1 2012-05-30 Jim Meyering <meyering@redhat.com>
3 * callproc.c (Fcall_process_region): Include directory component
4 in mkstemp error message (Bug#11586).
6 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
8 * alloc.c, lisp.h (make_pure_vector): Now static.
10 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
12 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
14 (Fautoload): Do the hash-doc more carefully.
15 * data.c (Fdefalias): Purify definition, except for keymaps.
16 (Qdefun): Move from eval.c.
17 * lisp.h (Qdefun): Remove.
18 * lread.c (read1): Tiny simplification.
20 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
22 Do not create empty overlays with the evaporate property (Bug#9642).
23 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
24 Bug#9642, but explicitly check that the buffer the overlay would
25 be moved to is live and rearrange lines to make sure that errors
26 will not put the overlay in an inconsistent state.
27 (Fdelete_overlay): Cosmetics.
29 2012-05-28 Eli Zaretskii <eliz@gnu.org>
31 * w32term.c (my_bring_window_to_top): New function.
32 (x_raise_frame): Use handle returned by DeferWindowPos, which
33 could be different from the original one.
34 Call my_bring_window_to_top instead of my_set_foreground_window.
37 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
38 by calling BringWindowToTop.
40 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
41 (WM_EMACS_END): Increase by one.
43 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
45 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
46 This avoids undefined behavior that might cause the eassert
47 to not catch an out-of-range value.
49 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
51 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
54 2012-05-27 Eli Zaretskii <eliz@gnu.org>
56 * bidi.c (bidi_mirror_char): Fix last change.
58 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
60 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
61 when referring to sectname field in printf format.
63 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
65 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
66 Only r_alloc_inhibit_buffer_relocation needed to be added;
67 the others were already declared.
69 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
70 before checking whether it's out of range. Put the check inside
72 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
74 2012-05-27 Ken Brown <kbrown@cornell.edu>
76 * callproc.c (Fcall_process): Restore a line that was accidentally
77 commented out in the 2011-02-13 change (bug#11547).
79 2012-05-27 Eli Zaretskii <eliz@gnu.org>
81 * lisp.h [REL_ALLOC]: Add prototypes for external functions
84 * buffer.c [REL_ALLOC]: Remove prototypes of
85 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
86 they are now on lisp.h.
88 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
90 * search.c (search_buffer): Use it to inhibit relocation of buffer
91 text while re_search_2 is doing its job, because re_search_2 is
92 passed C pointers to buffer text. (Bug#11519)
94 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
97 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
98 state after an additional call to move_it_in_display_line_to, keep
99 the values of it->max_ascent and it->max_descent found for the
101 (pos_visible_p): Revert the comparison against bottom_y to what it
102 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
105 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
107 Fix coding-related core dumps with gcc -ftrapv.
108 The code was computing A - B, where A and B are pointers, and B is
109 random garbage. This can lead to core dumps on platforms that
110 have special pointer registers, and it also leads to core dumps on
111 x86-64 when compiled with gcc -ftrapv. The fix is to compute
112 A - B only when B is initialized properly.
113 * coding.c (coding_set_source, coding_set_destination): Return void.
114 (coding_change_source, coding_change_destinations): New functions,
115 with the old behaviors of coding_set_source and coding_set_destination.
116 All callers that need an offset changed to use these new functions.
118 2012-05-26 Glenn Morris <rgm@gnu.org>
120 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
122 2012-05-26 Eli Zaretskii <eliz@gnu.org>
124 Extend mouse support on W32 text-mode console.
125 * xdisp.c (draw_row_with_mouse_face):
126 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
128 * w32console.c: Include window.h.
129 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
131 (initialize_w32_display): Initialize mouse-highlight data.
133 * w32inevt.c: Include termchar.h and window.h.
134 (do_mouse_event): Support mouse-autoselect-window. When the mouse
135 moves, call note_mouse_highlight. If help_echo changed, call
136 gen_help_event to produce help-echo message in the echo area.
137 Call clear_mouse_face if mouse_face_hidden is set in the mouse
140 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
142 * lread.c (read1): Simplify slightly to avoid an overflow warning
143 with GCC 4.7.0 on x86-64.
145 2012-05-26 Eli Zaretskii <eliz@gnu.org>
147 * bidi.c (bidi_mirror_char): Revert last change: an int is
148 definitely wide enough here.
150 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
152 Fix integer width and related bugs (Bug#9874).
153 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
154 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
155 (string_bytes, check_sblock, allocate_string_data):
156 (compact_small_strings, Fmake_bool_vector, make_string)
157 (make_unibyte_string, make_multibyte_string)
158 (make_string_from_bytes, make_specified_string)
159 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
160 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
163 (allocate_pseudovector):
164 Use int, not EMACS_INT, where int is wide enough.
165 (inhibit_garbage_collection, Fgarbage_collect):
166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
167 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
168 int might not be wide enough.
169 (bidi_cache_search, bidi_cache_find, bidi_init_it)
170 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
171 (bidi_at_paragraph_end, bidi_find_paragraph_start)
172 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
173 (bidi_level_of_next_char, bidi_move_to_visually_next):
174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
175 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
176 (Fkill_buffer, Fset_buffer_major_mode)
177 (advance_to_char_boundary, Fbuffer_swap_text)
178 (Fset_buffer_multibyte, overlays_at, overlays_in)
179 (overlay_touches_p, struct sortvec, record_overlay_string)
180 (overlay_strings, recenter_overlay_lists)
181 (adjust_overlays_for_insert, adjust_overlays_for_delete)
182 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
183 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
184 (Foverlay_recenter, last_overlay_modification_hooks_used)
185 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
187 (validate_region): Omit unnecessary test for b <= e,
188 since that's guaranteed by the previous test.
189 (adjust_overlays_for_delete): Avoid pos + length overflow.
190 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
191 (report_overlay_modification):
192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
193 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
194 Omit pointer cast, which isn't needed anyway, and doesn't work
195 after the EMACS_INT -> ptrdiff_t change.
196 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
197 * buffer.h: Adjust decls to match defn changes elsewhere.
198 (struct buffer_text, struct buffer):
199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
200 Use EMACS_INT, not int, where int might not be wide enough.
201 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
202 not int, to avoid needless 32-bit limit on 64-bit hosts.
203 (exec_byte_code): Use tighter memory-full test, one that checks
204 for alloca overflow. Don't compute the address of the object just
205 before an array, as that's not portable. Use EMACS_INT, not
206 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
207 * callint.c (Fcall_interactively):
208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
209 * callproc.c (call_process_kill, Fcall_process):
210 Don't assume pid_t fits into an Emacs fixnum.
211 (call_process_cleanup, Fcall_process, child_setup):
212 Don't assume pid_t fits into int.
213 (call_process_cleanup, Fcall_process, delete_temp_file)
214 (Fcall_process_region):
215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
216 (Fcall_process): Simplify handling of volatile integers.
217 Use int, not EMACS_INT, where int will do.
218 * casefiddle.c (casify_object, casify_region, operate_on_word)
219 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
221 (casify_object): Avoid integer overflow when overallocating buffer.
222 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
223 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
224 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
225 * category.h (CATEGORYP): Don't assume arg is nonnegative.
226 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
227 integers are now checked earlier. All uses replaced with XINT.
229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
230 For CCL_MapSingle, check that content and value are in int range.
231 (ccl_driver, Fregister_code_conversion_map):
232 Check that Vcode_version_map_vector is a vector.
233 (resolve_symbol_ccl_program): Check that vector header is in range.
234 Always copy the vector, so that we can check its contents reliably
235 now rather than having to recheck each instruction as it's being
236 executed. Check that vector words fit in 'int'.
237 (ccl_get_compiled_code, Fregister_ccl_program)
238 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
239 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
240 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
241 contents are in range.
242 (Fccl_execute_on_string): Check that status is in range.
243 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
244 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
245 Accept and return EMACS_INT, not int, because callers can pass values
247 (c_string_width, strwidth, lisp_string_width, chars_in_text)
248 (multibyte_chars_in_text, parse_str_as_multibyte)
249 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
250 (str_as_unibyte, str_to_unibyte, string_count_byte8)
251 (string_escape_byte8, Fget_byte):
252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
253 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
254 avoid mishandling large integers.
255 * character.h: Adjust decls to match defn changes elsewhere.
256 * charset.c (load_charset_map_from_file, find_charsets_in_text)
257 (Ffind_charset_region):
258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
259 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
260 (load_charset_map_from_vector, Fdefine_charset_internal):
261 Don't assume fixnum fits in int.
262 (load_charset_map_from_vector, Fmap_charset_chars):
263 Remove now-unnecessary CHECK_NATNUMs.
264 (Fdefine_charset_internal): Check ranges here, more carefully.
265 Don't rely on undefined behavior with signed left shift overflow.
266 Don't assume unsigned int fits into fixnum, or that fixnum fits
267 into unsigned int. Don't require max_code to be a valid fixnum;
268 that's not true for gb10830 4-byte on a 32-bit host. Allow
269 invalid_code to be a cons, for the same reason. Require code_offset
270 to be a character. Avoid int overflow if max_char is close
272 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
273 this is intended anyway and avoids some undefined behavior.
274 (load_charset_map): Pass unsigned, not int, as 2nd arg of
275 INDEX_TO_CODE_POINT, as that's what it expects.
276 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
277 * charset.h (DECODE_CHAR): Return int, not unsigned;
278 this is what was intended anyway, and it avoids undefined behavior.
279 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
280 integer-overflow issues.
281 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
282 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
283 where the argument is EMACS_INT, and this behavior is not intended.
284 * chartab.c (Fmake_char_table, Fset_char_table_range)
285 (uniprop_get_decoder, uniprop_get_encoder):
286 Don't assume fixnum fits in int.
287 * cmds.c (move_point): New function, that does the gist of
288 Fforward_char and Fbackward_char, but does so while checking
289 for integer overflow more accurately.
290 (Fforward_char, Fbackward_char): Use it.
291 (Fforward_line, Fend_of_line, internal_self_insert)
292 (internal_self_insert):
293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
294 Fix a FIXME, by checking for integer overflow when calculating
295 target_clm and actual_clm.
296 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
297 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
298 (ASSURE_DESTINATION, coding_alloc_by_realloc)
299 (coding_alloc_by_making_gap, alloc_destination)
300 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
301 (encode_coding_utf_16, detect_coding_emacs_mule)
302 (decode_coding_emacs_mule, encode_coding_emacs_mule)
303 (detect_coding_iso_2022, decode_coding_iso_2022)
304 (encode_invocation_designation, encode_designation_at_bol)
305 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
306 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
307 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
308 (encode_coding_ccl, encode_coding_raw_text)
309 (detect_coding_charset, decode_coding_charset)
310 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
311 (produce_composition, produce_charset, produce_annotation)
312 (decode_coding, handle_composition_annotation)
313 (handle_charset_annotation, consume_chars, decode_coding_gap)
314 (decode_coding_object, encode_coding_object, detect_coding_system)
315 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
316 (code_convert_region, code_convert_string)
317 (Fdefine_coding_system_internal)
318 (coding_set_source, coding_set_destination):
319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
320 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
321 (Fdefine_coding_system_internal):
322 Don't assume fixnums fit in int.
323 (decode_coding_gap, decode_coding_object, encode_coding_object)
324 (Fread_coding_system, Fdetect_coding_region)
325 (Funencodable_char_position, Fcheck_coding_systems_region)
326 (get_translation, handle_composition_annotation, consume_chars):
327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
328 (consume_chars): Rewrite to not calculate an address outside buffer.
329 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
330 Don't access memory outside of the args array.
331 (Fdefine_coding_system_internal): Check for charset-id overflow.
332 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
333 result of ENCODE_CHAR.
334 * coding.h: Adjust decls to match defn changes elsewhere.
335 (struct coding_system):
336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
337 * composite.c (get_composition_id, find_composition)
338 (run_composition_function, update_compositions)
339 (compose_text, composition_gstring_put_cache)
340 (composition_gstring_p, composition_gstring_width)
341 (fill_gstring_header, fill_gstring_body, autocmp_chars)
342 (composition_compute_stop_pos, composition_reseat_it)
343 (composition_update_it, struct position_record)
344 (find_automatic_composition, composition_adjust_point)
345 (Fcomposition_get_gstring, Ffind_composition_internal):
346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
347 (update_compositions):
348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
349 * composite.h: Adjust decls to match defn changes elsewhere.
350 (struct composition):
351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
352 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
353 Do not attempt to compute the address of the object just before a
354 buffer; this is not portable.
356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
357 (Faset): Use int, not EMACS_INT, where int is wide enough.
358 (Fstring_to_number): Don't assume fixnums fit in int.
359 (Frem): Don't assume arg is nonnegative.
360 * dbusbind.c (xd_append_arg): Check for integers out of range.
361 (Fdbus_call_method): Don't overflow the timeout int.
362 (extract_signed, extract_unsigned): New functions.
363 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
364 (xd_get_connection_references): Return ptrdiff_t, not int.
366 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
368 Use int, not unsigned, where the dbus API uses int.
369 (Fdbus_message_internal): Don't overflow mtype.
370 (syms_of_dbusbind): Allocate right-sized buffer for integers.
371 * dired.c (directory_files_internal, file_name_completion, scmp)
372 (file_name_completion_stat):
373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
374 (file_name_completion): Don't overflow matchcount.
375 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
376 * dispextern.h: Adjust decls to match defn changes elsewhere.
377 (struct text_pos, struct glyph, struct bidi_saved_info)
378 (struct bidi_string_data, struct bidi_it, struct composition_it)
380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
381 (struct display_pos, struct composition_it, struct it):
382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
383 * dispnew.c (increment_matrix_positions)
384 (increment_row_positions, mode_line_string)
385 (marginal_area_string):
386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
387 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
389 (duration_to_sec_usec): New function, to check for overflow better.
390 (Fsleep_for, sit_for): Use it.
391 * doc.c (get_doc_string, store_function_docstring):
392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
393 (get_doc_string, Fsnarf_documentation):
394 Use int, not EMACS_INT, where int is wide enough.
396 Use SAFE_ALLOCA, not alloca.
397 Check for overflow when converting EMACS_INT to off_t.
399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
400 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
401 Don't assume uid_t fits into fixnum.
402 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
403 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
404 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
405 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
406 (general_insert_function)
407 (Finsert_char, make_buffer_string, make_buffer_string_both)
408 (update_buffer_properties, Fbuffer_substring)
409 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
410 (Fsubst_char_in_region, check_translation)
411 (Ftranslate_region_internal, save_restriction_restore, Fformat)
412 (transpose_markers, Ftranspose_regions):
413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
414 (clip_to_bounds): Move to lisp.h as an inline function).
415 (Fconstrain_to_field): Don't assume integers are nonnegative.
416 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
417 (Fsubst_char_in_region, Fsave_restriction):
418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
419 (Femacs_pid): Don't assume pid_t fits into fixnum.
420 (lo_time): Use int, not EMACS_INT, when int suffices.
421 (lisp_time_argument): Check for usec out of range.
422 (Fencode_time): Don't assume fixnum fits in int.
423 (Fuser_login_name, Fuser_full_name): Signal an error
424 if a uid argument is out of range, rather than relying on
426 (Fformat_time_string): Remove now-unnecessary check.
427 lisp_time_argument checks for out-of-range usec now.
428 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
429 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
430 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
431 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
432 (init_cmdargs, Fdump_emacs):
433 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
434 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
435 the bottom (typically) 32 bits of the fixnum.
436 * eval.c (specpdl_size, call_debugger):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 (when_entered_debugger, Fbacktrace_debug):
439 Don't assume fixnum can fit in int.
440 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
441 the object just before a buffer; this is not portable.
442 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
443 (grow_specpdl, unbind_to):
444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
445 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
446 (grow_specpdl): Simplify allocation by using xpalloc.
447 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
448 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
449 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
451 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
454 (Fcopy_file, non_regular_nbytes, read_non_regular)
455 (Finsert_file_contents):
456 Use int, not EMACS_INT, where int is wide enough.
457 (READ_BUF_SIZE): Verify that it fits in int.
458 (Finsert_file_contents): Check that counts are in proper range,
459 rather than assuming fixnums fit into ptrdiff_t etc.
460 Don't assume fixnums fit into int.
461 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
462 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
463 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
464 (string_char_to_byte, string_byte_to_char)
465 (string_make_multibyte, string_to_multibyte)
466 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
467 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
468 (substring_both, Fdelete, internal_equal, Ffillarray)
469 (Fclear_string, mapcar1)
470 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
471 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
472 (larger_vector, make_hash_table, maybe_resize_hash_table)
473 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
474 (Fmaphash, secure_hash):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (concat): Check for string index and length overflow.
477 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
479 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
480 (larger_vector): New API (vec, incr_min, size_max) replaces old
481 one (vec, new_size, init). This catches size overflow.
482 INIT was removed because it was always Qnil.
484 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
485 the upper bound on a hash table index size.
486 (make_hash_table, maybe_resize_hash_table): Use it.
487 (secure_hash): Computer start_byte and end_byte only after
488 they're known to be in ptrdiff_t range.
489 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
490 (Ffont_get_glyphs, Ffont_at):
491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
492 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
493 (Flist_fonts, Fopen_font):
494 Don't assume fixnum can fit in int.
495 (check_gstring): Don't assume index can fit in int.
496 (font_match_p): Check that fixnum is a character, not a nonnegative
497 fixnum, since the later code needs to stuff it into an int.
498 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
499 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
500 conversion overflow issues.
501 (Fopen_font): Check for integer out of range.
502 (Ffont_get_glyphs): Don't assume index can fit in int.
503 * font.h: Adjust decls to match defn changes elsewhere.
504 * fontset.c (reorder_font_vector): Redo score calculation to avoid
506 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
507 printmax_t, where ptrdiff_t is wide enough.
508 (Finternal_char_font):
509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
510 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
511 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
512 (Fset_frame_position, x_set_frame_parameters)
513 (x_set_line_spacing, x_set_border_width)
514 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
515 Check that fixnums are in proper range for system types.
516 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
518 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
519 Use SAFE_ALLOCA_LISP, not alloca.
520 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
521 intptr_t is wide enough.
522 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
523 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
524 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
525 Check for fixnum out of range.
526 * ftfont.c (ftfont_list): Don't assume index fits in int.
527 Check that fixnums are in proper range for system types.
528 (ftfont_shape_by_flt):
529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
530 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
532 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
533 Check that fixnums are in proper range for system types.
534 * gnutls.h: Adjust decls to match defn changes elsewhere.
535 * gtkutil.c (xg_dialog_run):
536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
537 (update_frame_tool_bar):
538 Check that fixnums are in proper range for system types.
539 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
540 (lookup_image): Check that fixnums are in range for system types.
541 * indent.c (last_known_column, last_known_column_point):
542 (current_column_bol_cache):
543 (skip_invisible, current_column, check_display_width):
544 (check_display_width, scan_for_column, current_column_1)
545 (Findent_to, Fcurrent_indentation, position_indentation)
546 (indented_beyond_p, Fmove_to_column, compute_motion):
547 (Fcompute_motion, Fvertical_motion):
548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
549 (last_known_column_modified): Use EMACS_INT, not int.
550 (check_display_width):
552 Check that fixnums and floats are in proper range for system types.
553 (compute_motion): Don't assume index or fixnum fits in int.
554 (compute_motion, Fcompute_motion):
555 Use int, not EMACS_INT, when it is wide enough.
556 (vmotion): Omit local var start_hpos that is always 0; that way
557 we don't need to worry about overflow in expressions involving it.
558 * indent.h: Adjust decls to match defn changes elsewhere.
560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
561 Use int, not EMACS_INT, where int is wide enough.
562 Remove unused members ovstring_chars_done and tab_offset;
564 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
565 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
566 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
567 (make_gap, copy_text, insert, insert_and_inherit)
568 (insert_before_markers, insert_before_markers_and_inherit)
569 (insert_1, count_combining_before, count_combining_after)
570 (insert_1_both, insert_from_string)
571 (insert_from_string_before_markers, insert_from_string_1)
572 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
573 (adjust_after_replace, adjust_after_insert, replace_range)
574 (replace_range_2, del_range, del_range_1, del_range_byte)
575 (del_range_both, del_range_2, modify_region)
576 (prepare_to_modify_buffer, signal_before_change)
577 (signal_after_change, Fcombine_after_change_execute):
578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
579 * intervals.c (traverse_intervals, rotate_right, rotate_left)
580 (balance_an_interval, split_interval_right, split_interval_left)
581 (find_interval, next_interval, update_interval)
582 (adjust_intervals_for_insertion, delete_node, delete_interval)
583 (interval_deletion_adjustment, adjust_intervals_for_deletion)
584 (static_offset_intervals, offset_intervals)
585 (merge_interval_right, merge_interval_left, make_new_interval)
586 (graft_intervals_into_buffer, temp_set_point_both)
587 (temp_set_point, set_point, adjust_for_invis_intang)
588 (set_point_both, move_if_not_intangible, get_property_and_range)
589 (get_local_map, copy_intervals, copy_intervals_to_string)
590 (compare_string_intervals, set_intervals_multibyte_1):
591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
592 * intervals.h: Adjust decls to match defn changes elsewhere.
594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
595 * keyboard.c (this_command_key_count, this_single_command_key_start)
596 (before_command_key_count, before_command_echo_length, echo_now)
597 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
598 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
599 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
600 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
602 (last_non_minibuf_size, last_point_position, echo_truncate)
603 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
604 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
605 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
606 (stuff_buffered_input):
607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
608 (last_auto_save, command_loop_1, read_char):
609 Use EMACS_INT, not int, to avoid integer overflow.
610 (record_char): Avoid overflow in total_keys computation.
611 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
612 * keyboard.h: Adjust decls to match defn changes elsewhere.
613 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
614 (Fkey_description, Fdescribe_vector, Flookup_key):
615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
616 (click_position): New function, to check that positions are in range.
617 (Fcurrent_active_maps):
619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
620 (Faccessible_keymaps, Fkey_description):
621 (preferred_sequence_p):
622 Don't assume fixnum can fit into int.
623 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
624 Check for integer overflow in size calculations.
625 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
626 avoid mishandling large integers.
627 * lisp.h: Adjust decls to match defn changes elsewhere.
628 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
629 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
630 (struct Lisp_Marker):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (clip_to_bounds): Now an inline function, moved here from editfns.c.
633 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
634 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
636 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
637 Assume the arg has valid form, since it always does.
638 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
639 unsigned integer system type.
640 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
641 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
643 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
644 (duration_to_sec_usec): New decl.
645 * lread.c (read_from_string_index, read_from_string_index_byte)
646 (read_from_string_limit, readchar, unreadchar, openp)
647 (read_internal_start, read1, oblookup):
648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
649 (Fload, readevalloop, Feval_buffer, Feval_region):
650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
651 (openp): Check for out-of-range argument to 'access'.
652 (read1): Use int, not EMACS_INT, where int is wide enough.
653 Don't assume fixnum fits into int.
654 Fix off-by-one error that can read outside a buffer.
655 (read_filtered_event): Use duration_to_sec_usec
656 to do proper overflow checking on durations.
657 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
659 (Fexecute_kbd_macro):
660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
661 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
662 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
663 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
664 (set_marker_both, set_marker_restricted_both, marker_position)
665 (marker_byte_position, Fbuffer_has_markers_at):
666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
667 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
668 * menu.c (ensure_menu_items): Rename from grow_menu_items.
669 It now merely ensures that the menu is large enough, without
670 necessarily growing it, as this avoids some integer overflow issues.
672 (keymap_panes, parse_single_submenu, Fx_popup_menu):
673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
674 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
675 Use SAFE_ALLOCA_LISP, not alloca.
676 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
677 to EMACS_INT. Check that fixnums are in proper range for system types.
678 * minibuf.c (minibuf_prompt_width, string_to_object)
679 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
680 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
682 (get_minibuffer, read_minibuf_unwind):
683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
684 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
685 this simplifies overflow checking. All callers changed.
686 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
689 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
690 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
691 Check that fixnums are in proper range for system types.
692 (Fx_create_frame, Fx_show_tip):
693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
694 * nsfont.m (ns_findfonts, nsfont_list_family):
695 Don't assume fixnum fits in long.
696 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
697 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
698 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
700 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
702 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
703 (PRINTDECLARE, PRINTPREPARE):
704 (strout, print_string):
705 (print, print_preprocess, print_check_string_charset_prop)
707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
709 (temp_output_buffer_setup, Fprin1_to_string, print_object):
710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
711 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
712 (printchar, strout): Use xpalloc to catch size calculation overflow.
713 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
714 (print_error_message): Use SAFE_ALLOCA, not alloca.
715 (print_object): Use int, not EMACS_INT, where int is wide enough.
716 (print_depth, new_backquote_output, print_number_index):
717 Use ptrdiff_t, not int, where int might not be wide enough.
718 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
719 (Fset_process_window_size, Fformat_network_address)
720 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
722 Check that fixnums are in proper range for system types.
723 (Fsignal_process): Simplify by avoiding a goto.
724 Check for process-ids out of pid_t range rather than relying on
726 (process_tick, update_tick): Use EMACS_INT, not int.
727 (Fformat_network_address, read_process_output, send_process)
728 (Fprocess_send_region, status_notify):
729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
730 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
731 (wait_reading_process_output, read_process_output, exec_sentinel):
732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
733 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
734 (Faccept_process_output): Use duration_to_sec_usec to do proper
735 overflow checking on durations.
736 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
737 Don't assume pid_t fits in int.
738 * process.h (struct Lisp_Process): Members tick and update_tick
739 are now of type EMACS_INT, not int.
740 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
741 configured --with-wide-int.
742 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
743 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
744 * search.c (looking_at_1, string_match_1):
745 (fast_string_match, fast_c_string_match_ignore_case)
746 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
747 (scan_newline, find_before_next_newline, search_command)
748 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
749 (set_search_regs, wordify):
752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
753 (string_match_1, search_buffer, set_search_regs):
755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
756 (wordify): Check for overflow in size calculation.
757 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
758 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
759 Check that fixnums are in proper range for system types.
760 * sound.c (struct sound_device)
761 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
763 (Fplay_sound_internal):
764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
765 * syntax.c (struct lisp_parse_state, find_start_modiff)
766 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
767 (Fparse_partial_sexp):
768 Don't assume fixnums can fit in int.
769 (struct lisp_parse_state, find_start_pos, find_start_value)
770 (find_start_value_byte, find_start_begv)
771 (update_syntax_table, char_quoted, dec_bytepos)
772 (find_defun_start, prev_char_comend_first, back_comment):
773 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
774 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
776 (Finternal_describe_syntax_value): Check that match_lisp is a
777 character, not an integer, since the code stuffs it into int.
778 (scan_words, scan_sexps_forward):
779 Check that fixnums are in proper range for system types.
781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
782 (scan_sexps_forward):
783 Use CHARACTERP, not INTEGERP, since the value must fit into int.
784 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
785 * syntax.h: Adjust decls to match defn changes elsewhere.
787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
788 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
789 MOST_POSITIVE_FIXNUM.
790 * sysdep.c (wait_for_termination_1, wait_for_termination)
791 (interruptible_wait_for_termination, mkdir):
792 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
793 (emacs_read, emacs_write):
794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
795 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
796 and double all fit in int.
797 * term.c (set_tty_color_mode):
798 Check that fixnums are in proper range for system types.
799 * termhooks.h (struct input_event):
800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
801 * textprop.c (validate_interval_range, interval_of)
802 (Fadd_text_properties, set_text_properties_1)
803 (Fremove_text_properties, Fremove_list_of_text_properties)
804 (Ftext_property_any, Ftext_property_not_all)
805 (copy_text_properties, text_property_list, extend_property_ranges)
806 (verify_interval_modification):
807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
808 (Fnext_single_char_property_change)
809 (Fprevious_single_char_property_change):
810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
811 (copy_text_properties):
812 Check for integer overflow in index calculation.
813 * undo.c (last_boundary_position, record_point, record_insert)
814 (record_delete, record_marker_adjustment, record_change)
815 (record_property_change):
816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
817 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
819 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
820 (Fx_hide_tip, Fx_file_dialog):
821 * w32menu.c (set_frame_menubar):
822 Use ptrdiff_t, not int, for consistency with rest of code.
823 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
824 (select_window, Fdelete_other_windows_internal)
825 (window_scroll_pixel_based, window_scroll_line_based)
826 (Frecenter, Fset_window_configuration):
827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
828 (Fset_window_hscroll, run_window_configuration_change_hook)
829 (set_window_buffer, temp_output_buffer_show, scroll_command)
830 (Fscroll_other_window, Frecenter):
831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
832 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
833 Don't assume fixnum fits in int.
834 (Fset_window_scroll_bars):
835 Check that fixnums are in proper range for system types.
836 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
837 (string_pos, c_string_pos, number_of_chars, init_iterator)
838 (in_ellipses_for_invisible_text_p, init_from_display_pos)
839 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
840 (compute_display_string_end, handle_face_prop)
841 (face_before_or_after_it_pos, handle_invisible_prop)
842 (handle_display_prop, handle_display_spec, handle_single_display_spec)
843 (display_prop_intangible_p, string_buffer_position_lim)
844 (string_buffer_position, handle_composition_prop, load_overlay_strings)
845 (get_overlay_strings_1, get_overlay_strings)
846 (iterate_out_of_display_property, forward_to_next_line_start)
847 (back_to_previous_visible_line_start, reseat, reseat_to_string)
848 (get_next_display_element, set_iterator_to_next)
849 (get_visually_first_element, compute_stop_pos_backwards)
850 (handle_stop_backwards, next_element_from_buffer)
851 (move_it_in_display_line_to, move_it_in_display_line)
852 (move_it_to, move_it_vertically_backward, move_it_by_lines)
853 (add_to_log, message_dolog, message_log_check_duplicate)
854 (message2, message2_nolog, message3, message3_nolog
855 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
856 (current_message_1, truncate_echo_area, truncate_message_1)
857 (set_message, set_message_1, store_mode_line_noprop)
858 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
859 (text_outside_line_unchanged_p, check_point_in_composition)
860 (reconsider_clip_changes)
861 (redisplay_internal, set_cursor_from_row, try_scrolling)
862 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
863 (redisplay_window, find_last_unchanged_at_beg_row)
864 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
865 (trailing_whitespace_p, find_row_edges, display_line)
866 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
867 (display_mode_element, store_mode_line_string)
868 (pint2str, pint2hrstr, decode_mode_spec)
869 (display_count_lines, display_string, draw_glyphs)
870 (x_produce_glyphs, x_insert_glyphs)
871 (rows_from_pos_range, mouse_face_from_buffer_pos)
872 (fast_find_string_pos, mouse_face_from_string_pos)
873 (note_mode_line_or_margin_highlight, note_mouse_highlight):
874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
875 (safe_call, init_from_display_pos, handle_fontified_prop)
876 (handle_single_display_spec, load_overlay_strings)
877 (with_echo_area_buffer, setup_echo_area_for_printing)
878 (display_echo_area, echo_area_display)
879 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
880 (update_tool_bar, hscroll_window_tree, redisplay_internal)
881 (redisplay_window, dump_glyph_row, display_mode_line)
882 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
883 (handle_display_spec, display_prop_string_p):
884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
885 (handle_single_display_spec, build_desired_tool_bar_string)
886 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
887 (get_specified_cursor_type):
888 Check that fixnums are in proper range for system types.
889 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
891 Don't assume fixnums fit in int.
892 (compare_overlay_entries):
893 Avoid mishandling comparisons due to subtraction overflow.
894 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
895 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
896 (handle_tool_bar_click):
897 Use int, not unsigned, since we prefer signed and the signedness
899 (get_next_display_element, next_element_from_display_vector):
900 Use int, not EMACS_INT, when int is wide enough.
901 (start_hourglass): Use duration_to_sec_usec to do proper
902 overflow checking on durations.
903 * xfaces.c (Fbitmap_spec_p):
904 Check that fixnums are in proper range for system types.
905 (compare_fonts_by_sort_order):
906 Avoid mishandling comparisons due to subtraction overflow.
907 (Fx_family_fonts, realize_basic_faces):
908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
910 Don't assume fixnum fits in int.
911 Use SAFE_ALLOCA_LISP, not alloca.
912 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
913 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
914 (face_at_buffer_position, face_for_overlay_string)
915 (face_at_string_position):
916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
917 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
918 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
920 Check that fixnums are in proper range for system types.
921 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
922 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
924 (Fx_change_window_property): Don't assume fixnums fit in int.
925 * xfont.c (xfont_chars_supported):
926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
927 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
928 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
930 * xml.c (parse_region):
931 * xrdb.c (magic_file_p):
932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
933 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
934 (x_get_local_selection, x_reply_selection_request)
935 (x_handle_selection_request, wait_for_property_change):
936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
937 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
938 short is wide enough.
939 (x_send_client_event): Don't assume fixnum fits in int.
940 * xterm.c (x_x_to_emacs_modifiers):
941 Don't assume EMACS_INT overflows nicely into int.
942 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
944 (handle_one_xevent): NATNUMP can eval its arg twice.
945 (x_connection_closed):
946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
947 * xterm.h: Adjust decls to match defn changes elsewhere.
948 (struct scroll_bar): Use struct vectorlike_header
949 rather than rolling our own approximation.
950 (SCROLL_BAR_VEC_SIZE): Remove; not used.
952 2012-05-25 Glenn Morris <rgm@gnu.org>
954 * lisp.mk (lisp): Update for more files being compiled now.
956 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
958 * lread.c: Remove `read_pure' which makes no difference.
959 (read_pure): Remove var.
960 (unreadpure): Remove function.
961 (readevalloop): Don't call read_list with -1 flag.
962 (read1, read_vector): Don't test read_pure any more.
963 (read_list): Simplify.
965 * fileio.c, character.h: Minor style tweaks.
967 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
969 * window.h (clip_changed): Remove useless declaration.
971 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
973 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
974 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
976 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
979 This directory predates autoconf and is no longer needed nowadays.
980 Move its few remaining bits of functionality to where they're needed.
981 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
982 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
983 * m/template.h: Remove.
984 * Makefile.in (M_FILE): Remove. All uses removed.
985 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
986 * lisp.h (USE_LSB_TAG):
987 * mem-limits.h (EXCEEDS_LISP_PTR):
988 Use VAL_MAX, not VALBITS, in #if.
989 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
990 (EMACS_UINT): Define unconditionally now.
991 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
992 (BITS_PER_EMACS_INT): New constants, replacing
993 what used to be in config.h, but not useful in #if.
994 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
995 define them any more.
996 (VAL_MAX): New macro.
998 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
999 BITS_PER_EMACS_INT, in #if.
1000 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1001 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1002 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1003 * s/ms-w32.h (DATA_START):
1004 Move here from removed file m/intel386.h.
1005 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1006 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1008 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1010 Assume C89 or later.
1011 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1012 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1014 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1015 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1016 * textprop.c, tparam.c (NULL): Remove.
1017 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1018 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1019 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1020 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1021 * xterm.c (input_signal_count): Assume volatile works.
1023 2012-05-21 Ken Brown <kbrown@cornell.edu>
1025 * xgselect.c (xg_select): Fix first argument in call to 'select'
1028 2012-05-20 Ken Brown <kbrown@cornell.edu>
1030 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1031 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1033 2012-05-19 Ken Brown <kbrown@cornell.edu>
1035 * xfns.c (x_in_use): Remove `static' qualifier.
1036 * xterm.h (x_in_use): Declare.
1037 * xgselect.c: Include xterm.h.
1038 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1039 and `display_arg' (bug#9754).
1041 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1043 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1045 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1046 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1048 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1050 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1052 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1053 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1055 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1056 reference to image_cache->refcount.
1057 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1059 2012-05-17 Juri Linkov <juri@jurta.org>
1061 * search.c (Fword_search_regexp, Fword_search_backward)
1062 (Fword_search_forward, Fword_search_backward_lax)
1063 (Fword_search_forward_lax): Move functions to isearch.el
1064 (bug#10145, bug#11381).
1066 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1068 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1070 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1072 * lread.c (init_obarray): Declare Qt and Qnil as special.
1074 2012-05-14 Glenn Morris <rgm@gnu.org>
1076 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1077 Put "libexec" before "bin", for the sake of init_callproc_1.
1079 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1081 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1083 * unexaix.c: Port to more-recent AIX compilers.
1084 (report_error, report_error_1, make_hdr, copy_sym)
1085 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1086 Make arguments const char *, not char *, to avoid violations of C
1087 standard and to fix some AIX warnings reported by Gilles Pion.
1089 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1091 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1092 already have overlays loaded.
1093 (handle_single_display_spec): Before returning without displaying
1094 fringe bitmap, synchronize the bidi iterator with the main display
1095 iterator, by calling iterate_out_of_display_property.
1096 (iterate_out_of_display_property): Detect buffer iteration by
1097 testing that it->string is a Lisp string.
1098 (get_next_display_element): When the current object is exhausted,
1099 and there's something on it->stack, call set_iterator_to_next to
1100 proceed with what's on the stack, instead of returning zero.
1101 (set_iterator_to_next): If called at the end of a Lisp string,
1102 proceed to consider_string_end without incrementing string
1103 position. Don't increment display vector index past the end of
1104 the display vector. (Bug#11417)
1105 (pos_visible_p): Don't report a position visible when move_it_to
1106 stopped at the last line of window, which happens to be scanned
1107 backwards by the bidi iteration. (Bug#11464)
1109 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1111 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1112 and right-margin display specs even if the spec is invalid or we
1113 are on a TTY, and thus unable to display on the fringes.
1114 That's because the text with the property will not be displayed anyway,
1115 so we need to signal to the caller that this is a "replacing"
1116 display spec. This fixes display when the spec is invalid or we
1119 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1121 * unexaix.c (make_hdr): Fix typo in prototype.
1122 This bug broke the build on AIX. Problem reported by Gilles Pion.
1124 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1126 * keyboard.c (kbd_buffer_get_event): Read special events also in
1127 batch mode. (Bug#11415)
1129 2012-05-12 Glenn Morris <rgm@gnu.org>
1131 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1133 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1135 * lisp.mk (lisp): Add newcomment.elc.
1137 2012-05-12 Glenn Morris <rgm@gnu.org>
1139 * Makefile.in (MKDIR_P): New, set by configure.
1140 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1142 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1144 Remove unused function hourglass_started.
1145 * dispextern.h (hourglass_started):
1146 * w32fns.c (hourglass_started):
1147 * xdisp.c (hourglass_started): Remove.
1149 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1151 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1152 Update dependencies.
1154 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1156 * xgselect.c (xg_select): Put maxfds+1 into a var.
1157 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1159 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1161 2012-05-10 Dave Abrahams <dave@boostpro.com>
1163 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1164 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1166 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1168 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1169 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1170 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1171 Initialize xd_registered_buses.
1173 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1175 Untag more efficiently if USE_LSB_TAG.
1176 This is based on a proposal by YAMAMOTO Mitsuharu in
1177 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1178 For an admittedly artificial (nth 8000 longlist) benchmark on
1179 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1180 Emacs's overall text size by 1%.
1181 * lisp.h (XUNTAG): New macro.
1182 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1183 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1184 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1185 * eval.c (Fautoload):
1186 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1187 * frame.h (XFRAME): Use XUNTAG.
1189 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1190 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1191 Remove unportable assumptions about print widths of types like
1193 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1194 intptr_t when converting between pointer and integer, to avoid GCC
1195 warnings about wrong width.
1197 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1199 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1200 stack for each reader_thread, instead of defaulting to 8MB
1201 determined by the linker. This avoids failures in creating
1202 subprocesses on Windows 7, see the discussion in this thread:
1203 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1205 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1207 Fix up display of the *Minibuf-0* buffer in the mini window.
1208 * keyboard.c (read_char): Don't clear the echo area if there's no
1210 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1211 contents of *Minibuf-0*) if there's no message displayed in its stead.
1213 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1215 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1218 2012-05-06 Chong Yidong <cyd@gnu.org>
1220 * lisp.mk (lisp): Update.
1222 2012-05-05 Jim Meyering <meyering@redhat.com>
1224 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1226 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1228 * data.c (PUT_ERROR): New macro.
1229 (syms_of_data): Use it. Add new error type `user-error'.
1230 * undo.c (user_error): New function.
1231 (Fprimitive_undo): Use it.
1232 * print.c (print_error_message): Adjust print style for `user-error'.
1233 * keyboard.c (user_error): New function.
1234 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1236 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1238 Do not limit current-time-string to years 1000..9999.
1239 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1240 (Fcurrent_time_string): Support any year that is supported by the
1241 underlying localtime representation. Don't use asctime, as it
1242 has undefined behavior for years outside the range -999..9999.
1244 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1246 Fix race conditions involving setenv, gmtime, localtime, asctime.
1247 Without this fix, interrupts could mess up code that uses these
1248 nonreentrant functions, since setting TZ invalidates existing
1249 tm_zone or tzname values, and since most of these functions return
1250 pointers to static storage.
1251 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1252 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1253 Grow the critical sections to include not just invoking
1254 localtime/gmtime, but also accessing these functions' results
1255 including their tm_zone values if any, and any related TZ setting.
1256 (format_time_string): Last arg is now struct tm *, not struct tm **,
1257 so that the struct tm is saved in the critical section.
1258 All callers changed. Simplify allocation of initial buffer, partly
1259 motivated by the fact that memory allocation needs to be outside
1260 the critical section.
1262 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1264 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1265 with RESET_INTERVAL.
1267 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1268 Remove duplicated buffer name initialization.
1270 2012-05-02 Jim Meyering <jim@meyering.net>
1272 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1274 * xfns.c (x_window): Use xstrdup (Bug#11375).
1276 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1278 * xdisp.c (pos_visible_p): If already at a newline from the
1279 display string before the 'while' loop, don't walk back the glyphs
1280 from it3.glyph_row. Solves assertion violation when the display
1281 string begins with a newline (egg.el). (Bug#11367)
1283 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1285 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1288 2012-05-01 Glenn Morris <rgm@gnu.org>
1290 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1291 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1292 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1293 All were removed before 23.1.
1295 * dispnew.c: Remove HAVE_LIBNCURSES test;
1296 it is always true on relevant platforms.
1298 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1299 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1301 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1303 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1305 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1306 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1309 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1311 Do not avoid creating empty evaporating overlays (Bug#9642).
1312 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1313 That is, do not delete an evaporating overlay if it becomes
1314 empty after its bounds are adjusted to fit within its buffer.
1315 This fix caused other problems, and I'm reverting it until we get
1316 to the bottom of them.
1318 2012-04-27 Chong Yidong <cyd@gnu.org>
1320 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1322 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1324 * xdisp.c (pos_visible_p): If the window start position is beyond
1325 ZV, start the display from buffer beginning. Prevents assertion
1326 violation in init_iterator when the minibuffer window is scrolled
1329 * window.c (window_scroll_pixel_based): Likewise.
1331 2012-04-27 Chong Yidong <cyd@gnu.org>
1333 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1335 2012-04-27 Glenn Morris <rgm@gnu.org>
1337 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1338 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1340 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1342 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1343 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1345 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1347 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1348 display element, check also the underlying string or buffer
1349 character. (Bug#11341)
1351 * w32menu.c: Include w32heap.h.
1352 (add_menu_item): If the call to AppendMenuW (via
1353 unicode_append_menu) fails, disable Unicode menus only if we are
1354 running on Windows 9X/Me.
1356 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1358 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1359 (xgetint): Add missing shift for LSB tags.
1361 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1363 * keyboard.c (read_char): Don't wipe echo area for select window
1364 events: These might get delayed via `mouse-autoselect-window'
1367 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1369 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1370 manipulation of :loaded-from data.
1372 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1374 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1375 now a cons (bug#11311).
1377 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1379 Do not create empty overlays with the evaporate property (Bug#9642).
1380 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1381 if it becomes empty after its bounds are adjusted to fit within
1382 its buffer. Without this fix, in a nonempty buffer (let ((o
1383 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1384 yields an empty overlay that has the evaporate property, which is
1385 not supposed to happen.
1387 Fix minor GTK3 problems found by static checking.
1388 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1389 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1390 (struct _EmacsFixedClass, emacs_fixed_get_type):
1391 Move decls here from emacsgtkfixed.h, since they needn't be public.
1392 (emacs_fixed_get_type): Now static.
1393 (emacs_fixed_class_init): Omit unused local.
1394 (emacs_fixed_child_type): Remove; unused.
1395 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1396 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1397 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1398 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1399 (EMACS_FIXED_GET_CLASS): Remove; unused.
1400 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1402 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1403 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1405 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1407 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1408 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1409 (__malloc_size_t, __malloc_ptrdiff_t):
1410 Remove. All uses removed, replaced by the definiens if needed,
1411 since we can assume C89 or better now.
1412 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1413 (protect_malloc_state, align, get_contiguous_space)
1414 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1415 (malloc_atfork_handler_child, malloc_enable_thread)
1416 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1417 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1418 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1419 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1420 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1421 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1422 Define using prototypes, not old style.
1423 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1424 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1425 (align): Don't assume that signed integer overflow wraps around.
1426 Omit unused local var.
1427 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1428 (_free_internal_nolock, memalign, mallochook, reallochook):
1429 Omit no-longer-needed casts.
1430 (valloc): Use getpagesize, not __getpagesize.
1431 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1432 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1434 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1436 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1438 Move functions from C to Lisp. Make non-blocking method calls
1439 the default. Implement further D-Bus standard interfaces.
1441 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1442 (QCdbus_request_name_allow_replacement)
1443 (QCdbus_request_name_replace_existing)
1444 (QCdbus_request_name_do_not_queue)
1445 (QCdbus_request_name_reply_primary_owner)
1446 (QCdbus_request_name_reply_in_queue)
1447 (QCdbus_request_name_reply_exists)
1448 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1449 (QCdbus_registered_serial, QCdbus_registered_method)
1450 (QCdbus_registered_signal): New Lisp objects.
1451 (XD_DEBUG_MESSAGE): Use sizeof.
1452 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1453 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1454 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1455 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1456 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1457 (xd_signature, xd_append_arg): Allow float for integer types.
1458 (xd_get_connection_references): New function.
1459 (xd_get_connection_address): Rename from xd_initialize.
1460 Return cached address.
1461 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1462 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1464 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1465 Return number of refcounts.
1466 (Fdbus_get_unique_name): Make stronger parameter check.
1467 (Fdbus_message_internal): New defun.
1468 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1469 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1470 (Fdbus_send_signal, Fdbus_register_service)
1471 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1472 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1473 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1474 (Vdbus_compiled_version, Vdbus_runtime_version)
1475 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1476 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1477 (Vdbus_message_type_signal): New defvars.
1478 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1481 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1483 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1484 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1485 Do not assume ptrdiff_t is the same width as 'int'.
1487 * alloc.c: Handle unusual debugging option combinations.
1488 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1489 since the two debugging options are incompatible.
1490 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1492 (mem_init, mem_insert, mem_insert_fixup):
1493 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1494 (NEED_MEM_INSERT): Remove; no longer needed.
1496 2012-04-22 Leo Liu <sdl.web@gmail.com>
1498 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1500 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1502 * sysdep.c [__FreeBSD__]: Minor cleanups.
1503 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1504 Use Emacs indenting style more consistently. Avoid some casts.
1505 Use 'double' consistently rather than mixing 'float' and 'double'.
1507 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1509 * sysdep.c (list_system_processes, system_process_attributes):
1510 Add implementation for FreeBSD (Bug#5243).
1512 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1514 * lisp.mk (lisp): Update.
1516 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1518 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1519 It is never used otherwise.
1521 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1523 * print.c (print_preprocess): Only check print_depth if print-circle
1525 (print_object): Check for cycles even when print-circle is nil and
1526 print-gensym is t, but only check print_depth if print-circle is nil.
1528 2012-04-20 Chong Yidong <cyd@gnu.org>
1530 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1531 set the status to "failed" and ensure that sentinel is run.
1533 2012-04-20 Glenn Morris <rgm@gnu.org>
1535 * process.c (Fset_process_inherit_coding_system_flag)
1536 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1537 (Fmake_network_process, Fmake_serial_process): Doc fix.
1539 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1541 * xdisp.c (string_buffer_position_lim): Limit starting position to
1543 (set_cursor_from_row): If called for a mode-line or header-line
1544 row, return zero immediately.
1545 (try_cursor_movement): If inside continuation line, don't back up
1546 farther than the first row after the header line, if any.
1547 Don't consider the header-line row as "partially visible", even if
1548 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1550 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1552 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1555 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1556 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1558 configure: new option --enable-gcc-warnings (Bug#11207)
1559 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1560 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1561 (ALL_CFLAGS): Use new macros rather than old.
1562 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1563 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1564 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1565 -Wunused-result, -Wunused-variable. This should go away once
1566 the Emacs and Gnulib regex code is merged.
1567 (xmalloc, xrealloc): Now static.
1569 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1571 * dired.c (Fsystem_groups): Remove unused local.
1573 2012-04-17 Glenn Morris <rgm@gnu.org>
1575 * dired.c (Fsystem_users): Doc fix.
1577 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1579 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1580 (syms_of_dired): Add them.
1582 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1584 Fix minor alloc.c problems found by static checking.
1585 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1586 New extern decls, to avoid calling undeclared functions.
1587 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1588 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1589 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1590 (NEED_MEM_INSERT): New macro.
1591 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1592 Remove one incorrect comment and fix another.
1594 Fix minor ralloc.c problems found by static checking.
1595 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1596 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1597 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1598 (r_alloc_sbrk): Now static.
1600 Improve ralloc.c interface checking.
1601 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1602 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1603 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1604 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1605 [REL_ALLOC]: ... to here, to check interface.
1606 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1607 Remove decls. This fixes an "It stinks!".
1609 * alloc.c (which_symbols): Fix alignment issue / type clash.
1611 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1613 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1614 (struct Lisp_Misc_Any): Likewise.
1615 (struct Lisp_Free): Likewise.
1616 * alloc.c (union aligned_Lisp_Symbol): Define.
1617 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1618 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1619 (union aligned_Lisp_Misc): Define.
1620 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1621 aligned_Lisp_Misc instead of union Lisp_Misc.
1622 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1624 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1626 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1627 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1628 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1629 * s/netbsd.h, s/sol2-6.h:
1630 Remove definition of GC_MARK_STACK, since the default now works.
1631 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1632 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1633 no longer the default.
1634 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1636 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1638 * lread.c (lisp_file_lexically_bound_p):
1639 Fix hang at ";-*-\n" (bug#11238).
1641 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1643 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1644 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1646 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1648 * nsterm.m (constrainFrameRect): Always constrain when there is only
1649 one screen (Bug#10962).
1651 2012-04-13 Ken Brown <kbrown@cornell.edu>
1653 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1655 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1657 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1659 2012-04-11 Daniel Colascione <dancol@dancol.org>
1661 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1662 against is gone. It's better to use vfork now so that when Cygwin
1663 gains a new, working vfork, we use it automatically (bug#10398).
1665 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1667 * window.c (save_window_save): Obey window-point-insertion-type.
1669 2012-04-11 Glenn Morris <rgm@gnu.org>
1671 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1673 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1675 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1677 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1679 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1680 (force_quit_count): New var.
1681 (handle_interrupt): Use it.
1683 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1685 * w32.c (w32_delayed_load): Record the full path of the library
1686 being loaded (bug#10424).
1688 2012-04-09 Glenn Morris <rgm@gnu.org>
1690 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1691 not just in the obarray, before snarfing them. (Bug#11036)
1693 * Makefile.in ($(leimdir)/leim-list.el):
1694 Pass EMACS rather than BUILT_EMACS.
1696 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1698 * process.c (make_process):
1699 * process.h: Add integer `gnutls_handshakes_tried' member to
1702 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1703 Add convenience `GNUTLS_LOG2i' macro.
1705 * gnutls.c (gnutls_log_function2i): Convenience log function.
1706 (emacs_gnutls_read): Use new log functions,
1707 `gnutls_handshakes_tried' process member, and
1708 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1709 attempts per process (connection).
1711 2012-04-09 Chong Yidong <cyd@gnu.org>
1713 * eval.c (Fuser_variable_p, user_variable_p_eh)
1714 (lisp_indirect_variable): Functions deleted.
1715 (Fdefvar): Caller changed.
1717 * callint.c (Finteractive, Fcall_interactively):
1718 * minibuf.c (Fread_variable): Callers changed.
1720 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1722 * xdisp.c (set_cursor_from_row): If the display string appears in
1723 the buffer at position that is closer to point than the position
1724 after the display string, display the cursor on the first glyph of
1725 the display string. Fixes cursor display when a 'display' text
1726 property immediately follows invisible text. (Bug#11094)
1728 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1730 composite.c: use 'double' consistently
1731 * composite.c (get_composition_id): Use 'double' consistently
1732 instead of converting 'float' to 'double' and vice versa; this is
1733 easier to understand and avoids a GCC warning.
1735 2012-04-09 Glenn Morris <rgm@gnu.org>
1737 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1738 preparation for dumping it with emacs. (Bug#4789)
1739 (leimdir): New variable.
1740 ($(leimdir)/leim-list.el): New rule.
1741 (emacs$(EXEEXT)): Depend on leim-list.el.
1743 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1744 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1745 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1747 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1749 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1752 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1754 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1755 Remove unused local variable.
1757 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1759 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1760 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1761 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1762 objects, as mark_maybe_pointer will catch them otherwise.
1763 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1764 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1766 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1768 Fix typo that broke non-Windows builds.
1769 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1771 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1773 Support building on MS-Windows with libxml2.
1775 * makefile.w32-in (OBJ2): Add xml.$(O).
1776 (GLOBAL_SOURCES): Add xml.c.
1777 ($(BLD)/xml.$(O)): New dependency list.
1779 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1780 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1781 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1782 [!WINDOWSNT]: New macros.
1783 (init_libxml2_functions, libxml2_loaded_p): New functions.
1784 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1785 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1786 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1787 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1789 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1790 Call init_libxml2_functions before calling libxml2 functions.
1791 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1793 * emacs.c: Don't include libxml/parser.h.
1794 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1795 xmlCleanupParser directly.
1797 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1799 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1801 * indent.c (Fvertical_motion): If there is a display string at
1802 point, use it.vpos to compute how many lines to backtrack after
1803 move_it_to point. (Bug#11133)
1805 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1807 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1808 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1809 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1810 macros related to unification of CJK characters. For the details,
1811 see the discussion following the message here:
1812 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1814 2012-04-04 Chong Yidong <cyd@gnu.org>
1816 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1818 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1820 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1821 instead of alloca. (Bug#11138)
1823 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1825 * w32menu.c (is_simple_dialog): Properly check lisp types.
1828 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1831 position we get to after a call to move_it_to fails the
1832 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1833 only if we wind up in a string from display property. (Bug#11063)
1835 * window.c (Fdelete_other_windows_internal): Invalidate the row
1836 and column information about mouse highlight, so that redisplay
1837 restores it after reallocating the glyph matrices. (Bug#7464)
1839 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1840 string comes from a `display' text property, use the buffer
1841 position of that property as if we actually saw that position in
1843 (move_it_by_lines): Remove the assertion that
1844 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1845 violated when there's a before-string at the beginning of a line.
1848 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1850 * xdisp.c (append_space_for_newline): If the default face was
1851 remapped, use the remapped face for the appended newline.
1852 (extend_face_to_end_of_line): Use the remapped default face for
1853 extending the face to the end of the line.
1854 (display_line): Call extend_face_to_end_of_line when the default
1855 face was remapped. (Bug#11068)
1857 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1859 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1861 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1863 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1865 2012-03-27 Glenn Morris <rgm@gnu.org>
1867 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1870 2012-03-26 Kenichi Handa <handa@m17n.org>
1872 * dispextern.h (struct glyph): Fix previous change. Change the
1873 bit length of glyphless.ch to 25 (Bug#11082).
1875 2012-03-26 Chong Yidong <cyd@gnu.org>
1877 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1878 (command_loop_1): Use it; inhibit selection update for
1879 handle-select-window too (Bug#8996).
1881 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1883 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1885 2012-03-25 Kenichi Handa <handa@m17n.org>
1887 * dispextern.h (struct glyph): Change the bit length of
1888 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1890 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1892 * s/ms-w32.h (tzname): Include time.h before redirecting to
1893 _tzname. Fixes the MSVC build. (Bug#9960)
1895 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1897 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1900 * xterm.c (XTread_socket): Only modify handling_signal if
1901 !SYNC_INPUT. (Bug#11080)
1903 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1905 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1906 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1907 when fetching a multibyte character consumes more bytes than
1908 CHAR_BYTES returns, due to unification of CJK characters in
1909 string_char. (Bug#11073)
1911 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1913 * process.c (wait_reading_process_output): Handle pty disconnect
1914 by refraining from sending oneself a SIGCHLD (bug#10933).
1916 2012-03-22 Chong Yidong <cyd@gnu.org>
1918 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1920 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1921 Mark string as coming from a prefix property.
1922 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1923 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1925 2012-03-21 Chong Yidong <cyd@gnu.org>
1927 * xfaces.c (Vface_remapping_alist): Doc fix.
1929 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1931 * w32proc.c (Fw32_set_console_codepage)
1932 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1935 2012-03-20 Chong Yidong <cyd@gnu.org>
1937 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1938 to reflect default non-nil value of redisplay-dont-pause.
1940 2012-03-19 Kenichi Handa <handa@m17n.org>
1942 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1943 it fit in a valid range (Bug#11003).
1945 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1948 that is not from display property, accept the row as a "cursor
1949 row" if one of the string's character has a non-nil `cursor'
1950 property. Fixes cursor positioning when there are newlines in
1951 overlay strings, e.g. in icomplete.el. (Bug#11035)
1953 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1955 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1957 2012-03-12 Chong Yidong <cyd@gnu.org>
1959 * eval.c (inhibit_lisp_code): Rename from
1960 inhibit_window_configuration_change_hook; move from window.c.
1962 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1963 * window.c (run_window_configuration_change_hook)
1964 (syms_of_window): Callers changed.
1966 2012-03-11 Chong Yidong <cyd@gnu.org>
1968 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1970 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1972 2012-03-10 Chong Yidong <cyd@gnu.org>
1974 * frame.c (other_visible_frames): Don't assume the selected frame
1975 is visible (Bug#10955).
1977 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1979 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1981 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1983 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1984 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1987 2012-03-03 Glenn Morris <rgm@gnu.org>
1989 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1991 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1993 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1994 position past the first glyph_row that ends at ZV. (Bug#10902)
1995 (redisplay_window, next_element_from_string): Fix typos in
1997 (redisplay_window): Pass to move_it_vertically the margin in
1998 pixels, not in screen lines.
2000 2012-03-02 Glenn Morris <rgm@gnu.org>
2002 * buffer.c (buffer-list-update-hook): Doc fix.
2004 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2006 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2007 push_it before setting up the iterator for the first overlay
2008 string, even if we have an empty string loaded.
2009 (next_overlay_string): If there's an empty string on the iterator
2010 stack, pop the stack. (Bug#10903)
2012 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2014 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2015 Suggested by Stefan Monnier in
2016 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2017 * alloc.c (widen_to_Lisp_Object): New static function.
2018 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2019 and widening them to Lisp_Objects. This would work even if
2020 USE_LSB_TAG is defined and wide integers are used, which might
2021 happen in a future version of Emacs.
2023 2012-02-25 Chong Yidong <cyd@gnu.org>
2025 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2028 * xselect.c (Fx_selection_exists_p): Doc fix.
2029 (x_clipboard_manager_save_all): Print an informative message
2030 before saving to clipboard manager.
2032 2012-02-24 Chong Yidong <cyd@gnu.org>
2034 * keyboard.c (process_special_events): Handle all X selection
2035 requests in kbd_buffer, not just the next one (Bug#8869).
2037 2012-02-23 Chong Yidong <cyd@gnu.org>
2039 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2040 call when setting menu-bar-lines and tool-bar-lines parameters.
2041 (unwind_create_frame_1): New helper function.
2043 * window.c (inhibit_window_configuration_change_hook): New var.
2044 (run_window_configuration_change_hook): Obey it.
2045 (syms_of_window): Initialize it.
2047 2012-02-22 Chong Yidong <cyd@gnu.org>
2049 * xterm.c (x_draw_image_relief): Add missing type check for
2050 Vtool_bar_button_margin (Bug#10743).
2052 2012-02-21 Chong Yidong <cyd@gnu.org>
2054 * fileio.c (Vfile_name_handler_alist): Doc fix.
2056 * buffer.c (Fget_file_buffer): Protect against invalid file
2057 handler return value.
2059 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2061 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2062 when computing $valmask.
2064 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2065 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2066 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2067 It's useless in that case, and it can cause problems on hosts
2068 that allocate halves of EMACS_INT values separately.
2069 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2070 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2071 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2072 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2073 it avoids undefined behavior on hosts where shifting right by more
2074 than the word width has undefined behavior.
2076 2012-02-19 Chong Yidong <cyd@gnu.org>
2078 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2079 (Funhandled_file_name_directory, Ffile_name_as_directory)
2080 (Fdirectory_file_name, Fexpand_file_name)
2081 (Fsubstitute_in_file_name): Protect against invalid file handler
2082 return values (Bug#10845).
2084 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2086 * .gdbinit (pitx): Fix incorrect references to fields of the
2089 2012-02-17 Chong Yidong <cyd@gnu.org>
2091 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2093 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2095 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2096 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2098 2012-02-15 Chong Yidong <cyd@gnu.org>
2100 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2101 marked as special. Also, starting docstrings with * is obsolete.
2103 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2105 * gnutls.c (emacs_gnutls_write): Fix last change.
2107 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2109 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2112 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2114 * keymap.c (Fsingle_key_description): Handle char ranges.
2116 2012-02-12 Chong Yidong <cyd@gnu.org>
2118 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2119 as that creates a dangerous corner case.
2121 * window.c (Fdelete_window_internal): Invalidate the mouse
2122 highlight (Bug#9904).
2124 2012-02-12 Glenn Morris <rgm@gnu.org>
2126 * xselect.c (Fx_own_selection_internal)
2127 (Fx_get_selection_internal, Fx_disown_selection_internal)
2128 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2129 * nsselect.m (Fx_own_selection_internal)
2130 (Fx_disown_selection_internal, Fx_selection_exists_p)
2131 (Fx_selection_owner_p, Fx_get_selection_internal):
2132 Sync docs and argument specs with the xselect.c versions.
2134 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2136 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2138 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2140 * w32select.c (Fx_selection_exists_p): Sync doc string and
2141 argument list with xselect.c. (Bug#10783)
2143 * w16select.c (Fx_selection_exists_p): Sync doc string and
2144 argument list with xselect.c. (Bug#10783)
2146 2012-02-10 Glenn Morris <rgm@gnu.org>
2148 * fns.c (Fsecure_hash): Doc fix.
2150 2012-02-09 Kenichi Handa <handa@m17n.org>
2152 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2154 2012-02-07 Chong Yidong <cyd@gnu.org>
2156 * buffer.c (Fbuffer_local_variables)
2157 (buffer_lisp_local_variables): Handle unbound vars correctly;
2158 don't let Qunbound leak into Lisp.
2160 2012-02-07 Glenn Morris <rgm@gnu.org>
2162 * image.c (Fimagemagick_types): Doc fix.
2164 * image.c (imagemagick-render-type): Change it from a lisp object
2165 to an integer. Move the doc here from the lisp manual.
2166 Treat all values not equal to 0 the same.
2168 2012-02-06 Chong Yidong <cyd@gnu.org>
2170 * doc.c (store_function_docstring): Avoid applying docstring of
2171 alias to base function (Bug#2603).
2173 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2175 * .gdbinit (pp1, pv1): Remove redundant defines.
2178 2012-02-04 Chong Yidong <cyd@gnu.org>
2180 * nsterm.m: Declare a global (Bug#10694).
2182 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2184 * w32.c (get_emacs_configuration_options):
2185 Include --enable-checking, if specified, in the return value.
2187 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2189 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2190 after rounding frame sizes. (Bug#9723)
2192 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2194 * keyboard.c (adjust_point_for_property): Don't position point
2195 before BEGV. (Bug#10696)
2197 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2199 Handle overflow when computing char display width (Bug#9496).
2200 * character.c (char_width): Return EMACS_INT, not int.
2201 (char_width, c_string_width): Check for overflow when
2202 computing the width; this is possible now that individual
2203 characters can have unbounded width. Problem introduced
2204 by merge from Emacs 23 on 2012-01-19.
2206 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2208 * dbusbind.c (Fdbus_register_method): Mention the return value
2209 :ignore in the docstring.
2211 2012-02-02 Glenn Morris <rgm@gnu.org>
2213 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2215 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2216 Unconditionally set to t. (Bug#10673)
2217 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2218 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2219 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2221 2012-02-02 Kenichi Handa <handa@m17n.org>
2223 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2224 0, do not call append_composite_glyph.
2226 2012-02-02 Kenichi Handa <handa@m17n.org>
2228 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2230 (x_produce_glyphs): If the component of a composition is a null
2231 string, set it->pixel_width to 1 to avoid zero-width glyph.
2233 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2235 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2236 first 2 arguments are identical. This makes inserting large
2237 output from a subprocess an order of magnitude faster on
2238 MS-Windows, where all sbrk'ed memory is always contiguous.
2240 2012-01-31 Glenn Morris <rgm@gnu.org>
2242 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2243 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2244 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2246 2012-01-29 Glenn Morris <rgm@gnu.org>
2248 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2250 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2252 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2254 2012-01-28 Chong Yidong <cyd@gnu.org>
2256 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2258 2012-01-26 Chong Yidong <cyd@gnu.org>
2260 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2262 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2263 repeat counts (Bug#10507).
2265 2012-01-26 Glenn Morris <rgm@gnu.org>
2267 * lread.c (syms_of_lread): Doc fix.
2269 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2271 * coding.c (encode_designation_at_bol): Change return value to
2274 2012-01-25 Chong Yidong <cyd@gnu.org>
2276 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2278 2012-01-21 Chong Yidong <cyd@gnu.org>
2280 * floatfns.c (Fcopysign): Make the second argument non-optional,
2281 since nil is not allowed anyway.
2283 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2285 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2286 (send_process): Likewise.
2288 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2290 * window.c (save_window_save, Fcurrent_window_configuration)
2291 (Vwindow_persistent_parameters): Do not use Qstate.
2292 Rewrite doc-strings.
2294 2012-01-19 Kenichi Handa <handa@m17n.org>
2296 * character.c (char_width): New function.
2297 (Fchar_width, c_string_width, lisp_string_width):
2298 Use char_width (Bug#9496).
2300 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2302 * window.c (Vwindow_persistent_parameters): New variable.
2303 (Fset_window_configuration, save_window_save): Handle persistent
2306 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2308 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2309 thrashing the stack of the thread. (Bug#9087)
2311 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2313 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2315 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2317 * xdisp.c (rows_from_pos_range): Handle the case where the
2318 highlight ends on a newline. (Bug#10464)
2319 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2320 he end column for display of highlight that ends on a newline
2323 2012-01-11 Glenn Morris <rgm@gnu.org>
2325 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2326 from load-path also when installation-directory is nil. (Bug#10208)
2328 2012-01-10 Glenn Morris <rgm@gnu.org>
2330 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2332 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2333 Update template values to be closer to their typical values these days.
2335 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2337 * xdisp.c (rows_from_pos_range): Accept additional argument
2338 DISP_STRING, and accept any glyph in a row whose object is that
2339 string as eligible for mouse highlight. Fixes mouse highlight of
2340 display strings from overlays. (Bug#10464)
2342 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2344 emacs: fix an auto-save permissions race condition (Bug#10400)
2345 * fileio.c (auto_saving_dir_umask): New static var.
2346 (Fmake_directory_internal): Use it.
2347 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2348 creating the directory. The old code temporarily assigns
2349 too-generous permissions to the directory.
2350 (do_auto_save_eh): Clear it.
2351 (Fdo_auto_save): Catch all errors, not just file errors, so
2352 that the var is always cleared.
2354 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2356 * search.c (scan_buffer): Pass character positions to
2357 know_region_cache, not byte positions. (Bug#6540)
2359 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2361 * w32.c (sys_rename): Report EXDEV when rename of a directory
2362 fails because the target is on another logical disk. (Bug#10284)
2364 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2366 * xterm.c (x_embed_request_focus): New function.
2368 * xterm.h: Add prototype.
2370 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2372 2012-01-05 Glenn Morris <rgm@gnu.org>
2374 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2376 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2378 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2379 Load gnutls_transport_set_lowat only if GnuTLS version is below
2381 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2382 GnuTLS versions below 2.11.1.
2384 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2386 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2387 to the doc string advising against its use for altering the way
2388 windows are scrolled.
2390 2011-12-28 Kenichi Handa <handa@m17n.org>
2392 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2393 coding-system ASCII compatible only when it does not produce BOM
2394 on encoding (Bug#10383).
2396 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2398 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2400 (create_and_show_popup_menu): Always use menu_position_func for
2403 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2405 * callint.c (Fcall_interactively): Don't truncate prompt string.
2407 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2409 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2410 property that ends at ZV, so that the bidi iteration could be
2411 resumed from there (after widening). (Bug#10360)
2413 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2415 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2417 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2419 * nsterm.m (x_free_frame_resources):
2420 Release f->output_data.ns->miniimage.
2421 (ns_index_color): Fix indentation. Do not retain
2422 color_table->colors[i].
2424 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2427 * nsfns.m (x_set_background_color): Assign return value from
2428 ns_index_color to face-background instead of NSColor*.
2429 (ns_implicitly_set_icon_type): Fix indentation.
2430 Change assignment in for loop to comparison.
2432 * emacs.c (ns_pool): New variable.
2433 (main): Assign ns_pool.
2434 (Fkill_emacs): Call ns_release_autorelease_pool.
2436 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2437 autorelease fdesc, release fdAttrs and tdict.
2438 (ns_get_covering_families): Release charset.
2439 (ns_findfonts): Release NSFontDescriptor created with new.
2440 (ns_uni_to_glyphs): Fix indentation.
2441 (setString): Release attrStr before assigning new value.
2443 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2445 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2447 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2448 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2450 2011-12-18 David Reitter <reitter@cmu.edu>
2452 * nsterm.m (ns_term_init): Subscribe for notifications
2453 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2454 to method trackingNotification in EmacsMenu.
2456 * nsmenu.m (trackingMenu): New variable.
2457 (trackingNotification): New method (from Aquamacs).
2458 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2459 from Aquamacs (Bug#7030).
2461 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2463 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2464 (symbol_to_nsstring): Fix indentation.
2465 (ns_symbol_to_pb): New function.
2466 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2467 (Fns_rotate_cut_buffers_internal): Remove.
2468 (Fns_store_selection_internal): Rename from
2469 Fns_store_cut_buffer_internal.
2470 (ns_get_foreign_selection, Fx_own_selection_internal)
2471 (Fx_disown_selection_internal, Fx_selection_exists_p)
2472 (Fns_get_selection_internal, Fns_store_selection_internal):
2473 Use ns_symbol_to_pb and check if return value is nil.
2474 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2475 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2476 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2477 renamed to Sns_store_selection_internal.
2478 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2479 and remove this function.
2480 (ns_handle_selection_clear): Remove, never used.
2481 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2484 2011-12-17 Ken Brown <kbrown@cornell.edu>
2486 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2487 GID is unknown (Bug#10257).
2489 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2491 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2492 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2493 which caused a build failure on GNU/Linux IA-64. This problem was
2494 introduced by my 2011-10-07 patch.
2496 2011-12-15 Juri Linkov <juri@jurta.org>
2498 * image.c (imagemagick_error): New function. (Bug#10112)
2499 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2500 Use `imagemagick_error' where ImageMagick functions return
2502 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2505 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2507 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2508 fill background (Bug#8992).
2510 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2512 * window.c (Vwindow_combination_resize)
2513 (Vwindow_combination_limit): Use t instead of non-nil in
2515 (Vrecenter_redisplay): Add first sentence of doc-string on
2517 (Frecenter): Fix doc-string typo.
2519 2011-12-11 Kenichi Handa <handa@m17n.org>
2521 * coding.c (Funencodable_char_position): Pay attention to the
2522 buffer text relocation (Bug#9389).
2524 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2526 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2527 gtk_init (Bug#10100).
2529 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2531 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2532 IT->string is nil. (Bug#10263)
2534 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2536 * nsterm.h (x_free_frame_resources): Declare.
2538 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2539 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2541 * nsterm.h (ns_get_defaults_value): Declare.
2543 * nsterm.m (ns_default): Call ns_get_defaults_value.
2545 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2547 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2550 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2552 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2553 that where the value of an _OBJC_* symbol points to is in the .bss
2554 section (Bug#10240).
2556 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2558 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2559 after the loop to call ccl_driver at least once (Bug#8619).
2561 2011-12-08 Kenichi Handa <handa@m17n.org>
2563 * ftfont.c (get_adstyle_property): Fix previous change
2566 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2568 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2569 dirs from the default value of EMACSLOADPATH (bug#10208).
2571 2011-12-07 Glenn Morris <rgm@gnu.org>
2573 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2574 installation and source directories as well. (Bug#10208)
2576 2011-12-06 Chong Yidong <cyd@gnu.org>
2578 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2580 2011-12-06 Glenn Morris <rgm@gnu.org>
2582 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2583 as an error, not just -1. (Bug#10217)
2585 2011-12-05 Chong Yidong <cyd@gnu.org>
2587 * keyboard.c (process_special_events): New function.
2588 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2590 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2592 * coding.c (encode_designation_at_bol): Don't use uninitialized
2593 local variable (Bug#9318).
2595 2011-12-05 Kenichi Handa <handa@m17n.org>
2597 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2598 return Qnil (Bug#8046, Bug#10193).
2600 2011-12-05 Kenichi Handa <handa@m17n.org>
2602 * coding.c (encode_designation_at_bol): New args charbuf_end and
2603 dst. Return the number of produced bytes. Callers changed.
2604 (coding_set_source): Return how many bytes coding->source was
2606 (coding_set_destination): Return how many bytes
2607 coding->destination was relocated.
2608 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2609 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2611 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2613 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2614 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2617 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2619 The following changes are to fix Bug#9318.
2621 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2622 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2623 (encode_coding_iso_2022, encode_coding_sjis)
2624 (encode_coding_big5, encode_coding_charset): Use the above macros.
2626 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2628 * lisp.h (process_quit_flag): Fix external declaration.
2630 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2632 Don't macro-inline non-performance-critical code.
2633 * eval.c (process_quit_flag): New function.
2634 * lisp.h (QUIT): Use it.
2636 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2638 * nsfns.m (get_geometry_from_preferences): New function.
2639 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2641 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2643 * emacs.c (Qkill_emacs): Define.
2644 (syms_of_emacs): Initialize it.
2645 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2646 Qquit_flag to `kill-emacs' instead.
2647 (quit_throw_to_read_char): Add parameter `from_signal'.
2648 All callers changed. Call Fkill_emacs if requested and safe.
2649 * lisp.h (QUIT): Call Fkill_emacs if requested.
2651 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2653 * widget.c (update_wm_hints): Return if wmshell is null.
2654 (widget_update_wm_size_hints): New function.
2656 * widget.h (widget_update_wm_size_hints): Declare.
2658 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2659 widget_update_wm_size_hints (Bug#10104).
2661 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2663 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2664 before a newline, prepare the bidi iterator for consuming the
2665 newline, and keep the current paragraph direction. (Bug#10183)
2666 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2668 2011-12-02 Juri Linkov <juri@jurta.org>
2670 * search.c (Fword_search_regexp): New Lisp function created from
2671 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2672 (Fword_search_backward, Fword_search_forward)
2673 (Fword_search_backward_lax, Fword_search_forward_lax):
2674 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2675 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2677 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2679 * fileio.c (Finsert_file_contents): Move after-change-function call
2680 to before the "handled:" label, since all "goto handled" appear in
2681 cases where the *-change-functions have already been properly called
2684 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2686 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2687 waiting for input. (Bug#10169)
2689 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2691 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2692 verifies glyph row's hash code--we have just reallocated the
2693 glyphs, so their contents can be complete garbage. (Bug#10164)
2695 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2697 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2699 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2701 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2702 attributes are tested _before_ calling verify_row_hash, to protect
2703 against GCC re-ordering of the tests. (Bug#10164)
2705 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2707 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2709 * xterm.c (handle_one_xevent): Only set async_visible and friends
2710 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2711 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2712 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2714 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2716 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2717 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2718 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2719 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2720 All uses changed to use GCPRO1 etc.
2721 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2722 Revert to old implementation (i.e., before 2011-03-11).
2724 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2726 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2727 of scroll runs so as to avoid assigning disabled bogus rows and
2728 unnecessary graphics copy operations.
2730 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2732 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2733 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2734 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2735 (malloc, free, realloc, calloc): Redirect to e_* only when
2738 * lisp.h (GCTYPEBITS): Move before first use.
2739 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2740 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2741 this macro definition.
2743 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2746 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2748 * gtkutil.c (xg_create_frame_widgets):
2749 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2750 present with Gtk+ 2.0.
2752 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2754 * fileio.c (Finsert_file_contents): Undo previous change; see
2755 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2757 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2759 Rename locals to avoid shadowing.
2760 * fileio.c (Finsert_file_contents):
2761 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2762 * process.c (wait_reading_process_output):
2763 Rename inner 'proc' to 'p' to avoid shadowing.
2764 Indent for consistency with usual Emacs style.
2766 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2768 * xdisp.c (redisplay_window): If cursor row is not fully visible
2769 after recentering, and scroll-conservatively is set to a large
2770 number, scroll window by a few more lines to make the cursor fully
2771 visible and out of scroll-margin. (Bug#10105)
2772 (start_display): Don't move to the next line if the display should
2773 start at a newline that is part of a display vector or an overlay
2776 2011-11-24 Juri Linkov <juri@jurta.org>
2778 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2779 after the `MagickPingImage' call. (Bug#10112)
2781 2011-11-23 Chong Yidong <cyd@gnu.org>
2783 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2785 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2787 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2788 making another buffer current. (Bug#10114)
2790 2011-11-23 Glenn Morris <rgm@gnu.org>
2792 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2794 2011-11-23 Chong Yidong <cyd@gnu.org>
2796 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2797 using it (Bug#5984).
2799 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2801 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2802 and header-lines, as they don't have one computed for them.
2805 * .gdbinit (prow): Make displayed values more self-explaining.
2806 Add row's hash code.
2808 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2810 * process.c (wait_reading_process_output): Fix asynchrounous
2811 GnuTLS socket handling on some versions of the GnuTLS library.
2812 (wait_reading_process_output): Add comment and URL.
2814 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2816 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2818 2011-11-21 Chong Yidong <cyd@gnu.org>
2820 * window.c (Fnext_window, Fprevious_window): Doc fix.
2822 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2824 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2826 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2828 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2830 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2832 * window.c (Fset_window_combination_limit): Rename argument
2834 (Vwindow_combination_limit): Remove "status" from doc-string.
2836 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2838 * m/ibms390.h: Remove.
2839 * m/ibms390x.h: Don't include "ibms390.h".
2841 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2843 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2844 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2846 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2848 * casetab.c (Fset_case_table):
2849 * charset.c (Fcharset_after): Fix typos.
2851 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2853 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2854 Otherwise, valgrind does not work on some platforms.
2855 Problem reported by Andreas Schwab in
2856 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2857 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2858 is set, removing the need for VIRT_ADDRESS_VARIES.
2859 (PURE_P): Use a more-efficient implementation that needs just one
2860 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2861 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2862 to 4 (xorl, subq, cmpq, setbe).
2863 * alloc.c (pure): Always extern now, since that's the
2864 VIRT_ADDR_VARIES behavior.
2865 (PURE_POINTER_P): Use a single comparison, not two, for
2866 consistency with the new puresize.h.
2867 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2868 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2869 Remove VIRT_ADDR_VARIES no longer needed.
2871 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2873 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2874 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2875 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2876 behave as if the cursor position were at the window margin.
2878 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2879 and the cursor position is out of bounds, behave as if the cursor
2880 position were at the window margin. (Bug#10075)
2882 2011-11-18 Chong Yidong <cyd@gnu.org>
2884 * window.c (Fwindow_combination_limit): Make first argument
2885 non-optional, since it is meaningless for live windows like the
2888 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2890 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2892 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2894 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2895 (graft_intervals_into_buffer): Simplify.
2897 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2899 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2900 hash values of the two rows.
2901 (copy_row_except_pointers): Preserve the used[] arrays and the
2902 hash values of the two rows. (Bug#10035)
2903 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2905 * xdisp.c (row_hash): New function, body extracted from
2906 compute_line_metrics.
2907 (compute_line_metrics): Call row_hash, instead of computing the
2910 * dispnew.c (verify_row_hash): Call row_hash for computing the
2911 hash code of a row, instead of duplicating code from xdisp.c.
2913 * dispextern.h (row_hash): Add prototype.
2915 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2917 * frame.c (delete_frame): Don't delete the terminal when the last
2918 X frame is closed if emacs is built with GTK toolkit.
2920 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2922 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2924 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2926 * window.c (Vwindow_splits): Rename to
2927 Vwindow_combination_resize. Suggested by Juri Linkov.
2928 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2931 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2933 * nsfns.m (Fns_font_name):
2934 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2936 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2938 * window.h (window): Rename slot "nest" to "combination_limit".
2939 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2940 (Fset_window_nest): Rename to Fset_window_combination_limit.
2941 (Vwindow_nest): Rename to Vwindow_combination_limit.
2942 (recombine_windows, make_parent_window, make_window)
2943 (Fsplit_window_internal, saved_window)
2944 (Fset_window_configuration, save_window_save): Rename all
2945 occurrences of window_nest to window_combination_limit.
2947 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2949 * image.c (imagemagick_load_image): Fix typo.
2951 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2953 * xdisp.c (display_line): Move the call to
2954 highlight_trailing_whitespace before the call to
2955 compute_line_metrics, since the latter needs to see the final
2956 faces of all the glyphs to compute ROW's hash value.
2957 Fixes assertion violations in row_equal_p. (Bug#10035)
2959 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2961 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2962 just return (bug#10044).
2964 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2966 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2967 with user-defined heap size. Bump the default size of the temacs
2968 heap to 27MB, to avoid memory warning when running temacs.
2969 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2971 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2972 current_matrix and desired_matrix. (Bug#9990)
2973 (verify_row_hash) [XASSERTS]: New function.
2974 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2975 that the hash value of glyph rows is correct.
2977 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2979 * window.h (window): Remove splits slot.
2980 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2981 (Fdelete_other_windows_internal, make_parent_window)
2982 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2983 (Fset_window_configuration, save_window_save): Don't deal with
2984 split status of windows.
2985 (saved_window): Remove splits slot.
2986 (Vwindow_splits): Rewrite doc-string.
2988 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2990 * xfns.c (unwind_create_frame):
2991 * nsfns.m (unwind_create_frame):
2992 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2993 Vframe_list (Bug#9999).
2995 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2997 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2999 2011-11-11 Kenichi Handa <handa@m17n.org>
3001 * callproc.c (Fcall_process): Set the member dst_multibyte of
3004 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3006 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3007 avoid a crash (bug#9496).
3009 2011-11-09 Chong Yidong <cyd@gnu.org>
3011 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3012 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3014 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3016 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3018 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3020 Avoid some portability problems by eschewing 'extern inline' functions.
3021 The trivial performance wins aren't worth the portability hassles; see
3022 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3024 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3025 (window_box_width, window_box_left, window_box_left_offset)
3026 (window_box_right, window_box_right_offset): Undo previous change,
3027 by removing the "extern"s.
3028 * intervals.c (adjust_intervals_for_insertion)
3029 (adjust_intervals_for_deletion): Undo previous change,
3030 making these static again.
3031 (offset_intervals, temp_set_point_both, temp_set_point)
3032 (copy_intervals_to_string): No longer inline.
3033 * xdisp.c (window_text_bottom_y, window_box_width)
3034 (window_box_height, window_box_left_offset)
3035 (window_box_right_offset, window_box_left, window_box_right)
3036 (window_box): No longer inline.
3038 2011-11-08 Chong Yidong <cyd@gnu.org>
3040 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3041 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3042 Signal an error if not a live window.
3043 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3044 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3046 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3048 * lisp.h (syms_of_abbrev): Remove declaration.
3049 Reported by CHENG Gao <chenggao@royau.me>.
3051 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3053 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3054 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3055 of temacs in GUI mode.
3057 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3059 * window.h: Declare delete_all_child_windows instead of
3060 delete_all_subwindows.
3061 * window.c (Fwindow_nest, Fset_window_nest)
3062 (Fset_window_new_total, Fset_window_new_normal)
3063 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3064 (delete_all_subwindows): Rename to delete_all_child_windows.
3065 (Fdelete_other_windows_internal, Fset_window_configuration):
3066 Call delete_all_child_windows instead of delete_all_subwindows.
3067 * frame.c (delete_frame): Call delete_all_child_windows instead
3068 of delete_all_subwindows.
3070 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3072 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3073 This is also needed for porting to any host where GC_MARK_STACK is
3074 not GC_MAKE_GCPROS_NOOPS.
3075 (which_symbols): Use it.
3077 2011-11-07 Kenichi Handa <handa@m17n.org>
3079 * coding.c (coding_set_destination): Check coding->src_pos only
3080 when coding->src_object is a buffer (bug#9910).
3082 * process.c (send_process): Set the member src_multibyte of coding
3083 to 0 (bug#9911) when sending a unibyte text.
3085 * callproc.c (Fcall_process): Set the member src_multibyte of
3086 process_coding to 0 (bug#9912).
3088 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3090 * xmenu.c (cleanup_widget_value_tree): New function.
3091 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3092 calling free_menubar_widget_value_tree directly (Bug#9830).
3094 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3096 Fix some portability problems with 'inline'.
3097 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3098 (window_box_width, window_box_left, window_box_left_offset)
3099 (window_box_right, window_box_right_offset): Declare extern.
3100 Otherwise, these inline functions do not conform to C99 and
3101 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3102 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3103 * intervals.c (adjust_intervals_for_insertion)
3104 (adjust_intervals_for_deletion): Now extern, because otherwise the
3105 extern inline functions 'offset_intervals' couldn't refer to it.
3106 (static_offset_intervals): Remove.
3107 (offset_intervals): Rewrite using the old contents of
3108 static_offset_intervals. The old version didn't conform to C99
3109 because an extern inline function contained a reference to an
3110 identifier with static linkage.
3112 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3114 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3117 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3119 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3120 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3121 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3122 return Qleft_to_right.
3124 2011-11-06 Chong Yidong <cyd@gnu.org>
3126 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3127 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3128 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3129 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3130 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3131 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3132 (Fwindow_vscroll): Doc fix.
3133 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3134 argument, since it makes no sense to pass a live window and for
3135 consistency with window-child.
3137 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3139 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3142 2011-11-05 Jason Rumney <jasonr@gnu.org>
3144 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3145 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3147 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3148 bitwise arithmetic preventing use of unicode-sip and non-truetype
3151 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3153 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3156 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3157 initialization code to keep similarity to xfns.c after changes
3160 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3162 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3163 (unwind_create_frame): New function (Bug#9943).
3164 (Fx_create_frame): Restructure code to be more similar to the one in
3165 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3166 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3167 Move terminal->reference_count++ just before making the frame official
3170 * nsterm.m (x_free_frame_resources): New function.
3171 (x_destroy_window): Move code to x_free_frame_resources.
3173 * xfns.c (unwind_create_frame): Fix comment.
3174 (Fx_create_frame, x_create_tip_frame):
3175 Move terminal->reference_count++ just before making the frame
3176 official. Move initialization of image_cache_refcount and
3177 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3179 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3181 Support MSVC build with newer versions of Visual Studio.
3182 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3183 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3186 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3187 which are not supported by MSVC.
3188 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3189 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3191 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3193 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3195 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3197 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3199 Support MSVC build with newer versions of Visual Studio.
3200 * w32.c: Don't include w32api.h for MSVC.
3201 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3203 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3204 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3205 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3206 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3208 (alloca) [_MSC_VER]: Define to _alloca.
3210 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3212 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3214 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3216 * xdisp.c (note_mouse_highlight): If either of
3217 previous/next-single-property-change returns nil, treat that as
3218 the beginning or the end of the buffer. (Bug#9955)
3220 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3222 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3223 label is not null (Bug#9951).
3224 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3227 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3229 * window.c (Fwindow_body_size): Mention in the doc string that the
3230 return value is in frame's canonical units. (Bug#9949)
3232 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3234 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3236 * w32fns.c (unwind_create_frame): If needed, free the glyph
3237 matrices of the partially constructed frame. (Bug#9943)
3238 * xfns.c (unwind_create_frame): Likewise.
3240 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3242 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3243 Don't stop backward scan on the continuation glyph, even though
3244 its CHARPOS is positive.
3245 (mouse_face_from_buffer_pos, note_mouse_highlight):
3246 Rename cover_string to disp_string.
3248 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3250 * window.c (temp_output_buffer_show): Don't use
3251 Vtemp_buffer_show_specifiers.
3252 (Vtemp_buffer_show_specifiers): Remove unused variable.
3254 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3256 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3257 past the beginning of the current glyph matrix.
3259 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3261 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3262 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3263 HAVE_GTK3 (Bug#9869).
3265 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3266 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3268 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3270 * xterm.c: Declare x_handle_net_wm_state to return int.
3271 (handle_one_xevent): Check if we are iconified but don't have
3272 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3273 (get_current_wm_state): Return non-zero if not hidden,
3274 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3275 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3276 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3277 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3279 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3281 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3282 so that this new function doesn't get optimized away by a
3283 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3285 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3287 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3289 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3291 Fix the `xbytecode' command.
3292 * .gdbinit (xprintbytestr): New command.
3293 (xwhichsymbols): Rename from `which'; all callers changed.
3294 (xbytecode): Print the byte-code string as well.
3296 2011-10-29 Kim Storm <storm@cua.dk>
3298 * alloc.c (which_symbols): New function.
3300 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3302 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3305 2011-10-29 Glenn Morris <rgm@gnu.org>
3307 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3308 Not clear what it was for, and it causes various bugs. (Bug#9839)
3310 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3312 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3313 possible random value that matches one of those tested as
3314 condition to clear the mouse face.
3316 2011-10-28 Chong Yidong <cyd@gnu.org>
3318 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3320 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3322 * window.c (make_window): Initialize phys_cursor_on_p.
3324 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3326 * lisp.h (struct Lisp_Symbol): Update comments.
3328 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3330 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3332 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3334 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3335 <oslsachem@gmail.com> for helping to debug this.
3337 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3338 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3339 (g_b_init_get_glyph_outline_w): New static variables.
3340 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3341 (GetGlyphOutlineW_Proc): New typedefs.
3342 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3343 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3345 (w32font_open_internal, compute_metrics):
3346 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3347 instead of calling the "wide" APIs directly.
3349 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3351 * w32.h (syms_of_w32font): Add prototype.
3353 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3355 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3356 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3357 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3358 (Fmove_to_window_line): Doc fix.
3360 2011-10-27 Chong Yidong <cyd@gnu.org>
3362 * process.c (make_process): Set gnutls_state to NULL.
3364 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3365 non-NULL, regardless of GNUTLS_INITSTAGE.
3366 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3367 an error. Set process slots as soon as we allocate them.
3369 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3371 2011-10-27 Chong Yidong <cyd@gnu.org>
3373 * gnutls.c (emacs_gnutls_deinit): New function.
3374 Deallocate credentials structures as well as calling gnutls_deinit.
3375 (Fgnutls_deinit, Fgnutls_boot): Use it.
3377 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3378 (deactivate_process): Call emacs_gnutls_deinit.
3380 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3382 * image.c (x_create_x_image_and_pixmap):
3383 * w32.c (sys_rename, w32_delayed_load):
3384 * w32font.c (fill_in_logfont):
3385 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3387 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3389 * w32fns.c (w32_default_color_map): New function,
3390 extracted from Fw32_default_color_map.
3391 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3393 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3395 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3397 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3399 * keyboard.c (test_undefined): New function (bug#9751).
3400 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3402 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3404 * sysdep.c (init_sys_modes): Fix the check for the controlling
3405 terminal (Bug#6649).
3407 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3409 * dispextern.h (struct bidi_it): New member next_en_type.
3411 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3412 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3413 current character, check also for next_en_type being WEAK_EN.
3414 (bidi_resolve_weak): Don't enter the expensive loop if the current
3415 position is before next_en_pos. Record the bidi type of the first
3416 non-ET, non-BN character we find, in addition to its position.
3417 (bidi_level_of_next_char): Invalidate next_en_type when
3418 next_en_pos is over-stepped.
3420 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3422 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3423 * editfns.c: Rewrite current-time-zone so that it invokes
3424 the equivalent of (format-time-string "%Z") to get the time zone name.
3425 This fixes a bug when the time zone name contains characters that
3426 need converting from the system time locale to Emacs internal format.
3427 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3428 that patch fixed format-time-string to do the conversion, but
3429 I forgot to fix current-time-zone.
3430 (format_time_string): New function, containing most of
3431 what Fformat_time_string used to contain.
3432 (Fformat_time_string): Rewrite in terms of format_time_string.
3433 This doesn't change this function's behavior.
3434 (current-time-zone): Rewrite to use format_time_string.
3435 This fixes the bug reported by Michael Schierl in
3436 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3437 Jason Rumney's 2007-06-07 change worked around this bug, but
3439 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3441 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3443 * xdisp.c (start_display): If the character at POS is displayed
3444 via a display vector, reset IT->current.dpvec_index to zero.
3445 (try_window_reusing_current_matrix): If a line ends in a display
3446 vector or the next line starts in a display vector, continue
3447 redrawing the window even though the character position of
3448 start_row was reached.
3451 2011-10-18 Chong Yidong <cyd@gnu.org>
3453 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3454 with nobreak-char-display too.
3456 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3458 Fix part 3 of bug#9771.
3459 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3460 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3461 non-neutral characters if the current character is a paragraph
3462 separator (a.k.a. Newline). This avoids running the same
3463 expensive loop twice, once when we consume the preceding newline
3464 and the other time when the line actually needs to be displayed.
3465 Avoid the loop when we see neutrals on the base embedding level
3466 following a character whose directionality is the same as the
3467 paragraph's. This avoids running the expensive loop when a line
3468 ends in a long sequence of neutrals, like control characters.
3469 Add assertion against STRONG_AL type. Slightly rearrange code
3470 that determines the type of a neutral given the first non-neutral
3472 (bidi_level_of_next_char): Set next_en_pos to zero when
3473 invalidating its info.
3475 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3477 * xdisp.c (push_display_prop): Determine whether to record string
3478 or buffer position by IT->string, not by IT->method. Allow
3479 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3480 (move_it_vertically_backward): Don't look for character position
3481 immediately after the newline when in a continuation line.
3484 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3486 * window.c (coordinates_in_window): Rewrite and delabelize
3487 vertical border check. (Bug#5357) (Bug#9618)
3489 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3491 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3492 errors in XSetWindowBorder (bug#9310).
3494 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3496 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3497 avoid crash when xmalloc overrun checking is enabled.
3499 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3501 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3502 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3503 cursor motion with <left> and <right> arrow keys.
3505 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3506 some callers set that themselves.
3508 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3510 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3511 display string and the previous row comes from the same string and
3512 is empty. (Bug#9739) (Bug#9738)
3514 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3516 * doc.c (get_doc_string): Encode file name (bug#9735).
3518 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3520 * bidi.c (bidi_level_of_next_char):
3521 * xdisp.c (get_visually_first_element): Remove old incorrect
3522 comments regarding the Unicode Line Separator character.
3524 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3526 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3528 * alloc.c (Fgc_status): Do not access beyond zombies array
3529 boundary if nzombies > MAX_ZOMBIES.
3530 * alloc.c (dump_zombies): Add missing format specifier.
3532 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3534 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3535 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3537 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3538 Some packages use them to denote characters with modifiers.
3540 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3542 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3543 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3544 matching a pp-number. Rename parameter var to var1.
3546 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3548 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3550 2011-10-08 Glenn Morris <rgm@gnu.org>
3552 * callint.c (Fcall_interactively): Give a more explicit error for the
3553 'c' case with a non-character input. (Bug#8479)
3555 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3557 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3559 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3560 lines that are hscrolled on the left.
3562 * dispnew.c (buffer_posn_from_coords): Account for a possible
3563 presence of header-line. (Bug#4426)
3565 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3567 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3568 Don't advertise functionality which we discourage or doesn't work.
3570 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3572 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3573 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3574 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3575 this makes Emacs dump core during garbage collection on rare
3576 occasions. sizeof is obviously inferior to offsetof here, so
3577 stick with offsetof.
3578 (GC_POINTER_ALIGNMENT): New macro.
3579 (mark_memory): Omit 3rd (offset) arg; caller changed.
3580 Don't assume EMACS_INT alignment is the same as pointer alignment.
3582 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3584 * keyboard.c (read_key_sequence_remapped): New var.
3585 (read_key_sequence): Compute remapping in the right buffer.
3586 (command_loop_1): Use read_key_sequence's remapping directly.
3588 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3590 * dired.c (file_name_completion): Don't expand file name.
3591 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3592 before checking file name handler.
3594 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3595 they've been requested explicitly (bug#9591).
3597 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3599 * keymap.c (Fsingle_key_description): Use make_specified_string
3600 instead of build_string to build string from push_key_description.
3603 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3605 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3606 This fixes a Y2038 bug on 64-bit hosts.
3607 * buffer.c (reset_buffer):
3608 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3609 (Fclear_buffer_auto_save_failure):
3610 Use 0, not -1, to represent an unset failure time, since time_t
3611 might not be signed.
3613 Remove dependency on glibc malloc internals.
3614 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3615 Move back here from lisp.h, but with their new implementations.
3616 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3617 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3618 * charset.c (charset_table_init): New static var.
3619 (syms_of_charset): Use it instead of xmalloc. This removes a
3620 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3621 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3622 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3623 Move back to alloc.c.
3624 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3625 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3627 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3629 * nsterm.m (windowDidResize): Call x_set_window_size only when
3630 ns_in_resize is true. Otherwise set pixelwidth/height and
3631 call change_frame_size (Bug#9628).
3633 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3635 Port --enable-checking=all to Fedora 14 x86-64.
3636 * charset.c (syms_of_charset): Also account for glibc malloc's
3637 internal overhead when calculating the initial malloc maximum.
3639 Port --enable-checking=all to Fedora 14 x86.
3640 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3642 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3643 (overrun_check_realloc, overrun_check_free):
3644 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3645 That way, xmalloc returns a properly-aligned pointer even if
3646 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3647 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3648 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3649 into account when calculating the initial malloc maximum.
3650 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3651 Move here from alloc.c, so that charset.c can use it too.
3652 Properly align; the old code wasn't right for common 32-bit hosts
3653 when configured with --enable-checking=all.
3654 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3655 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3657 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3659 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3662 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3664 * xdisp.c (compute_display_string_end): If there's no display
3665 string at CHARPOS, return -1.
3667 * bidi.c (bidi_fetch_char): When compute_display_string_end
3668 returns a negative value, treat the character as a normal
3669 character not covered by a display string. (Bug#9624)
3671 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3673 * lread.c (Fread_from_string): Fix typo in docstring.
3675 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3677 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3678 newline, reseat the iterator instead of bidi-iterating there one
3679 character at a time. (Bug#9610)
3680 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3681 TO_CHARPOS if the bidi iterator is at base embedding level.
3683 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3685 * lread.c (readevalloop): Use correct code for NBSP.
3686 (read1): Likewise. (Bug#9608)
3688 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3690 * dbusbind.c (Fdbus_register_signal): When service is not
3691 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3693 2011-09-25 Glenn Morris <rgm@gnu.org>
3695 * buffer.c (truncate-lines): Doc fix.
3697 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3699 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3700 (Fset_window_next_buffers): Doc fix.
3702 2011-09-24 Glenn Morris <rgm@gnu.org>
3704 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3706 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3708 Fix minor problems found by static checking.
3709 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3710 * indent.c (Fvertical_motion): Fix == vs = typo.
3712 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3714 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3715 Default value is now t. Doc fix.
3717 * indent.c (Fvertical_motion): Compute and apply the overshoot
3718 logic when moving up, not only when moving down. Fix the
3719 confusing name and values of the it_overshoot_expected variable;
3720 logic changes accordingly. (Bug#9254) (Bug#9549)
3722 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3723 CHARPOS is covered by a display string which includes newlines.
3724 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3725 is covered by a display string with embedded newlines.
3727 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3729 * dbusbind.c (Fdbus_register_signal): Add match rule to
3730 Vdbus_registered_objects_table. (Bug#9581)
3731 (Fdbus_register_method, Vdbus_registered_objects_table):
3734 2011-09-24 Jim Meyering <meyering@redhat.com>
3736 do not ignore write error for any output size
3737 The previous change was incomplete.
3738 While it makes emacs --batch detect the vast majority of stdout
3739 write failures, errors were still ignored whenever the output size is
3740 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3741 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3742 && echo FAIL: ignored write error
3743 FAIL: ignored write error
3744 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3745 && echo FAIL: ignored write error
3746 FAIL: ignored write error
3747 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3749 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3751 * emacs.c (Fkill_emacs): In noninteractive mode exit
3752 non-successfully if a write error occurred on stdout. (Bug#9574)
3754 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3756 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3759 * dispextern.h (struct it): Update the comment documenting what
3762 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3764 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3765 a display string, extend search for cursor position to end of row.
3766 (find_row_edges): If the row ends in a newline from a display
3767 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3768 Handle the case of a display string with multiple newlines.
3769 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3770 non-empty line. Fixes confusing cursor motion with arrow keys at
3771 the beginning of a line that starts with whitespace.
3773 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3775 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3778 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3780 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3783 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3785 * xdisp.c (display_line): Record maximum and minimum buffer
3786 positions even if no glyphs were produced (e.g., by a zero-width
3787 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3788 buffer positions that will be removed from the glyph row because
3790 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3791 column is beyond frame width: don't subtract 1 "pixel" when
3792 computing width of the stretch.
3793 (reseat_at_next_visible_line_start): Undo the change made on
3794 2011-09-17 that saved paragraph information and restored it after
3795 the call to `reseat'. (Bug#9545)
3797 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3799 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3800 and turn window cursor on if cleared (Bug#9415).
3802 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3804 * search.c (boyer_moore): Take unibyte characters from pattern
3805 literally. (Bug#9458)
3807 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3809 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3811 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3813 Fix minor problem found by static checking.
3814 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3815 initialized, to pacify gcc -Wuninitialized.
3817 * fileio.c: Report proper errno when syscall falls.
3818 (Finsert_file_contents): Save and restore errno,
3819 so that report_file_error outputs the correct diagnostic.
3820 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3822 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3824 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3826 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3828 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3829 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3831 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3833 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3834 about the current paragraph and restore it after the call to reseat.
3836 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3837 (bidi_find_paragraph_start): Search back for paragraph beginning
3838 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3839 (bidi_move_to_visually_next): Only trigger paragraph-related
3840 computations when the last character is a newline or at EOB, not
3841 just any NEUTRAL_B. (Bug#9470)
3843 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3844 truncated lines if point is covered by a display string. (Bug#9524)
3846 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3848 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3849 (cons_to_x_long): New function.
3850 (lisp_data_to_selection_data): Use it. Correct the test for
3851 short-versus-long data; it was negated. Break out of vector
3852 loop, for efficiency, when a long datum is discovered.
3854 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3856 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3858 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3860 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3861 GCC PR/17406) by declaring this function with external scope.
3863 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3865 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3866 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3868 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3870 * editfns.c (Fformat): Correctly handle text properties on "%%".
3872 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3874 * xterm.c (x_draw_composite_glyph_string_foreground):
3875 * w32term.c (x_draw_composite_glyph_string_foreground):
3876 * term.c (encode_terminal_code):
3877 * composite.c (composition_update_it, get_composition_id):
3878 * xdisp.c (get_next_display_element)
3879 (fill_composite_glyph_string): Add comments about special meaning
3880 of TAB characters in a composition.
3882 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3884 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3885 This occurs when processing a multibyte format.
3886 Problem reported by Wolfgang Jenker.
3888 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3890 * xdisp.c (try_cursor_movement): Only check for exact match if
3891 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3893 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3895 Remove unused external symbols.
3896 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3897 * xdisp.c (calc_pixel_width_or_height): Now static.
3898 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3899 * indent.c (check_display_width):
3900 * w32term.c: Fix comment to match code.
3901 * xterm.c, xterm.h (x_catching_errors): Remove.
3903 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3905 * xselect.c: Use signed conversions more consistently (Bug#9498).
3906 (selection_data_to_lisp_data): Assume incoming selection data are
3907 signed integers, not unsigned. This is to be consistent with
3908 outgoing selection data, which was modified to use signed integers
3909 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3910 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3911 expects long, not unsigned long.
3913 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3915 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3916 computation of loop end. Reported by Johan Bockgård
3919 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3921 * frame.c (Fother_visible_frames_p): Function deleted.
3923 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3925 * indent.c (compute_motion): Process display vector front to back
3926 rather than the other way around. (Bug#2496)
3928 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3930 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3932 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3934 * minibuf.c (Fread_from_minibuffer): Doc fix.
3936 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3938 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3939 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3941 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3943 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3944 value for non-existent files.
3946 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3948 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3949 set its "size" to -1. This will set the modtime_size field of
3950 the corresponding buffer to -1, which is what
3951 verify-visited-file-modtime expects for files that do not exist.
3954 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3956 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3958 * lisp.h: ... from here. push_key_description is no longer
3959 defined in keyboard.c, so its declaration should not be in
3960 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3961 logically belongs with push_key_description.
3963 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3965 * buffer.h: Include <sys/types.h> instead of <time.h>.
3966 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3967 Problem reported by Herbert J. Skuhra.
3969 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3971 * xml.c (parse_region): Make the parsing work for
3972 non-comment-starting XML files again (bug#9144).
3974 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3976 * image.c (gif_load): Fix calculation of bottom and right corner.
3979 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3981 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3982 redisplay in small windows.
3984 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3986 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3988 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3990 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3991 Operate on live windows only.
3993 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3995 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3997 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3999 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4000 only under bidi iteration.
4002 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4004 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4006 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4008 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4009 Without this fix, the command to link temacs failed due to an
4010 undefined symbol __builtin_isnan. This is because
4011 /usr/include/iso/math_c99.h #defines isnan(x) to
4012 __builtin_isnan(x), but the bundled gcc, which identifies itself
4013 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4015 * floatfns.c (isnan): #undef, and then #define to a clone of
4017 (Fisnan): Always define, since it's always available now.
4018 (syms_of_floatfns): Always define isnan at the Lisp level.
4020 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4022 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4024 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4026 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4027 The previous code assumed that file offsets (off_t values) fit in
4028 EMACS_INT variables, which is not true on typical 32-bit hosts.
4029 The code messed up by falsely reporting buffer overflow in cases
4030 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4031 when "big" contains more than 2**29 bytes, even though this
4032 inserts just one byte and does not overflow the buffer.
4033 (Finsert_file_contents): Store file offsets as off_t
4034 values, not as EMACS_INT values. Check for overflow when
4035 converting between EMACS_INT and off_t. When checking for
4036 buffer overflow or for overlap, take the offsets into account.
4037 Don't use EMACS_INT for small values where int suffices.
4038 When checking for overlap, fix a typo: ZV was used where
4039 ZV_BYTE was intended.
4040 (Fwrite_region): Don't assume off_t fits into 'long'.
4041 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4043 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4045 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4047 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4049 sprintf-related integer and memory overflow issues (Bug#9412).
4051 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4052 (esprintf, exprintf, evxprintf): New functions.
4053 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4054 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4055 (modify_event_symbol): Do not assume that the length of
4056 name_alist_or_stem is safe to alloca and fits in int.
4057 (Fexecute_extended_command): Likewise for function name and binding.
4058 (Frecursion_depth): Wrap around reliably on integer overflow.
4059 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4060 since some callers pass EMACS_INT values.
4061 (Fsingle_key_description): Don't crash if symbol name contains more
4062 than MAX_ALLOCA bytes.
4063 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4064 (get_minibuffer): Arg is now EMACS_INT, not int.
4065 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4066 (esprintf, exprintf, evxprintf): New decls.
4067 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4069 * dbusbind.c (signature_cat): New function.
4070 (xd_signature, Fdbus_register_signal):
4071 Do not overrun buffer; instead, report string overflow.
4073 * dispnew.c (add_window_display_history): Don't overrun buffer.
4074 Truncate instead; this is OK since it's just a log.
4076 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4077 even if the time zone offset is outlandishly large.
4078 Don't mishandle offset == INT_MIN.
4080 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4081 when creating daemon; the previous buffer-overflow check was incorrect.
4083 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4084 which has the guts of the old verror function.
4086 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4087 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4089 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4090 (font_unparse_xlfd): Don't blindly alloca long strings.
4091 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4092 fits in int, when using sprintf. Use single snprintf to count
4093 length of string rather than counting it via multiple sprintfs;
4094 that's simpler and more reliable.
4095 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4096 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4097 sprintf, in case result does not fit in int.
4099 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4100 (fontset_from_font): Print it.
4102 * frame.c (tty_frame_count): Now printmax_t, not int.
4103 (make_terminal_frame, set_term_frame_name): Print it.
4104 (x_report_frame_params): In X, window IDs are unsigned long,
4105 not signed long, so print them as unsigned.
4106 (validate_x_resource_name): Check for implausibly long names,
4107 and don't assume name length fits in 'int'.
4108 (x_get_resource_string): Don't blindly alloca invocation name;
4109 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4112 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4113 (xg_check_special_colors, xg_set_geometry):
4114 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4116 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4117 Use esprintf, not sprintf, in case result does not fit in int.
4119 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4120 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4121 it as a large positive number.
4122 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4123 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4125 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4126 in case result does not fit in int.
4128 * print.c (float_to_string): Detect width overflow more reliably.
4129 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4130 buffer overrun. Don't assume list length fits in 'int'. Treat
4131 print length of 0 as 0, not as infinity; to be consistent with other
4132 uses of print length in this function. Don't overflow print length
4133 index. Don't assume hash table size fits in 'long', or that
4134 vectorlike size fits in 'unsigned long'.
4136 * process.c (make_process): Use printmax_t, not int, to format
4137 process-name gensyms.
4139 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4141 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4142 to avoid potential buffer overrun.
4144 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4145 if X resource line is longer than 512 bytes.
4147 * xfns.c (x_window): Make sprintf buffer a bit bigger
4148 to avoid potential buffer overrun.
4150 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4152 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4154 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4156 Integer overflow fixes for scrolling, etc.
4157 Without these, Emacs silently mishandles large integers sometimes.
4158 For example, "C-u 4294967297 M-x recenter" was treated as if
4159 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4161 * xdisp.c (try_window_id): Check Emacs fixnum range before
4162 converting to 'int'.
4164 * window.c (window_scroll_line_based, Frecenter):
4165 Check that an Emacs fixnum is in range before assigning it to 'int'.
4166 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4167 values converted from Emacs fixnums.
4168 (Frecenter): Don't wrap around a line count if it is out of 'int'
4169 range; instead, treat it as an extreme value.
4170 (Fset_window_configuration, compare_window_configurations):
4171 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4173 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4174 that can exceed INT_MAX. Check that EMACS_INT value is in range
4175 before assigning it to the (possibly-narrower) index.
4176 (match_limit): Don't assume that a fixnum can fit in 'int'.
4178 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4181 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4182 (Fvertical_motion): Don't wrap around LINES values that don't fit
4183 in 'int'. Instead, treat them as extreme values. This is good
4184 enough for windows, which can't have more than INT_MAX lines anyway.
4186 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4188 * Require libxml/parser.h to avoid compilation warning.
4190 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4192 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4193 since this reportedly can destroy thread storage.
4195 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4197 * syntax.c (find_defun_start): Update all cache variables if
4198 exiting early (Bug#9401).
4200 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4202 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4204 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4205 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4206 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4208 * term.c (tty_append_glyph): New function.
4209 (produce_stretch_glyph): Static function and its prototype deleted.
4211 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4214 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4216 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4217 when checking :margin (Bug#9390).
4218 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4219 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4220 so that the name doesn't mislead. All uses changed.
4222 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4224 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4227 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4229 * xdisp.c (move_it_to): Don't bail out early when reaching
4230 position beyond to_charpos, if we are scanning backwards.
4231 (move_it_vertically_backward): When DY == 0, make sure we get to
4232 the first character in the line after the newline.
4234 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4236 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4237 (ccl_driver): Do not generate an out-of-range pointer.
4238 (Fccl_execute_on_string): Remove unnecessary check for
4239 integer overflow, noted by Stefan Monnier in
4240 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4241 Remove a FIXME that didn't need fixing.
4242 Simplify the newly-introduced buffer reallocation code.
4244 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4246 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4248 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4250 Integer and memory overflow issues (Bug#9196).
4252 * doc.c (get_doc_string): Rework so that
4253 get_doc_string_buffer_size is the actual buffer size, rather than
4254 being 1 less than the actual buffer size; this makes xpalloc more
4257 * image.c (x_allocate_bitmap_record, cache_image):
4258 * xselect.c (Fx_register_dnd_atom):
4259 Simplify previous changes by using xpalloc.
4261 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4262 since either will do and ptrdiff_t is convenient with xpalloc.
4264 * charset.c (charset_table_size)
4265 (struct charset_sort_data.priority): Now ptrdiff_t.
4266 (charset_compare): Don't overflow if priorities differ greatly.
4267 (Fsort_charsets): Don't assume list length fits in int.
4268 Check for size-calculation overflow when allocating sort data.
4269 (syms_of_charset): Allocate an initial charset table that is
4270 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4272 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4274 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4275 The actual value is always <= INT_MAX, and leaving it unsigned made
4276 overflow checking harder.
4278 * dispextern.h (struct glyph_matrix.rows_allocated)
4279 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4280 with xpalloc. The values are still always <= INT_MAX.
4282 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4284 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4285 (SAFE_NALLOCA): New macro.
4287 * region-cache.c (struct boundary.pos, find_cache_boundary)
4288 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4289 (set_cache_region, invalidate_region_cache)
4290 (revalidate_region_cache, know_region_cache, region_cache_forward)
4291 (region_cache_backward, pp_cache):
4292 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4293 so that ptrdiff_t * can be passed to xpalloc.
4294 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4295 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4296 (pp_cache): Don't assume cache_len fits in int.
4297 * region-cache.h: Adjust extern decls to match.
4299 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4300 EMACS_INT, since either will do, for xpalloc.
4302 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4303 (xnmalloc, xnrealloc, xpalloc): New functions.
4305 * bidi.c (bidi_shelve_header_size): New constant.
4306 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4307 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4309 * bidi.c (bidi_cache_shrink):
4310 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4312 Don't update size of array until after memory allocation succeeds,
4313 because xmalloc/xrealloc may not return.
4314 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4315 now that we have proper integer overflow checking.
4316 (record_overlay_string, overlay_strings): Catch overflows when
4317 calculating size of overlay_str_buf.
4319 * callproc.c (Fcall_process): Check for size overflow when
4320 calculating size of args2.
4321 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4322 Normally we prefer signed values, but sticking with ptrdiff_t would
4323 require adding more-complicated checks.
4325 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4326 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4327 Redo buffer-overflow calculations to avoid integer overflow.
4328 Add a FIXME comment where memory seems to be over-allocated.
4330 * character.c (Fstring): Check for size-calculation overflow.
4332 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4333 unnecessary integer overflow. Check for size overflow.
4334 (encode_coding_object): Don't update size until xmalloc succeeds.
4336 * composite.c (get_composition_id): Check for overflow in glyph
4337 length calculations.
4339 Integer and memory overflow fixes for display code.
4340 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4341 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4342 (scrolling_window): Check for overflow in size calculations.
4343 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4344 Don't assume glyph table len fits in int.
4345 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4346 (row_table_size): Now ptrdiff_t, not int.
4347 (scrolling_window): Avoid overflow in size calculations.
4348 Don't update size until allocation succeeds.
4349 * fns.c (concat): Check for overflow in size calculations.
4350 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4351 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4352 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4354 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4355 (get_doc_string): Check for size calculation overflow.
4356 Don't update size until allocation succeeds.
4357 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4358 EMACS_INT, where ptrdiff_t will do.
4359 (Fsubstitute_command_keys): Check for string overflow.
4361 * editfns.c (set_time_zone_rule): Don't assume environment length
4363 (message_length): Now ptrdiff_t, not int.
4364 (Fmessage_box): Don't update size until allocation succeeds.
4365 Don't assume message length fits in int.
4366 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4368 * emacs.c (main): Do not reallocate argv, since there is a null at
4369 the end that can be overwritten, and this way there's no need to
4370 worry about size-calculation overflow.
4371 (sort_args): Check for size-calculation overflow.
4373 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4375 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4377 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4378 (x_set_scroll_bar_width, x_figure_window_size):
4379 Check for integer overflow.
4380 (x_set_alpha): Do not assume XINT fits in int.
4382 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4383 This is for the members text_lines, text_cols, total_lines, total_cols,
4384 where the system imposes an 'int' limit.
4386 * fringe.c (Fdefine_fringe_bitmap):
4387 Don't update size until alloc works.
4389 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4390 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4392 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4393 Check for size-calculation overflow.
4394 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4395 do, as we prefer signed integers.
4396 (id_to_widget.max_size, id_to_widget.used)
4397 (xg_store_widget_in_map, xg_remove_widget_from_map)
4398 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4399 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4400 Use and return ptrdiff_t, not int.
4401 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4402 * gtkutil.h: Change prototypes to match the above.
4404 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4405 are duplicate now that they've been promoted to lisp.h.
4406 (x_allocate_bitmap_record, x_alloc_image_color)
4407 (make_image_cache, cache_image, xpm_load):
4408 Don't update size until alloc is done.
4409 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4411 Check for size calculation overflow.
4412 (ct_colors_allocated_max): New constant.
4413 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4416 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4417 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4418 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4419 Use ptrdiff_t, not int, to count maps.
4420 (read_char_minibuf_menu_prompt): Check for overflow in size
4421 calculations. Don't update size until allocation succeeds.
4422 Redo calculations to avoid overflow.
4423 * keyboard.h: Change prototypes to match the above.
4425 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4427 (current_minor_maps): Check for size calculation overflow.
4428 * keymap.h: Change prototypes to match the above.
4430 * lread.c (read1, init_obarray): Don't update size until alloc done.
4432 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4433 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4435 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4436 Now ptrdiff_t, not int.
4437 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4438 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4440 * process.c (Fnetwork_interface_list): Check for overflow
4441 in size calculation.
4443 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4445 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4446 overflow. Don't bother calling xmalloc when xrealloc will do.
4448 * search.c (Freplace_match): Check for size calculation overflow.
4449 (Fset_match_data): Don't assume list lengths fit in 'int'.
4451 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4452 for command line length. Do not attempt to address one before the
4453 beginning of an array, as that's not portable.
4455 * term.c (max_frame_lines): Remove; unused.
4456 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4458 (encode_terminal_code, calculate_costs): Check for size
4459 calculation overflow.
4460 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4461 table lengths and related sizes. Don't update size until alloc
4462 done. Redo calculations to avoid overflow.
4463 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4465 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4466 subtracting pointers.
4467 (gobble_line): Check for overflow more carefully. Don't update size
4470 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4471 Don't update size until alloc done.
4472 Redo size calculations to avoid overflow.
4473 Check for size calculation overflow.
4474 (main) [DEBUG]: Fix typo in invoking tparam1.
4476 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4477 Use ptrdiff_t, not int, for sizes.
4478 (store_mode_line_noprop_char): Don't update size until alloc done.
4480 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4481 Use ptrdiff_t, not int, for sizes.
4482 (Finternal_make_lisp_face, cache_face):
4483 Check for size calculation overflow.
4484 (cache_face): Treat size calculation overflows as if they were
4485 memory exhaustion (the usual treatment), rather than aborting.
4487 * xfns.c (x_encode_text, x_set_name_internal)
4488 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4489 sizes, since they can exceed INT_MAX in size. Check for size
4490 calculation overflow.
4492 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4493 (xg_select): Check for size calculation overflow.
4494 Don't update size until alloc done.
4496 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4497 as sprintf is limited to int lengths.
4499 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4500 (X_LONG_MIN): New macros.
4501 Use them to make the following changes clearer.
4502 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4503 This change doesn't affect the value now, but it may help remind
4504 future maintainers not to raise the value too much later.
4505 (SELECTION_QUANTUM): Remove, replacing with ...
4506 (selection_quantum): ... new function, which avoids overflow.
4508 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4509 assumption that selection length fits in 'int'.
4510 (x_reply_selection_request, x_handle_selection_request)
4511 (x_get_window_property, receive_incremental_selection)
4512 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4513 (lisp_data_to_selection_data, clean_local_selection_data):
4514 Use ptrdiff_t, not int, to record length of selection.
4515 (x_reply_selection_request, x_get_window_property)
4516 (receive_incremental_selection, x_property_data_to_lisp):
4517 Redo calculations to avoid overflow.
4518 (x_reply_selection_request): When sending hint, ceiling it at
4519 X_LONG_MAX rather than relying on wraparound overflow to send
4521 (x_get_window_property, receive_incremental_selection)
4522 (lisp_data_to_selection_data, x_property_data_to_lisp):
4523 Check for size-calculation overflow.
4524 (x_get_window_property, receive_incremental_selection)
4525 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4526 Don't store size until memory allocation succeeds.
4527 (x_get_window_property): Plug memory leak on memory exhaustion.
4528 Don't double-block input; malloc is safe here. Don't assume 2**34
4529 - 4 fits in unsigned long. Add an xassert to check
4530 XGetWindowProperty overflow. Be more careful about overflow
4531 calculations, and distinguish size from memory overflow better.
4532 (receive_incremental_selection): When tracing, don't assume
4533 unsigned int is less than INT_MAX.
4534 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4535 harmful) conversions of unsigned short to int.
4536 (lisp_data_to_selection_data): Don't assume that integers
4537 in the range -65535 through -1 fit in an X unsigned short.
4538 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4539 result parameters unless successful. Rely on cons_to_unsigned
4540 to report problems with elements; the old code wasn't right anyway.
4541 (x_check_property_data): Check for int overflow; we cannot use
4542 a wider type due to X limits.
4543 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4545 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4547 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4548 (x_term_init): Check for size calculation overflow.
4549 (x_color_cells): Don't store size until memory allocation succeeds.
4550 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4551 Don't assume alloca size is less than MAX_ALLOCA.
4552 (x_term_init): Don't assume length fits in int (sprintf is limited
4555 Use ptrdiff_t for composition IDs.
4556 * character.c (lisp_string_width):
4557 * composite.c (composition_table_size, n_compositions)
4558 (get_composition_id, composition_gstring_from_id):
4559 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4560 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4561 * window.c (Frecenter):
4562 Use ptrdiff_t, not int, for composition IDs.
4563 * composite.c (get_composition_id): Check for integer overflow.
4564 * composite.h: Adjust prototypes to match the above changes.
4566 Use ptrdiff_t for hash table indexes.
4567 * category.c (hash_get_category_set):
4568 * ccl.c (ccl_driver):
4569 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4570 * coding.c (coding_system_charset_list, detect_coding_system):
4571 * coding.h (struct coding_system.id):
4572 * composite.c (get_composition_id, gstring_lookup_cache):
4573 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4574 * image.c (xpm_get_color_table_h):
4575 * lisp.h (hash_lookup, hash_put):
4576 * minibuf.c (Ftest_completion):
4577 Use ptrdiff_t for hash table indexes, not int (which is too
4578 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4579 32-bit --with-wide-int hosts).
4581 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4582 Add a FIXME comment about memory leaks.
4583 (syms_of_charset): Don't assume xmalloc returns.
4585 Don't assume that stated character widths fit in int.
4586 * character.c (Fchar_width, c_string_width, lisp_string_width):
4587 * character.h (CHAR_WIDTH):
4588 * indent.c (MULTIBYTE_BYTES_WIDTH):
4589 Use sanitize_char_width to avoid undefined and/or bad behavior
4590 with outlandish widths.
4591 * character.h (sanitize_tab_width): Rename from sanitize_width,
4592 now that we have two such functions. All uses changed.
4593 (sanitize_char_width): New inline function.
4595 Don't assume that tab-width fits in int.
4596 * character.h (sanitize_width): New inline function.
4597 (SANE_TAB_WIDTH): New macro.
4598 (ASCII_CHAR_WIDTH): Use it.
4599 * indent.c (sane_tab_width): Remove. All uses replaced by
4600 SANE_TAB_WIDTH (current_buffer).
4601 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4603 * fileio.c: Integer overflow issues with file modes.
4604 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4606 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4607 Remove unreachable code.
4608 (read_hex, load_charset_map_from_file): Check for integer overflow.
4610 * xterm.c: Don't go over XClientMessageEvent limit.
4611 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4612 (x_send_scroll_bar_event): Likewise. Check that the size does not
4613 exceed limits imposed by XClientMessageEvent, as well as the usual
4614 ptrdiff_t and size_t limits.
4616 * keyboard.c: Overflow, signedness and related fixes.
4617 (make_lispy_movement): Use same integer type in forward decl
4618 that is used in the definition.
4619 (read_key_sequence, keyremap_step):
4620 Change bufsize argument back to int, undoing my 2011-03-30 change.
4621 We prefer signed types, and int is wide enough here.
4622 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4623 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4624 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4625 length, not size_t. Use ptrdiff_t for index, not int.
4626 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4627 possibility of integer overflow.
4629 Overflow, signedness and related fixes for images.
4631 * dispextern.h (struct it.stack[0].u.image.image_id)
4632 (struct_it.image_id, struct image.id, struct image_cache.size)
4633 (struct image_cache.used, struct image_cache.ref_count):
4634 * gtkutil.c (update_frame_tool_bar):
4635 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4636 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4637 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4638 * nsmenu.m (update_frame_tool_bar):
4639 * xdisp.c (calc_pixel_width_or_height):
4640 * xfns.c (image_cache_refcount):
4641 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4642 on typical 64-bit hosts.
4644 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4645 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4646 Omit unnecessary casts to int.
4647 (parse_image_spec): Check that integers fall into 'int' range
4648 when the callers expect that.
4649 (image_ascent): Redo ascent calculation to avoid int overflow.
4650 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4651 (lookup_image): Remove unnecessary tests.
4652 (xbm_image_p): Locals are now of int, not EMACS_INT,
4653 since parse_image_check makes sure they fit into int.
4654 (png_load, gif_load, svg_load_image):
4655 Prefer int to unsigned where either will do.
4656 (tiff_handler): New function, combining the cores of the
4657 old tiff_error_handler and tiff_warning_handler.
4658 This function is rewritten to use vsnprintf and thereby avoid
4659 stack buffer overflows. It uses only the features of vsnprintf
4660 that are common to both POSIX and native Microsoft.
4661 (tiff_error_handler, tiff_warning_handler): Use it.
4662 (tiff_load, gif_load, imagemagick_load_image):
4663 Don't assume :index value fits in 'int'.
4664 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4665 (imagemagick_load_image): Check that crop parameters fit into
4666 the integer types that MagickCropImage accepts. Don't assume
4667 Vimagemagick_render_type has a nonnegative value. Don't assume
4668 size_t fits in 'long'.
4669 (gs_load): Use printmax_t to print the widest integers possible.
4670 Check for integer overflow when computing image height and width.
4672 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4674 * xdisp.c (redisplay_window): Don't force window start if point
4675 will be invisible in the resulting window. (Bug#9324)
4677 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4679 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4680 the display spec is of the form `(space ...)'.
4681 (handle_display_spec): Return the value returned by
4682 handle_single_display_spec, not just 1 or zero.
4683 (handle_single_display_spec): If the display spec is of the form
4684 `(space ...)', and specifies display in the text area, return 2
4686 (try_cursor_movement): Check for the need to scroll more
4687 accurately, and prefer exact match for point under bidi.
4688 Don't advance `row' beyond the last row of the window.
4690 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4691 into disp_prop; all users changed.
4693 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4694 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4695 for the text covered by the display property.
4697 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4699 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4700 Change return value to nil.
4701 (Frecord_buffer): Delete unused function.
4703 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4705 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4706 buffers, return left-to-right.
4707 (set_cursor_from_row): Consider candidate row a win if its glyph
4708 represents a newline and point is on that newline. Fixes cursor
4709 positioning on the newline at EOL of R2L text within L2R
4710 paragraph, and vice versa.
4711 (try_cursor_movement): Check continued rows, in addition to
4712 continuation rows. Fixes unwarranted scroll when point enters a
4713 continued line of R2L text within an L2R paragraph, or vice versa.
4714 (cursor_row_p): Consider the case of point being equal to
4715 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4716 from the end of a short line to the beginning of a continued line
4717 of R2L text within L2R paragraph.
4718 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4719 composed characters.
4721 * bidi.c (bidi_check_type): Use xassert.
4722 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4725 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4727 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4730 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4732 * nsfont.m (ns_otf_to_script): Fix typo.
4734 2011-08-22 Kenichi Handa <handa@m17n.org>
4736 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4737 extra slot even if the purpose is char-code-property-table.
4739 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4741 * xdisp.c (redisplay_window): When computing centering_position,
4742 account for the height of the header line. (Bug#8874)
4744 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4745 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4746 candidate is selected by the mouse, and that candidate has a
4747 composed character under the mouse.
4749 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4750 coordinates reported by pos-visible-in-window-p for a composed
4751 character in column zero.
4753 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4755 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4757 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4759 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4760 consider it a hit if to_charpos is anywhere in the range of the
4761 composed buffer positions.
4763 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4765 * image.c (gif_load): Don't assume that each subimage has the same
4766 dimensions as the base image. Handle disposal method that is
4767 "undefined" by the gif spec (Bug#9335).
4769 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4771 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4772 (Fcondition_case): Document `debug' symbol in error handler.
4774 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4776 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4777 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4778 from an Org mode buffer to a Speedbar frame.
4780 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4781 a composition, take its buffer position from IT->cmp_it.charpos.
4782 Fixes cursor positioning at the beginning of a line that begins
4783 with a composed character.
4785 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4787 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4788 character bidirectional type, use STRONG_L instead. Fixes crashes
4789 in a buffer produced by `describe-categories'.
4791 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4792 members before the level stack, so they would be saved and
4793 restored when copying iterator state. Fixes incorrect reordering
4794 around TABs covered by display properties.
4796 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4798 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4800 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4802 * eval.c (internal_condition_case, internal_condition_case_1)
4803 (internal_condition_case_2, internal_condition_case_n):
4804 Remove unnecessary aborts (Bug#9081).
4806 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4808 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4809 has no `load' handler, try opening the file locally. (Bug#9311)
4811 2011-08-16 Ken Brown <kbrown@cornell.edu>
4813 * gmalloc.c: Expand comment.
4815 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4817 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4818 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4820 2011-08-16 Ken Brown <kbrown@cornell.edu>
4822 Fix memory allocation problems in Cygwin build (Bug#9273).
4824 * unexcw.c ( __malloc_initialized): Declare external variable.
4825 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4827 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4829 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4831 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4833 [CYGWIN] (special_realloc): New function.
4834 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4835 requests to realloc storage in the static heap.
4837 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4839 * bidi.c (bidi_initialize): Remove unused local.
4841 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4844 * biditype.h: Remove file.
4845 * makefile.w32-in ($(BLD)/bidi.$(O)):
4846 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4848 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4850 * chartab.c: Improve commentary for the uniprop_table API.
4852 * bidi.c (bidi_paragraph_init): Support zero value of
4853 bidi_ignore_explicit_marks_for_paragraph_level.
4854 (bidi_initialize): Use uniprop_table instead of including
4855 biditype.h and bidimirror.h.
4857 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4858 coordinates of the iterator when restoring from ppos_it.
4861 2011-08-14 Kenichi Handa <handa@m17n.org>
4863 * process.c (create_process): Call setup_process_coding_systems
4864 after the pid of the process is set to -1 (Bug#8162).
4866 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4868 * xdisp.c (move_it_in_display_line_to): Don't invoke
4869 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4870 ppos_it. Fixes vertical cursor motion when line beginning is
4871 covered by an image. (Bug#9296)
4873 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4875 * nsterm.h (ns_run_ascript): Declare.
4876 (NSAPP_DATA2_RUNASSCRIPT): Define.
4878 * nsfns.m (as_script, as_result, as_status): New static variables.
4879 (ns_run_ascript): New function.
4880 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4881 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4882 the event loop. Get status from as_status (Bug#7276).
4884 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4885 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4886 the event loop (Bug#7276).
4888 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4890 * gnutls.c (QCgnutls_bootprop_priority)
4891 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4892 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4893 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4894 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4895 (QCgnutls_bootprop_verify_hostname_error)
4896 (QCgnutls_bootprop_callbacks_verify): Rename from
4897 Qgnutls_bootprop_..., all uses changed.
4899 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4902 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4904 * xfaces.c (Qframe_set_background_mode): Now static.
4905 * dispextern.h (Qframe_set_background_mode): Remove decl.
4907 * process.c (Fnetwork_interface_info): Declare local only if needed.
4909 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4911 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4912 (Fnetwork_interface_list): Allocate in increments of bytes instead
4913 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4914 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4916 (struct ifflag_def): notrailers is smart on OSX.
4917 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4918 Get hardware address with getifaddrs if available.
4920 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4922 * xdisp.c (iterate_out_of_display_property): xassert that
4923 IT->position is set to within IT->object's boundaries. Break from
4924 the loop as soon as EOB is reached; avoids infloops in redisplay
4925 when IT->position is set up wrongly due to some bug.
4926 Set IT->current to match the bidi iterator unconditionally.
4927 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4928 entry. Force push_it to save on the stack the current
4929 buffer/string position, to be restored by pop_it. Fix flags in
4930 the iterator structure wrt the object coming from a display
4931 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4932 properties. (Bug#9284)
4934 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4936 * fontset.c (fontset_get_font_group): Add proper type checks.
4939 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4941 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4942 and LC_VERSION_MIN_MACOSX.
4943 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4944 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4946 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4948 * xdisp.c (forward_to_next_line_start): Allow to use the
4949 no-display-properties-and-no-overlays under bidi display.
4950 Set disp_pos in the bidi iterator to avoid searches for display
4951 properties and overlays.
4953 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4955 * editfns.c (Fset_time_zone_rule): Document relationship with the
4958 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4959 the font entity extracted from the cache (Bug#8109).
4961 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4963 * composite.c (autocmp_chars): Don't reset point. That is done by
4964 restore_point_unwind (Bug#5984).
4966 2011-08-07 Juri Linkov <juri@jurta.org>
4968 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4969 to show the arg `TIME' instead of `TIMEVAL'.
4971 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4973 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4974 display property strides EOL and includes a newline, as in
4975 longlines-mode. (Bug#9254)
4976 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4977 word-wrap under bidirectional display. (Bug#9224)
4979 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4980 is non-zero, even if the data buffer is NULL. Fixes a crash in
4981 vertical-motion with longlines-mode. (Bug#9254)
4983 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4985 * bidi.c <bidi_cache_total_alloc>: Now static.
4986 (bidi_initialize): Initialize bidi_cache_total_alloc.
4988 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4991 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4992 amount allocated this far in `bidi_cache_total_alloc'.
4993 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4994 non-zero, only free the data buffer without restoring the cache
4995 contents. All callers changed.
4997 * dispextern.h (bidi_unshelve_cache): Update prototype.
4999 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5000 (move_it_in_display_line, move_it_to)
5001 (move_it_vertically_backward, move_it_by_lines): Replace the call
5002 to xfree to an equivalent call to bidi_unshelve_cache.
5003 (move_it_in_display_line_to): Fix logic of returning
5004 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5006 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5008 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5009 came from a string character with a `cursor' property. (Bug#9229)
5011 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5013 * Makefile.in (LIB_PTHREAD): New variable.
5014 (LIBES): Add LIB_PTHREAD (Bug#9216).
5016 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5017 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5019 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5021 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5023 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5025 * xterm.c (x_find_topmost_parent): New function.
5026 (x_set_frame_alpha): Find topmost parent window with
5027 x_find_topmost_parent and set the property there also (bug#9181).
5028 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5030 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5032 * callproc.c (Fcall_process): Avoid vfork clobbering
5033 the local vars buffer, coding_systems, current_dir.
5035 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5037 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5039 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5041 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5042 so that it is not optimized away.
5044 * xdisp.c (compute_display_string_pos): Remove unused local.
5046 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5048 Fix slow cursor motion and scrolling in large buffers with
5049 selective display, like Org Mode buffers. (Bug#9218)
5051 * dispextern.h (struct bidi_it): New member disp_prop_p.
5053 * xdisp.c: Remove one-slot cache of display string positions.
5054 (compute_display_string_pos): Accept an additional argument
5055 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5056 for a display string or property. If found, set DISP_PROP_P
5059 * bidi.c (bidi_fetch_char): Accept an additional argument
5060 DISP_PROP_P, and pass it to compute_display_string_pos.
5061 Only handle text covered by a display string if DISP_PROP_P is returned
5062 non-zero. All callers of bidi_fetch_char changed.
5064 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5066 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5068 2010-12-03 Don March <don@ohspite.net>
5070 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5071 last character M-[char] is translated to ESC [char] (bug#7541).
5073 2011-08-02 Kenichi Handa <handa@m17n.org>
5075 * lisp.h (uniprop_table): Extern it.
5077 * chartab.c (uniprop_table): Make it non-static.
5079 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5081 * xdisp.c (forward_to_next_line_start): Accept additional argument
5082 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5084 (reseat_at_next_visible_line_start): Use the bidi iterator state
5085 returned by forward_to_next_line_start to restore the state of
5086 it->bidi_it after backing up to previous newline. (Bug#9212)
5088 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5090 * regex.c (re_comp): Protoize.
5091 (re_exec): Fix return type.
5092 (regexec): Fix type of `ret'. (Bug#9203)
5094 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5096 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5097 This is needed if max-image-size is a floating-point number.
5099 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5101 * print.c (print_object): Print empty symbol as ##.
5103 * lread.c (read1): Read ## as empty symbol.
5105 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5107 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5108 setting frame foreground color (Bug#9175).
5109 (x_set_background_color): Likewise.
5111 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5112 contents (Bug#9176).
5113 (EmacsTooltip -init): Remove bezels and add shadows to
5116 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5117 or scroll bar (Bug#8470).
5119 * nsfont.m (nsfont_open): Remove assignment to voffset and
5120 unnecessary vars hshink, expand, hd, full_height, min_height.
5121 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5123 * nsterm.h (nsfont_info): Remove voffset field.
5125 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5127 Implement strike-through and overline on NextStep (Bug#8863).
5129 * nsfont.m (nsfont_open): Use underline position provided by font,
5130 instead of hard-coded value of 2.
5131 (nsfont_draw): Call ns_draw_text_decoration instead.
5133 * nsterm.h: Add declaration for ns_draw_text_decoration.
5135 * nsterm.m (ns_draw_text_decoration): New function for drawing
5136 underline, overline, and strike-through.
5137 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5138 ns_draw_text_decoration. Change treatment of cursor drawing to
5139 accommodate underlining, etc.
5141 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5143 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5146 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5148 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5149 Without this fix, if a signal arrives just after memory fills up,
5150 'malloc' might be invoked reentrantly.
5152 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5153 In other words, assume that every image size is allowed, on non-X
5154 hosts. This assumption is probably wrong, but it lets Emacs compile.
5156 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5158 * regex.c (re_iswctype): Convert return values to boolean.
5160 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5162 * xdisp.c (compute_display_string_pos): Don't use cached display
5163 string position if the buffer had its restriction changed.
5166 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5168 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5170 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5172 Integer signedness and overflow and related fixes. (Bug#9079)
5174 * bidi.c: Integer size and overflow fixes.
5175 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5176 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5177 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5178 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5179 (bidi_find_other_level_edge):
5180 Use ptrdiff_t instead of EMACS_INT where either will do.
5181 This works better on 32-bit hosts configured --with-wide-int.
5182 (bidi_cache_ensure_space): Check for size-calculation overflow.
5183 Use % rather than repeated addition, for better worst-case speed.
5184 Don't set bidi_cache_size until after xrealloc returns, because it
5186 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5187 (bidi_cache_ensure_space): Also check that the bidi cache size
5188 does not exceed that of the largest Lisp string or buffer. See Eli
5189 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5191 * alloc.c (__malloc_size_t): Remove.
5192 All uses replaced by size_t. See Andreas Schwab's note
5193 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5195 * image.c: Improve checking for integer overflow.
5196 (check_image_size): Assume that f is nonnull, since
5197 it is always nonnull in practice. This is one less thing to
5198 worry about when checking for integer overflow later.
5199 (x_check_image_size): New function, which checks for integer
5200 overflow issues inside X.
5201 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5202 This removes the need for a memory_full check.
5203 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5204 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5205 (xbm_read_bitmap_data): Change locals back to 'int', since
5206 their values must fit in 'int'.
5207 (xpm_load_image, png_load, tiff_load):
5208 Invoke x_create_x_image_and_pixmap earlier,
5209 to avoid much needless work if the image is too large.
5210 (tiff_load): Treat overly large images as if
5211 x_create_x_image_and_pixmap failed, not as malloc failures.
5212 (gs_load): Use x_check_image_size.
5214 * gtkutil.c: Omit integer casts.
5215 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5216 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5218 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5220 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5221 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5222 would wrongly return t on a 64-bit host.
5224 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5225 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5226 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5227 and therefore cause GCC to emit a bogus diagnostic in some cases.
5229 * image.c: Integer signedness and overflow and related fixes.
5230 This is not an exhaustive set of fixes, but it's time to
5231 record what I've got.
5232 (lookup_pixel_color, check_image_size): Remove redundant decls.
5233 (check_image_size): Don't assume that arbitrary EMACS_INT values
5234 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5235 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5236 (tiff_load, imagemagick_load_image):
5237 Check for overflow in size calculations.
5238 (x_create_x_image_and_pixmap): Remove unnecessary test for
5239 xmalloc returning NULL; that can't happen.
5240 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5241 (xpm_color_bucket): Use better integer hashing function.
5242 (xpm_cache_color): Don't possibly over-allocate memory.
5243 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5244 (gif_memory_source):
5245 Use ptrdiff_t, not int or size_t, to record sizes.
5246 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5247 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5248 either works, as we prefer signed integers.
5249 (tiff_read_from_memory, tiff_write_from_memory):
5250 Return tsize_t, not size_t, since that's what the TIFF API wants.
5251 (tiff_read_from_memory): Don't fail simply because the read would
5252 go past EOF; instead, return a short read.
5253 (tiff_load): Omit no-longer-needed casts.
5254 (Fimagemagick_types): Don't assume size fits into 'int'.
5256 Improve hashing quality when configured --with-wide-int.
5257 * fns.c (hash_string): New function, taken from sxhash_string.
5258 Do not discard information about ASCII character case; this
5259 discarding is no longer needed.
5260 (sxhash-string): Use it. Change sig to match it. Caller changed.
5261 * lisp.h: Declare it.
5262 * lread.c (hash_string): Remove, since we now use fns.c's version.
5263 The fns.c version returns a wider integer if --with-wide-int is
5264 specified, so this should help the quality of the hashing a bit.
5266 * emacs.c: Integer overflow minor fix.
5267 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5268 Define only if GNU_LINUX.
5269 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5271 * dispnew.c: Integer signedness and overflow fixes.
5272 Remove unnecessary forward decls, that were a maintenance hassle.
5273 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5275 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5276 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5277 (prepare_desired_row, line_draw_cost):
5278 Use int, not unsigned, where either works.
5279 (save_current_matrix, restore_current_matrix):
5280 Use ptrdiff_t, not size_t, where either works.
5281 (init_display): Check for overflow more accurately, and without
5282 relying on undefined behavior.
5284 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5285 Remove, replacing with the new symbols in lisp.h. All uses changed.
5286 * fileio.c (make_temp_name):
5287 * filelock.c (lock_file_1, lock_file):
5288 * xdisp.c (message_dolog):
5289 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5290 Use pMd etc. instead.
5291 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5292 replacing the pWIDE etc. symbols removed from editfns.c.
5294 * keyboard.h (num_input_events): Now uintmax_t.
5295 This is (very slightly) less likely to mess up due to wraparound.
5298 * buffer.c: Integer signedness fixes.
5299 (alloc_buffer_text, enlarge_buffer_text):
5300 Use ptrdiff_t rather than size_t when either will do, as we prefer
5303 * alloc.c: Integer signedness and overflow fixes.
5304 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5305 (__malloc_size_t): Default to size_t, not to int.
5306 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5307 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5308 Prefer ptrdiff_t to size_t when either would do, as we prefer
5310 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5311 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5312 Now const. Initialize with values that are in range even if char
5314 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5315 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5316 These functions do the right thing with sizes > 2**32.
5317 (check_depth): Now ptrdiff_t, not int.
5318 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5319 Adjust to new way of storing sizes. Check for size overflow bugs
5321 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5322 slightly wrong anyway, as it missed one instance of
5323 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5324 (refill_memory_reserve): Omit needless cast to size_t.
5325 (mark_object_loop_halt): Mark as externally visible.
5327 * xselect.c: Integer signedness and overflow fixes.
5328 (Fx_register_dnd_atom, x_handle_dnd_message):
5329 Use ptrdiff_t, not size_t, since we prefer signed.
5330 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5331 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5332 x_dnd_atoms_size and x_dnd_atoms_length.
5334 * doprnt.c: Prefer signed to unsigned when either works.
5336 * doprnt.c (doprnt):
5338 * xdisp.c (vmessage):
5339 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5340 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5341 prefer signed arithmetic to avoid comparison confusion.
5342 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5343 but is a bit tricky.
5345 Assume freestanding C89 headers, string.h, stdlib.h.
5346 * data.c, doprnt.c, floatfns.c, print.c:
5347 Include float.h unconditionally.
5348 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5349 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5350 * regex.c: Likewise for stddef.h, string.h.
5351 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5352 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5353 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5354 (STDC_HEADERS): Remove obsolete defines.
5355 * sysdep.c: Include limits.h unconditionally.
5357 Assume support for memcmp, memcpy, memmove, memset.
5358 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5359 * regex.c (memcmp, memcpy):
5360 Remove; we assume C89 now.
5362 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5363 (__malloc_safe_bcopy): Remove; no longer needed.
5365 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5366 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5367 well either way, and we prefer signed to unsigned.
5369 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5371 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5372 closes the connection while we're reading (bug#9182).
5374 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5376 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5377 are specified (Bug#9168).
5379 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5381 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5382 Found by GCC static checking and --with-wide-int on a 32-bit host.
5384 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5386 * xdisp.c (compute_display_string_pos): Fix logic of caching
5387 previous display string position. Initialize cached_prev_pos to
5388 -1. Fixes slow-down at the beginning of a buffer.
5390 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5392 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5393 for attrs[LFACE_FONTSET_INDEX].
5395 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5397 * xml.c (parse_region): Remove unused local
5398 that was recently introduced.
5400 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5402 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5403 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5405 * xdisp.c (move_it_in_display_line_to): Record the best matching
5406 position for TO_CHARPOS while scanning the line, and restore it on
5407 exit if none of the characters scanned was an exact match.
5408 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5409 when exact match is impossible due to invisible text, and the
5410 lines are truncated.
5412 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5414 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5417 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5419 Fix a significant slow-down of cursor motion with C-n, C-p,
5420 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5421 auto-repeat under bidi redisplay in fontified buffers.
5422 * xdisp.c (compute_stop_pos_backwards): New function.
5423 (next_element_from_buffer): Call compute_stop_pos_backwards to
5424 find a suitable prev_stop when we find ourselves before
5426 (reseat): Don't look for prev_stop, as that could mean a very long
5428 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5429 <cached_disp_overlay_modiff>: Cache for last found display string
5431 (compute_display_string_pos): Return the cached position if asked
5432 about the same buffer in the same area of character positions, and
5433 the buffer wasn't changed since the time the display string
5434 position was cached.
5436 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5438 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5439 is an integer, which is important for empty lines. (Bug#9149)
5441 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5443 * frame.c (Fmodify_frame_parameters): In tty case, update the
5444 default face if necessary (Bug#4238).
5446 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5448 * editfns.c (Fstring_to_char): No need to explain what a character
5449 is in the docstring (Bug#6576).
5451 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5453 * xml.c (parse_region): Make sure we always return a tree.
5455 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5457 * xml.c (parse_region): If a document contains only comments,
5460 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5462 * xml.c (make_dom): Return comments, too.
5464 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5467 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5468 and the surrounding thread.
5469 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5470 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5471 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5473 * s/openbsd.h (BROKEN_SIGIO): Define.
5474 * unexelf.c (unexec) [__OpenBSD__]:
5475 Don't update the .mdebug section of the Alpha COFF symbol table.
5477 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5479 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5482 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5484 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5485 This fixes some race conditions on the permissions of any newly
5488 * alloc.c (valid_pointer_p): Use pipe, not open.
5489 This fixes some permissions issues when debugging.
5491 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5492 If fchown fails to set both uid and gid, try to set just gid,
5493 as that is sometimes allowed. Adjust the file's mode to eliminate
5494 setuid or setgid bits that are inappropriate if fchown fails.
5496 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5498 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5499 to compare Lisp_Objects.
5500 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5501 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5502 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5504 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5506 * lread.c (read_integer): Unread even EOF character.
5507 (read1): Likewise. Properly record start position of symbol.
5509 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5510 symbol character follows.
5512 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5514 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5515 This works around a problem with the previous change to Fcopy_file.
5516 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5517 and without this change, GCC might complain about discarding
5518 fchown's return value.
5520 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5522 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5524 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5526 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5528 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5530 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5531 it's used from the C level.
5533 * process.c: Use the same condition for POLL_FOR_INPUT in both
5534 keyboard.c and process.c (bug#1858).
5536 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5538 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5539 (Fgnutls_boot): Use it.
5541 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5543 * doc.c (Fsubstitute_command_keys): Revert last change.
5545 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5547 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5548 quotes the next character, and doesn't affect other longer
5549 sequences (bug#8935).
5551 * lread.c (syms_of_lread): Clarify that is isn't only
5552 `eval-buffer' and `eval-defun' that's affected by
5553 `lexical-binding' (bug#8460).
5555 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5557 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5558 bidi redisplay when a line includes both an image and is truncated.
5560 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5562 Fix minor problems found by static checking.
5563 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5564 (elsz): Now a signed constant, not a size_t var. We prefer signed
5565 types to unsigned, to avoid integer comparison confusion. Without
5566 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5567 "cannot optimize loop, the loop counter may overflow", a symptom
5569 * indent.c (Fvertical_motion): Mark locals as initialized.
5570 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5572 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5574 * search.c (Fre_search_backward): Mention `case-fold-search' in
5575 all the re_search_* functions (bug#8138).
5577 * keyboard.c (Fopen_dribble_file): Document when the file is
5580 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5582 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5585 Support bidi reordering of display and overlay strings.
5586 * xdisp.c (compute_display_string_pos)
5587 (compute_display_string_end): Accept additional argument STRING.
5588 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5589 (reseat_to_string): Initialize bidi_it->string.s and
5590 bidi_it->string.schars.
5591 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5592 NULL (avoids a crash in bidi_paragraph_init).
5593 Initialize itb.string.lstring.
5594 (init_iterator): Call bidi_init_it only of a valid
5595 buffer position was specified. Initialize paragraph_embedding to
5597 (reseat_to_string): Initialize the bidi iterator.
5598 (display_string): If we need to ignore text properties of
5599 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5600 original value of -1 will not work with bidi.)
5601 (compute_display_string_pos): First arg is now struct
5602 `text_pos *'; all callers changed. Support display properties on
5604 (compute_display_string_end): Support display properties on Lisp
5606 (init_iterator, reseat_1, reseat_to_string): Initialize the
5607 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5608 when iterating on a string not from display properties).
5609 (compute_display_string_pos, compute_display_string_end):
5610 Fix calculation of the object to scan. Fixes an error when using
5612 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5613 base_level_stop; instead, set base_level_stop to BEGV.
5614 Fixes crashes in vertical-motion.
5615 (next_element_from_buffer): Improve commentary for when
5616 the iterator is before prev_stop.
5617 (init_iterator): Initialize bidi_p from the default value of
5618 bidi-display-reordering, not from buffer-local value. Use the
5619 buffer-local value only if initializing for buffer iteration.
5620 (handle_invisible_prop): Support invisible properties on strings
5621 that are being bidi-reordered.
5622 (set_iterator_to_next): Support bidi reordering of C strings and
5624 (next_element_from_string): Support bidi reordering of Lisp
5626 (handle_stop_backwards): Support Lisp strings as well.
5627 (display_string): Support display of R2L glyph rows.
5628 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5629 (init_iterator): Don't initialize it->bidi_p for strings
5631 (reseat_to_string): Initialize it->bidi_p for strings here.
5632 (next_element_from_string, next_element_from_c_string)
5633 (next_element_from_buffer): Add xassert's for correspondence
5634 between IT's object being iterated and it->bidi_it.string
5636 (face_before_or_after_it_pos): Support bidi iteration.
5637 (next_element_from_c_string): Handle the case of the first string
5638 character that is not the first one in the visual order.
5639 (get_visually_first_element): New function, refactored from common
5640 parts of next_element_from_buffer, next_element_from_string, and
5641 next_element_from_c_string.
5642 (tool_bar_lines_needed, redisplay_tool_bar)
5643 (display_menu_bar): Force left-to-right direction. Add a FIXME
5644 comment for making that be controlled by a user option.
5645 (push_it, pop_it): Save and restore the state of the
5646 bidi iterator. Save and restore the bidi_p flag.
5647 (pop_it): Iterate out of display property for string iteration as
5649 (iterate_out_of_display_property): Support iteration over strings.
5650 (handle_single_display_spec): Set up it->bidi_it for iteration
5651 over a display string, and call bidi_init_it.
5652 (handle_single_display_spec, next_overlay_string)
5653 (get_overlay_strings_1, push_display_prop): Set up the bidi
5654 iterator for displaying display or overlay strings.
5655 (forward_to_next_line_start): Don't use the shortcut if
5657 (back_to_previous_visible_line_start): If handle_display_prop
5658 pushed the iterator stack, restore the internal state of the bidi
5659 iterator by calling bidi_pop_it same number of times.
5660 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5661 and we are bidi-iterating, don't decrement the iterator position;
5662 instead, set the first_elt flag in the bidi iterator, to produce
5664 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5665 (push_display_prop): xassert that we are iterating a buffer.
5666 (push_it, pop_it): Save and restore paragraph_embedding member.
5667 (handle_single_display_spec, next_overlay_string)
5668 (get_overlay_strings_1, reseat_1, reseat_to_string)
5669 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5670 correctly. Don't assume unibyte strings are not bidi-reordered.
5671 (compute_display_string_pos)
5672 (compute_display_string_end): Fix handling the case of C string.
5673 (push_it, pop_it): Save and restore from_disp_prop_p.
5674 (handle_single_display_spec, push_display_prop): Set the
5675 from_disp_prop_p flag.
5676 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5677 (pop_it): Call iterate_out_of_display_property only if we are
5678 popping after iteration over a string that came from a display
5679 property. Fix a typo in popping stretch info. Add an assertion
5680 for verifying that the iterator position is in sync with the bidi
5682 (handle_single_display_spec, get_overlay_strings_1)
5683 (push_display_prop): Fix initialization of paragraph direction for
5684 string when that of the parent object is not yet determined.
5685 (reseat_1): Call bidi_init_it to resync the bidi
5686 iterator with IT's position. (Bug#7616)
5687 (find_row_edges): If ROW->start.pos gives position
5688 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5689 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5690 Reset the from_disp_prop_p flag.
5691 (SAVE_IT, RESTORE_IT): New macros.
5692 (pos_visible_p, face_before_or_after_it_pos)
5693 (back_to_previous_visible_line_start)
5694 (move_it_in_display_line_to, move_it_in_display_line)
5695 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5696 (try_scrolling, redisplay_window, display_line): Use them when
5697 saving a temporary copy of the iterator and restoring it back.
5698 (back_to_previous_visible_line_start, reseat_1)
5699 (init_iterator): Empty the bidi cache "stack".
5700 (move_it_in_display_line_to): If iterator ended up at
5701 EOL, but we never saw any buffer positions smaller than
5702 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5703 motion in bidi-reordered lines.
5704 (move_it_in_display_line_to): Record prev_method and prev_pos
5705 immediately before the call to set_iterator_to_next. Fixes cursor
5706 motion in bidi-reordered lines with stretch glyphs and strings
5707 displayed in margins. (Bug#8133) (Bug#8867)
5708 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5710 (pos_visible_p): Support positions in bidi-reordered lines.
5711 Save and restore bidi cache.
5713 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5714 (bidi_paragraph_info): Delete unused struct.
5715 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5716 (bidi_cache_start): New variable.
5717 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5719 (bidi_cache_fetch_state, bidi_cache_search)
5720 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5721 (bidi_cache_find, bidi_peek_at_next_level)
5722 (bidi_level_of_next_char, bidi_find_other_level_edge)
5723 (bidi_move_to_visually_next): Compare cache index with
5724 bidi_cache_start rather than with zero.
5725 (bidi_fetch_char): Accept new argument STRING; all callers
5726 changed. Support iteration over a string. Support strings with
5727 display properties. Support unibyte strings. Fix the type of
5728 `len' according to what STRING_CHAR_AND_LENGTH expects.
5729 (bidi_paragraph_init, bidi_resolve_explicit_1)
5730 (bidi_resolve_explicit, bidi_resolve_weak)
5731 (bidi_level_of_next_char, bidi_move_to_visually_next):
5732 Support iteration over a string.
5733 (bidi_set_sor_type, bidi_resolve_explicit_1)
5734 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5735 can now be zero (for strings); special values 0 and -1 were
5736 changed to -1 and -2, respectively.
5737 (bidi_char_at_pos): New function.
5738 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5739 Call it instead of FETCH_MULTIBYTE_CHAR.
5740 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5741 initialized to valid values.
5742 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5744 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5745 the test for valid cached positions. Fix the logic for looking up
5746 the sentinel state in the cache. GCPRO the Lisp string we are
5748 (bidi_push_it, bidi_pop_it): New functions.
5749 (bidi_initialize): Initialize the bidi cache start stack pointer.
5750 (bidi_cache_ensure_space): New function, refactored from part of
5751 bidi_cache_iterator_state. Don't assume the required size is just
5752 one BIDI_CACHE_CHUNK away.
5753 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5754 (bidi_count_bytes, bidi_char_at_pos): New functions.
5755 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5756 always valid if bidi_cache_idx is valid.
5757 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5758 is valid if it's going to be used.
5759 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5760 (bidi_cache_fetch_state, bidi_cache_search)
5761 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5762 (bidi_cache_iterator_state, bidi_cache_find)
5763 (bidi_find_other_level_edge, bidi_cache_start_stack):
5764 All variables related to cache indices are now EMACS_INT.
5766 * dispextern.h (struct bidi_string_data): New structure.
5767 (struct bidi_it): New member `string'. Make flag members be 1-bit
5768 fields, and put them last in the struct.
5769 (compute_display_string_pos, compute_display_string_end):
5771 (bidi_push_it, bidi_pop_it): Add prototypes.
5772 (struct iterator_stack_entry): New members bidi_p,
5773 paragraph_embedding, and from_disp_prop_p.
5774 (struct it): Member bidi_p is now a bit field 1 bit wide.
5775 (bidi_shelve_cache, bidi_unshelve_cache):
5778 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5779 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5780 and vector-like objects.
5782 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5783 cache around display iteration.
5785 * window.c (Fwindow_end, window_scroll_pixel_based)
5786 (displayed_window_lines, Frecenter): Save and restore the bidi
5787 cache around display iteration.
5789 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5791 * editfns.c (Fdelete_region): Clarify the use of the named
5792 parameters (bug#6788).
5794 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5796 * indent.c (Fvertical_motion): Set and restore w->pointm when
5797 saving and restoring the window's buffer (Bug#9006).
5799 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5801 * editfns.c (Fstring_to_char): Clarify just what is returned
5802 (bug#6576). Text by Eli Zaretskii.
5804 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5806 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5808 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5810 * buffer.c (mmap_find): Fix a typo.
5812 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5814 Fix execution of x selection hooks.
5815 * xselect.c (Qx_lost_selection_functions)
5816 (Qx_sent_selection_functions): New vars.
5817 (syms_of_xselect): DEFSYM them.
5818 (x_handle_selection_request): Pass Qx_sent_selection_functions
5819 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5820 (x_handle_selection_clear,x_clear_frame_selections):
5821 Pass Qx_lost_selection_functions rather than
5822 Vx_lost_selection_functions to Frun_hook_with_args.
5824 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5826 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5827 The old code sometimes used this field without initializing it.
5829 * alloc.c (gc_sweep): Don't read past end of array.
5830 In theory, the old code could also have corrupted Emacs internals,
5831 though it'd be very unlikely.
5833 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5835 * character.c (Fcharacterp): Don't advertise optional ignored
5836 argument. (Bug#4026)
5838 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5840 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5843 * window.c (Fset_window_start): Doc fix (bug#4199).
5844 (Fset_window_hscroll): Ditto.
5846 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5848 Fix minor new problems caught by GCC 4.6.1.
5849 * term.c (init_tty): Remove unused local.
5850 * xsettings.c (store_monospaced_changed): Define this function only
5851 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5854 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5856 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5858 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5860 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5861 are the mini-buffer and the echo area (bug#3320).
5863 * term.c (init_tty): Remove support for supdup, c10 and perq
5864 terminals, which are no longer supported (bug#1482).
5866 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5868 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5870 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5872 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5873 for non-popups (Bug#3642).
5875 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5877 * alloc.c (reset_malloc_hooks): Protoize.
5878 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5879 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5880 * cm.c (losecursor): Likewise.
5881 * data.c (fmod): Likewise.
5882 * dispnew.c (swap_glyphs_in_rows): Likewise.
5883 * emacs.c (memory_warning_signal): Likewise.
5884 * floatfns.c (float_error): Likewise.
5885 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5886 (otf_open, font_otf_capability, generate_otf_features)
5887 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5889 * image.c (pbm_read_file): Likewise.
5890 * indent.c (string_display_width): Likewise.
5891 * intervals.c (check_for_interval, search_for_interval)
5892 (inc_interval_count, count_intervals, root_interval)
5893 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5894 * lread.c (defalias): Likewise.
5895 * ralloc.c (r_alloc_check): Likewise.
5896 * regex.c (set_image_of_range_1, set_image_of_range)
5897 (regex_grow_registers): Likewise.
5898 * sysdep.c (strerror): Likewise.
5899 * termcap.c (valid_filename_p, tprint, main): Likewise.
5900 * tparam.c (main): Likewise.
5901 * unexhp9k800.c (run_time_remap, save_data_space)
5902 (update_file_ptrs, read_header, write_header, calculate_checksum)
5903 (copy_file, copy_rest, display_header): Likewise.
5904 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5906 * xdisp.c (check_it): Likewise.
5907 * xfaces.c (register_color, unregister_color, unregister_colors):
5909 * xfns.c (print_fontset_result): Likewise.
5910 * xrdb.c (member, fatal, main): Likewise.
5912 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5914 Fix minor problems found by static checking (Bug#9031).
5915 * chartab.c (char_table_set_range, map_sub_char_table):
5916 Remove unused locals.
5917 (uniprop_table): Now static.
5918 * composite.c (_work_char): Remove unused static var.
5920 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5922 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5924 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5926 * gtkutil.c (qttip_cb): Remove code without function.
5928 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5930 * w32.c (pthread_sigmask): New stub.
5932 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5934 Use pthread_sigmask, not sigprocmask (Bug#9010).
5935 sigprocmask is portable only for single-threaded applications, and
5936 Emacs can be multi-threaded when it uses GTK.
5937 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5939 * callproc.c (Fcall_process):
5940 * process.c (create_process):
5941 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5942 Use pthread_sigmask, not sigprocmask.
5944 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5946 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5947 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5950 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5952 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5953 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5954 (xg_hide_tooltip): Fix comment.
5956 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5957 in registerServicesMenuSendTypes.
5958 (validRequestorForSendType): Don't check ns_return_types.
5960 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5963 2011-07-08 Jason Rumney <jasonr@gnu.org>
5965 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5966 SH_SHOW for hidden windows (Bug#5482).
5968 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5969 frame struct members of non-existent frames (Bug#6284).
5971 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5973 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5974 variable firstTime not needed on OSX >= 10.6.
5975 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5976 >= 10.5. Use setKnobProportion, setDoubleValue.
5978 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5979 (MAC_OS_X_VERSION_10_5): Define if not defined.
5980 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5981 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5982 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5984 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5985 cString and lossyCString on OSX >= 10.4
5987 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5988 sizeToFit on OSX >= 10.2.
5990 * nsimage.m (allocInitFromFile): Don't use deprecated method
5991 bestRepresentationForDevice on OSX >= 10.6.
5993 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5996 * emacs.c: Declare unexec_init_emacs_zone.
5998 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6000 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6002 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6003 on svcsMenu (Bug#8842).
6005 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6007 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6009 * nsterm.m (QUTF8_STRING): Declare.
6010 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6011 (validRequestorForSendType): Return type is (id).
6012 Change indexOfObjectIdenticalTo to indexOfObject.
6013 Check if we have local selection before returning self (Bug#8842).
6014 (writeSelectionToPasteboard): Put local selection into paste board
6015 if we have a local selection (Bug#8842).
6016 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6018 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6019 (ns_get_local_selection): Declare.
6021 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6023 * keymap.c (describe_map_tree): Don't insert a double newline at
6024 the end of the buffer (bug#1169) and return whether we inserted
6027 * callint.c (Fcall_interactively): Change "reading args" to
6028 "providing args" to try to clarify what it does (bug#1010).
6030 2011-07-07 Kenichi Handa <handa@m17n.org>
6032 * composite.c (composition_compute_stop_pos): Ignore a static
6033 composition starting before CHARPOS (Bug#8915).
6035 * xdisp.c (handle_composition_prop): Likewise.
6037 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6039 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6042 2011-07-07 Kenichi Handa <handa@m17n.org>
6044 * character.h (unicode_category_t): New enum type.
6046 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6047 (Qchar_code_property_table): New variable.
6048 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6049 (UNIPROP_COMPRESSED_FORM_P): New macros.
6050 (char_table_ascii): Uncompress the compressed values.
6051 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6052 Uncompress the compressed values.
6053 (sub_char_table_ref_and_range): Likewise.
6054 (char_table_ref_and_range): Uncompress the compressed values.
6055 (sub_char_table_set): New arg is_uniprop. Callers changed.
6056 Uncompress the compressed values.
6057 (sub_char_table_set_range): Args changed. Callers changed.
6058 (char_table_set_range): Adjuted for the above change.
6059 (map_sub_char_table): Delete args default_val and parent. Add arg
6060 top. Give decoded values to a Lisp function.
6061 (map_char_table): Adjust for the above change. Give decoded
6062 values to a Lisp function. Gcpro more variables.
6063 (uniprop_table_uncompress)
6064 (uniprop_decode_value_run_length): New functions.
6065 (uniprop_decoder, uniprop_decoder_count): New variables.
6066 (uniprop_get_decoder, uniprop_encode_value_character)
6067 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6069 (uniprop_encoder, uniprop_encoder_count): New variables.
6070 (uniprop_get_encoder, uniprop_table)
6071 (Funicode_property_table_internal, Fget_unicode_property_internal)
6072 (Fput_unicode_property_internal): New functions.
6073 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6074 Sunicode_property_table_internal, Sget_unicode_property_internal,
6075 and Sput_unicode_property_internal. Defvar_lisp
6076 char-code-property-alist.
6078 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6079 Vunicode_category_table.
6081 * font.c (font_range): Adjust for the change of
6082 Vunicode_category_table.
6084 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6086 * m/iris4d.h: Remove file, move contents ...
6087 * s/irix6-5.h: ... here.
6089 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6091 Remove unportable assumption about struct layout (Bug#8884).
6092 * alloc.c (mark_buffer):
6093 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6094 (clone_per_buffer_values): Don't assume that
6095 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6096 This isn't true in general, and it's particularly not true
6097 if Emacs is configured with --with-wide-int.
6098 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6099 New macros, used in the buffer.c change.
6101 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6103 * xsettings.c: Use both GConf and GSettings if both are available.
6104 (store_config_changed_event): Add comment.
6105 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6106 (store_tool_bar_style_changed): New functions.
6107 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6108 (struct xsettings): Move font inside HAVE_XFT.
6109 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6110 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6111 Move inside HAVE_XFT.
6112 (something_changed_gsettingsCB): Rename from something_changedCB.
6113 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6115 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6116 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6117 (something_changed_gconfCB): Rename from something_changedCB.
6118 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6119 (parse_settings): Move check for font inside HAVE_XFT.
6120 (read_settings, apply_xft_settings): Add comment.
6121 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6122 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6123 call store_font_name_changed.
6124 (xft_settings_event): Add comment.
6125 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6126 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6127 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6128 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6129 (xsettings_initialize): Call init_gsettings last.
6130 (xsettings_get_system_font, xsettings_get_system_normal_font):
6133 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6135 Random fixes. E.g., (random) never returned negative values.
6136 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6137 subseconds part to the entropy, as that's a bit more random.
6138 Prefer signed to unsigned, since the signedness doesn't matter and
6139 in general we prefer signed. When given a limit, use a
6140 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6141 latter isn't right if USE_2_TAGS_FOR_INTS.
6142 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6143 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6145 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6147 * textprop.c (text_property_stickiness):
6148 Obey Vtext_property_default_nonsticky.
6149 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6150 * w32fns.c (syms_of_w32fns):
6151 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6153 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6155 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6156 This is more efficient than Ffile_directory_p and avoids a minor race.
6158 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6160 * buffer.c (Foverlay_put): Say what the return value is
6163 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6164 is a directory before asking whether to use the file name
6166 (barf_or_query_if_file_exists): Make the "File is a directory"
6167 error be more correct.
6169 * fns.c (Frequire): Remove the mention of the .gz files, since
6170 that's installation-specific, but keep the mention of
6171 `get-load-suffixes'.
6173 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6175 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6176 Report string overflow if the output is too long.
6178 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6180 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6181 (syms_of_gnutls): Remove duplicate DEFSYM for
6182 Qgnutls_bootprop_verify_hostname_error, an error for
6183 Qgnutls_bootprop_verify_error (which is no longer used).
6185 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6186 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6187 Also (re)move comments that are misplaced or no longer relevant.
6189 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6191 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6193 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6195 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6196 and background color parameters if they have been changed.
6198 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6200 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6202 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6204 * xsettings.c (SYSTEM_FONT): Define only when used.
6205 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6207 * keymap.c (access_keymap_1): Now static.
6209 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6211 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6212 leave any prefix arg for the up event (Bug#1586).
6214 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6216 * lread.c (syms_of_lread): Mention single symbols defined by
6217 `defvar' or `defconst' (bug#7154).
6219 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6220 (Frequire): Mention get-load-suffixes.
6222 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6224 * window.h (window): Remove clone_number slot.
6225 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6227 (make_parent_window, make_window, saved_window)
6228 (Fset_window_configuration, save_window_save): Don't deal with
6230 * buffer.c (Qclone_number): Remove declaration.
6231 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6233 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6235 Add multiple inheritance to keymaps.
6236 * keymap.c (Fmake_composed_keymap): New function.
6237 (Fset_keymap_parent): Simplify.
6238 (fix_submap_inheritance): Remove.
6239 (access_keymap_1): New function extracted from access_keymap to handle
6240 embedded parents and handle lists of maps.
6241 (access_keymap): Use it.
6242 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6243 (Fcopy_keymap): Handle embedded parents.
6244 (Fcommand_remapping, define_as_prefix): Simplify.
6245 (Fkey_binding): Simplify.
6246 (syms_of_keymap): Move minibuffer-local-completion-map,
6247 minibuffer-local-filename-completion-map,
6248 minibuffer-local-must-match-map, and
6249 minibuffer-local-filename-must-match-map to Elisp.
6250 (syms_of_keymap): Defsubr make-composed-keymap.
6251 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6252 (parse_menu_item): Trivial simplification.
6254 2011-07-01 Glenn Morris <rgm@gnu.org>
6256 * Makefile.in (SETTINGS_LIBS): Fix typo.
6258 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6260 * coding.c (Fencode_coding_string): Record the last coding system
6261 used, as the function doc string says (bug#8738).
6263 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6265 * xsettings.c (store_monospaced_changed): Take new font as arg and
6266 check for change against current_mono_font.
6267 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6268 (emacs_settings_constructor, emacs_settings_get_property)
6269 (emacs_settings_set_property, emacs_settings_class_init)
6270 (emacs_settings_init, gsettings_obj): Remove.
6271 (something_changedCB): New function for HAVE_GSETTINGS.
6272 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6273 with value as argument.
6274 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6275 g_settings_new (Bug#8967). Do not create gsettings_obj.
6276 Remove calls to g_settings_bind. Connect something_changedCB to
6279 * xgselect.c: Add defined (HAVE_GSETTINGS).
6280 (xgselect_initialize): Ditto.
6282 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6283 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6286 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6288 * eval.c (struct backtrace): Simplify and port the data structure.
6289 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6290 signed bit field, as this assumption is not portable and it makes
6291 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6292 "char debug_on_exit : 1" as this is not portable either; instead,
6293 use the portable "unsigned int debug_on_exit : 1". Remove unused
6294 member evalargs. Remove obsolete comments about cc bombing out.
6296 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6298 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6299 Let HAVE_GSETTINGS override HAVE_GCONF.
6300 (store_monospaced_changed): New function.
6301 (EMACS_SETTINGS): A new type derived from GObject to handle
6302 GSettings notifications.
6303 (emacs_settings_constructor, emacs_settings_get_property)
6304 (emacs_settings_set_property, emacs_settings_class_init):
6306 (gsettings_client, gsettings_obj): New variables.
6307 (GSETTINGS_SCHEMA): New define.
6308 (something_changedCB): Call store_monospaced_changed.
6309 (init_gsettings): New function.
6310 (xsettings_initialize): Call init_gsettings.
6311 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6314 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6317 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6319 * window.c (resize_root_window, grow_mini_window)
6320 (shrink_mini_window): Rename Qresize_root_window to
6321 Qwindow_resize_root_window and Qresize_root_window_vertically to
6322 Qwindow_resize_root_window_vertically.
6324 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6326 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6328 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6330 * makefile.w32-in: Redesign dependencies so they reflect more
6331 clearly which files are directly included by each source file,
6332 and not through other includes.
6334 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6336 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6337 (sort_overlays, overlay_strings): When an overlay's clone number
6338 matches the window's clone number process the overlay even if
6339 the overlay's window property doesn't match the current window.
6341 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6342 (Fwindow_hchild): Rename to Fwindow_left_child.
6343 (Fwindow_next): Rename to Fwindow_next_sibling.
6344 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6345 (resize_window_check): Rename to window_resize_check.
6346 (resize_window_apply): Rename to window_resize_apply.
6347 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6348 (Fdelete_other_windows_internal, resize_frame_windows)
6349 (Fsplit_window_internal, Fdelete_window_internal)
6350 (grow_mini_window, shrink_mini_window)
6351 (Fresize_mini_window_internal): Fix callers accordingly.
6353 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6355 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6356 (emacs_fixed_set_min_size): Remove.
6357 (emacs_fixed_new): Take frame as argument.
6359 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6360 (_EmacsFixedPrivate): Remove minwidth/height.
6361 Add struct frame *f.
6362 (emacs_fixed_init): Initialize priv->f.
6363 (get_parent_class, emacs_fixed_set_min_size): Remove.
6364 (emacs_fixed_new): Set priv->f to argument.
6365 (emacs_fixed_get_preferred_width)
6366 (emacs_fixed_get_preferred_height): Use min_width/height from
6367 frames size_hint to set minimum and natural (Bug#8919).
6368 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6369 and use min_width/height from frames size_hint to set
6370 min_width/height (Bug#8919).
6372 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6373 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6376 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6378 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6379 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6382 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6384 * process.c (wait_reading_process_output): Bypass select if
6385 waiting for a cell while ignoring keyboard input, and input is
6386 pending. Suggested by Jan Djärv (Bug#8869).
6388 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6390 Use gnulib's dup2 module instead of rolling our own.
6391 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6393 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6395 * dispnew.c (scrolling_window): Before scrolling, turn off a
6396 mouse-highlight in the window being scrolled.
6398 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6400 Move DEFSYM to lisp.h and use everywhere.
6402 * character.h (DEFSYM): Move declaration...
6403 * lisp.h (DEFSYM): ...here.
6409 * w32select.c: Don't include character.h.
6411 * alloc.c (syms_of_alloc):
6412 * buffer.c (syms_of_buffer):
6413 * bytecode.c (syms_of_bytecode):
6414 * callint.c (syms_of_callint):
6415 * casefiddle.c (syms_of_casefiddle):
6416 * casetab.c (init_casetab_once):
6417 * category.c (init_category_once, syms_of_category):
6418 * ccl.c (syms_of_ccl):
6419 * cmds.c (syms_of_cmds):
6420 * composite.c (syms_of_composite):
6421 * dbusbind.c (syms_of_dbusbind):
6422 * dired.c (syms_of_dired):
6423 * dispnew.c (syms_of_display):
6424 * doc.c (syms_of_doc):
6425 * editfns.c (syms_of_editfns):
6426 * emacs.c (syms_of_emacs):
6427 * eval.c (syms_of_eval):
6428 * fileio.c (syms_of_fileio):
6429 * fns.c (syms_of_fns):
6430 * frame.c (syms_of_frame):
6431 * fringe.c (syms_of_fringe):
6432 * insdel.c (syms_of_insdel):
6433 * keymap.c (syms_of_keymap):
6434 * lread.c (init_obarray, syms_of_lread):
6435 * macros.c (syms_of_macros):
6436 * msdos.c (syms_of_msdos):
6437 * print.c (syms_of_print):
6438 * process.c (syms_of_process):
6439 * search.c (syms_of_search):
6440 * sound.c (syms_of_sound):
6441 * syntax.c (init_syntax_once, syms_of_syntax):
6442 * terminal.c (syms_of_terminal):
6443 * textprop.c (syms_of_textprop):
6444 * undo.c (syms_of_undo):
6445 * w32.c (globals_of_w32):
6446 * window.c (syms_of_window):
6447 * xdisp.c (syms_of_xdisp):
6448 * xfaces.c (syms_of_xfaces):
6449 * xfns.c (syms_of_xfns):
6450 * xmenu.c (syms_of_xmenu):
6451 * xsettings.c (syms_of_xsettings):
6452 * xterm.c (syms_of_xterm): Use DEFSYM.
6454 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6456 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6458 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6460 Integer and buffer overflow fixes (Bug#8873).
6462 * print.c (printchar, strout): Check for string overflow.
6463 (PRINTPREPARE, printchar, strout):
6464 Don't set size unless allocation succeeds.
6466 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6467 for sizes. Check for string overflow more accurately.
6468 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6470 * macros.c: Integer and buffer overflow fixes.
6471 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6472 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6473 Use ptrdiff_t, not int, for sizes.
6474 Don't increment bufsize until after realloc succeeds.
6475 Check for size-calculation overflow.
6476 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6478 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6480 * lread.c: Integer overflow fixes.
6481 (read_integer): Radix is now EMACS_INT, not int,
6482 to improve quality of diagnostics for out-of-range radices.
6483 Calculate buffer size correctly for out-of-range radices.
6484 (read1): Check for integer overflow in radices, and in
6485 read-circle numbers.
6486 (read_escape): Avoid int overflow.
6487 (Fload, openp, read_buffer_size, read1)
6488 (substitute_object_recurse, read_vector, read_list, map_obarray):
6489 Use ptrdiff_t, not int, for sizes.
6490 (read1): Use EMACS_INT, not int, for sizes.
6491 Check for size overflow.
6493 * image.c (cache_image): Check for size arithmetic overflow.
6495 * lread.c: Integer overflow issues.
6496 (saved_doc_string_size, saved_doc_string_length)
6497 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6498 Now ptrdiff_t, not int.
6499 (read1): Don't assume doc string length fits in int. Check for
6500 out-of-range doc string lengths.
6501 (read_list): Don't assume file position fits in int.
6502 (read_escape): Check for hex character overflow.
6504 2011-06-22 Leo Liu <sdl.web@gmail.com>
6506 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6507 Move to minibuffer.el.
6509 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6511 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6512 The following patches are for when GLYPH_DEBUG && !XASSERT.
6513 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6514 * dispnew.c (flush_stdout):
6515 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6516 Mark as externally visible.
6517 * dispnew.c (check_window_matrix_pointers): Now static.
6518 * dispnew.c (window_to_frame_vpos):
6519 * xfns.c (unwind_create_frame):
6520 * xterm.c (x_check_font): Remove unused local.
6521 * scroll.c (CHECK_BOUNDS):
6522 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6523 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6524 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6525 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6526 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6528 (debug_method_add): Use va_list and vsprintf rather than relying
6529 on undefined behavior with wrong number of arguments.
6530 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6531 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6532 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6533 since we're not interested in debugging glyphs with old libraries.
6534 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6535 GCC 4.6.0's static checking.
6537 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6539 Integer overflow and signedness fixes (Bug#8873).
6540 A few related buffer overrun fixes, too.
6542 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6544 * dispextern.h (struct face.stipple):
6545 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6546 (x_bitmap_mask, x_allocate_bitmap_record)
6547 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6548 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6549 (x_create_bitmap_from_xpm_data):
6550 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6551 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6553 * xfaces.c (load_pixmap):
6554 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6555 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6556 (.bitmaps_last, struct x_output.icon_bitmap):
6557 Use ptrdiff_t, not int, for bitmap indexes.
6558 (x_allocate_bitmap_record): Check for size overflow.
6559 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6561 Use ptrdiff_t, not int, for overlay counts.
6562 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6563 * editfns.c (overlays_around, get_pos_property):
6564 * textprop.c (get_char_property_and_overlay):
6565 * xdisp.c (next_overlay_change, note_mouse_highlight):
6566 * xfaces.c (face_at_buffer_position):
6567 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6568 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6569 (Fnext_overlay_change, Fprevious_overlay_change)
6570 (mouse_face_overlay_overlaps, Foverlays_in):
6571 Use ptrdiff_t, not int, for sizes.
6572 (overlays_at, overlays_in): Check for size-calculation overflow.
6574 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6576 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6577 (x_session_initialize): Do not assume string length fits in int.
6579 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6580 This is unlikely, but can occur if DPI is outlandish.
6582 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6583 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6585 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6586 * xrdb.c (magic_file_p, search_magic_path):
6587 Omit last arg SUFFIX; it was always 0. All callers changed.
6588 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6590 * xfont.c (xfont_match): Avoid need for strlen.
6592 * xfns.c: Don't assume strlen fits in int.
6593 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6595 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6596 not unsigned long, as we prefer signed integers. All callers changed.
6597 Detect integer overflow in repeat count.
6598 (message_dolog): Don't assume print length fits in 39 bytes.
6599 (display_mode_element): Don't assume strlen fits in int.
6601 * termcap.c: Don't assume sizes fit in int and never overflow.
6602 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6603 (gobble_line): Check for size-calculation overflow.
6605 * minibuf.c (Fread_buffer):
6606 * lread.c (intern, intern_c_string):
6607 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6608 Don't assume string length fits in int.
6610 * keyboard.c (parse_tool_bar_item):
6611 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6613 * font.c: Don't assume string length fits in int.
6614 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6615 Use ptrdiff_t, not int.
6616 (font_intern_prop): Don't assume string length fits in int.
6617 Don't assume integer property fits in fixnum.
6618 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6620 * filelock.c: Fix some buffer overrun and integer overflow issues.
6621 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6622 Reformulate so as not to need the command string.
6623 Invoke gzip -cd rather than gunzip, as it's more portable.
6624 (lock_info_type, lock_file_1, lock_file):
6625 Don't assume pid_t and time_t fit in unsigned long.
6626 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6627 (current_lock_owner): Prefer signed type for sizes.
6628 Use memcpy, not strncpy, where memcpy is what is really wanted.
6629 Don't assume (via atoi) that time_t and pid_t fit in int.
6630 Check for time_t and/or pid_t out of range, e.g., via a network share.
6631 Don't alloca where an auto var works fine.
6633 * fileio.c: Fix some integer overflow issues.
6634 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6635 Don't assume string length fits in int.
6636 (directory_file_name): Don't assume string length fits in long.
6637 (make_temp_name): Don't assume pid fits in int, or that its print
6638 length is less than 20.
6640 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6642 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6644 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6646 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6647 We prefer signed integers, even for size calculations.
6649 * emacs.c: Don't assume string length fits in 'int'.
6650 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6651 (main): Don't invoke strlen when not needed.
6653 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6654 (XD_DEBUG_MESSAGE): Don't waste a byte.
6656 * callproc.c (getenv_internal_1, getenv_internal)
6658 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6660 * lread.c (invalid_syntax): Omit length argument.
6661 All uses changed. This doesn't fix a bug, but it simplifies the
6662 code away from its former Hollerith-constant appearance, and it's
6663 one less 'int' to worry about when looking at integer-overflow issues.
6664 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6666 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6667 This didn't break anything, but it didn't help either.
6668 It's confusing to put a bogus integer in a place where the actual
6669 value does not matter.
6670 (LIST_END_P): Remove unused macro and its bogus comment.
6671 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6673 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6674 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6676 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6677 We prefer signed types, and the value cannot exceed the EMACS_INT
6678 range anyway (because otherwise the length would not be representable).
6679 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6680 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6681 This avoids a GCC warning when WIDE_EMACS_INT.
6683 * indent.c (sane_tab_width): New function.
6684 (current_column, scan_for_column, Findent_to, position_indentation)
6685 (compute_motion): Use it. This is just for clarity.
6686 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6688 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6690 * lisp.h (lint_assume): New macro.
6691 * composite.c (composition_gstring_put_cache):
6692 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6694 * editfns.c, insdel.c:
6695 Omit unnecessary forward decls, to simplify future changes.
6697 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6699 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6701 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6702 Use much-faster test for byte-length change.
6703 Don't assume string byte-length fits in 'int'.
6704 Check that character arg fits in 'int'.
6705 (mapcar1): Declare byte as byte, for clarity.
6707 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6709 * fns.c (concat): Catch string overflow earlier.
6710 Do not rely on integer wraparound.
6712 * dispextern.h (struct it.overlay_strings_charpos)
6713 (struct it.selective): Now EMACS_INT, not int.
6714 * xdisp.c (forward_to_next_line_start)
6715 (back_to_previous_visible_line_start)
6716 (reseat_at_next_visible_line_start, next_element_from_buffer):
6717 Don't arbitrarily truncate the value of 'selective' to int.
6719 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6721 * composite.c: Don't truncate sizes to 'int'.
6722 (composition_gstring_p, composition_reseat_it)
6723 (composition_adjust_point): Use EMACS_INT, not int.
6724 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6725 not EMACS_UINT, for indexes.
6727 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6729 * buffer.c: Include <verify.h>.
6730 (struct sortvec.priority, struct sortstr.priority):
6731 Now EMACS_INT, not int.
6732 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6733 (struct sortstr.size, record_overlay_string)
6734 (struct sortstrlist.size, struct sortlist.used):
6735 Don't truncate size to int.
6736 (record_overlay_string): Check for size-calculation overflow.
6737 (init_buffer_once): Check at compile-time, not run-time.
6739 2011-06-22 Jim Meyering <meyering@redhat.com>
6741 Don't leak an XBM-image-sized buffer
6742 * image.c (xbm_load): Free the image buffer after using it.
6744 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6747 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6748 that Sun C diagnosed.
6749 * fns.c (secure_hash): Fix pointer signedness issue.
6750 * intervals.c (static_offset_intervals): New function.
6751 (offset_intervals): Use it.
6753 2011-06-21 Leo Liu <sdl.web@gmail.com>
6756 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6759 * fns.c (secure_hash): Rename from crypto_hash_function and change
6760 the first arg to accept symbols.
6761 (Fsecure_hash): New primitive.
6762 (syms_of_fns): New symbols.
6764 2011-06-20 Deniz Dogan <deniz@dogan.se>
6766 * process.c (Fset_process_buffer): Clarify return value in
6769 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6771 * dispnew.c (add_window_display_history): Use BVAR.
6773 * xdisp.c (debug_method_add): Use BVAR.
6774 (check_window_end, dump_glyph_matrix, dump_glyph)
6775 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6777 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6780 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6781 check till after the cache is created in init_frame_faces.
6783 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6785 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6787 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6789 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6790 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6791 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6793 Improve buffer-overflow checking (Bug#8873).
6794 * fileio.c (Finsert_file_contents):
6795 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6796 Remove the old (too-loose) buffer overflow checks.
6797 They weren't needed, since make_gap checks for buffer overflow.
6798 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6799 The old code merely checked for Emacs fixnum overflow, and relied
6800 on undefined (wraparound) behavior. The new code avoids undefined
6801 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6803 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6804 Tune. Don't use wider integers than needed. Don't use alloca.
6805 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6807 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6809 * insdel.c, lisp.h (buffer_overflow): New function.
6810 (insert_from_buffer_1, replace_range, replace_range_2):
6811 * insdel.c (make_gap_larger):
6812 * editfns.c (Finsert_char):
6813 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6815 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6817 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6819 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6821 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6822 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6824 * fileio.c: Don't assume EMACS_INT fits in off_t.
6825 (emacs_lseek): New static function.
6826 (Finsert_file_contents, Fwrite_region): Use it.
6827 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6829 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6831 * fns.c: Don't overflow int when computing a list length.
6832 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6833 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6834 truncation on 64-bit hosts. Check for QUIT every
6835 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6836 faster and is responsive enough.
6837 (Flength): Report an error instead of overflowing an integer.
6838 (Fsafe_length): Return a float if the value is not representable
6839 as a fixnum. This shouldn't happen except in contrived situations.
6840 (Fnthcdr, Fsort): Don't assume list length fits in int.
6841 (Fcopy_sequence): Don't assume vector length fits in int.
6843 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6844 (header_size, word_size): New constants.
6845 (allocate_vectorlike): Don't check size overflow here.
6846 (allocate_vector): Check it here instead, since this is the only
6847 caller of allocate_vectorlike that could cause overflow.
6848 Check that the new vector's length is representable as a fixnum.
6850 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6851 The previous code was bogus. For example, next_almost_prime (32)
6852 returned 39, which is undesirable as it is a multiple of 3; and
6853 next_almost_prime (24) returned 25, which is a multiple of 5 so
6854 why was the code bothering to check for multiples of 7?
6856 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6858 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6860 Variadic C functions now count arguments with ptrdiff_t.
6861 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6862 Back then I didn't know that the Emacs coding style prefers signed int.
6863 Also, in the meantime I found a few more instances where arguments
6864 were being counted with int, which may truncate counts on 64-bit
6865 machines, or EMACS_INT, which may be unnecessarily wide.
6866 * lisp.h (struct Lisp_Subr.function.aMANY)
6867 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6868 Arg counts are now ptrdiff_t, not size_t.
6869 All variadic functions and their callers changed accordingly.
6870 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6871 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6872 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6873 * callint.c (Fcall_interactively): Check arg count for overflow,
6874 to avoid potential buffer overrun. Use signed char, not 'int',
6875 for 'varies' array, so that we needn't bother to check its size
6876 calculation for overflow.
6877 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6878 * eval.c (apply_lambda):
6879 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6880 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6881 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6883 * callint.c (Fcall_interactively): Don't use index var as event count.
6885 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6886 * mem-limits.h (SIZE): Remove; no longer used.
6888 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6890 Remove unnecessary casts.
6891 * xterm.c (x_term_init):
6892 * xfns.c (x_set_border_pixel):
6893 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6894 These aren't needed now that we assume ANSI C.
6896 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6897 It's more likely to cause problems (due to unsigned overflow)
6900 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6902 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6904 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6906 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6908 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6910 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6912 GLYPH_CODE_FACE returns EMACS_INT, not int.
6913 * dispextern.h (merge_faces):
6914 * xfaces.c (merge_faces):
6915 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6916 Don't assume EMACS_INT fits in int.
6918 * character.h (CHAR_VALID_P): Remove unused parameter.
6919 * fontset.c, lisp.h, xdisp.c: All uses changed.
6921 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6923 * fns.c (concat): Minor tuning based on overflow analysis.
6924 This doesn't fix any bugs. Use int to hold character, instead
6925 of constantly refetching from Emacs object. Use XFASTINT, not
6926 XINT, for value known to be a character. Don't bother comparing
6927 a single byte to 0400, as it's always less.
6929 * floatfns.c (Fexpt):
6930 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6932 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6935 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6937 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6938 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6939 incorrectly succeed when S was a string, because 4294967386 was
6940 truncated before it was used.
6942 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6943 Otherwise, an out-of-range integer could cause undefined behavior
6946 * composite.c: Use int, not EMACS_INT, for characters.
6947 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6948 EMACS_INT, for values that are known to be in character range.
6949 This doesn't fix any bugs but is the usual style inside Emacs and
6950 may generate better code on 32-bit machines.
6952 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6953 This is for reasons similar to the recent CHAR_STRING fix.
6954 * charset.c (Fencode_char): Check that character arg is actually
6955 a character. Pass an int to ENCODE_CHAR.
6956 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6957 wider than 'int', as a compile-time check to prevent future regressions
6960 * character.c (char_string): Remove unnecessary casts.
6962 Make sure a 64-bit char is never passed to CHAR_STRING.
6963 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6964 by silently ignoring the top 32 bits, allowing some values
6965 that were far too large to be valid characters.
6966 * character.h: Include <verify.h>.
6967 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6968 arguments are no wider than unsigned, as a compile-time check
6969 to prevent future regressions in this area.
6971 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6972 (Fsubst_char_in_region):
6974 * xdisp.c (decode_mode_spec_coding):
6975 Adjust to CHAR_STRING's new requirement.
6976 * editfns.c (Finsert_char, Fsubst_char_in_region):
6977 * fns.c (concat): Check that character args are actually
6978 characters. Without this test, these functions did the wrong
6979 thing with wildly out-of-range values on 64-bit hosts.
6981 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6982 These casts should not be needed on 32-bit hosts, either.
6983 * keyboard.c (read_char):
6984 * lread.c (Fload): Remove casts to unsigned.
6986 * lisp.h (UNSIGNED_CMP): New macro.
6987 This fixes comparison bugs on 64-bit hosts.
6988 (ASCII_CHAR_P): Use it.
6989 * casefiddle.c (casify_object):
6990 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6991 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6992 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6993 * dispextern.h (FACE_FROM_ID):
6994 * keyboard.c (read_char): Use UNSIGNED_CMP.
6996 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6997 not to EMACS_INT, to avoid GCC warning.
6999 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7001 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7002 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7003 isn't needed on 32-bit machines.
7005 * buffer.c (Fgenerate_new_buffer_name):
7006 Use EMACS_INT for count, not int.
7007 (advance_to_char_boundary): Return EMACS_INT, not int.
7009 * data.c (Qcompiled_function): Now static.
7011 * window.c (window_body_lines): Now static.
7013 * image.c (gif_load): Rename local to avoid shadowing.
7015 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7016 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7017 * alloc.c (make_save_value): Integer argument is now of type
7019 (mark_object): Use ptrdiff_t, not int.
7020 * lisp.h (pD): New macro.
7021 * print.c (print_object): Use it.
7023 * alloc.c: Use EMACS_INT, not int, to count objects.
7024 (total_conses, total_markers, total_symbols, total_vector_size)
7025 (total_free_conses, total_free_markers, total_free_symbols)
7026 (total_free_floats, total_floats, total_free_intervals)
7027 (total_intervals, total_strings, total_free_strings):
7028 Now EMACS_INT, not int. All uses changed.
7029 (Fgarbage_collect): Compute overall total using a double, so that
7030 integer overflow is less likely to be a problem. Check for overflow
7031 when converting back to an integer.
7032 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7033 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7034 These were 'int' variables that could overflow on 64-bit hosts;
7035 they were never used, so remove them instead of repairing them.
7036 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7037 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7038 Previously, this ceilinged at INT_MAX, but that doesn't work on
7040 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7042 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7043 (allocate_vectorlike): Check for ptrdiff_t overflow.
7044 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7045 when a (possibly-narrower) signed value would do just as well.
7046 We prefer using signed arithmetic, to avoid comparison confusion.
7048 * alloc.c: Catch some string size overflows that we were missing.
7049 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7050 for convenience in STRING_BYTES_MAX.
7051 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7052 The definition here is exact; the one in lisp.h was approximate.
7053 (allocate_string_data): Check for string overflow. This catches
7054 some instances we weren't catching before. Also, it catches
7055 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7056 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7057 and ptrdiff_t and EMACS_INT are both 64 bits.
7059 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7060 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7061 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7063 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7065 * alloc.c (Fmake_string): Check for out-of-range init.
7067 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7069 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7071 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7073 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7074 xg_get_default_scrollbar_width.
7076 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7077 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7078 (style_changed_cb): Call update_theme_scrollbar_width and call
7079 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7080 all frames (Bug#8505).
7081 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7082 Call gtk_window_set_resizable if HAVE_GTK3.
7083 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7084 and height if HAVE_GTK3 (Bug#8505).
7085 (scroll_bar_width_for_theme): New variable.
7086 (update_theme_scrollbar_width): New function.
7087 (xg_get_default_scrollbar_width): Move code to
7088 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7089 (xg_initialize): Call update_theme_scrollbar_width.
7091 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7093 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7095 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7097 * frame.c (make_frame): Call other_buffer_safely instead of
7100 * window.c (temp_output_buffer_show): Call display_buffer with
7101 second argument Vtemp_buffer_show_specifiers and reset latter
7102 immediately after the call.
7103 (Vtemp_buffer_show_specifiers): New variable.
7104 (auto_window_vscroll_p, next_screen_context_lines)
7105 (Vscroll_preserve_screen_position): Remove leading asterisks from
7108 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7110 Fix minor problems found by GCC 4.6.0 static checking.
7111 * buffer.c (Qclone_number): Remove for now, as it's unused.
7112 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7113 (record_buffer): Remove unused local.
7114 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7115 (set_frame_buffer_list): Remove; unused.
7116 * frame.h (other_visible_frames): Remove decl.
7117 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7118 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7119 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7121 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7122 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7123 Define only if HAVE_GPM.
7124 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7125 (update_hints_inhibit): Remove; never set. All uses removed.
7126 * widgetprv.h (emacsFrameClassRec): Remove decl.
7127 * window.c (delete_deletable_window): Now returns void, since it
7128 wasn't returning anything.
7129 (compare_window_configurations): Remove unused locals.
7130 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7131 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7132 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7133 the same widths as pointers. This follows up on the 2011-05-06 patch.
7134 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7135 * xterm.h: Likewise.
7136 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7138 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7140 * makefile.w32-in: Update dependencies.
7141 (LISP_H): Add lib/intprops.h.
7143 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7145 * image.c (gif_load): Add animation frame delay to the metadata.
7146 (syms_of_image): Use DEFSYM. New symbol `delay'.
7148 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7150 * window.c (delete_deletable_window): Re-add.
7151 (Fset_window_configuration): Rewrite to handle dead buffers and
7152 consequently deletable windows.
7153 (window_tree, Fwindow_tree): Remove. Supply functionality in
7155 (compare_window_configurations): Simplify code.
7157 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7159 * image.c (imagemagick_load_image): Fix type mismatch.
7160 (Fimagemagick_types): Likewise.
7162 * window.h (replace_buffer_in_windows): Declare.
7164 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7166 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7167 Qclone_number. Remove external declaration of Qdelete_window.
7168 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7170 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7171 Run Qbuffer_list_update_hook if allowed.
7172 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7173 buffer list implementation.
7174 (other_buffer_safely): New function.
7175 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7176 calls to replace_buffer_in_windows and
7177 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7179 (record_buffer): Inhibit quitting and rewrite using quittable
7180 functions. Run Qbuffer_list_update_hook if allowed.
7181 (Frecord_buffer, Funrecord_buffer): New functions.
7182 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7183 Move switch-to-buffer to window.el.
7184 (bury-buffer): Move to window.el.
7185 (Vbuffer_list_update_hook): New variable.
7187 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7190 * window.h (resize_frame_windows): Move up in code.
7191 (Fwindow_frame): Remove EXFUN.
7192 (replace_buffer_in_all_windows): Remove prototype.
7193 (replace_buffer_in_windows_safely): Add prototype.
7195 * window.c: Declare Qdelete_window static again. Move down
7196 declaration of select_count.
7197 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7198 (Fother_window): Move to window.el.
7199 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7200 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7201 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7203 (replace_buffer_in_windows): Implement by calling
7204 Qreplace_buffer_in_windows.
7205 (replace_buffer_in_all_windows): Remove with some functionality
7206 moved into replace_buffer_in_windows_safely.
7207 (replace_buffer_in_windows_safely): New function.
7208 (select_window_norecord, select_frame_norecord): Move in front
7209 of run_window_configuration_change_hook. Remove now obsolete
7211 (Fset_window_buffer): Rewrite doc-string.
7212 Call Qrecord_window_buffer.
7213 (keys_of_window): Move binding for other-window to window.el.
7215 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7217 * dispextern.h (struct image): Replace data member, whose int_val
7218 and ptr_val fields were not used by anything, with a single
7221 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7222 (gif_clear_image, gif_load, imagemagick_load_image)
7223 (gs_clear_image, gs_load): Callers changed.
7225 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7227 * buffer.h: Include <time.h>, for time_t.
7228 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7230 Fix minor problems found by static checking.
7232 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7234 Make identifiers static if they are not used in other modules.
7235 * data.c (Qcompiled_function, Qframe, Qvector):
7236 * image.c (QimageMagick, Qsvg):
7237 * minibuf.c (Qmetadata):
7238 * window.c (resize_window_check, resize_root_window): Now static.
7239 * window.h (resize_window_check, resize_root_window): Remove decls.
7241 * window.c (window_deletion_count, delete_deletable_window):
7243 (window_body_lines): Now static.
7244 (Fdelete_other_windows_internal): Mark vars as initialized.
7245 Make sure 'resize_failed' is initialized.
7246 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7247 (resize_window_apply): Remove unused local.
7248 * window.h (delete_deletable_window): Remove decl.
7250 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7251 (imagemagick_load_image): Fix pointer signedness problem by changing
7252 last arg from unsigned char * to char *. All uses changed.
7253 Also, fix a local for similar reasons.
7254 Remove unused locals. Remove locals to avoid shadowing.
7255 (fn_rsvg_handle_free): Remove; unused.
7256 (svg_load, svg_load_image): Fix pointer signedness problem.
7257 (imagemagick_load_image): Don't use garbage pointer image_wand.
7259 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7261 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7263 * image.c (gif_load): Fix omitted cast error introduced by
7266 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7268 * window.h (resize_proportionally, orig_total_lines)
7269 (orig_top_line): Remove from window structure.
7270 (set_window_height, set_window_width, change_window_heights)
7271 (Fdelete_window): Remove prototypes.
7272 (resize_frame_windows): Remove duplicate declaration.
7274 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7276 * window.h (resize_frame_windows, resize_window_check)
7277 (delete_deletable_window, resize_root_window)
7278 (resize_frame_windows): Declare prototypes.
7280 * window.c (resize_window_apply): Make definition be "static" to
7281 match the prototype.
7283 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7285 * window.c: Remove declarations of Qwindow_size_fixed,
7286 window_min_size_1, window_min_size_2, window_min_size,
7287 size_window, window_fixed_size_p, enlarge_window, delete_window.
7288 Remove static from declaration of Qdelete_window, it's
7289 temporarily needed by Fbury_buffer.
7290 (replace_window): Don't assign orig_top_line and
7292 (Fdelete_window, delete_window): Remove. Window deletion is
7293 handled by window.el.
7294 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7295 Replace Fdelete_window calls with calls to Qdelete_window.
7296 (Fdelete_other_windows): Remove. Deleting other windows is
7297 handled by window.el.
7298 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7299 handled in window.el.
7300 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7301 Window minimum sizes are handled in window.el.
7302 (shrink_windows, size_window, set_window_height)
7303 (set_window_width, change_window_heights, window_height)
7304 (window_width, CURBEG, CURSIZE, enlarge_window)
7305 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7306 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7307 handled in window.el.
7308 (make_dummy_parent): Rename to make_parent_window and give it a
7309 second argument horflag.
7310 (make_window): Don't set resize_proportionally any more.
7311 (Fsplit_window): Remove. Windows are split in window.el.
7312 (save_restore_action, save_restore_orig_size)
7313 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7314 Resize mini windows in window.el.
7315 (grow_mini_window, shrink_mini_window): Implement by calling
7316 Qresize_root_window_vertically, resize_window_check and
7317 resize_window_apply.
7318 (saved_window, Fset_window_configuration, save_window_save):
7319 Do not handle orig_top_line, orig_total_lines, and
7320 resize_proportionally.
7321 (window_min_height, window_min_width): Move to window.el.
7322 (keys_of_window): Move bindings for delete-other-windows,
7323 split-window, delete-window and enlarge-window to window.el.
7325 * buffer.c: Temporarily extern Qdelete_window.
7326 (Fbury_buffer): Temporarily call Qdelete_window instead of
7327 Fdelete_window (Fbury_buffer will move to window.el soon).
7329 * frame.c (set_menu_bar_lines_1): Remove code handling
7330 orig_top_line and orig_total_lines.
7332 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7333 set_window_height but set heights directly.
7334 (change_frame_size_1): Use resize_frame_windows.
7336 * xdisp.c (init_xdisp): Don't use set_window_height but set
7339 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7340 Use resize_frame_windows instead of change_window_heights and run
7341 run_window_configuration_change_hook.
7343 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7344 instead of change_window_heights and run
7345 run_window_configuration_change_hook.
7347 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7349 * window.c (replace_window): Rename second argument REPLACEMENT to
7350 NEW. New third argument SETFLAG. Rewrite.
7351 (delete_window, make_dummy_parent): Call replace_window with
7353 (window_list_1): Move down in code.
7354 (run_window_configuration_change_hook): Move set_buffer part
7355 before select_frame_norecord part in order to unwind correctly.
7356 Rename count1 to count.
7357 (recombine_windows, delete_deletable_window, resize_root_window)
7358 (Fdelete_other_windows_internal)
7359 (Frun_window_configuration_change_hook, make_parent_window)
7360 (resize_window_check, resize_window_apply, Fresize_window_apply)
7361 (resize_frame_windows, Fsplit_window_internal)
7362 (Fdelete_window_internal, Fresize_mini_window_internal):
7364 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7366 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7368 * window.h (window): Add some new members to window structure -
7369 normal_lines, normal_cols, new_total, new_normal, clone_number,
7370 splits, nest, prev_buffers, next_buffers.
7371 (WINDOW_TOTAL_SIZE): Move here from window.c.
7372 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7374 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7376 (make_dummy_parent): Set new members of windows structure.
7377 (make_window): Move down in code. Handle new members of window
7379 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7380 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7381 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7382 (Fset_window_prev_buffers, Fwindow_next_buffers)
7383 (Fset_window_next_buffers, Fset_window_clone_number):
7385 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7386 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7388 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7389 Argument WINDOW can be now internal window too.
7390 (Fwindow_use_time): Move up in code.
7391 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7393 (Fset_window_configuration, saved_window)
7394 (Fcurrent_window_configuration, save_window_save): Handle new
7395 members of window structure.
7396 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7397 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7398 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7399 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7400 Qget_mru_window, Qresize_root_window,
7401 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7402 Qauto_buffer_name; staticpro them.
7404 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7406 * window.c (Fwindow_total_size, Fwindow_left_column)
7407 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7408 (Fwindow_list_1): New functions.
7409 (window_box_text_cols): Replace with window_body_cols.
7410 (Fwindow_width, Fscroll_left, Fscroll_right):
7411 Use window_body_cols instead of window_box_text_cols.
7412 (delete_window, Fset_window_configuration):
7413 Call delete_all_subwindows with window as argument.
7414 (delete_all_subwindows): Take a window as argument and not a
7416 (window_loop): Remove handling of GET_LRU_WINDOW and
7418 (Fget_lru_window, Fget_largest_window): Move to window.el.
7420 * window.h: Extern window_body_cols instead of
7421 window_box_text_cols. delete_all_subwindows now takes a
7422 Lisp_Object as argument.
7424 * indent.c (compute_motion, Fcompute_motion):
7425 Use window_body_cols instead of window_box_text_cols.
7427 * frame.c (delete_frame): Call delete_all_subwindows with root
7430 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7432 * fns.c (Fputhash): Document return value.
7434 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7436 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7438 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7440 Cons<->int and similar integer overflow fixes (Bug#8794).
7442 Check for overflow when converting integer to cons and back.
7443 * charset.c (Fdefine_charset_internal, Fdecode_char):
7444 Use cons_to_unsigned to catch overflow.
7445 (Fencode_char): Use INTEGER_TO_CONS.
7446 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7447 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7448 * data.c (long_to_cons, cons_to_long): Remove.
7449 (cons_to_unsigned, cons_to_signed): New functions.
7450 These signal an error for invalid or out-of-range values.
7451 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7452 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7453 * font.c (Ffont_variation_glyphs):
7454 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7455 * lisp.h: Include <intprops.h>.
7456 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7457 (cons_to_signed, cons_to_unsigned): New decls.
7458 (long_to_cons, cons_to_long): Remove decls.
7459 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7460 (Fprimitive_undo): Use CONS_TO_INTEGER.
7461 * xfns.c (Fx_window_property): Likewise.
7462 * xselect.c: Include <limits.h>.
7463 (x_own_selection, selection_data_to_lisp_data):
7464 Use INTEGER_TO_CONS.
7465 (x_handle_selection_request, x_handle_selection_clear)
7466 (x_get_foreign_selection, Fx_disown_selection_internal)
7467 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7468 (lisp_data_to_selection_data): Use cons_to_unsigned.
7469 (x_fill_property_data): Use cons_to_signed.
7470 Report values out of range.
7472 Check for buffer and string overflow more precisely.
7473 * buffer.h (BUF_BYTES_MAX): New macro.
7474 * lisp.h (STRING_BYTES_MAX): New macro.
7475 * alloc.c (Fmake_string):
7476 * character.c (string_escape_byte8):
7477 * coding.c (coding_alloc_by_realloc):
7478 * doprnt.c (doprnt):
7479 * editfns.c (Fformat):
7481 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7482 since they may not be the same number.
7483 * editfns.c (Finsert_char):
7484 * fileio.c (Finsert_file_contents):
7485 Likewise for BUF_BYTES_MAX.
7487 * image.c: Use ptrdiff_t, not int, for sizes.
7488 (slurp_file): Switch from int to ptrdiff_t.
7490 (slurp_file): Check that file size fits in both size_t (for
7491 malloc) and ptrdiff_t (for sanity and safety).
7493 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7494 if b->modtime has its maximal value.
7496 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7498 Don't assume time_t can fit into int.
7499 * buffer.h (struct buffer.modtime): Now time_t, not int.
7500 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7501 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7503 Minor fixes for signed vs unsigned integers.
7504 * character.h (MAYBE_UNIFY_CHAR):
7505 * charset.c (maybe_unify_char):
7506 * keyboard.c (read_char, reorder_modifiers):
7507 XINT -> XFASTINT, since the integer must be nonnegative.
7508 * ftfont.c (ftfont_spec_pattern):
7509 * keymap.c (access_keymap, silly_event_symbol_error):
7510 XUINT -> XFASTINT, since the integer must be nonnegative.
7511 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7512 since it makes no difference and we prefer signed.
7513 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7514 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7517 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7519 * window.h (Fwindow_frame): Declare.
7521 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7523 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7524 (SPARE_MEMORY): Always define.
7525 (LARGE_REQUEST): Remove.
7526 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7528 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7530 * lisp.h: Move EXFUNS for Fframe_root_window,
7531 Fframe_first_window and Fset_frame_selected_window to window.h.
7533 * window.h: Move EXFUNS for Fframe_root_window,
7534 Fframe_first_window and Fset_frame_selected_window here from
7537 * frame.c (Fwindow_frame, Fframe_first_window)
7538 (Fframe_root_window, Fframe_selected_window)
7539 (Fset_frame_selected_window): Move to window.c.
7540 (Factive_minibuffer_window): Move to minibuf.c.
7541 (Fother_visible_frames_p): New function.
7543 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7545 * window.c (decode_window, decode_any_window): Move up in code.
7546 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7547 (inhibit_frame_unsplittable): Remove unused variable.
7548 (Fwindow_buffer): Move up and rewrite doc-string.
7549 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7550 (Fwindow_prev): New functions.
7551 (Fwindow_frame): Move here from frame.c. Accept any window as
7553 (Fframe_root_window, Fframe_first_window)
7554 (Fframe_selected_window): Move here from frame.c. Accept frame
7555 or arbitrary window as argument. Update doc-strings.
7556 (Fminibuffer_window): Move up in code.
7557 (Fwindow_minibuffer_p): Move up in code and simplify.
7558 (Fset_frame_selected_window): Move here from frame.c.
7560 (Fselected_window, select_window, Fselect_window): Move up in
7561 code. Minor doc-string fixes.
7563 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7565 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7566 Do not assume that spare memory exists; that assumption is valid
7567 only if SYSTEM_MALLOC.
7568 (LARGE_REQUEST): New macro, so that the issue of large requests
7569 is separated from the issue of spare memory.
7571 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7573 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7576 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7578 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7581 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7583 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7585 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7587 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7588 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7590 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7592 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7594 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7596 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7597 (x_clipboard_manager_save): Add return value.
7598 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7600 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7601 Obey Vx_select_enable_clipboard_manager. Catch errors in
7602 x_clipboard_manager_save (Bug#8779).
7603 (Vx_select_enable_clipboard_manager): New variable.
7604 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7606 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7608 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7610 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7612 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7613 in the current matrix if keep_current_p is non-zero.
7615 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7617 * bidi.c (bidi_level_of_next_char): Fix last change.
7619 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7621 Support bidi reordering of text covered by display properties.
7623 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7624 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7625 (bidi_cache_search, bidi_cache_iterator_state)
7626 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7627 (bidi_level_of_next_char, bidi_move_to_visually_next):
7628 Support character positions inside a run of characters covered by a
7630 (bidi_paragraph_init, bidi_resolve_explicit_1)
7631 (bidi_level_of_next_char): Call bidi_fetch_char and
7632 bidi_fetch_char_advance instead of FETCH_CHAR and
7634 (bidi_init_it): Initialize new members.
7635 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7637 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7638 instead of using explicit *_CHAR codes.
7639 (bidi_resolve_explicit, bidi_resolve_weak):
7640 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7641 bidirectional text is supported only in multibyte buffers.
7642 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7643 it to initialize the frame_window_p member of struct bidi_it.
7644 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7645 (bidi_resolve_explicit, bidi_resolve_weak)
7646 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7647 bidi_it->nchars is non-positive.
7648 (bidi_level_of_next_char): Don't try to lookup the cache for the
7649 next/previous character if nothing is cached there yet, or if we
7650 were just reseat()'ed to a new position.
7652 * xdisp.c (set_cursor_from_row): Set start and stop points
7653 according to the row's direction when priming the loop that looks
7654 for the glyph on which to display cursor.
7655 (single_display_spec_intangible_p): Function deleted.
7656 (display_prop_intangible_p): Reimplement to call
7657 handle_display_spec instead of single_display_spec_intangible_p.
7658 Accept 3 additional arguments needed by handle_display_spec.
7659 This fixes incorrect cursor motion across display property with complex
7660 values: lists, `(when COND...)' forms, etc.
7661 (single_display_spec_string_p): Support property values that are
7662 lists with the argument STRING its top-level element.
7663 (display_prop_string_p): Fix the condition for processing a
7664 property that is a list to be consistent with handle_display_spec.
7665 (handle_display_spec): New function, refactored from the
7666 last portion of handle_display_prop.
7667 (compute_display_string_pos): Accept additional argument
7668 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7669 value of a `display' property is a "replacing spec".
7670 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7671 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7672 the display property, but just return a value indicating whether
7673 the display property will replace the characters it covers.
7674 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7675 frame_window_p members of struct bidi_it.
7676 (compute_display_string_pos, compute_display_string_end):
7678 (push_it): Accept second argument POSITION, where pop_it should
7679 jump to continue iteration.
7680 (reseat_1): Initialize bidi_it.disp_pos.
7682 * keyboard.c (adjust_point_for_property): Adjust the call to
7683 display_prop_intangible_p to its new signature.
7685 * dispextern.h (struct bidi_it): New member frame_window_p.
7686 (bidi_init_it): Update prototypes.
7687 (display_prop_intangible_p): Update prototype.
7688 (compute_display_string_pos, compute_display_string_end):
7690 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7693 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7695 Malloc failure behavior now depends on size of allocation.
7696 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7697 * lisp.h: Change signatures accordingly.
7698 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7699 All callers changed. (Bug#8762)
7701 * gnutls.c: Use Emacs's memory allocators.
7702 Without this change, the gnutls library would invoke malloc etc.
7703 directly, which causes problems on non-SYNC_INPUT hosts, and which
7704 runs afoul of improving memory_full behavior. (Bug#8761)
7705 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7706 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7707 xfree instead of the default malloc, realloc, free.
7708 (Fgnutls_boot): No need to check for memory allocation failure,
7709 since xmalloc does that for us.
7711 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7712 * category.c (hash_get_category_set):
7713 * ccl.c (ccl_driver):
7714 * charset.c (Fdefine_charset_internal):
7715 * charset.h (struct charset.hash_index):
7716 * composite.c (get_composition_id, gstring_lookup_cache)
7717 (composition_gstring_put_cache):
7718 * composite.h (struct composition.hash_index):
7719 * dispextern.h (struct image.hash):
7720 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7721 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7722 (hashfn_equal, hashfn_user_defined, make_hash_table)
7723 (maybe_resize_hash_table, hash_lookup, hash_put)
7724 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7725 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7726 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7727 * image.c (make_image, search_image_cache, lookup_image)
7728 (xpm_put_color_table_h):
7729 * lisp.h (struct Lisp_Hash_Table):
7730 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7731 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7732 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7733 * alloc.c (allocate_vectorlike):
7734 Check for overflow in vector size calculations.
7735 * ccl.c (ccl_driver):
7736 Check for overflow when converting EMACS_INT to int.
7737 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7738 need to be updated by these changes.
7739 * fns.c (make_hash_table, maybe_resize_hash_table):
7740 Check for integer overflow with large hash tables.
7741 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7742 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7743 (SXHASH_REDUCE): New macro.
7744 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7745 Use it instead of discarding useful hash info with large hash values.
7746 (sxhash_float): New function.
7747 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7748 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7749 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7750 Rewrite to use FIXNUM_BITS, as this simplifies things.
7751 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7752 Adjust signatures to match updated version of code.
7753 (consing_since_gc): Now EMACS_INT, since a single hash table can
7754 use more than INT_MAX bytes.
7756 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7758 Make it possible to build with GCC-4.6+ -O2 -flto.
7760 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7762 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7764 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7765 Call minibuffer-inactive-mode.
7767 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7769 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7770 Update dependencies.
7772 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7774 * data.c (init_data): Remove code for UTS, this system is not
7777 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7779 Don't force ./temacs to start in terminal mode.
7781 * frame.c (make_initial_frame): Initialize faces in all cases, not
7782 only when CANNOT_DUMP is defined.
7783 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7785 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7787 * dispnew.c (add_window_display_history): Use const for the string
7788 pointer. Remove declaration, not needed.
7790 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7792 Use 'inline', not 'INLINE'.
7793 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7794 * alloc.c, fontset.c (INLINE): Remove.
7795 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7796 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7797 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7798 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7799 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7801 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7803 Make it possible to run ./temacs.
7805 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7806 syms_of_callproc does the same thing. Remove test for
7807 "initialized", do it in the caller.
7808 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7810 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7812 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7813 (read_minibuf): Use get_minibuffer.
7814 (syms_of_minibuf): Use DEFSYM.
7815 (Qmetadata): New var.
7816 * data.c (Qbuffer): Don't make it static.
7817 (syms_of_data): Use DEFSYM.
7819 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7821 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7822 (CCL_CODE_MIN): New macro.
7824 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7826 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7828 * eval.c (Qdebug): Now static.
7829 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7830 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7831 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7833 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7835 * image.c: Various fixes to ImageMagick code comments.
7836 (Fimagemagick_types): Doc fix.
7838 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7840 Minor fixes prompted by GCC 4.6.0 warnings.
7842 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7844 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7845 (x_clipboard_manager_save_all): Move extern decl to ...
7846 * xterm.h: ... here, so that it can be checked for consistency.
7848 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7850 * xselect.c (x_clipboard_manager_save_frame)
7851 (x_clipboard_manager_save_all): New functions.
7852 (Fx_clipboard_manager_save): Lisp function deleted.
7854 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7855 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7857 * xterm.h: Update prototype.
7859 2011-05-28 William Xu <william.xwl@gmail.com>
7861 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7864 2011-05-28 Jim Meyering <meyering@redhat.com>
7866 Avoid a sign-extension bug in crypto_hash_function.
7867 * fns.c (to_uchar): Define.
7868 (crypto_hash_function): Use it to convert some newly-signed
7869 variables to unsigned, to avoid sign-extension bugs. For example,
7870 without this change, (md5 "truc") would evaluate to
7871 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7872 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7873 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7875 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7877 Integer overflow fixes.
7879 * dbusbind.c: Serial number integer overflow fixes.
7880 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7881 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7882 to hold a serial number that is too large for a fixnum.
7883 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7884 Check for serial numbers out of range. Decode any serial number
7885 that was so large that it became a float. (Bug#8722)
7887 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7888 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7889 Use XFASTINT rather than XUINT when numbers are nonnegative.
7890 (xd_append_arg, Fdbus_method_return_internal):
7891 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7892 arguments, check that Lisp number is nonnegative, rather than
7893 silently wrapping negative numbers around. (Bug#8722)
7894 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7897 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7899 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7901 ccl: Add integer overflow checks.
7902 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7903 (IN_INT_RANGE): New macros.
7904 (ccl_driver): Use them to check for integer overflow when
7905 decoding a CCL program. Many of the new checks are whether XINT (x)
7906 fits in int; it doesn't always, on 64-bit hosts. The new version
7907 doesn't catch all possible integer overflows, but it's an
7908 improvement. (Bug#8719)
7910 * alloc.c (make_event_array): Use XINT, not XUINT.
7911 There's no need for unsigned here.
7913 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7914 This follows up to the 2011-05-06 change that substituted uintptr_t
7915 for EMACS_INT. This case wasn't caught back then.
7917 Rework Fformat to avoid integer overflow issues.
7918 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7919 now (part of C89). Include <verify.h>.
7920 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7921 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7922 (Fformat): Avoid the prepass trying to compute sizes; it was only
7923 approximate and thus did not catch overflow reliably. Instead, walk
7924 through the format just once, formatting and computing sizes as we go,
7925 checking for integer overflow at every step, and allocating a larger
7926 buffer as needed. Keep track separately whether the format is
7927 multibyte. Keep only the most-recently calculated precision, rather
7928 than them all. Record whether each argument has been converted to
7929 string. Use EMACS_INT, not int, for byte and char and arg counts.
7930 Support field widths and precisions larger than INT_MAX. Avoid
7931 sprintf's undefined behavior with conversion specifications such as %#d
7932 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7933 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7934 formatting out-of-range floating point numbers with int
7937 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7939 * data.c: Avoid integer truncation in expressions involving floats.
7940 * data.c: Include <intprops.h>.
7941 (arith_driver): When there's an integer overflow in an expression
7942 involving floating point, convert the integers to floating point
7943 so that the resulting value does not suffer from catastrophic
7944 integer truncation. For example, on a 64-bit host (* 4
7945 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7946 Do not rely on undefined behavior after integer overflow.
7948 merge count_size_as_multibyte, parse_str_to_multibyte
7949 * character.c, character.h (count_size_as_multibyte):
7950 Rename from parse_str_to_multibyte; all uses changed.
7951 Check for integer overflow.
7952 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7953 since it's now a duplicate of the other. This is more of
7954 a character than a buffer op, so better that it's in character.c.
7955 * fns.c, print.c: Adjust to above changes.
7957 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7959 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7961 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7963 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7964 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7965 (x_clipboard_manager_save): Now static.
7966 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7968 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7969 (crypto_hash_function): Now static.
7970 Fix pointer signedness problems. Avoid unnecessary initializations.
7972 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7974 * termhooks.h (Vselection_alist): Make it terminal-local.
7976 * terminal.c (create_terminal): Initialize it.
7978 * xselect.c: Support for clipboard managers.
7979 (Vselection_alist): Move to termhooks.h as terminal-local var.
7980 (LOCAL_SELECTION): New macro.
7981 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7982 (symbol_to_x_atom): Remove gratuitous arg.
7983 (x_handle_selection_request, lisp_data_to_selection_data)
7984 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7985 (x_own_selection, x_get_local_selection, x_convert_selection):
7986 New arg, specifying work frame. Use terminal-local Vselection_alist.
7987 (some_frame_on_display): Delete unused function.
7988 (Fx_own_selection_internal, Fx_get_selection_internal)
7989 (Fx_disown_selection_internal, Fx_selection_owner_p)
7990 (Fx_selection_exists_p): New optional frame arg.
7991 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7992 (x_handle_selection_clear): Don't treat other terminals with the
7993 same keyboard specially. Use the terminal-local Vselection_alist.
7994 (x_clear_frame_selections): Use Frun_hook_with_args.
7996 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7998 * xterm.h: Add support for those atoms.
8000 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8002 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8003 (converted_selections, conversion_fail_tag): New global variables.
8004 (x_selection_request_lisp_error): Free the above.
8005 (x_get_local_selection): Remove unnecessary code.
8006 (x_reply_selection_request): Args changed; handle arbitrary array
8007 of converted selections stored in converted_selections.
8008 Separate the XChangeProperty and SelectionNotify steps.
8009 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8010 (x_convert_selection): New function.
8011 (x_handle_selection_event): Simplify.
8012 (x_get_foreign_selection): Don't ignore incoming requests while
8013 waiting for an answer; this will fail when we implement
8014 SAVE_TARGETS, and seems unnecessary anyway.
8015 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8016 (Vx_sent_selection_functions): Doc fix.
8018 2011-05-26 Leo Liu <sdl.web@gmail.com>
8020 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8022 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8024 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8026 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8027 for fringe update if it has periodic bitmap.
8028 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8029 and fringe_bitmap_periodic_p.
8031 * fringe.c (get_fringe_bitmap_data): New function.
8032 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8033 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8034 row. Mark glyph row for fringe update if periodicity changed.
8036 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8037 for fringe update unless it has periodic bitmap.
8039 2011-05-25 Kenichi Handa <handa@m17n.org>
8041 * xdisp.c (get_next_display_element): Set correct it->face_id for
8042 a static composition.
8044 2011-05-24 Leo Liu <sdl.web@gmail.com>
8047 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8049 * fns.c (crypto_hash_function, Fsha1): New function.
8050 (Fmd5): Use crypto_hash_function.
8051 (syms_of_fns): Add Ssha1.
8053 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8055 * gnutls.c: Remove unused macros.
8056 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8057 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8058 Remove macros that are defined and never used.
8059 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8061 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8063 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8064 (Fx_get_selection_internal): Minor cleanup.
8065 (Fx_own_selection_internal): Rename arguments for consistency with
8068 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8070 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8072 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8074 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8076 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8078 * dispnew.c (scrolling_window): Don't exclude the case that the
8079 last enabled row in the desired matrix touches the bottom boundary.
8081 2011-05-21 Glenn Morris <rgm@gnu.org>
8083 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8084 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8085 and add some more files.
8087 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8089 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8090 report_file_error introduced by the change from 2011-05-07.
8092 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8094 * systime.h (Time): Define only if emacs is defined.
8095 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8096 where the include path doesn't have X11/X.h by default. See
8097 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8099 2011-05-20 Kenichi Handa <handa@m17n.org>
8101 * composite.c (find_automatic_composition): Fix previous change.
8103 2011-05-20 Glenn Morris <rgm@gnu.org>
8105 * lisp.mk: New file, split from Makefile.in.
8106 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8107 (shortlisp): Remove.
8108 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8110 2011-05-19 Glenn Morris <rgm@gnu.org>
8112 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8113 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8114 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8115 (lisp): Set the order to that of loadup.el.
8116 (shortlisp): Make it a copy of $lisp.
8117 (SOME_MACHINE_LISP): Remove.
8118 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8119 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8121 2011-05-18 Kenichi Handa <handa@m17n.org>
8123 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8124 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8125 (find_automatic_composition): Mostly rewrite for efficiency.
8127 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8129 * makefile.w32-in: Update dependencies.
8131 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8133 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8134 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8136 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8138 Fix some integer overflow issues, such as string length overflow.
8140 * insdel.c (count_size_as_multibyte): Check for string overflow.
8142 * character.c (lisp_string_width): Check for string overflow.
8143 Use EMACS_INT, not int, for string indexes and lengths; in
8144 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8145 the resulting string length overflows an EMACS_INT; instead,
8146 report a string overflow if no precision given. When checking for
8147 precision exhaustion, use a check that cannot possibly have
8148 integer overflow. (Bug#8675)
8149 * character.h (lisp_string_width): Adjust to new signature.
8151 * alloc.c (string_overflow): New function.
8152 (Fmake_string): Use it. This doesn't change behavior, but saves
8153 a few bytes and will simplify future changes.
8154 * character.c (string_escape_byte8): Likewise.
8155 * lisp.h (string_overflow): New decl.
8157 Fixups, following up to the user-interface timestamp change.
8158 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8159 for UI timestamps, instead of unsigned long.
8160 * msdos.c (mouse_get_pos): Likewise.
8161 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8162 * w32gui.h (Time): Define by including "systime.h" rather than by
8163 declaring it ourselves. (Bug#8664)
8165 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8166 * image.c (clear_image_cache): Likewise.
8168 * term.c (term_mouse_position): Don't assume time_t wraparound.
8170 Be more systematic about user-interface timestamps.
8171 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8172 and sometimes 'EMACS_UINT', to represent these timestamps.
8173 This change causes it to use 'Time' uniformly, as that's what X uses.
8174 This makes the code easier to follow, and makes it easier to catch
8175 integer overflow bugs such as Bug#8664.
8176 * frame.c (Fmouse_position, Fmouse_pixel_position):
8177 Use Time, not unsigned long, for user-interface timestamps.
8178 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8179 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8180 * keyboard.h (last_event_timestamp): Likewise.
8181 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8182 * menu.h (xmenu_show): Likewise.
8183 * term.c (term_mouse_position): Likewise.
8184 * termhooks.h (struct input_event.timestamp): Likewise.
8185 (struct terminal.mouse_position_hook): Likewise.
8186 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8187 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8188 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8189 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8191 * menu.h, termhooks.h: Include "systime.h", for Time.
8193 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8194 Don't assume that the difference between two unsigned long values
8195 can fit into an integer. At this point, we know button_down_time
8196 <= event->timestamp, so the difference must be nonnegative, so
8197 there's no need to cast the result if double-click-time is
8198 nonnegative, as it should be; check that it's nonnegative, just in
8199 case. This bug is triggered when events are more than 2**31 ms
8200 apart (about 25 days). (Bug#8664)
8202 * xselect.c (last_event_timestamp): Remove duplicate decl.
8203 (x_own_selection): Remove needless cast to unsigned long.
8205 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8206 that always fit in int. Use a sentinel instead of a counter, to
8207 avoid a temp and to allay GCC's concerns about possible int overflow.
8208 * frame.h (struct frame): Use int for menu_bar_items_used
8209 instead of EMACS_INT, since it always fits in int.
8211 * menu.c (grow_menu_items): Check for int overflow.
8213 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8215 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8216 Before, the code was not consistent. These values cannot exceed
8217 2**31 - 1 so there's no need to make them unsigned.
8218 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8219 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8220 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8222 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8224 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8225 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8226 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8227 presumably because the widths might not match.
8229 * window.c (size_window): Avoid needless test at loop start.
8231 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8233 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8235 2011-05-12 Drew Adams <drew.adams@oracle.com>
8237 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8239 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8241 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8242 `width' to `bar_area_x' and `bar_area_width', respectively.
8243 (x_scroll_run): Take account of fringe background extension.
8245 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8246 Rename local vars `left' and `width' to `bar_area_x' and
8247 `bar_area_width', respectively.
8248 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8249 background extension.
8251 2011-05-10 Jim Meyering <meyering@redhat.com>
8253 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8255 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8257 * image.c (Finit_image_library): Return t for built-in image types,
8258 like pbm and xbm. (Bug#8640)
8260 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8262 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8264 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8266 * w32console.c (Fset_screen_color): Doc fix.
8267 (Fget_screen_color): New function.
8268 (syms_of_ntterm): Defsubr it.
8270 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8271 unlink the temporary file if Fcall_process didn't create it in the
8273 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8274 child process will be redirected to a file specified with `:file'.
8275 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8276 cue to call_process_cleanup not to close that handle.
8278 2011-05-07 Ben Key <bkey76@gmail.com>
8280 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8281 one of two shell specific rules, either bootstrap-temacs-CMD or
8282 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8283 to the previous implementation of the bootstrap-temacs rule.
8284 The bootstrap-temacs-CMD rule is similar to the previous
8285 implementation of the bootstrap-temacs rule except that it
8286 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8289 These changes, along with some changes to nt/configure.bat,
8290 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8291 earlier fix to add support for --cflags and --ldflags options
8292 that include quotes so that it works whether make uses cmd or
8295 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8297 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8298 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8300 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8301 a string. Handle both cases.
8302 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8303 (Fdbus_register_method): Use Qinvalid_function.
8305 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8307 * makefile.w32-in: Update dependencies.
8308 (LISP_H): Add inttypes.h and stdin.h.
8309 (PROCESS_H): Add unistd.h.
8311 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8313 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8314 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8316 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8318 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8320 * term.c (vfatal): Remove stray call to va_end.
8321 It's not needed and the C Standard doesn't allow it here anyway.
8323 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8324 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8326 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8329 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8331 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8333 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8335 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8337 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8339 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8340 * charset.c (Fdefine_charset_internal): Don't initialize
8341 charset.code_space[15]. The value was garbage, on hosts with
8342 32-bit int (Bug#8600).
8344 * lread.c (read_integer): Be more consistent with string-to-number.
8345 Use string_to_number to do the actual conversion; this avoids
8346 rounding errors and fixes some other screwups. Without this fix,
8347 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8348 (digit_to_number): Move earlier, for benefit of read_integer.
8349 Return -1 if the digit is out of range for the base, -2 if it is
8350 not a digit in any supported base. (Bug#8602)
8352 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8354 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8355 to match comment at start of function. This also removes a
8356 GCC warning about overflow in a 32+64-bit port.
8358 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8360 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8361 Reported by Stefan Monnier in
8362 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8363 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8364 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8366 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8367 (EMACS_UINTPTR): Likewise, with uintptr_t.
8369 * lisp.h: Prefer 64-bit EMACS_INT if available.
8370 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8371 on 32-bit hosts that have 64-bit int, so that they can access
8373 However, temporarily disable this change unless the temporary
8374 symbol WIDE_EMACS_INT is defined.
8376 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8378 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8379 This removes an assumption that EMACS_INT and long are the same
8380 width as pointers. The assumption is true for Emacs porting targets
8381 now, but we want to make other targets possible.
8382 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8383 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8384 In the rest of the code, change types of integers that hold casted
8385 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8386 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8387 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8388 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8389 No need to cast type when ORing.
8390 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8391 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8392 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8393 assume EMACS_INT is the same width as char *.
8394 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8395 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8396 Remove no-longer-needed casts.
8397 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8398 (xg_tool_bar_help_callback, xg_make_tool_item):
8399 Use EMACS_INTPTR to hold an integer
8400 that will be cast to void *; this can avoid a GCC warning
8401 if EMACS_INT is not the same width as void *.
8402 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8403 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8404 (current_message_1, set_message_1):
8405 Use a local to convert to proper width without a cast.
8406 * xmenu.c (dialog_selection_callback): Likewise.
8408 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8409 Also, don't assume VALBITS / RAND_BITS is less than 5,
8410 and don't rely on undefined behavior when shifting a 1 left into
8412 * lisp.h (get_random): Change signature to match.
8414 * lread.c (hash_string): Use size_t, not int, for hash computation.
8415 Normally we prefer signed values; but hashing is special, because
8416 it's better to use unsigned division on hash table sizes so that
8417 the remainder is nonnegative. Also, size_t is the natural width
8418 for hashing into memory. The previous code used 'int', which doesn't
8419 retain enough info to hash well into very large tables.
8420 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8422 * dbusbind.c: Don't possibly lose pointer info when converting.
8423 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8424 Use XPNTR rather than XHASH, so that the high-order bits of
8425 the pointer aren't lost when converting through void *.
8427 * eval.c (Fautoload): Don't double-shift a pointer.
8429 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8431 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8433 * gnutls.c (DEF_GNUTLS_FN):
8434 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8436 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8438 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8441 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8443 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8444 New version that can reserve upto 2GB of heap space.
8446 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8448 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8450 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8452 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8453 `gnutls_certificate_set_x509_key_file'.
8455 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8457 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8458 Update dependencies.
8460 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8462 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8463 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8464 Remove unused parameter `fildes'.
8465 * process.c (read_process_output, send_process): Don't pass it.
8467 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8469 Fix previous change: the library cache is defined in w32.c.
8470 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8471 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8473 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8475 Implement dynamic loading of GnuTLS on Windows.
8477 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8478 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8479 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8482 * gnutls.c (Qgnutls_dll): Define.
8483 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8484 (gnutls_*): Declare function pointers.
8485 (init_gnutls_functions): New function to initialize function pointers.
8486 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8487 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8488 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8489 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8490 (emacs_gnutls_write, emacs_gnutls_read)
8491 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8492 (Fgnutls_available_p): New function.
8493 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8494 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8495 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8497 * image.c: Include w32.h.
8498 (Vimage_type_cache): Delete.
8499 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8500 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8501 (w32_delayed_load): Move to w32.c.
8503 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8505 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8506 (w32_delayed_load): Move from image.c. When loading a library, record
8507 its filename in the :loaded-from property of the library id.
8508 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8509 Initialize and staticpro them.
8510 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8512 * process.c: Include lisp.h before w32.h, not after.
8513 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8514 instead of gnutls_record_check_pending.
8516 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8518 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8520 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8521 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8524 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8526 * xterm.c (x_set_frame_alpha): Do not set property on anything
8527 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8529 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8531 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8533 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8535 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8536 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8537 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8538 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8539 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8540 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8541 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8542 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8543 (Qgnutls_bootprop_callbacks_verify): Make static.
8545 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8547 * callproc.c: Indentation fixup.
8549 * sysdep.c (wait_for_termination_1): Make static.
8550 (wait_for_termination, interruptible_wait_for_termination):
8551 Move after wait_for_termination_1.
8553 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8555 * sysdep.c (interruptible_wait_for_termination): New function
8556 which is like wait_for_termination, but allows keyboard
8559 * callproc.c (Fcall_process): Add (:file "file") as an option for
8561 (Fcall_process_region): Ditto.
8563 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8565 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8566 rather than `XVECTOR (FOO)->size'.
8568 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8569 inttypes.h, as a gnulib replacement is used if it not available in
8572 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8574 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8575 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8576 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8578 * coding.c (coding_alloc_by_realloc): Error out if destination
8579 will grow beyond MOST_POSITIVE_FIXNUM.
8580 (decode_coding_emacs_mule): Abort if there isn't enough place in
8581 charbuf for the composition carryover bytes. Reserve an extra
8582 space for up to 2 characters produced in a loop.
8583 (decode_coding_iso_2022): Abort if there isn't enough place in
8584 charbuf for the composition carryover bytes.
8586 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8588 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8589 aborting when %lld or %lll format is passed.
8590 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8591 %llo or %llx format is passed. (Bug#8545)
8593 * window.c (window_scroll_line_based): Use a marker instead of
8594 simple variables to record original value of point. (Bug#7952)
8596 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8597 produced by %s or %c overflows available buffer space. (Bug#8545)
8599 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8601 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8602 (SIZE_MAX): Move defn after all includes, as they might #define it.
8604 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8606 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8608 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8610 * keyboard.c (Qdelayed_warnings_hook): Define.
8611 (command_loop_1): Run `delayed-warnings-hook'
8612 if Vdelayed_warnings_list is non-nil.
8613 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8614 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8616 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8618 * doprnt.c (doprnt): Don't return value smaller than the buffer
8619 size if the message was truncated. (Bug#8545).
8621 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8623 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8624 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8626 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8628 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8630 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8632 * makefile.w32-in: Update dependencies.
8634 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8636 Improve `doprnt' and its usage. (Bug#8545)
8637 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8638 `format_end'. Remove support for %l as a conversion specifier.
8639 Don't use xrealloc. Improve diagnostics when the %l size modifier
8640 is used. Update the commentary.
8642 * eval.c (verror): Simplify calculation of size_t.
8644 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8647 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8649 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8652 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8654 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8655 This makes this file independent of the recent pseudovector change.
8657 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8659 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8661 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8662 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8663 Remove unused local.
8664 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8666 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8667 GCC 4.6.0 optimizes based on type-based alias analysis.
8668 For example, if b is of type struct buffer * and v of type struct
8669 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8670 != &v->size, and therefore "v->size = 1; b->size = 2; return
8671 v->size;" must therefore return 1. This assumption is incorrect
8672 for Emacs, since it type-puns struct Lisp_Vector * with many other
8673 types. To fix this problem, this patch adds a new type struct
8674 vectorlike_header that documents the constraints on layout of vectors
8675 and pseudovectors, and helps optimizing compilers not get fooled
8676 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8677 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8678 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8680 (XSETPVECTYPE): Rewrite in terms of new macro.
8681 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8682 This is a bit clearer, and further avoids the possibility of
8683 undesirable aliasing.
8684 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8685 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8686 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8687 since Lisp_Subr is a special case (no "next" field).
8688 (ASIZE): Now uses header.size rather than size.
8689 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8690 to avoid the hassle of writing XVECTOR (foo)->header.size.
8691 (struct vectorlike_header): New type.
8692 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8693 object, to help avoid aliasing.
8694 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8695 (SUBRP): Likewise, since Lisp_Subr is a special case.
8696 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8697 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8698 (struct Lisp_Hash_Table): Combine first two members into a single
8699 struct vectorlike_header member. All uses of "size" and "next" members
8700 changed to be "header.size" and "header.next".
8701 * buffer.h (struct buffer): Likewise.
8702 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8703 * frame.h (struct frame): Likewise.
8704 * process.h (struct Lisp_Process): Likewise.
8705 * termhooks.h (struct terminal): Likewise.
8706 * window.c (struct save_window_data, struct saved_window): Likewise.
8707 * window.h (struct window): Likewise.
8708 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8709 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8710 * buffer.c (init_buffer_once): Likewise.
8711 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8713 * process.c (Fformat_network_address): Use local var for size,
8716 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8718 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8719 * data.c (atof): Remove decl; no longer used or needed.
8720 (digit_to_number): Move to lread.c.
8721 (Fstring_to_number): Use new string_to_number function, to be
8722 consistent with how the Lisp reader treats infinities and NaNs.
8723 Do not assume that floating-point numbers represent EMACS_INT
8724 without losing information; this is not true on most 64-bit hosts.
8725 Avoid double-rounding errors, by insisting on integers when
8726 parsing non-base-10 numbers, as the documentation specifies.
8727 * lisp.h (string_to_number): New decl, replacing ...
8728 (isfloat_string): Remove.
8729 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8730 (read1): Do not accept +. and -. as integers; this
8731 appears to have been a coding error. Similarly, do not accept
8732 strings like +-1e0 as floating point numbers. Do not report
8733 overflow for integer overflows unless the base is not 10 which
8734 means we have no simple and reliable way to continue.
8735 Break out the floating-point parsing into a new
8736 function string_to_number, so that Fstring_to_number parses
8737 floating point numbers consistently with the Lisp reader.
8738 (digit_to_number): Move here from data.c. Make it static inline.
8739 (E_CHAR, EXP_INT): Remove, replacing with ...
8740 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8741 (string_to_number): New function, replacing isfloat_string.
8742 This function checks for valid syntax and produces the resulting
8743 Lisp float number too. Rework it so that string-to-number
8744 no longer mishandles examples like "1.0e+". Use strtoumax,
8745 so that overflow for non-base-10 numbers is reported only when
8746 there's no portable and simple way to convert to floating point.
8748 * textprop.c (set_text_properties_1): Rewrite for clarity,
8749 and to avoid GCC warning about integer overflow.
8751 * intervals.h (struct interval): Use EMACS_INT for members
8752 where EMACS_UINT might cause problems. See
8753 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8754 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8755 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8757 (offset_intervals): Tell GCC not to worry about length overflow
8758 when negating a negative length.
8760 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8761 (overrun_check_free): Likewise.
8763 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8764 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8767 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8768 (gnutls_make_error): Rename local to avoid shadowing.
8769 (gnutls_emacs_global_deinit): ifdef out; not used.
8770 (Fgnutls_boot): Use const for pointer to readonly storage.
8771 Comment out unused local. Fix pointer signedness problems.
8773 * lread.c (openp): Don't stuff size_t into an 'int'.
8774 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8775 about possible signed overflow.
8777 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8778 (GDK_KEY_g): Don't define if already defined.
8779 (xg_prepare_tooltip): Avoid pointer signedness problem.
8780 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8782 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8783 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8785 * xfns.c (Fx_window_property): Simplify a bit,
8786 to make a bit faster and to avoid GCC 4.6.0 warning.
8787 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8789 * fns.c (internal_equal): Don't assume size_t fits in int.
8791 * alloc.c (compact_small_strings): Tighten assertion a little.
8793 Replace pEd with more-general pI, and fix some printf arg casts.
8794 * lisp.h (pI): New macro, generalizing old pEd macro to other
8795 conversion specifiers. For example, use "...%"pI"d..." rather
8796 than "...%"pEd"...".
8797 (pEd): Remove. All uses replaced with similar uses of pI.
8798 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8799 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8800 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8801 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8802 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8803 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8804 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8806 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8807 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8808 * print.c (safe_debug_print, print_object): Likewise.
8809 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8811 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8812 avoiding the 0 flag, which is not portable.
8813 * process.c (Fmake_network_process): Use pI to avoid cast.
8814 * region-cache.c (pp_cache): Likewise.
8815 * xdisp.c (decode_mode_spec): Likewise.
8816 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8817 behavior on 64-bit hosts with printf arg.
8818 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8819 (x_stop_queuing_selection_requests): Likewise.
8820 (x_get_window_property): Don't truncate byte count to an 'int'
8823 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8824 here, since it parses constructs like leading '-' and spaces,
8825 which are not wanted; and it overflows with large numbers.
8826 Instead, simply match F[0-9]+, which is what is wanted anyway.
8828 * alloc.c: Remove unportable assumptions about struct layout.
8829 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8830 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8831 (allocate_vectorlike, make_pure_vector): Use the new macros,
8832 plus offsetof, to remove unportable assumptions about struct layout.
8833 These assumptions hold on all porting targets that I know of, but
8834 they are not guaranteed, they're easy to remove, and removing them
8835 makes further changes easier.
8837 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8838 This doesn't fix a bug but makes the code clearer.
8839 (string_overrun_cookie): Now const. Use initializers that
8840 don't formally overflow signed char, to avoid warnings.
8841 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8842 can cause Emacs to crash when string overrun checking is enabled.
8843 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8844 multiple of sizeof (EMACS_INT); it need not be, if
8845 alignof(EMACS_INT) < sizeof (EMACS_INT).
8846 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8848 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8850 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8852 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8854 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8855 supposed to be handshaking. (Bug#8556)
8856 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8858 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8860 * lisp.h (Qdebug): List symbol.
8861 * eval.c (Qdebug): Restore global linkage.
8862 * keyboard.c (debug-on-event): New variable.
8863 (handle_user_signal): Break into debugger when debug-on-event
8864 matches the current signal symbol.
8866 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8868 * alloc.c (check_sblock, check_string_bytes)
8869 (check_string_free_list): Convert to standard C.
8871 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8873 * w32.c (emacs_gnutls_push): Fix typo.
8875 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8877 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8878 "cast to pointer from integer of different size".
8880 Improve doprnt and its use in verror. (Bug#8545)
8881 * doprnt.c (doprnt): Document the set of format control sequences
8882 supported by the function. Use SAFE_ALLOCA instead of always
8885 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8886 is one byte too soon. Don't use xrealloc; instead xfree and
8889 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8891 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8894 * gnutls.c: Renamed global_initialized to
8895 gnutls_global_initialized. Added internals for the
8896 :verify-hostname-error, :verify-error, and :verify-flags
8897 parameters of `gnutls-boot' and documented those parameters in the
8898 docstring. Start callback support.
8899 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8900 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8901 on error. Return error code.
8902 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8903 (emacs_gnutls_read): Likewise.
8904 (Fgnutls_boot): Return handshake error code.
8905 (emacs_gnutls_handle_error): New function.
8906 (wsaerror_to_errno): Likewise.
8908 * w32.h (emacs_gnutls_pull): Add prototype.
8909 (emacs_gnutls_push): Likewise.
8911 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8912 (emacs_gnutls_push): Likewise.
8914 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8916 * process.c (wait_reading_process_output): Check if GnuTLS
8917 buffered some data internally if no FDs are set for TLS
8920 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8921 (LIBS): Link to USER_LIBS.
8922 ($(BLD)/gnutls.$(0)): New target.
8924 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8926 * xdisp.c (handle_single_display_spec): Rename the
8927 display_replaced_before_p argument into display_replaced_p, to
8928 make it consistent with the commentary. Fix typos in the
8931 * textprop.c (syms_of_textprop): Remove dead code.
8932 (copy_text_properties): Delete obsolete commentary about an
8933 interface that was deleted long ago. Fix typos in the description
8936 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8937 to changes in oldXMenu/XMenu.h from 2011-04-16.
8938 <menu_help_message, prev_menu_help_message>: Constify.
8939 (IT_menu_make_room): menu->help_text is now `const char **';
8942 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8943 to changes in oldXMenu/XMenu.h from 2011-04-16.
8944 (struct XMenu): Declare `help_text' `const char **'.
8946 * xfaces.c <Qunspecified>: Make extern again.
8948 * syntax.c: Include sys/types.h before including regex.h, as
8951 * doc.c (get_doc_string): Improve the format passed to `error'.
8953 * doprnt.c (doprnt): Improve commentary.
8955 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8957 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8960 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8961 changes in globals.h immediately force recompilation.
8962 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8963 $(CURDIR)/s/ms-w32.h.
8964 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8966 * character.c (Fchar_direction): Function deleted.
8967 (syms_of_character): Don't defsubr it.
8968 <char-direction-table>: Deleted.
8970 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8972 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8973 * doprnt.c: Include limits.h.
8974 (SIZE_MAX): New macro.
8975 (doprnt): Return a size_t value. 2nd arg is now size_t.
8976 Many local variables are now size_t instead of int or unsigned.
8977 Improve overflow protection. Support `l' modifier for integer
8978 conversions. Support %l conversion. Don't assume an EMACS_INT
8979 argument for integer conversions and for %c.
8981 * lisp.h (doprnt): Restore prototype.
8983 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8986 * Makefile.in (base_obj): Add back doprnt.o.
8988 * deps.mk (doprnt.o): Add back prerequisites.
8989 (callint.o): Depend on character.h.
8991 * eval.c (internal_lisp_condition_case): Include the handler
8992 representation in the error message.
8993 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8994 when breaking from the loop.
8996 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8998 * callint.c (Fcall_interactively): When displaying error message
8999 about invalid control letter, pass the character's codepoint, not
9000 a pointer to its multibyte form. Improve display of the character
9001 in octal and display also its hex code.
9003 * character.c (char_string): Use %x to display the (unsigned)
9004 codepoint of an invalid character, to avoid displaying a bogus
9007 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9008 `error', not SYMBOL_NAME itself.
9010 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9011 character arguments to `error'.
9013 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9014 to `error' in error message about FINAL_CHAR argument. Make sure
9015 FINAL_CHAR is a character, and use %c when it is passed as
9016 argument to `error'.
9018 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9020 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9022 * w32.c: Include <time.h>.
9023 (sys_localtime): New function.
9025 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9027 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9029 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9031 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9033 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9036 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9038 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9039 gl_state.e_property when gl_state.object is Qt.
9041 * insdel.c (make_gap_larger): Remove limitation of buffer size
9044 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9046 * xdisp.c (lookup_glyphless_char_display)
9047 (produce_glyphless_glyph): Handle cons cell entry in
9048 glyphless-char-display.
9049 (Vglyphless_char_display): Document it.
9051 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9052 glyphless-char-display.
9054 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9056 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9058 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9060 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9061 definition for no-X builds.
9063 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9065 Static checks with GCC 4.6.0 and non-default toolkits.
9067 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9069 * process.c (keyboard_bit_set): Define only if SIGIO.
9070 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9071 (send_process): Repair possible setjmp clobbering.
9073 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9075 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9077 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9079 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9080 Define only if needed.
9082 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9083 by pacifying GCC about it. Maybe it's time to retire it?
9084 * xfaces.c (USG, __TIMEVAL__): Likewise.
9086 * dispextern.h (struct redisplay_interface): Rename param
9088 * termhooks.h (struct terminal): Likewise.
9089 * xterm.c (xembed_send_message): Likewise.
9091 * insdel.c (make_gap_smaller): Define only if
9092 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9094 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9097 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9098 so that we aren't warned about unused symbols.
9100 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9102 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9104 * xfns.c (x_real_positions): Mark locals as initialized.
9106 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9108 * xterm.c: Fix problems found by static analysis with other toolkits.
9109 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9110 (x_dispatch_event): Declare static if USE_GTK, and
9111 define if USE_GTK || USE_X_TOOLKIT.
9112 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9113 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9114 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9115 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9117 * xmenu.c (menu_help_callback): Pointer type fixes.
9118 Use const pointers when pointing at readonly data. Avoid pointer
9120 (FALSE): Remove unused macro.
9121 (update_frame_menubar): Remove unused decl.
9123 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9125 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9126 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9127 (single_menu_item): Rename local to avoid shadowing.
9129 * keyboard.c (make_lispy_event): Remove unused local var.
9131 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9132 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9134 * bitmaps: Change bitmaps from unsigned char back to the X11
9135 compatible char. Avoid the old compiler warnings about
9136 out-of-range initializers by using, for example, '\xab' rather
9139 * xgselect.c (xgselect_initialize): Check vs interface
9140 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9142 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9144 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9145 to read-only memory.
9147 * fns.c (vector): Remove; this old hack is no longer needed.
9149 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9151 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9153 * xrdb.c (x_load_resources): Omit unused local.
9155 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9156 (x_window): Rename locals to avoid shadowing.
9157 (USG): Use the kludged USG macro, to pacify gcc.
9159 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9160 (x_term_init): Remove local to avoid shadowing.
9162 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9164 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9165 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9167 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9169 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9171 Fix regex.c, syntax.c and friends for buffers > 2GB.
9172 * syntax.h (struct gl_state_s): Declare character position members
9175 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9177 * textprop.c (verify_interval_modification, interval_of):
9178 Declare arguments EMACS_INT.
9180 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9183 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9185 * indent.c (Fvertical_motion): Local variable it_start is now
9188 * regex.c (re_match, re_match_2, re_match_2_internal)
9189 (bcmp_translate, regcomp, regexec, print_double_string)
9190 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9191 (re_compile_pattern, re_exec): Declare arguments and local
9192 variables `size_t' and `ssize_t' and return values `regoff_t', as
9194 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9195 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9196 <compile_stack_type>: `size' and `avail' are now `size_t'.
9198 * regex.h <regoff_t>: Use ssize_t, not int.
9199 (re_search, re_search_2, re_match, re_match_2): Arguments that
9200 specify buffer/string position and length are now ssize_t and
9201 size_t. Return type is regoff_t.
9203 2011-04-16 Ben Key <bkey76@gmail.com>
9205 * nsfont.m: Fixed bugs in ns_get_family and
9206 ns_descriptor_to_entity that were caused by using free to
9207 deallocate memory blocks that were allocated by xmalloc (via
9208 xstrdup). This caused Emacs to crash when compiled with
9209 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9210 --enable-checking=xmallocoverrun). xfree is now used to
9211 deallocate these memory blocks.
9213 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9215 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9217 emacs_write: Accept and return EMACS_INT for sizes.
9218 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9220 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9221 Accept and return EMACS_INT.
9222 (emacs_gnutls_write): Return the number of bytes written on
9224 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9225 (emacs_read, emacs_write): Remove check for negative size, as the
9226 Emacs source code has been audited now.
9227 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9228 (emacs_read, emacs_write): Use it.
9229 * process.c (send_process): Adjust to the new signatures of
9230 emacs_write and emacs_gnutls_write. Do not attempt to store
9231 a byte offset into an 'int'; it might overflow.
9232 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9234 * sound.c: Don't assume sizes fit in 'int'.
9235 (struct sound_device.period_size, alsa_period_size):
9236 Return EMACS_INT, not int.
9237 (struct sound_device.write, vox_write, alsa_write):
9238 Accept EMACS_INT, not int.
9239 (wav_play, au_play): Use EMACS_INT to store sizes and to
9240 record read return values.
9242 2011-04-15 Ben Key <bkey76@gmail.com>
9244 * keyboard.c (Qundefined): Don't declare static since it is used
9246 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9247 static since they are used in nsfont.m.
9249 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9251 * process.c (Qprocessp): Don't declare static.
9252 * lisp.h (Qprocessp): Declare again.
9254 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9256 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9258 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9260 Improve C-level modularity by making more things 'static'.
9262 Don't publish debugger-only interfaces to other modules.
9263 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9264 (verify_bytepos, count_markers): Move decls to the only modules
9266 * region-cache.h (pp_cache): Likewise.
9267 * window.h (check_all_windows): Likewise.
9268 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9270 * sysdep.c (croak): Now static, if
9271 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9272 * syssignal.h (croak): Declare only if not static.
9274 * alloc.c (refill_memory_reserve): Now static if
9275 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9276 * lisp.h (refill_memory_reserve): Declare only if not static.
9278 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9279 Define only if USE_LUCID.
9281 * xrdb.c (x_customization_string, x_rm_string): Now static.
9283 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9284 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9286 * xdisp.c (draw_row_with_mouse_face): Now static.
9287 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9289 * window.h (check_all_windows): Mark externally visible.
9291 * window.c (window_deletion_count): Now static.
9293 * undo.c: Make symbols static if they're not exported.
9294 (last_undo_buffer, last_boundary_position, pending_boundary):
9297 * textprop.c (interval_insert_behind_hooks): Now static.
9298 (interval_insert_in_front_hooks): Likewise.
9300 * term.c: Make symbols static if they're not exported.
9301 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9302 (max_frame_lines, tty_set_terminal_modes):
9303 (tty_reset_terminal_modes, tty_turn_off_highlight):
9304 (get_tty_terminal): Now static.
9305 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9306 * termhooks.h (term_mouse_moveto): Do not declare if
9308 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9309 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9311 * sysdep.c: Make symbols static if they're not exported.
9312 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9314 (sigprocmask_set, full_mask): Remove; unused.
9315 (wait_debugging): Mark as visible.
9316 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9317 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9319 * syntax.c (syntax_temp): Define only if !__GNUC__.
9321 * sound.c (current_sound_device, current_sound): Now static.
9323 * search.c (searchbufs, searchbuf_head): Now static.
9325 * scroll.c (scroll_cost): Remove; unused.
9326 * dispextern.h (scroll_cost): Remove decl.
9328 * region-cache.h (pp_cache): Mark as externally visible.
9330 * process.c: Make symbols static if they're not exported.
9331 (process_tick, update_tick, create_process, chan_process):
9332 (Vprocess_alist, proc_buffered_char, datagram_access):
9333 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9334 (deactivate_process): Mark defn as static, as well as decl.
9335 * lisp.h (create_process): Remove decl.
9336 * process.h (chan_process, Vprocess_alist): Remove decls.
9338 * print.c: Make symbols static if they're not exported.
9339 (print_depth, new_backquote_output, being_printed, print_buffer):
9340 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9341 (print_interval, print_number_index, initial_stderr_stream):
9343 * lisp.h (Fprinc): Remove decl.
9344 (debug_output_compilation_hack): Mark as externally visible.
9346 * sysdep.c (croak): Move decl from here to syssignal.h.
9347 * syssignal.h (croak): Put it here, so the API can be checked when
9348 'croak' is called from dissociate_if_controlling_tty.
9350 * minibuf.c: Make symbols static if they're not exported.
9351 (minibuf_save_list, choose_minibuf_frame): Now static.
9352 * lisp.h (choose_minibuf_frame): Remove decl.
9354 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9356 * lread.c: Make symbols static if they're not exported.
9357 (read_objects, initial_obarray, oblookup_last_bucket_number):
9359 (make_symbol): Remove; unused.
9360 * lisp.h (initial_obarray, make_symbol): Remove decls.
9362 * keyboard.c: Make symbols static if they're not exported.
9363 (single_kboard, recent_keys_index, total_keys, recent_keys):
9364 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9365 (this_single_command_key_start, echoing, last_auto_save):
9366 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9367 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9368 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9369 (Vlispy_mouse_stem, double_click_count):
9371 (force_auto_save_soon): Define only if SIGDANGER.
9372 (ignore_mouse_drag_p): Now static if
9373 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9374 (print_help): Remove; unused.
9375 (stop_character, last_timer_event): Mark as externally visible.
9376 * keyboard.h (ignore_mouse_drag_p): Declare only if
9377 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9378 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9379 * lisp.h (echoing): Remove decl.
9380 (force_auto_save_soon): Declare only if SIGDANGER.
9381 * xdisp.c (redisplay_window): Simplify code, to make it more
9382 obvious that ignore_mouse_drag_p is not accessed if !defined
9383 USE_GTK && !defined HAVE_NS.
9385 * intervals.c: Make symbols static if they're not exported.
9386 (merge_properties_sticky, merge_interval_right, delete_interval):
9388 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9390 * insdel.c: Make symbols static if they're not exported.
9391 However, leave prepare_to_modify_buffer alone. It's never
9392 called from outside this function, but that appears to be a bug.
9393 (combine_after_change_list, combine_after_change_buffer):
9394 (adjust_after_replace, signal_before_change): Now static.
9395 (adjust_after_replace_noundo): Remove; unused.
9396 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9397 (signal_before_change): Remove decls.
9399 * indent.c (val_compute_motion, val_vmotion): Now static.
9401 * image.c: Make symbols static if they're not exported.
9402 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9404 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9405 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9407 * fringe.c (standard_bitmaps): Now static.
9408 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9410 * frame.c: Make symbols static if they're not exported.
9411 (x_report_frame_params, make_terminal_frame): Now static.
9412 (get_frame_param): Now static, unless HAVE_NS.
9413 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9414 (x_get_resource_string): Remove; not used.
9415 * frame.h (make_terminal_frame, x_report_frame_params):
9416 (x_get_resource_string); Remove decls.
9417 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9418 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9420 * font.c, fontset.c: Make symbols static if they're not exported.
9421 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9422 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9423 * font.c (font_close_object): Now static.
9424 * font.h (font_close_object): Remove.
9425 * fontset.c (FONTSET_OBJLIST): Remove.
9426 (free_realized_fontset) #if-0 the body, which does nothing.
9427 (face_suitable_for_char_p): #if-0, as it's never called.
9428 * fontset.h (face_suitable_for_char_p): Remove decl.
9429 * xfaces.c (face_at_string_position):
9430 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9431 since 0 is always ASCII.
9433 * fns.c (weak_hash_tables): Now static.
9435 * fileio.c: Make symbols static if they're not exported.
9436 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9437 (Vwrite_region_annotation_buffers): Now static.
9439 * eval.c: Make symbols static if they're not exported.
9440 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9441 * lisp.h (backtrace_list): Remove decl.
9443 * emacs.c: Make symbols static if they're not exported.
9444 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9445 (fatal_error_code, fatal_error_signal_hook, standard_args):
9447 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9448 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9449 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9450 * lisp.h (fatal_error_signal_hook): Remove decl.
9451 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9453 * editfns.c: Move a (normally-unused) function to its only use.
9454 * editfns.c, lisp.h (get_operating_system_release): Remove.
9455 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9456 worth the hassle of breaking this out.
9458 * xterm.c: Make symbols static if they're not exported.
9459 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9460 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9461 (x_destroy_window, x_delete_display):
9463 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9464 (x_mouse_leave): Remove; unused.
9465 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9466 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9467 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9469 (x_mouse_leave): Declare only if WINDOWSNT.
9470 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9471 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9474 * ftxfont.c: Make symbols static if they're not exported.
9475 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9477 * font.h (ftxfont_driver): Likewise.
9479 * xfns.c: Make symbols static if they're not exported.
9480 (x_last_font_name, x_display_info_for_name):
9481 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9482 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9483 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9484 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9485 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9486 (last_show_tip_args): Now static.
9487 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9488 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9489 (x_screen_planes): Remove; unused.
9490 * dispextern.h (x_screen_planes): Remove decl.
9492 * dispnew.c: Make symbols static if they're not exported.
9493 * dispextern.h (redraw_garbaged_frames, scrolling):
9494 (increment_row_positions): Remove.
9495 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9496 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9498 (redraw_garbaged_frames): Remove; unused.
9500 * xfaces.c: Make symbols static if they're not exported.
9501 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9503 * xterm.h (defined_color): Remove decls.
9504 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9505 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9506 (menu_face_changed_default, defined_color, free_realized_face):
9507 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9508 (ascii_face_of_lisp_face): Remove; unused.
9510 * xdisp.c: Make symbols static if they're not exported.
9511 * dispextern.h (scratch_glyph_row, window_box_edges):
9512 (glyph_to_pixel_coords, set_cursor_from_row):
9513 (get_next_display_element, set_iterator_to_next):
9514 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9515 (show_mouse_face): Remove decls
9516 * frame.h (message_buf_print): Likewise.
9517 * lisp.h (pop_message, set_message, check_point_in_composition):
9519 * xterm.h (set_vertical_scroll_bar): Likewise.
9520 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9521 (message_buf_print, scratch_glyph_row, displayed_buffer):
9522 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9523 (get_next_display_element, show_mouse_face, window_box_edges):
9524 (frame_to_window_pixel_xy, check_point_in_composition):
9525 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9526 (glyph_to_pixel_coords): Remove; unused.
9528 * dired.c (file_name_completion): Now static.
9530 * dbusbind.c (xd_in_read_queued_messages): Now static.
9532 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9533 * data.c (circular_list_error): Remove.
9535 * commands.h (last_point_position, last_point_position_buffer):
9536 (last_point_position_window): Remove decls.
9537 * keyboard.c: Make these variables static.
9539 * coding.h (coding, code_convert_region, encode_coding_gap):
9541 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9542 (iso_code_class, detect_coding, code_convert_region): Now static.
9543 (encode_coding_gap): Remove; unused.
9545 * chartab.c (chartab_chars, chartab_bits): Now static.
9547 * charset.h (charset_iso_8859_1): Remove decl.
9548 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9551 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9552 * ccl.c (Vccl_program_table): Now static.
9553 (check_ccl_update): Remove; unused.
9555 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9556 * category.h: ... from here.
9557 * category.c (check_category_table, set_category_set): Now static.
9559 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9560 * lisp.h: Remove these decls.
9562 * buffer.c (buffer_count): Remove unused var.
9564 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9565 so that it's not optimized away.
9566 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9567 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9568 exported only to the debugger.
9570 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9571 * atimer.h (run_all_atimers): Remove; not exported.
9573 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9574 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9575 was inaccessible from Lisp.
9576 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9577 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9579 alloc.c: Import and export fewer symbols, and remove unused items.
9580 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9582 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9583 it's not optimized away by whole-program optimization.
9584 (message_enable_multibyte, free_misc): Remove.
9585 (catchlist, handlerlist, mark_backtrace):
9586 Declare only if BYTE_MARK_STACK.
9587 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9588 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9589 (message_enable_multibyte): Remove decl.
9590 (free_misc, interval_free_list, float_block, float_block_index):
9591 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9592 (cons_free_list, last_marked_index):
9594 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9595 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9596 (mark_backtrace): Define only if BYTE_MARK_STACK.
9597 * xdisp.c (message_enable_multibyte): Now static.
9599 Declare Lisp_Object Q* variables to be 'static' if not exported.
9600 This makes it easier for human readers (and static analyzers)
9601 to see whether these variables are used from other modules.
9602 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9603 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9604 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9605 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9606 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9607 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9608 * xmenu.c, xselect.c:
9609 Declare Q* vars static if they are not used in other modules.
9610 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9611 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9612 Remove decls of unexported vars.
9613 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9615 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9617 Make Emacs functions such as Fatom 'static' by default.
9618 This makes it easier for human readers (and static analyzers)
9619 to see whether these functions can be called from other modules.
9620 DEFUN now defines a static function. To make the function external
9621 so that it can be used in other C modules, use the new macro DEFUE.
9622 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9623 (Finit_image_library):
9624 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9625 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9626 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9627 Remove decls, since these functions are now static.
9628 (Funintern, Fget_internal_run_time): New decls, since these functions
9629 were already external.
9631 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9632 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9633 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9634 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9635 * keyboard.c, keymap.c, lread.c:
9636 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9637 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9638 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9639 Mark functions with DEFUE instead of DEFUN,
9640 if they are used in other modules.
9641 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9642 decls for now-static functions.
9643 * buffer.h (Fdelete_overlay): Remove decl.
9644 * callproc.c (Fgetenv_internal): Mark as internal.
9645 * composite.c (Fremove_list_of_text_properties): Remove decl.
9646 (Fcomposition_get_gstring): New forward static decl.
9647 * composite.h (Fcomposite_get_gstring): Remove decl.
9648 * dired.c (Ffile_attributes): New forward static decl.
9649 * doc.c (Fdocumntation_property): New forward static decl.
9650 * eval.c (Ffetch_bytecode): New forward static decl.
9651 (Funintern): Remove extern decl; now in .h file where it belongs.
9652 * fileio.c (Fmake_symbolic_link): New forward static decl.
9653 * image.c (Finit_image_library): New forward static decl.
9654 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9655 * intervals.h (Fprevious_property_change):
9656 (Fremove_list_of_text_properties): Remove decls.
9657 * keyboard.c (Fthis_command_keys): Remove decl.
9658 (Fcommand_execute): New forward static decl.
9659 * keymap.c (Flookup_key): New forward static decl.
9660 (Fcopy_keymap): Now static.
9661 * keymap.h (Flookup_key): Remove decl.
9662 * process.c (Fget_process): New forward static decl.
9663 (Fprocess_datagram_address): Mark as internal.
9664 * syntax.c (Fsyntax_table_p): New forward static decl.
9665 (skip_chars): Remove duplicate decl.
9666 * textprop.c (Fprevious_property_change): New forward static decl.
9667 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9669 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9670 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9672 * editfns.c (Fformat): Remove unreachable code.
9674 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9676 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9679 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9681 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9682 when at ZV. (Bug#8487)
9684 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9686 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9688 * keyboard.c (parse_tool_bar_item): Likewise.
9689 * sound.c (sound_cleanup, alsa_close): Likewise.
9690 * termcap.c (tgetent): Likewise.
9691 * xfns.c (x_default_font_parameter): Likewise.
9692 * xsettings.c (read_and_apply_settings): Likewise.
9694 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9695 (overrun_check_free): Protoize.
9697 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9699 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9700 since callers should never pass a negative size.
9701 Change the signature to match that of plain 'read' and 'write'; see
9702 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9703 * lisp.h: Update prototypes of emacs_write and emacs_read.
9705 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9707 * xdisp.c (redisplay_window): Don't try to determine the character
9708 position of the scroll margin if the window start point w->startp
9709 is outside the buffer's accessible region. (Bug#8468)
9711 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9713 Fix write-region and its subroutines for buffers > 2GB.
9714 * fileio.c (a_write, e_write): Modify declaration of arguments and
9715 local variables to support buffers larger than 2GB.
9716 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9718 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9719 argument, local variables, and return value.
9721 * lisp.h: Update prototypes of emacs_write and emacs_read.
9723 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9725 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9727 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9729 Fix more problems found by GCC 4.6.0's static checks.
9731 * xdisp.c (vmessage): Use a better test for character truncation.
9733 * charset.c (load_charset_map): <, not <=, for optimization,
9734 and to avoid potential problems with integer overflow.
9735 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9736 * casetab.c (set_identity, shuffle): Likewise.
9737 * editfns.c (Fformat): Likewise.
9738 * syntax.c (skip_chars): Likewise.
9740 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9741 This also lets GCC 4.6.0 generate slightly better loop code.
9743 * callint.c (Fcall_interactively): <, not <=, for optimization.
9744 (Fcall_interactively): Count the number of arguments produced,
9745 not the number of arguments given. This is simpler and lets GCC
9746 4.6.0 generate slightly better code.
9748 * ftfont.c: Distingish more carefully between FcChar8 and char.
9749 The previous code passed unsigned char * to a functions like
9750 strlen and xstrcasecmp that expect char *, which does not
9751 conform to the C standard.
9752 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9753 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9754 char * when the C standard requires it.
9756 * keyboard.c (read_char): Remove unused var.
9758 * eval.c: Port to Windows vsnprintf (Bug#8435).
9760 (SIZE_MAX): Define if the headers do not.
9761 (verror): Do not give up if vsnprintf returns a negative count.
9762 Instead, grow the buffer. This ports to Windows vsnprintf, which
9763 does not conform to C99. Problem reported by Eli Zaretskii.
9764 Also, simplify the allocation scheme, by avoiding the need for
9765 calling realloc, and removing the ALLOCATED variable.
9767 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9769 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9770 But keep the doprint source code for now, as we might revamp it
9771 and use it again (Bug#8435).
9772 * lisp.h (doprnt): Remove.
9773 * Makefile.in (base_obj): Remove doprnt.o.
9774 * deps.mk (doprnt.o): Remove.
9776 error: Print 32- and 64-bit integers portably (Bug#8435).
9777 Without this change, on typical 64-bit hosts error ("...%d...", N)
9778 was used to print both 32- and 64-bit integers N, which relied on
9780 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9781 * lisp.h (error, verror): Mark as printf-like functions.
9782 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9783 Report overflow in size calculations when allocating printf buffer.
9784 Do not truncate output string at its first null byte.
9785 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9786 Truncate the output at a character boundary, since vsnprintf does not
9788 * charset.c (check_iso_charset_parameter): Convert internal
9789 character to string before calling 'error', since %c now has the
9791 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9792 overflow when computing char to be passed to 'error'. Do not
9793 pass Lisp_Object to 'error'; pass the integer instead.
9794 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9795 formatted with plain %d.
9797 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9799 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9801 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9803 * xterm.c (x_catch_errors): Remove duplicate declaration.
9805 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9807 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9809 2011-04-10 Jim Meyering <meyering@redhat.com>
9811 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9812 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9813 return ssize_t not "int", and use size_t as the buffer length.
9814 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9815 * gnutls.h: Update declarations.
9816 * process.c (read_process_output): Use ssize_t, to match.
9817 (send_process): Likewise.
9819 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9821 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9823 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9825 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9826 Use unsigned char, to match FcChar8 type definition.
9828 * xterm.c (handle_one_xevent):
9829 * xmenu.c (create_and_show_popup_menu):
9830 * xselect.c (x_decline_selection_request)
9831 (x_reply_selection_request): Avoid type-punned deref of X events.
9833 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9835 Fix some uses of `int' instead of EMACS_INT.
9836 * search.c (string_match_1, fast_string_match)
9837 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9838 (scan_buffer, find_next_newline_no_quit)
9839 (find_before_next_newline, search_command, Freplace_match)
9840 (Fmatch_data): Make some `int' variables be EMACS_INT.
9842 * xdisp.c (display_count_lines): 3rd argument and return value now
9843 EMACS_INT. All callers changed.
9844 (pint2hrstr): Last argument is now EMACS_INT.
9846 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9847 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9848 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9849 (decode_coding_utf_16, decode_coding_emacs_mule)
9850 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9851 (decode_coding_ccl, decode_coding_charset)
9852 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9853 (decode_coding_iso_2022, decode_coding_emacs_mule)
9854 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9855 <char_offset, last_offset>: Declare EMACS_INT.
9856 (encode_coding_utf_8, encode_coding_utf_16)
9857 (encode_coding_emacs_mule, encode_invocation_designation)
9858 (encode_designation_at_bol, encode_coding_iso_2022)
9859 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9860 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9862 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9863 (encode_invocation_designation): Last argument P_NCHARS is now
9865 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9866 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9868 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9871 * ccl.c (Fccl_execute_on_string): Declare some variables
9874 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9876 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9878 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9880 * process.c (Fformat_network_address): Doc fix.
9882 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9884 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9886 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9888 * keyboard.c (read_char): Call Lisp function help-form-show,
9889 instead of using internal_with_output_to_temp_buffer.
9890 (Qhelp_form_show): New var.
9891 (syms_of_keyboard): Use DEFSYM macro.
9893 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9895 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9897 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9899 * process.c (Flist_processes): Remove to Lisp.
9900 (list_processes_1): Delete.
9902 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9904 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9906 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9908 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9910 Fix more problems found by GCC 4.6.0's static checks.
9912 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9914 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9916 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9918 * xdisp.c (vmessage): Mark as a printf-like function.
9920 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9922 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9924 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9925 printf-like functions.
9926 (tiff_load): Add casts to remove these marks before passing them
9927 to system-supplied API.
9929 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9931 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9932 This avoids several warnings with gcc -Wstrict-overflow.
9933 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9934 directly, rather than having caller test rule sign. This avoids
9935 some unnecessary tests.
9936 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9937 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9938 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9940 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9941 (xfont_open): Avoid unnecessary tests.
9943 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9945 * composite.h, composite.c (composition_gstring_put_cache):
9946 Use EMACS_INT, not int, for length.
9948 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9949 breaking out part of COMPOSITION_DECODE_RULE.
9950 (COMPOSITION_DECODE_RULE): Use it.
9951 * composite.c (get_composition_id): Remove unused local vars,
9952 by using the new macro.
9954 * textprop.c (set_text_properties_1): Change while to do-while,
9955 since the condition is always true at first.
9957 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9958 (interval_deletion_adjustment): Return unsigned value.
9961 * process.c (list_processes_1, create_pty, read_process_output):
9962 (exec_sentinel): Remove vars that were set but not used.
9963 (create_pty): Remove unnecessary "volatile"s.
9964 (Fnetwork_interface_info): Avoid possibility of int overflow.
9965 (read_process_output): Do adaptive read buffering even if carryover.
9966 (read_process_output): Simplify nbytes computation if buffered.
9968 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9970 * syntax.c (scan_words): Remove var that was set but not used.
9971 (update_syntax_table): Use unsigned instead of int.
9973 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9974 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9975 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9977 * print.c (print_error_message): Avoid int overflow.
9979 * font.c (font_list_entities): Redo for clarity,
9980 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9982 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9983 (font_score): Avoid potential overflow in diff calculation.
9985 * fns.c (substring_both): Remove var that is set but not used.
9986 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9988 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9990 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9991 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9992 can always succeed if overflow has undefined behavior.
9994 * search.c (boyer_moore, wordify): Remove vars set but not used.
9995 (wordify): Omit three unnecessary tests.
9997 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9998 All callers changed. This avoids the need for an unused var.
10000 * casefiddle.c (casify_region): Remove var that is set but not used.
10002 * dired.c (file_name_completion): Remove var that is set but not used.
10004 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10006 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10007 (Finsert_file_contents): Remove unnecessary code checking fd.
10009 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10010 Check for integer overflow on size calculations.
10012 * buffer.c (Fprevious_overlay_change): Remove var that is set
10015 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10016 Remove vars that are set but not used.
10017 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10018 (timer_check_2): Mark vars as initialized.
10020 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10022 * image.c (lookup_image): Remove var that is set but not used.
10023 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10025 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10026 that are set but not used.
10028 * xfns.c (make_invisible_cursor): Don't return garbage
10029 if XCreateBitmapFromData fails (Bug#8410).
10031 * xselect.c (x_get_local_selection, x_handle_property_notify):
10032 Remove vars that are set but not used.
10034 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10035 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10037 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10038 Remove var that is set but not used.
10039 (scroll_bar_windows_size): Now size_t, not int.
10040 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10041 Check for overflow.
10043 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10044 (map_tty_color) [!defined MSDOS]: Likewise.
10046 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10048 * coding.c: Remove vars that are set but not used.
10049 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10050 All callers changed.
10051 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10052 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10053 (decode_coding_charset): Remove vars that are set but not used.
10055 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10056 that is set but not used.
10058 * print.c (print_object): Remove var that is set but not used.
10060 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10061 The gnulib version avoids calling malloc in the usual case,
10062 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10063 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10064 * filelock.c (current_lock_owner): Likewise.
10065 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10066 * sysdep.c: Include allocator.h, careadlinkat.h.
10067 (emacs_no_realloc_allocator): New static constant.
10068 (emacs_readlink): New function.
10069 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10070 ../lib/careadlinkat.h.
10072 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10074 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10075 first non-nil return value).
10077 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10079 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10080 if not defined (Bug#8403).
10082 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10084 * xdisp.c (display_count_lines): Remove parameter `start',
10085 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10086 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10087 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10088 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10089 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10090 and thereabouts. All callers changed.
10091 (get_per_char_metric): Remove parameter `f', unused since
10092 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10094 2011-04-02 Jim Meyering <meyering@redhat.com>
10096 do not dereference NULL upon failed strdup
10097 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10098 (ns_get_family): Likewise.
10100 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10102 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10104 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10106 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10109 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10111 Add lexical binding.
10113 * window.c (Ftemp_output_buffer_show): New fun.
10114 (Fsave_window_excursion):
10115 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10117 * lread.c (lisp_file_lexically_bound_p): New function.
10118 (Fload): Bind Qlexical_binding.
10119 (readevalloop): Remove `evalfun' arg.
10120 Bind Qinternal_interpreter_environment.
10121 (Feval_buffer): Bind Qlexical_binding.
10122 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10124 (syms_of_lread): Declare `lexical-binding'.
10126 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10128 * keyboard.c (eval_dyn): New fun.
10129 (menu_item_eval_property): Use it.
10131 * image.c (parse_image_spec): Use Ffunctionp.
10133 * fns.c (concat, mapcar1): Accept byte-code-functions.
10135 * eval.c (Fsetq): Handle lexical vars.
10136 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10137 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10138 (FletX, Flet): Obey lexical binding.
10139 (Fcommandp): Handle closures.
10140 (Feval): New `lexical' arg.
10141 (eval_sub): New function extracted from Feval. Use it almost
10142 everywhere where Feval was used. Look up vars in lexical env.
10144 (Ffunctionp): Move from subr.el.
10145 (Ffuncall): Handle closures.
10146 (apply_lambda): Remove `eval_flags'.
10147 (funcall_lambda): Handle closures and new byte-code-functions.
10148 (Fspecial_variable_p): New function.
10149 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10150 but without exporting it to Lisp.
10152 * doc.c (Fdocumentation, store_function_docstring):
10153 * data.c (Finteractive_form): Handle closures.
10155 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10158 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10160 (exec_byte_code): New function extracted from Fbyte_code to handle new
10161 calling convention for byte-code-functions. Add new byte-codes.
10163 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10165 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10167 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10169 * xdisp.c (redisplay_internal): Fix prototype.
10171 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10173 * xdisp.c (SCROLL_LIMIT): New macro.
10174 (try_scrolling): Use it when setting scroll_limit.
10175 Limit scrolling to 100 screen lines.
10176 (redisplay_window): Even when falling back on "recentering",
10177 position point in the window according to scroll-conservatively,
10178 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10180 (try_scrolling): When point is above the window, allow searching
10181 as far as scroll_max, or one screenful, to compute vertical
10182 distance from PT to the scroll margin position. This prevents
10183 try_scrolling from unnecessarily failing when
10184 scroll-conservatively is set to a value slightly larger than the
10185 window height. Clean up the case of PT below the margin at bottom
10186 of window: scroll_max can no longer be INT_MAX. When aggressive
10187 scrolling is in use, don't let point enter the opposite scroll
10188 margin as result of the scroll.
10189 (syms_of_xdisp) <scroll-conservatively>: Document the
10190 threshold of 100 lines for never-recentering scrolling.
10192 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10194 * dispextern.h (move_it_by_lines):
10195 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10196 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10197 (message_log_check_duplicate): Remove parameters `prev_bol' and
10198 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10199 (redisplay_internal): Remove parameter `preserve_echo_area',
10200 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10202 * indent.c (Fvertical_motion):
10203 * window.c (window_scroll_pixel_based, Frecenter):
10204 Don't pass `need_y_p' to `move_it_by_lines'.
10206 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10208 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10209 steal a few bits to be more compact.
10210 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10211 Remove unneeded casts.
10213 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10215 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10217 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10218 binding" message (bug#7967).
10220 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10222 Fix more problems found by GCC 4.6.0's static checks.
10224 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10225 Remove unused local var.
10227 * editfns.c (Fmessage_box): Remove unused local var.
10229 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10230 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10231 Omit unused local vars.
10232 * window.c (shrink_windows): Omit unused local var.
10233 * menu.c (digest_single_submenu): Omit unused local var.
10234 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10235 Omit unused local var.
10237 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10238 Don't assume string length fits in int.
10239 (keyremap_step, read_key_sequence): Use size_t for sizes.
10240 (read_key_sequence): Don't check last_real_key_start redundantly.
10242 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10243 instead of alloca (Bug#8344).
10245 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10246 (Fbacktrace_frame): Don't assume nframes fits in int.
10248 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10250 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10253 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10255 * cm.c (calccost): Turn while-do into do-while, for clarity.
10257 * keyboard.c (syms_of_keyboard): Use the same style as later
10258 in this function when indexing through an array. This also
10259 works around GCC bug 48267.
10261 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10263 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10265 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10266 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10268 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10269 This avoids undefined behavior on integer overflow, and is a bit
10270 more convenient anyway since it is compared to a size_t variable.
10272 Variadic C functions now count arguments with size_t, not int.
10273 This avoids an unnecessary limitation on 64-bit machines, which
10274 caused (substring ...) to crash on large vectors (Bug#8344).
10275 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10276 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10277 All variadic functions and their callers changed accordingly.
10278 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10279 * data.c (arith_driver, float_arith_driver): Likewise.
10280 * editfns.c (general_insert_function): Likewise.
10281 * eval.c (struct backtrace.nargs, interactive_p)
10282 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10283 (funcall_lambda, mark_backtrace): Likewise.
10284 * fns.c (concat): Likewise.
10285 * frame.c (x_set_frame_parameters): Likewise.
10286 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10287 0 if not found, not -1. All callers changed.
10289 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10290 (stack_copy_size): Now size_t, not int.
10291 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10293 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10295 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10296 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10297 All callers changed.
10299 * lisp.h (multibyte_char_to_unibyte):
10300 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10301 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10302 * character.h (CHAR_TO_BYTE8):
10303 * cmds.c (internal_self_insert):
10304 * editfns.c (general_insert_function):
10305 * keymap.c (push_key_description):
10306 * search.c (Freplace_match):
10307 * xdisp.c (message_dolog, set_message_1): All callers changed.
10309 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10311 * keyboard.c (safe_run_hook_funcall): New function.
10312 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10313 don't set the hook to nil, but remove the offending function instead.
10314 (Qcommand_hook_internal): Remove, unused.
10315 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10316 Vcommand_hook_internal.
10318 * eval.c (enum run_hooks_condition): Remove.
10319 (funcall_nil, funcall_not): New functions.
10320 (run_hook_with_args): Call each function through a `funcall' argument.
10321 Remove `cond' argument, now redundant.
10322 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10323 (Frun_hook_with_args_until_failure): Adjust accordingly.
10324 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10326 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10328 * dispextern.h (string_buffer_position): Remove declaration.
10330 * print.c (strout): Remove parameter `multibyte', unused since
10331 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10333 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10334 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10335 All callers changed.
10337 * w32.c (_wsa_errlist): Use braces for struct initializers.
10339 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10340 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10341 All callers changed.
10342 (string_buffer_position): Likewise. Also, make static (it's never
10343 used outside xdisp.c).
10344 (cursor_row_p): Remove parameter `w', unused since
10345 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10346 (decode_mode_spec): Remove parameter `precision', introduced during
10347 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10348 All callers changed.
10350 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10352 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10354 2011-03-27 Anders Lindgren <andlind@gmail.com>
10356 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10357 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10358 (ns_update_auto_hide_menu_bar): New functions.
10359 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10360 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10361 ns_constrain_all_frames.
10362 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10363 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10365 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10367 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10369 2011-03-27 Glenn Morris <rgm@gnu.org>
10371 * syssignal.h: Replace RETSIGTYPE with void.
10372 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10373 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10374 Replace SIGTYPE with void everywhere.
10375 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10376 * s/template.h (SIGTYPE): Remove commented out definition.
10378 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10380 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10381 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10383 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10385 * w32.c (read_unc_volume): Use parameter `henum', instead of
10386 global variable `wget_enum_handle'.
10388 * keymap.c (describe_vector): Remove parameters `indices' and
10389 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10390 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10392 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10394 * keyboard.c (timer_check): Remove parameter `do_it_now',
10395 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10396 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10397 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10399 * keyboard.c (read_char):
10400 * w32menu.c (w32_menu_display_help):
10401 * xmenu.c (show_help_event, menu_help_callback):
10402 Adjust calls to `show_help_echo'.
10404 * gtkutil.c (xg_maybe_add_timer):
10405 * keyboard.c (readable_events):
10406 * process.c (wait_reading_process_output):
10407 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10409 * insdel.c (adjust_markers_gap_motion):
10410 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10411 (gap_left, gap_right): Don't call it.
10413 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10415 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10416 incurred during fontification.
10418 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10420 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10421 (DEFVAR_PER_BUFFER): Don't pass it.
10423 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10424 (scrolling_window): Don't pass it.
10426 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10428 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10430 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10432 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10433 of variables specific to SELinux and computation of `encoded_absname'.
10435 * image.c (XPutPixel): Remove unused variable `height'.
10437 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10439 * unexw32.c (get_section_info): Remove unused variable `section'.
10441 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10442 (system_process_attributes): Remove unused variable `sess'.
10443 (sys_read): Remove unused variable `err'.
10445 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10446 (w32_wnd_proc): Remove unused variable `isdead'.
10447 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10448 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10449 (x_create_tip_frame): Remove unused variable `tem'.
10451 * w32inevt.c (w32_console_read_socket):
10452 Remove unused variable `no_events'.
10454 * w32term.c (x_draw_composite_glyph_string_foreground):
10455 Remove unused variable `width'.
10457 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10459 * w32term.c (x_set_glyph_string_clipping):
10460 Don't pass uninitialized region to CombineRgn.
10462 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10464 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10465 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10466 (Fx_close_connection): Remove unused variable `i'.
10468 * w32font.c (w32font_draw): Return number of glyphs.
10469 (w32font_open_internal): Remove unused variable `i'.
10470 (w32font_driver): Add missing initializer.
10472 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10473 (fill_in_menu): Remove unused variable `items_added'.
10475 * w32term.c (last_mouse_press_frame): Remove static global variable.
10476 (w32_clip_to_row): Remove unused variable `f'.
10477 (x_delete_terminal): Remove unused variable `i'.
10479 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10480 (NOTHING): Remove unused static global variable.
10481 (uniscribe_check_otf): Remove unused variable `table'.
10482 (uniscribe_font_driver): Add missing initializers.
10484 2011-03-23 Julien Danjou <julien@danjou.info>
10486 * term.c (Fsuspend_tty, Fresume_tty):
10487 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10488 * window.c (temp_output_buffer_show):
10489 * insdel.c (signal_before_change):
10490 * frame.c (Fhandle_switch_frame):
10491 * fileio.c (Fdo_auto_save):
10492 * emacs.c (Fkill_emacs):
10493 * editfns.c (save_excursion_restore):
10494 * cmds.c (internal_self_insert):
10495 * callint.c (Fcall_interactively):
10496 * buffer.c (Fkill_all_local_variables):
10497 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10499 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10500 unconditionally since it does the check itself.
10502 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10504 Fix more problems found by GCC 4.5.2's static checks.
10506 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10507 the first time through the loop, since we know p0 < p1 then.
10508 This also avoids a gcc -Wstrict-overflow warning.
10510 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10511 leading to a memory leak, possible in functions like
10512 load_charset_map_from_file that can allocate an unbounded number
10513 of objects (Bug#8318).
10515 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10516 that could (at least in theory) be that large.
10518 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10519 This is less likely to overflow, and avoids undefined behavior if
10520 overflow does occur. All callers changed. Use strtoul to scan
10521 for the unsigned long integer.
10522 (pint2hrstr): Simplify and tune code slightly.
10523 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10525 * scroll.c (do_scrolling): Work around GCC bug 48228.
10526 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10528 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10529 This also avoids a warning with gcc -Wstrict-overflow.
10530 (validate_x_resource_name): Simplify count usage.
10531 This also avoids a warning with gcc -Wstrict-overflow.
10533 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10536 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10538 * process.c (Fmake_network_process): Use socklen_t, not int,
10539 where POSIX says socklen_t is required in portable programs.
10540 This fixes a porting bug on hosts like 64-bit HP-UX, where
10541 socklen_t is wider than int (Bug#8277).
10542 (Fmake_network_process, server_accept_connection):
10543 (wait_reading_process_output, read_process_output):
10546 * process.c: Rename or move locals to avoid shadowing.
10547 (list_processes_1, Fmake_network_process):
10548 (read_process_output_error_handler, exec_sentinel_error_handler):
10549 Rename or move locals.
10550 (Fmake_network_process): Define label "retry_connect" only if needed.
10551 (Fnetwork_interface_info): Fix pointer signedness.
10552 (process_send_signal): Add cast to avoid pointer signedness problem.
10553 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10554 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10556 Make tparam.h and terminfo.c consistent.
10557 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10558 Include tparam.h instead, since it declares them.
10559 * cm.h (PC): Remove extern decl; tparam.h now does this.
10560 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10561 * terminfo.c: Include tparam.h, to check interfaces.
10562 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10563 (tparam): Adjust signature to match interface in tparam.h;
10564 this removes some undefined behavior. Check that outstring and len
10565 are zero, which they always are with Emacs.
10566 * tparam.h (PC, BC, UP): New extern decls.
10568 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10569 (xftfont_open): Rename locals to avoid shadowing.
10571 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10572 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10573 (OTF_TAG_SYM): Omit macro if not needed.
10574 (ftfont_list): Remove unused local.
10575 (get_adstyle_property, ftfont_pattern_entity):
10576 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10577 Rename locals to avoid shadowing.
10579 * xfont.c (xfont_list_family): Mark var as initialized.
10581 * xml.c (make_dom): Now static.
10583 * composite.c (composition_compute_stop_pos): Rename local to
10585 (composition_reseat_it): Remove unused locals.
10586 (find_automatic_composition, composition_adjust_point): Likewise.
10587 (composition_update_it): Mark var as initialized.
10588 (find_automatic_composition): Mark vars as initialized,
10589 with a FIXME (Bug#8290).
10591 character.h: Rename locals to avoid shadowing.
10592 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10593 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10594 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10595 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10596 to avoid shadowing.
10598 * textprop.c (property_change_between_p): Remove; unused.
10600 * intervals.c (interval_start_pos): Now static.
10602 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10604 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10605 Rename locals to avoid shadowing.
10607 * sound.c (wav_play, au_play, Fplay_sound_internal):
10608 Fix pointer signedness.
10609 (alsa_choose_format): Remove unused local var.
10610 (wav_play): Initialize a variable to 0, to prevent undefined
10611 behavior (Bug#8278).
10613 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10615 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10617 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10618 clobbering (Bug#8298).
10619 * sysdep.c (sys_subshell): Likewise.
10620 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10622 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10623 This should get cleaned up, so that child_setup has the
10624 same signature on all platforms.
10626 * callproc.c (call_process_cleanup): Now static.
10627 (relocate_fd): Rename locals to avoid shadowing.
10629 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10631 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10632 not to be necessary, and produces flickering.
10634 2011-03-20 Glenn Morris <rgm@gnu.org>
10636 * config.in: Remove file.
10638 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10640 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10641 are now in src/globals.h.
10642 (syms_of_minibuf): Remove spurious & from previous change.
10644 2011-03-20 Leo Liu <sdl.web@gmail.com>
10646 * minibuf.c (completing-read-function): New variable.
10647 (completing-read-default): Rename from completing-read.
10648 (completing-read): Call completing-read-function.
10650 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10652 * xfaces.c (Fx_load_color_file):
10653 Read color file from absolute filename (bug#8250).
10655 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10657 * makefile.w32-in: Update dependencies.
10659 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10661 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10663 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10665 Fix more problems found by GCC 4.5.2's static checks.
10667 * process.c (make_serial_process_unwind, send_process_trap):
10668 (sigchld_handler): Now static.
10670 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10671 That way, the code declares only the vars that it needs.
10672 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10673 * s/cygwin.h (PTY_ITERATION): Likewise.
10674 * s/darwin.h (PTY_ITERATION): Likewise.
10675 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10677 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10678 * process.c (allocate_pty): Don't declare stb unless it's needed.
10680 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10681 (CONSTANTLIM): Remove; unused.
10682 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10683 Define only if needed.
10685 * unexelf.c (unexec): Name an expression,
10686 to avoid gcc -Wbad-function-cast warning.
10687 Use a different way to cause a compilation error if anyone uses
10688 n rather than nn, a way that does not involve shadowing.
10689 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10691 * deps.mk (unexalpha.o): Remove; unused.
10693 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10694 * unexec.h: New file.
10695 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10696 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10697 Depend on unexec.h.
10698 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10699 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10700 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10701 Change as necessary to match prototype in unexec.h.
10703 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10705 (back_comment, skip_chars): Mark vars as initialized.
10707 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10708 Rename locals to avoid shadowing.
10710 * lread.c (read1): Rewrite so as not to use empty "else".
10711 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10713 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10715 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10716 warning when compiling print.c.
10718 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10719 instead of using an uninitialized var.
10720 (font_sort_entities): Mark var as initialized.
10722 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10724 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10725 pointers to constants.
10726 (font_parse_fcname): Remove unused vars.
10727 (font_delete_unmatched): Now static.
10728 (font_get_spec): Remove; unused.
10729 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10730 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10731 Rename or move locals to avoid shadowing.
10733 * fns.c (require_nesting_list, require_unwind): Now static.
10734 (Ffillarray): Rename locals to avoid shadowing.
10736 * floatfns.c (domain_error2): Define only if needed.
10737 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10739 * alloc.c (mark_backtrace): Move decl from here ...
10740 * lisp.h: ... to here, so that it can be checked.
10742 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10743 (Fdefvar): Rewrite so as not to use empty "else".
10744 (lisp_indirect_variable): Name an expression,
10745 to avoid gcc -Wbad-function-cast warning.
10746 (Fdefvar): Rename locals to avoid shadowing.
10748 * callint.c (quotify_arg, quotify_args): Now static.
10749 (Fcall_interactively): Rename locals to avoid shadowing.
10750 Use const pointer when appropriate.
10752 * lisp.h (get_system_name, get_operating_system_release):
10753 Move decls here, to check interfaces.
10754 * process.c (get_operating_system_release): Move decl to lisp.h.
10755 * xrdb.c (get_system_name): Likewise.
10756 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10757 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10758 some of which prompt warnings from gcc -Wbad-function-cast.
10759 (Fformat_time_string, Fencode_time, Finsert_char):
10760 (Ftranslate_region_internal, Fformat):
10761 Rename or remove local vars to avoid shadowing.
10762 (Ftranslate_region_internal): Mark var as initialized.
10764 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10767 * lisp.h (eassert): Check that the argument compiles, even if
10768 ENABLE_CHECKING is not defined.
10770 * data.c (Findirect_variable): Name an expression, to avoid
10771 gcc -Wbad-function-cast warning.
10772 (default_value, arithcompare, arith_driver, arith_error): Now static.
10773 (store_symval_forwarding): Rename local to avoid shadowing.
10774 (Fmake_variable_buffer_local, Fmake_local_variable):
10775 Mark variables as initialized.
10776 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10778 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10779 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10780 Rename locals to avoid shadowing.
10781 (mark_stack): Move local variables into the #ifdef region where
10783 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10784 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10786 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10787 (GC_STRING_CHARS): Remove; not used.
10788 (Fmemory_limit): Cast sbrk's returned value to char *.
10790 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10791 avoids undefined behavior in theory.
10793 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10795 Use functions, not macros, for up- and down-casing (Bug#8254).
10796 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10797 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10798 to use the following functions instead of these macros.
10799 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10800 EMACS_INT, since callers assume the returned value fits in int.
10801 (upcase1): Likewise, for UPCASE_TABLE.
10802 (uppercasep, lowercasep, upcase): New static inline functions.
10803 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10804 the race-condition problem in the old DOWNCASE.
10806 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10807 Rename locals to avoid shadowing.
10808 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10809 (regex_compile, re_search_2, re_match_2_internal):
10810 Remove unused local vars.
10811 (FREE_VAR): Rewrite so as not to use empty "else",
10812 which gcc can warn about.
10813 (regex_compile, re_match_2_internal): Mark locals as initialized.
10814 (RETALLOC_IF): Define only if needed.
10815 (WORDCHAR_P): Likewise. This one is never needed, but is used
10816 only in a comment talking about a compiler bug, so put inside
10817 the #if 0 of that comment.
10818 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10819 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10822 * search.c (boyer_moore): Rename locals to avoid shadowing.
10823 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10824 (PREV_CHAR_BOUNDARY): Likewise.
10826 * search.c (simple_search): Remove unused var.
10828 * dired.c (compile_pattern): Move decl from here ...
10829 * lisp.h: ... to here, so that it can be checked.
10830 (struct re_registers): New forward decl.
10832 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10834 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10836 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10837 Rename locals to avoid shadowing.
10838 (Fvertical_motion): Mark locals as initialized.
10840 * casefiddle.c (casify_object, casify_region): Now static.
10841 (casify_region): Mark local as initialized.
10843 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10845 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10846 New macros, so that the caller can use some names other than
10847 gcpro1, gcpro2, etc.
10848 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10850 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10851 argument, for consistency with GCPRO2_VAR, etc: it is now the
10852 prefix of the variable, not the variable itself. All uses
10854 * dired.c (directory_files_internal, file_name_completion):
10855 Rename locals to avoid shadowing.
10857 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10858 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10859 dired.c's scmp function, had undefined behavior.
10860 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10861 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10862 * buffer.h: ... to here, because these macros use current_buffer,
10863 and the new implementation with inline functions needs to have
10864 current_buffer in scope now, rather than later when the macros
10866 (downcase, upcase1): New static inline functions.
10867 (DOWNCASE, UPCASE1): Reimplement using these functions.
10868 This avoids undefined behavior in expressions like
10869 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10870 from race conditions in accessing the global variables
10871 case_temp1 and case_temp2.
10872 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10873 * lisp.h (case_temp1, case_temp2): Remove their decls.
10874 * character.h (ASCII_CHAR_P): Move from here ...
10875 * lisp.h: ... to here, so that the inline functions mentioned
10876 above can use them.
10878 * dired.c (directory_files_internal_unwind): Now static.
10880 * fileio.c (file_name_as_directory, directory_file_name):
10881 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10883 (file_name_as_directory): Use const pointers when appropriate.
10884 (Fexpand_file_name): Likewise. In particular, newdir might
10885 point at constant storage, so make it a const pointer.
10886 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10887 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10889 (Fset_file_times, Finsert_file_contents, auto_save_error):
10890 Rename locals to avoid shadowing.
10892 * minibuf.c (choose_minibuf_frame_1): Now static.
10893 (Ftry_completion, Fall_completions): Rename or remove locals
10894 to avoid shadowing.
10896 * marker.c (bytepos_to_charpos): Remove; unused.
10898 * lisp.h (verify_bytepos, count_markers): New decls,
10899 so that gcc does not warn that these functions aren't declared.
10901 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10902 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10903 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10904 (copy_text): Remove unused local var.
10906 * filelock.c (within_one_second): Now static.
10907 (lock_file_1): Rename local to avoid shadowing.
10909 * buffer.c (fix_overlays_before): Mark locals as initialized.
10910 (fix_start_end_in_overlays): Likewise. This function should be
10911 simplified by using pointers-to-pointers, but that's a different
10913 (switch_to_buffer_1): Now static.
10914 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10915 (report_overlay_modification): Rename locals to avoid shadowing.
10917 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10918 Fix pointer signedness issue.
10919 (sys_subshell): Mark local as volatile if checking for lint,
10920 to suppress a gcc -Wclobbered warning that does not seem to be right.
10921 (MAXPATHLEN): Define only if needed.
10923 * process.c (serial_open, serial_configure): Move decls from here ...
10924 * systty.h: ... to here, so that they can be checked.
10926 * fns.c (get_random, seed_random): Move extern decls from here ...
10927 * lisp.h: ... to here, so that they can be checked.
10929 * sysdep.c (reset_io): Now static.
10930 (wait_for_termination_signal): Remove; unused.
10932 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10933 (copy_keymap_item, append_key, push_text_char_description):
10935 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10936 (DENSE_TABLE_SIZE): Remove; unused.
10937 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10938 (describe_map_tree):
10939 Rename locals to avoid shadowing.
10941 * keyboard.c: Declare functions static if they are not used elsewhere.
10942 (echo_char, echo_dash, cmd_error, top_level_2):
10943 (poll_for_input, handle_async_input): Now static.
10944 (read_char, kbd_buffer_get_event, make_lispy_position):
10945 (make_lispy_event, make_lispy_movement, apply_modifiers):
10946 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10947 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10948 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10949 (read_key_sequence, read_char): Mark locals as initialized.
10950 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10952 * keyboard.h (make_ctrl_char): New decl.
10953 (mark_kboards): Move decl here ...
10954 * alloc.c (mark_kboards): ... from here.
10956 * lisp.h (force_auto_save_soon): New decl.
10958 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10959 (DEFINE_DUMMY_FUNCTION): New macro.
10960 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10962 (main): Add casts to avoid warnings
10963 if GCC considers string literals to be constants.
10965 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10967 * dbusbind.c: Pointer signedness fixes.
10968 (xd_signature, xd_append_arg, xd_initialize):
10969 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10970 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10971 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10972 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10974 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10975 if GCC considers string literals to be constants.
10976 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10978 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10980 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10981 (print_preprocess, print_object): New macro to fix last change.
10983 * print.c (print_preprocess): Don't forget font objects.
10985 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10987 * emacs.c (USAGE3): Doc fixes.
10989 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10991 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10994 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10996 * lisp.h (VWindow_system, Qfile_name_history):
10997 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10998 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10999 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11001 * w32select.c: Don't #include "keyboard.h".
11002 (run_protected): Add extern declaration for waiting_for_input.
11004 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11005 * w32console.c (detect_input_pending, read_input_pending)
11006 (encode_terminal_code):
11007 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11008 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11009 (w32_system_caret_y, Qfile_name_history):
11010 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11011 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11012 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11013 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11014 * w32proc.c (Qlocal, report_file_error):
11015 * w32term.c (Vwindow_system, updating_frame):
11016 * w32uniscribe.c (initialized, uniscribe_font_driver):
11017 Remove unneeded extern declarations.
11019 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11021 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11023 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11025 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11026 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11027 These macros can no longer be used for assignment.
11029 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11030 Assign struct members directly, instead of using BUF_BEGV etc.
11031 (record_buffer_markers, fetch_buffer_markers): New functions for
11032 recording and fetching special buffer markers.
11033 (set_buffer_internal_1, set_buffer_temp): Use them.
11035 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11037 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11039 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11040 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11042 * xdisp.c (hscroll_window_tree):
11043 (reconsider_clip_changes): Use PT instead of BUF_PT.
11045 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11047 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11048 $(EMACS_ROOT)/lib/intprops.h.
11050 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11052 Fix more problems found by GCC 4.5.2's static checks.
11054 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11055 to unsigned char * to avoid compiler diagnostic.
11056 (xg_free_frame_widgets): Make it clear that a local variable is
11057 needed only if USE_GTK_TOOLTIP.
11058 (gdk_window_get_screen): Make it clear that this macro is needed
11059 only if USE_GTK_TOOLTIP.
11060 (int_gtk_range_get_value): New function, which avoids a diagnostic
11061 from gcc -Wbad-function-cast.
11062 (xg_set_toolkit_scroll_bar_thumb): Use it.
11063 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11064 diagnostic from gcc -Wbad-function-cast.
11065 (get_utf8_string, xg_get_file_with_chooser):
11066 Rename locals to avoid shadowing.
11067 (create_dialog): Move locals to avoid shadowing.
11069 * xgselect.c (xg_select): Remove unused var.
11071 * image.c (four_corners_best): Mark locals as initialized.
11072 (gif_load): Initialize transparent_p to zero (Bug#8238).
11073 Mark another local as initialized.
11074 (my_png_error, my_error_exit): Mark with NO_RETURN.
11076 * image.c (clear_image_cache): Now static.
11077 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11078 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11079 (x_edge_detection): Remove unnecessary cast that
11080 gcc -Wbad-function-cast diagnoses.
11081 (gif_load): Fix pointer signedness.
11082 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11083 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11085 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11087 Improve quality of tests for time stamp overflow.
11088 For example, without this patch (encode-time 0 0 0 1 1
11089 1152921504606846976) returns the obviously-bogus value (-948597
11090 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11091 reports time overflow. See
11092 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11093 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11094 * editfns.c: Include limits.h and intprops.h.
11095 (TIME_T_MIN, TIME_T_MAX): New macros.
11096 (time_overflow): Move earlier, to before first use.
11097 (hi_time, lo_time): New functions, for an accurate test for
11098 out-of-range times.
11099 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11100 (Fget_internal_run_time): Don't assume time_t fits in int.
11101 (make_time): Use list2 instead of Fcons twice.
11102 (Fdecode_time): More accurate test for out-of-range times.
11103 (check_tm_member): New function.
11104 (Fencode_time): Use it, to test for out-of-range times.
11105 (lisp_time_argument): Don't rely on undefined left-shift and
11106 right-shift behavior when checking for time stamp overflow.
11108 * editfns.c (time_overflow): New function, refactoring common code.
11109 (Fformat_time_string, Fdecode_time, Fencode_time):
11110 (Fcurrent_time_string): Use it.
11112 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11113 * dired.c (make_time): Move to ...
11114 * editfns.c (make_time): ... here.
11115 * systime.h: Note the move.
11117 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11119 * fringe.c (update_window_fringes): Remove unused variables.
11121 * unexmacosx.c (copy_data_segment): Also copy __got section.
11124 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11126 * termcap.c [MSDOS]: Include "msdos.h".
11127 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11128 Constify `char *' arguments and their references according to
11129 prototypes in tparam.h.
11131 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11133 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11134 Adapt all references accordingly.
11136 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11138 2011-03-11 Tom Tromey <tromey@redhat.com>
11140 * buffer.c (syms_of_buffer): Remove obsolete comment.
11142 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11144 * termhooks.h (encode_terminal_code): Declare prototype.
11146 * msdos.c (encode_terminal_code): Don't declare prototype.
11148 * term.c (encode_terminal_code): Now external again, used by
11149 w32console.c and msdos.c.
11151 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11152 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11154 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11156 Fix some minor problems found by GCC 4.5.2's static checks.
11158 * fringe.c (update_window_fringes): Mark locals as initialized
11160 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11162 * alloc.c (mark_fringe_data): Move decl from here ...
11163 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11164 to check its interface.
11165 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11167 * fontset.c (free_realized_fontset): Now static.
11168 (Fset_fontset_font): Rename local to avoid shadowing.
11169 (fontset_font): Mark local as initialized.
11170 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11172 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11174 * xselect.c (x_disown_buffer_selections): Remove; not used.
11175 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11176 (x_own_selection, Fx_disown_selection_internal): Rename locals
11177 to avoid shadowing.
11178 (x_handle_dnd_message): Remove local to avoid shadowing.
11180 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11181 so that the caller can use some name other than gcpro1.
11182 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11183 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11184 (Fx_backspace_delete_keys_p):
11185 Use them to avoid shadowing, and rename vars to avoid shadowing.
11186 (x_decode_color, x_set_name, x_window): Now static.
11187 (Fx_create_frame): Add braces to silence GCC warning.
11188 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11189 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11190 Remove unused locals.
11191 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11192 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11193 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11196 * xterm.h (x_mouse_leave): New decl.
11198 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11199 Remove unused functions.
11200 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11201 (x_calc_absolute_position): Now static.
11202 (XTread_socket): Don't define label "out" unless it's used.
11203 Don't declare local "event" unless it's used.
11204 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11205 unless they are used.
11206 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11207 (x_fatal_error_signal): Remove; not used.
11208 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11209 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11210 (x_error_catcher, x_connection_closed, x_error_handler):
11211 (x_error_quitter, xembed_send_message, x_iconify_frame):
11212 (my_log_handler): Rename locals to avoid shadowing.
11213 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11214 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11216 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11217 Rename or move locals to avoid shadowing.
11218 (tty_defined_color, merge_face_heights): Now static.
11219 (free_realized_faces_for_fontset): Remove; not used.
11220 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11221 does not deduce is never used uninitialized.
11222 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11223 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11225 * terminal.c (store_terminal_param): Now static.
11227 * xmenu.c (menu_highlight_callback): Now static.
11228 (set_frame_menubar): Remove unused local.
11229 (xmenu_show): Rename parameter to avoid shadowing.
11230 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11231 since they might point to immutable storage.
11232 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11233 since it's unused otherwise.
11235 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11236 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11237 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11238 avoids a gcc -Wuninitialized diagnostic.
11239 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11240 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11241 does not deduce are never used uninitialized.
11243 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11245 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11246 * window.c (window_loop, size_window):
11247 (run_window_configuration_change_hook, enlarge_window): Likewise.
11249 * window.c (display_buffer): Now static.
11250 (size_window): Mark variables that gcc -Wuninitialized
11251 does not deduce are never used uninitialized.
11252 * window.h (check_all_windows): New decl, to forestall
11253 gcc -Wmissing-prototypes diagnostic.
11254 * dispextern.h (bidi_dump_cached_states): Likewise.
11256 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11258 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11259 Include <limits.h>.
11260 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11261 and to avoid gcc -Wuninitialized warning.
11262 (load_charset_map): Mark variables that gcc -Wuninitialized
11263 does not deduce are never used uninitialized.
11264 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11266 * coding.c (coding_set_source, coding_set_destination):
11267 Use "else { /* comment */ }" rather than "else /* comment */;"
11268 for clarity, and to avoid gcc -Wempty-body warning.
11269 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11270 a block, when the outer 'i' will do.
11271 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11272 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11273 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11274 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11275 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11276 Rename locals to avoid shadowing.
11277 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11278 * coding.c (emacs_mule_char, encode_invocation_designation):
11279 Now static, since they're not used elsewhere.
11280 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11281 (decode_coding_object, encode_coding_object, detect_coding_system):
11282 (decode_coding_emacs_mule): Mark variables that gcc
11283 -Wuninitialized does not deduce are never used uninitialized.
11284 (detect_coding_iso_2022): Initialize a local variable that might
11285 be used uninitialized. Leave a FIXME because it's not clear that
11286 this initialization is needed. (Bug#8211)
11287 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11288 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11289 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11290 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11291 Remove unused macros.
11293 * category.c (hash_get_category_set): Remove unused local var.
11294 (copy_category_table): Now static, since it's not used elsewhere.
11295 * character.c (string_count_byte8): Likewise.
11297 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11298 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11300 * chartab.c (copy_sub_char_table): Now static, since it's not used
11302 (sub_char_table_ref_and_range, char_table_ref_and_range):
11303 Rename locals to avoid shadowing.
11304 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11306 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11307 (BIDI_BOB): Remove unused macro.
11309 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11310 deduce are never used uninitialized.
11311 * term.c (encode_terminal_code): Likewise.
11313 * term.c (encode_terminal_code): Now static. Remove unused local.
11315 * tparam.h: New file.
11316 * term.c, tparam.h: Include it.
11317 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11318 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11319 Move these decls to tparam.h, and make them agree with what
11320 is actually in tparam.c. The previous trick of using incompatible
11321 decls in different modules does not conform to the C standard.
11322 All callers of tparam changed to use tparam's actual API.
11323 * tparam.c (tparam1, tparam, tgoto):
11324 Use const pointers where appropriate.
11326 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11327 * cm.h (struct cm): Likewise.
11328 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11329 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11330 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11331 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11332 (turn_on_face, init_tty): Likewise.
11333 * termchar.h (struct tty_display_info): Likewise.
11335 * term.c (term_mouse_position): Rename local to avoid shadowing.
11337 * alloc.c (mark_ttys): Move decl from here ...
11338 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11340 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11342 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11344 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11346 * search.c (compile_pattern_1): Remove argument regp, unused since
11347 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11348 (compile_pattern): Don't pass it.
11350 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11352 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11353 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11355 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11357 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11359 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11360 gdk_window_get_screen, gdk_window_get_geometry,
11361 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11362 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11363 (xg_get_pixbuf_from_pixmap): New function.
11364 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11365 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11366 Call xg_get_pixbuf_from_pixmap instead of
11367 gdk_pixbuf_get_from_drawable.
11368 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11369 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11370 (xg_check_special_colors): Use GtkStyleContext and its functions
11372 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11373 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11374 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11375 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11376 Call gtk_widget_get_preferred_size.
11377 (xg_frame_resized): gdk_window_get_geometry only takes 5
11379 (xg_win_to_widget, xg_event_is_for_menubar):
11380 Call gdk_x11_window_lookup_for_display.
11381 (xg_set_widget_bg): New function.
11382 (delete_cb): New function.
11383 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11384 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11385 (xg_set_background_color): Call xg_set_widget_bg.
11386 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11387 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11388 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11389 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11391 (update_frame_tool_bar): Call gtk_widget_hide.
11392 (xg_initialize): Use GDK_KEY_g.
11394 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11396 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11398 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11399 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11400 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11402 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11404 * w32xfns.c (select_palette): Check success of RealizePalette against
11405 GDI_ERROR, not zero.
11407 See ChangeLog.11 for earlier changes.
11409 ;; Local Variables:
11413 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11415 This file is part of GNU Emacs.
11417 GNU Emacs is free software: you can redistribute it and/or modify
11418 it under the terms of the GNU General Public License as published by
11419 the Free Software Foundation, either version 3 of the License, or
11420 (at your option) any later version.
11422 GNU Emacs is distributed in the hope that it will be useful,
11423 but WITHOUT ANY WARRANTY; without even the implied warranty of
11424 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11425 GNU General Public License for more details.
11427 You should have received a copy of the GNU General Public License
11428 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.