]> code.delx.au - gnu-emacs/blob - src/ChangeLog
nnimap.el (nnimap-open-connection-1): Use the correct port number in the error message.
[gnu-emacs] / src / ChangeLog
1 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * Require libxml/parser.h to avoid compilation warning.
4
5 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6
7 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8 since this reportedly can destroy thread storage.
9
10 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
11
12 * syntax.c (find_defun_start): Update all cache variables if
13 exiting early (Bug#9401).
14
15 2011-08-30 Eli Zaretskii <eliz@gnu.org>
16
17 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
18
19 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
20 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
21 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
22
23 * term.c (tty_append_glyph): New function.
24 (produce_stretch_glyph): Static function and its prototype deleted.
25
26 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
27 prototypes.
28
29 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
30
31 * image.c (parse_image_spec): Check for nonnegative, not for positive,
32 when checking :margin (Bug#9390).
33 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
34 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
35 so that the name doesn't mislead. All uses changed.
36
37 2011-08-28 Johan Bockgård <bojohan@gnu.org>
38
39 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
40 set_tty_hooks.
41
42 2011-08-27 Eli Zaretskii <eliz@gnu.org>
43
44 * xdisp.c (move_it_to): Don't bail out early when reaching
45 position beyond to_charpos, if we are scanning backwards.
46 (move_it_vertically_backward): When DY == 0, make sure we get to
47 the first character in the line after the newline.
48
49 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
50
51 * ccl.c: Improve and simplify overflow checking (Bug#9196).
52 (ccl_driver): Do not generate an out-of-range pointer.
53 (Fccl_execute_on_string): Remove unnecessary check for
54 integer overflow, noted by Stefan Monnier in
55 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
56 Remove a FIXME that didn't need fixing.
57 Simplify the newly-introduced buffer reallocation code.
58
59 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
60
61 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
62
63 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
64
65 Integer and memory overflow issues (Bug#9196).
66
67 * doc.c (get_doc_string): Rework so that
68 get_doc_string_buffer_size is the actual buffer size, rather than
69 being 1 less than the actual buffer size; this makes xpalloc more
70 convenient.
71
72 * image.c (x_allocate_bitmap_record, cache_image):
73 * xselect.c (Fx_register_dnd_atom):
74 Simplify previous changes by using xpalloc.
75
76 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
77 since either will do and ptrdiff_t is convenient with xpalloc.
78
79 * charset.c (charset_table_size)
80 (struct charset_sort_data.priority): Now ptrdiff_t.
81 (charset_compare): Don't overflow if priorities differ greatly.
82 (Fsort_charsets): Don't assume list length fits in int.
83 Check for size-calculation overflow when allocating sort data.
84 (syms_of_charset): Allocate an initial charset table that is
85 just under 64 KiB, to avoid problems with glibc malloc and mmap.
86
87 * cmds.c (internal_self_insert): Check for size-calculation overflow.
88
89 * composite.h (struct composition.glyph_len): Now int, not unsigned.
90 The actual value is always <= INT_MAX, and leaving it unsigned made
91 overflow checking harder.
92
93 * dispextern.h (struct glyph_matrix.rows_allocated)
94 (struct face_cache.size): Now ptrdiff_t, for convenience in use
95 with xpalloc. The values are still always <= INT_MAX.
96
97 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
98
99 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
100 (SAFE_NALLOCA): New macro.
101
102 * region-cache.c (struct boundary.pos, find_cache_boundary)
103 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
104 (set_cache_region, invalidate_region_cache)
105 (revalidate_region_cache, know_region_cache, region_cache_forward)
106 (region_cache_backward, pp_cache):
107 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
108 so that ptrdiff_t * can be passed to xpalloc.
109 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
110 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
111 (pp_cache): Don't assume cache_len fits in int.
112 * region-cache.h: Adjust extern decls to match.
113
114 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
115 EMACS_INT, since either will do, for xpalloc.
116
117 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
118 (xnmalloc, xnrealloc, xpalloc): New functions.
119
120 * bidi.c (bidi_shelve_header_size): New constant.
121 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
122 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
123
124 * bidi.c (bidi_cache_shrink):
125 * buffer.c (overlays_at, overlays_in, record_overlay_string)
126 (overlay_strings):
127 Don't update size of array until after memory allocation succeeds,
128 because xmalloc/xrealloc may not return.
129 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
130 now that we have proper integer overflow checking.
131 (record_overlay_string, overlay_strings): Catch overflows when
132 calculating size of overlay_str_buf.
133
134 * callproc.c (Fcall_process): Check for size overflow when
135 calculating size of args2.
136 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
137 Normally we prefer signed values, but sticking with ptrdiff_t would
138 require adding more-complicated checks.
139
140 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
141 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
142 Redo buffer-overflow calculations to avoid integer overflow.
143 Add a FIXME comment where memory seems to be over-allocated.
144
145 * character.c (Fstring): Check for size-calculation overflow.
146
147 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
148 unnecessary integer overflow. Check for size overflow.
149 (encode_coding_object): Don't update size until xmalloc succeeds.
150
151 * composite.c (get_composition_id): Check for overflow in glyph
152 length calculations.
153
154 Integer and memory overflow fixes for display code.
155 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
156 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
157 (scrolling_window): Check for overflow in size calculations.
158 (line_draw_cost, realloc_glyph_pool, add_row_entry):
159 Don't assume glyph table len fits in int.
160 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
161 (row_table_size): Now ptrdiff_t, not int.
162 (scrolling_window): Avoid overflow in size calculations.
163 Don't update size until allocation succeeds.
164 * fns.c (concat): Check for overflow in size calculations.
165 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
166 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
167 (NEXT_ALMOST_PRIME_LIMIT): New constant.
168
169 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
170 (get_doc_string): Check for size calculation overflow.
171 Don't update size until allocation succeeds.
172 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
173 EMACS_INT, where ptrdiff_t will do.
174 (Fsubstitute_command_keys): Check for string overflow.
175
176 * editfns.c (set_time_zone_rule): Don't assume environment length
177 fits in int.
178 (message_length): Now ptrdiff_t, not int.
179 (Fmessage_box): Don't update size until allocation succeeds.
180 Don't assume message length fits in int.
181 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
182
183 * emacs.c (main): Do not reallocate argv, since there is a null at
184 the end that can be overwritten, and this way there's no need to
185 worry about size-calculation overflow.
186 (sort_args): Check for size-calculation overflow.
187
188 * eval.c (init_eval_once, grow_specpdl): Don't update size until
189 alloc succeeds.
190 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
191
192 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
193 (x_set_scroll_bar_width, x_figure_window_size):
194 Check for integer overflow.
195 (x_set_alpha): Do not assume XINT fits in int.
196
197 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
198 This is for the members text_lines, text_cols, total_lines, total_cols,
199 where the system imposes an 'int' limit.
200
201 * fringe.c (Fdefine_fringe_bitmap):
202 Don't update size until alloc works.
203
204 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
205 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
206
207 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
208 Check for size-calculation overflow.
209 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
210 do, as we prefer signed integers.
211 (id_to_widget.max_size, id_to_widget.used)
212 (xg_store_widget_in_map, xg_remove_widget_from_map)
213 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
214 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
215 Use and return ptrdiff_t, not int.
216 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
217 * gtkutil.h: Change prototypes to match the above.
218
219 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
220 are duplicate now that they've been promoted to lisp.h.
221 (x_allocate_bitmap_record, x_alloc_image_color)
222 (make_image_cache, cache_image, xpm_load):
223 Don't update size until alloc is done.
224 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
225 (x_detect_edges):
226 Check for size calculation overflow.
227 (ct_colors_allocated_max): New constant.
228 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
229 overflow.
230
231 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
232 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
233 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
234 Use ptrdiff_t, not int, to count maps.
235 (read_char_minibuf_menu_prompt): Check for overflow in size
236 calculations. Don't update size until allocation succeeds. Redo
237 calculations to avoid overflow.
238 * keyboard.h: Change prototypes to match the above.
239
240 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
241 to count maps.
242 (current_minor_maps): Check for size calculation overflow.
243 * keymap.h: Change prototypes to match the above.
244
245 * lread.c (read1, init_obarray): Don't update size until alloc done.
246
247 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
248 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
249
250 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
251 Now ptrdiff_t, not int.
252 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
253 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
254
255 * process.c (Fnetwork_interface_list): Check for overflow
256 in size calculation.
257
258 * region-cache.c (move_cache_gap): Check for size calculation overflow.
259
260 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
261 overflow. Don't bother calling xmalloc when xrealloc will do.
262
263 * search.c (Freplace_match): Check for size calculation overflow.
264 (Fset_match_data): Don't assume list lengths fit in 'int'.
265
266 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
267 for command line length. Do not attempt to address one before the
268 beginning of an array, as that's not portable.
269
270 * term.c (max_frame_lines): Remove; unused.
271 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
272 not int.
273 (encode_terminal_code, calculate_costs): Check for size
274 calculation overflow.
275 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
276 table lengths and related sizes. Don't update size until alloc
277 done. Redo calculations to avoid overflow.
278 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
279
280 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
281 subtracting pointers.
282 (gobble_line): Check for overflow more carefully. Don't update size
283 until alloc done.
284
285 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
286 Don't update size until alloc done.
287 Redo size calculations to avoid overflow.
288 Check for size calculation overflow.
289 (main) [DEBUG]: Fix typo in invoking tparam1.
290
291 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
292 Use ptrdiff_t, not int, for sizes.
293 (store_mode_line_noprop_char): Don't update size until alloc done.
294
295 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
296 Use ptrdiff_t, not int, for sizes.
297 (Finternal_make_lisp_face, cache_face):
298 Check for size calculation overflow.
299 (cache_face): Treat size calculation overflows as if they were
300 memory exhaustion (the usual treatment), rather than aborting.
301
302 * xfns.c (x_encode_text, x_set_name_internal)
303 (Fx_change_window_property): Use ptrdiff_t, not int, to count
304 sizes, since they can exceed INT_MAX in size. Check for size
305 calculation overflow.
306
307 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
308 (xg_select): Check for size calculation overflow.
309 Don't update size until alloc done.
310
311 * xrdb.c (get_environ_db): Don't assume path length fits in int,
312 as sprintf is limited to int lengths.
313
314 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
315 (X_LONG_MIN): New macros.
316 Use them to make the following changes clearer.
317 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
318 This change doesn't affect the value now, but it may help remind
319 future maintainers not to raise the value too much later.
320 (SELECTION_QUANTUM): Remove, replacing with ...
321 (selection_quantum): ... new function, which avoids overflow.
322 All uses changed.
323 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
324 assumption that selection length fits in 'int'.
325 (x_reply_selection_request, x_handle_selection_request)
326 (x_get_window_property, receive_incremental_selection)
327 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
328 (lisp_data_to_selection_data, clean_local_selection_data):
329 Use ptrdiff_t, not int, to record length of selection.
330 (x_reply_selection_request, x_get_window_property)
331 (receive_incremental_selection, x_property_data_to_lisp):
332 Redo calculations to avoid overflow.
333 (x_reply_selection_request): When sending hint, ceiling it at
334 X_LONG_MAX rather than relying on wraparound overflow to send
335 something.
336 (x_get_window_property, receive_incremental_selection)
337 (lisp_data_to_selection_data, x_property_data_to_lisp):
338 Check for size-calculation overflow.
339 (x_get_window_property, receive_incremental_selection)
340 (lisp_data_to_selection_data, Fx_register_dnd_atom):
341 Don't store size until memory allocation succeeds.
342 (x_get_window_property): Plug memory leak on memory exhaustion.
343 Don't double-block input; malloc is safe here. Don't assume 2**34
344 - 4 fits in unsigned long. Add an xassert to check
345 XGetWindowProperty overflow. Be more careful about overflow
346 calculations, and distinguish size from memory overflow better.
347 (receive_incremental_selection): When tracing, don't assume
348 unsigned int is less than INT_MAX.
349 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
350 harmful) conversions of unsigned short to int.
351 (lisp_data_to_selection_data): Don't assume that integers
352 in the range -65535 through -1 fit in an X unsigned short.
353 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
354 result parameters unless successful. Rely on cons_to_unsigned
355 to report problems with elements; the old code wasn't right anyway.
356 (x_check_property_data): Check for int overflow; we cannot use
357 a wider type due to X limits.
358 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
359
360 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
361
362 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
363 (x_term_init): Check for size calculation overflow.
364 (x_color_cells): Don't store size until memory allocation succeeds.
365 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
366 Don't assume alloca size is less than MAX_ALLOCA.
367 (x_term_init): Don't assume length fits in int (sprintf is limited
368 to int size).
369
370 Use ptrdiff_t for composition IDs.
371 * character.c (lisp_string_width):
372 * composite.c (composition_table_size, n_compositions)
373 (get_composition_id, composition_gstring_from_id):
374 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
375 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
376 * window.c (Frecenter):
377 Use ptrdiff_t, not int, for composition IDs.
378 * composite.c (get_composition_id): Check for integer overflow.
379 * composite.h: Adjust prototypes to match the above changes.
380
381 Use ptrdiff_t for hash table indexes.
382 * category.c (hash_get_category_set):
383 * ccl.c (ccl_driver):
384 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
385 * coding.c (coding_system_charset_list, detect_coding_system):
386 * coding.h (struct coding_system.id):
387 * composite.c (get_composition_id, gstring_lookup_cache):
388 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
389 * image.c (xpm_get_color_table_h):
390 * lisp.h (hash_lookup, hash_put):
391 * minibuf.c (Ftest_completion):
392 Use ptrdiff_t for hash table indexes, not int (which is too
393 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
394 32-bit --with-wide-int hosts).
395
396 * charset.c (Fdefine_charset_internal): Check for integer overflow.
397 Add a FIXME comment about memory leaks.
398 (syms_of_charset): Don't assume xmalloc returns.
399
400 Don't assume that stated character widths fit in int.
401 * character.c (Fchar_width, c_string_width, lisp_string_width):
402 * character.h (CHAR_WIDTH):
403 * indent.c (MULTIBYTE_BYTES_WIDTH):
404 Use sanitize_char_width to avoid undefined and/or bad behavior
405 with outlandish widths.
406 * character.h (sanitize_tab_width): Renamed from sanitize_width,
407 now that we have two such functions. All uses changed.
408 (sanitize_char_width): New inline function.
409
410 Don't assume that tab-width fits in int.
411 * character.h (sanitize_width): New inline function.
412 (SANE_TAB_WIDTH): New macro.
413 (ASCII_CHAR_WIDTH): Use it.
414 * indent.c (sane_tab_width): Remove. All uses replaced by
415 SANE_TAB_WIDTH (current_buffer).
416 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
417
418 * fileio.c: Integer overflow issues with file modes.
419 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
420
421 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
422 Remove unreachable code.
423 (read_hex, load_charset_map_from_file): Check for integer overflow.
424
425 * xterm.c: don't go over XClientMessageEvent limit
426 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
427 (x_send_scroll_bar_event): Likewise. Check that the size does not
428 exceed limits imposed by XClientMessageEvent, as well as the usual
429 ptrdiff_t and size_t limits.
430
431 * keyboard.c: Overflow, signedness and related fixes.
432 (make_lispy_movement): Use same integer type in forward decl
433 that is used in the definition.
434 (read_key_sequence, keyremap_step):
435 Change bufsize argument back to int, undoing my 2011-03-30 change.
436 We prefer signed types, and int is wide enough here.
437 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
438 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
439 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
440 length, not size_t. Use ptrdiff_t for index, not int.
441 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
442 possibility of integer overflow.
443
444 Overflow, signedness and related fixes for images.
445
446 * dispextern.h (struct it.stack[0].u.image.image_id)
447 (struct_it.image_id, struct image.id, struct image_cache.size)
448 (struct image_cache.used, struct image_cache.ref_count):
449 * gtkutil.c (update_frame_tool_bar):
450 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
451 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
452 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
453 * nsmenu.m (update_frame_tool_bar):
454 * xdisp.c (calc_pixel_width_or_height):
455 * xfns.c (image_cache_refcount):
456 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
457 on typical 64-bit hosts.
458
459 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
460 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
461 Omit unnecessary casts to int.
462 (parse_image_spec): Check that integers fall into 'int' range
463 when the callers expect that.
464 (image_ascent): Redo ascent calculation to avoid int overflow.
465 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
466 (lookup_image): Remove unnecessary tests.
467 (xbm_image_p): Locals are now of int, not EMACS_INT,
468 since parse_image_check makes sure they fit into int.
469 (png_load, gif_load, svg_load_image):
470 Prefer int to unsigned where either will do.
471 (tiff_handler): New function, combining the cores of the
472 old tiff_error_handler and tiff_warning_handler. This
473 function is rewritten to use vsnprintf and thereby avoid
474 stack buffer overflows. It uses only the features of vsnprintf
475 that are common to both POSIX and native Microsoft.
476 (tiff_error_handler, tiff_warning_handler): Use it.
477 (tiff_load, gif_load, imagemagick_load_image):
478 Don't assume :index value fits in 'int'.
479 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
480 (imagemagick_load_image): Check that crop parameters fit into
481 the integer types that MagickCropImage accepts. Don't assume
482 Vimagemagick_render_type has a nonnegative value. Don't assume
483 size_t fits in 'long'.
484 (gs_load): Use printmax_t to print the widest integers possible.
485 Check for integer overflow when computing image height and width.
486
487 2011-08-26 Eli Zaretskii <eliz@gnu.org>
488
489 * xdisp.c (redisplay_window): Don't force window start if point
490 will be invisible in the resulting window. (Bug#9324)
491
492 2011-08-25 Eli Zaretskii <eliz@gnu.org>
493
494 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
495 the display spec is of the form `(space ...)'.
496 (handle_display_spec): Return the value returned by
497 handle_single_display_spec, not just 1 or zero.
498 (handle_single_display_spec): If the display spec is of the form
499 `(space ...)', and specifies display in the text area, return 2
500 rather than 1.
501 (try_cursor_movement): Check for the need to scroll more
502 accurately, and prefer exact match for point under bidi. Don't
503 advance `row' beyond the last row of the window.
504
505 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
506 into disp_prop; all users changed.
507
508 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
509 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
510 for the text covered by the display property.
511
512 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
513
514 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
515 Change return value to nil.
516 (Frecord_buffer): Delete unused function.
517
518 2011-08-24 Eli Zaretskii <eliz@gnu.org>
519
520 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
521 buffers, return left-to-right.
522 (set_cursor_from_row): Consider candidate row a win if its glyph
523 represents a newline and point is on that newline. Fixes cursor
524 positioning on the newline at EOL of R2L text within L2R
525 paragraph, and vice versa.
526 (try_cursor_movement): Check continued rows, in addition to
527 continuation rows. Fixes unwarranted scroll when point enters a
528 continued line of R2L text within an L2R paragraph, or vice versa.
529 (cursor_row_p): Consider the case of point being equal to
530 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
531 from the end of a short line to the beginning of a continued line
532 of R2L text within L2R paragraph.
533 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
534 composed characters.
535
536 * bidi.c (bidi_check_type): Use xassert.
537 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
538 members.
539
540 2011-08-23 Eli Zaretskii <eliz@gnu.org>
541
542 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
543 a character.
544
545 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
546
547 * nsfont.m (ns_otf_to_script): Fix typo.
548
549 2011-08-22 Kenichi Handa <handa@m17n.org>
550
551 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
552 extra slot even if the purpose is char-code-property-table.
553
554 2011-08-23 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (redisplay_window): When computing centering_position,
557 account for the height of the header line. (Bug#8874)
558
559 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
560 instead of CHAR_TO_BYTE. Fixes a crash when a completion
561 candidate is selected by the mouse, and that candidate has a
562 composed character under the mouse.
563
564 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
565 coordinates reported by pos-visible-in-window-p for a composed
566 character in column zero.
567
568 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
569
570 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
571
572 2011-08-22 Eli Zaretskii <eliz@gnu.org>
573
574 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
575 consider it a hit if to_charpos is anywhere in the range of the
576 composed buffer positions.
577
578 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
579
580 * image.c (gif_load): Don't assume that each subimage has the same
581 dimensions as the base image. Handle disposal method that is
582 "undefined" by the gif spec (Bug#9335).
583
584 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
585
586 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
587 (Fcondition_case): Document `debug' symbol in error handler.
588
589 2011-08-19 Eli Zaretskii <eliz@gnu.org>
590
591 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
592 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
593 from an Org mode buffer to a Speedbar frame.
594
595 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
596 a composition, take its buffer position from IT->cmp_it.charpos.
597 Fixes cursor positioning at the beginning of a line that begins
598 with a composed character.
599
600 2011-08-18 Eli Zaretskii <eliz@gnu.org>
601
602 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
603 character bidirectional type, use STRONG_L instead. Fixes crashes
604 in a buffer produced by `describe-categories'.
605
606 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
607 members before the level stack, so they would be saved and
608 restored when copying iterator state. Fixes incorrect reordering
609 around TABs covered by display properties.
610
611 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
612
613 * process.c (Fnetwork_interface_list): Correctly determine buffer
614 size.
615
616 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
617
618 * eval.c (internal_condition_case, internal_condition_case_1)
619 (internal_condition_case_2, internal_condition_case_n):
620 Remove unnecessary aborts (Bug#9081).
621
622 2011-08-17 Eli Zaretskii <eliz@gnu.org>
623
624 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
625 has no `load' handler, try opening the file locally. (Bug#9311)
626
627 2011-08-16 Ken Brown <kbrown@cornell.edu>
628
629 * gmalloc.c: Expand comment.
630
631 2011-08-16 Eli Zaretskii <eliz@gnu.org>
632
633 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
634 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
635
636 2011-08-16 Ken Brown <kbrown@cornell.edu>
637
638 Fix memory allocation problems in Cygwin build (Bug#9273).
639
640 * unexcw.c ( __malloc_initialized): Declare external variable.
641 (fixup_executable): Force the dumped emacs to reinitialize malloc.
642
643 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
644 New variables.
645 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
646 dumped emacs.
647 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
648 in the static heap.
649 [CYGWIN] (special_realloc): New function.
650 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
651 requests to realloc storage in the static heap.
652
653 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
654
655 * bidi.c (bidi_initialize): Remove unused local.
656
657 2011-08-15 Eli Zaretskii <eliz@gnu.org>
658
659 * biditype.h: File removed.
660
661 * bidimirror.h: File removed.
662
663 * deps.mk (bidi.o): Remove biditype.h and
664 bidimirror.h.
665
666 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
667 bidimirror.h.
668
669 * dispextern.h: Fix a typo in the comment to bidi_type_t.
670
671 * chartab.c: Improve commentary for the uniprop_table API.
672
673 * bidi.c (bidi_paragraph_init): Support zero value of
674 bidi_ignore_explicit_marks_for_paragraph_level.
675 (bidi_initialize): Use uniprop_table instead of including
676 biditype.h and bidimirror.h.
677
678 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
679 coordinates of the iterator when restoring from ppos_it.
680 (Bug#9296)
681
682 2011-08-14 Kenichi Handa <handa@m17n.org>
683
684 * process.c (create_process): Call setup_process_coding_systems
685 after the pid of the process is set to -1 (Bug#8162).
686
687 2011-08-14 Eli Zaretskii <eliz@gnu.org>
688
689 * xdisp.c (move_it_in_display_line_to): Don't invoke
690 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
691 ppos_it. Fixes vertical cursor motion when line beginning is
692 covered by an image. (Bug#9296)
693
694 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
695
696 * nsterm.h (ns_run_ascript): Declare.
697 (NSAPP_DATA2_RUNASSCRIPT): Define.
698
699 * nsfns.m (as_script, as_result, as_status): New static variables.
700 (ns_run_ascript): New function.
701 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
702 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
703 the event loop. Get status from as_status (Bug#7276).
704
705 * nsterm.m (sendEvent): If event is NSApplicationDefined and
706 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
707 the event loop (Bug#7276).
708
709 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
710
711 * gnutls.c (QCgnutls_bootprop_priority)
712 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
713 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
714 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
715 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
716 (QCgnutls_bootprop_verify_hostname_error)
717 (QCgnutls_bootprop_callbacks_verify): Rename from
718 Qgnutls_bootprop_..., all uses changed.
719
720 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
721 uses changed.
722
723 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
724
725 * xfaces.c (Qframe_set_background_mode): Now static.
726 * dispextern.h (Qframe_set_background_mode): Remove decl.
727
728 * process.c (Fnetwork_interface_info): Declare local only if needed.
729
730 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
731
732 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
733 (Fnetwork_interface_list): Allocate in increments of bytes instead
734 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
735 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
736 sockaddr.
737 (struct ifflag_def): notrailers is smart on OSX.
738 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
739 Get hardware address with getifaddrs if available.
740
741 2011-08-12 Eli Zaretskii <eliz@gnu.org>
742
743 * xdisp.c (iterate_out_of_display_property): xassert that
744 IT->position is set to within IT->object's boundaries. Break from
745 the loop as soon as EOB is reached; avoids infloops in redisplay
746 when IT->position is set up wrongly due to some bug.
747 Set IT->current to match the bidi iterator unconditionally.
748 (push_display_prop): Allow GET_FROM_STRING as IT->method on
749 entry. Force push_it to save on the stack the current
750 buffer/string position, to be restored by pop_it. Fix flags in
751 the iterator structure wrt the object coming from a display
752 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
753 properties. (Bug#9284)
754
755 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
756
757 * fontset.c (fontset_get_font_group): Add proper type checks.
758 (Bug#9172)
759
760 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
761
762 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
763 and LC_VERSION_MIN_MACOSX.
764 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
765 (dump_it) [LC_FUNCTION_STARTS]: Use it.
766
767 2011-08-08 Eli Zaretskii <eliz@gnu.org>
768
769 * xdisp.c (forward_to_next_line_start): Allow to use the
770 no-display-properties-and-no-overlays under bidi display.
771 Set disp_pos in the bidi iterator to avoid searches for display
772 properties and overlays.
773
774 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
775
776 * editfns.c (Fset_time_zone_rule): Document relationship with the
777 setenv function.
778
779 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
780 the font entity extracted from the cache (Bug#8109).
781
782 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
783
784 * composite.c (autocmp_chars): Don't reset point. That is done by
785 restore_point_unwind (Bug#5984).
786
787 2011-08-07 Juri Linkov <juri@jurta.org>
788
789 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
790 to show the arg `TIME' instead of `TIMEVAL'.
791
792 2011-08-06 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
795 display property strides EOL and includes a newline, as in
796 longlines-mode. (Bug#9254)
797 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
798 word-wrap under bidirectional display. (Bug#9224)
799
800 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
801 is non-zero, even if the data buffer is NULL. Fixes a crash in
802 vertical-motion with longlines-mode. (Bug#9254)
803
804 2011-08-05 Eli Zaretskii <eliz@gnu.org>
805
806 * bidi.c <bidi_cache_total_alloc>: Now static.
807 (bidi_initialize): Initialize bidi_cache_total_alloc.
808
809 * xdisp.c (display_line): Release buffer allocated for shelved bidi
810 cache. (Bug#9221)
811
812 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
813 amount allocated this far in `bidi_cache_total_alloc'.
814 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
815 non-zero, only free the data buffer without restoring the cache
816 contents. All callers changed.
817
818 * dispextern.h (bidi_unshelve_cache): Update prototype.
819
820 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
821 (move_it_in_display_line, move_it_to)
822 (move_it_vertically_backward, move_it_by_lines): Replace the call
823 to xfree to an equivalent call to bidi_unshelve_cache.
824 (move_it_in_display_line_to): Fix logic of returning
825 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
826
827 2011-08-05 Eli Zaretskii <eliz@gnu.org>
828
829 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
830 came from a string character with a `cursor' property. (Bug#9229)
831
832 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
833
834 * Makefile.in (LIB_PTHREAD): New variable.
835 (LIBES): Add LIB_PTHREAD (Bug#9216).
836
837 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
838 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
839
840 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
841
842 * regex.c (re_iswctype): Remove some redundant boolean
843 conversions.
844
845 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
846
847 * xterm.c (x_find_topmost_parent): New function.
848 (x_set_frame_alpha): Find topmost parent window with
849 x_find_topmost_parent and set the property there also (bug#9181).
850 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
851
852 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
853
854 * callproc.c (Fcall_process): Avoid vfork clobbering
855 the local vars buffer, coding_systems, current_dir.
856
857 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
858
859 * keymap.c (Fmake_composed_keymap): Move to subr.el.
860
861 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
862
863 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
864 so that it is not optimized away.
865
866 * xdisp.c (compute_display_string_pos): Remove unused local.
867
868 2011-08-02 Eli Zaretskii <eliz@gnu.org>
869
870 Fix slow cursor motion and scrolling in large buffers with
871 selective display, like Org Mode buffers. (Bug#9218)
872
873 * dispextern.h (struct bidi_it): New member disp_prop_p.
874
875 * xdisp.c: Remove one-slot cache of display string positions.
876 (compute_display_string_pos): Accept an additional argument
877 DISP_PROP_P; callers changed. Scan at most 5K characters forward
878 for a display string or property. If found, set DISP_PROP_P
879 non-zero.
880
881 * bidi.c (bidi_fetch_char): Accept an additional argument
882 DISP_PROP_P, and pass it to compute_display_string_pos.
883 Only handle text covered by a display string if DISP_PROP_P is returned
884 non-zero. All callers of bidi_fetch_char changed.
885
886 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
887
888 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
889
890 2010-12-03 Don March <don@ohspite.net>
891
892 * keymap.c (Fdefine_key): Fix non-prefix key error message when
893 last character M-[char] is translated to ESC [char] (bug#7541).
894
895 2011-08-02 Kenichi Handa <handa@m17n.org>
896
897 * lisp.h (uniprop_table): Extern it.
898
899 * chartab.c (uniprop_table): Make it non-static.
900
901 2011-08-01 Eli Zaretskii <eliz@gnu.org>
902
903 * xdisp.c (forward_to_next_line_start): Accept additional argument
904 BIDI_IT_PREV, and store into it the state of the bidi iterator had
905 on the newline.
906 (reseat_at_next_visible_line_start): Use the bidi iterator state
907 returned by forward_to_next_line_start to restore the state of
908 it->bidi_it after backing up to previous newline. (Bug#9212)
909
910 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
911
912 * regex.c (re_comp): Protoize.
913 (re_exec): Fix return type.
914 (regexec): Fix type of `ret'. (Bug#9203)
915
916 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
917
918 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
919 This is needed if max-image-size is a floating-point number.
920
921 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
922
923 * print.c (print_object): Print empty symbol as ##.
924
925 * lread.c (read1): Read ## as empty symbol.
926
927 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
928
929 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
930 setting frame foreground color (Bug#9175).
931 (x_set_background_color): Likewise.
932
933 * nsmenu.m (-setText): Size tooltip dimensions precisely to
934 contents (Bug#9176).
935 (EmacsTooltip -init): Remove bezels and add shadows to
936 tooltip windows.
937
938 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
939 or scroll bar (Bug#8470).
940
941 * nsfont.m (nsfont_open): Remove assignment to voffset and
942 unnecessary vars hshink, expand, hd, full_height, min_height.
943 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
944
945 * nsterm.h (nsfont_info): Remove voffset field.
946
947 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
948
949 Implement strike-through and overline on NextStep (Bug#8863).
950
951 * nsfont.m (nsfont_open): Use underline position provided by font,
952 instead of hard-coded value of 2.
953 (nsfont_draw): Call ns_draw_text_decoration instead.
954
955 * nsterm.h: Add declaration for ns_draw_text_decoration.
956
957 * nsterm.m (ns_draw_text_decoration): New function for drawing
958 underline, overline, and strike-through.
959 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
960 ns_draw_text_decoration. Change treatment of cursor drawing to
961 accomodate underlining, etc.
962
963 2011-07-28 Eli Zaretskii <eliz@gnu.org>
964
965 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
966 default.
967
968 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
969
970 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
971 Without this fix, if a signal arrives just after memory fills up,
972 'malloc' might be invoked reentrantly.
973
974 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
975 In other words, assume that every image size is allowed, on non-X
976 hosts. This assumption is probably wrong, but it lets Emacs compile.
977
978 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
979
980 * regex.c (re_iswctype): Convert return values to boolean.
981
982 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
983
984 * xdisp.c (compute_display_string_pos): Don't use cached display
985 string position if the buffer had its restriction changed.
986 (Bug#9184)
987
988 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
989
990 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
991
992 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
993
994 Integer signedness and overflow and related fixes. (Bug#9079)
995
996 * bidi.c: Integer size and overflow fixes.
997 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
998 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
999 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1000 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1001 (bidi_find_other_level_edge):
1002 Use ptrdiff_t instead of EMACS_INT where either will do.
1003 This works better on 32-bit hosts configured --with-wide-int.
1004 (bidi_cache_ensure_space): Check for size-calculation overflow.
1005 Use % rather than repeated addition, for better worst-case speed.
1006 Don't set bidi_cache_size until after xrealloc returns, because it
1007 might not return.
1008 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1009 (bidi_cache_ensure_space): Also check that the bidi cache size
1010 does not exceed that of the largest Lisp string or buffer. See Eli
1011 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1012
1013 * alloc.c (__malloc_size_t): Remove.
1014 All uses replaced by size_t. See Andreas Schwab's note
1015 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1016
1017 * image.c: Improve checking for integer overflow.
1018 (check_image_size): Assume that f is nonnull, since
1019 it is always nonnull in practice. This is one less thing to
1020 worry about when checking for integer overflow later.
1021 (x_check_image_size): New function, which checks for integer
1022 overflow issues inside X.
1023 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1024 This removes the need for a memory_full check.
1025 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1026 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1027 (xbm_read_bitmap_data): Change locals back to 'int', since
1028 their values must fit in 'int'.
1029 (xpm_load_image, png_load, tiff_load):
1030 Invoke x_create_x_image_and_pixmap earlier,
1031 to avoid much needless work if the image is too large.
1032 (tiff_load): Treat overly large images as if
1033 x_create_x_image_and_pixmap failed, not as malloc failures.
1034 (gs_load): Use x_check_image_size.
1035
1036 * gtkutil.c: Omit integer casts.
1037 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1038 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1039
1040 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1041
1042 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1043 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1044 would wrongly return t on a 64-bit host.
1045
1046 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1047 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1048 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1049 and therefore cause GCC to emit a bogus diagnostic in some cases.
1050
1051 * image.c: Integer signedness and overflow and related fixes.
1052 This is not an exhaustive set of fixes, but it's time to
1053 record what I've got.
1054 (lookup_pixel_color, check_image_size): Remove redundant decls.
1055 (check_image_size): Don't assume that arbitrary EMACS_INT values
1056 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1057 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1058 (tiff_load, imagemagick_load_image):
1059 Check for overflow in size calculations.
1060 (x_create_x_image_and_pixmap): Remove unnecessary test for
1061 xmalloc returning NULL; that can't happen.
1062 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1063 (xpm_color_bucket): Use better integer hashing function.
1064 (xpm_cache_color): Don't possibly over-allocate memory.
1065 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1066 (gif_memory_source):
1067 Use ptrdiff_t, not int or size_t, to record sizes.
1068 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1069 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1070 either works, as we prefer signed integers.
1071 (tiff_read_from_memory, tiff_write_from_memory):
1072 Return tsize_t, not size_t, since that's what the TIFF API wants.
1073 (tiff_read_from_memory): Don't fail simply because the read would
1074 go past EOF; instead, return a short read.
1075 (tiff_load): Omit no-longer-needed casts.
1076 (Fimagemagick_types): Don't assume size fits into 'int'.
1077
1078 Improve hashing quality when configured --with-wide-int.
1079 * fns.c (hash_string): New function, taken from sxhash_string.
1080 Do not discard information about ASCII character case; this
1081 discarding is no longer needed.
1082 (sxhash-string): Use it. Change sig to match it. Caller changed.
1083 * lisp.h: Declare it.
1084 * lread.c (hash_string): Remove, since we now use fns.c's version.
1085 The fns.c version returns a wider integer if --with-wide-int is
1086 specified, so this should help the quality of the hashing a bit.
1087
1088 * emacs.c: Integer overflow minor fix.
1089 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1090 Define only if GNU_LINUX.
1091 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1092
1093 * dispnew.c: Integer signedness and overflow fixes.
1094 Remove unnecessary forward decls, that were a maintenance hassle.
1095 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1096 All uses changed.
1097 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1098 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1099 (prepare_desired_row, line_draw_cost):
1100 Use int, not unsigned, where either works.
1101 (save_current_matrix, restore_current_matrix):
1102 Use ptrdiff_t, not size_t, where either works.
1103 (init_display): Check for overflow more accurately, and without
1104 relying on undefined behavior.
1105
1106 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1107 Remove, replacing with the new symbols in lisp.h. All uses changed.
1108 * fileio.c (make_temp_name):
1109 * filelock.c (lock_file_1, lock_file):
1110 * xdisp.c (message_dolog):
1111 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1112 Use pMd etc. instead.
1113 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1114 replacing the pWIDE etc. symbols removed from editfns.c.
1115
1116 * keyboard.h (num_input_events): Now uintmax_t.
1117 This is (very slightly) less likely to mess up due to wraparound.
1118 All uses changed.
1119
1120 * buffer.c: Integer signedness fixes.
1121 (alloc_buffer_text, enlarge_buffer_text):
1122 Use ptrdiff_t rather than size_t when either will do, as we prefer
1123 signed integers.
1124
1125 * alloc.c: Integer signedness and overflow fixes.
1126 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1127 (__malloc_size_t): Default to size_t, not to int.
1128 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1129 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1130 Prefer ptrdiff_t to size_t when either would do, as we prefer
1131 signed integers.
1132 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1133 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1134 Now const. Initialize with values that are in range even if char
1135 is signed.
1136 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1137 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1138 These functions do the right thing with sizes > 2**32.
1139 (check_depth): Now ptrdiff_t, not int.
1140 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1141 Adjust to new way of storing sizes. Check for size overflow bugs
1142 in rest of code.
1143 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1144 slightly wrong anyway, as it missed one instance of
1145 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1146 (refill_memory_reserve): Omit needless cast to size_t.
1147 (mark_object_loop_halt): Mark as externally visible.
1148
1149 * xselect.c: Integer signedness and overflow fixes.
1150 (Fx_register_dnd_atom, x_handle_dnd_message):
1151 Use ptrdiff_t, not size_t, since we prefer signed.
1152 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1153 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1154 x_dnd_atoms_size and x_dnd_atoms_length.
1155
1156 * doprnt.c: Prefer signed to unsigned when either works.
1157 * eval.c (verror):
1158 * doprnt.c (doprnt):
1159 * lisp.h (doprnt):
1160 * xdisp.c (vmessage):
1161 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1162 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1163 prefer signed arithmetic to avoid comparison confusion.
1164 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1165 but is a bit tricky.
1166
1167 Assume freestanding C89 headers, string.h, stdlib.h.
1168 * data.c, doprnt.c, floatfns.c, print.c:
1169 Include float.h unconditionally.
1170 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1171 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1172 * regex.c: Likewise for stddef.h, string.h.
1173 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1174 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1175 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1176 (STDC_HEADERS): Remove obsolete defines.
1177 * sysdep.c: Include limits.h unconditionally.
1178
1179 Assume support for memcmp, memcpy, memmove, memset.
1180 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1181 * regex.c (memcmp, memcpy):
1182 Remove; we assume C89 now.
1183
1184 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1185 (__malloc_safe_bcopy): Remove; no longer needed.
1186
1187 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1188 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1189 well either way, and we prefer signed to unsigned.
1190
1191 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1192
1193 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1194 closes the connection while we're reading (bug#9182).
1195
1196 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1197
1198 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1199 are specified (Bug#9168).
1200
1201 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1202
1203 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1204 Found by GCC static checking and --with-wide-int on a 32-bit host.
1205
1206 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1207
1208 * xdisp.c (compute_display_string_pos): Fix logic of caching
1209 previous display string position. Initialize cached_prev_pos to
1210 -1. Fixes slow-down at the beginning of a buffer.
1211
1212 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1213
1214 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1215 for attrs[LFACE_FONTSET_INDEX].
1216
1217 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 * xml.c (parse_region): Remove unused local
1220 that was recently introduced.
1221
1222 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1223
1224 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1225 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1226
1227 * xdisp.c (move_it_in_display_line_to): Record the best matching
1228 position for TO_CHARPOS while scanning the line, and restore it on
1229 exit if none of the characters scanned was an exact match.
1230 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1231 when exact match is impossible due to invisible text, and the
1232 lines are truncated.
1233
1234 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1235
1236 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1237 for OSX >= 10.7.
1238
1239 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1240
1241 Fix a significant slow-down of cursor motion with C-n, C-p,
1242 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1243 auto-repeat under bidi redisplay in fontified buffers.
1244 * xdisp.c (compute_stop_pos_backwards): New function.
1245 (next_element_from_buffer): Call compute_stop_pos_backwards to
1246 find a suitable prev_stop when we find ourselves before
1247 base_level_stop.
1248 (reseat): Don't look for prev_stop, as that could mean a very long
1249 run.
1250 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1251 <cached_disp_overlay_modiff>: Cache for last found display string
1252 position.
1253 (compute_display_string_pos): Return the cached position if asked
1254 about the same buffer in the same area of character positions, and
1255 the buffer wasn't changed since the time the display string
1256 position was cached.
1257
1258 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1259
1260 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1261 is an integer, which is important for empty lines. (Bug#9149)
1262
1263 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1264
1265 * frame.c (Fmodify_frame_parameters): In tty case, update the
1266 default face if necessary (Bug#4238).
1267
1268 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1269
1270 * editfns.c (Fstring_to_char): No need to explain what a character
1271 is in the docstring (Bug#6576).
1272
1273 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1274
1275 * xml.c (parse_region): Make sure we always return a tree.
1276
1277 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1278
1279 * xml.c (parse_region): If a document contains only comments,
1280 return that, too.
1281
1282 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1283
1284 * xml.c (make_dom): Return comments, too.
1285
1286 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 Port to OpenBSD.
1289 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1290 and the surrounding thread.
1291 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1292 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1293 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1294 timer goes off.
1295 * s/openbsd.h (BROKEN_SIGIO): Define.
1296 * unexelf.c (unexec) [__OpenBSD__]:
1297 Don't update the .mdebug section of the Alpha COFF symbol table.
1298
1299 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1300
1301 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1302 (bug#8460).
1303
1304 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1307 This fixes some race conditions on the permissions of any newly
1308 created file.
1309
1310 * alloc.c (valid_pointer_p): Use pipe, not open.
1311 This fixes some permissions issues when debugging.
1312
1313 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1314 If fchown fails to set both uid and gid, try to set just gid,
1315 as that is sometimes allowed. Adjust the file's mode to eliminate
1316 setuid or setgid bits that are inappropriate if fchown fails.
1317
1318 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1319
1320 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1321 to compare Lisp_Objects.
1322 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1323 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1324 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1325
1326 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1327
1328 * lread.c (read_integer): Unread even EOF character.
1329 (read1): Likewise. Properly record start position of symbol.
1330
1331 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1332 symbol character follows.
1333
1334 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1337 This works around a problem with the previous change to Fcopy_file.
1338 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1339 and without this change, GCC might complain about discarding
1340 fchown's return value.
1341
1342 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1343
1344 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1345
1346 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1349
1350 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1351
1352 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1353 it's used from the C level.
1354
1355 * process.c: Use the same condition for POLL_FOR_INPUT in both
1356 keyboard.c and process.c (bug#1858).
1357
1358 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1359
1360 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1361 (Fgnutls_boot): Use it.
1362
1363 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1364
1365 * doc.c (Fsubstitute_command_keys): Revert last change.
1366
1367 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1368
1369 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1370 quotes the next character, and doesn't affect other longer
1371 sequences (bug#8935).
1372
1373 * lread.c (syms_of_lread): Clarify that is isn't only
1374 `eval-buffer' and `eval-defun' that's affected by
1375 `lexical-binding' (bug#8460).
1376
1377 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1378
1379 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1380 bidi redisplay when a line includes both an image and is
1381 truncated.
1382
1383 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1384
1385 Fix minor problems found by static checking.
1386 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1387 (elsz): Now a signed constant, not a size_t var. We prefer signed
1388 types to unsigned, to avoid integer comparison confusion. Without
1389 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1390 "cannot optimize loop, the loop counter may overflow", a symptom
1391 of the confusion.
1392 * indent.c (Fvertical_motion): Mark locals as initialized.
1393 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1394
1395 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1396
1397 * search.c (Fre_search_backward): Mention `case-fold-search' in
1398 all the re_search_* functions (bug#8138).
1399
1400 * keyboard.c (Fopen_dribble_file): Document when the file is
1401 closed (bug#8056).
1402
1403 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1404
1405 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1406 bidi_cache_idx.
1407
1408 Support bidi reordering of display and overlay strings.
1409 * xdisp.c (compute_display_string_pos)
1410 (compute_display_string_end): Accept additional argument STRING.
1411 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1412 (reseat_to_string): Initialize bidi_it->string.s and
1413 bidi_it->string.schars.
1414 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1415 NULL (avoids a crash in bidi_paragraph_init).
1416 Initialize itb.string.lstring.
1417 (init_iterator): Call bidi_init_it only of a valid
1418 buffer position was specified. Initialize paragraph_embedding to
1419 L2R.
1420 (reseat_to_string): Initialize the bidi iterator.
1421 (display_string): If we need to ignore text properties of
1422 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1423 original value of -1 will not work with bidi.)
1424 (compute_display_string_pos): First arg is now struct
1425 `text_pos *'; all callers changed. Support display properties on
1426 Lisp strings.
1427 (compute_display_string_end): Support display properties on Lisp
1428 strings.
1429 (init_iterator, reseat_1, reseat_to_string): Initialize the
1430 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1431 when iterating on a string not from display properties).
1432 (compute_display_string_pos, compute_display_string_end):
1433 Fix calculation of the object to scan. Fixes an error when using
1434 arrow keys.
1435 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1436 base_level_stop; instead, set base_level_stop to BEGV.
1437 Fixes crashes in vertical-motion.
1438 (next_element_from_buffer): Improve commentary for when
1439 the iterator is before prev_stop.
1440 (init_iterator): Initialize bidi_p from the default value of
1441 bidi-display-reordering, not from buffer-local value. Use the
1442 buffer-local value only if initializing for buffer iteration.
1443 (handle_invisible_prop): Support invisible properties on strings
1444 that are being bidi-reordered.
1445 (set_iterator_to_next): Support bidi reordering of C strings and
1446 Lisp strings.
1447 (next_element_from_string): Support bidi reordering of Lisp
1448 strings.
1449 (handle_stop_backwards): Support Lisp strings as well.
1450 (display_string): Support display of R2L glyph rows.
1451 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1452 (init_iterator): Don't initialize it->bidi_p for strings
1453 here.
1454 (reseat_to_string): Initialize it->bidi_p for strings here.
1455 (next_element_from_string, next_element_from_c_string)
1456 (next_element_from_buffer): Add xassert's for correspondence
1457 between IT's object being iterated and it->bidi_it.string
1458 structure.
1459 (face_before_or_after_it_pos): Support bidi iteration.
1460 (next_element_from_c_string): Handle the case of the first string
1461 character that is not the first one in the visual order.
1462 (get_visually_first_element): New function, refactored from common
1463 parts of next_element_from_buffer, next_element_from_string, and
1464 next_element_from_c_string.
1465 (tool_bar_lines_needed, redisplay_tool_bar)
1466 (display_menu_bar): Force left-to-right direction. Add a FIXME
1467 comment for making that be controlled by a user option.
1468 (push_it, pop_it): Save and restore the state of the
1469 bidi iterator. Save and restore the bidi_p flag.
1470 (pop_it): Iterate out of display property for string iteration as
1471 well.
1472 (iterate_out_of_display_property): Support iteration over strings.
1473 (handle_single_display_spec): Set up it->bidi_it for iteration
1474 over a display string, and call bidi_init_it.
1475 (handle_single_display_spec, next_overlay_string)
1476 (get_overlay_strings_1, push_display_prop): Set up the bidi
1477 iterator for displaying display or overlay strings.
1478 (forward_to_next_line_start): Don't use the shortcut if
1479 bidi-iterating.
1480 (back_to_previous_visible_line_start): If handle_display_prop
1481 pushed the iterator stack, restore the internal state of the bidi
1482 iterator by calling bidi_pop_it same number of times.
1483 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1484 and we are bidi-iterating, don't decrement the iterator position;
1485 instead, set the first_elt flag in the bidi iterator, to produce
1486 the same effect.
1487 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1488 (push_display_prop): xassert that we are iterating a buffer.
1489 (push_it, pop_it): Save and restore paragraph_embedding member.
1490 (handle_single_display_spec, next_overlay_string)
1491 (get_overlay_strings_1, reseat_1, reseat_to_string)
1492 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1493 correctly. Don't assume unibyte strings are not bidi-reordered.
1494 (compute_display_string_pos)
1495 (compute_display_string_end): Fix handling the case of C string.
1496 (push_it, pop_it): Save and restore from_disp_prop_p.
1497 (handle_single_display_spec, push_display_prop): Set the
1498 from_disp_prop_p flag.
1499 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1500 (pop_it): Call iterate_out_of_display_property only if we are
1501 popping after iteration over a string that came from a display
1502 property. Fix a typo in popping stretch info. Add an assertion
1503 for verifying that the iterator position is in sync with the bidi
1504 iterator.
1505 (handle_single_display_spec, get_overlay_strings_1)
1506 (push_display_prop): Fix initialization of paragraph direction for
1507 string when that of the parent object is not yet determined.
1508 (reseat_1): Call bidi_init_it to resync the bidi
1509 iterator with IT's position. (Bug#7616)
1510 (find_row_edges): If ROW->start.pos gives position
1511 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1512 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1513 Reset the from_disp_prop_p flag.
1514 (SAVE_IT, RESTORE_IT): New macros.
1515 (pos_visible_p, face_before_or_after_it_pos)
1516 (back_to_previous_visible_line_start)
1517 (move_it_in_display_line_to, move_it_in_display_line)
1518 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1519 (try_scrolling, redisplay_window, display_line): Use them when
1520 saving a temporary copy of the iterator and restoring it back.
1521 (back_to_previous_visible_line_start, reseat_1)
1522 (init_iterator): Empty the bidi cache "stack".
1523 (move_it_in_display_line_to): If iterator ended up at
1524 EOL, but we never saw any buffer positions smaller than
1525 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1526 motion in bidi-reordered lines.
1527 (move_it_in_display_line_to): Record prev_method and prev_pos
1528 immediately before the call to set_iterator_to_next. Fixes cursor
1529 motion in bidi-reordered lines with stretch glyphs and strings
1530 displayed in margins. (Bug#8133) (Bug#8867)
1531 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1532 TO_CHARPOS.
1533 (pos_visible_p): Support positions in bidi-reordered lines.
1534 Save and restore bidi cache.
1535
1536 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1537 (bidi_paragraph_info): Delete unused struct.
1538 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1539 (bidi_cache_start): New variable.
1540 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1541 to zero.
1542 (bidi_cache_fetch_state, bidi_cache_search)
1543 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1544 (bidi_cache_find, bidi_peek_at_next_level)
1545 (bidi_level_of_next_char, bidi_find_other_level_edge)
1546 (bidi_move_to_visually_next): Compare cache index with
1547 bidi_cache_start rather than with zero.
1548 (bidi_fetch_char): Accept new argument STRING; all callers
1549 changed. Support iteration over a string. Support strings with
1550 display properties. Support unibyte strings. Fix the type of
1551 `len' according to what STRING_CHAR_AND_LENGTH expects.
1552 (bidi_paragraph_init, bidi_resolve_explicit_1)
1553 (bidi_resolve_explicit, bidi_resolve_weak)
1554 (bidi_level_of_next_char, bidi_move_to_visually_next):
1555 Support iteration over a string.
1556 (bidi_set_sor_type, bidi_resolve_explicit_1)
1557 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1558 can now be zero (for strings); special values 0 and -1 were
1559 changed to -1 and -2, respectively.
1560 (bidi_char_at_pos): New function.
1561 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1562 Call it instead of FETCH_MULTIBYTE_CHAR.
1563 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1564 initialized to valid values.
1565 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1566 values.
1567 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1568 the test for valid cached positions. Fix the logic for looking up
1569 the sentinel state in the cache. GCPRO the Lisp string we are
1570 iterating.
1571 (bidi_push_it, bidi_pop_it): New functions.
1572 (bidi_initialize): Initialize the bidi cache start stack pointer.
1573 (bidi_cache_ensure_space): New function, refactored from part of
1574 bidi_cache_iterator_state. Don't assume the required size is just
1575 one BIDI_CACHE_CHUNK away.
1576 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1577 (bidi_count_bytes, bidi_char_at_pos): New functions.
1578 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1579 always valid if bidi_cache_idx is valid.
1580 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1581 is valid if it's going to be used.
1582 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1583 (bidi_cache_fetch_state, bidi_cache_search)
1584 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1585 (bidi_cache_iterator_state, bidi_cache_find)
1586 (bidi_find_other_level_edge, bidi_cache_start_stack):
1587 All variables related to cache indices are now EMACS_INT.
1588
1589 * dispextern.h (struct bidi_string_data): New structure.
1590 (struct bidi_it): New member `string'. Make flag members be 1-bit
1591 fields, and put them last in the struct.
1592 (compute_display_string_pos, compute_display_string_end):
1593 Update prototypes.
1594 (bidi_push_it, bidi_pop_it): Add prototypes.
1595 (struct iterator_stack_entry): New members bidi_p,
1596 paragraph_embedding, and from_disp_prop_p.
1597 (struct it): Member bidi_p is now a bit field 1 bit wide.
1598 (bidi_shelve_cache, bidi_unshelve_cache):
1599 Declare prototypes.
1600
1601 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1602 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1603 and vector-like objects.
1604
1605 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1606 cache around display iteration.
1607
1608 * window.c (Fwindow_end, window_scroll_pixel_based)
1609 (displayed_window_lines, Frecenter): Save and restore the bidi
1610 cache around display iteration.
1611
1612 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1613
1614 * editfns.c (Fdelete_region): Clarify the use of the named
1615 parameters (bug#6788).
1616
1617 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1618
1619 * indent.c (Fvertical_motion): Set and restore w->pointm when
1620 saving and restoring the window's buffer (Bug#9006).
1621
1622 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1623
1624 * editfns.c (Fstring_to_char): Clarify just what is returned
1625 (bug#6576). Text by Eli Zaretskii.
1626
1627 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1628
1629 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1630
1631 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1632
1633 * buffer.c (mmap_find): Fix a typo.
1634
1635 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1636
1637 Fix execution of x selection hooks.
1638 * xselect.c (Qx_lost_selection_functions)
1639 (Qx_sent_selection_functions): New vars.
1640 (syms_of_xselect): DEFSYM them.
1641 (x_handle_selection_request): Pass Qx_sent_selection_functions
1642 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1643 (x_handle_selection_clear,x_clear_frame_selections):
1644 Pass Qx_lost_selection_functions rather than
1645 Vx_lost_selection_functions to Frun_hook_with_args.
1646
1647 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1648
1649 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1650 The old code sometimes used this field without initializing it.
1651
1652 * alloc.c (gc_sweep): Don't read past end of array.
1653 In theory, the old code could also have corrupted Emacs internals,
1654 though it'd be very unlikely.
1655
1656 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1657
1658 * character.c (Fcharacterp): Don't advertise optional ignored
1659 argument. (Bug#4026)
1660
1661 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1662
1663 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1664 key" (bug#4257).
1665
1666 * window.c (Fset_window_start): Doc fix (bug#4199).
1667 (Fset_window_hscroll): Ditto.
1668
1669 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1670
1671 Fix minor new problems caught by GCC 4.6.1.
1672 * term.c (init_tty): Remove unused local.
1673 * xsettings.c (store_monospaced_changed): Define this function only
1674 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1675 not used otherwise.
1676
1677 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1678
1679 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1680
1681 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1682
1683 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1684 are the mini-buffer and the echo area (bug#3320).
1685
1686 * term.c (init_tty): Remove support for supdup, c10 and perq
1687 terminals, which are no longer supported (bug#1482).
1688
1689 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1690
1691 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1692
1693 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1694
1695 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1696 for non-popups (Bug#3642).
1697
1698 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1699
1700 * alloc.c (reset_malloc_hooks): Protoize.
1701 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1702 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1703 * cm.c (losecursor): Likewise.
1704 * data.c (fmod): Likewise.
1705 * dispnew.c (swap_glyphs_in_rows): Likewise.
1706 * emacs.c (memory_warning_signal): Likewise.
1707 * floatfns.c (float_error): Likewise.
1708 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1709 (otf_open, font_otf_capability, generate_otf_features)
1710 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1711 Likewise.
1712 * image.c (pbm_read_file): Likewise.
1713 * indent.c (string_display_width): Likewise.
1714 * intervals.c (check_for_interval, search_for_interval)
1715 (inc_interval_count, count_intervals, root_interval)
1716 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1717 * lread.c (defalias): Likewise.
1718 * ralloc.c (r_alloc_check): Likewise.
1719 * regex.c (set_image_of_range_1, set_image_of_range)
1720 (regex_grow_registers): Likewise.
1721 * sysdep.c (strerror): Likewise.
1722 * termcap.c (valid_filename_p, tprint, main): Likewise.
1723 * tparam.c (main): Likewise.
1724 * unexhp9k800.c (run_time_remap, save_data_space)
1725 (update_file_ptrs, read_header, write_header, calculate_checksum)
1726 (copy_file, copy_rest, display_header): Likewise.
1727 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1728 Likewise.
1729 * xdisp.c (check_it): Likewise.
1730 * xfaces.c (register_color, unregister_color, unregister_colors):
1731 Likewise.
1732 * xfns.c (print_fontset_result): Likewise.
1733 * xrdb.c (member, fatal, main): Likewise.
1734
1735 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 Fix minor problems found by static checking (Bug#9031).
1738 * chartab.c (char_table_set_range, map_sub_char_table):
1739 Remove unused locals.
1740 (uniprop_table): Now static.
1741 * composite.c (_work_char): Remove unused static var.
1742
1743 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1744
1745 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1746
1747 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1748
1749 * gtkutil.c (qttip_cb): Remove code without function.
1750
1751 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1752
1753 * w32.c (pthread_sigmask): New stub.
1754
1755 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1756
1757 Use pthread_sigmask, not sigprocmask (Bug#9010).
1758 sigprocmask is portable only for single-threaded applications, and
1759 Emacs can be multi-threaded when it uses GTK.
1760 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1761 (LIBES): Use it.
1762 * callproc.c (Fcall_process):
1763 * process.c (create_process):
1764 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1765 Use pthread_sigmask, not sigprocmask.
1766
1767 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1768
1769 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1770 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1771 wrong (Bug#8591).
1772
1773 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1774
1775 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1776 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1777 (xg_hide_tooltip): Fix comment.
1778
1779 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1780 in registerServicesMenuSendTypes.
1781 (validRequestorForSendType): Don't check ns_return_types.
1782
1783 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1784 ns_return_type.
1785
1786 2011-07-08 Jason Rumney <jasonr@gnu.org>
1787
1788 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1789 frame struct members of non-existent frames (Bug#6284).
1790
1791 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1792
1793 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1794 variable firstTime not needed on OSX >= 10.6.
1795 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1796 >= 10.5. Use setKnobProportion, setDoubleValue.
1797
1798 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1799 (MAC_OS_X_VERSION_10_5): Define if not defined.
1800 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1801 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1802 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1803
1804 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1805 cString and lossyCString on OSX >= 10.4
1806
1807 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1808 sizeToFit on OSX >= 10.2.
1809
1810 * nsimage.m (allocInitFromFile): Don't use deprecated method
1811 bestRepresentationForDevice on OSX >= 10.6.
1812
1813 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1814 to avoid warning.
1815
1816 * emacs.c: Declare unexec_init_emacs_zone.
1817
1818 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1819
1820 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1821
1822 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1823 on svcsMenu (Bug#8842).
1824
1825 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1826 ns_return_types.
1827 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1828
1829 * nsterm.m (QUTF8_STRING): Declare.
1830 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1831 (validRequestorForSendType): Return type is (id).
1832 Change indexOfObjectIdenticalTo to indexOfObject.
1833 Check if we have local selection before returning self (Bug#8842).
1834 (writeSelectionToPasteboard): Put local selection into paste board
1835 if we have a local selection (Bug#8842).
1836 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1837
1838 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1839 (ns_get_local_selection): Declare.
1840
1841 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1842
1843 * keymap.c (describe_map_tree): Don't insert a double newline at
1844 the end of the buffer (bug#1169) and return whether we inserted
1845 something.
1846
1847 * callint.c (Fcall_interactively): Change "reading args" to
1848 "providing args" to try to clarify what it does (bug#1010).
1849
1850 2011-07-07 Kenichi Handa <handa@m17n.org>
1851
1852 * composite.c (composition_compute_stop_pos): Ignore a static
1853 composition starting before CHARPOS (Bug#8915).
1854
1855 * xdisp.c (handle_composition_prop): Likewise.
1856
1857 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1858
1859 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1860 (Bug#9015)
1861
1862 2011-07-07 Kenichi Handa <handa@m17n.org>
1863
1864 * character.h (unicode_category_t): New enum type.
1865
1866 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1867 (Qchar_code_property_table): New variable.
1868 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1869 (UNIPROP_COMPRESSED_FORM_P): New macros.
1870 (char_table_ascii): Uncompress the compressed values.
1871 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1872 Uncompress the compressed values.
1873 (sub_char_table_ref_and_range): Likewise.
1874 (char_table_ref_and_range): Uncompress the compressed values.
1875 (sub_char_table_set): New arg is_uniprop. Callers changed.
1876 Uncompress the compressed values.
1877 (sub_char_table_set_range): Args changed. Callers changed.
1878 (char_table_set_range): Adjuted for the above change.
1879 (map_sub_char_table): Delete args default_val and parent. Add arg
1880 top. Give decoded values to a Lisp function.
1881 (map_char_table): Adjust for the above change. Give decoded
1882 values to a Lisp function. Gcpro more variables.
1883 (uniprop_table_uncompress)
1884 (uniprop_decode_value_run_length): New functions.
1885 (uniprop_decoder, uniprop_decoder_count): New variables.
1886 (uniprop_get_decoder, uniprop_encode_value_character)
1887 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1888 New functions.
1889 (uniprop_encoder, uniprop_encoder_count): New variables.
1890 (uniprop_get_encoder, uniprop_table)
1891 (Funicode_property_table_internal, Fget_unicode_property_internal)
1892 (Fput_unicode_property_internal): New functions.
1893 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1894 Sunicode_property_table_internal, Sget_unicode_property_internal,
1895 and Sput_unicode_property_internal. Defvar_lisp
1896 char-code-property-alist.
1897
1898 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1899 Vunicode_category_table.
1900
1901 * font.c (font_range): Adjust for the change of
1902 Vunicode_category_table.
1903
1904 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1905
1906 * m/iris4d.h: Remove file, move contents ...
1907 * s/irix6-5.h: ... here.
1908
1909 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 Remove unportable assumption about struct layout (Bug#8884).
1912 * alloc.c (mark_buffer):
1913 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1914 (clone_per_buffer_values): Don't assume that
1915 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1916 This isn't true in general, and it's particularly not true
1917 if Emacs is configured with --with-wide-int.
1918 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1919 New macros, used in the buffer.c change.
1920
1921 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1922
1923 * xsettings.c: Use both GConf and GSettings if both are available.
1924 (store_config_changed_event): Add comment.
1925 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1926 (store_tool_bar_style_changed): New functions.
1927 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1928 (struct xsettings): Move font inside HAVE_XFT.
1929 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1930 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1931 Move inside HAVE_XFT.
1932 (something_changed_gsettingsCB): Rename from something_changedCB.
1933 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1934 also.
1935 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1936 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1937 (something_changed_gconfCB): Rename from something_changedCB.
1938 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1939 (parse_settings): Move check for font inside HAVE_XFT.
1940 (read_settings, apply_xft_settings): Add comment.
1941 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1942 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1943 call store_font_name_changed.
1944 (xft_settings_event): Add comment.
1945 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1946 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1947 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1948 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1949 (xsettings_initialize): Call init_gsettings last.
1950 (xsettings_get_system_font, xsettings_get_system_normal_font):
1951 Add comment.
1952
1953 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1954
1955 Random fixes. E.g., (random) never returned negative values.
1956 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1957 subseconds part to the entropy, as that's a bit more random.
1958 Prefer signed to unsigned, since the signedness doesn't matter and
1959 in general we prefer signed. When given a limit, use a
1960 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1961 latter isn't right if USE_2_TAGS_FOR_INTS.
1962 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1963 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1964
1965 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1966
1967 * textprop.c (text_property_stickiness):
1968 Obey Vtext_property_default_nonsticky.
1969 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1970 * w32fns.c (syms_of_w32fns):
1971 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1972
1973 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1974
1975 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1976 This is more efficient than Ffile_directory_p and avoids a minor race.
1977
1978 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1979
1980 * buffer.c (Foverlay_put): Say what the return value is
1981 (bug#7835).
1982
1983 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1984 is a directory before asking whether to use the file name
1985 (bug#7564).
1986 (barf_or_query_if_file_exists): Make the "File is a directory"
1987 error be more correct.
1988
1989 * fns.c (Frequire): Remove the mention of the .gz files, since
1990 that's installation-specific, but keep the mention of
1991 `get-load-suffixes'.
1992
1993 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1996 Report string overflow if the output is too long.
1997
1998 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1999
2000 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2001 (syms_of_gnutls): Remove duplicate DEFSYM for
2002 Qgnutls_bootprop_verify_hostname_error, an error for
2003 Qgnutls_bootprop_verify_error (which is no longer used).
2004
2005 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2006 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2007 Also (re)move comments that are misplaced or no longer relevant.
2008
2009 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2010
2011 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2012
2013 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2014
2015 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2016 and background color parameters if they have been changed.
2017
2018 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2019
2020 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2021
2022 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 * xsettings.c (SYSTEM_FONT): Define only when used.
2025 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2026
2027 * keymap.c (access_keymap_1): Now static.
2028
2029 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2030
2031 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2032 leave any prefix arg for the up event (Bug#1586).
2033
2034 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2035
2036 * lread.c (syms_of_lread): Mention single symbols defined by
2037 `defvar' or `defconst' (bug#7154).
2038
2039 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2040 (Frequire): Mention get-load-suffixes.
2041
2042 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2043
2044 * window.h (window): Remove clone_number slot.
2045 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2046 Remove.
2047 (make_parent_window, make_window, saved_window)
2048 (Fset_window_configuration, save_window_save): Don't deal with
2049 clone numbers.
2050 * buffer.c (Qclone_number): Remove declaration.
2051 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2052
2053 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2054
2055 Add multiple inheritance to keymaps.
2056 * keymap.c (Fmake_composed_keymap): New function.
2057 (Fset_keymap_parent): Simplify.
2058 (fix_submap_inheritance): Remove.
2059 (access_keymap_1): New function extracted from access_keymap to handle
2060 embedded parents and handle lists of maps.
2061 (access_keymap): Use it.
2062 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2063 (Fcopy_keymap): Handle embedded parents.
2064 (Fcommand_remapping, define_as_prefix): Simplify.
2065 (Fkey_binding): Simplify.
2066 (syms_of_keymap): Move minibuffer-local-completion-map,
2067 minibuffer-local-filename-completion-map,
2068 minibuffer-local-must-match-map, and
2069 minibuffer-local-filename-must-match-map to Elisp.
2070 (syms_of_keymap): Defsubr make-composed-keymap.
2071 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2072 (parse_menu_item): Trivial simplification.
2073
2074 2011-07-01 Glenn Morris <rgm@gnu.org>
2075
2076 * Makefile.in (SETTINGS_LIBS): Fix typo.
2077
2078 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2079
2080 * coding.c (Fencode_coding_string): Record the last coding system
2081 used, as the function doc string says (bug#8738).
2082
2083 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2084
2085 * xsettings.c (store_monospaced_changed): Take new font as arg and
2086 check for change against current_mono_font.
2087 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2088 (emacs_settings_constructor, emacs_settings_get_property)
2089 (emacs_settings_set_property, emacs_settings_class_init)
2090 (emacs_settings_init, gsettings_obj): Remove.
2091 (something_changedCB): New function for HAVE_GSETTINGS.
2092 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2093 with value as argument.
2094 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2095 g_settings_new (Bug#8967). Do not create gsettings_obj.
2096 Remove calls to g_settings_bind. Connect something_changedCB to
2097 "changed".
2098
2099 * xgselect.c: Add defined (HAVE_GSETTINGS).
2100 (xgselect_initialize): Ditto.
2101
2102 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2103 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2104 xg_select.
2105
2106 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2107
2108 * eval.c (struct backtrace): Simplify and port the data structure.
2109 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2110 signed bit field, as this assumption is not portable and it makes
2111 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2112 "char debug_on_exit : 1" as this is not portable either; instead,
2113 use the portable "unsigned int debug_on_exit : 1". Remove unused
2114 member evalargs. Remove obsolete comments about cc bombing out.
2115
2116 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2117
2118 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2119 Let HAVE_GSETTINGS override HAVE_GCONF.
2120 (store_monospaced_changed): New function.
2121 (EMACS_SETTINGS): A new type derived from GObject to handle
2122 GSettings notifications.
2123 (emacs_settings_constructor, emacs_settings_get_property)
2124 (emacs_settings_set_property, emacs_settings_class_init):
2125 New functions.
2126 (gsettings_client, gsettings_obj): New variables.
2127 (GSETTINGS_SCHEMA): New define.
2128 (something_changedCB): Call store_monospaced_changed.
2129 (init_gsettings): New function.
2130 (xsettings_initialize): Call init_gsettings.
2131 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2132 to NULL.
2133
2134 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2135 GCONF_CFLAGS/LIBS.
2136
2137 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2138
2139 * window.c (resize_root_window, grow_mini_window)
2140 (shrink_mini_window): Rename Qresize_root_window to
2141 Qwindow_resize_root_window and Qresize_root_window_vertically to
2142 Qwindow_resize_root_window_vertically.
2143
2144 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2147
2148 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2149
2150 * makefile.w32-in: Redesign dependencies so they reflect more
2151 clearly which files are directly included by each source file,
2152 and not through other includes.
2153
2154 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2155
2156 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2157 (sort_overlays, overlay_strings): When an overlay's clone number
2158 matches the window's clone number process the overlay even if
2159 the overlay's window property doesn't match the current window.
2160
2161 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2162 (Fwindow_hchild): Rename to Fwindow_left_child.
2163 (Fwindow_next): Rename to Fwindow_next_sibling.
2164 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2165 (resize_window_check): Rename to window_resize_check.
2166 (resize_window_apply): Rename to window_resize_apply.
2167 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2168 (Fdelete_other_windows_internal, resize_frame_windows)
2169 (Fsplit_window_internal, Fdelete_window_internal)
2170 (grow_mini_window, shrink_mini_window)
2171 (Fresize_mini_window_internal): Fix callers accordingly.
2172
2173 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2174
2175 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2176 (emacs_fixed_set_min_size): Remove.
2177 (emacs_fixed_new): Take frame as argument.
2178
2179 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2180 (_EmacsFixedPrivate): Remove minwidth/height.
2181 Add struct frame *f.
2182 (emacs_fixed_init): Initialize priv->f.
2183 (get_parent_class, emacs_fixed_set_min_size): Remove.
2184 (emacs_fixed_new): Set priv->f to argument.
2185 (emacs_fixed_get_preferred_width)
2186 (emacs_fixed_get_preferred_height): Use min_width/height from
2187 frames size_hint to set minimum and natural (Bug#8919).
2188 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2189 and use min_width/height from frames size_hint to set
2190 min_width/height (Bug#8919).
2191
2192 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2193 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2194 Fix indentation.
2195
2196 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2197
2198 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2199 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2200 called at ZV.
2201
2202 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2203
2204 * process.c (wait_reading_process_output): Bypass select if
2205 waiting for a cell while ignoring keyboard input, and input is
2206 pending. Suggested by Jan Djärv (Bug#8869).
2207
2208 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 Use gnulib's dup2 module instead of rolling our own.
2211 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2212
2213 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2214
2215 * dispnew.c (scrolling_window): Before scrolling, turn off a
2216 mouse-highlight in the window being scrolled.
2217
2218 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2219
2220 Move DEFSYM to lisp.h and use everywhere.
2221
2222 * character.h (DEFSYM): Move declaration...
2223 * lisp.h (DEFSYM): ...here.
2224
2225 * gnutls.c:
2226 * minibuf.c:
2227 * w32menu.c:
2228 * w32proc.c:
2229 * w32select.c: Don't include character.h.
2230
2231 * alloc.c (syms_of_alloc):
2232 * buffer.c (syms_of_buffer):
2233 * bytecode.c (syms_of_bytecode):
2234 * callint.c (syms_of_callint):
2235 * casefiddle.c (syms_of_casefiddle):
2236 * casetab.c (init_casetab_once):
2237 * category.c (init_category_once, syms_of_category):
2238 * ccl.c (syms_of_ccl):
2239 * cmds.c (syms_of_cmds):
2240 * composite.c (syms_of_composite):
2241 * dbusbind.c (syms_of_dbusbind):
2242 * dired.c (syms_of_dired):
2243 * dispnew.c (syms_of_display):
2244 * doc.c (syms_of_doc):
2245 * editfns.c (syms_of_editfns):
2246 * emacs.c (syms_of_emacs):
2247 * eval.c (syms_of_eval):
2248 * fileio.c (syms_of_fileio):
2249 * fns.c (syms_of_fns):
2250 * frame.c (syms_of_frame):
2251 * fringe.c (syms_of_fringe):
2252 * insdel.c (syms_of_insdel):
2253 * keymap.c (syms_of_keymap):
2254 * lread.c (init_obarray, syms_of_lread):
2255 * macros.c (syms_of_macros):
2256 * msdos.c (syms_of_msdos):
2257 * print.c (syms_of_print):
2258 * process.c (syms_of_process):
2259 * search.c (syms_of_search):
2260 * sound.c (syms_of_sound):
2261 * syntax.c (init_syntax_once, syms_of_syntax):
2262 * terminal.c (syms_of_terminal):
2263 * textprop.c (syms_of_textprop):
2264 * undo.c (syms_of_undo):
2265 * w32.c (globals_of_w32):
2266 * window.c (syms_of_window):
2267 * xdisp.c (syms_of_xdisp):
2268 * xfaces.c (syms_of_xfaces):
2269 * xfns.c (syms_of_xfns):
2270 * xmenu.c (syms_of_xmenu):
2271 * xsettings.c (syms_of_xsettings):
2272 * xterm.c (syms_of_xterm): Use DEFSYM.
2273
2274 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2275
2276 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2277
2278 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 Integer and buffer overflow fixes (Bug#8873).
2281
2282 * print.c (printchar, strout): Check for string overflow.
2283 (PRINTPREPARE, printchar, strout):
2284 Don't set size unless allocation succeeds.
2285
2286 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2287 for sizes. Check for string overflow more accurately.
2288 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2289
2290 * macros.c: Integer and buffer overflow fixes.
2291 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2292 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2293 Use ptrdiff_t, not int, for sizes.
2294 Don't increment bufsize until after realloc succeeds.
2295 Check for size-calculation overflow.
2296 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2297
2298 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2299
2300 * lread.c: Integer overflow fixes.
2301 (read_integer): Radix is now EMACS_INT, not int,
2302 to improve quality of diagnostics for out-of-range radices.
2303 Calculate buffer size correctly for out-of-range radices.
2304 (read1): Check for integer overflow in radices, and in
2305 read-circle numbers.
2306 (read_escape): Avoid int overflow.
2307 (Fload, openp, read_buffer_size, read1)
2308 (substitute_object_recurse, read_vector, read_list, map_obarray):
2309 Use ptrdiff_t, not int, for sizes.
2310 (read1): Use EMACS_INT, not int, for sizes.
2311 Check for size overflow.
2312
2313 * image.c (cache_image): Check for size arithmetic overflow.
2314
2315 * lread.c: Integer overflow issues.
2316 (saved_doc_string_size, saved_doc_string_length)
2317 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2318 Now ptrdiff_t, not int.
2319 (read1): Don't assume doc string length fits in int. Check for
2320 out-of-range doc string lengths.
2321 (read_list): Don't assume file position fits in int.
2322 (read_escape): Check for hex character overflow.
2323
2324 2011-06-22 Leo Liu <sdl.web@gmail.com>
2325
2326 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2327 Move to minibuffer.el.
2328
2329 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2332 The following patches are for when GLYPH_DEBUG && !XASSERT.
2333 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2334 * dispnew.c (flush_stdout):
2335 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2336 Mark as externally visible.
2337 * dispnew.c (check_window_matrix_pointers): Now static.
2338 * dispnew.c (window_to_frame_vpos):
2339 * xfns.c (unwind_create_frame):
2340 * xterm.c (x_check_font): Remove unused local.
2341 * scroll.c (CHECK_BOUNDS):
2342 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2343 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2344 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2345 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2346 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2347 Now static.
2348 (debug_method_add): Use va_list and vsprintf rather than relying
2349 on undefined behavior with wrong number of arguments.
2350 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2351 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2352 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2353 since we're not interested in debugging glyphs with old libraries.
2354 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2355 GCC 4.6.0's static checking.
2356
2357 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 Integer overflow and signedness fixes (Bug#8873).
2360 A few related buffer overrun fixes, too.
2361
2362 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2363
2364 * dispextern.h (struct face.stipple):
2365 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2366 (x_bitmap_mask, x_allocate_bitmap_record)
2367 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2368 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2369 (x_create_bitmap_from_xpm_data):
2370 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2371 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2372 (.bitmaps_last):
2373 * xfaces.c (load_pixmap):
2374 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2375 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2376 (.bitmaps_last, struct x_output.icon_bitmap):
2377 Use ptrdiff_t, not int, for bitmap indexes.
2378 (x_allocate_bitmap_record): Check for size overflow.
2379 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2380
2381 Use ptrdiff_t, not int, for overlay counts.
2382 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2383 * editfns.c (overlays_around, get_pos_property):
2384 * textprop.c (get_char_property_and_overlay):
2385 * xdisp.c (next_overlay_change, note_mouse_highlight):
2386 * xfaces.c (face_at_buffer_position):
2387 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2388 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2389 (Fnext_overlay_change, Fprevious_overlay_change)
2390 (mouse_face_overlay_overlaps, Foverlays_in):
2391 Use ptrdiff_t, not int, for sizes.
2392 (overlays_at, overlays_in): Check for size-calculation overflow.
2393
2394 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2395
2396 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2397 (x_session_initialize): Do not assume string length fits in int.
2398
2399 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2400 This is unlikely, but can occur if DPI is outlandish.
2401
2402 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2403 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2404
2405 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2406 * xrdb.c (magic_file_p, search_magic_path):
2407 Omit last arg SUFFIX; it was always 0. All callers changed.
2408 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2409
2410 * xfont.c (xfont_match): Avoid need for strlen.
2411
2412 * xfns.c: Don't assume strlen fits in int.
2413 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2414
2415 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2416 not unsigned long, as we prefer signed integers. All callers changed.
2417 Detect integer overflow in repeat count.
2418 (message_dolog): Don't assume print length fits in 39 bytes.
2419 (display_mode_element): Don't assume strlen fits in int.
2420
2421 * termcap.c: Don't assume sizes fit in int and never overflow.
2422 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2423 (gobble_line): Check for size-calculation overflow.
2424
2425 * minibuf.c (Fread_buffer):
2426 * lread.c (intern, intern_c_string):
2427 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2428 Don't assume string length fits in int.
2429
2430 * keyboard.c (parse_tool_bar_item):
2431 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2432
2433 * font.c: Don't assume string length fits in int.
2434 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2435 Use ptrdiff_t, not int.
2436 (font_intern_prop): Don't assume string length fits in int.
2437 Don't assume integer property fits in fixnum.
2438 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2439
2440 * filelock.c: Fix some buffer overrun and integer overflow issues.
2441 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2442 Reformulate so as not to need the command string.
2443 Invoke gzip -cd rather than gunzip, as it's more portable.
2444 (lock_info_type, lock_file_1, lock_file):
2445 Don't assume pid_t and time_t fit in unsigned long.
2446 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2447 (current_lock_owner): Prefer signed type for sizes.
2448 Use memcpy, not strncpy, where memcpy is what is really wanted.
2449 Don't assume (via atoi) that time_t and pid_t fit in int.
2450 Check for time_t and/or pid_t out of range, e.g., via a network share.
2451 Don't alloca where an auto var works fine.
2452
2453 * fileio.c: Fix some integer overflow issues.
2454 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2455 Don't assume string length fits in int.
2456 (directory_file_name): Don't assume string length fits in long.
2457 (make_temp_name): Don't assume pid fits in int, or that its print
2458 length is less than 20.
2459
2460 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2461
2462 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2463
2464 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2465
2466 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2467 We prefer signed integers, even for size calculations.
2468
2469 * emacs.c: Don't assume string length fits in 'int'.
2470 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2471 (main): Don't invoke strlen when not needed.
2472
2473 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2474 (XD_DEBUG_MESSAGE): Don't waste a byte.
2475
2476 * callproc.c (getenv_internal_1, getenv_internal)
2477 (Fgetenv_internal):
2478 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2479
2480 * lread.c (invalid_syntax): Omit length argument.
2481 All uses changed. This doesn't fix a bug, but it simplifies the
2482 code away from its former Hollerith-constant appearance, and it's
2483 one less 'int' to worry about when looking at integer-overflow issues.
2484 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2485
2486 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2487 This didn't break anything, but it didn't help either.
2488 It's confusing to put a bogus integer in a place where the actual
2489 value does not matter.
2490 (LIST_END_P): Remove unused macro and its bogus comment.
2491 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2492
2493 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2494 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2495 implementation.
2496 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2497 We prefer signed types, and the value cannot exceed the EMACS_INT
2498 range anyway (because otherwise the length would not be representable).
2499 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2500 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2501 This avoids a GCC warning when WIDE_EMACS_INT.
2502
2503 * indent.c (sane_tab_width): New function.
2504 (current_column, scan_for_column, Findent_to, position_indentation)
2505 (compute_motion): Use it. This is just for clarity.
2506 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2507
2508 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2509
2510 * lisp.h (lint_assume): New macro.
2511 * composite.c (composition_gstring_put_cache):
2512 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2513
2514 * editfns.c, insdel.c:
2515 Omit unnecessary forward decls, to simplify future changes.
2516
2517 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2518
2519 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2520
2521 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2522 Use much-faster test for byte-length change.
2523 Don't assume string byte-length fits in 'int'.
2524 Check that character arg fits in 'int'.
2525 (mapcar1): Declare byte as byte, for clarity.
2526
2527 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2528
2529 * fns.c (concat): Catch string overflow earlier.
2530 Do not rely on integer wraparound.
2531
2532 * dispextern.h (struct it.overlay_strings_charpos)
2533 (struct it.selective): Now EMACS_INT, not int.
2534 * xdisp.c (forward_to_next_line_start)
2535 (back_to_previous_visible_line_start)
2536 (reseat_at_next_visible_line_start, next_element_from_buffer):
2537 Don't arbitrarily truncate the value of 'selective' to int.
2538
2539 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2540
2541 * composite.c: Don't truncate sizes to 'int'.
2542 (composition_gstring_p, composition_reseat_it)
2543 (composition_adjust_point): Use EMACS_INT, not int.
2544 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2545 not EMACS_UINT, for indexes.
2546
2547 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2548
2549 * buffer.c: Include <verify.h>.
2550 (struct sortvec.priority, struct sortstr.priority):
2551 Now EMACS_INT, not int.
2552 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2553 (struct sortstr.size, record_overlay_string)
2554 (struct sortstrlist.size, struct sortlist.used):
2555 Don't truncate size to int.
2556 (record_overlay_string): Check for size-calculation overflow.
2557 (init_buffer_once): Check at compile-time, not run-time.
2558
2559 2011-06-22 Jim Meyering <meyering@redhat.com>
2560
2561 Don't leak an XBM-image-sized buffer
2562 * image.c (xbm_load): Free the image buffer after using it.
2563
2564 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2565
2566 Port to Sun C.
2567 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2568 that Sun C diagnosed.
2569 * fns.c (secure_hash): Fix pointer signedness issue.
2570 * intervals.c (static_offset_intervals): New function.
2571 (offset_intervals): Use it.
2572
2573 2011-06-21 Leo Liu <sdl.web@gmail.com>
2574
2575 * deps.mk (fns.o):
2576 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2577 sha512.h.
2578
2579 * fns.c (secure_hash): Rename from crypto_hash_function and change
2580 the first arg to accept symbols.
2581 (Fsecure_hash): New primitive.
2582 (syms_of_fns): New symbols.
2583
2584 2011-06-20 Deniz Dogan <deniz@dogan.se>
2585
2586 * process.c (Fset_process_buffer): Clarify return value in
2587 docstring.
2588
2589 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2590
2591 * dispnew.c (add_window_display_history): Use BVAR.
2592
2593 * xdisp.c (debug_method_add): Use BVAR.
2594 (check_window_end, dump_glyph_matrix, dump_glyph)
2595 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2596
2597 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2598 Likewise.
2599
2600 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2601 check till after the cache is created in init_frame_faces.
2602
2603 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2604
2605 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2606
2607 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2608
2609 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2610 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2611 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2612
2613 Improve buffer-overflow checking (Bug#8873).
2614 * fileio.c (Finsert_file_contents):
2615 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2616 Remove the old (too-loose) buffer overflow checks.
2617 They weren't needed, since make_gap checks for buffer overflow.
2618 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2619 The old code merely checked for Emacs fixnum overflow, and relied
2620 on undefined (wraparound) behavior. The new code avoids undefined
2621 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2622
2623 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2624 Tune. Don't use wider integers than needed. Don't use alloca.
2625 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2626
2627 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2628
2629 * insdel.c, lisp.h (buffer_overflow): New function.
2630 (insert_from_buffer_1, replace_range, replace_range_2):
2631 * insdel.c (make_gap_larger):
2632 * editfns.c (Finsert_char):
2633 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2634
2635 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2636
2637 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2638
2639 Integer overflow and signedness fixes (Bug#8873).
2640
2641 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2642 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2643
2644 * fileio.c: Don't assume EMACS_INT fits in off_t.
2645 (emacs_lseek): New static function.
2646 (Finsert_file_contents, Fwrite_region): Use it.
2647 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2648
2649 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2650
2651 * fns.c: Don't overflow int when computing a list length.
2652 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2653 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2654 truncation on 64-bit hosts. Check for QUIT every
2655 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2656 faster and is responsive enough.
2657 (Flength): Report an error instead of overflowing an integer.
2658 (Fsafe_length): Return a float if the value is not representable
2659 as a fixnum. This shouldn't happen except in contrived situations.
2660 (Fnthcdr, Fsort): Don't assume list length fits in int.
2661 (Fcopy_sequence): Don't assume vector length fits in int.
2662
2663 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2664 (header_size, word_size): New constants.
2665 (allocate_vectorlike): Don't check size overflow here.
2666 (allocate_vector): Check it here instead, since this is the only
2667 caller of allocate_vectorlike that could cause overflow.
2668 Check that the new vector's length is representable as a fixnum.
2669
2670 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2671 The previous code was bogus. For example, next_almost_prime (32)
2672 returned 39, which is undesirable as it is a multiple of 3; and
2673 next_almost_prime (24) returned 25, which is a multiple of 5 so
2674 why was the code bothering to check for multiples of 7?
2675
2676 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2677
2678 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2679
2680 Variadic C functions now count arguments with ptrdiff_t.
2681 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2682 Back then I didn't know that the Emacs coding style prefers signed int.
2683 Also, in the meantime I found a few more instances where arguments
2684 were being counted with int, which may truncate counts on 64-bit
2685 machines, or EMACS_INT, which may be unnecessarily wide.
2686 * lisp.h (struct Lisp_Subr.function.aMANY)
2687 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2688 Arg counts are now ptrdiff_t, not size_t.
2689 All variadic functions and their callers changed accordingly.
2690 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2691 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2692 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2693 * callint.c (Fcall_interactively): Check arg count for overflow,
2694 to avoid potential buffer overrun. Use signed char, not 'int',
2695 for 'varies' array, so that we needn't bother to check its size
2696 calculation for overflow.
2697 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2698 * eval.c (apply_lambda):
2699 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2700 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2701 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2702
2703 * callint.c (Fcall_interactively): Don't use index var as event count.
2704
2705 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2706 * mem-limits.h (SIZE): Remove; no longer used.
2707
2708 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2709
2710 Remove unnecessary casts.
2711 * xterm.c (x_term_init):
2712 * xfns.c (x_set_border_pixel):
2713 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2714 These aren't needed now that we assume ANSI C.
2715
2716 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2717 It's more likely to cause problems (due to unsigned overflow)
2718 than to cure them.
2719
2720 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2721
2722 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2723
2724 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2725
2726 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2727
2728 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2729
2730 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2731
2732 GLYPH_CODE_FACE returns EMACS_INT, not int.
2733 * dispextern.h (merge_faces):
2734 * xfaces.c (merge_faces):
2735 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2736 Don't assume EMACS_INT fits in int.
2737
2738 * character.h (CHAR_VALID_P): Remove unused parameter.
2739 * fontset.c, lisp.h, xdisp.c: All uses changed.
2740
2741 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2742
2743 * fns.c (concat): Minor tuning based on overflow analysis.
2744 This doesn't fix any bugs. Use int to hold character, instead
2745 of constantly refetching from Emacs object. Use XFASTINT, not
2746 XINT, for value known to be a character. Don't bother comparing
2747 a single byte to 0400, as it's always less.
2748
2749 * floatfns.c (Fexpt):
2750 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2751
2752 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2753 for characters.
2754
2755 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2756
2757 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2758 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2759 incorrectly succeed when S was a string, because 4294967386 was
2760 truncated before it was used.
2761
2762 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2763 Otherwise, an out-of-range integer could cause undefined behavior
2764 on a 64-bit host.
2765
2766 * composite.c: Use int, not EMACS_INT, for characters.
2767 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2768 EMACS_INT, for values that are known to be in character range.
2769 This doesn't fix any bugs but is the usual style inside Emacs and
2770 may generate better code on 32-bit machines.
2771
2772 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2773 This is for reasons similar to the recent CHAR_STRING fix.
2774 * charset.c (Fencode_char): Check that character arg is actually
2775 a character. Pass an int to ENCODE_CHAR.
2776 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2777 wider than 'int', as a compile-time check to prevent future regressions
2778 in this area.
2779
2780 * character.c (char_string): Remove unnecessary casts.
2781
2782 Make sure a 64-bit char is never passed to CHAR_STRING.
2783 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2784 by silently ignoring the top 32 bits, allowing some values
2785 that were far too large to be valid characters.
2786 * character.h: Include <verify.h>.
2787 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2788 arguments are no wider than unsigned, as a compile-time check
2789 to prevent future regressions in this area.
2790 * data.c (Faset):
2791 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2792 (Fsubst_char_in_region):
2793 * fns.c (concat):
2794 * xdisp.c (decode_mode_spec_coding):
2795 Adjust to CHAR_STRING's new requirement.
2796 * editfns.c (Finsert_char, Fsubst_char_in_region):
2797 * fns.c (concat): Check that character args are actually
2798 characters. Without this test, these functions did the wrong
2799 thing with wildly out-of-range values on 64-bit hosts.
2800
2801 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2802 These casts should not be needed on 32-bit hosts, either.
2803 * keyboard.c (read_char):
2804 * lread.c (Fload): Remove casts to unsigned.
2805
2806 * lisp.h (UNSIGNED_CMP): New macro.
2807 This fixes comparison bugs on 64-bit hosts.
2808 (ASCII_CHAR_P): Use it.
2809 * casefiddle.c (casify_object):
2810 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2811 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2812 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2813 * dispextern.h (FACE_FROM_ID):
2814 * keyboard.c (read_char): Use UNSIGNED_CMP.
2815
2816 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2817 not to EMACS_INT, to avoid GCC warning.
2818
2819 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2820
2821 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2822 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2823 isn't needed on 32-bit machines.
2824
2825 * buffer.c (Fgenerate_new_buffer_name):
2826 Use EMACS_INT for count, not int.
2827 (advance_to_char_boundary): Return EMACS_INT, not int.
2828
2829 * data.c (Qcompiled_function): Now static.
2830
2831 * window.c (window_body_lines): Now static.
2832
2833 * image.c (gif_load): Rename local to avoid shadowing.
2834
2835 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2836 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2837 * alloc.c (make_save_value): Integer argument is now of type
2838 ptrdiff_t, not int.
2839 (mark_object): Use ptrdiff_t, not int.
2840 * lisp.h (pD): New macro.
2841 * print.c (print_object): Use it.
2842
2843 * alloc.c: Use EMACS_INT, not int, to count objects.
2844 (total_conses, total_markers, total_symbols, total_vector_size)
2845 (total_free_conses, total_free_markers, total_free_symbols)
2846 (total_free_floats, total_floats, total_free_intervals)
2847 (total_intervals, total_strings, total_free_strings):
2848 Now EMACS_INT, not int. All uses changed.
2849 (Fgarbage_collect): Compute overall total using a double, so that
2850 integer overflow is less likely to be a problem. Check for overflow
2851 when converting back to an integer.
2852 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2853 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2854 These were 'int' variables that could overflow on 64-bit hosts;
2855 they were never used, so remove them instead of repairing them.
2856 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2857 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2858 Previously, this ceilinged at INT_MAX, but that doesn't work on
2859 64-bit machines.
2860 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2861
2862 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2863 (allocate_vectorlike): Check for ptrdiff_t overflow.
2864 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2865 when a (possibly-narrower) signed value would do just as well.
2866 We prefer using signed arithmetic, to avoid comparison confusion.
2867
2868 * alloc.c: Catch some string size overflows that we were missing.
2869 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2870 for convenience in STRING_BYTES_MAX.
2871 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2872 The definition here is exact; the one in lisp.h was approximate.
2873 (allocate_string_data): Check for string overflow. This catches
2874 some instances we weren't catching before. Also, it catches
2875 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2876 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2877 and ptrdiff_t and EMACS_INT are both 64 bits.
2878
2879 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2880 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2881 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2882
2883 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2884
2885 * alloc.c (Fmake_string): Check for out-of-range init.
2886
2887 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2888
2889 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2890
2891 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2892
2893 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2894 xg_get_default_scrollbar_width.
2895
2896 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2897 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2898 (style_changed_cb): Call update_theme_scrollbar_width and call
2899 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2900 all frames (Bug#8505).
2901 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2902 Call gtk_window_set_resizable if HAVE_GTK3.
2903 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2904 and height if HAVE_GTK3 (Bug#8505).
2905 (scroll_bar_width_for_theme): New variable.
2906 (update_theme_scrollbar_width): New function.
2907 (xg_get_default_scrollbar_width): Move code to
2908 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2909 (xg_initialize): Call update_theme_scrollbar_width.
2910
2911 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2912
2913 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2914
2915 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2916
2917 * frame.c (make_frame): Call other_buffer_safely instead of
2918 other_buffer.
2919
2920 * window.c (temp_output_buffer_show): Call display_buffer with
2921 second argument Vtemp_buffer_show_specifiers and reset latter
2922 immediately after the call.
2923 (Vtemp_buffer_show_specifiers): New variable.
2924 (auto_window_vscroll_p, next_screen_context_lines)
2925 (Vscroll_preserve_screen_position): Remove leading asterisks from
2926 doc-strings.
2927
2928 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 Fix minor problems found by GCC 4.6.0 static checking.
2931 * buffer.c (Qclone_number): Remove for now, as it's unused.
2932 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2933 (record_buffer): Remove unused local.
2934 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2935 (set_frame_buffer_list): Remove; unused.
2936 * frame.h (other_visible_frames): Remove decl.
2937 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2938 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2939 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2940 if HAVE_GPM.
2941 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2942 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2943 Define only if HAVE_GPM.
2944 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2945 (update_hints_inhibit): Remove; never set. All uses removed.
2946 * widgetprv.h (emacsFrameClassRec): Remove decl.
2947 * window.c (delete_deletable_window): Now returns void, since it
2948 wasn't returning anything.
2949 (compare_window_configurations): Remove unused locals.
2950 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2951 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2952 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2953 the same widths as pointers. This follows up on the 2011-05-06 patch.
2954 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2955 * xterm.h: Likewise.
2956 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2957
2958 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2959
2960 * makefile.w32-in: Update dependencies.
2961 (LISP_H): Add lib/intprops.h.
2962
2963 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2964
2965 * image.c (gif_load): Add animation frame delay to the metadata.
2966 (syms_of_image): Use DEFSYM. New symbol `delay'.
2967
2968 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2969
2970 * window.c (delete_deletable_window): Re-add.
2971 (Fset_window_configuration): Rewrite to handle dead buffers and
2972 consequently deletable windows.
2973 (window_tree, Fwindow_tree): Remove. Supply functionality in
2974 window.el.
2975 (compare_window_configurations): Simplify code.
2976
2977 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2978
2979 * image.c (imagemagick_load_image): Fix type mismatch.
2980 (Fimagemagick_types): Likewise.
2981
2982 * window.h (replace_buffer_in_windows): Declare.
2983
2984 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2985
2986 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2987 Qclone_number. Remove external declaration of Qdelete_window.
2988 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2989 code.
2990 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2991 Run Qbuffer_list_update_hook if allowed.
2992 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2993 buffer list implementation.
2994 (other_buffer_safely): New function.
2995 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2996 calls to replace_buffer_in_windows and
2997 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2998 if allowed.
2999 (record_buffer): Inhibit quitting and rewrite using quittable
3000 functions. Run Qbuffer_list_update_hook if allowed.
3001 (Frecord_buffer, Funrecord_buffer): New functions.
3002 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3003 Move switch-to-buffer to window.el.
3004 (bury-buffer): Move to window.el.
3005 (Vbuffer_list_update_hook): New variable.
3006
3007 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3008 section.
3009
3010 * window.h (resize_frame_windows): Move up in code.
3011 (Fwindow_frame): Remove EXFUN.
3012 (replace_buffer_in_all_windows): Remove prototype.
3013 (replace_buffer_in_windows_safely): Add prototype.
3014
3015 * window.c: Declare Qdelete_window static again. Move down
3016 declaration of select_count.
3017 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3018 (Fother_window): Move to window.el.
3019 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3020 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3021 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3022 window.el.
3023 (replace_buffer_in_windows): Implement by calling
3024 Qreplace_buffer_in_windows.
3025 (replace_buffer_in_all_windows): Remove with some functionality
3026 moved into replace_buffer_in_windows_safely.
3027 (replace_buffer_in_windows_safely): New function.
3028 (select_window_norecord, select_frame_norecord): Move in front
3029 of run_window_configuration_change_hook. Remove now obsolete
3030 declarations.
3031 (Fset_window_buffer): Rewrite doc-string.
3032 Call Qrecord_window_buffer.
3033 (keys_of_window): Move binding for other-window to window.el.
3034
3035 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3036
3037 * dispextern.h (struct image): Replace data member, whose int_val
3038 and ptr_val fields were not used by anything, with a single
3039 lisp_val object.
3040
3041 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3042 (gif_clear_image, gif_load, imagemagick_load_image)
3043 (gs_clear_image, gs_load): Callers changed.
3044
3045 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3046
3047 * buffer.h: Include <time.h>, for time_t.
3048 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3049
3050 Fix minor problems found by static checking.
3051
3052 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3053
3054 Make identifiers static if they are not used in other modules.
3055 * data.c (Qcompiled_function, Qframe, Qvector):
3056 * image.c (QimageMagick, Qsvg):
3057 * minibuf.c (Qmetadata):
3058 * window.c (resize_window_check, resize_root_window): Now static.
3059 * window.h (resize_window_check, resize_root_window): Remove decls.
3060
3061 * window.c (window_deletion_count, delete_deletable_window):
3062 Remove; unused.
3063 (window_body_lines): Now static.
3064 (Fdelete_other_windows_internal): Mark vars as initialized.
3065 Make sure 'resize_failed' is initialized.
3066 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3067 (resize_window_apply): Remove unused local.
3068 * window.h (delete_deletable_window): Remove decl.
3069
3070 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3071 (imagemagick_load_image): Fix pointer signedness problem by changing
3072 last arg from unsigned char * to char *. All uses changed.
3073 Also, fix a local for similar reasons.
3074 Remove unused locals. Remove locals to avoid shadowing.
3075 (fn_rsvg_handle_free): Remove; unused.
3076 (svg_load, svg_load_image): Fix pointer signedness problem.
3077 (imagemagick_load_image): Don't use garbage pointer image_wand.
3078
3079 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3080
3081 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3082
3083 * image.c (gif_load): Fix omitted cast error introduced by
3084 2011-06-06 change.
3085
3086 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3087
3088 * window.h (resize_proportionally, orig_total_lines)
3089 (orig_top_line): Remove from window structure.
3090 (set_window_height, set_window_width, change_window_heights)
3091 (Fdelete_window): Remove prototypes.
3092 (resize_frame_windows): Remove duplicate declaration.
3093
3094 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3095
3096 * window.h (resize_frame_windows, resize_window_check)
3097 (delete_deletable_window, resize_root_window)
3098 (resize_frame_windows): Declare prototypes.
3099
3100 * window.c (resize_window_apply): Make definition be "static" to
3101 match the prototype.
3102
3103 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3104
3105 * window.c: Remove declarations of Qwindow_size_fixed,
3106 window_min_size_1, window_min_size_2, window_min_size,
3107 size_window, window_fixed_size_p, enlarge_window, delete_window.
3108 Remove static from declaration of Qdelete_window, it's
3109 temporarily needed by Fbury_buffer.
3110 (replace_window): Don't assign orig_top_line and
3111 orig_total_lines.
3112 (Fdelete_window, delete_window): Remove. Window deletion is
3113 handled by window.el.
3114 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3115 Replace Fdelete_window calls with calls to Qdelete_window.
3116 (Fdelete_other_windows): Remove. Deleting other windows is
3117 handled by window.el.
3118 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3119 handled in window.el.
3120 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3121 Window minimum sizes are handled in window.el.
3122 (shrink_windows, size_window, set_window_height)
3123 (set_window_width, change_window_heights, window_height)
3124 (window_width, CURBEG, CURSIZE, enlarge_window)
3125 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3126 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3127 handled in window.el.
3128 (make_dummy_parent): Rename to make_parent_window and give it a
3129 second argument horflag.
3130 (make_window): Don't set resize_proportionally any more.
3131 (Fsplit_window): Remove. Windows are split in window.el.
3132 (save_restore_action, save_restore_orig_size)
3133 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3134 Resize mini windows in window.el.
3135 (grow_mini_window, shrink_mini_window): Implement by calling
3136 Qresize_root_window_vertically, resize_window_check and
3137 resize_window_apply.
3138 (saved_window, Fset_window_configuration, save_window_save):
3139 Do not handle orig_top_line, orig_total_lines, and
3140 resize_proportionally.
3141 (window_min_height, window_min_width): Move to window.el.
3142 (keys_of_window): Move bindings for delete-other-windows,
3143 split-window, delete-window and enlarge-window to window.el.
3144
3145 * buffer.c: Temporarily extern Qdelete_window.
3146 (Fbury_buffer): Temporarily call Qdelete_window instead of
3147 Fdelete_window (Fbury_buffer will move to window.el soon).
3148
3149 * frame.c (set_menu_bar_lines_1): Remove code handling
3150 orig_top_line and orig_total_lines.
3151
3152 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3153 set_window_height but set heights directly.
3154 (change_frame_size_1): Use resize_frame_windows.
3155
3156 * xdisp.c (init_xdisp): Don't use set_window_height but set
3157 heights directly.
3158
3159 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3160 Use resize_frame_windows instead of change_window_heights and run
3161 run_window_configuration_change_hook.
3162
3163 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3164 instead of change_window_heights and run
3165 run_window_configuration_change_hook.
3166
3167 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3168
3169 * window.c (replace_window): Rename second argument REPLACEMENT to
3170 NEW. New third argument SETFLAG. Rewrite.
3171 (delete_window, make_dummy_parent): Call replace_window with
3172 third argument 1.
3173 (window_list_1): Move down in code.
3174 (run_window_configuration_change_hook): Move set_buffer part
3175 before select_frame_norecord part in order to unwind correctly.
3176 Rename count1 to count.
3177 (recombine_windows, delete_deletable_window, resize_root_window)
3178 (Fdelete_other_windows_internal)
3179 (Frun_window_configuration_change_hook, make_parent_window)
3180 (resize_window_check, resize_window_apply, Fresize_window_apply)
3181 (resize_frame_windows, Fsplit_window_internal)
3182 (Fdelete_window_internal, Fresize_mini_window_internal):
3183 New functions.
3184 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3185
3186 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3187
3188 * window.h (window): Add some new members to window structure -
3189 normal_lines, normal_cols, new_total, new_normal, clone_number,
3190 splits, nest, prev_buffers, next_buffers.
3191 (WINDOW_TOTAL_SIZE): Move here from window.c.
3192 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3193
3194 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3195 Remove.
3196 (make_dummy_parent): Set new members of windows structure.
3197 (make_window): Move down in code. Handle new members of window
3198 structure.
3199 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3200 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3201 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3202 (Fset_window_prev_buffers, Fwindow_next_buffers)
3203 (Fset_window_next_buffers, Fset_window_clone_number):
3204 New functions.
3205 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3206 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3207 Doc-string fixes.
3208 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3209 Argument WINDOW can be now internal window too.
3210 (Fwindow_use_time): Move up in code.
3211 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3212 Rewrite doc-string.
3213 (Fset_window_configuration, saved_window)
3214 (Fcurrent_window_configuration, save_window_save): Handle new
3215 members of window structure.
3216 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3217 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3218 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3219 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3220 Qget_mru_window, Qresize_root_window,
3221 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3222 Qauto_buffer_name; staticpro them.
3223
3224 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3225
3226 * window.c (Fwindow_total_size, Fwindow_left_column)
3227 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3228 (Fwindow_list_1): New functions.
3229 (window_box_text_cols): Replace with window_body_cols.
3230 (Fwindow_width, Fscroll_left, Fscroll_right):
3231 Use window_body_cols instead of window_box_text_cols.
3232 (delete_window, Fset_window_configuration):
3233 Call delete_all_subwindows with window as argument.
3234 (delete_all_subwindows): Take a window as argument and not a
3235 structure. Rewrite.
3236 (window_loop): Remove handling of GET_LRU_WINDOW and
3237 GET_LARGEST_WINDOW.
3238 (Fget_lru_window, Fget_largest_window): Move to window.el.
3239
3240 * window.h: Extern window_body_cols instead of
3241 window_box_text_cols. delete_all_subwindows now takes a
3242 Lisp_Object as argument.
3243
3244 * indent.c (compute_motion, Fcompute_motion):
3245 Use window_body_cols instead of window_box_text_cols.
3246
3247 * frame.c (delete_frame): Call delete_all_subwindows with root
3248 window as argument.
3249
3250 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3251
3252 * fns.c (Fputhash): Document return value.
3253
3254 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3255
3256 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3257
3258 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 Cons<->int and similar integer overflow fixes (Bug#8794).
3261
3262 Check for overflow when converting integer to cons and back.
3263 * charset.c (Fdefine_charset_internal, Fdecode_char):
3264 Use cons_to_unsigned to catch overflow.
3265 (Fencode_char): Use INTEGER_TO_CONS.
3266 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3267 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3268 * data.c (long_to_cons, cons_to_long): Remove.
3269 (cons_to_unsigned, cons_to_signed): New functions.
3270 These signal an error for invalid or out-of-range values.
3271 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3272 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3273 * font.c (Ffont_variation_glyphs):
3274 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3275 * lisp.h: Include <intprops.h>.
3276 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3277 (cons_to_signed, cons_to_unsigned): New decls.
3278 (long_to_cons, cons_to_long): Remove decls.
3279 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3280 (Fprimitive_undo): Use CONS_TO_INTEGER.
3281 * xfns.c (Fx_window_property): Likewise.
3282 * xselect.c: Include <limits.h>.
3283 (x_own_selection, selection_data_to_lisp_data):
3284 Use INTEGER_TO_CONS.
3285 (x_handle_selection_request, x_handle_selection_clear)
3286 (x_get_foreign_selection, Fx_disown_selection_internal)
3287 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3288 (lisp_data_to_selection_data): Use cons_to_unsigned.
3289 (x_fill_property_data): Use cons_to_signed.
3290 Report values out of range.
3291
3292 Check for buffer and string overflow more precisely.
3293 * buffer.h (BUF_BYTES_MAX): New macro.
3294 * lisp.h (STRING_BYTES_MAX): New macro.
3295 * alloc.c (Fmake_string):
3296 * character.c (string_escape_byte8):
3297 * coding.c (coding_alloc_by_realloc):
3298 * doprnt.c (doprnt):
3299 * editfns.c (Fformat):
3300 * eval.c (verror):
3301 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3302 since they may not be the same number.
3303 * editfns.c (Finsert_char):
3304 * fileio.c (Finsert_file_contents):
3305 Likewise for BUF_BYTES_MAX.
3306
3307 * image.c: Use ptrdiff_t, not int, for sizes.
3308 (slurp_file): Switch from int to ptrdiff_t.
3309 All uses changed.
3310 (slurp_file): Check that file size fits in both size_t (for
3311 malloc) and ptrdiff_t (for sanity and safety).
3312
3313 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3314 if b->modtime has its maximal value.
3315
3316 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3317
3318 Don't assume time_t can fit into int.
3319 * buffer.h (struct buffer.modtime): Now time_t, not int.
3320 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3321 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3322
3323 Minor fixes for signed vs unsigned integers.
3324 * character.h (MAYBE_UNIFY_CHAR):
3325 * charset.c (maybe_unify_char):
3326 * keyboard.c (read_char, reorder_modifiers):
3327 XINT -> XFASTINT, since the integer must be nonnegative.
3328 * ftfont.c (ftfont_spec_pattern):
3329 * keymap.c (access_keymap, silly_event_symbol_error):
3330 XUINT -> XFASTINT, since the integer must be nonnegative.
3331 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3332 since it makes no difference and we prefer signed.
3333 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3334 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3335 nonnegative.
3336
3337 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3338
3339 * window.h (Fwindow_frame): Declare.
3340
3341 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3342
3343 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3344 (SPARE_MEMORY): Always define.
3345 (LARGE_REQUEST): Remove.
3346 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3347
3348 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3349
3350 * lisp.h: Move EXFUNS for Fframe_root_window,
3351 Fframe_first_window and Fset_frame_selected_window to window.h.
3352
3353 * window.h: Move EXFUNS for Fframe_root_window,
3354 Fframe_first_window and Fset_frame_selected_window here from
3355 lisp.h.
3356
3357 * frame.c (Fwindow_frame, Fframe_first_window)
3358 (Fframe_root_window, Fframe_selected_window)
3359 (Fset_frame_selected_window): Move to window.c.
3360 (Factive_minibuffer_window): Move to minibuf.c.
3361 (Fother_visible_frames_p): New function.
3362
3363 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3364
3365 * window.c (decode_window, decode_any_window): Move up in code.
3366 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3367 (inhibit_frame_unsplittable): Remove unused variable.
3368 (Fwindow_buffer): Move up and rewrite doc-string.
3369 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3370 (Fwindow_prev): New functions.
3371 (Fwindow_frame): Move here from frame.c. Accept any window as
3372 argument.
3373 (Fframe_root_window, Fframe_first_window)
3374 (Fframe_selected_window): Move here from frame.c. Accept frame
3375 or arbitrary window as argument. Update doc-strings.
3376 (Fminibuffer_window): Move up in code.
3377 (Fwindow_minibuffer_p): Move up in code and simplify.
3378 (Fset_frame_selected_window): Move here from frame.c.
3379 Marginal rewrite.
3380 (Fselected_window, select_window, Fselect_window): Move up in
3381 code. Minor doc-string fixes.
3382
3383 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3384
3385 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3386 Do not assume that spare memory exists; that assumption is valid
3387 only if SYSTEM_MALLOC.
3388 (LARGE_REQUEST): New macro, so that the issue of large requests
3389 is separated from the issue of spare memory.
3390
3391 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3392
3393 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3394 format. (Bug#8806)
3395
3396 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3397
3398 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3399 before statements.
3400
3401 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3402
3403 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3404
3405 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3406
3407 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3408 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3409
3410 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3411
3412 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3413
3414 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3415
3416 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3417 (x_clipboard_manager_save): Add return value.
3418 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3419 New error handlers.
3420 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3421 Obey Vx_select_enable_clipboard_manager. Catch errors in
3422 x_clipboard_manager_save (Bug#8779).
3423 (Vx_select_enable_clipboard_manager): New variable.
3424 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3425
3426 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3427
3428 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3429
3430 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3431
3432 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3433 in the current matrix if keep_current_p is non-zero.
3434
3435 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3436
3437 * bidi.c (bidi_level_of_next_char): Fix last change.
3438
3439 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3440
3441 Support bidi reordering of text covered by display properties.
3442
3443 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3444 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3445 (bidi_cache_search, bidi_cache_iterator_state)
3446 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3447 (bidi_level_of_next_char, bidi_move_to_visually_next):
3448 Support character positions inside a run of characters covered by a
3449 display string.
3450 (bidi_paragraph_init, bidi_resolve_explicit_1)
3451 (bidi_level_of_next_char): Call bidi_fetch_char and
3452 bidi_fetch_char_advance instead of FETCH_CHAR and
3453 FETCH_CHAR_ADVANCE.
3454 (bidi_init_it): Initialize new members.
3455 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3456 definitions.
3457 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3458 instead of using explicit *_CHAR codes.
3459 (bidi_resolve_explicit, bidi_resolve_weak):
3460 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3461 bidirectional text is supported only in multibyte buffers.
3462 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3463 it to initialize the frame_window_p member of struct bidi_it.
3464 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3465 (bidi_resolve_explicit, bidi_resolve_weak)
3466 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3467 bidi_it->nchars is non-positive.
3468 (bidi_level_of_next_char): Don't try to lookup the cache for the
3469 next/previous character if nothing is cached there yet, or if we
3470 were just reseat()'ed to a new position.
3471
3472 * xdisp.c (set_cursor_from_row): Set start and stop points
3473 according to the row's direction when priming the loop that looks
3474 for the glyph on which to display cursor.
3475 (single_display_spec_intangible_p): Function deleted.
3476 (display_prop_intangible_p): Reimplement to call
3477 handle_display_spec instead of single_display_spec_intangible_p.
3478 Accept 3 additional arguments needed by handle_display_spec.
3479 This fixes incorrect cursor motion across display property with complex
3480 values: lists, `(when COND...)' forms, etc.
3481 (single_display_spec_string_p): Support property values that are
3482 lists with the argument STRING its top-level element.
3483 (display_prop_string_p): Fix the condition for processing a
3484 property that is a list to be consistent with handle_display_spec.
3485 (handle_display_spec): New function, refactored from the
3486 last portion of handle_display_prop.
3487 (compute_display_string_pos): Accept additional argument
3488 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3489 value of a `display' property is a "replacing spec".
3490 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3491 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3492 the display property, but just return a value indicating whether
3493 the display property will replace the characters it covers.
3494 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3495 frame_window_p members of struct bidi_it.
3496 (compute_display_string_pos, compute_display_string_end):
3497 New functions.
3498 (push_it): Accept second argument POSITION, where pop_it should
3499 jump to continue iteration.
3500 (reseat_1): Initialize bidi_it.disp_pos.
3501
3502 * keyboard.c (adjust_point_for_property): Adjust the call to
3503 display_prop_intangible_p to its new signature.
3504
3505 * dispextern.h (struct bidi_it): New member frame_window_p.
3506 (bidi_init_it): Update prototypes.
3507 (display_prop_intangible_p): Update prototype.
3508 (compute_display_string_pos, compute_display_string_end):
3509 Declare prototypes.
3510 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3511 EMACS_INT.
3512
3513 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 Malloc failure behavior now depends on size of allocation.
3516 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3517 * lisp.h: Change signatures accordingly.
3518 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3519 All callers changed. (Bug#8762)
3520
3521 * gnutls.c: Use Emacs's memory allocators.
3522 Without this change, the gnutls library would invoke malloc etc.
3523 directly, which causes problems on non-SYNC_INPUT hosts, and which
3524 runs afoul of improving memory_full behavior. (Bug#8761)
3525 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3526 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3527 xfree instead of the default malloc, realloc, free.
3528 (Fgnutls_boot): No need to check for memory allocation failure,
3529 since xmalloc does that for us.
3530
3531 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3532 * category.c (hash_get_category_set):
3533 * ccl.c (ccl_driver):
3534 * charset.c (Fdefine_charset_internal):
3535 * charset.h (struct charset.hash_index):
3536 * composite.c (get_composition_id, gstring_lookup_cache)
3537 (composition_gstring_put_cache):
3538 * composite.h (struct composition.hash_index):
3539 * dispextern.h (struct image.hash):
3540 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3541 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3542 (hashfn_equal, hashfn_user_defined, make_hash_table)
3543 (maybe_resize_hash_table, hash_lookup, hash_put)
3544 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3545 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3546 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3547 * image.c (make_image, search_image_cache, lookup_image)
3548 (xpm_put_color_table_h):
3549 * lisp.h (struct Lisp_Hash_Table):
3550 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3551 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3552 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3553 * alloc.c (allocate_vectorlike):
3554 Check for overflow in vector size calculations.
3555 * ccl.c (ccl_driver):
3556 Check for overflow when converting EMACS_INT to int.
3557 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3558 need to be updated by these changes.
3559 * fns.c (make_hash_table, maybe_resize_hash_table):
3560 Check for integer overflow with large hash tables.
3561 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3562 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3563 (SXHASH_REDUCE): New macro.
3564 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3565 Use it instead of discarding useful hash info with large hash values.
3566 (sxhash_float): New function.
3567 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3568 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3569 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3570 Rewrite to use FIXNUM_BITS, as this simplifies things.
3571 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3572 Adjust signatures to match updated version of code.
3573 (consing_since_gc): Now EMACS_INT, since a single hash table can
3574 use more than INT_MAX bytes.
3575
3576 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3577
3578 Make it possible to build with GCC-4.6+ -O2 -flto.
3579
3580 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3581
3582 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3583
3584 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3585 Call minibuffer-inactive-mode.
3586
3587 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3588
3589 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3590 Update dependencies.
3591
3592 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3593
3594 * data.c (init_data): Remove code for UTS, this system is not
3595 supported anymore.
3596
3597 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3598
3599 Don't force ./temacs to start in terminal mode.
3600
3601 * frame.c (make_initial_frame): Initialize faces in all cases, not
3602 only when CANNOT_DUMP is defined.
3603 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3604
3605 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3606
3607 * dispnew.c (add_window_display_history): Use const for the string
3608 pointer. Remove declaration, not needed.
3609
3610 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 Use 'inline', not 'INLINE'.
3613 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3614 * alloc.c, fontset.c (INLINE): Remove.
3615 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3616 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3617 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3618 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3619 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3620
3621 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3622
3623 Make it possible to run ./temacs.
3624
3625 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3626 syms_of_callproc does the same thing. Remove test for
3627 "initialized", do it in the caller.
3628 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3629
3630 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3631
3632 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3633 (read_minibuf): Use get_minibuffer.
3634 (syms_of_minibuf): Use DEFSYM.
3635 (Qmetadata): New var.
3636 * data.c (Qbuffer): Don't make it static.
3637 (syms_of_data): Use DEFSYM.
3638
3639 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3642 (CCL_CODE_MIN): New macro.
3643
3644 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3645
3646 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3647
3648 * eval.c (Qdebug): Now static.
3649 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3650 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3651 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3652
3653 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3654
3655 * image.c: Various fixes to ImageMagick code comments.
3656 (Fimagemagick_types): Doc fix.
3657
3658 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3659
3660 Minor fixes prompted by GCC 4.6.0 warnings.
3661
3662 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3663
3664 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3665 (x_clipboard_manager_save_all): Move extern decl to ...
3666 * xterm.h: ... here, so that it can be checked for consistency.
3667
3668 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3669
3670 * xselect.c (x_clipboard_manager_save_frame)
3671 (x_clipboard_manager_save_all): New functions.
3672 (Fx_clipboard_manager_save): Lisp function deleted.
3673
3674 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3675 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3676
3677 * xterm.h: Update prototype.
3678
3679 2011-05-28 William Xu <william.xwl@gmail.com>
3680
3681 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3682 exiting (Bug#8239).
3683
3684 2011-05-28 Jim Meyering <meyering@redhat.com>
3685
3686 Avoid a sign-extension bug in crypto_hash_function.
3687 * fns.c (to_uchar): Define.
3688 (crypto_hash_function): Use it to convert some newly-signed
3689 variables to unsigned, to avoid sign-extension bugs. For example,
3690 without this change, (md5 "truc") would evaluate to
3691 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3692 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3693 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3694
3695 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3696
3697 Integer overflow fixes.
3698
3699 * dbusbind.c: Serial number integer overflow fixes.
3700 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3701 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3702 to hold a serial number that is too large for a fixnum.
3703 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3704 Check for serial numbers out of range. Decode any serial number
3705 that was so large that it became a float. (Bug#8722)
3706
3707 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3708 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3709 Use XFASTINT rather than XUINT when numbers are nonnegative.
3710 (xd_append_arg, Fdbus_method_return_internal):
3711 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3712 arguments, check that Lisp number is nonnegative, rather than
3713 silently wrapping negative numbers around. (Bug#8722)
3714 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3715 (Bug#8722)
3716
3717 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3718
3719 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3720
3721 ccl: add integer overflow checks
3722 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3723 (IN_INT_RANGE): New macros.
3724 (ccl_driver): Use them to check for integer overflow when
3725 decoding a CCL program. Many of the new checks are whether XINT (x)
3726 fits in int; it doesn't always, on 64-bit hosts. The new version
3727 doesn't catch all possible integer overflows, but it's an
3728 improvement. (Bug#8719)
3729
3730 * alloc.c (make_event_array): Use XINT, not XUINT.
3731 There's no need for unsigned here.
3732
3733 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3734 This follows up to the 2011-05-06 change that substituted uintptr_t
3735 for EMACS_INT. This case wasn't caught back then.
3736
3737 Rework Fformat to avoid integer overflow issues.
3738 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3739 now (part of C89). Include <verify.h>.
3740 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3741 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3742 (Fformat): Avoid the prepass trying to compute sizes; it was only
3743 approximate and thus did not catch overflow reliably. Instead, walk
3744 through the format just once, formatting and computing sizes as we go,
3745 checking for integer overflow at every step, and allocating a larger
3746 buffer as needed. Keep track separately whether the format is
3747 multibyte. Keep only the most-recently calculated precision, rather
3748 than them all. Record whether each argument has been converted to
3749 string. Use EMACS_INT, not int, for byte and char and arg counts.
3750 Support field widths and precisions larger than INT_MAX. Avoid
3751 sprintf's undefined behavior with conversion specifications such as %#d
3752 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3753 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3754 formatting out-of-range floating point numbers with int
3755 formats. (Bug#8668)
3756
3757 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3758
3759 * data.c: Avoid integer truncation in expressions involving floats.
3760 * data.c: Include <intprops.h>.
3761 (arith_driver): When there's an integer overflow in an expression
3762 involving floating point, convert the integers to floating point
3763 so that the resulting value does not suffer from catastrophic
3764 integer truncation. For example, on a 64-bit host (* 4
3765 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3766 Do not rely on undefined behavior after integer overflow.
3767
3768 merge count_size_as_multibyte, parse_str_to_multibyte
3769 * character.c, character.h (count_size_as_multibyte):
3770 Rename from parse_str_to_multibyte; all uses changed.
3771 Check for integer overflow.
3772 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3773 since it's now a duplicate of the other. This is more of
3774 a character than a buffer op, so better that it's in character.c.
3775 * fns.c, print.c: Adjust to above changes.
3776
3777 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3778
3779 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3780
3781 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3782
3783 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3784 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3785 (x_clipboard_manager_save): Now static.
3786 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3787
3788 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3789 (crypto_hash_function): Now static.
3790 Fix pointer signedness problems. Avoid unnecessary initializations.
3791
3792 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3793
3794 * termhooks.h (Vselection_alist): Make it terminal-local.
3795
3796 * terminal.c (create_terminal): Initialize it.
3797
3798 * xselect.c: Support for clipboard managers.
3799 (Vselection_alist): Move to termhooks.h as terminal-local var.
3800 (LOCAL_SELECTION): New macro.
3801 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3802 (symbol_to_x_atom): Remove gratuitous arg.
3803 (x_handle_selection_request, lisp_data_to_selection_data)
3804 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3805 (x_own_selection, x_get_local_selection, x_convert_selection):
3806 New arg, specifying work frame. Use terminal-local Vselection_alist.
3807 (some_frame_on_display): Delete unused function.
3808 (Fx_own_selection_internal, Fx_get_selection_internal)
3809 (Fx_disown_selection_internal, Fx_selection_owner_p)
3810 (Fx_selection_exists_p): New optional frame arg.
3811 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3812 (x_handle_selection_clear): Don't treat other terminals with the
3813 same keyboard specially. Use the terminal-local Vselection_alist.
3814 (x_clear_frame_selections): Use Frun_hook_with_args.
3815
3816 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3817
3818 * xterm.h: Add support for those atoms.
3819
3820 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3821
3822 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3823 (converted_selections, conversion_fail_tag): New global variables.
3824 (x_selection_request_lisp_error): Free the above.
3825 (x_get_local_selection): Remove unnecessary code.
3826 (x_reply_selection_request): Args changed; handle arbitrary array
3827 of converted selections stored in converted_selections.
3828 Separate the XChangeProperty and SelectionNotify steps.
3829 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3830 (x_convert_selection): New function.
3831 (x_handle_selection_event): Simplify.
3832 (x_get_foreign_selection): Don't ignore incoming requests while
3833 waiting for an answer; this will fail when we implement
3834 SAVE_TARGETS, and seems unnecessary anyway.
3835 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3836 (Vx_sent_selection_functions): Doc fix.
3837
3838 2011-05-26 Leo Liu <sdl.web@gmail.com>
3839
3840 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3841
3842 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3843
3844 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3845
3846 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3847 for fringe update if it has periodic bitmap.
3848 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3849 and fringe_bitmap_periodic_p.
3850
3851 * fringe.c (get_fringe_bitmap_data): New function.
3852 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3853 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3854 row. Mark glyph row for fringe update if periodicity changed.
3855
3856 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3857 for fringe update unless it has periodic bitmap.
3858
3859 2011-05-25 Kenichi Handa <handa@m17n.org>
3860
3861 * xdisp.c (get_next_display_element): Set correct it->face_id for
3862 a static composition.
3863
3864 2011-05-24 Leo Liu <sdl.web@gmail.com>
3865
3866 * deps.mk (fns.o):
3867 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3868
3869 * fns.c (crypto_hash_function, Fsha1): New function.
3870 (Fmd5): Use crypto_hash_function.
3871 (syms_of_fns): Add Ssha1.
3872
3873 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3874
3875 * gnutls.c: Remove unused macros.
3876 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3877 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3878 Remove macros that are defined and never used.
3879 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3880
3881 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3882
3883 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3884 (Fx_get_selection_internal): Minor cleanup.
3885 (Fx_own_selection_internal): Rename arguments for consistency with
3886 select.el.
3887
3888 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3889
3890 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3891
3892 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3893
3894 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3895
3896 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3897
3898 * dispnew.c (scrolling_window): Don't exclude the case that the
3899 last enabled row in the desired matrix touches the bottom boundary.
3900
3901 2011-05-21 Glenn Morris <rgm@gnu.org>
3902
3903 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3904 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3905 and add some more files.
3906
3907 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3908
3909 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3910 report_file_error introduced by the change from 2011-05-07.
3911
3912 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3913
3914 * systime.h (Time): Define only if emacs is defined.
3915 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3916 where the include path doesn't have X11/X.h by default. See
3917 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3918
3919 2011-05-20 Kenichi Handa <handa@m17n.org>
3920
3921 * composite.c (find_automatic_composition): Fix previous change.
3922
3923 2011-05-20 Glenn Morris <rgm@gnu.org>
3924
3925 * lisp.mk: New file, split from Makefile.in.
3926 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3927 (shortlisp): Remove.
3928 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3929
3930 2011-05-19 Glenn Morris <rgm@gnu.org>
3931
3932 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3933 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3934 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3935 (lisp): Set the order to that of loadup.el.
3936 (shortlisp): Make it a copy of $lisp.
3937 (SOME_MACHINE_LISP): Remove.
3938 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3939 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3940
3941 2011-05-18 Kenichi Handa <handa@m17n.org>
3942
3943 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3944 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3945 (find_automatic_composition): Mostly rewrite for efficiency.
3946
3947 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3948
3949 * makefile.w32-in: Update dependencies.
3950
3951 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3952
3953 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3954 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3955
3956 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Fix some integer overflow issues, such as string length overflow.
3959
3960 * insdel.c (count_size_as_multibyte): Check for string overflow.
3961
3962 * character.c (lisp_string_width): Check for string overflow.
3963 Use EMACS_INT, not int, for string indexes and lengths; in
3964 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3965 the resulting string length overflows an EMACS_INT; instead,
3966 report a string overflow if no precision given. When checking for
3967 precision exhaustion, use a check that cannot possibly have
3968 integer overflow. (Bug#8675)
3969 * character.h (lisp_string_width): Adjust to new signature.
3970
3971 * alloc.c (string_overflow): New function.
3972 (Fmake_string): Use it. This doesn't change behavior, but saves
3973 a few bytes and will simplify future changes.
3974 * character.c (string_escape_byte8): Likewise.
3975 * lisp.h (string_overflow): New decl.
3976
3977 Fixups, following up to the user-interface timestamp change.
3978 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3979 for UI timestamps, instead of unsigned long.
3980 * msdos.c (mouse_get_pos): Likewise.
3981 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3982 * w32gui.h (Time): Define by including "systime.h" rather than by
3983 declaring it ourselves. (Bug#8664)
3984
3985 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3986 * image.c (clear_image_cache): Likewise.
3987
3988 * term.c (term_mouse_position): Don't assume time_t wraparound.
3989
3990 Be more systematic about user-interface timestamps.
3991 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3992 and sometimes 'EMACS_UINT', to represent these timestamps.
3993 This change causes it to use 'Time' uniformly, as that's what X uses.
3994 This makes the code easier to follow, and makes it easier to catch
3995 integer overflow bugs such as Bug#8664.
3996 * frame.c (Fmouse_position, Fmouse_pixel_position):
3997 Use Time, not unsigned long, for user-interface timestamps.
3998 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3999 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4000 * keyboard.h (last_event_timestamp): Likewise.
4001 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4002 * menu.h (xmenu_show): Likewise.
4003 * term.c (term_mouse_position): Likewise.
4004 * termhooks.h (struct input_event.timestamp): Likewise.
4005 (struct terminal.mouse_position_hook): Likewise.
4006 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4007 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4008 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4009 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4010 what it was before.
4011 * menu.h, termhooks.h: Include "systime.h", for Time.
4012
4013 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4014 Don't assume that the difference between two unsigned long values
4015 can fit into an integer. At this point, we know button_down_time
4016 <= event->timestamp, so the difference must be nonnegative, so
4017 there's no need to cast the result if double-click-time is
4018 nonnegative, as it should be; check that it's nonnegative, just in
4019 case. This bug is triggered when events are more than 2**31 ms
4020 apart (about 25 days). (Bug#8664)
4021
4022 * xselect.c (last_event_timestamp): Remove duplicate decl.
4023 (x_own_selection): Remove needless cast to unsigned long.
4024
4025 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4026 that always fit in int. Use a sentinel instead of a counter, to
4027 avoid a temp and to allay GCC's concerns about possible int overflow.
4028 * frame.h (struct frame): Use int for menu_bar_items_used
4029 instead of EMACS_INT, since it always fits in int.
4030
4031 * menu.c (grow_menu_items): Check for int overflow.
4032
4033 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4034
4035 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4036 Before, the code was not consistent. These values cannot exceed
4037 2**31 - 1 so there's no need to make them unsigned.
4038 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4039 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4040 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4041 as modifiers.
4042 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4043
4044 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4045 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4046 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4047 presumably because the widths might not match.
4048
4049 * window.c (size_window): Avoid needless test at loop start.
4050
4051 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4052
4053 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4054
4055 2011-05-12 Drew Adams <drew.adams@oracle.com>
4056
4057 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4058
4059 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4060
4061 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4062 `width' to `bar_area_x' and `bar_area_width', respectively.
4063 (x_scroll_run): Take account of fringe background extension.
4064
4065 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4066 Rename local vars `left' and `width' to `bar_area_x' and
4067 `bar_area_width', respectively.
4068 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4069 background extension.
4070
4071 2011-05-10 Jim Meyering <meyering@redhat.com>
4072
4073 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4074
4075 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4076
4077 * image.c (Finit_image_library): Return t for built-in image types,
4078 like pbm and xbm. (Bug#8640)
4079
4080 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4081
4082 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4083
4084 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4085
4086 * w32console.c (Fset_screen_color): Doc fix.
4087 (Fget_screen_color): New function.
4088 (syms_of_ntterm): Defsubr it.
4089
4090 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4091 unlink the temporary file if Fcall_process didn't create it in the
4092 first place.
4093 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4094 child process will be redirected to a file specified with `:file'.
4095 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4096 cue to call_process_cleanup not to close that handle.
4097
4098 2011-05-07 Ben Key <bkey76@gmail.com>
4099
4100 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4101 one of two shell specific rules, either bootstrap-temacs-CMD or
4102 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4103 to the previous implementation of the bootstrap-temacs rule.
4104 The bootstrap-temacs-CMD rule is similar to the previous
4105 implementation of the bootstrap-temacs rule except that it
4106 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4107 variable.
4108
4109 These changes, along with some changes to nt/configure.bat,
4110 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4111 earlier fix to add support for --cflags and --ldflags options
4112 that include quotes so that it works whether make uses cmd or
4113 sh as the shell.
4114
4115 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4116
4117 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4118 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4119 is a constant.
4120 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4121 a string. Handle both cases.
4122 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4123 (Fdbus_register_method): Use Qinvalid_function.
4124
4125 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4126
4127 * makefile.w32-in: Update dependencies.
4128 (LISP_H): Add inttypes.h and stdin.h.
4129 (PROCESS_H): Add unistd.h.
4130
4131 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4132
4133 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4134 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4135
4136 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4137
4138 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4139
4140 * term.c (vfatal): Remove stray call to va_end.
4141 It's not needed and the C Standard doesn't allow it here anyway.
4142
4143 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4144 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4145
4146 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4147 bytes.
4148
4149 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4150
4151 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4152
4153 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4154
4155 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4156
4157 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4158
4159 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4160 * charset.c (Fdefine_charset_internal): Don't initialize
4161 charset.code_space[15]. The value was garbage, on hosts with
4162 32-bit int (Bug#8600).
4163
4164 * lread.c (read_integer): Be more consistent with string-to-number.
4165 Use string_to_number to do the actual conversion; this avoids
4166 rounding errors and fixes some other screwups. Without this fix,
4167 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4168 (digit_to_number): Move earlier, for benefit of read_integer.
4169 Return -1 if the digit is out of range for the base, -2 if it is
4170 not a digit in any supported base. (Bug#8602)
4171
4172 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4173
4174 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4175 to match comment at start of function. This also removes a
4176 GCC warning about overflow in a 32+64-bit port.
4177
4178 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4179
4180 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4181 Reported by Stefan Monnier in
4182 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4183 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4184 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4185
4186 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4187 (EMACS_UINTPTR): Likewise, with uintptr_t.
4188
4189 * lisp.h: Prefer 64-bit EMACS_INT if available.
4190 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4191 on 32-bit hosts that have 64-bit int, so that they can access
4192 large files.
4193 However, temporarily disable this change unless the temporary
4194 symbol WIDE_EMACS_INT is defined.
4195
4196 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4197
4198 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4199 This removes an assumption that EMACS_INT and long are the same
4200 width as pointers. The assumption is true for Emacs porting targets
4201 now, but we want to make other targets possible.
4202 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4203 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4204 In the rest of the code, change types of integers that hold casted
4205 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4206 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4207 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4208 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4209 No need to cast type when ORing.
4210 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4211 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4212 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4213 assume EMACS_INT is the same width as char *.
4214 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4215 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4216 Remove no-longer-needed casts.
4217 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4218 (xg_tool_bar_help_callback, xg_make_tool_item):
4219 Use EMACS_INTPTR to hold an integer
4220 that will be cast to void *; this can avoid a GCC warning
4221 if EMACS_INT is not the same width as void *.
4222 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4223 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4224 (current_message_1, set_message_1):
4225 Use a local to convert to proper width without a cast.
4226 * xmenu.c (dialog_selection_callback): Likewise.
4227
4228 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4229 Also, don't assume VALBITS / RAND_BITS is less than 5,
4230 and don't rely on undefined behavior when shifting a 1 left into
4231 the sign bit.
4232 * lisp.h (get_random): Change signature to match.
4233
4234 * lread.c (hash_string): Use size_t, not int, for hash computation.
4235 Normally we prefer signed values; but hashing is special, because
4236 it's better to use unsigned division on hash table sizes so that
4237 the remainder is nonnegative. Also, size_t is the natural width
4238 for hashing into memory. The previous code used 'int', which doesn't
4239 retain enough info to hash well into very large tables.
4240 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4241
4242 * dbusbind.c: Don't possibly lose pointer info when converting.
4243 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4244 Use XPNTR rather than XHASH, so that the high-order bits of
4245 the pointer aren't lost when converting through void *.
4246
4247 * eval.c (Fautoload): Don't double-shift a pointer.
4248
4249 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4250
4251 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4252
4253 * gnutls.c (DEF_GNUTLS_FN):
4254 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4255
4256 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4257
4258 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4259 marker. (Bug#8610)
4260
4261 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4262
4263 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4264 New version that can reserve upto 2GB of heap space.
4265
4266 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4267
4268 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4269
4270 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4271
4272 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4273 `gnutls_certificate_set_x509_key_file'.
4274
4275 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4278 Update dependencies.
4279
4280 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4281
4282 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4283 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4284 Remove unused parameter `fildes'.
4285 * process.c (read_process_output, send_process): Don't pass it.
4286
4287 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4288
4289 Fix previous change: the library cache is defined in w32.c.
4290 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4291 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4292
4293 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4294
4295 Implement dynamic loading of GnuTLS on Windows.
4296
4297 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4298 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4299 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4300 Declare.
4301
4302 * gnutls.c (Qgnutls_dll): Define.
4303 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4304 (gnutls_*): Declare function pointers.
4305 (init_gnutls_functions): New function to initialize function pointers.
4306 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4307 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4308 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4309 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4310 (emacs_gnutls_write, emacs_gnutls_read)
4311 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4312 (Fgnutls_available_p): New function.
4313 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4314 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4315 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4316
4317 * image.c: Include w32.h.
4318 (Vimage_type_cache): Delete.
4319 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4320 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4321 (w32_delayed_load): Move to w32.c.
4322
4323 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4324
4325 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4326 (w32_delayed_load): Move from image.c. When loading a library, record
4327 its filename in the :loaded-from property of the library id.
4328 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4329 Initialize and staticpro them.
4330 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4331
4332 * process.c: Include lisp.h before w32.h, not after.
4333 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4334 instead of gnutls_record_check_pending.
4335
4336 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4337
4338 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4339
4340 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4341 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4342 as passed in.
4343
4344 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4345
4346 * xterm.c (x_set_frame_alpha): Do not set property on anything
4347 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4348
4349 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4350
4351 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4352
4353 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4354
4355 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4356 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4357 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4358 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4359 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4360 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4361 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4362 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4363 (Qgnutls_bootprop_callbacks_verify): Make static.
4364
4365 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4366
4367 * callproc.c: Indentation fixup.
4368
4369 * sysdep.c (wait_for_termination_1): Make static.
4370 (wait_for_termination, interruptible_wait_for_termination):
4371 Move after wait_for_termination_1.
4372
4373 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4374
4375 * sysdep.c (interruptible_wait_for_termination): New function
4376 which is like wait_for_termination, but allows keyboard
4377 interruptions.
4378
4379 * callproc.c (Fcall_process): Add (:file "file") as an option for
4380 the STDOUT buffer.
4381 (Fcall_process_region): Ditto.
4382
4383 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4384
4385 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4386 rather than `XVECTOR (FOO)->size'.
4387
4388 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4389 inttypes.h, as a gnulib replacement is used if it not available in
4390 system headers.
4391
4392 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4393
4394 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4395 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4396 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4397
4398 * coding.c (coding_alloc_by_realloc): Error out if destination
4399 will grow beyond MOST_POSITIVE_FIXNUM.
4400 (decode_coding_emacs_mule): Abort if there isn't enough place in
4401 charbuf for the composition carryover bytes. Reserve an extra
4402 space for up to 2 characters produced in a loop.
4403 (decode_coding_iso_2022): Abort if there isn't enough place in
4404 charbuf for the composition carryover bytes.
4405
4406 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4407
4408 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4409 aborting when %lld or %lll format is passed.
4410 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4411 %llo or %llx format is passed. (Bug#8545)
4412
4413 * window.c (window_scroll_line_based): Use a marker instead of
4414 simple variables to record original value of point. (Bug#7952)
4415
4416 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4417 produced by %s or %c overflows available buffer space. (Bug#8545)
4418
4419 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4420
4421 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4422 (SIZE_MAX): Move defn after all includes, as they might #define it.
4423
4424 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4425
4426 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4427
4428 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4429
4430 * keyboard.c (Qdelayed_warnings_hook): Define.
4431 (command_loop_1): Run `delayed-warnings-hook'
4432 if Vdelayed_warnings_list is non-nil.
4433 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4434 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4435
4436 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4437
4438 * doprnt.c (doprnt): Don't return value smaller than the buffer
4439 size if the message was truncated. (Bug#8545).
4440
4441 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4442
4443 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4444 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4445
4446 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4449
4450 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4451
4452 * makefile.w32-in: Update dependencies.
4453
4454 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4455
4456 Improve `doprnt' and its usage. (Bug#8545)
4457 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4458 `format_end'. Remove support for %l as a conversion specifier.
4459 Don't use xrealloc. Improve diagnostics when the %l size modifier
4460 is used. Update the commentary.
4461
4462 * eval.c (verror): Simplify calculation of size_t.
4463
4464 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4465 messages.
4466
4467 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4468
4469 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4470 change.
4471
4472 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4475 This makes this file independent of the recent pseudovector change.
4476
4477 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4478
4479 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4480
4481 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4482 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4483 Remove unused local.
4484 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4485
4486 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4487 GCC 4.6.0 optimizes based on type-based alias analysis.
4488 For example, if b is of type struct buffer * and v of type struct
4489 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4490 != &v->size, and therefore "v->size = 1; b->size = 2; return
4491 v->size;" must therefore return 1. This assumption is incorrect
4492 for Emacs, since it type-puns struct Lisp_Vector * with many other
4493 types. To fix this problem, this patch adds a new type struct
4494 vectorlike_header that documents the constraints on layout of vectors
4495 and pseudovectors, and helps optimizing compilers not get fooled
4496 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4497 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4498 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4499 the size member.
4500 (XSETPVECTYPE): Rewrite in terms of new macro.
4501 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4502 This is a bit clearer, and further avoids the possibility of
4503 undesirable aliasing.
4504 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4505 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4506 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4507 since Lisp_Subr is a special case (no "next" field).
4508 (ASIZE): Now uses header.size rather than size.
4509 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4510 to avoid the hassle of writing XVECTOR (foo)->header.size.
4511 (struct vectorlike_header): New type.
4512 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4513 object, to help avoid aliasing.
4514 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4515 (SUBRP): Likewise, since Lisp_Subr is a special case.
4516 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4517 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4518 (struct Lisp_Hash_Table): Combine first two members into a single
4519 struct vectorlike_header member. All uses of "size" and "next" members
4520 changed to be "header.size" and "header.next".
4521 * buffer.h (struct buffer): Likewise.
4522 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4523 * frame.h (struct frame): Likewise.
4524 * process.h (struct Lisp_Process): Likewise.
4525 * termhooks.h (struct terminal): Likewise.
4526 * window.c (struct save_window_data, struct saved_window): Likewise.
4527 * window.h (struct window): Likewise.
4528 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4529 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4530 * buffer.c (init_buffer_once): Likewise.
4531 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4532 special case.
4533 * process.c (Fformat_network_address): Use local var for size,
4534 for brevity.
4535
4536 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4537
4538 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4539 * data.c (atof): Remove decl; no longer used or needed.
4540 (digit_to_number): Move to lread.c.
4541 (Fstring_to_number): Use new string_to_number function, to be
4542 consistent with how the Lisp reader treats infinities and NaNs.
4543 Do not assume that floating-point numbers represent EMACS_INT
4544 without losing information; this is not true on most 64-bit hosts.
4545 Avoid double-rounding errors, by insisting on integers when
4546 parsing non-base-10 numbers, as the documentation specifies.
4547 * lisp.h (string_to_number): New decl, replacing ...
4548 (isfloat_string): Remove.
4549 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4550 (read1): Do not accept +. and -. as integers; this
4551 appears to have been a coding error. Similarly, do not accept
4552 strings like +-1e0 as floating point numbers. Do not report
4553 overflow for integer overflows unless the base is not 10 which
4554 means we have no simple and reliable way to continue.
4555 Break out the floating-point parsing into a new
4556 function string_to_number, so that Fstring_to_number parses
4557 floating point numbers consistently with the Lisp reader.
4558 (digit_to_number): Move here from data.c. Make it static inline.
4559 (E_CHAR, EXP_INT): Remove, replacing with ...
4560 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4561 (string_to_number): New function, replacing isfloat_string.
4562 This function checks for valid syntax and produces the resulting
4563 Lisp float number too. Rework it so that string-to-number
4564 no longer mishandles examples like "1.0e+". Use strtoumax,
4565 so that overflow for non-base-10 numbers is reported only when
4566 there's no portable and simple way to convert to floating point.
4567
4568 * textprop.c (set_text_properties_1): Rewrite for clarity,
4569 and to avoid GCC warning about integer overflow.
4570
4571 * intervals.h (struct interval): Use EMACS_INT for members
4572 where EMACS_UINT might cause problems. See
4573 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4574 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4575 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4576 All uses changed.
4577 (offset_intervals): Tell GCC not to worry about length overflow
4578 when negating a negative length.
4579
4580 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4581 (overrun_check_free): Likewise.
4582
4583 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4584 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4585 word size.
4586
4587 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4588 (gnutls_make_error): Rename local to avoid shadowing.
4589 (gnutls_emacs_global_deinit): ifdef out; not used.
4590 (Fgnutls_boot): Use const for pointer to readonly storage.
4591 Comment out unused local. Fix pointer signedness problems.
4592
4593 * lread.c (openp): Don't stuff size_t into an 'int'.
4594 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4595 about possible signed overflow.
4596
4597 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4598 (GDK_KEY_g): Don't define if already defined.
4599 (xg_prepare_tooltip): Avoid pointer signedness problem.
4600 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4601
4602 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4603 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4604
4605 * xfns.c (Fx_window_property): Simplify a bit,
4606 to make a bit faster and to avoid GCC 4.6.0 warning.
4607 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4608
4609 * fns.c (internal_equal): Don't assume size_t fits in int.
4610
4611 * alloc.c (compact_small_strings): Tighten assertion a little.
4612
4613 Replace pEd with more-general pI, and fix some printf arg casts.
4614 * lisp.h (pI): New macro, generalizing old pEd macro to other
4615 conversion specifiers. For example, use "...%"pI"d..." rather
4616 than "...%"pEd"...".
4617 (pEd): Remove. All uses replaced with similar uses of pI.
4618 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4619 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4620 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4621 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4622 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4623 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4624 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4625 64-bit hosts.
4626 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4627 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4628 * print.c (safe_debug_print, print_object): Likewise.
4629 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4630 to int.
4631 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4632 avoiding the 0 flag, which is not portable.
4633 * process.c (Fmake_network_process): Use pI to avoid cast.
4634 * region-cache.c (pp_cache): Likewise.
4635 * xdisp.c (decode_mode_spec): Likewise.
4636 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4637 behavior on 64-bit hosts with printf arg.
4638 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4639 (x_stop_queuing_selection_requests): Likewise.
4640 (x_get_window_property): Don't truncate byte count to an 'int'
4641 when tracing.
4642
4643 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4644 here, since it parses constructs like leading '-' and spaces,
4645 which are not wanted; and it overflows with large numbers.
4646 Instead, simply match F[0-9]+, which is what is wanted anyway.
4647
4648 * alloc.c: Remove unportable assumptions about struct layout.
4649 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4650 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4651 (allocate_vectorlike, make_pure_vector): Use the new macros,
4652 plus offsetof, to remove unportable assumptions about struct layout.
4653 These assumptions hold on all porting targets that I know of, but
4654 they are not guaranteed, they're easy to remove, and removing them
4655 makes further changes easier.
4656
4657 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4658 This doesn't fix a bug but makes the code clearer.
4659 (string_overrun_cookie): Now const. Use initializers that
4660 don't formally overflow signed char, to avoid warnings.
4661 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4662 can cause Emacs to crash when string overrun checking is enabled.
4663 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4664 multiple of sizeof (EMACS_INT); it need not be, if
4665 alignof(EMACS_INT) < sizeof (EMACS_INT).
4666 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4667
4668 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4669
4670 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4671
4672 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4673
4674 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4675 supposed to be handshaking. (Bug#8556)
4676 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4677
4678 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4679
4680 * lisp.h (Qdebug): List symbol.
4681 * eval.c (Qdebug): Restore global linkage.
4682 * keyboard.c (debug-on-event): New variable.
4683 (handle_user_signal): Break into debugger when debug-on-event
4684 matches the current signal symbol.
4685
4686 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4687
4688 * alloc.c (check_sblock, check_string_bytes)
4689 (check_string_free_list): Convert to standard C.
4690
4691 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4692
4693 * w32.c (emacs_gnutls_push): Fix typo.
4694
4695 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4696
4697 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4698 "cast to pointer from integer of different size".
4699
4700 Improve doprnt and its use in verror. (Bug#8545)
4701 * doprnt.c (doprnt): Document the set of format control sequences
4702 supported by the function. Use SAFE_ALLOCA instead of always
4703 using `alloca'.
4704
4705 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4706 is one byte too soon. Don't use xrealloc; instead xfree and
4707 xmalloc anew.
4708
4709 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4710
4711 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4712 callbacks stage.
4713
4714 * gnutls.c: Renamed global_initialized to
4715 gnutls_global_initialized. Added internals for the
4716 :verify-hostname-error, :verify-error, and :verify-flags
4717 parameters of `gnutls-boot' and documented those parameters in the
4718 docstring. Start callback support.
4719 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4720 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4721 on error. Return error code.
4722 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4723 (emacs_gnutls_read): Likewise.
4724 (Fgnutls_boot): Return handshake error code.
4725 (emacs_gnutls_handle_error): New function.
4726 (wsaerror_to_errno): Likewise.
4727
4728 * w32.h (emacs_gnutls_pull): Add prototype.
4729 (emacs_gnutls_push): Likewise.
4730
4731 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4732 (emacs_gnutls_push): Likewise.
4733
4734 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4735
4736 * process.c (wait_reading_process_output): Check if GnuTLS
4737 buffered some data internally if no FDs are set for TLS
4738 connections.
4739
4740 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4741 (LIBS): Link to USER_LIBS.
4742 ($(BLD)/gnutls.$(0)): New target.
4743
4744 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4745
4746 * xdisp.c (handle_single_display_spec): Rename the
4747 display_replaced_before_p argument into display_replaced_p, to
4748 make it consistent with the commentary. Fix typos in the
4749 commentary.
4750
4751 * textprop.c (syms_of_textprop): Remove dead code.
4752 (copy_text_properties): Delete obsolete commentary about an
4753 interface that was deleted long ago. Fix typos in the description
4754 of arguments.
4755
4756 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4757 to changes in oldXMenu/XMenu.h from 2011-04-16.
4758 <menu_help_message, prev_menu_help_message>: Constify.
4759 (IT_menu_make_room): menu->help_text is now `const char **';
4760 adjust.
4761
4762 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4763 to changes in oldXMenu/XMenu.h from 2011-04-16.
4764 (struct XMenu): Declare `help_text' `const char **'.
4765
4766 * xfaces.c <Qunspecified>: Make extern again.
4767
4768 * syntax.c: Include sys/types.h before including regex.h, as
4769 required by Posix.
4770
4771 * doc.c (get_doc_string): Improve the format passed to `error'.
4772
4773 * doprnt.c (doprnt): Improve commentary.
4774
4775 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4776
4777 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4778 them with etags.
4779
4780 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4781 changes in globals.h immediately force recompilation.
4782 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4783 $(CURDIR)/s/ms-w32.h.
4784 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4785
4786 * character.c (Fchar_direction): Function deleted.
4787 (syms_of_character): Don't defsubr it.
4788 <char-direction-table>: Deleted.
4789
4790 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4791
4792 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4793 * doprnt.c: Include limits.h.
4794 (SIZE_MAX): New macro.
4795 (doprnt): Return a size_t value. 2nd arg is now size_t.
4796 Many local variables are now size_t instead of int or unsigned.
4797 Improve overflow protection. Support `l' modifier for integer
4798 conversions. Support %l conversion. Don't assume an EMACS_INT
4799 argument for integer conversions and for %c.
4800
4801 * lisp.h (doprnt): Restore prototype.
4802
4803 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4804 $(SRC)/character.h.
4805
4806 * Makefile.in (base_obj): Add back doprnt.o.
4807
4808 * deps.mk (doprnt.o): Add back prerequisites.
4809 (callint.o): Depend on character.h.
4810
4811 * eval.c (internal_lisp_condition_case): Include the handler
4812 representation in the error message.
4813 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4814 when breaking from the loop.
4815
4816 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4817
4818 * callint.c (Fcall_interactively): When displaying error message
4819 about invalid control letter, pass the character's codepoint, not
4820 a pointer to its multibyte form. Improve display of the character
4821 in octal and display also its hex code.
4822
4823 * character.c (char_string): Use %x to display the (unsigned)
4824 codepoint of an invalid character, to avoid displaying a bogus
4825 negative value.
4826
4827 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4828 `error', not SYMBOL_NAME itself.
4829
4830 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4831 character arguments to `error'.
4832
4833 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4834 to `error' in error message about FINAL_CHAR argument. Make sure
4835 FINAL_CHAR is a character, and use %c when it is passed as
4836 argument to `error'.
4837
4838 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4839
4840 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4841
4842 * w32.c: Include <time.h>.
4843 (sys_localtime): New function.
4844
4845 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4846
4847 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4848
4849 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4850
4851 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4852
4853 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4854 zombies (Bug#8467).
4855
4856 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4857
4858 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4859 gl_state.e_property when gl_state.object is Qt.
4860
4861 * insdel.c (make_gap_larger): Remove limitation of buffer size
4862 to <= INT_MAX.
4863
4864 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4865
4866 * xdisp.c (lookup_glyphless_char_display)
4867 (produce_glyphless_glyph): Handle cons cell entry in
4868 glyphless-char-display.
4869 (Vglyphless_char_display): Document it.
4870
4871 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4872 glyphless-char-display.
4873
4874 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4875
4876 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4877
4878 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4879
4880 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4881 definition for no-X builds.
4882
4883 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4884
4885 Static checks with GCC 4.6.0 and non-default toolkits.
4886
4887 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4888
4889 * process.c (keyboard_bit_set): Define only if SIGIO.
4890 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4891 (send_process): Repair possible setjmp clobbering.
4892
4893 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4894
4895 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4896
4897 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4898
4899 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4900 Define only if needed.
4901
4902 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4903 by pacifying GCC about it. Maybe it's time to retire it?
4904 * xfaces.c (USG, __TIMEVAL__): Likewise.
4905
4906 * dispextern.h (struct redisplay_interface): Rename param
4907 to avoid shadowing.
4908 * termhooks.h (struct terminal): Likewise.
4909 * xterm.c (xembed_send_message): Likewise.
4910
4911 * insdel.c (make_gap_smaller): Define only if
4912 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4913
4914 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4915 it.
4916
4917 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4918 so that we aren't warned about unused symbols.
4919
4920 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4921
4922 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4923
4924 * xfns.c (x_real_positions): Mark locals as initialized.
4925
4926 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4927
4928 * xterm.c: Fix problems found by static analysis with other toolkits.
4929 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4930 (x_dispatch_event): Declare static if USE_GTK, and
4931 define if USE_GTK || USE_X_TOOLKIT.
4932 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4933 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4934 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4935 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4936
4937 * xmenu.c (menu_help_callback): Pointer type fixes.
4938 Use const pointers when pointing at readonly data. Avoid pointer
4939 signedness clashes.
4940 (FALSE): Remove unused macro.
4941 (update_frame_menubar): Remove unused decl.
4942
4943 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4944
4945 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4946 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4947 (single_menu_item): Rename local to avoid shadowing.
4948
4949 * keyboard.c (make_lispy_event): Remove unused local var.
4950
4951 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4952 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4953
4954 * bitmaps: Change bitmaps from unsigned char back to the X11
4955 compatible char. Avoid the old compiler warnings about
4956 out-of-range initializers by using, for example, '\xab' rather
4957 than 0xab.
4958
4959 * xgselect.c (xgselect_initialize): Check vs interface
4960 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4961
4962 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4963
4964 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4965 to read-only memory.
4966
4967 * fns.c (vector): Remove; this old hack is no longer needed.
4968
4969 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4970 Remove unused var.
4971 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4972
4973 * xrdb.c (x_load_resources): Omit unused local.
4974
4975 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4976 (x_window): Rename locals to avoid shadowing.
4977 (USG): Use the kludged USG macro, to pacify gcc.
4978
4979 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4980 (x_term_init): Remove local to avoid shadowing.
4981
4982 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4983
4984 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4985 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4986
4987 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4988
4989 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4990
4991 Fix regex.c, syntax.c and friends for buffers > 2GB.
4992 * syntax.h (struct gl_state_s): Declare character position members
4993 EMACS_INT.
4994
4995 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4996
4997 * textprop.c (verify_interval_modification, interval_of):
4998 Declare arguments EMACS_INT.
4999
5000 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5001 EMACS_INT.
5002
5003 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5004
5005 * indent.c (Fvertical_motion): Local variable it_start is now
5006 EMACS_INT.
5007
5008 * regex.c (re_match, re_match_2, re_match_2_internal)
5009 (bcmp_translate, regcomp, regexec, print_double_string)
5010 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5011 (re_compile_pattern, re_exec): Declare arguments and local
5012 variables `size_t' and `ssize_t' and return values `regoff_t', as
5013 appropriate.
5014 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5015 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5016 <compile_stack_type>: `size' and `avail' are now `size_t'.
5017
5018 * regex.h <regoff_t>: Use ssize_t, not int.
5019 (re_search, re_search_2, re_match, re_match_2): Arguments that
5020 specify buffer/string position and length are now ssize_t and
5021 size_t. Return type is regoff_t.
5022
5023 2011-04-16 Ben Key <bkey76@gmail.com>
5024
5025 * nsfont.m: Fixed bugs in ns_get_family and
5026 ns_descriptor_to_entity that were caused by using free to
5027 deallocate memory blocks that were allocated by xmalloc (via
5028 xstrdup). This caused Emacs to crash when compiled with
5029 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5030 --enable-checking=xmallocoverrun). xfree is now used to
5031 deallocate these memory blocks.
5032
5033 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5034
5035 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5036
5037 emacs_write: Accept and return EMACS_INT for sizes.
5038 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5039 et seq.
5040 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5041 Accept and return EMACS_INT.
5042 (emacs_gnutls_write): Return the number of bytes written on
5043 partial writes.
5044 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5045 (emacs_read, emacs_write): Remove check for negative size, as the
5046 Emacs source code has been audited now.
5047 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5048 (emacs_read, emacs_write): Use it.
5049 * process.c (send_process): Adjust to the new signatures of
5050 emacs_write and emacs_gnutls_write. Do not attempt to store
5051 a byte offset into an 'int'; it might overflow.
5052 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5053
5054 * sound.c: Don't assume sizes fit in 'int'.
5055 (struct sound_device.period_size, alsa_period_size):
5056 Return EMACS_INT, not int.
5057 (struct sound_device.write, vox_write, alsa_write):
5058 Accept EMACS_INT, not int.
5059 (wav_play, au_play): Use EMACS_INT to store sizes and to
5060 record read return values.
5061
5062 2011-04-15 Ben Key <bkey76@gmail.com>
5063
5064 * keyboard.c (Qundefined): Don't declare static since it is used
5065 in nsfns.m.
5066 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5067 static since they are used in nsfont.m.
5068
5069 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5070
5071 * process.c (Qprocessp): Don't declare static.
5072 * lisp.h (Qprocessp): Declare again.
5073
5074 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5075
5076 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5077
5078 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5079
5080 Improve C-level modularity by making more things 'static'.
5081
5082 Don't publish debugger-only interfaces to other modules.
5083 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5084 (verify_bytepos, count_markers): Move decls to the only modules
5085 that need them.
5086 * region-cache.h (pp_cache): Likewise.
5087 * window.h (check_all_windows): Likewise.
5088 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5089
5090 * sysdep.c (croak): Now static, if
5091 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5092 * syssignal.h (croak): Declare only if not static.
5093
5094 * alloc.c (refill_memory_reserve): Now static if
5095 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5096 * lisp.h (refill_memory_reserve): Declare only if not static.
5097
5098 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5099 Define only if USE_LUCID.
5100
5101 * xrdb.c (x_customization_string, x_rm_string): Now static.
5102
5103 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5104 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5105
5106 * xdisp.c (draw_row_with_mouse_face): Now static.
5107 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5108
5109 * window.h (check_all_windows): Mark externally visible.
5110
5111 * window.c (window_deletion_count): Now static.
5112
5113 * undo.c: Make symbols static if they're not exported.
5114 (last_undo_buffer, last_boundary_position, pending_boundary):
5115 Now static.
5116
5117 * textprop.c (interval_insert_behind_hooks): Now static.
5118 (interval_insert_in_front_hooks): Likewise.
5119
5120 * term.c: Make symbols static if they're not exported.
5121 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5122 (max_frame_lines, tty_set_terminal_modes):
5123 (tty_reset_terminal_modes, tty_turn_off_highlight):
5124 (get_tty_terminal): Now static.
5125 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5126 * termhooks.h (term_mouse_moveto): Do not declare if
5127 HAVE_WINDOW_SYSTEM.
5128 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5129 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5130
5131 * sysdep.c: Make symbols static if they're not exported.
5132 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5133 Now static.
5134 (sigprocmask_set, full_mask): Remove; unused.
5135 (wait_debugging): Mark as visible.
5136 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5137 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5138
5139 * syntax.c (syntax_temp): Define only if !__GNUC__.
5140
5141 * sound.c (current_sound_device, current_sound): Now static.
5142
5143 * search.c (searchbufs, searchbuf_head): Now static.
5144
5145 * scroll.c (scroll_cost): Remove; unused.
5146 * dispextern.h (scroll_cost): Remove decl.
5147
5148 * region-cache.h (pp_cache): Mark as externally visible.
5149
5150 * process.c: Make symbols static if they're not exported.
5151 (process_tick, update_tick, create_process, chan_process):
5152 (Vprocess_alist, proc_buffered_char, datagram_access):
5153 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5154 (deactivate_process): Mark defn as static, as well as decl.
5155 * lisp.h (create_process): Remove decl.
5156 * process.h (chan_process, Vprocess_alist): Remove decls.
5157
5158 * print.c: Make symbols static if they're not exported.
5159 (print_depth, new_backquote_output, being_printed, print_buffer):
5160 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5161 (print_interval, print_number_index, initial_stderr_stream):
5162 Now static.
5163 * lisp.h (Fprinc): Remove decl.
5164 (debug_output_compilation_hack): Mark as externally visible.
5165
5166 * sysdep.c (croak): Move decl from here to syssignal.h.
5167 * syssignal.h (croak): Put it here, so the API can be checked when
5168 'croak' is called from dissociate_if_controlling_tty.
5169
5170 * minibuf.c: Make symbols static if they're not exported.
5171 (minibuf_save_list, choose_minibuf_frame): Now static.
5172 * lisp.h (choose_minibuf_frame): Remove decl.
5173
5174 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5175
5176 * lread.c: Make symbols static if they're not exported.
5177 (read_objects, initial_obarray, oblookup_last_bucket_number):
5178 Now static.
5179 (make_symbol): Remove; unused.
5180 * lisp.h (initial_obarray, make_symbol): Remove decls.
5181
5182 * keyboard.c: Make symbols static if they're not exported.
5183 (single_kboard, recent_keys_index, total_keys, recent_keys):
5184 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5185 (this_single_command_key_start, echoing, last_auto_save):
5186 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5187 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5188 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5189 (Vlispy_mouse_stem, double_click_count):
5190 Now static.
5191 (force_auto_save_soon): Define only if SIGDANGER.
5192 (ignore_mouse_drag_p): Now static if
5193 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5194 (print_help): Remove; unused.
5195 (stop_character, last_timer_event): Mark as externally visible.
5196 * keyboard.h (ignore_mouse_drag_p): Declare only if
5197 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5198 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5199 * lisp.h (echoing): Remove decl.
5200 (force_auto_save_soon): Declare only if SIGDANGER.
5201 * xdisp.c (redisplay_window): Simplify code, to make it more
5202 obvious that ignore_mouse_drag_p is not accessed if !defined
5203 USE_GTK && !defined HAVE_NS.
5204
5205 * intervals.c: Make symbols static if they're not exported.
5206 (merge_properties_sticky, merge_interval_right, delete_interval):
5207 Now static.
5208 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5209
5210 * insdel.c: Make symbols static if they're not exported.
5211 However, leave prepare_to_modify_buffer alone. It's never
5212 called from outside this function, but that appears to be a bug.
5213 (combine_after_change_list, combine_after_change_buffer):
5214 (adjust_after_replace, signal_before_change): Now static.
5215 (adjust_after_replace_noundo): Remove; unused.
5216 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5217 (signal_before_change): Remove decls.
5218
5219 * indent.c (val_compute_motion, val_vmotion): Now static.
5220
5221 * image.c: Make symbols static if they're not exported.
5222 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5223 if USE_GTK.
5224 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5225 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5226
5227 * fringe.c (standard_bitmaps): Now static.
5228 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5229
5230 * frame.c: Make symbols static if they're not exported.
5231 (x_report_frame_params, make_terminal_frame): Now static.
5232 (get_frame_param): Now static, unless HAVE_NS.
5233 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5234 (x_get_resource_string): Remove; not used.
5235 * frame.h (make_terminal_frame, x_report_frame_params):
5236 (x_get_resource_string); Remove decls.
5237 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5238 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5239
5240 * font.c, fontset.c: Make symbols static if they're not exported.
5241 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5242 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5243 * font.c (font_close_object): Now static.
5244 * font.h (font_close_object): Remove.
5245 * fontset.c (FONTSET_OBJLIST): Remove.
5246 (free_realized_fontset) #if-0 the body, which does nothing.
5247 (face_suitable_for_char_p): #if-0, as it's never called.
5248 * fontset.h (face_suitable_for_char_p): Remove decl.
5249 * xfaces.c (face_at_string_position):
5250 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5251 since 0 is always ASCII.
5252
5253 * fns.c (weak_hash_tables): Now static.
5254
5255 * fileio.c: Make symbols static if they're not exported.
5256 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5257 (Vwrite_region_annotation_buffers): Now static.
5258
5259 * eval.c: Make symbols static if they're not exported.
5260 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5261 * lisp.h (backtrace_list): Remove decl.
5262
5263 * emacs.c: Make symbols static if they're not exported.
5264 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5265 (fatal_error_code, fatal_error_signal_hook, standard_args):
5266 Now static.
5267 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5268 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5269 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5270 * lisp.h (fatal_error_signal_hook): Remove decl.
5271 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5272
5273 * editfns.c: Move a (normally-unused) function to its only use.
5274 * editfns.c, lisp.h (get_operating_system_release): Remove.
5275 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5276 worth the hassle of breaking this out.
5277
5278 * xterm.c: Make symbols static if they're not exported.
5279 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5280 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5281 (x_destroy_window, x_delete_display):
5282 Now static.
5283 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5284 (x_mouse_leave): Remove; unused.
5285 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5286 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5287 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5288 Remove decls.
5289 (x_mouse_leave): Declare only if WINDOWSNT.
5290 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5291 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5292 USE_X_TOOLKIT.
5293
5294 * ftxfont.c: Make symbols static if they're not exported.
5295 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5296 HAVE_FREETYPE.
5297 * font.h (ftxfont_driver): Likewise.
5298
5299 * xfns.c: Make symbols static if they're not exported.
5300 (x_last_font_name, x_display_info_for_name):
5301 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5302 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5303 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5304 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5305 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5306 (last_show_tip_args): Now static.
5307 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5308 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5309 (x_screen_planes): Remove; unused.
5310 * dispextern.h (x_screen_planes): Remove decl.
5311
5312 * dispnew.c: Make symbols static if they're not exported.
5313 * dispextern.h (redraw_garbaged_frames, scrolling):
5314 (increment_row_positions): Remove.
5315 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5316 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5317 Now static.
5318 (redraw_garbaged_frames): Remove; unused.
5319
5320 * xfaces.c: Make symbols static if they're not exported.
5321 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5322 Remove decls.
5323 * xterm.h (defined_color): Remove decls.
5324 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5325 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5326 (menu_face_changed_default, defined_color, free_realized_face):
5327 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5328 (ascii_face_of_lisp_face): Remove; unused.
5329
5330 * xdisp.c: Make symbols static if they're not exported.
5331 * dispextern.h (scratch_glyph_row, window_box_edges):
5332 (glyph_to_pixel_coords, set_cursor_from_row):
5333 (get_next_display_element, set_iterator_to_next):
5334 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5335 (show_mouse_face): Remove decls
5336 * frame.h (message_buf_print): Likewise.
5337 * lisp.h (pop_message, set_message, check_point_in_composition):
5338 Likewise.
5339 * xterm.h (set_vertical_scroll_bar): Likewise.
5340 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5341 (message_buf_print, scratch_glyph_row, displayed_buffer):
5342 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5343 (get_next_display_element, show_mouse_face, window_box_edges):
5344 (frame_to_window_pixel_xy, check_point_in_composition):
5345 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5346 (glyph_to_pixel_coords): Remove; unused.
5347
5348 * dired.c (file_name_completion): Now static.
5349
5350 * dbusbind.c (xd_in_read_queued_messages): Now static.
5351
5352 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5353 * data.c (circular_list_error): Remove.
5354
5355 * commands.h (last_point_position, last_point_position_buffer):
5356 (last_point_position_window): Remove decls.
5357 * keyboard.c: Make these variables static.
5358
5359 * coding.h (coding, code_convert_region, encode_coding_gap):
5360 Remove decls.
5361 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5362 (iso_code_class, detect_coding, code_convert_region): Now static.
5363 (encode_coding_gap): Remove; unused.
5364
5365 * chartab.c (chartab_chars, chartab_bits): Now static.
5366
5367 * charset.h (charset_iso_8859_1): Remove decl.
5368 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5369 Now static.
5370
5371 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5372 * ccl.c (Vccl_program_table): Now static.
5373 (check_ccl_update): Remove; unused.
5374
5375 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5376 * category.h: ... from here.
5377 * category.c (check_category_table, set_category_set): Now static.
5378
5379 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5380 * lisp.h: Remove these decls.
5381
5382 * buffer.c (buffer_count): Remove unused var.
5383
5384 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5385 so that it's not optimized away.
5386 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5387 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5388 exported only to the debugger.
5389
5390 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5391 * atimer.h (run_all_atimers): Remove; not exported.
5392
5393 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5394 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5395 was inaccessible from Lisp.
5396 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5397 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5398
5399 alloc.c: Import and export fewer symbols, and remove unused items.
5400 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5401 is defined.
5402 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5403 it's not optimized away by whole-program optimization.
5404 (message_enable_multibyte, free_misc): Remove.
5405 (catchlist, handlerlist, mark_backtrace):
5406 Declare only if BYTE_MARK_STACK.
5407 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5408 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5409 (message_enable_multibyte): Remove decl.
5410 (free_misc, interval_free_list, float_block, float_block_index):
5411 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5412 (cons_free_list, last_marked_index):
5413 Now static.
5414 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5415 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5416 (mark_backtrace): Define only if BYTE_MARK_STACK.
5417 * xdisp.c (message_enable_multibyte): Now static.
5418
5419 Declare Lisp_Object Q* variables to be 'static' if not exported.
5420 This makes it easier for human readers (and static analyzers)
5421 to see whether these variables are used from other modules.
5422 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5423 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5424 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5425 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5426 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5427 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5428 * xmenu.c, xselect.c:
5429 Declare Q* vars static if they are not used in other modules.
5430 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5431 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5432 Remove decls of unexported vars.
5433 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5434
5435 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5436
5437 Make Emacs functions such as Fatom 'static' by default.
5438 This makes it easier for human readers (and static analyzers)
5439 to see whether these functions can be called from other modules.
5440 DEFUN now defines a static function. To make the function external
5441 so that it can be used in other C modules, use the new macro DEFUE.
5442 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5443 (Finit_image_library):
5444 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5445 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5446 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5447 Remove decls, since these functions are now static.
5448 (Funintern, Fget_internal_run_time): New decls, since these functions
5449 were already external.
5450
5451 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5452 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5453 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5454 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5455 * keyboard.c, keymap.c, lread.c:
5456 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5457 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5458 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5459 Mark functions with DEFUE instead of DEFUN,
5460 if they are used in other modules.
5461 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5462 decls for now-static functions.
5463 * buffer.h (Fdelete_overlay): Remove decl.
5464 * callproc.c (Fgetenv_internal): Mark as internal.
5465 * composite.c (Fremove_list_of_text_properties): Remove decl.
5466 (Fcomposition_get_gstring): New forward static decl.
5467 * composite.h (Fcomposite_get_gstring): Remove decl.
5468 * dired.c (Ffile_attributes): New forward static decl.
5469 * doc.c (Fdocumntation_property): New forward static decl.
5470 * eval.c (Ffetch_bytecode): New forward static decl.
5471 (Funintern): Remove extern decl; now in .h file where it belongs.
5472 * fileio.c (Fmake_symbolic_link): New forward static decl.
5473 * image.c (Finit_image_library): New forward static decl.
5474 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5475 * intervals.h (Fprevious_property_change):
5476 (Fremove_list_of_text_properties): Remove decls.
5477 * keyboard.c (Fthis_command_keys): Remove decl.
5478 (Fcommand_execute): New forward static decl.
5479 * keymap.c (Flookup_key): New forward static decl.
5480 (Fcopy_keymap): Now static.
5481 * keymap.h (Flookup_key): Remove decl.
5482 * process.c (Fget_process): New forward static decl.
5483 (Fprocess_datagram_address): Mark as internal.
5484 * syntax.c (Fsyntax_table_p): New forward static decl.
5485 (skip_chars): Remove duplicate decl.
5486 * textprop.c (Fprevious_property_change): New forward static decl.
5487 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5488 Now internal.
5489 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5490 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5491
5492 * editfns.c (Fformat): Remove unreachable code.
5493
5494 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5495
5496 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5497 change. (Bug#8496)
5498
5499 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5500
5501 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5502 when at ZV. (Bug#8487)
5503
5504 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5505
5506 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5507 (Bug#8437)
5508 * keyboard.c (parse_tool_bar_item): Likewise.
5509 * sound.c (sound_cleanup, alsa_close): Likewise.
5510 * termcap.c (tgetent): Likewise.
5511 * xfns.c (x_default_font_parameter): Likewise.
5512 * xsettings.c (read_and_apply_settings): Likewise.
5513
5514 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5515 (overrun_check_free): Protoize.
5516
5517 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5518
5519 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5520 since callers should never pass a negative size.
5521 Change the signature to match that of plain 'read' and 'write'; see
5522 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5523 * lisp.h: Update prototypes of emacs_write and emacs_read.
5524
5525 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5526
5527 * xdisp.c (redisplay_window): Don't try to determine the character
5528 position of the scroll margin if the window start point w->startp
5529 is outside the buffer's accessible region. (Bug#8468)
5530
5531 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5532
5533 Fix write-region and its subroutines for buffers > 2GB.
5534 * fileio.c (a_write, e_write): Modify declaration of arguments and
5535 local variables to support buffers larger than 2GB.
5536 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5537
5538 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5539 argument, local variables, and return value.
5540
5541 * lisp.h: Update prototypes of emacs_write and emacs_read.
5542
5543 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5544
5545 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5546
5547 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5548
5549 Fix more problems found by GCC 4.6.0's static checks.
5550
5551 * xdisp.c (vmessage): Use a better test for character truncation.
5552
5553 * charset.c (load_charset_map): <, not <=, for optimization,
5554 and to avoid potential problems with integer overflow.
5555 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5556 * casetab.c (set_identity, shuffle): Likewise.
5557 * editfns.c (Fformat): Likewise.
5558 * syntax.c (skip_chars): Likewise.
5559
5560 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5561 This also lets GCC 4.6.0 generate slightly better loop code.
5562
5563 * callint.c (Fcall_interactively): <, not <=, for optimization.
5564 (Fcall_interactively): Count the number of arguments produced,
5565 not the number of arguments given. This is simpler and lets GCC
5566 4.6.0 generate slightly better code.
5567
5568 * ftfont.c: Distingish more carefully between FcChar8 and char.
5569 The previous code passed unsigned char * to a functions like
5570 strlen and xstrcasecmp that expect char *, which does not
5571 conform to the C standard.
5572 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5573 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5574 char * when the C standard requires it.
5575
5576 * keyboard.c (read_char): Remove unused var.
5577
5578 * eval.c: Port to Windows vsnprintf (Bug#8435).
5579 Include <limits.h>.
5580 (SIZE_MAX): Define if the headers do not.
5581 (verror): Do not give up if vsnprintf returns a negative count.
5582 Instead, grow the buffer. This ports to Windows vsnprintf, which
5583 does not conform to C99. Problem reported by Eli Zaretskii.
5584 Also, simplify the allocation scheme, by avoiding the need for
5585 calling realloc, and removing the ALLOCATED variable.
5586
5587 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5588
5589 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5590 But keep the doprint source code for now, as we might revamp it
5591 and use it again (Bug#8435).
5592 * lisp.h (doprnt): Remove.
5593 * Makefile.in (base_obj): Remove doprnt.o.
5594 * deps.mk (doprnt.o): Remove.
5595
5596 error: Print 32- and 64-bit integers portably (Bug#8435).
5597 Without this change, on typical 64-bit hosts error ("...%d...", N)
5598 was used to print both 32- and 64-bit integers N, which relied on
5599 undefined behavior.
5600 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5601 New macro.
5602 * lisp.h (error, verror): Mark as printf-like functions.
5603 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5604 Report overflow in size calculations when allocating printf buffer.
5605 Do not truncate output string at its first null byte.
5606 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5607 Truncate the output at a character boundary, since vsnprintf does not
5608 do that.
5609 * charset.c (check_iso_charset_parameter): Convert internal
5610 character to string before calling 'error', since %c now has the
5611 printf meaning.
5612 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5613 overflow when computing char to be passed to 'error'. Do not
5614 pass Lisp_Object to 'error'; pass the integer instead.
5615 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5616 formatted with plain %d.
5617
5618 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5619
5620 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5621
5622 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5623
5624 * xterm.c (x_catch_errors): Remove duplicate declaration.
5625
5626 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5627
5628 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5629
5630 2011-04-10 Jim Meyering <meyering@redhat.com>
5631
5632 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5633 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5634 return ssize_t not "int", and use size_t as the buffer length.
5635 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5636 * gnutls.h: Update declarations.
5637 * process.c (read_process_output): Use ssize_t, to match.
5638 (send_process): Likewise.
5639
5640 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5641
5642 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5643
5644 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5645
5646 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5647 Use unsigned char, to match FcChar8 type definition.
5648
5649 * xterm.c (handle_one_xevent):
5650 * xmenu.c (create_and_show_popup_menu):
5651 * xselect.c (x_decline_selection_request)
5652 (x_reply_selection_request): Avoid type-punned deref of X events.
5653
5654 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5655
5656 Fix some uses of `int' instead of EMACS_INT.
5657 * search.c (string_match_1, fast_string_match)
5658 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5659 (scan_buffer, find_next_newline_no_quit)
5660 (find_before_next_newline, search_command, Freplace_match)
5661 (Fmatch_data): Make some `int' variables be EMACS_INT.
5662
5663 * xdisp.c (display_count_lines): 3rd argument and return value now
5664 EMACS_INT. All callers changed.
5665 (pint2hrstr): Last argument is now EMACS_INT.
5666
5667 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5668 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5669 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5670 (decode_coding_utf_16, decode_coding_emacs_mule)
5671 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5672 (decode_coding_ccl, decode_coding_charset)
5673 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5674 (decode_coding_iso_2022, decode_coding_emacs_mule)
5675 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5676 <char_offset, last_offset>: Declare EMACS_INT.
5677 (encode_coding_utf_8, encode_coding_utf_16)
5678 (encode_coding_emacs_mule, encode_invocation_designation)
5679 (encode_designation_at_bol, encode_coding_iso_2022)
5680 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5681 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5682 Declare EMACS_INT.
5683 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5684 (encode_invocation_designation): Last argument P_NCHARS is now
5685 EMACS_INT.
5686 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5687 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5688
5689 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5690 All users changed.
5691
5692 * ccl.c (Fccl_execute_on_string): Declare some variables
5693 EMACS_INT.
5694
5695 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5696
5697 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5698
5699 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5700
5701 * process.c (Fformat_network_address): Doc fix.
5702
5703 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5704
5705 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5706
5707 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5708
5709 * keyboard.c (read_char): Call Lisp function help-form-show,
5710 instead of using internal_with_output_to_temp_buffer.
5711 (Qhelp_form_show): New var.
5712 (syms_of_keyboard): Use DEFSYM macro.
5713
5714 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5715
5716 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5717
5718 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5719
5720 * process.c (Flist_processes): Remove to Lisp.
5721 (list_processes_1): Delete.
5722
5723 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5724
5725 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5726
5727 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5728
5729 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 Fix more problems found by GCC 4.6.0's static checks.
5732
5733 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5734
5735 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5736
5737 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5738
5739 * xdisp.c (vmessage): Mark as a printf-like function.
5740
5741 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5742
5743 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5744
5745 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5746 printf-like functions.
5747 (tiff_load): Add casts to remove these marks before passing them
5748 to system-supplied API.
5749
5750 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5751
5752 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5753 This avoids several warnings with gcc -Wstrict-overflow.
5754 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5755 directly, rather than having caller test rule sign. This avoids
5756 some unnecessary tests.
5757 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5758 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5759 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5760
5761 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5762 (xfont_open): Avoid unnecessary tests.
5763
5764 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5765
5766 * composite.h, composite.c (composition_gstring_put_cache):
5767 Use EMACS_INT, not int, for length.
5768
5769 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5770 breaking out part of COMPOSITION_DECODE_RULE.
5771 (COMPOSITION_DECODE_RULE): Use it.
5772 * composite.c (get_composition_id): Remove unused local vars,
5773 by using the new macro.
5774
5775 * textprop.c (set_text_properties_1): Change while to do-while,
5776 since the condition is always true at first.
5777
5778 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5779 (interval_deletion_adjustment): Return unsigned value.
5780 All uses changed.
5781
5782 * process.c (list_processes_1, create_pty, read_process_output):
5783 (exec_sentinel): Remove vars that were set but not used.
5784 (create_pty): Remove unnecessary "volatile"s.
5785 (Fnetwork_interface_info): Avoid possibility of int overflow.
5786 (read_process_output): Do adaptive read buffering even if carryover.
5787 (read_process_output): Simplify nbytes computation if buffered.
5788
5789 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5790
5791 * syntax.c (scan_words): Remove var that was set but not used.
5792 (update_syntax_table): Use unsigned instead of int.
5793
5794 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5795 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5796 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5797
5798 * print.c (print_error_message): Avoid int overflow.
5799
5800 * font.c (font_list_entities): Redo for clarity,
5801 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5802
5803 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5804 (font_score): Avoid potential overflow in diff calculation.
5805
5806 * fns.c (substring_both): Remove var that is set but not used.
5807 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5808
5809 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5810
5811 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5812 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5813 can always succeed if overflow has undefined behavior.
5814
5815 * search.c (boyer_moore, wordify): Remove vars set but not used.
5816 (wordify): Omit three unnecessary tests.
5817
5818 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5819 All callers changed. This avoids the need for an unused var.
5820
5821 * casefiddle.c (casify_region): Remove var that is set but not used.
5822
5823 * dired.c (file_name_completion): Remove var that is set but not used.
5824
5825 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5826
5827 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5828 (Finsert_file_contents): Remove unnecessary code checking fd.
5829
5830 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5831 Check for integer overflow on size calculations.
5832
5833 * buffer.c (Fprevious_overlay_change): Remove var that is set
5834 but not used.
5835
5836 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5837 Remove vars that are set but not used.
5838 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5839 (timer_check_2): Mark vars as initialized.
5840
5841 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5842
5843 * image.c (lookup_image): Remove var that is set but not used.
5844 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5845
5846 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5847 that are set but not used.
5848
5849 * xfns.c (make_invisible_cursor): Don't return garbage
5850 if XCreateBitmapFromData fails (Bug#8410).
5851
5852 * xselect.c (x_get_local_selection, x_handle_property_notify):
5853 Remove vars that are set but not used.
5854
5855 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5856 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5857
5858 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5859 Remove var that is set but not used.
5860 (scroll_bar_windows_size): Now size_t, not int.
5861 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5862 Check for overflow.
5863
5864 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5865 (map_tty_color) [!defined MSDOS]: Likewise.
5866
5867 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5868
5869 * coding.c: Remove vars that are set but not used.
5870 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5871 All callers changed.
5872 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5873 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5874 (decode_coding_charset): Remove vars that are set but not used.
5875
5876 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5877 that is set but not used.
5878
5879 * print.c (print_object): Remove var that is set but not used.
5880
5881 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5882 The gnulib version avoids calling malloc in the usual case,
5883 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5884 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5885 * filelock.c (current_lock_owner): Likewise.
5886 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5887 * sysdep.c: Include allocator.h, careadlinkat.h.
5888 (emacs_no_realloc_allocator): New static constant.
5889 (emacs_readlink): New function.
5890 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5891 ../lib/careadlinkat.h.
5892
5893 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5894
5895 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5896 first non-nil return value).
5897
5898 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5899
5900 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5901 if not defined (Bug#8403).
5902
5903 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5904
5905 * xdisp.c (display_count_lines): Remove parameter `start',
5906 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5907 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5908 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5909 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5910 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5911 and thereabouts. All callers changed.
5912 (get_per_char_metric): Remove parameter `f', unused since
5913 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5914
5915 2011-04-02 Jim Meyering <meyering@redhat.com>
5916
5917 do not dereference NULL upon failed strdup
5918 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5919 (ns_get_family): Likewise.
5920
5921 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5922
5923 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5924
5925 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5926
5927 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5928 later (Bug#8403).
5929
5930 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5931
5932 Add lexical binding.
5933
5934 * window.c (Ftemp_output_buffer_show): New fun.
5935 (Fsave_window_excursion):
5936 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5937
5938 * lread.c (lisp_file_lexically_bound_p): New function.
5939 (Fload): Bind Qlexical_binding.
5940 (readevalloop): Remove `evalfun' arg.
5941 Bind Qinternal_interpreter_environment.
5942 (Feval_buffer): Bind Qlexical_binding.
5943 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5944 Mark as dynamic.
5945 (syms_of_lread): Declare `lexical-binding'.
5946
5947 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5948
5949 * keyboard.c (eval_dyn): New fun.
5950 (menu_item_eval_property): Use it.
5951
5952 * image.c (parse_image_spec): Use Ffunctionp.
5953
5954 * fns.c (concat, mapcar1): Accept byte-code-functions.
5955
5956 * eval.c (Fsetq): Handle lexical vars.
5957 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5958 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5959 (FletX, Flet): Obey lexical binding.
5960 (Fcommandp): Handle closures.
5961 (Feval): New `lexical' arg.
5962 (eval_sub): New function extracted from Feval. Use it almost
5963 everywhere where Feval was used. Look up vars in lexical env.
5964 Handle closures.
5965 (Ffunctionp): Move from subr.el.
5966 (Ffuncall): Handle closures.
5967 (apply_lambda): Remove `eval_flags'.
5968 (funcall_lambda): Handle closures and new byte-code-functions.
5969 (Fspecial_variable_p): New function.
5970 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5971 but without exporting it to Lisp.
5972
5973 * doc.c (Fdocumentation, store_function_docstring):
5974 * data.c (Finteractive_form): Handle closures.
5975
5976 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5977 interactive spec.
5978
5979 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5980 New byte-codes.
5981 (exec_byte_code): New function extracted from Fbyte_code to handle new
5982 calling convention for byte-code-functions. Add new byte-codes.
5983
5984 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5985
5986 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5987
5988 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5989
5990 * xdisp.c (redisplay_internal): Fix prototype.
5991
5992 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5993
5994 * xdisp.c (SCROLL_LIMIT): New macro.
5995 (try_scrolling): Use it when setting scroll_limit.
5996 Limit scrolling to 100 screen lines.
5997 (redisplay_window): Even when falling back on "recentering",
5998 position point in the window according to scroll-conservatively,
5999 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6000
6001 (try_scrolling): When point is above the window, allow searching
6002 as far as scroll_max, or one screenful, to compute vertical
6003 distance from PT to the scroll margin position. This prevents
6004 try_scrolling from unnecessarily failing when
6005 scroll-conservatively is set to a value slightly larger than the
6006 window height. Clean up the case of PT below the margin at bottom
6007 of window: scroll_max can no longer be INT_MAX. When aggressive
6008 scrolling is in use, don't let point enter the opposite scroll
6009 margin as result of the scroll.
6010 (syms_of_xdisp) <scroll-conservatively>: Document the
6011 threshold of 100 lines for never-recentering scrolling.
6012
6013 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6014
6015 * dispextern.h (move_it_by_lines):
6016 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6017 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6018 (message_log_check_duplicate): Remove parameters `prev_bol' and
6019 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6020 (redisplay_internal): Remove parameter `preserve_echo_area',
6021 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6022
6023 * indent.c (Fvertical_motion):
6024 * window.c (window_scroll_pixel_based, Frecenter):
6025 Don't pass `need_y_p' to `move_it_by_lines'.
6026
6027 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6028
6029 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6030 steal a few bits to be more compact.
6031 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6032 Remove unneeded casts.
6033
6034 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6035
6036 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6037
6038 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6039 binding" message (bug#7967).
6040
6041 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6042
6043 Fix more problems found by GCC 4.6.0's static checks.
6044
6045 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6046 Remove unused local var.
6047
6048 * editfns.c (Fmessage_box): Remove unused local var.
6049
6050 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6051 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6052 Omit unused local vars.
6053 * window.c (shrink_windows): Omit unused local var.
6054 * menu.c (digest_single_submenu): Omit unused local var.
6055 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6056 Omit unused local var.
6057
6058 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6059 Don't assume string length fits in int.
6060 (keyremap_step, read_key_sequence): Use size_t for sizes.
6061 (read_key_sequence): Don't check last_real_key_start redundantly.
6062
6063 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6064 instead of alloca (Bug#8344).
6065
6066 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6067 (Fbacktrace_frame): Don't assume nframes fits in int.
6068
6069 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6070
6071 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6072 concerns.
6073
6074 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6075
6076 * cm.c (calccost): Turn while-do into do-while, for clarity.
6077
6078 * keyboard.c (syms_of_keyboard): Use the same style as later
6079 in this function when indexing through an array. This also
6080 works around GCC bug 48267.
6081
6082 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6083
6084 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6085
6086 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6087 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6088
6089 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6090 This avoids undefined behavior on integer overflow, and is a bit
6091 more convenient anyway since it is compared to a size_t variable.
6092
6093 Variadic C functions now count arguments with size_t, not int.
6094 This avoids an unnecessary limitation on 64-bit machines, which
6095 caused (substring ...) to crash on large vectors (Bug#8344).
6096 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6097 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6098 All variadic functions and their callers changed accordingly.
6099 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6100 * data.c (arith_driver, float_arith_driver): Likewise.
6101 * editfns.c (general_insert_function): Likewise.
6102 * eval.c (struct backtrace.nargs, interactive_p)
6103 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6104 (funcall_lambda, mark_backtrace): Likewise.
6105 * fns.c (concat): Likewise.
6106 * frame.c (x_set_frame_parameters): Likewise.
6107 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6108 0 if not found, not -1. All callers changed.
6109
6110 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6111 (stack_copy_size): Now size_t, not int.
6112 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6113
6114 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6115
6116 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6117 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6118 All callers changed.
6119
6120 * lisp.h (multibyte_char_to_unibyte):
6121 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6122 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6123 * character.h (CHAR_TO_BYTE8):
6124 * cmds.c (internal_self_insert):
6125 * editfns.c (general_insert_function):
6126 * keymap.c (push_key_description):
6127 * search.c (Freplace_match):
6128 * xdisp.c (message_dolog, set_message_1): All callers changed.
6129
6130 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6131
6132 * keyboard.c (safe_run_hook_funcall): New function.
6133 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6134 don't set the hook to nil, but remove the offending function instead.
6135 (Qcommand_hook_internal): Remove, unused.
6136 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6137 Vcommand_hook_internal.
6138
6139 * eval.c (enum run_hooks_condition): Remove.
6140 (funcall_nil, funcall_not): New functions.
6141 (run_hook_with_args): Call each function through a `funcall' argument.
6142 Remove `cond' argument, now redundant.
6143 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6144 (Frun_hook_with_args_until_failure): Adjust accordingly.
6145 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6146
6147 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6148
6149 * dispextern.h (string_buffer_position): Remove declaration.
6150
6151 * print.c (strout): Remove parameter `multibyte', unused since
6152 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6153
6154 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6155 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6156 All callers changed.
6157
6158 * w32.c (_wsa_errlist): Use braces for struct initializers.
6159
6160 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6161 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6162 All callers changed.
6163 (string_buffer_position): Likewise. Also, make static (it's never
6164 used outside xdisp.c).
6165 (cursor_row_p): Remove parameter `w', unused since
6166 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6167 (decode_mode_spec): Remove parameter `precision', introduced during
6168 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6169 All callers changed.
6170
6171 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6172
6173 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6174
6175 2011-03-27 Anders Lindgren <andlind@gmail.com>
6176
6177 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6178 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6179 (ns_update_auto_hide_menu_bar): New functions.
6180 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6181 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6182 ns_constrain_all_frames.
6183 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6184 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6185
6186 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6187
6188 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6189
6190 2011-03-27 Glenn Morris <rgm@gnu.org>
6191
6192 * syssignal.h: Replace RETSIGTYPE with void.
6193 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6194 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6195 Replace SIGTYPE with void everywhere.
6196 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6197 * s/template.h (SIGTYPE): Remove commented out definition.
6198
6199 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6200
6201 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6202 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6203
6204 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6205
6206 * w32.c (read_unc_volume): Use parameter `henum', instead of
6207 global variable `wget_enum_handle'.
6208
6209 * keymap.c (describe_vector): Remove parameters `indices' and
6210 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6211 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6212
6213 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6214
6215 * keyboard.c (timer_check): Remove parameter `do_it_now',
6216 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6217 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6218 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6219
6220 * keyboard.c (read_char):
6221 * w32menu.c (w32_menu_display_help):
6222 * xmenu.c (show_help_event, menu_help_callback):
6223 Adjust calls to `show_help_echo'.
6224
6225 * gtkutil.c (xg_maybe_add_timer):
6226 * keyboard.c (readable_events):
6227 * process.c (wait_reading_process_output):
6228 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6229
6230 * insdel.c (adjust_markers_gap_motion):
6231 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6232 (gap_left, gap_right): Don't call it.
6233
6234 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6235
6236 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6237 incurred during fontification.
6238
6239 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6240
6241 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6242 (DEFVAR_PER_BUFFER): Don't pass it.
6243
6244 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6245 (scrolling_window): Don't pass it.
6246
6247 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6248
6249 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6250
6251 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6252 and `suffix'.
6253 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6254 of variables specific to SELinux and computation of `encoded_absname'.
6255
6256 * image.c (XPutPixel): Remove unused variable `height'.
6257
6258 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6259
6260 * unexw32.c (get_section_info): Remove unused variable `section'.
6261
6262 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6263 (system_process_attributes): Remove unused variable `sess'.
6264 (sys_read): Remove unused variable `err'.
6265
6266 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6267 (w32_wnd_proc): Remove unused variable `isdead'.
6268 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6269 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6270 (x_create_tip_frame): Remove unused variable `tem'.
6271
6272 * w32inevt.c (w32_console_read_socket):
6273 Remove unused variable `no_events'.
6274
6275 * w32term.c (x_draw_composite_glyph_string_foreground):
6276 Remove unused variable `width'.
6277
6278 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6279
6280 * w32term.c (x_set_glyph_string_clipping):
6281 Don't pass uninitialized region to CombineRgn.
6282
6283 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6284
6285 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6286 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6287 (Fx_close_connection): Remove unused variable `i'.
6288
6289 * w32font.c (w32font_draw): Return number of glyphs.
6290 (w32font_open_internal): Remove unused variable `i'.
6291 (w32font_driver): Add missing initializer.
6292
6293 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6294 (fill_in_menu): Remove unused variable `items_added'.
6295
6296 * w32term.c (last_mouse_press_frame): Remove static global variable.
6297 (w32_clip_to_row): Remove unused variable `f'.
6298 (x_delete_terminal): Remove unused variable `i'.
6299
6300 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6301 (NOTHING): Remove unused static global variable.
6302 (uniscribe_check_otf): Remove unused variable `table'.
6303 (uniscribe_font_driver): Add missing initializers.
6304
6305 2011-03-23 Julien Danjou <julien@danjou.info>
6306
6307 * term.c (Fsuspend_tty, Fresume_tty):
6308 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6309 * window.c (temp_output_buffer_show):
6310 * insdel.c (signal_before_change):
6311 * frame.c (Fhandle_switch_frame):
6312 * fileio.c (Fdo_auto_save):
6313 * emacs.c (Fkill_emacs):
6314 * editfns.c (save_excursion_restore):
6315 * cmds.c (internal_self_insert):
6316 * callint.c (Fcall_interactively):
6317 * buffer.c (Fkill_all_local_variables):
6318 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6319 Use Frun_hooks.
6320 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6321 unconditionnaly since it does the check itself.
6322
6323 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6324
6325 Fix more problems found by GCC 4.5.2's static checks.
6326
6327 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6328 the first time through the loop, since we know p0 < p1 then.
6329 This also avoids a gcc -Wstrict-overflow warning.
6330
6331 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6332 leading to a memory leak, possible in functions like
6333 load_charset_map_from_file that can allocate an unbounded number
6334 of objects (Bug#8318).
6335
6336 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6337 that could (at least in theory) be that large.
6338
6339 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6340 This is less likely to overflow, and avoids undefined behavior if
6341 overflow does occur. All callers changed. Use strtoul to scan
6342 for the unsigned long integer.
6343 (pint2hrstr): Simplify and tune code slightly.
6344 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6345
6346 * scroll.c (do_scrolling): Work around GCC bug 48228.
6347 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6348
6349 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6350 This also avoids a warning with gcc -Wstrict-overflow.
6351 (validate_x_resource_name): Simplify count usage.
6352 This also avoids a warning with gcc -Wstrict-overflow.
6353
6354 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6355 fail (Bug#8306).
6356
6357 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6358
6359 * process.c (Fmake_network_process): Use socklen_t, not int,
6360 where POSIX says socklen_t is required in portable programs.
6361 This fixes a porting bug on hosts like 64-bit HP-UX, where
6362 socklen_t is wider than int (Bug#8277).
6363 (Fmake_network_process, server_accept_connection):
6364 (wait_reading_process_output, read_process_output):
6365 Likewise.
6366
6367 * process.c: Rename or move locals to avoid shadowing.
6368 (list_processes_1, Fmake_network_process):
6369 (read_process_output_error_handler, exec_sentinel_error_handler):
6370 Rename or move locals.
6371 (Fmake_network_process): Define label "retry_connect" only if needed.
6372 (Fnetwork_interface_info): Fix pointer signedness.
6373 (process_send_signal): Add cast to avoid pointer signedness problem.
6374 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6375 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6376
6377 Make tparam.h and terminfo.c consistent.
6378 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6379 Include tparam.h instead, since it declares them.
6380 * cm.h (PC): Remove extern decl; tparam.h now does this.
6381 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6382 * terminfo.c: Include tparam.h, to check interfaces.
6383 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6384 (tparam): Adjust signature to match interface in tparam.h;
6385 this removes some undefined behavior. Check that outstring and len
6386 are zero, which they always are with Emacs.
6387 * tparam.h (PC, BC, UP): New extern decls.
6388
6389 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6390 (xftfont_open): Rename locals to avoid shadowing.
6391
6392 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6393 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6394 (OTF_TAG_SYM): Omit macro if not needed.
6395 (ftfont_list): Remove unused local.
6396 (get_adstyle_property, ftfont_pattern_entity):
6397 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6398 Rename locals to avoid shadowing.
6399
6400 * xfont.c (xfont_list_family): Mark var as initialized.
6401
6402 * xml.c (make_dom): Now static.
6403
6404 * composite.c (composition_compute_stop_pos): Rename local to
6405 avoid shadowing.
6406 (composition_reseat_it): Remove unused locals.
6407 (find_automatic_composition, composition_adjust_point): Likewise.
6408 (composition_update_it): Mark var as initialized.
6409 (find_automatic_composition): Mark vars as initialized,
6410 with a FIXME (Bug#8290).
6411
6412 character.h: Rename locals to avoid shadowing.
6413 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6414 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6415 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6416 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6417 to avoid shadowing.
6418
6419 * textprop.c (property_change_between_p): Remove; unused.
6420
6421 * intervals.c (interval_start_pos): Now static.
6422
6423 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6424
6425 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6426 Rename locals to avoid shadowing.
6427
6428 * sound.c (wav_play, au_play, Fplay_sound_internal):
6429 Fix pointer signedness.
6430 (alsa_choose_format): Remove unused local var.
6431 (wav_play): Initialize a variable to 0, to prevent undefined
6432 behavior (Bug#8278).
6433
6434 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6435
6436 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6437
6438 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6439 clobbering (Bug#8298).
6440 * sysdep.c (sys_subshell): Likewise.
6441 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6442
6443 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6444 This should get cleaned up, so that child_setup has the
6445 same signature on all platforms.
6446
6447 * callproc.c (call_process_cleanup): Now static.
6448 (relocate_fd): Rename locals to avoid shadowing.
6449
6450 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6451
6452 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6453 not to be necessary, and produces flickering.
6454
6455 2011-03-20 Glenn Morris <rgm@gnu.org>
6456
6457 * config.in: Remove file.
6458
6459 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6460
6461 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6462 are now in src/globals.h.
6463 (syms_of_minibuf): Remove spurious & from previous change.
6464
6465 2011-03-20 Leo <sdl.web@gmail.com>
6466
6467 * minibuf.c (completing-read-function): New variable.
6468 (completing-read-default): Rename from completing-read.
6469 (completing-read): Call completing-read-function.
6470
6471 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6472
6473 * xfaces.c (Fx_load_color_file):
6474 Read color file from absolute filename (bug#8250).
6475
6476 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6477
6478 * makefile.w32-in: Update dependencies.
6479
6480 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6481
6482 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6483
6484 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6485
6486 Fix more problems found by GCC 4.5.2's static checks.
6487
6488 * process.c (make_serial_process_unwind, send_process_trap):
6489 (sigchld_handler): Now static.
6490
6491 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6492 That way, the code declares only the vars that it needs.
6493 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6494 * s/cygwin.h (PTY_ITERATION): Likewise.
6495 * s/darwin.h (PTY_ITERATION): Likewise.
6496 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6497
6498 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6499 * process.c (allocate_pty): Don't declare stb unless it's needed.
6500
6501 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6502 (CONSTANTLIM): Remove; unused.
6503 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6504 Define only if needed.
6505
6506 * unexelf.c (unexec): Name an expression,
6507 to avoid gcc -Wbad-function-cast warning.
6508 Use a different way to cause a compilation error if anyone uses
6509 n rather than nn, a way that does not involve shadowing.
6510 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6511
6512 * deps.mk (unexalpha.o): Remove; unused.
6513
6514 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6515 * unexec.h: New file.
6516 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6517 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6518 Depend on unexec.h.
6519 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6520 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6521 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6522 Change as necessary to match prototype in unexec.h.
6523
6524 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6525 shadowing.
6526 (back_comment, skip_chars): Mark vars as initialized.
6527
6528 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6529 Rename locals to avoid shadowing.
6530
6531 * lread.c (read1): Rewrite so as not to use empty "else".
6532 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6533
6534 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6535
6536 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6537 warning when compiling print.c.
6538
6539 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6540 instead of using an uninitialized var.
6541 (font_sort_entities): Mark var as initialized.
6542
6543 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6544
6545 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6546 pointers to constants.
6547 (font_parse_fcname): Remove unused vars.
6548 (font_delete_unmatched): Now static.
6549 (font_get_spec): Remove; unused.
6550 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6551 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6552 Rename or move locals to avoid shadowing.
6553
6554 * fns.c (require_nesting_list, require_unwind): Now static.
6555 (Ffillarray): Rename locals to avoid shadowing.
6556
6557 * floatfns.c (domain_error2): Define only if needed.
6558 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6559
6560 * alloc.c (mark_backtrace): Move decl from here ...
6561 * lisp.h: ... to here, so that it can be checked.
6562
6563 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6564 (Fdefvar): Rewrite so as not to use empty "else".
6565 (lisp_indirect_variable): Name an expression,
6566 to avoid gcc -Wbad-function-cast warning.
6567 (Fdefvar): Rename locals to avoid shadowing.
6568
6569 * callint.c (quotify_arg, quotify_args): Now static.
6570 (Fcall_interactively): Rename locals to avoid shadowing.
6571 Use const pointer when appropriate.
6572
6573 * lisp.h (get_system_name, get_operating_system_release):
6574 Move decls here, to check interfaces.
6575 * process.c (get_operating_system_release): Move decl to lisp.h.
6576 * xrdb.c (get_system_name): Likewise.
6577 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6578 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6579 some of which prompt warnings from gcc -Wbad-function-cast.
6580 (Fformat_time_string, Fencode_time, Finsert_char):
6581 (Ftranslate_region_internal, Fformat):
6582 Rename or remove local vars to avoid shadowing.
6583 (Ftranslate_region_internal): Mark var as initialized.
6584
6585 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6586 avoid shadowing.
6587
6588 * lisp.h (eassert): Check that the argument compiles, even if
6589 ENABLE_CHECKING is not defined.
6590
6591 * data.c (Findirect_variable): Name an expression, to avoid
6592 gcc -Wbad-function-cast warning.
6593 (default_value, arithcompare, arith_driver, arith_error): Now static.
6594 (store_symval_forwarding): Rename local to avoid shadowing.
6595 (Fmake_variable_buffer_local, Fmake_local_variable):
6596 Mark variables as initialized.
6597 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6598
6599 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6600 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6601 Rename locals to avoid shadowing.
6602 (mark_stack): Move local variables into the #ifdef region where
6603 they're used.
6604 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6605 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6606 needed otherwise.
6607 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6608 (GC_STRING_CHARS): Remove; not used.
6609 (Fmemory_limit): Cast sbrk's returned value to char *.
6610
6611 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6612 avoids undefined behavior in theory.
6613
6614 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6615
6616 Use functions, not macros, for up- and down-casing (Bug#8254).
6617 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6618 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6619 to use the following functions instead of these macros.
6620 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6621 EMACS_INT, since callers assume the returned value fits in int.
6622 (upcase1): Likewise, for UPCASE_TABLE.
6623 (uppercasep, lowercasep, upcase): New static inline functions.
6624 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6625 the race-condition problem in the old DOWNCASE.
6626
6627 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6628 Rename locals to avoid shadowing.
6629 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6630 (regex_compile, re_search_2, re_match_2_internal):
6631 Remove unused local vars.
6632 (FREE_VAR): Rewrite so as not to use empty "else",
6633 which gcc can warn about.
6634 (regex_compile, re_match_2_internal): Mark locals as initialized.
6635 (RETALLOC_IF): Define only if needed.
6636 (WORDCHAR_P): Likewise. This one is never needed, but is used
6637 only in a comment talking about a compiler bug, so put inside
6638 the #if 0 of that comment.
6639 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6640 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6641 Remove; unused.
6642
6643 * search.c (boyer_moore): Rename locals to avoid shadowing.
6644 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6645 (PREV_CHAR_BOUNDARY): Likewise.
6646
6647 * search.c (simple_search): Remove unused var.
6648
6649 * dired.c (compile_pattern): Move decl from here ...
6650 * lisp.h: ... to here, so that it can be checked.
6651 (struct re_registers): New forward decl.
6652
6653 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6654
6655 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6656 All uses changed.
6657 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6658 Rename locals to avoid shadowing.
6659 (Fvertical_motion): Mark locals as initialized.
6660
6661 * casefiddle.c (casify_object, casify_region): Now static.
6662 (casify_region): Mark local as initialized.
6663
6664 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6665
6666 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6667 New macros, so that the caller can use some names other than
6668 gcpro1, gcpro2, etc.
6669 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6670 of the new macros.
6671 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6672 argument, for consistency with GCPRO2_VAR, etc: it is now the
6673 prefix of the variable, not the variable itself. All uses
6674 changed.
6675 * dired.c (directory_files_internal, file_name_completion):
6676 Rename locals to avoid shadowing.
6677
6678 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6679 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6680 dired.c's scmp function, had undefined behavior.
6681 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6682 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6683 * buffer.h: ... to here, because these macros use current_buffer,
6684 and the new implementation with inline functions needs to have
6685 current_buffer in scope now, rather than later when the macros
6686 are used.
6687 (downcase, upcase1): New static inline functions.
6688 (DOWNCASE, UPCASE1): Reimplement using these functions.
6689 This avoids undefined behavior in expressions like
6690 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6691 from race conditions in accessing the global variables
6692 case_temp1 and case_temp2.
6693 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6694 * lisp.h (case_temp1, case_temp2): Remove their decls.
6695 * character.h (ASCII_CHAR_P): Move from here ...
6696 * lisp.h: ... to here, so that the inline functions mentioned
6697 above can use them.
6698
6699 * dired.c (directory_files_internal_unwind): Now static.
6700
6701 * fileio.c (file_name_as_directory, directory_file_name):
6702 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6703 Now static.
6704 (file_name_as_directory): Use const pointers when appropriate.
6705 (Fexpand_file_name): Likewise. In particular, newdir might
6706 point at constant storage, so make it a const pointer.
6707 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6708 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6709 signedness issues.
6710 (Fset_file_times, Finsert_file_contents, auto_save_error):
6711 Rename locals to avoid shadowing.
6712
6713 * minibuf.c (choose_minibuf_frame_1): Now static.
6714 (Ftry_completion, Fall_completions): Rename or remove locals
6715 to avoid shadowing.
6716
6717 * marker.c (bytepos_to_charpos): Remove; unused.
6718
6719 * lisp.h (verify_bytepos, count_markers): New decls,
6720 so that gcc does not warn that these functions aren't declared.
6721
6722 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6723 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6724 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6725 (copy_text): Remove unused local var.
6726
6727 * filelock.c (within_one_second): Now static.
6728 (lock_file_1): Rename local to avoid shadowing.
6729
6730 * buffer.c (fix_overlays_before): Mark locals as initialized.
6731 (fix_start_end_in_overlays): Likewise. This function should be
6732 simplified by using pointers-to-pointers, but that's a different
6733 matter.
6734 (switch_to_buffer_1): Now static.
6735 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6736 (report_overlay_modification): Rename locals to avoid shadowing.
6737
6738 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6739 Fix pointer signedness issue.
6740 (sys_subshell): Mark local as volatile if checking for lint,
6741 to suppress a gcc -Wclobbered warning that does not seem to be right.
6742 (MAXPATHLEN): Define only if needed.
6743
6744 * process.c (serial_open, serial_configure): Move decls from here ...
6745 * systty.h: ... to here, so that they can be checked.
6746
6747 * fns.c (get_random, seed_random): Move extern decls from here ...
6748 * lisp.h: ... to here, so that they can be checked.
6749
6750 * sysdep.c (reset_io): Now static.
6751 (wait_for_termination_signal): Remove; unused.
6752
6753 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6754 (copy_keymap_item, append_key, push_text_char_description):
6755 Now static.
6756 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6757 (DENSE_TABLE_SIZE): Remove; unused.
6758 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6759 (describe_map_tree):
6760 Rename locals to avoid shadowing.
6761
6762 * keyboard.c: Declare functions static if they are not used elsewhere.
6763 (echo_char, echo_dash, cmd_error, top_level_2):
6764 (poll_for_input, handle_async_input): Now static.
6765 (read_char, kbd_buffer_get_event, make_lispy_position):
6766 (make_lispy_event, make_lispy_movement, apply_modifiers):
6767 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6768 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6769 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6770 (read_key_sequence, read_char): Mark locals as initialized.
6771 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6772
6773 * keyboard.h (make_ctrl_char): New decl.
6774 (mark_kboards): Move decl here ...
6775 * alloc.c (mark_kboards): ... from here.
6776
6777 * lisp.h (force_auto_save_soon): New decl.
6778
6779 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6780 (DEFINE_DUMMY_FUNCTION): New macro.
6781 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6782 Use it.
6783 (main): Add casts to avoid warnings
6784 if GCC considers string literals to be constants.
6785
6786 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6787
6788 * dbusbind.c: Pointer signedness fixes.
6789 (xd_signature, xd_append_arg, xd_initialize):
6790 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6791 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6792 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6793 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6794
6795 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6796 if GCC considers string literals to be constants.
6797 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6798
6799 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6800
6801 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6802 (print_preprocess, print_object): New macro to fix last change.
6803
6804 * print.c (print_preprocess): Don't forget font objects.
6805
6806 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6807
6808 * emacs.c (USAGE3): Doc fixes.
6809
6810 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6811
6812 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6813 structure.
6814
6815 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6816
6817 * lisp.h (VWindow_system, Qfile_name_history):
6818 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6819 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6820 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6821
6822 * w32select.c: Don't #include "keyboard.h".
6823 (run_protected): Add extern declaration for waiting_for_input.
6824
6825 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6826 * w32console.c (detect_input_pending, read_input_pending)
6827 (encode_terminal_code):
6828 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6829 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6830 (w32_system_caret_y, Qfile_name_history):
6831 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6832 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6833 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6834 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6835 * w32proc.c (Qlocal, report_file_error):
6836 * w32term.c (Vwindow_system, updating_frame):
6837 * w32uniscribe.c (initialized, uniscribe_font_driver):
6838 Remove unneeded extern declarations.
6839
6840 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6841
6842 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6843
6844 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6845
6846 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6847 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6848 These macros can no longer be used for assignment.
6849
6850 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6851 Assign struct members directly, instead of using BUF_BEGV etc.
6852 (record_buffer_markers, fetch_buffer_markers): New functions for
6853 recording and fetching special buffer markers.
6854 (set_buffer_internal_1, set_buffer_temp): Use them.
6855
6856 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6857
6858 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6859
6860 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6861 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6862
6863 * xdisp.c (hscroll_window_tree):
6864 (reconsider_clip_changes): Use PT instead of BUF_PT.
6865
6866 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6867
6868 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6869 $(EMACS_ROOT)/lib/intprops.h.
6870
6871 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6872
6873 Fix more problems found by GCC 4.5.2's static checks.
6874
6875 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6876 to unsigned char * to avoid compiler diagnostic.
6877 (xg_free_frame_widgets): Make it clear that a local variable is
6878 needed only if USE_GTK_TOOLTIP.
6879 (gdk_window_get_screen): Make it clear that this macro is needed
6880 only if USE_GTK_TOOLTIP.
6881 (int_gtk_range_get_value): New function, which avoids a diagnostic
6882 from gcc -Wbad-function-cast.
6883 (xg_set_toolkit_scroll_bar_thumb): Use it.
6884 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6885 diagnostic from gcc -Wbad-function-cast.
6886 (get_utf8_string, xg_get_file_with_chooser):
6887 Rename locals to avoid shadowing.
6888 (create_dialog): Move locals to avoid shadowing.
6889
6890 * xgselect.c (xg_select): Remove unused var.
6891
6892 * image.c (four_corners_best): Mark locals as initialized.
6893 (gif_load): Initialize transparent_p to zero (Bug#8238).
6894 Mark another local as initialized.
6895 (my_png_error, my_error_exit): Mark with NO_RETURN.
6896
6897 * image.c (clear_image_cache): Now static.
6898 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6899 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6900 (x_edge_detection): Remove unnecessary cast that
6901 gcc -Wbad-function-cast diagnoses.
6902 (gif_load): Fix pointer signedness.
6903 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6904 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6905
6906 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6907
6908 Improve quality of tests for time stamp overflow.
6909 For example, without this patch (encode-time 0 0 0 1 1
6910 1152921504606846976) returns the obviously-bogus value (-948597
6911 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6912 reports time overflow. See
6913 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6914 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6915 * editfns.c: Include limits.h and intprops.h.
6916 (TIME_T_MIN, TIME_T_MAX): New macros.
6917 (time_overflow): Move earlier, to before first use.
6918 (hi_time, lo_time): New functions, for an accurate test for
6919 out-of-range times.
6920 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6921 (Fget_internal_run_time): Don't assume time_t fits in int.
6922 (make_time): Use list2 instead of Fcons twice.
6923 (Fdecode_time): More accurate test for out-of-range times.
6924 (check_tm_member): New function.
6925 (Fencode_time): Use it, to test for out-of-range times.
6926 (lisp_time_argument): Don't rely on undefined left-shift and
6927 right-shift behavior when checking for time stamp overflow.
6928
6929 * editfns.c (time_overflow): New function, refactoring common code.
6930 (Fformat_time_string, Fdecode_time, Fencode_time):
6931 (Fcurrent_time_string): Use it.
6932
6933 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6934 * dired.c (make_time): Move to ...
6935 * editfns.c (make_time): ... here.
6936 * systime.h: Note the move.
6937
6938 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6939
6940 * fringe.c (update_window_fringes): Remove unused variables.
6941
6942 * unexmacosx.c (copy_data_segment): Also copy __got section.
6943 (Bug#8223)
6944
6945 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6946
6947 * termcap.c [MSDOS]: Include "msdos.h".
6948 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6949 Constify `char *' arguments and their references according to
6950 prototypes in tparam.h.
6951
6952 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6953
6954 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6955 Adapt all references accordingly.
6956
6957 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6958
6959 2011-03-11 Tom Tromey <tromey@redhat.com>
6960
6961 * buffer.c (syms_of_buffer): Remove obsolete comment.
6962
6963 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6964
6965 * termhooks.h (encode_terminal_code): Declare prototype.
6966
6967 * msdos.c (encode_terminal_code): Don't declare prototype.
6968
6969 * term.c (encode_terminal_code): Now external again, used by
6970 w32console.c and msdos.c.
6971
6972 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6973 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6974
6975 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6976
6977 Fix some minor problems found by GCC 4.5.2's static checks.
6978
6979 * fringe.c (update_window_fringes): Mark locals as initialized
6980 (Bug#8227).
6981 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6982
6983 * alloc.c (mark_fringe_data): Move decl from here ...
6984 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6985 to check its interface.
6986 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6987
6988 * fontset.c (free_realized_fontset): Now static.
6989 (Fset_fontset_font): Rename local to avoid shadowing.
6990 (fontset_font): Mark local as initialized.
6991 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6992
6993 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6994
6995 * xselect.c (x_disown_buffer_selections): Remove; not used.
6996 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6997 (x_own_selection, Fx_disown_selection_internal): Rename locals
6998 to avoid shadowing.
6999 (x_handle_dnd_message): Remove local to avoid shadowing.
7000
7001 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7002 so that the caller can use some name other than gcpro1.
7003 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7004 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7005 (Fx_backspace_delete_keys_p):
7006 Use them to avoid shadowing, and rename vars to avoid shadowing.
7007 (x_decode_color, x_set_name, x_window): Now static.
7008 (Fx_create_frame): Add braces to silence GCC warning.
7009 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7010 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7011 Remove unused locals.
7012 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7013 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7014 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7015 macros.
7016
7017 * xterm.h (x_mouse_leave): New decl.
7018
7019 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7020 Remove unused functions.
7021 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7022 (x_calc_absolute_position): Now static.
7023 (XTread_socket): Don't define label "out" unless it's used.
7024 Don't declare local "event" unless it's used.
7025 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7026 unless they are used.
7027 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7028 (x_fatal_error_signal): Remove; not used.
7029 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7030 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7031 (x_error_catcher, x_connection_closed, x_error_handler):
7032 (x_error_quitter, xembed_send_message, x_iconify_frame):
7033 (my_log_handler): Rename locals to avoid shadowing.
7034 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7035 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7036
7037 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7038 Rename or move locals to avoid shadowing.
7039 (tty_defined_color, merge_face_heights): Now static.
7040 (free_realized_faces_for_fontset): Remove; not used.
7041 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7042 does not deduce is never used uninitialized.
7043 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7044 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7045
7046 * terminal.c (store_terminal_param): Now static.
7047
7048 * xmenu.c (menu_highlight_callback): Now static.
7049 (set_frame_menubar): Remove unused local.
7050 (xmenu_show): Rename parameter to avoid shadowing.
7051 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7052 since they might point to immutable storage.
7053 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7054 since it's unused otherwise.
7055
7056 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7057 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7058 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7059 avoids a gcc -Wuninitialized diagnostic.
7060 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7061 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7062 does not deduce are never used uninitialized.
7063
7064 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7065
7066 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7067 * window.c (window_loop, size_window):
7068 (run_window_configuration_change_hook, enlarge_window): Likewise.
7069
7070 * window.c (display_buffer): Now static.
7071 (size_window): Mark variables that gcc -Wuninitialized
7072 does not deduce are never used uninitialized.
7073 * window.h (check_all_windows): New decl, to forestall
7074 gcc -Wmissing-prototypes diagnostic.
7075 * dispextern.h (bidi_dump_cached_states): Likewise.
7076
7077 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7078 shadowing.
7079 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7080 Include <limits.h>.
7081 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7082 and to avoid gcc -Wuninitialized warning.
7083 (load_charset_map): Mark variables that gcc -Wuninitialized
7084 does not deduce are never used uninitialized.
7085 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7086
7087 * coding.c (coding_set_source, coding_set_destination):
7088 Use "else { /* comment */ }" rather than "else /* comment */;"
7089 for clarity, and to avoid gcc -Wempty-body warning.
7090 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7091 a block, when the outer 'i' will do.
7092 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7093 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7094 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7095 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7096 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7097 Rename locals to avoid shadowing.
7098 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7099 * coding.c (emacs_mule_char, encode_invocation_designation):
7100 Now static, since they're not used elsewhere.
7101 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7102 (decode_coding_object, encode_coding_object, detect_coding_system):
7103 (decode_coding_emacs_mule): Mark variables that gcc
7104 -Wuninitialized does not deduce are never used uninitialized.
7105 (detect_coding_iso_2022): Initialize a local variable that might
7106 be used uninitialized. Leave a FIXME because it's not clear that
7107 this initialization is needed. (Bug#8211)
7108 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7109 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7110 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7111 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7112 Remove unused macros.
7113
7114 * category.c (hash_get_category_set): Remove unused local var.
7115 (copy_category_table): Now static, since it's not used elsewhere.
7116 * character.c (string_count_byte8): Likewise.
7117
7118 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7119 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7120
7121 * chartab.c (copy_sub_char_table): Now static, since it's not used
7122 elsewhere.
7123 (sub_char_table_ref_and_range, char_table_ref_and_range):
7124 Rename locals to avoid shadowing.
7125 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7126
7127 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7128 (BIDI_BOB): Remove unused macro.
7129
7130 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7131 deduce are never used uninitialized.
7132 * term.c (encode_terminal_code): Likewise.
7133
7134 * term.c (encode_terminal_code): Now static. Remove unused local.
7135
7136 * tparam.h: New file.
7137 * term.c, tparam.h: Include it.
7138 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7139 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7140 Move these decls to tparam.h, and make them agree with what
7141 is actually in tparam.c. The previous trick of using incompatible
7142 decls in different modules does not conform to the C standard.
7143 All callers of tparam changed to use tparam's actual API.
7144 * tparam.c (tparam1, tparam, tgoto):
7145 Use const pointers where appropriate.
7146
7147 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7148 * cm.h (struct cm): Likewise.
7149 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7150 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7151 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7152 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7153 (turn_on_face, init_tty): Likewise.
7154 * termchar.h (struct tty_display_info): Likewise.
7155
7156 * term.c (term_mouse_position): Rename local to avoid shadowing.
7157
7158 * alloc.c (mark_ttys): Move decl from here ...
7159 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7160
7161 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7162
7163 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7164
7165 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7166
7167 * search.c (compile_pattern_1): Remove argument regp, unused since
7168 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7169 (compile_pattern): Don't pass it.
7170
7171 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7172
7173 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7174 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7175 for ! HAVE_GTK3.
7176 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7177
7178 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7179
7180 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7181 gdk_window_get_screen, gdk_window_get_geometry,
7182 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7183 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7184 (xg_get_pixbuf_from_pixmap): New function.
7185 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7186 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7187 Call xg_get_pixbuf_from_pixmap instead of
7188 gdk_pixbuf_get_from_drawable.
7189 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7190 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7191 (xg_check_special_colors): Use GtkStyleContext and its functions
7192 for HAVE_GTK3.
7193 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7194 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7195 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7196 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7197 Call gtk_widget_get_preferred_size.
7198 (xg_frame_resized): gdk_window_get_geometry only takes 5
7199 parameters.
7200 (xg_win_to_widget, xg_event_is_for_menubar):
7201 Call gdk_x11_window_lookup_for_display.
7202 (xg_set_widget_bg): New function.
7203 (delete_cb): New function.
7204 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7205 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7206 (xg_set_background_color): Call xg_set_widget_bg.
7207 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7208 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7209 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7210 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7211 if ! HAVE_GTK3.
7212 (update_frame_tool_bar): Call gtk_widget_hide.
7213 (xg_initialize): Use GDK_KEY_g.
7214
7215 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7216 if ! HAVE_GTK3
7217 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7218
7219 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7220 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7221 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7222
7223 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7224
7225 * w32xfns.c (select_palette): Check success of RealizePalette against
7226 GDI_ERROR, not zero.
7227
7228 See ChangeLog.11 for earlier changes.
7229
7230 ;; Local Variables:
7231 ;; coding: utf-8
7232 ;; End:
7233
7234 Copyright (C) 2011 Free Software Foundation, Inc.
7235
7236 This file is part of GNU Emacs.
7237
7238 GNU Emacs is free software: you can redistribute it and/or modify
7239 it under the terms of the GNU General Public License as published by
7240 the Free Software Foundation, either version 3 of the License, or
7241 (at your option) any later version.
7242
7243 GNU Emacs is distributed in the hope that it will be useful,
7244 but WITHOUT ANY WARRANTY; without even the implied warranty of
7245 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7246 GNU General Public License for more details.
7247
7248 You should have received a copy of the GNU General Public License
7249 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.