1 2011-08-16 Paul Eggert <eggert@cs.ucla.edu>
3 Integer and memory overflow issues (Bug#9196).
5 * image.c (x_allocate_bitmap_record, cache_image):
6 * xselect.c (Fx_register_dnd_atom):
7 Simplify previous changes by using xpalloc.
9 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10 since either will do and ptrdiff_t is convenient with xpalloc.
12 * charset.c (charset_table_size)
13 (struct charset_sort_data.priority): Now ptrdiff_t.
14 (charset_compare): Don't overflow if priorities differ greatly.
15 (Fsort_charsets): Don't assume list length fits in int.
16 Check for size-calculation overflow when allocating sort data.
17 (syms_of_charset): Allocate an initial charset table that is
18 just under 64 KiB, to avoid problems with glibc malloc and mmap.
20 * cmds.c (internal_self_insert): Check for size-calculation overflow.
22 * composite.h (struct composition.glyph_len): Now int, not unsigned.
23 The actual value is always <= INT_MAX, and leaving it unsigned made
24 overflow checking harder.
26 * dispextern.h (struct glyph_matrix.rows_allocated)
27 (struct face_cache.size): Now ptrdiff_t, for convenience in use
28 with xpalloc. The values are still always <= INT_MAX.
30 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
32 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
33 (SAFE_NALLOCA): New macro.
35 * region-cache.c (struct boundary.pos, find_cache_boundary)
36 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
37 (set_cache_region, invalidate_region_cache)
38 (revalidate_region_cache, know_region_cache, region_cache_forward)
39 (region_cache_backward, pp_cache):
40 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
41 so that ptrdiff_t * can be passed to xpalloc.
42 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
43 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
44 (pp_cache): Don't assume cache_len fits in int.
45 * region-cache.h: Adjust extern decls to match.
47 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
48 EMACS_INT, since either will do, for xpalloc.
50 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
51 (xnmalloc, xnrealloc, xpalloc): New functions.
53 * bidi.c (bidi_shelve_header_size): New constant.
54 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
55 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
57 * buffer.c (overlays_at, overlays_in, record_overlay_string)
59 Don't update size of array until after memory allocation succeeds,
60 because xmalloc/xrealloc may not return.
61 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
62 now that we have proper integer overflow checking.
63 (record_overlay_string, overlay_strings): Catch overflows when
64 calculating size of overlay_str_buf.
66 * callproc.c (Fcall_process): Check for size overflow when
67 calculating size of args2.
68 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
69 Normally we prefer signed values, but sticking with ptrdiff_t would
70 require adding more-complicated checks.
72 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
73 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
74 Redo buffer-overflow calculations to avoid integer overflow.
75 Add a FIXME comment where memory seems to be over-allocated.
77 * character.c (Fstring): Check for size-calculation overflow.
79 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
80 unnecessary integer overflow. Check for size overflow.
81 (encode_coding_object): Don't update size until xmalloc succeeds.
83 * composite.c (get_composition_id): Check for overflow in glyph
86 Integer and memory overflow fixes for display code.
87 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
88 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
89 (scrolling_window): Check for overflow in size calculations.
90 (line_draw_cost, realloc_glyph_pool, add_row_entry):
91 Don't assume glyph table len fits in int.
92 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
93 (row_table_size): Now ptrdiff_t, not int.
94 (scrolling_window): Avoid overflow in size calculations.
95 Don't update size until allocation succeeds.
96 * fns.c (concat): Check for overflow in size calculations.
97 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
98 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
99 (NEXT_ALMOST_PRIME_LIMIT): New constant.
101 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
102 (get_doc_string): Check for size calculation overflow.
103 Don't update size until allocation succeeds.
104 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
105 EMACS_INT, where ptrdiff_t will do.
106 (Fsubstitute_command_keys): Check for string overflow.
108 * editfns.c (set_time_zone_rule): Don't assume environment length
110 (message_length): Now ptrdiff_t, not int.
111 (Fmessage_box): Don't update size until allocation succeeds.
112 Don't assume message length fits in int.
113 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
115 * emacs.c (main): Do not reallocate argv, since there is a null at
116 the end that can be overwritten, and this way there's no need to
117 worry about size-calculation overflow.
118 (sort_args): Check for size-calculation overflow.
120 * eval.c (init_eval_once, grow_specpdl): Don't update size until
122 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
124 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
125 (x_set_scroll_bar_width, x_figure_window_size):
126 Check for integer overflow.
127 (x_set_alpha): Do not assume XINT fits in int.
129 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
130 This is for the members text_lines, text_cols, total_lines, total_cols,
131 where the system imposes an 'int' limit.
133 * fringe.c (Fdefine_fringe_bitmap):
134 Don't update size until alloc works.
136 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
137 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
139 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
140 Check for size-calculation overflow.
141 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
142 do, as we prefer signed integers.
143 (id_to_widget.max_size, id_to_widget.used)
144 (xg_store_widget_in_map, xg_remove_widget_from_map)
145 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
146 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
147 Use and return ptrdiff_t, not int.
148 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
149 * gtkutil.h: Change prototypes to match the above.
151 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
152 are duplicate now that they've been promoted to lisp.h.
153 (x_allocate_bitmap_record, x_alloc_image_color)
154 (make_image_cache, cache_image, xpm_load):
155 Don't update size until alloc is done.
156 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
158 Check for size calculation overflow.
159 (ct_colors_allocated_max): New constant.
160 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
163 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
164 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
165 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
166 Use ptrdiff_t, not int, to count maps.
167 (read_char_minibuf_menu_prompt): Check for overflow in size
168 calculations. Don't update size until allocation succeeds. Redo
169 calculations to avoid overflow.
170 * keyboard.h: Change prototypes to match the above.
172 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
174 (current_minor_maps): Check for size calculation overflow.
175 * keymap.h: Change prototypes to match the above.
177 * lread.c (read1, init_obarray): Don't update size until alloc done.
179 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
180 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
182 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
183 Now ptrdiff_t, not int.
184 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
185 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
187 * process.c (Fnetwork_interface_list): Check for overflow
190 * region-cache.c (move_cache_gap): Check for size calculation overflow.
192 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
193 overflow. Don't bother calling xmalloc when xrealloc will do.
195 * search.c (Freplace_match): Check for size calculation overflow.
196 (Fset_match_data): Don't assume list lengths fit in 'int'.
198 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
199 for command line length. Do not attempt to address one before the
200 beginning of an array, as that's not portable.
202 * term.c (max_frame_lines): Remove; unused.
203 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
205 (encode_terminal_code, calculate_costs): Check for size
206 calculation overflow.
207 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
208 table lengths and related sizes. Don't update size until alloc
209 done. Redo calculations to avoid overflow.
210 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
212 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
213 subtracting pointers.
214 (gobble_line): Check for overflow more carefully. Don't update size
217 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
218 Don't update size until alloc done.
219 Redo size calculations to avoid overflow.
220 Check for size calculation overflow.
221 (main) [DEBUG]: Fix typo in invoking tparam1.
223 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
224 Use ptrdiff_t, not int, for sizes.
225 (store_mode_line_noprop_char): Don't update size until alloc done.
227 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
228 Use ptrdiff_t, not int, for sizes.
229 (Finternal_make_lisp_face, cache_face):
230 Check for size calculation overflow.
231 (cache_face): Treat size calculation overflows as if they were
232 memory exhaustion (the usual treatment), rather than aborting.
234 * xfns.c (x_encode_text, x_set_name_internal)
235 (Fx_change_window_property): Use ptrdiff_t, not int, to count
236 sizes, since they can exceed INT_MAX in size. Check for size
237 calculation overflow.
239 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
240 (xg_select): Check for size calculation overflow.
241 Don't update size until alloc done.
243 * xrdb.c (get_environ_db): Don't assume path length fits in int,
244 as sprintf is limited to int lengths.
246 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
247 (X_LONG_MIN): New macros.
248 Use them to make the following changes clearer.
249 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
250 This change doesn't affect the value now, but it may help remind
251 future maintainers not to raise the value too much later.
252 (SELECTION_QUANTUM): Remove, replacing with ...
253 (selection_quantum): ... new function, which avoids overflow.
255 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
256 assumption that selection length fits in 'int'.
257 (x_reply_selection_request, x_handle_selection_request)
258 (x_get_window_property, receive_incremental_selection)
259 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
260 (lisp_data_to_selection_data, clean_local_selection_data):
261 Use ptrdiff_t, not int, to record length of selection.
262 (x_reply_selection_request, x_get_window_property)
263 (receive_incremental_selection, x_property_data_to_lisp):
264 Redo calculations to avoid overflow.
265 (x_reply_selection_request): When sending hint, ceiling it at
266 X_LONG_MAX rather than relying on wraparound overflow to send
268 (x_get_window_property, receive_incremental_selection)
269 (lisp_data_to_selection_data, x_property_data_to_lisp):
270 Check for size-calculation overflow.
271 (x_get_window_property, receive_incremental_selection)
272 (lisp_data_to_selection_data, Fx_register_dnd_atom):
273 Don't store size until memory allocation succeeds.
274 (x_get_window_property): Plug memory leak on memory exhaustion.
275 Don't double-block input; malloc is safe here. Don't assume 2**34
276 - 4 fits in unsigned long. Add an xassert to check
277 XGetWindowProperty overflow. Be more careful about overflow
278 calculations, and distinguish size from memory overflow better.
279 (receive_incremental_selection): When tracing, don't assume
280 unsigned int is less than INT_MAX.
281 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
282 harmful) conversions of unsigned short to int.
283 (lisp_data_to_selection_data): Don't assume that integers
284 in the range -65535 through -1 fit in an X unsigned short.
285 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
286 result parameters unless successful. Rely on cons_to_unsigned
287 to report problems with elements; the old code wasn't right anyway.
288 (x_check_property_data): Check for int overflow; we cannot use
289 a wider type due to X limits.
290 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
292 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
294 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
295 (x_term_init): Check for size calculation overflow.
296 (x_color_cells): Don't store size until memory allocation succeeds.
297 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
298 Don't assume alloca size is less than MAX_ALLOCA.
299 (x_term_init): Don't assume length fits in int (sprintf is limited
302 Use ptrdiff_t for composition IDs.
303 * character.c (lisp_string_width):
304 * composite.c (composition_table_size, n_compositions)
305 (get_composition_id, composition_gstring_from_id):
306 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
307 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
308 * window.c (Frecenter):
309 Use ptrdiff_t, not int, for composition IDs.
310 * composite.c (get_composition_id): Check for integer overflow.
311 * composite.h: Adjust prototypes to match the above changes.
313 Use ptrdiff_t for hash table indexes.
314 * category.c (hash_get_category_set):
315 * ccl.c (ccl_driver):
316 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
317 * coding.c (coding_system_charset_list, detect_coding_system):
318 * coding.h (struct coding_system.id):
319 * composite.c (get_composition_id, gstring_lookup_cache):
320 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
321 * image.c (xpm_get_color_table_h):
322 * lisp.h (hash_lookup, hash_put):
323 * minibuf.c (Ftest_completion):
324 Use ptrdiff_t for hash table indexes, not int (which is too
325 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
326 32-bit --with-wide-int hosts).
328 * charset.c (Fdefine_charset_internal): Check for integer overflow.
329 Add a FIXME comment about memory leaks.
330 (syms_of_charset): Don't assume xmalloc returns.
332 Don't assume that stated character widths fit in int.
333 * character.c (Fchar_width, c_string_width, lisp_string_width):
334 * character.h (CHAR_WIDTH):
335 * indent.c (MULTIBYTE_BYTES_WIDTH):
336 Use sanitize_char_width to avoid undefined and/or bad behavior
337 with outlandish widths.
338 * character.h (sanitize_tab_width): Renamed from sanitize_width,
339 now that we have two such functions. All uses changed.
340 (sanitize_char_width): New inline function.
342 Don't assume that tab-width fits in int.
343 * character.h (sanitize_width): New inline function.
344 (SANE_TAB_WIDTH): New macro.
345 (ASCII_CHAR_WIDTH): Use it.
346 * indent.c (sane_tab_width): Remove. All uses replaced by
347 SANE_TAB_WIDTH (current_buffer).
348 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
350 * fileio.c: Integer overflow issues with file modes.
351 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
353 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
354 Remove unreachable code.
355 (read_hex, load_charset_map_from_file): Check for integer overflow.
357 * xterm.c: don't go over XClientMessageEvent limit
358 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
359 (x_send_scroll_bar_event): Likewise. Check that the size does not
360 exceed limits imposed by XClientMessageEvent, as well as the usual
361 ptrdiff_t and size_t limits.
363 * keyboard.c: Overflow, signedness and related fixes.
364 (make_lispy_movement): Use same integer type in forward decl
365 that is used in the definition.
366 (read_key_sequence, keyremap_step):
367 Change bufsize argument back to int, undoing my 2011-03-30 change.
368 We prefer signed types, and int is wide enough here.
369 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
370 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
371 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
372 length, not size_t. Use ptrdiff_t for index, not int.
373 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
374 possibility of integer overflow.
376 Overflow, signedness and related fixes for images.
378 * dispextern.h (struct it.stack[0].u.image.image_id)
379 (struct_it.image_id, struct image.id, struct image_cache.size)
380 (struct image_cache.used, struct image_cache.ref_count):
381 * gtkutil.c (update_frame_tool_bar):
382 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
383 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
384 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
385 * nsmenu.m (update_frame_tool_bar):
386 * xdisp.c (calc_pixel_width_or_height):
387 * xfns.c (image_cache_refcount):
388 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
389 on typical 64-bit hosts.
391 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
392 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
393 Omit unnecessary casts to int.
394 (parse_image_spec): Check that integers fall into 'int' range
395 when the callers expect that.
396 (image_ascent): Redo ascent calculation to avoid int overflow.
397 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
398 (lookup_image): Remove unnecessary tests.
399 (xbm_image_p): Locals are now of int, not EMACS_INT,
400 since parse_image_check makes sure they fit into int.
401 (png_load, gif_load, svg_load_image):
402 Prefer int to unsigned where either will do.
403 (tiff_handler): New function, combining the cores of the
404 old tiff_error_handler and tiff_warning_handler. This
405 function is rewritten to use vsnprintf and thereby avoid
406 stack buffer overflows. It uses only the features of vsnprintf
407 that are common to both POSIX and native Microsoft.
408 (tiff_error_handler, tiff_warning_handler): Use it.
409 (tiff_load, gif_load, imagemagick_load_image):
410 Don't assume :index value fits in 'int'.
411 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
412 (imagemagick_load_image): Check that crop parameters fit into
413 the integer types that MagickCropImage accepts. Don't assume
414 Vimagemagick_render_type has a nonnegative value. Don't assume
415 size_t fits in 'long'.
416 (gs_load): Use printmax_t to print the widest integers possible.
417 Check for integer overflow when computing image height and width.
419 2011-08-16 Eli Zaretskii <eliz@gnu.org>
421 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
422 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
424 2011-08-16 Ken Brown <kbrown@cornell.edu>
426 Fix memory allocation problems in Cygwin build (Bug#9273).
428 * unexcw.c ( __malloc_initialized): Declare external variable.
429 (fixup_executable): Force the dumped emacs to reinitialize malloc.
431 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
433 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
435 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
437 [CYGWIN] (special_realloc): New function.
438 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
439 requests to realloc storage in the static heap.
441 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
443 * bidi.c (bidi_initialize): Remove unused local.
445 2011-08-15 Eli Zaretskii <eliz@gnu.org>
447 * biditype.h: File removed.
449 * bidimirror.h: File removed.
451 * deps.mk (bidi.o): Remove biditype.h and
454 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
457 * dispextern.h: Fix a typo in the comment to bidi_type_t.
459 * chartab.c: Improve commentary for the uniprop_table API.
461 * bidi.c (bidi_paragraph_init): Support zero value of
462 bidi_ignore_explicit_marks_for_paragraph_level.
463 (bidi_initialize): Use uniprop_table instead of including
464 biditype.h and bidimirror.h.
466 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
467 coordinates of the iterator when restoring from ppos_it.
470 2011-08-14 Kenichi Handa <handa@m17n.org>
472 * process.c (create_process): Call setup_process_coding_systems
473 after the pid of the process is set to -1.
475 2011-08-14 Eli Zaretskii <eliz@gnu.org>
477 * xdisp.c (move_it_in_display_line_to): Don't invoke
478 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
479 ppos_it. Fixes vertical cursor motion when line beginning is
480 covered by an image. (Bug#9296)
482 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
484 * nsterm.h (ns_run_ascript): Declare.
485 (NSAPP_DATA2_RUNASSCRIPT): Define.
487 * nsfns.m (as_script, as_result, as_status): New static variables.
488 (ns_run_ascript): New function.
489 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
490 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
491 the event loop. Get status from as_status (Bug#7276).
493 * nsterm.m (sendEvent): If event is NSApplicationDefined and
494 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
495 the event loop (Bug#7276).
497 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
499 * gnutls.c (QCgnutls_bootprop_priority)
500 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
501 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
502 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
503 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
504 (QCgnutls_bootprop_verify_hostname_error)
505 (QCgnutls_bootprop_callbacks_verify): Rename from
506 Qgnutls_bootprop_..., all uses changed.
508 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
511 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
513 * xfaces.c (Qframe_set_background_mode): Now static.
514 * dispextern.h (Qframe_set_background_mode): Remove decl.
516 * process.c (Fnetwork_interface_info): Declare local only if needed.
518 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
520 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
521 (Fnetwork_interface_list): Allocate in increments of bytes instead
522 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
523 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
525 (struct ifflag_def): notrailers is smart on OSX.
526 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
527 Get hardware address with getifaddrs if available.
529 2011-08-12 Eli Zaretskii <eliz@gnu.org>
531 * xdisp.c (iterate_out_of_display_property): xassert that
532 IT->position is set to within IT->object's boundaries. Break from
533 the loop as soon as EOB is reached; avoids infloops in redisplay
534 when IT->position is set up wrongly due to some bug. Set
535 IT->current to match the bidi iterator unconditionally.
536 (push_display_prop): Allow GET_FROM_STRING as IT->method on
537 entry. Force push_it to save on the stack the current
538 buffer/string position, to be restored by pop_it. Fix flags in
539 the iterator structure wrt the object coming from a display
540 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
541 properties. (Bug#9284)
543 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
545 * fontset.c (fontset_get_font_group): Add proper type checks.
548 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
550 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
551 and LC_VERSION_MIN_MACOSX.
552 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
553 (dump_it) [LC_FUNCTION_STARTS]: Use it.
555 2011-08-08 Eli Zaretskii <eliz@gnu.org>
557 * xdisp.c (forward_to_next_line_start): Allow to use the
558 no-display-properties-and-no-overlays under bidi display. Set
559 disp_pos in the bidi iterator to avoid searches for display
560 properties and overlays.
562 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
564 * editfns.c (Fset_time_zone_rule): Document relationship with the
567 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
568 the font entity extracted from the cache (Bug#8109).
570 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
572 * composite.c (autocmp_chars): Don't reset point. That is done by
573 restore_point_unwind (Bug#5984).
575 2011-08-07 Juri Linkov <juri@jurta.org>
577 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
578 to show the arg `TIME' instead of `TIMEVAL'.
580 2011-08-06 Eli Zaretskii <eliz@gnu.org>
582 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
583 display property strides EOL and includes a newline, as in
584 longlines-mode. (Bug#9254)
585 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
586 word-wrap under bidirectional display. (Bug#9224)
588 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
589 is non-zero, even if the data buffer is NULL. Fixes a crash in
590 vertical-motion with longlines-mode. (Bug#9254)
592 2011-08-05 Eli Zaretskii <eliz@gnu.org>
594 * bidi.c <bidi_cache_total_alloc>: Now static.
595 (bidi_initialize): Initialize bidi_cache_total_alloc.
597 *xdisp.c (display_line): Release buffer allocated for shelved bidi
600 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
601 amount allocated this far in `bidi_cache_total_alloc'.
602 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
603 non-zero, only free the data buffer without restoring the cache
604 contents. All callers changed.
606 * dispextern.h (bidi_unshelve_cache): Update prototype.
608 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
609 (move_it_in_display_line, move_it_to)
610 (move_it_vertically_backward, move_it_by_lines): Replace the call
611 to xfree to an equivalent call to bidi_unshelve_cache.
612 (move_it_in_display_line_to): Fix logic of returning
613 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
615 2011-08-05 Eli Zaretskii <eliz@gnu.org>
617 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
618 came from a string character with a `cursor' property. (Bug#9229)
620 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
622 * Makefile.in (LIB_PTHREAD): New variable.
623 (LIBES): Add LIB_PTHREAD (Bug#9216).
625 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
626 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
628 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
630 * regex.c (re_iswctype): Remove some redundant boolean
633 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
635 * xterm.c (x_find_topmost_parent): New function.
636 (x_set_frame_alpha): Find topmost parent window with
637 x_find_topmost_parent and set the property there also (bug#9181).
638 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
640 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
642 * callproc.c (Fcall_process): Avoid vfork clobbering
643 the local vars buffer, coding_systems, current_dir.
645 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
647 * keymap.c (Fmake_composed_keymap): Move to subr.el.
649 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
651 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
652 so that it is not optimized away.
654 * xdisp.c (compute_display_string_pos): Remove unused local.
656 2011-08-02 Eli Zaretskii <eliz@gnu.org>
658 Fix slow cursor motion and scrolling in large buffers with
659 selective display, like Org Mode buffers. (Bug#9218)
661 * dispextern.h (struct bidi_it): New member disp_prop_p.
663 * xdisp.c: Remove one-slot cache of display string positions.
664 (compute_display_string_pos): Accept an additional argument
665 DISP_PROP_P; callers changed. Scan at most 5K characters forward
666 for a display string or property. If found, set DISP_PROP_P
669 * bidi.c (bidi_fetch_char): Accept an additional argument
670 DISP_PROP_P, and pass it to compute_display_string_pos.
671 Only handle text covered by a display string if DISP_PROP_P is returned
672 non-zero. All callers of bidi_fetch_char changed.
674 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
676 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
678 2010-12-03 Don March <don@ohspite.net>
680 * keymap.c (Fdefine_key): Fix non-prefix key error message when
681 last character M-[char] is translated to ESC [char] (bug#7541).
683 2011-08-02 Kenichi Handa <handa@m17n.org>
685 * lisp.h (uniprop_table): Extern it.
687 * chartab.c (uniprop_table): Make it non-static.
689 2011-08-01 Eli Zaretskii <eliz@gnu.org>
691 * xdisp.c (forward_to_next_line_start): Accept additional argument
692 BIDI_IT_PREV, and store into it the state of the bidi iterator had
694 (reseat_at_next_visible_line_start): Use the bidi iterator state
695 returned by forward_to_next_line_start to restore the state of
696 it->bidi_it after backing up to previous newline. (Bug#9212)
698 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
700 * regex.c (re_comp): Protoize.
701 (re_exec): Fix return type.
702 (regexec): Fix type of `ret'. (Bug#9203)
704 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
706 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
707 This is needed if max-image-size is a floating-point number.
709 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
711 * print.c (print_object): Print empty symbol as ##.
713 * lread.c (read1): Read ## as empty symbol.
715 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
717 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
718 setting frame foreground color (Bug#9175).
719 (x_set_background_color): Likewise.
721 * nsmenu.m (-setText): Size tooltip dimensions precisely to
723 (EmacsTooltip -init): Remove bezels and add shadows to
726 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
727 or scroll bar (Bug#8470).
729 * nsfont.m (nsfont_open): Remove assignment to voffset and
730 unnecessary vars hshink, expand, hd, full_height, min_height.
731 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
733 * nsterm.h (nsfont_info): Remove voffset field.
735 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
737 Implement strike-through and overline on NextStep (Bug#8863).
739 * nsfont.m (nsfont_open): Use underline position provided by font,
740 instead of hard-coded value of 2.
741 (nsfont_draw): Call ns_draw_text_decoration instead.
743 * nsterm.h: Add declaration for ns_draw_text_decoration.
745 * nsterm.m (ns_draw_text_decoration): New function for drawing
746 underline, overline, and strike-through.
747 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
748 ns_draw_text_decoration. Change treatment of cursor drawing to
749 accomodate underlining, etc.
751 2011-07-28 Eli Zaretskii <eliz@gnu.org>
753 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
756 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
758 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
759 Without this fix, if a signal arrives just after memory fills up,
760 'malloc' might be invoked reentrantly.
762 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
763 In other words, assume that every image size is allowed, on non-X
764 hosts. This assumption is probably wrong, but it lets Emacs compile.
766 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
768 * regex.c (re_iswctype): Convert return values to boolean.
770 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
772 * xdisp.c (compute_display_string_pos): Don't use cached display
773 string position if the buffer had its restriction changed.
776 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
778 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
780 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
782 Integer signedness and overflow and related fixes. (Bug#9079)
784 * bidi.c: Integer size and overflow fixes.
785 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
786 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
787 (bidi_cache_find_level_change, bidi_cache_ensure_space)
788 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
789 (bidi_find_other_level_edge):
790 Use ptrdiff_t instead of EMACS_INT where either will do.
791 This works better on 32-bit hosts configured --with-wide-int.
792 (bidi_cache_ensure_space): Check for size-calculation overflow.
793 Use % rather than repeated addition, for better worst-case speed.
794 Don't set bidi_cache_size until after xrealloc returns, because it
796 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
797 (bidi_cache_ensure_space): Also check that the bidi cache size
798 does not exceed that of the largest Lisp string or buffer. See Eli
799 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
801 * alloc.c (__malloc_size_t): Remove.
802 All uses replaced by size_t. See Andreas Schwab's note
803 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
805 * image.c: Improve checking for integer overflow.
806 (check_image_size): Assume that f is nonnull, since
807 it is always nonnull in practice. This is one less thing to
808 worry about when checking for integer overflow later.
809 (x_check_image_size): New function, which checks for integer
810 overflow issues inside X.
811 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
812 This removes the need for a memory_full check.
813 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
814 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
815 (xbm_read_bitmap_data): Change locals back to 'int', since
816 their values must fit in 'int'.
817 (xpm_load_image, png_load, tiff_load):
818 Invoke x_create_x_image_and_pixmap earlier,
819 to avoid much needless work if the image is too large.
820 (tiff_load): Treat overly large images as if
821 x_create_x_image_and_pixmap failed, not as malloc failures.
822 (gs_load): Use x_check_image_size.
824 * gtkutil.c: Omit integer casts.
825 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
826 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
828 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
830 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
831 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
832 would wrongly return t on a 64-bit host.
834 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
835 The plain *_OVERFLOW macros run afoul of GCC bug 49705
836 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
837 and therefore cause GCC to emit a bogus diagnostic in some cases.
839 * image.c: Integer signedness and overflow and related fixes.
840 This is not an exhaustive set of fixes, but it's time to
841 record what I've got.
842 (lookup_pixel_color, check_image_size): Remove redundant decls.
843 (check_image_size): Don't assume that arbitrary EMACS_INT values
844 fit in 'int', or that arbitrary 'double' values fit in 'int'.
845 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
846 (tiff_load, imagemagick_load_image):
847 Check for overflow in size calculations.
848 (x_create_x_image_and_pixmap): Remove unnecessary test for
849 xmalloc returning NULL; that can't happen.
850 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
851 (xpm_color_bucket): Use better integer hashing function.
852 (xpm_cache_color): Don't possibly over-allocate memory.
853 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
855 Use ptrdiff_t, not int or size_t, to record sizes.
856 (png_load): Don't assume values greater than 2**31 fit in 'int'.
857 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
858 either works, as we prefer signed integers.
859 (tiff_read_from_memory, tiff_write_from_memory):
860 Return tsize_t, not size_t, since that's what the TIFF API wants.
861 (tiff_read_from_memory): Don't fail simply because the read would
862 go past EOF; instead, return a short read.
863 (tiff_load): Omit no-longer-needed casts.
864 (Fimagemagick_types): Don't assume size fits into 'int'.
866 Improve hashing quality when configured --with-wide-int.
867 * fns.c (hash_string): New function, taken from sxhash_string.
868 Do not discard information about ASCII character case; this
869 discarding is no longer needed.
870 (sxhash-string): Use it. Change sig to match it. Caller changed.
871 * lisp.h: Declare it.
872 * lread.c (hash_string): Remove, since we now use fns.c's version.
873 The fns.c version returns a wider integer if --with-wide-int is
874 specified, so this should help the quality of the hashing a bit.
876 * emacs.c: Integer overflow minor fix.
877 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
878 Define only if GNU_LINUX.
879 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
881 * dispnew.c: Integer signedness and overflow fixes.
882 Remove unnecessary forward decls, that were a maintenance hassle.
883 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
885 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
886 (scrolling_window): Use ptrdiff_t, not int, for byte count.
887 (prepare_desired_row, line_draw_cost):
888 Use int, not unsigned, where either works.
889 (save_current_matrix, restore_current_matrix):
890 Use ptrdiff_t, not size_t, where either works.
891 (init_display): Check for overflow more accurately, and without
892 relying on undefined behavior.
894 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
895 Remove, replacing with the new symbols in lisp.h. All uses changed.
896 * fileio.c (make_temp_name):
897 * filelock.c (lock_file_1, lock_file):
898 * xdisp.c (message_dolog):
899 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
900 Use pMd etc. instead.
901 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
902 replacing the pWIDE etc. symbols removed from editfns.c.
904 * keyboard.h (num_input_events): Now uintmax_t.
905 This is (very slightly) less likely to mess up due to wraparound.
908 * buffer.c: Integer signedness fixes.
909 (alloc_buffer_text, enlarge_buffer_text):
910 Use ptrdiff_t rather than size_t when either will do, as we prefer
913 * alloc.c: Integer signedness and overflow fixes.
914 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
915 (__malloc_size_t): Default to size_t, not to int.
916 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
917 (Fgarbage_collect, mark_object_loop_halt, mark_object):
918 Prefer ptrdiff_t to size_t when either would do, as we prefer
920 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
921 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
922 Now const. Initialize with values that are in range even if char
924 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
925 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
926 These functions do the right thing with sizes > 2**32.
927 (check_depth): Now ptrdiff_t, not int.
928 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
929 Adjust to new way of storing sizes. Check for size overflow bugs
931 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
932 slightly wrong anyway, as it missed one instance of
933 XMALLOC_OVERRUN_CHECK_OVERHEAD.
934 (refill_memory_reserve): Omit needless cast to size_t.
935 (mark_object_loop_halt): Mark as externally visible.
937 * xselect.c: Integer signedness and overflow fixes.
938 (Fx_register_dnd_atom, x_handle_dnd_message):
939 Use ptrdiff_t, not size_t, since we prefer signed.
940 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
941 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
942 x_dnd_atoms_size and x_dnd_atoms_length.
944 * doprnt.c: Prefer signed to unsigned when either works.
948 * xdisp.c (vmessage):
949 Use ptrdiff_t, not size_t, when using or implementing doprnt,
950 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
951 prefer signed arithmetic to avoid comparison confusion.
952 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
955 Assume freestanding C89 headers, string.h, stdlib.h.
956 * data.c, doprnt.c, floatfns.c, print.c:
957 Include float.h unconditionally.
958 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
959 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
960 * regex.c: Likewise for stddef.h, string.h.
961 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
962 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
963 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
964 (STDC_HEADERS): Remove obsolete defines.
965 * sysdep.c: Include limits.h unconditionally.
967 Assume support for memcmp, memcpy, memmove, memset.
968 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
969 * regex.c (memcmp, memcpy):
970 Remove; we assume C89 now.
972 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
973 (__malloc_safe_bcopy): Remove; no longer needed.
975 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
976 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
977 well either way, and we prefer signed to unsigned.
979 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
981 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
982 closes the connection while we're reading (bug#9182).
984 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
986 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
987 are specified (Bug#9168).
989 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
991 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
992 Found by GCC static checking and --with-wide-int on a 32-bit host.
994 2011-07-25 Eli Zaretskii <eliz@gnu.org>
996 * xdisp.c (compute_display_string_pos): Fix logic of caching
997 previous display string position. Initialize cached_prev_pos to
998 -1. Fixes slow-down at the beginning of a buffer.
1000 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1002 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1003 for attrs[LFACE_FONTSET_INDEX].
1005 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1007 * xml.c (parse_region): Remove unused local
1008 that was recently introduced.
1010 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1012 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1013 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1015 * xdisp.c (move_it_in_display_line_to): Record the best matching
1016 position for TO_CHARPOS while scanning the line, and restore it on
1017 exit if none of the characters scanned was an exact match.
1018 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1019 when exact match is impossible due to invisible text, and the
1020 lines are truncated.
1022 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1024 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1027 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1029 Fix a significant slow-down of cursor motion with C-n, C-p,
1030 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1031 auto-repeat under bidi redisplay in fontified buffers.
1032 * xdisp.c (compute_stop_pos_backwards): New function.
1033 (next_element_from_buffer): Call compute_stop_pos_backwards to
1034 find a suitable prev_stop when we find ourselves before
1036 (reseat): Don't look for prev_stop, as that could mean a very long
1038 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1039 <cached_disp_overlay_modiff>: Cache for last found display string
1041 (compute_display_string_pos): Return the cached position if asked
1042 about the same buffer in the same area of character positions, and
1043 the buffer wasn't changed since the time the display string
1044 position was cached.
1046 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1048 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1049 is an integer, which is important for empty lines. (Bug#9149)
1051 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1053 * frame.c (Fmodify_frame_parameters): In tty case, update the
1054 default face if necessary (Bug#4238).
1056 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1058 * editfns.c (Fstring_to_char): No need to explain what a character
1059 is in the docstring (Bug#6576).
1061 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1063 * xml.c (parse_region): Make sure we always return a tree.
1065 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1067 * xml.c (parse_region): If a document contains only comments,
1070 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1072 * xml.c (make_dom): Return comments, too.
1074 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1077 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1078 and the surrounding thread.
1079 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1080 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1081 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1083 * s/openbsd.h (BROKEN_SIGIO): Define.
1084 * unexelf.c (unexec) [__OpenBSD__]:
1085 Don't update the .mdebug section of the Alpha COFF symbol table.
1087 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1089 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1092 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1094 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1095 This fixes some race conditions on the permissions of any newly
1098 * alloc.c (valid_pointer_p): Use pipe, not open.
1099 This fixes some permissions issues when debugging.
1101 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1102 If fchown fails to set both uid and gid, try to set just gid,
1103 as that is sometimes allowed. Adjust the file's mode to eliminate
1104 setuid or setgid bits that are inappropriate if fchown fails.
1106 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1108 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1109 to compare Lisp_Objects.
1110 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1111 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1112 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1114 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1116 * lread.c (read_integer): Unread even EOF character.
1117 (read1): Likewise. Properly record start position of symbol.
1119 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1120 symbol character follows.
1122 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1124 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1125 This works around a problem with the previous change to Fcopy_file.
1126 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1127 and without this change, GCC might complain about discarding
1128 fchown's return value.
1130 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1132 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1134 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1136 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1138 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1140 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1141 it's used from the C level.
1143 * process.c: Use the same condition for POLL_FOR_INPUT in both
1144 keyboard.c and process.c (bug#1858).
1146 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1148 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1149 (Fgnutls_boot): Use it.
1151 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1153 * doc.c (Fsubstitute_command_keys): Revert last change.
1155 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1157 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1158 quotes the next character, and doesn't affect other longer
1159 sequences (bug#8935).
1161 * lread.c (syms_of_lread): Clarify that is isn't only
1162 `eval-buffer' and `eval-defun' that's affected by
1163 `lexical-binding' (bug#8460).
1165 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1167 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1168 bidi redisplay when a line includes both an image and is
1171 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1173 Fix minor problems found by static checking.
1174 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1175 (elsz): Now a signed constant, not a size_t var. We prefer signed
1176 types to unsigned, to avoid integer comparison confusion. Without
1177 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1178 "cannot optimize loop, the loop counter may overflow", a symptom
1180 * indent.c (Fvertical_motion): Mark locals as initialized.
1181 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1183 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1185 * search.c (Fre_search_backward): Mention `case-fold-search' in
1186 all the re_search_* functions (bug#8138).
1188 * keyboard.c (Fopen_dribble_file): Document when the file is
1191 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1193 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1196 Support bidi reordering of display and overlay strings.
1197 * xdisp.c (compute_display_string_pos)
1198 (compute_display_string_end): Accept additional argument STRING.
1199 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1200 (reseat_to_string): Initialize bidi_it->string.s and
1201 bidi_it->string.schars.
1202 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1203 NULL (avoids a crash in bidi_paragraph_init).
1204 Initialize itb.string.lstring.
1205 (init_iterator): Call bidi_init_it only of a valid
1206 buffer position was specified. Initialize paragraph_embedding to
1208 (reseat_to_string): Initialize the bidi iterator.
1209 (display_string): If we need to ignore text properties of
1210 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1211 original value of -1 will not work with bidi.)
1212 (compute_display_string_pos): First arg is now struct
1213 `text_pos *'; all callers changed. Support display properties on
1215 (compute_display_string_end): Support display properties on Lisp
1217 (init_iterator, reseat_1, reseat_to_string): Initialize the
1218 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1219 when iterating on a string not from display properties).
1220 (compute_display_string_pos, compute_display_string_end):
1221 Fix calculation of the object to scan. Fixes an error when using
1223 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1224 base_level_stop; instead, set base_level_stop to BEGV.
1225 Fixes crashes in vertical-motion.
1226 (next_element_from_buffer): Improve commentary for when
1227 the iterator is before prev_stop.
1228 (init_iterator): Initialize bidi_p from the default value of
1229 bidi-display-reordering, not from buffer-local value. Use the
1230 buffer-local value only if initializing for buffer iteration.
1231 (handle_invisible_prop): Support invisible properties on strings
1232 that are being bidi-reordered.
1233 (set_iterator_to_next): Support bidi reordering of C strings and
1235 (next_element_from_string): Support bidi reordering of Lisp
1237 (handle_stop_backwards): Support Lisp strings as well.
1238 (display_string): Support display of R2L glyph rows.
1239 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1240 (init_iterator): Don't initialize it->bidi_p for strings
1242 (reseat_to_string): Initialize it->bidi_p for strings here.
1243 (next_element_from_string, next_element_from_c_string)
1244 (next_element_from_buffer): Add xassert's for correspondence
1245 between IT's object being iterated and it->bidi_it.string
1247 (face_before_or_after_it_pos): Support bidi iteration.
1248 (next_element_from_c_string): Handle the case of the first string
1249 character that is not the first one in the visual order.
1250 (get_visually_first_element): New function, refactored from common
1251 parts of next_element_from_buffer, next_element_from_string, and
1252 next_element_from_c_string.
1253 (tool_bar_lines_needed, redisplay_tool_bar)
1254 (display_menu_bar): Force left-to-right direction. Add a FIXME
1255 comment for making that be controlled by a user option.
1256 (push_it, pop_it): Save and restore the state of the
1257 bidi iterator. Save and restore the bidi_p flag.
1258 (pop_it): Iterate out of display property for string iteration as
1260 (iterate_out_of_display_property): Support iteration over strings.
1261 (handle_single_display_spec): Set up it->bidi_it for iteration
1262 over a display string, and call bidi_init_it.
1263 (handle_single_display_spec, next_overlay_string)
1264 (get_overlay_strings_1, push_display_prop): Set up the bidi
1265 iterator for displaying display or overlay strings.
1266 (forward_to_next_line_start): Don't use the shortcut if
1268 (back_to_previous_visible_line_start): If handle_display_prop
1269 pushed the iterator stack, restore the internal state of the bidi
1270 iterator by calling bidi_pop_it same number of times.
1271 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1272 and we are bidi-iterating, don't decrement the iterator position;
1273 instead, set the first_elt flag in the bidi iterator, to produce
1275 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1276 (push_display_prop): xassert that we are iterating a buffer.
1277 (push_it, pop_it): Save and restore paragraph_embedding member.
1278 (handle_single_display_spec, next_overlay_string)
1279 (get_overlay_strings_1, reseat_1, reseat_to_string)
1280 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1281 correctly. Don't assume unibyte strings are not bidi-reordered.
1282 (compute_display_string_pos)
1283 (compute_display_string_end): Fix handling the case of C string.
1284 (push_it, pop_it): Save and restore from_disp_prop_p.
1285 (handle_single_display_spec, push_display_prop): Set the
1286 from_disp_prop_p flag.
1287 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1288 (pop_it): Call iterate_out_of_display_property only if we are
1289 popping after iteration over a string that came from a display
1290 property. Fix a typo in popping stretch info. Add an assertion
1291 for verifying that the iterator position is in sync with the bidi
1293 (handle_single_display_spec, get_overlay_strings_1)
1294 (push_display_prop): Fix initialization of paragraph direction for
1295 string when that of the parent object is not yet determined.
1296 (reseat_1): Call bidi_init_it to resync the bidi
1297 iterator with IT's position. (Bug#7616)
1298 (find_row_edges): If ROW->start.pos gives position
1299 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1300 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1301 Reset the from_disp_prop_p flag.
1302 (SAVE_IT, RESTORE_IT): New macros.
1303 (pos_visible_p, face_before_or_after_it_pos)
1304 (back_to_previous_visible_line_start)
1305 (move_it_in_display_line_to, move_it_in_display_line)
1306 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1307 (try_scrolling, redisplay_window, display_line): Use them when
1308 saving a temporary copy of the iterator and restoring it back.
1309 (back_to_previous_visible_line_start, reseat_1)
1310 (init_iterator): Empty the bidi cache "stack".
1311 (move_it_in_display_line_to): If iterator ended up at
1312 EOL, but we never saw any buffer positions smaller than
1313 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1314 motion in bidi-reordered lines.
1315 (move_it_in_display_line_to): Record prev_method and prev_pos
1316 immediately before the call to set_iterator_to_next. Fixes cursor
1317 motion in bidi-reordered lines with stretch glyphs and strings
1318 displayed in margins. (Bug#8133) (Bug#8867)
1319 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1321 (pos_visible_p): Support positions in bidi-reordered lines.
1322 Save and restore bidi cache.
1324 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1325 (bidi_paragraph_info): Delete unused struct.
1326 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1327 (bidi_cache_start): New variable.
1328 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1330 (bidi_cache_fetch_state, bidi_cache_search)
1331 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1332 (bidi_cache_find, bidi_peek_at_next_level)
1333 (bidi_level_of_next_char, bidi_find_other_level_edge)
1334 (bidi_move_to_visually_next): Compare cache index with
1335 bidi_cache_start rather than with zero.
1336 (bidi_fetch_char): Accept new argument STRING; all callers
1337 changed. Support iteration over a string. Support strings with
1338 display properties. Support unibyte strings. Fix the type of
1339 `len' according to what STRING_CHAR_AND_LENGTH expects.
1340 (bidi_paragraph_init, bidi_resolve_explicit_1)
1341 (bidi_resolve_explicit, bidi_resolve_weak)
1342 (bidi_level_of_next_char, bidi_move_to_visually_next):
1343 Support iteration over a string.
1344 (bidi_set_sor_type, bidi_resolve_explicit_1)
1345 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1346 can now be zero (for strings); special values 0 and -1 were
1347 changed to -1 and -2, respectively.
1348 (bidi_char_at_pos): New function.
1349 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1350 Call it instead of FETCH_MULTIBYTE_CHAR.
1351 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1352 initialized to valid values.
1353 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1355 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1356 the test for valid cached positions. Fix the logic for looking up
1357 the sentinel state in the cache. GCPRO the Lisp string we are
1359 (bidi_push_it, bidi_pop_it): New functions.
1360 (bidi_initialize): Initialize the bidi cache start stack pointer.
1361 (bidi_cache_ensure_space): New function, refactored from part of
1362 bidi_cache_iterator_state. Don't assume the required size is just
1363 one BIDI_CACHE_CHUNK away.
1364 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1365 (bidi_count_bytes, bidi_char_at_pos): New functions.
1366 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1367 always valid if bidi_cache_idx is valid.
1368 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1369 is valid if it's going to be used.
1370 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1371 (bidi_cache_fetch_state, bidi_cache_search)
1372 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1373 (bidi_cache_iterator_state, bidi_cache_find)
1374 (bidi_find_other_level_edge, bidi_cache_start_stack):
1375 All variables related to cache indices are now EMACS_INT.
1377 * dispextern.h (struct bidi_string_data): New structure.
1378 (struct bidi_it): New member `string'. Make flag members be 1-bit
1379 fields, and put them last in the struct.
1380 (compute_display_string_pos, compute_display_string_end):
1382 (bidi_push_it, bidi_pop_it): Add prototypes.
1383 (struct iterator_stack_entry): New members bidi_p,
1384 paragraph_embedding, and from_disp_prop_p.
1385 (struct it): Member bidi_p is now a bit field 1 bit wide.
1386 (bidi_shelve_cache, bidi_unshelve_cache):
1389 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1390 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1391 and vector-like objects.
1393 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1394 cache around display iteration.
1396 * window.c (Fwindow_end, window_scroll_pixel_based)
1397 (displayed_window_lines, Frecenter): Save and restore the bidi
1398 cache around display iteration.
1400 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1402 * editfns.c (Fdelete_region): Clarify the use of the named
1403 parameters (bug#6788).
1405 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1407 * indent.c (Fvertical_motion): Set and restore w->pointm when
1408 saving and restoring the window's buffer (Bug#9006).
1410 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1412 * editfns.c (Fstring_to_char): Clarify just what is returned
1413 (bug#6576). Text by Eli Zaretskii.
1415 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1417 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1419 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1421 * buffer.c (mmap_find): Fix a typo.
1423 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1425 Fix execution of x selection hooks.
1426 * xselect.c (Qx_lost_selection_functions)
1427 (Qx_sent_selection_functions): New vars.
1428 (syms_of_xselect): DEFSYM them.
1429 (x_handle_selection_request): Pass Qx_sent_selection_functions
1430 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1431 (x_handle_selection_clear,x_clear_frame_selections):
1432 Pass Qx_lost_selection_functions rather than
1433 Vx_lost_selection_functions to Frun_hook_with_args.
1435 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1437 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1438 The old code sometimes used this field without initializing it.
1440 * alloc.c (gc_sweep): Don't read past end of array.
1441 In theory, the old code could also have corrupted Emacs internals,
1442 though it'd be very unlikely.
1444 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1446 * character.c (Fcharacterp): Don't advertise optional ignored
1447 argument. (Bug#4026)
1449 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1451 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1454 * window.c (Fset_window_start): Doc fix (bug#4199).
1455 (Fset_window_hscroll): Ditto.
1457 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1459 Fix minor new problems caught by GCC 4.6.1.
1460 * term.c (init_tty): Remove unused local.
1461 * xsettings.c (store_monospaced_changed): Define this function only
1462 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1465 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1467 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1469 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1471 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1472 are the mini-buffer and the echo area (bug#3320).
1474 * term.c (init_tty): Remove support for supdup, c10 and perq
1475 terminals, which are no longer supported (bug#1482).
1477 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1479 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1481 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1483 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1484 for non-popups (Bug#3642).
1486 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1488 * alloc.c (reset_malloc_hooks): Protoize.
1489 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1490 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1491 * cm.c (losecursor): Likewise.
1492 * data.c (fmod): Likewise.
1493 * dispnew.c (swap_glyphs_in_rows): Likewise.
1494 * emacs.c (memory_warning_signal): Likewise.
1495 * floatfns.c (float_error): Likewise.
1496 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1497 (otf_open, font_otf_capability, generate_otf_features)
1498 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1500 * image.c (pbm_read_file): Likewise.
1501 * indent.c (string_display_width): Likewise.
1502 * intervals.c (check_for_interval, search_for_interval)
1503 (inc_interval_count, count_intervals, root_interval)
1504 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1505 * lread.c (defalias): Likewise.
1506 * ralloc.c (r_alloc_check): Likewise.
1507 * regex.c (set_image_of_range_1, set_image_of_range)
1508 (regex_grow_registers): Likewise.
1509 * sysdep.c (strerror): Likewise.
1510 * termcap.c (valid_filename_p, tprint, main): Likewise.
1511 * tparam.c (main): Likewise.
1512 * unexhp9k800.c (run_time_remap, save_data_space)
1513 (update_file_ptrs, read_header, write_header, calculate_checksum)
1514 (copy_file, copy_rest, display_header): Likewise.
1515 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1517 * xdisp.c (check_it): Likewise.
1518 * xfaces.c (register_color, unregister_color, unregister_colors):
1520 * xfns.c (print_fontset_result): Likewise.
1521 * xrdb.c (member, fatal, main): Likewise.
1523 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1525 Fix minor problems found by static checking (Bug#9031).
1526 * chartab.c (char_table_set_range, map_sub_char_table):
1527 Remove unused locals.
1528 (uniprop_table): Now static.
1529 * composite.c (_work_char): Remove unused static var.
1531 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1533 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1535 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1537 * gtkutil.c (qttip_cb): Remove code without function.
1539 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1541 * w32.c (pthread_sigmask): New stub.
1543 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1545 Use pthread_sigmask, not sigprocmask (Bug#9010).
1546 sigprocmask is portable only for single-threaded applications, and
1547 Emacs can be multi-threaded when it uses GTK.
1548 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1550 * callproc.c (Fcall_process):
1551 * process.c (create_process):
1552 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1553 Use pthread_sigmask, not sigprocmask.
1555 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1557 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1558 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1561 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1563 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1564 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1565 (xg_hide_tooltip): Fix comment.
1567 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1568 in registerServicesMenuSendTypes.
1569 (validRequestorForSendType): Don't check ns_return_types.
1571 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1574 2011-07-08 Jason Rumney <jasonr@gnu.org>
1576 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1577 frame struct members of non-existent frames (Bug#6284).
1579 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1581 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1582 variable firstTime not needed on OSX >= 10.6.
1583 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1584 >= 10.5. Use setKnobProportion, setDoubleValue.
1586 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1587 (MAC_OS_X_VERSION_10_5): Define if not defined.
1588 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1589 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1590 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1592 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1593 cString and lossyCString on OSX >= 10.4
1595 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1596 sizeToFit on OSX >= 10.2.
1598 * nsimage.m (allocInitFromFile): Don't use deprecated method
1599 bestRepresentationForDevice on OSX >= 10.6.
1601 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1604 * emacs.c: Declare unexec_init_emacs_zone.
1606 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1608 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1610 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1611 on svcsMenu (Bug#8842).
1613 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1615 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1617 * nsterm.m (QUTF8_STRING): Declare.
1618 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1619 (validRequestorForSendType): Return type is (id).
1620 Change indexOfObjectIdenticalTo to indexOfObject.
1621 Check if we have local selection before returning self (Bug#8842).
1622 (writeSelectionToPasteboard): Put local selection into paste board
1623 if we have a local selection (Bug#8842).
1624 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1626 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1627 (ns_get_local_selection): Declare.
1629 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1631 * keymap.c (describe_map_tree): Don't insert a double newline at
1632 the end of the buffer (bug#1169) and return whether we inserted
1635 * callint.c (Fcall_interactively): Change "reading args" to
1636 "providing args" to try to clarify what it does (bug#1010).
1638 2011-07-07 Kenichi Handa <handa@m17n.org>
1640 * composite.c (composition_compute_stop_pos): Ignore a static
1641 composition starting before CHARPOS (Bug#8915).
1643 * xdisp.c (handle_composition_prop): Likewise.
1645 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1647 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1650 2011-07-07 Kenichi Handa <handa@m17n.org>
1652 * character.h (unicode_category_t): New enum type.
1654 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1655 (Qchar_code_property_table): New variable.
1656 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1657 (UNIPROP_COMPRESSED_FORM_P): New macros.
1658 (char_table_ascii): Uncompress the compressed values.
1659 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1660 Uncompress the compressed values.
1661 (sub_char_table_ref_and_range): Likewise.
1662 (char_table_ref_and_range): Uncompress the compressed values.
1663 (sub_char_table_set): New arg is_uniprop. Callers changed.
1664 Uncompress the compressed values.
1665 (sub_char_table_set_range): Args changed. Callers changed.
1666 (char_table_set_range): Adjuted for the above change.
1667 (map_sub_char_table): Delete args default_val and parent. Add arg
1668 top. Give decoded values to a Lisp function.
1669 (map_char_table): Adjust for the above change. Give decoded
1670 values to a Lisp function. Gcpro more variables.
1671 (uniprop_table_uncompress)
1672 (uniprop_decode_value_run_length): New functions.
1673 (uniprop_decoder, uniprop_decoder_count): New variables.
1674 (uniprop_get_decoder, uniprop_encode_value_character)
1675 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1677 (uniprop_encoder, uniprop_encoder_count): New variables.
1678 (uniprop_get_encoder, uniprop_table)
1679 (Funicode_property_table_internal, Fget_unicode_property_internal)
1680 (Fput_unicode_property_internal): New functions.
1681 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1682 Sunicode_property_table_internal, Sget_unicode_property_internal,
1683 and Sput_unicode_property_internal. Defvar_lisp
1684 char-code-property-alist.
1686 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1687 Vunicode_category_table.
1689 * font.c (font_range): Adjust for the change of
1690 Vunicode_category_table.
1692 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1694 * m/iris4d.h: Remove file, move contents ...
1695 * s/irix6-5.h: ... here.
1697 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1699 Remove unportable assumption about struct layout (Bug#8884).
1700 * alloc.c (mark_buffer):
1701 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1702 (clone_per_buffer_values): Don't assume that
1703 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1704 This isn't true in general, and it's particularly not true
1705 if Emacs is configured with --with-wide-int.
1706 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1707 New macros, used in the buffer.c change.
1709 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1711 * xsettings.c: Use both GConf and GSettings if both are available.
1712 (store_config_changed_event): Add comment.
1713 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1714 (store_tool_bar_style_changed): New functions.
1715 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1716 (struct xsettings): Move font inside HAVE_XFT.
1717 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1718 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1719 Move inside HAVE_XFT.
1720 (something_changed_gsettingsCB): Rename from something_changedCB.
1721 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1723 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1724 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1725 (something_changed_gconfCB): Rename from something_changedCB.
1726 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1727 (parse_settings): Move check for font inside HAVE_XFT.
1728 (read_settings, apply_xft_settings): Add comment.
1729 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1730 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1731 call store_font_name_changed.
1732 (xft_settings_event): Add comment.
1733 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1734 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1735 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1736 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1737 (xsettings_initialize): Call init_gsettings last.
1738 (xsettings_get_system_font, xsettings_get_system_normal_font):
1741 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1743 Random fixes. E.g., (random) never returned negative values.
1744 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1745 subseconds part to the entropy, as that's a bit more random.
1746 Prefer signed to unsigned, since the signedness doesn't matter and
1747 in general we prefer signed. When given a limit, use a
1748 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1749 latter isn't right if USE_2_TAGS_FOR_INTS.
1750 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1751 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1753 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1755 * textprop.c (text_property_stickiness):
1756 Obey Vtext_property_default_nonsticky.
1757 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1758 * w32fns.c (syms_of_w32fns):
1759 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1761 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1763 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1764 This is more efficient than Ffile_directory_p and avoids a minor race.
1766 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1768 * buffer.c (Foverlay_put): Say what the return value is
1771 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1772 is a directory before asking whether to use the file name
1774 (barf_or_query_if_file_exists): Make the "File is a directory"
1775 error be more correct.
1777 * fns.c (Frequire): Remove the mention of the .gz files, since
1778 that's installation-specific, but keep the mention of
1779 `get-load-suffixes'.
1781 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1783 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1784 Report string overflow if the output is too long.
1786 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1788 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1789 (syms_of_gnutls): Remove duplicate DEFSYM for
1790 Qgnutls_bootprop_verify_hostname_error, an error for
1791 Qgnutls_bootprop_verify_error (which is no longer used).
1793 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1794 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1795 Also (re)move comments that are misplaced or no longer relevant.
1797 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1799 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1801 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1803 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1804 and background color parameters if they have been changed.
1806 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1808 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1810 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1812 * xsettings.c (SYSTEM_FONT): Define only when used.
1813 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1815 * keymap.c (access_keymap_1): Now static.
1817 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1819 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1820 leave any prefix arg for the up event (Bug#1586).
1822 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1824 * lread.c (syms_of_lread): Mention single symbols defined by
1825 `defvar' or `defconst' (bug#7154).
1827 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1828 (Frequire): Mention get-load-suffixes.
1830 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1832 * window.h (window): Remove clone_number slot.
1833 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1835 (make_parent_window, make_window, saved_window)
1836 (Fset_window_configuration, save_window_save): Don't deal with
1838 * buffer.c (Qclone_number): Remove declaration.
1839 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1841 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1843 Add multiple inheritance to keymaps.
1844 * keymap.c (Fmake_composed_keymap): New function.
1845 (Fset_keymap_parent): Simplify.
1846 (fix_submap_inheritance): Remove.
1847 (access_keymap_1): New function extracted from access_keymap to handle
1848 embedded parents and handle lists of maps.
1849 (access_keymap): Use it.
1850 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1851 (Fcopy_keymap): Handle embedded parents.
1852 (Fcommand_remapping, define_as_prefix): Simplify.
1853 (Fkey_binding): Simplify.
1854 (syms_of_keymap): Move minibuffer-local-completion-map,
1855 minibuffer-local-filename-completion-map,
1856 minibuffer-local-must-match-map, and
1857 minibuffer-local-filename-must-match-map to Elisp.
1858 (syms_of_keymap): Defsubr make-composed-keymap.
1859 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1860 (parse_menu_item): Trivial simplification.
1862 2011-07-01 Glenn Morris <rgm@gnu.org>
1864 * Makefile.in (SETTINGS_LIBS): Fix typo.
1866 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1868 * coding.c (Fencode_coding_string): Record the last coding system
1869 used, as the function doc string says (bug#8738).
1871 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1873 * xsettings.c (store_monospaced_changed): Take new font as arg and
1874 check for change against current_mono_font.
1875 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1876 (emacs_settings_constructor, emacs_settings_get_property)
1877 (emacs_settings_set_property, emacs_settings_class_init)
1878 (emacs_settings_init, gsettings_obj): Remove.
1879 (something_changedCB): New function for HAVE_GSETTINGS.
1880 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1881 with value as argument.
1882 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1883 g_settings_new (Bug#8967). Do not create gsettings_obj.
1884 Remove calls to g_settings_bind. Connect something_changedCB to
1887 * xgselect.c: Add defined (HAVE_GSETTINGS).
1888 (xgselect_initialize): Ditto.
1890 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1891 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1894 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1896 * eval.c (struct backtrace): Simplify and port the data structure.
1897 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1898 signed bit field, as this assumption is not portable and it makes
1899 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1900 "char debug_on_exit : 1" as this is not portable either; instead,
1901 use the portable "unsigned int debug_on_exit : 1". Remove unused
1902 member evalargs. Remove obsolete comments about cc bombing out.
1904 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1906 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1907 Let HAVE_GSETTINGS override HAVE_GCONF.
1908 (store_monospaced_changed): New function.
1909 (EMACS_SETTINGS): A new type derived from GObject to handle
1910 GSettings notifications.
1911 (emacs_settings_constructor, emacs_settings_get_property)
1912 (emacs_settings_set_property, emacs_settings_class_init):
1914 (gsettings_client, gsettings_obj): New variables.
1915 (GSETTINGS_SCHEMA): New define.
1916 (something_changedCB): Call store_monospaced_changed.
1917 (init_gsettings): New function.
1918 (xsettings_initialize): Call init_gsettings.
1919 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1922 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1925 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1927 * window.c (resize_root_window, grow_mini_window)
1928 (shrink_mini_window): Rename Qresize_root_window to
1929 Qwindow_resize_root_window and Qresize_root_window_vertically to
1930 Qwindow_resize_root_window_vertically.
1932 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1934 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1936 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1938 * makefile.w32-in: Redesign dependencies so they reflect more
1939 clearly which files are directly included by each source file,
1940 and not through other includes.
1942 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1944 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1945 (sort_overlays, overlay_strings): When an overlay's clone number
1946 matches the window's clone number process the overlay even if
1947 the overlay's window property doesn't match the current window.
1949 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1950 (Fwindow_hchild): Rename to Fwindow_left_child.
1951 (Fwindow_next): Rename to Fwindow_next_sibling.
1952 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1953 (resize_window_check): Rename to window_resize_check.
1954 (resize_window_apply): Rename to window_resize_apply.
1955 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1956 (Fdelete_other_windows_internal, resize_frame_windows)
1957 (Fsplit_window_internal, Fdelete_window_internal)
1958 (grow_mini_window, shrink_mini_window)
1959 (Fresize_mini_window_internal): Fix callers accordingly.
1961 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1963 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1964 (emacs_fixed_set_min_size): Remove.
1965 (emacs_fixed_new): Take frame as argument.
1967 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1968 (_EmacsFixedPrivate): Remove minwidth/height.
1969 Add struct frame *f.
1970 (emacs_fixed_init): Initialize priv->f.
1971 (get_parent_class, emacs_fixed_set_min_size): Remove.
1972 (emacs_fixed_new): Set priv->f to argument.
1973 (emacs_fixed_get_preferred_width)
1974 (emacs_fixed_get_preferred_height): Use min_width/height from
1975 frames size_hint to set minimum and natural (Bug#8919).
1976 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1977 and use min_width/height from frames size_hint to set
1978 min_width/height (Bug#8919).
1980 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1981 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1984 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1986 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1987 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1990 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1992 * process.c (wait_reading_process_output): Bypass select if
1993 waiting for a cell while ignoring keyboard input, and input is
1994 pending. Suggested by Jan Djärv (Bug#8869).
1996 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1998 Use gnulib's dup2 module instead of rolling our own.
1999 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2001 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2003 * dispnew.c (scrolling_window): Before scrolling, turn off a
2004 mouse-highlight in the window being scrolled.
2006 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2008 Move DEFSYM to lisp.h and use everywhere.
2010 * character.h (DEFSYM): Move declaration...
2011 * lisp.h (DEFSYM): ...here.
2017 * w32select.c: Don't include character.h.
2019 * alloc.c (syms_of_alloc):
2020 * buffer.c (syms_of_buffer):
2021 * bytecode.c (syms_of_bytecode):
2022 * callint.c (syms_of_callint):
2023 * casefiddle.c (syms_of_casefiddle):
2024 * casetab.c (init_casetab_once):
2025 * category.c (init_category_once, syms_of_category):
2026 * ccl.c (syms_of_ccl):
2027 * cmds.c (syms_of_cmds):
2028 * composite.c (syms_of_composite):
2029 * dbusbind.c (syms_of_dbusbind):
2030 * dired.c (syms_of_dired):
2031 * dispnew.c (syms_of_display):
2032 * doc.c (syms_of_doc):
2033 * editfns.c (syms_of_editfns):
2034 * emacs.c (syms_of_emacs):
2035 * eval.c (syms_of_eval):
2036 * fileio.c (syms_of_fileio):
2037 * fns.c (syms_of_fns):
2038 * frame.c (syms_of_frame):
2039 * fringe.c (syms_of_fringe):
2040 * insdel.c (syms_of_insdel):
2041 * keymap.c (syms_of_keymap):
2042 * lread.c (init_obarray, syms_of_lread):
2043 * macros.c (syms_of_macros):
2044 * msdos.c (syms_of_msdos):
2045 * print.c (syms_of_print):
2046 * process.c (syms_of_process):
2047 * search.c (syms_of_search):
2048 * sound.c (syms_of_sound):
2049 * syntax.c (init_syntax_once, syms_of_syntax):
2050 * terminal.c (syms_of_terminal):
2051 * textprop.c (syms_of_textprop):
2052 * undo.c (syms_of_undo):
2053 * w32.c (globals_of_w32):
2054 * window.c (syms_of_window):
2055 * xdisp.c (syms_of_xdisp):
2056 * xfaces.c (syms_of_xfaces):
2057 * xfns.c (syms_of_xfns):
2058 * xmenu.c (syms_of_xmenu):
2059 * xsettings.c (syms_of_xsettings):
2060 * xterm.c (syms_of_xterm): Use DEFSYM.
2062 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2064 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2066 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2068 Integer and buffer overflow fixes (Bug#8873).
2070 * print.c (printchar, strout): Check for string overflow.
2071 (PRINTPREPARE, printchar, strout):
2072 Don't set size unless allocation succeeds.
2074 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2075 for sizes. Check for string overflow more accurately.
2076 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2078 * macros.c: Integer and buffer overflow fixes.
2079 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2080 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2081 Use ptrdiff_t, not int, for sizes.
2082 Don't increment bufsize until after realloc succeeds.
2083 Check for size-calculation overflow.
2084 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2086 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2088 * lread.c: Integer overflow fixes.
2089 (read_integer): Radix is now EMACS_INT, not int,
2090 to improve quality of diagnostics for out-of-range radices.
2091 Calculate buffer size correctly for out-of-range radices.
2092 (read1): Check for integer overflow in radices, and in
2093 read-circle numbers.
2094 (read_escape): Avoid int overflow.
2095 (Fload, openp, read_buffer_size, read1)
2096 (substitute_object_recurse, read_vector, read_list, map_obarray):
2097 Use ptrdiff_t, not int, for sizes.
2098 (read1): Use EMACS_INT, not int, for sizes.
2099 Check for size overflow.
2101 * image.c (cache_image): Check for size arithmetic overflow.
2103 * lread.c: Integer overflow issues.
2104 (saved_doc_string_size, saved_doc_string_length)
2105 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2106 Now ptrdiff_t, not int.
2107 (read1): Don't assume doc string length fits in int. Check for
2108 out-of-range doc string lengths.
2109 (read_list): Don't assume file position fits in int.
2110 (read_escape): Check for hex character overflow.
2112 2011-06-22 Leo Liu <sdl.web@gmail.com>
2114 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2115 Move to minibuffer.el.
2117 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2119 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2120 The following patches are for when GLYPH_DEBUG && !XASSERT.
2121 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2122 * dispnew.c (flush_stdout):
2123 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2124 Mark as externally visible.
2125 * dispnew.c (check_window_matrix_pointers): Now static.
2126 * dispnew.c (window_to_frame_vpos):
2127 * xfns.c (unwind_create_frame):
2128 * xterm.c (x_check_font): Remove unused local.
2129 * scroll.c (CHECK_BOUNDS):
2130 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2131 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2132 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2133 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2134 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2136 (debug_method_add): Use va_list and vsprintf rather than relying
2137 on undefined behavior with wrong number of arguments.
2138 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2139 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2140 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2141 since we're not interested in debugging glyphs with old libraries.
2142 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2143 GCC 4.6.0's static checking.
2145 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2147 Integer overflow and signedness fixes (Bug#8873).
2148 A few related buffer overrun fixes, too.
2150 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2152 * dispextern.h (struct face.stipple):
2153 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2154 (x_bitmap_mask, x_allocate_bitmap_record)
2155 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2156 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2157 (x_create_bitmap_from_xpm_data):
2158 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2159 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2161 * xfaces.c (load_pixmap):
2162 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2163 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2164 (.bitmaps_last, struct x_output.icon_bitmap):
2165 Use ptrdiff_t, not int, for bitmap indexes.
2166 (x_allocate_bitmap_record): Check for size overflow.
2167 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2169 Use ptrdiff_t, not int, for overlay counts.
2170 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2171 * editfns.c (overlays_around, get_pos_property):
2172 * textprop.c (get_char_property_and_overlay):
2173 * xdisp.c (next_overlay_change, note_mouse_highlight):
2174 * xfaces.c (face_at_buffer_position):
2175 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2176 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2177 (Fnext_overlay_change, Fprevious_overlay_change)
2178 (mouse_face_overlay_overlaps, Foverlays_in):
2179 Use ptrdiff_t, not int, for sizes.
2180 (overlays_at, overlays_in): Check for size-calculation overflow.
2182 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2184 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2185 (x_session_initialize): Do not assume string length fits in int.
2187 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2188 This is unlikely, but can occur if DPI is outlandish.
2190 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2191 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2193 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2194 * xrdb.c (magic_file_p, search_magic_path):
2195 Omit last arg SUFFIX; it was always 0. All callers changed.
2196 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2198 * xfont.c (xfont_match): Avoid need for strlen.
2200 * xfns.c: Don't assume strlen fits in int.
2201 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2203 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2204 not unsigned long, as we prefer signed integers. All callers changed.
2205 Detect integer overflow in repeat count.
2206 (message_dolog): Don't assume print length fits in 39 bytes.
2207 (display_mode_element): Don't assume strlen fits in int.
2209 * termcap.c: Don't assume sizes fit in int and never overflow.
2210 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2211 (gobble_line): Check for size-calculation overflow.
2213 * minibuf.c (Fread_buffer):
2214 * lread.c (intern, intern_c_string):
2215 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2216 Don't assume string length fits in int.
2218 * keyboard.c (parse_tool_bar_item):
2219 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2221 * font.c: Don't assume string length fits in int.
2222 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2223 Use ptrdiff_t, not int.
2224 (font_intern_prop): Don't assume string length fits in int.
2225 Don't assume integer property fits in fixnum.
2226 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2228 * filelock.c: Fix some buffer overrun and integer overflow issues.
2229 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2230 Reformulate so as not to need the command string.
2231 Invoke gzip -cd rather than gunzip, as it's more portable.
2232 (lock_info_type, lock_file_1, lock_file):
2233 Don't assume pid_t and time_t fit in unsigned long.
2234 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2235 (current_lock_owner): Prefer signed type for sizes.
2236 Use memcpy, not strncpy, where memcpy is what is really wanted.
2237 Don't assume (via atoi) that time_t and pid_t fit in int.
2238 Check for time_t and/or pid_t out of range, e.g., via a network share.
2239 Don't alloca where an auto var works fine.
2241 * fileio.c: Fix some integer overflow issues.
2242 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2243 Don't assume string length fits in int.
2244 (directory_file_name): Don't assume string length fits in long.
2245 (make_temp_name): Don't assume pid fits in int, or that its print
2246 length is less than 20.
2248 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2250 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2252 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2254 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2255 We prefer signed integers, even for size calculations.
2257 * emacs.c: Don't assume string length fits in 'int'.
2258 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2259 (main): Don't invoke strlen when not needed.
2261 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2262 (XD_DEBUG_MESSAGE): Don't waste a byte.
2264 * callproc.c (getenv_internal_1, getenv_internal)
2266 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2268 * lread.c (invalid_syntax): Omit length argument.
2269 All uses changed. This doesn't fix a bug, but it simplifies the
2270 code away from its former Hollerith-constant appearance, and it's
2271 one less 'int' to worry about when looking at integer-overflow issues.
2272 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2274 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2275 This didn't break anything, but it didn't help either.
2276 It's confusing to put a bogus integer in a place where the actual
2277 value does not matter.
2278 (LIST_END_P): Remove unused macro and its bogus comment.
2279 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2281 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2282 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2284 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2285 We prefer signed types, and the value cannot exceed the EMACS_INT
2286 range anyway (because otherwise the length would not be representable).
2287 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2288 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2289 This avoids a GCC warning when WIDE_EMACS_INT.
2291 * indent.c (sane_tab_width): New function.
2292 (current_column, scan_for_column, Findent_to, position_indentation)
2293 (compute_motion): Use it. This is just for clarity.
2294 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2296 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2298 * lisp.h (lint_assume): New macro.
2299 * composite.c (composition_gstring_put_cache):
2300 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2302 * editfns.c, insdel.c:
2303 Omit unnecessary forward decls, to simplify future changes.
2305 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2307 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2309 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2310 Use much-faster test for byte-length change.
2311 Don't assume string byte-length fits in 'int'.
2312 Check that character arg fits in 'int'.
2313 (mapcar1): Declare byte as byte, for clarity.
2315 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2317 * fns.c (concat): Catch string overflow earlier.
2318 Do not rely on integer wraparound.
2320 * dispextern.h (struct it.overlay_strings_charpos)
2321 (struct it.selective): Now EMACS_INT, not int.
2322 * xdisp.c (forward_to_next_line_start)
2323 (back_to_previous_visible_line_start)
2324 (reseat_at_next_visible_line_start, next_element_from_buffer):
2325 Don't arbitrarily truncate the value of 'selective' to int.
2327 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2329 * composite.c: Don't truncate sizes to 'int'.
2330 (composition_gstring_p, composition_reseat_it)
2331 (composition_adjust_point): Use EMACS_INT, not int.
2332 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2333 not EMACS_UINT, for indexes.
2335 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2337 * buffer.c: Include <verify.h>.
2338 (struct sortvec.priority, struct sortstr.priority):
2339 Now EMACS_INT, not int.
2340 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2341 (struct sortstr.size, record_overlay_string)
2342 (struct sortstrlist.size, struct sortlist.used):
2343 Don't truncate size to int.
2344 (record_overlay_string): Check for size-calculation overflow.
2345 (init_buffer_once): Check at compile-time, not run-time.
2347 2011-06-22 Jim Meyering <meyering@redhat.com>
2349 Don't leak an XBM-image-sized buffer
2350 * image.c (xbm_load): Free the image buffer after using it.
2352 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2355 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2356 that Sun C diagnosed.
2357 * fns.c (secure_hash): Fix pointer signedness issue.
2358 * intervals.c (static_offset_intervals): New function.
2359 (offset_intervals): Use it.
2361 2011-06-21 Leo Liu <sdl.web@gmail.com>
2364 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2367 * fns.c (secure_hash): Rename from crypto_hash_function and change
2368 the first arg to accept symbols.
2369 (Fsecure_hash): New primitive.
2370 (syms_of_fns): New symbols.
2372 2011-06-20 Deniz Dogan <deniz@dogan.se>
2374 * process.c (Fset_process_buffer): Clarify return value in
2377 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2379 * dispnew.c (add_window_display_history): Use BVAR.
2381 * xdisp.c (debug_method_add): Use BVAR.
2382 (check_window_end, dump_glyph_matrix, dump_glyph)
2383 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2385 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2388 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2389 check till after the cache is created in init_frame_faces.
2391 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2393 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2395 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2397 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2398 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2399 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2401 Improve buffer-overflow checking (Bug#8873).
2402 * fileio.c (Finsert_file_contents):
2403 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2404 Remove the old (too-loose) buffer overflow checks.
2405 They weren't needed, since make_gap checks for buffer overflow.
2406 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2407 The old code merely checked for Emacs fixnum overflow, and relied
2408 on undefined (wraparound) behavior. The new code avoids undefined
2409 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2411 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2412 Tune. Don't use wider integers than needed. Don't use alloca.
2413 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2415 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2417 * insdel.c, lisp.h (buffer_overflow): New function.
2418 (insert_from_buffer_1, replace_range, replace_range_2):
2419 * insdel.c (make_gap_larger):
2420 * editfns.c (Finsert_char):
2421 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2423 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2425 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2427 Integer overflow and signedness fixes (Bug#8873).
2429 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2430 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2432 * fileio.c: Don't assume EMACS_INT fits in off_t.
2433 (emacs_lseek): New static function.
2434 (Finsert_file_contents, Fwrite_region): Use it.
2435 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2437 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2439 * fns.c: Don't overflow int when computing a list length.
2440 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2441 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2442 truncation on 64-bit hosts. Check for QUIT every
2443 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2444 faster and is responsive enough.
2445 (Flength): Report an error instead of overflowing an integer.
2446 (Fsafe_length): Return a float if the value is not representable
2447 as a fixnum. This shouldn't happen except in contrived situations.
2448 (Fnthcdr, Fsort): Don't assume list length fits in int.
2449 (Fcopy_sequence): Don't assume vector length fits in int.
2451 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2452 (header_size, word_size): New constants.
2453 (allocate_vectorlike): Don't check size overflow here.
2454 (allocate_vector): Check it here instead, since this is the only
2455 caller of allocate_vectorlike that could cause overflow.
2456 Check that the new vector's length is representable as a fixnum.
2458 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2459 The previous code was bogus. For example, next_almost_prime (32)
2460 returned 39, which is undesirable as it is a multiple of 3; and
2461 next_almost_prime (24) returned 25, which is a multiple of 5 so
2462 why was the code bothering to check for multiples of 7?
2464 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2466 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2468 Variadic C functions now count arguments with ptrdiff_t.
2469 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2470 Back then I didn't know that the Emacs coding style prefers signed int.
2471 Also, in the meantime I found a few more instances where arguments
2472 were being counted with int, which may truncate counts on 64-bit
2473 machines, or EMACS_INT, which may be unnecessarily wide.
2474 * lisp.h (struct Lisp_Subr.function.aMANY)
2475 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2476 Arg counts are now ptrdiff_t, not size_t.
2477 All variadic functions and their callers changed accordingly.
2478 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2479 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2480 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2481 * callint.c (Fcall_interactively): Check arg count for overflow,
2482 to avoid potential buffer overrun. Use signed char, not 'int',
2483 for 'varies' array, so that we needn't bother to check its size
2484 calculation for overflow.
2485 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2486 * eval.c (apply_lambda):
2487 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2488 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2489 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2491 * callint.c (Fcall_interactively): Don't use index var as event count.
2493 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2494 * mem-limits.h (SIZE): Remove; no longer used.
2496 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2498 Remove unnecessary casts.
2499 * xterm.c (x_term_init):
2500 * xfns.c (x_set_border_pixel):
2501 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2502 These aren't needed now that we assume ANSI C.
2504 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2505 It's more likely to cause problems (due to unsigned overflow)
2508 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2510 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2512 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2514 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2516 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2518 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2520 GLYPH_CODE_FACE returns EMACS_INT, not int.
2521 * dispextern.h (merge_faces):
2522 * xfaces.c (merge_faces):
2523 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2524 Don't assume EMACS_INT fits in int.
2526 * character.h (CHAR_VALID_P): Remove unused parameter.
2527 * fontset.c, lisp.h, xdisp.c: All uses changed.
2529 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2531 * fns.c (concat): Minor tuning based on overflow analysis.
2532 This doesn't fix any bugs. Use int to hold character, instead
2533 of constantly refetching from Emacs object. Use XFASTINT, not
2534 XINT, for value known to be a character. Don't bother comparing
2535 a single byte to 0400, as it's always less.
2537 * floatfns.c (Fexpt):
2538 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2540 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2543 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2545 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2546 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2547 incorrectly succeed when S was a string, because 4294967386 was
2548 truncated before it was used.
2550 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2551 Otherwise, an out-of-range integer could cause undefined behavior
2554 * composite.c: Use int, not EMACS_INT, for characters.
2555 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2556 EMACS_INT, for values that are known to be in character range.
2557 This doesn't fix any bugs but is the usual style inside Emacs and
2558 may generate better code on 32-bit machines.
2560 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2561 This is for reasons similar to the recent CHAR_STRING fix.
2562 * charset.c (Fencode_char): Check that character arg is actually
2563 a character. Pass an int to ENCODE_CHAR.
2564 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2565 wider than 'int', as a compile-time check to prevent future regressions
2568 * character.c (char_string): Remove unnecessary casts.
2570 Make sure a 64-bit char is never passed to CHAR_STRING.
2571 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2572 by silently ignoring the top 32 bits, allowing some values
2573 that were far too large to be valid characters.
2574 * character.h: Include <verify.h>.
2575 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2576 arguments are no wider than unsigned, as a compile-time check
2577 to prevent future regressions in this area.
2579 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2580 (Fsubst_char_in_region):
2582 * xdisp.c (decode_mode_spec_coding):
2583 Adjust to CHAR_STRING's new requirement.
2584 * editfns.c (Finsert_char, Fsubst_char_in_region):
2585 * fns.c (concat): Check that character args are actually
2586 characters. Without this test, these functions did the wrong
2587 thing with wildly out-of-range values on 64-bit hosts.
2589 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2590 These casts should not be needed on 32-bit hosts, either.
2591 * keyboard.c (read_char):
2592 * lread.c (Fload): Remove casts to unsigned.
2594 * lisp.h (UNSIGNED_CMP): New macro.
2595 This fixes comparison bugs on 64-bit hosts.
2596 (ASCII_CHAR_P): Use it.
2597 * casefiddle.c (casify_object):
2598 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2599 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2600 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2601 * dispextern.h (FACE_FROM_ID):
2602 * keyboard.c (read_char): Use UNSIGNED_CMP.
2604 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2605 not to EMACS_INT, to avoid GCC warning.
2607 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2609 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2610 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2611 isn't needed on 32-bit machines.
2613 * buffer.c (Fgenerate_new_buffer_name):
2614 Use EMACS_INT for count, not int.
2615 (advance_to_char_boundary): Return EMACS_INT, not int.
2617 * data.c (Qcompiled_function): Now static.
2619 * window.c (window_body_lines): Now static.
2621 * image.c (gif_load): Rename local to avoid shadowing.
2623 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2624 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2625 * alloc.c (make_save_value): Integer argument is now of type
2627 (mark_object): Use ptrdiff_t, not int.
2628 * lisp.h (pD): New macro.
2629 * print.c (print_object): Use it.
2631 * alloc.c: Use EMACS_INT, not int, to count objects.
2632 (total_conses, total_markers, total_symbols, total_vector_size)
2633 (total_free_conses, total_free_markers, total_free_symbols)
2634 (total_free_floats, total_floats, total_free_intervals)
2635 (total_intervals, total_strings, total_free_strings):
2636 Now EMACS_INT, not int. All uses changed.
2637 (Fgarbage_collect): Compute overall total using a double, so that
2638 integer overflow is less likely to be a problem. Check for overflow
2639 when converting back to an integer.
2640 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2641 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2642 These were 'int' variables that could overflow on 64-bit hosts;
2643 they were never used, so remove them instead of repairing them.
2644 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2645 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2646 Previously, this ceilinged at INT_MAX, but that doesn't work on
2648 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2650 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2651 (allocate_vectorlike): Check for ptrdiff_t overflow.
2652 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2653 when a (possibly-narrower) signed value would do just as well.
2654 We prefer using signed arithmetic, to avoid comparison confusion.
2656 * alloc.c: Catch some string size overflows that we were missing.
2657 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2658 for convenience in STRING_BYTES_MAX.
2659 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2660 The definition here is exact; the one in lisp.h was approximate.
2661 (allocate_string_data): Check for string overflow. This catches
2662 some instances we weren't catching before. Also, it catches
2663 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2664 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2665 and ptrdiff_t and EMACS_INT are both 64 bits.
2667 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2668 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2669 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2671 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2673 * alloc.c (Fmake_string): Check for out-of-range init.
2675 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2677 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2679 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2681 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2682 xg_get_default_scrollbar_width.
2684 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2685 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2686 (style_changed_cb): Call update_theme_scrollbar_width and call
2687 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2688 all frames (Bug#8505).
2689 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2690 Call gtk_window_set_resizable if HAVE_GTK3.
2691 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2692 and height if HAVE_GTK3 (Bug#8505).
2693 (scroll_bar_width_for_theme): New variable.
2694 (update_theme_scrollbar_width): New function.
2695 (xg_get_default_scrollbar_width): Move code to
2696 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2697 (xg_initialize): Call update_theme_scrollbar_width.
2699 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2701 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2703 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2705 * frame.c (make_frame): Call other_buffer_safely instead of
2708 * window.c (temp_output_buffer_show): Call display_buffer with
2709 second argument Vtemp_buffer_show_specifiers and reset latter
2710 immediately after the call.
2711 (Vtemp_buffer_show_specifiers): New variable.
2712 (auto_window_vscroll_p, next_screen_context_lines)
2713 (Vscroll_preserve_screen_position): Remove leading asterisks from
2716 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2718 Fix minor problems found by GCC 4.6.0 static checking.
2719 * buffer.c (Qclone_number): Remove for now, as it's unused.
2720 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2721 (record_buffer): Remove unused local.
2722 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2723 (set_frame_buffer_list): Remove; unused.
2724 * frame.h (other_visible_frames): Remove decl.
2725 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2726 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2727 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2729 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2730 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2731 Define only if HAVE_GPM.
2732 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2733 (update_hints_inhibit): Remove; never set. All uses removed.
2734 * widgetprv.h (emacsFrameClassRec): Remove decl.
2735 * window.c (delete_deletable_window): Now returns void, since it
2736 wasn't returning anything.
2737 (compare_window_configurations): Remove unused locals.
2738 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2739 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2740 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2741 the same widths as pointers. This follows up on the 2011-05-06 patch.
2742 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2743 * xterm.h: Likewise.
2744 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2746 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2748 * makefile.w32-in: Update dependencies.
2749 (LISP_H): Add lib/intprops.h.
2751 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2753 * image.c (gif_load): Add animation frame delay to the metadata.
2754 (syms_of_image): Use DEFSYM. New symbol `delay'.
2756 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2758 * window.c (delete_deletable_window): Re-add.
2759 (Fset_window_configuration): Rewrite to handle dead buffers and
2760 consequently deletable windows.
2761 (window_tree, Fwindow_tree): Remove. Supply functionality in
2763 (compare_window_configurations): Simplify code.
2765 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2767 * image.c (imagemagick_load_image): Fix type mismatch.
2768 (Fimagemagick_types): Likewise.
2770 * window.h (replace_buffer_in_windows): Declare.
2772 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2774 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2775 Qclone_number. Remove external declaration of Qdelete_window.
2776 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2778 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2779 Run Qbuffer_list_update_hook if allowed.
2780 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2781 buffer list implementation.
2782 (other_buffer_safely): New function.
2783 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2784 calls to replace_buffer_in_windows and
2785 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2787 (record_buffer): Inhibit quitting and rewrite using quittable
2788 functions. Run Qbuffer_list_update_hook if allowed.
2789 (Frecord_buffer, Funrecord_buffer): New functions.
2790 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2791 Move switch-to-buffer to window.el.
2792 (bury-buffer): Move to window.el.
2793 (Vbuffer_list_update_hook): New variable.
2795 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2798 * window.h (resize_frame_windows): Move up in code.
2799 (Fwindow_frame): Remove EXFUN.
2800 (replace_buffer_in_all_windows): Remove prototype.
2801 (replace_buffer_in_windows_safely): Add prototype.
2803 * window.c: Declare Qdelete_window static again. Move down
2804 declaration of select_count.
2805 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2806 (Fother_window): Move to window.el.
2807 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2808 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2809 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2811 (replace_buffer_in_windows): Implement by calling
2812 Qreplace_buffer_in_windows.
2813 (replace_buffer_in_all_windows): Remove with some functionality
2814 moved into replace_buffer_in_windows_safely.
2815 (replace_buffer_in_windows_safely): New function.
2816 (select_window_norecord, select_frame_norecord): Move in front
2817 of run_window_configuration_change_hook. Remove now obsolete
2819 (Fset_window_buffer): Rewrite doc-string.
2820 Call Qrecord_window_buffer.
2821 (keys_of_window): Move binding for other-window to window.el.
2823 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2825 * dispextern.h (struct image): Replace data member, whose int_val
2826 and ptr_val fields were not used by anything, with a single
2829 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2830 (gif_clear_image, gif_load, imagemagick_load_image)
2831 (gs_clear_image, gs_load): Callers changed.
2833 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2835 * buffer.h: Include <time.h>, for time_t.
2836 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2838 Fix minor problems found by static checking.
2840 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2842 Make identifiers static if they are not used in other modules.
2843 * data.c (Qcompiled_function, Qframe, Qvector):
2844 * image.c (QimageMagick, Qsvg):
2845 * minibuf.c (Qmetadata):
2846 * window.c (resize_window_check, resize_root_window): Now static.
2847 * window.h (resize_window_check, resize_root_window): Remove decls.
2849 * window.c (window_deletion_count, delete_deletable_window):
2851 (window_body_lines): Now static.
2852 (Fdelete_other_windows_internal): Mark vars as initialized.
2853 Make sure 'resize_failed' is initialized.
2854 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2855 (resize_window_apply): Remove unused local.
2856 * window.h (delete_deletable_window): Remove decl.
2858 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2859 (imagemagick_load_image): Fix pointer signedness problem by changing
2860 last arg from unsigned char * to char *. All uses changed.
2861 Also, fix a local for similar reasons.
2862 Remove unused locals. Remove locals to avoid shadowing.
2863 (fn_rsvg_handle_free): Remove; unused.
2864 (svg_load, svg_load_image): Fix pointer signedness problem.
2865 (imagemagick_load_image): Don't use garbage pointer image_wand.
2867 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2869 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2871 * image.c (gif_load): Fix omitted cast error introduced by
2874 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2876 * window.h (resize_proportionally, orig_total_lines)
2877 (orig_top_line): Remove from window structure.
2878 (set_window_height, set_window_width, change_window_heights)
2879 (Fdelete_window): Remove prototypes.
2880 (resize_frame_windows): Remove duplicate declaration.
2882 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2884 * window.h (resize_frame_windows, resize_window_check)
2885 (delete_deletable_window, resize_root_window)
2886 (resize_frame_windows): Declare prototypes.
2888 * window.c (resize_window_apply): Make definition be "static" to
2889 match the prototype.
2891 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2893 * window.c: Remove declarations of Qwindow_size_fixed,
2894 window_min_size_1, window_min_size_2, window_min_size,
2895 size_window, window_fixed_size_p, enlarge_window, delete_window.
2896 Remove static from declaration of Qdelete_window, it's
2897 temporarily needed by Fbury_buffer.
2898 (replace_window): Don't assign orig_top_line and
2900 (Fdelete_window, delete_window): Remove. Window deletion is
2901 handled by window.el.
2902 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2903 Replace Fdelete_window calls with calls to Qdelete_window.
2904 (Fdelete_other_windows): Remove. Deleting other windows is
2905 handled by window.el.
2906 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2907 handled in window.el.
2908 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2909 Window minimum sizes are handled in window.el.
2910 (shrink_windows, size_window, set_window_height)
2911 (set_window_width, change_window_heights, window_height)
2912 (window_width, CURBEG, CURSIZE, enlarge_window)
2913 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2914 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2915 handled in window.el.
2916 (make_dummy_parent): Rename to make_parent_window and give it a
2917 second argument horflag.
2918 (make_window): Don't set resize_proportionally any more.
2919 (Fsplit_window): Remove. Windows are split in window.el.
2920 (save_restore_action, save_restore_orig_size)
2921 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2922 Resize mini windows in window.el.
2923 (grow_mini_window, shrink_mini_window): Implement by calling
2924 Qresize_root_window_vertically, resize_window_check and
2925 resize_window_apply.
2926 (saved_window, Fset_window_configuration, save_window_save):
2927 Do not handle orig_top_line, orig_total_lines, and
2928 resize_proportionally.
2929 (window_min_height, window_min_width): Move to window.el.
2930 (keys_of_window): Move bindings for delete-other-windows,
2931 split-window, delete-window and enlarge-window to window.el.
2933 * buffer.c: Temporarily extern Qdelete_window.
2934 (Fbury_buffer): Temporarily call Qdelete_window instead of
2935 Fdelete_window (Fbury_buffer will move to window.el soon).
2937 * frame.c (set_menu_bar_lines_1): Remove code handling
2938 orig_top_line and orig_total_lines.
2940 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2941 set_window_height but set heights directly.
2942 (change_frame_size_1): Use resize_frame_windows.
2944 * xdisp.c (init_xdisp): Don't use set_window_height but set
2947 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2948 Use resize_frame_windows instead of change_window_heights and run
2949 run_window_configuration_change_hook.
2951 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2952 instead of change_window_heights and run
2953 run_window_configuration_change_hook.
2955 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2957 * window.c (replace_window): Rename second argument REPLACEMENT to
2958 NEW. New third argument SETFLAG. Rewrite.
2959 (delete_window, make_dummy_parent): Call replace_window with
2961 (window_list_1): Move down in code.
2962 (run_window_configuration_change_hook): Move set_buffer part
2963 before select_frame_norecord part in order to unwind correctly.
2964 Rename count1 to count.
2965 (recombine_windows, delete_deletable_window, resize_root_window)
2966 (Fdelete_other_windows_internal)
2967 (Frun_window_configuration_change_hook, make_parent_window)
2968 (resize_window_check, resize_window_apply, Fresize_window_apply)
2969 (resize_frame_windows, Fsplit_window_internal)
2970 (Fdelete_window_internal, Fresize_mini_window_internal):
2972 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2974 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2976 * window.h (window): Add some new members to window structure -
2977 normal_lines, normal_cols, new_total, new_normal, clone_number,
2978 splits, nest, prev_buffers, next_buffers.
2979 (WINDOW_TOTAL_SIZE): Move here from window.c.
2980 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2982 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2984 (make_dummy_parent): Set new members of windows structure.
2985 (make_window): Move down in code. Handle new members of window
2987 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2988 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2989 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2990 (Fset_window_prev_buffers, Fwindow_next_buffers)
2991 (Fset_window_next_buffers, Fset_window_clone_number):
2993 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2994 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2996 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2997 Argument WINDOW can be now internal window too.
2998 (Fwindow_use_time): Move up in code.
2999 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3001 (Fset_window_configuration, saved_window)
3002 (Fcurrent_window_configuration, save_window_save): Handle new
3003 members of window structure.
3004 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3005 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3006 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3007 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3008 Qget_mru_window, Qresize_root_window,
3009 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3010 Qauto_buffer_name; staticpro them.
3012 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3014 * window.c (Fwindow_total_size, Fwindow_left_column)
3015 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3016 (Fwindow_list_1): New functions.
3017 (window_box_text_cols): Replace with window_body_cols.
3018 (Fwindow_width, Fscroll_left, Fscroll_right):
3019 Use window_body_cols instead of window_box_text_cols.
3020 (delete_window, Fset_window_configuration):
3021 Call delete_all_subwindows with window as argument.
3022 (delete_all_subwindows): Take a window as argument and not a
3024 (window_loop): Remove handling of GET_LRU_WINDOW and
3026 (Fget_lru_window, Fget_largest_window): Move to window.el.
3028 * window.h: Extern window_body_cols instead of
3029 window_box_text_cols. delete_all_subwindows now takes a
3030 Lisp_Object as argument.
3032 * indent.c (compute_motion, Fcompute_motion):
3033 Use window_body_cols instead of window_box_text_cols.
3035 * frame.c (delete_frame): Call delete_all_subwindows with root
3038 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3040 * fns.c (Fputhash): Document return value.
3042 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3044 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3046 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3048 Cons<->int and similar integer overflow fixes (Bug#8794).
3050 Check for overflow when converting integer to cons and back.
3051 * charset.c (Fdefine_charset_internal, Fdecode_char):
3052 Use cons_to_unsigned to catch overflow.
3053 (Fencode_char): Use INTEGER_TO_CONS.
3054 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3055 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3056 * data.c (long_to_cons, cons_to_long): Remove.
3057 (cons_to_unsigned, cons_to_signed): New functions.
3058 These signal an error for invalid or out-of-range values.
3059 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3060 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3061 * font.c (Ffont_variation_glyphs):
3062 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3063 * lisp.h: Include <intprops.h>.
3064 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3065 (cons_to_signed, cons_to_unsigned): New decls.
3066 (long_to_cons, cons_to_long): Remove decls.
3067 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3068 (Fprimitive_undo): Use CONS_TO_INTEGER.
3069 * xfns.c (Fx_window_property): Likewise.
3070 * xselect.c: Include <limits.h>.
3071 (x_own_selection, selection_data_to_lisp_data):
3072 Use INTEGER_TO_CONS.
3073 (x_handle_selection_request, x_handle_selection_clear)
3074 (x_get_foreign_selection, Fx_disown_selection_internal)
3075 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3076 (lisp_data_to_selection_data): Use cons_to_unsigned.
3077 (x_fill_property_data): Use cons_to_signed.
3078 Report values out of range.
3080 Check for buffer and string overflow more precisely.
3081 * buffer.h (BUF_BYTES_MAX): New macro.
3082 * lisp.h (STRING_BYTES_MAX): New macro.
3083 * alloc.c (Fmake_string):
3084 * character.c (string_escape_byte8):
3085 * coding.c (coding_alloc_by_realloc):
3086 * doprnt.c (doprnt):
3087 * editfns.c (Fformat):
3089 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3090 since they may not be the same number.
3091 * editfns.c (Finsert_char):
3092 * fileio.c (Finsert_file_contents):
3093 Likewise for BUF_BYTES_MAX.
3095 * image.c: Use ptrdiff_t, not int, for sizes.
3096 (slurp_file): Switch from int to ptrdiff_t.
3098 (slurp_file): Check that file size fits in both size_t (for
3099 malloc) and ptrdiff_t (for sanity and safety).
3101 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3102 if b->modtime has its maximal value.
3104 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3106 Don't assume time_t can fit into int.
3107 * buffer.h (struct buffer.modtime): Now time_t, not int.
3108 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3109 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3111 Minor fixes for signed vs unsigned integers.
3112 * character.h (MAYBE_UNIFY_CHAR):
3113 * charset.c (maybe_unify_char):
3114 * keyboard.c (read_char, reorder_modifiers):
3115 XINT -> XFASTINT, since the integer must be nonnegative.
3116 * ftfont.c (ftfont_spec_pattern):
3117 * keymap.c (access_keymap, silly_event_symbol_error):
3118 XUINT -> XFASTINT, since the integer must be nonnegative.
3119 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3120 since it makes no difference and we prefer signed.
3121 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3122 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3125 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3127 * window.h (Fwindow_frame): Declare.
3129 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3131 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3132 (SPARE_MEMORY): Always define.
3133 (LARGE_REQUEST): Remove.
3134 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3136 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3138 * lisp.h: Move EXFUNS for Fframe_root_window,
3139 Fframe_first_window and Fset_frame_selected_window to window.h.
3141 * window.h: Move EXFUNS for Fframe_root_window,
3142 Fframe_first_window and Fset_frame_selected_window here from
3145 * frame.c (Fwindow_frame, Fframe_first_window)
3146 (Fframe_root_window, Fframe_selected_window)
3147 (Fset_frame_selected_window): Move to window.c.
3148 (Factive_minibuffer_window): Move to minibuf.c.
3149 (Fother_visible_frames_p): New function.
3151 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3153 * window.c (decode_window, decode_any_window): Move up in code.
3154 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3155 (inhibit_frame_unsplittable): Remove unused variable.
3156 (Fwindow_buffer): Move up and rewrite doc-string.
3157 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3158 (Fwindow_prev): New functions.
3159 (Fwindow_frame): Move here from frame.c. Accept any window as
3161 (Fframe_root_window, Fframe_first_window)
3162 (Fframe_selected_window): Move here from frame.c. Accept frame
3163 or arbitrary window as argument. Update doc-strings.
3164 (Fminibuffer_window): Move up in code.
3165 (Fwindow_minibuffer_p): Move up in code and simplify.
3166 (Fset_frame_selected_window): Move here from frame.c.
3168 (Fselected_window, select_window, Fselect_window): Move up in
3169 code. Minor doc-string fixes.
3171 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3173 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3174 Do not assume that spare memory exists; that assumption is valid
3175 only if SYSTEM_MALLOC.
3176 (LARGE_REQUEST): New macro, so that the issue of large requests
3177 is separated from the issue of spare memory.
3179 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3181 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3184 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3186 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3189 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3191 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3193 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3195 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3196 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3198 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3200 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3202 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3204 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3205 (x_clipboard_manager_save): Add return value.
3206 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3208 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3209 Obey Vx_select_enable_clipboard_manager. Catch errors in
3210 x_clipboard_manager_save (Bug#8779).
3211 (Vx_select_enable_clipboard_manager): New variable.
3212 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3214 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3216 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3218 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3220 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3221 in the current matrix if keep_current_p is non-zero.
3223 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3225 * bidi.c (bidi_level_of_next_char): Fix last change.
3227 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3229 Support bidi reordering of text covered by display properties.
3231 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3232 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3233 (bidi_cache_search, bidi_cache_iterator_state)
3234 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3235 (bidi_level_of_next_char, bidi_move_to_visually_next):
3236 Support character positions inside a run of characters covered by a
3238 (bidi_paragraph_init, bidi_resolve_explicit_1)
3239 (bidi_level_of_next_char): Call bidi_fetch_char and
3240 bidi_fetch_char_advance instead of FETCH_CHAR and
3242 (bidi_init_it): Initialize new members.
3243 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3245 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3246 instead of using explicit *_CHAR codes.
3247 (bidi_resolve_explicit, bidi_resolve_weak):
3248 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3249 bidirectional text is supported only in multibyte buffers.
3250 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3251 it to initialize the frame_window_p member of struct bidi_it.
3252 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3253 (bidi_resolve_explicit, bidi_resolve_weak)
3254 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3255 bidi_it->nchars is non-positive.
3256 (bidi_level_of_next_char): Don't try to lookup the cache for the
3257 next/previous character if nothing is cached there yet, or if we
3258 were just reseat()'ed to a new position.
3260 * xdisp.c (set_cursor_from_row): Set start and stop points
3261 according to the row's direction when priming the loop that looks
3262 for the glyph on which to display cursor.
3263 (single_display_spec_intangible_p): Function deleted.
3264 (display_prop_intangible_p): Reimplement to call
3265 handle_display_spec instead of single_display_spec_intangible_p.
3266 Accept 3 additional arguments needed by handle_display_spec.
3267 This fixes incorrect cursor motion across display property with complex
3268 values: lists, `(when COND...)' forms, etc.
3269 (single_display_spec_string_p): Support property values that are
3270 lists with the argument STRING its top-level element.
3271 (display_prop_string_p): Fix the condition for processing a
3272 property that is a list to be consistent with handle_display_spec.
3273 (handle_display_spec): New function, refactored from the
3274 last portion of handle_display_prop.
3275 (compute_display_string_pos): Accept additional argument
3276 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3277 value of a `display' property is a "replacing spec".
3278 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3279 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3280 the display property, but just return a value indicating whether
3281 the display property will replace the characters it covers.
3282 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3283 frame_window_p members of struct bidi_it.
3284 (compute_display_string_pos, compute_display_string_end):
3286 (push_it): Accept second argument POSITION, where pop_it should
3287 jump to continue iteration.
3288 (reseat_1): Initialize bidi_it.disp_pos.
3290 * keyboard.c (adjust_point_for_property): Adjust the call to
3291 display_prop_intangible_p to its new signature.
3293 * dispextern.h (struct bidi_it): New member frame_window_p.
3294 (bidi_init_it): Update prototypes.
3295 (display_prop_intangible_p): Update prototype.
3296 (compute_display_string_pos, compute_display_string_end):
3298 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3301 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3303 Malloc failure behavior now depends on size of allocation.
3304 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3305 * lisp.h: Change signatures accordingly.
3306 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3307 All callers changed. (Bug#8762)
3309 * gnutls.c: Use Emacs's memory allocators.
3310 Without this change, the gnutls library would invoke malloc etc.
3311 directly, which causes problems on non-SYNC_INPUT hosts, and which
3312 runs afoul of improving memory_full behavior. (Bug#8761)
3313 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3314 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3315 xfree instead of the default malloc, realloc, free.
3316 (Fgnutls_boot): No need to check for memory allocation failure,
3317 since xmalloc does that for us.
3319 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3320 * category.c (hash_get_category_set):
3321 * ccl.c (ccl_driver):
3322 * charset.c (Fdefine_charset_internal):
3323 * charset.h (struct charset.hash_index):
3324 * composite.c (get_composition_id, gstring_lookup_cache)
3325 (composition_gstring_put_cache):
3326 * composite.h (struct composition.hash_index):
3327 * dispextern.h (struct image.hash):
3328 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3329 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3330 (hashfn_equal, hashfn_user_defined, make_hash_table)
3331 (maybe_resize_hash_table, hash_lookup, hash_put)
3332 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3333 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3334 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3335 * image.c (make_image, search_image_cache, lookup_image)
3336 (xpm_put_color_table_h):
3337 * lisp.h (struct Lisp_Hash_Table):
3338 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3339 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3340 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3341 * alloc.c (allocate_vectorlike):
3342 Check for overflow in vector size calculations.
3343 * ccl.c (ccl_driver):
3344 Check for overflow when converting EMACS_INT to int.
3345 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3346 need to be updated by these changes.
3347 * fns.c (make_hash_table, maybe_resize_hash_table):
3348 Check for integer overflow with large hash tables.
3349 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3350 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3351 (SXHASH_REDUCE): New macro.
3352 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3353 Use it instead of discarding useful hash info with large hash values.
3354 (sxhash_float): New function.
3355 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3356 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3357 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3358 Rewrite to use FIXNUM_BITS, as this simplifies things.
3359 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3360 Adjust signatures to match updated version of code.
3361 (consing_since_gc): Now EMACS_INT, since a single hash table can
3362 use more than INT_MAX bytes.
3364 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3366 Make it possible to build with GCC-4.6+ -O2 -flto.
3368 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3370 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3372 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3373 Call minibuffer-inactive-mode.
3375 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3377 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3378 Update dependencies.
3380 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3382 * data.c (init_data): Remove code for UTS, this system is not
3385 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3387 Don't force ./temacs to start in terminal mode.
3389 * frame.c (make_initial_frame): Initialize faces in all cases, not
3390 only when CANNOT_DUMP is defined.
3391 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3393 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3395 * dispnew.c (add_window_display_history): Use const for the string
3396 pointer. Remove declaration, not needed.
3398 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3400 Use 'inline', not 'INLINE'.
3401 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3402 * alloc.c, fontset.c (INLINE): Remove.
3403 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3404 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3405 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3406 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3407 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3409 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3411 Make it possible to run ./temacs.
3413 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3414 syms_of_callproc does the same thing. Remove test for
3415 "initialized", do it in the caller.
3416 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3418 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3420 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3421 (read_minibuf): Use get_minibuffer.
3422 (syms_of_minibuf): Use DEFSYM.
3423 (Qmetadata): New var.
3424 * data.c (Qbuffer): Don't make it static.
3425 (syms_of_data): Use DEFSYM.
3427 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3429 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3430 (CCL_CODE_MIN): New macro.
3432 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3434 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3436 * eval.c (Qdebug): Now static.
3437 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3438 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3439 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3441 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3443 * image.c: Various fixes to ImageMagick code comments.
3444 (Fimagemagick_types): Doc fix.
3446 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3448 Minor fixes prompted by GCC 4.6.0 warnings.
3450 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3452 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3453 (x_clipboard_manager_save_all): Move extern decl to ...
3454 * xterm.h: ... here, so that it can be checked for consistency.
3456 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3458 * xselect.c (x_clipboard_manager_save_frame)
3459 (x_clipboard_manager_save_all): New functions.
3460 (Fx_clipboard_manager_save): Lisp function deleted.
3462 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3463 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3465 * xterm.h: Update prototype.
3467 2011-05-28 William Xu <william.xwl@gmail.com>
3469 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3472 2011-05-28 Jim Meyering <meyering@redhat.com>
3474 Avoid a sign-extension bug in crypto_hash_function.
3475 * fns.c (to_uchar): Define.
3476 (crypto_hash_function): Use it to convert some newly-signed
3477 variables to unsigned, to avoid sign-extension bugs. For example,
3478 without this change, (md5 "truc") would evaluate to
3479 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3480 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3481 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3483 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3485 Integer overflow fixes.
3487 * dbusbind.c: Serial number integer overflow fixes.
3488 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3489 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3490 to hold a serial number that is too large for a fixnum.
3491 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3492 Check for serial numbers out of range. Decode any serial number
3493 that was so large that it became a float. (Bug#8722)
3495 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3496 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3497 Use XFASTINT rather than XUINT when numbers are nonnegative.
3498 (xd_append_arg, Fdbus_method_return_internal):
3499 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3500 arguments, check that Lisp number is nonnegative, rather than
3501 silently wrapping negative numbers around. (Bug#8722)
3502 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3505 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3507 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3509 ccl: add integer overflow checks
3510 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3511 (IN_INT_RANGE): New macros.
3512 (ccl_driver): Use them to check for integer overflow when
3513 decoding a CCL program. Many of the new checks are whether XINT (x)
3514 fits in int; it doesn't always, on 64-bit hosts. The new version
3515 doesn't catch all possible integer overflows, but it's an
3516 improvement. (Bug#8719)
3518 * alloc.c (make_event_array): Use XINT, not XUINT.
3519 There's no need for unsigned here.
3521 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3522 This follows up to the 2011-05-06 change that substituted uintptr_t
3523 for EMACS_INT. This case wasn't caught back then.
3525 Rework Fformat to avoid integer overflow issues.
3526 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3527 now (part of C89). Include <verify.h>.
3528 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3529 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3530 (Fformat): Avoid the prepass trying to compute sizes; it was only
3531 approximate and thus did not catch overflow reliably. Instead, walk
3532 through the format just once, formatting and computing sizes as we go,
3533 checking for integer overflow at every step, and allocating a larger
3534 buffer as needed. Keep track separately whether the format is
3535 multibyte. Keep only the most-recently calculated precision, rather
3536 than them all. Record whether each argument has been converted to
3537 string. Use EMACS_INT, not int, for byte and char and arg counts.
3538 Support field widths and precisions larger than INT_MAX. Avoid
3539 sprintf's undefined behavior with conversion specifications such as %#d
3540 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3541 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3542 formatting out-of-range floating point numbers with int
3545 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3547 * data.c: Avoid integer truncation in expressions involving floats.
3548 * data.c: Include <intprops.h>.
3549 (arith_driver): When there's an integer overflow in an expression
3550 involving floating point, convert the integers to floating point
3551 so that the resulting value does not suffer from catastrophic
3552 integer truncation. For example, on a 64-bit host (* 4
3553 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3554 Do not rely on undefined behavior after integer overflow.
3556 merge count_size_as_multibyte, parse_str_to_multibyte
3557 * character.c, character.h (count_size_as_multibyte):
3558 Rename from parse_str_to_multibyte; all uses changed.
3559 Check for integer overflow.
3560 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3561 since it's now a duplicate of the other. This is more of
3562 a character than a buffer op, so better that it's in character.c.
3563 * fns.c, print.c: Adjust to above changes.
3565 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3567 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3569 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3571 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3572 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3573 (x_clipboard_manager_save): Now static.
3574 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3576 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3577 (crypto_hash_function): Now static.
3578 Fix pointer signedness problems. Avoid unnecessary initializations.
3580 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3582 * termhooks.h (Vselection_alist): Make it terminal-local.
3584 * terminal.c (create_terminal): Initialize it.
3586 * xselect.c: Support for clipboard managers.
3587 (Vselection_alist): Move to termhooks.h as terminal-local var.
3588 (LOCAL_SELECTION): New macro.
3589 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3590 (symbol_to_x_atom): Remove gratuitous arg.
3591 (x_handle_selection_request, lisp_data_to_selection_data)
3592 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3593 (x_own_selection, x_get_local_selection, x_convert_selection):
3594 New arg, specifying work frame. Use terminal-local Vselection_alist.
3595 (some_frame_on_display): Delete unused function.
3596 (Fx_own_selection_internal, Fx_get_selection_internal)
3597 (Fx_disown_selection_internal, Fx_selection_owner_p)
3598 (Fx_selection_exists_p): New optional frame arg.
3599 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3600 (x_handle_selection_clear): Don't treat other terminals with the
3601 same keyboard specially. Use the terminal-local Vselection_alist.
3602 (x_clear_frame_selections): Use Frun_hook_with_args.
3604 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3606 * xterm.h: Add support for those atoms.
3608 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3610 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3611 (converted_selections, conversion_fail_tag): New global variables.
3612 (x_selection_request_lisp_error): Free the above.
3613 (x_get_local_selection): Remove unnecessary code.
3614 (x_reply_selection_request): Args changed; handle arbitrary array
3615 of converted selections stored in converted_selections.
3616 Separate the XChangeProperty and SelectionNotify steps.
3617 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3618 (x_convert_selection): New function.
3619 (x_handle_selection_event): Simplify.
3620 (x_get_foreign_selection): Don't ignore incoming requests while
3621 waiting for an answer; this will fail when we implement
3622 SAVE_TARGETS, and seems unnecessary anyway.
3623 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3624 (Vx_sent_selection_functions): Doc fix.
3626 2011-05-26 Leo Liu <sdl.web@gmail.com>
3628 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3630 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3632 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3634 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3635 for fringe update if it has periodic bitmap.
3636 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3637 and fringe_bitmap_periodic_p.
3639 * fringe.c (get_fringe_bitmap_data): New function.
3640 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3641 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3642 row. Mark glyph row for fringe update if periodicity changed.
3644 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3645 for fringe update unless it has periodic bitmap.
3647 2011-05-25 Kenichi Handa <handa@m17n.org>
3649 * xdisp.c (get_next_display_element): Set correct it->face_id for
3650 a static composition.
3652 2011-05-24 Leo Liu <sdl.web@gmail.com>
3655 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3657 * fns.c (crypto_hash_function, Fsha1): New function.
3658 (Fmd5): Use crypto_hash_function.
3659 (syms_of_fns): Add Ssha1.
3661 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3663 * gnutls.c: Remove unused macros.
3664 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3665 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3666 Remove macros that are defined and never used.
3667 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3669 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3671 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3672 (Fx_get_selection_internal): Minor cleanup.
3673 (Fx_own_selection_internal): Rename arguments for consistency with
3676 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3678 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3680 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3682 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3684 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3686 * dispnew.c (scrolling_window): Don't exclude the case that the
3687 last enabled row in the desired matrix touches the bottom boundary.
3689 2011-05-21 Glenn Morris <rgm@gnu.org>
3691 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3692 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3693 and add some more files.
3695 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3697 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3698 report_file_error introduced by the change from 2011-05-07.
3700 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3702 * systime.h (Time): Define only if emacs is defined.
3703 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3704 where the include path doesn't have X11/X.h by default. See
3705 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3707 2011-05-20 Kenichi Handa <handa@m17n.org>
3709 * composite.c (find_automatic_composition): Fix previous change.
3711 2011-05-20 Glenn Morris <rgm@gnu.org>
3713 * lisp.mk: New file, split from Makefile.in.
3714 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3715 (shortlisp): Remove.
3716 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3718 2011-05-19 Glenn Morris <rgm@gnu.org>
3720 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3721 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3722 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3723 (lisp): Set the order to that of loadup.el.
3724 (shortlisp): Make it a copy of $lisp.
3725 (SOME_MACHINE_LISP): Remove.
3726 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3727 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3729 2011-05-18 Kenichi Handa <handa@m17n.org>
3731 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3732 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3733 (find_automatic_composition): Mostly rewrite for efficiency.
3735 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3737 * makefile.w32-in: Update dependencies.
3739 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3741 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3742 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3744 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3746 Fix some integer overflow issues, such as string length overflow.
3748 * insdel.c (count_size_as_multibyte): Check for string overflow.
3750 * character.c (lisp_string_width): Check for string overflow.
3751 Use EMACS_INT, not int, for string indexes and lengths; in
3752 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3753 the resulting string length overflows an EMACS_INT; instead,
3754 report a string overflow if no precision given. When checking for
3755 precision exhaustion, use a check that cannot possibly have
3756 integer overflow. (Bug#8675)
3757 * character.h (lisp_string_width): Adjust to new signature.
3759 * alloc.c (string_overflow): New function.
3760 (Fmake_string): Use it. This doesn't change behavior, but saves
3761 a few bytes and will simplify future changes.
3762 * character.c (string_escape_byte8): Likewise.
3763 * lisp.h (string_overflow): New decl.
3765 Fixups, following up to the user-interface timestamp change.
3766 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3767 for UI timestamps, instead of unsigned long.
3768 * msdos.c (mouse_get_pos): Likewise.
3769 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3770 * w32gui.h (Time): Define by including "systime.h" rather than by
3771 declaring it ourselves. (Bug#8664)
3773 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3774 * image.c (clear_image_cache): Likewise.
3776 * term.c (term_mouse_position): Don't assume time_t wraparound.
3778 Be more systematic about user-interface timestamps.
3779 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3780 and sometimes 'EMACS_UINT', to represent these timestamps.
3781 This change causes it to use 'Time' uniformly, as that's what X uses.
3782 This makes the code easier to follow, and makes it easier to catch
3783 integer overflow bugs such as Bug#8664.
3784 * frame.c (Fmouse_position, Fmouse_pixel_position):
3785 Use Time, not unsigned long, for user-interface timestamps.
3786 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3787 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3788 * keyboard.h (last_event_timestamp): Likewise.
3789 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3790 * menu.h (xmenu_show): Likewise.
3791 * term.c (term_mouse_position): Likewise.
3792 * termhooks.h (struct input_event.timestamp): Likewise.
3793 (struct terminal.mouse_position_hook): Likewise.
3794 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3795 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3796 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3797 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3799 * menu.h, termhooks.h: Include "systime.h", for Time.
3801 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3802 Don't assume that the difference between two unsigned long values
3803 can fit into an integer. At this point, we know button_down_time
3804 <= event->timestamp, so the difference must be nonnegative, so
3805 there's no need to cast the result if double-click-time is
3806 nonnegative, as it should be; check that it's nonnegative, just in
3807 case. This bug is triggered when events are more than 2**31 ms
3808 apart (about 25 days). (Bug#8664)
3810 * xselect.c (last_event_timestamp): Remove duplicate decl.
3811 (x_own_selection): Remove needless cast to unsigned long.
3813 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3814 that always fit in int. Use a sentinel instead of a counter, to
3815 avoid a temp and to allay GCC's concerns about possible int overflow.
3816 * frame.h (struct frame): Use int for menu_bar_items_used
3817 instead of EMACS_INT, since it always fits in int.
3819 * menu.c (grow_menu_items): Check for int overflow.
3821 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3823 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3824 Before, the code was not consistent. These values cannot exceed
3825 2**31 - 1 so there's no need to make them unsigned.
3826 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3827 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3828 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3830 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3832 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3833 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3834 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3835 presumably because the widths might not match.
3837 * window.c (size_window): Avoid needless test at loop start.
3839 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3841 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3843 2011-05-12 Drew Adams <drew.adams@oracle.com>
3845 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3847 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3849 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3850 `width' to `bar_area_x' and `bar_area_width', respectively.
3851 (x_scroll_run): Take account of fringe background extension.
3853 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3854 Rename local vars `left' and `width' to `bar_area_x' and
3855 `bar_area_width', respectively.
3856 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3857 background extension.
3859 2011-05-10 Jim Meyering <meyering@redhat.com>
3861 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3863 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3865 * image.c (Finit_image_library): Return t for built-in image types,
3866 like pbm and xbm. (Bug#8640)
3868 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3870 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3872 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3874 * w32console.c (Fset_screen_color): Doc fix.
3875 (Fget_screen_color): New function.
3876 (syms_of_ntterm): Defsubr it.
3878 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3879 unlink the temporary file if Fcall_process didn't create it in the
3881 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3882 child process will be redirected to a file specified with `:file'.
3883 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3884 cue to call_process_cleanup not to close that handle.
3886 2011-05-07 Ben Key <bkey76@gmail.com>
3888 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3889 one of two shell specific rules, either bootstrap-temacs-CMD or
3890 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3891 to the previous implementation of the bootstrap-temacs rule.
3892 The bootstrap-temacs-CMD rule is similar to the previous
3893 implementation of the bootstrap-temacs rule except that it
3894 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3897 These changes, along with some changes to nt/configure.bat,
3898 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3899 earlier fix to add support for --cflags and --ldflags options
3900 that include quotes so that it works whether make uses cmd or
3903 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3905 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3906 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3908 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3909 a string. Handle both cases.
3910 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3911 (Fdbus_register_method): Use Qinvalid_function.
3913 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3915 * makefile.w32-in: Update dependencies.
3916 (LISP_H): Add inttypes.h and stdin.h.
3917 (PROCESS_H): Add unistd.h.
3919 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3921 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3922 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3924 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3926 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3928 * term.c (vfatal): Remove stray call to va_end.
3929 It's not needed and the C Standard doesn't allow it here anyway.
3931 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3932 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3934 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3937 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3939 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3941 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3943 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3945 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3947 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3948 * charset.c (Fdefine_charset_internal): Don't initialize
3949 charset.code_space[15]. The value was garbage, on hosts with
3950 32-bit int (Bug#8600).
3952 * lread.c (read_integer): Be more consistent with string-to-number.
3953 Use string_to_number to do the actual conversion; this avoids
3954 rounding errors and fixes some other screwups. Without this fix,
3955 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3956 (digit_to_number): Move earlier, for benefit of read_integer.
3957 Return -1 if the digit is out of range for the base, -2 if it is
3958 not a digit in any supported base. (Bug#8602)
3960 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3962 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3963 to match comment at start of function. This also removes a
3964 GCC warning about overflow in a 32+64-bit port.
3966 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3968 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3969 Reported by Stefan Monnier in
3970 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3971 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3972 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3974 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3975 (EMACS_UINTPTR): Likewise, with uintptr_t.
3977 * lisp.h: Prefer 64-bit EMACS_INT if available.
3978 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3979 on 32-bit hosts that have 64-bit int, so that they can access
3981 However, temporarily disable this change unless the temporary
3982 symbol WIDE_EMACS_INT is defined.
3984 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3986 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3987 This removes an assumption that EMACS_INT and long are the same
3988 width as pointers. The assumption is true for Emacs porting targets
3989 now, but we want to make other targets possible.
3990 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3991 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3992 In the rest of the code, change types of integers that hold casted
3993 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3994 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3995 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3996 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3997 No need to cast type when ORing.
3998 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3999 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4000 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4001 assume EMACS_INT is the same width as char *.
4002 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4003 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4004 Remove no-longer-needed casts.
4005 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4006 (xg_tool_bar_help_callback, xg_make_tool_item):
4007 Use EMACS_INTPTR to hold an integer
4008 that will be cast to void *; this can avoid a GCC warning
4009 if EMACS_INT is not the same width as void *.
4010 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4011 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4012 (current_message_1, set_message_1):
4013 Use a local to convert to proper width without a cast.
4014 * xmenu.c (dialog_selection_callback): Likewise.
4016 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4017 Also, don't assume VALBITS / RAND_BITS is less than 5,
4018 and don't rely on undefined behavior when shifting a 1 left into
4020 * lisp.h (get_random): Change signature to match.
4022 * lread.c (hash_string): Use size_t, not int, for hash computation.
4023 Normally we prefer signed values; but hashing is special, because
4024 it's better to use unsigned division on hash table sizes so that
4025 the remainder is nonnegative. Also, size_t is the natural width
4026 for hashing into memory. The previous code used 'int', which doesn't
4027 retain enough info to hash well into very large tables.
4028 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4030 * dbusbind.c: Don't possibly lose pointer info when converting.
4031 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4032 Use XPNTR rather than XHASH, so that the high-order bits of
4033 the pointer aren't lost when converting through void *.
4035 * eval.c (Fautoload): Don't double-shift a pointer.
4037 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4039 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4041 * gnutls.c (DEF_GNUTLS_FN):
4042 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4044 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4046 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4049 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4051 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4052 New version that can reserve upto 2GB of heap space.
4054 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4056 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4058 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4060 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4061 `gnutls_certificate_set_x509_key_file'.
4063 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4065 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4066 Update dependencies.
4068 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4070 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4071 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4072 Remove unused parameter `fildes'.
4073 * process.c (read_process_output, send_process): Don't pass it.
4075 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4077 Fix previous change: the library cache is defined in w32.c.
4078 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4079 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4081 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4083 Implement dynamic loading of GnuTLS on Windows.
4085 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4086 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4087 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4090 * gnutls.c (Qgnutls_dll): Define.
4091 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4092 (gnutls_*): Declare function pointers.
4093 (init_gnutls_functions): New function to initialize function pointers.
4094 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4095 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4096 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4097 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4098 (emacs_gnutls_write, emacs_gnutls_read)
4099 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4100 (Fgnutls_available_p): New function.
4101 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4102 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4103 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4105 * image.c: Include w32.h.
4106 (Vimage_type_cache): Delete.
4107 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4108 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4109 (w32_delayed_load): Move to w32.c.
4111 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4113 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4114 (w32_delayed_load): Move from image.c. When loading a library, record
4115 its filename in the :loaded-from property of the library id.
4116 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4117 Initialize and staticpro them.
4118 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4120 * process.c: Include lisp.h before w32.h, not after.
4121 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4122 instead of gnutls_record_check_pending.
4124 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4126 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4128 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4129 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4132 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4134 * xterm.c (x_set_frame_alpha): Do not set property on anything
4135 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4137 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4139 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4141 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4143 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4144 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4145 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4146 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4147 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4148 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4149 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4150 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4151 (Qgnutls_bootprop_callbacks_verify): Make static.
4153 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4155 * callproc.c: Indentation fixup.
4157 * sysdep.c (wait_for_termination_1): Make static.
4158 (wait_for_termination, interruptible_wait_for_termination):
4159 Move after wait_for_termination_1.
4161 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4163 * sysdep.c (interruptible_wait_for_termination): New function
4164 which is like wait_for_termination, but allows keyboard
4167 * callproc.c (Fcall_process): Add (:file "file") as an option for
4169 (Fcall_process_region): Ditto.
4171 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4173 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4174 rather than `XVECTOR (FOO)->size'.
4176 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4177 inttypes.h, as a gnulib replacement is used if it not available in
4180 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4182 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4183 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4184 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4186 * coding.c (coding_alloc_by_realloc): Error out if destination
4187 will grow beyond MOST_POSITIVE_FIXNUM.
4188 (decode_coding_emacs_mule): Abort if there isn't enough place in
4189 charbuf for the composition carryover bytes. Reserve an extra
4190 space for up to 2 characters produced in a loop.
4191 (decode_coding_iso_2022): Abort if there isn't enough place in
4192 charbuf for the composition carryover bytes.
4194 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4196 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4197 aborting when %lld or %lll format is passed.
4198 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4199 %llo or %llx format is passed. (Bug#8545)
4201 * window.c (window_scroll_line_based): Use a marker instead of
4202 simple variables to record original value of point. (Bug#7952)
4204 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4205 produced by %s or %c overflows available buffer space. (Bug#8545)
4207 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4209 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4210 (SIZE_MAX): Move defn after all includes, as they might #define it.
4212 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4214 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4216 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4218 * keyboard.c (Qdelayed_warnings_hook): Define.
4219 (command_loop_1): Run `delayed-warnings-hook'
4220 if Vdelayed_warnings_list is non-nil.
4221 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4222 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4224 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4226 * doprnt.c (doprnt): Don't return value smaller than the buffer
4227 size if the message was truncated. (Bug#8545).
4229 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4231 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4232 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4234 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4236 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4238 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4240 * makefile.w32-in: Update dependencies.
4242 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4244 Improve `doprnt' and its usage. (Bug#8545)
4245 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4246 `format_end'. Remove support for %l as a conversion specifier.
4247 Don't use xrealloc. Improve diagnostics when the %l size modifier
4248 is used. Update the commentary.
4250 * eval.c (verror): Simplify calculation of size_t.
4252 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4255 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4257 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4260 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4262 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4263 This makes this file independent of the recent pseudovector change.
4265 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4267 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4269 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4270 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4271 Remove unused local.
4272 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4274 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4275 GCC 4.6.0 optimizes based on type-based alias analysis.
4276 For example, if b is of type struct buffer * and v of type struct
4277 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4278 != &v->size, and therefore "v->size = 1; b->size = 2; return
4279 v->size;" must therefore return 1. This assumption is incorrect
4280 for Emacs, since it type-puns struct Lisp_Vector * with many other
4281 types. To fix this problem, this patch adds a new type struct
4282 vectorlike_header that documents the constraints on layout of vectors
4283 and pseudovectors, and helps optimizing compilers not get fooled
4284 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4285 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4286 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4288 (XSETPVECTYPE): Rewrite in terms of new macro.
4289 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4290 This is a bit clearer, and further avoids the possibility of
4291 undesirable aliasing.
4292 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4293 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4294 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4295 since Lisp_Subr is a special case (no "next" field).
4296 (ASIZE): Now uses header.size rather than size.
4297 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4298 to avoid the hassle of writing XVECTOR (foo)->header.size.
4299 (struct vectorlike_header): New type.
4300 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4301 object, to help avoid aliasing.
4302 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4303 (SUBRP): Likewise, since Lisp_Subr is a special case.
4304 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4305 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4306 (struct Lisp_Hash_Table): Combine first two members into a single
4307 struct vectorlike_header member. All uses of "size" and "next" members
4308 changed to be "header.size" and "header.next".
4309 * buffer.h (struct buffer): Likewise.
4310 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4311 * frame.h (struct frame): Likewise.
4312 * process.h (struct Lisp_Process): Likewise.
4313 * termhooks.h (struct terminal): Likewise.
4314 * window.c (struct save_window_data, struct saved_window): Likewise.
4315 * window.h (struct window): Likewise.
4316 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4317 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4318 * buffer.c (init_buffer_once): Likewise.
4319 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4321 * process.c (Fformat_network_address): Use local var for size,
4324 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4326 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4327 * data.c (atof): Remove decl; no longer used or needed.
4328 (digit_to_number): Move to lread.c.
4329 (Fstring_to_number): Use new string_to_number function, to be
4330 consistent with how the Lisp reader treats infinities and NaNs.
4331 Do not assume that floating-point numbers represent EMACS_INT
4332 without losing information; this is not true on most 64-bit hosts.
4333 Avoid double-rounding errors, by insisting on integers when
4334 parsing non-base-10 numbers, as the documentation specifies.
4335 * lisp.h (string_to_number): New decl, replacing ...
4336 (isfloat_string): Remove.
4337 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4338 (read1): Do not accept +. and -. as integers; this
4339 appears to have been a coding error. Similarly, do not accept
4340 strings like +-1e0 as floating point numbers. Do not report
4341 overflow for integer overflows unless the base is not 10 which
4342 means we have no simple and reliable way to continue.
4343 Break out the floating-point parsing into a new
4344 function string_to_number, so that Fstring_to_number parses
4345 floating point numbers consistently with the Lisp reader.
4346 (digit_to_number): Move here from data.c. Make it static inline.
4347 (E_CHAR, EXP_INT): Remove, replacing with ...
4348 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4349 (string_to_number): New function, replacing isfloat_string.
4350 This function checks for valid syntax and produces the resulting
4351 Lisp float number too. Rework it so that string-to-number
4352 no longer mishandles examples like "1.0e+". Use strtoumax,
4353 so that overflow for non-base-10 numbers is reported only when
4354 there's no portable and simple way to convert to floating point.
4356 * textprop.c (set_text_properties_1): Rewrite for clarity,
4357 and to avoid GCC warning about integer overflow.
4359 * intervals.h (struct interval): Use EMACS_INT for members
4360 where EMACS_UINT might cause problems. See
4361 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4362 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4363 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4365 (offset_intervals): Tell GCC not to worry about length overflow
4366 when negating a negative length.
4368 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4369 (overrun_check_free): Likewise.
4371 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4372 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4375 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4376 (gnutls_make_error): Rename local to avoid shadowing.
4377 (gnutls_emacs_global_deinit): ifdef out; not used.
4378 (Fgnutls_boot): Use const for pointer to readonly storage.
4379 Comment out unused local. Fix pointer signedness problems.
4381 * lread.c (openp): Don't stuff size_t into an 'int'.
4382 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4383 about possible signed overflow.
4385 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4386 (GDK_KEY_g): Don't define if already defined.
4387 (xg_prepare_tooltip): Avoid pointer signedness problem.
4388 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4390 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4391 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4393 * xfns.c (Fx_window_property): Simplify a bit,
4394 to make a bit faster and to avoid GCC 4.6.0 warning.
4395 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4397 * fns.c (internal_equal): Don't assume size_t fits in int.
4399 * alloc.c (compact_small_strings): Tighten assertion a little.
4401 Replace pEd with more-general pI, and fix some printf arg casts.
4402 * lisp.h (pI): New macro, generalizing old pEd macro to other
4403 conversion specifiers. For example, use "...%"pI"d..." rather
4404 than "...%"pEd"...".
4405 (pEd): Remove. All uses replaced with similar uses of pI.
4406 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4407 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4408 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4409 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4410 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4411 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4412 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4414 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4415 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4416 * print.c (safe_debug_print, print_object): Likewise.
4417 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4419 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4420 avoiding the 0 flag, which is not portable.
4421 * process.c (Fmake_network_process): Use pI to avoid cast.
4422 * region-cache.c (pp_cache): Likewise.
4423 * xdisp.c (decode_mode_spec): Likewise.
4424 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4425 behavior on 64-bit hosts with printf arg.
4426 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4427 (x_stop_queuing_selection_requests): Likewise.
4428 (x_get_window_property): Don't truncate byte count to an 'int'
4431 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4432 here, since it parses constructs like leading '-' and spaces,
4433 which are not wanted; and it overflows with large numbers.
4434 Instead, simply match F[0-9]+, which is what is wanted anyway.
4436 * alloc.c: Remove unportable assumptions about struct layout.
4437 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4438 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4439 (allocate_vectorlike, make_pure_vector): Use the new macros,
4440 plus offsetof, to remove unportable assumptions about struct layout.
4441 These assumptions hold on all porting targets that I know of, but
4442 they are not guaranteed, they're easy to remove, and removing them
4443 makes further changes easier.
4445 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4446 This doesn't fix a bug but makes the code clearer.
4447 (string_overrun_cookie): Now const. Use initializers that
4448 don't formally overflow signed char, to avoid warnings.
4449 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4450 can cause Emacs to crash when string overrun checking is enabled.
4451 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4452 multiple of sizeof (EMACS_INT); it need not be, if
4453 alignof(EMACS_INT) < sizeof (EMACS_INT).
4454 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4456 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4458 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4460 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4462 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4463 supposed to be handshaking. (Bug#8556)
4464 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4466 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4468 * lisp.h (Qdebug): List symbol.
4469 * eval.c (Qdebug): Restore global linkage.
4470 * keyboard.c (debug-on-event): New variable.
4471 (handle_user_signal): Break into debugger when debug-on-event
4472 matches the current signal symbol.
4474 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4476 * alloc.c (check_sblock, check_string_bytes)
4477 (check_string_free_list): Convert to standard C.
4479 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4481 * w32.c (emacs_gnutls_push): Fix typo.
4483 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4485 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4486 "cast to pointer from integer of different size".
4488 Improve doprnt and its use in verror. (Bug#8545)
4489 * doprnt.c (doprnt): Document the set of format control sequences
4490 supported by the function. Use SAFE_ALLOCA instead of always
4493 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4494 is one byte too soon. Don't use xrealloc; instead xfree and
4497 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4499 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4502 * gnutls.c: Renamed global_initialized to
4503 gnutls_global_initialized. Added internals for the
4504 :verify-hostname-error, :verify-error, and :verify-flags
4505 parameters of `gnutls-boot' and documented those parameters in the
4506 docstring. Start callback support.
4507 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4508 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4509 on error. Return error code.
4510 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4511 (emacs_gnutls_read): Likewise.
4512 (Fgnutls_boot): Return handshake error code.
4513 (emacs_gnutls_handle_error): New function.
4514 (wsaerror_to_errno): Likewise.
4516 * w32.h (emacs_gnutls_pull): Add prototype.
4517 (emacs_gnutls_push): Likewise.
4519 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4520 (emacs_gnutls_push): Likewise.
4522 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4524 * process.c (wait_reading_process_output): Check if GnuTLS
4525 buffered some data internally if no FDs are set for TLS
4528 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4529 (LIBS): Link to USER_LIBS.
4530 ($(BLD)/gnutls.$(0)): New target.
4532 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4534 * xdisp.c (handle_single_display_spec): Rename the
4535 display_replaced_before_p argument into display_replaced_p, to
4536 make it consistent with the commentary. Fix typos in the
4539 * textprop.c (syms_of_textprop): Remove dead code.
4540 (copy_text_properties): Delete obsolete commentary about an
4541 interface that was deleted long ago. Fix typos in the description
4544 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4545 to changes in oldXMenu/XMenu.h from 2011-04-16.
4546 <menu_help_message, prev_menu_help_message>: Constify.
4547 (IT_menu_make_room): menu->help_text is now `const char **';
4550 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4551 to changes in oldXMenu/XMenu.h from 2011-04-16.
4552 (struct XMenu): Declare `help_text' `const char **'.
4554 * xfaces.c <Qunspecified>: Make extern again.
4556 * syntax.c: Include sys/types.h before including regex.h, as
4559 * doc.c (get_doc_string): Improve the format passed to `error'.
4561 * doprnt.c (doprnt): Improve commentary.
4563 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4565 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4568 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4569 changes in globals.h immediately force recompilation.
4570 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4571 $(CURDIR)/s/ms-w32.h.
4572 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4574 * character.c (Fchar_direction): Function deleted.
4575 (syms_of_character): Don't defsubr it.
4576 <char-direction-table>: Deleted.
4578 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4580 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4581 * doprnt.c: Include limits.h.
4582 (SIZE_MAX): New macro.
4583 (doprnt): Return a size_t value. 2nd arg is now size_t.
4584 Many local variables are now size_t instead of int or unsigned.
4585 Improve overflow protection. Support `l' modifier for integer
4586 conversions. Support %l conversion. Don't assume an EMACS_INT
4587 argument for integer conversions and for %c.
4589 * lisp.h (doprnt): Restore prototype.
4591 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4594 * Makefile.in (base_obj): Add back doprnt.o.
4596 * deps.mk (doprnt.o): Add back prerequisites.
4597 (callint.o): Depend on character.h.
4599 * eval.c (internal_lisp_condition_case): Include the handler
4600 representation in the error message.
4601 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4602 when breaking from the loop.
4604 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4606 * callint.c (Fcall_interactively): When displaying error message
4607 about invalid control letter, pass the character's codepoint, not
4608 a pointer to its multibyte form. Improve display of the character
4609 in octal and display also its hex code.
4611 * character.c (char_string): Use %x to display the (unsigned)
4612 codepoint of an invalid character, to avoid displaying a bogus
4615 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4616 `error', not SYMBOL_NAME itself.
4618 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4619 character arguments to `error'.
4621 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4622 to `error' in error message about FINAL_CHAR argument. Make sure
4623 FINAL_CHAR is a character, and use %c when it is passed as
4624 argument to `error'.
4626 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4628 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4630 * w32.c: Include <time.h>.
4631 (sys_localtime): New function.
4633 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4635 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4637 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4639 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4641 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4644 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4646 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4647 gl_state.e_property when gl_state.object is Qt.
4649 * insdel.c (make_gap_larger): Remove limitation of buffer size
4652 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4654 * xdisp.c (lookup_glyphless_char_display)
4655 (produce_glyphless_glyph): Handle cons cell entry in
4656 glyphless-char-display.
4657 (Vglyphless_char_display): Document it.
4659 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4660 glyphless-char-display.
4662 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4664 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4666 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4668 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4669 definition for no-X builds.
4671 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4673 Static checks with GCC 4.6.0 and non-default toolkits.
4675 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4677 * process.c (keyboard_bit_set): Define only if SIGIO.
4678 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4679 (send_process): Repair possible setjmp clobbering.
4681 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4683 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4685 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4687 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4688 Define only if needed.
4690 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4691 by pacifying GCC about it. Maybe it's time to retire it?
4692 * xfaces.c (USG, __TIMEVAL__): Likewise.
4694 * dispextern.h (struct redisplay_interface): Rename param
4696 * termhooks.h (struct terminal): Likewise.
4697 * xterm.c (xembed_send_message): Likewise.
4699 * insdel.c (make_gap_smaller): Define only if
4700 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4702 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4705 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4706 so that we aren't warned about unused symbols.
4708 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4710 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4712 * xfns.c (x_real_positions): Mark locals as initialized.
4714 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4716 * xterm.c: Fix problems found by static analysis with other toolkits.
4717 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4718 (x_dispatch_event): Declare static if USE_GTK, and
4719 define if USE_GTK || USE_X_TOOLKIT.
4720 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4721 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4722 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4723 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4725 * xmenu.c (menu_help_callback): Pointer type fixes.
4726 Use const pointers when pointing at readonly data. Avoid pointer
4728 (FALSE): Remove unused macro.
4729 (update_frame_menubar): Remove unused decl.
4731 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4733 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4734 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4735 (single_menu_item): Rename local to avoid shadowing.
4737 * keyboard.c (make_lispy_event): Remove unused local var.
4739 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4740 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4742 * bitmaps: Change bitmaps from unsigned char back to the X11
4743 compatible char. Avoid the old compiler warnings about
4744 out-of-range initializers by using, for example, '\xab' rather
4747 * xgselect.c (xgselect_initialize): Check vs interface
4748 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4750 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4752 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4753 to read-only memory.
4755 * fns.c (vector): Remove; this old hack is no longer needed.
4757 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4759 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4761 * xrdb.c (x_load_resources): Omit unused local.
4763 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4764 (x_window): Rename locals to avoid shadowing.
4765 (USG): Use the kludged USG macro, to pacify gcc.
4767 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4768 (x_term_init): Remove local to avoid shadowing.
4770 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4772 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4773 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4775 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4777 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4779 Fix regex.c, syntax.c and friends for buffers > 2GB.
4780 * syntax.h (struct gl_state_s): Declare character position members
4783 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4785 * textprop.c (verify_interval_modification, interval_of):
4786 Declare arguments EMACS_INT.
4788 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4791 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4793 * indent.c (Fvertical_motion): Local variable it_start is now
4796 * regex.c (re_match, re_match_2, re_match_2_internal)
4797 (bcmp_translate, regcomp, regexec, print_double_string)
4798 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4799 (re_compile_pattern, re_exec): Declare arguments and local
4800 variables `size_t' and `ssize_t' and return values `regoff_t', as
4802 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4803 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4804 <compile_stack_type>: `size' and `avail' are now `size_t'.
4806 * regex.h <regoff_t>: Use ssize_t, not int.
4807 (re_search, re_search_2, re_match, re_match_2): Arguments that
4808 specify buffer/string position and length are now ssize_t and
4809 size_t. Return type is regoff_t.
4811 2011-04-16 Ben Key <bkey76@gmail.com>
4813 * nsfont.m: Fixed bugs in ns_get_family and
4814 ns_descriptor_to_entity that were caused by using free to
4815 deallocate memory blocks that were allocated by xmalloc (via
4816 xstrdup). This caused Emacs to crash when compiled with
4817 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4818 --enable-checking=xmallocoverrun). xfree is now used to
4819 deallocate these memory blocks.
4821 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4823 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4825 emacs_write: Accept and return EMACS_INT for sizes.
4826 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4828 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4829 Accept and return EMACS_INT.
4830 (emacs_gnutls_write): Return the number of bytes written on
4832 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4833 (emacs_read, emacs_write): Remove check for negative size, as the
4834 Emacs source code has been audited now.
4835 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4836 (emacs_read, emacs_write): Use it.
4837 * process.c (send_process): Adjust to the new signatures of
4838 emacs_write and emacs_gnutls_write. Do not attempt to store
4839 a byte offset into an 'int'; it might overflow.
4840 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4842 * sound.c: Don't assume sizes fit in 'int'.
4843 (struct sound_device.period_size, alsa_period_size):
4844 Return EMACS_INT, not int.
4845 (struct sound_device.write, vox_write, alsa_write):
4846 Accept EMACS_INT, not int.
4847 (wav_play, au_play): Use EMACS_INT to store sizes and to
4848 record read return values.
4850 2011-04-15 Ben Key <bkey76@gmail.com>
4852 * keyboard.c (Qundefined): Don't declare static since it is used
4854 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4855 static since they are used in nsfont.m.
4857 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4859 * process.c (Qprocessp): Don't declare static.
4860 * lisp.h (Qprocessp): Declare again.
4862 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4864 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4866 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4868 Improve C-level modularity by making more things 'static'.
4870 Don't publish debugger-only interfaces to other modules.
4871 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4872 (verify_bytepos, count_markers): Move decls to the only modules
4874 * region-cache.h (pp_cache): Likewise.
4875 * window.h (check_all_windows): Likewise.
4876 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4878 * sysdep.c (croak): Now static, if
4879 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4880 * syssignal.h (croak): Declare only if not static.
4882 * alloc.c (refill_memory_reserve): Now static if
4883 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4884 * lisp.h (refill_memory_reserve): Declare only if not static.
4886 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4887 Define only if USE_LUCID.
4889 * xrdb.c (x_customization_string, x_rm_string): Now static.
4891 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4892 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4894 * xdisp.c (draw_row_with_mouse_face): Now static.
4895 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4897 * window.h (check_all_windows): Mark externally visible.
4899 * window.c (window_deletion_count): Now static.
4901 * undo.c: Make symbols static if they're not exported.
4902 (last_undo_buffer, last_boundary_position, pending_boundary):
4905 * textprop.c (interval_insert_behind_hooks): Now static.
4906 (interval_insert_in_front_hooks): Likewise.
4908 * term.c: Make symbols static if they're not exported.
4909 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4910 (max_frame_lines, tty_set_terminal_modes):
4911 (tty_reset_terminal_modes, tty_turn_off_highlight):
4912 (get_tty_terminal): Now static.
4913 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4914 * termhooks.h (term_mouse_moveto): Do not declare if
4916 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4917 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4919 * sysdep.c: Make symbols static if they're not exported.
4920 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4922 (sigprocmask_set, full_mask): Remove; unused.
4923 (wait_debugging): Mark as visible.
4924 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4925 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4927 * syntax.c (syntax_temp): Define only if !__GNUC__.
4929 * sound.c (current_sound_device, current_sound): Now static.
4931 * search.c (searchbufs, searchbuf_head): Now static.
4933 * scroll.c (scroll_cost): Remove; unused.
4934 * dispextern.h (scroll_cost): Remove decl.
4936 * region-cache.h (pp_cache): Mark as externally visible.
4938 * process.c: Make symbols static if they're not exported.
4939 (process_tick, update_tick, create_process, chan_process):
4940 (Vprocess_alist, proc_buffered_char, datagram_access):
4941 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4942 (deactivate_process): Mark defn as static, as well as decl.
4943 * lisp.h (create_process): Remove decl.
4944 * process.h (chan_process, Vprocess_alist): Remove decls.
4946 * print.c: Make symbols static if they're not exported.
4947 (print_depth, new_backquote_output, being_printed, print_buffer):
4948 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4949 (print_interval, print_number_index, initial_stderr_stream):
4951 * lisp.h (Fprinc): Remove decl.
4952 (debug_output_compilation_hack): Mark as externally visible.
4954 * sysdep.c (croak): Move decl from here to syssignal.h.
4955 * syssignal.h (croak): Put it here, so the API can be checked when
4956 'croak' is called from dissociate_if_controlling_tty.
4958 * minibuf.c: Make symbols static if they're not exported.
4959 (minibuf_save_list, choose_minibuf_frame): Now static.
4960 * lisp.h (choose_minibuf_frame): Remove decl.
4962 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4964 * lread.c: Make symbols static if they're not exported.
4965 (read_objects, initial_obarray, oblookup_last_bucket_number):
4967 (make_symbol): Remove; unused.
4968 * lisp.h (initial_obarray, make_symbol): Remove decls.
4970 * keyboard.c: Make symbols static if they're not exported.
4971 (single_kboard, recent_keys_index, total_keys, recent_keys):
4972 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4973 (this_single_command_key_start, echoing, last_auto_save):
4974 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4975 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4976 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4977 (Vlispy_mouse_stem, double_click_count):
4979 (force_auto_save_soon): Define only if SIGDANGER.
4980 (ignore_mouse_drag_p): Now static if
4981 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4982 (print_help): Remove; unused.
4983 (stop_character, last_timer_event): Mark as externally visible.
4984 * keyboard.h (ignore_mouse_drag_p): Declare only if
4985 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4986 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4987 * lisp.h (echoing): Remove decl.
4988 (force_auto_save_soon): Declare only if SIGDANGER.
4989 * xdisp.c (redisplay_window): Simplify code, to make it more
4990 obvious that ignore_mouse_drag_p is not accessed if !defined
4991 USE_GTK && !defined HAVE_NS.
4993 * intervals.c: Make symbols static if they're not exported.
4994 (merge_properties_sticky, merge_interval_right, delete_interval):
4996 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4998 * insdel.c: Make symbols static if they're not exported.
4999 However, leave prepare_to_modify_buffer alone. It's never
5000 called from outside this function, but that appears to be a bug.
5001 (combine_after_change_list, combine_after_change_buffer):
5002 (adjust_after_replace, signal_before_change): Now static.
5003 (adjust_after_replace_noundo): Remove; unused.
5004 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5005 (signal_before_change): Remove decls.
5007 * indent.c (val_compute_motion, val_vmotion): Now static.
5009 * image.c: Make symbols static if they're not exported.
5010 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5012 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5013 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5015 * fringe.c (standard_bitmaps): Now static.
5016 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5018 * frame.c: Make symbols static if they're not exported.
5019 (x_report_frame_params, make_terminal_frame): Now static.
5020 (get_frame_param): Now static, unless HAVE_NS.
5021 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5022 (x_get_resource_string): Remove; not used.
5023 * frame.h (make_terminal_frame, x_report_frame_params):
5024 (x_get_resource_string); Remove decls.
5025 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5026 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5028 * font.c, fontset.c: Make symbols static if they're not exported.
5029 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5030 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5031 * font.c (font_close_object): Now static.
5032 * font.h (font_close_object): Remove.
5033 * fontset.c (FONTSET_OBJLIST): Remove.
5034 (free_realized_fontset) #if-0 the body, which does nothing.
5035 (face_suitable_for_char_p): #if-0, as it's never called.
5036 * fontset.h (face_suitable_for_char_p): Remove decl.
5037 * xfaces.c (face_at_string_position):
5038 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5039 since 0 is always ASCII.
5041 * fns.c (weak_hash_tables): Now static.
5043 * fileio.c: Make symbols static if they're not exported.
5044 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5045 (Vwrite_region_annotation_buffers): Now static.
5047 * eval.c: Make symbols static if they're not exported.
5048 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5049 * lisp.h (backtrace_list): Remove decl.
5051 * emacs.c: Make symbols static if they're not exported.
5052 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5053 (fatal_error_code, fatal_error_signal_hook, standard_args):
5055 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5056 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5057 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5058 * lisp.h (fatal_error_signal_hook): Remove decl.
5059 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5061 * editfns.c: Move a (normally-unused) function to its only use.
5062 * editfns.c, lisp.h (get_operating_system_release): Remove.
5063 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5064 worth the hassle of breaking this out.
5066 * xterm.c: Make symbols static if they're not exported.
5067 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5068 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5069 (x_destroy_window, x_delete_display):
5071 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5072 (x_mouse_leave): Remove; unused.
5073 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5074 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5075 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5077 (x_mouse_leave): Declare only if WINDOWSNT.
5078 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5079 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5082 * ftxfont.c: Make symbols static if they're not exported.
5083 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5085 * font.h (ftxfont_driver): Likewise.
5087 * xfns.c: Make symbols static if they're not exported.
5088 (x_last_font_name, x_display_info_for_name):
5089 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5090 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5091 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5092 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5093 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5094 (last_show_tip_args): Now static.
5095 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5096 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5097 (x_screen_planes): Remove; unused.
5098 * dispextern.h (x_screen_planes): Remove decl.
5100 * dispnew.c: Make symbols static if they're not exported.
5101 * dispextern.h (redraw_garbaged_frames, scrolling):
5102 (increment_row_positions): Remove.
5103 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5104 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5106 (redraw_garbaged_frames): Remove; unused.
5108 * xfaces.c: Make symbols static if they're not exported.
5109 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5111 * xterm.h (defined_color): Remove decls.
5112 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5113 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5114 (menu_face_changed_default, defined_color, free_realized_face):
5115 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5116 (ascii_face_of_lisp_face): Remove; unused.
5118 * xdisp.c: Make symbols static if they're not exported.
5119 * dispextern.h (scratch_glyph_row, window_box_edges):
5120 (glyph_to_pixel_coords, set_cursor_from_row):
5121 (get_next_display_element, set_iterator_to_next):
5122 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5123 (show_mouse_face): Remove decls
5124 * frame.h (message_buf_print): Likewise.
5125 * lisp.h (pop_message, set_message, check_point_in_composition):
5127 * xterm.h (set_vertical_scroll_bar): Likewise.
5128 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5129 (message_buf_print, scratch_glyph_row, displayed_buffer):
5130 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5131 (get_next_display_element, show_mouse_face, window_box_edges):
5132 (frame_to_window_pixel_xy, check_point_in_composition):
5133 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5134 (glyph_to_pixel_coords): Remove; unused.
5136 * dired.c (file_name_completion): Now static.
5138 * dbusbind.c (xd_in_read_queued_messages): Now static.
5140 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5141 * data.c (circular_list_error): Remove.
5143 * commands.h (last_point_position, last_point_position_buffer):
5144 (last_point_position_window): Remove decls.
5145 * keyboard.c: Make these variables static.
5147 * coding.h (coding, code_convert_region, encode_coding_gap):
5149 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5150 (iso_code_class, detect_coding, code_convert_region): Now static.
5151 (encode_coding_gap): Remove; unused.
5153 * chartab.c (chartab_chars, chartab_bits): Now static.
5155 * charset.h (charset_iso_8859_1): Remove decl.
5156 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5159 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5160 * ccl.c (Vccl_program_table): Now static.
5161 (check_ccl_update): Remove; unused.
5163 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5164 * category.h: ... from here.
5165 * category.c (check_category_table, set_category_set): Now static.
5167 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5168 * lisp.h: Remove these decls.
5170 * buffer.c (buffer_count): Remove unused var.
5172 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5173 so that it's not optimized away.
5174 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5175 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5176 exported only to the debugger.
5178 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5179 * atimer.h (run_all_atimers): Remove; not exported.
5181 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5182 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5183 was inaccessible from Lisp.
5184 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5185 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5187 alloc.c: Import and export fewer symbols, and remove unused items.
5188 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5190 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5191 it's not optimized away by whole-program optimization.
5192 (message_enable_multibyte, free_misc): Remove.
5193 (catchlist, handlerlist, mark_backtrace):
5194 Declare only if BYTE_MARK_STACK.
5195 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5196 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5197 (message_enable_multibyte): Remove decl.
5198 (free_misc, interval_free_list, float_block, float_block_index):
5199 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5200 (cons_free_list, last_marked_index):
5202 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5203 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5204 (mark_backtrace): Define only if BYTE_MARK_STACK.
5205 * xdisp.c (message_enable_multibyte): Now static.
5207 Declare Lisp_Object Q* variables to be 'static' if not exported.
5208 This makes it easier for human readers (and static analyzers)
5209 to see whether these variables are used from other modules.
5210 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5211 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5212 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5213 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5214 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5215 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5216 * xmenu.c, xselect.c:
5217 Declare Q* vars static if they are not used in other modules.
5218 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5219 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5220 Remove decls of unexported vars.
5221 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5223 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5225 Make Emacs functions such as Fatom 'static' by default.
5226 This makes it easier for human readers (and static analyzers)
5227 to see whether these functions can be called from other modules.
5228 DEFUN now defines a static function. To make the function external
5229 so that it can be used in other C modules, use the new macro DEFUE.
5230 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5231 (Finit_image_library):
5232 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5233 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5234 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5235 Remove decls, since these functions are now static.
5236 (Funintern, Fget_internal_run_time): New decls, since these functions
5237 were already external.
5239 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5240 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5241 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5242 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5243 * keyboard.c, keymap.c, lread.c:
5244 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5245 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5246 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5247 Mark functions with DEFUE instead of DEFUN,
5248 if they are used in other modules.
5249 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5250 decls for now-static functions.
5251 * buffer.h (Fdelete_overlay): Remove decl.
5252 * callproc.c (Fgetenv_internal): Mark as internal.
5253 * composite.c (Fremove_list_of_text_properties): Remove decl.
5254 (Fcomposition_get_gstring): New forward static decl.
5255 * composite.h (Fcomposite_get_gstring): Remove decl.
5256 * dired.c (Ffile_attributes): New forward static decl.
5257 * doc.c (Fdocumntation_property): New forward static decl.
5258 * eval.c (Ffetch_bytecode): New forward static decl.
5259 (Funintern): Remove extern decl; now in .h file where it belongs.
5260 * fileio.c (Fmake_symbolic_link): New forward static decl.
5261 * image.c (Finit_image_library): New forward static decl.
5262 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5263 * intervals.h (Fprevious_property_change):
5264 (Fremove_list_of_text_properties): Remove decls.
5265 * keyboard.c (Fthis_command_keys): Remove decl.
5266 (Fcommand_execute): New forward static decl.
5267 * keymap.c (Flookup_key): New forward static decl.
5268 (Fcopy_keymap): Now static.
5269 * keymap.h (Flookup_key): Remove decl.
5270 * process.c (Fget_process): New forward static decl.
5271 (Fprocess_datagram_address): Mark as internal.
5272 * syntax.c (Fsyntax_table_p): New forward static decl.
5273 (skip_chars): Remove duplicate decl.
5274 * textprop.c (Fprevious_property_change): New forward static decl.
5275 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5277 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5278 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5280 * editfns.c (Fformat): Remove unreachable code.
5282 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5284 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5287 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5289 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5290 when at ZV. (Bug#8487)
5292 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5294 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5296 * keyboard.c (parse_tool_bar_item): Likewise.
5297 * sound.c (sound_cleanup, alsa_close): Likewise.
5298 * termcap.c (tgetent): Likewise.
5299 * xfns.c (x_default_font_parameter): Likewise.
5300 * xsettings.c (read_and_apply_settings): Likewise.
5302 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5303 (overrun_check_free): Protoize.
5305 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5307 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5308 since callers should never pass a negative size.
5309 Change the signature to match that of plain 'read' and 'write'; see
5310 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5311 * lisp.h: Update prototypes of emacs_write and emacs_read.
5313 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5315 * xdisp.c (redisplay_window): Don't try to determine the character
5316 position of the scroll margin if the window start point w->startp
5317 is outside the buffer's accessible region. (Bug#8468)
5319 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5321 Fix write-region and its subroutines for buffers > 2GB.
5322 * fileio.c (a_write, e_write): Modify declaration of arguments and
5323 local variables to support buffers larger than 2GB.
5324 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5326 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5327 argument, local variables, and return value.
5329 * lisp.h: Update prototypes of emacs_write and emacs_read.
5331 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5333 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5335 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5337 Fix more problems found by GCC 4.6.0's static checks.
5339 * xdisp.c (vmessage): Use a better test for character truncation.
5341 * charset.c (load_charset_map): <, not <=, for optimization,
5342 and to avoid potential problems with integer overflow.
5343 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5344 * casetab.c (set_identity, shuffle): Likewise.
5345 * editfns.c (Fformat): Likewise.
5346 * syntax.c (skip_chars): Likewise.
5348 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5349 This also lets GCC 4.6.0 generate slightly better loop code.
5351 * callint.c (Fcall_interactively): <, not <=, for optimization.
5352 (Fcall_interactively): Count the number of arguments produced,
5353 not the number of arguments given. This is simpler and lets GCC
5354 4.6.0 generate slightly better code.
5356 * ftfont.c: Distingish more carefully between FcChar8 and char.
5357 The previous code passed unsigned char * to a functions like
5358 strlen and xstrcasecmp that expect char *, which does not
5359 conform to the C standard.
5360 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5361 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5362 char * when the C standard requires it.
5364 * keyboard.c (read_char): Remove unused var.
5366 * eval.c: Port to Windows vsnprintf (Bug#8435).
5368 (SIZE_MAX): Define if the headers do not.
5369 (verror): Do not give up if vsnprintf returns a negative count.
5370 Instead, grow the buffer. This ports to Windows vsnprintf, which
5371 does not conform to C99. Problem reported by Eli Zaretskii.
5372 Also, simplify the allocation scheme, by avoiding the need for
5373 calling realloc, and removing the ALLOCATED variable.
5375 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5377 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5378 But keep the doprint source code for now, as we might revamp it
5379 and use it again (Bug#8435).
5380 * lisp.h (doprnt): Remove.
5381 * Makefile.in (base_obj): Remove doprnt.o.
5382 * deps.mk (doprnt.o): Remove.
5384 error: Print 32- and 64-bit integers portably (Bug#8435).
5385 Without this change, on typical 64-bit hosts error ("...%d...", N)
5386 was used to print both 32- and 64-bit integers N, which relied on
5388 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5390 * lisp.h (error, verror): Mark as printf-like functions.
5391 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5392 Report overflow in size calculations when allocating printf buffer.
5393 Do not truncate output string at its first null byte.
5394 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5395 Truncate the output at a character boundary, since vsnprintf does not
5397 * charset.c (check_iso_charset_parameter): Convert internal
5398 character to string before calling 'error', since %c now has the
5400 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5401 overflow when computing char to be passed to 'error'. Do not
5402 pass Lisp_Object to 'error'; pass the integer instead.
5403 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5404 formatted with plain %d.
5406 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5408 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5410 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5412 * xterm.c (x_catch_errors): Remove duplicate declaration.
5414 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5416 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5418 2011-04-10 Jim Meyering <meyering@redhat.com>
5420 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5421 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5422 return ssize_t not "int", and use size_t as the buffer length.
5423 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5424 * gnutls.h: Update declarations.
5425 * process.c (read_process_output): Use ssize_t, to match.
5426 (send_process): Likewise.
5428 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5430 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5432 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5434 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5435 Use unsigned char, to match FcChar8 type definition.
5437 * xterm.c (handle_one_xevent):
5438 * xmenu.c (create_and_show_popup_menu):
5439 * xselect.c (x_decline_selection_request)
5440 (x_reply_selection_request): Avoid type-punned deref of X events.
5442 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5444 Fix some uses of `int' instead of EMACS_INT.
5445 * search.c (string_match_1, fast_string_match)
5446 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5447 (scan_buffer, find_next_newline_no_quit)
5448 (find_before_next_newline, search_command, Freplace_match)
5449 (Fmatch_data): Make some `int' variables be EMACS_INT.
5451 * xdisp.c (display_count_lines): 3rd argument and return value now
5452 EMACS_INT. All callers changed.
5453 (pint2hrstr): Last argument is now EMACS_INT.
5455 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5456 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5457 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5458 (decode_coding_utf_16, decode_coding_emacs_mule)
5459 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5460 (decode_coding_ccl, decode_coding_charset)
5461 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5462 (decode_coding_iso_2022, decode_coding_emacs_mule)
5463 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5464 <char_offset, last_offset>: Declare EMACS_INT.
5465 (encode_coding_utf_8, encode_coding_utf_16)
5466 (encode_coding_emacs_mule, encode_invocation_designation)
5467 (encode_designation_at_bol, encode_coding_iso_2022)
5468 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5469 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5471 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5472 (encode_invocation_designation): Last argument P_NCHARS is now
5474 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5475 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5477 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5480 * ccl.c (Fccl_execute_on_string): Declare some variables
5483 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5485 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5487 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5489 * process.c (Fformat_network_address): Doc fix.
5491 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5493 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5495 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5497 * keyboard.c (read_char): Call Lisp function help-form-show,
5498 instead of using internal_with_output_to_temp_buffer.
5499 (Qhelp_form_show): New var.
5500 (syms_of_keyboard): Use DEFSYM macro.
5502 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5504 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5506 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5508 * process.c (Flist_processes): Remove to Lisp.
5509 (list_processes_1): Delete.
5511 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5513 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5515 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5517 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5519 Fix more problems found by GCC 4.6.0's static checks.
5521 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5523 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5525 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5527 * xdisp.c (vmessage): Mark as a printf-like function.
5529 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5531 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5533 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5534 printf-like functions.
5535 (tiff_load): Add casts to remove these marks before passing them
5536 to system-supplied API.
5538 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5540 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5541 This avoids several warnings with gcc -Wstrict-overflow.
5542 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5543 directly, rather than having caller test rule sign. This avoids
5544 some unnecessary tests.
5545 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5546 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5547 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5549 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5550 (xfont_open): Avoid unnecessary tests.
5552 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5554 * composite.h, composite.c (composition_gstring_put_cache):
5555 Use EMACS_INT, not int, for length.
5557 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5558 breaking out part of COMPOSITION_DECODE_RULE.
5559 (COMPOSITION_DECODE_RULE): Use it.
5560 * composite.c (get_composition_id): Remove unused local vars,
5561 by using the new macro.
5563 * textprop.c (set_text_properties_1): Change while to do-while,
5564 since the condition is always true at first.
5566 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5567 (interval_deletion_adjustment): Return unsigned value.
5570 * process.c (list_processes_1, create_pty, read_process_output):
5571 (exec_sentinel): Remove vars that were set but not used.
5572 (create_pty): Remove unnecessary "volatile"s.
5573 (Fnetwork_interface_info): Avoid possibility of int overflow.
5574 (read_process_output): Do adaptive read buffering even if carryover.
5575 (read_process_output): Simplify nbytes computation if buffered.
5577 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5579 * syntax.c (scan_words): Remove var that was set but not used.
5580 (update_syntax_table): Use unsigned instead of int.
5582 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5583 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5584 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5586 * print.c (print_error_message): Avoid int overflow.
5588 * font.c (font_list_entities): Redo for clarity,
5589 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5591 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5592 (font_score): Avoid potential overflow in diff calculation.
5594 * fns.c (substring_both): Remove var that is set but not used.
5595 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5597 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5599 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5600 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5601 can always succeed if overflow has undefined behavior.
5603 * search.c (boyer_moore, wordify): Remove vars set but not used.
5604 (wordify): Omit three unnecessary tests.
5606 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5607 All callers changed. This avoids the need for an unused var.
5609 * casefiddle.c (casify_region): Remove var that is set but not used.
5611 * dired.c (file_name_completion): Remove var that is set but not used.
5613 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5615 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5616 (Finsert_file_contents): Remove unnecessary code checking fd.
5618 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5619 Check for integer overflow on size calculations.
5621 * buffer.c (Fprevious_overlay_change): Remove var that is set
5624 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5625 Remove vars that are set but not used.
5626 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5627 (timer_check_2): Mark vars as initialized.
5629 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5631 * image.c (lookup_image): Remove var that is set but not used.
5632 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5634 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5635 that are set but not used.
5637 * xfns.c (make_invisible_cursor): Don't return garbage
5638 if XCreateBitmapFromData fails (Bug#8410).
5640 * xselect.c (x_get_local_selection, x_handle_property_notify):
5641 Remove vars that are set but not used.
5643 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5644 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5646 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5647 Remove var that is set but not used.
5648 (scroll_bar_windows_size): Now size_t, not int.
5649 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5652 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5653 (map_tty_color) [!defined MSDOS]: Likewise.
5655 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5657 * coding.c: Remove vars that are set but not used.
5658 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5659 All callers changed.
5660 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5661 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5662 (decode_coding_charset): Remove vars that are set but not used.
5664 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5665 that is set but not used.
5667 * print.c (print_object): Remove var that is set but not used.
5669 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5670 The gnulib version avoids calling malloc in the usual case,
5671 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5672 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5673 * filelock.c (current_lock_owner): Likewise.
5674 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5675 * sysdep.c: Include allocator.h, careadlinkat.h.
5676 (emacs_no_realloc_allocator): New static constant.
5677 (emacs_readlink): New function.
5678 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5679 ../lib/careadlinkat.h.
5681 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5683 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5684 first non-nil return value).
5686 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5688 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5689 if not defined (Bug#8403).
5691 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5693 * xdisp.c (display_count_lines): Remove parameter `start',
5694 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5695 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5696 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5697 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5698 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5699 and thereabouts. All callers changed.
5700 (get_per_char_metric): Remove parameter `f', unused since
5701 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5703 2011-04-02 Jim Meyering <meyering@redhat.com>
5705 do not dereference NULL upon failed strdup
5706 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5707 (ns_get_family): Likewise.
5709 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5711 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5713 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5715 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5718 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5720 Add lexical binding.
5722 * window.c (Ftemp_output_buffer_show): New fun.
5723 (Fsave_window_excursion):
5724 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5726 * lread.c (lisp_file_lexically_bound_p): New function.
5727 (Fload): Bind Qlexical_binding.
5728 (readevalloop): Remove `evalfun' arg.
5729 Bind Qinternal_interpreter_environment.
5730 (Feval_buffer): Bind Qlexical_binding.
5731 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5733 (syms_of_lread): Declare `lexical-binding'.
5735 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5737 * keyboard.c (eval_dyn): New fun.
5738 (menu_item_eval_property): Use it.
5740 * image.c (parse_image_spec): Use Ffunctionp.
5742 * fns.c (concat, mapcar1): Accept byte-code-functions.
5744 * eval.c (Fsetq): Handle lexical vars.
5745 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5746 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5747 (FletX, Flet): Obey lexical binding.
5748 (Fcommandp): Handle closures.
5749 (Feval): New `lexical' arg.
5750 (eval_sub): New function extracted from Feval. Use it almost
5751 everywhere where Feval was used. Look up vars in lexical env.
5753 (Ffunctionp): Move from subr.el.
5754 (Ffuncall): Handle closures.
5755 (apply_lambda): Remove `eval_flags'.
5756 (funcall_lambda): Handle closures and new byte-code-functions.
5757 (Fspecial_variable_p): New function.
5758 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5759 but without exporting it to Lisp.
5761 * doc.c (Fdocumentation, store_function_docstring):
5762 * data.c (Finteractive_form): Handle closures.
5764 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5767 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5769 (exec_byte_code): New function extracted from Fbyte_code to handle new
5770 calling convention for byte-code-functions. Add new byte-codes.
5772 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5774 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5776 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5778 * xdisp.c (redisplay_internal): Fix prototype.
5780 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5782 * xdisp.c (SCROLL_LIMIT): New macro.
5783 (try_scrolling): Use it when setting scroll_limit.
5784 Limit scrolling to 100 screen lines.
5785 (redisplay_window): Even when falling back on "recentering",
5786 position point in the window according to scroll-conservatively,
5787 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5789 (try_scrolling): When point is above the window, allow searching
5790 as far as scroll_max, or one screenful, to compute vertical
5791 distance from PT to the scroll margin position. This prevents
5792 try_scrolling from unnecessarily failing when
5793 scroll-conservatively is set to a value slightly larger than the
5794 window height. Clean up the case of PT below the margin at bottom
5795 of window: scroll_max can no longer be INT_MAX. When aggressive
5796 scrolling is in use, don't let point enter the opposite scroll
5797 margin as result of the scroll.
5798 (syms_of_xdisp) <scroll-conservatively>: Document the
5799 threshold of 100 lines for never-recentering scrolling.
5801 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5803 * dispextern.h (move_it_by_lines):
5804 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5805 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5806 (message_log_check_duplicate): Remove parameters `prev_bol' and
5807 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5808 (redisplay_internal): Remove parameter `preserve_echo_area',
5809 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5811 * indent.c (Fvertical_motion):
5812 * window.c (window_scroll_pixel_based, Frecenter):
5813 Don't pass `need_y_p' to `move_it_by_lines'.
5815 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5817 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5818 steal a few bits to be more compact.
5819 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5820 Remove unneeded casts.
5822 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5824 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5826 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5827 binding" message (bug#7967).
5829 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5831 Fix more problems found by GCC 4.6.0's static checks.
5833 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5834 Remove unused local var.
5836 * editfns.c (Fmessage_box): Remove unused local var.
5838 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5839 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5840 Omit unused local vars.
5841 * window.c (shrink_windows): Omit unused local var.
5842 * menu.c (digest_single_submenu): Omit unused local var.
5843 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5844 Omit unused local var.
5846 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5847 Don't assume string length fits in int.
5848 (keyremap_step, read_key_sequence): Use size_t for sizes.
5849 (read_key_sequence): Don't check last_real_key_start redundantly.
5851 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5852 instead of alloca (Bug#8344).
5854 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5855 (Fbacktrace_frame): Don't assume nframes fits in int.
5857 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5859 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5862 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5864 * cm.c (calccost): Turn while-do into do-while, for clarity.
5866 * keyboard.c (syms_of_keyboard): Use the same style as later
5867 in this function when indexing through an array. This also
5868 works around GCC bug 48267.
5870 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5872 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5874 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5875 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5877 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5878 This avoids undefined behavior on integer overflow, and is a bit
5879 more convenient anyway since it is compared to a size_t variable.
5881 Variadic C functions now count arguments with size_t, not int.
5882 This avoids an unnecessary limitation on 64-bit machines, which
5883 caused (substring ...) to crash on large vectors (Bug#8344).
5884 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5885 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5886 All variadic functions and their callers changed accordingly.
5887 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5888 * data.c (arith_driver, float_arith_driver): Likewise.
5889 * editfns.c (general_insert_function): Likewise.
5890 * eval.c (struct backtrace.nargs, interactive_p)
5891 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5892 (funcall_lambda, mark_backtrace): Likewise.
5893 * fns.c (concat): Likewise.
5894 * frame.c (x_set_frame_parameters): Likewise.
5895 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5896 0 if not found, not -1. All callers changed.
5898 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5899 (stack_copy_size): Now size_t, not int.
5900 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5902 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5904 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5905 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5906 All callers changed.
5908 * lisp.h (multibyte_char_to_unibyte):
5909 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5910 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5911 * character.h (CHAR_TO_BYTE8):
5912 * cmds.c (internal_self_insert):
5913 * editfns.c (general_insert_function):
5914 * keymap.c (push_key_description):
5915 * search.c (Freplace_match):
5916 * xdisp.c (message_dolog, set_message_1): All callers changed.
5918 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5920 * keyboard.c (safe_run_hook_funcall): New function.
5921 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5922 don't set the hook to nil, but remove the offending function instead.
5923 (Qcommand_hook_internal): Remove, unused.
5924 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5925 Vcommand_hook_internal.
5927 * eval.c (enum run_hooks_condition): Remove.
5928 (funcall_nil, funcall_not): New functions.
5929 (run_hook_with_args): Call each function through a `funcall' argument.
5930 Remove `cond' argument, now redundant.
5931 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5932 (Frun_hook_with_args_until_failure): Adjust accordingly.
5933 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5935 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5937 * dispextern.h (string_buffer_position): Remove declaration.
5939 * print.c (strout): Remove parameter `multibyte', unused since
5940 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5942 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5943 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5944 All callers changed.
5946 * w32.c (_wsa_errlist): Use braces for struct initializers.
5948 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5949 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5950 All callers changed.
5951 (string_buffer_position): Likewise. Also, make static (it's never
5952 used outside xdisp.c).
5953 (cursor_row_p): Remove parameter `w', unused since
5954 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5955 (decode_mode_spec): Remove parameter `precision', introduced during
5956 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5957 All callers changed.
5959 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5961 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5963 2011-03-27 Anders Lindgren <andlind@gmail.com>
5965 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5966 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5967 (ns_update_auto_hide_menu_bar): New functions.
5968 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5969 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5970 ns_constrain_all_frames.
5971 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5972 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5974 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5976 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5978 2011-03-27 Glenn Morris <rgm@gnu.org>
5980 * syssignal.h: Replace RETSIGTYPE with void.
5981 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5982 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5983 Replace SIGTYPE with void everywhere.
5984 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5985 * s/template.h (SIGTYPE): Remove commented out definition.
5987 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5989 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5990 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5992 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5994 * w32.c (read_unc_volume): Use parameter `henum', instead of
5995 global variable `wget_enum_handle'.
5997 * keymap.c (describe_vector): Remove parameters `indices' and
5998 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5999 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6001 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6003 * keyboard.c (timer_check): Remove parameter `do_it_now',
6004 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6005 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6006 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6008 * keyboard.c (read_char):
6009 * w32menu.c (w32_menu_display_help):
6010 * xmenu.c (show_help_event, menu_help_callback):
6011 Adjust calls to `show_help_echo'.
6013 * gtkutil.c (xg_maybe_add_timer):
6014 * keyboard.c (readable_events):
6015 * process.c (wait_reading_process_output):
6016 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6018 * insdel.c (adjust_markers_gap_motion):
6019 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6020 (gap_left, gap_right): Don't call it.
6022 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6024 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6025 incurred during fontification.
6027 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6029 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6030 (DEFVAR_PER_BUFFER): Don't pass it.
6032 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6033 (scrolling_window): Don't pass it.
6035 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6037 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6039 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6041 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6042 of variables specific to SELinux and computation of `encoded_absname'.
6044 * image.c (XPutPixel): Remove unused variable `height'.
6046 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6048 * unexw32.c (get_section_info): Remove unused variable `section'.
6050 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6051 (system_process_attributes): Remove unused variable `sess'.
6052 (sys_read): Remove unused variable `err'.
6054 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6055 (w32_wnd_proc): Remove unused variable `isdead'.
6056 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6057 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6058 (x_create_tip_frame): Remove unused variable `tem'.
6060 * w32inevt.c (w32_console_read_socket):
6061 Remove unused variable `no_events'.
6063 * w32term.c (x_draw_composite_glyph_string_foreground):
6064 Remove unused variable `width'.
6066 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6068 * w32term.c (x_set_glyph_string_clipping):
6069 Don't pass uninitialized region to CombineRgn.
6071 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6073 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6074 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6075 (Fx_close_connection): Remove unused variable `i'.
6077 * w32font.c (w32font_draw): Return number of glyphs.
6078 (w32font_open_internal): Remove unused variable `i'.
6079 (w32font_driver): Add missing initializer.
6081 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6082 (fill_in_menu): Remove unused variable `items_added'.
6084 * w32term.c (last_mouse_press_frame): Remove static global variable.
6085 (w32_clip_to_row): Remove unused variable `f'.
6086 (x_delete_terminal): Remove unused variable `i'.
6088 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6089 (NOTHING): Remove unused static global variable.
6090 (uniscribe_check_otf): Remove unused variable `table'.
6091 (uniscribe_font_driver): Add missing initializers.
6093 2011-03-23 Julien Danjou <julien@danjou.info>
6095 * term.c (Fsuspend_tty, Fresume_tty):
6096 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6097 * window.c (temp_output_buffer_show):
6098 * insdel.c (signal_before_change):
6099 * frame.c (Fhandle_switch_frame):
6100 * fileio.c (Fdo_auto_save):
6101 * emacs.c (Fkill_emacs):
6102 * editfns.c (save_excursion_restore):
6103 * cmds.c (internal_self_insert):
6104 * callint.c (Fcall_interactively):
6105 * buffer.c (Fkill_all_local_variables):
6106 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6108 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6109 unconditionnaly since it does the check itself.
6111 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6113 Fix more problems found by GCC 4.5.2's static checks.
6115 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6116 the first time through the loop, since we know p0 < p1 then.
6117 This also avoids a gcc -Wstrict-overflow warning.
6119 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6120 leading to a memory leak, possible in functions like
6121 load_charset_map_from_file that can allocate an unbounded number
6122 of objects (Bug#8318).
6124 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6125 that could (at least in theory) be that large.
6127 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6128 This is less likely to overflow, and avoids undefined behavior if
6129 overflow does occur. All callers changed. Use strtoul to scan
6130 for the unsigned long integer.
6131 (pint2hrstr): Simplify and tune code slightly.
6132 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6134 * scroll.c (do_scrolling): Work around GCC bug 48228.
6135 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6137 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6138 This also avoids a warning with gcc -Wstrict-overflow.
6139 (validate_x_resource_name): Simplify count usage.
6140 This also avoids a warning with gcc -Wstrict-overflow.
6142 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6145 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6147 * process.c (Fmake_network_process): Use socklen_t, not int,
6148 where POSIX says socklen_t is required in portable programs.
6149 This fixes a porting bug on hosts like 64-bit HP-UX, where
6150 socklen_t is wider than int (Bug#8277).
6151 (Fmake_network_process, server_accept_connection):
6152 (wait_reading_process_output, read_process_output):
6155 * process.c: Rename or move locals to avoid shadowing.
6156 (list_processes_1, Fmake_network_process):
6157 (read_process_output_error_handler, exec_sentinel_error_handler):
6158 Rename or move locals.
6159 (Fmake_network_process): Define label "retry_connect" only if needed.
6160 (Fnetwork_interface_info): Fix pointer signedness.
6161 (process_send_signal): Add cast to avoid pointer signedness problem.
6162 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6163 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6165 Make tparam.h and terminfo.c consistent.
6166 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6167 Include tparam.h instead, since it declares them.
6168 * cm.h (PC): Remove extern decl; tparam.h now does this.
6169 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6170 * terminfo.c: Include tparam.h, to check interfaces.
6171 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6172 (tparam): Adjust signature to match interface in tparam.h;
6173 this removes some undefined behavior. Check that outstring and len
6174 are zero, which they always are with Emacs.
6175 * tparam.h (PC, BC, UP): New extern decls.
6177 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6178 (xftfont_open): Rename locals to avoid shadowing.
6180 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6181 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6182 (OTF_TAG_SYM): Omit macro if not needed.
6183 (ftfont_list): Remove unused local.
6184 (get_adstyle_property, ftfont_pattern_entity):
6185 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6186 Rename locals to avoid shadowing.
6188 * xfont.c (xfont_list_family): Mark var as initialized.
6190 * xml.c (make_dom): Now static.
6192 * composite.c (composition_compute_stop_pos): Rename local to
6194 (composition_reseat_it): Remove unused locals.
6195 (find_automatic_composition, composition_adjust_point): Likewise.
6196 (composition_update_it): Mark var as initialized.
6197 (find_automatic_composition): Mark vars as initialized,
6198 with a FIXME (Bug#8290).
6200 character.h: Rename locals to avoid shadowing.
6201 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6202 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6203 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6204 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6207 * textprop.c (property_change_between_p): Remove; unused.
6209 * intervals.c (interval_start_pos): Now static.
6211 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6213 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6214 Rename locals to avoid shadowing.
6216 * sound.c (wav_play, au_play, Fplay_sound_internal):
6217 Fix pointer signedness.
6218 (alsa_choose_format): Remove unused local var.
6219 (wav_play): Initialize a variable to 0, to prevent undefined
6220 behavior (Bug#8278).
6222 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6224 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6226 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6227 clobbering (Bug#8298).
6228 * sysdep.c (sys_subshell): Likewise.
6229 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6231 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6232 This should get cleaned up, so that child_setup has the
6233 same signature on all platforms.
6235 * callproc.c (call_process_cleanup): Now static.
6236 (relocate_fd): Rename locals to avoid shadowing.
6238 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6240 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6241 not to be necessary, and produces flickering.
6243 2011-03-20 Glenn Morris <rgm@gnu.org>
6245 * config.in: Remove file.
6247 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6249 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6250 are now in src/globals.h.
6251 (syms_of_minibuf): Remove spurious & from previous change.
6253 2011-03-20 Leo <sdl.web@gmail.com>
6255 * minibuf.c (completing-read-function): New variable.
6256 (completing-read-default): Rename from completing-read.
6257 (completing-read): Call completing-read-function.
6259 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6261 * xfaces.c (Fx_load_color_file):
6262 Read color file from absolute filename (bug#8250).
6264 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6266 * makefile.w32-in: Update dependencies.
6268 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6270 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6272 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6274 Fix more problems found by GCC 4.5.2's static checks.
6276 * process.c (make_serial_process_unwind, send_process_trap):
6277 (sigchld_handler): Now static.
6279 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6280 That way, the code declares only the vars that it needs.
6281 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6282 * s/cygwin.h (PTY_ITERATION): Likewise.
6283 * s/darwin.h (PTY_ITERATION): Likewise.
6284 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6286 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6287 * process.c (allocate_pty): Don't declare stb unless it's needed.
6289 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6290 (CONSTANTLIM): Remove; unused.
6291 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6292 Define only if needed.
6294 * unexelf.c (unexec): Name an expression,
6295 to avoid gcc -Wbad-function-cast warning.
6296 Use a different way to cause a compilation error if anyone uses
6297 n rather than nn, a way that does not involve shadowing.
6298 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6300 * deps.mk (unexalpha.o): Remove; unused.
6302 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6303 * unexec.h: New file.
6304 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6305 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6307 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6308 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6309 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6310 Change as necessary to match prototype in unexec.h.
6312 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6314 (back_comment, skip_chars): Mark vars as initialized.
6316 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6317 Rename locals to avoid shadowing.
6319 * lread.c (read1): Rewrite so as not to use empty "else".
6320 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6322 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6324 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6325 warning when compiling print.c.
6327 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6328 instead of using an uninitialized var.
6329 (font_sort_entities): Mark var as initialized.
6331 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6333 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6334 pointers to constants.
6335 (font_parse_fcname): Remove unused vars.
6336 (font_delete_unmatched): Now static.
6337 (font_get_spec): Remove; unused.
6338 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6339 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6340 Rename or move locals to avoid shadowing.
6342 * fns.c (require_nesting_list, require_unwind): Now static.
6343 (Ffillarray): Rename locals to avoid shadowing.
6345 * floatfns.c (domain_error2): Define only if needed.
6346 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6348 * alloc.c (mark_backtrace): Move decl from here ...
6349 * lisp.h: ... to here, so that it can be checked.
6351 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6352 (Fdefvar): Rewrite so as not to use empty "else".
6353 (lisp_indirect_variable): Name an expression,
6354 to avoid gcc -Wbad-function-cast warning.
6355 (Fdefvar): Rename locals to avoid shadowing.
6357 * callint.c (quotify_arg, quotify_args): Now static.
6358 (Fcall_interactively): Rename locals to avoid shadowing.
6359 Use const pointer when appropriate.
6361 * lisp.h (get_system_name, get_operating_system_release):
6362 Move decls here, to check interfaces.
6363 * process.c (get_operating_system_release): Move decl to lisp.h.
6364 * xrdb.c (get_system_name): Likewise.
6365 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6366 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6367 some of which prompt warnings from gcc -Wbad-function-cast.
6368 (Fformat_time_string, Fencode_time, Finsert_char):
6369 (Ftranslate_region_internal, Fformat):
6370 Rename or remove local vars to avoid shadowing.
6371 (Ftranslate_region_internal): Mark var as initialized.
6373 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6376 * lisp.h (eassert): Check that the argument compiles, even if
6377 ENABLE_CHECKING is not defined.
6379 * data.c (Findirect_variable): Name an expression, to avoid
6380 gcc -Wbad-function-cast warning.
6381 (default_value, arithcompare, arith_driver, arith_error): Now static.
6382 (store_symval_forwarding): Rename local to avoid shadowing.
6383 (Fmake_variable_buffer_local, Fmake_local_variable):
6384 Mark variables as initialized.
6385 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6387 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6388 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6389 Rename locals to avoid shadowing.
6390 (mark_stack): Move local variables into the #ifdef region where
6392 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6393 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6395 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6396 (GC_STRING_CHARS): Remove; not used.
6397 (Fmemory_limit): Cast sbrk's returned value to char *.
6399 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6400 avoids undefined behavior in theory.
6402 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6404 Use functions, not macros, for up- and down-casing (Bug#8254).
6405 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6406 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6407 to use the following functions instead of these macros.
6408 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6409 EMACS_INT, since callers assume the returned value fits in int.
6410 (upcase1): Likewise, for UPCASE_TABLE.
6411 (uppercasep, lowercasep, upcase): New static inline functions.
6412 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6413 the race-condition problem in the old DOWNCASE.
6415 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6416 Rename locals to avoid shadowing.
6417 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6418 (regex_compile, re_search_2, re_match_2_internal):
6419 Remove unused local vars.
6420 (FREE_VAR): Rewrite so as not to use empty "else",
6421 which gcc can warn about.
6422 (regex_compile, re_match_2_internal): Mark locals as initialized.
6423 (RETALLOC_IF): Define only if needed.
6424 (WORDCHAR_P): Likewise. This one is never needed, but is used
6425 only in a comment talking about a compiler bug, so put inside
6426 the #if 0 of that comment.
6427 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6428 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6431 * search.c (boyer_moore): Rename locals to avoid shadowing.
6432 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6433 (PREV_CHAR_BOUNDARY): Likewise.
6435 * search.c (simple_search): Remove unused var.
6437 * dired.c (compile_pattern): Move decl from here ...
6438 * lisp.h: ... to here, so that it can be checked.
6439 (struct re_registers): New forward decl.
6441 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6443 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6445 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6446 Rename locals to avoid shadowing.
6447 (Fvertical_motion): Mark locals as initialized.
6449 * casefiddle.c (casify_object, casify_region): Now static.
6450 (casify_region): Mark local as initialized.
6452 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6454 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6455 New macros, so that the caller can use some names other than
6456 gcpro1, gcpro2, etc.
6457 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6459 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6460 argument, for consistency with GCPRO2_VAR, etc: it is now the
6461 prefix of the variable, not the variable itself. All uses
6463 * dired.c (directory_files_internal, file_name_completion):
6464 Rename locals to avoid shadowing.
6466 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6467 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6468 dired.c's scmp function, had undefined behavior.
6469 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6470 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6471 * buffer.h: ... to here, because these macros use current_buffer,
6472 and the new implementation with inline functions needs to have
6473 current_buffer in scope now, rather than later when the macros
6475 (downcase, upcase1): New static inline functions.
6476 (DOWNCASE, UPCASE1): Reimplement using these functions.
6477 This avoids undefined behavior in expressions like
6478 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6479 from race conditions in accessing the global variables
6480 case_temp1 and case_temp2.
6481 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6482 * lisp.h (case_temp1, case_temp2): Remove their decls.
6483 * character.h (ASCII_CHAR_P): Move from here ...
6484 * lisp.h: ... to here, so that the inline functions mentioned
6487 * dired.c (directory_files_internal_unwind): Now static.
6489 * fileio.c (file_name_as_directory, directory_file_name):
6490 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6492 (file_name_as_directory): Use const pointers when appropriate.
6493 (Fexpand_file_name): Likewise. In particular, newdir might
6494 point at constant storage, so make it a const pointer.
6495 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6496 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6498 (Fset_file_times, Finsert_file_contents, auto_save_error):
6499 Rename locals to avoid shadowing.
6501 * minibuf.c (choose_minibuf_frame_1): Now static.
6502 (Ftry_completion, Fall_completions): Rename or remove locals
6505 * marker.c (bytepos_to_charpos): Remove; unused.
6507 * lisp.h (verify_bytepos, count_markers): New decls,
6508 so that gcc does not warn that these functions aren't declared.
6510 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6511 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6512 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6513 (copy_text): Remove unused local var.
6515 * filelock.c (within_one_second): Now static.
6516 (lock_file_1): Rename local to avoid shadowing.
6518 * buffer.c (fix_overlays_before): Mark locals as initialized.
6519 (fix_start_end_in_overlays): Likewise. This function should be
6520 simplified by using pointers-to-pointers, but that's a different
6522 (switch_to_buffer_1): Now static.
6523 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6524 (report_overlay_modification): Rename locals to avoid shadowing.
6526 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6527 Fix pointer signedness issue.
6528 (sys_subshell): Mark local as volatile if checking for lint,
6529 to suppress a gcc -Wclobbered warning that does not seem to be right.
6530 (MAXPATHLEN): Define only if needed.
6532 * process.c (serial_open, serial_configure): Move decls from here ...
6533 * systty.h: ... to here, so that they can be checked.
6535 * fns.c (get_random, seed_random): Move extern decls from here ...
6536 * lisp.h: ... to here, so that they can be checked.
6538 * sysdep.c (reset_io): Now static.
6539 (wait_for_termination_signal): Remove; unused.
6541 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6542 (copy_keymap_item, append_key, push_text_char_description):
6544 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6545 (DENSE_TABLE_SIZE): Remove; unused.
6546 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6547 (describe_map_tree):
6548 Rename locals to avoid shadowing.
6550 * keyboard.c: Declare functions static if they are not used elsewhere.
6551 (echo_char, echo_dash, cmd_error, top_level_2):
6552 (poll_for_input, handle_async_input): Now static.
6553 (read_char, kbd_buffer_get_event, make_lispy_position):
6554 (make_lispy_event, make_lispy_movement, apply_modifiers):
6555 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6556 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6557 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6558 (read_key_sequence, read_char): Mark locals as initialized.
6559 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6561 * keyboard.h (make_ctrl_char): New decl.
6562 (mark_kboards): Move decl here ...
6563 * alloc.c (mark_kboards): ... from here.
6565 * lisp.h (force_auto_save_soon): New decl.
6567 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6568 (DEFINE_DUMMY_FUNCTION): New macro.
6569 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6571 (main): Add casts to avoid warnings
6572 if GCC considers string literals to be constants.
6574 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6576 * dbusbind.c: Pointer signedness fixes.
6577 (xd_signature, xd_append_arg, xd_initialize):
6578 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6579 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6580 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6581 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6583 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6584 if GCC considers string literals to be constants.
6585 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6587 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6589 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6590 (print_preprocess, print_object): New macro to fix last change.
6592 * print.c (print_preprocess): Don't forget font objects.
6594 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6596 * emacs.c (USAGE3): Doc fixes.
6598 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6600 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6603 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6605 * lisp.h (VWindow_system, Qfile_name_history):
6606 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6607 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6608 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6610 * w32select.c: Don't #include "keyboard.h".
6611 (run_protected): Add extern declaration for waiting_for_input.
6613 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6614 * w32console.c (detect_input_pending, read_input_pending)
6615 (encode_terminal_code):
6616 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6617 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6618 (w32_system_caret_y, Qfile_name_history):
6619 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6620 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6621 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6622 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6623 * w32proc.c (Qlocal, report_file_error):
6624 * w32term.c (Vwindow_system, updating_frame):
6625 * w32uniscribe.c (initialized, uniscribe_font_driver):
6626 Remove unneeded extern declarations.
6628 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6630 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6632 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6634 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6635 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6636 These macros can no longer be used for assignment.
6638 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6639 Assign struct members directly, instead of using BUF_BEGV etc.
6640 (record_buffer_markers, fetch_buffer_markers): New functions for
6641 recording and fetching special buffer markers.
6642 (set_buffer_internal_1, set_buffer_temp): Use them.
6644 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6646 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6648 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6649 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6651 * xdisp.c (hscroll_window_tree):
6652 (reconsider_clip_changes): Use PT instead of BUF_PT.
6654 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6656 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6657 $(EMACS_ROOT)/lib/intprops.h.
6659 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6661 Fix more problems found by GCC 4.5.2's static checks.
6663 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6664 to unsigned char * to avoid compiler diagnostic.
6665 (xg_free_frame_widgets): Make it clear that a local variable is
6666 needed only if USE_GTK_TOOLTIP.
6667 (gdk_window_get_screen): Make it clear that this macro is needed
6668 only if USE_GTK_TOOLTIP.
6669 (int_gtk_range_get_value): New function, which avoids a diagnostic
6670 from gcc -Wbad-function-cast.
6671 (xg_set_toolkit_scroll_bar_thumb): Use it.
6672 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6673 diagnostic from gcc -Wbad-function-cast.
6674 (get_utf8_string, xg_get_file_with_chooser):
6675 Rename locals to avoid shadowing.
6676 (create_dialog): Move locals to avoid shadowing.
6678 * xgselect.c (xg_select): Remove unused var.
6680 * image.c (four_corners_best): Mark locals as initialized.
6681 (gif_load): Initialize transparent_p to zero (Bug#8238).
6682 Mark another local as initialized.
6683 (my_png_error, my_error_exit): Mark with NO_RETURN.
6685 * image.c (clear_image_cache): Now static.
6686 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6687 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6688 (x_edge_detection): Remove unnecessary cast that
6689 gcc -Wbad-function-cast diagnoses.
6690 (gif_load): Fix pointer signedness.
6691 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6692 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6694 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6696 Improve quality of tests for time stamp overflow.
6697 For example, without this patch (encode-time 0 0 0 1 1
6698 1152921504606846976) returns the obviously-bogus value (-948597
6699 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6700 reports time overflow. See
6701 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6702 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6703 * editfns.c: Include limits.h and intprops.h.
6704 (TIME_T_MIN, TIME_T_MAX): New macros.
6705 (time_overflow): Move earlier, to before first use.
6706 (hi_time, lo_time): New functions, for an accurate test for
6708 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6709 (Fget_internal_run_time): Don't assume time_t fits in int.
6710 (make_time): Use list2 instead of Fcons twice.
6711 (Fdecode_time): More accurate test for out-of-range times.
6712 (check_tm_member): New function.
6713 (Fencode_time): Use it, to test for out-of-range times.
6714 (lisp_time_argument): Don't rely on undefined left-shift and
6715 right-shift behavior when checking for time stamp overflow.
6717 * editfns.c (time_overflow): New function, refactoring common code.
6718 (Fformat_time_string, Fdecode_time, Fencode_time):
6719 (Fcurrent_time_string): Use it.
6721 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6722 * dired.c (make_time): Move to ...
6723 * editfns.c (make_time): ... here.
6724 * systime.h: Note the move.
6726 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6728 * fringe.c (update_window_fringes): Remove unused variables.
6730 * unexmacosx.c (copy_data_segment): Also copy __got section.
6733 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6735 * termcap.c [MSDOS]: Include "msdos.h".
6736 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6737 Constify `char *' arguments and their references according to
6738 prototypes in tparam.h.
6740 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6742 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6743 Adapt all references accordingly.
6745 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6747 2011-03-11 Tom Tromey <tromey@redhat.com>
6749 * buffer.c (syms_of_buffer): Remove obsolete comment.
6751 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6753 * termhooks.h (encode_terminal_code): Declare prototype.
6755 * msdos.c (encode_terminal_code): Don't declare prototype.
6757 * term.c (encode_terminal_code): Now external again, used by
6758 w32console.c and msdos.c.
6760 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6761 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6763 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6765 Fix some minor problems found by GCC 4.5.2's static checks.
6767 * fringe.c (update_window_fringes): Mark locals as initialized
6769 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6771 * alloc.c (mark_fringe_data): Move decl from here ...
6772 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6773 to check its interface.
6774 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6776 * fontset.c (free_realized_fontset): Now static.
6777 (Fset_fontset_font): Rename local to avoid shadowing.
6778 (fontset_font): Mark local as initialized.
6779 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6781 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6783 * xselect.c (x_disown_buffer_selections): Remove; not used.
6784 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6785 (x_own_selection, Fx_disown_selection_internal): Rename locals
6787 (x_handle_dnd_message): Remove local to avoid shadowing.
6789 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6790 so that the caller can use some name other than gcpro1.
6791 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6792 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6793 (Fx_backspace_delete_keys_p):
6794 Use them to avoid shadowing, and rename vars to avoid shadowing.
6795 (x_decode_color, x_set_name, x_window): Now static.
6796 (Fx_create_frame): Add braces to silence GCC warning.
6797 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6798 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6799 Remove unused locals.
6800 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6801 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6802 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6805 * xterm.h (x_mouse_leave): New decl.
6807 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6808 Remove unused functions.
6809 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6810 (x_calc_absolute_position): Now static.
6811 (XTread_socket): Don't define label "out" unless it's used.
6812 Don't declare local "event" unless it's used.
6813 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6814 unless they are used.
6815 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6816 (x_fatal_error_signal): Remove; not used.
6817 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6818 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6819 (x_error_catcher, x_connection_closed, x_error_handler):
6820 (x_error_quitter, xembed_send_message, x_iconify_frame):
6821 (my_log_handler): Rename locals to avoid shadowing.
6822 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6823 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6825 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6826 Rename or move locals to avoid shadowing.
6827 (tty_defined_color, merge_face_heights): Now static.
6828 (free_realized_faces_for_fontset): Remove; not used.
6829 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6830 does not deduce is never used uninitialized.
6831 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6832 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6834 * terminal.c (store_terminal_param): Now static.
6836 * xmenu.c (menu_highlight_callback): Now static.
6837 (set_frame_menubar): Remove unused local.
6838 (xmenu_show): Rename parameter to avoid shadowing.
6839 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6840 since they might point to immutable storage.
6841 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6842 since it's unused otherwise.
6844 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6845 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6846 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6847 avoids a gcc -Wuninitialized diagnostic.
6848 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6849 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6850 does not deduce are never used uninitialized.
6852 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6854 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6855 * window.c (window_loop, size_window):
6856 (run_window_configuration_change_hook, enlarge_window): Likewise.
6858 * window.c (display_buffer): Now static.
6859 (size_window): Mark variables that gcc -Wuninitialized
6860 does not deduce are never used uninitialized.
6861 * window.h (check_all_windows): New decl, to forestall
6862 gcc -Wmissing-prototypes diagnostic.
6863 * dispextern.h (bidi_dump_cached_states): Likewise.
6865 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6867 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6869 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6870 and to avoid gcc -Wuninitialized warning.
6871 (load_charset_map): Mark variables that gcc -Wuninitialized
6872 does not deduce are never used uninitialized.
6873 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6875 * coding.c (coding_set_source, coding_set_destination):
6876 Use "else { /* comment */ }" rather than "else /* comment */;"
6877 for clarity, and to avoid gcc -Wempty-body warning.
6878 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6879 a block, when the outer 'i' will do.
6880 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6881 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6882 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6883 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6884 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6885 Rename locals to avoid shadowing.
6886 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6887 * coding.c (emacs_mule_char, encode_invocation_designation):
6888 Now static, since they're not used elsewhere.
6889 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6890 (decode_coding_object, encode_coding_object, detect_coding_system):
6891 (decode_coding_emacs_mule): Mark variables that gcc
6892 -Wuninitialized does not deduce are never used uninitialized.
6893 (detect_coding_iso_2022): Initialize a local variable that might
6894 be used uninitialized. Leave a FIXME because it's not clear that
6895 this initialization is needed. (Bug#8211)
6896 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6897 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6898 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6899 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6900 Remove unused macros.
6902 * category.c (hash_get_category_set): Remove unused local var.
6903 (copy_category_table): Now static, since it's not used elsewhere.
6904 * character.c (string_count_byte8): Likewise.
6906 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6907 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6909 * chartab.c (copy_sub_char_table): Now static, since it's not used
6911 (sub_char_table_ref_and_range, char_table_ref_and_range):
6912 Rename locals to avoid shadowing.
6913 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6915 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6916 (BIDI_BOB): Remove unused macro.
6918 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6919 deduce are never used uninitialized.
6920 * term.c (encode_terminal_code): Likewise.
6922 * term.c (encode_terminal_code): Now static. Remove unused local.
6924 * tparam.h: New file.
6925 * term.c, tparam.h: Include it.
6926 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6927 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6928 Move these decls to tparam.h, and make them agree with what
6929 is actually in tparam.c. The previous trick of using incompatible
6930 decls in different modules does not conform to the C standard.
6931 All callers of tparam changed to use tparam's actual API.
6932 * tparam.c (tparam1, tparam, tgoto):
6933 Use const pointers where appropriate.
6935 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6936 * cm.h (struct cm): Likewise.
6937 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6938 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6939 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6940 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6941 (turn_on_face, init_tty): Likewise.
6942 * termchar.h (struct tty_display_info): Likewise.
6944 * term.c (term_mouse_position): Rename local to avoid shadowing.
6946 * alloc.c (mark_ttys): Move decl from here ...
6947 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6949 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6951 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6953 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6955 * search.c (compile_pattern_1): Remove argument regp, unused since
6956 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6957 (compile_pattern): Don't pass it.
6959 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6961 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6962 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6964 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6966 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6968 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6969 gdk_window_get_screen, gdk_window_get_geometry,
6970 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6971 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6972 (xg_get_pixbuf_from_pixmap): New function.
6973 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6974 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6975 Call xg_get_pixbuf_from_pixmap instead of
6976 gdk_pixbuf_get_from_drawable.
6977 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6978 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6979 (xg_check_special_colors): Use GtkStyleContext and its functions
6981 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6982 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6983 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6984 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6985 Call gtk_widget_get_preferred_size.
6986 (xg_frame_resized): gdk_window_get_geometry only takes 5
6988 (xg_win_to_widget, xg_event_is_for_menubar):
6989 Call gdk_x11_window_lookup_for_display.
6990 (xg_set_widget_bg): New function.
6991 (delete_cb): New function.
6992 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6993 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6994 (xg_set_background_color): Call xg_set_widget_bg.
6995 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6996 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6997 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6998 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7000 (update_frame_tool_bar): Call gtk_widget_hide.
7001 (xg_initialize): Use GDK_KEY_g.
7003 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7005 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7007 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7008 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7009 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7011 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7013 * w32xfns.c (select_palette): Check success of RealizePalette against
7014 GDI_ERROR, not zero.
7016 See ChangeLog.11 for earlier changes.
7022 Copyright (C) 2011 Free Software Foundation, Inc.
7024 This file is part of GNU Emacs.
7026 GNU Emacs is free software: you can redistribute it and/or modify
7027 it under the terms of the GNU General Public License as published by
7028 the Free Software Foundation, either version 3 of the License, or
7029 (at your option) any later version.
7031 GNU Emacs is distributed in the hope that it will be useful,
7032 but WITHOUT ANY WARRANTY; without even the implied warranty of
7033 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7034 GNU General Public License for more details.
7036 You should have received a copy of the GNU General Public License
7037 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.