1 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4 * alloc.c (make_number) [!defined make_number]:
5 Remove, as lisp.h always defines this now.
6 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
7 (roundup_size): Verify that it is a power of 2.
8 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
9 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
10 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
11 -DUSE_LSB_TAG=0, to override the automatically-selected default.
12 USE_LSB_TAG now is always defined to be either 0 or 1.
14 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
15 code works fine either way, and efficiency is not a concern here,
16 as the union type is for debugging, not for production.
17 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
18 Use an inline function on all platforms when using the union type,
19 since this is simpler and 'static inline' can be used portably
21 (LISP_INITIALLY_ZERO): New macro.
22 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
23 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
25 2012-06-12 Glenn Morris <rgm@gnu.org>
27 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
29 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
31 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
32 Move BROKEN_SIGIO to configure.
34 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
35 Move NO_TERMIO to configure.
37 2012-06-12 Chong Yidong <cyd@gnu.org>
39 * image.c (imagemagick_load_image): Use MagickFlattenImage if
40 MagickMergeImageLayers is undefined. Use pixel pusher loop if
41 MagickExportImagePixels is undefined.
43 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
45 * image.c (imagemagick_load_image): Remove unused label.
47 2012-06-11 Glenn Morris <rgm@gnu.org>
49 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
50 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
51 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
52 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
54 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
56 * alloc.c (make_byte_code): New function.
57 (Fmake_byte_code): Use it. Don't purify here.
58 * lread.c (read1): Use it as well to avoid extra allocation.
60 2012-06-11 Chong Yidong <cyd@gnu.org>
62 * image.c (imagemagick_load_image): Implement transparency.
64 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
66 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
67 account for preceding backslashes. (Bug#11663)
69 2012-06-09 Chong Yidong <cyd@gnu.org>
71 * term.c: Support italics in capable terminals (Bug#9652).
72 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
73 (turn_on_face): Output using TS_enter_italic_mode if available.
74 Don't handle unused blinking and alt-charset cases.
75 (turn_off_face): Handle italic case; discard unused tty_blinking_p
76 and tty_alt_charset_p cases.
77 (tty_capable_p, init_tty): Support italics.
79 * termchar.h (struct tty_display_info): Add field for italics.
80 Remove unused blink field.
82 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
85 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
86 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
87 tty_alt_charset_p. Add tty_italic_p.
89 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
91 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
92 dbus_type_is_basic if available.
93 (xd_extract_signed, xd_extract_unsigned): Rename from
94 extract_signed and extract_unsigned, respectively. Adapt callers.
96 2012-06-09 Chong Yidong <cyd@gnu.org>
98 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
100 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
103 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
105 * xdisp.c (vmessage): Treat frame message as multibyte.
106 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
107 would generate the diagnostic "Making \302\247 buffer-local while
110 2012-06-08 Eli Zaretskii <eliz@gnu.org>
112 * dispnew.c (showing_window_margins_p): Undo last change, which
113 was done due to an inadvertent commit.
114 (adjust_frame_glyphs_for_frame_redisplay): Do call
115 showing_window_margins_p.
117 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
119 * eval.c (Fmake_var_non_special): New primitive.
120 (syms_of_eval): Defsubr it.
121 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
123 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
125 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
126 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
128 2012-06-08 Eli Zaretskii <eliz@gnu.org>
130 * alloc.c (allocate_vectorlike): Fix last change.
132 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
134 Block-based vector allocation of small vectors.
135 * lisp.h (struct vectorlike_header): New field `nbytes',
136 adjust comment accordingly.
137 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
138 to denote vector blocks. Adjust users (live_vector_p,
139 mark_maybe_pointer, valid_lisp_object_p) accordingly.
140 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
141 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
142 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
143 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
144 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
145 (roundup_size): New constant.
146 (struct vector_block): New data type.
147 (vector_blocks, vector_free_lists, zero_vector): New variables.
148 (all_vectors): Rename to `large_vectors'.
149 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
150 (sweep_vectors): New functions.
151 (allocate_vectorlike): Return `zero_vector' as the only vector of
152 0 items. Allocate new vector from block if vector size is less than
153 or equal to VBLOCK_BYTES_MAX.
154 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
155 (init_alloc_once): Add call to init_vectors.
157 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
159 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
161 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
163 * doprnt.c (doprnt): Truncate multibyte char correctly.
164 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
165 would mishandle a string argument "Xc" if X was a multibyte
166 character of length 2: it would truncate after X's first byte
167 rather than including all of X.
169 2012-06-06 Chong Yidong <cyd@gnu.org>
171 * buffer.c (word_wrap): Doc fix.
173 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
175 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
177 2012-06-03 Glenn Morris <rgm@gnu.org>
179 * xdisp.c (tool-bar-style): Doc fix.
181 2012-06-03 Ulrich Müller <ulm@gentoo.org>
183 * Makefile.in (PAXCTL): Define.
184 (temacs$(EXEEXT)): Disable memory randomization for the temacs
185 binary via PaX flags if the paxctl utility is available.
186 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
187 Restore PaX flags to their default. (Bug#11398)
189 2012-06-03 Chong Yidong <cyd@gnu.org>
191 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
194 2012-06-03 Chong Yidong <cyd@gnu.org>
196 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
197 (note_mode_line_or_margin_highlight): If there is no help echo,
198 use mode-line-default-help-echo. Handle the case where the mouse
199 position is past the end of the mode line string.
201 * buffer.c (buffer_local_value_1): New function, split from
202 Fbuffer_local_value; can return Qunbound.
203 (Fbuffer_local_value): Use it.
204 (Vmode_line_format): Docstring tweaks.
206 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
208 * sysdep.c (system_process_attributes): Improve comment.
210 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
212 * keyboard.c: Export real-this-command to Elisp.
213 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
214 and DEFVAR it. Update all users.
216 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
218 * minibuf.c (Fassoc_string): Remove duplicate declaration.
220 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
221 Convert pctcpu and pctmem to Lisp float properly.
222 Let the compiler fold better, as 100.0/0x8000 is exact.
224 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
226 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
229 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
231 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
233 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
235 For a 'struct window', replace some Lisp_Object fields to
236 bitfields where appropriate, remove unused fields.
237 * window.h (struct window): Remove unused 'last_mark_x' and
238 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
239 change it's type from Lisp_Object to bitfield.
240 Change type of 'force_start', 'optional_new_start',
241 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
242 fields from Lisp_Object to bitfield. Adjust users accordingly.
244 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
246 Pacify gcc -Wdouble-precision when using Xaw.
247 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
248 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
249 Use 'float' consistently, rather than 'float' in most places
250 and 'double' in a couple of places.
252 2012-05-31 Eli Zaretskii <eliz@gnu.org>
254 * xdisp.c (handle_stop): Detect whether we have overlay strings
255 loaded by testing it->current.overlay_string_index to be
256 non-negative, instead of checking whether n_overlay_strings is
257 positive. (Bug#11587)
259 2012-05-31 Chong Yidong <cyd@gnu.org>
261 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
263 * doc.c (Fsubstitute_command_keys): Doc fix.
265 2012-05-31 Eli Zaretskii <eliz@gnu.org>
267 * search.c (search_buffer): Remove calls to
268 r_alloc_inhibit_buffer_relocation, as it is now called by
269 maybe_unify_char, which was the cause of relocation of buffer text
272 2012-05-31 Eli Zaretskii <eliz@gnu.org>
274 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
275 for the duration of call to load_charset, to avoid problems with
276 callers of maybe_unify_char that access buffer text through C
279 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
280 decrement the inhibition flag, instead of just setting or
283 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
285 Remove obsolete '#define static' cruft.
286 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
287 This #undef was "temporary" in 2000; it is no longer needed
288 now that '#define static' has gone away.
289 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
290 (gray_bitmap_bits): Remove; no longer needed.
291 All uses replaced with definiens.
292 * xterm.c: Include "bitmaps/gray.xbm".
294 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
296 Clean up __executable_start, monstartup when --enable-profiling.
297 The following changes affect the code only when profiling.
298 * dispnew.c (__executable_start): Rename from safe_bcopy.
299 Define only on platforms that need it.
300 * emacs.c: Include <sys/gmon.h> when profiling.
301 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
302 (__executable_start): Remove decl, since lisp.h does it now.
303 (safe_bcopy): Remove decl; no longer has that name.
304 (main): Coalesce #if into single bit of code, for simplicity.
305 Cast pointers to uintptr_t, since standard libraries want integers
307 * lisp.h (__executable_start): New decl.
309 2012-05-31 Glenn Morris <rgm@gnu.org>
311 * image.c (Fimagemagick_types): Doc fix.
313 2012-05-30 Jim Meyering <meyering@redhat.com>
315 * callproc.c (Fcall_process_region): Include directory component
316 in mkstemp error message (Bug#11586).
318 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
320 * alloc.c, lisp.h (make_pure_vector): Now static.
322 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
324 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
326 (Fautoload): Do the hash-doc more carefully.
327 * data.c (Fdefalias): Purify definition, except for keymaps.
328 (Qdefun): Move from eval.c.
329 * lisp.h (Qdefun): Remove.
330 * lread.c (read1): Tiny simplification.
332 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
334 Do not create empty overlays with the evaporate property (Bug#9642).
335 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
336 Bug#9642, but explicitly check that the buffer the overlay would
337 be moved to is live and rearrange lines to make sure that errors
338 will not put the overlay in an inconsistent state.
339 (Fdelete_overlay): Cosmetics.
341 2012-05-28 Eli Zaretskii <eliz@gnu.org>
343 * w32term.c (my_bring_window_to_top): New function.
344 (x_raise_frame): Use handle returned by DeferWindowPos, which
345 could be different from the original one.
346 Call my_bring_window_to_top instead of my_set_foreground_window.
349 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
350 by calling BringWindowToTop.
352 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
353 (WM_EMACS_END): Increase by one.
355 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
357 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
358 This avoids undefined behavior that might cause the eassert
359 to not catch an out-of-range value.
361 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
363 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
366 2012-05-27 Eli Zaretskii <eliz@gnu.org>
368 * bidi.c (bidi_mirror_char): Fix last change.
370 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
372 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
373 when referring to sectname field in printf format.
375 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
377 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
378 Only r_alloc_inhibit_buffer_relocation needed to be added;
379 the others were already declared.
381 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
382 before checking whether it's out of range. Put the check inside
384 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
386 2012-05-27 Ken Brown <kbrown@cornell.edu>
388 * callproc.c (Fcall_process): Restore a line that was accidentally
389 commented out in the 2011-02-13 change (bug#11547).
391 2012-05-27 Eli Zaretskii <eliz@gnu.org>
393 * lisp.h [REL_ALLOC]: Add prototypes for external functions
396 * buffer.c [REL_ALLOC]: Remove prototypes of
397 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
398 they are now on lisp.h.
400 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
402 * search.c (search_buffer): Use it to inhibit relocation of buffer
403 text while re_search_2 is doing its job, because re_search_2 is
404 passed C pointers to buffer text. (Bug#11519)
406 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
409 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
410 state after an additional call to move_it_in_display_line_to, keep
411 the values of it->max_ascent and it->max_descent found for the
413 (pos_visible_p): Revert the comparison against bottom_y to what it
414 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
417 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
419 Fix coding-related core dumps with gcc -ftrapv.
420 The code was computing A - B, where A and B are pointers, and B is
421 random garbage. This can lead to core dumps on platforms that
422 have special pointer registers, and it also leads to core dumps on
423 x86-64 when compiled with gcc -ftrapv. The fix is to compute
424 A - B only when B is initialized properly.
425 * coding.c (coding_set_source, coding_set_destination): Return void.
426 (coding_change_source, coding_change_destinations): New functions,
427 with the old behaviors of coding_set_source and coding_set_destination.
428 All callers that need an offset changed to use these new functions.
430 2012-05-26 Glenn Morris <rgm@gnu.org>
432 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
434 2012-05-26 Eli Zaretskii <eliz@gnu.org>
436 Extend mouse support on W32 text-mode console.
437 * xdisp.c (draw_row_with_mouse_face):
438 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
440 * w32console.c: Include window.h.
441 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
443 (initialize_w32_display): Initialize mouse-highlight data.
445 * w32inevt.c: Include termchar.h and window.h.
446 (do_mouse_event): Support mouse-autoselect-window. When the mouse
447 moves, call note_mouse_highlight. If help_echo changed, call
448 gen_help_event to produce help-echo message in the echo area.
449 Call clear_mouse_face if mouse_face_hidden is set in the mouse
452 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
454 * lread.c (read1): Simplify slightly to avoid an overflow warning
455 with GCC 4.7.0 on x86-64.
457 2012-05-26 Eli Zaretskii <eliz@gnu.org>
459 * bidi.c (bidi_mirror_char): Revert last change: an int is
460 definitely wide enough here.
462 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
464 Fix integer width and related bugs (Bug#9874).
465 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
466 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
467 (string_bytes, check_sblock, allocate_string_data):
468 (compact_small_strings, Fmake_bool_vector, make_string)
469 (make_unibyte_string, make_multibyte_string)
470 (make_string_from_bytes, make_specified_string)
471 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
472 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
475 (allocate_pseudovector):
476 Use int, not EMACS_INT, where int is wide enough.
477 (inhibit_garbage_collection, Fgarbage_collect):
478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
479 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
480 int might not be wide enough.
481 (bidi_cache_search, bidi_cache_find, bidi_init_it)
482 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
483 (bidi_at_paragraph_end, bidi_find_paragraph_start)
484 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
485 (bidi_level_of_next_char, bidi_move_to_visually_next):
486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
487 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
488 (Fkill_buffer, Fset_buffer_major_mode)
489 (advance_to_char_boundary, Fbuffer_swap_text)
490 (Fset_buffer_multibyte, overlays_at, overlays_in)
491 (overlay_touches_p, struct sortvec, record_overlay_string)
492 (overlay_strings, recenter_overlay_lists)
493 (adjust_overlays_for_insert, adjust_overlays_for_delete)
494 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
495 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
496 (Foverlay_recenter, last_overlay_modification_hooks_used)
497 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
498 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
499 (validate_region): Omit unnecessary test for b <= e,
500 since that's guaranteed by the previous test.
501 (adjust_overlays_for_delete): Avoid pos + length overflow.
502 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
503 (report_overlay_modification):
504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
505 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
506 Omit pointer cast, which isn't needed anyway, and doesn't work
507 after the EMACS_INT -> ptrdiff_t change.
508 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
509 * buffer.h: Adjust decls to match defn changes elsewhere.
510 (struct buffer_text, struct buffer):
511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
512 Use EMACS_INT, not int, where int might not be wide enough.
513 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
514 not int, to avoid needless 32-bit limit on 64-bit hosts.
515 (exec_byte_code): Use tighter memory-full test, one that checks
516 for alloca overflow. Don't compute the address of the object just
517 before an array, as that's not portable. Use EMACS_INT, not
518 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
519 * callint.c (Fcall_interactively):
520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
521 * callproc.c (call_process_kill, Fcall_process):
522 Don't assume pid_t fits into an Emacs fixnum.
523 (call_process_cleanup, Fcall_process, child_setup):
524 Don't assume pid_t fits into int.
525 (call_process_cleanup, Fcall_process, delete_temp_file)
526 (Fcall_process_region):
527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
528 (Fcall_process): Simplify handling of volatile integers.
529 Use int, not EMACS_INT, where int will do.
530 * casefiddle.c (casify_object, casify_region, operate_on_word)
531 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 (casify_object): Avoid integer overflow when overallocating buffer.
534 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
535 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
536 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
537 * category.h (CATEGORYP): Don't assume arg is nonnegative.
538 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
539 integers are now checked earlier. All uses replaced with XINT.
541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
542 For CCL_MapSingle, check that content and value are in int range.
543 (ccl_driver, Fregister_code_conversion_map):
544 Check that Vcode_version_map_vector is a vector.
545 (resolve_symbol_ccl_program): Check that vector header is in range.
546 Always copy the vector, so that we can check its contents reliably
547 now rather than having to recheck each instruction as it's being
548 executed. Check that vector words fit in 'int'.
549 (ccl_get_compiled_code, Fregister_ccl_program)
550 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
551 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
552 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
553 contents are in range.
554 (Fccl_execute_on_string): Check that status is in range.
555 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
556 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
557 Accept and return EMACS_INT, not int, because callers can pass values
559 (c_string_width, strwidth, lisp_string_width, chars_in_text)
560 (multibyte_chars_in_text, parse_str_as_multibyte)
561 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
562 (str_as_unibyte, str_to_unibyte, string_count_byte8)
563 (string_escape_byte8, Fget_byte):
564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
565 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
566 avoid mishandling large integers.
567 * character.h: Adjust decls to match defn changes elsewhere.
568 * charset.c (load_charset_map_from_file, find_charsets_in_text)
569 (Ffind_charset_region):
570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
571 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
572 (load_charset_map_from_vector, Fdefine_charset_internal):
573 Don't assume fixnum fits in int.
574 (load_charset_map_from_vector, Fmap_charset_chars):
575 Remove now-unnecessary CHECK_NATNUMs.
576 (Fdefine_charset_internal): Check ranges here, more carefully.
577 Don't rely on undefined behavior with signed left shift overflow.
578 Don't assume unsigned int fits into fixnum, or that fixnum fits
579 into unsigned int. Don't require max_code to be a valid fixnum;
580 that's not true for gb10830 4-byte on a 32-bit host. Allow
581 invalid_code to be a cons, for the same reason. Require code_offset
582 to be a character. Avoid int overflow if max_char is close
584 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
585 this is intended anyway and avoids some undefined behavior.
586 (load_charset_map): Pass unsigned, not int, as 2nd arg of
587 INDEX_TO_CODE_POINT, as that's what it expects.
588 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
589 * charset.h (DECODE_CHAR): Return int, not unsigned;
590 this is what was intended anyway, and it avoids undefined behavior.
591 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
592 integer-overflow issues.
593 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
594 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
595 where the argument is EMACS_INT, and this behavior is not intended.
596 * chartab.c (Fmake_char_table, Fset_char_table_range)
597 (uniprop_get_decoder, uniprop_get_encoder):
598 Don't assume fixnum fits in int.
599 * cmds.c (move_point): New function, that does the gist of
600 Fforward_char and Fbackward_char, but does so while checking
601 for integer overflow more accurately.
602 (Fforward_char, Fbackward_char): Use it.
603 (Fforward_line, Fend_of_line, internal_self_insert)
604 (internal_self_insert):
605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
606 Fix a FIXME, by checking for integer overflow when calculating
607 target_clm and actual_clm.
608 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
609 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
610 (ASSURE_DESTINATION, coding_alloc_by_realloc)
611 (coding_alloc_by_making_gap, alloc_destination)
612 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
613 (encode_coding_utf_16, detect_coding_emacs_mule)
614 (decode_coding_emacs_mule, encode_coding_emacs_mule)
615 (detect_coding_iso_2022, decode_coding_iso_2022)
616 (encode_invocation_designation, encode_designation_at_bol)
617 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
618 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
619 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
620 (encode_coding_ccl, encode_coding_raw_text)
621 (detect_coding_charset, decode_coding_charset)
622 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
623 (produce_composition, produce_charset, produce_annotation)
624 (decode_coding, handle_composition_annotation)
625 (handle_charset_annotation, consume_chars, decode_coding_gap)
626 (decode_coding_object, encode_coding_object, detect_coding_system)
627 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
628 (code_convert_region, code_convert_string)
629 (Fdefine_coding_system_internal)
630 (coding_set_source, coding_set_destination):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
633 (Fdefine_coding_system_internal):
634 Don't assume fixnums fit in int.
635 (decode_coding_gap, decode_coding_object, encode_coding_object)
636 (Fread_coding_system, Fdetect_coding_region)
637 (Funencodable_char_position, Fcheck_coding_systems_region)
638 (get_translation, handle_composition_annotation, consume_chars):
639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
640 (consume_chars): Rewrite to not calculate an address outside buffer.
641 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
642 Don't access memory outside of the args array.
643 (Fdefine_coding_system_internal): Check for charset-id overflow.
644 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
645 result of ENCODE_CHAR.
646 * coding.h: Adjust decls to match defn changes elsewhere.
647 (struct coding_system):
648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
649 * composite.c (get_composition_id, find_composition)
650 (run_composition_function, update_compositions)
651 (compose_text, composition_gstring_put_cache)
652 (composition_gstring_p, composition_gstring_width)
653 (fill_gstring_header, fill_gstring_body, autocmp_chars)
654 (composition_compute_stop_pos, composition_reseat_it)
655 (composition_update_it, struct position_record)
656 (find_automatic_composition, composition_adjust_point)
657 (Fcomposition_get_gstring, Ffind_composition_internal):
658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
659 (update_compositions):
660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
661 * composite.h: Adjust decls to match defn changes elsewhere.
662 (struct composition):
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
665 Do not attempt to compute the address of the object just before a
666 buffer; this is not portable.
668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
669 (Faset): Use int, not EMACS_INT, where int is wide enough.
670 (Fstring_to_number): Don't assume fixnums fit in int.
671 (Frem): Don't assume arg is nonnegative.
672 * dbusbind.c (xd_append_arg): Check for integers out of range.
673 (Fdbus_call_method): Don't overflow the timeout int.
674 (extract_signed, extract_unsigned): New functions.
675 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
676 (xd_get_connection_references): Return ptrdiff_t, not int.
678 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
680 Use int, not unsigned, where the dbus API uses int.
681 (Fdbus_message_internal): Don't overflow mtype.
682 (syms_of_dbusbind): Allocate right-sized buffer for integers.
683 * dired.c (directory_files_internal, file_name_completion, scmp)
684 (file_name_completion_stat):
685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
686 (file_name_completion): Don't overflow matchcount.
687 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
688 * dispextern.h: Adjust decls to match defn changes elsewhere.
689 (struct text_pos, struct glyph, struct bidi_saved_info)
690 (struct bidi_string_data, struct bidi_it, struct composition_it)
692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
693 (struct display_pos, struct composition_it, struct it):
694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
695 * dispnew.c (increment_matrix_positions)
696 (increment_row_positions, mode_line_string)
697 (marginal_area_string):
698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
699 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
701 (duration_to_sec_usec): New function, to check for overflow better.
702 (Fsleep_for, sit_for): Use it.
703 * doc.c (get_doc_string, store_function_docstring):
704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
705 (get_doc_string, Fsnarf_documentation):
706 Use int, not EMACS_INT, where int is wide enough.
708 Use SAFE_ALLOCA, not alloca.
709 Check for overflow when converting EMACS_INT to off_t.
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
713 Don't assume uid_t fits into fixnum.
714 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
715 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
716 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
717 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
718 (general_insert_function)
719 (Finsert_char, make_buffer_string, make_buffer_string_both)
720 (update_buffer_properties, Fbuffer_substring)
721 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
722 (Fsubst_char_in_region, check_translation)
723 (Ftranslate_region_internal, save_restriction_restore, Fformat)
724 (transpose_markers, Ftranspose_regions):
725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
726 (clip_to_bounds): Move to lisp.h as an inline function).
727 (Fconstrain_to_field): Don't assume integers are nonnegative.
728 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
729 (Fsubst_char_in_region, Fsave_restriction):
730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
731 (Femacs_pid): Don't assume pid_t fits into fixnum.
732 (lo_time): Use int, not EMACS_INT, when int suffices.
733 (lisp_time_argument): Check for usec out of range.
734 (Fencode_time): Don't assume fixnum fits in int.
735 (Fuser_login_name, Fuser_full_name): Signal an error
736 if a uid argument is out of range, rather than relying on
738 (Fformat_time_string): Remove now-unnecessary check.
739 lisp_time_argument checks for out-of-range usec now.
740 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
741 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
742 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
743 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
744 (init_cmdargs, Fdump_emacs):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
747 the bottom (typically) 32 bits of the fixnum.
748 * eval.c (specpdl_size, call_debugger):
749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
750 (when_entered_debugger, Fbacktrace_debug):
751 Don't assume fixnum can fit in int.
752 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
753 the object just before a buffer; this is not portable.
754 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
755 (grow_specpdl, unbind_to):
756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
757 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
758 (grow_specpdl): Simplify allocation by using xpalloc.
759 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
760 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
761 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
763 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
766 (Fcopy_file, non_regular_nbytes, read_non_regular)
767 (Finsert_file_contents):
768 Use int, not EMACS_INT, where int is wide enough.
769 (READ_BUF_SIZE): Verify that it fits in int.
770 (Finsert_file_contents): Check that counts are in proper range,
771 rather than assuming fixnums fit into ptrdiff_t etc.
772 Don't assume fixnums fit into int.
773 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
774 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
775 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
776 (string_char_to_byte, string_byte_to_char)
777 (string_make_multibyte, string_to_multibyte)
778 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
779 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
780 (substring_both, Fdelete, internal_equal, Ffillarray)
781 (Fclear_string, mapcar1)
782 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
783 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
784 (larger_vector, make_hash_table, maybe_resize_hash_table)
785 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
786 (Fmaphash, secure_hash):
787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
788 (concat): Check for string index and length overflow.
789 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
792 (larger_vector): New API (vec, incr_min, size_max) replaces old
793 one (vec, new_size, init). This catches size overflow.
794 INIT was removed because it was always Qnil.
796 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
797 the upper bound on a hash table index size.
798 (make_hash_table, maybe_resize_hash_table): Use it.
799 (secure_hash): Computer start_byte and end_byte only after
800 they're known to be in ptrdiff_t range.
801 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
802 (Ffont_get_glyphs, Ffont_at):
803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
804 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
805 (Flist_fonts, Fopen_font):
806 Don't assume fixnum can fit in int.
807 (check_gstring): Don't assume index can fit in int.
808 (font_match_p): Check that fixnum is a character, not a nonnegative
809 fixnum, since the later code needs to stuff it into an int.
810 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
811 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
812 conversion overflow issues.
813 (Fopen_font): Check for integer out of range.
814 (Ffont_get_glyphs): Don't assume index can fit in int.
815 * font.h: Adjust decls to match defn changes elsewhere.
816 * fontset.c (reorder_font_vector): Redo score calculation to avoid
818 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
819 printmax_t, where ptrdiff_t is wide enough.
820 (Finternal_char_font):
821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
822 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
823 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
824 (Fset_frame_position, x_set_frame_parameters)
825 (x_set_line_spacing, x_set_border_width)
826 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
827 Check that fixnums are in proper range for system types.
828 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
830 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
831 Use SAFE_ALLOCA_LISP, not alloca.
832 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
833 intptr_t is wide enough.
834 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
835 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
836 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
837 Check for fixnum out of range.
838 * ftfont.c (ftfont_list): Don't assume index fits in int.
839 Check that fixnums are in proper range for system types.
840 (ftfont_shape_by_flt):
841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
842 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
844 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
845 Check that fixnums are in proper range for system types.
846 * gnutls.h: Adjust decls to match defn changes elsewhere.
847 * gtkutil.c (xg_dialog_run):
848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
849 (update_frame_tool_bar):
850 Check that fixnums are in proper range for system types.
851 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
852 (lookup_image): Check that fixnums are in range for system types.
853 * indent.c (last_known_column, last_known_column_point):
854 (current_column_bol_cache):
855 (skip_invisible, current_column, check_display_width):
856 (check_display_width, scan_for_column, current_column_1)
857 (Findent_to, Fcurrent_indentation, position_indentation)
858 (indented_beyond_p, Fmove_to_column, compute_motion):
859 (Fcompute_motion, Fvertical_motion):
860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
861 (last_known_column_modified): Use EMACS_INT, not int.
862 (check_display_width):
864 Check that fixnums and floats are in proper range for system types.
865 (compute_motion): Don't assume index or fixnum fits in int.
866 (compute_motion, Fcompute_motion):
867 Use int, not EMACS_INT, when it is wide enough.
868 (vmotion): Omit local var start_hpos that is always 0; that way
869 we don't need to worry about overflow in expressions involving it.
870 * indent.h: Adjust decls to match defn changes elsewhere.
872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
873 Use int, not EMACS_INT, where int is wide enough.
874 Remove unused members ovstring_chars_done and tab_offset;
876 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
877 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
878 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
879 (make_gap, copy_text, insert, insert_and_inherit)
880 (insert_before_markers, insert_before_markers_and_inherit)
881 (insert_1, count_combining_before, count_combining_after)
882 (insert_1_both, insert_from_string)
883 (insert_from_string_before_markers, insert_from_string_1)
884 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
885 (adjust_after_replace, adjust_after_insert, replace_range)
886 (replace_range_2, del_range, del_range_1, del_range_byte)
887 (del_range_both, del_range_2, modify_region)
888 (prepare_to_modify_buffer, signal_before_change)
889 (signal_after_change, Fcombine_after_change_execute):
890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
891 * intervals.c (traverse_intervals, rotate_right, rotate_left)
892 (balance_an_interval, split_interval_right, split_interval_left)
893 (find_interval, next_interval, update_interval)
894 (adjust_intervals_for_insertion, delete_node, delete_interval)
895 (interval_deletion_adjustment, adjust_intervals_for_deletion)
896 (static_offset_intervals, offset_intervals)
897 (merge_interval_right, merge_interval_left, make_new_interval)
898 (graft_intervals_into_buffer, temp_set_point_both)
899 (temp_set_point, set_point, adjust_for_invis_intang)
900 (set_point_both, move_if_not_intangible, get_property_and_range)
901 (get_local_map, copy_intervals, copy_intervals_to_string)
902 (compare_string_intervals, set_intervals_multibyte_1):
903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
904 * intervals.h: Adjust decls to match defn changes elsewhere.
906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
907 * keyboard.c (this_command_key_count, this_single_command_key_start)
908 (before_command_key_count, before_command_echo_length, echo_now)
909 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
910 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
911 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
912 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
914 (last_non_minibuf_size, last_point_position, echo_truncate)
915 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
916 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
917 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
918 (stuff_buffered_input):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (last_auto_save, command_loop_1, read_char):
921 Use EMACS_INT, not int, to avoid integer overflow.
922 (record_char): Avoid overflow in total_keys computation.
923 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
924 * keyboard.h: Adjust decls to match defn changes elsewhere.
925 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
926 (Fkey_description, Fdescribe_vector, Flookup_key):
927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
928 (click_position): New function, to check that positions are in range.
929 (Fcurrent_active_maps):
931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
932 (Faccessible_keymaps, Fkey_description):
933 (preferred_sequence_p):
934 Don't assume fixnum can fit into int.
935 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
936 Check for integer overflow in size calculations.
937 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
938 avoid mishandling large integers.
939 * lisp.h: Adjust decls to match defn changes elsewhere.
940 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
941 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
942 (struct Lisp_Marker):
943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
944 (clip_to_bounds): Now an inline function, moved here from editfns.c.
945 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
946 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
948 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
949 Assume the arg has valid form, since it always does.
950 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
951 unsigned integer system type.
952 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
953 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
956 (duration_to_sec_usec): New decl.
957 * lread.c (read_from_string_index, read_from_string_index_byte)
958 (read_from_string_limit, readchar, unreadchar, openp)
959 (read_internal_start, read1, oblookup):
960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
961 (Fload, readevalloop, Feval_buffer, Feval_region):
962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
963 (openp): Check for out-of-range argument to 'access'.
964 (read1): Use int, not EMACS_INT, where int is wide enough.
965 Don't assume fixnum fits into int.
966 Fix off-by-one error that can read outside a buffer.
967 (read_filtered_event): Use duration_to_sec_usec
968 to do proper overflow checking on durations.
969 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
971 (Fexecute_kbd_macro):
972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
973 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
974 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
975 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
976 (set_marker_both, set_marker_restricted_both, marker_position)
977 (marker_byte_position, Fbuffer_has_markers_at):
978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
979 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
980 * menu.c (ensure_menu_items): Rename from grow_menu_items.
981 It now merely ensures that the menu is large enough, without
982 necessarily growing it, as this avoids some integer overflow issues.
984 (keymap_panes, parse_single_submenu, Fx_popup_menu):
985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
986 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
987 Use SAFE_ALLOCA_LISP, not alloca.
988 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
989 to EMACS_INT. Check that fixnums are in proper range for system types.
990 * minibuf.c (minibuf_prompt_width, string_to_object)
991 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
992 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
994 (get_minibuffer, read_minibuf_unwind):
995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
996 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
997 this simplifies overflow checking. All callers changed.
998 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1001 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1002 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1003 Check that fixnums are in proper range for system types.
1004 (Fx_create_frame, Fx_show_tip):
1005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1006 * nsfont.m (ns_findfonts, nsfont_list_family):
1007 Don't assume fixnum fits in long.
1008 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1010 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1012 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1014 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1015 (PRINTDECLARE, PRINTPREPARE):
1016 (strout, print_string):
1017 (print, print_preprocess, print_check_string_charset_prop)
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1021 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1023 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1024 (printchar, strout): Use xpalloc to catch size calculation overflow.
1025 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1026 (print_error_message): Use SAFE_ALLOCA, not alloca.
1027 (print_object): Use int, not EMACS_INT, where int is wide enough.
1028 (print_depth, new_backquote_output, print_number_index):
1029 Use ptrdiff_t, not int, where int might not be wide enough.
1030 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1031 (Fset_process_window_size, Fformat_network_address)
1032 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1034 Check that fixnums are in proper range for system types.
1035 (Fsignal_process): Simplify by avoiding a goto.
1036 Check for process-ids out of pid_t range rather than relying on
1038 (process_tick, update_tick): Use EMACS_INT, not int.
1039 (Fformat_network_address, read_process_output, send_process)
1040 (Fprocess_send_region, status_notify):
1041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1042 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1043 (wait_reading_process_output, read_process_output, exec_sentinel):
1044 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1045 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1046 (Faccept_process_output): Use duration_to_sec_usec to do proper
1047 overflow checking on durations.
1048 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1049 Don't assume pid_t fits in int.
1050 * process.h (struct Lisp_Process): Members tick and update_tick
1051 are now of type EMACS_INT, not int.
1052 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1053 configured --with-wide-int.
1054 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1055 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1056 * search.c (looking_at_1, string_match_1):
1057 (fast_string_match, fast_c_string_match_ignore_case)
1058 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1059 (scan_newline, find_before_next_newline, search_command)
1060 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1061 (set_search_regs, wordify):
1064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1065 (string_match_1, search_buffer, set_search_regs):
1067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1068 (wordify): Check for overflow in size calculation.
1069 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1070 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1071 Check that fixnums are in proper range for system types.
1072 * sound.c (struct sound_device)
1073 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1075 (Fplay_sound_internal):
1076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1077 * syntax.c (struct lisp_parse_state, find_start_modiff)
1078 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1079 (Fparse_partial_sexp):
1080 Don't assume fixnums can fit in int.
1081 (struct lisp_parse_state, find_start_pos, find_start_value)
1082 (find_start_value_byte, find_start_begv)
1083 (update_syntax_table, char_quoted, dec_bytepos)
1084 (find_defun_start, prev_char_comend_first, back_comment):
1085 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1086 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1088 (Finternal_describe_syntax_value): Check that match_lisp is a
1089 character, not an integer, since the code stuffs it into int.
1090 (scan_words, scan_sexps_forward):
1091 Check that fixnums are in proper range for system types.
1093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1094 (scan_sexps_forward):
1095 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1096 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1097 * syntax.h: Adjust decls to match defn changes elsewhere.
1098 (struct gl_state_s):
1099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1100 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1101 MOST_POSITIVE_FIXNUM.
1102 * sysdep.c (wait_for_termination_1, wait_for_termination)
1103 (interruptible_wait_for_termination, mkdir):
1104 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1105 (emacs_read, emacs_write):
1106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1107 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1108 and double all fit in int.
1109 * term.c (set_tty_color_mode):
1110 Check that fixnums are in proper range for system types.
1111 * termhooks.h (struct input_event):
1112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1113 * textprop.c (validate_interval_range, interval_of)
1114 (Fadd_text_properties, set_text_properties_1)
1115 (Fremove_text_properties, Fremove_list_of_text_properties)
1116 (Ftext_property_any, Ftext_property_not_all)
1117 (copy_text_properties, text_property_list, extend_property_ranges)
1118 (verify_interval_modification):
1119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1120 (Fnext_single_char_property_change)
1121 (Fprevious_single_char_property_change):
1122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1123 (copy_text_properties):
1124 Check for integer overflow in index calculation.
1125 * undo.c (last_boundary_position, record_point, record_insert)
1126 (record_delete, record_marker_adjustment, record_change)
1127 (record_property_change):
1128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1129 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1131 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1132 (Fx_hide_tip, Fx_file_dialog):
1133 * w32menu.c (set_frame_menubar):
1134 Use ptrdiff_t, not int, for consistency with rest of code.
1135 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1136 (select_window, Fdelete_other_windows_internal)
1137 (window_scroll_pixel_based, window_scroll_line_based)
1138 (Frecenter, Fset_window_configuration):
1139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1140 (Fset_window_hscroll, run_window_configuration_change_hook)
1141 (set_window_buffer, temp_output_buffer_show, scroll_command)
1142 (Fscroll_other_window, Frecenter):
1143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1144 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1145 Don't assume fixnum fits in int.
1146 (Fset_window_scroll_bars):
1147 Check that fixnums are in proper range for system types.
1148 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1149 (string_pos, c_string_pos, number_of_chars, init_iterator)
1150 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1151 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1152 (compute_display_string_end, handle_face_prop)
1153 (face_before_or_after_it_pos, handle_invisible_prop)
1154 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1155 (display_prop_intangible_p, string_buffer_position_lim)
1156 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1157 (get_overlay_strings_1, get_overlay_strings)
1158 (iterate_out_of_display_property, forward_to_next_line_start)
1159 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1160 (get_next_display_element, set_iterator_to_next)
1161 (get_visually_first_element, compute_stop_pos_backwards)
1162 (handle_stop_backwards, next_element_from_buffer)
1163 (move_it_in_display_line_to, move_it_in_display_line)
1164 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1165 (add_to_log, message_dolog, message_log_check_duplicate)
1166 (message2, message2_nolog, message3, message3_nolog
1167 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1168 (current_message_1, truncate_echo_area, truncate_message_1)
1169 (set_message, set_message_1, store_mode_line_noprop)
1170 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1171 (text_outside_line_unchanged_p, check_point_in_composition)
1172 (reconsider_clip_changes)
1173 (redisplay_internal, set_cursor_from_row, try_scrolling)
1174 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1175 (redisplay_window, find_last_unchanged_at_beg_row)
1176 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1177 (trailing_whitespace_p, find_row_edges, display_line)
1178 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1179 (display_mode_element, store_mode_line_string)
1180 (pint2str, pint2hrstr, decode_mode_spec)
1181 (display_count_lines, display_string, draw_glyphs)
1182 (x_produce_glyphs, x_insert_glyphs)
1183 (rows_from_pos_range, mouse_face_from_buffer_pos)
1184 (fast_find_string_pos, mouse_face_from_string_pos)
1185 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1187 (safe_call, init_from_display_pos, handle_fontified_prop)
1188 (handle_single_display_spec, load_overlay_strings)
1189 (with_echo_area_buffer, setup_echo_area_for_printing)
1190 (display_echo_area, echo_area_display)
1191 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1192 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1193 (redisplay_window, dump_glyph_row, display_mode_line)
1194 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1195 (handle_display_spec, display_prop_string_p):
1196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1197 (handle_single_display_spec, build_desired_tool_bar_string)
1198 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1199 (get_specified_cursor_type):
1200 Check that fixnums are in proper range for system types.
1201 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1202 (Flookup_image_map):
1203 Don't assume fixnums fit in int.
1204 (compare_overlay_entries):
1205 Avoid mishandling comparisons due to subtraction overflow.
1206 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1207 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1208 (handle_tool_bar_click):
1209 Use int, not unsigned, since we prefer signed and the signedness
1210 doesn't matter here.
1211 (get_next_display_element, next_element_from_display_vector):
1212 Use int, not EMACS_INT, when int is wide enough.
1213 (start_hourglass): Use duration_to_sec_usec to do proper
1214 overflow checking on durations.
1215 * xfaces.c (Fbitmap_spec_p):
1216 Check that fixnums are in proper range for system types.
1217 (compare_fonts_by_sort_order):
1218 Avoid mishandling comparisons due to subtraction overflow.
1219 (Fx_family_fonts, realize_basic_faces):
1220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1222 Don't assume fixnum fits in int.
1223 Use SAFE_ALLOCA_LISP, not alloca.
1224 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1225 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1226 (face_at_buffer_position, face_for_overlay_string)
1227 (face_at_string_position):
1228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1229 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1230 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1232 Check that fixnums are in proper range for system types.
1233 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1234 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1236 (Fx_change_window_property): Don't assume fixnums fit in int.
1237 * xfont.c (xfont_chars_supported):
1238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1239 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1240 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1242 * xml.c (parse_region):
1243 * xrdb.c (magic_file_p):
1244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1245 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1246 (x_get_local_selection, x_reply_selection_request)
1247 (x_handle_selection_request, wait_for_property_change):
1248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1249 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1250 short is wide enough.
1251 (x_send_client_event): Don't assume fixnum fits in int.
1252 * xterm.c (x_x_to_emacs_modifiers):
1253 Don't assume EMACS_INT overflows nicely into int.
1254 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1256 (handle_one_xevent): NATNUMP can eval its arg twice.
1257 (x_connection_closed):
1258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1259 * xterm.h: Adjust decls to match defn changes elsewhere.
1260 (struct scroll_bar): Use struct vectorlike_header
1261 rather than rolling our own approximation.
1262 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1264 2012-05-25 Glenn Morris <rgm@gnu.org>
1266 * lisp.mk (lisp): Update for more files being compiled now.
1268 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1270 * lread.c: Remove `read_pure' which makes no difference.
1271 (read_pure): Remove var.
1272 (unreadpure): Remove function.
1273 (readevalloop): Don't call read_list with -1 flag.
1274 (read1, read_vector): Don't test read_pure any more.
1275 (read_list): Simplify.
1277 * fileio.c, character.h: Minor style tweaks.
1279 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1281 * window.h (clip_changed): Remove useless declaration.
1283 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1285 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1286 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1288 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1291 This directory predates autoconf and is no longer needed nowadays.
1292 Move its few remaining bits of functionality to where they're needed.
1293 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1294 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1295 * m/template.h: Remove.
1296 * Makefile.in (M_FILE): Remove. All uses removed.
1297 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1298 * lisp.h (USE_LSB_TAG):
1299 * mem-limits.h (EXCEEDS_LISP_PTR):
1300 Use VAL_MAX, not VALBITS, in #if.
1301 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1302 (EMACS_UINT): Define unconditionally now.
1303 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1304 (BITS_PER_EMACS_INT): New constants, replacing
1305 what used to be in config.h, but not useful in #if.
1306 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1307 define them any more.
1308 (VAL_MAX): New macro.
1310 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1311 BITS_PER_EMACS_INT, in #if.
1312 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1313 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1314 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1315 * s/ms-w32.h (DATA_START):
1316 Move here from removed file m/intel386.h.
1317 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1318 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1320 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1322 Assume C89 or later.
1323 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1324 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1326 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1327 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1328 * textprop.c, tparam.c (NULL): Remove.
1329 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1330 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1331 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1332 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1333 * xterm.c (input_signal_count): Assume volatile works.
1335 2012-05-21 Ken Brown <kbrown@cornell.edu>
1337 * xgselect.c (xg_select): Fix first argument in call to 'select'
1340 2012-05-20 Ken Brown <kbrown@cornell.edu>
1342 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1343 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1345 2012-05-19 Ken Brown <kbrown@cornell.edu>
1347 * xfns.c (x_in_use): Remove `static' qualifier.
1348 * xterm.h (x_in_use): Declare.
1349 * xgselect.c: Include xterm.h.
1350 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1351 and `display_arg' (bug#9754).
1353 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1355 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1357 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1358 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1360 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1362 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1364 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1365 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1367 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1368 reference to image_cache->refcount.
1369 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1371 2012-05-17 Juri Linkov <juri@jurta.org>
1373 * search.c (Fword_search_regexp, Fword_search_backward)
1374 (Fword_search_forward, Fword_search_backward_lax)
1375 (Fword_search_forward_lax): Move functions to isearch.el
1376 (bug#10145, bug#11381).
1378 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1380 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1382 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1384 * lread.c (init_obarray): Declare Qt and Qnil as special.
1386 2012-05-14 Glenn Morris <rgm@gnu.org>
1388 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1389 Put "libexec" before "bin", for the sake of init_callproc_1.
1391 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1393 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1395 * unexaix.c: Port to more-recent AIX compilers.
1396 (report_error, report_error_1, make_hdr, copy_sym)
1397 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1398 Make arguments const char *, not char *, to avoid violations of C
1399 standard and to fix some AIX warnings reported by Gilles Pion.
1401 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1403 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1404 already have overlays loaded.
1405 (handle_single_display_spec): Before returning without displaying
1406 fringe bitmap, synchronize the bidi iterator with the main display
1407 iterator, by calling iterate_out_of_display_property.
1408 (iterate_out_of_display_property): Detect buffer iteration by
1409 testing that it->string is a Lisp string.
1410 (get_next_display_element): When the current object is exhausted,
1411 and there's something on it->stack, call set_iterator_to_next to
1412 proceed with what's on the stack, instead of returning zero.
1413 (set_iterator_to_next): If called at the end of a Lisp string,
1414 proceed to consider_string_end without incrementing string
1415 position. Don't increment display vector index past the end of
1416 the display vector. (Bug#11417)
1417 (pos_visible_p): Don't report a position visible when move_it_to
1418 stopped at the last line of window, which happens to be scanned
1419 backwards by the bidi iteration. (Bug#11464)
1421 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1423 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1424 and right-margin display specs even if the spec is invalid or we
1425 are on a TTY, and thus unable to display on the fringes.
1426 That's because the text with the property will not be displayed anyway,
1427 so we need to signal to the caller that this is a "replacing"
1428 display spec. This fixes display when the spec is invalid or we
1431 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1433 * unexaix.c (make_hdr): Fix typo in prototype.
1434 This bug broke the build on AIX. Problem reported by Gilles Pion.
1436 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1438 * keyboard.c (kbd_buffer_get_event): Read special events also in
1439 batch mode. (Bug#11415)
1441 2012-05-12 Glenn Morris <rgm@gnu.org>
1443 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1445 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1447 * lisp.mk (lisp): Add newcomment.elc.
1449 2012-05-12 Glenn Morris <rgm@gnu.org>
1451 * Makefile.in (MKDIR_P): New, set by configure.
1452 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1454 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1456 Remove unused function hourglass_started.
1457 * dispextern.h (hourglass_started):
1458 * w32fns.c (hourglass_started):
1459 * xdisp.c (hourglass_started): Remove.
1461 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1463 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1464 Update dependencies.
1466 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1468 * xgselect.c (xg_select): Put maxfds+1 into a var.
1469 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1471 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1473 2012-05-10 Dave Abrahams <dave@boostpro.com>
1475 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1476 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1478 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1480 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1481 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1482 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1483 Initialize xd_registered_buses.
1485 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1487 Untag more efficiently if USE_LSB_TAG.
1488 This is based on a proposal by YAMAMOTO Mitsuharu in
1489 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1490 For an admittedly artificial (nth 8000 longlist) benchmark on
1491 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1492 Emacs's overall text size by 1%.
1493 * lisp.h (XUNTAG): New macro.
1494 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1495 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1496 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1497 * eval.c (Fautoload):
1498 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1499 * frame.h (XFRAME): Use XUNTAG.
1501 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1502 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1503 Remove unportable assumptions about print widths of types like
1505 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1506 intptr_t when converting between pointer and integer, to avoid GCC
1507 warnings about wrong width.
1509 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1511 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1512 stack for each reader_thread, instead of defaulting to 8MB
1513 determined by the linker. This avoids failures in creating
1514 subprocesses on Windows 7, see the discussion in this thread:
1515 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1517 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1519 Fix up display of the *Minibuf-0* buffer in the mini window.
1520 * keyboard.c (read_char): Don't clear the echo area if there's no
1522 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1523 contents of *Minibuf-0*) if there's no message displayed in its stead.
1525 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1527 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1530 2012-05-06 Chong Yidong <cyd@gnu.org>
1532 * lisp.mk (lisp): Update.
1534 2012-05-05 Jim Meyering <meyering@redhat.com>
1536 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1538 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1540 * data.c (PUT_ERROR): New macro.
1541 (syms_of_data): Use it. Add new error type `user-error'.
1542 * undo.c (user_error): New function.
1543 (Fprimitive_undo): Use it.
1544 * print.c (print_error_message): Adjust print style for `user-error'.
1545 * keyboard.c (user_error): New function.
1546 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1548 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1550 Do not limit current-time-string to years 1000..9999.
1551 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1552 (Fcurrent_time_string): Support any year that is supported by the
1553 underlying localtime representation. Don't use asctime, as it
1554 has undefined behavior for years outside the range -999..9999.
1556 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1558 Fix race conditions involving setenv, gmtime, localtime, asctime.
1559 Without this fix, interrupts could mess up code that uses these
1560 nonreentrant functions, since setting TZ invalidates existing
1561 tm_zone or tzname values, and since most of these functions return
1562 pointers to static storage.
1563 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1564 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1565 Grow the critical sections to include not just invoking
1566 localtime/gmtime, but also accessing these functions' results
1567 including their tm_zone values if any, and any related TZ setting.
1568 (format_time_string): Last arg is now struct tm *, not struct tm **,
1569 so that the struct tm is saved in the critical section.
1570 All callers changed. Simplify allocation of initial buffer, partly
1571 motivated by the fact that memory allocation needs to be outside
1572 the critical section.
1574 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1576 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1577 with RESET_INTERVAL.
1579 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1580 Remove duplicated buffer name initialization.
1582 2012-05-02 Jim Meyering <jim@meyering.net>
1584 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1586 * xfns.c (x_window): Use xstrdup (Bug#11375).
1588 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1590 * xdisp.c (pos_visible_p): If already at a newline from the
1591 display string before the 'while' loop, don't walk back the glyphs
1592 from it3.glyph_row. Solves assertion violation when the display
1593 string begins with a newline (egg.el). (Bug#11367)
1595 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1597 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1600 2012-05-01 Glenn Morris <rgm@gnu.org>
1602 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1603 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1604 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1605 All were removed before 23.1.
1607 * dispnew.c: Remove HAVE_LIBNCURSES test;
1608 it is always true on relevant platforms.
1610 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1611 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1613 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1615 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1617 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1618 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1621 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1623 Do not avoid creating empty evaporating overlays (Bug#9642).
1624 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1625 That is, do not delete an evaporating overlay if it becomes
1626 empty after its bounds are adjusted to fit within its buffer.
1627 This fix caused other problems, and I'm reverting it until we get
1628 to the bottom of them.
1630 2012-04-27 Chong Yidong <cyd@gnu.org>
1632 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1634 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1636 * xdisp.c (pos_visible_p): If the window start position is beyond
1637 ZV, start the display from buffer beginning. Prevents assertion
1638 violation in init_iterator when the minibuffer window is scrolled
1641 * window.c (window_scroll_pixel_based): Likewise.
1643 2012-04-27 Chong Yidong <cyd@gnu.org>
1645 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1647 2012-04-27 Glenn Morris <rgm@gnu.org>
1649 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1650 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1652 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1654 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1655 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1657 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1659 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1660 display element, check also the underlying string or buffer
1661 character. (Bug#11341)
1663 * w32menu.c: Include w32heap.h.
1664 (add_menu_item): If the call to AppendMenuW (via
1665 unicode_append_menu) fails, disable Unicode menus only if we are
1666 running on Windows 9X/Me.
1668 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1670 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1671 (xgetint): Add missing shift for LSB tags.
1673 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1675 * keyboard.c (read_char): Don't wipe echo area for select window
1676 events: These might get delayed via `mouse-autoselect-window'
1679 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1681 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1682 manipulation of :loaded-from data.
1684 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1686 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1687 now a cons (bug#11311).
1689 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1691 Do not create empty overlays with the evaporate property (Bug#9642).
1692 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1693 if it becomes empty after its bounds are adjusted to fit within
1694 its buffer. Without this fix, in a nonempty buffer (let ((o
1695 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1696 yields an empty overlay that has the evaporate property, which is
1697 not supposed to happen.
1699 Fix minor GTK3 problems found by static checking.
1700 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1701 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1702 (struct _EmacsFixedClass, emacs_fixed_get_type):
1703 Move decls here from emacsgtkfixed.h, since they needn't be public.
1704 (emacs_fixed_get_type): Now static.
1705 (emacs_fixed_class_init): Omit unused local.
1706 (emacs_fixed_child_type): Remove; unused.
1707 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1708 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1709 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1710 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1711 (EMACS_FIXED_GET_CLASS): Remove; unused.
1712 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1714 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1715 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1717 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1719 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1720 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1721 (__malloc_size_t, __malloc_ptrdiff_t):
1722 Remove. All uses removed, replaced by the definiens if needed,
1723 since we can assume C89 or better now.
1724 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1725 (protect_malloc_state, align, get_contiguous_space)
1726 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1727 (malloc_atfork_handler_child, malloc_enable_thread)
1728 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1729 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1730 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1731 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1732 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1733 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1734 Define using prototypes, not old style.
1735 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1736 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1737 (align): Don't assume that signed integer overflow wraps around.
1738 Omit unused local var.
1739 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1740 (_free_internal_nolock, memalign, mallochook, reallochook):
1741 Omit no-longer-needed casts.
1742 (valloc): Use getpagesize, not __getpagesize.
1743 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1744 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1746 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1748 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1750 Move functions from C to Lisp. Make non-blocking method calls
1751 the default. Implement further D-Bus standard interfaces.
1753 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1754 (QCdbus_request_name_allow_replacement)
1755 (QCdbus_request_name_replace_existing)
1756 (QCdbus_request_name_do_not_queue)
1757 (QCdbus_request_name_reply_primary_owner)
1758 (QCdbus_request_name_reply_in_queue)
1759 (QCdbus_request_name_reply_exists)
1760 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1761 (QCdbus_registered_serial, QCdbus_registered_method)
1762 (QCdbus_registered_signal): New Lisp objects.
1763 (XD_DEBUG_MESSAGE): Use sizeof.
1764 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1765 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1766 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1767 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1768 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1769 (xd_signature, xd_append_arg): Allow float for integer types.
1770 (xd_get_connection_references): New function.
1771 (xd_get_connection_address): Rename from xd_initialize.
1772 Return cached address.
1773 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1774 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1776 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1777 Return number of refcounts.
1778 (Fdbus_get_unique_name): Make stronger parameter check.
1779 (Fdbus_message_internal): New defun.
1780 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1781 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1782 (Fdbus_send_signal, Fdbus_register_service)
1783 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1784 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1785 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1786 (Vdbus_compiled_version, Vdbus_runtime_version)
1787 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1788 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1789 (Vdbus_message_type_signal): New defvars.
1790 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1793 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1795 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1796 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1797 Do not assume ptrdiff_t is the same width as 'int'.
1799 * alloc.c: Handle unusual debugging option combinations.
1800 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1801 since the two debugging options are incompatible.
1802 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1804 (mem_init, mem_insert, mem_insert_fixup):
1805 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1806 (NEED_MEM_INSERT): Remove; no longer needed.
1808 2012-04-22 Leo Liu <sdl.web@gmail.com>
1810 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1812 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1814 * sysdep.c [__FreeBSD__]: Minor cleanups.
1815 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1816 Use Emacs indenting style more consistently. Avoid some casts.
1817 Use 'double' consistently rather than mixing 'float' and 'double'.
1819 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1821 * sysdep.c (list_system_processes, system_process_attributes):
1822 Add implementation for FreeBSD (Bug#5243).
1824 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1826 * lisp.mk (lisp): Update.
1828 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1830 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1831 It is never used otherwise.
1833 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1835 * print.c (print_preprocess): Only check print_depth if print-circle
1837 (print_object): Check for cycles even when print-circle is nil and
1838 print-gensym is t, but only check print_depth if print-circle is nil.
1840 2012-04-20 Chong Yidong <cyd@gnu.org>
1842 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1843 set the status to "failed" and ensure that sentinel is run.
1845 2012-04-20 Glenn Morris <rgm@gnu.org>
1847 * process.c (Fset_process_inherit_coding_system_flag)
1848 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1849 (Fmake_network_process, Fmake_serial_process): Doc fix.
1851 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1853 * xdisp.c (string_buffer_position_lim): Limit starting position to
1855 (set_cursor_from_row): If called for a mode-line or header-line
1856 row, return zero immediately.
1857 (try_cursor_movement): If inside continuation line, don't back up
1858 farther than the first row after the header line, if any.
1859 Don't consider the header-line row as "partially visible", even if
1860 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1862 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1864 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1867 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1868 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1870 configure: new option --enable-gcc-warnings (Bug#11207)
1871 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1872 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1873 (ALL_CFLAGS): Use new macros rather than old.
1874 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1875 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1876 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1877 -Wunused-result, -Wunused-variable. This should go away once
1878 the Emacs and Gnulib regex code is merged.
1879 (xmalloc, xrealloc): Now static.
1881 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1883 * dired.c (Fsystem_groups): Remove unused local.
1885 2012-04-17 Glenn Morris <rgm@gnu.org>
1887 * dired.c (Fsystem_users): Doc fix.
1889 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1891 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1892 (syms_of_dired): Add them.
1894 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1896 Fix minor alloc.c problems found by static checking.
1897 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1898 New extern decls, to avoid calling undeclared functions.
1899 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1900 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1901 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1902 (NEED_MEM_INSERT): New macro.
1903 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1904 Remove one incorrect comment and fix another.
1906 Fix minor ralloc.c problems found by static checking.
1907 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1908 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1909 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1910 (r_alloc_sbrk): Now static.
1912 Improve ralloc.c interface checking.
1913 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1914 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1915 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1916 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1917 [REL_ALLOC]: ... to here, to check interface.
1918 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1919 Remove decls. This fixes an "It stinks!".
1921 * alloc.c (which_symbols): Fix alignment issue / type clash.
1923 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1925 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1926 (struct Lisp_Misc_Any): Likewise.
1927 (struct Lisp_Free): Likewise.
1928 * alloc.c (union aligned_Lisp_Symbol): Define.
1929 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1930 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1931 (union aligned_Lisp_Misc): Define.
1932 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1933 aligned_Lisp_Misc instead of union Lisp_Misc.
1934 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1936 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1938 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1939 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1940 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1941 * s/netbsd.h, s/sol2-6.h:
1942 Remove definition of GC_MARK_STACK, since the default now works.
1943 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1944 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1945 no longer the default.
1946 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1948 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1950 * lread.c (lisp_file_lexically_bound_p):
1951 Fix hang at ";-*-\n" (bug#11238).
1953 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1955 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1956 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1958 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1960 * nsterm.m (constrainFrameRect): Always constrain when there is only
1961 one screen (Bug#10962).
1963 2012-04-13 Ken Brown <kbrown@cornell.edu>
1965 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1967 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1969 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1971 2012-04-11 Daniel Colascione <dancol@dancol.org>
1973 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1974 against is gone. It's better to use vfork now so that when Cygwin
1975 gains a new, working vfork, we use it automatically (bug#10398).
1977 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1979 * window.c (save_window_save): Obey window-point-insertion-type.
1981 2012-04-11 Glenn Morris <rgm@gnu.org>
1983 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1985 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1987 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1989 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1991 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1992 (force_quit_count): New var.
1993 (handle_interrupt): Use it.
1995 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1997 * w32.c (w32_delayed_load): Record the full path of the library
1998 being loaded (bug#10424).
2000 2012-04-09 Glenn Morris <rgm@gnu.org>
2002 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2003 not just in the obarray, before snarfing them. (Bug#11036)
2005 * Makefile.in ($(leimdir)/leim-list.el):
2006 Pass EMACS rather than BUILT_EMACS.
2008 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2010 * process.c (make_process):
2011 * process.h: Add integer `gnutls_handshakes_tried' member to
2014 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2015 Add convenience `GNUTLS_LOG2i' macro.
2017 * gnutls.c (gnutls_log_function2i): Convenience log function.
2018 (emacs_gnutls_read): Use new log functions,
2019 `gnutls_handshakes_tried' process member, and
2020 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2021 attempts per process (connection).
2023 2012-04-09 Chong Yidong <cyd@gnu.org>
2025 * eval.c (Fuser_variable_p, user_variable_p_eh)
2026 (lisp_indirect_variable): Functions deleted.
2027 (Fdefvar): Caller changed.
2029 * callint.c (Finteractive, Fcall_interactively):
2030 * minibuf.c (Fread_variable): Callers changed.
2032 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2034 * xdisp.c (set_cursor_from_row): If the display string appears in
2035 the buffer at position that is closer to point than the position
2036 after the display string, display the cursor on the first glyph of
2037 the display string. Fixes cursor display when a 'display' text
2038 property immediately follows invisible text. (Bug#11094)
2040 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2042 composite.c: use 'double' consistently
2043 * composite.c (get_composition_id): Use 'double' consistently
2044 instead of converting 'float' to 'double' and vice versa; this is
2045 easier to understand and avoids a GCC warning.
2047 2012-04-09 Glenn Morris <rgm@gnu.org>
2049 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2050 preparation for dumping it with emacs. (Bug#4789)
2051 (leimdir): New variable.
2052 ($(leimdir)/leim-list.el): New rule.
2053 (emacs$(EXEEXT)): Depend on leim-list.el.
2055 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2056 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2057 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2059 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2061 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2064 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2066 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2067 Remove unused local variable.
2069 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2071 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2072 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2073 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2074 objects, as mark_maybe_pointer will catch them otherwise.
2075 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2076 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2078 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2080 Fix typo that broke non-Windows builds.
2081 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2083 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2085 Support building on MS-Windows with libxml2.
2087 * makefile.w32-in (OBJ2): Add xml.$(O).
2088 (GLOBAL_SOURCES): Add xml.c.
2089 ($(BLD)/xml.$(O)): New dependency list.
2091 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2092 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2093 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2094 [!WINDOWSNT]: New macros.
2095 (init_libxml2_functions, libxml2_loaded_p): New functions.
2096 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2097 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2098 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2099 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2101 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2102 Call init_libxml2_functions before calling libxml2 functions.
2103 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2105 * emacs.c: Don't include libxml/parser.h.
2106 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2107 xmlCleanupParser directly.
2109 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2111 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2113 * indent.c (Fvertical_motion): If there is a display string at
2114 point, use it.vpos to compute how many lines to backtrack after
2115 move_it_to point. (Bug#11133)
2117 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2119 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2120 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2121 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2122 macros related to unification of CJK characters. For the details,
2123 see the discussion following the message here:
2124 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2126 2012-04-04 Chong Yidong <cyd@gnu.org>
2128 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2130 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2132 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2133 instead of alloca. (Bug#11138)
2135 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2137 * w32menu.c (is_simple_dialog): Properly check lisp types.
2140 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2142 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2143 position we get to after a call to move_it_to fails the
2144 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2145 only if we wind up in a string from display property. (Bug#11063)
2147 * window.c (Fdelete_other_windows_internal): Invalidate the row
2148 and column information about mouse highlight, so that redisplay
2149 restores it after reallocating the glyph matrices. (Bug#7464)
2151 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2152 string comes from a `display' text property, use the buffer
2153 position of that property as if we actually saw that position in
2155 (move_it_by_lines): Remove the assertion that
2156 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2157 violated when there's a before-string at the beginning of a line.
2160 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2162 * xdisp.c (append_space_for_newline): If the default face was
2163 remapped, use the remapped face for the appended newline.
2164 (extend_face_to_end_of_line): Use the remapped default face for
2165 extending the face to the end of the line.
2166 (display_line): Call extend_face_to_end_of_line when the default
2167 face was remapped. (Bug#11068)
2169 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2171 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2173 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2175 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2177 2012-03-27 Glenn Morris <rgm@gnu.org>
2179 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2182 2012-03-26 Kenichi Handa <handa@m17n.org>
2184 * dispextern.h (struct glyph): Fix previous change. Change the
2185 bit length of glyphless.ch to 25 (Bug#11082).
2187 2012-03-26 Chong Yidong <cyd@gnu.org>
2189 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2190 (command_loop_1): Use it; inhibit selection update for
2191 handle-select-window too (Bug#8996).
2193 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2195 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2197 2012-03-25 Kenichi Handa <handa@m17n.org>
2199 * dispextern.h (struct glyph): Change the bit length of
2200 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2202 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2204 * s/ms-w32.h (tzname): Include time.h before redirecting to
2205 _tzname. Fixes the MSVC build. (Bug#9960)
2207 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2209 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2212 * xterm.c (XTread_socket): Only modify handling_signal if
2213 !SYNC_INPUT. (Bug#11080)
2215 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2217 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2218 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2219 when fetching a multibyte character consumes more bytes than
2220 CHAR_BYTES returns, due to unification of CJK characters in
2221 string_char. (Bug#11073)
2223 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2225 * process.c (wait_reading_process_output): Handle pty disconnect
2226 by refraining from sending oneself a SIGCHLD (bug#10933).
2228 2012-03-22 Chong Yidong <cyd@gnu.org>
2230 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2232 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2233 Mark string as coming from a prefix property.
2234 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2235 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2237 2012-03-21 Chong Yidong <cyd@gnu.org>
2239 * xfaces.c (Vface_remapping_alist): Doc fix.
2241 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2243 * w32proc.c (Fw32_set_console_codepage)
2244 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2247 2012-03-20 Chong Yidong <cyd@gnu.org>
2249 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2250 to reflect default non-nil value of redisplay-dont-pause.
2252 2012-03-19 Kenichi Handa <handa@m17n.org>
2254 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2255 it fit in a valid range (Bug#11003).
2257 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2259 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2260 that is not from display property, accept the row as a "cursor
2261 row" if one of the string's character has a non-nil `cursor'
2262 property. Fixes cursor positioning when there are newlines in
2263 overlay strings, e.g. in icomplete.el. (Bug#11035)
2265 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2267 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2269 2012-03-12 Chong Yidong <cyd@gnu.org>
2271 * eval.c (inhibit_lisp_code): Rename from
2272 inhibit_window_configuration_change_hook; move from window.c.
2274 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2275 * window.c (run_window_configuration_change_hook)
2276 (syms_of_window): Callers changed.
2278 2012-03-11 Chong Yidong <cyd@gnu.org>
2280 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2282 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2284 2012-03-10 Chong Yidong <cyd@gnu.org>
2286 * frame.c (other_visible_frames): Don't assume the selected frame
2287 is visible (Bug#10955).
2289 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2291 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2293 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2295 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2296 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2299 2012-03-03 Glenn Morris <rgm@gnu.org>
2301 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2303 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2305 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2306 position past the first glyph_row that ends at ZV. (Bug#10902)
2307 (redisplay_window, next_element_from_string): Fix typos in
2309 (redisplay_window): Pass to move_it_vertically the margin in
2310 pixels, not in screen lines.
2312 2012-03-02 Glenn Morris <rgm@gnu.org>
2314 * buffer.c (buffer-list-update-hook): Doc fix.
2316 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2318 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2319 push_it before setting up the iterator for the first overlay
2320 string, even if we have an empty string loaded.
2321 (next_overlay_string): If there's an empty string on the iterator
2322 stack, pop the stack. (Bug#10903)
2324 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2326 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2327 Suggested by Stefan Monnier in
2328 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2329 * alloc.c (widen_to_Lisp_Object): New static function.
2330 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2331 and widening them to Lisp_Objects. This would work even if
2332 USE_LSB_TAG is defined and wide integers are used, which might
2333 happen in a future version of Emacs.
2335 2012-02-25 Chong Yidong <cyd@gnu.org>
2337 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2340 * xselect.c (Fx_selection_exists_p): Doc fix.
2341 (x_clipboard_manager_save_all): Print an informative message
2342 before saving to clipboard manager.
2344 2012-02-24 Chong Yidong <cyd@gnu.org>
2346 * keyboard.c (process_special_events): Handle all X selection
2347 requests in kbd_buffer, not just the next one (Bug#8869).
2349 2012-02-23 Chong Yidong <cyd@gnu.org>
2351 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2352 call when setting menu-bar-lines and tool-bar-lines parameters.
2353 (unwind_create_frame_1): New helper function.
2355 * window.c (inhibit_window_configuration_change_hook): New var.
2356 (run_window_configuration_change_hook): Obey it.
2357 (syms_of_window): Initialize it.
2359 2012-02-22 Chong Yidong <cyd@gnu.org>
2361 * xterm.c (x_draw_image_relief): Add missing type check for
2362 Vtool_bar_button_margin (Bug#10743).
2364 2012-02-21 Chong Yidong <cyd@gnu.org>
2366 * fileio.c (Vfile_name_handler_alist): Doc fix.
2368 * buffer.c (Fget_file_buffer): Protect against invalid file
2369 handler return value.
2371 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2373 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2374 when computing $valmask.
2376 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2377 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2378 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2379 It's useless in that case, and it can cause problems on hosts
2380 that allocate halves of EMACS_INT values separately.
2381 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2382 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2383 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2384 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2385 it avoids undefined behavior on hosts where shifting right by more
2386 than the word width has undefined behavior.
2388 2012-02-19 Chong Yidong <cyd@gnu.org>
2390 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2391 (Funhandled_file_name_directory, Ffile_name_as_directory)
2392 (Fdirectory_file_name, Fexpand_file_name)
2393 (Fsubstitute_in_file_name): Protect against invalid file handler
2394 return values (Bug#10845).
2396 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2398 * .gdbinit (pitx): Fix incorrect references to fields of the
2401 2012-02-17 Chong Yidong <cyd@gnu.org>
2403 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2405 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2407 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2408 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2410 2012-02-15 Chong Yidong <cyd@gnu.org>
2412 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2413 marked as special. Also, starting docstrings with * is obsolete.
2415 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2417 * gnutls.c (emacs_gnutls_write): Fix last change.
2419 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2421 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2424 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2426 * keymap.c (Fsingle_key_description): Handle char ranges.
2428 2012-02-12 Chong Yidong <cyd@gnu.org>
2430 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2431 as that creates a dangerous corner case.
2433 * window.c (Fdelete_window_internal): Invalidate the mouse
2434 highlight (Bug#9904).
2436 2012-02-12 Glenn Morris <rgm@gnu.org>
2438 * xselect.c (Fx_own_selection_internal)
2439 (Fx_get_selection_internal, Fx_disown_selection_internal)
2440 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2441 * nsselect.m (Fx_own_selection_internal)
2442 (Fx_disown_selection_internal, Fx_selection_exists_p)
2443 (Fx_selection_owner_p, Fx_get_selection_internal):
2444 Sync docs and argument specs with the xselect.c versions.
2446 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2448 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2450 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2452 * w32select.c (Fx_selection_exists_p): Sync doc string and
2453 argument list with xselect.c. (Bug#10783)
2455 * w16select.c (Fx_selection_exists_p): Sync doc string and
2456 argument list with xselect.c. (Bug#10783)
2458 2012-02-10 Glenn Morris <rgm@gnu.org>
2460 * fns.c (Fsecure_hash): Doc fix.
2462 2012-02-09 Kenichi Handa <handa@m17n.org>
2464 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2466 2012-02-07 Chong Yidong <cyd@gnu.org>
2468 * buffer.c (Fbuffer_local_variables)
2469 (buffer_lisp_local_variables): Handle unbound vars correctly;
2470 don't let Qunbound leak into Lisp.
2472 2012-02-07 Glenn Morris <rgm@gnu.org>
2474 * image.c (Fimagemagick_types): Doc fix.
2476 * image.c (imagemagick-render-type): Change it from a lisp object
2477 to an integer. Move the doc here from the lisp manual.
2478 Treat all values not equal to 0 the same.
2480 2012-02-06 Chong Yidong <cyd@gnu.org>
2482 * doc.c (store_function_docstring): Avoid applying docstring of
2483 alias to base function (Bug#2603).
2485 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2487 * .gdbinit (pp1, pv1): Remove redundant defines.
2490 2012-02-04 Chong Yidong <cyd@gnu.org>
2492 * nsterm.m: Declare a global (Bug#10694).
2494 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2496 * w32.c (get_emacs_configuration_options):
2497 Include --enable-checking, if specified, in the return value.
2499 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2501 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2502 after rounding frame sizes. (Bug#9723)
2504 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2506 * keyboard.c (adjust_point_for_property): Don't position point
2507 before BEGV. (Bug#10696)
2509 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2511 Handle overflow when computing char display width (Bug#9496).
2512 * character.c (char_width): Return EMACS_INT, not int.
2513 (char_width, c_string_width): Check for overflow when
2514 computing the width; this is possible now that individual
2515 characters can have unbounded width. Problem introduced
2516 by merge from Emacs 23 on 2012-01-19.
2518 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2520 * dbusbind.c (Fdbus_register_method): Mention the return value
2521 :ignore in the docstring.
2523 2012-02-02 Glenn Morris <rgm@gnu.org>
2525 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2527 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2528 Unconditionally set to t. (Bug#10673)
2529 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2530 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2531 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2533 2012-02-02 Kenichi Handa <handa@m17n.org>
2535 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2536 0, do not call append_composite_glyph.
2538 2012-02-02 Kenichi Handa <handa@m17n.org>
2540 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2542 (x_produce_glyphs): If the component of a composition is a null
2543 string, set it->pixel_width to 1 to avoid zero-width glyph.
2545 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2547 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2548 first 2 arguments are identical. This makes inserting large
2549 output from a subprocess an order of magnitude faster on
2550 MS-Windows, where all sbrk'ed memory is always contiguous.
2552 2012-01-31 Glenn Morris <rgm@gnu.org>
2554 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2555 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2556 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2558 2012-01-29 Glenn Morris <rgm@gnu.org>
2560 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2562 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2564 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2566 2012-01-28 Chong Yidong <cyd@gnu.org>
2568 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2570 2012-01-26 Chong Yidong <cyd@gnu.org>
2572 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2574 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2575 repeat counts (Bug#10507).
2577 2012-01-26 Glenn Morris <rgm@gnu.org>
2579 * lread.c (syms_of_lread): Doc fix.
2581 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2583 * coding.c (encode_designation_at_bol): Change return value to
2586 2012-01-25 Chong Yidong <cyd@gnu.org>
2588 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2590 2012-01-21 Chong Yidong <cyd@gnu.org>
2592 * floatfns.c (Fcopysign): Make the second argument non-optional,
2593 since nil is not allowed anyway.
2595 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2597 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2598 (send_process): Likewise.
2600 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2602 * window.c (save_window_save, Fcurrent_window_configuration)
2603 (Vwindow_persistent_parameters): Do not use Qstate.
2604 Rewrite doc-strings.
2606 2012-01-19 Kenichi Handa <handa@m17n.org>
2608 * character.c (char_width): New function.
2609 (Fchar_width, c_string_width, lisp_string_width):
2610 Use char_width (Bug#9496).
2612 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2614 * window.c (Vwindow_persistent_parameters): New variable.
2615 (Fset_window_configuration, save_window_save): Handle persistent
2618 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2620 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2621 thrashing the stack of the thread. (Bug#9087)
2623 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2625 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2627 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2629 * xdisp.c (rows_from_pos_range): Handle the case where the
2630 highlight ends on a newline. (Bug#10464)
2631 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2632 he end column for display of highlight that ends on a newline
2635 2012-01-11 Glenn Morris <rgm@gnu.org>
2637 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2638 from load-path also when installation-directory is nil. (Bug#10208)
2640 2012-01-10 Glenn Morris <rgm@gnu.org>
2642 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2644 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2645 Update template values to be closer to their typical values these days.
2647 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2649 * xdisp.c (rows_from_pos_range): Accept additional argument
2650 DISP_STRING, and accept any glyph in a row whose object is that
2651 string as eligible for mouse highlight. Fixes mouse highlight of
2652 display strings from overlays. (Bug#10464)
2654 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2656 emacs: fix an auto-save permissions race condition (Bug#10400)
2657 * fileio.c (auto_saving_dir_umask): New static var.
2658 (Fmake_directory_internal): Use it.
2659 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2660 creating the directory. The old code temporarily assigns
2661 too-generous permissions to the directory.
2662 (do_auto_save_eh): Clear it.
2663 (Fdo_auto_save): Catch all errors, not just file errors, so
2664 that the var is always cleared.
2666 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2668 * search.c (scan_buffer): Pass character positions to
2669 know_region_cache, not byte positions. (Bug#6540)
2671 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2673 * w32.c (sys_rename): Report EXDEV when rename of a directory
2674 fails because the target is on another logical disk. (Bug#10284)
2676 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2678 * xterm.c (x_embed_request_focus): New function.
2680 * xterm.h: Add prototype.
2682 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2684 2012-01-05 Glenn Morris <rgm@gnu.org>
2686 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2688 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2690 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2691 Load gnutls_transport_set_lowat only if GnuTLS version is below
2693 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2694 GnuTLS versions below 2.11.1.
2696 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2698 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2699 to the doc string advising against its use for altering the way
2700 windows are scrolled.
2702 2011-12-28 Kenichi Handa <handa@m17n.org>
2704 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2705 coding-system ASCII compatible only when it does not produce BOM
2706 on encoding (Bug#10383).
2708 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2710 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2712 (create_and_show_popup_menu): Always use menu_position_func for
2715 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2717 * callint.c (Fcall_interactively): Don't truncate prompt string.
2719 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2721 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2722 property that ends at ZV, so that the bidi iteration could be
2723 resumed from there (after widening). (Bug#10360)
2725 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2727 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2729 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2731 * nsterm.m (x_free_frame_resources):
2732 Release f->output_data.ns->miniimage.
2733 (ns_index_color): Fix indentation. Do not retain
2734 color_table->colors[i].
2736 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2739 * nsfns.m (x_set_background_color): Assign return value from
2740 ns_index_color to face-background instead of NSColor*.
2741 (ns_implicitly_set_icon_type): Fix indentation.
2742 Change assignment in for loop to comparison.
2744 * emacs.c (ns_pool): New variable.
2745 (main): Assign ns_pool.
2746 (Fkill_emacs): Call ns_release_autorelease_pool.
2748 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2749 autorelease fdesc, release fdAttrs and tdict.
2750 (ns_get_covering_families): Release charset.
2751 (ns_findfonts): Release NSFontDescriptor created with new.
2752 (ns_uni_to_glyphs): Fix indentation.
2753 (setString): Release attrStr before assigning new value.
2755 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2757 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2759 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2760 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2762 2011-12-18 David Reitter <reitter@cmu.edu>
2764 * nsterm.m (ns_term_init): Subscribe for notifications
2765 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2766 to method trackingNotification in EmacsMenu.
2768 * nsmenu.m (trackingMenu): New variable.
2769 (trackingNotification): New method (from Aquamacs).
2770 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2771 from Aquamacs (Bug#7030).
2773 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2775 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2776 (symbol_to_nsstring): Fix indentation.
2777 (ns_symbol_to_pb): New function.
2778 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2779 (Fns_rotate_cut_buffers_internal): Remove.
2780 (Fns_store_selection_internal): Rename from
2781 Fns_store_cut_buffer_internal.
2782 (ns_get_foreign_selection, Fx_own_selection_internal)
2783 (Fx_disown_selection_internal, Fx_selection_exists_p)
2784 (Fns_get_selection_internal, Fns_store_selection_internal):
2785 Use ns_symbol_to_pb and check if return value is nil.
2786 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2787 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2788 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2789 renamed to Sns_store_selection_internal.
2790 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2791 and remove this function.
2792 (ns_handle_selection_clear): Remove, never used.
2793 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2796 2011-12-17 Ken Brown <kbrown@cornell.edu>
2798 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2799 GID is unknown (Bug#10257).
2801 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2803 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2804 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2805 which caused a build failure on GNU/Linux IA-64. This problem was
2806 introduced by my 2011-10-07 patch.
2808 2011-12-15 Juri Linkov <juri@jurta.org>
2810 * image.c (imagemagick_error): New function. (Bug#10112)
2811 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2812 Use `imagemagick_error' where ImageMagick functions return
2814 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2817 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2819 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2820 fill background (Bug#8992).
2822 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2824 * window.c (Vwindow_combination_resize)
2825 (Vwindow_combination_limit): Use t instead of non-nil in
2827 (Vrecenter_redisplay): Add first sentence of doc-string on
2829 (Frecenter): Fix doc-string typo.
2831 2011-12-11 Kenichi Handa <handa@m17n.org>
2833 * coding.c (Funencodable_char_position): Pay attention to the
2834 buffer text relocation (Bug#9389).
2836 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2838 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2839 gtk_init (Bug#10100).
2841 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2843 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2844 IT->string is nil. (Bug#10263)
2846 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2848 * nsterm.h (x_free_frame_resources): Declare.
2850 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2851 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2853 * nsterm.h (ns_get_defaults_value): Declare.
2855 * nsterm.m (ns_default): Call ns_get_defaults_value.
2857 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2859 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2862 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2864 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2865 that where the value of an _OBJC_* symbol points to is in the .bss
2866 section (Bug#10240).
2868 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2870 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2871 after the loop to call ccl_driver at least once (Bug#8619).
2873 2011-12-08 Kenichi Handa <handa@m17n.org>
2875 * ftfont.c (get_adstyle_property): Fix previous change
2878 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2880 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2881 dirs from the default value of EMACSLOADPATH (bug#10208).
2883 2011-12-07 Glenn Morris <rgm@gnu.org>
2885 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2886 installation and source directories as well. (Bug#10208)
2888 2011-12-06 Chong Yidong <cyd@gnu.org>
2890 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2892 2011-12-06 Glenn Morris <rgm@gnu.org>
2894 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2895 as an error, not just -1. (Bug#10217)
2897 2011-12-05 Chong Yidong <cyd@gnu.org>
2899 * keyboard.c (process_special_events): New function.
2900 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2902 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2904 * coding.c (encode_designation_at_bol): Don't use uninitialized
2905 local variable (Bug#9318).
2907 2011-12-05 Kenichi Handa <handa@m17n.org>
2909 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2910 return Qnil (Bug#8046, Bug#10193).
2912 2011-12-05 Kenichi Handa <handa@m17n.org>
2914 * coding.c (encode_designation_at_bol): New args charbuf_end and
2915 dst. Return the number of produced bytes. Callers changed.
2916 (coding_set_source): Return how many bytes coding->source was
2918 (coding_set_destination): Return how many bytes
2919 coding->destination was relocated.
2920 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2921 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2923 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2925 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2926 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2929 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2931 The following changes are to fix Bug#9318.
2933 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2934 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2935 (encode_coding_iso_2022, encode_coding_sjis)
2936 (encode_coding_big5, encode_coding_charset): Use the above macros.
2938 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2940 * lisp.h (process_quit_flag): Fix external declaration.
2942 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2944 Don't macro-inline non-performance-critical code.
2945 * eval.c (process_quit_flag): New function.
2946 * lisp.h (QUIT): Use it.
2948 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2950 * nsfns.m (get_geometry_from_preferences): New function.
2951 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2953 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2955 * emacs.c (Qkill_emacs): Define.
2956 (syms_of_emacs): Initialize it.
2957 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2958 Qquit_flag to `kill-emacs' instead.
2959 (quit_throw_to_read_char): Add parameter `from_signal'.
2960 All callers changed. Call Fkill_emacs if requested and safe.
2961 * lisp.h (QUIT): Call Fkill_emacs if requested.
2963 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2965 * widget.c (update_wm_hints): Return if wmshell is null.
2966 (widget_update_wm_size_hints): New function.
2968 * widget.h (widget_update_wm_size_hints): Declare.
2970 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2971 widget_update_wm_size_hints (Bug#10104).
2973 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2975 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2976 before a newline, prepare the bidi iterator for consuming the
2977 newline, and keep the current paragraph direction. (Bug#10183)
2978 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2980 2011-12-02 Juri Linkov <juri@jurta.org>
2982 * search.c (Fword_search_regexp): New Lisp function created from
2983 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2984 (Fword_search_backward, Fword_search_forward)
2985 (Fword_search_backward_lax, Fword_search_forward_lax):
2986 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2987 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2989 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2991 * fileio.c (Finsert_file_contents): Move after-change-function call
2992 to before the "handled:" label, since all "goto handled" appear in
2993 cases where the *-change-functions have already been properly called
2996 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2998 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2999 waiting for input. (Bug#10169)
3001 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3003 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3004 verifies glyph row's hash code--we have just reallocated the
3005 glyphs, so their contents can be complete garbage. (Bug#10164)
3007 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3009 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3011 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3013 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3014 attributes are tested _before_ calling verify_row_hash, to protect
3015 against GCC re-ordering of the tests. (Bug#10164)
3017 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3019 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3021 * xterm.c (handle_one_xevent): Only set async_visible and friends
3022 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3023 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3024 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3026 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3028 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3029 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3030 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3031 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3032 All uses changed to use GCPRO1 etc.
3033 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3034 Revert to old implementation (i.e., before 2011-03-11).
3036 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3038 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3039 of scroll runs so as to avoid assigning disabled bogus rows and
3040 unnecessary graphics copy operations.
3042 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3044 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3045 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3046 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3047 (malloc, free, realloc, calloc): Redirect to e_* only when
3050 * lisp.h (GCTYPEBITS): Move before first use.
3051 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3052 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3053 this macro definition.
3055 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3058 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3060 * gtkutil.c (xg_create_frame_widgets):
3061 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3062 present with Gtk+ 2.0.
3064 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3066 * fileio.c (Finsert_file_contents): Undo previous change; see
3067 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3069 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3071 Rename locals to avoid shadowing.
3072 * fileio.c (Finsert_file_contents):
3073 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3074 * process.c (wait_reading_process_output):
3075 Rename inner 'proc' to 'p' to avoid shadowing.
3076 Indent for consistency with usual Emacs style.
3078 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3080 * xdisp.c (redisplay_window): If cursor row is not fully visible
3081 after recentering, and scroll-conservatively is set to a large
3082 number, scroll window by a few more lines to make the cursor fully
3083 visible and out of scroll-margin. (Bug#10105)
3084 (start_display): Don't move to the next line if the display should
3085 start at a newline that is part of a display vector or an overlay
3088 2011-11-24 Juri Linkov <juri@jurta.org>
3090 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3091 after the `MagickPingImage' call. (Bug#10112)
3093 2011-11-23 Chong Yidong <cyd@gnu.org>
3095 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3097 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3099 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3100 making another buffer current. (Bug#10114)
3102 2011-11-23 Glenn Morris <rgm@gnu.org>
3104 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3106 2011-11-23 Chong Yidong <cyd@gnu.org>
3108 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3109 using it (Bug#5984).
3111 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3113 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3114 and header-lines, as they don't have one computed for them.
3117 * .gdbinit (prow): Make displayed values more self-explaining.
3118 Add row's hash code.
3120 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3122 * process.c (wait_reading_process_output): Fix asynchrounous
3123 GnuTLS socket handling on some versions of the GnuTLS library.
3124 (wait_reading_process_output): Add comment and URL.
3126 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3128 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3130 2011-11-21 Chong Yidong <cyd@gnu.org>
3132 * window.c (Fnext_window, Fprevious_window): Doc fix.
3134 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3136 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3138 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3140 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3142 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3144 * window.c (Fset_window_combination_limit): Rename argument
3146 (Vwindow_combination_limit): Remove "status" from doc-string.
3148 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3150 * m/ibms390.h: Remove.
3151 * m/ibms390x.h: Don't include "ibms390.h".
3153 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3155 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3156 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3158 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3160 * casetab.c (Fset_case_table):
3161 * charset.c (Fcharset_after): Fix typos.
3163 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3165 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3166 Otherwise, valgrind does not work on some platforms.
3167 Problem reported by Andreas Schwab in
3168 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3169 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3170 is set, removing the need for VIRT_ADDRESS_VARIES.
3171 (PURE_P): Use a more-efficient implementation that needs just one
3172 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3173 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3174 to 4 (xorl, subq, cmpq, setbe).
3175 * alloc.c (pure): Always extern now, since that's the
3176 VIRT_ADDR_VARIES behavior.
3177 (PURE_POINTER_P): Use a single comparison, not two, for
3178 consistency with the new puresize.h.
3179 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3180 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3181 Remove VIRT_ADDR_VARIES no longer needed.
3183 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3185 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3186 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3187 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3188 behave as if the cursor position were at the window margin.
3190 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3191 and the cursor position is out of bounds, behave as if the cursor
3192 position were at the window margin. (Bug#10075)
3194 2011-11-18 Chong Yidong <cyd@gnu.org>
3196 * window.c (Fwindow_combination_limit): Make first argument
3197 non-optional, since it is meaningless for live windows like the
3200 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3202 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3204 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3206 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3207 (graft_intervals_into_buffer): Simplify.
3209 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3211 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3212 hash values of the two rows.
3213 (copy_row_except_pointers): Preserve the used[] arrays and the
3214 hash values of the two rows. (Bug#10035)
3215 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3217 * xdisp.c (row_hash): New function, body extracted from
3218 compute_line_metrics.
3219 (compute_line_metrics): Call row_hash, instead of computing the
3222 * dispnew.c (verify_row_hash): Call row_hash for computing the
3223 hash code of a row, instead of duplicating code from xdisp.c.
3225 * dispextern.h (row_hash): Add prototype.
3227 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3229 * frame.c (delete_frame): Don't delete the terminal when the last
3230 X frame is closed if emacs is built with GTK toolkit.
3232 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3234 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3236 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3238 * window.c (Vwindow_splits): Rename to
3239 Vwindow_combination_resize. Suggested by Juri Linkov.
3240 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3243 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3245 * nsfns.m (Fns_font_name):
3246 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3248 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3250 * window.h (window): Rename slot "nest" to "combination_limit".
3251 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3252 (Fset_window_nest): Rename to Fset_window_combination_limit.
3253 (Vwindow_nest): Rename to Vwindow_combination_limit.
3254 (recombine_windows, make_parent_window, make_window)
3255 (Fsplit_window_internal, saved_window)
3256 (Fset_window_configuration, save_window_save): Rename all
3257 occurrences of window_nest to window_combination_limit.
3259 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3261 * image.c (imagemagick_load_image): Fix typo.
3263 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3265 * xdisp.c (display_line): Move the call to
3266 highlight_trailing_whitespace before the call to
3267 compute_line_metrics, since the latter needs to see the final
3268 faces of all the glyphs to compute ROW's hash value.
3269 Fixes assertion violations in row_equal_p. (Bug#10035)
3271 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3273 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3274 just return (bug#10044).
3276 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3278 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3279 with user-defined heap size. Bump the default size of the temacs
3280 heap to 27MB, to avoid memory warning when running temacs.
3281 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3283 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3284 current_matrix and desired_matrix. (Bug#9990)
3285 (verify_row_hash) [XASSERTS]: New function.
3286 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3287 that the hash value of glyph rows is correct.
3289 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3291 * window.h (window): Remove splits slot.
3292 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3293 (Fdelete_other_windows_internal, make_parent_window)
3294 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3295 (Fset_window_configuration, save_window_save): Don't deal with
3296 split status of windows.
3297 (saved_window): Remove splits slot.
3298 (Vwindow_splits): Rewrite doc-string.
3300 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3302 * xfns.c (unwind_create_frame):
3303 * nsfns.m (unwind_create_frame):
3304 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3305 Vframe_list (Bug#9999).
3307 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3309 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3311 2011-11-11 Kenichi Handa <handa@m17n.org>
3313 * callproc.c (Fcall_process): Set the member dst_multibyte of
3316 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3318 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3319 avoid a crash (bug#9496).
3321 2011-11-09 Chong Yidong <cyd@gnu.org>
3323 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3324 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3326 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3328 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3330 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3332 Avoid some portability problems by eschewing 'extern inline' functions.
3333 The trivial performance wins aren't worth the portability hassles; see
3334 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3336 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3337 (window_box_width, window_box_left, window_box_left_offset)
3338 (window_box_right, window_box_right_offset): Undo previous change,
3339 by removing the "extern"s.
3340 * intervals.c (adjust_intervals_for_insertion)
3341 (adjust_intervals_for_deletion): Undo previous change,
3342 making these static again.
3343 (offset_intervals, temp_set_point_both, temp_set_point)
3344 (copy_intervals_to_string): No longer inline.
3345 * xdisp.c (window_text_bottom_y, window_box_width)
3346 (window_box_height, window_box_left_offset)
3347 (window_box_right_offset, window_box_left, window_box_right)
3348 (window_box): No longer inline.
3350 2011-11-08 Chong Yidong <cyd@gnu.org>
3352 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3353 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3354 Signal an error if not a live window.
3355 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3356 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3358 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3360 * lisp.h (syms_of_abbrev): Remove declaration.
3361 Reported by CHENG Gao <chenggao@royau.me>.
3363 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3365 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3366 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3367 of temacs in GUI mode.
3369 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3371 * window.h: Declare delete_all_child_windows instead of
3372 delete_all_subwindows.
3373 * window.c (Fwindow_nest, Fset_window_nest)
3374 (Fset_window_new_total, Fset_window_new_normal)
3375 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3376 (delete_all_subwindows): Rename to delete_all_child_windows.
3377 (Fdelete_other_windows_internal, Fset_window_configuration):
3378 Call delete_all_child_windows instead of delete_all_subwindows.
3379 * frame.c (delete_frame): Call delete_all_child_windows instead
3380 of delete_all_subwindows.
3382 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3384 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3385 This is also needed for porting to any host where GC_MARK_STACK is
3386 not GC_MAKE_GCPROS_NOOPS.
3387 (which_symbols): Use it.
3389 2011-11-07 Kenichi Handa <handa@m17n.org>
3391 * coding.c (coding_set_destination): Check coding->src_pos only
3392 when coding->src_object is a buffer (bug#9910).
3394 * process.c (send_process): Set the member src_multibyte of coding
3395 to 0 (bug#9911) when sending a unibyte text.
3397 * callproc.c (Fcall_process): Set the member src_multibyte of
3398 process_coding to 0 (bug#9912).
3400 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3402 * xmenu.c (cleanup_widget_value_tree): New function.
3403 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3404 calling free_menubar_widget_value_tree directly (Bug#9830).
3406 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3408 Fix some portability problems with 'inline'.
3409 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3410 (window_box_width, window_box_left, window_box_left_offset)
3411 (window_box_right, window_box_right_offset): Declare extern.
3412 Otherwise, these inline functions do not conform to C99 and
3413 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3414 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3415 * intervals.c (adjust_intervals_for_insertion)
3416 (adjust_intervals_for_deletion): Now extern, because otherwise the
3417 extern inline functions 'offset_intervals' couldn't refer to it.
3418 (static_offset_intervals): Remove.
3419 (offset_intervals): Rewrite using the old contents of
3420 static_offset_intervals. The old version didn't conform to C99
3421 because an extern inline function contained a reference to an
3422 identifier with static linkage.
3424 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3426 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3429 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3431 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3432 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3433 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3434 return Qleft_to_right.
3436 2011-11-06 Chong Yidong <cyd@gnu.org>
3438 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3439 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3440 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3441 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3442 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3443 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3444 (Fwindow_vscroll): Doc fix.
3445 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3446 argument, since it makes no sense to pass a live window and for
3447 consistency with window-child.
3449 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3451 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3454 2011-11-05 Jason Rumney <jasonr@gnu.org>
3456 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3457 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3459 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3460 bitwise arithmetic preventing use of unicode-sip and non-truetype
3463 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3465 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3468 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3469 initialization code to keep similarity to xfns.c after changes
3472 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3474 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3475 (unwind_create_frame): New function (Bug#9943).
3476 (Fx_create_frame): Restructure code to be more similar to the one in
3477 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3478 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3479 Move terminal->reference_count++ just before making the frame official
3482 * nsterm.m (x_free_frame_resources): New function.
3483 (x_destroy_window): Move code to x_free_frame_resources.
3485 * xfns.c (unwind_create_frame): Fix comment.
3486 (Fx_create_frame, x_create_tip_frame):
3487 Move terminal->reference_count++ just before making the frame
3488 official. Move initialization of image_cache_refcount and
3489 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3491 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3493 Support MSVC build with newer versions of Visual Studio.
3494 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3495 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3498 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3499 which are not supported by MSVC.
3500 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3501 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3503 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3505 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3507 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3509 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3511 Support MSVC build with newer versions of Visual Studio.
3512 * w32.c: Don't include w32api.h for MSVC.
3513 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3515 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3516 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3517 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3518 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3520 (alloca) [_MSC_VER]: Define to _alloca.
3522 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3524 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3526 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3528 * xdisp.c (note_mouse_highlight): If either of
3529 previous/next-single-property-change returns nil, treat that as
3530 the beginning or the end of the buffer. (Bug#9955)
3532 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3534 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3535 label is not null (Bug#9951).
3536 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3539 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3541 * window.c (Fwindow_body_size): Mention in the doc string that the
3542 return value is in frame's canonical units. (Bug#9949)
3544 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3546 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3548 * w32fns.c (unwind_create_frame): If needed, free the glyph
3549 matrices of the partially constructed frame. (Bug#9943)
3550 * xfns.c (unwind_create_frame): Likewise.
3552 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3554 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3555 Don't stop backward scan on the continuation glyph, even though
3556 its CHARPOS is positive.
3557 (mouse_face_from_buffer_pos, note_mouse_highlight):
3558 Rename cover_string to disp_string.
3560 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3562 * window.c (temp_output_buffer_show): Don't use
3563 Vtemp_buffer_show_specifiers.
3564 (Vtemp_buffer_show_specifiers): Remove unused variable.
3566 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3568 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3569 past the beginning of the current glyph matrix.
3571 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3573 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3574 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3575 HAVE_GTK3 (Bug#9869).
3577 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3578 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3580 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3582 * xterm.c: Declare x_handle_net_wm_state to return int.
3583 (handle_one_xevent): Check if we are iconified but don't have
3584 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3585 (get_current_wm_state): Return non-zero if not hidden,
3586 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3587 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3588 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3589 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3591 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3593 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3594 so that this new function doesn't get optimized away by a
3595 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3597 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3599 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3601 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3603 Fix the `xbytecode' command.
3604 * .gdbinit (xprintbytestr): New command.
3605 (xwhichsymbols): Rename from `which'; all callers changed.
3606 (xbytecode): Print the byte-code string as well.
3608 2011-10-29 Kim Storm <storm@cua.dk>
3610 * alloc.c (which_symbols): New function.
3612 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3614 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3617 2011-10-29 Glenn Morris <rgm@gnu.org>
3619 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3620 Not clear what it was for, and it causes various bugs. (Bug#9839)
3622 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3624 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3625 possible random value that matches one of those tested as
3626 condition to clear the mouse face.
3628 2011-10-28 Chong Yidong <cyd@gnu.org>
3630 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3632 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3634 * window.c (make_window): Initialize phys_cursor_on_p.
3636 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3638 * lisp.h (struct Lisp_Symbol): Update comments.
3640 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3642 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3644 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3646 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3647 <oslsachem@gmail.com> for helping to debug this.
3649 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3650 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3651 (g_b_init_get_glyph_outline_w): New static variables.
3652 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3653 (GetGlyphOutlineW_Proc): New typedefs.
3654 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3655 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3657 (w32font_open_internal, compute_metrics):
3658 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3659 instead of calling the "wide" APIs directly.
3661 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3663 * w32.h (syms_of_w32font): Add prototype.
3665 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3667 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3668 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3669 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3670 (Fmove_to_window_line): Doc fix.
3672 2011-10-27 Chong Yidong <cyd@gnu.org>
3674 * process.c (make_process): Set gnutls_state to NULL.
3676 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3677 non-NULL, regardless of GNUTLS_INITSTAGE.
3678 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3679 an error. Set process slots as soon as we allocate them.
3681 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3683 2011-10-27 Chong Yidong <cyd@gnu.org>
3685 * gnutls.c (emacs_gnutls_deinit): New function.
3686 Deallocate credentials structures as well as calling gnutls_deinit.
3687 (Fgnutls_deinit, Fgnutls_boot): Use it.
3689 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3690 (deactivate_process): Call emacs_gnutls_deinit.
3692 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3694 * image.c (x_create_x_image_and_pixmap):
3695 * w32.c (sys_rename, w32_delayed_load):
3696 * w32font.c (fill_in_logfont):
3697 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3699 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3701 * w32fns.c (w32_default_color_map): New function,
3702 extracted from Fw32_default_color_map.
3703 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3705 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3707 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3709 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3711 * keyboard.c (test_undefined): New function (bug#9751).
3712 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3714 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3716 * sysdep.c (init_sys_modes): Fix the check for the controlling
3717 terminal (Bug#6649).
3719 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3721 * dispextern.h (struct bidi_it): New member next_en_type.
3723 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3724 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3725 current character, check also for next_en_type being WEAK_EN.
3726 (bidi_resolve_weak): Don't enter the expensive loop if the current
3727 position is before next_en_pos. Record the bidi type of the first
3728 non-ET, non-BN character we find, in addition to its position.
3729 (bidi_level_of_next_char): Invalidate next_en_type when
3730 next_en_pos is over-stepped.
3732 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3734 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3735 * editfns.c: Rewrite current-time-zone so that it invokes
3736 the equivalent of (format-time-string "%Z") to get the time zone name.
3737 This fixes a bug when the time zone name contains characters that
3738 need converting from the system time locale to Emacs internal format.
3739 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3740 that patch fixed format-time-string to do the conversion, but
3741 I forgot to fix current-time-zone.
3742 (format_time_string): New function, containing most of
3743 what Fformat_time_string used to contain.
3744 (Fformat_time_string): Rewrite in terms of format_time_string.
3745 This doesn't change this function's behavior.
3746 (current-time-zone): Rewrite to use format_time_string.
3747 This fixes the bug reported by Michael Schierl in
3748 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3749 Jason Rumney's 2007-06-07 change worked around this bug, but
3751 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3753 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3755 * xdisp.c (start_display): If the character at POS is displayed
3756 via a display vector, reset IT->current.dpvec_index to zero.
3757 (try_window_reusing_current_matrix): If a line ends in a display
3758 vector or the next line starts in a display vector, continue
3759 redrawing the window even though the character position of
3760 start_row was reached.
3763 2011-10-18 Chong Yidong <cyd@gnu.org>
3765 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3766 with nobreak-char-display too.
3768 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3770 Fix part 3 of bug#9771.
3771 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3772 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3773 non-neutral characters if the current character is a paragraph
3774 separator (a.k.a. Newline). This avoids running the same
3775 expensive loop twice, once when we consume the preceding newline
3776 and the other time when the line actually needs to be displayed.
3777 Avoid the loop when we see neutrals on the base embedding level
3778 following a character whose directionality is the same as the
3779 paragraph's. This avoids running the expensive loop when a line
3780 ends in a long sequence of neutrals, like control characters.
3781 Add assertion against STRONG_AL type. Slightly rearrange code
3782 that determines the type of a neutral given the first non-neutral
3784 (bidi_level_of_next_char): Set next_en_pos to zero when
3785 invalidating its info.
3787 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3789 * xdisp.c (push_display_prop): Determine whether to record string
3790 or buffer position by IT->string, not by IT->method. Allow
3791 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3792 (move_it_vertically_backward): Don't look for character position
3793 immediately after the newline when in a continuation line.
3796 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3798 * window.c (coordinates_in_window): Rewrite and delabelize
3799 vertical border check. (Bug#5357) (Bug#9618)
3801 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3803 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3804 errors in XSetWindowBorder (bug#9310).
3806 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3808 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3809 avoid crash when xmalloc overrun checking is enabled.
3811 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3813 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3814 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3815 cursor motion with <left> and <right> arrow keys.
3817 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3818 some callers set that themselves.
3820 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3822 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3823 display string and the previous row comes from the same string and
3824 is empty. (Bug#9739) (Bug#9738)
3826 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3828 * doc.c (get_doc_string): Encode file name (bug#9735).
3830 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3832 * bidi.c (bidi_level_of_next_char):
3833 * xdisp.c (get_visually_first_element): Remove old incorrect
3834 comments regarding the Unicode Line Separator character.
3836 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3838 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3840 * alloc.c (Fgc_status): Do not access beyond zombies array
3841 boundary if nzombies > MAX_ZOMBIES.
3842 * alloc.c (dump_zombies): Add missing format specifier.
3844 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3846 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3847 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3849 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3850 Some packages use them to denote characters with modifiers.
3852 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3854 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3855 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3856 matching a pp-number. Rename parameter var to var1.
3858 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3860 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3862 2011-10-08 Glenn Morris <rgm@gnu.org>
3864 * callint.c (Fcall_interactively): Give a more explicit error for the
3865 'c' case with a non-character input. (Bug#8479)
3867 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3869 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3871 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3872 lines that are hscrolled on the left.
3874 * dispnew.c (buffer_posn_from_coords): Account for a possible
3875 presence of header-line. (Bug#4426)
3877 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3879 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3880 Don't advertise functionality which we discourage or doesn't work.
3882 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3884 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3885 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3886 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3887 this makes Emacs dump core during garbage collection on rare
3888 occasions. sizeof is obviously inferior to offsetof here, so
3889 stick with offsetof.
3890 (GC_POINTER_ALIGNMENT): New macro.
3891 (mark_memory): Omit 3rd (offset) arg; caller changed.
3892 Don't assume EMACS_INT alignment is the same as pointer alignment.
3894 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3896 * keyboard.c (read_key_sequence_remapped): New var.
3897 (read_key_sequence): Compute remapping in the right buffer.
3898 (command_loop_1): Use read_key_sequence's remapping directly.
3900 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3902 * dired.c (file_name_completion): Don't expand file name.
3903 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3904 before checking file name handler.
3906 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3907 they've been requested explicitly (bug#9591).
3909 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3911 * keymap.c (Fsingle_key_description): Use make_specified_string
3912 instead of build_string to build string from push_key_description.
3915 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3917 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3918 This fixes a Y2038 bug on 64-bit hosts.
3919 * buffer.c (reset_buffer):
3920 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3921 (Fclear_buffer_auto_save_failure):
3922 Use 0, not -1, to represent an unset failure time, since time_t
3923 might not be signed.
3925 Remove dependency on glibc malloc internals.
3926 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3927 Move back here from lisp.h, but with their new implementations.
3928 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3929 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3930 * charset.c (charset_table_init): New static var.
3931 (syms_of_charset): Use it instead of xmalloc. This removes a
3932 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3933 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3934 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3935 Move back to alloc.c.
3936 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3937 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3939 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3941 * nsterm.m (windowDidResize): Call x_set_window_size only when
3942 ns_in_resize is true. Otherwise set pixelwidth/height and
3943 call change_frame_size (Bug#9628).
3945 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3947 Port --enable-checking=all to Fedora 14 x86-64.
3948 * charset.c (syms_of_charset): Also account for glibc malloc's
3949 internal overhead when calculating the initial malloc maximum.
3951 Port --enable-checking=all to Fedora 14 x86.
3952 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3954 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3955 (overrun_check_realloc, overrun_check_free):
3956 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3957 That way, xmalloc returns a properly-aligned pointer even if
3958 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3959 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3960 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3961 into account when calculating the initial malloc maximum.
3962 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3963 Move here from alloc.c, so that charset.c can use it too.
3964 Properly align; the old code wasn't right for common 32-bit hosts
3965 when configured with --enable-checking=all.
3966 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3967 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3969 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3971 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3974 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3976 * xdisp.c (compute_display_string_end): If there's no display
3977 string at CHARPOS, return -1.
3979 * bidi.c (bidi_fetch_char): When compute_display_string_end
3980 returns a negative value, treat the character as a normal
3981 character not covered by a display string. (Bug#9624)
3983 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3985 * lread.c (Fread_from_string): Fix typo in docstring.
3987 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3989 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3990 newline, reseat the iterator instead of bidi-iterating there one
3991 character at a time. (Bug#9610)
3992 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3993 TO_CHARPOS if the bidi iterator is at base embedding level.
3995 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3997 * lread.c (readevalloop): Use correct code for NBSP.
3998 (read1): Likewise. (Bug#9608)
4000 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4002 * dbusbind.c (Fdbus_register_signal): When service is not
4003 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4005 2011-09-25 Glenn Morris <rgm@gnu.org>
4007 * buffer.c (truncate-lines): Doc fix.
4009 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4011 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4012 (Fset_window_next_buffers): Doc fix.
4014 2011-09-24 Glenn Morris <rgm@gnu.org>
4016 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4018 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4020 Fix minor problems found by static checking.
4021 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4022 * indent.c (Fvertical_motion): Fix == vs = typo.
4024 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4026 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4027 Default value is now t. Doc fix.
4029 * indent.c (Fvertical_motion): Compute and apply the overshoot
4030 logic when moving up, not only when moving down. Fix the
4031 confusing name and values of the it_overshoot_expected variable;
4032 logic changes accordingly. (Bug#9254) (Bug#9549)
4034 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4035 CHARPOS is covered by a display string which includes newlines.
4036 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4037 is covered by a display string with embedded newlines.
4039 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4041 * dbusbind.c (Fdbus_register_signal): Add match rule to
4042 Vdbus_registered_objects_table. (Bug#9581)
4043 (Fdbus_register_method, Vdbus_registered_objects_table):
4046 2011-09-24 Jim Meyering <meyering@redhat.com>
4048 do not ignore write error for any output size
4049 The previous change was incomplete.
4050 While it makes emacs --batch detect the vast majority of stdout
4051 write failures, errors were still ignored whenever the output size is
4052 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4053 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4054 && echo FAIL: ignored write error
4055 FAIL: ignored write error
4056 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4057 && echo FAIL: ignored write error
4058 FAIL: ignored write error
4059 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4061 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4063 * emacs.c (Fkill_emacs): In noninteractive mode exit
4064 non-successfully if a write error occurred on stdout. (Bug#9574)
4066 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4068 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4071 * dispextern.h (struct it): Update the comment documenting what
4074 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4076 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4077 a display string, extend search for cursor position to end of row.
4078 (find_row_edges): If the row ends in a newline from a display
4079 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4080 Handle the case of a display string with multiple newlines.
4081 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4082 non-empty line. Fixes confusing cursor motion with arrow keys at
4083 the beginning of a line that starts with whitespace.
4085 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4087 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4090 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4092 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4095 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4097 * xdisp.c (display_line): Record maximum and minimum buffer
4098 positions even if no glyphs were produced (e.g., by a zero-width
4099 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4100 buffer positions that will be removed from the glyph row because
4102 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4103 column is beyond frame width: don't subtract 1 "pixel" when
4104 computing width of the stretch.
4105 (reseat_at_next_visible_line_start): Undo the change made on
4106 2011-09-17 that saved paragraph information and restored it after
4107 the call to `reseat'. (Bug#9545)
4109 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4111 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4112 and turn window cursor on if cleared (Bug#9415).
4114 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4116 * search.c (boyer_moore): Take unibyte characters from pattern
4117 literally. (Bug#9458)
4119 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4121 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4123 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4125 Fix minor problem found by static checking.
4126 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4127 initialized, to pacify gcc -Wuninitialized.
4129 * fileio.c: Report proper errno when syscall falls.
4130 (Finsert_file_contents): Save and restore errno,
4131 so that report_file_error outputs the correct diagnostic.
4132 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4134 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4136 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4138 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4140 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4141 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4143 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4145 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4146 about the current paragraph and restore it after the call to reseat.
4148 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4149 (bidi_find_paragraph_start): Search back for paragraph beginning
4150 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4151 (bidi_move_to_visually_next): Only trigger paragraph-related
4152 computations when the last character is a newline or at EOB, not
4153 just any NEUTRAL_B. (Bug#9470)
4155 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4156 truncated lines if point is covered by a display string. (Bug#9524)
4158 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4160 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4161 (cons_to_x_long): New function.
4162 (lisp_data_to_selection_data): Use it. Correct the test for
4163 short-versus-long data; it was negated. Break out of vector
4164 loop, for efficiency, when a long datum is discovered.
4166 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4168 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4170 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4172 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4173 GCC PR/17406) by declaring this function with external scope.
4175 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4177 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4178 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4180 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4182 * editfns.c (Fformat): Correctly handle text properties on "%%".
4184 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4186 * xterm.c (x_draw_composite_glyph_string_foreground):
4187 * w32term.c (x_draw_composite_glyph_string_foreground):
4188 * term.c (encode_terminal_code):
4189 * composite.c (composition_update_it, get_composition_id):
4190 * xdisp.c (get_next_display_element)
4191 (fill_composite_glyph_string): Add comments about special meaning
4192 of TAB characters in a composition.
4194 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4196 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4197 This occurs when processing a multibyte format.
4198 Problem reported by Wolfgang Jenker.
4200 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4202 * xdisp.c (try_cursor_movement): Only check for exact match if
4203 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4205 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4207 Remove unused external symbols.
4208 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4209 * xdisp.c (calc_pixel_width_or_height): Now static.
4210 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4211 * indent.c (check_display_width):
4212 * w32term.c: Fix comment to match code.
4213 * xterm.c, xterm.h (x_catching_errors): Remove.
4215 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4217 * xselect.c: Use signed conversions more consistently (Bug#9498).
4218 (selection_data_to_lisp_data): Assume incoming selection data are
4219 signed integers, not unsigned. This is to be consistent with
4220 outgoing selection data, which was modified to use signed integers
4221 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4222 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4223 expects long, not unsigned long.
4225 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4227 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4228 computation of loop end. Reported by Johan Bockgård
4231 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4233 * frame.c (Fother_visible_frames_p): Function deleted.
4235 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4237 * indent.c (compute_motion): Process display vector front to back
4238 rather than the other way around. (Bug#2496)
4240 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4242 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4244 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4246 * minibuf.c (Fread_from_minibuffer): Doc fix.
4248 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4250 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4251 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4253 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4255 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4256 value for non-existent files.
4258 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4260 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4261 set its "size" to -1. This will set the modtime_size field of
4262 the corresponding buffer to -1, which is what
4263 verify-visited-file-modtime expects for files that do not exist.
4266 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4268 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4270 * lisp.h: ... from here. push_key_description is no longer
4271 defined in keyboard.c, so its declaration should not be in
4272 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4273 logically belongs with push_key_description.
4275 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4277 * buffer.h: Include <sys/types.h> instead of <time.h>.
4278 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4279 Problem reported by Herbert J. Skuhra.
4281 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4283 * xml.c (parse_region): Make the parsing work for
4284 non-comment-starting XML files again (bug#9144).
4286 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4288 * image.c (gif_load): Fix calculation of bottom and right corner.
4291 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4293 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4294 redisplay in small windows.
4296 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4298 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4300 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4302 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4303 Operate on live windows only.
4305 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4307 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4309 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4311 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4312 only under bidi iteration.
4314 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4316 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4318 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4320 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4321 Without this fix, the command to link temacs failed due to an
4322 undefined symbol __builtin_isnan. This is because
4323 /usr/include/iso/math_c99.h #defines isnan(x) to
4324 __builtin_isnan(x), but the bundled gcc, which identifies itself
4325 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4327 * floatfns.c (isnan): #undef, and then #define to a clone of
4329 (Fisnan): Always define, since it's always available now.
4330 (syms_of_floatfns): Always define isnan at the Lisp level.
4332 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4334 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4336 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4338 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4339 The previous code assumed that file offsets (off_t values) fit in
4340 EMACS_INT variables, which is not true on typical 32-bit hosts.
4341 The code messed up by falsely reporting buffer overflow in cases
4342 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4343 when "big" contains more than 2**29 bytes, even though this
4344 inserts just one byte and does not overflow the buffer.
4345 (Finsert_file_contents): Store file offsets as off_t
4346 values, not as EMACS_INT values. Check for overflow when
4347 converting between EMACS_INT and off_t. When checking for
4348 buffer overflow or for overlap, take the offsets into account.
4349 Don't use EMACS_INT for small values where int suffices.
4350 When checking for overlap, fix a typo: ZV was used where
4351 ZV_BYTE was intended.
4352 (Fwrite_region): Don't assume off_t fits into 'long'.
4353 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4355 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4357 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4359 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4361 sprintf-related integer and memory overflow issues (Bug#9412).
4363 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4364 (esprintf, exprintf, evxprintf): New functions.
4365 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4366 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4367 (modify_event_symbol): Do not assume that the length of
4368 name_alist_or_stem is safe to alloca and fits in int.
4369 (Fexecute_extended_command): Likewise for function name and binding.
4370 (Frecursion_depth): Wrap around reliably on integer overflow.
4371 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4372 since some callers pass EMACS_INT values.
4373 (Fsingle_key_description): Don't crash if symbol name contains more
4374 than MAX_ALLOCA bytes.
4375 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4376 (get_minibuffer): Arg is now EMACS_INT, not int.
4377 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4378 (esprintf, exprintf, evxprintf): New decls.
4379 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4381 * dbusbind.c (signature_cat): New function.
4382 (xd_signature, Fdbus_register_signal):
4383 Do not overrun buffer; instead, report string overflow.
4385 * dispnew.c (add_window_display_history): Don't overrun buffer.
4386 Truncate instead; this is OK since it's just a log.
4388 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4389 even if the time zone offset is outlandishly large.
4390 Don't mishandle offset == INT_MIN.
4392 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4393 when creating daemon; the previous buffer-overflow check was incorrect.
4395 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4396 which has the guts of the old verror function.
4398 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4399 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4401 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4402 (font_unparse_xlfd): Don't blindly alloca long strings.
4403 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4404 fits in int, when using sprintf. Use single snprintf to count
4405 length of string rather than counting it via multiple sprintfs;
4406 that's simpler and more reliable.
4407 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4408 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4409 sprintf, in case result does not fit in int.
4411 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4412 (fontset_from_font): Print it.
4414 * frame.c (tty_frame_count): Now printmax_t, not int.
4415 (make_terminal_frame, set_term_frame_name): Print it.
4416 (x_report_frame_params): In X, window IDs are unsigned long,
4417 not signed long, so print them as unsigned.
4418 (validate_x_resource_name): Check for implausibly long names,
4419 and don't assume name length fits in 'int'.
4420 (x_get_resource_string): Don't blindly alloca invocation name;
4421 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4424 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4425 (xg_check_special_colors, xg_set_geometry):
4426 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4428 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4429 Use esprintf, not sprintf, in case result does not fit in int.
4431 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4432 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4433 it as a large positive number.
4434 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4435 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4437 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4438 in case result does not fit in int.
4440 * print.c (float_to_string): Detect width overflow more reliably.
4441 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4442 buffer overrun. Don't assume list length fits in 'int'. Treat
4443 print length of 0 as 0, not as infinity; to be consistent with other
4444 uses of print length in this function. Don't overflow print length
4445 index. Don't assume hash table size fits in 'long', or that
4446 vectorlike size fits in 'unsigned long'.
4448 * process.c (make_process): Use printmax_t, not int, to format
4449 process-name gensyms.
4451 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4453 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4454 to avoid potential buffer overrun.
4456 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4457 if X resource line is longer than 512 bytes.
4459 * xfns.c (x_window): Make sprintf buffer a bit bigger
4460 to avoid potential buffer overrun.
4462 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4464 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4466 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4468 Integer overflow fixes for scrolling, etc.
4469 Without these, Emacs silently mishandles large integers sometimes.
4470 For example, "C-u 4294967297 M-x recenter" was treated as if
4471 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4473 * xdisp.c (try_window_id): Check Emacs fixnum range before
4474 converting to 'int'.
4476 * window.c (window_scroll_line_based, Frecenter):
4477 Check that an Emacs fixnum is in range before assigning it to 'int'.
4478 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4479 values converted from Emacs fixnums.
4480 (Frecenter): Don't wrap around a line count if it is out of 'int'
4481 range; instead, treat it as an extreme value.
4482 (Fset_window_configuration, compare_window_configurations):
4483 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4485 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4486 that can exceed INT_MAX. Check that EMACS_INT value is in range
4487 before assigning it to the (possibly-narrower) index.
4488 (match_limit): Don't assume that a fixnum can fit in 'int'.
4490 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4493 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4494 (Fvertical_motion): Don't wrap around LINES values that don't fit
4495 in 'int'. Instead, treat them as extreme values. This is good
4496 enough for windows, which can't have more than INT_MAX lines anyway.
4498 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4500 * Require libxml/parser.h to avoid compilation warning.
4502 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4504 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4505 since this reportedly can destroy thread storage.
4507 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4509 * syntax.c (find_defun_start): Update all cache variables if
4510 exiting early (Bug#9401).
4512 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4514 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4516 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4517 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4518 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4520 * term.c (tty_append_glyph): New function.
4521 (produce_stretch_glyph): Static function and its prototype deleted.
4523 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4526 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4528 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4529 when checking :margin (Bug#9390).
4530 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4531 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4532 so that the name doesn't mislead. All uses changed.
4534 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4536 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4539 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4541 * xdisp.c (move_it_to): Don't bail out early when reaching
4542 position beyond to_charpos, if we are scanning backwards.
4543 (move_it_vertically_backward): When DY == 0, make sure we get to
4544 the first character in the line after the newline.
4546 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4548 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4549 (ccl_driver): Do not generate an out-of-range pointer.
4550 (Fccl_execute_on_string): Remove unnecessary check for
4551 integer overflow, noted by Stefan Monnier in
4552 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4553 Remove a FIXME that didn't need fixing.
4554 Simplify the newly-introduced buffer reallocation code.
4556 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4558 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4560 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4562 Integer and memory overflow issues (Bug#9196).
4564 * doc.c (get_doc_string): Rework so that
4565 get_doc_string_buffer_size is the actual buffer size, rather than
4566 being 1 less than the actual buffer size; this makes xpalloc more
4569 * image.c (x_allocate_bitmap_record, cache_image):
4570 * xselect.c (Fx_register_dnd_atom):
4571 Simplify previous changes by using xpalloc.
4573 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4574 since either will do and ptrdiff_t is convenient with xpalloc.
4576 * charset.c (charset_table_size)
4577 (struct charset_sort_data.priority): Now ptrdiff_t.
4578 (charset_compare): Don't overflow if priorities differ greatly.
4579 (Fsort_charsets): Don't assume list length fits in int.
4580 Check for size-calculation overflow when allocating sort data.
4581 (syms_of_charset): Allocate an initial charset table that is
4582 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4584 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4586 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4587 The actual value is always <= INT_MAX, and leaving it unsigned made
4588 overflow checking harder.
4590 * dispextern.h (struct glyph_matrix.rows_allocated)
4591 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4592 with xpalloc. The values are still always <= INT_MAX.
4594 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4596 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4597 (SAFE_NALLOCA): New macro.
4599 * region-cache.c (struct boundary.pos, find_cache_boundary)
4600 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4601 (set_cache_region, invalidate_region_cache)
4602 (revalidate_region_cache, know_region_cache, region_cache_forward)
4603 (region_cache_backward, pp_cache):
4604 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4605 so that ptrdiff_t * can be passed to xpalloc.
4606 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4607 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4608 (pp_cache): Don't assume cache_len fits in int.
4609 * region-cache.h: Adjust extern decls to match.
4611 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4612 EMACS_INT, since either will do, for xpalloc.
4614 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4615 (xnmalloc, xnrealloc, xpalloc): New functions.
4617 * bidi.c (bidi_shelve_header_size): New constant.
4618 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4619 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4621 * bidi.c (bidi_cache_shrink):
4622 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4624 Don't update size of array until after memory allocation succeeds,
4625 because xmalloc/xrealloc may not return.
4626 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4627 now that we have proper integer overflow checking.
4628 (record_overlay_string, overlay_strings): Catch overflows when
4629 calculating size of overlay_str_buf.
4631 * callproc.c (Fcall_process): Check for size overflow when
4632 calculating size of args2.
4633 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4634 Normally we prefer signed values, but sticking with ptrdiff_t would
4635 require adding more-complicated checks.
4637 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4638 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4639 Redo buffer-overflow calculations to avoid integer overflow.
4640 Add a FIXME comment where memory seems to be over-allocated.
4642 * character.c (Fstring): Check for size-calculation overflow.
4644 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4645 unnecessary integer overflow. Check for size overflow.
4646 (encode_coding_object): Don't update size until xmalloc succeeds.
4648 * composite.c (get_composition_id): Check for overflow in glyph
4649 length calculations.
4651 Integer and memory overflow fixes for display code.
4652 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4653 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4654 (scrolling_window): Check for overflow in size calculations.
4655 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4656 Don't assume glyph table len fits in int.
4657 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4658 (row_table_size): Now ptrdiff_t, not int.
4659 (scrolling_window): Avoid overflow in size calculations.
4660 Don't update size until allocation succeeds.
4661 * fns.c (concat): Check for overflow in size calculations.
4662 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4663 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4664 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4666 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4667 (get_doc_string): Check for size calculation overflow.
4668 Don't update size until allocation succeeds.
4669 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4670 EMACS_INT, where ptrdiff_t will do.
4671 (Fsubstitute_command_keys): Check for string overflow.
4673 * editfns.c (set_time_zone_rule): Don't assume environment length
4675 (message_length): Now ptrdiff_t, not int.
4676 (Fmessage_box): Don't update size until allocation succeeds.
4677 Don't assume message length fits in int.
4678 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4680 * emacs.c (main): Do not reallocate argv, since there is a null at
4681 the end that can be overwritten, and this way there's no need to
4682 worry about size-calculation overflow.
4683 (sort_args): Check for size-calculation overflow.
4685 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4687 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4689 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4690 (x_set_scroll_bar_width, x_figure_window_size):
4691 Check for integer overflow.
4692 (x_set_alpha): Do not assume XINT fits in int.
4694 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4695 This is for the members text_lines, text_cols, total_lines, total_cols,
4696 where the system imposes an 'int' limit.
4698 * fringe.c (Fdefine_fringe_bitmap):
4699 Don't update size until alloc works.
4701 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4702 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4704 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4705 Check for size-calculation overflow.
4706 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4707 do, as we prefer signed integers.
4708 (id_to_widget.max_size, id_to_widget.used)
4709 (xg_store_widget_in_map, xg_remove_widget_from_map)
4710 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4711 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4712 Use and return ptrdiff_t, not int.
4713 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4714 * gtkutil.h: Change prototypes to match the above.
4716 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4717 are duplicate now that they've been promoted to lisp.h.
4718 (x_allocate_bitmap_record, x_alloc_image_color)
4719 (make_image_cache, cache_image, xpm_load):
4720 Don't update size until alloc is done.
4721 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4723 Check for size calculation overflow.
4724 (ct_colors_allocated_max): New constant.
4725 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4728 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4729 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4730 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4731 Use ptrdiff_t, not int, to count maps.
4732 (read_char_minibuf_menu_prompt): Check for overflow in size
4733 calculations. Don't update size until allocation succeeds.
4734 Redo calculations to avoid overflow.
4735 * keyboard.h: Change prototypes to match the above.
4737 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4739 (current_minor_maps): Check for size calculation overflow.
4740 * keymap.h: Change prototypes to match the above.
4742 * lread.c (read1, init_obarray): Don't update size until alloc done.
4744 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4745 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4747 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4748 Now ptrdiff_t, not int.
4749 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4750 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4752 * process.c (Fnetwork_interface_list): Check for overflow
4753 in size calculation.
4755 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4757 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4758 overflow. Don't bother calling xmalloc when xrealloc will do.
4760 * search.c (Freplace_match): Check for size calculation overflow.
4761 (Fset_match_data): Don't assume list lengths fit in 'int'.
4763 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4764 for command line length. Do not attempt to address one before the
4765 beginning of an array, as that's not portable.
4767 * term.c (max_frame_lines): Remove; unused.
4768 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4770 (encode_terminal_code, calculate_costs): Check for size
4771 calculation overflow.
4772 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4773 table lengths and related sizes. Don't update size until alloc
4774 done. Redo calculations to avoid overflow.
4775 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4777 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4778 subtracting pointers.
4779 (gobble_line): Check for overflow more carefully. Don't update size
4782 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4783 Don't update size until alloc done.
4784 Redo size calculations to avoid overflow.
4785 Check for size calculation overflow.
4786 (main) [DEBUG]: Fix typo in invoking tparam1.
4788 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4789 Use ptrdiff_t, not int, for sizes.
4790 (store_mode_line_noprop_char): Don't update size until alloc done.
4792 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4793 Use ptrdiff_t, not int, for sizes.
4794 (Finternal_make_lisp_face, cache_face):
4795 Check for size calculation overflow.
4796 (cache_face): Treat size calculation overflows as if they were
4797 memory exhaustion (the usual treatment), rather than aborting.
4799 * xfns.c (x_encode_text, x_set_name_internal)
4800 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4801 sizes, since they can exceed INT_MAX in size. Check for size
4802 calculation overflow.
4804 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4805 (xg_select): Check for size calculation overflow.
4806 Don't update size until alloc done.
4808 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4809 as sprintf is limited to int lengths.
4811 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4812 (X_LONG_MIN): New macros.
4813 Use them to make the following changes clearer.
4814 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4815 This change doesn't affect the value now, but it may help remind
4816 future maintainers not to raise the value too much later.
4817 (SELECTION_QUANTUM): Remove, replacing with ...
4818 (selection_quantum): ... new function, which avoids overflow.
4820 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4821 assumption that selection length fits in 'int'.
4822 (x_reply_selection_request, x_handle_selection_request)
4823 (x_get_window_property, receive_incremental_selection)
4824 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4825 (lisp_data_to_selection_data, clean_local_selection_data):
4826 Use ptrdiff_t, not int, to record length of selection.
4827 (x_reply_selection_request, x_get_window_property)
4828 (receive_incremental_selection, x_property_data_to_lisp):
4829 Redo calculations to avoid overflow.
4830 (x_reply_selection_request): When sending hint, ceiling it at
4831 X_LONG_MAX rather than relying on wraparound overflow to send
4833 (x_get_window_property, receive_incremental_selection)
4834 (lisp_data_to_selection_data, x_property_data_to_lisp):
4835 Check for size-calculation overflow.
4836 (x_get_window_property, receive_incremental_selection)
4837 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4838 Don't store size until memory allocation succeeds.
4839 (x_get_window_property): Plug memory leak on memory exhaustion.
4840 Don't double-block input; malloc is safe here. Don't assume 2**34
4841 - 4 fits in unsigned long. Add an xassert to check
4842 XGetWindowProperty overflow. Be more careful about overflow
4843 calculations, and distinguish size from memory overflow better.
4844 (receive_incremental_selection): When tracing, don't assume
4845 unsigned int is less than INT_MAX.
4846 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4847 harmful) conversions of unsigned short to int.
4848 (lisp_data_to_selection_data): Don't assume that integers
4849 in the range -65535 through -1 fit in an X unsigned short.
4850 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4851 result parameters unless successful. Rely on cons_to_unsigned
4852 to report problems with elements; the old code wasn't right anyway.
4853 (x_check_property_data): Check for int overflow; we cannot use
4854 a wider type due to X limits.
4855 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4857 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4859 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4860 (x_term_init): Check for size calculation overflow.
4861 (x_color_cells): Don't store size until memory allocation succeeds.
4862 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4863 Don't assume alloca size is less than MAX_ALLOCA.
4864 (x_term_init): Don't assume length fits in int (sprintf is limited
4867 Use ptrdiff_t for composition IDs.
4868 * character.c (lisp_string_width):
4869 * composite.c (composition_table_size, n_compositions)
4870 (get_composition_id, composition_gstring_from_id):
4871 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4872 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4873 * window.c (Frecenter):
4874 Use ptrdiff_t, not int, for composition IDs.
4875 * composite.c (get_composition_id): Check for integer overflow.
4876 * composite.h: Adjust prototypes to match the above changes.
4878 Use ptrdiff_t for hash table indexes.
4879 * category.c (hash_get_category_set):
4880 * ccl.c (ccl_driver):
4881 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4882 * coding.c (coding_system_charset_list, detect_coding_system):
4883 * coding.h (struct coding_system.id):
4884 * composite.c (get_composition_id, gstring_lookup_cache):
4885 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4886 * image.c (xpm_get_color_table_h):
4887 * lisp.h (hash_lookup, hash_put):
4888 * minibuf.c (Ftest_completion):
4889 Use ptrdiff_t for hash table indexes, not int (which is too
4890 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4891 32-bit --with-wide-int hosts).
4893 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4894 Add a FIXME comment about memory leaks.
4895 (syms_of_charset): Don't assume xmalloc returns.
4897 Don't assume that stated character widths fit in int.
4898 * character.c (Fchar_width, c_string_width, lisp_string_width):
4899 * character.h (CHAR_WIDTH):
4900 * indent.c (MULTIBYTE_BYTES_WIDTH):
4901 Use sanitize_char_width to avoid undefined and/or bad behavior
4902 with outlandish widths.
4903 * character.h (sanitize_tab_width): Rename from sanitize_width,
4904 now that we have two such functions. All uses changed.
4905 (sanitize_char_width): New inline function.
4907 Don't assume that tab-width fits in int.
4908 * character.h (sanitize_width): New inline function.
4909 (SANE_TAB_WIDTH): New macro.
4910 (ASCII_CHAR_WIDTH): Use it.
4911 * indent.c (sane_tab_width): Remove. All uses replaced by
4912 SANE_TAB_WIDTH (current_buffer).
4913 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4915 * fileio.c: Integer overflow issues with file modes.
4916 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4918 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4919 Remove unreachable code.
4920 (read_hex, load_charset_map_from_file): Check for integer overflow.
4922 * xterm.c: Don't go over XClientMessageEvent limit.
4923 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4924 (x_send_scroll_bar_event): Likewise. Check that the size does not
4925 exceed limits imposed by XClientMessageEvent, as well as the usual
4926 ptrdiff_t and size_t limits.
4928 * keyboard.c: Overflow, signedness and related fixes.
4929 (make_lispy_movement): Use same integer type in forward decl
4930 that is used in the definition.
4931 (read_key_sequence, keyremap_step):
4932 Change bufsize argument back to int, undoing my 2011-03-30 change.
4933 We prefer signed types, and int is wide enough here.
4934 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4935 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4936 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4937 length, not size_t. Use ptrdiff_t for index, not int.
4938 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4939 possibility of integer overflow.
4941 Overflow, signedness and related fixes for images.
4943 * dispextern.h (struct it.stack[0].u.image.image_id)
4944 (struct_it.image_id, struct image.id, struct image_cache.size)
4945 (struct image_cache.used, struct image_cache.ref_count):
4946 * gtkutil.c (update_frame_tool_bar):
4947 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4948 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4949 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4950 * nsmenu.m (update_frame_tool_bar):
4951 * xdisp.c (calc_pixel_width_or_height):
4952 * xfns.c (image_cache_refcount):
4953 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4954 on typical 64-bit hosts.
4956 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4957 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4958 Omit unnecessary casts to int.
4959 (parse_image_spec): Check that integers fall into 'int' range
4960 when the callers expect that.
4961 (image_ascent): Redo ascent calculation to avoid int overflow.
4962 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4963 (lookup_image): Remove unnecessary tests.
4964 (xbm_image_p): Locals are now of int, not EMACS_INT,
4965 since parse_image_check makes sure they fit into int.
4966 (png_load, gif_load, svg_load_image):
4967 Prefer int to unsigned where either will do.
4968 (tiff_handler): New function, combining the cores of the
4969 old tiff_error_handler and tiff_warning_handler.
4970 This function is rewritten to use vsnprintf and thereby avoid
4971 stack buffer overflows. It uses only the features of vsnprintf
4972 that are common to both POSIX and native Microsoft.
4973 (tiff_error_handler, tiff_warning_handler): Use it.
4974 (tiff_load, gif_load, imagemagick_load_image):
4975 Don't assume :index value fits in 'int'.
4976 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4977 (imagemagick_load_image): Check that crop parameters fit into
4978 the integer types that MagickCropImage accepts. Don't assume
4979 Vimagemagick_render_type has a nonnegative value. Don't assume
4980 size_t fits in 'long'.
4981 (gs_load): Use printmax_t to print the widest integers possible.
4982 Check for integer overflow when computing image height and width.
4984 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4986 * xdisp.c (redisplay_window): Don't force window start if point
4987 will be invisible in the resulting window. (Bug#9324)
4989 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4991 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4992 the display spec is of the form `(space ...)'.
4993 (handle_display_spec): Return the value returned by
4994 handle_single_display_spec, not just 1 or zero.
4995 (handle_single_display_spec): If the display spec is of the form
4996 `(space ...)', and specifies display in the text area, return 2
4998 (try_cursor_movement): Check for the need to scroll more
4999 accurately, and prefer exact match for point under bidi.
5000 Don't advance `row' beyond the last row of the window.
5002 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5003 into disp_prop; all users changed.
5005 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5006 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5007 for the text covered by the display property.
5009 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5011 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5012 Change return value to nil.
5013 (Frecord_buffer): Delete unused function.
5015 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5017 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5018 buffers, return left-to-right.
5019 (set_cursor_from_row): Consider candidate row a win if its glyph
5020 represents a newline and point is on that newline. Fixes cursor
5021 positioning on the newline at EOL of R2L text within L2R
5022 paragraph, and vice versa.
5023 (try_cursor_movement): Check continued rows, in addition to
5024 continuation rows. Fixes unwarranted scroll when point enters a
5025 continued line of R2L text within an L2R paragraph, or vice versa.
5026 (cursor_row_p): Consider the case of point being equal to
5027 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5028 from the end of a short line to the beginning of a continued line
5029 of R2L text within L2R paragraph.
5030 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5031 composed characters.
5033 * bidi.c (bidi_check_type): Use xassert.
5034 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5037 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5039 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5042 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5044 * nsfont.m (ns_otf_to_script): Fix typo.
5046 2011-08-22 Kenichi Handa <handa@m17n.org>
5048 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5049 extra slot even if the purpose is char-code-property-table.
5051 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5053 * xdisp.c (redisplay_window): When computing centering_position,
5054 account for the height of the header line. (Bug#8874)
5056 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5057 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5058 candidate is selected by the mouse, and that candidate has a
5059 composed character under the mouse.
5061 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5062 coordinates reported by pos-visible-in-window-p for a composed
5063 character in column zero.
5065 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5067 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5069 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5071 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5072 consider it a hit if to_charpos is anywhere in the range of the
5073 composed buffer positions.
5075 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5077 * image.c (gif_load): Don't assume that each subimage has the same
5078 dimensions as the base image. Handle disposal method that is
5079 "undefined" by the gif spec (Bug#9335).
5081 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5083 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5084 (Fcondition_case): Document `debug' symbol in error handler.
5086 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5088 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5089 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5090 from an Org mode buffer to a Speedbar frame.
5092 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5093 a composition, take its buffer position from IT->cmp_it.charpos.
5094 Fixes cursor positioning at the beginning of a line that begins
5095 with a composed character.
5097 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5099 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5100 character bidirectional type, use STRONG_L instead. Fixes crashes
5101 in a buffer produced by `describe-categories'.
5103 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5104 members before the level stack, so they would be saved and
5105 restored when copying iterator state. Fixes incorrect reordering
5106 around TABs covered by display properties.
5108 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5110 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5112 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5114 * eval.c (internal_condition_case, internal_condition_case_1)
5115 (internal_condition_case_2, internal_condition_case_n):
5116 Remove unnecessary aborts (Bug#9081).
5118 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5120 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5121 has no `load' handler, try opening the file locally. (Bug#9311)
5123 2011-08-16 Ken Brown <kbrown@cornell.edu>
5125 * gmalloc.c: Expand comment.
5127 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5129 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5130 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5132 2011-08-16 Ken Brown <kbrown@cornell.edu>
5134 Fix memory allocation problems in Cygwin build (Bug#9273).
5136 * unexcw.c ( __malloc_initialized): Declare external variable.
5137 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5139 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5141 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5143 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5145 [CYGWIN] (special_realloc): New function.
5146 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5147 requests to realloc storage in the static heap.
5149 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5151 * bidi.c (bidi_initialize): Remove unused local.
5153 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5156 * biditype.h: Remove file.
5157 * makefile.w32-in ($(BLD)/bidi.$(O)):
5158 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5160 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5162 * chartab.c: Improve commentary for the uniprop_table API.
5164 * bidi.c (bidi_paragraph_init): Support zero value of
5165 bidi_ignore_explicit_marks_for_paragraph_level.
5166 (bidi_initialize): Use uniprop_table instead of including
5167 biditype.h and bidimirror.h.
5169 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5170 coordinates of the iterator when restoring from ppos_it.
5173 2011-08-14 Kenichi Handa <handa@m17n.org>
5175 * process.c (create_process): Call setup_process_coding_systems
5176 after the pid of the process is set to -1 (Bug#8162).
5178 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5180 * xdisp.c (move_it_in_display_line_to): Don't invoke
5181 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5182 ppos_it. Fixes vertical cursor motion when line beginning is
5183 covered by an image. (Bug#9296)
5185 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5187 * nsterm.h (ns_run_ascript): Declare.
5188 (NSAPP_DATA2_RUNASSCRIPT): Define.
5190 * nsfns.m (as_script, as_result, as_status): New static variables.
5191 (ns_run_ascript): New function.
5192 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5193 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5194 the event loop. Get status from as_status (Bug#7276).
5196 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5197 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5198 the event loop (Bug#7276).
5200 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5202 * gnutls.c (QCgnutls_bootprop_priority)
5203 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5204 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5205 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5206 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5207 (QCgnutls_bootprop_verify_hostname_error)
5208 (QCgnutls_bootprop_callbacks_verify): Rename from
5209 Qgnutls_bootprop_..., all uses changed.
5211 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5214 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5216 * xfaces.c (Qframe_set_background_mode): Now static.
5217 * dispextern.h (Qframe_set_background_mode): Remove decl.
5219 * process.c (Fnetwork_interface_info): Declare local only if needed.
5221 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5223 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5224 (Fnetwork_interface_list): Allocate in increments of bytes instead
5225 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5226 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5228 (struct ifflag_def): notrailers is smart on OSX.
5229 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5230 Get hardware address with getifaddrs if available.
5232 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5234 * xdisp.c (iterate_out_of_display_property): xassert that
5235 IT->position is set to within IT->object's boundaries. Break from
5236 the loop as soon as EOB is reached; avoids infloops in redisplay
5237 when IT->position is set up wrongly due to some bug.
5238 Set IT->current to match the bidi iterator unconditionally.
5239 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5240 entry. Force push_it to save on the stack the current
5241 buffer/string position, to be restored by pop_it. Fix flags in
5242 the iterator structure wrt the object coming from a display
5243 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5244 properties. (Bug#9284)
5246 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5248 * fontset.c (fontset_get_font_group): Add proper type checks.
5251 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5253 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5254 and LC_VERSION_MIN_MACOSX.
5255 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5256 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5258 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5260 * xdisp.c (forward_to_next_line_start): Allow to use the
5261 no-display-properties-and-no-overlays under bidi display.
5262 Set disp_pos in the bidi iterator to avoid searches for display
5263 properties and overlays.
5265 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5267 * editfns.c (Fset_time_zone_rule): Document relationship with the
5270 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5271 the font entity extracted from the cache (Bug#8109).
5273 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5275 * composite.c (autocmp_chars): Don't reset point. That is done by
5276 restore_point_unwind (Bug#5984).
5278 2011-08-07 Juri Linkov <juri@jurta.org>
5280 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5281 to show the arg `TIME' instead of `TIMEVAL'.
5283 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5285 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5286 display property strides EOL and includes a newline, as in
5287 longlines-mode. (Bug#9254)
5288 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5289 word-wrap under bidirectional display. (Bug#9224)
5291 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5292 is non-zero, even if the data buffer is NULL. Fixes a crash in
5293 vertical-motion with longlines-mode. (Bug#9254)
5295 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5297 * bidi.c <bidi_cache_total_alloc>: Now static.
5298 (bidi_initialize): Initialize bidi_cache_total_alloc.
5300 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5303 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5304 amount allocated this far in `bidi_cache_total_alloc'.
5305 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5306 non-zero, only free the data buffer without restoring the cache
5307 contents. All callers changed.
5309 * dispextern.h (bidi_unshelve_cache): Update prototype.
5311 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5312 (move_it_in_display_line, move_it_to)
5313 (move_it_vertically_backward, move_it_by_lines): Replace the call
5314 to xfree to an equivalent call to bidi_unshelve_cache.
5315 (move_it_in_display_line_to): Fix logic of returning
5316 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5318 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5320 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5321 came from a string character with a `cursor' property. (Bug#9229)
5323 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5325 * Makefile.in (LIB_PTHREAD): New variable.
5326 (LIBES): Add LIB_PTHREAD (Bug#9216).
5328 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5329 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5331 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5333 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5335 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5337 * xterm.c (x_find_topmost_parent): New function.
5338 (x_set_frame_alpha): Find topmost parent window with
5339 x_find_topmost_parent and set the property there also (bug#9181).
5340 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5342 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5344 * callproc.c (Fcall_process): Avoid vfork clobbering
5345 the local vars buffer, coding_systems, current_dir.
5347 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5349 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5351 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5353 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5354 so that it is not optimized away.
5356 * xdisp.c (compute_display_string_pos): Remove unused local.
5358 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5360 Fix slow cursor motion and scrolling in large buffers with
5361 selective display, like Org Mode buffers. (Bug#9218)
5363 * dispextern.h (struct bidi_it): New member disp_prop_p.
5365 * xdisp.c: Remove one-slot cache of display string positions.
5366 (compute_display_string_pos): Accept an additional argument
5367 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5368 for a display string or property. If found, set DISP_PROP_P
5371 * bidi.c (bidi_fetch_char): Accept an additional argument
5372 DISP_PROP_P, and pass it to compute_display_string_pos.
5373 Only handle text covered by a display string if DISP_PROP_P is returned
5374 non-zero. All callers of bidi_fetch_char changed.
5376 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5378 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5380 2010-12-03 Don March <don@ohspite.net>
5382 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5383 last character M-[char] is translated to ESC [char] (bug#7541).
5385 2011-08-02 Kenichi Handa <handa@m17n.org>
5387 * lisp.h (uniprop_table): Extern it.
5389 * chartab.c (uniprop_table): Make it non-static.
5391 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5393 * xdisp.c (forward_to_next_line_start): Accept additional argument
5394 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5396 (reseat_at_next_visible_line_start): Use the bidi iterator state
5397 returned by forward_to_next_line_start to restore the state of
5398 it->bidi_it after backing up to previous newline. (Bug#9212)
5400 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5402 * regex.c (re_comp): Protoize.
5403 (re_exec): Fix return type.
5404 (regexec): Fix type of `ret'. (Bug#9203)
5406 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5408 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5409 This is needed if max-image-size is a floating-point number.
5411 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5413 * print.c (print_object): Print empty symbol as ##.
5415 * lread.c (read1): Read ## as empty symbol.
5417 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5419 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5420 setting frame foreground color (Bug#9175).
5421 (x_set_background_color): Likewise.
5423 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5424 contents (Bug#9176).
5425 (EmacsTooltip -init): Remove bezels and add shadows to
5428 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5429 or scroll bar (Bug#8470).
5431 * nsfont.m (nsfont_open): Remove assignment to voffset and
5432 unnecessary vars hshink, expand, hd, full_height, min_height.
5433 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5435 * nsterm.h (nsfont_info): Remove voffset field.
5437 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5439 Implement strike-through and overline on NextStep (Bug#8863).
5441 * nsfont.m (nsfont_open): Use underline position provided by font,
5442 instead of hard-coded value of 2.
5443 (nsfont_draw): Call ns_draw_text_decoration instead.
5445 * nsterm.h: Add declaration for ns_draw_text_decoration.
5447 * nsterm.m (ns_draw_text_decoration): New function for drawing
5448 underline, overline, and strike-through.
5449 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5450 ns_draw_text_decoration. Change treatment of cursor drawing to
5451 accommodate underlining, etc.
5453 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5455 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5458 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5460 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5461 Without this fix, if a signal arrives just after memory fills up,
5462 'malloc' might be invoked reentrantly.
5464 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5465 In other words, assume that every image size is allowed, on non-X
5466 hosts. This assumption is probably wrong, but it lets Emacs compile.
5468 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5470 * regex.c (re_iswctype): Convert return values to boolean.
5472 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5474 * xdisp.c (compute_display_string_pos): Don't use cached display
5475 string position if the buffer had its restriction changed.
5478 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5480 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5482 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5484 Integer signedness and overflow and related fixes. (Bug#9079)
5486 * bidi.c: Integer size and overflow fixes.
5487 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5488 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5489 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5490 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5491 (bidi_find_other_level_edge):
5492 Use ptrdiff_t instead of EMACS_INT where either will do.
5493 This works better on 32-bit hosts configured --with-wide-int.
5494 (bidi_cache_ensure_space): Check for size-calculation overflow.
5495 Use % rather than repeated addition, for better worst-case speed.
5496 Don't set bidi_cache_size until after xrealloc returns, because it
5498 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5499 (bidi_cache_ensure_space): Also check that the bidi cache size
5500 does not exceed that of the largest Lisp string or buffer. See Eli
5501 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5503 * alloc.c (__malloc_size_t): Remove.
5504 All uses replaced by size_t. See Andreas Schwab's note
5505 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5507 * image.c: Improve checking for integer overflow.
5508 (check_image_size): Assume that f is nonnull, since
5509 it is always nonnull in practice. This is one less thing to
5510 worry about when checking for integer overflow later.
5511 (x_check_image_size): New function, which checks for integer
5512 overflow issues inside X.
5513 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5514 This removes the need for a memory_full check.
5515 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5516 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5517 (xbm_read_bitmap_data): Change locals back to 'int', since
5518 their values must fit in 'int'.
5519 (xpm_load_image, png_load, tiff_load):
5520 Invoke x_create_x_image_and_pixmap earlier,
5521 to avoid much needless work if the image is too large.
5522 (tiff_load): Treat overly large images as if
5523 x_create_x_image_and_pixmap failed, not as malloc failures.
5524 (gs_load): Use x_check_image_size.
5526 * gtkutil.c: Omit integer casts.
5527 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5528 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5530 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5532 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5533 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5534 would wrongly return t on a 64-bit host.
5536 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5537 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5538 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5539 and therefore cause GCC to emit a bogus diagnostic in some cases.
5541 * image.c: Integer signedness and overflow and related fixes.
5542 This is not an exhaustive set of fixes, but it's time to
5543 record what I've got.
5544 (lookup_pixel_color, check_image_size): Remove redundant decls.
5545 (check_image_size): Don't assume that arbitrary EMACS_INT values
5546 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5547 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5548 (tiff_load, imagemagick_load_image):
5549 Check for overflow in size calculations.
5550 (x_create_x_image_and_pixmap): Remove unnecessary test for
5551 xmalloc returning NULL; that can't happen.
5552 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5553 (xpm_color_bucket): Use better integer hashing function.
5554 (xpm_cache_color): Don't possibly over-allocate memory.
5555 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5556 (gif_memory_source):
5557 Use ptrdiff_t, not int or size_t, to record sizes.
5558 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5559 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5560 either works, as we prefer signed integers.
5561 (tiff_read_from_memory, tiff_write_from_memory):
5562 Return tsize_t, not size_t, since that's what the TIFF API wants.
5563 (tiff_read_from_memory): Don't fail simply because the read would
5564 go past EOF; instead, return a short read.
5565 (tiff_load): Omit no-longer-needed casts.
5566 (Fimagemagick_types): Don't assume size fits into 'int'.
5568 Improve hashing quality when configured --with-wide-int.
5569 * fns.c (hash_string): New function, taken from sxhash_string.
5570 Do not discard information about ASCII character case; this
5571 discarding is no longer needed.
5572 (sxhash-string): Use it. Change sig to match it. Caller changed.
5573 * lisp.h: Declare it.
5574 * lread.c (hash_string): Remove, since we now use fns.c's version.
5575 The fns.c version returns a wider integer if --with-wide-int is
5576 specified, so this should help the quality of the hashing a bit.
5578 * emacs.c: Integer overflow minor fix.
5579 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5580 Define only if GNU_LINUX.
5581 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5583 * dispnew.c: Integer signedness and overflow fixes.
5584 Remove unnecessary forward decls, that were a maintenance hassle.
5585 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5587 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5588 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5589 (prepare_desired_row, line_draw_cost):
5590 Use int, not unsigned, where either works.
5591 (save_current_matrix, restore_current_matrix):
5592 Use ptrdiff_t, not size_t, where either works.
5593 (init_display): Check for overflow more accurately, and without
5594 relying on undefined behavior.
5596 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5597 Remove, replacing with the new symbols in lisp.h. All uses changed.
5598 * fileio.c (make_temp_name):
5599 * filelock.c (lock_file_1, lock_file):
5600 * xdisp.c (message_dolog):
5601 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5602 Use pMd etc. instead.
5603 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5604 replacing the pWIDE etc. symbols removed from editfns.c.
5606 * keyboard.h (num_input_events): Now uintmax_t.
5607 This is (very slightly) less likely to mess up due to wraparound.
5610 * buffer.c: Integer signedness fixes.
5611 (alloc_buffer_text, enlarge_buffer_text):
5612 Use ptrdiff_t rather than size_t when either will do, as we prefer
5615 * alloc.c: Integer signedness and overflow fixes.
5616 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5617 (__malloc_size_t): Default to size_t, not to int.
5618 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5619 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5620 Prefer ptrdiff_t to size_t when either would do, as we prefer
5622 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5623 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5624 Now const. Initialize with values that are in range even if char
5626 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5627 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5628 These functions do the right thing with sizes > 2**32.
5629 (check_depth): Now ptrdiff_t, not int.
5630 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5631 Adjust to new way of storing sizes. Check for size overflow bugs
5633 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5634 slightly wrong anyway, as it missed one instance of
5635 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5636 (refill_memory_reserve): Omit needless cast to size_t.
5637 (mark_object_loop_halt): Mark as externally visible.
5639 * xselect.c: Integer signedness and overflow fixes.
5640 (Fx_register_dnd_atom, x_handle_dnd_message):
5641 Use ptrdiff_t, not size_t, since we prefer signed.
5642 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5643 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5644 x_dnd_atoms_size and x_dnd_atoms_length.
5646 * doprnt.c: Prefer signed to unsigned when either works.
5648 * doprnt.c (doprnt):
5650 * xdisp.c (vmessage):
5651 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5652 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5653 prefer signed arithmetic to avoid comparison confusion.
5654 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5655 but is a bit tricky.
5657 Assume freestanding C89 headers, string.h, stdlib.h.
5658 * data.c, doprnt.c, floatfns.c, print.c:
5659 Include float.h unconditionally.
5660 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5661 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5662 * regex.c: Likewise for stddef.h, string.h.
5663 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5664 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5665 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5666 (STDC_HEADERS): Remove obsolete defines.
5667 * sysdep.c: Include limits.h unconditionally.
5669 Assume support for memcmp, memcpy, memmove, memset.
5670 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5671 * regex.c (memcmp, memcpy):
5672 Remove; we assume C89 now.
5674 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5675 (__malloc_safe_bcopy): Remove; no longer needed.
5677 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5678 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5679 well either way, and we prefer signed to unsigned.
5681 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5683 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5684 closes the connection while we're reading (bug#9182).
5686 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5688 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5689 are specified (Bug#9168).
5691 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5693 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5694 Found by GCC static checking and --with-wide-int on a 32-bit host.
5696 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5698 * xdisp.c (compute_display_string_pos): Fix logic of caching
5699 previous display string position. Initialize cached_prev_pos to
5700 -1. Fixes slow-down at the beginning of a buffer.
5702 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5704 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5705 for attrs[LFACE_FONTSET_INDEX].
5707 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5709 * xml.c (parse_region): Remove unused local
5710 that was recently introduced.
5712 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5714 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5715 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5717 * xdisp.c (move_it_in_display_line_to): Record the best matching
5718 position for TO_CHARPOS while scanning the line, and restore it on
5719 exit if none of the characters scanned was an exact match.
5720 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5721 when exact match is impossible due to invisible text, and the
5722 lines are truncated.
5724 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5726 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5729 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5731 Fix a significant slow-down of cursor motion with C-n, C-p,
5732 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5733 auto-repeat under bidi redisplay in fontified buffers.
5734 * xdisp.c (compute_stop_pos_backwards): New function.
5735 (next_element_from_buffer): Call compute_stop_pos_backwards to
5736 find a suitable prev_stop when we find ourselves before
5738 (reseat): Don't look for prev_stop, as that could mean a very long
5740 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5741 <cached_disp_overlay_modiff>: Cache for last found display string
5743 (compute_display_string_pos): Return the cached position if asked
5744 about the same buffer in the same area of character positions, and
5745 the buffer wasn't changed since the time the display string
5746 position was cached.
5748 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5750 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5751 is an integer, which is important for empty lines. (Bug#9149)
5753 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5755 * frame.c (Fmodify_frame_parameters): In tty case, update the
5756 default face if necessary (Bug#4238).
5758 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5760 * editfns.c (Fstring_to_char): No need to explain what a character
5761 is in the docstring (Bug#6576).
5763 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5765 * xml.c (parse_region): Make sure we always return a tree.
5767 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5769 * xml.c (parse_region): If a document contains only comments,
5772 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5774 * xml.c (make_dom): Return comments, too.
5776 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5779 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5780 and the surrounding thread.
5781 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5782 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5783 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5785 * s/openbsd.h (BROKEN_SIGIO): Define.
5786 * unexelf.c (unexec) [__OpenBSD__]:
5787 Don't update the .mdebug section of the Alpha COFF symbol table.
5789 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5791 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5794 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5796 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5797 This fixes some race conditions on the permissions of any newly
5800 * alloc.c (valid_pointer_p): Use pipe, not open.
5801 This fixes some permissions issues when debugging.
5803 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5804 If fchown fails to set both uid and gid, try to set just gid,
5805 as that is sometimes allowed. Adjust the file's mode to eliminate
5806 setuid or setgid bits that are inappropriate if fchown fails.
5808 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5810 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5811 to compare Lisp_Objects.
5812 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5813 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5814 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5816 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5818 * lread.c (read_integer): Unread even EOF character.
5819 (read1): Likewise. Properly record start position of symbol.
5821 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5822 symbol character follows.
5824 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5826 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5827 This works around a problem with the previous change to Fcopy_file.
5828 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5829 and without this change, GCC might complain about discarding
5830 fchown's return value.
5832 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5834 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5836 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5838 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5840 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5842 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5843 it's used from the C level.
5845 * process.c: Use the same condition for POLL_FOR_INPUT in both
5846 keyboard.c and process.c (bug#1858).
5848 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5850 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5851 (Fgnutls_boot): Use it.
5853 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5855 * doc.c (Fsubstitute_command_keys): Revert last change.
5857 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5859 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5860 quotes the next character, and doesn't affect other longer
5861 sequences (bug#8935).
5863 * lread.c (syms_of_lread): Clarify that is isn't only
5864 `eval-buffer' and `eval-defun' that's affected by
5865 `lexical-binding' (bug#8460).
5867 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5869 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5870 bidi redisplay when a line includes both an image and is truncated.
5872 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5874 Fix minor problems found by static checking.
5875 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5876 (elsz): Now a signed constant, not a size_t var. We prefer signed
5877 types to unsigned, to avoid integer comparison confusion. Without
5878 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5879 "cannot optimize loop, the loop counter may overflow", a symptom
5881 * indent.c (Fvertical_motion): Mark locals as initialized.
5882 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5884 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5886 * search.c (Fre_search_backward): Mention `case-fold-search' in
5887 all the re_search_* functions (bug#8138).
5889 * keyboard.c (Fopen_dribble_file): Document when the file is
5892 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5894 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5897 Support bidi reordering of display and overlay strings.
5898 * xdisp.c (compute_display_string_pos)
5899 (compute_display_string_end): Accept additional argument STRING.
5900 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5901 (reseat_to_string): Initialize bidi_it->string.s and
5902 bidi_it->string.schars.
5903 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5904 NULL (avoids a crash in bidi_paragraph_init).
5905 Initialize itb.string.lstring.
5906 (init_iterator): Call bidi_init_it only of a valid
5907 buffer position was specified. Initialize paragraph_embedding to
5909 (reseat_to_string): Initialize the bidi iterator.
5910 (display_string): If we need to ignore text properties of
5911 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5912 original value of -1 will not work with bidi.)
5913 (compute_display_string_pos): First arg is now struct
5914 `text_pos *'; all callers changed. Support display properties on
5916 (compute_display_string_end): Support display properties on Lisp
5918 (init_iterator, reseat_1, reseat_to_string): Initialize the
5919 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5920 when iterating on a string not from display properties).
5921 (compute_display_string_pos, compute_display_string_end):
5922 Fix calculation of the object to scan. Fixes an error when using
5924 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5925 base_level_stop; instead, set base_level_stop to BEGV.
5926 Fixes crashes in vertical-motion.
5927 (next_element_from_buffer): Improve commentary for when
5928 the iterator is before prev_stop.
5929 (init_iterator): Initialize bidi_p from the default value of
5930 bidi-display-reordering, not from buffer-local value. Use the
5931 buffer-local value only if initializing for buffer iteration.
5932 (handle_invisible_prop): Support invisible properties on strings
5933 that are being bidi-reordered.
5934 (set_iterator_to_next): Support bidi reordering of C strings and
5936 (next_element_from_string): Support bidi reordering of Lisp
5938 (handle_stop_backwards): Support Lisp strings as well.
5939 (display_string): Support display of R2L glyph rows.
5940 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5941 (init_iterator): Don't initialize it->bidi_p for strings
5943 (reseat_to_string): Initialize it->bidi_p for strings here.
5944 (next_element_from_string, next_element_from_c_string)
5945 (next_element_from_buffer): Add xassert's for correspondence
5946 between IT's object being iterated and it->bidi_it.string
5948 (face_before_or_after_it_pos): Support bidi iteration.
5949 (next_element_from_c_string): Handle the case of the first string
5950 character that is not the first one in the visual order.
5951 (get_visually_first_element): New function, refactored from common
5952 parts of next_element_from_buffer, next_element_from_string, and
5953 next_element_from_c_string.
5954 (tool_bar_lines_needed, redisplay_tool_bar)
5955 (display_menu_bar): Force left-to-right direction. Add a FIXME
5956 comment for making that be controlled by a user option.
5957 (push_it, pop_it): Save and restore the state of the
5958 bidi iterator. Save and restore the bidi_p flag.
5959 (pop_it): Iterate out of display property for string iteration as
5961 (iterate_out_of_display_property): Support iteration over strings.
5962 (handle_single_display_spec): Set up it->bidi_it for iteration
5963 over a display string, and call bidi_init_it.
5964 (handle_single_display_spec, next_overlay_string)
5965 (get_overlay_strings_1, push_display_prop): Set up the bidi
5966 iterator for displaying display or overlay strings.
5967 (forward_to_next_line_start): Don't use the shortcut if
5969 (back_to_previous_visible_line_start): If handle_display_prop
5970 pushed the iterator stack, restore the internal state of the bidi
5971 iterator by calling bidi_pop_it same number of times.
5972 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5973 and we are bidi-iterating, don't decrement the iterator position;
5974 instead, set the first_elt flag in the bidi iterator, to produce
5976 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5977 (push_display_prop): xassert that we are iterating a buffer.
5978 (push_it, pop_it): Save and restore paragraph_embedding member.
5979 (handle_single_display_spec, next_overlay_string)
5980 (get_overlay_strings_1, reseat_1, reseat_to_string)
5981 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5982 correctly. Don't assume unibyte strings are not bidi-reordered.
5983 (compute_display_string_pos)
5984 (compute_display_string_end): Fix handling the case of C string.
5985 (push_it, pop_it): Save and restore from_disp_prop_p.
5986 (handle_single_display_spec, push_display_prop): Set the
5987 from_disp_prop_p flag.
5988 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5989 (pop_it): Call iterate_out_of_display_property only if we are
5990 popping after iteration over a string that came from a display
5991 property. Fix a typo in popping stretch info. Add an assertion
5992 for verifying that the iterator position is in sync with the bidi
5994 (handle_single_display_spec, get_overlay_strings_1)
5995 (push_display_prop): Fix initialization of paragraph direction for
5996 string when that of the parent object is not yet determined.
5997 (reseat_1): Call bidi_init_it to resync the bidi
5998 iterator with IT's position. (Bug#7616)
5999 (find_row_edges): If ROW->start.pos gives position
6000 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6001 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6002 Reset the from_disp_prop_p flag.
6003 (SAVE_IT, RESTORE_IT): New macros.
6004 (pos_visible_p, face_before_or_after_it_pos)
6005 (back_to_previous_visible_line_start)
6006 (move_it_in_display_line_to, move_it_in_display_line)
6007 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6008 (try_scrolling, redisplay_window, display_line): Use them when
6009 saving a temporary copy of the iterator and restoring it back.
6010 (back_to_previous_visible_line_start, reseat_1)
6011 (init_iterator): Empty the bidi cache "stack".
6012 (move_it_in_display_line_to): If iterator ended up at
6013 EOL, but we never saw any buffer positions smaller than
6014 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6015 motion in bidi-reordered lines.
6016 (move_it_in_display_line_to): Record prev_method and prev_pos
6017 immediately before the call to set_iterator_to_next. Fixes cursor
6018 motion in bidi-reordered lines with stretch glyphs and strings
6019 displayed in margins. (Bug#8133) (Bug#8867)
6020 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6022 (pos_visible_p): Support positions in bidi-reordered lines.
6023 Save and restore bidi cache.
6025 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6026 (bidi_paragraph_info): Delete unused struct.
6027 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6028 (bidi_cache_start): New variable.
6029 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6031 (bidi_cache_fetch_state, bidi_cache_search)
6032 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6033 (bidi_cache_find, bidi_peek_at_next_level)
6034 (bidi_level_of_next_char, bidi_find_other_level_edge)
6035 (bidi_move_to_visually_next): Compare cache index with
6036 bidi_cache_start rather than with zero.
6037 (bidi_fetch_char): Accept new argument STRING; all callers
6038 changed. Support iteration over a string. Support strings with
6039 display properties. Support unibyte strings. Fix the type of
6040 `len' according to what STRING_CHAR_AND_LENGTH expects.
6041 (bidi_paragraph_init, bidi_resolve_explicit_1)
6042 (bidi_resolve_explicit, bidi_resolve_weak)
6043 (bidi_level_of_next_char, bidi_move_to_visually_next):
6044 Support iteration over a string.
6045 (bidi_set_sor_type, bidi_resolve_explicit_1)
6046 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6047 can now be zero (for strings); special values 0 and -1 were
6048 changed to -1 and -2, respectively.
6049 (bidi_char_at_pos): New function.
6050 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6051 Call it instead of FETCH_MULTIBYTE_CHAR.
6052 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6053 initialized to valid values.
6054 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6056 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6057 the test for valid cached positions. Fix the logic for looking up
6058 the sentinel state in the cache. GCPRO the Lisp string we are
6060 (bidi_push_it, bidi_pop_it): New functions.
6061 (bidi_initialize): Initialize the bidi cache start stack pointer.
6062 (bidi_cache_ensure_space): New function, refactored from part of
6063 bidi_cache_iterator_state. Don't assume the required size is just
6064 one BIDI_CACHE_CHUNK away.
6065 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6066 (bidi_count_bytes, bidi_char_at_pos): New functions.
6067 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6068 always valid if bidi_cache_idx is valid.
6069 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6070 is valid if it's going to be used.
6071 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6072 (bidi_cache_fetch_state, bidi_cache_search)
6073 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6074 (bidi_cache_iterator_state, bidi_cache_find)
6075 (bidi_find_other_level_edge, bidi_cache_start_stack):
6076 All variables related to cache indices are now EMACS_INT.
6078 * dispextern.h (struct bidi_string_data): New structure.
6079 (struct bidi_it): New member `string'. Make flag members be 1-bit
6080 fields, and put them last in the struct.
6081 (compute_display_string_pos, compute_display_string_end):
6083 (bidi_push_it, bidi_pop_it): Add prototypes.
6084 (struct iterator_stack_entry): New members bidi_p,
6085 paragraph_embedding, and from_disp_prop_p.
6086 (struct it): Member bidi_p is now a bit field 1 bit wide.
6087 (bidi_shelve_cache, bidi_unshelve_cache):
6090 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6091 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6092 and vector-like objects.
6094 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6095 cache around display iteration.
6097 * window.c (Fwindow_end, window_scroll_pixel_based)
6098 (displayed_window_lines, Frecenter): Save and restore the bidi
6099 cache around display iteration.
6101 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6103 * editfns.c (Fdelete_region): Clarify the use of the named
6104 parameters (bug#6788).
6106 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6108 * indent.c (Fvertical_motion): Set and restore w->pointm when
6109 saving and restoring the window's buffer (Bug#9006).
6111 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6113 * editfns.c (Fstring_to_char): Clarify just what is returned
6114 (bug#6576). Text by Eli Zaretskii.
6116 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6118 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6120 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6122 * buffer.c (mmap_find): Fix a typo.
6124 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6126 Fix execution of x selection hooks.
6127 * xselect.c (Qx_lost_selection_functions)
6128 (Qx_sent_selection_functions): New vars.
6129 (syms_of_xselect): DEFSYM them.
6130 (x_handle_selection_request): Pass Qx_sent_selection_functions
6131 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6132 (x_handle_selection_clear,x_clear_frame_selections):
6133 Pass Qx_lost_selection_functions rather than
6134 Vx_lost_selection_functions to Frun_hook_with_args.
6136 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6138 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6139 The old code sometimes used this field without initializing it.
6141 * alloc.c (gc_sweep): Don't read past end of array.
6142 In theory, the old code could also have corrupted Emacs internals,
6143 though it'd be very unlikely.
6145 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6147 * character.c (Fcharacterp): Don't advertise optional ignored
6148 argument. (Bug#4026)
6150 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6152 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6155 * window.c (Fset_window_start): Doc fix (bug#4199).
6156 (Fset_window_hscroll): Ditto.
6158 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6160 Fix minor new problems caught by GCC 4.6.1.
6161 * term.c (init_tty): Remove unused local.
6162 * xsettings.c (store_monospaced_changed): Define this function only
6163 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6166 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6168 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6170 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6172 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6173 are the mini-buffer and the echo area (bug#3320).
6175 * term.c (init_tty): Remove support for supdup, c10 and perq
6176 terminals, which are no longer supported (bug#1482).
6178 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6180 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6182 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6184 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6185 for non-popups (Bug#3642).
6187 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6189 * alloc.c (reset_malloc_hooks): Protoize.
6190 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6191 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6192 * cm.c (losecursor): Likewise.
6193 * data.c (fmod): Likewise.
6194 * dispnew.c (swap_glyphs_in_rows): Likewise.
6195 * emacs.c (memory_warning_signal): Likewise.
6196 * floatfns.c (float_error): Likewise.
6197 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6198 (otf_open, font_otf_capability, generate_otf_features)
6199 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6201 * image.c (pbm_read_file): Likewise.
6202 * indent.c (string_display_width): Likewise.
6203 * intervals.c (check_for_interval, search_for_interval)
6204 (inc_interval_count, count_intervals, root_interval)
6205 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6206 * lread.c (defalias): Likewise.
6207 * ralloc.c (r_alloc_check): Likewise.
6208 * regex.c (set_image_of_range_1, set_image_of_range)
6209 (regex_grow_registers): Likewise.
6210 * sysdep.c (strerror): Likewise.
6211 * termcap.c (valid_filename_p, tprint, main): Likewise.
6212 * tparam.c (main): Likewise.
6213 * unexhp9k800.c (run_time_remap, save_data_space)
6214 (update_file_ptrs, read_header, write_header, calculate_checksum)
6215 (copy_file, copy_rest, display_header): Likewise.
6216 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6218 * xdisp.c (check_it): Likewise.
6219 * xfaces.c (register_color, unregister_color, unregister_colors):
6221 * xfns.c (print_fontset_result): Likewise.
6222 * xrdb.c (member, fatal, main): Likewise.
6224 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6226 Fix minor problems found by static checking (Bug#9031).
6227 * chartab.c (char_table_set_range, map_sub_char_table):
6228 Remove unused locals.
6229 (uniprop_table): Now static.
6230 * composite.c (_work_char): Remove unused static var.
6232 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6234 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6236 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6238 * gtkutil.c (qttip_cb): Remove code without function.
6240 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6242 * w32.c (pthread_sigmask): New stub.
6244 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6246 Use pthread_sigmask, not sigprocmask (Bug#9010).
6247 sigprocmask is portable only for single-threaded applications, and
6248 Emacs can be multi-threaded when it uses GTK.
6249 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6251 * callproc.c (Fcall_process):
6252 * process.c (create_process):
6253 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6254 Use pthread_sigmask, not sigprocmask.
6256 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6258 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6259 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6262 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6264 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6265 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6266 (xg_hide_tooltip): Fix comment.
6268 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6269 in registerServicesMenuSendTypes.
6270 (validRequestorForSendType): Don't check ns_return_types.
6272 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6275 2011-07-08 Jason Rumney <jasonr@gnu.org>
6277 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6278 SH_SHOW for hidden windows (Bug#5482).
6280 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6281 frame struct members of non-existent frames (Bug#6284).
6283 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6285 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6286 variable firstTime not needed on OSX >= 10.6.
6287 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6288 >= 10.5. Use setKnobProportion, setDoubleValue.
6290 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6291 (MAC_OS_X_VERSION_10_5): Define if not defined.
6292 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6293 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6294 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6296 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6297 cString and lossyCString on OSX >= 10.4
6299 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6300 sizeToFit on OSX >= 10.2.
6302 * nsimage.m (allocInitFromFile): Don't use deprecated method
6303 bestRepresentationForDevice on OSX >= 10.6.
6305 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6308 * emacs.c: Declare unexec_init_emacs_zone.
6310 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6312 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6314 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6315 on svcsMenu (Bug#8842).
6317 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6319 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6321 * nsterm.m (QUTF8_STRING): Declare.
6322 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6323 (validRequestorForSendType): Return type is (id).
6324 Change indexOfObjectIdenticalTo to indexOfObject.
6325 Check if we have local selection before returning self (Bug#8842).
6326 (writeSelectionToPasteboard): Put local selection into paste board
6327 if we have a local selection (Bug#8842).
6328 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6330 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6331 (ns_get_local_selection): Declare.
6333 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6335 * keymap.c (describe_map_tree): Don't insert a double newline at
6336 the end of the buffer (bug#1169) and return whether we inserted
6339 * callint.c (Fcall_interactively): Change "reading args" to
6340 "providing args" to try to clarify what it does (bug#1010).
6342 2011-07-07 Kenichi Handa <handa@m17n.org>
6344 * composite.c (composition_compute_stop_pos): Ignore a static
6345 composition starting before CHARPOS (Bug#8915).
6347 * xdisp.c (handle_composition_prop): Likewise.
6349 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6351 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6354 2011-07-07 Kenichi Handa <handa@m17n.org>
6356 * character.h (unicode_category_t): New enum type.
6358 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6359 (Qchar_code_property_table): New variable.
6360 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6361 (UNIPROP_COMPRESSED_FORM_P): New macros.
6362 (char_table_ascii): Uncompress the compressed values.
6363 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6364 Uncompress the compressed values.
6365 (sub_char_table_ref_and_range): Likewise.
6366 (char_table_ref_and_range): Uncompress the compressed values.
6367 (sub_char_table_set): New arg is_uniprop. Callers changed.
6368 Uncompress the compressed values.
6369 (sub_char_table_set_range): Args changed. Callers changed.
6370 (char_table_set_range): Adjuted for the above change.
6371 (map_sub_char_table): Delete args default_val and parent. Add arg
6372 top. Give decoded values to a Lisp function.
6373 (map_char_table): Adjust for the above change. Give decoded
6374 values to a Lisp function. Gcpro more variables.
6375 (uniprop_table_uncompress)
6376 (uniprop_decode_value_run_length): New functions.
6377 (uniprop_decoder, uniprop_decoder_count): New variables.
6378 (uniprop_get_decoder, uniprop_encode_value_character)
6379 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6381 (uniprop_encoder, uniprop_encoder_count): New variables.
6382 (uniprop_get_encoder, uniprop_table)
6383 (Funicode_property_table_internal, Fget_unicode_property_internal)
6384 (Fput_unicode_property_internal): New functions.
6385 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6386 Sunicode_property_table_internal, Sget_unicode_property_internal,
6387 and Sput_unicode_property_internal. Defvar_lisp
6388 char-code-property-alist.
6390 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6391 Vunicode_category_table.
6393 * font.c (font_range): Adjust for the change of
6394 Vunicode_category_table.
6396 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6398 * m/iris4d.h: Remove file, move contents ...
6399 * s/irix6-5.h: ... here.
6401 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6403 Remove unportable assumption about struct layout (Bug#8884).
6404 * alloc.c (mark_buffer):
6405 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6406 (clone_per_buffer_values): Don't assume that
6407 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6408 This isn't true in general, and it's particularly not true
6409 if Emacs is configured with --with-wide-int.
6410 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6411 New macros, used in the buffer.c change.
6413 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6415 * xsettings.c: Use both GConf and GSettings if both are available.
6416 (store_config_changed_event): Add comment.
6417 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6418 (store_tool_bar_style_changed): New functions.
6419 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6420 (struct xsettings): Move font inside HAVE_XFT.
6421 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6422 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6423 Move inside HAVE_XFT.
6424 (something_changed_gsettingsCB): Rename from something_changedCB.
6425 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6427 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6428 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6429 (something_changed_gconfCB): Rename from something_changedCB.
6430 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6431 (parse_settings): Move check for font inside HAVE_XFT.
6432 (read_settings, apply_xft_settings): Add comment.
6433 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6434 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6435 call store_font_name_changed.
6436 (xft_settings_event): Add comment.
6437 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6438 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6439 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6440 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6441 (xsettings_initialize): Call init_gsettings last.
6442 (xsettings_get_system_font, xsettings_get_system_normal_font):
6445 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6447 Random fixes. E.g., (random) never returned negative values.
6448 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6449 subseconds part to the entropy, as that's a bit more random.
6450 Prefer signed to unsigned, since the signedness doesn't matter and
6451 in general we prefer signed. When given a limit, use a
6452 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6453 latter isn't right if USE_2_TAGS_FOR_INTS.
6454 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6455 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6457 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6459 * textprop.c (text_property_stickiness):
6460 Obey Vtext_property_default_nonsticky.
6461 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6462 * w32fns.c (syms_of_w32fns):
6463 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6465 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6467 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6468 This is more efficient than Ffile_directory_p and avoids a minor race.
6470 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6472 * buffer.c (Foverlay_put): Say what the return value is
6475 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6476 is a directory before asking whether to use the file name
6478 (barf_or_query_if_file_exists): Make the "File is a directory"
6479 error be more correct.
6481 * fns.c (Frequire): Remove the mention of the .gz files, since
6482 that's installation-specific, but keep the mention of
6483 `get-load-suffixes'.
6485 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6487 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6488 Report string overflow if the output is too long.
6490 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6492 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6493 (syms_of_gnutls): Remove duplicate DEFSYM for
6494 Qgnutls_bootprop_verify_hostname_error, an error for
6495 Qgnutls_bootprop_verify_error (which is no longer used).
6497 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6498 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6499 Also (re)move comments that are misplaced or no longer relevant.
6501 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6503 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6505 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6507 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6508 and background color parameters if they have been changed.
6510 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6512 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6514 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6516 * xsettings.c (SYSTEM_FONT): Define only when used.
6517 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6519 * keymap.c (access_keymap_1): Now static.
6521 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6523 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6524 leave any prefix arg for the up event (Bug#1586).
6526 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6528 * lread.c (syms_of_lread): Mention single symbols defined by
6529 `defvar' or `defconst' (bug#7154).
6531 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6532 (Frequire): Mention get-load-suffixes.
6534 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6536 * window.h (window): Remove clone_number slot.
6537 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6539 (make_parent_window, make_window, saved_window)
6540 (Fset_window_configuration, save_window_save): Don't deal with
6542 * buffer.c (Qclone_number): Remove declaration.
6543 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6545 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6547 Add multiple inheritance to keymaps.
6548 * keymap.c (Fmake_composed_keymap): New function.
6549 (Fset_keymap_parent): Simplify.
6550 (fix_submap_inheritance): Remove.
6551 (access_keymap_1): New function extracted from access_keymap to handle
6552 embedded parents and handle lists of maps.
6553 (access_keymap): Use it.
6554 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6555 (Fcopy_keymap): Handle embedded parents.
6556 (Fcommand_remapping, define_as_prefix): Simplify.
6557 (Fkey_binding): Simplify.
6558 (syms_of_keymap): Move minibuffer-local-completion-map,
6559 minibuffer-local-filename-completion-map,
6560 minibuffer-local-must-match-map, and
6561 minibuffer-local-filename-must-match-map to Elisp.
6562 (syms_of_keymap): Defsubr make-composed-keymap.
6563 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6564 (parse_menu_item): Trivial simplification.
6566 2011-07-01 Glenn Morris <rgm@gnu.org>
6568 * Makefile.in (SETTINGS_LIBS): Fix typo.
6570 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6572 * coding.c (Fencode_coding_string): Record the last coding system
6573 used, as the function doc string says (bug#8738).
6575 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6577 * xsettings.c (store_monospaced_changed): Take new font as arg and
6578 check for change against current_mono_font.
6579 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6580 (emacs_settings_constructor, emacs_settings_get_property)
6581 (emacs_settings_set_property, emacs_settings_class_init)
6582 (emacs_settings_init, gsettings_obj): Remove.
6583 (something_changedCB): New function for HAVE_GSETTINGS.
6584 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6585 with value as argument.
6586 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6587 g_settings_new (Bug#8967). Do not create gsettings_obj.
6588 Remove calls to g_settings_bind. Connect something_changedCB to
6591 * xgselect.c: Add defined (HAVE_GSETTINGS).
6592 (xgselect_initialize): Ditto.
6594 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6595 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6598 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6600 * eval.c (struct backtrace): Simplify and port the data structure.
6601 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6602 signed bit field, as this assumption is not portable and it makes
6603 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6604 "char debug_on_exit : 1" as this is not portable either; instead,
6605 use the portable "unsigned int debug_on_exit : 1". Remove unused
6606 member evalargs. Remove obsolete comments about cc bombing out.
6608 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6610 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6611 Let HAVE_GSETTINGS override HAVE_GCONF.
6612 (store_monospaced_changed): New function.
6613 (EMACS_SETTINGS): A new type derived from GObject to handle
6614 GSettings notifications.
6615 (emacs_settings_constructor, emacs_settings_get_property)
6616 (emacs_settings_set_property, emacs_settings_class_init):
6618 (gsettings_client, gsettings_obj): New variables.
6619 (GSETTINGS_SCHEMA): New define.
6620 (something_changedCB): Call store_monospaced_changed.
6621 (init_gsettings): New function.
6622 (xsettings_initialize): Call init_gsettings.
6623 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6626 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6629 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6631 * window.c (resize_root_window, grow_mini_window)
6632 (shrink_mini_window): Rename Qresize_root_window to
6633 Qwindow_resize_root_window and Qresize_root_window_vertically to
6634 Qwindow_resize_root_window_vertically.
6636 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6638 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6640 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6642 * makefile.w32-in: Redesign dependencies so they reflect more
6643 clearly which files are directly included by each source file,
6644 and not through other includes.
6646 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6648 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6649 (sort_overlays, overlay_strings): When an overlay's clone number
6650 matches the window's clone number process the overlay even if
6651 the overlay's window property doesn't match the current window.
6653 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6654 (Fwindow_hchild): Rename to Fwindow_left_child.
6655 (Fwindow_next): Rename to Fwindow_next_sibling.
6656 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6657 (resize_window_check): Rename to window_resize_check.
6658 (resize_window_apply): Rename to window_resize_apply.
6659 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6660 (Fdelete_other_windows_internal, resize_frame_windows)
6661 (Fsplit_window_internal, Fdelete_window_internal)
6662 (grow_mini_window, shrink_mini_window)
6663 (Fresize_mini_window_internal): Fix callers accordingly.
6665 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6667 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6668 (emacs_fixed_set_min_size): Remove.
6669 (emacs_fixed_new): Take frame as argument.
6671 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6672 (_EmacsFixedPrivate): Remove minwidth/height.
6673 Add struct frame *f.
6674 (emacs_fixed_init): Initialize priv->f.
6675 (get_parent_class, emacs_fixed_set_min_size): Remove.
6676 (emacs_fixed_new): Set priv->f to argument.
6677 (emacs_fixed_get_preferred_width)
6678 (emacs_fixed_get_preferred_height): Use min_width/height from
6679 frames size_hint to set minimum and natural (Bug#8919).
6680 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6681 and use min_width/height from frames size_hint to set
6682 min_width/height (Bug#8919).
6684 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6685 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6688 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6690 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6691 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6694 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6696 * process.c (wait_reading_process_output): Bypass select if
6697 waiting for a cell while ignoring keyboard input, and input is
6698 pending. Suggested by Jan Djärv (Bug#8869).
6700 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6702 Use gnulib's dup2 module instead of rolling our own.
6703 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6705 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6707 * dispnew.c (scrolling_window): Before scrolling, turn off a
6708 mouse-highlight in the window being scrolled.
6710 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6712 Move DEFSYM to lisp.h and use everywhere.
6714 * character.h (DEFSYM): Move declaration...
6715 * lisp.h (DEFSYM): ...here.
6721 * w32select.c: Don't include character.h.
6723 * alloc.c (syms_of_alloc):
6724 * buffer.c (syms_of_buffer):
6725 * bytecode.c (syms_of_bytecode):
6726 * callint.c (syms_of_callint):
6727 * casefiddle.c (syms_of_casefiddle):
6728 * casetab.c (init_casetab_once):
6729 * category.c (init_category_once, syms_of_category):
6730 * ccl.c (syms_of_ccl):
6731 * cmds.c (syms_of_cmds):
6732 * composite.c (syms_of_composite):
6733 * dbusbind.c (syms_of_dbusbind):
6734 * dired.c (syms_of_dired):
6735 * dispnew.c (syms_of_display):
6736 * doc.c (syms_of_doc):
6737 * editfns.c (syms_of_editfns):
6738 * emacs.c (syms_of_emacs):
6739 * eval.c (syms_of_eval):
6740 * fileio.c (syms_of_fileio):
6741 * fns.c (syms_of_fns):
6742 * frame.c (syms_of_frame):
6743 * fringe.c (syms_of_fringe):
6744 * insdel.c (syms_of_insdel):
6745 * keymap.c (syms_of_keymap):
6746 * lread.c (init_obarray, syms_of_lread):
6747 * macros.c (syms_of_macros):
6748 * msdos.c (syms_of_msdos):
6749 * print.c (syms_of_print):
6750 * process.c (syms_of_process):
6751 * search.c (syms_of_search):
6752 * sound.c (syms_of_sound):
6753 * syntax.c (init_syntax_once, syms_of_syntax):
6754 * terminal.c (syms_of_terminal):
6755 * textprop.c (syms_of_textprop):
6756 * undo.c (syms_of_undo):
6757 * w32.c (globals_of_w32):
6758 * window.c (syms_of_window):
6759 * xdisp.c (syms_of_xdisp):
6760 * xfaces.c (syms_of_xfaces):
6761 * xfns.c (syms_of_xfns):
6762 * xmenu.c (syms_of_xmenu):
6763 * xsettings.c (syms_of_xsettings):
6764 * xterm.c (syms_of_xterm): Use DEFSYM.
6766 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6768 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6770 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6772 Integer and buffer overflow fixes (Bug#8873).
6774 * print.c (printchar, strout): Check for string overflow.
6775 (PRINTPREPARE, printchar, strout):
6776 Don't set size unless allocation succeeds.
6778 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6779 for sizes. Check for string overflow more accurately.
6780 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6782 * macros.c: Integer and buffer overflow fixes.
6783 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6784 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6785 Use ptrdiff_t, not int, for sizes.
6786 Don't increment bufsize until after realloc succeeds.
6787 Check for size-calculation overflow.
6788 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6790 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6792 * lread.c: Integer overflow fixes.
6793 (read_integer): Radix is now EMACS_INT, not int,
6794 to improve quality of diagnostics for out-of-range radices.
6795 Calculate buffer size correctly for out-of-range radices.
6796 (read1): Check for integer overflow in radices, and in
6797 read-circle numbers.
6798 (read_escape): Avoid int overflow.
6799 (Fload, openp, read_buffer_size, read1)
6800 (substitute_object_recurse, read_vector, read_list, map_obarray):
6801 Use ptrdiff_t, not int, for sizes.
6802 (read1): Use EMACS_INT, not int, for sizes.
6803 Check for size overflow.
6805 * image.c (cache_image): Check for size arithmetic overflow.
6807 * lread.c: Integer overflow issues.
6808 (saved_doc_string_size, saved_doc_string_length)
6809 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6810 Now ptrdiff_t, not int.
6811 (read1): Don't assume doc string length fits in int. Check for
6812 out-of-range doc string lengths.
6813 (read_list): Don't assume file position fits in int.
6814 (read_escape): Check for hex character overflow.
6816 2011-06-22 Leo Liu <sdl.web@gmail.com>
6818 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6819 Move to minibuffer.el.
6821 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6823 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6824 The following patches are for when GLYPH_DEBUG && !XASSERT.
6825 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6826 * dispnew.c (flush_stdout):
6827 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6828 Mark as externally visible.
6829 * dispnew.c (check_window_matrix_pointers): Now static.
6830 * dispnew.c (window_to_frame_vpos):
6831 * xfns.c (unwind_create_frame):
6832 * xterm.c (x_check_font): Remove unused local.
6833 * scroll.c (CHECK_BOUNDS):
6834 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6835 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6836 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6837 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6838 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6840 (debug_method_add): Use va_list and vsprintf rather than relying
6841 on undefined behavior with wrong number of arguments.
6842 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6843 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6844 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6845 since we're not interested in debugging glyphs with old libraries.
6846 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6847 GCC 4.6.0's static checking.
6849 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6851 Integer overflow and signedness fixes (Bug#8873).
6852 A few related buffer overrun fixes, too.
6854 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6856 * dispextern.h (struct face.stipple):
6857 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6858 (x_bitmap_mask, x_allocate_bitmap_record)
6859 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6860 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6861 (x_create_bitmap_from_xpm_data):
6862 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6863 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6865 * xfaces.c (load_pixmap):
6866 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6867 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6868 (.bitmaps_last, struct x_output.icon_bitmap):
6869 Use ptrdiff_t, not int, for bitmap indexes.
6870 (x_allocate_bitmap_record): Check for size overflow.
6871 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6873 Use ptrdiff_t, not int, for overlay counts.
6874 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6875 * editfns.c (overlays_around, get_pos_property):
6876 * textprop.c (get_char_property_and_overlay):
6877 * xdisp.c (next_overlay_change, note_mouse_highlight):
6878 * xfaces.c (face_at_buffer_position):
6879 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6880 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6881 (Fnext_overlay_change, Fprevious_overlay_change)
6882 (mouse_face_overlay_overlaps, Foverlays_in):
6883 Use ptrdiff_t, not int, for sizes.
6884 (overlays_at, overlays_in): Check for size-calculation overflow.
6886 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6888 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6889 (x_session_initialize): Do not assume string length fits in int.
6891 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6892 This is unlikely, but can occur if DPI is outlandish.
6894 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6895 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6897 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6898 * xrdb.c (magic_file_p, search_magic_path):
6899 Omit last arg SUFFIX; it was always 0. All callers changed.
6900 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6902 * xfont.c (xfont_match): Avoid need for strlen.
6904 * xfns.c: Don't assume strlen fits in int.
6905 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6907 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6908 not unsigned long, as we prefer signed integers. All callers changed.
6909 Detect integer overflow in repeat count.
6910 (message_dolog): Don't assume print length fits in 39 bytes.
6911 (display_mode_element): Don't assume strlen fits in int.
6913 * termcap.c: Don't assume sizes fit in int and never overflow.
6914 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6915 (gobble_line): Check for size-calculation overflow.
6917 * minibuf.c (Fread_buffer):
6918 * lread.c (intern, intern_c_string):
6919 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6920 Don't assume string length fits in int.
6922 * keyboard.c (parse_tool_bar_item):
6923 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6925 * font.c: Don't assume string length fits in int.
6926 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6927 Use ptrdiff_t, not int.
6928 (font_intern_prop): Don't assume string length fits in int.
6929 Don't assume integer property fits in fixnum.
6930 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6932 * filelock.c: Fix some buffer overrun and integer overflow issues.
6933 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6934 Reformulate so as not to need the command string.
6935 Invoke gzip -cd rather than gunzip, as it's more portable.
6936 (lock_info_type, lock_file_1, lock_file):
6937 Don't assume pid_t and time_t fit in unsigned long.
6938 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6939 (current_lock_owner): Prefer signed type for sizes.
6940 Use memcpy, not strncpy, where memcpy is what is really wanted.
6941 Don't assume (via atoi) that time_t and pid_t fit in int.
6942 Check for time_t and/or pid_t out of range, e.g., via a network share.
6943 Don't alloca where an auto var works fine.
6945 * fileio.c: Fix some integer overflow issues.
6946 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6947 Don't assume string length fits in int.
6948 (directory_file_name): Don't assume string length fits in long.
6949 (make_temp_name): Don't assume pid fits in int, or that its print
6950 length is less than 20.
6952 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6954 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6956 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6958 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6959 We prefer signed integers, even for size calculations.
6961 * emacs.c: Don't assume string length fits in 'int'.
6962 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6963 (main): Don't invoke strlen when not needed.
6965 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6966 (XD_DEBUG_MESSAGE): Don't waste a byte.
6968 * callproc.c (getenv_internal_1, getenv_internal)
6970 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6972 * lread.c (invalid_syntax): Omit length argument.
6973 All uses changed. This doesn't fix a bug, but it simplifies the
6974 code away from its former Hollerith-constant appearance, and it's
6975 one less 'int' to worry about when looking at integer-overflow issues.
6976 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6978 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6979 This didn't break anything, but it didn't help either.
6980 It's confusing to put a bogus integer in a place where the actual
6981 value does not matter.
6982 (LIST_END_P): Remove unused macro and its bogus comment.
6983 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6985 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6986 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6988 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6989 We prefer signed types, and the value cannot exceed the EMACS_INT
6990 range anyway (because otherwise the length would not be representable).
6991 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6992 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6993 This avoids a GCC warning when WIDE_EMACS_INT.
6995 * indent.c (sane_tab_width): New function.
6996 (current_column, scan_for_column, Findent_to, position_indentation)
6997 (compute_motion): Use it. This is just for clarity.
6998 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7000 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7002 * lisp.h (lint_assume): New macro.
7003 * composite.c (composition_gstring_put_cache):
7004 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7006 * editfns.c, insdel.c:
7007 Omit unnecessary forward decls, to simplify future changes.
7009 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7011 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7013 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7014 Use much-faster test for byte-length change.
7015 Don't assume string byte-length fits in 'int'.
7016 Check that character arg fits in 'int'.
7017 (mapcar1): Declare byte as byte, for clarity.
7019 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7021 * fns.c (concat): Catch string overflow earlier.
7022 Do not rely on integer wraparound.
7024 * dispextern.h (struct it.overlay_strings_charpos)
7025 (struct it.selective): Now EMACS_INT, not int.
7026 * xdisp.c (forward_to_next_line_start)
7027 (back_to_previous_visible_line_start)
7028 (reseat_at_next_visible_line_start, next_element_from_buffer):
7029 Don't arbitrarily truncate the value of 'selective' to int.
7031 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7033 * composite.c: Don't truncate sizes to 'int'.
7034 (composition_gstring_p, composition_reseat_it)
7035 (composition_adjust_point): Use EMACS_INT, not int.
7036 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7037 not EMACS_UINT, for indexes.
7039 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7041 * buffer.c: Include <verify.h>.
7042 (struct sortvec.priority, struct sortstr.priority):
7043 Now EMACS_INT, not int.
7044 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7045 (struct sortstr.size, record_overlay_string)
7046 (struct sortstrlist.size, struct sortlist.used):
7047 Don't truncate size to int.
7048 (record_overlay_string): Check for size-calculation overflow.
7049 (init_buffer_once): Check at compile-time, not run-time.
7051 2011-06-22 Jim Meyering <meyering@redhat.com>
7053 Don't leak an XBM-image-sized buffer
7054 * image.c (xbm_load): Free the image buffer after using it.
7056 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7059 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7060 that Sun C diagnosed.
7061 * fns.c (secure_hash): Fix pointer signedness issue.
7062 * intervals.c (static_offset_intervals): New function.
7063 (offset_intervals): Use it.
7065 2011-06-21 Leo Liu <sdl.web@gmail.com>
7068 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7071 * fns.c (secure_hash): Rename from crypto_hash_function and change
7072 the first arg to accept symbols.
7073 (Fsecure_hash): New primitive.
7074 (syms_of_fns): New symbols.
7076 2011-06-20 Deniz Dogan <deniz@dogan.se>
7078 * process.c (Fset_process_buffer): Clarify return value in
7081 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7083 * dispnew.c (add_window_display_history): Use BVAR.
7085 * xdisp.c (debug_method_add): Use BVAR.
7086 (check_window_end, dump_glyph_matrix, dump_glyph)
7087 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7089 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7092 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7093 check till after the cache is created in init_frame_faces.
7095 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7097 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7099 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7101 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7102 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7103 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7105 Improve buffer-overflow checking (Bug#8873).
7106 * fileio.c (Finsert_file_contents):
7107 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7108 Remove the old (too-loose) buffer overflow checks.
7109 They weren't needed, since make_gap checks for buffer overflow.
7110 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7111 The old code merely checked for Emacs fixnum overflow, and relied
7112 on undefined (wraparound) behavior. The new code avoids undefined
7113 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7115 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7116 Tune. Don't use wider integers than needed. Don't use alloca.
7117 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7119 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7121 * insdel.c, lisp.h (buffer_overflow): New function.
7122 (insert_from_buffer_1, replace_range, replace_range_2):
7123 * insdel.c (make_gap_larger):
7124 * editfns.c (Finsert_char):
7125 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7127 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7129 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7131 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7133 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7134 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7136 * fileio.c: Don't assume EMACS_INT fits in off_t.
7137 (emacs_lseek): New static function.
7138 (Finsert_file_contents, Fwrite_region): Use it.
7139 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7141 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7143 * fns.c: Don't overflow int when computing a list length.
7144 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7145 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7146 truncation on 64-bit hosts. Check for QUIT every
7147 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7148 faster and is responsive enough.
7149 (Flength): Report an error instead of overflowing an integer.
7150 (Fsafe_length): Return a float if the value is not representable
7151 as a fixnum. This shouldn't happen except in contrived situations.
7152 (Fnthcdr, Fsort): Don't assume list length fits in int.
7153 (Fcopy_sequence): Don't assume vector length fits in int.
7155 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7156 (header_size, word_size): New constants.
7157 (allocate_vectorlike): Don't check size overflow here.
7158 (allocate_vector): Check it here instead, since this is the only
7159 caller of allocate_vectorlike that could cause overflow.
7160 Check that the new vector's length is representable as a fixnum.
7162 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7163 The previous code was bogus. For example, next_almost_prime (32)
7164 returned 39, which is undesirable as it is a multiple of 3; and
7165 next_almost_prime (24) returned 25, which is a multiple of 5 so
7166 why was the code bothering to check for multiples of 7?
7168 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7170 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7172 Variadic C functions now count arguments with ptrdiff_t.
7173 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7174 Back then I didn't know that the Emacs coding style prefers signed int.
7175 Also, in the meantime I found a few more instances where arguments
7176 were being counted with int, which may truncate counts on 64-bit
7177 machines, or EMACS_INT, which may be unnecessarily wide.
7178 * lisp.h (struct Lisp_Subr.function.aMANY)
7179 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7180 Arg counts are now ptrdiff_t, not size_t.
7181 All variadic functions and their callers changed accordingly.
7182 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7183 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7184 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7185 * callint.c (Fcall_interactively): Check arg count for overflow,
7186 to avoid potential buffer overrun. Use signed char, not 'int',
7187 for 'varies' array, so that we needn't bother to check its size
7188 calculation for overflow.
7189 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7190 * eval.c (apply_lambda):
7191 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7192 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7193 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7195 * callint.c (Fcall_interactively): Don't use index var as event count.
7197 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7198 * mem-limits.h (SIZE): Remove; no longer used.
7200 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7202 Remove unnecessary casts.
7203 * xterm.c (x_term_init):
7204 * xfns.c (x_set_border_pixel):
7205 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7206 These aren't needed now that we assume ANSI C.
7208 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7209 It's more likely to cause problems (due to unsigned overflow)
7212 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7214 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7216 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7218 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7220 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7222 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7224 GLYPH_CODE_FACE returns EMACS_INT, not int.
7225 * dispextern.h (merge_faces):
7226 * xfaces.c (merge_faces):
7227 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7228 Don't assume EMACS_INT fits in int.
7230 * character.h (CHAR_VALID_P): Remove unused parameter.
7231 * fontset.c, lisp.h, xdisp.c: All uses changed.
7233 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7235 * fns.c (concat): Minor tuning based on overflow analysis.
7236 This doesn't fix any bugs. Use int to hold character, instead
7237 of constantly refetching from Emacs object. Use XFASTINT, not
7238 XINT, for value known to be a character. Don't bother comparing
7239 a single byte to 0400, as it's always less.
7241 * floatfns.c (Fexpt):
7242 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7244 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7247 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7249 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7250 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7251 incorrectly succeed when S was a string, because 4294967386 was
7252 truncated before it was used.
7254 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7255 Otherwise, an out-of-range integer could cause undefined behavior
7258 * composite.c: Use int, not EMACS_INT, for characters.
7259 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7260 EMACS_INT, for values that are known to be in character range.
7261 This doesn't fix any bugs but is the usual style inside Emacs and
7262 may generate better code on 32-bit machines.
7264 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7265 This is for reasons similar to the recent CHAR_STRING fix.
7266 * charset.c (Fencode_char): Check that character arg is actually
7267 a character. Pass an int to ENCODE_CHAR.
7268 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7269 wider than 'int', as a compile-time check to prevent future regressions
7272 * character.c (char_string): Remove unnecessary casts.
7274 Make sure a 64-bit char is never passed to CHAR_STRING.
7275 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7276 by silently ignoring the top 32 bits, allowing some values
7277 that were far too large to be valid characters.
7278 * character.h: Include <verify.h>.
7279 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7280 arguments are no wider than unsigned, as a compile-time check
7281 to prevent future regressions in this area.
7283 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7284 (Fsubst_char_in_region):
7286 * xdisp.c (decode_mode_spec_coding):
7287 Adjust to CHAR_STRING's new requirement.
7288 * editfns.c (Finsert_char, Fsubst_char_in_region):
7289 * fns.c (concat): Check that character args are actually
7290 characters. Without this test, these functions did the wrong
7291 thing with wildly out-of-range values on 64-bit hosts.
7293 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7294 These casts should not be needed on 32-bit hosts, either.
7295 * keyboard.c (read_char):
7296 * lread.c (Fload): Remove casts to unsigned.
7298 * lisp.h (UNSIGNED_CMP): New macro.
7299 This fixes comparison bugs on 64-bit hosts.
7300 (ASCII_CHAR_P): Use it.
7301 * casefiddle.c (casify_object):
7302 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7303 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7304 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7305 * dispextern.h (FACE_FROM_ID):
7306 * keyboard.c (read_char): Use UNSIGNED_CMP.
7308 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7309 not to EMACS_INT, to avoid GCC warning.
7311 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7313 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7314 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7315 isn't needed on 32-bit machines.
7317 * buffer.c (Fgenerate_new_buffer_name):
7318 Use EMACS_INT for count, not int.
7319 (advance_to_char_boundary): Return EMACS_INT, not int.
7321 * data.c (Qcompiled_function): Now static.
7323 * window.c (window_body_lines): Now static.
7325 * image.c (gif_load): Rename local to avoid shadowing.
7327 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7328 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7329 * alloc.c (make_save_value): Integer argument is now of type
7331 (mark_object): Use ptrdiff_t, not int.
7332 * lisp.h (pD): New macro.
7333 * print.c (print_object): Use it.
7335 * alloc.c: Use EMACS_INT, not int, to count objects.
7336 (total_conses, total_markers, total_symbols, total_vector_size)
7337 (total_free_conses, total_free_markers, total_free_symbols)
7338 (total_free_floats, total_floats, total_free_intervals)
7339 (total_intervals, total_strings, total_free_strings):
7340 Now EMACS_INT, not int. All uses changed.
7341 (Fgarbage_collect): Compute overall total using a double, so that
7342 integer overflow is less likely to be a problem. Check for overflow
7343 when converting back to an integer.
7344 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7345 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7346 These were 'int' variables that could overflow on 64-bit hosts;
7347 they were never used, so remove them instead of repairing them.
7348 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7349 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7350 Previously, this ceilinged at INT_MAX, but that doesn't work on
7352 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7354 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7355 (allocate_vectorlike): Check for ptrdiff_t overflow.
7356 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7357 when a (possibly-narrower) signed value would do just as well.
7358 We prefer using signed arithmetic, to avoid comparison confusion.
7360 * alloc.c: Catch some string size overflows that we were missing.
7361 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7362 for convenience in STRING_BYTES_MAX.
7363 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7364 The definition here is exact; the one in lisp.h was approximate.
7365 (allocate_string_data): Check for string overflow. This catches
7366 some instances we weren't catching before. Also, it catches
7367 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7368 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7369 and ptrdiff_t and EMACS_INT are both 64 bits.
7371 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7372 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7373 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7375 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7377 * alloc.c (Fmake_string): Check for out-of-range init.
7379 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7381 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7383 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7385 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7386 xg_get_default_scrollbar_width.
7388 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7389 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7390 (style_changed_cb): Call update_theme_scrollbar_width and call
7391 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7392 all frames (Bug#8505).
7393 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7394 Call gtk_window_set_resizable if HAVE_GTK3.
7395 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7396 and height if HAVE_GTK3 (Bug#8505).
7397 (scroll_bar_width_for_theme): New variable.
7398 (update_theme_scrollbar_width): New function.
7399 (xg_get_default_scrollbar_width): Move code to
7400 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7401 (xg_initialize): Call update_theme_scrollbar_width.
7403 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7405 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7407 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7409 * frame.c (make_frame): Call other_buffer_safely instead of
7412 * window.c (temp_output_buffer_show): Call display_buffer with
7413 second argument Vtemp_buffer_show_specifiers and reset latter
7414 immediately after the call.
7415 (Vtemp_buffer_show_specifiers): New variable.
7416 (auto_window_vscroll_p, next_screen_context_lines)
7417 (Vscroll_preserve_screen_position): Remove leading asterisks from
7420 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7422 Fix minor problems found by GCC 4.6.0 static checking.
7423 * buffer.c (Qclone_number): Remove for now, as it's unused.
7424 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7425 (record_buffer): Remove unused local.
7426 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7427 (set_frame_buffer_list): Remove; unused.
7428 * frame.h (other_visible_frames): Remove decl.
7429 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7430 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7431 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7433 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7434 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7435 Define only if HAVE_GPM.
7436 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7437 (update_hints_inhibit): Remove; never set. All uses removed.
7438 * widgetprv.h (emacsFrameClassRec): Remove decl.
7439 * window.c (delete_deletable_window): Now returns void, since it
7440 wasn't returning anything.
7441 (compare_window_configurations): Remove unused locals.
7442 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7443 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7444 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7445 the same widths as pointers. This follows up on the 2011-05-06 patch.
7446 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7447 * xterm.h: Likewise.
7448 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7450 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7452 * makefile.w32-in: Update dependencies.
7453 (LISP_H): Add lib/intprops.h.
7455 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7457 * image.c (gif_load): Add animation frame delay to the metadata.
7458 (syms_of_image): Use DEFSYM. New symbol `delay'.
7460 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7462 * window.c (delete_deletable_window): Re-add.
7463 (Fset_window_configuration): Rewrite to handle dead buffers and
7464 consequently deletable windows.
7465 (window_tree, Fwindow_tree): Remove. Supply functionality in
7467 (compare_window_configurations): Simplify code.
7469 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7471 * image.c (imagemagick_load_image): Fix type mismatch.
7472 (Fimagemagick_types): Likewise.
7474 * window.h (replace_buffer_in_windows): Declare.
7476 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7478 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7479 Qclone_number. Remove external declaration of Qdelete_window.
7480 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7482 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7483 Run Qbuffer_list_update_hook if allowed.
7484 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7485 buffer list implementation.
7486 (other_buffer_safely): New function.
7487 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7488 calls to replace_buffer_in_windows and
7489 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7491 (record_buffer): Inhibit quitting and rewrite using quittable
7492 functions. Run Qbuffer_list_update_hook if allowed.
7493 (Frecord_buffer, Funrecord_buffer): New functions.
7494 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7495 Move switch-to-buffer to window.el.
7496 (bury-buffer): Move to window.el.
7497 (Vbuffer_list_update_hook): New variable.
7499 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7502 * window.h (resize_frame_windows): Move up in code.
7503 (Fwindow_frame): Remove EXFUN.
7504 (replace_buffer_in_all_windows): Remove prototype.
7505 (replace_buffer_in_windows_safely): Add prototype.
7507 * window.c: Declare Qdelete_window static again. Move down
7508 declaration of select_count.
7509 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7510 (Fother_window): Move to window.el.
7511 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7512 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7513 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7515 (replace_buffer_in_windows): Implement by calling
7516 Qreplace_buffer_in_windows.
7517 (replace_buffer_in_all_windows): Remove with some functionality
7518 moved into replace_buffer_in_windows_safely.
7519 (replace_buffer_in_windows_safely): New function.
7520 (select_window_norecord, select_frame_norecord): Move in front
7521 of run_window_configuration_change_hook. Remove now obsolete
7523 (Fset_window_buffer): Rewrite doc-string.
7524 Call Qrecord_window_buffer.
7525 (keys_of_window): Move binding for other-window to window.el.
7527 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7529 * dispextern.h (struct image): Replace data member, whose int_val
7530 and ptr_val fields were not used by anything, with a single
7533 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7534 (gif_clear_image, gif_load, imagemagick_load_image)
7535 (gs_clear_image, gs_load): Callers changed.
7537 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7539 * buffer.h: Include <time.h>, for time_t.
7540 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7542 Fix minor problems found by static checking.
7544 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7546 Make identifiers static if they are not used in other modules.
7547 * data.c (Qcompiled_function, Qframe, Qvector):
7548 * image.c (QimageMagick, Qsvg):
7549 * minibuf.c (Qmetadata):
7550 * window.c (resize_window_check, resize_root_window): Now static.
7551 * window.h (resize_window_check, resize_root_window): Remove decls.
7553 * window.c (window_deletion_count, delete_deletable_window):
7555 (window_body_lines): Now static.
7556 (Fdelete_other_windows_internal): Mark vars as initialized.
7557 Make sure 'resize_failed' is initialized.
7558 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7559 (resize_window_apply): Remove unused local.
7560 * window.h (delete_deletable_window): Remove decl.
7562 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7563 (imagemagick_load_image): Fix pointer signedness problem by changing
7564 last arg from unsigned char * to char *. All uses changed.
7565 Also, fix a local for similar reasons.
7566 Remove unused locals. Remove locals to avoid shadowing.
7567 (fn_rsvg_handle_free): Remove; unused.
7568 (svg_load, svg_load_image): Fix pointer signedness problem.
7569 (imagemagick_load_image): Don't use garbage pointer image_wand.
7571 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7573 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7575 * image.c (gif_load): Fix omitted cast error introduced by
7578 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7580 * window.h (resize_proportionally, orig_total_lines)
7581 (orig_top_line): Remove from window structure.
7582 (set_window_height, set_window_width, change_window_heights)
7583 (Fdelete_window): Remove prototypes.
7584 (resize_frame_windows): Remove duplicate declaration.
7586 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7588 * window.h (resize_frame_windows, resize_window_check)
7589 (delete_deletable_window, resize_root_window)
7590 (resize_frame_windows): Declare prototypes.
7592 * window.c (resize_window_apply): Make definition be "static" to
7593 match the prototype.
7595 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7597 * window.c: Remove declarations of Qwindow_size_fixed,
7598 window_min_size_1, window_min_size_2, window_min_size,
7599 size_window, window_fixed_size_p, enlarge_window, delete_window.
7600 Remove static from declaration of Qdelete_window, it's
7601 temporarily needed by Fbury_buffer.
7602 (replace_window): Don't assign orig_top_line and
7604 (Fdelete_window, delete_window): Remove. Window deletion is
7605 handled by window.el.
7606 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7607 Replace Fdelete_window calls with calls to Qdelete_window.
7608 (Fdelete_other_windows): Remove. Deleting other windows is
7609 handled by window.el.
7610 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7611 handled in window.el.
7612 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7613 Window minimum sizes are handled in window.el.
7614 (shrink_windows, size_window, set_window_height)
7615 (set_window_width, change_window_heights, window_height)
7616 (window_width, CURBEG, CURSIZE, enlarge_window)
7617 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7618 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7619 handled in window.el.
7620 (make_dummy_parent): Rename to make_parent_window and give it a
7621 second argument horflag.
7622 (make_window): Don't set resize_proportionally any more.
7623 (Fsplit_window): Remove. Windows are split in window.el.
7624 (save_restore_action, save_restore_orig_size)
7625 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7626 Resize mini windows in window.el.
7627 (grow_mini_window, shrink_mini_window): Implement by calling
7628 Qresize_root_window_vertically, resize_window_check and
7629 resize_window_apply.
7630 (saved_window, Fset_window_configuration, save_window_save):
7631 Do not handle orig_top_line, orig_total_lines, and
7632 resize_proportionally.
7633 (window_min_height, window_min_width): Move to window.el.
7634 (keys_of_window): Move bindings for delete-other-windows,
7635 split-window, delete-window and enlarge-window to window.el.
7637 * buffer.c: Temporarily extern Qdelete_window.
7638 (Fbury_buffer): Temporarily call Qdelete_window instead of
7639 Fdelete_window (Fbury_buffer will move to window.el soon).
7641 * frame.c (set_menu_bar_lines_1): Remove code handling
7642 orig_top_line and orig_total_lines.
7644 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7645 set_window_height but set heights directly.
7646 (change_frame_size_1): Use resize_frame_windows.
7648 * xdisp.c (init_xdisp): Don't use set_window_height but set
7651 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7652 Use resize_frame_windows instead of change_window_heights and run
7653 run_window_configuration_change_hook.
7655 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7656 instead of change_window_heights and run
7657 run_window_configuration_change_hook.
7659 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7661 * window.c (replace_window): Rename second argument REPLACEMENT to
7662 NEW. New third argument SETFLAG. Rewrite.
7663 (delete_window, make_dummy_parent): Call replace_window with
7665 (window_list_1): Move down in code.
7666 (run_window_configuration_change_hook): Move set_buffer part
7667 before select_frame_norecord part in order to unwind correctly.
7668 Rename count1 to count.
7669 (recombine_windows, delete_deletable_window, resize_root_window)
7670 (Fdelete_other_windows_internal)
7671 (Frun_window_configuration_change_hook, make_parent_window)
7672 (resize_window_check, resize_window_apply, Fresize_window_apply)
7673 (resize_frame_windows, Fsplit_window_internal)
7674 (Fdelete_window_internal, Fresize_mini_window_internal):
7676 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7678 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7680 * window.h (window): Add some new members to window structure -
7681 normal_lines, normal_cols, new_total, new_normal, clone_number,
7682 splits, nest, prev_buffers, next_buffers.
7683 (WINDOW_TOTAL_SIZE): Move here from window.c.
7684 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7686 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7688 (make_dummy_parent): Set new members of windows structure.
7689 (make_window): Move down in code. Handle new members of window
7691 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7692 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7693 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7694 (Fset_window_prev_buffers, Fwindow_next_buffers)
7695 (Fset_window_next_buffers, Fset_window_clone_number):
7697 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7698 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7700 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7701 Argument WINDOW can be now internal window too.
7702 (Fwindow_use_time): Move up in code.
7703 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7705 (Fset_window_configuration, saved_window)
7706 (Fcurrent_window_configuration, save_window_save): Handle new
7707 members of window structure.
7708 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7709 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7710 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7711 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7712 Qget_mru_window, Qresize_root_window,
7713 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7714 Qauto_buffer_name; staticpro them.
7716 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7718 * window.c (Fwindow_total_size, Fwindow_left_column)
7719 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7720 (Fwindow_list_1): New functions.
7721 (window_box_text_cols): Replace with window_body_cols.
7722 (Fwindow_width, Fscroll_left, Fscroll_right):
7723 Use window_body_cols instead of window_box_text_cols.
7724 (delete_window, Fset_window_configuration):
7725 Call delete_all_subwindows with window as argument.
7726 (delete_all_subwindows): Take a window as argument and not a
7728 (window_loop): Remove handling of GET_LRU_WINDOW and
7730 (Fget_lru_window, Fget_largest_window): Move to window.el.
7732 * window.h: Extern window_body_cols instead of
7733 window_box_text_cols. delete_all_subwindows now takes a
7734 Lisp_Object as argument.
7736 * indent.c (compute_motion, Fcompute_motion):
7737 Use window_body_cols instead of window_box_text_cols.
7739 * frame.c (delete_frame): Call delete_all_subwindows with root
7742 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7744 * fns.c (Fputhash): Document return value.
7746 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7748 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7750 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7752 Cons<->int and similar integer overflow fixes (Bug#8794).
7754 Check for overflow when converting integer to cons and back.
7755 * charset.c (Fdefine_charset_internal, Fdecode_char):
7756 Use cons_to_unsigned to catch overflow.
7757 (Fencode_char): Use INTEGER_TO_CONS.
7758 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7759 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7760 * data.c (long_to_cons, cons_to_long): Remove.
7761 (cons_to_unsigned, cons_to_signed): New functions.
7762 These signal an error for invalid or out-of-range values.
7763 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7764 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7765 * font.c (Ffont_variation_glyphs):
7766 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7767 * lisp.h: Include <intprops.h>.
7768 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7769 (cons_to_signed, cons_to_unsigned): New decls.
7770 (long_to_cons, cons_to_long): Remove decls.
7771 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7772 (Fprimitive_undo): Use CONS_TO_INTEGER.
7773 * xfns.c (Fx_window_property): Likewise.
7774 * xselect.c: Include <limits.h>.
7775 (x_own_selection, selection_data_to_lisp_data):
7776 Use INTEGER_TO_CONS.
7777 (x_handle_selection_request, x_handle_selection_clear)
7778 (x_get_foreign_selection, Fx_disown_selection_internal)
7779 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7780 (lisp_data_to_selection_data): Use cons_to_unsigned.
7781 (x_fill_property_data): Use cons_to_signed.
7782 Report values out of range.
7784 Check for buffer and string overflow more precisely.
7785 * buffer.h (BUF_BYTES_MAX): New macro.
7786 * lisp.h (STRING_BYTES_MAX): New macro.
7787 * alloc.c (Fmake_string):
7788 * character.c (string_escape_byte8):
7789 * coding.c (coding_alloc_by_realloc):
7790 * doprnt.c (doprnt):
7791 * editfns.c (Fformat):
7793 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7794 since they may not be the same number.
7795 * editfns.c (Finsert_char):
7796 * fileio.c (Finsert_file_contents):
7797 Likewise for BUF_BYTES_MAX.
7799 * image.c: Use ptrdiff_t, not int, for sizes.
7800 (slurp_file): Switch from int to ptrdiff_t.
7802 (slurp_file): Check that file size fits in both size_t (for
7803 malloc) and ptrdiff_t (for sanity and safety).
7805 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7806 if b->modtime has its maximal value.
7808 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7810 Don't assume time_t can fit into int.
7811 * buffer.h (struct buffer.modtime): Now time_t, not int.
7812 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7813 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7815 Minor fixes for signed vs unsigned integers.
7816 * character.h (MAYBE_UNIFY_CHAR):
7817 * charset.c (maybe_unify_char):
7818 * keyboard.c (read_char, reorder_modifiers):
7819 XINT -> XFASTINT, since the integer must be nonnegative.
7820 * ftfont.c (ftfont_spec_pattern):
7821 * keymap.c (access_keymap, silly_event_symbol_error):
7822 XUINT -> XFASTINT, since the integer must be nonnegative.
7823 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7824 since it makes no difference and we prefer signed.
7825 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7826 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7829 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7831 * window.h (Fwindow_frame): Declare.
7833 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7835 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7836 (SPARE_MEMORY): Always define.
7837 (LARGE_REQUEST): Remove.
7838 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7840 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7842 * lisp.h: Move EXFUNS for Fframe_root_window,
7843 Fframe_first_window and Fset_frame_selected_window to window.h.
7845 * window.h: Move EXFUNS for Fframe_root_window,
7846 Fframe_first_window and Fset_frame_selected_window here from
7849 * frame.c (Fwindow_frame, Fframe_first_window)
7850 (Fframe_root_window, Fframe_selected_window)
7851 (Fset_frame_selected_window): Move to window.c.
7852 (Factive_minibuffer_window): Move to minibuf.c.
7853 (Fother_visible_frames_p): New function.
7855 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7857 * window.c (decode_window, decode_any_window): Move up in code.
7858 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7859 (inhibit_frame_unsplittable): Remove unused variable.
7860 (Fwindow_buffer): Move up and rewrite doc-string.
7861 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7862 (Fwindow_prev): New functions.
7863 (Fwindow_frame): Move here from frame.c. Accept any window as
7865 (Fframe_root_window, Fframe_first_window)
7866 (Fframe_selected_window): Move here from frame.c. Accept frame
7867 or arbitrary window as argument. Update doc-strings.
7868 (Fminibuffer_window): Move up in code.
7869 (Fwindow_minibuffer_p): Move up in code and simplify.
7870 (Fset_frame_selected_window): Move here from frame.c.
7872 (Fselected_window, select_window, Fselect_window): Move up in
7873 code. Minor doc-string fixes.
7875 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7877 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7878 Do not assume that spare memory exists; that assumption is valid
7879 only if SYSTEM_MALLOC.
7880 (LARGE_REQUEST): New macro, so that the issue of large requests
7881 is separated from the issue of spare memory.
7883 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7885 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7888 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7890 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7893 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7895 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7897 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7899 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7900 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7902 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7904 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7906 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7908 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7909 (x_clipboard_manager_save): Add return value.
7910 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7912 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7913 Obey Vx_select_enable_clipboard_manager. Catch errors in
7914 x_clipboard_manager_save (Bug#8779).
7915 (Vx_select_enable_clipboard_manager): New variable.
7916 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7918 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7920 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7922 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7924 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7925 in the current matrix if keep_current_p is non-zero.
7927 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7929 * bidi.c (bidi_level_of_next_char): Fix last change.
7931 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7933 Support bidi reordering of text covered by display properties.
7935 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7936 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7937 (bidi_cache_search, bidi_cache_iterator_state)
7938 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7939 (bidi_level_of_next_char, bidi_move_to_visually_next):
7940 Support character positions inside a run of characters covered by a
7942 (bidi_paragraph_init, bidi_resolve_explicit_1)
7943 (bidi_level_of_next_char): Call bidi_fetch_char and
7944 bidi_fetch_char_advance instead of FETCH_CHAR and
7946 (bidi_init_it): Initialize new members.
7947 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7949 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7950 instead of using explicit *_CHAR codes.
7951 (bidi_resolve_explicit, bidi_resolve_weak):
7952 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7953 bidirectional text is supported only in multibyte buffers.
7954 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7955 it to initialize the frame_window_p member of struct bidi_it.
7956 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7957 (bidi_resolve_explicit, bidi_resolve_weak)
7958 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7959 bidi_it->nchars is non-positive.
7960 (bidi_level_of_next_char): Don't try to lookup the cache for the
7961 next/previous character if nothing is cached there yet, or if we
7962 were just reseat()'ed to a new position.
7964 * xdisp.c (set_cursor_from_row): Set start and stop points
7965 according to the row's direction when priming the loop that looks
7966 for the glyph on which to display cursor.
7967 (single_display_spec_intangible_p): Function deleted.
7968 (display_prop_intangible_p): Reimplement to call
7969 handle_display_spec instead of single_display_spec_intangible_p.
7970 Accept 3 additional arguments needed by handle_display_spec.
7971 This fixes incorrect cursor motion across display property with complex
7972 values: lists, `(when COND...)' forms, etc.
7973 (single_display_spec_string_p): Support property values that are
7974 lists with the argument STRING its top-level element.
7975 (display_prop_string_p): Fix the condition for processing a
7976 property that is a list to be consistent with handle_display_spec.
7977 (handle_display_spec): New function, refactored from the
7978 last portion of handle_display_prop.
7979 (compute_display_string_pos): Accept additional argument
7980 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7981 value of a `display' property is a "replacing spec".
7982 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7983 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7984 the display property, but just return a value indicating whether
7985 the display property will replace the characters it covers.
7986 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7987 frame_window_p members of struct bidi_it.
7988 (compute_display_string_pos, compute_display_string_end):
7990 (push_it): Accept second argument POSITION, where pop_it should
7991 jump to continue iteration.
7992 (reseat_1): Initialize bidi_it.disp_pos.
7994 * keyboard.c (adjust_point_for_property): Adjust the call to
7995 display_prop_intangible_p to its new signature.
7997 * dispextern.h (struct bidi_it): New member frame_window_p.
7998 (bidi_init_it): Update prototypes.
7999 (display_prop_intangible_p): Update prototype.
8000 (compute_display_string_pos, compute_display_string_end):
8002 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8005 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8007 Malloc failure behavior now depends on size of allocation.
8008 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8009 * lisp.h: Change signatures accordingly.
8010 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8011 All callers changed. (Bug#8762)
8013 * gnutls.c: Use Emacs's memory allocators.
8014 Without this change, the gnutls library would invoke malloc etc.
8015 directly, which causes problems on non-SYNC_INPUT hosts, and which
8016 runs afoul of improving memory_full behavior. (Bug#8761)
8017 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8018 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8019 xfree instead of the default malloc, realloc, free.
8020 (Fgnutls_boot): No need to check for memory allocation failure,
8021 since xmalloc does that for us.
8023 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8024 * category.c (hash_get_category_set):
8025 * ccl.c (ccl_driver):
8026 * charset.c (Fdefine_charset_internal):
8027 * charset.h (struct charset.hash_index):
8028 * composite.c (get_composition_id, gstring_lookup_cache)
8029 (composition_gstring_put_cache):
8030 * composite.h (struct composition.hash_index):
8031 * dispextern.h (struct image.hash):
8032 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8033 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8034 (hashfn_equal, hashfn_user_defined, make_hash_table)
8035 (maybe_resize_hash_table, hash_lookup, hash_put)
8036 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8037 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8038 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8039 * image.c (make_image, search_image_cache, lookup_image)
8040 (xpm_put_color_table_h):
8041 * lisp.h (struct Lisp_Hash_Table):
8042 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8043 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8044 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8045 * alloc.c (allocate_vectorlike):
8046 Check for overflow in vector size calculations.
8047 * ccl.c (ccl_driver):
8048 Check for overflow when converting EMACS_INT to int.
8049 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8050 need to be updated by these changes.
8051 * fns.c (make_hash_table, maybe_resize_hash_table):
8052 Check for integer overflow with large hash tables.
8053 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8054 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8055 (SXHASH_REDUCE): New macro.
8056 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8057 Use it instead of discarding useful hash info with large hash values.
8058 (sxhash_float): New function.
8059 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8060 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8061 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8062 Rewrite to use FIXNUM_BITS, as this simplifies things.
8063 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8064 Adjust signatures to match updated version of code.
8065 (consing_since_gc): Now EMACS_INT, since a single hash table can
8066 use more than INT_MAX bytes.
8068 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8070 Make it possible to build with GCC-4.6+ -O2 -flto.
8072 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8074 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8076 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8077 Call minibuffer-inactive-mode.
8079 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8081 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8082 Update dependencies.
8084 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8086 * data.c (init_data): Remove code for UTS, this system is not
8089 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8091 Don't force ./temacs to start in terminal mode.
8093 * frame.c (make_initial_frame): Initialize faces in all cases, not
8094 only when CANNOT_DUMP is defined.
8095 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8097 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8099 * dispnew.c (add_window_display_history): Use const for the string
8100 pointer. Remove declaration, not needed.
8102 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8104 Use 'inline', not 'INLINE'.
8105 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8106 * alloc.c, fontset.c (INLINE): Remove.
8107 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8108 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8109 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8110 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8111 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8113 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8115 Make it possible to run ./temacs.
8117 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8118 syms_of_callproc does the same thing. Remove test for
8119 "initialized", do it in the caller.
8120 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8122 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8124 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8125 (read_minibuf): Use get_minibuffer.
8126 (syms_of_minibuf): Use DEFSYM.
8127 (Qmetadata): New var.
8128 * data.c (Qbuffer): Don't make it static.
8129 (syms_of_data): Use DEFSYM.
8131 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8133 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8134 (CCL_CODE_MIN): New macro.
8136 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8138 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8140 * eval.c (Qdebug): Now static.
8141 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8142 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8143 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8145 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8147 * image.c: Various fixes to ImageMagick code comments.
8148 (Fimagemagick_types): Doc fix.
8150 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8152 Minor fixes prompted by GCC 4.6.0 warnings.
8154 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8156 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8157 (x_clipboard_manager_save_all): Move extern decl to ...
8158 * xterm.h: ... here, so that it can be checked for consistency.
8160 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8162 * xselect.c (x_clipboard_manager_save_frame)
8163 (x_clipboard_manager_save_all): New functions.
8164 (Fx_clipboard_manager_save): Lisp function deleted.
8166 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8167 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8169 * xterm.h: Update prototype.
8171 2011-05-28 William Xu <william.xwl@gmail.com>
8173 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8176 2011-05-28 Jim Meyering <meyering@redhat.com>
8178 Avoid a sign-extension bug in crypto_hash_function.
8179 * fns.c (to_uchar): Define.
8180 (crypto_hash_function): Use it to convert some newly-signed
8181 variables to unsigned, to avoid sign-extension bugs. For example,
8182 without this change, (md5 "truc") would evaluate to
8183 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8184 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8185 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8187 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8189 Integer overflow fixes.
8191 * dbusbind.c: Serial number integer overflow fixes.
8192 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8193 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8194 to hold a serial number that is too large for a fixnum.
8195 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8196 Check for serial numbers out of range. Decode any serial number
8197 that was so large that it became a float. (Bug#8722)
8199 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8200 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8201 Use XFASTINT rather than XUINT when numbers are nonnegative.
8202 (xd_append_arg, Fdbus_method_return_internal):
8203 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8204 arguments, check that Lisp number is nonnegative, rather than
8205 silently wrapping negative numbers around. (Bug#8722)
8206 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8209 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8211 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8213 ccl: Add integer overflow checks.
8214 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8215 (IN_INT_RANGE): New macros.
8216 (ccl_driver): Use them to check for integer overflow when
8217 decoding a CCL program. Many of the new checks are whether XINT (x)
8218 fits in int; it doesn't always, on 64-bit hosts. The new version
8219 doesn't catch all possible integer overflows, but it's an
8220 improvement. (Bug#8719)
8222 * alloc.c (make_event_array): Use XINT, not XUINT.
8223 There's no need for unsigned here.
8225 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8226 This follows up to the 2011-05-06 change that substituted uintptr_t
8227 for EMACS_INT. This case wasn't caught back then.
8229 Rework Fformat to avoid integer overflow issues.
8230 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8231 now (part of C89). Include <verify.h>.
8232 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8233 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8234 (Fformat): Avoid the prepass trying to compute sizes; it was only
8235 approximate and thus did not catch overflow reliably. Instead, walk
8236 through the format just once, formatting and computing sizes as we go,
8237 checking for integer overflow at every step, and allocating a larger
8238 buffer as needed. Keep track separately whether the format is
8239 multibyte. Keep only the most-recently calculated precision, rather
8240 than them all. Record whether each argument has been converted to
8241 string. Use EMACS_INT, not int, for byte and char and arg counts.
8242 Support field widths and precisions larger than INT_MAX. Avoid
8243 sprintf's undefined behavior with conversion specifications such as %#d
8244 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8245 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8246 formatting out-of-range floating point numbers with int
8249 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8251 * data.c: Avoid integer truncation in expressions involving floats.
8252 * data.c: Include <intprops.h>.
8253 (arith_driver): When there's an integer overflow in an expression
8254 involving floating point, convert the integers to floating point
8255 so that the resulting value does not suffer from catastrophic
8256 integer truncation. For example, on a 64-bit host (* 4
8257 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8258 Do not rely on undefined behavior after integer overflow.
8260 merge count_size_as_multibyte, parse_str_to_multibyte
8261 * character.c, character.h (count_size_as_multibyte):
8262 Rename from parse_str_to_multibyte; all uses changed.
8263 Check for integer overflow.
8264 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8265 since it's now a duplicate of the other. This is more of
8266 a character than a buffer op, so better that it's in character.c.
8267 * fns.c, print.c: Adjust to above changes.
8269 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8271 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8273 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8275 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8276 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8277 (x_clipboard_manager_save): Now static.
8278 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8280 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8281 (crypto_hash_function): Now static.
8282 Fix pointer signedness problems. Avoid unnecessary initializations.
8284 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8286 * termhooks.h (Vselection_alist): Make it terminal-local.
8288 * terminal.c (create_terminal): Initialize it.
8290 * xselect.c: Support for clipboard managers.
8291 (Vselection_alist): Move to termhooks.h as terminal-local var.
8292 (LOCAL_SELECTION): New macro.
8293 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8294 (symbol_to_x_atom): Remove gratuitous arg.
8295 (x_handle_selection_request, lisp_data_to_selection_data)
8296 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8297 (x_own_selection, x_get_local_selection, x_convert_selection):
8298 New arg, specifying work frame. Use terminal-local Vselection_alist.
8299 (some_frame_on_display): Delete unused function.
8300 (Fx_own_selection_internal, Fx_get_selection_internal)
8301 (Fx_disown_selection_internal, Fx_selection_owner_p)
8302 (Fx_selection_exists_p): New optional frame arg.
8303 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8304 (x_handle_selection_clear): Don't treat other terminals with the
8305 same keyboard specially. Use the terminal-local Vselection_alist.
8306 (x_clear_frame_selections): Use Frun_hook_with_args.
8308 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8310 * xterm.h: Add support for those atoms.
8312 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8314 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8315 (converted_selections, conversion_fail_tag): New global variables.
8316 (x_selection_request_lisp_error): Free the above.
8317 (x_get_local_selection): Remove unnecessary code.
8318 (x_reply_selection_request): Args changed; handle arbitrary array
8319 of converted selections stored in converted_selections.
8320 Separate the XChangeProperty and SelectionNotify steps.
8321 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8322 (x_convert_selection): New function.
8323 (x_handle_selection_event): Simplify.
8324 (x_get_foreign_selection): Don't ignore incoming requests while
8325 waiting for an answer; this will fail when we implement
8326 SAVE_TARGETS, and seems unnecessary anyway.
8327 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8328 (Vx_sent_selection_functions): Doc fix.
8330 2011-05-26 Leo Liu <sdl.web@gmail.com>
8332 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8334 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8336 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8338 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8339 for fringe update if it has periodic bitmap.
8340 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8341 and fringe_bitmap_periodic_p.
8343 * fringe.c (get_fringe_bitmap_data): New function.
8344 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8345 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8346 row. Mark glyph row for fringe update if periodicity changed.
8348 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8349 for fringe update unless it has periodic bitmap.
8351 2011-05-25 Kenichi Handa <handa@m17n.org>
8353 * xdisp.c (get_next_display_element): Set correct it->face_id for
8354 a static composition.
8356 2011-05-24 Leo Liu <sdl.web@gmail.com>
8359 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8361 * fns.c (crypto_hash_function, Fsha1): New function.
8362 (Fmd5): Use crypto_hash_function.
8363 (syms_of_fns): Add Ssha1.
8365 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8367 * gnutls.c: Remove unused macros.
8368 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8369 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8370 Remove macros that are defined and never used.
8371 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8373 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8375 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8376 (Fx_get_selection_internal): Minor cleanup.
8377 (Fx_own_selection_internal): Rename arguments for consistency with
8380 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8382 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8384 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8386 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8388 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8390 * dispnew.c (scrolling_window): Don't exclude the case that the
8391 last enabled row in the desired matrix touches the bottom boundary.
8393 2011-05-21 Glenn Morris <rgm@gnu.org>
8395 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8396 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8397 and add some more files.
8399 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8401 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8402 report_file_error introduced by the change from 2011-05-07.
8404 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8406 * systime.h (Time): Define only if emacs is defined.
8407 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8408 where the include path doesn't have X11/X.h by default. See
8409 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8411 2011-05-20 Kenichi Handa <handa@m17n.org>
8413 * composite.c (find_automatic_composition): Fix previous change.
8415 2011-05-20 Glenn Morris <rgm@gnu.org>
8417 * lisp.mk: New file, split from Makefile.in.
8418 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8419 (shortlisp): Remove.
8420 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8422 2011-05-19 Glenn Morris <rgm@gnu.org>
8424 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8425 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8426 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8427 (lisp): Set the order to that of loadup.el.
8428 (shortlisp): Make it a copy of $lisp.
8429 (SOME_MACHINE_LISP): Remove.
8430 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8431 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8433 2011-05-18 Kenichi Handa <handa@m17n.org>
8435 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8436 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8437 (find_automatic_composition): Mostly rewrite for efficiency.
8439 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8441 * makefile.w32-in: Update dependencies.
8443 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8445 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8446 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8448 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8450 Fix some integer overflow issues, such as string length overflow.
8452 * insdel.c (count_size_as_multibyte): Check for string overflow.
8454 * character.c (lisp_string_width): Check for string overflow.
8455 Use EMACS_INT, not int, for string indexes and lengths; in
8456 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8457 the resulting string length overflows an EMACS_INT; instead,
8458 report a string overflow if no precision given. When checking for
8459 precision exhaustion, use a check that cannot possibly have
8460 integer overflow. (Bug#8675)
8461 * character.h (lisp_string_width): Adjust to new signature.
8463 * alloc.c (string_overflow): New function.
8464 (Fmake_string): Use it. This doesn't change behavior, but saves
8465 a few bytes and will simplify future changes.
8466 * character.c (string_escape_byte8): Likewise.
8467 * lisp.h (string_overflow): New decl.
8469 Fixups, following up to the user-interface timestamp change.
8470 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8471 for UI timestamps, instead of unsigned long.
8472 * msdos.c (mouse_get_pos): Likewise.
8473 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8474 * w32gui.h (Time): Define by including "systime.h" rather than by
8475 declaring it ourselves. (Bug#8664)
8477 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8478 * image.c (clear_image_cache): Likewise.
8480 * term.c (term_mouse_position): Don't assume time_t wraparound.
8482 Be more systematic about user-interface timestamps.
8483 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8484 and sometimes 'EMACS_UINT', to represent these timestamps.
8485 This change causes it to use 'Time' uniformly, as that's what X uses.
8486 This makes the code easier to follow, and makes it easier to catch
8487 integer overflow bugs such as Bug#8664.
8488 * frame.c (Fmouse_position, Fmouse_pixel_position):
8489 Use Time, not unsigned long, for user-interface timestamps.
8490 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8491 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8492 * keyboard.h (last_event_timestamp): Likewise.
8493 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8494 * menu.h (xmenu_show): Likewise.
8495 * term.c (term_mouse_position): Likewise.
8496 * termhooks.h (struct input_event.timestamp): Likewise.
8497 (struct terminal.mouse_position_hook): Likewise.
8498 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8499 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8500 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8501 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8503 * menu.h, termhooks.h: Include "systime.h", for Time.
8505 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8506 Don't assume that the difference between two unsigned long values
8507 can fit into an integer. At this point, we know button_down_time
8508 <= event->timestamp, so the difference must be nonnegative, so
8509 there's no need to cast the result if double-click-time is
8510 nonnegative, as it should be; check that it's nonnegative, just in
8511 case. This bug is triggered when events are more than 2**31 ms
8512 apart (about 25 days). (Bug#8664)
8514 * xselect.c (last_event_timestamp): Remove duplicate decl.
8515 (x_own_selection): Remove needless cast to unsigned long.
8517 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8518 that always fit in int. Use a sentinel instead of a counter, to
8519 avoid a temp and to allay GCC's concerns about possible int overflow.
8520 * frame.h (struct frame): Use int for menu_bar_items_used
8521 instead of EMACS_INT, since it always fits in int.
8523 * menu.c (grow_menu_items): Check for int overflow.
8525 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8527 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8528 Before, the code was not consistent. These values cannot exceed
8529 2**31 - 1 so there's no need to make them unsigned.
8530 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8531 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8532 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8534 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8536 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8537 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8538 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8539 presumably because the widths might not match.
8541 * window.c (size_window): Avoid needless test at loop start.
8543 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8545 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8547 2011-05-12 Drew Adams <drew.adams@oracle.com>
8549 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8551 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8553 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8554 `width' to `bar_area_x' and `bar_area_width', respectively.
8555 (x_scroll_run): Take account of fringe background extension.
8557 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8558 Rename local vars `left' and `width' to `bar_area_x' and
8559 `bar_area_width', respectively.
8560 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8561 background extension.
8563 2011-05-10 Jim Meyering <meyering@redhat.com>
8565 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8567 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8569 * image.c (Finit_image_library): Return t for built-in image types,
8570 like pbm and xbm. (Bug#8640)
8572 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8574 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8576 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8578 * w32console.c (Fset_screen_color): Doc fix.
8579 (Fget_screen_color): New function.
8580 (syms_of_ntterm): Defsubr it.
8582 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8583 unlink the temporary file if Fcall_process didn't create it in the
8585 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8586 child process will be redirected to a file specified with `:file'.
8587 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8588 cue to call_process_cleanup not to close that handle.
8590 2011-05-07 Ben Key <bkey76@gmail.com>
8592 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8593 one of two shell specific rules, either bootstrap-temacs-CMD or
8594 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8595 to the previous implementation of the bootstrap-temacs rule.
8596 The bootstrap-temacs-CMD rule is similar to the previous
8597 implementation of the bootstrap-temacs rule except that it
8598 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8601 These changes, along with some changes to nt/configure.bat,
8602 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8603 earlier fix to add support for --cflags and --ldflags options
8604 that include quotes so that it works whether make uses cmd or
8607 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8609 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8610 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8612 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8613 a string. Handle both cases.
8614 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8615 (Fdbus_register_method): Use Qinvalid_function.
8617 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8619 * makefile.w32-in: Update dependencies.
8620 (LISP_H): Add inttypes.h and stdin.h.
8621 (PROCESS_H): Add unistd.h.
8623 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8625 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8626 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8628 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8630 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8632 * term.c (vfatal): Remove stray call to va_end.
8633 It's not needed and the C Standard doesn't allow it here anyway.
8635 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8636 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8638 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8641 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8643 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8645 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8647 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8649 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8651 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8652 * charset.c (Fdefine_charset_internal): Don't initialize
8653 charset.code_space[15]. The value was garbage, on hosts with
8654 32-bit int (Bug#8600).
8656 * lread.c (read_integer): Be more consistent with string-to-number.
8657 Use string_to_number to do the actual conversion; this avoids
8658 rounding errors and fixes some other screwups. Without this fix,
8659 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8660 (digit_to_number): Move earlier, for benefit of read_integer.
8661 Return -1 if the digit is out of range for the base, -2 if it is
8662 not a digit in any supported base. (Bug#8602)
8664 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8666 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8667 to match comment at start of function. This also removes a
8668 GCC warning about overflow in a 32+64-bit port.
8670 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8672 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8673 Reported by Stefan Monnier in
8674 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8675 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8676 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8678 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8679 (EMACS_UINTPTR): Likewise, with uintptr_t.
8681 * lisp.h: Prefer 64-bit EMACS_INT if available.
8682 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8683 on 32-bit hosts that have 64-bit int, so that they can access
8685 However, temporarily disable this change unless the temporary
8686 symbol WIDE_EMACS_INT is defined.
8688 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8690 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8691 This removes an assumption that EMACS_INT and long are the same
8692 width as pointers. The assumption is true for Emacs porting targets
8693 now, but we want to make other targets possible.
8694 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8695 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8696 In the rest of the code, change types of integers that hold casted
8697 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8698 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8699 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8700 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8701 No need to cast type when ORing.
8702 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8703 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8704 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8705 assume EMACS_INT is the same width as char *.
8706 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8707 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8708 Remove no-longer-needed casts.
8709 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8710 (xg_tool_bar_help_callback, xg_make_tool_item):
8711 Use EMACS_INTPTR to hold an integer
8712 that will be cast to void *; this can avoid a GCC warning
8713 if EMACS_INT is not the same width as void *.
8714 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8715 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8716 (current_message_1, set_message_1):
8717 Use a local to convert to proper width without a cast.
8718 * xmenu.c (dialog_selection_callback): Likewise.
8720 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8721 Also, don't assume VALBITS / RAND_BITS is less than 5,
8722 and don't rely on undefined behavior when shifting a 1 left into
8724 * lisp.h (get_random): Change signature to match.
8726 * lread.c (hash_string): Use size_t, not int, for hash computation.
8727 Normally we prefer signed values; but hashing is special, because
8728 it's better to use unsigned division on hash table sizes so that
8729 the remainder is nonnegative. Also, size_t is the natural width
8730 for hashing into memory. The previous code used 'int', which doesn't
8731 retain enough info to hash well into very large tables.
8732 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8734 * dbusbind.c: Don't possibly lose pointer info when converting.
8735 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8736 Use XPNTR rather than XHASH, so that the high-order bits of
8737 the pointer aren't lost when converting through void *.
8739 * eval.c (Fautoload): Don't double-shift a pointer.
8741 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8743 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8745 * gnutls.c (DEF_GNUTLS_FN):
8746 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8748 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8750 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8753 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8755 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8756 New version that can reserve upto 2GB of heap space.
8758 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8760 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8762 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8764 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8765 `gnutls_certificate_set_x509_key_file'.
8767 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8769 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8770 Update dependencies.
8772 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8774 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8775 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8776 Remove unused parameter `fildes'.
8777 * process.c (read_process_output, send_process): Don't pass it.
8779 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8781 Fix previous change: the library cache is defined in w32.c.
8782 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8783 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8785 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8787 Implement dynamic loading of GnuTLS on Windows.
8789 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8790 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8791 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8794 * gnutls.c (Qgnutls_dll): Define.
8795 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8796 (gnutls_*): Declare function pointers.
8797 (init_gnutls_functions): New function to initialize function pointers.
8798 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8799 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8800 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8801 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8802 (emacs_gnutls_write, emacs_gnutls_read)
8803 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8804 (Fgnutls_available_p): New function.
8805 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8806 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8807 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8809 * image.c: Include w32.h.
8810 (Vimage_type_cache): Delete.
8811 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8812 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8813 (w32_delayed_load): Move to w32.c.
8815 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8817 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8818 (w32_delayed_load): Move from image.c. When loading a library, record
8819 its filename in the :loaded-from property of the library id.
8820 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8821 Initialize and staticpro them.
8822 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8824 * process.c: Include lisp.h before w32.h, not after.
8825 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8826 instead of gnutls_record_check_pending.
8828 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8830 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8832 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8833 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8836 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8838 * xterm.c (x_set_frame_alpha): Do not set property on anything
8839 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8841 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8843 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8845 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8847 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8848 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8849 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8850 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8851 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8852 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8853 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8854 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8855 (Qgnutls_bootprop_callbacks_verify): Make static.
8857 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8859 * callproc.c: Indentation fixup.
8861 * sysdep.c (wait_for_termination_1): Make static.
8862 (wait_for_termination, interruptible_wait_for_termination):
8863 Move after wait_for_termination_1.
8865 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8867 * sysdep.c (interruptible_wait_for_termination): New function
8868 which is like wait_for_termination, but allows keyboard
8871 * callproc.c (Fcall_process): Add (:file "file") as an option for
8873 (Fcall_process_region): Ditto.
8875 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8877 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8878 rather than `XVECTOR (FOO)->size'.
8880 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8881 inttypes.h, as a gnulib replacement is used if it not available in
8884 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8886 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8887 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8888 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8890 * coding.c (coding_alloc_by_realloc): Error out if destination
8891 will grow beyond MOST_POSITIVE_FIXNUM.
8892 (decode_coding_emacs_mule): Abort if there isn't enough place in
8893 charbuf for the composition carryover bytes. Reserve an extra
8894 space for up to 2 characters produced in a loop.
8895 (decode_coding_iso_2022): Abort if there isn't enough place in
8896 charbuf for the composition carryover bytes.
8898 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8900 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8901 aborting when %lld or %lll format is passed.
8902 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8903 %llo or %llx format is passed. (Bug#8545)
8905 * window.c (window_scroll_line_based): Use a marker instead of
8906 simple variables to record original value of point. (Bug#7952)
8908 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8909 produced by %s or %c overflows available buffer space. (Bug#8545)
8911 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8913 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8914 (SIZE_MAX): Move defn after all includes, as they might #define it.
8916 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8918 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8920 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8922 * keyboard.c (Qdelayed_warnings_hook): Define.
8923 (command_loop_1): Run `delayed-warnings-hook'
8924 if Vdelayed_warnings_list is non-nil.
8925 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8926 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8928 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8930 * doprnt.c (doprnt): Don't return value smaller than the buffer
8931 size if the message was truncated. (Bug#8545).
8933 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8935 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8936 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8938 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8940 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8942 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8944 * makefile.w32-in: Update dependencies.
8946 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8948 Improve `doprnt' and its usage. (Bug#8545)
8949 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8950 `format_end'. Remove support for %l as a conversion specifier.
8951 Don't use xrealloc. Improve diagnostics when the %l size modifier
8952 is used. Update the commentary.
8954 * eval.c (verror): Simplify calculation of size_t.
8956 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8959 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8961 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8964 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8966 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8967 This makes this file independent of the recent pseudovector change.
8969 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8971 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8973 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8974 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8975 Remove unused local.
8976 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8978 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8979 GCC 4.6.0 optimizes based on type-based alias analysis.
8980 For example, if b is of type struct buffer * and v of type struct
8981 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8982 != &v->size, and therefore "v->size = 1; b->size = 2; return
8983 v->size;" must therefore return 1. This assumption is incorrect
8984 for Emacs, since it type-puns struct Lisp_Vector * with many other
8985 types. To fix this problem, this patch adds a new type struct
8986 vectorlike_header that documents the constraints on layout of vectors
8987 and pseudovectors, and helps optimizing compilers not get fooled
8988 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8989 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8990 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8992 (XSETPVECTYPE): Rewrite in terms of new macro.
8993 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8994 This is a bit clearer, and further avoids the possibility of
8995 undesirable aliasing.
8996 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8997 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8998 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8999 since Lisp_Subr is a special case (no "next" field).
9000 (ASIZE): Now uses header.size rather than size.
9001 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9002 to avoid the hassle of writing XVECTOR (foo)->header.size.
9003 (struct vectorlike_header): New type.
9004 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9005 object, to help avoid aliasing.
9006 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9007 (SUBRP): Likewise, since Lisp_Subr is a special case.
9008 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9009 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9010 (struct Lisp_Hash_Table): Combine first two members into a single
9011 struct vectorlike_header member. All uses of "size" and "next" members
9012 changed to be "header.size" and "header.next".
9013 * buffer.h (struct buffer): Likewise.
9014 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9015 * frame.h (struct frame): Likewise.
9016 * process.h (struct Lisp_Process): Likewise.
9017 * termhooks.h (struct terminal): Likewise.
9018 * window.c (struct save_window_data, struct saved_window): Likewise.
9019 * window.h (struct window): Likewise.
9020 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9021 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9022 * buffer.c (init_buffer_once): Likewise.
9023 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9025 * process.c (Fformat_network_address): Use local var for size,
9028 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9030 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9031 * data.c (atof): Remove decl; no longer used or needed.
9032 (digit_to_number): Move to lread.c.
9033 (Fstring_to_number): Use new string_to_number function, to be
9034 consistent with how the Lisp reader treats infinities and NaNs.
9035 Do not assume that floating-point numbers represent EMACS_INT
9036 without losing information; this is not true on most 64-bit hosts.
9037 Avoid double-rounding errors, by insisting on integers when
9038 parsing non-base-10 numbers, as the documentation specifies.
9039 * lisp.h (string_to_number): New decl, replacing ...
9040 (isfloat_string): Remove.
9041 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9042 (read1): Do not accept +. and -. as integers; this
9043 appears to have been a coding error. Similarly, do not accept
9044 strings like +-1e0 as floating point numbers. Do not report
9045 overflow for integer overflows unless the base is not 10 which
9046 means we have no simple and reliable way to continue.
9047 Break out the floating-point parsing into a new
9048 function string_to_number, so that Fstring_to_number parses
9049 floating point numbers consistently with the Lisp reader.
9050 (digit_to_number): Move here from data.c. Make it static inline.
9051 (E_CHAR, EXP_INT): Remove, replacing with ...
9052 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9053 (string_to_number): New function, replacing isfloat_string.
9054 This function checks for valid syntax and produces the resulting
9055 Lisp float number too. Rework it so that string-to-number
9056 no longer mishandles examples like "1.0e+". Use strtoumax,
9057 so that overflow for non-base-10 numbers is reported only when
9058 there's no portable and simple way to convert to floating point.
9060 * textprop.c (set_text_properties_1): Rewrite for clarity,
9061 and to avoid GCC warning about integer overflow.
9063 * intervals.h (struct interval): Use EMACS_INT for members
9064 where EMACS_UINT might cause problems. See
9065 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9066 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9067 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9069 (offset_intervals): Tell GCC not to worry about length overflow
9070 when negating a negative length.
9072 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9073 (overrun_check_free): Likewise.
9075 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9076 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9079 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9080 (gnutls_make_error): Rename local to avoid shadowing.
9081 (gnutls_emacs_global_deinit): ifdef out; not used.
9082 (Fgnutls_boot): Use const for pointer to readonly storage.
9083 Comment out unused local. Fix pointer signedness problems.
9085 * lread.c (openp): Don't stuff size_t into an 'int'.
9086 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9087 about possible signed overflow.
9089 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9090 (GDK_KEY_g): Don't define if already defined.
9091 (xg_prepare_tooltip): Avoid pointer signedness problem.
9092 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9094 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9095 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9097 * xfns.c (Fx_window_property): Simplify a bit,
9098 to make a bit faster and to avoid GCC 4.6.0 warning.
9099 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9101 * fns.c (internal_equal): Don't assume size_t fits in int.
9103 * alloc.c (compact_small_strings): Tighten assertion a little.
9105 Replace pEd with more-general pI, and fix some printf arg casts.
9106 * lisp.h (pI): New macro, generalizing old pEd macro to other
9107 conversion specifiers. For example, use "...%"pI"d..." rather
9108 than "...%"pEd"...".
9109 (pEd): Remove. All uses replaced with similar uses of pI.
9110 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9111 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9112 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9113 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9114 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9115 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9116 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9118 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9119 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9120 * print.c (safe_debug_print, print_object): Likewise.
9121 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9123 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9124 avoiding the 0 flag, which is not portable.
9125 * process.c (Fmake_network_process): Use pI to avoid cast.
9126 * region-cache.c (pp_cache): Likewise.
9127 * xdisp.c (decode_mode_spec): Likewise.
9128 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9129 behavior on 64-bit hosts with printf arg.
9130 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9131 (x_stop_queuing_selection_requests): Likewise.
9132 (x_get_window_property): Don't truncate byte count to an 'int'
9135 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9136 here, since it parses constructs like leading '-' and spaces,
9137 which are not wanted; and it overflows with large numbers.
9138 Instead, simply match F[0-9]+, which is what is wanted anyway.
9140 * alloc.c: Remove unportable assumptions about struct layout.
9141 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9142 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9143 (allocate_vectorlike, make_pure_vector): Use the new macros,
9144 plus offsetof, to remove unportable assumptions about struct layout.
9145 These assumptions hold on all porting targets that I know of, but
9146 they are not guaranteed, they're easy to remove, and removing them
9147 makes further changes easier.
9149 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9150 This doesn't fix a bug but makes the code clearer.
9151 (string_overrun_cookie): Now const. Use initializers that
9152 don't formally overflow signed char, to avoid warnings.
9153 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9154 can cause Emacs to crash when string overrun checking is enabled.
9155 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9156 multiple of sizeof (EMACS_INT); it need not be, if
9157 alignof(EMACS_INT) < sizeof (EMACS_INT).
9158 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9160 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9162 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9164 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9166 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9167 supposed to be handshaking. (Bug#8556)
9168 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9170 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9172 * lisp.h (Qdebug): List symbol.
9173 * eval.c (Qdebug): Restore global linkage.
9174 * keyboard.c (debug-on-event): New variable.
9175 (handle_user_signal): Break into debugger when debug-on-event
9176 matches the current signal symbol.
9178 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9180 * alloc.c (check_sblock, check_string_bytes)
9181 (check_string_free_list): Convert to standard C.
9183 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9185 * w32.c (emacs_gnutls_push): Fix typo.
9187 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9189 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9190 "cast to pointer from integer of different size".
9192 Improve doprnt and its use in verror. (Bug#8545)
9193 * doprnt.c (doprnt): Document the set of format control sequences
9194 supported by the function. Use SAFE_ALLOCA instead of always
9197 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9198 is one byte too soon. Don't use xrealloc; instead xfree and
9201 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9203 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9206 * gnutls.c: Renamed global_initialized to
9207 gnutls_global_initialized. Added internals for the
9208 :verify-hostname-error, :verify-error, and :verify-flags
9209 parameters of `gnutls-boot' and documented those parameters in the
9210 docstring. Start callback support.
9211 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9212 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9213 on error. Return error code.
9214 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9215 (emacs_gnutls_read): Likewise.
9216 (Fgnutls_boot): Return handshake error code.
9217 (emacs_gnutls_handle_error): New function.
9218 (wsaerror_to_errno): Likewise.
9220 * w32.h (emacs_gnutls_pull): Add prototype.
9221 (emacs_gnutls_push): Likewise.
9223 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9224 (emacs_gnutls_push): Likewise.
9226 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9228 * process.c (wait_reading_process_output): Check if GnuTLS
9229 buffered some data internally if no FDs are set for TLS
9232 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9233 (LIBS): Link to USER_LIBS.
9234 ($(BLD)/gnutls.$(0)): New target.
9236 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9238 * xdisp.c (handle_single_display_spec): Rename the
9239 display_replaced_before_p argument into display_replaced_p, to
9240 make it consistent with the commentary. Fix typos in the
9243 * textprop.c (syms_of_textprop): Remove dead code.
9244 (copy_text_properties): Delete obsolete commentary about an
9245 interface that was deleted long ago. Fix typos in the description
9248 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9249 to changes in oldXMenu/XMenu.h from 2011-04-16.
9250 <menu_help_message, prev_menu_help_message>: Constify.
9251 (IT_menu_make_room): menu->help_text is now `const char **';
9254 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9255 to changes in oldXMenu/XMenu.h from 2011-04-16.
9256 (struct XMenu): Declare `help_text' `const char **'.
9258 * xfaces.c <Qunspecified>: Make extern again.
9260 * syntax.c: Include sys/types.h before including regex.h, as
9263 * doc.c (get_doc_string): Improve the format passed to `error'.
9265 * doprnt.c (doprnt): Improve commentary.
9267 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9269 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9272 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9273 changes in globals.h immediately force recompilation.
9274 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9275 $(CURDIR)/s/ms-w32.h.
9276 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9278 * character.c (Fchar_direction): Function deleted.
9279 (syms_of_character): Don't defsubr it.
9280 <char-direction-table>: Deleted.
9282 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9284 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9285 * doprnt.c: Include limits.h.
9286 (SIZE_MAX): New macro.
9287 (doprnt): Return a size_t value. 2nd arg is now size_t.
9288 Many local variables are now size_t instead of int or unsigned.
9289 Improve overflow protection. Support `l' modifier for integer
9290 conversions. Support %l conversion. Don't assume an EMACS_INT
9291 argument for integer conversions and for %c.
9293 * lisp.h (doprnt): Restore prototype.
9295 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9298 * Makefile.in (base_obj): Add back doprnt.o.
9300 * deps.mk (doprnt.o): Add back prerequisites.
9301 (callint.o): Depend on character.h.
9303 * eval.c (internal_lisp_condition_case): Include the handler
9304 representation in the error message.
9305 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9306 when breaking from the loop.
9308 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9310 * callint.c (Fcall_interactively): When displaying error message
9311 about invalid control letter, pass the character's codepoint, not
9312 a pointer to its multibyte form. Improve display of the character
9313 in octal and display also its hex code.
9315 * character.c (char_string): Use %x to display the (unsigned)
9316 codepoint of an invalid character, to avoid displaying a bogus
9319 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9320 `error', not SYMBOL_NAME itself.
9322 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9323 character arguments to `error'.
9325 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9326 to `error' in error message about FINAL_CHAR argument. Make sure
9327 FINAL_CHAR is a character, and use %c when it is passed as
9328 argument to `error'.
9330 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9332 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9334 * w32.c: Include <time.h>.
9335 (sys_localtime): New function.
9337 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9339 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9341 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9343 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9345 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9348 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9350 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9351 gl_state.e_property when gl_state.object is Qt.
9353 * insdel.c (make_gap_larger): Remove limitation of buffer size
9356 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9358 * xdisp.c (lookup_glyphless_char_display)
9359 (produce_glyphless_glyph): Handle cons cell entry in
9360 glyphless-char-display.
9361 (Vglyphless_char_display): Document it.
9363 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9364 glyphless-char-display.
9366 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9368 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9370 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9372 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9373 definition for no-X builds.
9375 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9377 Static checks with GCC 4.6.0 and non-default toolkits.
9379 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9381 * process.c (keyboard_bit_set): Define only if SIGIO.
9382 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9383 (send_process): Repair possible setjmp clobbering.
9385 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9387 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9389 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9391 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9392 Define only if needed.
9394 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9395 by pacifying GCC about it. Maybe it's time to retire it?
9396 * xfaces.c (USG, __TIMEVAL__): Likewise.
9398 * dispextern.h (struct redisplay_interface): Rename param
9400 * termhooks.h (struct terminal): Likewise.
9401 * xterm.c (xembed_send_message): Likewise.
9403 * insdel.c (make_gap_smaller): Define only if
9404 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9406 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9409 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9410 so that we aren't warned about unused symbols.
9412 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9414 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9416 * xfns.c (x_real_positions): Mark locals as initialized.
9418 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9420 * xterm.c: Fix problems found by static analysis with other toolkits.
9421 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9422 (x_dispatch_event): Declare static if USE_GTK, and
9423 define if USE_GTK || USE_X_TOOLKIT.
9424 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9425 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9426 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9427 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9429 * xmenu.c (menu_help_callback): Pointer type fixes.
9430 Use const pointers when pointing at readonly data. Avoid pointer
9432 (FALSE): Remove unused macro.
9433 (update_frame_menubar): Remove unused decl.
9435 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9437 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9438 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9439 (single_menu_item): Rename local to avoid shadowing.
9441 * keyboard.c (make_lispy_event): Remove unused local var.
9443 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9444 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9446 * bitmaps: Change bitmaps from unsigned char back to the X11
9447 compatible char. Avoid the old compiler warnings about
9448 out-of-range initializers by using, for example, '\xab' rather
9451 * xgselect.c (xgselect_initialize): Check vs interface
9452 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9454 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9456 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9457 to read-only memory.
9459 * fns.c (vector): Remove; this old hack is no longer needed.
9461 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9463 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9465 * xrdb.c (x_load_resources): Omit unused local.
9467 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9468 (x_window): Rename locals to avoid shadowing.
9469 (USG): Use the kludged USG macro, to pacify gcc.
9471 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9472 (x_term_init): Remove local to avoid shadowing.
9474 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9476 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9477 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9479 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9481 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9483 Fix regex.c, syntax.c and friends for buffers > 2GB.
9484 * syntax.h (struct gl_state_s): Declare character position members
9487 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9489 * textprop.c (verify_interval_modification, interval_of):
9490 Declare arguments EMACS_INT.
9492 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9495 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9497 * indent.c (Fvertical_motion): Local variable it_start is now
9500 * regex.c (re_match, re_match_2, re_match_2_internal)
9501 (bcmp_translate, regcomp, regexec, print_double_string)
9502 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9503 (re_compile_pattern, re_exec): Declare arguments and local
9504 variables `size_t' and `ssize_t' and return values `regoff_t', as
9506 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9507 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9508 <compile_stack_type>: `size' and `avail' are now `size_t'.
9510 * regex.h <regoff_t>: Use ssize_t, not int.
9511 (re_search, re_search_2, re_match, re_match_2): Arguments that
9512 specify buffer/string position and length are now ssize_t and
9513 size_t. Return type is regoff_t.
9515 2011-04-16 Ben Key <bkey76@gmail.com>
9517 * nsfont.m: Fixed bugs in ns_get_family and
9518 ns_descriptor_to_entity that were caused by using free to
9519 deallocate memory blocks that were allocated by xmalloc (via
9520 xstrdup). This caused Emacs to crash when compiled with
9521 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9522 --enable-checking=xmallocoverrun). xfree is now used to
9523 deallocate these memory blocks.
9525 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9527 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9529 emacs_write: Accept and return EMACS_INT for sizes.
9530 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9532 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9533 Accept and return EMACS_INT.
9534 (emacs_gnutls_write): Return the number of bytes written on
9536 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9537 (emacs_read, emacs_write): Remove check for negative size, as the
9538 Emacs source code has been audited now.
9539 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9540 (emacs_read, emacs_write): Use it.
9541 * process.c (send_process): Adjust to the new signatures of
9542 emacs_write and emacs_gnutls_write. Do not attempt to store
9543 a byte offset into an 'int'; it might overflow.
9544 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9546 * sound.c: Don't assume sizes fit in 'int'.
9547 (struct sound_device.period_size, alsa_period_size):
9548 Return EMACS_INT, not int.
9549 (struct sound_device.write, vox_write, alsa_write):
9550 Accept EMACS_INT, not int.
9551 (wav_play, au_play): Use EMACS_INT to store sizes and to
9552 record read return values.
9554 2011-04-15 Ben Key <bkey76@gmail.com>
9556 * keyboard.c (Qundefined): Don't declare static since it is used
9558 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9559 static since they are used in nsfont.m.
9561 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9563 * process.c (Qprocessp): Don't declare static.
9564 * lisp.h (Qprocessp): Declare again.
9566 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9568 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9570 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9572 Improve C-level modularity by making more things 'static'.
9574 Don't publish debugger-only interfaces to other modules.
9575 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9576 (verify_bytepos, count_markers): Move decls to the only modules
9578 * region-cache.h (pp_cache): Likewise.
9579 * window.h (check_all_windows): Likewise.
9580 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9582 * sysdep.c (croak): Now static, if
9583 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9584 * syssignal.h (croak): Declare only if not static.
9586 * alloc.c (refill_memory_reserve): Now static if
9587 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9588 * lisp.h (refill_memory_reserve): Declare only if not static.
9590 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9591 Define only if USE_LUCID.
9593 * xrdb.c (x_customization_string, x_rm_string): Now static.
9595 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9596 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9598 * xdisp.c (draw_row_with_mouse_face): Now static.
9599 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9601 * window.h (check_all_windows): Mark externally visible.
9603 * window.c (window_deletion_count): Now static.
9605 * undo.c: Make symbols static if they're not exported.
9606 (last_undo_buffer, last_boundary_position, pending_boundary):
9609 * textprop.c (interval_insert_behind_hooks): Now static.
9610 (interval_insert_in_front_hooks): Likewise.
9612 * term.c: Make symbols static if they're not exported.
9613 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9614 (max_frame_lines, tty_set_terminal_modes):
9615 (tty_reset_terminal_modes, tty_turn_off_highlight):
9616 (get_tty_terminal): Now static.
9617 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9618 * termhooks.h (term_mouse_moveto): Do not declare if
9620 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9621 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9623 * sysdep.c: Make symbols static if they're not exported.
9624 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9626 (sigprocmask_set, full_mask): Remove; unused.
9627 (wait_debugging): Mark as visible.
9628 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9629 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9631 * syntax.c (syntax_temp): Define only if !__GNUC__.
9633 * sound.c (current_sound_device, current_sound): Now static.
9635 * search.c (searchbufs, searchbuf_head): Now static.
9637 * scroll.c (scroll_cost): Remove; unused.
9638 * dispextern.h (scroll_cost): Remove decl.
9640 * region-cache.h (pp_cache): Mark as externally visible.
9642 * process.c: Make symbols static if they're not exported.
9643 (process_tick, update_tick, create_process, chan_process):
9644 (Vprocess_alist, proc_buffered_char, datagram_access):
9645 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9646 (deactivate_process): Mark defn as static, as well as decl.
9647 * lisp.h (create_process): Remove decl.
9648 * process.h (chan_process, Vprocess_alist): Remove decls.
9650 * print.c: Make symbols static if they're not exported.
9651 (print_depth, new_backquote_output, being_printed, print_buffer):
9652 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9653 (print_interval, print_number_index, initial_stderr_stream):
9655 * lisp.h (Fprinc): Remove decl.
9656 (debug_output_compilation_hack): Mark as externally visible.
9658 * sysdep.c (croak): Move decl from here to syssignal.h.
9659 * syssignal.h (croak): Put it here, so the API can be checked when
9660 'croak' is called from dissociate_if_controlling_tty.
9662 * minibuf.c: Make symbols static if they're not exported.
9663 (minibuf_save_list, choose_minibuf_frame): Now static.
9664 * lisp.h (choose_minibuf_frame): Remove decl.
9666 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9668 * lread.c: Make symbols static if they're not exported.
9669 (read_objects, initial_obarray, oblookup_last_bucket_number):
9671 (make_symbol): Remove; unused.
9672 * lisp.h (initial_obarray, make_symbol): Remove decls.
9674 * keyboard.c: Make symbols static if they're not exported.
9675 (single_kboard, recent_keys_index, total_keys, recent_keys):
9676 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9677 (this_single_command_key_start, echoing, last_auto_save):
9678 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9679 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9680 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9681 (Vlispy_mouse_stem, double_click_count):
9683 (force_auto_save_soon): Define only if SIGDANGER.
9684 (ignore_mouse_drag_p): Now static if
9685 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9686 (print_help): Remove; unused.
9687 (stop_character, last_timer_event): Mark as externally visible.
9688 * keyboard.h (ignore_mouse_drag_p): Declare only if
9689 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9690 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9691 * lisp.h (echoing): Remove decl.
9692 (force_auto_save_soon): Declare only if SIGDANGER.
9693 * xdisp.c (redisplay_window): Simplify code, to make it more
9694 obvious that ignore_mouse_drag_p is not accessed if !defined
9695 USE_GTK && !defined HAVE_NS.
9697 * intervals.c: Make symbols static if they're not exported.
9698 (merge_properties_sticky, merge_interval_right, delete_interval):
9700 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9702 * insdel.c: Make symbols static if they're not exported.
9703 However, leave prepare_to_modify_buffer alone. It's never
9704 called from outside this function, but that appears to be a bug.
9705 (combine_after_change_list, combine_after_change_buffer):
9706 (adjust_after_replace, signal_before_change): Now static.
9707 (adjust_after_replace_noundo): Remove; unused.
9708 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9709 (signal_before_change): Remove decls.
9711 * indent.c (val_compute_motion, val_vmotion): Now static.
9713 * image.c: Make symbols static if they're not exported.
9714 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9716 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9717 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9719 * fringe.c (standard_bitmaps): Now static.
9720 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9722 * frame.c: Make symbols static if they're not exported.
9723 (x_report_frame_params, make_terminal_frame): Now static.
9724 (get_frame_param): Now static, unless HAVE_NS.
9725 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9726 (x_get_resource_string): Remove; not used.
9727 * frame.h (make_terminal_frame, x_report_frame_params):
9728 (x_get_resource_string); Remove decls.
9729 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9730 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9732 * font.c, fontset.c: Make symbols static if they're not exported.
9733 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9734 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9735 * font.c (font_close_object): Now static.
9736 * font.h (font_close_object): Remove.
9737 * fontset.c (FONTSET_OBJLIST): Remove.
9738 (free_realized_fontset) #if-0 the body, which does nothing.
9739 (face_suitable_for_char_p): #if-0, as it's never called.
9740 * fontset.h (face_suitable_for_char_p): Remove decl.
9741 * xfaces.c (face_at_string_position):
9742 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9743 since 0 is always ASCII.
9745 * fns.c (weak_hash_tables): Now static.
9747 * fileio.c: Make symbols static if they're not exported.
9748 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9749 (Vwrite_region_annotation_buffers): Now static.
9751 * eval.c: Make symbols static if they're not exported.
9752 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9753 * lisp.h (backtrace_list): Remove decl.
9755 * emacs.c: Make symbols static if they're not exported.
9756 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9757 (fatal_error_code, fatal_error_signal_hook, standard_args):
9759 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9760 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9761 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9762 * lisp.h (fatal_error_signal_hook): Remove decl.
9763 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9765 * editfns.c: Move a (normally-unused) function to its only use.
9766 * editfns.c, lisp.h (get_operating_system_release): Remove.
9767 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9768 worth the hassle of breaking this out.
9770 * xterm.c: Make symbols static if they're not exported.
9771 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9772 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9773 (x_destroy_window, x_delete_display):
9775 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9776 (x_mouse_leave): Remove; unused.
9777 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9778 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9779 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9781 (x_mouse_leave): Declare only if WINDOWSNT.
9782 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9783 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9786 * ftxfont.c: Make symbols static if they're not exported.
9787 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9789 * font.h (ftxfont_driver): Likewise.
9791 * xfns.c: Make symbols static if they're not exported.
9792 (x_last_font_name, x_display_info_for_name):
9793 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9794 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9795 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9796 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9797 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9798 (last_show_tip_args): Now static.
9799 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9800 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9801 (x_screen_planes): Remove; unused.
9802 * dispextern.h (x_screen_planes): Remove decl.
9804 * dispnew.c: Make symbols static if they're not exported.
9805 * dispextern.h (redraw_garbaged_frames, scrolling):
9806 (increment_row_positions): Remove.
9807 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9808 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9810 (redraw_garbaged_frames): Remove; unused.
9812 * xfaces.c: Make symbols static if they're not exported.
9813 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9815 * xterm.h (defined_color): Remove decls.
9816 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9817 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9818 (menu_face_changed_default, defined_color, free_realized_face):
9819 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9820 (ascii_face_of_lisp_face): Remove; unused.
9822 * xdisp.c: Make symbols static if they're not exported.
9823 * dispextern.h (scratch_glyph_row, window_box_edges):
9824 (glyph_to_pixel_coords, set_cursor_from_row):
9825 (get_next_display_element, set_iterator_to_next):
9826 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9827 (show_mouse_face): Remove decls
9828 * frame.h (message_buf_print): Likewise.
9829 * lisp.h (pop_message, set_message, check_point_in_composition):
9831 * xterm.h (set_vertical_scroll_bar): Likewise.
9832 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9833 (message_buf_print, scratch_glyph_row, displayed_buffer):
9834 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9835 (get_next_display_element, show_mouse_face, window_box_edges):
9836 (frame_to_window_pixel_xy, check_point_in_composition):
9837 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9838 (glyph_to_pixel_coords): Remove; unused.
9840 * dired.c (file_name_completion): Now static.
9842 * dbusbind.c (xd_in_read_queued_messages): Now static.
9844 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9845 * data.c (circular_list_error): Remove.
9847 * commands.h (last_point_position, last_point_position_buffer):
9848 (last_point_position_window): Remove decls.
9849 * keyboard.c: Make these variables static.
9851 * coding.h (coding, code_convert_region, encode_coding_gap):
9853 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9854 (iso_code_class, detect_coding, code_convert_region): Now static.
9855 (encode_coding_gap): Remove; unused.
9857 * chartab.c (chartab_chars, chartab_bits): Now static.
9859 * charset.h (charset_iso_8859_1): Remove decl.
9860 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9863 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9864 * ccl.c (Vccl_program_table): Now static.
9865 (check_ccl_update): Remove; unused.
9867 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9868 * category.h: ... from here.
9869 * category.c (check_category_table, set_category_set): Now static.
9871 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9872 * lisp.h: Remove these decls.
9874 * buffer.c (buffer_count): Remove unused var.
9876 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9877 so that it's not optimized away.
9878 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9879 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9880 exported only to the debugger.
9882 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9883 * atimer.h (run_all_atimers): Remove; not exported.
9885 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9886 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9887 was inaccessible from Lisp.
9888 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9889 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9891 alloc.c: Import and export fewer symbols, and remove unused items.
9892 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9894 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9895 it's not optimized away by whole-program optimization.
9896 (message_enable_multibyte, free_misc): Remove.
9897 (catchlist, handlerlist, mark_backtrace):
9898 Declare only if BYTE_MARK_STACK.
9899 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9900 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9901 (message_enable_multibyte): Remove decl.
9902 (free_misc, interval_free_list, float_block, float_block_index):
9903 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9904 (cons_free_list, last_marked_index):
9906 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9907 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9908 (mark_backtrace): Define only if BYTE_MARK_STACK.
9909 * xdisp.c (message_enable_multibyte): Now static.
9911 Declare Lisp_Object Q* variables to be 'static' if not exported.
9912 This makes it easier for human readers (and static analyzers)
9913 to see whether these variables are used from other modules.
9914 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9915 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9916 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9917 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9918 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9919 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9920 * xmenu.c, xselect.c:
9921 Declare Q* vars static if they are not used in other modules.
9922 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9923 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9924 Remove decls of unexported vars.
9925 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9927 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9929 Make Emacs functions such as Fatom 'static' by default.
9930 This makes it easier for human readers (and static analyzers)
9931 to see whether these functions can be called from other modules.
9932 DEFUN now defines a static function. To make the function external
9933 so that it can be used in other C modules, use the new macro DEFUE.
9934 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9935 (Finit_image_library):
9936 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9937 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9938 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9939 Remove decls, since these functions are now static.
9940 (Funintern, Fget_internal_run_time): New decls, since these functions
9941 were already external.
9943 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9944 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9945 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9946 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9947 * keyboard.c, keymap.c, lread.c:
9948 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9949 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9950 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9951 Mark functions with DEFUE instead of DEFUN,
9952 if they are used in other modules.
9953 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9954 decls for now-static functions.
9955 * buffer.h (Fdelete_overlay): Remove decl.
9956 * callproc.c (Fgetenv_internal): Mark as internal.
9957 * composite.c (Fremove_list_of_text_properties): Remove decl.
9958 (Fcomposition_get_gstring): New forward static decl.
9959 * composite.h (Fcomposite_get_gstring): Remove decl.
9960 * dired.c (Ffile_attributes): New forward static decl.
9961 * doc.c (Fdocumntation_property): New forward static decl.
9962 * eval.c (Ffetch_bytecode): New forward static decl.
9963 (Funintern): Remove extern decl; now in .h file where it belongs.
9964 * fileio.c (Fmake_symbolic_link): New forward static decl.
9965 * image.c (Finit_image_library): New forward static decl.
9966 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9967 * intervals.h (Fprevious_property_change):
9968 (Fremove_list_of_text_properties): Remove decls.
9969 * keyboard.c (Fthis_command_keys): Remove decl.
9970 (Fcommand_execute): New forward static decl.
9971 * keymap.c (Flookup_key): New forward static decl.
9972 (Fcopy_keymap): Now static.
9973 * keymap.h (Flookup_key): Remove decl.
9974 * process.c (Fget_process): New forward static decl.
9975 (Fprocess_datagram_address): Mark as internal.
9976 * syntax.c (Fsyntax_table_p): New forward static decl.
9977 (skip_chars): Remove duplicate decl.
9978 * textprop.c (Fprevious_property_change): New forward static decl.
9979 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9981 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9982 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9984 * editfns.c (Fformat): Remove unreachable code.
9986 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9988 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9991 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9993 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9994 when at ZV. (Bug#8487)
9996 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9998 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10000 * keyboard.c (parse_tool_bar_item): Likewise.
10001 * sound.c (sound_cleanup, alsa_close): Likewise.
10002 * termcap.c (tgetent): Likewise.
10003 * xfns.c (x_default_font_parameter): Likewise.
10004 * xsettings.c (read_and_apply_settings): Likewise.
10006 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10007 (overrun_check_free): Protoize.
10009 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10011 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10012 since callers should never pass a negative size.
10013 Change the signature to match that of plain 'read' and 'write'; see
10014 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10015 * lisp.h: Update prototypes of emacs_write and emacs_read.
10017 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10019 * xdisp.c (redisplay_window): Don't try to determine the character
10020 position of the scroll margin if the window start point w->startp
10021 is outside the buffer's accessible region. (Bug#8468)
10023 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10025 Fix write-region and its subroutines for buffers > 2GB.
10026 * fileio.c (a_write, e_write): Modify declaration of arguments and
10027 local variables to support buffers larger than 2GB.
10028 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10030 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10031 argument, local variables, and return value.
10033 * lisp.h: Update prototypes of emacs_write and emacs_read.
10035 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10037 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10039 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10041 Fix more problems found by GCC 4.6.0's static checks.
10043 * xdisp.c (vmessage): Use a better test for character truncation.
10045 * charset.c (load_charset_map): <, not <=, for optimization,
10046 and to avoid potential problems with integer overflow.
10047 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10048 * casetab.c (set_identity, shuffle): Likewise.
10049 * editfns.c (Fformat): Likewise.
10050 * syntax.c (skip_chars): Likewise.
10052 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10053 This also lets GCC 4.6.0 generate slightly better loop code.
10055 * callint.c (Fcall_interactively): <, not <=, for optimization.
10056 (Fcall_interactively): Count the number of arguments produced,
10057 not the number of arguments given. This is simpler and lets GCC
10058 4.6.0 generate slightly better code.
10060 * ftfont.c: Distingish more carefully between FcChar8 and char.
10061 The previous code passed unsigned char * to a functions like
10062 strlen and xstrcasecmp that expect char *, which does not
10063 conform to the C standard.
10064 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10065 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10066 char * when the C standard requires it.
10068 * keyboard.c (read_char): Remove unused var.
10070 * eval.c: Port to Windows vsnprintf (Bug#8435).
10071 Include <limits.h>.
10072 (SIZE_MAX): Define if the headers do not.
10073 (verror): Do not give up if vsnprintf returns a negative count.
10074 Instead, grow the buffer. This ports to Windows vsnprintf, which
10075 does not conform to C99. Problem reported by Eli Zaretskii.
10076 Also, simplify the allocation scheme, by avoiding the need for
10077 calling realloc, and removing the ALLOCATED variable.
10079 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10081 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10082 But keep the doprint source code for now, as we might revamp it
10083 and use it again (Bug#8435).
10084 * lisp.h (doprnt): Remove.
10085 * Makefile.in (base_obj): Remove doprnt.o.
10086 * deps.mk (doprnt.o): Remove.
10088 error: Print 32- and 64-bit integers portably (Bug#8435).
10089 Without this change, on typical 64-bit hosts error ("...%d...", N)
10090 was used to print both 32- and 64-bit integers N, which relied on
10091 undefined behavior.
10092 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10093 * lisp.h (error, verror): Mark as printf-like functions.
10094 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10095 Report overflow in size calculations when allocating printf buffer.
10096 Do not truncate output string at its first null byte.
10097 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10098 Truncate the output at a character boundary, since vsnprintf does not
10100 * charset.c (check_iso_charset_parameter): Convert internal
10101 character to string before calling 'error', since %c now has the
10103 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10104 overflow when computing char to be passed to 'error'. Do not
10105 pass Lisp_Object to 'error'; pass the integer instead.
10106 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10107 formatted with plain %d.
10109 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10111 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10113 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10115 * xterm.c (x_catch_errors): Remove duplicate declaration.
10117 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10119 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10121 2011-04-10 Jim Meyering <meyering@redhat.com>
10123 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10124 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10125 return ssize_t not "int", and use size_t as the buffer length.
10126 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10127 * gnutls.h: Update declarations.
10128 * process.c (read_process_output): Use ssize_t, to match.
10129 (send_process): Likewise.
10131 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10133 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10135 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10137 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10138 Use unsigned char, to match FcChar8 type definition.
10140 * xterm.c (handle_one_xevent):
10141 * xmenu.c (create_and_show_popup_menu):
10142 * xselect.c (x_decline_selection_request)
10143 (x_reply_selection_request): Avoid type-punned deref of X events.
10145 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10147 Fix some uses of `int' instead of EMACS_INT.
10148 * search.c (string_match_1, fast_string_match)
10149 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10150 (scan_buffer, find_next_newline_no_quit)
10151 (find_before_next_newline, search_command, Freplace_match)
10152 (Fmatch_data): Make some `int' variables be EMACS_INT.
10154 * xdisp.c (display_count_lines): 3rd argument and return value now
10155 EMACS_INT. All callers changed.
10156 (pint2hrstr): Last argument is now EMACS_INT.
10158 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10159 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10160 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10161 (decode_coding_utf_16, decode_coding_emacs_mule)
10162 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10163 (decode_coding_ccl, decode_coding_charset)
10164 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10165 (decode_coding_iso_2022, decode_coding_emacs_mule)
10166 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10167 <char_offset, last_offset>: Declare EMACS_INT.
10168 (encode_coding_utf_8, encode_coding_utf_16)
10169 (encode_coding_emacs_mule, encode_invocation_designation)
10170 (encode_designation_at_bol, encode_coding_iso_2022)
10171 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10172 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10174 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10175 (encode_invocation_designation): Last argument P_NCHARS is now
10177 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10178 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10180 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10183 * ccl.c (Fccl_execute_on_string): Declare some variables
10186 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10188 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10190 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10192 * process.c (Fformat_network_address): Doc fix.
10194 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10196 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10198 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10200 * keyboard.c (read_char): Call Lisp function help-form-show,
10201 instead of using internal_with_output_to_temp_buffer.
10202 (Qhelp_form_show): New var.
10203 (syms_of_keyboard): Use DEFSYM macro.
10205 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10207 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10209 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10211 * process.c (Flist_processes): Remove to Lisp.
10212 (list_processes_1): Delete.
10214 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10216 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10218 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10220 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10222 Fix more problems found by GCC 4.6.0's static checks.
10224 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10226 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10228 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10230 * xdisp.c (vmessage): Mark as a printf-like function.
10232 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10234 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10236 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10237 printf-like functions.
10238 (tiff_load): Add casts to remove these marks before passing them
10239 to system-supplied API.
10241 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10243 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10244 This avoids several warnings with gcc -Wstrict-overflow.
10245 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10246 directly, rather than having caller test rule sign. This avoids
10247 some unnecessary tests.
10248 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10249 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10250 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10252 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10253 (xfont_open): Avoid unnecessary tests.
10255 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10257 * composite.h, composite.c (composition_gstring_put_cache):
10258 Use EMACS_INT, not int, for length.
10260 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10261 breaking out part of COMPOSITION_DECODE_RULE.
10262 (COMPOSITION_DECODE_RULE): Use it.
10263 * composite.c (get_composition_id): Remove unused local vars,
10264 by using the new macro.
10266 * textprop.c (set_text_properties_1): Change while to do-while,
10267 since the condition is always true at first.
10269 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10270 (interval_deletion_adjustment): Return unsigned value.
10273 * process.c (list_processes_1, create_pty, read_process_output):
10274 (exec_sentinel): Remove vars that were set but not used.
10275 (create_pty): Remove unnecessary "volatile"s.
10276 (Fnetwork_interface_info): Avoid possibility of int overflow.
10277 (read_process_output): Do adaptive read buffering even if carryover.
10278 (read_process_output): Simplify nbytes computation if buffered.
10280 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10282 * syntax.c (scan_words): Remove var that was set but not used.
10283 (update_syntax_table): Use unsigned instead of int.
10285 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10286 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10287 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10289 * print.c (print_error_message): Avoid int overflow.
10291 * font.c (font_list_entities): Redo for clarity,
10292 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10294 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10295 (font_score): Avoid potential overflow in diff calculation.
10297 * fns.c (substring_both): Remove var that is set but not used.
10298 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10300 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10302 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10303 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10304 can always succeed if overflow has undefined behavior.
10306 * search.c (boyer_moore, wordify): Remove vars set but not used.
10307 (wordify): Omit three unnecessary tests.
10309 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10310 All callers changed. This avoids the need for an unused var.
10312 * casefiddle.c (casify_region): Remove var that is set but not used.
10314 * dired.c (file_name_completion): Remove var that is set but not used.
10316 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10318 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10319 (Finsert_file_contents): Remove unnecessary code checking fd.
10321 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10322 Check for integer overflow on size calculations.
10324 * buffer.c (Fprevious_overlay_change): Remove var that is set
10327 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10328 Remove vars that are set but not used.
10329 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10330 (timer_check_2): Mark vars as initialized.
10332 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10334 * image.c (lookup_image): Remove var that is set but not used.
10335 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10337 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10338 that are set but not used.
10340 * xfns.c (make_invisible_cursor): Don't return garbage
10341 if XCreateBitmapFromData fails (Bug#8410).
10343 * xselect.c (x_get_local_selection, x_handle_property_notify):
10344 Remove vars that are set but not used.
10346 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10347 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10349 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10350 Remove var that is set but not used.
10351 (scroll_bar_windows_size): Now size_t, not int.
10352 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10353 Check for overflow.
10355 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10356 (map_tty_color) [!defined MSDOS]: Likewise.
10358 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10360 * coding.c: Remove vars that are set but not used.
10361 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10362 All callers changed.
10363 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10364 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10365 (decode_coding_charset): Remove vars that are set but not used.
10367 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10368 that is set but not used.
10370 * print.c (print_object): Remove var that is set but not used.
10372 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10373 The gnulib version avoids calling malloc in the usual case,
10374 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10375 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10376 * filelock.c (current_lock_owner): Likewise.
10377 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10378 * sysdep.c: Include allocator.h, careadlinkat.h.
10379 (emacs_no_realloc_allocator): New static constant.
10380 (emacs_readlink): New function.
10381 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10382 ../lib/careadlinkat.h.
10384 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10386 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10387 first non-nil return value).
10389 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10391 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10392 if not defined (Bug#8403).
10394 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10396 * xdisp.c (display_count_lines): Remove parameter `start',
10397 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10398 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10399 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10400 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10401 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10402 and thereabouts. All callers changed.
10403 (get_per_char_metric): Remove parameter `f', unused since
10404 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10406 2011-04-02 Jim Meyering <meyering@redhat.com>
10408 do not dereference NULL upon failed strdup
10409 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10410 (ns_get_family): Likewise.
10412 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10414 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10416 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10418 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10421 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10423 Add lexical binding.
10425 * window.c (Ftemp_output_buffer_show): New fun.
10426 (Fsave_window_excursion):
10427 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10429 * lread.c (lisp_file_lexically_bound_p): New function.
10430 (Fload): Bind Qlexical_binding.
10431 (readevalloop): Remove `evalfun' arg.
10432 Bind Qinternal_interpreter_environment.
10433 (Feval_buffer): Bind Qlexical_binding.
10434 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10436 (syms_of_lread): Declare `lexical-binding'.
10438 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10440 * keyboard.c (eval_dyn): New fun.
10441 (menu_item_eval_property): Use it.
10443 * image.c (parse_image_spec): Use Ffunctionp.
10445 * fns.c (concat, mapcar1): Accept byte-code-functions.
10447 * eval.c (Fsetq): Handle lexical vars.
10448 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10449 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10450 (FletX, Flet): Obey lexical binding.
10451 (Fcommandp): Handle closures.
10452 (Feval): New `lexical' arg.
10453 (eval_sub): New function extracted from Feval. Use it almost
10454 everywhere where Feval was used. Look up vars in lexical env.
10456 (Ffunctionp): Move from subr.el.
10457 (Ffuncall): Handle closures.
10458 (apply_lambda): Remove `eval_flags'.
10459 (funcall_lambda): Handle closures and new byte-code-functions.
10460 (Fspecial_variable_p): New function.
10461 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10462 but without exporting it to Lisp.
10464 * doc.c (Fdocumentation, store_function_docstring):
10465 * data.c (Finteractive_form): Handle closures.
10467 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10470 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10472 (exec_byte_code): New function extracted from Fbyte_code to handle new
10473 calling convention for byte-code-functions. Add new byte-codes.
10475 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10477 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10479 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10481 * xdisp.c (redisplay_internal): Fix prototype.
10483 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10485 * xdisp.c (SCROLL_LIMIT): New macro.
10486 (try_scrolling): Use it when setting scroll_limit.
10487 Limit scrolling to 100 screen lines.
10488 (redisplay_window): Even when falling back on "recentering",
10489 position point in the window according to scroll-conservatively,
10490 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10492 (try_scrolling): When point is above the window, allow searching
10493 as far as scroll_max, or one screenful, to compute vertical
10494 distance from PT to the scroll margin position. This prevents
10495 try_scrolling from unnecessarily failing when
10496 scroll-conservatively is set to a value slightly larger than the
10497 window height. Clean up the case of PT below the margin at bottom
10498 of window: scroll_max can no longer be INT_MAX. When aggressive
10499 scrolling is in use, don't let point enter the opposite scroll
10500 margin as result of the scroll.
10501 (syms_of_xdisp) <scroll-conservatively>: Document the
10502 threshold of 100 lines for never-recentering scrolling.
10504 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10506 * dispextern.h (move_it_by_lines):
10507 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10508 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10509 (message_log_check_duplicate): Remove parameters `prev_bol' and
10510 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10511 (redisplay_internal): Remove parameter `preserve_echo_area',
10512 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10514 * indent.c (Fvertical_motion):
10515 * window.c (window_scroll_pixel_based, Frecenter):
10516 Don't pass `need_y_p' to `move_it_by_lines'.
10518 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10520 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10521 steal a few bits to be more compact.
10522 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10523 Remove unneeded casts.
10525 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10527 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10529 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10530 binding" message (bug#7967).
10532 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10534 Fix more problems found by GCC 4.6.0's static checks.
10536 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10537 Remove unused local var.
10539 * editfns.c (Fmessage_box): Remove unused local var.
10541 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10542 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10543 Omit unused local vars.
10544 * window.c (shrink_windows): Omit unused local var.
10545 * menu.c (digest_single_submenu): Omit unused local var.
10546 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10547 Omit unused local var.
10549 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10550 Don't assume string length fits in int.
10551 (keyremap_step, read_key_sequence): Use size_t for sizes.
10552 (read_key_sequence): Don't check last_real_key_start redundantly.
10554 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10555 instead of alloca (Bug#8344).
10557 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10558 (Fbacktrace_frame): Don't assume nframes fits in int.
10560 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10562 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10565 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10567 * cm.c (calccost): Turn while-do into do-while, for clarity.
10569 * keyboard.c (syms_of_keyboard): Use the same style as later
10570 in this function when indexing through an array. This also
10571 works around GCC bug 48267.
10573 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10575 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10577 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10578 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10580 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10581 This avoids undefined behavior on integer overflow, and is a bit
10582 more convenient anyway since it is compared to a size_t variable.
10584 Variadic C functions now count arguments with size_t, not int.
10585 This avoids an unnecessary limitation on 64-bit machines, which
10586 caused (substring ...) to crash on large vectors (Bug#8344).
10587 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10588 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10589 All variadic functions and their callers changed accordingly.
10590 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10591 * data.c (arith_driver, float_arith_driver): Likewise.
10592 * editfns.c (general_insert_function): Likewise.
10593 * eval.c (struct backtrace.nargs, interactive_p)
10594 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10595 (funcall_lambda, mark_backtrace): Likewise.
10596 * fns.c (concat): Likewise.
10597 * frame.c (x_set_frame_parameters): Likewise.
10598 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10599 0 if not found, not -1. All callers changed.
10601 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10602 (stack_copy_size): Now size_t, not int.
10603 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10605 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10607 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10608 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10609 All callers changed.
10611 * lisp.h (multibyte_char_to_unibyte):
10612 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10613 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10614 * character.h (CHAR_TO_BYTE8):
10615 * cmds.c (internal_self_insert):
10616 * editfns.c (general_insert_function):
10617 * keymap.c (push_key_description):
10618 * search.c (Freplace_match):
10619 * xdisp.c (message_dolog, set_message_1): All callers changed.
10621 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10623 * keyboard.c (safe_run_hook_funcall): New function.
10624 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10625 don't set the hook to nil, but remove the offending function instead.
10626 (Qcommand_hook_internal): Remove, unused.
10627 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10628 Vcommand_hook_internal.
10630 * eval.c (enum run_hooks_condition): Remove.
10631 (funcall_nil, funcall_not): New functions.
10632 (run_hook_with_args): Call each function through a `funcall' argument.
10633 Remove `cond' argument, now redundant.
10634 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10635 (Frun_hook_with_args_until_failure): Adjust accordingly.
10636 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10638 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10640 * dispextern.h (string_buffer_position): Remove declaration.
10642 * print.c (strout): Remove parameter `multibyte', unused since
10643 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10645 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10646 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10647 All callers changed.
10649 * w32.c (_wsa_errlist): Use braces for struct initializers.
10651 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10652 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10653 All callers changed.
10654 (string_buffer_position): Likewise. Also, make static (it's never
10655 used outside xdisp.c).
10656 (cursor_row_p): Remove parameter `w', unused since
10657 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10658 (decode_mode_spec): Remove parameter `precision', introduced during
10659 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10660 All callers changed.
10662 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10664 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10666 2011-03-27 Anders Lindgren <andlind@gmail.com>
10668 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10669 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10670 (ns_update_auto_hide_menu_bar): New functions.
10671 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10672 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10673 ns_constrain_all_frames.
10674 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10675 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10677 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10679 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10681 2011-03-27 Glenn Morris <rgm@gnu.org>
10683 * syssignal.h: Replace RETSIGTYPE with void.
10684 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10685 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10686 Replace SIGTYPE with void everywhere.
10687 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10688 * s/template.h (SIGTYPE): Remove commented out definition.
10690 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10692 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10693 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10695 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10697 * w32.c (read_unc_volume): Use parameter `henum', instead of
10698 global variable `wget_enum_handle'.
10700 * keymap.c (describe_vector): Remove parameters `indices' and
10701 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10702 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10704 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10706 * keyboard.c (timer_check): Remove parameter `do_it_now',
10707 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10708 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10709 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10711 * keyboard.c (read_char):
10712 * w32menu.c (w32_menu_display_help):
10713 * xmenu.c (show_help_event, menu_help_callback):
10714 Adjust calls to `show_help_echo'.
10716 * gtkutil.c (xg_maybe_add_timer):
10717 * keyboard.c (readable_events):
10718 * process.c (wait_reading_process_output):
10719 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10721 * insdel.c (adjust_markers_gap_motion):
10722 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10723 (gap_left, gap_right): Don't call it.
10725 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10727 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10728 incurred during fontification.
10730 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10732 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10733 (DEFVAR_PER_BUFFER): Don't pass it.
10735 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10736 (scrolling_window): Don't pass it.
10738 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10740 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10742 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10744 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10745 of variables specific to SELinux and computation of `encoded_absname'.
10747 * image.c (XPutPixel): Remove unused variable `height'.
10749 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10751 * unexw32.c (get_section_info): Remove unused variable `section'.
10753 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10754 (system_process_attributes): Remove unused variable `sess'.
10755 (sys_read): Remove unused variable `err'.
10757 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10758 (w32_wnd_proc): Remove unused variable `isdead'.
10759 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10760 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10761 (x_create_tip_frame): Remove unused variable `tem'.
10763 * w32inevt.c (w32_console_read_socket):
10764 Remove unused variable `no_events'.
10766 * w32term.c (x_draw_composite_glyph_string_foreground):
10767 Remove unused variable `width'.
10769 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10771 * w32term.c (x_set_glyph_string_clipping):
10772 Don't pass uninitialized region to CombineRgn.
10774 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10776 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10777 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10778 (Fx_close_connection): Remove unused variable `i'.
10780 * w32font.c (w32font_draw): Return number of glyphs.
10781 (w32font_open_internal): Remove unused variable `i'.
10782 (w32font_driver): Add missing initializer.
10784 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10785 (fill_in_menu): Remove unused variable `items_added'.
10787 * w32term.c (last_mouse_press_frame): Remove static global variable.
10788 (w32_clip_to_row): Remove unused variable `f'.
10789 (x_delete_terminal): Remove unused variable `i'.
10791 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10792 (NOTHING): Remove unused static global variable.
10793 (uniscribe_check_otf): Remove unused variable `table'.
10794 (uniscribe_font_driver): Add missing initializers.
10796 2011-03-23 Julien Danjou <julien@danjou.info>
10798 * term.c (Fsuspend_tty, Fresume_tty):
10799 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10800 * window.c (temp_output_buffer_show):
10801 * insdel.c (signal_before_change):
10802 * frame.c (Fhandle_switch_frame):
10803 * fileio.c (Fdo_auto_save):
10804 * emacs.c (Fkill_emacs):
10805 * editfns.c (save_excursion_restore):
10806 * cmds.c (internal_self_insert):
10807 * callint.c (Fcall_interactively):
10808 * buffer.c (Fkill_all_local_variables):
10809 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10811 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10812 unconditionally since it does the check itself.
10814 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10816 Fix more problems found by GCC 4.5.2's static checks.
10818 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10819 the first time through the loop, since we know p0 < p1 then.
10820 This also avoids a gcc -Wstrict-overflow warning.
10822 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10823 leading to a memory leak, possible in functions like
10824 load_charset_map_from_file that can allocate an unbounded number
10825 of objects (Bug#8318).
10827 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10828 that could (at least in theory) be that large.
10830 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10831 This is less likely to overflow, and avoids undefined behavior if
10832 overflow does occur. All callers changed. Use strtoul to scan
10833 for the unsigned long integer.
10834 (pint2hrstr): Simplify and tune code slightly.
10835 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10837 * scroll.c (do_scrolling): Work around GCC bug 48228.
10838 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10840 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10841 This also avoids a warning with gcc -Wstrict-overflow.
10842 (validate_x_resource_name): Simplify count usage.
10843 This also avoids a warning with gcc -Wstrict-overflow.
10845 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10848 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10850 * process.c (Fmake_network_process): Use socklen_t, not int,
10851 where POSIX says socklen_t is required in portable programs.
10852 This fixes a porting bug on hosts like 64-bit HP-UX, where
10853 socklen_t is wider than int (Bug#8277).
10854 (Fmake_network_process, server_accept_connection):
10855 (wait_reading_process_output, read_process_output):
10858 * process.c: Rename or move locals to avoid shadowing.
10859 (list_processes_1, Fmake_network_process):
10860 (read_process_output_error_handler, exec_sentinel_error_handler):
10861 Rename or move locals.
10862 (Fmake_network_process): Define label "retry_connect" only if needed.
10863 (Fnetwork_interface_info): Fix pointer signedness.
10864 (process_send_signal): Add cast to avoid pointer signedness problem.
10865 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10866 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10868 Make tparam.h and terminfo.c consistent.
10869 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10870 Include tparam.h instead, since it declares them.
10871 * cm.h (PC): Remove extern decl; tparam.h now does this.
10872 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10873 * terminfo.c: Include tparam.h, to check interfaces.
10874 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10875 (tparam): Adjust signature to match interface in tparam.h;
10876 this removes some undefined behavior. Check that outstring and len
10877 are zero, which they always are with Emacs.
10878 * tparam.h (PC, BC, UP): New extern decls.
10880 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10881 (xftfont_open): Rename locals to avoid shadowing.
10883 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10884 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10885 (OTF_TAG_SYM): Omit macro if not needed.
10886 (ftfont_list): Remove unused local.
10887 (get_adstyle_property, ftfont_pattern_entity):
10888 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10889 Rename locals to avoid shadowing.
10891 * xfont.c (xfont_list_family): Mark var as initialized.
10893 * xml.c (make_dom): Now static.
10895 * composite.c (composition_compute_stop_pos): Rename local to
10897 (composition_reseat_it): Remove unused locals.
10898 (find_automatic_composition, composition_adjust_point): Likewise.
10899 (composition_update_it): Mark var as initialized.
10900 (find_automatic_composition): Mark vars as initialized,
10901 with a FIXME (Bug#8290).
10903 character.h: Rename locals to avoid shadowing.
10904 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10905 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10906 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10907 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10908 to avoid shadowing.
10910 * textprop.c (property_change_between_p): Remove; unused.
10912 * intervals.c (interval_start_pos): Now static.
10914 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10916 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10917 Rename locals to avoid shadowing.
10919 * sound.c (wav_play, au_play, Fplay_sound_internal):
10920 Fix pointer signedness.
10921 (alsa_choose_format): Remove unused local var.
10922 (wav_play): Initialize a variable to 0, to prevent undefined
10923 behavior (Bug#8278).
10925 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10927 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10929 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10930 clobbering (Bug#8298).
10931 * sysdep.c (sys_subshell): Likewise.
10932 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10934 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10935 This should get cleaned up, so that child_setup has the
10936 same signature on all platforms.
10938 * callproc.c (call_process_cleanup): Now static.
10939 (relocate_fd): Rename locals to avoid shadowing.
10941 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10943 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10944 not to be necessary, and produces flickering.
10946 2011-03-20 Glenn Morris <rgm@gnu.org>
10948 * config.in: Remove file.
10950 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10952 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10953 are now in src/globals.h.
10954 (syms_of_minibuf): Remove spurious & from previous change.
10956 2011-03-20 Leo Liu <sdl.web@gmail.com>
10958 * minibuf.c (completing-read-function): New variable.
10959 (completing-read-default): Rename from completing-read.
10960 (completing-read): Call completing-read-function.
10962 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10964 * xfaces.c (Fx_load_color_file):
10965 Read color file from absolute filename (bug#8250).
10967 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10969 * makefile.w32-in: Update dependencies.
10971 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10973 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10975 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10977 Fix more problems found by GCC 4.5.2's static checks.
10979 * process.c (make_serial_process_unwind, send_process_trap):
10980 (sigchld_handler): Now static.
10982 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10983 That way, the code declares only the vars that it needs.
10984 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10985 * s/cygwin.h (PTY_ITERATION): Likewise.
10986 * s/darwin.h (PTY_ITERATION): Likewise.
10987 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10989 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10990 * process.c (allocate_pty): Don't declare stb unless it's needed.
10992 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10993 (CONSTANTLIM): Remove; unused.
10994 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10995 Define only if needed.
10997 * unexelf.c (unexec): Name an expression,
10998 to avoid gcc -Wbad-function-cast warning.
10999 Use a different way to cause a compilation error if anyone uses
11000 n rather than nn, a way that does not involve shadowing.
11001 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11003 * deps.mk (unexalpha.o): Remove; unused.
11005 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11006 * unexec.h: New file.
11007 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11008 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11009 Depend on unexec.h.
11010 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11011 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11012 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11013 Change as necessary to match prototype in unexec.h.
11015 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11017 (back_comment, skip_chars): Mark vars as initialized.
11019 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11020 Rename locals to avoid shadowing.
11022 * lread.c (read1): Rewrite so as not to use empty "else".
11023 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11025 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11027 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11028 warning when compiling print.c.
11030 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11031 instead of using an uninitialized var.
11032 (font_sort_entities): Mark var as initialized.
11034 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11036 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11037 pointers to constants.
11038 (font_parse_fcname): Remove unused vars.
11039 (font_delete_unmatched): Now static.
11040 (font_get_spec): Remove; unused.
11041 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11042 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11043 Rename or move locals to avoid shadowing.
11045 * fns.c (require_nesting_list, require_unwind): Now static.
11046 (Ffillarray): Rename locals to avoid shadowing.
11048 * floatfns.c (domain_error2): Define only if needed.
11049 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11051 * alloc.c (mark_backtrace): Move decl from here ...
11052 * lisp.h: ... to here, so that it can be checked.
11054 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11055 (Fdefvar): Rewrite so as not to use empty "else".
11056 (lisp_indirect_variable): Name an expression,
11057 to avoid gcc -Wbad-function-cast warning.
11058 (Fdefvar): Rename locals to avoid shadowing.
11060 * callint.c (quotify_arg, quotify_args): Now static.
11061 (Fcall_interactively): Rename locals to avoid shadowing.
11062 Use const pointer when appropriate.
11064 * lisp.h (get_system_name, get_operating_system_release):
11065 Move decls here, to check interfaces.
11066 * process.c (get_operating_system_release): Move decl to lisp.h.
11067 * xrdb.c (get_system_name): Likewise.
11068 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11069 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11070 some of which prompt warnings from gcc -Wbad-function-cast.
11071 (Fformat_time_string, Fencode_time, Finsert_char):
11072 (Ftranslate_region_internal, Fformat):
11073 Rename or remove local vars to avoid shadowing.
11074 (Ftranslate_region_internal): Mark var as initialized.
11076 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11079 * lisp.h (eassert): Check that the argument compiles, even if
11080 ENABLE_CHECKING is not defined.
11082 * data.c (Findirect_variable): Name an expression, to avoid
11083 gcc -Wbad-function-cast warning.
11084 (default_value, arithcompare, arith_driver, arith_error): Now static.
11085 (store_symval_forwarding): Rename local to avoid shadowing.
11086 (Fmake_variable_buffer_local, Fmake_local_variable):
11087 Mark variables as initialized.
11088 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11090 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11091 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11092 Rename locals to avoid shadowing.
11093 (mark_stack): Move local variables into the #ifdef region where
11095 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11096 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11098 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11099 (GC_STRING_CHARS): Remove; not used.
11100 (Fmemory_limit): Cast sbrk's returned value to char *.
11102 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11103 avoids undefined behavior in theory.
11105 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11107 Use functions, not macros, for up- and down-casing (Bug#8254).
11108 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11109 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11110 to use the following functions instead of these macros.
11111 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11112 EMACS_INT, since callers assume the returned value fits in int.
11113 (upcase1): Likewise, for UPCASE_TABLE.
11114 (uppercasep, lowercasep, upcase): New static inline functions.
11115 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11116 the race-condition problem in the old DOWNCASE.
11118 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11119 Rename locals to avoid shadowing.
11120 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11121 (regex_compile, re_search_2, re_match_2_internal):
11122 Remove unused local vars.
11123 (FREE_VAR): Rewrite so as not to use empty "else",
11124 which gcc can warn about.
11125 (regex_compile, re_match_2_internal): Mark locals as initialized.
11126 (RETALLOC_IF): Define only if needed.
11127 (WORDCHAR_P): Likewise. This one is never needed, but is used
11128 only in a comment talking about a compiler bug, so put inside
11129 the #if 0 of that comment.
11130 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11131 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11134 * search.c (boyer_moore): Rename locals to avoid shadowing.
11135 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11136 (PREV_CHAR_BOUNDARY): Likewise.
11138 * search.c (simple_search): Remove unused var.
11140 * dired.c (compile_pattern): Move decl from here ...
11141 * lisp.h: ... to here, so that it can be checked.
11142 (struct re_registers): New forward decl.
11144 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11146 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11148 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11149 Rename locals to avoid shadowing.
11150 (Fvertical_motion): Mark locals as initialized.
11152 * casefiddle.c (casify_object, casify_region): Now static.
11153 (casify_region): Mark local as initialized.
11155 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11157 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11158 New macros, so that the caller can use some names other than
11159 gcpro1, gcpro2, etc.
11160 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11162 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11163 argument, for consistency with GCPRO2_VAR, etc: it is now the
11164 prefix of the variable, not the variable itself. All uses
11166 * dired.c (directory_files_internal, file_name_completion):
11167 Rename locals to avoid shadowing.
11169 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11170 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11171 dired.c's scmp function, had undefined behavior.
11172 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11173 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11174 * buffer.h: ... to here, because these macros use current_buffer,
11175 and the new implementation with inline functions needs to have
11176 current_buffer in scope now, rather than later when the macros
11178 (downcase, upcase1): New static inline functions.
11179 (DOWNCASE, UPCASE1): Reimplement using these functions.
11180 This avoids undefined behavior in expressions like
11181 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11182 from race conditions in accessing the global variables
11183 case_temp1 and case_temp2.
11184 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11185 * lisp.h (case_temp1, case_temp2): Remove their decls.
11186 * character.h (ASCII_CHAR_P): Move from here ...
11187 * lisp.h: ... to here, so that the inline functions mentioned
11188 above can use them.
11190 * dired.c (directory_files_internal_unwind): Now static.
11192 * fileio.c (file_name_as_directory, directory_file_name):
11193 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11195 (file_name_as_directory): Use const pointers when appropriate.
11196 (Fexpand_file_name): Likewise. In particular, newdir might
11197 point at constant storage, so make it a const pointer.
11198 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11199 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11201 (Fset_file_times, Finsert_file_contents, auto_save_error):
11202 Rename locals to avoid shadowing.
11204 * minibuf.c (choose_minibuf_frame_1): Now static.
11205 (Ftry_completion, Fall_completions): Rename or remove locals
11206 to avoid shadowing.
11208 * marker.c (bytepos_to_charpos): Remove; unused.
11210 * lisp.h (verify_bytepos, count_markers): New decls,
11211 so that gcc does not warn that these functions aren't declared.
11213 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11214 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11215 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11216 (copy_text): Remove unused local var.
11218 * filelock.c (within_one_second): Now static.
11219 (lock_file_1): Rename local to avoid shadowing.
11221 * buffer.c (fix_overlays_before): Mark locals as initialized.
11222 (fix_start_end_in_overlays): Likewise. This function should be
11223 simplified by using pointers-to-pointers, but that's a different
11225 (switch_to_buffer_1): Now static.
11226 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11227 (report_overlay_modification): Rename locals to avoid shadowing.
11229 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11230 Fix pointer signedness issue.
11231 (sys_subshell): Mark local as volatile if checking for lint,
11232 to suppress a gcc -Wclobbered warning that does not seem to be right.
11233 (MAXPATHLEN): Define only if needed.
11235 * process.c (serial_open, serial_configure): Move decls from here ...
11236 * systty.h: ... to here, so that they can be checked.
11238 * fns.c (get_random, seed_random): Move extern decls from here ...
11239 * lisp.h: ... to here, so that they can be checked.
11241 * sysdep.c (reset_io): Now static.
11242 (wait_for_termination_signal): Remove; unused.
11244 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11245 (copy_keymap_item, append_key, push_text_char_description):
11247 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11248 (DENSE_TABLE_SIZE): Remove; unused.
11249 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11250 (describe_map_tree):
11251 Rename locals to avoid shadowing.
11253 * keyboard.c: Declare functions static if they are not used elsewhere.
11254 (echo_char, echo_dash, cmd_error, top_level_2):
11255 (poll_for_input, handle_async_input): Now static.
11256 (read_char, kbd_buffer_get_event, make_lispy_position):
11257 (make_lispy_event, make_lispy_movement, apply_modifiers):
11258 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11259 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11260 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11261 (read_key_sequence, read_char): Mark locals as initialized.
11262 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11264 * keyboard.h (make_ctrl_char): New decl.
11265 (mark_kboards): Move decl here ...
11266 * alloc.c (mark_kboards): ... from here.
11268 * lisp.h (force_auto_save_soon): New decl.
11270 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11271 (DEFINE_DUMMY_FUNCTION): New macro.
11272 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11274 (main): Add casts to avoid warnings
11275 if GCC considers string literals to be constants.
11277 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11279 * dbusbind.c: Pointer signedness fixes.
11280 (xd_signature, xd_append_arg, xd_initialize):
11281 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11282 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11283 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11284 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11286 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11287 if GCC considers string literals to be constants.
11288 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11290 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11292 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11293 (print_preprocess, print_object): New macro to fix last change.
11295 * print.c (print_preprocess): Don't forget font objects.
11297 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11299 * emacs.c (USAGE3): Doc fixes.
11301 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11303 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11306 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11308 * lisp.h (VWindow_system, Qfile_name_history):
11309 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11310 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11311 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11313 * w32select.c: Don't #include "keyboard.h".
11314 (run_protected): Add extern declaration for waiting_for_input.
11316 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11317 * w32console.c (detect_input_pending, read_input_pending)
11318 (encode_terminal_code):
11319 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11320 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11321 (w32_system_caret_y, Qfile_name_history):
11322 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11323 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11324 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11325 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11326 * w32proc.c (Qlocal, report_file_error):
11327 * w32term.c (Vwindow_system, updating_frame):
11328 * w32uniscribe.c (initialized, uniscribe_font_driver):
11329 Remove unneeded extern declarations.
11331 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11333 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11335 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11337 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11338 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11339 These macros can no longer be used for assignment.
11341 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11342 Assign struct members directly, instead of using BUF_BEGV etc.
11343 (record_buffer_markers, fetch_buffer_markers): New functions for
11344 recording and fetching special buffer markers.
11345 (set_buffer_internal_1, set_buffer_temp): Use them.
11347 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11349 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11351 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11352 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11354 * xdisp.c (hscroll_window_tree):
11355 (reconsider_clip_changes): Use PT instead of BUF_PT.
11357 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11359 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11360 $(EMACS_ROOT)/lib/intprops.h.
11362 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11364 Fix more problems found by GCC 4.5.2's static checks.
11366 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11367 to unsigned char * to avoid compiler diagnostic.
11368 (xg_free_frame_widgets): Make it clear that a local variable is
11369 needed only if USE_GTK_TOOLTIP.
11370 (gdk_window_get_screen): Make it clear that this macro is needed
11371 only if USE_GTK_TOOLTIP.
11372 (int_gtk_range_get_value): New function, which avoids a diagnostic
11373 from gcc -Wbad-function-cast.
11374 (xg_set_toolkit_scroll_bar_thumb): Use it.
11375 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11376 diagnostic from gcc -Wbad-function-cast.
11377 (get_utf8_string, xg_get_file_with_chooser):
11378 Rename locals to avoid shadowing.
11379 (create_dialog): Move locals to avoid shadowing.
11381 * xgselect.c (xg_select): Remove unused var.
11383 * image.c (four_corners_best): Mark locals as initialized.
11384 (gif_load): Initialize transparent_p to zero (Bug#8238).
11385 Mark another local as initialized.
11386 (my_png_error, my_error_exit): Mark with NO_RETURN.
11388 * image.c (clear_image_cache): Now static.
11389 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11390 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11391 (x_edge_detection): Remove unnecessary cast that
11392 gcc -Wbad-function-cast diagnoses.
11393 (gif_load): Fix pointer signedness.
11394 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11395 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11397 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11399 Improve quality of tests for time stamp overflow.
11400 For example, without this patch (encode-time 0 0 0 1 1
11401 1152921504606846976) returns the obviously-bogus value (-948597
11402 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11403 reports time overflow. See
11404 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11405 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11406 * editfns.c: Include limits.h and intprops.h.
11407 (TIME_T_MIN, TIME_T_MAX): New macros.
11408 (time_overflow): Move earlier, to before first use.
11409 (hi_time, lo_time): New functions, for an accurate test for
11410 out-of-range times.
11411 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11412 (Fget_internal_run_time): Don't assume time_t fits in int.
11413 (make_time): Use list2 instead of Fcons twice.
11414 (Fdecode_time): More accurate test for out-of-range times.
11415 (check_tm_member): New function.
11416 (Fencode_time): Use it, to test for out-of-range times.
11417 (lisp_time_argument): Don't rely on undefined left-shift and
11418 right-shift behavior when checking for time stamp overflow.
11420 * editfns.c (time_overflow): New function, refactoring common code.
11421 (Fformat_time_string, Fdecode_time, Fencode_time):
11422 (Fcurrent_time_string): Use it.
11424 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11425 * dired.c (make_time): Move to ...
11426 * editfns.c (make_time): ... here.
11427 * systime.h: Note the move.
11429 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11431 * fringe.c (update_window_fringes): Remove unused variables.
11433 * unexmacosx.c (copy_data_segment): Also copy __got section.
11436 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11438 * termcap.c [MSDOS]: Include "msdos.h".
11439 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11440 Constify `char *' arguments and their references according to
11441 prototypes in tparam.h.
11443 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11445 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11446 Adapt all references accordingly.
11448 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11450 2011-03-11 Tom Tromey <tromey@redhat.com>
11452 * buffer.c (syms_of_buffer): Remove obsolete comment.
11454 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11456 * termhooks.h (encode_terminal_code): Declare prototype.
11458 * msdos.c (encode_terminal_code): Don't declare prototype.
11460 * term.c (encode_terminal_code): Now external again, used by
11461 w32console.c and msdos.c.
11463 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11464 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11466 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11468 Fix some minor problems found by GCC 4.5.2's static checks.
11470 * fringe.c (update_window_fringes): Mark locals as initialized
11472 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11474 * alloc.c (mark_fringe_data): Move decl from here ...
11475 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11476 to check its interface.
11477 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11479 * fontset.c (free_realized_fontset): Now static.
11480 (Fset_fontset_font): Rename local to avoid shadowing.
11481 (fontset_font): Mark local as initialized.
11482 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11484 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11486 * xselect.c (x_disown_buffer_selections): Remove; not used.
11487 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11488 (x_own_selection, Fx_disown_selection_internal): Rename locals
11489 to avoid shadowing.
11490 (x_handle_dnd_message): Remove local to avoid shadowing.
11492 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11493 so that the caller can use some name other than gcpro1.
11494 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11495 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11496 (Fx_backspace_delete_keys_p):
11497 Use them to avoid shadowing, and rename vars to avoid shadowing.
11498 (x_decode_color, x_set_name, x_window): Now static.
11499 (Fx_create_frame): Add braces to silence GCC warning.
11500 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11501 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11502 Remove unused locals.
11503 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11504 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11505 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11508 * xterm.h (x_mouse_leave): New decl.
11510 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11511 Remove unused functions.
11512 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11513 (x_calc_absolute_position): Now static.
11514 (XTread_socket): Don't define label "out" unless it's used.
11515 Don't declare local "event" unless it's used.
11516 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11517 unless they are used.
11518 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11519 (x_fatal_error_signal): Remove; not used.
11520 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11521 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11522 (x_error_catcher, x_connection_closed, x_error_handler):
11523 (x_error_quitter, xembed_send_message, x_iconify_frame):
11524 (my_log_handler): Rename locals to avoid shadowing.
11525 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11526 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11528 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11529 Rename or move locals to avoid shadowing.
11530 (tty_defined_color, merge_face_heights): Now static.
11531 (free_realized_faces_for_fontset): Remove; not used.
11532 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11533 does not deduce is never used uninitialized.
11534 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11535 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11537 * terminal.c (store_terminal_param): Now static.
11539 * xmenu.c (menu_highlight_callback): Now static.
11540 (set_frame_menubar): Remove unused local.
11541 (xmenu_show): Rename parameter to avoid shadowing.
11542 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11543 since they might point to immutable storage.
11544 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11545 since it's unused otherwise.
11547 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11548 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11549 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11550 avoids a gcc -Wuninitialized diagnostic.
11551 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11552 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11553 does not deduce are never used uninitialized.
11555 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11557 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11558 * window.c (window_loop, size_window):
11559 (run_window_configuration_change_hook, enlarge_window): Likewise.
11561 * window.c (display_buffer): Now static.
11562 (size_window): Mark variables that gcc -Wuninitialized
11563 does not deduce are never used uninitialized.
11564 * window.h (check_all_windows): New decl, to forestall
11565 gcc -Wmissing-prototypes diagnostic.
11566 * dispextern.h (bidi_dump_cached_states): Likewise.
11568 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11570 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11571 Include <limits.h>.
11572 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11573 and to avoid gcc -Wuninitialized warning.
11574 (load_charset_map): Mark variables that gcc -Wuninitialized
11575 does not deduce are never used uninitialized.
11576 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11578 * coding.c (coding_set_source, coding_set_destination):
11579 Use "else { /* comment */ }" rather than "else /* comment */;"
11580 for clarity, and to avoid gcc -Wempty-body warning.
11581 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11582 a block, when the outer 'i' will do.
11583 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11584 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11585 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11586 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11587 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11588 Rename locals to avoid shadowing.
11589 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11590 * coding.c (emacs_mule_char, encode_invocation_designation):
11591 Now static, since they're not used elsewhere.
11592 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11593 (decode_coding_object, encode_coding_object, detect_coding_system):
11594 (decode_coding_emacs_mule): Mark variables that gcc
11595 -Wuninitialized does not deduce are never used uninitialized.
11596 (detect_coding_iso_2022): Initialize a local variable that might
11597 be used uninitialized. Leave a FIXME because it's not clear that
11598 this initialization is needed. (Bug#8211)
11599 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11600 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11601 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11602 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11603 Remove unused macros.
11605 * category.c (hash_get_category_set): Remove unused local var.
11606 (copy_category_table): Now static, since it's not used elsewhere.
11607 * character.c (string_count_byte8): Likewise.
11609 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11610 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11612 * chartab.c (copy_sub_char_table): Now static, since it's not used
11614 (sub_char_table_ref_and_range, char_table_ref_and_range):
11615 Rename locals to avoid shadowing.
11616 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11618 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11619 (BIDI_BOB): Remove unused macro.
11621 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11622 deduce are never used uninitialized.
11623 * term.c (encode_terminal_code): Likewise.
11625 * term.c (encode_terminal_code): Now static. Remove unused local.
11627 * tparam.h: New file.
11628 * term.c, tparam.h: Include it.
11629 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11630 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11631 Move these decls to tparam.h, and make them agree with what
11632 is actually in tparam.c. The previous trick of using incompatible
11633 decls in different modules does not conform to the C standard.
11634 All callers of tparam changed to use tparam's actual API.
11635 * tparam.c (tparam1, tparam, tgoto):
11636 Use const pointers where appropriate.
11638 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11639 * cm.h (struct cm): Likewise.
11640 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11641 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11642 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11643 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11644 (turn_on_face, init_tty): Likewise.
11645 * termchar.h (struct tty_display_info): Likewise.
11647 * term.c (term_mouse_position): Rename local to avoid shadowing.
11649 * alloc.c (mark_ttys): Move decl from here ...
11650 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11652 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11654 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11656 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11658 * search.c (compile_pattern_1): Remove argument regp, unused since
11659 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11660 (compile_pattern): Don't pass it.
11662 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11664 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11665 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11667 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11669 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11671 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11672 gdk_window_get_screen, gdk_window_get_geometry,
11673 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11674 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11675 (xg_get_pixbuf_from_pixmap): New function.
11676 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11677 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11678 Call xg_get_pixbuf_from_pixmap instead of
11679 gdk_pixbuf_get_from_drawable.
11680 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11681 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11682 (xg_check_special_colors): Use GtkStyleContext and its functions
11684 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11685 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11686 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11687 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11688 Call gtk_widget_get_preferred_size.
11689 (xg_frame_resized): gdk_window_get_geometry only takes 5
11691 (xg_win_to_widget, xg_event_is_for_menubar):
11692 Call gdk_x11_window_lookup_for_display.
11693 (xg_set_widget_bg): New function.
11694 (delete_cb): New function.
11695 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11696 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11697 (xg_set_background_color): Call xg_set_widget_bg.
11698 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11699 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11700 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11701 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11703 (update_frame_tool_bar): Call gtk_widget_hide.
11704 (xg_initialize): Use GDK_KEY_g.
11706 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11708 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11710 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11711 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11712 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11714 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11716 * w32xfns.c (select_palette): Check success of RealizePalette against
11717 GDI_ERROR, not zero.
11719 See ChangeLog.11 for earlier changes.
11721 ;; Local Variables:
11725 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11727 This file is part of GNU Emacs.
11729 GNU Emacs is free software: you can redistribute it and/or modify
11730 it under the terms of the GNU General Public License as published by
11731 the Free Software Foundation, either version 3 of the License, or
11732 (at your option) any later version.
11734 GNU Emacs is distributed in the hope that it will be useful,
11735 but WITHOUT ANY WARRANTY; without even the implied warranty of
11736 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11737 GNU General Public License for more details.
11739 You should have received a copy of the GNU General Public License
11740 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.