]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
[gnu-emacs] / src / ChangeLog
1 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4
5 2012-06-03 Glenn Morris <rgm@gnu.org>
6
7 * xdisp.c (tool-bar-style): Doc fix.
8
9 2012-06-03 Ulrich Müller <ulm@gentoo.org>
10
11 * Makefile.in (PAXCTL): Define.
12 (temacs$(EXEEXT)): Disable memory randomization for the temacs
13 binary via PaX flags if the paxctl utility is available.
14 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
15 Restore PaX flags to their default. (Bug#11398)
16
17 2012-06-03 Chong Yidong <cyd@gnu.org>
18
19 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
20 buffer (Bug#11226).
21
22 2012-06-03 Chong Yidong <cyd@gnu.org>
23
24 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
25 (note_mode_line_or_margin_highlight): If there is no help echo,
26 use mode-line-default-help-echo. Handle the case where the mouse
27 position is past the end of the mode line string.
28
29 * buffer.c (buffer_local_value_1): New function, split from
30 Fbuffer_local_value; can return Qunbound.
31 (Fbuffer_local_value): Use it.
32 (Vmode_line_format): Docstring tweaks.
33
34 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
35
36 * sysdep.c (system_process_attributes): Improve comment.
37
38 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
39
40 * keyboard.c: Export real-this-command to Elisp.
41 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
42 and DEFVAR it. Update all users.
43
44 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
45
46 * minibuf.c (Fassoc_string): Remove duplicate declaration.
47
48 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
49 Convert pctcpu and pctmem to Lisp float properly.
50 Let the compiler fold better, as 100.0/0x8000 is exact.
51
52 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
53
54 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
55 cons_block.
56
57 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
58
59 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
60
61 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
62
63 For a 'struct window', replace some Lisp_Object fields to
64 bitfields where appropriate, remove unused fields.
65 * window.h (struct window): Remove unused 'last_mark_x' and
66 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
67 change it's type from Lisp_Object to bitfield.
68 Change type of 'force_start', 'optional_new_start',
69 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
70 fields from Lisp_Object to bitfield. Adjust users accordingly.
71
72 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
73
74 Pacify gcc -Wdouble-precision when using Xaw.
75 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
76 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
77 Use 'float' consistently, rather than 'float' in most places
78 and 'double' in a couple of places.
79
80 2012-05-31 Eli Zaretskii <eliz@gnu.org>
81
82 * xdisp.c (handle_stop): Detect whether we have overlay strings
83 loaded by testing it->current.overlay_string_index to be
84 non-negative, instead of checking whether n_overlay_strings is
85 positive. (Bug#11587)
86
87 2012-05-31 Chong Yidong <cyd@gnu.org>
88
89 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
90
91 * doc.c (Fsubstitute_command_keys): Doc fix.
92
93 2012-05-31 Eli Zaretskii <eliz@gnu.org>
94
95 * search.c (search_buffer): Remove calls to
96 r_alloc_inhibit_buffer_relocation, as it is now called by
97 maybe_unify_char, which was the cause of relocation of buffer text
98 in bug#11519.
99
100 2012-05-31 Eli Zaretskii <eliz@gnu.org>
101
102 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
103 for the duration of call to load_charset, to avoid problems with
104 callers of maybe_unify_char that access buffer text through C
105 pointers.
106
107 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
108 decrement the inhibition flag, instead of just setting or
109 resetting it.
110
111 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
112
113 Remove obsolete '#define static' cruft.
114 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
115 This #undef was "temporary" in 2000; it is no longer needed
116 now that '#define static' has gone away.
117 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
118 (gray_bitmap_bits): Remove; no longer needed.
119 All uses replaced with definiens.
120 * xterm.c: Include "bitmaps/gray.xbm".
121
122 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
123
124 Clean up __executable_start, monstartup when --enable-profiling.
125 The following changes affect the code only when profiling.
126 * dispnew.c (__executable_start): Rename from safe_bcopy.
127 Define only on platforms that need it.
128 * emacs.c: Include <sys/gmon.h> when profiling.
129 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
130 (__executable_start): Remove decl, since lisp.h does it now.
131 (safe_bcopy): Remove decl; no longer has that name.
132 (main): Coalesce #if into single bit of code, for simplicity.
133 Cast pointers to uintptr_t, since standard libraries want integers
134 and not pointers.
135 * lisp.h (__executable_start): New decl.
136
137 2012-05-31 Glenn Morris <rgm@gnu.org>
138
139 * image.c (Fimagemagick_types): Doc fix.
140
141 2012-05-30 Jim Meyering <meyering@redhat.com>
142
143 * callproc.c (Fcall_process_region): Include directory component
144 in mkstemp error message (Bug#11586).
145
146 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
147
148 * alloc.c, lisp.h (make_pure_vector): Now static.
149
150 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
151
152 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
153 Move to byte-run.el.
154 (Fautoload): Do the hash-doc more carefully.
155 * data.c (Fdefalias): Purify definition, except for keymaps.
156 (Qdefun): Move from eval.c.
157 * lisp.h (Qdefun): Remove.
158 * lread.c (read1): Tiny simplification.
159
160 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
161
162 Do not create empty overlays with the evaporate property (Bug#9642).
163 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
164 Bug#9642, but explicitly check that the buffer the overlay would
165 be moved to is live and rearrange lines to make sure that errors
166 will not put the overlay in an inconsistent state.
167 (Fdelete_overlay): Cosmetics.
168
169 2012-05-28 Eli Zaretskii <eliz@gnu.org>
170
171 * w32term.c (my_bring_window_to_top): New function.
172 (x_raise_frame): Use handle returned by DeferWindowPos, which
173 could be different from the original one.
174 Call my_bring_window_to_top instead of my_set_foreground_window.
175 (Bug#11513)
176
177 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
178 by calling BringWindowToTop.
179
180 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
181 (WM_EMACS_END): Increase by one.
182
183 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
184
185 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
186 This avoids undefined behavior that might cause the eassert
187 to not catch an out-of-range value.
188
189 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
190
191 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
192 Update dependencies.
193
194 2012-05-27 Eli Zaretskii <eliz@gnu.org>
195
196 * bidi.c (bidi_mirror_char): Fix last change.
197
198 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
199
200 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
201 when referring to sectname field in printf format.
202
203 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
204
205 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
206 Only r_alloc_inhibit_buffer_relocation needed to be added;
207 the others were already declared.
208
209 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
210 before checking whether it's out of range. Put the check inside
211 eassert. See
212 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
213
214 2012-05-27 Ken Brown <kbrown@cornell.edu>
215
216 * callproc.c (Fcall_process): Restore a line that was accidentally
217 commented out in the 2011-02-13 change (bug#11547).
218
219 2012-05-27 Eli Zaretskii <eliz@gnu.org>
220
221 * lisp.h [REL_ALLOC]: Add prototypes for external functions
222 defined on ralloc.c.
223
224 * buffer.c [REL_ALLOC]: Remove prototypes of
225 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
226 they are now on lisp.h.
227
228 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
229
230 * search.c (search_buffer): Use it to inhibit relocation of buffer
231 text while re_search_2 is doing its job, because re_search_2 is
232 passed C pointers to buffer text. (Bug#11519)
233
234 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
235 Update value to 24.
236
237 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
238 state after an additional call to move_it_in_display_line_to, keep
239 the values of it->max_ascent and it->max_descent found for the
240 entire line.
241 (pos_visible_p): Revert the comparison against bottom_y to what it
242 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
243 (Bug#11464)
244
245 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
246
247 Fix coding-related core dumps with gcc -ftrapv.
248 The code was computing A - B, where A and B are pointers, and B is
249 random garbage. This can lead to core dumps on platforms that
250 have special pointer registers, and it also leads to core dumps on
251 x86-64 when compiled with gcc -ftrapv. The fix is to compute
252 A - B only when B is initialized properly.
253 * coding.c (coding_set_source, coding_set_destination): Return void.
254 (coding_change_source, coding_change_destinations): New functions,
255 with the old behaviors of coding_set_source and coding_set_destination.
256 All callers that need an offset changed to use these new functions.
257
258 2012-05-26 Glenn Morris <rgm@gnu.org>
259
260 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
261
262 2012-05-26 Eli Zaretskii <eliz@gnu.org>
263
264 Extend mouse support on W32 text-mode console.
265 * xdisp.c (draw_row_with_mouse_face):
266 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
267
268 * w32console.c: Include window.h.
269 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
270 New functions.
271 (initialize_w32_display): Initialize mouse-highlight data.
272
273 * w32inevt.c: Include termchar.h and window.h.
274 (do_mouse_event): Support mouse-autoselect-window. When the mouse
275 moves, call note_mouse_highlight. If help_echo changed, call
276 gen_help_event to produce help-echo message in the echo area.
277 Call clear_mouse_face if mouse_face_hidden is set in the mouse
278 highlight info.
279
280 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
281
282 * lread.c (read1): Simplify slightly to avoid an overflow warning
283 with GCC 4.7.0 on x86-64.
284
285 2012-05-26 Eli Zaretskii <eliz@gnu.org>
286
287 * bidi.c (bidi_mirror_char): Revert last change: an int is
288 definitely wide enough here.
289
290 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
291
292 Fix integer width and related bugs (Bug#9874).
293 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
294 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
295 (string_bytes, check_sblock, allocate_string_data):
296 (compact_small_strings, Fmake_bool_vector, make_string)
297 (make_unibyte_string, make_multibyte_string)
298 (make_string_from_bytes, make_specified_string)
299 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
300 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
301 (mark_vectorlike):
302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
303 (allocate_pseudovector):
304 Use int, not EMACS_INT, where int is wide enough.
305 (inhibit_garbage_collection, Fgarbage_collect):
306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
307 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
308 int might not be wide enough.
309 (bidi_cache_search, bidi_cache_find, bidi_init_it)
310 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
311 (bidi_at_paragraph_end, bidi_find_paragraph_start)
312 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
313 (bidi_level_of_next_char, bidi_move_to_visually_next):
314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
315 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
316 (Fkill_buffer, Fset_buffer_major_mode)
317 (advance_to_char_boundary, Fbuffer_swap_text)
318 (Fset_buffer_multibyte, overlays_at, overlays_in)
319 (overlay_touches_p, struct sortvec, record_overlay_string)
320 (overlay_strings, recenter_overlay_lists)
321 (adjust_overlays_for_insert, adjust_overlays_for_delete)
322 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
323 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
324 (Foverlay_recenter, last_overlay_modification_hooks_used)
325 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
327 (validate_region): Omit unnecessary test for b <= e,
328 since that's guaranteed by the previous test.
329 (adjust_overlays_for_delete): Avoid pos + length overflow.
330 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
331 (report_overlay_modification):
332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
333 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
334 Omit pointer cast, which isn't needed anyway, and doesn't work
335 after the EMACS_INT -> ptrdiff_t change.
336 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
337 * buffer.h: Adjust decls to match defn changes elsewhere.
338 (struct buffer_text, struct buffer):
339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
340 Use EMACS_INT, not int, where int might not be wide enough.
341 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
342 not int, to avoid needless 32-bit limit on 64-bit hosts.
343 (exec_byte_code): Use tighter memory-full test, one that checks
344 for alloca overflow. Don't compute the address of the object just
345 before an array, as that's not portable. Use EMACS_INT, not
346 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
347 * callint.c (Fcall_interactively):
348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
349 * callproc.c (call_process_kill, Fcall_process):
350 Don't assume pid_t fits into an Emacs fixnum.
351 (call_process_cleanup, Fcall_process, child_setup):
352 Don't assume pid_t fits into int.
353 (call_process_cleanup, Fcall_process, delete_temp_file)
354 (Fcall_process_region):
355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
356 (Fcall_process): Simplify handling of volatile integers.
357 Use int, not EMACS_INT, where int will do.
358 * casefiddle.c (casify_object, casify_region, operate_on_word)
359 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
361 (casify_object): Avoid integer overflow when overallocating buffer.
362 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
363 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
364 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
365 * category.h (CATEGORYP): Don't assume arg is nonnegative.
366 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
367 integers are now checked earlier. All uses replaced with XINT.
368 (ccl_driver):
369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
370 For CCL_MapSingle, check that content and value are in int range.
371 (ccl_driver, Fregister_code_conversion_map):
372 Check that Vcode_version_map_vector is a vector.
373 (resolve_symbol_ccl_program): Check that vector header is in range.
374 Always copy the vector, so that we can check its contents reliably
375 now rather than having to recheck each instruction as it's being
376 executed. Check that vector words fit in 'int'.
377 (ccl_get_compiled_code, Fregister_ccl_program)
378 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
379 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
380 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
381 contents are in range.
382 (Fccl_execute_on_string): Check that status is in range.
383 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
384 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
385 Accept and return EMACS_INT, not int, because callers can pass values
386 out of 'int' range.
387 (c_string_width, strwidth, lisp_string_width, chars_in_text)
388 (multibyte_chars_in_text, parse_str_as_multibyte)
389 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
390 (str_as_unibyte, str_to_unibyte, string_count_byte8)
391 (string_escape_byte8, Fget_byte):
392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
393 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
394 avoid mishandling large integers.
395 * character.h: Adjust decls to match defn changes elsewhere.
396 * charset.c (load_charset_map_from_file, find_charsets_in_text)
397 (Ffind_charset_region):
398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
399 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
400 (load_charset_map_from_vector, Fdefine_charset_internal):
401 Don't assume fixnum fits in int.
402 (load_charset_map_from_vector, Fmap_charset_chars):
403 Remove now-unnecessary CHECK_NATNUMs.
404 (Fdefine_charset_internal): Check ranges here, more carefully.
405 Don't rely on undefined behavior with signed left shift overflow.
406 Don't assume unsigned int fits into fixnum, or that fixnum fits
407 into unsigned int. Don't require max_code to be a valid fixnum;
408 that's not true for gb10830 4-byte on a 32-bit host. Allow
409 invalid_code to be a cons, for the same reason. Require code_offset
410 to be a character. Avoid int overflow if max_char is close
411 to INT_MAX.
412 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
413 this is intended anyway and avoids some undefined behavior.
414 (load_charset_map): Pass unsigned, not int, as 2nd arg of
415 INDEX_TO_CODE_POINT, as that's what it expects.
416 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
417 * charset.h (DECODE_CHAR): Return int, not unsigned;
418 this is what was intended anyway, and it avoids undefined behavior.
419 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
420 integer-overflow issues.
421 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
422 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
423 where the argument is EMACS_INT, and this behavior is not intended.
424 * chartab.c (Fmake_char_table, Fset_char_table_range)
425 (uniprop_get_decoder, uniprop_get_encoder):
426 Don't assume fixnum fits in int.
427 * cmds.c (move_point): New function, that does the gist of
428 Fforward_char and Fbackward_char, but does so while checking
429 for integer overflow more accurately.
430 (Fforward_char, Fbackward_char): Use it.
431 (Fforward_line, Fend_of_line, internal_self_insert)
432 (internal_self_insert):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 Fix a FIXME, by checking for integer overflow when calculating
435 target_clm and actual_clm.
436 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
437 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
438 (ASSURE_DESTINATION, coding_alloc_by_realloc)
439 (coding_alloc_by_making_gap, alloc_destination)
440 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
441 (encode_coding_utf_16, detect_coding_emacs_mule)
442 (decode_coding_emacs_mule, encode_coding_emacs_mule)
443 (detect_coding_iso_2022, decode_coding_iso_2022)
444 (encode_invocation_designation, encode_designation_at_bol)
445 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
446 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
447 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
448 (encode_coding_ccl, encode_coding_raw_text)
449 (detect_coding_charset, decode_coding_charset)
450 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
451 (produce_composition, produce_charset, produce_annotation)
452 (decode_coding, handle_composition_annotation)
453 (handle_charset_annotation, consume_chars, decode_coding_gap)
454 (decode_coding_object, encode_coding_object, detect_coding_system)
455 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
456 (code_convert_region, code_convert_string)
457 (Fdefine_coding_system_internal)
458 (coding_set_source, coding_set_destination):
459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
460 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
461 (Fdefine_coding_system_internal):
462 Don't assume fixnums fit in int.
463 (decode_coding_gap, decode_coding_object, encode_coding_object)
464 (Fread_coding_system, Fdetect_coding_region)
465 (Funencodable_char_position, Fcheck_coding_systems_region)
466 (get_translation, handle_composition_annotation, consume_chars):
467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
468 (consume_chars): Rewrite to not calculate an address outside buffer.
469 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
470 Don't access memory outside of the args array.
471 (Fdefine_coding_system_internal): Check for charset-id overflow.
472 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
473 result of ENCODE_CHAR.
474 * coding.h: Adjust decls to match defn changes elsewhere.
475 (struct coding_system):
476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
477 * composite.c (get_composition_id, find_composition)
478 (run_composition_function, update_compositions)
479 (compose_text, composition_gstring_put_cache)
480 (composition_gstring_p, composition_gstring_width)
481 (fill_gstring_header, fill_gstring_body, autocmp_chars)
482 (composition_compute_stop_pos, composition_reseat_it)
483 (composition_update_it, struct position_record)
484 (find_automatic_composition, composition_adjust_point)
485 (Fcomposition_get_gstring, Ffind_composition_internal):
486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
487 (update_compositions):
488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
489 * composite.h: Adjust decls to match defn changes elsewhere.
490 (struct composition):
491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
492 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
493 Do not attempt to compute the address of the object just before a
494 buffer; this is not portable.
495 (Faref, Faset):
496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
497 (Faset): Use int, not EMACS_INT, where int is wide enough.
498 (Fstring_to_number): Don't assume fixnums fit in int.
499 (Frem): Don't assume arg is nonnegative.
500 * dbusbind.c (xd_append_arg): Check for integers out of range.
501 (Fdbus_call_method): Don't overflow the timeout int.
502 (extract_signed, extract_unsigned): New functions.
503 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
504 (xd_get_connection_references): Return ptrdiff_t, not int.
505 All uses changed.
506 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
507 (xd_read_message_1):
508 Use int, not unsigned, where the dbus API uses int.
509 (Fdbus_message_internal): Don't overflow mtype.
510 (syms_of_dbusbind): Allocate right-sized buffer for integers.
511 * dired.c (directory_files_internal, file_name_completion, scmp)
512 (file_name_completion_stat):
513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
514 (file_name_completion): Don't overflow matchcount.
515 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
516 * dispextern.h: Adjust decls to match defn changes elsewhere.
517 (struct text_pos, struct glyph, struct bidi_saved_info)
518 (struct bidi_string_data, struct bidi_it, struct composition_it)
519 (struct it):
520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
521 (struct display_pos, struct composition_it, struct it):
522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
523 * dispnew.c (increment_matrix_positions)
524 (increment_row_positions, mode_line_string)
525 (marginal_area_string):
526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
527 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
529 (duration_to_sec_usec): New function, to check for overflow better.
530 (Fsleep_for, sit_for): Use it.
531 * doc.c (get_doc_string, store_function_docstring):
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 (get_doc_string, Fsnarf_documentation):
534 Use int, not EMACS_INT, where int is wide enough.
535 (get_doc_string):
536 Use SAFE_ALLOCA, not alloca.
537 Check for overflow when converting EMACS_INT to off_t.
538 * doprnt.c (doprnt):
539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
540 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
541 Don't assume uid_t fits into fixnum.
542 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
543 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
544 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
545 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
546 (general_insert_function)
547 (Finsert_char, make_buffer_string, make_buffer_string_both)
548 (update_buffer_properties, Fbuffer_substring)
549 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
550 (Fsubst_char_in_region, check_translation)
551 (Ftranslate_region_internal, save_restriction_restore, Fformat)
552 (transpose_markers, Ftranspose_regions):
553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
554 (clip_to_bounds): Move to lisp.h as an inline function).
555 (Fconstrain_to_field): Don't assume integers are nonnegative.
556 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
557 (Fsubst_char_in_region, Fsave_restriction):
558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
559 (Femacs_pid): Don't assume pid_t fits into fixnum.
560 (lo_time): Use int, not EMACS_INT, when int suffices.
561 (lisp_time_argument): Check for usec out of range.
562 (Fencode_time): Don't assume fixnum fits in int.
563 (Fuser_login_name, Fuser_full_name): Signal an error
564 if a uid argument is out of range, rather than relying on
565 undefined behavior.
566 (Fformat_time_string): Remove now-unnecessary check.
567 lisp_time_argument checks for out-of-range usec now.
568 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
569 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
570 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
571 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
572 (init_cmdargs, Fdump_emacs):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
575 the bottom (typically) 32 bits of the fixnum.
576 * eval.c (specpdl_size, call_debugger):
577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
578 (when_entered_debugger, Fbacktrace_debug):
579 Don't assume fixnum can fit in int.
580 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
581 the object just before a buffer; this is not portable.
582 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
583 (grow_specpdl, unbind_to):
584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
585 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
586 (grow_specpdl): Simplify allocation by using xpalloc.
587 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
588 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
589 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
591 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
592 (a_write, e_write):
593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
594 (Fcopy_file, non_regular_nbytes, read_non_regular)
595 (Finsert_file_contents):
596 Use int, not EMACS_INT, where int is wide enough.
597 (READ_BUF_SIZE): Verify that it fits in int.
598 (Finsert_file_contents): Check that counts are in proper range,
599 rather than assuming fixnums fit into ptrdiff_t etc.
600 Don't assume fixnums fit into int.
601 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
602 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
603 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
604 (string_char_to_byte, string_byte_to_char)
605 (string_make_multibyte, string_to_multibyte)
606 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
607 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
608 (substring_both, Fdelete, internal_equal, Ffillarray)
609 (Fclear_string, mapcar1)
610 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
611 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
612 (larger_vector, make_hash_table, maybe_resize_hash_table)
613 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
614 (Fmaphash, secure_hash):
615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
616 (concat): Check for string index and length overflow.
617 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
618 (Frequire):
619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
620 (larger_vector): New API (vec, incr_min, size_max) replaces old
621 one (vec, new_size, init). This catches size overflow.
622 INIT was removed because it was always Qnil.
623 All callers changed.
624 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
625 the upper bound on a hash table index size.
626 (make_hash_table, maybe_resize_hash_table): Use it.
627 (secure_hash): Computer start_byte and end_byte only after
628 they're known to be in ptrdiff_t range.
629 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
630 (Ffont_get_glyphs, Ffont_at):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
633 (Flist_fonts, Fopen_font):
634 Don't assume fixnum can fit in int.
635 (check_gstring): Don't assume index can fit in int.
636 (font_match_p): Check that fixnum is a character, not a nonnegative
637 fixnum, since the later code needs to stuff it into an int.
638 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
639 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
640 conversion overflow issues.
641 (Fopen_font): Check for integer out of range.
642 (Ffont_get_glyphs): Don't assume index can fit in int.
643 * font.h: Adjust decls to match defn changes elsewhere.
644 * fontset.c (reorder_font_vector): Redo score calculation to avoid
645 integer overflow.
646 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
647 printmax_t, where ptrdiff_t is wide enough.
648 (Finternal_char_font):
649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
650 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
651 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
652 (Fset_frame_position, x_set_frame_parameters)
653 (x_set_line_spacing, x_set_border_width)
654 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
655 Check that fixnums are in proper range for system types.
656 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
658 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
659 Use SAFE_ALLOCA_LISP, not alloca.
660 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
661 intptr_t is wide enough.
662 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
663 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
664 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
665 Check for fixnum out of range.
666 * ftfont.c (ftfont_list): Don't assume index fits in int.
667 Check that fixnums are in proper range for system types.
668 (ftfont_shape_by_flt):
669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
670 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
672 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
673 Check that fixnums are in proper range for system types.
674 * gnutls.h: Adjust decls to match defn changes elsewhere.
675 * gtkutil.c (xg_dialog_run):
676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
677 (update_frame_tool_bar):
678 Check that fixnums are in proper range for system types.
679 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
680 (lookup_image): Check that fixnums are in range for system types.
681 * indent.c (last_known_column, last_known_column_point):
682 (current_column_bol_cache):
683 (skip_invisible, current_column, check_display_width):
684 (check_display_width, scan_for_column, current_column_1)
685 (Findent_to, Fcurrent_indentation, position_indentation)
686 (indented_beyond_p, Fmove_to_column, compute_motion):
687 (Fcompute_motion, Fvertical_motion):
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 (last_known_column_modified): Use EMACS_INT, not int.
690 (check_display_width):
691 (Fcompute_motion):
692 Check that fixnums and floats are in proper range for system types.
693 (compute_motion): Don't assume index or fixnum fits in int.
694 (compute_motion, Fcompute_motion):
695 Use int, not EMACS_INT, when it is wide enough.
696 (vmotion): Omit local var start_hpos that is always 0; that way
697 we don't need to worry about overflow in expressions involving it.
698 * indent.h: Adjust decls to match defn changes elsewhere.
699 (struct position):
700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
701 Use int, not EMACS_INT, where int is wide enough.
702 Remove unused members ovstring_chars_done and tab_offset;
703 all uses removed.
704 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
705 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
706 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
707 (make_gap, copy_text, insert, insert_and_inherit)
708 (insert_before_markers, insert_before_markers_and_inherit)
709 (insert_1, count_combining_before, count_combining_after)
710 (insert_1_both, insert_from_string)
711 (insert_from_string_before_markers, insert_from_string_1)
712 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
713 (adjust_after_replace, adjust_after_insert, replace_range)
714 (replace_range_2, del_range, del_range_1, del_range_byte)
715 (del_range_both, del_range_2, modify_region)
716 (prepare_to_modify_buffer, signal_before_change)
717 (signal_after_change, Fcombine_after_change_execute):
718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
719 * intervals.c (traverse_intervals, rotate_right, rotate_left)
720 (balance_an_interval, split_interval_right, split_interval_left)
721 (find_interval, next_interval, update_interval)
722 (adjust_intervals_for_insertion, delete_node, delete_interval)
723 (interval_deletion_adjustment, adjust_intervals_for_deletion)
724 (static_offset_intervals, offset_intervals)
725 (merge_interval_right, merge_interval_left, make_new_interval)
726 (graft_intervals_into_buffer, temp_set_point_both)
727 (temp_set_point, set_point, adjust_for_invis_intang)
728 (set_point_both, move_if_not_intangible, get_property_and_range)
729 (get_local_map, copy_intervals, copy_intervals_to_string)
730 (compare_string_intervals, set_intervals_multibyte_1):
731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
732 * intervals.h: Adjust decls to match defn changes elsewhere.
733 (struct interval):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 * keyboard.c (this_command_key_count, this_single_command_key_start)
736 (before_command_key_count, before_command_echo_length, echo_now)
737 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
738 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
739 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
740 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
742 (last_non_minibuf_size, last_point_position, echo_truncate)
743 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
744 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
745 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
746 (stuff_buffered_input):
747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
748 (last_auto_save, command_loop_1, read_char):
749 Use EMACS_INT, not int, to avoid integer overflow.
750 (record_char): Avoid overflow in total_keys computation.
751 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
752 * keyboard.h: Adjust decls to match defn changes elsewhere.
753 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
754 (Fkey_description, Fdescribe_vector, Flookup_key):
755 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
756 (click_position): New function, to check that positions are in range.
757 (Fcurrent_active_maps):
758 (describe_command):
759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
760 (Faccessible_keymaps, Fkey_description):
761 (preferred_sequence_p):
762 Don't assume fixnum can fit into int.
763 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
764 Check for integer overflow in size calculations.
765 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
766 avoid mishandling large integers.
767 * lisp.h: Adjust decls to match defn changes elsewhere.
768 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
769 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
770 (struct Lisp_Marker):
771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
772 (clip_to_bounds): Now an inline function, moved here from editfns.c.
773 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
774 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
775 All callers changed.
776 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
777 Assume the arg has valid form, since it always does.
778 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
779 unsigned integer system type.
780 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
781 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
783 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
784 (duration_to_sec_usec): New decl.
785 * lread.c (read_from_string_index, read_from_string_index_byte)
786 (read_from_string_limit, readchar, unreadchar, openp)
787 (read_internal_start, read1, oblookup):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 (Fload, readevalloop, Feval_buffer, Feval_region):
790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
791 (openp): Check for out-of-range argument to 'access'.
792 (read1): Use int, not EMACS_INT, where int is wide enough.
793 Don't assume fixnum fits into int.
794 Fix off-by-one error that can read outside a buffer.
795 (read_filtered_event): Use duration_to_sec_usec
796 to do proper overflow checking on durations.
797 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
798 in size calculation.
799 (Fexecute_kbd_macro):
800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
801 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
802 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
803 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
804 (set_marker_both, set_marker_restricted_both, marker_position)
805 (marker_byte_position, Fbuffer_has_markers_at):
806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
807 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
808 * menu.c (ensure_menu_items): Rename from grow_menu_items.
809 It now merely ensures that the menu is large enough, without
810 necessarily growing it, as this avoids some integer overflow issues.
811 All callers changed.
812 (keymap_panes, parse_single_submenu, Fx_popup_menu):
813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
814 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
815 Use SAFE_ALLOCA_LISP, not alloca.
816 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
817 to EMACS_INT. Check that fixnums are in proper range for system types.
818 * minibuf.c (minibuf_prompt_width, string_to_object)
819 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
820 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
822 (get_minibuffer, read_minibuf_unwind):
823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
824 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
825 this simplifies overflow checking. All callers changed.
826 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
827 (Ftest_completion):
828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
829 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
830 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
831 Check that fixnums are in proper range for system types.
832 (Fx_create_frame, Fx_show_tip):
833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
834 * nsfont.m (ns_findfonts, nsfont_list_family):
835 Don't assume fixnum fits in long.
836 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
838 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
839 wide enough.
840 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
842 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
843 (PRINTDECLARE, PRINTPREPARE):
844 (strout, print_string):
845 (print, print_preprocess, print_check_string_charset_prop)
846 (print_object):
847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
848 (PRINTDECLARE):
849 (temp_output_buffer_setup, Fprin1_to_string, print_object):
850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
851 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
852 (printchar, strout): Use xpalloc to catch size calculation overflow.
853 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
854 (print_error_message): Use SAFE_ALLOCA, not alloca.
855 (print_object): Use int, not EMACS_INT, where int is wide enough.
856 (print_depth, new_backquote_output, print_number_index):
857 Use ptrdiff_t, not int, where int might not be wide enough.
858 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
859 (Fset_process_window_size, Fformat_network_address)
860 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
861 (sigchld_handler):
862 Check that fixnums are in proper range for system types.
863 (Fsignal_process): Simplify by avoiding a goto.
864 Check for process-ids out of pid_t range rather than relying on
865 undefined behavior.
866 (process_tick, update_tick): Use EMACS_INT, not int.
867 (Fformat_network_address, read_process_output, send_process)
868 (Fprocess_send_region, status_notify):
869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
870 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
871 (wait_reading_process_output, read_process_output, exec_sentinel):
872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
873 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
874 (Faccept_process_output): Use duration_to_sec_usec to do proper
875 overflow checking on durations.
876 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
877 Don't assume pid_t fits in int.
878 * process.h (struct Lisp_Process): Members tick and update_tick
879 are now of type EMACS_INT, not int.
880 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
881 configured --with-wide-int.
882 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
883 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
884 * search.c (looking_at_1, string_match_1):
885 (fast_string_match, fast_c_string_match_ignore_case)
886 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
887 (scan_newline, find_before_next_newline, search_command)
888 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
889 (set_search_regs, wordify):
890 (Freplace_match):
891 (Fmatch_data):
892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
893 (string_match_1, search_buffer, set_search_regs):
894 (Fmatch_data):
895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
896 (wordify): Check for overflow in size calculation.
897 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
898 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
899 Check that fixnums are in proper range for system types.
900 * sound.c (struct sound_device)
901 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
903 (Fplay_sound_internal):
904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
905 * syntax.c (struct lisp_parse_state, find_start_modiff)
906 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
907 (Fparse_partial_sexp):
908 Don't assume fixnums can fit in int.
909 (struct lisp_parse_state, find_start_pos, find_start_value)
910 (find_start_value_byte, find_start_begv)
911 (update_syntax_table, char_quoted, dec_bytepos)
912 (find_defun_start, prev_char_comend_first, back_comment):
913 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
914 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
916 (Finternal_describe_syntax_value): Check that match_lisp is a
917 character, not an integer, since the code stuffs it into int.
918 (scan_words, scan_sexps_forward):
919 Check that fixnums are in proper range for system types.
920 (Fforward_word):
921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
922 (scan_sexps_forward):
923 Use CHARACTERP, not INTEGERP, since the value must fit into int.
924 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
925 * syntax.h: Adjust decls to match defn changes elsewhere.
926 (struct gl_state_s):
927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
928 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
929 MOST_POSITIVE_FIXNUM.
930 * sysdep.c (wait_for_termination_1, wait_for_termination)
931 (interruptible_wait_for_termination, mkdir):
932 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
933 (emacs_read, emacs_write):
934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
935 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
936 and double all fit in int.
937 * term.c (set_tty_color_mode):
938 Check that fixnums are in proper range for system types.
939 * termhooks.h (struct input_event):
940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
941 * textprop.c (validate_interval_range, interval_of)
942 (Fadd_text_properties, set_text_properties_1)
943 (Fremove_text_properties, Fremove_list_of_text_properties)
944 (Ftext_property_any, Ftext_property_not_all)
945 (copy_text_properties, text_property_list, extend_property_ranges)
946 (verify_interval_modification):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 (Fnext_single_char_property_change)
949 (Fprevious_single_char_property_change):
950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
951 (copy_text_properties):
952 Check for integer overflow in index calculation.
953 * undo.c (last_boundary_position, record_point, record_insert)
954 (record_delete, record_marker_adjustment, record_change)
955 (record_property_change):
956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
957 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
959 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
960 (Fx_hide_tip, Fx_file_dialog):
961 * w32menu.c (set_frame_menubar):
962 Use ptrdiff_t, not int, for consistency with rest of code.
963 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
964 (select_window, Fdelete_other_windows_internal)
965 (window_scroll_pixel_based, window_scroll_line_based)
966 (Frecenter, Fset_window_configuration):
967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
968 (Fset_window_hscroll, run_window_configuration_change_hook)
969 (set_window_buffer, temp_output_buffer_show, scroll_command)
970 (Fscroll_other_window, Frecenter):
971 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
972 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
973 Don't assume fixnum fits in int.
974 (Fset_window_scroll_bars):
975 Check that fixnums are in proper range for system types.
976 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
977 (string_pos, c_string_pos, number_of_chars, init_iterator)
978 (in_ellipses_for_invisible_text_p, init_from_display_pos)
979 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
980 (compute_display_string_end, handle_face_prop)
981 (face_before_or_after_it_pos, handle_invisible_prop)
982 (handle_display_prop, handle_display_spec, handle_single_display_spec)
983 (display_prop_intangible_p, string_buffer_position_lim)
984 (string_buffer_position, handle_composition_prop, load_overlay_strings)
985 (get_overlay_strings_1, get_overlay_strings)
986 (iterate_out_of_display_property, forward_to_next_line_start)
987 (back_to_previous_visible_line_start, reseat, reseat_to_string)
988 (get_next_display_element, set_iterator_to_next)
989 (get_visually_first_element, compute_stop_pos_backwards)
990 (handle_stop_backwards, next_element_from_buffer)
991 (move_it_in_display_line_to, move_it_in_display_line)
992 (move_it_to, move_it_vertically_backward, move_it_by_lines)
993 (add_to_log, message_dolog, message_log_check_duplicate)
994 (message2, message2_nolog, message3, message3_nolog
995 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
996 (current_message_1, truncate_echo_area, truncate_message_1)
997 (set_message, set_message_1, store_mode_line_noprop)
998 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
999 (text_outside_line_unchanged_p, check_point_in_composition)
1000 (reconsider_clip_changes)
1001 (redisplay_internal, set_cursor_from_row, try_scrolling)
1002 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1003 (redisplay_window, find_last_unchanged_at_beg_row)
1004 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1005 (trailing_whitespace_p, find_row_edges, display_line)
1006 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1007 (display_mode_element, store_mode_line_string)
1008 (pint2str, pint2hrstr, decode_mode_spec)
1009 (display_count_lines, display_string, draw_glyphs)
1010 (x_produce_glyphs, x_insert_glyphs)
1011 (rows_from_pos_range, mouse_face_from_buffer_pos)
1012 (fast_find_string_pos, mouse_face_from_string_pos)
1013 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1014 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1015 (safe_call, init_from_display_pos, handle_fontified_prop)
1016 (handle_single_display_spec, load_overlay_strings)
1017 (with_echo_area_buffer, setup_echo_area_for_printing)
1018 (display_echo_area, echo_area_display)
1019 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1020 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1021 (redisplay_window, dump_glyph_row, display_mode_line)
1022 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1023 (handle_display_spec, display_prop_string_p):
1024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1025 (handle_single_display_spec, build_desired_tool_bar_string)
1026 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1027 (get_specified_cursor_type):
1028 Check that fixnums are in proper range for system types.
1029 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1030 (Flookup_image_map):
1031 Don't assume fixnums fit in int.
1032 (compare_overlay_entries):
1033 Avoid mishandling comparisons due to subtraction overflow.
1034 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1035 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1036 (handle_tool_bar_click):
1037 Use int, not unsigned, since we prefer signed and the signedness
1038 doesn't matter here.
1039 (get_next_display_element, next_element_from_display_vector):
1040 Use int, not EMACS_INT, when int is wide enough.
1041 (start_hourglass): Use duration_to_sec_usec to do proper
1042 overflow checking on durations.
1043 * xfaces.c (Fbitmap_spec_p):
1044 Check that fixnums are in proper range for system types.
1045 (compare_fonts_by_sort_order):
1046 Avoid mishandling comparisons due to subtraction overflow.
1047 (Fx_family_fonts, realize_basic_faces):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 (Fx_family_fonts):
1050 Don't assume fixnum fits in int.
1051 Use SAFE_ALLOCA_LISP, not alloca.
1052 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1053 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1054 (face_at_buffer_position, face_for_overlay_string)
1055 (face_at_string_position):
1056 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1057 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1058 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1059 (Fx_show_tip):
1060 Check that fixnums are in proper range for system types.
1061 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1062 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1064 (Fx_change_window_property): Don't assume fixnums fit in int.
1065 * xfont.c (xfont_chars_supported):
1066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1067 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1068 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1070 * xml.c (parse_region):
1071 * xrdb.c (magic_file_p):
1072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1073 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1074 (x_get_local_selection, x_reply_selection_request)
1075 (x_handle_selection_request, wait_for_property_change):
1076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1077 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1078 short is wide enough.
1079 (x_send_client_event): Don't assume fixnum fits in int.
1080 * xterm.c (x_x_to_emacs_modifiers):
1081 Don't assume EMACS_INT overflows nicely into int.
1082 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1083 may come from Lisp.
1084 (handle_one_xevent): NATNUMP can eval its arg twice.
1085 (x_connection_closed):
1086 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1087 * xterm.h: Adjust decls to match defn changes elsewhere.
1088 (struct scroll_bar): Use struct vectorlike_header
1089 rather than rolling our own approximation.
1090 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1091
1092 2012-05-25 Glenn Morris <rgm@gnu.org>
1093
1094 * lisp.mk (lisp): Update for more files being compiled now.
1095
1096 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1097
1098 * lread.c: Remove `read_pure' which makes no difference.
1099 (read_pure): Remove var.
1100 (unreadpure): Remove function.
1101 (readevalloop): Don't call read_list with -1 flag.
1102 (read1, read_vector): Don't test read_pure any more.
1103 (read_list): Simplify.
1104
1105 * fileio.c, character.h: Minor style tweaks.
1106
1107 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1108
1109 * window.h (clip_changed): Remove useless declaration.
1110
1111 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1112
1113 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1114 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1115
1116 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 Remove src/m/*.
1119 This directory predates autoconf and is no longer needed nowadays.
1120 Move its few remaining bits of functionality to where they're needed.
1121 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1122 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1123 * m/template.h: Remove.
1124 * Makefile.in (M_FILE): Remove. All uses removed.
1125 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1126 * lisp.h (USE_LSB_TAG):
1127 * mem-limits.h (EXCEEDS_LISP_PTR):
1128 Use VAL_MAX, not VALBITS, in #if.
1129 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1130 (EMACS_UINT): Define unconditionally now.
1131 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1132 (BITS_PER_EMACS_INT): New constants, replacing
1133 what used to be in config.h, but not useful in #if.
1134 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1135 define them any more.
1136 (VAL_MAX): New macro.
1137 (VALMASK): Use it.
1138 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1139 BITS_PER_EMACS_INT, in #if.
1140 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1141 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1142 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1143 * s/ms-w32.h (DATA_START):
1144 Move here from removed file m/intel386.h.
1145 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1146 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1147
1148 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1149
1150 Assume C89 or later.
1151 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1152 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1153 (xrealloc):
1154 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1155 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1156 * textprop.c, tparam.c (NULL): Remove.
1157 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1158 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1159 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1160 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1161 * xterm.c (input_signal_count): Assume volatile works.
1162
1163 2012-05-21 Ken Brown <kbrown@cornell.edu>
1164
1165 * xgselect.c (xg_select): Fix first argument in call to 'select'
1166 (bug#11508).
1167
1168 2012-05-20 Ken Brown <kbrown@cornell.edu>
1169
1170 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1171 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1172
1173 2012-05-19 Ken Brown <kbrown@cornell.edu>
1174
1175 * xfns.c (x_in_use): Remove `static' qualifier.
1176 * xterm.h (x_in_use): Declare.
1177 * xgselect.c: Include xterm.h.
1178 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1179 and `display_arg' (bug#9754).
1180
1181 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1182
1183 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1184
1185 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1186 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1187
1188 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1189
1190 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1191
1192 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1193 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1194
1195 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1196 reference to image_cache->refcount.
1197 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1198
1199 2012-05-17 Juri Linkov <juri@jurta.org>
1200
1201 * search.c (Fword_search_regexp, Fword_search_backward)
1202 (Fword_search_forward, Fword_search_backward_lax)
1203 (Fword_search_forward_lax): Move functions to isearch.el
1204 (bug#10145, bug#11381).
1205
1206 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1207
1208 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1209
1210 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1211
1212 * lread.c (init_obarray): Declare Qt and Qnil as special.
1213
1214 2012-05-14 Glenn Morris <rgm@gnu.org>
1215
1216 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1217 Put "libexec" before "bin", for the sake of init_callproc_1.
1218
1219 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1222
1223 * unexaix.c: Port to more-recent AIX compilers.
1224 (report_error, report_error_1, make_hdr, copy_sym)
1225 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1226 Make arguments const char *, not char *, to avoid violations of C
1227 standard and to fix some AIX warnings reported by Gilles Pion.
1228
1229 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1232 already have overlays loaded.
1233 (handle_single_display_spec): Before returning without displaying
1234 fringe bitmap, synchronize the bidi iterator with the main display
1235 iterator, by calling iterate_out_of_display_property.
1236 (iterate_out_of_display_property): Detect buffer iteration by
1237 testing that it->string is a Lisp string.
1238 (get_next_display_element): When the current object is exhausted,
1239 and there's something on it->stack, call set_iterator_to_next to
1240 proceed with what's on the stack, instead of returning zero.
1241 (set_iterator_to_next): If called at the end of a Lisp string,
1242 proceed to consider_string_end without incrementing string
1243 position. Don't increment display vector index past the end of
1244 the display vector. (Bug#11417)
1245 (pos_visible_p): Don't report a position visible when move_it_to
1246 stopped at the last line of window, which happens to be scanned
1247 backwards by the bidi iteration. (Bug#11464)
1248
1249 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1252 and right-margin display specs even if the spec is invalid or we
1253 are on a TTY, and thus unable to display on the fringes.
1254 That's because the text with the property will not be displayed anyway,
1255 so we need to signal to the caller that this is a "replacing"
1256 display spec. This fixes display when the spec is invalid or we
1257 are on a TTY.
1258
1259 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 * unexaix.c (make_hdr): Fix typo in prototype.
1262 This bug broke the build on AIX. Problem reported by Gilles Pion.
1263
1264 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1265
1266 * keyboard.c (kbd_buffer_get_event): Read special events also in
1267 batch mode. (Bug#11415)
1268
1269 2012-05-12 Glenn Morris <rgm@gnu.org>
1270
1271 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1272
1273 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1274
1275 * lisp.mk (lisp): Add newcomment.elc.
1276
1277 2012-05-12 Glenn Morris <rgm@gnu.org>
1278
1279 * Makefile.in (MKDIR_P): New, set by configure.
1280 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1281
1282 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 Remove unused function hourglass_started.
1285 * dispextern.h (hourglass_started):
1286 * w32fns.c (hourglass_started):
1287 * xdisp.c (hourglass_started): Remove.
1288
1289 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1290
1291 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1292 Update dependencies.
1293
1294 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 * xgselect.c (xg_select): Put maxfds+1 into a var.
1297 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1298
1299 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1300
1301 2012-05-10 Dave Abrahams <dave@boostpro.com>
1302
1303 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1304 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1305
1306 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1307
1308 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1309 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1310 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1311 Initialize xd_registered_buses.
1312
1313 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 Untag more efficiently if USE_LSB_TAG.
1316 This is based on a proposal by YAMAMOTO Mitsuharu in
1317 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1318 For an admittedly artificial (nth 8000 longlist) benchmark on
1319 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1320 Emacs's overall text size by 1%.
1321 * lisp.h (XUNTAG): New macro.
1322 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1323 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1324 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1325 * eval.c (Fautoload):
1326 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1327 * frame.h (XFRAME): Use XUNTAG.
1328
1329 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1330 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1331 Remove unportable assumptions about print widths of types like
1332 dbus_uint32_t.
1333 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1334 intptr_t when converting between pointer and integer, to avoid GCC
1335 warnings about wrong width.
1336
1337 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1338
1339 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1340 stack for each reader_thread, instead of defaulting to 8MB
1341 determined by the linker. This avoids failures in creating
1342 subprocesses on Windows 7, see the discussion in this thread:
1343 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1344
1345 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1346
1347 Fix up display of the *Minibuf-0* buffer in the mini window.
1348 * keyboard.c (read_char): Don't clear the echo area if there's no
1349 message to clear.
1350 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1351 contents of *Minibuf-0*) if there's no message displayed in its stead.
1352
1353 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1354
1355 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1356 batch mode.
1357
1358 2012-05-06 Chong Yidong <cyd@gnu.org>
1359
1360 * lisp.mk (lisp): Update.
1361
1362 2012-05-05 Jim Meyering <meyering@redhat.com>
1363
1364 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1365
1366 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1367
1368 * data.c (PUT_ERROR): New macro.
1369 (syms_of_data): Use it. Add new error type `user-error'.
1370 * undo.c (user_error): New function.
1371 (Fprimitive_undo): Use it.
1372 * print.c (print_error_message): Adjust print style for `user-error'.
1373 * keyboard.c (user_error): New function.
1374 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1375
1376 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1377
1378 Do not limit current-time-string to years 1000..9999.
1379 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1380 (Fcurrent_time_string): Support any year that is supported by the
1381 underlying localtime representation. Don't use asctime, as it
1382 has undefined behavior for years outside the range -999..9999.
1383
1384 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1385
1386 Fix race conditions involving setenv, gmtime, localtime, asctime.
1387 Without this fix, interrupts could mess up code that uses these
1388 nonreentrant functions, since setting TZ invalidates existing
1389 tm_zone or tzname values, and since most of these functions return
1390 pointers to static storage.
1391 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1392 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1393 Grow the critical sections to include not just invoking
1394 localtime/gmtime, but also accessing these functions' results
1395 including their tm_zone values if any, and any related TZ setting.
1396 (format_time_string): Last arg is now struct tm *, not struct tm **,
1397 so that the struct tm is saved in the critical section.
1398 All callers changed. Simplify allocation of initial buffer, partly
1399 motivated by the fact that memory allocation needs to be outside
1400 the critical section.
1401
1402 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1403
1404 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1405 with RESET_INTERVAL.
1406
1407 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1408 Remove duplicated buffer name initialization.
1409
1410 2012-05-02 Jim Meyering <jim@meyering.net>
1411
1412 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1413
1414 * xfns.c (x_window): Use xstrdup (Bug#11375).
1415
1416 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1417
1418 * xdisp.c (pos_visible_p): If already at a newline from the
1419 display string before the 'while' loop, don't walk back the glyphs
1420 from it3.glyph_row. Solves assertion violation when the display
1421 string begins with a newline (egg.el). (Bug#11367)
1422
1423 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1424
1425 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1426 Move to simple.el.
1427
1428 2012-05-01 Glenn Morris <rgm@gnu.org>
1429
1430 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1431 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1432 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1433 All were removed before 23.1.
1434
1435 * dispnew.c: Remove HAVE_LIBNCURSES test;
1436 it is always true on relevant platforms.
1437
1438 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1439 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1440
1441 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1442
1443 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1444
1445 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1446 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1447 Remove.
1448
1449 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 Do not avoid creating empty evaporating overlays (Bug#9642).
1452 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1453 That is, do not delete an evaporating overlay if it becomes
1454 empty after its bounds are adjusted to fit within its buffer.
1455 This fix caused other problems, and I'm reverting it until we get
1456 to the bottom of them.
1457
1458 2012-04-27 Chong Yidong <cyd@gnu.org>
1459
1460 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1461
1462 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1463
1464 * xdisp.c (pos_visible_p): If the window start position is beyond
1465 ZV, start the display from buffer beginning. Prevents assertion
1466 violation in init_iterator when the minibuffer window is scrolled
1467 via the scroll bar.
1468
1469 * window.c (window_scroll_pixel_based): Likewise.
1470
1471 2012-04-27 Chong Yidong <cyd@gnu.org>
1472
1473 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1474
1475 2012-04-27 Glenn Morris <rgm@gnu.org>
1476
1477 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1478 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1479
1480 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1481
1482 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1483 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1484
1485 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1486
1487 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1488 display element, check also the underlying string or buffer
1489 character. (Bug#11341)
1490
1491 * w32menu.c: Include w32heap.h.
1492 (add_menu_item): If the call to AppendMenuW (via
1493 unicode_append_menu) fails, disable Unicode menus only if we are
1494 running on Windows 9X/Me.
1495
1496 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1497
1498 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1499 (xgetint): Add missing shift for LSB tags.
1500
1501 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1502
1503 * keyboard.c (read_char): Don't wipe echo area for select window
1504 events: These might get delayed via `mouse-autoselect-window'
1505 (Bug#11304).
1506
1507 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1508
1509 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1510 manipulation of :loaded-from data.
1511
1512 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1513
1514 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1515 now a cons (bug#11311).
1516
1517 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 Do not create empty overlays with the evaporate property (Bug#9642).
1520 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1521 if it becomes empty after its bounds are adjusted to fit within
1522 its buffer. Without this fix, in a nonempty buffer (let ((o
1523 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1524 yields an empty overlay that has the evaporate property, which is
1525 not supposed to happen.
1526
1527 Fix minor GTK3 problems found by static checking.
1528 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1529 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1530 (struct _EmacsFixedClass, emacs_fixed_get_type):
1531 Move decls here from emacsgtkfixed.h, since they needn't be public.
1532 (emacs_fixed_get_type): Now static.
1533 (emacs_fixed_class_init): Omit unused local.
1534 (emacs_fixed_child_type): Remove; unused.
1535 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1536 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1537 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1538 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1539 (EMACS_FIXED_GET_CLASS): Remove; unused.
1540 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1541
1542 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1543 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1544
1545 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1548 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1549 (__malloc_size_t, __malloc_ptrdiff_t):
1550 Remove. All uses removed, replaced by the definiens if needed,
1551 since we can assume C89 or better now.
1552 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1553 (protect_malloc_state, align, get_contiguous_space)
1554 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1555 (malloc_atfork_handler_child, malloc_enable_thread)
1556 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1557 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1558 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1559 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1560 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1561 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1562 Define using prototypes, not old style.
1563 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1564 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1565 (align): Don't assume that signed integer overflow wraps around.
1566 Omit unused local var.
1567 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1568 (_free_internal_nolock, memalign, mallochook, reallochook):
1569 Omit no-longer-needed casts.
1570 (valloc): Use getpagesize, not __getpagesize.
1571 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1572 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1573
1574 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1575
1576 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1577
1578 Move functions from C to Lisp. Make non-blocking method calls
1579 the default. Implement further D-Bus standard interfaces.
1580
1581 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1582 (QCdbus_request_name_allow_replacement)
1583 (QCdbus_request_name_replace_existing)
1584 (QCdbus_request_name_do_not_queue)
1585 (QCdbus_request_name_reply_primary_owner)
1586 (QCdbus_request_name_reply_in_queue)
1587 (QCdbus_request_name_reply_exists)
1588 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1589 (QCdbus_registered_serial, QCdbus_registered_method)
1590 (QCdbus_registered_signal): New Lisp objects.
1591 (XD_DEBUG_MESSAGE): Use sizeof.
1592 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1593 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1594 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1595 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1596 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1597 (xd_signature, xd_append_arg): Allow float for integer types.
1598 (xd_get_connection_references): New function.
1599 (xd_get_connection_address): Rename from xd_initialize.
1600 Return cached address.
1601 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1602 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1603 level.
1604 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1605 Return number of refcounts.
1606 (Fdbus_get_unique_name): Make stronger parameter check.
1607 (Fdbus_message_internal): New defun.
1608 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1609 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1610 (Fdbus_send_signal, Fdbus_register_service)
1611 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1612 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1613 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1614 (Vdbus_compiled_version, Vdbus_runtime_version)
1615 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1616 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1617 (Vdbus_message_type_signal): New defvars.
1618 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1619 Adapt docstring.
1620
1621 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1624 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1625 Do not assume ptrdiff_t is the same width as 'int'.
1626
1627 * alloc.c: Handle unusual debugging option combinations.
1628 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1629 since the two debugging options are incompatible.
1630 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1631 is defined.
1632 (mem_init, mem_insert, mem_insert_fixup):
1633 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1634 (NEED_MEM_INSERT): Remove; no longer needed.
1635
1636 2012-04-22 Leo Liu <sdl.web@gmail.com>
1637
1638 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1639
1640 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1641
1642 * sysdep.c [__FreeBSD__]: Minor cleanups.
1643 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1644 Use Emacs indenting style more consistently. Avoid some casts.
1645 Use 'double' consistently rather than mixing 'float' and 'double'.
1646
1647 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1648
1649 * sysdep.c (list_system_processes, system_process_attributes):
1650 Add implementation for FreeBSD (Bug#5243).
1651
1652 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1653
1654 * lisp.mk (lisp): Update.
1655
1656 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1657
1658 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1659 It is never used otherwise.
1660
1661 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1662
1663 * print.c (print_preprocess): Only check print_depth if print-circle
1664 is nil.
1665 (print_object): Check for cycles even when print-circle is nil and
1666 print-gensym is t, but only check print_depth if print-circle is nil.
1667
1668 2012-04-20 Chong Yidong <cyd@gnu.org>
1669
1670 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1671 set the status to "failed" and ensure that sentinel is run.
1672
1673 2012-04-20 Glenn Morris <rgm@gnu.org>
1674
1675 * process.c (Fset_process_inherit_coding_system_flag)
1676 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1677 (Fmake_network_process, Fmake_serial_process): Doc fix.
1678
1679 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (string_buffer_position_lim): Limit starting position to
1682 BEGV.
1683 (set_cursor_from_row): If called for a mode-line or header-line
1684 row, return zero immediately.
1685 (try_cursor_movement): If inside continuation line, don't back up
1686 farther than the first row after the header line, if any.
1687 Don't consider the header-line row as "partially visible", even if
1688 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1689
1690 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1691
1692 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1693 (bug#11238).
1694
1695 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1696 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1697
1698 configure: new option --enable-gcc-warnings (Bug#11207)
1699 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1700 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1701 (ALL_CFLAGS): Use new macros rather than old.
1702 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1703 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1704 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1705 -Wunused-result, -Wunused-variable. This should go away once
1706 the Emacs and Gnulib regex code is merged.
1707 (xmalloc, xrealloc): Now static.
1708
1709 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 * dired.c (Fsystem_groups): Remove unused local.
1712
1713 2012-04-17 Glenn Morris <rgm@gnu.org>
1714
1715 * dired.c (Fsystem_users): Doc fix.
1716
1717 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1718
1719 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1720 (syms_of_dired): Add them.
1721
1722 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 Fix minor alloc.c problems found by static checking.
1725 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1726 New extern decls, to avoid calling undeclared functions.
1727 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1728 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1729 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1730 (NEED_MEM_INSERT): New macro.
1731 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1732 Remove one incorrect comment and fix another.
1733
1734 Fix minor ralloc.c problems found by static checking.
1735 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1736 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1737 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1738 (r_alloc_sbrk): Now static.
1739
1740 Improve ralloc.c interface checking.
1741 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1742 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1743 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1744 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1745 [REL_ALLOC]: ... to here, to check interface.
1746 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1747 Remove decls. This fixes an "It stinks!".
1748
1749 * alloc.c (which_symbols): Fix alignment issue / type clash.
1750
1751 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1752
1753 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1754 (struct Lisp_Misc_Any): Likewise.
1755 (struct Lisp_Free): Likewise.
1756 * alloc.c (union aligned_Lisp_Symbol): Define.
1757 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1758 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1759 (union aligned_Lisp_Misc): Define.
1760 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1761 aligned_Lisp_Misc instead of union Lisp_Misc.
1762 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1763
1764 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1767 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1768 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1769 * s/netbsd.h, s/sol2-6.h:
1770 Remove definition of GC_MARK_STACK, since the default now works.
1771 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1772 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1773 no longer the default.
1774 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1775
1776 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1777
1778 * lread.c (lisp_file_lexically_bound_p):
1779 Fix hang at ";-*-\n" (bug#11238).
1780
1781 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1782
1783 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1784 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1785
1786 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1787
1788 * nsterm.m (constrainFrameRect): Always constrain when there is only
1789 one screen (Bug#10962).
1790
1791 2012-04-13 Ken Brown <kbrown@cornell.edu>
1792
1793 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1794
1795 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1796
1797 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1798
1799 2012-04-11 Daniel Colascione <dancol@dancol.org>
1800
1801 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1802 against is gone. It's better to use vfork now so that when Cygwin
1803 gains a new, working vfork, we use it automatically (bug#10398).
1804
1805 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1806
1807 * window.c (save_window_save): Obey window-point-insertion-type.
1808
1809 2012-04-11 Glenn Morris <rgm@gnu.org>
1810
1811 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1812
1813 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1814
1815 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1816
1817 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1818
1819 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1820 (force_quit_count): New var.
1821 (handle_interrupt): Use it.
1822
1823 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1824
1825 * w32.c (w32_delayed_load): Record the full path of the library
1826 being loaded (bug#10424).
1827
1828 2012-04-09 Glenn Morris <rgm@gnu.org>
1829
1830 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1831 not just in the obarray, before snarfing them. (Bug#11036)
1832
1833 * Makefile.in ($(leimdir)/leim-list.el):
1834 Pass EMACS rather than BUILT_EMACS.
1835
1836 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1837
1838 * process.c (make_process):
1839 * process.h: Add integer `gnutls_handshakes_tried' member to
1840 process struct.
1841
1842 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1843 Add convenience `GNUTLS_LOG2i' macro.
1844
1845 * gnutls.c (gnutls_log_function2i): Convenience log function.
1846 (emacs_gnutls_read): Use new log functions,
1847 `gnutls_handshakes_tried' process member, and
1848 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1849 attempts per process (connection).
1850
1851 2012-04-09 Chong Yidong <cyd@gnu.org>
1852
1853 * eval.c (Fuser_variable_p, user_variable_p_eh)
1854 (lisp_indirect_variable): Functions deleted.
1855 (Fdefvar): Caller changed.
1856
1857 * callint.c (Finteractive, Fcall_interactively):
1858 * minibuf.c (Fread_variable): Callers changed.
1859
1860 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1861
1862 * xdisp.c (set_cursor_from_row): If the display string appears in
1863 the buffer at position that is closer to point than the position
1864 after the display string, display the cursor on the first glyph of
1865 the display string. Fixes cursor display when a 'display' text
1866 property immediately follows invisible text. (Bug#11094)
1867
1868 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 composite.c: use 'double' consistently
1871 * composite.c (get_composition_id): Use 'double' consistently
1872 instead of converting 'float' to 'double' and vice versa; this is
1873 easier to understand and avoids a GCC warning.
1874
1875 2012-04-09 Glenn Morris <rgm@gnu.org>
1876
1877 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1878 preparation for dumping it with emacs. (Bug#4789)
1879 (leimdir): New variable.
1880 ($(leimdir)/leim-list.el): New rule.
1881 (emacs$(EXEEXT)): Depend on leim-list.el.
1882
1883 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1884 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1885 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1886
1887 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1888
1889 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1890 proper alignment.
1891
1892 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1893
1894 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1895 Remove unused local variable.
1896
1897 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1898
1899 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1900 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1901 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1902 objects, as mark_maybe_pointer will catch them otherwise.
1903 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1904 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1905
1906 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 Fix typo that broke non-Windows builds.
1909 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1910
1911 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1912
1913 Support building on MS-Windows with libxml2.
1914
1915 * makefile.w32-in (OBJ2): Add xml.$(O).
1916 (GLOBAL_SOURCES): Add xml.c.
1917 ($(BLD)/xml.$(O)): New dependency list.
1918
1919 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1920 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1921 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1922 [!WINDOWSNT]: New macros.
1923 (init_libxml2_functions, libxml2_loaded_p): New functions.
1924 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1925 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1926 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1927 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1928 linked in).
1929 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1930 Call init_libxml2_functions before calling libxml2 functions.
1931 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1932
1933 * emacs.c: Don't include libxml/parser.h.
1934 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1935 xmlCleanupParser directly.
1936
1937 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1938
1939 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1940
1941 * indent.c (Fvertical_motion): If there is a display string at
1942 point, use it.vpos to compute how many lines to backtrack after
1943 move_it_to point. (Bug#11133)
1944
1945 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1946
1947 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1948 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1949 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1950 macros related to unification of CJK characters. For the details,
1951 see the discussion following the message here:
1952 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1953
1954 2012-04-04 Chong Yidong <cyd@gnu.org>
1955
1956 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1957
1958 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1959
1960 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1961 instead of alloca. (Bug#11138)
1962
1963 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1964
1965 * w32menu.c (is_simple_dialog): Properly check lisp types.
1966 (Bug#11141)
1967
1968 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1969
1970 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1971 position we get to after a call to move_it_to fails the
1972 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1973 only if we wind up in a string from display property. (Bug#11063)
1974
1975 * window.c (Fdelete_other_windows_internal): Invalidate the row
1976 and column information about mouse highlight, so that redisplay
1977 restores it after reallocating the glyph matrices. (Bug#7464)
1978
1979 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1980 string comes from a `display' text property, use the buffer
1981 position of that property as if we actually saw that position in
1982 the row's glyphs.
1983 (move_it_by_lines): Remove the assertion that
1984 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1985 violated when there's a before-string at the beginning of a line.
1986 (Bug#11063)
1987
1988 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1989
1990 * xdisp.c (append_space_for_newline): If the default face was
1991 remapped, use the remapped face for the appended newline.
1992 (extend_face_to_end_of_line): Use the remapped default face for
1993 extending the face to the end of the line.
1994 (display_line): Call extend_face_to_end_of_line when the default
1995 face was remapped. (Bug#11068)
1996
1997 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1998
1999 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2000
2001 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2002
2003 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2004
2005 2012-03-27 Glenn Morris <rgm@gnu.org>
2006
2007 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2008 Doc fixes.
2009
2010 2012-03-26 Kenichi Handa <handa@m17n.org>
2011
2012 * dispextern.h (struct glyph): Fix previous change. Change the
2013 bit length of glyphless.ch to 25 (Bug#11082).
2014
2015 2012-03-26 Chong Yidong <cyd@gnu.org>
2016
2017 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2018 (command_loop_1): Use it; inhibit selection update for
2019 handle-select-window too (Bug#8996).
2020
2021 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2022
2023 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2024
2025 2012-03-25 Kenichi Handa <handa@m17n.org>
2026
2027 * dispextern.h (struct glyph): Change the bit length of
2028 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2029
2030 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2031
2032 * s/ms-w32.h (tzname): Include time.h before redirecting to
2033 _tzname. Fixes the MSVC build. (Bug#9960)
2034
2035 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2036
2037 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2038 characters.
2039
2040 * xterm.c (XTread_socket): Only modify handling_signal if
2041 !SYNC_INPUT. (Bug#11080)
2042
2043 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2044
2045 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2046 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2047 when fetching a multibyte character consumes more bytes than
2048 CHAR_BYTES returns, due to unification of CJK characters in
2049 string_char. (Bug#11073)
2050
2051 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2052
2053 * process.c (wait_reading_process_output): Handle pty disconnect
2054 by refraining from sending oneself a SIGCHLD (bug#10933).
2055
2056 2012-03-22 Chong Yidong <cyd@gnu.org>
2057
2058 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2059
2060 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2061 Mark string as coming from a prefix property.
2062 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2063 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2064
2065 2012-03-21 Chong Yidong <cyd@gnu.org>
2066
2067 * xfaces.c (Vface_remapping_alist): Doc fix.
2068
2069 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2070
2071 * w32proc.c (Fw32_set_console_codepage)
2072 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2073 Doc fixes.
2074
2075 2012-03-20 Chong Yidong <cyd@gnu.org>
2076
2077 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2078 to reflect default non-nil value of redisplay-dont-pause.
2079
2080 2012-03-19 Kenichi Handa <handa@m17n.org>
2081
2082 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2083 it fit in a valid range (Bug#11003).
2084
2085 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2086
2087 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2088 that is not from display property, accept the row as a "cursor
2089 row" if one of the string's character has a non-nil `cursor'
2090 property. Fixes cursor positioning when there are newlines in
2091 overlay strings, e.g. in icomplete.el. (Bug#11035)
2092
2093 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2094
2095 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2096
2097 2012-03-12 Chong Yidong <cyd@gnu.org>
2098
2099 * eval.c (inhibit_lisp_code): Rename from
2100 inhibit_window_configuration_change_hook; move from window.c.
2101
2102 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2103 * window.c (run_window_configuration_change_hook)
2104 (syms_of_window): Callers changed.
2105
2106 2012-03-11 Chong Yidong <cyd@gnu.org>
2107
2108 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2109
2110 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2111
2112 2012-03-10 Chong Yidong <cyd@gnu.org>
2113
2114 * frame.c (other_visible_frames): Don't assume the selected frame
2115 is visible (Bug#10955).
2116
2117 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2118
2119 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2120
2121 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2122
2123 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2124 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2125 zero (Bug#10954).
2126
2127 2012-03-03 Glenn Morris <rgm@gnu.org>
2128
2129 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2130
2131 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2132
2133 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2134 position past the first glyph_row that ends at ZV. (Bug#10902)
2135 (redisplay_window, next_element_from_string): Fix typos in
2136 comments.
2137 (redisplay_window): Pass to move_it_vertically the margin in
2138 pixels, not in screen lines.
2139
2140 2012-03-02 Glenn Morris <rgm@gnu.org>
2141
2142 * buffer.c (buffer-list-update-hook): Doc fix.
2143
2144 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2145
2146 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2147 push_it before setting up the iterator for the first overlay
2148 string, even if we have an empty string loaded.
2149 (next_overlay_string): If there's an empty string on the iterator
2150 stack, pop the stack. (Bug#10903)
2151
2152 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2153
2154 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2155 Suggested by Stefan Monnier in
2156 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2157 * alloc.c (widen_to_Lisp_Object): New static function.
2158 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2159 and widening them to Lisp_Objects. This would work even if
2160 USE_LSB_TAG is defined and wide integers are used, which might
2161 happen in a future version of Emacs.
2162
2163 2012-02-25 Chong Yidong <cyd@gnu.org>
2164
2165 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2166 Doc fix.
2167
2168 * xselect.c (Fx_selection_exists_p): Doc fix.
2169 (x_clipboard_manager_save_all): Print an informative message
2170 before saving to clipboard manager.
2171
2172 2012-02-24 Chong Yidong <cyd@gnu.org>
2173
2174 * keyboard.c (process_special_events): Handle all X selection
2175 requests in kbd_buffer, not just the next one (Bug#8869).
2176
2177 2012-02-23 Chong Yidong <cyd@gnu.org>
2178
2179 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2180 call when setting menu-bar-lines and tool-bar-lines parameters.
2181 (unwind_create_frame_1): New helper function.
2182
2183 * window.c (inhibit_window_configuration_change_hook): New var.
2184 (run_window_configuration_change_hook): Obey it.
2185 (syms_of_window): Initialize it.
2186
2187 2012-02-22 Chong Yidong <cyd@gnu.org>
2188
2189 * xterm.c (x_draw_image_relief): Add missing type check for
2190 Vtool_bar_button_margin (Bug#10743).
2191
2192 2012-02-21 Chong Yidong <cyd@gnu.org>
2193
2194 * fileio.c (Vfile_name_handler_alist): Doc fix.
2195
2196 * buffer.c (Fget_file_buffer): Protect against invalid file
2197 handler return value.
2198
2199 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2202 when computing $valmask.
2203
2204 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2205 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2206 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2207 It's useless in that case, and it can cause problems on hosts
2208 that allocate halves of EMACS_INT values separately.
2209 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2210 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2211 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2212 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2213 it avoids undefined behavior on hosts where shifting right by more
2214 than the word width has undefined behavior.
2215
2216 2012-02-19 Chong Yidong <cyd@gnu.org>
2217
2218 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2219 (Funhandled_file_name_directory, Ffile_name_as_directory)
2220 (Fdirectory_file_name, Fexpand_file_name)
2221 (Fsubstitute_in_file_name): Protect against invalid file handler
2222 return values (Bug#10845).
2223
2224 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2225
2226 * .gdbinit (pitx): Fix incorrect references to fields of the
2227 iterator stack.
2228
2229 2012-02-17 Chong Yidong <cyd@gnu.org>
2230
2231 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2232
2233 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2234
2235 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2236 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2237
2238 2012-02-15 Chong Yidong <cyd@gnu.org>
2239
2240 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2241 marked as special. Also, starting docstrings with * is obsolete.
2242
2243 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2244
2245 * gnutls.c (emacs_gnutls_write): Fix last change.
2246
2247 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2248
2249 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2250 send_process.
2251
2252 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2253
2254 * keymap.c (Fsingle_key_description): Handle char ranges.
2255
2256 2012-02-12 Chong Yidong <cyd@gnu.org>
2257
2258 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2259 as that creates a dangerous corner case.
2260
2261 * window.c (Fdelete_window_internal): Invalidate the mouse
2262 highlight (Bug#9904).
2263
2264 2012-02-12 Glenn Morris <rgm@gnu.org>
2265
2266 * xselect.c (Fx_own_selection_internal)
2267 (Fx_get_selection_internal, Fx_disown_selection_internal)
2268 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2269 * nsselect.m (Fx_own_selection_internal)
2270 (Fx_disown_selection_internal, Fx_selection_exists_p)
2271 (Fx_selection_owner_p, Fx_get_selection_internal):
2272 Sync docs and argument specs with the xselect.c versions.
2273
2274 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2275
2276 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2277
2278 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2279
2280 * w32select.c (Fx_selection_exists_p): Sync doc string and
2281 argument list with xselect.c. (Bug#10783)
2282
2283 * w16select.c (Fx_selection_exists_p): Sync doc string and
2284 argument list with xselect.c. (Bug#10783)
2285
2286 2012-02-10 Glenn Morris <rgm@gnu.org>
2287
2288 * fns.c (Fsecure_hash): Doc fix.
2289
2290 2012-02-09 Kenichi Handa <handa@m17n.org>
2291
2292 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2293
2294 2012-02-07 Chong Yidong <cyd@gnu.org>
2295
2296 * buffer.c (Fbuffer_local_variables)
2297 (buffer_lisp_local_variables): Handle unbound vars correctly;
2298 don't let Qunbound leak into Lisp.
2299
2300 2012-02-07 Glenn Morris <rgm@gnu.org>
2301
2302 * image.c (Fimagemagick_types): Doc fix.
2303
2304 * image.c (imagemagick-render-type): Change it from a lisp object
2305 to an integer. Move the doc here from the lisp manual.
2306 Treat all values not equal to 0 the same.
2307
2308 2012-02-06 Chong Yidong <cyd@gnu.org>
2309
2310 * doc.c (store_function_docstring): Avoid applying docstring of
2311 alias to base function (Bug#2603).
2312
2313 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2314
2315 * .gdbinit (pp1, pv1): Remove redundant defines.
2316 (pr): Use pp.
2317
2318 2012-02-04 Chong Yidong <cyd@gnu.org>
2319
2320 * nsterm.m: Declare a global (Bug#10694).
2321
2322 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2323
2324 * w32.c (get_emacs_configuration_options):
2325 Include --enable-checking, if specified, in the return value.
2326
2327 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2328
2329 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2330 after rounding frame sizes. (Bug#9723)
2331
2332 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2333
2334 * keyboard.c (adjust_point_for_property): Don't position point
2335 before BEGV. (Bug#10696)
2336
2337 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2338
2339 Handle overflow when computing char display width (Bug#9496).
2340 * character.c (char_width): Return EMACS_INT, not int.
2341 (char_width, c_string_width): Check for overflow when
2342 computing the width; this is possible now that individual
2343 characters can have unbounded width. Problem introduced
2344 by merge from Emacs 23 on 2012-01-19.
2345
2346 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2347
2348 * dbusbind.c (Fdbus_register_method): Mention the return value
2349 :ignore in the docstring.
2350
2351 2012-02-02 Glenn Morris <rgm@gnu.org>
2352
2353 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2354
2355 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2356 Unconditionally set to t. (Bug#10673)
2357 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2358 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2359 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2360
2361 2012-02-02 Kenichi Handa <handa@m17n.org>
2362
2363 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2364 0, do not call append_composite_glyph.
2365
2366 2012-02-02 Kenichi Handa <handa@m17n.org>
2367
2368 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2369 NULL (Bug#6988).
2370 (x_produce_glyphs): If the component of a composition is a null
2371 string, set it->pixel_width to 1 to avoid zero-width glyph.
2372
2373 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2374
2375 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2376 first 2 arguments are identical. This makes inserting large
2377 output from a subprocess an order of magnitude faster on
2378 MS-Windows, where all sbrk'ed memory is always contiguous.
2379
2380 2012-01-31 Glenn Morris <rgm@gnu.org>
2381
2382 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2383 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2384 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2385
2386 2012-01-29 Glenn Morris <rgm@gnu.org>
2387
2388 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2389
2390 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2391
2392 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2393
2394 2012-01-28 Chong Yidong <cyd@gnu.org>
2395
2396 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2397
2398 2012-01-26 Chong Yidong <cyd@gnu.org>
2399
2400 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2401
2402 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2403 repeat counts (Bug#10507).
2404
2405 2012-01-26 Glenn Morris <rgm@gnu.org>
2406
2407 * lread.c (syms_of_lread): Doc fix.
2408
2409 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2410
2411 * coding.c (encode_designation_at_bol): Change return value to
2412 EMACS_INT.
2413
2414 2012-01-25 Chong Yidong <cyd@gnu.org>
2415
2416 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2417
2418 2012-01-21 Chong Yidong <cyd@gnu.org>
2419
2420 * floatfns.c (Fcopysign): Make the second argument non-optional,
2421 since nil is not allowed anyway.
2422
2423 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2424
2425 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2426 (send_process): Likewise.
2427
2428 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2429
2430 * window.c (save_window_save, Fcurrent_window_configuration)
2431 (Vwindow_persistent_parameters): Do not use Qstate.
2432 Rewrite doc-strings.
2433
2434 2012-01-19 Kenichi Handa <handa@m17n.org>
2435
2436 * character.c (char_width): New function.
2437 (Fchar_width, c_string_width, lisp_string_width):
2438 Use char_width (Bug#9496).
2439
2440 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2441
2442 * window.c (Vwindow_persistent_parameters): New variable.
2443 (Fset_window_configuration, save_window_save): Handle persistent
2444 window parameters.
2445
2446 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2447
2448 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2449 thrashing the stack of the thread. (Bug#9087)
2450
2451 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2454
2455 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2456
2457 * xdisp.c (rows_from_pos_range): Handle the case where the
2458 highlight ends on a newline. (Bug#10464)
2459 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2460 he end column for display of highlight that ends on a newline
2461 before a R2L line.
2462
2463 2012-01-11 Glenn Morris <rgm@gnu.org>
2464
2465 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2466 from load-path also when installation-directory is nil. (Bug#10208)
2467
2468 2012-01-10 Glenn Morris <rgm@gnu.org>
2469
2470 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2471
2472 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2473 Update template values to be closer to their typical values these days.
2474
2475 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2476
2477 * xdisp.c (rows_from_pos_range): Accept additional argument
2478 DISP_STRING, and accept any glyph in a row whose object is that
2479 string as eligible for mouse highlight. Fixes mouse highlight of
2480 display strings from overlays. (Bug#10464)
2481
2482 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 emacs: fix an auto-save permissions race condition (Bug#10400)
2485 * fileio.c (auto_saving_dir_umask): New static var.
2486 (Fmake_directory_internal): Use it.
2487 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2488 creating the directory. The old code temporarily assigns
2489 too-generous permissions to the directory.
2490 (do_auto_save_eh): Clear it.
2491 (Fdo_auto_save): Catch all errors, not just file errors, so
2492 that the var is always cleared.
2493
2494 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2495
2496 * search.c (scan_buffer): Pass character positions to
2497 know_region_cache, not byte positions. (Bug#6540)
2498
2499 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2500
2501 * w32.c (sys_rename): Report EXDEV when rename of a directory
2502 fails because the target is on another logical disk. (Bug#10284)
2503
2504 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2505
2506 * xterm.c (x_embed_request_focus): New function.
2507
2508 * xterm.h: Add prototype.
2509
2510 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2511
2512 2012-01-05 Glenn Morris <rgm@gnu.org>
2513
2514 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2515
2516 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2517
2518 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2519 Load gnutls_transport_set_lowat only if GnuTLS version is below
2520 2.11.1.
2521 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2522 GnuTLS versions below 2.11.1.
2523
2524 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2525
2526 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2527 to the doc string advising against its use for altering the way
2528 windows are scrolled.
2529
2530 2011-12-28 Kenichi Handa <handa@m17n.org>
2531
2532 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2533 coding-system ASCII compatible only when it does not produce BOM
2534 on encoding (Bug#10383).
2535
2536 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2537
2538 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2539 can scroll.
2540 (create_and_show_popup_menu): Always use menu_position_func for
2541 Gtk3 (Bug#10361).
2542
2543 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2544
2545 * callint.c (Fcall_interactively): Don't truncate prompt string.
2546
2547 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2548
2549 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2550 property that ends at ZV, so that the bidi iteration could be
2551 resumed from there (after widening). (Bug#10360)
2552
2553 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2554
2555 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2556
2557 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2558
2559 * nsterm.m (x_free_frame_resources):
2560 Release f->output_data.ns->miniimage.
2561 (ns_index_color): Fix indentation. Do not retain
2562 color_table->colors[i].
2563
2564 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2565 before returning.
2566
2567 * nsfns.m (x_set_background_color): Assign return value from
2568 ns_index_color to face-background instead of NSColor*.
2569 (ns_implicitly_set_icon_type): Fix indentation.
2570 Change assignment in for loop to comparison.
2571
2572 * emacs.c (ns_pool): New variable.
2573 (main): Assign ns_pool.
2574 (Fkill_emacs): Call ns_release_autorelease_pool.
2575
2576 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2577 autorelease fdesc, release fdAttrs and tdict.
2578 (ns_get_covering_families): Release charset.
2579 (ns_findfonts): Release NSFontDescriptor created with new.
2580 (ns_uni_to_glyphs): Fix indentation.
2581 (setString): Release attrStr before assigning new value.
2582
2583 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2584
2585 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2586 and NS_IMPL_COCOA.
2587 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2588 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2589
2590 2011-12-18 David Reitter <reitter@cmu.edu>
2591
2592 * nsterm.m (ns_term_init): Subscribe for notifications
2593 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2594 to method trackingNotification in EmacsMenu.
2595
2596 * nsmenu.m (trackingMenu): New variable.
2597 (trackingNotification): New method (from Aquamacs).
2598 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2599 from Aquamacs (Bug#7030).
2600
2601 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2602
2603 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2604 (symbol_to_nsstring): Fix indentation.
2605 (ns_symbol_to_pb): New function.
2606 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2607 (Fns_rotate_cut_buffers_internal): Remove.
2608 (Fns_store_selection_internal): Rename from
2609 Fns_store_cut_buffer_internal.
2610 (ns_get_foreign_selection, Fx_own_selection_internal)
2611 (Fx_disown_selection_internal, Fx_selection_exists_p)
2612 (Fns_get_selection_internal, Fns_store_selection_internal):
2613 Use ns_symbol_to_pb and check if return value is nil.
2614 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2615 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2616 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2617 renamed to Sns_store_selection_internal.
2618 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2619 and remove this function.
2620 (ns_handle_selection_clear): Remove, never used.
2621 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2622 here.
2623
2624 2011-12-17 Ken Brown <kbrown@cornell.edu>
2625
2626 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2627 GID is unknown (Bug#10257).
2628
2629 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2630
2631 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2632 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2633 which caused a build failure on GNU/Linux IA-64. This problem was
2634 introduced by my 2011-10-07 patch.
2635
2636 2011-12-15 Juri Linkov <juri@jurta.org>
2637
2638 * image.c (imagemagick_error): New function. (Bug#10112)
2639 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2640 Use `imagemagick_error' where ImageMagick functions return
2641 `MagickFalse'.
2642 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2643 proper order.
2644
2645 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2646
2647 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2648 fill background (Bug#8992).
2649
2650 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2651
2652 * window.c (Vwindow_combination_resize)
2653 (Vwindow_combination_limit): Use t instead of non-nil in
2654 doc-strings.
2655 (Vrecenter_redisplay): Add first sentence of doc-string on
2656 separate line.
2657 (Frecenter): Fix doc-string typo.
2658
2659 2011-12-11 Kenichi Handa <handa@m17n.org>
2660
2661 * coding.c (Funencodable_char_position): Pay attention to the
2662 buffer text relocation (Bug#9389).
2663
2664 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2665
2666 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2667 gtk_init (Bug#10100).
2668
2669 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2670
2671 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2672 IT->string is nil. (Bug#10263)
2673
2674 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2675
2676 * nsterm.h (x_free_frame_resources): Declare.
2677
2678 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2679 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2680
2681 * nsterm.h (ns_get_defaults_value): Declare.
2682
2683 * nsterm.m (ns_default): Call ns_get_defaults_value.
2684
2685 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2686
2687 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2688 (Bug#10170)
2689
2690 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2691
2692 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2693 that where the value of an _OBJC_* symbol points to is in the .bss
2694 section (Bug#10240).
2695
2696 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2697
2698 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2699 after the loop to call ccl_driver at least once (Bug#8619).
2700
2701 2011-12-08 Kenichi Handa <handa@m17n.org>
2702
2703 * ftfont.c (get_adstyle_property): Fix previous change
2704 (Bug#10233).
2705
2706 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2707
2708 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2709 dirs from the default value of EMACSLOADPATH (bug#10208).
2710
2711 2011-12-07 Glenn Morris <rgm@gnu.org>
2712
2713 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2714 installation and source directories as well. (Bug#10208)
2715
2716 2011-12-06 Chong Yidong <cyd@gnu.org>
2717
2718 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2719
2720 2011-12-06 Glenn Morris <rgm@gnu.org>
2721
2722 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2723 as an error, not just -1. (Bug#10217)
2724
2725 2011-12-05 Chong Yidong <cyd@gnu.org>
2726
2727 * keyboard.c (process_special_events): New function.
2728 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2729
2730 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2731
2732 * coding.c (encode_designation_at_bol): Don't use uninitialized
2733 local variable (Bug#9318).
2734
2735 2011-12-05 Kenichi Handa <handa@m17n.org>
2736
2737 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2738 return Qnil (Bug#8046, Bug#10193).
2739
2740 2011-12-05 Kenichi Handa <handa@m17n.org>
2741
2742 * coding.c (encode_designation_at_bol): New args charbuf_end and
2743 dst. Return the number of produced bytes. Callers changed.
2744 (coding_set_source): Return how many bytes coding->source was
2745 relocated.
2746 (coding_set_destination): Return how many bytes
2747 coding->destination was relocated.
2748 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2749 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2750
2751 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2752
2753 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2754 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2755 macro (Bug#9318).
2756
2757 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2758
2759 The following changes are to fix Bug#9318.
2760
2761 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2762 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2763 (encode_coding_iso_2022, encode_coding_sjis)
2764 (encode_coding_big5, encode_coding_charset): Use the above macros.
2765
2766 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2767
2768 * lisp.h (process_quit_flag): Fix external declaration.
2769
2770 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2771
2772 Don't macro-inline non-performance-critical code.
2773 * eval.c (process_quit_flag): New function.
2774 * lisp.h (QUIT): Use it.
2775
2776 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2777
2778 * nsfns.m (get_geometry_from_preferences): New function.
2779 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2780
2781 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2782
2783 * emacs.c (Qkill_emacs): Define.
2784 (syms_of_emacs): Initialize it.
2785 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2786 Qquit_flag to `kill-emacs' instead.
2787 (quit_throw_to_read_char): Add parameter `from_signal'.
2788 All callers changed. Call Fkill_emacs if requested and safe.
2789 * lisp.h (QUIT): Call Fkill_emacs if requested.
2790
2791 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2792
2793 * widget.c (update_wm_hints): Return if wmshell is null.
2794 (widget_update_wm_size_hints): New function.
2795
2796 * widget.h (widget_update_wm_size_hints): Declare.
2797
2798 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2799 widget_update_wm_size_hints (Bug#10104).
2800
2801 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2802
2803 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2804 before a newline, prepare the bidi iterator for consuming the
2805 newline, and keep the current paragraph direction. (Bug#10183)
2806 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2807
2808 2011-12-02 Juri Linkov <juri@jurta.org>
2809
2810 * search.c (Fword_search_regexp): New Lisp function created from
2811 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2812 (Fword_search_backward, Fword_search_forward)
2813 (Fword_search_backward_lax, Fword_search_forward_lax):
2814 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2815 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2816
2817 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2818
2819 * fileio.c (Finsert_file_contents): Move after-change-function call
2820 to before the "handled:" label, since all "goto handled" appear in
2821 cases where the *-change-functions have already been properly called
2822 (bug#10117).
2823
2824 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2825
2826 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2827 waiting for input. (Bug#10169)
2828
2829 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2830
2831 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2832 verifies glyph row's hash code--we have just reallocated the
2833 glyphs, so their contents can be complete garbage. (Bug#10164)
2834
2835 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2836
2837 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2838
2839 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2840
2841 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2842 attributes are tested _before_ calling verify_row_hash, to protect
2843 against GCC re-ordering of the tests. (Bug#10164)
2844
2845 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2846
2847 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2848
2849 * xterm.c (handle_one_xevent): Only set async_visible and friends
2850 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2851 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2852 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2853
2854 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2855
2856 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2857 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2858 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2859 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2860 All uses changed to use GCPRO1 etc.
2861 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2862 Revert to old implementation (i.e., before 2011-03-11).
2863
2864 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2865
2866 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2867 of scroll runs so as to avoid assigning disabled bogus rows and
2868 unnecessary graphics copy operations.
2869
2870 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2871
2872 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2873 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2874 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2875 (malloc, free, realloc, calloc): Redirect to e_* only when
2876 compiling Emacs.
2877
2878 * lisp.h (GCTYPEBITS): Move before first use.
2879 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2880 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2881 this macro definition.
2882
2883 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2884 _MSC_VER.
2885
2886 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2887
2888 * gtkutil.c (xg_create_frame_widgets):
2889 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2890 present with Gtk+ 2.0.
2891
2892 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * fileio.c (Finsert_file_contents): Undo previous change; see
2895 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2896
2897 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 Rename locals to avoid shadowing.
2900 * fileio.c (Finsert_file_contents):
2901 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2902 * process.c (wait_reading_process_output):
2903 Rename inner 'proc' to 'p' to avoid shadowing.
2904 Indent for consistency with usual Emacs style.
2905
2906 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2907
2908 * xdisp.c (redisplay_window): If cursor row is not fully visible
2909 after recentering, and scroll-conservatively is set to a large
2910 number, scroll window by a few more lines to make the cursor fully
2911 visible and out of scroll-margin. (Bug#10105)
2912 (start_display): Don't move to the next line if the display should
2913 start at a newline that is part of a display vector or an overlay
2914 string. (Bug#10119)
2915
2916 2011-11-24 Juri Linkov <juri@jurta.org>
2917
2918 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2919 after the `MagickPingImage' call. (Bug#10112)
2920
2921 2011-11-23 Chong Yidong <cyd@gnu.org>
2922
2923 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2924
2925 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2926
2927 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2928 making another buffer current. (Bug#10114)
2929
2930 2011-11-23 Glenn Morris <rgm@gnu.org>
2931
2932 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2933
2934 2011-11-23 Chong Yidong <cyd@gnu.org>
2935
2936 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2937 using it (Bug#5984).
2938
2939 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2940
2941 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2942 and header-lines, as they don't have one computed for them.
2943 (Bug#10098)
2944
2945 * .gdbinit (prow): Make displayed values more self-explaining.
2946 Add row's hash code.
2947
2948 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2949
2950 * process.c (wait_reading_process_output): Fix asynchrounous
2951 GnuTLS socket handling on some versions of the GnuTLS library.
2952 (wait_reading_process_output): Add comment and URL.
2953
2954 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2955
2956 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2957
2958 2011-11-21 Chong Yidong <cyd@gnu.org>
2959
2960 * window.c (Fnext_window, Fprevious_window): Doc fix.
2961
2962 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2963
2964 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2965
2966 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2967
2968 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2969
2970 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2971
2972 * window.c (Fset_window_combination_limit): Rename argument
2973 STATUS to LIMIT.
2974 (Vwindow_combination_limit): Remove "status" from doc-string.
2975
2976 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2977
2978 * m/ibms390.h: Remove.
2979 * m/ibms390x.h: Don't include "ibms390.h".
2980
2981 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2982
2983 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2984 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2985
2986 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2987
2988 * casetab.c (Fset_case_table):
2989 * charset.c (Fcharset_after): Fix typos.
2990
2991 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2992
2993 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2994 Otherwise, valgrind does not work on some platforms.
2995 Problem reported by Andreas Schwab in
2996 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2997 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2998 is set, removing the need for VIRT_ADDRESS_VARIES.
2999 (PURE_P): Use a more-efficient implementation that needs just one
3000 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3001 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3002 to 4 (xorl, subq, cmpq, setbe).
3003 * alloc.c (pure): Always extern now, since that's the
3004 VIRT_ADDR_VARIES behavior.
3005 (PURE_POINTER_P): Use a single comparison, not two, for
3006 consistency with the new puresize.h.
3007 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3008 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3009 Remove VIRT_ADDR_VARIES no longer needed.
3010
3011 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3012
3013 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3014 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3015 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3016 behave as if the cursor position were at the window margin.
3017
3018 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3019 and the cursor position is out of bounds, behave as if the cursor
3020 position were at the window margin. (Bug#10075)
3021
3022 2011-11-18 Chong Yidong <cyd@gnu.org>
3023
3024 * window.c (Fwindow_combination_limit): Make first argument
3025 non-optional, since it is meaningless for live windows like the
3026 selected window.
3027
3028 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3029
3030 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3031
3032 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3033
3034 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3035 (graft_intervals_into_buffer): Simplify.
3036
3037 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3038
3039 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3040 hash values of the two rows.
3041 (copy_row_except_pointers): Preserve the used[] arrays and the
3042 hash values of the two rows. (Bug#10035)
3043 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3044
3045 * xdisp.c (row_hash): New function, body extracted from
3046 compute_line_metrics.
3047 (compute_line_metrics): Call row_hash, instead of computing the
3048 hash code inline.
3049
3050 * dispnew.c (verify_row_hash): Call row_hash for computing the
3051 hash code of a row, instead of duplicating code from xdisp.c.
3052
3053 * dispextern.h (row_hash): Add prototype.
3054
3055 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3056
3057 * frame.c (delete_frame): Don't delete the terminal when the last
3058 X frame is closed if emacs is built with GTK toolkit.
3059
3060 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3063
3064 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3065
3066 * window.c (Vwindow_splits): Rename to
3067 Vwindow_combination_resize. Suggested by Juri Linkov.
3068 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3069 of Vwindow_splits.
3070
3071 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3072
3073 * nsfns.m (Fns_font_name):
3074 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3075
3076 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3077
3078 * window.h (window): Rename slot "nest" to "combination_limit".
3079 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3080 (Fset_window_nest): Rename to Fset_window_combination_limit.
3081 (Vwindow_nest): Rename to Vwindow_combination_limit.
3082 (recombine_windows, make_parent_window, make_window)
3083 (Fsplit_window_internal, saved_window)
3084 (Fset_window_configuration, save_window_save): Rename all
3085 occurrences of window_nest to window_combination_limit.
3086
3087 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3088
3089 * image.c (imagemagick_load_image): Fix typo.
3090
3091 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3092
3093 * xdisp.c (display_line): Move the call to
3094 highlight_trailing_whitespace before the call to
3095 compute_line_metrics, since the latter needs to see the final
3096 faces of all the glyphs to compute ROW's hash value.
3097 Fixes assertion violations in row_equal_p. (Bug#10035)
3098
3099 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3100
3101 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3102 just return (bug#10044).
3103
3104 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3105
3106 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3107 with user-defined heap size. Bump the default size of the temacs
3108 heap to 27MB, to avoid memory warning when running temacs.
3109 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3110
3111 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3112 current_matrix and desired_matrix. (Bug#9990)
3113 (verify_row_hash) [XASSERTS]: New function.
3114 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3115 that the hash value of glyph rows is correct.
3116
3117 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3118
3119 * window.h (window): Remove splits slot.
3120 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3121 (Fdelete_other_windows_internal, make_parent_window)
3122 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3123 (Fset_window_configuration, save_window_save): Don't deal with
3124 split status of windows.
3125 (saved_window): Remove splits slot.
3126 (Vwindow_splits): Rewrite doc-string.
3127
3128 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3129
3130 * xfns.c (unwind_create_frame):
3131 * nsfns.m (unwind_create_frame):
3132 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3133 Vframe_list (Bug#9999).
3134
3135 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3136
3137 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3138
3139 2011-11-11 Kenichi Handa <handa@m17n.org>
3140
3141 * callproc.c (Fcall_process): Set the member dst_multibyte of
3142 process_coding.
3143
3144 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3145
3146 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3147 avoid a crash (bug#9496).
3148
3149 2011-11-09 Chong Yidong <cyd@gnu.org>
3150
3151 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3152 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3153
3154 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3157
3158 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 Avoid some portability problems by eschewing 'extern inline' functions.
3161 The trivial performance wins aren't worth the portability hassles; see
3162 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3163 et seq.
3164 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3165 (window_box_width, window_box_left, window_box_left_offset)
3166 (window_box_right, window_box_right_offset): Undo previous change,
3167 by removing the "extern"s.
3168 * intervals.c (adjust_intervals_for_insertion)
3169 (adjust_intervals_for_deletion): Undo previous change,
3170 making these static again.
3171 (offset_intervals, temp_set_point_both, temp_set_point)
3172 (copy_intervals_to_string): No longer inline.
3173 * xdisp.c (window_text_bottom_y, window_box_width)
3174 (window_box_height, window_box_left_offset)
3175 (window_box_right_offset, window_box_left, window_box_right)
3176 (window_box): No longer inline.
3177
3178 2011-11-08 Chong Yidong <cyd@gnu.org>
3179
3180 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3181 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3182 Signal an error if not a live window.
3183 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3184 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3185
3186 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3187
3188 * lisp.h (syms_of_abbrev): Remove declaration.
3189 Reported by CHENG Gao <chenggao@royau.me>.
3190
3191 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3192
3193 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3194 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3195 of temacs in GUI mode.
3196
3197 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3198
3199 * window.h: Declare delete_all_child_windows instead of
3200 delete_all_subwindows.
3201 * window.c (Fwindow_nest, Fset_window_nest)
3202 (Fset_window_new_total, Fset_window_new_normal)
3203 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3204 (delete_all_subwindows): Rename to delete_all_child_windows.
3205 (Fdelete_other_windows_internal, Fset_window_configuration):
3206 Call delete_all_child_windows instead of delete_all_subwindows.
3207 * frame.c (delete_frame): Call delete_all_child_windows instead
3208 of delete_all_subwindows.
3209
3210 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3213 This is also needed for porting to any host where GC_MARK_STACK is
3214 not GC_MAKE_GCPROS_NOOPS.
3215 (which_symbols): Use it.
3216
3217 2011-11-07 Kenichi Handa <handa@m17n.org>
3218
3219 * coding.c (coding_set_destination): Check coding->src_pos only
3220 when coding->src_object is a buffer (bug#9910).
3221
3222 * process.c (send_process): Set the member src_multibyte of coding
3223 to 0 (bug#9911) when sending a unibyte text.
3224
3225 * callproc.c (Fcall_process): Set the member src_multibyte of
3226 process_coding to 0 (bug#9912).
3227
3228 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3229
3230 * xmenu.c (cleanup_widget_value_tree): New function.
3231 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3232 calling free_menubar_widget_value_tree directly (Bug#9830).
3233
3234 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3235
3236 Fix some portability problems with 'inline'.
3237 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3238 (window_box_width, window_box_left, window_box_left_offset)
3239 (window_box_right, window_box_right_offset): Declare extern.
3240 Otherwise, these inline functions do not conform to C99 and
3241 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3242 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3243 * intervals.c (adjust_intervals_for_insertion)
3244 (adjust_intervals_for_deletion): Now extern, because otherwise the
3245 extern inline functions 'offset_intervals' couldn't refer to it.
3246 (static_offset_intervals): Remove.
3247 (offset_intervals): Rewrite using the old contents of
3248 static_offset_intervals. The old version didn't conform to C99
3249 because an extern inline function contained a reference to an
3250 identifier with static linkage.
3251
3252 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3253
3254 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3255 GC.
3256
3257 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3258
3259 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3260 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3261 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3262 return Qleft_to_right.
3263
3264 2011-11-06 Chong Yidong <cyd@gnu.org>
3265
3266 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3267 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3268 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3269 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3270 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3271 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3272 (Fwindow_vscroll): Doc fix.
3273 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3274 argument, since it makes no sense to pass a live window and for
3275 consistency with window-child.
3276
3277 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3278
3279 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3280 support MSVC.
3281
3282 2011-11-05 Jason Rumney <jasonr@gnu.org>
3283
3284 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3285 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3286 fonts (Bug#6029).
3287 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3288 bitwise arithmetic preventing use of unicode-sip and non-truetype
3289 opentype fonts.
3290
3291 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3292
3293 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3294 "emacs"-only part.
3295
3296 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3297 initialization code to keep similarity to xfns.c after changes
3298 from 2011-11-05.
3299
3300 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3301
3302 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3303 (unwind_create_frame): New function (Bug#9943).
3304 (Fx_create_frame): Restructure code to be more similar to the one in
3305 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3306 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3307 Move terminal->reference_count++ just before making the frame official
3308 (Bug#9943).
3309
3310 * nsterm.m (x_free_frame_resources): New function.
3311 (x_destroy_window): Move code to x_free_frame_resources.
3312
3313 * xfns.c (unwind_create_frame): Fix comment.
3314 (Fx_create_frame, x_create_tip_frame):
3315 Move terminal->reference_count++ just before making the frame
3316 official. Move initialization of image_cache_refcount and
3317 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3318
3319 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3320
3321 Support MSVC build with newer versions of Visual Studio.
3322 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3323 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3324 nt/gmake.defs.
3325
3326 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3327 which are not supported by MSVC.
3328 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3329 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3330 bitfields.
3331 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3332 types in bitfields.
3333 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3334
3335 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3336
3337 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3338
3339 Support MSVC build with newer versions of Visual Studio.
3340 * w32.c: Don't include w32api.h for MSVC.
3341 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3342
3343 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3344 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3345 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3346 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3347 e_* cousins.
3348 (alloca) [_MSC_VER]: Define to _alloca.
3349
3350 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3351
3352 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3353
3354 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3355
3356 * xdisp.c (note_mouse_highlight): If either of
3357 previous/next-single-property-change returns nil, treat that as
3358 the beginning or the end of the buffer. (Bug#9955)
3359
3360 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3361
3362 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3363 label is not null (Bug#9951).
3364 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3365 may be NULL.
3366
3367 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3368
3369 * window.c (Fwindow_body_size): Mention in the doc string that the
3370 return value is in frame's canonical units. (Bug#9949)
3371
3372 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3373
3374 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3375
3376 * w32fns.c (unwind_create_frame): If needed, free the glyph
3377 matrices of the partially constructed frame. (Bug#9943)
3378 * xfns.c (unwind_create_frame): Likewise.
3379
3380 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3381
3382 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3383 Don't stop backward scan on the continuation glyph, even though
3384 its CHARPOS is positive.
3385 (mouse_face_from_buffer_pos, note_mouse_highlight):
3386 Rename cover_string to disp_string.
3387
3388 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3389
3390 * window.c (temp_output_buffer_show): Don't use
3391 Vtemp_buffer_show_specifiers.
3392 (Vtemp_buffer_show_specifiers): Remove unused variable.
3393
3394 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3395
3396 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3397 past the beginning of the current glyph matrix.
3398
3399 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3400
3401 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3402 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3403 HAVE_GTK3 (Bug#9869).
3404
3405 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3406 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3407
3408 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3409
3410 * xterm.c: Declare x_handle_net_wm_state to return int.
3411 (handle_one_xevent): Check if we are iconified but don't have
3412 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3413 (get_current_wm_state): Return non-zero if not hidden,
3414 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3415 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3416 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3417 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3418
3419 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3422 so that this new function doesn't get optimized away by a
3423 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3424
3425 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3426
3427 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3428
3429 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3430
3431 Fix the `xbytecode' command.
3432 * .gdbinit (xprintbytestr): New command.
3433 (xwhichsymbols): Rename from `which'; all callers changed.
3434 (xbytecode): Print the byte-code string as well.
3435
3436 2011-10-29 Kim Storm <storm@cua.dk>
3437
3438 * alloc.c (which_symbols): New function.
3439
3440 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3441
3442 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3443 line. (Bug#9903)
3444
3445 2011-10-29 Glenn Morris <rgm@gnu.org>
3446
3447 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3448 Not clear what it was for, and it causes various bugs. (Bug#9839)
3449
3450 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3451
3452 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3453 possible random value that matches one of those tested as
3454 condition to clear the mouse face.
3455
3456 2011-10-28 Chong Yidong <cyd@gnu.org>
3457
3458 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3459
3460 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3461
3462 * window.c (make_window): Initialize phys_cursor_on_p.
3463
3464 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3465
3466 * lisp.h (struct Lisp_Symbol): Update comments.
3467
3468 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3471
3472 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3473
3474 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3475 <oslsachem@gmail.com> for helping to debug this.
3476
3477 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3478 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3479 (g_b_init_get_glyph_outline_w): New static variables.
3480 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3481 (GetGlyphOutlineW_Proc): New typedefs.
3482 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3483 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3484 New functions.
3485 (w32font_open_internal, compute_metrics):
3486 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3487 instead of calling the "wide" APIs directly.
3488
3489 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3490
3491 * w32.h (syms_of_w32font): Add prototype.
3492
3493 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3494
3495 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3496 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3497 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3498 (Fmove_to_window_line): Doc fix.
3499
3500 2011-10-27 Chong Yidong <cyd@gnu.org>
3501
3502 * process.c (make_process): Set gnutls_state to NULL.
3503
3504 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3505 non-NULL, regardless of GNUTLS_INITSTAGE.
3506 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3507 an error. Set process slots as soon as we allocate them.
3508
3509 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3510
3511 2011-10-27 Chong Yidong <cyd@gnu.org>
3512
3513 * gnutls.c (emacs_gnutls_deinit): New function.
3514 Deallocate credentials structures as well as calling gnutls_deinit.
3515 (Fgnutls_deinit, Fgnutls_boot): Use it.
3516
3517 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3518 (deactivate_process): Call emacs_gnutls_deinit.
3519
3520 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3521
3522 * image.c (x_create_x_image_and_pixmap):
3523 * w32.c (sys_rename, w32_delayed_load):
3524 * w32font.c (fill_in_logfont):
3525 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3526
3527 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * w32fns.c (w32_default_color_map): New function,
3530 extracted from Fw32_default_color_map.
3531 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3532
3533 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3534
3535 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3536
3537 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3538
3539 * keyboard.c (test_undefined): New function (bug#9751).
3540 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3541
3542 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3543
3544 * sysdep.c (init_sys_modes): Fix the check for the controlling
3545 terminal (Bug#6649).
3546
3547 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3548
3549 * dispextern.h (struct bidi_it): New member next_en_type.
3550
3551 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3552 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3553 current character, check also for next_en_type being WEAK_EN.
3554 (bidi_resolve_weak): Don't enter the expensive loop if the current
3555 position is before next_en_pos. Record the bidi type of the first
3556 non-ET, non-BN character we find, in addition to its position.
3557 (bidi_level_of_next_char): Invalidate next_en_type when
3558 next_en_pos is over-stepped.
3559
3560 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3561
3562 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3563 * editfns.c: Rewrite current-time-zone so that it invokes
3564 the equivalent of (format-time-string "%Z") to get the time zone name.
3565 This fixes a bug when the time zone name contains characters that
3566 need converting from the system time locale to Emacs internal format.
3567 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3568 that patch fixed format-time-string to do the conversion, but
3569 I forgot to fix current-time-zone.
3570 (format_time_string): New function, containing most of
3571 what Fformat_time_string used to contain.
3572 (Fformat_time_string): Rewrite in terms of format_time_string.
3573 This doesn't change this function's behavior.
3574 (current-time-zone): Rewrite to use format_time_string.
3575 This fixes the bug reported by Michael Schierl in
3576 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3577 Jason Rumney's 2007-06-07 change worked around this bug, but
3578 didn't fix it.
3579 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3580
3581 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3582
3583 * xdisp.c (start_display): If the character at POS is displayed
3584 via a display vector, reset IT->current.dpvec_index to zero.
3585 (try_window_reusing_current_matrix): If a line ends in a display
3586 vector or the next line starts in a display vector, continue
3587 redrawing the window even though the character position of
3588 start_row was reached.
3589 (Bug#9771, part 2)
3590
3591 2011-10-18 Chong Yidong <cyd@gnu.org>
3592
3593 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3594 with nobreak-char-display too.
3595
3596 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3597
3598 Fix part 3 of bug#9771.
3599 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3600 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3601 non-neutral characters if the current character is a paragraph
3602 separator (a.k.a. Newline). This avoids running the same
3603 expensive loop twice, once when we consume the preceding newline
3604 and the other time when the line actually needs to be displayed.
3605 Avoid the loop when we see neutrals on the base embedding level
3606 following a character whose directionality is the same as the
3607 paragraph's. This avoids running the expensive loop when a line
3608 ends in a long sequence of neutrals, like control characters.
3609 Add assertion against STRONG_AL type. Slightly rearrange code
3610 that determines the type of a neutral given the first non-neutral
3611 that follows it.
3612 (bidi_level_of_next_char): Set next_en_pos to zero when
3613 invalidating its info.
3614
3615 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3616
3617 * xdisp.c (push_display_prop): Determine whether to record string
3618 or buffer position by IT->string, not by IT->method. Allow
3619 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3620 (move_it_vertically_backward): Don't look for character position
3621 immediately after the newline when in a continuation line.
3622 (Bug#9771, part 1)
3623
3624 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3625
3626 * window.c (coordinates_in_window): Rewrite and delabelize
3627 vertical border check. (Bug#5357) (Bug#9618)
3628
3629 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3630
3631 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3632 errors in XSetWindowBorder (bug#9310).
3633
3634 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3635
3636 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3637 avoid crash when xmalloc overrun checking is enabled.
3638
3639 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3640
3641 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3642 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3643 cursor motion with <left> and <right> arrow keys.
3644
3645 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3646 some callers set that themselves.
3647
3648 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3649
3650 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3651 display string and the previous row comes from the same string and
3652 is empty. (Bug#9739) (Bug#9738)
3653
3654 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3655
3656 * doc.c (get_doc_string): Encode file name (bug#9735).
3657
3658 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3659
3660 * bidi.c (bidi_level_of_next_char):
3661 * xdisp.c (get_visually_first_element): Remove old incorrect
3662 comments regarding the Unicode Line Separator character.
3663
3664 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3665
3666 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3667
3668 * alloc.c (Fgc_status): Do not access beyond zombies array
3669 boundary if nzombies > MAX_ZOMBIES.
3670 * alloc.c (dump_zombies): Add missing format specifier.
3671
3672 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3673
3674 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3675 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3676
3677 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3678 Some packages use them to denote characters with modifiers.
3679
3680 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3681
3682 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3683 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3684 matching a pp-number. Rename parameter var to var1.
3685
3686 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3687
3688 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3689
3690 2011-10-08 Glenn Morris <rgm@gnu.org>
3691
3692 * callint.c (Fcall_interactively): Give a more explicit error for the
3693 'c' case with a non-character input. (Bug#8479)
3694
3695 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3696
3697 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3698 lines.
3699 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3700 lines that are hscrolled on the left.
3701
3702 * dispnew.c (buffer_posn_from_coords): Account for a possible
3703 presence of header-line. (Bug#4426)
3704
3705 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3706
3707 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3708 Don't advertise functionality which we discourage or doesn't work.
3709
3710 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3713 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3714 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3715 this makes Emacs dump core during garbage collection on rare
3716 occasions. sizeof is obviously inferior to offsetof here, so
3717 stick with offsetof.
3718 (GC_POINTER_ALIGNMENT): New macro.
3719 (mark_memory): Omit 3rd (offset) arg; caller changed.
3720 Don't assume EMACS_INT alignment is the same as pointer alignment.
3721
3722 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3723
3724 * keyboard.c (read_key_sequence_remapped): New var.
3725 (read_key_sequence): Compute remapping in the right buffer.
3726 (command_loop_1): Use read_key_sequence's remapping directly.
3727
3728 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3729
3730 * dired.c (file_name_completion): Don't expand file name.
3731 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3732 before checking file name handler.
3733
3734 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3735 they've been requested explicitly (bug#9591).
3736
3737 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3738
3739 * keymap.c (Fsingle_key_description): Use make_specified_string
3740 instead of build_string to build string from push_key_description.
3741 (Bug#5193)
3742
3743 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3744
3745 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3746 This fixes a Y2038 bug on 64-bit hosts.
3747 * buffer.c (reset_buffer):
3748 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3749 (Fclear_buffer_auto_save_failure):
3750 Use 0, not -1, to represent an unset failure time, since time_t
3751 might not be signed.
3752
3753 Remove dependency on glibc malloc internals.
3754 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3755 Move back here from lisp.h, but with their new implementations.
3756 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3757 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3758 * charset.c (charset_table_init): New static var.
3759 (syms_of_charset): Use it instead of xmalloc. This removes a
3760 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3761 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3762 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3763 Move back to alloc.c.
3764 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3765 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3766
3767 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3768
3769 * nsterm.m (windowDidResize): Call x_set_window_size only when
3770 ns_in_resize is true. Otherwise set pixelwidth/height and
3771 call change_frame_size (Bug#9628).
3772
3773 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3774
3775 Port --enable-checking=all to Fedora 14 x86-64.
3776 * charset.c (syms_of_charset): Also account for glibc malloc's
3777 internal overhead when calculating the initial malloc maximum.
3778
3779 Port --enable-checking=all to Fedora 14 x86.
3780 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3781 Move to lisp.h.
3782 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3783 (overrun_check_realloc, overrun_check_free):
3784 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3785 That way, xmalloc returns a properly-aligned pointer even if
3786 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3787 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3788 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3789 into account when calculating the initial malloc maximum.
3790 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3791 Move here from alloc.c, so that charset.c can use it too.
3792 Properly align; the old code wasn't right for common 32-bit hosts
3793 when configured with --enable-checking=all.
3794 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3795 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3796
3797 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3798
3799 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3800 use EDOM.
3801
3802 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3803
3804 * xdisp.c (compute_display_string_end): If there's no display
3805 string at CHARPOS, return -1.
3806
3807 * bidi.c (bidi_fetch_char): When compute_display_string_end
3808 returns a negative value, treat the character as a normal
3809 character not covered by a display string. (Bug#9624)
3810
3811 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3812
3813 * lread.c (Fread_from_string): Fix typo in docstring.
3814
3815 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3816
3817 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3818 newline, reseat the iterator instead of bidi-iterating there one
3819 character at a time. (Bug#9610)
3820 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3821 TO_CHARPOS if the bidi iterator is at base embedding level.
3822
3823 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3824
3825 * lread.c (readevalloop): Use correct code for NBSP.
3826 (read1): Likewise. (Bug#9608)
3827
3828 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3829
3830 * dbusbind.c (Fdbus_register_signal): When service is not
3831 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3832
3833 2011-09-25 Glenn Morris <rgm@gnu.org>
3834
3835 * buffer.c (truncate-lines): Doc fix.
3836
3837 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3838
3839 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3840 (Fset_window_next_buffers): Doc fix.
3841
3842 2011-09-24 Glenn Morris <rgm@gnu.org>
3843
3844 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3845
3846 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3847
3848 Fix minor problems found by static checking.
3849 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3850 * indent.c (Fvertical_motion): Fix == vs = typo.
3851
3852 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3853
3854 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3855 Default value is now t. Doc fix.
3856
3857 * indent.c (Fvertical_motion): Compute and apply the overshoot
3858 logic when moving up, not only when moving down. Fix the
3859 confusing name and values of the it_overshoot_expected variable;
3860 logic changes accordingly. (Bug#9254) (Bug#9549)
3861
3862 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3863 CHARPOS is covered by a display string which includes newlines.
3864 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3865 is covered by a display string with embedded newlines.
3866
3867 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3868
3869 * dbusbind.c (Fdbus_register_signal): Add match rule to
3870 Vdbus_registered_objects_table. (Bug#9581)
3871 (Fdbus_register_method, Vdbus_registered_objects_table):
3872 Fix docstring.
3873
3874 2011-09-24 Jim Meyering <meyering@redhat.com>
3875
3876 do not ignore write error for any output size
3877 The previous change was incomplete.
3878 While it makes emacs --batch detect the vast majority of stdout
3879 write failures, errors were still ignored whenever the output size is
3880 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3881 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3882 && echo FAIL: ignored write error
3883 FAIL: ignored write error
3884 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3885 && echo FAIL: ignored write error
3886 FAIL: ignored write error
3887 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3888
3889 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3890
3891 * emacs.c (Fkill_emacs): In noninteractive mode exit
3892 non-successfully if a write error occurred on stdout. (Bug#9574)
3893
3894 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3895
3896 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3897 the xassert test.
3898
3899 * dispextern.h (struct it): Update the comment documenting what
3900 can it->OBJECT be.
3901
3902 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3903
3904 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3905 a display string, extend search for cursor position to end of row.
3906 (find_row_edges): If the row ends in a newline from a display
3907 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3908 Handle the case of a display string with multiple newlines.
3909 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3910 non-empty line. Fixes confusing cursor motion with arrow keys at
3911 the beginning of a line that starts with whitespace.
3912
3913 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3914
3915 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3916 (bug#9493).
3917
3918 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3919
3920 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3921 boolean (Bug#9154).
3922
3923 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3924
3925 * xdisp.c (display_line): Record maximum and minimum buffer
3926 positions even if no glyphs were produced (e.g., by a zero-width
3927 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3928 buffer positions that will be removed from the glyph row because
3929 they don't fit.
3930 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3931 column is beyond frame width: don't subtract 1 "pixel" when
3932 computing width of the stretch.
3933 (reseat_at_next_visible_line_start): Undo the change made on
3934 2011-09-17 that saved paragraph information and restored it after
3935 the call to `reseat'. (Bug#9545)
3936
3937 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3938
3939 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3940 and turn window cursor on if cleared (Bug#9415).
3941
3942 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3943
3944 * search.c (boyer_moore): Take unibyte characters from pattern
3945 literally. (Bug#9458)
3946
3947 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3948
3949 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3950
3951 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3952
3953 Fix minor problem found by static checking.
3954 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3955 initialized, to pacify gcc -Wuninitialized.
3956
3957 * fileio.c: Report proper errno when syscall falls.
3958 (Finsert_file_contents): Save and restore errno,
3959 so that report_file_error outputs the correct diagnostic.
3960 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3961
3962 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3963
3964 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3965
3966 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3967
3968 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3969 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3970
3971 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3972
3973 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3974 about the current paragraph and restore it after the call to reseat.
3975
3976 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3977 (bidi_find_paragraph_start): Search back for paragraph beginning
3978 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3979 (bidi_move_to_visually_next): Only trigger paragraph-related
3980 computations when the last character is a newline or at EOB, not
3981 just any NEUTRAL_B. (Bug#9470)
3982
3983 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3984 truncated lines if point is covered by a display string. (Bug#9524)
3985
3986 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3989 (cons_to_x_long): New function.
3990 (lisp_data_to_selection_data): Use it. Correct the test for
3991 short-versus-long data; it was negated. Break out of vector
3992 loop, for efficiency, when a long datum is discovered.
3993
3994 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3995
3996 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3997
3998 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3999
4000 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4001 GCC PR/17406) by declaring this function with external scope.
4002
4003 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4004
4005 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4006 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4007
4008 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4009
4010 * editfns.c (Fformat): Correctly handle text properties on "%%".
4011
4012 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4013
4014 * xterm.c (x_draw_composite_glyph_string_foreground):
4015 * w32term.c (x_draw_composite_glyph_string_foreground):
4016 * term.c (encode_terminal_code):
4017 * composite.c (composition_update_it, get_composition_id):
4018 * xdisp.c (get_next_display_element)
4019 (fill_composite_glyph_string): Add comments about special meaning
4020 of TAB characters in a composition.
4021
4022 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4023
4024 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4025 This occurs when processing a multibyte format.
4026 Problem reported by Wolfgang Jenker.
4027
4028 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4029
4030 * xdisp.c (try_cursor_movement): Only check for exact match if
4031 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4032
4033 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4034
4035 Remove unused external symbols.
4036 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4037 * xdisp.c (calc_pixel_width_or_height): Now static.
4038 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4039 * indent.c (check_display_width):
4040 * w32term.c: Fix comment to match code.
4041 * xterm.c, xterm.h (x_catching_errors): Remove.
4042
4043 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4044
4045 * xselect.c: Use signed conversions more consistently (Bug#9498).
4046 (selection_data_to_lisp_data): Assume incoming selection data are
4047 signed integers, not unsigned. This is to be consistent with
4048 outgoing selection data, which was modified to use signed integers
4049 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4050 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4051 expects long, not unsigned long.
4052
4053 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4054
4055 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4056 computation of loop end. Reported by Johan Bockgård
4057 <bojohan@gnu.org>.
4058
4059 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4060
4061 * frame.c (Fother_visible_frames_p): Function deleted.
4062
4063 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4064
4065 * indent.c (compute_motion): Process display vector front to back
4066 rather than the other way around. (Bug#2496)
4067
4068 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4069
4070 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4071
4072 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4073
4074 * minibuf.c (Fread_from_minibuffer): Doc fix.
4075
4076 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4077
4078 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4079 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4080
4081 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4082
4083 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4084 value for non-existent files.
4085
4086 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4087
4088 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4089 set its "size" to -1. This will set the modtime_size field of
4090 the corresponding buffer to -1, which is what
4091 verify-visited-file-modtime expects for files that do not exist.
4092 (Bug#9139)
4093
4094 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4095
4096 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4097 here ...
4098 * lisp.h: ... from here. push_key_description is no longer
4099 defined in keyboard.c, so its declaration should not be in
4100 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4101 logically belongs with push_key_description.
4102
4103 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4104
4105 * buffer.h: Include <sys/types.h> instead of <time.h>.
4106 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4107 Problem reported by Herbert J. Skuhra.
4108
4109 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4110
4111 * xml.c (parse_region): Make the parsing work for
4112 non-comment-starting XML files again (bug#9144).
4113
4114 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 * image.c (gif_load): Fix calculation of bottom and right corner.
4117 (Bug#9468)
4118
4119 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4120
4121 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4122 redisplay in small windows.
4123
4124 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4125
4126 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4127
4128 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4129
4130 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4131 Operate on live windows only.
4132
4133 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4134
4135 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4136
4137 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4138
4139 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4140 only under bidi iteration.
4141
4142 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4143
4144 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4145
4146 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4147
4148 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4149 Without this fix, the command to link temacs failed due to an
4150 undefined symbol __builtin_isnan. This is because
4151 /usr/include/iso/math_c99.h #defines isnan(x) to
4152 __builtin_isnan(x), but the bundled gcc, which identifies itself
4153 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4154 a __builtin_isnan.
4155 * floatfns.c (isnan): #undef, and then #define to a clone of
4156 what's in data.c.
4157 (Fisnan): Always define, since it's always available now.
4158 (syms_of_floatfns): Always define isnan at the Lisp level.
4159
4160 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4161
4162 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4163
4164 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4165
4166 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4167 The previous code assumed that file offsets (off_t values) fit in
4168 EMACS_INT variables, which is not true on typical 32-bit hosts.
4169 The code messed up by falsely reporting buffer overflow in cases
4170 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4171 when "big" contains more than 2**29 bytes, even though this
4172 inserts just one byte and does not overflow the buffer.
4173 (Finsert_file_contents): Store file offsets as off_t
4174 values, not as EMACS_INT values. Check for overflow when
4175 converting between EMACS_INT and off_t. When checking for
4176 buffer overflow or for overlap, take the offsets into account.
4177 Don't use EMACS_INT for small values where int suffices.
4178 When checking for overlap, fix a typo: ZV was used where
4179 ZV_BYTE was intended.
4180 (Fwrite_region): Don't assume off_t fits into 'long'.
4181 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4182
4183 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4184
4185 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4186
4187 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4188
4189 sprintf-related integer and memory overflow issues (Bug#9412).
4190
4191 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4192 (esprintf, exprintf, evxprintf): New functions.
4193 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4194 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4195 (modify_event_symbol): Do not assume that the length of
4196 name_alist_or_stem is safe to alloca and fits in int.
4197 (Fexecute_extended_command): Likewise for function name and binding.
4198 (Frecursion_depth): Wrap around reliably on integer overflow.
4199 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4200 since some callers pass EMACS_INT values.
4201 (Fsingle_key_description): Don't crash if symbol name contains more
4202 than MAX_ALLOCA bytes.
4203 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4204 (get_minibuffer): Arg is now EMACS_INT, not int.
4205 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4206 (esprintf, exprintf, evxprintf): New decls.
4207 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4208
4209 * dbusbind.c (signature_cat): New function.
4210 (xd_signature, Fdbus_register_signal):
4211 Do not overrun buffer; instead, report string overflow.
4212
4213 * dispnew.c (add_window_display_history): Don't overrun buffer.
4214 Truncate instead; this is OK since it's just a log.
4215
4216 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4217 even if the time zone offset is outlandishly large.
4218 Don't mishandle offset == INT_MIN.
4219
4220 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4221 when creating daemon; the previous buffer-overflow check was incorrect.
4222
4223 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4224 which has the guts of the old verror function.
4225
4226 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4227 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4228
4229 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4230 (font_unparse_xlfd): Don't blindly alloca long strings.
4231 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4232 fits in int, when using sprintf. Use single snprintf to count
4233 length of string rather than counting it via multiple sprintfs;
4234 that's simpler and more reliable.
4235 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4236 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4237 sprintf, in case result does not fit in int.
4238
4239 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4240 (fontset_from_font): Print it.
4241
4242 * frame.c (tty_frame_count): Now printmax_t, not int.
4243 (make_terminal_frame, set_term_frame_name): Print it.
4244 (x_report_frame_params): In X, window IDs are unsigned long,
4245 not signed long, so print them as unsigned.
4246 (validate_x_resource_name): Check for implausibly long names,
4247 and don't assume name length fits in 'int'.
4248 (x_get_resource_string): Don't blindly alloca invocation name;
4249 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4250 not fit in int.
4251
4252 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4253 (xg_check_special_colors, xg_set_geometry):
4254 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4255
4256 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4257 Use esprintf, not sprintf, in case result does not fit in int.
4258
4259 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4260 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4261 it as a large positive number.
4262 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4263 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4264
4265 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4266 in case result does not fit in int.
4267
4268 * print.c (float_to_string): Detect width overflow more reliably.
4269 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4270 buffer overrun. Don't assume list length fits in 'int'. Treat
4271 print length of 0 as 0, not as infinity; to be consistent with other
4272 uses of print length in this function. Don't overflow print length
4273 index. Don't assume hash table size fits in 'long', or that
4274 vectorlike size fits in 'unsigned long'.
4275
4276 * process.c (make_process): Use printmax_t, not int, to format
4277 process-name gensyms.
4278
4279 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4280
4281 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4282 to avoid potential buffer overrun.
4283
4284 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4285 if X resource line is longer than 512 bytes.
4286
4287 * xfns.c (x_window): Make sprintf buffer a bit bigger
4288 to avoid potential buffer overrun.
4289
4290 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4291
4292 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4293
4294 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4295
4296 Integer overflow fixes for scrolling, etc.
4297 Without these, Emacs silently mishandles large integers sometimes.
4298 For example, "C-u 4294967297 M-x recenter" was treated as if
4299 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4300
4301 * xdisp.c (try_window_id): Check Emacs fixnum range before
4302 converting to 'int'.
4303
4304 * window.c (window_scroll_line_based, Frecenter):
4305 Check that an Emacs fixnum is in range before assigning it to 'int'.
4306 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4307 values converted from Emacs fixnums.
4308 (Frecenter): Don't wrap around a line count if it is out of 'int'
4309 range; instead, treat it as an extreme value.
4310 (Fset_window_configuration, compare_window_configurations):
4311 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4312
4313 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4314 that can exceed INT_MAX. Check that EMACS_INT value is in range
4315 before assigning it to the (possibly-narrower) index.
4316 (match_limit): Don't assume that a fixnum can fit in 'int'.
4317
4318 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4319 exceed INT_MAX.
4320
4321 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4322 (Fvertical_motion): Don't wrap around LINES values that don't fit
4323 in 'int'. Instead, treat them as extreme values. This is good
4324 enough for windows, which can't have more than INT_MAX lines anyway.
4325
4326 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4327
4328 * Require libxml/parser.h to avoid compilation warning.
4329
4330 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4331
4332 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4333 since this reportedly can destroy thread storage.
4334
4335 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4336
4337 * syntax.c (find_defun_start): Update all cache variables if
4338 exiting early (Bug#9401).
4339
4340 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4341
4342 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4343
4344 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4345 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4346 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4347
4348 * term.c (tty_append_glyph): New function.
4349 (produce_stretch_glyph): Static function and its prototype deleted.
4350
4351 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4352 Add prototypes.
4353
4354 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4355
4356 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4357 when checking :margin (Bug#9390).
4358 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4359 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4360 so that the name doesn't mislead. All uses changed.
4361
4362 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4363
4364 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4365 set_tty_hooks.
4366
4367 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4368
4369 * xdisp.c (move_it_to): Don't bail out early when reaching
4370 position beyond to_charpos, if we are scanning backwards.
4371 (move_it_vertically_backward): When DY == 0, make sure we get to
4372 the first character in the line after the newline.
4373
4374 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4375
4376 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4377 (ccl_driver): Do not generate an out-of-range pointer.
4378 (Fccl_execute_on_string): Remove unnecessary check for
4379 integer overflow, noted by Stefan Monnier in
4380 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4381 Remove a FIXME that didn't need fixing.
4382 Simplify the newly-introduced buffer reallocation code.
4383
4384 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4385
4386 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4387
4388 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4389
4390 Integer and memory overflow issues (Bug#9196).
4391
4392 * doc.c (get_doc_string): Rework so that
4393 get_doc_string_buffer_size is the actual buffer size, rather than
4394 being 1 less than the actual buffer size; this makes xpalloc more
4395 convenient.
4396
4397 * image.c (x_allocate_bitmap_record, cache_image):
4398 * xselect.c (Fx_register_dnd_atom):
4399 Simplify previous changes by using xpalloc.
4400
4401 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4402 since either will do and ptrdiff_t is convenient with xpalloc.
4403
4404 * charset.c (charset_table_size)
4405 (struct charset_sort_data.priority): Now ptrdiff_t.
4406 (charset_compare): Don't overflow if priorities differ greatly.
4407 (Fsort_charsets): Don't assume list length fits in int.
4408 Check for size-calculation overflow when allocating sort data.
4409 (syms_of_charset): Allocate an initial charset table that is
4410 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4411
4412 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4413
4414 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4415 The actual value is always <= INT_MAX, and leaving it unsigned made
4416 overflow checking harder.
4417
4418 * dispextern.h (struct glyph_matrix.rows_allocated)
4419 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4420 with xpalloc. The values are still always <= INT_MAX.
4421
4422 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4423
4424 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4425 (SAFE_NALLOCA): New macro.
4426
4427 * region-cache.c (struct boundary.pos, find_cache_boundary)
4428 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4429 (set_cache_region, invalidate_region_cache)
4430 (revalidate_region_cache, know_region_cache, region_cache_forward)
4431 (region_cache_backward, pp_cache):
4432 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4433 so that ptrdiff_t * can be passed to xpalloc.
4434 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4435 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4436 (pp_cache): Don't assume cache_len fits in int.
4437 * region-cache.h: Adjust extern decls to match.
4438
4439 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4440 EMACS_INT, since either will do, for xpalloc.
4441
4442 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4443 (xnmalloc, xnrealloc, xpalloc): New functions.
4444
4445 * bidi.c (bidi_shelve_header_size): New constant.
4446 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4447 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4448
4449 * bidi.c (bidi_cache_shrink):
4450 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4451 (overlay_strings):
4452 Don't update size of array until after memory allocation succeeds,
4453 because xmalloc/xrealloc may not return.
4454 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4455 now that we have proper integer overflow checking.
4456 (record_overlay_string, overlay_strings): Catch overflows when
4457 calculating size of overlay_str_buf.
4458
4459 * callproc.c (Fcall_process): Check for size overflow when
4460 calculating size of args2.
4461 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4462 Normally we prefer signed values, but sticking with ptrdiff_t would
4463 require adding more-complicated checks.
4464
4465 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4466 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4467 Redo buffer-overflow calculations to avoid integer overflow.
4468 Add a FIXME comment where memory seems to be over-allocated.
4469
4470 * character.c (Fstring): Check for size-calculation overflow.
4471
4472 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4473 unnecessary integer overflow. Check for size overflow.
4474 (encode_coding_object): Don't update size until xmalloc succeeds.
4475
4476 * composite.c (get_composition_id): Check for overflow in glyph
4477 length calculations.
4478
4479 Integer and memory overflow fixes for display code.
4480 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4481 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4482 (scrolling_window): Check for overflow in size calculations.
4483 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4484 Don't assume glyph table len fits in int.
4485 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4486 (row_table_size): Now ptrdiff_t, not int.
4487 (scrolling_window): Avoid overflow in size calculations.
4488 Don't update size until allocation succeeds.
4489 * fns.c (concat): Check for overflow in size calculations.
4490 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4491 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4492 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4493
4494 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4495 (get_doc_string): Check for size calculation overflow.
4496 Don't update size until allocation succeeds.
4497 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4498 EMACS_INT, where ptrdiff_t will do.
4499 (Fsubstitute_command_keys): Check for string overflow.
4500
4501 * editfns.c (set_time_zone_rule): Don't assume environment length
4502 fits in int.
4503 (message_length): Now ptrdiff_t, not int.
4504 (Fmessage_box): Don't update size until allocation succeeds.
4505 Don't assume message length fits in int.
4506 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4507
4508 * emacs.c (main): Do not reallocate argv, since there is a null at
4509 the end that can be overwritten, and this way there's no need to
4510 worry about size-calculation overflow.
4511 (sort_args): Check for size-calculation overflow.
4512
4513 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4514 alloc succeeds.
4515 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4516
4517 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4518 (x_set_scroll_bar_width, x_figure_window_size):
4519 Check for integer overflow.
4520 (x_set_alpha): Do not assume XINT fits in int.
4521
4522 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4523 This is for the members text_lines, text_cols, total_lines, total_cols,
4524 where the system imposes an 'int' limit.
4525
4526 * fringe.c (Fdefine_fringe_bitmap):
4527 Don't update size until alloc works.
4528
4529 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4530 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4531
4532 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4533 Check for size-calculation overflow.
4534 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4535 do, as we prefer signed integers.
4536 (id_to_widget.max_size, id_to_widget.used)
4537 (xg_store_widget_in_map, xg_remove_widget_from_map)
4538 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4539 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4540 Use and return ptrdiff_t, not int.
4541 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4542 * gtkutil.h: Change prototypes to match the above.
4543
4544 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4545 are duplicate now that they've been promoted to lisp.h.
4546 (x_allocate_bitmap_record, x_alloc_image_color)
4547 (make_image_cache, cache_image, xpm_load):
4548 Don't update size until alloc is done.
4549 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4550 (x_detect_edges):
4551 Check for size calculation overflow.
4552 (ct_colors_allocated_max): New constant.
4553 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4554 overflow.
4555
4556 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4557 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4558 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4559 Use ptrdiff_t, not int, to count maps.
4560 (read_char_minibuf_menu_prompt): Check for overflow in size
4561 calculations. Don't update size until allocation succeeds.
4562 Redo calculations to avoid overflow.
4563 * keyboard.h: Change prototypes to match the above.
4564
4565 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4566 to count maps.
4567 (current_minor_maps): Check for size calculation overflow.
4568 * keymap.h: Change prototypes to match the above.
4569
4570 * lread.c (read1, init_obarray): Don't update size until alloc done.
4571
4572 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4573 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4574
4575 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4576 Now ptrdiff_t, not int.
4577 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4578 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4579
4580 * process.c (Fnetwork_interface_list): Check for overflow
4581 in size calculation.
4582
4583 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4584
4585 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4586 overflow. Don't bother calling xmalloc when xrealloc will do.
4587
4588 * search.c (Freplace_match): Check for size calculation overflow.
4589 (Fset_match_data): Don't assume list lengths fit in 'int'.
4590
4591 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4592 for command line length. Do not attempt to address one before the
4593 beginning of an array, as that's not portable.
4594
4595 * term.c (max_frame_lines): Remove; unused.
4596 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4597 not int.
4598 (encode_terminal_code, calculate_costs): Check for size
4599 calculation overflow.
4600 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4601 table lengths and related sizes. Don't update size until alloc
4602 done. Redo calculations to avoid overflow.
4603 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4604
4605 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4606 subtracting pointers.
4607 (gobble_line): Check for overflow more carefully. Don't update size
4608 until alloc done.
4609
4610 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4611 Don't update size until alloc done.
4612 Redo size calculations to avoid overflow.
4613 Check for size calculation overflow.
4614 (main) [DEBUG]: Fix typo in invoking tparam1.
4615
4616 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4617 Use ptrdiff_t, not int, for sizes.
4618 (store_mode_line_noprop_char): Don't update size until alloc done.
4619
4620 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4621 Use ptrdiff_t, not int, for sizes.
4622 (Finternal_make_lisp_face, cache_face):
4623 Check for size calculation overflow.
4624 (cache_face): Treat size calculation overflows as if they were
4625 memory exhaustion (the usual treatment), rather than aborting.
4626
4627 * xfns.c (x_encode_text, x_set_name_internal)
4628 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4629 sizes, since they can exceed INT_MAX in size. Check for size
4630 calculation overflow.
4631
4632 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4633 (xg_select): Check for size calculation overflow.
4634 Don't update size until alloc done.
4635
4636 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4637 as sprintf is limited to int lengths.
4638
4639 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4640 (X_LONG_MIN): New macros.
4641 Use them to make the following changes clearer.
4642 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4643 This change doesn't affect the value now, but it may help remind
4644 future maintainers not to raise the value too much later.
4645 (SELECTION_QUANTUM): Remove, replacing with ...
4646 (selection_quantum): ... new function, which avoids overflow.
4647 All uses changed.
4648 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4649 assumption that selection length fits in 'int'.
4650 (x_reply_selection_request, x_handle_selection_request)
4651 (x_get_window_property, receive_incremental_selection)
4652 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4653 (lisp_data_to_selection_data, clean_local_selection_data):
4654 Use ptrdiff_t, not int, to record length of selection.
4655 (x_reply_selection_request, x_get_window_property)
4656 (receive_incremental_selection, x_property_data_to_lisp):
4657 Redo calculations to avoid overflow.
4658 (x_reply_selection_request): When sending hint, ceiling it at
4659 X_LONG_MAX rather than relying on wraparound overflow to send
4660 something.
4661 (x_get_window_property, receive_incremental_selection)
4662 (lisp_data_to_selection_data, x_property_data_to_lisp):
4663 Check for size-calculation overflow.
4664 (x_get_window_property, receive_incremental_selection)
4665 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4666 Don't store size until memory allocation succeeds.
4667 (x_get_window_property): Plug memory leak on memory exhaustion.
4668 Don't double-block input; malloc is safe here. Don't assume 2**34
4669 - 4 fits in unsigned long. Add an xassert to check
4670 XGetWindowProperty overflow. Be more careful about overflow
4671 calculations, and distinguish size from memory overflow better.
4672 (receive_incremental_selection): When tracing, don't assume
4673 unsigned int is less than INT_MAX.
4674 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4675 harmful) conversions of unsigned short to int.
4676 (lisp_data_to_selection_data): Don't assume that integers
4677 in the range -65535 through -1 fit in an X unsigned short.
4678 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4679 result parameters unless successful. Rely on cons_to_unsigned
4680 to report problems with elements; the old code wasn't right anyway.
4681 (x_check_property_data): Check for int overflow; we cannot use
4682 a wider type due to X limits.
4683 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4684
4685 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4686
4687 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4688 (x_term_init): Check for size calculation overflow.
4689 (x_color_cells): Don't store size until memory allocation succeeds.
4690 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4691 Don't assume alloca size is less than MAX_ALLOCA.
4692 (x_term_init): Don't assume length fits in int (sprintf is limited
4693 to int size).
4694
4695 Use ptrdiff_t for composition IDs.
4696 * character.c (lisp_string_width):
4697 * composite.c (composition_table_size, n_compositions)
4698 (get_composition_id, composition_gstring_from_id):
4699 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4700 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4701 * window.c (Frecenter):
4702 Use ptrdiff_t, not int, for composition IDs.
4703 * composite.c (get_composition_id): Check for integer overflow.
4704 * composite.h: Adjust prototypes to match the above changes.
4705
4706 Use ptrdiff_t for hash table indexes.
4707 * category.c (hash_get_category_set):
4708 * ccl.c (ccl_driver):
4709 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4710 * coding.c (coding_system_charset_list, detect_coding_system):
4711 * coding.h (struct coding_system.id):
4712 * composite.c (get_composition_id, gstring_lookup_cache):
4713 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4714 * image.c (xpm_get_color_table_h):
4715 * lisp.h (hash_lookup, hash_put):
4716 * minibuf.c (Ftest_completion):
4717 Use ptrdiff_t for hash table indexes, not int (which is too
4718 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4719 32-bit --with-wide-int hosts).
4720
4721 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4722 Add a FIXME comment about memory leaks.
4723 (syms_of_charset): Don't assume xmalloc returns.
4724
4725 Don't assume that stated character widths fit in int.
4726 * character.c (Fchar_width, c_string_width, lisp_string_width):
4727 * character.h (CHAR_WIDTH):
4728 * indent.c (MULTIBYTE_BYTES_WIDTH):
4729 Use sanitize_char_width to avoid undefined and/or bad behavior
4730 with outlandish widths.
4731 * character.h (sanitize_tab_width): Rename from sanitize_width,
4732 now that we have two such functions. All uses changed.
4733 (sanitize_char_width): New inline function.
4734
4735 Don't assume that tab-width fits in int.
4736 * character.h (sanitize_width): New inline function.
4737 (SANE_TAB_WIDTH): New macro.
4738 (ASCII_CHAR_WIDTH): Use it.
4739 * indent.c (sane_tab_width): Remove. All uses replaced by
4740 SANE_TAB_WIDTH (current_buffer).
4741 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4742
4743 * fileio.c: Integer overflow issues with file modes.
4744 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4745
4746 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4747 Remove unreachable code.
4748 (read_hex, load_charset_map_from_file): Check for integer overflow.
4749
4750 * xterm.c: Don't go over XClientMessageEvent limit.
4751 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4752 (x_send_scroll_bar_event): Likewise. Check that the size does not
4753 exceed limits imposed by XClientMessageEvent, as well as the usual
4754 ptrdiff_t and size_t limits.
4755
4756 * keyboard.c: Overflow, signedness and related fixes.
4757 (make_lispy_movement): Use same integer type in forward decl
4758 that is used in the definition.
4759 (read_key_sequence, keyremap_step):
4760 Change bufsize argument back to int, undoing my 2011-03-30 change.
4761 We prefer signed types, and int is wide enough here.
4762 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4763 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4764 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4765 length, not size_t. Use ptrdiff_t for index, not int.
4766 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4767 possibility of integer overflow.
4768
4769 Overflow, signedness and related fixes for images.
4770
4771 * dispextern.h (struct it.stack[0].u.image.image_id)
4772 (struct_it.image_id, struct image.id, struct image_cache.size)
4773 (struct image_cache.used, struct image_cache.ref_count):
4774 * gtkutil.c (update_frame_tool_bar):
4775 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4776 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4777 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4778 * nsmenu.m (update_frame_tool_bar):
4779 * xdisp.c (calc_pixel_width_or_height):
4780 * xfns.c (image_cache_refcount):
4781 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4782 on typical 64-bit hosts.
4783
4784 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4785 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4786 Omit unnecessary casts to int.
4787 (parse_image_spec): Check that integers fall into 'int' range
4788 when the callers expect that.
4789 (image_ascent): Redo ascent calculation to avoid int overflow.
4790 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4791 (lookup_image): Remove unnecessary tests.
4792 (xbm_image_p): Locals are now of int, not EMACS_INT,
4793 since parse_image_check makes sure they fit into int.
4794 (png_load, gif_load, svg_load_image):
4795 Prefer int to unsigned where either will do.
4796 (tiff_handler): New function, combining the cores of the
4797 old tiff_error_handler and tiff_warning_handler.
4798 This function is rewritten to use vsnprintf and thereby avoid
4799 stack buffer overflows. It uses only the features of vsnprintf
4800 that are common to both POSIX and native Microsoft.
4801 (tiff_error_handler, tiff_warning_handler): Use it.
4802 (tiff_load, gif_load, imagemagick_load_image):
4803 Don't assume :index value fits in 'int'.
4804 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4805 (imagemagick_load_image): Check that crop parameters fit into
4806 the integer types that MagickCropImage accepts. Don't assume
4807 Vimagemagick_render_type has a nonnegative value. Don't assume
4808 size_t fits in 'long'.
4809 (gs_load): Use printmax_t to print the widest integers possible.
4810 Check for integer overflow when computing image height and width.
4811
4812 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4813
4814 * xdisp.c (redisplay_window): Don't force window start if point
4815 will be invisible in the resulting window. (Bug#9324)
4816
4817 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4818
4819 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4820 the display spec is of the form `(space ...)'.
4821 (handle_display_spec): Return the value returned by
4822 handle_single_display_spec, not just 1 or zero.
4823 (handle_single_display_spec): If the display spec is of the form
4824 `(space ...)', and specifies display in the text area, return 2
4825 rather than 1.
4826 (try_cursor_movement): Check for the need to scroll more
4827 accurately, and prefer exact match for point under bidi.
4828 Don't advance `row' beyond the last row of the window.
4829
4830 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4831 into disp_prop; all users changed.
4832
4833 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4834 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4835 for the text covered by the display property.
4836
4837 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4838
4839 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4840 Change return value to nil.
4841 (Frecord_buffer): Delete unused function.
4842
4843 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4844
4845 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4846 buffers, return left-to-right.
4847 (set_cursor_from_row): Consider candidate row a win if its glyph
4848 represents a newline and point is on that newline. Fixes cursor
4849 positioning on the newline at EOL of R2L text within L2R
4850 paragraph, and vice versa.
4851 (try_cursor_movement): Check continued rows, in addition to
4852 continuation rows. Fixes unwarranted scroll when point enters a
4853 continued line of R2L text within an L2R paragraph, or vice versa.
4854 (cursor_row_p): Consider the case of point being equal to
4855 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4856 from the end of a short line to the beginning of a continued line
4857 of R2L text within L2R paragraph.
4858 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4859 composed characters.
4860
4861 * bidi.c (bidi_check_type): Use xassert.
4862 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4863 members.
4864
4865 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4866
4867 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4868 a character.
4869
4870 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4871
4872 * nsfont.m (ns_otf_to_script): Fix typo.
4873
4874 2011-08-22 Kenichi Handa <handa@m17n.org>
4875
4876 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4877 extra slot even if the purpose is char-code-property-table.
4878
4879 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4880
4881 * xdisp.c (redisplay_window): When computing centering_position,
4882 account for the height of the header line. (Bug#8874)
4883
4884 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4885 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4886 candidate is selected by the mouse, and that candidate has a
4887 composed character under the mouse.
4888
4889 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4890 coordinates reported by pos-visible-in-window-p for a composed
4891 character in column zero.
4892
4893 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4894
4895 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4896
4897 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4898
4899 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4900 consider it a hit if to_charpos is anywhere in the range of the
4901 composed buffer positions.
4902
4903 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4904
4905 * image.c (gif_load): Don't assume that each subimage has the same
4906 dimensions as the base image. Handle disposal method that is
4907 "undefined" by the gif spec (Bug#9335).
4908
4909 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4910
4911 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4912 (Fcondition_case): Document `debug' symbol in error handler.
4913
4914 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4915
4916 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4917 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4918 from an Org mode buffer to a Speedbar frame.
4919
4920 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4921 a composition, take its buffer position from IT->cmp_it.charpos.
4922 Fixes cursor positioning at the beginning of a line that begins
4923 with a composed character.
4924
4925 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4926
4927 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4928 character bidirectional type, use STRONG_L instead. Fixes crashes
4929 in a buffer produced by `describe-categories'.
4930
4931 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4932 members before the level stack, so they would be saved and
4933 restored when copying iterator state. Fixes incorrect reordering
4934 around TABs covered by display properties.
4935
4936 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4937
4938 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4939
4940 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4941
4942 * eval.c (internal_condition_case, internal_condition_case_1)
4943 (internal_condition_case_2, internal_condition_case_n):
4944 Remove unnecessary aborts (Bug#9081).
4945
4946 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4947
4948 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4949 has no `load' handler, try opening the file locally. (Bug#9311)
4950
4951 2011-08-16 Ken Brown <kbrown@cornell.edu>
4952
4953 * gmalloc.c: Expand comment.
4954
4955 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4956
4957 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4958 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4959
4960 2011-08-16 Ken Brown <kbrown@cornell.edu>
4961
4962 Fix memory allocation problems in Cygwin build (Bug#9273).
4963
4964 * unexcw.c ( __malloc_initialized): Declare external variable.
4965 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4966
4967 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4968 New variables.
4969 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4970 dumped emacs.
4971 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4972 in the static heap.
4973 [CYGWIN] (special_realloc): New function.
4974 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4975 requests to realloc storage in the static heap.
4976
4977 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4978
4979 * bidi.c (bidi_initialize): Remove unused local.
4980
4981 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4982
4983 * bidimirror.h:
4984 * biditype.h: Remove file.
4985 * makefile.w32-in ($(BLD)/bidi.$(O)):
4986 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4987
4988 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4989
4990 * chartab.c: Improve commentary for the uniprop_table API.
4991
4992 * bidi.c (bidi_paragraph_init): Support zero value of
4993 bidi_ignore_explicit_marks_for_paragraph_level.
4994 (bidi_initialize): Use uniprop_table instead of including
4995 biditype.h and bidimirror.h.
4996
4997 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4998 coordinates of the iterator when restoring from ppos_it.
4999 (Bug#9296)
5000
5001 2011-08-14 Kenichi Handa <handa@m17n.org>
5002
5003 * process.c (create_process): Call setup_process_coding_systems
5004 after the pid of the process is set to -1 (Bug#8162).
5005
5006 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5007
5008 * xdisp.c (move_it_in_display_line_to): Don't invoke
5009 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5010 ppos_it. Fixes vertical cursor motion when line beginning is
5011 covered by an image. (Bug#9296)
5012
5013 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5014
5015 * nsterm.h (ns_run_ascript): Declare.
5016 (NSAPP_DATA2_RUNASSCRIPT): Define.
5017
5018 * nsfns.m (as_script, as_result, as_status): New static variables.
5019 (ns_run_ascript): New function.
5020 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5021 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5022 the event loop. Get status from as_status (Bug#7276).
5023
5024 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5025 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5026 the event loop (Bug#7276).
5027
5028 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5029
5030 * gnutls.c (QCgnutls_bootprop_priority)
5031 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5032 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5033 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5034 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5035 (QCgnutls_bootprop_verify_hostname_error)
5036 (QCgnutls_bootprop_callbacks_verify): Rename from
5037 Qgnutls_bootprop_..., all uses changed.
5038
5039 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5040 uses changed.
5041
5042 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5043
5044 * xfaces.c (Qframe_set_background_mode): Now static.
5045 * dispextern.h (Qframe_set_background_mode): Remove decl.
5046
5047 * process.c (Fnetwork_interface_info): Declare local only if needed.
5048
5049 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5050
5051 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5052 (Fnetwork_interface_list): Allocate in increments of bytes instead
5053 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5054 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5055 sockaddr.
5056 (struct ifflag_def): notrailers is smart on OSX.
5057 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5058 Get hardware address with getifaddrs if available.
5059
5060 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5061
5062 * xdisp.c (iterate_out_of_display_property): xassert that
5063 IT->position is set to within IT->object's boundaries. Break from
5064 the loop as soon as EOB is reached; avoids infloops in redisplay
5065 when IT->position is set up wrongly due to some bug.
5066 Set IT->current to match the bidi iterator unconditionally.
5067 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5068 entry. Force push_it to save on the stack the current
5069 buffer/string position, to be restored by pop_it. Fix flags in
5070 the iterator structure wrt the object coming from a display
5071 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5072 properties. (Bug#9284)
5073
5074 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5075
5076 * fontset.c (fontset_get_font_group): Add proper type checks.
5077 (Bug#9172)
5078
5079 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5080
5081 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5082 and LC_VERSION_MIN_MACOSX.
5083 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5084 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5085
5086 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5087
5088 * xdisp.c (forward_to_next_line_start): Allow to use the
5089 no-display-properties-and-no-overlays under bidi display.
5090 Set disp_pos in the bidi iterator to avoid searches for display
5091 properties and overlays.
5092
5093 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5094
5095 * editfns.c (Fset_time_zone_rule): Document relationship with the
5096 setenv function.
5097
5098 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5099 the font entity extracted from the cache (Bug#8109).
5100
5101 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5102
5103 * composite.c (autocmp_chars): Don't reset point. That is done by
5104 restore_point_unwind (Bug#5984).
5105
5106 2011-08-07 Juri Linkov <juri@jurta.org>
5107
5108 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5109 to show the arg `TIME' instead of `TIMEVAL'.
5110
5111 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5112
5113 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5114 display property strides EOL and includes a newline, as in
5115 longlines-mode. (Bug#9254)
5116 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5117 word-wrap under bidirectional display. (Bug#9224)
5118
5119 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5120 is non-zero, even if the data buffer is NULL. Fixes a crash in
5121 vertical-motion with longlines-mode. (Bug#9254)
5122
5123 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5124
5125 * bidi.c <bidi_cache_total_alloc>: Now static.
5126 (bidi_initialize): Initialize bidi_cache_total_alloc.
5127
5128 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5129 cache. (Bug#9221)
5130
5131 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5132 amount allocated this far in `bidi_cache_total_alloc'.
5133 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5134 non-zero, only free the data buffer without restoring the cache
5135 contents. All callers changed.
5136
5137 * dispextern.h (bidi_unshelve_cache): Update prototype.
5138
5139 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5140 (move_it_in_display_line, move_it_to)
5141 (move_it_vertically_backward, move_it_by_lines): Replace the call
5142 to xfree to an equivalent call to bidi_unshelve_cache.
5143 (move_it_in_display_line_to): Fix logic of returning
5144 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5145
5146 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5147
5148 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5149 came from a string character with a `cursor' property. (Bug#9229)
5150
5151 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5152
5153 * Makefile.in (LIB_PTHREAD): New variable.
5154 (LIBES): Add LIB_PTHREAD (Bug#9216).
5155
5156 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5157 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5158
5159 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5160
5161 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5162
5163 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5164
5165 * xterm.c (x_find_topmost_parent): New function.
5166 (x_set_frame_alpha): Find topmost parent window with
5167 x_find_topmost_parent and set the property there also (bug#9181).
5168 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5169
5170 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5171
5172 * callproc.c (Fcall_process): Avoid vfork clobbering
5173 the local vars buffer, coding_systems, current_dir.
5174
5175 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5176
5177 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5178
5179 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5180
5181 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5182 so that it is not optimized away.
5183
5184 * xdisp.c (compute_display_string_pos): Remove unused local.
5185
5186 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5187
5188 Fix slow cursor motion and scrolling in large buffers with
5189 selective display, like Org Mode buffers. (Bug#9218)
5190
5191 * dispextern.h (struct bidi_it): New member disp_prop_p.
5192
5193 * xdisp.c: Remove one-slot cache of display string positions.
5194 (compute_display_string_pos): Accept an additional argument
5195 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5196 for a display string or property. If found, set DISP_PROP_P
5197 non-zero.
5198
5199 * bidi.c (bidi_fetch_char): Accept an additional argument
5200 DISP_PROP_P, and pass it to compute_display_string_pos.
5201 Only handle text covered by a display string if DISP_PROP_P is returned
5202 non-zero. All callers of bidi_fetch_char changed.
5203
5204 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5205
5206 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5207
5208 2010-12-03 Don March <don@ohspite.net>
5209
5210 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5211 last character M-[char] is translated to ESC [char] (bug#7541).
5212
5213 2011-08-02 Kenichi Handa <handa@m17n.org>
5214
5215 * lisp.h (uniprop_table): Extern it.
5216
5217 * chartab.c (uniprop_table): Make it non-static.
5218
5219 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5220
5221 * xdisp.c (forward_to_next_line_start): Accept additional argument
5222 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5223 on the newline.
5224 (reseat_at_next_visible_line_start): Use the bidi iterator state
5225 returned by forward_to_next_line_start to restore the state of
5226 it->bidi_it after backing up to previous newline. (Bug#9212)
5227
5228 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5229
5230 * regex.c (re_comp): Protoize.
5231 (re_exec): Fix return type.
5232 (regexec): Fix type of `ret'. (Bug#9203)
5233
5234 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5235
5236 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5237 This is needed if max-image-size is a floating-point number.
5238
5239 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5240
5241 * print.c (print_object): Print empty symbol as ##.
5242
5243 * lread.c (read1): Read ## as empty symbol.
5244
5245 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5246
5247 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5248 setting frame foreground color (Bug#9175).
5249 (x_set_background_color): Likewise.
5250
5251 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5252 contents (Bug#9176).
5253 (EmacsTooltip -init): Remove bezels and add shadows to
5254 tooltip windows.
5255
5256 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5257 or scroll bar (Bug#8470).
5258
5259 * nsfont.m (nsfont_open): Remove assignment to voffset and
5260 unnecessary vars hshink, expand, hd, full_height, min_height.
5261 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5262
5263 * nsterm.h (nsfont_info): Remove voffset field.
5264
5265 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5266
5267 Implement strike-through and overline on NextStep (Bug#8863).
5268
5269 * nsfont.m (nsfont_open): Use underline position provided by font,
5270 instead of hard-coded value of 2.
5271 (nsfont_draw): Call ns_draw_text_decoration instead.
5272
5273 * nsterm.h: Add declaration for ns_draw_text_decoration.
5274
5275 * nsterm.m (ns_draw_text_decoration): New function for drawing
5276 underline, overline, and strike-through.
5277 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5278 ns_draw_text_decoration. Change treatment of cursor drawing to
5279 accommodate underlining, etc.
5280
5281 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5282
5283 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5284 default.
5285
5286 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5287
5288 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5289 Without this fix, if a signal arrives just after memory fills up,
5290 'malloc' might be invoked reentrantly.
5291
5292 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5293 In other words, assume that every image size is allowed, on non-X
5294 hosts. This assumption is probably wrong, but it lets Emacs compile.
5295
5296 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5297
5298 * regex.c (re_iswctype): Convert return values to boolean.
5299
5300 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5301
5302 * xdisp.c (compute_display_string_pos): Don't use cached display
5303 string position if the buffer had its restriction changed.
5304 (Bug#9184)
5305
5306 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5307
5308 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5309
5310 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5311
5312 Integer signedness and overflow and related fixes. (Bug#9079)
5313
5314 * bidi.c: Integer size and overflow fixes.
5315 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5316 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5317 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5318 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5319 (bidi_find_other_level_edge):
5320 Use ptrdiff_t instead of EMACS_INT where either will do.
5321 This works better on 32-bit hosts configured --with-wide-int.
5322 (bidi_cache_ensure_space): Check for size-calculation overflow.
5323 Use % rather than repeated addition, for better worst-case speed.
5324 Don't set bidi_cache_size until after xrealloc returns, because it
5325 might not return.
5326 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5327 (bidi_cache_ensure_space): Also check that the bidi cache size
5328 does not exceed that of the largest Lisp string or buffer. See Eli
5329 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5330
5331 * alloc.c (__malloc_size_t): Remove.
5332 All uses replaced by size_t. See Andreas Schwab's note
5333 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5334
5335 * image.c: Improve checking for integer overflow.
5336 (check_image_size): Assume that f is nonnull, since
5337 it is always nonnull in practice. This is one less thing to
5338 worry about when checking for integer overflow later.
5339 (x_check_image_size): New function, which checks for integer
5340 overflow issues inside X.
5341 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5342 This removes the need for a memory_full check.
5343 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5344 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5345 (xbm_read_bitmap_data): Change locals back to 'int', since
5346 their values must fit in 'int'.
5347 (xpm_load_image, png_load, tiff_load):
5348 Invoke x_create_x_image_and_pixmap earlier,
5349 to avoid much needless work if the image is too large.
5350 (tiff_load): Treat overly large images as if
5351 x_create_x_image_and_pixmap failed, not as malloc failures.
5352 (gs_load): Use x_check_image_size.
5353
5354 * gtkutil.c: Omit integer casts.
5355 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5356 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5357
5358 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5359
5360 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5361 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5362 would wrongly return t on a 64-bit host.
5363
5364 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5365 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5366 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5367 and therefore cause GCC to emit a bogus diagnostic in some cases.
5368
5369 * image.c: Integer signedness and overflow and related fixes.
5370 This is not an exhaustive set of fixes, but it's time to
5371 record what I've got.
5372 (lookup_pixel_color, check_image_size): Remove redundant decls.
5373 (check_image_size): Don't assume that arbitrary EMACS_INT values
5374 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5375 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5376 (tiff_load, imagemagick_load_image):
5377 Check for overflow in size calculations.
5378 (x_create_x_image_and_pixmap): Remove unnecessary test for
5379 xmalloc returning NULL; that can't happen.
5380 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5381 (xpm_color_bucket): Use better integer hashing function.
5382 (xpm_cache_color): Don't possibly over-allocate memory.
5383 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5384 (gif_memory_source):
5385 Use ptrdiff_t, not int or size_t, to record sizes.
5386 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5387 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5388 either works, as we prefer signed integers.
5389 (tiff_read_from_memory, tiff_write_from_memory):
5390 Return tsize_t, not size_t, since that's what the TIFF API wants.
5391 (tiff_read_from_memory): Don't fail simply because the read would
5392 go past EOF; instead, return a short read.
5393 (tiff_load): Omit no-longer-needed casts.
5394 (Fimagemagick_types): Don't assume size fits into 'int'.
5395
5396 Improve hashing quality when configured --with-wide-int.
5397 * fns.c (hash_string): New function, taken from sxhash_string.
5398 Do not discard information about ASCII character case; this
5399 discarding is no longer needed.
5400 (sxhash-string): Use it. Change sig to match it. Caller changed.
5401 * lisp.h: Declare it.
5402 * lread.c (hash_string): Remove, since we now use fns.c's version.
5403 The fns.c version returns a wider integer if --with-wide-int is
5404 specified, so this should help the quality of the hashing a bit.
5405
5406 * emacs.c: Integer overflow minor fix.
5407 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5408 Define only if GNU_LINUX.
5409 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5410
5411 * dispnew.c: Integer signedness and overflow fixes.
5412 Remove unnecessary forward decls, that were a maintenance hassle.
5413 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5414 All uses changed.
5415 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5416 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5417 (prepare_desired_row, line_draw_cost):
5418 Use int, not unsigned, where either works.
5419 (save_current_matrix, restore_current_matrix):
5420 Use ptrdiff_t, not size_t, where either works.
5421 (init_display): Check for overflow more accurately, and without
5422 relying on undefined behavior.
5423
5424 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5425 Remove, replacing with the new symbols in lisp.h. All uses changed.
5426 * fileio.c (make_temp_name):
5427 * filelock.c (lock_file_1, lock_file):
5428 * xdisp.c (message_dolog):
5429 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5430 Use pMd etc. instead.
5431 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5432 replacing the pWIDE etc. symbols removed from editfns.c.
5433
5434 * keyboard.h (num_input_events): Now uintmax_t.
5435 This is (very slightly) less likely to mess up due to wraparound.
5436 All uses changed.
5437
5438 * buffer.c: Integer signedness fixes.
5439 (alloc_buffer_text, enlarge_buffer_text):
5440 Use ptrdiff_t rather than size_t when either will do, as we prefer
5441 signed integers.
5442
5443 * alloc.c: Integer signedness and overflow fixes.
5444 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5445 (__malloc_size_t): Default to size_t, not to int.
5446 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5447 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5448 Prefer ptrdiff_t to size_t when either would do, as we prefer
5449 signed integers.
5450 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5451 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5452 Now const. Initialize with values that are in range even if char
5453 is signed.
5454 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5455 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5456 These functions do the right thing with sizes > 2**32.
5457 (check_depth): Now ptrdiff_t, not int.
5458 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5459 Adjust to new way of storing sizes. Check for size overflow bugs
5460 in rest of code.
5461 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5462 slightly wrong anyway, as it missed one instance of
5463 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5464 (refill_memory_reserve): Omit needless cast to size_t.
5465 (mark_object_loop_halt): Mark as externally visible.
5466
5467 * xselect.c: Integer signedness and overflow fixes.
5468 (Fx_register_dnd_atom, x_handle_dnd_message):
5469 Use ptrdiff_t, not size_t, since we prefer signed.
5470 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5471 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5472 x_dnd_atoms_size and x_dnd_atoms_length.
5473
5474 * doprnt.c: Prefer signed to unsigned when either works.
5475 * eval.c (verror):
5476 * doprnt.c (doprnt):
5477 * lisp.h (doprnt):
5478 * xdisp.c (vmessage):
5479 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5480 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5481 prefer signed arithmetic to avoid comparison confusion.
5482 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5483 but is a bit tricky.
5484
5485 Assume freestanding C89 headers, string.h, stdlib.h.
5486 * data.c, doprnt.c, floatfns.c, print.c:
5487 Include float.h unconditionally.
5488 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5489 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5490 * regex.c: Likewise for stddef.h, string.h.
5491 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5492 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5493 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5494 (STDC_HEADERS): Remove obsolete defines.
5495 * sysdep.c: Include limits.h unconditionally.
5496
5497 Assume support for memcmp, memcpy, memmove, memset.
5498 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5499 * regex.c (memcmp, memcpy):
5500 Remove; we assume C89 now.
5501
5502 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5503 (__malloc_safe_bcopy): Remove; no longer needed.
5504
5505 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5506 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5507 well either way, and we prefer signed to unsigned.
5508
5509 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5510
5511 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5512 closes the connection while we're reading (bug#9182).
5513
5514 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5515
5516 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5517 are specified (Bug#9168).
5518
5519 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5520
5521 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5522 Found by GCC static checking and --with-wide-int on a 32-bit host.
5523
5524 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5525
5526 * xdisp.c (compute_display_string_pos): Fix logic of caching
5527 previous display string position. Initialize cached_prev_pos to
5528 -1. Fixes slow-down at the beginning of a buffer.
5529
5530 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5531
5532 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5533 for attrs[LFACE_FONTSET_INDEX].
5534
5535 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5536
5537 * xml.c (parse_region): Remove unused local
5538 that was recently introduced.
5539
5540 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5541
5542 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5543 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5544
5545 * xdisp.c (move_it_in_display_line_to): Record the best matching
5546 position for TO_CHARPOS while scanning the line, and restore it on
5547 exit if none of the characters scanned was an exact match.
5548 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5549 when exact match is impossible due to invisible text, and the
5550 lines are truncated.
5551
5552 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5553
5554 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5555 for OSX >= 10.7.
5556
5557 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5558
5559 Fix a significant slow-down of cursor motion with C-n, C-p,
5560 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5561 auto-repeat under bidi redisplay in fontified buffers.
5562 * xdisp.c (compute_stop_pos_backwards): New function.
5563 (next_element_from_buffer): Call compute_stop_pos_backwards to
5564 find a suitable prev_stop when we find ourselves before
5565 base_level_stop.
5566 (reseat): Don't look for prev_stop, as that could mean a very long
5567 run.
5568 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5569 <cached_disp_overlay_modiff>: Cache for last found display string
5570 position.
5571 (compute_display_string_pos): Return the cached position if asked
5572 about the same buffer in the same area of character positions, and
5573 the buffer wasn't changed since the time the display string
5574 position was cached.
5575
5576 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5577
5578 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5579 is an integer, which is important for empty lines. (Bug#9149)
5580
5581 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5582
5583 * frame.c (Fmodify_frame_parameters): In tty case, update the
5584 default face if necessary (Bug#4238).
5585
5586 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5587
5588 * editfns.c (Fstring_to_char): No need to explain what a character
5589 is in the docstring (Bug#6576).
5590
5591 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5592
5593 * xml.c (parse_region): Make sure we always return a tree.
5594
5595 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5596
5597 * xml.c (parse_region): If a document contains only comments,
5598 return that, too.
5599
5600 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5601
5602 * xml.c (make_dom): Return comments, too.
5603
5604 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5605
5606 Port to OpenBSD.
5607 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5608 and the surrounding thread.
5609 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5610 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5611 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5612 timer goes off.
5613 * s/openbsd.h (BROKEN_SIGIO): Define.
5614 * unexelf.c (unexec) [__OpenBSD__]:
5615 Don't update the .mdebug section of the Alpha COFF symbol table.
5616
5617 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5618
5619 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5620 (bug#8460).
5621
5622 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5623
5624 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5625 This fixes some race conditions on the permissions of any newly
5626 created file.
5627
5628 * alloc.c (valid_pointer_p): Use pipe, not open.
5629 This fixes some permissions issues when debugging.
5630
5631 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5632 If fchown fails to set both uid and gid, try to set just gid,
5633 as that is sometimes allowed. Adjust the file's mode to eliminate
5634 setuid or setgid bits that are inappropriate if fchown fails.
5635
5636 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5637
5638 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5639 to compare Lisp_Objects.
5640 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5641 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5642 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5643
5644 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5645
5646 * lread.c (read_integer): Unread even EOF character.
5647 (read1): Likewise. Properly record start position of symbol.
5648
5649 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5650 symbol character follows.
5651
5652 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5653
5654 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5655 This works around a problem with the previous change to Fcopy_file.
5656 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5657 and without this change, GCC might complain about discarding
5658 fchown's return value.
5659
5660 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5661
5662 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5663
5664 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5665
5666 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5667
5668 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5669
5670 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5671 it's used from the C level.
5672
5673 * process.c: Use the same condition for POLL_FOR_INPUT in both
5674 keyboard.c and process.c (bug#1858).
5675
5676 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5677
5678 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5679 (Fgnutls_boot): Use it.
5680
5681 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5682
5683 * doc.c (Fsubstitute_command_keys): Revert last change.
5684
5685 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5686
5687 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5688 quotes the next character, and doesn't affect other longer
5689 sequences (bug#8935).
5690
5691 * lread.c (syms_of_lread): Clarify that is isn't only
5692 `eval-buffer' and `eval-defun' that's affected by
5693 `lexical-binding' (bug#8460).
5694
5695 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5696
5697 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5698 bidi redisplay when a line includes both an image and is truncated.
5699
5700 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5701
5702 Fix minor problems found by static checking.
5703 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5704 (elsz): Now a signed constant, not a size_t var. We prefer signed
5705 types to unsigned, to avoid integer comparison confusion. Without
5706 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5707 "cannot optimize loop, the loop counter may overflow", a symptom
5708 of the confusion.
5709 * indent.c (Fvertical_motion): Mark locals as initialized.
5710 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5711
5712 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5713
5714 * search.c (Fre_search_backward): Mention `case-fold-search' in
5715 all the re_search_* functions (bug#8138).
5716
5717 * keyboard.c (Fopen_dribble_file): Document when the file is
5718 closed (bug#8056).
5719
5720 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5721
5722 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5723 bidi_cache_idx.
5724
5725 Support bidi reordering of display and overlay strings.
5726 * xdisp.c (compute_display_string_pos)
5727 (compute_display_string_end): Accept additional argument STRING.
5728 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5729 (reseat_to_string): Initialize bidi_it->string.s and
5730 bidi_it->string.schars.
5731 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5732 NULL (avoids a crash in bidi_paragraph_init).
5733 Initialize itb.string.lstring.
5734 (init_iterator): Call bidi_init_it only of a valid
5735 buffer position was specified. Initialize paragraph_embedding to
5736 L2R.
5737 (reseat_to_string): Initialize the bidi iterator.
5738 (display_string): If we need to ignore text properties of
5739 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5740 original value of -1 will not work with bidi.)
5741 (compute_display_string_pos): First arg is now struct
5742 `text_pos *'; all callers changed. Support display properties on
5743 Lisp strings.
5744 (compute_display_string_end): Support display properties on Lisp
5745 strings.
5746 (init_iterator, reseat_1, reseat_to_string): Initialize the
5747 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5748 when iterating on a string not from display properties).
5749 (compute_display_string_pos, compute_display_string_end):
5750 Fix calculation of the object to scan. Fixes an error when using
5751 arrow keys.
5752 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5753 base_level_stop; instead, set base_level_stop to BEGV.
5754 Fixes crashes in vertical-motion.
5755 (next_element_from_buffer): Improve commentary for when
5756 the iterator is before prev_stop.
5757 (init_iterator): Initialize bidi_p from the default value of
5758 bidi-display-reordering, not from buffer-local value. Use the
5759 buffer-local value only if initializing for buffer iteration.
5760 (handle_invisible_prop): Support invisible properties on strings
5761 that are being bidi-reordered.
5762 (set_iterator_to_next): Support bidi reordering of C strings and
5763 Lisp strings.
5764 (next_element_from_string): Support bidi reordering of Lisp
5765 strings.
5766 (handle_stop_backwards): Support Lisp strings as well.
5767 (display_string): Support display of R2L glyph rows.
5768 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5769 (init_iterator): Don't initialize it->bidi_p for strings
5770 here.
5771 (reseat_to_string): Initialize it->bidi_p for strings here.
5772 (next_element_from_string, next_element_from_c_string)
5773 (next_element_from_buffer): Add xassert's for correspondence
5774 between IT's object being iterated and it->bidi_it.string
5775 structure.
5776 (face_before_or_after_it_pos): Support bidi iteration.
5777 (next_element_from_c_string): Handle the case of the first string
5778 character that is not the first one in the visual order.
5779 (get_visually_first_element): New function, refactored from common
5780 parts of next_element_from_buffer, next_element_from_string, and
5781 next_element_from_c_string.
5782 (tool_bar_lines_needed, redisplay_tool_bar)
5783 (display_menu_bar): Force left-to-right direction. Add a FIXME
5784 comment for making that be controlled by a user option.
5785 (push_it, pop_it): Save and restore the state of the
5786 bidi iterator. Save and restore the bidi_p flag.
5787 (pop_it): Iterate out of display property for string iteration as
5788 well.
5789 (iterate_out_of_display_property): Support iteration over strings.
5790 (handle_single_display_spec): Set up it->bidi_it for iteration
5791 over a display string, and call bidi_init_it.
5792 (handle_single_display_spec, next_overlay_string)
5793 (get_overlay_strings_1, push_display_prop): Set up the bidi
5794 iterator for displaying display or overlay strings.
5795 (forward_to_next_line_start): Don't use the shortcut if
5796 bidi-iterating.
5797 (back_to_previous_visible_line_start): If handle_display_prop
5798 pushed the iterator stack, restore the internal state of the bidi
5799 iterator by calling bidi_pop_it same number of times.
5800 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5801 and we are bidi-iterating, don't decrement the iterator position;
5802 instead, set the first_elt flag in the bidi iterator, to produce
5803 the same effect.
5804 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5805 (push_display_prop): xassert that we are iterating a buffer.
5806 (push_it, pop_it): Save and restore paragraph_embedding member.
5807 (handle_single_display_spec, next_overlay_string)
5808 (get_overlay_strings_1, reseat_1, reseat_to_string)
5809 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5810 correctly. Don't assume unibyte strings are not bidi-reordered.
5811 (compute_display_string_pos)
5812 (compute_display_string_end): Fix handling the case of C string.
5813 (push_it, pop_it): Save and restore from_disp_prop_p.
5814 (handle_single_display_spec, push_display_prop): Set the
5815 from_disp_prop_p flag.
5816 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5817 (pop_it): Call iterate_out_of_display_property only if we are
5818 popping after iteration over a string that came from a display
5819 property. Fix a typo in popping stretch info. Add an assertion
5820 for verifying that the iterator position is in sync with the bidi
5821 iterator.
5822 (handle_single_display_spec, get_overlay_strings_1)
5823 (push_display_prop): Fix initialization of paragraph direction for
5824 string when that of the parent object is not yet determined.
5825 (reseat_1): Call bidi_init_it to resync the bidi
5826 iterator with IT's position. (Bug#7616)
5827 (find_row_edges): If ROW->start.pos gives position
5828 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5829 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5830 Reset the from_disp_prop_p flag.
5831 (SAVE_IT, RESTORE_IT): New macros.
5832 (pos_visible_p, face_before_or_after_it_pos)
5833 (back_to_previous_visible_line_start)
5834 (move_it_in_display_line_to, move_it_in_display_line)
5835 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5836 (try_scrolling, redisplay_window, display_line): Use them when
5837 saving a temporary copy of the iterator and restoring it back.
5838 (back_to_previous_visible_line_start, reseat_1)
5839 (init_iterator): Empty the bidi cache "stack".
5840 (move_it_in_display_line_to): If iterator ended up at
5841 EOL, but we never saw any buffer positions smaller than
5842 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5843 motion in bidi-reordered lines.
5844 (move_it_in_display_line_to): Record prev_method and prev_pos
5845 immediately before the call to set_iterator_to_next. Fixes cursor
5846 motion in bidi-reordered lines with stretch glyphs and strings
5847 displayed in margins. (Bug#8133) (Bug#8867)
5848 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5849 TO_CHARPOS.
5850 (pos_visible_p): Support positions in bidi-reordered lines.
5851 Save and restore bidi cache.
5852
5853 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5854 (bidi_paragraph_info): Delete unused struct.
5855 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5856 (bidi_cache_start): New variable.
5857 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5858 to zero.
5859 (bidi_cache_fetch_state, bidi_cache_search)
5860 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5861 (bidi_cache_find, bidi_peek_at_next_level)
5862 (bidi_level_of_next_char, bidi_find_other_level_edge)
5863 (bidi_move_to_visually_next): Compare cache index with
5864 bidi_cache_start rather than with zero.
5865 (bidi_fetch_char): Accept new argument STRING; all callers
5866 changed. Support iteration over a string. Support strings with
5867 display properties. Support unibyte strings. Fix the type of
5868 `len' according to what STRING_CHAR_AND_LENGTH expects.
5869 (bidi_paragraph_init, bidi_resolve_explicit_1)
5870 (bidi_resolve_explicit, bidi_resolve_weak)
5871 (bidi_level_of_next_char, bidi_move_to_visually_next):
5872 Support iteration over a string.
5873 (bidi_set_sor_type, bidi_resolve_explicit_1)
5874 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5875 can now be zero (for strings); special values 0 and -1 were
5876 changed to -1 and -2, respectively.
5877 (bidi_char_at_pos): New function.
5878 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5879 Call it instead of FETCH_MULTIBYTE_CHAR.
5880 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5881 initialized to valid values.
5882 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5883 values.
5884 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5885 the test for valid cached positions. Fix the logic for looking up
5886 the sentinel state in the cache. GCPRO the Lisp string we are
5887 iterating.
5888 (bidi_push_it, bidi_pop_it): New functions.
5889 (bidi_initialize): Initialize the bidi cache start stack pointer.
5890 (bidi_cache_ensure_space): New function, refactored from part of
5891 bidi_cache_iterator_state. Don't assume the required size is just
5892 one BIDI_CACHE_CHUNK away.
5893 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5894 (bidi_count_bytes, bidi_char_at_pos): New functions.
5895 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5896 always valid if bidi_cache_idx is valid.
5897 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5898 is valid if it's going to be used.
5899 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5900 (bidi_cache_fetch_state, bidi_cache_search)
5901 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5902 (bidi_cache_iterator_state, bidi_cache_find)
5903 (bidi_find_other_level_edge, bidi_cache_start_stack):
5904 All variables related to cache indices are now EMACS_INT.
5905
5906 * dispextern.h (struct bidi_string_data): New structure.
5907 (struct bidi_it): New member `string'. Make flag members be 1-bit
5908 fields, and put them last in the struct.
5909 (compute_display_string_pos, compute_display_string_end):
5910 Update prototypes.
5911 (bidi_push_it, bidi_pop_it): Add prototypes.
5912 (struct iterator_stack_entry): New members bidi_p,
5913 paragraph_embedding, and from_disp_prop_p.
5914 (struct it): Member bidi_p is now a bit field 1 bit wide.
5915 (bidi_shelve_cache, bidi_unshelve_cache):
5916 Declare prototypes.
5917
5918 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5919 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5920 and vector-like objects.
5921
5922 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5923 cache around display iteration.
5924
5925 * window.c (Fwindow_end, window_scroll_pixel_based)
5926 (displayed_window_lines, Frecenter): Save and restore the bidi
5927 cache around display iteration.
5928
5929 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5930
5931 * editfns.c (Fdelete_region): Clarify the use of the named
5932 parameters (bug#6788).
5933
5934 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5935
5936 * indent.c (Fvertical_motion): Set and restore w->pointm when
5937 saving and restoring the window's buffer (Bug#9006).
5938
5939 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5940
5941 * editfns.c (Fstring_to_char): Clarify just what is returned
5942 (bug#6576). Text by Eli Zaretskii.
5943
5944 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5945
5946 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5947
5948 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5949
5950 * buffer.c (mmap_find): Fix a typo.
5951
5952 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5953
5954 Fix execution of x selection hooks.
5955 * xselect.c (Qx_lost_selection_functions)
5956 (Qx_sent_selection_functions): New vars.
5957 (syms_of_xselect): DEFSYM them.
5958 (x_handle_selection_request): Pass Qx_sent_selection_functions
5959 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5960 (x_handle_selection_clear,x_clear_frame_selections):
5961 Pass Qx_lost_selection_functions rather than
5962 Vx_lost_selection_functions to Frun_hook_with_args.
5963
5964 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5965
5966 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5967 The old code sometimes used this field without initializing it.
5968
5969 * alloc.c (gc_sweep): Don't read past end of array.
5970 In theory, the old code could also have corrupted Emacs internals,
5971 though it'd be very unlikely.
5972
5973 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5974
5975 * character.c (Fcharacterp): Don't advertise optional ignored
5976 argument. (Bug#4026)
5977
5978 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5979
5980 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5981 key" (bug#4257).
5982
5983 * window.c (Fset_window_start): Doc fix (bug#4199).
5984 (Fset_window_hscroll): Ditto.
5985
5986 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5987
5988 Fix minor new problems caught by GCC 4.6.1.
5989 * term.c (init_tty): Remove unused local.
5990 * xsettings.c (store_monospaced_changed): Define this function only
5991 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5992 not used otherwise.
5993
5994 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5995
5996 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5997
5998 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5999
6000 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6001 are the mini-buffer and the echo area (bug#3320).
6002
6003 * term.c (init_tty): Remove support for supdup, c10 and perq
6004 terminals, which are no longer supported (bug#1482).
6005
6006 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6007
6008 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6009
6010 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6011
6012 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6013 for non-popups (Bug#3642).
6014
6015 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6016
6017 * alloc.c (reset_malloc_hooks): Protoize.
6018 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6019 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6020 * cm.c (losecursor): Likewise.
6021 * data.c (fmod): Likewise.
6022 * dispnew.c (swap_glyphs_in_rows): Likewise.
6023 * emacs.c (memory_warning_signal): Likewise.
6024 * floatfns.c (float_error): Likewise.
6025 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6026 (otf_open, font_otf_capability, generate_otf_features)
6027 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6028 Likewise.
6029 * image.c (pbm_read_file): Likewise.
6030 * indent.c (string_display_width): Likewise.
6031 * intervals.c (check_for_interval, search_for_interval)
6032 (inc_interval_count, count_intervals, root_interval)
6033 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6034 * lread.c (defalias): Likewise.
6035 * ralloc.c (r_alloc_check): Likewise.
6036 * regex.c (set_image_of_range_1, set_image_of_range)
6037 (regex_grow_registers): Likewise.
6038 * sysdep.c (strerror): Likewise.
6039 * termcap.c (valid_filename_p, tprint, main): Likewise.
6040 * tparam.c (main): Likewise.
6041 * unexhp9k800.c (run_time_remap, save_data_space)
6042 (update_file_ptrs, read_header, write_header, calculate_checksum)
6043 (copy_file, copy_rest, display_header): Likewise.
6044 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6045 Likewise.
6046 * xdisp.c (check_it): Likewise.
6047 * xfaces.c (register_color, unregister_color, unregister_colors):
6048 Likewise.
6049 * xfns.c (print_fontset_result): Likewise.
6050 * xrdb.c (member, fatal, main): Likewise.
6051
6052 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6053
6054 Fix minor problems found by static checking (Bug#9031).
6055 * chartab.c (char_table_set_range, map_sub_char_table):
6056 Remove unused locals.
6057 (uniprop_table): Now static.
6058 * composite.c (_work_char): Remove unused static var.
6059
6060 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6061
6062 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6063
6064 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6065
6066 * gtkutil.c (qttip_cb): Remove code without function.
6067
6068 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6069
6070 * w32.c (pthread_sigmask): New stub.
6071
6072 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6073
6074 Use pthread_sigmask, not sigprocmask (Bug#9010).
6075 sigprocmask is portable only for single-threaded applications, and
6076 Emacs can be multi-threaded when it uses GTK.
6077 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6078 (LIBES): Use it.
6079 * callproc.c (Fcall_process):
6080 * process.c (create_process):
6081 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6082 Use pthread_sigmask, not sigprocmask.
6083
6084 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6085
6086 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6087 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6088 wrong (Bug#8591).
6089
6090 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6091
6092 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6093 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6094 (xg_hide_tooltip): Fix comment.
6095
6096 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6097 in registerServicesMenuSendTypes.
6098 (validRequestorForSendType): Don't check ns_return_types.
6099
6100 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6101 ns_return_type.
6102
6103 2011-07-08 Jason Rumney <jasonr@gnu.org>
6104
6105 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6106 SH_SHOW for hidden windows (Bug#5482).
6107
6108 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6109 frame struct members of non-existent frames (Bug#6284).
6110
6111 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6112
6113 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6114 variable firstTime not needed on OSX >= 10.6.
6115 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6116 >= 10.5. Use setKnobProportion, setDoubleValue.
6117
6118 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6119 (MAC_OS_X_VERSION_10_5): Define if not defined.
6120 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6121 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6122 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6123
6124 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6125 cString and lossyCString on OSX >= 10.4
6126
6127 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6128 sizeToFit on OSX >= 10.2.
6129
6130 * nsimage.m (allocInitFromFile): Don't use deprecated method
6131 bestRepresentationForDevice on OSX >= 10.6.
6132
6133 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6134 to avoid warning.
6135
6136 * emacs.c: Declare unexec_init_emacs_zone.
6137
6138 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6139
6140 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6141
6142 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6143 on svcsMenu (Bug#8842).
6144
6145 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6146 ns_return_types.
6147 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6148
6149 * nsterm.m (QUTF8_STRING): Declare.
6150 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6151 (validRequestorForSendType): Return type is (id).
6152 Change indexOfObjectIdenticalTo to indexOfObject.
6153 Check if we have local selection before returning self (Bug#8842).
6154 (writeSelectionToPasteboard): Put local selection into paste board
6155 if we have a local selection (Bug#8842).
6156 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6157
6158 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6159 (ns_get_local_selection): Declare.
6160
6161 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6162
6163 * keymap.c (describe_map_tree): Don't insert a double newline at
6164 the end of the buffer (bug#1169) and return whether we inserted
6165 something.
6166
6167 * callint.c (Fcall_interactively): Change "reading args" to
6168 "providing args" to try to clarify what it does (bug#1010).
6169
6170 2011-07-07 Kenichi Handa <handa@m17n.org>
6171
6172 * composite.c (composition_compute_stop_pos): Ignore a static
6173 composition starting before CHARPOS (Bug#8915).
6174
6175 * xdisp.c (handle_composition_prop): Likewise.
6176
6177 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6178
6179 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6180 (Bug#9015)
6181
6182 2011-07-07 Kenichi Handa <handa@m17n.org>
6183
6184 * character.h (unicode_category_t): New enum type.
6185
6186 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6187 (Qchar_code_property_table): New variable.
6188 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6189 (UNIPROP_COMPRESSED_FORM_P): New macros.
6190 (char_table_ascii): Uncompress the compressed values.
6191 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6192 Uncompress the compressed values.
6193 (sub_char_table_ref_and_range): Likewise.
6194 (char_table_ref_and_range): Uncompress the compressed values.
6195 (sub_char_table_set): New arg is_uniprop. Callers changed.
6196 Uncompress the compressed values.
6197 (sub_char_table_set_range): Args changed. Callers changed.
6198 (char_table_set_range): Adjuted for the above change.
6199 (map_sub_char_table): Delete args default_val and parent. Add arg
6200 top. Give decoded values to a Lisp function.
6201 (map_char_table): Adjust for the above change. Give decoded
6202 values to a Lisp function. Gcpro more variables.
6203 (uniprop_table_uncompress)
6204 (uniprop_decode_value_run_length): New functions.
6205 (uniprop_decoder, uniprop_decoder_count): New variables.
6206 (uniprop_get_decoder, uniprop_encode_value_character)
6207 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6208 New functions.
6209 (uniprop_encoder, uniprop_encoder_count): New variables.
6210 (uniprop_get_encoder, uniprop_table)
6211 (Funicode_property_table_internal, Fget_unicode_property_internal)
6212 (Fput_unicode_property_internal): New functions.
6213 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6214 Sunicode_property_table_internal, Sget_unicode_property_internal,
6215 and Sput_unicode_property_internal. Defvar_lisp
6216 char-code-property-alist.
6217
6218 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6219 Vunicode_category_table.
6220
6221 * font.c (font_range): Adjust for the change of
6222 Vunicode_category_table.
6223
6224 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6225
6226 * m/iris4d.h: Remove file, move contents ...
6227 * s/irix6-5.h: ... here.
6228
6229 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6230
6231 Remove unportable assumption about struct layout (Bug#8884).
6232 * alloc.c (mark_buffer):
6233 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6234 (clone_per_buffer_values): Don't assume that
6235 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6236 This isn't true in general, and it's particularly not true
6237 if Emacs is configured with --with-wide-int.
6238 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6239 New macros, used in the buffer.c change.
6240
6241 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6242
6243 * xsettings.c: Use both GConf and GSettings if both are available.
6244 (store_config_changed_event): Add comment.
6245 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6246 (store_tool_bar_style_changed): New functions.
6247 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6248 (struct xsettings): Move font inside HAVE_XFT.
6249 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6250 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6251 Move inside HAVE_XFT.
6252 (something_changed_gsettingsCB): Rename from something_changedCB.
6253 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6254 also.
6255 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6256 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6257 (something_changed_gconfCB): Rename from something_changedCB.
6258 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6259 (parse_settings): Move check for font inside HAVE_XFT.
6260 (read_settings, apply_xft_settings): Add comment.
6261 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6262 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6263 call store_font_name_changed.
6264 (xft_settings_event): Add comment.
6265 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6266 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6267 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6268 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6269 (xsettings_initialize): Call init_gsettings last.
6270 (xsettings_get_system_font, xsettings_get_system_normal_font):
6271 Add comment.
6272
6273 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6274
6275 Random fixes. E.g., (random) never returned negative values.
6276 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6277 subseconds part to the entropy, as that's a bit more random.
6278 Prefer signed to unsigned, since the signedness doesn't matter and
6279 in general we prefer signed. When given a limit, use a
6280 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6281 latter isn't right if USE_2_TAGS_FOR_INTS.
6282 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6283 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6284
6285 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6286
6287 * textprop.c (text_property_stickiness):
6288 Obey Vtext_property_default_nonsticky.
6289 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6290 * w32fns.c (syms_of_w32fns):
6291 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6292
6293 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6294
6295 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6296 This is more efficient than Ffile_directory_p and avoids a minor race.
6297
6298 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6299
6300 * buffer.c (Foverlay_put): Say what the return value is
6301 (bug#7835).
6302
6303 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6304 is a directory before asking whether to use the file name
6305 (bug#7564).
6306 (barf_or_query_if_file_exists): Make the "File is a directory"
6307 error be more correct.
6308
6309 * fns.c (Frequire): Remove the mention of the .gz files, since
6310 that's installation-specific, but keep the mention of
6311 `get-load-suffixes'.
6312
6313 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6314
6315 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6316 Report string overflow if the output is too long.
6317
6318 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6319
6320 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6321 (syms_of_gnutls): Remove duplicate DEFSYM for
6322 Qgnutls_bootprop_verify_hostname_error, an error for
6323 Qgnutls_bootprop_verify_error (which is no longer used).
6324
6325 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6326 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6327 Also (re)move comments that are misplaced or no longer relevant.
6328
6329 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6330
6331 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6332
6333 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6334
6335 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6336 and background color parameters if they have been changed.
6337
6338 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6339
6340 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6341
6342 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6343
6344 * xsettings.c (SYSTEM_FONT): Define only when used.
6345 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6346
6347 * keymap.c (access_keymap_1): Now static.
6348
6349 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6350
6351 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6352 leave any prefix arg for the up event (Bug#1586).
6353
6354 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6355
6356 * lread.c (syms_of_lread): Mention single symbols defined by
6357 `defvar' or `defconst' (bug#7154).
6358
6359 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6360 (Frequire): Mention get-load-suffixes.
6361
6362 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6363
6364 * window.h (window): Remove clone_number slot.
6365 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6366 Remove.
6367 (make_parent_window, make_window, saved_window)
6368 (Fset_window_configuration, save_window_save): Don't deal with
6369 clone numbers.
6370 * buffer.c (Qclone_number): Remove declaration.
6371 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6372
6373 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6374
6375 Add multiple inheritance to keymaps.
6376 * keymap.c (Fmake_composed_keymap): New function.
6377 (Fset_keymap_parent): Simplify.
6378 (fix_submap_inheritance): Remove.
6379 (access_keymap_1): New function extracted from access_keymap to handle
6380 embedded parents and handle lists of maps.
6381 (access_keymap): Use it.
6382 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6383 (Fcopy_keymap): Handle embedded parents.
6384 (Fcommand_remapping, define_as_prefix): Simplify.
6385 (Fkey_binding): Simplify.
6386 (syms_of_keymap): Move minibuffer-local-completion-map,
6387 minibuffer-local-filename-completion-map,
6388 minibuffer-local-must-match-map, and
6389 minibuffer-local-filename-must-match-map to Elisp.
6390 (syms_of_keymap): Defsubr make-composed-keymap.
6391 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6392 (parse_menu_item): Trivial simplification.
6393
6394 2011-07-01 Glenn Morris <rgm@gnu.org>
6395
6396 * Makefile.in (SETTINGS_LIBS): Fix typo.
6397
6398 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6399
6400 * coding.c (Fencode_coding_string): Record the last coding system
6401 used, as the function doc string says (bug#8738).
6402
6403 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6404
6405 * xsettings.c (store_monospaced_changed): Take new font as arg and
6406 check for change against current_mono_font.
6407 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6408 (emacs_settings_constructor, emacs_settings_get_property)
6409 (emacs_settings_set_property, emacs_settings_class_init)
6410 (emacs_settings_init, gsettings_obj): Remove.
6411 (something_changedCB): New function for HAVE_GSETTINGS.
6412 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6413 with value as argument.
6414 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6415 g_settings_new (Bug#8967). Do not create gsettings_obj.
6416 Remove calls to g_settings_bind. Connect something_changedCB to
6417 "changed".
6418
6419 * xgselect.c: Add defined (HAVE_GSETTINGS).
6420 (xgselect_initialize): Ditto.
6421
6422 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6423 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6424 xg_select.
6425
6426 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6427
6428 * eval.c (struct backtrace): Simplify and port the data structure.
6429 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6430 signed bit field, as this assumption is not portable and it makes
6431 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6432 "char debug_on_exit : 1" as this is not portable either; instead,
6433 use the portable "unsigned int debug_on_exit : 1". Remove unused
6434 member evalargs. Remove obsolete comments about cc bombing out.
6435
6436 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6437
6438 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6439 Let HAVE_GSETTINGS override HAVE_GCONF.
6440 (store_monospaced_changed): New function.
6441 (EMACS_SETTINGS): A new type derived from GObject to handle
6442 GSettings notifications.
6443 (emacs_settings_constructor, emacs_settings_get_property)
6444 (emacs_settings_set_property, emacs_settings_class_init):
6445 New functions.
6446 (gsettings_client, gsettings_obj): New variables.
6447 (GSETTINGS_SCHEMA): New define.
6448 (something_changedCB): Call store_monospaced_changed.
6449 (init_gsettings): New function.
6450 (xsettings_initialize): Call init_gsettings.
6451 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6452 to NULL.
6453
6454 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6455 GCONF_CFLAGS/LIBS.
6456
6457 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6458
6459 * window.c (resize_root_window, grow_mini_window)
6460 (shrink_mini_window): Rename Qresize_root_window to
6461 Qwindow_resize_root_window and Qresize_root_window_vertically to
6462 Qwindow_resize_root_window_vertically.
6463
6464 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6465
6466 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6467
6468 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6469
6470 * makefile.w32-in: Redesign dependencies so they reflect more
6471 clearly which files are directly included by each source file,
6472 and not through other includes.
6473
6474 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6475
6476 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6477 (sort_overlays, overlay_strings): When an overlay's clone number
6478 matches the window's clone number process the overlay even if
6479 the overlay's window property doesn't match the current window.
6480
6481 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6482 (Fwindow_hchild): Rename to Fwindow_left_child.
6483 (Fwindow_next): Rename to Fwindow_next_sibling.
6484 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6485 (resize_window_check): Rename to window_resize_check.
6486 (resize_window_apply): Rename to window_resize_apply.
6487 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6488 (Fdelete_other_windows_internal, resize_frame_windows)
6489 (Fsplit_window_internal, Fdelete_window_internal)
6490 (grow_mini_window, shrink_mini_window)
6491 (Fresize_mini_window_internal): Fix callers accordingly.
6492
6493 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6494
6495 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6496 (emacs_fixed_set_min_size): Remove.
6497 (emacs_fixed_new): Take frame as argument.
6498
6499 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6500 (_EmacsFixedPrivate): Remove minwidth/height.
6501 Add struct frame *f.
6502 (emacs_fixed_init): Initialize priv->f.
6503 (get_parent_class, emacs_fixed_set_min_size): Remove.
6504 (emacs_fixed_new): Set priv->f to argument.
6505 (emacs_fixed_get_preferred_width)
6506 (emacs_fixed_get_preferred_height): Use min_width/height from
6507 frames size_hint to set minimum and natural (Bug#8919).
6508 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6509 and use min_width/height from frames size_hint to set
6510 min_width/height (Bug#8919).
6511
6512 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6513 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6514 Fix indentation.
6515
6516 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6517
6518 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6519 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6520 called at ZV.
6521
6522 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6523
6524 * process.c (wait_reading_process_output): Bypass select if
6525 waiting for a cell while ignoring keyboard input, and input is
6526 pending. Suggested by Jan Djärv (Bug#8869).
6527
6528 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6529
6530 Use gnulib's dup2 module instead of rolling our own.
6531 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6532
6533 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6534
6535 * dispnew.c (scrolling_window): Before scrolling, turn off a
6536 mouse-highlight in the window being scrolled.
6537
6538 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6539
6540 Move DEFSYM to lisp.h and use everywhere.
6541
6542 * character.h (DEFSYM): Move declaration...
6543 * lisp.h (DEFSYM): ...here.
6544
6545 * gnutls.c:
6546 * minibuf.c:
6547 * w32menu.c:
6548 * w32proc.c:
6549 * w32select.c: Don't include character.h.
6550
6551 * alloc.c (syms_of_alloc):
6552 * buffer.c (syms_of_buffer):
6553 * bytecode.c (syms_of_bytecode):
6554 * callint.c (syms_of_callint):
6555 * casefiddle.c (syms_of_casefiddle):
6556 * casetab.c (init_casetab_once):
6557 * category.c (init_category_once, syms_of_category):
6558 * ccl.c (syms_of_ccl):
6559 * cmds.c (syms_of_cmds):
6560 * composite.c (syms_of_composite):
6561 * dbusbind.c (syms_of_dbusbind):
6562 * dired.c (syms_of_dired):
6563 * dispnew.c (syms_of_display):
6564 * doc.c (syms_of_doc):
6565 * editfns.c (syms_of_editfns):
6566 * emacs.c (syms_of_emacs):
6567 * eval.c (syms_of_eval):
6568 * fileio.c (syms_of_fileio):
6569 * fns.c (syms_of_fns):
6570 * frame.c (syms_of_frame):
6571 * fringe.c (syms_of_fringe):
6572 * insdel.c (syms_of_insdel):
6573 * keymap.c (syms_of_keymap):
6574 * lread.c (init_obarray, syms_of_lread):
6575 * macros.c (syms_of_macros):
6576 * msdos.c (syms_of_msdos):
6577 * print.c (syms_of_print):
6578 * process.c (syms_of_process):
6579 * search.c (syms_of_search):
6580 * sound.c (syms_of_sound):
6581 * syntax.c (init_syntax_once, syms_of_syntax):
6582 * terminal.c (syms_of_terminal):
6583 * textprop.c (syms_of_textprop):
6584 * undo.c (syms_of_undo):
6585 * w32.c (globals_of_w32):
6586 * window.c (syms_of_window):
6587 * xdisp.c (syms_of_xdisp):
6588 * xfaces.c (syms_of_xfaces):
6589 * xfns.c (syms_of_xfns):
6590 * xmenu.c (syms_of_xmenu):
6591 * xsettings.c (syms_of_xsettings):
6592 * xterm.c (syms_of_xterm): Use DEFSYM.
6593
6594 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6595
6596 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6597
6598 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6599
6600 Integer and buffer overflow fixes (Bug#8873).
6601
6602 * print.c (printchar, strout): Check for string overflow.
6603 (PRINTPREPARE, printchar, strout):
6604 Don't set size unless allocation succeeds.
6605
6606 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6607 for sizes. Check for string overflow more accurately.
6608 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6609
6610 * macros.c: Integer and buffer overflow fixes.
6611 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6612 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6613 Use ptrdiff_t, not int, for sizes.
6614 Don't increment bufsize until after realloc succeeds.
6615 Check for size-calculation overflow.
6616 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6617
6618 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6619
6620 * lread.c: Integer overflow fixes.
6621 (read_integer): Radix is now EMACS_INT, not int,
6622 to improve quality of diagnostics for out-of-range radices.
6623 Calculate buffer size correctly for out-of-range radices.
6624 (read1): Check for integer overflow in radices, and in
6625 read-circle numbers.
6626 (read_escape): Avoid int overflow.
6627 (Fload, openp, read_buffer_size, read1)
6628 (substitute_object_recurse, read_vector, read_list, map_obarray):
6629 Use ptrdiff_t, not int, for sizes.
6630 (read1): Use EMACS_INT, not int, for sizes.
6631 Check for size overflow.
6632
6633 * image.c (cache_image): Check for size arithmetic overflow.
6634
6635 * lread.c: Integer overflow issues.
6636 (saved_doc_string_size, saved_doc_string_length)
6637 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6638 Now ptrdiff_t, not int.
6639 (read1): Don't assume doc string length fits in int. Check for
6640 out-of-range doc string lengths.
6641 (read_list): Don't assume file position fits in int.
6642 (read_escape): Check for hex character overflow.
6643
6644 2011-06-22 Leo Liu <sdl.web@gmail.com>
6645
6646 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6647 Move to minibuffer.el.
6648
6649 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6650
6651 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6652 The following patches are for when GLYPH_DEBUG && !XASSERT.
6653 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6654 * dispnew.c (flush_stdout):
6655 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6656 Mark as externally visible.
6657 * dispnew.c (check_window_matrix_pointers): Now static.
6658 * dispnew.c (window_to_frame_vpos):
6659 * xfns.c (unwind_create_frame):
6660 * xterm.c (x_check_font): Remove unused local.
6661 * scroll.c (CHECK_BOUNDS):
6662 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6663 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6664 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6665 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6666 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6667 Now static.
6668 (debug_method_add): Use va_list and vsprintf rather than relying
6669 on undefined behavior with wrong number of arguments.
6670 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6671 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6672 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6673 since we're not interested in debugging glyphs with old libraries.
6674 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6675 GCC 4.6.0's static checking.
6676
6677 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6678
6679 Integer overflow and signedness fixes (Bug#8873).
6680 A few related buffer overrun fixes, too.
6681
6682 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6683
6684 * dispextern.h (struct face.stipple):
6685 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6686 (x_bitmap_mask, x_allocate_bitmap_record)
6687 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6688 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6689 (x_create_bitmap_from_xpm_data):
6690 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6691 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6692 (.bitmaps_last):
6693 * xfaces.c (load_pixmap):
6694 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6695 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6696 (.bitmaps_last, struct x_output.icon_bitmap):
6697 Use ptrdiff_t, not int, for bitmap indexes.
6698 (x_allocate_bitmap_record): Check for size overflow.
6699 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6700
6701 Use ptrdiff_t, not int, for overlay counts.
6702 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6703 * editfns.c (overlays_around, get_pos_property):
6704 * textprop.c (get_char_property_and_overlay):
6705 * xdisp.c (next_overlay_change, note_mouse_highlight):
6706 * xfaces.c (face_at_buffer_position):
6707 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6708 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6709 (Fnext_overlay_change, Fprevious_overlay_change)
6710 (mouse_face_overlay_overlaps, Foverlays_in):
6711 Use ptrdiff_t, not int, for sizes.
6712 (overlays_at, overlays_in): Check for size-calculation overflow.
6713
6714 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6715
6716 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6717 (x_session_initialize): Do not assume string length fits in int.
6718
6719 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6720 This is unlikely, but can occur if DPI is outlandish.
6721
6722 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6723 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6724
6725 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6726 * xrdb.c (magic_file_p, search_magic_path):
6727 Omit last arg SUFFIX; it was always 0. All callers changed.
6728 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6729
6730 * xfont.c (xfont_match): Avoid need for strlen.
6731
6732 * xfns.c: Don't assume strlen fits in int.
6733 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6734
6735 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6736 not unsigned long, as we prefer signed integers. All callers changed.
6737 Detect integer overflow in repeat count.
6738 (message_dolog): Don't assume print length fits in 39 bytes.
6739 (display_mode_element): Don't assume strlen fits in int.
6740
6741 * termcap.c: Don't assume sizes fit in int and never overflow.
6742 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6743 (gobble_line): Check for size-calculation overflow.
6744
6745 * minibuf.c (Fread_buffer):
6746 * lread.c (intern, intern_c_string):
6747 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6748 Don't assume string length fits in int.
6749
6750 * keyboard.c (parse_tool_bar_item):
6751 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6752
6753 * font.c: Don't assume string length fits in int.
6754 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6755 Use ptrdiff_t, not int.
6756 (font_intern_prop): Don't assume string length fits in int.
6757 Don't assume integer property fits in fixnum.
6758 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6759
6760 * filelock.c: Fix some buffer overrun and integer overflow issues.
6761 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6762 Reformulate so as not to need the command string.
6763 Invoke gzip -cd rather than gunzip, as it's more portable.
6764 (lock_info_type, lock_file_1, lock_file):
6765 Don't assume pid_t and time_t fit in unsigned long.
6766 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6767 (current_lock_owner): Prefer signed type for sizes.
6768 Use memcpy, not strncpy, where memcpy is what is really wanted.
6769 Don't assume (via atoi) that time_t and pid_t fit in int.
6770 Check for time_t and/or pid_t out of range, e.g., via a network share.
6771 Don't alloca where an auto var works fine.
6772
6773 * fileio.c: Fix some integer overflow issues.
6774 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6775 Don't assume string length fits in int.
6776 (directory_file_name): Don't assume string length fits in long.
6777 (make_temp_name): Don't assume pid fits in int, or that its print
6778 length is less than 20.
6779
6780 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6781
6782 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6783
6784 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6785
6786 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6787 We prefer signed integers, even for size calculations.
6788
6789 * emacs.c: Don't assume string length fits in 'int'.
6790 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6791 (main): Don't invoke strlen when not needed.
6792
6793 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6794 (XD_DEBUG_MESSAGE): Don't waste a byte.
6795
6796 * callproc.c (getenv_internal_1, getenv_internal)
6797 (Fgetenv_internal):
6798 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6799
6800 * lread.c (invalid_syntax): Omit length argument.
6801 All uses changed. This doesn't fix a bug, but it simplifies the
6802 code away from its former Hollerith-constant appearance, and it's
6803 one less 'int' to worry about when looking at integer-overflow issues.
6804 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6805
6806 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6807 This didn't break anything, but it didn't help either.
6808 It's confusing to put a bogus integer in a place where the actual
6809 value does not matter.
6810 (LIST_END_P): Remove unused macro and its bogus comment.
6811 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6812
6813 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6814 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6815 implementation.
6816 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6817 We prefer signed types, and the value cannot exceed the EMACS_INT
6818 range anyway (because otherwise the length would not be representable).
6819 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6820 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6821 This avoids a GCC warning when WIDE_EMACS_INT.
6822
6823 * indent.c (sane_tab_width): New function.
6824 (current_column, scan_for_column, Findent_to, position_indentation)
6825 (compute_motion): Use it. This is just for clarity.
6826 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6827
6828 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6829
6830 * lisp.h (lint_assume): New macro.
6831 * composite.c (composition_gstring_put_cache):
6832 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6833
6834 * editfns.c, insdel.c:
6835 Omit unnecessary forward decls, to simplify future changes.
6836
6837 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6838
6839 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6840
6841 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6842 Use much-faster test for byte-length change.
6843 Don't assume string byte-length fits in 'int'.
6844 Check that character arg fits in 'int'.
6845 (mapcar1): Declare byte as byte, for clarity.
6846
6847 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6848
6849 * fns.c (concat): Catch string overflow earlier.
6850 Do not rely on integer wraparound.
6851
6852 * dispextern.h (struct it.overlay_strings_charpos)
6853 (struct it.selective): Now EMACS_INT, not int.
6854 * xdisp.c (forward_to_next_line_start)
6855 (back_to_previous_visible_line_start)
6856 (reseat_at_next_visible_line_start, next_element_from_buffer):
6857 Don't arbitrarily truncate the value of 'selective' to int.
6858
6859 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6860
6861 * composite.c: Don't truncate sizes to 'int'.
6862 (composition_gstring_p, composition_reseat_it)
6863 (composition_adjust_point): Use EMACS_INT, not int.
6864 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6865 not EMACS_UINT, for indexes.
6866
6867 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6868
6869 * buffer.c: Include <verify.h>.
6870 (struct sortvec.priority, struct sortstr.priority):
6871 Now EMACS_INT, not int.
6872 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6873 (struct sortstr.size, record_overlay_string)
6874 (struct sortstrlist.size, struct sortlist.used):
6875 Don't truncate size to int.
6876 (record_overlay_string): Check for size-calculation overflow.
6877 (init_buffer_once): Check at compile-time, not run-time.
6878
6879 2011-06-22 Jim Meyering <meyering@redhat.com>
6880
6881 Don't leak an XBM-image-sized buffer
6882 * image.c (xbm_load): Free the image buffer after using it.
6883
6884 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6885
6886 Port to Sun C.
6887 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6888 that Sun C diagnosed.
6889 * fns.c (secure_hash): Fix pointer signedness issue.
6890 * intervals.c (static_offset_intervals): New function.
6891 (offset_intervals): Use it.
6892
6893 2011-06-21 Leo Liu <sdl.web@gmail.com>
6894
6895 * deps.mk (fns.o):
6896 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6897 sha512.h.
6898
6899 * fns.c (secure_hash): Rename from crypto_hash_function and change
6900 the first arg to accept symbols.
6901 (Fsecure_hash): New primitive.
6902 (syms_of_fns): New symbols.
6903
6904 2011-06-20 Deniz Dogan <deniz@dogan.se>
6905
6906 * process.c (Fset_process_buffer): Clarify return value in
6907 docstring.
6908
6909 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6910
6911 * dispnew.c (add_window_display_history): Use BVAR.
6912
6913 * xdisp.c (debug_method_add): Use BVAR.
6914 (check_window_end, dump_glyph_matrix, dump_glyph)
6915 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6916
6917 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6918 Likewise.
6919
6920 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6921 check till after the cache is created in init_frame_faces.
6922
6923 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6924
6925 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6926
6927 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6928
6929 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6930 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6931 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6932
6933 Improve buffer-overflow checking (Bug#8873).
6934 * fileio.c (Finsert_file_contents):
6935 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6936 Remove the old (too-loose) buffer overflow checks.
6937 They weren't needed, since make_gap checks for buffer overflow.
6938 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6939 The old code merely checked for Emacs fixnum overflow, and relied
6940 on undefined (wraparound) behavior. The new code avoids undefined
6941 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6942
6943 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6944 Tune. Don't use wider integers than needed. Don't use alloca.
6945 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6946
6947 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6948
6949 * insdel.c, lisp.h (buffer_overflow): New function.
6950 (insert_from_buffer_1, replace_range, replace_range_2):
6951 * insdel.c (make_gap_larger):
6952 * editfns.c (Finsert_char):
6953 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6954
6955 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6956
6957 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6958
6959 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6960
6961 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6962 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6963
6964 * fileio.c: Don't assume EMACS_INT fits in off_t.
6965 (emacs_lseek): New static function.
6966 (Finsert_file_contents, Fwrite_region): Use it.
6967 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6968
6969 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6970
6971 * fns.c: Don't overflow int when computing a list length.
6972 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6973 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6974 truncation on 64-bit hosts. Check for QUIT every
6975 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6976 faster and is responsive enough.
6977 (Flength): Report an error instead of overflowing an integer.
6978 (Fsafe_length): Return a float if the value is not representable
6979 as a fixnum. This shouldn't happen except in contrived situations.
6980 (Fnthcdr, Fsort): Don't assume list length fits in int.
6981 (Fcopy_sequence): Don't assume vector length fits in int.
6982
6983 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6984 (header_size, word_size): New constants.
6985 (allocate_vectorlike): Don't check size overflow here.
6986 (allocate_vector): Check it here instead, since this is the only
6987 caller of allocate_vectorlike that could cause overflow.
6988 Check that the new vector's length is representable as a fixnum.
6989
6990 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6991 The previous code was bogus. For example, next_almost_prime (32)
6992 returned 39, which is undesirable as it is a multiple of 3; and
6993 next_almost_prime (24) returned 25, which is a multiple of 5 so
6994 why was the code bothering to check for multiples of 7?
6995
6996 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6997
6998 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6999
7000 Variadic C functions now count arguments with ptrdiff_t.
7001 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7002 Back then I didn't know that the Emacs coding style prefers signed int.
7003 Also, in the meantime I found a few more instances where arguments
7004 were being counted with int, which may truncate counts on 64-bit
7005 machines, or EMACS_INT, which may be unnecessarily wide.
7006 * lisp.h (struct Lisp_Subr.function.aMANY)
7007 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7008 Arg counts are now ptrdiff_t, not size_t.
7009 All variadic functions and their callers changed accordingly.
7010 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7011 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7012 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7013 * callint.c (Fcall_interactively): Check arg count for overflow,
7014 to avoid potential buffer overrun. Use signed char, not 'int',
7015 for 'varies' array, so that we needn't bother to check its size
7016 calculation for overflow.
7017 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7018 * eval.c (apply_lambda):
7019 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7020 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7021 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7022
7023 * callint.c (Fcall_interactively): Don't use index var as event count.
7024
7025 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7026 * mem-limits.h (SIZE): Remove; no longer used.
7027
7028 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7029
7030 Remove unnecessary casts.
7031 * xterm.c (x_term_init):
7032 * xfns.c (x_set_border_pixel):
7033 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7034 These aren't needed now that we assume ANSI C.
7035
7036 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7037 It's more likely to cause problems (due to unsigned overflow)
7038 than to cure them.
7039
7040 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7041
7042 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7043
7044 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7045
7046 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7047
7048 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7049
7050 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7051
7052 GLYPH_CODE_FACE returns EMACS_INT, not int.
7053 * dispextern.h (merge_faces):
7054 * xfaces.c (merge_faces):
7055 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7056 Don't assume EMACS_INT fits in int.
7057
7058 * character.h (CHAR_VALID_P): Remove unused parameter.
7059 * fontset.c, lisp.h, xdisp.c: All uses changed.
7060
7061 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7062
7063 * fns.c (concat): Minor tuning based on overflow analysis.
7064 This doesn't fix any bugs. Use int to hold character, instead
7065 of constantly refetching from Emacs object. Use XFASTINT, not
7066 XINT, for value known to be a character. Don't bother comparing
7067 a single byte to 0400, as it's always less.
7068
7069 * floatfns.c (Fexpt):
7070 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7071
7072 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7073 for characters.
7074
7075 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7076
7077 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7078 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7079 incorrectly succeed when S was a string, because 4294967386 was
7080 truncated before it was used.
7081
7082 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7083 Otherwise, an out-of-range integer could cause undefined behavior
7084 on a 64-bit host.
7085
7086 * composite.c: Use int, not EMACS_INT, for characters.
7087 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7088 EMACS_INT, for values that are known to be in character range.
7089 This doesn't fix any bugs but is the usual style inside Emacs and
7090 may generate better code on 32-bit machines.
7091
7092 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7093 This is for reasons similar to the recent CHAR_STRING fix.
7094 * charset.c (Fencode_char): Check that character arg is actually
7095 a character. Pass an int to ENCODE_CHAR.
7096 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7097 wider than 'int', as a compile-time check to prevent future regressions
7098 in this area.
7099
7100 * character.c (char_string): Remove unnecessary casts.
7101
7102 Make sure a 64-bit char is never passed to CHAR_STRING.
7103 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7104 by silently ignoring the top 32 bits, allowing some values
7105 that were far too large to be valid characters.
7106 * character.h: Include <verify.h>.
7107 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7108 arguments are no wider than unsigned, as a compile-time check
7109 to prevent future regressions in this area.
7110 * data.c (Faset):
7111 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7112 (Fsubst_char_in_region):
7113 * fns.c (concat):
7114 * xdisp.c (decode_mode_spec_coding):
7115 Adjust to CHAR_STRING's new requirement.
7116 * editfns.c (Finsert_char, Fsubst_char_in_region):
7117 * fns.c (concat): Check that character args are actually
7118 characters. Without this test, these functions did the wrong
7119 thing with wildly out-of-range values on 64-bit hosts.
7120
7121 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7122 These casts should not be needed on 32-bit hosts, either.
7123 * keyboard.c (read_char):
7124 * lread.c (Fload): Remove casts to unsigned.
7125
7126 * lisp.h (UNSIGNED_CMP): New macro.
7127 This fixes comparison bugs on 64-bit hosts.
7128 (ASCII_CHAR_P): Use it.
7129 * casefiddle.c (casify_object):
7130 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7131 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7132 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7133 * dispextern.h (FACE_FROM_ID):
7134 * keyboard.c (read_char): Use UNSIGNED_CMP.
7135
7136 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7137 not to EMACS_INT, to avoid GCC warning.
7138
7139 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7140
7141 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7142 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7143 isn't needed on 32-bit machines.
7144
7145 * buffer.c (Fgenerate_new_buffer_name):
7146 Use EMACS_INT for count, not int.
7147 (advance_to_char_boundary): Return EMACS_INT, not int.
7148
7149 * data.c (Qcompiled_function): Now static.
7150
7151 * window.c (window_body_lines): Now static.
7152
7153 * image.c (gif_load): Rename local to avoid shadowing.
7154
7155 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7156 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7157 * alloc.c (make_save_value): Integer argument is now of type
7158 ptrdiff_t, not int.
7159 (mark_object): Use ptrdiff_t, not int.
7160 * lisp.h (pD): New macro.
7161 * print.c (print_object): Use it.
7162
7163 * alloc.c: Use EMACS_INT, not int, to count objects.
7164 (total_conses, total_markers, total_symbols, total_vector_size)
7165 (total_free_conses, total_free_markers, total_free_symbols)
7166 (total_free_floats, total_floats, total_free_intervals)
7167 (total_intervals, total_strings, total_free_strings):
7168 Now EMACS_INT, not int. All uses changed.
7169 (Fgarbage_collect): Compute overall total using a double, so that
7170 integer overflow is less likely to be a problem. Check for overflow
7171 when converting back to an integer.
7172 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7173 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7174 These were 'int' variables that could overflow on 64-bit hosts;
7175 they were never used, so remove them instead of repairing them.
7176 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7177 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7178 Previously, this ceilinged at INT_MAX, but that doesn't work on
7179 64-bit machines.
7180 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7181
7182 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7183 (allocate_vectorlike): Check for ptrdiff_t overflow.
7184 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7185 when a (possibly-narrower) signed value would do just as well.
7186 We prefer using signed arithmetic, to avoid comparison confusion.
7187
7188 * alloc.c: Catch some string size overflows that we were missing.
7189 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7190 for convenience in STRING_BYTES_MAX.
7191 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7192 The definition here is exact; the one in lisp.h was approximate.
7193 (allocate_string_data): Check for string overflow. This catches
7194 some instances we weren't catching before. Also, it catches
7195 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7196 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7197 and ptrdiff_t and EMACS_INT are both 64 bits.
7198
7199 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7200 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7201 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7202
7203 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7204
7205 * alloc.c (Fmake_string): Check for out-of-range init.
7206
7207 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7208
7209 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7210
7211 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7212
7213 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7214 xg_get_default_scrollbar_width.
7215
7216 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7217 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7218 (style_changed_cb): Call update_theme_scrollbar_width and call
7219 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7220 all frames (Bug#8505).
7221 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7222 Call gtk_window_set_resizable if HAVE_GTK3.
7223 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7224 and height if HAVE_GTK3 (Bug#8505).
7225 (scroll_bar_width_for_theme): New variable.
7226 (update_theme_scrollbar_width): New function.
7227 (xg_get_default_scrollbar_width): Move code to
7228 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7229 (xg_initialize): Call update_theme_scrollbar_width.
7230
7231 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7232
7233 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7234
7235 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7236
7237 * frame.c (make_frame): Call other_buffer_safely instead of
7238 other_buffer.
7239
7240 * window.c (temp_output_buffer_show): Call display_buffer with
7241 second argument Vtemp_buffer_show_specifiers and reset latter
7242 immediately after the call.
7243 (Vtemp_buffer_show_specifiers): New variable.
7244 (auto_window_vscroll_p, next_screen_context_lines)
7245 (Vscroll_preserve_screen_position): Remove leading asterisks from
7246 doc-strings.
7247
7248 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7249
7250 Fix minor problems found by GCC 4.6.0 static checking.
7251 * buffer.c (Qclone_number): Remove for now, as it's unused.
7252 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7253 (record_buffer): Remove unused local.
7254 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7255 (set_frame_buffer_list): Remove; unused.
7256 * frame.h (other_visible_frames): Remove decl.
7257 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7258 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7259 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7260 if HAVE_GPM.
7261 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7262 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7263 Define only if HAVE_GPM.
7264 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7265 (update_hints_inhibit): Remove; never set. All uses removed.
7266 * widgetprv.h (emacsFrameClassRec): Remove decl.
7267 * window.c (delete_deletable_window): Now returns void, since it
7268 wasn't returning anything.
7269 (compare_window_configurations): Remove unused locals.
7270 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7271 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7272 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7273 the same widths as pointers. This follows up on the 2011-05-06 patch.
7274 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7275 * xterm.h: Likewise.
7276 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7277
7278 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7279
7280 * makefile.w32-in: Update dependencies.
7281 (LISP_H): Add lib/intprops.h.
7282
7283 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7284
7285 * image.c (gif_load): Add animation frame delay to the metadata.
7286 (syms_of_image): Use DEFSYM. New symbol `delay'.
7287
7288 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7289
7290 * window.c (delete_deletable_window): Re-add.
7291 (Fset_window_configuration): Rewrite to handle dead buffers and
7292 consequently deletable windows.
7293 (window_tree, Fwindow_tree): Remove. Supply functionality in
7294 window.el.
7295 (compare_window_configurations): Simplify code.
7296
7297 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7298
7299 * image.c (imagemagick_load_image): Fix type mismatch.
7300 (Fimagemagick_types): Likewise.
7301
7302 * window.h (replace_buffer_in_windows): Declare.
7303
7304 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7305
7306 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7307 Qclone_number. Remove external declaration of Qdelete_window.
7308 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7309 code.
7310 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7311 Run Qbuffer_list_update_hook if allowed.
7312 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7313 buffer list implementation.
7314 (other_buffer_safely): New function.
7315 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7316 calls to replace_buffer_in_windows and
7317 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7318 if allowed.
7319 (record_buffer): Inhibit quitting and rewrite using quittable
7320 functions. Run Qbuffer_list_update_hook if allowed.
7321 (Frecord_buffer, Funrecord_buffer): New functions.
7322 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7323 Move switch-to-buffer to window.el.
7324 (bury-buffer): Move to window.el.
7325 (Vbuffer_list_update_hook): New variable.
7326
7327 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7328 section.
7329
7330 * window.h (resize_frame_windows): Move up in code.
7331 (Fwindow_frame): Remove EXFUN.
7332 (replace_buffer_in_all_windows): Remove prototype.
7333 (replace_buffer_in_windows_safely): Add prototype.
7334
7335 * window.c: Declare Qdelete_window static again. Move down
7336 declaration of select_count.
7337 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7338 (Fother_window): Move to window.el.
7339 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7340 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7341 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7342 window.el.
7343 (replace_buffer_in_windows): Implement by calling
7344 Qreplace_buffer_in_windows.
7345 (replace_buffer_in_all_windows): Remove with some functionality
7346 moved into replace_buffer_in_windows_safely.
7347 (replace_buffer_in_windows_safely): New function.
7348 (select_window_norecord, select_frame_norecord): Move in front
7349 of run_window_configuration_change_hook. Remove now obsolete
7350 declarations.
7351 (Fset_window_buffer): Rewrite doc-string.
7352 Call Qrecord_window_buffer.
7353 (keys_of_window): Move binding for other-window to window.el.
7354
7355 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7356
7357 * dispextern.h (struct image): Replace data member, whose int_val
7358 and ptr_val fields were not used by anything, with a single
7359 lisp_val object.
7360
7361 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7362 (gif_clear_image, gif_load, imagemagick_load_image)
7363 (gs_clear_image, gs_load): Callers changed.
7364
7365 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7366
7367 * buffer.h: Include <time.h>, for time_t.
7368 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7369
7370 Fix minor problems found by static checking.
7371
7372 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7373
7374 Make identifiers static if they are not used in other modules.
7375 * data.c (Qcompiled_function, Qframe, Qvector):
7376 * image.c (QimageMagick, Qsvg):
7377 * minibuf.c (Qmetadata):
7378 * window.c (resize_window_check, resize_root_window): Now static.
7379 * window.h (resize_window_check, resize_root_window): Remove decls.
7380
7381 * window.c (window_deletion_count, delete_deletable_window):
7382 Remove; unused.
7383 (window_body_lines): Now static.
7384 (Fdelete_other_windows_internal): Mark vars as initialized.
7385 Make sure 'resize_failed' is initialized.
7386 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7387 (resize_window_apply): Remove unused local.
7388 * window.h (delete_deletable_window): Remove decl.
7389
7390 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7391 (imagemagick_load_image): Fix pointer signedness problem by changing
7392 last arg from unsigned char * to char *. All uses changed.
7393 Also, fix a local for similar reasons.
7394 Remove unused locals. Remove locals to avoid shadowing.
7395 (fn_rsvg_handle_free): Remove; unused.
7396 (svg_load, svg_load_image): Fix pointer signedness problem.
7397 (imagemagick_load_image): Don't use garbage pointer image_wand.
7398
7399 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7400
7401 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7402
7403 * image.c (gif_load): Fix omitted cast error introduced by
7404 2011-06-06 change.
7405
7406 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7407
7408 * window.h (resize_proportionally, orig_total_lines)
7409 (orig_top_line): Remove from window structure.
7410 (set_window_height, set_window_width, change_window_heights)
7411 (Fdelete_window): Remove prototypes.
7412 (resize_frame_windows): Remove duplicate declaration.
7413
7414 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7415
7416 * window.h (resize_frame_windows, resize_window_check)
7417 (delete_deletable_window, resize_root_window)
7418 (resize_frame_windows): Declare prototypes.
7419
7420 * window.c (resize_window_apply): Make definition be "static" to
7421 match the prototype.
7422
7423 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7424
7425 * window.c: Remove declarations of Qwindow_size_fixed,
7426 window_min_size_1, window_min_size_2, window_min_size,
7427 size_window, window_fixed_size_p, enlarge_window, delete_window.
7428 Remove static from declaration of Qdelete_window, it's
7429 temporarily needed by Fbury_buffer.
7430 (replace_window): Don't assign orig_top_line and
7431 orig_total_lines.
7432 (Fdelete_window, delete_window): Remove. Window deletion is
7433 handled by window.el.
7434 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7435 Replace Fdelete_window calls with calls to Qdelete_window.
7436 (Fdelete_other_windows): Remove. Deleting other windows is
7437 handled by window.el.
7438 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7439 handled in window.el.
7440 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7441 Window minimum sizes are handled in window.el.
7442 (shrink_windows, size_window, set_window_height)
7443 (set_window_width, change_window_heights, window_height)
7444 (window_width, CURBEG, CURSIZE, enlarge_window)
7445 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7446 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7447 handled in window.el.
7448 (make_dummy_parent): Rename to make_parent_window and give it a
7449 second argument horflag.
7450 (make_window): Don't set resize_proportionally any more.
7451 (Fsplit_window): Remove. Windows are split in window.el.
7452 (save_restore_action, save_restore_orig_size)
7453 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7454 Resize mini windows in window.el.
7455 (grow_mini_window, shrink_mini_window): Implement by calling
7456 Qresize_root_window_vertically, resize_window_check and
7457 resize_window_apply.
7458 (saved_window, Fset_window_configuration, save_window_save):
7459 Do not handle orig_top_line, orig_total_lines, and
7460 resize_proportionally.
7461 (window_min_height, window_min_width): Move to window.el.
7462 (keys_of_window): Move bindings for delete-other-windows,
7463 split-window, delete-window and enlarge-window to window.el.
7464
7465 * buffer.c: Temporarily extern Qdelete_window.
7466 (Fbury_buffer): Temporarily call Qdelete_window instead of
7467 Fdelete_window (Fbury_buffer will move to window.el soon).
7468
7469 * frame.c (set_menu_bar_lines_1): Remove code handling
7470 orig_top_line and orig_total_lines.
7471
7472 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7473 set_window_height but set heights directly.
7474 (change_frame_size_1): Use resize_frame_windows.
7475
7476 * xdisp.c (init_xdisp): Don't use set_window_height but set
7477 heights directly.
7478
7479 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7480 Use resize_frame_windows instead of change_window_heights and run
7481 run_window_configuration_change_hook.
7482
7483 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7484 instead of change_window_heights and run
7485 run_window_configuration_change_hook.
7486
7487 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7488
7489 * window.c (replace_window): Rename second argument REPLACEMENT to
7490 NEW. New third argument SETFLAG. Rewrite.
7491 (delete_window, make_dummy_parent): Call replace_window with
7492 third argument 1.
7493 (window_list_1): Move down in code.
7494 (run_window_configuration_change_hook): Move set_buffer part
7495 before select_frame_norecord part in order to unwind correctly.
7496 Rename count1 to count.
7497 (recombine_windows, delete_deletable_window, resize_root_window)
7498 (Fdelete_other_windows_internal)
7499 (Frun_window_configuration_change_hook, make_parent_window)
7500 (resize_window_check, resize_window_apply, Fresize_window_apply)
7501 (resize_frame_windows, Fsplit_window_internal)
7502 (Fdelete_window_internal, Fresize_mini_window_internal):
7503 New functions.
7504 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7505
7506 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7507
7508 * window.h (window): Add some new members to window structure -
7509 normal_lines, normal_cols, new_total, new_normal, clone_number,
7510 splits, nest, prev_buffers, next_buffers.
7511 (WINDOW_TOTAL_SIZE): Move here from window.c.
7512 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7513
7514 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7515 Remove.
7516 (make_dummy_parent): Set new members of windows structure.
7517 (make_window): Move down in code. Handle new members of window
7518 structure.
7519 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7520 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7521 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7522 (Fset_window_prev_buffers, Fwindow_next_buffers)
7523 (Fset_window_next_buffers, Fset_window_clone_number):
7524 New functions.
7525 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7526 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7527 Doc-string fixes.
7528 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7529 Argument WINDOW can be now internal window too.
7530 (Fwindow_use_time): Move up in code.
7531 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7532 Rewrite doc-string.
7533 (Fset_window_configuration, saved_window)
7534 (Fcurrent_window_configuration, save_window_save): Handle new
7535 members of window structure.
7536 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7537 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7538 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7539 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7540 Qget_mru_window, Qresize_root_window,
7541 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7542 Qauto_buffer_name; staticpro them.
7543
7544 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7545
7546 * window.c (Fwindow_total_size, Fwindow_left_column)
7547 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7548 (Fwindow_list_1): New functions.
7549 (window_box_text_cols): Replace with window_body_cols.
7550 (Fwindow_width, Fscroll_left, Fscroll_right):
7551 Use window_body_cols instead of window_box_text_cols.
7552 (delete_window, Fset_window_configuration):
7553 Call delete_all_subwindows with window as argument.
7554 (delete_all_subwindows): Take a window as argument and not a
7555 structure. Rewrite.
7556 (window_loop): Remove handling of GET_LRU_WINDOW and
7557 GET_LARGEST_WINDOW.
7558 (Fget_lru_window, Fget_largest_window): Move to window.el.
7559
7560 * window.h: Extern window_body_cols instead of
7561 window_box_text_cols. delete_all_subwindows now takes a
7562 Lisp_Object as argument.
7563
7564 * indent.c (compute_motion, Fcompute_motion):
7565 Use window_body_cols instead of window_box_text_cols.
7566
7567 * frame.c (delete_frame): Call delete_all_subwindows with root
7568 window as argument.
7569
7570 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7571
7572 * fns.c (Fputhash): Document return value.
7573
7574 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7575
7576 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7577
7578 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7579
7580 Cons<->int and similar integer overflow fixes (Bug#8794).
7581
7582 Check for overflow when converting integer to cons and back.
7583 * charset.c (Fdefine_charset_internal, Fdecode_char):
7584 Use cons_to_unsigned to catch overflow.
7585 (Fencode_char): Use INTEGER_TO_CONS.
7586 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7587 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7588 * data.c (long_to_cons, cons_to_long): Remove.
7589 (cons_to_unsigned, cons_to_signed): New functions.
7590 These signal an error for invalid or out-of-range values.
7591 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7592 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7593 * font.c (Ffont_variation_glyphs):
7594 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7595 * lisp.h: Include <intprops.h>.
7596 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7597 (cons_to_signed, cons_to_unsigned): New decls.
7598 (long_to_cons, cons_to_long): Remove decls.
7599 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7600 (Fprimitive_undo): Use CONS_TO_INTEGER.
7601 * xfns.c (Fx_window_property): Likewise.
7602 * xselect.c: Include <limits.h>.
7603 (x_own_selection, selection_data_to_lisp_data):
7604 Use INTEGER_TO_CONS.
7605 (x_handle_selection_request, x_handle_selection_clear)
7606 (x_get_foreign_selection, Fx_disown_selection_internal)
7607 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7608 (lisp_data_to_selection_data): Use cons_to_unsigned.
7609 (x_fill_property_data): Use cons_to_signed.
7610 Report values out of range.
7611
7612 Check for buffer and string overflow more precisely.
7613 * buffer.h (BUF_BYTES_MAX): New macro.
7614 * lisp.h (STRING_BYTES_MAX): New macro.
7615 * alloc.c (Fmake_string):
7616 * character.c (string_escape_byte8):
7617 * coding.c (coding_alloc_by_realloc):
7618 * doprnt.c (doprnt):
7619 * editfns.c (Fformat):
7620 * eval.c (verror):
7621 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7622 since they may not be the same number.
7623 * editfns.c (Finsert_char):
7624 * fileio.c (Finsert_file_contents):
7625 Likewise for BUF_BYTES_MAX.
7626
7627 * image.c: Use ptrdiff_t, not int, for sizes.
7628 (slurp_file): Switch from int to ptrdiff_t.
7629 All uses changed.
7630 (slurp_file): Check that file size fits in both size_t (for
7631 malloc) and ptrdiff_t (for sanity and safety).
7632
7633 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7634 if b->modtime has its maximal value.
7635
7636 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7637
7638 Don't assume time_t can fit into int.
7639 * buffer.h (struct buffer.modtime): Now time_t, not int.
7640 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7641 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7642
7643 Minor fixes for signed vs unsigned integers.
7644 * character.h (MAYBE_UNIFY_CHAR):
7645 * charset.c (maybe_unify_char):
7646 * keyboard.c (read_char, reorder_modifiers):
7647 XINT -> XFASTINT, since the integer must be nonnegative.
7648 * ftfont.c (ftfont_spec_pattern):
7649 * keymap.c (access_keymap, silly_event_symbol_error):
7650 XUINT -> XFASTINT, since the integer must be nonnegative.
7651 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7652 since it makes no difference and we prefer signed.
7653 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7654 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7655 nonnegative.
7656
7657 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7658
7659 * window.h (Fwindow_frame): Declare.
7660
7661 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7662
7663 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7664 (SPARE_MEMORY): Always define.
7665 (LARGE_REQUEST): Remove.
7666 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7667
7668 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7669
7670 * lisp.h: Move EXFUNS for Fframe_root_window,
7671 Fframe_first_window and Fset_frame_selected_window to window.h.
7672
7673 * window.h: Move EXFUNS for Fframe_root_window,
7674 Fframe_first_window and Fset_frame_selected_window here from
7675 lisp.h.
7676
7677 * frame.c (Fwindow_frame, Fframe_first_window)
7678 (Fframe_root_window, Fframe_selected_window)
7679 (Fset_frame_selected_window): Move to window.c.
7680 (Factive_minibuffer_window): Move to minibuf.c.
7681 (Fother_visible_frames_p): New function.
7682
7683 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7684
7685 * window.c (decode_window, decode_any_window): Move up in code.
7686 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7687 (inhibit_frame_unsplittable): Remove unused variable.
7688 (Fwindow_buffer): Move up and rewrite doc-string.
7689 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7690 (Fwindow_prev): New functions.
7691 (Fwindow_frame): Move here from frame.c. Accept any window as
7692 argument.
7693 (Fframe_root_window, Fframe_first_window)
7694 (Fframe_selected_window): Move here from frame.c. Accept frame
7695 or arbitrary window as argument. Update doc-strings.
7696 (Fminibuffer_window): Move up in code.
7697 (Fwindow_minibuffer_p): Move up in code and simplify.
7698 (Fset_frame_selected_window): Move here from frame.c.
7699 Marginal rewrite.
7700 (Fselected_window, select_window, Fselect_window): Move up in
7701 code. Minor doc-string fixes.
7702
7703 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7704
7705 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7706 Do not assume that spare memory exists; that assumption is valid
7707 only if SYSTEM_MALLOC.
7708 (LARGE_REQUEST): New macro, so that the issue of large requests
7709 is separated from the issue of spare memory.
7710
7711 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7712
7713 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7714 format. (Bug#8806)
7715
7716 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7717
7718 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7719 before statements.
7720
7721 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7722
7723 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7724
7725 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7726
7727 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7728 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7729
7730 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7731
7732 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7733
7734 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7735
7736 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7737 (x_clipboard_manager_save): Add return value.
7738 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7739 New error handlers.
7740 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7741 Obey Vx_select_enable_clipboard_manager. Catch errors in
7742 x_clipboard_manager_save (Bug#8779).
7743 (Vx_select_enable_clipboard_manager): New variable.
7744 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7745
7746 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7747
7748 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7749
7750 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7751
7752 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7753 in the current matrix if keep_current_p is non-zero.
7754
7755 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7756
7757 * bidi.c (bidi_level_of_next_char): Fix last change.
7758
7759 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7760
7761 Support bidi reordering of text covered by display properties.
7762
7763 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7764 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7765 (bidi_cache_search, bidi_cache_iterator_state)
7766 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7767 (bidi_level_of_next_char, bidi_move_to_visually_next):
7768 Support character positions inside a run of characters covered by a
7769 display string.
7770 (bidi_paragraph_init, bidi_resolve_explicit_1)
7771 (bidi_level_of_next_char): Call bidi_fetch_char and
7772 bidi_fetch_char_advance instead of FETCH_CHAR and
7773 FETCH_CHAR_ADVANCE.
7774 (bidi_init_it): Initialize new members.
7775 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7776 definitions.
7777 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7778 instead of using explicit *_CHAR codes.
7779 (bidi_resolve_explicit, bidi_resolve_weak):
7780 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7781 bidirectional text is supported only in multibyte buffers.
7782 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7783 it to initialize the frame_window_p member of struct bidi_it.
7784 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7785 (bidi_resolve_explicit, bidi_resolve_weak)
7786 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7787 bidi_it->nchars is non-positive.
7788 (bidi_level_of_next_char): Don't try to lookup the cache for the
7789 next/previous character if nothing is cached there yet, or if we
7790 were just reseat()'ed to a new position.
7791
7792 * xdisp.c (set_cursor_from_row): Set start and stop points
7793 according to the row's direction when priming the loop that looks
7794 for the glyph on which to display cursor.
7795 (single_display_spec_intangible_p): Function deleted.
7796 (display_prop_intangible_p): Reimplement to call
7797 handle_display_spec instead of single_display_spec_intangible_p.
7798 Accept 3 additional arguments needed by handle_display_spec.
7799 This fixes incorrect cursor motion across display property with complex
7800 values: lists, `(when COND...)' forms, etc.
7801 (single_display_spec_string_p): Support property values that are
7802 lists with the argument STRING its top-level element.
7803 (display_prop_string_p): Fix the condition for processing a
7804 property that is a list to be consistent with handle_display_spec.
7805 (handle_display_spec): New function, refactored from the
7806 last portion of handle_display_prop.
7807 (compute_display_string_pos): Accept additional argument
7808 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7809 value of a `display' property is a "replacing spec".
7810 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7811 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7812 the display property, but just return a value indicating whether
7813 the display property will replace the characters it covers.
7814 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7815 frame_window_p members of struct bidi_it.
7816 (compute_display_string_pos, compute_display_string_end):
7817 New functions.
7818 (push_it): Accept second argument POSITION, where pop_it should
7819 jump to continue iteration.
7820 (reseat_1): Initialize bidi_it.disp_pos.
7821
7822 * keyboard.c (adjust_point_for_property): Adjust the call to
7823 display_prop_intangible_p to its new signature.
7824
7825 * dispextern.h (struct bidi_it): New member frame_window_p.
7826 (bidi_init_it): Update prototypes.
7827 (display_prop_intangible_p): Update prototype.
7828 (compute_display_string_pos, compute_display_string_end):
7829 Declare prototypes.
7830 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7831 EMACS_INT.
7832
7833 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7834
7835 Malloc failure behavior now depends on size of allocation.
7836 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7837 * lisp.h: Change signatures accordingly.
7838 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7839 All callers changed. (Bug#8762)
7840
7841 * gnutls.c: Use Emacs's memory allocators.
7842 Without this change, the gnutls library would invoke malloc etc.
7843 directly, which causes problems on non-SYNC_INPUT hosts, and which
7844 runs afoul of improving memory_full behavior. (Bug#8761)
7845 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7846 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7847 xfree instead of the default malloc, realloc, free.
7848 (Fgnutls_boot): No need to check for memory allocation failure,
7849 since xmalloc does that for us.
7850
7851 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7852 * category.c (hash_get_category_set):
7853 * ccl.c (ccl_driver):
7854 * charset.c (Fdefine_charset_internal):
7855 * charset.h (struct charset.hash_index):
7856 * composite.c (get_composition_id, gstring_lookup_cache)
7857 (composition_gstring_put_cache):
7858 * composite.h (struct composition.hash_index):
7859 * dispextern.h (struct image.hash):
7860 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7861 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7862 (hashfn_equal, hashfn_user_defined, make_hash_table)
7863 (maybe_resize_hash_table, hash_lookup, hash_put)
7864 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7865 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7866 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7867 * image.c (make_image, search_image_cache, lookup_image)
7868 (xpm_put_color_table_h):
7869 * lisp.h (struct Lisp_Hash_Table):
7870 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7871 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7872 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7873 * alloc.c (allocate_vectorlike):
7874 Check for overflow in vector size calculations.
7875 * ccl.c (ccl_driver):
7876 Check for overflow when converting EMACS_INT to int.
7877 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7878 need to be updated by these changes.
7879 * fns.c (make_hash_table, maybe_resize_hash_table):
7880 Check for integer overflow with large hash tables.
7881 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7882 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7883 (SXHASH_REDUCE): New macro.
7884 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7885 Use it instead of discarding useful hash info with large hash values.
7886 (sxhash_float): New function.
7887 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7888 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7889 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7890 Rewrite to use FIXNUM_BITS, as this simplifies things.
7891 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7892 Adjust signatures to match updated version of code.
7893 (consing_since_gc): Now EMACS_INT, since a single hash table can
7894 use more than INT_MAX bytes.
7895
7896 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7897
7898 Make it possible to build with GCC-4.6+ -O2 -flto.
7899
7900 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7901
7902 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7903
7904 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7905 Call minibuffer-inactive-mode.
7906
7907 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7908
7909 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7910 Update dependencies.
7911
7912 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7913
7914 * data.c (init_data): Remove code for UTS, this system is not
7915 supported anymore.
7916
7917 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7918
7919 Don't force ./temacs to start in terminal mode.
7920
7921 * frame.c (make_initial_frame): Initialize faces in all cases, not
7922 only when CANNOT_DUMP is defined.
7923 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7924
7925 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7926
7927 * dispnew.c (add_window_display_history): Use const for the string
7928 pointer. Remove declaration, not needed.
7929
7930 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7931
7932 Use 'inline', not 'INLINE'.
7933 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7934 * alloc.c, fontset.c (INLINE): Remove.
7935 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7936 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7937 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7938 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7939 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7940
7941 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7942
7943 Make it possible to run ./temacs.
7944
7945 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7946 syms_of_callproc does the same thing. Remove test for
7947 "initialized", do it in the caller.
7948 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7949
7950 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7951
7952 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7953 (read_minibuf): Use get_minibuffer.
7954 (syms_of_minibuf): Use DEFSYM.
7955 (Qmetadata): New var.
7956 * data.c (Qbuffer): Don't make it static.
7957 (syms_of_data): Use DEFSYM.
7958
7959 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7960
7961 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7962 (CCL_CODE_MIN): New macro.
7963
7964 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7965
7966 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7967
7968 * eval.c (Qdebug): Now static.
7969 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7970 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7971 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7972
7973 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7974
7975 * image.c: Various fixes to ImageMagick code comments.
7976 (Fimagemagick_types): Doc fix.
7977
7978 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7979
7980 Minor fixes prompted by GCC 4.6.0 warnings.
7981
7982 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7983
7984 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7985 (x_clipboard_manager_save_all): Move extern decl to ...
7986 * xterm.h: ... here, so that it can be checked for consistency.
7987
7988 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7989
7990 * xselect.c (x_clipboard_manager_save_frame)
7991 (x_clipboard_manager_save_all): New functions.
7992 (Fx_clipboard_manager_save): Lisp function deleted.
7993
7994 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7995 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7996
7997 * xterm.h: Update prototype.
7998
7999 2011-05-28 William Xu <william.xwl@gmail.com>
8000
8001 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8002 exiting (Bug#8239).
8003
8004 2011-05-28 Jim Meyering <meyering@redhat.com>
8005
8006 Avoid a sign-extension bug in crypto_hash_function.
8007 * fns.c (to_uchar): Define.
8008 (crypto_hash_function): Use it to convert some newly-signed
8009 variables to unsigned, to avoid sign-extension bugs. For example,
8010 without this change, (md5 "truc") would evaluate to
8011 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8012 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8013 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8014
8015 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8016
8017 Integer overflow fixes.
8018
8019 * dbusbind.c: Serial number integer overflow fixes.
8020 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8021 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8022 to hold a serial number that is too large for a fixnum.
8023 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8024 Check for serial numbers out of range. Decode any serial number
8025 that was so large that it became a float. (Bug#8722)
8026
8027 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8028 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8029 Use XFASTINT rather than XUINT when numbers are nonnegative.
8030 (xd_append_arg, Fdbus_method_return_internal):
8031 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8032 arguments, check that Lisp number is nonnegative, rather than
8033 silently wrapping negative numbers around. (Bug#8722)
8034 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8035 (Bug#8722)
8036
8037 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8038
8039 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8040
8041 ccl: Add integer overflow checks.
8042 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8043 (IN_INT_RANGE): New macros.
8044 (ccl_driver): Use them to check for integer overflow when
8045 decoding a CCL program. Many of the new checks are whether XINT (x)
8046 fits in int; it doesn't always, on 64-bit hosts. The new version
8047 doesn't catch all possible integer overflows, but it's an
8048 improvement. (Bug#8719)
8049
8050 * alloc.c (make_event_array): Use XINT, not XUINT.
8051 There's no need for unsigned here.
8052
8053 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8054 This follows up to the 2011-05-06 change that substituted uintptr_t
8055 for EMACS_INT. This case wasn't caught back then.
8056
8057 Rework Fformat to avoid integer overflow issues.
8058 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8059 now (part of C89). Include <verify.h>.
8060 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8061 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8062 (Fformat): Avoid the prepass trying to compute sizes; it was only
8063 approximate and thus did not catch overflow reliably. Instead, walk
8064 through the format just once, formatting and computing sizes as we go,
8065 checking for integer overflow at every step, and allocating a larger
8066 buffer as needed. Keep track separately whether the format is
8067 multibyte. Keep only the most-recently calculated precision, rather
8068 than them all. Record whether each argument has been converted to
8069 string. Use EMACS_INT, not int, for byte and char and arg counts.
8070 Support field widths and precisions larger than INT_MAX. Avoid
8071 sprintf's undefined behavior with conversion specifications such as %#d
8072 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8073 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8074 formatting out-of-range floating point numbers with int
8075 formats. (Bug#8668)
8076
8077 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8078
8079 * data.c: Avoid integer truncation in expressions involving floats.
8080 * data.c: Include <intprops.h>.
8081 (arith_driver): When there's an integer overflow in an expression
8082 involving floating point, convert the integers to floating point
8083 so that the resulting value does not suffer from catastrophic
8084 integer truncation. For example, on a 64-bit host (* 4
8085 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8086 Do not rely on undefined behavior after integer overflow.
8087
8088 merge count_size_as_multibyte, parse_str_to_multibyte
8089 * character.c, character.h (count_size_as_multibyte):
8090 Rename from parse_str_to_multibyte; all uses changed.
8091 Check for integer overflow.
8092 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8093 since it's now a duplicate of the other. This is more of
8094 a character than a buffer op, so better that it's in character.c.
8095 * fns.c, print.c: Adjust to above changes.
8096
8097 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8098
8099 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8100
8101 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8102
8103 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8104 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8105 (x_clipboard_manager_save): Now static.
8106 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8107
8108 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8109 (crypto_hash_function): Now static.
8110 Fix pointer signedness problems. Avoid unnecessary initializations.
8111
8112 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8113
8114 * termhooks.h (Vselection_alist): Make it terminal-local.
8115
8116 * terminal.c (create_terminal): Initialize it.
8117
8118 * xselect.c: Support for clipboard managers.
8119 (Vselection_alist): Move to termhooks.h as terminal-local var.
8120 (LOCAL_SELECTION): New macro.
8121 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8122 (symbol_to_x_atom): Remove gratuitous arg.
8123 (x_handle_selection_request, lisp_data_to_selection_data)
8124 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8125 (x_own_selection, x_get_local_selection, x_convert_selection):
8126 New arg, specifying work frame. Use terminal-local Vselection_alist.
8127 (some_frame_on_display): Delete unused function.
8128 (Fx_own_selection_internal, Fx_get_selection_internal)
8129 (Fx_disown_selection_internal, Fx_selection_owner_p)
8130 (Fx_selection_exists_p): New optional frame arg.
8131 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8132 (x_handle_selection_clear): Don't treat other terminals with the
8133 same keyboard specially. Use the terminal-local Vselection_alist.
8134 (x_clear_frame_selections): Use Frun_hook_with_args.
8135
8136 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8137
8138 * xterm.h: Add support for those atoms.
8139
8140 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8141
8142 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8143 (converted_selections, conversion_fail_tag): New global variables.
8144 (x_selection_request_lisp_error): Free the above.
8145 (x_get_local_selection): Remove unnecessary code.
8146 (x_reply_selection_request): Args changed; handle arbitrary array
8147 of converted selections stored in converted_selections.
8148 Separate the XChangeProperty and SelectionNotify steps.
8149 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8150 (x_convert_selection): New function.
8151 (x_handle_selection_event): Simplify.
8152 (x_get_foreign_selection): Don't ignore incoming requests while
8153 waiting for an answer; this will fail when we implement
8154 SAVE_TARGETS, and seems unnecessary anyway.
8155 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8156 (Vx_sent_selection_functions): Doc fix.
8157
8158 2011-05-26 Leo Liu <sdl.web@gmail.com>
8159
8160 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8161
8162 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8163
8164 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8165
8166 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8167 for fringe update if it has periodic bitmap.
8168 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8169 and fringe_bitmap_periodic_p.
8170
8171 * fringe.c (get_fringe_bitmap_data): New function.
8172 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8173 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8174 row. Mark glyph row for fringe update if periodicity changed.
8175
8176 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8177 for fringe update unless it has periodic bitmap.
8178
8179 2011-05-25 Kenichi Handa <handa@m17n.org>
8180
8181 * xdisp.c (get_next_display_element): Set correct it->face_id for
8182 a static composition.
8183
8184 2011-05-24 Leo Liu <sdl.web@gmail.com>
8185
8186 * deps.mk (fns.o):
8187 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8188
8189 * fns.c (crypto_hash_function, Fsha1): New function.
8190 (Fmd5): Use crypto_hash_function.
8191 (syms_of_fns): Add Ssha1.
8192
8193 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8194
8195 * gnutls.c: Remove unused macros.
8196 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8197 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8198 Remove macros that are defined and never used.
8199 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8200
8201 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8202
8203 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8204 (Fx_get_selection_internal): Minor cleanup.
8205 (Fx_own_selection_internal): Rename arguments for consistency with
8206 select.el.
8207
8208 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8209
8210 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8211
8212 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8213
8214 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8215
8216 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8217
8218 * dispnew.c (scrolling_window): Don't exclude the case that the
8219 last enabled row in the desired matrix touches the bottom boundary.
8220
8221 2011-05-21 Glenn Morris <rgm@gnu.org>
8222
8223 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8224 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8225 and add some more files.
8226
8227 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8228
8229 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8230 report_file_error introduced by the change from 2011-05-07.
8231
8232 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8233
8234 * systime.h (Time): Define only if emacs is defined.
8235 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8236 where the include path doesn't have X11/X.h by default. See
8237 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8238
8239 2011-05-20 Kenichi Handa <handa@m17n.org>
8240
8241 * composite.c (find_automatic_composition): Fix previous change.
8242
8243 2011-05-20 Glenn Morris <rgm@gnu.org>
8244
8245 * lisp.mk: New file, split from Makefile.in.
8246 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8247 (shortlisp): Remove.
8248 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8249
8250 2011-05-19 Glenn Morris <rgm@gnu.org>
8251
8252 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8253 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8254 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8255 (lisp): Set the order to that of loadup.el.
8256 (shortlisp): Make it a copy of $lisp.
8257 (SOME_MACHINE_LISP): Remove.
8258 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8259 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8260
8261 2011-05-18 Kenichi Handa <handa@m17n.org>
8262
8263 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8264 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8265 (find_automatic_composition): Mostly rewrite for efficiency.
8266
8267 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8268
8269 * makefile.w32-in: Update dependencies.
8270
8271 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8272
8273 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8274 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8275
8276 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8277
8278 Fix some integer overflow issues, such as string length overflow.
8279
8280 * insdel.c (count_size_as_multibyte): Check for string overflow.
8281
8282 * character.c (lisp_string_width): Check for string overflow.
8283 Use EMACS_INT, not int, for string indexes and lengths; in
8284 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8285 the resulting string length overflows an EMACS_INT; instead,
8286 report a string overflow if no precision given. When checking for
8287 precision exhaustion, use a check that cannot possibly have
8288 integer overflow. (Bug#8675)
8289 * character.h (lisp_string_width): Adjust to new signature.
8290
8291 * alloc.c (string_overflow): New function.
8292 (Fmake_string): Use it. This doesn't change behavior, but saves
8293 a few bytes and will simplify future changes.
8294 * character.c (string_escape_byte8): Likewise.
8295 * lisp.h (string_overflow): New decl.
8296
8297 Fixups, following up to the user-interface timestamp change.
8298 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8299 for UI timestamps, instead of unsigned long.
8300 * msdos.c (mouse_get_pos): Likewise.
8301 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8302 * w32gui.h (Time): Define by including "systime.h" rather than by
8303 declaring it ourselves. (Bug#8664)
8304
8305 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8306 * image.c (clear_image_cache): Likewise.
8307
8308 * term.c (term_mouse_position): Don't assume time_t wraparound.
8309
8310 Be more systematic about user-interface timestamps.
8311 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8312 and sometimes 'EMACS_UINT', to represent these timestamps.
8313 This change causes it to use 'Time' uniformly, as that's what X uses.
8314 This makes the code easier to follow, and makes it easier to catch
8315 integer overflow bugs such as Bug#8664.
8316 * frame.c (Fmouse_position, Fmouse_pixel_position):
8317 Use Time, not unsigned long, for user-interface timestamps.
8318 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8319 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8320 * keyboard.h (last_event_timestamp): Likewise.
8321 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8322 * menu.h (xmenu_show): Likewise.
8323 * term.c (term_mouse_position): Likewise.
8324 * termhooks.h (struct input_event.timestamp): Likewise.
8325 (struct terminal.mouse_position_hook): Likewise.
8326 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8327 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8328 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8329 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8330 what it was before.
8331 * menu.h, termhooks.h: Include "systime.h", for Time.
8332
8333 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8334 Don't assume that the difference between two unsigned long values
8335 can fit into an integer. At this point, we know button_down_time
8336 <= event->timestamp, so the difference must be nonnegative, so
8337 there's no need to cast the result if double-click-time is
8338 nonnegative, as it should be; check that it's nonnegative, just in
8339 case. This bug is triggered when events are more than 2**31 ms
8340 apart (about 25 days). (Bug#8664)
8341
8342 * xselect.c (last_event_timestamp): Remove duplicate decl.
8343 (x_own_selection): Remove needless cast to unsigned long.
8344
8345 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8346 that always fit in int. Use a sentinel instead of a counter, to
8347 avoid a temp and to allay GCC's concerns about possible int overflow.
8348 * frame.h (struct frame): Use int for menu_bar_items_used
8349 instead of EMACS_INT, since it always fits in int.
8350
8351 * menu.c (grow_menu_items): Check for int overflow.
8352
8353 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8354
8355 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8356 Before, the code was not consistent. These values cannot exceed
8357 2**31 - 1 so there's no need to make them unsigned.
8358 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8359 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8360 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8361 as modifiers.
8362 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8363
8364 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8365 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8366 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8367 presumably because the widths might not match.
8368
8369 * window.c (size_window): Avoid needless test at loop start.
8370
8371 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8372
8373 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8374
8375 2011-05-12 Drew Adams <drew.adams@oracle.com>
8376
8377 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8378
8379 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8380
8381 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8382 `width' to `bar_area_x' and `bar_area_width', respectively.
8383 (x_scroll_run): Take account of fringe background extension.
8384
8385 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8386 Rename local vars `left' and `width' to `bar_area_x' and
8387 `bar_area_width', respectively.
8388 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8389 background extension.
8390
8391 2011-05-10 Jim Meyering <meyering@redhat.com>
8392
8393 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8394
8395 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8396
8397 * image.c (Finit_image_library): Return t for built-in image types,
8398 like pbm and xbm. (Bug#8640)
8399
8400 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8401
8402 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8403
8404 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8405
8406 * w32console.c (Fset_screen_color): Doc fix.
8407 (Fget_screen_color): New function.
8408 (syms_of_ntterm): Defsubr it.
8409
8410 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8411 unlink the temporary file if Fcall_process didn't create it in the
8412 first place.
8413 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8414 child process will be redirected to a file specified with `:file'.
8415 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8416 cue to call_process_cleanup not to close that handle.
8417
8418 2011-05-07 Ben Key <bkey76@gmail.com>
8419
8420 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8421 one of two shell specific rules, either bootstrap-temacs-CMD or
8422 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8423 to the previous implementation of the bootstrap-temacs rule.
8424 The bootstrap-temacs-CMD rule is similar to the previous
8425 implementation of the bootstrap-temacs rule except that it
8426 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8427 variable.
8428
8429 These changes, along with some changes to nt/configure.bat,
8430 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8431 earlier fix to add support for --cflags and --ldflags options
8432 that include quotes so that it works whether make uses cmd or
8433 sh as the shell.
8434
8435 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8436
8437 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8438 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8439 is a constant.
8440 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8441 a string. Handle both cases.
8442 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8443 (Fdbus_register_method): Use Qinvalid_function.
8444
8445 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8446
8447 * makefile.w32-in: Update dependencies.
8448 (LISP_H): Add inttypes.h and stdin.h.
8449 (PROCESS_H): Add unistd.h.
8450
8451 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8452
8453 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8454 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8455
8456 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8457
8458 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8459
8460 * term.c (vfatal): Remove stray call to va_end.
8461 It's not needed and the C Standard doesn't allow it here anyway.
8462
8463 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8464 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8465
8466 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8467 bytes.
8468
8469 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8470
8471 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8472
8473 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8474
8475 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8476
8477 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8478
8479 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8480 * charset.c (Fdefine_charset_internal): Don't initialize
8481 charset.code_space[15]. The value was garbage, on hosts with
8482 32-bit int (Bug#8600).
8483
8484 * lread.c (read_integer): Be more consistent with string-to-number.
8485 Use string_to_number to do the actual conversion; this avoids
8486 rounding errors and fixes some other screwups. Without this fix,
8487 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8488 (digit_to_number): Move earlier, for benefit of read_integer.
8489 Return -1 if the digit is out of range for the base, -2 if it is
8490 not a digit in any supported base. (Bug#8602)
8491
8492 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8493
8494 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8495 to match comment at start of function. This also removes a
8496 GCC warning about overflow in a 32+64-bit port.
8497
8498 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8499
8500 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8501 Reported by Stefan Monnier in
8502 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8503 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8504 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8505
8506 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8507 (EMACS_UINTPTR): Likewise, with uintptr_t.
8508
8509 * lisp.h: Prefer 64-bit EMACS_INT if available.
8510 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8511 on 32-bit hosts that have 64-bit int, so that they can access
8512 large files.
8513 However, temporarily disable this change unless the temporary
8514 symbol WIDE_EMACS_INT is defined.
8515
8516 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8517
8518 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8519 This removes an assumption that EMACS_INT and long are the same
8520 width as pointers. The assumption is true for Emacs porting targets
8521 now, but we want to make other targets possible.
8522 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8523 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8524 In the rest of the code, change types of integers that hold casted
8525 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8526 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8527 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8528 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8529 No need to cast type when ORing.
8530 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8531 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8532 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8533 assume EMACS_INT is the same width as char *.
8534 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8535 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8536 Remove no-longer-needed casts.
8537 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8538 (xg_tool_bar_help_callback, xg_make_tool_item):
8539 Use EMACS_INTPTR to hold an integer
8540 that will be cast to void *; this can avoid a GCC warning
8541 if EMACS_INT is not the same width as void *.
8542 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8543 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8544 (current_message_1, set_message_1):
8545 Use a local to convert to proper width without a cast.
8546 * xmenu.c (dialog_selection_callback): Likewise.
8547
8548 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8549 Also, don't assume VALBITS / RAND_BITS is less than 5,
8550 and don't rely on undefined behavior when shifting a 1 left into
8551 the sign bit.
8552 * lisp.h (get_random): Change signature to match.
8553
8554 * lread.c (hash_string): Use size_t, not int, for hash computation.
8555 Normally we prefer signed values; but hashing is special, because
8556 it's better to use unsigned division on hash table sizes so that
8557 the remainder is nonnegative. Also, size_t is the natural width
8558 for hashing into memory. The previous code used 'int', which doesn't
8559 retain enough info to hash well into very large tables.
8560 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8561
8562 * dbusbind.c: Don't possibly lose pointer info when converting.
8563 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8564 Use XPNTR rather than XHASH, so that the high-order bits of
8565 the pointer aren't lost when converting through void *.
8566
8567 * eval.c (Fautoload): Don't double-shift a pointer.
8568
8569 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8570
8571 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8572
8573 * gnutls.c (DEF_GNUTLS_FN):
8574 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8575
8576 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8577
8578 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8579 marker. (Bug#8610)
8580
8581 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8582
8583 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8584 New version that can reserve upto 2GB of heap space.
8585
8586 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8587
8588 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8589
8590 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8591
8592 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8593 `gnutls_certificate_set_x509_key_file'.
8594
8595 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8596
8597 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8598 Update dependencies.
8599
8600 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8601
8602 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8603 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8604 Remove unused parameter `fildes'.
8605 * process.c (read_process_output, send_process): Don't pass it.
8606
8607 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8608
8609 Fix previous change: the library cache is defined in w32.c.
8610 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8611 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8612
8613 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8614
8615 Implement dynamic loading of GnuTLS on Windows.
8616
8617 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8618 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8619 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8620 Declare.
8621
8622 * gnutls.c (Qgnutls_dll): Define.
8623 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8624 (gnutls_*): Declare function pointers.
8625 (init_gnutls_functions): New function to initialize function pointers.
8626 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8627 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8628 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8629 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8630 (emacs_gnutls_write, emacs_gnutls_read)
8631 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8632 (Fgnutls_available_p): New function.
8633 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8634 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8635 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8636
8637 * image.c: Include w32.h.
8638 (Vimage_type_cache): Delete.
8639 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8640 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8641 (w32_delayed_load): Move to w32.c.
8642
8643 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8644
8645 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8646 (w32_delayed_load): Move from image.c. When loading a library, record
8647 its filename in the :loaded-from property of the library id.
8648 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8649 Initialize and staticpro them.
8650 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8651
8652 * process.c: Include lisp.h before w32.h, not after.
8653 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8654 instead of gnutls_record_check_pending.
8655
8656 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8657
8658 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8659
8660 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8661 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8662 as passed in.
8663
8664 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8665
8666 * xterm.c (x_set_frame_alpha): Do not set property on anything
8667 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8668
8669 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8670
8671 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8672
8673 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8674
8675 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8676 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8677 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8678 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8679 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8680 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8681 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8682 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8683 (Qgnutls_bootprop_callbacks_verify): Make static.
8684
8685 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8686
8687 * callproc.c: Indentation fixup.
8688
8689 * sysdep.c (wait_for_termination_1): Make static.
8690 (wait_for_termination, interruptible_wait_for_termination):
8691 Move after wait_for_termination_1.
8692
8693 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8694
8695 * sysdep.c (interruptible_wait_for_termination): New function
8696 which is like wait_for_termination, but allows keyboard
8697 interruptions.
8698
8699 * callproc.c (Fcall_process): Add (:file "file") as an option for
8700 the STDOUT buffer.
8701 (Fcall_process_region): Ditto.
8702
8703 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8704
8705 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8706 rather than `XVECTOR (FOO)->size'.
8707
8708 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8709 inttypes.h, as a gnulib replacement is used if it not available in
8710 system headers.
8711
8712 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8713
8714 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8715 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8716 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8717
8718 * coding.c (coding_alloc_by_realloc): Error out if destination
8719 will grow beyond MOST_POSITIVE_FIXNUM.
8720 (decode_coding_emacs_mule): Abort if there isn't enough place in
8721 charbuf for the composition carryover bytes. Reserve an extra
8722 space for up to 2 characters produced in a loop.
8723 (decode_coding_iso_2022): Abort if there isn't enough place in
8724 charbuf for the composition carryover bytes.
8725
8726 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8727
8728 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8729 aborting when %lld or %lll format is passed.
8730 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8731 %llo or %llx format is passed. (Bug#8545)
8732
8733 * window.c (window_scroll_line_based): Use a marker instead of
8734 simple variables to record original value of point. (Bug#7952)
8735
8736 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8737 produced by %s or %c overflows available buffer space. (Bug#8545)
8738
8739 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8740
8741 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8742 (SIZE_MAX): Move defn after all includes, as they might #define it.
8743
8744 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8745
8746 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8747
8748 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8749
8750 * keyboard.c (Qdelayed_warnings_hook): Define.
8751 (command_loop_1): Run `delayed-warnings-hook'
8752 if Vdelayed_warnings_list is non-nil.
8753 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8754 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8755
8756 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8757
8758 * doprnt.c (doprnt): Don't return value smaller than the buffer
8759 size if the message was truncated. (Bug#8545).
8760
8761 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8762
8763 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8764 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8765
8766 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8767
8768 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8769
8770 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8771
8772 * makefile.w32-in: Update dependencies.
8773
8774 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8775
8776 Improve `doprnt' and its usage. (Bug#8545)
8777 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8778 `format_end'. Remove support for %l as a conversion specifier.
8779 Don't use xrealloc. Improve diagnostics when the %l size modifier
8780 is used. Update the commentary.
8781
8782 * eval.c (verror): Simplify calculation of size_t.
8783
8784 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8785 messages.
8786
8787 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8788
8789 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8790 change.
8791
8792 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8793
8794 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8795 This makes this file independent of the recent pseudovector change.
8796
8797 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8798
8799 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8800
8801 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8802 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8803 Remove unused local.
8804 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8805
8806 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8807 GCC 4.6.0 optimizes based on type-based alias analysis.
8808 For example, if b is of type struct buffer * and v of type struct
8809 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8810 != &v->size, and therefore "v->size = 1; b->size = 2; return
8811 v->size;" must therefore return 1. This assumption is incorrect
8812 for Emacs, since it type-puns struct Lisp_Vector * with many other
8813 types. To fix this problem, this patch adds a new type struct
8814 vectorlike_header that documents the constraints on layout of vectors
8815 and pseudovectors, and helps optimizing compilers not get fooled
8816 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8817 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8818 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8819 the size member.
8820 (XSETPVECTYPE): Rewrite in terms of new macro.
8821 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8822 This is a bit clearer, and further avoids the possibility of
8823 undesirable aliasing.
8824 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8825 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8826 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8827 since Lisp_Subr is a special case (no "next" field).
8828 (ASIZE): Now uses header.size rather than size.
8829 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8830 to avoid the hassle of writing XVECTOR (foo)->header.size.
8831 (struct vectorlike_header): New type.
8832 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8833 object, to help avoid aliasing.
8834 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8835 (SUBRP): Likewise, since Lisp_Subr is a special case.
8836 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8837 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8838 (struct Lisp_Hash_Table): Combine first two members into a single
8839 struct vectorlike_header member. All uses of "size" and "next" members
8840 changed to be "header.size" and "header.next".
8841 * buffer.h (struct buffer): Likewise.
8842 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8843 * frame.h (struct frame): Likewise.
8844 * process.h (struct Lisp_Process): Likewise.
8845 * termhooks.h (struct terminal): Likewise.
8846 * window.c (struct save_window_data, struct saved_window): Likewise.
8847 * window.h (struct window): Likewise.
8848 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8849 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8850 * buffer.c (init_buffer_once): Likewise.
8851 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8852 special case.
8853 * process.c (Fformat_network_address): Use local var for size,
8854 for brevity.
8855
8856 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8857
8858 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8859 * data.c (atof): Remove decl; no longer used or needed.
8860 (digit_to_number): Move to lread.c.
8861 (Fstring_to_number): Use new string_to_number function, to be
8862 consistent with how the Lisp reader treats infinities and NaNs.
8863 Do not assume that floating-point numbers represent EMACS_INT
8864 without losing information; this is not true on most 64-bit hosts.
8865 Avoid double-rounding errors, by insisting on integers when
8866 parsing non-base-10 numbers, as the documentation specifies.
8867 * lisp.h (string_to_number): New decl, replacing ...
8868 (isfloat_string): Remove.
8869 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8870 (read1): Do not accept +. and -. as integers; this
8871 appears to have been a coding error. Similarly, do not accept
8872 strings like +-1e0 as floating point numbers. Do not report
8873 overflow for integer overflows unless the base is not 10 which
8874 means we have no simple and reliable way to continue.
8875 Break out the floating-point parsing into a new
8876 function string_to_number, so that Fstring_to_number parses
8877 floating point numbers consistently with the Lisp reader.
8878 (digit_to_number): Move here from data.c. Make it static inline.
8879 (E_CHAR, EXP_INT): Remove, replacing with ...
8880 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8881 (string_to_number): New function, replacing isfloat_string.
8882 This function checks for valid syntax and produces the resulting
8883 Lisp float number too. Rework it so that string-to-number
8884 no longer mishandles examples like "1.0e+". Use strtoumax,
8885 so that overflow for non-base-10 numbers is reported only when
8886 there's no portable and simple way to convert to floating point.
8887
8888 * textprop.c (set_text_properties_1): Rewrite for clarity,
8889 and to avoid GCC warning about integer overflow.
8890
8891 * intervals.h (struct interval): Use EMACS_INT for members
8892 where EMACS_UINT might cause problems. See
8893 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8894 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8895 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8896 All uses changed.
8897 (offset_intervals): Tell GCC not to worry about length overflow
8898 when negating a negative length.
8899
8900 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8901 (overrun_check_free): Likewise.
8902
8903 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8904 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8905 word size.
8906
8907 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8908 (gnutls_make_error): Rename local to avoid shadowing.
8909 (gnutls_emacs_global_deinit): ifdef out; not used.
8910 (Fgnutls_boot): Use const for pointer to readonly storage.
8911 Comment out unused local. Fix pointer signedness problems.
8912
8913 * lread.c (openp): Don't stuff size_t into an 'int'.
8914 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8915 about possible signed overflow.
8916
8917 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8918 (GDK_KEY_g): Don't define if already defined.
8919 (xg_prepare_tooltip): Avoid pointer signedness problem.
8920 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8921
8922 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8923 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8924
8925 * xfns.c (Fx_window_property): Simplify a bit,
8926 to make a bit faster and to avoid GCC 4.6.0 warning.
8927 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8928
8929 * fns.c (internal_equal): Don't assume size_t fits in int.
8930
8931 * alloc.c (compact_small_strings): Tighten assertion a little.
8932
8933 Replace pEd with more-general pI, and fix some printf arg casts.
8934 * lisp.h (pI): New macro, generalizing old pEd macro to other
8935 conversion specifiers. For example, use "...%"pI"d..." rather
8936 than "...%"pEd"...".
8937 (pEd): Remove. All uses replaced with similar uses of pI.
8938 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8939 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8940 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8941 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8942 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8943 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8944 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8945 64-bit hosts.
8946 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8947 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8948 * print.c (safe_debug_print, print_object): Likewise.
8949 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8950 to int.
8951 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8952 avoiding the 0 flag, which is not portable.
8953 * process.c (Fmake_network_process): Use pI to avoid cast.
8954 * region-cache.c (pp_cache): Likewise.
8955 * xdisp.c (decode_mode_spec): Likewise.
8956 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8957 behavior on 64-bit hosts with printf arg.
8958 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8959 (x_stop_queuing_selection_requests): Likewise.
8960 (x_get_window_property): Don't truncate byte count to an 'int'
8961 when tracing.
8962
8963 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8964 here, since it parses constructs like leading '-' and spaces,
8965 which are not wanted; and it overflows with large numbers.
8966 Instead, simply match F[0-9]+, which is what is wanted anyway.
8967
8968 * alloc.c: Remove unportable assumptions about struct layout.
8969 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8970 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8971 (allocate_vectorlike, make_pure_vector): Use the new macros,
8972 plus offsetof, to remove unportable assumptions about struct layout.
8973 These assumptions hold on all porting targets that I know of, but
8974 they are not guaranteed, they're easy to remove, and removing them
8975 makes further changes easier.
8976
8977 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8978 This doesn't fix a bug but makes the code clearer.
8979 (string_overrun_cookie): Now const. Use initializers that
8980 don't formally overflow signed char, to avoid warnings.
8981 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8982 can cause Emacs to crash when string overrun checking is enabled.
8983 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8984 multiple of sizeof (EMACS_INT); it need not be, if
8985 alignof(EMACS_INT) < sizeof (EMACS_INT).
8986 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8987
8988 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8989
8990 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8991
8992 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8993
8994 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8995 supposed to be handshaking. (Bug#8556)
8996 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8997
8998 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8999
9000 * lisp.h (Qdebug): List symbol.
9001 * eval.c (Qdebug): Restore global linkage.
9002 * keyboard.c (debug-on-event): New variable.
9003 (handle_user_signal): Break into debugger when debug-on-event
9004 matches the current signal symbol.
9005
9006 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9007
9008 * alloc.c (check_sblock, check_string_bytes)
9009 (check_string_free_list): Convert to standard C.
9010
9011 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9012
9013 * w32.c (emacs_gnutls_push): Fix typo.
9014
9015 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9016
9017 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9018 "cast to pointer from integer of different size".
9019
9020 Improve doprnt and its use in verror. (Bug#8545)
9021 * doprnt.c (doprnt): Document the set of format control sequences
9022 supported by the function. Use SAFE_ALLOCA instead of always
9023 using `alloca'.
9024
9025 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9026 is one byte too soon. Don't use xrealloc; instead xfree and
9027 xmalloc anew.
9028
9029 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9030
9031 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9032 callbacks stage.
9033
9034 * gnutls.c: Renamed global_initialized to
9035 gnutls_global_initialized. Added internals for the
9036 :verify-hostname-error, :verify-error, and :verify-flags
9037 parameters of `gnutls-boot' and documented those parameters in the
9038 docstring. Start callback support.
9039 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9040 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9041 on error. Return error code.
9042 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9043 (emacs_gnutls_read): Likewise.
9044 (Fgnutls_boot): Return handshake error code.
9045 (emacs_gnutls_handle_error): New function.
9046 (wsaerror_to_errno): Likewise.
9047
9048 * w32.h (emacs_gnutls_pull): Add prototype.
9049 (emacs_gnutls_push): Likewise.
9050
9051 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9052 (emacs_gnutls_push): Likewise.
9053
9054 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9055
9056 * process.c (wait_reading_process_output): Check if GnuTLS
9057 buffered some data internally if no FDs are set for TLS
9058 connections.
9059
9060 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9061 (LIBS): Link to USER_LIBS.
9062 ($(BLD)/gnutls.$(0)): New target.
9063
9064 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9065
9066 * xdisp.c (handle_single_display_spec): Rename the
9067 display_replaced_before_p argument into display_replaced_p, to
9068 make it consistent with the commentary. Fix typos in the
9069 commentary.
9070
9071 * textprop.c (syms_of_textprop): Remove dead code.
9072 (copy_text_properties): Delete obsolete commentary about an
9073 interface that was deleted long ago. Fix typos in the description
9074 of arguments.
9075
9076 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9077 to changes in oldXMenu/XMenu.h from 2011-04-16.
9078 <menu_help_message, prev_menu_help_message>: Constify.
9079 (IT_menu_make_room): menu->help_text is now `const char **';
9080 adjust.
9081
9082 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9083 to changes in oldXMenu/XMenu.h from 2011-04-16.
9084 (struct XMenu): Declare `help_text' `const char **'.
9085
9086 * xfaces.c <Qunspecified>: Make extern again.
9087
9088 * syntax.c: Include sys/types.h before including regex.h, as
9089 required by POSIX.
9090
9091 * doc.c (get_doc_string): Improve the format passed to `error'.
9092
9093 * doprnt.c (doprnt): Improve commentary.
9094
9095 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9096
9097 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9098 them with etags.
9099
9100 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9101 changes in globals.h immediately force recompilation.
9102 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9103 $(CURDIR)/s/ms-w32.h.
9104 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9105
9106 * character.c (Fchar_direction): Function deleted.
9107 (syms_of_character): Don't defsubr it.
9108 <char-direction-table>: Deleted.
9109
9110 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9111
9112 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9113 * doprnt.c: Include limits.h.
9114 (SIZE_MAX): New macro.
9115 (doprnt): Return a size_t value. 2nd arg is now size_t.
9116 Many local variables are now size_t instead of int or unsigned.
9117 Improve overflow protection. Support `l' modifier for integer
9118 conversions. Support %l conversion. Don't assume an EMACS_INT
9119 argument for integer conversions and for %c.
9120
9121 * lisp.h (doprnt): Restore prototype.
9122
9123 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9124 $(SRC)/character.h.
9125
9126 * Makefile.in (base_obj): Add back doprnt.o.
9127
9128 * deps.mk (doprnt.o): Add back prerequisites.
9129 (callint.o): Depend on character.h.
9130
9131 * eval.c (internal_lisp_condition_case): Include the handler
9132 representation in the error message.
9133 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9134 when breaking from the loop.
9135
9136 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9137
9138 * callint.c (Fcall_interactively): When displaying error message
9139 about invalid control letter, pass the character's codepoint, not
9140 a pointer to its multibyte form. Improve display of the character
9141 in octal and display also its hex code.
9142
9143 * character.c (char_string): Use %x to display the (unsigned)
9144 codepoint of an invalid character, to avoid displaying a bogus
9145 negative value.
9146
9147 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9148 `error', not SYMBOL_NAME itself.
9149
9150 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9151 character arguments to `error'.
9152
9153 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9154 to `error' in error message about FINAL_CHAR argument. Make sure
9155 FINAL_CHAR is a character, and use %c when it is passed as
9156 argument to `error'.
9157
9158 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9159
9160 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9161
9162 * w32.c: Include <time.h>.
9163 (sys_localtime): New function.
9164
9165 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9166
9167 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9168
9169 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9170
9171 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9172
9173 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9174 zombies (Bug#8467).
9175
9176 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9177
9178 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9179 gl_state.e_property when gl_state.object is Qt.
9180
9181 * insdel.c (make_gap_larger): Remove limitation of buffer size
9182 to <= INT_MAX.
9183
9184 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9185
9186 * xdisp.c (lookup_glyphless_char_display)
9187 (produce_glyphless_glyph): Handle cons cell entry in
9188 glyphless-char-display.
9189 (Vglyphless_char_display): Document it.
9190
9191 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9192 glyphless-char-display.
9193
9194 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9195
9196 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9197
9198 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9199
9200 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9201 definition for no-X builds.
9202
9203 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9204
9205 Static checks with GCC 4.6.0 and non-default toolkits.
9206
9207 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9208
9209 * process.c (keyboard_bit_set): Define only if SIGIO.
9210 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9211 (send_process): Repair possible setjmp clobbering.
9212
9213 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9214
9215 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9216
9217 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9218
9219 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9220 Define only if needed.
9221
9222 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9223 by pacifying GCC about it. Maybe it's time to retire it?
9224 * xfaces.c (USG, __TIMEVAL__): Likewise.
9225
9226 * dispextern.h (struct redisplay_interface): Rename param
9227 to avoid shadowing.
9228 * termhooks.h (struct terminal): Likewise.
9229 * xterm.c (xembed_send_message): Likewise.
9230
9231 * insdel.c (make_gap_smaller): Define only if
9232 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9233
9234 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9235 it.
9236
9237 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9238 so that we aren't warned about unused symbols.
9239
9240 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9241
9242 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9243
9244 * xfns.c (x_real_positions): Mark locals as initialized.
9245
9246 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9247
9248 * xterm.c: Fix problems found by static analysis with other toolkits.
9249 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9250 (x_dispatch_event): Declare static if USE_GTK, and
9251 define if USE_GTK || USE_X_TOOLKIT.
9252 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9253 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9254 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9255 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9256
9257 * xmenu.c (menu_help_callback): Pointer type fixes.
9258 Use const pointers when pointing at readonly data. Avoid pointer
9259 signedness clashes.
9260 (FALSE): Remove unused macro.
9261 (update_frame_menubar): Remove unused decl.
9262
9263 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9264
9265 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9266 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9267 (single_menu_item): Rename local to avoid shadowing.
9268
9269 * keyboard.c (make_lispy_event): Remove unused local var.
9270
9271 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9272 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9273
9274 * bitmaps: Change bitmaps from unsigned char back to the X11
9275 compatible char. Avoid the old compiler warnings about
9276 out-of-range initializers by using, for example, '\xab' rather
9277 than 0xab.
9278
9279 * xgselect.c (xgselect_initialize): Check vs interface
9280 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9281
9282 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9283
9284 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9285 to read-only memory.
9286
9287 * fns.c (vector): Remove; this old hack is no longer needed.
9288
9289 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9290 Remove unused var.
9291 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9292
9293 * xrdb.c (x_load_resources): Omit unused local.
9294
9295 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9296 (x_window): Rename locals to avoid shadowing.
9297 (USG): Use the kludged USG macro, to pacify gcc.
9298
9299 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9300 (x_term_init): Remove local to avoid shadowing.
9301
9302 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9303
9304 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9305 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9306
9307 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9308
9309 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9310
9311 Fix regex.c, syntax.c and friends for buffers > 2GB.
9312 * syntax.h (struct gl_state_s): Declare character position members
9313 EMACS_INT.
9314
9315 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9316
9317 * textprop.c (verify_interval_modification, interval_of):
9318 Declare arguments EMACS_INT.
9319
9320 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9321 EMACS_INT.
9322
9323 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9324
9325 * indent.c (Fvertical_motion): Local variable it_start is now
9326 EMACS_INT.
9327
9328 * regex.c (re_match, re_match_2, re_match_2_internal)
9329 (bcmp_translate, regcomp, regexec, print_double_string)
9330 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9331 (re_compile_pattern, re_exec): Declare arguments and local
9332 variables `size_t' and `ssize_t' and return values `regoff_t', as
9333 appropriate.
9334 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9335 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9336 <compile_stack_type>: `size' and `avail' are now `size_t'.
9337
9338 * regex.h <regoff_t>: Use ssize_t, not int.
9339 (re_search, re_search_2, re_match, re_match_2): Arguments that
9340 specify buffer/string position and length are now ssize_t and
9341 size_t. Return type is regoff_t.
9342
9343 2011-04-16 Ben Key <bkey76@gmail.com>
9344
9345 * nsfont.m: Fixed bugs in ns_get_family and
9346 ns_descriptor_to_entity that were caused by using free to
9347 deallocate memory blocks that were allocated by xmalloc (via
9348 xstrdup). This caused Emacs to crash when compiled with
9349 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9350 --enable-checking=xmallocoverrun). xfree is now used to
9351 deallocate these memory blocks.
9352
9353 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9354
9355 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9356
9357 emacs_write: Accept and return EMACS_INT for sizes.
9358 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9359 et seq.
9360 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9361 Accept and return EMACS_INT.
9362 (emacs_gnutls_write): Return the number of bytes written on
9363 partial writes.
9364 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9365 (emacs_read, emacs_write): Remove check for negative size, as the
9366 Emacs source code has been audited now.
9367 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9368 (emacs_read, emacs_write): Use it.
9369 * process.c (send_process): Adjust to the new signatures of
9370 emacs_write and emacs_gnutls_write. Do not attempt to store
9371 a byte offset into an 'int'; it might overflow.
9372 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9373
9374 * sound.c: Don't assume sizes fit in 'int'.
9375 (struct sound_device.period_size, alsa_period_size):
9376 Return EMACS_INT, not int.
9377 (struct sound_device.write, vox_write, alsa_write):
9378 Accept EMACS_INT, not int.
9379 (wav_play, au_play): Use EMACS_INT to store sizes and to
9380 record read return values.
9381
9382 2011-04-15 Ben Key <bkey76@gmail.com>
9383
9384 * keyboard.c (Qundefined): Don't declare static since it is used
9385 in nsfns.m.
9386 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9387 static since they are used in nsfont.m.
9388
9389 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9390
9391 * process.c (Qprocessp): Don't declare static.
9392 * lisp.h (Qprocessp): Declare again.
9393
9394 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9395
9396 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9397
9398 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9399
9400 Improve C-level modularity by making more things 'static'.
9401
9402 Don't publish debugger-only interfaces to other modules.
9403 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9404 (verify_bytepos, count_markers): Move decls to the only modules
9405 that need them.
9406 * region-cache.h (pp_cache): Likewise.
9407 * window.h (check_all_windows): Likewise.
9408 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9409
9410 * sysdep.c (croak): Now static, if
9411 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9412 * syssignal.h (croak): Declare only if not static.
9413
9414 * alloc.c (refill_memory_reserve): Now static if
9415 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9416 * lisp.h (refill_memory_reserve): Declare only if not static.
9417
9418 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9419 Define only if USE_LUCID.
9420
9421 * xrdb.c (x_customization_string, x_rm_string): Now static.
9422
9423 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9424 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9425
9426 * xdisp.c (draw_row_with_mouse_face): Now static.
9427 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9428
9429 * window.h (check_all_windows): Mark externally visible.
9430
9431 * window.c (window_deletion_count): Now static.
9432
9433 * undo.c: Make symbols static if they're not exported.
9434 (last_undo_buffer, last_boundary_position, pending_boundary):
9435 Now static.
9436
9437 * textprop.c (interval_insert_behind_hooks): Now static.
9438 (interval_insert_in_front_hooks): Likewise.
9439
9440 * term.c: Make symbols static if they're not exported.
9441 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9442 (max_frame_lines, tty_set_terminal_modes):
9443 (tty_reset_terminal_modes, tty_turn_off_highlight):
9444 (get_tty_terminal): Now static.
9445 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9446 * termhooks.h (term_mouse_moveto): Do not declare if
9447 HAVE_WINDOW_SYSTEM.
9448 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9449 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9450
9451 * sysdep.c: Make symbols static if they're not exported.
9452 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9453 Now static.
9454 (sigprocmask_set, full_mask): Remove; unused.
9455 (wait_debugging): Mark as visible.
9456 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9457 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9458
9459 * syntax.c (syntax_temp): Define only if !__GNUC__.
9460
9461 * sound.c (current_sound_device, current_sound): Now static.
9462
9463 * search.c (searchbufs, searchbuf_head): Now static.
9464
9465 * scroll.c (scroll_cost): Remove; unused.
9466 * dispextern.h (scroll_cost): Remove decl.
9467
9468 * region-cache.h (pp_cache): Mark as externally visible.
9469
9470 * process.c: Make symbols static if they're not exported.
9471 (process_tick, update_tick, create_process, chan_process):
9472 (Vprocess_alist, proc_buffered_char, datagram_access):
9473 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9474 (deactivate_process): Mark defn as static, as well as decl.
9475 * lisp.h (create_process): Remove decl.
9476 * process.h (chan_process, Vprocess_alist): Remove decls.
9477
9478 * print.c: Make symbols static if they're not exported.
9479 (print_depth, new_backquote_output, being_printed, print_buffer):
9480 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9481 (print_interval, print_number_index, initial_stderr_stream):
9482 Now static.
9483 * lisp.h (Fprinc): Remove decl.
9484 (debug_output_compilation_hack): Mark as externally visible.
9485
9486 * sysdep.c (croak): Move decl from here to syssignal.h.
9487 * syssignal.h (croak): Put it here, so the API can be checked when
9488 'croak' is called from dissociate_if_controlling_tty.
9489
9490 * minibuf.c: Make symbols static if they're not exported.
9491 (minibuf_save_list, choose_minibuf_frame): Now static.
9492 * lisp.h (choose_minibuf_frame): Remove decl.
9493
9494 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9495
9496 * lread.c: Make symbols static if they're not exported.
9497 (read_objects, initial_obarray, oblookup_last_bucket_number):
9498 Now static.
9499 (make_symbol): Remove; unused.
9500 * lisp.h (initial_obarray, make_symbol): Remove decls.
9501
9502 * keyboard.c: Make symbols static if they're not exported.
9503 (single_kboard, recent_keys_index, total_keys, recent_keys):
9504 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9505 (this_single_command_key_start, echoing, last_auto_save):
9506 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9507 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9508 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9509 (Vlispy_mouse_stem, double_click_count):
9510 Now static.
9511 (force_auto_save_soon): Define only if SIGDANGER.
9512 (ignore_mouse_drag_p): Now static if
9513 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9514 (print_help): Remove; unused.
9515 (stop_character, last_timer_event): Mark as externally visible.
9516 * keyboard.h (ignore_mouse_drag_p): Declare only if
9517 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9518 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9519 * lisp.h (echoing): Remove decl.
9520 (force_auto_save_soon): Declare only if SIGDANGER.
9521 * xdisp.c (redisplay_window): Simplify code, to make it more
9522 obvious that ignore_mouse_drag_p is not accessed if !defined
9523 USE_GTK && !defined HAVE_NS.
9524
9525 * intervals.c: Make symbols static if they're not exported.
9526 (merge_properties_sticky, merge_interval_right, delete_interval):
9527 Now static.
9528 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9529
9530 * insdel.c: Make symbols static if they're not exported.
9531 However, leave prepare_to_modify_buffer alone. It's never
9532 called from outside this function, but that appears to be a bug.
9533 (combine_after_change_list, combine_after_change_buffer):
9534 (adjust_after_replace, signal_before_change): Now static.
9535 (adjust_after_replace_noundo): Remove; unused.
9536 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9537 (signal_before_change): Remove decls.
9538
9539 * indent.c (val_compute_motion, val_vmotion): Now static.
9540
9541 * image.c: Make symbols static if they're not exported.
9542 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9543 if USE_GTK.
9544 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9545 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9546
9547 * fringe.c (standard_bitmaps): Now static.
9548 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9549
9550 * frame.c: Make symbols static if they're not exported.
9551 (x_report_frame_params, make_terminal_frame): Now static.
9552 (get_frame_param): Now static, unless HAVE_NS.
9553 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9554 (x_get_resource_string): Remove; not used.
9555 * frame.h (make_terminal_frame, x_report_frame_params):
9556 (x_get_resource_string); Remove decls.
9557 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9558 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9559
9560 * font.c, fontset.c: Make symbols static if they're not exported.
9561 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9562 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9563 * font.c (font_close_object): Now static.
9564 * font.h (font_close_object): Remove.
9565 * fontset.c (FONTSET_OBJLIST): Remove.
9566 (free_realized_fontset) #if-0 the body, which does nothing.
9567 (face_suitable_for_char_p): #if-0, as it's never called.
9568 * fontset.h (face_suitable_for_char_p): Remove decl.
9569 * xfaces.c (face_at_string_position):
9570 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9571 since 0 is always ASCII.
9572
9573 * fns.c (weak_hash_tables): Now static.
9574
9575 * fileio.c: Make symbols static if they're not exported.
9576 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9577 (Vwrite_region_annotation_buffers): Now static.
9578
9579 * eval.c: Make symbols static if they're not exported.
9580 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9581 * lisp.h (backtrace_list): Remove decl.
9582
9583 * emacs.c: Make symbols static if they're not exported.
9584 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9585 (fatal_error_code, fatal_error_signal_hook, standard_args):
9586 Now static.
9587 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9588 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9589 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9590 * lisp.h (fatal_error_signal_hook): Remove decl.
9591 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9592
9593 * editfns.c: Move a (normally-unused) function to its only use.
9594 * editfns.c, lisp.h (get_operating_system_release): Remove.
9595 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9596 worth the hassle of breaking this out.
9597
9598 * xterm.c: Make symbols static if they're not exported.
9599 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9600 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9601 (x_destroy_window, x_delete_display):
9602 Now static.
9603 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9604 (x_mouse_leave): Remove; unused.
9605 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9606 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9607 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9608 Remove decls.
9609 (x_mouse_leave): Declare only if WINDOWSNT.
9610 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9611 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9612 USE_X_TOOLKIT.
9613
9614 * ftxfont.c: Make symbols static if they're not exported.
9615 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9616 HAVE_FREETYPE.
9617 * font.h (ftxfont_driver): Likewise.
9618
9619 * xfns.c: Make symbols static if they're not exported.
9620 (x_last_font_name, x_display_info_for_name):
9621 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9622 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9623 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9624 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9625 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9626 (last_show_tip_args): Now static.
9627 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9628 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9629 (x_screen_planes): Remove; unused.
9630 * dispextern.h (x_screen_planes): Remove decl.
9631
9632 * dispnew.c: Make symbols static if they're not exported.
9633 * dispextern.h (redraw_garbaged_frames, scrolling):
9634 (increment_row_positions): Remove.
9635 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9636 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9637 Now static.
9638 (redraw_garbaged_frames): Remove; unused.
9639
9640 * xfaces.c: Make symbols static if they're not exported.
9641 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9642 Remove decls.
9643 * xterm.h (defined_color): Remove decls.
9644 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9645 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9646 (menu_face_changed_default, defined_color, free_realized_face):
9647 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9648 (ascii_face_of_lisp_face): Remove; unused.
9649
9650 * xdisp.c: Make symbols static if they're not exported.
9651 * dispextern.h (scratch_glyph_row, window_box_edges):
9652 (glyph_to_pixel_coords, set_cursor_from_row):
9653 (get_next_display_element, set_iterator_to_next):
9654 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9655 (show_mouse_face): Remove decls
9656 * frame.h (message_buf_print): Likewise.
9657 * lisp.h (pop_message, set_message, check_point_in_composition):
9658 Likewise.
9659 * xterm.h (set_vertical_scroll_bar): Likewise.
9660 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9661 (message_buf_print, scratch_glyph_row, displayed_buffer):
9662 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9663 (get_next_display_element, show_mouse_face, window_box_edges):
9664 (frame_to_window_pixel_xy, check_point_in_composition):
9665 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9666 (glyph_to_pixel_coords): Remove; unused.
9667
9668 * dired.c (file_name_completion): Now static.
9669
9670 * dbusbind.c (xd_in_read_queued_messages): Now static.
9671
9672 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9673 * data.c (circular_list_error): Remove.
9674
9675 * commands.h (last_point_position, last_point_position_buffer):
9676 (last_point_position_window): Remove decls.
9677 * keyboard.c: Make these variables static.
9678
9679 * coding.h (coding, code_convert_region, encode_coding_gap):
9680 Remove decls.
9681 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9682 (iso_code_class, detect_coding, code_convert_region): Now static.
9683 (encode_coding_gap): Remove; unused.
9684
9685 * chartab.c (chartab_chars, chartab_bits): Now static.
9686
9687 * charset.h (charset_iso_8859_1): Remove decl.
9688 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9689 Now static.
9690
9691 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9692 * ccl.c (Vccl_program_table): Now static.
9693 (check_ccl_update): Remove; unused.
9694
9695 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9696 * category.h: ... from here.
9697 * category.c (check_category_table, set_category_set): Now static.
9698
9699 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9700 * lisp.h: Remove these decls.
9701
9702 * buffer.c (buffer_count): Remove unused var.
9703
9704 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9705 so that it's not optimized away.
9706 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9707 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9708 exported only to the debugger.
9709
9710 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9711 * atimer.h (run_all_atimers): Remove; not exported.
9712
9713 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9714 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9715 was inaccessible from Lisp.
9716 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9717 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9718
9719 alloc.c: Import and export fewer symbols, and remove unused items.
9720 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9721 is defined.
9722 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9723 it's not optimized away by whole-program optimization.
9724 (message_enable_multibyte, free_misc): Remove.
9725 (catchlist, handlerlist, mark_backtrace):
9726 Declare only if BYTE_MARK_STACK.
9727 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9728 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9729 (message_enable_multibyte): Remove decl.
9730 (free_misc, interval_free_list, float_block, float_block_index):
9731 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9732 (cons_free_list, last_marked_index):
9733 Now static.
9734 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9735 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9736 (mark_backtrace): Define only if BYTE_MARK_STACK.
9737 * xdisp.c (message_enable_multibyte): Now static.
9738
9739 Declare Lisp_Object Q* variables to be 'static' if not exported.
9740 This makes it easier for human readers (and static analyzers)
9741 to see whether these variables are used from other modules.
9742 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9743 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9744 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9745 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9746 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9747 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9748 * xmenu.c, xselect.c:
9749 Declare Q* vars static if they are not used in other modules.
9750 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9751 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9752 Remove decls of unexported vars.
9753 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9754
9755 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9756
9757 Make Emacs functions such as Fatom 'static' by default.
9758 This makes it easier for human readers (and static analyzers)
9759 to see whether these functions can be called from other modules.
9760 DEFUN now defines a static function. To make the function external
9761 so that it can be used in other C modules, use the new macro DEFUE.
9762 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9763 (Finit_image_library):
9764 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9765 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9766 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9767 Remove decls, since these functions are now static.
9768 (Funintern, Fget_internal_run_time): New decls, since these functions
9769 were already external.
9770
9771 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9772 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9773 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9774 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9775 * keyboard.c, keymap.c, lread.c:
9776 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9777 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9778 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9779 Mark functions with DEFUE instead of DEFUN,
9780 if they are used in other modules.
9781 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9782 decls for now-static functions.
9783 * buffer.h (Fdelete_overlay): Remove decl.
9784 * callproc.c (Fgetenv_internal): Mark as internal.
9785 * composite.c (Fremove_list_of_text_properties): Remove decl.
9786 (Fcomposition_get_gstring): New forward static decl.
9787 * composite.h (Fcomposite_get_gstring): Remove decl.
9788 * dired.c (Ffile_attributes): New forward static decl.
9789 * doc.c (Fdocumntation_property): New forward static decl.
9790 * eval.c (Ffetch_bytecode): New forward static decl.
9791 (Funintern): Remove extern decl; now in .h file where it belongs.
9792 * fileio.c (Fmake_symbolic_link): New forward static decl.
9793 * image.c (Finit_image_library): New forward static decl.
9794 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9795 * intervals.h (Fprevious_property_change):
9796 (Fremove_list_of_text_properties): Remove decls.
9797 * keyboard.c (Fthis_command_keys): Remove decl.
9798 (Fcommand_execute): New forward static decl.
9799 * keymap.c (Flookup_key): New forward static decl.
9800 (Fcopy_keymap): Now static.
9801 * keymap.h (Flookup_key): Remove decl.
9802 * process.c (Fget_process): New forward static decl.
9803 (Fprocess_datagram_address): Mark as internal.
9804 * syntax.c (Fsyntax_table_p): New forward static decl.
9805 (skip_chars): Remove duplicate decl.
9806 * textprop.c (Fprevious_property_change): New forward static decl.
9807 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9808 Now internal.
9809 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9810 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9811
9812 * editfns.c (Fformat): Remove unreachable code.
9813
9814 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9815
9816 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9817 change. (Bug#8496)
9818
9819 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9820
9821 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9822 when at ZV. (Bug#8487)
9823
9824 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9825
9826 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9827 (Bug#8437)
9828 * keyboard.c (parse_tool_bar_item): Likewise.
9829 * sound.c (sound_cleanup, alsa_close): Likewise.
9830 * termcap.c (tgetent): Likewise.
9831 * xfns.c (x_default_font_parameter): Likewise.
9832 * xsettings.c (read_and_apply_settings): Likewise.
9833
9834 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9835 (overrun_check_free): Protoize.
9836
9837 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9838
9839 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9840 since callers should never pass a negative size.
9841 Change the signature to match that of plain 'read' and 'write'; see
9842 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9843 * lisp.h: Update prototypes of emacs_write and emacs_read.
9844
9845 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9846
9847 * xdisp.c (redisplay_window): Don't try to determine the character
9848 position of the scroll margin if the window start point w->startp
9849 is outside the buffer's accessible region. (Bug#8468)
9850
9851 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9852
9853 Fix write-region and its subroutines for buffers > 2GB.
9854 * fileio.c (a_write, e_write): Modify declaration of arguments and
9855 local variables to support buffers larger than 2GB.
9856 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9857
9858 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9859 argument, local variables, and return value.
9860
9861 * lisp.h: Update prototypes of emacs_write and emacs_read.
9862
9863 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9864
9865 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9866
9867 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9868
9869 Fix more problems found by GCC 4.6.0's static checks.
9870
9871 * xdisp.c (vmessage): Use a better test for character truncation.
9872
9873 * charset.c (load_charset_map): <, not <=, for optimization,
9874 and to avoid potential problems with integer overflow.
9875 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9876 * casetab.c (set_identity, shuffle): Likewise.
9877 * editfns.c (Fformat): Likewise.
9878 * syntax.c (skip_chars): Likewise.
9879
9880 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9881 This also lets GCC 4.6.0 generate slightly better loop code.
9882
9883 * callint.c (Fcall_interactively): <, not <=, for optimization.
9884 (Fcall_interactively): Count the number of arguments produced,
9885 not the number of arguments given. This is simpler and lets GCC
9886 4.6.0 generate slightly better code.
9887
9888 * ftfont.c: Distingish more carefully between FcChar8 and char.
9889 The previous code passed unsigned char * to a functions like
9890 strlen and xstrcasecmp that expect char *, which does not
9891 conform to the C standard.
9892 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9893 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9894 char * when the C standard requires it.
9895
9896 * keyboard.c (read_char): Remove unused var.
9897
9898 * eval.c: Port to Windows vsnprintf (Bug#8435).
9899 Include <limits.h>.
9900 (SIZE_MAX): Define if the headers do not.
9901 (verror): Do not give up if vsnprintf returns a negative count.
9902 Instead, grow the buffer. This ports to Windows vsnprintf, which
9903 does not conform to C99. Problem reported by Eli Zaretskii.
9904 Also, simplify the allocation scheme, by avoiding the need for
9905 calling realloc, and removing the ALLOCATED variable.
9906
9907 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9908
9909 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9910 But keep the doprint source code for now, as we might revamp it
9911 and use it again (Bug#8435).
9912 * lisp.h (doprnt): Remove.
9913 * Makefile.in (base_obj): Remove doprnt.o.
9914 * deps.mk (doprnt.o): Remove.
9915
9916 error: Print 32- and 64-bit integers portably (Bug#8435).
9917 Without this change, on typical 64-bit hosts error ("...%d...", N)
9918 was used to print both 32- and 64-bit integers N, which relied on
9919 undefined behavior.
9920 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9921 * lisp.h (error, verror): Mark as printf-like functions.
9922 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9923 Report overflow in size calculations when allocating printf buffer.
9924 Do not truncate output string at its first null byte.
9925 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9926 Truncate the output at a character boundary, since vsnprintf does not
9927 do that.
9928 * charset.c (check_iso_charset_parameter): Convert internal
9929 character to string before calling 'error', since %c now has the
9930 printf meaning.
9931 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9932 overflow when computing char to be passed to 'error'. Do not
9933 pass Lisp_Object to 'error'; pass the integer instead.
9934 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9935 formatted with plain %d.
9936
9937 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9938
9939 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9940
9941 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9942
9943 * xterm.c (x_catch_errors): Remove duplicate declaration.
9944
9945 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9946
9947 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9948
9949 2011-04-10 Jim Meyering <meyering@redhat.com>
9950
9951 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9952 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9953 return ssize_t not "int", and use size_t as the buffer length.
9954 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9955 * gnutls.h: Update declarations.
9956 * process.c (read_process_output): Use ssize_t, to match.
9957 (send_process): Likewise.
9958
9959 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9960
9961 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9962
9963 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9964
9965 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9966 Use unsigned char, to match FcChar8 type definition.
9967
9968 * xterm.c (handle_one_xevent):
9969 * xmenu.c (create_and_show_popup_menu):
9970 * xselect.c (x_decline_selection_request)
9971 (x_reply_selection_request): Avoid type-punned deref of X events.
9972
9973 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9974
9975 Fix some uses of `int' instead of EMACS_INT.
9976 * search.c (string_match_1, fast_string_match)
9977 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9978 (scan_buffer, find_next_newline_no_quit)
9979 (find_before_next_newline, search_command, Freplace_match)
9980 (Fmatch_data): Make some `int' variables be EMACS_INT.
9981
9982 * xdisp.c (display_count_lines): 3rd argument and return value now
9983 EMACS_INT. All callers changed.
9984 (pint2hrstr): Last argument is now EMACS_INT.
9985
9986 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9987 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9988 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9989 (decode_coding_utf_16, decode_coding_emacs_mule)
9990 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9991 (decode_coding_ccl, decode_coding_charset)
9992 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9993 (decode_coding_iso_2022, decode_coding_emacs_mule)
9994 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9995 <char_offset, last_offset>: Declare EMACS_INT.
9996 (encode_coding_utf_8, encode_coding_utf_16)
9997 (encode_coding_emacs_mule, encode_invocation_designation)
9998 (encode_designation_at_bol, encode_coding_iso_2022)
9999 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10000 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10001 Declare EMACS_INT.
10002 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10003 (encode_invocation_designation): Last argument P_NCHARS is now
10004 EMACS_INT.
10005 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10006 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10007
10008 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10009 All users changed.
10010
10011 * ccl.c (Fccl_execute_on_string): Declare some variables
10012 EMACS_INT.
10013
10014 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10015
10016 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10017
10018 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10019
10020 * process.c (Fformat_network_address): Doc fix.
10021
10022 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10023
10024 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10025
10026 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10027
10028 * keyboard.c (read_char): Call Lisp function help-form-show,
10029 instead of using internal_with_output_to_temp_buffer.
10030 (Qhelp_form_show): New var.
10031 (syms_of_keyboard): Use DEFSYM macro.
10032
10033 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10034
10035 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10036
10037 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10038
10039 * process.c (Flist_processes): Remove to Lisp.
10040 (list_processes_1): Delete.
10041
10042 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10043
10044 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10045
10046 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10047
10048 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10049
10050 Fix more problems found by GCC 4.6.0's static checks.
10051
10052 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10053
10054 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10055
10056 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10057
10058 * xdisp.c (vmessage): Mark as a printf-like function.
10059
10060 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10061
10062 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10063
10064 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10065 printf-like functions.
10066 (tiff_load): Add casts to remove these marks before passing them
10067 to system-supplied API.
10068
10069 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10070
10071 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10072 This avoids several warnings with gcc -Wstrict-overflow.
10073 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10074 directly, rather than having caller test rule sign. This avoids
10075 some unnecessary tests.
10076 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10077 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10078 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10079
10080 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10081 (xfont_open): Avoid unnecessary tests.
10082
10083 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10084
10085 * composite.h, composite.c (composition_gstring_put_cache):
10086 Use EMACS_INT, not int, for length.
10087
10088 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10089 breaking out part of COMPOSITION_DECODE_RULE.
10090 (COMPOSITION_DECODE_RULE): Use it.
10091 * composite.c (get_composition_id): Remove unused local vars,
10092 by using the new macro.
10093
10094 * textprop.c (set_text_properties_1): Change while to do-while,
10095 since the condition is always true at first.
10096
10097 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10098 (interval_deletion_adjustment): Return unsigned value.
10099 All uses changed.
10100
10101 * process.c (list_processes_1, create_pty, read_process_output):
10102 (exec_sentinel): Remove vars that were set but not used.
10103 (create_pty): Remove unnecessary "volatile"s.
10104 (Fnetwork_interface_info): Avoid possibility of int overflow.
10105 (read_process_output): Do adaptive read buffering even if carryover.
10106 (read_process_output): Simplify nbytes computation if buffered.
10107
10108 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10109
10110 * syntax.c (scan_words): Remove var that was set but not used.
10111 (update_syntax_table): Use unsigned instead of int.
10112
10113 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10114 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10115 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10116
10117 * print.c (print_error_message): Avoid int overflow.
10118
10119 * font.c (font_list_entities): Redo for clarity,
10120 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10121
10122 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10123 (font_score): Avoid potential overflow in diff calculation.
10124
10125 * fns.c (substring_both): Remove var that is set but not used.
10126 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10127
10128 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10129
10130 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10131 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10132 can always succeed if overflow has undefined behavior.
10133
10134 * search.c (boyer_moore, wordify): Remove vars set but not used.
10135 (wordify): Omit three unnecessary tests.
10136
10137 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10138 All callers changed. This avoids the need for an unused var.
10139
10140 * casefiddle.c (casify_region): Remove var that is set but not used.
10141
10142 * dired.c (file_name_completion): Remove var that is set but not used.
10143
10144 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10145
10146 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10147 (Finsert_file_contents): Remove unnecessary code checking fd.
10148
10149 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10150 Check for integer overflow on size calculations.
10151
10152 * buffer.c (Fprevious_overlay_change): Remove var that is set
10153 but not used.
10154
10155 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10156 Remove vars that are set but not used.
10157 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10158 (timer_check_2): Mark vars as initialized.
10159
10160 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10161
10162 * image.c (lookup_image): Remove var that is set but not used.
10163 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10164
10165 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10166 that are set but not used.
10167
10168 * xfns.c (make_invisible_cursor): Don't return garbage
10169 if XCreateBitmapFromData fails (Bug#8410).
10170
10171 * xselect.c (x_get_local_selection, x_handle_property_notify):
10172 Remove vars that are set but not used.
10173
10174 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10175 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10176
10177 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10178 Remove var that is set but not used.
10179 (scroll_bar_windows_size): Now size_t, not int.
10180 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10181 Check for overflow.
10182
10183 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10184 (map_tty_color) [!defined MSDOS]: Likewise.
10185
10186 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10187
10188 * coding.c: Remove vars that are set but not used.
10189 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10190 All callers changed.
10191 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10192 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10193 (decode_coding_charset): Remove vars that are set but not used.
10194
10195 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10196 that is set but not used.
10197
10198 * print.c (print_object): Remove var that is set but not used.
10199
10200 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10201 The gnulib version avoids calling malloc in the usual case,
10202 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10203 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10204 * filelock.c (current_lock_owner): Likewise.
10205 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10206 * sysdep.c: Include allocator.h, careadlinkat.h.
10207 (emacs_no_realloc_allocator): New static constant.
10208 (emacs_readlink): New function.
10209 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10210 ../lib/careadlinkat.h.
10211
10212 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10213
10214 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10215 first non-nil return value).
10216
10217 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10218
10219 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10220 if not defined (Bug#8403).
10221
10222 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10223
10224 * xdisp.c (display_count_lines): Remove parameter `start',
10225 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10226 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10227 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10228 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10229 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10230 and thereabouts. All callers changed.
10231 (get_per_char_metric): Remove parameter `f', unused since
10232 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10233
10234 2011-04-02 Jim Meyering <meyering@redhat.com>
10235
10236 do not dereference NULL upon failed strdup
10237 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10238 (ns_get_family): Likewise.
10239
10240 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10241
10242 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10243
10244 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10245
10246 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10247 later (Bug#8403).
10248
10249 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10250
10251 Add lexical binding.
10252
10253 * window.c (Ftemp_output_buffer_show): New fun.
10254 (Fsave_window_excursion):
10255 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10256
10257 * lread.c (lisp_file_lexically_bound_p): New function.
10258 (Fload): Bind Qlexical_binding.
10259 (readevalloop): Remove `evalfun' arg.
10260 Bind Qinternal_interpreter_environment.
10261 (Feval_buffer): Bind Qlexical_binding.
10262 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10263 Mark as dynamic.
10264 (syms_of_lread): Declare `lexical-binding'.
10265
10266 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10267
10268 * keyboard.c (eval_dyn): New fun.
10269 (menu_item_eval_property): Use it.
10270
10271 * image.c (parse_image_spec): Use Ffunctionp.
10272
10273 * fns.c (concat, mapcar1): Accept byte-code-functions.
10274
10275 * eval.c (Fsetq): Handle lexical vars.
10276 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10277 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10278 (FletX, Flet): Obey lexical binding.
10279 (Fcommandp): Handle closures.
10280 (Feval): New `lexical' arg.
10281 (eval_sub): New function extracted from Feval. Use it almost
10282 everywhere where Feval was used. Look up vars in lexical env.
10283 Handle closures.
10284 (Ffunctionp): Move from subr.el.
10285 (Ffuncall): Handle closures.
10286 (apply_lambda): Remove `eval_flags'.
10287 (funcall_lambda): Handle closures and new byte-code-functions.
10288 (Fspecial_variable_p): New function.
10289 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10290 but without exporting it to Lisp.
10291
10292 * doc.c (Fdocumentation, store_function_docstring):
10293 * data.c (Finteractive_form): Handle closures.
10294
10295 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10296 interactive spec.
10297
10298 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10299 New byte-codes.
10300 (exec_byte_code): New function extracted from Fbyte_code to handle new
10301 calling convention for byte-code-functions. Add new byte-codes.
10302
10303 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10304
10305 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10306
10307 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10308
10309 * xdisp.c (redisplay_internal): Fix prototype.
10310
10311 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10312
10313 * xdisp.c (SCROLL_LIMIT): New macro.
10314 (try_scrolling): Use it when setting scroll_limit.
10315 Limit scrolling to 100 screen lines.
10316 (redisplay_window): Even when falling back on "recentering",
10317 position point in the window according to scroll-conservatively,
10318 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10319
10320 (try_scrolling): When point is above the window, allow searching
10321 as far as scroll_max, or one screenful, to compute vertical
10322 distance from PT to the scroll margin position. This prevents
10323 try_scrolling from unnecessarily failing when
10324 scroll-conservatively is set to a value slightly larger than the
10325 window height. Clean up the case of PT below the margin at bottom
10326 of window: scroll_max can no longer be INT_MAX. When aggressive
10327 scrolling is in use, don't let point enter the opposite scroll
10328 margin as result of the scroll.
10329 (syms_of_xdisp) <scroll-conservatively>: Document the
10330 threshold of 100 lines for never-recentering scrolling.
10331
10332 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10333
10334 * dispextern.h (move_it_by_lines):
10335 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10336 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10337 (message_log_check_duplicate): Remove parameters `prev_bol' and
10338 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10339 (redisplay_internal): Remove parameter `preserve_echo_area',
10340 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10341
10342 * indent.c (Fvertical_motion):
10343 * window.c (window_scroll_pixel_based, Frecenter):
10344 Don't pass `need_y_p' to `move_it_by_lines'.
10345
10346 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10347
10348 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10349 steal a few bits to be more compact.
10350 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10351 Remove unneeded casts.
10352
10353 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10354
10355 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10356
10357 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10358 binding" message (bug#7967).
10359
10360 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10361
10362 Fix more problems found by GCC 4.6.0's static checks.
10363
10364 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10365 Remove unused local var.
10366
10367 * editfns.c (Fmessage_box): Remove unused local var.
10368
10369 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10370 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10371 Omit unused local vars.
10372 * window.c (shrink_windows): Omit unused local var.
10373 * menu.c (digest_single_submenu): Omit unused local var.
10374 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10375 Omit unused local var.
10376
10377 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10378 Don't assume string length fits in int.
10379 (keyremap_step, read_key_sequence): Use size_t for sizes.
10380 (read_key_sequence): Don't check last_real_key_start redundantly.
10381
10382 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10383 instead of alloca (Bug#8344).
10384
10385 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10386 (Fbacktrace_frame): Don't assume nframes fits in int.
10387
10388 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10389
10390 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10391 concerns.
10392
10393 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10394
10395 * cm.c (calccost): Turn while-do into do-while, for clarity.
10396
10397 * keyboard.c (syms_of_keyboard): Use the same style as later
10398 in this function when indexing through an array. This also
10399 works around GCC bug 48267.
10400
10401 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10402
10403 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10404
10405 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10406 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10407
10408 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10409 This avoids undefined behavior on integer overflow, and is a bit
10410 more convenient anyway since it is compared to a size_t variable.
10411
10412 Variadic C functions now count arguments with size_t, not int.
10413 This avoids an unnecessary limitation on 64-bit machines, which
10414 caused (substring ...) to crash on large vectors (Bug#8344).
10415 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10416 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10417 All variadic functions and their callers changed accordingly.
10418 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10419 * data.c (arith_driver, float_arith_driver): Likewise.
10420 * editfns.c (general_insert_function): Likewise.
10421 * eval.c (struct backtrace.nargs, interactive_p)
10422 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10423 (funcall_lambda, mark_backtrace): Likewise.
10424 * fns.c (concat): Likewise.
10425 * frame.c (x_set_frame_parameters): Likewise.
10426 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10427 0 if not found, not -1. All callers changed.
10428
10429 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10430 (stack_copy_size): Now size_t, not int.
10431 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10432
10433 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10434
10435 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10436 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10437 All callers changed.
10438
10439 * lisp.h (multibyte_char_to_unibyte):
10440 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10441 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10442 * character.h (CHAR_TO_BYTE8):
10443 * cmds.c (internal_self_insert):
10444 * editfns.c (general_insert_function):
10445 * keymap.c (push_key_description):
10446 * search.c (Freplace_match):
10447 * xdisp.c (message_dolog, set_message_1): All callers changed.
10448
10449 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10450
10451 * keyboard.c (safe_run_hook_funcall): New function.
10452 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10453 don't set the hook to nil, but remove the offending function instead.
10454 (Qcommand_hook_internal): Remove, unused.
10455 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10456 Vcommand_hook_internal.
10457
10458 * eval.c (enum run_hooks_condition): Remove.
10459 (funcall_nil, funcall_not): New functions.
10460 (run_hook_with_args): Call each function through a `funcall' argument.
10461 Remove `cond' argument, now redundant.
10462 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10463 (Frun_hook_with_args_until_failure): Adjust accordingly.
10464 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10465
10466 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10467
10468 * dispextern.h (string_buffer_position): Remove declaration.
10469
10470 * print.c (strout): Remove parameter `multibyte', unused since
10471 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10472
10473 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10474 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10475 All callers changed.
10476
10477 * w32.c (_wsa_errlist): Use braces for struct initializers.
10478
10479 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10480 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10481 All callers changed.
10482 (string_buffer_position): Likewise. Also, make static (it's never
10483 used outside xdisp.c).
10484 (cursor_row_p): Remove parameter `w', unused since
10485 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10486 (decode_mode_spec): Remove parameter `precision', introduced during
10487 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10488 All callers changed.
10489
10490 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10491
10492 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10493
10494 2011-03-27 Anders Lindgren <andlind@gmail.com>
10495
10496 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10497 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10498 (ns_update_auto_hide_menu_bar): New functions.
10499 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10500 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10501 ns_constrain_all_frames.
10502 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10503 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10504
10505 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10506
10507 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10508
10509 2011-03-27 Glenn Morris <rgm@gnu.org>
10510
10511 * syssignal.h: Replace RETSIGTYPE with void.
10512 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10513 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10514 Replace SIGTYPE with void everywhere.
10515 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10516 * s/template.h (SIGTYPE): Remove commented out definition.
10517
10518 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10519
10520 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10521 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10522
10523 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10524
10525 * w32.c (read_unc_volume): Use parameter `henum', instead of
10526 global variable `wget_enum_handle'.
10527
10528 * keymap.c (describe_vector): Remove parameters `indices' and
10529 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10530 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10531
10532 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10533
10534 * keyboard.c (timer_check): Remove parameter `do_it_now',
10535 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10536 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10537 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10538
10539 * keyboard.c (read_char):
10540 * w32menu.c (w32_menu_display_help):
10541 * xmenu.c (show_help_event, menu_help_callback):
10542 Adjust calls to `show_help_echo'.
10543
10544 * gtkutil.c (xg_maybe_add_timer):
10545 * keyboard.c (readable_events):
10546 * process.c (wait_reading_process_output):
10547 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10548
10549 * insdel.c (adjust_markers_gap_motion):
10550 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10551 (gap_left, gap_right): Don't call it.
10552
10553 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10554
10555 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10556 incurred during fontification.
10557
10558 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10559
10560 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10561 (DEFVAR_PER_BUFFER): Don't pass it.
10562
10563 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10564 (scrolling_window): Don't pass it.
10565
10566 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10567
10568 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10569
10570 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10571 and `suffix'.
10572 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10573 of variables specific to SELinux and computation of `encoded_absname'.
10574
10575 * image.c (XPutPixel): Remove unused variable `height'.
10576
10577 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10578
10579 * unexw32.c (get_section_info): Remove unused variable `section'.
10580
10581 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10582 (system_process_attributes): Remove unused variable `sess'.
10583 (sys_read): Remove unused variable `err'.
10584
10585 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10586 (w32_wnd_proc): Remove unused variable `isdead'.
10587 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10588 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10589 (x_create_tip_frame): Remove unused variable `tem'.
10590
10591 * w32inevt.c (w32_console_read_socket):
10592 Remove unused variable `no_events'.
10593
10594 * w32term.c (x_draw_composite_glyph_string_foreground):
10595 Remove unused variable `width'.
10596
10597 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10598
10599 * w32term.c (x_set_glyph_string_clipping):
10600 Don't pass uninitialized region to CombineRgn.
10601
10602 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10603
10604 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10605 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10606 (Fx_close_connection): Remove unused variable `i'.
10607
10608 * w32font.c (w32font_draw): Return number of glyphs.
10609 (w32font_open_internal): Remove unused variable `i'.
10610 (w32font_driver): Add missing initializer.
10611
10612 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10613 (fill_in_menu): Remove unused variable `items_added'.
10614
10615 * w32term.c (last_mouse_press_frame): Remove static global variable.
10616 (w32_clip_to_row): Remove unused variable `f'.
10617 (x_delete_terminal): Remove unused variable `i'.
10618
10619 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10620 (NOTHING): Remove unused static global variable.
10621 (uniscribe_check_otf): Remove unused variable `table'.
10622 (uniscribe_font_driver): Add missing initializers.
10623
10624 2011-03-23 Julien Danjou <julien@danjou.info>
10625
10626 * term.c (Fsuspend_tty, Fresume_tty):
10627 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10628 * window.c (temp_output_buffer_show):
10629 * insdel.c (signal_before_change):
10630 * frame.c (Fhandle_switch_frame):
10631 * fileio.c (Fdo_auto_save):
10632 * emacs.c (Fkill_emacs):
10633 * editfns.c (save_excursion_restore):
10634 * cmds.c (internal_self_insert):
10635 * callint.c (Fcall_interactively):
10636 * buffer.c (Fkill_all_local_variables):
10637 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10638 Use Frun_hooks.
10639 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10640 unconditionally since it does the check itself.
10641
10642 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10643
10644 Fix more problems found by GCC 4.5.2's static checks.
10645
10646 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10647 the first time through the loop, since we know p0 < p1 then.
10648 This also avoids a gcc -Wstrict-overflow warning.
10649
10650 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10651 leading to a memory leak, possible in functions like
10652 load_charset_map_from_file that can allocate an unbounded number
10653 of objects (Bug#8318).
10654
10655 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10656 that could (at least in theory) be that large.
10657
10658 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10659 This is less likely to overflow, and avoids undefined behavior if
10660 overflow does occur. All callers changed. Use strtoul to scan
10661 for the unsigned long integer.
10662 (pint2hrstr): Simplify and tune code slightly.
10663 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10664
10665 * scroll.c (do_scrolling): Work around GCC bug 48228.
10666 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10667
10668 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10669 This also avoids a warning with gcc -Wstrict-overflow.
10670 (validate_x_resource_name): Simplify count usage.
10671 This also avoids a warning with gcc -Wstrict-overflow.
10672
10673 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10674 fail (Bug#8306).
10675
10676 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10677
10678 * process.c (Fmake_network_process): Use socklen_t, not int,
10679 where POSIX says socklen_t is required in portable programs.
10680 This fixes a porting bug on hosts like 64-bit HP-UX, where
10681 socklen_t is wider than int (Bug#8277).
10682 (Fmake_network_process, server_accept_connection):
10683 (wait_reading_process_output, read_process_output):
10684 Likewise.
10685
10686 * process.c: Rename or move locals to avoid shadowing.
10687 (list_processes_1, Fmake_network_process):
10688 (read_process_output_error_handler, exec_sentinel_error_handler):
10689 Rename or move locals.
10690 (Fmake_network_process): Define label "retry_connect" only if needed.
10691 (Fnetwork_interface_info): Fix pointer signedness.
10692 (process_send_signal): Add cast to avoid pointer signedness problem.
10693 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10694 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10695
10696 Make tparam.h and terminfo.c consistent.
10697 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10698 Include tparam.h instead, since it declares them.
10699 * cm.h (PC): Remove extern decl; tparam.h now does this.
10700 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10701 * terminfo.c: Include tparam.h, to check interfaces.
10702 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10703 (tparam): Adjust signature to match interface in tparam.h;
10704 this removes some undefined behavior. Check that outstring and len
10705 are zero, which they always are with Emacs.
10706 * tparam.h (PC, BC, UP): New extern decls.
10707
10708 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10709 (xftfont_open): Rename locals to avoid shadowing.
10710
10711 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10712 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10713 (OTF_TAG_SYM): Omit macro if not needed.
10714 (ftfont_list): Remove unused local.
10715 (get_adstyle_property, ftfont_pattern_entity):
10716 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10717 Rename locals to avoid shadowing.
10718
10719 * xfont.c (xfont_list_family): Mark var as initialized.
10720
10721 * xml.c (make_dom): Now static.
10722
10723 * composite.c (composition_compute_stop_pos): Rename local to
10724 avoid shadowing.
10725 (composition_reseat_it): Remove unused locals.
10726 (find_automatic_composition, composition_adjust_point): Likewise.
10727 (composition_update_it): Mark var as initialized.
10728 (find_automatic_composition): Mark vars as initialized,
10729 with a FIXME (Bug#8290).
10730
10731 character.h: Rename locals to avoid shadowing.
10732 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10733 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10734 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10735 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10736 to avoid shadowing.
10737
10738 * textprop.c (property_change_between_p): Remove; unused.
10739
10740 * intervals.c (interval_start_pos): Now static.
10741
10742 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10743
10744 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10745 Rename locals to avoid shadowing.
10746
10747 * sound.c (wav_play, au_play, Fplay_sound_internal):
10748 Fix pointer signedness.
10749 (alsa_choose_format): Remove unused local var.
10750 (wav_play): Initialize a variable to 0, to prevent undefined
10751 behavior (Bug#8278).
10752
10753 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10754
10755 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10756
10757 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10758 clobbering (Bug#8298).
10759 * sysdep.c (sys_subshell): Likewise.
10760 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10761
10762 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10763 This should get cleaned up, so that child_setup has the
10764 same signature on all platforms.
10765
10766 * callproc.c (call_process_cleanup): Now static.
10767 (relocate_fd): Rename locals to avoid shadowing.
10768
10769 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10770
10771 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10772 not to be necessary, and produces flickering.
10773
10774 2011-03-20 Glenn Morris <rgm@gnu.org>
10775
10776 * config.in: Remove file.
10777
10778 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10779
10780 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10781 are now in src/globals.h.
10782 (syms_of_minibuf): Remove spurious & from previous change.
10783
10784 2011-03-20 Leo Liu <sdl.web@gmail.com>
10785
10786 * minibuf.c (completing-read-function): New variable.
10787 (completing-read-default): Rename from completing-read.
10788 (completing-read): Call completing-read-function.
10789
10790 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10791
10792 * xfaces.c (Fx_load_color_file):
10793 Read color file from absolute filename (bug#8250).
10794
10795 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10796
10797 * makefile.w32-in: Update dependencies.
10798
10799 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10800
10801 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10802
10803 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10804
10805 Fix more problems found by GCC 4.5.2's static checks.
10806
10807 * process.c (make_serial_process_unwind, send_process_trap):
10808 (sigchld_handler): Now static.
10809
10810 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10811 That way, the code declares only the vars that it needs.
10812 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10813 * s/cygwin.h (PTY_ITERATION): Likewise.
10814 * s/darwin.h (PTY_ITERATION): Likewise.
10815 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10816
10817 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10818 * process.c (allocate_pty): Don't declare stb unless it's needed.
10819
10820 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10821 (CONSTANTLIM): Remove; unused.
10822 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10823 Define only if needed.
10824
10825 * unexelf.c (unexec): Name an expression,
10826 to avoid gcc -Wbad-function-cast warning.
10827 Use a different way to cause a compilation error if anyone uses
10828 n rather than nn, a way that does not involve shadowing.
10829 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10830
10831 * deps.mk (unexalpha.o): Remove; unused.
10832
10833 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10834 * unexec.h: New file.
10835 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10836 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10837 Depend on unexec.h.
10838 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10839 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10840 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10841 Change as necessary to match prototype in unexec.h.
10842
10843 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10844 shadowing.
10845 (back_comment, skip_chars): Mark vars as initialized.
10846
10847 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10848 Rename locals to avoid shadowing.
10849
10850 * lread.c (read1): Rewrite so as not to use empty "else".
10851 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10852
10853 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10854
10855 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10856 warning when compiling print.c.
10857
10858 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10859 instead of using an uninitialized var.
10860 (font_sort_entities): Mark var as initialized.
10861
10862 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10863
10864 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10865 pointers to constants.
10866 (font_parse_fcname): Remove unused vars.
10867 (font_delete_unmatched): Now static.
10868 (font_get_spec): Remove; unused.
10869 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10870 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10871 Rename or move locals to avoid shadowing.
10872
10873 * fns.c (require_nesting_list, require_unwind): Now static.
10874 (Ffillarray): Rename locals to avoid shadowing.
10875
10876 * floatfns.c (domain_error2): Define only if needed.
10877 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10878
10879 * alloc.c (mark_backtrace): Move decl from here ...
10880 * lisp.h: ... to here, so that it can be checked.
10881
10882 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10883 (Fdefvar): Rewrite so as not to use empty "else".
10884 (lisp_indirect_variable): Name an expression,
10885 to avoid gcc -Wbad-function-cast warning.
10886 (Fdefvar): Rename locals to avoid shadowing.
10887
10888 * callint.c (quotify_arg, quotify_args): Now static.
10889 (Fcall_interactively): Rename locals to avoid shadowing.
10890 Use const pointer when appropriate.
10891
10892 * lisp.h (get_system_name, get_operating_system_release):
10893 Move decls here, to check interfaces.
10894 * process.c (get_operating_system_release): Move decl to lisp.h.
10895 * xrdb.c (get_system_name): Likewise.
10896 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10897 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10898 some of which prompt warnings from gcc -Wbad-function-cast.
10899 (Fformat_time_string, Fencode_time, Finsert_char):
10900 (Ftranslate_region_internal, Fformat):
10901 Rename or remove local vars to avoid shadowing.
10902 (Ftranslate_region_internal): Mark var as initialized.
10903
10904 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10905 avoid shadowing.
10906
10907 * lisp.h (eassert): Check that the argument compiles, even if
10908 ENABLE_CHECKING is not defined.
10909
10910 * data.c (Findirect_variable): Name an expression, to avoid
10911 gcc -Wbad-function-cast warning.
10912 (default_value, arithcompare, arith_driver, arith_error): Now static.
10913 (store_symval_forwarding): Rename local to avoid shadowing.
10914 (Fmake_variable_buffer_local, Fmake_local_variable):
10915 Mark variables as initialized.
10916 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10917
10918 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10919 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10920 Rename locals to avoid shadowing.
10921 (mark_stack): Move local variables into the #ifdef region where
10922 they're used.
10923 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10924 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10925 needed otherwise.
10926 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10927 (GC_STRING_CHARS): Remove; not used.
10928 (Fmemory_limit): Cast sbrk's returned value to char *.
10929
10930 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10931 avoids undefined behavior in theory.
10932
10933 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10934
10935 Use functions, not macros, for up- and down-casing (Bug#8254).
10936 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10937 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10938 to use the following functions instead of these macros.
10939 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10940 EMACS_INT, since callers assume the returned value fits in int.
10941 (upcase1): Likewise, for UPCASE_TABLE.
10942 (uppercasep, lowercasep, upcase): New static inline functions.
10943 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10944 the race-condition problem in the old DOWNCASE.
10945
10946 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10947 Rename locals to avoid shadowing.
10948 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10949 (regex_compile, re_search_2, re_match_2_internal):
10950 Remove unused local vars.
10951 (FREE_VAR): Rewrite so as not to use empty "else",
10952 which gcc can warn about.
10953 (regex_compile, re_match_2_internal): Mark locals as initialized.
10954 (RETALLOC_IF): Define only if needed.
10955 (WORDCHAR_P): Likewise. This one is never needed, but is used
10956 only in a comment talking about a compiler bug, so put inside
10957 the #if 0 of that comment.
10958 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10959 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10960 Remove; unused.
10961
10962 * search.c (boyer_moore): Rename locals to avoid shadowing.
10963 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10964 (PREV_CHAR_BOUNDARY): Likewise.
10965
10966 * search.c (simple_search): Remove unused var.
10967
10968 * dired.c (compile_pattern): Move decl from here ...
10969 * lisp.h: ... to here, so that it can be checked.
10970 (struct re_registers): New forward decl.
10971
10972 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10973
10974 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10975 All uses changed.
10976 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10977 Rename locals to avoid shadowing.
10978 (Fvertical_motion): Mark locals as initialized.
10979
10980 * casefiddle.c (casify_object, casify_region): Now static.
10981 (casify_region): Mark local as initialized.
10982
10983 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10984
10985 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10986 New macros, so that the caller can use some names other than
10987 gcpro1, gcpro2, etc.
10988 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10989 of the new macros.
10990 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10991 argument, for consistency with GCPRO2_VAR, etc: it is now the
10992 prefix of the variable, not the variable itself. All uses
10993 changed.
10994 * dired.c (directory_files_internal, file_name_completion):
10995 Rename locals to avoid shadowing.
10996
10997 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10998 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10999 dired.c's scmp function, had undefined behavior.
11000 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11001 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11002 * buffer.h: ... to here, because these macros use current_buffer,
11003 and the new implementation with inline functions needs to have
11004 current_buffer in scope now, rather than later when the macros
11005 are used.
11006 (downcase, upcase1): New static inline functions.
11007 (DOWNCASE, UPCASE1): Reimplement using these functions.
11008 This avoids undefined behavior in expressions like
11009 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11010 from race conditions in accessing the global variables
11011 case_temp1 and case_temp2.
11012 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11013 * lisp.h (case_temp1, case_temp2): Remove their decls.
11014 * character.h (ASCII_CHAR_P): Move from here ...
11015 * lisp.h: ... to here, so that the inline functions mentioned
11016 above can use them.
11017
11018 * dired.c (directory_files_internal_unwind): Now static.
11019
11020 * fileio.c (file_name_as_directory, directory_file_name):
11021 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11022 Now static.
11023 (file_name_as_directory): Use const pointers when appropriate.
11024 (Fexpand_file_name): Likewise. In particular, newdir might
11025 point at constant storage, so make it a const pointer.
11026 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11027 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11028 signedness issues.
11029 (Fset_file_times, Finsert_file_contents, auto_save_error):
11030 Rename locals to avoid shadowing.
11031
11032 * minibuf.c (choose_minibuf_frame_1): Now static.
11033 (Ftry_completion, Fall_completions): Rename or remove locals
11034 to avoid shadowing.
11035
11036 * marker.c (bytepos_to_charpos): Remove; unused.
11037
11038 * lisp.h (verify_bytepos, count_markers): New decls,
11039 so that gcc does not warn that these functions aren't declared.
11040
11041 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11042 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11043 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11044 (copy_text): Remove unused local var.
11045
11046 * filelock.c (within_one_second): Now static.
11047 (lock_file_1): Rename local to avoid shadowing.
11048
11049 * buffer.c (fix_overlays_before): Mark locals as initialized.
11050 (fix_start_end_in_overlays): Likewise. This function should be
11051 simplified by using pointers-to-pointers, but that's a different
11052 matter.
11053 (switch_to_buffer_1): Now static.
11054 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11055 (report_overlay_modification): Rename locals to avoid shadowing.
11056
11057 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11058 Fix pointer signedness issue.
11059 (sys_subshell): Mark local as volatile if checking for lint,
11060 to suppress a gcc -Wclobbered warning that does not seem to be right.
11061 (MAXPATHLEN): Define only if needed.
11062
11063 * process.c (serial_open, serial_configure): Move decls from here ...
11064 * systty.h: ... to here, so that they can be checked.
11065
11066 * fns.c (get_random, seed_random): Move extern decls from here ...
11067 * lisp.h: ... to here, so that they can be checked.
11068
11069 * sysdep.c (reset_io): Now static.
11070 (wait_for_termination_signal): Remove; unused.
11071
11072 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11073 (copy_keymap_item, append_key, push_text_char_description):
11074 Now static.
11075 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11076 (DENSE_TABLE_SIZE): Remove; unused.
11077 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11078 (describe_map_tree):
11079 Rename locals to avoid shadowing.
11080
11081 * keyboard.c: Declare functions static if they are not used elsewhere.
11082 (echo_char, echo_dash, cmd_error, top_level_2):
11083 (poll_for_input, handle_async_input): Now static.
11084 (read_char, kbd_buffer_get_event, make_lispy_position):
11085 (make_lispy_event, make_lispy_movement, apply_modifiers):
11086 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11087 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11088 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11089 (read_key_sequence, read_char): Mark locals as initialized.
11090 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11091
11092 * keyboard.h (make_ctrl_char): New decl.
11093 (mark_kboards): Move decl here ...
11094 * alloc.c (mark_kboards): ... from here.
11095
11096 * lisp.h (force_auto_save_soon): New decl.
11097
11098 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11099 (DEFINE_DUMMY_FUNCTION): New macro.
11100 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11101 Use it.
11102 (main): Add casts to avoid warnings
11103 if GCC considers string literals to be constants.
11104
11105 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11106
11107 * dbusbind.c: Pointer signedness fixes.
11108 (xd_signature, xd_append_arg, xd_initialize):
11109 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11110 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11111 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11112 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11113
11114 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11115 if GCC considers string literals to be constants.
11116 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11117
11118 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11119
11120 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11121 (print_preprocess, print_object): New macro to fix last change.
11122
11123 * print.c (print_preprocess): Don't forget font objects.
11124
11125 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11126
11127 * emacs.c (USAGE3): Doc fixes.
11128
11129 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11130
11131 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11132 structure.
11133
11134 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11135
11136 * lisp.h (VWindow_system, Qfile_name_history):
11137 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11138 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11139 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11140
11141 * w32select.c: Don't #include "keyboard.h".
11142 (run_protected): Add extern declaration for waiting_for_input.
11143
11144 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11145 * w32console.c (detect_input_pending, read_input_pending)
11146 (encode_terminal_code):
11147 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11148 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11149 (w32_system_caret_y, Qfile_name_history):
11150 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11151 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11152 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11153 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11154 * w32proc.c (Qlocal, report_file_error):
11155 * w32term.c (Vwindow_system, updating_frame):
11156 * w32uniscribe.c (initialized, uniscribe_font_driver):
11157 Remove unneeded extern declarations.
11158
11159 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11160
11161 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11162
11163 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11164
11165 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11166 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11167 These macros can no longer be used for assignment.
11168
11169 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11170 Assign struct members directly, instead of using BUF_BEGV etc.
11171 (record_buffer_markers, fetch_buffer_markers): New functions for
11172 recording and fetching special buffer markers.
11173 (set_buffer_internal_1, set_buffer_temp): Use them.
11174
11175 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11176
11177 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11178
11179 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11180 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11181
11182 * xdisp.c (hscroll_window_tree):
11183 (reconsider_clip_changes): Use PT instead of BUF_PT.
11184
11185 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11186
11187 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11188 $(EMACS_ROOT)/lib/intprops.h.
11189
11190 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11191
11192 Fix more problems found by GCC 4.5.2's static checks.
11193
11194 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11195 to unsigned char * to avoid compiler diagnostic.
11196 (xg_free_frame_widgets): Make it clear that a local variable is
11197 needed only if USE_GTK_TOOLTIP.
11198 (gdk_window_get_screen): Make it clear that this macro is needed
11199 only if USE_GTK_TOOLTIP.
11200 (int_gtk_range_get_value): New function, which avoids a diagnostic
11201 from gcc -Wbad-function-cast.
11202 (xg_set_toolkit_scroll_bar_thumb): Use it.
11203 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11204 diagnostic from gcc -Wbad-function-cast.
11205 (get_utf8_string, xg_get_file_with_chooser):
11206 Rename locals to avoid shadowing.
11207 (create_dialog): Move locals to avoid shadowing.
11208
11209 * xgselect.c (xg_select): Remove unused var.
11210
11211 * image.c (four_corners_best): Mark locals as initialized.
11212 (gif_load): Initialize transparent_p to zero (Bug#8238).
11213 Mark another local as initialized.
11214 (my_png_error, my_error_exit): Mark with NO_RETURN.
11215
11216 * image.c (clear_image_cache): Now static.
11217 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11218 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11219 (x_edge_detection): Remove unnecessary cast that
11220 gcc -Wbad-function-cast diagnoses.
11221 (gif_load): Fix pointer signedness.
11222 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11223 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11224
11225 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11226
11227 Improve quality of tests for time stamp overflow.
11228 For example, without this patch (encode-time 0 0 0 1 1
11229 1152921504606846976) returns the obviously-bogus value (-948597
11230 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11231 reports time overflow. See
11232 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11233 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11234 * editfns.c: Include limits.h and intprops.h.
11235 (TIME_T_MIN, TIME_T_MAX): New macros.
11236 (time_overflow): Move earlier, to before first use.
11237 (hi_time, lo_time): New functions, for an accurate test for
11238 out-of-range times.
11239 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11240 (Fget_internal_run_time): Don't assume time_t fits in int.
11241 (make_time): Use list2 instead of Fcons twice.
11242 (Fdecode_time): More accurate test for out-of-range times.
11243 (check_tm_member): New function.
11244 (Fencode_time): Use it, to test for out-of-range times.
11245 (lisp_time_argument): Don't rely on undefined left-shift and
11246 right-shift behavior when checking for time stamp overflow.
11247
11248 * editfns.c (time_overflow): New function, refactoring common code.
11249 (Fformat_time_string, Fdecode_time, Fencode_time):
11250 (Fcurrent_time_string): Use it.
11251
11252 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11253 * dired.c (make_time): Move to ...
11254 * editfns.c (make_time): ... here.
11255 * systime.h: Note the move.
11256
11257 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11258
11259 * fringe.c (update_window_fringes): Remove unused variables.
11260
11261 * unexmacosx.c (copy_data_segment): Also copy __got section.
11262 (Bug#8223)
11263
11264 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11265
11266 * termcap.c [MSDOS]: Include "msdos.h".
11267 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11268 Constify `char *' arguments and their references according to
11269 prototypes in tparam.h.
11270
11271 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11272
11273 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11274 Adapt all references accordingly.
11275
11276 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11277
11278 2011-03-11 Tom Tromey <tromey@redhat.com>
11279
11280 * buffer.c (syms_of_buffer): Remove obsolete comment.
11281
11282 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11283
11284 * termhooks.h (encode_terminal_code): Declare prototype.
11285
11286 * msdos.c (encode_terminal_code): Don't declare prototype.
11287
11288 * term.c (encode_terminal_code): Now external again, used by
11289 w32console.c and msdos.c.
11290
11291 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11292 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11293
11294 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11295
11296 Fix some minor problems found by GCC 4.5.2's static checks.
11297
11298 * fringe.c (update_window_fringes): Mark locals as initialized
11299 (Bug#8227).
11300 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11301
11302 * alloc.c (mark_fringe_data): Move decl from here ...
11303 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11304 to check its interface.
11305 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11306
11307 * fontset.c (free_realized_fontset): Now static.
11308 (Fset_fontset_font): Rename local to avoid shadowing.
11309 (fontset_font): Mark local as initialized.
11310 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11311
11312 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11313
11314 * xselect.c (x_disown_buffer_selections): Remove; not used.
11315 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11316 (x_own_selection, Fx_disown_selection_internal): Rename locals
11317 to avoid shadowing.
11318 (x_handle_dnd_message): Remove local to avoid shadowing.
11319
11320 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11321 so that the caller can use some name other than gcpro1.
11322 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11323 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11324 (Fx_backspace_delete_keys_p):
11325 Use them to avoid shadowing, and rename vars to avoid shadowing.
11326 (x_decode_color, x_set_name, x_window): Now static.
11327 (Fx_create_frame): Add braces to silence GCC warning.
11328 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11329 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11330 Remove unused locals.
11331 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11332 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11333 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11334 macros.
11335
11336 * xterm.h (x_mouse_leave): New decl.
11337
11338 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11339 Remove unused functions.
11340 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11341 (x_calc_absolute_position): Now static.
11342 (XTread_socket): Don't define label "out" unless it's used.
11343 Don't declare local "event" unless it's used.
11344 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11345 unless they are used.
11346 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11347 (x_fatal_error_signal): Remove; not used.
11348 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11349 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11350 (x_error_catcher, x_connection_closed, x_error_handler):
11351 (x_error_quitter, xembed_send_message, x_iconify_frame):
11352 (my_log_handler): Rename locals to avoid shadowing.
11353 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11354 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11355
11356 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11357 Rename or move locals to avoid shadowing.
11358 (tty_defined_color, merge_face_heights): Now static.
11359 (free_realized_faces_for_fontset): Remove; not used.
11360 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11361 does not deduce is never used uninitialized.
11362 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11363 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11364
11365 * terminal.c (store_terminal_param): Now static.
11366
11367 * xmenu.c (menu_highlight_callback): Now static.
11368 (set_frame_menubar): Remove unused local.
11369 (xmenu_show): Rename parameter to avoid shadowing.
11370 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11371 since they might point to immutable storage.
11372 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11373 since it's unused otherwise.
11374
11375 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11376 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11377 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11378 avoids a gcc -Wuninitialized diagnostic.
11379 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11380 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11381 does not deduce are never used uninitialized.
11382
11383 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11384
11385 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11386 * window.c (window_loop, size_window):
11387 (run_window_configuration_change_hook, enlarge_window): Likewise.
11388
11389 * window.c (display_buffer): Now static.
11390 (size_window): Mark variables that gcc -Wuninitialized
11391 does not deduce are never used uninitialized.
11392 * window.h (check_all_windows): New decl, to forestall
11393 gcc -Wmissing-prototypes diagnostic.
11394 * dispextern.h (bidi_dump_cached_states): Likewise.
11395
11396 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11397 shadowing.
11398 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11399 Include <limits.h>.
11400 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11401 and to avoid gcc -Wuninitialized warning.
11402 (load_charset_map): Mark variables that gcc -Wuninitialized
11403 does not deduce are never used uninitialized.
11404 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11405
11406 * coding.c (coding_set_source, coding_set_destination):
11407 Use "else { /* comment */ }" rather than "else /* comment */;"
11408 for clarity, and to avoid gcc -Wempty-body warning.
11409 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11410 a block, when the outer 'i' will do.
11411 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11412 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11413 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11414 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11415 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11416 Rename locals to avoid shadowing.
11417 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11418 * coding.c (emacs_mule_char, encode_invocation_designation):
11419 Now static, since they're not used elsewhere.
11420 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11421 (decode_coding_object, encode_coding_object, detect_coding_system):
11422 (decode_coding_emacs_mule): Mark variables that gcc
11423 -Wuninitialized does not deduce are never used uninitialized.
11424 (detect_coding_iso_2022): Initialize a local variable that might
11425 be used uninitialized. Leave a FIXME because it's not clear that
11426 this initialization is needed. (Bug#8211)
11427 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11428 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11429 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11430 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11431 Remove unused macros.
11432
11433 * category.c (hash_get_category_set): Remove unused local var.
11434 (copy_category_table): Now static, since it's not used elsewhere.
11435 * character.c (string_count_byte8): Likewise.
11436
11437 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11438 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11439
11440 * chartab.c (copy_sub_char_table): Now static, since it's not used
11441 elsewhere.
11442 (sub_char_table_ref_and_range, char_table_ref_and_range):
11443 Rename locals to avoid shadowing.
11444 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11445
11446 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11447 (BIDI_BOB): Remove unused macro.
11448
11449 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11450 deduce are never used uninitialized.
11451 * term.c (encode_terminal_code): Likewise.
11452
11453 * term.c (encode_terminal_code): Now static. Remove unused local.
11454
11455 * tparam.h: New file.
11456 * term.c, tparam.h: Include it.
11457 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11458 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11459 Move these decls to tparam.h, and make them agree with what
11460 is actually in tparam.c. The previous trick of using incompatible
11461 decls in different modules does not conform to the C standard.
11462 All callers of tparam changed to use tparam's actual API.
11463 * tparam.c (tparam1, tparam, tgoto):
11464 Use const pointers where appropriate.
11465
11466 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11467 * cm.h (struct cm): Likewise.
11468 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11469 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11470 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11471 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11472 (turn_on_face, init_tty): Likewise.
11473 * termchar.h (struct tty_display_info): Likewise.
11474
11475 * term.c (term_mouse_position): Rename local to avoid shadowing.
11476
11477 * alloc.c (mark_ttys): Move decl from here ...
11478 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11479
11480 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11481
11482 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11483
11484 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11485
11486 * search.c (compile_pattern_1): Remove argument regp, unused since
11487 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11488 (compile_pattern): Don't pass it.
11489
11490 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11491
11492 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11493 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11494 for ! HAVE_GTK3.
11495 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11496
11497 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11498
11499 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11500 gdk_window_get_screen, gdk_window_get_geometry,
11501 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11502 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11503 (xg_get_pixbuf_from_pixmap): New function.
11504 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11505 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11506 Call xg_get_pixbuf_from_pixmap instead of
11507 gdk_pixbuf_get_from_drawable.
11508 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11509 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11510 (xg_check_special_colors): Use GtkStyleContext and its functions
11511 for HAVE_GTK3.
11512 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11513 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11514 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11515 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11516 Call gtk_widget_get_preferred_size.
11517 (xg_frame_resized): gdk_window_get_geometry only takes 5
11518 parameters.
11519 (xg_win_to_widget, xg_event_is_for_menubar):
11520 Call gdk_x11_window_lookup_for_display.
11521 (xg_set_widget_bg): New function.
11522 (delete_cb): New function.
11523 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11524 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11525 (xg_set_background_color): Call xg_set_widget_bg.
11526 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11527 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11528 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11529 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11530 if ! HAVE_GTK3.
11531 (update_frame_tool_bar): Call gtk_widget_hide.
11532 (xg_initialize): Use GDK_KEY_g.
11533
11534 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11535 if ! HAVE_GTK3
11536 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11537
11538 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11539 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11540 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11541
11542 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11543
11544 * w32xfns.c (select_palette): Check success of RealizePalette against
11545 GDI_ERROR, not zero.
11546
11547 See ChangeLog.11 for earlier changes.
11548
11549 ;; Local Variables:
11550 ;; coding: utf-8
11551 ;; End:
11552
11553 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11554
11555 This file is part of GNU Emacs.
11556
11557 GNU Emacs is free software: you can redistribute it and/or modify
11558 it under the terms of the GNU General Public License as published by
11559 the Free Software Foundation, either version 3 of the License, or
11560 (at your option) any later version.
11561
11562 GNU Emacs is distributed in the hope that it will be useful,
11563 but WITHOUT ANY WARRANTY; without even the implied warranty of
11564 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11565 GNU General Public License for more details.
11566
11567 You should have received a copy of the GNU General Public License
11568 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.