]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Fix random crashes while scrolling backwards.
[gnu-emacs] / src / ChangeLog
1 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4 past the beginning of the current glyph matrix.
5
6 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
7
8 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
10 HAVE_GTK3 (Bug#9869).
11
12 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
13 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
14
15 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
16
17 * xterm.c: Declare x_handle_net_wm_state to return int.
18 (handle_one_xevent): Check if we are iconified but don't have
19 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
20 (get_current_wm_state): Return non-zero if not hidden,
21 check for _NET_WM_STATE_HIDDEN (Bug#9893).
22 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
23 (x_handle_net_wm_state): Return what get_current_wm_state returns.
24 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
25
26 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
27
28 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
29 so that this new function doesn't get optimized away by a
30 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
31
32 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
33
34 * frame.h (MOUSE_HL_INFO): Remove excess parens.
35
36 2011-10-29 Eli Zaretskii <eliz@gnu.org>
37
38 Fix the `xbytecode' command.
39 * .gdbinit (xprintbytestr): New command.
40 (xwhichsymbols): Renamed from `which'; all callers changed.
41 (xbytecode): Print the byte-code string as well.
42
43 2011-10-29 Kim Storm <storm@cua.dk>
44
45 * alloc.c (which_symbols): New function.
46
47 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
48
49 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
50 line. (Bug#9903)
51
52 2011-10-29 Glenn Morris <rgm@gnu.org>
53
54 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
55 Not clear what it was for, and it causes various bugs. (Bug#9839)
56
57 2011-10-28 Eli Zaretskii <eliz@gnu.org>
58
59 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
60 possible random value that matches one of those tested as
61 condition to clear the mouse face.
62
63 2011-10-28 Chong Yidong <cyd@gnu.org>
64
65 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
66
67 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
68
69 * window.c (make_window): Initialize phys_cursor_on_p.
70
71 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
72
73 * lisp.h (struct Lisp_Symbol): Update comments.
74
75 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
76
77 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
78
79 2011-10-28 Eli Zaretskii <eliz@gnu.org>
80
81 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
82 <oslsachem@gmail.com> for helping to debug this.
83
84 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
85 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
86 (g_b_init_get_glyph_outline_w): New static variables.
87 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
88 (GetGlyphOutlineW_Proc): New typedefs.
89 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
90 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
91 New functions.
92 (w32font_open_internal, compute_metrics):
93 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
94 instead of calling the "wide" APIs directly.
95
96 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
97
98 * w32.h (syms_of_w32font): Add prototype.
99
100 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
101
102 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
103 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
104 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
105 (Fmove_to_window_line): Doc fix.
106
107 2011-10-27 Chong Yidong <cyd@gnu.org>
108
109 * process.c (make_process): Set gnutls_state to NULL.
110
111 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
112 non-NULL, regardless of GNUTLS_INITSTAGE.
113 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
114 an error. Set process slots as soon as we allocate them.
115
116 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
117
118 2011-10-27 Chong Yidong <cyd@gnu.org>
119
120 * gnutls.c (emacs_gnutls_deinit): New function.
121 Deallocate credentials structures as well as calling gnutls_deinit.
122 (Fgnutls_deinit, Fgnutls_boot): Use it.
123
124 * process.c (make_process): Initialize GnuTLS credentials to NULL.
125 (deactivate_process): Call emacs_gnutls_deinit.
126
127 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
128
129 * image.c (x_create_x_image_and_pixmap):
130 * w32.c (sys_rename, w32_delayed_load):
131 * w32font.c (fill_in_logfont):
132 * w32reg.c (x_get_string_resource): Silence compiler warnings.
133
134 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
135
136 * w32fns.c (w32_default_color_map): New function,
137 extracted from Fw32_default_color_map.
138 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
139
140 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
141
142 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
143
144 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
145
146 * keyboard.c (test_undefined): New function (bug#9751).
147 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
148
149 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
150
151 * sysdep.c (init_sys_modes): Fix the check for the controlling
152 terminal (Bug#6649).
153
154 2011-10-20 Eli Zaretskii <eliz@gnu.org>
155
156 * dispextern.h (struct bidi_it): New member next_en_type.
157
158 * bidi.c (bidi_line_init): Initialize the next_en_type member.
159 (bidi_resolve_explicit_1): When next_en_pos is valid for the
160 current character, check also for next_en_type being WEAK_EN.
161 (bidi_resolve_weak): Don't enter the expensive loop if the current
162 position is before next_en_pos. Record the bidi type of the first
163 non-ET, non-BN character we find, in addition to its position.
164 (bidi_level_of_next_char): Invalidate next_en_type when
165 next_en_pos is over-stepped.
166
167 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
168
169 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
170 * editfns.c: Rewrite current-time-zone so that it invokes
171 the equivalent of (format-time-string "%Z") to get the time zone name.
172 This fixes a bug when the time zone name contains characters that
173 need converting from the system time locale to Emacs internal format.
174 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
175 that patch fixed format-time-string to do the conversion, but
176 I forgot to fix current-time-zone.
177 (format_time_string): New function, containing most of
178 what Fformat_time_string used to contain.
179 (Fformat_time_string): Rewrite in terms of format_time_string.
180 This doesn't change this function's behavior.
181 (current-time-zone): Rewrite to use format_time_string.
182 This fixes the bug reported by Michael Schierl in
183 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
184 Jason Rumney's 2007-06-07 change worked around this bug, but
185 didn't fix it.
186 * systime.h (tzname, timezone): Remove no-longer-used declarations.
187
188 2011-10-19 Eli Zaretskii <eliz@gnu.org>
189
190 * xdisp.c (start_display): If the character at POS is displayed
191 via a display vector, reset IT->current.dpvec_index to zero.
192 (try_window_reusing_current_matrix): If a line ends in a display
193 vector or the next line starts in a display vector, continue
194 redrawing the window even though the character position of
195 start_row was reached.
196 (Bug#9771, part 2)
197
198 2011-10-18 Chong Yidong <cyd@gnu.org>
199
200 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
201 with nobreak-char-display too.
202
203 2011-10-18 Eli Zaretskii <eliz@gnu.org>
204
205 Fix part 3 of bug#9771.
206 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
207 (bidi_resolve_neutral): Don't enter the expensive loop looking for
208 non-neutral characters if the current character is a paragraph
209 separator (a.k.a. Newline). This avoids running the same
210 expensive loop twice, once when we consume the preceding newline
211 and the other time when the line actually needs to be displayed.
212 Avoid the loop when we see neutrals on the base embedding level
213 following a character whose directionality is the same as the
214 paragraph's. This avoids running the expensive loop when a line
215 ends in a long sequence of neutrals, like control characters.
216 Add assertion against STRONG_AL type. Slightly rearrange code
217 that determines the type of a neutral given the first non-neutral
218 that follows it.
219 (bidi_level_of_next_char): Set next_en_pos to zero when
220 invalidating its info.
221
222 2011-10-17 Eli Zaretskii <eliz@gnu.org>
223
224 * xdisp.c (push_display_prop): Determine whether to record string
225 or buffer position by IT->string, not by IT->method. Allow
226 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
227 (move_it_vertically_backward): Don't look for character position
228 immediately after the newline when in a continuation line.
229 (Bug#9771, part 1)
230
231 2011-10-15 Martin Rudalics <rudalics@gmx.at>
232
233 * window.c (coordinates_in_window): Rewrite and delabelize
234 vertical border check. (Bug#5357) (Bug#9618)
235
236 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
237
238 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
239 errors in XSetWindowBorder (bug#9310).
240
241 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
242
243 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
244 avoid crash when xmalloc overrun checking is enabled.
245
246 2011-10-13 Eli Zaretskii <eliz@gnu.org>
247
248 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
249 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
250 cursor motion with <left> and <right> arrow keys.
251
252 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
253 some callers set that themselves.
254
255 2011-10-12 Eli Zaretskii <eliz@gnu.org>
256
257 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
258 display string and the previous row comes from the same string and
259 is empty. (Bug#9739) (Bug#9738)
260
261 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
262
263 * doc.c (get_doc_string): Encode file name (bug#9735).
264
265 2011-10-12 Eli Zaretskii <eliz@gnu.org>
266
267 * bidi.c (bidi_level_of_next_char):
268 * xdisp.c (get_visually_first_element): Remove old incorrect
269 comments regarding the Unicode Line Separator character.
270
271 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
272
273 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
274
275 * alloc.c (Fgc_status): Do not access beyond zombies array
276 boundary if nzombies > MAX_ZOMBIES.
277 * alloc.c (dump_zombies): Add missing format specifier.
278
279 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
280
281 * xdisp.c (set_cursor_from_row): Simplify conditionals,
282 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
283
284 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
285 Some packages use them to denote characters with modifiers.
286
287 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
288
289 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
290 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
291 matching a pp-number. Rename parameter var to var1.
292
293 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
294
295 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
296
297 2011-10-08 Glenn Morris <rgm@gnu.org>
298
299 * callint.c (Fcall_interactively): Give a more explicit error for the
300 'c' case with a non-character input. (Bug#8479)
301
302 2011-10-08 Eli Zaretskii <eliz@gnu.org>
303
304 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
305 lines.
306 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
307 lines that are hscrolled on the left.
308
309 * dispnew.c (buffer_posn_from_coords): Account for a possible
310 presence of header-line. (Bug#4426)
311
312 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
313
314 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
315 Don't advertise functionality which we discourage or doesn't work.
316
317 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
318
319 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
320 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
321 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
322 this makes Emacs dump core during garbage collection on rare
323 occasions. sizeof is obviously inferior to offsetof here, so
324 stick with offsetof.
325 (GC_POINTER_ALIGNMENT): New macro.
326 (mark_memory): Omit 3rd (offset) arg; caller changed.
327 Don't assume EMACS_INT alignment is the same as pointer alignment.
328
329 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
330
331 * keyboard.c (read_key_sequence_remapped): New var.
332 (read_key_sequence): Compute remapping in the right buffer.
333 (command_loop_1): Use read_key_sequence's remapping directly.
334
335 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
336
337 * dired.c (file_name_completion): Don't expand file name.
338 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
339 before checking file name handler.
340
341 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
342 they've been requested explicitly (bug#9591).
343
344 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
345
346 * keymap.c (Fsingle_key_description): Use make_specified_string
347 instead of build_string to build string from push_key_description.
348 (Bug#5193)
349
350 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
351
352 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
353 This fixes a Y2038 bug on 64-bit hosts.
354 * buffer.c (reset_buffer):
355 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
356 (Fclear_buffer_auto_save_failure):
357 Use 0, not -1, to represent an unset failure time, since time_t
358 might not be signed.
359
360 Remove dependency on glibc malloc internals.
361 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
362 Move back here from lisp.h, but with their new implementations.
363 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
364 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
365 * charset.c (charset_table_init): New static var.
366 (syms_of_charset): Use it instead of xmalloc. This removes a
367 dependency on glibc malloc internals. See Eli Zaretskii's comment in
368 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
369 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
370 Move back to alloc.c.
371 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
372 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
373
374 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
375
376 * nsterm.m (windowDidResize): Call x_set_window_size only when
377 ns_in_resize is true. Otherwise set pixelwidth/height and
378 call change_frame_size (Bug#9628).
379
380 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
381
382 Port --enable-checking=all to Fedora 14 x86-64.
383 * charset.c (syms_of_charset): Also account for glibc malloc's
384 internal overhead when calculating the initial malloc maximum.
385
386 Port --enable-checking=all to Fedora 14 x86.
387 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
388 Move to lisp.h.
389 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
390 (overrun_check_realloc, overrun_check_free):
391 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
392 That way, xmalloc returns a properly-aligned pointer even if
393 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
394 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
395 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
396 into account when calculating the initial malloc maximum.
397 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
398 Move here from alloc.c, so that charset.c can use it too.
399 Properly align; the old code wasn't right for common 32-bit hosts
400 when configured with --enable-checking=all.
401 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
402 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
403
404 2011-09-29 Eli Zaretskii <eliz@gnu.org>
405
406 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
407 use EDOM.
408
409 2011-09-28 Eli Zaretskii <eliz@gnu.org>
410
411 * xdisp.c (compute_display_string_end): If there's no display
412 string at CHARPOS, return -1.
413
414 * bidi.c (bidi_fetch_char): When compute_display_string_end
415 returns a negative value, treat the character as a normal
416 character not covered by a display string. (Bug#9624)
417
418 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
419
420 * lread.c (Fread_from_string): Fix typo in docstring.
421
422 2011-09-27 Eli Zaretskii <eliz@gnu.org>
423
424 * xdisp.c (handle_invisible_prop): If invisible text ends on a
425 newline, reseat the iterator instead of bidi-iterating there one
426 character at a time. (Bug#9610)
427 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
428 TO_CHARPOS if the bidi iterator is at base embedding level.
429
430 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
431
432 * lread.c (readevalloop): Use correct code for NBSP.
433 (read1): Likewise. (Bug#9608)
434
435 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
436
437 * dbusbind.c (Fdbus_register_signal): When service is not
438 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
439
440 2011-09-25 Glenn Morris <rgm@gnu.org>
441
442 * buffer.c (truncate-lines): Doc fix.
443
444 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
445
446 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
447 (Fset_window_next_buffers): Doc fix.
448
449 2011-09-24 Glenn Morris <rgm@gnu.org>
450
451 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
452
453 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
454
455 Fix minor problems found by static checking.
456 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
457 * indent.c (Fvertical_motion): Fix == vs = typo.
458
459 2011-09-24 Eli Zaretskii <eliz@gnu.org>
460
461 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
462 Default value is now t. Doc fix.
463
464 * indent.c (Fvertical_motion): Compute and apply the overshoot
465 logic when moving up, not only when moving down. Fix the
466 confusing name and values of the it_overshoot_expected variable;
467 logic changes accordingly. (Bug#9254) (Bug#9549)
468
469 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
470 CHARPOS is covered by a display string which includes newlines.
471 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
472 is covered by a display string with embedded newlines.
473
474 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
475
476 * dbusbind.c (Fdbus_register_signal): Add match rule to
477 Vdbus_registered_objects_table. (Bug#9581)
478 (Fdbus_register_method, Vdbus_registered_objects_table):
479 Fix docstring.
480
481 2011-09-24 Jim Meyering <meyering@redhat.com>
482
483 do not ignore write error for any output size
484 The previous change was incomplete.
485 While it makes emacs --batch detect the vast majority of stdout
486 write failures, errors were still ignored whenever the output size is
487 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
488 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
489 && echo FAIL: ignored write error
490 FAIL: ignored write error
491 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
492 && echo FAIL: ignored write error
493 FAIL: ignored write error
494 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
495
496 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
497
498 * emacs.c (Fkill_emacs): In noninteractive mode exit
499 non-successfully if a write error occurred on stdout. (Bug#9574)
500
501 2011-09-21 Eli Zaretskii <eliz@gnu.org>
502
503 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
504 the xassert test.
505
506 * dispextern.h (struct it): Update the comment documenting what
507 can it->OBJECT be.
508
509 2011-09-20 Eli Zaretskii <eliz@gnu.org>
510
511 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
512 a display string, extend search for cursor position to end of row.
513 (find_row_edges): If the row ends in a newline from a display
514 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
515 Handle the case of a display string with multiple newlines.
516 (Fcurrent_bidi_paragraph_direction): Fix search for previous
517 non-empty line. Fixes confusing cursor motion with arrow keys at
518 the beginning of a line that starts with whitespace.
519
520 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
521
522 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
523 (bug#9493).
524
525 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
526
527 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
528 boolean (Bug#9154).
529
530 2011-09-18 Eli Zaretskii <eliz@gnu.org>
531
532 * xdisp.c (display_line): Record maximum and minimum buffer
533 positions even if no glyphs were produced (e.g., by a zero-width
534 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
535 buffer positions that will be removed from the glyph row because
536 they don't fit.
537 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
538 column is beyond frame width: don't subtract 1 "pixel" when
539 computing width of the stretch.
540 (reseat_at_next_visible_line_start): Undo the change made on
541 2011-09-17 that saved paragraph information and restored it after
542 the call to `reseat'. (Bug#9545)
543
544 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
545
546 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
547 and turn window cursor on if cleared (Bug#9415).
548
549 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
550
551 * search.c (boyer_moore): Take unibyte characters from pattern
552 literally. (Bug#9458)
553
554 2011-09-18 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
557
558 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
559
560 Fix minor problem found by static checking.
561 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
562 initialized, to pacify gcc -Wuninitialized.
563
564 * fileio.c: Report proper errno when syscall falls.
565 (Finsert_file_contents): Save and restore errno,
566 so that report_file_error outputs the correct diagnostic.
567 (Fwrite_region) [CLASH_DETECTION]: Likewise.
568
569 2011-09-18 Eli Zaretskii <eliz@gnu.org>
570
571 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
572
573 2011-09-17 Eli Zaretskii <eliz@gnu.org>
574
575 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
576 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
577
578 2011-09-17 Eli Zaretskii <eliz@gnu.org>
579
580 * xdisp.c (reseat_at_next_visible_line_start): Keep information
581 about the current paragraph and restore it after the call to reseat.
582
583 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
584 (bidi_find_paragraph_start): Search back for paragraph beginning
585 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
586 (bidi_move_to_visually_next): Only trigger paragraph-related
587 computations when the last character is a newline or at EOB, not
588 just any NEUTRAL_B. (Bug#9470)
589
590 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
591 truncated lines if point is covered by a display string. (Bug#9524)
592
593 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
594
595 * xselect.c: Relax test for outgoing X longs (Bug#9498).
596 (cons_to_x_long): New function.
597 (lisp_data_to_selection_data): Use it. Correct the test for
598 short-versus-long data; it was negated. Break out of vector
599 loop, for efficiency, when a long datum is discovered.
600
601 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
602
603 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
604
605 2011-09-16 Eli Zaretskii <eliz@gnu.org>
606
607 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
608 GCC PR/17406) by declaring this function with external scope.
609
610 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
611
612 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
613 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
614
615 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
616
617 * editfns.c (Fformat): Correctly handle text properties on "%%".
618
619 2011-09-15 Eli Zaretskii <eliz@gnu.org>
620
621 * xterm.c (x_draw_composite_glyph_string_foreground):
622 * w32term.c (x_draw_composite_glyph_string_foreground):
623 * term.c (encode_terminal_code):
624 * composite.c (composition_update_it, get_composition_id):
625 * xdisp.c (get_next_display_element)
626 (fill_composite_glyph_string): Add comments about special meaning
627 of TAB characters in a composition.
628
629 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
630
631 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
632 This occurs when processing a multibyte format.
633 Problem reported by Wolfgang Jenker.
634
635 2011-09-15 Johan Bockgård <bojohan@gnu.org>
636
637 * xdisp.c (try_cursor_movement): Only check for exact match if
638 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
639
640 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
641
642 Remove unused external symbols.
643 * dispextern.h (calc_pixel_width_or_height): Remove decl.
644 * xdisp.c (calc_pixel_width_or_height): Now static.
645 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
646 * indent.c (check_display_width):
647 * w32term.c: Fix comment to match code.
648 * xterm.c, xterm.h (x_catching_errors): Remove.
649
650 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
651
652 * xselect.c: Use signed conversions more consistently (Bug#9498).
653 (selection_data_to_lisp_data): Assume incoming selection data are
654 signed integers, not unsigned. This is to be consistent with
655 outgoing selection data, which was modified to use signed integers
656 in as part of the fix to Bug#9196 in response to Jan D.'s comment
657 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
658 expects long, not unsigned long.
659
660 2011-09-14 Eli Zaretskii <eliz@gnu.org>
661
662 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
663 computation of loop end. Reported by Johan Bockgård
664 <bojohan@gnu.org>.
665
666 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
667
668 * frame.c (Fother_visible_frames_p): Function deleted.
669
670 2011-09-12 Eli Zaretskii <eliz@gnu.org>
671
672 * indent.c (compute_motion): Process display vector front to back
673 rather than the other way around. (Bug#2496)
674
675 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
676
677 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
678
679 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
680
681 * minibuf.c (Fread_from_minibuffer): Doc fix.
682
683 2011-09-11 Eli Zaretskii <eliz@gnu.org>
684
685 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
686 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
687
688 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
689
690 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
691 value for non-existent files.
692
693 2011-09-11 Eli Zaretskii <eliz@gnu.org>
694
695 * fileio.c (Finsert_file_contents): If the file cannot be opened,
696 set its "size" to -1. This will set the modtime_size field of
697 the corresponding buffer to -1, which is what
698 verify-visited-file-modtime expects for files that do not exist.
699 (Bug#9139)
700
701 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
702
703 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
704 here ...
705 * lisp.h: ... from here. push_key_description is no longer
706 defined in keyboard.c, so its declaration should not be in
707 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
708 logically belongs with push_key_description.
709
710 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
711
712 * buffer.h: Include <sys/types.h> instead of <time.h>.
713 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
714 Problem reported by Herbert J. Skuhra.
715
716 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
717
718 * xml.c (parse_region): Make the parsing work for
719 non-comment-starting XML files again (bug#9144).
720
721 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
722
723 * image.c (gif_load): Fix calculation of bottom and right corner.
724 (Bug#9468)
725
726 2011-09-10 Eli Zaretskii <eliz@gnu.org>
727
728 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
729 redisplay in small windows.
730
731 2011-09-09 Eli Zaretskii <eliz@gnu.org>
732
733 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
734
735 2011-09-08 Martin Rudalics <rudalics@gmx.at>
736
737 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
738 Operate on live windows only.
739
740 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
741
742 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
743
744 2011-09-07 Eli Zaretskii <eliz@gnu.org>
745
746 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
747 only under bidi iteration.
748
749 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
750
751 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
752
753 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
754
755 isnan: Fix porting problem to Solaris 10 with bundled gcc.
756 Without this fix, the command to link temacs failed due to an
757 undefined symbol __builtin_isnan. This is because
758 /usr/include/iso/math_c99.h #defines isnan(x) to
759 __builtin_isnan(x), but the bundled gcc, which identifies itself
760 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
761 a __builtin_isnan.
762 * floatfns.c (isnan): #undef, and then #define to a clone of
763 what's in data.c.
764 (Fisnan): Always define, since it's always available now.
765 (syms_of_floatfns): Always define isnan at the Lisp level.
766
767 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
768
769 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
770
771 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
772
773 * fileio.c: Fix bugs with large file offsets (Bug#9428).
774 The previous code assumed that file offsets (off_t values) fit in
775 EMACS_INT variables, which is not true on typical 32-bit hosts.
776 The code messed up by falsely reporting buffer overflow in cases
777 such as (insert-file-contents "big" nil 1 2) into an empty buffer
778 when "big" contains more than 2**29 bytes, even though this
779 inserts just one byte and does not overflow the buffer.
780 (Finsert_file_contents): Store file offsets as off_t
781 values, not as EMACS_INT values. Check for overflow when
782 converting between EMACS_INT and off_t. When checking for
783 buffer overflow or for overlap, take the offsets into account.
784 Don't use EMACS_INT for small values where int suffices.
785 When checking for overlap, fix a typo: ZV was used where
786 ZV_BYTE was intended.
787 (Fwrite_region): Don't assume off_t fits into 'long'.
788 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
789
790 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
791
792 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
793
794 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
795
796 sprintf-related integer and memory overflow issues (Bug#9412).
797
798 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
799 (esprintf, exprintf, evxprintf): New functions.
800 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
801 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
802 (modify_event_symbol): Do not assume that the length of
803 name_alist_or_stem is safe to alloca and fits in int.
804 (Fexecute_extended_command): Likewise for function name and binding.
805 (Frecursion_depth): Wrap around reliably on integer overflow.
806 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
807 since some callers pass EMACS_INT values.
808 (Fsingle_key_description): Don't crash if symbol name contains more
809 than MAX_ALLOCA bytes.
810 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
811 (get_minibuffer): Arg is now EMACS_INT, not int.
812 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
813 (esprintf, exprintf, evxprintf): New decls.
814 * window.h (command_loop_level, minibuf_level): Reflect API changes.
815
816 * dbusbind.c (signature_cat): New function.
817 (xd_signature, Fdbus_register_signal):
818 Do not overrun buffer; instead, report string overflow.
819
820 * dispnew.c (add_window_display_history): Don't overrun buffer.
821 Truncate instead; this is OK since it's just a log.
822
823 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
824 even if the time zone offset is outlandishly large.
825 Don't mishandle offset == INT_MIN.
826
827 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
828 when creating daemon; the previous buffer-overflow check was incorrect.
829
830 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
831 which has the guts of the old verror function.
832
833 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
834 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
835
836 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
837 (font_unparse_xlfd): Don't blindly alloca long strings.
838 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
839 fits in int, when using sprintf. Use single snprintf to count
840 length of string rather than counting it via multiple sprintfs;
841 that's simpler and more reliable.
842 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
843 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
844 sprintf, in case result does not fit in int.
845
846 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
847 (fontset_from_font): Print it.
848
849 * frame.c (tty_frame_count): Now printmax_t, not int.
850 (make_terminal_frame, set_term_frame_name): Print it.
851 (x_report_frame_params): In X, window IDs are unsigned long,
852 not signed long, so print them as unsigned.
853 (validate_x_resource_name): Check for implausibly long names,
854 and don't assume name length fits in 'int'.
855 (x_get_resource_string): Don't blindly alloca invocation name;
856 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
857 not fit in int.
858
859 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
860 (xg_check_special_colors, xg_set_geometry):
861 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
862
863 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
864 Use esprintf, not sprintf, in case result does not fit in int.
865
866 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
867 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
868 it as a large positive number.
869 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
870 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
871
872 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
873 in case result does not fit in int.
874
875 * print.c (float_to_string): Detect width overflow more reliably.
876 (print_object): Make sprintf buffer a bit bigger, to avoid potential
877 buffer overrun. Don't assume list length fits in 'int'. Treat
878 print length of 0 as 0, not as infinity; to be consistent with other
879 uses of print length in this function. Don't overflow print length
880 index. Don't assume hash table size fits in 'long', or that
881 vectorlike size fits in 'unsigned long'.
882
883 * process.c (make_process): Use printmax_t, not int, to format
884 process-name gensyms.
885
886 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
887
888 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
889 to avoid potential buffer overrun.
890
891 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
892 if X resource line is longer than 512 bytes.
893
894 * xfns.c (x_window): Make sprintf buffer a bit bigger
895 to avoid potential buffer overrun.
896
897 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
898
899 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
900
901 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
902
903 Integer overflow fixes for scrolling, etc.
904 Without these, Emacs silently mishandles large integers sometimes.
905 For example, "C-u 4294967297 M-x recenter" was treated as if
906 it were "C-u 1 M-x recenter" on a typical 64-bit host.
907
908 * xdisp.c (try_window_id): Check Emacs fixnum range before
909 converting to 'int'.
910
911 * window.c (window_scroll_line_based, Frecenter):
912 Check that an Emacs fixnum is in range before assigning it to 'int'.
913 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
914 values converted from Emacs fixnums.
915 (Frecenter): Don't wrap around a line count if it is out of 'int'
916 range; instead, treat it as an extreme value.
917 (Fset_window_configuration, compare_window_configurations):
918 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
919
920 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
921 that can exceed INT_MAX. Check that EMACS_INT value is in range
922 before assigning it to the (possibly-narrower) index.
923 (match_limit): Don't assume that a fixnum can fit in 'int'.
924
925 * print.c (print_object): Use ptrdiff_t, not int, for index that can
926 exceed INT_MAX.
927
928 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
929 (Fvertical_motion): Don't wrap around LINES values that don't fit
930 in 'int'. Instead, treat them as extreme values. This is good
931 enough for windows, which can't have more than INT_MAX lines anyway.
932
933 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
934
935 * Require libxml/parser.h to avoid compilation warning.
936
937 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
938
939 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
940 since this reportedly can destroy thread storage.
941
942 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
943
944 * syntax.c (find_defun_start): Update all cache variables if
945 exiting early (Bug#9401).
946
947 2011-08-30 Eli Zaretskii <eliz@gnu.org>
948
949 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
950
951 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
952 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
953 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
954
955 * term.c (tty_append_glyph): New function.
956 (produce_stretch_glyph): Static function and its prototype deleted.
957
958 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
959 Add prototypes.
960
961 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
962
963 * image.c (parse_image_spec): Check for nonnegative, not for positive,
964 when checking :margin (Bug#9390).
965 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
966 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
967 so that the name doesn't mislead. All uses changed.
968
969 2011-08-28 Johan Bockgård <bojohan@gnu.org>
970
971 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
972 set_tty_hooks.
973
974 2011-08-27 Eli Zaretskii <eliz@gnu.org>
975
976 * xdisp.c (move_it_to): Don't bail out early when reaching
977 position beyond to_charpos, if we are scanning backwards.
978 (move_it_vertically_backward): When DY == 0, make sure we get to
979 the first character in the line after the newline.
980
981 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
982
983 * ccl.c: Improve and simplify overflow checking (Bug#9196).
984 (ccl_driver): Do not generate an out-of-range pointer.
985 (Fccl_execute_on_string): Remove unnecessary check for
986 integer overflow, noted by Stefan Monnier in
987 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
988 Remove a FIXME that didn't need fixing.
989 Simplify the newly-introduced buffer reallocation code.
990
991 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
992
993 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
994
995 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
996
997 Integer and memory overflow issues (Bug#9196).
998
999 * doc.c (get_doc_string): Rework so that
1000 get_doc_string_buffer_size is the actual buffer size, rather than
1001 being 1 less than the actual buffer size; this makes xpalloc more
1002 convenient.
1003
1004 * image.c (x_allocate_bitmap_record, cache_image):
1005 * xselect.c (Fx_register_dnd_atom):
1006 Simplify previous changes by using xpalloc.
1007
1008 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1009 since either will do and ptrdiff_t is convenient with xpalloc.
1010
1011 * charset.c (charset_table_size)
1012 (struct charset_sort_data.priority): Now ptrdiff_t.
1013 (charset_compare): Don't overflow if priorities differ greatly.
1014 (Fsort_charsets): Don't assume list length fits in int.
1015 Check for size-calculation overflow when allocating sort data.
1016 (syms_of_charset): Allocate an initial charset table that is
1017 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1018
1019 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1020
1021 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1022 The actual value is always <= INT_MAX, and leaving it unsigned made
1023 overflow checking harder.
1024
1025 * dispextern.h (struct glyph_matrix.rows_allocated)
1026 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1027 with xpalloc. The values are still always <= INT_MAX.
1028
1029 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1030
1031 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1032 (SAFE_NALLOCA): New macro.
1033
1034 * region-cache.c (struct boundary.pos, find_cache_boundary)
1035 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1036 (set_cache_region, invalidate_region_cache)
1037 (revalidate_region_cache, know_region_cache, region_cache_forward)
1038 (region_cache_backward, pp_cache):
1039 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1040 so that ptrdiff_t * can be passed to xpalloc.
1041 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1042 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1043 (pp_cache): Don't assume cache_len fits in int.
1044 * region-cache.h: Adjust extern decls to match.
1045
1046 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1047 EMACS_INT, since either will do, for xpalloc.
1048
1049 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1050 (xnmalloc, xnrealloc, xpalloc): New functions.
1051
1052 * bidi.c (bidi_shelve_header_size): New constant.
1053 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1054 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1055
1056 * bidi.c (bidi_cache_shrink):
1057 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1058 (overlay_strings):
1059 Don't update size of array until after memory allocation succeeds,
1060 because xmalloc/xrealloc may not return.
1061 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1062 now that we have proper integer overflow checking.
1063 (record_overlay_string, overlay_strings): Catch overflows when
1064 calculating size of overlay_str_buf.
1065
1066 * callproc.c (Fcall_process): Check for size overflow when
1067 calculating size of args2.
1068 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1069 Normally we prefer signed values, but sticking with ptrdiff_t would
1070 require adding more-complicated checks.
1071
1072 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1073 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1074 Redo buffer-overflow calculations to avoid integer overflow.
1075 Add a FIXME comment where memory seems to be over-allocated.
1076
1077 * character.c (Fstring): Check for size-calculation overflow.
1078
1079 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1080 unnecessary integer overflow. Check for size overflow.
1081 (encode_coding_object): Don't update size until xmalloc succeeds.
1082
1083 * composite.c (get_composition_id): Check for overflow in glyph
1084 length calculations.
1085
1086 Integer and memory overflow fixes for display code.
1087 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1088 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1089 (scrolling_window): Check for overflow in size calculations.
1090 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1091 Don't assume glyph table len fits in int.
1092 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1093 (row_table_size): Now ptrdiff_t, not int.
1094 (scrolling_window): Avoid overflow in size calculations.
1095 Don't update size until allocation succeeds.
1096 * fns.c (concat): Check for overflow in size calculations.
1097 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1098 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1099 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1100
1101 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1102 (get_doc_string): Check for size calculation overflow.
1103 Don't update size until allocation succeeds.
1104 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1105 EMACS_INT, where ptrdiff_t will do.
1106 (Fsubstitute_command_keys): Check for string overflow.
1107
1108 * editfns.c (set_time_zone_rule): Don't assume environment length
1109 fits in int.
1110 (message_length): Now ptrdiff_t, not int.
1111 (Fmessage_box): Don't update size until allocation succeeds.
1112 Don't assume message length fits in int.
1113 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1114
1115 * emacs.c (main): Do not reallocate argv, since there is a null at
1116 the end that can be overwritten, and this way there's no need to
1117 worry about size-calculation overflow.
1118 (sort_args): Check for size-calculation overflow.
1119
1120 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1121 alloc succeeds.
1122 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1123
1124 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1125 (x_set_scroll_bar_width, x_figure_window_size):
1126 Check for integer overflow.
1127 (x_set_alpha): Do not assume XINT fits in int.
1128
1129 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1130 This is for the members text_lines, text_cols, total_lines, total_cols,
1131 where the system imposes an 'int' limit.
1132
1133 * fringe.c (Fdefine_fringe_bitmap):
1134 Don't update size until alloc works.
1135
1136 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1137 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1138
1139 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1140 Check for size-calculation overflow.
1141 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1142 do, as we prefer signed integers.
1143 (id_to_widget.max_size, id_to_widget.used)
1144 (xg_store_widget_in_map, xg_remove_widget_from_map)
1145 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1146 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1147 Use and return ptrdiff_t, not int.
1148 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1149 * gtkutil.h: Change prototypes to match the above.
1150
1151 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1152 are duplicate now that they've been promoted to lisp.h.
1153 (x_allocate_bitmap_record, x_alloc_image_color)
1154 (make_image_cache, cache_image, xpm_load):
1155 Don't update size until alloc is done.
1156 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1157 (x_detect_edges):
1158 Check for size calculation overflow.
1159 (ct_colors_allocated_max): New constant.
1160 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1161 overflow.
1162
1163 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1164 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1165 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1166 Use ptrdiff_t, not int, to count maps.
1167 (read_char_minibuf_menu_prompt): Check for overflow in size
1168 calculations. Don't update size until allocation succeeds.
1169 Redo calculations to avoid overflow.
1170 * keyboard.h: Change prototypes to match the above.
1171
1172 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1173 to count maps.
1174 (current_minor_maps): Check for size calculation overflow.
1175 * keymap.h: Change prototypes to match the above.
1176
1177 * lread.c (read1, init_obarray): Don't update size until alloc done.
1178
1179 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1180 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1181
1182 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1183 Now ptrdiff_t, not int.
1184 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1185 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1186
1187 * process.c (Fnetwork_interface_list): Check for overflow
1188 in size calculation.
1189
1190 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1191
1192 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1193 overflow. Don't bother calling xmalloc when xrealloc will do.
1194
1195 * search.c (Freplace_match): Check for size calculation overflow.
1196 (Fset_match_data): Don't assume list lengths fit in 'int'.
1197
1198 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1199 for command line length. Do not attempt to address one before the
1200 beginning of an array, as that's not portable.
1201
1202 * term.c (max_frame_lines): Remove; unused.
1203 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1204 not int.
1205 (encode_terminal_code, calculate_costs): Check for size
1206 calculation overflow.
1207 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1208 table lengths and related sizes. Don't update size until alloc
1209 done. Redo calculations to avoid overflow.
1210 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1211
1212 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1213 subtracting pointers.
1214 (gobble_line): Check for overflow more carefully. Don't update size
1215 until alloc done.
1216
1217 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1218 Don't update size until alloc done.
1219 Redo size calculations to avoid overflow.
1220 Check for size calculation overflow.
1221 (main) [DEBUG]: Fix typo in invoking tparam1.
1222
1223 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1224 Use ptrdiff_t, not int, for sizes.
1225 (store_mode_line_noprop_char): Don't update size until alloc done.
1226
1227 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1228 Use ptrdiff_t, not int, for sizes.
1229 (Finternal_make_lisp_face, cache_face):
1230 Check for size calculation overflow.
1231 (cache_face): Treat size calculation overflows as if they were
1232 memory exhaustion (the usual treatment), rather than aborting.
1233
1234 * xfns.c (x_encode_text, x_set_name_internal)
1235 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1236 sizes, since they can exceed INT_MAX in size. Check for size
1237 calculation overflow.
1238
1239 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1240 (xg_select): Check for size calculation overflow.
1241 Don't update size until alloc done.
1242
1243 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1244 as sprintf is limited to int lengths.
1245
1246 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1247 (X_LONG_MIN): New macros.
1248 Use them to make the following changes clearer.
1249 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1250 This change doesn't affect the value now, but it may help remind
1251 future maintainers not to raise the value too much later.
1252 (SELECTION_QUANTUM): Remove, replacing with ...
1253 (selection_quantum): ... new function, which avoids overflow.
1254 All uses changed.
1255 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1256 assumption that selection length fits in 'int'.
1257 (x_reply_selection_request, x_handle_selection_request)
1258 (x_get_window_property, receive_incremental_selection)
1259 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1260 (lisp_data_to_selection_data, clean_local_selection_data):
1261 Use ptrdiff_t, not int, to record length of selection.
1262 (x_reply_selection_request, x_get_window_property)
1263 (receive_incremental_selection, x_property_data_to_lisp):
1264 Redo calculations to avoid overflow.
1265 (x_reply_selection_request): When sending hint, ceiling it at
1266 X_LONG_MAX rather than relying on wraparound overflow to send
1267 something.
1268 (x_get_window_property, receive_incremental_selection)
1269 (lisp_data_to_selection_data, x_property_data_to_lisp):
1270 Check for size-calculation overflow.
1271 (x_get_window_property, receive_incremental_selection)
1272 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1273 Don't store size until memory allocation succeeds.
1274 (x_get_window_property): Plug memory leak on memory exhaustion.
1275 Don't double-block input; malloc is safe here. Don't assume 2**34
1276 - 4 fits in unsigned long. Add an xassert to check
1277 XGetWindowProperty overflow. Be more careful about overflow
1278 calculations, and distinguish size from memory overflow better.
1279 (receive_incremental_selection): When tracing, don't assume
1280 unsigned int is less than INT_MAX.
1281 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1282 harmful) conversions of unsigned short to int.
1283 (lisp_data_to_selection_data): Don't assume that integers
1284 in the range -65535 through -1 fit in an X unsigned short.
1285 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1286 result parameters unless successful. Rely on cons_to_unsigned
1287 to report problems with elements; the old code wasn't right anyway.
1288 (x_check_property_data): Check for int overflow; we cannot use
1289 a wider type due to X limits.
1290 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1291
1292 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1293
1294 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1295 (x_term_init): Check for size calculation overflow.
1296 (x_color_cells): Don't store size until memory allocation succeeds.
1297 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1298 Don't assume alloca size is less than MAX_ALLOCA.
1299 (x_term_init): Don't assume length fits in int (sprintf is limited
1300 to int size).
1301
1302 Use ptrdiff_t for composition IDs.
1303 * character.c (lisp_string_width):
1304 * composite.c (composition_table_size, n_compositions)
1305 (get_composition_id, composition_gstring_from_id):
1306 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1307 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1308 * window.c (Frecenter):
1309 Use ptrdiff_t, not int, for composition IDs.
1310 * composite.c (get_composition_id): Check for integer overflow.
1311 * composite.h: Adjust prototypes to match the above changes.
1312
1313 Use ptrdiff_t for hash table indexes.
1314 * category.c (hash_get_category_set):
1315 * ccl.c (ccl_driver):
1316 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1317 * coding.c (coding_system_charset_list, detect_coding_system):
1318 * coding.h (struct coding_system.id):
1319 * composite.c (get_composition_id, gstring_lookup_cache):
1320 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1321 * image.c (xpm_get_color_table_h):
1322 * lisp.h (hash_lookup, hash_put):
1323 * minibuf.c (Ftest_completion):
1324 Use ptrdiff_t for hash table indexes, not int (which is too
1325 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1326 32-bit --with-wide-int hosts).
1327
1328 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1329 Add a FIXME comment about memory leaks.
1330 (syms_of_charset): Don't assume xmalloc returns.
1331
1332 Don't assume that stated character widths fit in int.
1333 * character.c (Fchar_width, c_string_width, lisp_string_width):
1334 * character.h (CHAR_WIDTH):
1335 * indent.c (MULTIBYTE_BYTES_WIDTH):
1336 Use sanitize_char_width to avoid undefined and/or bad behavior
1337 with outlandish widths.
1338 * character.h (sanitize_tab_width): Rename from sanitize_width,
1339 now that we have two such functions. All uses changed.
1340 (sanitize_char_width): New inline function.
1341
1342 Don't assume that tab-width fits in int.
1343 * character.h (sanitize_width): New inline function.
1344 (SANE_TAB_WIDTH): New macro.
1345 (ASCII_CHAR_WIDTH): Use it.
1346 * indent.c (sane_tab_width): Remove. All uses replaced by
1347 SANE_TAB_WIDTH (current_buffer).
1348 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1349
1350 * fileio.c: Integer overflow issues with file modes.
1351 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1352
1353 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1354 Remove unreachable code.
1355 (read_hex, load_charset_map_from_file): Check for integer overflow.
1356
1357 * xterm.c: don't go over XClientMessageEvent limit
1358 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1359 (x_send_scroll_bar_event): Likewise. Check that the size does not
1360 exceed limits imposed by XClientMessageEvent, as well as the usual
1361 ptrdiff_t and size_t limits.
1362
1363 * keyboard.c: Overflow, signedness and related fixes.
1364 (make_lispy_movement): Use same integer type in forward decl
1365 that is used in the definition.
1366 (read_key_sequence, keyremap_step):
1367 Change bufsize argument back to int, undoing my 2011-03-30 change.
1368 We prefer signed types, and int is wide enough here.
1369 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1370 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1371 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1372 length, not size_t. Use ptrdiff_t for index, not int.
1373 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1374 possibility of integer overflow.
1375
1376 Overflow, signedness and related fixes for images.
1377
1378 * dispextern.h (struct it.stack[0].u.image.image_id)
1379 (struct_it.image_id, struct image.id, struct image_cache.size)
1380 (struct image_cache.used, struct image_cache.ref_count):
1381 * gtkutil.c (update_frame_tool_bar):
1382 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1383 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1384 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1385 * nsmenu.m (update_frame_tool_bar):
1386 * xdisp.c (calc_pixel_width_or_height):
1387 * xfns.c (image_cache_refcount):
1388 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1389 on typical 64-bit hosts.
1390
1391 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1392 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1393 Omit unnecessary casts to int.
1394 (parse_image_spec): Check that integers fall into 'int' range
1395 when the callers expect that.
1396 (image_ascent): Redo ascent calculation to avoid int overflow.
1397 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1398 (lookup_image): Remove unnecessary tests.
1399 (xbm_image_p): Locals are now of int, not EMACS_INT,
1400 since parse_image_check makes sure they fit into int.
1401 (png_load, gif_load, svg_load_image):
1402 Prefer int to unsigned where either will do.
1403 (tiff_handler): New function, combining the cores of the
1404 old tiff_error_handler and tiff_warning_handler.
1405 This function is rewritten to use vsnprintf and thereby avoid
1406 stack buffer overflows. It uses only the features of vsnprintf
1407 that are common to both POSIX and native Microsoft.
1408 (tiff_error_handler, tiff_warning_handler): Use it.
1409 (tiff_load, gif_load, imagemagick_load_image):
1410 Don't assume :index value fits in 'int'.
1411 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1412 (imagemagick_load_image): Check that crop parameters fit into
1413 the integer types that MagickCropImage accepts. Don't assume
1414 Vimagemagick_render_type has a nonnegative value. Don't assume
1415 size_t fits in 'long'.
1416 (gs_load): Use printmax_t to print the widest integers possible.
1417 Check for integer overflow when computing image height and width.
1418
1419 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1420
1421 * xdisp.c (redisplay_window): Don't force window start if point
1422 will be invisible in the resulting window. (Bug#9324)
1423
1424 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1425
1426 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1427 the display spec is of the form `(space ...)'.
1428 (handle_display_spec): Return the value returned by
1429 handle_single_display_spec, not just 1 or zero.
1430 (handle_single_display_spec): If the display spec is of the form
1431 `(space ...)', and specifies display in the text area, return 2
1432 rather than 1.
1433 (try_cursor_movement): Check for the need to scroll more
1434 accurately, and prefer exact match for point under bidi.
1435 Don't advance `row' beyond the last row of the window.
1436
1437 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1438 into disp_prop; all users changed.
1439
1440 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1441 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1442 for the text covered by the display property.
1443
1444 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1445
1446 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1447 Change return value to nil.
1448 (Frecord_buffer): Delete unused function.
1449
1450 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1451
1452 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1453 buffers, return left-to-right.
1454 (set_cursor_from_row): Consider candidate row a win if its glyph
1455 represents a newline and point is on that newline. Fixes cursor
1456 positioning on the newline at EOL of R2L text within L2R
1457 paragraph, and vice versa.
1458 (try_cursor_movement): Check continued rows, in addition to
1459 continuation rows. Fixes unwarranted scroll when point enters a
1460 continued line of R2L text within an L2R paragraph, or vice versa.
1461 (cursor_row_p): Consider the case of point being equal to
1462 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1463 from the end of a short line to the beginning of a continued line
1464 of R2L text within L2R paragraph.
1465 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1466 composed characters.
1467
1468 * bidi.c (bidi_check_type): Use xassert.
1469 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1470 members.
1471
1472 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1473
1474 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1475 a character.
1476
1477 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1478
1479 * nsfont.m (ns_otf_to_script): Fix typo.
1480
1481 2011-08-22 Kenichi Handa <handa@m17n.org>
1482
1483 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1484 extra slot even if the purpose is char-code-property-table.
1485
1486 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1487
1488 * xdisp.c (redisplay_window): When computing centering_position,
1489 account for the height of the header line. (Bug#8874)
1490
1491 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1492 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1493 candidate is selected by the mouse, and that candidate has a
1494 composed character under the mouse.
1495
1496 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1497 coordinates reported by pos-visible-in-window-p for a composed
1498 character in column zero.
1499
1500 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1501
1502 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1503
1504 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1505
1506 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1507 consider it a hit if to_charpos is anywhere in the range of the
1508 composed buffer positions.
1509
1510 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1511
1512 * image.c (gif_load): Don't assume that each subimage has the same
1513 dimensions as the base image. Handle disposal method that is
1514 "undefined" by the gif spec (Bug#9335).
1515
1516 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1517
1518 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1519 (Fcondition_case): Document `debug' symbol in error handler.
1520
1521 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1522
1523 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1524 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1525 from an Org mode buffer to a Speedbar frame.
1526
1527 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1528 a composition, take its buffer position from IT->cmp_it.charpos.
1529 Fixes cursor positioning at the beginning of a line that begins
1530 with a composed character.
1531
1532 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1533
1534 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1535 character bidirectional type, use STRONG_L instead. Fixes crashes
1536 in a buffer produced by `describe-categories'.
1537
1538 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1539 members before the level stack, so they would be saved and
1540 restored when copying iterator state. Fixes incorrect reordering
1541 around TABs covered by display properties.
1542
1543 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1544
1545 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1546
1547 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1548
1549 * eval.c (internal_condition_case, internal_condition_case_1)
1550 (internal_condition_case_2, internal_condition_case_n):
1551 Remove unnecessary aborts (Bug#9081).
1552
1553 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1554
1555 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1556 has no `load' handler, try opening the file locally. (Bug#9311)
1557
1558 2011-08-16 Ken Brown <kbrown@cornell.edu>
1559
1560 * gmalloc.c: Expand comment.
1561
1562 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1563
1564 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1565 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1566
1567 2011-08-16 Ken Brown <kbrown@cornell.edu>
1568
1569 Fix memory allocation problems in Cygwin build (Bug#9273).
1570
1571 * unexcw.c ( __malloc_initialized): Declare external variable.
1572 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1573
1574 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1575 New variables.
1576 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1577 dumped emacs.
1578 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1579 in the static heap.
1580 [CYGWIN] (special_realloc): New function.
1581 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1582 requests to realloc storage in the static heap.
1583
1584 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 * bidi.c (bidi_initialize): Remove unused local.
1587
1588 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1589
1590 * bidimirror.h:
1591 * biditype.h: Remove file.
1592 * makefile.w32-in ($(BLD)/bidi.$(O)):
1593 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1594
1595 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1596
1597 * chartab.c: Improve commentary for the uniprop_table API.
1598
1599 * bidi.c (bidi_paragraph_init): Support zero value of
1600 bidi_ignore_explicit_marks_for_paragraph_level.
1601 (bidi_initialize): Use uniprop_table instead of including
1602 biditype.h and bidimirror.h.
1603
1604 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1605 coordinates of the iterator when restoring from ppos_it.
1606 (Bug#9296)
1607
1608 2011-08-14 Kenichi Handa <handa@m17n.org>
1609
1610 * process.c (create_process): Call setup_process_coding_systems
1611 after the pid of the process is set to -1 (Bug#8162).
1612
1613 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1614
1615 * xdisp.c (move_it_in_display_line_to): Don't invoke
1616 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1617 ppos_it. Fixes vertical cursor motion when line beginning is
1618 covered by an image. (Bug#9296)
1619
1620 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1621
1622 * nsterm.h (ns_run_ascript): Declare.
1623 (NSAPP_DATA2_RUNASSCRIPT): Define.
1624
1625 * nsfns.m (as_script, as_result, as_status): New static variables.
1626 (ns_run_ascript): New function.
1627 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1628 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1629 the event loop. Get status from as_status (Bug#7276).
1630
1631 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1632 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1633 the event loop (Bug#7276).
1634
1635 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1636
1637 * gnutls.c (QCgnutls_bootprop_priority)
1638 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1639 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1640 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1641 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1642 (QCgnutls_bootprop_verify_hostname_error)
1643 (QCgnutls_bootprop_callbacks_verify): Rename from
1644 Qgnutls_bootprop_..., all uses changed.
1645
1646 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1647 uses changed.
1648
1649 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1650
1651 * xfaces.c (Qframe_set_background_mode): Now static.
1652 * dispextern.h (Qframe_set_background_mode): Remove decl.
1653
1654 * process.c (Fnetwork_interface_info): Declare local only if needed.
1655
1656 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1657
1658 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1659 (Fnetwork_interface_list): Allocate in increments of bytes instead
1660 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1661 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1662 sockaddr.
1663 (struct ifflag_def): notrailers is smart on OSX.
1664 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1665 Get hardware address with getifaddrs if available.
1666
1667 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1668
1669 * xdisp.c (iterate_out_of_display_property): xassert that
1670 IT->position is set to within IT->object's boundaries. Break from
1671 the loop as soon as EOB is reached; avoids infloops in redisplay
1672 when IT->position is set up wrongly due to some bug.
1673 Set IT->current to match the bidi iterator unconditionally.
1674 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1675 entry. Force push_it to save on the stack the current
1676 buffer/string position, to be restored by pop_it. Fix flags in
1677 the iterator structure wrt the object coming from a display
1678 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1679 properties. (Bug#9284)
1680
1681 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1682
1683 * fontset.c (fontset_get_font_group): Add proper type checks.
1684 (Bug#9172)
1685
1686 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1687
1688 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1689 and LC_VERSION_MIN_MACOSX.
1690 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1691 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1692
1693 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1694
1695 * xdisp.c (forward_to_next_line_start): Allow to use the
1696 no-display-properties-and-no-overlays under bidi display.
1697 Set disp_pos in the bidi iterator to avoid searches for display
1698 properties and overlays.
1699
1700 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1701
1702 * editfns.c (Fset_time_zone_rule): Document relationship with the
1703 setenv function.
1704
1705 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1706 the font entity extracted from the cache (Bug#8109).
1707
1708 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1709
1710 * composite.c (autocmp_chars): Don't reset point. That is done by
1711 restore_point_unwind (Bug#5984).
1712
1713 2011-08-07 Juri Linkov <juri@jurta.org>
1714
1715 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1716 to show the arg `TIME' instead of `TIMEVAL'.
1717
1718 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1719
1720 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1721 display property strides EOL and includes a newline, as in
1722 longlines-mode. (Bug#9254)
1723 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1724 word-wrap under bidirectional display. (Bug#9224)
1725
1726 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1727 is non-zero, even if the data buffer is NULL. Fixes a crash in
1728 vertical-motion with longlines-mode. (Bug#9254)
1729
1730 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1731
1732 * bidi.c <bidi_cache_total_alloc>: Now static.
1733 (bidi_initialize): Initialize bidi_cache_total_alloc.
1734
1735 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1736 cache. (Bug#9221)
1737
1738 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1739 amount allocated this far in `bidi_cache_total_alloc'.
1740 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1741 non-zero, only free the data buffer without restoring the cache
1742 contents. All callers changed.
1743
1744 * dispextern.h (bidi_unshelve_cache): Update prototype.
1745
1746 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1747 (move_it_in_display_line, move_it_to)
1748 (move_it_vertically_backward, move_it_by_lines): Replace the call
1749 to xfree to an equivalent call to bidi_unshelve_cache.
1750 (move_it_in_display_line_to): Fix logic of returning
1751 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1752
1753 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1754
1755 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1756 came from a string character with a `cursor' property. (Bug#9229)
1757
1758 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1759
1760 * Makefile.in (LIB_PTHREAD): New variable.
1761 (LIBES): Add LIB_PTHREAD (Bug#9216).
1762
1763 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1764 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1765
1766 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1767
1768 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1769
1770 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1771
1772 * xterm.c (x_find_topmost_parent): New function.
1773 (x_set_frame_alpha): Find topmost parent window with
1774 x_find_topmost_parent and set the property there also (bug#9181).
1775 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1776
1777 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 * callproc.c (Fcall_process): Avoid vfork clobbering
1780 the local vars buffer, coding_systems, current_dir.
1781
1782 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1783
1784 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1785
1786 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1789 so that it is not optimized away.
1790
1791 * xdisp.c (compute_display_string_pos): Remove unused local.
1792
1793 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1794
1795 Fix slow cursor motion and scrolling in large buffers with
1796 selective display, like Org Mode buffers. (Bug#9218)
1797
1798 * dispextern.h (struct bidi_it): New member disp_prop_p.
1799
1800 * xdisp.c: Remove one-slot cache of display string positions.
1801 (compute_display_string_pos): Accept an additional argument
1802 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1803 for a display string or property. If found, set DISP_PROP_P
1804 non-zero.
1805
1806 * bidi.c (bidi_fetch_char): Accept an additional argument
1807 DISP_PROP_P, and pass it to compute_display_string_pos.
1808 Only handle text covered by a display string if DISP_PROP_P is returned
1809 non-zero. All callers of bidi_fetch_char changed.
1810
1811 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1812
1813 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1814
1815 2010-12-03 Don March <don@ohspite.net>
1816
1817 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1818 last character M-[char] is translated to ESC [char] (bug#7541).
1819
1820 2011-08-02 Kenichi Handa <handa@m17n.org>
1821
1822 * lisp.h (uniprop_table): Extern it.
1823
1824 * chartab.c (uniprop_table): Make it non-static.
1825
1826 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1827
1828 * xdisp.c (forward_to_next_line_start): Accept additional argument
1829 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1830 on the newline.
1831 (reseat_at_next_visible_line_start): Use the bidi iterator state
1832 returned by forward_to_next_line_start to restore the state of
1833 it->bidi_it after backing up to previous newline. (Bug#9212)
1834
1835 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1836
1837 * regex.c (re_comp): Protoize.
1838 (re_exec): Fix return type.
1839 (regexec): Fix type of `ret'. (Bug#9203)
1840
1841 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1844 This is needed if max-image-size is a floating-point number.
1845
1846 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1847
1848 * print.c (print_object): Print empty symbol as ##.
1849
1850 * lread.c (read1): Read ## as empty symbol.
1851
1852 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1853
1854 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1855 setting frame foreground color (Bug#9175).
1856 (x_set_background_color): Likewise.
1857
1858 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1859 contents (Bug#9176).
1860 (EmacsTooltip -init): Remove bezels and add shadows to
1861 tooltip windows.
1862
1863 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1864 or scroll bar (Bug#8470).
1865
1866 * nsfont.m (nsfont_open): Remove assignment to voffset and
1867 unnecessary vars hshink, expand, hd, full_height, min_height.
1868 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1869
1870 * nsterm.h (nsfont_info): Remove voffset field.
1871
1872 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1873
1874 Implement strike-through and overline on NextStep (Bug#8863).
1875
1876 * nsfont.m (nsfont_open): Use underline position provided by font,
1877 instead of hard-coded value of 2.
1878 (nsfont_draw): Call ns_draw_text_decoration instead.
1879
1880 * nsterm.h: Add declaration for ns_draw_text_decoration.
1881
1882 * nsterm.m (ns_draw_text_decoration): New function for drawing
1883 underline, overline, and strike-through.
1884 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1885 ns_draw_text_decoration. Change treatment of cursor drawing to
1886 accommodate underlining, etc.
1887
1888 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1889
1890 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1891 default.
1892
1893 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1896 Without this fix, if a signal arrives just after memory fills up,
1897 'malloc' might be invoked reentrantly.
1898
1899 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1900 In other words, assume that every image size is allowed, on non-X
1901 hosts. This assumption is probably wrong, but it lets Emacs compile.
1902
1903 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1904
1905 * regex.c (re_iswctype): Convert return values to boolean.
1906
1907 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1908
1909 * xdisp.c (compute_display_string_pos): Don't use cached display
1910 string position if the buffer had its restriction changed.
1911 (Bug#9184)
1912
1913 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1916
1917 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 Integer signedness and overflow and related fixes. (Bug#9079)
1920
1921 * bidi.c: Integer size and overflow fixes.
1922 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1923 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1924 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1925 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1926 (bidi_find_other_level_edge):
1927 Use ptrdiff_t instead of EMACS_INT where either will do.
1928 This works better on 32-bit hosts configured --with-wide-int.
1929 (bidi_cache_ensure_space): Check for size-calculation overflow.
1930 Use % rather than repeated addition, for better worst-case speed.
1931 Don't set bidi_cache_size until after xrealloc returns, because it
1932 might not return.
1933 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1934 (bidi_cache_ensure_space): Also check that the bidi cache size
1935 does not exceed that of the largest Lisp string or buffer. See Eli
1936 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1937
1938 * alloc.c (__malloc_size_t): Remove.
1939 All uses replaced by size_t. See Andreas Schwab's note
1940 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1941
1942 * image.c: Improve checking for integer overflow.
1943 (check_image_size): Assume that f is nonnull, since
1944 it is always nonnull in practice. This is one less thing to
1945 worry about when checking for integer overflow later.
1946 (x_check_image_size): New function, which checks for integer
1947 overflow issues inside X.
1948 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1949 This removes the need for a memory_full check.
1950 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1951 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1952 (xbm_read_bitmap_data): Change locals back to 'int', since
1953 their values must fit in 'int'.
1954 (xpm_load_image, png_load, tiff_load):
1955 Invoke x_create_x_image_and_pixmap earlier,
1956 to avoid much needless work if the image is too large.
1957 (tiff_load): Treat overly large images as if
1958 x_create_x_image_and_pixmap failed, not as malloc failures.
1959 (gs_load): Use x_check_image_size.
1960
1961 * gtkutil.c: Omit integer casts.
1962 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1963 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1964
1965 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1966
1967 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1968 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1969 would wrongly return t on a 64-bit host.
1970
1971 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1972 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1973 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1974 and therefore cause GCC to emit a bogus diagnostic in some cases.
1975
1976 * image.c: Integer signedness and overflow and related fixes.
1977 This is not an exhaustive set of fixes, but it's time to
1978 record what I've got.
1979 (lookup_pixel_color, check_image_size): Remove redundant decls.
1980 (check_image_size): Don't assume that arbitrary EMACS_INT values
1981 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1982 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1983 (tiff_load, imagemagick_load_image):
1984 Check for overflow in size calculations.
1985 (x_create_x_image_and_pixmap): Remove unnecessary test for
1986 xmalloc returning NULL; that can't happen.
1987 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1988 (xpm_color_bucket): Use better integer hashing function.
1989 (xpm_cache_color): Don't possibly over-allocate memory.
1990 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1991 (gif_memory_source):
1992 Use ptrdiff_t, not int or size_t, to record sizes.
1993 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1994 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1995 either works, as we prefer signed integers.
1996 (tiff_read_from_memory, tiff_write_from_memory):
1997 Return tsize_t, not size_t, since that's what the TIFF API wants.
1998 (tiff_read_from_memory): Don't fail simply because the read would
1999 go past EOF; instead, return a short read.
2000 (tiff_load): Omit no-longer-needed casts.
2001 (Fimagemagick_types): Don't assume size fits into 'int'.
2002
2003 Improve hashing quality when configured --with-wide-int.
2004 * fns.c (hash_string): New function, taken from sxhash_string.
2005 Do not discard information about ASCII character case; this
2006 discarding is no longer needed.
2007 (sxhash-string): Use it. Change sig to match it. Caller changed.
2008 * lisp.h: Declare it.
2009 * lread.c (hash_string): Remove, since we now use fns.c's version.
2010 The fns.c version returns a wider integer if --with-wide-int is
2011 specified, so this should help the quality of the hashing a bit.
2012
2013 * emacs.c: Integer overflow minor fix.
2014 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2015 Define only if GNU_LINUX.
2016 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2017
2018 * dispnew.c: Integer signedness and overflow fixes.
2019 Remove unnecessary forward decls, that were a maintenance hassle.
2020 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2021 All uses changed.
2022 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2023 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2024 (prepare_desired_row, line_draw_cost):
2025 Use int, not unsigned, where either works.
2026 (save_current_matrix, restore_current_matrix):
2027 Use ptrdiff_t, not size_t, where either works.
2028 (init_display): Check for overflow more accurately, and without
2029 relying on undefined behavior.
2030
2031 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2032 Remove, replacing with the new symbols in lisp.h. All uses changed.
2033 * fileio.c (make_temp_name):
2034 * filelock.c (lock_file_1, lock_file):
2035 * xdisp.c (message_dolog):
2036 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2037 Use pMd etc. instead.
2038 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2039 replacing the pWIDE etc. symbols removed from editfns.c.
2040
2041 * keyboard.h (num_input_events): Now uintmax_t.
2042 This is (very slightly) less likely to mess up due to wraparound.
2043 All uses changed.
2044
2045 * buffer.c: Integer signedness fixes.
2046 (alloc_buffer_text, enlarge_buffer_text):
2047 Use ptrdiff_t rather than size_t when either will do, as we prefer
2048 signed integers.
2049
2050 * alloc.c: Integer signedness and overflow fixes.
2051 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2052 (__malloc_size_t): Default to size_t, not to int.
2053 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2054 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2055 Prefer ptrdiff_t to size_t when either would do, as we prefer
2056 signed integers.
2057 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2058 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2059 Now const. Initialize with values that are in range even if char
2060 is signed.
2061 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2062 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2063 These functions do the right thing with sizes > 2**32.
2064 (check_depth): Now ptrdiff_t, not int.
2065 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2066 Adjust to new way of storing sizes. Check for size overflow bugs
2067 in rest of code.
2068 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2069 slightly wrong anyway, as it missed one instance of
2070 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2071 (refill_memory_reserve): Omit needless cast to size_t.
2072 (mark_object_loop_halt): Mark as externally visible.
2073
2074 * xselect.c: Integer signedness and overflow fixes.
2075 (Fx_register_dnd_atom, x_handle_dnd_message):
2076 Use ptrdiff_t, not size_t, since we prefer signed.
2077 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2078 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2079 x_dnd_atoms_size and x_dnd_atoms_length.
2080
2081 * doprnt.c: Prefer signed to unsigned when either works.
2082 * eval.c (verror):
2083 * doprnt.c (doprnt):
2084 * lisp.h (doprnt):
2085 * xdisp.c (vmessage):
2086 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2087 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2088 prefer signed arithmetic to avoid comparison confusion.
2089 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2090 but is a bit tricky.
2091
2092 Assume freestanding C89 headers, string.h, stdlib.h.
2093 * data.c, doprnt.c, floatfns.c, print.c:
2094 Include float.h unconditionally.
2095 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2096 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2097 * regex.c: Likewise for stddef.h, string.h.
2098 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2099 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2100 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2101 (STDC_HEADERS): Remove obsolete defines.
2102 * sysdep.c: Include limits.h unconditionally.
2103
2104 Assume support for memcmp, memcpy, memmove, memset.
2105 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2106 * regex.c (memcmp, memcpy):
2107 Remove; we assume C89 now.
2108
2109 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2110 (__malloc_safe_bcopy): Remove; no longer needed.
2111
2112 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2113 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2114 well either way, and we prefer signed to unsigned.
2115
2116 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2117
2118 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2119 closes the connection while we're reading (bug#9182).
2120
2121 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2122
2123 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2124 are specified (Bug#9168).
2125
2126 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2129 Found by GCC static checking and --with-wide-int on a 32-bit host.
2130
2131 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2132
2133 * xdisp.c (compute_display_string_pos): Fix logic of caching
2134 previous display string position. Initialize cached_prev_pos to
2135 -1. Fixes slow-down at the beginning of a buffer.
2136
2137 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2138
2139 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2140 for attrs[LFACE_FONTSET_INDEX].
2141
2142 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 * xml.c (parse_region): Remove unused local
2145 that was recently introduced.
2146
2147 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2148
2149 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2150 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2151
2152 * xdisp.c (move_it_in_display_line_to): Record the best matching
2153 position for TO_CHARPOS while scanning the line, and restore it on
2154 exit if none of the characters scanned was an exact match.
2155 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2156 when exact match is impossible due to invisible text, and the
2157 lines are truncated.
2158
2159 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2160
2161 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2162 for OSX >= 10.7.
2163
2164 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2165
2166 Fix a significant slow-down of cursor motion with C-n, C-p,
2167 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2168 auto-repeat under bidi redisplay in fontified buffers.
2169 * xdisp.c (compute_stop_pos_backwards): New function.
2170 (next_element_from_buffer): Call compute_stop_pos_backwards to
2171 find a suitable prev_stop when we find ourselves before
2172 base_level_stop.
2173 (reseat): Don't look for prev_stop, as that could mean a very long
2174 run.
2175 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2176 <cached_disp_overlay_modiff>: Cache for last found display string
2177 position.
2178 (compute_display_string_pos): Return the cached position if asked
2179 about the same buffer in the same area of character positions, and
2180 the buffer wasn't changed since the time the display string
2181 position was cached.
2182
2183 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2184
2185 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2186 is an integer, which is important for empty lines. (Bug#9149)
2187
2188 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2189
2190 * frame.c (Fmodify_frame_parameters): In tty case, update the
2191 default face if necessary (Bug#4238).
2192
2193 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2194
2195 * editfns.c (Fstring_to_char): No need to explain what a character
2196 is in the docstring (Bug#6576).
2197
2198 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2199
2200 * xml.c (parse_region): Make sure we always return a tree.
2201
2202 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2203
2204 * xml.c (parse_region): If a document contains only comments,
2205 return that, too.
2206
2207 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2208
2209 * xml.c (make_dom): Return comments, too.
2210
2211 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 Port to OpenBSD.
2214 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2215 and the surrounding thread.
2216 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2217 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2218 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2219 timer goes off.
2220 * s/openbsd.h (BROKEN_SIGIO): Define.
2221 * unexelf.c (unexec) [__OpenBSD__]:
2222 Don't update the .mdebug section of the Alpha COFF symbol table.
2223
2224 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2225
2226 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2227 (bug#8460).
2228
2229 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2232 This fixes some race conditions on the permissions of any newly
2233 created file.
2234
2235 * alloc.c (valid_pointer_p): Use pipe, not open.
2236 This fixes some permissions issues when debugging.
2237
2238 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2239 If fchown fails to set both uid and gid, try to set just gid,
2240 as that is sometimes allowed. Adjust the file's mode to eliminate
2241 setuid or setgid bits that are inappropriate if fchown fails.
2242
2243 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2244
2245 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2246 to compare Lisp_Objects.
2247 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2248 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2249 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2250
2251 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2252
2253 * lread.c (read_integer): Unread even EOF character.
2254 (read1): Likewise. Properly record start position of symbol.
2255
2256 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2257 symbol character follows.
2258
2259 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2260
2261 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2262 This works around a problem with the previous change to Fcopy_file.
2263 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2264 and without this change, GCC might complain about discarding
2265 fchown's return value.
2266
2267 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2268
2269 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2270
2271 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2274
2275 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2276
2277 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2278 it's used from the C level.
2279
2280 * process.c: Use the same condition for POLL_FOR_INPUT in both
2281 keyboard.c and process.c (bug#1858).
2282
2283 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2284
2285 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2286 (Fgnutls_boot): Use it.
2287
2288 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2289
2290 * doc.c (Fsubstitute_command_keys): Revert last change.
2291
2292 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2293
2294 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2295 quotes the next character, and doesn't affect other longer
2296 sequences (bug#8935).
2297
2298 * lread.c (syms_of_lread): Clarify that is isn't only
2299 `eval-buffer' and `eval-defun' that's affected by
2300 `lexical-binding' (bug#8460).
2301
2302 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2303
2304 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2305 bidi redisplay when a line includes both an image and is truncated.
2306
2307 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 Fix minor problems found by static checking.
2310 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2311 (elsz): Now a signed constant, not a size_t var. We prefer signed
2312 types to unsigned, to avoid integer comparison confusion. Without
2313 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2314 "cannot optimize loop, the loop counter may overflow", a symptom
2315 of the confusion.
2316 * indent.c (Fvertical_motion): Mark locals as initialized.
2317 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2318
2319 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2320
2321 * search.c (Fre_search_backward): Mention `case-fold-search' in
2322 all the re_search_* functions (bug#8138).
2323
2324 * keyboard.c (Fopen_dribble_file): Document when the file is
2325 closed (bug#8056).
2326
2327 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2328
2329 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2330 bidi_cache_idx.
2331
2332 Support bidi reordering of display and overlay strings.
2333 * xdisp.c (compute_display_string_pos)
2334 (compute_display_string_end): Accept additional argument STRING.
2335 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2336 (reseat_to_string): Initialize bidi_it->string.s and
2337 bidi_it->string.schars.
2338 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2339 NULL (avoids a crash in bidi_paragraph_init).
2340 Initialize itb.string.lstring.
2341 (init_iterator): Call bidi_init_it only of a valid
2342 buffer position was specified. Initialize paragraph_embedding to
2343 L2R.
2344 (reseat_to_string): Initialize the bidi iterator.
2345 (display_string): If we need to ignore text properties of
2346 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2347 original value of -1 will not work with bidi.)
2348 (compute_display_string_pos): First arg is now struct
2349 `text_pos *'; all callers changed. Support display properties on
2350 Lisp strings.
2351 (compute_display_string_end): Support display properties on Lisp
2352 strings.
2353 (init_iterator, reseat_1, reseat_to_string): Initialize the
2354 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2355 when iterating on a string not from display properties).
2356 (compute_display_string_pos, compute_display_string_end):
2357 Fix calculation of the object to scan. Fixes an error when using
2358 arrow keys.
2359 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2360 base_level_stop; instead, set base_level_stop to BEGV.
2361 Fixes crashes in vertical-motion.
2362 (next_element_from_buffer): Improve commentary for when
2363 the iterator is before prev_stop.
2364 (init_iterator): Initialize bidi_p from the default value of
2365 bidi-display-reordering, not from buffer-local value. Use the
2366 buffer-local value only if initializing for buffer iteration.
2367 (handle_invisible_prop): Support invisible properties on strings
2368 that are being bidi-reordered.
2369 (set_iterator_to_next): Support bidi reordering of C strings and
2370 Lisp strings.
2371 (next_element_from_string): Support bidi reordering of Lisp
2372 strings.
2373 (handle_stop_backwards): Support Lisp strings as well.
2374 (display_string): Support display of R2L glyph rows.
2375 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2376 (init_iterator): Don't initialize it->bidi_p for strings
2377 here.
2378 (reseat_to_string): Initialize it->bidi_p for strings here.
2379 (next_element_from_string, next_element_from_c_string)
2380 (next_element_from_buffer): Add xassert's for correspondence
2381 between IT's object being iterated and it->bidi_it.string
2382 structure.
2383 (face_before_or_after_it_pos): Support bidi iteration.
2384 (next_element_from_c_string): Handle the case of the first string
2385 character that is not the first one in the visual order.
2386 (get_visually_first_element): New function, refactored from common
2387 parts of next_element_from_buffer, next_element_from_string, and
2388 next_element_from_c_string.
2389 (tool_bar_lines_needed, redisplay_tool_bar)
2390 (display_menu_bar): Force left-to-right direction. Add a FIXME
2391 comment for making that be controlled by a user option.
2392 (push_it, pop_it): Save and restore the state of the
2393 bidi iterator. Save and restore the bidi_p flag.
2394 (pop_it): Iterate out of display property for string iteration as
2395 well.
2396 (iterate_out_of_display_property): Support iteration over strings.
2397 (handle_single_display_spec): Set up it->bidi_it for iteration
2398 over a display string, and call bidi_init_it.
2399 (handle_single_display_spec, next_overlay_string)
2400 (get_overlay_strings_1, push_display_prop): Set up the bidi
2401 iterator for displaying display or overlay strings.
2402 (forward_to_next_line_start): Don't use the shortcut if
2403 bidi-iterating.
2404 (back_to_previous_visible_line_start): If handle_display_prop
2405 pushed the iterator stack, restore the internal state of the bidi
2406 iterator by calling bidi_pop_it same number of times.
2407 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2408 and we are bidi-iterating, don't decrement the iterator position;
2409 instead, set the first_elt flag in the bidi iterator, to produce
2410 the same effect.
2411 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2412 (push_display_prop): xassert that we are iterating a buffer.
2413 (push_it, pop_it): Save and restore paragraph_embedding member.
2414 (handle_single_display_spec, next_overlay_string)
2415 (get_overlay_strings_1, reseat_1, reseat_to_string)
2416 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2417 correctly. Don't assume unibyte strings are not bidi-reordered.
2418 (compute_display_string_pos)
2419 (compute_display_string_end): Fix handling the case of C string.
2420 (push_it, pop_it): Save and restore from_disp_prop_p.
2421 (handle_single_display_spec, push_display_prop): Set the
2422 from_disp_prop_p flag.
2423 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2424 (pop_it): Call iterate_out_of_display_property only if we are
2425 popping after iteration over a string that came from a display
2426 property. Fix a typo in popping stretch info. Add an assertion
2427 for verifying that the iterator position is in sync with the bidi
2428 iterator.
2429 (handle_single_display_spec, get_overlay_strings_1)
2430 (push_display_prop): Fix initialization of paragraph direction for
2431 string when that of the parent object is not yet determined.
2432 (reseat_1): Call bidi_init_it to resync the bidi
2433 iterator with IT's position. (Bug#7616)
2434 (find_row_edges): If ROW->start.pos gives position
2435 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2436 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2437 Reset the from_disp_prop_p flag.
2438 (SAVE_IT, RESTORE_IT): New macros.
2439 (pos_visible_p, face_before_or_after_it_pos)
2440 (back_to_previous_visible_line_start)
2441 (move_it_in_display_line_to, move_it_in_display_line)
2442 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2443 (try_scrolling, redisplay_window, display_line): Use them when
2444 saving a temporary copy of the iterator and restoring it back.
2445 (back_to_previous_visible_line_start, reseat_1)
2446 (init_iterator): Empty the bidi cache "stack".
2447 (move_it_in_display_line_to): If iterator ended up at
2448 EOL, but we never saw any buffer positions smaller than
2449 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2450 motion in bidi-reordered lines.
2451 (move_it_in_display_line_to): Record prev_method and prev_pos
2452 immediately before the call to set_iterator_to_next. Fixes cursor
2453 motion in bidi-reordered lines with stretch glyphs and strings
2454 displayed in margins. (Bug#8133) (Bug#8867)
2455 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2456 TO_CHARPOS.
2457 (pos_visible_p): Support positions in bidi-reordered lines.
2458 Save and restore bidi cache.
2459
2460 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2461 (bidi_paragraph_info): Delete unused struct.
2462 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2463 (bidi_cache_start): New variable.
2464 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2465 to zero.
2466 (bidi_cache_fetch_state, bidi_cache_search)
2467 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2468 (bidi_cache_find, bidi_peek_at_next_level)
2469 (bidi_level_of_next_char, bidi_find_other_level_edge)
2470 (bidi_move_to_visually_next): Compare cache index with
2471 bidi_cache_start rather than with zero.
2472 (bidi_fetch_char): Accept new argument STRING; all callers
2473 changed. Support iteration over a string. Support strings with
2474 display properties. Support unibyte strings. Fix the type of
2475 `len' according to what STRING_CHAR_AND_LENGTH expects.
2476 (bidi_paragraph_init, bidi_resolve_explicit_1)
2477 (bidi_resolve_explicit, bidi_resolve_weak)
2478 (bidi_level_of_next_char, bidi_move_to_visually_next):
2479 Support iteration over a string.
2480 (bidi_set_sor_type, bidi_resolve_explicit_1)
2481 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2482 can now be zero (for strings); special values 0 and -1 were
2483 changed to -1 and -2, respectively.
2484 (bidi_char_at_pos): New function.
2485 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2486 Call it instead of FETCH_MULTIBYTE_CHAR.
2487 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2488 initialized to valid values.
2489 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2490 values.
2491 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2492 the test for valid cached positions. Fix the logic for looking up
2493 the sentinel state in the cache. GCPRO the Lisp string we are
2494 iterating.
2495 (bidi_push_it, bidi_pop_it): New functions.
2496 (bidi_initialize): Initialize the bidi cache start stack pointer.
2497 (bidi_cache_ensure_space): New function, refactored from part of
2498 bidi_cache_iterator_state. Don't assume the required size is just
2499 one BIDI_CACHE_CHUNK away.
2500 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2501 (bidi_count_bytes, bidi_char_at_pos): New functions.
2502 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2503 always valid if bidi_cache_idx is valid.
2504 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2505 is valid if it's going to be used.
2506 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2507 (bidi_cache_fetch_state, bidi_cache_search)
2508 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2509 (bidi_cache_iterator_state, bidi_cache_find)
2510 (bidi_find_other_level_edge, bidi_cache_start_stack):
2511 All variables related to cache indices are now EMACS_INT.
2512
2513 * dispextern.h (struct bidi_string_data): New structure.
2514 (struct bidi_it): New member `string'. Make flag members be 1-bit
2515 fields, and put them last in the struct.
2516 (compute_display_string_pos, compute_display_string_end):
2517 Update prototypes.
2518 (bidi_push_it, bidi_pop_it): Add prototypes.
2519 (struct iterator_stack_entry): New members bidi_p,
2520 paragraph_embedding, and from_disp_prop_p.
2521 (struct it): Member bidi_p is now a bit field 1 bit wide.
2522 (bidi_shelve_cache, bidi_unshelve_cache):
2523 Declare prototypes.
2524
2525 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2526 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2527 and vector-like objects.
2528
2529 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2530 cache around display iteration.
2531
2532 * window.c (Fwindow_end, window_scroll_pixel_based)
2533 (displayed_window_lines, Frecenter): Save and restore the bidi
2534 cache around display iteration.
2535
2536 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2537
2538 * editfns.c (Fdelete_region): Clarify the use of the named
2539 parameters (bug#6788).
2540
2541 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2542
2543 * indent.c (Fvertical_motion): Set and restore w->pointm when
2544 saving and restoring the window's buffer (Bug#9006).
2545
2546 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2547
2548 * editfns.c (Fstring_to_char): Clarify just what is returned
2549 (bug#6576). Text by Eli Zaretskii.
2550
2551 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2552
2553 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2554
2555 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2556
2557 * buffer.c (mmap_find): Fix a typo.
2558
2559 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2560
2561 Fix execution of x selection hooks.
2562 * xselect.c (Qx_lost_selection_functions)
2563 (Qx_sent_selection_functions): New vars.
2564 (syms_of_xselect): DEFSYM them.
2565 (x_handle_selection_request): Pass Qx_sent_selection_functions
2566 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2567 (x_handle_selection_clear,x_clear_frame_selections):
2568 Pass Qx_lost_selection_functions rather than
2569 Vx_lost_selection_functions to Frun_hook_with_args.
2570
2571 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2572
2573 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2574 The old code sometimes used this field without initializing it.
2575
2576 * alloc.c (gc_sweep): Don't read past end of array.
2577 In theory, the old code could also have corrupted Emacs internals,
2578 though it'd be very unlikely.
2579
2580 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2581
2582 * character.c (Fcharacterp): Don't advertise optional ignored
2583 argument. (Bug#4026)
2584
2585 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2586
2587 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2588 key" (bug#4257).
2589
2590 * window.c (Fset_window_start): Doc fix (bug#4199).
2591 (Fset_window_hscroll): Ditto.
2592
2593 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2594
2595 Fix minor new problems caught by GCC 4.6.1.
2596 * term.c (init_tty): Remove unused local.
2597 * xsettings.c (store_monospaced_changed): Define this function only
2598 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2599 not used otherwise.
2600
2601 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2602
2603 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2604
2605 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2606
2607 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2608 are the mini-buffer and the echo area (bug#3320).
2609
2610 * term.c (init_tty): Remove support for supdup, c10 and perq
2611 terminals, which are no longer supported (bug#1482).
2612
2613 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2614
2615 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2616
2617 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2618
2619 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2620 for non-popups (Bug#3642).
2621
2622 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2623
2624 * alloc.c (reset_malloc_hooks): Protoize.
2625 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2626 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2627 * cm.c (losecursor): Likewise.
2628 * data.c (fmod): Likewise.
2629 * dispnew.c (swap_glyphs_in_rows): Likewise.
2630 * emacs.c (memory_warning_signal): Likewise.
2631 * floatfns.c (float_error): Likewise.
2632 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2633 (otf_open, font_otf_capability, generate_otf_features)
2634 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2635 Likewise.
2636 * image.c (pbm_read_file): Likewise.
2637 * indent.c (string_display_width): Likewise.
2638 * intervals.c (check_for_interval, search_for_interval)
2639 (inc_interval_count, count_intervals, root_interval)
2640 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2641 * lread.c (defalias): Likewise.
2642 * ralloc.c (r_alloc_check): Likewise.
2643 * regex.c (set_image_of_range_1, set_image_of_range)
2644 (regex_grow_registers): Likewise.
2645 * sysdep.c (strerror): Likewise.
2646 * termcap.c (valid_filename_p, tprint, main): Likewise.
2647 * tparam.c (main): Likewise.
2648 * unexhp9k800.c (run_time_remap, save_data_space)
2649 (update_file_ptrs, read_header, write_header, calculate_checksum)
2650 (copy_file, copy_rest, display_header): Likewise.
2651 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2652 Likewise.
2653 * xdisp.c (check_it): Likewise.
2654 * xfaces.c (register_color, unregister_color, unregister_colors):
2655 Likewise.
2656 * xfns.c (print_fontset_result): Likewise.
2657 * xrdb.c (member, fatal, main): Likewise.
2658
2659 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 Fix minor problems found by static checking (Bug#9031).
2662 * chartab.c (char_table_set_range, map_sub_char_table):
2663 Remove unused locals.
2664 (uniprop_table): Now static.
2665 * composite.c (_work_char): Remove unused static var.
2666
2667 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2668
2669 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2670
2671 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2672
2673 * gtkutil.c (qttip_cb): Remove code without function.
2674
2675 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2676
2677 * w32.c (pthread_sigmask): New stub.
2678
2679 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 Use pthread_sigmask, not sigprocmask (Bug#9010).
2682 sigprocmask is portable only for single-threaded applications, and
2683 Emacs can be multi-threaded when it uses GTK.
2684 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2685 (LIBES): Use it.
2686 * callproc.c (Fcall_process):
2687 * process.c (create_process):
2688 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2689 Use pthread_sigmask, not sigprocmask.
2690
2691 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2692
2693 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2694 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2695 wrong (Bug#8591).
2696
2697 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2698
2699 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2700 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2701 (xg_hide_tooltip): Fix comment.
2702
2703 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2704 in registerServicesMenuSendTypes.
2705 (validRequestorForSendType): Don't check ns_return_types.
2706
2707 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2708 ns_return_type.
2709
2710 2011-07-08 Jason Rumney <jasonr@gnu.org>
2711
2712 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2713 frame struct members of non-existent frames (Bug#6284).
2714
2715 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2716
2717 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2718 variable firstTime not needed on OSX >= 10.6.
2719 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2720 >= 10.5. Use setKnobProportion, setDoubleValue.
2721
2722 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2723 (MAC_OS_X_VERSION_10_5): Define if not defined.
2724 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2725 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2726 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2727
2728 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2729 cString and lossyCString on OSX >= 10.4
2730
2731 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2732 sizeToFit on OSX >= 10.2.
2733
2734 * nsimage.m (allocInitFromFile): Don't use deprecated method
2735 bestRepresentationForDevice on OSX >= 10.6.
2736
2737 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2738 to avoid warning.
2739
2740 * emacs.c: Declare unexec_init_emacs_zone.
2741
2742 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2743
2744 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2745
2746 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2747 on svcsMenu (Bug#8842).
2748
2749 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2750 ns_return_types.
2751 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2752
2753 * nsterm.m (QUTF8_STRING): Declare.
2754 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2755 (validRequestorForSendType): Return type is (id).
2756 Change indexOfObjectIdenticalTo to indexOfObject.
2757 Check if we have local selection before returning self (Bug#8842).
2758 (writeSelectionToPasteboard): Put local selection into paste board
2759 if we have a local selection (Bug#8842).
2760 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2761
2762 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2763 (ns_get_local_selection): Declare.
2764
2765 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2766
2767 * keymap.c (describe_map_tree): Don't insert a double newline at
2768 the end of the buffer (bug#1169) and return whether we inserted
2769 something.
2770
2771 * callint.c (Fcall_interactively): Change "reading args" to
2772 "providing args" to try to clarify what it does (bug#1010).
2773
2774 2011-07-07 Kenichi Handa <handa@m17n.org>
2775
2776 * composite.c (composition_compute_stop_pos): Ignore a static
2777 composition starting before CHARPOS (Bug#8915).
2778
2779 * xdisp.c (handle_composition_prop): Likewise.
2780
2781 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2782
2783 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2784 (Bug#9015)
2785
2786 2011-07-07 Kenichi Handa <handa@m17n.org>
2787
2788 * character.h (unicode_category_t): New enum type.
2789
2790 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2791 (Qchar_code_property_table): New variable.
2792 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2793 (UNIPROP_COMPRESSED_FORM_P): New macros.
2794 (char_table_ascii): Uncompress the compressed values.
2795 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2796 Uncompress the compressed values.
2797 (sub_char_table_ref_and_range): Likewise.
2798 (char_table_ref_and_range): Uncompress the compressed values.
2799 (sub_char_table_set): New arg is_uniprop. Callers changed.
2800 Uncompress the compressed values.
2801 (sub_char_table_set_range): Args changed. Callers changed.
2802 (char_table_set_range): Adjuted for the above change.
2803 (map_sub_char_table): Delete args default_val and parent. Add arg
2804 top. Give decoded values to a Lisp function.
2805 (map_char_table): Adjust for the above change. Give decoded
2806 values to a Lisp function. Gcpro more variables.
2807 (uniprop_table_uncompress)
2808 (uniprop_decode_value_run_length): New functions.
2809 (uniprop_decoder, uniprop_decoder_count): New variables.
2810 (uniprop_get_decoder, uniprop_encode_value_character)
2811 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2812 New functions.
2813 (uniprop_encoder, uniprop_encoder_count): New variables.
2814 (uniprop_get_encoder, uniprop_table)
2815 (Funicode_property_table_internal, Fget_unicode_property_internal)
2816 (Fput_unicode_property_internal): New functions.
2817 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2818 Sunicode_property_table_internal, Sget_unicode_property_internal,
2819 and Sput_unicode_property_internal. Defvar_lisp
2820 char-code-property-alist.
2821
2822 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2823 Vunicode_category_table.
2824
2825 * font.c (font_range): Adjust for the change of
2826 Vunicode_category_table.
2827
2828 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2829
2830 * m/iris4d.h: Remove file, move contents ...
2831 * s/irix6-5.h: ... here.
2832
2833 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2834
2835 Remove unportable assumption about struct layout (Bug#8884).
2836 * alloc.c (mark_buffer):
2837 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2838 (clone_per_buffer_values): Don't assume that
2839 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2840 This isn't true in general, and it's particularly not true
2841 if Emacs is configured with --with-wide-int.
2842 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2843 New macros, used in the buffer.c change.
2844
2845 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2846
2847 * xsettings.c: Use both GConf and GSettings if both are available.
2848 (store_config_changed_event): Add comment.
2849 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2850 (store_tool_bar_style_changed): New functions.
2851 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2852 (struct xsettings): Move font inside HAVE_XFT.
2853 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2854 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2855 Move inside HAVE_XFT.
2856 (something_changed_gsettingsCB): Rename from something_changedCB.
2857 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2858 also.
2859 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2860 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2861 (something_changed_gconfCB): Rename from something_changedCB.
2862 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2863 (parse_settings): Move check for font inside HAVE_XFT.
2864 (read_settings, apply_xft_settings): Add comment.
2865 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2866 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2867 call store_font_name_changed.
2868 (xft_settings_event): Add comment.
2869 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2870 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2871 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2872 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2873 (xsettings_initialize): Call init_gsettings last.
2874 (xsettings_get_system_font, xsettings_get_system_normal_font):
2875 Add comment.
2876
2877 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 Random fixes. E.g., (random) never returned negative values.
2880 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2881 subseconds part to the entropy, as that's a bit more random.
2882 Prefer signed to unsigned, since the signedness doesn't matter and
2883 in general we prefer signed. When given a limit, use a
2884 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2885 latter isn't right if USE_2_TAGS_FOR_INTS.
2886 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2887 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2888
2889 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2890
2891 * textprop.c (text_property_stickiness):
2892 Obey Vtext_property_default_nonsticky.
2893 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2894 * w32fns.c (syms_of_w32fns):
2895 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2896
2897 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2900 This is more efficient than Ffile_directory_p and avoids a minor race.
2901
2902 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2903
2904 * buffer.c (Foverlay_put): Say what the return value is
2905 (bug#7835).
2906
2907 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2908 is a directory before asking whether to use the file name
2909 (bug#7564).
2910 (barf_or_query_if_file_exists): Make the "File is a directory"
2911 error be more correct.
2912
2913 * fns.c (Frequire): Remove the mention of the .gz files, since
2914 that's installation-specific, but keep the mention of
2915 `get-load-suffixes'.
2916
2917 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2918
2919 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2920 Report string overflow if the output is too long.
2921
2922 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2923
2924 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2925 (syms_of_gnutls): Remove duplicate DEFSYM for
2926 Qgnutls_bootprop_verify_hostname_error, an error for
2927 Qgnutls_bootprop_verify_error (which is no longer used).
2928
2929 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2930 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2931 Also (re)move comments that are misplaced or no longer relevant.
2932
2933 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2934
2935 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2936
2937 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2938
2939 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2940 and background color parameters if they have been changed.
2941
2942 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2943
2944 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2945
2946 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 * xsettings.c (SYSTEM_FONT): Define only when used.
2949 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2950
2951 * keymap.c (access_keymap_1): Now static.
2952
2953 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2954
2955 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2956 leave any prefix arg for the up event (Bug#1586).
2957
2958 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2959
2960 * lread.c (syms_of_lread): Mention single symbols defined by
2961 `defvar' or `defconst' (bug#7154).
2962
2963 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2964 (Frequire): Mention get-load-suffixes.
2965
2966 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2967
2968 * window.h (window): Remove clone_number slot.
2969 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2970 Remove.
2971 (make_parent_window, make_window, saved_window)
2972 (Fset_window_configuration, save_window_save): Don't deal with
2973 clone numbers.
2974 * buffer.c (Qclone_number): Remove declaration.
2975 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2976
2977 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2978
2979 Add multiple inheritance to keymaps.
2980 * keymap.c (Fmake_composed_keymap): New function.
2981 (Fset_keymap_parent): Simplify.
2982 (fix_submap_inheritance): Remove.
2983 (access_keymap_1): New function extracted from access_keymap to handle
2984 embedded parents and handle lists of maps.
2985 (access_keymap): Use it.
2986 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2987 (Fcopy_keymap): Handle embedded parents.
2988 (Fcommand_remapping, define_as_prefix): Simplify.
2989 (Fkey_binding): Simplify.
2990 (syms_of_keymap): Move minibuffer-local-completion-map,
2991 minibuffer-local-filename-completion-map,
2992 minibuffer-local-must-match-map, and
2993 minibuffer-local-filename-must-match-map to Elisp.
2994 (syms_of_keymap): Defsubr make-composed-keymap.
2995 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2996 (parse_menu_item): Trivial simplification.
2997
2998 2011-07-01 Glenn Morris <rgm@gnu.org>
2999
3000 * Makefile.in (SETTINGS_LIBS): Fix typo.
3001
3002 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3003
3004 * coding.c (Fencode_coding_string): Record the last coding system
3005 used, as the function doc string says (bug#8738).
3006
3007 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3008
3009 * xsettings.c (store_monospaced_changed): Take new font as arg and
3010 check for change against current_mono_font.
3011 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3012 (emacs_settings_constructor, emacs_settings_get_property)
3013 (emacs_settings_set_property, emacs_settings_class_init)
3014 (emacs_settings_init, gsettings_obj): Remove.
3015 (something_changedCB): New function for HAVE_GSETTINGS.
3016 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3017 with value as argument.
3018 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3019 g_settings_new (Bug#8967). Do not create gsettings_obj.
3020 Remove calls to g_settings_bind. Connect something_changedCB to
3021 "changed".
3022
3023 * xgselect.c: Add defined (HAVE_GSETTINGS).
3024 (xgselect_initialize): Ditto.
3025
3026 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3027 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3028 xg_select.
3029
3030 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 * eval.c (struct backtrace): Simplify and port the data structure.
3033 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3034 signed bit field, as this assumption is not portable and it makes
3035 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3036 "char debug_on_exit : 1" as this is not portable either; instead,
3037 use the portable "unsigned int debug_on_exit : 1". Remove unused
3038 member evalargs. Remove obsolete comments about cc bombing out.
3039
3040 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3041
3042 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3043 Let HAVE_GSETTINGS override HAVE_GCONF.
3044 (store_monospaced_changed): New function.
3045 (EMACS_SETTINGS): A new type derived from GObject to handle
3046 GSettings notifications.
3047 (emacs_settings_constructor, emacs_settings_get_property)
3048 (emacs_settings_set_property, emacs_settings_class_init):
3049 New functions.
3050 (gsettings_client, gsettings_obj): New variables.
3051 (GSETTINGS_SCHEMA): New define.
3052 (something_changedCB): Call store_monospaced_changed.
3053 (init_gsettings): New function.
3054 (xsettings_initialize): Call init_gsettings.
3055 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3056 to NULL.
3057
3058 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3059 GCONF_CFLAGS/LIBS.
3060
3061 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3062
3063 * window.c (resize_root_window, grow_mini_window)
3064 (shrink_mini_window): Rename Qresize_root_window to
3065 Qwindow_resize_root_window and Qresize_root_window_vertically to
3066 Qwindow_resize_root_window_vertically.
3067
3068 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3069
3070 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3071
3072 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3073
3074 * makefile.w32-in: Redesign dependencies so they reflect more
3075 clearly which files are directly included by each source file,
3076 and not through other includes.
3077
3078 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3079
3080 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3081 (sort_overlays, overlay_strings): When an overlay's clone number
3082 matches the window's clone number process the overlay even if
3083 the overlay's window property doesn't match the current window.
3084
3085 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3086 (Fwindow_hchild): Rename to Fwindow_left_child.
3087 (Fwindow_next): Rename to Fwindow_next_sibling.
3088 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3089 (resize_window_check): Rename to window_resize_check.
3090 (resize_window_apply): Rename to window_resize_apply.
3091 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3092 (Fdelete_other_windows_internal, resize_frame_windows)
3093 (Fsplit_window_internal, Fdelete_window_internal)
3094 (grow_mini_window, shrink_mini_window)
3095 (Fresize_mini_window_internal): Fix callers accordingly.
3096
3097 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3098
3099 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3100 (emacs_fixed_set_min_size): Remove.
3101 (emacs_fixed_new): Take frame as argument.
3102
3103 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3104 (_EmacsFixedPrivate): Remove minwidth/height.
3105 Add struct frame *f.
3106 (emacs_fixed_init): Initialize priv->f.
3107 (get_parent_class, emacs_fixed_set_min_size): Remove.
3108 (emacs_fixed_new): Set priv->f to argument.
3109 (emacs_fixed_get_preferred_width)
3110 (emacs_fixed_get_preferred_height): Use min_width/height from
3111 frames size_hint to set minimum and natural (Bug#8919).
3112 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3113 and use min_width/height from frames size_hint to set
3114 min_width/height (Bug#8919).
3115
3116 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3117 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3118 Fix indentation.
3119
3120 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3121
3122 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3123 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3124 called at ZV.
3125
3126 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3127
3128 * process.c (wait_reading_process_output): Bypass select if
3129 waiting for a cell while ignoring keyboard input, and input is
3130 pending. Suggested by Jan Djärv (Bug#8869).
3131
3132 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3133
3134 Use gnulib's dup2 module instead of rolling our own.
3135 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3136
3137 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3138
3139 * dispnew.c (scrolling_window): Before scrolling, turn off a
3140 mouse-highlight in the window being scrolled.
3141
3142 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3143
3144 Move DEFSYM to lisp.h and use everywhere.
3145
3146 * character.h (DEFSYM): Move declaration...
3147 * lisp.h (DEFSYM): ...here.
3148
3149 * gnutls.c:
3150 * minibuf.c:
3151 * w32menu.c:
3152 * w32proc.c:
3153 * w32select.c: Don't include character.h.
3154
3155 * alloc.c (syms_of_alloc):
3156 * buffer.c (syms_of_buffer):
3157 * bytecode.c (syms_of_bytecode):
3158 * callint.c (syms_of_callint):
3159 * casefiddle.c (syms_of_casefiddle):
3160 * casetab.c (init_casetab_once):
3161 * category.c (init_category_once, syms_of_category):
3162 * ccl.c (syms_of_ccl):
3163 * cmds.c (syms_of_cmds):
3164 * composite.c (syms_of_composite):
3165 * dbusbind.c (syms_of_dbusbind):
3166 * dired.c (syms_of_dired):
3167 * dispnew.c (syms_of_display):
3168 * doc.c (syms_of_doc):
3169 * editfns.c (syms_of_editfns):
3170 * emacs.c (syms_of_emacs):
3171 * eval.c (syms_of_eval):
3172 * fileio.c (syms_of_fileio):
3173 * fns.c (syms_of_fns):
3174 * frame.c (syms_of_frame):
3175 * fringe.c (syms_of_fringe):
3176 * insdel.c (syms_of_insdel):
3177 * keymap.c (syms_of_keymap):
3178 * lread.c (init_obarray, syms_of_lread):
3179 * macros.c (syms_of_macros):
3180 * msdos.c (syms_of_msdos):
3181 * print.c (syms_of_print):
3182 * process.c (syms_of_process):
3183 * search.c (syms_of_search):
3184 * sound.c (syms_of_sound):
3185 * syntax.c (init_syntax_once, syms_of_syntax):
3186 * terminal.c (syms_of_terminal):
3187 * textprop.c (syms_of_textprop):
3188 * undo.c (syms_of_undo):
3189 * w32.c (globals_of_w32):
3190 * window.c (syms_of_window):
3191 * xdisp.c (syms_of_xdisp):
3192 * xfaces.c (syms_of_xfaces):
3193 * xfns.c (syms_of_xfns):
3194 * xmenu.c (syms_of_xmenu):
3195 * xsettings.c (syms_of_xsettings):
3196 * xterm.c (syms_of_xterm): Use DEFSYM.
3197
3198 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3199
3200 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3201
3202 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3203
3204 Integer and buffer overflow fixes (Bug#8873).
3205
3206 * print.c (printchar, strout): Check for string overflow.
3207 (PRINTPREPARE, printchar, strout):
3208 Don't set size unless allocation succeeds.
3209
3210 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3211 for sizes. Check for string overflow more accurately.
3212 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3213
3214 * macros.c: Integer and buffer overflow fixes.
3215 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3216 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3217 Use ptrdiff_t, not int, for sizes.
3218 Don't increment bufsize until after realloc succeeds.
3219 Check for size-calculation overflow.
3220 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3221
3222 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3223
3224 * lread.c: Integer overflow fixes.
3225 (read_integer): Radix is now EMACS_INT, not int,
3226 to improve quality of diagnostics for out-of-range radices.
3227 Calculate buffer size correctly for out-of-range radices.
3228 (read1): Check for integer overflow in radices, and in
3229 read-circle numbers.
3230 (read_escape): Avoid int overflow.
3231 (Fload, openp, read_buffer_size, read1)
3232 (substitute_object_recurse, read_vector, read_list, map_obarray):
3233 Use ptrdiff_t, not int, for sizes.
3234 (read1): Use EMACS_INT, not int, for sizes.
3235 Check for size overflow.
3236
3237 * image.c (cache_image): Check for size arithmetic overflow.
3238
3239 * lread.c: Integer overflow issues.
3240 (saved_doc_string_size, saved_doc_string_length)
3241 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3242 Now ptrdiff_t, not int.
3243 (read1): Don't assume doc string length fits in int. Check for
3244 out-of-range doc string lengths.
3245 (read_list): Don't assume file position fits in int.
3246 (read_escape): Check for hex character overflow.
3247
3248 2011-06-22 Leo Liu <sdl.web@gmail.com>
3249
3250 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3251 Move to minibuffer.el.
3252
3253 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3254
3255 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3256 The following patches are for when GLYPH_DEBUG && !XASSERT.
3257 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3258 * dispnew.c (flush_stdout):
3259 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3260 Mark as externally visible.
3261 * dispnew.c (check_window_matrix_pointers): Now static.
3262 * dispnew.c (window_to_frame_vpos):
3263 * xfns.c (unwind_create_frame):
3264 * xterm.c (x_check_font): Remove unused local.
3265 * scroll.c (CHECK_BOUNDS):
3266 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3267 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3268 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3269 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3270 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3271 Now static.
3272 (debug_method_add): Use va_list and vsprintf rather than relying
3273 on undefined behavior with wrong number of arguments.
3274 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3275 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3276 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3277 since we're not interested in debugging glyphs with old libraries.
3278 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3279 GCC 4.6.0's static checking.
3280
3281 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3282
3283 Integer overflow and signedness fixes (Bug#8873).
3284 A few related buffer overrun fixes, too.
3285
3286 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3287
3288 * dispextern.h (struct face.stipple):
3289 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3290 (x_bitmap_mask, x_allocate_bitmap_record)
3291 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3292 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3293 (x_create_bitmap_from_xpm_data):
3294 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3295 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3296 (.bitmaps_last):
3297 * xfaces.c (load_pixmap):
3298 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3299 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3300 (.bitmaps_last, struct x_output.icon_bitmap):
3301 Use ptrdiff_t, not int, for bitmap indexes.
3302 (x_allocate_bitmap_record): Check for size overflow.
3303 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3304
3305 Use ptrdiff_t, not int, for overlay counts.
3306 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3307 * editfns.c (overlays_around, get_pos_property):
3308 * textprop.c (get_char_property_and_overlay):
3309 * xdisp.c (next_overlay_change, note_mouse_highlight):
3310 * xfaces.c (face_at_buffer_position):
3311 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3312 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3313 (Fnext_overlay_change, Fprevious_overlay_change)
3314 (mouse_face_overlay_overlaps, Foverlays_in):
3315 Use ptrdiff_t, not int, for sizes.
3316 (overlays_at, overlays_in): Check for size-calculation overflow.
3317
3318 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3319
3320 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3321 (x_session_initialize): Do not assume string length fits in int.
3322
3323 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3324 This is unlikely, but can occur if DPI is outlandish.
3325
3326 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3327 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3328
3329 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3330 * xrdb.c (magic_file_p, search_magic_path):
3331 Omit last arg SUFFIX; it was always 0. All callers changed.
3332 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3333
3334 * xfont.c (xfont_match): Avoid need for strlen.
3335
3336 * xfns.c: Don't assume strlen fits in int.
3337 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3338
3339 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3340 not unsigned long, as we prefer signed integers. All callers changed.
3341 Detect integer overflow in repeat count.
3342 (message_dolog): Don't assume print length fits in 39 bytes.
3343 (display_mode_element): Don't assume strlen fits in int.
3344
3345 * termcap.c: Don't assume sizes fit in int and never overflow.
3346 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3347 (gobble_line): Check for size-calculation overflow.
3348
3349 * minibuf.c (Fread_buffer):
3350 * lread.c (intern, intern_c_string):
3351 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3352 Don't assume string length fits in int.
3353
3354 * keyboard.c (parse_tool_bar_item):
3355 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3356
3357 * font.c: Don't assume string length fits in int.
3358 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3359 Use ptrdiff_t, not int.
3360 (font_intern_prop): Don't assume string length fits in int.
3361 Don't assume integer property fits in fixnum.
3362 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3363
3364 * filelock.c: Fix some buffer overrun and integer overflow issues.
3365 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3366 Reformulate so as not to need the command string.
3367 Invoke gzip -cd rather than gunzip, as it's more portable.
3368 (lock_info_type, lock_file_1, lock_file):
3369 Don't assume pid_t and time_t fit in unsigned long.
3370 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3371 (current_lock_owner): Prefer signed type for sizes.
3372 Use memcpy, not strncpy, where memcpy is what is really wanted.
3373 Don't assume (via atoi) that time_t and pid_t fit in int.
3374 Check for time_t and/or pid_t out of range, e.g., via a network share.
3375 Don't alloca where an auto var works fine.
3376
3377 * fileio.c: Fix some integer overflow issues.
3378 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3379 Don't assume string length fits in int.
3380 (directory_file_name): Don't assume string length fits in long.
3381 (make_temp_name): Don't assume pid fits in int, or that its print
3382 length is less than 20.
3383
3384 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3385
3386 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3387
3388 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3389
3390 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3391 We prefer signed integers, even for size calculations.
3392
3393 * emacs.c: Don't assume string length fits in 'int'.
3394 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3395 (main): Don't invoke strlen when not needed.
3396
3397 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3398 (XD_DEBUG_MESSAGE): Don't waste a byte.
3399
3400 * callproc.c (getenv_internal_1, getenv_internal)
3401 (Fgetenv_internal):
3402 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3403
3404 * lread.c (invalid_syntax): Omit length argument.
3405 All uses changed. This doesn't fix a bug, but it simplifies the
3406 code away from its former Hollerith-constant appearance, and it's
3407 one less 'int' to worry about when looking at integer-overflow issues.
3408 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3409
3410 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3411 This didn't break anything, but it didn't help either.
3412 It's confusing to put a bogus integer in a place where the actual
3413 value does not matter.
3414 (LIST_END_P): Remove unused macro and its bogus comment.
3415 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3416
3417 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3418 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3419 implementation.
3420 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3421 We prefer signed types, and the value cannot exceed the EMACS_INT
3422 range anyway (because otherwise the length would not be representable).
3423 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3424 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3425 This avoids a GCC warning when WIDE_EMACS_INT.
3426
3427 * indent.c (sane_tab_width): New function.
3428 (current_column, scan_for_column, Findent_to, position_indentation)
3429 (compute_motion): Use it. This is just for clarity.
3430 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3431
3432 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3433
3434 * lisp.h (lint_assume): New macro.
3435 * composite.c (composition_gstring_put_cache):
3436 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3437
3438 * editfns.c, insdel.c:
3439 Omit unnecessary forward decls, to simplify future changes.
3440
3441 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3442
3443 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3444
3445 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3446 Use much-faster test for byte-length change.
3447 Don't assume string byte-length fits in 'int'.
3448 Check that character arg fits in 'int'.
3449 (mapcar1): Declare byte as byte, for clarity.
3450
3451 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3452
3453 * fns.c (concat): Catch string overflow earlier.
3454 Do not rely on integer wraparound.
3455
3456 * dispextern.h (struct it.overlay_strings_charpos)
3457 (struct it.selective): Now EMACS_INT, not int.
3458 * xdisp.c (forward_to_next_line_start)
3459 (back_to_previous_visible_line_start)
3460 (reseat_at_next_visible_line_start, next_element_from_buffer):
3461 Don't arbitrarily truncate the value of 'selective' to int.
3462
3463 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3464
3465 * composite.c: Don't truncate sizes to 'int'.
3466 (composition_gstring_p, composition_reseat_it)
3467 (composition_adjust_point): Use EMACS_INT, not int.
3468 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3469 not EMACS_UINT, for indexes.
3470
3471 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3472
3473 * buffer.c: Include <verify.h>.
3474 (struct sortvec.priority, struct sortstr.priority):
3475 Now EMACS_INT, not int.
3476 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3477 (struct sortstr.size, record_overlay_string)
3478 (struct sortstrlist.size, struct sortlist.used):
3479 Don't truncate size to int.
3480 (record_overlay_string): Check for size-calculation overflow.
3481 (init_buffer_once): Check at compile-time, not run-time.
3482
3483 2011-06-22 Jim Meyering <meyering@redhat.com>
3484
3485 Don't leak an XBM-image-sized buffer
3486 * image.c (xbm_load): Free the image buffer after using it.
3487
3488 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 Port to Sun C.
3491 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3492 that Sun C diagnosed.
3493 * fns.c (secure_hash): Fix pointer signedness issue.
3494 * intervals.c (static_offset_intervals): New function.
3495 (offset_intervals): Use it.
3496
3497 2011-06-21 Leo Liu <sdl.web@gmail.com>
3498
3499 * deps.mk (fns.o):
3500 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3501 sha512.h.
3502
3503 * fns.c (secure_hash): Rename from crypto_hash_function and change
3504 the first arg to accept symbols.
3505 (Fsecure_hash): New primitive.
3506 (syms_of_fns): New symbols.
3507
3508 2011-06-20 Deniz Dogan <deniz@dogan.se>
3509
3510 * process.c (Fset_process_buffer): Clarify return value in
3511 docstring.
3512
3513 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3514
3515 * dispnew.c (add_window_display_history): Use BVAR.
3516
3517 * xdisp.c (debug_method_add): Use BVAR.
3518 (check_window_end, dump_glyph_matrix, dump_glyph)
3519 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3520
3521 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3522 Likewise.
3523
3524 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3525 check till after the cache is created in init_frame_faces.
3526
3527 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3528
3529 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3530
3531 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3532
3533 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3534 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3535 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3536
3537 Improve buffer-overflow checking (Bug#8873).
3538 * fileio.c (Finsert_file_contents):
3539 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3540 Remove the old (too-loose) buffer overflow checks.
3541 They weren't needed, since make_gap checks for buffer overflow.
3542 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3543 The old code merely checked for Emacs fixnum overflow, and relied
3544 on undefined (wraparound) behavior. The new code avoids undefined
3545 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3546
3547 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3548 Tune. Don't use wider integers than needed. Don't use alloca.
3549 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3550
3551 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3552
3553 * insdel.c, lisp.h (buffer_overflow): New function.
3554 (insert_from_buffer_1, replace_range, replace_range_2):
3555 * insdel.c (make_gap_larger):
3556 * editfns.c (Finsert_char):
3557 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3558
3559 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3560
3561 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3562
3563 Integer overflow and signedness fixes (Bug#8873).
3564
3565 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3566 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3567
3568 * fileio.c: Don't assume EMACS_INT fits in off_t.
3569 (emacs_lseek): New static function.
3570 (Finsert_file_contents, Fwrite_region): Use it.
3571 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3572
3573 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3574
3575 * fns.c: Don't overflow int when computing a list length.
3576 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3577 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3578 truncation on 64-bit hosts. Check for QUIT every
3579 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3580 faster and is responsive enough.
3581 (Flength): Report an error instead of overflowing an integer.
3582 (Fsafe_length): Return a float if the value is not representable
3583 as a fixnum. This shouldn't happen except in contrived situations.
3584 (Fnthcdr, Fsort): Don't assume list length fits in int.
3585 (Fcopy_sequence): Don't assume vector length fits in int.
3586
3587 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3588 (header_size, word_size): New constants.
3589 (allocate_vectorlike): Don't check size overflow here.
3590 (allocate_vector): Check it here instead, since this is the only
3591 caller of allocate_vectorlike that could cause overflow.
3592 Check that the new vector's length is representable as a fixnum.
3593
3594 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3595 The previous code was bogus. For example, next_almost_prime (32)
3596 returned 39, which is undesirable as it is a multiple of 3; and
3597 next_almost_prime (24) returned 25, which is a multiple of 5 so
3598 why was the code bothering to check for multiples of 7?
3599
3600 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3601
3602 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3603
3604 Variadic C functions now count arguments with ptrdiff_t.
3605 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3606 Back then I didn't know that the Emacs coding style prefers signed int.
3607 Also, in the meantime I found a few more instances where arguments
3608 were being counted with int, which may truncate counts on 64-bit
3609 machines, or EMACS_INT, which may be unnecessarily wide.
3610 * lisp.h (struct Lisp_Subr.function.aMANY)
3611 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3612 Arg counts are now ptrdiff_t, not size_t.
3613 All variadic functions and their callers changed accordingly.
3614 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3615 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3616 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3617 * callint.c (Fcall_interactively): Check arg count for overflow,
3618 to avoid potential buffer overrun. Use signed char, not 'int',
3619 for 'varies' array, so that we needn't bother to check its size
3620 calculation for overflow.
3621 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3622 * eval.c (apply_lambda):
3623 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3624 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3625 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3626
3627 * callint.c (Fcall_interactively): Don't use index var as event count.
3628
3629 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3630 * mem-limits.h (SIZE): Remove; no longer used.
3631
3632 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3633
3634 Remove unnecessary casts.
3635 * xterm.c (x_term_init):
3636 * xfns.c (x_set_border_pixel):
3637 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3638 These aren't needed now that we assume ANSI C.
3639
3640 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3641 It's more likely to cause problems (due to unsigned overflow)
3642 than to cure them.
3643
3644 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3645
3646 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3647
3648 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3649
3650 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3651
3652 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3653
3654 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3655
3656 GLYPH_CODE_FACE returns EMACS_INT, not int.
3657 * dispextern.h (merge_faces):
3658 * xfaces.c (merge_faces):
3659 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3660 Don't assume EMACS_INT fits in int.
3661
3662 * character.h (CHAR_VALID_P): Remove unused parameter.
3663 * fontset.c, lisp.h, xdisp.c: All uses changed.
3664
3665 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3666
3667 * fns.c (concat): Minor tuning based on overflow analysis.
3668 This doesn't fix any bugs. Use int to hold character, instead
3669 of constantly refetching from Emacs object. Use XFASTINT, not
3670 XINT, for value known to be a character. Don't bother comparing
3671 a single byte to 0400, as it's always less.
3672
3673 * floatfns.c (Fexpt):
3674 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3675
3676 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3677 for characters.
3678
3679 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3680
3681 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3682 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3683 incorrectly succeed when S was a string, because 4294967386 was
3684 truncated before it was used.
3685
3686 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3687 Otherwise, an out-of-range integer could cause undefined behavior
3688 on a 64-bit host.
3689
3690 * composite.c: Use int, not EMACS_INT, for characters.
3691 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3692 EMACS_INT, for values that are known to be in character range.
3693 This doesn't fix any bugs but is the usual style inside Emacs and
3694 may generate better code on 32-bit machines.
3695
3696 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3697 This is for reasons similar to the recent CHAR_STRING fix.
3698 * charset.c (Fencode_char): Check that character arg is actually
3699 a character. Pass an int to ENCODE_CHAR.
3700 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3701 wider than 'int', as a compile-time check to prevent future regressions
3702 in this area.
3703
3704 * character.c (char_string): Remove unnecessary casts.
3705
3706 Make sure a 64-bit char is never passed to CHAR_STRING.
3707 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3708 by silently ignoring the top 32 bits, allowing some values
3709 that were far too large to be valid characters.
3710 * character.h: Include <verify.h>.
3711 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3712 arguments are no wider than unsigned, as a compile-time check
3713 to prevent future regressions in this area.
3714 * data.c (Faset):
3715 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3716 (Fsubst_char_in_region):
3717 * fns.c (concat):
3718 * xdisp.c (decode_mode_spec_coding):
3719 Adjust to CHAR_STRING's new requirement.
3720 * editfns.c (Finsert_char, Fsubst_char_in_region):
3721 * fns.c (concat): Check that character args are actually
3722 characters. Without this test, these functions did the wrong
3723 thing with wildly out-of-range values on 64-bit hosts.
3724
3725 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3726 These casts should not be needed on 32-bit hosts, either.
3727 * keyboard.c (read_char):
3728 * lread.c (Fload): Remove casts to unsigned.
3729
3730 * lisp.h (UNSIGNED_CMP): New macro.
3731 This fixes comparison bugs on 64-bit hosts.
3732 (ASCII_CHAR_P): Use it.
3733 * casefiddle.c (casify_object):
3734 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3735 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3736 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3737 * dispextern.h (FACE_FROM_ID):
3738 * keyboard.c (read_char): Use UNSIGNED_CMP.
3739
3740 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3741 not to EMACS_INT, to avoid GCC warning.
3742
3743 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3744
3745 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3746 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3747 isn't needed on 32-bit machines.
3748
3749 * buffer.c (Fgenerate_new_buffer_name):
3750 Use EMACS_INT for count, not int.
3751 (advance_to_char_boundary): Return EMACS_INT, not int.
3752
3753 * data.c (Qcompiled_function): Now static.
3754
3755 * window.c (window_body_lines): Now static.
3756
3757 * image.c (gif_load): Rename local to avoid shadowing.
3758
3759 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3760 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3761 * alloc.c (make_save_value): Integer argument is now of type
3762 ptrdiff_t, not int.
3763 (mark_object): Use ptrdiff_t, not int.
3764 * lisp.h (pD): New macro.
3765 * print.c (print_object): Use it.
3766
3767 * alloc.c: Use EMACS_INT, not int, to count objects.
3768 (total_conses, total_markers, total_symbols, total_vector_size)
3769 (total_free_conses, total_free_markers, total_free_symbols)
3770 (total_free_floats, total_floats, total_free_intervals)
3771 (total_intervals, total_strings, total_free_strings):
3772 Now EMACS_INT, not int. All uses changed.
3773 (Fgarbage_collect): Compute overall total using a double, so that
3774 integer overflow is less likely to be a problem. Check for overflow
3775 when converting back to an integer.
3776 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3777 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3778 These were 'int' variables that could overflow on 64-bit hosts;
3779 they were never used, so remove them instead of repairing them.
3780 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3781 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3782 Previously, this ceilinged at INT_MAX, but that doesn't work on
3783 64-bit machines.
3784 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3785
3786 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3787 (allocate_vectorlike): Check for ptrdiff_t overflow.
3788 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3789 when a (possibly-narrower) signed value would do just as well.
3790 We prefer using signed arithmetic, to avoid comparison confusion.
3791
3792 * alloc.c: Catch some string size overflows that we were missing.
3793 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3794 for convenience in STRING_BYTES_MAX.
3795 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3796 The definition here is exact; the one in lisp.h was approximate.
3797 (allocate_string_data): Check for string overflow. This catches
3798 some instances we weren't catching before. Also, it catches
3799 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3800 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3801 and ptrdiff_t and EMACS_INT are both 64 bits.
3802
3803 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3804 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3805 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3806
3807 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3808
3809 * alloc.c (Fmake_string): Check for out-of-range init.
3810
3811 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3812
3813 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3814
3815 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3816
3817 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3818 xg_get_default_scrollbar_width.
3819
3820 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3821 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3822 (style_changed_cb): Call update_theme_scrollbar_width and call
3823 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3824 all frames (Bug#8505).
3825 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3826 Call gtk_window_set_resizable if HAVE_GTK3.
3827 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3828 and height if HAVE_GTK3 (Bug#8505).
3829 (scroll_bar_width_for_theme): New variable.
3830 (update_theme_scrollbar_width): New function.
3831 (xg_get_default_scrollbar_width): Move code to
3832 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3833 (xg_initialize): Call update_theme_scrollbar_width.
3834
3835 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3836
3837 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3838
3839 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3840
3841 * frame.c (make_frame): Call other_buffer_safely instead of
3842 other_buffer.
3843
3844 * window.c (temp_output_buffer_show): Call display_buffer with
3845 second argument Vtemp_buffer_show_specifiers and reset latter
3846 immediately after the call.
3847 (Vtemp_buffer_show_specifiers): New variable.
3848 (auto_window_vscroll_p, next_screen_context_lines)
3849 (Vscroll_preserve_screen_position): Remove leading asterisks from
3850 doc-strings.
3851
3852 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3853
3854 Fix minor problems found by GCC 4.6.0 static checking.
3855 * buffer.c (Qclone_number): Remove for now, as it's unused.
3856 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3857 (record_buffer): Remove unused local.
3858 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3859 (set_frame_buffer_list): Remove; unused.
3860 * frame.h (other_visible_frames): Remove decl.
3861 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3862 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3863 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3864 if HAVE_GPM.
3865 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3866 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3867 Define only if HAVE_GPM.
3868 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3869 (update_hints_inhibit): Remove; never set. All uses removed.
3870 * widgetprv.h (emacsFrameClassRec): Remove decl.
3871 * window.c (delete_deletable_window): Now returns void, since it
3872 wasn't returning anything.
3873 (compare_window_configurations): Remove unused locals.
3874 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3875 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3876 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3877 the same widths as pointers. This follows up on the 2011-05-06 patch.
3878 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3879 * xterm.h: Likewise.
3880 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3881
3882 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3883
3884 * makefile.w32-in: Update dependencies.
3885 (LISP_H): Add lib/intprops.h.
3886
3887 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3888
3889 * image.c (gif_load): Add animation frame delay to the metadata.
3890 (syms_of_image): Use DEFSYM. New symbol `delay'.
3891
3892 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3893
3894 * window.c (delete_deletable_window): Re-add.
3895 (Fset_window_configuration): Rewrite to handle dead buffers and
3896 consequently deletable windows.
3897 (window_tree, Fwindow_tree): Remove. Supply functionality in
3898 window.el.
3899 (compare_window_configurations): Simplify code.
3900
3901 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3902
3903 * image.c (imagemagick_load_image): Fix type mismatch.
3904 (Fimagemagick_types): Likewise.
3905
3906 * window.h (replace_buffer_in_windows): Declare.
3907
3908 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3909
3910 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3911 Qclone_number. Remove external declaration of Qdelete_window.
3912 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3913 code.
3914 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3915 Run Qbuffer_list_update_hook if allowed.
3916 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3917 buffer list implementation.
3918 (other_buffer_safely): New function.
3919 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3920 calls to replace_buffer_in_windows and
3921 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3922 if allowed.
3923 (record_buffer): Inhibit quitting and rewrite using quittable
3924 functions. Run Qbuffer_list_update_hook if allowed.
3925 (Frecord_buffer, Funrecord_buffer): New functions.
3926 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3927 Move switch-to-buffer to window.el.
3928 (bury-buffer): Move to window.el.
3929 (Vbuffer_list_update_hook): New variable.
3930
3931 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3932 section.
3933
3934 * window.h (resize_frame_windows): Move up in code.
3935 (Fwindow_frame): Remove EXFUN.
3936 (replace_buffer_in_all_windows): Remove prototype.
3937 (replace_buffer_in_windows_safely): Add prototype.
3938
3939 * window.c: Declare Qdelete_window static again. Move down
3940 declaration of select_count.
3941 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3942 (Fother_window): Move to window.el.
3943 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3944 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3945 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3946 window.el.
3947 (replace_buffer_in_windows): Implement by calling
3948 Qreplace_buffer_in_windows.
3949 (replace_buffer_in_all_windows): Remove with some functionality
3950 moved into replace_buffer_in_windows_safely.
3951 (replace_buffer_in_windows_safely): New function.
3952 (select_window_norecord, select_frame_norecord): Move in front
3953 of run_window_configuration_change_hook. Remove now obsolete
3954 declarations.
3955 (Fset_window_buffer): Rewrite doc-string.
3956 Call Qrecord_window_buffer.
3957 (keys_of_window): Move binding for other-window to window.el.
3958
3959 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3960
3961 * dispextern.h (struct image): Replace data member, whose int_val
3962 and ptr_val fields were not used by anything, with a single
3963 lisp_val object.
3964
3965 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3966 (gif_clear_image, gif_load, imagemagick_load_image)
3967 (gs_clear_image, gs_load): Callers changed.
3968
3969 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3970
3971 * buffer.h: Include <time.h>, for time_t.
3972 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3973
3974 Fix minor problems found by static checking.
3975
3976 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3977
3978 Make identifiers static if they are not used in other modules.
3979 * data.c (Qcompiled_function, Qframe, Qvector):
3980 * image.c (QimageMagick, Qsvg):
3981 * minibuf.c (Qmetadata):
3982 * window.c (resize_window_check, resize_root_window): Now static.
3983 * window.h (resize_window_check, resize_root_window): Remove decls.
3984
3985 * window.c (window_deletion_count, delete_deletable_window):
3986 Remove; unused.
3987 (window_body_lines): Now static.
3988 (Fdelete_other_windows_internal): Mark vars as initialized.
3989 Make sure 'resize_failed' is initialized.
3990 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3991 (resize_window_apply): Remove unused local.
3992 * window.h (delete_deletable_window): Remove decl.
3993
3994 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3995 (imagemagick_load_image): Fix pointer signedness problem by changing
3996 last arg from unsigned char * to char *. All uses changed.
3997 Also, fix a local for similar reasons.
3998 Remove unused locals. Remove locals to avoid shadowing.
3999 (fn_rsvg_handle_free): Remove; unused.
4000 (svg_load, svg_load_image): Fix pointer signedness problem.
4001 (imagemagick_load_image): Don't use garbage pointer image_wand.
4002
4003 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4004
4005 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4006
4007 * image.c (gif_load): Fix omitted cast error introduced by
4008 2011-06-06 change.
4009
4010 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4011
4012 * window.h (resize_proportionally, orig_total_lines)
4013 (orig_top_line): Remove from window structure.
4014 (set_window_height, set_window_width, change_window_heights)
4015 (Fdelete_window): Remove prototypes.
4016 (resize_frame_windows): Remove duplicate declaration.
4017
4018 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4019
4020 * window.h (resize_frame_windows, resize_window_check)
4021 (delete_deletable_window, resize_root_window)
4022 (resize_frame_windows): Declare prototypes.
4023
4024 * window.c (resize_window_apply): Make definition be "static" to
4025 match the prototype.
4026
4027 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4028
4029 * window.c: Remove declarations of Qwindow_size_fixed,
4030 window_min_size_1, window_min_size_2, window_min_size,
4031 size_window, window_fixed_size_p, enlarge_window, delete_window.
4032 Remove static from declaration of Qdelete_window, it's
4033 temporarily needed by Fbury_buffer.
4034 (replace_window): Don't assign orig_top_line and
4035 orig_total_lines.
4036 (Fdelete_window, delete_window): Remove. Window deletion is
4037 handled by window.el.
4038 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4039 Replace Fdelete_window calls with calls to Qdelete_window.
4040 (Fdelete_other_windows): Remove. Deleting other windows is
4041 handled by window.el.
4042 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4043 handled in window.el.
4044 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4045 Window minimum sizes are handled in window.el.
4046 (shrink_windows, size_window, set_window_height)
4047 (set_window_width, change_window_heights, window_height)
4048 (window_width, CURBEG, CURSIZE, enlarge_window)
4049 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4050 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4051 handled in window.el.
4052 (make_dummy_parent): Rename to make_parent_window and give it a
4053 second argument horflag.
4054 (make_window): Don't set resize_proportionally any more.
4055 (Fsplit_window): Remove. Windows are split in window.el.
4056 (save_restore_action, save_restore_orig_size)
4057 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4058 Resize mini windows in window.el.
4059 (grow_mini_window, shrink_mini_window): Implement by calling
4060 Qresize_root_window_vertically, resize_window_check and
4061 resize_window_apply.
4062 (saved_window, Fset_window_configuration, save_window_save):
4063 Do not handle orig_top_line, orig_total_lines, and
4064 resize_proportionally.
4065 (window_min_height, window_min_width): Move to window.el.
4066 (keys_of_window): Move bindings for delete-other-windows,
4067 split-window, delete-window and enlarge-window to window.el.
4068
4069 * buffer.c: Temporarily extern Qdelete_window.
4070 (Fbury_buffer): Temporarily call Qdelete_window instead of
4071 Fdelete_window (Fbury_buffer will move to window.el soon).
4072
4073 * frame.c (set_menu_bar_lines_1): Remove code handling
4074 orig_top_line and orig_total_lines.
4075
4076 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4077 set_window_height but set heights directly.
4078 (change_frame_size_1): Use resize_frame_windows.
4079
4080 * xdisp.c (init_xdisp): Don't use set_window_height but set
4081 heights directly.
4082
4083 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4084 Use resize_frame_windows instead of change_window_heights and run
4085 run_window_configuration_change_hook.
4086
4087 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4088 instead of change_window_heights and run
4089 run_window_configuration_change_hook.
4090
4091 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4092
4093 * window.c (replace_window): Rename second argument REPLACEMENT to
4094 NEW. New third argument SETFLAG. Rewrite.
4095 (delete_window, make_dummy_parent): Call replace_window with
4096 third argument 1.
4097 (window_list_1): Move down in code.
4098 (run_window_configuration_change_hook): Move set_buffer part
4099 before select_frame_norecord part in order to unwind correctly.
4100 Rename count1 to count.
4101 (recombine_windows, delete_deletable_window, resize_root_window)
4102 (Fdelete_other_windows_internal)
4103 (Frun_window_configuration_change_hook, make_parent_window)
4104 (resize_window_check, resize_window_apply, Fresize_window_apply)
4105 (resize_frame_windows, Fsplit_window_internal)
4106 (Fdelete_window_internal, Fresize_mini_window_internal):
4107 New functions.
4108 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4109
4110 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4111
4112 * window.h (window): Add some new members to window structure -
4113 normal_lines, normal_cols, new_total, new_normal, clone_number,
4114 splits, nest, prev_buffers, next_buffers.
4115 (WINDOW_TOTAL_SIZE): Move here from window.c.
4116 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4117
4118 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4119 Remove.
4120 (make_dummy_parent): Set new members of windows structure.
4121 (make_window): Move down in code. Handle new members of window
4122 structure.
4123 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4124 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4125 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4126 (Fset_window_prev_buffers, Fwindow_next_buffers)
4127 (Fset_window_next_buffers, Fset_window_clone_number):
4128 New functions.
4129 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4130 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4131 Doc-string fixes.
4132 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4133 Argument WINDOW can be now internal window too.
4134 (Fwindow_use_time): Move up in code.
4135 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4136 Rewrite doc-string.
4137 (Fset_window_configuration, saved_window)
4138 (Fcurrent_window_configuration, save_window_save): Handle new
4139 members of window structure.
4140 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4141 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4142 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4143 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4144 Qget_mru_window, Qresize_root_window,
4145 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4146 Qauto_buffer_name; staticpro them.
4147
4148 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4149
4150 * window.c (Fwindow_total_size, Fwindow_left_column)
4151 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4152 (Fwindow_list_1): New functions.
4153 (window_box_text_cols): Replace with window_body_cols.
4154 (Fwindow_width, Fscroll_left, Fscroll_right):
4155 Use window_body_cols instead of window_box_text_cols.
4156 (delete_window, Fset_window_configuration):
4157 Call delete_all_subwindows with window as argument.
4158 (delete_all_subwindows): Take a window as argument and not a
4159 structure. Rewrite.
4160 (window_loop): Remove handling of GET_LRU_WINDOW and
4161 GET_LARGEST_WINDOW.
4162 (Fget_lru_window, Fget_largest_window): Move to window.el.
4163
4164 * window.h: Extern window_body_cols instead of
4165 window_box_text_cols. delete_all_subwindows now takes a
4166 Lisp_Object as argument.
4167
4168 * indent.c (compute_motion, Fcompute_motion):
4169 Use window_body_cols instead of window_box_text_cols.
4170
4171 * frame.c (delete_frame): Call delete_all_subwindows with root
4172 window as argument.
4173
4174 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4175
4176 * fns.c (Fputhash): Document return value.
4177
4178 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4179
4180 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4181
4182 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4183
4184 Cons<->int and similar integer overflow fixes (Bug#8794).
4185
4186 Check for overflow when converting integer to cons and back.
4187 * charset.c (Fdefine_charset_internal, Fdecode_char):
4188 Use cons_to_unsigned to catch overflow.
4189 (Fencode_char): Use INTEGER_TO_CONS.
4190 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4191 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4192 * data.c (long_to_cons, cons_to_long): Remove.
4193 (cons_to_unsigned, cons_to_signed): New functions.
4194 These signal an error for invalid or out-of-range values.
4195 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4196 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4197 * font.c (Ffont_variation_glyphs):
4198 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4199 * lisp.h: Include <intprops.h>.
4200 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4201 (cons_to_signed, cons_to_unsigned): New decls.
4202 (long_to_cons, cons_to_long): Remove decls.
4203 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4204 (Fprimitive_undo): Use CONS_TO_INTEGER.
4205 * xfns.c (Fx_window_property): Likewise.
4206 * xselect.c: Include <limits.h>.
4207 (x_own_selection, selection_data_to_lisp_data):
4208 Use INTEGER_TO_CONS.
4209 (x_handle_selection_request, x_handle_selection_clear)
4210 (x_get_foreign_selection, Fx_disown_selection_internal)
4211 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4212 (lisp_data_to_selection_data): Use cons_to_unsigned.
4213 (x_fill_property_data): Use cons_to_signed.
4214 Report values out of range.
4215
4216 Check for buffer and string overflow more precisely.
4217 * buffer.h (BUF_BYTES_MAX): New macro.
4218 * lisp.h (STRING_BYTES_MAX): New macro.
4219 * alloc.c (Fmake_string):
4220 * character.c (string_escape_byte8):
4221 * coding.c (coding_alloc_by_realloc):
4222 * doprnt.c (doprnt):
4223 * editfns.c (Fformat):
4224 * eval.c (verror):
4225 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4226 since they may not be the same number.
4227 * editfns.c (Finsert_char):
4228 * fileio.c (Finsert_file_contents):
4229 Likewise for BUF_BYTES_MAX.
4230
4231 * image.c: Use ptrdiff_t, not int, for sizes.
4232 (slurp_file): Switch from int to ptrdiff_t.
4233 All uses changed.
4234 (slurp_file): Check that file size fits in both size_t (for
4235 malloc) and ptrdiff_t (for sanity and safety).
4236
4237 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4238 if b->modtime has its maximal value.
4239
4240 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4241
4242 Don't assume time_t can fit into int.
4243 * buffer.h (struct buffer.modtime): Now time_t, not int.
4244 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4245 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4246
4247 Minor fixes for signed vs unsigned integers.
4248 * character.h (MAYBE_UNIFY_CHAR):
4249 * charset.c (maybe_unify_char):
4250 * keyboard.c (read_char, reorder_modifiers):
4251 XINT -> XFASTINT, since the integer must be nonnegative.
4252 * ftfont.c (ftfont_spec_pattern):
4253 * keymap.c (access_keymap, silly_event_symbol_error):
4254 XUINT -> XFASTINT, since the integer must be nonnegative.
4255 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4256 since it makes no difference and we prefer signed.
4257 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4258 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4259 nonnegative.
4260
4261 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4262
4263 * window.h (Fwindow_frame): Declare.
4264
4265 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4266
4267 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4268 (SPARE_MEMORY): Always define.
4269 (LARGE_REQUEST): Remove.
4270 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4271
4272 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4273
4274 * lisp.h: Move EXFUNS for Fframe_root_window,
4275 Fframe_first_window and Fset_frame_selected_window to window.h.
4276
4277 * window.h: Move EXFUNS for Fframe_root_window,
4278 Fframe_first_window and Fset_frame_selected_window here from
4279 lisp.h.
4280
4281 * frame.c (Fwindow_frame, Fframe_first_window)
4282 (Fframe_root_window, Fframe_selected_window)
4283 (Fset_frame_selected_window): Move to window.c.
4284 (Factive_minibuffer_window): Move to minibuf.c.
4285 (Fother_visible_frames_p): New function.
4286
4287 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4288
4289 * window.c (decode_window, decode_any_window): Move up in code.
4290 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4291 (inhibit_frame_unsplittable): Remove unused variable.
4292 (Fwindow_buffer): Move up and rewrite doc-string.
4293 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4294 (Fwindow_prev): New functions.
4295 (Fwindow_frame): Move here from frame.c. Accept any window as
4296 argument.
4297 (Fframe_root_window, Fframe_first_window)
4298 (Fframe_selected_window): Move here from frame.c. Accept frame
4299 or arbitrary window as argument. Update doc-strings.
4300 (Fminibuffer_window): Move up in code.
4301 (Fwindow_minibuffer_p): Move up in code and simplify.
4302 (Fset_frame_selected_window): Move here from frame.c.
4303 Marginal rewrite.
4304 (Fselected_window, select_window, Fselect_window): Move up in
4305 code. Minor doc-string fixes.
4306
4307 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4308
4309 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4310 Do not assume that spare memory exists; that assumption is valid
4311 only if SYSTEM_MALLOC.
4312 (LARGE_REQUEST): New macro, so that the issue of large requests
4313 is separated from the issue of spare memory.
4314
4315 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4316
4317 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4318 format. (Bug#8806)
4319
4320 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4321
4322 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4323 before statements.
4324
4325 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4326
4327 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4328
4329 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4330
4331 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4332 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4333
4334 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4335
4336 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4337
4338 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4339
4340 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4341 (x_clipboard_manager_save): Add return value.
4342 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4343 New error handlers.
4344 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4345 Obey Vx_select_enable_clipboard_manager. Catch errors in
4346 x_clipboard_manager_save (Bug#8779).
4347 (Vx_select_enable_clipboard_manager): New variable.
4348 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4349
4350 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4351
4352 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4353
4354 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4355
4356 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4357 in the current matrix if keep_current_p is non-zero.
4358
4359 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4360
4361 * bidi.c (bidi_level_of_next_char): Fix last change.
4362
4363 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4364
4365 Support bidi reordering of text covered by display properties.
4366
4367 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4368 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4369 (bidi_cache_search, bidi_cache_iterator_state)
4370 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4371 (bidi_level_of_next_char, bidi_move_to_visually_next):
4372 Support character positions inside a run of characters covered by a
4373 display string.
4374 (bidi_paragraph_init, bidi_resolve_explicit_1)
4375 (bidi_level_of_next_char): Call bidi_fetch_char and
4376 bidi_fetch_char_advance instead of FETCH_CHAR and
4377 FETCH_CHAR_ADVANCE.
4378 (bidi_init_it): Initialize new members.
4379 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4380 definitions.
4381 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4382 instead of using explicit *_CHAR codes.
4383 (bidi_resolve_explicit, bidi_resolve_weak):
4384 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4385 bidirectional text is supported only in multibyte buffers.
4386 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4387 it to initialize the frame_window_p member of struct bidi_it.
4388 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4389 (bidi_resolve_explicit, bidi_resolve_weak)
4390 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4391 bidi_it->nchars is non-positive.
4392 (bidi_level_of_next_char): Don't try to lookup the cache for the
4393 next/previous character if nothing is cached there yet, or if we
4394 were just reseat()'ed to a new position.
4395
4396 * xdisp.c (set_cursor_from_row): Set start and stop points
4397 according to the row's direction when priming the loop that looks
4398 for the glyph on which to display cursor.
4399 (single_display_spec_intangible_p): Function deleted.
4400 (display_prop_intangible_p): Reimplement to call
4401 handle_display_spec instead of single_display_spec_intangible_p.
4402 Accept 3 additional arguments needed by handle_display_spec.
4403 This fixes incorrect cursor motion across display property with complex
4404 values: lists, `(when COND...)' forms, etc.
4405 (single_display_spec_string_p): Support property values that are
4406 lists with the argument STRING its top-level element.
4407 (display_prop_string_p): Fix the condition for processing a
4408 property that is a list to be consistent with handle_display_spec.
4409 (handle_display_spec): New function, refactored from the
4410 last portion of handle_display_prop.
4411 (compute_display_string_pos): Accept additional argument
4412 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4413 value of a `display' property is a "replacing spec".
4414 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4415 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4416 the display property, but just return a value indicating whether
4417 the display property will replace the characters it covers.
4418 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4419 frame_window_p members of struct bidi_it.
4420 (compute_display_string_pos, compute_display_string_end):
4421 New functions.
4422 (push_it): Accept second argument POSITION, where pop_it should
4423 jump to continue iteration.
4424 (reseat_1): Initialize bidi_it.disp_pos.
4425
4426 * keyboard.c (adjust_point_for_property): Adjust the call to
4427 display_prop_intangible_p to its new signature.
4428
4429 * dispextern.h (struct bidi_it): New member frame_window_p.
4430 (bidi_init_it): Update prototypes.
4431 (display_prop_intangible_p): Update prototype.
4432 (compute_display_string_pos, compute_display_string_end):
4433 Declare prototypes.
4434 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4435 EMACS_INT.
4436
4437 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4438
4439 Malloc failure behavior now depends on size of allocation.
4440 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4441 * lisp.h: Change signatures accordingly.
4442 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4443 All callers changed. (Bug#8762)
4444
4445 * gnutls.c: Use Emacs's memory allocators.
4446 Without this change, the gnutls library would invoke malloc etc.
4447 directly, which causes problems on non-SYNC_INPUT hosts, and which
4448 runs afoul of improving memory_full behavior. (Bug#8761)
4449 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4450 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4451 xfree instead of the default malloc, realloc, free.
4452 (Fgnutls_boot): No need to check for memory allocation failure,
4453 since xmalloc does that for us.
4454
4455 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4456 * category.c (hash_get_category_set):
4457 * ccl.c (ccl_driver):
4458 * charset.c (Fdefine_charset_internal):
4459 * charset.h (struct charset.hash_index):
4460 * composite.c (get_composition_id, gstring_lookup_cache)
4461 (composition_gstring_put_cache):
4462 * composite.h (struct composition.hash_index):
4463 * dispextern.h (struct image.hash):
4464 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4465 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4466 (hashfn_equal, hashfn_user_defined, make_hash_table)
4467 (maybe_resize_hash_table, hash_lookup, hash_put)
4468 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4469 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4470 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4471 * image.c (make_image, search_image_cache, lookup_image)
4472 (xpm_put_color_table_h):
4473 * lisp.h (struct Lisp_Hash_Table):
4474 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4475 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4476 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4477 * alloc.c (allocate_vectorlike):
4478 Check for overflow in vector size calculations.
4479 * ccl.c (ccl_driver):
4480 Check for overflow when converting EMACS_INT to int.
4481 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4482 need to be updated by these changes.
4483 * fns.c (make_hash_table, maybe_resize_hash_table):
4484 Check for integer overflow with large hash tables.
4485 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4486 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4487 (SXHASH_REDUCE): New macro.
4488 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4489 Use it instead of discarding useful hash info with large hash values.
4490 (sxhash_float): New function.
4491 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4492 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4493 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4494 Rewrite to use FIXNUM_BITS, as this simplifies things.
4495 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4496 Adjust signatures to match updated version of code.
4497 (consing_since_gc): Now EMACS_INT, since a single hash table can
4498 use more than INT_MAX bytes.
4499
4500 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4501
4502 Make it possible to build with GCC-4.6+ -O2 -flto.
4503
4504 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4505
4506 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4507
4508 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4509 Call minibuffer-inactive-mode.
4510
4511 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4512
4513 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4514 Update dependencies.
4515
4516 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4517
4518 * data.c (init_data): Remove code for UTS, this system is not
4519 supported anymore.
4520
4521 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4522
4523 Don't force ./temacs to start in terminal mode.
4524
4525 * frame.c (make_initial_frame): Initialize faces in all cases, not
4526 only when CANNOT_DUMP is defined.
4527 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4528
4529 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4530
4531 * dispnew.c (add_window_display_history): Use const for the string
4532 pointer. Remove declaration, not needed.
4533
4534 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4535
4536 Use 'inline', not 'INLINE'.
4537 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4538 * alloc.c, fontset.c (INLINE): Remove.
4539 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4540 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4541 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4542 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4543 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4544
4545 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4546
4547 Make it possible to run ./temacs.
4548
4549 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4550 syms_of_callproc does the same thing. Remove test for
4551 "initialized", do it in the caller.
4552 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4553
4554 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4555
4556 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4557 (read_minibuf): Use get_minibuffer.
4558 (syms_of_minibuf): Use DEFSYM.
4559 (Qmetadata): New var.
4560 * data.c (Qbuffer): Don't make it static.
4561 (syms_of_data): Use DEFSYM.
4562
4563 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4564
4565 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4566 (CCL_CODE_MIN): New macro.
4567
4568 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4569
4570 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4571
4572 * eval.c (Qdebug): Now static.
4573 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4574 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4575 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4576
4577 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4578
4579 * image.c: Various fixes to ImageMagick code comments.
4580 (Fimagemagick_types): Doc fix.
4581
4582 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4583
4584 Minor fixes prompted by GCC 4.6.0 warnings.
4585
4586 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4587
4588 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4589 (x_clipboard_manager_save_all): Move extern decl to ...
4590 * xterm.h: ... here, so that it can be checked for consistency.
4591
4592 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4593
4594 * xselect.c (x_clipboard_manager_save_frame)
4595 (x_clipboard_manager_save_all): New functions.
4596 (Fx_clipboard_manager_save): Lisp function deleted.
4597
4598 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4599 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4600
4601 * xterm.h: Update prototype.
4602
4603 2011-05-28 William Xu <william.xwl@gmail.com>
4604
4605 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4606 exiting (Bug#8239).
4607
4608 2011-05-28 Jim Meyering <meyering@redhat.com>
4609
4610 Avoid a sign-extension bug in crypto_hash_function.
4611 * fns.c (to_uchar): Define.
4612 (crypto_hash_function): Use it to convert some newly-signed
4613 variables to unsigned, to avoid sign-extension bugs. For example,
4614 without this change, (md5 "truc") would evaluate to
4615 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4616 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4617 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4618
4619 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4620
4621 Integer overflow fixes.
4622
4623 * dbusbind.c: Serial number integer overflow fixes.
4624 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4625 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4626 to hold a serial number that is too large for a fixnum.
4627 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4628 Check for serial numbers out of range. Decode any serial number
4629 that was so large that it became a float. (Bug#8722)
4630
4631 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4632 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4633 Use XFASTINT rather than XUINT when numbers are nonnegative.
4634 (xd_append_arg, Fdbus_method_return_internal):
4635 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4636 arguments, check that Lisp number is nonnegative, rather than
4637 silently wrapping negative numbers around. (Bug#8722)
4638 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4639 (Bug#8722)
4640
4641 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4642
4643 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4644
4645 ccl: add integer overflow checks
4646 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4647 (IN_INT_RANGE): New macros.
4648 (ccl_driver): Use them to check for integer overflow when
4649 decoding a CCL program. Many of the new checks are whether XINT (x)
4650 fits in int; it doesn't always, on 64-bit hosts. The new version
4651 doesn't catch all possible integer overflows, but it's an
4652 improvement. (Bug#8719)
4653
4654 * alloc.c (make_event_array): Use XINT, not XUINT.
4655 There's no need for unsigned here.
4656
4657 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4658 This follows up to the 2011-05-06 change that substituted uintptr_t
4659 for EMACS_INT. This case wasn't caught back then.
4660
4661 Rework Fformat to avoid integer overflow issues.
4662 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4663 now (part of C89). Include <verify.h>.
4664 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4665 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4666 (Fformat): Avoid the prepass trying to compute sizes; it was only
4667 approximate and thus did not catch overflow reliably. Instead, walk
4668 through the format just once, formatting and computing sizes as we go,
4669 checking for integer overflow at every step, and allocating a larger
4670 buffer as needed. Keep track separately whether the format is
4671 multibyte. Keep only the most-recently calculated precision, rather
4672 than them all. Record whether each argument has been converted to
4673 string. Use EMACS_INT, not int, for byte and char and arg counts.
4674 Support field widths and precisions larger than INT_MAX. Avoid
4675 sprintf's undefined behavior with conversion specifications such as %#d
4676 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4677 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4678 formatting out-of-range floating point numbers with int
4679 formats. (Bug#8668)
4680
4681 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4682
4683 * data.c: Avoid integer truncation in expressions involving floats.
4684 * data.c: Include <intprops.h>.
4685 (arith_driver): When there's an integer overflow in an expression
4686 involving floating point, convert the integers to floating point
4687 so that the resulting value does not suffer from catastrophic
4688 integer truncation. For example, on a 64-bit host (* 4
4689 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4690 Do not rely on undefined behavior after integer overflow.
4691
4692 merge count_size_as_multibyte, parse_str_to_multibyte
4693 * character.c, character.h (count_size_as_multibyte):
4694 Rename from parse_str_to_multibyte; all uses changed.
4695 Check for integer overflow.
4696 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4697 since it's now a duplicate of the other. This is more of
4698 a character than a buffer op, so better that it's in character.c.
4699 * fns.c, print.c: Adjust to above changes.
4700
4701 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4702
4703 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4704
4705 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4706
4707 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4708 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4709 (x_clipboard_manager_save): Now static.
4710 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4711
4712 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4713 (crypto_hash_function): Now static.
4714 Fix pointer signedness problems. Avoid unnecessary initializations.
4715
4716 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4717
4718 * termhooks.h (Vselection_alist): Make it terminal-local.
4719
4720 * terminal.c (create_terminal): Initialize it.
4721
4722 * xselect.c: Support for clipboard managers.
4723 (Vselection_alist): Move to termhooks.h as terminal-local var.
4724 (LOCAL_SELECTION): New macro.
4725 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4726 (symbol_to_x_atom): Remove gratuitous arg.
4727 (x_handle_selection_request, lisp_data_to_selection_data)
4728 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4729 (x_own_selection, x_get_local_selection, x_convert_selection):
4730 New arg, specifying work frame. Use terminal-local Vselection_alist.
4731 (some_frame_on_display): Delete unused function.
4732 (Fx_own_selection_internal, Fx_get_selection_internal)
4733 (Fx_disown_selection_internal, Fx_selection_owner_p)
4734 (Fx_selection_exists_p): New optional frame arg.
4735 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4736 (x_handle_selection_clear): Don't treat other terminals with the
4737 same keyboard specially. Use the terminal-local Vselection_alist.
4738 (x_clear_frame_selections): Use Frun_hook_with_args.
4739
4740 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4741
4742 * xterm.h: Add support for those atoms.
4743
4744 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4745
4746 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4747 (converted_selections, conversion_fail_tag): New global variables.
4748 (x_selection_request_lisp_error): Free the above.
4749 (x_get_local_selection): Remove unnecessary code.
4750 (x_reply_selection_request): Args changed; handle arbitrary array
4751 of converted selections stored in converted_selections.
4752 Separate the XChangeProperty and SelectionNotify steps.
4753 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4754 (x_convert_selection): New function.
4755 (x_handle_selection_event): Simplify.
4756 (x_get_foreign_selection): Don't ignore incoming requests while
4757 waiting for an answer; this will fail when we implement
4758 SAVE_TARGETS, and seems unnecessary anyway.
4759 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4760 (Vx_sent_selection_functions): Doc fix.
4761
4762 2011-05-26 Leo Liu <sdl.web@gmail.com>
4763
4764 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4765
4766 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4767
4768 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4769
4770 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4771 for fringe update if it has periodic bitmap.
4772 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4773 and fringe_bitmap_periodic_p.
4774
4775 * fringe.c (get_fringe_bitmap_data): New function.
4776 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4777 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4778 row. Mark glyph row for fringe update if periodicity changed.
4779
4780 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4781 for fringe update unless it has periodic bitmap.
4782
4783 2011-05-25 Kenichi Handa <handa@m17n.org>
4784
4785 * xdisp.c (get_next_display_element): Set correct it->face_id for
4786 a static composition.
4787
4788 2011-05-24 Leo Liu <sdl.web@gmail.com>
4789
4790 * deps.mk (fns.o):
4791 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4792
4793 * fns.c (crypto_hash_function, Fsha1): New function.
4794 (Fmd5): Use crypto_hash_function.
4795 (syms_of_fns): Add Ssha1.
4796
4797 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 * gnutls.c: Remove unused macros.
4800 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4801 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4802 Remove macros that are defined and never used.
4803 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4804
4805 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4806
4807 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4808 (Fx_get_selection_internal): Minor cleanup.
4809 (Fx_own_selection_internal): Rename arguments for consistency with
4810 select.el.
4811
4812 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4815
4816 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4817
4818 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4819
4820 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4821
4822 * dispnew.c (scrolling_window): Don't exclude the case that the
4823 last enabled row in the desired matrix touches the bottom boundary.
4824
4825 2011-05-21 Glenn Morris <rgm@gnu.org>
4826
4827 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4828 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4829 and add some more files.
4830
4831 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4832
4833 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4834 report_file_error introduced by the change from 2011-05-07.
4835
4836 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 * systime.h (Time): Define only if emacs is defined.
4839 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4840 where the include path doesn't have X11/X.h by default. See
4841 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4842
4843 2011-05-20 Kenichi Handa <handa@m17n.org>
4844
4845 * composite.c (find_automatic_composition): Fix previous change.
4846
4847 2011-05-20 Glenn Morris <rgm@gnu.org>
4848
4849 * lisp.mk: New file, split from Makefile.in.
4850 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4851 (shortlisp): Remove.
4852 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4853
4854 2011-05-19 Glenn Morris <rgm@gnu.org>
4855
4856 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4857 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4858 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4859 (lisp): Set the order to that of loadup.el.
4860 (shortlisp): Make it a copy of $lisp.
4861 (SOME_MACHINE_LISP): Remove.
4862 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4863 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4864
4865 2011-05-18 Kenichi Handa <handa@m17n.org>
4866
4867 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4868 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4869 (find_automatic_composition): Mostly rewrite for efficiency.
4870
4871 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4872
4873 * makefile.w32-in: Update dependencies.
4874
4875 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4876
4877 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4878 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4879
4880 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4881
4882 Fix some integer overflow issues, such as string length overflow.
4883
4884 * insdel.c (count_size_as_multibyte): Check for string overflow.
4885
4886 * character.c (lisp_string_width): Check for string overflow.
4887 Use EMACS_INT, not int, for string indexes and lengths; in
4888 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4889 the resulting string length overflows an EMACS_INT; instead,
4890 report a string overflow if no precision given. When checking for
4891 precision exhaustion, use a check that cannot possibly have
4892 integer overflow. (Bug#8675)
4893 * character.h (lisp_string_width): Adjust to new signature.
4894
4895 * alloc.c (string_overflow): New function.
4896 (Fmake_string): Use it. This doesn't change behavior, but saves
4897 a few bytes and will simplify future changes.
4898 * character.c (string_escape_byte8): Likewise.
4899 * lisp.h (string_overflow): New decl.
4900
4901 Fixups, following up to the user-interface timestamp change.
4902 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4903 for UI timestamps, instead of unsigned long.
4904 * msdos.c (mouse_get_pos): Likewise.
4905 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4906 * w32gui.h (Time): Define by including "systime.h" rather than by
4907 declaring it ourselves. (Bug#8664)
4908
4909 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4910 * image.c (clear_image_cache): Likewise.
4911
4912 * term.c (term_mouse_position): Don't assume time_t wraparound.
4913
4914 Be more systematic about user-interface timestamps.
4915 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4916 and sometimes 'EMACS_UINT', to represent these timestamps.
4917 This change causes it to use 'Time' uniformly, as that's what X uses.
4918 This makes the code easier to follow, and makes it easier to catch
4919 integer overflow bugs such as Bug#8664.
4920 * frame.c (Fmouse_position, Fmouse_pixel_position):
4921 Use Time, not unsigned long, for user-interface timestamps.
4922 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4923 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4924 * keyboard.h (last_event_timestamp): Likewise.
4925 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4926 * menu.h (xmenu_show): Likewise.
4927 * term.c (term_mouse_position): Likewise.
4928 * termhooks.h (struct input_event.timestamp): Likewise.
4929 (struct terminal.mouse_position_hook): Likewise.
4930 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4931 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4932 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4933 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4934 what it was before.
4935 * menu.h, termhooks.h: Include "systime.h", for Time.
4936
4937 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4938 Don't assume that the difference between two unsigned long values
4939 can fit into an integer. At this point, we know button_down_time
4940 <= event->timestamp, so the difference must be nonnegative, so
4941 there's no need to cast the result if double-click-time is
4942 nonnegative, as it should be; check that it's nonnegative, just in
4943 case. This bug is triggered when events are more than 2**31 ms
4944 apart (about 25 days). (Bug#8664)
4945
4946 * xselect.c (last_event_timestamp): Remove duplicate decl.
4947 (x_own_selection): Remove needless cast to unsigned long.
4948
4949 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4950 that always fit in int. Use a sentinel instead of a counter, to
4951 avoid a temp and to allay GCC's concerns about possible int overflow.
4952 * frame.h (struct frame): Use int for menu_bar_items_used
4953 instead of EMACS_INT, since it always fits in int.
4954
4955 * menu.c (grow_menu_items): Check for int overflow.
4956
4957 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4958
4959 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4960 Before, the code was not consistent. These values cannot exceed
4961 2**31 - 1 so there's no need to make them unsigned.
4962 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4963 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4964 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4965 as modifiers.
4966 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4967
4968 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4969 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4970 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4971 presumably because the widths might not match.
4972
4973 * window.c (size_window): Avoid needless test at loop start.
4974
4975 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4976
4977 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4978
4979 2011-05-12 Drew Adams <drew.adams@oracle.com>
4980
4981 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4982
4983 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4984
4985 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4986 `width' to `bar_area_x' and `bar_area_width', respectively.
4987 (x_scroll_run): Take account of fringe background extension.
4988
4989 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4990 Rename local vars `left' and `width' to `bar_area_x' and
4991 `bar_area_width', respectively.
4992 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4993 background extension.
4994
4995 2011-05-10 Jim Meyering <meyering@redhat.com>
4996
4997 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4998
4999 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5000
5001 * image.c (Finit_image_library): Return t for built-in image types,
5002 like pbm and xbm. (Bug#8640)
5003
5004 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5005
5006 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5007
5008 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5009
5010 * w32console.c (Fset_screen_color): Doc fix.
5011 (Fget_screen_color): New function.
5012 (syms_of_ntterm): Defsubr it.
5013
5014 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5015 unlink the temporary file if Fcall_process didn't create it in the
5016 first place.
5017 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5018 child process will be redirected to a file specified with `:file'.
5019 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5020 cue to call_process_cleanup not to close that handle.
5021
5022 2011-05-07 Ben Key <bkey76@gmail.com>
5023
5024 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5025 one of two shell specific rules, either bootstrap-temacs-CMD or
5026 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5027 to the previous implementation of the bootstrap-temacs rule.
5028 The bootstrap-temacs-CMD rule is similar to the previous
5029 implementation of the bootstrap-temacs rule except that it
5030 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5031 variable.
5032
5033 These changes, along with some changes to nt/configure.bat,
5034 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5035 earlier fix to add support for --cflags and --ldflags options
5036 that include quotes so that it works whether make uses cmd or
5037 sh as the shell.
5038
5039 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5040
5041 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5042 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5043 is a constant.
5044 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5045 a string. Handle both cases.
5046 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5047 (Fdbus_register_method): Use Qinvalid_function.
5048
5049 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5050
5051 * makefile.w32-in: Update dependencies.
5052 (LISP_H): Add inttypes.h and stdin.h.
5053 (PROCESS_H): Add unistd.h.
5054
5055 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5056
5057 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5058 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5059
5060 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5061
5062 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5063
5064 * term.c (vfatal): Remove stray call to va_end.
5065 It's not needed and the C Standard doesn't allow it here anyway.
5066
5067 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5068 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5069
5070 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5071 bytes.
5072
5073 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5074
5075 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5076
5077 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5078
5079 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5080
5081 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5082
5083 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5084 * charset.c (Fdefine_charset_internal): Don't initialize
5085 charset.code_space[15]. The value was garbage, on hosts with
5086 32-bit int (Bug#8600).
5087
5088 * lread.c (read_integer): Be more consistent with string-to-number.
5089 Use string_to_number to do the actual conversion; this avoids
5090 rounding errors and fixes some other screwups. Without this fix,
5091 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5092 (digit_to_number): Move earlier, for benefit of read_integer.
5093 Return -1 if the digit is out of range for the base, -2 if it is
5094 not a digit in any supported base. (Bug#8602)
5095
5096 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5097
5098 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5099 to match comment at start of function. This also removes a
5100 GCC warning about overflow in a 32+64-bit port.
5101
5102 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5103
5104 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5105 Reported by Stefan Monnier in
5106 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5107 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5108 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5109
5110 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5111 (EMACS_UINTPTR): Likewise, with uintptr_t.
5112
5113 * lisp.h: Prefer 64-bit EMACS_INT if available.
5114 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5115 on 32-bit hosts that have 64-bit int, so that they can access
5116 large files.
5117 However, temporarily disable this change unless the temporary
5118 symbol WIDE_EMACS_INT is defined.
5119
5120 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5121
5122 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5123 This removes an assumption that EMACS_INT and long are the same
5124 width as pointers. The assumption is true for Emacs porting targets
5125 now, but we want to make other targets possible.
5126 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5127 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5128 In the rest of the code, change types of integers that hold casted
5129 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5130 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5131 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5132 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5133 No need to cast type when ORing.
5134 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5135 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5136 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5137 assume EMACS_INT is the same width as char *.
5138 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5139 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5140 Remove no-longer-needed casts.
5141 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5142 (xg_tool_bar_help_callback, xg_make_tool_item):
5143 Use EMACS_INTPTR to hold an integer
5144 that will be cast to void *; this can avoid a GCC warning
5145 if EMACS_INT is not the same width as void *.
5146 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5147 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5148 (current_message_1, set_message_1):
5149 Use a local to convert to proper width without a cast.
5150 * xmenu.c (dialog_selection_callback): Likewise.
5151
5152 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5153 Also, don't assume VALBITS / RAND_BITS is less than 5,
5154 and don't rely on undefined behavior when shifting a 1 left into
5155 the sign bit.
5156 * lisp.h (get_random): Change signature to match.
5157
5158 * lread.c (hash_string): Use size_t, not int, for hash computation.
5159 Normally we prefer signed values; but hashing is special, because
5160 it's better to use unsigned division on hash table sizes so that
5161 the remainder is nonnegative. Also, size_t is the natural width
5162 for hashing into memory. The previous code used 'int', which doesn't
5163 retain enough info to hash well into very large tables.
5164 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5165
5166 * dbusbind.c: Don't possibly lose pointer info when converting.
5167 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5168 Use XPNTR rather than XHASH, so that the high-order bits of
5169 the pointer aren't lost when converting through void *.
5170
5171 * eval.c (Fautoload): Don't double-shift a pointer.
5172
5173 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5174
5175 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5176
5177 * gnutls.c (DEF_GNUTLS_FN):
5178 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5179
5180 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5181
5182 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5183 marker. (Bug#8610)
5184
5185 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5186
5187 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5188 New version that can reserve upto 2GB of heap space.
5189
5190 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5191
5192 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5193
5194 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5195
5196 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5197 `gnutls_certificate_set_x509_key_file'.
5198
5199 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5202 Update dependencies.
5203
5204 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5205
5206 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5207 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5208 Remove unused parameter `fildes'.
5209 * process.c (read_process_output, send_process): Don't pass it.
5210
5211 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5212
5213 Fix previous change: the library cache is defined in w32.c.
5214 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5215 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5216
5217 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5218
5219 Implement dynamic loading of GnuTLS on Windows.
5220
5221 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5222 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5223 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5224 Declare.
5225
5226 * gnutls.c (Qgnutls_dll): Define.
5227 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5228 (gnutls_*): Declare function pointers.
5229 (init_gnutls_functions): New function to initialize function pointers.
5230 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5231 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5232 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5233 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5234 (emacs_gnutls_write, emacs_gnutls_read)
5235 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5236 (Fgnutls_available_p): New function.
5237 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5238 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5239 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5240
5241 * image.c: Include w32.h.
5242 (Vimage_type_cache): Delete.
5243 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5244 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5245 (w32_delayed_load): Move to w32.c.
5246
5247 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5248
5249 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5250 (w32_delayed_load): Move from image.c. When loading a library, record
5251 its filename in the :loaded-from property of the library id.
5252 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5253 Initialize and staticpro them.
5254 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5255
5256 * process.c: Include lisp.h before w32.h, not after.
5257 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5258 instead of gnutls_record_check_pending.
5259
5260 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5261
5262 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5263
5264 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5265 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5266 as passed in.
5267
5268 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5269
5270 * xterm.c (x_set_frame_alpha): Do not set property on anything
5271 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5272
5273 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5274
5275 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5276
5277 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5278
5279 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5280 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5281 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5282 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5283 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5284 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5285 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5286 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5287 (Qgnutls_bootprop_callbacks_verify): Make static.
5288
5289 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5290
5291 * callproc.c: Indentation fixup.
5292
5293 * sysdep.c (wait_for_termination_1): Make static.
5294 (wait_for_termination, interruptible_wait_for_termination):
5295 Move after wait_for_termination_1.
5296
5297 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5298
5299 * sysdep.c (interruptible_wait_for_termination): New function
5300 which is like wait_for_termination, but allows keyboard
5301 interruptions.
5302
5303 * callproc.c (Fcall_process): Add (:file "file") as an option for
5304 the STDOUT buffer.
5305 (Fcall_process_region): Ditto.
5306
5307 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5308
5309 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5310 rather than `XVECTOR (FOO)->size'.
5311
5312 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5313 inttypes.h, as a gnulib replacement is used if it not available in
5314 system headers.
5315
5316 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5317
5318 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5319 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5320 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5321
5322 * coding.c (coding_alloc_by_realloc): Error out if destination
5323 will grow beyond MOST_POSITIVE_FIXNUM.
5324 (decode_coding_emacs_mule): Abort if there isn't enough place in
5325 charbuf for the composition carryover bytes. Reserve an extra
5326 space for up to 2 characters produced in a loop.
5327 (decode_coding_iso_2022): Abort if there isn't enough place in
5328 charbuf for the composition carryover bytes.
5329
5330 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5331
5332 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5333 aborting when %lld or %lll format is passed.
5334 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5335 %llo or %llx format is passed. (Bug#8545)
5336
5337 * window.c (window_scroll_line_based): Use a marker instead of
5338 simple variables to record original value of point. (Bug#7952)
5339
5340 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5341 produced by %s or %c overflows available buffer space. (Bug#8545)
5342
5343 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5344
5345 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5346 (SIZE_MAX): Move defn after all includes, as they might #define it.
5347
5348 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5349
5350 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5351
5352 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5353
5354 * keyboard.c (Qdelayed_warnings_hook): Define.
5355 (command_loop_1): Run `delayed-warnings-hook'
5356 if Vdelayed_warnings_list is non-nil.
5357 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5358 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5359
5360 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5361
5362 * doprnt.c (doprnt): Don't return value smaller than the buffer
5363 size if the message was truncated. (Bug#8545).
5364
5365 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5366
5367 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5368 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5369
5370 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5371
5372 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5373
5374 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5375
5376 * makefile.w32-in: Update dependencies.
5377
5378 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5379
5380 Improve `doprnt' and its usage. (Bug#8545)
5381 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5382 `format_end'. Remove support for %l as a conversion specifier.
5383 Don't use xrealloc. Improve diagnostics when the %l size modifier
5384 is used. Update the commentary.
5385
5386 * eval.c (verror): Simplify calculation of size_t.
5387
5388 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5389 messages.
5390
5391 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5392
5393 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5394 change.
5395
5396 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5397
5398 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5399 This makes this file independent of the recent pseudovector change.
5400
5401 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5402
5403 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5404
5405 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5406 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5407 Remove unused local.
5408 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5409
5410 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5411 GCC 4.6.0 optimizes based on type-based alias analysis.
5412 For example, if b is of type struct buffer * and v of type struct
5413 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5414 != &v->size, and therefore "v->size = 1; b->size = 2; return
5415 v->size;" must therefore return 1. This assumption is incorrect
5416 for Emacs, since it type-puns struct Lisp_Vector * with many other
5417 types. To fix this problem, this patch adds a new type struct
5418 vectorlike_header that documents the constraints on layout of vectors
5419 and pseudovectors, and helps optimizing compilers not get fooled
5420 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5421 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5422 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5423 the size member.
5424 (XSETPVECTYPE): Rewrite in terms of new macro.
5425 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5426 This is a bit clearer, and further avoids the possibility of
5427 undesirable aliasing.
5428 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5429 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5430 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5431 since Lisp_Subr is a special case (no "next" field).
5432 (ASIZE): Now uses header.size rather than size.
5433 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5434 to avoid the hassle of writing XVECTOR (foo)->header.size.
5435 (struct vectorlike_header): New type.
5436 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5437 object, to help avoid aliasing.
5438 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5439 (SUBRP): Likewise, since Lisp_Subr is a special case.
5440 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5441 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5442 (struct Lisp_Hash_Table): Combine first two members into a single
5443 struct vectorlike_header member. All uses of "size" and "next" members
5444 changed to be "header.size" and "header.next".
5445 * buffer.h (struct buffer): Likewise.
5446 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5447 * frame.h (struct frame): Likewise.
5448 * process.h (struct Lisp_Process): Likewise.
5449 * termhooks.h (struct terminal): Likewise.
5450 * window.c (struct save_window_data, struct saved_window): Likewise.
5451 * window.h (struct window): Likewise.
5452 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5453 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5454 * buffer.c (init_buffer_once): Likewise.
5455 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5456 special case.
5457 * process.c (Fformat_network_address): Use local var for size,
5458 for brevity.
5459
5460 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5461
5462 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5463 * data.c (atof): Remove decl; no longer used or needed.
5464 (digit_to_number): Move to lread.c.
5465 (Fstring_to_number): Use new string_to_number function, to be
5466 consistent with how the Lisp reader treats infinities and NaNs.
5467 Do not assume that floating-point numbers represent EMACS_INT
5468 without losing information; this is not true on most 64-bit hosts.
5469 Avoid double-rounding errors, by insisting on integers when
5470 parsing non-base-10 numbers, as the documentation specifies.
5471 * lisp.h (string_to_number): New decl, replacing ...
5472 (isfloat_string): Remove.
5473 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5474 (read1): Do not accept +. and -. as integers; this
5475 appears to have been a coding error. Similarly, do not accept
5476 strings like +-1e0 as floating point numbers. Do not report
5477 overflow for integer overflows unless the base is not 10 which
5478 means we have no simple and reliable way to continue.
5479 Break out the floating-point parsing into a new
5480 function string_to_number, so that Fstring_to_number parses
5481 floating point numbers consistently with the Lisp reader.
5482 (digit_to_number): Move here from data.c. Make it static inline.
5483 (E_CHAR, EXP_INT): Remove, replacing with ...
5484 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5485 (string_to_number): New function, replacing isfloat_string.
5486 This function checks for valid syntax and produces the resulting
5487 Lisp float number too. Rework it so that string-to-number
5488 no longer mishandles examples like "1.0e+". Use strtoumax,
5489 so that overflow for non-base-10 numbers is reported only when
5490 there's no portable and simple way to convert to floating point.
5491
5492 * textprop.c (set_text_properties_1): Rewrite for clarity,
5493 and to avoid GCC warning about integer overflow.
5494
5495 * intervals.h (struct interval): Use EMACS_INT for members
5496 where EMACS_UINT might cause problems. See
5497 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5498 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5499 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5500 All uses changed.
5501 (offset_intervals): Tell GCC not to worry about length overflow
5502 when negating a negative length.
5503
5504 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5505 (overrun_check_free): Likewise.
5506
5507 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5508 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5509 word size.
5510
5511 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5512 (gnutls_make_error): Rename local to avoid shadowing.
5513 (gnutls_emacs_global_deinit): ifdef out; not used.
5514 (Fgnutls_boot): Use const for pointer to readonly storage.
5515 Comment out unused local. Fix pointer signedness problems.
5516
5517 * lread.c (openp): Don't stuff size_t into an 'int'.
5518 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5519 about possible signed overflow.
5520
5521 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5522 (GDK_KEY_g): Don't define if already defined.
5523 (xg_prepare_tooltip): Avoid pointer signedness problem.
5524 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5525
5526 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5527 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5528
5529 * xfns.c (Fx_window_property): Simplify a bit,
5530 to make a bit faster and to avoid GCC 4.6.0 warning.
5531 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5532
5533 * fns.c (internal_equal): Don't assume size_t fits in int.
5534
5535 * alloc.c (compact_small_strings): Tighten assertion a little.
5536
5537 Replace pEd with more-general pI, and fix some printf arg casts.
5538 * lisp.h (pI): New macro, generalizing old pEd macro to other
5539 conversion specifiers. For example, use "...%"pI"d..." rather
5540 than "...%"pEd"...".
5541 (pEd): Remove. All uses replaced with similar uses of pI.
5542 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5543 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5544 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5545 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5546 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5547 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5548 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5549 64-bit hosts.
5550 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5551 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5552 * print.c (safe_debug_print, print_object): Likewise.
5553 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5554 to int.
5555 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5556 avoiding the 0 flag, which is not portable.
5557 * process.c (Fmake_network_process): Use pI to avoid cast.
5558 * region-cache.c (pp_cache): Likewise.
5559 * xdisp.c (decode_mode_spec): Likewise.
5560 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5561 behavior on 64-bit hosts with printf arg.
5562 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5563 (x_stop_queuing_selection_requests): Likewise.
5564 (x_get_window_property): Don't truncate byte count to an 'int'
5565 when tracing.
5566
5567 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5568 here, since it parses constructs like leading '-' and spaces,
5569 which are not wanted; and it overflows with large numbers.
5570 Instead, simply match F[0-9]+, which is what is wanted anyway.
5571
5572 * alloc.c: Remove unportable assumptions about struct layout.
5573 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5574 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5575 (allocate_vectorlike, make_pure_vector): Use the new macros,
5576 plus offsetof, to remove unportable assumptions about struct layout.
5577 These assumptions hold on all porting targets that I know of, but
5578 they are not guaranteed, they're easy to remove, and removing them
5579 makes further changes easier.
5580
5581 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5582 This doesn't fix a bug but makes the code clearer.
5583 (string_overrun_cookie): Now const. Use initializers that
5584 don't formally overflow signed char, to avoid warnings.
5585 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5586 can cause Emacs to crash when string overrun checking is enabled.
5587 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5588 multiple of sizeof (EMACS_INT); it need not be, if
5589 alignof(EMACS_INT) < sizeof (EMACS_INT).
5590 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5591
5592 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5593
5594 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5595
5596 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5597
5598 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5599 supposed to be handshaking. (Bug#8556)
5600 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5601
5602 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5603
5604 * lisp.h (Qdebug): List symbol.
5605 * eval.c (Qdebug): Restore global linkage.
5606 * keyboard.c (debug-on-event): New variable.
5607 (handle_user_signal): Break into debugger when debug-on-event
5608 matches the current signal symbol.
5609
5610 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5611
5612 * alloc.c (check_sblock, check_string_bytes)
5613 (check_string_free_list): Convert to standard C.
5614
5615 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5616
5617 * w32.c (emacs_gnutls_push): Fix typo.
5618
5619 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5620
5621 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5622 "cast to pointer from integer of different size".
5623
5624 Improve doprnt and its use in verror. (Bug#8545)
5625 * doprnt.c (doprnt): Document the set of format control sequences
5626 supported by the function. Use SAFE_ALLOCA instead of always
5627 using `alloca'.
5628
5629 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5630 is one byte too soon. Don't use xrealloc; instead xfree and
5631 xmalloc anew.
5632
5633 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5634
5635 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5636 callbacks stage.
5637
5638 * gnutls.c: Renamed global_initialized to
5639 gnutls_global_initialized. Added internals for the
5640 :verify-hostname-error, :verify-error, and :verify-flags
5641 parameters of `gnutls-boot' and documented those parameters in the
5642 docstring. Start callback support.
5643 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5644 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5645 on error. Return error code.
5646 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5647 (emacs_gnutls_read): Likewise.
5648 (Fgnutls_boot): Return handshake error code.
5649 (emacs_gnutls_handle_error): New function.
5650 (wsaerror_to_errno): Likewise.
5651
5652 * w32.h (emacs_gnutls_pull): Add prototype.
5653 (emacs_gnutls_push): Likewise.
5654
5655 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5656 (emacs_gnutls_push): Likewise.
5657
5658 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5659
5660 * process.c (wait_reading_process_output): Check if GnuTLS
5661 buffered some data internally if no FDs are set for TLS
5662 connections.
5663
5664 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5665 (LIBS): Link to USER_LIBS.
5666 ($(BLD)/gnutls.$(0)): New target.
5667
5668 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5669
5670 * xdisp.c (handle_single_display_spec): Rename the
5671 display_replaced_before_p argument into display_replaced_p, to
5672 make it consistent with the commentary. Fix typos in the
5673 commentary.
5674
5675 * textprop.c (syms_of_textprop): Remove dead code.
5676 (copy_text_properties): Delete obsolete commentary about an
5677 interface that was deleted long ago. Fix typos in the description
5678 of arguments.
5679
5680 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5681 to changes in oldXMenu/XMenu.h from 2011-04-16.
5682 <menu_help_message, prev_menu_help_message>: Constify.
5683 (IT_menu_make_room): menu->help_text is now `const char **';
5684 adjust.
5685
5686 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5687 to changes in oldXMenu/XMenu.h from 2011-04-16.
5688 (struct XMenu): Declare `help_text' `const char **'.
5689
5690 * xfaces.c <Qunspecified>: Make extern again.
5691
5692 * syntax.c: Include sys/types.h before including regex.h, as
5693 required by Posix.
5694
5695 * doc.c (get_doc_string): Improve the format passed to `error'.
5696
5697 * doprnt.c (doprnt): Improve commentary.
5698
5699 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5700
5701 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5702 them with etags.
5703
5704 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5705 changes in globals.h immediately force recompilation.
5706 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5707 $(CURDIR)/s/ms-w32.h.
5708 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5709
5710 * character.c (Fchar_direction): Function deleted.
5711 (syms_of_character): Don't defsubr it.
5712 <char-direction-table>: Deleted.
5713
5714 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5715
5716 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5717 * doprnt.c: Include limits.h.
5718 (SIZE_MAX): New macro.
5719 (doprnt): Return a size_t value. 2nd arg is now size_t.
5720 Many local variables are now size_t instead of int or unsigned.
5721 Improve overflow protection. Support `l' modifier for integer
5722 conversions. Support %l conversion. Don't assume an EMACS_INT
5723 argument for integer conversions and for %c.
5724
5725 * lisp.h (doprnt): Restore prototype.
5726
5727 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5728 $(SRC)/character.h.
5729
5730 * Makefile.in (base_obj): Add back doprnt.o.
5731
5732 * deps.mk (doprnt.o): Add back prerequisites.
5733 (callint.o): Depend on character.h.
5734
5735 * eval.c (internal_lisp_condition_case): Include the handler
5736 representation in the error message.
5737 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5738 when breaking from the loop.
5739
5740 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5741
5742 * callint.c (Fcall_interactively): When displaying error message
5743 about invalid control letter, pass the character's codepoint, not
5744 a pointer to its multibyte form. Improve display of the character
5745 in octal and display also its hex code.
5746
5747 * character.c (char_string): Use %x to display the (unsigned)
5748 codepoint of an invalid character, to avoid displaying a bogus
5749 negative value.
5750
5751 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5752 `error', not SYMBOL_NAME itself.
5753
5754 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5755 character arguments to `error'.
5756
5757 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5758 to `error' in error message about FINAL_CHAR argument. Make sure
5759 FINAL_CHAR is a character, and use %c when it is passed as
5760 argument to `error'.
5761
5762 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5763
5764 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5765
5766 * w32.c: Include <time.h>.
5767 (sys_localtime): New function.
5768
5769 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5770
5771 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5772
5773 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5774
5775 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5776
5777 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5778 zombies (Bug#8467).
5779
5780 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5781
5782 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5783 gl_state.e_property when gl_state.object is Qt.
5784
5785 * insdel.c (make_gap_larger): Remove limitation of buffer size
5786 to <= INT_MAX.
5787
5788 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5789
5790 * xdisp.c (lookup_glyphless_char_display)
5791 (produce_glyphless_glyph): Handle cons cell entry in
5792 glyphless-char-display.
5793 (Vglyphless_char_display): Document it.
5794
5795 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5796 glyphless-char-display.
5797
5798 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5799
5800 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5801
5802 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5803
5804 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5805 definition for no-X builds.
5806
5807 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5808
5809 Static checks with GCC 4.6.0 and non-default toolkits.
5810
5811 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5812
5813 * process.c (keyboard_bit_set): Define only if SIGIO.
5814 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5815 (send_process): Repair possible setjmp clobbering.
5816
5817 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5818
5819 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5820
5821 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5822
5823 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5824 Define only if needed.
5825
5826 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5827 by pacifying GCC about it. Maybe it's time to retire it?
5828 * xfaces.c (USG, __TIMEVAL__): Likewise.
5829
5830 * dispextern.h (struct redisplay_interface): Rename param
5831 to avoid shadowing.
5832 * termhooks.h (struct terminal): Likewise.
5833 * xterm.c (xembed_send_message): Likewise.
5834
5835 * insdel.c (make_gap_smaller): Define only if
5836 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5837
5838 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5839 it.
5840
5841 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5842 so that we aren't warned about unused symbols.
5843
5844 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5845
5846 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5847
5848 * xfns.c (x_real_positions): Mark locals as initialized.
5849
5850 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5851
5852 * xterm.c: Fix problems found by static analysis with other toolkits.
5853 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5854 (x_dispatch_event): Declare static if USE_GTK, and
5855 define if USE_GTK || USE_X_TOOLKIT.
5856 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5857 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5858 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5859 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5860
5861 * xmenu.c (menu_help_callback): Pointer type fixes.
5862 Use const pointers when pointing at readonly data. Avoid pointer
5863 signedness clashes.
5864 (FALSE): Remove unused macro.
5865 (update_frame_menubar): Remove unused decl.
5866
5867 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5868
5869 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5870 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5871 (single_menu_item): Rename local to avoid shadowing.
5872
5873 * keyboard.c (make_lispy_event): Remove unused local var.
5874
5875 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5876 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5877
5878 * bitmaps: Change bitmaps from unsigned char back to the X11
5879 compatible char. Avoid the old compiler warnings about
5880 out-of-range initializers by using, for example, '\xab' rather
5881 than 0xab.
5882
5883 * xgselect.c (xgselect_initialize): Check vs interface
5884 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5885
5886 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5887
5888 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5889 to read-only memory.
5890
5891 * fns.c (vector): Remove; this old hack is no longer needed.
5892
5893 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5894 Remove unused var.
5895 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5896
5897 * xrdb.c (x_load_resources): Omit unused local.
5898
5899 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5900 (x_window): Rename locals to avoid shadowing.
5901 (USG): Use the kludged USG macro, to pacify gcc.
5902
5903 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5904 (x_term_init): Remove local to avoid shadowing.
5905
5906 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5907
5908 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5909 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5910
5911 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5912
5913 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5914
5915 Fix regex.c, syntax.c and friends for buffers > 2GB.
5916 * syntax.h (struct gl_state_s): Declare character position members
5917 EMACS_INT.
5918
5919 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5920
5921 * textprop.c (verify_interval_modification, interval_of):
5922 Declare arguments EMACS_INT.
5923
5924 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5925 EMACS_INT.
5926
5927 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5928
5929 * indent.c (Fvertical_motion): Local variable it_start is now
5930 EMACS_INT.
5931
5932 * regex.c (re_match, re_match_2, re_match_2_internal)
5933 (bcmp_translate, regcomp, regexec, print_double_string)
5934 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5935 (re_compile_pattern, re_exec): Declare arguments and local
5936 variables `size_t' and `ssize_t' and return values `regoff_t', as
5937 appropriate.
5938 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5939 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5940 <compile_stack_type>: `size' and `avail' are now `size_t'.
5941
5942 * regex.h <regoff_t>: Use ssize_t, not int.
5943 (re_search, re_search_2, re_match, re_match_2): Arguments that
5944 specify buffer/string position and length are now ssize_t and
5945 size_t. Return type is regoff_t.
5946
5947 2011-04-16 Ben Key <bkey76@gmail.com>
5948
5949 * nsfont.m: Fixed bugs in ns_get_family and
5950 ns_descriptor_to_entity that were caused by using free to
5951 deallocate memory blocks that were allocated by xmalloc (via
5952 xstrdup). This caused Emacs to crash when compiled with
5953 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5954 --enable-checking=xmallocoverrun). xfree is now used to
5955 deallocate these memory blocks.
5956
5957 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5958
5959 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5960
5961 emacs_write: Accept and return EMACS_INT for sizes.
5962 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5963 et seq.
5964 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5965 Accept and return EMACS_INT.
5966 (emacs_gnutls_write): Return the number of bytes written on
5967 partial writes.
5968 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5969 (emacs_read, emacs_write): Remove check for negative size, as the
5970 Emacs source code has been audited now.
5971 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5972 (emacs_read, emacs_write): Use it.
5973 * process.c (send_process): Adjust to the new signatures of
5974 emacs_write and emacs_gnutls_write. Do not attempt to store
5975 a byte offset into an 'int'; it might overflow.
5976 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5977
5978 * sound.c: Don't assume sizes fit in 'int'.
5979 (struct sound_device.period_size, alsa_period_size):
5980 Return EMACS_INT, not int.
5981 (struct sound_device.write, vox_write, alsa_write):
5982 Accept EMACS_INT, not int.
5983 (wav_play, au_play): Use EMACS_INT to store sizes and to
5984 record read return values.
5985
5986 2011-04-15 Ben Key <bkey76@gmail.com>
5987
5988 * keyboard.c (Qundefined): Don't declare static since it is used
5989 in nsfns.m.
5990 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5991 static since they are used in nsfont.m.
5992
5993 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5994
5995 * process.c (Qprocessp): Don't declare static.
5996 * lisp.h (Qprocessp): Declare again.
5997
5998 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5999
6000 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6001
6002 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6003
6004 Improve C-level modularity by making more things 'static'.
6005
6006 Don't publish debugger-only interfaces to other modules.
6007 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6008 (verify_bytepos, count_markers): Move decls to the only modules
6009 that need them.
6010 * region-cache.h (pp_cache): Likewise.
6011 * window.h (check_all_windows): Likewise.
6012 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6013
6014 * sysdep.c (croak): Now static, if
6015 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6016 * syssignal.h (croak): Declare only if not static.
6017
6018 * alloc.c (refill_memory_reserve): Now static if
6019 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6020 * lisp.h (refill_memory_reserve): Declare only if not static.
6021
6022 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6023 Define only if USE_LUCID.
6024
6025 * xrdb.c (x_customization_string, x_rm_string): Now static.
6026
6027 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6028 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6029
6030 * xdisp.c (draw_row_with_mouse_face): Now static.
6031 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6032
6033 * window.h (check_all_windows): Mark externally visible.
6034
6035 * window.c (window_deletion_count): Now static.
6036
6037 * undo.c: Make symbols static if they're not exported.
6038 (last_undo_buffer, last_boundary_position, pending_boundary):
6039 Now static.
6040
6041 * textprop.c (interval_insert_behind_hooks): Now static.
6042 (interval_insert_in_front_hooks): Likewise.
6043
6044 * term.c: Make symbols static if they're not exported.
6045 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6046 (max_frame_lines, tty_set_terminal_modes):
6047 (tty_reset_terminal_modes, tty_turn_off_highlight):
6048 (get_tty_terminal): Now static.
6049 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6050 * termhooks.h (term_mouse_moveto): Do not declare if
6051 HAVE_WINDOW_SYSTEM.
6052 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6053 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6054
6055 * sysdep.c: Make symbols static if they're not exported.
6056 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6057 Now static.
6058 (sigprocmask_set, full_mask): Remove; unused.
6059 (wait_debugging): Mark as visible.
6060 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6061 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6062
6063 * syntax.c (syntax_temp): Define only if !__GNUC__.
6064
6065 * sound.c (current_sound_device, current_sound): Now static.
6066
6067 * search.c (searchbufs, searchbuf_head): Now static.
6068
6069 * scroll.c (scroll_cost): Remove; unused.
6070 * dispextern.h (scroll_cost): Remove decl.
6071
6072 * region-cache.h (pp_cache): Mark as externally visible.
6073
6074 * process.c: Make symbols static if they're not exported.
6075 (process_tick, update_tick, create_process, chan_process):
6076 (Vprocess_alist, proc_buffered_char, datagram_access):
6077 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6078 (deactivate_process): Mark defn as static, as well as decl.
6079 * lisp.h (create_process): Remove decl.
6080 * process.h (chan_process, Vprocess_alist): Remove decls.
6081
6082 * print.c: Make symbols static if they're not exported.
6083 (print_depth, new_backquote_output, being_printed, print_buffer):
6084 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6085 (print_interval, print_number_index, initial_stderr_stream):
6086 Now static.
6087 * lisp.h (Fprinc): Remove decl.
6088 (debug_output_compilation_hack): Mark as externally visible.
6089
6090 * sysdep.c (croak): Move decl from here to syssignal.h.
6091 * syssignal.h (croak): Put it here, so the API can be checked when
6092 'croak' is called from dissociate_if_controlling_tty.
6093
6094 * minibuf.c: Make symbols static if they're not exported.
6095 (minibuf_save_list, choose_minibuf_frame): Now static.
6096 * lisp.h (choose_minibuf_frame): Remove decl.
6097
6098 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6099
6100 * lread.c: Make symbols static if they're not exported.
6101 (read_objects, initial_obarray, oblookup_last_bucket_number):
6102 Now static.
6103 (make_symbol): Remove; unused.
6104 * lisp.h (initial_obarray, make_symbol): Remove decls.
6105
6106 * keyboard.c: Make symbols static if they're not exported.
6107 (single_kboard, recent_keys_index, total_keys, recent_keys):
6108 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6109 (this_single_command_key_start, echoing, last_auto_save):
6110 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6111 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6112 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6113 (Vlispy_mouse_stem, double_click_count):
6114 Now static.
6115 (force_auto_save_soon): Define only if SIGDANGER.
6116 (ignore_mouse_drag_p): Now static if
6117 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6118 (print_help): Remove; unused.
6119 (stop_character, last_timer_event): Mark as externally visible.
6120 * keyboard.h (ignore_mouse_drag_p): Declare only if
6121 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6122 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6123 * lisp.h (echoing): Remove decl.
6124 (force_auto_save_soon): Declare only if SIGDANGER.
6125 * xdisp.c (redisplay_window): Simplify code, to make it more
6126 obvious that ignore_mouse_drag_p is not accessed if !defined
6127 USE_GTK && !defined HAVE_NS.
6128
6129 * intervals.c: Make symbols static if they're not exported.
6130 (merge_properties_sticky, merge_interval_right, delete_interval):
6131 Now static.
6132 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6133
6134 * insdel.c: Make symbols static if they're not exported.
6135 However, leave prepare_to_modify_buffer alone. It's never
6136 called from outside this function, but that appears to be a bug.
6137 (combine_after_change_list, combine_after_change_buffer):
6138 (adjust_after_replace, signal_before_change): Now static.
6139 (adjust_after_replace_noundo): Remove; unused.
6140 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6141 (signal_before_change): Remove decls.
6142
6143 * indent.c (val_compute_motion, val_vmotion): Now static.
6144
6145 * image.c: Make symbols static if they're not exported.
6146 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6147 if USE_GTK.
6148 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6149 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6150
6151 * fringe.c (standard_bitmaps): Now static.
6152 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6153
6154 * frame.c: Make symbols static if they're not exported.
6155 (x_report_frame_params, make_terminal_frame): Now static.
6156 (get_frame_param): Now static, unless HAVE_NS.
6157 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6158 (x_get_resource_string): Remove; not used.
6159 * frame.h (make_terminal_frame, x_report_frame_params):
6160 (x_get_resource_string); Remove decls.
6161 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6162 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6163
6164 * font.c, fontset.c: Make symbols static if they're not exported.
6165 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6166 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6167 * font.c (font_close_object): Now static.
6168 * font.h (font_close_object): Remove.
6169 * fontset.c (FONTSET_OBJLIST): Remove.
6170 (free_realized_fontset) #if-0 the body, which does nothing.
6171 (face_suitable_for_char_p): #if-0, as it's never called.
6172 * fontset.h (face_suitable_for_char_p): Remove decl.
6173 * xfaces.c (face_at_string_position):
6174 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6175 since 0 is always ASCII.
6176
6177 * fns.c (weak_hash_tables): Now static.
6178
6179 * fileio.c: Make symbols static if they're not exported.
6180 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6181 (Vwrite_region_annotation_buffers): Now static.
6182
6183 * eval.c: Make symbols static if they're not exported.
6184 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6185 * lisp.h (backtrace_list): Remove decl.
6186
6187 * emacs.c: Make symbols static if they're not exported.
6188 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6189 (fatal_error_code, fatal_error_signal_hook, standard_args):
6190 Now static.
6191 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6192 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6193 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6194 * lisp.h (fatal_error_signal_hook): Remove decl.
6195 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6196
6197 * editfns.c: Move a (normally-unused) function to its only use.
6198 * editfns.c, lisp.h (get_operating_system_release): Remove.
6199 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6200 worth the hassle of breaking this out.
6201
6202 * xterm.c: Make symbols static if they're not exported.
6203 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6204 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6205 (x_destroy_window, x_delete_display):
6206 Now static.
6207 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6208 (x_mouse_leave): Remove; unused.
6209 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6210 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6211 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6212 Remove decls.
6213 (x_mouse_leave): Declare only if WINDOWSNT.
6214 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6215 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6216 USE_X_TOOLKIT.
6217
6218 * ftxfont.c: Make symbols static if they're not exported.
6219 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6220 HAVE_FREETYPE.
6221 * font.h (ftxfont_driver): Likewise.
6222
6223 * xfns.c: Make symbols static if they're not exported.
6224 (x_last_font_name, x_display_info_for_name):
6225 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6226 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6227 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6228 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6229 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6230 (last_show_tip_args): Now static.
6231 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6232 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6233 (x_screen_planes): Remove; unused.
6234 * dispextern.h (x_screen_planes): Remove decl.
6235
6236 * dispnew.c: Make symbols static if they're not exported.
6237 * dispextern.h (redraw_garbaged_frames, scrolling):
6238 (increment_row_positions): Remove.
6239 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6240 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6241 Now static.
6242 (redraw_garbaged_frames): Remove; unused.
6243
6244 * xfaces.c: Make symbols static if they're not exported.
6245 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6246 Remove decls.
6247 * xterm.h (defined_color): Remove decls.
6248 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6249 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6250 (menu_face_changed_default, defined_color, free_realized_face):
6251 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6252 (ascii_face_of_lisp_face): Remove; unused.
6253
6254 * xdisp.c: Make symbols static if they're not exported.
6255 * dispextern.h (scratch_glyph_row, window_box_edges):
6256 (glyph_to_pixel_coords, set_cursor_from_row):
6257 (get_next_display_element, set_iterator_to_next):
6258 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6259 (show_mouse_face): Remove decls
6260 * frame.h (message_buf_print): Likewise.
6261 * lisp.h (pop_message, set_message, check_point_in_composition):
6262 Likewise.
6263 * xterm.h (set_vertical_scroll_bar): Likewise.
6264 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6265 (message_buf_print, scratch_glyph_row, displayed_buffer):
6266 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6267 (get_next_display_element, show_mouse_face, window_box_edges):
6268 (frame_to_window_pixel_xy, check_point_in_composition):
6269 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6270 (glyph_to_pixel_coords): Remove; unused.
6271
6272 * dired.c (file_name_completion): Now static.
6273
6274 * dbusbind.c (xd_in_read_queued_messages): Now static.
6275
6276 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6277 * data.c (circular_list_error): Remove.
6278
6279 * commands.h (last_point_position, last_point_position_buffer):
6280 (last_point_position_window): Remove decls.
6281 * keyboard.c: Make these variables static.
6282
6283 * coding.h (coding, code_convert_region, encode_coding_gap):
6284 Remove decls.
6285 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6286 (iso_code_class, detect_coding, code_convert_region): Now static.
6287 (encode_coding_gap): Remove; unused.
6288
6289 * chartab.c (chartab_chars, chartab_bits): Now static.
6290
6291 * charset.h (charset_iso_8859_1): Remove decl.
6292 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6293 Now static.
6294
6295 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6296 * ccl.c (Vccl_program_table): Now static.
6297 (check_ccl_update): Remove; unused.
6298
6299 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6300 * category.h: ... from here.
6301 * category.c (check_category_table, set_category_set): Now static.
6302
6303 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6304 * lisp.h: Remove these decls.
6305
6306 * buffer.c (buffer_count): Remove unused var.
6307
6308 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6309 so that it's not optimized away.
6310 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6311 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6312 exported only to the debugger.
6313
6314 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6315 * atimer.h (run_all_atimers): Remove; not exported.
6316
6317 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6318 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6319 was inaccessible from Lisp.
6320 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6321 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6322
6323 alloc.c: Import and export fewer symbols, and remove unused items.
6324 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6325 is defined.
6326 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6327 it's not optimized away by whole-program optimization.
6328 (message_enable_multibyte, free_misc): Remove.
6329 (catchlist, handlerlist, mark_backtrace):
6330 Declare only if BYTE_MARK_STACK.
6331 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6332 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6333 (message_enable_multibyte): Remove decl.
6334 (free_misc, interval_free_list, float_block, float_block_index):
6335 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6336 (cons_free_list, last_marked_index):
6337 Now static.
6338 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6339 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6340 (mark_backtrace): Define only if BYTE_MARK_STACK.
6341 * xdisp.c (message_enable_multibyte): Now static.
6342
6343 Declare Lisp_Object Q* variables to be 'static' if not exported.
6344 This makes it easier for human readers (and static analyzers)
6345 to see whether these variables are used from other modules.
6346 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6347 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6348 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6349 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6350 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6351 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6352 * xmenu.c, xselect.c:
6353 Declare Q* vars static if they are not used in other modules.
6354 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6355 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6356 Remove decls of unexported vars.
6357 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6358
6359 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6360
6361 Make Emacs functions such as Fatom 'static' by default.
6362 This makes it easier for human readers (and static analyzers)
6363 to see whether these functions can be called from other modules.
6364 DEFUN now defines a static function. To make the function external
6365 so that it can be used in other C modules, use the new macro DEFUE.
6366 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6367 (Finit_image_library):
6368 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6369 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6370 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6371 Remove decls, since these functions are now static.
6372 (Funintern, Fget_internal_run_time): New decls, since these functions
6373 were already external.
6374
6375 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6376 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6377 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6378 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6379 * keyboard.c, keymap.c, lread.c:
6380 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6381 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6382 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6383 Mark functions with DEFUE instead of DEFUN,
6384 if they are used in other modules.
6385 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6386 decls for now-static functions.
6387 * buffer.h (Fdelete_overlay): Remove decl.
6388 * callproc.c (Fgetenv_internal): Mark as internal.
6389 * composite.c (Fremove_list_of_text_properties): Remove decl.
6390 (Fcomposition_get_gstring): New forward static decl.
6391 * composite.h (Fcomposite_get_gstring): Remove decl.
6392 * dired.c (Ffile_attributes): New forward static decl.
6393 * doc.c (Fdocumntation_property): New forward static decl.
6394 * eval.c (Ffetch_bytecode): New forward static decl.
6395 (Funintern): Remove extern decl; now in .h file where it belongs.
6396 * fileio.c (Fmake_symbolic_link): New forward static decl.
6397 * image.c (Finit_image_library): New forward static decl.
6398 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6399 * intervals.h (Fprevious_property_change):
6400 (Fremove_list_of_text_properties): Remove decls.
6401 * keyboard.c (Fthis_command_keys): Remove decl.
6402 (Fcommand_execute): New forward static decl.
6403 * keymap.c (Flookup_key): New forward static decl.
6404 (Fcopy_keymap): Now static.
6405 * keymap.h (Flookup_key): Remove decl.
6406 * process.c (Fget_process): New forward static decl.
6407 (Fprocess_datagram_address): Mark as internal.
6408 * syntax.c (Fsyntax_table_p): New forward static decl.
6409 (skip_chars): Remove duplicate decl.
6410 * textprop.c (Fprevious_property_change): New forward static decl.
6411 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6412 Now internal.
6413 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6414 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6415
6416 * editfns.c (Fformat): Remove unreachable code.
6417
6418 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6419
6420 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6421 change. (Bug#8496)
6422
6423 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6424
6425 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6426 when at ZV. (Bug#8487)
6427
6428 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6429
6430 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6431 (Bug#8437)
6432 * keyboard.c (parse_tool_bar_item): Likewise.
6433 * sound.c (sound_cleanup, alsa_close): Likewise.
6434 * termcap.c (tgetent): Likewise.
6435 * xfns.c (x_default_font_parameter): Likewise.
6436 * xsettings.c (read_and_apply_settings): Likewise.
6437
6438 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6439 (overrun_check_free): Protoize.
6440
6441 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6442
6443 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6444 since callers should never pass a negative size.
6445 Change the signature to match that of plain 'read' and 'write'; see
6446 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6447 * lisp.h: Update prototypes of emacs_write and emacs_read.
6448
6449 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6450
6451 * xdisp.c (redisplay_window): Don't try to determine the character
6452 position of the scroll margin if the window start point w->startp
6453 is outside the buffer's accessible region. (Bug#8468)
6454
6455 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6456
6457 Fix write-region and its subroutines for buffers > 2GB.
6458 * fileio.c (a_write, e_write): Modify declaration of arguments and
6459 local variables to support buffers larger than 2GB.
6460 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6461
6462 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6463 argument, local variables, and return value.
6464
6465 * lisp.h: Update prototypes of emacs_write and emacs_read.
6466
6467 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6468
6469 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6470
6471 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6472
6473 Fix more problems found by GCC 4.6.0's static checks.
6474
6475 * xdisp.c (vmessage): Use a better test for character truncation.
6476
6477 * charset.c (load_charset_map): <, not <=, for optimization,
6478 and to avoid potential problems with integer overflow.
6479 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6480 * casetab.c (set_identity, shuffle): Likewise.
6481 * editfns.c (Fformat): Likewise.
6482 * syntax.c (skip_chars): Likewise.
6483
6484 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6485 This also lets GCC 4.6.0 generate slightly better loop code.
6486
6487 * callint.c (Fcall_interactively): <, not <=, for optimization.
6488 (Fcall_interactively): Count the number of arguments produced,
6489 not the number of arguments given. This is simpler and lets GCC
6490 4.6.0 generate slightly better code.
6491
6492 * ftfont.c: Distingish more carefully between FcChar8 and char.
6493 The previous code passed unsigned char * to a functions like
6494 strlen and xstrcasecmp that expect char *, which does not
6495 conform to the C standard.
6496 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6497 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6498 char * when the C standard requires it.
6499
6500 * keyboard.c (read_char): Remove unused var.
6501
6502 * eval.c: Port to Windows vsnprintf (Bug#8435).
6503 Include <limits.h>.
6504 (SIZE_MAX): Define if the headers do not.
6505 (verror): Do not give up if vsnprintf returns a negative count.
6506 Instead, grow the buffer. This ports to Windows vsnprintf, which
6507 does not conform to C99. Problem reported by Eli Zaretskii.
6508 Also, simplify the allocation scheme, by avoiding the need for
6509 calling realloc, and removing the ALLOCATED variable.
6510
6511 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6512
6513 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6514 But keep the doprint source code for now, as we might revamp it
6515 and use it again (Bug#8435).
6516 * lisp.h (doprnt): Remove.
6517 * Makefile.in (base_obj): Remove doprnt.o.
6518 * deps.mk (doprnt.o): Remove.
6519
6520 error: Print 32- and 64-bit integers portably (Bug#8435).
6521 Without this change, on typical 64-bit hosts error ("...%d...", N)
6522 was used to print both 32- and 64-bit integers N, which relied on
6523 undefined behavior.
6524 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6525 New macro.
6526 * lisp.h (error, verror): Mark as printf-like functions.
6527 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6528 Report overflow in size calculations when allocating printf buffer.
6529 Do not truncate output string at its first null byte.
6530 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6531 Truncate the output at a character boundary, since vsnprintf does not
6532 do that.
6533 * charset.c (check_iso_charset_parameter): Convert internal
6534 character to string before calling 'error', since %c now has the
6535 printf meaning.
6536 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6537 overflow when computing char to be passed to 'error'. Do not
6538 pass Lisp_Object to 'error'; pass the integer instead.
6539 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6540 formatted with plain %d.
6541
6542 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6543
6544 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6545
6546 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6547
6548 * xterm.c (x_catch_errors): Remove duplicate declaration.
6549
6550 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6551
6552 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6553
6554 2011-04-10 Jim Meyering <meyering@redhat.com>
6555
6556 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6557 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6558 return ssize_t not "int", and use size_t as the buffer length.
6559 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6560 * gnutls.h: Update declarations.
6561 * process.c (read_process_output): Use ssize_t, to match.
6562 (send_process): Likewise.
6563
6564 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6565
6566 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6567
6568 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6569
6570 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6571 Use unsigned char, to match FcChar8 type definition.
6572
6573 * xterm.c (handle_one_xevent):
6574 * xmenu.c (create_and_show_popup_menu):
6575 * xselect.c (x_decline_selection_request)
6576 (x_reply_selection_request): Avoid type-punned deref of X events.
6577
6578 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6579
6580 Fix some uses of `int' instead of EMACS_INT.
6581 * search.c (string_match_1, fast_string_match)
6582 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6583 (scan_buffer, find_next_newline_no_quit)
6584 (find_before_next_newline, search_command, Freplace_match)
6585 (Fmatch_data): Make some `int' variables be EMACS_INT.
6586
6587 * xdisp.c (display_count_lines): 3rd argument and return value now
6588 EMACS_INT. All callers changed.
6589 (pint2hrstr): Last argument is now EMACS_INT.
6590
6591 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6592 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6593 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6594 (decode_coding_utf_16, decode_coding_emacs_mule)
6595 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6596 (decode_coding_ccl, decode_coding_charset)
6597 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6598 (decode_coding_iso_2022, decode_coding_emacs_mule)
6599 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6600 <char_offset, last_offset>: Declare EMACS_INT.
6601 (encode_coding_utf_8, encode_coding_utf_16)
6602 (encode_coding_emacs_mule, encode_invocation_designation)
6603 (encode_designation_at_bol, encode_coding_iso_2022)
6604 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6605 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6606 Declare EMACS_INT.
6607 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6608 (encode_invocation_designation): Last argument P_NCHARS is now
6609 EMACS_INT.
6610 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6611 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6612
6613 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6614 All users changed.
6615
6616 * ccl.c (Fccl_execute_on_string): Declare some variables
6617 EMACS_INT.
6618
6619 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6620
6621 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6622
6623 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6624
6625 * process.c (Fformat_network_address): Doc fix.
6626
6627 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6628
6629 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6630
6631 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6632
6633 * keyboard.c (read_char): Call Lisp function help-form-show,
6634 instead of using internal_with_output_to_temp_buffer.
6635 (Qhelp_form_show): New var.
6636 (syms_of_keyboard): Use DEFSYM macro.
6637
6638 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6639
6640 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6641
6642 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6643
6644 * process.c (Flist_processes): Remove to Lisp.
6645 (list_processes_1): Delete.
6646
6647 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6648
6649 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6650
6651 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6652
6653 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6654
6655 Fix more problems found by GCC 4.6.0's static checks.
6656
6657 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6658
6659 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6660
6661 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6662
6663 * xdisp.c (vmessage): Mark as a printf-like function.
6664
6665 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6666
6667 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6668
6669 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6670 printf-like functions.
6671 (tiff_load): Add casts to remove these marks before passing them
6672 to system-supplied API.
6673
6674 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6675
6676 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6677 This avoids several warnings with gcc -Wstrict-overflow.
6678 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6679 directly, rather than having caller test rule sign. This avoids
6680 some unnecessary tests.
6681 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6682 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6683 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6684
6685 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6686 (xfont_open): Avoid unnecessary tests.
6687
6688 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6689
6690 * composite.h, composite.c (composition_gstring_put_cache):
6691 Use EMACS_INT, not int, for length.
6692
6693 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6694 breaking out part of COMPOSITION_DECODE_RULE.
6695 (COMPOSITION_DECODE_RULE): Use it.
6696 * composite.c (get_composition_id): Remove unused local vars,
6697 by using the new macro.
6698
6699 * textprop.c (set_text_properties_1): Change while to do-while,
6700 since the condition is always true at first.
6701
6702 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6703 (interval_deletion_adjustment): Return unsigned value.
6704 All uses changed.
6705
6706 * process.c (list_processes_1, create_pty, read_process_output):
6707 (exec_sentinel): Remove vars that were set but not used.
6708 (create_pty): Remove unnecessary "volatile"s.
6709 (Fnetwork_interface_info): Avoid possibility of int overflow.
6710 (read_process_output): Do adaptive read buffering even if carryover.
6711 (read_process_output): Simplify nbytes computation if buffered.
6712
6713 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6714
6715 * syntax.c (scan_words): Remove var that was set but not used.
6716 (update_syntax_table): Use unsigned instead of int.
6717
6718 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6719 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6720 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6721
6722 * print.c (print_error_message): Avoid int overflow.
6723
6724 * font.c (font_list_entities): Redo for clarity,
6725 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6726
6727 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6728 (font_score): Avoid potential overflow in diff calculation.
6729
6730 * fns.c (substring_both): Remove var that is set but not used.
6731 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6732
6733 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6734
6735 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6736 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6737 can always succeed if overflow has undefined behavior.
6738
6739 * search.c (boyer_moore, wordify): Remove vars set but not used.
6740 (wordify): Omit three unnecessary tests.
6741
6742 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6743 All callers changed. This avoids the need for an unused var.
6744
6745 * casefiddle.c (casify_region): Remove var that is set but not used.
6746
6747 * dired.c (file_name_completion): Remove var that is set but not used.
6748
6749 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6750
6751 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6752 (Finsert_file_contents): Remove unnecessary code checking fd.
6753
6754 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6755 Check for integer overflow on size calculations.
6756
6757 * buffer.c (Fprevious_overlay_change): Remove var that is set
6758 but not used.
6759
6760 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6761 Remove vars that are set but not used.
6762 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6763 (timer_check_2): Mark vars as initialized.
6764
6765 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6766
6767 * image.c (lookup_image): Remove var that is set but not used.
6768 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6769
6770 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6771 that are set but not used.
6772
6773 * xfns.c (make_invisible_cursor): Don't return garbage
6774 if XCreateBitmapFromData fails (Bug#8410).
6775
6776 * xselect.c (x_get_local_selection, x_handle_property_notify):
6777 Remove vars that are set but not used.
6778
6779 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6780 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6781
6782 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6783 Remove var that is set but not used.
6784 (scroll_bar_windows_size): Now size_t, not int.
6785 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6786 Check for overflow.
6787
6788 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6789 (map_tty_color) [!defined MSDOS]: Likewise.
6790
6791 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6792
6793 * coding.c: Remove vars that are set but not used.
6794 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6795 All callers changed.
6796 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6797 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6798 (decode_coding_charset): Remove vars that are set but not used.
6799
6800 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6801 that is set but not used.
6802
6803 * print.c (print_object): Remove var that is set but not used.
6804
6805 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6806 The gnulib version avoids calling malloc in the usual case,
6807 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6808 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6809 * filelock.c (current_lock_owner): Likewise.
6810 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6811 * sysdep.c: Include allocator.h, careadlinkat.h.
6812 (emacs_no_realloc_allocator): New static constant.
6813 (emacs_readlink): New function.
6814 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6815 ../lib/careadlinkat.h.
6816
6817 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6818
6819 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6820 first non-nil return value).
6821
6822 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6823
6824 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6825 if not defined (Bug#8403).
6826
6827 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6828
6829 * xdisp.c (display_count_lines): Remove parameter `start',
6830 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6831 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6832 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6833 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6834 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6835 and thereabouts. All callers changed.
6836 (get_per_char_metric): Remove parameter `f', unused since
6837 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6838
6839 2011-04-02 Jim Meyering <meyering@redhat.com>
6840
6841 do not dereference NULL upon failed strdup
6842 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6843 (ns_get_family): Likewise.
6844
6845 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6846
6847 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6848
6849 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6850
6851 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6852 later (Bug#8403).
6853
6854 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6855
6856 Add lexical binding.
6857
6858 * window.c (Ftemp_output_buffer_show): New fun.
6859 (Fsave_window_excursion):
6860 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6861
6862 * lread.c (lisp_file_lexically_bound_p): New function.
6863 (Fload): Bind Qlexical_binding.
6864 (readevalloop): Remove `evalfun' arg.
6865 Bind Qinternal_interpreter_environment.
6866 (Feval_buffer): Bind Qlexical_binding.
6867 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6868 Mark as dynamic.
6869 (syms_of_lread): Declare `lexical-binding'.
6870
6871 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6872
6873 * keyboard.c (eval_dyn): New fun.
6874 (menu_item_eval_property): Use it.
6875
6876 * image.c (parse_image_spec): Use Ffunctionp.
6877
6878 * fns.c (concat, mapcar1): Accept byte-code-functions.
6879
6880 * eval.c (Fsetq): Handle lexical vars.
6881 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6882 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6883 (FletX, Flet): Obey lexical binding.
6884 (Fcommandp): Handle closures.
6885 (Feval): New `lexical' arg.
6886 (eval_sub): New function extracted from Feval. Use it almost
6887 everywhere where Feval was used. Look up vars in lexical env.
6888 Handle closures.
6889 (Ffunctionp): Move from subr.el.
6890 (Ffuncall): Handle closures.
6891 (apply_lambda): Remove `eval_flags'.
6892 (funcall_lambda): Handle closures and new byte-code-functions.
6893 (Fspecial_variable_p): New function.
6894 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6895 but without exporting it to Lisp.
6896
6897 * doc.c (Fdocumentation, store_function_docstring):
6898 * data.c (Finteractive_form): Handle closures.
6899
6900 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6901 interactive spec.
6902
6903 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6904 New byte-codes.
6905 (exec_byte_code): New function extracted from Fbyte_code to handle new
6906 calling convention for byte-code-functions. Add new byte-codes.
6907
6908 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6909
6910 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6911
6912 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6913
6914 * xdisp.c (redisplay_internal): Fix prototype.
6915
6916 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6917
6918 * xdisp.c (SCROLL_LIMIT): New macro.
6919 (try_scrolling): Use it when setting scroll_limit.
6920 Limit scrolling to 100 screen lines.
6921 (redisplay_window): Even when falling back on "recentering",
6922 position point in the window according to scroll-conservatively,
6923 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6924
6925 (try_scrolling): When point is above the window, allow searching
6926 as far as scroll_max, or one screenful, to compute vertical
6927 distance from PT to the scroll margin position. This prevents
6928 try_scrolling from unnecessarily failing when
6929 scroll-conservatively is set to a value slightly larger than the
6930 window height. Clean up the case of PT below the margin at bottom
6931 of window: scroll_max can no longer be INT_MAX. When aggressive
6932 scrolling is in use, don't let point enter the opposite scroll
6933 margin as result of the scroll.
6934 (syms_of_xdisp) <scroll-conservatively>: Document the
6935 threshold of 100 lines for never-recentering scrolling.
6936
6937 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6938
6939 * dispextern.h (move_it_by_lines):
6940 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6941 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6942 (message_log_check_duplicate): Remove parameters `prev_bol' and
6943 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6944 (redisplay_internal): Remove parameter `preserve_echo_area',
6945 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6946
6947 * indent.c (Fvertical_motion):
6948 * window.c (window_scroll_pixel_based, Frecenter):
6949 Don't pass `need_y_p' to `move_it_by_lines'.
6950
6951 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6952
6953 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6954 steal a few bits to be more compact.
6955 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6956 Remove unneeded casts.
6957
6958 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6959
6960 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6961
6962 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6963 binding" message (bug#7967).
6964
6965 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6966
6967 Fix more problems found by GCC 4.6.0's static checks.
6968
6969 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6970 Remove unused local var.
6971
6972 * editfns.c (Fmessage_box): Remove unused local var.
6973
6974 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6975 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6976 Omit unused local vars.
6977 * window.c (shrink_windows): Omit unused local var.
6978 * menu.c (digest_single_submenu): Omit unused local var.
6979 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6980 Omit unused local var.
6981
6982 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6983 Don't assume string length fits in int.
6984 (keyremap_step, read_key_sequence): Use size_t for sizes.
6985 (read_key_sequence): Don't check last_real_key_start redundantly.
6986
6987 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6988 instead of alloca (Bug#8344).
6989
6990 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6991 (Fbacktrace_frame): Don't assume nframes fits in int.
6992
6993 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6994
6995 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6996 concerns.
6997
6998 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6999
7000 * cm.c (calccost): Turn while-do into do-while, for clarity.
7001
7002 * keyboard.c (syms_of_keyboard): Use the same style as later
7003 in this function when indexing through an array. This also
7004 works around GCC bug 48267.
7005
7006 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7007
7008 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7009
7010 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7011 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7012
7013 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7014 This avoids undefined behavior on integer overflow, and is a bit
7015 more convenient anyway since it is compared to a size_t variable.
7016
7017 Variadic C functions now count arguments with size_t, not int.
7018 This avoids an unnecessary limitation on 64-bit machines, which
7019 caused (substring ...) to crash on large vectors (Bug#8344).
7020 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7021 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7022 All variadic functions and their callers changed accordingly.
7023 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7024 * data.c (arith_driver, float_arith_driver): Likewise.
7025 * editfns.c (general_insert_function): Likewise.
7026 * eval.c (struct backtrace.nargs, interactive_p)
7027 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7028 (funcall_lambda, mark_backtrace): Likewise.
7029 * fns.c (concat): Likewise.
7030 * frame.c (x_set_frame_parameters): Likewise.
7031 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7032 0 if not found, not -1. All callers changed.
7033
7034 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7035 (stack_copy_size): Now size_t, not int.
7036 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7037
7038 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7039
7040 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7041 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7042 All callers changed.
7043
7044 * lisp.h (multibyte_char_to_unibyte):
7045 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7046 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7047 * character.h (CHAR_TO_BYTE8):
7048 * cmds.c (internal_self_insert):
7049 * editfns.c (general_insert_function):
7050 * keymap.c (push_key_description):
7051 * search.c (Freplace_match):
7052 * xdisp.c (message_dolog, set_message_1): All callers changed.
7053
7054 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7055
7056 * keyboard.c (safe_run_hook_funcall): New function.
7057 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7058 don't set the hook to nil, but remove the offending function instead.
7059 (Qcommand_hook_internal): Remove, unused.
7060 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7061 Vcommand_hook_internal.
7062
7063 * eval.c (enum run_hooks_condition): Remove.
7064 (funcall_nil, funcall_not): New functions.
7065 (run_hook_with_args): Call each function through a `funcall' argument.
7066 Remove `cond' argument, now redundant.
7067 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7068 (Frun_hook_with_args_until_failure): Adjust accordingly.
7069 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7070
7071 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7072
7073 * dispextern.h (string_buffer_position): Remove declaration.
7074
7075 * print.c (strout): Remove parameter `multibyte', unused since
7076 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7077
7078 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7079 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7080 All callers changed.
7081
7082 * w32.c (_wsa_errlist): Use braces for struct initializers.
7083
7084 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7085 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7086 All callers changed.
7087 (string_buffer_position): Likewise. Also, make static (it's never
7088 used outside xdisp.c).
7089 (cursor_row_p): Remove parameter `w', unused since
7090 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7091 (decode_mode_spec): Remove parameter `precision', introduced during
7092 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7093 All callers changed.
7094
7095 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7096
7097 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7098
7099 2011-03-27 Anders Lindgren <andlind@gmail.com>
7100
7101 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7102 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7103 (ns_update_auto_hide_menu_bar): New functions.
7104 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7105 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7106 ns_constrain_all_frames.
7107 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7108 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7109
7110 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7111
7112 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7113
7114 2011-03-27 Glenn Morris <rgm@gnu.org>
7115
7116 * syssignal.h: Replace RETSIGTYPE with void.
7117 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7118 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7119 Replace SIGTYPE with void everywhere.
7120 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7121 * s/template.h (SIGTYPE): Remove commented out definition.
7122
7123 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7124
7125 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7126 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7127
7128 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7129
7130 * w32.c (read_unc_volume): Use parameter `henum', instead of
7131 global variable `wget_enum_handle'.
7132
7133 * keymap.c (describe_vector): Remove parameters `indices' and
7134 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7135 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7136
7137 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7138
7139 * keyboard.c (timer_check): Remove parameter `do_it_now',
7140 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7141 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7142 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7143
7144 * keyboard.c (read_char):
7145 * w32menu.c (w32_menu_display_help):
7146 * xmenu.c (show_help_event, menu_help_callback):
7147 Adjust calls to `show_help_echo'.
7148
7149 * gtkutil.c (xg_maybe_add_timer):
7150 * keyboard.c (readable_events):
7151 * process.c (wait_reading_process_output):
7152 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7153
7154 * insdel.c (adjust_markers_gap_motion):
7155 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7156 (gap_left, gap_right): Don't call it.
7157
7158 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7159
7160 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7161 incurred during fontification.
7162
7163 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7164
7165 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7166 (DEFVAR_PER_BUFFER): Don't pass it.
7167
7168 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7169 (scrolling_window): Don't pass it.
7170
7171 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7172
7173 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7174
7175 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7176 and `suffix'.
7177 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7178 of variables specific to SELinux and computation of `encoded_absname'.
7179
7180 * image.c (XPutPixel): Remove unused variable `height'.
7181
7182 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7183
7184 * unexw32.c (get_section_info): Remove unused variable `section'.
7185
7186 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7187 (system_process_attributes): Remove unused variable `sess'.
7188 (sys_read): Remove unused variable `err'.
7189
7190 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7191 (w32_wnd_proc): Remove unused variable `isdead'.
7192 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7193 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7194 (x_create_tip_frame): Remove unused variable `tem'.
7195
7196 * w32inevt.c (w32_console_read_socket):
7197 Remove unused variable `no_events'.
7198
7199 * w32term.c (x_draw_composite_glyph_string_foreground):
7200 Remove unused variable `width'.
7201
7202 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7203
7204 * w32term.c (x_set_glyph_string_clipping):
7205 Don't pass uninitialized region to CombineRgn.
7206
7207 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7208
7209 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7210 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7211 (Fx_close_connection): Remove unused variable `i'.
7212
7213 * w32font.c (w32font_draw): Return number of glyphs.
7214 (w32font_open_internal): Remove unused variable `i'.
7215 (w32font_driver): Add missing initializer.
7216
7217 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7218 (fill_in_menu): Remove unused variable `items_added'.
7219
7220 * w32term.c (last_mouse_press_frame): Remove static global variable.
7221 (w32_clip_to_row): Remove unused variable `f'.
7222 (x_delete_terminal): Remove unused variable `i'.
7223
7224 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7225 (NOTHING): Remove unused static global variable.
7226 (uniscribe_check_otf): Remove unused variable `table'.
7227 (uniscribe_font_driver): Add missing initializers.
7228
7229 2011-03-23 Julien Danjou <julien@danjou.info>
7230
7231 * term.c (Fsuspend_tty, Fresume_tty):
7232 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7233 * window.c (temp_output_buffer_show):
7234 * insdel.c (signal_before_change):
7235 * frame.c (Fhandle_switch_frame):
7236 * fileio.c (Fdo_auto_save):
7237 * emacs.c (Fkill_emacs):
7238 * editfns.c (save_excursion_restore):
7239 * cmds.c (internal_self_insert):
7240 * callint.c (Fcall_interactively):
7241 * buffer.c (Fkill_all_local_variables):
7242 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7243 Use Frun_hooks.
7244 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7245 unconditionnaly since it does the check itself.
7246
7247 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7248
7249 Fix more problems found by GCC 4.5.2's static checks.
7250
7251 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7252 the first time through the loop, since we know p0 < p1 then.
7253 This also avoids a gcc -Wstrict-overflow warning.
7254
7255 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7256 leading to a memory leak, possible in functions like
7257 load_charset_map_from_file that can allocate an unbounded number
7258 of objects (Bug#8318).
7259
7260 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7261 that could (at least in theory) be that large.
7262
7263 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7264 This is less likely to overflow, and avoids undefined behavior if
7265 overflow does occur. All callers changed. Use strtoul to scan
7266 for the unsigned long integer.
7267 (pint2hrstr): Simplify and tune code slightly.
7268 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7269
7270 * scroll.c (do_scrolling): Work around GCC bug 48228.
7271 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7272
7273 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7274 This also avoids a warning with gcc -Wstrict-overflow.
7275 (validate_x_resource_name): Simplify count usage.
7276 This also avoids a warning with gcc -Wstrict-overflow.
7277
7278 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7279 fail (Bug#8306).
7280
7281 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7282
7283 * process.c (Fmake_network_process): Use socklen_t, not int,
7284 where POSIX says socklen_t is required in portable programs.
7285 This fixes a porting bug on hosts like 64-bit HP-UX, where
7286 socklen_t is wider than int (Bug#8277).
7287 (Fmake_network_process, server_accept_connection):
7288 (wait_reading_process_output, read_process_output):
7289 Likewise.
7290
7291 * process.c: Rename or move locals to avoid shadowing.
7292 (list_processes_1, Fmake_network_process):
7293 (read_process_output_error_handler, exec_sentinel_error_handler):
7294 Rename or move locals.
7295 (Fmake_network_process): Define label "retry_connect" only if needed.
7296 (Fnetwork_interface_info): Fix pointer signedness.
7297 (process_send_signal): Add cast to avoid pointer signedness problem.
7298 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7299 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7300
7301 Make tparam.h and terminfo.c consistent.
7302 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7303 Include tparam.h instead, since it declares them.
7304 * cm.h (PC): Remove extern decl; tparam.h now does this.
7305 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7306 * terminfo.c: Include tparam.h, to check interfaces.
7307 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7308 (tparam): Adjust signature to match interface in tparam.h;
7309 this removes some undefined behavior. Check that outstring and len
7310 are zero, which they always are with Emacs.
7311 * tparam.h (PC, BC, UP): New extern decls.
7312
7313 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7314 (xftfont_open): Rename locals to avoid shadowing.
7315
7316 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7317 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7318 (OTF_TAG_SYM): Omit macro if not needed.
7319 (ftfont_list): Remove unused local.
7320 (get_adstyle_property, ftfont_pattern_entity):
7321 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7322 Rename locals to avoid shadowing.
7323
7324 * xfont.c (xfont_list_family): Mark var as initialized.
7325
7326 * xml.c (make_dom): Now static.
7327
7328 * composite.c (composition_compute_stop_pos): Rename local to
7329 avoid shadowing.
7330 (composition_reseat_it): Remove unused locals.
7331 (find_automatic_composition, composition_adjust_point): Likewise.
7332 (composition_update_it): Mark var as initialized.
7333 (find_automatic_composition): Mark vars as initialized,
7334 with a FIXME (Bug#8290).
7335
7336 character.h: Rename locals to avoid shadowing.
7337 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7338 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7339 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7340 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7341 to avoid shadowing.
7342
7343 * textprop.c (property_change_between_p): Remove; unused.
7344
7345 * intervals.c (interval_start_pos): Now static.
7346
7347 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7348
7349 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7350 Rename locals to avoid shadowing.
7351
7352 * sound.c (wav_play, au_play, Fplay_sound_internal):
7353 Fix pointer signedness.
7354 (alsa_choose_format): Remove unused local var.
7355 (wav_play): Initialize a variable to 0, to prevent undefined
7356 behavior (Bug#8278).
7357
7358 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7359
7360 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7361
7362 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7363 clobbering (Bug#8298).
7364 * sysdep.c (sys_subshell): Likewise.
7365 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7366
7367 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7368 This should get cleaned up, so that child_setup has the
7369 same signature on all platforms.
7370
7371 * callproc.c (call_process_cleanup): Now static.
7372 (relocate_fd): Rename locals to avoid shadowing.
7373
7374 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7375
7376 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7377 not to be necessary, and produces flickering.
7378
7379 2011-03-20 Glenn Morris <rgm@gnu.org>
7380
7381 * config.in: Remove file.
7382
7383 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7384
7385 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7386 are now in src/globals.h.
7387 (syms_of_minibuf): Remove spurious & from previous change.
7388
7389 2011-03-20 Leo <sdl.web@gmail.com>
7390
7391 * minibuf.c (completing-read-function): New variable.
7392 (completing-read-default): Rename from completing-read.
7393 (completing-read): Call completing-read-function.
7394
7395 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7396
7397 * xfaces.c (Fx_load_color_file):
7398 Read color file from absolute filename (bug#8250).
7399
7400 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7401
7402 * makefile.w32-in: Update dependencies.
7403
7404 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7405
7406 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7407
7408 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7409
7410 Fix more problems found by GCC 4.5.2's static checks.
7411
7412 * process.c (make_serial_process_unwind, send_process_trap):
7413 (sigchld_handler): Now static.
7414
7415 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7416 That way, the code declares only the vars that it needs.
7417 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7418 * s/cygwin.h (PTY_ITERATION): Likewise.
7419 * s/darwin.h (PTY_ITERATION): Likewise.
7420 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7421
7422 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7423 * process.c (allocate_pty): Don't declare stb unless it's needed.
7424
7425 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7426 (CONSTANTLIM): Remove; unused.
7427 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7428 Define only if needed.
7429
7430 * unexelf.c (unexec): Name an expression,
7431 to avoid gcc -Wbad-function-cast warning.
7432 Use a different way to cause a compilation error if anyone uses
7433 n rather than nn, a way that does not involve shadowing.
7434 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7435
7436 * deps.mk (unexalpha.o): Remove; unused.
7437
7438 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7439 * unexec.h: New file.
7440 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7441 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7442 Depend on unexec.h.
7443 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7444 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7445 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7446 Change as necessary to match prototype in unexec.h.
7447
7448 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7449 shadowing.
7450 (back_comment, skip_chars): Mark vars as initialized.
7451
7452 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7453 Rename locals to avoid shadowing.
7454
7455 * lread.c (read1): Rewrite so as not to use empty "else".
7456 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7457
7458 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7459
7460 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7461 warning when compiling print.c.
7462
7463 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7464 instead of using an uninitialized var.
7465 (font_sort_entities): Mark var as initialized.
7466
7467 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7468
7469 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7470 pointers to constants.
7471 (font_parse_fcname): Remove unused vars.
7472 (font_delete_unmatched): Now static.
7473 (font_get_spec): Remove; unused.
7474 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7475 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7476 Rename or move locals to avoid shadowing.
7477
7478 * fns.c (require_nesting_list, require_unwind): Now static.
7479 (Ffillarray): Rename locals to avoid shadowing.
7480
7481 * floatfns.c (domain_error2): Define only if needed.
7482 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7483
7484 * alloc.c (mark_backtrace): Move decl from here ...
7485 * lisp.h: ... to here, so that it can be checked.
7486
7487 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7488 (Fdefvar): Rewrite so as not to use empty "else".
7489 (lisp_indirect_variable): Name an expression,
7490 to avoid gcc -Wbad-function-cast warning.
7491 (Fdefvar): Rename locals to avoid shadowing.
7492
7493 * callint.c (quotify_arg, quotify_args): Now static.
7494 (Fcall_interactively): Rename locals to avoid shadowing.
7495 Use const pointer when appropriate.
7496
7497 * lisp.h (get_system_name, get_operating_system_release):
7498 Move decls here, to check interfaces.
7499 * process.c (get_operating_system_release): Move decl to lisp.h.
7500 * xrdb.c (get_system_name): Likewise.
7501 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7502 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7503 some of which prompt warnings from gcc -Wbad-function-cast.
7504 (Fformat_time_string, Fencode_time, Finsert_char):
7505 (Ftranslate_region_internal, Fformat):
7506 Rename or remove local vars to avoid shadowing.
7507 (Ftranslate_region_internal): Mark var as initialized.
7508
7509 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7510 avoid shadowing.
7511
7512 * lisp.h (eassert): Check that the argument compiles, even if
7513 ENABLE_CHECKING is not defined.
7514
7515 * data.c (Findirect_variable): Name an expression, to avoid
7516 gcc -Wbad-function-cast warning.
7517 (default_value, arithcompare, arith_driver, arith_error): Now static.
7518 (store_symval_forwarding): Rename local to avoid shadowing.
7519 (Fmake_variable_buffer_local, Fmake_local_variable):
7520 Mark variables as initialized.
7521 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7522
7523 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7524 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7525 Rename locals to avoid shadowing.
7526 (mark_stack): Move local variables into the #ifdef region where
7527 they're used.
7528 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7529 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7530 needed otherwise.
7531 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7532 (GC_STRING_CHARS): Remove; not used.
7533 (Fmemory_limit): Cast sbrk's returned value to char *.
7534
7535 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7536 avoids undefined behavior in theory.
7537
7538 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7539
7540 Use functions, not macros, for up- and down-casing (Bug#8254).
7541 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7542 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7543 to use the following functions instead of these macros.
7544 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7545 EMACS_INT, since callers assume the returned value fits in int.
7546 (upcase1): Likewise, for UPCASE_TABLE.
7547 (uppercasep, lowercasep, upcase): New static inline functions.
7548 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7549 the race-condition problem in the old DOWNCASE.
7550
7551 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7552 Rename locals to avoid shadowing.
7553 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7554 (regex_compile, re_search_2, re_match_2_internal):
7555 Remove unused local vars.
7556 (FREE_VAR): Rewrite so as not to use empty "else",
7557 which gcc can warn about.
7558 (regex_compile, re_match_2_internal): Mark locals as initialized.
7559 (RETALLOC_IF): Define only if needed.
7560 (WORDCHAR_P): Likewise. This one is never needed, but is used
7561 only in a comment talking about a compiler bug, so put inside
7562 the #if 0 of that comment.
7563 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7564 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7565 Remove; unused.
7566
7567 * search.c (boyer_moore): Rename locals to avoid shadowing.
7568 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7569 (PREV_CHAR_BOUNDARY): Likewise.
7570
7571 * search.c (simple_search): Remove unused var.
7572
7573 * dired.c (compile_pattern): Move decl from here ...
7574 * lisp.h: ... to here, so that it can be checked.
7575 (struct re_registers): New forward decl.
7576
7577 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7578
7579 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7580 All uses changed.
7581 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7582 Rename locals to avoid shadowing.
7583 (Fvertical_motion): Mark locals as initialized.
7584
7585 * casefiddle.c (casify_object, casify_region): Now static.
7586 (casify_region): Mark local as initialized.
7587
7588 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7589
7590 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7591 New macros, so that the caller can use some names other than
7592 gcpro1, gcpro2, etc.
7593 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7594 of the new macros.
7595 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7596 argument, for consistency with GCPRO2_VAR, etc: it is now the
7597 prefix of the variable, not the variable itself. All uses
7598 changed.
7599 * dired.c (directory_files_internal, file_name_completion):
7600 Rename locals to avoid shadowing.
7601
7602 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7603 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7604 dired.c's scmp function, had undefined behavior.
7605 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7606 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7607 * buffer.h: ... to here, because these macros use current_buffer,
7608 and the new implementation with inline functions needs to have
7609 current_buffer in scope now, rather than later when the macros
7610 are used.
7611 (downcase, upcase1): New static inline functions.
7612 (DOWNCASE, UPCASE1): Reimplement using these functions.
7613 This avoids undefined behavior in expressions like
7614 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7615 from race conditions in accessing the global variables
7616 case_temp1 and case_temp2.
7617 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7618 * lisp.h (case_temp1, case_temp2): Remove their decls.
7619 * character.h (ASCII_CHAR_P): Move from here ...
7620 * lisp.h: ... to here, so that the inline functions mentioned
7621 above can use them.
7622
7623 * dired.c (directory_files_internal_unwind): Now static.
7624
7625 * fileio.c (file_name_as_directory, directory_file_name):
7626 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7627 Now static.
7628 (file_name_as_directory): Use const pointers when appropriate.
7629 (Fexpand_file_name): Likewise. In particular, newdir might
7630 point at constant storage, so make it a const pointer.
7631 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7632 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7633 signedness issues.
7634 (Fset_file_times, Finsert_file_contents, auto_save_error):
7635 Rename locals to avoid shadowing.
7636
7637 * minibuf.c (choose_minibuf_frame_1): Now static.
7638 (Ftry_completion, Fall_completions): Rename or remove locals
7639 to avoid shadowing.
7640
7641 * marker.c (bytepos_to_charpos): Remove; unused.
7642
7643 * lisp.h (verify_bytepos, count_markers): New decls,
7644 so that gcc does not warn that these functions aren't declared.
7645
7646 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7647 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7648 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7649 (copy_text): Remove unused local var.
7650
7651 * filelock.c (within_one_second): Now static.
7652 (lock_file_1): Rename local to avoid shadowing.
7653
7654 * buffer.c (fix_overlays_before): Mark locals as initialized.
7655 (fix_start_end_in_overlays): Likewise. This function should be
7656 simplified by using pointers-to-pointers, but that's a different
7657 matter.
7658 (switch_to_buffer_1): Now static.
7659 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7660 (report_overlay_modification): Rename locals to avoid shadowing.
7661
7662 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7663 Fix pointer signedness issue.
7664 (sys_subshell): Mark local as volatile if checking for lint,
7665 to suppress a gcc -Wclobbered warning that does not seem to be right.
7666 (MAXPATHLEN): Define only if needed.
7667
7668 * process.c (serial_open, serial_configure): Move decls from here ...
7669 * systty.h: ... to here, so that they can be checked.
7670
7671 * fns.c (get_random, seed_random): Move extern decls from here ...
7672 * lisp.h: ... to here, so that they can be checked.
7673
7674 * sysdep.c (reset_io): Now static.
7675 (wait_for_termination_signal): Remove; unused.
7676
7677 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7678 (copy_keymap_item, append_key, push_text_char_description):
7679 Now static.
7680 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7681 (DENSE_TABLE_SIZE): Remove; unused.
7682 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7683 (describe_map_tree):
7684 Rename locals to avoid shadowing.
7685
7686 * keyboard.c: Declare functions static if they are not used elsewhere.
7687 (echo_char, echo_dash, cmd_error, top_level_2):
7688 (poll_for_input, handle_async_input): Now static.
7689 (read_char, kbd_buffer_get_event, make_lispy_position):
7690 (make_lispy_event, make_lispy_movement, apply_modifiers):
7691 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7692 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7693 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7694 (read_key_sequence, read_char): Mark locals as initialized.
7695 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7696
7697 * keyboard.h (make_ctrl_char): New decl.
7698 (mark_kboards): Move decl here ...
7699 * alloc.c (mark_kboards): ... from here.
7700
7701 * lisp.h (force_auto_save_soon): New decl.
7702
7703 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7704 (DEFINE_DUMMY_FUNCTION): New macro.
7705 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7706 Use it.
7707 (main): Add casts to avoid warnings
7708 if GCC considers string literals to be constants.
7709
7710 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7711
7712 * dbusbind.c: Pointer signedness fixes.
7713 (xd_signature, xd_append_arg, xd_initialize):
7714 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7715 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7716 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7717 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7718
7719 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7720 if GCC considers string literals to be constants.
7721 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7722
7723 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7724
7725 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7726 (print_preprocess, print_object): New macro to fix last change.
7727
7728 * print.c (print_preprocess): Don't forget font objects.
7729
7730 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7731
7732 * emacs.c (USAGE3): Doc fixes.
7733
7734 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7735
7736 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7737 structure.
7738
7739 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7740
7741 * lisp.h (VWindow_system, Qfile_name_history):
7742 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7743 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7744 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7745
7746 * w32select.c: Don't #include "keyboard.h".
7747 (run_protected): Add extern declaration for waiting_for_input.
7748
7749 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7750 * w32console.c (detect_input_pending, read_input_pending)
7751 (encode_terminal_code):
7752 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7753 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7754 (w32_system_caret_y, Qfile_name_history):
7755 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7756 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7757 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7758 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7759 * w32proc.c (Qlocal, report_file_error):
7760 * w32term.c (Vwindow_system, updating_frame):
7761 * w32uniscribe.c (initialized, uniscribe_font_driver):
7762 Remove unneeded extern declarations.
7763
7764 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7765
7766 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7767
7768 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7769
7770 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7771 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7772 These macros can no longer be used for assignment.
7773
7774 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7775 Assign struct members directly, instead of using BUF_BEGV etc.
7776 (record_buffer_markers, fetch_buffer_markers): New functions for
7777 recording and fetching special buffer markers.
7778 (set_buffer_internal_1, set_buffer_temp): Use them.
7779
7780 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7781
7782 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7783
7784 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7785 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7786
7787 * xdisp.c (hscroll_window_tree):
7788 (reconsider_clip_changes): Use PT instead of BUF_PT.
7789
7790 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7791
7792 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7793 $(EMACS_ROOT)/lib/intprops.h.
7794
7795 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7796
7797 Fix more problems found by GCC 4.5.2's static checks.
7798
7799 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7800 to unsigned char * to avoid compiler diagnostic.
7801 (xg_free_frame_widgets): Make it clear that a local variable is
7802 needed only if USE_GTK_TOOLTIP.
7803 (gdk_window_get_screen): Make it clear that this macro is needed
7804 only if USE_GTK_TOOLTIP.
7805 (int_gtk_range_get_value): New function, which avoids a diagnostic
7806 from gcc -Wbad-function-cast.
7807 (xg_set_toolkit_scroll_bar_thumb): Use it.
7808 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7809 diagnostic from gcc -Wbad-function-cast.
7810 (get_utf8_string, xg_get_file_with_chooser):
7811 Rename locals to avoid shadowing.
7812 (create_dialog): Move locals to avoid shadowing.
7813
7814 * xgselect.c (xg_select): Remove unused var.
7815
7816 * image.c (four_corners_best): Mark locals as initialized.
7817 (gif_load): Initialize transparent_p to zero (Bug#8238).
7818 Mark another local as initialized.
7819 (my_png_error, my_error_exit): Mark with NO_RETURN.
7820
7821 * image.c (clear_image_cache): Now static.
7822 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7823 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7824 (x_edge_detection): Remove unnecessary cast that
7825 gcc -Wbad-function-cast diagnoses.
7826 (gif_load): Fix pointer signedness.
7827 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7828 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7829
7830 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7831
7832 Improve quality of tests for time stamp overflow.
7833 For example, without this patch (encode-time 0 0 0 1 1
7834 1152921504606846976) returns the obviously-bogus value (-948597
7835 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7836 reports time overflow. See
7837 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7838 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7839 * editfns.c: Include limits.h and intprops.h.
7840 (TIME_T_MIN, TIME_T_MAX): New macros.
7841 (time_overflow): Move earlier, to before first use.
7842 (hi_time, lo_time): New functions, for an accurate test for
7843 out-of-range times.
7844 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7845 (Fget_internal_run_time): Don't assume time_t fits in int.
7846 (make_time): Use list2 instead of Fcons twice.
7847 (Fdecode_time): More accurate test for out-of-range times.
7848 (check_tm_member): New function.
7849 (Fencode_time): Use it, to test for out-of-range times.
7850 (lisp_time_argument): Don't rely on undefined left-shift and
7851 right-shift behavior when checking for time stamp overflow.
7852
7853 * editfns.c (time_overflow): New function, refactoring common code.
7854 (Fformat_time_string, Fdecode_time, Fencode_time):
7855 (Fcurrent_time_string): Use it.
7856
7857 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7858 * dired.c (make_time): Move to ...
7859 * editfns.c (make_time): ... here.
7860 * systime.h: Note the move.
7861
7862 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7863
7864 * fringe.c (update_window_fringes): Remove unused variables.
7865
7866 * unexmacosx.c (copy_data_segment): Also copy __got section.
7867 (Bug#8223)
7868
7869 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7870
7871 * termcap.c [MSDOS]: Include "msdos.h".
7872 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7873 Constify `char *' arguments and their references according to
7874 prototypes in tparam.h.
7875
7876 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7877
7878 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7879 Adapt all references accordingly.
7880
7881 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7882
7883 2011-03-11 Tom Tromey <tromey@redhat.com>
7884
7885 * buffer.c (syms_of_buffer): Remove obsolete comment.
7886
7887 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7888
7889 * termhooks.h (encode_terminal_code): Declare prototype.
7890
7891 * msdos.c (encode_terminal_code): Don't declare prototype.
7892
7893 * term.c (encode_terminal_code): Now external again, used by
7894 w32console.c and msdos.c.
7895
7896 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7897 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7898
7899 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7900
7901 Fix some minor problems found by GCC 4.5.2's static checks.
7902
7903 * fringe.c (update_window_fringes): Mark locals as initialized
7904 (Bug#8227).
7905 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7906
7907 * alloc.c (mark_fringe_data): Move decl from here ...
7908 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7909 to check its interface.
7910 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7911
7912 * fontset.c (free_realized_fontset): Now static.
7913 (Fset_fontset_font): Rename local to avoid shadowing.
7914 (fontset_font): Mark local as initialized.
7915 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7916
7917 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7918
7919 * xselect.c (x_disown_buffer_selections): Remove; not used.
7920 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7921 (x_own_selection, Fx_disown_selection_internal): Rename locals
7922 to avoid shadowing.
7923 (x_handle_dnd_message): Remove local to avoid shadowing.
7924
7925 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7926 so that the caller can use some name other than gcpro1.
7927 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7928 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7929 (Fx_backspace_delete_keys_p):
7930 Use them to avoid shadowing, and rename vars to avoid shadowing.
7931 (x_decode_color, x_set_name, x_window): Now static.
7932 (Fx_create_frame): Add braces to silence GCC warning.
7933 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7934 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7935 Remove unused locals.
7936 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7937 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7938 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7939 macros.
7940
7941 * xterm.h (x_mouse_leave): New decl.
7942
7943 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7944 Remove unused functions.
7945 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7946 (x_calc_absolute_position): Now static.
7947 (XTread_socket): Don't define label "out" unless it's used.
7948 Don't declare local "event" unless it's used.
7949 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7950 unless they are used.
7951 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7952 (x_fatal_error_signal): Remove; not used.
7953 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7954 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7955 (x_error_catcher, x_connection_closed, x_error_handler):
7956 (x_error_quitter, xembed_send_message, x_iconify_frame):
7957 (my_log_handler): Rename locals to avoid shadowing.
7958 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7959 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7960
7961 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7962 Rename or move locals to avoid shadowing.
7963 (tty_defined_color, merge_face_heights): Now static.
7964 (free_realized_faces_for_fontset): Remove; not used.
7965 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7966 does not deduce is never used uninitialized.
7967 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7968 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7969
7970 * terminal.c (store_terminal_param): Now static.
7971
7972 * xmenu.c (menu_highlight_callback): Now static.
7973 (set_frame_menubar): Remove unused local.
7974 (xmenu_show): Rename parameter to avoid shadowing.
7975 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7976 since they might point to immutable storage.
7977 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7978 since it's unused otherwise.
7979
7980 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7981 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7982 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7983 avoids a gcc -Wuninitialized diagnostic.
7984 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7985 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7986 does not deduce are never used uninitialized.
7987
7988 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7989
7990 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7991 * window.c (window_loop, size_window):
7992 (run_window_configuration_change_hook, enlarge_window): Likewise.
7993
7994 * window.c (display_buffer): Now static.
7995 (size_window): Mark variables that gcc -Wuninitialized
7996 does not deduce are never used uninitialized.
7997 * window.h (check_all_windows): New decl, to forestall
7998 gcc -Wmissing-prototypes diagnostic.
7999 * dispextern.h (bidi_dump_cached_states): Likewise.
8000
8001 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8002 shadowing.
8003 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8004 Include <limits.h>.
8005 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8006 and to avoid gcc -Wuninitialized warning.
8007 (load_charset_map): Mark variables that gcc -Wuninitialized
8008 does not deduce are never used uninitialized.
8009 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8010
8011 * coding.c (coding_set_source, coding_set_destination):
8012 Use "else { /* comment */ }" rather than "else /* comment */;"
8013 for clarity, and to avoid gcc -Wempty-body warning.
8014 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8015 a block, when the outer 'i' will do.
8016 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8017 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8018 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8019 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8020 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8021 Rename locals to avoid shadowing.
8022 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8023 * coding.c (emacs_mule_char, encode_invocation_designation):
8024 Now static, since they're not used elsewhere.
8025 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8026 (decode_coding_object, encode_coding_object, detect_coding_system):
8027 (decode_coding_emacs_mule): Mark variables that gcc
8028 -Wuninitialized does not deduce are never used uninitialized.
8029 (detect_coding_iso_2022): Initialize a local variable that might
8030 be used uninitialized. Leave a FIXME because it's not clear that
8031 this initialization is needed. (Bug#8211)
8032 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8033 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8034 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8035 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8036 Remove unused macros.
8037
8038 * category.c (hash_get_category_set): Remove unused local var.
8039 (copy_category_table): Now static, since it's not used elsewhere.
8040 * character.c (string_count_byte8): Likewise.
8041
8042 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8043 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8044
8045 * chartab.c (copy_sub_char_table): Now static, since it's not used
8046 elsewhere.
8047 (sub_char_table_ref_and_range, char_table_ref_and_range):
8048 Rename locals to avoid shadowing.
8049 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8050
8051 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8052 (BIDI_BOB): Remove unused macro.
8053
8054 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8055 deduce are never used uninitialized.
8056 * term.c (encode_terminal_code): Likewise.
8057
8058 * term.c (encode_terminal_code): Now static. Remove unused local.
8059
8060 * tparam.h: New file.
8061 * term.c, tparam.h: Include it.
8062 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8063 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8064 Move these decls to tparam.h, and make them agree with what
8065 is actually in tparam.c. The previous trick of using incompatible
8066 decls in different modules does not conform to the C standard.
8067 All callers of tparam changed to use tparam's actual API.
8068 * tparam.c (tparam1, tparam, tgoto):
8069 Use const pointers where appropriate.
8070
8071 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8072 * cm.h (struct cm): Likewise.
8073 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8074 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8075 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8076 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8077 (turn_on_face, init_tty): Likewise.
8078 * termchar.h (struct tty_display_info): Likewise.
8079
8080 * term.c (term_mouse_position): Rename local to avoid shadowing.
8081
8082 * alloc.c (mark_ttys): Move decl from here ...
8083 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8084
8085 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8086
8087 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8088
8089 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8090
8091 * search.c (compile_pattern_1): Remove argument regp, unused since
8092 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8093 (compile_pattern): Don't pass it.
8094
8095 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8096
8097 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8098 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8099 for ! HAVE_GTK3.
8100 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8101
8102 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8103
8104 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8105 gdk_window_get_screen, gdk_window_get_geometry,
8106 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8107 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8108 (xg_get_pixbuf_from_pixmap): New function.
8109 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8110 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8111 Call xg_get_pixbuf_from_pixmap instead of
8112 gdk_pixbuf_get_from_drawable.
8113 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8114 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8115 (xg_check_special_colors): Use GtkStyleContext and its functions
8116 for HAVE_GTK3.
8117 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8118 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8119 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8120 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8121 Call gtk_widget_get_preferred_size.
8122 (xg_frame_resized): gdk_window_get_geometry only takes 5
8123 parameters.
8124 (xg_win_to_widget, xg_event_is_for_menubar):
8125 Call gdk_x11_window_lookup_for_display.
8126 (xg_set_widget_bg): New function.
8127 (delete_cb): New function.
8128 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8129 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8130 (xg_set_background_color): Call xg_set_widget_bg.
8131 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8132 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8133 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8134 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8135 if ! HAVE_GTK3.
8136 (update_frame_tool_bar): Call gtk_widget_hide.
8137 (xg_initialize): Use GDK_KEY_g.
8138
8139 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8140 if ! HAVE_GTK3
8141 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8142
8143 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8144 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8145 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8146
8147 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8148
8149 * w32xfns.c (select_palette): Check success of RealizePalette against
8150 GDI_ERROR, not zero.
8151
8152 See ChangeLog.11 for earlier changes.
8153
8154 ;; Local Variables:
8155 ;; coding: utf-8
8156 ;; End:
8157
8158 Copyright (C) 2011 Free Software Foundation, Inc.
8159
8160 This file is part of GNU Emacs.
8161
8162 GNU Emacs is free software: you can redistribute it and/or modify
8163 it under the terms of the GNU General Public License as published by
8164 the Free Software Foundation, either version 3 of the License, or
8165 (at your option) any later version.
8166
8167 GNU Emacs is distributed in the hope that it will be useful,
8168 but WITHOUT ANY WARRANTY; without even the implied warranty of
8169 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8170 GNU General Public License for more details.
8171
8172 You should have received a copy of the GNU General Public License
8173 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.