]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
[gnu-emacs] / src / ChangeLog
1 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
41
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
51
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
54
55 * frame.c (tty_frame_count): Now printmax_t, not int.
56 (make_terminal_frame, set_term_frame_name): Print it.
57 (x_report_frame_params): In X, window IDs are unsigned long,
58 not signed long, so print them as unsigned.
59 (validate_x_resource_name): Check for implausibly long names,
60 and don't assume name length fits in 'int'.
61 (x_get_resource_string): Don't blindly alloca invocation name;
62 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
63 not fit in int.
64
65 * gtkutil.c (xg_check_special_colors, xg_set_geometry):
66 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
67
68 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
69 Use esprintf, not sprintf, in case result does not fit in int.
70
71 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
72 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
73 it as a large positive number.
74 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
75 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
76
77 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
78 in case result does not fit in int.
79
80 * print.c (float_to_string): Detect width overflow more reliably.
81 (print_object): Make sprintf buffer a bit bigger, to avoid potential
82 buffer overrun. Don't assume list length fits in 'int'. Treat
83 print length of 0 as 0, not as infinity; to be consistent with other
84 uses of print length in this function. Don't overflow print length
85 index. Don't assume hash table size fits in 'long', or that
86 vectorlike size fits in 'unsigned long'.
87
88 * process.c (make_process): Use printmax_t, not int, to format
89 process-name gensyms.
90
91 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
92 to avoid potential buffer overrun.
93
94 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
95 if X resource line is longer than 512 bytes.
96
97 * xfns.c (x_window): Make sprintf buffer a bit bigger
98 to avoid potential buffer overrun.
99
100 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
101
102 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
103
104 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
105
106 Integer and memory overflow issues (Bug#9196).
107
108 * doc.c (get_doc_string): Rework so that
109 get_doc_string_buffer_size is the actual buffer size, rather than
110 being 1 less than the actual buffer size; this makes xpalloc more
111 convenient.
112
113 * image.c (x_allocate_bitmap_record, cache_image):
114 * xselect.c (Fx_register_dnd_atom):
115 Simplify previous changes by using xpalloc.
116
117 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
118 since either will do and ptrdiff_t is convenient with xpalloc.
119
120 * charset.c (charset_table_size)
121 (struct charset_sort_data.priority): Now ptrdiff_t.
122 (charset_compare): Don't overflow if priorities differ greatly.
123 (Fsort_charsets): Don't assume list length fits in int.
124 Check for size-calculation overflow when allocating sort data.
125 (syms_of_charset): Allocate an initial charset table that is
126 just under 64 KiB, to avoid problems with glibc malloc and mmap.
127
128 * cmds.c (internal_self_insert): Check for size-calculation overflow.
129
130 * composite.h (struct composition.glyph_len): Now int, not unsigned.
131 The actual value is always <= INT_MAX, and leaving it unsigned made
132 overflow checking harder.
133
134 * dispextern.h (struct glyph_matrix.rows_allocated)
135 (struct face_cache.size): Now ptrdiff_t, for convenience in use
136 with xpalloc. The values are still always <= INT_MAX.
137
138 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
139
140 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
141 (SAFE_NALLOCA): New macro.
142
143 * region-cache.c (struct boundary.pos, find_cache_boundary)
144 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
145 (set_cache_region, invalidate_region_cache)
146 (revalidate_region_cache, know_region_cache, region_cache_forward)
147 (region_cache_backward, pp_cache):
148 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
149 so that ptrdiff_t * can be passed to xpalloc.
150 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
151 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
152 (pp_cache): Don't assume cache_len fits in int.
153 * region-cache.h: Adjust extern decls to match.
154
155 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
156 EMACS_INT, since either will do, for xpalloc.
157
158 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
159 (xnmalloc, xnrealloc, xpalloc): New functions.
160
161 * bidi.c (bidi_shelve_header_size): New constant.
162 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
163 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
164
165 * bidi.c (bidi_cache_shrink):
166 * buffer.c (overlays_at, overlays_in, record_overlay_string)
167 (overlay_strings):
168 Don't update size of array until after memory allocation succeeds,
169 because xmalloc/xrealloc may not return.
170 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
171 now that we have proper integer overflow checking.
172 (record_overlay_string, overlay_strings): Catch overflows when
173 calculating size of overlay_str_buf.
174
175 * callproc.c (Fcall_process): Check for size overflow when
176 calculating size of args2.
177 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
178 Normally we prefer signed values, but sticking with ptrdiff_t would
179 require adding more-complicated checks.
180
181 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
182 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
183 Redo buffer-overflow calculations to avoid integer overflow.
184 Add a FIXME comment where memory seems to be over-allocated.
185
186 * character.c (Fstring): Check for size-calculation overflow.
187
188 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
189 unnecessary integer overflow. Check for size overflow.
190 (encode_coding_object): Don't update size until xmalloc succeeds.
191
192 * composite.c (get_composition_id): Check for overflow in glyph
193 length calculations.
194
195 Integer and memory overflow fixes for display code.
196 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
197 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
198 (scrolling_window): Check for overflow in size calculations.
199 (line_draw_cost, realloc_glyph_pool, add_row_entry):
200 Don't assume glyph table len fits in int.
201 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
202 (row_table_size): Now ptrdiff_t, not int.
203 (scrolling_window): Avoid overflow in size calculations.
204 Don't update size until allocation succeeds.
205 * fns.c (concat): Check for overflow in size calculations.
206 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
207 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
208 (NEXT_ALMOST_PRIME_LIMIT): New constant.
209
210 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
211 (get_doc_string): Check for size calculation overflow.
212 Don't update size until allocation succeeds.
213 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
214 EMACS_INT, where ptrdiff_t will do.
215 (Fsubstitute_command_keys): Check for string overflow.
216
217 * editfns.c (set_time_zone_rule): Don't assume environment length
218 fits in int.
219 (message_length): Now ptrdiff_t, not int.
220 (Fmessage_box): Don't update size until allocation succeeds.
221 Don't assume message length fits in int.
222 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
223
224 * emacs.c (main): Do not reallocate argv, since there is a null at
225 the end that can be overwritten, and this way there's no need to
226 worry about size-calculation overflow.
227 (sort_args): Check for size-calculation overflow.
228
229 * eval.c (init_eval_once, grow_specpdl): Don't update size until
230 alloc succeeds.
231 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
232
233 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
234 (x_set_scroll_bar_width, x_figure_window_size):
235 Check for integer overflow.
236 (x_set_alpha): Do not assume XINT fits in int.
237
238 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
239 This is for the members text_lines, text_cols, total_lines, total_cols,
240 where the system imposes an 'int' limit.
241
242 * fringe.c (Fdefine_fringe_bitmap):
243 Don't update size until alloc works.
244
245 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
246 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
247
248 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
249 Check for size-calculation overflow.
250 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
251 do, as we prefer signed integers.
252 (id_to_widget.max_size, id_to_widget.used)
253 (xg_store_widget_in_map, xg_remove_widget_from_map)
254 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
255 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
256 Use and return ptrdiff_t, not int.
257 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
258 * gtkutil.h: Change prototypes to match the above.
259
260 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
261 are duplicate now that they've been promoted to lisp.h.
262 (x_allocate_bitmap_record, x_alloc_image_color)
263 (make_image_cache, cache_image, xpm_load):
264 Don't update size until alloc is done.
265 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
266 (x_detect_edges):
267 Check for size calculation overflow.
268 (ct_colors_allocated_max): New constant.
269 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
270 overflow.
271
272 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
273 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
274 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
275 Use ptrdiff_t, not int, to count maps.
276 (read_char_minibuf_menu_prompt): Check for overflow in size
277 calculations. Don't update size until allocation succeeds. Redo
278 calculations to avoid overflow.
279 * keyboard.h: Change prototypes to match the above.
280
281 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
282 to count maps.
283 (current_minor_maps): Check for size calculation overflow.
284 * keymap.h: Change prototypes to match the above.
285
286 * lread.c (read1, init_obarray): Don't update size until alloc done.
287
288 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
289 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
290
291 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
292 Now ptrdiff_t, not int.
293 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
294 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
295
296 * process.c (Fnetwork_interface_list): Check for overflow
297 in size calculation.
298
299 * region-cache.c (move_cache_gap): Check for size calculation overflow.
300
301 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
302 overflow. Don't bother calling xmalloc when xrealloc will do.
303
304 * search.c (Freplace_match): Check for size calculation overflow.
305 (Fset_match_data): Don't assume list lengths fit in 'int'.
306
307 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
308 for command line length. Do not attempt to address one before the
309 beginning of an array, as that's not portable.
310
311 * term.c (max_frame_lines): Remove; unused.
312 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
313 not int.
314 (encode_terminal_code, calculate_costs): Check for size
315 calculation overflow.
316 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
317 table lengths and related sizes. Don't update size until alloc
318 done. Redo calculations to avoid overflow.
319 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
320
321 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
322 subtracting pointers.
323 (gobble_line): Check for overflow more carefully. Don't update size
324 until alloc done.
325
326 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
327 Don't update size until alloc done.
328 Redo size calculations to avoid overflow.
329 Check for size calculation overflow.
330 (main) [DEBUG]: Fix typo in invoking tparam1.
331
332 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
333 Use ptrdiff_t, not int, for sizes.
334 (store_mode_line_noprop_char): Don't update size until alloc done.
335
336 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
337 Use ptrdiff_t, not int, for sizes.
338 (Finternal_make_lisp_face, cache_face):
339 Check for size calculation overflow.
340 (cache_face): Treat size calculation overflows as if they were
341 memory exhaustion (the usual treatment), rather than aborting.
342
343 * xfns.c (x_encode_text, x_set_name_internal)
344 (Fx_change_window_property): Use ptrdiff_t, not int, to count
345 sizes, since they can exceed INT_MAX in size. Check for size
346 calculation overflow.
347
348 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
349 (xg_select): Check for size calculation overflow.
350 Don't update size until alloc done.
351
352 * xrdb.c (get_environ_db): Don't assume path length fits in int,
353 as sprintf is limited to int lengths.
354
355 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
356 (X_LONG_MIN): New macros.
357 Use them to make the following changes clearer.
358 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
359 This change doesn't affect the value now, but it may help remind
360 future maintainers not to raise the value too much later.
361 (SELECTION_QUANTUM): Remove, replacing with ...
362 (selection_quantum): ... new function, which avoids overflow.
363 All uses changed.
364 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
365 assumption that selection length fits in 'int'.
366 (x_reply_selection_request, x_handle_selection_request)
367 (x_get_window_property, receive_incremental_selection)
368 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
369 (lisp_data_to_selection_data, clean_local_selection_data):
370 Use ptrdiff_t, not int, to record length of selection.
371 (x_reply_selection_request, x_get_window_property)
372 (receive_incremental_selection, x_property_data_to_lisp):
373 Redo calculations to avoid overflow.
374 (x_reply_selection_request): When sending hint, ceiling it at
375 X_LONG_MAX rather than relying on wraparound overflow to send
376 something.
377 (x_get_window_property, receive_incremental_selection)
378 (lisp_data_to_selection_data, x_property_data_to_lisp):
379 Check for size-calculation overflow.
380 (x_get_window_property, receive_incremental_selection)
381 (lisp_data_to_selection_data, Fx_register_dnd_atom):
382 Don't store size until memory allocation succeeds.
383 (x_get_window_property): Plug memory leak on memory exhaustion.
384 Don't double-block input; malloc is safe here. Don't assume 2**34
385 - 4 fits in unsigned long. Add an xassert to check
386 XGetWindowProperty overflow. Be more careful about overflow
387 calculations, and distinguish size from memory overflow better.
388 (receive_incremental_selection): When tracing, don't assume
389 unsigned int is less than INT_MAX.
390 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
391 harmful) conversions of unsigned short to int.
392 (lisp_data_to_selection_data): Don't assume that integers
393 in the range -65535 through -1 fit in an X unsigned short.
394 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
395 result parameters unless successful. Rely on cons_to_unsigned
396 to report problems with elements; the old code wasn't right anyway.
397 (x_check_property_data): Check for int overflow; we cannot use
398 a wider type due to X limits.
399 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
400
401 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
402
403 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
404 (x_term_init): Check for size calculation overflow.
405 (x_color_cells): Don't store size until memory allocation succeeds.
406 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
407 Don't assume alloca size is less than MAX_ALLOCA.
408 (x_term_init): Don't assume length fits in int (sprintf is limited
409 to int size).
410
411 Use ptrdiff_t for composition IDs.
412 * character.c (lisp_string_width):
413 * composite.c (composition_table_size, n_compositions)
414 (get_composition_id, composition_gstring_from_id):
415 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
416 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
417 * window.c (Frecenter):
418 Use ptrdiff_t, not int, for composition IDs.
419 * composite.c (get_composition_id): Check for integer overflow.
420 * composite.h: Adjust prototypes to match the above changes.
421
422 Use ptrdiff_t for hash table indexes.
423 * category.c (hash_get_category_set):
424 * ccl.c (ccl_driver):
425 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
426 * coding.c (coding_system_charset_list, detect_coding_system):
427 * coding.h (struct coding_system.id):
428 * composite.c (get_composition_id, gstring_lookup_cache):
429 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
430 * image.c (xpm_get_color_table_h):
431 * lisp.h (hash_lookup, hash_put):
432 * minibuf.c (Ftest_completion):
433 Use ptrdiff_t for hash table indexes, not int (which is too
434 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
435 32-bit --with-wide-int hosts).
436
437 * charset.c (Fdefine_charset_internal): Check for integer overflow.
438 Add a FIXME comment about memory leaks.
439 (syms_of_charset): Don't assume xmalloc returns.
440
441 Don't assume that stated character widths fit in int.
442 * character.c (Fchar_width, c_string_width, lisp_string_width):
443 * character.h (CHAR_WIDTH):
444 * indent.c (MULTIBYTE_BYTES_WIDTH):
445 Use sanitize_char_width to avoid undefined and/or bad behavior
446 with outlandish widths.
447 * character.h (sanitize_tab_width): Renamed from sanitize_width,
448 now that we have two such functions. All uses changed.
449 (sanitize_char_width): New inline function.
450
451 Don't assume that tab-width fits in int.
452 * character.h (sanitize_width): New inline function.
453 (SANE_TAB_WIDTH): New macro.
454 (ASCII_CHAR_WIDTH): Use it.
455 * indent.c (sane_tab_width): Remove. All uses replaced by
456 SANE_TAB_WIDTH (current_buffer).
457 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
458
459 * fileio.c: Integer overflow issues with file modes.
460 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
461
462 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
463 Remove unreachable code.
464 (read_hex, load_charset_map_from_file): Check for integer overflow.
465
466 * xterm.c: don't go over XClientMessageEvent limit
467 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
468 (x_send_scroll_bar_event): Likewise. Check that the size does not
469 exceed limits imposed by XClientMessageEvent, as well as the usual
470 ptrdiff_t and size_t limits.
471
472 * keyboard.c: Overflow, signedness and related fixes.
473 (make_lispy_movement): Use same integer type in forward decl
474 that is used in the definition.
475 (read_key_sequence, keyremap_step):
476 Change bufsize argument back to int, undoing my 2011-03-30 change.
477 We prefer signed types, and int is wide enough here.
478 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
479 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
480 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
481 length, not size_t. Use ptrdiff_t for index, not int.
482 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
483 possibility of integer overflow.
484
485 Overflow, signedness and related fixes for images.
486
487 * dispextern.h (struct it.stack[0].u.image.image_id)
488 (struct_it.image_id, struct image.id, struct image_cache.size)
489 (struct image_cache.used, struct image_cache.ref_count):
490 * gtkutil.c (update_frame_tool_bar):
491 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
492 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
493 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
494 * nsmenu.m (update_frame_tool_bar):
495 * xdisp.c (calc_pixel_width_or_height):
496 * xfns.c (image_cache_refcount):
497 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
498 on typical 64-bit hosts.
499
500 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
501 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
502 Omit unnecessary casts to int.
503 (parse_image_spec): Check that integers fall into 'int' range
504 when the callers expect that.
505 (image_ascent): Redo ascent calculation to avoid int overflow.
506 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
507 (lookup_image): Remove unnecessary tests.
508 (xbm_image_p): Locals are now of int, not EMACS_INT,
509 since parse_image_check makes sure they fit into int.
510 (png_load, gif_load, svg_load_image):
511 Prefer int to unsigned where either will do.
512 (tiff_handler): New function, combining the cores of the
513 old tiff_error_handler and tiff_warning_handler. This
514 function is rewritten to use vsnprintf and thereby avoid
515 stack buffer overflows. It uses only the features of vsnprintf
516 that are common to both POSIX and native Microsoft.
517 (tiff_error_handler, tiff_warning_handler): Use it.
518 (tiff_load, gif_load, imagemagick_load_image):
519 Don't assume :index value fits in 'int'.
520 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
521 (imagemagick_load_image): Check that crop parameters fit into
522 the integer types that MagickCropImage accepts. Don't assume
523 Vimagemagick_render_type has a nonnegative value. Don't assume
524 size_t fits in 'long'.
525 (gs_load): Use printmax_t to print the widest integers possible.
526 Check for integer overflow when computing image height and width.
527
528 2011-08-26 Eli Zaretskii <eliz@gnu.org>
529
530 * xdisp.c (redisplay_window): Don't force window start if point
531 will be invisible in the resulting window. (Bug#9324)
532
533 2011-08-25 Eli Zaretskii <eliz@gnu.org>
534
535 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
536 the display spec is of the form `(space ...)'.
537 (handle_display_spec): Return the value returned by
538 handle_single_display_spec, not just 1 or zero.
539 (handle_single_display_spec): If the display spec is of the form
540 `(space ...)', and specifies display in the text area, return 2
541 rather than 1.
542 (try_cursor_movement): Check for the need to scroll more
543 accurately, and prefer exact match for point under bidi. Don't
544 advance `row' beyond the last row of the window.
545
546 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
547 into disp_prop; all users changed.
548
549 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
550 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
551 for the text covered by the display property.
552
553 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
554
555 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
556 Change return value to nil.
557 (Frecord_buffer): Delete unused function.
558
559 2011-08-24 Eli Zaretskii <eliz@gnu.org>
560
561 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
562 buffers, return left-to-right.
563 (set_cursor_from_row): Consider candidate row a win if its glyph
564 represents a newline and point is on that newline. Fixes cursor
565 positioning on the newline at EOL of R2L text within L2R
566 paragraph, and vice versa.
567 (try_cursor_movement): Check continued rows, in addition to
568 continuation rows. Fixes unwarranted scroll when point enters a
569 continued line of R2L text within an L2R paragraph, or vice versa.
570 (cursor_row_p): Consider the case of point being equal to
571 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
572 from the end of a short line to the beginning of a continued line
573 of R2L text within L2R paragraph.
574 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
575 composed characters.
576
577 * bidi.c (bidi_check_type): Use xassert.
578 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
579 members.
580
581 2011-08-23 Eli Zaretskii <eliz@gnu.org>
582
583 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
584 a character.
585
586 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
587
588 * nsfont.m (ns_otf_to_script): Fix typo.
589
590 2011-08-22 Kenichi Handa <handa@m17n.org>
591
592 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
593 extra slot even if the purpose is char-code-property-table.
594
595 2011-08-23 Eli Zaretskii <eliz@gnu.org>
596
597 * xdisp.c (redisplay_window): When computing centering_position,
598 account for the height of the header line. (Bug#8874)
599
600 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
601 instead of CHAR_TO_BYTE. Fixes a crash when a completion
602 candidate is selected by the mouse, and that candidate has a
603 composed character under the mouse.
604
605 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
606 coordinates reported by pos-visible-in-window-p for a composed
607 character in column zero.
608
609 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
610
611 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
612
613 2011-08-22 Eli Zaretskii <eliz@gnu.org>
614
615 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
616 consider it a hit if to_charpos is anywhere in the range of the
617 composed buffer positions.
618
619 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
620
621 * image.c (gif_load): Don't assume that each subimage has the same
622 dimensions as the base image. Handle disposal method that is
623 "undefined" by the gif spec (Bug#9335).
624
625 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
626
627 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
628 (Fcondition_case): Document `debug' symbol in error handler.
629
630 2011-08-19 Eli Zaretskii <eliz@gnu.org>
631
632 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
633 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
634 from an Org mode buffer to a Speedbar frame.
635
636 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
637 a composition, take its buffer position from IT->cmp_it.charpos.
638 Fixes cursor positioning at the beginning of a line that begins
639 with a composed character.
640
641 2011-08-18 Eli Zaretskii <eliz@gnu.org>
642
643 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
644 character bidirectional type, use STRONG_L instead. Fixes crashes
645 in a buffer produced by `describe-categories'.
646
647 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
648 members before the level stack, so they would be saved and
649 restored when copying iterator state. Fixes incorrect reordering
650 around TABs covered by display properties.
651
652 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
653
654 * process.c (Fnetwork_interface_list): Correctly determine buffer
655 size.
656
657 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
658
659 * eval.c (internal_condition_case, internal_condition_case_1)
660 (internal_condition_case_2, internal_condition_case_n):
661 Remove unnecessary aborts (Bug#9081).
662
663 2011-08-17 Eli Zaretskii <eliz@gnu.org>
664
665 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
666 has no `load' handler, try opening the file locally. (Bug#9311)
667
668 2011-08-16 Ken Brown <kbrown@cornell.edu>
669
670 * gmalloc.c: Expand comment.
671
672 2011-08-16 Eli Zaretskii <eliz@gnu.org>
673
674 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
675 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
676
677 2011-08-16 Ken Brown <kbrown@cornell.edu>
678
679 Fix memory allocation problems in Cygwin build (Bug#9273).
680
681 * unexcw.c ( __malloc_initialized): Declare external variable.
682 (fixup_executable): Force the dumped emacs to reinitialize malloc.
683
684 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
685 New variables.
686 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
687 dumped emacs.
688 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
689 in the static heap.
690 [CYGWIN] (special_realloc): New function.
691 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
692 requests to realloc storage in the static heap.
693
694 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
695
696 * bidi.c (bidi_initialize): Remove unused local.
697
698 2011-08-15 Eli Zaretskii <eliz@gnu.org>
699
700 * biditype.h: File removed.
701
702 * bidimirror.h: File removed.
703
704 * deps.mk (bidi.o): Remove biditype.h and
705 bidimirror.h.
706
707 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
708 bidimirror.h.
709
710 * dispextern.h: Fix a typo in the comment to bidi_type_t.
711
712 * chartab.c: Improve commentary for the uniprop_table API.
713
714 * bidi.c (bidi_paragraph_init): Support zero value of
715 bidi_ignore_explicit_marks_for_paragraph_level.
716 (bidi_initialize): Use uniprop_table instead of including
717 biditype.h and bidimirror.h.
718
719 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
720 coordinates of the iterator when restoring from ppos_it.
721 (Bug#9296)
722
723 2011-08-14 Kenichi Handa <handa@m17n.org>
724
725 * process.c (create_process): Call setup_process_coding_systems
726 after the pid of the process is set to -1 (Bug#8162).
727
728 2011-08-14 Eli Zaretskii <eliz@gnu.org>
729
730 * xdisp.c (move_it_in_display_line_to): Don't invoke
731 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
732 ppos_it. Fixes vertical cursor motion when line beginning is
733 covered by an image. (Bug#9296)
734
735 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
736
737 * nsterm.h (ns_run_ascript): Declare.
738 (NSAPP_DATA2_RUNASSCRIPT): Define.
739
740 * nsfns.m (as_script, as_result, as_status): New static variables.
741 (ns_run_ascript): New function.
742 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
743 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
744 the event loop. Get status from as_status (Bug#7276).
745
746 * nsterm.m (sendEvent): If event is NSApplicationDefined and
747 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
748 the event loop (Bug#7276).
749
750 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
751
752 * gnutls.c (QCgnutls_bootprop_priority)
753 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
754 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
755 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
756 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
757 (QCgnutls_bootprop_verify_hostname_error)
758 (QCgnutls_bootprop_callbacks_verify): Rename from
759 Qgnutls_bootprop_..., all uses changed.
760
761 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
762 uses changed.
763
764 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
765
766 * xfaces.c (Qframe_set_background_mode): Now static.
767 * dispextern.h (Qframe_set_background_mode): Remove decl.
768
769 * process.c (Fnetwork_interface_info): Declare local only if needed.
770
771 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
772
773 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
774 (Fnetwork_interface_list): Allocate in increments of bytes instead
775 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
776 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
777 sockaddr.
778 (struct ifflag_def): notrailers is smart on OSX.
779 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
780 Get hardware address with getifaddrs if available.
781
782 2011-08-12 Eli Zaretskii <eliz@gnu.org>
783
784 * xdisp.c (iterate_out_of_display_property): xassert that
785 IT->position is set to within IT->object's boundaries. Break from
786 the loop as soon as EOB is reached; avoids infloops in redisplay
787 when IT->position is set up wrongly due to some bug.
788 Set IT->current to match the bidi iterator unconditionally.
789 (push_display_prop): Allow GET_FROM_STRING as IT->method on
790 entry. Force push_it to save on the stack the current
791 buffer/string position, to be restored by pop_it. Fix flags in
792 the iterator structure wrt the object coming from a display
793 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
794 properties. (Bug#9284)
795
796 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
797
798 * fontset.c (fontset_get_font_group): Add proper type checks.
799 (Bug#9172)
800
801 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
802
803 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
804 and LC_VERSION_MIN_MACOSX.
805 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
806 (dump_it) [LC_FUNCTION_STARTS]: Use it.
807
808 2011-08-08 Eli Zaretskii <eliz@gnu.org>
809
810 * xdisp.c (forward_to_next_line_start): Allow to use the
811 no-display-properties-and-no-overlays under bidi display.
812 Set disp_pos in the bidi iterator to avoid searches for display
813 properties and overlays.
814
815 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
816
817 * editfns.c (Fset_time_zone_rule): Document relationship with the
818 setenv function.
819
820 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
821 the font entity extracted from the cache (Bug#8109).
822
823 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
824
825 * composite.c (autocmp_chars): Don't reset point. That is done by
826 restore_point_unwind (Bug#5984).
827
828 2011-08-07 Juri Linkov <juri@jurta.org>
829
830 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
831 to show the arg `TIME' instead of `TIMEVAL'.
832
833 2011-08-06 Eli Zaretskii <eliz@gnu.org>
834
835 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
836 display property strides EOL and includes a newline, as in
837 longlines-mode. (Bug#9254)
838 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
839 word-wrap under bidirectional display. (Bug#9224)
840
841 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
842 is non-zero, even if the data buffer is NULL. Fixes a crash in
843 vertical-motion with longlines-mode. (Bug#9254)
844
845 2011-08-05 Eli Zaretskii <eliz@gnu.org>
846
847 * bidi.c <bidi_cache_total_alloc>: Now static.
848 (bidi_initialize): Initialize bidi_cache_total_alloc.
849
850 * xdisp.c (display_line): Release buffer allocated for shelved bidi
851 cache. (Bug#9221)
852
853 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
854 amount allocated this far in `bidi_cache_total_alloc'.
855 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
856 non-zero, only free the data buffer without restoring the cache
857 contents. All callers changed.
858
859 * dispextern.h (bidi_unshelve_cache): Update prototype.
860
861 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
862 (move_it_in_display_line, move_it_to)
863 (move_it_vertically_backward, move_it_by_lines): Replace the call
864 to xfree to an equivalent call to bidi_unshelve_cache.
865 (move_it_in_display_line_to): Fix logic of returning
866 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
867
868 2011-08-05 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
871 came from a string character with a `cursor' property. (Bug#9229)
872
873 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
874
875 * Makefile.in (LIB_PTHREAD): New variable.
876 (LIBES): Add LIB_PTHREAD (Bug#9216).
877
878 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
879 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
880
881 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
882
883 * regex.c (re_iswctype): Remove some redundant boolean
884 conversions.
885
886 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
887
888 * xterm.c (x_find_topmost_parent): New function.
889 (x_set_frame_alpha): Find topmost parent window with
890 x_find_topmost_parent and set the property there also (bug#9181).
891 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
892
893 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
894
895 * callproc.c (Fcall_process): Avoid vfork clobbering
896 the local vars buffer, coding_systems, current_dir.
897
898 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
899
900 * keymap.c (Fmake_composed_keymap): Move to subr.el.
901
902 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
903
904 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
905 so that it is not optimized away.
906
907 * xdisp.c (compute_display_string_pos): Remove unused local.
908
909 2011-08-02 Eli Zaretskii <eliz@gnu.org>
910
911 Fix slow cursor motion and scrolling in large buffers with
912 selective display, like Org Mode buffers. (Bug#9218)
913
914 * dispextern.h (struct bidi_it): New member disp_prop_p.
915
916 * xdisp.c: Remove one-slot cache of display string positions.
917 (compute_display_string_pos): Accept an additional argument
918 DISP_PROP_P; callers changed. Scan at most 5K characters forward
919 for a display string or property. If found, set DISP_PROP_P
920 non-zero.
921
922 * bidi.c (bidi_fetch_char): Accept an additional argument
923 DISP_PROP_P, and pass it to compute_display_string_pos.
924 Only handle text covered by a display string if DISP_PROP_P is returned
925 non-zero. All callers of bidi_fetch_char changed.
926
927 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
928
929 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
930
931 2010-12-03 Don March <don@ohspite.net>
932
933 * keymap.c (Fdefine_key): Fix non-prefix key error message when
934 last character M-[char] is translated to ESC [char] (bug#7541).
935
936 2011-08-02 Kenichi Handa <handa@m17n.org>
937
938 * lisp.h (uniprop_table): Extern it.
939
940 * chartab.c (uniprop_table): Make it non-static.
941
942 2011-08-01 Eli Zaretskii <eliz@gnu.org>
943
944 * xdisp.c (forward_to_next_line_start): Accept additional argument
945 BIDI_IT_PREV, and store into it the state of the bidi iterator had
946 on the newline.
947 (reseat_at_next_visible_line_start): Use the bidi iterator state
948 returned by forward_to_next_line_start to restore the state of
949 it->bidi_it after backing up to previous newline. (Bug#9212)
950
951 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
952
953 * regex.c (re_comp): Protoize.
954 (re_exec): Fix return type.
955 (regexec): Fix type of `ret'. (Bug#9203)
956
957 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
958
959 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
960 This is needed if max-image-size is a floating-point number.
961
962 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
963
964 * print.c (print_object): Print empty symbol as ##.
965
966 * lread.c (read1): Read ## as empty symbol.
967
968 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
969
970 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
971 setting frame foreground color (Bug#9175).
972 (x_set_background_color): Likewise.
973
974 * nsmenu.m (-setText): Size tooltip dimensions precisely to
975 contents (Bug#9176).
976 (EmacsTooltip -init): Remove bezels and add shadows to
977 tooltip windows.
978
979 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
980 or scroll bar (Bug#8470).
981
982 * nsfont.m (nsfont_open): Remove assignment to voffset and
983 unnecessary vars hshink, expand, hd, full_height, min_height.
984 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
985
986 * nsterm.h (nsfont_info): Remove voffset field.
987
988 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
989
990 Implement strike-through and overline on NextStep (Bug#8863).
991
992 * nsfont.m (nsfont_open): Use underline position provided by font,
993 instead of hard-coded value of 2.
994 (nsfont_draw): Call ns_draw_text_decoration instead.
995
996 * nsterm.h: Add declaration for ns_draw_text_decoration.
997
998 * nsterm.m (ns_draw_text_decoration): New function for drawing
999 underline, overline, and strike-through.
1000 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1001 ns_draw_text_decoration. Change treatment of cursor drawing to
1002 accomodate underlining, etc.
1003
1004 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1005
1006 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1007 default.
1008
1009 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1012 Without this fix, if a signal arrives just after memory fills up,
1013 'malloc' might be invoked reentrantly.
1014
1015 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1016 In other words, assume that every image size is allowed, on non-X
1017 hosts. This assumption is probably wrong, but it lets Emacs compile.
1018
1019 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1020
1021 * regex.c (re_iswctype): Convert return values to boolean.
1022
1023 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1024
1025 * xdisp.c (compute_display_string_pos): Don't use cached display
1026 string position if the buffer had its restriction changed.
1027 (Bug#9184)
1028
1029 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1030
1031 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1032
1033 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 Integer signedness and overflow and related fixes. (Bug#9079)
1036
1037 * bidi.c: Integer size and overflow fixes.
1038 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1039 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1040 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1041 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1042 (bidi_find_other_level_edge):
1043 Use ptrdiff_t instead of EMACS_INT where either will do.
1044 This works better on 32-bit hosts configured --with-wide-int.
1045 (bidi_cache_ensure_space): Check for size-calculation overflow.
1046 Use % rather than repeated addition, for better worst-case speed.
1047 Don't set bidi_cache_size until after xrealloc returns, because it
1048 might not return.
1049 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1050 (bidi_cache_ensure_space): Also check that the bidi cache size
1051 does not exceed that of the largest Lisp string or buffer. See Eli
1052 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1053
1054 * alloc.c (__malloc_size_t): Remove.
1055 All uses replaced by size_t. See Andreas Schwab's note
1056 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1057
1058 * image.c: Improve checking for integer overflow.
1059 (check_image_size): Assume that f is nonnull, since
1060 it is always nonnull in practice. This is one less thing to
1061 worry about when checking for integer overflow later.
1062 (x_check_image_size): New function, which checks for integer
1063 overflow issues inside X.
1064 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1065 This removes the need for a memory_full check.
1066 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1067 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1068 (xbm_read_bitmap_data): Change locals back to 'int', since
1069 their values must fit in 'int'.
1070 (xpm_load_image, png_load, tiff_load):
1071 Invoke x_create_x_image_and_pixmap earlier,
1072 to avoid much needless work if the image is too large.
1073 (tiff_load): Treat overly large images as if
1074 x_create_x_image_and_pixmap failed, not as malloc failures.
1075 (gs_load): Use x_check_image_size.
1076
1077 * gtkutil.c: Omit integer casts.
1078 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1079 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1080
1081 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1082
1083 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1084 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1085 would wrongly return t on a 64-bit host.
1086
1087 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1088 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1089 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1090 and therefore cause GCC to emit a bogus diagnostic in some cases.
1091
1092 * image.c: Integer signedness and overflow and related fixes.
1093 This is not an exhaustive set of fixes, but it's time to
1094 record what I've got.
1095 (lookup_pixel_color, check_image_size): Remove redundant decls.
1096 (check_image_size): Don't assume that arbitrary EMACS_INT values
1097 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1098 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1099 (tiff_load, imagemagick_load_image):
1100 Check for overflow in size calculations.
1101 (x_create_x_image_and_pixmap): Remove unnecessary test for
1102 xmalloc returning NULL; that can't happen.
1103 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1104 (xpm_color_bucket): Use better integer hashing function.
1105 (xpm_cache_color): Don't possibly over-allocate memory.
1106 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1107 (gif_memory_source):
1108 Use ptrdiff_t, not int or size_t, to record sizes.
1109 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1110 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1111 either works, as we prefer signed integers.
1112 (tiff_read_from_memory, tiff_write_from_memory):
1113 Return tsize_t, not size_t, since that's what the TIFF API wants.
1114 (tiff_read_from_memory): Don't fail simply because the read would
1115 go past EOF; instead, return a short read.
1116 (tiff_load): Omit no-longer-needed casts.
1117 (Fimagemagick_types): Don't assume size fits into 'int'.
1118
1119 Improve hashing quality when configured --with-wide-int.
1120 * fns.c (hash_string): New function, taken from sxhash_string.
1121 Do not discard information about ASCII character case; this
1122 discarding is no longer needed.
1123 (sxhash-string): Use it. Change sig to match it. Caller changed.
1124 * lisp.h: Declare it.
1125 * lread.c (hash_string): Remove, since we now use fns.c's version.
1126 The fns.c version returns a wider integer if --with-wide-int is
1127 specified, so this should help the quality of the hashing a bit.
1128
1129 * emacs.c: Integer overflow minor fix.
1130 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1131 Define only if GNU_LINUX.
1132 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1133
1134 * dispnew.c: Integer signedness and overflow fixes.
1135 Remove unnecessary forward decls, that were a maintenance hassle.
1136 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1137 All uses changed.
1138 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1139 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1140 (prepare_desired_row, line_draw_cost):
1141 Use int, not unsigned, where either works.
1142 (save_current_matrix, restore_current_matrix):
1143 Use ptrdiff_t, not size_t, where either works.
1144 (init_display): Check for overflow more accurately, and without
1145 relying on undefined behavior.
1146
1147 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1148 Remove, replacing with the new symbols in lisp.h. All uses changed.
1149 * fileio.c (make_temp_name):
1150 * filelock.c (lock_file_1, lock_file):
1151 * xdisp.c (message_dolog):
1152 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1153 Use pMd etc. instead.
1154 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1155 replacing the pWIDE etc. symbols removed from editfns.c.
1156
1157 * keyboard.h (num_input_events): Now uintmax_t.
1158 This is (very slightly) less likely to mess up due to wraparound.
1159 All uses changed.
1160
1161 * buffer.c: Integer signedness fixes.
1162 (alloc_buffer_text, enlarge_buffer_text):
1163 Use ptrdiff_t rather than size_t when either will do, as we prefer
1164 signed integers.
1165
1166 * alloc.c: Integer signedness and overflow fixes.
1167 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1168 (__malloc_size_t): Default to size_t, not to int.
1169 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1170 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1171 Prefer ptrdiff_t to size_t when either would do, as we prefer
1172 signed integers.
1173 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1174 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1175 Now const. Initialize with values that are in range even if char
1176 is signed.
1177 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1178 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1179 These functions do the right thing with sizes > 2**32.
1180 (check_depth): Now ptrdiff_t, not int.
1181 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1182 Adjust to new way of storing sizes. Check for size overflow bugs
1183 in rest of code.
1184 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1185 slightly wrong anyway, as it missed one instance of
1186 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1187 (refill_memory_reserve): Omit needless cast to size_t.
1188 (mark_object_loop_halt): Mark as externally visible.
1189
1190 * xselect.c: Integer signedness and overflow fixes.
1191 (Fx_register_dnd_atom, x_handle_dnd_message):
1192 Use ptrdiff_t, not size_t, since we prefer signed.
1193 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1194 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1195 x_dnd_atoms_size and x_dnd_atoms_length.
1196
1197 * doprnt.c: Prefer signed to unsigned when either works.
1198 * eval.c (verror):
1199 * doprnt.c (doprnt):
1200 * lisp.h (doprnt):
1201 * xdisp.c (vmessage):
1202 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1203 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1204 prefer signed arithmetic to avoid comparison confusion.
1205 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1206 but is a bit tricky.
1207
1208 Assume freestanding C89 headers, string.h, stdlib.h.
1209 * data.c, doprnt.c, floatfns.c, print.c:
1210 Include float.h unconditionally.
1211 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1212 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1213 * regex.c: Likewise for stddef.h, string.h.
1214 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1215 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1216 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1217 (STDC_HEADERS): Remove obsolete defines.
1218 * sysdep.c: Include limits.h unconditionally.
1219
1220 Assume support for memcmp, memcpy, memmove, memset.
1221 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1222 * regex.c (memcmp, memcpy):
1223 Remove; we assume C89 now.
1224
1225 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1226 (__malloc_safe_bcopy): Remove; no longer needed.
1227
1228 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1229 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1230 well either way, and we prefer signed to unsigned.
1231
1232 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1233
1234 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1235 closes the connection while we're reading (bug#9182).
1236
1237 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1238
1239 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1240 are specified (Bug#9168).
1241
1242 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1245 Found by GCC static checking and --with-wide-int on a 32-bit host.
1246
1247 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1248
1249 * xdisp.c (compute_display_string_pos): Fix logic of caching
1250 previous display string position. Initialize cached_prev_pos to
1251 -1. Fixes slow-down at the beginning of a buffer.
1252
1253 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1256 for attrs[LFACE_FONTSET_INDEX].
1257
1258 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 * xml.c (parse_region): Remove unused local
1261 that was recently introduced.
1262
1263 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1264
1265 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1266 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1267
1268 * xdisp.c (move_it_in_display_line_to): Record the best matching
1269 position for TO_CHARPOS while scanning the line, and restore it on
1270 exit if none of the characters scanned was an exact match.
1271 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1272 when exact match is impossible due to invisible text, and the
1273 lines are truncated.
1274
1275 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1276
1277 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1278 for OSX >= 10.7.
1279
1280 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1281
1282 Fix a significant slow-down of cursor motion with C-n, C-p,
1283 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1284 auto-repeat under bidi redisplay in fontified buffers.
1285 * xdisp.c (compute_stop_pos_backwards): New function.
1286 (next_element_from_buffer): Call compute_stop_pos_backwards to
1287 find a suitable prev_stop when we find ourselves before
1288 base_level_stop.
1289 (reseat): Don't look for prev_stop, as that could mean a very long
1290 run.
1291 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1292 <cached_disp_overlay_modiff>: Cache for last found display string
1293 position.
1294 (compute_display_string_pos): Return the cached position if asked
1295 about the same buffer in the same area of character positions, and
1296 the buffer wasn't changed since the time the display string
1297 position was cached.
1298
1299 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1300
1301 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1302 is an integer, which is important for empty lines. (Bug#9149)
1303
1304 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1305
1306 * frame.c (Fmodify_frame_parameters): In tty case, update the
1307 default face if necessary (Bug#4238).
1308
1309 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1310
1311 * editfns.c (Fstring_to_char): No need to explain what a character
1312 is in the docstring (Bug#6576).
1313
1314 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1315
1316 * xml.c (parse_region): Make sure we always return a tree.
1317
1318 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1319
1320 * xml.c (parse_region): If a document contains only comments,
1321 return that, too.
1322
1323 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1324
1325 * xml.c (make_dom): Return comments, too.
1326
1327 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 Port to OpenBSD.
1330 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1331 and the surrounding thread.
1332 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1333 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1334 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1335 timer goes off.
1336 * s/openbsd.h (BROKEN_SIGIO): Define.
1337 * unexelf.c (unexec) [__OpenBSD__]:
1338 Don't update the .mdebug section of the Alpha COFF symbol table.
1339
1340 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1341
1342 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1343 (bug#8460).
1344
1345 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1348 This fixes some race conditions on the permissions of any newly
1349 created file.
1350
1351 * alloc.c (valid_pointer_p): Use pipe, not open.
1352 This fixes some permissions issues when debugging.
1353
1354 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1355 If fchown fails to set both uid and gid, try to set just gid,
1356 as that is sometimes allowed. Adjust the file's mode to eliminate
1357 setuid or setgid bits that are inappropriate if fchown fails.
1358
1359 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1360
1361 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1362 to compare Lisp_Objects.
1363 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1364 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1365 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1366
1367 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1368
1369 * lread.c (read_integer): Unread even EOF character.
1370 (read1): Likewise. Properly record start position of symbol.
1371
1372 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1373 symbol character follows.
1374
1375 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1376
1377 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1378 This works around a problem with the previous change to Fcopy_file.
1379 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1380 and without this change, GCC might complain about discarding
1381 fchown's return value.
1382
1383 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1384
1385 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1386
1387 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1390
1391 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1392
1393 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1394 it's used from the C level.
1395
1396 * process.c: Use the same condition for POLL_FOR_INPUT in both
1397 keyboard.c and process.c (bug#1858).
1398
1399 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1400
1401 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1402 (Fgnutls_boot): Use it.
1403
1404 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1405
1406 * doc.c (Fsubstitute_command_keys): Revert last change.
1407
1408 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1409
1410 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1411 quotes the next character, and doesn't affect other longer
1412 sequences (bug#8935).
1413
1414 * lread.c (syms_of_lread): Clarify that is isn't only
1415 `eval-buffer' and `eval-defun' that's affected by
1416 `lexical-binding' (bug#8460).
1417
1418 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1419
1420 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1421 bidi redisplay when a line includes both an image and is
1422 truncated.
1423
1424 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 Fix minor problems found by static checking.
1427 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1428 (elsz): Now a signed constant, not a size_t var. We prefer signed
1429 types to unsigned, to avoid integer comparison confusion. Without
1430 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1431 "cannot optimize loop, the loop counter may overflow", a symptom
1432 of the confusion.
1433 * indent.c (Fvertical_motion): Mark locals as initialized.
1434 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1435
1436 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1437
1438 * search.c (Fre_search_backward): Mention `case-fold-search' in
1439 all the re_search_* functions (bug#8138).
1440
1441 * keyboard.c (Fopen_dribble_file): Document when the file is
1442 closed (bug#8056).
1443
1444 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1445
1446 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1447 bidi_cache_idx.
1448
1449 Support bidi reordering of display and overlay strings.
1450 * xdisp.c (compute_display_string_pos)
1451 (compute_display_string_end): Accept additional argument STRING.
1452 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1453 (reseat_to_string): Initialize bidi_it->string.s and
1454 bidi_it->string.schars.
1455 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1456 NULL (avoids a crash in bidi_paragraph_init).
1457 Initialize itb.string.lstring.
1458 (init_iterator): Call bidi_init_it only of a valid
1459 buffer position was specified. Initialize paragraph_embedding to
1460 L2R.
1461 (reseat_to_string): Initialize the bidi iterator.
1462 (display_string): If we need to ignore text properties of
1463 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1464 original value of -1 will not work with bidi.)
1465 (compute_display_string_pos): First arg is now struct
1466 `text_pos *'; all callers changed. Support display properties on
1467 Lisp strings.
1468 (compute_display_string_end): Support display properties on Lisp
1469 strings.
1470 (init_iterator, reseat_1, reseat_to_string): Initialize the
1471 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1472 when iterating on a string not from display properties).
1473 (compute_display_string_pos, compute_display_string_end):
1474 Fix calculation of the object to scan. Fixes an error when using
1475 arrow keys.
1476 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1477 base_level_stop; instead, set base_level_stop to BEGV.
1478 Fixes crashes in vertical-motion.
1479 (next_element_from_buffer): Improve commentary for when
1480 the iterator is before prev_stop.
1481 (init_iterator): Initialize bidi_p from the default value of
1482 bidi-display-reordering, not from buffer-local value. Use the
1483 buffer-local value only if initializing for buffer iteration.
1484 (handle_invisible_prop): Support invisible properties on strings
1485 that are being bidi-reordered.
1486 (set_iterator_to_next): Support bidi reordering of C strings and
1487 Lisp strings.
1488 (next_element_from_string): Support bidi reordering of Lisp
1489 strings.
1490 (handle_stop_backwards): Support Lisp strings as well.
1491 (display_string): Support display of R2L glyph rows.
1492 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1493 (init_iterator): Don't initialize it->bidi_p for strings
1494 here.
1495 (reseat_to_string): Initialize it->bidi_p for strings here.
1496 (next_element_from_string, next_element_from_c_string)
1497 (next_element_from_buffer): Add xassert's for correspondence
1498 between IT's object being iterated and it->bidi_it.string
1499 structure.
1500 (face_before_or_after_it_pos): Support bidi iteration.
1501 (next_element_from_c_string): Handle the case of the first string
1502 character that is not the first one in the visual order.
1503 (get_visually_first_element): New function, refactored from common
1504 parts of next_element_from_buffer, next_element_from_string, and
1505 next_element_from_c_string.
1506 (tool_bar_lines_needed, redisplay_tool_bar)
1507 (display_menu_bar): Force left-to-right direction. Add a FIXME
1508 comment for making that be controlled by a user option.
1509 (push_it, pop_it): Save and restore the state of the
1510 bidi iterator. Save and restore the bidi_p flag.
1511 (pop_it): Iterate out of display property for string iteration as
1512 well.
1513 (iterate_out_of_display_property): Support iteration over strings.
1514 (handle_single_display_spec): Set up it->bidi_it for iteration
1515 over a display string, and call bidi_init_it.
1516 (handle_single_display_spec, next_overlay_string)
1517 (get_overlay_strings_1, push_display_prop): Set up the bidi
1518 iterator for displaying display or overlay strings.
1519 (forward_to_next_line_start): Don't use the shortcut if
1520 bidi-iterating.
1521 (back_to_previous_visible_line_start): If handle_display_prop
1522 pushed the iterator stack, restore the internal state of the bidi
1523 iterator by calling bidi_pop_it same number of times.
1524 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1525 and we are bidi-iterating, don't decrement the iterator position;
1526 instead, set the first_elt flag in the bidi iterator, to produce
1527 the same effect.
1528 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1529 (push_display_prop): xassert that we are iterating a buffer.
1530 (push_it, pop_it): Save and restore paragraph_embedding member.
1531 (handle_single_display_spec, next_overlay_string)
1532 (get_overlay_strings_1, reseat_1, reseat_to_string)
1533 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1534 correctly. Don't assume unibyte strings are not bidi-reordered.
1535 (compute_display_string_pos)
1536 (compute_display_string_end): Fix handling the case of C string.
1537 (push_it, pop_it): Save and restore from_disp_prop_p.
1538 (handle_single_display_spec, push_display_prop): Set the
1539 from_disp_prop_p flag.
1540 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1541 (pop_it): Call iterate_out_of_display_property only if we are
1542 popping after iteration over a string that came from a display
1543 property. Fix a typo in popping stretch info. Add an assertion
1544 for verifying that the iterator position is in sync with the bidi
1545 iterator.
1546 (handle_single_display_spec, get_overlay_strings_1)
1547 (push_display_prop): Fix initialization of paragraph direction for
1548 string when that of the parent object is not yet determined.
1549 (reseat_1): Call bidi_init_it to resync the bidi
1550 iterator with IT's position. (Bug#7616)
1551 (find_row_edges): If ROW->start.pos gives position
1552 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1553 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1554 Reset the from_disp_prop_p flag.
1555 (SAVE_IT, RESTORE_IT): New macros.
1556 (pos_visible_p, face_before_or_after_it_pos)
1557 (back_to_previous_visible_line_start)
1558 (move_it_in_display_line_to, move_it_in_display_line)
1559 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1560 (try_scrolling, redisplay_window, display_line): Use them when
1561 saving a temporary copy of the iterator and restoring it back.
1562 (back_to_previous_visible_line_start, reseat_1)
1563 (init_iterator): Empty the bidi cache "stack".
1564 (move_it_in_display_line_to): If iterator ended up at
1565 EOL, but we never saw any buffer positions smaller than
1566 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1567 motion in bidi-reordered lines.
1568 (move_it_in_display_line_to): Record prev_method and prev_pos
1569 immediately before the call to set_iterator_to_next. Fixes cursor
1570 motion in bidi-reordered lines with stretch glyphs and strings
1571 displayed in margins. (Bug#8133) (Bug#8867)
1572 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1573 TO_CHARPOS.
1574 (pos_visible_p): Support positions in bidi-reordered lines.
1575 Save and restore bidi cache.
1576
1577 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1578 (bidi_paragraph_info): Delete unused struct.
1579 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1580 (bidi_cache_start): New variable.
1581 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1582 to zero.
1583 (bidi_cache_fetch_state, bidi_cache_search)
1584 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1585 (bidi_cache_find, bidi_peek_at_next_level)
1586 (bidi_level_of_next_char, bidi_find_other_level_edge)
1587 (bidi_move_to_visually_next): Compare cache index with
1588 bidi_cache_start rather than with zero.
1589 (bidi_fetch_char): Accept new argument STRING; all callers
1590 changed. Support iteration over a string. Support strings with
1591 display properties. Support unibyte strings. Fix the type of
1592 `len' according to what STRING_CHAR_AND_LENGTH expects.
1593 (bidi_paragraph_init, bidi_resolve_explicit_1)
1594 (bidi_resolve_explicit, bidi_resolve_weak)
1595 (bidi_level_of_next_char, bidi_move_to_visually_next):
1596 Support iteration over a string.
1597 (bidi_set_sor_type, bidi_resolve_explicit_1)
1598 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1599 can now be zero (for strings); special values 0 and -1 were
1600 changed to -1 and -2, respectively.
1601 (bidi_char_at_pos): New function.
1602 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1603 Call it instead of FETCH_MULTIBYTE_CHAR.
1604 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1605 initialized to valid values.
1606 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1607 values.
1608 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1609 the test for valid cached positions. Fix the logic for looking up
1610 the sentinel state in the cache. GCPRO the Lisp string we are
1611 iterating.
1612 (bidi_push_it, bidi_pop_it): New functions.
1613 (bidi_initialize): Initialize the bidi cache start stack pointer.
1614 (bidi_cache_ensure_space): New function, refactored from part of
1615 bidi_cache_iterator_state. Don't assume the required size is just
1616 one BIDI_CACHE_CHUNK away.
1617 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1618 (bidi_count_bytes, bidi_char_at_pos): New functions.
1619 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1620 always valid if bidi_cache_idx is valid.
1621 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1622 is valid if it's going to be used.
1623 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1624 (bidi_cache_fetch_state, bidi_cache_search)
1625 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1626 (bidi_cache_iterator_state, bidi_cache_find)
1627 (bidi_find_other_level_edge, bidi_cache_start_stack):
1628 All variables related to cache indices are now EMACS_INT.
1629
1630 * dispextern.h (struct bidi_string_data): New structure.
1631 (struct bidi_it): New member `string'. Make flag members be 1-bit
1632 fields, and put them last in the struct.
1633 (compute_display_string_pos, compute_display_string_end):
1634 Update prototypes.
1635 (bidi_push_it, bidi_pop_it): Add prototypes.
1636 (struct iterator_stack_entry): New members bidi_p,
1637 paragraph_embedding, and from_disp_prop_p.
1638 (struct it): Member bidi_p is now a bit field 1 bit wide.
1639 (bidi_shelve_cache, bidi_unshelve_cache):
1640 Declare prototypes.
1641
1642 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1643 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1644 and vector-like objects.
1645
1646 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1647 cache around display iteration.
1648
1649 * window.c (Fwindow_end, window_scroll_pixel_based)
1650 (displayed_window_lines, Frecenter): Save and restore the bidi
1651 cache around display iteration.
1652
1653 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1654
1655 * editfns.c (Fdelete_region): Clarify the use of the named
1656 parameters (bug#6788).
1657
1658 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1659
1660 * indent.c (Fvertical_motion): Set and restore w->pointm when
1661 saving and restoring the window's buffer (Bug#9006).
1662
1663 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1664
1665 * editfns.c (Fstring_to_char): Clarify just what is returned
1666 (bug#6576). Text by Eli Zaretskii.
1667
1668 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1669
1670 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1671
1672 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1673
1674 * buffer.c (mmap_find): Fix a typo.
1675
1676 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1677
1678 Fix execution of x selection hooks.
1679 * xselect.c (Qx_lost_selection_functions)
1680 (Qx_sent_selection_functions): New vars.
1681 (syms_of_xselect): DEFSYM them.
1682 (x_handle_selection_request): Pass Qx_sent_selection_functions
1683 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1684 (x_handle_selection_clear,x_clear_frame_selections):
1685 Pass Qx_lost_selection_functions rather than
1686 Vx_lost_selection_functions to Frun_hook_with_args.
1687
1688 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1691 The old code sometimes used this field without initializing it.
1692
1693 * alloc.c (gc_sweep): Don't read past end of array.
1694 In theory, the old code could also have corrupted Emacs internals,
1695 though it'd be very unlikely.
1696
1697 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1698
1699 * character.c (Fcharacterp): Don't advertise optional ignored
1700 argument. (Bug#4026)
1701
1702 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1703
1704 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1705 key" (bug#4257).
1706
1707 * window.c (Fset_window_start): Doc fix (bug#4199).
1708 (Fset_window_hscroll): Ditto.
1709
1710 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 Fix minor new problems caught by GCC 4.6.1.
1713 * term.c (init_tty): Remove unused local.
1714 * xsettings.c (store_monospaced_changed): Define this function only
1715 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1716 not used otherwise.
1717
1718 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1719
1720 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1721
1722 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1723
1724 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1725 are the mini-buffer and the echo area (bug#3320).
1726
1727 * term.c (init_tty): Remove support for supdup, c10 and perq
1728 terminals, which are no longer supported (bug#1482).
1729
1730 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1731
1732 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1733
1734 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1735
1736 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1737 for non-popups (Bug#3642).
1738
1739 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1740
1741 * alloc.c (reset_malloc_hooks): Protoize.
1742 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1743 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1744 * cm.c (losecursor): Likewise.
1745 * data.c (fmod): Likewise.
1746 * dispnew.c (swap_glyphs_in_rows): Likewise.
1747 * emacs.c (memory_warning_signal): Likewise.
1748 * floatfns.c (float_error): Likewise.
1749 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1750 (otf_open, font_otf_capability, generate_otf_features)
1751 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1752 Likewise.
1753 * image.c (pbm_read_file): Likewise.
1754 * indent.c (string_display_width): Likewise.
1755 * intervals.c (check_for_interval, search_for_interval)
1756 (inc_interval_count, count_intervals, root_interval)
1757 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1758 * lread.c (defalias): Likewise.
1759 * ralloc.c (r_alloc_check): Likewise.
1760 * regex.c (set_image_of_range_1, set_image_of_range)
1761 (regex_grow_registers): Likewise.
1762 * sysdep.c (strerror): Likewise.
1763 * termcap.c (valid_filename_p, tprint, main): Likewise.
1764 * tparam.c (main): Likewise.
1765 * unexhp9k800.c (run_time_remap, save_data_space)
1766 (update_file_ptrs, read_header, write_header, calculate_checksum)
1767 (copy_file, copy_rest, display_header): Likewise.
1768 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1769 Likewise.
1770 * xdisp.c (check_it): Likewise.
1771 * xfaces.c (register_color, unregister_color, unregister_colors):
1772 Likewise.
1773 * xfns.c (print_fontset_result): Likewise.
1774 * xrdb.c (member, fatal, main): Likewise.
1775
1776 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1777
1778 Fix minor problems found by static checking (Bug#9031).
1779 * chartab.c (char_table_set_range, map_sub_char_table):
1780 Remove unused locals.
1781 (uniprop_table): Now static.
1782 * composite.c (_work_char): Remove unused static var.
1783
1784 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1785
1786 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1787
1788 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1789
1790 * gtkutil.c (qttip_cb): Remove code without function.
1791
1792 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1793
1794 * w32.c (pthread_sigmask): New stub.
1795
1796 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 Use pthread_sigmask, not sigprocmask (Bug#9010).
1799 sigprocmask is portable only for single-threaded applications, and
1800 Emacs can be multi-threaded when it uses GTK.
1801 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1802 (LIBES): Use it.
1803 * callproc.c (Fcall_process):
1804 * process.c (create_process):
1805 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1806 Use pthread_sigmask, not sigprocmask.
1807
1808 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1809
1810 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1811 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1812 wrong (Bug#8591).
1813
1814 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1815
1816 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1817 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1818 (xg_hide_tooltip): Fix comment.
1819
1820 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1821 in registerServicesMenuSendTypes.
1822 (validRequestorForSendType): Don't check ns_return_types.
1823
1824 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1825 ns_return_type.
1826
1827 2011-07-08 Jason Rumney <jasonr@gnu.org>
1828
1829 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1830 frame struct members of non-existent frames (Bug#6284).
1831
1832 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1833
1834 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1835 variable firstTime not needed on OSX >= 10.6.
1836 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1837 >= 10.5. Use setKnobProportion, setDoubleValue.
1838
1839 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1840 (MAC_OS_X_VERSION_10_5): Define if not defined.
1841 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1842 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1843 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1844
1845 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1846 cString and lossyCString on OSX >= 10.4
1847
1848 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1849 sizeToFit on OSX >= 10.2.
1850
1851 * nsimage.m (allocInitFromFile): Don't use deprecated method
1852 bestRepresentationForDevice on OSX >= 10.6.
1853
1854 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1855 to avoid warning.
1856
1857 * emacs.c: Declare unexec_init_emacs_zone.
1858
1859 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1860
1861 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1862
1863 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1864 on svcsMenu (Bug#8842).
1865
1866 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1867 ns_return_types.
1868 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1869
1870 * nsterm.m (QUTF8_STRING): Declare.
1871 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1872 (validRequestorForSendType): Return type is (id).
1873 Change indexOfObjectIdenticalTo to indexOfObject.
1874 Check if we have local selection before returning self (Bug#8842).
1875 (writeSelectionToPasteboard): Put local selection into paste board
1876 if we have a local selection (Bug#8842).
1877 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1878
1879 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1880 (ns_get_local_selection): Declare.
1881
1882 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1883
1884 * keymap.c (describe_map_tree): Don't insert a double newline at
1885 the end of the buffer (bug#1169) and return whether we inserted
1886 something.
1887
1888 * callint.c (Fcall_interactively): Change "reading args" to
1889 "providing args" to try to clarify what it does (bug#1010).
1890
1891 2011-07-07 Kenichi Handa <handa@m17n.org>
1892
1893 * composite.c (composition_compute_stop_pos): Ignore a static
1894 composition starting before CHARPOS (Bug#8915).
1895
1896 * xdisp.c (handle_composition_prop): Likewise.
1897
1898 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1899
1900 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1901 (Bug#9015)
1902
1903 2011-07-07 Kenichi Handa <handa@m17n.org>
1904
1905 * character.h (unicode_category_t): New enum type.
1906
1907 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1908 (Qchar_code_property_table): New variable.
1909 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1910 (UNIPROP_COMPRESSED_FORM_P): New macros.
1911 (char_table_ascii): Uncompress the compressed values.
1912 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1913 Uncompress the compressed values.
1914 (sub_char_table_ref_and_range): Likewise.
1915 (char_table_ref_and_range): Uncompress the compressed values.
1916 (sub_char_table_set): New arg is_uniprop. Callers changed.
1917 Uncompress the compressed values.
1918 (sub_char_table_set_range): Args changed. Callers changed.
1919 (char_table_set_range): Adjuted for the above change.
1920 (map_sub_char_table): Delete args default_val and parent. Add arg
1921 top. Give decoded values to a Lisp function.
1922 (map_char_table): Adjust for the above change. Give decoded
1923 values to a Lisp function. Gcpro more variables.
1924 (uniprop_table_uncompress)
1925 (uniprop_decode_value_run_length): New functions.
1926 (uniprop_decoder, uniprop_decoder_count): New variables.
1927 (uniprop_get_decoder, uniprop_encode_value_character)
1928 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1929 New functions.
1930 (uniprop_encoder, uniprop_encoder_count): New variables.
1931 (uniprop_get_encoder, uniprop_table)
1932 (Funicode_property_table_internal, Fget_unicode_property_internal)
1933 (Fput_unicode_property_internal): New functions.
1934 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1935 Sunicode_property_table_internal, Sget_unicode_property_internal,
1936 and Sput_unicode_property_internal. Defvar_lisp
1937 char-code-property-alist.
1938
1939 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1940 Vunicode_category_table.
1941
1942 * font.c (font_range): Adjust for the change of
1943 Vunicode_category_table.
1944
1945 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1946
1947 * m/iris4d.h: Remove file, move contents ...
1948 * s/irix6-5.h: ... here.
1949
1950 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 Remove unportable assumption about struct layout (Bug#8884).
1953 * alloc.c (mark_buffer):
1954 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1955 (clone_per_buffer_values): Don't assume that
1956 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1957 This isn't true in general, and it's particularly not true
1958 if Emacs is configured with --with-wide-int.
1959 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1960 New macros, used in the buffer.c change.
1961
1962 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1963
1964 * xsettings.c: Use both GConf and GSettings if both are available.
1965 (store_config_changed_event): Add comment.
1966 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1967 (store_tool_bar_style_changed): New functions.
1968 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1969 (struct xsettings): Move font inside HAVE_XFT.
1970 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1971 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1972 Move inside HAVE_XFT.
1973 (something_changed_gsettingsCB): Rename from something_changedCB.
1974 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1975 also.
1976 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1977 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1978 (something_changed_gconfCB): Rename from something_changedCB.
1979 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1980 (parse_settings): Move check for font inside HAVE_XFT.
1981 (read_settings, apply_xft_settings): Add comment.
1982 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1983 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1984 call store_font_name_changed.
1985 (xft_settings_event): Add comment.
1986 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1987 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1988 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1989 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1990 (xsettings_initialize): Call init_gsettings last.
1991 (xsettings_get_system_font, xsettings_get_system_normal_font):
1992 Add comment.
1993
1994 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1995
1996 Random fixes. E.g., (random) never returned negative values.
1997 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1998 subseconds part to the entropy, as that's a bit more random.
1999 Prefer signed to unsigned, since the signedness doesn't matter and
2000 in general we prefer signed. When given a limit, use a
2001 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2002 latter isn't right if USE_2_TAGS_FOR_INTS.
2003 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2004 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2005
2006 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2007
2008 * textprop.c (text_property_stickiness):
2009 Obey Vtext_property_default_nonsticky.
2010 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2011 * w32fns.c (syms_of_w32fns):
2012 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2013
2014 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2017 This is more efficient than Ffile_directory_p and avoids a minor race.
2018
2019 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2020
2021 * buffer.c (Foverlay_put): Say what the return value is
2022 (bug#7835).
2023
2024 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2025 is a directory before asking whether to use the file name
2026 (bug#7564).
2027 (barf_or_query_if_file_exists): Make the "File is a directory"
2028 error be more correct.
2029
2030 * fns.c (Frequire): Remove the mention of the .gz files, since
2031 that's installation-specific, but keep the mention of
2032 `get-load-suffixes'.
2033
2034 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2037 Report string overflow if the output is too long.
2038
2039 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2040
2041 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2042 (syms_of_gnutls): Remove duplicate DEFSYM for
2043 Qgnutls_bootprop_verify_hostname_error, an error for
2044 Qgnutls_bootprop_verify_error (which is no longer used).
2045
2046 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2047 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2048 Also (re)move comments that are misplaced or no longer relevant.
2049
2050 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2051
2052 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2053
2054 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2055
2056 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2057 and background color parameters if they have been changed.
2058
2059 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2060
2061 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2062
2063 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * xsettings.c (SYSTEM_FONT): Define only when used.
2066 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2067
2068 * keymap.c (access_keymap_1): Now static.
2069
2070 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2071
2072 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2073 leave any prefix arg for the up event (Bug#1586).
2074
2075 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2076
2077 * lread.c (syms_of_lread): Mention single symbols defined by
2078 `defvar' or `defconst' (bug#7154).
2079
2080 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2081 (Frequire): Mention get-load-suffixes.
2082
2083 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2084
2085 * window.h (window): Remove clone_number slot.
2086 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2087 Remove.
2088 (make_parent_window, make_window, saved_window)
2089 (Fset_window_configuration, save_window_save): Don't deal with
2090 clone numbers.
2091 * buffer.c (Qclone_number): Remove declaration.
2092 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2093
2094 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2095
2096 Add multiple inheritance to keymaps.
2097 * keymap.c (Fmake_composed_keymap): New function.
2098 (Fset_keymap_parent): Simplify.
2099 (fix_submap_inheritance): Remove.
2100 (access_keymap_1): New function extracted from access_keymap to handle
2101 embedded parents and handle lists of maps.
2102 (access_keymap): Use it.
2103 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2104 (Fcopy_keymap): Handle embedded parents.
2105 (Fcommand_remapping, define_as_prefix): Simplify.
2106 (Fkey_binding): Simplify.
2107 (syms_of_keymap): Move minibuffer-local-completion-map,
2108 minibuffer-local-filename-completion-map,
2109 minibuffer-local-must-match-map, and
2110 minibuffer-local-filename-must-match-map to Elisp.
2111 (syms_of_keymap): Defsubr make-composed-keymap.
2112 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2113 (parse_menu_item): Trivial simplification.
2114
2115 2011-07-01 Glenn Morris <rgm@gnu.org>
2116
2117 * Makefile.in (SETTINGS_LIBS): Fix typo.
2118
2119 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2120
2121 * coding.c (Fencode_coding_string): Record the last coding system
2122 used, as the function doc string says (bug#8738).
2123
2124 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2125
2126 * xsettings.c (store_monospaced_changed): Take new font as arg and
2127 check for change against current_mono_font.
2128 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2129 (emacs_settings_constructor, emacs_settings_get_property)
2130 (emacs_settings_set_property, emacs_settings_class_init)
2131 (emacs_settings_init, gsettings_obj): Remove.
2132 (something_changedCB): New function for HAVE_GSETTINGS.
2133 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2134 with value as argument.
2135 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2136 g_settings_new (Bug#8967). Do not create gsettings_obj.
2137 Remove calls to g_settings_bind. Connect something_changedCB to
2138 "changed".
2139
2140 * xgselect.c: Add defined (HAVE_GSETTINGS).
2141 (xgselect_initialize): Ditto.
2142
2143 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2144 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2145 xg_select.
2146
2147 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2148
2149 * eval.c (struct backtrace): Simplify and port the data structure.
2150 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2151 signed bit field, as this assumption is not portable and it makes
2152 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2153 "char debug_on_exit : 1" as this is not portable either; instead,
2154 use the portable "unsigned int debug_on_exit : 1". Remove unused
2155 member evalargs. Remove obsolete comments about cc bombing out.
2156
2157 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2158
2159 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2160 Let HAVE_GSETTINGS override HAVE_GCONF.
2161 (store_monospaced_changed): New function.
2162 (EMACS_SETTINGS): A new type derived from GObject to handle
2163 GSettings notifications.
2164 (emacs_settings_constructor, emacs_settings_get_property)
2165 (emacs_settings_set_property, emacs_settings_class_init):
2166 New functions.
2167 (gsettings_client, gsettings_obj): New variables.
2168 (GSETTINGS_SCHEMA): New define.
2169 (something_changedCB): Call store_monospaced_changed.
2170 (init_gsettings): New function.
2171 (xsettings_initialize): Call init_gsettings.
2172 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2173 to NULL.
2174
2175 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2176 GCONF_CFLAGS/LIBS.
2177
2178 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2179
2180 * window.c (resize_root_window, grow_mini_window)
2181 (shrink_mini_window): Rename Qresize_root_window to
2182 Qwindow_resize_root_window and Qresize_root_window_vertically to
2183 Qwindow_resize_root_window_vertically.
2184
2185 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2186
2187 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2188
2189 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2190
2191 * makefile.w32-in: Redesign dependencies so they reflect more
2192 clearly which files are directly included by each source file,
2193 and not through other includes.
2194
2195 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2196
2197 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2198 (sort_overlays, overlay_strings): When an overlay's clone number
2199 matches the window's clone number process the overlay even if
2200 the overlay's window property doesn't match the current window.
2201
2202 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2203 (Fwindow_hchild): Rename to Fwindow_left_child.
2204 (Fwindow_next): Rename to Fwindow_next_sibling.
2205 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2206 (resize_window_check): Rename to window_resize_check.
2207 (resize_window_apply): Rename to window_resize_apply.
2208 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2209 (Fdelete_other_windows_internal, resize_frame_windows)
2210 (Fsplit_window_internal, Fdelete_window_internal)
2211 (grow_mini_window, shrink_mini_window)
2212 (Fresize_mini_window_internal): Fix callers accordingly.
2213
2214 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2215
2216 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2217 (emacs_fixed_set_min_size): Remove.
2218 (emacs_fixed_new): Take frame as argument.
2219
2220 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2221 (_EmacsFixedPrivate): Remove minwidth/height.
2222 Add struct frame *f.
2223 (emacs_fixed_init): Initialize priv->f.
2224 (get_parent_class, emacs_fixed_set_min_size): Remove.
2225 (emacs_fixed_new): Set priv->f to argument.
2226 (emacs_fixed_get_preferred_width)
2227 (emacs_fixed_get_preferred_height): Use min_width/height from
2228 frames size_hint to set minimum and natural (Bug#8919).
2229 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2230 and use min_width/height from frames size_hint to set
2231 min_width/height (Bug#8919).
2232
2233 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2234 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2235 Fix indentation.
2236
2237 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2238
2239 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2240 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2241 called at ZV.
2242
2243 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2244
2245 * process.c (wait_reading_process_output): Bypass select if
2246 waiting for a cell while ignoring keyboard input, and input is
2247 pending. Suggested by Jan Djärv (Bug#8869).
2248
2249 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 Use gnulib's dup2 module instead of rolling our own.
2252 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2253
2254 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2255
2256 * dispnew.c (scrolling_window): Before scrolling, turn off a
2257 mouse-highlight in the window being scrolled.
2258
2259 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2260
2261 Move DEFSYM to lisp.h and use everywhere.
2262
2263 * character.h (DEFSYM): Move declaration...
2264 * lisp.h (DEFSYM): ...here.
2265
2266 * gnutls.c:
2267 * minibuf.c:
2268 * w32menu.c:
2269 * w32proc.c:
2270 * w32select.c: Don't include character.h.
2271
2272 * alloc.c (syms_of_alloc):
2273 * buffer.c (syms_of_buffer):
2274 * bytecode.c (syms_of_bytecode):
2275 * callint.c (syms_of_callint):
2276 * casefiddle.c (syms_of_casefiddle):
2277 * casetab.c (init_casetab_once):
2278 * category.c (init_category_once, syms_of_category):
2279 * ccl.c (syms_of_ccl):
2280 * cmds.c (syms_of_cmds):
2281 * composite.c (syms_of_composite):
2282 * dbusbind.c (syms_of_dbusbind):
2283 * dired.c (syms_of_dired):
2284 * dispnew.c (syms_of_display):
2285 * doc.c (syms_of_doc):
2286 * editfns.c (syms_of_editfns):
2287 * emacs.c (syms_of_emacs):
2288 * eval.c (syms_of_eval):
2289 * fileio.c (syms_of_fileio):
2290 * fns.c (syms_of_fns):
2291 * frame.c (syms_of_frame):
2292 * fringe.c (syms_of_fringe):
2293 * insdel.c (syms_of_insdel):
2294 * keymap.c (syms_of_keymap):
2295 * lread.c (init_obarray, syms_of_lread):
2296 * macros.c (syms_of_macros):
2297 * msdos.c (syms_of_msdos):
2298 * print.c (syms_of_print):
2299 * process.c (syms_of_process):
2300 * search.c (syms_of_search):
2301 * sound.c (syms_of_sound):
2302 * syntax.c (init_syntax_once, syms_of_syntax):
2303 * terminal.c (syms_of_terminal):
2304 * textprop.c (syms_of_textprop):
2305 * undo.c (syms_of_undo):
2306 * w32.c (globals_of_w32):
2307 * window.c (syms_of_window):
2308 * xdisp.c (syms_of_xdisp):
2309 * xfaces.c (syms_of_xfaces):
2310 * xfns.c (syms_of_xfns):
2311 * xmenu.c (syms_of_xmenu):
2312 * xsettings.c (syms_of_xsettings):
2313 * xterm.c (syms_of_xterm): Use DEFSYM.
2314
2315 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2316
2317 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2318
2319 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 Integer and buffer overflow fixes (Bug#8873).
2322
2323 * print.c (printchar, strout): Check for string overflow.
2324 (PRINTPREPARE, printchar, strout):
2325 Don't set size unless allocation succeeds.
2326
2327 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2328 for sizes. Check for string overflow more accurately.
2329 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2330
2331 * macros.c: Integer and buffer overflow fixes.
2332 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2333 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2334 Use ptrdiff_t, not int, for sizes.
2335 Don't increment bufsize until after realloc succeeds.
2336 Check for size-calculation overflow.
2337 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2338
2339 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2340
2341 * lread.c: Integer overflow fixes.
2342 (read_integer): Radix is now EMACS_INT, not int,
2343 to improve quality of diagnostics for out-of-range radices.
2344 Calculate buffer size correctly for out-of-range radices.
2345 (read1): Check for integer overflow in radices, and in
2346 read-circle numbers.
2347 (read_escape): Avoid int overflow.
2348 (Fload, openp, read_buffer_size, read1)
2349 (substitute_object_recurse, read_vector, read_list, map_obarray):
2350 Use ptrdiff_t, not int, for sizes.
2351 (read1): Use EMACS_INT, not int, for sizes.
2352 Check for size overflow.
2353
2354 * image.c (cache_image): Check for size arithmetic overflow.
2355
2356 * lread.c: Integer overflow issues.
2357 (saved_doc_string_size, saved_doc_string_length)
2358 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2359 Now ptrdiff_t, not int.
2360 (read1): Don't assume doc string length fits in int. Check for
2361 out-of-range doc string lengths.
2362 (read_list): Don't assume file position fits in int.
2363 (read_escape): Check for hex character overflow.
2364
2365 2011-06-22 Leo Liu <sdl.web@gmail.com>
2366
2367 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2368 Move to minibuffer.el.
2369
2370 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2371
2372 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2373 The following patches are for when GLYPH_DEBUG && !XASSERT.
2374 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2375 * dispnew.c (flush_stdout):
2376 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2377 Mark as externally visible.
2378 * dispnew.c (check_window_matrix_pointers): Now static.
2379 * dispnew.c (window_to_frame_vpos):
2380 * xfns.c (unwind_create_frame):
2381 * xterm.c (x_check_font): Remove unused local.
2382 * scroll.c (CHECK_BOUNDS):
2383 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2384 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2385 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2386 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2387 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2388 Now static.
2389 (debug_method_add): Use va_list and vsprintf rather than relying
2390 on undefined behavior with wrong number of arguments.
2391 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2392 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2393 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2394 since we're not interested in debugging glyphs with old libraries.
2395 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2396 GCC 4.6.0's static checking.
2397
2398 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 Integer overflow and signedness fixes (Bug#8873).
2401 A few related buffer overrun fixes, too.
2402
2403 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2404
2405 * dispextern.h (struct face.stipple):
2406 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2407 (x_bitmap_mask, x_allocate_bitmap_record)
2408 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2409 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2410 (x_create_bitmap_from_xpm_data):
2411 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2412 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2413 (.bitmaps_last):
2414 * xfaces.c (load_pixmap):
2415 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2416 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2417 (.bitmaps_last, struct x_output.icon_bitmap):
2418 Use ptrdiff_t, not int, for bitmap indexes.
2419 (x_allocate_bitmap_record): Check for size overflow.
2420 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2421
2422 Use ptrdiff_t, not int, for overlay counts.
2423 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2424 * editfns.c (overlays_around, get_pos_property):
2425 * textprop.c (get_char_property_and_overlay):
2426 * xdisp.c (next_overlay_change, note_mouse_highlight):
2427 * xfaces.c (face_at_buffer_position):
2428 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2429 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2430 (Fnext_overlay_change, Fprevious_overlay_change)
2431 (mouse_face_overlay_overlaps, Foverlays_in):
2432 Use ptrdiff_t, not int, for sizes.
2433 (overlays_at, overlays_in): Check for size-calculation overflow.
2434
2435 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2436
2437 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2438 (x_session_initialize): Do not assume string length fits in int.
2439
2440 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2441 This is unlikely, but can occur if DPI is outlandish.
2442
2443 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2444 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2445
2446 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2447 * xrdb.c (magic_file_p, search_magic_path):
2448 Omit last arg SUFFIX; it was always 0. All callers changed.
2449 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2450
2451 * xfont.c (xfont_match): Avoid need for strlen.
2452
2453 * xfns.c: Don't assume strlen fits in int.
2454 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2455
2456 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2457 not unsigned long, as we prefer signed integers. All callers changed.
2458 Detect integer overflow in repeat count.
2459 (message_dolog): Don't assume print length fits in 39 bytes.
2460 (display_mode_element): Don't assume strlen fits in int.
2461
2462 * termcap.c: Don't assume sizes fit in int and never overflow.
2463 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2464 (gobble_line): Check for size-calculation overflow.
2465
2466 * minibuf.c (Fread_buffer):
2467 * lread.c (intern, intern_c_string):
2468 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2469 Don't assume string length fits in int.
2470
2471 * keyboard.c (parse_tool_bar_item):
2472 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2473
2474 * font.c: Don't assume string length fits in int.
2475 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2476 Use ptrdiff_t, not int.
2477 (font_intern_prop): Don't assume string length fits in int.
2478 Don't assume integer property fits in fixnum.
2479 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2480
2481 * filelock.c: Fix some buffer overrun and integer overflow issues.
2482 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2483 Reformulate so as not to need the command string.
2484 Invoke gzip -cd rather than gunzip, as it's more portable.
2485 (lock_info_type, lock_file_1, lock_file):
2486 Don't assume pid_t and time_t fit in unsigned long.
2487 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2488 (current_lock_owner): Prefer signed type for sizes.
2489 Use memcpy, not strncpy, where memcpy is what is really wanted.
2490 Don't assume (via atoi) that time_t and pid_t fit in int.
2491 Check for time_t and/or pid_t out of range, e.g., via a network share.
2492 Don't alloca where an auto var works fine.
2493
2494 * fileio.c: Fix some integer overflow issues.
2495 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2496 Don't assume string length fits in int.
2497 (directory_file_name): Don't assume string length fits in long.
2498 (make_temp_name): Don't assume pid fits in int, or that its print
2499 length is less than 20.
2500
2501 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2502
2503 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2504
2505 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2506
2507 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2508 We prefer signed integers, even for size calculations.
2509
2510 * emacs.c: Don't assume string length fits in 'int'.
2511 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2512 (main): Don't invoke strlen when not needed.
2513
2514 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2515 (XD_DEBUG_MESSAGE): Don't waste a byte.
2516
2517 * callproc.c (getenv_internal_1, getenv_internal)
2518 (Fgetenv_internal):
2519 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2520
2521 * lread.c (invalid_syntax): Omit length argument.
2522 All uses changed. This doesn't fix a bug, but it simplifies the
2523 code away from its former Hollerith-constant appearance, and it's
2524 one less 'int' to worry about when looking at integer-overflow issues.
2525 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2526
2527 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2528 This didn't break anything, but it didn't help either.
2529 It's confusing to put a bogus integer in a place where the actual
2530 value does not matter.
2531 (LIST_END_P): Remove unused macro and its bogus comment.
2532 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2533
2534 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2535 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2536 implementation.
2537 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2538 We prefer signed types, and the value cannot exceed the EMACS_INT
2539 range anyway (because otherwise the length would not be representable).
2540 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2541 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2542 This avoids a GCC warning when WIDE_EMACS_INT.
2543
2544 * indent.c (sane_tab_width): New function.
2545 (current_column, scan_for_column, Findent_to, position_indentation)
2546 (compute_motion): Use it. This is just for clarity.
2547 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2548
2549 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2550
2551 * lisp.h (lint_assume): New macro.
2552 * composite.c (composition_gstring_put_cache):
2553 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2554
2555 * editfns.c, insdel.c:
2556 Omit unnecessary forward decls, to simplify future changes.
2557
2558 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2559
2560 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2561
2562 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2563 Use much-faster test for byte-length change.
2564 Don't assume string byte-length fits in 'int'.
2565 Check that character arg fits in 'int'.
2566 (mapcar1): Declare byte as byte, for clarity.
2567
2568 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2569
2570 * fns.c (concat): Catch string overflow earlier.
2571 Do not rely on integer wraparound.
2572
2573 * dispextern.h (struct it.overlay_strings_charpos)
2574 (struct it.selective): Now EMACS_INT, not int.
2575 * xdisp.c (forward_to_next_line_start)
2576 (back_to_previous_visible_line_start)
2577 (reseat_at_next_visible_line_start, next_element_from_buffer):
2578 Don't arbitrarily truncate the value of 'selective' to int.
2579
2580 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2581
2582 * composite.c: Don't truncate sizes to 'int'.
2583 (composition_gstring_p, composition_reseat_it)
2584 (composition_adjust_point): Use EMACS_INT, not int.
2585 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2586 not EMACS_UINT, for indexes.
2587
2588 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2589
2590 * buffer.c: Include <verify.h>.
2591 (struct sortvec.priority, struct sortstr.priority):
2592 Now EMACS_INT, not int.
2593 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2594 (struct sortstr.size, record_overlay_string)
2595 (struct sortstrlist.size, struct sortlist.used):
2596 Don't truncate size to int.
2597 (record_overlay_string): Check for size-calculation overflow.
2598 (init_buffer_once): Check at compile-time, not run-time.
2599
2600 2011-06-22 Jim Meyering <meyering@redhat.com>
2601
2602 Don't leak an XBM-image-sized buffer
2603 * image.c (xbm_load): Free the image buffer after using it.
2604
2605 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 Port to Sun C.
2608 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2609 that Sun C diagnosed.
2610 * fns.c (secure_hash): Fix pointer signedness issue.
2611 * intervals.c (static_offset_intervals): New function.
2612 (offset_intervals): Use it.
2613
2614 2011-06-21 Leo Liu <sdl.web@gmail.com>
2615
2616 * deps.mk (fns.o):
2617 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2618 sha512.h.
2619
2620 * fns.c (secure_hash): Rename from crypto_hash_function and change
2621 the first arg to accept symbols.
2622 (Fsecure_hash): New primitive.
2623 (syms_of_fns): New symbols.
2624
2625 2011-06-20 Deniz Dogan <deniz@dogan.se>
2626
2627 * process.c (Fset_process_buffer): Clarify return value in
2628 docstring.
2629
2630 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2631
2632 * dispnew.c (add_window_display_history): Use BVAR.
2633
2634 * xdisp.c (debug_method_add): Use BVAR.
2635 (check_window_end, dump_glyph_matrix, dump_glyph)
2636 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2637
2638 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2639 Likewise.
2640
2641 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2642 check till after the cache is created in init_frame_faces.
2643
2644 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2645
2646 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2647
2648 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2649
2650 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2651 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2652 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2653
2654 Improve buffer-overflow checking (Bug#8873).
2655 * fileio.c (Finsert_file_contents):
2656 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2657 Remove the old (too-loose) buffer overflow checks.
2658 They weren't needed, since make_gap checks for buffer overflow.
2659 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2660 The old code merely checked for Emacs fixnum overflow, and relied
2661 on undefined (wraparound) behavior. The new code avoids undefined
2662 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2663
2664 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2665 Tune. Don't use wider integers than needed. Don't use alloca.
2666 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2667
2668 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2669
2670 * insdel.c, lisp.h (buffer_overflow): New function.
2671 (insert_from_buffer_1, replace_range, replace_range_2):
2672 * insdel.c (make_gap_larger):
2673 * editfns.c (Finsert_char):
2674 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2675
2676 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2677
2678 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2679
2680 Integer overflow and signedness fixes (Bug#8873).
2681
2682 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2683 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2684
2685 * fileio.c: Don't assume EMACS_INT fits in off_t.
2686 (emacs_lseek): New static function.
2687 (Finsert_file_contents, Fwrite_region): Use it.
2688 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2689
2690 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2691
2692 * fns.c: Don't overflow int when computing a list length.
2693 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2694 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2695 truncation on 64-bit hosts. Check for QUIT every
2696 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2697 faster and is responsive enough.
2698 (Flength): Report an error instead of overflowing an integer.
2699 (Fsafe_length): Return a float if the value is not representable
2700 as a fixnum. This shouldn't happen except in contrived situations.
2701 (Fnthcdr, Fsort): Don't assume list length fits in int.
2702 (Fcopy_sequence): Don't assume vector length fits in int.
2703
2704 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2705 (header_size, word_size): New constants.
2706 (allocate_vectorlike): Don't check size overflow here.
2707 (allocate_vector): Check it here instead, since this is the only
2708 caller of allocate_vectorlike that could cause overflow.
2709 Check that the new vector's length is representable as a fixnum.
2710
2711 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2712 The previous code was bogus. For example, next_almost_prime (32)
2713 returned 39, which is undesirable as it is a multiple of 3; and
2714 next_almost_prime (24) returned 25, which is a multiple of 5 so
2715 why was the code bothering to check for multiples of 7?
2716
2717 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2718
2719 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2720
2721 Variadic C functions now count arguments with ptrdiff_t.
2722 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2723 Back then I didn't know that the Emacs coding style prefers signed int.
2724 Also, in the meantime I found a few more instances where arguments
2725 were being counted with int, which may truncate counts on 64-bit
2726 machines, or EMACS_INT, which may be unnecessarily wide.
2727 * lisp.h (struct Lisp_Subr.function.aMANY)
2728 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2729 Arg counts are now ptrdiff_t, not size_t.
2730 All variadic functions and their callers changed accordingly.
2731 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2732 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2733 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2734 * callint.c (Fcall_interactively): Check arg count for overflow,
2735 to avoid potential buffer overrun. Use signed char, not 'int',
2736 for 'varies' array, so that we needn't bother to check its size
2737 calculation for overflow.
2738 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2739 * eval.c (apply_lambda):
2740 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2741 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2742 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2743
2744 * callint.c (Fcall_interactively): Don't use index var as event count.
2745
2746 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2747 * mem-limits.h (SIZE): Remove; no longer used.
2748
2749 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2750
2751 Remove unnecessary casts.
2752 * xterm.c (x_term_init):
2753 * xfns.c (x_set_border_pixel):
2754 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2755 These aren't needed now that we assume ANSI C.
2756
2757 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2758 It's more likely to cause problems (due to unsigned overflow)
2759 than to cure them.
2760
2761 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2762
2763 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2764
2765 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2766
2767 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2768
2769 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2770
2771 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2772
2773 GLYPH_CODE_FACE returns EMACS_INT, not int.
2774 * dispextern.h (merge_faces):
2775 * xfaces.c (merge_faces):
2776 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2777 Don't assume EMACS_INT fits in int.
2778
2779 * character.h (CHAR_VALID_P): Remove unused parameter.
2780 * fontset.c, lisp.h, xdisp.c: All uses changed.
2781
2782 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2783
2784 * fns.c (concat): Minor tuning based on overflow analysis.
2785 This doesn't fix any bugs. Use int to hold character, instead
2786 of constantly refetching from Emacs object. Use XFASTINT, not
2787 XINT, for value known to be a character. Don't bother comparing
2788 a single byte to 0400, as it's always less.
2789
2790 * floatfns.c (Fexpt):
2791 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2792
2793 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2794 for characters.
2795
2796 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2797
2798 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2799 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2800 incorrectly succeed when S was a string, because 4294967386 was
2801 truncated before it was used.
2802
2803 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2804 Otherwise, an out-of-range integer could cause undefined behavior
2805 on a 64-bit host.
2806
2807 * composite.c: Use int, not EMACS_INT, for characters.
2808 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2809 EMACS_INT, for values that are known to be in character range.
2810 This doesn't fix any bugs but is the usual style inside Emacs and
2811 may generate better code on 32-bit machines.
2812
2813 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2814 This is for reasons similar to the recent CHAR_STRING fix.
2815 * charset.c (Fencode_char): Check that character arg is actually
2816 a character. Pass an int to ENCODE_CHAR.
2817 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2818 wider than 'int', as a compile-time check to prevent future regressions
2819 in this area.
2820
2821 * character.c (char_string): Remove unnecessary casts.
2822
2823 Make sure a 64-bit char is never passed to CHAR_STRING.
2824 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2825 by silently ignoring the top 32 bits, allowing some values
2826 that were far too large to be valid characters.
2827 * character.h: Include <verify.h>.
2828 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2829 arguments are no wider than unsigned, as a compile-time check
2830 to prevent future regressions in this area.
2831 * data.c (Faset):
2832 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2833 (Fsubst_char_in_region):
2834 * fns.c (concat):
2835 * xdisp.c (decode_mode_spec_coding):
2836 Adjust to CHAR_STRING's new requirement.
2837 * editfns.c (Finsert_char, Fsubst_char_in_region):
2838 * fns.c (concat): Check that character args are actually
2839 characters. Without this test, these functions did the wrong
2840 thing with wildly out-of-range values on 64-bit hosts.
2841
2842 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2843 These casts should not be needed on 32-bit hosts, either.
2844 * keyboard.c (read_char):
2845 * lread.c (Fload): Remove casts to unsigned.
2846
2847 * lisp.h (UNSIGNED_CMP): New macro.
2848 This fixes comparison bugs on 64-bit hosts.
2849 (ASCII_CHAR_P): Use it.
2850 * casefiddle.c (casify_object):
2851 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2852 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2853 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2854 * dispextern.h (FACE_FROM_ID):
2855 * keyboard.c (read_char): Use UNSIGNED_CMP.
2856
2857 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2858 not to EMACS_INT, to avoid GCC warning.
2859
2860 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2861
2862 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2863 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2864 isn't needed on 32-bit machines.
2865
2866 * buffer.c (Fgenerate_new_buffer_name):
2867 Use EMACS_INT for count, not int.
2868 (advance_to_char_boundary): Return EMACS_INT, not int.
2869
2870 * data.c (Qcompiled_function): Now static.
2871
2872 * window.c (window_body_lines): Now static.
2873
2874 * image.c (gif_load): Rename local to avoid shadowing.
2875
2876 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2877 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2878 * alloc.c (make_save_value): Integer argument is now of type
2879 ptrdiff_t, not int.
2880 (mark_object): Use ptrdiff_t, not int.
2881 * lisp.h (pD): New macro.
2882 * print.c (print_object): Use it.
2883
2884 * alloc.c: Use EMACS_INT, not int, to count objects.
2885 (total_conses, total_markers, total_symbols, total_vector_size)
2886 (total_free_conses, total_free_markers, total_free_symbols)
2887 (total_free_floats, total_floats, total_free_intervals)
2888 (total_intervals, total_strings, total_free_strings):
2889 Now EMACS_INT, not int. All uses changed.
2890 (Fgarbage_collect): Compute overall total using a double, so that
2891 integer overflow is less likely to be a problem. Check for overflow
2892 when converting back to an integer.
2893 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2894 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2895 These were 'int' variables that could overflow on 64-bit hosts;
2896 they were never used, so remove them instead of repairing them.
2897 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2898 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2899 Previously, this ceilinged at INT_MAX, but that doesn't work on
2900 64-bit machines.
2901 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2902
2903 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2904 (allocate_vectorlike): Check for ptrdiff_t overflow.
2905 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2906 when a (possibly-narrower) signed value would do just as well.
2907 We prefer using signed arithmetic, to avoid comparison confusion.
2908
2909 * alloc.c: Catch some string size overflows that we were missing.
2910 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2911 for convenience in STRING_BYTES_MAX.
2912 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2913 The definition here is exact; the one in lisp.h was approximate.
2914 (allocate_string_data): Check for string overflow. This catches
2915 some instances we weren't catching before. Also, it catches
2916 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2917 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2918 and ptrdiff_t and EMACS_INT are both 64 bits.
2919
2920 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2921 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2922 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2923
2924 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2925
2926 * alloc.c (Fmake_string): Check for out-of-range init.
2927
2928 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2929
2930 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2931
2932 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2933
2934 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2935 xg_get_default_scrollbar_width.
2936
2937 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2938 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2939 (style_changed_cb): Call update_theme_scrollbar_width and call
2940 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2941 all frames (Bug#8505).
2942 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2943 Call gtk_window_set_resizable if HAVE_GTK3.
2944 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2945 and height if HAVE_GTK3 (Bug#8505).
2946 (scroll_bar_width_for_theme): New variable.
2947 (update_theme_scrollbar_width): New function.
2948 (xg_get_default_scrollbar_width): Move code to
2949 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2950 (xg_initialize): Call update_theme_scrollbar_width.
2951
2952 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2953
2954 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2955
2956 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2957
2958 * frame.c (make_frame): Call other_buffer_safely instead of
2959 other_buffer.
2960
2961 * window.c (temp_output_buffer_show): Call display_buffer with
2962 second argument Vtemp_buffer_show_specifiers and reset latter
2963 immediately after the call.
2964 (Vtemp_buffer_show_specifiers): New variable.
2965 (auto_window_vscroll_p, next_screen_context_lines)
2966 (Vscroll_preserve_screen_position): Remove leading asterisks from
2967 doc-strings.
2968
2969 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2970
2971 Fix minor problems found by GCC 4.6.0 static checking.
2972 * buffer.c (Qclone_number): Remove for now, as it's unused.
2973 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2974 (record_buffer): Remove unused local.
2975 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2976 (set_frame_buffer_list): Remove; unused.
2977 * frame.h (other_visible_frames): Remove decl.
2978 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2979 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2980 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2981 if HAVE_GPM.
2982 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2983 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2984 Define only if HAVE_GPM.
2985 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2986 (update_hints_inhibit): Remove; never set. All uses removed.
2987 * widgetprv.h (emacsFrameClassRec): Remove decl.
2988 * window.c (delete_deletable_window): Now returns void, since it
2989 wasn't returning anything.
2990 (compare_window_configurations): Remove unused locals.
2991 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2992 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2993 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2994 the same widths as pointers. This follows up on the 2011-05-06 patch.
2995 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2996 * xterm.h: Likewise.
2997 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2998
2999 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3000
3001 * makefile.w32-in: Update dependencies.
3002 (LISP_H): Add lib/intprops.h.
3003
3004 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3005
3006 * image.c (gif_load): Add animation frame delay to the metadata.
3007 (syms_of_image): Use DEFSYM. New symbol `delay'.
3008
3009 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3010
3011 * window.c (delete_deletable_window): Re-add.
3012 (Fset_window_configuration): Rewrite to handle dead buffers and
3013 consequently deletable windows.
3014 (window_tree, Fwindow_tree): Remove. Supply functionality in
3015 window.el.
3016 (compare_window_configurations): Simplify code.
3017
3018 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3019
3020 * image.c (imagemagick_load_image): Fix type mismatch.
3021 (Fimagemagick_types): Likewise.
3022
3023 * window.h (replace_buffer_in_windows): Declare.
3024
3025 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3026
3027 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3028 Qclone_number. Remove external declaration of Qdelete_window.
3029 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3030 code.
3031 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3032 Run Qbuffer_list_update_hook if allowed.
3033 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3034 buffer list implementation.
3035 (other_buffer_safely): New function.
3036 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3037 calls to replace_buffer_in_windows and
3038 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3039 if allowed.
3040 (record_buffer): Inhibit quitting and rewrite using quittable
3041 functions. Run Qbuffer_list_update_hook if allowed.
3042 (Frecord_buffer, Funrecord_buffer): New functions.
3043 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3044 Move switch-to-buffer to window.el.
3045 (bury-buffer): Move to window.el.
3046 (Vbuffer_list_update_hook): New variable.
3047
3048 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3049 section.
3050
3051 * window.h (resize_frame_windows): Move up in code.
3052 (Fwindow_frame): Remove EXFUN.
3053 (replace_buffer_in_all_windows): Remove prototype.
3054 (replace_buffer_in_windows_safely): Add prototype.
3055
3056 * window.c: Declare Qdelete_window static again. Move down
3057 declaration of select_count.
3058 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3059 (Fother_window): Move to window.el.
3060 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3061 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3062 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3063 window.el.
3064 (replace_buffer_in_windows): Implement by calling
3065 Qreplace_buffer_in_windows.
3066 (replace_buffer_in_all_windows): Remove with some functionality
3067 moved into replace_buffer_in_windows_safely.
3068 (replace_buffer_in_windows_safely): New function.
3069 (select_window_norecord, select_frame_norecord): Move in front
3070 of run_window_configuration_change_hook. Remove now obsolete
3071 declarations.
3072 (Fset_window_buffer): Rewrite doc-string.
3073 Call Qrecord_window_buffer.
3074 (keys_of_window): Move binding for other-window to window.el.
3075
3076 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3077
3078 * dispextern.h (struct image): Replace data member, whose int_val
3079 and ptr_val fields were not used by anything, with a single
3080 lisp_val object.
3081
3082 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3083 (gif_clear_image, gif_load, imagemagick_load_image)
3084 (gs_clear_image, gs_load): Callers changed.
3085
3086 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 * buffer.h: Include <time.h>, for time_t.
3089 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3090
3091 Fix minor problems found by static checking.
3092
3093 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3094
3095 Make identifiers static if they are not used in other modules.
3096 * data.c (Qcompiled_function, Qframe, Qvector):
3097 * image.c (QimageMagick, Qsvg):
3098 * minibuf.c (Qmetadata):
3099 * window.c (resize_window_check, resize_root_window): Now static.
3100 * window.h (resize_window_check, resize_root_window): Remove decls.
3101
3102 * window.c (window_deletion_count, delete_deletable_window):
3103 Remove; unused.
3104 (window_body_lines): Now static.
3105 (Fdelete_other_windows_internal): Mark vars as initialized.
3106 Make sure 'resize_failed' is initialized.
3107 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3108 (resize_window_apply): Remove unused local.
3109 * window.h (delete_deletable_window): Remove decl.
3110
3111 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3112 (imagemagick_load_image): Fix pointer signedness problem by changing
3113 last arg from unsigned char * to char *. All uses changed.
3114 Also, fix a local for similar reasons.
3115 Remove unused locals. Remove locals to avoid shadowing.
3116 (fn_rsvg_handle_free): Remove; unused.
3117 (svg_load, svg_load_image): Fix pointer signedness problem.
3118 (imagemagick_load_image): Don't use garbage pointer image_wand.
3119
3120 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3121
3122 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3123
3124 * image.c (gif_load): Fix omitted cast error introduced by
3125 2011-06-06 change.
3126
3127 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3128
3129 * window.h (resize_proportionally, orig_total_lines)
3130 (orig_top_line): Remove from window structure.
3131 (set_window_height, set_window_width, change_window_heights)
3132 (Fdelete_window): Remove prototypes.
3133 (resize_frame_windows): Remove duplicate declaration.
3134
3135 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3136
3137 * window.h (resize_frame_windows, resize_window_check)
3138 (delete_deletable_window, resize_root_window)
3139 (resize_frame_windows): Declare prototypes.
3140
3141 * window.c (resize_window_apply): Make definition be "static" to
3142 match the prototype.
3143
3144 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3145
3146 * window.c: Remove declarations of Qwindow_size_fixed,
3147 window_min_size_1, window_min_size_2, window_min_size,
3148 size_window, window_fixed_size_p, enlarge_window, delete_window.
3149 Remove static from declaration of Qdelete_window, it's
3150 temporarily needed by Fbury_buffer.
3151 (replace_window): Don't assign orig_top_line and
3152 orig_total_lines.
3153 (Fdelete_window, delete_window): Remove. Window deletion is
3154 handled by window.el.
3155 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3156 Replace Fdelete_window calls with calls to Qdelete_window.
3157 (Fdelete_other_windows): Remove. Deleting other windows is
3158 handled by window.el.
3159 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3160 handled in window.el.
3161 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3162 Window minimum sizes are handled in window.el.
3163 (shrink_windows, size_window, set_window_height)
3164 (set_window_width, change_window_heights, window_height)
3165 (window_width, CURBEG, CURSIZE, enlarge_window)
3166 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3167 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3168 handled in window.el.
3169 (make_dummy_parent): Rename to make_parent_window and give it a
3170 second argument horflag.
3171 (make_window): Don't set resize_proportionally any more.
3172 (Fsplit_window): Remove. Windows are split in window.el.
3173 (save_restore_action, save_restore_orig_size)
3174 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3175 Resize mini windows in window.el.
3176 (grow_mini_window, shrink_mini_window): Implement by calling
3177 Qresize_root_window_vertically, resize_window_check and
3178 resize_window_apply.
3179 (saved_window, Fset_window_configuration, save_window_save):
3180 Do not handle orig_top_line, orig_total_lines, and
3181 resize_proportionally.
3182 (window_min_height, window_min_width): Move to window.el.
3183 (keys_of_window): Move bindings for delete-other-windows,
3184 split-window, delete-window and enlarge-window to window.el.
3185
3186 * buffer.c: Temporarily extern Qdelete_window.
3187 (Fbury_buffer): Temporarily call Qdelete_window instead of
3188 Fdelete_window (Fbury_buffer will move to window.el soon).
3189
3190 * frame.c (set_menu_bar_lines_1): Remove code handling
3191 orig_top_line and orig_total_lines.
3192
3193 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3194 set_window_height but set heights directly.
3195 (change_frame_size_1): Use resize_frame_windows.
3196
3197 * xdisp.c (init_xdisp): Don't use set_window_height but set
3198 heights directly.
3199
3200 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3201 Use resize_frame_windows instead of change_window_heights and run
3202 run_window_configuration_change_hook.
3203
3204 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3205 instead of change_window_heights and run
3206 run_window_configuration_change_hook.
3207
3208 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3209
3210 * window.c (replace_window): Rename second argument REPLACEMENT to
3211 NEW. New third argument SETFLAG. Rewrite.
3212 (delete_window, make_dummy_parent): Call replace_window with
3213 third argument 1.
3214 (window_list_1): Move down in code.
3215 (run_window_configuration_change_hook): Move set_buffer part
3216 before select_frame_norecord part in order to unwind correctly.
3217 Rename count1 to count.
3218 (recombine_windows, delete_deletable_window, resize_root_window)
3219 (Fdelete_other_windows_internal)
3220 (Frun_window_configuration_change_hook, make_parent_window)
3221 (resize_window_check, resize_window_apply, Fresize_window_apply)
3222 (resize_frame_windows, Fsplit_window_internal)
3223 (Fdelete_window_internal, Fresize_mini_window_internal):
3224 New functions.
3225 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3226
3227 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3228
3229 * window.h (window): Add some new members to window structure -
3230 normal_lines, normal_cols, new_total, new_normal, clone_number,
3231 splits, nest, prev_buffers, next_buffers.
3232 (WINDOW_TOTAL_SIZE): Move here from window.c.
3233 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3234
3235 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3236 Remove.
3237 (make_dummy_parent): Set new members of windows structure.
3238 (make_window): Move down in code. Handle new members of window
3239 structure.
3240 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3241 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3242 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3243 (Fset_window_prev_buffers, Fwindow_next_buffers)
3244 (Fset_window_next_buffers, Fset_window_clone_number):
3245 New functions.
3246 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3247 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3248 Doc-string fixes.
3249 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3250 Argument WINDOW can be now internal window too.
3251 (Fwindow_use_time): Move up in code.
3252 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3253 Rewrite doc-string.
3254 (Fset_window_configuration, saved_window)
3255 (Fcurrent_window_configuration, save_window_save): Handle new
3256 members of window structure.
3257 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3258 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3259 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3260 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3261 Qget_mru_window, Qresize_root_window,
3262 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3263 Qauto_buffer_name; staticpro them.
3264
3265 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3266
3267 * window.c (Fwindow_total_size, Fwindow_left_column)
3268 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3269 (Fwindow_list_1): New functions.
3270 (window_box_text_cols): Replace with window_body_cols.
3271 (Fwindow_width, Fscroll_left, Fscroll_right):
3272 Use window_body_cols instead of window_box_text_cols.
3273 (delete_window, Fset_window_configuration):
3274 Call delete_all_subwindows with window as argument.
3275 (delete_all_subwindows): Take a window as argument and not a
3276 structure. Rewrite.
3277 (window_loop): Remove handling of GET_LRU_WINDOW and
3278 GET_LARGEST_WINDOW.
3279 (Fget_lru_window, Fget_largest_window): Move to window.el.
3280
3281 * window.h: Extern window_body_cols instead of
3282 window_box_text_cols. delete_all_subwindows now takes a
3283 Lisp_Object as argument.
3284
3285 * indent.c (compute_motion, Fcompute_motion):
3286 Use window_body_cols instead of window_box_text_cols.
3287
3288 * frame.c (delete_frame): Call delete_all_subwindows with root
3289 window as argument.
3290
3291 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3292
3293 * fns.c (Fputhash): Document return value.
3294
3295 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3296
3297 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3298
3299 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 Cons<->int and similar integer overflow fixes (Bug#8794).
3302
3303 Check for overflow when converting integer to cons and back.
3304 * charset.c (Fdefine_charset_internal, Fdecode_char):
3305 Use cons_to_unsigned to catch overflow.
3306 (Fencode_char): Use INTEGER_TO_CONS.
3307 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3308 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3309 * data.c (long_to_cons, cons_to_long): Remove.
3310 (cons_to_unsigned, cons_to_signed): New functions.
3311 These signal an error for invalid or out-of-range values.
3312 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3313 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3314 * font.c (Ffont_variation_glyphs):
3315 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3316 * lisp.h: Include <intprops.h>.
3317 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3318 (cons_to_signed, cons_to_unsigned): New decls.
3319 (long_to_cons, cons_to_long): Remove decls.
3320 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3321 (Fprimitive_undo): Use CONS_TO_INTEGER.
3322 * xfns.c (Fx_window_property): Likewise.
3323 * xselect.c: Include <limits.h>.
3324 (x_own_selection, selection_data_to_lisp_data):
3325 Use INTEGER_TO_CONS.
3326 (x_handle_selection_request, x_handle_selection_clear)
3327 (x_get_foreign_selection, Fx_disown_selection_internal)
3328 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3329 (lisp_data_to_selection_data): Use cons_to_unsigned.
3330 (x_fill_property_data): Use cons_to_signed.
3331 Report values out of range.
3332
3333 Check for buffer and string overflow more precisely.
3334 * buffer.h (BUF_BYTES_MAX): New macro.
3335 * lisp.h (STRING_BYTES_MAX): New macro.
3336 * alloc.c (Fmake_string):
3337 * character.c (string_escape_byte8):
3338 * coding.c (coding_alloc_by_realloc):
3339 * doprnt.c (doprnt):
3340 * editfns.c (Fformat):
3341 * eval.c (verror):
3342 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3343 since they may not be the same number.
3344 * editfns.c (Finsert_char):
3345 * fileio.c (Finsert_file_contents):
3346 Likewise for BUF_BYTES_MAX.
3347
3348 * image.c: Use ptrdiff_t, not int, for sizes.
3349 (slurp_file): Switch from int to ptrdiff_t.
3350 All uses changed.
3351 (slurp_file): Check that file size fits in both size_t (for
3352 malloc) and ptrdiff_t (for sanity and safety).
3353
3354 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3355 if b->modtime has its maximal value.
3356
3357 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3358
3359 Don't assume time_t can fit into int.
3360 * buffer.h (struct buffer.modtime): Now time_t, not int.
3361 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3362 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3363
3364 Minor fixes for signed vs unsigned integers.
3365 * character.h (MAYBE_UNIFY_CHAR):
3366 * charset.c (maybe_unify_char):
3367 * keyboard.c (read_char, reorder_modifiers):
3368 XINT -> XFASTINT, since the integer must be nonnegative.
3369 * ftfont.c (ftfont_spec_pattern):
3370 * keymap.c (access_keymap, silly_event_symbol_error):
3371 XUINT -> XFASTINT, since the integer must be nonnegative.
3372 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3373 since it makes no difference and we prefer signed.
3374 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3375 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3376 nonnegative.
3377
3378 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3379
3380 * window.h (Fwindow_frame): Declare.
3381
3382 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3385 (SPARE_MEMORY): Always define.
3386 (LARGE_REQUEST): Remove.
3387 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3388
3389 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3390
3391 * lisp.h: Move EXFUNS for Fframe_root_window,
3392 Fframe_first_window and Fset_frame_selected_window to window.h.
3393
3394 * window.h: Move EXFUNS for Fframe_root_window,
3395 Fframe_first_window and Fset_frame_selected_window here from
3396 lisp.h.
3397
3398 * frame.c (Fwindow_frame, Fframe_first_window)
3399 (Fframe_root_window, Fframe_selected_window)
3400 (Fset_frame_selected_window): Move to window.c.
3401 (Factive_minibuffer_window): Move to minibuf.c.
3402 (Fother_visible_frames_p): New function.
3403
3404 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3405
3406 * window.c (decode_window, decode_any_window): Move up in code.
3407 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3408 (inhibit_frame_unsplittable): Remove unused variable.
3409 (Fwindow_buffer): Move up and rewrite doc-string.
3410 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3411 (Fwindow_prev): New functions.
3412 (Fwindow_frame): Move here from frame.c. Accept any window as
3413 argument.
3414 (Fframe_root_window, Fframe_first_window)
3415 (Fframe_selected_window): Move here from frame.c. Accept frame
3416 or arbitrary window as argument. Update doc-strings.
3417 (Fminibuffer_window): Move up in code.
3418 (Fwindow_minibuffer_p): Move up in code and simplify.
3419 (Fset_frame_selected_window): Move here from frame.c.
3420 Marginal rewrite.
3421 (Fselected_window, select_window, Fselect_window): Move up in
3422 code. Minor doc-string fixes.
3423
3424 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3427 Do not assume that spare memory exists; that assumption is valid
3428 only if SYSTEM_MALLOC.
3429 (LARGE_REQUEST): New macro, so that the issue of large requests
3430 is separated from the issue of spare memory.
3431
3432 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3433
3434 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3435 format. (Bug#8806)
3436
3437 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3438
3439 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3440 before statements.
3441
3442 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3443
3444 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3445
3446 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3447
3448 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3449 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3450
3451 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3452
3453 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3454
3455 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3456
3457 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3458 (x_clipboard_manager_save): Add return value.
3459 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3460 New error handlers.
3461 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3462 Obey Vx_select_enable_clipboard_manager. Catch errors in
3463 x_clipboard_manager_save (Bug#8779).
3464 (Vx_select_enable_clipboard_manager): New variable.
3465 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3466
3467 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3468
3469 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3470
3471 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3472
3473 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3474 in the current matrix if keep_current_p is non-zero.
3475
3476 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3477
3478 * bidi.c (bidi_level_of_next_char): Fix last change.
3479
3480 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3481
3482 Support bidi reordering of text covered by display properties.
3483
3484 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3485 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3486 (bidi_cache_search, bidi_cache_iterator_state)
3487 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3488 (bidi_level_of_next_char, bidi_move_to_visually_next):
3489 Support character positions inside a run of characters covered by a
3490 display string.
3491 (bidi_paragraph_init, bidi_resolve_explicit_1)
3492 (bidi_level_of_next_char): Call bidi_fetch_char and
3493 bidi_fetch_char_advance instead of FETCH_CHAR and
3494 FETCH_CHAR_ADVANCE.
3495 (bidi_init_it): Initialize new members.
3496 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3497 definitions.
3498 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3499 instead of using explicit *_CHAR codes.
3500 (bidi_resolve_explicit, bidi_resolve_weak):
3501 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3502 bidirectional text is supported only in multibyte buffers.
3503 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3504 it to initialize the frame_window_p member of struct bidi_it.
3505 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3506 (bidi_resolve_explicit, bidi_resolve_weak)
3507 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3508 bidi_it->nchars is non-positive.
3509 (bidi_level_of_next_char): Don't try to lookup the cache for the
3510 next/previous character if nothing is cached there yet, or if we
3511 were just reseat()'ed to a new position.
3512
3513 * xdisp.c (set_cursor_from_row): Set start and stop points
3514 according to the row's direction when priming the loop that looks
3515 for the glyph on which to display cursor.
3516 (single_display_spec_intangible_p): Function deleted.
3517 (display_prop_intangible_p): Reimplement to call
3518 handle_display_spec instead of single_display_spec_intangible_p.
3519 Accept 3 additional arguments needed by handle_display_spec.
3520 This fixes incorrect cursor motion across display property with complex
3521 values: lists, `(when COND...)' forms, etc.
3522 (single_display_spec_string_p): Support property values that are
3523 lists with the argument STRING its top-level element.
3524 (display_prop_string_p): Fix the condition for processing a
3525 property that is a list to be consistent with handle_display_spec.
3526 (handle_display_spec): New function, refactored from the
3527 last portion of handle_display_prop.
3528 (compute_display_string_pos): Accept additional argument
3529 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3530 value of a `display' property is a "replacing spec".
3531 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3532 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3533 the display property, but just return a value indicating whether
3534 the display property will replace the characters it covers.
3535 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3536 frame_window_p members of struct bidi_it.
3537 (compute_display_string_pos, compute_display_string_end):
3538 New functions.
3539 (push_it): Accept second argument POSITION, where pop_it should
3540 jump to continue iteration.
3541 (reseat_1): Initialize bidi_it.disp_pos.
3542
3543 * keyboard.c (adjust_point_for_property): Adjust the call to
3544 display_prop_intangible_p to its new signature.
3545
3546 * dispextern.h (struct bidi_it): New member frame_window_p.
3547 (bidi_init_it): Update prototypes.
3548 (display_prop_intangible_p): Update prototype.
3549 (compute_display_string_pos, compute_display_string_end):
3550 Declare prototypes.
3551 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3552 EMACS_INT.
3553
3554 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 Malloc failure behavior now depends on size of allocation.
3557 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3558 * lisp.h: Change signatures accordingly.
3559 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3560 All callers changed. (Bug#8762)
3561
3562 * gnutls.c: Use Emacs's memory allocators.
3563 Without this change, the gnutls library would invoke malloc etc.
3564 directly, which causes problems on non-SYNC_INPUT hosts, and which
3565 runs afoul of improving memory_full behavior. (Bug#8761)
3566 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3567 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3568 xfree instead of the default malloc, realloc, free.
3569 (Fgnutls_boot): No need to check for memory allocation failure,
3570 since xmalloc does that for us.
3571
3572 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3573 * category.c (hash_get_category_set):
3574 * ccl.c (ccl_driver):
3575 * charset.c (Fdefine_charset_internal):
3576 * charset.h (struct charset.hash_index):
3577 * composite.c (get_composition_id, gstring_lookup_cache)
3578 (composition_gstring_put_cache):
3579 * composite.h (struct composition.hash_index):
3580 * dispextern.h (struct image.hash):
3581 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3582 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3583 (hashfn_equal, hashfn_user_defined, make_hash_table)
3584 (maybe_resize_hash_table, hash_lookup, hash_put)
3585 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3586 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3587 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3588 * image.c (make_image, search_image_cache, lookup_image)
3589 (xpm_put_color_table_h):
3590 * lisp.h (struct Lisp_Hash_Table):
3591 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3592 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3593 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3594 * alloc.c (allocate_vectorlike):
3595 Check for overflow in vector size calculations.
3596 * ccl.c (ccl_driver):
3597 Check for overflow when converting EMACS_INT to int.
3598 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3599 need to be updated by these changes.
3600 * fns.c (make_hash_table, maybe_resize_hash_table):
3601 Check for integer overflow with large hash tables.
3602 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3603 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3604 (SXHASH_REDUCE): New macro.
3605 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3606 Use it instead of discarding useful hash info with large hash values.
3607 (sxhash_float): New function.
3608 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3609 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3610 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3611 Rewrite to use FIXNUM_BITS, as this simplifies things.
3612 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3613 Adjust signatures to match updated version of code.
3614 (consing_since_gc): Now EMACS_INT, since a single hash table can
3615 use more than INT_MAX bytes.
3616
3617 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3618
3619 Make it possible to build with GCC-4.6+ -O2 -flto.
3620
3621 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3622
3623 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3624
3625 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3626 Call minibuffer-inactive-mode.
3627
3628 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3629
3630 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3631 Update dependencies.
3632
3633 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3634
3635 * data.c (init_data): Remove code for UTS, this system is not
3636 supported anymore.
3637
3638 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3639
3640 Don't force ./temacs to start in terminal mode.
3641
3642 * frame.c (make_initial_frame): Initialize faces in all cases, not
3643 only when CANNOT_DUMP is defined.
3644 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3645
3646 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3647
3648 * dispnew.c (add_window_display_history): Use const for the string
3649 pointer. Remove declaration, not needed.
3650
3651 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 Use 'inline', not 'INLINE'.
3654 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3655 * alloc.c, fontset.c (INLINE): Remove.
3656 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3657 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3658 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3659 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3660 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3661
3662 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3663
3664 Make it possible to run ./temacs.
3665
3666 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3667 syms_of_callproc does the same thing. Remove test for
3668 "initialized", do it in the caller.
3669 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3670
3671 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3672
3673 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3674 (read_minibuf): Use get_minibuffer.
3675 (syms_of_minibuf): Use DEFSYM.
3676 (Qmetadata): New var.
3677 * data.c (Qbuffer): Don't make it static.
3678 (syms_of_data): Use DEFSYM.
3679
3680 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3681
3682 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3683 (CCL_CODE_MIN): New macro.
3684
3685 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3686
3687 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3688
3689 * eval.c (Qdebug): Now static.
3690 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3691 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3692 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3693
3694 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3695
3696 * image.c: Various fixes to ImageMagick code comments.
3697 (Fimagemagick_types): Doc fix.
3698
3699 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3700
3701 Minor fixes prompted by GCC 4.6.0 warnings.
3702
3703 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3704
3705 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3706 (x_clipboard_manager_save_all): Move extern decl to ...
3707 * xterm.h: ... here, so that it can be checked for consistency.
3708
3709 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3710
3711 * xselect.c (x_clipboard_manager_save_frame)
3712 (x_clipboard_manager_save_all): New functions.
3713 (Fx_clipboard_manager_save): Lisp function deleted.
3714
3715 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3716 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3717
3718 * xterm.h: Update prototype.
3719
3720 2011-05-28 William Xu <william.xwl@gmail.com>
3721
3722 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3723 exiting (Bug#8239).
3724
3725 2011-05-28 Jim Meyering <meyering@redhat.com>
3726
3727 Avoid a sign-extension bug in crypto_hash_function.
3728 * fns.c (to_uchar): Define.
3729 (crypto_hash_function): Use it to convert some newly-signed
3730 variables to unsigned, to avoid sign-extension bugs. For example,
3731 without this change, (md5 "truc") would evaluate to
3732 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3733 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3734 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3735
3736 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3737
3738 Integer overflow fixes.
3739
3740 * dbusbind.c: Serial number integer overflow fixes.
3741 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3742 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3743 to hold a serial number that is too large for a fixnum.
3744 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3745 Check for serial numbers out of range. Decode any serial number
3746 that was so large that it became a float. (Bug#8722)
3747
3748 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3749 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3750 Use XFASTINT rather than XUINT when numbers are nonnegative.
3751 (xd_append_arg, Fdbus_method_return_internal):
3752 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3753 arguments, check that Lisp number is nonnegative, rather than
3754 silently wrapping negative numbers around. (Bug#8722)
3755 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3756 (Bug#8722)
3757
3758 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3759
3760 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3761
3762 ccl: add integer overflow checks
3763 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3764 (IN_INT_RANGE): New macros.
3765 (ccl_driver): Use them to check for integer overflow when
3766 decoding a CCL program. Many of the new checks are whether XINT (x)
3767 fits in int; it doesn't always, on 64-bit hosts. The new version
3768 doesn't catch all possible integer overflows, but it's an
3769 improvement. (Bug#8719)
3770
3771 * alloc.c (make_event_array): Use XINT, not XUINT.
3772 There's no need for unsigned here.
3773
3774 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3775 This follows up to the 2011-05-06 change that substituted uintptr_t
3776 for EMACS_INT. This case wasn't caught back then.
3777
3778 Rework Fformat to avoid integer overflow issues.
3779 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3780 now (part of C89). Include <verify.h>.
3781 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3782 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3783 (Fformat): Avoid the prepass trying to compute sizes; it was only
3784 approximate and thus did not catch overflow reliably. Instead, walk
3785 through the format just once, formatting and computing sizes as we go,
3786 checking for integer overflow at every step, and allocating a larger
3787 buffer as needed. Keep track separately whether the format is
3788 multibyte. Keep only the most-recently calculated precision, rather
3789 than them all. Record whether each argument has been converted to
3790 string. Use EMACS_INT, not int, for byte and char and arg counts.
3791 Support field widths and precisions larger than INT_MAX. Avoid
3792 sprintf's undefined behavior with conversion specifications such as %#d
3793 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3794 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3795 formatting out-of-range floating point numbers with int
3796 formats. (Bug#8668)
3797
3798 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3799
3800 * data.c: Avoid integer truncation in expressions involving floats.
3801 * data.c: Include <intprops.h>.
3802 (arith_driver): When there's an integer overflow in an expression
3803 involving floating point, convert the integers to floating point
3804 so that the resulting value does not suffer from catastrophic
3805 integer truncation. For example, on a 64-bit host (* 4
3806 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3807 Do not rely on undefined behavior after integer overflow.
3808
3809 merge count_size_as_multibyte, parse_str_to_multibyte
3810 * character.c, character.h (count_size_as_multibyte):
3811 Rename from parse_str_to_multibyte; all uses changed.
3812 Check for integer overflow.
3813 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3814 since it's now a duplicate of the other. This is more of
3815 a character than a buffer op, so better that it's in character.c.
3816 * fns.c, print.c: Adjust to above changes.
3817
3818 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3819
3820 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3821
3822 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3823
3824 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3825 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3826 (x_clipboard_manager_save): Now static.
3827 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3828
3829 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3830 (crypto_hash_function): Now static.
3831 Fix pointer signedness problems. Avoid unnecessary initializations.
3832
3833 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3834
3835 * termhooks.h (Vselection_alist): Make it terminal-local.
3836
3837 * terminal.c (create_terminal): Initialize it.
3838
3839 * xselect.c: Support for clipboard managers.
3840 (Vselection_alist): Move to termhooks.h as terminal-local var.
3841 (LOCAL_SELECTION): New macro.
3842 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3843 (symbol_to_x_atom): Remove gratuitous arg.
3844 (x_handle_selection_request, lisp_data_to_selection_data)
3845 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3846 (x_own_selection, x_get_local_selection, x_convert_selection):
3847 New arg, specifying work frame. Use terminal-local Vselection_alist.
3848 (some_frame_on_display): Delete unused function.
3849 (Fx_own_selection_internal, Fx_get_selection_internal)
3850 (Fx_disown_selection_internal, Fx_selection_owner_p)
3851 (Fx_selection_exists_p): New optional frame arg.
3852 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3853 (x_handle_selection_clear): Don't treat other terminals with the
3854 same keyboard specially. Use the terminal-local Vselection_alist.
3855 (x_clear_frame_selections): Use Frun_hook_with_args.
3856
3857 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3858
3859 * xterm.h: Add support for those atoms.
3860
3861 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3862
3863 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3864 (converted_selections, conversion_fail_tag): New global variables.
3865 (x_selection_request_lisp_error): Free the above.
3866 (x_get_local_selection): Remove unnecessary code.
3867 (x_reply_selection_request): Args changed; handle arbitrary array
3868 of converted selections stored in converted_selections.
3869 Separate the XChangeProperty and SelectionNotify steps.
3870 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3871 (x_convert_selection): New function.
3872 (x_handle_selection_event): Simplify.
3873 (x_get_foreign_selection): Don't ignore incoming requests while
3874 waiting for an answer; this will fail when we implement
3875 SAVE_TARGETS, and seems unnecessary anyway.
3876 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3877 (Vx_sent_selection_functions): Doc fix.
3878
3879 2011-05-26 Leo Liu <sdl.web@gmail.com>
3880
3881 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3882
3883 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3884
3885 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3886
3887 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3888 for fringe update if it has periodic bitmap.
3889 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3890 and fringe_bitmap_periodic_p.
3891
3892 * fringe.c (get_fringe_bitmap_data): New function.
3893 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3894 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3895 row. Mark glyph row for fringe update if periodicity changed.
3896
3897 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3898 for fringe update unless it has periodic bitmap.
3899
3900 2011-05-25 Kenichi Handa <handa@m17n.org>
3901
3902 * xdisp.c (get_next_display_element): Set correct it->face_id for
3903 a static composition.
3904
3905 2011-05-24 Leo Liu <sdl.web@gmail.com>
3906
3907 * deps.mk (fns.o):
3908 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3909
3910 * fns.c (crypto_hash_function, Fsha1): New function.
3911 (Fmd5): Use crypto_hash_function.
3912 (syms_of_fns): Add Ssha1.
3913
3914 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3915
3916 * gnutls.c: Remove unused macros.
3917 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3918 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3919 Remove macros that are defined and never used.
3920 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3921
3922 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3923
3924 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3925 (Fx_get_selection_internal): Minor cleanup.
3926 (Fx_own_selection_internal): Rename arguments for consistency with
3927 select.el.
3928
3929 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3932
3933 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3934
3935 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3936
3937 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3938
3939 * dispnew.c (scrolling_window): Don't exclude the case that the
3940 last enabled row in the desired matrix touches the bottom boundary.
3941
3942 2011-05-21 Glenn Morris <rgm@gnu.org>
3943
3944 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3945 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3946 and add some more files.
3947
3948 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3949
3950 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3951 report_file_error introduced by the change from 2011-05-07.
3952
3953 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 * systime.h (Time): Define only if emacs is defined.
3956 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3957 where the include path doesn't have X11/X.h by default. See
3958 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3959
3960 2011-05-20 Kenichi Handa <handa@m17n.org>
3961
3962 * composite.c (find_automatic_composition): Fix previous change.
3963
3964 2011-05-20 Glenn Morris <rgm@gnu.org>
3965
3966 * lisp.mk: New file, split from Makefile.in.
3967 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3968 (shortlisp): Remove.
3969 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3970
3971 2011-05-19 Glenn Morris <rgm@gnu.org>
3972
3973 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3974 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3975 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3976 (lisp): Set the order to that of loadup.el.
3977 (shortlisp): Make it a copy of $lisp.
3978 (SOME_MACHINE_LISP): Remove.
3979 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3980 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3981
3982 2011-05-18 Kenichi Handa <handa@m17n.org>
3983
3984 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3985 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3986 (find_automatic_composition): Mostly rewrite for efficiency.
3987
3988 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3989
3990 * makefile.w32-in: Update dependencies.
3991
3992 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3993
3994 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3995 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3996
3997 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3998
3999 Fix some integer overflow issues, such as string length overflow.
4000
4001 * insdel.c (count_size_as_multibyte): Check for string overflow.
4002
4003 * character.c (lisp_string_width): Check for string overflow.
4004 Use EMACS_INT, not int, for string indexes and lengths; in
4005 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4006 the resulting string length overflows an EMACS_INT; instead,
4007 report a string overflow if no precision given. When checking for
4008 precision exhaustion, use a check that cannot possibly have
4009 integer overflow. (Bug#8675)
4010 * character.h (lisp_string_width): Adjust to new signature.
4011
4012 * alloc.c (string_overflow): New function.
4013 (Fmake_string): Use it. This doesn't change behavior, but saves
4014 a few bytes and will simplify future changes.
4015 * character.c (string_escape_byte8): Likewise.
4016 * lisp.h (string_overflow): New decl.
4017
4018 Fixups, following up to the user-interface timestamp change.
4019 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4020 for UI timestamps, instead of unsigned long.
4021 * msdos.c (mouse_get_pos): Likewise.
4022 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4023 * w32gui.h (Time): Define by including "systime.h" rather than by
4024 declaring it ourselves. (Bug#8664)
4025
4026 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4027 * image.c (clear_image_cache): Likewise.
4028
4029 * term.c (term_mouse_position): Don't assume time_t wraparound.
4030
4031 Be more systematic about user-interface timestamps.
4032 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4033 and sometimes 'EMACS_UINT', to represent these timestamps.
4034 This change causes it to use 'Time' uniformly, as that's what X uses.
4035 This makes the code easier to follow, and makes it easier to catch
4036 integer overflow bugs such as Bug#8664.
4037 * frame.c (Fmouse_position, Fmouse_pixel_position):
4038 Use Time, not unsigned long, for user-interface timestamps.
4039 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4040 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4041 * keyboard.h (last_event_timestamp): Likewise.
4042 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4043 * menu.h (xmenu_show): Likewise.
4044 * term.c (term_mouse_position): Likewise.
4045 * termhooks.h (struct input_event.timestamp): Likewise.
4046 (struct terminal.mouse_position_hook): Likewise.
4047 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4048 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4049 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4050 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4051 what it was before.
4052 * menu.h, termhooks.h: Include "systime.h", for Time.
4053
4054 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4055 Don't assume that the difference between two unsigned long values
4056 can fit into an integer. At this point, we know button_down_time
4057 <= event->timestamp, so the difference must be nonnegative, so
4058 there's no need to cast the result if double-click-time is
4059 nonnegative, as it should be; check that it's nonnegative, just in
4060 case. This bug is triggered when events are more than 2**31 ms
4061 apart (about 25 days). (Bug#8664)
4062
4063 * xselect.c (last_event_timestamp): Remove duplicate decl.
4064 (x_own_selection): Remove needless cast to unsigned long.
4065
4066 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4067 that always fit in int. Use a sentinel instead of a counter, to
4068 avoid a temp and to allay GCC's concerns about possible int overflow.
4069 * frame.h (struct frame): Use int for menu_bar_items_used
4070 instead of EMACS_INT, since it always fits in int.
4071
4072 * menu.c (grow_menu_items): Check for int overflow.
4073
4074 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4075
4076 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4077 Before, the code was not consistent. These values cannot exceed
4078 2**31 - 1 so there's no need to make them unsigned.
4079 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4080 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4081 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4082 as modifiers.
4083 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4084
4085 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4086 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4087 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4088 presumably because the widths might not match.
4089
4090 * window.c (size_window): Avoid needless test at loop start.
4091
4092 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4093
4094 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4095
4096 2011-05-12 Drew Adams <drew.adams@oracle.com>
4097
4098 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4099
4100 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4101
4102 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4103 `width' to `bar_area_x' and `bar_area_width', respectively.
4104 (x_scroll_run): Take account of fringe background extension.
4105
4106 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4107 Rename local vars `left' and `width' to `bar_area_x' and
4108 `bar_area_width', respectively.
4109 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4110 background extension.
4111
4112 2011-05-10 Jim Meyering <meyering@redhat.com>
4113
4114 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4115
4116 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4117
4118 * image.c (Finit_image_library): Return t for built-in image types,
4119 like pbm and xbm. (Bug#8640)
4120
4121 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4122
4123 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4124
4125 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4126
4127 * w32console.c (Fset_screen_color): Doc fix.
4128 (Fget_screen_color): New function.
4129 (syms_of_ntterm): Defsubr it.
4130
4131 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4132 unlink the temporary file if Fcall_process didn't create it in the
4133 first place.
4134 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4135 child process will be redirected to a file specified with `:file'.
4136 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4137 cue to call_process_cleanup not to close that handle.
4138
4139 2011-05-07 Ben Key <bkey76@gmail.com>
4140
4141 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4142 one of two shell specific rules, either bootstrap-temacs-CMD or
4143 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4144 to the previous implementation of the bootstrap-temacs rule.
4145 The bootstrap-temacs-CMD rule is similar to the previous
4146 implementation of the bootstrap-temacs rule except that it
4147 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4148 variable.
4149
4150 These changes, along with some changes to nt/configure.bat,
4151 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4152 earlier fix to add support for --cflags and --ldflags options
4153 that include quotes so that it works whether make uses cmd or
4154 sh as the shell.
4155
4156 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4157
4158 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4159 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4160 is a constant.
4161 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4162 a string. Handle both cases.
4163 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4164 (Fdbus_register_method): Use Qinvalid_function.
4165
4166 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4167
4168 * makefile.w32-in: Update dependencies.
4169 (LISP_H): Add inttypes.h and stdin.h.
4170 (PROCESS_H): Add unistd.h.
4171
4172 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4173
4174 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4175 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4176
4177 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4178
4179 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4180
4181 * term.c (vfatal): Remove stray call to va_end.
4182 It's not needed and the C Standard doesn't allow it here anyway.
4183
4184 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4185 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4186
4187 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4188 bytes.
4189
4190 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4191
4192 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4193
4194 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4195
4196 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4197
4198 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4199
4200 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4201 * charset.c (Fdefine_charset_internal): Don't initialize
4202 charset.code_space[15]. The value was garbage, on hosts with
4203 32-bit int (Bug#8600).
4204
4205 * lread.c (read_integer): Be more consistent with string-to-number.
4206 Use string_to_number to do the actual conversion; this avoids
4207 rounding errors and fixes some other screwups. Without this fix,
4208 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4209 (digit_to_number): Move earlier, for benefit of read_integer.
4210 Return -1 if the digit is out of range for the base, -2 if it is
4211 not a digit in any supported base. (Bug#8602)
4212
4213 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4214
4215 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4216 to match comment at start of function. This also removes a
4217 GCC warning about overflow in a 32+64-bit port.
4218
4219 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4220
4221 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4222 Reported by Stefan Monnier in
4223 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4224 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4225 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4226
4227 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4228 (EMACS_UINTPTR): Likewise, with uintptr_t.
4229
4230 * lisp.h: Prefer 64-bit EMACS_INT if available.
4231 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4232 on 32-bit hosts that have 64-bit int, so that they can access
4233 large files.
4234 However, temporarily disable this change unless the temporary
4235 symbol WIDE_EMACS_INT is defined.
4236
4237 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4238
4239 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4240 This removes an assumption that EMACS_INT and long are the same
4241 width as pointers. The assumption is true for Emacs porting targets
4242 now, but we want to make other targets possible.
4243 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4244 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4245 In the rest of the code, change types of integers that hold casted
4246 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4247 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4248 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4249 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4250 No need to cast type when ORing.
4251 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4252 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4253 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4254 assume EMACS_INT is the same width as char *.
4255 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4256 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4257 Remove no-longer-needed casts.
4258 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4259 (xg_tool_bar_help_callback, xg_make_tool_item):
4260 Use EMACS_INTPTR to hold an integer
4261 that will be cast to void *; this can avoid a GCC warning
4262 if EMACS_INT is not the same width as void *.
4263 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4264 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4265 (current_message_1, set_message_1):
4266 Use a local to convert to proper width without a cast.
4267 * xmenu.c (dialog_selection_callback): Likewise.
4268
4269 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4270 Also, don't assume VALBITS / RAND_BITS is less than 5,
4271 and don't rely on undefined behavior when shifting a 1 left into
4272 the sign bit.
4273 * lisp.h (get_random): Change signature to match.
4274
4275 * lread.c (hash_string): Use size_t, not int, for hash computation.
4276 Normally we prefer signed values; but hashing is special, because
4277 it's better to use unsigned division on hash table sizes so that
4278 the remainder is nonnegative. Also, size_t is the natural width
4279 for hashing into memory. The previous code used 'int', which doesn't
4280 retain enough info to hash well into very large tables.
4281 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4282
4283 * dbusbind.c: Don't possibly lose pointer info when converting.
4284 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4285 Use XPNTR rather than XHASH, so that the high-order bits of
4286 the pointer aren't lost when converting through void *.
4287
4288 * eval.c (Fautoload): Don't double-shift a pointer.
4289
4290 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4291
4292 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * gnutls.c (DEF_GNUTLS_FN):
4295 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4296
4297 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4298
4299 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4300 marker. (Bug#8610)
4301
4302 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4303
4304 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4305 New version that can reserve upto 2GB of heap space.
4306
4307 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4308
4309 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4310
4311 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4312
4313 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4314 `gnutls_certificate_set_x509_key_file'.
4315
4316 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4317
4318 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4319 Update dependencies.
4320
4321 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4322
4323 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4324 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4325 Remove unused parameter `fildes'.
4326 * process.c (read_process_output, send_process): Don't pass it.
4327
4328 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4329
4330 Fix previous change: the library cache is defined in w32.c.
4331 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4332 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4333
4334 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4335
4336 Implement dynamic loading of GnuTLS on Windows.
4337
4338 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4339 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4340 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4341 Declare.
4342
4343 * gnutls.c (Qgnutls_dll): Define.
4344 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4345 (gnutls_*): Declare function pointers.
4346 (init_gnutls_functions): New function to initialize function pointers.
4347 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4348 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4349 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4350 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4351 (emacs_gnutls_write, emacs_gnutls_read)
4352 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4353 (Fgnutls_available_p): New function.
4354 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4355 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4356 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4357
4358 * image.c: Include w32.h.
4359 (Vimage_type_cache): Delete.
4360 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4361 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4362 (w32_delayed_load): Move to w32.c.
4363
4364 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4365
4366 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4367 (w32_delayed_load): Move from image.c. When loading a library, record
4368 its filename in the :loaded-from property of the library id.
4369 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4370 Initialize and staticpro them.
4371 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4372
4373 * process.c: Include lisp.h before w32.h, not after.
4374 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4375 instead of gnutls_record_check_pending.
4376
4377 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4378
4379 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4380
4381 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4382 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4383 as passed in.
4384
4385 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4386
4387 * xterm.c (x_set_frame_alpha): Do not set property on anything
4388 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4389
4390 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4391
4392 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4393
4394 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4395
4396 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4397 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4398 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4399 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4400 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4401 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4402 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4403 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4404 (Qgnutls_bootprop_callbacks_verify): Make static.
4405
4406 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4407
4408 * callproc.c: Indentation fixup.
4409
4410 * sysdep.c (wait_for_termination_1): Make static.
4411 (wait_for_termination, interruptible_wait_for_termination):
4412 Move after wait_for_termination_1.
4413
4414 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4415
4416 * sysdep.c (interruptible_wait_for_termination): New function
4417 which is like wait_for_termination, but allows keyboard
4418 interruptions.
4419
4420 * callproc.c (Fcall_process): Add (:file "file") as an option for
4421 the STDOUT buffer.
4422 (Fcall_process_region): Ditto.
4423
4424 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4425
4426 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4427 rather than `XVECTOR (FOO)->size'.
4428
4429 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4430 inttypes.h, as a gnulib replacement is used if it not available in
4431 system headers.
4432
4433 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4434
4435 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4436 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4437 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4438
4439 * coding.c (coding_alloc_by_realloc): Error out if destination
4440 will grow beyond MOST_POSITIVE_FIXNUM.
4441 (decode_coding_emacs_mule): Abort if there isn't enough place in
4442 charbuf for the composition carryover bytes. Reserve an extra
4443 space for up to 2 characters produced in a loop.
4444 (decode_coding_iso_2022): Abort if there isn't enough place in
4445 charbuf for the composition carryover bytes.
4446
4447 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4448
4449 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4450 aborting when %lld or %lll format is passed.
4451 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4452 %llo or %llx format is passed. (Bug#8545)
4453
4454 * window.c (window_scroll_line_based): Use a marker instead of
4455 simple variables to record original value of point. (Bug#7952)
4456
4457 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4458 produced by %s or %c overflows available buffer space. (Bug#8545)
4459
4460 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4461
4462 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4463 (SIZE_MAX): Move defn after all includes, as they might #define it.
4464
4465 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4466
4467 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4468
4469 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4470
4471 * keyboard.c (Qdelayed_warnings_hook): Define.
4472 (command_loop_1): Run `delayed-warnings-hook'
4473 if Vdelayed_warnings_list is non-nil.
4474 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4475 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4476
4477 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4478
4479 * doprnt.c (doprnt): Don't return value smaller than the buffer
4480 size if the message was truncated. (Bug#8545).
4481
4482 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4483
4484 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4485 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4486
4487 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4488
4489 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4490
4491 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4492
4493 * makefile.w32-in: Update dependencies.
4494
4495 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4496
4497 Improve `doprnt' and its usage. (Bug#8545)
4498 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4499 `format_end'. Remove support for %l as a conversion specifier.
4500 Don't use xrealloc. Improve diagnostics when the %l size modifier
4501 is used. Update the commentary.
4502
4503 * eval.c (verror): Simplify calculation of size_t.
4504
4505 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4506 messages.
4507
4508 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4509
4510 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4511 change.
4512
4513 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4516 This makes this file independent of the recent pseudovector change.
4517
4518 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4519
4520 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4521
4522 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4523 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4524 Remove unused local.
4525 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4526
4527 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4528 GCC 4.6.0 optimizes based on type-based alias analysis.
4529 For example, if b is of type struct buffer * and v of type struct
4530 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4531 != &v->size, and therefore "v->size = 1; b->size = 2; return
4532 v->size;" must therefore return 1. This assumption is incorrect
4533 for Emacs, since it type-puns struct Lisp_Vector * with many other
4534 types. To fix this problem, this patch adds a new type struct
4535 vectorlike_header that documents the constraints on layout of vectors
4536 and pseudovectors, and helps optimizing compilers not get fooled
4537 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4538 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4539 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4540 the size member.
4541 (XSETPVECTYPE): Rewrite in terms of new macro.
4542 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4543 This is a bit clearer, and further avoids the possibility of
4544 undesirable aliasing.
4545 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4546 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4547 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4548 since Lisp_Subr is a special case (no "next" field).
4549 (ASIZE): Now uses header.size rather than size.
4550 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4551 to avoid the hassle of writing XVECTOR (foo)->header.size.
4552 (struct vectorlike_header): New type.
4553 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4554 object, to help avoid aliasing.
4555 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4556 (SUBRP): Likewise, since Lisp_Subr is a special case.
4557 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4558 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4559 (struct Lisp_Hash_Table): Combine first two members into a single
4560 struct vectorlike_header member. All uses of "size" and "next" members
4561 changed to be "header.size" and "header.next".
4562 * buffer.h (struct buffer): Likewise.
4563 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4564 * frame.h (struct frame): Likewise.
4565 * process.h (struct Lisp_Process): Likewise.
4566 * termhooks.h (struct terminal): Likewise.
4567 * window.c (struct save_window_data, struct saved_window): Likewise.
4568 * window.h (struct window): Likewise.
4569 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4570 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4571 * buffer.c (init_buffer_once): Likewise.
4572 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4573 special case.
4574 * process.c (Fformat_network_address): Use local var for size,
4575 for brevity.
4576
4577 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4578
4579 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4580 * data.c (atof): Remove decl; no longer used or needed.
4581 (digit_to_number): Move to lread.c.
4582 (Fstring_to_number): Use new string_to_number function, to be
4583 consistent with how the Lisp reader treats infinities and NaNs.
4584 Do not assume that floating-point numbers represent EMACS_INT
4585 without losing information; this is not true on most 64-bit hosts.
4586 Avoid double-rounding errors, by insisting on integers when
4587 parsing non-base-10 numbers, as the documentation specifies.
4588 * lisp.h (string_to_number): New decl, replacing ...
4589 (isfloat_string): Remove.
4590 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4591 (read1): Do not accept +. and -. as integers; this
4592 appears to have been a coding error. Similarly, do not accept
4593 strings like +-1e0 as floating point numbers. Do not report
4594 overflow for integer overflows unless the base is not 10 which
4595 means we have no simple and reliable way to continue.
4596 Break out the floating-point parsing into a new
4597 function string_to_number, so that Fstring_to_number parses
4598 floating point numbers consistently with the Lisp reader.
4599 (digit_to_number): Move here from data.c. Make it static inline.
4600 (E_CHAR, EXP_INT): Remove, replacing with ...
4601 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4602 (string_to_number): New function, replacing isfloat_string.
4603 This function checks for valid syntax and produces the resulting
4604 Lisp float number too. Rework it so that string-to-number
4605 no longer mishandles examples like "1.0e+". Use strtoumax,
4606 so that overflow for non-base-10 numbers is reported only when
4607 there's no portable and simple way to convert to floating point.
4608
4609 * textprop.c (set_text_properties_1): Rewrite for clarity,
4610 and to avoid GCC warning about integer overflow.
4611
4612 * intervals.h (struct interval): Use EMACS_INT for members
4613 where EMACS_UINT might cause problems. See
4614 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4615 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4616 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4617 All uses changed.
4618 (offset_intervals): Tell GCC not to worry about length overflow
4619 when negating a negative length.
4620
4621 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4622 (overrun_check_free): Likewise.
4623
4624 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4625 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4626 word size.
4627
4628 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4629 (gnutls_make_error): Rename local to avoid shadowing.
4630 (gnutls_emacs_global_deinit): ifdef out; not used.
4631 (Fgnutls_boot): Use const for pointer to readonly storage.
4632 Comment out unused local. Fix pointer signedness problems.
4633
4634 * lread.c (openp): Don't stuff size_t into an 'int'.
4635 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4636 about possible signed overflow.
4637
4638 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4639 (GDK_KEY_g): Don't define if already defined.
4640 (xg_prepare_tooltip): Avoid pointer signedness problem.
4641 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4642
4643 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4644 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4645
4646 * xfns.c (Fx_window_property): Simplify a bit,
4647 to make a bit faster and to avoid GCC 4.6.0 warning.
4648 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4649
4650 * fns.c (internal_equal): Don't assume size_t fits in int.
4651
4652 * alloc.c (compact_small_strings): Tighten assertion a little.
4653
4654 Replace pEd with more-general pI, and fix some printf arg casts.
4655 * lisp.h (pI): New macro, generalizing old pEd macro to other
4656 conversion specifiers. For example, use "...%"pI"d..." rather
4657 than "...%"pEd"...".
4658 (pEd): Remove. All uses replaced with similar uses of pI.
4659 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4660 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4661 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4662 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4663 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4664 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4665 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4666 64-bit hosts.
4667 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4668 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4669 * print.c (safe_debug_print, print_object): Likewise.
4670 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4671 to int.
4672 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4673 avoiding the 0 flag, which is not portable.
4674 * process.c (Fmake_network_process): Use pI to avoid cast.
4675 * region-cache.c (pp_cache): Likewise.
4676 * xdisp.c (decode_mode_spec): Likewise.
4677 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4678 behavior on 64-bit hosts with printf arg.
4679 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4680 (x_stop_queuing_selection_requests): Likewise.
4681 (x_get_window_property): Don't truncate byte count to an 'int'
4682 when tracing.
4683
4684 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4685 here, since it parses constructs like leading '-' and spaces,
4686 which are not wanted; and it overflows with large numbers.
4687 Instead, simply match F[0-9]+, which is what is wanted anyway.
4688
4689 * alloc.c: Remove unportable assumptions about struct layout.
4690 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4691 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4692 (allocate_vectorlike, make_pure_vector): Use the new macros,
4693 plus offsetof, to remove unportable assumptions about struct layout.
4694 These assumptions hold on all porting targets that I know of, but
4695 they are not guaranteed, they're easy to remove, and removing them
4696 makes further changes easier.
4697
4698 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4699 This doesn't fix a bug but makes the code clearer.
4700 (string_overrun_cookie): Now const. Use initializers that
4701 don't formally overflow signed char, to avoid warnings.
4702 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4703 can cause Emacs to crash when string overrun checking is enabled.
4704 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4705 multiple of sizeof (EMACS_INT); it need not be, if
4706 alignof(EMACS_INT) < sizeof (EMACS_INT).
4707 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4708
4709 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4710
4711 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4712
4713 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4714
4715 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4716 supposed to be handshaking. (Bug#8556)
4717 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4718
4719 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4720
4721 * lisp.h (Qdebug): List symbol.
4722 * eval.c (Qdebug): Restore global linkage.
4723 * keyboard.c (debug-on-event): New variable.
4724 (handle_user_signal): Break into debugger when debug-on-event
4725 matches the current signal symbol.
4726
4727 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4728
4729 * alloc.c (check_sblock, check_string_bytes)
4730 (check_string_free_list): Convert to standard C.
4731
4732 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4733
4734 * w32.c (emacs_gnutls_push): Fix typo.
4735
4736 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4737
4738 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4739 "cast to pointer from integer of different size".
4740
4741 Improve doprnt and its use in verror. (Bug#8545)
4742 * doprnt.c (doprnt): Document the set of format control sequences
4743 supported by the function. Use SAFE_ALLOCA instead of always
4744 using `alloca'.
4745
4746 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4747 is one byte too soon. Don't use xrealloc; instead xfree and
4748 xmalloc anew.
4749
4750 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4751
4752 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4753 callbacks stage.
4754
4755 * gnutls.c: Renamed global_initialized to
4756 gnutls_global_initialized. Added internals for the
4757 :verify-hostname-error, :verify-error, and :verify-flags
4758 parameters of `gnutls-boot' and documented those parameters in the
4759 docstring. Start callback support.
4760 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4761 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4762 on error. Return error code.
4763 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4764 (emacs_gnutls_read): Likewise.
4765 (Fgnutls_boot): Return handshake error code.
4766 (emacs_gnutls_handle_error): New function.
4767 (wsaerror_to_errno): Likewise.
4768
4769 * w32.h (emacs_gnutls_pull): Add prototype.
4770 (emacs_gnutls_push): Likewise.
4771
4772 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4773 (emacs_gnutls_push): Likewise.
4774
4775 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4776
4777 * process.c (wait_reading_process_output): Check if GnuTLS
4778 buffered some data internally if no FDs are set for TLS
4779 connections.
4780
4781 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4782 (LIBS): Link to USER_LIBS.
4783 ($(BLD)/gnutls.$(0)): New target.
4784
4785 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4786
4787 * xdisp.c (handle_single_display_spec): Rename the
4788 display_replaced_before_p argument into display_replaced_p, to
4789 make it consistent with the commentary. Fix typos in the
4790 commentary.
4791
4792 * textprop.c (syms_of_textprop): Remove dead code.
4793 (copy_text_properties): Delete obsolete commentary about an
4794 interface that was deleted long ago. Fix typos in the description
4795 of arguments.
4796
4797 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4798 to changes in oldXMenu/XMenu.h from 2011-04-16.
4799 <menu_help_message, prev_menu_help_message>: Constify.
4800 (IT_menu_make_room): menu->help_text is now `const char **';
4801 adjust.
4802
4803 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4804 to changes in oldXMenu/XMenu.h from 2011-04-16.
4805 (struct XMenu): Declare `help_text' `const char **'.
4806
4807 * xfaces.c <Qunspecified>: Make extern again.
4808
4809 * syntax.c: Include sys/types.h before including regex.h, as
4810 required by Posix.
4811
4812 * doc.c (get_doc_string): Improve the format passed to `error'.
4813
4814 * doprnt.c (doprnt): Improve commentary.
4815
4816 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4817
4818 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4819 them with etags.
4820
4821 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4822 changes in globals.h immediately force recompilation.
4823 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4824 $(CURDIR)/s/ms-w32.h.
4825 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4826
4827 * character.c (Fchar_direction): Function deleted.
4828 (syms_of_character): Don't defsubr it.
4829 <char-direction-table>: Deleted.
4830
4831 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4832
4833 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4834 * doprnt.c: Include limits.h.
4835 (SIZE_MAX): New macro.
4836 (doprnt): Return a size_t value. 2nd arg is now size_t.
4837 Many local variables are now size_t instead of int or unsigned.
4838 Improve overflow protection. Support `l' modifier for integer
4839 conversions. Support %l conversion. Don't assume an EMACS_INT
4840 argument for integer conversions and for %c.
4841
4842 * lisp.h (doprnt): Restore prototype.
4843
4844 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4845 $(SRC)/character.h.
4846
4847 * Makefile.in (base_obj): Add back doprnt.o.
4848
4849 * deps.mk (doprnt.o): Add back prerequisites.
4850 (callint.o): Depend on character.h.
4851
4852 * eval.c (internal_lisp_condition_case): Include the handler
4853 representation in the error message.
4854 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4855 when breaking from the loop.
4856
4857 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4858
4859 * callint.c (Fcall_interactively): When displaying error message
4860 about invalid control letter, pass the character's codepoint, not
4861 a pointer to its multibyte form. Improve display of the character
4862 in octal and display also its hex code.
4863
4864 * character.c (char_string): Use %x to display the (unsigned)
4865 codepoint of an invalid character, to avoid displaying a bogus
4866 negative value.
4867
4868 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4869 `error', not SYMBOL_NAME itself.
4870
4871 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4872 character arguments to `error'.
4873
4874 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4875 to `error' in error message about FINAL_CHAR argument. Make sure
4876 FINAL_CHAR is a character, and use %c when it is passed as
4877 argument to `error'.
4878
4879 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4880
4881 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4882
4883 * w32.c: Include <time.h>.
4884 (sys_localtime): New function.
4885
4886 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4887
4888 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4889
4890 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4891
4892 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4893
4894 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4895 zombies (Bug#8467).
4896
4897 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4898
4899 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4900 gl_state.e_property when gl_state.object is Qt.
4901
4902 * insdel.c (make_gap_larger): Remove limitation of buffer size
4903 to <= INT_MAX.
4904
4905 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4906
4907 * xdisp.c (lookup_glyphless_char_display)
4908 (produce_glyphless_glyph): Handle cons cell entry in
4909 glyphless-char-display.
4910 (Vglyphless_char_display): Document it.
4911
4912 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4913 glyphless-char-display.
4914
4915 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4916
4917 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4918
4919 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4920
4921 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4922 definition for no-X builds.
4923
4924 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4925
4926 Static checks with GCC 4.6.0 and non-default toolkits.
4927
4928 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4929
4930 * process.c (keyboard_bit_set): Define only if SIGIO.
4931 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4932 (send_process): Repair possible setjmp clobbering.
4933
4934 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4935
4936 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4937
4938 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4939
4940 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4941 Define only if needed.
4942
4943 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4944 by pacifying GCC about it. Maybe it's time to retire it?
4945 * xfaces.c (USG, __TIMEVAL__): Likewise.
4946
4947 * dispextern.h (struct redisplay_interface): Rename param
4948 to avoid shadowing.
4949 * termhooks.h (struct terminal): Likewise.
4950 * xterm.c (xembed_send_message): Likewise.
4951
4952 * insdel.c (make_gap_smaller): Define only if
4953 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4954
4955 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4956 it.
4957
4958 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4959 so that we aren't warned about unused symbols.
4960
4961 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4962
4963 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4964
4965 * xfns.c (x_real_positions): Mark locals as initialized.
4966
4967 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4968
4969 * xterm.c: Fix problems found by static analysis with other toolkits.
4970 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4971 (x_dispatch_event): Declare static if USE_GTK, and
4972 define if USE_GTK || USE_X_TOOLKIT.
4973 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4974 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4975 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4976 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4977
4978 * xmenu.c (menu_help_callback): Pointer type fixes.
4979 Use const pointers when pointing at readonly data. Avoid pointer
4980 signedness clashes.
4981 (FALSE): Remove unused macro.
4982 (update_frame_menubar): Remove unused decl.
4983
4984 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4985
4986 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4987 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4988 (single_menu_item): Rename local to avoid shadowing.
4989
4990 * keyboard.c (make_lispy_event): Remove unused local var.
4991
4992 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4993 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4994
4995 * bitmaps: Change bitmaps from unsigned char back to the X11
4996 compatible char. Avoid the old compiler warnings about
4997 out-of-range initializers by using, for example, '\xab' rather
4998 than 0xab.
4999
5000 * xgselect.c (xgselect_initialize): Check vs interface
5001 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5002
5003 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5004
5005 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5006 to read-only memory.
5007
5008 * fns.c (vector): Remove; this old hack is no longer needed.
5009
5010 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5011 Remove unused var.
5012 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5013
5014 * xrdb.c (x_load_resources): Omit unused local.
5015
5016 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5017 (x_window): Rename locals to avoid shadowing.
5018 (USG): Use the kludged USG macro, to pacify gcc.
5019
5020 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5021 (x_term_init): Remove local to avoid shadowing.
5022
5023 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5024
5025 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5026 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5027
5028 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5029
5030 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5031
5032 Fix regex.c, syntax.c and friends for buffers > 2GB.
5033 * syntax.h (struct gl_state_s): Declare character position members
5034 EMACS_INT.
5035
5036 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5037
5038 * textprop.c (verify_interval_modification, interval_of):
5039 Declare arguments EMACS_INT.
5040
5041 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5042 EMACS_INT.
5043
5044 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5045
5046 * indent.c (Fvertical_motion): Local variable it_start is now
5047 EMACS_INT.
5048
5049 * regex.c (re_match, re_match_2, re_match_2_internal)
5050 (bcmp_translate, regcomp, regexec, print_double_string)
5051 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5052 (re_compile_pattern, re_exec): Declare arguments and local
5053 variables `size_t' and `ssize_t' and return values `regoff_t', as
5054 appropriate.
5055 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5056 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5057 <compile_stack_type>: `size' and `avail' are now `size_t'.
5058
5059 * regex.h <regoff_t>: Use ssize_t, not int.
5060 (re_search, re_search_2, re_match, re_match_2): Arguments that
5061 specify buffer/string position and length are now ssize_t and
5062 size_t. Return type is regoff_t.
5063
5064 2011-04-16 Ben Key <bkey76@gmail.com>
5065
5066 * nsfont.m: Fixed bugs in ns_get_family and
5067 ns_descriptor_to_entity that were caused by using free to
5068 deallocate memory blocks that were allocated by xmalloc (via
5069 xstrdup). This caused Emacs to crash when compiled with
5070 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5071 --enable-checking=xmallocoverrun). xfree is now used to
5072 deallocate these memory blocks.
5073
5074 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5075
5076 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5077
5078 emacs_write: Accept and return EMACS_INT for sizes.
5079 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5080 et seq.
5081 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5082 Accept and return EMACS_INT.
5083 (emacs_gnutls_write): Return the number of bytes written on
5084 partial writes.
5085 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5086 (emacs_read, emacs_write): Remove check for negative size, as the
5087 Emacs source code has been audited now.
5088 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5089 (emacs_read, emacs_write): Use it.
5090 * process.c (send_process): Adjust to the new signatures of
5091 emacs_write and emacs_gnutls_write. Do not attempt to store
5092 a byte offset into an 'int'; it might overflow.
5093 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5094
5095 * sound.c: Don't assume sizes fit in 'int'.
5096 (struct sound_device.period_size, alsa_period_size):
5097 Return EMACS_INT, not int.
5098 (struct sound_device.write, vox_write, alsa_write):
5099 Accept EMACS_INT, not int.
5100 (wav_play, au_play): Use EMACS_INT to store sizes and to
5101 record read return values.
5102
5103 2011-04-15 Ben Key <bkey76@gmail.com>
5104
5105 * keyboard.c (Qundefined): Don't declare static since it is used
5106 in nsfns.m.
5107 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5108 static since they are used in nsfont.m.
5109
5110 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5111
5112 * process.c (Qprocessp): Don't declare static.
5113 * lisp.h (Qprocessp): Declare again.
5114
5115 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5116
5117 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5118
5119 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5120
5121 Improve C-level modularity by making more things 'static'.
5122
5123 Don't publish debugger-only interfaces to other modules.
5124 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5125 (verify_bytepos, count_markers): Move decls to the only modules
5126 that need them.
5127 * region-cache.h (pp_cache): Likewise.
5128 * window.h (check_all_windows): Likewise.
5129 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5130
5131 * sysdep.c (croak): Now static, if
5132 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5133 * syssignal.h (croak): Declare only if not static.
5134
5135 * alloc.c (refill_memory_reserve): Now static if
5136 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5137 * lisp.h (refill_memory_reserve): Declare only if not static.
5138
5139 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5140 Define only if USE_LUCID.
5141
5142 * xrdb.c (x_customization_string, x_rm_string): Now static.
5143
5144 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5145 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5146
5147 * xdisp.c (draw_row_with_mouse_face): Now static.
5148 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5149
5150 * window.h (check_all_windows): Mark externally visible.
5151
5152 * window.c (window_deletion_count): Now static.
5153
5154 * undo.c: Make symbols static if they're not exported.
5155 (last_undo_buffer, last_boundary_position, pending_boundary):
5156 Now static.
5157
5158 * textprop.c (interval_insert_behind_hooks): Now static.
5159 (interval_insert_in_front_hooks): Likewise.
5160
5161 * term.c: Make symbols static if they're not exported.
5162 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5163 (max_frame_lines, tty_set_terminal_modes):
5164 (tty_reset_terminal_modes, tty_turn_off_highlight):
5165 (get_tty_terminal): Now static.
5166 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5167 * termhooks.h (term_mouse_moveto): Do not declare if
5168 HAVE_WINDOW_SYSTEM.
5169 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5170 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5171
5172 * sysdep.c: Make symbols static if they're not exported.
5173 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5174 Now static.
5175 (sigprocmask_set, full_mask): Remove; unused.
5176 (wait_debugging): Mark as visible.
5177 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5178 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5179
5180 * syntax.c (syntax_temp): Define only if !__GNUC__.
5181
5182 * sound.c (current_sound_device, current_sound): Now static.
5183
5184 * search.c (searchbufs, searchbuf_head): Now static.
5185
5186 * scroll.c (scroll_cost): Remove; unused.
5187 * dispextern.h (scroll_cost): Remove decl.
5188
5189 * region-cache.h (pp_cache): Mark as externally visible.
5190
5191 * process.c: Make symbols static if they're not exported.
5192 (process_tick, update_tick, create_process, chan_process):
5193 (Vprocess_alist, proc_buffered_char, datagram_access):
5194 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5195 (deactivate_process): Mark defn as static, as well as decl.
5196 * lisp.h (create_process): Remove decl.
5197 * process.h (chan_process, Vprocess_alist): Remove decls.
5198
5199 * print.c: Make symbols static if they're not exported.
5200 (print_depth, new_backquote_output, being_printed, print_buffer):
5201 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5202 (print_interval, print_number_index, initial_stderr_stream):
5203 Now static.
5204 * lisp.h (Fprinc): Remove decl.
5205 (debug_output_compilation_hack): Mark as externally visible.
5206
5207 * sysdep.c (croak): Move decl from here to syssignal.h.
5208 * syssignal.h (croak): Put it here, so the API can be checked when
5209 'croak' is called from dissociate_if_controlling_tty.
5210
5211 * minibuf.c: Make symbols static if they're not exported.
5212 (minibuf_save_list, choose_minibuf_frame): Now static.
5213 * lisp.h (choose_minibuf_frame): Remove decl.
5214
5215 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5216
5217 * lread.c: Make symbols static if they're not exported.
5218 (read_objects, initial_obarray, oblookup_last_bucket_number):
5219 Now static.
5220 (make_symbol): Remove; unused.
5221 * lisp.h (initial_obarray, make_symbol): Remove decls.
5222
5223 * keyboard.c: Make symbols static if they're not exported.
5224 (single_kboard, recent_keys_index, total_keys, recent_keys):
5225 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5226 (this_single_command_key_start, echoing, last_auto_save):
5227 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5228 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5229 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5230 (Vlispy_mouse_stem, double_click_count):
5231 Now static.
5232 (force_auto_save_soon): Define only if SIGDANGER.
5233 (ignore_mouse_drag_p): Now static if
5234 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5235 (print_help): Remove; unused.
5236 (stop_character, last_timer_event): Mark as externally visible.
5237 * keyboard.h (ignore_mouse_drag_p): Declare only if
5238 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5239 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5240 * lisp.h (echoing): Remove decl.
5241 (force_auto_save_soon): Declare only if SIGDANGER.
5242 * xdisp.c (redisplay_window): Simplify code, to make it more
5243 obvious that ignore_mouse_drag_p is not accessed if !defined
5244 USE_GTK && !defined HAVE_NS.
5245
5246 * intervals.c: Make symbols static if they're not exported.
5247 (merge_properties_sticky, merge_interval_right, delete_interval):
5248 Now static.
5249 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5250
5251 * insdel.c: Make symbols static if they're not exported.
5252 However, leave prepare_to_modify_buffer alone. It's never
5253 called from outside this function, but that appears to be a bug.
5254 (combine_after_change_list, combine_after_change_buffer):
5255 (adjust_after_replace, signal_before_change): Now static.
5256 (adjust_after_replace_noundo): Remove; unused.
5257 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5258 (signal_before_change): Remove decls.
5259
5260 * indent.c (val_compute_motion, val_vmotion): Now static.
5261
5262 * image.c: Make symbols static if they're not exported.
5263 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5264 if USE_GTK.
5265 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5266 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5267
5268 * fringe.c (standard_bitmaps): Now static.
5269 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5270
5271 * frame.c: Make symbols static if they're not exported.
5272 (x_report_frame_params, make_terminal_frame): Now static.
5273 (get_frame_param): Now static, unless HAVE_NS.
5274 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5275 (x_get_resource_string): Remove; not used.
5276 * frame.h (make_terminal_frame, x_report_frame_params):
5277 (x_get_resource_string); Remove decls.
5278 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5279 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5280
5281 * font.c, fontset.c: Make symbols static if they're not exported.
5282 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5283 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5284 * font.c (font_close_object): Now static.
5285 * font.h (font_close_object): Remove.
5286 * fontset.c (FONTSET_OBJLIST): Remove.
5287 (free_realized_fontset) #if-0 the body, which does nothing.
5288 (face_suitable_for_char_p): #if-0, as it's never called.
5289 * fontset.h (face_suitable_for_char_p): Remove decl.
5290 * xfaces.c (face_at_string_position):
5291 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5292 since 0 is always ASCII.
5293
5294 * fns.c (weak_hash_tables): Now static.
5295
5296 * fileio.c: Make symbols static if they're not exported.
5297 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5298 (Vwrite_region_annotation_buffers): Now static.
5299
5300 * eval.c: Make symbols static if they're not exported.
5301 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5302 * lisp.h (backtrace_list): Remove decl.
5303
5304 * emacs.c: Make symbols static if they're not exported.
5305 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5306 (fatal_error_code, fatal_error_signal_hook, standard_args):
5307 Now static.
5308 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5309 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5310 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5311 * lisp.h (fatal_error_signal_hook): Remove decl.
5312 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5313
5314 * editfns.c: Move a (normally-unused) function to its only use.
5315 * editfns.c, lisp.h (get_operating_system_release): Remove.
5316 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5317 worth the hassle of breaking this out.
5318
5319 * xterm.c: Make symbols static if they're not exported.
5320 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5321 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5322 (x_destroy_window, x_delete_display):
5323 Now static.
5324 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5325 (x_mouse_leave): Remove; unused.
5326 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5327 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5328 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5329 Remove decls.
5330 (x_mouse_leave): Declare only if WINDOWSNT.
5331 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5332 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5333 USE_X_TOOLKIT.
5334
5335 * ftxfont.c: Make symbols static if they're not exported.
5336 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5337 HAVE_FREETYPE.
5338 * font.h (ftxfont_driver): Likewise.
5339
5340 * xfns.c: Make symbols static if they're not exported.
5341 (x_last_font_name, x_display_info_for_name):
5342 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5343 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5344 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5345 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5346 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5347 (last_show_tip_args): Now static.
5348 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5349 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5350 (x_screen_planes): Remove; unused.
5351 * dispextern.h (x_screen_planes): Remove decl.
5352
5353 * dispnew.c: Make symbols static if they're not exported.
5354 * dispextern.h (redraw_garbaged_frames, scrolling):
5355 (increment_row_positions): Remove.
5356 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5357 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5358 Now static.
5359 (redraw_garbaged_frames): Remove; unused.
5360
5361 * xfaces.c: Make symbols static if they're not exported.
5362 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5363 Remove decls.
5364 * xterm.h (defined_color): Remove decls.
5365 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5366 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5367 (menu_face_changed_default, defined_color, free_realized_face):
5368 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5369 (ascii_face_of_lisp_face): Remove; unused.
5370
5371 * xdisp.c: Make symbols static if they're not exported.
5372 * dispextern.h (scratch_glyph_row, window_box_edges):
5373 (glyph_to_pixel_coords, set_cursor_from_row):
5374 (get_next_display_element, set_iterator_to_next):
5375 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5376 (show_mouse_face): Remove decls
5377 * frame.h (message_buf_print): Likewise.
5378 * lisp.h (pop_message, set_message, check_point_in_composition):
5379 Likewise.
5380 * xterm.h (set_vertical_scroll_bar): Likewise.
5381 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5382 (message_buf_print, scratch_glyph_row, displayed_buffer):
5383 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5384 (get_next_display_element, show_mouse_face, window_box_edges):
5385 (frame_to_window_pixel_xy, check_point_in_composition):
5386 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5387 (glyph_to_pixel_coords): Remove; unused.
5388
5389 * dired.c (file_name_completion): Now static.
5390
5391 * dbusbind.c (xd_in_read_queued_messages): Now static.
5392
5393 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5394 * data.c (circular_list_error): Remove.
5395
5396 * commands.h (last_point_position, last_point_position_buffer):
5397 (last_point_position_window): Remove decls.
5398 * keyboard.c: Make these variables static.
5399
5400 * coding.h (coding, code_convert_region, encode_coding_gap):
5401 Remove decls.
5402 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5403 (iso_code_class, detect_coding, code_convert_region): Now static.
5404 (encode_coding_gap): Remove; unused.
5405
5406 * chartab.c (chartab_chars, chartab_bits): Now static.
5407
5408 * charset.h (charset_iso_8859_1): Remove decl.
5409 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5410 Now static.
5411
5412 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5413 * ccl.c (Vccl_program_table): Now static.
5414 (check_ccl_update): Remove; unused.
5415
5416 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5417 * category.h: ... from here.
5418 * category.c (check_category_table, set_category_set): Now static.
5419
5420 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5421 * lisp.h: Remove these decls.
5422
5423 * buffer.c (buffer_count): Remove unused var.
5424
5425 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5426 so that it's not optimized away.
5427 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5428 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5429 exported only to the debugger.
5430
5431 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5432 * atimer.h (run_all_atimers): Remove; not exported.
5433
5434 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5435 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5436 was inaccessible from Lisp.
5437 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5438 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5439
5440 alloc.c: Import and export fewer symbols, and remove unused items.
5441 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5442 is defined.
5443 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5444 it's not optimized away by whole-program optimization.
5445 (message_enable_multibyte, free_misc): Remove.
5446 (catchlist, handlerlist, mark_backtrace):
5447 Declare only if BYTE_MARK_STACK.
5448 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5449 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5450 (message_enable_multibyte): Remove decl.
5451 (free_misc, interval_free_list, float_block, float_block_index):
5452 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5453 (cons_free_list, last_marked_index):
5454 Now static.
5455 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5456 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5457 (mark_backtrace): Define only if BYTE_MARK_STACK.
5458 * xdisp.c (message_enable_multibyte): Now static.
5459
5460 Declare Lisp_Object Q* variables to be 'static' if not exported.
5461 This makes it easier for human readers (and static analyzers)
5462 to see whether these variables are used from other modules.
5463 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5464 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5465 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5466 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5467 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5468 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5469 * xmenu.c, xselect.c:
5470 Declare Q* vars static if they are not used in other modules.
5471 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5472 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5473 Remove decls of unexported vars.
5474 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5475
5476 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5477
5478 Make Emacs functions such as Fatom 'static' by default.
5479 This makes it easier for human readers (and static analyzers)
5480 to see whether these functions can be called from other modules.
5481 DEFUN now defines a static function. To make the function external
5482 so that it can be used in other C modules, use the new macro DEFUE.
5483 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5484 (Finit_image_library):
5485 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5486 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5487 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5488 Remove decls, since these functions are now static.
5489 (Funintern, Fget_internal_run_time): New decls, since these functions
5490 were already external.
5491
5492 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5493 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5494 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5495 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5496 * keyboard.c, keymap.c, lread.c:
5497 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5498 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5499 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5500 Mark functions with DEFUE instead of DEFUN,
5501 if they are used in other modules.
5502 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5503 decls for now-static functions.
5504 * buffer.h (Fdelete_overlay): Remove decl.
5505 * callproc.c (Fgetenv_internal): Mark as internal.
5506 * composite.c (Fremove_list_of_text_properties): Remove decl.
5507 (Fcomposition_get_gstring): New forward static decl.
5508 * composite.h (Fcomposite_get_gstring): Remove decl.
5509 * dired.c (Ffile_attributes): New forward static decl.
5510 * doc.c (Fdocumntation_property): New forward static decl.
5511 * eval.c (Ffetch_bytecode): New forward static decl.
5512 (Funintern): Remove extern decl; now in .h file where it belongs.
5513 * fileio.c (Fmake_symbolic_link): New forward static decl.
5514 * image.c (Finit_image_library): New forward static decl.
5515 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5516 * intervals.h (Fprevious_property_change):
5517 (Fremove_list_of_text_properties): Remove decls.
5518 * keyboard.c (Fthis_command_keys): Remove decl.
5519 (Fcommand_execute): New forward static decl.
5520 * keymap.c (Flookup_key): New forward static decl.
5521 (Fcopy_keymap): Now static.
5522 * keymap.h (Flookup_key): Remove decl.
5523 * process.c (Fget_process): New forward static decl.
5524 (Fprocess_datagram_address): Mark as internal.
5525 * syntax.c (Fsyntax_table_p): New forward static decl.
5526 (skip_chars): Remove duplicate decl.
5527 * textprop.c (Fprevious_property_change): New forward static decl.
5528 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5529 Now internal.
5530 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5531 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5532
5533 * editfns.c (Fformat): Remove unreachable code.
5534
5535 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5536
5537 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5538 change. (Bug#8496)
5539
5540 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5541
5542 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5543 when at ZV. (Bug#8487)
5544
5545 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5546
5547 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5548 (Bug#8437)
5549 * keyboard.c (parse_tool_bar_item): Likewise.
5550 * sound.c (sound_cleanup, alsa_close): Likewise.
5551 * termcap.c (tgetent): Likewise.
5552 * xfns.c (x_default_font_parameter): Likewise.
5553 * xsettings.c (read_and_apply_settings): Likewise.
5554
5555 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5556 (overrun_check_free): Protoize.
5557
5558 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5559
5560 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5561 since callers should never pass a negative size.
5562 Change the signature to match that of plain 'read' and 'write'; see
5563 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5564 * lisp.h: Update prototypes of emacs_write and emacs_read.
5565
5566 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5567
5568 * xdisp.c (redisplay_window): Don't try to determine the character
5569 position of the scroll margin if the window start point w->startp
5570 is outside the buffer's accessible region. (Bug#8468)
5571
5572 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5573
5574 Fix write-region and its subroutines for buffers > 2GB.
5575 * fileio.c (a_write, e_write): Modify declaration of arguments and
5576 local variables to support buffers larger than 2GB.
5577 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5578
5579 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5580 argument, local variables, and return value.
5581
5582 * lisp.h: Update prototypes of emacs_write and emacs_read.
5583
5584 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5585
5586 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5587
5588 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5589
5590 Fix more problems found by GCC 4.6.0's static checks.
5591
5592 * xdisp.c (vmessage): Use a better test for character truncation.
5593
5594 * charset.c (load_charset_map): <, not <=, for optimization,
5595 and to avoid potential problems with integer overflow.
5596 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5597 * casetab.c (set_identity, shuffle): Likewise.
5598 * editfns.c (Fformat): Likewise.
5599 * syntax.c (skip_chars): Likewise.
5600
5601 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5602 This also lets GCC 4.6.0 generate slightly better loop code.
5603
5604 * callint.c (Fcall_interactively): <, not <=, for optimization.
5605 (Fcall_interactively): Count the number of arguments produced,
5606 not the number of arguments given. This is simpler and lets GCC
5607 4.6.0 generate slightly better code.
5608
5609 * ftfont.c: Distingish more carefully between FcChar8 and char.
5610 The previous code passed unsigned char * to a functions like
5611 strlen and xstrcasecmp that expect char *, which does not
5612 conform to the C standard.
5613 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5614 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5615 char * when the C standard requires it.
5616
5617 * keyboard.c (read_char): Remove unused var.
5618
5619 * eval.c: Port to Windows vsnprintf (Bug#8435).
5620 Include <limits.h>.
5621 (SIZE_MAX): Define if the headers do not.
5622 (verror): Do not give up if vsnprintf returns a negative count.
5623 Instead, grow the buffer. This ports to Windows vsnprintf, which
5624 does not conform to C99. Problem reported by Eli Zaretskii.
5625 Also, simplify the allocation scheme, by avoiding the need for
5626 calling realloc, and removing the ALLOCATED variable.
5627
5628 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5629
5630 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5631 But keep the doprint source code for now, as we might revamp it
5632 and use it again (Bug#8435).
5633 * lisp.h (doprnt): Remove.
5634 * Makefile.in (base_obj): Remove doprnt.o.
5635 * deps.mk (doprnt.o): Remove.
5636
5637 error: Print 32- and 64-bit integers portably (Bug#8435).
5638 Without this change, on typical 64-bit hosts error ("...%d...", N)
5639 was used to print both 32- and 64-bit integers N, which relied on
5640 undefined behavior.
5641 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5642 New macro.
5643 * lisp.h (error, verror): Mark as printf-like functions.
5644 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5645 Report overflow in size calculations when allocating printf buffer.
5646 Do not truncate output string at its first null byte.
5647 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5648 Truncate the output at a character boundary, since vsnprintf does not
5649 do that.
5650 * charset.c (check_iso_charset_parameter): Convert internal
5651 character to string before calling 'error', since %c now has the
5652 printf meaning.
5653 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5654 overflow when computing char to be passed to 'error'. Do not
5655 pass Lisp_Object to 'error'; pass the integer instead.
5656 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5657 formatted with plain %d.
5658
5659 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5660
5661 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5662
5663 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5664
5665 * xterm.c (x_catch_errors): Remove duplicate declaration.
5666
5667 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5668
5669 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5670
5671 2011-04-10 Jim Meyering <meyering@redhat.com>
5672
5673 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5674 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5675 return ssize_t not "int", and use size_t as the buffer length.
5676 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5677 * gnutls.h: Update declarations.
5678 * process.c (read_process_output): Use ssize_t, to match.
5679 (send_process): Likewise.
5680
5681 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5682
5683 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5684
5685 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5686
5687 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5688 Use unsigned char, to match FcChar8 type definition.
5689
5690 * xterm.c (handle_one_xevent):
5691 * xmenu.c (create_and_show_popup_menu):
5692 * xselect.c (x_decline_selection_request)
5693 (x_reply_selection_request): Avoid type-punned deref of X events.
5694
5695 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5696
5697 Fix some uses of `int' instead of EMACS_INT.
5698 * search.c (string_match_1, fast_string_match)
5699 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5700 (scan_buffer, find_next_newline_no_quit)
5701 (find_before_next_newline, search_command, Freplace_match)
5702 (Fmatch_data): Make some `int' variables be EMACS_INT.
5703
5704 * xdisp.c (display_count_lines): 3rd argument and return value now
5705 EMACS_INT. All callers changed.
5706 (pint2hrstr): Last argument is now EMACS_INT.
5707
5708 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5709 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5710 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5711 (decode_coding_utf_16, decode_coding_emacs_mule)
5712 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5713 (decode_coding_ccl, decode_coding_charset)
5714 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5715 (decode_coding_iso_2022, decode_coding_emacs_mule)
5716 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5717 <char_offset, last_offset>: Declare EMACS_INT.
5718 (encode_coding_utf_8, encode_coding_utf_16)
5719 (encode_coding_emacs_mule, encode_invocation_designation)
5720 (encode_designation_at_bol, encode_coding_iso_2022)
5721 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5722 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5723 Declare EMACS_INT.
5724 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5725 (encode_invocation_designation): Last argument P_NCHARS is now
5726 EMACS_INT.
5727 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5728 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5729
5730 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5731 All users changed.
5732
5733 * ccl.c (Fccl_execute_on_string): Declare some variables
5734 EMACS_INT.
5735
5736 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5737
5738 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5739
5740 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5741
5742 * process.c (Fformat_network_address): Doc fix.
5743
5744 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5745
5746 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5747
5748 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5749
5750 * keyboard.c (read_char): Call Lisp function help-form-show,
5751 instead of using internal_with_output_to_temp_buffer.
5752 (Qhelp_form_show): New var.
5753 (syms_of_keyboard): Use DEFSYM macro.
5754
5755 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5756
5757 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5758
5759 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5760
5761 * process.c (Flist_processes): Remove to Lisp.
5762 (list_processes_1): Delete.
5763
5764 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5765
5766 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5767
5768 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5769
5770 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5771
5772 Fix more problems found by GCC 4.6.0's static checks.
5773
5774 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5775
5776 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5777
5778 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5779
5780 * xdisp.c (vmessage): Mark as a printf-like function.
5781
5782 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5783
5784 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5785
5786 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5787 printf-like functions.
5788 (tiff_load): Add casts to remove these marks before passing them
5789 to system-supplied API.
5790
5791 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5792
5793 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5794 This avoids several warnings with gcc -Wstrict-overflow.
5795 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5796 directly, rather than having caller test rule sign. This avoids
5797 some unnecessary tests.
5798 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5799 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5800 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5801
5802 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5803 (xfont_open): Avoid unnecessary tests.
5804
5805 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5806
5807 * composite.h, composite.c (composition_gstring_put_cache):
5808 Use EMACS_INT, not int, for length.
5809
5810 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5811 breaking out part of COMPOSITION_DECODE_RULE.
5812 (COMPOSITION_DECODE_RULE): Use it.
5813 * composite.c (get_composition_id): Remove unused local vars,
5814 by using the new macro.
5815
5816 * textprop.c (set_text_properties_1): Change while to do-while,
5817 since the condition is always true at first.
5818
5819 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5820 (interval_deletion_adjustment): Return unsigned value.
5821 All uses changed.
5822
5823 * process.c (list_processes_1, create_pty, read_process_output):
5824 (exec_sentinel): Remove vars that were set but not used.
5825 (create_pty): Remove unnecessary "volatile"s.
5826 (Fnetwork_interface_info): Avoid possibility of int overflow.
5827 (read_process_output): Do adaptive read buffering even if carryover.
5828 (read_process_output): Simplify nbytes computation if buffered.
5829
5830 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5831
5832 * syntax.c (scan_words): Remove var that was set but not used.
5833 (update_syntax_table): Use unsigned instead of int.
5834
5835 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5836 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5837 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5838
5839 * print.c (print_error_message): Avoid int overflow.
5840
5841 * font.c (font_list_entities): Redo for clarity,
5842 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5843
5844 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5845 (font_score): Avoid potential overflow in diff calculation.
5846
5847 * fns.c (substring_both): Remove var that is set but not used.
5848 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5849
5850 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5851
5852 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5853 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5854 can always succeed if overflow has undefined behavior.
5855
5856 * search.c (boyer_moore, wordify): Remove vars set but not used.
5857 (wordify): Omit three unnecessary tests.
5858
5859 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5860 All callers changed. This avoids the need for an unused var.
5861
5862 * casefiddle.c (casify_region): Remove var that is set but not used.
5863
5864 * dired.c (file_name_completion): Remove var that is set but not used.
5865
5866 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5867
5868 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5869 (Finsert_file_contents): Remove unnecessary code checking fd.
5870
5871 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5872 Check for integer overflow on size calculations.
5873
5874 * buffer.c (Fprevious_overlay_change): Remove var that is set
5875 but not used.
5876
5877 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5878 Remove vars that are set but not used.
5879 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5880 (timer_check_2): Mark vars as initialized.
5881
5882 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5883
5884 * image.c (lookup_image): Remove var that is set but not used.
5885 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5886
5887 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5888 that are set but not used.
5889
5890 * xfns.c (make_invisible_cursor): Don't return garbage
5891 if XCreateBitmapFromData fails (Bug#8410).
5892
5893 * xselect.c (x_get_local_selection, x_handle_property_notify):
5894 Remove vars that are set but not used.
5895
5896 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5897 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5898
5899 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5900 Remove var that is set but not used.
5901 (scroll_bar_windows_size): Now size_t, not int.
5902 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5903 Check for overflow.
5904
5905 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5906 (map_tty_color) [!defined MSDOS]: Likewise.
5907
5908 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5909
5910 * coding.c: Remove vars that are set but not used.
5911 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5912 All callers changed.
5913 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5914 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5915 (decode_coding_charset): Remove vars that are set but not used.
5916
5917 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5918 that is set but not used.
5919
5920 * print.c (print_object): Remove var that is set but not used.
5921
5922 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5923 The gnulib version avoids calling malloc in the usual case,
5924 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5925 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5926 * filelock.c (current_lock_owner): Likewise.
5927 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5928 * sysdep.c: Include allocator.h, careadlinkat.h.
5929 (emacs_no_realloc_allocator): New static constant.
5930 (emacs_readlink): New function.
5931 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5932 ../lib/careadlinkat.h.
5933
5934 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5935
5936 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5937 first non-nil return value).
5938
5939 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5940
5941 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5942 if not defined (Bug#8403).
5943
5944 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5945
5946 * xdisp.c (display_count_lines): Remove parameter `start',
5947 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5948 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5949 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5950 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5951 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5952 and thereabouts. All callers changed.
5953 (get_per_char_metric): Remove parameter `f', unused since
5954 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5955
5956 2011-04-02 Jim Meyering <meyering@redhat.com>
5957
5958 do not dereference NULL upon failed strdup
5959 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5960 (ns_get_family): Likewise.
5961
5962 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5963
5964 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5965
5966 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5967
5968 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5969 later (Bug#8403).
5970
5971 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5972
5973 Add lexical binding.
5974
5975 * window.c (Ftemp_output_buffer_show): New fun.
5976 (Fsave_window_excursion):
5977 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5978
5979 * lread.c (lisp_file_lexically_bound_p): New function.
5980 (Fload): Bind Qlexical_binding.
5981 (readevalloop): Remove `evalfun' arg.
5982 Bind Qinternal_interpreter_environment.
5983 (Feval_buffer): Bind Qlexical_binding.
5984 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5985 Mark as dynamic.
5986 (syms_of_lread): Declare `lexical-binding'.
5987
5988 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5989
5990 * keyboard.c (eval_dyn): New fun.
5991 (menu_item_eval_property): Use it.
5992
5993 * image.c (parse_image_spec): Use Ffunctionp.
5994
5995 * fns.c (concat, mapcar1): Accept byte-code-functions.
5996
5997 * eval.c (Fsetq): Handle lexical vars.
5998 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5999 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6000 (FletX, Flet): Obey lexical binding.
6001 (Fcommandp): Handle closures.
6002 (Feval): New `lexical' arg.
6003 (eval_sub): New function extracted from Feval. Use it almost
6004 everywhere where Feval was used. Look up vars in lexical env.
6005 Handle closures.
6006 (Ffunctionp): Move from subr.el.
6007 (Ffuncall): Handle closures.
6008 (apply_lambda): Remove `eval_flags'.
6009 (funcall_lambda): Handle closures and new byte-code-functions.
6010 (Fspecial_variable_p): New function.
6011 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6012 but without exporting it to Lisp.
6013
6014 * doc.c (Fdocumentation, store_function_docstring):
6015 * data.c (Finteractive_form): Handle closures.
6016
6017 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6018 interactive spec.
6019
6020 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6021 New byte-codes.
6022 (exec_byte_code): New function extracted from Fbyte_code to handle new
6023 calling convention for byte-code-functions. Add new byte-codes.
6024
6025 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6026
6027 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6028
6029 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6030
6031 * xdisp.c (redisplay_internal): Fix prototype.
6032
6033 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6034
6035 * xdisp.c (SCROLL_LIMIT): New macro.
6036 (try_scrolling): Use it when setting scroll_limit.
6037 Limit scrolling to 100 screen lines.
6038 (redisplay_window): Even when falling back on "recentering",
6039 position point in the window according to scroll-conservatively,
6040 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6041
6042 (try_scrolling): When point is above the window, allow searching
6043 as far as scroll_max, or one screenful, to compute vertical
6044 distance from PT to the scroll margin position. This prevents
6045 try_scrolling from unnecessarily failing when
6046 scroll-conservatively is set to a value slightly larger than the
6047 window height. Clean up the case of PT below the margin at bottom
6048 of window: scroll_max can no longer be INT_MAX. When aggressive
6049 scrolling is in use, don't let point enter the opposite scroll
6050 margin as result of the scroll.
6051 (syms_of_xdisp) <scroll-conservatively>: Document the
6052 threshold of 100 lines for never-recentering scrolling.
6053
6054 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6055
6056 * dispextern.h (move_it_by_lines):
6057 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6058 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6059 (message_log_check_duplicate): Remove parameters `prev_bol' and
6060 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6061 (redisplay_internal): Remove parameter `preserve_echo_area',
6062 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6063
6064 * indent.c (Fvertical_motion):
6065 * window.c (window_scroll_pixel_based, Frecenter):
6066 Don't pass `need_y_p' to `move_it_by_lines'.
6067
6068 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6069
6070 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6071 steal a few bits to be more compact.
6072 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6073 Remove unneeded casts.
6074
6075 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6076
6077 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6078
6079 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6080 binding" message (bug#7967).
6081
6082 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6083
6084 Fix more problems found by GCC 4.6.0's static checks.
6085
6086 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6087 Remove unused local var.
6088
6089 * editfns.c (Fmessage_box): Remove unused local var.
6090
6091 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6092 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6093 Omit unused local vars.
6094 * window.c (shrink_windows): Omit unused local var.
6095 * menu.c (digest_single_submenu): Omit unused local var.
6096 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6097 Omit unused local var.
6098
6099 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6100 Don't assume string length fits in int.
6101 (keyremap_step, read_key_sequence): Use size_t for sizes.
6102 (read_key_sequence): Don't check last_real_key_start redundantly.
6103
6104 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6105 instead of alloca (Bug#8344).
6106
6107 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6108 (Fbacktrace_frame): Don't assume nframes fits in int.
6109
6110 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6111
6112 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6113 concerns.
6114
6115 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6116
6117 * cm.c (calccost): Turn while-do into do-while, for clarity.
6118
6119 * keyboard.c (syms_of_keyboard): Use the same style as later
6120 in this function when indexing through an array. This also
6121 works around GCC bug 48267.
6122
6123 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6124
6125 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6126
6127 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6128 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6129
6130 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6131 This avoids undefined behavior on integer overflow, and is a bit
6132 more convenient anyway since it is compared to a size_t variable.
6133
6134 Variadic C functions now count arguments with size_t, not int.
6135 This avoids an unnecessary limitation on 64-bit machines, which
6136 caused (substring ...) to crash on large vectors (Bug#8344).
6137 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6138 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6139 All variadic functions and their callers changed accordingly.
6140 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6141 * data.c (arith_driver, float_arith_driver): Likewise.
6142 * editfns.c (general_insert_function): Likewise.
6143 * eval.c (struct backtrace.nargs, interactive_p)
6144 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6145 (funcall_lambda, mark_backtrace): Likewise.
6146 * fns.c (concat): Likewise.
6147 * frame.c (x_set_frame_parameters): Likewise.
6148 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6149 0 if not found, not -1. All callers changed.
6150
6151 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6152 (stack_copy_size): Now size_t, not int.
6153 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6154
6155 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6156
6157 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6158 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6159 All callers changed.
6160
6161 * lisp.h (multibyte_char_to_unibyte):
6162 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6163 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6164 * character.h (CHAR_TO_BYTE8):
6165 * cmds.c (internal_self_insert):
6166 * editfns.c (general_insert_function):
6167 * keymap.c (push_key_description):
6168 * search.c (Freplace_match):
6169 * xdisp.c (message_dolog, set_message_1): All callers changed.
6170
6171 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6172
6173 * keyboard.c (safe_run_hook_funcall): New function.
6174 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6175 don't set the hook to nil, but remove the offending function instead.
6176 (Qcommand_hook_internal): Remove, unused.
6177 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6178 Vcommand_hook_internal.
6179
6180 * eval.c (enum run_hooks_condition): Remove.
6181 (funcall_nil, funcall_not): New functions.
6182 (run_hook_with_args): Call each function through a `funcall' argument.
6183 Remove `cond' argument, now redundant.
6184 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6185 (Frun_hook_with_args_until_failure): Adjust accordingly.
6186 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6187
6188 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6189
6190 * dispextern.h (string_buffer_position): Remove declaration.
6191
6192 * print.c (strout): Remove parameter `multibyte', unused since
6193 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6194
6195 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6196 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6197 All callers changed.
6198
6199 * w32.c (_wsa_errlist): Use braces for struct initializers.
6200
6201 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6202 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6203 All callers changed.
6204 (string_buffer_position): Likewise. Also, make static (it's never
6205 used outside xdisp.c).
6206 (cursor_row_p): Remove parameter `w', unused since
6207 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6208 (decode_mode_spec): Remove parameter `precision', introduced during
6209 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6210 All callers changed.
6211
6212 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6213
6214 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6215
6216 2011-03-27 Anders Lindgren <andlind@gmail.com>
6217
6218 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6219 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6220 (ns_update_auto_hide_menu_bar): New functions.
6221 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6222 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6223 ns_constrain_all_frames.
6224 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6225 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6226
6227 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6228
6229 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6230
6231 2011-03-27 Glenn Morris <rgm@gnu.org>
6232
6233 * syssignal.h: Replace RETSIGTYPE with void.
6234 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6235 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6236 Replace SIGTYPE with void everywhere.
6237 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6238 * s/template.h (SIGTYPE): Remove commented out definition.
6239
6240 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6241
6242 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6243 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6244
6245 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6246
6247 * w32.c (read_unc_volume): Use parameter `henum', instead of
6248 global variable `wget_enum_handle'.
6249
6250 * keymap.c (describe_vector): Remove parameters `indices' and
6251 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6252 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6253
6254 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6255
6256 * keyboard.c (timer_check): Remove parameter `do_it_now',
6257 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6258 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6259 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6260
6261 * keyboard.c (read_char):
6262 * w32menu.c (w32_menu_display_help):
6263 * xmenu.c (show_help_event, menu_help_callback):
6264 Adjust calls to `show_help_echo'.
6265
6266 * gtkutil.c (xg_maybe_add_timer):
6267 * keyboard.c (readable_events):
6268 * process.c (wait_reading_process_output):
6269 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6270
6271 * insdel.c (adjust_markers_gap_motion):
6272 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6273 (gap_left, gap_right): Don't call it.
6274
6275 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6276
6277 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6278 incurred during fontification.
6279
6280 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6281
6282 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6283 (DEFVAR_PER_BUFFER): Don't pass it.
6284
6285 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6286 (scrolling_window): Don't pass it.
6287
6288 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6289
6290 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6291
6292 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6293 and `suffix'.
6294 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6295 of variables specific to SELinux and computation of `encoded_absname'.
6296
6297 * image.c (XPutPixel): Remove unused variable `height'.
6298
6299 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6300
6301 * unexw32.c (get_section_info): Remove unused variable `section'.
6302
6303 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6304 (system_process_attributes): Remove unused variable `sess'.
6305 (sys_read): Remove unused variable `err'.
6306
6307 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6308 (w32_wnd_proc): Remove unused variable `isdead'.
6309 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6310 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6311 (x_create_tip_frame): Remove unused variable `tem'.
6312
6313 * w32inevt.c (w32_console_read_socket):
6314 Remove unused variable `no_events'.
6315
6316 * w32term.c (x_draw_composite_glyph_string_foreground):
6317 Remove unused variable `width'.
6318
6319 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * w32term.c (x_set_glyph_string_clipping):
6322 Don't pass uninitialized region to CombineRgn.
6323
6324 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6325
6326 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6327 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6328 (Fx_close_connection): Remove unused variable `i'.
6329
6330 * w32font.c (w32font_draw): Return number of glyphs.
6331 (w32font_open_internal): Remove unused variable `i'.
6332 (w32font_driver): Add missing initializer.
6333
6334 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6335 (fill_in_menu): Remove unused variable `items_added'.
6336
6337 * w32term.c (last_mouse_press_frame): Remove static global variable.
6338 (w32_clip_to_row): Remove unused variable `f'.
6339 (x_delete_terminal): Remove unused variable `i'.
6340
6341 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6342 (NOTHING): Remove unused static global variable.
6343 (uniscribe_check_otf): Remove unused variable `table'.
6344 (uniscribe_font_driver): Add missing initializers.
6345
6346 2011-03-23 Julien Danjou <julien@danjou.info>
6347
6348 * term.c (Fsuspend_tty, Fresume_tty):
6349 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6350 * window.c (temp_output_buffer_show):
6351 * insdel.c (signal_before_change):
6352 * frame.c (Fhandle_switch_frame):
6353 * fileio.c (Fdo_auto_save):
6354 * emacs.c (Fkill_emacs):
6355 * editfns.c (save_excursion_restore):
6356 * cmds.c (internal_self_insert):
6357 * callint.c (Fcall_interactively):
6358 * buffer.c (Fkill_all_local_variables):
6359 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6360 Use Frun_hooks.
6361 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6362 unconditionnaly since it does the check itself.
6363
6364 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6365
6366 Fix more problems found by GCC 4.5.2's static checks.
6367
6368 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6369 the first time through the loop, since we know p0 < p1 then.
6370 This also avoids a gcc -Wstrict-overflow warning.
6371
6372 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6373 leading to a memory leak, possible in functions like
6374 load_charset_map_from_file that can allocate an unbounded number
6375 of objects (Bug#8318).
6376
6377 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6378 that could (at least in theory) be that large.
6379
6380 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6381 This is less likely to overflow, and avoids undefined behavior if
6382 overflow does occur. All callers changed. Use strtoul to scan
6383 for the unsigned long integer.
6384 (pint2hrstr): Simplify and tune code slightly.
6385 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6386
6387 * scroll.c (do_scrolling): Work around GCC bug 48228.
6388 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6389
6390 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6391 This also avoids a warning with gcc -Wstrict-overflow.
6392 (validate_x_resource_name): Simplify count usage.
6393 This also avoids a warning with gcc -Wstrict-overflow.
6394
6395 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6396 fail (Bug#8306).
6397
6398 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6399
6400 * process.c (Fmake_network_process): Use socklen_t, not int,
6401 where POSIX says socklen_t is required in portable programs.
6402 This fixes a porting bug on hosts like 64-bit HP-UX, where
6403 socklen_t is wider than int (Bug#8277).
6404 (Fmake_network_process, server_accept_connection):
6405 (wait_reading_process_output, read_process_output):
6406 Likewise.
6407
6408 * process.c: Rename or move locals to avoid shadowing.
6409 (list_processes_1, Fmake_network_process):
6410 (read_process_output_error_handler, exec_sentinel_error_handler):
6411 Rename or move locals.
6412 (Fmake_network_process): Define label "retry_connect" only if needed.
6413 (Fnetwork_interface_info): Fix pointer signedness.
6414 (process_send_signal): Add cast to avoid pointer signedness problem.
6415 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6416 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6417
6418 Make tparam.h and terminfo.c consistent.
6419 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6420 Include tparam.h instead, since it declares them.
6421 * cm.h (PC): Remove extern decl; tparam.h now does this.
6422 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6423 * terminfo.c: Include tparam.h, to check interfaces.
6424 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6425 (tparam): Adjust signature to match interface in tparam.h;
6426 this removes some undefined behavior. Check that outstring and len
6427 are zero, which they always are with Emacs.
6428 * tparam.h (PC, BC, UP): New extern decls.
6429
6430 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6431 (xftfont_open): Rename locals to avoid shadowing.
6432
6433 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6434 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6435 (OTF_TAG_SYM): Omit macro if not needed.
6436 (ftfont_list): Remove unused local.
6437 (get_adstyle_property, ftfont_pattern_entity):
6438 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6439 Rename locals to avoid shadowing.
6440
6441 * xfont.c (xfont_list_family): Mark var as initialized.
6442
6443 * xml.c (make_dom): Now static.
6444
6445 * composite.c (composition_compute_stop_pos): Rename local to
6446 avoid shadowing.
6447 (composition_reseat_it): Remove unused locals.
6448 (find_automatic_composition, composition_adjust_point): Likewise.
6449 (composition_update_it): Mark var as initialized.
6450 (find_automatic_composition): Mark vars as initialized,
6451 with a FIXME (Bug#8290).
6452
6453 character.h: Rename locals to avoid shadowing.
6454 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6455 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6456 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6457 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6458 to avoid shadowing.
6459
6460 * textprop.c (property_change_between_p): Remove; unused.
6461
6462 * intervals.c (interval_start_pos): Now static.
6463
6464 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6465
6466 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6467 Rename locals to avoid shadowing.
6468
6469 * sound.c (wav_play, au_play, Fplay_sound_internal):
6470 Fix pointer signedness.
6471 (alsa_choose_format): Remove unused local var.
6472 (wav_play): Initialize a variable to 0, to prevent undefined
6473 behavior (Bug#8278).
6474
6475 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6476
6477 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6478
6479 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6480 clobbering (Bug#8298).
6481 * sysdep.c (sys_subshell): Likewise.
6482 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6483
6484 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6485 This should get cleaned up, so that child_setup has the
6486 same signature on all platforms.
6487
6488 * callproc.c (call_process_cleanup): Now static.
6489 (relocate_fd): Rename locals to avoid shadowing.
6490
6491 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6492
6493 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6494 not to be necessary, and produces flickering.
6495
6496 2011-03-20 Glenn Morris <rgm@gnu.org>
6497
6498 * config.in: Remove file.
6499
6500 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6501
6502 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6503 are now in src/globals.h.
6504 (syms_of_minibuf): Remove spurious & from previous change.
6505
6506 2011-03-20 Leo <sdl.web@gmail.com>
6507
6508 * minibuf.c (completing-read-function): New variable.
6509 (completing-read-default): Rename from completing-read.
6510 (completing-read): Call completing-read-function.
6511
6512 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * xfaces.c (Fx_load_color_file):
6515 Read color file from absolute filename (bug#8250).
6516
6517 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6518
6519 * makefile.w32-in: Update dependencies.
6520
6521 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6522
6523 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6524
6525 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6526
6527 Fix more problems found by GCC 4.5.2's static checks.
6528
6529 * process.c (make_serial_process_unwind, send_process_trap):
6530 (sigchld_handler): Now static.
6531
6532 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6533 That way, the code declares only the vars that it needs.
6534 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6535 * s/cygwin.h (PTY_ITERATION): Likewise.
6536 * s/darwin.h (PTY_ITERATION): Likewise.
6537 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6538
6539 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6540 * process.c (allocate_pty): Don't declare stb unless it's needed.
6541
6542 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6543 (CONSTANTLIM): Remove; unused.
6544 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6545 Define only if needed.
6546
6547 * unexelf.c (unexec): Name an expression,
6548 to avoid gcc -Wbad-function-cast warning.
6549 Use a different way to cause a compilation error if anyone uses
6550 n rather than nn, a way that does not involve shadowing.
6551 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6552
6553 * deps.mk (unexalpha.o): Remove; unused.
6554
6555 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6556 * unexec.h: New file.
6557 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6558 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6559 Depend on unexec.h.
6560 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6561 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6562 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6563 Change as necessary to match prototype in unexec.h.
6564
6565 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6566 shadowing.
6567 (back_comment, skip_chars): Mark vars as initialized.
6568
6569 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6570 Rename locals to avoid shadowing.
6571
6572 * lread.c (read1): Rewrite so as not to use empty "else".
6573 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6574
6575 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6576
6577 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6578 warning when compiling print.c.
6579
6580 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6581 instead of using an uninitialized var.
6582 (font_sort_entities): Mark var as initialized.
6583
6584 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6585
6586 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6587 pointers to constants.
6588 (font_parse_fcname): Remove unused vars.
6589 (font_delete_unmatched): Now static.
6590 (font_get_spec): Remove; unused.
6591 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6592 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6593 Rename or move locals to avoid shadowing.
6594
6595 * fns.c (require_nesting_list, require_unwind): Now static.
6596 (Ffillarray): Rename locals to avoid shadowing.
6597
6598 * floatfns.c (domain_error2): Define only if needed.
6599 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6600
6601 * alloc.c (mark_backtrace): Move decl from here ...
6602 * lisp.h: ... to here, so that it can be checked.
6603
6604 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6605 (Fdefvar): Rewrite so as not to use empty "else".
6606 (lisp_indirect_variable): Name an expression,
6607 to avoid gcc -Wbad-function-cast warning.
6608 (Fdefvar): Rename locals to avoid shadowing.
6609
6610 * callint.c (quotify_arg, quotify_args): Now static.
6611 (Fcall_interactively): Rename locals to avoid shadowing.
6612 Use const pointer when appropriate.
6613
6614 * lisp.h (get_system_name, get_operating_system_release):
6615 Move decls here, to check interfaces.
6616 * process.c (get_operating_system_release): Move decl to lisp.h.
6617 * xrdb.c (get_system_name): Likewise.
6618 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6619 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6620 some of which prompt warnings from gcc -Wbad-function-cast.
6621 (Fformat_time_string, Fencode_time, Finsert_char):
6622 (Ftranslate_region_internal, Fformat):
6623 Rename or remove local vars to avoid shadowing.
6624 (Ftranslate_region_internal): Mark var as initialized.
6625
6626 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6627 avoid shadowing.
6628
6629 * lisp.h (eassert): Check that the argument compiles, even if
6630 ENABLE_CHECKING is not defined.
6631
6632 * data.c (Findirect_variable): Name an expression, to avoid
6633 gcc -Wbad-function-cast warning.
6634 (default_value, arithcompare, arith_driver, arith_error): Now static.
6635 (store_symval_forwarding): Rename local to avoid shadowing.
6636 (Fmake_variable_buffer_local, Fmake_local_variable):
6637 Mark variables as initialized.
6638 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6639
6640 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6641 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6642 Rename locals to avoid shadowing.
6643 (mark_stack): Move local variables into the #ifdef region where
6644 they're used.
6645 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6646 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6647 needed otherwise.
6648 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6649 (GC_STRING_CHARS): Remove; not used.
6650 (Fmemory_limit): Cast sbrk's returned value to char *.
6651
6652 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6653 avoids undefined behavior in theory.
6654
6655 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6656
6657 Use functions, not macros, for up- and down-casing (Bug#8254).
6658 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6659 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6660 to use the following functions instead of these macros.
6661 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6662 EMACS_INT, since callers assume the returned value fits in int.
6663 (upcase1): Likewise, for UPCASE_TABLE.
6664 (uppercasep, lowercasep, upcase): New static inline functions.
6665 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6666 the race-condition problem in the old DOWNCASE.
6667
6668 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6669 Rename locals to avoid shadowing.
6670 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6671 (regex_compile, re_search_2, re_match_2_internal):
6672 Remove unused local vars.
6673 (FREE_VAR): Rewrite so as not to use empty "else",
6674 which gcc can warn about.
6675 (regex_compile, re_match_2_internal): Mark locals as initialized.
6676 (RETALLOC_IF): Define only if needed.
6677 (WORDCHAR_P): Likewise. This one is never needed, but is used
6678 only in a comment talking about a compiler bug, so put inside
6679 the #if 0 of that comment.
6680 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6681 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6682 Remove; unused.
6683
6684 * search.c (boyer_moore): Rename locals to avoid shadowing.
6685 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6686 (PREV_CHAR_BOUNDARY): Likewise.
6687
6688 * search.c (simple_search): Remove unused var.
6689
6690 * dired.c (compile_pattern): Move decl from here ...
6691 * lisp.h: ... to here, so that it can be checked.
6692 (struct re_registers): New forward decl.
6693
6694 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6695
6696 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6697 All uses changed.
6698 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6699 Rename locals to avoid shadowing.
6700 (Fvertical_motion): Mark locals as initialized.
6701
6702 * casefiddle.c (casify_object, casify_region): Now static.
6703 (casify_region): Mark local as initialized.
6704
6705 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6706
6707 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6708 New macros, so that the caller can use some names other than
6709 gcpro1, gcpro2, etc.
6710 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6711 of the new macros.
6712 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6713 argument, for consistency with GCPRO2_VAR, etc: it is now the
6714 prefix of the variable, not the variable itself. All uses
6715 changed.
6716 * dired.c (directory_files_internal, file_name_completion):
6717 Rename locals to avoid shadowing.
6718
6719 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6720 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6721 dired.c's scmp function, had undefined behavior.
6722 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6723 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6724 * buffer.h: ... to here, because these macros use current_buffer,
6725 and the new implementation with inline functions needs to have
6726 current_buffer in scope now, rather than later when the macros
6727 are used.
6728 (downcase, upcase1): New static inline functions.
6729 (DOWNCASE, UPCASE1): Reimplement using these functions.
6730 This avoids undefined behavior in expressions like
6731 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6732 from race conditions in accessing the global variables
6733 case_temp1 and case_temp2.
6734 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6735 * lisp.h (case_temp1, case_temp2): Remove their decls.
6736 * character.h (ASCII_CHAR_P): Move from here ...
6737 * lisp.h: ... to here, so that the inline functions mentioned
6738 above can use them.
6739
6740 * dired.c (directory_files_internal_unwind): Now static.
6741
6742 * fileio.c (file_name_as_directory, directory_file_name):
6743 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6744 Now static.
6745 (file_name_as_directory): Use const pointers when appropriate.
6746 (Fexpand_file_name): Likewise. In particular, newdir might
6747 point at constant storage, so make it a const pointer.
6748 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6749 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6750 signedness issues.
6751 (Fset_file_times, Finsert_file_contents, auto_save_error):
6752 Rename locals to avoid shadowing.
6753
6754 * minibuf.c (choose_minibuf_frame_1): Now static.
6755 (Ftry_completion, Fall_completions): Rename or remove locals
6756 to avoid shadowing.
6757
6758 * marker.c (bytepos_to_charpos): Remove; unused.
6759
6760 * lisp.h (verify_bytepos, count_markers): New decls,
6761 so that gcc does not warn that these functions aren't declared.
6762
6763 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6764 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6765 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6766 (copy_text): Remove unused local var.
6767
6768 * filelock.c (within_one_second): Now static.
6769 (lock_file_1): Rename local to avoid shadowing.
6770
6771 * buffer.c (fix_overlays_before): Mark locals as initialized.
6772 (fix_start_end_in_overlays): Likewise. This function should be
6773 simplified by using pointers-to-pointers, but that's a different
6774 matter.
6775 (switch_to_buffer_1): Now static.
6776 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6777 (report_overlay_modification): Rename locals to avoid shadowing.
6778
6779 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6780 Fix pointer signedness issue.
6781 (sys_subshell): Mark local as volatile if checking for lint,
6782 to suppress a gcc -Wclobbered warning that does not seem to be right.
6783 (MAXPATHLEN): Define only if needed.
6784
6785 * process.c (serial_open, serial_configure): Move decls from here ...
6786 * systty.h: ... to here, so that they can be checked.
6787
6788 * fns.c (get_random, seed_random): Move extern decls from here ...
6789 * lisp.h: ... to here, so that they can be checked.
6790
6791 * sysdep.c (reset_io): Now static.
6792 (wait_for_termination_signal): Remove; unused.
6793
6794 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6795 (copy_keymap_item, append_key, push_text_char_description):
6796 Now static.
6797 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6798 (DENSE_TABLE_SIZE): Remove; unused.
6799 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6800 (describe_map_tree):
6801 Rename locals to avoid shadowing.
6802
6803 * keyboard.c: Declare functions static if they are not used elsewhere.
6804 (echo_char, echo_dash, cmd_error, top_level_2):
6805 (poll_for_input, handle_async_input): Now static.
6806 (read_char, kbd_buffer_get_event, make_lispy_position):
6807 (make_lispy_event, make_lispy_movement, apply_modifiers):
6808 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6809 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6810 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6811 (read_key_sequence, read_char): Mark locals as initialized.
6812 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6813
6814 * keyboard.h (make_ctrl_char): New decl.
6815 (mark_kboards): Move decl here ...
6816 * alloc.c (mark_kboards): ... from here.
6817
6818 * lisp.h (force_auto_save_soon): New decl.
6819
6820 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6821 (DEFINE_DUMMY_FUNCTION): New macro.
6822 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6823 Use it.
6824 (main): Add casts to avoid warnings
6825 if GCC considers string literals to be constants.
6826
6827 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6828
6829 * dbusbind.c: Pointer signedness fixes.
6830 (xd_signature, xd_append_arg, xd_initialize):
6831 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6832 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6833 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6834 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6835
6836 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6837 if GCC considers string literals to be constants.
6838 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6839
6840 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6841
6842 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6843 (print_preprocess, print_object): New macro to fix last change.
6844
6845 * print.c (print_preprocess): Don't forget font objects.
6846
6847 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6848
6849 * emacs.c (USAGE3): Doc fixes.
6850
6851 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6852
6853 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6854 structure.
6855
6856 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6857
6858 * lisp.h (VWindow_system, Qfile_name_history):
6859 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6860 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6861 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6862
6863 * w32select.c: Don't #include "keyboard.h".
6864 (run_protected): Add extern declaration for waiting_for_input.
6865
6866 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6867 * w32console.c (detect_input_pending, read_input_pending)
6868 (encode_terminal_code):
6869 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6870 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6871 (w32_system_caret_y, Qfile_name_history):
6872 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6873 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6874 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6875 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6876 * w32proc.c (Qlocal, report_file_error):
6877 * w32term.c (Vwindow_system, updating_frame):
6878 * w32uniscribe.c (initialized, uniscribe_font_driver):
6879 Remove unneeded extern declarations.
6880
6881 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6882
6883 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6884
6885 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6886
6887 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6888 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6889 These macros can no longer be used for assignment.
6890
6891 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6892 Assign struct members directly, instead of using BUF_BEGV etc.
6893 (record_buffer_markers, fetch_buffer_markers): New functions for
6894 recording and fetching special buffer markers.
6895 (set_buffer_internal_1, set_buffer_temp): Use them.
6896
6897 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6898
6899 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6900
6901 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6902 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6903
6904 * xdisp.c (hscroll_window_tree):
6905 (reconsider_clip_changes): Use PT instead of BUF_PT.
6906
6907 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6908
6909 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6910 $(EMACS_ROOT)/lib/intprops.h.
6911
6912 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6913
6914 Fix more problems found by GCC 4.5.2's static checks.
6915
6916 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6917 to unsigned char * to avoid compiler diagnostic.
6918 (xg_free_frame_widgets): Make it clear that a local variable is
6919 needed only if USE_GTK_TOOLTIP.
6920 (gdk_window_get_screen): Make it clear that this macro is needed
6921 only if USE_GTK_TOOLTIP.
6922 (int_gtk_range_get_value): New function, which avoids a diagnostic
6923 from gcc -Wbad-function-cast.
6924 (xg_set_toolkit_scroll_bar_thumb): Use it.
6925 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6926 diagnostic from gcc -Wbad-function-cast.
6927 (get_utf8_string, xg_get_file_with_chooser):
6928 Rename locals to avoid shadowing.
6929 (create_dialog): Move locals to avoid shadowing.
6930
6931 * xgselect.c (xg_select): Remove unused var.
6932
6933 * image.c (four_corners_best): Mark locals as initialized.
6934 (gif_load): Initialize transparent_p to zero (Bug#8238).
6935 Mark another local as initialized.
6936 (my_png_error, my_error_exit): Mark with NO_RETURN.
6937
6938 * image.c (clear_image_cache): Now static.
6939 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6940 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6941 (x_edge_detection): Remove unnecessary cast that
6942 gcc -Wbad-function-cast diagnoses.
6943 (gif_load): Fix pointer signedness.
6944 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6945 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6946
6947 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6948
6949 Improve quality of tests for time stamp overflow.
6950 For example, without this patch (encode-time 0 0 0 1 1
6951 1152921504606846976) returns the obviously-bogus value (-948597
6952 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6953 reports time overflow. See
6954 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6955 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6956 * editfns.c: Include limits.h and intprops.h.
6957 (TIME_T_MIN, TIME_T_MAX): New macros.
6958 (time_overflow): Move earlier, to before first use.
6959 (hi_time, lo_time): New functions, for an accurate test for
6960 out-of-range times.
6961 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6962 (Fget_internal_run_time): Don't assume time_t fits in int.
6963 (make_time): Use list2 instead of Fcons twice.
6964 (Fdecode_time): More accurate test for out-of-range times.
6965 (check_tm_member): New function.
6966 (Fencode_time): Use it, to test for out-of-range times.
6967 (lisp_time_argument): Don't rely on undefined left-shift and
6968 right-shift behavior when checking for time stamp overflow.
6969
6970 * editfns.c (time_overflow): New function, refactoring common code.
6971 (Fformat_time_string, Fdecode_time, Fencode_time):
6972 (Fcurrent_time_string): Use it.
6973
6974 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6975 * dired.c (make_time): Move to ...
6976 * editfns.c (make_time): ... here.
6977 * systime.h: Note the move.
6978
6979 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6980
6981 * fringe.c (update_window_fringes): Remove unused variables.
6982
6983 * unexmacosx.c (copy_data_segment): Also copy __got section.
6984 (Bug#8223)
6985
6986 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6987
6988 * termcap.c [MSDOS]: Include "msdos.h".
6989 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6990 Constify `char *' arguments and their references according to
6991 prototypes in tparam.h.
6992
6993 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6994
6995 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6996 Adapt all references accordingly.
6997
6998 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6999
7000 2011-03-11 Tom Tromey <tromey@redhat.com>
7001
7002 * buffer.c (syms_of_buffer): Remove obsolete comment.
7003
7004 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7005
7006 * termhooks.h (encode_terminal_code): Declare prototype.
7007
7008 * msdos.c (encode_terminal_code): Don't declare prototype.
7009
7010 * term.c (encode_terminal_code): Now external again, used by
7011 w32console.c and msdos.c.
7012
7013 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7014 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7015
7016 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7017
7018 Fix some minor problems found by GCC 4.5.2's static checks.
7019
7020 * fringe.c (update_window_fringes): Mark locals as initialized
7021 (Bug#8227).
7022 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7023
7024 * alloc.c (mark_fringe_data): Move decl from here ...
7025 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7026 to check its interface.
7027 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7028
7029 * fontset.c (free_realized_fontset): Now static.
7030 (Fset_fontset_font): Rename local to avoid shadowing.
7031 (fontset_font): Mark local as initialized.
7032 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7033
7034 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7035
7036 * xselect.c (x_disown_buffer_selections): Remove; not used.
7037 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7038 (x_own_selection, Fx_disown_selection_internal): Rename locals
7039 to avoid shadowing.
7040 (x_handle_dnd_message): Remove local to avoid shadowing.
7041
7042 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7043 so that the caller can use some name other than gcpro1.
7044 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7045 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7046 (Fx_backspace_delete_keys_p):
7047 Use them to avoid shadowing, and rename vars to avoid shadowing.
7048 (x_decode_color, x_set_name, x_window): Now static.
7049 (Fx_create_frame): Add braces to silence GCC warning.
7050 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7051 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7052 Remove unused locals.
7053 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7054 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7055 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7056 macros.
7057
7058 * xterm.h (x_mouse_leave): New decl.
7059
7060 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7061 Remove unused functions.
7062 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7063 (x_calc_absolute_position): Now static.
7064 (XTread_socket): Don't define label "out" unless it's used.
7065 Don't declare local "event" unless it's used.
7066 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7067 unless they are used.
7068 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7069 (x_fatal_error_signal): Remove; not used.
7070 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7071 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7072 (x_error_catcher, x_connection_closed, x_error_handler):
7073 (x_error_quitter, xembed_send_message, x_iconify_frame):
7074 (my_log_handler): Rename locals to avoid shadowing.
7075 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7076 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7077
7078 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7079 Rename or move locals to avoid shadowing.
7080 (tty_defined_color, merge_face_heights): Now static.
7081 (free_realized_faces_for_fontset): Remove; not used.
7082 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7083 does not deduce is never used uninitialized.
7084 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7085 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7086
7087 * terminal.c (store_terminal_param): Now static.
7088
7089 * xmenu.c (menu_highlight_callback): Now static.
7090 (set_frame_menubar): Remove unused local.
7091 (xmenu_show): Rename parameter to avoid shadowing.
7092 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7093 since they might point to immutable storage.
7094 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7095 since it's unused otherwise.
7096
7097 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7098 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7099 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7100 avoids a gcc -Wuninitialized diagnostic.
7101 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7102 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7103 does not deduce are never used uninitialized.
7104
7105 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7106
7107 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7108 * window.c (window_loop, size_window):
7109 (run_window_configuration_change_hook, enlarge_window): Likewise.
7110
7111 * window.c (display_buffer): Now static.
7112 (size_window): Mark variables that gcc -Wuninitialized
7113 does not deduce are never used uninitialized.
7114 * window.h (check_all_windows): New decl, to forestall
7115 gcc -Wmissing-prototypes diagnostic.
7116 * dispextern.h (bidi_dump_cached_states): Likewise.
7117
7118 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7119 shadowing.
7120 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7121 Include <limits.h>.
7122 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7123 and to avoid gcc -Wuninitialized warning.
7124 (load_charset_map): Mark variables that gcc -Wuninitialized
7125 does not deduce are never used uninitialized.
7126 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7127
7128 * coding.c (coding_set_source, coding_set_destination):
7129 Use "else { /* comment */ }" rather than "else /* comment */;"
7130 for clarity, and to avoid gcc -Wempty-body warning.
7131 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7132 a block, when the outer 'i' will do.
7133 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7134 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7135 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7136 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7137 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7138 Rename locals to avoid shadowing.
7139 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7140 * coding.c (emacs_mule_char, encode_invocation_designation):
7141 Now static, since they're not used elsewhere.
7142 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7143 (decode_coding_object, encode_coding_object, detect_coding_system):
7144 (decode_coding_emacs_mule): Mark variables that gcc
7145 -Wuninitialized does not deduce are never used uninitialized.
7146 (detect_coding_iso_2022): Initialize a local variable that might
7147 be used uninitialized. Leave a FIXME because it's not clear that
7148 this initialization is needed. (Bug#8211)
7149 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7150 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7151 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7152 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7153 Remove unused macros.
7154
7155 * category.c (hash_get_category_set): Remove unused local var.
7156 (copy_category_table): Now static, since it's not used elsewhere.
7157 * character.c (string_count_byte8): Likewise.
7158
7159 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7160 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7161
7162 * chartab.c (copy_sub_char_table): Now static, since it's not used
7163 elsewhere.
7164 (sub_char_table_ref_and_range, char_table_ref_and_range):
7165 Rename locals to avoid shadowing.
7166 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7167
7168 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7169 (BIDI_BOB): Remove unused macro.
7170
7171 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7172 deduce are never used uninitialized.
7173 * term.c (encode_terminal_code): Likewise.
7174
7175 * term.c (encode_terminal_code): Now static. Remove unused local.
7176
7177 * tparam.h: New file.
7178 * term.c, tparam.h: Include it.
7179 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7180 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7181 Move these decls to tparam.h, and make them agree with what
7182 is actually in tparam.c. The previous trick of using incompatible
7183 decls in different modules does not conform to the C standard.
7184 All callers of tparam changed to use tparam's actual API.
7185 * tparam.c (tparam1, tparam, tgoto):
7186 Use const pointers where appropriate.
7187
7188 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7189 * cm.h (struct cm): Likewise.
7190 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7191 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7192 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7193 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7194 (turn_on_face, init_tty): Likewise.
7195 * termchar.h (struct tty_display_info): Likewise.
7196
7197 * term.c (term_mouse_position): Rename local to avoid shadowing.
7198
7199 * alloc.c (mark_ttys): Move decl from here ...
7200 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7201
7202 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7203
7204 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7205
7206 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7207
7208 * search.c (compile_pattern_1): Remove argument regp, unused since
7209 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7210 (compile_pattern): Don't pass it.
7211
7212 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7213
7214 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7215 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7216 for ! HAVE_GTK3.
7217 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7218
7219 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7220
7221 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7222 gdk_window_get_screen, gdk_window_get_geometry,
7223 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7224 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7225 (xg_get_pixbuf_from_pixmap): New function.
7226 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7227 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7228 Call xg_get_pixbuf_from_pixmap instead of
7229 gdk_pixbuf_get_from_drawable.
7230 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7231 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7232 (xg_check_special_colors): Use GtkStyleContext and its functions
7233 for HAVE_GTK3.
7234 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7235 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7236 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7237 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7238 Call gtk_widget_get_preferred_size.
7239 (xg_frame_resized): gdk_window_get_geometry only takes 5
7240 parameters.
7241 (xg_win_to_widget, xg_event_is_for_menubar):
7242 Call gdk_x11_window_lookup_for_display.
7243 (xg_set_widget_bg): New function.
7244 (delete_cb): New function.
7245 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7246 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7247 (xg_set_background_color): Call xg_set_widget_bg.
7248 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7249 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7250 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7251 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7252 if ! HAVE_GTK3.
7253 (update_frame_tool_bar): Call gtk_widget_hide.
7254 (xg_initialize): Use GDK_KEY_g.
7255
7256 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7257 if ! HAVE_GTK3
7258 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7259
7260 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7261 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7262 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7263
7264 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7265
7266 * w32xfns.c (select_palette): Check success of RealizePalette against
7267 GDI_ERROR, not zero.
7268
7269 See ChangeLog.11 for earlier changes.
7270
7271 ;; Local Variables:
7272 ;; coding: utf-8
7273 ;; End:
7274
7275 Copyright (C) 2011 Free Software Foundation, Inc.
7276
7277 This file is part of GNU Emacs.
7278
7279 GNU Emacs is free software: you can redistribute it and/or modify
7280 it under the terms of the GNU General Public License as published by
7281 the Free Software Foundation, either version 3 of the License, or
7282 (at your option) any later version.
7283
7284 GNU Emacs is distributed in the hope that it will be useful,
7285 but WITHOUT ANY WARRANTY; without even the implied warranty of
7286 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7287 GNU General Public License for more details.
7288
7289 You should have received a copy of the GNU General Public License
7290 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.