1 2012-06-06 Chong Yidong <cyd@gnu.org>
3 * buffer.c (word_wrap): Doc fix.
5 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
7 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
9 2012-06-03 Glenn Morris <rgm@gnu.org>
11 * xdisp.c (tool-bar-style): Doc fix.
13 2012-06-03 Ulrich Müller <ulm@gentoo.org>
15 * Makefile.in (PAXCTL): Define.
16 (temacs$(EXEEXT)): Disable memory randomization for the temacs
17 binary via PaX flags if the paxctl utility is available.
18 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
19 Restore PaX flags to their default. (Bug#11398)
21 2012-06-03 Chong Yidong <cyd@gnu.org>
23 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
26 2012-06-03 Chong Yidong <cyd@gnu.org>
28 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
29 (note_mode_line_or_margin_highlight): If there is no help echo,
30 use mode-line-default-help-echo. Handle the case where the mouse
31 position is past the end of the mode line string.
33 * buffer.c (buffer_local_value_1): New function, split from
34 Fbuffer_local_value; can return Qunbound.
35 (Fbuffer_local_value): Use it.
36 (Vmode_line_format): Docstring tweaks.
38 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
40 * sysdep.c (system_process_attributes): Improve comment.
42 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
44 * keyboard.c: Export real-this-command to Elisp.
45 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
46 and DEFVAR it. Update all users.
48 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
50 * minibuf.c (Fassoc_string): Remove duplicate declaration.
52 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
53 Convert pctcpu and pctmem to Lisp float properly.
54 Let the compiler fold better, as 100.0/0x8000 is exact.
56 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
58 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
61 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
63 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
65 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
67 For a 'struct window', replace some Lisp_Object fields to
68 bitfields where appropriate, remove unused fields.
69 * window.h (struct window): Remove unused 'last_mark_x' and
70 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
71 change it's type from Lisp_Object to bitfield.
72 Change type of 'force_start', 'optional_new_start',
73 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
74 fields from Lisp_Object to bitfield. Adjust users accordingly.
76 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
78 Pacify gcc -Wdouble-precision when using Xaw.
79 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
80 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
81 Use 'float' consistently, rather than 'float' in most places
82 and 'double' in a couple of places.
84 2012-05-31 Eli Zaretskii <eliz@gnu.org>
86 * xdisp.c (handle_stop): Detect whether we have overlay strings
87 loaded by testing it->current.overlay_string_index to be
88 non-negative, instead of checking whether n_overlay_strings is
91 2012-05-31 Chong Yidong <cyd@gnu.org>
93 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
95 * doc.c (Fsubstitute_command_keys): Doc fix.
97 2012-05-31 Eli Zaretskii <eliz@gnu.org>
99 * search.c (search_buffer): Remove calls to
100 r_alloc_inhibit_buffer_relocation, as it is now called by
101 maybe_unify_char, which was the cause of relocation of buffer text
104 2012-05-31 Eli Zaretskii <eliz@gnu.org>
106 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
107 for the duration of call to load_charset, to avoid problems with
108 callers of maybe_unify_char that access buffer text through C
111 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
112 decrement the inhibition flag, instead of just setting or
115 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
117 Remove obsolete '#define static' cruft.
118 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
119 This #undef was "temporary" in 2000; it is no longer needed
120 now that '#define static' has gone away.
121 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
122 (gray_bitmap_bits): Remove; no longer needed.
123 All uses replaced with definiens.
124 * xterm.c: Include "bitmaps/gray.xbm".
126 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
128 Clean up __executable_start, monstartup when --enable-profiling.
129 The following changes affect the code only when profiling.
130 * dispnew.c (__executable_start): Rename from safe_bcopy.
131 Define only on platforms that need it.
132 * emacs.c: Include <sys/gmon.h> when profiling.
133 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
134 (__executable_start): Remove decl, since lisp.h does it now.
135 (safe_bcopy): Remove decl; no longer has that name.
136 (main): Coalesce #if into single bit of code, for simplicity.
137 Cast pointers to uintptr_t, since standard libraries want integers
139 * lisp.h (__executable_start): New decl.
141 2012-05-31 Glenn Morris <rgm@gnu.org>
143 * image.c (Fimagemagick_types): Doc fix.
145 2012-05-30 Jim Meyering <meyering@redhat.com>
147 * callproc.c (Fcall_process_region): Include directory component
148 in mkstemp error message (Bug#11586).
150 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
152 * alloc.c, lisp.h (make_pure_vector): Now static.
154 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
156 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
158 (Fautoload): Do the hash-doc more carefully.
159 * data.c (Fdefalias): Purify definition, except for keymaps.
160 (Qdefun): Move from eval.c.
161 * lisp.h (Qdefun): Remove.
162 * lread.c (read1): Tiny simplification.
164 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
166 Do not create empty overlays with the evaporate property (Bug#9642).
167 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
168 Bug#9642, but explicitly check that the buffer the overlay would
169 be moved to is live and rearrange lines to make sure that errors
170 will not put the overlay in an inconsistent state.
171 (Fdelete_overlay): Cosmetics.
173 2012-05-28 Eli Zaretskii <eliz@gnu.org>
175 * w32term.c (my_bring_window_to_top): New function.
176 (x_raise_frame): Use handle returned by DeferWindowPos, which
177 could be different from the original one.
178 Call my_bring_window_to_top instead of my_set_foreground_window.
181 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
182 by calling BringWindowToTop.
184 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
185 (WM_EMACS_END): Increase by one.
187 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
189 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
190 This avoids undefined behavior that might cause the eassert
191 to not catch an out-of-range value.
193 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
195 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
198 2012-05-27 Eli Zaretskii <eliz@gnu.org>
200 * bidi.c (bidi_mirror_char): Fix last change.
202 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
204 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
205 when referring to sectname field in printf format.
207 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
209 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
210 Only r_alloc_inhibit_buffer_relocation needed to be added;
211 the others were already declared.
213 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
214 before checking whether it's out of range. Put the check inside
216 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
218 2012-05-27 Ken Brown <kbrown@cornell.edu>
220 * callproc.c (Fcall_process): Restore a line that was accidentally
221 commented out in the 2011-02-13 change (bug#11547).
223 2012-05-27 Eli Zaretskii <eliz@gnu.org>
225 * lisp.h [REL_ALLOC]: Add prototypes for external functions
228 * buffer.c [REL_ALLOC]: Remove prototypes of
229 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
230 they are now on lisp.h.
232 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
234 * search.c (search_buffer): Use it to inhibit relocation of buffer
235 text while re_search_2 is doing its job, because re_search_2 is
236 passed C pointers to buffer text. (Bug#11519)
238 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
241 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
242 state after an additional call to move_it_in_display_line_to, keep
243 the values of it->max_ascent and it->max_descent found for the
245 (pos_visible_p): Revert the comparison against bottom_y to what it
246 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
249 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
251 Fix coding-related core dumps with gcc -ftrapv.
252 The code was computing A - B, where A and B are pointers, and B is
253 random garbage. This can lead to core dumps on platforms that
254 have special pointer registers, and it also leads to core dumps on
255 x86-64 when compiled with gcc -ftrapv. The fix is to compute
256 A - B only when B is initialized properly.
257 * coding.c (coding_set_source, coding_set_destination): Return void.
258 (coding_change_source, coding_change_destinations): New functions,
259 with the old behaviors of coding_set_source and coding_set_destination.
260 All callers that need an offset changed to use these new functions.
262 2012-05-26 Glenn Morris <rgm@gnu.org>
264 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
266 2012-05-26 Eli Zaretskii <eliz@gnu.org>
268 Extend mouse support on W32 text-mode console.
269 * xdisp.c (draw_row_with_mouse_face):
270 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
272 * w32console.c: Include window.h.
273 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
275 (initialize_w32_display): Initialize mouse-highlight data.
277 * w32inevt.c: Include termchar.h and window.h.
278 (do_mouse_event): Support mouse-autoselect-window. When the mouse
279 moves, call note_mouse_highlight. If help_echo changed, call
280 gen_help_event to produce help-echo message in the echo area.
281 Call clear_mouse_face if mouse_face_hidden is set in the mouse
284 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
286 * lread.c (read1): Simplify slightly to avoid an overflow warning
287 with GCC 4.7.0 on x86-64.
289 2012-05-26 Eli Zaretskii <eliz@gnu.org>
291 * bidi.c (bidi_mirror_char): Revert last change: an int is
292 definitely wide enough here.
294 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
296 Fix integer width and related bugs (Bug#9874).
297 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
298 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
299 (string_bytes, check_sblock, allocate_string_data):
300 (compact_small_strings, Fmake_bool_vector, make_string)
301 (make_unibyte_string, make_multibyte_string)
302 (make_string_from_bytes, make_specified_string)
303 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
304 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
307 (allocate_pseudovector):
308 Use int, not EMACS_INT, where int is wide enough.
309 (inhibit_garbage_collection, Fgarbage_collect):
310 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
311 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
312 int might not be wide enough.
313 (bidi_cache_search, bidi_cache_find, bidi_init_it)
314 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
315 (bidi_at_paragraph_end, bidi_find_paragraph_start)
316 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
317 (bidi_level_of_next_char, bidi_move_to_visually_next):
318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
319 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
320 (Fkill_buffer, Fset_buffer_major_mode)
321 (advance_to_char_boundary, Fbuffer_swap_text)
322 (Fset_buffer_multibyte, overlays_at, overlays_in)
323 (overlay_touches_p, struct sortvec, record_overlay_string)
324 (overlay_strings, recenter_overlay_lists)
325 (adjust_overlays_for_insert, adjust_overlays_for_delete)
326 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
327 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
328 (Foverlay_recenter, last_overlay_modification_hooks_used)
329 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
331 (validate_region): Omit unnecessary test for b <= e,
332 since that's guaranteed by the previous test.
333 (adjust_overlays_for_delete): Avoid pos + length overflow.
334 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
335 (report_overlay_modification):
336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
337 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
338 Omit pointer cast, which isn't needed anyway, and doesn't work
339 after the EMACS_INT -> ptrdiff_t change.
340 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
341 * buffer.h: Adjust decls to match defn changes elsewhere.
342 (struct buffer_text, struct buffer):
343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
344 Use EMACS_INT, not int, where int might not be wide enough.
345 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
346 not int, to avoid needless 32-bit limit on 64-bit hosts.
347 (exec_byte_code): Use tighter memory-full test, one that checks
348 for alloca overflow. Don't compute the address of the object just
349 before an array, as that's not portable. Use EMACS_INT, not
350 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
351 * callint.c (Fcall_interactively):
352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
353 * callproc.c (call_process_kill, Fcall_process):
354 Don't assume pid_t fits into an Emacs fixnum.
355 (call_process_cleanup, Fcall_process, child_setup):
356 Don't assume pid_t fits into int.
357 (call_process_cleanup, Fcall_process, delete_temp_file)
358 (Fcall_process_region):
359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
360 (Fcall_process): Simplify handling of volatile integers.
361 Use int, not EMACS_INT, where int will do.
362 * casefiddle.c (casify_object, casify_region, operate_on_word)
363 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
365 (casify_object): Avoid integer overflow when overallocating buffer.
366 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
367 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
368 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
369 * category.h (CATEGORYP): Don't assume arg is nonnegative.
370 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
371 integers are now checked earlier. All uses replaced with XINT.
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 For CCL_MapSingle, check that content and value are in int range.
375 (ccl_driver, Fregister_code_conversion_map):
376 Check that Vcode_version_map_vector is a vector.
377 (resolve_symbol_ccl_program): Check that vector header is in range.
378 Always copy the vector, so that we can check its contents reliably
379 now rather than having to recheck each instruction as it's being
380 executed. Check that vector words fit in 'int'.
381 (ccl_get_compiled_code, Fregister_ccl_program)
382 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
383 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
384 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
385 contents are in range.
386 (Fccl_execute_on_string): Check that status is in range.
387 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
388 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
389 Accept and return EMACS_INT, not int, because callers can pass values
391 (c_string_width, strwidth, lisp_string_width, chars_in_text)
392 (multibyte_chars_in_text, parse_str_as_multibyte)
393 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
394 (str_as_unibyte, str_to_unibyte, string_count_byte8)
395 (string_escape_byte8, Fget_byte):
396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
397 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
398 avoid mishandling large integers.
399 * character.h: Adjust decls to match defn changes elsewhere.
400 * charset.c (load_charset_map_from_file, find_charsets_in_text)
401 (Ffind_charset_region):
402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
403 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
404 (load_charset_map_from_vector, Fdefine_charset_internal):
405 Don't assume fixnum fits in int.
406 (load_charset_map_from_vector, Fmap_charset_chars):
407 Remove now-unnecessary CHECK_NATNUMs.
408 (Fdefine_charset_internal): Check ranges here, more carefully.
409 Don't rely on undefined behavior with signed left shift overflow.
410 Don't assume unsigned int fits into fixnum, or that fixnum fits
411 into unsigned int. Don't require max_code to be a valid fixnum;
412 that's not true for gb10830 4-byte on a 32-bit host. Allow
413 invalid_code to be a cons, for the same reason. Require code_offset
414 to be a character. Avoid int overflow if max_char is close
416 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
417 this is intended anyway and avoids some undefined behavior.
418 (load_charset_map): Pass unsigned, not int, as 2nd arg of
419 INDEX_TO_CODE_POINT, as that's what it expects.
420 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
421 * charset.h (DECODE_CHAR): Return int, not unsigned;
422 this is what was intended anyway, and it avoids undefined behavior.
423 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
424 integer-overflow issues.
425 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
426 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
427 where the argument is EMACS_INT, and this behavior is not intended.
428 * chartab.c (Fmake_char_table, Fset_char_table_range)
429 (uniprop_get_decoder, uniprop_get_encoder):
430 Don't assume fixnum fits in int.
431 * cmds.c (move_point): New function, that does the gist of
432 Fforward_char and Fbackward_char, but does so while checking
433 for integer overflow more accurately.
434 (Fforward_char, Fbackward_char): Use it.
435 (Fforward_line, Fend_of_line, internal_self_insert)
436 (internal_self_insert):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 Fix a FIXME, by checking for integer overflow when calculating
439 target_clm and actual_clm.
440 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
441 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
442 (ASSURE_DESTINATION, coding_alloc_by_realloc)
443 (coding_alloc_by_making_gap, alloc_destination)
444 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
445 (encode_coding_utf_16, detect_coding_emacs_mule)
446 (decode_coding_emacs_mule, encode_coding_emacs_mule)
447 (detect_coding_iso_2022, decode_coding_iso_2022)
448 (encode_invocation_designation, encode_designation_at_bol)
449 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
450 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
451 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
452 (encode_coding_ccl, encode_coding_raw_text)
453 (detect_coding_charset, decode_coding_charset)
454 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
455 (produce_composition, produce_charset, produce_annotation)
456 (decode_coding, handle_composition_annotation)
457 (handle_charset_annotation, consume_chars, decode_coding_gap)
458 (decode_coding_object, encode_coding_object, detect_coding_system)
459 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
460 (code_convert_region, code_convert_string)
461 (Fdefine_coding_system_internal)
462 (coding_set_source, coding_set_destination):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
465 (Fdefine_coding_system_internal):
466 Don't assume fixnums fit in int.
467 (decode_coding_gap, decode_coding_object, encode_coding_object)
468 (Fread_coding_system, Fdetect_coding_region)
469 (Funencodable_char_position, Fcheck_coding_systems_region)
470 (get_translation, handle_composition_annotation, consume_chars):
471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
472 (consume_chars): Rewrite to not calculate an address outside buffer.
473 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
474 Don't access memory outside of the args array.
475 (Fdefine_coding_system_internal): Check for charset-id overflow.
476 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
477 result of ENCODE_CHAR.
478 * coding.h: Adjust decls to match defn changes elsewhere.
479 (struct coding_system):
480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
481 * composite.c (get_composition_id, find_composition)
482 (run_composition_function, update_compositions)
483 (compose_text, composition_gstring_put_cache)
484 (composition_gstring_p, composition_gstring_width)
485 (fill_gstring_header, fill_gstring_body, autocmp_chars)
486 (composition_compute_stop_pos, composition_reseat_it)
487 (composition_update_it, struct position_record)
488 (find_automatic_composition, composition_adjust_point)
489 (Fcomposition_get_gstring, Ffind_composition_internal):
490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
491 (update_compositions):
492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
493 * composite.h: Adjust decls to match defn changes elsewhere.
494 (struct composition):
495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
496 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
497 Do not attempt to compute the address of the object just before a
498 buffer; this is not portable.
500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
501 (Faset): Use int, not EMACS_INT, where int is wide enough.
502 (Fstring_to_number): Don't assume fixnums fit in int.
503 (Frem): Don't assume arg is nonnegative.
504 * dbusbind.c (xd_append_arg): Check for integers out of range.
505 (Fdbus_call_method): Don't overflow the timeout int.
506 (extract_signed, extract_unsigned): New functions.
507 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
508 (xd_get_connection_references): Return ptrdiff_t, not int.
510 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
512 Use int, not unsigned, where the dbus API uses int.
513 (Fdbus_message_internal): Don't overflow mtype.
514 (syms_of_dbusbind): Allocate right-sized buffer for integers.
515 * dired.c (directory_files_internal, file_name_completion, scmp)
516 (file_name_completion_stat):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (file_name_completion): Don't overflow matchcount.
519 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
520 * dispextern.h: Adjust decls to match defn changes elsewhere.
521 (struct text_pos, struct glyph, struct bidi_saved_info)
522 (struct bidi_string_data, struct bidi_it, struct composition_it)
524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
525 (struct display_pos, struct composition_it, struct it):
526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
527 * dispnew.c (increment_matrix_positions)
528 (increment_row_positions, mode_line_string)
529 (marginal_area_string):
530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
531 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
533 (duration_to_sec_usec): New function, to check for overflow better.
534 (Fsleep_for, sit_for): Use it.
535 * doc.c (get_doc_string, store_function_docstring):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (get_doc_string, Fsnarf_documentation):
538 Use int, not EMACS_INT, where int is wide enough.
540 Use SAFE_ALLOCA, not alloca.
541 Check for overflow when converting EMACS_INT to off_t.
543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
544 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
545 Don't assume uid_t fits into fixnum.
546 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
547 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
548 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
549 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
550 (general_insert_function)
551 (Finsert_char, make_buffer_string, make_buffer_string_both)
552 (update_buffer_properties, Fbuffer_substring)
553 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
554 (Fsubst_char_in_region, check_translation)
555 (Ftranslate_region_internal, save_restriction_restore, Fformat)
556 (transpose_markers, Ftranspose_regions):
557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
558 (clip_to_bounds): Move to lisp.h as an inline function).
559 (Fconstrain_to_field): Don't assume integers are nonnegative.
560 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
561 (Fsubst_char_in_region, Fsave_restriction):
562 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
563 (Femacs_pid): Don't assume pid_t fits into fixnum.
564 (lo_time): Use int, not EMACS_INT, when int suffices.
565 (lisp_time_argument): Check for usec out of range.
566 (Fencode_time): Don't assume fixnum fits in int.
567 (Fuser_login_name, Fuser_full_name): Signal an error
568 if a uid argument is out of range, rather than relying on
570 (Fformat_time_string): Remove now-unnecessary check.
571 lisp_time_argument checks for out-of-range usec now.
572 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
573 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
574 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
575 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
576 (init_cmdargs, Fdump_emacs):
577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
578 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
579 the bottom (typically) 32 bits of the fixnum.
580 * eval.c (specpdl_size, call_debugger):
581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
582 (when_entered_debugger, Fbacktrace_debug):
583 Don't assume fixnum can fit in int.
584 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
585 the object just before a buffer; this is not portable.
586 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
587 (grow_specpdl, unbind_to):
588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
589 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
590 (grow_specpdl): Simplify allocation by using xpalloc.
591 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
592 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
593 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
595 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
598 (Fcopy_file, non_regular_nbytes, read_non_regular)
599 (Finsert_file_contents):
600 Use int, not EMACS_INT, where int is wide enough.
601 (READ_BUF_SIZE): Verify that it fits in int.
602 (Finsert_file_contents): Check that counts are in proper range,
603 rather than assuming fixnums fit into ptrdiff_t etc.
604 Don't assume fixnums fit into int.
605 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
606 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
607 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
608 (string_char_to_byte, string_byte_to_char)
609 (string_make_multibyte, string_to_multibyte)
610 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
611 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
612 (substring_both, Fdelete, internal_equal, Ffillarray)
613 (Fclear_string, mapcar1)
614 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
615 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
616 (larger_vector, make_hash_table, maybe_resize_hash_table)
617 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
618 (Fmaphash, secure_hash):
619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
620 (concat): Check for string index and length overflow.
621 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
624 (larger_vector): New API (vec, incr_min, size_max) replaces old
625 one (vec, new_size, init). This catches size overflow.
626 INIT was removed because it was always Qnil.
628 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
629 the upper bound on a hash table index size.
630 (make_hash_table, maybe_resize_hash_table): Use it.
631 (secure_hash): Computer start_byte and end_byte only after
632 they're known to be in ptrdiff_t range.
633 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
634 (Ffont_get_glyphs, Ffont_at):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
637 (Flist_fonts, Fopen_font):
638 Don't assume fixnum can fit in int.
639 (check_gstring): Don't assume index can fit in int.
640 (font_match_p): Check that fixnum is a character, not a nonnegative
641 fixnum, since the later code needs to stuff it into an int.
642 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
643 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
644 conversion overflow issues.
645 (Fopen_font): Check for integer out of range.
646 (Ffont_get_glyphs): Don't assume index can fit in int.
647 * font.h: Adjust decls to match defn changes elsewhere.
648 * fontset.c (reorder_font_vector): Redo score calculation to avoid
650 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
651 printmax_t, where ptrdiff_t is wide enough.
652 (Finternal_char_font):
653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
654 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
655 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
656 (Fset_frame_position, x_set_frame_parameters)
657 (x_set_line_spacing, x_set_border_width)
658 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
659 Check that fixnums are in proper range for system types.
660 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
662 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
663 Use SAFE_ALLOCA_LISP, not alloca.
664 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
665 intptr_t is wide enough.
666 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
667 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
668 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
669 Check for fixnum out of range.
670 * ftfont.c (ftfont_list): Don't assume index fits in int.
671 Check that fixnums are in proper range for system types.
672 (ftfont_shape_by_flt):
673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
674 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
676 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
677 Check that fixnums are in proper range for system types.
678 * gnutls.h: Adjust decls to match defn changes elsewhere.
679 * gtkutil.c (xg_dialog_run):
680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
681 (update_frame_tool_bar):
682 Check that fixnums are in proper range for system types.
683 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
684 (lookup_image): Check that fixnums are in range for system types.
685 * indent.c (last_known_column, last_known_column_point):
686 (current_column_bol_cache):
687 (skip_invisible, current_column, check_display_width):
688 (check_display_width, scan_for_column, current_column_1)
689 (Findent_to, Fcurrent_indentation, position_indentation)
690 (indented_beyond_p, Fmove_to_column, compute_motion):
691 (Fcompute_motion, Fvertical_motion):
692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
693 (last_known_column_modified): Use EMACS_INT, not int.
694 (check_display_width):
696 Check that fixnums and floats are in proper range for system types.
697 (compute_motion): Don't assume index or fixnum fits in int.
698 (compute_motion, Fcompute_motion):
699 Use int, not EMACS_INT, when it is wide enough.
700 (vmotion): Omit local var start_hpos that is always 0; that way
701 we don't need to worry about overflow in expressions involving it.
702 * indent.h: Adjust decls to match defn changes elsewhere.
704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
705 Use int, not EMACS_INT, where int is wide enough.
706 Remove unused members ovstring_chars_done and tab_offset;
708 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
709 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
710 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
711 (make_gap, copy_text, insert, insert_and_inherit)
712 (insert_before_markers, insert_before_markers_and_inherit)
713 (insert_1, count_combining_before, count_combining_after)
714 (insert_1_both, insert_from_string)
715 (insert_from_string_before_markers, insert_from_string_1)
716 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
717 (adjust_after_replace, adjust_after_insert, replace_range)
718 (replace_range_2, del_range, del_range_1, del_range_byte)
719 (del_range_both, del_range_2, modify_region)
720 (prepare_to_modify_buffer, signal_before_change)
721 (signal_after_change, Fcombine_after_change_execute):
722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
723 * intervals.c (traverse_intervals, rotate_right, rotate_left)
724 (balance_an_interval, split_interval_right, split_interval_left)
725 (find_interval, next_interval, update_interval)
726 (adjust_intervals_for_insertion, delete_node, delete_interval)
727 (interval_deletion_adjustment, adjust_intervals_for_deletion)
728 (static_offset_intervals, offset_intervals)
729 (merge_interval_right, merge_interval_left, make_new_interval)
730 (graft_intervals_into_buffer, temp_set_point_both)
731 (temp_set_point, set_point, adjust_for_invis_intang)
732 (set_point_both, move_if_not_intangible, get_property_and_range)
733 (get_local_map, copy_intervals, copy_intervals_to_string)
734 (compare_string_intervals, set_intervals_multibyte_1):
735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
736 * intervals.h: Adjust decls to match defn changes elsewhere.
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
739 * keyboard.c (this_command_key_count, this_single_command_key_start)
740 (before_command_key_count, before_command_echo_length, echo_now)
741 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
742 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
743 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
744 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 (last_non_minibuf_size, last_point_position, echo_truncate)
747 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
748 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
749 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
750 (stuff_buffered_input):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 (last_auto_save, command_loop_1, read_char):
753 Use EMACS_INT, not int, to avoid integer overflow.
754 (record_char): Avoid overflow in total_keys computation.
755 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
756 * keyboard.h: Adjust decls to match defn changes elsewhere.
757 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
758 (Fkey_description, Fdescribe_vector, Flookup_key):
759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
760 (click_position): New function, to check that positions are in range.
761 (Fcurrent_active_maps):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 (Faccessible_keymaps, Fkey_description):
765 (preferred_sequence_p):
766 Don't assume fixnum can fit into int.
767 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
768 Check for integer overflow in size calculations.
769 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
770 avoid mishandling large integers.
771 * lisp.h: Adjust decls to match defn changes elsewhere.
772 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
773 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
774 (struct Lisp_Marker):
775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
776 (clip_to_bounds): Now an inline function, moved here from editfns.c.
777 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
778 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
780 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
781 Assume the arg has valid form, since it always does.
782 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
783 unsigned integer system type.
784 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
785 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
787 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
788 (duration_to_sec_usec): New decl.
789 * lread.c (read_from_string_index, read_from_string_index_byte)
790 (read_from_string_limit, readchar, unreadchar, openp)
791 (read_internal_start, read1, oblookup):
792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
793 (Fload, readevalloop, Feval_buffer, Feval_region):
794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
795 (openp): Check for out-of-range argument to 'access'.
796 (read1): Use int, not EMACS_INT, where int is wide enough.
797 Don't assume fixnum fits into int.
798 Fix off-by-one error that can read outside a buffer.
799 (read_filtered_event): Use duration_to_sec_usec
800 to do proper overflow checking on durations.
801 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
803 (Fexecute_kbd_macro):
804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
805 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
806 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
807 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
808 (set_marker_both, set_marker_restricted_both, marker_position)
809 (marker_byte_position, Fbuffer_has_markers_at):
810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
811 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
812 * menu.c (ensure_menu_items): Rename from grow_menu_items.
813 It now merely ensures that the menu is large enough, without
814 necessarily growing it, as this avoids some integer overflow issues.
816 (keymap_panes, parse_single_submenu, Fx_popup_menu):
817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
818 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
819 Use SAFE_ALLOCA_LISP, not alloca.
820 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
821 to EMACS_INT. Check that fixnums are in proper range for system types.
822 * minibuf.c (minibuf_prompt_width, string_to_object)
823 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
824 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
826 (get_minibuffer, read_minibuf_unwind):
827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
828 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
829 this simplifies overflow checking. All callers changed.
830 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
833 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
834 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
835 Check that fixnums are in proper range for system types.
836 (Fx_create_frame, Fx_show_tip):
837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
838 * nsfont.m (ns_findfonts, nsfont_list_family):
839 Don't assume fixnum fits in long.
840 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
842 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
844 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
846 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
847 (PRINTDECLARE, PRINTPREPARE):
848 (strout, print_string):
849 (print, print_preprocess, print_check_string_charset_prop)
851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
853 (temp_output_buffer_setup, Fprin1_to_string, print_object):
854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
855 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
856 (printchar, strout): Use xpalloc to catch size calculation overflow.
857 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
858 (print_error_message): Use SAFE_ALLOCA, not alloca.
859 (print_object): Use int, not EMACS_INT, where int is wide enough.
860 (print_depth, new_backquote_output, print_number_index):
861 Use ptrdiff_t, not int, where int might not be wide enough.
862 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
863 (Fset_process_window_size, Fformat_network_address)
864 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
866 Check that fixnums are in proper range for system types.
867 (Fsignal_process): Simplify by avoiding a goto.
868 Check for process-ids out of pid_t range rather than relying on
870 (process_tick, update_tick): Use EMACS_INT, not int.
871 (Fformat_network_address, read_process_output, send_process)
872 (Fprocess_send_region, status_notify):
873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
874 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
875 (wait_reading_process_output, read_process_output, exec_sentinel):
876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
877 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
878 (Faccept_process_output): Use duration_to_sec_usec to do proper
879 overflow checking on durations.
880 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
881 Don't assume pid_t fits in int.
882 * process.h (struct Lisp_Process): Members tick and update_tick
883 are now of type EMACS_INT, not int.
884 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
885 configured --with-wide-int.
886 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
887 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
888 * search.c (looking_at_1, string_match_1):
889 (fast_string_match, fast_c_string_match_ignore_case)
890 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
891 (scan_newline, find_before_next_newline, search_command)
892 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
893 (set_search_regs, wordify):
896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
897 (string_match_1, search_buffer, set_search_regs):
899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
900 (wordify): Check for overflow in size calculation.
901 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
902 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
903 Check that fixnums are in proper range for system types.
904 * sound.c (struct sound_device)
905 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
907 (Fplay_sound_internal):
908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
909 * syntax.c (struct lisp_parse_state, find_start_modiff)
910 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
911 (Fparse_partial_sexp):
912 Don't assume fixnums can fit in int.
913 (struct lisp_parse_state, find_start_pos, find_start_value)
914 (find_start_value_byte, find_start_begv)
915 (update_syntax_table, char_quoted, dec_bytepos)
916 (find_defun_start, prev_char_comend_first, back_comment):
917 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
918 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (Finternal_describe_syntax_value): Check that match_lisp is a
921 character, not an integer, since the code stuffs it into int.
922 (scan_words, scan_sexps_forward):
923 Check that fixnums are in proper range for system types.
925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
926 (scan_sexps_forward):
927 Use CHARACTERP, not INTEGERP, since the value must fit into int.
928 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
929 * syntax.h: Adjust decls to match defn changes elsewhere.
931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
932 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
933 MOST_POSITIVE_FIXNUM.
934 * sysdep.c (wait_for_termination_1, wait_for_termination)
935 (interruptible_wait_for_termination, mkdir):
936 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
937 (emacs_read, emacs_write):
938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
939 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
940 and double all fit in int.
941 * term.c (set_tty_color_mode):
942 Check that fixnums are in proper range for system types.
943 * termhooks.h (struct input_event):
944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
945 * textprop.c (validate_interval_range, interval_of)
946 (Fadd_text_properties, set_text_properties_1)
947 (Fremove_text_properties, Fremove_list_of_text_properties)
948 (Ftext_property_any, Ftext_property_not_all)
949 (copy_text_properties, text_property_list, extend_property_ranges)
950 (verify_interval_modification):
951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
952 (Fnext_single_char_property_change)
953 (Fprevious_single_char_property_change):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 (copy_text_properties):
956 Check for integer overflow in index calculation.
957 * undo.c (last_boundary_position, record_point, record_insert)
958 (record_delete, record_marker_adjustment, record_change)
959 (record_property_change):
960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
961 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
963 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
964 (Fx_hide_tip, Fx_file_dialog):
965 * w32menu.c (set_frame_menubar):
966 Use ptrdiff_t, not int, for consistency with rest of code.
967 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
968 (select_window, Fdelete_other_windows_internal)
969 (window_scroll_pixel_based, window_scroll_line_based)
970 (Frecenter, Fset_window_configuration):
971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
972 (Fset_window_hscroll, run_window_configuration_change_hook)
973 (set_window_buffer, temp_output_buffer_show, scroll_command)
974 (Fscroll_other_window, Frecenter):
975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
976 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
977 Don't assume fixnum fits in int.
978 (Fset_window_scroll_bars):
979 Check that fixnums are in proper range for system types.
980 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
981 (string_pos, c_string_pos, number_of_chars, init_iterator)
982 (in_ellipses_for_invisible_text_p, init_from_display_pos)
983 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
984 (compute_display_string_end, handle_face_prop)
985 (face_before_or_after_it_pos, handle_invisible_prop)
986 (handle_display_prop, handle_display_spec, handle_single_display_spec)
987 (display_prop_intangible_p, string_buffer_position_lim)
988 (string_buffer_position, handle_composition_prop, load_overlay_strings)
989 (get_overlay_strings_1, get_overlay_strings)
990 (iterate_out_of_display_property, forward_to_next_line_start)
991 (back_to_previous_visible_line_start, reseat, reseat_to_string)
992 (get_next_display_element, set_iterator_to_next)
993 (get_visually_first_element, compute_stop_pos_backwards)
994 (handle_stop_backwards, next_element_from_buffer)
995 (move_it_in_display_line_to, move_it_in_display_line)
996 (move_it_to, move_it_vertically_backward, move_it_by_lines)
997 (add_to_log, message_dolog, message_log_check_duplicate)
998 (message2, message2_nolog, message3, message3_nolog
999 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1000 (current_message_1, truncate_echo_area, truncate_message_1)
1001 (set_message, set_message_1, store_mode_line_noprop)
1002 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1003 (text_outside_line_unchanged_p, check_point_in_composition)
1004 (reconsider_clip_changes)
1005 (redisplay_internal, set_cursor_from_row, try_scrolling)
1006 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1007 (redisplay_window, find_last_unchanged_at_beg_row)
1008 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1009 (trailing_whitespace_p, find_row_edges, display_line)
1010 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1011 (display_mode_element, store_mode_line_string)
1012 (pint2str, pint2hrstr, decode_mode_spec)
1013 (display_count_lines, display_string, draw_glyphs)
1014 (x_produce_glyphs, x_insert_glyphs)
1015 (rows_from_pos_range, mouse_face_from_buffer_pos)
1016 (fast_find_string_pos, mouse_face_from_string_pos)
1017 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1019 (safe_call, init_from_display_pos, handle_fontified_prop)
1020 (handle_single_display_spec, load_overlay_strings)
1021 (with_echo_area_buffer, setup_echo_area_for_printing)
1022 (display_echo_area, echo_area_display)
1023 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1024 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1025 (redisplay_window, dump_glyph_row, display_mode_line)
1026 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1027 (handle_display_spec, display_prop_string_p):
1028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1029 (handle_single_display_spec, build_desired_tool_bar_string)
1030 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1031 (get_specified_cursor_type):
1032 Check that fixnums are in proper range for system types.
1033 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1034 (Flookup_image_map):
1035 Don't assume fixnums fit in int.
1036 (compare_overlay_entries):
1037 Avoid mishandling comparisons due to subtraction overflow.
1038 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1039 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1040 (handle_tool_bar_click):
1041 Use int, not unsigned, since we prefer signed and the signedness
1042 doesn't matter here.
1043 (get_next_display_element, next_element_from_display_vector):
1044 Use int, not EMACS_INT, when int is wide enough.
1045 (start_hourglass): Use duration_to_sec_usec to do proper
1046 overflow checking on durations.
1047 * xfaces.c (Fbitmap_spec_p):
1048 Check that fixnums are in proper range for system types.
1049 (compare_fonts_by_sort_order):
1050 Avoid mishandling comparisons due to subtraction overflow.
1051 (Fx_family_fonts, realize_basic_faces):
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1054 Don't assume fixnum fits in int.
1055 Use SAFE_ALLOCA_LISP, not alloca.
1056 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1057 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1058 (face_at_buffer_position, face_for_overlay_string)
1059 (face_at_string_position):
1060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1061 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1062 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1064 Check that fixnums are in proper range for system types.
1065 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1066 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1068 (Fx_change_window_property): Don't assume fixnums fit in int.
1069 * xfont.c (xfont_chars_supported):
1070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1071 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1072 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1074 * xml.c (parse_region):
1075 * xrdb.c (magic_file_p):
1076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1077 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1078 (x_get_local_selection, x_reply_selection_request)
1079 (x_handle_selection_request, wait_for_property_change):
1080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1081 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1082 short is wide enough.
1083 (x_send_client_event): Don't assume fixnum fits in int.
1084 * xterm.c (x_x_to_emacs_modifiers):
1085 Don't assume EMACS_INT overflows nicely into int.
1086 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1088 (handle_one_xevent): NATNUMP can eval its arg twice.
1089 (x_connection_closed):
1090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1091 * xterm.h: Adjust decls to match defn changes elsewhere.
1092 (struct scroll_bar): Use struct vectorlike_header
1093 rather than rolling our own approximation.
1094 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1096 2012-05-25 Glenn Morris <rgm@gnu.org>
1098 * lisp.mk (lisp): Update for more files being compiled now.
1100 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1102 * lread.c: Remove `read_pure' which makes no difference.
1103 (read_pure): Remove var.
1104 (unreadpure): Remove function.
1105 (readevalloop): Don't call read_list with -1 flag.
1106 (read1, read_vector): Don't test read_pure any more.
1107 (read_list): Simplify.
1109 * fileio.c, character.h: Minor style tweaks.
1111 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1113 * window.h (clip_changed): Remove useless declaration.
1115 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1117 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1118 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1120 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1123 This directory predates autoconf and is no longer needed nowadays.
1124 Move its few remaining bits of functionality to where they're needed.
1125 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1126 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1127 * m/template.h: Remove.
1128 * Makefile.in (M_FILE): Remove. All uses removed.
1129 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1130 * lisp.h (USE_LSB_TAG):
1131 * mem-limits.h (EXCEEDS_LISP_PTR):
1132 Use VAL_MAX, not VALBITS, in #if.
1133 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1134 (EMACS_UINT): Define unconditionally now.
1135 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1136 (BITS_PER_EMACS_INT): New constants, replacing
1137 what used to be in config.h, but not useful in #if.
1138 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1139 define them any more.
1140 (VAL_MAX): New macro.
1142 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1143 BITS_PER_EMACS_INT, in #if.
1144 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1145 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1146 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1147 * s/ms-w32.h (DATA_START):
1148 Move here from removed file m/intel386.h.
1149 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1150 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1152 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1154 Assume C89 or later.
1155 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1156 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1158 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1159 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1160 * textprop.c, tparam.c (NULL): Remove.
1161 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1162 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1163 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1164 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1165 * xterm.c (input_signal_count): Assume volatile works.
1167 2012-05-21 Ken Brown <kbrown@cornell.edu>
1169 * xgselect.c (xg_select): Fix first argument in call to 'select'
1172 2012-05-20 Ken Brown <kbrown@cornell.edu>
1174 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1175 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1177 2012-05-19 Ken Brown <kbrown@cornell.edu>
1179 * xfns.c (x_in_use): Remove `static' qualifier.
1180 * xterm.h (x_in_use): Declare.
1181 * xgselect.c: Include xterm.h.
1182 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1183 and `display_arg' (bug#9754).
1185 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1187 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1189 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1190 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1192 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1194 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1196 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1197 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1199 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1200 reference to image_cache->refcount.
1201 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1203 2012-05-17 Juri Linkov <juri@jurta.org>
1205 * search.c (Fword_search_regexp, Fword_search_backward)
1206 (Fword_search_forward, Fword_search_backward_lax)
1207 (Fword_search_forward_lax): Move functions to isearch.el
1208 (bug#10145, bug#11381).
1210 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1212 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1214 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1216 * lread.c (init_obarray): Declare Qt and Qnil as special.
1218 2012-05-14 Glenn Morris <rgm@gnu.org>
1220 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1221 Put "libexec" before "bin", for the sake of init_callproc_1.
1223 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1225 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1227 * unexaix.c: Port to more-recent AIX compilers.
1228 (report_error, report_error_1, make_hdr, copy_sym)
1229 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1230 Make arguments const char *, not char *, to avoid violations of C
1231 standard and to fix some AIX warnings reported by Gilles Pion.
1233 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1235 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1236 already have overlays loaded.
1237 (handle_single_display_spec): Before returning without displaying
1238 fringe bitmap, synchronize the bidi iterator with the main display
1239 iterator, by calling iterate_out_of_display_property.
1240 (iterate_out_of_display_property): Detect buffer iteration by
1241 testing that it->string is a Lisp string.
1242 (get_next_display_element): When the current object is exhausted,
1243 and there's something on it->stack, call set_iterator_to_next to
1244 proceed with what's on the stack, instead of returning zero.
1245 (set_iterator_to_next): If called at the end of a Lisp string,
1246 proceed to consider_string_end without incrementing string
1247 position. Don't increment display vector index past the end of
1248 the display vector. (Bug#11417)
1249 (pos_visible_p): Don't report a position visible when move_it_to
1250 stopped at the last line of window, which happens to be scanned
1251 backwards by the bidi iteration. (Bug#11464)
1253 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1255 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1256 and right-margin display specs even if the spec is invalid or we
1257 are on a TTY, and thus unable to display on the fringes.
1258 That's because the text with the property will not be displayed anyway,
1259 so we need to signal to the caller that this is a "replacing"
1260 display spec. This fixes display when the spec is invalid or we
1263 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1265 * unexaix.c (make_hdr): Fix typo in prototype.
1266 This bug broke the build on AIX. Problem reported by Gilles Pion.
1268 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1270 * keyboard.c (kbd_buffer_get_event): Read special events also in
1271 batch mode. (Bug#11415)
1273 2012-05-12 Glenn Morris <rgm@gnu.org>
1275 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1277 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1279 * lisp.mk (lisp): Add newcomment.elc.
1281 2012-05-12 Glenn Morris <rgm@gnu.org>
1283 * Makefile.in (MKDIR_P): New, set by configure.
1284 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1286 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1288 Remove unused function hourglass_started.
1289 * dispextern.h (hourglass_started):
1290 * w32fns.c (hourglass_started):
1291 * xdisp.c (hourglass_started): Remove.
1293 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1295 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1296 Update dependencies.
1298 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1300 * xgselect.c (xg_select): Put maxfds+1 into a var.
1301 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1303 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1305 2012-05-10 Dave Abrahams <dave@boostpro.com>
1307 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1308 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1310 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1312 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1313 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1314 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1315 Initialize xd_registered_buses.
1317 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1319 Untag more efficiently if USE_LSB_TAG.
1320 This is based on a proposal by YAMAMOTO Mitsuharu in
1321 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1322 For an admittedly artificial (nth 8000 longlist) benchmark on
1323 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1324 Emacs's overall text size by 1%.
1325 * lisp.h (XUNTAG): New macro.
1326 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1327 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1328 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1329 * eval.c (Fautoload):
1330 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1331 * frame.h (XFRAME): Use XUNTAG.
1333 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1334 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1335 Remove unportable assumptions about print widths of types like
1337 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1338 intptr_t when converting between pointer and integer, to avoid GCC
1339 warnings about wrong width.
1341 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1343 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1344 stack for each reader_thread, instead of defaulting to 8MB
1345 determined by the linker. This avoids failures in creating
1346 subprocesses on Windows 7, see the discussion in this thread:
1347 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1349 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1351 Fix up display of the *Minibuf-0* buffer in the mini window.
1352 * keyboard.c (read_char): Don't clear the echo area if there's no
1354 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1355 contents of *Minibuf-0*) if there's no message displayed in its stead.
1357 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1359 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1362 2012-05-06 Chong Yidong <cyd@gnu.org>
1364 * lisp.mk (lisp): Update.
1366 2012-05-05 Jim Meyering <meyering@redhat.com>
1368 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1370 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1372 * data.c (PUT_ERROR): New macro.
1373 (syms_of_data): Use it. Add new error type `user-error'.
1374 * undo.c (user_error): New function.
1375 (Fprimitive_undo): Use it.
1376 * print.c (print_error_message): Adjust print style for `user-error'.
1377 * keyboard.c (user_error): New function.
1378 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1380 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1382 Do not limit current-time-string to years 1000..9999.
1383 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1384 (Fcurrent_time_string): Support any year that is supported by the
1385 underlying localtime representation. Don't use asctime, as it
1386 has undefined behavior for years outside the range -999..9999.
1388 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1390 Fix race conditions involving setenv, gmtime, localtime, asctime.
1391 Without this fix, interrupts could mess up code that uses these
1392 nonreentrant functions, since setting TZ invalidates existing
1393 tm_zone or tzname values, and since most of these functions return
1394 pointers to static storage.
1395 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1396 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1397 Grow the critical sections to include not just invoking
1398 localtime/gmtime, but also accessing these functions' results
1399 including their tm_zone values if any, and any related TZ setting.
1400 (format_time_string): Last arg is now struct tm *, not struct tm **,
1401 so that the struct tm is saved in the critical section.
1402 All callers changed. Simplify allocation of initial buffer, partly
1403 motivated by the fact that memory allocation needs to be outside
1404 the critical section.
1406 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1408 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1409 with RESET_INTERVAL.
1411 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1412 Remove duplicated buffer name initialization.
1414 2012-05-02 Jim Meyering <jim@meyering.net>
1416 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1418 * xfns.c (x_window): Use xstrdup (Bug#11375).
1420 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1422 * xdisp.c (pos_visible_p): If already at a newline from the
1423 display string before the 'while' loop, don't walk back the glyphs
1424 from it3.glyph_row. Solves assertion violation when the display
1425 string begins with a newline (egg.el). (Bug#11367)
1427 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1429 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1432 2012-05-01 Glenn Morris <rgm@gnu.org>
1434 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1435 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1436 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1437 All were removed before 23.1.
1439 * dispnew.c: Remove HAVE_LIBNCURSES test;
1440 it is always true on relevant platforms.
1442 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1443 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1445 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1447 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1449 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1450 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1453 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1455 Do not avoid creating empty evaporating overlays (Bug#9642).
1456 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1457 That is, do not delete an evaporating overlay if it becomes
1458 empty after its bounds are adjusted to fit within its buffer.
1459 This fix caused other problems, and I'm reverting it until we get
1460 to the bottom of them.
1462 2012-04-27 Chong Yidong <cyd@gnu.org>
1464 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1466 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1468 * xdisp.c (pos_visible_p): If the window start position is beyond
1469 ZV, start the display from buffer beginning. Prevents assertion
1470 violation in init_iterator when the minibuffer window is scrolled
1473 * window.c (window_scroll_pixel_based): Likewise.
1475 2012-04-27 Chong Yidong <cyd@gnu.org>
1477 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1479 2012-04-27 Glenn Morris <rgm@gnu.org>
1481 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1482 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1484 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1486 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1487 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1489 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1491 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1492 display element, check also the underlying string or buffer
1493 character. (Bug#11341)
1495 * w32menu.c: Include w32heap.h.
1496 (add_menu_item): If the call to AppendMenuW (via
1497 unicode_append_menu) fails, disable Unicode menus only if we are
1498 running on Windows 9X/Me.
1500 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1502 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1503 (xgetint): Add missing shift for LSB tags.
1505 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1507 * keyboard.c (read_char): Don't wipe echo area for select window
1508 events: These might get delayed via `mouse-autoselect-window'
1511 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1513 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1514 manipulation of :loaded-from data.
1516 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1518 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1519 now a cons (bug#11311).
1521 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1523 Do not create empty overlays with the evaporate property (Bug#9642).
1524 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1525 if it becomes empty after its bounds are adjusted to fit within
1526 its buffer. Without this fix, in a nonempty buffer (let ((o
1527 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1528 yields an empty overlay that has the evaporate property, which is
1529 not supposed to happen.
1531 Fix minor GTK3 problems found by static checking.
1532 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1533 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1534 (struct _EmacsFixedClass, emacs_fixed_get_type):
1535 Move decls here from emacsgtkfixed.h, since they needn't be public.
1536 (emacs_fixed_get_type): Now static.
1537 (emacs_fixed_class_init): Omit unused local.
1538 (emacs_fixed_child_type): Remove; unused.
1539 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1540 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1541 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1542 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1543 (EMACS_FIXED_GET_CLASS): Remove; unused.
1544 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1546 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1547 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1549 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1551 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1552 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1553 (__malloc_size_t, __malloc_ptrdiff_t):
1554 Remove. All uses removed, replaced by the definiens if needed,
1555 since we can assume C89 or better now.
1556 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1557 (protect_malloc_state, align, get_contiguous_space)
1558 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1559 (malloc_atfork_handler_child, malloc_enable_thread)
1560 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1561 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1562 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1563 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1564 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1565 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1566 Define using prototypes, not old style.
1567 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1568 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1569 (align): Don't assume that signed integer overflow wraps around.
1570 Omit unused local var.
1571 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1572 (_free_internal_nolock, memalign, mallochook, reallochook):
1573 Omit no-longer-needed casts.
1574 (valloc): Use getpagesize, not __getpagesize.
1575 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1576 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1578 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1580 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1582 Move functions from C to Lisp. Make non-blocking method calls
1583 the default. Implement further D-Bus standard interfaces.
1585 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1586 (QCdbus_request_name_allow_replacement)
1587 (QCdbus_request_name_replace_existing)
1588 (QCdbus_request_name_do_not_queue)
1589 (QCdbus_request_name_reply_primary_owner)
1590 (QCdbus_request_name_reply_in_queue)
1591 (QCdbus_request_name_reply_exists)
1592 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1593 (QCdbus_registered_serial, QCdbus_registered_method)
1594 (QCdbus_registered_signal): New Lisp objects.
1595 (XD_DEBUG_MESSAGE): Use sizeof.
1596 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1597 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1598 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1599 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1600 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1601 (xd_signature, xd_append_arg): Allow float for integer types.
1602 (xd_get_connection_references): New function.
1603 (xd_get_connection_address): Rename from xd_initialize.
1604 Return cached address.
1605 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1606 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1608 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1609 Return number of refcounts.
1610 (Fdbus_get_unique_name): Make stronger parameter check.
1611 (Fdbus_message_internal): New defun.
1612 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1613 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1614 (Fdbus_send_signal, Fdbus_register_service)
1615 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1616 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1617 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1618 (Vdbus_compiled_version, Vdbus_runtime_version)
1619 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1620 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1621 (Vdbus_message_type_signal): New defvars.
1622 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1625 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1627 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1628 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1629 Do not assume ptrdiff_t is the same width as 'int'.
1631 * alloc.c: Handle unusual debugging option combinations.
1632 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1633 since the two debugging options are incompatible.
1634 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1636 (mem_init, mem_insert, mem_insert_fixup):
1637 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1638 (NEED_MEM_INSERT): Remove; no longer needed.
1640 2012-04-22 Leo Liu <sdl.web@gmail.com>
1642 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1644 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1646 * sysdep.c [__FreeBSD__]: Minor cleanups.
1647 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1648 Use Emacs indenting style more consistently. Avoid some casts.
1649 Use 'double' consistently rather than mixing 'float' and 'double'.
1651 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1653 * sysdep.c (list_system_processes, system_process_attributes):
1654 Add implementation for FreeBSD (Bug#5243).
1656 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1658 * lisp.mk (lisp): Update.
1660 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1662 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1663 It is never used otherwise.
1665 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1667 * print.c (print_preprocess): Only check print_depth if print-circle
1669 (print_object): Check for cycles even when print-circle is nil and
1670 print-gensym is t, but only check print_depth if print-circle is nil.
1672 2012-04-20 Chong Yidong <cyd@gnu.org>
1674 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1675 set the status to "failed" and ensure that sentinel is run.
1677 2012-04-20 Glenn Morris <rgm@gnu.org>
1679 * process.c (Fset_process_inherit_coding_system_flag)
1680 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1681 (Fmake_network_process, Fmake_serial_process): Doc fix.
1683 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1685 * xdisp.c (string_buffer_position_lim): Limit starting position to
1687 (set_cursor_from_row): If called for a mode-line or header-line
1688 row, return zero immediately.
1689 (try_cursor_movement): If inside continuation line, don't back up
1690 farther than the first row after the header line, if any.
1691 Don't consider the header-line row as "partially visible", even if
1692 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1694 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1696 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1699 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1700 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1702 configure: new option --enable-gcc-warnings (Bug#11207)
1703 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1704 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1705 (ALL_CFLAGS): Use new macros rather than old.
1706 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1707 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1708 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1709 -Wunused-result, -Wunused-variable. This should go away once
1710 the Emacs and Gnulib regex code is merged.
1711 (xmalloc, xrealloc): Now static.
1713 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1715 * dired.c (Fsystem_groups): Remove unused local.
1717 2012-04-17 Glenn Morris <rgm@gnu.org>
1719 * dired.c (Fsystem_users): Doc fix.
1721 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1723 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1724 (syms_of_dired): Add them.
1726 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1728 Fix minor alloc.c problems found by static checking.
1729 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1730 New extern decls, to avoid calling undeclared functions.
1731 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1732 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1733 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1734 (NEED_MEM_INSERT): New macro.
1735 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1736 Remove one incorrect comment and fix another.
1738 Fix minor ralloc.c problems found by static checking.
1739 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1740 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1741 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1742 (r_alloc_sbrk): Now static.
1744 Improve ralloc.c interface checking.
1745 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1746 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1747 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1748 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1749 [REL_ALLOC]: ... to here, to check interface.
1750 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1751 Remove decls. This fixes an "It stinks!".
1753 * alloc.c (which_symbols): Fix alignment issue / type clash.
1755 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1757 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1758 (struct Lisp_Misc_Any): Likewise.
1759 (struct Lisp_Free): Likewise.
1760 * alloc.c (union aligned_Lisp_Symbol): Define.
1761 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1762 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1763 (union aligned_Lisp_Misc): Define.
1764 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1765 aligned_Lisp_Misc instead of union Lisp_Misc.
1766 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1768 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1770 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1771 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1772 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1773 * s/netbsd.h, s/sol2-6.h:
1774 Remove definition of GC_MARK_STACK, since the default now works.
1775 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1776 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1777 no longer the default.
1778 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1780 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1782 * lread.c (lisp_file_lexically_bound_p):
1783 Fix hang at ";-*-\n" (bug#11238).
1785 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1787 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1788 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1790 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1792 * nsterm.m (constrainFrameRect): Always constrain when there is only
1793 one screen (Bug#10962).
1795 2012-04-13 Ken Brown <kbrown@cornell.edu>
1797 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1799 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1801 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1803 2012-04-11 Daniel Colascione <dancol@dancol.org>
1805 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1806 against is gone. It's better to use vfork now so that when Cygwin
1807 gains a new, working vfork, we use it automatically (bug#10398).
1809 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1811 * window.c (save_window_save): Obey window-point-insertion-type.
1813 2012-04-11 Glenn Morris <rgm@gnu.org>
1815 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1817 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1819 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1821 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1823 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1824 (force_quit_count): New var.
1825 (handle_interrupt): Use it.
1827 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1829 * w32.c (w32_delayed_load): Record the full path of the library
1830 being loaded (bug#10424).
1832 2012-04-09 Glenn Morris <rgm@gnu.org>
1834 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1835 not just in the obarray, before snarfing them. (Bug#11036)
1837 * Makefile.in ($(leimdir)/leim-list.el):
1838 Pass EMACS rather than BUILT_EMACS.
1840 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1842 * process.c (make_process):
1843 * process.h: Add integer `gnutls_handshakes_tried' member to
1846 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1847 Add convenience `GNUTLS_LOG2i' macro.
1849 * gnutls.c (gnutls_log_function2i): Convenience log function.
1850 (emacs_gnutls_read): Use new log functions,
1851 `gnutls_handshakes_tried' process member, and
1852 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1853 attempts per process (connection).
1855 2012-04-09 Chong Yidong <cyd@gnu.org>
1857 * eval.c (Fuser_variable_p, user_variable_p_eh)
1858 (lisp_indirect_variable): Functions deleted.
1859 (Fdefvar): Caller changed.
1861 * callint.c (Finteractive, Fcall_interactively):
1862 * minibuf.c (Fread_variable): Callers changed.
1864 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1866 * xdisp.c (set_cursor_from_row): If the display string appears in
1867 the buffer at position that is closer to point than the position
1868 after the display string, display the cursor on the first glyph of
1869 the display string. Fixes cursor display when a 'display' text
1870 property immediately follows invisible text. (Bug#11094)
1872 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1874 composite.c: use 'double' consistently
1875 * composite.c (get_composition_id): Use 'double' consistently
1876 instead of converting 'float' to 'double' and vice versa; this is
1877 easier to understand and avoids a GCC warning.
1879 2012-04-09 Glenn Morris <rgm@gnu.org>
1881 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1882 preparation for dumping it with emacs. (Bug#4789)
1883 (leimdir): New variable.
1884 ($(leimdir)/leim-list.el): New rule.
1885 (emacs$(EXEEXT)): Depend on leim-list.el.
1887 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1888 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1889 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1891 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1893 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1896 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1898 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1899 Remove unused local variable.
1901 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1903 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1904 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1905 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1906 objects, as mark_maybe_pointer will catch them otherwise.
1907 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1908 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1910 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1912 Fix typo that broke non-Windows builds.
1913 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1915 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1917 Support building on MS-Windows with libxml2.
1919 * makefile.w32-in (OBJ2): Add xml.$(O).
1920 (GLOBAL_SOURCES): Add xml.c.
1921 ($(BLD)/xml.$(O)): New dependency list.
1923 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1924 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1925 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1926 [!WINDOWSNT]: New macros.
1927 (init_libxml2_functions, libxml2_loaded_p): New functions.
1928 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1929 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1930 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1931 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1933 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1934 Call init_libxml2_functions before calling libxml2 functions.
1935 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1937 * emacs.c: Don't include libxml/parser.h.
1938 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1939 xmlCleanupParser directly.
1941 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1943 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1945 * indent.c (Fvertical_motion): If there is a display string at
1946 point, use it.vpos to compute how many lines to backtrack after
1947 move_it_to point. (Bug#11133)
1949 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1951 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1952 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1953 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1954 macros related to unification of CJK characters. For the details,
1955 see the discussion following the message here:
1956 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1958 2012-04-04 Chong Yidong <cyd@gnu.org>
1960 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1962 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1964 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1965 instead of alloca. (Bug#11138)
1967 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1969 * w32menu.c (is_simple_dialog): Properly check lisp types.
1972 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1974 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1975 position we get to after a call to move_it_to fails the
1976 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1977 only if we wind up in a string from display property. (Bug#11063)
1979 * window.c (Fdelete_other_windows_internal): Invalidate the row
1980 and column information about mouse highlight, so that redisplay
1981 restores it after reallocating the glyph matrices. (Bug#7464)
1983 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1984 string comes from a `display' text property, use the buffer
1985 position of that property as if we actually saw that position in
1987 (move_it_by_lines): Remove the assertion that
1988 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1989 violated when there's a before-string at the beginning of a line.
1992 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1994 * xdisp.c (append_space_for_newline): If the default face was
1995 remapped, use the remapped face for the appended newline.
1996 (extend_face_to_end_of_line): Use the remapped default face for
1997 extending the face to the end of the line.
1998 (display_line): Call extend_face_to_end_of_line when the default
1999 face was remapped. (Bug#11068)
2001 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2003 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2005 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2007 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2009 2012-03-27 Glenn Morris <rgm@gnu.org>
2011 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2014 2012-03-26 Kenichi Handa <handa@m17n.org>
2016 * dispextern.h (struct glyph): Fix previous change. Change the
2017 bit length of glyphless.ch to 25 (Bug#11082).
2019 2012-03-26 Chong Yidong <cyd@gnu.org>
2021 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2022 (command_loop_1): Use it; inhibit selection update for
2023 handle-select-window too (Bug#8996).
2025 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2027 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2029 2012-03-25 Kenichi Handa <handa@m17n.org>
2031 * dispextern.h (struct glyph): Change the bit length of
2032 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2034 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2036 * s/ms-w32.h (tzname): Include time.h before redirecting to
2037 _tzname. Fixes the MSVC build. (Bug#9960)
2039 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2041 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2044 * xterm.c (XTread_socket): Only modify handling_signal if
2045 !SYNC_INPUT. (Bug#11080)
2047 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2049 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2050 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2051 when fetching a multibyte character consumes more bytes than
2052 CHAR_BYTES returns, due to unification of CJK characters in
2053 string_char. (Bug#11073)
2055 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2057 * process.c (wait_reading_process_output): Handle pty disconnect
2058 by refraining from sending oneself a SIGCHLD (bug#10933).
2060 2012-03-22 Chong Yidong <cyd@gnu.org>
2062 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2064 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2065 Mark string as coming from a prefix property.
2066 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2067 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2069 2012-03-21 Chong Yidong <cyd@gnu.org>
2071 * xfaces.c (Vface_remapping_alist): Doc fix.
2073 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2075 * w32proc.c (Fw32_set_console_codepage)
2076 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2079 2012-03-20 Chong Yidong <cyd@gnu.org>
2081 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2082 to reflect default non-nil value of redisplay-dont-pause.
2084 2012-03-19 Kenichi Handa <handa@m17n.org>
2086 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2087 it fit in a valid range (Bug#11003).
2089 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2091 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2092 that is not from display property, accept the row as a "cursor
2093 row" if one of the string's character has a non-nil `cursor'
2094 property. Fixes cursor positioning when there are newlines in
2095 overlay strings, e.g. in icomplete.el. (Bug#11035)
2097 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2099 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2101 2012-03-12 Chong Yidong <cyd@gnu.org>
2103 * eval.c (inhibit_lisp_code): Rename from
2104 inhibit_window_configuration_change_hook; move from window.c.
2106 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2107 * window.c (run_window_configuration_change_hook)
2108 (syms_of_window): Callers changed.
2110 2012-03-11 Chong Yidong <cyd@gnu.org>
2112 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2114 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2116 2012-03-10 Chong Yidong <cyd@gnu.org>
2118 * frame.c (other_visible_frames): Don't assume the selected frame
2119 is visible (Bug#10955).
2121 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2123 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2125 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2127 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2128 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2131 2012-03-03 Glenn Morris <rgm@gnu.org>
2133 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2135 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2137 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2138 position past the first glyph_row that ends at ZV. (Bug#10902)
2139 (redisplay_window, next_element_from_string): Fix typos in
2141 (redisplay_window): Pass to move_it_vertically the margin in
2142 pixels, not in screen lines.
2144 2012-03-02 Glenn Morris <rgm@gnu.org>
2146 * buffer.c (buffer-list-update-hook): Doc fix.
2148 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2150 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2151 push_it before setting up the iterator for the first overlay
2152 string, even if we have an empty string loaded.
2153 (next_overlay_string): If there's an empty string on the iterator
2154 stack, pop the stack. (Bug#10903)
2156 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2158 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2159 Suggested by Stefan Monnier in
2160 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2161 * alloc.c (widen_to_Lisp_Object): New static function.
2162 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2163 and widening them to Lisp_Objects. This would work even if
2164 USE_LSB_TAG is defined and wide integers are used, which might
2165 happen in a future version of Emacs.
2167 2012-02-25 Chong Yidong <cyd@gnu.org>
2169 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2172 * xselect.c (Fx_selection_exists_p): Doc fix.
2173 (x_clipboard_manager_save_all): Print an informative message
2174 before saving to clipboard manager.
2176 2012-02-24 Chong Yidong <cyd@gnu.org>
2178 * keyboard.c (process_special_events): Handle all X selection
2179 requests in kbd_buffer, not just the next one (Bug#8869).
2181 2012-02-23 Chong Yidong <cyd@gnu.org>
2183 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2184 call when setting menu-bar-lines and tool-bar-lines parameters.
2185 (unwind_create_frame_1): New helper function.
2187 * window.c (inhibit_window_configuration_change_hook): New var.
2188 (run_window_configuration_change_hook): Obey it.
2189 (syms_of_window): Initialize it.
2191 2012-02-22 Chong Yidong <cyd@gnu.org>
2193 * xterm.c (x_draw_image_relief): Add missing type check for
2194 Vtool_bar_button_margin (Bug#10743).
2196 2012-02-21 Chong Yidong <cyd@gnu.org>
2198 * fileio.c (Vfile_name_handler_alist): Doc fix.
2200 * buffer.c (Fget_file_buffer): Protect against invalid file
2201 handler return value.
2203 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2205 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2206 when computing $valmask.
2208 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2209 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2210 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2211 It's useless in that case, and it can cause problems on hosts
2212 that allocate halves of EMACS_INT values separately.
2213 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2214 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2215 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2216 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2217 it avoids undefined behavior on hosts where shifting right by more
2218 than the word width has undefined behavior.
2220 2012-02-19 Chong Yidong <cyd@gnu.org>
2222 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2223 (Funhandled_file_name_directory, Ffile_name_as_directory)
2224 (Fdirectory_file_name, Fexpand_file_name)
2225 (Fsubstitute_in_file_name): Protect against invalid file handler
2226 return values (Bug#10845).
2228 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2230 * .gdbinit (pitx): Fix incorrect references to fields of the
2233 2012-02-17 Chong Yidong <cyd@gnu.org>
2235 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2237 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2239 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2240 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2242 2012-02-15 Chong Yidong <cyd@gnu.org>
2244 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2245 marked as special. Also, starting docstrings with * is obsolete.
2247 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2249 * gnutls.c (emacs_gnutls_write): Fix last change.
2251 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2253 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2256 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2258 * keymap.c (Fsingle_key_description): Handle char ranges.
2260 2012-02-12 Chong Yidong <cyd@gnu.org>
2262 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2263 as that creates a dangerous corner case.
2265 * window.c (Fdelete_window_internal): Invalidate the mouse
2266 highlight (Bug#9904).
2268 2012-02-12 Glenn Morris <rgm@gnu.org>
2270 * xselect.c (Fx_own_selection_internal)
2271 (Fx_get_selection_internal, Fx_disown_selection_internal)
2272 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2273 * nsselect.m (Fx_own_selection_internal)
2274 (Fx_disown_selection_internal, Fx_selection_exists_p)
2275 (Fx_selection_owner_p, Fx_get_selection_internal):
2276 Sync docs and argument specs with the xselect.c versions.
2278 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2280 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2282 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2284 * w32select.c (Fx_selection_exists_p): Sync doc string and
2285 argument list with xselect.c. (Bug#10783)
2287 * w16select.c (Fx_selection_exists_p): Sync doc string and
2288 argument list with xselect.c. (Bug#10783)
2290 2012-02-10 Glenn Morris <rgm@gnu.org>
2292 * fns.c (Fsecure_hash): Doc fix.
2294 2012-02-09 Kenichi Handa <handa@m17n.org>
2296 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2298 2012-02-07 Chong Yidong <cyd@gnu.org>
2300 * buffer.c (Fbuffer_local_variables)
2301 (buffer_lisp_local_variables): Handle unbound vars correctly;
2302 don't let Qunbound leak into Lisp.
2304 2012-02-07 Glenn Morris <rgm@gnu.org>
2306 * image.c (Fimagemagick_types): Doc fix.
2308 * image.c (imagemagick-render-type): Change it from a lisp object
2309 to an integer. Move the doc here from the lisp manual.
2310 Treat all values not equal to 0 the same.
2312 2012-02-06 Chong Yidong <cyd@gnu.org>
2314 * doc.c (store_function_docstring): Avoid applying docstring of
2315 alias to base function (Bug#2603).
2317 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2319 * .gdbinit (pp1, pv1): Remove redundant defines.
2322 2012-02-04 Chong Yidong <cyd@gnu.org>
2324 * nsterm.m: Declare a global (Bug#10694).
2326 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2328 * w32.c (get_emacs_configuration_options):
2329 Include --enable-checking, if specified, in the return value.
2331 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2333 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2334 after rounding frame sizes. (Bug#9723)
2336 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2338 * keyboard.c (adjust_point_for_property): Don't position point
2339 before BEGV. (Bug#10696)
2341 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2343 Handle overflow when computing char display width (Bug#9496).
2344 * character.c (char_width): Return EMACS_INT, not int.
2345 (char_width, c_string_width): Check for overflow when
2346 computing the width; this is possible now that individual
2347 characters can have unbounded width. Problem introduced
2348 by merge from Emacs 23 on 2012-01-19.
2350 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2352 * dbusbind.c (Fdbus_register_method): Mention the return value
2353 :ignore in the docstring.
2355 2012-02-02 Glenn Morris <rgm@gnu.org>
2357 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2359 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2360 Unconditionally set to t. (Bug#10673)
2361 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2362 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2363 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2365 2012-02-02 Kenichi Handa <handa@m17n.org>
2367 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2368 0, do not call append_composite_glyph.
2370 2012-02-02 Kenichi Handa <handa@m17n.org>
2372 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2374 (x_produce_glyphs): If the component of a composition is a null
2375 string, set it->pixel_width to 1 to avoid zero-width glyph.
2377 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2379 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2380 first 2 arguments are identical. This makes inserting large
2381 output from a subprocess an order of magnitude faster on
2382 MS-Windows, where all sbrk'ed memory is always contiguous.
2384 2012-01-31 Glenn Morris <rgm@gnu.org>
2386 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2387 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2388 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2390 2012-01-29 Glenn Morris <rgm@gnu.org>
2392 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2394 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2396 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2398 2012-01-28 Chong Yidong <cyd@gnu.org>
2400 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2402 2012-01-26 Chong Yidong <cyd@gnu.org>
2404 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2406 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2407 repeat counts (Bug#10507).
2409 2012-01-26 Glenn Morris <rgm@gnu.org>
2411 * lread.c (syms_of_lread): Doc fix.
2413 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2415 * coding.c (encode_designation_at_bol): Change return value to
2418 2012-01-25 Chong Yidong <cyd@gnu.org>
2420 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2422 2012-01-21 Chong Yidong <cyd@gnu.org>
2424 * floatfns.c (Fcopysign): Make the second argument non-optional,
2425 since nil is not allowed anyway.
2427 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2429 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2430 (send_process): Likewise.
2432 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2434 * window.c (save_window_save, Fcurrent_window_configuration)
2435 (Vwindow_persistent_parameters): Do not use Qstate.
2436 Rewrite doc-strings.
2438 2012-01-19 Kenichi Handa <handa@m17n.org>
2440 * character.c (char_width): New function.
2441 (Fchar_width, c_string_width, lisp_string_width):
2442 Use char_width (Bug#9496).
2444 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2446 * window.c (Vwindow_persistent_parameters): New variable.
2447 (Fset_window_configuration, save_window_save): Handle persistent
2450 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2452 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2453 thrashing the stack of the thread. (Bug#9087)
2455 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2457 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2459 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2461 * xdisp.c (rows_from_pos_range): Handle the case where the
2462 highlight ends on a newline. (Bug#10464)
2463 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2464 he end column for display of highlight that ends on a newline
2467 2012-01-11 Glenn Morris <rgm@gnu.org>
2469 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2470 from load-path also when installation-directory is nil. (Bug#10208)
2472 2012-01-10 Glenn Morris <rgm@gnu.org>
2474 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2476 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2477 Update template values to be closer to their typical values these days.
2479 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2481 * xdisp.c (rows_from_pos_range): Accept additional argument
2482 DISP_STRING, and accept any glyph in a row whose object is that
2483 string as eligible for mouse highlight. Fixes mouse highlight of
2484 display strings from overlays. (Bug#10464)
2486 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2488 emacs: fix an auto-save permissions race condition (Bug#10400)
2489 * fileio.c (auto_saving_dir_umask): New static var.
2490 (Fmake_directory_internal): Use it.
2491 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2492 creating the directory. The old code temporarily assigns
2493 too-generous permissions to the directory.
2494 (do_auto_save_eh): Clear it.
2495 (Fdo_auto_save): Catch all errors, not just file errors, so
2496 that the var is always cleared.
2498 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2500 * search.c (scan_buffer): Pass character positions to
2501 know_region_cache, not byte positions. (Bug#6540)
2503 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2505 * w32.c (sys_rename): Report EXDEV when rename of a directory
2506 fails because the target is on another logical disk. (Bug#10284)
2508 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2510 * xterm.c (x_embed_request_focus): New function.
2512 * xterm.h: Add prototype.
2514 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2516 2012-01-05 Glenn Morris <rgm@gnu.org>
2518 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2520 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2522 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2523 Load gnutls_transport_set_lowat only if GnuTLS version is below
2525 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2526 GnuTLS versions below 2.11.1.
2528 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2530 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2531 to the doc string advising against its use for altering the way
2532 windows are scrolled.
2534 2011-12-28 Kenichi Handa <handa@m17n.org>
2536 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2537 coding-system ASCII compatible only when it does not produce BOM
2538 on encoding (Bug#10383).
2540 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2542 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2544 (create_and_show_popup_menu): Always use menu_position_func for
2547 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2549 * callint.c (Fcall_interactively): Don't truncate prompt string.
2551 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2553 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2554 property that ends at ZV, so that the bidi iteration could be
2555 resumed from there (after widening). (Bug#10360)
2557 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2559 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2561 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2563 * nsterm.m (x_free_frame_resources):
2564 Release f->output_data.ns->miniimage.
2565 (ns_index_color): Fix indentation. Do not retain
2566 color_table->colors[i].
2568 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2571 * nsfns.m (x_set_background_color): Assign return value from
2572 ns_index_color to face-background instead of NSColor*.
2573 (ns_implicitly_set_icon_type): Fix indentation.
2574 Change assignment in for loop to comparison.
2576 * emacs.c (ns_pool): New variable.
2577 (main): Assign ns_pool.
2578 (Fkill_emacs): Call ns_release_autorelease_pool.
2580 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2581 autorelease fdesc, release fdAttrs and tdict.
2582 (ns_get_covering_families): Release charset.
2583 (ns_findfonts): Release NSFontDescriptor created with new.
2584 (ns_uni_to_glyphs): Fix indentation.
2585 (setString): Release attrStr before assigning new value.
2587 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2589 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2591 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2592 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2594 2011-12-18 David Reitter <reitter@cmu.edu>
2596 * nsterm.m (ns_term_init): Subscribe for notifications
2597 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2598 to method trackingNotification in EmacsMenu.
2600 * nsmenu.m (trackingMenu): New variable.
2601 (trackingNotification): New method (from Aquamacs).
2602 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2603 from Aquamacs (Bug#7030).
2605 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2607 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2608 (symbol_to_nsstring): Fix indentation.
2609 (ns_symbol_to_pb): New function.
2610 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2611 (Fns_rotate_cut_buffers_internal): Remove.
2612 (Fns_store_selection_internal): Rename from
2613 Fns_store_cut_buffer_internal.
2614 (ns_get_foreign_selection, Fx_own_selection_internal)
2615 (Fx_disown_selection_internal, Fx_selection_exists_p)
2616 (Fns_get_selection_internal, Fns_store_selection_internal):
2617 Use ns_symbol_to_pb and check if return value is nil.
2618 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2619 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2620 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2621 renamed to Sns_store_selection_internal.
2622 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2623 and remove this function.
2624 (ns_handle_selection_clear): Remove, never used.
2625 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2628 2011-12-17 Ken Brown <kbrown@cornell.edu>
2630 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2631 GID is unknown (Bug#10257).
2633 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2635 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2636 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2637 which caused a build failure on GNU/Linux IA-64. This problem was
2638 introduced by my 2011-10-07 patch.
2640 2011-12-15 Juri Linkov <juri@jurta.org>
2642 * image.c (imagemagick_error): New function. (Bug#10112)
2643 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2644 Use `imagemagick_error' where ImageMagick functions return
2646 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2649 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2651 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2652 fill background (Bug#8992).
2654 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2656 * window.c (Vwindow_combination_resize)
2657 (Vwindow_combination_limit): Use t instead of non-nil in
2659 (Vrecenter_redisplay): Add first sentence of doc-string on
2661 (Frecenter): Fix doc-string typo.
2663 2011-12-11 Kenichi Handa <handa@m17n.org>
2665 * coding.c (Funencodable_char_position): Pay attention to the
2666 buffer text relocation (Bug#9389).
2668 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2670 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2671 gtk_init (Bug#10100).
2673 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2675 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2676 IT->string is nil. (Bug#10263)
2678 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2680 * nsterm.h (x_free_frame_resources): Declare.
2682 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2683 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2685 * nsterm.h (ns_get_defaults_value): Declare.
2687 * nsterm.m (ns_default): Call ns_get_defaults_value.
2689 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2691 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2694 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2696 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2697 that where the value of an _OBJC_* symbol points to is in the .bss
2698 section (Bug#10240).
2700 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2702 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2703 after the loop to call ccl_driver at least once (Bug#8619).
2705 2011-12-08 Kenichi Handa <handa@m17n.org>
2707 * ftfont.c (get_adstyle_property): Fix previous change
2710 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2712 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2713 dirs from the default value of EMACSLOADPATH (bug#10208).
2715 2011-12-07 Glenn Morris <rgm@gnu.org>
2717 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2718 installation and source directories as well. (Bug#10208)
2720 2011-12-06 Chong Yidong <cyd@gnu.org>
2722 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2724 2011-12-06 Glenn Morris <rgm@gnu.org>
2726 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2727 as an error, not just -1. (Bug#10217)
2729 2011-12-05 Chong Yidong <cyd@gnu.org>
2731 * keyboard.c (process_special_events): New function.
2732 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2734 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2736 * coding.c (encode_designation_at_bol): Don't use uninitialized
2737 local variable (Bug#9318).
2739 2011-12-05 Kenichi Handa <handa@m17n.org>
2741 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2742 return Qnil (Bug#8046, Bug#10193).
2744 2011-12-05 Kenichi Handa <handa@m17n.org>
2746 * coding.c (encode_designation_at_bol): New args charbuf_end and
2747 dst. Return the number of produced bytes. Callers changed.
2748 (coding_set_source): Return how many bytes coding->source was
2750 (coding_set_destination): Return how many bytes
2751 coding->destination was relocated.
2752 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2753 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2755 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2757 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2758 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2761 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2763 The following changes are to fix Bug#9318.
2765 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2766 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2767 (encode_coding_iso_2022, encode_coding_sjis)
2768 (encode_coding_big5, encode_coding_charset): Use the above macros.
2770 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2772 * lisp.h (process_quit_flag): Fix external declaration.
2774 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2776 Don't macro-inline non-performance-critical code.
2777 * eval.c (process_quit_flag): New function.
2778 * lisp.h (QUIT): Use it.
2780 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2782 * nsfns.m (get_geometry_from_preferences): New function.
2783 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2785 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2787 * emacs.c (Qkill_emacs): Define.
2788 (syms_of_emacs): Initialize it.
2789 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2790 Qquit_flag to `kill-emacs' instead.
2791 (quit_throw_to_read_char): Add parameter `from_signal'.
2792 All callers changed. Call Fkill_emacs if requested and safe.
2793 * lisp.h (QUIT): Call Fkill_emacs if requested.
2795 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2797 * widget.c (update_wm_hints): Return if wmshell is null.
2798 (widget_update_wm_size_hints): New function.
2800 * widget.h (widget_update_wm_size_hints): Declare.
2802 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2803 widget_update_wm_size_hints (Bug#10104).
2805 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2807 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2808 before a newline, prepare the bidi iterator for consuming the
2809 newline, and keep the current paragraph direction. (Bug#10183)
2810 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2812 2011-12-02 Juri Linkov <juri@jurta.org>
2814 * search.c (Fword_search_regexp): New Lisp function created from
2815 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2816 (Fword_search_backward, Fword_search_forward)
2817 (Fword_search_backward_lax, Fword_search_forward_lax):
2818 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2819 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2821 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2823 * fileio.c (Finsert_file_contents): Move after-change-function call
2824 to before the "handled:" label, since all "goto handled" appear in
2825 cases where the *-change-functions have already been properly called
2828 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2830 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2831 waiting for input. (Bug#10169)
2833 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2835 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2836 verifies glyph row's hash code--we have just reallocated the
2837 glyphs, so their contents can be complete garbage. (Bug#10164)
2839 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2841 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2843 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2845 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2846 attributes are tested _before_ calling verify_row_hash, to protect
2847 against GCC re-ordering of the tests. (Bug#10164)
2849 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2851 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2853 * xterm.c (handle_one_xevent): Only set async_visible and friends
2854 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2855 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2856 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2858 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2860 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2861 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2862 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2863 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2864 All uses changed to use GCPRO1 etc.
2865 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2866 Revert to old implementation (i.e., before 2011-03-11).
2868 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2870 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2871 of scroll runs so as to avoid assigning disabled bogus rows and
2872 unnecessary graphics copy operations.
2874 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2876 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2877 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2878 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2879 (malloc, free, realloc, calloc): Redirect to e_* only when
2882 * lisp.h (GCTYPEBITS): Move before first use.
2883 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2884 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2885 this macro definition.
2887 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2890 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2892 * gtkutil.c (xg_create_frame_widgets):
2893 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2894 present with Gtk+ 2.0.
2896 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2898 * fileio.c (Finsert_file_contents): Undo previous change; see
2899 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2901 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2903 Rename locals to avoid shadowing.
2904 * fileio.c (Finsert_file_contents):
2905 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2906 * process.c (wait_reading_process_output):
2907 Rename inner 'proc' to 'p' to avoid shadowing.
2908 Indent for consistency with usual Emacs style.
2910 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2912 * xdisp.c (redisplay_window): If cursor row is not fully visible
2913 after recentering, and scroll-conservatively is set to a large
2914 number, scroll window by a few more lines to make the cursor fully
2915 visible and out of scroll-margin. (Bug#10105)
2916 (start_display): Don't move to the next line if the display should
2917 start at a newline that is part of a display vector or an overlay
2920 2011-11-24 Juri Linkov <juri@jurta.org>
2922 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2923 after the `MagickPingImage' call. (Bug#10112)
2925 2011-11-23 Chong Yidong <cyd@gnu.org>
2927 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2929 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2931 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2932 making another buffer current. (Bug#10114)
2934 2011-11-23 Glenn Morris <rgm@gnu.org>
2936 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2938 2011-11-23 Chong Yidong <cyd@gnu.org>
2940 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2941 using it (Bug#5984).
2943 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2945 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2946 and header-lines, as they don't have one computed for them.
2949 * .gdbinit (prow): Make displayed values more self-explaining.
2950 Add row's hash code.
2952 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2954 * process.c (wait_reading_process_output): Fix asynchrounous
2955 GnuTLS socket handling on some versions of the GnuTLS library.
2956 (wait_reading_process_output): Add comment and URL.
2958 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2960 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2962 2011-11-21 Chong Yidong <cyd@gnu.org>
2964 * window.c (Fnext_window, Fprevious_window): Doc fix.
2966 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2968 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2970 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2972 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2974 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2976 * window.c (Fset_window_combination_limit): Rename argument
2978 (Vwindow_combination_limit): Remove "status" from doc-string.
2980 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2982 * m/ibms390.h: Remove.
2983 * m/ibms390x.h: Don't include "ibms390.h".
2985 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2987 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2988 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2990 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2992 * casetab.c (Fset_case_table):
2993 * charset.c (Fcharset_after): Fix typos.
2995 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2997 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2998 Otherwise, valgrind does not work on some platforms.
2999 Problem reported by Andreas Schwab in
3000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3001 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3002 is set, removing the need for VIRT_ADDRESS_VARIES.
3003 (PURE_P): Use a more-efficient implementation that needs just one
3004 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3005 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3006 to 4 (xorl, subq, cmpq, setbe).
3007 * alloc.c (pure): Always extern now, since that's the
3008 VIRT_ADDR_VARIES behavior.
3009 (PURE_POINTER_P): Use a single comparison, not two, for
3010 consistency with the new puresize.h.
3011 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3012 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3013 Remove VIRT_ADDR_VARIES no longer needed.
3015 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3017 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3018 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3019 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3020 behave as if the cursor position were at the window margin.
3022 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3023 and the cursor position is out of bounds, behave as if the cursor
3024 position were at the window margin. (Bug#10075)
3026 2011-11-18 Chong Yidong <cyd@gnu.org>
3028 * window.c (Fwindow_combination_limit): Make first argument
3029 non-optional, since it is meaningless for live windows like the
3032 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3034 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3036 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3038 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3039 (graft_intervals_into_buffer): Simplify.
3041 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3043 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3044 hash values of the two rows.
3045 (copy_row_except_pointers): Preserve the used[] arrays and the
3046 hash values of the two rows. (Bug#10035)
3047 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3049 * xdisp.c (row_hash): New function, body extracted from
3050 compute_line_metrics.
3051 (compute_line_metrics): Call row_hash, instead of computing the
3054 * dispnew.c (verify_row_hash): Call row_hash for computing the
3055 hash code of a row, instead of duplicating code from xdisp.c.
3057 * dispextern.h (row_hash): Add prototype.
3059 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3061 * frame.c (delete_frame): Don't delete the terminal when the last
3062 X frame is closed if emacs is built with GTK toolkit.
3064 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3066 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3068 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3070 * window.c (Vwindow_splits): Rename to
3071 Vwindow_combination_resize. Suggested by Juri Linkov.
3072 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3075 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3077 * nsfns.m (Fns_font_name):
3078 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3080 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3082 * window.h (window): Rename slot "nest" to "combination_limit".
3083 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3084 (Fset_window_nest): Rename to Fset_window_combination_limit.
3085 (Vwindow_nest): Rename to Vwindow_combination_limit.
3086 (recombine_windows, make_parent_window, make_window)
3087 (Fsplit_window_internal, saved_window)
3088 (Fset_window_configuration, save_window_save): Rename all
3089 occurrences of window_nest to window_combination_limit.
3091 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3093 * image.c (imagemagick_load_image): Fix typo.
3095 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3097 * xdisp.c (display_line): Move the call to
3098 highlight_trailing_whitespace before the call to
3099 compute_line_metrics, since the latter needs to see the final
3100 faces of all the glyphs to compute ROW's hash value.
3101 Fixes assertion violations in row_equal_p. (Bug#10035)
3103 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3105 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3106 just return (bug#10044).
3108 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3110 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3111 with user-defined heap size. Bump the default size of the temacs
3112 heap to 27MB, to avoid memory warning when running temacs.
3113 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3115 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3116 current_matrix and desired_matrix. (Bug#9990)
3117 (verify_row_hash) [XASSERTS]: New function.
3118 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3119 that the hash value of glyph rows is correct.
3121 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3123 * window.h (window): Remove splits slot.
3124 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3125 (Fdelete_other_windows_internal, make_parent_window)
3126 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3127 (Fset_window_configuration, save_window_save): Don't deal with
3128 split status of windows.
3129 (saved_window): Remove splits slot.
3130 (Vwindow_splits): Rewrite doc-string.
3132 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3134 * xfns.c (unwind_create_frame):
3135 * nsfns.m (unwind_create_frame):
3136 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3137 Vframe_list (Bug#9999).
3139 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3141 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3143 2011-11-11 Kenichi Handa <handa@m17n.org>
3145 * callproc.c (Fcall_process): Set the member dst_multibyte of
3148 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3150 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3151 avoid a crash (bug#9496).
3153 2011-11-09 Chong Yidong <cyd@gnu.org>
3155 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3156 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3158 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3160 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3162 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3164 Avoid some portability problems by eschewing 'extern inline' functions.
3165 The trivial performance wins aren't worth the portability hassles; see
3166 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3168 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3169 (window_box_width, window_box_left, window_box_left_offset)
3170 (window_box_right, window_box_right_offset): Undo previous change,
3171 by removing the "extern"s.
3172 * intervals.c (adjust_intervals_for_insertion)
3173 (adjust_intervals_for_deletion): Undo previous change,
3174 making these static again.
3175 (offset_intervals, temp_set_point_both, temp_set_point)
3176 (copy_intervals_to_string): No longer inline.
3177 * xdisp.c (window_text_bottom_y, window_box_width)
3178 (window_box_height, window_box_left_offset)
3179 (window_box_right_offset, window_box_left, window_box_right)
3180 (window_box): No longer inline.
3182 2011-11-08 Chong Yidong <cyd@gnu.org>
3184 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3185 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3186 Signal an error if not a live window.
3187 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3188 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3190 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3192 * lisp.h (syms_of_abbrev): Remove declaration.
3193 Reported by CHENG Gao <chenggao@royau.me>.
3195 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3197 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3198 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3199 of temacs in GUI mode.
3201 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3203 * window.h: Declare delete_all_child_windows instead of
3204 delete_all_subwindows.
3205 * window.c (Fwindow_nest, Fset_window_nest)
3206 (Fset_window_new_total, Fset_window_new_normal)
3207 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3208 (delete_all_subwindows): Rename to delete_all_child_windows.
3209 (Fdelete_other_windows_internal, Fset_window_configuration):
3210 Call delete_all_child_windows instead of delete_all_subwindows.
3211 * frame.c (delete_frame): Call delete_all_child_windows instead
3212 of delete_all_subwindows.
3214 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3216 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3217 This is also needed for porting to any host where GC_MARK_STACK is
3218 not GC_MAKE_GCPROS_NOOPS.
3219 (which_symbols): Use it.
3221 2011-11-07 Kenichi Handa <handa@m17n.org>
3223 * coding.c (coding_set_destination): Check coding->src_pos only
3224 when coding->src_object is a buffer (bug#9910).
3226 * process.c (send_process): Set the member src_multibyte of coding
3227 to 0 (bug#9911) when sending a unibyte text.
3229 * callproc.c (Fcall_process): Set the member src_multibyte of
3230 process_coding to 0 (bug#9912).
3232 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3234 * xmenu.c (cleanup_widget_value_tree): New function.
3235 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3236 calling free_menubar_widget_value_tree directly (Bug#9830).
3238 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3240 Fix some portability problems with 'inline'.
3241 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3242 (window_box_width, window_box_left, window_box_left_offset)
3243 (window_box_right, window_box_right_offset): Declare extern.
3244 Otherwise, these inline functions do not conform to C99 and
3245 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3246 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3247 * intervals.c (adjust_intervals_for_insertion)
3248 (adjust_intervals_for_deletion): Now extern, because otherwise the
3249 extern inline functions 'offset_intervals' couldn't refer to it.
3250 (static_offset_intervals): Remove.
3251 (offset_intervals): Rewrite using the old contents of
3252 static_offset_intervals. The old version didn't conform to C99
3253 because an extern inline function contained a reference to an
3254 identifier with static linkage.
3256 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3258 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3261 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3263 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3264 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3265 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3266 return Qleft_to_right.
3268 2011-11-06 Chong Yidong <cyd@gnu.org>
3270 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3271 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3272 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3273 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3274 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3275 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3276 (Fwindow_vscroll): Doc fix.
3277 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3278 argument, since it makes no sense to pass a live window and for
3279 consistency with window-child.
3281 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3283 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3286 2011-11-05 Jason Rumney <jasonr@gnu.org>
3288 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3289 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3291 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3292 bitwise arithmetic preventing use of unicode-sip and non-truetype
3295 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3297 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3300 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3301 initialization code to keep similarity to xfns.c after changes
3304 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3306 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3307 (unwind_create_frame): New function (Bug#9943).
3308 (Fx_create_frame): Restructure code to be more similar to the one in
3309 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3310 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3311 Move terminal->reference_count++ just before making the frame official
3314 * nsterm.m (x_free_frame_resources): New function.
3315 (x_destroy_window): Move code to x_free_frame_resources.
3317 * xfns.c (unwind_create_frame): Fix comment.
3318 (Fx_create_frame, x_create_tip_frame):
3319 Move terminal->reference_count++ just before making the frame
3320 official. Move initialization of image_cache_refcount and
3321 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3323 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3325 Support MSVC build with newer versions of Visual Studio.
3326 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3327 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3330 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3331 which are not supported by MSVC.
3332 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3333 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3335 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3337 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3339 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3341 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3343 Support MSVC build with newer versions of Visual Studio.
3344 * w32.c: Don't include w32api.h for MSVC.
3345 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3347 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3348 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3349 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3350 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3352 (alloca) [_MSC_VER]: Define to _alloca.
3354 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3356 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3358 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3360 * xdisp.c (note_mouse_highlight): If either of
3361 previous/next-single-property-change returns nil, treat that as
3362 the beginning or the end of the buffer. (Bug#9955)
3364 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3366 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3367 label is not null (Bug#9951).
3368 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3371 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3373 * window.c (Fwindow_body_size): Mention in the doc string that the
3374 return value is in frame's canonical units. (Bug#9949)
3376 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3378 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3380 * w32fns.c (unwind_create_frame): If needed, free the glyph
3381 matrices of the partially constructed frame. (Bug#9943)
3382 * xfns.c (unwind_create_frame): Likewise.
3384 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3386 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3387 Don't stop backward scan on the continuation glyph, even though
3388 its CHARPOS is positive.
3389 (mouse_face_from_buffer_pos, note_mouse_highlight):
3390 Rename cover_string to disp_string.
3392 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3394 * window.c (temp_output_buffer_show): Don't use
3395 Vtemp_buffer_show_specifiers.
3396 (Vtemp_buffer_show_specifiers): Remove unused variable.
3398 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3400 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3401 past the beginning of the current glyph matrix.
3403 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3405 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3406 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3407 HAVE_GTK3 (Bug#9869).
3409 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3410 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3412 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3414 * xterm.c: Declare x_handle_net_wm_state to return int.
3415 (handle_one_xevent): Check if we are iconified but don't have
3416 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3417 (get_current_wm_state): Return non-zero if not hidden,
3418 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3419 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3420 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3421 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3423 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3425 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3426 so that this new function doesn't get optimized away by a
3427 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3429 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3431 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3433 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3435 Fix the `xbytecode' command.
3436 * .gdbinit (xprintbytestr): New command.
3437 (xwhichsymbols): Rename from `which'; all callers changed.
3438 (xbytecode): Print the byte-code string as well.
3440 2011-10-29 Kim Storm <storm@cua.dk>
3442 * alloc.c (which_symbols): New function.
3444 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3446 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3449 2011-10-29 Glenn Morris <rgm@gnu.org>
3451 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3452 Not clear what it was for, and it causes various bugs. (Bug#9839)
3454 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3456 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3457 possible random value that matches one of those tested as
3458 condition to clear the mouse face.
3460 2011-10-28 Chong Yidong <cyd@gnu.org>
3462 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3464 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3466 * window.c (make_window): Initialize phys_cursor_on_p.
3468 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3470 * lisp.h (struct Lisp_Symbol): Update comments.
3472 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3474 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3476 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3478 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3479 <oslsachem@gmail.com> for helping to debug this.
3481 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3482 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3483 (g_b_init_get_glyph_outline_w): New static variables.
3484 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3485 (GetGlyphOutlineW_Proc): New typedefs.
3486 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3487 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3489 (w32font_open_internal, compute_metrics):
3490 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3491 instead of calling the "wide" APIs directly.
3493 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3495 * w32.h (syms_of_w32font): Add prototype.
3497 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3499 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3500 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3501 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3502 (Fmove_to_window_line): Doc fix.
3504 2011-10-27 Chong Yidong <cyd@gnu.org>
3506 * process.c (make_process): Set gnutls_state to NULL.
3508 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3509 non-NULL, regardless of GNUTLS_INITSTAGE.
3510 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3511 an error. Set process slots as soon as we allocate them.
3513 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3515 2011-10-27 Chong Yidong <cyd@gnu.org>
3517 * gnutls.c (emacs_gnutls_deinit): New function.
3518 Deallocate credentials structures as well as calling gnutls_deinit.
3519 (Fgnutls_deinit, Fgnutls_boot): Use it.
3521 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3522 (deactivate_process): Call emacs_gnutls_deinit.
3524 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3526 * image.c (x_create_x_image_and_pixmap):
3527 * w32.c (sys_rename, w32_delayed_load):
3528 * w32font.c (fill_in_logfont):
3529 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3531 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3533 * w32fns.c (w32_default_color_map): New function,
3534 extracted from Fw32_default_color_map.
3535 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3537 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3539 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3541 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3543 * keyboard.c (test_undefined): New function (bug#9751).
3544 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3546 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3548 * sysdep.c (init_sys_modes): Fix the check for the controlling
3549 terminal (Bug#6649).
3551 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3553 * dispextern.h (struct bidi_it): New member next_en_type.
3555 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3556 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3557 current character, check also for next_en_type being WEAK_EN.
3558 (bidi_resolve_weak): Don't enter the expensive loop if the current
3559 position is before next_en_pos. Record the bidi type of the first
3560 non-ET, non-BN character we find, in addition to its position.
3561 (bidi_level_of_next_char): Invalidate next_en_type when
3562 next_en_pos is over-stepped.
3564 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3566 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3567 * editfns.c: Rewrite current-time-zone so that it invokes
3568 the equivalent of (format-time-string "%Z") to get the time zone name.
3569 This fixes a bug when the time zone name contains characters that
3570 need converting from the system time locale to Emacs internal format.
3571 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3572 that patch fixed format-time-string to do the conversion, but
3573 I forgot to fix current-time-zone.
3574 (format_time_string): New function, containing most of
3575 what Fformat_time_string used to contain.
3576 (Fformat_time_string): Rewrite in terms of format_time_string.
3577 This doesn't change this function's behavior.
3578 (current-time-zone): Rewrite to use format_time_string.
3579 This fixes the bug reported by Michael Schierl in
3580 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3581 Jason Rumney's 2007-06-07 change worked around this bug, but
3583 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3585 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3587 * xdisp.c (start_display): If the character at POS is displayed
3588 via a display vector, reset IT->current.dpvec_index to zero.
3589 (try_window_reusing_current_matrix): If a line ends in a display
3590 vector or the next line starts in a display vector, continue
3591 redrawing the window even though the character position of
3592 start_row was reached.
3595 2011-10-18 Chong Yidong <cyd@gnu.org>
3597 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3598 with nobreak-char-display too.
3600 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3602 Fix part 3 of bug#9771.
3603 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3604 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3605 non-neutral characters if the current character is a paragraph
3606 separator (a.k.a. Newline). This avoids running the same
3607 expensive loop twice, once when we consume the preceding newline
3608 and the other time when the line actually needs to be displayed.
3609 Avoid the loop when we see neutrals on the base embedding level
3610 following a character whose directionality is the same as the
3611 paragraph's. This avoids running the expensive loop when a line
3612 ends in a long sequence of neutrals, like control characters.
3613 Add assertion against STRONG_AL type. Slightly rearrange code
3614 that determines the type of a neutral given the first non-neutral
3616 (bidi_level_of_next_char): Set next_en_pos to zero when
3617 invalidating its info.
3619 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3621 * xdisp.c (push_display_prop): Determine whether to record string
3622 or buffer position by IT->string, not by IT->method. Allow
3623 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3624 (move_it_vertically_backward): Don't look for character position
3625 immediately after the newline when in a continuation line.
3628 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3630 * window.c (coordinates_in_window): Rewrite and delabelize
3631 vertical border check. (Bug#5357) (Bug#9618)
3633 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3635 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3636 errors in XSetWindowBorder (bug#9310).
3638 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3640 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3641 avoid crash when xmalloc overrun checking is enabled.
3643 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3645 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3646 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3647 cursor motion with <left> and <right> arrow keys.
3649 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3650 some callers set that themselves.
3652 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3654 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3655 display string and the previous row comes from the same string and
3656 is empty. (Bug#9739) (Bug#9738)
3658 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3660 * doc.c (get_doc_string): Encode file name (bug#9735).
3662 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3664 * bidi.c (bidi_level_of_next_char):
3665 * xdisp.c (get_visually_first_element): Remove old incorrect
3666 comments regarding the Unicode Line Separator character.
3668 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3670 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3672 * alloc.c (Fgc_status): Do not access beyond zombies array
3673 boundary if nzombies > MAX_ZOMBIES.
3674 * alloc.c (dump_zombies): Add missing format specifier.
3676 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3678 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3679 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3681 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3682 Some packages use them to denote characters with modifiers.
3684 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3686 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3687 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3688 matching a pp-number. Rename parameter var to var1.
3690 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3692 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3694 2011-10-08 Glenn Morris <rgm@gnu.org>
3696 * callint.c (Fcall_interactively): Give a more explicit error for the
3697 'c' case with a non-character input. (Bug#8479)
3699 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3701 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3703 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3704 lines that are hscrolled on the left.
3706 * dispnew.c (buffer_posn_from_coords): Account for a possible
3707 presence of header-line. (Bug#4426)
3709 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3711 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3712 Don't advertise functionality which we discourage or doesn't work.
3714 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3716 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3717 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3718 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3719 this makes Emacs dump core during garbage collection on rare
3720 occasions. sizeof is obviously inferior to offsetof here, so
3721 stick with offsetof.
3722 (GC_POINTER_ALIGNMENT): New macro.
3723 (mark_memory): Omit 3rd (offset) arg; caller changed.
3724 Don't assume EMACS_INT alignment is the same as pointer alignment.
3726 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3728 * keyboard.c (read_key_sequence_remapped): New var.
3729 (read_key_sequence): Compute remapping in the right buffer.
3730 (command_loop_1): Use read_key_sequence's remapping directly.
3732 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3734 * dired.c (file_name_completion): Don't expand file name.
3735 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3736 before checking file name handler.
3738 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3739 they've been requested explicitly (bug#9591).
3741 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3743 * keymap.c (Fsingle_key_description): Use make_specified_string
3744 instead of build_string to build string from push_key_description.
3747 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3749 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3750 This fixes a Y2038 bug on 64-bit hosts.
3751 * buffer.c (reset_buffer):
3752 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3753 (Fclear_buffer_auto_save_failure):
3754 Use 0, not -1, to represent an unset failure time, since time_t
3755 might not be signed.
3757 Remove dependency on glibc malloc internals.
3758 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3759 Move back here from lisp.h, but with their new implementations.
3760 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3761 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3762 * charset.c (charset_table_init): New static var.
3763 (syms_of_charset): Use it instead of xmalloc. This removes a
3764 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3765 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3766 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3767 Move back to alloc.c.
3768 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3769 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3771 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3773 * nsterm.m (windowDidResize): Call x_set_window_size only when
3774 ns_in_resize is true. Otherwise set pixelwidth/height and
3775 call change_frame_size (Bug#9628).
3777 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3779 Port --enable-checking=all to Fedora 14 x86-64.
3780 * charset.c (syms_of_charset): Also account for glibc malloc's
3781 internal overhead when calculating the initial malloc maximum.
3783 Port --enable-checking=all to Fedora 14 x86.
3784 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3786 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3787 (overrun_check_realloc, overrun_check_free):
3788 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3789 That way, xmalloc returns a properly-aligned pointer even if
3790 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3791 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3792 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3793 into account when calculating the initial malloc maximum.
3794 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3795 Move here from alloc.c, so that charset.c can use it too.
3796 Properly align; the old code wasn't right for common 32-bit hosts
3797 when configured with --enable-checking=all.
3798 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3799 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3801 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3803 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3806 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3808 * xdisp.c (compute_display_string_end): If there's no display
3809 string at CHARPOS, return -1.
3811 * bidi.c (bidi_fetch_char): When compute_display_string_end
3812 returns a negative value, treat the character as a normal
3813 character not covered by a display string. (Bug#9624)
3815 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3817 * lread.c (Fread_from_string): Fix typo in docstring.
3819 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3821 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3822 newline, reseat the iterator instead of bidi-iterating there one
3823 character at a time. (Bug#9610)
3824 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3825 TO_CHARPOS if the bidi iterator is at base embedding level.
3827 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3829 * lread.c (readevalloop): Use correct code for NBSP.
3830 (read1): Likewise. (Bug#9608)
3832 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3834 * dbusbind.c (Fdbus_register_signal): When service is not
3835 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3837 2011-09-25 Glenn Morris <rgm@gnu.org>
3839 * buffer.c (truncate-lines): Doc fix.
3841 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3843 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3844 (Fset_window_next_buffers): Doc fix.
3846 2011-09-24 Glenn Morris <rgm@gnu.org>
3848 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3850 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3852 Fix minor problems found by static checking.
3853 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3854 * indent.c (Fvertical_motion): Fix == vs = typo.
3856 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3858 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3859 Default value is now t. Doc fix.
3861 * indent.c (Fvertical_motion): Compute and apply the overshoot
3862 logic when moving up, not only when moving down. Fix the
3863 confusing name and values of the it_overshoot_expected variable;
3864 logic changes accordingly. (Bug#9254) (Bug#9549)
3866 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3867 CHARPOS is covered by a display string which includes newlines.
3868 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3869 is covered by a display string with embedded newlines.
3871 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3873 * dbusbind.c (Fdbus_register_signal): Add match rule to
3874 Vdbus_registered_objects_table. (Bug#9581)
3875 (Fdbus_register_method, Vdbus_registered_objects_table):
3878 2011-09-24 Jim Meyering <meyering@redhat.com>
3880 do not ignore write error for any output size
3881 The previous change was incomplete.
3882 While it makes emacs --batch detect the vast majority of stdout
3883 write failures, errors were still ignored whenever the output size is
3884 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3885 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3886 && echo FAIL: ignored write error
3887 FAIL: ignored write error
3888 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3889 && echo FAIL: ignored write error
3890 FAIL: ignored write error
3891 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3893 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3895 * emacs.c (Fkill_emacs): In noninteractive mode exit
3896 non-successfully if a write error occurred on stdout. (Bug#9574)
3898 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3900 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3903 * dispextern.h (struct it): Update the comment documenting what
3906 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3908 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3909 a display string, extend search for cursor position to end of row.
3910 (find_row_edges): If the row ends in a newline from a display
3911 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3912 Handle the case of a display string with multiple newlines.
3913 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3914 non-empty line. Fixes confusing cursor motion with arrow keys at
3915 the beginning of a line that starts with whitespace.
3917 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3919 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3922 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3924 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3927 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3929 * xdisp.c (display_line): Record maximum and minimum buffer
3930 positions even if no glyphs were produced (e.g., by a zero-width
3931 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3932 buffer positions that will be removed from the glyph row because
3934 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3935 column is beyond frame width: don't subtract 1 "pixel" when
3936 computing width of the stretch.
3937 (reseat_at_next_visible_line_start): Undo the change made on
3938 2011-09-17 that saved paragraph information and restored it after
3939 the call to `reseat'. (Bug#9545)
3941 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3943 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3944 and turn window cursor on if cleared (Bug#9415).
3946 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3948 * search.c (boyer_moore): Take unibyte characters from pattern
3949 literally. (Bug#9458)
3951 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3953 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3955 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3957 Fix minor problem found by static checking.
3958 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3959 initialized, to pacify gcc -Wuninitialized.
3961 * fileio.c: Report proper errno when syscall falls.
3962 (Finsert_file_contents): Save and restore errno,
3963 so that report_file_error outputs the correct diagnostic.
3964 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3966 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3968 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3970 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3972 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3973 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3975 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3977 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3978 about the current paragraph and restore it after the call to reseat.
3980 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3981 (bidi_find_paragraph_start): Search back for paragraph beginning
3982 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3983 (bidi_move_to_visually_next): Only trigger paragraph-related
3984 computations when the last character is a newline or at EOB, not
3985 just any NEUTRAL_B. (Bug#9470)
3987 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3988 truncated lines if point is covered by a display string. (Bug#9524)
3990 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3992 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3993 (cons_to_x_long): New function.
3994 (lisp_data_to_selection_data): Use it. Correct the test for
3995 short-versus-long data; it was negated. Break out of vector
3996 loop, for efficiency, when a long datum is discovered.
3998 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4000 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4002 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4004 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4005 GCC PR/17406) by declaring this function with external scope.
4007 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4009 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4010 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4012 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4014 * editfns.c (Fformat): Correctly handle text properties on "%%".
4016 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4018 * xterm.c (x_draw_composite_glyph_string_foreground):
4019 * w32term.c (x_draw_composite_glyph_string_foreground):
4020 * term.c (encode_terminal_code):
4021 * composite.c (composition_update_it, get_composition_id):
4022 * xdisp.c (get_next_display_element)
4023 (fill_composite_glyph_string): Add comments about special meaning
4024 of TAB characters in a composition.
4026 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4028 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4029 This occurs when processing a multibyte format.
4030 Problem reported by Wolfgang Jenker.
4032 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4034 * xdisp.c (try_cursor_movement): Only check for exact match if
4035 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4037 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4039 Remove unused external symbols.
4040 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4041 * xdisp.c (calc_pixel_width_or_height): Now static.
4042 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4043 * indent.c (check_display_width):
4044 * w32term.c: Fix comment to match code.
4045 * xterm.c, xterm.h (x_catching_errors): Remove.
4047 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4049 * xselect.c: Use signed conversions more consistently (Bug#9498).
4050 (selection_data_to_lisp_data): Assume incoming selection data are
4051 signed integers, not unsigned. This is to be consistent with
4052 outgoing selection data, which was modified to use signed integers
4053 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4054 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4055 expects long, not unsigned long.
4057 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4059 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4060 computation of loop end. Reported by Johan Bockgård
4063 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4065 * frame.c (Fother_visible_frames_p): Function deleted.
4067 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4069 * indent.c (compute_motion): Process display vector front to back
4070 rather than the other way around. (Bug#2496)
4072 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4074 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4076 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4078 * minibuf.c (Fread_from_minibuffer): Doc fix.
4080 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4082 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4083 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4085 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4087 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4088 value for non-existent files.
4090 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4092 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4093 set its "size" to -1. This will set the modtime_size field of
4094 the corresponding buffer to -1, which is what
4095 verify-visited-file-modtime expects for files that do not exist.
4098 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4100 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4102 * lisp.h: ... from here. push_key_description is no longer
4103 defined in keyboard.c, so its declaration should not be in
4104 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4105 logically belongs with push_key_description.
4107 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4109 * buffer.h: Include <sys/types.h> instead of <time.h>.
4110 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4111 Problem reported by Herbert J. Skuhra.
4113 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4115 * xml.c (parse_region): Make the parsing work for
4116 non-comment-starting XML files again (bug#9144).
4118 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4120 * image.c (gif_load): Fix calculation of bottom and right corner.
4123 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4125 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4126 redisplay in small windows.
4128 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4130 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4132 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4134 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4135 Operate on live windows only.
4137 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4139 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4141 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4143 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4144 only under bidi iteration.
4146 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4148 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4150 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4152 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4153 Without this fix, the command to link temacs failed due to an
4154 undefined symbol __builtin_isnan. This is because
4155 /usr/include/iso/math_c99.h #defines isnan(x) to
4156 __builtin_isnan(x), but the bundled gcc, which identifies itself
4157 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4159 * floatfns.c (isnan): #undef, and then #define to a clone of
4161 (Fisnan): Always define, since it's always available now.
4162 (syms_of_floatfns): Always define isnan at the Lisp level.
4164 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4166 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4168 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4170 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4171 The previous code assumed that file offsets (off_t values) fit in
4172 EMACS_INT variables, which is not true on typical 32-bit hosts.
4173 The code messed up by falsely reporting buffer overflow in cases
4174 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4175 when "big" contains more than 2**29 bytes, even though this
4176 inserts just one byte and does not overflow the buffer.
4177 (Finsert_file_contents): Store file offsets as off_t
4178 values, not as EMACS_INT values. Check for overflow when
4179 converting between EMACS_INT and off_t. When checking for
4180 buffer overflow or for overlap, take the offsets into account.
4181 Don't use EMACS_INT for small values where int suffices.
4182 When checking for overlap, fix a typo: ZV was used where
4183 ZV_BYTE was intended.
4184 (Fwrite_region): Don't assume off_t fits into 'long'.
4185 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4187 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4189 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4191 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4193 sprintf-related integer and memory overflow issues (Bug#9412).
4195 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4196 (esprintf, exprintf, evxprintf): New functions.
4197 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4198 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4199 (modify_event_symbol): Do not assume that the length of
4200 name_alist_or_stem is safe to alloca and fits in int.
4201 (Fexecute_extended_command): Likewise for function name and binding.
4202 (Frecursion_depth): Wrap around reliably on integer overflow.
4203 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4204 since some callers pass EMACS_INT values.
4205 (Fsingle_key_description): Don't crash if symbol name contains more
4206 than MAX_ALLOCA bytes.
4207 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4208 (get_minibuffer): Arg is now EMACS_INT, not int.
4209 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4210 (esprintf, exprintf, evxprintf): New decls.
4211 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4213 * dbusbind.c (signature_cat): New function.
4214 (xd_signature, Fdbus_register_signal):
4215 Do not overrun buffer; instead, report string overflow.
4217 * dispnew.c (add_window_display_history): Don't overrun buffer.
4218 Truncate instead; this is OK since it's just a log.
4220 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4221 even if the time zone offset is outlandishly large.
4222 Don't mishandle offset == INT_MIN.
4224 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4225 when creating daemon; the previous buffer-overflow check was incorrect.
4227 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4228 which has the guts of the old verror function.
4230 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4231 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4233 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4234 (font_unparse_xlfd): Don't blindly alloca long strings.
4235 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4236 fits in int, when using sprintf. Use single snprintf to count
4237 length of string rather than counting it via multiple sprintfs;
4238 that's simpler and more reliable.
4239 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4240 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4241 sprintf, in case result does not fit in int.
4243 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4244 (fontset_from_font): Print it.
4246 * frame.c (tty_frame_count): Now printmax_t, not int.
4247 (make_terminal_frame, set_term_frame_name): Print it.
4248 (x_report_frame_params): In X, window IDs are unsigned long,
4249 not signed long, so print them as unsigned.
4250 (validate_x_resource_name): Check for implausibly long names,
4251 and don't assume name length fits in 'int'.
4252 (x_get_resource_string): Don't blindly alloca invocation name;
4253 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4256 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4257 (xg_check_special_colors, xg_set_geometry):
4258 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4260 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4261 Use esprintf, not sprintf, in case result does not fit in int.
4263 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4264 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4265 it as a large positive number.
4266 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4267 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4269 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4270 in case result does not fit in int.
4272 * print.c (float_to_string): Detect width overflow more reliably.
4273 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4274 buffer overrun. Don't assume list length fits in 'int'. Treat
4275 print length of 0 as 0, not as infinity; to be consistent with other
4276 uses of print length in this function. Don't overflow print length
4277 index. Don't assume hash table size fits in 'long', or that
4278 vectorlike size fits in 'unsigned long'.
4280 * process.c (make_process): Use printmax_t, not int, to format
4281 process-name gensyms.
4283 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4285 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4286 to avoid potential buffer overrun.
4288 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4289 if X resource line is longer than 512 bytes.
4291 * xfns.c (x_window): Make sprintf buffer a bit bigger
4292 to avoid potential buffer overrun.
4294 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4296 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4298 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4300 Integer overflow fixes for scrolling, etc.
4301 Without these, Emacs silently mishandles large integers sometimes.
4302 For example, "C-u 4294967297 M-x recenter" was treated as if
4303 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4305 * xdisp.c (try_window_id): Check Emacs fixnum range before
4306 converting to 'int'.
4308 * window.c (window_scroll_line_based, Frecenter):
4309 Check that an Emacs fixnum is in range before assigning it to 'int'.
4310 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4311 values converted from Emacs fixnums.
4312 (Frecenter): Don't wrap around a line count if it is out of 'int'
4313 range; instead, treat it as an extreme value.
4314 (Fset_window_configuration, compare_window_configurations):
4315 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4317 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4318 that can exceed INT_MAX. Check that EMACS_INT value is in range
4319 before assigning it to the (possibly-narrower) index.
4320 (match_limit): Don't assume that a fixnum can fit in 'int'.
4322 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4325 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4326 (Fvertical_motion): Don't wrap around LINES values that don't fit
4327 in 'int'. Instead, treat them as extreme values. This is good
4328 enough for windows, which can't have more than INT_MAX lines anyway.
4330 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4332 * Require libxml/parser.h to avoid compilation warning.
4334 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4336 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4337 since this reportedly can destroy thread storage.
4339 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4341 * syntax.c (find_defun_start): Update all cache variables if
4342 exiting early (Bug#9401).
4344 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4346 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4348 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4349 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4350 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4352 * term.c (tty_append_glyph): New function.
4353 (produce_stretch_glyph): Static function and its prototype deleted.
4355 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4358 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4360 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4361 when checking :margin (Bug#9390).
4362 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4363 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4364 so that the name doesn't mislead. All uses changed.
4366 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4368 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4371 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4373 * xdisp.c (move_it_to): Don't bail out early when reaching
4374 position beyond to_charpos, if we are scanning backwards.
4375 (move_it_vertically_backward): When DY == 0, make sure we get to
4376 the first character in the line after the newline.
4378 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4380 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4381 (ccl_driver): Do not generate an out-of-range pointer.
4382 (Fccl_execute_on_string): Remove unnecessary check for
4383 integer overflow, noted by Stefan Monnier in
4384 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4385 Remove a FIXME that didn't need fixing.
4386 Simplify the newly-introduced buffer reallocation code.
4388 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4390 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4392 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4394 Integer and memory overflow issues (Bug#9196).
4396 * doc.c (get_doc_string): Rework so that
4397 get_doc_string_buffer_size is the actual buffer size, rather than
4398 being 1 less than the actual buffer size; this makes xpalloc more
4401 * image.c (x_allocate_bitmap_record, cache_image):
4402 * xselect.c (Fx_register_dnd_atom):
4403 Simplify previous changes by using xpalloc.
4405 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4406 since either will do and ptrdiff_t is convenient with xpalloc.
4408 * charset.c (charset_table_size)
4409 (struct charset_sort_data.priority): Now ptrdiff_t.
4410 (charset_compare): Don't overflow if priorities differ greatly.
4411 (Fsort_charsets): Don't assume list length fits in int.
4412 Check for size-calculation overflow when allocating sort data.
4413 (syms_of_charset): Allocate an initial charset table that is
4414 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4416 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4418 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4419 The actual value is always <= INT_MAX, and leaving it unsigned made
4420 overflow checking harder.
4422 * dispextern.h (struct glyph_matrix.rows_allocated)
4423 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4424 with xpalloc. The values are still always <= INT_MAX.
4426 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4428 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4429 (SAFE_NALLOCA): New macro.
4431 * region-cache.c (struct boundary.pos, find_cache_boundary)
4432 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4433 (set_cache_region, invalidate_region_cache)
4434 (revalidate_region_cache, know_region_cache, region_cache_forward)
4435 (region_cache_backward, pp_cache):
4436 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4437 so that ptrdiff_t * can be passed to xpalloc.
4438 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4439 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4440 (pp_cache): Don't assume cache_len fits in int.
4441 * region-cache.h: Adjust extern decls to match.
4443 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4444 EMACS_INT, since either will do, for xpalloc.
4446 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4447 (xnmalloc, xnrealloc, xpalloc): New functions.
4449 * bidi.c (bidi_shelve_header_size): New constant.
4450 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4451 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4453 * bidi.c (bidi_cache_shrink):
4454 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4456 Don't update size of array until after memory allocation succeeds,
4457 because xmalloc/xrealloc may not return.
4458 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4459 now that we have proper integer overflow checking.
4460 (record_overlay_string, overlay_strings): Catch overflows when
4461 calculating size of overlay_str_buf.
4463 * callproc.c (Fcall_process): Check for size overflow when
4464 calculating size of args2.
4465 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4466 Normally we prefer signed values, but sticking with ptrdiff_t would
4467 require adding more-complicated checks.
4469 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4470 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4471 Redo buffer-overflow calculations to avoid integer overflow.
4472 Add a FIXME comment where memory seems to be over-allocated.
4474 * character.c (Fstring): Check for size-calculation overflow.
4476 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4477 unnecessary integer overflow. Check for size overflow.
4478 (encode_coding_object): Don't update size until xmalloc succeeds.
4480 * composite.c (get_composition_id): Check for overflow in glyph
4481 length calculations.
4483 Integer and memory overflow fixes for display code.
4484 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4485 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4486 (scrolling_window): Check for overflow in size calculations.
4487 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4488 Don't assume glyph table len fits in int.
4489 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4490 (row_table_size): Now ptrdiff_t, not int.
4491 (scrolling_window): Avoid overflow in size calculations.
4492 Don't update size until allocation succeeds.
4493 * fns.c (concat): Check for overflow in size calculations.
4494 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4495 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4496 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4498 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4499 (get_doc_string): Check for size calculation overflow.
4500 Don't update size until allocation succeeds.
4501 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4502 EMACS_INT, where ptrdiff_t will do.
4503 (Fsubstitute_command_keys): Check for string overflow.
4505 * editfns.c (set_time_zone_rule): Don't assume environment length
4507 (message_length): Now ptrdiff_t, not int.
4508 (Fmessage_box): Don't update size until allocation succeeds.
4509 Don't assume message length fits in int.
4510 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4512 * emacs.c (main): Do not reallocate argv, since there is a null at
4513 the end that can be overwritten, and this way there's no need to
4514 worry about size-calculation overflow.
4515 (sort_args): Check for size-calculation overflow.
4517 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4519 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4521 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4522 (x_set_scroll_bar_width, x_figure_window_size):
4523 Check for integer overflow.
4524 (x_set_alpha): Do not assume XINT fits in int.
4526 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4527 This is for the members text_lines, text_cols, total_lines, total_cols,
4528 where the system imposes an 'int' limit.
4530 * fringe.c (Fdefine_fringe_bitmap):
4531 Don't update size until alloc works.
4533 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4534 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4536 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4537 Check for size-calculation overflow.
4538 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4539 do, as we prefer signed integers.
4540 (id_to_widget.max_size, id_to_widget.used)
4541 (xg_store_widget_in_map, xg_remove_widget_from_map)
4542 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4543 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4544 Use and return ptrdiff_t, not int.
4545 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4546 * gtkutil.h: Change prototypes to match the above.
4548 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4549 are duplicate now that they've been promoted to lisp.h.
4550 (x_allocate_bitmap_record, x_alloc_image_color)
4551 (make_image_cache, cache_image, xpm_load):
4552 Don't update size until alloc is done.
4553 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4555 Check for size calculation overflow.
4556 (ct_colors_allocated_max): New constant.
4557 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4560 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4561 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4562 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4563 Use ptrdiff_t, not int, to count maps.
4564 (read_char_minibuf_menu_prompt): Check for overflow in size
4565 calculations. Don't update size until allocation succeeds.
4566 Redo calculations to avoid overflow.
4567 * keyboard.h: Change prototypes to match the above.
4569 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4571 (current_minor_maps): Check for size calculation overflow.
4572 * keymap.h: Change prototypes to match the above.
4574 * lread.c (read1, init_obarray): Don't update size until alloc done.
4576 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4577 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4579 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4580 Now ptrdiff_t, not int.
4581 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4582 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4584 * process.c (Fnetwork_interface_list): Check for overflow
4585 in size calculation.
4587 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4589 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4590 overflow. Don't bother calling xmalloc when xrealloc will do.
4592 * search.c (Freplace_match): Check for size calculation overflow.
4593 (Fset_match_data): Don't assume list lengths fit in 'int'.
4595 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4596 for command line length. Do not attempt to address one before the
4597 beginning of an array, as that's not portable.
4599 * term.c (max_frame_lines): Remove; unused.
4600 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4602 (encode_terminal_code, calculate_costs): Check for size
4603 calculation overflow.
4604 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4605 table lengths and related sizes. Don't update size until alloc
4606 done. Redo calculations to avoid overflow.
4607 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4609 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4610 subtracting pointers.
4611 (gobble_line): Check for overflow more carefully. Don't update size
4614 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4615 Don't update size until alloc done.
4616 Redo size calculations to avoid overflow.
4617 Check for size calculation overflow.
4618 (main) [DEBUG]: Fix typo in invoking tparam1.
4620 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4621 Use ptrdiff_t, not int, for sizes.
4622 (store_mode_line_noprop_char): Don't update size until alloc done.
4624 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4625 Use ptrdiff_t, not int, for sizes.
4626 (Finternal_make_lisp_face, cache_face):
4627 Check for size calculation overflow.
4628 (cache_face): Treat size calculation overflows as if they were
4629 memory exhaustion (the usual treatment), rather than aborting.
4631 * xfns.c (x_encode_text, x_set_name_internal)
4632 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4633 sizes, since they can exceed INT_MAX in size. Check for size
4634 calculation overflow.
4636 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4637 (xg_select): Check for size calculation overflow.
4638 Don't update size until alloc done.
4640 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4641 as sprintf is limited to int lengths.
4643 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4644 (X_LONG_MIN): New macros.
4645 Use them to make the following changes clearer.
4646 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4647 This change doesn't affect the value now, but it may help remind
4648 future maintainers not to raise the value too much later.
4649 (SELECTION_QUANTUM): Remove, replacing with ...
4650 (selection_quantum): ... new function, which avoids overflow.
4652 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4653 assumption that selection length fits in 'int'.
4654 (x_reply_selection_request, x_handle_selection_request)
4655 (x_get_window_property, receive_incremental_selection)
4656 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4657 (lisp_data_to_selection_data, clean_local_selection_data):
4658 Use ptrdiff_t, not int, to record length of selection.
4659 (x_reply_selection_request, x_get_window_property)
4660 (receive_incremental_selection, x_property_data_to_lisp):
4661 Redo calculations to avoid overflow.
4662 (x_reply_selection_request): When sending hint, ceiling it at
4663 X_LONG_MAX rather than relying on wraparound overflow to send
4665 (x_get_window_property, receive_incremental_selection)
4666 (lisp_data_to_selection_data, x_property_data_to_lisp):
4667 Check for size-calculation overflow.
4668 (x_get_window_property, receive_incremental_selection)
4669 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4670 Don't store size until memory allocation succeeds.
4671 (x_get_window_property): Plug memory leak on memory exhaustion.
4672 Don't double-block input; malloc is safe here. Don't assume 2**34
4673 - 4 fits in unsigned long. Add an xassert to check
4674 XGetWindowProperty overflow. Be more careful about overflow
4675 calculations, and distinguish size from memory overflow better.
4676 (receive_incremental_selection): When tracing, don't assume
4677 unsigned int is less than INT_MAX.
4678 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4679 harmful) conversions of unsigned short to int.
4680 (lisp_data_to_selection_data): Don't assume that integers
4681 in the range -65535 through -1 fit in an X unsigned short.
4682 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4683 result parameters unless successful. Rely on cons_to_unsigned
4684 to report problems with elements; the old code wasn't right anyway.
4685 (x_check_property_data): Check for int overflow; we cannot use
4686 a wider type due to X limits.
4687 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4689 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4691 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4692 (x_term_init): Check for size calculation overflow.
4693 (x_color_cells): Don't store size until memory allocation succeeds.
4694 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4695 Don't assume alloca size is less than MAX_ALLOCA.
4696 (x_term_init): Don't assume length fits in int (sprintf is limited
4699 Use ptrdiff_t for composition IDs.
4700 * character.c (lisp_string_width):
4701 * composite.c (composition_table_size, n_compositions)
4702 (get_composition_id, composition_gstring_from_id):
4703 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4704 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4705 * window.c (Frecenter):
4706 Use ptrdiff_t, not int, for composition IDs.
4707 * composite.c (get_composition_id): Check for integer overflow.
4708 * composite.h: Adjust prototypes to match the above changes.
4710 Use ptrdiff_t for hash table indexes.
4711 * category.c (hash_get_category_set):
4712 * ccl.c (ccl_driver):
4713 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4714 * coding.c (coding_system_charset_list, detect_coding_system):
4715 * coding.h (struct coding_system.id):
4716 * composite.c (get_composition_id, gstring_lookup_cache):
4717 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4718 * image.c (xpm_get_color_table_h):
4719 * lisp.h (hash_lookup, hash_put):
4720 * minibuf.c (Ftest_completion):
4721 Use ptrdiff_t for hash table indexes, not int (which is too
4722 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4723 32-bit --with-wide-int hosts).
4725 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4726 Add a FIXME comment about memory leaks.
4727 (syms_of_charset): Don't assume xmalloc returns.
4729 Don't assume that stated character widths fit in int.
4730 * character.c (Fchar_width, c_string_width, lisp_string_width):
4731 * character.h (CHAR_WIDTH):
4732 * indent.c (MULTIBYTE_BYTES_WIDTH):
4733 Use sanitize_char_width to avoid undefined and/or bad behavior
4734 with outlandish widths.
4735 * character.h (sanitize_tab_width): Rename from sanitize_width,
4736 now that we have two such functions. All uses changed.
4737 (sanitize_char_width): New inline function.
4739 Don't assume that tab-width fits in int.
4740 * character.h (sanitize_width): New inline function.
4741 (SANE_TAB_WIDTH): New macro.
4742 (ASCII_CHAR_WIDTH): Use it.
4743 * indent.c (sane_tab_width): Remove. All uses replaced by
4744 SANE_TAB_WIDTH (current_buffer).
4745 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4747 * fileio.c: Integer overflow issues with file modes.
4748 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4750 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4751 Remove unreachable code.
4752 (read_hex, load_charset_map_from_file): Check for integer overflow.
4754 * xterm.c: Don't go over XClientMessageEvent limit.
4755 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4756 (x_send_scroll_bar_event): Likewise. Check that the size does not
4757 exceed limits imposed by XClientMessageEvent, as well as the usual
4758 ptrdiff_t and size_t limits.
4760 * keyboard.c: Overflow, signedness and related fixes.
4761 (make_lispy_movement): Use same integer type in forward decl
4762 that is used in the definition.
4763 (read_key_sequence, keyremap_step):
4764 Change bufsize argument back to int, undoing my 2011-03-30 change.
4765 We prefer signed types, and int is wide enough here.
4766 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4767 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4768 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4769 length, not size_t. Use ptrdiff_t for index, not int.
4770 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4771 possibility of integer overflow.
4773 Overflow, signedness and related fixes for images.
4775 * dispextern.h (struct it.stack[0].u.image.image_id)
4776 (struct_it.image_id, struct image.id, struct image_cache.size)
4777 (struct image_cache.used, struct image_cache.ref_count):
4778 * gtkutil.c (update_frame_tool_bar):
4779 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4780 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4781 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4782 * nsmenu.m (update_frame_tool_bar):
4783 * xdisp.c (calc_pixel_width_or_height):
4784 * xfns.c (image_cache_refcount):
4785 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4786 on typical 64-bit hosts.
4788 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4789 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4790 Omit unnecessary casts to int.
4791 (parse_image_spec): Check that integers fall into 'int' range
4792 when the callers expect that.
4793 (image_ascent): Redo ascent calculation to avoid int overflow.
4794 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4795 (lookup_image): Remove unnecessary tests.
4796 (xbm_image_p): Locals are now of int, not EMACS_INT,
4797 since parse_image_check makes sure they fit into int.
4798 (png_load, gif_load, svg_load_image):
4799 Prefer int to unsigned where either will do.
4800 (tiff_handler): New function, combining the cores of the
4801 old tiff_error_handler and tiff_warning_handler.
4802 This function is rewritten to use vsnprintf and thereby avoid
4803 stack buffer overflows. It uses only the features of vsnprintf
4804 that are common to both POSIX and native Microsoft.
4805 (tiff_error_handler, tiff_warning_handler): Use it.
4806 (tiff_load, gif_load, imagemagick_load_image):
4807 Don't assume :index value fits in 'int'.
4808 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4809 (imagemagick_load_image): Check that crop parameters fit into
4810 the integer types that MagickCropImage accepts. Don't assume
4811 Vimagemagick_render_type has a nonnegative value. Don't assume
4812 size_t fits in 'long'.
4813 (gs_load): Use printmax_t to print the widest integers possible.
4814 Check for integer overflow when computing image height and width.
4816 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4818 * xdisp.c (redisplay_window): Don't force window start if point
4819 will be invisible in the resulting window. (Bug#9324)
4821 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4823 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4824 the display spec is of the form `(space ...)'.
4825 (handle_display_spec): Return the value returned by
4826 handle_single_display_spec, not just 1 or zero.
4827 (handle_single_display_spec): If the display spec is of the form
4828 `(space ...)', and specifies display in the text area, return 2
4830 (try_cursor_movement): Check for the need to scroll more
4831 accurately, and prefer exact match for point under bidi.
4832 Don't advance `row' beyond the last row of the window.
4834 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4835 into disp_prop; all users changed.
4837 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4838 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4839 for the text covered by the display property.
4841 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4843 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4844 Change return value to nil.
4845 (Frecord_buffer): Delete unused function.
4847 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4849 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4850 buffers, return left-to-right.
4851 (set_cursor_from_row): Consider candidate row a win if its glyph
4852 represents a newline and point is on that newline. Fixes cursor
4853 positioning on the newline at EOL of R2L text within L2R
4854 paragraph, and vice versa.
4855 (try_cursor_movement): Check continued rows, in addition to
4856 continuation rows. Fixes unwarranted scroll when point enters a
4857 continued line of R2L text within an L2R paragraph, or vice versa.
4858 (cursor_row_p): Consider the case of point being equal to
4859 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4860 from the end of a short line to the beginning of a continued line
4861 of R2L text within L2R paragraph.
4862 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4863 composed characters.
4865 * bidi.c (bidi_check_type): Use xassert.
4866 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4869 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4871 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4874 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4876 * nsfont.m (ns_otf_to_script): Fix typo.
4878 2011-08-22 Kenichi Handa <handa@m17n.org>
4880 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4881 extra slot even if the purpose is char-code-property-table.
4883 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4885 * xdisp.c (redisplay_window): When computing centering_position,
4886 account for the height of the header line. (Bug#8874)
4888 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4889 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4890 candidate is selected by the mouse, and that candidate has a
4891 composed character under the mouse.
4893 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4894 coordinates reported by pos-visible-in-window-p for a composed
4895 character in column zero.
4897 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4899 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4901 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4903 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4904 consider it a hit if to_charpos is anywhere in the range of the
4905 composed buffer positions.
4907 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4909 * image.c (gif_load): Don't assume that each subimage has the same
4910 dimensions as the base image. Handle disposal method that is
4911 "undefined" by the gif spec (Bug#9335).
4913 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4915 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4916 (Fcondition_case): Document `debug' symbol in error handler.
4918 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4920 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4921 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4922 from an Org mode buffer to a Speedbar frame.
4924 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4925 a composition, take its buffer position from IT->cmp_it.charpos.
4926 Fixes cursor positioning at the beginning of a line that begins
4927 with a composed character.
4929 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4931 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4932 character bidirectional type, use STRONG_L instead. Fixes crashes
4933 in a buffer produced by `describe-categories'.
4935 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4936 members before the level stack, so they would be saved and
4937 restored when copying iterator state. Fixes incorrect reordering
4938 around TABs covered by display properties.
4940 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4942 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4944 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4946 * eval.c (internal_condition_case, internal_condition_case_1)
4947 (internal_condition_case_2, internal_condition_case_n):
4948 Remove unnecessary aborts (Bug#9081).
4950 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4952 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4953 has no `load' handler, try opening the file locally. (Bug#9311)
4955 2011-08-16 Ken Brown <kbrown@cornell.edu>
4957 * gmalloc.c: Expand comment.
4959 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4961 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4962 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4964 2011-08-16 Ken Brown <kbrown@cornell.edu>
4966 Fix memory allocation problems in Cygwin build (Bug#9273).
4968 * unexcw.c ( __malloc_initialized): Declare external variable.
4969 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4971 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4973 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4975 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4977 [CYGWIN] (special_realloc): New function.
4978 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4979 requests to realloc storage in the static heap.
4981 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4983 * bidi.c (bidi_initialize): Remove unused local.
4985 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4988 * biditype.h: Remove file.
4989 * makefile.w32-in ($(BLD)/bidi.$(O)):
4990 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4992 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4994 * chartab.c: Improve commentary for the uniprop_table API.
4996 * bidi.c (bidi_paragraph_init): Support zero value of
4997 bidi_ignore_explicit_marks_for_paragraph_level.
4998 (bidi_initialize): Use uniprop_table instead of including
4999 biditype.h and bidimirror.h.
5001 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5002 coordinates of the iterator when restoring from ppos_it.
5005 2011-08-14 Kenichi Handa <handa@m17n.org>
5007 * process.c (create_process): Call setup_process_coding_systems
5008 after the pid of the process is set to -1 (Bug#8162).
5010 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5012 * xdisp.c (move_it_in_display_line_to): Don't invoke
5013 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5014 ppos_it. Fixes vertical cursor motion when line beginning is
5015 covered by an image. (Bug#9296)
5017 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5019 * nsterm.h (ns_run_ascript): Declare.
5020 (NSAPP_DATA2_RUNASSCRIPT): Define.
5022 * nsfns.m (as_script, as_result, as_status): New static variables.
5023 (ns_run_ascript): New function.
5024 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5025 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5026 the event loop. Get status from as_status (Bug#7276).
5028 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5029 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5030 the event loop (Bug#7276).
5032 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5034 * gnutls.c (QCgnutls_bootprop_priority)
5035 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5036 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5037 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5038 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5039 (QCgnutls_bootprop_verify_hostname_error)
5040 (QCgnutls_bootprop_callbacks_verify): Rename from
5041 Qgnutls_bootprop_..., all uses changed.
5043 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5046 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5048 * xfaces.c (Qframe_set_background_mode): Now static.
5049 * dispextern.h (Qframe_set_background_mode): Remove decl.
5051 * process.c (Fnetwork_interface_info): Declare local only if needed.
5053 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5055 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5056 (Fnetwork_interface_list): Allocate in increments of bytes instead
5057 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5058 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5060 (struct ifflag_def): notrailers is smart on OSX.
5061 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5062 Get hardware address with getifaddrs if available.
5064 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5066 * xdisp.c (iterate_out_of_display_property): xassert that
5067 IT->position is set to within IT->object's boundaries. Break from
5068 the loop as soon as EOB is reached; avoids infloops in redisplay
5069 when IT->position is set up wrongly due to some bug.
5070 Set IT->current to match the bidi iterator unconditionally.
5071 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5072 entry. Force push_it to save on the stack the current
5073 buffer/string position, to be restored by pop_it. Fix flags in
5074 the iterator structure wrt the object coming from a display
5075 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5076 properties. (Bug#9284)
5078 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5080 * fontset.c (fontset_get_font_group): Add proper type checks.
5083 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5085 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5086 and LC_VERSION_MIN_MACOSX.
5087 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5088 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5090 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5092 * xdisp.c (forward_to_next_line_start): Allow to use the
5093 no-display-properties-and-no-overlays under bidi display.
5094 Set disp_pos in the bidi iterator to avoid searches for display
5095 properties and overlays.
5097 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5099 * editfns.c (Fset_time_zone_rule): Document relationship with the
5102 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5103 the font entity extracted from the cache (Bug#8109).
5105 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5107 * composite.c (autocmp_chars): Don't reset point. That is done by
5108 restore_point_unwind (Bug#5984).
5110 2011-08-07 Juri Linkov <juri@jurta.org>
5112 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5113 to show the arg `TIME' instead of `TIMEVAL'.
5115 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5117 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5118 display property strides EOL and includes a newline, as in
5119 longlines-mode. (Bug#9254)
5120 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5121 word-wrap under bidirectional display. (Bug#9224)
5123 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5124 is non-zero, even if the data buffer is NULL. Fixes a crash in
5125 vertical-motion with longlines-mode. (Bug#9254)
5127 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5129 * bidi.c <bidi_cache_total_alloc>: Now static.
5130 (bidi_initialize): Initialize bidi_cache_total_alloc.
5132 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5135 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5136 amount allocated this far in `bidi_cache_total_alloc'.
5137 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5138 non-zero, only free the data buffer without restoring the cache
5139 contents. All callers changed.
5141 * dispextern.h (bidi_unshelve_cache): Update prototype.
5143 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5144 (move_it_in_display_line, move_it_to)
5145 (move_it_vertically_backward, move_it_by_lines): Replace the call
5146 to xfree to an equivalent call to bidi_unshelve_cache.
5147 (move_it_in_display_line_to): Fix logic of returning
5148 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5150 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5152 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5153 came from a string character with a `cursor' property. (Bug#9229)
5155 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5157 * Makefile.in (LIB_PTHREAD): New variable.
5158 (LIBES): Add LIB_PTHREAD (Bug#9216).
5160 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5161 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5163 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5165 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5167 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5169 * xterm.c (x_find_topmost_parent): New function.
5170 (x_set_frame_alpha): Find topmost parent window with
5171 x_find_topmost_parent and set the property there also (bug#9181).
5172 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5174 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5176 * callproc.c (Fcall_process): Avoid vfork clobbering
5177 the local vars buffer, coding_systems, current_dir.
5179 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5181 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5183 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5185 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5186 so that it is not optimized away.
5188 * xdisp.c (compute_display_string_pos): Remove unused local.
5190 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5192 Fix slow cursor motion and scrolling in large buffers with
5193 selective display, like Org Mode buffers. (Bug#9218)
5195 * dispextern.h (struct bidi_it): New member disp_prop_p.
5197 * xdisp.c: Remove one-slot cache of display string positions.
5198 (compute_display_string_pos): Accept an additional argument
5199 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5200 for a display string or property. If found, set DISP_PROP_P
5203 * bidi.c (bidi_fetch_char): Accept an additional argument
5204 DISP_PROP_P, and pass it to compute_display_string_pos.
5205 Only handle text covered by a display string if DISP_PROP_P is returned
5206 non-zero. All callers of bidi_fetch_char changed.
5208 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5210 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5212 2010-12-03 Don March <don@ohspite.net>
5214 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5215 last character M-[char] is translated to ESC [char] (bug#7541).
5217 2011-08-02 Kenichi Handa <handa@m17n.org>
5219 * lisp.h (uniprop_table): Extern it.
5221 * chartab.c (uniprop_table): Make it non-static.
5223 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5225 * xdisp.c (forward_to_next_line_start): Accept additional argument
5226 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5228 (reseat_at_next_visible_line_start): Use the bidi iterator state
5229 returned by forward_to_next_line_start to restore the state of
5230 it->bidi_it after backing up to previous newline. (Bug#9212)
5232 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5234 * regex.c (re_comp): Protoize.
5235 (re_exec): Fix return type.
5236 (regexec): Fix type of `ret'. (Bug#9203)
5238 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5240 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5241 This is needed if max-image-size is a floating-point number.
5243 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5245 * print.c (print_object): Print empty symbol as ##.
5247 * lread.c (read1): Read ## as empty symbol.
5249 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5251 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5252 setting frame foreground color (Bug#9175).
5253 (x_set_background_color): Likewise.
5255 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5256 contents (Bug#9176).
5257 (EmacsTooltip -init): Remove bezels and add shadows to
5260 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5261 or scroll bar (Bug#8470).
5263 * nsfont.m (nsfont_open): Remove assignment to voffset and
5264 unnecessary vars hshink, expand, hd, full_height, min_height.
5265 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5267 * nsterm.h (nsfont_info): Remove voffset field.
5269 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5271 Implement strike-through and overline on NextStep (Bug#8863).
5273 * nsfont.m (nsfont_open): Use underline position provided by font,
5274 instead of hard-coded value of 2.
5275 (nsfont_draw): Call ns_draw_text_decoration instead.
5277 * nsterm.h: Add declaration for ns_draw_text_decoration.
5279 * nsterm.m (ns_draw_text_decoration): New function for drawing
5280 underline, overline, and strike-through.
5281 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5282 ns_draw_text_decoration. Change treatment of cursor drawing to
5283 accommodate underlining, etc.
5285 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5287 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5290 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5292 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5293 Without this fix, if a signal arrives just after memory fills up,
5294 'malloc' might be invoked reentrantly.
5296 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5297 In other words, assume that every image size is allowed, on non-X
5298 hosts. This assumption is probably wrong, but it lets Emacs compile.
5300 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5302 * regex.c (re_iswctype): Convert return values to boolean.
5304 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5306 * xdisp.c (compute_display_string_pos): Don't use cached display
5307 string position if the buffer had its restriction changed.
5310 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5312 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5314 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5316 Integer signedness and overflow and related fixes. (Bug#9079)
5318 * bidi.c: Integer size and overflow fixes.
5319 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5320 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5321 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5322 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5323 (bidi_find_other_level_edge):
5324 Use ptrdiff_t instead of EMACS_INT where either will do.
5325 This works better on 32-bit hosts configured --with-wide-int.
5326 (bidi_cache_ensure_space): Check for size-calculation overflow.
5327 Use % rather than repeated addition, for better worst-case speed.
5328 Don't set bidi_cache_size until after xrealloc returns, because it
5330 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5331 (bidi_cache_ensure_space): Also check that the bidi cache size
5332 does not exceed that of the largest Lisp string or buffer. See Eli
5333 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5335 * alloc.c (__malloc_size_t): Remove.
5336 All uses replaced by size_t. See Andreas Schwab's note
5337 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5339 * image.c: Improve checking for integer overflow.
5340 (check_image_size): Assume that f is nonnull, since
5341 it is always nonnull in practice. This is one less thing to
5342 worry about when checking for integer overflow later.
5343 (x_check_image_size): New function, which checks for integer
5344 overflow issues inside X.
5345 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5346 This removes the need for a memory_full check.
5347 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5348 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5349 (xbm_read_bitmap_data): Change locals back to 'int', since
5350 their values must fit in 'int'.
5351 (xpm_load_image, png_load, tiff_load):
5352 Invoke x_create_x_image_and_pixmap earlier,
5353 to avoid much needless work if the image is too large.
5354 (tiff_load): Treat overly large images as if
5355 x_create_x_image_and_pixmap failed, not as malloc failures.
5356 (gs_load): Use x_check_image_size.
5358 * gtkutil.c: Omit integer casts.
5359 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5360 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5362 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5364 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5365 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5366 would wrongly return t on a 64-bit host.
5368 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5369 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5370 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5371 and therefore cause GCC to emit a bogus diagnostic in some cases.
5373 * image.c: Integer signedness and overflow and related fixes.
5374 This is not an exhaustive set of fixes, but it's time to
5375 record what I've got.
5376 (lookup_pixel_color, check_image_size): Remove redundant decls.
5377 (check_image_size): Don't assume that arbitrary EMACS_INT values
5378 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5379 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5380 (tiff_load, imagemagick_load_image):
5381 Check for overflow in size calculations.
5382 (x_create_x_image_and_pixmap): Remove unnecessary test for
5383 xmalloc returning NULL; that can't happen.
5384 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5385 (xpm_color_bucket): Use better integer hashing function.
5386 (xpm_cache_color): Don't possibly over-allocate memory.
5387 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5388 (gif_memory_source):
5389 Use ptrdiff_t, not int or size_t, to record sizes.
5390 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5391 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5392 either works, as we prefer signed integers.
5393 (tiff_read_from_memory, tiff_write_from_memory):
5394 Return tsize_t, not size_t, since that's what the TIFF API wants.
5395 (tiff_read_from_memory): Don't fail simply because the read would
5396 go past EOF; instead, return a short read.
5397 (tiff_load): Omit no-longer-needed casts.
5398 (Fimagemagick_types): Don't assume size fits into 'int'.
5400 Improve hashing quality when configured --with-wide-int.
5401 * fns.c (hash_string): New function, taken from sxhash_string.
5402 Do not discard information about ASCII character case; this
5403 discarding is no longer needed.
5404 (sxhash-string): Use it. Change sig to match it. Caller changed.
5405 * lisp.h: Declare it.
5406 * lread.c (hash_string): Remove, since we now use fns.c's version.
5407 The fns.c version returns a wider integer if --with-wide-int is
5408 specified, so this should help the quality of the hashing a bit.
5410 * emacs.c: Integer overflow minor fix.
5411 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5412 Define only if GNU_LINUX.
5413 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5415 * dispnew.c: Integer signedness and overflow fixes.
5416 Remove unnecessary forward decls, that were a maintenance hassle.
5417 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5419 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5420 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5421 (prepare_desired_row, line_draw_cost):
5422 Use int, not unsigned, where either works.
5423 (save_current_matrix, restore_current_matrix):
5424 Use ptrdiff_t, not size_t, where either works.
5425 (init_display): Check for overflow more accurately, and without
5426 relying on undefined behavior.
5428 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5429 Remove, replacing with the new symbols in lisp.h. All uses changed.
5430 * fileio.c (make_temp_name):
5431 * filelock.c (lock_file_1, lock_file):
5432 * xdisp.c (message_dolog):
5433 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5434 Use pMd etc. instead.
5435 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5436 replacing the pWIDE etc. symbols removed from editfns.c.
5438 * keyboard.h (num_input_events): Now uintmax_t.
5439 This is (very slightly) less likely to mess up due to wraparound.
5442 * buffer.c: Integer signedness fixes.
5443 (alloc_buffer_text, enlarge_buffer_text):
5444 Use ptrdiff_t rather than size_t when either will do, as we prefer
5447 * alloc.c: Integer signedness and overflow fixes.
5448 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5449 (__malloc_size_t): Default to size_t, not to int.
5450 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5451 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5452 Prefer ptrdiff_t to size_t when either would do, as we prefer
5454 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5455 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5456 Now const. Initialize with values that are in range even if char
5458 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5459 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5460 These functions do the right thing with sizes > 2**32.
5461 (check_depth): Now ptrdiff_t, not int.
5462 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5463 Adjust to new way of storing sizes. Check for size overflow bugs
5465 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5466 slightly wrong anyway, as it missed one instance of
5467 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5468 (refill_memory_reserve): Omit needless cast to size_t.
5469 (mark_object_loop_halt): Mark as externally visible.
5471 * xselect.c: Integer signedness and overflow fixes.
5472 (Fx_register_dnd_atom, x_handle_dnd_message):
5473 Use ptrdiff_t, not size_t, since we prefer signed.
5474 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5475 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5476 x_dnd_atoms_size and x_dnd_atoms_length.
5478 * doprnt.c: Prefer signed to unsigned when either works.
5480 * doprnt.c (doprnt):
5482 * xdisp.c (vmessage):
5483 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5484 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5485 prefer signed arithmetic to avoid comparison confusion.
5486 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5487 but is a bit tricky.
5489 Assume freestanding C89 headers, string.h, stdlib.h.
5490 * data.c, doprnt.c, floatfns.c, print.c:
5491 Include float.h unconditionally.
5492 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5493 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5494 * regex.c: Likewise for stddef.h, string.h.
5495 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5496 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5497 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5498 (STDC_HEADERS): Remove obsolete defines.
5499 * sysdep.c: Include limits.h unconditionally.
5501 Assume support for memcmp, memcpy, memmove, memset.
5502 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5503 * regex.c (memcmp, memcpy):
5504 Remove; we assume C89 now.
5506 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5507 (__malloc_safe_bcopy): Remove; no longer needed.
5509 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5510 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5511 well either way, and we prefer signed to unsigned.
5513 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5515 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5516 closes the connection while we're reading (bug#9182).
5518 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5520 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5521 are specified (Bug#9168).
5523 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5525 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5526 Found by GCC static checking and --with-wide-int on a 32-bit host.
5528 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5530 * xdisp.c (compute_display_string_pos): Fix logic of caching
5531 previous display string position. Initialize cached_prev_pos to
5532 -1. Fixes slow-down at the beginning of a buffer.
5534 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5536 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5537 for attrs[LFACE_FONTSET_INDEX].
5539 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5541 * xml.c (parse_region): Remove unused local
5542 that was recently introduced.
5544 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5546 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5547 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5549 * xdisp.c (move_it_in_display_line_to): Record the best matching
5550 position for TO_CHARPOS while scanning the line, and restore it on
5551 exit if none of the characters scanned was an exact match.
5552 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5553 when exact match is impossible due to invisible text, and the
5554 lines are truncated.
5556 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5558 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5561 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5563 Fix a significant slow-down of cursor motion with C-n, C-p,
5564 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5565 auto-repeat under bidi redisplay in fontified buffers.
5566 * xdisp.c (compute_stop_pos_backwards): New function.
5567 (next_element_from_buffer): Call compute_stop_pos_backwards to
5568 find a suitable prev_stop when we find ourselves before
5570 (reseat): Don't look for prev_stop, as that could mean a very long
5572 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5573 <cached_disp_overlay_modiff>: Cache for last found display string
5575 (compute_display_string_pos): Return the cached position if asked
5576 about the same buffer in the same area of character positions, and
5577 the buffer wasn't changed since the time the display string
5578 position was cached.
5580 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5582 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5583 is an integer, which is important for empty lines. (Bug#9149)
5585 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5587 * frame.c (Fmodify_frame_parameters): In tty case, update the
5588 default face if necessary (Bug#4238).
5590 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5592 * editfns.c (Fstring_to_char): No need to explain what a character
5593 is in the docstring (Bug#6576).
5595 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5597 * xml.c (parse_region): Make sure we always return a tree.
5599 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5601 * xml.c (parse_region): If a document contains only comments,
5604 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5606 * xml.c (make_dom): Return comments, too.
5608 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5611 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5612 and the surrounding thread.
5613 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5614 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5615 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5617 * s/openbsd.h (BROKEN_SIGIO): Define.
5618 * unexelf.c (unexec) [__OpenBSD__]:
5619 Don't update the .mdebug section of the Alpha COFF symbol table.
5621 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5623 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5626 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5628 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5629 This fixes some race conditions on the permissions of any newly
5632 * alloc.c (valid_pointer_p): Use pipe, not open.
5633 This fixes some permissions issues when debugging.
5635 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5636 If fchown fails to set both uid and gid, try to set just gid,
5637 as that is sometimes allowed. Adjust the file's mode to eliminate
5638 setuid or setgid bits that are inappropriate if fchown fails.
5640 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5642 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5643 to compare Lisp_Objects.
5644 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5645 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5646 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5648 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5650 * lread.c (read_integer): Unread even EOF character.
5651 (read1): Likewise. Properly record start position of symbol.
5653 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5654 symbol character follows.
5656 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5658 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5659 This works around a problem with the previous change to Fcopy_file.
5660 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5661 and without this change, GCC might complain about discarding
5662 fchown's return value.
5664 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5666 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5668 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5670 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5672 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5674 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5675 it's used from the C level.
5677 * process.c: Use the same condition for POLL_FOR_INPUT in both
5678 keyboard.c and process.c (bug#1858).
5680 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5682 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5683 (Fgnutls_boot): Use it.
5685 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5687 * doc.c (Fsubstitute_command_keys): Revert last change.
5689 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5691 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5692 quotes the next character, and doesn't affect other longer
5693 sequences (bug#8935).
5695 * lread.c (syms_of_lread): Clarify that is isn't only
5696 `eval-buffer' and `eval-defun' that's affected by
5697 `lexical-binding' (bug#8460).
5699 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5701 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5702 bidi redisplay when a line includes both an image and is truncated.
5704 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5706 Fix minor problems found by static checking.
5707 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5708 (elsz): Now a signed constant, not a size_t var. We prefer signed
5709 types to unsigned, to avoid integer comparison confusion. Without
5710 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5711 "cannot optimize loop, the loop counter may overflow", a symptom
5713 * indent.c (Fvertical_motion): Mark locals as initialized.
5714 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5716 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5718 * search.c (Fre_search_backward): Mention `case-fold-search' in
5719 all the re_search_* functions (bug#8138).
5721 * keyboard.c (Fopen_dribble_file): Document when the file is
5724 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5726 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5729 Support bidi reordering of display and overlay strings.
5730 * xdisp.c (compute_display_string_pos)
5731 (compute_display_string_end): Accept additional argument STRING.
5732 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5733 (reseat_to_string): Initialize bidi_it->string.s and
5734 bidi_it->string.schars.
5735 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5736 NULL (avoids a crash in bidi_paragraph_init).
5737 Initialize itb.string.lstring.
5738 (init_iterator): Call bidi_init_it only of a valid
5739 buffer position was specified. Initialize paragraph_embedding to
5741 (reseat_to_string): Initialize the bidi iterator.
5742 (display_string): If we need to ignore text properties of
5743 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5744 original value of -1 will not work with bidi.)
5745 (compute_display_string_pos): First arg is now struct
5746 `text_pos *'; all callers changed. Support display properties on
5748 (compute_display_string_end): Support display properties on Lisp
5750 (init_iterator, reseat_1, reseat_to_string): Initialize the
5751 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5752 when iterating on a string not from display properties).
5753 (compute_display_string_pos, compute_display_string_end):
5754 Fix calculation of the object to scan. Fixes an error when using
5756 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5757 base_level_stop; instead, set base_level_stop to BEGV.
5758 Fixes crashes in vertical-motion.
5759 (next_element_from_buffer): Improve commentary for when
5760 the iterator is before prev_stop.
5761 (init_iterator): Initialize bidi_p from the default value of
5762 bidi-display-reordering, not from buffer-local value. Use the
5763 buffer-local value only if initializing for buffer iteration.
5764 (handle_invisible_prop): Support invisible properties on strings
5765 that are being bidi-reordered.
5766 (set_iterator_to_next): Support bidi reordering of C strings and
5768 (next_element_from_string): Support bidi reordering of Lisp
5770 (handle_stop_backwards): Support Lisp strings as well.
5771 (display_string): Support display of R2L glyph rows.
5772 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5773 (init_iterator): Don't initialize it->bidi_p for strings
5775 (reseat_to_string): Initialize it->bidi_p for strings here.
5776 (next_element_from_string, next_element_from_c_string)
5777 (next_element_from_buffer): Add xassert's for correspondence
5778 between IT's object being iterated and it->bidi_it.string
5780 (face_before_or_after_it_pos): Support bidi iteration.
5781 (next_element_from_c_string): Handle the case of the first string
5782 character that is not the first one in the visual order.
5783 (get_visually_first_element): New function, refactored from common
5784 parts of next_element_from_buffer, next_element_from_string, and
5785 next_element_from_c_string.
5786 (tool_bar_lines_needed, redisplay_tool_bar)
5787 (display_menu_bar): Force left-to-right direction. Add a FIXME
5788 comment for making that be controlled by a user option.
5789 (push_it, pop_it): Save and restore the state of the
5790 bidi iterator. Save and restore the bidi_p flag.
5791 (pop_it): Iterate out of display property for string iteration as
5793 (iterate_out_of_display_property): Support iteration over strings.
5794 (handle_single_display_spec): Set up it->bidi_it for iteration
5795 over a display string, and call bidi_init_it.
5796 (handle_single_display_spec, next_overlay_string)
5797 (get_overlay_strings_1, push_display_prop): Set up the bidi
5798 iterator for displaying display or overlay strings.
5799 (forward_to_next_line_start): Don't use the shortcut if
5801 (back_to_previous_visible_line_start): If handle_display_prop
5802 pushed the iterator stack, restore the internal state of the bidi
5803 iterator by calling bidi_pop_it same number of times.
5804 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5805 and we are bidi-iterating, don't decrement the iterator position;
5806 instead, set the first_elt flag in the bidi iterator, to produce
5808 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5809 (push_display_prop): xassert that we are iterating a buffer.
5810 (push_it, pop_it): Save and restore paragraph_embedding member.
5811 (handle_single_display_spec, next_overlay_string)
5812 (get_overlay_strings_1, reseat_1, reseat_to_string)
5813 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5814 correctly. Don't assume unibyte strings are not bidi-reordered.
5815 (compute_display_string_pos)
5816 (compute_display_string_end): Fix handling the case of C string.
5817 (push_it, pop_it): Save and restore from_disp_prop_p.
5818 (handle_single_display_spec, push_display_prop): Set the
5819 from_disp_prop_p flag.
5820 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5821 (pop_it): Call iterate_out_of_display_property only if we are
5822 popping after iteration over a string that came from a display
5823 property. Fix a typo in popping stretch info. Add an assertion
5824 for verifying that the iterator position is in sync with the bidi
5826 (handle_single_display_spec, get_overlay_strings_1)
5827 (push_display_prop): Fix initialization of paragraph direction for
5828 string when that of the parent object is not yet determined.
5829 (reseat_1): Call bidi_init_it to resync the bidi
5830 iterator with IT's position. (Bug#7616)
5831 (find_row_edges): If ROW->start.pos gives position
5832 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5833 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5834 Reset the from_disp_prop_p flag.
5835 (SAVE_IT, RESTORE_IT): New macros.
5836 (pos_visible_p, face_before_or_after_it_pos)
5837 (back_to_previous_visible_line_start)
5838 (move_it_in_display_line_to, move_it_in_display_line)
5839 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5840 (try_scrolling, redisplay_window, display_line): Use them when
5841 saving a temporary copy of the iterator and restoring it back.
5842 (back_to_previous_visible_line_start, reseat_1)
5843 (init_iterator): Empty the bidi cache "stack".
5844 (move_it_in_display_line_to): If iterator ended up at
5845 EOL, but we never saw any buffer positions smaller than
5846 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5847 motion in bidi-reordered lines.
5848 (move_it_in_display_line_to): Record prev_method and prev_pos
5849 immediately before the call to set_iterator_to_next. Fixes cursor
5850 motion in bidi-reordered lines with stretch glyphs and strings
5851 displayed in margins. (Bug#8133) (Bug#8867)
5852 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5854 (pos_visible_p): Support positions in bidi-reordered lines.
5855 Save and restore bidi cache.
5857 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5858 (bidi_paragraph_info): Delete unused struct.
5859 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5860 (bidi_cache_start): New variable.
5861 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5863 (bidi_cache_fetch_state, bidi_cache_search)
5864 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5865 (bidi_cache_find, bidi_peek_at_next_level)
5866 (bidi_level_of_next_char, bidi_find_other_level_edge)
5867 (bidi_move_to_visually_next): Compare cache index with
5868 bidi_cache_start rather than with zero.
5869 (bidi_fetch_char): Accept new argument STRING; all callers
5870 changed. Support iteration over a string. Support strings with
5871 display properties. Support unibyte strings. Fix the type of
5872 `len' according to what STRING_CHAR_AND_LENGTH expects.
5873 (bidi_paragraph_init, bidi_resolve_explicit_1)
5874 (bidi_resolve_explicit, bidi_resolve_weak)
5875 (bidi_level_of_next_char, bidi_move_to_visually_next):
5876 Support iteration over a string.
5877 (bidi_set_sor_type, bidi_resolve_explicit_1)
5878 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5879 can now be zero (for strings); special values 0 and -1 were
5880 changed to -1 and -2, respectively.
5881 (bidi_char_at_pos): New function.
5882 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5883 Call it instead of FETCH_MULTIBYTE_CHAR.
5884 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5885 initialized to valid values.
5886 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5888 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5889 the test for valid cached positions. Fix the logic for looking up
5890 the sentinel state in the cache. GCPRO the Lisp string we are
5892 (bidi_push_it, bidi_pop_it): New functions.
5893 (bidi_initialize): Initialize the bidi cache start stack pointer.
5894 (bidi_cache_ensure_space): New function, refactored from part of
5895 bidi_cache_iterator_state. Don't assume the required size is just
5896 one BIDI_CACHE_CHUNK away.
5897 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5898 (bidi_count_bytes, bidi_char_at_pos): New functions.
5899 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5900 always valid if bidi_cache_idx is valid.
5901 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5902 is valid if it's going to be used.
5903 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5904 (bidi_cache_fetch_state, bidi_cache_search)
5905 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5906 (bidi_cache_iterator_state, bidi_cache_find)
5907 (bidi_find_other_level_edge, bidi_cache_start_stack):
5908 All variables related to cache indices are now EMACS_INT.
5910 * dispextern.h (struct bidi_string_data): New structure.
5911 (struct bidi_it): New member `string'. Make flag members be 1-bit
5912 fields, and put them last in the struct.
5913 (compute_display_string_pos, compute_display_string_end):
5915 (bidi_push_it, bidi_pop_it): Add prototypes.
5916 (struct iterator_stack_entry): New members bidi_p,
5917 paragraph_embedding, and from_disp_prop_p.
5918 (struct it): Member bidi_p is now a bit field 1 bit wide.
5919 (bidi_shelve_cache, bidi_unshelve_cache):
5922 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5923 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5924 and vector-like objects.
5926 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5927 cache around display iteration.
5929 * window.c (Fwindow_end, window_scroll_pixel_based)
5930 (displayed_window_lines, Frecenter): Save and restore the bidi
5931 cache around display iteration.
5933 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5935 * editfns.c (Fdelete_region): Clarify the use of the named
5936 parameters (bug#6788).
5938 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5940 * indent.c (Fvertical_motion): Set and restore w->pointm when
5941 saving and restoring the window's buffer (Bug#9006).
5943 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5945 * editfns.c (Fstring_to_char): Clarify just what is returned
5946 (bug#6576). Text by Eli Zaretskii.
5948 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5950 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5952 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5954 * buffer.c (mmap_find): Fix a typo.
5956 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5958 Fix execution of x selection hooks.
5959 * xselect.c (Qx_lost_selection_functions)
5960 (Qx_sent_selection_functions): New vars.
5961 (syms_of_xselect): DEFSYM them.
5962 (x_handle_selection_request): Pass Qx_sent_selection_functions
5963 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5964 (x_handle_selection_clear,x_clear_frame_selections):
5965 Pass Qx_lost_selection_functions rather than
5966 Vx_lost_selection_functions to Frun_hook_with_args.
5968 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5970 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5971 The old code sometimes used this field without initializing it.
5973 * alloc.c (gc_sweep): Don't read past end of array.
5974 In theory, the old code could also have corrupted Emacs internals,
5975 though it'd be very unlikely.
5977 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5979 * character.c (Fcharacterp): Don't advertise optional ignored
5980 argument. (Bug#4026)
5982 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5984 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5987 * window.c (Fset_window_start): Doc fix (bug#4199).
5988 (Fset_window_hscroll): Ditto.
5990 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5992 Fix minor new problems caught by GCC 4.6.1.
5993 * term.c (init_tty): Remove unused local.
5994 * xsettings.c (store_monospaced_changed): Define this function only
5995 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5998 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6000 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6002 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6004 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6005 are the mini-buffer and the echo area (bug#3320).
6007 * term.c (init_tty): Remove support for supdup, c10 and perq
6008 terminals, which are no longer supported (bug#1482).
6010 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6012 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6014 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6016 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6017 for non-popups (Bug#3642).
6019 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6021 * alloc.c (reset_malloc_hooks): Protoize.
6022 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6023 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6024 * cm.c (losecursor): Likewise.
6025 * data.c (fmod): Likewise.
6026 * dispnew.c (swap_glyphs_in_rows): Likewise.
6027 * emacs.c (memory_warning_signal): Likewise.
6028 * floatfns.c (float_error): Likewise.
6029 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6030 (otf_open, font_otf_capability, generate_otf_features)
6031 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6033 * image.c (pbm_read_file): Likewise.
6034 * indent.c (string_display_width): Likewise.
6035 * intervals.c (check_for_interval, search_for_interval)
6036 (inc_interval_count, count_intervals, root_interval)
6037 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6038 * lread.c (defalias): Likewise.
6039 * ralloc.c (r_alloc_check): Likewise.
6040 * regex.c (set_image_of_range_1, set_image_of_range)
6041 (regex_grow_registers): Likewise.
6042 * sysdep.c (strerror): Likewise.
6043 * termcap.c (valid_filename_p, tprint, main): Likewise.
6044 * tparam.c (main): Likewise.
6045 * unexhp9k800.c (run_time_remap, save_data_space)
6046 (update_file_ptrs, read_header, write_header, calculate_checksum)
6047 (copy_file, copy_rest, display_header): Likewise.
6048 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6050 * xdisp.c (check_it): Likewise.
6051 * xfaces.c (register_color, unregister_color, unregister_colors):
6053 * xfns.c (print_fontset_result): Likewise.
6054 * xrdb.c (member, fatal, main): Likewise.
6056 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6058 Fix minor problems found by static checking (Bug#9031).
6059 * chartab.c (char_table_set_range, map_sub_char_table):
6060 Remove unused locals.
6061 (uniprop_table): Now static.
6062 * composite.c (_work_char): Remove unused static var.
6064 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6066 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6068 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6070 * gtkutil.c (qttip_cb): Remove code without function.
6072 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6074 * w32.c (pthread_sigmask): New stub.
6076 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6078 Use pthread_sigmask, not sigprocmask (Bug#9010).
6079 sigprocmask is portable only for single-threaded applications, and
6080 Emacs can be multi-threaded when it uses GTK.
6081 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6083 * callproc.c (Fcall_process):
6084 * process.c (create_process):
6085 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6086 Use pthread_sigmask, not sigprocmask.
6088 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6090 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6091 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6094 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6096 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6097 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6098 (xg_hide_tooltip): Fix comment.
6100 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6101 in registerServicesMenuSendTypes.
6102 (validRequestorForSendType): Don't check ns_return_types.
6104 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6107 2011-07-08 Jason Rumney <jasonr@gnu.org>
6109 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6110 SH_SHOW for hidden windows (Bug#5482).
6112 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6113 frame struct members of non-existent frames (Bug#6284).
6115 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6117 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6118 variable firstTime not needed on OSX >= 10.6.
6119 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6120 >= 10.5. Use setKnobProportion, setDoubleValue.
6122 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6123 (MAC_OS_X_VERSION_10_5): Define if not defined.
6124 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6125 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6126 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6128 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6129 cString and lossyCString on OSX >= 10.4
6131 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6132 sizeToFit on OSX >= 10.2.
6134 * nsimage.m (allocInitFromFile): Don't use deprecated method
6135 bestRepresentationForDevice on OSX >= 10.6.
6137 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6140 * emacs.c: Declare unexec_init_emacs_zone.
6142 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6144 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6146 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6147 on svcsMenu (Bug#8842).
6149 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6151 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6153 * nsterm.m (QUTF8_STRING): Declare.
6154 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6155 (validRequestorForSendType): Return type is (id).
6156 Change indexOfObjectIdenticalTo to indexOfObject.
6157 Check if we have local selection before returning self (Bug#8842).
6158 (writeSelectionToPasteboard): Put local selection into paste board
6159 if we have a local selection (Bug#8842).
6160 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6162 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6163 (ns_get_local_selection): Declare.
6165 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6167 * keymap.c (describe_map_tree): Don't insert a double newline at
6168 the end of the buffer (bug#1169) and return whether we inserted
6171 * callint.c (Fcall_interactively): Change "reading args" to
6172 "providing args" to try to clarify what it does (bug#1010).
6174 2011-07-07 Kenichi Handa <handa@m17n.org>
6176 * composite.c (composition_compute_stop_pos): Ignore a static
6177 composition starting before CHARPOS (Bug#8915).
6179 * xdisp.c (handle_composition_prop): Likewise.
6181 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6183 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6186 2011-07-07 Kenichi Handa <handa@m17n.org>
6188 * character.h (unicode_category_t): New enum type.
6190 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6191 (Qchar_code_property_table): New variable.
6192 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6193 (UNIPROP_COMPRESSED_FORM_P): New macros.
6194 (char_table_ascii): Uncompress the compressed values.
6195 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6196 Uncompress the compressed values.
6197 (sub_char_table_ref_and_range): Likewise.
6198 (char_table_ref_and_range): Uncompress the compressed values.
6199 (sub_char_table_set): New arg is_uniprop. Callers changed.
6200 Uncompress the compressed values.
6201 (sub_char_table_set_range): Args changed. Callers changed.
6202 (char_table_set_range): Adjuted for the above change.
6203 (map_sub_char_table): Delete args default_val and parent. Add arg
6204 top. Give decoded values to a Lisp function.
6205 (map_char_table): Adjust for the above change. Give decoded
6206 values to a Lisp function. Gcpro more variables.
6207 (uniprop_table_uncompress)
6208 (uniprop_decode_value_run_length): New functions.
6209 (uniprop_decoder, uniprop_decoder_count): New variables.
6210 (uniprop_get_decoder, uniprop_encode_value_character)
6211 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6213 (uniprop_encoder, uniprop_encoder_count): New variables.
6214 (uniprop_get_encoder, uniprop_table)
6215 (Funicode_property_table_internal, Fget_unicode_property_internal)
6216 (Fput_unicode_property_internal): New functions.
6217 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6218 Sunicode_property_table_internal, Sget_unicode_property_internal,
6219 and Sput_unicode_property_internal. Defvar_lisp
6220 char-code-property-alist.
6222 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6223 Vunicode_category_table.
6225 * font.c (font_range): Adjust for the change of
6226 Vunicode_category_table.
6228 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6230 * m/iris4d.h: Remove file, move contents ...
6231 * s/irix6-5.h: ... here.
6233 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6235 Remove unportable assumption about struct layout (Bug#8884).
6236 * alloc.c (mark_buffer):
6237 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6238 (clone_per_buffer_values): Don't assume that
6239 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6240 This isn't true in general, and it's particularly not true
6241 if Emacs is configured with --with-wide-int.
6242 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6243 New macros, used in the buffer.c change.
6245 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6247 * xsettings.c: Use both GConf and GSettings if both are available.
6248 (store_config_changed_event): Add comment.
6249 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6250 (store_tool_bar_style_changed): New functions.
6251 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6252 (struct xsettings): Move font inside HAVE_XFT.
6253 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6254 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6255 Move inside HAVE_XFT.
6256 (something_changed_gsettingsCB): Rename from something_changedCB.
6257 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6259 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6260 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6261 (something_changed_gconfCB): Rename from something_changedCB.
6262 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6263 (parse_settings): Move check for font inside HAVE_XFT.
6264 (read_settings, apply_xft_settings): Add comment.
6265 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6266 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6267 call store_font_name_changed.
6268 (xft_settings_event): Add comment.
6269 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6270 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6271 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6272 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6273 (xsettings_initialize): Call init_gsettings last.
6274 (xsettings_get_system_font, xsettings_get_system_normal_font):
6277 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6279 Random fixes. E.g., (random) never returned negative values.
6280 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6281 subseconds part to the entropy, as that's a bit more random.
6282 Prefer signed to unsigned, since the signedness doesn't matter and
6283 in general we prefer signed. When given a limit, use a
6284 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6285 latter isn't right if USE_2_TAGS_FOR_INTS.
6286 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6287 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6289 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6291 * textprop.c (text_property_stickiness):
6292 Obey Vtext_property_default_nonsticky.
6293 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6294 * w32fns.c (syms_of_w32fns):
6295 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6297 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6299 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6300 This is more efficient than Ffile_directory_p and avoids a minor race.
6302 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6304 * buffer.c (Foverlay_put): Say what the return value is
6307 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6308 is a directory before asking whether to use the file name
6310 (barf_or_query_if_file_exists): Make the "File is a directory"
6311 error be more correct.
6313 * fns.c (Frequire): Remove the mention of the .gz files, since
6314 that's installation-specific, but keep the mention of
6315 `get-load-suffixes'.
6317 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6319 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6320 Report string overflow if the output is too long.
6322 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6324 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6325 (syms_of_gnutls): Remove duplicate DEFSYM for
6326 Qgnutls_bootprop_verify_hostname_error, an error for
6327 Qgnutls_bootprop_verify_error (which is no longer used).
6329 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6330 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6331 Also (re)move comments that are misplaced or no longer relevant.
6333 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6335 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6337 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6339 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6340 and background color parameters if they have been changed.
6342 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6344 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6346 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6348 * xsettings.c (SYSTEM_FONT): Define only when used.
6349 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6351 * keymap.c (access_keymap_1): Now static.
6353 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6355 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6356 leave any prefix arg for the up event (Bug#1586).
6358 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6360 * lread.c (syms_of_lread): Mention single symbols defined by
6361 `defvar' or `defconst' (bug#7154).
6363 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6364 (Frequire): Mention get-load-suffixes.
6366 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6368 * window.h (window): Remove clone_number slot.
6369 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6371 (make_parent_window, make_window, saved_window)
6372 (Fset_window_configuration, save_window_save): Don't deal with
6374 * buffer.c (Qclone_number): Remove declaration.
6375 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6377 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6379 Add multiple inheritance to keymaps.
6380 * keymap.c (Fmake_composed_keymap): New function.
6381 (Fset_keymap_parent): Simplify.
6382 (fix_submap_inheritance): Remove.
6383 (access_keymap_1): New function extracted from access_keymap to handle
6384 embedded parents and handle lists of maps.
6385 (access_keymap): Use it.
6386 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6387 (Fcopy_keymap): Handle embedded parents.
6388 (Fcommand_remapping, define_as_prefix): Simplify.
6389 (Fkey_binding): Simplify.
6390 (syms_of_keymap): Move minibuffer-local-completion-map,
6391 minibuffer-local-filename-completion-map,
6392 minibuffer-local-must-match-map, and
6393 minibuffer-local-filename-must-match-map to Elisp.
6394 (syms_of_keymap): Defsubr make-composed-keymap.
6395 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6396 (parse_menu_item): Trivial simplification.
6398 2011-07-01 Glenn Morris <rgm@gnu.org>
6400 * Makefile.in (SETTINGS_LIBS): Fix typo.
6402 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6404 * coding.c (Fencode_coding_string): Record the last coding system
6405 used, as the function doc string says (bug#8738).
6407 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6409 * xsettings.c (store_monospaced_changed): Take new font as arg and
6410 check for change against current_mono_font.
6411 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6412 (emacs_settings_constructor, emacs_settings_get_property)
6413 (emacs_settings_set_property, emacs_settings_class_init)
6414 (emacs_settings_init, gsettings_obj): Remove.
6415 (something_changedCB): New function for HAVE_GSETTINGS.
6416 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6417 with value as argument.
6418 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6419 g_settings_new (Bug#8967). Do not create gsettings_obj.
6420 Remove calls to g_settings_bind. Connect something_changedCB to
6423 * xgselect.c: Add defined (HAVE_GSETTINGS).
6424 (xgselect_initialize): Ditto.
6426 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6427 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6430 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6432 * eval.c (struct backtrace): Simplify and port the data structure.
6433 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6434 signed bit field, as this assumption is not portable and it makes
6435 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6436 "char debug_on_exit : 1" as this is not portable either; instead,
6437 use the portable "unsigned int debug_on_exit : 1". Remove unused
6438 member evalargs. Remove obsolete comments about cc bombing out.
6440 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6442 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6443 Let HAVE_GSETTINGS override HAVE_GCONF.
6444 (store_monospaced_changed): New function.
6445 (EMACS_SETTINGS): A new type derived from GObject to handle
6446 GSettings notifications.
6447 (emacs_settings_constructor, emacs_settings_get_property)
6448 (emacs_settings_set_property, emacs_settings_class_init):
6450 (gsettings_client, gsettings_obj): New variables.
6451 (GSETTINGS_SCHEMA): New define.
6452 (something_changedCB): Call store_monospaced_changed.
6453 (init_gsettings): New function.
6454 (xsettings_initialize): Call init_gsettings.
6455 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6458 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6461 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6463 * window.c (resize_root_window, grow_mini_window)
6464 (shrink_mini_window): Rename Qresize_root_window to
6465 Qwindow_resize_root_window and Qresize_root_window_vertically to
6466 Qwindow_resize_root_window_vertically.
6468 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6470 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6472 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6474 * makefile.w32-in: Redesign dependencies so they reflect more
6475 clearly which files are directly included by each source file,
6476 and not through other includes.
6478 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6480 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6481 (sort_overlays, overlay_strings): When an overlay's clone number
6482 matches the window's clone number process the overlay even if
6483 the overlay's window property doesn't match the current window.
6485 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6486 (Fwindow_hchild): Rename to Fwindow_left_child.
6487 (Fwindow_next): Rename to Fwindow_next_sibling.
6488 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6489 (resize_window_check): Rename to window_resize_check.
6490 (resize_window_apply): Rename to window_resize_apply.
6491 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6492 (Fdelete_other_windows_internal, resize_frame_windows)
6493 (Fsplit_window_internal, Fdelete_window_internal)
6494 (grow_mini_window, shrink_mini_window)
6495 (Fresize_mini_window_internal): Fix callers accordingly.
6497 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6499 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6500 (emacs_fixed_set_min_size): Remove.
6501 (emacs_fixed_new): Take frame as argument.
6503 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6504 (_EmacsFixedPrivate): Remove minwidth/height.
6505 Add struct frame *f.
6506 (emacs_fixed_init): Initialize priv->f.
6507 (get_parent_class, emacs_fixed_set_min_size): Remove.
6508 (emacs_fixed_new): Set priv->f to argument.
6509 (emacs_fixed_get_preferred_width)
6510 (emacs_fixed_get_preferred_height): Use min_width/height from
6511 frames size_hint to set minimum and natural (Bug#8919).
6512 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6513 and use min_width/height from frames size_hint to set
6514 min_width/height (Bug#8919).
6516 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6517 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6520 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6522 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6523 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6526 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6528 * process.c (wait_reading_process_output): Bypass select if
6529 waiting for a cell while ignoring keyboard input, and input is
6530 pending. Suggested by Jan Djärv (Bug#8869).
6532 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6534 Use gnulib's dup2 module instead of rolling our own.
6535 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6537 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6539 * dispnew.c (scrolling_window): Before scrolling, turn off a
6540 mouse-highlight in the window being scrolled.
6542 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6544 Move DEFSYM to lisp.h and use everywhere.
6546 * character.h (DEFSYM): Move declaration...
6547 * lisp.h (DEFSYM): ...here.
6553 * w32select.c: Don't include character.h.
6555 * alloc.c (syms_of_alloc):
6556 * buffer.c (syms_of_buffer):
6557 * bytecode.c (syms_of_bytecode):
6558 * callint.c (syms_of_callint):
6559 * casefiddle.c (syms_of_casefiddle):
6560 * casetab.c (init_casetab_once):
6561 * category.c (init_category_once, syms_of_category):
6562 * ccl.c (syms_of_ccl):
6563 * cmds.c (syms_of_cmds):
6564 * composite.c (syms_of_composite):
6565 * dbusbind.c (syms_of_dbusbind):
6566 * dired.c (syms_of_dired):
6567 * dispnew.c (syms_of_display):
6568 * doc.c (syms_of_doc):
6569 * editfns.c (syms_of_editfns):
6570 * emacs.c (syms_of_emacs):
6571 * eval.c (syms_of_eval):
6572 * fileio.c (syms_of_fileio):
6573 * fns.c (syms_of_fns):
6574 * frame.c (syms_of_frame):
6575 * fringe.c (syms_of_fringe):
6576 * insdel.c (syms_of_insdel):
6577 * keymap.c (syms_of_keymap):
6578 * lread.c (init_obarray, syms_of_lread):
6579 * macros.c (syms_of_macros):
6580 * msdos.c (syms_of_msdos):
6581 * print.c (syms_of_print):
6582 * process.c (syms_of_process):
6583 * search.c (syms_of_search):
6584 * sound.c (syms_of_sound):
6585 * syntax.c (init_syntax_once, syms_of_syntax):
6586 * terminal.c (syms_of_terminal):
6587 * textprop.c (syms_of_textprop):
6588 * undo.c (syms_of_undo):
6589 * w32.c (globals_of_w32):
6590 * window.c (syms_of_window):
6591 * xdisp.c (syms_of_xdisp):
6592 * xfaces.c (syms_of_xfaces):
6593 * xfns.c (syms_of_xfns):
6594 * xmenu.c (syms_of_xmenu):
6595 * xsettings.c (syms_of_xsettings):
6596 * xterm.c (syms_of_xterm): Use DEFSYM.
6598 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6600 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6602 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6604 Integer and buffer overflow fixes (Bug#8873).
6606 * print.c (printchar, strout): Check for string overflow.
6607 (PRINTPREPARE, printchar, strout):
6608 Don't set size unless allocation succeeds.
6610 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6611 for sizes. Check for string overflow more accurately.
6612 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6614 * macros.c: Integer and buffer overflow fixes.
6615 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6616 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6617 Use ptrdiff_t, not int, for sizes.
6618 Don't increment bufsize until after realloc succeeds.
6619 Check for size-calculation overflow.
6620 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6622 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6624 * lread.c: Integer overflow fixes.
6625 (read_integer): Radix is now EMACS_INT, not int,
6626 to improve quality of diagnostics for out-of-range radices.
6627 Calculate buffer size correctly for out-of-range radices.
6628 (read1): Check for integer overflow in radices, and in
6629 read-circle numbers.
6630 (read_escape): Avoid int overflow.
6631 (Fload, openp, read_buffer_size, read1)
6632 (substitute_object_recurse, read_vector, read_list, map_obarray):
6633 Use ptrdiff_t, not int, for sizes.
6634 (read1): Use EMACS_INT, not int, for sizes.
6635 Check for size overflow.
6637 * image.c (cache_image): Check for size arithmetic overflow.
6639 * lread.c: Integer overflow issues.
6640 (saved_doc_string_size, saved_doc_string_length)
6641 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6642 Now ptrdiff_t, not int.
6643 (read1): Don't assume doc string length fits in int. Check for
6644 out-of-range doc string lengths.
6645 (read_list): Don't assume file position fits in int.
6646 (read_escape): Check for hex character overflow.
6648 2011-06-22 Leo Liu <sdl.web@gmail.com>
6650 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6651 Move to minibuffer.el.
6653 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6655 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6656 The following patches are for when GLYPH_DEBUG && !XASSERT.
6657 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6658 * dispnew.c (flush_stdout):
6659 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6660 Mark as externally visible.
6661 * dispnew.c (check_window_matrix_pointers): Now static.
6662 * dispnew.c (window_to_frame_vpos):
6663 * xfns.c (unwind_create_frame):
6664 * xterm.c (x_check_font): Remove unused local.
6665 * scroll.c (CHECK_BOUNDS):
6666 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6667 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6668 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6669 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6670 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6672 (debug_method_add): Use va_list and vsprintf rather than relying
6673 on undefined behavior with wrong number of arguments.
6674 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6675 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6676 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6677 since we're not interested in debugging glyphs with old libraries.
6678 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6679 GCC 4.6.0's static checking.
6681 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6683 Integer overflow and signedness fixes (Bug#8873).
6684 A few related buffer overrun fixes, too.
6686 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6688 * dispextern.h (struct face.stipple):
6689 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6690 (x_bitmap_mask, x_allocate_bitmap_record)
6691 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6692 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6693 (x_create_bitmap_from_xpm_data):
6694 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6695 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6697 * xfaces.c (load_pixmap):
6698 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6699 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6700 (.bitmaps_last, struct x_output.icon_bitmap):
6701 Use ptrdiff_t, not int, for bitmap indexes.
6702 (x_allocate_bitmap_record): Check for size overflow.
6703 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6705 Use ptrdiff_t, not int, for overlay counts.
6706 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6707 * editfns.c (overlays_around, get_pos_property):
6708 * textprop.c (get_char_property_and_overlay):
6709 * xdisp.c (next_overlay_change, note_mouse_highlight):
6710 * xfaces.c (face_at_buffer_position):
6711 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6712 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6713 (Fnext_overlay_change, Fprevious_overlay_change)
6714 (mouse_face_overlay_overlaps, Foverlays_in):
6715 Use ptrdiff_t, not int, for sizes.
6716 (overlays_at, overlays_in): Check for size-calculation overflow.
6718 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6720 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6721 (x_session_initialize): Do not assume string length fits in int.
6723 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6724 This is unlikely, but can occur if DPI is outlandish.
6726 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6727 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6729 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6730 * xrdb.c (magic_file_p, search_magic_path):
6731 Omit last arg SUFFIX; it was always 0. All callers changed.
6732 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6734 * xfont.c (xfont_match): Avoid need for strlen.
6736 * xfns.c: Don't assume strlen fits in int.
6737 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6739 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6740 not unsigned long, as we prefer signed integers. All callers changed.
6741 Detect integer overflow in repeat count.
6742 (message_dolog): Don't assume print length fits in 39 bytes.
6743 (display_mode_element): Don't assume strlen fits in int.
6745 * termcap.c: Don't assume sizes fit in int and never overflow.
6746 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6747 (gobble_line): Check for size-calculation overflow.
6749 * minibuf.c (Fread_buffer):
6750 * lread.c (intern, intern_c_string):
6751 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6752 Don't assume string length fits in int.
6754 * keyboard.c (parse_tool_bar_item):
6755 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6757 * font.c: Don't assume string length fits in int.
6758 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6759 Use ptrdiff_t, not int.
6760 (font_intern_prop): Don't assume string length fits in int.
6761 Don't assume integer property fits in fixnum.
6762 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6764 * filelock.c: Fix some buffer overrun and integer overflow issues.
6765 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6766 Reformulate so as not to need the command string.
6767 Invoke gzip -cd rather than gunzip, as it's more portable.
6768 (lock_info_type, lock_file_1, lock_file):
6769 Don't assume pid_t and time_t fit in unsigned long.
6770 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6771 (current_lock_owner): Prefer signed type for sizes.
6772 Use memcpy, not strncpy, where memcpy is what is really wanted.
6773 Don't assume (via atoi) that time_t and pid_t fit in int.
6774 Check for time_t and/or pid_t out of range, e.g., via a network share.
6775 Don't alloca where an auto var works fine.
6777 * fileio.c: Fix some integer overflow issues.
6778 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6779 Don't assume string length fits in int.
6780 (directory_file_name): Don't assume string length fits in long.
6781 (make_temp_name): Don't assume pid fits in int, or that its print
6782 length is less than 20.
6784 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6786 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6788 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6790 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6791 We prefer signed integers, even for size calculations.
6793 * emacs.c: Don't assume string length fits in 'int'.
6794 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6795 (main): Don't invoke strlen when not needed.
6797 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6798 (XD_DEBUG_MESSAGE): Don't waste a byte.
6800 * callproc.c (getenv_internal_1, getenv_internal)
6802 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6804 * lread.c (invalid_syntax): Omit length argument.
6805 All uses changed. This doesn't fix a bug, but it simplifies the
6806 code away from its former Hollerith-constant appearance, and it's
6807 one less 'int' to worry about when looking at integer-overflow issues.
6808 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6810 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6811 This didn't break anything, but it didn't help either.
6812 It's confusing to put a bogus integer in a place where the actual
6813 value does not matter.
6814 (LIST_END_P): Remove unused macro and its bogus comment.
6815 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6817 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6818 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6820 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6821 We prefer signed types, and the value cannot exceed the EMACS_INT
6822 range anyway (because otherwise the length would not be representable).
6823 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6824 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6825 This avoids a GCC warning when WIDE_EMACS_INT.
6827 * indent.c (sane_tab_width): New function.
6828 (current_column, scan_for_column, Findent_to, position_indentation)
6829 (compute_motion): Use it. This is just for clarity.
6830 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6832 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6834 * lisp.h (lint_assume): New macro.
6835 * composite.c (composition_gstring_put_cache):
6836 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6838 * editfns.c, insdel.c:
6839 Omit unnecessary forward decls, to simplify future changes.
6841 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6843 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6845 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6846 Use much-faster test for byte-length change.
6847 Don't assume string byte-length fits in 'int'.
6848 Check that character arg fits in 'int'.
6849 (mapcar1): Declare byte as byte, for clarity.
6851 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6853 * fns.c (concat): Catch string overflow earlier.
6854 Do not rely on integer wraparound.
6856 * dispextern.h (struct it.overlay_strings_charpos)
6857 (struct it.selective): Now EMACS_INT, not int.
6858 * xdisp.c (forward_to_next_line_start)
6859 (back_to_previous_visible_line_start)
6860 (reseat_at_next_visible_line_start, next_element_from_buffer):
6861 Don't arbitrarily truncate the value of 'selective' to int.
6863 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6865 * composite.c: Don't truncate sizes to 'int'.
6866 (composition_gstring_p, composition_reseat_it)
6867 (composition_adjust_point): Use EMACS_INT, not int.
6868 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6869 not EMACS_UINT, for indexes.
6871 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6873 * buffer.c: Include <verify.h>.
6874 (struct sortvec.priority, struct sortstr.priority):
6875 Now EMACS_INT, not int.
6876 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6877 (struct sortstr.size, record_overlay_string)
6878 (struct sortstrlist.size, struct sortlist.used):
6879 Don't truncate size to int.
6880 (record_overlay_string): Check for size-calculation overflow.
6881 (init_buffer_once): Check at compile-time, not run-time.
6883 2011-06-22 Jim Meyering <meyering@redhat.com>
6885 Don't leak an XBM-image-sized buffer
6886 * image.c (xbm_load): Free the image buffer after using it.
6888 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6891 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6892 that Sun C diagnosed.
6893 * fns.c (secure_hash): Fix pointer signedness issue.
6894 * intervals.c (static_offset_intervals): New function.
6895 (offset_intervals): Use it.
6897 2011-06-21 Leo Liu <sdl.web@gmail.com>
6900 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6903 * fns.c (secure_hash): Rename from crypto_hash_function and change
6904 the first arg to accept symbols.
6905 (Fsecure_hash): New primitive.
6906 (syms_of_fns): New symbols.
6908 2011-06-20 Deniz Dogan <deniz@dogan.se>
6910 * process.c (Fset_process_buffer): Clarify return value in
6913 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6915 * dispnew.c (add_window_display_history): Use BVAR.
6917 * xdisp.c (debug_method_add): Use BVAR.
6918 (check_window_end, dump_glyph_matrix, dump_glyph)
6919 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6921 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6924 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6925 check till after the cache is created in init_frame_faces.
6927 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6929 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6931 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6933 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6934 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6935 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6937 Improve buffer-overflow checking (Bug#8873).
6938 * fileio.c (Finsert_file_contents):
6939 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6940 Remove the old (too-loose) buffer overflow checks.
6941 They weren't needed, since make_gap checks for buffer overflow.
6942 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6943 The old code merely checked for Emacs fixnum overflow, and relied
6944 on undefined (wraparound) behavior. The new code avoids undefined
6945 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6947 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6948 Tune. Don't use wider integers than needed. Don't use alloca.
6949 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6951 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6953 * insdel.c, lisp.h (buffer_overflow): New function.
6954 (insert_from_buffer_1, replace_range, replace_range_2):
6955 * insdel.c (make_gap_larger):
6956 * editfns.c (Finsert_char):
6957 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6959 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6961 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6963 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6965 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6966 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6968 * fileio.c: Don't assume EMACS_INT fits in off_t.
6969 (emacs_lseek): New static function.
6970 (Finsert_file_contents, Fwrite_region): Use it.
6971 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6973 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6975 * fns.c: Don't overflow int when computing a list length.
6976 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6977 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6978 truncation on 64-bit hosts. Check for QUIT every
6979 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6980 faster and is responsive enough.
6981 (Flength): Report an error instead of overflowing an integer.
6982 (Fsafe_length): Return a float if the value is not representable
6983 as a fixnum. This shouldn't happen except in contrived situations.
6984 (Fnthcdr, Fsort): Don't assume list length fits in int.
6985 (Fcopy_sequence): Don't assume vector length fits in int.
6987 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6988 (header_size, word_size): New constants.
6989 (allocate_vectorlike): Don't check size overflow here.
6990 (allocate_vector): Check it here instead, since this is the only
6991 caller of allocate_vectorlike that could cause overflow.
6992 Check that the new vector's length is representable as a fixnum.
6994 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6995 The previous code was bogus. For example, next_almost_prime (32)
6996 returned 39, which is undesirable as it is a multiple of 3; and
6997 next_almost_prime (24) returned 25, which is a multiple of 5 so
6998 why was the code bothering to check for multiples of 7?
7000 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7002 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7004 Variadic C functions now count arguments with ptrdiff_t.
7005 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7006 Back then I didn't know that the Emacs coding style prefers signed int.
7007 Also, in the meantime I found a few more instances where arguments
7008 were being counted with int, which may truncate counts on 64-bit
7009 machines, or EMACS_INT, which may be unnecessarily wide.
7010 * lisp.h (struct Lisp_Subr.function.aMANY)
7011 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7012 Arg counts are now ptrdiff_t, not size_t.
7013 All variadic functions and their callers changed accordingly.
7014 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7015 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7016 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7017 * callint.c (Fcall_interactively): Check arg count for overflow,
7018 to avoid potential buffer overrun. Use signed char, not 'int',
7019 for 'varies' array, so that we needn't bother to check its size
7020 calculation for overflow.
7021 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7022 * eval.c (apply_lambda):
7023 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7024 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7025 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7027 * callint.c (Fcall_interactively): Don't use index var as event count.
7029 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7030 * mem-limits.h (SIZE): Remove; no longer used.
7032 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7034 Remove unnecessary casts.
7035 * xterm.c (x_term_init):
7036 * xfns.c (x_set_border_pixel):
7037 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7038 These aren't needed now that we assume ANSI C.
7040 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7041 It's more likely to cause problems (due to unsigned overflow)
7044 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7046 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7048 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7050 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7052 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7054 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7056 GLYPH_CODE_FACE returns EMACS_INT, not int.
7057 * dispextern.h (merge_faces):
7058 * xfaces.c (merge_faces):
7059 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7060 Don't assume EMACS_INT fits in int.
7062 * character.h (CHAR_VALID_P): Remove unused parameter.
7063 * fontset.c, lisp.h, xdisp.c: All uses changed.
7065 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7067 * fns.c (concat): Minor tuning based on overflow analysis.
7068 This doesn't fix any bugs. Use int to hold character, instead
7069 of constantly refetching from Emacs object. Use XFASTINT, not
7070 XINT, for value known to be a character. Don't bother comparing
7071 a single byte to 0400, as it's always less.
7073 * floatfns.c (Fexpt):
7074 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7076 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7079 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7081 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7082 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7083 incorrectly succeed when S was a string, because 4294967386 was
7084 truncated before it was used.
7086 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7087 Otherwise, an out-of-range integer could cause undefined behavior
7090 * composite.c: Use int, not EMACS_INT, for characters.
7091 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7092 EMACS_INT, for values that are known to be in character range.
7093 This doesn't fix any bugs but is the usual style inside Emacs and
7094 may generate better code on 32-bit machines.
7096 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7097 This is for reasons similar to the recent CHAR_STRING fix.
7098 * charset.c (Fencode_char): Check that character arg is actually
7099 a character. Pass an int to ENCODE_CHAR.
7100 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7101 wider than 'int', as a compile-time check to prevent future regressions
7104 * character.c (char_string): Remove unnecessary casts.
7106 Make sure a 64-bit char is never passed to CHAR_STRING.
7107 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7108 by silently ignoring the top 32 bits, allowing some values
7109 that were far too large to be valid characters.
7110 * character.h: Include <verify.h>.
7111 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7112 arguments are no wider than unsigned, as a compile-time check
7113 to prevent future regressions in this area.
7115 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7116 (Fsubst_char_in_region):
7118 * xdisp.c (decode_mode_spec_coding):
7119 Adjust to CHAR_STRING's new requirement.
7120 * editfns.c (Finsert_char, Fsubst_char_in_region):
7121 * fns.c (concat): Check that character args are actually
7122 characters. Without this test, these functions did the wrong
7123 thing with wildly out-of-range values on 64-bit hosts.
7125 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7126 These casts should not be needed on 32-bit hosts, either.
7127 * keyboard.c (read_char):
7128 * lread.c (Fload): Remove casts to unsigned.
7130 * lisp.h (UNSIGNED_CMP): New macro.
7131 This fixes comparison bugs on 64-bit hosts.
7132 (ASCII_CHAR_P): Use it.
7133 * casefiddle.c (casify_object):
7134 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7135 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7136 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7137 * dispextern.h (FACE_FROM_ID):
7138 * keyboard.c (read_char): Use UNSIGNED_CMP.
7140 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7141 not to EMACS_INT, to avoid GCC warning.
7143 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7145 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7146 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7147 isn't needed on 32-bit machines.
7149 * buffer.c (Fgenerate_new_buffer_name):
7150 Use EMACS_INT for count, not int.
7151 (advance_to_char_boundary): Return EMACS_INT, not int.
7153 * data.c (Qcompiled_function): Now static.
7155 * window.c (window_body_lines): Now static.
7157 * image.c (gif_load): Rename local to avoid shadowing.
7159 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7160 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7161 * alloc.c (make_save_value): Integer argument is now of type
7163 (mark_object): Use ptrdiff_t, not int.
7164 * lisp.h (pD): New macro.
7165 * print.c (print_object): Use it.
7167 * alloc.c: Use EMACS_INT, not int, to count objects.
7168 (total_conses, total_markers, total_symbols, total_vector_size)
7169 (total_free_conses, total_free_markers, total_free_symbols)
7170 (total_free_floats, total_floats, total_free_intervals)
7171 (total_intervals, total_strings, total_free_strings):
7172 Now EMACS_INT, not int. All uses changed.
7173 (Fgarbage_collect): Compute overall total using a double, so that
7174 integer overflow is less likely to be a problem. Check for overflow
7175 when converting back to an integer.
7176 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7177 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7178 These were 'int' variables that could overflow on 64-bit hosts;
7179 they were never used, so remove them instead of repairing them.
7180 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7181 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7182 Previously, this ceilinged at INT_MAX, but that doesn't work on
7184 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7186 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7187 (allocate_vectorlike): Check for ptrdiff_t overflow.
7188 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7189 when a (possibly-narrower) signed value would do just as well.
7190 We prefer using signed arithmetic, to avoid comparison confusion.
7192 * alloc.c: Catch some string size overflows that we were missing.
7193 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7194 for convenience in STRING_BYTES_MAX.
7195 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7196 The definition here is exact; the one in lisp.h was approximate.
7197 (allocate_string_data): Check for string overflow. This catches
7198 some instances we weren't catching before. Also, it catches
7199 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7200 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7201 and ptrdiff_t and EMACS_INT are both 64 bits.
7203 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7204 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7205 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7207 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7209 * alloc.c (Fmake_string): Check for out-of-range init.
7211 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7213 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7215 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7217 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7218 xg_get_default_scrollbar_width.
7220 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7221 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7222 (style_changed_cb): Call update_theme_scrollbar_width and call
7223 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7224 all frames (Bug#8505).
7225 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7226 Call gtk_window_set_resizable if HAVE_GTK3.
7227 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7228 and height if HAVE_GTK3 (Bug#8505).
7229 (scroll_bar_width_for_theme): New variable.
7230 (update_theme_scrollbar_width): New function.
7231 (xg_get_default_scrollbar_width): Move code to
7232 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7233 (xg_initialize): Call update_theme_scrollbar_width.
7235 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7237 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7239 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7241 * frame.c (make_frame): Call other_buffer_safely instead of
7244 * window.c (temp_output_buffer_show): Call display_buffer with
7245 second argument Vtemp_buffer_show_specifiers and reset latter
7246 immediately after the call.
7247 (Vtemp_buffer_show_specifiers): New variable.
7248 (auto_window_vscroll_p, next_screen_context_lines)
7249 (Vscroll_preserve_screen_position): Remove leading asterisks from
7252 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7254 Fix minor problems found by GCC 4.6.0 static checking.
7255 * buffer.c (Qclone_number): Remove for now, as it's unused.
7256 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7257 (record_buffer): Remove unused local.
7258 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7259 (set_frame_buffer_list): Remove; unused.
7260 * frame.h (other_visible_frames): Remove decl.
7261 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7262 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7263 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7265 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7266 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7267 Define only if HAVE_GPM.
7268 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7269 (update_hints_inhibit): Remove; never set. All uses removed.
7270 * widgetprv.h (emacsFrameClassRec): Remove decl.
7271 * window.c (delete_deletable_window): Now returns void, since it
7272 wasn't returning anything.
7273 (compare_window_configurations): Remove unused locals.
7274 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7275 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7276 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7277 the same widths as pointers. This follows up on the 2011-05-06 patch.
7278 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7279 * xterm.h: Likewise.
7280 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7282 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7284 * makefile.w32-in: Update dependencies.
7285 (LISP_H): Add lib/intprops.h.
7287 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7289 * image.c (gif_load): Add animation frame delay to the metadata.
7290 (syms_of_image): Use DEFSYM. New symbol `delay'.
7292 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7294 * window.c (delete_deletable_window): Re-add.
7295 (Fset_window_configuration): Rewrite to handle dead buffers and
7296 consequently deletable windows.
7297 (window_tree, Fwindow_tree): Remove. Supply functionality in
7299 (compare_window_configurations): Simplify code.
7301 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7303 * image.c (imagemagick_load_image): Fix type mismatch.
7304 (Fimagemagick_types): Likewise.
7306 * window.h (replace_buffer_in_windows): Declare.
7308 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7310 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7311 Qclone_number. Remove external declaration of Qdelete_window.
7312 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7314 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7315 Run Qbuffer_list_update_hook if allowed.
7316 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7317 buffer list implementation.
7318 (other_buffer_safely): New function.
7319 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7320 calls to replace_buffer_in_windows and
7321 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7323 (record_buffer): Inhibit quitting and rewrite using quittable
7324 functions. Run Qbuffer_list_update_hook if allowed.
7325 (Frecord_buffer, Funrecord_buffer): New functions.
7326 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7327 Move switch-to-buffer to window.el.
7328 (bury-buffer): Move to window.el.
7329 (Vbuffer_list_update_hook): New variable.
7331 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7334 * window.h (resize_frame_windows): Move up in code.
7335 (Fwindow_frame): Remove EXFUN.
7336 (replace_buffer_in_all_windows): Remove prototype.
7337 (replace_buffer_in_windows_safely): Add prototype.
7339 * window.c: Declare Qdelete_window static again. Move down
7340 declaration of select_count.
7341 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7342 (Fother_window): Move to window.el.
7343 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7344 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7345 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7347 (replace_buffer_in_windows): Implement by calling
7348 Qreplace_buffer_in_windows.
7349 (replace_buffer_in_all_windows): Remove with some functionality
7350 moved into replace_buffer_in_windows_safely.
7351 (replace_buffer_in_windows_safely): New function.
7352 (select_window_norecord, select_frame_norecord): Move in front
7353 of run_window_configuration_change_hook. Remove now obsolete
7355 (Fset_window_buffer): Rewrite doc-string.
7356 Call Qrecord_window_buffer.
7357 (keys_of_window): Move binding for other-window to window.el.
7359 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7361 * dispextern.h (struct image): Replace data member, whose int_val
7362 and ptr_val fields were not used by anything, with a single
7365 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7366 (gif_clear_image, gif_load, imagemagick_load_image)
7367 (gs_clear_image, gs_load): Callers changed.
7369 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7371 * buffer.h: Include <time.h>, for time_t.
7372 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7374 Fix minor problems found by static checking.
7376 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7378 Make identifiers static if they are not used in other modules.
7379 * data.c (Qcompiled_function, Qframe, Qvector):
7380 * image.c (QimageMagick, Qsvg):
7381 * minibuf.c (Qmetadata):
7382 * window.c (resize_window_check, resize_root_window): Now static.
7383 * window.h (resize_window_check, resize_root_window): Remove decls.
7385 * window.c (window_deletion_count, delete_deletable_window):
7387 (window_body_lines): Now static.
7388 (Fdelete_other_windows_internal): Mark vars as initialized.
7389 Make sure 'resize_failed' is initialized.
7390 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7391 (resize_window_apply): Remove unused local.
7392 * window.h (delete_deletable_window): Remove decl.
7394 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7395 (imagemagick_load_image): Fix pointer signedness problem by changing
7396 last arg from unsigned char * to char *. All uses changed.
7397 Also, fix a local for similar reasons.
7398 Remove unused locals. Remove locals to avoid shadowing.
7399 (fn_rsvg_handle_free): Remove; unused.
7400 (svg_load, svg_load_image): Fix pointer signedness problem.
7401 (imagemagick_load_image): Don't use garbage pointer image_wand.
7403 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7405 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7407 * image.c (gif_load): Fix omitted cast error introduced by
7410 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7412 * window.h (resize_proportionally, orig_total_lines)
7413 (orig_top_line): Remove from window structure.
7414 (set_window_height, set_window_width, change_window_heights)
7415 (Fdelete_window): Remove prototypes.
7416 (resize_frame_windows): Remove duplicate declaration.
7418 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7420 * window.h (resize_frame_windows, resize_window_check)
7421 (delete_deletable_window, resize_root_window)
7422 (resize_frame_windows): Declare prototypes.
7424 * window.c (resize_window_apply): Make definition be "static" to
7425 match the prototype.
7427 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7429 * window.c: Remove declarations of Qwindow_size_fixed,
7430 window_min_size_1, window_min_size_2, window_min_size,
7431 size_window, window_fixed_size_p, enlarge_window, delete_window.
7432 Remove static from declaration of Qdelete_window, it's
7433 temporarily needed by Fbury_buffer.
7434 (replace_window): Don't assign orig_top_line and
7436 (Fdelete_window, delete_window): Remove. Window deletion is
7437 handled by window.el.
7438 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7439 Replace Fdelete_window calls with calls to Qdelete_window.
7440 (Fdelete_other_windows): Remove. Deleting other windows is
7441 handled by window.el.
7442 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7443 handled in window.el.
7444 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7445 Window minimum sizes are handled in window.el.
7446 (shrink_windows, size_window, set_window_height)
7447 (set_window_width, change_window_heights, window_height)
7448 (window_width, CURBEG, CURSIZE, enlarge_window)
7449 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7450 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7451 handled in window.el.
7452 (make_dummy_parent): Rename to make_parent_window and give it a
7453 second argument horflag.
7454 (make_window): Don't set resize_proportionally any more.
7455 (Fsplit_window): Remove. Windows are split in window.el.
7456 (save_restore_action, save_restore_orig_size)
7457 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7458 Resize mini windows in window.el.
7459 (grow_mini_window, shrink_mini_window): Implement by calling
7460 Qresize_root_window_vertically, resize_window_check and
7461 resize_window_apply.
7462 (saved_window, Fset_window_configuration, save_window_save):
7463 Do not handle orig_top_line, orig_total_lines, and
7464 resize_proportionally.
7465 (window_min_height, window_min_width): Move to window.el.
7466 (keys_of_window): Move bindings for delete-other-windows,
7467 split-window, delete-window and enlarge-window to window.el.
7469 * buffer.c: Temporarily extern Qdelete_window.
7470 (Fbury_buffer): Temporarily call Qdelete_window instead of
7471 Fdelete_window (Fbury_buffer will move to window.el soon).
7473 * frame.c (set_menu_bar_lines_1): Remove code handling
7474 orig_top_line and orig_total_lines.
7476 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7477 set_window_height but set heights directly.
7478 (change_frame_size_1): Use resize_frame_windows.
7480 * xdisp.c (init_xdisp): Don't use set_window_height but set
7483 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7484 Use resize_frame_windows instead of change_window_heights and run
7485 run_window_configuration_change_hook.
7487 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7488 instead of change_window_heights and run
7489 run_window_configuration_change_hook.
7491 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7493 * window.c (replace_window): Rename second argument REPLACEMENT to
7494 NEW. New third argument SETFLAG. Rewrite.
7495 (delete_window, make_dummy_parent): Call replace_window with
7497 (window_list_1): Move down in code.
7498 (run_window_configuration_change_hook): Move set_buffer part
7499 before select_frame_norecord part in order to unwind correctly.
7500 Rename count1 to count.
7501 (recombine_windows, delete_deletable_window, resize_root_window)
7502 (Fdelete_other_windows_internal)
7503 (Frun_window_configuration_change_hook, make_parent_window)
7504 (resize_window_check, resize_window_apply, Fresize_window_apply)
7505 (resize_frame_windows, Fsplit_window_internal)
7506 (Fdelete_window_internal, Fresize_mini_window_internal):
7508 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7510 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7512 * window.h (window): Add some new members to window structure -
7513 normal_lines, normal_cols, new_total, new_normal, clone_number,
7514 splits, nest, prev_buffers, next_buffers.
7515 (WINDOW_TOTAL_SIZE): Move here from window.c.
7516 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7518 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7520 (make_dummy_parent): Set new members of windows structure.
7521 (make_window): Move down in code. Handle new members of window
7523 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7524 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7525 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7526 (Fset_window_prev_buffers, Fwindow_next_buffers)
7527 (Fset_window_next_buffers, Fset_window_clone_number):
7529 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7530 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7532 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7533 Argument WINDOW can be now internal window too.
7534 (Fwindow_use_time): Move up in code.
7535 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7537 (Fset_window_configuration, saved_window)
7538 (Fcurrent_window_configuration, save_window_save): Handle new
7539 members of window structure.
7540 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7541 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7542 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7543 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7544 Qget_mru_window, Qresize_root_window,
7545 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7546 Qauto_buffer_name; staticpro them.
7548 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7550 * window.c (Fwindow_total_size, Fwindow_left_column)
7551 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7552 (Fwindow_list_1): New functions.
7553 (window_box_text_cols): Replace with window_body_cols.
7554 (Fwindow_width, Fscroll_left, Fscroll_right):
7555 Use window_body_cols instead of window_box_text_cols.
7556 (delete_window, Fset_window_configuration):
7557 Call delete_all_subwindows with window as argument.
7558 (delete_all_subwindows): Take a window as argument and not a
7560 (window_loop): Remove handling of GET_LRU_WINDOW and
7562 (Fget_lru_window, Fget_largest_window): Move to window.el.
7564 * window.h: Extern window_body_cols instead of
7565 window_box_text_cols. delete_all_subwindows now takes a
7566 Lisp_Object as argument.
7568 * indent.c (compute_motion, Fcompute_motion):
7569 Use window_body_cols instead of window_box_text_cols.
7571 * frame.c (delete_frame): Call delete_all_subwindows with root
7574 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7576 * fns.c (Fputhash): Document return value.
7578 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7580 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7582 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7584 Cons<->int and similar integer overflow fixes (Bug#8794).
7586 Check for overflow when converting integer to cons and back.
7587 * charset.c (Fdefine_charset_internal, Fdecode_char):
7588 Use cons_to_unsigned to catch overflow.
7589 (Fencode_char): Use INTEGER_TO_CONS.
7590 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7591 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7592 * data.c (long_to_cons, cons_to_long): Remove.
7593 (cons_to_unsigned, cons_to_signed): New functions.
7594 These signal an error for invalid or out-of-range values.
7595 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7596 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7597 * font.c (Ffont_variation_glyphs):
7598 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7599 * lisp.h: Include <intprops.h>.
7600 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7601 (cons_to_signed, cons_to_unsigned): New decls.
7602 (long_to_cons, cons_to_long): Remove decls.
7603 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7604 (Fprimitive_undo): Use CONS_TO_INTEGER.
7605 * xfns.c (Fx_window_property): Likewise.
7606 * xselect.c: Include <limits.h>.
7607 (x_own_selection, selection_data_to_lisp_data):
7608 Use INTEGER_TO_CONS.
7609 (x_handle_selection_request, x_handle_selection_clear)
7610 (x_get_foreign_selection, Fx_disown_selection_internal)
7611 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7612 (lisp_data_to_selection_data): Use cons_to_unsigned.
7613 (x_fill_property_data): Use cons_to_signed.
7614 Report values out of range.
7616 Check for buffer and string overflow more precisely.
7617 * buffer.h (BUF_BYTES_MAX): New macro.
7618 * lisp.h (STRING_BYTES_MAX): New macro.
7619 * alloc.c (Fmake_string):
7620 * character.c (string_escape_byte8):
7621 * coding.c (coding_alloc_by_realloc):
7622 * doprnt.c (doprnt):
7623 * editfns.c (Fformat):
7625 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7626 since they may not be the same number.
7627 * editfns.c (Finsert_char):
7628 * fileio.c (Finsert_file_contents):
7629 Likewise for BUF_BYTES_MAX.
7631 * image.c: Use ptrdiff_t, not int, for sizes.
7632 (slurp_file): Switch from int to ptrdiff_t.
7634 (slurp_file): Check that file size fits in both size_t (for
7635 malloc) and ptrdiff_t (for sanity and safety).
7637 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7638 if b->modtime has its maximal value.
7640 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7642 Don't assume time_t can fit into int.
7643 * buffer.h (struct buffer.modtime): Now time_t, not int.
7644 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7645 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7647 Minor fixes for signed vs unsigned integers.
7648 * character.h (MAYBE_UNIFY_CHAR):
7649 * charset.c (maybe_unify_char):
7650 * keyboard.c (read_char, reorder_modifiers):
7651 XINT -> XFASTINT, since the integer must be nonnegative.
7652 * ftfont.c (ftfont_spec_pattern):
7653 * keymap.c (access_keymap, silly_event_symbol_error):
7654 XUINT -> XFASTINT, since the integer must be nonnegative.
7655 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7656 since it makes no difference and we prefer signed.
7657 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7658 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7661 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7663 * window.h (Fwindow_frame): Declare.
7665 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7667 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7668 (SPARE_MEMORY): Always define.
7669 (LARGE_REQUEST): Remove.
7670 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7672 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7674 * lisp.h: Move EXFUNS for Fframe_root_window,
7675 Fframe_first_window and Fset_frame_selected_window to window.h.
7677 * window.h: Move EXFUNS for Fframe_root_window,
7678 Fframe_first_window and Fset_frame_selected_window here from
7681 * frame.c (Fwindow_frame, Fframe_first_window)
7682 (Fframe_root_window, Fframe_selected_window)
7683 (Fset_frame_selected_window): Move to window.c.
7684 (Factive_minibuffer_window): Move to minibuf.c.
7685 (Fother_visible_frames_p): New function.
7687 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7689 * window.c (decode_window, decode_any_window): Move up in code.
7690 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7691 (inhibit_frame_unsplittable): Remove unused variable.
7692 (Fwindow_buffer): Move up and rewrite doc-string.
7693 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7694 (Fwindow_prev): New functions.
7695 (Fwindow_frame): Move here from frame.c. Accept any window as
7697 (Fframe_root_window, Fframe_first_window)
7698 (Fframe_selected_window): Move here from frame.c. Accept frame
7699 or arbitrary window as argument. Update doc-strings.
7700 (Fminibuffer_window): Move up in code.
7701 (Fwindow_minibuffer_p): Move up in code and simplify.
7702 (Fset_frame_selected_window): Move here from frame.c.
7704 (Fselected_window, select_window, Fselect_window): Move up in
7705 code. Minor doc-string fixes.
7707 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7709 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7710 Do not assume that spare memory exists; that assumption is valid
7711 only if SYSTEM_MALLOC.
7712 (LARGE_REQUEST): New macro, so that the issue of large requests
7713 is separated from the issue of spare memory.
7715 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7717 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7720 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7722 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7725 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7727 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7729 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7731 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7732 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7734 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7736 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7738 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7740 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7741 (x_clipboard_manager_save): Add return value.
7742 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7744 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7745 Obey Vx_select_enable_clipboard_manager. Catch errors in
7746 x_clipboard_manager_save (Bug#8779).
7747 (Vx_select_enable_clipboard_manager): New variable.
7748 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7750 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7752 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7754 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7756 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7757 in the current matrix if keep_current_p is non-zero.
7759 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7761 * bidi.c (bidi_level_of_next_char): Fix last change.
7763 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7765 Support bidi reordering of text covered by display properties.
7767 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7768 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7769 (bidi_cache_search, bidi_cache_iterator_state)
7770 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7771 (bidi_level_of_next_char, bidi_move_to_visually_next):
7772 Support character positions inside a run of characters covered by a
7774 (bidi_paragraph_init, bidi_resolve_explicit_1)
7775 (bidi_level_of_next_char): Call bidi_fetch_char and
7776 bidi_fetch_char_advance instead of FETCH_CHAR and
7778 (bidi_init_it): Initialize new members.
7779 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7781 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7782 instead of using explicit *_CHAR codes.
7783 (bidi_resolve_explicit, bidi_resolve_weak):
7784 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7785 bidirectional text is supported only in multibyte buffers.
7786 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7787 it to initialize the frame_window_p member of struct bidi_it.
7788 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7789 (bidi_resolve_explicit, bidi_resolve_weak)
7790 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7791 bidi_it->nchars is non-positive.
7792 (bidi_level_of_next_char): Don't try to lookup the cache for the
7793 next/previous character if nothing is cached there yet, or if we
7794 were just reseat()'ed to a new position.
7796 * xdisp.c (set_cursor_from_row): Set start and stop points
7797 according to the row's direction when priming the loop that looks
7798 for the glyph on which to display cursor.
7799 (single_display_spec_intangible_p): Function deleted.
7800 (display_prop_intangible_p): Reimplement to call
7801 handle_display_spec instead of single_display_spec_intangible_p.
7802 Accept 3 additional arguments needed by handle_display_spec.
7803 This fixes incorrect cursor motion across display property with complex
7804 values: lists, `(when COND...)' forms, etc.
7805 (single_display_spec_string_p): Support property values that are
7806 lists with the argument STRING its top-level element.
7807 (display_prop_string_p): Fix the condition for processing a
7808 property that is a list to be consistent with handle_display_spec.
7809 (handle_display_spec): New function, refactored from the
7810 last portion of handle_display_prop.
7811 (compute_display_string_pos): Accept additional argument
7812 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7813 value of a `display' property is a "replacing spec".
7814 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7815 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7816 the display property, but just return a value indicating whether
7817 the display property will replace the characters it covers.
7818 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7819 frame_window_p members of struct bidi_it.
7820 (compute_display_string_pos, compute_display_string_end):
7822 (push_it): Accept second argument POSITION, where pop_it should
7823 jump to continue iteration.
7824 (reseat_1): Initialize bidi_it.disp_pos.
7826 * keyboard.c (adjust_point_for_property): Adjust the call to
7827 display_prop_intangible_p to its new signature.
7829 * dispextern.h (struct bidi_it): New member frame_window_p.
7830 (bidi_init_it): Update prototypes.
7831 (display_prop_intangible_p): Update prototype.
7832 (compute_display_string_pos, compute_display_string_end):
7834 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7837 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7839 Malloc failure behavior now depends on size of allocation.
7840 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7841 * lisp.h: Change signatures accordingly.
7842 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7843 All callers changed. (Bug#8762)
7845 * gnutls.c: Use Emacs's memory allocators.
7846 Without this change, the gnutls library would invoke malloc etc.
7847 directly, which causes problems on non-SYNC_INPUT hosts, and which
7848 runs afoul of improving memory_full behavior. (Bug#8761)
7849 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7850 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7851 xfree instead of the default malloc, realloc, free.
7852 (Fgnutls_boot): No need to check for memory allocation failure,
7853 since xmalloc does that for us.
7855 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7856 * category.c (hash_get_category_set):
7857 * ccl.c (ccl_driver):
7858 * charset.c (Fdefine_charset_internal):
7859 * charset.h (struct charset.hash_index):
7860 * composite.c (get_composition_id, gstring_lookup_cache)
7861 (composition_gstring_put_cache):
7862 * composite.h (struct composition.hash_index):
7863 * dispextern.h (struct image.hash):
7864 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7865 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7866 (hashfn_equal, hashfn_user_defined, make_hash_table)
7867 (maybe_resize_hash_table, hash_lookup, hash_put)
7868 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7869 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7870 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7871 * image.c (make_image, search_image_cache, lookup_image)
7872 (xpm_put_color_table_h):
7873 * lisp.h (struct Lisp_Hash_Table):
7874 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7875 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7876 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7877 * alloc.c (allocate_vectorlike):
7878 Check for overflow in vector size calculations.
7879 * ccl.c (ccl_driver):
7880 Check for overflow when converting EMACS_INT to int.
7881 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7882 need to be updated by these changes.
7883 * fns.c (make_hash_table, maybe_resize_hash_table):
7884 Check for integer overflow with large hash tables.
7885 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7886 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7887 (SXHASH_REDUCE): New macro.
7888 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7889 Use it instead of discarding useful hash info with large hash values.
7890 (sxhash_float): New function.
7891 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7892 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7893 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7894 Rewrite to use FIXNUM_BITS, as this simplifies things.
7895 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7896 Adjust signatures to match updated version of code.
7897 (consing_since_gc): Now EMACS_INT, since a single hash table can
7898 use more than INT_MAX bytes.
7900 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7902 Make it possible to build with GCC-4.6+ -O2 -flto.
7904 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7906 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7908 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7909 Call minibuffer-inactive-mode.
7911 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7913 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7914 Update dependencies.
7916 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7918 * data.c (init_data): Remove code for UTS, this system is not
7921 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7923 Don't force ./temacs to start in terminal mode.
7925 * frame.c (make_initial_frame): Initialize faces in all cases, not
7926 only when CANNOT_DUMP is defined.
7927 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7929 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7931 * dispnew.c (add_window_display_history): Use const for the string
7932 pointer. Remove declaration, not needed.
7934 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7936 Use 'inline', not 'INLINE'.
7937 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7938 * alloc.c, fontset.c (INLINE): Remove.
7939 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7940 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7941 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7942 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7943 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7945 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7947 Make it possible to run ./temacs.
7949 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7950 syms_of_callproc does the same thing. Remove test for
7951 "initialized", do it in the caller.
7952 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7954 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7956 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7957 (read_minibuf): Use get_minibuffer.
7958 (syms_of_minibuf): Use DEFSYM.
7959 (Qmetadata): New var.
7960 * data.c (Qbuffer): Don't make it static.
7961 (syms_of_data): Use DEFSYM.
7963 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7965 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7966 (CCL_CODE_MIN): New macro.
7968 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7970 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7972 * eval.c (Qdebug): Now static.
7973 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7974 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7975 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7977 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7979 * image.c: Various fixes to ImageMagick code comments.
7980 (Fimagemagick_types): Doc fix.
7982 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7984 Minor fixes prompted by GCC 4.6.0 warnings.
7986 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7988 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7989 (x_clipboard_manager_save_all): Move extern decl to ...
7990 * xterm.h: ... here, so that it can be checked for consistency.
7992 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7994 * xselect.c (x_clipboard_manager_save_frame)
7995 (x_clipboard_manager_save_all): New functions.
7996 (Fx_clipboard_manager_save): Lisp function deleted.
7998 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7999 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8001 * xterm.h: Update prototype.
8003 2011-05-28 William Xu <william.xwl@gmail.com>
8005 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8008 2011-05-28 Jim Meyering <meyering@redhat.com>
8010 Avoid a sign-extension bug in crypto_hash_function.
8011 * fns.c (to_uchar): Define.
8012 (crypto_hash_function): Use it to convert some newly-signed
8013 variables to unsigned, to avoid sign-extension bugs. For example,
8014 without this change, (md5 "truc") would evaluate to
8015 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8016 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8017 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8019 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8021 Integer overflow fixes.
8023 * dbusbind.c: Serial number integer overflow fixes.
8024 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8025 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8026 to hold a serial number that is too large for a fixnum.
8027 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8028 Check for serial numbers out of range. Decode any serial number
8029 that was so large that it became a float. (Bug#8722)
8031 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8032 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8033 Use XFASTINT rather than XUINT when numbers are nonnegative.
8034 (xd_append_arg, Fdbus_method_return_internal):
8035 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8036 arguments, check that Lisp number is nonnegative, rather than
8037 silently wrapping negative numbers around. (Bug#8722)
8038 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8041 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8043 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8045 ccl: Add integer overflow checks.
8046 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8047 (IN_INT_RANGE): New macros.
8048 (ccl_driver): Use them to check for integer overflow when
8049 decoding a CCL program. Many of the new checks are whether XINT (x)
8050 fits in int; it doesn't always, on 64-bit hosts. The new version
8051 doesn't catch all possible integer overflows, but it's an
8052 improvement. (Bug#8719)
8054 * alloc.c (make_event_array): Use XINT, not XUINT.
8055 There's no need for unsigned here.
8057 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8058 This follows up to the 2011-05-06 change that substituted uintptr_t
8059 for EMACS_INT. This case wasn't caught back then.
8061 Rework Fformat to avoid integer overflow issues.
8062 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8063 now (part of C89). Include <verify.h>.
8064 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8065 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8066 (Fformat): Avoid the prepass trying to compute sizes; it was only
8067 approximate and thus did not catch overflow reliably. Instead, walk
8068 through the format just once, formatting and computing sizes as we go,
8069 checking for integer overflow at every step, and allocating a larger
8070 buffer as needed. Keep track separately whether the format is
8071 multibyte. Keep only the most-recently calculated precision, rather
8072 than them all. Record whether each argument has been converted to
8073 string. Use EMACS_INT, not int, for byte and char and arg counts.
8074 Support field widths and precisions larger than INT_MAX. Avoid
8075 sprintf's undefined behavior with conversion specifications such as %#d
8076 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8077 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8078 formatting out-of-range floating point numbers with int
8081 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8083 * data.c: Avoid integer truncation in expressions involving floats.
8084 * data.c: Include <intprops.h>.
8085 (arith_driver): When there's an integer overflow in an expression
8086 involving floating point, convert the integers to floating point
8087 so that the resulting value does not suffer from catastrophic
8088 integer truncation. For example, on a 64-bit host (* 4
8089 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8090 Do not rely on undefined behavior after integer overflow.
8092 merge count_size_as_multibyte, parse_str_to_multibyte
8093 * character.c, character.h (count_size_as_multibyte):
8094 Rename from parse_str_to_multibyte; all uses changed.
8095 Check for integer overflow.
8096 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8097 since it's now a duplicate of the other. This is more of
8098 a character than a buffer op, so better that it's in character.c.
8099 * fns.c, print.c: Adjust to above changes.
8101 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8103 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8105 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8107 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8108 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8109 (x_clipboard_manager_save): Now static.
8110 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8112 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8113 (crypto_hash_function): Now static.
8114 Fix pointer signedness problems. Avoid unnecessary initializations.
8116 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8118 * termhooks.h (Vselection_alist): Make it terminal-local.
8120 * terminal.c (create_terminal): Initialize it.
8122 * xselect.c: Support for clipboard managers.
8123 (Vselection_alist): Move to termhooks.h as terminal-local var.
8124 (LOCAL_SELECTION): New macro.
8125 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8126 (symbol_to_x_atom): Remove gratuitous arg.
8127 (x_handle_selection_request, lisp_data_to_selection_data)
8128 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8129 (x_own_selection, x_get_local_selection, x_convert_selection):
8130 New arg, specifying work frame. Use terminal-local Vselection_alist.
8131 (some_frame_on_display): Delete unused function.
8132 (Fx_own_selection_internal, Fx_get_selection_internal)
8133 (Fx_disown_selection_internal, Fx_selection_owner_p)
8134 (Fx_selection_exists_p): New optional frame arg.
8135 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8136 (x_handle_selection_clear): Don't treat other terminals with the
8137 same keyboard specially. Use the terminal-local Vselection_alist.
8138 (x_clear_frame_selections): Use Frun_hook_with_args.
8140 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8142 * xterm.h: Add support for those atoms.
8144 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8146 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8147 (converted_selections, conversion_fail_tag): New global variables.
8148 (x_selection_request_lisp_error): Free the above.
8149 (x_get_local_selection): Remove unnecessary code.
8150 (x_reply_selection_request): Args changed; handle arbitrary array
8151 of converted selections stored in converted_selections.
8152 Separate the XChangeProperty and SelectionNotify steps.
8153 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8154 (x_convert_selection): New function.
8155 (x_handle_selection_event): Simplify.
8156 (x_get_foreign_selection): Don't ignore incoming requests while
8157 waiting for an answer; this will fail when we implement
8158 SAVE_TARGETS, and seems unnecessary anyway.
8159 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8160 (Vx_sent_selection_functions): Doc fix.
8162 2011-05-26 Leo Liu <sdl.web@gmail.com>
8164 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8166 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8168 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8170 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8171 for fringe update if it has periodic bitmap.
8172 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8173 and fringe_bitmap_periodic_p.
8175 * fringe.c (get_fringe_bitmap_data): New function.
8176 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8177 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8178 row. Mark glyph row for fringe update if periodicity changed.
8180 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8181 for fringe update unless it has periodic bitmap.
8183 2011-05-25 Kenichi Handa <handa@m17n.org>
8185 * xdisp.c (get_next_display_element): Set correct it->face_id for
8186 a static composition.
8188 2011-05-24 Leo Liu <sdl.web@gmail.com>
8191 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8193 * fns.c (crypto_hash_function, Fsha1): New function.
8194 (Fmd5): Use crypto_hash_function.
8195 (syms_of_fns): Add Ssha1.
8197 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8199 * gnutls.c: Remove unused macros.
8200 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8201 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8202 Remove macros that are defined and never used.
8203 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8205 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8207 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8208 (Fx_get_selection_internal): Minor cleanup.
8209 (Fx_own_selection_internal): Rename arguments for consistency with
8212 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8214 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8216 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8218 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8220 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8222 * dispnew.c (scrolling_window): Don't exclude the case that the
8223 last enabled row in the desired matrix touches the bottom boundary.
8225 2011-05-21 Glenn Morris <rgm@gnu.org>
8227 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8228 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8229 and add some more files.
8231 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8233 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8234 report_file_error introduced by the change from 2011-05-07.
8236 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8238 * systime.h (Time): Define only if emacs is defined.
8239 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8240 where the include path doesn't have X11/X.h by default. See
8241 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8243 2011-05-20 Kenichi Handa <handa@m17n.org>
8245 * composite.c (find_automatic_composition): Fix previous change.
8247 2011-05-20 Glenn Morris <rgm@gnu.org>
8249 * lisp.mk: New file, split from Makefile.in.
8250 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8251 (shortlisp): Remove.
8252 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8254 2011-05-19 Glenn Morris <rgm@gnu.org>
8256 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8257 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8258 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8259 (lisp): Set the order to that of loadup.el.
8260 (shortlisp): Make it a copy of $lisp.
8261 (SOME_MACHINE_LISP): Remove.
8262 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8263 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8265 2011-05-18 Kenichi Handa <handa@m17n.org>
8267 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8268 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8269 (find_automatic_composition): Mostly rewrite for efficiency.
8271 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8273 * makefile.w32-in: Update dependencies.
8275 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8277 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8278 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8280 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8282 Fix some integer overflow issues, such as string length overflow.
8284 * insdel.c (count_size_as_multibyte): Check for string overflow.
8286 * character.c (lisp_string_width): Check for string overflow.
8287 Use EMACS_INT, not int, for string indexes and lengths; in
8288 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8289 the resulting string length overflows an EMACS_INT; instead,
8290 report a string overflow if no precision given. When checking for
8291 precision exhaustion, use a check that cannot possibly have
8292 integer overflow. (Bug#8675)
8293 * character.h (lisp_string_width): Adjust to new signature.
8295 * alloc.c (string_overflow): New function.
8296 (Fmake_string): Use it. This doesn't change behavior, but saves
8297 a few bytes and will simplify future changes.
8298 * character.c (string_escape_byte8): Likewise.
8299 * lisp.h (string_overflow): New decl.
8301 Fixups, following up to the user-interface timestamp change.
8302 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8303 for UI timestamps, instead of unsigned long.
8304 * msdos.c (mouse_get_pos): Likewise.
8305 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8306 * w32gui.h (Time): Define by including "systime.h" rather than by
8307 declaring it ourselves. (Bug#8664)
8309 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8310 * image.c (clear_image_cache): Likewise.
8312 * term.c (term_mouse_position): Don't assume time_t wraparound.
8314 Be more systematic about user-interface timestamps.
8315 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8316 and sometimes 'EMACS_UINT', to represent these timestamps.
8317 This change causes it to use 'Time' uniformly, as that's what X uses.
8318 This makes the code easier to follow, and makes it easier to catch
8319 integer overflow bugs such as Bug#8664.
8320 * frame.c (Fmouse_position, Fmouse_pixel_position):
8321 Use Time, not unsigned long, for user-interface timestamps.
8322 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8323 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8324 * keyboard.h (last_event_timestamp): Likewise.
8325 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8326 * menu.h (xmenu_show): Likewise.
8327 * term.c (term_mouse_position): Likewise.
8328 * termhooks.h (struct input_event.timestamp): Likewise.
8329 (struct terminal.mouse_position_hook): Likewise.
8330 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8331 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8332 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8333 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8335 * menu.h, termhooks.h: Include "systime.h", for Time.
8337 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8338 Don't assume that the difference between two unsigned long values
8339 can fit into an integer. At this point, we know button_down_time
8340 <= event->timestamp, so the difference must be nonnegative, so
8341 there's no need to cast the result if double-click-time is
8342 nonnegative, as it should be; check that it's nonnegative, just in
8343 case. This bug is triggered when events are more than 2**31 ms
8344 apart (about 25 days). (Bug#8664)
8346 * xselect.c (last_event_timestamp): Remove duplicate decl.
8347 (x_own_selection): Remove needless cast to unsigned long.
8349 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8350 that always fit in int. Use a sentinel instead of a counter, to
8351 avoid a temp and to allay GCC's concerns about possible int overflow.
8352 * frame.h (struct frame): Use int for menu_bar_items_used
8353 instead of EMACS_INT, since it always fits in int.
8355 * menu.c (grow_menu_items): Check for int overflow.
8357 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8359 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8360 Before, the code was not consistent. These values cannot exceed
8361 2**31 - 1 so there's no need to make them unsigned.
8362 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8363 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8364 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8366 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8368 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8369 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8370 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8371 presumably because the widths might not match.
8373 * window.c (size_window): Avoid needless test at loop start.
8375 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8377 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8379 2011-05-12 Drew Adams <drew.adams@oracle.com>
8381 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8383 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8385 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8386 `width' to `bar_area_x' and `bar_area_width', respectively.
8387 (x_scroll_run): Take account of fringe background extension.
8389 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8390 Rename local vars `left' and `width' to `bar_area_x' and
8391 `bar_area_width', respectively.
8392 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8393 background extension.
8395 2011-05-10 Jim Meyering <meyering@redhat.com>
8397 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8399 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8401 * image.c (Finit_image_library): Return t for built-in image types,
8402 like pbm and xbm. (Bug#8640)
8404 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8406 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8408 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8410 * w32console.c (Fset_screen_color): Doc fix.
8411 (Fget_screen_color): New function.
8412 (syms_of_ntterm): Defsubr it.
8414 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8415 unlink the temporary file if Fcall_process didn't create it in the
8417 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8418 child process will be redirected to a file specified with `:file'.
8419 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8420 cue to call_process_cleanup not to close that handle.
8422 2011-05-07 Ben Key <bkey76@gmail.com>
8424 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8425 one of two shell specific rules, either bootstrap-temacs-CMD or
8426 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8427 to the previous implementation of the bootstrap-temacs rule.
8428 The bootstrap-temacs-CMD rule is similar to the previous
8429 implementation of the bootstrap-temacs rule except that it
8430 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8433 These changes, along with some changes to nt/configure.bat,
8434 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8435 earlier fix to add support for --cflags and --ldflags options
8436 that include quotes so that it works whether make uses cmd or
8439 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8441 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8442 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8444 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8445 a string. Handle both cases.
8446 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8447 (Fdbus_register_method): Use Qinvalid_function.
8449 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8451 * makefile.w32-in: Update dependencies.
8452 (LISP_H): Add inttypes.h and stdin.h.
8453 (PROCESS_H): Add unistd.h.
8455 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8457 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8458 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8460 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8462 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8464 * term.c (vfatal): Remove stray call to va_end.
8465 It's not needed and the C Standard doesn't allow it here anyway.
8467 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8468 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8470 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8473 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8475 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8477 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8479 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8481 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8483 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8484 * charset.c (Fdefine_charset_internal): Don't initialize
8485 charset.code_space[15]. The value was garbage, on hosts with
8486 32-bit int (Bug#8600).
8488 * lread.c (read_integer): Be more consistent with string-to-number.
8489 Use string_to_number to do the actual conversion; this avoids
8490 rounding errors and fixes some other screwups. Without this fix,
8491 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8492 (digit_to_number): Move earlier, for benefit of read_integer.
8493 Return -1 if the digit is out of range for the base, -2 if it is
8494 not a digit in any supported base. (Bug#8602)
8496 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8498 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8499 to match comment at start of function. This also removes a
8500 GCC warning about overflow in a 32+64-bit port.
8502 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8504 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8505 Reported by Stefan Monnier in
8506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8507 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8508 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8510 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8511 (EMACS_UINTPTR): Likewise, with uintptr_t.
8513 * lisp.h: Prefer 64-bit EMACS_INT if available.
8514 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8515 on 32-bit hosts that have 64-bit int, so that they can access
8517 However, temporarily disable this change unless the temporary
8518 symbol WIDE_EMACS_INT is defined.
8520 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8522 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8523 This removes an assumption that EMACS_INT and long are the same
8524 width as pointers. The assumption is true for Emacs porting targets
8525 now, but we want to make other targets possible.
8526 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8527 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8528 In the rest of the code, change types of integers that hold casted
8529 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8530 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8531 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8532 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8533 No need to cast type when ORing.
8534 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8535 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8536 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8537 assume EMACS_INT is the same width as char *.
8538 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8539 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8540 Remove no-longer-needed casts.
8541 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8542 (xg_tool_bar_help_callback, xg_make_tool_item):
8543 Use EMACS_INTPTR to hold an integer
8544 that will be cast to void *; this can avoid a GCC warning
8545 if EMACS_INT is not the same width as void *.
8546 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8547 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8548 (current_message_1, set_message_1):
8549 Use a local to convert to proper width without a cast.
8550 * xmenu.c (dialog_selection_callback): Likewise.
8552 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8553 Also, don't assume VALBITS / RAND_BITS is less than 5,
8554 and don't rely on undefined behavior when shifting a 1 left into
8556 * lisp.h (get_random): Change signature to match.
8558 * lread.c (hash_string): Use size_t, not int, for hash computation.
8559 Normally we prefer signed values; but hashing is special, because
8560 it's better to use unsigned division on hash table sizes so that
8561 the remainder is nonnegative. Also, size_t is the natural width
8562 for hashing into memory. The previous code used 'int', which doesn't
8563 retain enough info to hash well into very large tables.
8564 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8566 * dbusbind.c: Don't possibly lose pointer info when converting.
8567 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8568 Use XPNTR rather than XHASH, so that the high-order bits of
8569 the pointer aren't lost when converting through void *.
8571 * eval.c (Fautoload): Don't double-shift a pointer.
8573 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8575 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8577 * gnutls.c (DEF_GNUTLS_FN):
8578 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8580 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8582 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8585 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8587 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8588 New version that can reserve upto 2GB of heap space.
8590 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8592 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8594 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8596 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8597 `gnutls_certificate_set_x509_key_file'.
8599 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8601 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8602 Update dependencies.
8604 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8606 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8607 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8608 Remove unused parameter `fildes'.
8609 * process.c (read_process_output, send_process): Don't pass it.
8611 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8613 Fix previous change: the library cache is defined in w32.c.
8614 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8615 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8617 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8619 Implement dynamic loading of GnuTLS on Windows.
8621 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8622 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8623 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8626 * gnutls.c (Qgnutls_dll): Define.
8627 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8628 (gnutls_*): Declare function pointers.
8629 (init_gnutls_functions): New function to initialize function pointers.
8630 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8631 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8632 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8633 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8634 (emacs_gnutls_write, emacs_gnutls_read)
8635 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8636 (Fgnutls_available_p): New function.
8637 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8638 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8639 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8641 * image.c: Include w32.h.
8642 (Vimage_type_cache): Delete.
8643 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8644 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8645 (w32_delayed_load): Move to w32.c.
8647 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8649 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8650 (w32_delayed_load): Move from image.c. When loading a library, record
8651 its filename in the :loaded-from property of the library id.
8652 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8653 Initialize and staticpro them.
8654 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8656 * process.c: Include lisp.h before w32.h, not after.
8657 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8658 instead of gnutls_record_check_pending.
8660 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8662 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8664 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8665 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8668 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8670 * xterm.c (x_set_frame_alpha): Do not set property on anything
8671 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8673 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8675 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8677 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8679 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8680 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8681 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8682 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8683 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8684 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8685 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8686 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8687 (Qgnutls_bootprop_callbacks_verify): Make static.
8689 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8691 * callproc.c: Indentation fixup.
8693 * sysdep.c (wait_for_termination_1): Make static.
8694 (wait_for_termination, interruptible_wait_for_termination):
8695 Move after wait_for_termination_1.
8697 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8699 * sysdep.c (interruptible_wait_for_termination): New function
8700 which is like wait_for_termination, but allows keyboard
8703 * callproc.c (Fcall_process): Add (:file "file") as an option for
8705 (Fcall_process_region): Ditto.
8707 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8709 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8710 rather than `XVECTOR (FOO)->size'.
8712 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8713 inttypes.h, as a gnulib replacement is used if it not available in
8716 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8718 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8719 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8720 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8722 * coding.c (coding_alloc_by_realloc): Error out if destination
8723 will grow beyond MOST_POSITIVE_FIXNUM.
8724 (decode_coding_emacs_mule): Abort if there isn't enough place in
8725 charbuf for the composition carryover bytes. Reserve an extra
8726 space for up to 2 characters produced in a loop.
8727 (decode_coding_iso_2022): Abort if there isn't enough place in
8728 charbuf for the composition carryover bytes.
8730 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8732 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8733 aborting when %lld or %lll format is passed.
8734 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8735 %llo or %llx format is passed. (Bug#8545)
8737 * window.c (window_scroll_line_based): Use a marker instead of
8738 simple variables to record original value of point. (Bug#7952)
8740 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8741 produced by %s or %c overflows available buffer space. (Bug#8545)
8743 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8745 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8746 (SIZE_MAX): Move defn after all includes, as they might #define it.
8748 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8750 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8752 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8754 * keyboard.c (Qdelayed_warnings_hook): Define.
8755 (command_loop_1): Run `delayed-warnings-hook'
8756 if Vdelayed_warnings_list is non-nil.
8757 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8758 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8760 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8762 * doprnt.c (doprnt): Don't return value smaller than the buffer
8763 size if the message was truncated. (Bug#8545).
8765 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8767 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8768 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8770 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8772 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8774 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8776 * makefile.w32-in: Update dependencies.
8778 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8780 Improve `doprnt' and its usage. (Bug#8545)
8781 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8782 `format_end'. Remove support for %l as a conversion specifier.
8783 Don't use xrealloc. Improve diagnostics when the %l size modifier
8784 is used. Update the commentary.
8786 * eval.c (verror): Simplify calculation of size_t.
8788 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8791 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8793 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8796 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8798 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8799 This makes this file independent of the recent pseudovector change.
8801 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8803 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8805 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8806 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8807 Remove unused local.
8808 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8810 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8811 GCC 4.6.0 optimizes based on type-based alias analysis.
8812 For example, if b is of type struct buffer * and v of type struct
8813 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8814 != &v->size, and therefore "v->size = 1; b->size = 2; return
8815 v->size;" must therefore return 1. This assumption is incorrect
8816 for Emacs, since it type-puns struct Lisp_Vector * with many other
8817 types. To fix this problem, this patch adds a new type struct
8818 vectorlike_header that documents the constraints on layout of vectors
8819 and pseudovectors, and helps optimizing compilers not get fooled
8820 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8821 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8822 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8824 (XSETPVECTYPE): Rewrite in terms of new macro.
8825 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8826 This is a bit clearer, and further avoids the possibility of
8827 undesirable aliasing.
8828 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8829 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8830 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8831 since Lisp_Subr is a special case (no "next" field).
8832 (ASIZE): Now uses header.size rather than size.
8833 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8834 to avoid the hassle of writing XVECTOR (foo)->header.size.
8835 (struct vectorlike_header): New type.
8836 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8837 object, to help avoid aliasing.
8838 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8839 (SUBRP): Likewise, since Lisp_Subr is a special case.
8840 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8841 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8842 (struct Lisp_Hash_Table): Combine first two members into a single
8843 struct vectorlike_header member. All uses of "size" and "next" members
8844 changed to be "header.size" and "header.next".
8845 * buffer.h (struct buffer): Likewise.
8846 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8847 * frame.h (struct frame): Likewise.
8848 * process.h (struct Lisp_Process): Likewise.
8849 * termhooks.h (struct terminal): Likewise.
8850 * window.c (struct save_window_data, struct saved_window): Likewise.
8851 * window.h (struct window): Likewise.
8852 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8853 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8854 * buffer.c (init_buffer_once): Likewise.
8855 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8857 * process.c (Fformat_network_address): Use local var for size,
8860 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8862 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8863 * data.c (atof): Remove decl; no longer used or needed.
8864 (digit_to_number): Move to lread.c.
8865 (Fstring_to_number): Use new string_to_number function, to be
8866 consistent with how the Lisp reader treats infinities and NaNs.
8867 Do not assume that floating-point numbers represent EMACS_INT
8868 without losing information; this is not true on most 64-bit hosts.
8869 Avoid double-rounding errors, by insisting on integers when
8870 parsing non-base-10 numbers, as the documentation specifies.
8871 * lisp.h (string_to_number): New decl, replacing ...
8872 (isfloat_string): Remove.
8873 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8874 (read1): Do not accept +. and -. as integers; this
8875 appears to have been a coding error. Similarly, do not accept
8876 strings like +-1e0 as floating point numbers. Do not report
8877 overflow for integer overflows unless the base is not 10 which
8878 means we have no simple and reliable way to continue.
8879 Break out the floating-point parsing into a new
8880 function string_to_number, so that Fstring_to_number parses
8881 floating point numbers consistently with the Lisp reader.
8882 (digit_to_number): Move here from data.c. Make it static inline.
8883 (E_CHAR, EXP_INT): Remove, replacing with ...
8884 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8885 (string_to_number): New function, replacing isfloat_string.
8886 This function checks for valid syntax and produces the resulting
8887 Lisp float number too. Rework it so that string-to-number
8888 no longer mishandles examples like "1.0e+". Use strtoumax,
8889 so that overflow for non-base-10 numbers is reported only when
8890 there's no portable and simple way to convert to floating point.
8892 * textprop.c (set_text_properties_1): Rewrite for clarity,
8893 and to avoid GCC warning about integer overflow.
8895 * intervals.h (struct interval): Use EMACS_INT for members
8896 where EMACS_UINT might cause problems. See
8897 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8898 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8899 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8901 (offset_intervals): Tell GCC not to worry about length overflow
8902 when negating a negative length.
8904 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8905 (overrun_check_free): Likewise.
8907 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8908 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8911 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8912 (gnutls_make_error): Rename local to avoid shadowing.
8913 (gnutls_emacs_global_deinit): ifdef out; not used.
8914 (Fgnutls_boot): Use const for pointer to readonly storage.
8915 Comment out unused local. Fix pointer signedness problems.
8917 * lread.c (openp): Don't stuff size_t into an 'int'.
8918 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8919 about possible signed overflow.
8921 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8922 (GDK_KEY_g): Don't define if already defined.
8923 (xg_prepare_tooltip): Avoid pointer signedness problem.
8924 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8926 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8927 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8929 * xfns.c (Fx_window_property): Simplify a bit,
8930 to make a bit faster and to avoid GCC 4.6.0 warning.
8931 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8933 * fns.c (internal_equal): Don't assume size_t fits in int.
8935 * alloc.c (compact_small_strings): Tighten assertion a little.
8937 Replace pEd with more-general pI, and fix some printf arg casts.
8938 * lisp.h (pI): New macro, generalizing old pEd macro to other
8939 conversion specifiers. For example, use "...%"pI"d..." rather
8940 than "...%"pEd"...".
8941 (pEd): Remove. All uses replaced with similar uses of pI.
8942 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8943 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8944 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8945 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8946 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8947 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8948 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8950 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8951 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8952 * print.c (safe_debug_print, print_object): Likewise.
8953 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8955 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8956 avoiding the 0 flag, which is not portable.
8957 * process.c (Fmake_network_process): Use pI to avoid cast.
8958 * region-cache.c (pp_cache): Likewise.
8959 * xdisp.c (decode_mode_spec): Likewise.
8960 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8961 behavior on 64-bit hosts with printf arg.
8962 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8963 (x_stop_queuing_selection_requests): Likewise.
8964 (x_get_window_property): Don't truncate byte count to an 'int'
8967 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8968 here, since it parses constructs like leading '-' and spaces,
8969 which are not wanted; and it overflows with large numbers.
8970 Instead, simply match F[0-9]+, which is what is wanted anyway.
8972 * alloc.c: Remove unportable assumptions about struct layout.
8973 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8974 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8975 (allocate_vectorlike, make_pure_vector): Use the new macros,
8976 plus offsetof, to remove unportable assumptions about struct layout.
8977 These assumptions hold on all porting targets that I know of, but
8978 they are not guaranteed, they're easy to remove, and removing them
8979 makes further changes easier.
8981 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8982 This doesn't fix a bug but makes the code clearer.
8983 (string_overrun_cookie): Now const. Use initializers that
8984 don't formally overflow signed char, to avoid warnings.
8985 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8986 can cause Emacs to crash when string overrun checking is enabled.
8987 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8988 multiple of sizeof (EMACS_INT); it need not be, if
8989 alignof(EMACS_INT) < sizeof (EMACS_INT).
8990 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8992 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8994 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8996 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8998 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8999 supposed to be handshaking. (Bug#8556)
9000 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9002 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9004 * lisp.h (Qdebug): List symbol.
9005 * eval.c (Qdebug): Restore global linkage.
9006 * keyboard.c (debug-on-event): New variable.
9007 (handle_user_signal): Break into debugger when debug-on-event
9008 matches the current signal symbol.
9010 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9012 * alloc.c (check_sblock, check_string_bytes)
9013 (check_string_free_list): Convert to standard C.
9015 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9017 * w32.c (emacs_gnutls_push): Fix typo.
9019 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9021 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9022 "cast to pointer from integer of different size".
9024 Improve doprnt and its use in verror. (Bug#8545)
9025 * doprnt.c (doprnt): Document the set of format control sequences
9026 supported by the function. Use SAFE_ALLOCA instead of always
9029 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9030 is one byte too soon. Don't use xrealloc; instead xfree and
9033 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9035 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9038 * gnutls.c: Renamed global_initialized to
9039 gnutls_global_initialized. Added internals for the
9040 :verify-hostname-error, :verify-error, and :verify-flags
9041 parameters of `gnutls-boot' and documented those parameters in the
9042 docstring. Start callback support.
9043 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9044 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9045 on error. Return error code.
9046 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9047 (emacs_gnutls_read): Likewise.
9048 (Fgnutls_boot): Return handshake error code.
9049 (emacs_gnutls_handle_error): New function.
9050 (wsaerror_to_errno): Likewise.
9052 * w32.h (emacs_gnutls_pull): Add prototype.
9053 (emacs_gnutls_push): Likewise.
9055 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9056 (emacs_gnutls_push): Likewise.
9058 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9060 * process.c (wait_reading_process_output): Check if GnuTLS
9061 buffered some data internally if no FDs are set for TLS
9064 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9065 (LIBS): Link to USER_LIBS.
9066 ($(BLD)/gnutls.$(0)): New target.
9068 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9070 * xdisp.c (handle_single_display_spec): Rename the
9071 display_replaced_before_p argument into display_replaced_p, to
9072 make it consistent with the commentary. Fix typos in the
9075 * textprop.c (syms_of_textprop): Remove dead code.
9076 (copy_text_properties): Delete obsolete commentary about an
9077 interface that was deleted long ago. Fix typos in the description
9080 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9081 to changes in oldXMenu/XMenu.h from 2011-04-16.
9082 <menu_help_message, prev_menu_help_message>: Constify.
9083 (IT_menu_make_room): menu->help_text is now `const char **';
9086 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9087 to changes in oldXMenu/XMenu.h from 2011-04-16.
9088 (struct XMenu): Declare `help_text' `const char **'.
9090 * xfaces.c <Qunspecified>: Make extern again.
9092 * syntax.c: Include sys/types.h before including regex.h, as
9095 * doc.c (get_doc_string): Improve the format passed to `error'.
9097 * doprnt.c (doprnt): Improve commentary.
9099 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9101 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9104 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9105 changes in globals.h immediately force recompilation.
9106 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9107 $(CURDIR)/s/ms-w32.h.
9108 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9110 * character.c (Fchar_direction): Function deleted.
9111 (syms_of_character): Don't defsubr it.
9112 <char-direction-table>: Deleted.
9114 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9116 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9117 * doprnt.c: Include limits.h.
9118 (SIZE_MAX): New macro.
9119 (doprnt): Return a size_t value. 2nd arg is now size_t.
9120 Many local variables are now size_t instead of int or unsigned.
9121 Improve overflow protection. Support `l' modifier for integer
9122 conversions. Support %l conversion. Don't assume an EMACS_INT
9123 argument for integer conversions and for %c.
9125 * lisp.h (doprnt): Restore prototype.
9127 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9130 * Makefile.in (base_obj): Add back doprnt.o.
9132 * deps.mk (doprnt.o): Add back prerequisites.
9133 (callint.o): Depend on character.h.
9135 * eval.c (internal_lisp_condition_case): Include the handler
9136 representation in the error message.
9137 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9138 when breaking from the loop.
9140 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9142 * callint.c (Fcall_interactively): When displaying error message
9143 about invalid control letter, pass the character's codepoint, not
9144 a pointer to its multibyte form. Improve display of the character
9145 in octal and display also its hex code.
9147 * character.c (char_string): Use %x to display the (unsigned)
9148 codepoint of an invalid character, to avoid displaying a bogus
9151 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9152 `error', not SYMBOL_NAME itself.
9154 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9155 character arguments to `error'.
9157 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9158 to `error' in error message about FINAL_CHAR argument. Make sure
9159 FINAL_CHAR is a character, and use %c when it is passed as
9160 argument to `error'.
9162 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9164 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9166 * w32.c: Include <time.h>.
9167 (sys_localtime): New function.
9169 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9171 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9173 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9175 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9177 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9180 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9182 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9183 gl_state.e_property when gl_state.object is Qt.
9185 * insdel.c (make_gap_larger): Remove limitation of buffer size
9188 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9190 * xdisp.c (lookup_glyphless_char_display)
9191 (produce_glyphless_glyph): Handle cons cell entry in
9192 glyphless-char-display.
9193 (Vglyphless_char_display): Document it.
9195 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9196 glyphless-char-display.
9198 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9200 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9202 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9204 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9205 definition for no-X builds.
9207 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9209 Static checks with GCC 4.6.0 and non-default toolkits.
9211 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9213 * process.c (keyboard_bit_set): Define only if SIGIO.
9214 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9215 (send_process): Repair possible setjmp clobbering.
9217 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9219 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9221 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9223 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9224 Define only if needed.
9226 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9227 by pacifying GCC about it. Maybe it's time to retire it?
9228 * xfaces.c (USG, __TIMEVAL__): Likewise.
9230 * dispextern.h (struct redisplay_interface): Rename param
9232 * termhooks.h (struct terminal): Likewise.
9233 * xterm.c (xembed_send_message): Likewise.
9235 * insdel.c (make_gap_smaller): Define only if
9236 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9238 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9241 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9242 so that we aren't warned about unused symbols.
9244 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9246 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9248 * xfns.c (x_real_positions): Mark locals as initialized.
9250 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9252 * xterm.c: Fix problems found by static analysis with other toolkits.
9253 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9254 (x_dispatch_event): Declare static if USE_GTK, and
9255 define if USE_GTK || USE_X_TOOLKIT.
9256 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9257 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9258 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9259 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9261 * xmenu.c (menu_help_callback): Pointer type fixes.
9262 Use const pointers when pointing at readonly data. Avoid pointer
9264 (FALSE): Remove unused macro.
9265 (update_frame_menubar): Remove unused decl.
9267 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9269 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9270 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9271 (single_menu_item): Rename local to avoid shadowing.
9273 * keyboard.c (make_lispy_event): Remove unused local var.
9275 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9276 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9278 * bitmaps: Change bitmaps from unsigned char back to the X11
9279 compatible char. Avoid the old compiler warnings about
9280 out-of-range initializers by using, for example, '\xab' rather
9283 * xgselect.c (xgselect_initialize): Check vs interface
9284 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9286 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9288 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9289 to read-only memory.
9291 * fns.c (vector): Remove; this old hack is no longer needed.
9293 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9295 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9297 * xrdb.c (x_load_resources): Omit unused local.
9299 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9300 (x_window): Rename locals to avoid shadowing.
9301 (USG): Use the kludged USG macro, to pacify gcc.
9303 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9304 (x_term_init): Remove local to avoid shadowing.
9306 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9308 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9309 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9311 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9313 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9315 Fix regex.c, syntax.c and friends for buffers > 2GB.
9316 * syntax.h (struct gl_state_s): Declare character position members
9319 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9321 * textprop.c (verify_interval_modification, interval_of):
9322 Declare arguments EMACS_INT.
9324 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9327 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9329 * indent.c (Fvertical_motion): Local variable it_start is now
9332 * regex.c (re_match, re_match_2, re_match_2_internal)
9333 (bcmp_translate, regcomp, regexec, print_double_string)
9334 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9335 (re_compile_pattern, re_exec): Declare arguments and local
9336 variables `size_t' and `ssize_t' and return values `regoff_t', as
9338 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9339 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9340 <compile_stack_type>: `size' and `avail' are now `size_t'.
9342 * regex.h <regoff_t>: Use ssize_t, not int.
9343 (re_search, re_search_2, re_match, re_match_2): Arguments that
9344 specify buffer/string position and length are now ssize_t and
9345 size_t. Return type is regoff_t.
9347 2011-04-16 Ben Key <bkey76@gmail.com>
9349 * nsfont.m: Fixed bugs in ns_get_family and
9350 ns_descriptor_to_entity that were caused by using free to
9351 deallocate memory blocks that were allocated by xmalloc (via
9352 xstrdup). This caused Emacs to crash when compiled with
9353 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9354 --enable-checking=xmallocoverrun). xfree is now used to
9355 deallocate these memory blocks.
9357 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9359 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9361 emacs_write: Accept and return EMACS_INT for sizes.
9362 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9364 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9365 Accept and return EMACS_INT.
9366 (emacs_gnutls_write): Return the number of bytes written on
9368 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9369 (emacs_read, emacs_write): Remove check for negative size, as the
9370 Emacs source code has been audited now.
9371 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9372 (emacs_read, emacs_write): Use it.
9373 * process.c (send_process): Adjust to the new signatures of
9374 emacs_write and emacs_gnutls_write. Do not attempt to store
9375 a byte offset into an 'int'; it might overflow.
9376 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9378 * sound.c: Don't assume sizes fit in 'int'.
9379 (struct sound_device.period_size, alsa_period_size):
9380 Return EMACS_INT, not int.
9381 (struct sound_device.write, vox_write, alsa_write):
9382 Accept EMACS_INT, not int.
9383 (wav_play, au_play): Use EMACS_INT to store sizes and to
9384 record read return values.
9386 2011-04-15 Ben Key <bkey76@gmail.com>
9388 * keyboard.c (Qundefined): Don't declare static since it is used
9390 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9391 static since they are used in nsfont.m.
9393 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9395 * process.c (Qprocessp): Don't declare static.
9396 * lisp.h (Qprocessp): Declare again.
9398 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9400 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9402 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9404 Improve C-level modularity by making more things 'static'.
9406 Don't publish debugger-only interfaces to other modules.
9407 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9408 (verify_bytepos, count_markers): Move decls to the only modules
9410 * region-cache.h (pp_cache): Likewise.
9411 * window.h (check_all_windows): Likewise.
9412 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9414 * sysdep.c (croak): Now static, if
9415 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9416 * syssignal.h (croak): Declare only if not static.
9418 * alloc.c (refill_memory_reserve): Now static if
9419 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9420 * lisp.h (refill_memory_reserve): Declare only if not static.
9422 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9423 Define only if USE_LUCID.
9425 * xrdb.c (x_customization_string, x_rm_string): Now static.
9427 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9428 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9430 * xdisp.c (draw_row_with_mouse_face): Now static.
9431 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9433 * window.h (check_all_windows): Mark externally visible.
9435 * window.c (window_deletion_count): Now static.
9437 * undo.c: Make symbols static if they're not exported.
9438 (last_undo_buffer, last_boundary_position, pending_boundary):
9441 * textprop.c (interval_insert_behind_hooks): Now static.
9442 (interval_insert_in_front_hooks): Likewise.
9444 * term.c: Make symbols static if they're not exported.
9445 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9446 (max_frame_lines, tty_set_terminal_modes):
9447 (tty_reset_terminal_modes, tty_turn_off_highlight):
9448 (get_tty_terminal): Now static.
9449 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9450 * termhooks.h (term_mouse_moveto): Do not declare if
9452 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9453 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9455 * sysdep.c: Make symbols static if they're not exported.
9456 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9458 (sigprocmask_set, full_mask): Remove; unused.
9459 (wait_debugging): Mark as visible.
9460 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9461 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9463 * syntax.c (syntax_temp): Define only if !__GNUC__.
9465 * sound.c (current_sound_device, current_sound): Now static.
9467 * search.c (searchbufs, searchbuf_head): Now static.
9469 * scroll.c (scroll_cost): Remove; unused.
9470 * dispextern.h (scroll_cost): Remove decl.
9472 * region-cache.h (pp_cache): Mark as externally visible.
9474 * process.c: Make symbols static if they're not exported.
9475 (process_tick, update_tick, create_process, chan_process):
9476 (Vprocess_alist, proc_buffered_char, datagram_access):
9477 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9478 (deactivate_process): Mark defn as static, as well as decl.
9479 * lisp.h (create_process): Remove decl.
9480 * process.h (chan_process, Vprocess_alist): Remove decls.
9482 * print.c: Make symbols static if they're not exported.
9483 (print_depth, new_backquote_output, being_printed, print_buffer):
9484 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9485 (print_interval, print_number_index, initial_stderr_stream):
9487 * lisp.h (Fprinc): Remove decl.
9488 (debug_output_compilation_hack): Mark as externally visible.
9490 * sysdep.c (croak): Move decl from here to syssignal.h.
9491 * syssignal.h (croak): Put it here, so the API can be checked when
9492 'croak' is called from dissociate_if_controlling_tty.
9494 * minibuf.c: Make symbols static if they're not exported.
9495 (minibuf_save_list, choose_minibuf_frame): Now static.
9496 * lisp.h (choose_minibuf_frame): Remove decl.
9498 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9500 * lread.c: Make symbols static if they're not exported.
9501 (read_objects, initial_obarray, oblookup_last_bucket_number):
9503 (make_symbol): Remove; unused.
9504 * lisp.h (initial_obarray, make_symbol): Remove decls.
9506 * keyboard.c: Make symbols static if they're not exported.
9507 (single_kboard, recent_keys_index, total_keys, recent_keys):
9508 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9509 (this_single_command_key_start, echoing, last_auto_save):
9510 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9511 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9512 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9513 (Vlispy_mouse_stem, double_click_count):
9515 (force_auto_save_soon): Define only if SIGDANGER.
9516 (ignore_mouse_drag_p): Now static if
9517 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9518 (print_help): Remove; unused.
9519 (stop_character, last_timer_event): Mark as externally visible.
9520 * keyboard.h (ignore_mouse_drag_p): Declare only if
9521 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9522 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9523 * lisp.h (echoing): Remove decl.
9524 (force_auto_save_soon): Declare only if SIGDANGER.
9525 * xdisp.c (redisplay_window): Simplify code, to make it more
9526 obvious that ignore_mouse_drag_p is not accessed if !defined
9527 USE_GTK && !defined HAVE_NS.
9529 * intervals.c: Make symbols static if they're not exported.
9530 (merge_properties_sticky, merge_interval_right, delete_interval):
9532 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9534 * insdel.c: Make symbols static if they're not exported.
9535 However, leave prepare_to_modify_buffer alone. It's never
9536 called from outside this function, but that appears to be a bug.
9537 (combine_after_change_list, combine_after_change_buffer):
9538 (adjust_after_replace, signal_before_change): Now static.
9539 (adjust_after_replace_noundo): Remove; unused.
9540 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9541 (signal_before_change): Remove decls.
9543 * indent.c (val_compute_motion, val_vmotion): Now static.
9545 * image.c: Make symbols static if they're not exported.
9546 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9548 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9549 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9551 * fringe.c (standard_bitmaps): Now static.
9552 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9554 * frame.c: Make symbols static if they're not exported.
9555 (x_report_frame_params, make_terminal_frame): Now static.
9556 (get_frame_param): Now static, unless HAVE_NS.
9557 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9558 (x_get_resource_string): Remove; not used.
9559 * frame.h (make_terminal_frame, x_report_frame_params):
9560 (x_get_resource_string); Remove decls.
9561 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9562 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9564 * font.c, fontset.c: Make symbols static if they're not exported.
9565 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9566 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9567 * font.c (font_close_object): Now static.
9568 * font.h (font_close_object): Remove.
9569 * fontset.c (FONTSET_OBJLIST): Remove.
9570 (free_realized_fontset) #if-0 the body, which does nothing.
9571 (face_suitable_for_char_p): #if-0, as it's never called.
9572 * fontset.h (face_suitable_for_char_p): Remove decl.
9573 * xfaces.c (face_at_string_position):
9574 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9575 since 0 is always ASCII.
9577 * fns.c (weak_hash_tables): Now static.
9579 * fileio.c: Make symbols static if they're not exported.
9580 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9581 (Vwrite_region_annotation_buffers): Now static.
9583 * eval.c: Make symbols static if they're not exported.
9584 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9585 * lisp.h (backtrace_list): Remove decl.
9587 * emacs.c: Make symbols static if they're not exported.
9588 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9589 (fatal_error_code, fatal_error_signal_hook, standard_args):
9591 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9592 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9593 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9594 * lisp.h (fatal_error_signal_hook): Remove decl.
9595 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9597 * editfns.c: Move a (normally-unused) function to its only use.
9598 * editfns.c, lisp.h (get_operating_system_release): Remove.
9599 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9600 worth the hassle of breaking this out.
9602 * xterm.c: Make symbols static if they're not exported.
9603 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9604 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9605 (x_destroy_window, x_delete_display):
9607 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9608 (x_mouse_leave): Remove; unused.
9609 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9610 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9611 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9613 (x_mouse_leave): Declare only if WINDOWSNT.
9614 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9615 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9618 * ftxfont.c: Make symbols static if they're not exported.
9619 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9621 * font.h (ftxfont_driver): Likewise.
9623 * xfns.c: Make symbols static if they're not exported.
9624 (x_last_font_name, x_display_info_for_name):
9625 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9626 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9627 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9628 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9629 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9630 (last_show_tip_args): Now static.
9631 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9632 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9633 (x_screen_planes): Remove; unused.
9634 * dispextern.h (x_screen_planes): Remove decl.
9636 * dispnew.c: Make symbols static if they're not exported.
9637 * dispextern.h (redraw_garbaged_frames, scrolling):
9638 (increment_row_positions): Remove.
9639 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9640 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9642 (redraw_garbaged_frames): Remove; unused.
9644 * xfaces.c: Make symbols static if they're not exported.
9645 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9647 * xterm.h (defined_color): Remove decls.
9648 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9649 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9650 (menu_face_changed_default, defined_color, free_realized_face):
9651 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9652 (ascii_face_of_lisp_face): Remove; unused.
9654 * xdisp.c: Make symbols static if they're not exported.
9655 * dispextern.h (scratch_glyph_row, window_box_edges):
9656 (glyph_to_pixel_coords, set_cursor_from_row):
9657 (get_next_display_element, set_iterator_to_next):
9658 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9659 (show_mouse_face): Remove decls
9660 * frame.h (message_buf_print): Likewise.
9661 * lisp.h (pop_message, set_message, check_point_in_composition):
9663 * xterm.h (set_vertical_scroll_bar): Likewise.
9664 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9665 (message_buf_print, scratch_glyph_row, displayed_buffer):
9666 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9667 (get_next_display_element, show_mouse_face, window_box_edges):
9668 (frame_to_window_pixel_xy, check_point_in_composition):
9669 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9670 (glyph_to_pixel_coords): Remove; unused.
9672 * dired.c (file_name_completion): Now static.
9674 * dbusbind.c (xd_in_read_queued_messages): Now static.
9676 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9677 * data.c (circular_list_error): Remove.
9679 * commands.h (last_point_position, last_point_position_buffer):
9680 (last_point_position_window): Remove decls.
9681 * keyboard.c: Make these variables static.
9683 * coding.h (coding, code_convert_region, encode_coding_gap):
9685 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9686 (iso_code_class, detect_coding, code_convert_region): Now static.
9687 (encode_coding_gap): Remove; unused.
9689 * chartab.c (chartab_chars, chartab_bits): Now static.
9691 * charset.h (charset_iso_8859_1): Remove decl.
9692 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9695 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9696 * ccl.c (Vccl_program_table): Now static.
9697 (check_ccl_update): Remove; unused.
9699 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9700 * category.h: ... from here.
9701 * category.c (check_category_table, set_category_set): Now static.
9703 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9704 * lisp.h: Remove these decls.
9706 * buffer.c (buffer_count): Remove unused var.
9708 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9709 so that it's not optimized away.
9710 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9711 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9712 exported only to the debugger.
9714 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9715 * atimer.h (run_all_atimers): Remove; not exported.
9717 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9718 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9719 was inaccessible from Lisp.
9720 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9721 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9723 alloc.c: Import and export fewer symbols, and remove unused items.
9724 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9726 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9727 it's not optimized away by whole-program optimization.
9728 (message_enable_multibyte, free_misc): Remove.
9729 (catchlist, handlerlist, mark_backtrace):
9730 Declare only if BYTE_MARK_STACK.
9731 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9732 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9733 (message_enable_multibyte): Remove decl.
9734 (free_misc, interval_free_list, float_block, float_block_index):
9735 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9736 (cons_free_list, last_marked_index):
9738 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9739 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9740 (mark_backtrace): Define only if BYTE_MARK_STACK.
9741 * xdisp.c (message_enable_multibyte): Now static.
9743 Declare Lisp_Object Q* variables to be 'static' if not exported.
9744 This makes it easier for human readers (and static analyzers)
9745 to see whether these variables are used from other modules.
9746 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9747 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9748 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9749 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9750 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9751 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9752 * xmenu.c, xselect.c:
9753 Declare Q* vars static if they are not used in other modules.
9754 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9755 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9756 Remove decls of unexported vars.
9757 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9759 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9761 Make Emacs functions such as Fatom 'static' by default.
9762 This makes it easier for human readers (and static analyzers)
9763 to see whether these functions can be called from other modules.
9764 DEFUN now defines a static function. To make the function external
9765 so that it can be used in other C modules, use the new macro DEFUE.
9766 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9767 (Finit_image_library):
9768 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9769 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9770 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9771 Remove decls, since these functions are now static.
9772 (Funintern, Fget_internal_run_time): New decls, since these functions
9773 were already external.
9775 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9776 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9777 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9778 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9779 * keyboard.c, keymap.c, lread.c:
9780 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9781 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9782 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9783 Mark functions with DEFUE instead of DEFUN,
9784 if they are used in other modules.
9785 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9786 decls for now-static functions.
9787 * buffer.h (Fdelete_overlay): Remove decl.
9788 * callproc.c (Fgetenv_internal): Mark as internal.
9789 * composite.c (Fremove_list_of_text_properties): Remove decl.
9790 (Fcomposition_get_gstring): New forward static decl.
9791 * composite.h (Fcomposite_get_gstring): Remove decl.
9792 * dired.c (Ffile_attributes): New forward static decl.
9793 * doc.c (Fdocumntation_property): New forward static decl.
9794 * eval.c (Ffetch_bytecode): New forward static decl.
9795 (Funintern): Remove extern decl; now in .h file where it belongs.
9796 * fileio.c (Fmake_symbolic_link): New forward static decl.
9797 * image.c (Finit_image_library): New forward static decl.
9798 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9799 * intervals.h (Fprevious_property_change):
9800 (Fremove_list_of_text_properties): Remove decls.
9801 * keyboard.c (Fthis_command_keys): Remove decl.
9802 (Fcommand_execute): New forward static decl.
9803 * keymap.c (Flookup_key): New forward static decl.
9804 (Fcopy_keymap): Now static.
9805 * keymap.h (Flookup_key): Remove decl.
9806 * process.c (Fget_process): New forward static decl.
9807 (Fprocess_datagram_address): Mark as internal.
9808 * syntax.c (Fsyntax_table_p): New forward static decl.
9809 (skip_chars): Remove duplicate decl.
9810 * textprop.c (Fprevious_property_change): New forward static decl.
9811 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9813 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9814 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9816 * editfns.c (Fformat): Remove unreachable code.
9818 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9820 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9823 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9825 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9826 when at ZV. (Bug#8487)
9828 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9830 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9832 * keyboard.c (parse_tool_bar_item): Likewise.
9833 * sound.c (sound_cleanup, alsa_close): Likewise.
9834 * termcap.c (tgetent): Likewise.
9835 * xfns.c (x_default_font_parameter): Likewise.
9836 * xsettings.c (read_and_apply_settings): Likewise.
9838 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9839 (overrun_check_free): Protoize.
9841 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9843 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9844 since callers should never pass a negative size.
9845 Change the signature to match that of plain 'read' and 'write'; see
9846 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9847 * lisp.h: Update prototypes of emacs_write and emacs_read.
9849 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9851 * xdisp.c (redisplay_window): Don't try to determine the character
9852 position of the scroll margin if the window start point w->startp
9853 is outside the buffer's accessible region. (Bug#8468)
9855 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9857 Fix write-region and its subroutines for buffers > 2GB.
9858 * fileio.c (a_write, e_write): Modify declaration of arguments and
9859 local variables to support buffers larger than 2GB.
9860 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9862 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9863 argument, local variables, and return value.
9865 * lisp.h: Update prototypes of emacs_write and emacs_read.
9867 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9869 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9871 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9873 Fix more problems found by GCC 4.6.0's static checks.
9875 * xdisp.c (vmessage): Use a better test for character truncation.
9877 * charset.c (load_charset_map): <, not <=, for optimization,
9878 and to avoid potential problems with integer overflow.
9879 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9880 * casetab.c (set_identity, shuffle): Likewise.
9881 * editfns.c (Fformat): Likewise.
9882 * syntax.c (skip_chars): Likewise.
9884 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9885 This also lets GCC 4.6.0 generate slightly better loop code.
9887 * callint.c (Fcall_interactively): <, not <=, for optimization.
9888 (Fcall_interactively): Count the number of arguments produced,
9889 not the number of arguments given. This is simpler and lets GCC
9890 4.6.0 generate slightly better code.
9892 * ftfont.c: Distingish more carefully between FcChar8 and char.
9893 The previous code passed unsigned char * to a functions like
9894 strlen and xstrcasecmp that expect char *, which does not
9895 conform to the C standard.
9896 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9897 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9898 char * when the C standard requires it.
9900 * keyboard.c (read_char): Remove unused var.
9902 * eval.c: Port to Windows vsnprintf (Bug#8435).
9904 (SIZE_MAX): Define if the headers do not.
9905 (verror): Do not give up if vsnprintf returns a negative count.
9906 Instead, grow the buffer. This ports to Windows vsnprintf, which
9907 does not conform to C99. Problem reported by Eli Zaretskii.
9908 Also, simplify the allocation scheme, by avoiding the need for
9909 calling realloc, and removing the ALLOCATED variable.
9911 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9913 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9914 But keep the doprint source code for now, as we might revamp it
9915 and use it again (Bug#8435).
9916 * lisp.h (doprnt): Remove.
9917 * Makefile.in (base_obj): Remove doprnt.o.
9918 * deps.mk (doprnt.o): Remove.
9920 error: Print 32- and 64-bit integers portably (Bug#8435).
9921 Without this change, on typical 64-bit hosts error ("...%d...", N)
9922 was used to print both 32- and 64-bit integers N, which relied on
9924 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9925 * lisp.h (error, verror): Mark as printf-like functions.
9926 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9927 Report overflow in size calculations when allocating printf buffer.
9928 Do not truncate output string at its first null byte.
9929 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9930 Truncate the output at a character boundary, since vsnprintf does not
9932 * charset.c (check_iso_charset_parameter): Convert internal
9933 character to string before calling 'error', since %c now has the
9935 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9936 overflow when computing char to be passed to 'error'. Do not
9937 pass Lisp_Object to 'error'; pass the integer instead.
9938 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9939 formatted with plain %d.
9941 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9943 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9945 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9947 * xterm.c (x_catch_errors): Remove duplicate declaration.
9949 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9951 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9953 2011-04-10 Jim Meyering <meyering@redhat.com>
9955 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9956 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9957 return ssize_t not "int", and use size_t as the buffer length.
9958 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9959 * gnutls.h: Update declarations.
9960 * process.c (read_process_output): Use ssize_t, to match.
9961 (send_process): Likewise.
9963 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9965 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9967 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9969 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9970 Use unsigned char, to match FcChar8 type definition.
9972 * xterm.c (handle_one_xevent):
9973 * xmenu.c (create_and_show_popup_menu):
9974 * xselect.c (x_decline_selection_request)
9975 (x_reply_selection_request): Avoid type-punned deref of X events.
9977 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9979 Fix some uses of `int' instead of EMACS_INT.
9980 * search.c (string_match_1, fast_string_match)
9981 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9982 (scan_buffer, find_next_newline_no_quit)
9983 (find_before_next_newline, search_command, Freplace_match)
9984 (Fmatch_data): Make some `int' variables be EMACS_INT.
9986 * xdisp.c (display_count_lines): 3rd argument and return value now
9987 EMACS_INT. All callers changed.
9988 (pint2hrstr): Last argument is now EMACS_INT.
9990 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9991 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9992 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9993 (decode_coding_utf_16, decode_coding_emacs_mule)
9994 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9995 (decode_coding_ccl, decode_coding_charset)
9996 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9997 (decode_coding_iso_2022, decode_coding_emacs_mule)
9998 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9999 <char_offset, last_offset>: Declare EMACS_INT.
10000 (encode_coding_utf_8, encode_coding_utf_16)
10001 (encode_coding_emacs_mule, encode_invocation_designation)
10002 (encode_designation_at_bol, encode_coding_iso_2022)
10003 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10004 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10006 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10007 (encode_invocation_designation): Last argument P_NCHARS is now
10009 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10010 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10012 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10015 * ccl.c (Fccl_execute_on_string): Declare some variables
10018 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10020 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10022 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10024 * process.c (Fformat_network_address): Doc fix.
10026 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10028 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10030 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10032 * keyboard.c (read_char): Call Lisp function help-form-show,
10033 instead of using internal_with_output_to_temp_buffer.
10034 (Qhelp_form_show): New var.
10035 (syms_of_keyboard): Use DEFSYM macro.
10037 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10039 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10041 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10043 * process.c (Flist_processes): Remove to Lisp.
10044 (list_processes_1): Delete.
10046 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10048 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10050 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10052 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10054 Fix more problems found by GCC 4.6.0's static checks.
10056 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10058 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10060 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10062 * xdisp.c (vmessage): Mark as a printf-like function.
10064 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10066 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10068 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10069 printf-like functions.
10070 (tiff_load): Add casts to remove these marks before passing them
10071 to system-supplied API.
10073 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10075 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10076 This avoids several warnings with gcc -Wstrict-overflow.
10077 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10078 directly, rather than having caller test rule sign. This avoids
10079 some unnecessary tests.
10080 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10081 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10082 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10084 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10085 (xfont_open): Avoid unnecessary tests.
10087 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10089 * composite.h, composite.c (composition_gstring_put_cache):
10090 Use EMACS_INT, not int, for length.
10092 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10093 breaking out part of COMPOSITION_DECODE_RULE.
10094 (COMPOSITION_DECODE_RULE): Use it.
10095 * composite.c (get_composition_id): Remove unused local vars,
10096 by using the new macro.
10098 * textprop.c (set_text_properties_1): Change while to do-while,
10099 since the condition is always true at first.
10101 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10102 (interval_deletion_adjustment): Return unsigned value.
10105 * process.c (list_processes_1, create_pty, read_process_output):
10106 (exec_sentinel): Remove vars that were set but not used.
10107 (create_pty): Remove unnecessary "volatile"s.
10108 (Fnetwork_interface_info): Avoid possibility of int overflow.
10109 (read_process_output): Do adaptive read buffering even if carryover.
10110 (read_process_output): Simplify nbytes computation if buffered.
10112 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10114 * syntax.c (scan_words): Remove var that was set but not used.
10115 (update_syntax_table): Use unsigned instead of int.
10117 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10118 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10119 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10121 * print.c (print_error_message): Avoid int overflow.
10123 * font.c (font_list_entities): Redo for clarity,
10124 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10126 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10127 (font_score): Avoid potential overflow in diff calculation.
10129 * fns.c (substring_both): Remove var that is set but not used.
10130 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10132 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10134 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10135 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10136 can always succeed if overflow has undefined behavior.
10138 * search.c (boyer_moore, wordify): Remove vars set but not used.
10139 (wordify): Omit three unnecessary tests.
10141 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10142 All callers changed. This avoids the need for an unused var.
10144 * casefiddle.c (casify_region): Remove var that is set but not used.
10146 * dired.c (file_name_completion): Remove var that is set but not used.
10148 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10150 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10151 (Finsert_file_contents): Remove unnecessary code checking fd.
10153 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10154 Check for integer overflow on size calculations.
10156 * buffer.c (Fprevious_overlay_change): Remove var that is set
10159 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10160 Remove vars that are set but not used.
10161 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10162 (timer_check_2): Mark vars as initialized.
10164 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10166 * image.c (lookup_image): Remove var that is set but not used.
10167 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10169 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10170 that are set but not used.
10172 * xfns.c (make_invisible_cursor): Don't return garbage
10173 if XCreateBitmapFromData fails (Bug#8410).
10175 * xselect.c (x_get_local_selection, x_handle_property_notify):
10176 Remove vars that are set but not used.
10178 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10179 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10181 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10182 Remove var that is set but not used.
10183 (scroll_bar_windows_size): Now size_t, not int.
10184 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10185 Check for overflow.
10187 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10188 (map_tty_color) [!defined MSDOS]: Likewise.
10190 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10192 * coding.c: Remove vars that are set but not used.
10193 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10194 All callers changed.
10195 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10196 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10197 (decode_coding_charset): Remove vars that are set but not used.
10199 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10200 that is set but not used.
10202 * print.c (print_object): Remove var that is set but not used.
10204 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10205 The gnulib version avoids calling malloc in the usual case,
10206 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10207 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10208 * filelock.c (current_lock_owner): Likewise.
10209 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10210 * sysdep.c: Include allocator.h, careadlinkat.h.
10211 (emacs_no_realloc_allocator): New static constant.
10212 (emacs_readlink): New function.
10213 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10214 ../lib/careadlinkat.h.
10216 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10218 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10219 first non-nil return value).
10221 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10223 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10224 if not defined (Bug#8403).
10226 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10228 * xdisp.c (display_count_lines): Remove parameter `start',
10229 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10230 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10231 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10232 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10233 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10234 and thereabouts. All callers changed.
10235 (get_per_char_metric): Remove parameter `f', unused since
10236 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10238 2011-04-02 Jim Meyering <meyering@redhat.com>
10240 do not dereference NULL upon failed strdup
10241 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10242 (ns_get_family): Likewise.
10244 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10246 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10248 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10250 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10253 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10255 Add lexical binding.
10257 * window.c (Ftemp_output_buffer_show): New fun.
10258 (Fsave_window_excursion):
10259 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10261 * lread.c (lisp_file_lexically_bound_p): New function.
10262 (Fload): Bind Qlexical_binding.
10263 (readevalloop): Remove `evalfun' arg.
10264 Bind Qinternal_interpreter_environment.
10265 (Feval_buffer): Bind Qlexical_binding.
10266 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10268 (syms_of_lread): Declare `lexical-binding'.
10270 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10272 * keyboard.c (eval_dyn): New fun.
10273 (menu_item_eval_property): Use it.
10275 * image.c (parse_image_spec): Use Ffunctionp.
10277 * fns.c (concat, mapcar1): Accept byte-code-functions.
10279 * eval.c (Fsetq): Handle lexical vars.
10280 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10281 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10282 (FletX, Flet): Obey lexical binding.
10283 (Fcommandp): Handle closures.
10284 (Feval): New `lexical' arg.
10285 (eval_sub): New function extracted from Feval. Use it almost
10286 everywhere where Feval was used. Look up vars in lexical env.
10288 (Ffunctionp): Move from subr.el.
10289 (Ffuncall): Handle closures.
10290 (apply_lambda): Remove `eval_flags'.
10291 (funcall_lambda): Handle closures and new byte-code-functions.
10292 (Fspecial_variable_p): New function.
10293 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10294 but without exporting it to Lisp.
10296 * doc.c (Fdocumentation, store_function_docstring):
10297 * data.c (Finteractive_form): Handle closures.
10299 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10302 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10304 (exec_byte_code): New function extracted from Fbyte_code to handle new
10305 calling convention for byte-code-functions. Add new byte-codes.
10307 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10309 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10311 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10313 * xdisp.c (redisplay_internal): Fix prototype.
10315 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10317 * xdisp.c (SCROLL_LIMIT): New macro.
10318 (try_scrolling): Use it when setting scroll_limit.
10319 Limit scrolling to 100 screen lines.
10320 (redisplay_window): Even when falling back on "recentering",
10321 position point in the window according to scroll-conservatively,
10322 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10324 (try_scrolling): When point is above the window, allow searching
10325 as far as scroll_max, or one screenful, to compute vertical
10326 distance from PT to the scroll margin position. This prevents
10327 try_scrolling from unnecessarily failing when
10328 scroll-conservatively is set to a value slightly larger than the
10329 window height. Clean up the case of PT below the margin at bottom
10330 of window: scroll_max can no longer be INT_MAX. When aggressive
10331 scrolling is in use, don't let point enter the opposite scroll
10332 margin as result of the scroll.
10333 (syms_of_xdisp) <scroll-conservatively>: Document the
10334 threshold of 100 lines for never-recentering scrolling.
10336 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10338 * dispextern.h (move_it_by_lines):
10339 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10340 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10341 (message_log_check_duplicate): Remove parameters `prev_bol' and
10342 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10343 (redisplay_internal): Remove parameter `preserve_echo_area',
10344 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10346 * indent.c (Fvertical_motion):
10347 * window.c (window_scroll_pixel_based, Frecenter):
10348 Don't pass `need_y_p' to `move_it_by_lines'.
10350 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10352 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10353 steal a few bits to be more compact.
10354 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10355 Remove unneeded casts.
10357 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10359 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10361 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10362 binding" message (bug#7967).
10364 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10366 Fix more problems found by GCC 4.6.0's static checks.
10368 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10369 Remove unused local var.
10371 * editfns.c (Fmessage_box): Remove unused local var.
10373 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10374 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10375 Omit unused local vars.
10376 * window.c (shrink_windows): Omit unused local var.
10377 * menu.c (digest_single_submenu): Omit unused local var.
10378 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10379 Omit unused local var.
10381 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10382 Don't assume string length fits in int.
10383 (keyremap_step, read_key_sequence): Use size_t for sizes.
10384 (read_key_sequence): Don't check last_real_key_start redundantly.
10386 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10387 instead of alloca (Bug#8344).
10389 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10390 (Fbacktrace_frame): Don't assume nframes fits in int.
10392 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10394 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10397 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10399 * cm.c (calccost): Turn while-do into do-while, for clarity.
10401 * keyboard.c (syms_of_keyboard): Use the same style as later
10402 in this function when indexing through an array. This also
10403 works around GCC bug 48267.
10405 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10407 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10409 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10410 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10412 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10413 This avoids undefined behavior on integer overflow, and is a bit
10414 more convenient anyway since it is compared to a size_t variable.
10416 Variadic C functions now count arguments with size_t, not int.
10417 This avoids an unnecessary limitation on 64-bit machines, which
10418 caused (substring ...) to crash on large vectors (Bug#8344).
10419 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10420 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10421 All variadic functions and their callers changed accordingly.
10422 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10423 * data.c (arith_driver, float_arith_driver): Likewise.
10424 * editfns.c (general_insert_function): Likewise.
10425 * eval.c (struct backtrace.nargs, interactive_p)
10426 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10427 (funcall_lambda, mark_backtrace): Likewise.
10428 * fns.c (concat): Likewise.
10429 * frame.c (x_set_frame_parameters): Likewise.
10430 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10431 0 if not found, not -1. All callers changed.
10433 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10434 (stack_copy_size): Now size_t, not int.
10435 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10437 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10439 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10440 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10441 All callers changed.
10443 * lisp.h (multibyte_char_to_unibyte):
10444 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10445 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10446 * character.h (CHAR_TO_BYTE8):
10447 * cmds.c (internal_self_insert):
10448 * editfns.c (general_insert_function):
10449 * keymap.c (push_key_description):
10450 * search.c (Freplace_match):
10451 * xdisp.c (message_dolog, set_message_1): All callers changed.
10453 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10455 * keyboard.c (safe_run_hook_funcall): New function.
10456 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10457 don't set the hook to nil, but remove the offending function instead.
10458 (Qcommand_hook_internal): Remove, unused.
10459 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10460 Vcommand_hook_internal.
10462 * eval.c (enum run_hooks_condition): Remove.
10463 (funcall_nil, funcall_not): New functions.
10464 (run_hook_with_args): Call each function through a `funcall' argument.
10465 Remove `cond' argument, now redundant.
10466 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10467 (Frun_hook_with_args_until_failure): Adjust accordingly.
10468 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10470 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10472 * dispextern.h (string_buffer_position): Remove declaration.
10474 * print.c (strout): Remove parameter `multibyte', unused since
10475 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10477 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10478 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10479 All callers changed.
10481 * w32.c (_wsa_errlist): Use braces for struct initializers.
10483 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10484 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10485 All callers changed.
10486 (string_buffer_position): Likewise. Also, make static (it's never
10487 used outside xdisp.c).
10488 (cursor_row_p): Remove parameter `w', unused since
10489 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10490 (decode_mode_spec): Remove parameter `precision', introduced during
10491 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10492 All callers changed.
10494 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10496 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10498 2011-03-27 Anders Lindgren <andlind@gmail.com>
10500 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10501 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10502 (ns_update_auto_hide_menu_bar): New functions.
10503 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10504 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10505 ns_constrain_all_frames.
10506 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10507 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10509 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10511 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10513 2011-03-27 Glenn Morris <rgm@gnu.org>
10515 * syssignal.h: Replace RETSIGTYPE with void.
10516 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10517 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10518 Replace SIGTYPE with void everywhere.
10519 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10520 * s/template.h (SIGTYPE): Remove commented out definition.
10522 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10524 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10525 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10527 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10529 * w32.c (read_unc_volume): Use parameter `henum', instead of
10530 global variable `wget_enum_handle'.
10532 * keymap.c (describe_vector): Remove parameters `indices' and
10533 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10534 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10536 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10538 * keyboard.c (timer_check): Remove parameter `do_it_now',
10539 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10540 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10541 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10543 * keyboard.c (read_char):
10544 * w32menu.c (w32_menu_display_help):
10545 * xmenu.c (show_help_event, menu_help_callback):
10546 Adjust calls to `show_help_echo'.
10548 * gtkutil.c (xg_maybe_add_timer):
10549 * keyboard.c (readable_events):
10550 * process.c (wait_reading_process_output):
10551 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10553 * insdel.c (adjust_markers_gap_motion):
10554 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10555 (gap_left, gap_right): Don't call it.
10557 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10559 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10560 incurred during fontification.
10562 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10564 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10565 (DEFVAR_PER_BUFFER): Don't pass it.
10567 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10568 (scrolling_window): Don't pass it.
10570 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10572 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10574 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10576 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10577 of variables specific to SELinux and computation of `encoded_absname'.
10579 * image.c (XPutPixel): Remove unused variable `height'.
10581 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10583 * unexw32.c (get_section_info): Remove unused variable `section'.
10585 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10586 (system_process_attributes): Remove unused variable `sess'.
10587 (sys_read): Remove unused variable `err'.
10589 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10590 (w32_wnd_proc): Remove unused variable `isdead'.
10591 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10592 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10593 (x_create_tip_frame): Remove unused variable `tem'.
10595 * w32inevt.c (w32_console_read_socket):
10596 Remove unused variable `no_events'.
10598 * w32term.c (x_draw_composite_glyph_string_foreground):
10599 Remove unused variable `width'.
10601 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10603 * w32term.c (x_set_glyph_string_clipping):
10604 Don't pass uninitialized region to CombineRgn.
10606 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10608 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10609 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10610 (Fx_close_connection): Remove unused variable `i'.
10612 * w32font.c (w32font_draw): Return number of glyphs.
10613 (w32font_open_internal): Remove unused variable `i'.
10614 (w32font_driver): Add missing initializer.
10616 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10617 (fill_in_menu): Remove unused variable `items_added'.
10619 * w32term.c (last_mouse_press_frame): Remove static global variable.
10620 (w32_clip_to_row): Remove unused variable `f'.
10621 (x_delete_terminal): Remove unused variable `i'.
10623 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10624 (NOTHING): Remove unused static global variable.
10625 (uniscribe_check_otf): Remove unused variable `table'.
10626 (uniscribe_font_driver): Add missing initializers.
10628 2011-03-23 Julien Danjou <julien@danjou.info>
10630 * term.c (Fsuspend_tty, Fresume_tty):
10631 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10632 * window.c (temp_output_buffer_show):
10633 * insdel.c (signal_before_change):
10634 * frame.c (Fhandle_switch_frame):
10635 * fileio.c (Fdo_auto_save):
10636 * emacs.c (Fkill_emacs):
10637 * editfns.c (save_excursion_restore):
10638 * cmds.c (internal_self_insert):
10639 * callint.c (Fcall_interactively):
10640 * buffer.c (Fkill_all_local_variables):
10641 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10643 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10644 unconditionally since it does the check itself.
10646 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10648 Fix more problems found by GCC 4.5.2's static checks.
10650 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10651 the first time through the loop, since we know p0 < p1 then.
10652 This also avoids a gcc -Wstrict-overflow warning.
10654 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10655 leading to a memory leak, possible in functions like
10656 load_charset_map_from_file that can allocate an unbounded number
10657 of objects (Bug#8318).
10659 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10660 that could (at least in theory) be that large.
10662 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10663 This is less likely to overflow, and avoids undefined behavior if
10664 overflow does occur. All callers changed. Use strtoul to scan
10665 for the unsigned long integer.
10666 (pint2hrstr): Simplify and tune code slightly.
10667 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10669 * scroll.c (do_scrolling): Work around GCC bug 48228.
10670 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10672 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10673 This also avoids a warning with gcc -Wstrict-overflow.
10674 (validate_x_resource_name): Simplify count usage.
10675 This also avoids a warning with gcc -Wstrict-overflow.
10677 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10680 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10682 * process.c (Fmake_network_process): Use socklen_t, not int,
10683 where POSIX says socklen_t is required in portable programs.
10684 This fixes a porting bug on hosts like 64-bit HP-UX, where
10685 socklen_t is wider than int (Bug#8277).
10686 (Fmake_network_process, server_accept_connection):
10687 (wait_reading_process_output, read_process_output):
10690 * process.c: Rename or move locals to avoid shadowing.
10691 (list_processes_1, Fmake_network_process):
10692 (read_process_output_error_handler, exec_sentinel_error_handler):
10693 Rename or move locals.
10694 (Fmake_network_process): Define label "retry_connect" only if needed.
10695 (Fnetwork_interface_info): Fix pointer signedness.
10696 (process_send_signal): Add cast to avoid pointer signedness problem.
10697 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10698 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10700 Make tparam.h and terminfo.c consistent.
10701 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10702 Include tparam.h instead, since it declares them.
10703 * cm.h (PC): Remove extern decl; tparam.h now does this.
10704 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10705 * terminfo.c: Include tparam.h, to check interfaces.
10706 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10707 (tparam): Adjust signature to match interface in tparam.h;
10708 this removes some undefined behavior. Check that outstring and len
10709 are zero, which they always are with Emacs.
10710 * tparam.h (PC, BC, UP): New extern decls.
10712 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10713 (xftfont_open): Rename locals to avoid shadowing.
10715 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10716 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10717 (OTF_TAG_SYM): Omit macro if not needed.
10718 (ftfont_list): Remove unused local.
10719 (get_adstyle_property, ftfont_pattern_entity):
10720 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10721 Rename locals to avoid shadowing.
10723 * xfont.c (xfont_list_family): Mark var as initialized.
10725 * xml.c (make_dom): Now static.
10727 * composite.c (composition_compute_stop_pos): Rename local to
10729 (composition_reseat_it): Remove unused locals.
10730 (find_automatic_composition, composition_adjust_point): Likewise.
10731 (composition_update_it): Mark var as initialized.
10732 (find_automatic_composition): Mark vars as initialized,
10733 with a FIXME (Bug#8290).
10735 character.h: Rename locals to avoid shadowing.
10736 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10737 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10738 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10739 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10740 to avoid shadowing.
10742 * textprop.c (property_change_between_p): Remove; unused.
10744 * intervals.c (interval_start_pos): Now static.
10746 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10748 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10749 Rename locals to avoid shadowing.
10751 * sound.c (wav_play, au_play, Fplay_sound_internal):
10752 Fix pointer signedness.
10753 (alsa_choose_format): Remove unused local var.
10754 (wav_play): Initialize a variable to 0, to prevent undefined
10755 behavior (Bug#8278).
10757 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10759 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10761 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10762 clobbering (Bug#8298).
10763 * sysdep.c (sys_subshell): Likewise.
10764 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10766 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10767 This should get cleaned up, so that child_setup has the
10768 same signature on all platforms.
10770 * callproc.c (call_process_cleanup): Now static.
10771 (relocate_fd): Rename locals to avoid shadowing.
10773 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10775 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10776 not to be necessary, and produces flickering.
10778 2011-03-20 Glenn Morris <rgm@gnu.org>
10780 * config.in: Remove file.
10782 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10784 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10785 are now in src/globals.h.
10786 (syms_of_minibuf): Remove spurious & from previous change.
10788 2011-03-20 Leo Liu <sdl.web@gmail.com>
10790 * minibuf.c (completing-read-function): New variable.
10791 (completing-read-default): Rename from completing-read.
10792 (completing-read): Call completing-read-function.
10794 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10796 * xfaces.c (Fx_load_color_file):
10797 Read color file from absolute filename (bug#8250).
10799 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10801 * makefile.w32-in: Update dependencies.
10803 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10805 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10807 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10809 Fix more problems found by GCC 4.5.2's static checks.
10811 * process.c (make_serial_process_unwind, send_process_trap):
10812 (sigchld_handler): Now static.
10814 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10815 That way, the code declares only the vars that it needs.
10816 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10817 * s/cygwin.h (PTY_ITERATION): Likewise.
10818 * s/darwin.h (PTY_ITERATION): Likewise.
10819 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10821 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10822 * process.c (allocate_pty): Don't declare stb unless it's needed.
10824 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10825 (CONSTANTLIM): Remove; unused.
10826 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10827 Define only if needed.
10829 * unexelf.c (unexec): Name an expression,
10830 to avoid gcc -Wbad-function-cast warning.
10831 Use a different way to cause a compilation error if anyone uses
10832 n rather than nn, a way that does not involve shadowing.
10833 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10835 * deps.mk (unexalpha.o): Remove; unused.
10837 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10838 * unexec.h: New file.
10839 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10840 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10841 Depend on unexec.h.
10842 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10843 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10844 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10845 Change as necessary to match prototype in unexec.h.
10847 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10849 (back_comment, skip_chars): Mark vars as initialized.
10851 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10852 Rename locals to avoid shadowing.
10854 * lread.c (read1): Rewrite so as not to use empty "else".
10855 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10857 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10859 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10860 warning when compiling print.c.
10862 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10863 instead of using an uninitialized var.
10864 (font_sort_entities): Mark var as initialized.
10866 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10868 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10869 pointers to constants.
10870 (font_parse_fcname): Remove unused vars.
10871 (font_delete_unmatched): Now static.
10872 (font_get_spec): Remove; unused.
10873 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10874 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10875 Rename or move locals to avoid shadowing.
10877 * fns.c (require_nesting_list, require_unwind): Now static.
10878 (Ffillarray): Rename locals to avoid shadowing.
10880 * floatfns.c (domain_error2): Define only if needed.
10881 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10883 * alloc.c (mark_backtrace): Move decl from here ...
10884 * lisp.h: ... to here, so that it can be checked.
10886 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10887 (Fdefvar): Rewrite so as not to use empty "else".
10888 (lisp_indirect_variable): Name an expression,
10889 to avoid gcc -Wbad-function-cast warning.
10890 (Fdefvar): Rename locals to avoid shadowing.
10892 * callint.c (quotify_arg, quotify_args): Now static.
10893 (Fcall_interactively): Rename locals to avoid shadowing.
10894 Use const pointer when appropriate.
10896 * lisp.h (get_system_name, get_operating_system_release):
10897 Move decls here, to check interfaces.
10898 * process.c (get_operating_system_release): Move decl to lisp.h.
10899 * xrdb.c (get_system_name): Likewise.
10900 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10901 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10902 some of which prompt warnings from gcc -Wbad-function-cast.
10903 (Fformat_time_string, Fencode_time, Finsert_char):
10904 (Ftranslate_region_internal, Fformat):
10905 Rename or remove local vars to avoid shadowing.
10906 (Ftranslate_region_internal): Mark var as initialized.
10908 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10911 * lisp.h (eassert): Check that the argument compiles, even if
10912 ENABLE_CHECKING is not defined.
10914 * data.c (Findirect_variable): Name an expression, to avoid
10915 gcc -Wbad-function-cast warning.
10916 (default_value, arithcompare, arith_driver, arith_error): Now static.
10917 (store_symval_forwarding): Rename local to avoid shadowing.
10918 (Fmake_variable_buffer_local, Fmake_local_variable):
10919 Mark variables as initialized.
10920 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10922 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10923 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10924 Rename locals to avoid shadowing.
10925 (mark_stack): Move local variables into the #ifdef region where
10927 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10928 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10930 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10931 (GC_STRING_CHARS): Remove; not used.
10932 (Fmemory_limit): Cast sbrk's returned value to char *.
10934 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10935 avoids undefined behavior in theory.
10937 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10939 Use functions, not macros, for up- and down-casing (Bug#8254).
10940 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10941 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10942 to use the following functions instead of these macros.
10943 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10944 EMACS_INT, since callers assume the returned value fits in int.
10945 (upcase1): Likewise, for UPCASE_TABLE.
10946 (uppercasep, lowercasep, upcase): New static inline functions.
10947 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10948 the race-condition problem in the old DOWNCASE.
10950 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10951 Rename locals to avoid shadowing.
10952 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10953 (regex_compile, re_search_2, re_match_2_internal):
10954 Remove unused local vars.
10955 (FREE_VAR): Rewrite so as not to use empty "else",
10956 which gcc can warn about.
10957 (regex_compile, re_match_2_internal): Mark locals as initialized.
10958 (RETALLOC_IF): Define only if needed.
10959 (WORDCHAR_P): Likewise. This one is never needed, but is used
10960 only in a comment talking about a compiler bug, so put inside
10961 the #if 0 of that comment.
10962 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10963 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10966 * search.c (boyer_moore): Rename locals to avoid shadowing.
10967 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10968 (PREV_CHAR_BOUNDARY): Likewise.
10970 * search.c (simple_search): Remove unused var.
10972 * dired.c (compile_pattern): Move decl from here ...
10973 * lisp.h: ... to here, so that it can be checked.
10974 (struct re_registers): New forward decl.
10976 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10978 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10980 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10981 Rename locals to avoid shadowing.
10982 (Fvertical_motion): Mark locals as initialized.
10984 * casefiddle.c (casify_object, casify_region): Now static.
10985 (casify_region): Mark local as initialized.
10987 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10989 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10990 New macros, so that the caller can use some names other than
10991 gcpro1, gcpro2, etc.
10992 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10994 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10995 argument, for consistency with GCPRO2_VAR, etc: it is now the
10996 prefix of the variable, not the variable itself. All uses
10998 * dired.c (directory_files_internal, file_name_completion):
10999 Rename locals to avoid shadowing.
11001 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11002 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11003 dired.c's scmp function, had undefined behavior.
11004 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11005 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11006 * buffer.h: ... to here, because these macros use current_buffer,
11007 and the new implementation with inline functions needs to have
11008 current_buffer in scope now, rather than later when the macros
11010 (downcase, upcase1): New static inline functions.
11011 (DOWNCASE, UPCASE1): Reimplement using these functions.
11012 This avoids undefined behavior in expressions like
11013 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11014 from race conditions in accessing the global variables
11015 case_temp1 and case_temp2.
11016 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11017 * lisp.h (case_temp1, case_temp2): Remove their decls.
11018 * character.h (ASCII_CHAR_P): Move from here ...
11019 * lisp.h: ... to here, so that the inline functions mentioned
11020 above can use them.
11022 * dired.c (directory_files_internal_unwind): Now static.
11024 * fileio.c (file_name_as_directory, directory_file_name):
11025 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11027 (file_name_as_directory): Use const pointers when appropriate.
11028 (Fexpand_file_name): Likewise. In particular, newdir might
11029 point at constant storage, so make it a const pointer.
11030 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11031 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11033 (Fset_file_times, Finsert_file_contents, auto_save_error):
11034 Rename locals to avoid shadowing.
11036 * minibuf.c (choose_minibuf_frame_1): Now static.
11037 (Ftry_completion, Fall_completions): Rename or remove locals
11038 to avoid shadowing.
11040 * marker.c (bytepos_to_charpos): Remove; unused.
11042 * lisp.h (verify_bytepos, count_markers): New decls,
11043 so that gcc does not warn that these functions aren't declared.
11045 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11046 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11047 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11048 (copy_text): Remove unused local var.
11050 * filelock.c (within_one_second): Now static.
11051 (lock_file_1): Rename local to avoid shadowing.
11053 * buffer.c (fix_overlays_before): Mark locals as initialized.
11054 (fix_start_end_in_overlays): Likewise. This function should be
11055 simplified by using pointers-to-pointers, but that's a different
11057 (switch_to_buffer_1): Now static.
11058 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11059 (report_overlay_modification): Rename locals to avoid shadowing.
11061 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11062 Fix pointer signedness issue.
11063 (sys_subshell): Mark local as volatile if checking for lint,
11064 to suppress a gcc -Wclobbered warning that does not seem to be right.
11065 (MAXPATHLEN): Define only if needed.
11067 * process.c (serial_open, serial_configure): Move decls from here ...
11068 * systty.h: ... to here, so that they can be checked.
11070 * fns.c (get_random, seed_random): Move extern decls from here ...
11071 * lisp.h: ... to here, so that they can be checked.
11073 * sysdep.c (reset_io): Now static.
11074 (wait_for_termination_signal): Remove; unused.
11076 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11077 (copy_keymap_item, append_key, push_text_char_description):
11079 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11080 (DENSE_TABLE_SIZE): Remove; unused.
11081 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11082 (describe_map_tree):
11083 Rename locals to avoid shadowing.
11085 * keyboard.c: Declare functions static if they are not used elsewhere.
11086 (echo_char, echo_dash, cmd_error, top_level_2):
11087 (poll_for_input, handle_async_input): Now static.
11088 (read_char, kbd_buffer_get_event, make_lispy_position):
11089 (make_lispy_event, make_lispy_movement, apply_modifiers):
11090 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11091 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11092 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11093 (read_key_sequence, read_char): Mark locals as initialized.
11094 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11096 * keyboard.h (make_ctrl_char): New decl.
11097 (mark_kboards): Move decl here ...
11098 * alloc.c (mark_kboards): ... from here.
11100 * lisp.h (force_auto_save_soon): New decl.
11102 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11103 (DEFINE_DUMMY_FUNCTION): New macro.
11104 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11106 (main): Add casts to avoid warnings
11107 if GCC considers string literals to be constants.
11109 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11111 * dbusbind.c: Pointer signedness fixes.
11112 (xd_signature, xd_append_arg, xd_initialize):
11113 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11114 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11115 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11116 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11118 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11119 if GCC considers string literals to be constants.
11120 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11122 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11124 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11125 (print_preprocess, print_object): New macro to fix last change.
11127 * print.c (print_preprocess): Don't forget font objects.
11129 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11131 * emacs.c (USAGE3): Doc fixes.
11133 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11135 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11138 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11140 * lisp.h (VWindow_system, Qfile_name_history):
11141 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11142 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11143 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11145 * w32select.c: Don't #include "keyboard.h".
11146 (run_protected): Add extern declaration for waiting_for_input.
11148 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11149 * w32console.c (detect_input_pending, read_input_pending)
11150 (encode_terminal_code):
11151 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11152 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11153 (w32_system_caret_y, Qfile_name_history):
11154 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11155 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11156 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11157 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11158 * w32proc.c (Qlocal, report_file_error):
11159 * w32term.c (Vwindow_system, updating_frame):
11160 * w32uniscribe.c (initialized, uniscribe_font_driver):
11161 Remove unneeded extern declarations.
11163 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11165 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11167 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11169 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11170 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11171 These macros can no longer be used for assignment.
11173 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11174 Assign struct members directly, instead of using BUF_BEGV etc.
11175 (record_buffer_markers, fetch_buffer_markers): New functions for
11176 recording and fetching special buffer markers.
11177 (set_buffer_internal_1, set_buffer_temp): Use them.
11179 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11181 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11183 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11184 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11186 * xdisp.c (hscroll_window_tree):
11187 (reconsider_clip_changes): Use PT instead of BUF_PT.
11189 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11191 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11192 $(EMACS_ROOT)/lib/intprops.h.
11194 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11196 Fix more problems found by GCC 4.5.2's static checks.
11198 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11199 to unsigned char * to avoid compiler diagnostic.
11200 (xg_free_frame_widgets): Make it clear that a local variable is
11201 needed only if USE_GTK_TOOLTIP.
11202 (gdk_window_get_screen): Make it clear that this macro is needed
11203 only if USE_GTK_TOOLTIP.
11204 (int_gtk_range_get_value): New function, which avoids a diagnostic
11205 from gcc -Wbad-function-cast.
11206 (xg_set_toolkit_scroll_bar_thumb): Use it.
11207 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11208 diagnostic from gcc -Wbad-function-cast.
11209 (get_utf8_string, xg_get_file_with_chooser):
11210 Rename locals to avoid shadowing.
11211 (create_dialog): Move locals to avoid shadowing.
11213 * xgselect.c (xg_select): Remove unused var.
11215 * image.c (four_corners_best): Mark locals as initialized.
11216 (gif_load): Initialize transparent_p to zero (Bug#8238).
11217 Mark another local as initialized.
11218 (my_png_error, my_error_exit): Mark with NO_RETURN.
11220 * image.c (clear_image_cache): Now static.
11221 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11222 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11223 (x_edge_detection): Remove unnecessary cast that
11224 gcc -Wbad-function-cast diagnoses.
11225 (gif_load): Fix pointer signedness.
11226 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11227 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11229 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11231 Improve quality of tests for time stamp overflow.
11232 For example, without this patch (encode-time 0 0 0 1 1
11233 1152921504606846976) returns the obviously-bogus value (-948597
11234 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11235 reports time overflow. See
11236 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11237 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11238 * editfns.c: Include limits.h and intprops.h.
11239 (TIME_T_MIN, TIME_T_MAX): New macros.
11240 (time_overflow): Move earlier, to before first use.
11241 (hi_time, lo_time): New functions, for an accurate test for
11242 out-of-range times.
11243 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11244 (Fget_internal_run_time): Don't assume time_t fits in int.
11245 (make_time): Use list2 instead of Fcons twice.
11246 (Fdecode_time): More accurate test for out-of-range times.
11247 (check_tm_member): New function.
11248 (Fencode_time): Use it, to test for out-of-range times.
11249 (lisp_time_argument): Don't rely on undefined left-shift and
11250 right-shift behavior when checking for time stamp overflow.
11252 * editfns.c (time_overflow): New function, refactoring common code.
11253 (Fformat_time_string, Fdecode_time, Fencode_time):
11254 (Fcurrent_time_string): Use it.
11256 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11257 * dired.c (make_time): Move to ...
11258 * editfns.c (make_time): ... here.
11259 * systime.h: Note the move.
11261 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11263 * fringe.c (update_window_fringes): Remove unused variables.
11265 * unexmacosx.c (copy_data_segment): Also copy __got section.
11268 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11270 * termcap.c [MSDOS]: Include "msdos.h".
11271 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11272 Constify `char *' arguments and their references according to
11273 prototypes in tparam.h.
11275 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11277 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11278 Adapt all references accordingly.
11280 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11282 2011-03-11 Tom Tromey <tromey@redhat.com>
11284 * buffer.c (syms_of_buffer): Remove obsolete comment.
11286 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11288 * termhooks.h (encode_terminal_code): Declare prototype.
11290 * msdos.c (encode_terminal_code): Don't declare prototype.
11292 * term.c (encode_terminal_code): Now external again, used by
11293 w32console.c and msdos.c.
11295 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11296 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11298 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11300 Fix some minor problems found by GCC 4.5.2's static checks.
11302 * fringe.c (update_window_fringes): Mark locals as initialized
11304 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11306 * alloc.c (mark_fringe_data): Move decl from here ...
11307 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11308 to check its interface.
11309 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11311 * fontset.c (free_realized_fontset): Now static.
11312 (Fset_fontset_font): Rename local to avoid shadowing.
11313 (fontset_font): Mark local as initialized.
11314 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11316 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11318 * xselect.c (x_disown_buffer_selections): Remove; not used.
11319 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11320 (x_own_selection, Fx_disown_selection_internal): Rename locals
11321 to avoid shadowing.
11322 (x_handle_dnd_message): Remove local to avoid shadowing.
11324 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11325 so that the caller can use some name other than gcpro1.
11326 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11327 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11328 (Fx_backspace_delete_keys_p):
11329 Use them to avoid shadowing, and rename vars to avoid shadowing.
11330 (x_decode_color, x_set_name, x_window): Now static.
11331 (Fx_create_frame): Add braces to silence GCC warning.
11332 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11333 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11334 Remove unused locals.
11335 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11336 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11337 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11340 * xterm.h (x_mouse_leave): New decl.
11342 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11343 Remove unused functions.
11344 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11345 (x_calc_absolute_position): Now static.
11346 (XTread_socket): Don't define label "out" unless it's used.
11347 Don't declare local "event" unless it's used.
11348 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11349 unless they are used.
11350 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11351 (x_fatal_error_signal): Remove; not used.
11352 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11353 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11354 (x_error_catcher, x_connection_closed, x_error_handler):
11355 (x_error_quitter, xembed_send_message, x_iconify_frame):
11356 (my_log_handler): Rename locals to avoid shadowing.
11357 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11358 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11360 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11361 Rename or move locals to avoid shadowing.
11362 (tty_defined_color, merge_face_heights): Now static.
11363 (free_realized_faces_for_fontset): Remove; not used.
11364 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11365 does not deduce is never used uninitialized.
11366 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11367 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11369 * terminal.c (store_terminal_param): Now static.
11371 * xmenu.c (menu_highlight_callback): Now static.
11372 (set_frame_menubar): Remove unused local.
11373 (xmenu_show): Rename parameter to avoid shadowing.
11374 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11375 since they might point to immutable storage.
11376 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11377 since it's unused otherwise.
11379 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11380 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11381 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11382 avoids a gcc -Wuninitialized diagnostic.
11383 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11384 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11385 does not deduce are never used uninitialized.
11387 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11389 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11390 * window.c (window_loop, size_window):
11391 (run_window_configuration_change_hook, enlarge_window): Likewise.
11393 * window.c (display_buffer): Now static.
11394 (size_window): Mark variables that gcc -Wuninitialized
11395 does not deduce are never used uninitialized.
11396 * window.h (check_all_windows): New decl, to forestall
11397 gcc -Wmissing-prototypes diagnostic.
11398 * dispextern.h (bidi_dump_cached_states): Likewise.
11400 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11402 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11403 Include <limits.h>.
11404 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11405 and to avoid gcc -Wuninitialized warning.
11406 (load_charset_map): Mark variables that gcc -Wuninitialized
11407 does not deduce are never used uninitialized.
11408 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11410 * coding.c (coding_set_source, coding_set_destination):
11411 Use "else { /* comment */ }" rather than "else /* comment */;"
11412 for clarity, and to avoid gcc -Wempty-body warning.
11413 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11414 a block, when the outer 'i' will do.
11415 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11416 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11417 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11418 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11419 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11420 Rename locals to avoid shadowing.
11421 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11422 * coding.c (emacs_mule_char, encode_invocation_designation):
11423 Now static, since they're not used elsewhere.
11424 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11425 (decode_coding_object, encode_coding_object, detect_coding_system):
11426 (decode_coding_emacs_mule): Mark variables that gcc
11427 -Wuninitialized does not deduce are never used uninitialized.
11428 (detect_coding_iso_2022): Initialize a local variable that might
11429 be used uninitialized. Leave a FIXME because it's not clear that
11430 this initialization is needed. (Bug#8211)
11431 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11432 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11433 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11434 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11435 Remove unused macros.
11437 * category.c (hash_get_category_set): Remove unused local var.
11438 (copy_category_table): Now static, since it's not used elsewhere.
11439 * character.c (string_count_byte8): Likewise.
11441 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11442 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11444 * chartab.c (copy_sub_char_table): Now static, since it's not used
11446 (sub_char_table_ref_and_range, char_table_ref_and_range):
11447 Rename locals to avoid shadowing.
11448 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11450 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11451 (BIDI_BOB): Remove unused macro.
11453 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11454 deduce are never used uninitialized.
11455 * term.c (encode_terminal_code): Likewise.
11457 * term.c (encode_terminal_code): Now static. Remove unused local.
11459 * tparam.h: New file.
11460 * term.c, tparam.h: Include it.
11461 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11462 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11463 Move these decls to tparam.h, and make them agree with what
11464 is actually in tparam.c. The previous trick of using incompatible
11465 decls in different modules does not conform to the C standard.
11466 All callers of tparam changed to use tparam's actual API.
11467 * tparam.c (tparam1, tparam, tgoto):
11468 Use const pointers where appropriate.
11470 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11471 * cm.h (struct cm): Likewise.
11472 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11473 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11474 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11475 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11476 (turn_on_face, init_tty): Likewise.
11477 * termchar.h (struct tty_display_info): Likewise.
11479 * term.c (term_mouse_position): Rename local to avoid shadowing.
11481 * alloc.c (mark_ttys): Move decl from here ...
11482 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11484 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11486 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11488 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11490 * search.c (compile_pattern_1): Remove argument regp, unused since
11491 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11492 (compile_pattern): Don't pass it.
11494 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11496 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11497 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11499 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11501 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11503 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11504 gdk_window_get_screen, gdk_window_get_geometry,
11505 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11506 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11507 (xg_get_pixbuf_from_pixmap): New function.
11508 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11509 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11510 Call xg_get_pixbuf_from_pixmap instead of
11511 gdk_pixbuf_get_from_drawable.
11512 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11513 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11514 (xg_check_special_colors): Use GtkStyleContext and its functions
11516 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11517 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11518 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11519 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11520 Call gtk_widget_get_preferred_size.
11521 (xg_frame_resized): gdk_window_get_geometry only takes 5
11523 (xg_win_to_widget, xg_event_is_for_menubar):
11524 Call gdk_x11_window_lookup_for_display.
11525 (xg_set_widget_bg): New function.
11526 (delete_cb): New function.
11527 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11528 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11529 (xg_set_background_color): Call xg_set_widget_bg.
11530 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11531 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11532 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11533 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11535 (update_frame_tool_bar): Call gtk_widget_hide.
11536 (xg_initialize): Use GDK_KEY_g.
11538 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11540 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11542 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11543 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11544 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11546 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11548 * w32xfns.c (select_palette): Check success of RealizePalette against
11549 GDI_ERROR, not zero.
11551 See ChangeLog.11 for earlier changes.
11553 ;; Local Variables:
11557 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11559 This file is part of GNU Emacs.
11561 GNU Emacs is free software: you can redistribute it and/or modify
11562 it under the terms of the GNU General Public License as published by
11563 the Free Software Foundation, either version 3 of the License, or
11564 (at your option) any later version.
11566 GNU Emacs is distributed in the hope that it will be useful,
11567 but WITHOUT ANY WARRANTY; without even the implied warranty of
11568 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11569 GNU General Public License for more details.
11571 You should have received a copy of the GNU General Public License
11572 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.