1 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3 * Makefile.in (PAXCTL): Define.
4 (temacs$(EXEEXT)): Disable memory randomization for the temacs
5 binary via PaX flags if the paxctl utility is available.
6 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
7 Restore PaX flags to their default. (Bug#11398)
9 2012-06-03 Chong Yidong <cyd@gnu.org>
11 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
14 2012-06-03 Chong Yidong <cyd@gnu.org>
16 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
17 (note_mode_line_or_margin_highlight): If there is no help echo,
18 use mode-line-default-help-echo. Handle the case where the mouse
19 position is past the end of the mode line string.
21 * buffer.c (buffer_local_value_1): New function, split from
22 Fbuffer_local_value; can return Qunbound.
23 (Fbuffer_local_value): Use it.
24 (Vmode_line_format): Docstring tweaks.
26 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
28 * sysdep.c (system_process_attributes): Improve comment.
30 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
32 * keyboard.c: Export real-this-command to Elisp.
33 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
34 and DEFVAR it. Update all users.
36 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
38 * minibuf.c (Fassoc_string): Remove duplicate declaration.
40 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
41 Convert pctcpu and pctmem to Lisp float properly.
42 Let the compiler fold better, as 100.0/0x8000 is exact.
44 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
46 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
49 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
51 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
53 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
55 For a 'struct window', replace some Lisp_Object fields to
56 bitfields where appropriate, remove unused fields.
57 * window.h (struct window): Remove unused 'last_mark_x' and
58 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
59 change it's type from Lisp_Object to bitfield.
60 Change type of 'force_start', 'optional_new_start',
61 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
62 fields from Lisp_Object to bitfield. Adjust users accordingly.
64 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
66 Pacify gcc -Wdouble-precision when using Xaw.
67 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
68 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
69 Use 'float' consistently, rather than 'float' in most places
70 and 'double' in a couple of places.
72 2012-05-31 Eli Zaretskii <eliz@gnu.org>
74 * xdisp.c (handle_stop): Detect whether we have overlay strings
75 loaded by testing it->current.overlay_string_index to be
76 non-negative, instead of checking whether n_overlay_strings is
79 2012-05-31 Chong Yidong <cyd@gnu.org>
81 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
83 * doc.c (Fsubstitute_command_keys): Doc fix.
85 2012-05-31 Eli Zaretskii <eliz@gnu.org>
87 * search.c (search_buffer): Remove calls to
88 r_alloc_inhibit_buffer_relocation, as it is now called by
89 maybe_unify_char, which was the cause of relocation of buffer text
92 2012-05-31 Eli Zaretskii <eliz@gnu.org>
94 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
95 for the duration of call to load_charset, to avoid problems with
96 callers of maybe_unify_char that access buffer text through C
99 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
100 decrement the inhibition flag, instead of just setting or
103 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
105 Remove obsolete '#define static' cruft.
106 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
107 This #undef was "temporary" in 2000; it is no longer needed
108 now that '#define static' has gone away.
109 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
110 (gray_bitmap_bits): Remove; no longer needed.
111 All uses replaced with definiens.
112 * xterm.c: Include "bitmaps/gray.xbm".
114 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
116 Clean up __executable_start, monstartup when --enable-profiling.
117 The following changes affect the code only when profiling.
118 * dispnew.c (__executable_start): Rename from safe_bcopy.
119 Define only on platforms that need it.
120 * emacs.c: Include <sys/gmon.h> when profiling.
121 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
122 (__executable_start): Remove decl, since lisp.h does it now.
123 (safe_bcopy): Remove decl; no longer has that name.
124 (main): Coalesce #if into single bit of code, for simplicity.
125 Cast pointers to uintptr_t, since standard libraries want integers
127 * lisp.h (__executable_start): New decl.
129 2012-05-31 Glenn Morris <rgm@gnu.org>
131 * image.c (Fimagemagick_types): Doc fix.
133 2012-05-30 Jim Meyering <meyering@redhat.com>
135 * callproc.c (Fcall_process_region): Include directory component
136 in mkstemp error message (Bug#11586).
138 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
140 * alloc.c, lisp.h (make_pure_vector): Now static.
142 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
144 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
146 (Fautoload): Do the hash-doc more carefully.
147 * data.c (Fdefalias): Purify definition, except for keymaps.
148 (Qdefun): Move from eval.c.
149 * lisp.h (Qdefun): Remove.
150 * lread.c (read1): Tiny simplification.
152 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
154 Do not create empty overlays with the evaporate property (Bug#9642).
155 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
156 Bug#9642, but explicitly check that the buffer the overlay would
157 be moved to is live and rearrange lines to make sure that errors
158 will not put the overlay in an inconsistent state.
159 (Fdelete_overlay): Cosmetics.
161 2012-05-28 Eli Zaretskii <eliz@gnu.org>
163 * w32term.c (my_bring_window_to_top): New function.
164 (x_raise_frame): Use handle returned by DeferWindowPos, which
165 could be different from the original one.
166 Call my_bring_window_to_top instead of my_set_foreground_window.
169 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
170 by calling BringWindowToTop.
172 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
173 (WM_EMACS_END): Increase by one.
175 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
177 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
178 This avoids undefined behavior that might cause the eassert
179 to not catch an out-of-range value.
181 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
183 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
186 2012-05-27 Eli Zaretskii <eliz@gnu.org>
188 * bidi.c (bidi_mirror_char): Fix last change.
190 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
192 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
193 when referring to sectname field in printf format.
195 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
197 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
198 Only r_alloc_inhibit_buffer_relocation needed to be added;
199 the others were already declared.
201 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
202 before checking whether it's out of range. Put the check inside
204 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
206 2012-05-27 Ken Brown <kbrown@cornell.edu>
208 * callproc.c (Fcall_process): Restore a line that was accidentally
209 commented out in the 2011-02-13 change (bug#11547).
211 2012-05-27 Eli Zaretskii <eliz@gnu.org>
213 * lisp.h [REL_ALLOC]: Add prototypes for external functions
216 * buffer.c [REL_ALLOC]: Remove prototypes of
217 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
218 they are now on lisp.h.
220 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
222 * search.c (search_buffer): Use it to inhibit relocation of buffer
223 text while re_search_2 is doing its job, because re_search_2 is
224 passed C pointers to buffer text. (Bug#11519)
226 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
229 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
230 state after an additional call to move_it_in_display_line_to, keep
231 the values of it->max_ascent and it->max_descent found for the
233 (pos_visible_p): Revert the comparison against bottom_y to what it
234 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
237 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
239 Fix coding-related core dumps with gcc -ftrapv.
240 The code was computing A - B, where A and B are pointers, and B is
241 random garbage. This can lead to core dumps on platforms that
242 have special pointer registers, and it also leads to core dumps on
243 x86-64 when compiled with gcc -ftrapv. The fix is to compute
244 A - B only when B is initialized properly.
245 * coding.c (coding_set_source, coding_set_destination): Return void.
246 (coding_change_source, coding_change_destinations): New functions,
247 with the old behaviors of coding_set_source and coding_set_destination.
248 All callers that need an offset changed to use these new functions.
250 2012-05-26 Glenn Morris <rgm@gnu.org>
252 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
254 2012-05-26 Eli Zaretskii <eliz@gnu.org>
256 Extend mouse support on W32 text-mode console.
257 * xdisp.c (draw_row_with_mouse_face):
258 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
260 * w32console.c: Include window.h.
261 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
263 (initialize_w32_display): Initialize mouse-highlight data.
265 * w32inevt.c: Include termchar.h and window.h.
266 (do_mouse_event): Support mouse-autoselect-window. When the mouse
267 moves, call note_mouse_highlight. If help_echo changed, call
268 gen_help_event to produce help-echo message in the echo area.
269 Call clear_mouse_face if mouse_face_hidden is set in the mouse
272 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
274 * lread.c (read1): Simplify slightly to avoid an overflow warning
275 with GCC 4.7.0 on x86-64.
277 2012-05-26 Eli Zaretskii <eliz@gnu.org>
279 * bidi.c (bidi_mirror_char): Revert last change: an int is
280 definitely wide enough here.
282 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
284 Fix integer width and related bugs (Bug#9874).
285 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
286 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
287 (string_bytes, check_sblock, allocate_string_data):
288 (compact_small_strings, Fmake_bool_vector, make_string)
289 (make_unibyte_string, make_multibyte_string)
290 (make_string_from_bytes, make_specified_string)
291 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
292 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
295 (allocate_pseudovector):
296 Use int, not EMACS_INT, where int is wide enough.
297 (inhibit_garbage_collection, Fgarbage_collect):
298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
299 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
300 int might not be wide enough.
301 (bidi_cache_search, bidi_cache_find, bidi_init_it)
302 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
303 (bidi_at_paragraph_end, bidi_find_paragraph_start)
304 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
305 (bidi_level_of_next_char, bidi_move_to_visually_next):
306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
307 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
308 (Fkill_buffer, Fset_buffer_major_mode)
309 (advance_to_char_boundary, Fbuffer_swap_text)
310 (Fset_buffer_multibyte, overlays_at, overlays_in)
311 (overlay_touches_p, struct sortvec, record_overlay_string)
312 (overlay_strings, recenter_overlay_lists)
313 (adjust_overlays_for_insert, adjust_overlays_for_delete)
314 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
315 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
316 (Foverlay_recenter, last_overlay_modification_hooks_used)
317 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
319 (validate_region): Omit unnecessary test for b <= e,
320 since that's guaranteed by the previous test.
321 (adjust_overlays_for_delete): Avoid pos + length overflow.
322 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
323 (report_overlay_modification):
324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
325 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
326 Omit pointer cast, which isn't needed anyway, and doesn't work
327 after the EMACS_INT -> ptrdiff_t change.
328 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
329 * buffer.h: Adjust decls to match defn changes elsewhere.
330 (struct buffer_text, struct buffer):
331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
332 Use EMACS_INT, not int, where int might not be wide enough.
333 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
334 not int, to avoid needless 32-bit limit on 64-bit hosts.
335 (exec_byte_code): Use tighter memory-full test, one that checks
336 for alloca overflow. Don't compute the address of the object just
337 before an array, as that's not portable. Use EMACS_INT, not
338 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
339 * callint.c (Fcall_interactively):
340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
341 * callproc.c (call_process_kill, Fcall_process):
342 Don't assume pid_t fits into an Emacs fixnum.
343 (call_process_cleanup, Fcall_process, child_setup):
344 Don't assume pid_t fits into int.
345 (call_process_cleanup, Fcall_process, delete_temp_file)
346 (Fcall_process_region):
347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
348 (Fcall_process): Simplify handling of volatile integers.
349 Use int, not EMACS_INT, where int will do.
350 * casefiddle.c (casify_object, casify_region, operate_on_word)
351 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
353 (casify_object): Avoid integer overflow when overallocating buffer.
354 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
355 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
356 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
357 * category.h (CATEGORYP): Don't assume arg is nonnegative.
358 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
359 integers are now checked earlier. All uses replaced with XINT.
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 For CCL_MapSingle, check that content and value are in int range.
363 (ccl_driver, Fregister_code_conversion_map):
364 Check that Vcode_version_map_vector is a vector.
365 (resolve_symbol_ccl_program): Check that vector header is in range.
366 Always copy the vector, so that we can check its contents reliably
367 now rather than having to recheck each instruction as it's being
368 executed. Check that vector words fit in 'int'.
369 (ccl_get_compiled_code, Fregister_ccl_program)
370 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
371 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
372 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
373 contents are in range.
374 (Fccl_execute_on_string): Check that status is in range.
375 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
376 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
377 Accept and return EMACS_INT, not int, because callers can pass values
379 (c_string_width, strwidth, lisp_string_width, chars_in_text)
380 (multibyte_chars_in_text, parse_str_as_multibyte)
381 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
382 (str_as_unibyte, str_to_unibyte, string_count_byte8)
383 (string_escape_byte8, Fget_byte):
384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
385 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
386 avoid mishandling large integers.
387 * character.h: Adjust decls to match defn changes elsewhere.
388 * charset.c (load_charset_map_from_file, find_charsets_in_text)
389 (Ffind_charset_region):
390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
391 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
392 (load_charset_map_from_vector, Fdefine_charset_internal):
393 Don't assume fixnum fits in int.
394 (load_charset_map_from_vector, Fmap_charset_chars):
395 Remove now-unnecessary CHECK_NATNUMs.
396 (Fdefine_charset_internal): Check ranges here, more carefully.
397 Don't rely on undefined behavior with signed left shift overflow.
398 Don't assume unsigned int fits into fixnum, or that fixnum fits
399 into unsigned int. Don't require max_code to be a valid fixnum;
400 that's not true for gb10830 4-byte on a 32-bit host. Allow
401 invalid_code to be a cons, for the same reason. Require code_offset
402 to be a character. Avoid int overflow if max_char is close
404 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
405 this is intended anyway and avoids some undefined behavior.
406 (load_charset_map): Pass unsigned, not int, as 2nd arg of
407 INDEX_TO_CODE_POINT, as that's what it expects.
408 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
409 * charset.h (DECODE_CHAR): Return int, not unsigned;
410 this is what was intended anyway, and it avoids undefined behavior.
411 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
412 integer-overflow issues.
413 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
414 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
415 where the argument is EMACS_INT, and this behavior is not intended.
416 * chartab.c (Fmake_char_table, Fset_char_table_range)
417 (uniprop_get_decoder, uniprop_get_encoder):
418 Don't assume fixnum fits in int.
419 * cmds.c (move_point): New function, that does the gist of
420 Fforward_char and Fbackward_char, but does so while checking
421 for integer overflow more accurately.
422 (Fforward_char, Fbackward_char): Use it.
423 (Fforward_line, Fend_of_line, internal_self_insert)
424 (internal_self_insert):
425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
426 Fix a FIXME, by checking for integer overflow when calculating
427 target_clm and actual_clm.
428 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
429 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
430 (ASSURE_DESTINATION, coding_alloc_by_realloc)
431 (coding_alloc_by_making_gap, alloc_destination)
432 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
433 (encode_coding_utf_16, detect_coding_emacs_mule)
434 (decode_coding_emacs_mule, encode_coding_emacs_mule)
435 (detect_coding_iso_2022, decode_coding_iso_2022)
436 (encode_invocation_designation, encode_designation_at_bol)
437 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
438 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
439 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
440 (encode_coding_ccl, encode_coding_raw_text)
441 (detect_coding_charset, decode_coding_charset)
442 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
443 (produce_composition, produce_charset, produce_annotation)
444 (decode_coding, handle_composition_annotation)
445 (handle_charset_annotation, consume_chars, decode_coding_gap)
446 (decode_coding_object, encode_coding_object, detect_coding_system)
447 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
448 (code_convert_region, code_convert_string)
449 (Fdefine_coding_system_internal)
450 (coding_set_source, coding_set_destination):
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
453 (Fdefine_coding_system_internal):
454 Don't assume fixnums fit in int.
455 (decode_coding_gap, decode_coding_object, encode_coding_object)
456 (Fread_coding_system, Fdetect_coding_region)
457 (Funencodable_char_position, Fcheck_coding_systems_region)
458 (get_translation, handle_composition_annotation, consume_chars):
459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
460 (consume_chars): Rewrite to not calculate an address outside buffer.
461 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
462 Don't access memory outside of the args array.
463 (Fdefine_coding_system_internal): Check for charset-id overflow.
464 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
465 result of ENCODE_CHAR.
466 * coding.h: Adjust decls to match defn changes elsewhere.
467 (struct coding_system):
468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
469 * composite.c (get_composition_id, find_composition)
470 (run_composition_function, update_compositions)
471 (compose_text, composition_gstring_put_cache)
472 (composition_gstring_p, composition_gstring_width)
473 (fill_gstring_header, fill_gstring_body, autocmp_chars)
474 (composition_compute_stop_pos, composition_reseat_it)
475 (composition_update_it, struct position_record)
476 (find_automatic_composition, composition_adjust_point)
477 (Fcomposition_get_gstring, Ffind_composition_internal):
478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
479 (update_compositions):
480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
481 * composite.h: Adjust decls to match defn changes elsewhere.
482 (struct composition):
483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
484 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
485 Do not attempt to compute the address of the object just before a
486 buffer; this is not portable.
488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
489 (Faset): Use int, not EMACS_INT, where int is wide enough.
490 (Fstring_to_number): Don't assume fixnums fit in int.
491 (Frem): Don't assume arg is nonnegative.
492 * dbusbind.c (xd_append_arg): Check for integers out of range.
493 (Fdbus_call_method): Don't overflow the timeout int.
494 (extract_signed, extract_unsigned): New functions.
495 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
496 (xd_get_connection_references): Return ptrdiff_t, not int.
498 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
500 Use int, not unsigned, where the dbus API uses int.
501 (Fdbus_message_internal): Don't overflow mtype.
502 (syms_of_dbusbind): Allocate right-sized buffer for integers.
503 * dired.c (directory_files_internal, file_name_completion, scmp)
504 (file_name_completion_stat):
505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
506 (file_name_completion): Don't overflow matchcount.
507 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
508 * dispextern.h: Adjust decls to match defn changes elsewhere.
509 (struct text_pos, struct glyph, struct bidi_saved_info)
510 (struct bidi_string_data, struct bidi_it, struct composition_it)
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 (struct display_pos, struct composition_it, struct it):
514 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
515 * dispnew.c (increment_matrix_positions)
516 (increment_row_positions, mode_line_string)
517 (marginal_area_string):
518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
519 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
521 (duration_to_sec_usec): New function, to check for overflow better.
522 (Fsleep_for, sit_for): Use it.
523 * doc.c (get_doc_string, store_function_docstring):
524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
525 (get_doc_string, Fsnarf_documentation):
526 Use int, not EMACS_INT, where int is wide enough.
528 Use SAFE_ALLOCA, not alloca.
529 Check for overflow when converting EMACS_INT to off_t.
531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
532 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
533 Don't assume uid_t fits into fixnum.
534 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
535 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
536 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
537 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
538 (general_insert_function)
539 (Finsert_char, make_buffer_string, make_buffer_string_both)
540 (update_buffer_properties, Fbuffer_substring)
541 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
542 (Fsubst_char_in_region, check_translation)
543 (Ftranslate_region_internal, save_restriction_restore, Fformat)
544 (transpose_markers, Ftranspose_regions):
545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
546 (clip_to_bounds): Move to lisp.h as an inline function).
547 (Fconstrain_to_field): Don't assume integers are nonnegative.
548 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
549 (Fsubst_char_in_region, Fsave_restriction):
550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
551 (Femacs_pid): Don't assume pid_t fits into fixnum.
552 (lo_time): Use int, not EMACS_INT, when int suffices.
553 (lisp_time_argument): Check for usec out of range.
554 (Fencode_time): Don't assume fixnum fits in int.
555 (Fuser_login_name, Fuser_full_name): Signal an error
556 if a uid argument is out of range, rather than relying on
558 (Fformat_time_string): Remove now-unnecessary check.
559 lisp_time_argument checks for out-of-range usec now.
560 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
561 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
562 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
563 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
564 (init_cmdargs, Fdump_emacs):
565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
566 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
567 the bottom (typically) 32 bits of the fixnum.
568 * eval.c (specpdl_size, call_debugger):
569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
570 (when_entered_debugger, Fbacktrace_debug):
571 Don't assume fixnum can fit in int.
572 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
573 the object just before a buffer; this is not portable.
574 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
575 (grow_specpdl, unbind_to):
576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
577 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
578 (grow_specpdl): Simplify allocation by using xpalloc.
579 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
580 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
581 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
583 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 (Fcopy_file, non_regular_nbytes, read_non_regular)
587 (Finsert_file_contents):
588 Use int, not EMACS_INT, where int is wide enough.
589 (READ_BUF_SIZE): Verify that it fits in int.
590 (Finsert_file_contents): Check that counts are in proper range,
591 rather than assuming fixnums fit into ptrdiff_t etc.
592 Don't assume fixnums fit into int.
593 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
594 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
595 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
596 (string_char_to_byte, string_byte_to_char)
597 (string_make_multibyte, string_to_multibyte)
598 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
599 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
600 (substring_both, Fdelete, internal_equal, Ffillarray)
601 (Fclear_string, mapcar1)
602 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
603 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
604 (larger_vector, make_hash_table, maybe_resize_hash_table)
605 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
606 (Fmaphash, secure_hash):
607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
608 (concat): Check for string index and length overflow.
609 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
612 (larger_vector): New API (vec, incr_min, size_max) replaces old
613 one (vec, new_size, init). This catches size overflow.
614 INIT was removed because it was always Qnil.
616 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
617 the upper bound on a hash table index size.
618 (make_hash_table, maybe_resize_hash_table): Use it.
619 (secure_hash): Computer start_byte and end_byte only after
620 they're known to be in ptrdiff_t range.
621 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
622 (Ffont_get_glyphs, Ffont_at):
623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
624 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
625 (Flist_fonts, Fopen_font):
626 Don't assume fixnum can fit in int.
627 (check_gstring): Don't assume index can fit in int.
628 (font_match_p): Check that fixnum is a character, not a nonnegative
629 fixnum, since the later code needs to stuff it into an int.
630 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
631 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
632 conversion overflow issues.
633 (Fopen_font): Check for integer out of range.
634 (Ffont_get_glyphs): Don't assume index can fit in int.
635 * font.h: Adjust decls to match defn changes elsewhere.
636 * fontset.c (reorder_font_vector): Redo score calculation to avoid
638 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
639 printmax_t, where ptrdiff_t is wide enough.
640 (Finternal_char_font):
641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
642 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
643 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
644 (Fset_frame_position, x_set_frame_parameters)
645 (x_set_line_spacing, x_set_border_width)
646 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
647 Check that fixnums are in proper range for system types.
648 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
650 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
651 Use SAFE_ALLOCA_LISP, not alloca.
652 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
653 intptr_t is wide enough.
654 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
655 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
656 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
657 Check for fixnum out of range.
658 * ftfont.c (ftfont_list): Don't assume index fits in int.
659 Check that fixnums are in proper range for system types.
660 (ftfont_shape_by_flt):
661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
662 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
665 Check that fixnums are in proper range for system types.
666 * gnutls.h: Adjust decls to match defn changes elsewhere.
667 * gtkutil.c (xg_dialog_run):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (update_frame_tool_bar):
670 Check that fixnums are in proper range for system types.
671 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
672 (lookup_image): Check that fixnums are in range for system types.
673 * indent.c (last_known_column, last_known_column_point):
674 (current_column_bol_cache):
675 (skip_invisible, current_column, check_display_width):
676 (check_display_width, scan_for_column, current_column_1)
677 (Findent_to, Fcurrent_indentation, position_indentation)
678 (indented_beyond_p, Fmove_to_column, compute_motion):
679 (Fcompute_motion, Fvertical_motion):
680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
681 (last_known_column_modified): Use EMACS_INT, not int.
682 (check_display_width):
684 Check that fixnums and floats are in proper range for system types.
685 (compute_motion): Don't assume index or fixnum fits in int.
686 (compute_motion, Fcompute_motion):
687 Use int, not EMACS_INT, when it is wide enough.
688 (vmotion): Omit local var start_hpos that is always 0; that way
689 we don't need to worry about overflow in expressions involving it.
690 * indent.h: Adjust decls to match defn changes elsewhere.
692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
693 Use int, not EMACS_INT, where int is wide enough.
694 Remove unused members ovstring_chars_done and tab_offset;
696 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
697 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
698 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
699 (make_gap, copy_text, insert, insert_and_inherit)
700 (insert_before_markers, insert_before_markers_and_inherit)
701 (insert_1, count_combining_before, count_combining_after)
702 (insert_1_both, insert_from_string)
703 (insert_from_string_before_markers, insert_from_string_1)
704 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
705 (adjust_after_replace, adjust_after_insert, replace_range)
706 (replace_range_2, del_range, del_range_1, del_range_byte)
707 (del_range_both, del_range_2, modify_region)
708 (prepare_to_modify_buffer, signal_before_change)
709 (signal_after_change, Fcombine_after_change_execute):
710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
711 * intervals.c (traverse_intervals, rotate_right, rotate_left)
712 (balance_an_interval, split_interval_right, split_interval_left)
713 (find_interval, next_interval, update_interval)
714 (adjust_intervals_for_insertion, delete_node, delete_interval)
715 (interval_deletion_adjustment, adjust_intervals_for_deletion)
716 (static_offset_intervals, offset_intervals)
717 (merge_interval_right, merge_interval_left, make_new_interval)
718 (graft_intervals_into_buffer, temp_set_point_both)
719 (temp_set_point, set_point, adjust_for_invis_intang)
720 (set_point_both, move_if_not_intangible, get_property_and_range)
721 (get_local_map, copy_intervals, copy_intervals_to_string)
722 (compare_string_intervals, set_intervals_multibyte_1):
723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
724 * intervals.h: Adjust decls to match defn changes elsewhere.
726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
727 * keyboard.c (this_command_key_count, this_single_command_key_start)
728 (before_command_key_count, before_command_echo_length, echo_now)
729 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
730 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
731 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
732 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
734 (last_non_minibuf_size, last_point_position, echo_truncate)
735 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
736 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
737 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
738 (stuff_buffered_input):
739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
740 (last_auto_save, command_loop_1, read_char):
741 Use EMACS_INT, not int, to avoid integer overflow.
742 (record_char): Avoid overflow in total_keys computation.
743 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
744 * keyboard.h: Adjust decls to match defn changes elsewhere.
745 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
746 (Fkey_description, Fdescribe_vector, Flookup_key):
747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
748 (click_position): New function, to check that positions are in range.
749 (Fcurrent_active_maps):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 (Faccessible_keymaps, Fkey_description):
753 (preferred_sequence_p):
754 Don't assume fixnum can fit into int.
755 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
756 Check for integer overflow in size calculations.
757 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
758 avoid mishandling large integers.
759 * lisp.h: Adjust decls to match defn changes elsewhere.
760 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
761 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
762 (struct Lisp_Marker):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 (clip_to_bounds): Now an inline function, moved here from editfns.c.
765 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
766 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
768 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
769 Assume the arg has valid form, since it always does.
770 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
771 unsigned integer system type.
772 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
773 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
775 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
776 (duration_to_sec_usec): New decl.
777 * lread.c (read_from_string_index, read_from_string_index_byte)
778 (read_from_string_limit, readchar, unreadchar, openp)
779 (read_internal_start, read1, oblookup):
780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
781 (Fload, readevalloop, Feval_buffer, Feval_region):
782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
783 (openp): Check for out-of-range argument to 'access'.
784 (read1): Use int, not EMACS_INT, where int is wide enough.
785 Don't assume fixnum fits into int.
786 Fix off-by-one error that can read outside a buffer.
787 (read_filtered_event): Use duration_to_sec_usec
788 to do proper overflow checking on durations.
789 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
791 (Fexecute_kbd_macro):
792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
793 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
794 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
795 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
796 (set_marker_both, set_marker_restricted_both, marker_position)
797 (marker_byte_position, Fbuffer_has_markers_at):
798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
799 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
800 * menu.c (ensure_menu_items): Rename from grow_menu_items.
801 It now merely ensures that the menu is large enough, without
802 necessarily growing it, as this avoids some integer overflow issues.
804 (keymap_panes, parse_single_submenu, Fx_popup_menu):
805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
806 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
807 Use SAFE_ALLOCA_LISP, not alloca.
808 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
809 to EMACS_INT. Check that fixnums are in proper range for system types.
810 * minibuf.c (minibuf_prompt_width, string_to_object)
811 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
812 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
814 (get_minibuffer, read_minibuf_unwind):
815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
816 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
817 this simplifies overflow checking. All callers changed.
818 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
821 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
822 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
823 Check that fixnums are in proper range for system types.
824 (Fx_create_frame, Fx_show_tip):
825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
826 * nsfont.m (ns_findfonts, nsfont_list_family):
827 Don't assume fixnum fits in long.
828 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
830 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
832 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
834 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
835 (PRINTDECLARE, PRINTPREPARE):
836 (strout, print_string):
837 (print, print_preprocess, print_check_string_charset_prop)
839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
841 (temp_output_buffer_setup, Fprin1_to_string, print_object):
842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
843 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
844 (printchar, strout): Use xpalloc to catch size calculation overflow.
845 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
846 (print_error_message): Use SAFE_ALLOCA, not alloca.
847 (print_object): Use int, not EMACS_INT, where int is wide enough.
848 (print_depth, new_backquote_output, print_number_index):
849 Use ptrdiff_t, not int, where int might not be wide enough.
850 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
851 (Fset_process_window_size, Fformat_network_address)
852 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
854 Check that fixnums are in proper range for system types.
855 (Fsignal_process): Simplify by avoiding a goto.
856 Check for process-ids out of pid_t range rather than relying on
858 (process_tick, update_tick): Use EMACS_INT, not int.
859 (Fformat_network_address, read_process_output, send_process)
860 (Fprocess_send_region, status_notify):
861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
862 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
863 (wait_reading_process_output, read_process_output, exec_sentinel):
864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
865 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
866 (Faccept_process_output): Use duration_to_sec_usec to do proper
867 overflow checking on durations.
868 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
869 Don't assume pid_t fits in int.
870 * process.h (struct Lisp_Process): Members tick and update_tick
871 are now of type EMACS_INT, not int.
872 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
873 configured --with-wide-int.
874 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
875 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
876 * search.c (looking_at_1, string_match_1):
877 (fast_string_match, fast_c_string_match_ignore_case)
878 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
879 (scan_newline, find_before_next_newline, search_command)
880 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
881 (set_search_regs, wordify):
884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
885 (string_match_1, search_buffer, set_search_regs):
887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
888 (wordify): Check for overflow in size calculation.
889 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
890 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
891 Check that fixnums are in proper range for system types.
892 * sound.c (struct sound_device)
893 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
895 (Fplay_sound_internal):
896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
897 * syntax.c (struct lisp_parse_state, find_start_modiff)
898 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
899 (Fparse_partial_sexp):
900 Don't assume fixnums can fit in int.
901 (struct lisp_parse_state, find_start_pos, find_start_value)
902 (find_start_value_byte, find_start_begv)
903 (update_syntax_table, char_quoted, dec_bytepos)
904 (find_defun_start, prev_char_comend_first, back_comment):
905 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
906 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 (Finternal_describe_syntax_value): Check that match_lisp is a
909 character, not an integer, since the code stuffs it into int.
910 (scan_words, scan_sexps_forward):
911 Check that fixnums are in proper range for system types.
913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
914 (scan_sexps_forward):
915 Use CHARACTERP, not INTEGERP, since the value must fit into int.
916 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
917 * syntax.h: Adjust decls to match defn changes elsewhere.
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
921 MOST_POSITIVE_FIXNUM.
922 * sysdep.c (wait_for_termination_1, wait_for_termination)
923 (interruptible_wait_for_termination, mkdir):
924 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
925 (emacs_read, emacs_write):
926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
927 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
928 and double all fit in int.
929 * term.c (set_tty_color_mode):
930 Check that fixnums are in proper range for system types.
931 * termhooks.h (struct input_event):
932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
933 * textprop.c (validate_interval_range, interval_of)
934 (Fadd_text_properties, set_text_properties_1)
935 (Fremove_text_properties, Fremove_list_of_text_properties)
936 (Ftext_property_any, Ftext_property_not_all)
937 (copy_text_properties, text_property_list, extend_property_ranges)
938 (verify_interval_modification):
939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
940 (Fnext_single_char_property_change)
941 (Fprevious_single_char_property_change):
942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
943 (copy_text_properties):
944 Check for integer overflow in index calculation.
945 * undo.c (last_boundary_position, record_point, record_insert)
946 (record_delete, record_marker_adjustment, record_change)
947 (record_property_change):
948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
949 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
951 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
952 (Fx_hide_tip, Fx_file_dialog):
953 * w32menu.c (set_frame_menubar):
954 Use ptrdiff_t, not int, for consistency with rest of code.
955 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
956 (select_window, Fdelete_other_windows_internal)
957 (window_scroll_pixel_based, window_scroll_line_based)
958 (Frecenter, Fset_window_configuration):
959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
960 (Fset_window_hscroll, run_window_configuration_change_hook)
961 (set_window_buffer, temp_output_buffer_show, scroll_command)
962 (Fscroll_other_window, Frecenter):
963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
964 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
965 Don't assume fixnum fits in int.
966 (Fset_window_scroll_bars):
967 Check that fixnums are in proper range for system types.
968 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
969 (string_pos, c_string_pos, number_of_chars, init_iterator)
970 (in_ellipses_for_invisible_text_p, init_from_display_pos)
971 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
972 (compute_display_string_end, handle_face_prop)
973 (face_before_or_after_it_pos, handle_invisible_prop)
974 (handle_display_prop, handle_display_spec, handle_single_display_spec)
975 (display_prop_intangible_p, string_buffer_position_lim)
976 (string_buffer_position, handle_composition_prop, load_overlay_strings)
977 (get_overlay_strings_1, get_overlay_strings)
978 (iterate_out_of_display_property, forward_to_next_line_start)
979 (back_to_previous_visible_line_start, reseat, reseat_to_string)
980 (get_next_display_element, set_iterator_to_next)
981 (get_visually_first_element, compute_stop_pos_backwards)
982 (handle_stop_backwards, next_element_from_buffer)
983 (move_it_in_display_line_to, move_it_in_display_line)
984 (move_it_to, move_it_vertically_backward, move_it_by_lines)
985 (add_to_log, message_dolog, message_log_check_duplicate)
986 (message2, message2_nolog, message3, message3_nolog
987 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
988 (current_message_1, truncate_echo_area, truncate_message_1)
989 (set_message, set_message_1, store_mode_line_noprop)
990 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
991 (text_outside_line_unchanged_p, check_point_in_composition)
992 (reconsider_clip_changes)
993 (redisplay_internal, set_cursor_from_row, try_scrolling)
994 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
995 (redisplay_window, find_last_unchanged_at_beg_row)
996 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
997 (trailing_whitespace_p, find_row_edges, display_line)
998 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
999 (display_mode_element, store_mode_line_string)
1000 (pint2str, pint2hrstr, decode_mode_spec)
1001 (display_count_lines, display_string, draw_glyphs)
1002 (x_produce_glyphs, x_insert_glyphs)
1003 (rows_from_pos_range, mouse_face_from_buffer_pos)
1004 (fast_find_string_pos, mouse_face_from_string_pos)
1005 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1007 (safe_call, init_from_display_pos, handle_fontified_prop)
1008 (handle_single_display_spec, load_overlay_strings)
1009 (with_echo_area_buffer, setup_echo_area_for_printing)
1010 (display_echo_area, echo_area_display)
1011 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1012 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1013 (redisplay_window, dump_glyph_row, display_mode_line)
1014 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1015 (handle_display_spec, display_prop_string_p):
1016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1017 (handle_single_display_spec, build_desired_tool_bar_string)
1018 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1019 (get_specified_cursor_type):
1020 Check that fixnums are in proper range for system types.
1021 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1022 (Flookup_image_map):
1023 Don't assume fixnums fit in int.
1024 (compare_overlay_entries):
1025 Avoid mishandling comparisons due to subtraction overflow.
1026 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1027 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1028 (handle_tool_bar_click):
1029 Use int, not unsigned, since we prefer signed and the signedness
1030 doesn't matter here.
1031 (get_next_display_element, next_element_from_display_vector):
1032 Use int, not EMACS_INT, when int is wide enough.
1033 (start_hourglass): Use duration_to_sec_usec to do proper
1034 overflow checking on durations.
1035 * xfaces.c (Fbitmap_spec_p):
1036 Check that fixnums are in proper range for system types.
1037 (compare_fonts_by_sort_order):
1038 Avoid mishandling comparisons due to subtraction overflow.
1039 (Fx_family_fonts, realize_basic_faces):
1040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1042 Don't assume fixnum fits in int.
1043 Use SAFE_ALLOCA_LISP, not alloca.
1044 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1045 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1046 (face_at_buffer_position, face_for_overlay_string)
1047 (face_at_string_position):
1048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1049 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1050 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1052 Check that fixnums are in proper range for system types.
1053 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1054 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1056 (Fx_change_window_property): Don't assume fixnums fit in int.
1057 * xfont.c (xfont_chars_supported):
1058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1059 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1060 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1062 * xml.c (parse_region):
1063 * xrdb.c (magic_file_p):
1064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1065 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1066 (x_get_local_selection, x_reply_selection_request)
1067 (x_handle_selection_request, wait_for_property_change):
1068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1069 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1070 short is wide enough.
1071 (x_send_client_event): Don't assume fixnum fits in int.
1072 * xterm.c (x_x_to_emacs_modifiers):
1073 Don't assume EMACS_INT overflows nicely into int.
1074 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1076 (handle_one_xevent): NATNUMP can eval its arg twice.
1077 (x_connection_closed):
1078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1079 * xterm.h: Adjust decls to match defn changes elsewhere.
1080 (struct scroll_bar): Use struct vectorlike_header
1081 rather than rolling our own approximation.
1082 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1084 2012-05-25 Glenn Morris <rgm@gnu.org>
1086 * lisp.mk (lisp): Update for more files being compiled now.
1088 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1090 * lread.c: Remove `read_pure' which makes no difference.
1091 (read_pure): Remove var.
1092 (unreadpure): Remove function.
1093 (readevalloop): Don't call read_list with -1 flag.
1094 (read1, read_vector): Don't test read_pure any more.
1095 (read_list): Simplify.
1097 * fileio.c, character.h: Minor style tweaks.
1099 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1101 * window.h (clip_changed): Remove useless declaration.
1103 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1105 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1106 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1108 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1111 This directory predates autoconf and is no longer needed nowadays.
1112 Move its few remaining bits of functionality to where they're needed.
1113 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1114 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1115 * m/template.h: Remove.
1116 * Makefile.in (M_FILE): Remove. All uses removed.
1117 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1118 * lisp.h (USE_LSB_TAG):
1119 * mem-limits.h (EXCEEDS_LISP_PTR):
1120 Use VAL_MAX, not VALBITS, in #if.
1121 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1122 (EMACS_UINT): Define unconditionally now.
1123 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1124 (BITS_PER_EMACS_INT): New constants, replacing
1125 what used to be in config.h, but not useful in #if.
1126 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1127 define them any more.
1128 (VAL_MAX): New macro.
1130 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1131 BITS_PER_EMACS_INT, in #if.
1132 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1133 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1134 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1135 * s/ms-w32.h (DATA_START):
1136 Move here from removed file m/intel386.h.
1137 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1138 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1140 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1142 Assume C89 or later.
1143 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1144 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1146 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1147 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1148 * textprop.c, tparam.c (NULL): Remove.
1149 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1150 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1151 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1152 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1153 * xterm.c (input_signal_count): Assume volatile works.
1155 2012-05-21 Ken Brown <kbrown@cornell.edu>
1157 * xgselect.c (xg_select): Fix first argument in call to 'select'
1160 2012-05-20 Ken Brown <kbrown@cornell.edu>
1162 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1163 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1165 2012-05-19 Ken Brown <kbrown@cornell.edu>
1167 * xfns.c (x_in_use): Remove `static' qualifier.
1168 * xterm.h (x_in_use): Declare.
1169 * xgselect.c: Include xterm.h.
1170 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1171 and `display_arg' (bug#9754).
1173 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1175 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1177 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1178 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1180 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1182 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1184 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1185 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1187 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1188 reference to image_cache->refcount.
1189 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1191 2012-05-17 Juri Linkov <juri@jurta.org>
1193 * search.c (Fword_search_regexp, Fword_search_backward)
1194 (Fword_search_forward, Fword_search_backward_lax)
1195 (Fword_search_forward_lax): Move functions to isearch.el
1196 (bug#10145, bug#11381).
1198 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1200 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1202 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1204 * lread.c (init_obarray): Declare Qt and Qnil as special.
1206 2012-05-14 Glenn Morris <rgm@gnu.org>
1208 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1209 Put "libexec" before "bin", for the sake of init_callproc_1.
1211 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1213 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1215 * unexaix.c: Port to more-recent AIX compilers.
1216 (report_error, report_error_1, make_hdr, copy_sym)
1217 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1218 Make arguments const char *, not char *, to avoid violations of C
1219 standard and to fix some AIX warnings reported by Gilles Pion.
1221 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1223 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1224 already have overlays loaded.
1225 (handle_single_display_spec): Before returning without displaying
1226 fringe bitmap, synchronize the bidi iterator with the main display
1227 iterator, by calling iterate_out_of_display_property.
1228 (iterate_out_of_display_property): Detect buffer iteration by
1229 testing that it->string is a Lisp string.
1230 (get_next_display_element): When the current object is exhausted,
1231 and there's something on it->stack, call set_iterator_to_next to
1232 proceed with what's on the stack, instead of returning zero.
1233 (set_iterator_to_next): If called at the end of a Lisp string,
1234 proceed to consider_string_end without incrementing string
1235 position. Don't increment display vector index past the end of
1236 the display vector. (Bug#11417)
1237 (pos_visible_p): Don't report a position visible when move_it_to
1238 stopped at the last line of window, which happens to be scanned
1239 backwards by the bidi iteration. (Bug#11464)
1241 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1243 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1244 and right-margin display specs even if the spec is invalid or we
1245 are on a TTY, and thus unable to display on the fringes.
1246 That's because the text with the property will not be displayed anyway,
1247 so we need to signal to the caller that this is a "replacing"
1248 display spec. This fixes display when the spec is invalid or we
1251 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1253 * unexaix.c (make_hdr): Fix typo in prototype.
1254 This bug broke the build on AIX. Problem reported by Gilles Pion.
1256 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1258 * keyboard.c (kbd_buffer_get_event): Read special events also in
1259 batch mode. (Bug#11415)
1261 2012-05-12 Glenn Morris <rgm@gnu.org>
1263 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1265 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1267 * lisp.mk (lisp): Add newcomment.elc.
1269 2012-05-12 Glenn Morris <rgm@gnu.org>
1271 * Makefile.in (MKDIR_P): New, set by configure.
1272 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1274 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1276 Remove unused function hourglass_started.
1277 * dispextern.h (hourglass_started):
1278 * w32fns.c (hourglass_started):
1279 * xdisp.c (hourglass_started): Remove.
1281 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1283 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1284 Update dependencies.
1286 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1288 * xgselect.c (xg_select): Put maxfds+1 into a var.
1289 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1291 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1293 2012-05-10 Dave Abrahams <dave@boostpro.com>
1295 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1296 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1298 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1300 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1301 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1302 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1303 Initialize xd_registered_buses.
1305 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1307 Untag more efficiently if USE_LSB_TAG.
1308 This is based on a proposal by YAMAMOTO Mitsuharu in
1309 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1310 For an admittedly artificial (nth 8000 longlist) benchmark on
1311 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1312 Emacs's overall text size by 1%.
1313 * lisp.h (XUNTAG): New macro.
1314 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1315 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1316 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1317 * eval.c (Fautoload):
1318 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1319 * frame.h (XFRAME): Use XUNTAG.
1321 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1322 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1323 Remove unportable assumptions about print widths of types like
1325 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1326 intptr_t when converting between pointer and integer, to avoid GCC
1327 warnings about wrong width.
1329 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1331 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1332 stack for each reader_thread, instead of defaulting to 8MB
1333 determined by the linker. This avoids failures in creating
1334 subprocesses on Windows 7, see the discussion in this thread:
1335 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1337 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1339 Fix up display of the *Minibuf-0* buffer in the mini window.
1340 * keyboard.c (read_char): Don't clear the echo area if there's no
1342 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1343 contents of *Minibuf-0*) if there's no message displayed in its stead.
1345 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1347 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1350 2012-05-06 Chong Yidong <cyd@gnu.org>
1352 * lisp.mk (lisp): Update.
1354 2012-05-05 Jim Meyering <meyering@redhat.com>
1356 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1358 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1360 * data.c (PUT_ERROR): New macro.
1361 (syms_of_data): Use it. Add new error type `user-error'.
1362 * undo.c (user_error): New function.
1363 (Fprimitive_undo): Use it.
1364 * print.c (print_error_message): Adjust print style for `user-error'.
1365 * keyboard.c (user_error): New function.
1366 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1368 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1370 Do not limit current-time-string to years 1000..9999.
1371 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1372 (Fcurrent_time_string): Support any year that is supported by the
1373 underlying localtime representation. Don't use asctime, as it
1374 has undefined behavior for years outside the range -999..9999.
1376 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1378 Fix race conditions involving setenv, gmtime, localtime, asctime.
1379 Without this fix, interrupts could mess up code that uses these
1380 nonreentrant functions, since setting TZ invalidates existing
1381 tm_zone or tzname values, and since most of these functions return
1382 pointers to static storage.
1383 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1384 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1385 Grow the critical sections to include not just invoking
1386 localtime/gmtime, but also accessing these functions' results
1387 including their tm_zone values if any, and any related TZ setting.
1388 (format_time_string): Last arg is now struct tm *, not struct tm **,
1389 so that the struct tm is saved in the critical section.
1390 All callers changed. Simplify allocation of initial buffer, partly
1391 motivated by the fact that memory allocation needs to be outside
1392 the critical section.
1394 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1396 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1397 with RESET_INTERVAL.
1399 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1400 Remove duplicated buffer name initialization.
1402 2012-05-02 Jim Meyering <jim@meyering.net>
1404 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1406 * xfns.c (x_window): Use xstrdup (Bug#11375).
1408 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1410 * xdisp.c (pos_visible_p): If already at a newline from the
1411 display string before the 'while' loop, don't walk back the glyphs
1412 from it3.glyph_row. Solves assertion violation when the display
1413 string begins with a newline (egg.el). (Bug#11367)
1415 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1417 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1420 2012-05-01 Glenn Morris <rgm@gnu.org>
1422 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1423 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1424 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1425 All were removed before 23.1.
1427 * dispnew.c: Remove HAVE_LIBNCURSES test;
1428 it is always true on relevant platforms.
1430 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1431 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1433 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1435 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1437 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1438 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1441 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1443 Do not avoid creating empty evaporating overlays (Bug#9642).
1444 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1445 That is, do not delete an evaporating overlay if it becomes
1446 empty after its bounds are adjusted to fit within its buffer.
1447 This fix caused other problems, and I'm reverting it until we get
1448 to the bottom of them.
1450 2012-04-27 Chong Yidong <cyd@gnu.org>
1452 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1454 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1456 * xdisp.c (pos_visible_p): If the window start position is beyond
1457 ZV, start the display from buffer beginning. Prevents assertion
1458 violation in init_iterator when the minibuffer window is scrolled
1461 * window.c (window_scroll_pixel_based): Likewise.
1463 2012-04-27 Chong Yidong <cyd@gnu.org>
1465 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1467 2012-04-27 Glenn Morris <rgm@gnu.org>
1469 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1470 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1472 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1474 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1475 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1477 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1479 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1480 display element, check also the underlying string or buffer
1481 character. (Bug#11341)
1483 * w32menu.c: Include w32heap.h.
1484 (add_menu_item): If the call to AppendMenuW (via
1485 unicode_append_menu) fails, disable Unicode menus only if we are
1486 running on Windows 9X/Me.
1488 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1490 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1491 (xgetint): Add missing shift for LSB tags.
1493 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1495 * keyboard.c (read_char): Don't wipe echo area for select window
1496 events: These might get delayed via `mouse-autoselect-window'
1499 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1501 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1502 manipulation of :loaded-from data.
1504 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1506 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1507 now a cons (bug#11311).
1509 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1511 Do not create empty overlays with the evaporate property (Bug#9642).
1512 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1513 if it becomes empty after its bounds are adjusted to fit within
1514 its buffer. Without this fix, in a nonempty buffer (let ((o
1515 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1516 yields an empty overlay that has the evaporate property, which is
1517 not supposed to happen.
1519 Fix minor GTK3 problems found by static checking.
1520 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1521 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1522 (struct _EmacsFixedClass, emacs_fixed_get_type):
1523 Move decls here from emacsgtkfixed.h, since they needn't be public.
1524 (emacs_fixed_get_type): Now static.
1525 (emacs_fixed_class_init): Omit unused local.
1526 (emacs_fixed_child_type): Remove; unused.
1527 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1528 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1529 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1530 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1531 (EMACS_FIXED_GET_CLASS): Remove; unused.
1532 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1534 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1535 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1537 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1539 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1540 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1541 (__malloc_size_t, __malloc_ptrdiff_t):
1542 Remove. All uses removed, replaced by the definiens if needed,
1543 since we can assume C89 or better now.
1544 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1545 (protect_malloc_state, align, get_contiguous_space)
1546 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1547 (malloc_atfork_handler_child, malloc_enable_thread)
1548 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1549 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1550 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1551 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1552 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1553 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1554 Define using prototypes, not old style.
1555 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1556 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1557 (align): Don't assume that signed integer overflow wraps around.
1558 Omit unused local var.
1559 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1560 (_free_internal_nolock, memalign, mallochook, reallochook):
1561 Omit no-longer-needed casts.
1562 (valloc): Use getpagesize, not __getpagesize.
1563 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1564 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1566 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1568 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1570 Move functions from C to Lisp. Make non-blocking method calls
1571 the default. Implement further D-Bus standard interfaces.
1573 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1574 (QCdbus_request_name_allow_replacement)
1575 (QCdbus_request_name_replace_existing)
1576 (QCdbus_request_name_do_not_queue)
1577 (QCdbus_request_name_reply_primary_owner)
1578 (QCdbus_request_name_reply_in_queue)
1579 (QCdbus_request_name_reply_exists)
1580 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1581 (QCdbus_registered_serial, QCdbus_registered_method)
1582 (QCdbus_registered_signal): New Lisp objects.
1583 (XD_DEBUG_MESSAGE): Use sizeof.
1584 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1585 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1586 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1587 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1588 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1589 (xd_signature, xd_append_arg): Allow float for integer types.
1590 (xd_get_connection_references): New function.
1591 (xd_get_connection_address): Rename from xd_initialize.
1592 Return cached address.
1593 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1594 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1596 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1597 Return number of refcounts.
1598 (Fdbus_get_unique_name): Make stronger parameter check.
1599 (Fdbus_message_internal): New defun.
1600 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1601 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1602 (Fdbus_send_signal, Fdbus_register_service)
1603 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1604 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1605 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1606 (Vdbus_compiled_version, Vdbus_runtime_version)
1607 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1608 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1609 (Vdbus_message_type_signal): New defvars.
1610 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1613 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1615 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1616 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1617 Do not assume ptrdiff_t is the same width as 'int'.
1619 * alloc.c: Handle unusual debugging option combinations.
1620 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1621 since the two debugging options are incompatible.
1622 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1624 (mem_init, mem_insert, mem_insert_fixup):
1625 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1626 (NEED_MEM_INSERT): Remove; no longer needed.
1628 2012-04-22 Leo Liu <sdl.web@gmail.com>
1630 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1632 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1634 * sysdep.c [__FreeBSD__]: Minor cleanups.
1635 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1636 Use Emacs indenting style more consistently. Avoid some casts.
1637 Use 'double' consistently rather than mixing 'float' and 'double'.
1639 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1641 * sysdep.c (list_system_processes, system_process_attributes):
1642 Add implementation for FreeBSD (Bug#5243).
1644 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1646 * lisp.mk (lisp): Update.
1648 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1650 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1651 It is never used otherwise.
1653 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1655 * print.c (print_preprocess): Only check print_depth if print-circle
1657 (print_object): Check for cycles even when print-circle is nil and
1658 print-gensym is t, but only check print_depth if print-circle is nil.
1660 2012-04-20 Chong Yidong <cyd@gnu.org>
1662 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1663 set the status to "failed" and ensure that sentinel is run.
1665 2012-04-20 Glenn Morris <rgm@gnu.org>
1667 * process.c (Fset_process_inherit_coding_system_flag)
1668 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1669 (Fmake_network_process, Fmake_serial_process): Doc fix.
1671 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1673 * xdisp.c (string_buffer_position_lim): Limit starting position to
1675 (set_cursor_from_row): If called for a mode-line or header-line
1676 row, return zero immediately.
1677 (try_cursor_movement): If inside continuation line, don't back up
1678 farther than the first row after the header line, if any.
1679 Don't consider the header-line row as "partially visible", even if
1680 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1682 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1684 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1687 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1688 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1690 configure: new option --enable-gcc-warnings (Bug#11207)
1691 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1692 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1693 (ALL_CFLAGS): Use new macros rather than old.
1694 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1695 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1696 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1697 -Wunused-result, -Wunused-variable. This should go away once
1698 the Emacs and Gnulib regex code is merged.
1699 (xmalloc, xrealloc): Now static.
1701 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1703 * dired.c (Fsystem_groups): Remove unused local.
1705 2012-04-17 Glenn Morris <rgm@gnu.org>
1707 * dired.c (Fsystem_users): Doc fix.
1709 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1711 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1712 (syms_of_dired): Add them.
1714 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1716 Fix minor alloc.c problems found by static checking.
1717 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1718 New extern decls, to avoid calling undeclared functions.
1719 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1720 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1721 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1722 (NEED_MEM_INSERT): New macro.
1723 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1724 Remove one incorrect comment and fix another.
1726 Fix minor ralloc.c problems found by static checking.
1727 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1728 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1729 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1730 (r_alloc_sbrk): Now static.
1732 Improve ralloc.c interface checking.
1733 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1734 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1735 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1736 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1737 [REL_ALLOC]: ... to here, to check interface.
1738 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1739 Remove decls. This fixes an "It stinks!".
1741 * alloc.c (which_symbols): Fix alignment issue / type clash.
1743 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1745 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1746 (struct Lisp_Misc_Any): Likewise.
1747 (struct Lisp_Free): Likewise.
1748 * alloc.c (union aligned_Lisp_Symbol): Define.
1749 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1750 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1751 (union aligned_Lisp_Misc): Define.
1752 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1753 aligned_Lisp_Misc instead of union Lisp_Misc.
1754 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1756 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1758 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1759 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1760 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1761 * s/netbsd.h, s/sol2-6.h:
1762 Remove definition of GC_MARK_STACK, since the default now works.
1763 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1764 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1765 no longer the default.
1766 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1768 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1770 * lread.c (lisp_file_lexically_bound_p):
1771 Fix hang at ";-*-\n" (bug#11238).
1773 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1775 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1776 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1778 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1780 * nsterm.m (constrainFrameRect): Always constrain when there is only
1781 one screen (Bug#10962).
1783 2012-04-13 Ken Brown <kbrown@cornell.edu>
1785 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1787 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1789 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1791 2012-04-11 Daniel Colascione <dancol@dancol.org>
1793 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1794 against is gone. It's better to use vfork now so that when Cygwin
1795 gains a new, working vfork, we use it automatically (bug#10398).
1797 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1799 * window.c (save_window_save): Obey window-point-insertion-type.
1801 2012-04-11 Glenn Morris <rgm@gnu.org>
1803 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1805 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1807 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1809 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1811 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1812 (force_quit_count): New var.
1813 (handle_interrupt): Use it.
1815 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1817 * w32.c (w32_delayed_load): Record the full path of the library
1818 being loaded (bug#10424).
1820 2012-04-09 Glenn Morris <rgm@gnu.org>
1822 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1823 not just in the obarray, before snarfing them. (Bug#11036)
1825 * Makefile.in ($(leimdir)/leim-list.el):
1826 Pass EMACS rather than BUILT_EMACS.
1828 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1830 * process.c (make_process):
1831 * process.h: Add integer `gnutls_handshakes_tried' member to
1834 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1835 Add convenience `GNUTLS_LOG2i' macro.
1837 * gnutls.c (gnutls_log_function2i): Convenience log function.
1838 (emacs_gnutls_read): Use new log functions,
1839 `gnutls_handshakes_tried' process member, and
1840 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1841 attempts per process (connection).
1843 2012-04-09 Chong Yidong <cyd@gnu.org>
1845 * eval.c (Fuser_variable_p, user_variable_p_eh)
1846 (lisp_indirect_variable): Functions deleted.
1847 (Fdefvar): Caller changed.
1849 * callint.c (Finteractive, Fcall_interactively):
1850 * minibuf.c (Fread_variable): Callers changed.
1852 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1854 * xdisp.c (set_cursor_from_row): If the display string appears in
1855 the buffer at position that is closer to point than the position
1856 after the display string, display the cursor on the first glyph of
1857 the display string. Fixes cursor display when a 'display' text
1858 property immediately follows invisible text. (Bug#11094)
1860 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1862 composite.c: use 'double' consistently
1863 * composite.c (get_composition_id): Use 'double' consistently
1864 instead of converting 'float' to 'double' and vice versa; this is
1865 easier to understand and avoids a GCC warning.
1867 2012-04-09 Glenn Morris <rgm@gnu.org>
1869 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1870 preparation for dumping it with emacs. (Bug#4789)
1871 (leimdir): New variable.
1872 ($(leimdir)/leim-list.el): New rule.
1873 (emacs$(EXEEXT)): Depend on leim-list.el.
1875 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1876 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1877 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1879 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1881 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1884 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1886 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1887 Remove unused local variable.
1889 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1891 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1892 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1893 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1894 objects, as mark_maybe_pointer will catch them otherwise.
1895 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1896 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1898 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1900 Fix typo that broke non-Windows builds.
1901 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1903 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1905 Support building on MS-Windows with libxml2.
1907 * makefile.w32-in (OBJ2): Add xml.$(O).
1908 (GLOBAL_SOURCES): Add xml.c.
1909 ($(BLD)/xml.$(O)): New dependency list.
1911 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1912 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1913 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1914 [!WINDOWSNT]: New macros.
1915 (init_libxml2_functions, libxml2_loaded_p): New functions.
1916 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1917 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1918 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1919 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1921 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1922 Call init_libxml2_functions before calling libxml2 functions.
1923 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1925 * emacs.c: Don't include libxml/parser.h.
1926 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1927 xmlCleanupParser directly.
1929 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1931 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1933 * indent.c (Fvertical_motion): If there is a display string at
1934 point, use it.vpos to compute how many lines to backtrack after
1935 move_it_to point. (Bug#11133)
1937 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1939 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1940 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1941 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1942 macros related to unification of CJK characters. For the details,
1943 see the discussion following the message here:
1944 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1946 2012-04-04 Chong Yidong <cyd@gnu.org>
1948 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1950 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1952 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1953 instead of alloca. (Bug#11138)
1955 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1957 * w32menu.c (is_simple_dialog): Properly check lisp types.
1960 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1962 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1963 position we get to after a call to move_it_to fails the
1964 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1965 only if we wind up in a string from display property. (Bug#11063)
1967 * window.c (Fdelete_other_windows_internal): Invalidate the row
1968 and column information about mouse highlight, so that redisplay
1969 restores it after reallocating the glyph matrices. (Bug#7464)
1971 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1972 string comes from a `display' text property, use the buffer
1973 position of that property as if we actually saw that position in
1975 (move_it_by_lines): Remove the assertion that
1976 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1977 violated when there's a before-string at the beginning of a line.
1980 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1982 * xdisp.c (append_space_for_newline): If the default face was
1983 remapped, use the remapped face for the appended newline.
1984 (extend_face_to_end_of_line): Use the remapped default face for
1985 extending the face to the end of the line.
1986 (display_line): Call extend_face_to_end_of_line when the default
1987 face was remapped. (Bug#11068)
1989 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1991 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1993 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1995 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1997 2012-03-27 Glenn Morris <rgm@gnu.org>
1999 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2002 2012-03-26 Kenichi Handa <handa@m17n.org>
2004 * dispextern.h (struct glyph): Fix previous change. Change the
2005 bit length of glyphless.ch to 25 (Bug#11082).
2007 2012-03-26 Chong Yidong <cyd@gnu.org>
2009 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2010 (command_loop_1): Use it; inhibit selection update for
2011 handle-select-window too (Bug#8996).
2013 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2015 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2017 2012-03-25 Kenichi Handa <handa@m17n.org>
2019 * dispextern.h (struct glyph): Change the bit length of
2020 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2022 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2024 * s/ms-w32.h (tzname): Include time.h before redirecting to
2025 _tzname. Fixes the MSVC build. (Bug#9960)
2027 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2029 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2032 * xterm.c (XTread_socket): Only modify handling_signal if
2033 !SYNC_INPUT. (Bug#11080)
2035 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2037 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2038 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2039 when fetching a multibyte character consumes more bytes than
2040 CHAR_BYTES returns, due to unification of CJK characters in
2041 string_char. (Bug#11073)
2043 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2045 * process.c (wait_reading_process_output): Handle pty disconnect
2046 by refraining from sending oneself a SIGCHLD (bug#10933).
2048 2012-03-22 Chong Yidong <cyd@gnu.org>
2050 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2052 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2053 Mark string as coming from a prefix property.
2054 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2055 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2057 2012-03-21 Chong Yidong <cyd@gnu.org>
2059 * xfaces.c (Vface_remapping_alist): Doc fix.
2061 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2063 * w32proc.c (Fw32_set_console_codepage)
2064 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2067 2012-03-20 Chong Yidong <cyd@gnu.org>
2069 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2070 to reflect default non-nil value of redisplay-dont-pause.
2072 2012-03-19 Kenichi Handa <handa@m17n.org>
2074 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2075 it fit in a valid range (Bug#11003).
2077 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2079 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2080 that is not from display property, accept the row as a "cursor
2081 row" if one of the string's character has a non-nil `cursor'
2082 property. Fixes cursor positioning when there are newlines in
2083 overlay strings, e.g. in icomplete.el. (Bug#11035)
2085 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2087 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2089 2012-03-12 Chong Yidong <cyd@gnu.org>
2091 * eval.c (inhibit_lisp_code): Rename from
2092 inhibit_window_configuration_change_hook; move from window.c.
2094 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2095 * window.c (run_window_configuration_change_hook)
2096 (syms_of_window): Callers changed.
2098 2012-03-11 Chong Yidong <cyd@gnu.org>
2100 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2102 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2104 2012-03-10 Chong Yidong <cyd@gnu.org>
2106 * frame.c (other_visible_frames): Don't assume the selected frame
2107 is visible (Bug#10955).
2109 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2111 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2113 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2115 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2116 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2119 2012-03-03 Glenn Morris <rgm@gnu.org>
2121 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2123 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2125 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2126 position past the first glyph_row that ends at ZV. (Bug#10902)
2127 (redisplay_window, next_element_from_string): Fix typos in
2129 (redisplay_window): Pass to move_it_vertically the margin in
2130 pixels, not in screen lines.
2132 2012-03-02 Glenn Morris <rgm@gnu.org>
2134 * buffer.c (buffer-list-update-hook): Doc fix.
2136 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2138 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2139 push_it before setting up the iterator for the first overlay
2140 string, even if we have an empty string loaded.
2141 (next_overlay_string): If there's an empty string on the iterator
2142 stack, pop the stack. (Bug#10903)
2144 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2146 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2147 Suggested by Stefan Monnier in
2148 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2149 * alloc.c (widen_to_Lisp_Object): New static function.
2150 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2151 and widening them to Lisp_Objects. This would work even if
2152 USE_LSB_TAG is defined and wide integers are used, which might
2153 happen in a future version of Emacs.
2155 2012-02-25 Chong Yidong <cyd@gnu.org>
2157 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2160 * xselect.c (Fx_selection_exists_p): Doc fix.
2161 (x_clipboard_manager_save_all): Print an informative message
2162 before saving to clipboard manager.
2164 2012-02-24 Chong Yidong <cyd@gnu.org>
2166 * keyboard.c (process_special_events): Handle all X selection
2167 requests in kbd_buffer, not just the next one (Bug#8869).
2169 2012-02-23 Chong Yidong <cyd@gnu.org>
2171 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2172 call when setting menu-bar-lines and tool-bar-lines parameters.
2173 (unwind_create_frame_1): New helper function.
2175 * window.c (inhibit_window_configuration_change_hook): New var.
2176 (run_window_configuration_change_hook): Obey it.
2177 (syms_of_window): Initialize it.
2179 2012-02-22 Chong Yidong <cyd@gnu.org>
2181 * xterm.c (x_draw_image_relief): Add missing type check for
2182 Vtool_bar_button_margin (Bug#10743).
2184 2012-02-21 Chong Yidong <cyd@gnu.org>
2186 * fileio.c (Vfile_name_handler_alist): Doc fix.
2188 * buffer.c (Fget_file_buffer): Protect against invalid file
2189 handler return value.
2191 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2193 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2194 when computing $valmask.
2196 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2197 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2198 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2199 It's useless in that case, and it can cause problems on hosts
2200 that allocate halves of EMACS_INT values separately.
2201 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2202 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2203 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2204 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2205 it avoids undefined behavior on hosts where shifting right by more
2206 than the word width has undefined behavior.
2208 2012-02-19 Chong Yidong <cyd@gnu.org>
2210 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2211 (Funhandled_file_name_directory, Ffile_name_as_directory)
2212 (Fdirectory_file_name, Fexpand_file_name)
2213 (Fsubstitute_in_file_name): Protect against invalid file handler
2214 return values (Bug#10845).
2216 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2218 * .gdbinit (pitx): Fix incorrect references to fields of the
2221 2012-02-17 Chong Yidong <cyd@gnu.org>
2223 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2225 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2227 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2228 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2230 2012-02-15 Chong Yidong <cyd@gnu.org>
2232 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2233 marked as special. Also, starting docstrings with * is obsolete.
2235 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2237 * gnutls.c (emacs_gnutls_write): Fix last change.
2239 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2241 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2244 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2246 * keymap.c (Fsingle_key_description): Handle char ranges.
2248 2012-02-12 Chong Yidong <cyd@gnu.org>
2250 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2251 as that creates a dangerous corner case.
2253 * window.c (Fdelete_window_internal): Invalidate the mouse
2254 highlight (Bug#9904).
2256 2012-02-12 Glenn Morris <rgm@gnu.org>
2258 * xselect.c (Fx_own_selection_internal)
2259 (Fx_get_selection_internal, Fx_disown_selection_internal)
2260 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2261 * nsselect.m (Fx_own_selection_internal)
2262 (Fx_disown_selection_internal, Fx_selection_exists_p)
2263 (Fx_selection_owner_p, Fx_get_selection_internal):
2264 Sync docs and argument specs with the xselect.c versions.
2266 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2268 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2270 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2272 * w32select.c (Fx_selection_exists_p): Sync doc string and
2273 argument list with xselect.c. (Bug#10783)
2275 * w16select.c (Fx_selection_exists_p): Sync doc string and
2276 argument list with xselect.c. (Bug#10783)
2278 2012-02-10 Glenn Morris <rgm@gnu.org>
2280 * fns.c (Fsecure_hash): Doc fix.
2282 2012-02-09 Kenichi Handa <handa@m17n.org>
2284 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2286 2012-02-07 Chong Yidong <cyd@gnu.org>
2288 * buffer.c (Fbuffer_local_variables)
2289 (buffer_lisp_local_variables): Handle unbound vars correctly;
2290 don't let Qunbound leak into Lisp.
2292 2012-02-07 Glenn Morris <rgm@gnu.org>
2294 * image.c (Fimagemagick_types): Doc fix.
2296 * image.c (imagemagick-render-type): Change it from a lisp object
2297 to an integer. Move the doc here from the lisp manual.
2298 Treat all values not equal to 0 the same.
2300 2012-02-06 Chong Yidong <cyd@gnu.org>
2302 * doc.c (store_function_docstring): Avoid applying docstring of
2303 alias to base function (Bug#2603).
2305 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2307 * .gdbinit (pp1, pv1): Remove redundant defines.
2310 2012-02-04 Chong Yidong <cyd@gnu.org>
2312 * nsterm.m: Declare a global (Bug#10694).
2314 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2316 * w32.c (get_emacs_configuration_options):
2317 Include --enable-checking, if specified, in the return value.
2319 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2321 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2322 after rounding frame sizes. (Bug#9723)
2324 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2326 * keyboard.c (adjust_point_for_property): Don't position point
2327 before BEGV. (Bug#10696)
2329 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2331 Handle overflow when computing char display width (Bug#9496).
2332 * character.c (char_width): Return EMACS_INT, not int.
2333 (char_width, c_string_width): Check for overflow when
2334 computing the width; this is possible now that individual
2335 characters can have unbounded width. Problem introduced
2336 by merge from Emacs 23 on 2012-01-19.
2338 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2340 * dbusbind.c (Fdbus_register_method): Mention the return value
2341 :ignore in the docstring.
2343 2012-02-02 Glenn Morris <rgm@gnu.org>
2345 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2347 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2348 Unconditionally set to t. (Bug#10673)
2349 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2350 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2351 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2353 2012-02-02 Kenichi Handa <handa@m17n.org>
2355 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2356 0, do not call append_composite_glyph.
2358 2012-02-02 Kenichi Handa <handa@m17n.org>
2360 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2362 (x_produce_glyphs): If the component of a composition is a null
2363 string, set it->pixel_width to 1 to avoid zero-width glyph.
2365 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2367 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2368 first 2 arguments are identical. This makes inserting large
2369 output from a subprocess an order of magnitude faster on
2370 MS-Windows, where all sbrk'ed memory is always contiguous.
2372 2012-01-31 Glenn Morris <rgm@gnu.org>
2374 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2375 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2376 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2378 2012-01-29 Glenn Morris <rgm@gnu.org>
2380 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2382 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2384 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2386 2012-01-28 Chong Yidong <cyd@gnu.org>
2388 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2390 2012-01-26 Chong Yidong <cyd@gnu.org>
2392 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2394 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2395 repeat counts (Bug#10507).
2397 2012-01-26 Glenn Morris <rgm@gnu.org>
2399 * lread.c (syms_of_lread): Doc fix.
2401 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2403 * coding.c (encode_designation_at_bol): Change return value to
2406 2012-01-25 Chong Yidong <cyd@gnu.org>
2408 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2410 2012-01-21 Chong Yidong <cyd@gnu.org>
2412 * floatfns.c (Fcopysign): Make the second argument non-optional,
2413 since nil is not allowed anyway.
2415 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2417 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2418 (send_process): Likewise.
2420 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2422 * window.c (save_window_save, Fcurrent_window_configuration)
2423 (Vwindow_persistent_parameters): Do not use Qstate.
2424 Rewrite doc-strings.
2426 2012-01-19 Kenichi Handa <handa@m17n.org>
2428 * character.c (char_width): New function.
2429 (Fchar_width, c_string_width, lisp_string_width):
2430 Use char_width (Bug#9496).
2432 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2434 * window.c (Vwindow_persistent_parameters): New variable.
2435 (Fset_window_configuration, save_window_save): Handle persistent
2438 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2440 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2441 thrashing the stack of the thread. (Bug#9087)
2443 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2445 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2447 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2449 * xdisp.c (rows_from_pos_range): Handle the case where the
2450 highlight ends on a newline. (Bug#10464)
2451 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2452 he end column for display of highlight that ends on a newline
2455 2012-01-11 Glenn Morris <rgm@gnu.org>
2457 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2458 from load-path also when installation-directory is nil. (Bug#10208)
2460 2012-01-10 Glenn Morris <rgm@gnu.org>
2462 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2464 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2465 Update template values to be closer to their typical values these days.
2467 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2469 * xdisp.c (rows_from_pos_range): Accept additional argument
2470 DISP_STRING, and accept any glyph in a row whose object is that
2471 string as eligible for mouse highlight. Fixes mouse highlight of
2472 display strings from overlays. (Bug#10464)
2474 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2476 emacs: fix an auto-save permissions race condition (Bug#10400)
2477 * fileio.c (auto_saving_dir_umask): New static var.
2478 (Fmake_directory_internal): Use it.
2479 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2480 creating the directory. The old code temporarily assigns
2481 too-generous permissions to the directory.
2482 (do_auto_save_eh): Clear it.
2483 (Fdo_auto_save): Catch all errors, not just file errors, so
2484 that the var is always cleared.
2486 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2488 * search.c (scan_buffer): Pass character positions to
2489 know_region_cache, not byte positions. (Bug#6540)
2491 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2493 * w32.c (sys_rename): Report EXDEV when rename of a directory
2494 fails because the target is on another logical disk. (Bug#10284)
2496 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2498 * xterm.c (x_embed_request_focus): New function.
2500 * xterm.h: Add prototype.
2502 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2504 2012-01-05 Glenn Morris <rgm@gnu.org>
2506 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2508 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2510 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2511 Load gnutls_transport_set_lowat only if GnuTLS version is below
2513 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2514 GnuTLS versions below 2.11.1.
2516 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2518 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2519 to the doc string advising against its use for altering the way
2520 windows are scrolled.
2522 2011-12-28 Kenichi Handa <handa@m17n.org>
2524 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2525 coding-system ASCII compatible only when it does not produce BOM
2526 on encoding (Bug#10383).
2528 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2530 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2532 (create_and_show_popup_menu): Always use menu_position_func for
2535 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2537 * callint.c (Fcall_interactively): Don't truncate prompt string.
2539 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2541 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2542 property that ends at ZV, so that the bidi iteration could be
2543 resumed from there (after widening). (Bug#10360)
2545 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2547 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2549 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2551 * nsterm.m (x_free_frame_resources):
2552 Release f->output_data.ns->miniimage.
2553 (ns_index_color): Fix indentation. Do not retain
2554 color_table->colors[i].
2556 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2559 * nsfns.m (x_set_background_color): Assign return value from
2560 ns_index_color to face-background instead of NSColor*.
2561 (ns_implicitly_set_icon_type): Fix indentation.
2562 Change assignment in for loop to comparison.
2564 * emacs.c (ns_pool): New variable.
2565 (main): Assign ns_pool.
2566 (Fkill_emacs): Call ns_release_autorelease_pool.
2568 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2569 autorelease fdesc, release fdAttrs and tdict.
2570 (ns_get_covering_families): Release charset.
2571 (ns_findfonts): Release NSFontDescriptor created with new.
2572 (ns_uni_to_glyphs): Fix indentation.
2573 (setString): Release attrStr before assigning new value.
2575 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2577 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2579 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2580 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2582 2011-12-18 David Reitter <reitter@cmu.edu>
2584 * nsterm.m (ns_term_init): Subscribe for notifications
2585 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2586 to method trackingNotification in EmacsMenu.
2588 * nsmenu.m (trackingMenu): New variable.
2589 (trackingNotification): New method (from Aquamacs).
2590 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2591 from Aquamacs (Bug#7030).
2593 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2595 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2596 (symbol_to_nsstring): Fix indentation.
2597 (ns_symbol_to_pb): New function.
2598 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2599 (Fns_rotate_cut_buffers_internal): Remove.
2600 (Fns_store_selection_internal): Rename from
2601 Fns_store_cut_buffer_internal.
2602 (ns_get_foreign_selection, Fx_own_selection_internal)
2603 (Fx_disown_selection_internal, Fx_selection_exists_p)
2604 (Fns_get_selection_internal, Fns_store_selection_internal):
2605 Use ns_symbol_to_pb and check if return value is nil.
2606 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2607 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2608 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2609 renamed to Sns_store_selection_internal.
2610 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2611 and remove this function.
2612 (ns_handle_selection_clear): Remove, never used.
2613 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2616 2011-12-17 Ken Brown <kbrown@cornell.edu>
2618 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2619 GID is unknown (Bug#10257).
2621 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2623 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2624 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2625 which caused a build failure on GNU/Linux IA-64. This problem was
2626 introduced by my 2011-10-07 patch.
2628 2011-12-15 Juri Linkov <juri@jurta.org>
2630 * image.c (imagemagick_error): New function. (Bug#10112)
2631 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2632 Use `imagemagick_error' where ImageMagick functions return
2634 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2637 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2639 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2640 fill background (Bug#8992).
2642 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2644 * window.c (Vwindow_combination_resize)
2645 (Vwindow_combination_limit): Use t instead of non-nil in
2647 (Vrecenter_redisplay): Add first sentence of doc-string on
2649 (Frecenter): Fix doc-string typo.
2651 2011-12-11 Kenichi Handa <handa@m17n.org>
2653 * coding.c (Funencodable_char_position): Pay attention to the
2654 buffer text relocation (Bug#9389).
2656 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2658 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2659 gtk_init (Bug#10100).
2661 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2663 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2664 IT->string is nil. (Bug#10263)
2666 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2668 * nsterm.h (x_free_frame_resources): Declare.
2670 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2671 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2673 * nsterm.h (ns_get_defaults_value): Declare.
2675 * nsterm.m (ns_default): Call ns_get_defaults_value.
2677 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2679 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2682 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2684 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2685 that where the value of an _OBJC_* symbol points to is in the .bss
2686 section (Bug#10240).
2688 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2690 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2691 after the loop to call ccl_driver at least once (Bug#8619).
2693 2011-12-08 Kenichi Handa <handa@m17n.org>
2695 * ftfont.c (get_adstyle_property): Fix previous change
2698 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2700 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2701 dirs from the default value of EMACSLOADPATH (bug#10208).
2703 2011-12-07 Glenn Morris <rgm@gnu.org>
2705 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2706 installation and source directories as well. (Bug#10208)
2708 2011-12-06 Chong Yidong <cyd@gnu.org>
2710 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2712 2011-12-06 Glenn Morris <rgm@gnu.org>
2714 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2715 as an error, not just -1. (Bug#10217)
2717 2011-12-05 Chong Yidong <cyd@gnu.org>
2719 * keyboard.c (process_special_events): New function.
2720 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2722 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2724 * coding.c (encode_designation_at_bol): Don't use uninitialized
2725 local variable (Bug#9318).
2727 2011-12-05 Kenichi Handa <handa@m17n.org>
2729 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2730 return Qnil (Bug#8046, Bug#10193).
2732 2011-12-05 Kenichi Handa <handa@m17n.org>
2734 * coding.c (encode_designation_at_bol): New args charbuf_end and
2735 dst. Return the number of produced bytes. Callers changed.
2736 (coding_set_source): Return how many bytes coding->source was
2738 (coding_set_destination): Return how many bytes
2739 coding->destination was relocated.
2740 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2741 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2743 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2745 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2746 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2749 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2751 The following changes are to fix Bug#9318.
2753 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2754 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2755 (encode_coding_iso_2022, encode_coding_sjis)
2756 (encode_coding_big5, encode_coding_charset): Use the above macros.
2758 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2760 * lisp.h (process_quit_flag): Fix external declaration.
2762 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2764 Don't macro-inline non-performance-critical code.
2765 * eval.c (process_quit_flag): New function.
2766 * lisp.h (QUIT): Use it.
2768 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2770 * nsfns.m (get_geometry_from_preferences): New function.
2771 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2773 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2775 * emacs.c (Qkill_emacs): Define.
2776 (syms_of_emacs): Initialize it.
2777 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2778 Qquit_flag to `kill-emacs' instead.
2779 (quit_throw_to_read_char): Add parameter `from_signal'.
2780 All callers changed. Call Fkill_emacs if requested and safe.
2781 * lisp.h (QUIT): Call Fkill_emacs if requested.
2783 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2785 * widget.c (update_wm_hints): Return if wmshell is null.
2786 (widget_update_wm_size_hints): New function.
2788 * widget.h (widget_update_wm_size_hints): Declare.
2790 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2791 widget_update_wm_size_hints (Bug#10104).
2793 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2795 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2796 before a newline, prepare the bidi iterator for consuming the
2797 newline, and keep the current paragraph direction. (Bug#10183)
2798 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2800 2011-12-02 Juri Linkov <juri@jurta.org>
2802 * search.c (Fword_search_regexp): New Lisp function created from
2803 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2804 (Fword_search_backward, Fword_search_forward)
2805 (Fword_search_backward_lax, Fword_search_forward_lax):
2806 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2807 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2809 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2811 * fileio.c (Finsert_file_contents): Move after-change-function call
2812 to before the "handled:" label, since all "goto handled" appear in
2813 cases where the *-change-functions have already been properly called
2816 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2818 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2819 waiting for input. (Bug#10169)
2821 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2823 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2824 verifies glyph row's hash code--we have just reallocated the
2825 glyphs, so their contents can be complete garbage. (Bug#10164)
2827 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2829 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2831 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2833 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2834 attributes are tested _before_ calling verify_row_hash, to protect
2835 against GCC re-ordering of the tests. (Bug#10164)
2837 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2839 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2841 * xterm.c (handle_one_xevent): Only set async_visible and friends
2842 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2843 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2844 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2846 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2848 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2849 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2850 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2851 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2852 All uses changed to use GCPRO1 etc.
2853 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2854 Revert to old implementation (i.e., before 2011-03-11).
2856 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2858 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2859 of scroll runs so as to avoid assigning disabled bogus rows and
2860 unnecessary graphics copy operations.
2862 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2864 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2865 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2866 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2867 (malloc, free, realloc, calloc): Redirect to e_* only when
2870 * lisp.h (GCTYPEBITS): Move before first use.
2871 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2872 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2873 this macro definition.
2875 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2878 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2880 * gtkutil.c (xg_create_frame_widgets):
2881 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2882 present with Gtk+ 2.0.
2884 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2886 * fileio.c (Finsert_file_contents): Undo previous change; see
2887 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2889 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2891 Rename locals to avoid shadowing.
2892 * fileio.c (Finsert_file_contents):
2893 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2894 * process.c (wait_reading_process_output):
2895 Rename inner 'proc' to 'p' to avoid shadowing.
2896 Indent for consistency with usual Emacs style.
2898 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2900 * xdisp.c (redisplay_window): If cursor row is not fully visible
2901 after recentering, and scroll-conservatively is set to a large
2902 number, scroll window by a few more lines to make the cursor fully
2903 visible and out of scroll-margin. (Bug#10105)
2904 (start_display): Don't move to the next line if the display should
2905 start at a newline that is part of a display vector or an overlay
2908 2011-11-24 Juri Linkov <juri@jurta.org>
2910 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2911 after the `MagickPingImage' call. (Bug#10112)
2913 2011-11-23 Chong Yidong <cyd@gnu.org>
2915 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2917 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2919 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2920 making another buffer current. (Bug#10114)
2922 2011-11-23 Glenn Morris <rgm@gnu.org>
2924 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2926 2011-11-23 Chong Yidong <cyd@gnu.org>
2928 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2929 using it (Bug#5984).
2931 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2933 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2934 and header-lines, as they don't have one computed for them.
2937 * .gdbinit (prow): Make displayed values more self-explaining.
2938 Add row's hash code.
2940 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2942 * process.c (wait_reading_process_output): Fix asynchrounous
2943 GnuTLS socket handling on some versions of the GnuTLS library.
2944 (wait_reading_process_output): Add comment and URL.
2946 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2948 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2950 2011-11-21 Chong Yidong <cyd@gnu.org>
2952 * window.c (Fnext_window, Fprevious_window): Doc fix.
2954 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2956 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2958 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2960 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2962 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2964 * window.c (Fset_window_combination_limit): Rename argument
2966 (Vwindow_combination_limit): Remove "status" from doc-string.
2968 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2970 * m/ibms390.h: Remove.
2971 * m/ibms390x.h: Don't include "ibms390.h".
2973 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2975 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2976 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2978 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2980 * casetab.c (Fset_case_table):
2981 * charset.c (Fcharset_after): Fix typos.
2983 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2985 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2986 Otherwise, valgrind does not work on some platforms.
2987 Problem reported by Andreas Schwab in
2988 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2989 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2990 is set, removing the need for VIRT_ADDRESS_VARIES.
2991 (PURE_P): Use a more-efficient implementation that needs just one
2992 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2993 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2994 to 4 (xorl, subq, cmpq, setbe).
2995 * alloc.c (pure): Always extern now, since that's the
2996 VIRT_ADDR_VARIES behavior.
2997 (PURE_POINTER_P): Use a single comparison, not two, for
2998 consistency with the new puresize.h.
2999 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3000 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3001 Remove VIRT_ADDR_VARIES no longer needed.
3003 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3005 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3006 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3007 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3008 behave as if the cursor position were at the window margin.
3010 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3011 and the cursor position is out of bounds, behave as if the cursor
3012 position were at the window margin. (Bug#10075)
3014 2011-11-18 Chong Yidong <cyd@gnu.org>
3016 * window.c (Fwindow_combination_limit): Make first argument
3017 non-optional, since it is meaningless for live windows like the
3020 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3022 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3024 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3026 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3027 (graft_intervals_into_buffer): Simplify.
3029 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3031 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3032 hash values of the two rows.
3033 (copy_row_except_pointers): Preserve the used[] arrays and the
3034 hash values of the two rows. (Bug#10035)
3035 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3037 * xdisp.c (row_hash): New function, body extracted from
3038 compute_line_metrics.
3039 (compute_line_metrics): Call row_hash, instead of computing the
3042 * dispnew.c (verify_row_hash): Call row_hash for computing the
3043 hash code of a row, instead of duplicating code from xdisp.c.
3045 * dispextern.h (row_hash): Add prototype.
3047 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3049 * frame.c (delete_frame): Don't delete the terminal when the last
3050 X frame is closed if emacs is built with GTK toolkit.
3052 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3054 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3056 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3058 * window.c (Vwindow_splits): Rename to
3059 Vwindow_combination_resize. Suggested by Juri Linkov.
3060 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3063 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3065 * nsfns.m (Fns_font_name):
3066 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3068 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3070 * window.h (window): Rename slot "nest" to "combination_limit".
3071 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3072 (Fset_window_nest): Rename to Fset_window_combination_limit.
3073 (Vwindow_nest): Rename to Vwindow_combination_limit.
3074 (recombine_windows, make_parent_window, make_window)
3075 (Fsplit_window_internal, saved_window)
3076 (Fset_window_configuration, save_window_save): Rename all
3077 occurrences of window_nest to window_combination_limit.
3079 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3081 * image.c (imagemagick_load_image): Fix typo.
3083 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3085 * xdisp.c (display_line): Move the call to
3086 highlight_trailing_whitespace before the call to
3087 compute_line_metrics, since the latter needs to see the final
3088 faces of all the glyphs to compute ROW's hash value.
3089 Fixes assertion violations in row_equal_p. (Bug#10035)
3091 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3093 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3094 just return (bug#10044).
3096 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3098 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3099 with user-defined heap size. Bump the default size of the temacs
3100 heap to 27MB, to avoid memory warning when running temacs.
3101 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3103 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3104 current_matrix and desired_matrix. (Bug#9990)
3105 (verify_row_hash) [XASSERTS]: New function.
3106 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3107 that the hash value of glyph rows is correct.
3109 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3111 * window.h (window): Remove splits slot.
3112 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3113 (Fdelete_other_windows_internal, make_parent_window)
3114 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3115 (Fset_window_configuration, save_window_save): Don't deal with
3116 split status of windows.
3117 (saved_window): Remove splits slot.
3118 (Vwindow_splits): Rewrite doc-string.
3120 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3122 * xfns.c (unwind_create_frame):
3123 * nsfns.m (unwind_create_frame):
3124 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3125 Vframe_list (Bug#9999).
3127 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3129 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3131 2011-11-11 Kenichi Handa <handa@m17n.org>
3133 * callproc.c (Fcall_process): Set the member dst_multibyte of
3136 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3138 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3139 avoid a crash (bug#9496).
3141 2011-11-09 Chong Yidong <cyd@gnu.org>
3143 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3144 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3146 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3148 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3150 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3152 Avoid some portability problems by eschewing 'extern inline' functions.
3153 The trivial performance wins aren't worth the portability hassles; see
3154 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3156 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3157 (window_box_width, window_box_left, window_box_left_offset)
3158 (window_box_right, window_box_right_offset): Undo previous change,
3159 by removing the "extern"s.
3160 * intervals.c (adjust_intervals_for_insertion)
3161 (adjust_intervals_for_deletion): Undo previous change,
3162 making these static again.
3163 (offset_intervals, temp_set_point_both, temp_set_point)
3164 (copy_intervals_to_string): No longer inline.
3165 * xdisp.c (window_text_bottom_y, window_box_width)
3166 (window_box_height, window_box_left_offset)
3167 (window_box_right_offset, window_box_left, window_box_right)
3168 (window_box): No longer inline.
3170 2011-11-08 Chong Yidong <cyd@gnu.org>
3172 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3173 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3174 Signal an error if not a live window.
3175 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3176 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3178 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3180 * lisp.h (syms_of_abbrev): Remove declaration.
3181 Reported by CHENG Gao <chenggao@royau.me>.
3183 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3185 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3186 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3187 of temacs in GUI mode.
3189 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3191 * window.h: Declare delete_all_child_windows instead of
3192 delete_all_subwindows.
3193 * window.c (Fwindow_nest, Fset_window_nest)
3194 (Fset_window_new_total, Fset_window_new_normal)
3195 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3196 (delete_all_subwindows): Rename to delete_all_child_windows.
3197 (Fdelete_other_windows_internal, Fset_window_configuration):
3198 Call delete_all_child_windows instead of delete_all_subwindows.
3199 * frame.c (delete_frame): Call delete_all_child_windows instead
3200 of delete_all_subwindows.
3202 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3204 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3205 This is also needed for porting to any host where GC_MARK_STACK is
3206 not GC_MAKE_GCPROS_NOOPS.
3207 (which_symbols): Use it.
3209 2011-11-07 Kenichi Handa <handa@m17n.org>
3211 * coding.c (coding_set_destination): Check coding->src_pos only
3212 when coding->src_object is a buffer (bug#9910).
3214 * process.c (send_process): Set the member src_multibyte of coding
3215 to 0 (bug#9911) when sending a unibyte text.
3217 * callproc.c (Fcall_process): Set the member src_multibyte of
3218 process_coding to 0 (bug#9912).
3220 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3222 * xmenu.c (cleanup_widget_value_tree): New function.
3223 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3224 calling free_menubar_widget_value_tree directly (Bug#9830).
3226 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3228 Fix some portability problems with 'inline'.
3229 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3230 (window_box_width, window_box_left, window_box_left_offset)
3231 (window_box_right, window_box_right_offset): Declare extern.
3232 Otherwise, these inline functions do not conform to C99 and
3233 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3234 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3235 * intervals.c (adjust_intervals_for_insertion)
3236 (adjust_intervals_for_deletion): Now extern, because otherwise the
3237 extern inline functions 'offset_intervals' couldn't refer to it.
3238 (static_offset_intervals): Remove.
3239 (offset_intervals): Rewrite using the old contents of
3240 static_offset_intervals. The old version didn't conform to C99
3241 because an extern inline function contained a reference to an
3242 identifier with static linkage.
3244 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3246 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3249 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3251 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3252 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3253 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3254 return Qleft_to_right.
3256 2011-11-06 Chong Yidong <cyd@gnu.org>
3258 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3259 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3260 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3261 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3262 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3263 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3264 (Fwindow_vscroll): Doc fix.
3265 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3266 argument, since it makes no sense to pass a live window and for
3267 consistency with window-child.
3269 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3271 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3274 2011-11-05 Jason Rumney <jasonr@gnu.org>
3276 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3277 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3279 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3280 bitwise arithmetic preventing use of unicode-sip and non-truetype
3283 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3285 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3288 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3289 initialization code to keep similarity to xfns.c after changes
3292 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3294 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3295 (unwind_create_frame): New function (Bug#9943).
3296 (Fx_create_frame): Restructure code to be more similar to the one in
3297 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3298 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3299 Move terminal->reference_count++ just before making the frame official
3302 * nsterm.m (x_free_frame_resources): New function.
3303 (x_destroy_window): Move code to x_free_frame_resources.
3305 * xfns.c (unwind_create_frame): Fix comment.
3306 (Fx_create_frame, x_create_tip_frame):
3307 Move terminal->reference_count++ just before making the frame
3308 official. Move initialization of image_cache_refcount and
3309 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3311 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3313 Support MSVC build with newer versions of Visual Studio.
3314 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3315 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3318 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3319 which are not supported by MSVC.
3320 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3321 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3323 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3325 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3327 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3329 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3331 Support MSVC build with newer versions of Visual Studio.
3332 * w32.c: Don't include w32api.h for MSVC.
3333 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3335 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3336 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3337 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3338 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3340 (alloca) [_MSC_VER]: Define to _alloca.
3342 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3344 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3346 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3348 * xdisp.c (note_mouse_highlight): If either of
3349 previous/next-single-property-change returns nil, treat that as
3350 the beginning or the end of the buffer. (Bug#9955)
3352 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3354 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3355 label is not null (Bug#9951).
3356 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3359 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3361 * window.c (Fwindow_body_size): Mention in the doc string that the
3362 return value is in frame's canonical units. (Bug#9949)
3364 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3366 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3368 * w32fns.c (unwind_create_frame): If needed, free the glyph
3369 matrices of the partially constructed frame. (Bug#9943)
3370 * xfns.c (unwind_create_frame): Likewise.
3372 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3374 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3375 Don't stop backward scan on the continuation glyph, even though
3376 its CHARPOS is positive.
3377 (mouse_face_from_buffer_pos, note_mouse_highlight):
3378 Rename cover_string to disp_string.
3380 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3382 * window.c (temp_output_buffer_show): Don't use
3383 Vtemp_buffer_show_specifiers.
3384 (Vtemp_buffer_show_specifiers): Remove unused variable.
3386 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3388 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3389 past the beginning of the current glyph matrix.
3391 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3393 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3394 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3395 HAVE_GTK3 (Bug#9869).
3397 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3398 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3400 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3402 * xterm.c: Declare x_handle_net_wm_state to return int.
3403 (handle_one_xevent): Check if we are iconified but don't have
3404 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3405 (get_current_wm_state): Return non-zero if not hidden,
3406 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3407 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3408 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3409 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3411 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3413 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3414 so that this new function doesn't get optimized away by a
3415 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3417 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3419 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3421 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3423 Fix the `xbytecode' command.
3424 * .gdbinit (xprintbytestr): New command.
3425 (xwhichsymbols): Rename from `which'; all callers changed.
3426 (xbytecode): Print the byte-code string as well.
3428 2011-10-29 Kim Storm <storm@cua.dk>
3430 * alloc.c (which_symbols): New function.
3432 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3434 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3437 2011-10-29 Glenn Morris <rgm@gnu.org>
3439 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3440 Not clear what it was for, and it causes various bugs. (Bug#9839)
3442 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3444 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3445 possible random value that matches one of those tested as
3446 condition to clear the mouse face.
3448 2011-10-28 Chong Yidong <cyd@gnu.org>
3450 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3452 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3454 * window.c (make_window): Initialize phys_cursor_on_p.
3456 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3458 * lisp.h (struct Lisp_Symbol): Update comments.
3460 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3462 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3464 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3466 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3467 <oslsachem@gmail.com> for helping to debug this.
3469 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3470 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3471 (g_b_init_get_glyph_outline_w): New static variables.
3472 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3473 (GetGlyphOutlineW_Proc): New typedefs.
3474 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3475 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3477 (w32font_open_internal, compute_metrics):
3478 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3479 instead of calling the "wide" APIs directly.
3481 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3483 * w32.h (syms_of_w32font): Add prototype.
3485 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3487 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3488 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3489 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3490 (Fmove_to_window_line): Doc fix.
3492 2011-10-27 Chong Yidong <cyd@gnu.org>
3494 * process.c (make_process): Set gnutls_state to NULL.
3496 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3497 non-NULL, regardless of GNUTLS_INITSTAGE.
3498 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3499 an error. Set process slots as soon as we allocate them.
3501 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3503 2011-10-27 Chong Yidong <cyd@gnu.org>
3505 * gnutls.c (emacs_gnutls_deinit): New function.
3506 Deallocate credentials structures as well as calling gnutls_deinit.
3507 (Fgnutls_deinit, Fgnutls_boot): Use it.
3509 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3510 (deactivate_process): Call emacs_gnutls_deinit.
3512 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3514 * image.c (x_create_x_image_and_pixmap):
3515 * w32.c (sys_rename, w32_delayed_load):
3516 * w32font.c (fill_in_logfont):
3517 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3519 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3521 * w32fns.c (w32_default_color_map): New function,
3522 extracted from Fw32_default_color_map.
3523 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3525 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3527 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3529 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3531 * keyboard.c (test_undefined): New function (bug#9751).
3532 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3534 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3536 * sysdep.c (init_sys_modes): Fix the check for the controlling
3537 terminal (Bug#6649).
3539 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3541 * dispextern.h (struct bidi_it): New member next_en_type.
3543 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3544 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3545 current character, check also for next_en_type being WEAK_EN.
3546 (bidi_resolve_weak): Don't enter the expensive loop if the current
3547 position is before next_en_pos. Record the bidi type of the first
3548 non-ET, non-BN character we find, in addition to its position.
3549 (bidi_level_of_next_char): Invalidate next_en_type when
3550 next_en_pos is over-stepped.
3552 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3554 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3555 * editfns.c: Rewrite current-time-zone so that it invokes
3556 the equivalent of (format-time-string "%Z") to get the time zone name.
3557 This fixes a bug when the time zone name contains characters that
3558 need converting from the system time locale to Emacs internal format.
3559 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3560 that patch fixed format-time-string to do the conversion, but
3561 I forgot to fix current-time-zone.
3562 (format_time_string): New function, containing most of
3563 what Fformat_time_string used to contain.
3564 (Fformat_time_string): Rewrite in terms of format_time_string.
3565 This doesn't change this function's behavior.
3566 (current-time-zone): Rewrite to use format_time_string.
3567 This fixes the bug reported by Michael Schierl in
3568 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3569 Jason Rumney's 2007-06-07 change worked around this bug, but
3571 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3573 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3575 * xdisp.c (start_display): If the character at POS is displayed
3576 via a display vector, reset IT->current.dpvec_index to zero.
3577 (try_window_reusing_current_matrix): If a line ends in a display
3578 vector or the next line starts in a display vector, continue
3579 redrawing the window even though the character position of
3580 start_row was reached.
3583 2011-10-18 Chong Yidong <cyd@gnu.org>
3585 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3586 with nobreak-char-display too.
3588 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3590 Fix part 3 of bug#9771.
3591 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3592 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3593 non-neutral characters if the current character is a paragraph
3594 separator (a.k.a. Newline). This avoids running the same
3595 expensive loop twice, once when we consume the preceding newline
3596 and the other time when the line actually needs to be displayed.
3597 Avoid the loop when we see neutrals on the base embedding level
3598 following a character whose directionality is the same as the
3599 paragraph's. This avoids running the expensive loop when a line
3600 ends in a long sequence of neutrals, like control characters.
3601 Add assertion against STRONG_AL type. Slightly rearrange code
3602 that determines the type of a neutral given the first non-neutral
3604 (bidi_level_of_next_char): Set next_en_pos to zero when
3605 invalidating its info.
3607 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3609 * xdisp.c (push_display_prop): Determine whether to record string
3610 or buffer position by IT->string, not by IT->method. Allow
3611 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3612 (move_it_vertically_backward): Don't look for character position
3613 immediately after the newline when in a continuation line.
3616 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3618 * window.c (coordinates_in_window): Rewrite and delabelize
3619 vertical border check. (Bug#5357) (Bug#9618)
3621 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3623 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3624 errors in XSetWindowBorder (bug#9310).
3626 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3628 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3629 avoid crash when xmalloc overrun checking is enabled.
3631 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3633 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3634 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3635 cursor motion with <left> and <right> arrow keys.
3637 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3638 some callers set that themselves.
3640 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3642 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3643 display string and the previous row comes from the same string and
3644 is empty. (Bug#9739) (Bug#9738)
3646 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3648 * doc.c (get_doc_string): Encode file name (bug#9735).
3650 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3652 * bidi.c (bidi_level_of_next_char):
3653 * xdisp.c (get_visually_first_element): Remove old incorrect
3654 comments regarding the Unicode Line Separator character.
3656 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3658 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3660 * alloc.c (Fgc_status): Do not access beyond zombies array
3661 boundary if nzombies > MAX_ZOMBIES.
3662 * alloc.c (dump_zombies): Add missing format specifier.
3664 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3666 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3667 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3669 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3670 Some packages use them to denote characters with modifiers.
3672 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3674 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3675 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3676 matching a pp-number. Rename parameter var to var1.
3678 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3680 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3682 2011-10-08 Glenn Morris <rgm@gnu.org>
3684 * callint.c (Fcall_interactively): Give a more explicit error for the
3685 'c' case with a non-character input. (Bug#8479)
3687 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3689 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3691 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3692 lines that are hscrolled on the left.
3694 * dispnew.c (buffer_posn_from_coords): Account for a possible
3695 presence of header-line. (Bug#4426)
3697 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3699 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3700 Don't advertise functionality which we discourage or doesn't work.
3702 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3704 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3705 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3706 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3707 this makes Emacs dump core during garbage collection on rare
3708 occasions. sizeof is obviously inferior to offsetof here, so
3709 stick with offsetof.
3710 (GC_POINTER_ALIGNMENT): New macro.
3711 (mark_memory): Omit 3rd (offset) arg; caller changed.
3712 Don't assume EMACS_INT alignment is the same as pointer alignment.
3714 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3716 * keyboard.c (read_key_sequence_remapped): New var.
3717 (read_key_sequence): Compute remapping in the right buffer.
3718 (command_loop_1): Use read_key_sequence's remapping directly.
3720 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3722 * dired.c (file_name_completion): Don't expand file name.
3723 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3724 before checking file name handler.
3726 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3727 they've been requested explicitly (bug#9591).
3729 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3731 * keymap.c (Fsingle_key_description): Use make_specified_string
3732 instead of build_string to build string from push_key_description.
3735 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3737 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3738 This fixes a Y2038 bug on 64-bit hosts.
3739 * buffer.c (reset_buffer):
3740 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3741 (Fclear_buffer_auto_save_failure):
3742 Use 0, not -1, to represent an unset failure time, since time_t
3743 might not be signed.
3745 Remove dependency on glibc malloc internals.
3746 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3747 Move back here from lisp.h, but with their new implementations.
3748 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3749 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3750 * charset.c (charset_table_init): New static var.
3751 (syms_of_charset): Use it instead of xmalloc. This removes a
3752 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3753 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3754 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3755 Move back to alloc.c.
3756 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3757 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3759 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3761 * nsterm.m (windowDidResize): Call x_set_window_size only when
3762 ns_in_resize is true. Otherwise set pixelwidth/height and
3763 call change_frame_size (Bug#9628).
3765 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3767 Port --enable-checking=all to Fedora 14 x86-64.
3768 * charset.c (syms_of_charset): Also account for glibc malloc's
3769 internal overhead when calculating the initial malloc maximum.
3771 Port --enable-checking=all to Fedora 14 x86.
3772 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3774 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3775 (overrun_check_realloc, overrun_check_free):
3776 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3777 That way, xmalloc returns a properly-aligned pointer even if
3778 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3779 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3780 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3781 into account when calculating the initial malloc maximum.
3782 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3783 Move here from alloc.c, so that charset.c can use it too.
3784 Properly align; the old code wasn't right for common 32-bit hosts
3785 when configured with --enable-checking=all.
3786 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3787 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3789 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3791 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3794 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3796 * xdisp.c (compute_display_string_end): If there's no display
3797 string at CHARPOS, return -1.
3799 * bidi.c (bidi_fetch_char): When compute_display_string_end
3800 returns a negative value, treat the character as a normal
3801 character not covered by a display string. (Bug#9624)
3803 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3805 * lread.c (Fread_from_string): Fix typo in docstring.
3807 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3809 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3810 newline, reseat the iterator instead of bidi-iterating there one
3811 character at a time. (Bug#9610)
3812 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3813 TO_CHARPOS if the bidi iterator is at base embedding level.
3815 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3817 * lread.c (readevalloop): Use correct code for NBSP.
3818 (read1): Likewise. (Bug#9608)
3820 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3822 * dbusbind.c (Fdbus_register_signal): When service is not
3823 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3825 2011-09-25 Glenn Morris <rgm@gnu.org>
3827 * buffer.c (truncate-lines): Doc fix.
3829 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3831 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3832 (Fset_window_next_buffers): Doc fix.
3834 2011-09-24 Glenn Morris <rgm@gnu.org>
3836 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3838 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3840 Fix minor problems found by static checking.
3841 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3842 * indent.c (Fvertical_motion): Fix == vs = typo.
3844 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3846 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3847 Default value is now t. Doc fix.
3849 * indent.c (Fvertical_motion): Compute and apply the overshoot
3850 logic when moving up, not only when moving down. Fix the
3851 confusing name and values of the it_overshoot_expected variable;
3852 logic changes accordingly. (Bug#9254) (Bug#9549)
3854 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3855 CHARPOS is covered by a display string which includes newlines.
3856 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3857 is covered by a display string with embedded newlines.
3859 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3861 * dbusbind.c (Fdbus_register_signal): Add match rule to
3862 Vdbus_registered_objects_table. (Bug#9581)
3863 (Fdbus_register_method, Vdbus_registered_objects_table):
3866 2011-09-24 Jim Meyering <meyering@redhat.com>
3868 do not ignore write error for any output size
3869 The previous change was incomplete.
3870 While it makes emacs --batch detect the vast majority of stdout
3871 write failures, errors were still ignored whenever the output size is
3872 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3873 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3874 && echo FAIL: ignored write error
3875 FAIL: ignored write error
3876 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3877 && echo FAIL: ignored write error
3878 FAIL: ignored write error
3879 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3881 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3883 * emacs.c (Fkill_emacs): In noninteractive mode exit
3884 non-successfully if a write error occurred on stdout. (Bug#9574)
3886 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3888 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3891 * dispextern.h (struct it): Update the comment documenting what
3894 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3896 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3897 a display string, extend search for cursor position to end of row.
3898 (find_row_edges): If the row ends in a newline from a display
3899 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3900 Handle the case of a display string with multiple newlines.
3901 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3902 non-empty line. Fixes confusing cursor motion with arrow keys at
3903 the beginning of a line that starts with whitespace.
3905 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3907 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3910 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3912 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3915 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3917 * xdisp.c (display_line): Record maximum and minimum buffer
3918 positions even if no glyphs were produced (e.g., by a zero-width
3919 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3920 buffer positions that will be removed from the glyph row because
3922 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3923 column is beyond frame width: don't subtract 1 "pixel" when
3924 computing width of the stretch.
3925 (reseat_at_next_visible_line_start): Undo the change made on
3926 2011-09-17 that saved paragraph information and restored it after
3927 the call to `reseat'. (Bug#9545)
3929 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3931 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3932 and turn window cursor on if cleared (Bug#9415).
3934 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3936 * search.c (boyer_moore): Take unibyte characters from pattern
3937 literally. (Bug#9458)
3939 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3941 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3943 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3945 Fix minor problem found by static checking.
3946 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3947 initialized, to pacify gcc -Wuninitialized.
3949 * fileio.c: Report proper errno when syscall falls.
3950 (Finsert_file_contents): Save and restore errno,
3951 so that report_file_error outputs the correct diagnostic.
3952 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3954 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3956 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3958 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3960 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3961 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3963 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3965 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3966 about the current paragraph and restore it after the call to reseat.
3968 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3969 (bidi_find_paragraph_start): Search back for paragraph beginning
3970 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3971 (bidi_move_to_visually_next): Only trigger paragraph-related
3972 computations when the last character is a newline or at EOB, not
3973 just any NEUTRAL_B. (Bug#9470)
3975 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3976 truncated lines if point is covered by a display string. (Bug#9524)
3978 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3980 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3981 (cons_to_x_long): New function.
3982 (lisp_data_to_selection_data): Use it. Correct the test for
3983 short-versus-long data; it was negated. Break out of vector
3984 loop, for efficiency, when a long datum is discovered.
3986 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3988 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3990 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3992 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3993 GCC PR/17406) by declaring this function with external scope.
3995 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3997 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3998 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4000 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4002 * editfns.c (Fformat): Correctly handle text properties on "%%".
4004 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4006 * xterm.c (x_draw_composite_glyph_string_foreground):
4007 * w32term.c (x_draw_composite_glyph_string_foreground):
4008 * term.c (encode_terminal_code):
4009 * composite.c (composition_update_it, get_composition_id):
4010 * xdisp.c (get_next_display_element)
4011 (fill_composite_glyph_string): Add comments about special meaning
4012 of TAB characters in a composition.
4014 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4016 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4017 This occurs when processing a multibyte format.
4018 Problem reported by Wolfgang Jenker.
4020 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4022 * xdisp.c (try_cursor_movement): Only check for exact match if
4023 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4025 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4027 Remove unused external symbols.
4028 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4029 * xdisp.c (calc_pixel_width_or_height): Now static.
4030 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4031 * indent.c (check_display_width):
4032 * w32term.c: Fix comment to match code.
4033 * xterm.c, xterm.h (x_catching_errors): Remove.
4035 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4037 * xselect.c: Use signed conversions more consistently (Bug#9498).
4038 (selection_data_to_lisp_data): Assume incoming selection data are
4039 signed integers, not unsigned. This is to be consistent with
4040 outgoing selection data, which was modified to use signed integers
4041 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4042 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4043 expects long, not unsigned long.
4045 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4047 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4048 computation of loop end. Reported by Johan Bockgård
4051 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4053 * frame.c (Fother_visible_frames_p): Function deleted.
4055 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4057 * indent.c (compute_motion): Process display vector front to back
4058 rather than the other way around. (Bug#2496)
4060 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4062 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4064 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4066 * minibuf.c (Fread_from_minibuffer): Doc fix.
4068 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4070 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4071 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4073 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4075 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4076 value for non-existent files.
4078 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4080 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4081 set its "size" to -1. This will set the modtime_size field of
4082 the corresponding buffer to -1, which is what
4083 verify-visited-file-modtime expects for files that do not exist.
4086 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4088 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4090 * lisp.h: ... from here. push_key_description is no longer
4091 defined in keyboard.c, so its declaration should not be in
4092 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4093 logically belongs with push_key_description.
4095 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4097 * buffer.h: Include <sys/types.h> instead of <time.h>.
4098 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4099 Problem reported by Herbert J. Skuhra.
4101 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4103 * xml.c (parse_region): Make the parsing work for
4104 non-comment-starting XML files again (bug#9144).
4106 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4108 * image.c (gif_load): Fix calculation of bottom and right corner.
4111 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4113 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4114 redisplay in small windows.
4116 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4118 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4120 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4122 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4123 Operate on live windows only.
4125 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4127 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4129 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4131 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4132 only under bidi iteration.
4134 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4136 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4138 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4140 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4141 Without this fix, the command to link temacs failed due to an
4142 undefined symbol __builtin_isnan. This is because
4143 /usr/include/iso/math_c99.h #defines isnan(x) to
4144 __builtin_isnan(x), but the bundled gcc, which identifies itself
4145 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4147 * floatfns.c (isnan): #undef, and then #define to a clone of
4149 (Fisnan): Always define, since it's always available now.
4150 (syms_of_floatfns): Always define isnan at the Lisp level.
4152 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4154 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4156 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4158 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4159 The previous code assumed that file offsets (off_t values) fit in
4160 EMACS_INT variables, which is not true on typical 32-bit hosts.
4161 The code messed up by falsely reporting buffer overflow in cases
4162 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4163 when "big" contains more than 2**29 bytes, even though this
4164 inserts just one byte and does not overflow the buffer.
4165 (Finsert_file_contents): Store file offsets as off_t
4166 values, not as EMACS_INT values. Check for overflow when
4167 converting between EMACS_INT and off_t. When checking for
4168 buffer overflow or for overlap, take the offsets into account.
4169 Don't use EMACS_INT for small values where int suffices.
4170 When checking for overlap, fix a typo: ZV was used where
4171 ZV_BYTE was intended.
4172 (Fwrite_region): Don't assume off_t fits into 'long'.
4173 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4175 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4177 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4179 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4181 sprintf-related integer and memory overflow issues (Bug#9412).
4183 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4184 (esprintf, exprintf, evxprintf): New functions.
4185 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4186 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4187 (modify_event_symbol): Do not assume that the length of
4188 name_alist_or_stem is safe to alloca and fits in int.
4189 (Fexecute_extended_command): Likewise for function name and binding.
4190 (Frecursion_depth): Wrap around reliably on integer overflow.
4191 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4192 since some callers pass EMACS_INT values.
4193 (Fsingle_key_description): Don't crash if symbol name contains more
4194 than MAX_ALLOCA bytes.
4195 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4196 (get_minibuffer): Arg is now EMACS_INT, not int.
4197 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4198 (esprintf, exprintf, evxprintf): New decls.
4199 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4201 * dbusbind.c (signature_cat): New function.
4202 (xd_signature, Fdbus_register_signal):
4203 Do not overrun buffer; instead, report string overflow.
4205 * dispnew.c (add_window_display_history): Don't overrun buffer.
4206 Truncate instead; this is OK since it's just a log.
4208 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4209 even if the time zone offset is outlandishly large.
4210 Don't mishandle offset == INT_MIN.
4212 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4213 when creating daemon; the previous buffer-overflow check was incorrect.
4215 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4216 which has the guts of the old verror function.
4218 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4219 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4221 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4222 (font_unparse_xlfd): Don't blindly alloca long strings.
4223 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4224 fits in int, when using sprintf. Use single snprintf to count
4225 length of string rather than counting it via multiple sprintfs;
4226 that's simpler and more reliable.
4227 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4228 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4229 sprintf, in case result does not fit in int.
4231 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4232 (fontset_from_font): Print it.
4234 * frame.c (tty_frame_count): Now printmax_t, not int.
4235 (make_terminal_frame, set_term_frame_name): Print it.
4236 (x_report_frame_params): In X, window IDs are unsigned long,
4237 not signed long, so print them as unsigned.
4238 (validate_x_resource_name): Check for implausibly long names,
4239 and don't assume name length fits in 'int'.
4240 (x_get_resource_string): Don't blindly alloca invocation name;
4241 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4244 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4245 (xg_check_special_colors, xg_set_geometry):
4246 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4248 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4249 Use esprintf, not sprintf, in case result does not fit in int.
4251 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4252 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4253 it as a large positive number.
4254 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4255 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4257 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4258 in case result does not fit in int.
4260 * print.c (float_to_string): Detect width overflow more reliably.
4261 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4262 buffer overrun. Don't assume list length fits in 'int'. Treat
4263 print length of 0 as 0, not as infinity; to be consistent with other
4264 uses of print length in this function. Don't overflow print length
4265 index. Don't assume hash table size fits in 'long', or that
4266 vectorlike size fits in 'unsigned long'.
4268 * process.c (make_process): Use printmax_t, not int, to format
4269 process-name gensyms.
4271 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4273 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4274 to avoid potential buffer overrun.
4276 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4277 if X resource line is longer than 512 bytes.
4279 * xfns.c (x_window): Make sprintf buffer a bit bigger
4280 to avoid potential buffer overrun.
4282 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4284 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4286 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4288 Integer overflow fixes for scrolling, etc.
4289 Without these, Emacs silently mishandles large integers sometimes.
4290 For example, "C-u 4294967297 M-x recenter" was treated as if
4291 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4293 * xdisp.c (try_window_id): Check Emacs fixnum range before
4294 converting to 'int'.
4296 * window.c (window_scroll_line_based, Frecenter):
4297 Check that an Emacs fixnum is in range before assigning it to 'int'.
4298 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4299 values converted from Emacs fixnums.
4300 (Frecenter): Don't wrap around a line count if it is out of 'int'
4301 range; instead, treat it as an extreme value.
4302 (Fset_window_configuration, compare_window_configurations):
4303 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4305 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4306 that can exceed INT_MAX. Check that EMACS_INT value is in range
4307 before assigning it to the (possibly-narrower) index.
4308 (match_limit): Don't assume that a fixnum can fit in 'int'.
4310 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4313 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4314 (Fvertical_motion): Don't wrap around LINES values that don't fit
4315 in 'int'. Instead, treat them as extreme values. This is good
4316 enough for windows, which can't have more than INT_MAX lines anyway.
4318 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4320 * Require libxml/parser.h to avoid compilation warning.
4322 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4324 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4325 since this reportedly can destroy thread storage.
4327 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4329 * syntax.c (find_defun_start): Update all cache variables if
4330 exiting early (Bug#9401).
4332 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4334 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4336 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4337 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4338 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4340 * term.c (tty_append_glyph): New function.
4341 (produce_stretch_glyph): Static function and its prototype deleted.
4343 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4346 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4348 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4349 when checking :margin (Bug#9390).
4350 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4351 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4352 so that the name doesn't mislead. All uses changed.
4354 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4356 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4359 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4361 * xdisp.c (move_it_to): Don't bail out early when reaching
4362 position beyond to_charpos, if we are scanning backwards.
4363 (move_it_vertically_backward): When DY == 0, make sure we get to
4364 the first character in the line after the newline.
4366 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4368 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4369 (ccl_driver): Do not generate an out-of-range pointer.
4370 (Fccl_execute_on_string): Remove unnecessary check for
4371 integer overflow, noted by Stefan Monnier in
4372 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4373 Remove a FIXME that didn't need fixing.
4374 Simplify the newly-introduced buffer reallocation code.
4376 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4378 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4380 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4382 Integer and memory overflow issues (Bug#9196).
4384 * doc.c (get_doc_string): Rework so that
4385 get_doc_string_buffer_size is the actual buffer size, rather than
4386 being 1 less than the actual buffer size; this makes xpalloc more
4389 * image.c (x_allocate_bitmap_record, cache_image):
4390 * xselect.c (Fx_register_dnd_atom):
4391 Simplify previous changes by using xpalloc.
4393 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4394 since either will do and ptrdiff_t is convenient with xpalloc.
4396 * charset.c (charset_table_size)
4397 (struct charset_sort_data.priority): Now ptrdiff_t.
4398 (charset_compare): Don't overflow if priorities differ greatly.
4399 (Fsort_charsets): Don't assume list length fits in int.
4400 Check for size-calculation overflow when allocating sort data.
4401 (syms_of_charset): Allocate an initial charset table that is
4402 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4404 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4406 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4407 The actual value is always <= INT_MAX, and leaving it unsigned made
4408 overflow checking harder.
4410 * dispextern.h (struct glyph_matrix.rows_allocated)
4411 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4412 with xpalloc. The values are still always <= INT_MAX.
4414 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4416 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4417 (SAFE_NALLOCA): New macro.
4419 * region-cache.c (struct boundary.pos, find_cache_boundary)
4420 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4421 (set_cache_region, invalidate_region_cache)
4422 (revalidate_region_cache, know_region_cache, region_cache_forward)
4423 (region_cache_backward, pp_cache):
4424 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4425 so that ptrdiff_t * can be passed to xpalloc.
4426 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4427 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4428 (pp_cache): Don't assume cache_len fits in int.
4429 * region-cache.h: Adjust extern decls to match.
4431 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4432 EMACS_INT, since either will do, for xpalloc.
4434 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4435 (xnmalloc, xnrealloc, xpalloc): New functions.
4437 * bidi.c (bidi_shelve_header_size): New constant.
4438 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4439 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4441 * bidi.c (bidi_cache_shrink):
4442 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4444 Don't update size of array until after memory allocation succeeds,
4445 because xmalloc/xrealloc may not return.
4446 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4447 now that we have proper integer overflow checking.
4448 (record_overlay_string, overlay_strings): Catch overflows when
4449 calculating size of overlay_str_buf.
4451 * callproc.c (Fcall_process): Check for size overflow when
4452 calculating size of args2.
4453 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4454 Normally we prefer signed values, but sticking with ptrdiff_t would
4455 require adding more-complicated checks.
4457 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4458 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4459 Redo buffer-overflow calculations to avoid integer overflow.
4460 Add a FIXME comment where memory seems to be over-allocated.
4462 * character.c (Fstring): Check for size-calculation overflow.
4464 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4465 unnecessary integer overflow. Check for size overflow.
4466 (encode_coding_object): Don't update size until xmalloc succeeds.
4468 * composite.c (get_composition_id): Check for overflow in glyph
4469 length calculations.
4471 Integer and memory overflow fixes for display code.
4472 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4473 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4474 (scrolling_window): Check for overflow in size calculations.
4475 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4476 Don't assume glyph table len fits in int.
4477 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4478 (row_table_size): Now ptrdiff_t, not int.
4479 (scrolling_window): Avoid overflow in size calculations.
4480 Don't update size until allocation succeeds.
4481 * fns.c (concat): Check for overflow in size calculations.
4482 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4483 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4484 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4486 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4487 (get_doc_string): Check for size calculation overflow.
4488 Don't update size until allocation succeeds.
4489 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4490 EMACS_INT, where ptrdiff_t will do.
4491 (Fsubstitute_command_keys): Check for string overflow.
4493 * editfns.c (set_time_zone_rule): Don't assume environment length
4495 (message_length): Now ptrdiff_t, not int.
4496 (Fmessage_box): Don't update size until allocation succeeds.
4497 Don't assume message length fits in int.
4498 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4500 * emacs.c (main): Do not reallocate argv, since there is a null at
4501 the end that can be overwritten, and this way there's no need to
4502 worry about size-calculation overflow.
4503 (sort_args): Check for size-calculation overflow.
4505 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4507 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4509 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4510 (x_set_scroll_bar_width, x_figure_window_size):
4511 Check for integer overflow.
4512 (x_set_alpha): Do not assume XINT fits in int.
4514 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4515 This is for the members text_lines, text_cols, total_lines, total_cols,
4516 where the system imposes an 'int' limit.
4518 * fringe.c (Fdefine_fringe_bitmap):
4519 Don't update size until alloc works.
4521 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4522 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4524 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4525 Check for size-calculation overflow.
4526 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4527 do, as we prefer signed integers.
4528 (id_to_widget.max_size, id_to_widget.used)
4529 (xg_store_widget_in_map, xg_remove_widget_from_map)
4530 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4531 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4532 Use and return ptrdiff_t, not int.
4533 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4534 * gtkutil.h: Change prototypes to match the above.
4536 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4537 are duplicate now that they've been promoted to lisp.h.
4538 (x_allocate_bitmap_record, x_alloc_image_color)
4539 (make_image_cache, cache_image, xpm_load):
4540 Don't update size until alloc is done.
4541 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4543 Check for size calculation overflow.
4544 (ct_colors_allocated_max): New constant.
4545 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4548 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4549 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4550 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4551 Use ptrdiff_t, not int, to count maps.
4552 (read_char_minibuf_menu_prompt): Check for overflow in size
4553 calculations. Don't update size until allocation succeeds.
4554 Redo calculations to avoid overflow.
4555 * keyboard.h: Change prototypes to match the above.
4557 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4559 (current_minor_maps): Check for size calculation overflow.
4560 * keymap.h: Change prototypes to match the above.
4562 * lread.c (read1, init_obarray): Don't update size until alloc done.
4564 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4565 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4567 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4568 Now ptrdiff_t, not int.
4569 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4570 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4572 * process.c (Fnetwork_interface_list): Check for overflow
4573 in size calculation.
4575 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4577 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4578 overflow. Don't bother calling xmalloc when xrealloc will do.
4580 * search.c (Freplace_match): Check for size calculation overflow.
4581 (Fset_match_data): Don't assume list lengths fit in 'int'.
4583 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4584 for command line length. Do not attempt to address one before the
4585 beginning of an array, as that's not portable.
4587 * term.c (max_frame_lines): Remove; unused.
4588 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4590 (encode_terminal_code, calculate_costs): Check for size
4591 calculation overflow.
4592 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4593 table lengths and related sizes. Don't update size until alloc
4594 done. Redo calculations to avoid overflow.
4595 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4597 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4598 subtracting pointers.
4599 (gobble_line): Check for overflow more carefully. Don't update size
4602 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4603 Don't update size until alloc done.
4604 Redo size calculations to avoid overflow.
4605 Check for size calculation overflow.
4606 (main) [DEBUG]: Fix typo in invoking tparam1.
4608 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4609 Use ptrdiff_t, not int, for sizes.
4610 (store_mode_line_noprop_char): Don't update size until alloc done.
4612 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4613 Use ptrdiff_t, not int, for sizes.
4614 (Finternal_make_lisp_face, cache_face):
4615 Check for size calculation overflow.
4616 (cache_face): Treat size calculation overflows as if they were
4617 memory exhaustion (the usual treatment), rather than aborting.
4619 * xfns.c (x_encode_text, x_set_name_internal)
4620 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4621 sizes, since they can exceed INT_MAX in size. Check for size
4622 calculation overflow.
4624 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4625 (xg_select): Check for size calculation overflow.
4626 Don't update size until alloc done.
4628 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4629 as sprintf is limited to int lengths.
4631 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4632 (X_LONG_MIN): New macros.
4633 Use them to make the following changes clearer.
4634 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4635 This change doesn't affect the value now, but it may help remind
4636 future maintainers not to raise the value too much later.
4637 (SELECTION_QUANTUM): Remove, replacing with ...
4638 (selection_quantum): ... new function, which avoids overflow.
4640 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4641 assumption that selection length fits in 'int'.
4642 (x_reply_selection_request, x_handle_selection_request)
4643 (x_get_window_property, receive_incremental_selection)
4644 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4645 (lisp_data_to_selection_data, clean_local_selection_data):
4646 Use ptrdiff_t, not int, to record length of selection.
4647 (x_reply_selection_request, x_get_window_property)
4648 (receive_incremental_selection, x_property_data_to_lisp):
4649 Redo calculations to avoid overflow.
4650 (x_reply_selection_request): When sending hint, ceiling it at
4651 X_LONG_MAX rather than relying on wraparound overflow to send
4653 (x_get_window_property, receive_incremental_selection)
4654 (lisp_data_to_selection_data, x_property_data_to_lisp):
4655 Check for size-calculation overflow.
4656 (x_get_window_property, receive_incremental_selection)
4657 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4658 Don't store size until memory allocation succeeds.
4659 (x_get_window_property): Plug memory leak on memory exhaustion.
4660 Don't double-block input; malloc is safe here. Don't assume 2**34
4661 - 4 fits in unsigned long. Add an xassert to check
4662 XGetWindowProperty overflow. Be more careful about overflow
4663 calculations, and distinguish size from memory overflow better.
4664 (receive_incremental_selection): When tracing, don't assume
4665 unsigned int is less than INT_MAX.
4666 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4667 harmful) conversions of unsigned short to int.
4668 (lisp_data_to_selection_data): Don't assume that integers
4669 in the range -65535 through -1 fit in an X unsigned short.
4670 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4671 result parameters unless successful. Rely on cons_to_unsigned
4672 to report problems with elements; the old code wasn't right anyway.
4673 (x_check_property_data): Check for int overflow; we cannot use
4674 a wider type due to X limits.
4675 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4677 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4679 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4680 (x_term_init): Check for size calculation overflow.
4681 (x_color_cells): Don't store size until memory allocation succeeds.
4682 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4683 Don't assume alloca size is less than MAX_ALLOCA.
4684 (x_term_init): Don't assume length fits in int (sprintf is limited
4687 Use ptrdiff_t for composition IDs.
4688 * character.c (lisp_string_width):
4689 * composite.c (composition_table_size, n_compositions)
4690 (get_composition_id, composition_gstring_from_id):
4691 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4692 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4693 * window.c (Frecenter):
4694 Use ptrdiff_t, not int, for composition IDs.
4695 * composite.c (get_composition_id): Check for integer overflow.
4696 * composite.h: Adjust prototypes to match the above changes.
4698 Use ptrdiff_t for hash table indexes.
4699 * category.c (hash_get_category_set):
4700 * ccl.c (ccl_driver):
4701 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4702 * coding.c (coding_system_charset_list, detect_coding_system):
4703 * coding.h (struct coding_system.id):
4704 * composite.c (get_composition_id, gstring_lookup_cache):
4705 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4706 * image.c (xpm_get_color_table_h):
4707 * lisp.h (hash_lookup, hash_put):
4708 * minibuf.c (Ftest_completion):
4709 Use ptrdiff_t for hash table indexes, not int (which is too
4710 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4711 32-bit --with-wide-int hosts).
4713 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4714 Add a FIXME comment about memory leaks.
4715 (syms_of_charset): Don't assume xmalloc returns.
4717 Don't assume that stated character widths fit in int.
4718 * character.c (Fchar_width, c_string_width, lisp_string_width):
4719 * character.h (CHAR_WIDTH):
4720 * indent.c (MULTIBYTE_BYTES_WIDTH):
4721 Use sanitize_char_width to avoid undefined and/or bad behavior
4722 with outlandish widths.
4723 * character.h (sanitize_tab_width): Rename from sanitize_width,
4724 now that we have two such functions. All uses changed.
4725 (sanitize_char_width): New inline function.
4727 Don't assume that tab-width fits in int.
4728 * character.h (sanitize_width): New inline function.
4729 (SANE_TAB_WIDTH): New macro.
4730 (ASCII_CHAR_WIDTH): Use it.
4731 * indent.c (sane_tab_width): Remove. All uses replaced by
4732 SANE_TAB_WIDTH (current_buffer).
4733 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4735 * fileio.c: Integer overflow issues with file modes.
4736 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4738 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4739 Remove unreachable code.
4740 (read_hex, load_charset_map_from_file): Check for integer overflow.
4742 * xterm.c: Don't go over XClientMessageEvent limit.
4743 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4744 (x_send_scroll_bar_event): Likewise. Check that the size does not
4745 exceed limits imposed by XClientMessageEvent, as well as the usual
4746 ptrdiff_t and size_t limits.
4748 * keyboard.c: Overflow, signedness and related fixes.
4749 (make_lispy_movement): Use same integer type in forward decl
4750 that is used in the definition.
4751 (read_key_sequence, keyremap_step):
4752 Change bufsize argument back to int, undoing my 2011-03-30 change.
4753 We prefer signed types, and int is wide enough here.
4754 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4755 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4756 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4757 length, not size_t. Use ptrdiff_t for index, not int.
4758 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4759 possibility of integer overflow.
4761 Overflow, signedness and related fixes for images.
4763 * dispextern.h (struct it.stack[0].u.image.image_id)
4764 (struct_it.image_id, struct image.id, struct image_cache.size)
4765 (struct image_cache.used, struct image_cache.ref_count):
4766 * gtkutil.c (update_frame_tool_bar):
4767 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4768 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4769 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4770 * nsmenu.m (update_frame_tool_bar):
4771 * xdisp.c (calc_pixel_width_or_height):
4772 * xfns.c (image_cache_refcount):
4773 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4774 on typical 64-bit hosts.
4776 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4777 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4778 Omit unnecessary casts to int.
4779 (parse_image_spec): Check that integers fall into 'int' range
4780 when the callers expect that.
4781 (image_ascent): Redo ascent calculation to avoid int overflow.
4782 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4783 (lookup_image): Remove unnecessary tests.
4784 (xbm_image_p): Locals are now of int, not EMACS_INT,
4785 since parse_image_check makes sure they fit into int.
4786 (png_load, gif_load, svg_load_image):
4787 Prefer int to unsigned where either will do.
4788 (tiff_handler): New function, combining the cores of the
4789 old tiff_error_handler and tiff_warning_handler.
4790 This function is rewritten to use vsnprintf and thereby avoid
4791 stack buffer overflows. It uses only the features of vsnprintf
4792 that are common to both POSIX and native Microsoft.
4793 (tiff_error_handler, tiff_warning_handler): Use it.
4794 (tiff_load, gif_load, imagemagick_load_image):
4795 Don't assume :index value fits in 'int'.
4796 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4797 (imagemagick_load_image): Check that crop parameters fit into
4798 the integer types that MagickCropImage accepts. Don't assume
4799 Vimagemagick_render_type has a nonnegative value. Don't assume
4800 size_t fits in 'long'.
4801 (gs_load): Use printmax_t to print the widest integers possible.
4802 Check for integer overflow when computing image height and width.
4804 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4806 * xdisp.c (redisplay_window): Don't force window start if point
4807 will be invisible in the resulting window. (Bug#9324)
4809 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4811 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4812 the display spec is of the form `(space ...)'.
4813 (handle_display_spec): Return the value returned by
4814 handle_single_display_spec, not just 1 or zero.
4815 (handle_single_display_spec): If the display spec is of the form
4816 `(space ...)', and specifies display in the text area, return 2
4818 (try_cursor_movement): Check for the need to scroll more
4819 accurately, and prefer exact match for point under bidi.
4820 Don't advance `row' beyond the last row of the window.
4822 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4823 into disp_prop; all users changed.
4825 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4826 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4827 for the text covered by the display property.
4829 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4831 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4832 Change return value to nil.
4833 (Frecord_buffer): Delete unused function.
4835 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4837 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4838 buffers, return left-to-right.
4839 (set_cursor_from_row): Consider candidate row a win if its glyph
4840 represents a newline and point is on that newline. Fixes cursor
4841 positioning on the newline at EOL of R2L text within L2R
4842 paragraph, and vice versa.
4843 (try_cursor_movement): Check continued rows, in addition to
4844 continuation rows. Fixes unwarranted scroll when point enters a
4845 continued line of R2L text within an L2R paragraph, or vice versa.
4846 (cursor_row_p): Consider the case of point being equal to
4847 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4848 from the end of a short line to the beginning of a continued line
4849 of R2L text within L2R paragraph.
4850 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4851 composed characters.
4853 * bidi.c (bidi_check_type): Use xassert.
4854 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4857 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4859 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4862 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4864 * nsfont.m (ns_otf_to_script): Fix typo.
4866 2011-08-22 Kenichi Handa <handa@m17n.org>
4868 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4869 extra slot even if the purpose is char-code-property-table.
4871 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4873 * xdisp.c (redisplay_window): When computing centering_position,
4874 account for the height of the header line. (Bug#8874)
4876 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4877 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4878 candidate is selected by the mouse, and that candidate has a
4879 composed character under the mouse.
4881 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4882 coordinates reported by pos-visible-in-window-p for a composed
4883 character in column zero.
4885 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4887 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4889 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4891 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4892 consider it a hit if to_charpos is anywhere in the range of the
4893 composed buffer positions.
4895 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4897 * image.c (gif_load): Don't assume that each subimage has the same
4898 dimensions as the base image. Handle disposal method that is
4899 "undefined" by the gif spec (Bug#9335).
4901 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4903 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4904 (Fcondition_case): Document `debug' symbol in error handler.
4906 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4908 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4909 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4910 from an Org mode buffer to a Speedbar frame.
4912 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4913 a composition, take its buffer position from IT->cmp_it.charpos.
4914 Fixes cursor positioning at the beginning of a line that begins
4915 with a composed character.
4917 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4919 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4920 character bidirectional type, use STRONG_L instead. Fixes crashes
4921 in a buffer produced by `describe-categories'.
4923 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4924 members before the level stack, so they would be saved and
4925 restored when copying iterator state. Fixes incorrect reordering
4926 around TABs covered by display properties.
4928 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4930 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4932 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4934 * eval.c (internal_condition_case, internal_condition_case_1)
4935 (internal_condition_case_2, internal_condition_case_n):
4936 Remove unnecessary aborts (Bug#9081).
4938 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4940 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4941 has no `load' handler, try opening the file locally. (Bug#9311)
4943 2011-08-16 Ken Brown <kbrown@cornell.edu>
4945 * gmalloc.c: Expand comment.
4947 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4949 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4950 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4952 2011-08-16 Ken Brown <kbrown@cornell.edu>
4954 Fix memory allocation problems in Cygwin build (Bug#9273).
4956 * unexcw.c ( __malloc_initialized): Declare external variable.
4957 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4959 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4961 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4963 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4965 [CYGWIN] (special_realloc): New function.
4966 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4967 requests to realloc storage in the static heap.
4969 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4971 * bidi.c (bidi_initialize): Remove unused local.
4973 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4976 * biditype.h: Remove file.
4977 * makefile.w32-in ($(BLD)/bidi.$(O)):
4978 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4980 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4982 * chartab.c: Improve commentary for the uniprop_table API.
4984 * bidi.c (bidi_paragraph_init): Support zero value of
4985 bidi_ignore_explicit_marks_for_paragraph_level.
4986 (bidi_initialize): Use uniprop_table instead of including
4987 biditype.h and bidimirror.h.
4989 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4990 coordinates of the iterator when restoring from ppos_it.
4993 2011-08-14 Kenichi Handa <handa@m17n.org>
4995 * process.c (create_process): Call setup_process_coding_systems
4996 after the pid of the process is set to -1 (Bug#8162).
4998 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5000 * xdisp.c (move_it_in_display_line_to): Don't invoke
5001 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5002 ppos_it. Fixes vertical cursor motion when line beginning is
5003 covered by an image. (Bug#9296)
5005 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5007 * nsterm.h (ns_run_ascript): Declare.
5008 (NSAPP_DATA2_RUNASSCRIPT): Define.
5010 * nsfns.m (as_script, as_result, as_status): New static variables.
5011 (ns_run_ascript): New function.
5012 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5013 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5014 the event loop. Get status from as_status (Bug#7276).
5016 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5017 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5018 the event loop (Bug#7276).
5020 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5022 * gnutls.c (QCgnutls_bootprop_priority)
5023 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5024 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5025 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5026 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5027 (QCgnutls_bootprop_verify_hostname_error)
5028 (QCgnutls_bootprop_callbacks_verify): Rename from
5029 Qgnutls_bootprop_..., all uses changed.
5031 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5034 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5036 * xfaces.c (Qframe_set_background_mode): Now static.
5037 * dispextern.h (Qframe_set_background_mode): Remove decl.
5039 * process.c (Fnetwork_interface_info): Declare local only if needed.
5041 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5043 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5044 (Fnetwork_interface_list): Allocate in increments of bytes instead
5045 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5046 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5048 (struct ifflag_def): notrailers is smart on OSX.
5049 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5050 Get hardware address with getifaddrs if available.
5052 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5054 * xdisp.c (iterate_out_of_display_property): xassert that
5055 IT->position is set to within IT->object's boundaries. Break from
5056 the loop as soon as EOB is reached; avoids infloops in redisplay
5057 when IT->position is set up wrongly due to some bug.
5058 Set IT->current to match the bidi iterator unconditionally.
5059 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5060 entry. Force push_it to save on the stack the current
5061 buffer/string position, to be restored by pop_it. Fix flags in
5062 the iterator structure wrt the object coming from a display
5063 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5064 properties. (Bug#9284)
5066 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5068 * fontset.c (fontset_get_font_group): Add proper type checks.
5071 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5073 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5074 and LC_VERSION_MIN_MACOSX.
5075 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5076 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5078 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5080 * xdisp.c (forward_to_next_line_start): Allow to use the
5081 no-display-properties-and-no-overlays under bidi display.
5082 Set disp_pos in the bidi iterator to avoid searches for display
5083 properties and overlays.
5085 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5087 * editfns.c (Fset_time_zone_rule): Document relationship with the
5090 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5091 the font entity extracted from the cache (Bug#8109).
5093 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5095 * composite.c (autocmp_chars): Don't reset point. That is done by
5096 restore_point_unwind (Bug#5984).
5098 2011-08-07 Juri Linkov <juri@jurta.org>
5100 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5101 to show the arg `TIME' instead of `TIMEVAL'.
5103 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5105 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5106 display property strides EOL and includes a newline, as in
5107 longlines-mode. (Bug#9254)
5108 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5109 word-wrap under bidirectional display. (Bug#9224)
5111 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5112 is non-zero, even if the data buffer is NULL. Fixes a crash in
5113 vertical-motion with longlines-mode. (Bug#9254)
5115 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5117 * bidi.c <bidi_cache_total_alloc>: Now static.
5118 (bidi_initialize): Initialize bidi_cache_total_alloc.
5120 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5123 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5124 amount allocated this far in `bidi_cache_total_alloc'.
5125 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5126 non-zero, only free the data buffer without restoring the cache
5127 contents. All callers changed.
5129 * dispextern.h (bidi_unshelve_cache): Update prototype.
5131 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5132 (move_it_in_display_line, move_it_to)
5133 (move_it_vertically_backward, move_it_by_lines): Replace the call
5134 to xfree to an equivalent call to bidi_unshelve_cache.
5135 (move_it_in_display_line_to): Fix logic of returning
5136 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5138 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5140 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5141 came from a string character with a `cursor' property. (Bug#9229)
5143 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5145 * Makefile.in (LIB_PTHREAD): New variable.
5146 (LIBES): Add LIB_PTHREAD (Bug#9216).
5148 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5149 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5151 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5153 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5155 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5157 * xterm.c (x_find_topmost_parent): New function.
5158 (x_set_frame_alpha): Find topmost parent window with
5159 x_find_topmost_parent and set the property there also (bug#9181).
5160 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5162 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5164 * callproc.c (Fcall_process): Avoid vfork clobbering
5165 the local vars buffer, coding_systems, current_dir.
5167 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5169 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5171 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5173 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5174 so that it is not optimized away.
5176 * xdisp.c (compute_display_string_pos): Remove unused local.
5178 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5180 Fix slow cursor motion and scrolling in large buffers with
5181 selective display, like Org Mode buffers. (Bug#9218)
5183 * dispextern.h (struct bidi_it): New member disp_prop_p.
5185 * xdisp.c: Remove one-slot cache of display string positions.
5186 (compute_display_string_pos): Accept an additional argument
5187 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5188 for a display string or property. If found, set DISP_PROP_P
5191 * bidi.c (bidi_fetch_char): Accept an additional argument
5192 DISP_PROP_P, and pass it to compute_display_string_pos.
5193 Only handle text covered by a display string if DISP_PROP_P is returned
5194 non-zero. All callers of bidi_fetch_char changed.
5196 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5198 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5200 2010-12-03 Don March <don@ohspite.net>
5202 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5203 last character M-[char] is translated to ESC [char] (bug#7541).
5205 2011-08-02 Kenichi Handa <handa@m17n.org>
5207 * lisp.h (uniprop_table): Extern it.
5209 * chartab.c (uniprop_table): Make it non-static.
5211 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5213 * xdisp.c (forward_to_next_line_start): Accept additional argument
5214 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5216 (reseat_at_next_visible_line_start): Use the bidi iterator state
5217 returned by forward_to_next_line_start to restore the state of
5218 it->bidi_it after backing up to previous newline. (Bug#9212)
5220 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5222 * regex.c (re_comp): Protoize.
5223 (re_exec): Fix return type.
5224 (regexec): Fix type of `ret'. (Bug#9203)
5226 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5228 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5229 This is needed if max-image-size is a floating-point number.
5231 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5233 * print.c (print_object): Print empty symbol as ##.
5235 * lread.c (read1): Read ## as empty symbol.
5237 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5239 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5240 setting frame foreground color (Bug#9175).
5241 (x_set_background_color): Likewise.
5243 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5244 contents (Bug#9176).
5245 (EmacsTooltip -init): Remove bezels and add shadows to
5248 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5249 or scroll bar (Bug#8470).
5251 * nsfont.m (nsfont_open): Remove assignment to voffset and
5252 unnecessary vars hshink, expand, hd, full_height, min_height.
5253 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5255 * nsterm.h (nsfont_info): Remove voffset field.
5257 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5259 Implement strike-through and overline on NextStep (Bug#8863).
5261 * nsfont.m (nsfont_open): Use underline position provided by font,
5262 instead of hard-coded value of 2.
5263 (nsfont_draw): Call ns_draw_text_decoration instead.
5265 * nsterm.h: Add declaration for ns_draw_text_decoration.
5267 * nsterm.m (ns_draw_text_decoration): New function for drawing
5268 underline, overline, and strike-through.
5269 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5270 ns_draw_text_decoration. Change treatment of cursor drawing to
5271 accommodate underlining, etc.
5273 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5275 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5278 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5280 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5281 Without this fix, if a signal arrives just after memory fills up,
5282 'malloc' might be invoked reentrantly.
5284 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5285 In other words, assume that every image size is allowed, on non-X
5286 hosts. This assumption is probably wrong, but it lets Emacs compile.
5288 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5290 * regex.c (re_iswctype): Convert return values to boolean.
5292 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5294 * xdisp.c (compute_display_string_pos): Don't use cached display
5295 string position if the buffer had its restriction changed.
5298 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5300 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5302 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5304 Integer signedness and overflow and related fixes. (Bug#9079)
5306 * bidi.c: Integer size and overflow fixes.
5307 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5308 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5309 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5310 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5311 (bidi_find_other_level_edge):
5312 Use ptrdiff_t instead of EMACS_INT where either will do.
5313 This works better on 32-bit hosts configured --with-wide-int.
5314 (bidi_cache_ensure_space): Check for size-calculation overflow.
5315 Use % rather than repeated addition, for better worst-case speed.
5316 Don't set bidi_cache_size until after xrealloc returns, because it
5318 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5319 (bidi_cache_ensure_space): Also check that the bidi cache size
5320 does not exceed that of the largest Lisp string or buffer. See Eli
5321 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5323 * alloc.c (__malloc_size_t): Remove.
5324 All uses replaced by size_t. See Andreas Schwab's note
5325 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5327 * image.c: Improve checking for integer overflow.
5328 (check_image_size): Assume that f is nonnull, since
5329 it is always nonnull in practice. This is one less thing to
5330 worry about when checking for integer overflow later.
5331 (x_check_image_size): New function, which checks for integer
5332 overflow issues inside X.
5333 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5334 This removes the need for a memory_full check.
5335 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5336 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5337 (xbm_read_bitmap_data): Change locals back to 'int', since
5338 their values must fit in 'int'.
5339 (xpm_load_image, png_load, tiff_load):
5340 Invoke x_create_x_image_and_pixmap earlier,
5341 to avoid much needless work if the image is too large.
5342 (tiff_load): Treat overly large images as if
5343 x_create_x_image_and_pixmap failed, not as malloc failures.
5344 (gs_load): Use x_check_image_size.
5346 * gtkutil.c: Omit integer casts.
5347 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5348 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5350 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5352 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5353 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5354 would wrongly return t on a 64-bit host.
5356 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5357 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5358 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5359 and therefore cause GCC to emit a bogus diagnostic in some cases.
5361 * image.c: Integer signedness and overflow and related fixes.
5362 This is not an exhaustive set of fixes, but it's time to
5363 record what I've got.
5364 (lookup_pixel_color, check_image_size): Remove redundant decls.
5365 (check_image_size): Don't assume that arbitrary EMACS_INT values
5366 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5367 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5368 (tiff_load, imagemagick_load_image):
5369 Check for overflow in size calculations.
5370 (x_create_x_image_and_pixmap): Remove unnecessary test for
5371 xmalloc returning NULL; that can't happen.
5372 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5373 (xpm_color_bucket): Use better integer hashing function.
5374 (xpm_cache_color): Don't possibly over-allocate memory.
5375 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5376 (gif_memory_source):
5377 Use ptrdiff_t, not int or size_t, to record sizes.
5378 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5379 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5380 either works, as we prefer signed integers.
5381 (tiff_read_from_memory, tiff_write_from_memory):
5382 Return tsize_t, not size_t, since that's what the TIFF API wants.
5383 (tiff_read_from_memory): Don't fail simply because the read would
5384 go past EOF; instead, return a short read.
5385 (tiff_load): Omit no-longer-needed casts.
5386 (Fimagemagick_types): Don't assume size fits into 'int'.
5388 Improve hashing quality when configured --with-wide-int.
5389 * fns.c (hash_string): New function, taken from sxhash_string.
5390 Do not discard information about ASCII character case; this
5391 discarding is no longer needed.
5392 (sxhash-string): Use it. Change sig to match it. Caller changed.
5393 * lisp.h: Declare it.
5394 * lread.c (hash_string): Remove, since we now use fns.c's version.
5395 The fns.c version returns a wider integer if --with-wide-int is
5396 specified, so this should help the quality of the hashing a bit.
5398 * emacs.c: Integer overflow minor fix.
5399 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5400 Define only if GNU_LINUX.
5401 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5403 * dispnew.c: Integer signedness and overflow fixes.
5404 Remove unnecessary forward decls, that were a maintenance hassle.
5405 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5407 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5408 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5409 (prepare_desired_row, line_draw_cost):
5410 Use int, not unsigned, where either works.
5411 (save_current_matrix, restore_current_matrix):
5412 Use ptrdiff_t, not size_t, where either works.
5413 (init_display): Check for overflow more accurately, and without
5414 relying on undefined behavior.
5416 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5417 Remove, replacing with the new symbols in lisp.h. All uses changed.
5418 * fileio.c (make_temp_name):
5419 * filelock.c (lock_file_1, lock_file):
5420 * xdisp.c (message_dolog):
5421 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5422 Use pMd etc. instead.
5423 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5424 replacing the pWIDE etc. symbols removed from editfns.c.
5426 * keyboard.h (num_input_events): Now uintmax_t.
5427 This is (very slightly) less likely to mess up due to wraparound.
5430 * buffer.c: Integer signedness fixes.
5431 (alloc_buffer_text, enlarge_buffer_text):
5432 Use ptrdiff_t rather than size_t when either will do, as we prefer
5435 * alloc.c: Integer signedness and overflow fixes.
5436 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5437 (__malloc_size_t): Default to size_t, not to int.
5438 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5439 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5440 Prefer ptrdiff_t to size_t when either would do, as we prefer
5442 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5443 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5444 Now const. Initialize with values that are in range even if char
5446 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5447 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5448 These functions do the right thing with sizes > 2**32.
5449 (check_depth): Now ptrdiff_t, not int.
5450 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5451 Adjust to new way of storing sizes. Check for size overflow bugs
5453 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5454 slightly wrong anyway, as it missed one instance of
5455 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5456 (refill_memory_reserve): Omit needless cast to size_t.
5457 (mark_object_loop_halt): Mark as externally visible.
5459 * xselect.c: Integer signedness and overflow fixes.
5460 (Fx_register_dnd_atom, x_handle_dnd_message):
5461 Use ptrdiff_t, not size_t, since we prefer signed.
5462 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5463 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5464 x_dnd_atoms_size and x_dnd_atoms_length.
5466 * doprnt.c: Prefer signed to unsigned when either works.
5468 * doprnt.c (doprnt):
5470 * xdisp.c (vmessage):
5471 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5472 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5473 prefer signed arithmetic to avoid comparison confusion.
5474 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5475 but is a bit tricky.
5477 Assume freestanding C89 headers, string.h, stdlib.h.
5478 * data.c, doprnt.c, floatfns.c, print.c:
5479 Include float.h unconditionally.
5480 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5481 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5482 * regex.c: Likewise for stddef.h, string.h.
5483 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5484 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5485 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5486 (STDC_HEADERS): Remove obsolete defines.
5487 * sysdep.c: Include limits.h unconditionally.
5489 Assume support for memcmp, memcpy, memmove, memset.
5490 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5491 * regex.c (memcmp, memcpy):
5492 Remove; we assume C89 now.
5494 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5495 (__malloc_safe_bcopy): Remove; no longer needed.
5497 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5498 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5499 well either way, and we prefer signed to unsigned.
5501 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5503 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5504 closes the connection while we're reading (bug#9182).
5506 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5508 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5509 are specified (Bug#9168).
5511 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5513 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5514 Found by GCC static checking and --with-wide-int on a 32-bit host.
5516 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5518 * xdisp.c (compute_display_string_pos): Fix logic of caching
5519 previous display string position. Initialize cached_prev_pos to
5520 -1. Fixes slow-down at the beginning of a buffer.
5522 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5524 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5525 for attrs[LFACE_FONTSET_INDEX].
5527 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5529 * xml.c (parse_region): Remove unused local
5530 that was recently introduced.
5532 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5534 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5535 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5537 * xdisp.c (move_it_in_display_line_to): Record the best matching
5538 position for TO_CHARPOS while scanning the line, and restore it on
5539 exit if none of the characters scanned was an exact match.
5540 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5541 when exact match is impossible due to invisible text, and the
5542 lines are truncated.
5544 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5546 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5549 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5551 Fix a significant slow-down of cursor motion with C-n, C-p,
5552 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5553 auto-repeat under bidi redisplay in fontified buffers.
5554 * xdisp.c (compute_stop_pos_backwards): New function.
5555 (next_element_from_buffer): Call compute_stop_pos_backwards to
5556 find a suitable prev_stop when we find ourselves before
5558 (reseat): Don't look for prev_stop, as that could mean a very long
5560 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5561 <cached_disp_overlay_modiff>: Cache for last found display string
5563 (compute_display_string_pos): Return the cached position if asked
5564 about the same buffer in the same area of character positions, and
5565 the buffer wasn't changed since the time the display string
5566 position was cached.
5568 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5570 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5571 is an integer, which is important for empty lines. (Bug#9149)
5573 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5575 * frame.c (Fmodify_frame_parameters): In tty case, update the
5576 default face if necessary (Bug#4238).
5578 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5580 * editfns.c (Fstring_to_char): No need to explain what a character
5581 is in the docstring (Bug#6576).
5583 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5585 * xml.c (parse_region): Make sure we always return a tree.
5587 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5589 * xml.c (parse_region): If a document contains only comments,
5592 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5594 * xml.c (make_dom): Return comments, too.
5596 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5599 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5600 and the surrounding thread.
5601 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5602 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5603 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5605 * s/openbsd.h (BROKEN_SIGIO): Define.
5606 * unexelf.c (unexec) [__OpenBSD__]:
5607 Don't update the .mdebug section of the Alpha COFF symbol table.
5609 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5611 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5614 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5616 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5617 This fixes some race conditions on the permissions of any newly
5620 * alloc.c (valid_pointer_p): Use pipe, not open.
5621 This fixes some permissions issues when debugging.
5623 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5624 If fchown fails to set both uid and gid, try to set just gid,
5625 as that is sometimes allowed. Adjust the file's mode to eliminate
5626 setuid or setgid bits that are inappropriate if fchown fails.
5628 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5630 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5631 to compare Lisp_Objects.
5632 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5633 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5634 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5636 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5638 * lread.c (read_integer): Unread even EOF character.
5639 (read1): Likewise. Properly record start position of symbol.
5641 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5642 symbol character follows.
5644 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5646 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5647 This works around a problem with the previous change to Fcopy_file.
5648 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5649 and without this change, GCC might complain about discarding
5650 fchown's return value.
5652 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5654 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5656 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5658 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5660 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5662 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5663 it's used from the C level.
5665 * process.c: Use the same condition for POLL_FOR_INPUT in both
5666 keyboard.c and process.c (bug#1858).
5668 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5670 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5671 (Fgnutls_boot): Use it.
5673 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5675 * doc.c (Fsubstitute_command_keys): Revert last change.
5677 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5679 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5680 quotes the next character, and doesn't affect other longer
5681 sequences (bug#8935).
5683 * lread.c (syms_of_lread): Clarify that is isn't only
5684 `eval-buffer' and `eval-defun' that's affected by
5685 `lexical-binding' (bug#8460).
5687 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5689 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5690 bidi redisplay when a line includes both an image and is truncated.
5692 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5694 Fix minor problems found by static checking.
5695 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5696 (elsz): Now a signed constant, not a size_t var. We prefer signed
5697 types to unsigned, to avoid integer comparison confusion. Without
5698 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5699 "cannot optimize loop, the loop counter may overflow", a symptom
5701 * indent.c (Fvertical_motion): Mark locals as initialized.
5702 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5704 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5706 * search.c (Fre_search_backward): Mention `case-fold-search' in
5707 all the re_search_* functions (bug#8138).
5709 * keyboard.c (Fopen_dribble_file): Document when the file is
5712 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5714 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5717 Support bidi reordering of display and overlay strings.
5718 * xdisp.c (compute_display_string_pos)
5719 (compute_display_string_end): Accept additional argument STRING.
5720 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5721 (reseat_to_string): Initialize bidi_it->string.s and
5722 bidi_it->string.schars.
5723 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5724 NULL (avoids a crash in bidi_paragraph_init).
5725 Initialize itb.string.lstring.
5726 (init_iterator): Call bidi_init_it only of a valid
5727 buffer position was specified. Initialize paragraph_embedding to
5729 (reseat_to_string): Initialize the bidi iterator.
5730 (display_string): If we need to ignore text properties of
5731 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5732 original value of -1 will not work with bidi.)
5733 (compute_display_string_pos): First arg is now struct
5734 `text_pos *'; all callers changed. Support display properties on
5736 (compute_display_string_end): Support display properties on Lisp
5738 (init_iterator, reseat_1, reseat_to_string): Initialize the
5739 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5740 when iterating on a string not from display properties).
5741 (compute_display_string_pos, compute_display_string_end):
5742 Fix calculation of the object to scan. Fixes an error when using
5744 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5745 base_level_stop; instead, set base_level_stop to BEGV.
5746 Fixes crashes in vertical-motion.
5747 (next_element_from_buffer): Improve commentary for when
5748 the iterator is before prev_stop.
5749 (init_iterator): Initialize bidi_p from the default value of
5750 bidi-display-reordering, not from buffer-local value. Use the
5751 buffer-local value only if initializing for buffer iteration.
5752 (handle_invisible_prop): Support invisible properties on strings
5753 that are being bidi-reordered.
5754 (set_iterator_to_next): Support bidi reordering of C strings and
5756 (next_element_from_string): Support bidi reordering of Lisp
5758 (handle_stop_backwards): Support Lisp strings as well.
5759 (display_string): Support display of R2L glyph rows.
5760 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5761 (init_iterator): Don't initialize it->bidi_p for strings
5763 (reseat_to_string): Initialize it->bidi_p for strings here.
5764 (next_element_from_string, next_element_from_c_string)
5765 (next_element_from_buffer): Add xassert's for correspondence
5766 between IT's object being iterated and it->bidi_it.string
5768 (face_before_or_after_it_pos): Support bidi iteration.
5769 (next_element_from_c_string): Handle the case of the first string
5770 character that is not the first one in the visual order.
5771 (get_visually_first_element): New function, refactored from common
5772 parts of next_element_from_buffer, next_element_from_string, and
5773 next_element_from_c_string.
5774 (tool_bar_lines_needed, redisplay_tool_bar)
5775 (display_menu_bar): Force left-to-right direction. Add a FIXME
5776 comment for making that be controlled by a user option.
5777 (push_it, pop_it): Save and restore the state of the
5778 bidi iterator. Save and restore the bidi_p flag.
5779 (pop_it): Iterate out of display property for string iteration as
5781 (iterate_out_of_display_property): Support iteration over strings.
5782 (handle_single_display_spec): Set up it->bidi_it for iteration
5783 over a display string, and call bidi_init_it.
5784 (handle_single_display_spec, next_overlay_string)
5785 (get_overlay_strings_1, push_display_prop): Set up the bidi
5786 iterator for displaying display or overlay strings.
5787 (forward_to_next_line_start): Don't use the shortcut if
5789 (back_to_previous_visible_line_start): If handle_display_prop
5790 pushed the iterator stack, restore the internal state of the bidi
5791 iterator by calling bidi_pop_it same number of times.
5792 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5793 and we are bidi-iterating, don't decrement the iterator position;
5794 instead, set the first_elt flag in the bidi iterator, to produce
5796 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5797 (push_display_prop): xassert that we are iterating a buffer.
5798 (push_it, pop_it): Save and restore paragraph_embedding member.
5799 (handle_single_display_spec, next_overlay_string)
5800 (get_overlay_strings_1, reseat_1, reseat_to_string)
5801 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5802 correctly. Don't assume unibyte strings are not bidi-reordered.
5803 (compute_display_string_pos)
5804 (compute_display_string_end): Fix handling the case of C string.
5805 (push_it, pop_it): Save and restore from_disp_prop_p.
5806 (handle_single_display_spec, push_display_prop): Set the
5807 from_disp_prop_p flag.
5808 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5809 (pop_it): Call iterate_out_of_display_property only if we are
5810 popping after iteration over a string that came from a display
5811 property. Fix a typo in popping stretch info. Add an assertion
5812 for verifying that the iterator position is in sync with the bidi
5814 (handle_single_display_spec, get_overlay_strings_1)
5815 (push_display_prop): Fix initialization of paragraph direction for
5816 string when that of the parent object is not yet determined.
5817 (reseat_1): Call bidi_init_it to resync the bidi
5818 iterator with IT's position. (Bug#7616)
5819 (find_row_edges): If ROW->start.pos gives position
5820 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5821 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5822 Reset the from_disp_prop_p flag.
5823 (SAVE_IT, RESTORE_IT): New macros.
5824 (pos_visible_p, face_before_or_after_it_pos)
5825 (back_to_previous_visible_line_start)
5826 (move_it_in_display_line_to, move_it_in_display_line)
5827 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5828 (try_scrolling, redisplay_window, display_line): Use them when
5829 saving a temporary copy of the iterator and restoring it back.
5830 (back_to_previous_visible_line_start, reseat_1)
5831 (init_iterator): Empty the bidi cache "stack".
5832 (move_it_in_display_line_to): If iterator ended up at
5833 EOL, but we never saw any buffer positions smaller than
5834 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5835 motion in bidi-reordered lines.
5836 (move_it_in_display_line_to): Record prev_method and prev_pos
5837 immediately before the call to set_iterator_to_next. Fixes cursor
5838 motion in bidi-reordered lines with stretch glyphs and strings
5839 displayed in margins. (Bug#8133) (Bug#8867)
5840 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5842 (pos_visible_p): Support positions in bidi-reordered lines.
5843 Save and restore bidi cache.
5845 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5846 (bidi_paragraph_info): Delete unused struct.
5847 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5848 (bidi_cache_start): New variable.
5849 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5851 (bidi_cache_fetch_state, bidi_cache_search)
5852 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5853 (bidi_cache_find, bidi_peek_at_next_level)
5854 (bidi_level_of_next_char, bidi_find_other_level_edge)
5855 (bidi_move_to_visually_next): Compare cache index with
5856 bidi_cache_start rather than with zero.
5857 (bidi_fetch_char): Accept new argument STRING; all callers
5858 changed. Support iteration over a string. Support strings with
5859 display properties. Support unibyte strings. Fix the type of
5860 `len' according to what STRING_CHAR_AND_LENGTH expects.
5861 (bidi_paragraph_init, bidi_resolve_explicit_1)
5862 (bidi_resolve_explicit, bidi_resolve_weak)
5863 (bidi_level_of_next_char, bidi_move_to_visually_next):
5864 Support iteration over a string.
5865 (bidi_set_sor_type, bidi_resolve_explicit_1)
5866 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5867 can now be zero (for strings); special values 0 and -1 were
5868 changed to -1 and -2, respectively.
5869 (bidi_char_at_pos): New function.
5870 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5871 Call it instead of FETCH_MULTIBYTE_CHAR.
5872 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5873 initialized to valid values.
5874 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5876 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5877 the test for valid cached positions. Fix the logic for looking up
5878 the sentinel state in the cache. GCPRO the Lisp string we are
5880 (bidi_push_it, bidi_pop_it): New functions.
5881 (bidi_initialize): Initialize the bidi cache start stack pointer.
5882 (bidi_cache_ensure_space): New function, refactored from part of
5883 bidi_cache_iterator_state. Don't assume the required size is just
5884 one BIDI_CACHE_CHUNK away.
5885 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5886 (bidi_count_bytes, bidi_char_at_pos): New functions.
5887 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5888 always valid if bidi_cache_idx is valid.
5889 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5890 is valid if it's going to be used.
5891 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5892 (bidi_cache_fetch_state, bidi_cache_search)
5893 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5894 (bidi_cache_iterator_state, bidi_cache_find)
5895 (bidi_find_other_level_edge, bidi_cache_start_stack):
5896 All variables related to cache indices are now EMACS_INT.
5898 * dispextern.h (struct bidi_string_data): New structure.
5899 (struct bidi_it): New member `string'. Make flag members be 1-bit
5900 fields, and put them last in the struct.
5901 (compute_display_string_pos, compute_display_string_end):
5903 (bidi_push_it, bidi_pop_it): Add prototypes.
5904 (struct iterator_stack_entry): New members bidi_p,
5905 paragraph_embedding, and from_disp_prop_p.
5906 (struct it): Member bidi_p is now a bit field 1 bit wide.
5907 (bidi_shelve_cache, bidi_unshelve_cache):
5910 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5911 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5912 and vector-like objects.
5914 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5915 cache around display iteration.
5917 * window.c (Fwindow_end, window_scroll_pixel_based)
5918 (displayed_window_lines, Frecenter): Save and restore the bidi
5919 cache around display iteration.
5921 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5923 * editfns.c (Fdelete_region): Clarify the use of the named
5924 parameters (bug#6788).
5926 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5928 * indent.c (Fvertical_motion): Set and restore w->pointm when
5929 saving and restoring the window's buffer (Bug#9006).
5931 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5933 * editfns.c (Fstring_to_char): Clarify just what is returned
5934 (bug#6576). Text by Eli Zaretskii.
5936 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5938 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5940 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5942 * buffer.c (mmap_find): Fix a typo.
5944 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5946 Fix execution of x selection hooks.
5947 * xselect.c (Qx_lost_selection_functions)
5948 (Qx_sent_selection_functions): New vars.
5949 (syms_of_xselect): DEFSYM them.
5950 (x_handle_selection_request): Pass Qx_sent_selection_functions
5951 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5952 (x_handle_selection_clear,x_clear_frame_selections):
5953 Pass Qx_lost_selection_functions rather than
5954 Vx_lost_selection_functions to Frun_hook_with_args.
5956 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5958 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5959 The old code sometimes used this field without initializing it.
5961 * alloc.c (gc_sweep): Don't read past end of array.
5962 In theory, the old code could also have corrupted Emacs internals,
5963 though it'd be very unlikely.
5965 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5967 * character.c (Fcharacterp): Don't advertise optional ignored
5968 argument. (Bug#4026)
5970 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5972 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5975 * window.c (Fset_window_start): Doc fix (bug#4199).
5976 (Fset_window_hscroll): Ditto.
5978 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5980 Fix minor new problems caught by GCC 4.6.1.
5981 * term.c (init_tty): Remove unused local.
5982 * xsettings.c (store_monospaced_changed): Define this function only
5983 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5986 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5988 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5990 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5992 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5993 are the mini-buffer and the echo area (bug#3320).
5995 * term.c (init_tty): Remove support for supdup, c10 and perq
5996 terminals, which are no longer supported (bug#1482).
5998 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6000 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6002 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6004 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6005 for non-popups (Bug#3642).
6007 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6009 * alloc.c (reset_malloc_hooks): Protoize.
6010 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6011 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6012 * cm.c (losecursor): Likewise.
6013 * data.c (fmod): Likewise.
6014 * dispnew.c (swap_glyphs_in_rows): Likewise.
6015 * emacs.c (memory_warning_signal): Likewise.
6016 * floatfns.c (float_error): Likewise.
6017 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6018 (otf_open, font_otf_capability, generate_otf_features)
6019 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6021 * image.c (pbm_read_file): Likewise.
6022 * indent.c (string_display_width): Likewise.
6023 * intervals.c (check_for_interval, search_for_interval)
6024 (inc_interval_count, count_intervals, root_interval)
6025 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6026 * lread.c (defalias): Likewise.
6027 * ralloc.c (r_alloc_check): Likewise.
6028 * regex.c (set_image_of_range_1, set_image_of_range)
6029 (regex_grow_registers): Likewise.
6030 * sysdep.c (strerror): Likewise.
6031 * termcap.c (valid_filename_p, tprint, main): Likewise.
6032 * tparam.c (main): Likewise.
6033 * unexhp9k800.c (run_time_remap, save_data_space)
6034 (update_file_ptrs, read_header, write_header, calculate_checksum)
6035 (copy_file, copy_rest, display_header): Likewise.
6036 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6038 * xdisp.c (check_it): Likewise.
6039 * xfaces.c (register_color, unregister_color, unregister_colors):
6041 * xfns.c (print_fontset_result): Likewise.
6042 * xrdb.c (member, fatal, main): Likewise.
6044 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6046 Fix minor problems found by static checking (Bug#9031).
6047 * chartab.c (char_table_set_range, map_sub_char_table):
6048 Remove unused locals.
6049 (uniprop_table): Now static.
6050 * composite.c (_work_char): Remove unused static var.
6052 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6054 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6056 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6058 * gtkutil.c (qttip_cb): Remove code without function.
6060 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6062 * w32.c (pthread_sigmask): New stub.
6064 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6066 Use pthread_sigmask, not sigprocmask (Bug#9010).
6067 sigprocmask is portable only for single-threaded applications, and
6068 Emacs can be multi-threaded when it uses GTK.
6069 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6071 * callproc.c (Fcall_process):
6072 * process.c (create_process):
6073 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6074 Use pthread_sigmask, not sigprocmask.
6076 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6078 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6079 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6082 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6084 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6085 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6086 (xg_hide_tooltip): Fix comment.
6088 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6089 in registerServicesMenuSendTypes.
6090 (validRequestorForSendType): Don't check ns_return_types.
6092 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6095 2011-07-08 Jason Rumney <jasonr@gnu.org>
6097 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6098 SH_SHOW for hidden windows (Bug#5482).
6100 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6101 frame struct members of non-existent frames (Bug#6284).
6103 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6105 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6106 variable firstTime not needed on OSX >= 10.6.
6107 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6108 >= 10.5. Use setKnobProportion, setDoubleValue.
6110 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6111 (MAC_OS_X_VERSION_10_5): Define if not defined.
6112 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6113 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6114 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6116 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6117 cString and lossyCString on OSX >= 10.4
6119 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6120 sizeToFit on OSX >= 10.2.
6122 * nsimage.m (allocInitFromFile): Don't use deprecated method
6123 bestRepresentationForDevice on OSX >= 10.6.
6125 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6128 * emacs.c: Declare unexec_init_emacs_zone.
6130 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6132 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6134 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6135 on svcsMenu (Bug#8842).
6137 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6139 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6141 * nsterm.m (QUTF8_STRING): Declare.
6142 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6143 (validRequestorForSendType): Return type is (id).
6144 Change indexOfObjectIdenticalTo to indexOfObject.
6145 Check if we have local selection before returning self (Bug#8842).
6146 (writeSelectionToPasteboard): Put local selection into paste board
6147 if we have a local selection (Bug#8842).
6148 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6150 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6151 (ns_get_local_selection): Declare.
6153 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6155 * keymap.c (describe_map_tree): Don't insert a double newline at
6156 the end of the buffer (bug#1169) and return whether we inserted
6159 * callint.c (Fcall_interactively): Change "reading args" to
6160 "providing args" to try to clarify what it does (bug#1010).
6162 2011-07-07 Kenichi Handa <handa@m17n.org>
6164 * composite.c (composition_compute_stop_pos): Ignore a static
6165 composition starting before CHARPOS (Bug#8915).
6167 * xdisp.c (handle_composition_prop): Likewise.
6169 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6171 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6174 2011-07-07 Kenichi Handa <handa@m17n.org>
6176 * character.h (unicode_category_t): New enum type.
6178 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6179 (Qchar_code_property_table): New variable.
6180 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6181 (UNIPROP_COMPRESSED_FORM_P): New macros.
6182 (char_table_ascii): Uncompress the compressed values.
6183 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6184 Uncompress the compressed values.
6185 (sub_char_table_ref_and_range): Likewise.
6186 (char_table_ref_and_range): Uncompress the compressed values.
6187 (sub_char_table_set): New arg is_uniprop. Callers changed.
6188 Uncompress the compressed values.
6189 (sub_char_table_set_range): Args changed. Callers changed.
6190 (char_table_set_range): Adjuted for the above change.
6191 (map_sub_char_table): Delete args default_val and parent. Add arg
6192 top. Give decoded values to a Lisp function.
6193 (map_char_table): Adjust for the above change. Give decoded
6194 values to a Lisp function. Gcpro more variables.
6195 (uniprop_table_uncompress)
6196 (uniprop_decode_value_run_length): New functions.
6197 (uniprop_decoder, uniprop_decoder_count): New variables.
6198 (uniprop_get_decoder, uniprop_encode_value_character)
6199 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6201 (uniprop_encoder, uniprop_encoder_count): New variables.
6202 (uniprop_get_encoder, uniprop_table)
6203 (Funicode_property_table_internal, Fget_unicode_property_internal)
6204 (Fput_unicode_property_internal): New functions.
6205 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6206 Sunicode_property_table_internal, Sget_unicode_property_internal,
6207 and Sput_unicode_property_internal. Defvar_lisp
6208 char-code-property-alist.
6210 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6211 Vunicode_category_table.
6213 * font.c (font_range): Adjust for the change of
6214 Vunicode_category_table.
6216 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6218 * m/iris4d.h: Remove file, move contents ...
6219 * s/irix6-5.h: ... here.
6221 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6223 Remove unportable assumption about struct layout (Bug#8884).
6224 * alloc.c (mark_buffer):
6225 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6226 (clone_per_buffer_values): Don't assume that
6227 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6228 This isn't true in general, and it's particularly not true
6229 if Emacs is configured with --with-wide-int.
6230 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6231 New macros, used in the buffer.c change.
6233 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6235 * xsettings.c: Use both GConf and GSettings if both are available.
6236 (store_config_changed_event): Add comment.
6237 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6238 (store_tool_bar_style_changed): New functions.
6239 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6240 (struct xsettings): Move font inside HAVE_XFT.
6241 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6242 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6243 Move inside HAVE_XFT.
6244 (something_changed_gsettingsCB): Rename from something_changedCB.
6245 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6247 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6248 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6249 (something_changed_gconfCB): Rename from something_changedCB.
6250 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6251 (parse_settings): Move check for font inside HAVE_XFT.
6252 (read_settings, apply_xft_settings): Add comment.
6253 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6254 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6255 call store_font_name_changed.
6256 (xft_settings_event): Add comment.
6257 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6258 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6259 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6260 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6261 (xsettings_initialize): Call init_gsettings last.
6262 (xsettings_get_system_font, xsettings_get_system_normal_font):
6265 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6267 Random fixes. E.g., (random) never returned negative values.
6268 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6269 subseconds part to the entropy, as that's a bit more random.
6270 Prefer signed to unsigned, since the signedness doesn't matter and
6271 in general we prefer signed. When given a limit, use a
6272 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6273 latter isn't right if USE_2_TAGS_FOR_INTS.
6274 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6275 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6277 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6279 * textprop.c (text_property_stickiness):
6280 Obey Vtext_property_default_nonsticky.
6281 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6282 * w32fns.c (syms_of_w32fns):
6283 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6285 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6287 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6288 This is more efficient than Ffile_directory_p and avoids a minor race.
6290 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6292 * buffer.c (Foverlay_put): Say what the return value is
6295 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6296 is a directory before asking whether to use the file name
6298 (barf_or_query_if_file_exists): Make the "File is a directory"
6299 error be more correct.
6301 * fns.c (Frequire): Remove the mention of the .gz files, since
6302 that's installation-specific, but keep the mention of
6303 `get-load-suffixes'.
6305 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6307 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6308 Report string overflow if the output is too long.
6310 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6312 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6313 (syms_of_gnutls): Remove duplicate DEFSYM for
6314 Qgnutls_bootprop_verify_hostname_error, an error for
6315 Qgnutls_bootprop_verify_error (which is no longer used).
6317 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6318 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6319 Also (re)move comments that are misplaced or no longer relevant.
6321 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6323 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6325 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6327 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6328 and background color parameters if they have been changed.
6330 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6332 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6334 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6336 * xsettings.c (SYSTEM_FONT): Define only when used.
6337 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6339 * keymap.c (access_keymap_1): Now static.
6341 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6343 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6344 leave any prefix arg for the up event (Bug#1586).
6346 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6348 * lread.c (syms_of_lread): Mention single symbols defined by
6349 `defvar' or `defconst' (bug#7154).
6351 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6352 (Frequire): Mention get-load-suffixes.
6354 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6356 * window.h (window): Remove clone_number slot.
6357 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6359 (make_parent_window, make_window, saved_window)
6360 (Fset_window_configuration, save_window_save): Don't deal with
6362 * buffer.c (Qclone_number): Remove declaration.
6363 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6365 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6367 Add multiple inheritance to keymaps.
6368 * keymap.c (Fmake_composed_keymap): New function.
6369 (Fset_keymap_parent): Simplify.
6370 (fix_submap_inheritance): Remove.
6371 (access_keymap_1): New function extracted from access_keymap to handle
6372 embedded parents and handle lists of maps.
6373 (access_keymap): Use it.
6374 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6375 (Fcopy_keymap): Handle embedded parents.
6376 (Fcommand_remapping, define_as_prefix): Simplify.
6377 (Fkey_binding): Simplify.
6378 (syms_of_keymap): Move minibuffer-local-completion-map,
6379 minibuffer-local-filename-completion-map,
6380 minibuffer-local-must-match-map, and
6381 minibuffer-local-filename-must-match-map to Elisp.
6382 (syms_of_keymap): Defsubr make-composed-keymap.
6383 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6384 (parse_menu_item): Trivial simplification.
6386 2011-07-01 Glenn Morris <rgm@gnu.org>
6388 * Makefile.in (SETTINGS_LIBS): Fix typo.
6390 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6392 * coding.c (Fencode_coding_string): Record the last coding system
6393 used, as the function doc string says (bug#8738).
6395 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6397 * xsettings.c (store_monospaced_changed): Take new font as arg and
6398 check for change against current_mono_font.
6399 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6400 (emacs_settings_constructor, emacs_settings_get_property)
6401 (emacs_settings_set_property, emacs_settings_class_init)
6402 (emacs_settings_init, gsettings_obj): Remove.
6403 (something_changedCB): New function for HAVE_GSETTINGS.
6404 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6405 with value as argument.
6406 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6407 g_settings_new (Bug#8967). Do not create gsettings_obj.
6408 Remove calls to g_settings_bind. Connect something_changedCB to
6411 * xgselect.c: Add defined (HAVE_GSETTINGS).
6412 (xgselect_initialize): Ditto.
6414 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6415 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6418 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6420 * eval.c (struct backtrace): Simplify and port the data structure.
6421 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6422 signed bit field, as this assumption is not portable and it makes
6423 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6424 "char debug_on_exit : 1" as this is not portable either; instead,
6425 use the portable "unsigned int debug_on_exit : 1". Remove unused
6426 member evalargs. Remove obsolete comments about cc bombing out.
6428 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6430 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6431 Let HAVE_GSETTINGS override HAVE_GCONF.
6432 (store_monospaced_changed): New function.
6433 (EMACS_SETTINGS): A new type derived from GObject to handle
6434 GSettings notifications.
6435 (emacs_settings_constructor, emacs_settings_get_property)
6436 (emacs_settings_set_property, emacs_settings_class_init):
6438 (gsettings_client, gsettings_obj): New variables.
6439 (GSETTINGS_SCHEMA): New define.
6440 (something_changedCB): Call store_monospaced_changed.
6441 (init_gsettings): New function.
6442 (xsettings_initialize): Call init_gsettings.
6443 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6446 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6449 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6451 * window.c (resize_root_window, grow_mini_window)
6452 (shrink_mini_window): Rename Qresize_root_window to
6453 Qwindow_resize_root_window and Qresize_root_window_vertically to
6454 Qwindow_resize_root_window_vertically.
6456 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6458 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6460 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6462 * makefile.w32-in: Redesign dependencies so they reflect more
6463 clearly which files are directly included by each source file,
6464 and not through other includes.
6466 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6468 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6469 (sort_overlays, overlay_strings): When an overlay's clone number
6470 matches the window's clone number process the overlay even if
6471 the overlay's window property doesn't match the current window.
6473 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6474 (Fwindow_hchild): Rename to Fwindow_left_child.
6475 (Fwindow_next): Rename to Fwindow_next_sibling.
6476 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6477 (resize_window_check): Rename to window_resize_check.
6478 (resize_window_apply): Rename to window_resize_apply.
6479 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6480 (Fdelete_other_windows_internal, resize_frame_windows)
6481 (Fsplit_window_internal, Fdelete_window_internal)
6482 (grow_mini_window, shrink_mini_window)
6483 (Fresize_mini_window_internal): Fix callers accordingly.
6485 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6487 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6488 (emacs_fixed_set_min_size): Remove.
6489 (emacs_fixed_new): Take frame as argument.
6491 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6492 (_EmacsFixedPrivate): Remove minwidth/height.
6493 Add struct frame *f.
6494 (emacs_fixed_init): Initialize priv->f.
6495 (get_parent_class, emacs_fixed_set_min_size): Remove.
6496 (emacs_fixed_new): Set priv->f to argument.
6497 (emacs_fixed_get_preferred_width)
6498 (emacs_fixed_get_preferred_height): Use min_width/height from
6499 frames size_hint to set minimum and natural (Bug#8919).
6500 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6501 and use min_width/height from frames size_hint to set
6502 min_width/height (Bug#8919).
6504 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6505 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6508 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6510 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6511 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6514 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6516 * process.c (wait_reading_process_output): Bypass select if
6517 waiting for a cell while ignoring keyboard input, and input is
6518 pending. Suggested by Jan Djärv (Bug#8869).
6520 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6522 Use gnulib's dup2 module instead of rolling our own.
6523 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6525 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6527 * dispnew.c (scrolling_window): Before scrolling, turn off a
6528 mouse-highlight in the window being scrolled.
6530 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6532 Move DEFSYM to lisp.h and use everywhere.
6534 * character.h (DEFSYM): Move declaration...
6535 * lisp.h (DEFSYM): ...here.
6541 * w32select.c: Don't include character.h.
6543 * alloc.c (syms_of_alloc):
6544 * buffer.c (syms_of_buffer):
6545 * bytecode.c (syms_of_bytecode):
6546 * callint.c (syms_of_callint):
6547 * casefiddle.c (syms_of_casefiddle):
6548 * casetab.c (init_casetab_once):
6549 * category.c (init_category_once, syms_of_category):
6550 * ccl.c (syms_of_ccl):
6551 * cmds.c (syms_of_cmds):
6552 * composite.c (syms_of_composite):
6553 * dbusbind.c (syms_of_dbusbind):
6554 * dired.c (syms_of_dired):
6555 * dispnew.c (syms_of_display):
6556 * doc.c (syms_of_doc):
6557 * editfns.c (syms_of_editfns):
6558 * emacs.c (syms_of_emacs):
6559 * eval.c (syms_of_eval):
6560 * fileio.c (syms_of_fileio):
6561 * fns.c (syms_of_fns):
6562 * frame.c (syms_of_frame):
6563 * fringe.c (syms_of_fringe):
6564 * insdel.c (syms_of_insdel):
6565 * keymap.c (syms_of_keymap):
6566 * lread.c (init_obarray, syms_of_lread):
6567 * macros.c (syms_of_macros):
6568 * msdos.c (syms_of_msdos):
6569 * print.c (syms_of_print):
6570 * process.c (syms_of_process):
6571 * search.c (syms_of_search):
6572 * sound.c (syms_of_sound):
6573 * syntax.c (init_syntax_once, syms_of_syntax):
6574 * terminal.c (syms_of_terminal):
6575 * textprop.c (syms_of_textprop):
6576 * undo.c (syms_of_undo):
6577 * w32.c (globals_of_w32):
6578 * window.c (syms_of_window):
6579 * xdisp.c (syms_of_xdisp):
6580 * xfaces.c (syms_of_xfaces):
6581 * xfns.c (syms_of_xfns):
6582 * xmenu.c (syms_of_xmenu):
6583 * xsettings.c (syms_of_xsettings):
6584 * xterm.c (syms_of_xterm): Use DEFSYM.
6586 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6588 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6590 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6592 Integer and buffer overflow fixes (Bug#8873).
6594 * print.c (printchar, strout): Check for string overflow.
6595 (PRINTPREPARE, printchar, strout):
6596 Don't set size unless allocation succeeds.
6598 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6599 for sizes. Check for string overflow more accurately.
6600 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6602 * macros.c: Integer and buffer overflow fixes.
6603 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6604 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6605 Use ptrdiff_t, not int, for sizes.
6606 Don't increment bufsize until after realloc succeeds.
6607 Check for size-calculation overflow.
6608 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6610 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6612 * lread.c: Integer overflow fixes.
6613 (read_integer): Radix is now EMACS_INT, not int,
6614 to improve quality of diagnostics for out-of-range radices.
6615 Calculate buffer size correctly for out-of-range radices.
6616 (read1): Check for integer overflow in radices, and in
6617 read-circle numbers.
6618 (read_escape): Avoid int overflow.
6619 (Fload, openp, read_buffer_size, read1)
6620 (substitute_object_recurse, read_vector, read_list, map_obarray):
6621 Use ptrdiff_t, not int, for sizes.
6622 (read1): Use EMACS_INT, not int, for sizes.
6623 Check for size overflow.
6625 * image.c (cache_image): Check for size arithmetic overflow.
6627 * lread.c: Integer overflow issues.
6628 (saved_doc_string_size, saved_doc_string_length)
6629 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6630 Now ptrdiff_t, not int.
6631 (read1): Don't assume doc string length fits in int. Check for
6632 out-of-range doc string lengths.
6633 (read_list): Don't assume file position fits in int.
6634 (read_escape): Check for hex character overflow.
6636 2011-06-22 Leo Liu <sdl.web@gmail.com>
6638 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6639 Move to minibuffer.el.
6641 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6643 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6644 The following patches are for when GLYPH_DEBUG && !XASSERT.
6645 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6646 * dispnew.c (flush_stdout):
6647 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6648 Mark as externally visible.
6649 * dispnew.c (check_window_matrix_pointers): Now static.
6650 * dispnew.c (window_to_frame_vpos):
6651 * xfns.c (unwind_create_frame):
6652 * xterm.c (x_check_font): Remove unused local.
6653 * scroll.c (CHECK_BOUNDS):
6654 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6655 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6656 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6657 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6658 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6660 (debug_method_add): Use va_list and vsprintf rather than relying
6661 on undefined behavior with wrong number of arguments.
6662 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6663 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6664 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6665 since we're not interested in debugging glyphs with old libraries.
6666 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6667 GCC 4.6.0's static checking.
6669 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6671 Integer overflow and signedness fixes (Bug#8873).
6672 A few related buffer overrun fixes, too.
6674 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6676 * dispextern.h (struct face.stipple):
6677 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6678 (x_bitmap_mask, x_allocate_bitmap_record)
6679 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6680 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6681 (x_create_bitmap_from_xpm_data):
6682 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6683 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6685 * xfaces.c (load_pixmap):
6686 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6687 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6688 (.bitmaps_last, struct x_output.icon_bitmap):
6689 Use ptrdiff_t, not int, for bitmap indexes.
6690 (x_allocate_bitmap_record): Check for size overflow.
6691 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6693 Use ptrdiff_t, not int, for overlay counts.
6694 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6695 * editfns.c (overlays_around, get_pos_property):
6696 * textprop.c (get_char_property_and_overlay):
6697 * xdisp.c (next_overlay_change, note_mouse_highlight):
6698 * xfaces.c (face_at_buffer_position):
6699 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6700 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6701 (Fnext_overlay_change, Fprevious_overlay_change)
6702 (mouse_face_overlay_overlaps, Foverlays_in):
6703 Use ptrdiff_t, not int, for sizes.
6704 (overlays_at, overlays_in): Check for size-calculation overflow.
6706 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6708 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6709 (x_session_initialize): Do not assume string length fits in int.
6711 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6712 This is unlikely, but can occur if DPI is outlandish.
6714 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6715 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6717 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6718 * xrdb.c (magic_file_p, search_magic_path):
6719 Omit last arg SUFFIX; it was always 0. All callers changed.
6720 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6722 * xfont.c (xfont_match): Avoid need for strlen.
6724 * xfns.c: Don't assume strlen fits in int.
6725 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6727 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6728 not unsigned long, as we prefer signed integers. All callers changed.
6729 Detect integer overflow in repeat count.
6730 (message_dolog): Don't assume print length fits in 39 bytes.
6731 (display_mode_element): Don't assume strlen fits in int.
6733 * termcap.c: Don't assume sizes fit in int and never overflow.
6734 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6735 (gobble_line): Check for size-calculation overflow.
6737 * minibuf.c (Fread_buffer):
6738 * lread.c (intern, intern_c_string):
6739 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6740 Don't assume string length fits in int.
6742 * keyboard.c (parse_tool_bar_item):
6743 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6745 * font.c: Don't assume string length fits in int.
6746 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6747 Use ptrdiff_t, not int.
6748 (font_intern_prop): Don't assume string length fits in int.
6749 Don't assume integer property fits in fixnum.
6750 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6752 * filelock.c: Fix some buffer overrun and integer overflow issues.
6753 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6754 Reformulate so as not to need the command string.
6755 Invoke gzip -cd rather than gunzip, as it's more portable.
6756 (lock_info_type, lock_file_1, lock_file):
6757 Don't assume pid_t and time_t fit in unsigned long.
6758 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6759 (current_lock_owner): Prefer signed type for sizes.
6760 Use memcpy, not strncpy, where memcpy is what is really wanted.
6761 Don't assume (via atoi) that time_t and pid_t fit in int.
6762 Check for time_t and/or pid_t out of range, e.g., via a network share.
6763 Don't alloca where an auto var works fine.
6765 * fileio.c: Fix some integer overflow issues.
6766 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6767 Don't assume string length fits in int.
6768 (directory_file_name): Don't assume string length fits in long.
6769 (make_temp_name): Don't assume pid fits in int, or that its print
6770 length is less than 20.
6772 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6774 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6776 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6778 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6779 We prefer signed integers, even for size calculations.
6781 * emacs.c: Don't assume string length fits in 'int'.
6782 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6783 (main): Don't invoke strlen when not needed.
6785 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6786 (XD_DEBUG_MESSAGE): Don't waste a byte.
6788 * callproc.c (getenv_internal_1, getenv_internal)
6790 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6792 * lread.c (invalid_syntax): Omit length argument.
6793 All uses changed. This doesn't fix a bug, but it simplifies the
6794 code away from its former Hollerith-constant appearance, and it's
6795 one less 'int' to worry about when looking at integer-overflow issues.
6796 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6798 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6799 This didn't break anything, but it didn't help either.
6800 It's confusing to put a bogus integer in a place where the actual
6801 value does not matter.
6802 (LIST_END_P): Remove unused macro and its bogus comment.
6803 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6805 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6806 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6808 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6809 We prefer signed types, and the value cannot exceed the EMACS_INT
6810 range anyway (because otherwise the length would not be representable).
6811 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6812 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6813 This avoids a GCC warning when WIDE_EMACS_INT.
6815 * indent.c (sane_tab_width): New function.
6816 (current_column, scan_for_column, Findent_to, position_indentation)
6817 (compute_motion): Use it. This is just for clarity.
6818 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6820 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6822 * lisp.h (lint_assume): New macro.
6823 * composite.c (composition_gstring_put_cache):
6824 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6826 * editfns.c, insdel.c:
6827 Omit unnecessary forward decls, to simplify future changes.
6829 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6831 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6833 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6834 Use much-faster test for byte-length change.
6835 Don't assume string byte-length fits in 'int'.
6836 Check that character arg fits in 'int'.
6837 (mapcar1): Declare byte as byte, for clarity.
6839 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6841 * fns.c (concat): Catch string overflow earlier.
6842 Do not rely on integer wraparound.
6844 * dispextern.h (struct it.overlay_strings_charpos)
6845 (struct it.selective): Now EMACS_INT, not int.
6846 * xdisp.c (forward_to_next_line_start)
6847 (back_to_previous_visible_line_start)
6848 (reseat_at_next_visible_line_start, next_element_from_buffer):
6849 Don't arbitrarily truncate the value of 'selective' to int.
6851 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6853 * composite.c: Don't truncate sizes to 'int'.
6854 (composition_gstring_p, composition_reseat_it)
6855 (composition_adjust_point): Use EMACS_INT, not int.
6856 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6857 not EMACS_UINT, for indexes.
6859 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6861 * buffer.c: Include <verify.h>.
6862 (struct sortvec.priority, struct sortstr.priority):
6863 Now EMACS_INT, not int.
6864 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6865 (struct sortstr.size, record_overlay_string)
6866 (struct sortstrlist.size, struct sortlist.used):
6867 Don't truncate size to int.
6868 (record_overlay_string): Check for size-calculation overflow.
6869 (init_buffer_once): Check at compile-time, not run-time.
6871 2011-06-22 Jim Meyering <meyering@redhat.com>
6873 Don't leak an XBM-image-sized buffer
6874 * image.c (xbm_load): Free the image buffer after using it.
6876 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6879 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6880 that Sun C diagnosed.
6881 * fns.c (secure_hash): Fix pointer signedness issue.
6882 * intervals.c (static_offset_intervals): New function.
6883 (offset_intervals): Use it.
6885 2011-06-21 Leo Liu <sdl.web@gmail.com>
6888 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6891 * fns.c (secure_hash): Rename from crypto_hash_function and change
6892 the first arg to accept symbols.
6893 (Fsecure_hash): New primitive.
6894 (syms_of_fns): New symbols.
6896 2011-06-20 Deniz Dogan <deniz@dogan.se>
6898 * process.c (Fset_process_buffer): Clarify return value in
6901 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6903 * dispnew.c (add_window_display_history): Use BVAR.
6905 * xdisp.c (debug_method_add): Use BVAR.
6906 (check_window_end, dump_glyph_matrix, dump_glyph)
6907 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6909 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6912 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6913 check till after the cache is created in init_frame_faces.
6915 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6917 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6919 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6921 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6922 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6923 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6925 Improve buffer-overflow checking (Bug#8873).
6926 * fileio.c (Finsert_file_contents):
6927 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6928 Remove the old (too-loose) buffer overflow checks.
6929 They weren't needed, since make_gap checks for buffer overflow.
6930 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6931 The old code merely checked for Emacs fixnum overflow, and relied
6932 on undefined (wraparound) behavior. The new code avoids undefined
6933 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6935 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6936 Tune. Don't use wider integers than needed. Don't use alloca.
6937 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6939 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6941 * insdel.c, lisp.h (buffer_overflow): New function.
6942 (insert_from_buffer_1, replace_range, replace_range_2):
6943 * insdel.c (make_gap_larger):
6944 * editfns.c (Finsert_char):
6945 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6947 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6949 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6951 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6953 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6954 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6956 * fileio.c: Don't assume EMACS_INT fits in off_t.
6957 (emacs_lseek): New static function.
6958 (Finsert_file_contents, Fwrite_region): Use it.
6959 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6961 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6963 * fns.c: Don't overflow int when computing a list length.
6964 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6965 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6966 truncation on 64-bit hosts. Check for QUIT every
6967 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6968 faster and is responsive enough.
6969 (Flength): Report an error instead of overflowing an integer.
6970 (Fsafe_length): Return a float if the value is not representable
6971 as a fixnum. This shouldn't happen except in contrived situations.
6972 (Fnthcdr, Fsort): Don't assume list length fits in int.
6973 (Fcopy_sequence): Don't assume vector length fits in int.
6975 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6976 (header_size, word_size): New constants.
6977 (allocate_vectorlike): Don't check size overflow here.
6978 (allocate_vector): Check it here instead, since this is the only
6979 caller of allocate_vectorlike that could cause overflow.
6980 Check that the new vector's length is representable as a fixnum.
6982 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6983 The previous code was bogus. For example, next_almost_prime (32)
6984 returned 39, which is undesirable as it is a multiple of 3; and
6985 next_almost_prime (24) returned 25, which is a multiple of 5 so
6986 why was the code bothering to check for multiples of 7?
6988 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6990 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6992 Variadic C functions now count arguments with ptrdiff_t.
6993 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6994 Back then I didn't know that the Emacs coding style prefers signed int.
6995 Also, in the meantime I found a few more instances where arguments
6996 were being counted with int, which may truncate counts on 64-bit
6997 machines, or EMACS_INT, which may be unnecessarily wide.
6998 * lisp.h (struct Lisp_Subr.function.aMANY)
6999 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7000 Arg counts are now ptrdiff_t, not size_t.
7001 All variadic functions and their callers changed accordingly.
7002 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7003 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7004 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7005 * callint.c (Fcall_interactively): Check arg count for overflow,
7006 to avoid potential buffer overrun. Use signed char, not 'int',
7007 for 'varies' array, so that we needn't bother to check its size
7008 calculation for overflow.
7009 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7010 * eval.c (apply_lambda):
7011 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7012 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7013 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7015 * callint.c (Fcall_interactively): Don't use index var as event count.
7017 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7018 * mem-limits.h (SIZE): Remove; no longer used.
7020 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7022 Remove unnecessary casts.
7023 * xterm.c (x_term_init):
7024 * xfns.c (x_set_border_pixel):
7025 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7026 These aren't needed now that we assume ANSI C.
7028 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7029 It's more likely to cause problems (due to unsigned overflow)
7032 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7034 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7036 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7038 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7040 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7042 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7044 GLYPH_CODE_FACE returns EMACS_INT, not int.
7045 * dispextern.h (merge_faces):
7046 * xfaces.c (merge_faces):
7047 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7048 Don't assume EMACS_INT fits in int.
7050 * character.h (CHAR_VALID_P): Remove unused parameter.
7051 * fontset.c, lisp.h, xdisp.c: All uses changed.
7053 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7055 * fns.c (concat): Minor tuning based on overflow analysis.
7056 This doesn't fix any bugs. Use int to hold character, instead
7057 of constantly refetching from Emacs object. Use XFASTINT, not
7058 XINT, for value known to be a character. Don't bother comparing
7059 a single byte to 0400, as it's always less.
7061 * floatfns.c (Fexpt):
7062 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7064 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7067 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7069 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7070 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7071 incorrectly succeed when S was a string, because 4294967386 was
7072 truncated before it was used.
7074 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7075 Otherwise, an out-of-range integer could cause undefined behavior
7078 * composite.c: Use int, not EMACS_INT, for characters.
7079 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7080 EMACS_INT, for values that are known to be in character range.
7081 This doesn't fix any bugs but is the usual style inside Emacs and
7082 may generate better code on 32-bit machines.
7084 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7085 This is for reasons similar to the recent CHAR_STRING fix.
7086 * charset.c (Fencode_char): Check that character arg is actually
7087 a character. Pass an int to ENCODE_CHAR.
7088 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7089 wider than 'int', as a compile-time check to prevent future regressions
7092 * character.c (char_string): Remove unnecessary casts.
7094 Make sure a 64-bit char is never passed to CHAR_STRING.
7095 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7096 by silently ignoring the top 32 bits, allowing some values
7097 that were far too large to be valid characters.
7098 * character.h: Include <verify.h>.
7099 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7100 arguments are no wider than unsigned, as a compile-time check
7101 to prevent future regressions in this area.
7103 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7104 (Fsubst_char_in_region):
7106 * xdisp.c (decode_mode_spec_coding):
7107 Adjust to CHAR_STRING's new requirement.
7108 * editfns.c (Finsert_char, Fsubst_char_in_region):
7109 * fns.c (concat): Check that character args are actually
7110 characters. Without this test, these functions did the wrong
7111 thing with wildly out-of-range values on 64-bit hosts.
7113 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7114 These casts should not be needed on 32-bit hosts, either.
7115 * keyboard.c (read_char):
7116 * lread.c (Fload): Remove casts to unsigned.
7118 * lisp.h (UNSIGNED_CMP): New macro.
7119 This fixes comparison bugs on 64-bit hosts.
7120 (ASCII_CHAR_P): Use it.
7121 * casefiddle.c (casify_object):
7122 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7123 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7124 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7125 * dispextern.h (FACE_FROM_ID):
7126 * keyboard.c (read_char): Use UNSIGNED_CMP.
7128 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7129 not to EMACS_INT, to avoid GCC warning.
7131 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7133 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7134 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7135 isn't needed on 32-bit machines.
7137 * buffer.c (Fgenerate_new_buffer_name):
7138 Use EMACS_INT for count, not int.
7139 (advance_to_char_boundary): Return EMACS_INT, not int.
7141 * data.c (Qcompiled_function): Now static.
7143 * window.c (window_body_lines): Now static.
7145 * image.c (gif_load): Rename local to avoid shadowing.
7147 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7148 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7149 * alloc.c (make_save_value): Integer argument is now of type
7151 (mark_object): Use ptrdiff_t, not int.
7152 * lisp.h (pD): New macro.
7153 * print.c (print_object): Use it.
7155 * alloc.c: Use EMACS_INT, not int, to count objects.
7156 (total_conses, total_markers, total_symbols, total_vector_size)
7157 (total_free_conses, total_free_markers, total_free_symbols)
7158 (total_free_floats, total_floats, total_free_intervals)
7159 (total_intervals, total_strings, total_free_strings):
7160 Now EMACS_INT, not int. All uses changed.
7161 (Fgarbage_collect): Compute overall total using a double, so that
7162 integer overflow is less likely to be a problem. Check for overflow
7163 when converting back to an integer.
7164 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7165 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7166 These were 'int' variables that could overflow on 64-bit hosts;
7167 they were never used, so remove them instead of repairing them.
7168 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7169 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7170 Previously, this ceilinged at INT_MAX, but that doesn't work on
7172 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7174 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7175 (allocate_vectorlike): Check for ptrdiff_t overflow.
7176 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7177 when a (possibly-narrower) signed value would do just as well.
7178 We prefer using signed arithmetic, to avoid comparison confusion.
7180 * alloc.c: Catch some string size overflows that we were missing.
7181 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7182 for convenience in STRING_BYTES_MAX.
7183 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7184 The definition here is exact; the one in lisp.h was approximate.
7185 (allocate_string_data): Check for string overflow. This catches
7186 some instances we weren't catching before. Also, it catches
7187 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7188 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7189 and ptrdiff_t and EMACS_INT are both 64 bits.
7191 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7192 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7193 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7195 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7197 * alloc.c (Fmake_string): Check for out-of-range init.
7199 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7201 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7203 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7205 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7206 xg_get_default_scrollbar_width.
7208 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7209 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7210 (style_changed_cb): Call update_theme_scrollbar_width and call
7211 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7212 all frames (Bug#8505).
7213 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7214 Call gtk_window_set_resizable if HAVE_GTK3.
7215 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7216 and height if HAVE_GTK3 (Bug#8505).
7217 (scroll_bar_width_for_theme): New variable.
7218 (update_theme_scrollbar_width): New function.
7219 (xg_get_default_scrollbar_width): Move code to
7220 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7221 (xg_initialize): Call update_theme_scrollbar_width.
7223 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7225 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7227 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7229 * frame.c (make_frame): Call other_buffer_safely instead of
7232 * window.c (temp_output_buffer_show): Call display_buffer with
7233 second argument Vtemp_buffer_show_specifiers and reset latter
7234 immediately after the call.
7235 (Vtemp_buffer_show_specifiers): New variable.
7236 (auto_window_vscroll_p, next_screen_context_lines)
7237 (Vscroll_preserve_screen_position): Remove leading asterisks from
7240 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7242 Fix minor problems found by GCC 4.6.0 static checking.
7243 * buffer.c (Qclone_number): Remove for now, as it's unused.
7244 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7245 (record_buffer): Remove unused local.
7246 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7247 (set_frame_buffer_list): Remove; unused.
7248 * frame.h (other_visible_frames): Remove decl.
7249 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7250 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7251 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7253 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7254 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7255 Define only if HAVE_GPM.
7256 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7257 (update_hints_inhibit): Remove; never set. All uses removed.
7258 * widgetprv.h (emacsFrameClassRec): Remove decl.
7259 * window.c (delete_deletable_window): Now returns void, since it
7260 wasn't returning anything.
7261 (compare_window_configurations): Remove unused locals.
7262 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7263 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7264 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7265 the same widths as pointers. This follows up on the 2011-05-06 patch.
7266 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7267 * xterm.h: Likewise.
7268 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7270 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7272 * makefile.w32-in: Update dependencies.
7273 (LISP_H): Add lib/intprops.h.
7275 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7277 * image.c (gif_load): Add animation frame delay to the metadata.
7278 (syms_of_image): Use DEFSYM. New symbol `delay'.
7280 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7282 * window.c (delete_deletable_window): Re-add.
7283 (Fset_window_configuration): Rewrite to handle dead buffers and
7284 consequently deletable windows.
7285 (window_tree, Fwindow_tree): Remove. Supply functionality in
7287 (compare_window_configurations): Simplify code.
7289 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7291 * image.c (imagemagick_load_image): Fix type mismatch.
7292 (Fimagemagick_types): Likewise.
7294 * window.h (replace_buffer_in_windows): Declare.
7296 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7298 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7299 Qclone_number. Remove external declaration of Qdelete_window.
7300 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7302 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7303 Run Qbuffer_list_update_hook if allowed.
7304 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7305 buffer list implementation.
7306 (other_buffer_safely): New function.
7307 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7308 calls to replace_buffer_in_windows and
7309 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7311 (record_buffer): Inhibit quitting and rewrite using quittable
7312 functions. Run Qbuffer_list_update_hook if allowed.
7313 (Frecord_buffer, Funrecord_buffer): New functions.
7314 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7315 Move switch-to-buffer to window.el.
7316 (bury-buffer): Move to window.el.
7317 (Vbuffer_list_update_hook): New variable.
7319 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7322 * window.h (resize_frame_windows): Move up in code.
7323 (Fwindow_frame): Remove EXFUN.
7324 (replace_buffer_in_all_windows): Remove prototype.
7325 (replace_buffer_in_windows_safely): Add prototype.
7327 * window.c: Declare Qdelete_window static again. Move down
7328 declaration of select_count.
7329 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7330 (Fother_window): Move to window.el.
7331 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7332 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7333 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7335 (replace_buffer_in_windows): Implement by calling
7336 Qreplace_buffer_in_windows.
7337 (replace_buffer_in_all_windows): Remove with some functionality
7338 moved into replace_buffer_in_windows_safely.
7339 (replace_buffer_in_windows_safely): New function.
7340 (select_window_norecord, select_frame_norecord): Move in front
7341 of run_window_configuration_change_hook. Remove now obsolete
7343 (Fset_window_buffer): Rewrite doc-string.
7344 Call Qrecord_window_buffer.
7345 (keys_of_window): Move binding for other-window to window.el.
7347 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7349 * dispextern.h (struct image): Replace data member, whose int_val
7350 and ptr_val fields were not used by anything, with a single
7353 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7354 (gif_clear_image, gif_load, imagemagick_load_image)
7355 (gs_clear_image, gs_load): Callers changed.
7357 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7359 * buffer.h: Include <time.h>, for time_t.
7360 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7362 Fix minor problems found by static checking.
7364 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7366 Make identifiers static if they are not used in other modules.
7367 * data.c (Qcompiled_function, Qframe, Qvector):
7368 * image.c (QimageMagick, Qsvg):
7369 * minibuf.c (Qmetadata):
7370 * window.c (resize_window_check, resize_root_window): Now static.
7371 * window.h (resize_window_check, resize_root_window): Remove decls.
7373 * window.c (window_deletion_count, delete_deletable_window):
7375 (window_body_lines): Now static.
7376 (Fdelete_other_windows_internal): Mark vars as initialized.
7377 Make sure 'resize_failed' is initialized.
7378 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7379 (resize_window_apply): Remove unused local.
7380 * window.h (delete_deletable_window): Remove decl.
7382 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7383 (imagemagick_load_image): Fix pointer signedness problem by changing
7384 last arg from unsigned char * to char *. All uses changed.
7385 Also, fix a local for similar reasons.
7386 Remove unused locals. Remove locals to avoid shadowing.
7387 (fn_rsvg_handle_free): Remove; unused.
7388 (svg_load, svg_load_image): Fix pointer signedness problem.
7389 (imagemagick_load_image): Don't use garbage pointer image_wand.
7391 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7393 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7395 * image.c (gif_load): Fix omitted cast error introduced by
7398 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7400 * window.h (resize_proportionally, orig_total_lines)
7401 (orig_top_line): Remove from window structure.
7402 (set_window_height, set_window_width, change_window_heights)
7403 (Fdelete_window): Remove prototypes.
7404 (resize_frame_windows): Remove duplicate declaration.
7406 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7408 * window.h (resize_frame_windows, resize_window_check)
7409 (delete_deletable_window, resize_root_window)
7410 (resize_frame_windows): Declare prototypes.
7412 * window.c (resize_window_apply): Make definition be "static" to
7413 match the prototype.
7415 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7417 * window.c: Remove declarations of Qwindow_size_fixed,
7418 window_min_size_1, window_min_size_2, window_min_size,
7419 size_window, window_fixed_size_p, enlarge_window, delete_window.
7420 Remove static from declaration of Qdelete_window, it's
7421 temporarily needed by Fbury_buffer.
7422 (replace_window): Don't assign orig_top_line and
7424 (Fdelete_window, delete_window): Remove. Window deletion is
7425 handled by window.el.
7426 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7427 Replace Fdelete_window calls with calls to Qdelete_window.
7428 (Fdelete_other_windows): Remove. Deleting other windows is
7429 handled by window.el.
7430 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7431 handled in window.el.
7432 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7433 Window minimum sizes are handled in window.el.
7434 (shrink_windows, size_window, set_window_height)
7435 (set_window_width, change_window_heights, window_height)
7436 (window_width, CURBEG, CURSIZE, enlarge_window)
7437 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7438 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7439 handled in window.el.
7440 (make_dummy_parent): Rename to make_parent_window and give it a
7441 second argument horflag.
7442 (make_window): Don't set resize_proportionally any more.
7443 (Fsplit_window): Remove. Windows are split in window.el.
7444 (save_restore_action, save_restore_orig_size)
7445 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7446 Resize mini windows in window.el.
7447 (grow_mini_window, shrink_mini_window): Implement by calling
7448 Qresize_root_window_vertically, resize_window_check and
7449 resize_window_apply.
7450 (saved_window, Fset_window_configuration, save_window_save):
7451 Do not handle orig_top_line, orig_total_lines, and
7452 resize_proportionally.
7453 (window_min_height, window_min_width): Move to window.el.
7454 (keys_of_window): Move bindings for delete-other-windows,
7455 split-window, delete-window and enlarge-window to window.el.
7457 * buffer.c: Temporarily extern Qdelete_window.
7458 (Fbury_buffer): Temporarily call Qdelete_window instead of
7459 Fdelete_window (Fbury_buffer will move to window.el soon).
7461 * frame.c (set_menu_bar_lines_1): Remove code handling
7462 orig_top_line and orig_total_lines.
7464 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7465 set_window_height but set heights directly.
7466 (change_frame_size_1): Use resize_frame_windows.
7468 * xdisp.c (init_xdisp): Don't use set_window_height but set
7471 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7472 Use resize_frame_windows instead of change_window_heights and run
7473 run_window_configuration_change_hook.
7475 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7476 instead of change_window_heights and run
7477 run_window_configuration_change_hook.
7479 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7481 * window.c (replace_window): Rename second argument REPLACEMENT to
7482 NEW. New third argument SETFLAG. Rewrite.
7483 (delete_window, make_dummy_parent): Call replace_window with
7485 (window_list_1): Move down in code.
7486 (run_window_configuration_change_hook): Move set_buffer part
7487 before select_frame_norecord part in order to unwind correctly.
7488 Rename count1 to count.
7489 (recombine_windows, delete_deletable_window, resize_root_window)
7490 (Fdelete_other_windows_internal)
7491 (Frun_window_configuration_change_hook, make_parent_window)
7492 (resize_window_check, resize_window_apply, Fresize_window_apply)
7493 (resize_frame_windows, Fsplit_window_internal)
7494 (Fdelete_window_internal, Fresize_mini_window_internal):
7496 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7498 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7500 * window.h (window): Add some new members to window structure -
7501 normal_lines, normal_cols, new_total, new_normal, clone_number,
7502 splits, nest, prev_buffers, next_buffers.
7503 (WINDOW_TOTAL_SIZE): Move here from window.c.
7504 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7506 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7508 (make_dummy_parent): Set new members of windows structure.
7509 (make_window): Move down in code. Handle new members of window
7511 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7512 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7513 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7514 (Fset_window_prev_buffers, Fwindow_next_buffers)
7515 (Fset_window_next_buffers, Fset_window_clone_number):
7517 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7518 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7520 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7521 Argument WINDOW can be now internal window too.
7522 (Fwindow_use_time): Move up in code.
7523 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7525 (Fset_window_configuration, saved_window)
7526 (Fcurrent_window_configuration, save_window_save): Handle new
7527 members of window structure.
7528 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7529 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7530 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7531 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7532 Qget_mru_window, Qresize_root_window,
7533 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7534 Qauto_buffer_name; staticpro them.
7536 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7538 * window.c (Fwindow_total_size, Fwindow_left_column)
7539 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7540 (Fwindow_list_1): New functions.
7541 (window_box_text_cols): Replace with window_body_cols.
7542 (Fwindow_width, Fscroll_left, Fscroll_right):
7543 Use window_body_cols instead of window_box_text_cols.
7544 (delete_window, Fset_window_configuration):
7545 Call delete_all_subwindows with window as argument.
7546 (delete_all_subwindows): Take a window as argument and not a
7548 (window_loop): Remove handling of GET_LRU_WINDOW and
7550 (Fget_lru_window, Fget_largest_window): Move to window.el.
7552 * window.h: Extern window_body_cols instead of
7553 window_box_text_cols. delete_all_subwindows now takes a
7554 Lisp_Object as argument.
7556 * indent.c (compute_motion, Fcompute_motion):
7557 Use window_body_cols instead of window_box_text_cols.
7559 * frame.c (delete_frame): Call delete_all_subwindows with root
7562 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7564 * fns.c (Fputhash): Document return value.
7566 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7568 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7570 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7572 Cons<->int and similar integer overflow fixes (Bug#8794).
7574 Check for overflow when converting integer to cons and back.
7575 * charset.c (Fdefine_charset_internal, Fdecode_char):
7576 Use cons_to_unsigned to catch overflow.
7577 (Fencode_char): Use INTEGER_TO_CONS.
7578 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7579 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7580 * data.c (long_to_cons, cons_to_long): Remove.
7581 (cons_to_unsigned, cons_to_signed): New functions.
7582 These signal an error for invalid or out-of-range values.
7583 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7584 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7585 * font.c (Ffont_variation_glyphs):
7586 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7587 * lisp.h: Include <intprops.h>.
7588 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7589 (cons_to_signed, cons_to_unsigned): New decls.
7590 (long_to_cons, cons_to_long): Remove decls.
7591 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7592 (Fprimitive_undo): Use CONS_TO_INTEGER.
7593 * xfns.c (Fx_window_property): Likewise.
7594 * xselect.c: Include <limits.h>.
7595 (x_own_selection, selection_data_to_lisp_data):
7596 Use INTEGER_TO_CONS.
7597 (x_handle_selection_request, x_handle_selection_clear)
7598 (x_get_foreign_selection, Fx_disown_selection_internal)
7599 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7600 (lisp_data_to_selection_data): Use cons_to_unsigned.
7601 (x_fill_property_data): Use cons_to_signed.
7602 Report values out of range.
7604 Check for buffer and string overflow more precisely.
7605 * buffer.h (BUF_BYTES_MAX): New macro.
7606 * lisp.h (STRING_BYTES_MAX): New macro.
7607 * alloc.c (Fmake_string):
7608 * character.c (string_escape_byte8):
7609 * coding.c (coding_alloc_by_realloc):
7610 * doprnt.c (doprnt):
7611 * editfns.c (Fformat):
7613 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7614 since they may not be the same number.
7615 * editfns.c (Finsert_char):
7616 * fileio.c (Finsert_file_contents):
7617 Likewise for BUF_BYTES_MAX.
7619 * image.c: Use ptrdiff_t, not int, for sizes.
7620 (slurp_file): Switch from int to ptrdiff_t.
7622 (slurp_file): Check that file size fits in both size_t (for
7623 malloc) and ptrdiff_t (for sanity and safety).
7625 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7626 if b->modtime has its maximal value.
7628 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7630 Don't assume time_t can fit into int.
7631 * buffer.h (struct buffer.modtime): Now time_t, not int.
7632 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7633 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7635 Minor fixes for signed vs unsigned integers.
7636 * character.h (MAYBE_UNIFY_CHAR):
7637 * charset.c (maybe_unify_char):
7638 * keyboard.c (read_char, reorder_modifiers):
7639 XINT -> XFASTINT, since the integer must be nonnegative.
7640 * ftfont.c (ftfont_spec_pattern):
7641 * keymap.c (access_keymap, silly_event_symbol_error):
7642 XUINT -> XFASTINT, since the integer must be nonnegative.
7643 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7644 since it makes no difference and we prefer signed.
7645 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7646 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7649 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7651 * window.h (Fwindow_frame): Declare.
7653 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7655 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7656 (SPARE_MEMORY): Always define.
7657 (LARGE_REQUEST): Remove.
7658 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7660 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7662 * lisp.h: Move EXFUNS for Fframe_root_window,
7663 Fframe_first_window and Fset_frame_selected_window to window.h.
7665 * window.h: Move EXFUNS for Fframe_root_window,
7666 Fframe_first_window and Fset_frame_selected_window here from
7669 * frame.c (Fwindow_frame, Fframe_first_window)
7670 (Fframe_root_window, Fframe_selected_window)
7671 (Fset_frame_selected_window): Move to window.c.
7672 (Factive_minibuffer_window): Move to minibuf.c.
7673 (Fother_visible_frames_p): New function.
7675 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7677 * window.c (decode_window, decode_any_window): Move up in code.
7678 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7679 (inhibit_frame_unsplittable): Remove unused variable.
7680 (Fwindow_buffer): Move up and rewrite doc-string.
7681 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7682 (Fwindow_prev): New functions.
7683 (Fwindow_frame): Move here from frame.c. Accept any window as
7685 (Fframe_root_window, Fframe_first_window)
7686 (Fframe_selected_window): Move here from frame.c. Accept frame
7687 or arbitrary window as argument. Update doc-strings.
7688 (Fminibuffer_window): Move up in code.
7689 (Fwindow_minibuffer_p): Move up in code and simplify.
7690 (Fset_frame_selected_window): Move here from frame.c.
7692 (Fselected_window, select_window, Fselect_window): Move up in
7693 code. Minor doc-string fixes.
7695 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7697 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7698 Do not assume that spare memory exists; that assumption is valid
7699 only if SYSTEM_MALLOC.
7700 (LARGE_REQUEST): New macro, so that the issue of large requests
7701 is separated from the issue of spare memory.
7703 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7705 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7708 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7710 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7713 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7715 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7717 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7719 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7720 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7722 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7724 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7726 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7728 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7729 (x_clipboard_manager_save): Add return value.
7730 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7732 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7733 Obey Vx_select_enable_clipboard_manager. Catch errors in
7734 x_clipboard_manager_save (Bug#8779).
7735 (Vx_select_enable_clipboard_manager): New variable.
7736 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7738 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7740 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7742 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7744 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7745 in the current matrix if keep_current_p is non-zero.
7747 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7749 * bidi.c (bidi_level_of_next_char): Fix last change.
7751 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7753 Support bidi reordering of text covered by display properties.
7755 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7756 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7757 (bidi_cache_search, bidi_cache_iterator_state)
7758 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7759 (bidi_level_of_next_char, bidi_move_to_visually_next):
7760 Support character positions inside a run of characters covered by a
7762 (bidi_paragraph_init, bidi_resolve_explicit_1)
7763 (bidi_level_of_next_char): Call bidi_fetch_char and
7764 bidi_fetch_char_advance instead of FETCH_CHAR and
7766 (bidi_init_it): Initialize new members.
7767 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7769 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7770 instead of using explicit *_CHAR codes.
7771 (bidi_resolve_explicit, bidi_resolve_weak):
7772 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7773 bidirectional text is supported only in multibyte buffers.
7774 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7775 it to initialize the frame_window_p member of struct bidi_it.
7776 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7777 (bidi_resolve_explicit, bidi_resolve_weak)
7778 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7779 bidi_it->nchars is non-positive.
7780 (bidi_level_of_next_char): Don't try to lookup the cache for the
7781 next/previous character if nothing is cached there yet, or if we
7782 were just reseat()'ed to a new position.
7784 * xdisp.c (set_cursor_from_row): Set start and stop points
7785 according to the row's direction when priming the loop that looks
7786 for the glyph on which to display cursor.
7787 (single_display_spec_intangible_p): Function deleted.
7788 (display_prop_intangible_p): Reimplement to call
7789 handle_display_spec instead of single_display_spec_intangible_p.
7790 Accept 3 additional arguments needed by handle_display_spec.
7791 This fixes incorrect cursor motion across display property with complex
7792 values: lists, `(when COND...)' forms, etc.
7793 (single_display_spec_string_p): Support property values that are
7794 lists with the argument STRING its top-level element.
7795 (display_prop_string_p): Fix the condition for processing a
7796 property that is a list to be consistent with handle_display_spec.
7797 (handle_display_spec): New function, refactored from the
7798 last portion of handle_display_prop.
7799 (compute_display_string_pos): Accept additional argument
7800 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7801 value of a `display' property is a "replacing spec".
7802 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7803 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7804 the display property, but just return a value indicating whether
7805 the display property will replace the characters it covers.
7806 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7807 frame_window_p members of struct bidi_it.
7808 (compute_display_string_pos, compute_display_string_end):
7810 (push_it): Accept second argument POSITION, where pop_it should
7811 jump to continue iteration.
7812 (reseat_1): Initialize bidi_it.disp_pos.
7814 * keyboard.c (adjust_point_for_property): Adjust the call to
7815 display_prop_intangible_p to its new signature.
7817 * dispextern.h (struct bidi_it): New member frame_window_p.
7818 (bidi_init_it): Update prototypes.
7819 (display_prop_intangible_p): Update prototype.
7820 (compute_display_string_pos, compute_display_string_end):
7822 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7825 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7827 Malloc failure behavior now depends on size of allocation.
7828 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7829 * lisp.h: Change signatures accordingly.
7830 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7831 All callers changed. (Bug#8762)
7833 * gnutls.c: Use Emacs's memory allocators.
7834 Without this change, the gnutls library would invoke malloc etc.
7835 directly, which causes problems on non-SYNC_INPUT hosts, and which
7836 runs afoul of improving memory_full behavior. (Bug#8761)
7837 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7838 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7839 xfree instead of the default malloc, realloc, free.
7840 (Fgnutls_boot): No need to check for memory allocation failure,
7841 since xmalloc does that for us.
7843 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7844 * category.c (hash_get_category_set):
7845 * ccl.c (ccl_driver):
7846 * charset.c (Fdefine_charset_internal):
7847 * charset.h (struct charset.hash_index):
7848 * composite.c (get_composition_id, gstring_lookup_cache)
7849 (composition_gstring_put_cache):
7850 * composite.h (struct composition.hash_index):
7851 * dispextern.h (struct image.hash):
7852 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7853 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7854 (hashfn_equal, hashfn_user_defined, make_hash_table)
7855 (maybe_resize_hash_table, hash_lookup, hash_put)
7856 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7857 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7858 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7859 * image.c (make_image, search_image_cache, lookup_image)
7860 (xpm_put_color_table_h):
7861 * lisp.h (struct Lisp_Hash_Table):
7862 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7863 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7864 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7865 * alloc.c (allocate_vectorlike):
7866 Check for overflow in vector size calculations.
7867 * ccl.c (ccl_driver):
7868 Check for overflow when converting EMACS_INT to int.
7869 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7870 need to be updated by these changes.
7871 * fns.c (make_hash_table, maybe_resize_hash_table):
7872 Check for integer overflow with large hash tables.
7873 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7874 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7875 (SXHASH_REDUCE): New macro.
7876 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7877 Use it instead of discarding useful hash info with large hash values.
7878 (sxhash_float): New function.
7879 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7880 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7881 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7882 Rewrite to use FIXNUM_BITS, as this simplifies things.
7883 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7884 Adjust signatures to match updated version of code.
7885 (consing_since_gc): Now EMACS_INT, since a single hash table can
7886 use more than INT_MAX bytes.
7888 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7890 Make it possible to build with GCC-4.6+ -O2 -flto.
7892 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7894 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7896 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7897 Call minibuffer-inactive-mode.
7899 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7901 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7902 Update dependencies.
7904 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7906 * data.c (init_data): Remove code for UTS, this system is not
7909 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7911 Don't force ./temacs to start in terminal mode.
7913 * frame.c (make_initial_frame): Initialize faces in all cases, not
7914 only when CANNOT_DUMP is defined.
7915 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7917 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7919 * dispnew.c (add_window_display_history): Use const for the string
7920 pointer. Remove declaration, not needed.
7922 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7924 Use 'inline', not 'INLINE'.
7925 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7926 * alloc.c, fontset.c (INLINE): Remove.
7927 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7928 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7929 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7930 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7931 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7933 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7935 Make it possible to run ./temacs.
7937 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7938 syms_of_callproc does the same thing. Remove test for
7939 "initialized", do it in the caller.
7940 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7942 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7944 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7945 (read_minibuf): Use get_minibuffer.
7946 (syms_of_minibuf): Use DEFSYM.
7947 (Qmetadata): New var.
7948 * data.c (Qbuffer): Don't make it static.
7949 (syms_of_data): Use DEFSYM.
7951 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7953 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7954 (CCL_CODE_MIN): New macro.
7956 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7958 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7960 * eval.c (Qdebug): Now static.
7961 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7962 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7963 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7965 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7967 * image.c: Various fixes to ImageMagick code comments.
7968 (Fimagemagick_types): Doc fix.
7970 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7972 Minor fixes prompted by GCC 4.6.0 warnings.
7974 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7976 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7977 (x_clipboard_manager_save_all): Move extern decl to ...
7978 * xterm.h: ... here, so that it can be checked for consistency.
7980 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7982 * xselect.c (x_clipboard_manager_save_frame)
7983 (x_clipboard_manager_save_all): New functions.
7984 (Fx_clipboard_manager_save): Lisp function deleted.
7986 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7987 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7989 * xterm.h: Update prototype.
7991 2011-05-28 William Xu <william.xwl@gmail.com>
7993 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7996 2011-05-28 Jim Meyering <meyering@redhat.com>
7998 Avoid a sign-extension bug in crypto_hash_function.
7999 * fns.c (to_uchar): Define.
8000 (crypto_hash_function): Use it to convert some newly-signed
8001 variables to unsigned, to avoid sign-extension bugs. For example,
8002 without this change, (md5 "truc") would evaluate to
8003 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8004 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8005 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8007 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8009 Integer overflow fixes.
8011 * dbusbind.c: Serial number integer overflow fixes.
8012 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8013 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8014 to hold a serial number that is too large for a fixnum.
8015 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8016 Check for serial numbers out of range. Decode any serial number
8017 that was so large that it became a float. (Bug#8722)
8019 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8020 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8021 Use XFASTINT rather than XUINT when numbers are nonnegative.
8022 (xd_append_arg, Fdbus_method_return_internal):
8023 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8024 arguments, check that Lisp number is nonnegative, rather than
8025 silently wrapping negative numbers around. (Bug#8722)
8026 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8029 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8031 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8033 ccl: Add integer overflow checks.
8034 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8035 (IN_INT_RANGE): New macros.
8036 (ccl_driver): Use them to check for integer overflow when
8037 decoding a CCL program. Many of the new checks are whether XINT (x)
8038 fits in int; it doesn't always, on 64-bit hosts. The new version
8039 doesn't catch all possible integer overflows, but it's an
8040 improvement. (Bug#8719)
8042 * alloc.c (make_event_array): Use XINT, not XUINT.
8043 There's no need for unsigned here.
8045 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8046 This follows up to the 2011-05-06 change that substituted uintptr_t
8047 for EMACS_INT. This case wasn't caught back then.
8049 Rework Fformat to avoid integer overflow issues.
8050 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8051 now (part of C89). Include <verify.h>.
8052 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8053 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8054 (Fformat): Avoid the prepass trying to compute sizes; it was only
8055 approximate and thus did not catch overflow reliably. Instead, walk
8056 through the format just once, formatting and computing sizes as we go,
8057 checking for integer overflow at every step, and allocating a larger
8058 buffer as needed. Keep track separately whether the format is
8059 multibyte. Keep only the most-recently calculated precision, rather
8060 than them all. Record whether each argument has been converted to
8061 string. Use EMACS_INT, not int, for byte and char and arg counts.
8062 Support field widths and precisions larger than INT_MAX. Avoid
8063 sprintf's undefined behavior with conversion specifications such as %#d
8064 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8065 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8066 formatting out-of-range floating point numbers with int
8069 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8071 * data.c: Avoid integer truncation in expressions involving floats.
8072 * data.c: Include <intprops.h>.
8073 (arith_driver): When there's an integer overflow in an expression
8074 involving floating point, convert the integers to floating point
8075 so that the resulting value does not suffer from catastrophic
8076 integer truncation. For example, on a 64-bit host (* 4
8077 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8078 Do not rely on undefined behavior after integer overflow.
8080 merge count_size_as_multibyte, parse_str_to_multibyte
8081 * character.c, character.h (count_size_as_multibyte):
8082 Rename from parse_str_to_multibyte; all uses changed.
8083 Check for integer overflow.
8084 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8085 since it's now a duplicate of the other. This is more of
8086 a character than a buffer op, so better that it's in character.c.
8087 * fns.c, print.c: Adjust to above changes.
8089 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8091 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8093 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8095 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8096 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8097 (x_clipboard_manager_save): Now static.
8098 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8100 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8101 (crypto_hash_function): Now static.
8102 Fix pointer signedness problems. Avoid unnecessary initializations.
8104 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8106 * termhooks.h (Vselection_alist): Make it terminal-local.
8108 * terminal.c (create_terminal): Initialize it.
8110 * xselect.c: Support for clipboard managers.
8111 (Vselection_alist): Move to termhooks.h as terminal-local var.
8112 (LOCAL_SELECTION): New macro.
8113 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8114 (symbol_to_x_atom): Remove gratuitous arg.
8115 (x_handle_selection_request, lisp_data_to_selection_data)
8116 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8117 (x_own_selection, x_get_local_selection, x_convert_selection):
8118 New arg, specifying work frame. Use terminal-local Vselection_alist.
8119 (some_frame_on_display): Delete unused function.
8120 (Fx_own_selection_internal, Fx_get_selection_internal)
8121 (Fx_disown_selection_internal, Fx_selection_owner_p)
8122 (Fx_selection_exists_p): New optional frame arg.
8123 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8124 (x_handle_selection_clear): Don't treat other terminals with the
8125 same keyboard specially. Use the terminal-local Vselection_alist.
8126 (x_clear_frame_selections): Use Frun_hook_with_args.
8128 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8130 * xterm.h: Add support for those atoms.
8132 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8134 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8135 (converted_selections, conversion_fail_tag): New global variables.
8136 (x_selection_request_lisp_error): Free the above.
8137 (x_get_local_selection): Remove unnecessary code.
8138 (x_reply_selection_request): Args changed; handle arbitrary array
8139 of converted selections stored in converted_selections.
8140 Separate the XChangeProperty and SelectionNotify steps.
8141 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8142 (x_convert_selection): New function.
8143 (x_handle_selection_event): Simplify.
8144 (x_get_foreign_selection): Don't ignore incoming requests while
8145 waiting for an answer; this will fail when we implement
8146 SAVE_TARGETS, and seems unnecessary anyway.
8147 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8148 (Vx_sent_selection_functions): Doc fix.
8150 2011-05-26 Leo Liu <sdl.web@gmail.com>
8152 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8154 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8156 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8158 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8159 for fringe update if it has periodic bitmap.
8160 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8161 and fringe_bitmap_periodic_p.
8163 * fringe.c (get_fringe_bitmap_data): New function.
8164 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8165 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8166 row. Mark glyph row for fringe update if periodicity changed.
8168 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8169 for fringe update unless it has periodic bitmap.
8171 2011-05-25 Kenichi Handa <handa@m17n.org>
8173 * xdisp.c (get_next_display_element): Set correct it->face_id for
8174 a static composition.
8176 2011-05-24 Leo Liu <sdl.web@gmail.com>
8179 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8181 * fns.c (crypto_hash_function, Fsha1): New function.
8182 (Fmd5): Use crypto_hash_function.
8183 (syms_of_fns): Add Ssha1.
8185 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8187 * gnutls.c: Remove unused macros.
8188 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8189 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8190 Remove macros that are defined and never used.
8191 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8193 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8195 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8196 (Fx_get_selection_internal): Minor cleanup.
8197 (Fx_own_selection_internal): Rename arguments for consistency with
8200 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8202 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8204 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8206 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8208 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8210 * dispnew.c (scrolling_window): Don't exclude the case that the
8211 last enabled row in the desired matrix touches the bottom boundary.
8213 2011-05-21 Glenn Morris <rgm@gnu.org>
8215 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8216 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8217 and add some more files.
8219 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8221 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8222 report_file_error introduced by the change from 2011-05-07.
8224 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8226 * systime.h (Time): Define only if emacs is defined.
8227 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8228 where the include path doesn't have X11/X.h by default. See
8229 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8231 2011-05-20 Kenichi Handa <handa@m17n.org>
8233 * composite.c (find_automatic_composition): Fix previous change.
8235 2011-05-20 Glenn Morris <rgm@gnu.org>
8237 * lisp.mk: New file, split from Makefile.in.
8238 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8239 (shortlisp): Remove.
8240 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8242 2011-05-19 Glenn Morris <rgm@gnu.org>
8244 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8245 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8246 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8247 (lisp): Set the order to that of loadup.el.
8248 (shortlisp): Make it a copy of $lisp.
8249 (SOME_MACHINE_LISP): Remove.
8250 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8251 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8253 2011-05-18 Kenichi Handa <handa@m17n.org>
8255 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8256 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8257 (find_automatic_composition): Mostly rewrite for efficiency.
8259 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8261 * makefile.w32-in: Update dependencies.
8263 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8265 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8266 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8268 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8270 Fix some integer overflow issues, such as string length overflow.
8272 * insdel.c (count_size_as_multibyte): Check for string overflow.
8274 * character.c (lisp_string_width): Check for string overflow.
8275 Use EMACS_INT, not int, for string indexes and lengths; in
8276 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8277 the resulting string length overflows an EMACS_INT; instead,
8278 report a string overflow if no precision given. When checking for
8279 precision exhaustion, use a check that cannot possibly have
8280 integer overflow. (Bug#8675)
8281 * character.h (lisp_string_width): Adjust to new signature.
8283 * alloc.c (string_overflow): New function.
8284 (Fmake_string): Use it. This doesn't change behavior, but saves
8285 a few bytes and will simplify future changes.
8286 * character.c (string_escape_byte8): Likewise.
8287 * lisp.h (string_overflow): New decl.
8289 Fixups, following up to the user-interface timestamp change.
8290 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8291 for UI timestamps, instead of unsigned long.
8292 * msdos.c (mouse_get_pos): Likewise.
8293 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8294 * w32gui.h (Time): Define by including "systime.h" rather than by
8295 declaring it ourselves. (Bug#8664)
8297 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8298 * image.c (clear_image_cache): Likewise.
8300 * term.c (term_mouse_position): Don't assume time_t wraparound.
8302 Be more systematic about user-interface timestamps.
8303 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8304 and sometimes 'EMACS_UINT', to represent these timestamps.
8305 This change causes it to use 'Time' uniformly, as that's what X uses.
8306 This makes the code easier to follow, and makes it easier to catch
8307 integer overflow bugs such as Bug#8664.
8308 * frame.c (Fmouse_position, Fmouse_pixel_position):
8309 Use Time, not unsigned long, for user-interface timestamps.
8310 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8311 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8312 * keyboard.h (last_event_timestamp): Likewise.
8313 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8314 * menu.h (xmenu_show): Likewise.
8315 * term.c (term_mouse_position): Likewise.
8316 * termhooks.h (struct input_event.timestamp): Likewise.
8317 (struct terminal.mouse_position_hook): Likewise.
8318 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8319 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8320 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8321 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8323 * menu.h, termhooks.h: Include "systime.h", for Time.
8325 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8326 Don't assume that the difference between two unsigned long values
8327 can fit into an integer. At this point, we know button_down_time
8328 <= event->timestamp, so the difference must be nonnegative, so
8329 there's no need to cast the result if double-click-time is
8330 nonnegative, as it should be; check that it's nonnegative, just in
8331 case. This bug is triggered when events are more than 2**31 ms
8332 apart (about 25 days). (Bug#8664)
8334 * xselect.c (last_event_timestamp): Remove duplicate decl.
8335 (x_own_selection): Remove needless cast to unsigned long.
8337 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8338 that always fit in int. Use a sentinel instead of a counter, to
8339 avoid a temp and to allay GCC's concerns about possible int overflow.
8340 * frame.h (struct frame): Use int for menu_bar_items_used
8341 instead of EMACS_INT, since it always fits in int.
8343 * menu.c (grow_menu_items): Check for int overflow.
8345 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8347 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8348 Before, the code was not consistent. These values cannot exceed
8349 2**31 - 1 so there's no need to make them unsigned.
8350 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8351 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8352 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8354 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8356 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8357 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8358 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8359 presumably because the widths might not match.
8361 * window.c (size_window): Avoid needless test at loop start.
8363 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8365 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8367 2011-05-12 Drew Adams <drew.adams@oracle.com>
8369 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8371 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8373 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8374 `width' to `bar_area_x' and `bar_area_width', respectively.
8375 (x_scroll_run): Take account of fringe background extension.
8377 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8378 Rename local vars `left' and `width' to `bar_area_x' and
8379 `bar_area_width', respectively.
8380 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8381 background extension.
8383 2011-05-10 Jim Meyering <meyering@redhat.com>
8385 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8387 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8389 * image.c (Finit_image_library): Return t for built-in image types,
8390 like pbm and xbm. (Bug#8640)
8392 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8394 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8396 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8398 * w32console.c (Fset_screen_color): Doc fix.
8399 (Fget_screen_color): New function.
8400 (syms_of_ntterm): Defsubr it.
8402 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8403 unlink the temporary file if Fcall_process didn't create it in the
8405 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8406 child process will be redirected to a file specified with `:file'.
8407 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8408 cue to call_process_cleanup not to close that handle.
8410 2011-05-07 Ben Key <bkey76@gmail.com>
8412 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8413 one of two shell specific rules, either bootstrap-temacs-CMD or
8414 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8415 to the previous implementation of the bootstrap-temacs rule.
8416 The bootstrap-temacs-CMD rule is similar to the previous
8417 implementation of the bootstrap-temacs rule except that it
8418 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8421 These changes, along with some changes to nt/configure.bat,
8422 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8423 earlier fix to add support for --cflags and --ldflags options
8424 that include quotes so that it works whether make uses cmd or
8427 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8429 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8430 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8432 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8433 a string. Handle both cases.
8434 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8435 (Fdbus_register_method): Use Qinvalid_function.
8437 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8439 * makefile.w32-in: Update dependencies.
8440 (LISP_H): Add inttypes.h and stdin.h.
8441 (PROCESS_H): Add unistd.h.
8443 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8445 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8446 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8448 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8450 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8452 * term.c (vfatal): Remove stray call to va_end.
8453 It's not needed and the C Standard doesn't allow it here anyway.
8455 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8456 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8458 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8461 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8463 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8465 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8467 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8469 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8471 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8472 * charset.c (Fdefine_charset_internal): Don't initialize
8473 charset.code_space[15]. The value was garbage, on hosts with
8474 32-bit int (Bug#8600).
8476 * lread.c (read_integer): Be more consistent with string-to-number.
8477 Use string_to_number to do the actual conversion; this avoids
8478 rounding errors and fixes some other screwups. Without this fix,
8479 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8480 (digit_to_number): Move earlier, for benefit of read_integer.
8481 Return -1 if the digit is out of range for the base, -2 if it is
8482 not a digit in any supported base. (Bug#8602)
8484 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8486 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8487 to match comment at start of function. This also removes a
8488 GCC warning about overflow in a 32+64-bit port.
8490 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8492 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8493 Reported by Stefan Monnier in
8494 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8495 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8496 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8498 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8499 (EMACS_UINTPTR): Likewise, with uintptr_t.
8501 * lisp.h: Prefer 64-bit EMACS_INT if available.
8502 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8503 on 32-bit hosts that have 64-bit int, so that they can access
8505 However, temporarily disable this change unless the temporary
8506 symbol WIDE_EMACS_INT is defined.
8508 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8510 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8511 This removes an assumption that EMACS_INT and long are the same
8512 width as pointers. The assumption is true for Emacs porting targets
8513 now, but we want to make other targets possible.
8514 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8515 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8516 In the rest of the code, change types of integers that hold casted
8517 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8518 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8519 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8520 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8521 No need to cast type when ORing.
8522 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8523 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8524 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8525 assume EMACS_INT is the same width as char *.
8526 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8527 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8528 Remove no-longer-needed casts.
8529 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8530 (xg_tool_bar_help_callback, xg_make_tool_item):
8531 Use EMACS_INTPTR to hold an integer
8532 that will be cast to void *; this can avoid a GCC warning
8533 if EMACS_INT is not the same width as void *.
8534 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8535 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8536 (current_message_1, set_message_1):
8537 Use a local to convert to proper width without a cast.
8538 * xmenu.c (dialog_selection_callback): Likewise.
8540 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8541 Also, don't assume VALBITS / RAND_BITS is less than 5,
8542 and don't rely on undefined behavior when shifting a 1 left into
8544 * lisp.h (get_random): Change signature to match.
8546 * lread.c (hash_string): Use size_t, not int, for hash computation.
8547 Normally we prefer signed values; but hashing is special, because
8548 it's better to use unsigned division on hash table sizes so that
8549 the remainder is nonnegative. Also, size_t is the natural width
8550 for hashing into memory. The previous code used 'int', which doesn't
8551 retain enough info to hash well into very large tables.
8552 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8554 * dbusbind.c: Don't possibly lose pointer info when converting.
8555 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8556 Use XPNTR rather than XHASH, so that the high-order bits of
8557 the pointer aren't lost when converting through void *.
8559 * eval.c (Fautoload): Don't double-shift a pointer.
8561 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8563 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8565 * gnutls.c (DEF_GNUTLS_FN):
8566 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8568 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8570 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8573 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8575 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8576 New version that can reserve upto 2GB of heap space.
8578 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8580 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8582 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8584 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8585 `gnutls_certificate_set_x509_key_file'.
8587 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8589 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8590 Update dependencies.
8592 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8594 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8595 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8596 Remove unused parameter `fildes'.
8597 * process.c (read_process_output, send_process): Don't pass it.
8599 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8601 Fix previous change: the library cache is defined in w32.c.
8602 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8603 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8605 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8607 Implement dynamic loading of GnuTLS on Windows.
8609 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8610 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8611 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8614 * gnutls.c (Qgnutls_dll): Define.
8615 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8616 (gnutls_*): Declare function pointers.
8617 (init_gnutls_functions): New function to initialize function pointers.
8618 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8619 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8620 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8621 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8622 (emacs_gnutls_write, emacs_gnutls_read)
8623 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8624 (Fgnutls_available_p): New function.
8625 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8626 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8627 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8629 * image.c: Include w32.h.
8630 (Vimage_type_cache): Delete.
8631 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8632 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8633 (w32_delayed_load): Move to w32.c.
8635 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8637 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8638 (w32_delayed_load): Move from image.c. When loading a library, record
8639 its filename in the :loaded-from property of the library id.
8640 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8641 Initialize and staticpro them.
8642 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8644 * process.c: Include lisp.h before w32.h, not after.
8645 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8646 instead of gnutls_record_check_pending.
8648 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8650 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8652 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8653 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8656 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8658 * xterm.c (x_set_frame_alpha): Do not set property on anything
8659 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8661 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8663 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8665 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8667 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8668 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8669 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8670 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8671 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8672 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8673 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8674 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8675 (Qgnutls_bootprop_callbacks_verify): Make static.
8677 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8679 * callproc.c: Indentation fixup.
8681 * sysdep.c (wait_for_termination_1): Make static.
8682 (wait_for_termination, interruptible_wait_for_termination):
8683 Move after wait_for_termination_1.
8685 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8687 * sysdep.c (interruptible_wait_for_termination): New function
8688 which is like wait_for_termination, but allows keyboard
8691 * callproc.c (Fcall_process): Add (:file "file") as an option for
8693 (Fcall_process_region): Ditto.
8695 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8697 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8698 rather than `XVECTOR (FOO)->size'.
8700 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8701 inttypes.h, as a gnulib replacement is used if it not available in
8704 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8706 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8707 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8708 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8710 * coding.c (coding_alloc_by_realloc): Error out if destination
8711 will grow beyond MOST_POSITIVE_FIXNUM.
8712 (decode_coding_emacs_mule): Abort if there isn't enough place in
8713 charbuf for the composition carryover bytes. Reserve an extra
8714 space for up to 2 characters produced in a loop.
8715 (decode_coding_iso_2022): Abort if there isn't enough place in
8716 charbuf for the composition carryover bytes.
8718 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8720 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8721 aborting when %lld or %lll format is passed.
8722 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8723 %llo or %llx format is passed. (Bug#8545)
8725 * window.c (window_scroll_line_based): Use a marker instead of
8726 simple variables to record original value of point. (Bug#7952)
8728 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8729 produced by %s or %c overflows available buffer space. (Bug#8545)
8731 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8733 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8734 (SIZE_MAX): Move defn after all includes, as they might #define it.
8736 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8738 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8740 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8742 * keyboard.c (Qdelayed_warnings_hook): Define.
8743 (command_loop_1): Run `delayed-warnings-hook'
8744 if Vdelayed_warnings_list is non-nil.
8745 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8746 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8748 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8750 * doprnt.c (doprnt): Don't return value smaller than the buffer
8751 size if the message was truncated. (Bug#8545).
8753 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8755 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8756 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8758 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8760 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8762 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8764 * makefile.w32-in: Update dependencies.
8766 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8768 Improve `doprnt' and its usage. (Bug#8545)
8769 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8770 `format_end'. Remove support for %l as a conversion specifier.
8771 Don't use xrealloc. Improve diagnostics when the %l size modifier
8772 is used. Update the commentary.
8774 * eval.c (verror): Simplify calculation of size_t.
8776 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8779 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8781 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8784 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8786 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8787 This makes this file independent of the recent pseudovector change.
8789 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8791 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8793 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8794 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8795 Remove unused local.
8796 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8798 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8799 GCC 4.6.0 optimizes based on type-based alias analysis.
8800 For example, if b is of type struct buffer * and v of type struct
8801 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8802 != &v->size, and therefore "v->size = 1; b->size = 2; return
8803 v->size;" must therefore return 1. This assumption is incorrect
8804 for Emacs, since it type-puns struct Lisp_Vector * with many other
8805 types. To fix this problem, this patch adds a new type struct
8806 vectorlike_header that documents the constraints on layout of vectors
8807 and pseudovectors, and helps optimizing compilers not get fooled
8808 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8809 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8810 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8812 (XSETPVECTYPE): Rewrite in terms of new macro.
8813 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8814 This is a bit clearer, and further avoids the possibility of
8815 undesirable aliasing.
8816 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8817 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8818 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8819 since Lisp_Subr is a special case (no "next" field).
8820 (ASIZE): Now uses header.size rather than size.
8821 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8822 to avoid the hassle of writing XVECTOR (foo)->header.size.
8823 (struct vectorlike_header): New type.
8824 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8825 object, to help avoid aliasing.
8826 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8827 (SUBRP): Likewise, since Lisp_Subr is a special case.
8828 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8829 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8830 (struct Lisp_Hash_Table): Combine first two members into a single
8831 struct vectorlike_header member. All uses of "size" and "next" members
8832 changed to be "header.size" and "header.next".
8833 * buffer.h (struct buffer): Likewise.
8834 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8835 * frame.h (struct frame): Likewise.
8836 * process.h (struct Lisp_Process): Likewise.
8837 * termhooks.h (struct terminal): Likewise.
8838 * window.c (struct save_window_data, struct saved_window): Likewise.
8839 * window.h (struct window): Likewise.
8840 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8841 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8842 * buffer.c (init_buffer_once): Likewise.
8843 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8845 * process.c (Fformat_network_address): Use local var for size,
8848 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8850 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8851 * data.c (atof): Remove decl; no longer used or needed.
8852 (digit_to_number): Move to lread.c.
8853 (Fstring_to_number): Use new string_to_number function, to be
8854 consistent with how the Lisp reader treats infinities and NaNs.
8855 Do not assume that floating-point numbers represent EMACS_INT
8856 without losing information; this is not true on most 64-bit hosts.
8857 Avoid double-rounding errors, by insisting on integers when
8858 parsing non-base-10 numbers, as the documentation specifies.
8859 * lisp.h (string_to_number): New decl, replacing ...
8860 (isfloat_string): Remove.
8861 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8862 (read1): Do not accept +. and -. as integers; this
8863 appears to have been a coding error. Similarly, do not accept
8864 strings like +-1e0 as floating point numbers. Do not report
8865 overflow for integer overflows unless the base is not 10 which
8866 means we have no simple and reliable way to continue.
8867 Break out the floating-point parsing into a new
8868 function string_to_number, so that Fstring_to_number parses
8869 floating point numbers consistently with the Lisp reader.
8870 (digit_to_number): Move here from data.c. Make it static inline.
8871 (E_CHAR, EXP_INT): Remove, replacing with ...
8872 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8873 (string_to_number): New function, replacing isfloat_string.
8874 This function checks for valid syntax and produces the resulting
8875 Lisp float number too. Rework it so that string-to-number
8876 no longer mishandles examples like "1.0e+". Use strtoumax,
8877 so that overflow for non-base-10 numbers is reported only when
8878 there's no portable and simple way to convert to floating point.
8880 * textprop.c (set_text_properties_1): Rewrite for clarity,
8881 and to avoid GCC warning about integer overflow.
8883 * intervals.h (struct interval): Use EMACS_INT for members
8884 where EMACS_UINT might cause problems. See
8885 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8886 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8887 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8889 (offset_intervals): Tell GCC not to worry about length overflow
8890 when negating a negative length.
8892 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8893 (overrun_check_free): Likewise.
8895 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8896 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8899 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8900 (gnutls_make_error): Rename local to avoid shadowing.
8901 (gnutls_emacs_global_deinit): ifdef out; not used.
8902 (Fgnutls_boot): Use const for pointer to readonly storage.
8903 Comment out unused local. Fix pointer signedness problems.
8905 * lread.c (openp): Don't stuff size_t into an 'int'.
8906 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8907 about possible signed overflow.
8909 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8910 (GDK_KEY_g): Don't define if already defined.
8911 (xg_prepare_tooltip): Avoid pointer signedness problem.
8912 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8914 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8915 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8917 * xfns.c (Fx_window_property): Simplify a bit,
8918 to make a bit faster and to avoid GCC 4.6.0 warning.
8919 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8921 * fns.c (internal_equal): Don't assume size_t fits in int.
8923 * alloc.c (compact_small_strings): Tighten assertion a little.
8925 Replace pEd with more-general pI, and fix some printf arg casts.
8926 * lisp.h (pI): New macro, generalizing old pEd macro to other
8927 conversion specifiers. For example, use "...%"pI"d..." rather
8928 than "...%"pEd"...".
8929 (pEd): Remove. All uses replaced with similar uses of pI.
8930 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8931 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8932 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8933 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8934 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8935 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8936 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8938 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8939 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8940 * print.c (safe_debug_print, print_object): Likewise.
8941 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8943 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8944 avoiding the 0 flag, which is not portable.
8945 * process.c (Fmake_network_process): Use pI to avoid cast.
8946 * region-cache.c (pp_cache): Likewise.
8947 * xdisp.c (decode_mode_spec): Likewise.
8948 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8949 behavior on 64-bit hosts with printf arg.
8950 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8951 (x_stop_queuing_selection_requests): Likewise.
8952 (x_get_window_property): Don't truncate byte count to an 'int'
8955 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8956 here, since it parses constructs like leading '-' and spaces,
8957 which are not wanted; and it overflows with large numbers.
8958 Instead, simply match F[0-9]+, which is what is wanted anyway.
8960 * alloc.c: Remove unportable assumptions about struct layout.
8961 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8962 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8963 (allocate_vectorlike, make_pure_vector): Use the new macros,
8964 plus offsetof, to remove unportable assumptions about struct layout.
8965 These assumptions hold on all porting targets that I know of, but
8966 they are not guaranteed, they're easy to remove, and removing them
8967 makes further changes easier.
8969 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8970 This doesn't fix a bug but makes the code clearer.
8971 (string_overrun_cookie): Now const. Use initializers that
8972 don't formally overflow signed char, to avoid warnings.
8973 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8974 can cause Emacs to crash when string overrun checking is enabled.
8975 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8976 multiple of sizeof (EMACS_INT); it need not be, if
8977 alignof(EMACS_INT) < sizeof (EMACS_INT).
8978 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8980 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8982 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8984 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8986 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8987 supposed to be handshaking. (Bug#8556)
8988 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8990 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8992 * lisp.h (Qdebug): List symbol.
8993 * eval.c (Qdebug): Restore global linkage.
8994 * keyboard.c (debug-on-event): New variable.
8995 (handle_user_signal): Break into debugger when debug-on-event
8996 matches the current signal symbol.
8998 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9000 * alloc.c (check_sblock, check_string_bytes)
9001 (check_string_free_list): Convert to standard C.
9003 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9005 * w32.c (emacs_gnutls_push): Fix typo.
9007 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9009 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9010 "cast to pointer from integer of different size".
9012 Improve doprnt and its use in verror. (Bug#8545)
9013 * doprnt.c (doprnt): Document the set of format control sequences
9014 supported by the function. Use SAFE_ALLOCA instead of always
9017 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9018 is one byte too soon. Don't use xrealloc; instead xfree and
9021 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9023 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9026 * gnutls.c: Renamed global_initialized to
9027 gnutls_global_initialized. Added internals for the
9028 :verify-hostname-error, :verify-error, and :verify-flags
9029 parameters of `gnutls-boot' and documented those parameters in the
9030 docstring. Start callback support.
9031 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9032 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9033 on error. Return error code.
9034 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9035 (emacs_gnutls_read): Likewise.
9036 (Fgnutls_boot): Return handshake error code.
9037 (emacs_gnutls_handle_error): New function.
9038 (wsaerror_to_errno): Likewise.
9040 * w32.h (emacs_gnutls_pull): Add prototype.
9041 (emacs_gnutls_push): Likewise.
9043 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9044 (emacs_gnutls_push): Likewise.
9046 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9048 * process.c (wait_reading_process_output): Check if GnuTLS
9049 buffered some data internally if no FDs are set for TLS
9052 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9053 (LIBS): Link to USER_LIBS.
9054 ($(BLD)/gnutls.$(0)): New target.
9056 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9058 * xdisp.c (handle_single_display_spec): Rename the
9059 display_replaced_before_p argument into display_replaced_p, to
9060 make it consistent with the commentary. Fix typos in the
9063 * textprop.c (syms_of_textprop): Remove dead code.
9064 (copy_text_properties): Delete obsolete commentary about an
9065 interface that was deleted long ago. Fix typos in the description
9068 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9069 to changes in oldXMenu/XMenu.h from 2011-04-16.
9070 <menu_help_message, prev_menu_help_message>: Constify.
9071 (IT_menu_make_room): menu->help_text is now `const char **';
9074 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9075 to changes in oldXMenu/XMenu.h from 2011-04-16.
9076 (struct XMenu): Declare `help_text' `const char **'.
9078 * xfaces.c <Qunspecified>: Make extern again.
9080 * syntax.c: Include sys/types.h before including regex.h, as
9083 * doc.c (get_doc_string): Improve the format passed to `error'.
9085 * doprnt.c (doprnt): Improve commentary.
9087 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9089 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9092 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9093 changes in globals.h immediately force recompilation.
9094 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9095 $(CURDIR)/s/ms-w32.h.
9096 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9098 * character.c (Fchar_direction): Function deleted.
9099 (syms_of_character): Don't defsubr it.
9100 <char-direction-table>: Deleted.
9102 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9104 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9105 * doprnt.c: Include limits.h.
9106 (SIZE_MAX): New macro.
9107 (doprnt): Return a size_t value. 2nd arg is now size_t.
9108 Many local variables are now size_t instead of int or unsigned.
9109 Improve overflow protection. Support `l' modifier for integer
9110 conversions. Support %l conversion. Don't assume an EMACS_INT
9111 argument for integer conversions and for %c.
9113 * lisp.h (doprnt): Restore prototype.
9115 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9118 * Makefile.in (base_obj): Add back doprnt.o.
9120 * deps.mk (doprnt.o): Add back prerequisites.
9121 (callint.o): Depend on character.h.
9123 * eval.c (internal_lisp_condition_case): Include the handler
9124 representation in the error message.
9125 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9126 when breaking from the loop.
9128 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9130 * callint.c (Fcall_interactively): When displaying error message
9131 about invalid control letter, pass the character's codepoint, not
9132 a pointer to its multibyte form. Improve display of the character
9133 in octal and display also its hex code.
9135 * character.c (char_string): Use %x to display the (unsigned)
9136 codepoint of an invalid character, to avoid displaying a bogus
9139 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9140 `error', not SYMBOL_NAME itself.
9142 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9143 character arguments to `error'.
9145 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9146 to `error' in error message about FINAL_CHAR argument. Make sure
9147 FINAL_CHAR is a character, and use %c when it is passed as
9148 argument to `error'.
9150 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9152 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9154 * w32.c: Include <time.h>.
9155 (sys_localtime): New function.
9157 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9159 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9161 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9163 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9165 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9168 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9170 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9171 gl_state.e_property when gl_state.object is Qt.
9173 * insdel.c (make_gap_larger): Remove limitation of buffer size
9176 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9178 * xdisp.c (lookup_glyphless_char_display)
9179 (produce_glyphless_glyph): Handle cons cell entry in
9180 glyphless-char-display.
9181 (Vglyphless_char_display): Document it.
9183 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9184 glyphless-char-display.
9186 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9188 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9190 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9192 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9193 definition for no-X builds.
9195 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9197 Static checks with GCC 4.6.0 and non-default toolkits.
9199 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9201 * process.c (keyboard_bit_set): Define only if SIGIO.
9202 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9203 (send_process): Repair possible setjmp clobbering.
9205 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9207 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9209 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9211 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9212 Define only if needed.
9214 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9215 by pacifying GCC about it. Maybe it's time to retire it?
9216 * xfaces.c (USG, __TIMEVAL__): Likewise.
9218 * dispextern.h (struct redisplay_interface): Rename param
9220 * termhooks.h (struct terminal): Likewise.
9221 * xterm.c (xembed_send_message): Likewise.
9223 * insdel.c (make_gap_smaller): Define only if
9224 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9226 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9229 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9230 so that we aren't warned about unused symbols.
9232 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9234 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9236 * xfns.c (x_real_positions): Mark locals as initialized.
9238 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9240 * xterm.c: Fix problems found by static analysis with other toolkits.
9241 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9242 (x_dispatch_event): Declare static if USE_GTK, and
9243 define if USE_GTK || USE_X_TOOLKIT.
9244 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9245 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9246 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9247 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9249 * xmenu.c (menu_help_callback): Pointer type fixes.
9250 Use const pointers when pointing at readonly data. Avoid pointer
9252 (FALSE): Remove unused macro.
9253 (update_frame_menubar): Remove unused decl.
9255 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9257 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9258 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9259 (single_menu_item): Rename local to avoid shadowing.
9261 * keyboard.c (make_lispy_event): Remove unused local var.
9263 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9264 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9266 * bitmaps: Change bitmaps from unsigned char back to the X11
9267 compatible char. Avoid the old compiler warnings about
9268 out-of-range initializers by using, for example, '\xab' rather
9271 * xgselect.c (xgselect_initialize): Check vs interface
9272 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9274 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9276 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9277 to read-only memory.
9279 * fns.c (vector): Remove; this old hack is no longer needed.
9281 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9283 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9285 * xrdb.c (x_load_resources): Omit unused local.
9287 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9288 (x_window): Rename locals to avoid shadowing.
9289 (USG): Use the kludged USG macro, to pacify gcc.
9291 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9292 (x_term_init): Remove local to avoid shadowing.
9294 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9296 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9297 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9299 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9301 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9303 Fix regex.c, syntax.c and friends for buffers > 2GB.
9304 * syntax.h (struct gl_state_s): Declare character position members
9307 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9309 * textprop.c (verify_interval_modification, interval_of):
9310 Declare arguments EMACS_INT.
9312 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9315 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9317 * indent.c (Fvertical_motion): Local variable it_start is now
9320 * regex.c (re_match, re_match_2, re_match_2_internal)
9321 (bcmp_translate, regcomp, regexec, print_double_string)
9322 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9323 (re_compile_pattern, re_exec): Declare arguments and local
9324 variables `size_t' and `ssize_t' and return values `regoff_t', as
9326 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9327 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9328 <compile_stack_type>: `size' and `avail' are now `size_t'.
9330 * regex.h <regoff_t>: Use ssize_t, not int.
9331 (re_search, re_search_2, re_match, re_match_2): Arguments that
9332 specify buffer/string position and length are now ssize_t and
9333 size_t. Return type is regoff_t.
9335 2011-04-16 Ben Key <bkey76@gmail.com>
9337 * nsfont.m: Fixed bugs in ns_get_family and
9338 ns_descriptor_to_entity that were caused by using free to
9339 deallocate memory blocks that were allocated by xmalloc (via
9340 xstrdup). This caused Emacs to crash when compiled with
9341 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9342 --enable-checking=xmallocoverrun). xfree is now used to
9343 deallocate these memory blocks.
9345 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9347 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9349 emacs_write: Accept and return EMACS_INT for sizes.
9350 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9352 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9353 Accept and return EMACS_INT.
9354 (emacs_gnutls_write): Return the number of bytes written on
9356 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9357 (emacs_read, emacs_write): Remove check for negative size, as the
9358 Emacs source code has been audited now.
9359 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9360 (emacs_read, emacs_write): Use it.
9361 * process.c (send_process): Adjust to the new signatures of
9362 emacs_write and emacs_gnutls_write. Do not attempt to store
9363 a byte offset into an 'int'; it might overflow.
9364 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9366 * sound.c: Don't assume sizes fit in 'int'.
9367 (struct sound_device.period_size, alsa_period_size):
9368 Return EMACS_INT, not int.
9369 (struct sound_device.write, vox_write, alsa_write):
9370 Accept EMACS_INT, not int.
9371 (wav_play, au_play): Use EMACS_INT to store sizes and to
9372 record read return values.
9374 2011-04-15 Ben Key <bkey76@gmail.com>
9376 * keyboard.c (Qundefined): Don't declare static since it is used
9378 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9379 static since they are used in nsfont.m.
9381 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9383 * process.c (Qprocessp): Don't declare static.
9384 * lisp.h (Qprocessp): Declare again.
9386 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9388 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9390 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9392 Improve C-level modularity by making more things 'static'.
9394 Don't publish debugger-only interfaces to other modules.
9395 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9396 (verify_bytepos, count_markers): Move decls to the only modules
9398 * region-cache.h (pp_cache): Likewise.
9399 * window.h (check_all_windows): Likewise.
9400 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9402 * sysdep.c (croak): Now static, if
9403 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9404 * syssignal.h (croak): Declare only if not static.
9406 * alloc.c (refill_memory_reserve): Now static if
9407 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9408 * lisp.h (refill_memory_reserve): Declare only if not static.
9410 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9411 Define only if USE_LUCID.
9413 * xrdb.c (x_customization_string, x_rm_string): Now static.
9415 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9416 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9418 * xdisp.c (draw_row_with_mouse_face): Now static.
9419 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9421 * window.h (check_all_windows): Mark externally visible.
9423 * window.c (window_deletion_count): Now static.
9425 * undo.c: Make symbols static if they're not exported.
9426 (last_undo_buffer, last_boundary_position, pending_boundary):
9429 * textprop.c (interval_insert_behind_hooks): Now static.
9430 (interval_insert_in_front_hooks): Likewise.
9432 * term.c: Make symbols static if they're not exported.
9433 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9434 (max_frame_lines, tty_set_terminal_modes):
9435 (tty_reset_terminal_modes, tty_turn_off_highlight):
9436 (get_tty_terminal): Now static.
9437 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9438 * termhooks.h (term_mouse_moveto): Do not declare if
9440 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9441 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9443 * sysdep.c: Make symbols static if they're not exported.
9444 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9446 (sigprocmask_set, full_mask): Remove; unused.
9447 (wait_debugging): Mark as visible.
9448 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9449 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9451 * syntax.c (syntax_temp): Define only if !__GNUC__.
9453 * sound.c (current_sound_device, current_sound): Now static.
9455 * search.c (searchbufs, searchbuf_head): Now static.
9457 * scroll.c (scroll_cost): Remove; unused.
9458 * dispextern.h (scroll_cost): Remove decl.
9460 * region-cache.h (pp_cache): Mark as externally visible.
9462 * process.c: Make symbols static if they're not exported.
9463 (process_tick, update_tick, create_process, chan_process):
9464 (Vprocess_alist, proc_buffered_char, datagram_access):
9465 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9466 (deactivate_process): Mark defn as static, as well as decl.
9467 * lisp.h (create_process): Remove decl.
9468 * process.h (chan_process, Vprocess_alist): Remove decls.
9470 * print.c: Make symbols static if they're not exported.
9471 (print_depth, new_backquote_output, being_printed, print_buffer):
9472 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9473 (print_interval, print_number_index, initial_stderr_stream):
9475 * lisp.h (Fprinc): Remove decl.
9476 (debug_output_compilation_hack): Mark as externally visible.
9478 * sysdep.c (croak): Move decl from here to syssignal.h.
9479 * syssignal.h (croak): Put it here, so the API can be checked when
9480 'croak' is called from dissociate_if_controlling_tty.
9482 * minibuf.c: Make symbols static if they're not exported.
9483 (minibuf_save_list, choose_minibuf_frame): Now static.
9484 * lisp.h (choose_minibuf_frame): Remove decl.
9486 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9488 * lread.c: Make symbols static if they're not exported.
9489 (read_objects, initial_obarray, oblookup_last_bucket_number):
9491 (make_symbol): Remove; unused.
9492 * lisp.h (initial_obarray, make_symbol): Remove decls.
9494 * keyboard.c: Make symbols static if they're not exported.
9495 (single_kboard, recent_keys_index, total_keys, recent_keys):
9496 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9497 (this_single_command_key_start, echoing, last_auto_save):
9498 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9499 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9500 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9501 (Vlispy_mouse_stem, double_click_count):
9503 (force_auto_save_soon): Define only if SIGDANGER.
9504 (ignore_mouse_drag_p): Now static if
9505 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9506 (print_help): Remove; unused.
9507 (stop_character, last_timer_event): Mark as externally visible.
9508 * keyboard.h (ignore_mouse_drag_p): Declare only if
9509 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9510 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9511 * lisp.h (echoing): Remove decl.
9512 (force_auto_save_soon): Declare only if SIGDANGER.
9513 * xdisp.c (redisplay_window): Simplify code, to make it more
9514 obvious that ignore_mouse_drag_p is not accessed if !defined
9515 USE_GTK && !defined HAVE_NS.
9517 * intervals.c: Make symbols static if they're not exported.
9518 (merge_properties_sticky, merge_interval_right, delete_interval):
9520 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9522 * insdel.c: Make symbols static if they're not exported.
9523 However, leave prepare_to_modify_buffer alone. It's never
9524 called from outside this function, but that appears to be a bug.
9525 (combine_after_change_list, combine_after_change_buffer):
9526 (adjust_after_replace, signal_before_change): Now static.
9527 (adjust_after_replace_noundo): Remove; unused.
9528 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9529 (signal_before_change): Remove decls.
9531 * indent.c (val_compute_motion, val_vmotion): Now static.
9533 * image.c: Make symbols static if they're not exported.
9534 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9536 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9537 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9539 * fringe.c (standard_bitmaps): Now static.
9540 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9542 * frame.c: Make symbols static if they're not exported.
9543 (x_report_frame_params, make_terminal_frame): Now static.
9544 (get_frame_param): Now static, unless HAVE_NS.
9545 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9546 (x_get_resource_string): Remove; not used.
9547 * frame.h (make_terminal_frame, x_report_frame_params):
9548 (x_get_resource_string); Remove decls.
9549 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9550 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9552 * font.c, fontset.c: Make symbols static if they're not exported.
9553 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9554 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9555 * font.c (font_close_object): Now static.
9556 * font.h (font_close_object): Remove.
9557 * fontset.c (FONTSET_OBJLIST): Remove.
9558 (free_realized_fontset) #if-0 the body, which does nothing.
9559 (face_suitable_for_char_p): #if-0, as it's never called.
9560 * fontset.h (face_suitable_for_char_p): Remove decl.
9561 * xfaces.c (face_at_string_position):
9562 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9563 since 0 is always ASCII.
9565 * fns.c (weak_hash_tables): Now static.
9567 * fileio.c: Make symbols static if they're not exported.
9568 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9569 (Vwrite_region_annotation_buffers): Now static.
9571 * eval.c: Make symbols static if they're not exported.
9572 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9573 * lisp.h (backtrace_list): Remove decl.
9575 * emacs.c: Make symbols static if they're not exported.
9576 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9577 (fatal_error_code, fatal_error_signal_hook, standard_args):
9579 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9580 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9581 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9582 * lisp.h (fatal_error_signal_hook): Remove decl.
9583 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9585 * editfns.c: Move a (normally-unused) function to its only use.
9586 * editfns.c, lisp.h (get_operating_system_release): Remove.
9587 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9588 worth the hassle of breaking this out.
9590 * xterm.c: Make symbols static if they're not exported.
9591 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9592 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9593 (x_destroy_window, x_delete_display):
9595 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9596 (x_mouse_leave): Remove; unused.
9597 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9598 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9599 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9601 (x_mouse_leave): Declare only if WINDOWSNT.
9602 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9603 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9606 * ftxfont.c: Make symbols static if they're not exported.
9607 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9609 * font.h (ftxfont_driver): Likewise.
9611 * xfns.c: Make symbols static if they're not exported.
9612 (x_last_font_name, x_display_info_for_name):
9613 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9614 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9615 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9616 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9617 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9618 (last_show_tip_args): Now static.
9619 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9620 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9621 (x_screen_planes): Remove; unused.
9622 * dispextern.h (x_screen_planes): Remove decl.
9624 * dispnew.c: Make symbols static if they're not exported.
9625 * dispextern.h (redraw_garbaged_frames, scrolling):
9626 (increment_row_positions): Remove.
9627 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9628 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9630 (redraw_garbaged_frames): Remove; unused.
9632 * xfaces.c: Make symbols static if they're not exported.
9633 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9635 * xterm.h (defined_color): Remove decls.
9636 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9637 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9638 (menu_face_changed_default, defined_color, free_realized_face):
9639 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9640 (ascii_face_of_lisp_face): Remove; unused.
9642 * xdisp.c: Make symbols static if they're not exported.
9643 * dispextern.h (scratch_glyph_row, window_box_edges):
9644 (glyph_to_pixel_coords, set_cursor_from_row):
9645 (get_next_display_element, set_iterator_to_next):
9646 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9647 (show_mouse_face): Remove decls
9648 * frame.h (message_buf_print): Likewise.
9649 * lisp.h (pop_message, set_message, check_point_in_composition):
9651 * xterm.h (set_vertical_scroll_bar): Likewise.
9652 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9653 (message_buf_print, scratch_glyph_row, displayed_buffer):
9654 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9655 (get_next_display_element, show_mouse_face, window_box_edges):
9656 (frame_to_window_pixel_xy, check_point_in_composition):
9657 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9658 (glyph_to_pixel_coords): Remove; unused.
9660 * dired.c (file_name_completion): Now static.
9662 * dbusbind.c (xd_in_read_queued_messages): Now static.
9664 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9665 * data.c (circular_list_error): Remove.
9667 * commands.h (last_point_position, last_point_position_buffer):
9668 (last_point_position_window): Remove decls.
9669 * keyboard.c: Make these variables static.
9671 * coding.h (coding, code_convert_region, encode_coding_gap):
9673 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9674 (iso_code_class, detect_coding, code_convert_region): Now static.
9675 (encode_coding_gap): Remove; unused.
9677 * chartab.c (chartab_chars, chartab_bits): Now static.
9679 * charset.h (charset_iso_8859_1): Remove decl.
9680 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9683 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9684 * ccl.c (Vccl_program_table): Now static.
9685 (check_ccl_update): Remove; unused.
9687 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9688 * category.h: ... from here.
9689 * category.c (check_category_table, set_category_set): Now static.
9691 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9692 * lisp.h: Remove these decls.
9694 * buffer.c (buffer_count): Remove unused var.
9696 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9697 so that it's not optimized away.
9698 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9699 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9700 exported only to the debugger.
9702 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9703 * atimer.h (run_all_atimers): Remove; not exported.
9705 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9706 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9707 was inaccessible from Lisp.
9708 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9709 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9711 alloc.c: Import and export fewer symbols, and remove unused items.
9712 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9714 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9715 it's not optimized away by whole-program optimization.
9716 (message_enable_multibyte, free_misc): Remove.
9717 (catchlist, handlerlist, mark_backtrace):
9718 Declare only if BYTE_MARK_STACK.
9719 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9720 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9721 (message_enable_multibyte): Remove decl.
9722 (free_misc, interval_free_list, float_block, float_block_index):
9723 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9724 (cons_free_list, last_marked_index):
9726 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9727 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9728 (mark_backtrace): Define only if BYTE_MARK_STACK.
9729 * xdisp.c (message_enable_multibyte): Now static.
9731 Declare Lisp_Object Q* variables to be 'static' if not exported.
9732 This makes it easier for human readers (and static analyzers)
9733 to see whether these variables are used from other modules.
9734 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9735 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9736 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9737 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9738 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9739 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9740 * xmenu.c, xselect.c:
9741 Declare Q* vars static if they are not used in other modules.
9742 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9743 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9744 Remove decls of unexported vars.
9745 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9747 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9749 Make Emacs functions such as Fatom 'static' by default.
9750 This makes it easier for human readers (and static analyzers)
9751 to see whether these functions can be called from other modules.
9752 DEFUN now defines a static function. To make the function external
9753 so that it can be used in other C modules, use the new macro DEFUE.
9754 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9755 (Finit_image_library):
9756 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9757 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9758 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9759 Remove decls, since these functions are now static.
9760 (Funintern, Fget_internal_run_time): New decls, since these functions
9761 were already external.
9763 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9764 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9765 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9766 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9767 * keyboard.c, keymap.c, lread.c:
9768 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9769 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9770 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9771 Mark functions with DEFUE instead of DEFUN,
9772 if they are used in other modules.
9773 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9774 decls for now-static functions.
9775 * buffer.h (Fdelete_overlay): Remove decl.
9776 * callproc.c (Fgetenv_internal): Mark as internal.
9777 * composite.c (Fremove_list_of_text_properties): Remove decl.
9778 (Fcomposition_get_gstring): New forward static decl.
9779 * composite.h (Fcomposite_get_gstring): Remove decl.
9780 * dired.c (Ffile_attributes): New forward static decl.
9781 * doc.c (Fdocumntation_property): New forward static decl.
9782 * eval.c (Ffetch_bytecode): New forward static decl.
9783 (Funintern): Remove extern decl; now in .h file where it belongs.
9784 * fileio.c (Fmake_symbolic_link): New forward static decl.
9785 * image.c (Finit_image_library): New forward static decl.
9786 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9787 * intervals.h (Fprevious_property_change):
9788 (Fremove_list_of_text_properties): Remove decls.
9789 * keyboard.c (Fthis_command_keys): Remove decl.
9790 (Fcommand_execute): New forward static decl.
9791 * keymap.c (Flookup_key): New forward static decl.
9792 (Fcopy_keymap): Now static.
9793 * keymap.h (Flookup_key): Remove decl.
9794 * process.c (Fget_process): New forward static decl.
9795 (Fprocess_datagram_address): Mark as internal.
9796 * syntax.c (Fsyntax_table_p): New forward static decl.
9797 (skip_chars): Remove duplicate decl.
9798 * textprop.c (Fprevious_property_change): New forward static decl.
9799 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9801 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9802 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9804 * editfns.c (Fformat): Remove unreachable code.
9806 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9808 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9811 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9813 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9814 when at ZV. (Bug#8487)
9816 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9818 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9820 * keyboard.c (parse_tool_bar_item): Likewise.
9821 * sound.c (sound_cleanup, alsa_close): Likewise.
9822 * termcap.c (tgetent): Likewise.
9823 * xfns.c (x_default_font_parameter): Likewise.
9824 * xsettings.c (read_and_apply_settings): Likewise.
9826 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9827 (overrun_check_free): Protoize.
9829 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9831 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9832 since callers should never pass a negative size.
9833 Change the signature to match that of plain 'read' and 'write'; see
9834 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9835 * lisp.h: Update prototypes of emacs_write and emacs_read.
9837 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9839 * xdisp.c (redisplay_window): Don't try to determine the character
9840 position of the scroll margin if the window start point w->startp
9841 is outside the buffer's accessible region. (Bug#8468)
9843 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9845 Fix write-region and its subroutines for buffers > 2GB.
9846 * fileio.c (a_write, e_write): Modify declaration of arguments and
9847 local variables to support buffers larger than 2GB.
9848 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9850 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9851 argument, local variables, and return value.
9853 * lisp.h: Update prototypes of emacs_write and emacs_read.
9855 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9857 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9859 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9861 Fix more problems found by GCC 4.6.0's static checks.
9863 * xdisp.c (vmessage): Use a better test for character truncation.
9865 * charset.c (load_charset_map): <, not <=, for optimization,
9866 and to avoid potential problems with integer overflow.
9867 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9868 * casetab.c (set_identity, shuffle): Likewise.
9869 * editfns.c (Fformat): Likewise.
9870 * syntax.c (skip_chars): Likewise.
9872 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9873 This also lets GCC 4.6.0 generate slightly better loop code.
9875 * callint.c (Fcall_interactively): <, not <=, for optimization.
9876 (Fcall_interactively): Count the number of arguments produced,
9877 not the number of arguments given. This is simpler and lets GCC
9878 4.6.0 generate slightly better code.
9880 * ftfont.c: Distingish more carefully between FcChar8 and char.
9881 The previous code passed unsigned char * to a functions like
9882 strlen and xstrcasecmp that expect char *, which does not
9883 conform to the C standard.
9884 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9885 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9886 char * when the C standard requires it.
9888 * keyboard.c (read_char): Remove unused var.
9890 * eval.c: Port to Windows vsnprintf (Bug#8435).
9892 (SIZE_MAX): Define if the headers do not.
9893 (verror): Do not give up if vsnprintf returns a negative count.
9894 Instead, grow the buffer. This ports to Windows vsnprintf, which
9895 does not conform to C99. Problem reported by Eli Zaretskii.
9896 Also, simplify the allocation scheme, by avoiding the need for
9897 calling realloc, and removing the ALLOCATED variable.
9899 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9901 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9902 But keep the doprint source code for now, as we might revamp it
9903 and use it again (Bug#8435).
9904 * lisp.h (doprnt): Remove.
9905 * Makefile.in (base_obj): Remove doprnt.o.
9906 * deps.mk (doprnt.o): Remove.
9908 error: Print 32- and 64-bit integers portably (Bug#8435).
9909 Without this change, on typical 64-bit hosts error ("...%d...", N)
9910 was used to print both 32- and 64-bit integers N, which relied on
9912 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9913 * lisp.h (error, verror): Mark as printf-like functions.
9914 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9915 Report overflow in size calculations when allocating printf buffer.
9916 Do not truncate output string at its first null byte.
9917 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9918 Truncate the output at a character boundary, since vsnprintf does not
9920 * charset.c (check_iso_charset_parameter): Convert internal
9921 character to string before calling 'error', since %c now has the
9923 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9924 overflow when computing char to be passed to 'error'. Do not
9925 pass Lisp_Object to 'error'; pass the integer instead.
9926 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9927 formatted with plain %d.
9929 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9931 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9933 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9935 * xterm.c (x_catch_errors): Remove duplicate declaration.
9937 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9939 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9941 2011-04-10 Jim Meyering <meyering@redhat.com>
9943 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9944 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9945 return ssize_t not "int", and use size_t as the buffer length.
9946 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9947 * gnutls.h: Update declarations.
9948 * process.c (read_process_output): Use ssize_t, to match.
9949 (send_process): Likewise.
9951 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9953 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9955 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9957 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9958 Use unsigned char, to match FcChar8 type definition.
9960 * xterm.c (handle_one_xevent):
9961 * xmenu.c (create_and_show_popup_menu):
9962 * xselect.c (x_decline_selection_request)
9963 (x_reply_selection_request): Avoid type-punned deref of X events.
9965 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9967 Fix some uses of `int' instead of EMACS_INT.
9968 * search.c (string_match_1, fast_string_match)
9969 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9970 (scan_buffer, find_next_newline_no_quit)
9971 (find_before_next_newline, search_command, Freplace_match)
9972 (Fmatch_data): Make some `int' variables be EMACS_INT.
9974 * xdisp.c (display_count_lines): 3rd argument and return value now
9975 EMACS_INT. All callers changed.
9976 (pint2hrstr): Last argument is now EMACS_INT.
9978 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9979 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9980 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9981 (decode_coding_utf_16, decode_coding_emacs_mule)
9982 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9983 (decode_coding_ccl, decode_coding_charset)
9984 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9985 (decode_coding_iso_2022, decode_coding_emacs_mule)
9986 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9987 <char_offset, last_offset>: Declare EMACS_INT.
9988 (encode_coding_utf_8, encode_coding_utf_16)
9989 (encode_coding_emacs_mule, encode_invocation_designation)
9990 (encode_designation_at_bol, encode_coding_iso_2022)
9991 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9992 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9994 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9995 (encode_invocation_designation): Last argument P_NCHARS is now
9997 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9998 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10000 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10003 * ccl.c (Fccl_execute_on_string): Declare some variables
10006 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10008 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10010 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10012 * process.c (Fformat_network_address): Doc fix.
10014 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10016 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10018 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10020 * keyboard.c (read_char): Call Lisp function help-form-show,
10021 instead of using internal_with_output_to_temp_buffer.
10022 (Qhelp_form_show): New var.
10023 (syms_of_keyboard): Use DEFSYM macro.
10025 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10027 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10029 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10031 * process.c (Flist_processes): Remove to Lisp.
10032 (list_processes_1): Delete.
10034 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10036 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10038 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10040 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10042 Fix more problems found by GCC 4.6.0's static checks.
10044 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10046 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10048 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10050 * xdisp.c (vmessage): Mark as a printf-like function.
10052 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10054 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10056 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10057 printf-like functions.
10058 (tiff_load): Add casts to remove these marks before passing them
10059 to system-supplied API.
10061 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10063 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10064 This avoids several warnings with gcc -Wstrict-overflow.
10065 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10066 directly, rather than having caller test rule sign. This avoids
10067 some unnecessary tests.
10068 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10069 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10070 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10072 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10073 (xfont_open): Avoid unnecessary tests.
10075 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10077 * composite.h, composite.c (composition_gstring_put_cache):
10078 Use EMACS_INT, not int, for length.
10080 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10081 breaking out part of COMPOSITION_DECODE_RULE.
10082 (COMPOSITION_DECODE_RULE): Use it.
10083 * composite.c (get_composition_id): Remove unused local vars,
10084 by using the new macro.
10086 * textprop.c (set_text_properties_1): Change while to do-while,
10087 since the condition is always true at first.
10089 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10090 (interval_deletion_adjustment): Return unsigned value.
10093 * process.c (list_processes_1, create_pty, read_process_output):
10094 (exec_sentinel): Remove vars that were set but not used.
10095 (create_pty): Remove unnecessary "volatile"s.
10096 (Fnetwork_interface_info): Avoid possibility of int overflow.
10097 (read_process_output): Do adaptive read buffering even if carryover.
10098 (read_process_output): Simplify nbytes computation if buffered.
10100 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10102 * syntax.c (scan_words): Remove var that was set but not used.
10103 (update_syntax_table): Use unsigned instead of int.
10105 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10106 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10107 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10109 * print.c (print_error_message): Avoid int overflow.
10111 * font.c (font_list_entities): Redo for clarity,
10112 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10114 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10115 (font_score): Avoid potential overflow in diff calculation.
10117 * fns.c (substring_both): Remove var that is set but not used.
10118 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10120 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10122 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10123 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10124 can always succeed if overflow has undefined behavior.
10126 * search.c (boyer_moore, wordify): Remove vars set but not used.
10127 (wordify): Omit three unnecessary tests.
10129 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10130 All callers changed. This avoids the need for an unused var.
10132 * casefiddle.c (casify_region): Remove var that is set but not used.
10134 * dired.c (file_name_completion): Remove var that is set but not used.
10136 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10138 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10139 (Finsert_file_contents): Remove unnecessary code checking fd.
10141 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10142 Check for integer overflow on size calculations.
10144 * buffer.c (Fprevious_overlay_change): Remove var that is set
10147 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10148 Remove vars that are set but not used.
10149 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10150 (timer_check_2): Mark vars as initialized.
10152 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10154 * image.c (lookup_image): Remove var that is set but not used.
10155 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10157 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10158 that are set but not used.
10160 * xfns.c (make_invisible_cursor): Don't return garbage
10161 if XCreateBitmapFromData fails (Bug#8410).
10163 * xselect.c (x_get_local_selection, x_handle_property_notify):
10164 Remove vars that are set but not used.
10166 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10167 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10169 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10170 Remove var that is set but not used.
10171 (scroll_bar_windows_size): Now size_t, not int.
10172 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10173 Check for overflow.
10175 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10176 (map_tty_color) [!defined MSDOS]: Likewise.
10178 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10180 * coding.c: Remove vars that are set but not used.
10181 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10182 All callers changed.
10183 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10184 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10185 (decode_coding_charset): Remove vars that are set but not used.
10187 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10188 that is set but not used.
10190 * print.c (print_object): Remove var that is set but not used.
10192 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10193 The gnulib version avoids calling malloc in the usual case,
10194 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10195 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10196 * filelock.c (current_lock_owner): Likewise.
10197 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10198 * sysdep.c: Include allocator.h, careadlinkat.h.
10199 (emacs_no_realloc_allocator): New static constant.
10200 (emacs_readlink): New function.
10201 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10202 ../lib/careadlinkat.h.
10204 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10206 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10207 first non-nil return value).
10209 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10211 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10212 if not defined (Bug#8403).
10214 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10216 * xdisp.c (display_count_lines): Remove parameter `start',
10217 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10218 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10219 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10220 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10221 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10222 and thereabouts. All callers changed.
10223 (get_per_char_metric): Remove parameter `f', unused since
10224 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10226 2011-04-02 Jim Meyering <meyering@redhat.com>
10228 do not dereference NULL upon failed strdup
10229 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10230 (ns_get_family): Likewise.
10232 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10234 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10236 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10238 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10241 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10243 Add lexical binding.
10245 * window.c (Ftemp_output_buffer_show): New fun.
10246 (Fsave_window_excursion):
10247 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10249 * lread.c (lisp_file_lexically_bound_p): New function.
10250 (Fload): Bind Qlexical_binding.
10251 (readevalloop): Remove `evalfun' arg.
10252 Bind Qinternal_interpreter_environment.
10253 (Feval_buffer): Bind Qlexical_binding.
10254 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10256 (syms_of_lread): Declare `lexical-binding'.
10258 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10260 * keyboard.c (eval_dyn): New fun.
10261 (menu_item_eval_property): Use it.
10263 * image.c (parse_image_spec): Use Ffunctionp.
10265 * fns.c (concat, mapcar1): Accept byte-code-functions.
10267 * eval.c (Fsetq): Handle lexical vars.
10268 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10269 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10270 (FletX, Flet): Obey lexical binding.
10271 (Fcommandp): Handle closures.
10272 (Feval): New `lexical' arg.
10273 (eval_sub): New function extracted from Feval. Use it almost
10274 everywhere where Feval was used. Look up vars in lexical env.
10276 (Ffunctionp): Move from subr.el.
10277 (Ffuncall): Handle closures.
10278 (apply_lambda): Remove `eval_flags'.
10279 (funcall_lambda): Handle closures and new byte-code-functions.
10280 (Fspecial_variable_p): New function.
10281 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10282 but without exporting it to Lisp.
10284 * doc.c (Fdocumentation, store_function_docstring):
10285 * data.c (Finteractive_form): Handle closures.
10287 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10290 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10292 (exec_byte_code): New function extracted from Fbyte_code to handle new
10293 calling convention for byte-code-functions. Add new byte-codes.
10295 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10297 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10299 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10301 * xdisp.c (redisplay_internal): Fix prototype.
10303 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10305 * xdisp.c (SCROLL_LIMIT): New macro.
10306 (try_scrolling): Use it when setting scroll_limit.
10307 Limit scrolling to 100 screen lines.
10308 (redisplay_window): Even when falling back on "recentering",
10309 position point in the window according to scroll-conservatively,
10310 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10312 (try_scrolling): When point is above the window, allow searching
10313 as far as scroll_max, or one screenful, to compute vertical
10314 distance from PT to the scroll margin position. This prevents
10315 try_scrolling from unnecessarily failing when
10316 scroll-conservatively is set to a value slightly larger than the
10317 window height. Clean up the case of PT below the margin at bottom
10318 of window: scroll_max can no longer be INT_MAX. When aggressive
10319 scrolling is in use, don't let point enter the opposite scroll
10320 margin as result of the scroll.
10321 (syms_of_xdisp) <scroll-conservatively>: Document the
10322 threshold of 100 lines for never-recentering scrolling.
10324 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10326 * dispextern.h (move_it_by_lines):
10327 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10328 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10329 (message_log_check_duplicate): Remove parameters `prev_bol' and
10330 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10331 (redisplay_internal): Remove parameter `preserve_echo_area',
10332 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10334 * indent.c (Fvertical_motion):
10335 * window.c (window_scroll_pixel_based, Frecenter):
10336 Don't pass `need_y_p' to `move_it_by_lines'.
10338 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10340 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10341 steal a few bits to be more compact.
10342 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10343 Remove unneeded casts.
10345 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10347 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10349 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10350 binding" message (bug#7967).
10352 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10354 Fix more problems found by GCC 4.6.0's static checks.
10356 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10357 Remove unused local var.
10359 * editfns.c (Fmessage_box): Remove unused local var.
10361 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10362 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10363 Omit unused local vars.
10364 * window.c (shrink_windows): Omit unused local var.
10365 * menu.c (digest_single_submenu): Omit unused local var.
10366 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10367 Omit unused local var.
10369 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10370 Don't assume string length fits in int.
10371 (keyremap_step, read_key_sequence): Use size_t for sizes.
10372 (read_key_sequence): Don't check last_real_key_start redundantly.
10374 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10375 instead of alloca (Bug#8344).
10377 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10378 (Fbacktrace_frame): Don't assume nframes fits in int.
10380 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10382 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10385 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10387 * cm.c (calccost): Turn while-do into do-while, for clarity.
10389 * keyboard.c (syms_of_keyboard): Use the same style as later
10390 in this function when indexing through an array. This also
10391 works around GCC bug 48267.
10393 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10395 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10397 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10398 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10400 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10401 This avoids undefined behavior on integer overflow, and is a bit
10402 more convenient anyway since it is compared to a size_t variable.
10404 Variadic C functions now count arguments with size_t, not int.
10405 This avoids an unnecessary limitation on 64-bit machines, which
10406 caused (substring ...) to crash on large vectors (Bug#8344).
10407 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10408 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10409 All variadic functions and their callers changed accordingly.
10410 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10411 * data.c (arith_driver, float_arith_driver): Likewise.
10412 * editfns.c (general_insert_function): Likewise.
10413 * eval.c (struct backtrace.nargs, interactive_p)
10414 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10415 (funcall_lambda, mark_backtrace): Likewise.
10416 * fns.c (concat): Likewise.
10417 * frame.c (x_set_frame_parameters): Likewise.
10418 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10419 0 if not found, not -1. All callers changed.
10421 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10422 (stack_copy_size): Now size_t, not int.
10423 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10425 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10427 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10428 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10429 All callers changed.
10431 * lisp.h (multibyte_char_to_unibyte):
10432 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10433 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10434 * character.h (CHAR_TO_BYTE8):
10435 * cmds.c (internal_self_insert):
10436 * editfns.c (general_insert_function):
10437 * keymap.c (push_key_description):
10438 * search.c (Freplace_match):
10439 * xdisp.c (message_dolog, set_message_1): All callers changed.
10441 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10443 * keyboard.c (safe_run_hook_funcall): New function.
10444 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10445 don't set the hook to nil, but remove the offending function instead.
10446 (Qcommand_hook_internal): Remove, unused.
10447 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10448 Vcommand_hook_internal.
10450 * eval.c (enum run_hooks_condition): Remove.
10451 (funcall_nil, funcall_not): New functions.
10452 (run_hook_with_args): Call each function through a `funcall' argument.
10453 Remove `cond' argument, now redundant.
10454 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10455 (Frun_hook_with_args_until_failure): Adjust accordingly.
10456 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10458 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10460 * dispextern.h (string_buffer_position): Remove declaration.
10462 * print.c (strout): Remove parameter `multibyte', unused since
10463 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10465 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10466 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10467 All callers changed.
10469 * w32.c (_wsa_errlist): Use braces for struct initializers.
10471 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10472 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10473 All callers changed.
10474 (string_buffer_position): Likewise. Also, make static (it's never
10475 used outside xdisp.c).
10476 (cursor_row_p): Remove parameter `w', unused since
10477 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10478 (decode_mode_spec): Remove parameter `precision', introduced during
10479 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10480 All callers changed.
10482 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10484 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10486 2011-03-27 Anders Lindgren <andlind@gmail.com>
10488 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10489 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10490 (ns_update_auto_hide_menu_bar): New functions.
10491 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10492 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10493 ns_constrain_all_frames.
10494 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10495 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10497 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10499 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10501 2011-03-27 Glenn Morris <rgm@gnu.org>
10503 * syssignal.h: Replace RETSIGTYPE with void.
10504 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10505 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10506 Replace SIGTYPE with void everywhere.
10507 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10508 * s/template.h (SIGTYPE): Remove commented out definition.
10510 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10512 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10513 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10515 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10517 * w32.c (read_unc_volume): Use parameter `henum', instead of
10518 global variable `wget_enum_handle'.
10520 * keymap.c (describe_vector): Remove parameters `indices' and
10521 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10522 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10524 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10526 * keyboard.c (timer_check): Remove parameter `do_it_now',
10527 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10528 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10529 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10531 * keyboard.c (read_char):
10532 * w32menu.c (w32_menu_display_help):
10533 * xmenu.c (show_help_event, menu_help_callback):
10534 Adjust calls to `show_help_echo'.
10536 * gtkutil.c (xg_maybe_add_timer):
10537 * keyboard.c (readable_events):
10538 * process.c (wait_reading_process_output):
10539 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10541 * insdel.c (adjust_markers_gap_motion):
10542 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10543 (gap_left, gap_right): Don't call it.
10545 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10547 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10548 incurred during fontification.
10550 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10552 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10553 (DEFVAR_PER_BUFFER): Don't pass it.
10555 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10556 (scrolling_window): Don't pass it.
10558 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10560 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10562 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10564 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10565 of variables specific to SELinux and computation of `encoded_absname'.
10567 * image.c (XPutPixel): Remove unused variable `height'.
10569 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10571 * unexw32.c (get_section_info): Remove unused variable `section'.
10573 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10574 (system_process_attributes): Remove unused variable `sess'.
10575 (sys_read): Remove unused variable `err'.
10577 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10578 (w32_wnd_proc): Remove unused variable `isdead'.
10579 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10580 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10581 (x_create_tip_frame): Remove unused variable `tem'.
10583 * w32inevt.c (w32_console_read_socket):
10584 Remove unused variable `no_events'.
10586 * w32term.c (x_draw_composite_glyph_string_foreground):
10587 Remove unused variable `width'.
10589 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10591 * w32term.c (x_set_glyph_string_clipping):
10592 Don't pass uninitialized region to CombineRgn.
10594 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10596 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10597 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10598 (Fx_close_connection): Remove unused variable `i'.
10600 * w32font.c (w32font_draw): Return number of glyphs.
10601 (w32font_open_internal): Remove unused variable `i'.
10602 (w32font_driver): Add missing initializer.
10604 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10605 (fill_in_menu): Remove unused variable `items_added'.
10607 * w32term.c (last_mouse_press_frame): Remove static global variable.
10608 (w32_clip_to_row): Remove unused variable `f'.
10609 (x_delete_terminal): Remove unused variable `i'.
10611 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10612 (NOTHING): Remove unused static global variable.
10613 (uniscribe_check_otf): Remove unused variable `table'.
10614 (uniscribe_font_driver): Add missing initializers.
10616 2011-03-23 Julien Danjou <julien@danjou.info>
10618 * term.c (Fsuspend_tty, Fresume_tty):
10619 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10620 * window.c (temp_output_buffer_show):
10621 * insdel.c (signal_before_change):
10622 * frame.c (Fhandle_switch_frame):
10623 * fileio.c (Fdo_auto_save):
10624 * emacs.c (Fkill_emacs):
10625 * editfns.c (save_excursion_restore):
10626 * cmds.c (internal_self_insert):
10627 * callint.c (Fcall_interactively):
10628 * buffer.c (Fkill_all_local_variables):
10629 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10631 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10632 unconditionally since it does the check itself.
10634 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10636 Fix more problems found by GCC 4.5.2's static checks.
10638 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10639 the first time through the loop, since we know p0 < p1 then.
10640 This also avoids a gcc -Wstrict-overflow warning.
10642 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10643 leading to a memory leak, possible in functions like
10644 load_charset_map_from_file that can allocate an unbounded number
10645 of objects (Bug#8318).
10647 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10648 that could (at least in theory) be that large.
10650 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10651 This is less likely to overflow, and avoids undefined behavior if
10652 overflow does occur. All callers changed. Use strtoul to scan
10653 for the unsigned long integer.
10654 (pint2hrstr): Simplify and tune code slightly.
10655 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10657 * scroll.c (do_scrolling): Work around GCC bug 48228.
10658 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10660 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10661 This also avoids a warning with gcc -Wstrict-overflow.
10662 (validate_x_resource_name): Simplify count usage.
10663 This also avoids a warning with gcc -Wstrict-overflow.
10665 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10668 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10670 * process.c (Fmake_network_process): Use socklen_t, not int,
10671 where POSIX says socklen_t is required in portable programs.
10672 This fixes a porting bug on hosts like 64-bit HP-UX, where
10673 socklen_t is wider than int (Bug#8277).
10674 (Fmake_network_process, server_accept_connection):
10675 (wait_reading_process_output, read_process_output):
10678 * process.c: Rename or move locals to avoid shadowing.
10679 (list_processes_1, Fmake_network_process):
10680 (read_process_output_error_handler, exec_sentinel_error_handler):
10681 Rename or move locals.
10682 (Fmake_network_process): Define label "retry_connect" only if needed.
10683 (Fnetwork_interface_info): Fix pointer signedness.
10684 (process_send_signal): Add cast to avoid pointer signedness problem.
10685 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10686 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10688 Make tparam.h and terminfo.c consistent.
10689 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10690 Include tparam.h instead, since it declares them.
10691 * cm.h (PC): Remove extern decl; tparam.h now does this.
10692 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10693 * terminfo.c: Include tparam.h, to check interfaces.
10694 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10695 (tparam): Adjust signature to match interface in tparam.h;
10696 this removes some undefined behavior. Check that outstring and len
10697 are zero, which they always are with Emacs.
10698 * tparam.h (PC, BC, UP): New extern decls.
10700 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10701 (xftfont_open): Rename locals to avoid shadowing.
10703 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10704 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10705 (OTF_TAG_SYM): Omit macro if not needed.
10706 (ftfont_list): Remove unused local.
10707 (get_adstyle_property, ftfont_pattern_entity):
10708 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10709 Rename locals to avoid shadowing.
10711 * xfont.c (xfont_list_family): Mark var as initialized.
10713 * xml.c (make_dom): Now static.
10715 * composite.c (composition_compute_stop_pos): Rename local to
10717 (composition_reseat_it): Remove unused locals.
10718 (find_automatic_composition, composition_adjust_point): Likewise.
10719 (composition_update_it): Mark var as initialized.
10720 (find_automatic_composition): Mark vars as initialized,
10721 with a FIXME (Bug#8290).
10723 character.h: Rename locals to avoid shadowing.
10724 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10725 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10726 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10727 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10728 to avoid shadowing.
10730 * textprop.c (property_change_between_p): Remove; unused.
10732 * intervals.c (interval_start_pos): Now static.
10734 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10736 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10737 Rename locals to avoid shadowing.
10739 * sound.c (wav_play, au_play, Fplay_sound_internal):
10740 Fix pointer signedness.
10741 (alsa_choose_format): Remove unused local var.
10742 (wav_play): Initialize a variable to 0, to prevent undefined
10743 behavior (Bug#8278).
10745 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10747 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10749 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10750 clobbering (Bug#8298).
10751 * sysdep.c (sys_subshell): Likewise.
10752 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10754 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10755 This should get cleaned up, so that child_setup has the
10756 same signature on all platforms.
10758 * callproc.c (call_process_cleanup): Now static.
10759 (relocate_fd): Rename locals to avoid shadowing.
10761 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10763 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10764 not to be necessary, and produces flickering.
10766 2011-03-20 Glenn Morris <rgm@gnu.org>
10768 * config.in: Remove file.
10770 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10772 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10773 are now in src/globals.h.
10774 (syms_of_minibuf): Remove spurious & from previous change.
10776 2011-03-20 Leo Liu <sdl.web@gmail.com>
10778 * minibuf.c (completing-read-function): New variable.
10779 (completing-read-default): Rename from completing-read.
10780 (completing-read): Call completing-read-function.
10782 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10784 * xfaces.c (Fx_load_color_file):
10785 Read color file from absolute filename (bug#8250).
10787 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10789 * makefile.w32-in: Update dependencies.
10791 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10793 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10795 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10797 Fix more problems found by GCC 4.5.2's static checks.
10799 * process.c (make_serial_process_unwind, send_process_trap):
10800 (sigchld_handler): Now static.
10802 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10803 That way, the code declares only the vars that it needs.
10804 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10805 * s/cygwin.h (PTY_ITERATION): Likewise.
10806 * s/darwin.h (PTY_ITERATION): Likewise.
10807 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10809 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10810 * process.c (allocate_pty): Don't declare stb unless it's needed.
10812 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10813 (CONSTANTLIM): Remove; unused.
10814 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10815 Define only if needed.
10817 * unexelf.c (unexec): Name an expression,
10818 to avoid gcc -Wbad-function-cast warning.
10819 Use a different way to cause a compilation error if anyone uses
10820 n rather than nn, a way that does not involve shadowing.
10821 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10823 * deps.mk (unexalpha.o): Remove; unused.
10825 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10826 * unexec.h: New file.
10827 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10828 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10829 Depend on unexec.h.
10830 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10831 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10832 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10833 Change as necessary to match prototype in unexec.h.
10835 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10837 (back_comment, skip_chars): Mark vars as initialized.
10839 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10840 Rename locals to avoid shadowing.
10842 * lread.c (read1): Rewrite so as not to use empty "else".
10843 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10845 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10847 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10848 warning when compiling print.c.
10850 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10851 instead of using an uninitialized var.
10852 (font_sort_entities): Mark var as initialized.
10854 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10856 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10857 pointers to constants.
10858 (font_parse_fcname): Remove unused vars.
10859 (font_delete_unmatched): Now static.
10860 (font_get_spec): Remove; unused.
10861 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10862 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10863 Rename or move locals to avoid shadowing.
10865 * fns.c (require_nesting_list, require_unwind): Now static.
10866 (Ffillarray): Rename locals to avoid shadowing.
10868 * floatfns.c (domain_error2): Define only if needed.
10869 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10871 * alloc.c (mark_backtrace): Move decl from here ...
10872 * lisp.h: ... to here, so that it can be checked.
10874 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10875 (Fdefvar): Rewrite so as not to use empty "else".
10876 (lisp_indirect_variable): Name an expression,
10877 to avoid gcc -Wbad-function-cast warning.
10878 (Fdefvar): Rename locals to avoid shadowing.
10880 * callint.c (quotify_arg, quotify_args): Now static.
10881 (Fcall_interactively): Rename locals to avoid shadowing.
10882 Use const pointer when appropriate.
10884 * lisp.h (get_system_name, get_operating_system_release):
10885 Move decls here, to check interfaces.
10886 * process.c (get_operating_system_release): Move decl to lisp.h.
10887 * xrdb.c (get_system_name): Likewise.
10888 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10889 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10890 some of which prompt warnings from gcc -Wbad-function-cast.
10891 (Fformat_time_string, Fencode_time, Finsert_char):
10892 (Ftranslate_region_internal, Fformat):
10893 Rename or remove local vars to avoid shadowing.
10894 (Ftranslate_region_internal): Mark var as initialized.
10896 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10899 * lisp.h (eassert): Check that the argument compiles, even if
10900 ENABLE_CHECKING is not defined.
10902 * data.c (Findirect_variable): Name an expression, to avoid
10903 gcc -Wbad-function-cast warning.
10904 (default_value, arithcompare, arith_driver, arith_error): Now static.
10905 (store_symval_forwarding): Rename local to avoid shadowing.
10906 (Fmake_variable_buffer_local, Fmake_local_variable):
10907 Mark variables as initialized.
10908 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10910 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10911 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10912 Rename locals to avoid shadowing.
10913 (mark_stack): Move local variables into the #ifdef region where
10915 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10916 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10918 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10919 (GC_STRING_CHARS): Remove; not used.
10920 (Fmemory_limit): Cast sbrk's returned value to char *.
10922 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10923 avoids undefined behavior in theory.
10925 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10927 Use functions, not macros, for up- and down-casing (Bug#8254).
10928 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10929 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10930 to use the following functions instead of these macros.
10931 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10932 EMACS_INT, since callers assume the returned value fits in int.
10933 (upcase1): Likewise, for UPCASE_TABLE.
10934 (uppercasep, lowercasep, upcase): New static inline functions.
10935 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10936 the race-condition problem in the old DOWNCASE.
10938 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10939 Rename locals to avoid shadowing.
10940 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10941 (regex_compile, re_search_2, re_match_2_internal):
10942 Remove unused local vars.
10943 (FREE_VAR): Rewrite so as not to use empty "else",
10944 which gcc can warn about.
10945 (regex_compile, re_match_2_internal): Mark locals as initialized.
10946 (RETALLOC_IF): Define only if needed.
10947 (WORDCHAR_P): Likewise. This one is never needed, but is used
10948 only in a comment talking about a compiler bug, so put inside
10949 the #if 0 of that comment.
10950 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10951 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10954 * search.c (boyer_moore): Rename locals to avoid shadowing.
10955 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10956 (PREV_CHAR_BOUNDARY): Likewise.
10958 * search.c (simple_search): Remove unused var.
10960 * dired.c (compile_pattern): Move decl from here ...
10961 * lisp.h: ... to here, so that it can be checked.
10962 (struct re_registers): New forward decl.
10964 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10966 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10968 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10969 Rename locals to avoid shadowing.
10970 (Fvertical_motion): Mark locals as initialized.
10972 * casefiddle.c (casify_object, casify_region): Now static.
10973 (casify_region): Mark local as initialized.
10975 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10977 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10978 New macros, so that the caller can use some names other than
10979 gcpro1, gcpro2, etc.
10980 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10982 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10983 argument, for consistency with GCPRO2_VAR, etc: it is now the
10984 prefix of the variable, not the variable itself. All uses
10986 * dired.c (directory_files_internal, file_name_completion):
10987 Rename locals to avoid shadowing.
10989 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10990 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10991 dired.c's scmp function, had undefined behavior.
10992 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10993 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10994 * buffer.h: ... to here, because these macros use current_buffer,
10995 and the new implementation with inline functions needs to have
10996 current_buffer in scope now, rather than later when the macros
10998 (downcase, upcase1): New static inline functions.
10999 (DOWNCASE, UPCASE1): Reimplement using these functions.
11000 This avoids undefined behavior in expressions like
11001 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11002 from race conditions in accessing the global variables
11003 case_temp1 and case_temp2.
11004 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11005 * lisp.h (case_temp1, case_temp2): Remove their decls.
11006 * character.h (ASCII_CHAR_P): Move from here ...
11007 * lisp.h: ... to here, so that the inline functions mentioned
11008 above can use them.
11010 * dired.c (directory_files_internal_unwind): Now static.
11012 * fileio.c (file_name_as_directory, directory_file_name):
11013 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11015 (file_name_as_directory): Use const pointers when appropriate.
11016 (Fexpand_file_name): Likewise. In particular, newdir might
11017 point at constant storage, so make it a const pointer.
11018 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11019 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11021 (Fset_file_times, Finsert_file_contents, auto_save_error):
11022 Rename locals to avoid shadowing.
11024 * minibuf.c (choose_minibuf_frame_1): Now static.
11025 (Ftry_completion, Fall_completions): Rename or remove locals
11026 to avoid shadowing.
11028 * marker.c (bytepos_to_charpos): Remove; unused.
11030 * lisp.h (verify_bytepos, count_markers): New decls,
11031 so that gcc does not warn that these functions aren't declared.
11033 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11034 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11035 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11036 (copy_text): Remove unused local var.
11038 * filelock.c (within_one_second): Now static.
11039 (lock_file_1): Rename local to avoid shadowing.
11041 * buffer.c (fix_overlays_before): Mark locals as initialized.
11042 (fix_start_end_in_overlays): Likewise. This function should be
11043 simplified by using pointers-to-pointers, but that's a different
11045 (switch_to_buffer_1): Now static.
11046 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11047 (report_overlay_modification): Rename locals to avoid shadowing.
11049 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11050 Fix pointer signedness issue.
11051 (sys_subshell): Mark local as volatile if checking for lint,
11052 to suppress a gcc -Wclobbered warning that does not seem to be right.
11053 (MAXPATHLEN): Define only if needed.
11055 * process.c (serial_open, serial_configure): Move decls from here ...
11056 * systty.h: ... to here, so that they can be checked.
11058 * fns.c (get_random, seed_random): Move extern decls from here ...
11059 * lisp.h: ... to here, so that they can be checked.
11061 * sysdep.c (reset_io): Now static.
11062 (wait_for_termination_signal): Remove; unused.
11064 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11065 (copy_keymap_item, append_key, push_text_char_description):
11067 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11068 (DENSE_TABLE_SIZE): Remove; unused.
11069 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11070 (describe_map_tree):
11071 Rename locals to avoid shadowing.
11073 * keyboard.c: Declare functions static if they are not used elsewhere.
11074 (echo_char, echo_dash, cmd_error, top_level_2):
11075 (poll_for_input, handle_async_input): Now static.
11076 (read_char, kbd_buffer_get_event, make_lispy_position):
11077 (make_lispy_event, make_lispy_movement, apply_modifiers):
11078 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11079 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11080 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11081 (read_key_sequence, read_char): Mark locals as initialized.
11082 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11084 * keyboard.h (make_ctrl_char): New decl.
11085 (mark_kboards): Move decl here ...
11086 * alloc.c (mark_kboards): ... from here.
11088 * lisp.h (force_auto_save_soon): New decl.
11090 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11091 (DEFINE_DUMMY_FUNCTION): New macro.
11092 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11094 (main): Add casts to avoid warnings
11095 if GCC considers string literals to be constants.
11097 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11099 * dbusbind.c: Pointer signedness fixes.
11100 (xd_signature, xd_append_arg, xd_initialize):
11101 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11102 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11103 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11104 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11106 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11107 if GCC considers string literals to be constants.
11108 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11110 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11112 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11113 (print_preprocess, print_object): New macro to fix last change.
11115 * print.c (print_preprocess): Don't forget font objects.
11117 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11119 * emacs.c (USAGE3): Doc fixes.
11121 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11123 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11126 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11128 * lisp.h (VWindow_system, Qfile_name_history):
11129 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11130 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11131 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11133 * w32select.c: Don't #include "keyboard.h".
11134 (run_protected): Add extern declaration for waiting_for_input.
11136 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11137 * w32console.c (detect_input_pending, read_input_pending)
11138 (encode_terminal_code):
11139 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11140 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11141 (w32_system_caret_y, Qfile_name_history):
11142 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11143 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11144 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11145 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11146 * w32proc.c (Qlocal, report_file_error):
11147 * w32term.c (Vwindow_system, updating_frame):
11148 * w32uniscribe.c (initialized, uniscribe_font_driver):
11149 Remove unneeded extern declarations.
11151 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11153 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11155 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11157 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11158 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11159 These macros can no longer be used for assignment.
11161 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11162 Assign struct members directly, instead of using BUF_BEGV etc.
11163 (record_buffer_markers, fetch_buffer_markers): New functions for
11164 recording and fetching special buffer markers.
11165 (set_buffer_internal_1, set_buffer_temp): Use them.
11167 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11169 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11171 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11172 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11174 * xdisp.c (hscroll_window_tree):
11175 (reconsider_clip_changes): Use PT instead of BUF_PT.
11177 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11179 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11180 $(EMACS_ROOT)/lib/intprops.h.
11182 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11184 Fix more problems found by GCC 4.5.2's static checks.
11186 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11187 to unsigned char * to avoid compiler diagnostic.
11188 (xg_free_frame_widgets): Make it clear that a local variable is
11189 needed only if USE_GTK_TOOLTIP.
11190 (gdk_window_get_screen): Make it clear that this macro is needed
11191 only if USE_GTK_TOOLTIP.
11192 (int_gtk_range_get_value): New function, which avoids a diagnostic
11193 from gcc -Wbad-function-cast.
11194 (xg_set_toolkit_scroll_bar_thumb): Use it.
11195 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11196 diagnostic from gcc -Wbad-function-cast.
11197 (get_utf8_string, xg_get_file_with_chooser):
11198 Rename locals to avoid shadowing.
11199 (create_dialog): Move locals to avoid shadowing.
11201 * xgselect.c (xg_select): Remove unused var.
11203 * image.c (four_corners_best): Mark locals as initialized.
11204 (gif_load): Initialize transparent_p to zero (Bug#8238).
11205 Mark another local as initialized.
11206 (my_png_error, my_error_exit): Mark with NO_RETURN.
11208 * image.c (clear_image_cache): Now static.
11209 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11210 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11211 (x_edge_detection): Remove unnecessary cast that
11212 gcc -Wbad-function-cast diagnoses.
11213 (gif_load): Fix pointer signedness.
11214 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11215 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11217 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11219 Improve quality of tests for time stamp overflow.
11220 For example, without this patch (encode-time 0 0 0 1 1
11221 1152921504606846976) returns the obviously-bogus value (-948597
11222 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11223 reports time overflow. See
11224 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11225 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11226 * editfns.c: Include limits.h and intprops.h.
11227 (TIME_T_MIN, TIME_T_MAX): New macros.
11228 (time_overflow): Move earlier, to before first use.
11229 (hi_time, lo_time): New functions, for an accurate test for
11230 out-of-range times.
11231 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11232 (Fget_internal_run_time): Don't assume time_t fits in int.
11233 (make_time): Use list2 instead of Fcons twice.
11234 (Fdecode_time): More accurate test for out-of-range times.
11235 (check_tm_member): New function.
11236 (Fencode_time): Use it, to test for out-of-range times.
11237 (lisp_time_argument): Don't rely on undefined left-shift and
11238 right-shift behavior when checking for time stamp overflow.
11240 * editfns.c (time_overflow): New function, refactoring common code.
11241 (Fformat_time_string, Fdecode_time, Fencode_time):
11242 (Fcurrent_time_string): Use it.
11244 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11245 * dired.c (make_time): Move to ...
11246 * editfns.c (make_time): ... here.
11247 * systime.h: Note the move.
11249 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11251 * fringe.c (update_window_fringes): Remove unused variables.
11253 * unexmacosx.c (copy_data_segment): Also copy __got section.
11256 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11258 * termcap.c [MSDOS]: Include "msdos.h".
11259 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11260 Constify `char *' arguments and their references according to
11261 prototypes in tparam.h.
11263 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11265 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11266 Adapt all references accordingly.
11268 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11270 2011-03-11 Tom Tromey <tromey@redhat.com>
11272 * buffer.c (syms_of_buffer): Remove obsolete comment.
11274 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11276 * termhooks.h (encode_terminal_code): Declare prototype.
11278 * msdos.c (encode_terminal_code): Don't declare prototype.
11280 * term.c (encode_terminal_code): Now external again, used by
11281 w32console.c and msdos.c.
11283 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11284 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11286 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11288 Fix some minor problems found by GCC 4.5.2's static checks.
11290 * fringe.c (update_window_fringes): Mark locals as initialized
11292 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11294 * alloc.c (mark_fringe_data): Move decl from here ...
11295 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11296 to check its interface.
11297 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11299 * fontset.c (free_realized_fontset): Now static.
11300 (Fset_fontset_font): Rename local to avoid shadowing.
11301 (fontset_font): Mark local as initialized.
11302 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11304 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11306 * xselect.c (x_disown_buffer_selections): Remove; not used.
11307 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11308 (x_own_selection, Fx_disown_selection_internal): Rename locals
11309 to avoid shadowing.
11310 (x_handle_dnd_message): Remove local to avoid shadowing.
11312 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11313 so that the caller can use some name other than gcpro1.
11314 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11315 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11316 (Fx_backspace_delete_keys_p):
11317 Use them to avoid shadowing, and rename vars to avoid shadowing.
11318 (x_decode_color, x_set_name, x_window): Now static.
11319 (Fx_create_frame): Add braces to silence GCC warning.
11320 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11321 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11322 Remove unused locals.
11323 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11324 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11325 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11328 * xterm.h (x_mouse_leave): New decl.
11330 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11331 Remove unused functions.
11332 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11333 (x_calc_absolute_position): Now static.
11334 (XTread_socket): Don't define label "out" unless it's used.
11335 Don't declare local "event" unless it's used.
11336 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11337 unless they are used.
11338 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11339 (x_fatal_error_signal): Remove; not used.
11340 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11341 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11342 (x_error_catcher, x_connection_closed, x_error_handler):
11343 (x_error_quitter, xembed_send_message, x_iconify_frame):
11344 (my_log_handler): Rename locals to avoid shadowing.
11345 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11346 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11348 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11349 Rename or move locals to avoid shadowing.
11350 (tty_defined_color, merge_face_heights): Now static.
11351 (free_realized_faces_for_fontset): Remove; not used.
11352 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11353 does not deduce is never used uninitialized.
11354 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11355 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11357 * terminal.c (store_terminal_param): Now static.
11359 * xmenu.c (menu_highlight_callback): Now static.
11360 (set_frame_menubar): Remove unused local.
11361 (xmenu_show): Rename parameter to avoid shadowing.
11362 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11363 since they might point to immutable storage.
11364 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11365 since it's unused otherwise.
11367 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11368 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11369 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11370 avoids a gcc -Wuninitialized diagnostic.
11371 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11372 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11373 does not deduce are never used uninitialized.
11375 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11377 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11378 * window.c (window_loop, size_window):
11379 (run_window_configuration_change_hook, enlarge_window): Likewise.
11381 * window.c (display_buffer): Now static.
11382 (size_window): Mark variables that gcc -Wuninitialized
11383 does not deduce are never used uninitialized.
11384 * window.h (check_all_windows): New decl, to forestall
11385 gcc -Wmissing-prototypes diagnostic.
11386 * dispextern.h (bidi_dump_cached_states): Likewise.
11388 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11390 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11391 Include <limits.h>.
11392 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11393 and to avoid gcc -Wuninitialized warning.
11394 (load_charset_map): Mark variables that gcc -Wuninitialized
11395 does not deduce are never used uninitialized.
11396 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11398 * coding.c (coding_set_source, coding_set_destination):
11399 Use "else { /* comment */ }" rather than "else /* comment */;"
11400 for clarity, and to avoid gcc -Wempty-body warning.
11401 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11402 a block, when the outer 'i' will do.
11403 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11404 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11405 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11406 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11407 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11408 Rename locals to avoid shadowing.
11409 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11410 * coding.c (emacs_mule_char, encode_invocation_designation):
11411 Now static, since they're not used elsewhere.
11412 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11413 (decode_coding_object, encode_coding_object, detect_coding_system):
11414 (decode_coding_emacs_mule): Mark variables that gcc
11415 -Wuninitialized does not deduce are never used uninitialized.
11416 (detect_coding_iso_2022): Initialize a local variable that might
11417 be used uninitialized. Leave a FIXME because it's not clear that
11418 this initialization is needed. (Bug#8211)
11419 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11420 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11421 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11422 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11423 Remove unused macros.
11425 * category.c (hash_get_category_set): Remove unused local var.
11426 (copy_category_table): Now static, since it's not used elsewhere.
11427 * character.c (string_count_byte8): Likewise.
11429 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11430 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11432 * chartab.c (copy_sub_char_table): Now static, since it's not used
11434 (sub_char_table_ref_and_range, char_table_ref_and_range):
11435 Rename locals to avoid shadowing.
11436 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11438 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11439 (BIDI_BOB): Remove unused macro.
11441 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11442 deduce are never used uninitialized.
11443 * term.c (encode_terminal_code): Likewise.
11445 * term.c (encode_terminal_code): Now static. Remove unused local.
11447 * tparam.h: New file.
11448 * term.c, tparam.h: Include it.
11449 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11450 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11451 Move these decls to tparam.h, and make them agree with what
11452 is actually in tparam.c. The previous trick of using incompatible
11453 decls in different modules does not conform to the C standard.
11454 All callers of tparam changed to use tparam's actual API.
11455 * tparam.c (tparam1, tparam, tgoto):
11456 Use const pointers where appropriate.
11458 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11459 * cm.h (struct cm): Likewise.
11460 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11461 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11462 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11463 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11464 (turn_on_face, init_tty): Likewise.
11465 * termchar.h (struct tty_display_info): Likewise.
11467 * term.c (term_mouse_position): Rename local to avoid shadowing.
11469 * alloc.c (mark_ttys): Move decl from here ...
11470 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11472 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11474 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11476 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11478 * search.c (compile_pattern_1): Remove argument regp, unused since
11479 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11480 (compile_pattern): Don't pass it.
11482 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11484 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11485 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11487 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11489 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11491 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11492 gdk_window_get_screen, gdk_window_get_geometry,
11493 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11494 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11495 (xg_get_pixbuf_from_pixmap): New function.
11496 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11497 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11498 Call xg_get_pixbuf_from_pixmap instead of
11499 gdk_pixbuf_get_from_drawable.
11500 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11501 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11502 (xg_check_special_colors): Use GtkStyleContext and its functions
11504 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11505 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11506 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11507 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11508 Call gtk_widget_get_preferred_size.
11509 (xg_frame_resized): gdk_window_get_geometry only takes 5
11511 (xg_win_to_widget, xg_event_is_for_menubar):
11512 Call gdk_x11_window_lookup_for_display.
11513 (xg_set_widget_bg): New function.
11514 (delete_cb): New function.
11515 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11516 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11517 (xg_set_background_color): Call xg_set_widget_bg.
11518 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11519 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11520 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11521 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11523 (update_frame_tool_bar): Call gtk_widget_hide.
11524 (xg_initialize): Use GDK_KEY_g.
11526 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11528 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11530 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11531 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11532 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11534 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11536 * w32xfns.c (select_palette): Check success of RealizePalette against
11537 GDI_ERROR, not zero.
11539 See ChangeLog.11 for earlier changes.
11541 ;; Local Variables:
11545 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11547 This file is part of GNU Emacs.
11549 GNU Emacs is free software: you can redistribute it and/or modify
11550 it under the terms of the GNU General Public License as published by
11551 the Free Software Foundation, either version 3 of the License, or
11552 (at your option) any later version.
11554 GNU Emacs is distributed in the hope that it will be useful,
11555 but WITHOUT ANY WARRANTY; without even the implied warranty of
11556 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11557 GNU General Public License for more details.
11559 You should have received a copy of the GNU General Public License
11560 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.