]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from emacs-24; up to 2012-04-30T11:57:47Z!sdl.web@gmail.com
[gnu-emacs] / src / ChangeLog
1 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2
3 * gnutls.c (emacs_gnutls_handshake):
4 Add QUIT to make the loop interruptible.
5
6 2012-06-29 Glenn Morris <rgm@gnu.org>
7
8 * charset.c (init_charset): Make lack of etc/charsets fatal.
9
10 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
11
12 * editfns.c (region_limit): Fix type mismatch.
13
14 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
15
16 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
17 undefined. Convert from xassert to eassert.
18 * nsmenu.m: Convert from xassert to eassert.
19 * nsterm.m: Likewise.
20
21 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
22
23 * editfns.c (region_limit): Clip to narrowing (bug#11770).
24
25 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
26
27 Avoid integer overflow on scroll-left and scroll-right.
28 * window.c (HSCROLL_MAX): New macro.
29 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
30 overflow when requested scroll falls outside ptrdiff_t range.
31
32 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
33
34 * window.h (struct window): Change type of 'hscroll',
35 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
36 'last_modified' and 'last_overlay_modified' to EMACS_INT.
37 Adjust users accordingly.
38 * xdisp.c (try_cursor_movement): Replace type check with eassert.
39 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
40 from EMACS_INT to ptrdiff_t.
41 (make_window): Omit redundant initialization.
42
43 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
44
45 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
46
47 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
48
49 * window.h (struct window): Change type of 'use_time' and
50 'sequence_number' from Lisp_Object to int.
51 * frame.c (make_frame): Adjust users accordingly.
52 * print.c (print_object): Likewise.
53 * window.c (select_window, Fwindow_use_time, make_parent_window)
54 (make_window): Likewise.
55
56 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
57
58 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
59 enabled with --enable-checking=[all,glyphs] configure option.
60 Fix GLYPH_DEBUG usage assuming that it may be undefined,
61 adjust comments accordingly.
62 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
63 undefined, adjust comments accordingly.
64 * image.c: Likewise.
65 * scroll.c: Likewise.
66 * w32fns.c: Likewise.
67 * w32term.c: Likewise.
68 * xdisp.c: Likewise.
69 * xfaces.c: Likewise.
70 * xfns.c: Likewise.
71 * xterm.c: Likewise.
72
73 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Generalize run-time debugging checks.
76 * dispextern.h (XASSERTS): Remove.
77 * fontset.c (xassert): Remove.
78 Convert from xassert to eassert.
79 * alloc.c: Convert from xassert to eassert.
80 * bidi.c: Likewise.
81 * dispnew.c: Likewise.
82 * fns.c: Likewise.
83 * fringe.c: Likewise.
84 * ftfont.c: Likewise.
85 * gtkutil.c: Likewise.
86 * image.c: Likewise.
87 * keyboard.c: Likewise.
88 * menu.c: Likewise.
89 * process.c: Likewise.
90 * scroll.c: Likewise.
91 * sound.c: Likewise.
92 * term.c: Likewise.
93 * w32console.c: Likewise.
94 * w32fns.c: Likewise.
95 * w32term.c: Likewise.
96 * window.c: Likewise.
97 * xdisp.c: Likewise.
98 * xfaces.c: Likewise.
99 * xfns.c: Likewise.
100 * xselect.c: Likewise.
101 * xterm.c: Likewise.
102
103 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
104
105 * fns.c (maybe_resize_hash_table): Output message when growing the
106 purify-hashtable.
107
108 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
109
110 * alloc.c (allocate_string_data): Remove dead code.
111 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
112 avoid GCC warning about unused macro.
113
114 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
115
116 * alloc.c (allocate_string): Omit intervals initialization.
117 * alloc.c (make_uninit_multibyte_string): Initialize intervals
118 as in make_pure_string and make_pure_c_string.
119
120 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
121
122 * alloc.c (allocate_string): Fix last change.
123
124 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
125
126 * alloc.c (allocate_string): Remove two redundant calls
127 to memset, add explicit initialization where appropriate.
128
129 2012-06-27 Glenn Morris <rgm@gnu.org>
130
131 * lisp.mk (lisp): Remove paths.elc.
132
133 2012-06-27 Chong Yidong <cyd@gnu.org>
134
135 * doc.c (Fsubstitute_command_keys): Fix punctuation.
136
137 2012-06-26 John Wiegley <johnw@newartisans.com>
138
139 * unexmacosx.c (copy_data_segment): Add two section names used
140 on Mac OS X Lion: __mod_init_func and __mod_term_func.
141
142 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
143 when building with Clang.
144
145 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
146
147 * eval.c (Fapply): Allow calling it with a single argument.
148
149 2012-06-26 Eli Zaretskii <eliz@gnu.org>
150
151 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
152 _stricmp and _strnicmp.
153 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
154
155 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
156
157 * alloc.c (allocate_window): Zero out non-Lisp part of newly
158 allocated window.
159 (allocate_process): Likewise for new process.
160 (allocate_terminal): Change to use offsetof.
161 (allocate_frame): Likewise.
162 * frame.c (make_frame): Omit redundant initialization.
163 * window.c (make_parent_window): Use memset.
164 (make_window): Omit redundant initialization.
165 * process.c (make_process): Omit redundant initialization.
166 * terminal.c (create_terminal): Likewise.
167
168 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
169
170 * term.c (delete_tty): Remove redundant call to memset.
171
172 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
173
174 * alloc.c: Remove build_string.
175 * lisp.h: Define build_string as static inline. This provides
176 a better opportunity to optimize away calls to strlen when the
177 function is called with compile-time constant argument.
178 * image.c (imagemagick_error): Convert to build_string.
179 * w32proc.c (sys_spawnve): Likewise.
180 * xterm.c (x_term_init): Likewise.
181
182 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
183
184 Use sprintf return value instead of invoking strlen on result.
185 In the old days this wasn't portable, since some sprintf
186 implementations returned char *. But they died out years ago and
187 Emacs already assumes sprintf returns int.
188 Similarly for float_to_string.
189 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
190 * ccl.c (ccl_driver):
191 * character.c (string_escape_byte8):
192 * data.c (Fnumber_to_string):
193 * doprnt.c (doprnt):
194 * print.c (print_object):
195 * xdisp.c (message_dolog):
196 * xfns.c (syms_of_xfns):
197 Use sprintf or float_to_string result to avoid need to call strlen.
198 * data.c (Fnumber_to_string):
199 Use make_unibyte_string, since the string must be ASCII.
200 * lisp.h, print.c (float_to_string): Now returns int length.
201 * term.c (produce_glyphless_glyph):
202 Use sprintf result rather than recomputing it.
203
204 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
205 * Makefile.in (ALL_CFLAGS):
206 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
207 * gmalloc.c, regex.c: Include <config.h> unconditionally.
208
209 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
210
211 * dispextern.h (xstrcasecmp): Define to library function
212 strcasecmp if available.
213 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
214
215 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
216
217 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
218 Avoid comma operator.
219 * menu.c (push_submenu_start, push_submenu_end)
220 (push_left_right_boundary, push_menu_pane): Likewise.
221 * msdos.c (dos_rawgetc): Likewise.
222
223 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
224
225 * xfns.c (xic_create_fontsetname): Remove redundant calls
226 to memset.
227
228 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
229
230 * gtkutil.c (get_utf8_string): Remove redundant assignment.
231 sprintf already null-terminates its output.
232
233 * xfns.c (x_window): Remove redundant cast.
234
235 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
236
237 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
238 `const char *' to `char *' to avoid compiler warning.
239
240 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
241
242 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
243 instead of truncating it to 63 (admittedly a generous limit).
244
245 * process.c: Fix spelling and caps in comments.
246
247 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
248
249 * emacs.c (setpgrp): Remove definition, unused.
250 * sysdep.c (setpgrp): Remove definition, not used in this file.
251
252 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
253
254 * makefile.w32-in: Update dependencies.
255
256 2012-06-24 Eli Zaretskii <eliz@gnu.org>
257
258 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
259 (SYSTIME_H): Add nt/inc/sys/time.h.
260
261 * systime.h [WINDOWSNT]: Include sys/time.h.
262
263 * s/ms-w32.h (struct timespec): Definition moved from
264 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
265
266 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
267
268 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
269 * buffer.h (buffer_slot_type_mismatch):
270 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
271 * eval.c (unwind_to_catch):
272 * image.c (my_png_error, my_error_exit):
273 * keyboard.c (quit_throw_to_read_char, user_error)
274 (Fexit_recursive_edit, Fabort_recursive_edit):
275 * lisp.h (die, args_out_of_range, args_out_of_range_3)
276 (wrong_type_argument, buffer_overflow, __executable_start)
277 (memory_full, buffer_memory_full, string_overflow, Fthrow)
278 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
279 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
280 (fatal):
281 (child_setup) [!DOS_NT]:
282 * lread.c (end_of_file_error, invalid_syntax):
283 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
284 * puresize.h (pure_write_error):
285 * search.c (matcher_overflow):
286 * sound.c (sound_perror, alsa_sound_perror):
287 * sysdep.c, syssignal.h (croak):
288 * term.c (maybe_fatal, vfatal):
289 * textprop.c (text_read_only):
290 * undo.c (user_error):
291 * unexmacosx.c (unexec_error):
292 * xterm.c (x_ins_del_lines, x_delete_glyphs):
293 Use _Noreturn rather than NO_RETURN.
294 No need for separate decl merely because of _Noreturn.
295 * sound.c (sound_warning, parse_sound):
296 Remove unnecessary forward decls.
297
298 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
299
300 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
301 * lisp.h (WAIT_READING_MAX): New macro.
302 * dispnew.c (Fsleep_for, sit_for):
303 * keyboard.c (kbd_buffer_get_event):
304 * process.c (Faccept_process_output):
305 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
306 This improves on the previous patch, which introduced a bug
307 when time_t is unsigned and as wide as intmax_t.
308 See <http://bugs.gnu.org/9000#51>.
309
310 2012-06-23 Eli Zaretskii <eliz@gnu.org>
311
312 * dispnew.c (sit_for, Fsleep_for):
313 * keyboard.c (kbd_buffer_get_event):
314 * process.c (Faccept_process_output): Avoid compiler warnings when
315 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
316
317 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
318
319 * makefile.w32-in: Update dependencies.
320
321 * w32.c (ltime): Add return type and declare static.
322 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
323
324 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
325
326 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
327 Privately reported by Herbert J. Skuhra.
328 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
329 All uses changed.
330 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
331 not make_lisp_timeval, when the argument is of type EMACS_TIME.
332
333 2012-06-23 Eli Zaretskii <eliz@gnu.org>
334
335 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
336 last argument of make_unibyte_string.
337
338 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
339 language ID in the event parameters.
340
341 * w32term.c (w32_read_socket): Put the new keyboard codepage into
342 event.code, not the obscure "character set ID".
343
344 2012-06-23 Chong Yidong <cyd@gnu.org>
345
346 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
347
348 2012-06-23 Eli Zaretskii <eliz@gnu.org>
349
350 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
351 * w32.c (fdutimens): New function.
352
353 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
354
355 * s/ms-w32.h (pselect): Redirect to sys_select.
356
357 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
358
359 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
360 in the logic of incrementing and decrementing the value of
361 use_relocatable_buffers.
362
363 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
364
365 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
366 Privately reported by Herbert J. Skuhra.
367 [__FreeBSD__]: Remove "*/" typo after "#include".
368 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
369 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
370 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
371 Don't assume EMACS_TIME and struct timeval are the same type.
372
373 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
374
375 Support higher-resolution time stamps (Bug#9000).
376 The time stamps are only nanosecond-resolution at the C level,
377 since that's the best that any real-world system supports now.
378 But they are picosecond-resolution at the Lisp level, as that's
379 easy, and leaves room for future OS improvements.
380
381 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
382 (LIBES): Use it.
383
384 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
385 Don't get current time unless it's needed.
386
387 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
388 now provides it if it's absent.
389 (start_atimer): Port to higher-res time stamps.
390 Check for time stamp overflow. Don't get current time more
391 often than is needed.
392
393 * buffer.h (struct buffer): Buffer modtime now has high resolution.
394 Include systime.h, not time.h.
395 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
396
397 * dired.c: Include stat-time.h.
398 (Ffile-attributes): File times now have higher resolution.
399
400 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
401 (struct image): Timestamp now has higher resolution.
402
403 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
404 has at least microseconds now. All uses removed.
405 (update_frame, update_single_window, update_window, update_frame_1)
406 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
407
408 * editfns.c (time_overflow): Now extern.
409 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
410 (float-time, Fformat_time_string, Fcurrent_time_string)
411 (Fcurrent_time_zone): Accept and generate higher-resolution
412 time stamps.
413 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
414 (decode_time_components, lisp_seconds_argument): New functions.
415 (make_time): Now static.
416 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
417 Report an error if the time is invalid, rather than having the caller
418 do that.
419
420 * fileio.c: Include <stat-time.h>
421 (Fcopy_file): Copy higher-resolution time stamps.
422 Prefer to set the time stamp via a file descriptor if that works.
423 (Fset_file_times, Finsert_file_contents, Fwrite_region)
424 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
425 (Fvisited_file_modtime, Fset_visited_file_modtime):
426 Support higher-resolution time stamps.
427
428 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
429
430 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
431
432 * image.c (prepare_image_for_display, clear_image_cache)
433 (lookup_image): Port to higer-resolution time stamps.
434
435 * keyboard.c (start_polling, bind_polling_period):
436 Check for time stamp overflow.
437 (read_char, kbd_buffer_get_event, timer_start_idle)
438 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
439 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
440 Port to higher-resolution time stamps. Do not assume time_t is signed.
441 (decode_timer): New function. Timers are now vectors of length 9,
442 not 8, to accommodate the picosecond component.
443 (timer_check_2): Use it.
444
445 * nsterm.m (select_timeout, timeval_subtract): Remove.
446 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
447 as they're a bit more accurate and handle overflow better.
448 (ns_select): Change prototype to be compatible with pselect.
449 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
450 * nsterm.h (ns_select): Adjust prototype.
451
452 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
453 us-resolution time stamps.
454 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
455
456 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
457
458 * lisp.h (time_overflow): New decl.
459 (wait_reading_process_output): First arg is now intmax_t, not int,
460 to accommodate larger waits.
461
462 * process.h (struct Lisp_Process.read_output_delay):
463 Now counts nanoseconds, not microseconds.
464 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
465 EMACS_HAS_USECS.
466 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
467 (wait_reading_process_output):
468 Port to ns-resolution time stamps.
469 (Faccept_process_output, wait_reading_process_output):
470 Check for time stamp overflow. Do not assume time_t is signed.
471 (select_wrapper): Remove; we now use pselect.
472 (Fprocess_attributes): Now generates ns-resolution time stamps.
473
474 * sysdep.c: Include utimens.h. Don't include utime.h
475 or worry about struct utimbuf; gnulib does that for us now.
476 (gettimeofday): Remove; gnulib provides a substitute.
477 (make_timeval): New function.
478 (set_file_times): Now sets ns-resolution time stamps.
479 New arg FD; all uses changed.
480 (time_from_jiffies, ltime_from_jiffies, get_up_time)
481 (system_process_attributes):
482 Now returns ns-resolution time stamp. All uses changed.
483 Check for time stamp overflow.
484
485 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
486 provides a substitute now.
487
488 * systime.h: Include timespec.h rather than sys/time.h and time.h,
489 since it guarantees struct timespec.
490 (EMACS_TIME): Now struct timespec, so that we can support
491 ns-resolution time stamps.
492 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
493 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
494 (EMACS_USECS): Remove.
495 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
496 so multiply the arg by 1000 before storing it.
497 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
498 New macros.
499 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
500 Port to ns-resolution time stamps.
501 (EMACS_TIME_NEG_P): Remove; replaced by....
502 (EMACS_TIME_SIGN): New macro.
503 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
504 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
505 (set_file_times, make_time, lisp_time_argument): Adjust signature.
506 (make_timeval, make_lisp_time, decode_time_components): New decls.
507 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
508 that it mishandled time_t overflow. You can't compare by subtracting!
509 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
510 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
511
512 * term.c: Include <sys/time.h>.
513 (timeval_to_Time): New function, for proper overflow wraparound.
514 (term_mouse_position, term_mouse_click): Use it.
515
516 * undo.c (record_first_change): Support higher-resolution time stamps
517 in the undo buffer.
518 (Fprimitive_undo): Use them when restoring time stamps.
519
520 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
521 (w32_get_internal_run_time):
522 Port to higher-resolution Emacs time stamps.
523 (ltime): Now accepts single 64-bit integer, as that's more convenient
524 for callers.
525
526 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
527
528 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
529 for compatibility with pselect. Support ns-resolution time stamps.
530
531 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
532
533 * xselect.c (wait_for_property_change, x_get_foreign_selection):
534 Check for time stamp overflow, and support ns-resolution time stamps.
535
536 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
537 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
538 (timeval_subtract): Remove; no longer needed.
539 (XTflash, XTring_bell, x_wait_for_event):
540 Port to ns-resolution time stamps. Don't assume time_t is signed.
541
542 2012-06-22 Chong Yidong <cyd@gnu.org>
543
544 * xdisp.c (x_consider_frame_title): Revert last change.
545
546 2012-06-22 Eli Zaretskii <eliz@gnu.org>
547
548 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
549 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
550 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
551 staticidx goes up to 1597 out of 1600 = 0x640.)
552
553 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
554
555 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
556 Otherwise, the umask might be mistakenly 0 while handling input signals.
557
558 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
559
560 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
561
562 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
563
564 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
565 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
566 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
567 access to `contents' member of Lisp_Vector objects with AREF and ASET
568 where appropriate.
569
570 2012-06-19 Chong Yidong <cyd@gnu.org>
571
572 * frame.c (delete_frame): When selecting a frame on a different
573 text terminal, do not alter the terminal's top-frame.
574
575 * xdisp.c (format_mode_line_unwind_data): Record the target
576 frame's selected window and its terminal's top-frame.
577 (unwind_format_mode_line): Restore them.
578 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
579 Callers changed.
580 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
581 since tty frames can be explicitly named.
582 (prepare_menu_bars): Likewise.
583
584 * term.c (Ftty_top_frame): New function.
585
586 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
587
588 Port byte-code-meter to modern targets.
589 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
590 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
591 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
592 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
593 (METER_1, METER_2): Simplify.
594
595 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
596
597 * data.c (Fdefalias): Return `symbol' (bug#11686).
598
599 2012-06-18 Martin Rudalics <rudalics@gmx.at>
600
601 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
602 gets killed during executing of this function (Bug#11665).
603 Try to always return Qt when the buffer has been actually killed.
604 (Vkill_buffer_query_functions): In doc-string say that functions
605 run by this hook should not change the current buffer.
606
607 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
608
609 Fix recently-introduced process.c problems found by static checking.
610 * process.c (write_queue_push, write_queue_pop, send_process):
611 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
612 (write_queue_pop): Fix pointer signedness problem.
613 (send_process): Remove unused local.
614
615 2012-06-17 Chong Yidong <cyd@gnu.org>
616
617 * xdisp.c (redisplay_internal): No need to redisplay terminal
618 frames that are not on top.
619
620 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
621
622 * process.c (make_process): Initialize write_queue.
623 (write_queue_push, write_queue_pop): New functions.
624 (send_process): Use them to maintain correct ordering of process
625 writes (Bug#10815).
626
627 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
628
629 * lisp.h (eassert): Assume C89 or later.
630 This removes the need for CHECK.
631 (CHECK): Remove. Its comments about always evaluating its
632 argument were confusing, as 'eassert' typically does not evaluate
633 its argument.
634
635 * coding.c (produce_chars): Use ptrdiff_t, not int.
636
637 * xterm.c (x_draw_underwave): Check for integer overflow.
638 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
639
640 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
641
642 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
643 referenced (Bug#11583).
644
645 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
646
647 Implement wave-style variant of underlining.
648 * dispextern.h (face_underline_type): New enum.
649 (face): Add field for underline type.
650 * nsterm.m (ns_draw_underwave): New function.
651 (ns_draw_text_decoration): Use it.
652 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
653 New functions.
654 (x_draw_glyph_string): Use them.
655 * xfaces.c (Qline, Qwave): New Lisp objects.
656 (check_lface_attrs, merge_face_ref)
657 (Finternal_set_lisp_face_attribute, realize_x_face):
658 Handle wave-style underline face attributes.
659 * xterm.c (x_draw_underwave): New function.
660 (x_draw_glyph_string): Use it.
661
662 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
663
664 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
665 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
666 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
667 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
668 ($(BLD)/w32select.$(O)): Update dependencies.
669
670 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
671
672 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
673 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
674 * character.c (_fetch_multibyte_char_p): Remove.
675 * alloc.c: Include "character.h" before "buffer.h".
676 * bidi.c: Likewise.
677 * buffer.c: Likewise.
678 * bytecode.c: Likewise.
679 * callint.c: Likewise.
680 * callproc.c: Likewise.
681 * casefiddle.c: Likewise.
682 * casetab.c: Likewise.
683 * category.c: Likewise.
684 * cmds.c: Likewise.
685 * coding.c: Likewise.
686 * composite.c: Likewise.
687 * dired.c: Likewise.
688 * dispnew.c: Likewise.
689 * doc.c: Likewise.
690 * dosfns.c: Likewise.
691 * editfns.c: Likewise.
692 * emacs.c: Likewise.
693 * fileio.c: Likewise.
694 * filelock.c: Likewise.
695 * font.c: Likewise.
696 * fontset.c: Likewise.
697 * fringe.c: Likewise.
698 * indent.c: Likewise.
699 * insdel.c: Likewise.
700 * intervals.c: Likewise.
701 * keyboard.c: Likewise.
702 * keymap.c: Likewise.
703 * lread.c: Likewise.
704 * macros.c: Likewise.
705 * marker.c: Likewise.
706 * minibuf.c: Likewise.
707 * nsfns.m: Likewise.
708 * nsmenu.m: Likewise.
709 * print.c: Likewise.
710 * process.c: Likewise.
711 * regex.c: Likewise.
712 * region-cache.c: Likewise.
713 * search.c: Likewise.
714 * syntax.c: Likewise.
715 * term.c: Likewise.
716 * textprop.c: Likewise.
717 * undo.c: Likewise.
718 * unexsol.c: Likewise.
719 * w16select.c: Likewise.
720 * w32fns.c: Likewise.
721 * w32menu.c: Likewise.
722 * window.c: Likewise.
723 * xdisp.c: Likewise.
724 * xfns.c: Likewise.
725 * xmenu.c: Likewise.
726 * xml.c: Likewise.
727 * xselect.c: Likewise.
728
729 2012-06-16 Eli Zaretskii <eliz@gnu.org>
730
731 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
732 If all the glyphs of the glyph row came from strings, and we have no
733 cursor positioning clues, put the cursor on the first glyph of the
734 row.
735 (handle_face_prop): Use chunk-relative overlay string index when
736 indexing into it->string_overlays array. (Bug#11653)
737 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
738 the rightmost. (Bug#11720)
739
740 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
741
742 * category.h (CHAR_HAS_CATEGORY): Define as inline.
743 (CATEGORY_MEMBER): Enforce 1/0 value.
744 * category.c (_temp_category_set): Remove.
745
746 2012-06-16 Eli Zaretskii <eliz@gnu.org>
747
748 * window.c (Fdelete_other_windows_internal)
749 (Fdelete_window_internal): Don't access frame's mouse highlight
750 info of the initial frame. (Bug#11677)
751
752 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
753
754 * .gdbinit (xgetint): Fix recently-introduced paren typo.
755 Assume USE_2_TAGS_FOR_INTS.
756 (xreload): Adjust $tagmask width to match recent lisp.h change.
757
758 Simplify lisp.h in minor ways that should not affect code.
759 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
760 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
761 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
762 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
763 (INTTYPEBITS): New macro, for clarity.
764 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
765 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
766 Simplify now that USE_LSB_TAG is always defined.
767 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
768 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
769
770 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
771
772 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
773
774 2012-06-13 Glenn Morris <rgm@gnu.org>
775
776 * s/bsd-common.h (BSD4_3):
777 * s/usg5-4-common.h (USG5_4): No longer define; unused.
778
779 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
780
781 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
782 instead of union.
783 (XLI, XIL): Define.
784 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
785 Use them.
786 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
787 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
788 * alloc.c (widen_to_Lisp_Object): Remove.
789 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
790 * frame.c (delete_frame): Remove outdated comment.
791 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
792 USE_LISP_UNION_TYPE.
793 (Fw32_unregister_hot_key): Likewise.
794 (Fw32_toggle_lock_key): Likewise.
795 * w32menu.c (add_menu_item): Likewise.
796 (w32_menu_display_help): Use XIL instead of checking
797 USE_LISP_UNION_TYPE.
798 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
799 (init_heap): Likewise.
800 * w32term.c (w32_read_socket): Update comment.
801
802 2012-06-13 Glenn Morris <rgm@gnu.org>
803
804 * s/usg5-4-common.h, src/s/unixware.h:
805 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
806
807 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
808
809 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
810
811 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
812 * alloc.c (make_number) [!defined make_number]:
813 Remove, as lisp.h always defines this now.
814 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
815 (roundup_size): Verify that it is a power of 2.
816 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
817 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
818 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
819 -DUSE_LSB_TAG=0, to override the automatically-selected default.
820 USE_LSB_TAG now is always defined to be either 0 or 1.
821 All uses changed.
822 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
823 code works fine either way, and efficiency is not a concern here,
824 as the union type is for debugging, not for production.
825 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
826 Use an inline function on all platforms when using the union type,
827 since this is simpler and 'static inline' can be used portably
828 within Emacs now.
829 (LISP_INITIALLY_ZERO): New macro.
830 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
831 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
832
833 2012-06-12 Glenn Morris <rgm@gnu.org>
834
835 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
836
837 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
838
839 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
840 Move BROKEN_SIGIO to configure.
841
842 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
843 Move NO_TERMIO to configure.
844
845 2012-06-12 Chong Yidong <cyd@gnu.org>
846
847 * image.c (imagemagick_load_image): Use MagickFlattenImage if
848 MagickMergeImageLayers is undefined. Use pixel pusher loop if
849 MagickExportImagePixels is undefined.
850
851 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
852
853 * image.c (imagemagick_load_image): Remove unused label.
854
855 2012-06-11 Glenn Morris <rgm@gnu.org>
856
857 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
858 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
859 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
860 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
861
862 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
863
864 * alloc.c (make_byte_code): New function.
865 (Fmake_byte_code): Use it. Don't purify here.
866 * lread.c (read1): Use it as well to avoid extra allocation.
867
868 2012-06-11 Chong Yidong <cyd@gnu.org>
869
870 * image.c (imagemagick_load_image): Implement transparency.
871
872 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
873
874 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
875 account for preceding backslashes. (Bug#11663)
876
877 2012-06-09 Chong Yidong <cyd@gnu.org>
878
879 * term.c: Support italics in capable terminals (Bug#9652).
880 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
881 (turn_on_face): Output using TS_enter_italic_mode if available.
882 Don't handle unused blinking and alt-charset cases.
883 (turn_off_face): Handle italic case; discard unused tty_blinking_p
884 and tty_alt_charset_p cases.
885 (tty_capable_p, init_tty): Support italics.
886
887 * termchar.h (struct tty_display_info): Add field for italics.
888 Remove unused blink field.
889
890 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
891 Handle slant.
892
893 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
894 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
895 tty_alt_charset_p. Add tty_italic_p.
896
897 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
898
899 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
900 dbus_type_is_basic if available.
901 (xd_extract_signed, xd_extract_unsigned): Rename from
902 extract_signed and extract_unsigned, respectively. Adapt callers.
903
904 2012-06-09 Chong Yidong <cyd@gnu.org>
905
906 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
907
908 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
909 case (Bug#9752).
910
911 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
912
913 * xdisp.c (vmessage): Treat frame message as multibyte.
914 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
915 would generate the diagnostic "Making \302\247 buffer-local while
916 let-bound!".
917
918 2012-06-08 Eli Zaretskii <eliz@gnu.org>
919
920 * dispnew.c (showing_window_margins_p): Undo last change, which
921 was done due to an inadvertent commit.
922 (adjust_frame_glyphs_for_frame_redisplay): Do call
923 showing_window_margins_p.
924
925 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
926
927 * eval.c (Fmake_var_non_special): New primitive.
928 (syms_of_eval): Defsubr it.
929 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
930
931 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
932
933 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
934 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
935
936 2012-06-08 Eli Zaretskii <eliz@gnu.org>
937
938 * alloc.c (allocate_vectorlike): Fix last change.
939
940 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
941
942 Block-based vector allocation of small vectors.
943 * lisp.h (struct vectorlike_header): New field `nbytes',
944 adjust comment accordingly.
945 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
946 to denote vector blocks. Adjust users (live_vector_p,
947 mark_maybe_pointer, valid_lisp_object_p) accordingly.
948 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
949 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
950 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
951 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
952 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
953 (roundup_size): New constant.
954 (struct vector_block): New data type.
955 (vector_blocks, vector_free_lists, zero_vector): New variables.
956 (all_vectors): Rename to `large_vectors'.
957 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
958 (sweep_vectors): New functions.
959 (allocate_vectorlike): Return `zero_vector' as the only vector of
960 0 items. Allocate new vector from block if vector size is less than
961 or equal to VBLOCK_BYTES_MAX.
962 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
963 (init_alloc_once): Add call to init_vectors.
964
965 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
966
967 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
968
969 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
970
971 * doprnt.c (doprnt): Truncate multibyte char correctly.
972 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
973 would mishandle a string argument "Xc" if X was a multibyte
974 character of length 2: it would truncate after X's first byte
975 rather than including all of X.
976
977 2012-06-06 Chong Yidong <cyd@gnu.org>
978
979 * buffer.c (word_wrap): Doc fix.
980
981 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
982
983 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
984
985 2012-06-03 Glenn Morris <rgm@gnu.org>
986
987 * xdisp.c (tool-bar-style): Doc fix.
988
989 2012-06-03 Ulrich Müller <ulm@gentoo.org>
990
991 * Makefile.in (PAXCTL): Define.
992 (temacs$(EXEEXT)): Disable memory randomization for the temacs
993 binary via PaX flags if the paxctl utility is available.
994 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
995 Restore PaX flags to their default. (Bug#11398)
996
997 2012-06-03 Chong Yidong <cyd@gnu.org>
998
999 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1000 buffer (Bug#11226).
1001
1002 2012-06-03 Chong Yidong <cyd@gnu.org>
1003
1004 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1005 (note_mode_line_or_margin_highlight): If there is no help echo,
1006 use mode-line-default-help-echo. Handle the case where the mouse
1007 position is past the end of the mode line string.
1008
1009 * buffer.c (buffer_local_value_1): New function, split from
1010 Fbuffer_local_value; can return Qunbound.
1011 (Fbuffer_local_value): Use it.
1012 (Vmode_line_format): Docstring tweaks.
1013
1014 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1015
1016 * sysdep.c (system_process_attributes): Improve comment.
1017
1018 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1019
1020 * keyboard.c: Export real-this-command to Elisp.
1021 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1022 and DEFVAR it. Update all users.
1023
1024 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1027
1028 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1029 Convert pctcpu and pctmem to Lisp float properly.
1030 Let the compiler fold better, as 100.0/0x8000 is exact.
1031
1032 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1033
1034 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1035 cons_block.
1036
1037 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1040
1041 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1042
1043 For a 'struct window', replace some Lisp_Object fields to
1044 bitfields where appropriate, remove unused fields.
1045 * window.h (struct window): Remove unused 'last_mark_x' and
1046 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1047 change it's type from Lisp_Object to bitfield.
1048 Change type of 'force_start', 'optional_new_start',
1049 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1050 fields from Lisp_Object to bitfield. Adjust users accordingly.
1051
1052 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1053
1054 Pacify gcc -Wdouble-precision when using Xaw.
1055 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1056 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1057 Use 'float' consistently, rather than 'float' in most places
1058 and 'double' in a couple of places.
1059
1060 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1061
1062 * xdisp.c (handle_stop): Detect whether we have overlay strings
1063 loaded by testing it->current.overlay_string_index to be
1064 non-negative, instead of checking whether n_overlay_strings is
1065 positive. (Bug#11587)
1066
1067 2012-05-31 Chong Yidong <cyd@gnu.org>
1068
1069 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1070
1071 * doc.c (Fsubstitute_command_keys): Doc fix.
1072
1073 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1074
1075 * search.c (search_buffer): Remove calls to
1076 r_alloc_inhibit_buffer_relocation, as it is now called by
1077 maybe_unify_char, which was the cause of relocation of buffer text
1078 in bug#11519.
1079
1080 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1081
1082 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1083 for the duration of call to load_charset, to avoid problems with
1084 callers of maybe_unify_char that access buffer text through C
1085 pointers.
1086
1087 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1088 decrement the inhibition flag, instead of just setting or
1089 resetting it.
1090
1091 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 Remove obsolete '#define static' cruft.
1094 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1095 This #undef was "temporary" in 2000; it is no longer needed
1096 now that '#define static' has gone away.
1097 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1098 (gray_bitmap_bits): Remove; no longer needed.
1099 All uses replaced with definiens.
1100 * xterm.c: Include "bitmaps/gray.xbm".
1101
1102 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 Clean up __executable_start, monstartup when --enable-profiling.
1105 The following changes affect the code only when profiling.
1106 * dispnew.c (__executable_start): Rename from safe_bcopy.
1107 Define only on platforms that need it.
1108 * emacs.c: Include <sys/gmon.h> when profiling.
1109 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1110 (__executable_start): Remove decl, since lisp.h does it now.
1111 (safe_bcopy): Remove decl; no longer has that name.
1112 (main): Coalesce #if into single bit of code, for simplicity.
1113 Cast pointers to uintptr_t, since standard libraries want integers
1114 and not pointers.
1115 * lisp.h (__executable_start): New decl.
1116
1117 2012-05-31 Glenn Morris <rgm@gnu.org>
1118
1119 * image.c (Fimagemagick_types): Doc fix.
1120
1121 2012-05-30 Jim Meyering <meyering@redhat.com>
1122
1123 * callproc.c (Fcall_process_region): Include directory component
1124 in mkstemp error message (Bug#11586).
1125
1126 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1127
1128 * alloc.c, lisp.h (make_pure_vector): Now static.
1129
1130 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1131
1132 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1133 Move to byte-run.el.
1134 (Fautoload): Do the hash-doc more carefully.
1135 * data.c (Fdefalias): Purify definition, except for keymaps.
1136 (Qdefun): Move from eval.c.
1137 * lisp.h (Qdefun): Remove.
1138 * lread.c (read1): Tiny simplification.
1139
1140 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1141
1142 Do not create empty overlays with the evaporate property (Bug#9642).
1143 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1144 Bug#9642, but explicitly check that the buffer the overlay would
1145 be moved to is live and rearrange lines to make sure that errors
1146 will not put the overlay in an inconsistent state.
1147 (Fdelete_overlay): Cosmetics.
1148
1149 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1150
1151 * w32term.c (my_bring_window_to_top): New function.
1152 (x_raise_frame): Use handle returned by DeferWindowPos, which
1153 could be different from the original one.
1154 Call my_bring_window_to_top instead of my_set_foreground_window.
1155 (Bug#11513)
1156
1157 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1158 by calling BringWindowToTop.
1159
1160 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1161 (WM_EMACS_END): Increase by one.
1162
1163 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1164
1165 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1166 This avoids undefined behavior that might cause the eassert
1167 to not catch an out-of-range value.
1168
1169 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1170
1171 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1172 Update dependencies.
1173
1174 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1175
1176 * bidi.c (bidi_mirror_char): Fix last change.
1177
1178 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1179
1180 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1181 when referring to sectname field in printf format.
1182
1183 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1186 Only r_alloc_inhibit_buffer_relocation needed to be added;
1187 the others were already declared.
1188
1189 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1190 before checking whether it's out of range. Put the check inside
1191 eassert. See
1192 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1193
1194 2012-05-27 Ken Brown <kbrown@cornell.edu>
1195
1196 * callproc.c (Fcall_process): Restore a line that was accidentally
1197 commented out in the 2011-02-13 change (bug#11547).
1198
1199 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1200
1201 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1202 defined on ralloc.c.
1203
1204 * buffer.c [REL_ALLOC]: Remove prototypes of
1205 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1206 they are now on lisp.h.
1207
1208 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1209
1210 * search.c (search_buffer): Use it to inhibit relocation of buffer
1211 text while re_search_2 is doing its job, because re_search_2 is
1212 passed C pointers to buffer text. (Bug#11519)
1213
1214 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1215 Update value to 24.
1216
1217 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1218 state after an additional call to move_it_in_display_line_to, keep
1219 the values of it->max_ascent and it->max_descent found for the
1220 entire line.
1221 (pos_visible_p): Revert the comparison against bottom_y to what it
1222 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1223 (Bug#11464)
1224
1225 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 Fix coding-related core dumps with gcc -ftrapv.
1228 The code was computing A - B, where A and B are pointers, and B is
1229 random garbage. This can lead to core dumps on platforms that
1230 have special pointer registers, and it also leads to core dumps on
1231 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1232 A - B only when B is initialized properly.
1233 * coding.c (coding_set_source, coding_set_destination): Return void.
1234 (coding_change_source, coding_change_destinations): New functions,
1235 with the old behaviors of coding_set_source and coding_set_destination.
1236 All callers that need an offset changed to use these new functions.
1237
1238 2012-05-26 Glenn Morris <rgm@gnu.org>
1239
1240 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1241
1242 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1243
1244 Extend mouse support on W32 text-mode console.
1245 * xdisp.c (draw_row_with_mouse_face):
1246 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1247
1248 * w32console.c: Include window.h.
1249 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1250 New functions.
1251 (initialize_w32_display): Initialize mouse-highlight data.
1252
1253 * w32inevt.c: Include termchar.h and window.h.
1254 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1255 moves, call note_mouse_highlight. If help_echo changed, call
1256 gen_help_event to produce help-echo message in the echo area.
1257 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1258 highlight info.
1259
1260 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 * lread.c (read1): Simplify slightly to avoid an overflow warning
1263 with GCC 4.7.0 on x86-64.
1264
1265 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1266
1267 * bidi.c (bidi_mirror_char): Revert last change: an int is
1268 definitely wide enough here.
1269
1270 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 Fix integer width and related bugs (Bug#9874).
1273 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1274 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1275 (string_bytes, check_sblock, allocate_string_data):
1276 (compact_small_strings, Fmake_bool_vector, make_string)
1277 (make_unibyte_string, make_multibyte_string)
1278 (make_string_from_bytes, make_specified_string)
1279 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1280 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1281 (mark_vectorlike):
1282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1283 (allocate_pseudovector):
1284 Use int, not EMACS_INT, where int is wide enough.
1285 (inhibit_garbage_collection, Fgarbage_collect):
1286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1287 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1288 int might not be wide enough.
1289 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1290 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1291 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1292 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1293 (bidi_level_of_next_char, bidi_move_to_visually_next):
1294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1295 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1296 (Fkill_buffer, Fset_buffer_major_mode)
1297 (advance_to_char_boundary, Fbuffer_swap_text)
1298 (Fset_buffer_multibyte, overlays_at, overlays_in)
1299 (overlay_touches_p, struct sortvec, record_overlay_string)
1300 (overlay_strings, recenter_overlay_lists)
1301 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1302 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1303 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1304 (Foverlay_recenter, last_overlay_modification_hooks_used)
1305 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1307 (validate_region): Omit unnecessary test for b <= e,
1308 since that's guaranteed by the previous test.
1309 (adjust_overlays_for_delete): Avoid pos + length overflow.
1310 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1311 (report_overlay_modification):
1312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1313 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1314 Omit pointer cast, which isn't needed anyway, and doesn't work
1315 after the EMACS_INT -> ptrdiff_t change.
1316 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1317 * buffer.h: Adjust decls to match defn changes elsewhere.
1318 (struct buffer_text, struct buffer):
1319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1320 Use EMACS_INT, not int, where int might not be wide enough.
1321 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1322 not int, to avoid needless 32-bit limit on 64-bit hosts.
1323 (exec_byte_code): Use tighter memory-full test, one that checks
1324 for alloca overflow. Don't compute the address of the object just
1325 before an array, as that's not portable. Use EMACS_INT, not
1326 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1327 * callint.c (Fcall_interactively):
1328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1329 * callproc.c (call_process_kill, Fcall_process):
1330 Don't assume pid_t fits into an Emacs fixnum.
1331 (call_process_cleanup, Fcall_process, child_setup):
1332 Don't assume pid_t fits into int.
1333 (call_process_cleanup, Fcall_process, delete_temp_file)
1334 (Fcall_process_region):
1335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1336 (Fcall_process): Simplify handling of volatile integers.
1337 Use int, not EMACS_INT, where int will do.
1338 * casefiddle.c (casify_object, casify_region, operate_on_word)
1339 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1341 (casify_object): Avoid integer overflow when overallocating buffer.
1342 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1343 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1344 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1345 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1346 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1347 integers are now checked earlier. All uses replaced with XINT.
1348 (ccl_driver):
1349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1350 For CCL_MapSingle, check that content and value are in int range.
1351 (ccl_driver, Fregister_code_conversion_map):
1352 Check that Vcode_version_map_vector is a vector.
1353 (resolve_symbol_ccl_program): Check that vector header is in range.
1354 Always copy the vector, so that we can check its contents reliably
1355 now rather than having to recheck each instruction as it's being
1356 executed. Check that vector words fit in 'int'.
1357 (ccl_get_compiled_code, Fregister_ccl_program)
1358 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1359 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1360 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1361 contents are in range.
1362 (Fccl_execute_on_string): Check that status is in range.
1363 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1364 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1365 Accept and return EMACS_INT, not int, because callers can pass values
1366 out of 'int' range.
1367 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1368 (multibyte_chars_in_text, parse_str_as_multibyte)
1369 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1370 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1371 (string_escape_byte8, Fget_byte):
1372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1373 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1374 avoid mishandling large integers.
1375 * character.h: Adjust decls to match defn changes elsewhere.
1376 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1377 (Ffind_charset_region):
1378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1379 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1380 (load_charset_map_from_vector, Fdefine_charset_internal):
1381 Don't assume fixnum fits in int.
1382 (load_charset_map_from_vector, Fmap_charset_chars):
1383 Remove now-unnecessary CHECK_NATNUMs.
1384 (Fdefine_charset_internal): Check ranges here, more carefully.
1385 Don't rely on undefined behavior with signed left shift overflow.
1386 Don't assume unsigned int fits into fixnum, or that fixnum fits
1387 into unsigned int. Don't require max_code to be a valid fixnum;
1388 that's not true for gb10830 4-byte on a 32-bit host. Allow
1389 invalid_code to be a cons, for the same reason. Require code_offset
1390 to be a character. Avoid int overflow if max_char is close
1391 to INT_MAX.
1392 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1393 this is intended anyway and avoids some undefined behavior.
1394 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1395 INDEX_TO_CODE_POINT, as that's what it expects.
1396 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1397 * charset.h (DECODE_CHAR): Return int, not unsigned;
1398 this is what was intended anyway, and it avoids undefined behavior.
1399 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1400 integer-overflow issues.
1401 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1402 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1403 where the argument is EMACS_INT, and this behavior is not intended.
1404 * chartab.c (Fmake_char_table, Fset_char_table_range)
1405 (uniprop_get_decoder, uniprop_get_encoder):
1406 Don't assume fixnum fits in int.
1407 * cmds.c (move_point): New function, that does the gist of
1408 Fforward_char and Fbackward_char, but does so while checking
1409 for integer overflow more accurately.
1410 (Fforward_char, Fbackward_char): Use it.
1411 (Fforward_line, Fend_of_line, internal_self_insert)
1412 (internal_self_insert):
1413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1414 Fix a FIXME, by checking for integer overflow when calculating
1415 target_clm and actual_clm.
1416 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1417 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1418 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1419 (coding_alloc_by_making_gap, alloc_destination)
1420 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1421 (encode_coding_utf_16, detect_coding_emacs_mule)
1422 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1423 (detect_coding_iso_2022, decode_coding_iso_2022)
1424 (encode_invocation_designation, encode_designation_at_bol)
1425 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1426 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1427 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1428 (encode_coding_ccl, encode_coding_raw_text)
1429 (detect_coding_charset, decode_coding_charset)
1430 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1431 (produce_composition, produce_charset, produce_annotation)
1432 (decode_coding, handle_composition_annotation)
1433 (handle_charset_annotation, consume_chars, decode_coding_gap)
1434 (decode_coding_object, encode_coding_object, detect_coding_system)
1435 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1436 (code_convert_region, code_convert_string)
1437 (Fdefine_coding_system_internal)
1438 (coding_set_source, coding_set_destination):
1439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1440 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1441 (Fdefine_coding_system_internal):
1442 Don't assume fixnums fit in int.
1443 (decode_coding_gap, decode_coding_object, encode_coding_object)
1444 (Fread_coding_system, Fdetect_coding_region)
1445 (Funencodable_char_position, Fcheck_coding_systems_region)
1446 (get_translation, handle_composition_annotation, consume_chars):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 (consume_chars): Rewrite to not calculate an address outside buffer.
1449 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1450 Don't access memory outside of the args array.
1451 (Fdefine_coding_system_internal): Check for charset-id overflow.
1452 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1453 result of ENCODE_CHAR.
1454 * coding.h: Adjust decls to match defn changes elsewhere.
1455 (struct coding_system):
1456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1457 * composite.c (get_composition_id, find_composition)
1458 (run_composition_function, update_compositions)
1459 (compose_text, composition_gstring_put_cache)
1460 (composition_gstring_p, composition_gstring_width)
1461 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1462 (composition_compute_stop_pos, composition_reseat_it)
1463 (composition_update_it, struct position_record)
1464 (find_automatic_composition, composition_adjust_point)
1465 (Fcomposition_get_gstring, Ffind_composition_internal):
1466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1467 (update_compositions):
1468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1469 * composite.h: Adjust decls to match defn changes elsewhere.
1470 (struct composition):
1471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1472 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1473 Do not attempt to compute the address of the object just before a
1474 buffer; this is not portable.
1475 (Faref, Faset):
1476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1477 (Faset): Use int, not EMACS_INT, where int is wide enough.
1478 (Fstring_to_number): Don't assume fixnums fit in int.
1479 (Frem): Don't assume arg is nonnegative.
1480 * dbusbind.c (xd_append_arg): Check for integers out of range.
1481 (Fdbus_call_method): Don't overflow the timeout int.
1482 (extract_signed, extract_unsigned): New functions.
1483 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1484 (xd_get_connection_references): Return ptrdiff_t, not int.
1485 All uses changed.
1486 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1487 (xd_read_message_1):
1488 Use int, not unsigned, where the dbus API uses int.
1489 (Fdbus_message_internal): Don't overflow mtype.
1490 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1491 * dired.c (directory_files_internal, file_name_completion, scmp)
1492 (file_name_completion_stat):
1493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1494 (file_name_completion): Don't overflow matchcount.
1495 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1496 * dispextern.h: Adjust decls to match defn changes elsewhere.
1497 (struct text_pos, struct glyph, struct bidi_saved_info)
1498 (struct bidi_string_data, struct bidi_it, struct composition_it)
1499 (struct it):
1500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1501 (struct display_pos, struct composition_it, struct it):
1502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1503 * dispnew.c (increment_matrix_positions)
1504 (increment_row_positions, mode_line_string)
1505 (marginal_area_string):
1506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1507 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1509 (duration_to_sec_usec): New function, to check for overflow better.
1510 (Fsleep_for, sit_for): Use it.
1511 * doc.c (get_doc_string, store_function_docstring):
1512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1513 (get_doc_string, Fsnarf_documentation):
1514 Use int, not EMACS_INT, where int is wide enough.
1515 (get_doc_string):
1516 Use SAFE_ALLOCA, not alloca.
1517 Check for overflow when converting EMACS_INT to off_t.
1518 * doprnt.c (doprnt):
1519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1520 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1521 Don't assume uid_t fits into fixnum.
1522 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1523 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1524 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1525 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1526 (general_insert_function)
1527 (Finsert_char, make_buffer_string, make_buffer_string_both)
1528 (update_buffer_properties, Fbuffer_substring)
1529 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1530 (Fsubst_char_in_region, check_translation)
1531 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1532 (transpose_markers, Ftranspose_regions):
1533 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1534 (clip_to_bounds): Move to lisp.h as an inline function).
1535 (Fconstrain_to_field): Don't assume integers are nonnegative.
1536 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1537 (Fsubst_char_in_region, Fsave_restriction):
1538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1539 (Femacs_pid): Don't assume pid_t fits into fixnum.
1540 (lo_time): Use int, not EMACS_INT, when int suffices.
1541 (lisp_time_argument): Check for usec out of range.
1542 (Fencode_time): Don't assume fixnum fits in int.
1543 (Fuser_login_name, Fuser_full_name): Signal an error
1544 if a uid argument is out of range, rather than relying on
1545 undefined behavior.
1546 (Fformat_time_string): Remove now-unnecessary check.
1547 lisp_time_argument checks for out-of-range usec now.
1548 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1549 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1550 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1551 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1552 (init_cmdargs, Fdump_emacs):
1553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1554 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1555 the bottom (typically) 32 bits of the fixnum.
1556 * eval.c (specpdl_size, call_debugger):
1557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1558 (when_entered_debugger, Fbacktrace_debug):
1559 Don't assume fixnum can fit in int.
1560 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1561 the object just before a buffer; this is not portable.
1562 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1563 (grow_specpdl, unbind_to):
1564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1565 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1566 (grow_specpdl): Simplify allocation by using xpalloc.
1567 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1568 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1569 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1571 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1572 (a_write, e_write):
1573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1574 (Fcopy_file, non_regular_nbytes, read_non_regular)
1575 (Finsert_file_contents):
1576 Use int, not EMACS_INT, where int is wide enough.
1577 (READ_BUF_SIZE): Verify that it fits in int.
1578 (Finsert_file_contents): Check that counts are in proper range,
1579 rather than assuming fixnums fit into ptrdiff_t etc.
1580 Don't assume fixnums fit into int.
1581 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1582 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1583 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1584 (string_char_to_byte, string_byte_to_char)
1585 (string_make_multibyte, string_to_multibyte)
1586 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1587 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1588 (substring_both, Fdelete, internal_equal, Ffillarray)
1589 (Fclear_string, mapcar1)
1590 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1591 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1592 (larger_vector, make_hash_table, maybe_resize_hash_table)
1593 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1594 (Fmaphash, secure_hash):
1595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1596 (concat): Check for string index and length overflow.
1597 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1598 (Frequire):
1599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1600 (larger_vector): New API (vec, incr_min, size_max) replaces old
1601 one (vec, new_size, init). This catches size overflow.
1602 INIT was removed because it was always Qnil.
1603 All callers changed.
1604 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1605 the upper bound on a hash table index size.
1606 (make_hash_table, maybe_resize_hash_table): Use it.
1607 (secure_hash): Computer start_byte and end_byte only after
1608 they're known to be in ptrdiff_t range.
1609 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1610 (Ffont_get_glyphs, Ffont_at):
1611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1612 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1613 (Flist_fonts, Fopen_font):
1614 Don't assume fixnum can fit in int.
1615 (check_gstring): Don't assume index can fit in int.
1616 (font_match_p): Check that fixnum is a character, not a nonnegative
1617 fixnum, since the later code needs to stuff it into an int.
1618 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1619 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1620 conversion overflow issues.
1621 (Fopen_font): Check for integer out of range.
1622 (Ffont_get_glyphs): Don't assume index can fit in int.
1623 * font.h: Adjust decls to match defn changes elsewhere.
1624 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1625 integer overflow.
1626 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1627 printmax_t, where ptrdiff_t is wide enough.
1628 (Finternal_char_font):
1629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1630 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1631 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1632 (Fset_frame_position, x_set_frame_parameters)
1633 (x_set_line_spacing, x_set_border_width)
1634 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1635 Check that fixnums are in proper range for system types.
1636 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1638 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1639 Use SAFE_ALLOCA_LISP, not alloca.
1640 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1641 intptr_t is wide enough.
1642 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1643 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1644 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1645 Check for fixnum out of range.
1646 * ftfont.c (ftfont_list): Don't assume index fits in int.
1647 Check that fixnums are in proper range for system types.
1648 (ftfont_shape_by_flt):
1649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1650 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1652 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1653 Check that fixnums are in proper range for system types.
1654 * gnutls.h: Adjust decls to match defn changes elsewhere.
1655 * gtkutil.c (xg_dialog_run):
1656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1657 (update_frame_tool_bar):
1658 Check that fixnums are in proper range for system types.
1659 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1660 (lookup_image): Check that fixnums are in range for system types.
1661 * indent.c (last_known_column, last_known_column_point):
1662 (current_column_bol_cache):
1663 (skip_invisible, current_column, check_display_width):
1664 (check_display_width, scan_for_column, current_column_1)
1665 (Findent_to, Fcurrent_indentation, position_indentation)
1666 (indented_beyond_p, Fmove_to_column, compute_motion):
1667 (Fcompute_motion, Fvertical_motion):
1668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1669 (last_known_column_modified): Use EMACS_INT, not int.
1670 (check_display_width):
1671 (Fcompute_motion):
1672 Check that fixnums and floats are in proper range for system types.
1673 (compute_motion): Don't assume index or fixnum fits in int.
1674 (compute_motion, Fcompute_motion):
1675 Use int, not EMACS_INT, when it is wide enough.
1676 (vmotion): Omit local var start_hpos that is always 0; that way
1677 we don't need to worry about overflow in expressions involving it.
1678 * indent.h: Adjust decls to match defn changes elsewhere.
1679 (struct position):
1680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1681 Use int, not EMACS_INT, where int is wide enough.
1682 Remove unused members ovstring_chars_done and tab_offset;
1683 all uses removed.
1684 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1685 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1686 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1687 (make_gap, copy_text, insert, insert_and_inherit)
1688 (insert_before_markers, insert_before_markers_and_inherit)
1689 (insert_1, count_combining_before, count_combining_after)
1690 (insert_1_both, insert_from_string)
1691 (insert_from_string_before_markers, insert_from_string_1)
1692 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1693 (adjust_after_replace, adjust_after_insert, replace_range)
1694 (replace_range_2, del_range, del_range_1, del_range_byte)
1695 (del_range_both, del_range_2, modify_region)
1696 (prepare_to_modify_buffer, signal_before_change)
1697 (signal_after_change, Fcombine_after_change_execute):
1698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1699 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1700 (balance_an_interval, split_interval_right, split_interval_left)
1701 (find_interval, next_interval, update_interval)
1702 (adjust_intervals_for_insertion, delete_node, delete_interval)
1703 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1704 (static_offset_intervals, offset_intervals)
1705 (merge_interval_right, merge_interval_left, make_new_interval)
1706 (graft_intervals_into_buffer, temp_set_point_both)
1707 (temp_set_point, set_point, adjust_for_invis_intang)
1708 (set_point_both, move_if_not_intangible, get_property_and_range)
1709 (get_local_map, copy_intervals, copy_intervals_to_string)
1710 (compare_string_intervals, set_intervals_multibyte_1):
1711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1712 * intervals.h: Adjust decls to match defn changes elsewhere.
1713 (struct interval):
1714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1715 * keyboard.c (this_command_key_count, this_single_command_key_start)
1716 (before_command_key_count, before_command_echo_length, echo_now)
1717 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1718 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1719 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1720 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1722 (last_non_minibuf_size, last_point_position, echo_truncate)
1723 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1724 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1725 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1726 (stuff_buffered_input):
1727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1728 (last_auto_save, command_loop_1, read_char):
1729 Use EMACS_INT, not int, to avoid integer overflow.
1730 (record_char): Avoid overflow in total_keys computation.
1731 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1732 * keyboard.h: Adjust decls to match defn changes elsewhere.
1733 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1734 (Fkey_description, Fdescribe_vector, Flookup_key):
1735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1736 (click_position): New function, to check that positions are in range.
1737 (Fcurrent_active_maps):
1738 (describe_command):
1739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1740 (Faccessible_keymaps, Fkey_description):
1741 (preferred_sequence_p):
1742 Don't assume fixnum can fit into int.
1743 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1744 Check for integer overflow in size calculations.
1745 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1746 avoid mishandling large integers.
1747 * lisp.h: Adjust decls to match defn changes elsewhere.
1748 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1749 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1750 (struct Lisp_Marker):
1751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1752 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1753 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1754 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1755 All callers changed.
1756 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1757 Assume the arg has valid form, since it always does.
1758 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1759 unsigned integer system type.
1760 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1761 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1763 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1764 (duration_to_sec_usec): New decl.
1765 * lread.c (read_from_string_index, read_from_string_index_byte)
1766 (read_from_string_limit, readchar, unreadchar, openp)
1767 (read_internal_start, read1, oblookup):
1768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1769 (Fload, readevalloop, Feval_buffer, Feval_region):
1770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1771 (openp): Check for out-of-range argument to 'access'.
1772 (read1): Use int, not EMACS_INT, where int is wide enough.
1773 Don't assume fixnum fits into int.
1774 Fix off-by-one error that can read outside a buffer.
1775 (read_filtered_event): Use duration_to_sec_usec
1776 to do proper overflow checking on durations.
1777 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1778 in size calculation.
1779 (Fexecute_kbd_macro):
1780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1781 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1782 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1783 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1784 (set_marker_both, set_marker_restricted_both, marker_position)
1785 (marker_byte_position, Fbuffer_has_markers_at):
1786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1787 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1788 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1789 It now merely ensures that the menu is large enough, without
1790 necessarily growing it, as this avoids some integer overflow issues.
1791 All callers changed.
1792 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1794 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1795 Use SAFE_ALLOCA_LISP, not alloca.
1796 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1797 to EMACS_INT. Check that fixnums are in proper range for system types.
1798 * minibuf.c (minibuf_prompt_width, string_to_object)
1799 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1800 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1802 (get_minibuffer, read_minibuf_unwind):
1803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1804 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1805 this simplifies overflow checking. All callers changed.
1806 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1807 (Ftest_completion):
1808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1809 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1810 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1811 Check that fixnums are in proper range for system types.
1812 (Fx_create_frame, Fx_show_tip):
1813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1814 * nsfont.m (ns_findfonts, nsfont_list_family):
1815 Don't assume fixnum fits in long.
1816 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1818 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1819 wide enough.
1820 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1822 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1823 (PRINTDECLARE, PRINTPREPARE):
1824 (strout, print_string):
1825 (print, print_preprocess, print_check_string_charset_prop)
1826 (print_object):
1827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1828 (PRINTDECLARE):
1829 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1831 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1832 (printchar, strout): Use xpalloc to catch size calculation overflow.
1833 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1834 (print_error_message): Use SAFE_ALLOCA, not alloca.
1835 (print_object): Use int, not EMACS_INT, where int is wide enough.
1836 (print_depth, new_backquote_output, print_number_index):
1837 Use ptrdiff_t, not int, where int might not be wide enough.
1838 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1839 (Fset_process_window_size, Fformat_network_address)
1840 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1841 (sigchld_handler):
1842 Check that fixnums are in proper range for system types.
1843 (Fsignal_process): Simplify by avoiding a goto.
1844 Check for process-ids out of pid_t range rather than relying on
1845 undefined behavior.
1846 (process_tick, update_tick): Use EMACS_INT, not int.
1847 (Fformat_network_address, read_process_output, send_process)
1848 (Fprocess_send_region, status_notify):
1849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1850 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1851 (wait_reading_process_output, read_process_output, exec_sentinel):
1852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1853 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1854 (Faccept_process_output): Use duration_to_sec_usec to do proper
1855 overflow checking on durations.
1856 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1857 Don't assume pid_t fits in int.
1858 * process.h (struct Lisp_Process): Members tick and update_tick
1859 are now of type EMACS_INT, not int.
1860 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1861 configured --with-wide-int.
1862 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1863 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1864 * search.c (looking_at_1, string_match_1):
1865 (fast_string_match, fast_c_string_match_ignore_case)
1866 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1867 (scan_newline, find_before_next_newline, search_command)
1868 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1869 (set_search_regs, wordify):
1870 (Freplace_match):
1871 (Fmatch_data):
1872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1873 (string_match_1, search_buffer, set_search_regs):
1874 (Fmatch_data):
1875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1876 (wordify): Check for overflow in size calculation.
1877 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1878 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1879 Check that fixnums are in proper range for system types.
1880 * sound.c (struct sound_device)
1881 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1883 (Fplay_sound_internal):
1884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1885 * syntax.c (struct lisp_parse_state, find_start_modiff)
1886 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1887 (Fparse_partial_sexp):
1888 Don't assume fixnums can fit in int.
1889 (struct lisp_parse_state, find_start_pos, find_start_value)
1890 (find_start_value_byte, find_start_begv)
1891 (update_syntax_table, char_quoted, dec_bytepos)
1892 (find_defun_start, prev_char_comend_first, back_comment):
1893 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1894 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1896 (Finternal_describe_syntax_value): Check that match_lisp is a
1897 character, not an integer, since the code stuffs it into int.
1898 (scan_words, scan_sexps_forward):
1899 Check that fixnums are in proper range for system types.
1900 (Fforward_word):
1901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1902 (scan_sexps_forward):
1903 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1904 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1905 * syntax.h: Adjust decls to match defn changes elsewhere.
1906 (struct gl_state_s):
1907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1908 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1909 MOST_POSITIVE_FIXNUM.
1910 * sysdep.c (wait_for_termination_1, wait_for_termination)
1911 (interruptible_wait_for_termination, mkdir):
1912 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1913 (emacs_read, emacs_write):
1914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1915 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1916 and double all fit in int.
1917 * term.c (set_tty_color_mode):
1918 Check that fixnums are in proper range for system types.
1919 * termhooks.h (struct input_event):
1920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1921 * textprop.c (validate_interval_range, interval_of)
1922 (Fadd_text_properties, set_text_properties_1)
1923 (Fremove_text_properties, Fremove_list_of_text_properties)
1924 (Ftext_property_any, Ftext_property_not_all)
1925 (copy_text_properties, text_property_list, extend_property_ranges)
1926 (verify_interval_modification):
1927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1928 (Fnext_single_char_property_change)
1929 (Fprevious_single_char_property_change):
1930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1931 (copy_text_properties):
1932 Check for integer overflow in index calculation.
1933 * undo.c (last_boundary_position, record_point, record_insert)
1934 (record_delete, record_marker_adjustment, record_change)
1935 (record_property_change):
1936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1937 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1939 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1940 (Fx_hide_tip, Fx_file_dialog):
1941 * w32menu.c (set_frame_menubar):
1942 Use ptrdiff_t, not int, for consistency with rest of code.
1943 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1944 (select_window, Fdelete_other_windows_internal)
1945 (window_scroll_pixel_based, window_scroll_line_based)
1946 (Frecenter, Fset_window_configuration):
1947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1948 (Fset_window_hscroll, run_window_configuration_change_hook)
1949 (set_window_buffer, temp_output_buffer_show, scroll_command)
1950 (Fscroll_other_window, Frecenter):
1951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1952 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1953 Don't assume fixnum fits in int.
1954 (Fset_window_scroll_bars):
1955 Check that fixnums are in proper range for system types.
1956 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1957 (string_pos, c_string_pos, number_of_chars, init_iterator)
1958 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1959 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1960 (compute_display_string_end, handle_face_prop)
1961 (face_before_or_after_it_pos, handle_invisible_prop)
1962 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1963 (display_prop_intangible_p, string_buffer_position_lim)
1964 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1965 (get_overlay_strings_1, get_overlay_strings)
1966 (iterate_out_of_display_property, forward_to_next_line_start)
1967 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1968 (get_next_display_element, set_iterator_to_next)
1969 (get_visually_first_element, compute_stop_pos_backwards)
1970 (handle_stop_backwards, next_element_from_buffer)
1971 (move_it_in_display_line_to, move_it_in_display_line)
1972 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1973 (add_to_log, message_dolog, message_log_check_duplicate)
1974 (message2, message2_nolog, message3, message3_nolog
1975 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1976 (current_message_1, truncate_echo_area, truncate_message_1)
1977 (set_message, set_message_1, store_mode_line_noprop)
1978 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1979 (text_outside_line_unchanged_p, check_point_in_composition)
1980 (reconsider_clip_changes)
1981 (redisplay_internal, set_cursor_from_row, try_scrolling)
1982 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1983 (redisplay_window, find_last_unchanged_at_beg_row)
1984 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1985 (trailing_whitespace_p, find_row_edges, display_line)
1986 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1987 (display_mode_element, store_mode_line_string)
1988 (pint2str, pint2hrstr, decode_mode_spec)
1989 (display_count_lines, display_string, draw_glyphs)
1990 (x_produce_glyphs, x_insert_glyphs)
1991 (rows_from_pos_range, mouse_face_from_buffer_pos)
1992 (fast_find_string_pos, mouse_face_from_string_pos)
1993 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1995 (safe_call, init_from_display_pos, handle_fontified_prop)
1996 (handle_single_display_spec, load_overlay_strings)
1997 (with_echo_area_buffer, setup_echo_area_for_printing)
1998 (display_echo_area, echo_area_display)
1999 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2000 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2001 (redisplay_window, dump_glyph_row, display_mode_line)
2002 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2003 (handle_display_spec, display_prop_string_p):
2004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2005 (handle_single_display_spec, build_desired_tool_bar_string)
2006 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2007 (get_specified_cursor_type):
2008 Check that fixnums are in proper range for system types.
2009 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2010 (Flookup_image_map):
2011 Don't assume fixnums fit in int.
2012 (compare_overlay_entries):
2013 Avoid mishandling comparisons due to subtraction overflow.
2014 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2015 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2016 (handle_tool_bar_click):
2017 Use int, not unsigned, since we prefer signed and the signedness
2018 doesn't matter here.
2019 (get_next_display_element, next_element_from_display_vector):
2020 Use int, not EMACS_INT, when int is wide enough.
2021 (start_hourglass): Use duration_to_sec_usec to do proper
2022 overflow checking on durations.
2023 * xfaces.c (Fbitmap_spec_p):
2024 Check that fixnums are in proper range for system types.
2025 (compare_fonts_by_sort_order):
2026 Avoid mishandling comparisons due to subtraction overflow.
2027 (Fx_family_fonts, realize_basic_faces):
2028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2029 (Fx_family_fonts):
2030 Don't assume fixnum fits in int.
2031 Use SAFE_ALLOCA_LISP, not alloca.
2032 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2033 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2034 (face_at_buffer_position, face_for_overlay_string)
2035 (face_at_string_position):
2036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2037 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2038 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2039 (Fx_show_tip):
2040 Check that fixnums are in proper range for system types.
2041 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2042 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2044 (Fx_change_window_property): Don't assume fixnums fit in int.
2045 * xfont.c (xfont_chars_supported):
2046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2047 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2048 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2050 * xml.c (parse_region):
2051 * xrdb.c (magic_file_p):
2052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2053 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2054 (x_get_local_selection, x_reply_selection_request)
2055 (x_handle_selection_request, wait_for_property_change):
2056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2057 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2058 short is wide enough.
2059 (x_send_client_event): Don't assume fixnum fits in int.
2060 * xterm.c (x_x_to_emacs_modifiers):
2061 Don't assume EMACS_INT overflows nicely into int.
2062 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2063 may come from Lisp.
2064 (handle_one_xevent): NATNUMP can eval its arg twice.
2065 (x_connection_closed):
2066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2067 * xterm.h: Adjust decls to match defn changes elsewhere.
2068 (struct scroll_bar): Use struct vectorlike_header
2069 rather than rolling our own approximation.
2070 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2071
2072 2012-05-25 Glenn Morris <rgm@gnu.org>
2073
2074 * lisp.mk (lisp): Update for more files being compiled now.
2075
2076 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2077
2078 * lread.c: Remove `read_pure' which makes no difference.
2079 (read_pure): Remove var.
2080 (unreadpure): Remove function.
2081 (readevalloop): Don't call read_list with -1 flag.
2082 (read1, read_vector): Don't test read_pure any more.
2083 (read_list): Simplify.
2084
2085 * fileio.c, character.h: Minor style tweaks.
2086
2087 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2088
2089 * window.h (clip_changed): Remove useless declaration.
2090
2091 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2094 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2095
2096 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 Remove src/m/*.
2099 This directory predates autoconf and is no longer needed nowadays.
2100 Move its few remaining bits of functionality to where they're needed.
2101 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2102 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2103 * m/template.h: Remove.
2104 * Makefile.in (M_FILE): Remove. All uses removed.
2105 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2106 * lisp.h (USE_LSB_TAG):
2107 * mem-limits.h (EXCEEDS_LISP_PTR):
2108 Use VAL_MAX, not VALBITS, in #if.
2109 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2110 (EMACS_UINT): Define unconditionally now.
2111 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2112 (BITS_PER_EMACS_INT): New constants, replacing
2113 what used to be in config.h, but not useful in #if.
2114 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2115 define them any more.
2116 (VAL_MAX): New macro.
2117 (VALMASK): Use it.
2118 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2119 BITS_PER_EMACS_INT, in #if.
2120 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2121 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2122 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2123 * s/ms-w32.h (DATA_START):
2124 Move here from removed file m/intel386.h.
2125 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2126 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2127
2128 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2129
2130 Assume C89 or later.
2131 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2132 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2133 (xrealloc):
2134 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2135 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2136 * textprop.c, tparam.c (NULL): Remove.
2137 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2138 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2139 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2140 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2141 * xterm.c (input_signal_count): Assume volatile works.
2142
2143 2012-05-21 Ken Brown <kbrown@cornell.edu>
2144
2145 * xgselect.c (xg_select): Fix first argument in call to 'select'
2146 (bug#11508).
2147
2148 2012-05-20 Ken Brown <kbrown@cornell.edu>
2149
2150 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2151 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2152
2153 2012-05-19 Ken Brown <kbrown@cornell.edu>
2154
2155 * xfns.c (x_in_use): Remove `static' qualifier.
2156 * xterm.h (x_in_use): Declare.
2157 * xgselect.c: Include xterm.h.
2158 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2159 and `display_arg' (bug#9754).
2160
2161 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2164
2165 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2166 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2167
2168 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2169
2170 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2171
2172 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2173 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2174
2175 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2176 reference to image_cache->refcount.
2177 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2178
2179 2012-05-17 Juri Linkov <juri@jurta.org>
2180
2181 * search.c (Fword_search_regexp, Fword_search_backward)
2182 (Fword_search_forward, Fword_search_backward_lax)
2183 (Fword_search_forward_lax): Move functions to isearch.el
2184 (bug#10145, bug#11381).
2185
2186 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2189
2190 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2191
2192 * lread.c (init_obarray): Declare Qt and Qnil as special.
2193
2194 2012-05-14 Glenn Morris <rgm@gnu.org>
2195
2196 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2197 Put "libexec" before "bin", for the sake of init_callproc_1.
2198
2199 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2200
2201 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2202
2203 * unexaix.c: Port to more-recent AIX compilers.
2204 (report_error, report_error_1, make_hdr, copy_sym)
2205 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2206 Make arguments const char *, not char *, to avoid violations of C
2207 standard and to fix some AIX warnings reported by Gilles Pion.
2208
2209 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2210
2211 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2212 already have overlays loaded.
2213 (handle_single_display_spec): Before returning without displaying
2214 fringe bitmap, synchronize the bidi iterator with the main display
2215 iterator, by calling iterate_out_of_display_property.
2216 (iterate_out_of_display_property): Detect buffer iteration by
2217 testing that it->string is a Lisp string.
2218 (get_next_display_element): When the current object is exhausted,
2219 and there's something on it->stack, call set_iterator_to_next to
2220 proceed with what's on the stack, instead of returning zero.
2221 (set_iterator_to_next): If called at the end of a Lisp string,
2222 proceed to consider_string_end without incrementing string
2223 position. Don't increment display vector index past the end of
2224 the display vector. (Bug#11417)
2225 (pos_visible_p): Don't report a position visible when move_it_to
2226 stopped at the last line of window, which happens to be scanned
2227 backwards by the bidi iteration. (Bug#11464)
2228
2229 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2230
2231 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2232 and right-margin display specs even if the spec is invalid or we
2233 are on a TTY, and thus unable to display on the fringes.
2234 That's because the text with the property will not be displayed anyway,
2235 so we need to signal to the caller that this is a "replacing"
2236 display spec. This fixes display when the spec is invalid or we
2237 are on a TTY.
2238
2239 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 * unexaix.c (make_hdr): Fix typo in prototype.
2242 This bug broke the build on AIX. Problem reported by Gilles Pion.
2243
2244 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2245
2246 * keyboard.c (kbd_buffer_get_event): Read special events also in
2247 batch mode. (Bug#11415)
2248
2249 2012-05-12 Glenn Morris <rgm@gnu.org>
2250
2251 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2252
2253 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2254
2255 * lisp.mk (lisp): Add newcomment.elc.
2256
2257 2012-05-12 Glenn Morris <rgm@gnu.org>
2258
2259 * Makefile.in (MKDIR_P): New, set by configure.
2260 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2261
2262 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2263
2264 Remove unused function hourglass_started.
2265 * dispextern.h (hourglass_started):
2266 * w32fns.c (hourglass_started):
2267 * xdisp.c (hourglass_started): Remove.
2268
2269 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2270
2271 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2272 Update dependencies.
2273
2274 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 * xgselect.c (xg_select): Put maxfds+1 into a var.
2277 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2278
2279 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2280
2281 2012-05-10 Dave Abrahams <dave@boostpro.com>
2282
2283 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2284 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2285
2286 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2287
2288 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2289 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2290 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2291 Initialize xd_registered_buses.
2292
2293 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 Untag more efficiently if USE_LSB_TAG.
2296 This is based on a proposal by YAMAMOTO Mitsuharu in
2297 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2298 For an admittedly artificial (nth 8000 longlist) benchmark on
2299 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2300 Emacs's overall text size by 1%.
2301 * lisp.h (XUNTAG): New macro.
2302 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2303 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2304 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2305 * eval.c (Fautoload):
2306 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2307 * frame.h (XFRAME): Use XUNTAG.
2308
2309 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2310 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2311 Remove unportable assumptions about print widths of types like
2312 dbus_uint32_t.
2313 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2314 intptr_t when converting between pointer and integer, to avoid GCC
2315 warnings about wrong width.
2316
2317 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2318
2319 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2320 stack for each reader_thread, instead of defaulting to 8MB
2321 determined by the linker. This avoids failures in creating
2322 subprocesses on Windows 7, see the discussion in this thread:
2323 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2324
2325 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2326
2327 Fix up display of the *Minibuf-0* buffer in the mini window.
2328 * keyboard.c (read_char): Don't clear the echo area if there's no
2329 message to clear.
2330 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2331 contents of *Minibuf-0*) if there's no message displayed in its stead.
2332
2333 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2334
2335 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2336 batch mode.
2337
2338 2012-05-06 Chong Yidong <cyd@gnu.org>
2339
2340 * lisp.mk (lisp): Update.
2341
2342 2012-05-05 Jim Meyering <meyering@redhat.com>
2343
2344 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2345
2346 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2347
2348 * data.c (PUT_ERROR): New macro.
2349 (syms_of_data): Use it. Add new error type `user-error'.
2350 * undo.c (user_error): New function.
2351 (Fprimitive_undo): Use it.
2352 * print.c (print_error_message): Adjust print style for `user-error'.
2353 * keyboard.c (user_error): New function.
2354 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2355
2356 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2357
2358 Do not limit current-time-string to years 1000..9999.
2359 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2360 (Fcurrent_time_string): Support any year that is supported by the
2361 underlying localtime representation. Don't use asctime, as it
2362 has undefined behavior for years outside the range -999..9999.
2363
2364 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2365
2366 Fix race conditions involving setenv, gmtime, localtime, asctime.
2367 Without this fix, interrupts could mess up code that uses these
2368 nonreentrant functions, since setting TZ invalidates existing
2369 tm_zone or tzname values, and since most of these functions return
2370 pointers to static storage.
2371 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2372 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2373 Grow the critical sections to include not just invoking
2374 localtime/gmtime, but also accessing these functions' results
2375 including their tm_zone values if any, and any related TZ setting.
2376 (format_time_string): Last arg is now struct tm *, not struct tm **,
2377 so that the struct tm is saved in the critical section.
2378 All callers changed. Simplify allocation of initial buffer, partly
2379 motivated by the fact that memory allocation needs to be outside
2380 the critical section.
2381
2382 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2383
2384 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2385 with RESET_INTERVAL.
2386
2387 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2388 Remove duplicated buffer name initialization.
2389
2390 2012-05-02 Jim Meyering <jim@meyering.net>
2391
2392 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2393
2394 * xfns.c (x_window): Use xstrdup (Bug#11375).
2395
2396 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2397
2398 * xdisp.c (pos_visible_p): If already at a newline from the
2399 display string before the 'while' loop, don't walk back the glyphs
2400 from it3.glyph_row. Solves assertion violation when the display
2401 string begins with a newline (egg.el). (Bug#11367)
2402
2403 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2404
2405 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2406 Move to simple.el.
2407
2408 2012-05-01 Glenn Morris <rgm@gnu.org>
2409
2410 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2411 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2412 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2413 All were removed before 23.1.
2414
2415 * dispnew.c: Remove HAVE_LIBNCURSES test;
2416 it is always true on relevant platforms.
2417
2418 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2419 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2420
2421 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2422
2423 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2424
2425 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2426 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2427 Remove.
2428
2429 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 Do not avoid creating empty evaporating overlays (Bug#9642).
2432 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2433 That is, do not delete an evaporating overlay if it becomes
2434 empty after its bounds are adjusted to fit within its buffer.
2435 This fix caused other problems, and I'm reverting it until we get
2436 to the bottom of them.
2437
2438 2012-04-27 Chong Yidong <cyd@gnu.org>
2439
2440 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2441
2442 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2443
2444 * xdisp.c (pos_visible_p): If the window start position is beyond
2445 ZV, start the display from buffer beginning. Prevents assertion
2446 violation in init_iterator when the minibuffer window is scrolled
2447 via the scroll bar.
2448
2449 * window.c (window_scroll_pixel_based): Likewise.
2450
2451 2012-04-27 Chong Yidong <cyd@gnu.org>
2452
2453 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2454
2455 2012-04-27 Glenn Morris <rgm@gnu.org>
2456
2457 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2458 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2459
2460 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2461
2462 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2463 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2464
2465 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2466
2467 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2468 display element, check also the underlying string or buffer
2469 character. (Bug#11341)
2470
2471 * w32menu.c: Include w32heap.h.
2472 (add_menu_item): If the call to AppendMenuW (via
2473 unicode_append_menu) fails, disable Unicode menus only if we are
2474 running on Windows 9X/Me.
2475
2476 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2477
2478 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2479 (xgetint): Add missing shift for LSB tags.
2480
2481 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2482
2483 * keyboard.c (read_char): Don't wipe echo area for select window
2484 events: These might get delayed via `mouse-autoselect-window'
2485 (Bug#11304).
2486
2487 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2488
2489 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2490 manipulation of :loaded-from data.
2491
2492 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2493
2494 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2495 now a cons (bug#11311).
2496
2497 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 Do not create empty overlays with the evaporate property (Bug#9642).
2500 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2501 if it becomes empty after its bounds are adjusted to fit within
2502 its buffer. Without this fix, in a nonempty buffer (let ((o
2503 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2504 yields an empty overlay that has the evaporate property, which is
2505 not supposed to happen.
2506
2507 Fix minor GTK3 problems found by static checking.
2508 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2509 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2510 (struct _EmacsFixedClass, emacs_fixed_get_type):
2511 Move decls here from emacsgtkfixed.h, since they needn't be public.
2512 (emacs_fixed_get_type): Now static.
2513 (emacs_fixed_class_init): Omit unused local.
2514 (emacs_fixed_child_type): Remove; unused.
2515 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2516 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2517 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2518 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2519 (EMACS_FIXED_GET_CLASS): Remove; unused.
2520 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2521
2522 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2523 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2524
2525 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2528 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2529 (__malloc_size_t, __malloc_ptrdiff_t):
2530 Remove. All uses removed, replaced by the definiens if needed,
2531 since we can assume C89 or better now.
2532 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2533 (protect_malloc_state, align, get_contiguous_space)
2534 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2535 (malloc_atfork_handler_child, malloc_enable_thread)
2536 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2537 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2538 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2539 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2540 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2541 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2542 Define using prototypes, not old style.
2543 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2544 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2545 (align): Don't assume that signed integer overflow wraps around.
2546 Omit unused local var.
2547 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2548 (_free_internal_nolock, memalign, mallochook, reallochook):
2549 Omit no-longer-needed casts.
2550 (valloc): Use getpagesize, not __getpagesize.
2551 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2552 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2553
2554 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2555
2556 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2557
2558 Move functions from C to Lisp. Make non-blocking method calls
2559 the default. Implement further D-Bus standard interfaces.
2560
2561 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2562 (QCdbus_request_name_allow_replacement)
2563 (QCdbus_request_name_replace_existing)
2564 (QCdbus_request_name_do_not_queue)
2565 (QCdbus_request_name_reply_primary_owner)
2566 (QCdbus_request_name_reply_in_queue)
2567 (QCdbus_request_name_reply_exists)
2568 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2569 (QCdbus_registered_serial, QCdbus_registered_method)
2570 (QCdbus_registered_signal): New Lisp objects.
2571 (XD_DEBUG_MESSAGE): Use sizeof.
2572 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2573 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2574 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2575 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2576 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2577 (xd_signature, xd_append_arg): Allow float for integer types.
2578 (xd_get_connection_references): New function.
2579 (xd_get_connection_address): Rename from xd_initialize.
2580 Return cached address.
2581 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2582 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2583 level.
2584 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2585 Return number of refcounts.
2586 (Fdbus_get_unique_name): Make stronger parameter check.
2587 (Fdbus_message_internal): New defun.
2588 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2589 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2590 (Fdbus_send_signal, Fdbus_register_service)
2591 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2592 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2593 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2594 (Vdbus_compiled_version, Vdbus_runtime_version)
2595 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2596 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2597 (Vdbus_message_type_signal): New defvars.
2598 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2599 Adapt docstring.
2600
2601 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2604 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2605 Do not assume ptrdiff_t is the same width as 'int'.
2606
2607 * alloc.c: Handle unusual debugging option combinations.
2608 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2609 since the two debugging options are incompatible.
2610 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2611 is defined.
2612 (mem_init, mem_insert, mem_insert_fixup):
2613 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2614 (NEED_MEM_INSERT): Remove; no longer needed.
2615
2616 2012-04-22 Leo Liu <sdl.web@gmail.com>
2617
2618 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2619
2620 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2621
2622 * sysdep.c [__FreeBSD__]: Minor cleanups.
2623 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2624 Use Emacs indenting style more consistently. Avoid some casts.
2625 Use 'double' consistently rather than mixing 'float' and 'double'.
2626
2627 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2628
2629 * sysdep.c (list_system_processes, system_process_attributes):
2630 Add implementation for FreeBSD (Bug#5243).
2631
2632 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2633
2634 * lisp.mk (lisp): Update.
2635
2636 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2639 It is never used otherwise.
2640
2641 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2642
2643 * print.c (print_preprocess): Only check print_depth if print-circle
2644 is nil.
2645 (print_object): Check for cycles even when print-circle is nil and
2646 print-gensym is t, but only check print_depth if print-circle is nil.
2647
2648 2012-04-20 Chong Yidong <cyd@gnu.org>
2649
2650 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2651 set the status to "failed" and ensure that sentinel is run.
2652
2653 2012-04-20 Glenn Morris <rgm@gnu.org>
2654
2655 * process.c (Fset_process_inherit_coding_system_flag)
2656 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2657 (Fmake_network_process, Fmake_serial_process): Doc fix.
2658
2659 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2660
2661 * xdisp.c (string_buffer_position_lim): Limit starting position to
2662 BEGV.
2663 (set_cursor_from_row): If called for a mode-line or header-line
2664 row, return zero immediately.
2665 (try_cursor_movement): If inside continuation line, don't back up
2666 farther than the first row after the header line, if any.
2667 Don't consider the header-line row as "partially visible", even if
2668 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2669
2670 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2671
2672 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2673 (bug#11238).
2674
2675 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2676 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 configure: new option --enable-gcc-warnings (Bug#11207)
2679 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2680 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2681 (ALL_CFLAGS): Use new macros rather than old.
2682 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2683 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2684 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2685 -Wunused-result, -Wunused-variable. This should go away once
2686 the Emacs and Gnulib regex code is merged.
2687 (xmalloc, xrealloc): Now static.
2688
2689 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2690
2691 * dired.c (Fsystem_groups): Remove unused local.
2692
2693 2012-04-17 Glenn Morris <rgm@gnu.org>
2694
2695 * dired.c (Fsystem_users): Doc fix.
2696
2697 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2698
2699 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2700 (syms_of_dired): Add them.
2701
2702 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 Fix minor alloc.c problems found by static checking.
2705 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2706 New extern decls, to avoid calling undeclared functions.
2707 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2708 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2709 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2710 (NEED_MEM_INSERT): New macro.
2711 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2712 Remove one incorrect comment and fix another.
2713
2714 Fix minor ralloc.c problems found by static checking.
2715 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2716 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2717 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2718 (r_alloc_sbrk): Now static.
2719
2720 Improve ralloc.c interface checking.
2721 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2722 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2723 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2724 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2725 [REL_ALLOC]: ... to here, to check interface.
2726 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2727 Remove decls. This fixes an "It stinks!".
2728
2729 * alloc.c (which_symbols): Fix alignment issue / type clash.
2730
2731 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2732
2733 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2734 (struct Lisp_Misc_Any): Likewise.
2735 (struct Lisp_Free): Likewise.
2736 * alloc.c (union aligned_Lisp_Symbol): Define.
2737 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2738 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2739 (union aligned_Lisp_Misc): Define.
2740 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2741 aligned_Lisp_Misc instead of union Lisp_Misc.
2742 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2743
2744 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2747 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2748 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2749 * s/netbsd.h, s/sol2-6.h:
2750 Remove definition of GC_MARK_STACK, since the default now works.
2751 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2752 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2753 no longer the default.
2754 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2755
2756 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2757
2758 * lread.c (lisp_file_lexically_bound_p):
2759 Fix hang at ";-*-\n" (bug#11238).
2760
2761 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2762
2763 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2764 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2765
2766 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2767
2768 * nsterm.m (constrainFrameRect): Always constrain when there is only
2769 one screen (Bug#10962).
2770
2771 2012-04-13 Ken Brown <kbrown@cornell.edu>
2772
2773 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2774
2775 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2776
2777 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2778
2779 2012-04-11 Daniel Colascione <dancol@dancol.org>
2780
2781 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2782 against is gone. It's better to use vfork now so that when Cygwin
2783 gains a new, working vfork, we use it automatically (bug#10398).
2784
2785 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2786
2787 * window.c (save_window_save): Obey window-point-insertion-type.
2788
2789 2012-04-11 Glenn Morris <rgm@gnu.org>
2790
2791 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2792
2793 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2794
2795 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2796
2797 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2798
2799 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2800 (force_quit_count): New var.
2801 (handle_interrupt): Use it.
2802
2803 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * w32.c (w32_delayed_load): Record the full path of the library
2806 being loaded (bug#10424).
2807
2808 2012-04-09 Glenn Morris <rgm@gnu.org>
2809
2810 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2811 not just in the obarray, before snarfing them. (Bug#11036)
2812
2813 * Makefile.in ($(leimdir)/leim-list.el):
2814 Pass EMACS rather than BUILT_EMACS.
2815
2816 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2817
2818 * process.c (make_process):
2819 * process.h: Add integer `gnutls_handshakes_tried' member to
2820 process struct.
2821
2822 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2823 Add convenience `GNUTLS_LOG2i' macro.
2824
2825 * gnutls.c (gnutls_log_function2i): Convenience log function.
2826 (emacs_gnutls_read): Use new log functions,
2827 `gnutls_handshakes_tried' process member, and
2828 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2829 attempts per process (connection).
2830
2831 2012-04-09 Chong Yidong <cyd@gnu.org>
2832
2833 * eval.c (Fuser_variable_p, user_variable_p_eh)
2834 (lisp_indirect_variable): Functions deleted.
2835 (Fdefvar): Caller changed.
2836
2837 * callint.c (Finteractive, Fcall_interactively):
2838 * minibuf.c (Fread_variable): Callers changed.
2839
2840 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2841
2842 * xdisp.c (set_cursor_from_row): If the display string appears in
2843 the buffer at position that is closer to point than the position
2844 after the display string, display the cursor on the first glyph of
2845 the display string. Fixes cursor display when a 'display' text
2846 property immediately follows invisible text. (Bug#11094)
2847
2848 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2849
2850 composite.c: use 'double' consistently
2851 * composite.c (get_composition_id): Use 'double' consistently
2852 instead of converting 'float' to 'double' and vice versa; this is
2853 easier to understand and avoids a GCC warning.
2854
2855 2012-04-09 Glenn Morris <rgm@gnu.org>
2856
2857 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2858 preparation for dumping it with emacs. (Bug#4789)
2859 (leimdir): New variable.
2860 ($(leimdir)/leim-list.el): New rule.
2861 (emacs$(EXEEXT)): Depend on leim-list.el.
2862
2863 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2864 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2865 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2866
2867 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2868
2869 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2870 proper alignment.
2871
2872 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2873
2874 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2875 Remove unused local variable.
2876
2877 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2880 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2881 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2882 objects, as mark_maybe_pointer will catch them otherwise.
2883 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2884 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2885
2886 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2887
2888 Fix typo that broke non-Windows builds.
2889 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2890
2891 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2892
2893 Support building on MS-Windows with libxml2.
2894
2895 * makefile.w32-in (OBJ2): Add xml.$(O).
2896 (GLOBAL_SOURCES): Add xml.c.
2897 ($(BLD)/xml.$(O)): New dependency list.
2898
2899 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2900 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2901 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2902 [!WINDOWSNT]: New macros.
2903 (init_libxml2_functions, libxml2_loaded_p): New functions.
2904 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2905 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2906 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2907 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2908 linked in).
2909 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2910 Call init_libxml2_functions before calling libxml2 functions.
2911 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2912
2913 * emacs.c: Don't include libxml/parser.h.
2914 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2915 xmlCleanupParser directly.
2916
2917 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2918
2919 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2920
2921 * indent.c (Fvertical_motion): If there is a display string at
2922 point, use it.vpos to compute how many lines to backtrack after
2923 move_it_to point. (Bug#11133)
2924
2925 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2926
2927 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2928 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2929 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2930 macros related to unification of CJK characters. For the details,
2931 see the discussion following the message here:
2932 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2933
2934 2012-04-04 Chong Yidong <cyd@gnu.org>
2935
2936 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2937
2938 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2939
2940 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2941 instead of alloca. (Bug#11138)
2942
2943 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2944
2945 * w32menu.c (is_simple_dialog): Properly check lisp types.
2946 (Bug#11141)
2947
2948 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2949
2950 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2951 position we get to after a call to move_it_to fails the
2952 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2953 only if we wind up in a string from display property. (Bug#11063)
2954
2955 * window.c (Fdelete_other_windows_internal): Invalidate the row
2956 and column information about mouse highlight, so that redisplay
2957 restores it after reallocating the glyph matrices. (Bug#7464)
2958
2959 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2960 string comes from a `display' text property, use the buffer
2961 position of that property as if we actually saw that position in
2962 the row's glyphs.
2963 (move_it_by_lines): Remove the assertion that
2964 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2965 violated when there's a before-string at the beginning of a line.
2966 (Bug#11063)
2967
2968 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2969
2970 * xdisp.c (append_space_for_newline): If the default face was
2971 remapped, use the remapped face for the appended newline.
2972 (extend_face_to_end_of_line): Use the remapped default face for
2973 extending the face to the end of the line.
2974 (display_line): Call extend_face_to_end_of_line when the default
2975 face was remapped. (Bug#11068)
2976
2977 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2978
2979 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2980
2981 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2982
2983 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2984
2985 2012-03-27 Glenn Morris <rgm@gnu.org>
2986
2987 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2988 Doc fixes.
2989
2990 2012-03-26 Kenichi Handa <handa@m17n.org>
2991
2992 * dispextern.h (struct glyph): Fix previous change. Change the
2993 bit length of glyphless.ch to 25 (Bug#11082).
2994
2995 2012-03-26 Chong Yidong <cyd@gnu.org>
2996
2997 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2998 (command_loop_1): Use it; inhibit selection update for
2999 handle-select-window too (Bug#8996).
3000
3001 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3002
3003 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3004
3005 2012-03-25 Kenichi Handa <handa@m17n.org>
3006
3007 * dispextern.h (struct glyph): Change the bit length of
3008 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3009
3010 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3011
3012 * s/ms-w32.h (tzname): Include time.h before redirecting to
3013 _tzname. Fixes the MSVC build. (Bug#9960)
3014
3015 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3016
3017 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3018 characters.
3019
3020 * xterm.c (XTread_socket): Only modify handling_signal if
3021 !SYNC_INPUT. (Bug#11080)
3022
3023 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3024
3025 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3026 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3027 when fetching a multibyte character consumes more bytes than
3028 CHAR_BYTES returns, due to unification of CJK characters in
3029 string_char. (Bug#11073)
3030
3031 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3032
3033 * process.c (wait_reading_process_output): Handle pty disconnect
3034 by refraining from sending oneself a SIGCHLD (bug#10933).
3035
3036 2012-03-22 Chong Yidong <cyd@gnu.org>
3037
3038 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3039
3040 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3041 Mark string as coming from a prefix property.
3042 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3043 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3044
3045 2012-03-21 Chong Yidong <cyd@gnu.org>
3046
3047 * xfaces.c (Vface_remapping_alist): Doc fix.
3048
3049 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3050
3051 * w32proc.c (Fw32_set_console_codepage)
3052 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3053 Doc fixes.
3054
3055 2012-03-20 Chong Yidong <cyd@gnu.org>
3056
3057 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3058 to reflect default non-nil value of redisplay-dont-pause.
3059
3060 2012-03-19 Kenichi Handa <handa@m17n.org>
3061
3062 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3063 it fit in a valid range (Bug#11003).
3064
3065 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3066
3067 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3068 that is not from display property, accept the row as a "cursor
3069 row" if one of the string's character has a non-nil `cursor'
3070 property. Fixes cursor positioning when there are newlines in
3071 overlay strings, e.g. in icomplete.el. (Bug#11035)
3072
3073 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3076
3077 2012-03-12 Chong Yidong <cyd@gnu.org>
3078
3079 * eval.c (inhibit_lisp_code): Rename from
3080 inhibit_window_configuration_change_hook; move from window.c.
3081
3082 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3083 * window.c (run_window_configuration_change_hook)
3084 (syms_of_window): Callers changed.
3085
3086 2012-03-11 Chong Yidong <cyd@gnu.org>
3087
3088 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3089
3090 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3091
3092 2012-03-10 Chong Yidong <cyd@gnu.org>
3093
3094 * frame.c (other_visible_frames): Don't assume the selected frame
3095 is visible (Bug#10955).
3096
3097 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3098
3099 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3100
3101 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3102
3103 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3104 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3105 zero (Bug#10954).
3106
3107 2012-03-03 Glenn Morris <rgm@gnu.org>
3108
3109 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3110
3111 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3112
3113 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3114 position past the first glyph_row that ends at ZV. (Bug#10902)
3115 (redisplay_window, next_element_from_string): Fix typos in
3116 comments.
3117 (redisplay_window): Pass to move_it_vertically the margin in
3118 pixels, not in screen lines.
3119
3120 2012-03-02 Glenn Morris <rgm@gnu.org>
3121
3122 * buffer.c (buffer-list-update-hook): Doc fix.
3123
3124 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3125
3126 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3127 push_it before setting up the iterator for the first overlay
3128 string, even if we have an empty string loaded.
3129 (next_overlay_string): If there's an empty string on the iterator
3130 stack, pop the stack. (Bug#10903)
3131
3132 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3133
3134 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3135 Suggested by Stefan Monnier in
3136 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3137 * alloc.c (widen_to_Lisp_Object): New static function.
3138 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3139 and widening them to Lisp_Objects. This would work even if
3140 USE_LSB_TAG is defined and wide integers are used, which might
3141 happen in a future version of Emacs.
3142
3143 2012-02-25 Chong Yidong <cyd@gnu.org>
3144
3145 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3146 Doc fix.
3147
3148 * xselect.c (Fx_selection_exists_p): Doc fix.
3149 (x_clipboard_manager_save_all): Print an informative message
3150 before saving to clipboard manager.
3151
3152 2012-02-24 Chong Yidong <cyd@gnu.org>
3153
3154 * keyboard.c (process_special_events): Handle all X selection
3155 requests in kbd_buffer, not just the next one (Bug#8869).
3156
3157 2012-02-23 Chong Yidong <cyd@gnu.org>
3158
3159 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3160 call when setting menu-bar-lines and tool-bar-lines parameters.
3161 (unwind_create_frame_1): New helper function.
3162
3163 * window.c (inhibit_window_configuration_change_hook): New var.
3164 (run_window_configuration_change_hook): Obey it.
3165 (syms_of_window): Initialize it.
3166
3167 2012-02-22 Chong Yidong <cyd@gnu.org>
3168
3169 * xterm.c (x_draw_image_relief): Add missing type check for
3170 Vtool_bar_button_margin (Bug#10743).
3171
3172 2012-02-21 Chong Yidong <cyd@gnu.org>
3173
3174 * fileio.c (Vfile_name_handler_alist): Doc fix.
3175
3176 * buffer.c (Fget_file_buffer): Protect against invalid file
3177 handler return value.
3178
3179 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3182 when computing $valmask.
3183
3184 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3185 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3186 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3187 It's useless in that case, and it can cause problems on hosts
3188 that allocate halves of EMACS_INT values separately.
3189 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3190 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3191 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3192 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3193 it avoids undefined behavior on hosts where shifting right by more
3194 than the word width has undefined behavior.
3195
3196 2012-02-19 Chong Yidong <cyd@gnu.org>
3197
3198 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3199 (Funhandled_file_name_directory, Ffile_name_as_directory)
3200 (Fdirectory_file_name, Fexpand_file_name)
3201 (Fsubstitute_in_file_name): Protect against invalid file handler
3202 return values (Bug#10845).
3203
3204 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3205
3206 * .gdbinit (pitx): Fix incorrect references to fields of the
3207 iterator stack.
3208
3209 2012-02-17 Chong Yidong <cyd@gnu.org>
3210
3211 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3212
3213 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3214
3215 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3216 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3217
3218 2012-02-15 Chong Yidong <cyd@gnu.org>
3219
3220 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3221 marked as special. Also, starting docstrings with * is obsolete.
3222
3223 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3224
3225 * gnutls.c (emacs_gnutls_write): Fix last change.
3226
3227 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3228
3229 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3230 send_process.
3231
3232 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3233
3234 * keymap.c (Fsingle_key_description): Handle char ranges.
3235
3236 2012-02-12 Chong Yidong <cyd@gnu.org>
3237
3238 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3239 as that creates a dangerous corner case.
3240
3241 * window.c (Fdelete_window_internal): Invalidate the mouse
3242 highlight (Bug#9904).
3243
3244 2012-02-12 Glenn Morris <rgm@gnu.org>
3245
3246 * xselect.c (Fx_own_selection_internal)
3247 (Fx_get_selection_internal, Fx_disown_selection_internal)
3248 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3249 * nsselect.m (Fx_own_selection_internal)
3250 (Fx_disown_selection_internal, Fx_selection_exists_p)
3251 (Fx_selection_owner_p, Fx_get_selection_internal):
3252 Sync docs and argument specs with the xselect.c versions.
3253
3254 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3255
3256 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3257
3258 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3259
3260 * w32select.c (Fx_selection_exists_p): Sync doc string and
3261 argument list with xselect.c. (Bug#10783)
3262
3263 * w16select.c (Fx_selection_exists_p): Sync doc string and
3264 argument list with xselect.c. (Bug#10783)
3265
3266 2012-02-10 Glenn Morris <rgm@gnu.org>
3267
3268 * fns.c (Fsecure_hash): Doc fix.
3269
3270 2012-02-09 Kenichi Handa <handa@m17n.org>
3271
3272 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3273
3274 2012-02-07 Chong Yidong <cyd@gnu.org>
3275
3276 * buffer.c (Fbuffer_local_variables)
3277 (buffer_lisp_local_variables): Handle unbound vars correctly;
3278 don't let Qunbound leak into Lisp.
3279
3280 2012-02-07 Glenn Morris <rgm@gnu.org>
3281
3282 * image.c (Fimagemagick_types): Doc fix.
3283
3284 * image.c (imagemagick-render-type): Change it from a lisp object
3285 to an integer. Move the doc here from the lisp manual.
3286 Treat all values not equal to 0 the same.
3287
3288 2012-02-06 Chong Yidong <cyd@gnu.org>
3289
3290 * doc.c (store_function_docstring): Avoid applying docstring of
3291 alias to base function (Bug#2603).
3292
3293 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3294
3295 * .gdbinit (pp1, pv1): Remove redundant defines.
3296 (pr): Use pp.
3297
3298 2012-02-04 Chong Yidong <cyd@gnu.org>
3299
3300 * nsterm.m: Declare a global (Bug#10694).
3301
3302 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3303
3304 * w32.c (get_emacs_configuration_options):
3305 Include --enable-checking, if specified, in the return value.
3306
3307 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3308
3309 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3310 after rounding frame sizes. (Bug#9723)
3311
3312 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3313
3314 * keyboard.c (adjust_point_for_property): Don't position point
3315 before BEGV. (Bug#10696)
3316
3317 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 Handle overflow when computing char display width (Bug#9496).
3320 * character.c (char_width): Return EMACS_INT, not int.
3321 (char_width, c_string_width): Check for overflow when
3322 computing the width; this is possible now that individual
3323 characters can have unbounded width. Problem introduced
3324 by merge from Emacs 23 on 2012-01-19.
3325
3326 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3327
3328 * dbusbind.c (Fdbus_register_method): Mention the return value
3329 :ignore in the docstring.
3330
3331 2012-02-02 Glenn Morris <rgm@gnu.org>
3332
3333 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3334
3335 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3336 Unconditionally set to t. (Bug#10673)
3337 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3338 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3339 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3340
3341 2012-02-02 Kenichi Handa <handa@m17n.org>
3342
3343 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3344 0, do not call append_composite_glyph.
3345
3346 2012-02-02 Kenichi Handa <handa@m17n.org>
3347
3348 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3349 NULL (Bug#6988).
3350 (x_produce_glyphs): If the component of a composition is a null
3351 string, set it->pixel_width to 1 to avoid zero-width glyph.
3352
3353 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3354
3355 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3356 first 2 arguments are identical. This makes inserting large
3357 output from a subprocess an order of magnitude faster on
3358 MS-Windows, where all sbrk'ed memory is always contiguous.
3359
3360 2012-01-31 Glenn Morris <rgm@gnu.org>
3361
3362 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3363 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3364 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3365
3366 2012-01-29 Glenn Morris <rgm@gnu.org>
3367
3368 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3369
3370 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3371
3372 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3373
3374 2012-01-28 Chong Yidong <cyd@gnu.org>
3375
3376 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3377
3378 2012-01-26 Chong Yidong <cyd@gnu.org>
3379
3380 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3381
3382 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3383 repeat counts (Bug#10507).
3384
3385 2012-01-26 Glenn Morris <rgm@gnu.org>
3386
3387 * lread.c (syms_of_lread): Doc fix.
3388
3389 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3390
3391 * coding.c (encode_designation_at_bol): Change return value to
3392 EMACS_INT.
3393
3394 2012-01-25 Chong Yidong <cyd@gnu.org>
3395
3396 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3397
3398 2012-01-21 Chong Yidong <cyd@gnu.org>
3399
3400 * floatfns.c (Fcopysign): Make the second argument non-optional,
3401 since nil is not allowed anyway.
3402
3403 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3404
3405 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3406 (send_process): Likewise.
3407
3408 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3409
3410 * window.c (save_window_save, Fcurrent_window_configuration)
3411 (Vwindow_persistent_parameters): Do not use Qstate.
3412 Rewrite doc-strings.
3413
3414 2012-01-19 Kenichi Handa <handa@m17n.org>
3415
3416 * character.c (char_width): New function.
3417 (Fchar_width, c_string_width, lisp_string_width):
3418 Use char_width (Bug#9496).
3419
3420 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3421
3422 * window.c (Vwindow_persistent_parameters): New variable.
3423 (Fset_window_configuration, save_window_save): Handle persistent
3424 window parameters.
3425
3426 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3427
3428 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3429 thrashing the stack of the thread. (Bug#9087)
3430
3431 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3432
3433 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3434
3435 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3436
3437 * xdisp.c (rows_from_pos_range): Handle the case where the
3438 highlight ends on a newline. (Bug#10464)
3439 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3440 he end column for display of highlight that ends on a newline
3441 before a R2L line.
3442
3443 2012-01-11 Glenn Morris <rgm@gnu.org>
3444
3445 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3446 from load-path also when installation-directory is nil. (Bug#10208)
3447
3448 2012-01-10 Glenn Morris <rgm@gnu.org>
3449
3450 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3451
3452 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3453 Update template values to be closer to their typical values these days.
3454
3455 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3456
3457 * xdisp.c (rows_from_pos_range): Accept additional argument
3458 DISP_STRING, and accept any glyph in a row whose object is that
3459 string as eligible for mouse highlight. Fixes mouse highlight of
3460 display strings from overlays. (Bug#10464)
3461
3462 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3463
3464 emacs: fix an auto-save permissions race condition (Bug#10400)
3465 * fileio.c (auto_saving_dir_umask): New static var.
3466 (Fmake_directory_internal): Use it.
3467 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3468 creating the directory. The old code temporarily assigns
3469 too-generous permissions to the directory.
3470 (do_auto_save_eh): Clear it.
3471 (Fdo_auto_save): Catch all errors, not just file errors, so
3472 that the var is always cleared.
3473
3474 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3475
3476 * search.c (scan_buffer): Pass character positions to
3477 know_region_cache, not byte positions. (Bug#6540)
3478
3479 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3480
3481 * w32.c (sys_rename): Report EXDEV when rename of a directory
3482 fails because the target is on another logical disk. (Bug#10284)
3483
3484 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3485
3486 * xterm.c (x_embed_request_focus): New function.
3487
3488 * xterm.h: Add prototype.
3489
3490 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3491
3492 2012-01-05 Glenn Morris <rgm@gnu.org>
3493
3494 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3495
3496 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3497
3498 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3499 Load gnutls_transport_set_lowat only if GnuTLS version is below
3500 2.11.1.
3501 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3502 GnuTLS versions below 2.11.1.
3503
3504 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3505
3506 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3507 to the doc string advising against its use for altering the way
3508 windows are scrolled.
3509
3510 2011-12-28 Kenichi Handa <handa@m17n.org>
3511
3512 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3513 coding-system ASCII compatible only when it does not produce BOM
3514 on encoding (Bug#10383).
3515
3516 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3517
3518 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3519 can scroll.
3520 (create_and_show_popup_menu): Always use menu_position_func for
3521 Gtk3 (Bug#10361).
3522
3523 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3524
3525 * callint.c (Fcall_interactively): Don't truncate prompt string.
3526
3527 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3528
3529 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3530 property that ends at ZV, so that the bidi iteration could be
3531 resumed from there (after widening). (Bug#10360)
3532
3533 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3534
3535 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3536
3537 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3538
3539 * nsterm.m (x_free_frame_resources):
3540 Release f->output_data.ns->miniimage.
3541 (ns_index_color): Fix indentation. Do not retain
3542 color_table->colors[i].
3543
3544 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3545 before returning.
3546
3547 * nsfns.m (x_set_background_color): Assign return value from
3548 ns_index_color to face-background instead of NSColor*.
3549 (ns_implicitly_set_icon_type): Fix indentation.
3550 Change assignment in for loop to comparison.
3551
3552 * emacs.c (ns_pool): New variable.
3553 (main): Assign ns_pool.
3554 (Fkill_emacs): Call ns_release_autorelease_pool.
3555
3556 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3557 autorelease fdesc, release fdAttrs and tdict.
3558 (ns_get_covering_families): Release charset.
3559 (ns_findfonts): Release NSFontDescriptor created with new.
3560 (ns_uni_to_glyphs): Fix indentation.
3561 (setString): Release attrStr before assigning new value.
3562
3563 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3564
3565 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3566 and NS_IMPL_COCOA.
3567 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3568 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3569
3570 2011-12-18 David Reitter <reitter@cmu.edu>
3571
3572 * nsterm.m (ns_term_init): Subscribe for notifications
3573 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3574 to method trackingNotification in EmacsMenu.
3575
3576 * nsmenu.m (trackingMenu): New variable.
3577 (trackingNotification): New method (from Aquamacs).
3578 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3579 from Aquamacs (Bug#7030).
3580
3581 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3582
3583 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3584 (symbol_to_nsstring): Fix indentation.
3585 (ns_symbol_to_pb): New function.
3586 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3587 (Fns_rotate_cut_buffers_internal): Remove.
3588 (Fns_store_selection_internal): Rename from
3589 Fns_store_cut_buffer_internal.
3590 (ns_get_foreign_selection, Fx_own_selection_internal)
3591 (Fx_disown_selection_internal, Fx_selection_exists_p)
3592 (Fns_get_selection_internal, Fns_store_selection_internal):
3593 Use ns_symbol_to_pb and check if return value is nil.
3594 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3595 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3596 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3597 renamed to Sns_store_selection_internal.
3598 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3599 and remove this function.
3600 (ns_handle_selection_clear): Remove, never used.
3601 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3602 here.
3603
3604 2011-12-17 Ken Brown <kbrown@cornell.edu>
3605
3606 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3607 GID is unknown (Bug#10257).
3608
3609 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3610
3611 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3612 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3613 which caused a build failure on GNU/Linux IA-64. This problem was
3614 introduced by my 2011-10-07 patch.
3615
3616 2011-12-15 Juri Linkov <juri@jurta.org>
3617
3618 * image.c (imagemagick_error): New function. (Bug#10112)
3619 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3620 Use `imagemagick_error' where ImageMagick functions return
3621 `MagickFalse'.
3622 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3623 proper order.
3624
3625 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3626
3627 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3628 fill background (Bug#8992).
3629
3630 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3631
3632 * window.c (Vwindow_combination_resize)
3633 (Vwindow_combination_limit): Use t instead of non-nil in
3634 doc-strings.
3635 (Vrecenter_redisplay): Add first sentence of doc-string on
3636 separate line.
3637 (Frecenter): Fix doc-string typo.
3638
3639 2011-12-11 Kenichi Handa <handa@m17n.org>
3640
3641 * coding.c (Funencodable_char_position): Pay attention to the
3642 buffer text relocation (Bug#9389).
3643
3644 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3645
3646 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3647 gtk_init (Bug#10100).
3648
3649 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3650
3651 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3652 IT->string is nil. (Bug#10263)
3653
3654 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3655
3656 * nsterm.h (x_free_frame_resources): Declare.
3657
3658 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3659 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3660
3661 * nsterm.h (ns_get_defaults_value): Declare.
3662
3663 * nsterm.m (ns_default): Call ns_get_defaults_value.
3664
3665 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3666
3667 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3668 (Bug#10170)
3669
3670 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3671
3672 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3673 that where the value of an _OBJC_* symbol points to is in the .bss
3674 section (Bug#10240).
3675
3676 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3677
3678 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3679 after the loop to call ccl_driver at least once (Bug#8619).
3680
3681 2011-12-08 Kenichi Handa <handa@m17n.org>
3682
3683 * ftfont.c (get_adstyle_property): Fix previous change
3684 (Bug#10233).
3685
3686 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3687
3688 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3689 dirs from the default value of EMACSLOADPATH (bug#10208).
3690
3691 2011-12-07 Glenn Morris <rgm@gnu.org>
3692
3693 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3694 installation and source directories as well. (Bug#10208)
3695
3696 2011-12-06 Chong Yidong <cyd@gnu.org>
3697
3698 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3699
3700 2011-12-06 Glenn Morris <rgm@gnu.org>
3701
3702 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3703 as an error, not just -1. (Bug#10217)
3704
3705 2011-12-05 Chong Yidong <cyd@gnu.org>
3706
3707 * keyboard.c (process_special_events): New function.
3708 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3709
3710 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 * coding.c (encode_designation_at_bol): Don't use uninitialized
3713 local variable (Bug#9318).
3714
3715 2011-12-05 Kenichi Handa <handa@m17n.org>
3716
3717 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3718 return Qnil (Bug#8046, Bug#10193).
3719
3720 2011-12-05 Kenichi Handa <handa@m17n.org>
3721
3722 * coding.c (encode_designation_at_bol): New args charbuf_end and
3723 dst. Return the number of produced bytes. Callers changed.
3724 (coding_set_source): Return how many bytes coding->source was
3725 relocated.
3726 (coding_set_destination): Return how many bytes
3727 coding->destination was relocated.
3728 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3729 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3730
3731 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3732
3733 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3734 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3735 macro (Bug#9318).
3736
3737 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3738
3739 The following changes are to fix Bug#9318.
3740
3741 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3742 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3743 (encode_coding_iso_2022, encode_coding_sjis)
3744 (encode_coding_big5, encode_coding_charset): Use the above macros.
3745
3746 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3747
3748 * lisp.h (process_quit_flag): Fix external declaration.
3749
3750 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3751
3752 Don't macro-inline non-performance-critical code.
3753 * eval.c (process_quit_flag): New function.
3754 * lisp.h (QUIT): Use it.
3755
3756 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3757
3758 * nsfns.m (get_geometry_from_preferences): New function.
3759 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3760
3761 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3762
3763 * emacs.c (Qkill_emacs): Define.
3764 (syms_of_emacs): Initialize it.
3765 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3766 Qquit_flag to `kill-emacs' instead.
3767 (quit_throw_to_read_char): Add parameter `from_signal'.
3768 All callers changed. Call Fkill_emacs if requested and safe.
3769 * lisp.h (QUIT): Call Fkill_emacs if requested.
3770
3771 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3772
3773 * widget.c (update_wm_hints): Return if wmshell is null.
3774 (widget_update_wm_size_hints): New function.
3775
3776 * widget.h (widget_update_wm_size_hints): Declare.
3777
3778 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3779 widget_update_wm_size_hints (Bug#10104).
3780
3781 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3782
3783 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3784 before a newline, prepare the bidi iterator for consuming the
3785 newline, and keep the current paragraph direction. (Bug#10183)
3786 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3787
3788 2011-12-02 Juri Linkov <juri@jurta.org>
3789
3790 * search.c (Fword_search_regexp): New Lisp function created from
3791 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3792 (Fword_search_backward, Fword_search_forward)
3793 (Fword_search_backward_lax, Fword_search_forward_lax):
3794 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3795 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3796
3797 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3798
3799 * fileio.c (Finsert_file_contents): Move after-change-function call
3800 to before the "handled:" label, since all "goto handled" appear in
3801 cases where the *-change-functions have already been properly called
3802 (bug#10117).
3803
3804 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3805
3806 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3807 waiting for input. (Bug#10169)
3808
3809 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3810
3811 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3812 verifies glyph row's hash code--we have just reallocated the
3813 glyphs, so their contents can be complete garbage. (Bug#10164)
3814
3815 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3816
3817 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3818
3819 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3820
3821 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3822 attributes are tested _before_ calling verify_row_hash, to protect
3823 against GCC re-ordering of the tests. (Bug#10164)
3824
3825 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3826
3827 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3828
3829 * xterm.c (handle_one_xevent): Only set async_visible and friends
3830 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3831 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3832 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3833
3834 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3835
3836 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3837 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3838 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3839 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3840 All uses changed to use GCPRO1 etc.
3841 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3842 Revert to old implementation (i.e., before 2011-03-11).
3843
3844 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3845
3846 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3847 of scroll runs so as to avoid assigning disabled bogus rows and
3848 unnecessary graphics copy operations.
3849
3850 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3851
3852 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3853 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3854 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3855 (malloc, free, realloc, calloc): Redirect to e_* only when
3856 compiling Emacs.
3857
3858 * lisp.h (GCTYPEBITS): Move before first use.
3859 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3860 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3861 this macro definition.
3862
3863 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3864 _MSC_VER.
3865
3866 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3867
3868 * gtkutil.c (xg_create_frame_widgets):
3869 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3870 present with Gtk+ 2.0.
3871
3872 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3873
3874 * fileio.c (Finsert_file_contents): Undo previous change; see
3875 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3876
3877 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 Rename locals to avoid shadowing.
3880 * fileio.c (Finsert_file_contents):
3881 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3882 * process.c (wait_reading_process_output):
3883 Rename inner 'proc' to 'p' to avoid shadowing.
3884 Indent for consistency with usual Emacs style.
3885
3886 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3887
3888 * xdisp.c (redisplay_window): If cursor row is not fully visible
3889 after recentering, and scroll-conservatively is set to a large
3890 number, scroll window by a few more lines to make the cursor fully
3891 visible and out of scroll-margin. (Bug#10105)
3892 (start_display): Don't move to the next line if the display should
3893 start at a newline that is part of a display vector or an overlay
3894 string. (Bug#10119)
3895
3896 2011-11-24 Juri Linkov <juri@jurta.org>
3897
3898 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3899 after the `MagickPingImage' call. (Bug#10112)
3900
3901 2011-11-23 Chong Yidong <cyd@gnu.org>
3902
3903 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3904
3905 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3906
3907 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3908 making another buffer current. (Bug#10114)
3909
3910 2011-11-23 Glenn Morris <rgm@gnu.org>
3911
3912 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3913
3914 2011-11-23 Chong Yidong <cyd@gnu.org>
3915
3916 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3917 using it (Bug#5984).
3918
3919 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3920
3921 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3922 and header-lines, as they don't have one computed for them.
3923 (Bug#10098)
3924
3925 * .gdbinit (prow): Make displayed values more self-explaining.
3926 Add row's hash code.
3927
3928 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3929
3930 * process.c (wait_reading_process_output): Fix asynchrounous
3931 GnuTLS socket handling on some versions of the GnuTLS library.
3932 (wait_reading_process_output): Add comment and URL.
3933
3934 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3935
3936 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3937
3938 2011-11-21 Chong Yidong <cyd@gnu.org>
3939
3940 * window.c (Fnext_window, Fprevious_window): Doc fix.
3941
3942 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3943
3944 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3945
3946 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3947
3948 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3949
3950 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3951
3952 * window.c (Fset_window_combination_limit): Rename argument
3953 STATUS to LIMIT.
3954 (Vwindow_combination_limit): Remove "status" from doc-string.
3955
3956 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3957
3958 * m/ibms390.h: Remove.
3959 * m/ibms390x.h: Don't include "ibms390.h".
3960
3961 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3962
3963 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3964 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3965
3966 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3967
3968 * casetab.c (Fset_case_table):
3969 * charset.c (Fcharset_after): Fix typos.
3970
3971 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3972
3973 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3974 Otherwise, valgrind does not work on some platforms.
3975 Problem reported by Andreas Schwab in
3976 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3977 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3978 is set, removing the need for VIRT_ADDRESS_VARIES.
3979 (PURE_P): Use a more-efficient implementation that needs just one
3980 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3981 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3982 to 4 (xorl, subq, cmpq, setbe).
3983 * alloc.c (pure): Always extern now, since that's the
3984 VIRT_ADDR_VARIES behavior.
3985 (PURE_POINTER_P): Use a single comparison, not two, for
3986 consistency with the new puresize.h.
3987 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3988 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3989 Remove VIRT_ADDR_VARIES no longer needed.
3990
3991 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3992
3993 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3994 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3995 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3996 behave as if the cursor position were at the window margin.
3997
3998 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3999 and the cursor position is out of bounds, behave as if the cursor
4000 position were at the window margin. (Bug#10075)
4001
4002 2011-11-18 Chong Yidong <cyd@gnu.org>
4003
4004 * window.c (Fwindow_combination_limit): Make first argument
4005 non-optional, since it is meaningless for live windows like the
4006 selected window.
4007
4008 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4009
4010 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4011
4012 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4013
4014 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4015 (graft_intervals_into_buffer): Simplify.
4016
4017 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4018
4019 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4020 hash values of the two rows.
4021 (copy_row_except_pointers): Preserve the used[] arrays and the
4022 hash values of the two rows. (Bug#10035)
4023 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4024
4025 * xdisp.c (row_hash): New function, body extracted from
4026 compute_line_metrics.
4027 (compute_line_metrics): Call row_hash, instead of computing the
4028 hash code inline.
4029
4030 * dispnew.c (verify_row_hash): Call row_hash for computing the
4031 hash code of a row, instead of duplicating code from xdisp.c.
4032
4033 * dispextern.h (row_hash): Add prototype.
4034
4035 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4036
4037 * frame.c (delete_frame): Don't delete the terminal when the last
4038 X frame is closed if emacs is built with GTK toolkit.
4039
4040 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4041
4042 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4043
4044 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4045
4046 * window.c (Vwindow_splits): Rename to
4047 Vwindow_combination_resize. Suggested by Juri Linkov.
4048 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4049 of Vwindow_splits.
4050
4051 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4052
4053 * nsfns.m (Fns_font_name):
4054 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4055
4056 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4057
4058 * window.h (window): Rename slot "nest" to "combination_limit".
4059 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4060 (Fset_window_nest): Rename to Fset_window_combination_limit.
4061 (Vwindow_nest): Rename to Vwindow_combination_limit.
4062 (recombine_windows, make_parent_window, make_window)
4063 (Fsplit_window_internal, saved_window)
4064 (Fset_window_configuration, save_window_save): Rename all
4065 occurrences of window_nest to window_combination_limit.
4066
4067 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4068
4069 * image.c (imagemagick_load_image): Fix typo.
4070
4071 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4072
4073 * xdisp.c (display_line): Move the call to
4074 highlight_trailing_whitespace before the call to
4075 compute_line_metrics, since the latter needs to see the final
4076 faces of all the glyphs to compute ROW's hash value.
4077 Fixes assertion violations in row_equal_p. (Bug#10035)
4078
4079 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4080
4081 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4082 just return (bug#10044).
4083
4084 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4085
4086 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4087 with user-defined heap size. Bump the default size of the temacs
4088 heap to 27MB, to avoid memory warning when running temacs.
4089 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4090
4091 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4092 current_matrix and desired_matrix. (Bug#9990)
4093 (verify_row_hash) [XASSERTS]: New function.
4094 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4095 that the hash value of glyph rows is correct.
4096
4097 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4098
4099 * window.h (window): Remove splits slot.
4100 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4101 (Fdelete_other_windows_internal, make_parent_window)
4102 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4103 (Fset_window_configuration, save_window_save): Don't deal with
4104 split status of windows.
4105 (saved_window): Remove splits slot.
4106 (Vwindow_splits): Rewrite doc-string.
4107
4108 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4109
4110 * xfns.c (unwind_create_frame):
4111 * nsfns.m (unwind_create_frame):
4112 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4113 Vframe_list (Bug#9999).
4114
4115 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4116
4117 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4118
4119 2011-11-11 Kenichi Handa <handa@m17n.org>
4120
4121 * callproc.c (Fcall_process): Set the member dst_multibyte of
4122 process_coding.
4123
4124 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4125
4126 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4127 avoid a crash (bug#9496).
4128
4129 2011-11-09 Chong Yidong <cyd@gnu.org>
4130
4131 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4132 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4133
4134 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4137
4138 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 Avoid some portability problems by eschewing 'extern inline' functions.
4141 The trivial performance wins aren't worth the portability hassles; see
4142 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4143 et seq.
4144 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4145 (window_box_width, window_box_left, window_box_left_offset)
4146 (window_box_right, window_box_right_offset): Undo previous change,
4147 by removing the "extern"s.
4148 * intervals.c (adjust_intervals_for_insertion)
4149 (adjust_intervals_for_deletion): Undo previous change,
4150 making these static again.
4151 (offset_intervals, temp_set_point_both, temp_set_point)
4152 (copy_intervals_to_string): No longer inline.
4153 * xdisp.c (window_text_bottom_y, window_box_width)
4154 (window_box_height, window_box_left_offset)
4155 (window_box_right_offset, window_box_left, window_box_right)
4156 (window_box): No longer inline.
4157
4158 2011-11-08 Chong Yidong <cyd@gnu.org>
4159
4160 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4161 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4162 Signal an error if not a live window.
4163 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4164 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4165
4166 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4167
4168 * lisp.h (syms_of_abbrev): Remove declaration.
4169 Reported by CHENG Gao <chenggao@royau.me>.
4170
4171 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4172
4173 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4174 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4175 of temacs in GUI mode.
4176
4177 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4178
4179 * window.h: Declare delete_all_child_windows instead of
4180 delete_all_subwindows.
4181 * window.c (Fwindow_nest, Fset_window_nest)
4182 (Fset_window_new_total, Fset_window_new_normal)
4183 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4184 (delete_all_subwindows): Rename to delete_all_child_windows.
4185 (Fdelete_other_windows_internal, Fset_window_configuration):
4186 Call delete_all_child_windows instead of delete_all_subwindows.
4187 * frame.c (delete_frame): Call delete_all_child_windows instead
4188 of delete_all_subwindows.
4189
4190 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4191
4192 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4193 This is also needed for porting to any host where GC_MARK_STACK is
4194 not GC_MAKE_GCPROS_NOOPS.
4195 (which_symbols): Use it.
4196
4197 2011-11-07 Kenichi Handa <handa@m17n.org>
4198
4199 * coding.c (coding_set_destination): Check coding->src_pos only
4200 when coding->src_object is a buffer (bug#9910).
4201
4202 * process.c (send_process): Set the member src_multibyte of coding
4203 to 0 (bug#9911) when sending a unibyte text.
4204
4205 * callproc.c (Fcall_process): Set the member src_multibyte of
4206 process_coding to 0 (bug#9912).
4207
4208 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4209
4210 * xmenu.c (cleanup_widget_value_tree): New function.
4211 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4212 calling free_menubar_widget_value_tree directly (Bug#9830).
4213
4214 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 Fix some portability problems with 'inline'.
4217 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4218 (window_box_width, window_box_left, window_box_left_offset)
4219 (window_box_right, window_box_right_offset): Declare extern.
4220 Otherwise, these inline functions do not conform to C99 and
4221 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4222 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4223 * intervals.c (adjust_intervals_for_insertion)
4224 (adjust_intervals_for_deletion): Now extern, because otherwise the
4225 extern inline functions 'offset_intervals' couldn't refer to it.
4226 (static_offset_intervals): Remove.
4227 (offset_intervals): Rewrite using the old contents of
4228 static_offset_intervals. The old version didn't conform to C99
4229 because an extern inline function contained a reference to an
4230 identifier with static linkage.
4231
4232 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4233
4234 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4235 GC.
4236
4237 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4238
4239 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4240 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4241 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4242 return Qleft_to_right.
4243
4244 2011-11-06 Chong Yidong <cyd@gnu.org>
4245
4246 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4247 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4248 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4249 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4250 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4251 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4252 (Fwindow_vscroll): Doc fix.
4253 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4254 argument, since it makes no sense to pass a live window and for
4255 consistency with window-child.
4256
4257 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4258
4259 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4260 support MSVC.
4261
4262 2011-11-05 Jason Rumney <jasonr@gnu.org>
4263
4264 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4265 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4266 fonts (Bug#6029).
4267 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4268 bitwise arithmetic preventing use of unicode-sip and non-truetype
4269 opentype fonts.
4270
4271 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4272
4273 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4274 "emacs"-only part.
4275
4276 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4277 initialization code to keep similarity to xfns.c after changes
4278 from 2011-11-05.
4279
4280 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4281
4282 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4283 (unwind_create_frame): New function (Bug#9943).
4284 (Fx_create_frame): Restructure code to be more similar to the one in
4285 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4286 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4287 Move terminal->reference_count++ just before making the frame official
4288 (Bug#9943).
4289
4290 * nsterm.m (x_free_frame_resources): New function.
4291 (x_destroy_window): Move code to x_free_frame_resources.
4292
4293 * xfns.c (unwind_create_frame): Fix comment.
4294 (Fx_create_frame, x_create_tip_frame):
4295 Move terminal->reference_count++ just before making the frame
4296 official. Move initialization of image_cache_refcount and
4297 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4298
4299 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4300
4301 Support MSVC build with newer versions of Visual Studio.
4302 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4303 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4304 nt/gmake.defs.
4305
4306 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4307 which are not supported by MSVC.
4308 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4309 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4310 bitfields.
4311 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4312 types in bitfields.
4313 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4314
4315 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4316
4317 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4318
4319 Support MSVC build with newer versions of Visual Studio.
4320 * w32.c: Don't include w32api.h for MSVC.
4321 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4322
4323 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4324 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4325 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4326 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4327 e_* cousins.
4328 (alloca) [_MSC_VER]: Define to _alloca.
4329
4330 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4331
4332 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4333
4334 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4335
4336 * xdisp.c (note_mouse_highlight): If either of
4337 previous/next-single-property-change returns nil, treat that as
4338 the beginning or the end of the buffer. (Bug#9955)
4339
4340 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4341
4342 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4343 label is not null (Bug#9951).
4344 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4345 may be NULL.
4346
4347 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4348
4349 * window.c (Fwindow_body_size): Mention in the doc string that the
4350 return value is in frame's canonical units. (Bug#9949)
4351
4352 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4353
4354 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4355
4356 * w32fns.c (unwind_create_frame): If needed, free the glyph
4357 matrices of the partially constructed frame. (Bug#9943)
4358 * xfns.c (unwind_create_frame): Likewise.
4359
4360 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4361
4362 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4363 Don't stop backward scan on the continuation glyph, even though
4364 its CHARPOS is positive.
4365 (mouse_face_from_buffer_pos, note_mouse_highlight):
4366 Rename cover_string to disp_string.
4367
4368 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4369
4370 * window.c (temp_output_buffer_show): Don't use
4371 Vtemp_buffer_show_specifiers.
4372 (Vtemp_buffer_show_specifiers): Remove unused variable.
4373
4374 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4375
4376 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4377 past the beginning of the current glyph matrix.
4378
4379 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4380
4381 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4382 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4383 HAVE_GTK3 (Bug#9869).
4384
4385 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4386 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4387
4388 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4389
4390 * xterm.c: Declare x_handle_net_wm_state to return int.
4391 (handle_one_xevent): Check if we are iconified but don't have
4392 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4393 (get_current_wm_state): Return non-zero if not hidden,
4394 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4395 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4396 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4397 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4398
4399 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4400
4401 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4402 so that this new function doesn't get optimized away by a
4403 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4404
4405 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4406
4407 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4408
4409 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4410
4411 Fix the `xbytecode' command.
4412 * .gdbinit (xprintbytestr): New command.
4413 (xwhichsymbols): Rename from `which'; all callers changed.
4414 (xbytecode): Print the byte-code string as well.
4415
4416 2011-10-29 Kim Storm <storm@cua.dk>
4417
4418 * alloc.c (which_symbols): New function.
4419
4420 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4421
4422 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4423 line. (Bug#9903)
4424
4425 2011-10-29 Glenn Morris <rgm@gnu.org>
4426
4427 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4428 Not clear what it was for, and it causes various bugs. (Bug#9839)
4429
4430 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4431
4432 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4433 possible random value that matches one of those tested as
4434 condition to clear the mouse face.
4435
4436 2011-10-28 Chong Yidong <cyd@gnu.org>
4437
4438 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4439
4440 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4441
4442 * window.c (make_window): Initialize phys_cursor_on_p.
4443
4444 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4445
4446 * lisp.h (struct Lisp_Symbol): Update comments.
4447
4448 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4449
4450 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4451
4452 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4453
4454 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4455 <oslsachem@gmail.com> for helping to debug this.
4456
4457 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4458 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4459 (g_b_init_get_glyph_outline_w): New static variables.
4460 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4461 (GetGlyphOutlineW_Proc): New typedefs.
4462 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4463 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4464 New functions.
4465 (w32font_open_internal, compute_metrics):
4466 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4467 instead of calling the "wide" APIs directly.
4468
4469 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4470
4471 * w32.h (syms_of_w32font): Add prototype.
4472
4473 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4474
4475 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4476 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4477 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4478 (Fmove_to_window_line): Doc fix.
4479
4480 2011-10-27 Chong Yidong <cyd@gnu.org>
4481
4482 * process.c (make_process): Set gnutls_state to NULL.
4483
4484 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4485 non-NULL, regardless of GNUTLS_INITSTAGE.
4486 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4487 an error. Set process slots as soon as we allocate them.
4488
4489 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4490
4491 2011-10-27 Chong Yidong <cyd@gnu.org>
4492
4493 * gnutls.c (emacs_gnutls_deinit): New function.
4494 Deallocate credentials structures as well as calling gnutls_deinit.
4495 (Fgnutls_deinit, Fgnutls_boot): Use it.
4496
4497 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4498 (deactivate_process): Call emacs_gnutls_deinit.
4499
4500 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4501
4502 * image.c (x_create_x_image_and_pixmap):
4503 * w32.c (sys_rename, w32_delayed_load):
4504 * w32font.c (fill_in_logfont):
4505 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4506
4507 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4508
4509 * w32fns.c (w32_default_color_map): New function,
4510 extracted from Fw32_default_color_map.
4511 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4512
4513 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4516
4517 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4518
4519 * keyboard.c (test_undefined): New function (bug#9751).
4520 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4521
4522 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4523
4524 * sysdep.c (init_sys_modes): Fix the check for the controlling
4525 terminal (Bug#6649).
4526
4527 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4528
4529 * dispextern.h (struct bidi_it): New member next_en_type.
4530
4531 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4532 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4533 current character, check also for next_en_type being WEAK_EN.
4534 (bidi_resolve_weak): Don't enter the expensive loop if the current
4535 position is before next_en_pos. Record the bidi type of the first
4536 non-ET, non-BN character we find, in addition to its position.
4537 (bidi_level_of_next_char): Invalidate next_en_type when
4538 next_en_pos is over-stepped.
4539
4540 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4541
4542 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4543 * editfns.c: Rewrite current-time-zone so that it invokes
4544 the equivalent of (format-time-string "%Z") to get the time zone name.
4545 This fixes a bug when the time zone name contains characters that
4546 need converting from the system time locale to Emacs internal format.
4547 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4548 that patch fixed format-time-string to do the conversion, but
4549 I forgot to fix current-time-zone.
4550 (format_time_string): New function, containing most of
4551 what Fformat_time_string used to contain.
4552 (Fformat_time_string): Rewrite in terms of format_time_string.
4553 This doesn't change this function's behavior.
4554 (current-time-zone): Rewrite to use format_time_string.
4555 This fixes the bug reported by Michael Schierl in
4556 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4557 Jason Rumney's 2007-06-07 change worked around this bug, but
4558 didn't fix it.
4559 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4560
4561 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4562
4563 * xdisp.c (start_display): If the character at POS is displayed
4564 via a display vector, reset IT->current.dpvec_index to zero.
4565 (try_window_reusing_current_matrix): If a line ends in a display
4566 vector or the next line starts in a display vector, continue
4567 redrawing the window even though the character position of
4568 start_row was reached.
4569 (Bug#9771, part 2)
4570
4571 2011-10-18 Chong Yidong <cyd@gnu.org>
4572
4573 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4574 with nobreak-char-display too.
4575
4576 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4577
4578 Fix part 3 of bug#9771.
4579 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4580 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4581 non-neutral characters if the current character is a paragraph
4582 separator (a.k.a. Newline). This avoids running the same
4583 expensive loop twice, once when we consume the preceding newline
4584 and the other time when the line actually needs to be displayed.
4585 Avoid the loop when we see neutrals on the base embedding level
4586 following a character whose directionality is the same as the
4587 paragraph's. This avoids running the expensive loop when a line
4588 ends in a long sequence of neutrals, like control characters.
4589 Add assertion against STRONG_AL type. Slightly rearrange code
4590 that determines the type of a neutral given the first non-neutral
4591 that follows it.
4592 (bidi_level_of_next_char): Set next_en_pos to zero when
4593 invalidating its info.
4594
4595 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4596
4597 * xdisp.c (push_display_prop): Determine whether to record string
4598 or buffer position by IT->string, not by IT->method. Allow
4599 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4600 (move_it_vertically_backward): Don't look for character position
4601 immediately after the newline when in a continuation line.
4602 (Bug#9771, part 1)
4603
4604 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4605
4606 * window.c (coordinates_in_window): Rewrite and delabelize
4607 vertical border check. (Bug#5357) (Bug#9618)
4608
4609 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4610
4611 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4612 errors in XSetWindowBorder (bug#9310).
4613
4614 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4615
4616 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4617 avoid crash when xmalloc overrun checking is enabled.
4618
4619 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4620
4621 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4622 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4623 cursor motion with <left> and <right> arrow keys.
4624
4625 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4626 some callers set that themselves.
4627
4628 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4629
4630 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4631 display string and the previous row comes from the same string and
4632 is empty. (Bug#9739) (Bug#9738)
4633
4634 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4635
4636 * doc.c (get_doc_string): Encode file name (bug#9735).
4637
4638 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4639
4640 * bidi.c (bidi_level_of_next_char):
4641 * xdisp.c (get_visually_first_element): Remove old incorrect
4642 comments regarding the Unicode Line Separator character.
4643
4644 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4645
4646 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4647
4648 * alloc.c (Fgc_status): Do not access beyond zombies array
4649 boundary if nzombies > MAX_ZOMBIES.
4650 * alloc.c (dump_zombies): Add missing format specifier.
4651
4652 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4653
4654 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4655 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4656
4657 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4658 Some packages use them to denote characters with modifiers.
4659
4660 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4661
4662 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4663 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4664 matching a pp-number. Rename parameter var to var1.
4665
4666 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4667
4668 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4669
4670 2011-10-08 Glenn Morris <rgm@gnu.org>
4671
4672 * callint.c (Fcall_interactively): Give a more explicit error for the
4673 'c' case with a non-character input. (Bug#8479)
4674
4675 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4676
4677 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4678 lines.
4679 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4680 lines that are hscrolled on the left.
4681
4682 * dispnew.c (buffer_posn_from_coords): Account for a possible
4683 presence of header-line. (Bug#4426)
4684
4685 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4686
4687 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4688 Don't advertise functionality which we discourage or doesn't work.
4689
4690 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4691
4692 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4693 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4694 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4695 this makes Emacs dump core during garbage collection on rare
4696 occasions. sizeof is obviously inferior to offsetof here, so
4697 stick with offsetof.
4698 (GC_POINTER_ALIGNMENT): New macro.
4699 (mark_memory): Omit 3rd (offset) arg; caller changed.
4700 Don't assume EMACS_INT alignment is the same as pointer alignment.
4701
4702 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4703
4704 * keyboard.c (read_key_sequence_remapped): New var.
4705 (read_key_sequence): Compute remapping in the right buffer.
4706 (command_loop_1): Use read_key_sequence's remapping directly.
4707
4708 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4709
4710 * dired.c (file_name_completion): Don't expand file name.
4711 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4712 before checking file name handler.
4713
4714 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4715 they've been requested explicitly (bug#9591).
4716
4717 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4718
4719 * keymap.c (Fsingle_key_description): Use make_specified_string
4720 instead of build_string to build string from push_key_description.
4721 (Bug#5193)
4722
4723 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4726 This fixes a Y2038 bug on 64-bit hosts.
4727 * buffer.c (reset_buffer):
4728 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4729 (Fclear_buffer_auto_save_failure):
4730 Use 0, not -1, to represent an unset failure time, since time_t
4731 might not be signed.
4732
4733 Remove dependency on glibc malloc internals.
4734 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4735 Move back here from lisp.h, but with their new implementations.
4736 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4737 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4738 * charset.c (charset_table_init): New static var.
4739 (syms_of_charset): Use it instead of xmalloc. This removes a
4740 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4741 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4742 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4743 Move back to alloc.c.
4744 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4745 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4746
4747 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4748
4749 * nsterm.m (windowDidResize): Call x_set_window_size only when
4750 ns_in_resize is true. Otherwise set pixelwidth/height and
4751 call change_frame_size (Bug#9628).
4752
4753 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4754
4755 Port --enable-checking=all to Fedora 14 x86-64.
4756 * charset.c (syms_of_charset): Also account for glibc malloc's
4757 internal overhead when calculating the initial malloc maximum.
4758
4759 Port --enable-checking=all to Fedora 14 x86.
4760 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4761 Move to lisp.h.
4762 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4763 (overrun_check_realloc, overrun_check_free):
4764 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4765 That way, xmalloc returns a properly-aligned pointer even if
4766 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4767 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4768 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4769 into account when calculating the initial malloc maximum.
4770 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4771 Move here from alloc.c, so that charset.c can use it too.
4772 Properly align; the old code wasn't right for common 32-bit hosts
4773 when configured with --enable-checking=all.
4774 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4775 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4776
4777 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4778
4779 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4780 use EDOM.
4781
4782 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4783
4784 * xdisp.c (compute_display_string_end): If there's no display
4785 string at CHARPOS, return -1.
4786
4787 * bidi.c (bidi_fetch_char): When compute_display_string_end
4788 returns a negative value, treat the character as a normal
4789 character not covered by a display string. (Bug#9624)
4790
4791 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4792
4793 * lread.c (Fread_from_string): Fix typo in docstring.
4794
4795 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4796
4797 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4798 newline, reseat the iterator instead of bidi-iterating there one
4799 character at a time. (Bug#9610)
4800 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4801 TO_CHARPOS if the bidi iterator is at base embedding level.
4802
4803 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4804
4805 * lread.c (readevalloop): Use correct code for NBSP.
4806 (read1): Likewise. (Bug#9608)
4807
4808 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4809
4810 * dbusbind.c (Fdbus_register_signal): When service is not
4811 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4812
4813 2011-09-25 Glenn Morris <rgm@gnu.org>
4814
4815 * buffer.c (truncate-lines): Doc fix.
4816
4817 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4818
4819 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4820 (Fset_window_next_buffers): Doc fix.
4821
4822 2011-09-24 Glenn Morris <rgm@gnu.org>
4823
4824 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4825
4826 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4827
4828 Fix minor problems found by static checking.
4829 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4830 * indent.c (Fvertical_motion): Fix == vs = typo.
4831
4832 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4833
4834 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4835 Default value is now t. Doc fix.
4836
4837 * indent.c (Fvertical_motion): Compute and apply the overshoot
4838 logic when moving up, not only when moving down. Fix the
4839 confusing name and values of the it_overshoot_expected variable;
4840 logic changes accordingly. (Bug#9254) (Bug#9549)
4841
4842 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4843 CHARPOS is covered by a display string which includes newlines.
4844 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4845 is covered by a display string with embedded newlines.
4846
4847 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4848
4849 * dbusbind.c (Fdbus_register_signal): Add match rule to
4850 Vdbus_registered_objects_table. (Bug#9581)
4851 (Fdbus_register_method, Vdbus_registered_objects_table):
4852 Fix docstring.
4853
4854 2011-09-24 Jim Meyering <meyering@redhat.com>
4855
4856 do not ignore write error for any output size
4857 The previous change was incomplete.
4858 While it makes emacs --batch detect the vast majority of stdout
4859 write failures, errors were still ignored whenever the output size is
4860 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4861 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4862 && echo FAIL: ignored write error
4863 FAIL: ignored write error
4864 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4865 && echo FAIL: ignored write error
4866 FAIL: ignored write error
4867 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4868
4869 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4870
4871 * emacs.c (Fkill_emacs): In noninteractive mode exit
4872 non-successfully if a write error occurred on stdout. (Bug#9574)
4873
4874 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4875
4876 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4877 the xassert test.
4878
4879 * dispextern.h (struct it): Update the comment documenting what
4880 can it->OBJECT be.
4881
4882 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4883
4884 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4885 a display string, extend search for cursor position to end of row.
4886 (find_row_edges): If the row ends in a newline from a display
4887 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4888 Handle the case of a display string with multiple newlines.
4889 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4890 non-empty line. Fixes confusing cursor motion with arrow keys at
4891 the beginning of a line that starts with whitespace.
4892
4893 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4894
4895 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4896 (bug#9493).
4897
4898 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4899
4900 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4901 boolean (Bug#9154).
4902
4903 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4904
4905 * xdisp.c (display_line): Record maximum and minimum buffer
4906 positions even if no glyphs were produced (e.g., by a zero-width
4907 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4908 buffer positions that will be removed from the glyph row because
4909 they don't fit.
4910 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4911 column is beyond frame width: don't subtract 1 "pixel" when
4912 computing width of the stretch.
4913 (reseat_at_next_visible_line_start): Undo the change made on
4914 2011-09-17 that saved paragraph information and restored it after
4915 the call to `reseat'. (Bug#9545)
4916
4917 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4918
4919 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4920 and turn window cursor on if cleared (Bug#9415).
4921
4922 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4923
4924 * search.c (boyer_moore): Take unibyte characters from pattern
4925 literally. (Bug#9458)
4926
4927 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4928
4929 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4930
4931 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4932
4933 Fix minor problem found by static checking.
4934 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4935 initialized, to pacify gcc -Wuninitialized.
4936
4937 * fileio.c: Report proper errno when syscall falls.
4938 (Finsert_file_contents): Save and restore errno,
4939 so that report_file_error outputs the correct diagnostic.
4940 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4941
4942 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4943
4944 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4945
4946 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4947
4948 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4949 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4950
4951 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4952
4953 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4954 about the current paragraph and restore it after the call to reseat.
4955
4956 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4957 (bidi_find_paragraph_start): Search back for paragraph beginning
4958 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4959 (bidi_move_to_visually_next): Only trigger paragraph-related
4960 computations when the last character is a newline or at EOB, not
4961 just any NEUTRAL_B. (Bug#9470)
4962
4963 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4964 truncated lines if point is covered by a display string. (Bug#9524)
4965
4966 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4969 (cons_to_x_long): New function.
4970 (lisp_data_to_selection_data): Use it. Correct the test for
4971 short-versus-long data; it was negated. Break out of vector
4972 loop, for efficiency, when a long datum is discovered.
4973
4974 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4975
4976 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4977
4978 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4979
4980 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4981 GCC PR/17406) by declaring this function with external scope.
4982
4983 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4984
4985 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4986 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4987
4988 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4989
4990 * editfns.c (Fformat): Correctly handle text properties on "%%".
4991
4992 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4993
4994 * xterm.c (x_draw_composite_glyph_string_foreground):
4995 * w32term.c (x_draw_composite_glyph_string_foreground):
4996 * term.c (encode_terminal_code):
4997 * composite.c (composition_update_it, get_composition_id):
4998 * xdisp.c (get_next_display_element)
4999 (fill_composite_glyph_string): Add comments about special meaning
5000 of TAB characters in a composition.
5001
5002 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5003
5004 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5005 This occurs when processing a multibyte format.
5006 Problem reported by Wolfgang Jenker.
5007
5008 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5009
5010 * xdisp.c (try_cursor_movement): Only check for exact match if
5011 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5012
5013 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5014
5015 Remove unused external symbols.
5016 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5017 * xdisp.c (calc_pixel_width_or_height): Now static.
5018 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5019 * indent.c (check_display_width):
5020 * w32term.c: Fix comment to match code.
5021 * xterm.c, xterm.h (x_catching_errors): Remove.
5022
5023 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5024
5025 * xselect.c: Use signed conversions more consistently (Bug#9498).
5026 (selection_data_to_lisp_data): Assume incoming selection data are
5027 signed integers, not unsigned. This is to be consistent with
5028 outgoing selection data, which was modified to use signed integers
5029 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5030 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5031 expects long, not unsigned long.
5032
5033 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5034
5035 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5036 computation of loop end. Reported by Johan Bockgård
5037 <bojohan@gnu.org>.
5038
5039 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5040
5041 * frame.c (Fother_visible_frames_p): Function deleted.
5042
5043 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5044
5045 * indent.c (compute_motion): Process display vector front to back
5046 rather than the other way around. (Bug#2496)
5047
5048 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5049
5050 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5051
5052 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5053
5054 * minibuf.c (Fread_from_minibuffer): Doc fix.
5055
5056 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5057
5058 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5059 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5060
5061 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5062
5063 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5064 value for non-existent files.
5065
5066 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5067
5068 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5069 set its "size" to -1. This will set the modtime_size field of
5070 the corresponding buffer to -1, which is what
5071 verify-visited-file-modtime expects for files that do not exist.
5072 (Bug#9139)
5073
5074 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5075
5076 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5077 here ...
5078 * lisp.h: ... from here. push_key_description is no longer
5079 defined in keyboard.c, so its declaration should not be in
5080 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5081 logically belongs with push_key_description.
5082
5083 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5084
5085 * buffer.h: Include <sys/types.h> instead of <time.h>.
5086 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5087 Problem reported by Herbert J. Skuhra.
5088
5089 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5090
5091 * xml.c (parse_region): Make the parsing work for
5092 non-comment-starting XML files again (bug#9144).
5093
5094 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5095
5096 * image.c (gif_load): Fix calculation of bottom and right corner.
5097 (Bug#9468)
5098
5099 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5100
5101 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5102 redisplay in small windows.
5103
5104 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5105
5106 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5107
5108 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5109
5110 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5111 Operate on live windows only.
5112
5113 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5114
5115 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5116
5117 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5118
5119 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5120 only under bidi iteration.
5121
5122 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5123
5124 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5125
5126 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5129 Without this fix, the command to link temacs failed due to an
5130 undefined symbol __builtin_isnan. This is because
5131 /usr/include/iso/math_c99.h #defines isnan(x) to
5132 __builtin_isnan(x), but the bundled gcc, which identifies itself
5133 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5134 a __builtin_isnan.
5135 * floatfns.c (isnan): #undef, and then #define to a clone of
5136 what's in data.c.
5137 (Fisnan): Always define, since it's always available now.
5138 (syms_of_floatfns): Always define isnan at the Lisp level.
5139
5140 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5141
5142 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5143
5144 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5145
5146 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5147 The previous code assumed that file offsets (off_t values) fit in
5148 EMACS_INT variables, which is not true on typical 32-bit hosts.
5149 The code messed up by falsely reporting buffer overflow in cases
5150 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5151 when "big" contains more than 2**29 bytes, even though this
5152 inserts just one byte and does not overflow the buffer.
5153 (Finsert_file_contents): Store file offsets as off_t
5154 values, not as EMACS_INT values. Check for overflow when
5155 converting between EMACS_INT and off_t. When checking for
5156 buffer overflow or for overlap, take the offsets into account.
5157 Don't use EMACS_INT for small values where int suffices.
5158 When checking for overlap, fix a typo: ZV was used where
5159 ZV_BYTE was intended.
5160 (Fwrite_region): Don't assume off_t fits into 'long'.
5161 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5162
5163 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5164
5165 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5166
5167 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5168
5169 sprintf-related integer and memory overflow issues (Bug#9412).
5170
5171 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5172 (esprintf, exprintf, evxprintf): New functions.
5173 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5174 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5175 (modify_event_symbol): Do not assume that the length of
5176 name_alist_or_stem is safe to alloca and fits in int.
5177 (Fexecute_extended_command): Likewise for function name and binding.
5178 (Frecursion_depth): Wrap around reliably on integer overflow.
5179 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5180 since some callers pass EMACS_INT values.
5181 (Fsingle_key_description): Don't crash if symbol name contains more
5182 than MAX_ALLOCA bytes.
5183 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5184 (get_minibuffer): Arg is now EMACS_INT, not int.
5185 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5186 (esprintf, exprintf, evxprintf): New decls.
5187 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5188
5189 * dbusbind.c (signature_cat): New function.
5190 (xd_signature, Fdbus_register_signal):
5191 Do not overrun buffer; instead, report string overflow.
5192
5193 * dispnew.c (add_window_display_history): Don't overrun buffer.
5194 Truncate instead; this is OK since it's just a log.
5195
5196 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5197 even if the time zone offset is outlandishly large.
5198 Don't mishandle offset == INT_MIN.
5199
5200 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5201 when creating daemon; the previous buffer-overflow check was incorrect.
5202
5203 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5204 which has the guts of the old verror function.
5205
5206 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5207 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5208
5209 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5210 (font_unparse_xlfd): Don't blindly alloca long strings.
5211 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5212 fits in int, when using sprintf. Use single snprintf to count
5213 length of string rather than counting it via multiple sprintfs;
5214 that's simpler and more reliable.
5215 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5216 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5217 sprintf, in case result does not fit in int.
5218
5219 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5220 (fontset_from_font): Print it.
5221
5222 * frame.c (tty_frame_count): Now printmax_t, not int.
5223 (make_terminal_frame, set_term_frame_name): Print it.
5224 (x_report_frame_params): In X, window IDs are unsigned long,
5225 not signed long, so print them as unsigned.
5226 (validate_x_resource_name): Check for implausibly long names,
5227 and don't assume name length fits in 'int'.
5228 (x_get_resource_string): Don't blindly alloca invocation name;
5229 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5230 not fit in int.
5231
5232 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5233 (xg_check_special_colors, xg_set_geometry):
5234 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5235
5236 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5237 Use esprintf, not sprintf, in case result does not fit in int.
5238
5239 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5240 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5241 it as a large positive number.
5242 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5243 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5244
5245 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5246 in case result does not fit in int.
5247
5248 * print.c (float_to_string): Detect width overflow more reliably.
5249 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5250 buffer overrun. Don't assume list length fits in 'int'. Treat
5251 print length of 0 as 0, not as infinity; to be consistent with other
5252 uses of print length in this function. Don't overflow print length
5253 index. Don't assume hash table size fits in 'long', or that
5254 vectorlike size fits in 'unsigned long'.
5255
5256 * process.c (make_process): Use printmax_t, not int, to format
5257 process-name gensyms.
5258
5259 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5260
5261 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5262 to avoid potential buffer overrun.
5263
5264 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5265 if X resource line is longer than 512 bytes.
5266
5267 * xfns.c (x_window): Make sprintf buffer a bit bigger
5268 to avoid potential buffer overrun.
5269
5270 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5271
5272 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5273
5274 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5275
5276 Integer overflow fixes for scrolling, etc.
5277 Without these, Emacs silently mishandles large integers sometimes.
5278 For example, "C-u 4294967297 M-x recenter" was treated as if
5279 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5280
5281 * xdisp.c (try_window_id): Check Emacs fixnum range before
5282 converting to 'int'.
5283
5284 * window.c (window_scroll_line_based, Frecenter):
5285 Check that an Emacs fixnum is in range before assigning it to 'int'.
5286 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5287 values converted from Emacs fixnums.
5288 (Frecenter): Don't wrap around a line count if it is out of 'int'
5289 range; instead, treat it as an extreme value.
5290 (Fset_window_configuration, compare_window_configurations):
5291 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5292
5293 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5294 that can exceed INT_MAX. Check that EMACS_INT value is in range
5295 before assigning it to the (possibly-narrower) index.
5296 (match_limit): Don't assume that a fixnum can fit in 'int'.
5297
5298 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5299 exceed INT_MAX.
5300
5301 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5302 (Fvertical_motion): Don't wrap around LINES values that don't fit
5303 in 'int'. Instead, treat them as extreme values. This is good
5304 enough for windows, which can't have more than INT_MAX lines anyway.
5305
5306 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5307
5308 * Require libxml/parser.h to avoid compilation warning.
5309
5310 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5311
5312 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5313 since this reportedly can destroy thread storage.
5314
5315 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5316
5317 * syntax.c (find_defun_start): Update all cache variables if
5318 exiting early (Bug#9401).
5319
5320 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5321
5322 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5323
5324 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5325 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5326 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5327
5328 * term.c (tty_append_glyph): New function.
5329 (produce_stretch_glyph): Static function and its prototype deleted.
5330
5331 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5332 Add prototypes.
5333
5334 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5335
5336 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5337 when checking :margin (Bug#9390).
5338 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5339 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5340 so that the name doesn't mislead. All uses changed.
5341
5342 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5343
5344 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5345 set_tty_hooks.
5346
5347 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5348
5349 * xdisp.c (move_it_to): Don't bail out early when reaching
5350 position beyond to_charpos, if we are scanning backwards.
5351 (move_it_vertically_backward): When DY == 0, make sure we get to
5352 the first character in the line after the newline.
5353
5354 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5355
5356 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5357 (ccl_driver): Do not generate an out-of-range pointer.
5358 (Fccl_execute_on_string): Remove unnecessary check for
5359 integer overflow, noted by Stefan Monnier in
5360 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5361 Remove a FIXME that didn't need fixing.
5362 Simplify the newly-introduced buffer reallocation code.
5363
5364 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5365
5366 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5367
5368 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5369
5370 Integer and memory overflow issues (Bug#9196).
5371
5372 * doc.c (get_doc_string): Rework so that
5373 get_doc_string_buffer_size is the actual buffer size, rather than
5374 being 1 less than the actual buffer size; this makes xpalloc more
5375 convenient.
5376
5377 * image.c (x_allocate_bitmap_record, cache_image):
5378 * xselect.c (Fx_register_dnd_atom):
5379 Simplify previous changes by using xpalloc.
5380
5381 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5382 since either will do and ptrdiff_t is convenient with xpalloc.
5383
5384 * charset.c (charset_table_size)
5385 (struct charset_sort_data.priority): Now ptrdiff_t.
5386 (charset_compare): Don't overflow if priorities differ greatly.
5387 (Fsort_charsets): Don't assume list length fits in int.
5388 Check for size-calculation overflow when allocating sort data.
5389 (syms_of_charset): Allocate an initial charset table that is
5390 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5391
5392 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5393
5394 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5395 The actual value is always <= INT_MAX, and leaving it unsigned made
5396 overflow checking harder.
5397
5398 * dispextern.h (struct glyph_matrix.rows_allocated)
5399 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5400 with xpalloc. The values are still always <= INT_MAX.
5401
5402 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5403
5404 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5405 (SAFE_NALLOCA): New macro.
5406
5407 * region-cache.c (struct boundary.pos, find_cache_boundary)
5408 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5409 (set_cache_region, invalidate_region_cache)
5410 (revalidate_region_cache, know_region_cache, region_cache_forward)
5411 (region_cache_backward, pp_cache):
5412 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5413 so that ptrdiff_t * can be passed to xpalloc.
5414 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5415 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5416 (pp_cache): Don't assume cache_len fits in int.
5417 * region-cache.h: Adjust extern decls to match.
5418
5419 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5420 EMACS_INT, since either will do, for xpalloc.
5421
5422 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5423 (xnmalloc, xnrealloc, xpalloc): New functions.
5424
5425 * bidi.c (bidi_shelve_header_size): New constant.
5426 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5427 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5428
5429 * bidi.c (bidi_cache_shrink):
5430 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5431 (overlay_strings):
5432 Don't update size of array until after memory allocation succeeds,
5433 because xmalloc/xrealloc may not return.
5434 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5435 now that we have proper integer overflow checking.
5436 (record_overlay_string, overlay_strings): Catch overflows when
5437 calculating size of overlay_str_buf.
5438
5439 * callproc.c (Fcall_process): Check for size overflow when
5440 calculating size of args2.
5441 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5442 Normally we prefer signed values, but sticking with ptrdiff_t would
5443 require adding more-complicated checks.
5444
5445 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5446 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5447 Redo buffer-overflow calculations to avoid integer overflow.
5448 Add a FIXME comment where memory seems to be over-allocated.
5449
5450 * character.c (Fstring): Check for size-calculation overflow.
5451
5452 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5453 unnecessary integer overflow. Check for size overflow.
5454 (encode_coding_object): Don't update size until xmalloc succeeds.
5455
5456 * composite.c (get_composition_id): Check for overflow in glyph
5457 length calculations.
5458
5459 Integer and memory overflow fixes for display code.
5460 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5461 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5462 (scrolling_window): Check for overflow in size calculations.
5463 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5464 Don't assume glyph table len fits in int.
5465 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5466 (row_table_size): Now ptrdiff_t, not int.
5467 (scrolling_window): Avoid overflow in size calculations.
5468 Don't update size until allocation succeeds.
5469 * fns.c (concat): Check for overflow in size calculations.
5470 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5471 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5472 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5473
5474 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5475 (get_doc_string): Check for size calculation overflow.
5476 Don't update size until allocation succeeds.
5477 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5478 EMACS_INT, where ptrdiff_t will do.
5479 (Fsubstitute_command_keys): Check for string overflow.
5480
5481 * editfns.c (set_time_zone_rule): Don't assume environment length
5482 fits in int.
5483 (message_length): Now ptrdiff_t, not int.
5484 (Fmessage_box): Don't update size until allocation succeeds.
5485 Don't assume message length fits in int.
5486 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5487
5488 * emacs.c (main): Do not reallocate argv, since there is a null at
5489 the end that can be overwritten, and this way there's no need to
5490 worry about size-calculation overflow.
5491 (sort_args): Check for size-calculation overflow.
5492
5493 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5494 alloc succeeds.
5495 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5496
5497 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5498 (x_set_scroll_bar_width, x_figure_window_size):
5499 Check for integer overflow.
5500 (x_set_alpha): Do not assume XINT fits in int.
5501
5502 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5503 This is for the members text_lines, text_cols, total_lines, total_cols,
5504 where the system imposes an 'int' limit.
5505
5506 * fringe.c (Fdefine_fringe_bitmap):
5507 Don't update size until alloc works.
5508
5509 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5510 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5511
5512 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5513 Check for size-calculation overflow.
5514 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5515 do, as we prefer signed integers.
5516 (id_to_widget.max_size, id_to_widget.used)
5517 (xg_store_widget_in_map, xg_remove_widget_from_map)
5518 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5519 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5520 Use and return ptrdiff_t, not int.
5521 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5522 * gtkutil.h: Change prototypes to match the above.
5523
5524 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5525 are duplicate now that they've been promoted to lisp.h.
5526 (x_allocate_bitmap_record, x_alloc_image_color)
5527 (make_image_cache, cache_image, xpm_load):
5528 Don't update size until alloc is done.
5529 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5530 (x_detect_edges):
5531 Check for size calculation overflow.
5532 (ct_colors_allocated_max): New constant.
5533 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5534 overflow.
5535
5536 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5537 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5538 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5539 Use ptrdiff_t, not int, to count maps.
5540 (read_char_minibuf_menu_prompt): Check for overflow in size
5541 calculations. Don't update size until allocation succeeds.
5542 Redo calculations to avoid overflow.
5543 * keyboard.h: Change prototypes to match the above.
5544
5545 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5546 to count maps.
5547 (current_minor_maps): Check for size calculation overflow.
5548 * keymap.h: Change prototypes to match the above.
5549
5550 * lread.c (read1, init_obarray): Don't update size until alloc done.
5551
5552 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5553 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5554
5555 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5556 Now ptrdiff_t, not int.
5557 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5558 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5559
5560 * process.c (Fnetwork_interface_list): Check for overflow
5561 in size calculation.
5562
5563 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5564
5565 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5566 overflow. Don't bother calling xmalloc when xrealloc will do.
5567
5568 * search.c (Freplace_match): Check for size calculation overflow.
5569 (Fset_match_data): Don't assume list lengths fit in 'int'.
5570
5571 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5572 for command line length. Do not attempt to address one before the
5573 beginning of an array, as that's not portable.
5574
5575 * term.c (max_frame_lines): Remove; unused.
5576 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5577 not int.
5578 (encode_terminal_code, calculate_costs): Check for size
5579 calculation overflow.
5580 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5581 table lengths and related sizes. Don't update size until alloc
5582 done. Redo calculations to avoid overflow.
5583 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5584
5585 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5586 subtracting pointers.
5587 (gobble_line): Check for overflow more carefully. Don't update size
5588 until alloc done.
5589
5590 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5591 Don't update size until alloc done.
5592 Redo size calculations to avoid overflow.
5593 Check for size calculation overflow.
5594 (main) [DEBUG]: Fix typo in invoking tparam1.
5595
5596 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5597 Use ptrdiff_t, not int, for sizes.
5598 (store_mode_line_noprop_char): Don't update size until alloc done.
5599
5600 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5601 Use ptrdiff_t, not int, for sizes.
5602 (Finternal_make_lisp_face, cache_face):
5603 Check for size calculation overflow.
5604 (cache_face): Treat size calculation overflows as if they were
5605 memory exhaustion (the usual treatment), rather than aborting.
5606
5607 * xfns.c (x_encode_text, x_set_name_internal)
5608 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5609 sizes, since they can exceed INT_MAX in size. Check for size
5610 calculation overflow.
5611
5612 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5613 (xg_select): Check for size calculation overflow.
5614 Don't update size until alloc done.
5615
5616 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5617 as sprintf is limited to int lengths.
5618
5619 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5620 (X_LONG_MIN): New macros.
5621 Use them to make the following changes clearer.
5622 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5623 This change doesn't affect the value now, but it may help remind
5624 future maintainers not to raise the value too much later.
5625 (SELECTION_QUANTUM): Remove, replacing with ...
5626 (selection_quantum): ... new function, which avoids overflow.
5627 All uses changed.
5628 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5629 assumption that selection length fits in 'int'.
5630 (x_reply_selection_request, x_handle_selection_request)
5631 (x_get_window_property, receive_incremental_selection)
5632 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5633 (lisp_data_to_selection_data, clean_local_selection_data):
5634 Use ptrdiff_t, not int, to record length of selection.
5635 (x_reply_selection_request, x_get_window_property)
5636 (receive_incremental_selection, x_property_data_to_lisp):
5637 Redo calculations to avoid overflow.
5638 (x_reply_selection_request): When sending hint, ceiling it at
5639 X_LONG_MAX rather than relying on wraparound overflow to send
5640 something.
5641 (x_get_window_property, receive_incremental_selection)
5642 (lisp_data_to_selection_data, x_property_data_to_lisp):
5643 Check for size-calculation overflow.
5644 (x_get_window_property, receive_incremental_selection)
5645 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5646 Don't store size until memory allocation succeeds.
5647 (x_get_window_property): Plug memory leak on memory exhaustion.
5648 Don't double-block input; malloc is safe here. Don't assume 2**34
5649 - 4 fits in unsigned long. Add an xassert to check
5650 XGetWindowProperty overflow. Be more careful about overflow
5651 calculations, and distinguish size from memory overflow better.
5652 (receive_incremental_selection): When tracing, don't assume
5653 unsigned int is less than INT_MAX.
5654 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5655 harmful) conversions of unsigned short to int.
5656 (lisp_data_to_selection_data): Don't assume that integers
5657 in the range -65535 through -1 fit in an X unsigned short.
5658 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5659 result parameters unless successful. Rely on cons_to_unsigned
5660 to report problems with elements; the old code wasn't right anyway.
5661 (x_check_property_data): Check for int overflow; we cannot use
5662 a wider type due to X limits.
5663 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5664
5665 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5666
5667 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5668 (x_term_init): Check for size calculation overflow.
5669 (x_color_cells): Don't store size until memory allocation succeeds.
5670 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5671 Don't assume alloca size is less than MAX_ALLOCA.
5672 (x_term_init): Don't assume length fits in int (sprintf is limited
5673 to int size).
5674
5675 Use ptrdiff_t for composition IDs.
5676 * character.c (lisp_string_width):
5677 * composite.c (composition_table_size, n_compositions)
5678 (get_composition_id, composition_gstring_from_id):
5679 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5680 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5681 * window.c (Frecenter):
5682 Use ptrdiff_t, not int, for composition IDs.
5683 * composite.c (get_composition_id): Check for integer overflow.
5684 * composite.h: Adjust prototypes to match the above changes.
5685
5686 Use ptrdiff_t for hash table indexes.
5687 * category.c (hash_get_category_set):
5688 * ccl.c (ccl_driver):
5689 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5690 * coding.c (coding_system_charset_list, detect_coding_system):
5691 * coding.h (struct coding_system.id):
5692 * composite.c (get_composition_id, gstring_lookup_cache):
5693 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5694 * image.c (xpm_get_color_table_h):
5695 * lisp.h (hash_lookup, hash_put):
5696 * minibuf.c (Ftest_completion):
5697 Use ptrdiff_t for hash table indexes, not int (which is too
5698 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5699 32-bit --with-wide-int hosts).
5700
5701 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5702 Add a FIXME comment about memory leaks.
5703 (syms_of_charset): Don't assume xmalloc returns.
5704
5705 Don't assume that stated character widths fit in int.
5706 * character.c (Fchar_width, c_string_width, lisp_string_width):
5707 * character.h (CHAR_WIDTH):
5708 * indent.c (MULTIBYTE_BYTES_WIDTH):
5709 Use sanitize_char_width to avoid undefined and/or bad behavior
5710 with outlandish widths.
5711 * character.h (sanitize_tab_width): Rename from sanitize_width,
5712 now that we have two such functions. All uses changed.
5713 (sanitize_char_width): New inline function.
5714
5715 Don't assume that tab-width fits in int.
5716 * character.h (sanitize_width): New inline function.
5717 (SANE_TAB_WIDTH): New macro.
5718 (ASCII_CHAR_WIDTH): Use it.
5719 * indent.c (sane_tab_width): Remove. All uses replaced by
5720 SANE_TAB_WIDTH (current_buffer).
5721 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5722
5723 * fileio.c: Integer overflow issues with file modes.
5724 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5725
5726 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5727 Remove unreachable code.
5728 (read_hex, load_charset_map_from_file): Check for integer overflow.
5729
5730 * xterm.c: Don't go over XClientMessageEvent limit.
5731 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5732 (x_send_scroll_bar_event): Likewise. Check that the size does not
5733 exceed limits imposed by XClientMessageEvent, as well as the usual
5734 ptrdiff_t and size_t limits.
5735
5736 * keyboard.c: Overflow, signedness and related fixes.
5737 (make_lispy_movement): Use same integer type in forward decl
5738 that is used in the definition.
5739 (read_key_sequence, keyremap_step):
5740 Change bufsize argument back to int, undoing my 2011-03-30 change.
5741 We prefer signed types, and int is wide enough here.
5742 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5743 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5744 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5745 length, not size_t. Use ptrdiff_t for index, not int.
5746 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5747 possibility of integer overflow.
5748
5749 Overflow, signedness and related fixes for images.
5750
5751 * dispextern.h (struct it.stack[0].u.image.image_id)
5752 (struct_it.image_id, struct image.id, struct image_cache.size)
5753 (struct image_cache.used, struct image_cache.ref_count):
5754 * gtkutil.c (update_frame_tool_bar):
5755 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5756 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5757 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5758 * nsmenu.m (update_frame_tool_bar):
5759 * xdisp.c (calc_pixel_width_or_height):
5760 * xfns.c (image_cache_refcount):
5761 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5762 on typical 64-bit hosts.
5763
5764 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5765 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5766 Omit unnecessary casts to int.
5767 (parse_image_spec): Check that integers fall into 'int' range
5768 when the callers expect that.
5769 (image_ascent): Redo ascent calculation to avoid int overflow.
5770 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5771 (lookup_image): Remove unnecessary tests.
5772 (xbm_image_p): Locals are now of int, not EMACS_INT,
5773 since parse_image_check makes sure they fit into int.
5774 (png_load, gif_load, svg_load_image):
5775 Prefer int to unsigned where either will do.
5776 (tiff_handler): New function, combining the cores of the
5777 old tiff_error_handler and tiff_warning_handler.
5778 This function is rewritten to use vsnprintf and thereby avoid
5779 stack buffer overflows. It uses only the features of vsnprintf
5780 that are common to both POSIX and native Microsoft.
5781 (tiff_error_handler, tiff_warning_handler): Use it.
5782 (tiff_load, gif_load, imagemagick_load_image):
5783 Don't assume :index value fits in 'int'.
5784 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5785 (imagemagick_load_image): Check that crop parameters fit into
5786 the integer types that MagickCropImage accepts. Don't assume
5787 Vimagemagick_render_type has a nonnegative value. Don't assume
5788 size_t fits in 'long'.
5789 (gs_load): Use printmax_t to print the widest integers possible.
5790 Check for integer overflow when computing image height and width.
5791
5792 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5793
5794 * xdisp.c (redisplay_window): Don't force window start if point
5795 will be invisible in the resulting window. (Bug#9324)
5796
5797 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5798
5799 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5800 the display spec is of the form `(space ...)'.
5801 (handle_display_spec): Return the value returned by
5802 handle_single_display_spec, not just 1 or zero.
5803 (handle_single_display_spec): If the display spec is of the form
5804 `(space ...)', and specifies display in the text area, return 2
5805 rather than 1.
5806 (try_cursor_movement): Check for the need to scroll more
5807 accurately, and prefer exact match for point under bidi.
5808 Don't advance `row' beyond the last row of the window.
5809
5810 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5811 into disp_prop; all users changed.
5812
5813 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5814 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5815 for the text covered by the display property.
5816
5817 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5818
5819 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5820 Change return value to nil.
5821 (Frecord_buffer): Delete unused function.
5822
5823 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5824
5825 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5826 buffers, return left-to-right.
5827 (set_cursor_from_row): Consider candidate row a win if its glyph
5828 represents a newline and point is on that newline. Fixes cursor
5829 positioning on the newline at EOL of R2L text within L2R
5830 paragraph, and vice versa.
5831 (try_cursor_movement): Check continued rows, in addition to
5832 continuation rows. Fixes unwarranted scroll when point enters a
5833 continued line of R2L text within an L2R paragraph, or vice versa.
5834 (cursor_row_p): Consider the case of point being equal to
5835 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5836 from the end of a short line to the beginning of a continued line
5837 of R2L text within L2R paragraph.
5838 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5839 composed characters.
5840
5841 * bidi.c (bidi_check_type): Use xassert.
5842 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5843 members.
5844
5845 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5846
5847 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5848 a character.
5849
5850 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5851
5852 * nsfont.m (ns_otf_to_script): Fix typo.
5853
5854 2011-08-22 Kenichi Handa <handa@m17n.org>
5855
5856 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5857 extra slot even if the purpose is char-code-property-table.
5858
5859 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5860
5861 * xdisp.c (redisplay_window): When computing centering_position,
5862 account for the height of the header line. (Bug#8874)
5863
5864 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5865 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5866 candidate is selected by the mouse, and that candidate has a
5867 composed character under the mouse.
5868
5869 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5870 coordinates reported by pos-visible-in-window-p for a composed
5871 character in column zero.
5872
5873 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5874
5875 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5876
5877 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5878
5879 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5880 consider it a hit if to_charpos is anywhere in the range of the
5881 composed buffer positions.
5882
5883 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5884
5885 * image.c (gif_load): Don't assume that each subimage has the same
5886 dimensions as the base image. Handle disposal method that is
5887 "undefined" by the gif spec (Bug#9335).
5888
5889 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5890
5891 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5892 (Fcondition_case): Document `debug' symbol in error handler.
5893
5894 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5895
5896 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5897 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5898 from an Org mode buffer to a Speedbar frame.
5899
5900 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5901 a composition, take its buffer position from IT->cmp_it.charpos.
5902 Fixes cursor positioning at the beginning of a line that begins
5903 with a composed character.
5904
5905 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5906
5907 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5908 character bidirectional type, use STRONG_L instead. Fixes crashes
5909 in a buffer produced by `describe-categories'.
5910
5911 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5912 members before the level stack, so they would be saved and
5913 restored when copying iterator state. Fixes incorrect reordering
5914 around TABs covered by display properties.
5915
5916 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5917
5918 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5919
5920 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5921
5922 * eval.c (internal_condition_case, internal_condition_case_1)
5923 (internal_condition_case_2, internal_condition_case_n):
5924 Remove unnecessary aborts (Bug#9081).
5925
5926 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5927
5928 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5929 has no `load' handler, try opening the file locally. (Bug#9311)
5930
5931 2011-08-16 Ken Brown <kbrown@cornell.edu>
5932
5933 * gmalloc.c: Expand comment.
5934
5935 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5936
5937 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5938 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5939
5940 2011-08-16 Ken Brown <kbrown@cornell.edu>
5941
5942 Fix memory allocation problems in Cygwin build (Bug#9273).
5943
5944 * unexcw.c ( __malloc_initialized): Declare external variable.
5945 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5946
5947 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5948 New variables.
5949 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5950 dumped emacs.
5951 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5952 in the static heap.
5953 [CYGWIN] (special_realloc): New function.
5954 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5955 requests to realloc storage in the static heap.
5956
5957 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5958
5959 * bidi.c (bidi_initialize): Remove unused local.
5960
5961 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5962
5963 * bidimirror.h:
5964 * biditype.h: Remove file.
5965 * makefile.w32-in ($(BLD)/bidi.$(O)):
5966 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5967
5968 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5969
5970 * chartab.c: Improve commentary for the uniprop_table API.
5971
5972 * bidi.c (bidi_paragraph_init): Support zero value of
5973 bidi_ignore_explicit_marks_for_paragraph_level.
5974 (bidi_initialize): Use uniprop_table instead of including
5975 biditype.h and bidimirror.h.
5976
5977 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5978 coordinates of the iterator when restoring from ppos_it.
5979 (Bug#9296)
5980
5981 2011-08-14 Kenichi Handa <handa@m17n.org>
5982
5983 * process.c (create_process): Call setup_process_coding_systems
5984 after the pid of the process is set to -1 (Bug#8162).
5985
5986 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5987
5988 * xdisp.c (move_it_in_display_line_to): Don't invoke
5989 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5990 ppos_it. Fixes vertical cursor motion when line beginning is
5991 covered by an image. (Bug#9296)
5992
5993 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5994
5995 * nsterm.h (ns_run_ascript): Declare.
5996 (NSAPP_DATA2_RUNASSCRIPT): Define.
5997
5998 * nsfns.m (as_script, as_result, as_status): New static variables.
5999 (ns_run_ascript): New function.
6000 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6001 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6002 the event loop. Get status from as_status (Bug#7276).
6003
6004 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6005 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6006 the event loop (Bug#7276).
6007
6008 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6009
6010 * gnutls.c (QCgnutls_bootprop_priority)
6011 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6012 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6013 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6014 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6015 (QCgnutls_bootprop_verify_hostname_error)
6016 (QCgnutls_bootprop_callbacks_verify): Rename from
6017 Qgnutls_bootprop_..., all uses changed.
6018
6019 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6020 uses changed.
6021
6022 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 * xfaces.c (Qframe_set_background_mode): Now static.
6025 * dispextern.h (Qframe_set_background_mode): Remove decl.
6026
6027 * process.c (Fnetwork_interface_info): Declare local only if needed.
6028
6029 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6030
6031 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6032 (Fnetwork_interface_list): Allocate in increments of bytes instead
6033 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6034 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6035 sockaddr.
6036 (struct ifflag_def): notrailers is smart on OSX.
6037 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6038 Get hardware address with getifaddrs if available.
6039
6040 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6041
6042 * xdisp.c (iterate_out_of_display_property): xassert that
6043 IT->position is set to within IT->object's boundaries. Break from
6044 the loop as soon as EOB is reached; avoids infloops in redisplay
6045 when IT->position is set up wrongly due to some bug.
6046 Set IT->current to match the bidi iterator unconditionally.
6047 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6048 entry. Force push_it to save on the stack the current
6049 buffer/string position, to be restored by pop_it. Fix flags in
6050 the iterator structure wrt the object coming from a display
6051 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6052 properties. (Bug#9284)
6053
6054 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6055
6056 * fontset.c (fontset_get_font_group): Add proper type checks.
6057 (Bug#9172)
6058
6059 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6060
6061 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6062 and LC_VERSION_MIN_MACOSX.
6063 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6064 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6065
6066 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6067
6068 * xdisp.c (forward_to_next_line_start): Allow to use the
6069 no-display-properties-and-no-overlays under bidi display.
6070 Set disp_pos in the bidi iterator to avoid searches for display
6071 properties and overlays.
6072
6073 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6074
6075 * editfns.c (Fset_time_zone_rule): Document relationship with the
6076 setenv function.
6077
6078 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6079 the font entity extracted from the cache (Bug#8109).
6080
6081 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6082
6083 * composite.c (autocmp_chars): Don't reset point. That is done by
6084 restore_point_unwind (Bug#5984).
6085
6086 2011-08-07 Juri Linkov <juri@jurta.org>
6087
6088 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6089 to show the arg `TIME' instead of `TIMEVAL'.
6090
6091 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6092
6093 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6094 display property strides EOL and includes a newline, as in
6095 longlines-mode. (Bug#9254)
6096 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6097 word-wrap under bidirectional display. (Bug#9224)
6098
6099 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6100 is non-zero, even if the data buffer is NULL. Fixes a crash in
6101 vertical-motion with longlines-mode. (Bug#9254)
6102
6103 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6104
6105 * bidi.c <bidi_cache_total_alloc>: Now static.
6106 (bidi_initialize): Initialize bidi_cache_total_alloc.
6107
6108 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6109 cache. (Bug#9221)
6110
6111 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6112 amount allocated this far in `bidi_cache_total_alloc'.
6113 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6114 non-zero, only free the data buffer without restoring the cache
6115 contents. All callers changed.
6116
6117 * dispextern.h (bidi_unshelve_cache): Update prototype.
6118
6119 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6120 (move_it_in_display_line, move_it_to)
6121 (move_it_vertically_backward, move_it_by_lines): Replace the call
6122 to xfree to an equivalent call to bidi_unshelve_cache.
6123 (move_it_in_display_line_to): Fix logic of returning
6124 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6125
6126 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6127
6128 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6129 came from a string character with a `cursor' property. (Bug#9229)
6130
6131 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6132
6133 * Makefile.in (LIB_PTHREAD): New variable.
6134 (LIBES): Add LIB_PTHREAD (Bug#9216).
6135
6136 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6137 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6138
6139 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6140
6141 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6142
6143 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6144
6145 * xterm.c (x_find_topmost_parent): New function.
6146 (x_set_frame_alpha): Find topmost parent window with
6147 x_find_topmost_parent and set the property there also (bug#9181).
6148 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6149
6150 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6151
6152 * callproc.c (Fcall_process): Avoid vfork clobbering
6153 the local vars buffer, coding_systems, current_dir.
6154
6155 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6156
6157 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6158
6159 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6160
6161 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6162 so that it is not optimized away.
6163
6164 * xdisp.c (compute_display_string_pos): Remove unused local.
6165
6166 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6167
6168 Fix slow cursor motion and scrolling in large buffers with
6169 selective display, like Org Mode buffers. (Bug#9218)
6170
6171 * dispextern.h (struct bidi_it): New member disp_prop_p.
6172
6173 * xdisp.c: Remove one-slot cache of display string positions.
6174 (compute_display_string_pos): Accept an additional argument
6175 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6176 for a display string or property. If found, set DISP_PROP_P
6177 non-zero.
6178
6179 * bidi.c (bidi_fetch_char): Accept an additional argument
6180 DISP_PROP_P, and pass it to compute_display_string_pos.
6181 Only handle text covered by a display string if DISP_PROP_P is returned
6182 non-zero. All callers of bidi_fetch_char changed.
6183
6184 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6185
6186 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6187
6188 2010-12-03 Don March <don@ohspite.net>
6189
6190 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6191 last character M-[char] is translated to ESC [char] (bug#7541).
6192
6193 2011-08-02 Kenichi Handa <handa@m17n.org>
6194
6195 * lisp.h (uniprop_table): Extern it.
6196
6197 * chartab.c (uniprop_table): Make it non-static.
6198
6199 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6200
6201 * xdisp.c (forward_to_next_line_start): Accept additional argument
6202 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6203 on the newline.
6204 (reseat_at_next_visible_line_start): Use the bidi iterator state
6205 returned by forward_to_next_line_start to restore the state of
6206 it->bidi_it after backing up to previous newline. (Bug#9212)
6207
6208 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6209
6210 * regex.c (re_comp): Protoize.
6211 (re_exec): Fix return type.
6212 (regexec): Fix type of `ret'. (Bug#9203)
6213
6214 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6215
6216 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6217 This is needed if max-image-size is a floating-point number.
6218
6219 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6220
6221 * print.c (print_object): Print empty symbol as ##.
6222
6223 * lread.c (read1): Read ## as empty symbol.
6224
6225 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6226
6227 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6228 setting frame foreground color (Bug#9175).
6229 (x_set_background_color): Likewise.
6230
6231 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6232 contents (Bug#9176).
6233 (EmacsTooltip -init): Remove bezels and add shadows to
6234 tooltip windows.
6235
6236 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6237 or scroll bar (Bug#8470).
6238
6239 * nsfont.m (nsfont_open): Remove assignment to voffset and
6240 unnecessary vars hshink, expand, hd, full_height, min_height.
6241 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6242
6243 * nsterm.h (nsfont_info): Remove voffset field.
6244
6245 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6246
6247 Implement strike-through and overline on NextStep (Bug#8863).
6248
6249 * nsfont.m (nsfont_open): Use underline position provided by font,
6250 instead of hard-coded value of 2.
6251 (nsfont_draw): Call ns_draw_text_decoration instead.
6252
6253 * nsterm.h: Add declaration for ns_draw_text_decoration.
6254
6255 * nsterm.m (ns_draw_text_decoration): New function for drawing
6256 underline, overline, and strike-through.
6257 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6258 ns_draw_text_decoration. Change treatment of cursor drawing to
6259 accommodate underlining, etc.
6260
6261 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6262
6263 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6264 default.
6265
6266 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6267
6268 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6269 Without this fix, if a signal arrives just after memory fills up,
6270 'malloc' might be invoked reentrantly.
6271
6272 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6273 In other words, assume that every image size is allowed, on non-X
6274 hosts. This assumption is probably wrong, but it lets Emacs compile.
6275
6276 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6277
6278 * regex.c (re_iswctype): Convert return values to boolean.
6279
6280 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6281
6282 * xdisp.c (compute_display_string_pos): Don't use cached display
6283 string position if the buffer had its restriction changed.
6284 (Bug#9184)
6285
6286 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6287
6288 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6289
6290 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6291
6292 Integer signedness and overflow and related fixes. (Bug#9079)
6293
6294 * bidi.c: Integer size and overflow fixes.
6295 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6296 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6297 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6298 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6299 (bidi_find_other_level_edge):
6300 Use ptrdiff_t instead of EMACS_INT where either will do.
6301 This works better on 32-bit hosts configured --with-wide-int.
6302 (bidi_cache_ensure_space): Check for size-calculation overflow.
6303 Use % rather than repeated addition, for better worst-case speed.
6304 Don't set bidi_cache_size until after xrealloc returns, because it
6305 might not return.
6306 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6307 (bidi_cache_ensure_space): Also check that the bidi cache size
6308 does not exceed that of the largest Lisp string or buffer. See Eli
6309 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6310
6311 * alloc.c (__malloc_size_t): Remove.
6312 All uses replaced by size_t. See Andreas Schwab's note
6313 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6314
6315 * image.c: Improve checking for integer overflow.
6316 (check_image_size): Assume that f is nonnull, since
6317 it is always nonnull in practice. This is one less thing to
6318 worry about when checking for integer overflow later.
6319 (x_check_image_size): New function, which checks for integer
6320 overflow issues inside X.
6321 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6322 This removes the need for a memory_full check.
6323 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6324 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6325 (xbm_read_bitmap_data): Change locals back to 'int', since
6326 their values must fit in 'int'.
6327 (xpm_load_image, png_load, tiff_load):
6328 Invoke x_create_x_image_and_pixmap earlier,
6329 to avoid much needless work if the image is too large.
6330 (tiff_load): Treat overly large images as if
6331 x_create_x_image_and_pixmap failed, not as malloc failures.
6332 (gs_load): Use x_check_image_size.
6333
6334 * gtkutil.c: Omit integer casts.
6335 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6336 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6337
6338 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6339
6340 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6341 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6342 would wrongly return t on a 64-bit host.
6343
6344 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6345 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6346 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6347 and therefore cause GCC to emit a bogus diagnostic in some cases.
6348
6349 * image.c: Integer signedness and overflow and related fixes.
6350 This is not an exhaustive set of fixes, but it's time to
6351 record what I've got.
6352 (lookup_pixel_color, check_image_size): Remove redundant decls.
6353 (check_image_size): Don't assume that arbitrary EMACS_INT values
6354 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6355 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6356 (tiff_load, imagemagick_load_image):
6357 Check for overflow in size calculations.
6358 (x_create_x_image_and_pixmap): Remove unnecessary test for
6359 xmalloc returning NULL; that can't happen.
6360 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6361 (xpm_color_bucket): Use better integer hashing function.
6362 (xpm_cache_color): Don't possibly over-allocate memory.
6363 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6364 (gif_memory_source):
6365 Use ptrdiff_t, not int or size_t, to record sizes.
6366 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6367 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6368 either works, as we prefer signed integers.
6369 (tiff_read_from_memory, tiff_write_from_memory):
6370 Return tsize_t, not size_t, since that's what the TIFF API wants.
6371 (tiff_read_from_memory): Don't fail simply because the read would
6372 go past EOF; instead, return a short read.
6373 (tiff_load): Omit no-longer-needed casts.
6374 (Fimagemagick_types): Don't assume size fits into 'int'.
6375
6376 Improve hashing quality when configured --with-wide-int.
6377 * fns.c (hash_string): New function, taken from sxhash_string.
6378 Do not discard information about ASCII character case; this
6379 discarding is no longer needed.
6380 (sxhash-string): Use it. Change sig to match it. Caller changed.
6381 * lisp.h: Declare it.
6382 * lread.c (hash_string): Remove, since we now use fns.c's version.
6383 The fns.c version returns a wider integer if --with-wide-int is
6384 specified, so this should help the quality of the hashing a bit.
6385
6386 * emacs.c: Integer overflow minor fix.
6387 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6388 Define only if GNU_LINUX.
6389 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6390
6391 * dispnew.c: Integer signedness and overflow fixes.
6392 Remove unnecessary forward decls, that were a maintenance hassle.
6393 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6394 All uses changed.
6395 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6396 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6397 (prepare_desired_row, line_draw_cost):
6398 Use int, not unsigned, where either works.
6399 (save_current_matrix, restore_current_matrix):
6400 Use ptrdiff_t, not size_t, where either works.
6401 (init_display): Check for overflow more accurately, and without
6402 relying on undefined behavior.
6403
6404 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6405 Remove, replacing with the new symbols in lisp.h. All uses changed.
6406 * fileio.c (make_temp_name):
6407 * filelock.c (lock_file_1, lock_file):
6408 * xdisp.c (message_dolog):
6409 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6410 Use pMd etc. instead.
6411 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6412 replacing the pWIDE etc. symbols removed from editfns.c.
6413
6414 * keyboard.h (num_input_events): Now uintmax_t.
6415 This is (very slightly) less likely to mess up due to wraparound.
6416 All uses changed.
6417
6418 * buffer.c: Integer signedness fixes.
6419 (alloc_buffer_text, enlarge_buffer_text):
6420 Use ptrdiff_t rather than size_t when either will do, as we prefer
6421 signed integers.
6422
6423 * alloc.c: Integer signedness and overflow fixes.
6424 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6425 (__malloc_size_t): Default to size_t, not to int.
6426 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6427 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6428 Prefer ptrdiff_t to size_t when either would do, as we prefer
6429 signed integers.
6430 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6431 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6432 Now const. Initialize with values that are in range even if char
6433 is signed.
6434 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6435 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6436 These functions do the right thing with sizes > 2**32.
6437 (check_depth): Now ptrdiff_t, not int.
6438 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6439 Adjust to new way of storing sizes. Check for size overflow bugs
6440 in rest of code.
6441 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6442 slightly wrong anyway, as it missed one instance of
6443 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6444 (refill_memory_reserve): Omit needless cast to size_t.
6445 (mark_object_loop_halt): Mark as externally visible.
6446
6447 * xselect.c: Integer signedness and overflow fixes.
6448 (Fx_register_dnd_atom, x_handle_dnd_message):
6449 Use ptrdiff_t, not size_t, since we prefer signed.
6450 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6451 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6452 x_dnd_atoms_size and x_dnd_atoms_length.
6453
6454 * doprnt.c: Prefer signed to unsigned when either works.
6455 * eval.c (verror):
6456 * doprnt.c (doprnt):
6457 * lisp.h (doprnt):
6458 * xdisp.c (vmessage):
6459 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6460 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6461 prefer signed arithmetic to avoid comparison confusion.
6462 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6463 but is a bit tricky.
6464
6465 Assume freestanding C89 headers, string.h, stdlib.h.
6466 * data.c, doprnt.c, floatfns.c, print.c:
6467 Include float.h unconditionally.
6468 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6469 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6470 * regex.c: Likewise for stddef.h, string.h.
6471 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6472 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6473 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6474 (STDC_HEADERS): Remove obsolete defines.
6475 * sysdep.c: Include limits.h unconditionally.
6476
6477 Assume support for memcmp, memcpy, memmove, memset.
6478 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6479 * regex.c (memcmp, memcpy):
6480 Remove; we assume C89 now.
6481
6482 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6483 (__malloc_safe_bcopy): Remove; no longer needed.
6484
6485 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6486 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6487 well either way, and we prefer signed to unsigned.
6488
6489 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6490
6491 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6492 closes the connection while we're reading (bug#9182).
6493
6494 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6495
6496 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6497 are specified (Bug#9168).
6498
6499 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6500
6501 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6502 Found by GCC static checking and --with-wide-int on a 32-bit host.
6503
6504 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6505
6506 * xdisp.c (compute_display_string_pos): Fix logic of caching
6507 previous display string position. Initialize cached_prev_pos to
6508 -1. Fixes slow-down at the beginning of a buffer.
6509
6510 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6511
6512 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6513 for attrs[LFACE_FONTSET_INDEX].
6514
6515 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6516
6517 * xml.c (parse_region): Remove unused local
6518 that was recently introduced.
6519
6520 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6521
6522 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6523 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6524
6525 * xdisp.c (move_it_in_display_line_to): Record the best matching
6526 position for TO_CHARPOS while scanning the line, and restore it on
6527 exit if none of the characters scanned was an exact match.
6528 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6529 when exact match is impossible due to invisible text, and the
6530 lines are truncated.
6531
6532 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6533
6534 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6535 for OSX >= 10.7.
6536
6537 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6538
6539 Fix a significant slow-down of cursor motion with C-n, C-p,
6540 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6541 auto-repeat under bidi redisplay in fontified buffers.
6542 * xdisp.c (compute_stop_pos_backwards): New function.
6543 (next_element_from_buffer): Call compute_stop_pos_backwards to
6544 find a suitable prev_stop when we find ourselves before
6545 base_level_stop.
6546 (reseat): Don't look for prev_stop, as that could mean a very long
6547 run.
6548 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6549 <cached_disp_overlay_modiff>: Cache for last found display string
6550 position.
6551 (compute_display_string_pos): Return the cached position if asked
6552 about the same buffer in the same area of character positions, and
6553 the buffer wasn't changed since the time the display string
6554 position was cached.
6555
6556 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6557
6558 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6559 is an integer, which is important for empty lines. (Bug#9149)
6560
6561 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6562
6563 * frame.c (Fmodify_frame_parameters): In tty case, update the
6564 default face if necessary (Bug#4238).
6565
6566 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6567
6568 * editfns.c (Fstring_to_char): No need to explain what a character
6569 is in the docstring (Bug#6576).
6570
6571 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6572
6573 * xml.c (parse_region): Make sure we always return a tree.
6574
6575 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6576
6577 * xml.c (parse_region): If a document contains only comments,
6578 return that, too.
6579
6580 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6581
6582 * xml.c (make_dom): Return comments, too.
6583
6584 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6585
6586 Port to OpenBSD.
6587 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6588 and the surrounding thread.
6589 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6590 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6591 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6592 timer goes off.
6593 * s/openbsd.h (BROKEN_SIGIO): Define.
6594 * unexelf.c (unexec) [__OpenBSD__]:
6595 Don't update the .mdebug section of the Alpha COFF symbol table.
6596
6597 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6598
6599 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6600 (bug#8460).
6601
6602 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6603
6604 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6605 This fixes some race conditions on the permissions of any newly
6606 created file.
6607
6608 * alloc.c (valid_pointer_p): Use pipe, not open.
6609 This fixes some permissions issues when debugging.
6610
6611 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6612 If fchown fails to set both uid and gid, try to set just gid,
6613 as that is sometimes allowed. Adjust the file's mode to eliminate
6614 setuid or setgid bits that are inappropriate if fchown fails.
6615
6616 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6617
6618 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6619 to compare Lisp_Objects.
6620 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6621 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6622 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6623
6624 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6625
6626 * lread.c (read_integer): Unread even EOF character.
6627 (read1): Likewise. Properly record start position of symbol.
6628
6629 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6630 symbol character follows.
6631
6632 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6633
6634 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6635 This works around a problem with the previous change to Fcopy_file.
6636 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6637 and without this change, GCC might complain about discarding
6638 fchown's return value.
6639
6640 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6641
6642 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6643
6644 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6645
6646 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6647
6648 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6649
6650 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6651 it's used from the C level.
6652
6653 * process.c: Use the same condition for POLL_FOR_INPUT in both
6654 keyboard.c and process.c (bug#1858).
6655
6656 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6657
6658 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6659 (Fgnutls_boot): Use it.
6660
6661 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6662
6663 * doc.c (Fsubstitute_command_keys): Revert last change.
6664
6665 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6666
6667 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6668 quotes the next character, and doesn't affect other longer
6669 sequences (bug#8935).
6670
6671 * lread.c (syms_of_lread): Clarify that is isn't only
6672 `eval-buffer' and `eval-defun' that's affected by
6673 `lexical-binding' (bug#8460).
6674
6675 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6676
6677 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6678 bidi redisplay when a line includes both an image and is truncated.
6679
6680 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6681
6682 Fix minor problems found by static checking.
6683 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6684 (elsz): Now a signed constant, not a size_t var. We prefer signed
6685 types to unsigned, to avoid integer comparison confusion. Without
6686 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6687 "cannot optimize loop, the loop counter may overflow", a symptom
6688 of the confusion.
6689 * indent.c (Fvertical_motion): Mark locals as initialized.
6690 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6691
6692 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6693
6694 * search.c (Fre_search_backward): Mention `case-fold-search' in
6695 all the re_search_* functions (bug#8138).
6696
6697 * keyboard.c (Fopen_dribble_file): Document when the file is
6698 closed (bug#8056).
6699
6700 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6701
6702 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6703 bidi_cache_idx.
6704
6705 Support bidi reordering of display and overlay strings.
6706 * xdisp.c (compute_display_string_pos)
6707 (compute_display_string_end): Accept additional argument STRING.
6708 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6709 (reseat_to_string): Initialize bidi_it->string.s and
6710 bidi_it->string.schars.
6711 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6712 NULL (avoids a crash in bidi_paragraph_init).
6713 Initialize itb.string.lstring.
6714 (init_iterator): Call bidi_init_it only of a valid
6715 buffer position was specified. Initialize paragraph_embedding to
6716 L2R.
6717 (reseat_to_string): Initialize the bidi iterator.
6718 (display_string): If we need to ignore text properties of
6719 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6720 original value of -1 will not work with bidi.)
6721 (compute_display_string_pos): First arg is now struct
6722 `text_pos *'; all callers changed. Support display properties on
6723 Lisp strings.
6724 (compute_display_string_end): Support display properties on Lisp
6725 strings.
6726 (init_iterator, reseat_1, reseat_to_string): Initialize the
6727 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6728 when iterating on a string not from display properties).
6729 (compute_display_string_pos, compute_display_string_end):
6730 Fix calculation of the object to scan. Fixes an error when using
6731 arrow keys.
6732 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6733 base_level_stop; instead, set base_level_stop to BEGV.
6734 Fixes crashes in vertical-motion.
6735 (next_element_from_buffer): Improve commentary for when
6736 the iterator is before prev_stop.
6737 (init_iterator): Initialize bidi_p from the default value of
6738 bidi-display-reordering, not from buffer-local value. Use the
6739 buffer-local value only if initializing for buffer iteration.
6740 (handle_invisible_prop): Support invisible properties on strings
6741 that are being bidi-reordered.
6742 (set_iterator_to_next): Support bidi reordering of C strings and
6743 Lisp strings.
6744 (next_element_from_string): Support bidi reordering of Lisp
6745 strings.
6746 (handle_stop_backwards): Support Lisp strings as well.
6747 (display_string): Support display of R2L glyph rows.
6748 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6749 (init_iterator): Don't initialize it->bidi_p for strings
6750 here.
6751 (reseat_to_string): Initialize it->bidi_p for strings here.
6752 (next_element_from_string, next_element_from_c_string)
6753 (next_element_from_buffer): Add xassert's for correspondence
6754 between IT's object being iterated and it->bidi_it.string
6755 structure.
6756 (face_before_or_after_it_pos): Support bidi iteration.
6757 (next_element_from_c_string): Handle the case of the first string
6758 character that is not the first one in the visual order.
6759 (get_visually_first_element): New function, refactored from common
6760 parts of next_element_from_buffer, next_element_from_string, and
6761 next_element_from_c_string.
6762 (tool_bar_lines_needed, redisplay_tool_bar)
6763 (display_menu_bar): Force left-to-right direction. Add a FIXME
6764 comment for making that be controlled by a user option.
6765 (push_it, pop_it): Save and restore the state of the
6766 bidi iterator. Save and restore the bidi_p flag.
6767 (pop_it): Iterate out of display property for string iteration as
6768 well.
6769 (iterate_out_of_display_property): Support iteration over strings.
6770 (handle_single_display_spec): Set up it->bidi_it for iteration
6771 over a display string, and call bidi_init_it.
6772 (handle_single_display_spec, next_overlay_string)
6773 (get_overlay_strings_1, push_display_prop): Set up the bidi
6774 iterator for displaying display or overlay strings.
6775 (forward_to_next_line_start): Don't use the shortcut if
6776 bidi-iterating.
6777 (back_to_previous_visible_line_start): If handle_display_prop
6778 pushed the iterator stack, restore the internal state of the bidi
6779 iterator by calling bidi_pop_it same number of times.
6780 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6781 and we are bidi-iterating, don't decrement the iterator position;
6782 instead, set the first_elt flag in the bidi iterator, to produce
6783 the same effect.
6784 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6785 (push_display_prop): xassert that we are iterating a buffer.
6786 (push_it, pop_it): Save and restore paragraph_embedding member.
6787 (handle_single_display_spec, next_overlay_string)
6788 (get_overlay_strings_1, reseat_1, reseat_to_string)
6789 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6790 correctly. Don't assume unibyte strings are not bidi-reordered.
6791 (compute_display_string_pos)
6792 (compute_display_string_end): Fix handling the case of C string.
6793 (push_it, pop_it): Save and restore from_disp_prop_p.
6794 (handle_single_display_spec, push_display_prop): Set the
6795 from_disp_prop_p flag.
6796 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6797 (pop_it): Call iterate_out_of_display_property only if we are
6798 popping after iteration over a string that came from a display
6799 property. Fix a typo in popping stretch info. Add an assertion
6800 for verifying that the iterator position is in sync with the bidi
6801 iterator.
6802 (handle_single_display_spec, get_overlay_strings_1)
6803 (push_display_prop): Fix initialization of paragraph direction for
6804 string when that of the parent object is not yet determined.
6805 (reseat_1): Call bidi_init_it to resync the bidi
6806 iterator with IT's position. (Bug#7616)
6807 (find_row_edges): If ROW->start.pos gives position
6808 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6809 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6810 Reset the from_disp_prop_p flag.
6811 (SAVE_IT, RESTORE_IT): New macros.
6812 (pos_visible_p, face_before_or_after_it_pos)
6813 (back_to_previous_visible_line_start)
6814 (move_it_in_display_line_to, move_it_in_display_line)
6815 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6816 (try_scrolling, redisplay_window, display_line): Use them when
6817 saving a temporary copy of the iterator and restoring it back.
6818 (back_to_previous_visible_line_start, reseat_1)
6819 (init_iterator): Empty the bidi cache "stack".
6820 (move_it_in_display_line_to): If iterator ended up at
6821 EOL, but we never saw any buffer positions smaller than
6822 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6823 motion in bidi-reordered lines.
6824 (move_it_in_display_line_to): Record prev_method and prev_pos
6825 immediately before the call to set_iterator_to_next. Fixes cursor
6826 motion in bidi-reordered lines with stretch glyphs and strings
6827 displayed in margins. (Bug#8133) (Bug#8867)
6828 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6829 TO_CHARPOS.
6830 (pos_visible_p): Support positions in bidi-reordered lines.
6831 Save and restore bidi cache.
6832
6833 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6834 (bidi_paragraph_info): Delete unused struct.
6835 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6836 (bidi_cache_start): New variable.
6837 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6838 to zero.
6839 (bidi_cache_fetch_state, bidi_cache_search)
6840 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6841 (bidi_cache_find, bidi_peek_at_next_level)
6842 (bidi_level_of_next_char, bidi_find_other_level_edge)
6843 (bidi_move_to_visually_next): Compare cache index with
6844 bidi_cache_start rather than with zero.
6845 (bidi_fetch_char): Accept new argument STRING; all callers
6846 changed. Support iteration over a string. Support strings with
6847 display properties. Support unibyte strings. Fix the type of
6848 `len' according to what STRING_CHAR_AND_LENGTH expects.
6849 (bidi_paragraph_init, bidi_resolve_explicit_1)
6850 (bidi_resolve_explicit, bidi_resolve_weak)
6851 (bidi_level_of_next_char, bidi_move_to_visually_next):
6852 Support iteration over a string.
6853 (bidi_set_sor_type, bidi_resolve_explicit_1)
6854 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6855 can now be zero (for strings); special values 0 and -1 were
6856 changed to -1 and -2, respectively.
6857 (bidi_char_at_pos): New function.
6858 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6859 Call it instead of FETCH_MULTIBYTE_CHAR.
6860 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6861 initialized to valid values.
6862 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6863 values.
6864 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6865 the test for valid cached positions. Fix the logic for looking up
6866 the sentinel state in the cache. GCPRO the Lisp string we are
6867 iterating.
6868 (bidi_push_it, bidi_pop_it): New functions.
6869 (bidi_initialize): Initialize the bidi cache start stack pointer.
6870 (bidi_cache_ensure_space): New function, refactored from part of
6871 bidi_cache_iterator_state. Don't assume the required size is just
6872 one BIDI_CACHE_CHUNK away.
6873 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6874 (bidi_count_bytes, bidi_char_at_pos): New functions.
6875 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6876 always valid if bidi_cache_idx is valid.
6877 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6878 is valid if it's going to be used.
6879 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6880 (bidi_cache_fetch_state, bidi_cache_search)
6881 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6882 (bidi_cache_iterator_state, bidi_cache_find)
6883 (bidi_find_other_level_edge, bidi_cache_start_stack):
6884 All variables related to cache indices are now EMACS_INT.
6885
6886 * dispextern.h (struct bidi_string_data): New structure.
6887 (struct bidi_it): New member `string'. Make flag members be 1-bit
6888 fields, and put them last in the struct.
6889 (compute_display_string_pos, compute_display_string_end):
6890 Update prototypes.
6891 (bidi_push_it, bidi_pop_it): Add prototypes.
6892 (struct iterator_stack_entry): New members bidi_p,
6893 paragraph_embedding, and from_disp_prop_p.
6894 (struct it): Member bidi_p is now a bit field 1 bit wide.
6895 (bidi_shelve_cache, bidi_unshelve_cache):
6896 Declare prototypes.
6897
6898 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6899 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6900 and vector-like objects.
6901
6902 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6903 cache around display iteration.
6904
6905 * window.c (Fwindow_end, window_scroll_pixel_based)
6906 (displayed_window_lines, Frecenter): Save and restore the bidi
6907 cache around display iteration.
6908
6909 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6910
6911 * editfns.c (Fdelete_region): Clarify the use of the named
6912 parameters (bug#6788).
6913
6914 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6915
6916 * indent.c (Fvertical_motion): Set and restore w->pointm when
6917 saving and restoring the window's buffer (Bug#9006).
6918
6919 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6920
6921 * editfns.c (Fstring_to_char): Clarify just what is returned
6922 (bug#6576). Text by Eli Zaretskii.
6923
6924 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6925
6926 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6927
6928 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6929
6930 * buffer.c (mmap_find): Fix a typo.
6931
6932 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6933
6934 Fix execution of x selection hooks.
6935 * xselect.c (Qx_lost_selection_functions)
6936 (Qx_sent_selection_functions): New vars.
6937 (syms_of_xselect): DEFSYM them.
6938 (x_handle_selection_request): Pass Qx_sent_selection_functions
6939 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6940 (x_handle_selection_clear,x_clear_frame_selections):
6941 Pass Qx_lost_selection_functions rather than
6942 Vx_lost_selection_functions to Frun_hook_with_args.
6943
6944 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6945
6946 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6947 The old code sometimes used this field without initializing it.
6948
6949 * alloc.c (gc_sweep): Don't read past end of array.
6950 In theory, the old code could also have corrupted Emacs internals,
6951 though it'd be very unlikely.
6952
6953 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6954
6955 * character.c (Fcharacterp): Don't advertise optional ignored
6956 argument. (Bug#4026)
6957
6958 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6959
6960 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6961 key" (bug#4257).
6962
6963 * window.c (Fset_window_start): Doc fix (bug#4199).
6964 (Fset_window_hscroll): Ditto.
6965
6966 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6967
6968 Fix minor new problems caught by GCC 4.6.1.
6969 * term.c (init_tty): Remove unused local.
6970 * xsettings.c (store_monospaced_changed): Define this function only
6971 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6972 not used otherwise.
6973
6974 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6975
6976 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6977
6978 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6979
6980 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6981 are the mini-buffer and the echo area (bug#3320).
6982
6983 * term.c (init_tty): Remove support for supdup, c10 and perq
6984 terminals, which are no longer supported (bug#1482).
6985
6986 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6987
6988 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6989
6990 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6991
6992 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6993 for non-popups (Bug#3642).
6994
6995 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6996
6997 * alloc.c (reset_malloc_hooks): Protoize.
6998 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6999 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7000 * cm.c (losecursor): Likewise.
7001 * data.c (fmod): Likewise.
7002 * dispnew.c (swap_glyphs_in_rows): Likewise.
7003 * emacs.c (memory_warning_signal): Likewise.
7004 * floatfns.c (float_error): Likewise.
7005 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7006 (otf_open, font_otf_capability, generate_otf_features)
7007 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7008 Likewise.
7009 * image.c (pbm_read_file): Likewise.
7010 * indent.c (string_display_width): Likewise.
7011 * intervals.c (check_for_interval, search_for_interval)
7012 (inc_interval_count, count_intervals, root_interval)
7013 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7014 * lread.c (defalias): Likewise.
7015 * ralloc.c (r_alloc_check): Likewise.
7016 * regex.c (set_image_of_range_1, set_image_of_range)
7017 (regex_grow_registers): Likewise.
7018 * sysdep.c (strerror): Likewise.
7019 * termcap.c (valid_filename_p, tprint, main): Likewise.
7020 * tparam.c (main): Likewise.
7021 * unexhp9k800.c (run_time_remap, save_data_space)
7022 (update_file_ptrs, read_header, write_header, calculate_checksum)
7023 (copy_file, copy_rest, display_header): Likewise.
7024 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7025 Likewise.
7026 * xdisp.c (check_it): Likewise.
7027 * xfaces.c (register_color, unregister_color, unregister_colors):
7028 Likewise.
7029 * xfns.c (print_fontset_result): Likewise.
7030 * xrdb.c (member, fatal, main): Likewise.
7031
7032 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7033
7034 Fix minor problems found by static checking (Bug#9031).
7035 * chartab.c (char_table_set_range, map_sub_char_table):
7036 Remove unused locals.
7037 (uniprop_table): Now static.
7038 * composite.c (_work_char): Remove unused static var.
7039
7040 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7041
7042 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7043
7044 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7045
7046 * gtkutil.c (qttip_cb): Remove code without function.
7047
7048 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7049
7050 * w32.c (pthread_sigmask): New stub.
7051
7052 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7053
7054 Use pthread_sigmask, not sigprocmask (Bug#9010).
7055 sigprocmask is portable only for single-threaded applications, and
7056 Emacs can be multi-threaded when it uses GTK.
7057 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7058 (LIBES): Use it.
7059 * callproc.c (Fcall_process):
7060 * process.c (create_process):
7061 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7062 Use pthread_sigmask, not sigprocmask.
7063
7064 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7065
7066 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7067 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7068 wrong (Bug#8591).
7069
7070 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7071
7072 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7073 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7074 (xg_hide_tooltip): Fix comment.
7075
7076 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7077 in registerServicesMenuSendTypes.
7078 (validRequestorForSendType): Don't check ns_return_types.
7079
7080 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7081 ns_return_type.
7082
7083 2011-07-08 Jason Rumney <jasonr@gnu.org>
7084
7085 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7086 SH_SHOW for hidden windows (Bug#5482).
7087
7088 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7089 frame struct members of non-existent frames (Bug#6284).
7090
7091 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7092
7093 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7094 variable firstTime not needed on OSX >= 10.6.
7095 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7096 >= 10.5. Use setKnobProportion, setDoubleValue.
7097
7098 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7099 (MAC_OS_X_VERSION_10_5): Define if not defined.
7100 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7101 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7102 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7103
7104 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7105 cString and lossyCString on OSX >= 10.4
7106
7107 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7108 sizeToFit on OSX >= 10.2.
7109
7110 * nsimage.m (allocInitFromFile): Don't use deprecated method
7111 bestRepresentationForDevice on OSX >= 10.6.
7112
7113 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7114 to avoid warning.
7115
7116 * emacs.c: Declare unexec_init_emacs_zone.
7117
7118 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7119
7120 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7121
7122 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7123 on svcsMenu (Bug#8842).
7124
7125 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7126 ns_return_types.
7127 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7128
7129 * nsterm.m (QUTF8_STRING): Declare.
7130 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7131 (validRequestorForSendType): Return type is (id).
7132 Change indexOfObjectIdenticalTo to indexOfObject.
7133 Check if we have local selection before returning self (Bug#8842).
7134 (writeSelectionToPasteboard): Put local selection into paste board
7135 if we have a local selection (Bug#8842).
7136 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7137
7138 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7139 (ns_get_local_selection): Declare.
7140
7141 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7142
7143 * keymap.c (describe_map_tree): Don't insert a double newline at
7144 the end of the buffer (bug#1169) and return whether we inserted
7145 something.
7146
7147 * callint.c (Fcall_interactively): Change "reading args" to
7148 "providing args" to try to clarify what it does (bug#1010).
7149
7150 2011-07-07 Kenichi Handa <handa@m17n.org>
7151
7152 * composite.c (composition_compute_stop_pos): Ignore a static
7153 composition starting before CHARPOS (Bug#8915).
7154
7155 * xdisp.c (handle_composition_prop): Likewise.
7156
7157 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7158
7159 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7160 (Bug#9015)
7161
7162 2011-07-07 Kenichi Handa <handa@m17n.org>
7163
7164 * character.h (unicode_category_t): New enum type.
7165
7166 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7167 (Qchar_code_property_table): New variable.
7168 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7169 (UNIPROP_COMPRESSED_FORM_P): New macros.
7170 (char_table_ascii): Uncompress the compressed values.
7171 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7172 Uncompress the compressed values.
7173 (sub_char_table_ref_and_range): Likewise.
7174 (char_table_ref_and_range): Uncompress the compressed values.
7175 (sub_char_table_set): New arg is_uniprop. Callers changed.
7176 Uncompress the compressed values.
7177 (sub_char_table_set_range): Args changed. Callers changed.
7178 (char_table_set_range): Adjuted for the above change.
7179 (map_sub_char_table): Delete args default_val and parent. Add arg
7180 top. Give decoded values to a Lisp function.
7181 (map_char_table): Adjust for the above change. Give decoded
7182 values to a Lisp function. Gcpro more variables.
7183 (uniprop_table_uncompress)
7184 (uniprop_decode_value_run_length): New functions.
7185 (uniprop_decoder, uniprop_decoder_count): New variables.
7186 (uniprop_get_decoder, uniprop_encode_value_character)
7187 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7188 New functions.
7189 (uniprop_encoder, uniprop_encoder_count): New variables.
7190 (uniprop_get_encoder, uniprop_table)
7191 (Funicode_property_table_internal, Fget_unicode_property_internal)
7192 (Fput_unicode_property_internal): New functions.
7193 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7194 Sunicode_property_table_internal, Sget_unicode_property_internal,
7195 and Sput_unicode_property_internal. Defvar_lisp
7196 char-code-property-alist.
7197
7198 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7199 Vunicode_category_table.
7200
7201 * font.c (font_range): Adjust for the change of
7202 Vunicode_category_table.
7203
7204 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7205
7206 * m/iris4d.h: Remove file, move contents ...
7207 * s/irix6-5.h: ... here.
7208
7209 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7210
7211 Remove unportable assumption about struct layout (Bug#8884).
7212 * alloc.c (mark_buffer):
7213 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7214 (clone_per_buffer_values): Don't assume that
7215 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7216 This isn't true in general, and it's particularly not true
7217 if Emacs is configured with --with-wide-int.
7218 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7219 New macros, used in the buffer.c change.
7220
7221 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7222
7223 * xsettings.c: Use both GConf and GSettings if both are available.
7224 (store_config_changed_event): Add comment.
7225 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7226 (store_tool_bar_style_changed): New functions.
7227 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7228 (struct xsettings): Move font inside HAVE_XFT.
7229 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7230 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7231 Move inside HAVE_XFT.
7232 (something_changed_gsettingsCB): Rename from something_changedCB.
7233 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7234 also.
7235 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7236 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7237 (something_changed_gconfCB): Rename from something_changedCB.
7238 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7239 (parse_settings): Move check for font inside HAVE_XFT.
7240 (read_settings, apply_xft_settings): Add comment.
7241 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7242 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7243 call store_font_name_changed.
7244 (xft_settings_event): Add comment.
7245 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7246 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7247 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7248 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7249 (xsettings_initialize): Call init_gsettings last.
7250 (xsettings_get_system_font, xsettings_get_system_normal_font):
7251 Add comment.
7252
7253 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7254
7255 Random fixes. E.g., (random) never returned negative values.
7256 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7257 subseconds part to the entropy, as that's a bit more random.
7258 Prefer signed to unsigned, since the signedness doesn't matter and
7259 in general we prefer signed. When given a limit, use a
7260 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7261 latter isn't right if USE_2_TAGS_FOR_INTS.
7262 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7263 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7264
7265 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7266
7267 * textprop.c (text_property_stickiness):
7268 Obey Vtext_property_default_nonsticky.
7269 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7270 * w32fns.c (syms_of_w32fns):
7271 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7272
7273 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7274
7275 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7276 This is more efficient than Ffile_directory_p and avoids a minor race.
7277
7278 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7279
7280 * buffer.c (Foverlay_put): Say what the return value is
7281 (bug#7835).
7282
7283 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7284 is a directory before asking whether to use the file name
7285 (bug#7564).
7286 (barf_or_query_if_file_exists): Make the "File is a directory"
7287 error be more correct.
7288
7289 * fns.c (Frequire): Remove the mention of the .gz files, since
7290 that's installation-specific, but keep the mention of
7291 `get-load-suffixes'.
7292
7293 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7294
7295 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7296 Report string overflow if the output is too long.
7297
7298 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7299
7300 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7301 (syms_of_gnutls): Remove duplicate DEFSYM for
7302 Qgnutls_bootprop_verify_hostname_error, an error for
7303 Qgnutls_bootprop_verify_error (which is no longer used).
7304
7305 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7306 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7307 Also (re)move comments that are misplaced or no longer relevant.
7308
7309 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7310
7311 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7312
7313 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7314
7315 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7316 and background color parameters if they have been changed.
7317
7318 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7319
7320 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7321
7322 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7323
7324 * xsettings.c (SYSTEM_FONT): Define only when used.
7325 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7326
7327 * keymap.c (access_keymap_1): Now static.
7328
7329 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7330
7331 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7332 leave any prefix arg for the up event (Bug#1586).
7333
7334 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7335
7336 * lread.c (syms_of_lread): Mention single symbols defined by
7337 `defvar' or `defconst' (bug#7154).
7338
7339 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7340 (Frequire): Mention get-load-suffixes.
7341
7342 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7343
7344 * window.h (window): Remove clone_number slot.
7345 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7346 Remove.
7347 (make_parent_window, make_window, saved_window)
7348 (Fset_window_configuration, save_window_save): Don't deal with
7349 clone numbers.
7350 * buffer.c (Qclone_number): Remove declaration.
7351 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7352
7353 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7354
7355 Add multiple inheritance to keymaps.
7356 * keymap.c (Fmake_composed_keymap): New function.
7357 (Fset_keymap_parent): Simplify.
7358 (fix_submap_inheritance): Remove.
7359 (access_keymap_1): New function extracted from access_keymap to handle
7360 embedded parents and handle lists of maps.
7361 (access_keymap): Use it.
7362 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7363 (Fcopy_keymap): Handle embedded parents.
7364 (Fcommand_remapping, define_as_prefix): Simplify.
7365 (Fkey_binding): Simplify.
7366 (syms_of_keymap): Move minibuffer-local-completion-map,
7367 minibuffer-local-filename-completion-map,
7368 minibuffer-local-must-match-map, and
7369 minibuffer-local-filename-must-match-map to Elisp.
7370 (syms_of_keymap): Defsubr make-composed-keymap.
7371 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7372 (parse_menu_item): Trivial simplification.
7373
7374 2011-07-01 Glenn Morris <rgm@gnu.org>
7375
7376 * Makefile.in (SETTINGS_LIBS): Fix typo.
7377
7378 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7379
7380 * coding.c (Fencode_coding_string): Record the last coding system
7381 used, as the function doc string says (bug#8738).
7382
7383 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7384
7385 * xsettings.c (store_monospaced_changed): Take new font as arg and
7386 check for change against current_mono_font.
7387 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7388 (emacs_settings_constructor, emacs_settings_get_property)
7389 (emacs_settings_set_property, emacs_settings_class_init)
7390 (emacs_settings_init, gsettings_obj): Remove.
7391 (something_changedCB): New function for HAVE_GSETTINGS.
7392 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7393 with value as argument.
7394 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7395 g_settings_new (Bug#8967). Do not create gsettings_obj.
7396 Remove calls to g_settings_bind. Connect something_changedCB to
7397 "changed".
7398
7399 * xgselect.c: Add defined (HAVE_GSETTINGS).
7400 (xgselect_initialize): Ditto.
7401
7402 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7403 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7404 xg_select.
7405
7406 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7407
7408 * eval.c (struct backtrace): Simplify and port the data structure.
7409 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7410 signed bit field, as this assumption is not portable and it makes
7411 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7412 "char debug_on_exit : 1" as this is not portable either; instead,
7413 use the portable "unsigned int debug_on_exit : 1". Remove unused
7414 member evalargs. Remove obsolete comments about cc bombing out.
7415
7416 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7417
7418 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7419 Let HAVE_GSETTINGS override HAVE_GCONF.
7420 (store_monospaced_changed): New function.
7421 (EMACS_SETTINGS): A new type derived from GObject to handle
7422 GSettings notifications.
7423 (emacs_settings_constructor, emacs_settings_get_property)
7424 (emacs_settings_set_property, emacs_settings_class_init):
7425 New functions.
7426 (gsettings_client, gsettings_obj): New variables.
7427 (GSETTINGS_SCHEMA): New define.
7428 (something_changedCB): Call store_monospaced_changed.
7429 (init_gsettings): New function.
7430 (xsettings_initialize): Call init_gsettings.
7431 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7432 to NULL.
7433
7434 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7435 GCONF_CFLAGS/LIBS.
7436
7437 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7438
7439 * window.c (resize_root_window, grow_mini_window)
7440 (shrink_mini_window): Rename Qresize_root_window to
7441 Qwindow_resize_root_window and Qresize_root_window_vertically to
7442 Qwindow_resize_root_window_vertically.
7443
7444 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7445
7446 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7447
7448 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7449
7450 * makefile.w32-in: Redesign dependencies so they reflect more
7451 clearly which files are directly included by each source file,
7452 and not through other includes.
7453
7454 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7455
7456 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7457 (sort_overlays, overlay_strings): When an overlay's clone number
7458 matches the window's clone number process the overlay even if
7459 the overlay's window property doesn't match the current window.
7460
7461 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7462 (Fwindow_hchild): Rename to Fwindow_left_child.
7463 (Fwindow_next): Rename to Fwindow_next_sibling.
7464 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7465 (resize_window_check): Rename to window_resize_check.
7466 (resize_window_apply): Rename to window_resize_apply.
7467 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7468 (Fdelete_other_windows_internal, resize_frame_windows)
7469 (Fsplit_window_internal, Fdelete_window_internal)
7470 (grow_mini_window, shrink_mini_window)
7471 (Fresize_mini_window_internal): Fix callers accordingly.
7472
7473 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7474
7475 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7476 (emacs_fixed_set_min_size): Remove.
7477 (emacs_fixed_new): Take frame as argument.
7478
7479 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7480 (_EmacsFixedPrivate): Remove minwidth/height.
7481 Add struct frame *f.
7482 (emacs_fixed_init): Initialize priv->f.
7483 (get_parent_class, emacs_fixed_set_min_size): Remove.
7484 (emacs_fixed_new): Set priv->f to argument.
7485 (emacs_fixed_get_preferred_width)
7486 (emacs_fixed_get_preferred_height): Use min_width/height from
7487 frames size_hint to set minimum and natural (Bug#8919).
7488 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7489 and use min_width/height from frames size_hint to set
7490 min_width/height (Bug#8919).
7491
7492 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7493 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7494 Fix indentation.
7495
7496 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7497
7498 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7499 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7500 called at ZV.
7501
7502 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7503
7504 * process.c (wait_reading_process_output): Bypass select if
7505 waiting for a cell while ignoring keyboard input, and input is
7506 pending. Suggested by Jan Djärv (Bug#8869).
7507
7508 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7509
7510 Use gnulib's dup2 module instead of rolling our own.
7511 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7512
7513 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7514
7515 * dispnew.c (scrolling_window): Before scrolling, turn off a
7516 mouse-highlight in the window being scrolled.
7517
7518 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7519
7520 Move DEFSYM to lisp.h and use everywhere.
7521
7522 * character.h (DEFSYM): Move declaration...
7523 * lisp.h (DEFSYM): ...here.
7524
7525 * gnutls.c:
7526 * minibuf.c:
7527 * w32menu.c:
7528 * w32proc.c:
7529 * w32select.c: Don't include character.h.
7530
7531 * alloc.c (syms_of_alloc):
7532 * buffer.c (syms_of_buffer):
7533 * bytecode.c (syms_of_bytecode):
7534 * callint.c (syms_of_callint):
7535 * casefiddle.c (syms_of_casefiddle):
7536 * casetab.c (init_casetab_once):
7537 * category.c (init_category_once, syms_of_category):
7538 * ccl.c (syms_of_ccl):
7539 * cmds.c (syms_of_cmds):
7540 * composite.c (syms_of_composite):
7541 * dbusbind.c (syms_of_dbusbind):
7542 * dired.c (syms_of_dired):
7543 * dispnew.c (syms_of_display):
7544 * doc.c (syms_of_doc):
7545 * editfns.c (syms_of_editfns):
7546 * emacs.c (syms_of_emacs):
7547 * eval.c (syms_of_eval):
7548 * fileio.c (syms_of_fileio):
7549 * fns.c (syms_of_fns):
7550 * frame.c (syms_of_frame):
7551 * fringe.c (syms_of_fringe):
7552 * insdel.c (syms_of_insdel):
7553 * keymap.c (syms_of_keymap):
7554 * lread.c (init_obarray, syms_of_lread):
7555 * macros.c (syms_of_macros):
7556 * msdos.c (syms_of_msdos):
7557 * print.c (syms_of_print):
7558 * process.c (syms_of_process):
7559 * search.c (syms_of_search):
7560 * sound.c (syms_of_sound):
7561 * syntax.c (init_syntax_once, syms_of_syntax):
7562 * terminal.c (syms_of_terminal):
7563 * textprop.c (syms_of_textprop):
7564 * undo.c (syms_of_undo):
7565 * w32.c (globals_of_w32):
7566 * window.c (syms_of_window):
7567 * xdisp.c (syms_of_xdisp):
7568 * xfaces.c (syms_of_xfaces):
7569 * xfns.c (syms_of_xfns):
7570 * xmenu.c (syms_of_xmenu):
7571 * xsettings.c (syms_of_xsettings):
7572 * xterm.c (syms_of_xterm): Use DEFSYM.
7573
7574 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7575
7576 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7577
7578 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7579
7580 Integer and buffer overflow fixes (Bug#8873).
7581
7582 * print.c (printchar, strout): Check for string overflow.
7583 (PRINTPREPARE, printchar, strout):
7584 Don't set size unless allocation succeeds.
7585
7586 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7587 for sizes. Check for string overflow more accurately.
7588 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7589
7590 * macros.c: Integer and buffer overflow fixes.
7591 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7592 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7593 Use ptrdiff_t, not int, for sizes.
7594 Don't increment bufsize until after realloc succeeds.
7595 Check for size-calculation overflow.
7596 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7597
7598 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7599
7600 * lread.c: Integer overflow fixes.
7601 (read_integer): Radix is now EMACS_INT, not int,
7602 to improve quality of diagnostics for out-of-range radices.
7603 Calculate buffer size correctly for out-of-range radices.
7604 (read1): Check for integer overflow in radices, and in
7605 read-circle numbers.
7606 (read_escape): Avoid int overflow.
7607 (Fload, openp, read_buffer_size, read1)
7608 (substitute_object_recurse, read_vector, read_list, map_obarray):
7609 Use ptrdiff_t, not int, for sizes.
7610 (read1): Use EMACS_INT, not int, for sizes.
7611 Check for size overflow.
7612
7613 * image.c (cache_image): Check for size arithmetic overflow.
7614
7615 * lread.c: Integer overflow issues.
7616 (saved_doc_string_size, saved_doc_string_length)
7617 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7618 Now ptrdiff_t, not int.
7619 (read1): Don't assume doc string length fits in int. Check for
7620 out-of-range doc string lengths.
7621 (read_list): Don't assume file position fits in int.
7622 (read_escape): Check for hex character overflow.
7623
7624 2011-06-22 Leo Liu <sdl.web@gmail.com>
7625
7626 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7627 Move to minibuffer.el.
7628
7629 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7630
7631 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7632 The following patches are for when GLYPH_DEBUG && !XASSERT.
7633 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7634 * dispnew.c (flush_stdout):
7635 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7636 Mark as externally visible.
7637 * dispnew.c (check_window_matrix_pointers): Now static.
7638 * dispnew.c (window_to_frame_vpos):
7639 * xfns.c (unwind_create_frame):
7640 * xterm.c (x_check_font): Remove unused local.
7641 * scroll.c (CHECK_BOUNDS):
7642 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7643 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7644 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7645 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7646 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7647 Now static.
7648 (debug_method_add): Use va_list and vsprintf rather than relying
7649 on undefined behavior with wrong number of arguments.
7650 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7651 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7652 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7653 since we're not interested in debugging glyphs with old libraries.
7654 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7655 GCC 4.6.0's static checking.
7656
7657 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7658
7659 Integer overflow and signedness fixes (Bug#8873).
7660 A few related buffer overrun fixes, too.
7661
7662 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7663
7664 * dispextern.h (struct face.stipple):
7665 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7666 (x_bitmap_mask, x_allocate_bitmap_record)
7667 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7668 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7669 (x_create_bitmap_from_xpm_data):
7670 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7671 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7672 (.bitmaps_last):
7673 * xfaces.c (load_pixmap):
7674 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7675 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7676 (.bitmaps_last, struct x_output.icon_bitmap):
7677 Use ptrdiff_t, not int, for bitmap indexes.
7678 (x_allocate_bitmap_record): Check for size overflow.
7679 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7680
7681 Use ptrdiff_t, not int, for overlay counts.
7682 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7683 * editfns.c (overlays_around, get_pos_property):
7684 * textprop.c (get_char_property_and_overlay):
7685 * xdisp.c (next_overlay_change, note_mouse_highlight):
7686 * xfaces.c (face_at_buffer_position):
7687 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7688 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7689 (Fnext_overlay_change, Fprevious_overlay_change)
7690 (mouse_face_overlay_overlaps, Foverlays_in):
7691 Use ptrdiff_t, not int, for sizes.
7692 (overlays_at, overlays_in): Check for size-calculation overflow.
7693
7694 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7695
7696 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7697 (x_session_initialize): Do not assume string length fits in int.
7698
7699 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7700 This is unlikely, but can occur if DPI is outlandish.
7701
7702 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7703 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7704
7705 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7706 * xrdb.c (magic_file_p, search_magic_path):
7707 Omit last arg SUFFIX; it was always 0. All callers changed.
7708 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7709
7710 * xfont.c (xfont_match): Avoid need for strlen.
7711
7712 * xfns.c: Don't assume strlen fits in int.
7713 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7714
7715 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7716 not unsigned long, as we prefer signed integers. All callers changed.
7717 Detect integer overflow in repeat count.
7718 (message_dolog): Don't assume print length fits in 39 bytes.
7719 (display_mode_element): Don't assume strlen fits in int.
7720
7721 * termcap.c: Don't assume sizes fit in int and never overflow.
7722 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7723 (gobble_line): Check for size-calculation overflow.
7724
7725 * minibuf.c (Fread_buffer):
7726 * lread.c (intern, intern_c_string):
7727 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7728 Don't assume string length fits in int.
7729
7730 * keyboard.c (parse_tool_bar_item):
7731 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7732
7733 * font.c: Don't assume string length fits in int.
7734 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7735 Use ptrdiff_t, not int.
7736 (font_intern_prop): Don't assume string length fits in int.
7737 Don't assume integer property fits in fixnum.
7738 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7739
7740 * filelock.c: Fix some buffer overrun and integer overflow issues.
7741 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7742 Reformulate so as not to need the command string.
7743 Invoke gzip -cd rather than gunzip, as it's more portable.
7744 (lock_info_type, lock_file_1, lock_file):
7745 Don't assume pid_t and time_t fit in unsigned long.
7746 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7747 (current_lock_owner): Prefer signed type for sizes.
7748 Use memcpy, not strncpy, where memcpy is what is really wanted.
7749 Don't assume (via atoi) that time_t and pid_t fit in int.
7750 Check for time_t and/or pid_t out of range, e.g., via a network share.
7751 Don't alloca where an auto var works fine.
7752
7753 * fileio.c: Fix some integer overflow issues.
7754 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7755 Don't assume string length fits in int.
7756 (directory_file_name): Don't assume string length fits in long.
7757 (make_temp_name): Don't assume pid fits in int, or that its print
7758 length is less than 20.
7759
7760 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7761
7762 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7763
7764 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7765
7766 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7767 We prefer signed integers, even for size calculations.
7768
7769 * emacs.c: Don't assume string length fits in 'int'.
7770 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7771 (main): Don't invoke strlen when not needed.
7772
7773 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7774 (XD_DEBUG_MESSAGE): Don't waste a byte.
7775
7776 * callproc.c (getenv_internal_1, getenv_internal)
7777 (Fgetenv_internal):
7778 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7779
7780 * lread.c (invalid_syntax): Omit length argument.
7781 All uses changed. This doesn't fix a bug, but it simplifies the
7782 code away from its former Hollerith-constant appearance, and it's
7783 one less 'int' to worry about when looking at integer-overflow issues.
7784 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7785
7786 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7787 This didn't break anything, but it didn't help either.
7788 It's confusing to put a bogus integer in a place where the actual
7789 value does not matter.
7790 (LIST_END_P): Remove unused macro and its bogus comment.
7791 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7792
7793 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7794 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7795 implementation.
7796 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7797 We prefer signed types, and the value cannot exceed the EMACS_INT
7798 range anyway (because otherwise the length would not be representable).
7799 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7800 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7801 This avoids a GCC warning when WIDE_EMACS_INT.
7802
7803 * indent.c (sane_tab_width): New function.
7804 (current_column, scan_for_column, Findent_to, position_indentation)
7805 (compute_motion): Use it. This is just for clarity.
7806 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7807
7808 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7809
7810 * lisp.h (lint_assume): New macro.
7811 * composite.c (composition_gstring_put_cache):
7812 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7813
7814 * editfns.c, insdel.c:
7815 Omit unnecessary forward decls, to simplify future changes.
7816
7817 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7818
7819 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7820
7821 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7822 Use much-faster test for byte-length change.
7823 Don't assume string byte-length fits in 'int'.
7824 Check that character arg fits in 'int'.
7825 (mapcar1): Declare byte as byte, for clarity.
7826
7827 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7828
7829 * fns.c (concat): Catch string overflow earlier.
7830 Do not rely on integer wraparound.
7831
7832 * dispextern.h (struct it.overlay_strings_charpos)
7833 (struct it.selective): Now EMACS_INT, not int.
7834 * xdisp.c (forward_to_next_line_start)
7835 (back_to_previous_visible_line_start)
7836 (reseat_at_next_visible_line_start, next_element_from_buffer):
7837 Don't arbitrarily truncate the value of 'selective' to int.
7838
7839 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7840
7841 * composite.c: Don't truncate sizes to 'int'.
7842 (composition_gstring_p, composition_reseat_it)
7843 (composition_adjust_point): Use EMACS_INT, not int.
7844 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7845 not EMACS_UINT, for indexes.
7846
7847 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7848
7849 * buffer.c: Include <verify.h>.
7850 (struct sortvec.priority, struct sortstr.priority):
7851 Now EMACS_INT, not int.
7852 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7853 (struct sortstr.size, record_overlay_string)
7854 (struct sortstrlist.size, struct sortlist.used):
7855 Don't truncate size to int.
7856 (record_overlay_string): Check for size-calculation overflow.
7857 (init_buffer_once): Check at compile-time, not run-time.
7858
7859 2011-06-22 Jim Meyering <meyering@redhat.com>
7860
7861 Don't leak an XBM-image-sized buffer
7862 * image.c (xbm_load): Free the image buffer after using it.
7863
7864 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7865
7866 Port to Sun C.
7867 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7868 that Sun C diagnosed.
7869 * fns.c (secure_hash): Fix pointer signedness issue.
7870 * intervals.c (static_offset_intervals): New function.
7871 (offset_intervals): Use it.
7872
7873 2011-06-21 Leo Liu <sdl.web@gmail.com>
7874
7875 * deps.mk (fns.o):
7876 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7877 sha512.h.
7878
7879 * fns.c (secure_hash): Rename from crypto_hash_function and change
7880 the first arg to accept symbols.
7881 (Fsecure_hash): New primitive.
7882 (syms_of_fns): New symbols.
7883
7884 2011-06-20 Deniz Dogan <deniz@dogan.se>
7885
7886 * process.c (Fset_process_buffer): Clarify return value in
7887 docstring.
7888
7889 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7890
7891 * dispnew.c (add_window_display_history): Use BVAR.
7892
7893 * xdisp.c (debug_method_add): Use BVAR.
7894 (check_window_end, dump_glyph_matrix, dump_glyph)
7895 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7896
7897 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7898 Likewise.
7899
7900 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7901 check till after the cache is created in init_frame_faces.
7902
7903 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7904
7905 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7906
7907 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7908
7909 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7910 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7911 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7912
7913 Improve buffer-overflow checking (Bug#8873).
7914 * fileio.c (Finsert_file_contents):
7915 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7916 Remove the old (too-loose) buffer overflow checks.
7917 They weren't needed, since make_gap checks for buffer overflow.
7918 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7919 The old code merely checked for Emacs fixnum overflow, and relied
7920 on undefined (wraparound) behavior. The new code avoids undefined
7921 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7922
7923 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7924 Tune. Don't use wider integers than needed. Don't use alloca.
7925 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7926
7927 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7928
7929 * insdel.c, lisp.h (buffer_overflow): New function.
7930 (insert_from_buffer_1, replace_range, replace_range_2):
7931 * insdel.c (make_gap_larger):
7932 * editfns.c (Finsert_char):
7933 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7934
7935 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7936
7937 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7938
7939 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7940
7941 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7942 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7943
7944 * fileio.c: Don't assume EMACS_INT fits in off_t.
7945 (emacs_lseek): New static function.
7946 (Finsert_file_contents, Fwrite_region): Use it.
7947 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7948
7949 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7950
7951 * fns.c: Don't overflow int when computing a list length.
7952 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7953 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7954 truncation on 64-bit hosts. Check for QUIT every
7955 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7956 faster and is responsive enough.
7957 (Flength): Report an error instead of overflowing an integer.
7958 (Fsafe_length): Return a float if the value is not representable
7959 as a fixnum. This shouldn't happen except in contrived situations.
7960 (Fnthcdr, Fsort): Don't assume list length fits in int.
7961 (Fcopy_sequence): Don't assume vector length fits in int.
7962
7963 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7964 (header_size, word_size): New constants.
7965 (allocate_vectorlike): Don't check size overflow here.
7966 (allocate_vector): Check it here instead, since this is the only
7967 caller of allocate_vectorlike that could cause overflow.
7968 Check that the new vector's length is representable as a fixnum.
7969
7970 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7971 The previous code was bogus. For example, next_almost_prime (32)
7972 returned 39, which is undesirable as it is a multiple of 3; and
7973 next_almost_prime (24) returned 25, which is a multiple of 5 so
7974 why was the code bothering to check for multiples of 7?
7975
7976 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7977
7978 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7979
7980 Variadic C functions now count arguments with ptrdiff_t.
7981 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7982 Back then I didn't know that the Emacs coding style prefers signed int.
7983 Also, in the meantime I found a few more instances where arguments
7984 were being counted with int, which may truncate counts on 64-bit
7985 machines, or EMACS_INT, which may be unnecessarily wide.
7986 * lisp.h (struct Lisp_Subr.function.aMANY)
7987 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7988 Arg counts are now ptrdiff_t, not size_t.
7989 All variadic functions and their callers changed accordingly.
7990 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7991 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7992 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7993 * callint.c (Fcall_interactively): Check arg count for overflow,
7994 to avoid potential buffer overrun. Use signed char, not 'int',
7995 for 'varies' array, so that we needn't bother to check its size
7996 calculation for overflow.
7997 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7998 * eval.c (apply_lambda):
7999 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8000 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8001 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8002
8003 * callint.c (Fcall_interactively): Don't use index var as event count.
8004
8005 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8006 * mem-limits.h (SIZE): Remove; no longer used.
8007
8008 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8009
8010 Remove unnecessary casts.
8011 * xterm.c (x_term_init):
8012 * xfns.c (x_set_border_pixel):
8013 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8014 These aren't needed now that we assume ANSI C.
8015
8016 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8017 It's more likely to cause problems (due to unsigned overflow)
8018 than to cure them.
8019
8020 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8021
8022 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8023
8024 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8025
8026 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8027
8028 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8029
8030 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8031
8032 GLYPH_CODE_FACE returns EMACS_INT, not int.
8033 * dispextern.h (merge_faces):
8034 * xfaces.c (merge_faces):
8035 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8036 Don't assume EMACS_INT fits in int.
8037
8038 * character.h (CHAR_VALID_P): Remove unused parameter.
8039 * fontset.c, lisp.h, xdisp.c: All uses changed.
8040
8041 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8042
8043 * fns.c (concat): Minor tuning based on overflow analysis.
8044 This doesn't fix any bugs. Use int to hold character, instead
8045 of constantly refetching from Emacs object. Use XFASTINT, not
8046 XINT, for value known to be a character. Don't bother comparing
8047 a single byte to 0400, as it's always less.
8048
8049 * floatfns.c (Fexpt):
8050 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8051
8052 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8053 for characters.
8054
8055 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8056
8057 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8058 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8059 incorrectly succeed when S was a string, because 4294967386 was
8060 truncated before it was used.
8061
8062 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8063 Otherwise, an out-of-range integer could cause undefined behavior
8064 on a 64-bit host.
8065
8066 * composite.c: Use int, not EMACS_INT, for characters.
8067 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8068 EMACS_INT, for values that are known to be in character range.
8069 This doesn't fix any bugs but is the usual style inside Emacs and
8070 may generate better code on 32-bit machines.
8071
8072 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8073 This is for reasons similar to the recent CHAR_STRING fix.
8074 * charset.c (Fencode_char): Check that character arg is actually
8075 a character. Pass an int to ENCODE_CHAR.
8076 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8077 wider than 'int', as a compile-time check to prevent future regressions
8078 in this area.
8079
8080 * character.c (char_string): Remove unnecessary casts.
8081
8082 Make sure a 64-bit char is never passed to CHAR_STRING.
8083 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8084 by silently ignoring the top 32 bits, allowing some values
8085 that were far too large to be valid characters.
8086 * character.h: Include <verify.h>.
8087 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8088 arguments are no wider than unsigned, as a compile-time check
8089 to prevent future regressions in this area.
8090 * data.c (Faset):
8091 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8092 (Fsubst_char_in_region):
8093 * fns.c (concat):
8094 * xdisp.c (decode_mode_spec_coding):
8095 Adjust to CHAR_STRING's new requirement.
8096 * editfns.c (Finsert_char, Fsubst_char_in_region):
8097 * fns.c (concat): Check that character args are actually
8098 characters. Without this test, these functions did the wrong
8099 thing with wildly out-of-range values on 64-bit hosts.
8100
8101 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8102 These casts should not be needed on 32-bit hosts, either.
8103 * keyboard.c (read_char):
8104 * lread.c (Fload): Remove casts to unsigned.
8105
8106 * lisp.h (UNSIGNED_CMP): New macro.
8107 This fixes comparison bugs on 64-bit hosts.
8108 (ASCII_CHAR_P): Use it.
8109 * casefiddle.c (casify_object):
8110 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8111 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8112 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8113 * dispextern.h (FACE_FROM_ID):
8114 * keyboard.c (read_char): Use UNSIGNED_CMP.
8115
8116 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8117 not to EMACS_INT, to avoid GCC warning.
8118
8119 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8120
8121 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8122 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8123 isn't needed on 32-bit machines.
8124
8125 * buffer.c (Fgenerate_new_buffer_name):
8126 Use EMACS_INT for count, not int.
8127 (advance_to_char_boundary): Return EMACS_INT, not int.
8128
8129 * data.c (Qcompiled_function): Now static.
8130
8131 * window.c (window_body_lines): Now static.
8132
8133 * image.c (gif_load): Rename local to avoid shadowing.
8134
8135 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8136 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8137 * alloc.c (make_save_value): Integer argument is now of type
8138 ptrdiff_t, not int.
8139 (mark_object): Use ptrdiff_t, not int.
8140 * lisp.h (pD): New macro.
8141 * print.c (print_object): Use it.
8142
8143 * alloc.c: Use EMACS_INT, not int, to count objects.
8144 (total_conses, total_markers, total_symbols, total_vector_size)
8145 (total_free_conses, total_free_markers, total_free_symbols)
8146 (total_free_floats, total_floats, total_free_intervals)
8147 (total_intervals, total_strings, total_free_strings):
8148 Now EMACS_INT, not int. All uses changed.
8149 (Fgarbage_collect): Compute overall total using a double, so that
8150 integer overflow is less likely to be a problem. Check for overflow
8151 when converting back to an integer.
8152 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8153 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8154 These were 'int' variables that could overflow on 64-bit hosts;
8155 they were never used, so remove them instead of repairing them.
8156 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8157 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8158 Previously, this ceilinged at INT_MAX, but that doesn't work on
8159 64-bit machines.
8160 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8161
8162 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8163 (allocate_vectorlike): Check for ptrdiff_t overflow.
8164 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8165 when a (possibly-narrower) signed value would do just as well.
8166 We prefer using signed arithmetic, to avoid comparison confusion.
8167
8168 * alloc.c: Catch some string size overflows that we were missing.
8169 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8170 for convenience in STRING_BYTES_MAX.
8171 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8172 The definition here is exact; the one in lisp.h was approximate.
8173 (allocate_string_data): Check for string overflow. This catches
8174 some instances we weren't catching before. Also, it catches
8175 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8176 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8177 and ptrdiff_t and EMACS_INT are both 64 bits.
8178
8179 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8180 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8181 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8182
8183 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8184
8185 * alloc.c (Fmake_string): Check for out-of-range init.
8186
8187 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8188
8189 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8190
8191 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8192
8193 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8194 xg_get_default_scrollbar_width.
8195
8196 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8197 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8198 (style_changed_cb): Call update_theme_scrollbar_width and call
8199 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8200 all frames (Bug#8505).
8201 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8202 Call gtk_window_set_resizable if HAVE_GTK3.
8203 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8204 and height if HAVE_GTK3 (Bug#8505).
8205 (scroll_bar_width_for_theme): New variable.
8206 (update_theme_scrollbar_width): New function.
8207 (xg_get_default_scrollbar_width): Move code to
8208 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8209 (xg_initialize): Call update_theme_scrollbar_width.
8210
8211 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8212
8213 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8214
8215 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8216
8217 * frame.c (make_frame): Call other_buffer_safely instead of
8218 other_buffer.
8219
8220 * window.c (temp_output_buffer_show): Call display_buffer with
8221 second argument Vtemp_buffer_show_specifiers and reset latter
8222 immediately after the call.
8223 (Vtemp_buffer_show_specifiers): New variable.
8224 (auto_window_vscroll_p, next_screen_context_lines)
8225 (Vscroll_preserve_screen_position): Remove leading asterisks from
8226 doc-strings.
8227
8228 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8229
8230 Fix minor problems found by GCC 4.6.0 static checking.
8231 * buffer.c (Qclone_number): Remove for now, as it's unused.
8232 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8233 (record_buffer): Remove unused local.
8234 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8235 (set_frame_buffer_list): Remove; unused.
8236 * frame.h (other_visible_frames): Remove decl.
8237 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8238 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8239 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8240 if HAVE_GPM.
8241 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8242 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8243 Define only if HAVE_GPM.
8244 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8245 (update_hints_inhibit): Remove; never set. All uses removed.
8246 * widgetprv.h (emacsFrameClassRec): Remove decl.
8247 * window.c (delete_deletable_window): Now returns void, since it
8248 wasn't returning anything.
8249 (compare_window_configurations): Remove unused locals.
8250 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8251 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8252 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8253 the same widths as pointers. This follows up on the 2011-05-06 patch.
8254 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8255 * xterm.h: Likewise.
8256 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8257
8258 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8259
8260 * makefile.w32-in: Update dependencies.
8261 (LISP_H): Add lib/intprops.h.
8262
8263 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8264
8265 * image.c (gif_load): Add animation frame delay to the metadata.
8266 (syms_of_image): Use DEFSYM. New symbol `delay'.
8267
8268 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8269
8270 * window.c (delete_deletable_window): Re-add.
8271 (Fset_window_configuration): Rewrite to handle dead buffers and
8272 consequently deletable windows.
8273 (window_tree, Fwindow_tree): Remove. Supply functionality in
8274 window.el.
8275 (compare_window_configurations): Simplify code.
8276
8277 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8278
8279 * image.c (imagemagick_load_image): Fix type mismatch.
8280 (Fimagemagick_types): Likewise.
8281
8282 * window.h (replace_buffer_in_windows): Declare.
8283
8284 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8285
8286 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8287 Qclone_number. Remove external declaration of Qdelete_window.
8288 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8289 code.
8290 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8291 Run Qbuffer_list_update_hook if allowed.
8292 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8293 buffer list implementation.
8294 (other_buffer_safely): New function.
8295 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8296 calls to replace_buffer_in_windows and
8297 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8298 if allowed.
8299 (record_buffer): Inhibit quitting and rewrite using quittable
8300 functions. Run Qbuffer_list_update_hook if allowed.
8301 (Frecord_buffer, Funrecord_buffer): New functions.
8302 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8303 Move switch-to-buffer to window.el.
8304 (bury-buffer): Move to window.el.
8305 (Vbuffer_list_update_hook): New variable.
8306
8307 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8308 section.
8309
8310 * window.h (resize_frame_windows): Move up in code.
8311 (Fwindow_frame): Remove EXFUN.
8312 (replace_buffer_in_all_windows): Remove prototype.
8313 (replace_buffer_in_windows_safely): Add prototype.
8314
8315 * window.c: Declare Qdelete_window static again. Move down
8316 declaration of select_count.
8317 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8318 (Fother_window): Move to window.el.
8319 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8320 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8321 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8322 window.el.
8323 (replace_buffer_in_windows): Implement by calling
8324 Qreplace_buffer_in_windows.
8325 (replace_buffer_in_all_windows): Remove with some functionality
8326 moved into replace_buffer_in_windows_safely.
8327 (replace_buffer_in_windows_safely): New function.
8328 (select_window_norecord, select_frame_norecord): Move in front
8329 of run_window_configuration_change_hook. Remove now obsolete
8330 declarations.
8331 (Fset_window_buffer): Rewrite doc-string.
8332 Call Qrecord_window_buffer.
8333 (keys_of_window): Move binding for other-window to window.el.
8334
8335 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8336
8337 * dispextern.h (struct image): Replace data member, whose int_val
8338 and ptr_val fields were not used by anything, with a single
8339 lisp_val object.
8340
8341 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8342 (gif_clear_image, gif_load, imagemagick_load_image)
8343 (gs_clear_image, gs_load): Callers changed.
8344
8345 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8346
8347 * buffer.h: Include <time.h>, for time_t.
8348 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8349
8350 Fix minor problems found by static checking.
8351
8352 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8353
8354 Make identifiers static if they are not used in other modules.
8355 * data.c (Qcompiled_function, Qframe, Qvector):
8356 * image.c (QimageMagick, Qsvg):
8357 * minibuf.c (Qmetadata):
8358 * window.c (resize_window_check, resize_root_window): Now static.
8359 * window.h (resize_window_check, resize_root_window): Remove decls.
8360
8361 * window.c (window_deletion_count, delete_deletable_window):
8362 Remove; unused.
8363 (window_body_lines): Now static.
8364 (Fdelete_other_windows_internal): Mark vars as initialized.
8365 Make sure 'resize_failed' is initialized.
8366 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8367 (resize_window_apply): Remove unused local.
8368 * window.h (delete_deletable_window): Remove decl.
8369
8370 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8371 (imagemagick_load_image): Fix pointer signedness problem by changing
8372 last arg from unsigned char * to char *. All uses changed.
8373 Also, fix a local for similar reasons.
8374 Remove unused locals. Remove locals to avoid shadowing.
8375 (fn_rsvg_handle_free): Remove; unused.
8376 (svg_load, svg_load_image): Fix pointer signedness problem.
8377 (imagemagick_load_image): Don't use garbage pointer image_wand.
8378
8379 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8380
8381 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8382
8383 * image.c (gif_load): Fix omitted cast error introduced by
8384 2011-06-06 change.
8385
8386 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8387
8388 * window.h (resize_proportionally, orig_total_lines)
8389 (orig_top_line): Remove from window structure.
8390 (set_window_height, set_window_width, change_window_heights)
8391 (Fdelete_window): Remove prototypes.
8392 (resize_frame_windows): Remove duplicate declaration.
8393
8394 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8395
8396 * window.h (resize_frame_windows, resize_window_check)
8397 (delete_deletable_window, resize_root_window)
8398 (resize_frame_windows): Declare prototypes.
8399
8400 * window.c (resize_window_apply): Make definition be "static" to
8401 match the prototype.
8402
8403 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8404
8405 * window.c: Remove declarations of Qwindow_size_fixed,
8406 window_min_size_1, window_min_size_2, window_min_size,
8407 size_window, window_fixed_size_p, enlarge_window, delete_window.
8408 Remove static from declaration of Qdelete_window, it's
8409 temporarily needed by Fbury_buffer.
8410 (replace_window): Don't assign orig_top_line and
8411 orig_total_lines.
8412 (Fdelete_window, delete_window): Remove. Window deletion is
8413 handled by window.el.
8414 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8415 Replace Fdelete_window calls with calls to Qdelete_window.
8416 (Fdelete_other_windows): Remove. Deleting other windows is
8417 handled by window.el.
8418 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8419 handled in window.el.
8420 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8421 Window minimum sizes are handled in window.el.
8422 (shrink_windows, size_window, set_window_height)
8423 (set_window_width, change_window_heights, window_height)
8424 (window_width, CURBEG, CURSIZE, enlarge_window)
8425 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8426 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8427 handled in window.el.
8428 (make_dummy_parent): Rename to make_parent_window and give it a
8429 second argument horflag.
8430 (make_window): Don't set resize_proportionally any more.
8431 (Fsplit_window): Remove. Windows are split in window.el.
8432 (save_restore_action, save_restore_orig_size)
8433 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8434 Resize mini windows in window.el.
8435 (grow_mini_window, shrink_mini_window): Implement by calling
8436 Qresize_root_window_vertically, resize_window_check and
8437 resize_window_apply.
8438 (saved_window, Fset_window_configuration, save_window_save):
8439 Do not handle orig_top_line, orig_total_lines, and
8440 resize_proportionally.
8441 (window_min_height, window_min_width): Move to window.el.
8442 (keys_of_window): Move bindings for delete-other-windows,
8443 split-window, delete-window and enlarge-window to window.el.
8444
8445 * buffer.c: Temporarily extern Qdelete_window.
8446 (Fbury_buffer): Temporarily call Qdelete_window instead of
8447 Fdelete_window (Fbury_buffer will move to window.el soon).
8448
8449 * frame.c (set_menu_bar_lines_1): Remove code handling
8450 orig_top_line and orig_total_lines.
8451
8452 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8453 set_window_height but set heights directly.
8454 (change_frame_size_1): Use resize_frame_windows.
8455
8456 * xdisp.c (init_xdisp): Don't use set_window_height but set
8457 heights directly.
8458
8459 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8460 Use resize_frame_windows instead of change_window_heights and run
8461 run_window_configuration_change_hook.
8462
8463 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8464 instead of change_window_heights and run
8465 run_window_configuration_change_hook.
8466
8467 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8468
8469 * window.c (replace_window): Rename second argument REPLACEMENT to
8470 NEW. New third argument SETFLAG. Rewrite.
8471 (delete_window, make_dummy_parent): Call replace_window with
8472 third argument 1.
8473 (window_list_1): Move down in code.
8474 (run_window_configuration_change_hook): Move set_buffer part
8475 before select_frame_norecord part in order to unwind correctly.
8476 Rename count1 to count.
8477 (recombine_windows, delete_deletable_window, resize_root_window)
8478 (Fdelete_other_windows_internal)
8479 (Frun_window_configuration_change_hook, make_parent_window)
8480 (resize_window_check, resize_window_apply, Fresize_window_apply)
8481 (resize_frame_windows, Fsplit_window_internal)
8482 (Fdelete_window_internal, Fresize_mini_window_internal):
8483 New functions.
8484 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8485
8486 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8487
8488 * window.h (window): Add some new members to window structure -
8489 normal_lines, normal_cols, new_total, new_normal, clone_number,
8490 splits, nest, prev_buffers, next_buffers.
8491 (WINDOW_TOTAL_SIZE): Move here from window.c.
8492 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8493
8494 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8495 Remove.
8496 (make_dummy_parent): Set new members of windows structure.
8497 (make_window): Move down in code. Handle new members of window
8498 structure.
8499 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8500 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8501 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8502 (Fset_window_prev_buffers, Fwindow_next_buffers)
8503 (Fset_window_next_buffers, Fset_window_clone_number):
8504 New functions.
8505 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8506 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8507 Doc-string fixes.
8508 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8509 Argument WINDOW can be now internal window too.
8510 (Fwindow_use_time): Move up in code.
8511 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8512 Rewrite doc-string.
8513 (Fset_window_configuration, saved_window)
8514 (Fcurrent_window_configuration, save_window_save): Handle new
8515 members of window structure.
8516 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8517 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8518 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8519 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8520 Qget_mru_window, Qresize_root_window,
8521 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8522 Qauto_buffer_name; staticpro them.
8523
8524 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8525
8526 * window.c (Fwindow_total_size, Fwindow_left_column)
8527 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8528 (Fwindow_list_1): New functions.
8529 (window_box_text_cols): Replace with window_body_cols.
8530 (Fwindow_width, Fscroll_left, Fscroll_right):
8531 Use window_body_cols instead of window_box_text_cols.
8532 (delete_window, Fset_window_configuration):
8533 Call delete_all_subwindows with window as argument.
8534 (delete_all_subwindows): Take a window as argument and not a
8535 structure. Rewrite.
8536 (window_loop): Remove handling of GET_LRU_WINDOW and
8537 GET_LARGEST_WINDOW.
8538 (Fget_lru_window, Fget_largest_window): Move to window.el.
8539
8540 * window.h: Extern window_body_cols instead of
8541 window_box_text_cols. delete_all_subwindows now takes a
8542 Lisp_Object as argument.
8543
8544 * indent.c (compute_motion, Fcompute_motion):
8545 Use window_body_cols instead of window_box_text_cols.
8546
8547 * frame.c (delete_frame): Call delete_all_subwindows with root
8548 window as argument.
8549
8550 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8551
8552 * fns.c (Fputhash): Document return value.
8553
8554 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8555
8556 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8557
8558 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8559
8560 Cons<->int and similar integer overflow fixes (Bug#8794).
8561
8562 Check for overflow when converting integer to cons and back.
8563 * charset.c (Fdefine_charset_internal, Fdecode_char):
8564 Use cons_to_unsigned to catch overflow.
8565 (Fencode_char): Use INTEGER_TO_CONS.
8566 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8567 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8568 * data.c (long_to_cons, cons_to_long): Remove.
8569 (cons_to_unsigned, cons_to_signed): New functions.
8570 These signal an error for invalid or out-of-range values.
8571 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8572 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8573 * font.c (Ffont_variation_glyphs):
8574 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8575 * lisp.h: Include <intprops.h>.
8576 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8577 (cons_to_signed, cons_to_unsigned): New decls.
8578 (long_to_cons, cons_to_long): Remove decls.
8579 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8580 (Fprimitive_undo): Use CONS_TO_INTEGER.
8581 * xfns.c (Fx_window_property): Likewise.
8582 * xselect.c: Include <limits.h>.
8583 (x_own_selection, selection_data_to_lisp_data):
8584 Use INTEGER_TO_CONS.
8585 (x_handle_selection_request, x_handle_selection_clear)
8586 (x_get_foreign_selection, Fx_disown_selection_internal)
8587 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8588 (lisp_data_to_selection_data): Use cons_to_unsigned.
8589 (x_fill_property_data): Use cons_to_signed.
8590 Report values out of range.
8591
8592 Check for buffer and string overflow more precisely.
8593 * buffer.h (BUF_BYTES_MAX): New macro.
8594 * lisp.h (STRING_BYTES_MAX): New macro.
8595 * alloc.c (Fmake_string):
8596 * character.c (string_escape_byte8):
8597 * coding.c (coding_alloc_by_realloc):
8598 * doprnt.c (doprnt):
8599 * editfns.c (Fformat):
8600 * eval.c (verror):
8601 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8602 since they may not be the same number.
8603 * editfns.c (Finsert_char):
8604 * fileio.c (Finsert_file_contents):
8605 Likewise for BUF_BYTES_MAX.
8606
8607 * image.c: Use ptrdiff_t, not int, for sizes.
8608 (slurp_file): Switch from int to ptrdiff_t.
8609 All uses changed.
8610 (slurp_file): Check that file size fits in both size_t (for
8611 malloc) and ptrdiff_t (for sanity and safety).
8612
8613 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8614 if b->modtime has its maximal value.
8615
8616 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8617
8618 Don't assume time_t can fit into int.
8619 * buffer.h (struct buffer.modtime): Now time_t, not int.
8620 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8621 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8622
8623 Minor fixes for signed vs unsigned integers.
8624 * character.h (MAYBE_UNIFY_CHAR):
8625 * charset.c (maybe_unify_char):
8626 * keyboard.c (read_char, reorder_modifiers):
8627 XINT -> XFASTINT, since the integer must be nonnegative.
8628 * ftfont.c (ftfont_spec_pattern):
8629 * keymap.c (access_keymap, silly_event_symbol_error):
8630 XUINT -> XFASTINT, since the integer must be nonnegative.
8631 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8632 since it makes no difference and we prefer signed.
8633 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8634 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8635 nonnegative.
8636
8637 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8638
8639 * window.h (Fwindow_frame): Declare.
8640
8641 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8642
8643 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8644 (SPARE_MEMORY): Always define.
8645 (LARGE_REQUEST): Remove.
8646 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8647
8648 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8649
8650 * lisp.h: Move EXFUNS for Fframe_root_window,
8651 Fframe_first_window and Fset_frame_selected_window to window.h.
8652
8653 * window.h: Move EXFUNS for Fframe_root_window,
8654 Fframe_first_window and Fset_frame_selected_window here from
8655 lisp.h.
8656
8657 * frame.c (Fwindow_frame, Fframe_first_window)
8658 (Fframe_root_window, Fframe_selected_window)
8659 (Fset_frame_selected_window): Move to window.c.
8660 (Factive_minibuffer_window): Move to minibuf.c.
8661 (Fother_visible_frames_p): New function.
8662
8663 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8664
8665 * window.c (decode_window, decode_any_window): Move up in code.
8666 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8667 (inhibit_frame_unsplittable): Remove unused variable.
8668 (Fwindow_buffer): Move up and rewrite doc-string.
8669 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8670 (Fwindow_prev): New functions.
8671 (Fwindow_frame): Move here from frame.c. Accept any window as
8672 argument.
8673 (Fframe_root_window, Fframe_first_window)
8674 (Fframe_selected_window): Move here from frame.c. Accept frame
8675 or arbitrary window as argument. Update doc-strings.
8676 (Fminibuffer_window): Move up in code.
8677 (Fwindow_minibuffer_p): Move up in code and simplify.
8678 (Fset_frame_selected_window): Move here from frame.c.
8679 Marginal rewrite.
8680 (Fselected_window, select_window, Fselect_window): Move up in
8681 code. Minor doc-string fixes.
8682
8683 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8684
8685 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8686 Do not assume that spare memory exists; that assumption is valid
8687 only if SYSTEM_MALLOC.
8688 (LARGE_REQUEST): New macro, so that the issue of large requests
8689 is separated from the issue of spare memory.
8690
8691 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8692
8693 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8694 format. (Bug#8806)
8695
8696 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8697
8698 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8699 before statements.
8700
8701 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8702
8703 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8704
8705 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8706
8707 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8708 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8709
8710 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8711
8712 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8713
8714 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8715
8716 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8717 (x_clipboard_manager_save): Add return value.
8718 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8719 New error handlers.
8720 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8721 Obey Vx_select_enable_clipboard_manager. Catch errors in
8722 x_clipboard_manager_save (Bug#8779).
8723 (Vx_select_enable_clipboard_manager): New variable.
8724 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8725
8726 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8727
8728 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8729
8730 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8731
8732 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8733 in the current matrix if keep_current_p is non-zero.
8734
8735 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8736
8737 * bidi.c (bidi_level_of_next_char): Fix last change.
8738
8739 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8740
8741 Support bidi reordering of text covered by display properties.
8742
8743 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8744 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8745 (bidi_cache_search, bidi_cache_iterator_state)
8746 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8747 (bidi_level_of_next_char, bidi_move_to_visually_next):
8748 Support character positions inside a run of characters covered by a
8749 display string.
8750 (bidi_paragraph_init, bidi_resolve_explicit_1)
8751 (bidi_level_of_next_char): Call bidi_fetch_char and
8752 bidi_fetch_char_advance instead of FETCH_CHAR and
8753 FETCH_CHAR_ADVANCE.
8754 (bidi_init_it): Initialize new members.
8755 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8756 definitions.
8757 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8758 instead of using explicit *_CHAR codes.
8759 (bidi_resolve_explicit, bidi_resolve_weak):
8760 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8761 bidirectional text is supported only in multibyte buffers.
8762 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8763 it to initialize the frame_window_p member of struct bidi_it.
8764 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8765 (bidi_resolve_explicit, bidi_resolve_weak)
8766 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8767 bidi_it->nchars is non-positive.
8768 (bidi_level_of_next_char): Don't try to lookup the cache for the
8769 next/previous character if nothing is cached there yet, or if we
8770 were just reseat()'ed to a new position.
8771
8772 * xdisp.c (set_cursor_from_row): Set start and stop points
8773 according to the row's direction when priming the loop that looks
8774 for the glyph on which to display cursor.
8775 (single_display_spec_intangible_p): Function deleted.
8776 (display_prop_intangible_p): Reimplement to call
8777 handle_display_spec instead of single_display_spec_intangible_p.
8778 Accept 3 additional arguments needed by handle_display_spec.
8779 This fixes incorrect cursor motion across display property with complex
8780 values: lists, `(when COND...)' forms, etc.
8781 (single_display_spec_string_p): Support property values that are
8782 lists with the argument STRING its top-level element.
8783 (display_prop_string_p): Fix the condition for processing a
8784 property that is a list to be consistent with handle_display_spec.
8785 (handle_display_spec): New function, refactored from the
8786 last portion of handle_display_prop.
8787 (compute_display_string_pos): Accept additional argument
8788 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8789 value of a `display' property is a "replacing spec".
8790 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8791 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8792 the display property, but just return a value indicating whether
8793 the display property will replace the characters it covers.
8794 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8795 frame_window_p members of struct bidi_it.
8796 (compute_display_string_pos, compute_display_string_end):
8797 New functions.
8798 (push_it): Accept second argument POSITION, where pop_it should
8799 jump to continue iteration.
8800 (reseat_1): Initialize bidi_it.disp_pos.
8801
8802 * keyboard.c (adjust_point_for_property): Adjust the call to
8803 display_prop_intangible_p to its new signature.
8804
8805 * dispextern.h (struct bidi_it): New member frame_window_p.
8806 (bidi_init_it): Update prototypes.
8807 (display_prop_intangible_p): Update prototype.
8808 (compute_display_string_pos, compute_display_string_end):
8809 Declare prototypes.
8810 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8811 EMACS_INT.
8812
8813 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8814
8815 Malloc failure behavior now depends on size of allocation.
8816 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8817 * lisp.h: Change signatures accordingly.
8818 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8819 All callers changed. (Bug#8762)
8820
8821 * gnutls.c: Use Emacs's memory allocators.
8822 Without this change, the gnutls library would invoke malloc etc.
8823 directly, which causes problems on non-SYNC_INPUT hosts, and which
8824 runs afoul of improving memory_full behavior. (Bug#8761)
8825 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8826 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8827 xfree instead of the default malloc, realloc, free.
8828 (Fgnutls_boot): No need to check for memory allocation failure,
8829 since xmalloc does that for us.
8830
8831 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8832 * category.c (hash_get_category_set):
8833 * ccl.c (ccl_driver):
8834 * charset.c (Fdefine_charset_internal):
8835 * charset.h (struct charset.hash_index):
8836 * composite.c (get_composition_id, gstring_lookup_cache)
8837 (composition_gstring_put_cache):
8838 * composite.h (struct composition.hash_index):
8839 * dispextern.h (struct image.hash):
8840 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8841 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8842 (hashfn_equal, hashfn_user_defined, make_hash_table)
8843 (maybe_resize_hash_table, hash_lookup, hash_put)
8844 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8845 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8846 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8847 * image.c (make_image, search_image_cache, lookup_image)
8848 (xpm_put_color_table_h):
8849 * lisp.h (struct Lisp_Hash_Table):
8850 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8851 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8852 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8853 * alloc.c (allocate_vectorlike):
8854 Check for overflow in vector size calculations.
8855 * ccl.c (ccl_driver):
8856 Check for overflow when converting EMACS_INT to int.
8857 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8858 need to be updated by these changes.
8859 * fns.c (make_hash_table, maybe_resize_hash_table):
8860 Check for integer overflow with large hash tables.
8861 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8862 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8863 (SXHASH_REDUCE): New macro.
8864 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8865 Use it instead of discarding useful hash info with large hash values.
8866 (sxhash_float): New function.
8867 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8868 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8869 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8870 Rewrite to use FIXNUM_BITS, as this simplifies things.
8871 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8872 Adjust signatures to match updated version of code.
8873 (consing_since_gc): Now EMACS_INT, since a single hash table can
8874 use more than INT_MAX bytes.
8875
8876 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8877
8878 Make it possible to build with GCC-4.6+ -O2 -flto.
8879
8880 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8881
8882 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8883
8884 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8885 Call minibuffer-inactive-mode.
8886
8887 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8888
8889 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8890 Update dependencies.
8891
8892 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8893
8894 * data.c (init_data): Remove code for UTS, this system is not
8895 supported anymore.
8896
8897 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8898
8899 Don't force ./temacs to start in terminal mode.
8900
8901 * frame.c (make_initial_frame): Initialize faces in all cases, not
8902 only when CANNOT_DUMP is defined.
8903 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8904
8905 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8906
8907 * dispnew.c (add_window_display_history): Use const for the string
8908 pointer. Remove declaration, not needed.
8909
8910 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8911
8912 Use 'inline', not 'INLINE'.
8913 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8914 * alloc.c, fontset.c (INLINE): Remove.
8915 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8916 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8917 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8918 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8919 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8920
8921 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8922
8923 Make it possible to run ./temacs.
8924
8925 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8926 syms_of_callproc does the same thing. Remove test for
8927 "initialized", do it in the caller.
8928 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8929
8930 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8931
8932 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8933 (read_minibuf): Use get_minibuffer.
8934 (syms_of_minibuf): Use DEFSYM.
8935 (Qmetadata): New var.
8936 * data.c (Qbuffer): Don't make it static.
8937 (syms_of_data): Use DEFSYM.
8938
8939 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8940
8941 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8942 (CCL_CODE_MIN): New macro.
8943
8944 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8945
8946 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8947
8948 * eval.c (Qdebug): Now static.
8949 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8950 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8951 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8952
8953 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8954
8955 * image.c: Various fixes to ImageMagick code comments.
8956 (Fimagemagick_types): Doc fix.
8957
8958 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8959
8960 Minor fixes prompted by GCC 4.6.0 warnings.
8961
8962 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8963
8964 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8965 (x_clipboard_manager_save_all): Move extern decl to ...
8966 * xterm.h: ... here, so that it can be checked for consistency.
8967
8968 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8969
8970 * xselect.c (x_clipboard_manager_save_frame)
8971 (x_clipboard_manager_save_all): New functions.
8972 (Fx_clipboard_manager_save): Lisp function deleted.
8973
8974 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8975 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8976
8977 * xterm.h: Update prototype.
8978
8979 2011-05-28 William Xu <william.xwl@gmail.com>
8980
8981 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8982 exiting (Bug#8239).
8983
8984 2011-05-28 Jim Meyering <meyering@redhat.com>
8985
8986 Avoid a sign-extension bug in crypto_hash_function.
8987 * fns.c (to_uchar): Define.
8988 (crypto_hash_function): Use it to convert some newly-signed
8989 variables to unsigned, to avoid sign-extension bugs. For example,
8990 without this change, (md5 "truc") would evaluate to
8991 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8992 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8993 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8994
8995 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8996
8997 Integer overflow fixes.
8998
8999 * dbusbind.c: Serial number integer overflow fixes.
9000 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9001 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9002 to hold a serial number that is too large for a fixnum.
9003 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9004 Check for serial numbers out of range. Decode any serial number
9005 that was so large that it became a float. (Bug#8722)
9006
9007 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9008 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9009 Use XFASTINT rather than XUINT when numbers are nonnegative.
9010 (xd_append_arg, Fdbus_method_return_internal):
9011 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9012 arguments, check that Lisp number is nonnegative, rather than
9013 silently wrapping negative numbers around. (Bug#8722)
9014 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9015 (Bug#8722)
9016
9017 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9018
9019 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9020
9021 ccl: Add integer overflow checks.
9022 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9023 (IN_INT_RANGE): New macros.
9024 (ccl_driver): Use them to check for integer overflow when
9025 decoding a CCL program. Many of the new checks are whether XINT (x)
9026 fits in int; it doesn't always, on 64-bit hosts. The new version
9027 doesn't catch all possible integer overflows, but it's an
9028 improvement. (Bug#8719)
9029
9030 * alloc.c (make_event_array): Use XINT, not XUINT.
9031 There's no need for unsigned here.
9032
9033 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9034 This follows up to the 2011-05-06 change that substituted uintptr_t
9035 for EMACS_INT. This case wasn't caught back then.
9036
9037 Rework Fformat to avoid integer overflow issues.
9038 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9039 now (part of C89). Include <verify.h>.
9040 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9041 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9042 (Fformat): Avoid the prepass trying to compute sizes; it was only
9043 approximate and thus did not catch overflow reliably. Instead, walk
9044 through the format just once, formatting and computing sizes as we go,
9045 checking for integer overflow at every step, and allocating a larger
9046 buffer as needed. Keep track separately whether the format is
9047 multibyte. Keep only the most-recently calculated precision, rather
9048 than them all. Record whether each argument has been converted to
9049 string. Use EMACS_INT, not int, for byte and char and arg counts.
9050 Support field widths and precisions larger than INT_MAX. Avoid
9051 sprintf's undefined behavior with conversion specifications such as %#d
9052 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9053 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9054 formatting out-of-range floating point numbers with int
9055 formats. (Bug#8668)
9056
9057 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9058
9059 * data.c: Avoid integer truncation in expressions involving floats.
9060 * data.c: Include <intprops.h>.
9061 (arith_driver): When there's an integer overflow in an expression
9062 involving floating point, convert the integers to floating point
9063 so that the resulting value does not suffer from catastrophic
9064 integer truncation. For example, on a 64-bit host (* 4
9065 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9066 Do not rely on undefined behavior after integer overflow.
9067
9068 merge count_size_as_multibyte, parse_str_to_multibyte
9069 * character.c, character.h (count_size_as_multibyte):
9070 Rename from parse_str_to_multibyte; all uses changed.
9071 Check for integer overflow.
9072 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9073 since it's now a duplicate of the other. This is more of
9074 a character than a buffer op, so better that it's in character.c.
9075 * fns.c, print.c: Adjust to above changes.
9076
9077 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9078
9079 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9080
9081 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9082
9083 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9084 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9085 (x_clipboard_manager_save): Now static.
9086 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9087
9088 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9089 (crypto_hash_function): Now static.
9090 Fix pointer signedness problems. Avoid unnecessary initializations.
9091
9092 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9093
9094 * termhooks.h (Vselection_alist): Make it terminal-local.
9095
9096 * terminal.c (create_terminal): Initialize it.
9097
9098 * xselect.c: Support for clipboard managers.
9099 (Vselection_alist): Move to termhooks.h as terminal-local var.
9100 (LOCAL_SELECTION): New macro.
9101 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9102 (symbol_to_x_atom): Remove gratuitous arg.
9103 (x_handle_selection_request, lisp_data_to_selection_data)
9104 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9105 (x_own_selection, x_get_local_selection, x_convert_selection):
9106 New arg, specifying work frame. Use terminal-local Vselection_alist.
9107 (some_frame_on_display): Delete unused function.
9108 (Fx_own_selection_internal, Fx_get_selection_internal)
9109 (Fx_disown_selection_internal, Fx_selection_owner_p)
9110 (Fx_selection_exists_p): New optional frame arg.
9111 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9112 (x_handle_selection_clear): Don't treat other terminals with the
9113 same keyboard specially. Use the terminal-local Vselection_alist.
9114 (x_clear_frame_selections): Use Frun_hook_with_args.
9115
9116 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9117
9118 * xterm.h: Add support for those atoms.
9119
9120 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9121
9122 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9123 (converted_selections, conversion_fail_tag): New global variables.
9124 (x_selection_request_lisp_error): Free the above.
9125 (x_get_local_selection): Remove unnecessary code.
9126 (x_reply_selection_request): Args changed; handle arbitrary array
9127 of converted selections stored in converted_selections.
9128 Separate the XChangeProperty and SelectionNotify steps.
9129 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9130 (x_convert_selection): New function.
9131 (x_handle_selection_event): Simplify.
9132 (x_get_foreign_selection): Don't ignore incoming requests while
9133 waiting for an answer; this will fail when we implement
9134 SAVE_TARGETS, and seems unnecessary anyway.
9135 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9136 (Vx_sent_selection_functions): Doc fix.
9137
9138 2011-05-26 Leo Liu <sdl.web@gmail.com>
9139
9140 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9141
9142 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9143
9144 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9145
9146 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9147 for fringe update if it has periodic bitmap.
9148 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9149 and fringe_bitmap_periodic_p.
9150
9151 * fringe.c (get_fringe_bitmap_data): New function.
9152 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9153 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9154 row. Mark glyph row for fringe update if periodicity changed.
9155
9156 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9157 for fringe update unless it has periodic bitmap.
9158
9159 2011-05-25 Kenichi Handa <handa@m17n.org>
9160
9161 * xdisp.c (get_next_display_element): Set correct it->face_id for
9162 a static composition.
9163
9164 2011-05-24 Leo Liu <sdl.web@gmail.com>
9165
9166 * deps.mk (fns.o):
9167 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9168
9169 * fns.c (crypto_hash_function, Fsha1): New function.
9170 (Fmd5): Use crypto_hash_function.
9171 (syms_of_fns): Add Ssha1.
9172
9173 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9174
9175 * gnutls.c: Remove unused macros.
9176 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9177 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9178 Remove macros that are defined and never used.
9179 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9180
9181 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9182
9183 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9184 (Fx_get_selection_internal): Minor cleanup.
9185 (Fx_own_selection_internal): Rename arguments for consistency with
9186 select.el.
9187
9188 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9189
9190 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9191
9192 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9193
9194 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9195
9196 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9197
9198 * dispnew.c (scrolling_window): Don't exclude the case that the
9199 last enabled row in the desired matrix touches the bottom boundary.
9200
9201 2011-05-21 Glenn Morris <rgm@gnu.org>
9202
9203 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9204 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9205 and add some more files.
9206
9207 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9208
9209 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9210 report_file_error introduced by the change from 2011-05-07.
9211
9212 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9213
9214 * systime.h (Time): Define only if emacs is defined.
9215 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9216 where the include path doesn't have X11/X.h by default. See
9217 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9218
9219 2011-05-20 Kenichi Handa <handa@m17n.org>
9220
9221 * composite.c (find_automatic_composition): Fix previous change.
9222
9223 2011-05-20 Glenn Morris <rgm@gnu.org>
9224
9225 * lisp.mk: New file, split from Makefile.in.
9226 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9227 (shortlisp): Remove.
9228 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9229
9230 2011-05-19 Glenn Morris <rgm@gnu.org>
9231
9232 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9233 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9234 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9235 (lisp): Set the order to that of loadup.el.
9236 (shortlisp): Make it a copy of $lisp.
9237 (SOME_MACHINE_LISP): Remove.
9238 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9239 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9240
9241 2011-05-18 Kenichi Handa <handa@m17n.org>
9242
9243 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9244 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9245 (find_automatic_composition): Mostly rewrite for efficiency.
9246
9247 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9248
9249 * makefile.w32-in: Update dependencies.
9250
9251 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9252
9253 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9254 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9255
9256 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9257
9258 Fix some integer overflow issues, such as string length overflow.
9259
9260 * insdel.c (count_size_as_multibyte): Check for string overflow.
9261
9262 * character.c (lisp_string_width): Check for string overflow.
9263 Use EMACS_INT, not int, for string indexes and lengths; in
9264 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9265 the resulting string length overflows an EMACS_INT; instead,
9266 report a string overflow if no precision given. When checking for
9267 precision exhaustion, use a check that cannot possibly have
9268 integer overflow. (Bug#8675)
9269 * character.h (lisp_string_width): Adjust to new signature.
9270
9271 * alloc.c (string_overflow): New function.
9272 (Fmake_string): Use it. This doesn't change behavior, but saves
9273 a few bytes and will simplify future changes.
9274 * character.c (string_escape_byte8): Likewise.
9275 * lisp.h (string_overflow): New decl.
9276
9277 Fixups, following up to the user-interface timestamp change.
9278 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9279 for UI timestamps, instead of unsigned long.
9280 * msdos.c (mouse_get_pos): Likewise.
9281 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9282 * w32gui.h (Time): Define by including "systime.h" rather than by
9283 declaring it ourselves. (Bug#8664)
9284
9285 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9286 * image.c (clear_image_cache): Likewise.
9287
9288 * term.c (term_mouse_position): Don't assume time_t wraparound.
9289
9290 Be more systematic about user-interface timestamps.
9291 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9292 and sometimes 'EMACS_UINT', to represent these timestamps.
9293 This change causes it to use 'Time' uniformly, as that's what X uses.
9294 This makes the code easier to follow, and makes it easier to catch
9295 integer overflow bugs such as Bug#8664.
9296 * frame.c (Fmouse_position, Fmouse_pixel_position):
9297 Use Time, not unsigned long, for user-interface timestamps.
9298 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9299 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9300 * keyboard.h (last_event_timestamp): Likewise.
9301 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9302 * menu.h (xmenu_show): Likewise.
9303 * term.c (term_mouse_position): Likewise.
9304 * termhooks.h (struct input_event.timestamp): Likewise.
9305 (struct terminal.mouse_position_hook): Likewise.
9306 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9307 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9308 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9309 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9310 what it was before.
9311 * menu.h, termhooks.h: Include "systime.h", for Time.
9312
9313 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9314 Don't assume that the difference between two unsigned long values
9315 can fit into an integer. At this point, we know button_down_time
9316 <= event->timestamp, so the difference must be nonnegative, so
9317 there's no need to cast the result if double-click-time is
9318 nonnegative, as it should be; check that it's nonnegative, just in
9319 case. This bug is triggered when events are more than 2**31 ms
9320 apart (about 25 days). (Bug#8664)
9321
9322 * xselect.c (last_event_timestamp): Remove duplicate decl.
9323 (x_own_selection): Remove needless cast to unsigned long.
9324
9325 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9326 that always fit in int. Use a sentinel instead of a counter, to
9327 avoid a temp and to allay GCC's concerns about possible int overflow.
9328 * frame.h (struct frame): Use int for menu_bar_items_used
9329 instead of EMACS_INT, since it always fits in int.
9330
9331 * menu.c (grow_menu_items): Check for int overflow.
9332
9333 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9334
9335 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9336 Before, the code was not consistent. These values cannot exceed
9337 2**31 - 1 so there's no need to make them unsigned.
9338 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9339 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9340 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9341 as modifiers.
9342 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9343
9344 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9345 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9346 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9347 presumably because the widths might not match.
9348
9349 * window.c (size_window): Avoid needless test at loop start.
9350
9351 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9352
9353 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9354
9355 2011-05-12 Drew Adams <drew.adams@oracle.com>
9356
9357 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9358
9359 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9360
9361 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9362 `width' to `bar_area_x' and `bar_area_width', respectively.
9363 (x_scroll_run): Take account of fringe background extension.
9364
9365 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9366 Rename local vars `left' and `width' to `bar_area_x' and
9367 `bar_area_width', respectively.
9368 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9369 background extension.
9370
9371 2011-05-10 Jim Meyering <meyering@redhat.com>
9372
9373 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9374
9375 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9376
9377 * image.c (Finit_image_library): Return t for built-in image types,
9378 like pbm and xbm. (Bug#8640)
9379
9380 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9381
9382 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9383
9384 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9385
9386 * w32console.c (Fset_screen_color): Doc fix.
9387 (Fget_screen_color): New function.
9388 (syms_of_ntterm): Defsubr it.
9389
9390 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9391 unlink the temporary file if Fcall_process didn't create it in the
9392 first place.
9393 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9394 child process will be redirected to a file specified with `:file'.
9395 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9396 cue to call_process_cleanup not to close that handle.
9397
9398 2011-05-07 Ben Key <bkey76@gmail.com>
9399
9400 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9401 one of two shell specific rules, either bootstrap-temacs-CMD or
9402 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9403 to the previous implementation of the bootstrap-temacs rule.
9404 The bootstrap-temacs-CMD rule is similar to the previous
9405 implementation of the bootstrap-temacs rule except that it
9406 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9407 variable.
9408
9409 These changes, along with some changes to nt/configure.bat,
9410 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9411 earlier fix to add support for --cflags and --ldflags options
9412 that include quotes so that it works whether make uses cmd or
9413 sh as the shell.
9414
9415 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9416
9417 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9418 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9419 is a constant.
9420 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9421 a string. Handle both cases.
9422 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9423 (Fdbus_register_method): Use Qinvalid_function.
9424
9425 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9426
9427 * makefile.w32-in: Update dependencies.
9428 (LISP_H): Add inttypes.h and stdin.h.
9429 (PROCESS_H): Add unistd.h.
9430
9431 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9432
9433 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9434 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9435
9436 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9437
9438 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9439
9440 * term.c (vfatal): Remove stray call to va_end.
9441 It's not needed and the C Standard doesn't allow it here anyway.
9442
9443 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9444 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9445
9446 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9447 bytes.
9448
9449 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9450
9451 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9452
9453 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9454
9455 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9456
9457 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9458
9459 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9460 * charset.c (Fdefine_charset_internal): Don't initialize
9461 charset.code_space[15]. The value was garbage, on hosts with
9462 32-bit int (Bug#8600).
9463
9464 * lread.c (read_integer): Be more consistent with string-to-number.
9465 Use string_to_number to do the actual conversion; this avoids
9466 rounding errors and fixes some other screwups. Without this fix,
9467 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9468 (digit_to_number): Move earlier, for benefit of read_integer.
9469 Return -1 if the digit is out of range for the base, -2 if it is
9470 not a digit in any supported base. (Bug#8602)
9471
9472 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9473
9474 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9475 to match comment at start of function. This also removes a
9476 GCC warning about overflow in a 32+64-bit port.
9477
9478 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9479
9480 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9481 Reported by Stefan Monnier in
9482 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9483 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9484 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9485
9486 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9487 (EMACS_UINTPTR): Likewise, with uintptr_t.
9488
9489 * lisp.h: Prefer 64-bit EMACS_INT if available.
9490 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9491 on 32-bit hosts that have 64-bit int, so that they can access
9492 large files.
9493 However, temporarily disable this change unless the temporary
9494 symbol WIDE_EMACS_INT is defined.
9495
9496 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9497
9498 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9499 This removes an assumption that EMACS_INT and long are the same
9500 width as pointers. The assumption is true for Emacs porting targets
9501 now, but we want to make other targets possible.
9502 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9503 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9504 In the rest of the code, change types of integers that hold casted
9505 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9506 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9507 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9508 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9509 No need to cast type when ORing.
9510 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9511 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9512 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9513 assume EMACS_INT is the same width as char *.
9514 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9515 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9516 Remove no-longer-needed casts.
9517 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9518 (xg_tool_bar_help_callback, xg_make_tool_item):
9519 Use EMACS_INTPTR to hold an integer
9520 that will be cast to void *; this can avoid a GCC warning
9521 if EMACS_INT is not the same width as void *.
9522 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9523 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9524 (current_message_1, set_message_1):
9525 Use a local to convert to proper width without a cast.
9526 * xmenu.c (dialog_selection_callback): Likewise.
9527
9528 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9529 Also, don't assume VALBITS / RAND_BITS is less than 5,
9530 and don't rely on undefined behavior when shifting a 1 left into
9531 the sign bit.
9532 * lisp.h (get_random): Change signature to match.
9533
9534 * lread.c (hash_string): Use size_t, not int, for hash computation.
9535 Normally we prefer signed values; but hashing is special, because
9536 it's better to use unsigned division on hash table sizes so that
9537 the remainder is nonnegative. Also, size_t is the natural width
9538 for hashing into memory. The previous code used 'int', which doesn't
9539 retain enough info to hash well into very large tables.
9540 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9541
9542 * dbusbind.c: Don't possibly lose pointer info when converting.
9543 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9544 Use XPNTR rather than XHASH, so that the high-order bits of
9545 the pointer aren't lost when converting through void *.
9546
9547 * eval.c (Fautoload): Don't double-shift a pointer.
9548
9549 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9550
9551 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9552
9553 * gnutls.c (DEF_GNUTLS_FN):
9554 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9555
9556 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9557
9558 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9559 marker. (Bug#8610)
9560
9561 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9562
9563 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9564 New version that can reserve upto 2GB of heap space.
9565
9566 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9567
9568 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9569
9570 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9571
9572 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9573 `gnutls_certificate_set_x509_key_file'.
9574
9575 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9576
9577 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9578 Update dependencies.
9579
9580 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9581
9582 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9583 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9584 Remove unused parameter `fildes'.
9585 * process.c (read_process_output, send_process): Don't pass it.
9586
9587 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9588
9589 Fix previous change: the library cache is defined in w32.c.
9590 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9591 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9592
9593 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9594
9595 Implement dynamic loading of GnuTLS on Windows.
9596
9597 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9598 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9599 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9600 Declare.
9601
9602 * gnutls.c (Qgnutls_dll): Define.
9603 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9604 (gnutls_*): Declare function pointers.
9605 (init_gnutls_functions): New function to initialize function pointers.
9606 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9607 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9608 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9609 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9610 (emacs_gnutls_write, emacs_gnutls_read)
9611 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9612 (Fgnutls_available_p): New function.
9613 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9614 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9615 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9616
9617 * image.c: Include w32.h.
9618 (Vimage_type_cache): Delete.
9619 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9620 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9621 (w32_delayed_load): Move to w32.c.
9622
9623 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9624
9625 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9626 (w32_delayed_load): Move from image.c. When loading a library, record
9627 its filename in the :loaded-from property of the library id.
9628 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9629 Initialize and staticpro them.
9630 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9631
9632 * process.c: Include lisp.h before w32.h, not after.
9633 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9634 instead of gnutls_record_check_pending.
9635
9636 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9637
9638 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9639
9640 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9641 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9642 as passed in.
9643
9644 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9645
9646 * xterm.c (x_set_frame_alpha): Do not set property on anything
9647 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9648
9649 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9650
9651 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9652
9653 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9654
9655 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9656 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9657 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9658 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9659 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9660 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9661 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9662 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9663 (Qgnutls_bootprop_callbacks_verify): Make static.
9664
9665 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9666
9667 * callproc.c: Indentation fixup.
9668
9669 * sysdep.c (wait_for_termination_1): Make static.
9670 (wait_for_termination, interruptible_wait_for_termination):
9671 Move after wait_for_termination_1.
9672
9673 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9674
9675 * sysdep.c (interruptible_wait_for_termination): New function
9676 which is like wait_for_termination, but allows keyboard
9677 interruptions.
9678
9679 * callproc.c (Fcall_process): Add (:file "file") as an option for
9680 the STDOUT buffer.
9681 (Fcall_process_region): Ditto.
9682
9683 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9684
9685 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9686 rather than `XVECTOR (FOO)->size'.
9687
9688 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9689 inttypes.h, as a gnulib replacement is used if it not available in
9690 system headers.
9691
9692 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9693
9694 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9695 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9696 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9697
9698 * coding.c (coding_alloc_by_realloc): Error out if destination
9699 will grow beyond MOST_POSITIVE_FIXNUM.
9700 (decode_coding_emacs_mule): Abort if there isn't enough place in
9701 charbuf for the composition carryover bytes. Reserve an extra
9702 space for up to 2 characters produced in a loop.
9703 (decode_coding_iso_2022): Abort if there isn't enough place in
9704 charbuf for the composition carryover bytes.
9705
9706 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9707
9708 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9709 aborting when %lld or %lll format is passed.
9710 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9711 %llo or %llx format is passed. (Bug#8545)
9712
9713 * window.c (window_scroll_line_based): Use a marker instead of
9714 simple variables to record original value of point. (Bug#7952)
9715
9716 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9717 produced by %s or %c overflows available buffer space. (Bug#8545)
9718
9719 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9720
9721 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9722 (SIZE_MAX): Move defn after all includes, as they might #define it.
9723
9724 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9725
9726 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9727
9728 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9729
9730 * keyboard.c (Qdelayed_warnings_hook): Define.
9731 (command_loop_1): Run `delayed-warnings-hook'
9732 if Vdelayed_warnings_list is non-nil.
9733 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9734 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9735
9736 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9737
9738 * doprnt.c (doprnt): Don't return value smaller than the buffer
9739 size if the message was truncated. (Bug#8545).
9740
9741 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9742
9743 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9744 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9745
9746 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9747
9748 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9749
9750 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9751
9752 * makefile.w32-in: Update dependencies.
9753
9754 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9755
9756 Improve `doprnt' and its usage. (Bug#8545)
9757 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9758 `format_end'. Remove support for %l as a conversion specifier.
9759 Don't use xrealloc. Improve diagnostics when the %l size modifier
9760 is used. Update the commentary.
9761
9762 * eval.c (verror): Simplify calculation of size_t.
9763
9764 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9765 messages.
9766
9767 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9768
9769 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9770 change.
9771
9772 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9773
9774 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9775 This makes this file independent of the recent pseudovector change.
9776
9777 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9778
9779 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9780
9781 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9782 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9783 Remove unused local.
9784 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9785
9786 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9787 GCC 4.6.0 optimizes based on type-based alias analysis.
9788 For example, if b is of type struct buffer * and v of type struct
9789 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9790 != &v->size, and therefore "v->size = 1; b->size = 2; return
9791 v->size;" must therefore return 1. This assumption is incorrect
9792 for Emacs, since it type-puns struct Lisp_Vector * with many other
9793 types. To fix this problem, this patch adds a new type struct
9794 vectorlike_header that documents the constraints on layout of vectors
9795 and pseudovectors, and helps optimizing compilers not get fooled
9796 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9797 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9798 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9799 the size member.
9800 (XSETPVECTYPE): Rewrite in terms of new macro.
9801 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9802 This is a bit clearer, and further avoids the possibility of
9803 undesirable aliasing.
9804 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9805 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9806 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9807 since Lisp_Subr is a special case (no "next" field).
9808 (ASIZE): Now uses header.size rather than size.
9809 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9810 to avoid the hassle of writing XVECTOR (foo)->header.size.
9811 (struct vectorlike_header): New type.
9812 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9813 object, to help avoid aliasing.
9814 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9815 (SUBRP): Likewise, since Lisp_Subr is a special case.
9816 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9817 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9818 (struct Lisp_Hash_Table): Combine first two members into a single
9819 struct vectorlike_header member. All uses of "size" and "next" members
9820 changed to be "header.size" and "header.next".
9821 * buffer.h (struct buffer): Likewise.
9822 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9823 * frame.h (struct frame): Likewise.
9824 * process.h (struct Lisp_Process): Likewise.
9825 * termhooks.h (struct terminal): Likewise.
9826 * window.c (struct save_window_data, struct saved_window): Likewise.
9827 * window.h (struct window): Likewise.
9828 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9829 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9830 * buffer.c (init_buffer_once): Likewise.
9831 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9832 special case.
9833 * process.c (Fformat_network_address): Use local var for size,
9834 for brevity.
9835
9836 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9837
9838 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9839 * data.c (atof): Remove decl; no longer used or needed.
9840 (digit_to_number): Move to lread.c.
9841 (Fstring_to_number): Use new string_to_number function, to be
9842 consistent with how the Lisp reader treats infinities and NaNs.
9843 Do not assume that floating-point numbers represent EMACS_INT
9844 without losing information; this is not true on most 64-bit hosts.
9845 Avoid double-rounding errors, by insisting on integers when
9846 parsing non-base-10 numbers, as the documentation specifies.
9847 * lisp.h (string_to_number): New decl, replacing ...
9848 (isfloat_string): Remove.
9849 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9850 (read1): Do not accept +. and -. as integers; this
9851 appears to have been a coding error. Similarly, do not accept
9852 strings like +-1e0 as floating point numbers. Do not report
9853 overflow for integer overflows unless the base is not 10 which
9854 means we have no simple and reliable way to continue.
9855 Break out the floating-point parsing into a new
9856 function string_to_number, so that Fstring_to_number parses
9857 floating point numbers consistently with the Lisp reader.
9858 (digit_to_number): Move here from data.c. Make it static inline.
9859 (E_CHAR, EXP_INT): Remove, replacing with ...
9860 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9861 (string_to_number): New function, replacing isfloat_string.
9862 This function checks for valid syntax and produces the resulting
9863 Lisp float number too. Rework it so that string-to-number
9864 no longer mishandles examples like "1.0e+". Use strtoumax,
9865 so that overflow for non-base-10 numbers is reported only when
9866 there's no portable and simple way to convert to floating point.
9867
9868 * textprop.c (set_text_properties_1): Rewrite for clarity,
9869 and to avoid GCC warning about integer overflow.
9870
9871 * intervals.h (struct interval): Use EMACS_INT for members
9872 where EMACS_UINT might cause problems. See
9873 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9874 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9875 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9876 All uses changed.
9877 (offset_intervals): Tell GCC not to worry about length overflow
9878 when negating a negative length.
9879
9880 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9881 (overrun_check_free): Likewise.
9882
9883 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9884 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9885 word size.
9886
9887 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9888 (gnutls_make_error): Rename local to avoid shadowing.
9889 (gnutls_emacs_global_deinit): ifdef out; not used.
9890 (Fgnutls_boot): Use const for pointer to readonly storage.
9891 Comment out unused local. Fix pointer signedness problems.
9892
9893 * lread.c (openp): Don't stuff size_t into an 'int'.
9894 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9895 about possible signed overflow.
9896
9897 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9898 (GDK_KEY_g): Don't define if already defined.
9899 (xg_prepare_tooltip): Avoid pointer signedness problem.
9900 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9901
9902 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9903 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9904
9905 * xfns.c (Fx_window_property): Simplify a bit,
9906 to make a bit faster and to avoid GCC 4.6.0 warning.
9907 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9908
9909 * fns.c (internal_equal): Don't assume size_t fits in int.
9910
9911 * alloc.c (compact_small_strings): Tighten assertion a little.
9912
9913 Replace pEd with more-general pI, and fix some printf arg casts.
9914 * lisp.h (pI): New macro, generalizing old pEd macro to other
9915 conversion specifiers. For example, use "...%"pI"d..." rather
9916 than "...%"pEd"...".
9917 (pEd): Remove. All uses replaced with similar uses of pI.
9918 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9919 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9920 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9921 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9922 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9923 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9924 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9925 64-bit hosts.
9926 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9927 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9928 * print.c (safe_debug_print, print_object): Likewise.
9929 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9930 to int.
9931 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9932 avoiding the 0 flag, which is not portable.
9933 * process.c (Fmake_network_process): Use pI to avoid cast.
9934 * region-cache.c (pp_cache): Likewise.
9935 * xdisp.c (decode_mode_spec): Likewise.
9936 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9937 behavior on 64-bit hosts with printf arg.
9938 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9939 (x_stop_queuing_selection_requests): Likewise.
9940 (x_get_window_property): Don't truncate byte count to an 'int'
9941 when tracing.
9942
9943 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9944 here, since it parses constructs like leading '-' and spaces,
9945 which are not wanted; and it overflows with large numbers.
9946 Instead, simply match F[0-9]+, which is what is wanted anyway.
9947
9948 * alloc.c: Remove unportable assumptions about struct layout.
9949 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9950 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9951 (allocate_vectorlike, make_pure_vector): Use the new macros,
9952 plus offsetof, to remove unportable assumptions about struct layout.
9953 These assumptions hold on all porting targets that I know of, but
9954 they are not guaranteed, they're easy to remove, and removing them
9955 makes further changes easier.
9956
9957 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9958 This doesn't fix a bug but makes the code clearer.
9959 (string_overrun_cookie): Now const. Use initializers that
9960 don't formally overflow signed char, to avoid warnings.
9961 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9962 can cause Emacs to crash when string overrun checking is enabled.
9963 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9964 multiple of sizeof (EMACS_INT); it need not be, if
9965 alignof(EMACS_INT) < sizeof (EMACS_INT).
9966 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9967
9968 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9969
9970 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9971
9972 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9973
9974 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9975 supposed to be handshaking. (Bug#8556)
9976 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9977
9978 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9979
9980 * lisp.h (Qdebug): List symbol.
9981 * eval.c (Qdebug): Restore global linkage.
9982 * keyboard.c (debug-on-event): New variable.
9983 (handle_user_signal): Break into debugger when debug-on-event
9984 matches the current signal symbol.
9985
9986 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9987
9988 * alloc.c (check_sblock, check_string_bytes)
9989 (check_string_free_list): Convert to standard C.
9990
9991 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9992
9993 * w32.c (emacs_gnutls_push): Fix typo.
9994
9995 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9996
9997 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9998 "cast to pointer from integer of different size".
9999
10000 Improve doprnt and its use in verror. (Bug#8545)
10001 * doprnt.c (doprnt): Document the set of format control sequences
10002 supported by the function. Use SAFE_ALLOCA instead of always
10003 using `alloca'.
10004
10005 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10006 is one byte too soon. Don't use xrealloc; instead xfree and
10007 xmalloc anew.
10008
10009 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10010
10011 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10012 callbacks stage.
10013
10014 * gnutls.c: Renamed global_initialized to
10015 gnutls_global_initialized. Added internals for the
10016 :verify-hostname-error, :verify-error, and :verify-flags
10017 parameters of `gnutls-boot' and documented those parameters in the
10018 docstring. Start callback support.
10019 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10020 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10021 on error. Return error code.
10022 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10023 (emacs_gnutls_read): Likewise.
10024 (Fgnutls_boot): Return handshake error code.
10025 (emacs_gnutls_handle_error): New function.
10026 (wsaerror_to_errno): Likewise.
10027
10028 * w32.h (emacs_gnutls_pull): Add prototype.
10029 (emacs_gnutls_push): Likewise.
10030
10031 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10032 (emacs_gnutls_push): Likewise.
10033
10034 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10035
10036 * process.c (wait_reading_process_output): Check if GnuTLS
10037 buffered some data internally if no FDs are set for TLS
10038 connections.
10039
10040 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10041 (LIBS): Link to USER_LIBS.
10042 ($(BLD)/gnutls.$(0)): New target.
10043
10044 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10045
10046 * xdisp.c (handle_single_display_spec): Rename the
10047 display_replaced_before_p argument into display_replaced_p, to
10048 make it consistent with the commentary. Fix typos in the
10049 commentary.
10050
10051 * textprop.c (syms_of_textprop): Remove dead code.
10052 (copy_text_properties): Delete obsolete commentary about an
10053 interface that was deleted long ago. Fix typos in the description
10054 of arguments.
10055
10056 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10057 to changes in oldXMenu/XMenu.h from 2011-04-16.
10058 <menu_help_message, prev_menu_help_message>: Constify.
10059 (IT_menu_make_room): menu->help_text is now `const char **';
10060 adjust.
10061
10062 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10063 to changes in oldXMenu/XMenu.h from 2011-04-16.
10064 (struct XMenu): Declare `help_text' `const char **'.
10065
10066 * xfaces.c <Qunspecified>: Make extern again.
10067
10068 * syntax.c: Include sys/types.h before including regex.h, as
10069 required by POSIX.
10070
10071 * doc.c (get_doc_string): Improve the format passed to `error'.
10072
10073 * doprnt.c (doprnt): Improve commentary.
10074
10075 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10076
10077 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10078 them with etags.
10079
10080 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10081 changes in globals.h immediately force recompilation.
10082 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10083 $(CURDIR)/s/ms-w32.h.
10084 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10085
10086 * character.c (Fchar_direction): Function deleted.
10087 (syms_of_character): Don't defsubr it.
10088 <char-direction-table>: Deleted.
10089
10090 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10091
10092 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10093 * doprnt.c: Include limits.h.
10094 (SIZE_MAX): New macro.
10095 (doprnt): Return a size_t value. 2nd arg is now size_t.
10096 Many local variables are now size_t instead of int or unsigned.
10097 Improve overflow protection. Support `l' modifier for integer
10098 conversions. Support %l conversion. Don't assume an EMACS_INT
10099 argument for integer conversions and for %c.
10100
10101 * lisp.h (doprnt): Restore prototype.
10102
10103 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10104 $(SRC)/character.h.
10105
10106 * Makefile.in (base_obj): Add back doprnt.o.
10107
10108 * deps.mk (doprnt.o): Add back prerequisites.
10109 (callint.o): Depend on character.h.
10110
10111 * eval.c (internal_lisp_condition_case): Include the handler
10112 representation in the error message.
10113 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10114 when breaking from the loop.
10115
10116 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10117
10118 * callint.c (Fcall_interactively): When displaying error message
10119 about invalid control letter, pass the character's codepoint, not
10120 a pointer to its multibyte form. Improve display of the character
10121 in octal and display also its hex code.
10122
10123 * character.c (char_string): Use %x to display the (unsigned)
10124 codepoint of an invalid character, to avoid displaying a bogus
10125 negative value.
10126
10127 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10128 `error', not SYMBOL_NAME itself.
10129
10130 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10131 character arguments to `error'.
10132
10133 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10134 to `error' in error message about FINAL_CHAR argument. Make sure
10135 FINAL_CHAR is a character, and use %c when it is passed as
10136 argument to `error'.
10137
10138 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10139
10140 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10141
10142 * w32.c: Include <time.h>.
10143 (sys_localtime): New function.
10144
10145 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10146
10147 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10148
10149 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10150
10151 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10152
10153 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10154 zombies (Bug#8467).
10155
10156 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10157
10158 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10159 gl_state.e_property when gl_state.object is Qt.
10160
10161 * insdel.c (make_gap_larger): Remove limitation of buffer size
10162 to <= INT_MAX.
10163
10164 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10165
10166 * xdisp.c (lookup_glyphless_char_display)
10167 (produce_glyphless_glyph): Handle cons cell entry in
10168 glyphless-char-display.
10169 (Vglyphless_char_display): Document it.
10170
10171 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10172 glyphless-char-display.
10173
10174 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10175
10176 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10177
10178 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10179
10180 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10181 definition for no-X builds.
10182
10183 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10184
10185 Static checks with GCC 4.6.0 and non-default toolkits.
10186
10187 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10188
10189 * process.c (keyboard_bit_set): Define only if SIGIO.
10190 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10191 (send_process): Repair possible setjmp clobbering.
10192
10193 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10194
10195 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10196
10197 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10198
10199 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10200 Define only if needed.
10201
10202 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10203 by pacifying GCC about it. Maybe it's time to retire it?
10204 * xfaces.c (USG, __TIMEVAL__): Likewise.
10205
10206 * dispextern.h (struct redisplay_interface): Rename param
10207 to avoid shadowing.
10208 * termhooks.h (struct terminal): Likewise.
10209 * xterm.c (xembed_send_message): Likewise.
10210
10211 * insdel.c (make_gap_smaller): Define only if
10212 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10213
10214 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10215 it.
10216
10217 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10218 so that we aren't warned about unused symbols.
10219
10220 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10221
10222 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10223
10224 * xfns.c (x_real_positions): Mark locals as initialized.
10225
10226 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10227
10228 * xterm.c: Fix problems found by static analysis with other toolkits.
10229 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10230 (x_dispatch_event): Declare static if USE_GTK, and
10231 define if USE_GTK || USE_X_TOOLKIT.
10232 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10233 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10234 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10235 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10236
10237 * xmenu.c (menu_help_callback): Pointer type fixes.
10238 Use const pointers when pointing at readonly data. Avoid pointer
10239 signedness clashes.
10240 (FALSE): Remove unused macro.
10241 (update_frame_menubar): Remove unused decl.
10242
10243 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10244
10245 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10246 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10247 (single_menu_item): Rename local to avoid shadowing.
10248
10249 * keyboard.c (make_lispy_event): Remove unused local var.
10250
10251 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10252 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10253
10254 * bitmaps: Change bitmaps from unsigned char back to the X11
10255 compatible char. Avoid the old compiler warnings about
10256 out-of-range initializers by using, for example, '\xab' rather
10257 than 0xab.
10258
10259 * xgselect.c (xgselect_initialize): Check vs interface
10260 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10261
10262 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10263
10264 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10265 to read-only memory.
10266
10267 * fns.c (vector): Remove; this old hack is no longer needed.
10268
10269 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10270 Remove unused var.
10271 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10272
10273 * xrdb.c (x_load_resources): Omit unused local.
10274
10275 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10276 (x_window): Rename locals to avoid shadowing.
10277 (USG): Use the kludged USG macro, to pacify gcc.
10278
10279 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10280 (x_term_init): Remove local to avoid shadowing.
10281
10282 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10283
10284 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10285 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10286
10287 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10288
10289 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10290
10291 Fix regex.c, syntax.c and friends for buffers > 2GB.
10292 * syntax.h (struct gl_state_s): Declare character position members
10293 EMACS_INT.
10294
10295 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10296
10297 * textprop.c (verify_interval_modification, interval_of):
10298 Declare arguments EMACS_INT.
10299
10300 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10301 EMACS_INT.
10302
10303 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10304
10305 * indent.c (Fvertical_motion): Local variable it_start is now
10306 EMACS_INT.
10307
10308 * regex.c (re_match, re_match_2, re_match_2_internal)
10309 (bcmp_translate, regcomp, regexec, print_double_string)
10310 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10311 (re_compile_pattern, re_exec): Declare arguments and local
10312 variables `size_t' and `ssize_t' and return values `regoff_t', as
10313 appropriate.
10314 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10315 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10316 <compile_stack_type>: `size' and `avail' are now `size_t'.
10317
10318 * regex.h <regoff_t>: Use ssize_t, not int.
10319 (re_search, re_search_2, re_match, re_match_2): Arguments that
10320 specify buffer/string position and length are now ssize_t and
10321 size_t. Return type is regoff_t.
10322
10323 2011-04-16 Ben Key <bkey76@gmail.com>
10324
10325 * nsfont.m: Fixed bugs in ns_get_family and
10326 ns_descriptor_to_entity that were caused by using free to
10327 deallocate memory blocks that were allocated by xmalloc (via
10328 xstrdup). This caused Emacs to crash when compiled with
10329 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10330 --enable-checking=xmallocoverrun). xfree is now used to
10331 deallocate these memory blocks.
10332
10333 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10334
10335 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10336
10337 emacs_write: Accept and return EMACS_INT for sizes.
10338 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10339 et seq.
10340 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10341 Accept and return EMACS_INT.
10342 (emacs_gnutls_write): Return the number of bytes written on
10343 partial writes.
10344 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10345 (emacs_read, emacs_write): Remove check for negative size, as the
10346 Emacs source code has been audited now.
10347 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10348 (emacs_read, emacs_write): Use it.
10349 * process.c (send_process): Adjust to the new signatures of
10350 emacs_write and emacs_gnutls_write. Do not attempt to store
10351 a byte offset into an 'int'; it might overflow.
10352 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10353
10354 * sound.c: Don't assume sizes fit in 'int'.
10355 (struct sound_device.period_size, alsa_period_size):
10356 Return EMACS_INT, not int.
10357 (struct sound_device.write, vox_write, alsa_write):
10358 Accept EMACS_INT, not int.
10359 (wav_play, au_play): Use EMACS_INT to store sizes and to
10360 record read return values.
10361
10362 2011-04-15 Ben Key <bkey76@gmail.com>
10363
10364 * keyboard.c (Qundefined): Don't declare static since it is used
10365 in nsfns.m.
10366 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10367 static since they are used in nsfont.m.
10368
10369 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10370
10371 * process.c (Qprocessp): Don't declare static.
10372 * lisp.h (Qprocessp): Declare again.
10373
10374 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10375
10376 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10377
10378 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10379
10380 Improve C-level modularity by making more things 'static'.
10381
10382 Don't publish debugger-only interfaces to other modules.
10383 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10384 (verify_bytepos, count_markers): Move decls to the only modules
10385 that need them.
10386 * region-cache.h (pp_cache): Likewise.
10387 * window.h (check_all_windows): Likewise.
10388 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10389
10390 * sysdep.c (croak): Now static, if
10391 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10392 * syssignal.h (croak): Declare only if not static.
10393
10394 * alloc.c (refill_memory_reserve): Now static if
10395 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10396 * lisp.h (refill_memory_reserve): Declare only if not static.
10397
10398 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10399 Define only if USE_LUCID.
10400
10401 * xrdb.c (x_customization_string, x_rm_string): Now static.
10402
10403 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10404 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10405
10406 * xdisp.c (draw_row_with_mouse_face): Now static.
10407 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10408
10409 * window.h (check_all_windows): Mark externally visible.
10410
10411 * window.c (window_deletion_count): Now static.
10412
10413 * undo.c: Make symbols static if they're not exported.
10414 (last_undo_buffer, last_boundary_position, pending_boundary):
10415 Now static.
10416
10417 * textprop.c (interval_insert_behind_hooks): Now static.
10418 (interval_insert_in_front_hooks): Likewise.
10419
10420 * term.c: Make symbols static if they're not exported.
10421 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10422 (max_frame_lines, tty_set_terminal_modes):
10423 (tty_reset_terminal_modes, tty_turn_off_highlight):
10424 (get_tty_terminal): Now static.
10425 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10426 * termhooks.h (term_mouse_moveto): Do not declare if
10427 HAVE_WINDOW_SYSTEM.
10428 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10429 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10430
10431 * sysdep.c: Make symbols static if they're not exported.
10432 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10433 Now static.
10434 (sigprocmask_set, full_mask): Remove; unused.
10435 (wait_debugging): Mark as visible.
10436 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10437 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10438
10439 * syntax.c (syntax_temp): Define only if !__GNUC__.
10440
10441 * sound.c (current_sound_device, current_sound): Now static.
10442
10443 * search.c (searchbufs, searchbuf_head): Now static.
10444
10445 * scroll.c (scroll_cost): Remove; unused.
10446 * dispextern.h (scroll_cost): Remove decl.
10447
10448 * region-cache.h (pp_cache): Mark as externally visible.
10449
10450 * process.c: Make symbols static if they're not exported.
10451 (process_tick, update_tick, create_process, chan_process):
10452 (Vprocess_alist, proc_buffered_char, datagram_access):
10453 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10454 (deactivate_process): Mark defn as static, as well as decl.
10455 * lisp.h (create_process): Remove decl.
10456 * process.h (chan_process, Vprocess_alist): Remove decls.
10457
10458 * print.c: Make symbols static if they're not exported.
10459 (print_depth, new_backquote_output, being_printed, print_buffer):
10460 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10461 (print_interval, print_number_index, initial_stderr_stream):
10462 Now static.
10463 * lisp.h (Fprinc): Remove decl.
10464 (debug_output_compilation_hack): Mark as externally visible.
10465
10466 * sysdep.c (croak): Move decl from here to syssignal.h.
10467 * syssignal.h (croak): Put it here, so the API can be checked when
10468 'croak' is called from dissociate_if_controlling_tty.
10469
10470 * minibuf.c: Make symbols static if they're not exported.
10471 (minibuf_save_list, choose_minibuf_frame): Now static.
10472 * lisp.h (choose_minibuf_frame): Remove decl.
10473
10474 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10475
10476 * lread.c: Make symbols static if they're not exported.
10477 (read_objects, initial_obarray, oblookup_last_bucket_number):
10478 Now static.
10479 (make_symbol): Remove; unused.
10480 * lisp.h (initial_obarray, make_symbol): Remove decls.
10481
10482 * keyboard.c: Make symbols static if they're not exported.
10483 (single_kboard, recent_keys_index, total_keys, recent_keys):
10484 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10485 (this_single_command_key_start, echoing, last_auto_save):
10486 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10487 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10488 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10489 (Vlispy_mouse_stem, double_click_count):
10490 Now static.
10491 (force_auto_save_soon): Define only if SIGDANGER.
10492 (ignore_mouse_drag_p): Now static if
10493 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10494 (print_help): Remove; unused.
10495 (stop_character, last_timer_event): Mark as externally visible.
10496 * keyboard.h (ignore_mouse_drag_p): Declare only if
10497 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10498 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10499 * lisp.h (echoing): Remove decl.
10500 (force_auto_save_soon): Declare only if SIGDANGER.
10501 * xdisp.c (redisplay_window): Simplify code, to make it more
10502 obvious that ignore_mouse_drag_p is not accessed if !defined
10503 USE_GTK && !defined HAVE_NS.
10504
10505 * intervals.c: Make symbols static if they're not exported.
10506 (merge_properties_sticky, merge_interval_right, delete_interval):
10507 Now static.
10508 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10509
10510 * insdel.c: Make symbols static if they're not exported.
10511 However, leave prepare_to_modify_buffer alone. It's never
10512 called from outside this function, but that appears to be a bug.
10513 (combine_after_change_list, combine_after_change_buffer):
10514 (adjust_after_replace, signal_before_change): Now static.
10515 (adjust_after_replace_noundo): Remove; unused.
10516 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10517 (signal_before_change): Remove decls.
10518
10519 * indent.c (val_compute_motion, val_vmotion): Now static.
10520
10521 * image.c: Make symbols static if they're not exported.
10522 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10523 if USE_GTK.
10524 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10525 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10526
10527 * fringe.c (standard_bitmaps): Now static.
10528 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10529
10530 * frame.c: Make symbols static if they're not exported.
10531 (x_report_frame_params, make_terminal_frame): Now static.
10532 (get_frame_param): Now static, unless HAVE_NS.
10533 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10534 (x_get_resource_string): Remove; not used.
10535 * frame.h (make_terminal_frame, x_report_frame_params):
10536 (x_get_resource_string); Remove decls.
10537 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10538 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10539
10540 * font.c, fontset.c: Make symbols static if they're not exported.
10541 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10542 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10543 * font.c (font_close_object): Now static.
10544 * font.h (font_close_object): Remove.
10545 * fontset.c (FONTSET_OBJLIST): Remove.
10546 (free_realized_fontset) #if-0 the body, which does nothing.
10547 (face_suitable_for_char_p): #if-0, as it's never called.
10548 * fontset.h (face_suitable_for_char_p): Remove decl.
10549 * xfaces.c (face_at_string_position):
10550 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10551 since 0 is always ASCII.
10552
10553 * fns.c (weak_hash_tables): Now static.
10554
10555 * fileio.c: Make symbols static if they're not exported.
10556 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10557 (Vwrite_region_annotation_buffers): Now static.
10558
10559 * eval.c: Make symbols static if they're not exported.
10560 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10561 * lisp.h (backtrace_list): Remove decl.
10562
10563 * emacs.c: Make symbols static if they're not exported.
10564 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10565 (fatal_error_code, fatal_error_signal_hook, standard_args):
10566 Now static.
10567 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10568 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10569 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10570 * lisp.h (fatal_error_signal_hook): Remove decl.
10571 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10572
10573 * editfns.c: Move a (normally-unused) function to its only use.
10574 * editfns.c, lisp.h (get_operating_system_release): Remove.
10575 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10576 worth the hassle of breaking this out.
10577
10578 * xterm.c: Make symbols static if they're not exported.
10579 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10580 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10581 (x_destroy_window, x_delete_display):
10582 Now static.
10583 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10584 (x_mouse_leave): Remove; unused.
10585 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10586 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10587 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10588 Remove decls.
10589 (x_mouse_leave): Declare only if WINDOWSNT.
10590 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10591 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10592 USE_X_TOOLKIT.
10593
10594 * ftxfont.c: Make symbols static if they're not exported.
10595 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10596 HAVE_FREETYPE.
10597 * font.h (ftxfont_driver): Likewise.
10598
10599 * xfns.c: Make symbols static if they're not exported.
10600 (x_last_font_name, x_display_info_for_name):
10601 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10602 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10603 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10604 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10605 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10606 (last_show_tip_args): Now static.
10607 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10608 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10609 (x_screen_planes): Remove; unused.
10610 * dispextern.h (x_screen_planes): Remove decl.
10611
10612 * dispnew.c: Make symbols static if they're not exported.
10613 * dispextern.h (redraw_garbaged_frames, scrolling):
10614 (increment_row_positions): Remove.
10615 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10616 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10617 Now static.
10618 (redraw_garbaged_frames): Remove; unused.
10619
10620 * xfaces.c: Make symbols static if they're not exported.
10621 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10622 Remove decls.
10623 * xterm.h (defined_color): Remove decls.
10624 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10625 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10626 (menu_face_changed_default, defined_color, free_realized_face):
10627 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10628 (ascii_face_of_lisp_face): Remove; unused.
10629
10630 * xdisp.c: Make symbols static if they're not exported.
10631 * dispextern.h (scratch_glyph_row, window_box_edges):
10632 (glyph_to_pixel_coords, set_cursor_from_row):
10633 (get_next_display_element, set_iterator_to_next):
10634 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10635 (show_mouse_face): Remove decls
10636 * frame.h (message_buf_print): Likewise.
10637 * lisp.h (pop_message, set_message, check_point_in_composition):
10638 Likewise.
10639 * xterm.h (set_vertical_scroll_bar): Likewise.
10640 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10641 (message_buf_print, scratch_glyph_row, displayed_buffer):
10642 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10643 (get_next_display_element, show_mouse_face, window_box_edges):
10644 (frame_to_window_pixel_xy, check_point_in_composition):
10645 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10646 (glyph_to_pixel_coords): Remove; unused.
10647
10648 * dired.c (file_name_completion): Now static.
10649
10650 * dbusbind.c (xd_in_read_queued_messages): Now static.
10651
10652 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10653 * data.c (circular_list_error): Remove.
10654
10655 * commands.h (last_point_position, last_point_position_buffer):
10656 (last_point_position_window): Remove decls.
10657 * keyboard.c: Make these variables static.
10658
10659 * coding.h (coding, code_convert_region, encode_coding_gap):
10660 Remove decls.
10661 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10662 (iso_code_class, detect_coding, code_convert_region): Now static.
10663 (encode_coding_gap): Remove; unused.
10664
10665 * chartab.c (chartab_chars, chartab_bits): Now static.
10666
10667 * charset.h (charset_iso_8859_1): Remove decl.
10668 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10669 Now static.
10670
10671 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10672 * ccl.c (Vccl_program_table): Now static.
10673 (check_ccl_update): Remove; unused.
10674
10675 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10676 * category.h: ... from here.
10677 * category.c (check_category_table, set_category_set): Now static.
10678
10679 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10680 * lisp.h: Remove these decls.
10681
10682 * buffer.c (buffer_count): Remove unused var.
10683
10684 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10685 so that it's not optimized away.
10686 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10687 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10688 exported only to the debugger.
10689
10690 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10691 * atimer.h (run_all_atimers): Remove; not exported.
10692
10693 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10694 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10695 was inaccessible from Lisp.
10696 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10697 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10698
10699 alloc.c: Import and export fewer symbols, and remove unused items.
10700 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10701 is defined.
10702 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10703 it's not optimized away by whole-program optimization.
10704 (message_enable_multibyte, free_misc): Remove.
10705 (catchlist, handlerlist, mark_backtrace):
10706 Declare only if BYTE_MARK_STACK.
10707 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10708 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10709 (message_enable_multibyte): Remove decl.
10710 (free_misc, interval_free_list, float_block, float_block_index):
10711 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10712 (cons_free_list, last_marked_index):
10713 Now static.
10714 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10715 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10716 (mark_backtrace): Define only if BYTE_MARK_STACK.
10717 * xdisp.c (message_enable_multibyte): Now static.
10718
10719 Declare Lisp_Object Q* variables to be 'static' if not exported.
10720 This makes it easier for human readers (and static analyzers)
10721 to see whether these variables are used from other modules.
10722 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10723 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10724 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10725 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10726 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10727 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10728 * xmenu.c, xselect.c:
10729 Declare Q* vars static if they are not used in other modules.
10730 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10731 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10732 Remove decls of unexported vars.
10733 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10734
10735 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10736
10737 Make Emacs functions such as Fatom 'static' by default.
10738 This makes it easier for human readers (and static analyzers)
10739 to see whether these functions can be called from other modules.
10740 DEFUN now defines a static function. To make the function external
10741 so that it can be used in other C modules, use the new macro DEFUE.
10742 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10743 (Finit_image_library):
10744 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10745 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10746 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10747 Remove decls, since these functions are now static.
10748 (Funintern, Fget_internal_run_time): New decls, since these functions
10749 were already external.
10750
10751 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10752 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10753 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10754 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10755 * keyboard.c, keymap.c, lread.c:
10756 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10757 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10758 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10759 Mark functions with DEFUE instead of DEFUN,
10760 if they are used in other modules.
10761 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10762 decls for now-static functions.
10763 * buffer.h (Fdelete_overlay): Remove decl.
10764 * callproc.c (Fgetenv_internal): Mark as internal.
10765 * composite.c (Fremove_list_of_text_properties): Remove decl.
10766 (Fcomposition_get_gstring): New forward static decl.
10767 * composite.h (Fcomposite_get_gstring): Remove decl.
10768 * dired.c (Ffile_attributes): New forward static decl.
10769 * doc.c (Fdocumntation_property): New forward static decl.
10770 * eval.c (Ffetch_bytecode): New forward static decl.
10771 (Funintern): Remove extern decl; now in .h file where it belongs.
10772 * fileio.c (Fmake_symbolic_link): New forward static decl.
10773 * image.c (Finit_image_library): New forward static decl.
10774 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10775 * intervals.h (Fprevious_property_change):
10776 (Fremove_list_of_text_properties): Remove decls.
10777 * keyboard.c (Fthis_command_keys): Remove decl.
10778 (Fcommand_execute): New forward static decl.
10779 * keymap.c (Flookup_key): New forward static decl.
10780 (Fcopy_keymap): Now static.
10781 * keymap.h (Flookup_key): Remove decl.
10782 * process.c (Fget_process): New forward static decl.
10783 (Fprocess_datagram_address): Mark as internal.
10784 * syntax.c (Fsyntax_table_p): New forward static decl.
10785 (skip_chars): Remove duplicate decl.
10786 * textprop.c (Fprevious_property_change): New forward static decl.
10787 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10788 Now internal.
10789 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10790 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10791
10792 * editfns.c (Fformat): Remove unreachable code.
10793
10794 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10795
10796 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10797 change. (Bug#8496)
10798
10799 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10800
10801 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10802 when at ZV. (Bug#8487)
10803
10804 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10805
10806 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10807 (Bug#8437)
10808 * keyboard.c (parse_tool_bar_item): Likewise.
10809 * sound.c (sound_cleanup, alsa_close): Likewise.
10810 * termcap.c (tgetent): Likewise.
10811 * xfns.c (x_default_font_parameter): Likewise.
10812 * xsettings.c (read_and_apply_settings): Likewise.
10813
10814 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10815 (overrun_check_free): Protoize.
10816
10817 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10818
10819 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10820 since callers should never pass a negative size.
10821 Change the signature to match that of plain 'read' and 'write'; see
10822 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10823 * lisp.h: Update prototypes of emacs_write and emacs_read.
10824
10825 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10826
10827 * xdisp.c (redisplay_window): Don't try to determine the character
10828 position of the scroll margin if the window start point w->startp
10829 is outside the buffer's accessible region. (Bug#8468)
10830
10831 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10832
10833 Fix write-region and its subroutines for buffers > 2GB.
10834 * fileio.c (a_write, e_write): Modify declaration of arguments and
10835 local variables to support buffers larger than 2GB.
10836 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10837
10838 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10839 argument, local variables, and return value.
10840
10841 * lisp.h: Update prototypes of emacs_write and emacs_read.
10842
10843 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10844
10845 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10846
10847 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10848
10849 Fix more problems found by GCC 4.6.0's static checks.
10850
10851 * xdisp.c (vmessage): Use a better test for character truncation.
10852
10853 * charset.c (load_charset_map): <, not <=, for optimization,
10854 and to avoid potential problems with integer overflow.
10855 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10856 * casetab.c (set_identity, shuffle): Likewise.
10857 * editfns.c (Fformat): Likewise.
10858 * syntax.c (skip_chars): Likewise.
10859
10860 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10861 This also lets GCC 4.6.0 generate slightly better loop code.
10862
10863 * callint.c (Fcall_interactively): <, not <=, for optimization.
10864 (Fcall_interactively): Count the number of arguments produced,
10865 not the number of arguments given. This is simpler and lets GCC
10866 4.6.0 generate slightly better code.
10867
10868 * ftfont.c: Distingish more carefully between FcChar8 and char.
10869 The previous code passed unsigned char * to a functions like
10870 strlen and xstrcasecmp that expect char *, which does not
10871 conform to the C standard.
10872 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10873 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10874 char * when the C standard requires it.
10875
10876 * keyboard.c (read_char): Remove unused var.
10877
10878 * eval.c: Port to Windows vsnprintf (Bug#8435).
10879 Include <limits.h>.
10880 (SIZE_MAX): Define if the headers do not.
10881 (verror): Do not give up if vsnprintf returns a negative count.
10882 Instead, grow the buffer. This ports to Windows vsnprintf, which
10883 does not conform to C99. Problem reported by Eli Zaretskii.
10884 Also, simplify the allocation scheme, by avoiding the need for
10885 calling realloc, and removing the ALLOCATED variable.
10886
10887 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10888
10889 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10890 But keep the doprint source code for now, as we might revamp it
10891 and use it again (Bug#8435).
10892 * lisp.h (doprnt): Remove.
10893 * Makefile.in (base_obj): Remove doprnt.o.
10894 * deps.mk (doprnt.o): Remove.
10895
10896 error: Print 32- and 64-bit integers portably (Bug#8435).
10897 Without this change, on typical 64-bit hosts error ("...%d...", N)
10898 was used to print both 32- and 64-bit integers N, which relied on
10899 undefined behavior.
10900 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10901 * lisp.h (error, verror): Mark as printf-like functions.
10902 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10903 Report overflow in size calculations when allocating printf buffer.
10904 Do not truncate output string at its first null byte.
10905 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10906 Truncate the output at a character boundary, since vsnprintf does not
10907 do that.
10908 * charset.c (check_iso_charset_parameter): Convert internal
10909 character to string before calling 'error', since %c now has the
10910 printf meaning.
10911 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10912 overflow when computing char to be passed to 'error'. Do not
10913 pass Lisp_Object to 'error'; pass the integer instead.
10914 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10915 formatted with plain %d.
10916
10917 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10918
10919 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10920
10921 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10922
10923 * xterm.c (x_catch_errors): Remove duplicate declaration.
10924
10925 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10926
10927 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10928
10929 2011-04-10 Jim Meyering <meyering@redhat.com>
10930
10931 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10932 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10933 return ssize_t not "int", and use size_t as the buffer length.
10934 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10935 * gnutls.h: Update declarations.
10936 * process.c (read_process_output): Use ssize_t, to match.
10937 (send_process): Likewise.
10938
10939 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10940
10941 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10942
10943 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10944
10945 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10946 Use unsigned char, to match FcChar8 type definition.
10947
10948 * xterm.c (handle_one_xevent):
10949 * xmenu.c (create_and_show_popup_menu):
10950 * xselect.c (x_decline_selection_request)
10951 (x_reply_selection_request): Avoid type-punned deref of X events.
10952
10953 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10954
10955 Fix some uses of `int' instead of EMACS_INT.
10956 * search.c (string_match_1, fast_string_match)
10957 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10958 (scan_buffer, find_next_newline_no_quit)
10959 (find_before_next_newline, search_command, Freplace_match)
10960 (Fmatch_data): Make some `int' variables be EMACS_INT.
10961
10962 * xdisp.c (display_count_lines): 3rd argument and return value now
10963 EMACS_INT. All callers changed.
10964 (pint2hrstr): Last argument is now EMACS_INT.
10965
10966 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10967 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10968 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10969 (decode_coding_utf_16, decode_coding_emacs_mule)
10970 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10971 (decode_coding_ccl, decode_coding_charset)
10972 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10973 (decode_coding_iso_2022, decode_coding_emacs_mule)
10974 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10975 <char_offset, last_offset>: Declare EMACS_INT.
10976 (encode_coding_utf_8, encode_coding_utf_16)
10977 (encode_coding_emacs_mule, encode_invocation_designation)
10978 (encode_designation_at_bol, encode_coding_iso_2022)
10979 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10980 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10981 Declare EMACS_INT.
10982 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10983 (encode_invocation_designation): Last argument P_NCHARS is now
10984 EMACS_INT.
10985 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10986 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10987
10988 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10989 All users changed.
10990
10991 * ccl.c (Fccl_execute_on_string): Declare some variables
10992 EMACS_INT.
10993
10994 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10995
10996 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10997
10998 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10999
11000 * process.c (Fformat_network_address): Doc fix.
11001
11002 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11003
11004 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11005
11006 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11007
11008 * keyboard.c (read_char): Call Lisp function help-form-show,
11009 instead of using internal_with_output_to_temp_buffer.
11010 (Qhelp_form_show): New var.
11011 (syms_of_keyboard): Use DEFSYM macro.
11012
11013 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11014
11015 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11016
11017 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11018
11019 * process.c (Flist_processes): Remove to Lisp.
11020 (list_processes_1): Delete.
11021
11022 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11023
11024 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11025
11026 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11027
11028 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11029
11030 Fix more problems found by GCC 4.6.0's static checks.
11031
11032 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11033
11034 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11035
11036 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11037
11038 * xdisp.c (vmessage): Mark as a printf-like function.
11039
11040 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11041
11042 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11043
11044 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11045 printf-like functions.
11046 (tiff_load): Add casts to remove these marks before passing them
11047 to system-supplied API.
11048
11049 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11050
11051 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11052 This avoids several warnings with gcc -Wstrict-overflow.
11053 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11054 directly, rather than having caller test rule sign. This avoids
11055 some unnecessary tests.
11056 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11057 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11058 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11059
11060 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11061 (xfont_open): Avoid unnecessary tests.
11062
11063 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11064
11065 * composite.h, composite.c (composition_gstring_put_cache):
11066 Use EMACS_INT, not int, for length.
11067
11068 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11069 breaking out part of COMPOSITION_DECODE_RULE.
11070 (COMPOSITION_DECODE_RULE): Use it.
11071 * composite.c (get_composition_id): Remove unused local vars,
11072 by using the new macro.
11073
11074 * textprop.c (set_text_properties_1): Change while to do-while,
11075 since the condition is always true at first.
11076
11077 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11078 (interval_deletion_adjustment): Return unsigned value.
11079 All uses changed.
11080
11081 * process.c (list_processes_1, create_pty, read_process_output):
11082 (exec_sentinel): Remove vars that were set but not used.
11083 (create_pty): Remove unnecessary "volatile"s.
11084 (Fnetwork_interface_info): Avoid possibility of int overflow.
11085 (read_process_output): Do adaptive read buffering even if carryover.
11086 (read_process_output): Simplify nbytes computation if buffered.
11087
11088 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11089
11090 * syntax.c (scan_words): Remove var that was set but not used.
11091 (update_syntax_table): Use unsigned instead of int.
11092
11093 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11094 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11095 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11096
11097 * print.c (print_error_message): Avoid int overflow.
11098
11099 * font.c (font_list_entities): Redo for clarity,
11100 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11101
11102 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11103 (font_score): Avoid potential overflow in diff calculation.
11104
11105 * fns.c (substring_both): Remove var that is set but not used.
11106 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11107
11108 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11109
11110 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11111 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11112 can always succeed if overflow has undefined behavior.
11113
11114 * search.c (boyer_moore, wordify): Remove vars set but not used.
11115 (wordify): Omit three unnecessary tests.
11116
11117 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11118 All callers changed. This avoids the need for an unused var.
11119
11120 * casefiddle.c (casify_region): Remove var that is set but not used.
11121
11122 * dired.c (file_name_completion): Remove var that is set but not used.
11123
11124 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11125
11126 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11127 (Finsert_file_contents): Remove unnecessary code checking fd.
11128
11129 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11130 Check for integer overflow on size calculations.
11131
11132 * buffer.c (Fprevious_overlay_change): Remove var that is set
11133 but not used.
11134
11135 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11136 Remove vars that are set but not used.
11137 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11138 (timer_check_2): Mark vars as initialized.
11139
11140 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11141
11142 * image.c (lookup_image): Remove var that is set but not used.
11143 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11144
11145 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11146 that are set but not used.
11147
11148 * xfns.c (make_invisible_cursor): Don't return garbage
11149 if XCreateBitmapFromData fails (Bug#8410).
11150
11151 * xselect.c (x_get_local_selection, x_handle_property_notify):
11152 Remove vars that are set but not used.
11153
11154 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11155 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11156
11157 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11158 Remove var that is set but not used.
11159 (scroll_bar_windows_size): Now size_t, not int.
11160 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11161 Check for overflow.
11162
11163 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11164 (map_tty_color) [!defined MSDOS]: Likewise.
11165
11166 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11167
11168 * coding.c: Remove vars that are set but not used.
11169 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11170 All callers changed.
11171 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11172 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11173 (decode_coding_charset): Remove vars that are set but not used.
11174
11175 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11176 that is set but not used.
11177
11178 * print.c (print_object): Remove var that is set but not used.
11179
11180 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11181 The gnulib version avoids calling malloc in the usual case,
11182 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11183 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11184 * filelock.c (current_lock_owner): Likewise.
11185 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11186 * sysdep.c: Include allocator.h, careadlinkat.h.
11187 (emacs_no_realloc_allocator): New static constant.
11188 (emacs_readlink): New function.
11189 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11190 ../lib/careadlinkat.h.
11191
11192 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11193
11194 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11195 first non-nil return value).
11196
11197 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11198
11199 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11200 if not defined (Bug#8403).
11201
11202 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11203
11204 * xdisp.c (display_count_lines): Remove parameter `start',
11205 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11206 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11207 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11208 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11209 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11210 and thereabouts. All callers changed.
11211 (get_per_char_metric): Remove parameter `f', unused since
11212 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11213
11214 2011-04-02 Jim Meyering <meyering@redhat.com>
11215
11216 do not dereference NULL upon failed strdup
11217 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11218 (ns_get_family): Likewise.
11219
11220 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11221
11222 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11223
11224 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11225
11226 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11227 later (Bug#8403).
11228
11229 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11230
11231 Add lexical binding.
11232
11233 * window.c (Ftemp_output_buffer_show): New fun.
11234 (Fsave_window_excursion):
11235 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11236
11237 * lread.c (lisp_file_lexically_bound_p): New function.
11238 (Fload): Bind Qlexical_binding.
11239 (readevalloop): Remove `evalfun' arg.
11240 Bind Qinternal_interpreter_environment.
11241 (Feval_buffer): Bind Qlexical_binding.
11242 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11243 Mark as dynamic.
11244 (syms_of_lread): Declare `lexical-binding'.
11245
11246 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11247
11248 * keyboard.c (eval_dyn): New fun.
11249 (menu_item_eval_property): Use it.
11250
11251 * image.c (parse_image_spec): Use Ffunctionp.
11252
11253 * fns.c (concat, mapcar1): Accept byte-code-functions.
11254
11255 * eval.c (Fsetq): Handle lexical vars.
11256 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11257 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11258 (FletX, Flet): Obey lexical binding.
11259 (Fcommandp): Handle closures.
11260 (Feval): New `lexical' arg.
11261 (eval_sub): New function extracted from Feval. Use it almost
11262 everywhere where Feval was used. Look up vars in lexical env.
11263 Handle closures.
11264 (Ffunctionp): Move from subr.el.
11265 (Ffuncall): Handle closures.
11266 (apply_lambda): Remove `eval_flags'.
11267 (funcall_lambda): Handle closures and new byte-code-functions.
11268 (Fspecial_variable_p): New function.
11269 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11270 but without exporting it to Lisp.
11271
11272 * doc.c (Fdocumentation, store_function_docstring):
11273 * data.c (Finteractive_form): Handle closures.
11274
11275 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11276 interactive spec.
11277
11278 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11279 New byte-codes.
11280 (exec_byte_code): New function extracted from Fbyte_code to handle new
11281 calling convention for byte-code-functions. Add new byte-codes.
11282
11283 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11284
11285 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11286
11287 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11288
11289 * xdisp.c (redisplay_internal): Fix prototype.
11290
11291 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11292
11293 * xdisp.c (SCROLL_LIMIT): New macro.
11294 (try_scrolling): Use it when setting scroll_limit.
11295 Limit scrolling to 100 screen lines.
11296 (redisplay_window): Even when falling back on "recentering",
11297 position point in the window according to scroll-conservatively,
11298 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11299
11300 (try_scrolling): When point is above the window, allow searching
11301 as far as scroll_max, or one screenful, to compute vertical
11302 distance from PT to the scroll margin position. This prevents
11303 try_scrolling from unnecessarily failing when
11304 scroll-conservatively is set to a value slightly larger than the
11305 window height. Clean up the case of PT below the margin at bottom
11306 of window: scroll_max can no longer be INT_MAX. When aggressive
11307 scrolling is in use, don't let point enter the opposite scroll
11308 margin as result of the scroll.
11309 (syms_of_xdisp) <scroll-conservatively>: Document the
11310 threshold of 100 lines for never-recentering scrolling.
11311
11312 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11313
11314 * dispextern.h (move_it_by_lines):
11315 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11316 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11317 (message_log_check_duplicate): Remove parameters `prev_bol' and
11318 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11319 (redisplay_internal): Remove parameter `preserve_echo_area',
11320 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11321
11322 * indent.c (Fvertical_motion):
11323 * window.c (window_scroll_pixel_based, Frecenter):
11324 Don't pass `need_y_p' to `move_it_by_lines'.
11325
11326 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11327
11328 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11329 steal a few bits to be more compact.
11330 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11331 Remove unneeded casts.
11332
11333 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11334
11335 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11336
11337 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11338 binding" message (bug#7967).
11339
11340 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11341
11342 Fix more problems found by GCC 4.6.0's static checks.
11343
11344 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11345 Remove unused local var.
11346
11347 * editfns.c (Fmessage_box): Remove unused local var.
11348
11349 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11350 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11351 Omit unused local vars.
11352 * window.c (shrink_windows): Omit unused local var.
11353 * menu.c (digest_single_submenu): Omit unused local var.
11354 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11355 Omit unused local var.
11356
11357 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11358 Don't assume string length fits in int.
11359 (keyremap_step, read_key_sequence): Use size_t for sizes.
11360 (read_key_sequence): Don't check last_real_key_start redundantly.
11361
11362 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11363 instead of alloca (Bug#8344).
11364
11365 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11366 (Fbacktrace_frame): Don't assume nframes fits in int.
11367
11368 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11369
11370 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11371 concerns.
11372
11373 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11374
11375 * cm.c (calccost): Turn while-do into do-while, for clarity.
11376
11377 * keyboard.c (syms_of_keyboard): Use the same style as later
11378 in this function when indexing through an array. This also
11379 works around GCC bug 48267.
11380
11381 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11382
11383 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11384
11385 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11386 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11387
11388 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11389 This avoids undefined behavior on integer overflow, and is a bit
11390 more convenient anyway since it is compared to a size_t variable.
11391
11392 Variadic C functions now count arguments with size_t, not int.
11393 This avoids an unnecessary limitation on 64-bit machines, which
11394 caused (substring ...) to crash on large vectors (Bug#8344).
11395 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11396 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11397 All variadic functions and their callers changed accordingly.
11398 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11399 * data.c (arith_driver, float_arith_driver): Likewise.
11400 * editfns.c (general_insert_function): Likewise.
11401 * eval.c (struct backtrace.nargs, interactive_p)
11402 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11403 (funcall_lambda, mark_backtrace): Likewise.
11404 * fns.c (concat): Likewise.
11405 * frame.c (x_set_frame_parameters): Likewise.
11406 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11407 0 if not found, not -1. All callers changed.
11408
11409 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11410 (stack_copy_size): Now size_t, not int.
11411 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11412
11413 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11414
11415 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11416 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11417 All callers changed.
11418
11419 * lisp.h (multibyte_char_to_unibyte):
11420 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11421 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11422 * character.h (CHAR_TO_BYTE8):
11423 * cmds.c (internal_self_insert):
11424 * editfns.c (general_insert_function):
11425 * keymap.c (push_key_description):
11426 * search.c (Freplace_match):
11427 * xdisp.c (message_dolog, set_message_1): All callers changed.
11428
11429 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11430
11431 * keyboard.c (safe_run_hook_funcall): New function.
11432 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11433 don't set the hook to nil, but remove the offending function instead.
11434 (Qcommand_hook_internal): Remove, unused.
11435 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11436 Vcommand_hook_internal.
11437
11438 * eval.c (enum run_hooks_condition): Remove.
11439 (funcall_nil, funcall_not): New functions.
11440 (run_hook_with_args): Call each function through a `funcall' argument.
11441 Remove `cond' argument, now redundant.
11442 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11443 (Frun_hook_with_args_until_failure): Adjust accordingly.
11444 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11445
11446 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11447
11448 * dispextern.h (string_buffer_position): Remove declaration.
11449
11450 * print.c (strout): Remove parameter `multibyte', unused since
11451 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11452
11453 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11454 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11455 All callers changed.
11456
11457 * w32.c (_wsa_errlist): Use braces for struct initializers.
11458
11459 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11460 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11461 All callers changed.
11462 (string_buffer_position): Likewise. Also, make static (it's never
11463 used outside xdisp.c).
11464 (cursor_row_p): Remove parameter `w', unused since
11465 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11466 (decode_mode_spec): Remove parameter `precision', introduced during
11467 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11468 All callers changed.
11469
11470 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11471
11472 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11473
11474 2011-03-27 Anders Lindgren <andlind@gmail.com>
11475
11476 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11477 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11478 (ns_update_auto_hide_menu_bar): New functions.
11479 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11480 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11481 ns_constrain_all_frames.
11482 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11483 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11484
11485 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11486
11487 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11488
11489 2011-03-27 Glenn Morris <rgm@gnu.org>
11490
11491 * syssignal.h: Replace RETSIGTYPE with void.
11492 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11493 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11494 Replace SIGTYPE with void everywhere.
11495 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11496 * s/template.h (SIGTYPE): Remove commented out definition.
11497
11498 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11499
11500 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11501 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11502
11503 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11504
11505 * w32.c (read_unc_volume): Use parameter `henum', instead of
11506 global variable `wget_enum_handle'.
11507
11508 * keymap.c (describe_vector): Remove parameters `indices' and
11509 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11510 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11511
11512 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11513
11514 * keyboard.c (timer_check): Remove parameter `do_it_now',
11515 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11516 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11517 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11518
11519 * keyboard.c (read_char):
11520 * w32menu.c (w32_menu_display_help):
11521 * xmenu.c (show_help_event, menu_help_callback):
11522 Adjust calls to `show_help_echo'.
11523
11524 * gtkutil.c (xg_maybe_add_timer):
11525 * keyboard.c (readable_events):
11526 * process.c (wait_reading_process_output):
11527 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11528
11529 * insdel.c (adjust_markers_gap_motion):
11530 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11531 (gap_left, gap_right): Don't call it.
11532
11533 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11534
11535 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11536 incurred during fontification.
11537
11538 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11539
11540 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11541 (DEFVAR_PER_BUFFER): Don't pass it.
11542
11543 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11544 (scrolling_window): Don't pass it.
11545
11546 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11547
11548 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11549
11550 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11551 and `suffix'.
11552 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11553 of variables specific to SELinux and computation of `encoded_absname'.
11554
11555 * image.c (XPutPixel): Remove unused variable `height'.
11556
11557 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11558
11559 * unexw32.c (get_section_info): Remove unused variable `section'.
11560
11561 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11562 (system_process_attributes): Remove unused variable `sess'.
11563 (sys_read): Remove unused variable `err'.
11564
11565 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11566 (w32_wnd_proc): Remove unused variable `isdead'.
11567 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11568 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11569 (x_create_tip_frame): Remove unused variable `tem'.
11570
11571 * w32inevt.c (w32_console_read_socket):
11572 Remove unused variable `no_events'.
11573
11574 * w32term.c (x_draw_composite_glyph_string_foreground):
11575 Remove unused variable `width'.
11576
11577 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11578
11579 * w32term.c (x_set_glyph_string_clipping):
11580 Don't pass uninitialized region to CombineRgn.
11581
11582 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11583
11584 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11585 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11586 (Fx_close_connection): Remove unused variable `i'.
11587
11588 * w32font.c (w32font_draw): Return number of glyphs.
11589 (w32font_open_internal): Remove unused variable `i'.
11590 (w32font_driver): Add missing initializer.
11591
11592 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11593 (fill_in_menu): Remove unused variable `items_added'.
11594
11595 * w32term.c (last_mouse_press_frame): Remove static global variable.
11596 (w32_clip_to_row): Remove unused variable `f'.
11597 (x_delete_terminal): Remove unused variable `i'.
11598
11599 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11600 (NOTHING): Remove unused static global variable.
11601 (uniscribe_check_otf): Remove unused variable `table'.
11602 (uniscribe_font_driver): Add missing initializers.
11603
11604 2011-03-23 Julien Danjou <julien@danjou.info>
11605
11606 * term.c (Fsuspend_tty, Fresume_tty):
11607 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11608 * window.c (temp_output_buffer_show):
11609 * insdel.c (signal_before_change):
11610 * frame.c (Fhandle_switch_frame):
11611 * fileio.c (Fdo_auto_save):
11612 * emacs.c (Fkill_emacs):
11613 * editfns.c (save_excursion_restore):
11614 * cmds.c (internal_self_insert):
11615 * callint.c (Fcall_interactively):
11616 * buffer.c (Fkill_all_local_variables):
11617 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11618 Use Frun_hooks.
11619 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11620 unconditionally since it does the check itself.
11621
11622 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11623
11624 Fix more problems found by GCC 4.5.2's static checks.
11625
11626 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11627 the first time through the loop, since we know p0 < p1 then.
11628 This also avoids a gcc -Wstrict-overflow warning.
11629
11630 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11631 leading to a memory leak, possible in functions like
11632 load_charset_map_from_file that can allocate an unbounded number
11633 of objects (Bug#8318).
11634
11635 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11636 that could (at least in theory) be that large.
11637
11638 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11639 This is less likely to overflow, and avoids undefined behavior if
11640 overflow does occur. All callers changed. Use strtoul to scan
11641 for the unsigned long integer.
11642 (pint2hrstr): Simplify and tune code slightly.
11643 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11644
11645 * scroll.c (do_scrolling): Work around GCC bug 48228.
11646 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11647
11648 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11649 This also avoids a warning with gcc -Wstrict-overflow.
11650 (validate_x_resource_name): Simplify count usage.
11651 This also avoids a warning with gcc -Wstrict-overflow.
11652
11653 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11654 fail (Bug#8306).
11655
11656 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11657
11658 * process.c (Fmake_network_process): Use socklen_t, not int,
11659 where POSIX says socklen_t is required in portable programs.
11660 This fixes a porting bug on hosts like 64-bit HP-UX, where
11661 socklen_t is wider than int (Bug#8277).
11662 (Fmake_network_process, server_accept_connection):
11663 (wait_reading_process_output, read_process_output):
11664 Likewise.
11665
11666 * process.c: Rename or move locals to avoid shadowing.
11667 (list_processes_1, Fmake_network_process):
11668 (read_process_output_error_handler, exec_sentinel_error_handler):
11669 Rename or move locals.
11670 (Fmake_network_process): Define label "retry_connect" only if needed.
11671 (Fnetwork_interface_info): Fix pointer signedness.
11672 (process_send_signal): Add cast to avoid pointer signedness problem.
11673 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11674 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11675
11676 Make tparam.h and terminfo.c consistent.
11677 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11678 Include tparam.h instead, since it declares them.
11679 * cm.h (PC): Remove extern decl; tparam.h now does this.
11680 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11681 * terminfo.c: Include tparam.h, to check interfaces.
11682 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11683 (tparam): Adjust signature to match interface in tparam.h;
11684 this removes some undefined behavior. Check that outstring and len
11685 are zero, which they always are with Emacs.
11686 * tparam.h (PC, BC, UP): New extern decls.
11687
11688 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11689 (xftfont_open): Rename locals to avoid shadowing.
11690
11691 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11692 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11693 (OTF_TAG_SYM): Omit macro if not needed.
11694 (ftfont_list): Remove unused local.
11695 (get_adstyle_property, ftfont_pattern_entity):
11696 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11697 Rename locals to avoid shadowing.
11698
11699 * xfont.c (xfont_list_family): Mark var as initialized.
11700
11701 * xml.c (make_dom): Now static.
11702
11703 * composite.c (composition_compute_stop_pos): Rename local to
11704 avoid shadowing.
11705 (composition_reseat_it): Remove unused locals.
11706 (find_automatic_composition, composition_adjust_point): Likewise.
11707 (composition_update_it): Mark var as initialized.
11708 (find_automatic_composition): Mark vars as initialized,
11709 with a FIXME (Bug#8290).
11710
11711 character.h: Rename locals to avoid shadowing.
11712 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11713 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11714 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11715 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11716 to avoid shadowing.
11717
11718 * textprop.c (property_change_between_p): Remove; unused.
11719
11720 * intervals.c (interval_start_pos): Now static.
11721
11722 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11723
11724 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11725 Rename locals to avoid shadowing.
11726
11727 * sound.c (wav_play, au_play, Fplay_sound_internal):
11728 Fix pointer signedness.
11729 (alsa_choose_format): Remove unused local var.
11730 (wav_play): Initialize a variable to 0, to prevent undefined
11731 behavior (Bug#8278).
11732
11733 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11734
11735 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11736
11737 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11738 clobbering (Bug#8298).
11739 * sysdep.c (sys_subshell): Likewise.
11740 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11741
11742 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11743 This should get cleaned up, so that child_setup has the
11744 same signature on all platforms.
11745
11746 * callproc.c (call_process_cleanup): Now static.
11747 (relocate_fd): Rename locals to avoid shadowing.
11748
11749 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11750
11751 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11752 not to be necessary, and produces flickering.
11753
11754 2011-03-20 Glenn Morris <rgm@gnu.org>
11755
11756 * config.in: Remove file.
11757
11758 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11759
11760 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11761 are now in src/globals.h.
11762 (syms_of_minibuf): Remove spurious & from previous change.
11763
11764 2011-03-20 Leo Liu <sdl.web@gmail.com>
11765
11766 * minibuf.c (completing-read-function): New variable.
11767 (completing-read-default): Rename from completing-read.
11768 (completing-read): Call completing-read-function.
11769
11770 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11771
11772 * xfaces.c (Fx_load_color_file):
11773 Read color file from absolute filename (bug#8250).
11774
11775 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11776
11777 * makefile.w32-in: Update dependencies.
11778
11779 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11780
11781 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11782
11783 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11784
11785 Fix more problems found by GCC 4.5.2's static checks.
11786
11787 * process.c (make_serial_process_unwind, send_process_trap):
11788 (sigchld_handler): Now static.
11789
11790 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11791 That way, the code declares only the vars that it needs.
11792 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11793 * s/cygwin.h (PTY_ITERATION): Likewise.
11794 * s/darwin.h (PTY_ITERATION): Likewise.
11795 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11796
11797 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11798 * process.c (allocate_pty): Don't declare stb unless it's needed.
11799
11800 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11801 (CONSTANTLIM): Remove; unused.
11802 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11803 Define only if needed.
11804
11805 * unexelf.c (unexec): Name an expression,
11806 to avoid gcc -Wbad-function-cast warning.
11807 Use a different way to cause a compilation error if anyone uses
11808 n rather than nn, a way that does not involve shadowing.
11809 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11810
11811 * deps.mk (unexalpha.o): Remove; unused.
11812
11813 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11814 * unexec.h: New file.
11815 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11816 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11817 Depend on unexec.h.
11818 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11819 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11820 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11821 Change as necessary to match prototype in unexec.h.
11822
11823 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11824 shadowing.
11825 (back_comment, skip_chars): Mark vars as initialized.
11826
11827 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11828 Rename locals to avoid shadowing.
11829
11830 * lread.c (read1): Rewrite so as not to use empty "else".
11831 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11832
11833 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11834
11835 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11836 warning when compiling print.c.
11837
11838 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11839 instead of using an uninitialized var.
11840 (font_sort_entities): Mark var as initialized.
11841
11842 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11843
11844 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11845 pointers to constants.
11846 (font_parse_fcname): Remove unused vars.
11847 (font_delete_unmatched): Now static.
11848 (font_get_spec): Remove; unused.
11849 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11850 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11851 Rename or move locals to avoid shadowing.
11852
11853 * fns.c (require_nesting_list, require_unwind): Now static.
11854 (Ffillarray): Rename locals to avoid shadowing.
11855
11856 * floatfns.c (domain_error2): Define only if needed.
11857 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11858
11859 * alloc.c (mark_backtrace): Move decl from here ...
11860 * lisp.h: ... to here, so that it can be checked.
11861
11862 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11863 (Fdefvar): Rewrite so as not to use empty "else".
11864 (lisp_indirect_variable): Name an expression,
11865 to avoid gcc -Wbad-function-cast warning.
11866 (Fdefvar): Rename locals to avoid shadowing.
11867
11868 * callint.c (quotify_arg, quotify_args): Now static.
11869 (Fcall_interactively): Rename locals to avoid shadowing.
11870 Use const pointer when appropriate.
11871
11872 * lisp.h (get_system_name, get_operating_system_release):
11873 Move decls here, to check interfaces.
11874 * process.c (get_operating_system_release): Move decl to lisp.h.
11875 * xrdb.c (get_system_name): Likewise.
11876 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11877 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11878 some of which prompt warnings from gcc -Wbad-function-cast.
11879 (Fformat_time_string, Fencode_time, Finsert_char):
11880 (Ftranslate_region_internal, Fformat):
11881 Rename or remove local vars to avoid shadowing.
11882 (Ftranslate_region_internal): Mark var as initialized.
11883
11884 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11885 avoid shadowing.
11886
11887 * lisp.h (eassert): Check that the argument compiles, even if
11888 ENABLE_CHECKING is not defined.
11889
11890 * data.c (Findirect_variable): Name an expression, to avoid
11891 gcc -Wbad-function-cast warning.
11892 (default_value, arithcompare, arith_driver, arith_error): Now static.
11893 (store_symval_forwarding): Rename local to avoid shadowing.
11894 (Fmake_variable_buffer_local, Fmake_local_variable):
11895 Mark variables as initialized.
11896 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11897
11898 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11899 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11900 Rename locals to avoid shadowing.
11901 (mark_stack): Move local variables into the #ifdef region where
11902 they're used.
11903 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11904 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11905 needed otherwise.
11906 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11907 (GC_STRING_CHARS): Remove; not used.
11908 (Fmemory_limit): Cast sbrk's returned value to char *.
11909
11910 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11911 avoids undefined behavior in theory.
11912
11913 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11914
11915 Use functions, not macros, for up- and down-casing (Bug#8254).
11916 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11917 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11918 to use the following functions instead of these macros.
11919 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11920 EMACS_INT, since callers assume the returned value fits in int.
11921 (upcase1): Likewise, for UPCASE_TABLE.
11922 (uppercasep, lowercasep, upcase): New static inline functions.
11923 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11924 the race-condition problem in the old DOWNCASE.
11925
11926 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11927 Rename locals to avoid shadowing.
11928 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11929 (regex_compile, re_search_2, re_match_2_internal):
11930 Remove unused local vars.
11931 (FREE_VAR): Rewrite so as not to use empty "else",
11932 which gcc can warn about.
11933 (regex_compile, re_match_2_internal): Mark locals as initialized.
11934 (RETALLOC_IF): Define only if needed.
11935 (WORDCHAR_P): Likewise. This one is never needed, but is used
11936 only in a comment talking about a compiler bug, so put inside
11937 the #if 0 of that comment.
11938 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11939 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11940 Remove; unused.
11941
11942 * search.c (boyer_moore): Rename locals to avoid shadowing.
11943 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11944 (PREV_CHAR_BOUNDARY): Likewise.
11945
11946 * search.c (simple_search): Remove unused var.
11947
11948 * dired.c (compile_pattern): Move decl from here ...
11949 * lisp.h: ... to here, so that it can be checked.
11950 (struct re_registers): New forward decl.
11951
11952 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11953
11954 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11955 All uses changed.
11956 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11957 Rename locals to avoid shadowing.
11958 (Fvertical_motion): Mark locals as initialized.
11959
11960 * casefiddle.c (casify_object, casify_region): Now static.
11961 (casify_region): Mark local as initialized.
11962
11963 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11964
11965 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11966 New macros, so that the caller can use some names other than
11967 gcpro1, gcpro2, etc.
11968 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11969 of the new macros.
11970 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11971 argument, for consistency with GCPRO2_VAR, etc: it is now the
11972 prefix of the variable, not the variable itself. All uses
11973 changed.
11974 * dired.c (directory_files_internal, file_name_completion):
11975 Rename locals to avoid shadowing.
11976
11977 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11978 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11979 dired.c's scmp function, had undefined behavior.
11980 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11981 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11982 * buffer.h: ... to here, because these macros use current_buffer,
11983 and the new implementation with inline functions needs to have
11984 current_buffer in scope now, rather than later when the macros
11985 are used.
11986 (downcase, upcase1): New static inline functions.
11987 (DOWNCASE, UPCASE1): Reimplement using these functions.
11988 This avoids undefined behavior in expressions like
11989 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11990 from race conditions in accessing the global variables
11991 case_temp1 and case_temp2.
11992 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11993 * lisp.h (case_temp1, case_temp2): Remove their decls.
11994 * character.h (ASCII_CHAR_P): Move from here ...
11995 * lisp.h: ... to here, so that the inline functions mentioned
11996 above can use them.
11997
11998 * dired.c (directory_files_internal_unwind): Now static.
11999
12000 * fileio.c (file_name_as_directory, directory_file_name):
12001 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12002 Now static.
12003 (file_name_as_directory): Use const pointers when appropriate.
12004 (Fexpand_file_name): Likewise. In particular, newdir might
12005 point at constant storage, so make it a const pointer.
12006 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12007 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12008 signedness issues.
12009 (Fset_file_times, Finsert_file_contents, auto_save_error):
12010 Rename locals to avoid shadowing.
12011
12012 * minibuf.c (choose_minibuf_frame_1): Now static.
12013 (Ftry_completion, Fall_completions): Rename or remove locals
12014 to avoid shadowing.
12015
12016 * marker.c (bytepos_to_charpos): Remove; unused.
12017
12018 * lisp.h (verify_bytepos, count_markers): New decls,
12019 so that gcc does not warn that these functions aren't declared.
12020
12021 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12022 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12023 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12024 (copy_text): Remove unused local var.
12025
12026 * filelock.c (within_one_second): Now static.
12027 (lock_file_1): Rename local to avoid shadowing.
12028
12029 * buffer.c (fix_overlays_before): Mark locals as initialized.
12030 (fix_start_end_in_overlays): Likewise. This function should be
12031 simplified by using pointers-to-pointers, but that's a different
12032 matter.
12033 (switch_to_buffer_1): Now static.
12034 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12035 (report_overlay_modification): Rename locals to avoid shadowing.
12036
12037 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12038 Fix pointer signedness issue.
12039 (sys_subshell): Mark local as volatile if checking for lint,
12040 to suppress a gcc -Wclobbered warning that does not seem to be right.
12041 (MAXPATHLEN): Define only if needed.
12042
12043 * process.c (serial_open, serial_configure): Move decls from here ...
12044 * systty.h: ... to here, so that they can be checked.
12045
12046 * fns.c (get_random, seed_random): Move extern decls from here ...
12047 * lisp.h: ... to here, so that they can be checked.
12048
12049 * sysdep.c (reset_io): Now static.
12050 (wait_for_termination_signal): Remove; unused.
12051
12052 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12053 (copy_keymap_item, append_key, push_text_char_description):
12054 Now static.
12055 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12056 (DENSE_TABLE_SIZE): Remove; unused.
12057 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12058 (describe_map_tree):
12059 Rename locals to avoid shadowing.
12060
12061 * keyboard.c: Declare functions static if they are not used elsewhere.
12062 (echo_char, echo_dash, cmd_error, top_level_2):
12063 (poll_for_input, handle_async_input): Now static.
12064 (read_char, kbd_buffer_get_event, make_lispy_position):
12065 (make_lispy_event, make_lispy_movement, apply_modifiers):
12066 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12067 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12068 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12069 (read_key_sequence, read_char): Mark locals as initialized.
12070 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12071
12072 * keyboard.h (make_ctrl_char): New decl.
12073 (mark_kboards): Move decl here ...
12074 * alloc.c (mark_kboards): ... from here.
12075
12076 * lisp.h (force_auto_save_soon): New decl.
12077
12078 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12079 (DEFINE_DUMMY_FUNCTION): New macro.
12080 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12081 Use it.
12082 (main): Add casts to avoid warnings
12083 if GCC considers string literals to be constants.
12084
12085 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12086
12087 * dbusbind.c: Pointer signedness fixes.
12088 (xd_signature, xd_append_arg, xd_initialize):
12089 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12090 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12091 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12092 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12093
12094 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12095 if GCC considers string literals to be constants.
12096 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12097
12098 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12099
12100 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12101 (print_preprocess, print_object): New macro to fix last change.
12102
12103 * print.c (print_preprocess): Don't forget font objects.
12104
12105 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12106
12107 * emacs.c (USAGE3): Doc fixes.
12108
12109 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12110
12111 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12112 structure.
12113
12114 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12115
12116 * lisp.h (VWindow_system, Qfile_name_history):
12117 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12118 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12119 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12120
12121 * w32select.c: Don't #include "keyboard.h".
12122 (run_protected): Add extern declaration for waiting_for_input.
12123
12124 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12125 * w32console.c (detect_input_pending, read_input_pending)
12126 (encode_terminal_code):
12127 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12128 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12129 (w32_system_caret_y, Qfile_name_history):
12130 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12131 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12132 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12133 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12134 * w32proc.c (Qlocal, report_file_error):
12135 * w32term.c (Vwindow_system, updating_frame):
12136 * w32uniscribe.c (initialized, uniscribe_font_driver):
12137 Remove unneeded extern declarations.
12138
12139 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12140
12141 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12142
12143 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12144
12145 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12146 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12147 These macros can no longer be used for assignment.
12148
12149 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12150 Assign struct members directly, instead of using BUF_BEGV etc.
12151 (record_buffer_markers, fetch_buffer_markers): New functions for
12152 recording and fetching special buffer markers.
12153 (set_buffer_internal_1, set_buffer_temp): Use them.
12154
12155 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12156
12157 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12158
12159 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12160 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12161
12162 * xdisp.c (hscroll_window_tree):
12163 (reconsider_clip_changes): Use PT instead of BUF_PT.
12164
12165 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12166
12167 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12168 $(EMACS_ROOT)/lib/intprops.h.
12169
12170 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12171
12172 Fix more problems found by GCC 4.5.2's static checks.
12173
12174 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12175 to unsigned char * to avoid compiler diagnostic.
12176 (xg_free_frame_widgets): Make it clear that a local variable is
12177 needed only if USE_GTK_TOOLTIP.
12178 (gdk_window_get_screen): Make it clear that this macro is needed
12179 only if USE_GTK_TOOLTIP.
12180 (int_gtk_range_get_value): New function, which avoids a diagnostic
12181 from gcc -Wbad-function-cast.
12182 (xg_set_toolkit_scroll_bar_thumb): Use it.
12183 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12184 diagnostic from gcc -Wbad-function-cast.
12185 (get_utf8_string, xg_get_file_with_chooser):
12186 Rename locals to avoid shadowing.
12187 (create_dialog): Move locals to avoid shadowing.
12188
12189 * xgselect.c (xg_select): Remove unused var.
12190
12191 * image.c (four_corners_best): Mark locals as initialized.
12192 (gif_load): Initialize transparent_p to zero (Bug#8238).
12193 Mark another local as initialized.
12194 (my_png_error, my_error_exit): Mark with NO_RETURN.
12195
12196 * image.c (clear_image_cache): Now static.
12197 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12198 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12199 (x_edge_detection): Remove unnecessary cast that
12200 gcc -Wbad-function-cast diagnoses.
12201 (gif_load): Fix pointer signedness.
12202 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12203 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12204
12205 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12206
12207 Improve quality of tests for time stamp overflow.
12208 For example, without this patch (encode-time 0 0 0 1 1
12209 1152921504606846976) returns the obviously-bogus value (-948597
12210 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12211 reports time overflow. See
12212 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12213 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12214 * editfns.c: Include limits.h and intprops.h.
12215 (TIME_T_MIN, TIME_T_MAX): New macros.
12216 (time_overflow): Move earlier, to before first use.
12217 (hi_time, lo_time): New functions, for an accurate test for
12218 out-of-range times.
12219 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12220 (Fget_internal_run_time): Don't assume time_t fits in int.
12221 (make_time): Use list2 instead of Fcons twice.
12222 (Fdecode_time): More accurate test for out-of-range times.
12223 (check_tm_member): New function.
12224 (Fencode_time): Use it, to test for out-of-range times.
12225 (lisp_time_argument): Don't rely on undefined left-shift and
12226 right-shift behavior when checking for time stamp overflow.
12227
12228 * editfns.c (time_overflow): New function, refactoring common code.
12229 (Fformat_time_string, Fdecode_time, Fencode_time):
12230 (Fcurrent_time_string): Use it.
12231
12232 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12233 * dired.c (make_time): Move to ...
12234 * editfns.c (make_time): ... here.
12235 * systime.h: Note the move.
12236
12237 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12238
12239 * fringe.c (update_window_fringes): Remove unused variables.
12240
12241 * unexmacosx.c (copy_data_segment): Also copy __got section.
12242 (Bug#8223)
12243
12244 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12245
12246 * termcap.c [MSDOS]: Include "msdos.h".
12247 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12248 Constify `char *' arguments and their references according to
12249 prototypes in tparam.h.
12250
12251 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12252
12253 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12254 Adapt all references accordingly.
12255
12256 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12257
12258 2011-03-11 Tom Tromey <tromey@redhat.com>
12259
12260 * buffer.c (syms_of_buffer): Remove obsolete comment.
12261
12262 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12263
12264 * termhooks.h (encode_terminal_code): Declare prototype.
12265
12266 * msdos.c (encode_terminal_code): Don't declare prototype.
12267
12268 * term.c (encode_terminal_code): Now external again, used by
12269 w32console.c and msdos.c.
12270
12271 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12272 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12273
12274 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12275
12276 Fix some minor problems found by GCC 4.5.2's static checks.
12277
12278 * fringe.c (update_window_fringes): Mark locals as initialized
12279 (Bug#8227).
12280 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12281
12282 * alloc.c (mark_fringe_data): Move decl from here ...
12283 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12284 to check its interface.
12285 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12286
12287 * fontset.c (free_realized_fontset): Now static.
12288 (Fset_fontset_font): Rename local to avoid shadowing.
12289 (fontset_font): Mark local as initialized.
12290 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12291
12292 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12293
12294 * xselect.c (x_disown_buffer_selections): Remove; not used.
12295 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12296 (x_own_selection, Fx_disown_selection_internal): Rename locals
12297 to avoid shadowing.
12298 (x_handle_dnd_message): Remove local to avoid shadowing.
12299
12300 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12301 so that the caller can use some name other than gcpro1.
12302 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12303 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12304 (Fx_backspace_delete_keys_p):
12305 Use them to avoid shadowing, and rename vars to avoid shadowing.
12306 (x_decode_color, x_set_name, x_window): Now static.
12307 (Fx_create_frame): Add braces to silence GCC warning.
12308 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12309 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12310 Remove unused locals.
12311 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12312 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12313 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12314 macros.
12315
12316 * xterm.h (x_mouse_leave): New decl.
12317
12318 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12319 Remove unused functions.
12320 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12321 (x_calc_absolute_position): Now static.
12322 (XTread_socket): Don't define label "out" unless it's used.
12323 Don't declare local "event" unless it's used.
12324 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12325 unless they are used.
12326 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12327 (x_fatal_error_signal): Remove; not used.
12328 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12329 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12330 (x_error_catcher, x_connection_closed, x_error_handler):
12331 (x_error_quitter, xembed_send_message, x_iconify_frame):
12332 (my_log_handler): Rename locals to avoid shadowing.
12333 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12334 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12335
12336 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12337 Rename or move locals to avoid shadowing.
12338 (tty_defined_color, merge_face_heights): Now static.
12339 (free_realized_faces_for_fontset): Remove; not used.
12340 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12341 does not deduce is never used uninitialized.
12342 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12343 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12344
12345 * terminal.c (store_terminal_param): Now static.
12346
12347 * xmenu.c (menu_highlight_callback): Now static.
12348 (set_frame_menubar): Remove unused local.
12349 (xmenu_show): Rename parameter to avoid shadowing.
12350 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12351 since they might point to immutable storage.
12352 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12353 since it's unused otherwise.
12354
12355 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12356 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12357 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12358 avoids a gcc -Wuninitialized diagnostic.
12359 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12360 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12361 does not deduce are never used uninitialized.
12362
12363 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12364
12365 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12366 * window.c (window_loop, size_window):
12367 (run_window_configuration_change_hook, enlarge_window): Likewise.
12368
12369 * window.c (display_buffer): Now static.
12370 (size_window): Mark variables that gcc -Wuninitialized
12371 does not deduce are never used uninitialized.
12372 * window.h (check_all_windows): New decl, to forestall
12373 gcc -Wmissing-prototypes diagnostic.
12374 * dispextern.h (bidi_dump_cached_states): Likewise.
12375
12376 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12377 shadowing.
12378 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12379 Include <limits.h>.
12380 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12381 and to avoid gcc -Wuninitialized warning.
12382 (load_charset_map): Mark variables that gcc -Wuninitialized
12383 does not deduce are never used uninitialized.
12384 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12385
12386 * coding.c (coding_set_source, coding_set_destination):
12387 Use "else { /* comment */ }" rather than "else /* comment */;"
12388 for clarity, and to avoid gcc -Wempty-body warning.
12389 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12390 a block, when the outer 'i' will do.
12391 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12392 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12393 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12394 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12395 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12396 Rename locals to avoid shadowing.
12397 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12398 * coding.c (emacs_mule_char, encode_invocation_designation):
12399 Now static, since they're not used elsewhere.
12400 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12401 (decode_coding_object, encode_coding_object, detect_coding_system):
12402 (decode_coding_emacs_mule): Mark variables that gcc
12403 -Wuninitialized does not deduce are never used uninitialized.
12404 (detect_coding_iso_2022): Initialize a local variable that might
12405 be used uninitialized. Leave a FIXME because it's not clear that
12406 this initialization is needed. (Bug#8211)
12407 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12408 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12409 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12410 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12411 Remove unused macros.
12412
12413 * category.c (hash_get_category_set): Remove unused local var.
12414 (copy_category_table): Now static, since it's not used elsewhere.
12415 * character.c (string_count_byte8): Likewise.
12416
12417 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12418 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12419
12420 * chartab.c (copy_sub_char_table): Now static, since it's not used
12421 elsewhere.
12422 (sub_char_table_ref_and_range, char_table_ref_and_range):
12423 Rename locals to avoid shadowing.
12424 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12425
12426 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12427 (BIDI_BOB): Remove unused macro.
12428
12429 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12430 deduce are never used uninitialized.
12431 * term.c (encode_terminal_code): Likewise.
12432
12433 * term.c (encode_terminal_code): Now static. Remove unused local.
12434
12435 * tparam.h: New file.
12436 * term.c, tparam.h: Include it.
12437 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12438 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12439 Move these decls to tparam.h, and make them agree with what
12440 is actually in tparam.c. The previous trick of using incompatible
12441 decls in different modules does not conform to the C standard.
12442 All callers of tparam changed to use tparam's actual API.
12443 * tparam.c (tparam1, tparam, tgoto):
12444 Use const pointers where appropriate.
12445
12446 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12447 * cm.h (struct cm): Likewise.
12448 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12449 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12450 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12451 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12452 (turn_on_face, init_tty): Likewise.
12453 * termchar.h (struct tty_display_info): Likewise.
12454
12455 * term.c (term_mouse_position): Rename local to avoid shadowing.
12456
12457 * alloc.c (mark_ttys): Move decl from here ...
12458 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12459
12460 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12461
12462 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12463
12464 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12465
12466 * search.c (compile_pattern_1): Remove argument regp, unused since
12467 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12468 (compile_pattern): Don't pass it.
12469
12470 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12471
12472 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12473 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12474 for ! HAVE_GTK3.
12475 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12476
12477 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12478
12479 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12480 gdk_window_get_screen, gdk_window_get_geometry,
12481 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12482 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12483 (xg_get_pixbuf_from_pixmap): New function.
12484 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12485 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12486 Call xg_get_pixbuf_from_pixmap instead of
12487 gdk_pixbuf_get_from_drawable.
12488 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12489 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12490 (xg_check_special_colors): Use GtkStyleContext and its functions
12491 for HAVE_GTK3.
12492 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12493 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12494 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12495 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12496 Call gtk_widget_get_preferred_size.
12497 (xg_frame_resized): gdk_window_get_geometry only takes 5
12498 parameters.
12499 (xg_win_to_widget, xg_event_is_for_menubar):
12500 Call gdk_x11_window_lookup_for_display.
12501 (xg_set_widget_bg): New function.
12502 (delete_cb): New function.
12503 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12504 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12505 (xg_set_background_color): Call xg_set_widget_bg.
12506 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12507 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12508 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12509 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12510 if ! HAVE_GTK3.
12511 (update_frame_tool_bar): Call gtk_widget_hide.
12512 (xg_initialize): Use GDK_KEY_g.
12513
12514 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12515 if ! HAVE_GTK3
12516 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12517
12518 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12519 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12520 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12521
12522 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12523
12524 * w32xfns.c (select_palette): Check success of RealizePalette against
12525 GDI_ERROR, not zero.
12526
12527 See ChangeLog.11 for earlier changes.
12528
12529 ;; Local Variables:
12530 ;; coding: utf-8
12531 ;; End:
12532
12533 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12534
12535 This file is part of GNU Emacs.
12536
12537 GNU Emacs is free software: you can redistribute it and/or modify
12538 it under the terms of the GNU General Public License as published by
12539 the Free Software Foundation, either version 3 of the License, or
12540 (at your option) any later version.
12541
12542 GNU Emacs is distributed in the hope that it will be useful,
12543 but WITHOUT ANY WARRANTY; without even the implied warranty of
12544 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12545 GNU General Public License for more details.
12546
12547 You should have received a copy of the GNU General Public License
12548 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.