]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Small callint.c fix.
[gnu-emacs] / src / ChangeLog
1 2011-10-08 Glenn Morris <rgm@gnu.org>
2
3 * callint.c (Fcall_interactively): Give a more explicit error for the
4 'c' case with a non-character input. (Bug#8479)
5
6 2011-10-08 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
9 lines.
10 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
11 lines that are hscrolled on the left.
12
13 * dispnew.c (buffer_posn_from_coords): Account for a possible
14 presence of header-line. (Bug#4426)
15
16 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
17
18 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
19 advertise functionality which we discourage or doesn't work.
20
21 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
22
23 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
24 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
25 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
26 this makes Emacs dump core during garbage collection on rare
27 occasions. sizeof is obviously inferior to offsetof here, so
28 stick with offsetof.
29 (GC_POINTER_ALIGNMENT): New macro.
30 (mark_memory): Omit 3rd (offset) arg; caller changed.
31 Don't assume EMACS_INT alignment is the same as pointer alignment.
32
33 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
34
35 * keyboard.c (read_key_sequence_remapped): New var.
36 (read_key_sequence): Compute remapping in the right buffer.
37 (command_loop_1): Use read_key_sequence's remapping directly.
38
39 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
40
41 * dired.c (file_name_completion): Don't expand file name.
42 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
43 before checking file name handler.
44
45 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
46 they've been requested explicitly (bug#9591).
47
48 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
49
50 * keymap.c (Fsingle_key_description): Use make_specified_string
51 instead of build_string to build string from push_key_description.
52 (Bug#5193)
53
54 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
55
56 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
57 This fixes a Y2038 bug on 64-bit hosts.
58 * buffer.c (reset_buffer):
59 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
60 (Fclear_buffer_auto_save_failure):
61 Use 0, not -1, to represent an unset failure time, since time_t
62 might not be signed.
63
64 Remove dependency on glibc malloc internals.
65 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
66 Move back here from lisp.h, but with their new implementations.
67 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
68 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
69 * charset.c (charset_table_init): New static var.
70 (syms_of_charset): Use it instead of xmalloc. This removes a
71 dependency on glibc malloc internals. See Eli Zaretskii's comment in
72 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
73 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
74 Move back to alloc.c.
75 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
76 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
77
78 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
79
80 * nsterm.m (windowDidResize): Call x_set_window_size only when
81 ns_in_resize is true. Otherwise set pixelwidth/height and
82 call change_frame_size (Bug#9628).
83
84 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
85
86 Port --enable-checking=all to Fedora 14 x86-64.
87 * charset.c (syms_of_charset): Also account for glibc malloc's
88 internal overhead when calculating the initial malloc maximum.
89
90 Port --enable-checking=all to Fedora 14 x86.
91 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
92 Move to lisp.h.
93 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
94 (overrun_check_realloc, overrun_check_free):
95 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
96 That way, xmalloc returns a properly-aligned pointer even if
97 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
98 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
99 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
100 into account when calculating the initial malloc maximum.
101 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
102 Move here from alloc.c, so that charset.c can use it too.
103 Properly align; the old code wasn't right for common 32-bit hosts
104 when configured with --enable-checking=all.
105 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
106 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
107
108 2011-09-29 Eli Zaretskii <eliz@gnu.org>
109
110 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
111 use EDOM.
112
113 2011-09-28 Eli Zaretskii <eliz@gnu.org>
114
115 * xdisp.c (compute_display_string_end): If there's no display
116 string at CHARPOS, return -1.
117
118 * bidi.c (bidi_fetch_char): When compute_display_string_end
119 returns a negative value, treat the character as a normal
120 character not covered by a display string. (Bug#9624)
121
122 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
123
124 * lread.c (Fread_from_string): Fix typo in docstring.
125
126 2011-09-27 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (handle_invisible_prop): If invisible text ends on a
129 newline, reseat the iterator instead of bidi-iterating there one
130 character at a time. (Bug#9610)
131 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
132 TO_CHARPOS if the bidi iterator is at base embedding level.
133
134 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
135
136 * lread.c (readevalloop): Use correct code for NBSP.
137 (read1): Likewise. (Bug#9608)
138
139 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
140
141 * dbusbind.c (Fdbus_register_signal): When service is not
142 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
143
144 2011-09-25 Glenn Morris <rgm@gnu.org>
145
146 * buffer.c (truncate-lines): Doc fix.
147
148 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
149
150 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
151 (Fset_window_next_buffers): Doc fix.
152
153 2011-09-24 Glenn Morris <rgm@gnu.org>
154
155 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
156
157 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
158
159 Fix minor problems found by static checking.
160 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
161 * indent.c (Fvertical_motion): Fix == vs = typo.
162
163 2011-09-24 Eli Zaretskii <eliz@gnu.org>
164
165 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
166 Default value is now t. Doc fix.
167
168 * indent.c (Fvertical_motion): Compute and apply the overshoot
169 logic when moving up, not only when moving down. Fix the
170 confusing name and values of the it_overshoot_expected variable;
171 logic changes accordingly. (Bug#9254) (Bug#9549)
172
173 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
174 CHARPOS is covered by a display string which includes newlines.
175 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
176 is covered by a display string with embedded newlines.
177
178 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
179
180 * dbusbind.c (Fdbus_register_signal): Add match rule to
181 Vdbus_registered_objects_table. (Bug#9581)
182 (Fdbus_register_method, Vdbus_registered_objects_table):
183 Fix docstring.
184
185 2011-09-24 Jim Meyering <meyering@redhat.com>
186
187 do not ignore write error for any output size
188 The previous change was incomplete.
189 While it makes emacs --batch detect the vast majority of stdout
190 write failures, errors were still ignored whenever the output size is
191 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
192 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
193 && echo FAIL: ignored write error
194 FAIL: ignored write error
195 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
196 && echo FAIL: ignored write error
197 FAIL: ignored write error
198 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
199
200 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
201
202 * emacs.c (Fkill_emacs): In noninteractive mode exit
203 non-successfully if a write error occurred on stdout. (Bug#9574)
204
205 2011-09-21 Eli Zaretskii <eliz@gnu.org>
206
207 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
208 the xassert test.
209
210 * dispextern.h (struct it): Update the comment documenting what
211 can it->OBJECT be.
212
213 2011-09-20 Eli Zaretskii <eliz@gnu.org>
214
215 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
216 a display string, extend search for cursor position to end of row.
217 (find_row_edges): If the row ends in a newline from a display
218 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
219 Handle the case of a display string with multiple newlines.
220 (Fcurrent_bidi_paragraph_direction): Fix search for previous
221 non-empty line. Fixes confusing cursor motion with arrow keys at
222 the beginning of a line that starts with whitespace.
223
224 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
225
226 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
227 (bug#9493).
228
229 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
230
231 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
232 boolean (Bug#9154).
233
234 2011-09-18 Eli Zaretskii <eliz@gnu.org>
235
236 * xdisp.c (display_line): Record maximum and minimum buffer
237 positions even if no glyphs were produced (e.g., by a zero-width
238 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
239 buffer positions that will be removed from the glyph row because
240 they don't fit.
241 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
242 column is beyond frame width: don't subtract 1 "pixel" when
243 computing width of the stretch.
244 (reseat_at_next_visible_line_start): Undo the change made on
245 2011-09-17 that saved paragraph information and restored it after
246 the call to `reseat'. (Bug#9545)
247
248 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
249
250 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
251 and turn window cursor on if cleared (Bug#9415).
252
253 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
254
255 * search.c (boyer_moore): Take unibyte characters from pattern
256 literally. (Bug#9458)
257
258 2011-09-18 Eli Zaretskii <eliz@gnu.org>
259
260 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
261
262 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
263
264 Fix minor problem found by static checking.
265 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
266 initialized, to pacify gcc -Wuninitialized.
267
268 * fileio.c: Report proper errno when syscall falls.
269 (Finsert_file_contents): Save and restore errno,
270 so that report_file_error outputs the correct diagnostic.
271 (Fwrite_region) [CLASH_DETECTION]: Likewise.
272
273 2011-09-18 Eli Zaretskii <eliz@gnu.org>
274
275 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
276
277 2011-09-17 Eli Zaretskii <eliz@gnu.org>
278
279 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
280 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
281
282 2011-09-17 Eli Zaretskii <eliz@gnu.org>
283
284 * xdisp.c (reseat_at_next_visible_line_start): Keep information
285 about the current paragraph and restore it after the call to
286 reseat.
287
288 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
289 (bidi_find_paragraph_start): Search back for paragraph beginning
290 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
291 (bidi_move_to_visually_next): Only trigger paragraph-related
292 computations when the last character is a newline or at EOB, not
293 just any NEUTRAL_B. (Bug#9470)
294
295 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
296 truncated lines if point is covered by a display string. (Bug#9524)
297
298 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
299
300 * xselect.c: Relax test for outgoing X longs (Bug#9498).
301 (cons_to_x_long): New function.
302 (lisp_data_to_selection_data): Use it. Correct the test for
303 short-versus-long data; it was negated. Break out of vector
304 loop, for efficiency, when a long datum is discovered.
305
306 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
307
308 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
309
310 2011-09-16 Eli Zaretskii <eliz@gnu.org>
311
312 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
313 GCC PR/17406) by declaring this function with external scope.
314
315 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
316
317 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
318 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
319
320 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
321
322 * editfns.c (Fformat): Correctly handle text properties on "%%".
323
324 2011-09-15 Eli Zaretskii <eliz@gnu.org>
325
326 * xterm.c (x_draw_composite_glyph_string_foreground):
327 * w32term.c (x_draw_composite_glyph_string_foreground):
328 * term.c (encode_terminal_code):
329 * composite.c (composition_update_it, get_composition_id):
330 * xdisp.c (get_next_display_element)
331 (fill_composite_glyph_string): Add comments about special meaning
332 of TAB characters in a composition.
333
334 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
335
336 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
337 This occurs when processing a multibyte format.
338 Problem reported by Wolfgang Jenker.
339
340 2011-09-15 Johan Bockgård <bojohan@gnu.org>
341
342 * xdisp.c (try_cursor_movement): Only check for exact match if
343 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
344
345 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
346
347 Remove unused external symbols.
348 * dispextern.h (calc_pixel_width_or_height): Remove decl.
349 * xdisp.c (calc_pixel_width_or_height): Now static.
350 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
351 * indent.c (check_display_width):
352 * w32term.c: Fix comment to match code.
353 * xterm.c, xterm.h (x_catching_errors): Remove.
354
355 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
356
357 * xselect.c: Use signed conversions more consistently (Bug#9498).
358 (selection_data_to_lisp_data): Assume incoming selection data are
359 signed integers, not unsigned. This is to be consistent with
360 outgoing selection data, which was modified to use signed integers
361 in as part of the fix to Bug#9196 in response to Jan D.'s comment
362 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
363 expects long, not unsigned long.
364
365 2011-09-14 Eli Zaretskii <eliz@gnu.org>
366
367 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
368 computation of loop end. Reported by Johan Bockgård
369 <bojohan@gnu.org>.
370
371 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
372
373 * frame.c (Fother_visible_frames_p): Function deleted.
374
375 2011-09-12 Eli Zaretskii <eliz@gnu.org>
376
377 * indent.c (compute_motion): Process display vector front to back
378 rather than the other way around. (Bug#2496)
379
380 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
383
384 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
385
386 * minibuf.c (Fread_from_minibuffer): Doc fix.
387
388 2011-09-11 Eli Zaretskii <eliz@gnu.org>
389
390 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
391 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
392
393 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
394
395 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
396 value for non-existent files.
397
398 2011-09-11 Eli Zaretskii <eliz@gnu.org>
399
400 * fileio.c (Finsert_file_contents): If the file cannot be opened,
401 set its "size" to -1. This will set the modtime_size field of
402 the corresponding buffer to -1, which is what
403 verify-visited-file-modtime expects for files that do not exist.
404 (Bug#9139)
405
406 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
407
408 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
409 here ...
410 * lisp.h: ... from here. push_key_description is no longer
411 defined in keyboard.c, so its declaration should not be in
412 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
413 logically belongs with push_key_description.
414
415 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
416
417 * buffer.h: Include <sys/types.h> instead of <time.h>.
418 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
419 Problem reported by Herbert J. Skuhra.
420
421 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
422
423 * xml.c (parse_region): Make the parsing work for
424 non-comment-starting XML files again (bug#9144).
425
426 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
427
428 * image.c (gif_load): Fix calculation of bottom and right corner.
429 (Bug#9468)
430
431 2011-09-10 Eli Zaretskii <eliz@gnu.org>
432
433 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
434 redisplay in small windows.
435
436 2011-09-09 Eli Zaretskii <eliz@gnu.org>
437
438 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
439
440 2011-09-08 Martin Rudalics <rudalics@gmx.at>
441
442 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
443 Operate on live windows only.
444
445 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
446
447 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
448
449 2011-09-07 Eli Zaretskii <eliz@gnu.org>
450
451 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
452 only under bidi iteration.
453
454 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
455
456 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
457
458 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
459
460 isnan: Fix porting problem to Solaris 10 with bundled gcc.
461 Without this fix, the command to link temacs failed due to an
462 undefined symbol __builtin_isnan. This is because
463 /usr/include/iso/math_c99.h #defines isnan(x) to
464 __builtin_isnan(x), but the bundled gcc, which identifies itself
465 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
466 a __builtin_isnan.
467 * floatfns.c (isnan): #undef, and then #define to a clone of
468 what's in data.c.
469 (Fisnan): Always define, since it's always available now.
470 (syms_of_floatfns): Always define isnan at the Lisp level.
471
472 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
473
474 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
475
476 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
477
478 * fileio.c: Fix bugs with large file offsets (Bug#9428).
479 The previous code assumed that file offsets (off_t values) fit in
480 EMACS_INT variables, which is not true on typical 32-bit hosts.
481 The code messed up by falsely reporting buffer overflow in cases
482 such as (insert-file-contents "big" nil 1 2) into an empty buffer
483 when "big" contains more than 2**29 bytes, even though this
484 inserts just one byte and does not overflow the buffer.
485 (Finsert_file_contents): Store file offsets as off_t
486 values, not as EMACS_INT values. Check for overflow when
487 converting between EMACS_INT and off_t. When checking for
488 buffer overflow or for overlap, take the offsets into account.
489 Don't use EMACS_INT for small values where int suffices.
490 When checking for overlap, fix a typo: ZV was used where
491 ZV_BYTE was intended.
492 (Fwrite_region): Don't assume off_t fits into 'long'.
493 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
494
495 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
496
497 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
498
499 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
500
501 sprintf-related integer and memory overflow issues (Bug#9412).
502
503 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
504 (esprintf, exprintf, evxprintf): New functions.
505 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
506 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
507 (modify_event_symbol): Do not assume that the length of
508 name_alist_or_stem is safe to alloca and fits in int.
509 (Fexecute_extended_command): Likewise for function name and binding.
510 (Frecursion_depth): Wrap around reliably on integer overflow.
511 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
512 since some callers pass EMACS_INT values.
513 (Fsingle_key_description): Don't crash if symbol name contains more
514 than MAX_ALLOCA bytes.
515 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
516 (get_minibuffer): Arg is now EMACS_INT, not int.
517 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
518 (esprintf, exprintf, evxprintf): New decls.
519 * window.h (command_loop_level, minibuf_level): Reflect API changes.
520
521 * dbusbind.c (signature_cat): New function.
522 (xd_signature, Fdbus_register_signal):
523 Do not overrun buffer; instead, report string overflow.
524
525 * dispnew.c (add_window_display_history): Don't overrun buffer.
526 Truncate instead; this is OK since it's just a log.
527
528 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
529 even if the time zone offset is outlandishly large.
530 Don't mishandle offset == INT_MIN.
531
532 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
533 when creating daemon; the previous buffer-overflow check was incorrect.
534
535 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
536 which has the guts of the old verror function.
537
538 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
539 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
540
541 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
542 (font_unparse_xlfd): Don't blindly alloca long strings.
543 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
544 fits in int, when using sprintf. Use single snprintf to count
545 length of string rather than counting it via multiple sprintfs;
546 that's simpler and more reliable.
547 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
548 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
549 sprintf, in case result does not fit in int.
550
551 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
552 (fontset_from_font): Print it.
553
554 * frame.c (tty_frame_count): Now printmax_t, not int.
555 (make_terminal_frame, set_term_frame_name): Print it.
556 (x_report_frame_params): In X, window IDs are unsigned long,
557 not signed long, so print them as unsigned.
558 (validate_x_resource_name): Check for implausibly long names,
559 and don't assume name length fits in 'int'.
560 (x_get_resource_string): Don't blindly alloca invocation name;
561 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
562 not fit in int.
563
564 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
565 (xg_check_special_colors, xg_set_geometry):
566 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
567
568 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
569 Use esprintf, not sprintf, in case result does not fit in int.
570
571 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
572 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
573 it as a large positive number.
574 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
575 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
576
577 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
578 in case result does not fit in int.
579
580 * print.c (float_to_string): Detect width overflow more reliably.
581 (print_object): Make sprintf buffer a bit bigger, to avoid potential
582 buffer overrun. Don't assume list length fits in 'int'. Treat
583 print length of 0 as 0, not as infinity; to be consistent with other
584 uses of print length in this function. Don't overflow print length
585 index. Don't assume hash table size fits in 'long', or that
586 vectorlike size fits in 'unsigned long'.
587
588 * process.c (make_process): Use printmax_t, not int, to format
589 process-name gensyms.
590
591 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
592
593 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
594 to avoid potential buffer overrun.
595
596 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
597 if X resource line is longer than 512 bytes.
598
599 * xfns.c (x_window): Make sprintf buffer a bit bigger
600 to avoid potential buffer overrun.
601
602 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
603
604 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
605
606 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
607
608 Integer overflow fixes for scrolling, etc.
609 Without these, Emacs silently mishandles large integers sometimes.
610 For example, "C-u 4294967297 M-x recenter" was treated as if
611 it were "C-u 1 M-x recenter" on a typical 64-bit host.
612
613 * xdisp.c (try_window_id): Check Emacs fixnum range before
614 converting to 'int'.
615
616 * window.c (window_scroll_line_based, Frecenter):
617 Check that an Emacs fixnum is in range before assigning it to 'int'.
618 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
619 values converted from Emacs fixnums.
620 (Frecenter): Don't wrap around a line count if it is out of 'int'
621 range; instead, treat it as an extreme value.
622 (Fset_window_configuration, compare_window_configurations):
623 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
624
625 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
626 that can exceed INT_MAX. Check that EMACS_INT value is in range
627 before assigning it to the (possibly-narrower) index.
628 (match_limit): Don't assume that a fixnum can fit in 'int'.
629
630 * print.c (print_object): Use ptrdiff_t, not int, for index that can
631 exceed INT_MAX.
632
633 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
634 (Fvertical_motion): Don't wrap around LINES values that don't fit
635 in 'int'. Instead, treat them as extreme values. This is good
636 enough for windows, which can't have more than INT_MAX lines anyway.
637
638 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
639
640 * Require libxml/parser.h to avoid compilation warning.
641
642 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
643
644 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
645 since this reportedly can destroy thread storage.
646
647 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
648
649 * syntax.c (find_defun_start): Update all cache variables if
650 exiting early (Bug#9401).
651
652 2011-08-30 Eli Zaretskii <eliz@gnu.org>
653
654 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
655
656 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
657 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
658 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
659
660 * term.c (tty_append_glyph): New function.
661 (produce_stretch_glyph): Static function and its prototype deleted.
662
663 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
664 Add prototypes.
665
666 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
667
668 * image.c (parse_image_spec): Check for nonnegative, not for positive,
669 when checking :margin (Bug#9390).
670 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
671 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
672 so that the name doesn't mislead. All uses changed.
673
674 2011-08-28 Johan Bockgård <bojohan@gnu.org>
675
676 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
677 set_tty_hooks.
678
679 2011-08-27 Eli Zaretskii <eliz@gnu.org>
680
681 * xdisp.c (move_it_to): Don't bail out early when reaching
682 position beyond to_charpos, if we are scanning backwards.
683 (move_it_vertically_backward): When DY == 0, make sure we get to
684 the first character in the line after the newline.
685
686 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
687
688 * ccl.c: Improve and simplify overflow checking (Bug#9196).
689 (ccl_driver): Do not generate an out-of-range pointer.
690 (Fccl_execute_on_string): Remove unnecessary check for
691 integer overflow, noted by Stefan Monnier in
692 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
693 Remove a FIXME that didn't need fixing.
694 Simplify the newly-introduced buffer reallocation code.
695
696 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
697
698 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
699
700 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
701
702 Integer and memory overflow issues (Bug#9196).
703
704 * doc.c (get_doc_string): Rework so that
705 get_doc_string_buffer_size is the actual buffer size, rather than
706 being 1 less than the actual buffer size; this makes xpalloc more
707 convenient.
708
709 * image.c (x_allocate_bitmap_record, cache_image):
710 * xselect.c (Fx_register_dnd_atom):
711 Simplify previous changes by using xpalloc.
712
713 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
714 since either will do and ptrdiff_t is convenient with xpalloc.
715
716 * charset.c (charset_table_size)
717 (struct charset_sort_data.priority): Now ptrdiff_t.
718 (charset_compare): Don't overflow if priorities differ greatly.
719 (Fsort_charsets): Don't assume list length fits in int.
720 Check for size-calculation overflow when allocating sort data.
721 (syms_of_charset): Allocate an initial charset table that is
722 just under 64 KiB, to avoid problems with glibc malloc and mmap.
723
724 * cmds.c (internal_self_insert): Check for size-calculation overflow.
725
726 * composite.h (struct composition.glyph_len): Now int, not unsigned.
727 The actual value is always <= INT_MAX, and leaving it unsigned made
728 overflow checking harder.
729
730 * dispextern.h (struct glyph_matrix.rows_allocated)
731 (struct face_cache.size): Now ptrdiff_t, for convenience in use
732 with xpalloc. The values are still always <= INT_MAX.
733
734 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
735
736 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
737 (SAFE_NALLOCA): New macro.
738
739 * region-cache.c (struct boundary.pos, find_cache_boundary)
740 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
741 (set_cache_region, invalidate_region_cache)
742 (revalidate_region_cache, know_region_cache, region_cache_forward)
743 (region_cache_backward, pp_cache):
744 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
745 so that ptrdiff_t * can be passed to xpalloc.
746 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
747 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
748 (pp_cache): Don't assume cache_len fits in int.
749 * region-cache.h: Adjust extern decls to match.
750
751 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
752 EMACS_INT, since either will do, for xpalloc.
753
754 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
755 (xnmalloc, xnrealloc, xpalloc): New functions.
756
757 * bidi.c (bidi_shelve_header_size): New constant.
758 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
759 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
760
761 * bidi.c (bidi_cache_shrink):
762 * buffer.c (overlays_at, overlays_in, record_overlay_string)
763 (overlay_strings):
764 Don't update size of array until after memory allocation succeeds,
765 because xmalloc/xrealloc may not return.
766 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
767 now that we have proper integer overflow checking.
768 (record_overlay_string, overlay_strings): Catch overflows when
769 calculating size of overlay_str_buf.
770
771 * callproc.c (Fcall_process): Check for size overflow when
772 calculating size of args2.
773 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
774 Normally we prefer signed values, but sticking with ptrdiff_t would
775 require adding more-complicated checks.
776
777 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
778 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
779 Redo buffer-overflow calculations to avoid integer overflow.
780 Add a FIXME comment where memory seems to be over-allocated.
781
782 * character.c (Fstring): Check for size-calculation overflow.
783
784 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
785 unnecessary integer overflow. Check for size overflow.
786 (encode_coding_object): Don't update size until xmalloc succeeds.
787
788 * composite.c (get_composition_id): Check for overflow in glyph
789 length calculations.
790
791 Integer and memory overflow fixes for display code.
792 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
793 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
794 (scrolling_window): Check for overflow in size calculations.
795 (line_draw_cost, realloc_glyph_pool, add_row_entry):
796 Don't assume glyph table len fits in int.
797 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
798 (row_table_size): Now ptrdiff_t, not int.
799 (scrolling_window): Avoid overflow in size calculations.
800 Don't update size until allocation succeeds.
801 * fns.c (concat): Check for overflow in size calculations.
802 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
803 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
804 (NEXT_ALMOST_PRIME_LIMIT): New constant.
805
806 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
807 (get_doc_string): Check for size calculation overflow.
808 Don't update size until allocation succeeds.
809 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
810 EMACS_INT, where ptrdiff_t will do.
811 (Fsubstitute_command_keys): Check for string overflow.
812
813 * editfns.c (set_time_zone_rule): Don't assume environment length
814 fits in int.
815 (message_length): Now ptrdiff_t, not int.
816 (Fmessage_box): Don't update size until allocation succeeds.
817 Don't assume message length fits in int.
818 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
819
820 * emacs.c (main): Do not reallocate argv, since there is a null at
821 the end that can be overwritten, and this way there's no need to
822 worry about size-calculation overflow.
823 (sort_args): Check for size-calculation overflow.
824
825 * eval.c (init_eval_once, grow_specpdl): Don't update size until
826 alloc succeeds.
827 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
828
829 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
830 (x_set_scroll_bar_width, x_figure_window_size):
831 Check for integer overflow.
832 (x_set_alpha): Do not assume XINT fits in int.
833
834 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
835 This is for the members text_lines, text_cols, total_lines, total_cols,
836 where the system imposes an 'int' limit.
837
838 * fringe.c (Fdefine_fringe_bitmap):
839 Don't update size until alloc works.
840
841 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
842 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
843
844 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
845 Check for size-calculation overflow.
846 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
847 do, as we prefer signed integers.
848 (id_to_widget.max_size, id_to_widget.used)
849 (xg_store_widget_in_map, xg_remove_widget_from_map)
850 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
851 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
852 Use and return ptrdiff_t, not int.
853 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
854 * gtkutil.h: Change prototypes to match the above.
855
856 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
857 are duplicate now that they've been promoted to lisp.h.
858 (x_allocate_bitmap_record, x_alloc_image_color)
859 (make_image_cache, cache_image, xpm_load):
860 Don't update size until alloc is done.
861 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
862 (x_detect_edges):
863 Check for size calculation overflow.
864 (ct_colors_allocated_max): New constant.
865 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
866 overflow.
867
868 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
869 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
870 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
871 Use ptrdiff_t, not int, to count maps.
872 (read_char_minibuf_menu_prompt): Check for overflow in size
873 calculations. Don't update size until allocation succeeds.
874 Redo calculations to avoid overflow.
875 * keyboard.h: Change prototypes to match the above.
876
877 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
878 to count maps.
879 (current_minor_maps): Check for size calculation overflow.
880 * keymap.h: Change prototypes to match the above.
881
882 * lread.c (read1, init_obarray): Don't update size until alloc done.
883
884 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
885 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
886
887 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
888 Now ptrdiff_t, not int.
889 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
890 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
891
892 * process.c (Fnetwork_interface_list): Check for overflow
893 in size calculation.
894
895 * region-cache.c (move_cache_gap): Check for size calculation overflow.
896
897 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
898 overflow. Don't bother calling xmalloc when xrealloc will do.
899
900 * search.c (Freplace_match): Check for size calculation overflow.
901 (Fset_match_data): Don't assume list lengths fit in 'int'.
902
903 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
904 for command line length. Do not attempt to address one before the
905 beginning of an array, as that's not portable.
906
907 * term.c (max_frame_lines): Remove; unused.
908 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
909 not int.
910 (encode_terminal_code, calculate_costs): Check for size
911 calculation overflow.
912 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
913 table lengths and related sizes. Don't update size until alloc
914 done. Redo calculations to avoid overflow.
915 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
916
917 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
918 subtracting pointers.
919 (gobble_line): Check for overflow more carefully. Don't update size
920 until alloc done.
921
922 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
923 Don't update size until alloc done.
924 Redo size calculations to avoid overflow.
925 Check for size calculation overflow.
926 (main) [DEBUG]: Fix typo in invoking tparam1.
927
928 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
929 Use ptrdiff_t, not int, for sizes.
930 (store_mode_line_noprop_char): Don't update size until alloc done.
931
932 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
933 Use ptrdiff_t, not int, for sizes.
934 (Finternal_make_lisp_face, cache_face):
935 Check for size calculation overflow.
936 (cache_face): Treat size calculation overflows as if they were
937 memory exhaustion (the usual treatment), rather than aborting.
938
939 * xfns.c (x_encode_text, x_set_name_internal)
940 (Fx_change_window_property): Use ptrdiff_t, not int, to count
941 sizes, since they can exceed INT_MAX in size. Check for size
942 calculation overflow.
943
944 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
945 (xg_select): Check for size calculation overflow.
946 Don't update size until alloc done.
947
948 * xrdb.c (get_environ_db): Don't assume path length fits in int,
949 as sprintf is limited to int lengths.
950
951 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
952 (X_LONG_MIN): New macros.
953 Use them to make the following changes clearer.
954 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
955 This change doesn't affect the value now, but it may help remind
956 future maintainers not to raise the value too much later.
957 (SELECTION_QUANTUM): Remove, replacing with ...
958 (selection_quantum): ... new function, which avoids overflow.
959 All uses changed.
960 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
961 assumption that selection length fits in 'int'.
962 (x_reply_selection_request, x_handle_selection_request)
963 (x_get_window_property, receive_incremental_selection)
964 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
965 (lisp_data_to_selection_data, clean_local_selection_data):
966 Use ptrdiff_t, not int, to record length of selection.
967 (x_reply_selection_request, x_get_window_property)
968 (receive_incremental_selection, x_property_data_to_lisp):
969 Redo calculations to avoid overflow.
970 (x_reply_selection_request): When sending hint, ceiling it at
971 X_LONG_MAX rather than relying on wraparound overflow to send
972 something.
973 (x_get_window_property, receive_incremental_selection)
974 (lisp_data_to_selection_data, x_property_data_to_lisp):
975 Check for size-calculation overflow.
976 (x_get_window_property, receive_incremental_selection)
977 (lisp_data_to_selection_data, Fx_register_dnd_atom):
978 Don't store size until memory allocation succeeds.
979 (x_get_window_property): Plug memory leak on memory exhaustion.
980 Don't double-block input; malloc is safe here. Don't assume 2**34
981 - 4 fits in unsigned long. Add an xassert to check
982 XGetWindowProperty overflow. Be more careful about overflow
983 calculations, and distinguish size from memory overflow better.
984 (receive_incremental_selection): When tracing, don't assume
985 unsigned int is less than INT_MAX.
986 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
987 harmful) conversions of unsigned short to int.
988 (lisp_data_to_selection_data): Don't assume that integers
989 in the range -65535 through -1 fit in an X unsigned short.
990 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
991 result parameters unless successful. Rely on cons_to_unsigned
992 to report problems with elements; the old code wasn't right anyway.
993 (x_check_property_data): Check for int overflow; we cannot use
994 a wider type due to X limits.
995 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
996
997 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
998
999 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1000 (x_term_init): Check for size calculation overflow.
1001 (x_color_cells): Don't store size until memory allocation succeeds.
1002 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1003 Don't assume alloca size is less than MAX_ALLOCA.
1004 (x_term_init): Don't assume length fits in int (sprintf is limited
1005 to int size).
1006
1007 Use ptrdiff_t for composition IDs.
1008 * character.c (lisp_string_width):
1009 * composite.c (composition_table_size, n_compositions)
1010 (get_composition_id, composition_gstring_from_id):
1011 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1012 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1013 * window.c (Frecenter):
1014 Use ptrdiff_t, not int, for composition IDs.
1015 * composite.c (get_composition_id): Check for integer overflow.
1016 * composite.h: Adjust prototypes to match the above changes.
1017
1018 Use ptrdiff_t for hash table indexes.
1019 * category.c (hash_get_category_set):
1020 * ccl.c (ccl_driver):
1021 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1022 * coding.c (coding_system_charset_list, detect_coding_system):
1023 * coding.h (struct coding_system.id):
1024 * composite.c (get_composition_id, gstring_lookup_cache):
1025 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1026 * image.c (xpm_get_color_table_h):
1027 * lisp.h (hash_lookup, hash_put):
1028 * minibuf.c (Ftest_completion):
1029 Use ptrdiff_t for hash table indexes, not int (which is too
1030 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1031 32-bit --with-wide-int hosts).
1032
1033 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1034 Add a FIXME comment about memory leaks.
1035 (syms_of_charset): Don't assume xmalloc returns.
1036
1037 Don't assume that stated character widths fit in int.
1038 * character.c (Fchar_width, c_string_width, lisp_string_width):
1039 * character.h (CHAR_WIDTH):
1040 * indent.c (MULTIBYTE_BYTES_WIDTH):
1041 Use sanitize_char_width to avoid undefined and/or bad behavior
1042 with outlandish widths.
1043 * character.h (sanitize_tab_width): Rename from sanitize_width,
1044 now that we have two such functions. All uses changed.
1045 (sanitize_char_width): New inline function.
1046
1047 Don't assume that tab-width fits in int.
1048 * character.h (sanitize_width): New inline function.
1049 (SANE_TAB_WIDTH): New macro.
1050 (ASCII_CHAR_WIDTH): Use it.
1051 * indent.c (sane_tab_width): Remove. All uses replaced by
1052 SANE_TAB_WIDTH (current_buffer).
1053 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1054
1055 * fileio.c: Integer overflow issues with file modes.
1056 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1057
1058 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1059 Remove unreachable code.
1060 (read_hex, load_charset_map_from_file): Check for integer overflow.
1061
1062 * xterm.c: don't go over XClientMessageEvent limit
1063 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1064 (x_send_scroll_bar_event): Likewise. Check that the size does not
1065 exceed limits imposed by XClientMessageEvent, as well as the usual
1066 ptrdiff_t and size_t limits.
1067
1068 * keyboard.c: Overflow, signedness and related fixes.
1069 (make_lispy_movement): Use same integer type in forward decl
1070 that is used in the definition.
1071 (read_key_sequence, keyremap_step):
1072 Change bufsize argument back to int, undoing my 2011-03-30 change.
1073 We prefer signed types, and int is wide enough here.
1074 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1075 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1076 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1077 length, not size_t. Use ptrdiff_t for index, not int.
1078 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1079 possibility of integer overflow.
1080
1081 Overflow, signedness and related fixes for images.
1082
1083 * dispextern.h (struct it.stack[0].u.image.image_id)
1084 (struct_it.image_id, struct image.id, struct image_cache.size)
1085 (struct image_cache.used, struct image_cache.ref_count):
1086 * gtkutil.c (update_frame_tool_bar):
1087 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1088 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1089 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1090 * nsmenu.m (update_frame_tool_bar):
1091 * xdisp.c (calc_pixel_width_or_height):
1092 * xfns.c (image_cache_refcount):
1093 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1094 on typical 64-bit hosts.
1095
1096 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1097 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1098 Omit unnecessary casts to int.
1099 (parse_image_spec): Check that integers fall into 'int' range
1100 when the callers expect that.
1101 (image_ascent): Redo ascent calculation to avoid int overflow.
1102 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1103 (lookup_image): Remove unnecessary tests.
1104 (xbm_image_p): Locals are now of int, not EMACS_INT,
1105 since parse_image_check makes sure they fit into int.
1106 (png_load, gif_load, svg_load_image):
1107 Prefer int to unsigned where either will do.
1108 (tiff_handler): New function, combining the cores of the
1109 old tiff_error_handler and tiff_warning_handler.
1110 This function is rewritten to use vsnprintf and thereby avoid
1111 stack buffer overflows. It uses only the features of vsnprintf
1112 that are common to both POSIX and native Microsoft.
1113 (tiff_error_handler, tiff_warning_handler): Use it.
1114 (tiff_load, gif_load, imagemagick_load_image):
1115 Don't assume :index value fits in 'int'.
1116 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1117 (imagemagick_load_image): Check that crop parameters fit into
1118 the integer types that MagickCropImage accepts. Don't assume
1119 Vimagemagick_render_type has a nonnegative value. Don't assume
1120 size_t fits in 'long'.
1121 (gs_load): Use printmax_t to print the widest integers possible.
1122 Check for integer overflow when computing image height and width.
1123
1124 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1125
1126 * xdisp.c (redisplay_window): Don't force window start if point
1127 will be invisible in the resulting window. (Bug#9324)
1128
1129 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1130
1131 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1132 the display spec is of the form `(space ...)'.
1133 (handle_display_spec): Return the value returned by
1134 handle_single_display_spec, not just 1 or zero.
1135 (handle_single_display_spec): If the display spec is of the form
1136 `(space ...)', and specifies display in the text area, return 2
1137 rather than 1.
1138 (try_cursor_movement): Check for the need to scroll more
1139 accurately, and prefer exact match for point under bidi.
1140 Don't advance `row' beyond the last row of the window.
1141
1142 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1143 into disp_prop; all users changed.
1144
1145 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1146 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1147 for the text covered by the display property.
1148
1149 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1150
1151 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1152 Change return value to nil.
1153 (Frecord_buffer): Delete unused function.
1154
1155 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1156
1157 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1158 buffers, return left-to-right.
1159 (set_cursor_from_row): Consider candidate row a win if its glyph
1160 represents a newline and point is on that newline. Fixes cursor
1161 positioning on the newline at EOL of R2L text within L2R
1162 paragraph, and vice versa.
1163 (try_cursor_movement): Check continued rows, in addition to
1164 continuation rows. Fixes unwarranted scroll when point enters a
1165 continued line of R2L text within an L2R paragraph, or vice versa.
1166 (cursor_row_p): Consider the case of point being equal to
1167 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1168 from the end of a short line to the beginning of a continued line
1169 of R2L text within L2R paragraph.
1170 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1171 composed characters.
1172
1173 * bidi.c (bidi_check_type): Use xassert.
1174 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1175 members.
1176
1177 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1178
1179 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1180 a character.
1181
1182 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1183
1184 * nsfont.m (ns_otf_to_script): Fix typo.
1185
1186 2011-08-22 Kenichi Handa <handa@m17n.org>
1187
1188 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1189 extra slot even if the purpose is char-code-property-table.
1190
1191 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1192
1193 * xdisp.c (redisplay_window): When computing centering_position,
1194 account for the height of the header line. (Bug#8874)
1195
1196 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1197 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1198 candidate is selected by the mouse, and that candidate has a
1199 composed character under the mouse.
1200
1201 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1202 coordinates reported by pos-visible-in-window-p for a composed
1203 character in column zero.
1204
1205 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1208
1209 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1210
1211 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1212 consider it a hit if to_charpos is anywhere in the range of the
1213 composed buffer positions.
1214
1215 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1216
1217 * image.c (gif_load): Don't assume that each subimage has the same
1218 dimensions as the base image. Handle disposal method that is
1219 "undefined" by the gif spec (Bug#9335).
1220
1221 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1222
1223 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1224 (Fcondition_case): Document `debug' symbol in error handler.
1225
1226 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1227
1228 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1229 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1230 from an Org mode buffer to a Speedbar frame.
1231
1232 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1233 a composition, take its buffer position from IT->cmp_it.charpos.
1234 Fixes cursor positioning at the beginning of a line that begins
1235 with a composed character.
1236
1237 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1238
1239 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1240 character bidirectional type, use STRONG_L instead. Fixes crashes
1241 in a buffer produced by `describe-categories'.
1242
1243 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1244 members before the level stack, so they would be saved and
1245 restored when copying iterator state. Fixes incorrect reordering
1246 around TABs covered by display properties.
1247
1248 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1249
1250 * process.c (Fnetwork_interface_list): Correctly determine buffer
1251 size.
1252
1253 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1254
1255 * eval.c (internal_condition_case, internal_condition_case_1)
1256 (internal_condition_case_2, internal_condition_case_n):
1257 Remove unnecessary aborts (Bug#9081).
1258
1259 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1260
1261 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1262 has no `load' handler, try opening the file locally. (Bug#9311)
1263
1264 2011-08-16 Ken Brown <kbrown@cornell.edu>
1265
1266 * gmalloc.c: Expand comment.
1267
1268 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1269
1270 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1271 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1272
1273 2011-08-16 Ken Brown <kbrown@cornell.edu>
1274
1275 Fix memory allocation problems in Cygwin build (Bug#9273).
1276
1277 * unexcw.c ( __malloc_initialized): Declare external variable.
1278 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1279
1280 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1281 New variables.
1282 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1283 dumped emacs.
1284 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1285 in the static heap.
1286 [CYGWIN] (special_realloc): New function.
1287 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1288 requests to realloc storage in the static heap.
1289
1290 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 * bidi.c (bidi_initialize): Remove unused local.
1293
1294 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1295
1296 * biditype.h: File removed.
1297
1298 * bidimirror.h: File removed.
1299
1300 * deps.mk (bidi.o): Remove biditype.h and
1301 bidimirror.h.
1302
1303 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1304 bidimirror.h.
1305
1306 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1307
1308 * chartab.c: Improve commentary for the uniprop_table API.
1309
1310 * bidi.c (bidi_paragraph_init): Support zero value of
1311 bidi_ignore_explicit_marks_for_paragraph_level.
1312 (bidi_initialize): Use uniprop_table instead of including
1313 biditype.h and bidimirror.h.
1314
1315 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1316 coordinates of the iterator when restoring from ppos_it.
1317 (Bug#9296)
1318
1319 2011-08-14 Kenichi Handa <handa@m17n.org>
1320
1321 * process.c (create_process): Call setup_process_coding_systems
1322 after the pid of the process is set to -1 (Bug#8162).
1323
1324 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xdisp.c (move_it_in_display_line_to): Don't invoke
1327 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1328 ppos_it. Fixes vertical cursor motion when line beginning is
1329 covered by an image. (Bug#9296)
1330
1331 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1332
1333 * nsterm.h (ns_run_ascript): Declare.
1334 (NSAPP_DATA2_RUNASSCRIPT): Define.
1335
1336 * nsfns.m (as_script, as_result, as_status): New static variables.
1337 (ns_run_ascript): New function.
1338 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1339 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1340 the event loop. Get status from as_status (Bug#7276).
1341
1342 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1343 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1344 the event loop (Bug#7276).
1345
1346 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1347
1348 * gnutls.c (QCgnutls_bootprop_priority)
1349 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1350 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1351 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1352 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1353 (QCgnutls_bootprop_verify_hostname_error)
1354 (QCgnutls_bootprop_callbacks_verify): Rename from
1355 Qgnutls_bootprop_..., all uses changed.
1356
1357 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1358 uses changed.
1359
1360 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 * xfaces.c (Qframe_set_background_mode): Now static.
1363 * dispextern.h (Qframe_set_background_mode): Remove decl.
1364
1365 * process.c (Fnetwork_interface_info): Declare local only if needed.
1366
1367 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1368
1369 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1370 (Fnetwork_interface_list): Allocate in increments of bytes instead
1371 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1372 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1373 sockaddr.
1374 (struct ifflag_def): notrailers is smart on OSX.
1375 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1376 Get hardware address with getifaddrs if available.
1377
1378 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1379
1380 * xdisp.c (iterate_out_of_display_property): xassert that
1381 IT->position is set to within IT->object's boundaries. Break from
1382 the loop as soon as EOB is reached; avoids infloops in redisplay
1383 when IT->position is set up wrongly due to some bug.
1384 Set IT->current to match the bidi iterator unconditionally.
1385 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1386 entry. Force push_it to save on the stack the current
1387 buffer/string position, to be restored by pop_it. Fix flags in
1388 the iterator structure wrt the object coming from a display
1389 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1390 properties. (Bug#9284)
1391
1392 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1393
1394 * fontset.c (fontset_get_font_group): Add proper type checks.
1395 (Bug#9172)
1396
1397 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1398
1399 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1400 and LC_VERSION_MIN_MACOSX.
1401 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1402 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1403
1404 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1405
1406 * xdisp.c (forward_to_next_line_start): Allow to use the
1407 no-display-properties-and-no-overlays under bidi display.
1408 Set disp_pos in the bidi iterator to avoid searches for display
1409 properties and overlays.
1410
1411 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1412
1413 * editfns.c (Fset_time_zone_rule): Document relationship with the
1414 setenv function.
1415
1416 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1417 the font entity extracted from the cache (Bug#8109).
1418
1419 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1420
1421 * composite.c (autocmp_chars): Don't reset point. That is done by
1422 restore_point_unwind (Bug#5984).
1423
1424 2011-08-07 Juri Linkov <juri@jurta.org>
1425
1426 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1427 to show the arg `TIME' instead of `TIMEVAL'.
1428
1429 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1430
1431 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1432 display property strides EOL and includes a newline, as in
1433 longlines-mode. (Bug#9254)
1434 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1435 word-wrap under bidirectional display. (Bug#9224)
1436
1437 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1438 is non-zero, even if the data buffer is NULL. Fixes a crash in
1439 vertical-motion with longlines-mode. (Bug#9254)
1440
1441 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1442
1443 * bidi.c <bidi_cache_total_alloc>: Now static.
1444 (bidi_initialize): Initialize bidi_cache_total_alloc.
1445
1446 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1447 cache. (Bug#9221)
1448
1449 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1450 amount allocated this far in `bidi_cache_total_alloc'.
1451 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1452 non-zero, only free the data buffer without restoring the cache
1453 contents. All callers changed.
1454
1455 * dispextern.h (bidi_unshelve_cache): Update prototype.
1456
1457 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1458 (move_it_in_display_line, move_it_to)
1459 (move_it_vertically_backward, move_it_by_lines): Replace the call
1460 to xfree to an equivalent call to bidi_unshelve_cache.
1461 (move_it_in_display_line_to): Fix logic of returning
1462 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1463
1464 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1465
1466 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1467 came from a string character with a `cursor' property. (Bug#9229)
1468
1469 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1470
1471 * Makefile.in (LIB_PTHREAD): New variable.
1472 (LIBES): Add LIB_PTHREAD (Bug#9216).
1473
1474 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1475 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1476
1477 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1478
1479 * regex.c (re_iswctype): Remove some redundant boolean
1480 conversions.
1481
1482 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1483
1484 * xterm.c (x_find_topmost_parent): New function.
1485 (x_set_frame_alpha): Find topmost parent window with
1486 x_find_topmost_parent and set the property there also (bug#9181).
1487 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1488
1489 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1490
1491 * callproc.c (Fcall_process): Avoid vfork clobbering
1492 the local vars buffer, coding_systems, current_dir.
1493
1494 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1495
1496 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1497
1498 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1499
1500 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1501 so that it is not optimized away.
1502
1503 * xdisp.c (compute_display_string_pos): Remove unused local.
1504
1505 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1506
1507 Fix slow cursor motion and scrolling in large buffers with
1508 selective display, like Org Mode buffers. (Bug#9218)
1509
1510 * dispextern.h (struct bidi_it): New member disp_prop_p.
1511
1512 * xdisp.c: Remove one-slot cache of display string positions.
1513 (compute_display_string_pos): Accept an additional argument
1514 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1515 for a display string or property. If found, set DISP_PROP_P
1516 non-zero.
1517
1518 * bidi.c (bidi_fetch_char): Accept an additional argument
1519 DISP_PROP_P, and pass it to compute_display_string_pos.
1520 Only handle text covered by a display string if DISP_PROP_P is returned
1521 non-zero. All callers of bidi_fetch_char changed.
1522
1523 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1524
1525 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1526
1527 2010-12-03 Don March <don@ohspite.net>
1528
1529 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1530 last character M-[char] is translated to ESC [char] (bug#7541).
1531
1532 2011-08-02 Kenichi Handa <handa@m17n.org>
1533
1534 * lisp.h (uniprop_table): Extern it.
1535
1536 * chartab.c (uniprop_table): Make it non-static.
1537
1538 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (forward_to_next_line_start): Accept additional argument
1541 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1542 on the newline.
1543 (reseat_at_next_visible_line_start): Use the bidi iterator state
1544 returned by forward_to_next_line_start to restore the state of
1545 it->bidi_it after backing up to previous newline. (Bug#9212)
1546
1547 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1548
1549 * regex.c (re_comp): Protoize.
1550 (re_exec): Fix return type.
1551 (regexec): Fix type of `ret'. (Bug#9203)
1552
1553 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1556 This is needed if max-image-size is a floating-point number.
1557
1558 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1559
1560 * print.c (print_object): Print empty symbol as ##.
1561
1562 * lread.c (read1): Read ## as empty symbol.
1563
1564 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1565
1566 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1567 setting frame foreground color (Bug#9175).
1568 (x_set_background_color): Likewise.
1569
1570 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1571 contents (Bug#9176).
1572 (EmacsTooltip -init): Remove bezels and add shadows to
1573 tooltip windows.
1574
1575 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1576 or scroll bar (Bug#8470).
1577
1578 * nsfont.m (nsfont_open): Remove assignment to voffset and
1579 unnecessary vars hshink, expand, hd, full_height, min_height.
1580 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1581
1582 * nsterm.h (nsfont_info): Remove voffset field.
1583
1584 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1585
1586 Implement strike-through and overline on NextStep (Bug#8863).
1587
1588 * nsfont.m (nsfont_open): Use underline position provided by font,
1589 instead of hard-coded value of 2.
1590 (nsfont_draw): Call ns_draw_text_decoration instead.
1591
1592 * nsterm.h: Add declaration for ns_draw_text_decoration.
1593
1594 * nsterm.m (ns_draw_text_decoration): New function for drawing
1595 underline, overline, and strike-through.
1596 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1597 ns_draw_text_decoration. Change treatment of cursor drawing to
1598 accommodate underlining, etc.
1599
1600 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1601
1602 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1603 default.
1604
1605 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1606
1607 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1608 Without this fix, if a signal arrives just after memory fills up,
1609 'malloc' might be invoked reentrantly.
1610
1611 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1612 In other words, assume that every image size is allowed, on non-X
1613 hosts. This assumption is probably wrong, but it lets Emacs compile.
1614
1615 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1616
1617 * regex.c (re_iswctype): Convert return values to boolean.
1618
1619 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1620
1621 * xdisp.c (compute_display_string_pos): Don't use cached display
1622 string position if the buffer had its restriction changed.
1623 (Bug#9184)
1624
1625 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1628
1629 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 Integer signedness and overflow and related fixes. (Bug#9079)
1632
1633 * bidi.c: Integer size and overflow fixes.
1634 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1635 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1636 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1637 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1638 (bidi_find_other_level_edge):
1639 Use ptrdiff_t instead of EMACS_INT where either will do.
1640 This works better on 32-bit hosts configured --with-wide-int.
1641 (bidi_cache_ensure_space): Check for size-calculation overflow.
1642 Use % rather than repeated addition, for better worst-case speed.
1643 Don't set bidi_cache_size until after xrealloc returns, because it
1644 might not return.
1645 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1646 (bidi_cache_ensure_space): Also check that the bidi cache size
1647 does not exceed that of the largest Lisp string or buffer. See Eli
1648 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1649
1650 * alloc.c (__malloc_size_t): Remove.
1651 All uses replaced by size_t. See Andreas Schwab's note
1652 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1653
1654 * image.c: Improve checking for integer overflow.
1655 (check_image_size): Assume that f is nonnull, since
1656 it is always nonnull in practice. This is one less thing to
1657 worry about when checking for integer overflow later.
1658 (x_check_image_size): New function, which checks for integer
1659 overflow issues inside X.
1660 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1661 This removes the need for a memory_full check.
1662 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1663 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1664 (xbm_read_bitmap_data): Change locals back to 'int', since
1665 their values must fit in 'int'.
1666 (xpm_load_image, png_load, tiff_load):
1667 Invoke x_create_x_image_and_pixmap earlier,
1668 to avoid much needless work if the image is too large.
1669 (tiff_load): Treat overly large images as if
1670 x_create_x_image_and_pixmap failed, not as malloc failures.
1671 (gs_load): Use x_check_image_size.
1672
1673 * gtkutil.c: Omit integer casts.
1674 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1675 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1676
1677 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1678
1679 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1680 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1681 would wrongly return t on a 64-bit host.
1682
1683 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1684 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1685 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1686 and therefore cause GCC to emit a bogus diagnostic in some cases.
1687
1688 * image.c: Integer signedness and overflow and related fixes.
1689 This is not an exhaustive set of fixes, but it's time to
1690 record what I've got.
1691 (lookup_pixel_color, check_image_size): Remove redundant decls.
1692 (check_image_size): Don't assume that arbitrary EMACS_INT values
1693 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1694 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1695 (tiff_load, imagemagick_load_image):
1696 Check for overflow in size calculations.
1697 (x_create_x_image_and_pixmap): Remove unnecessary test for
1698 xmalloc returning NULL; that can't happen.
1699 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1700 (xpm_color_bucket): Use better integer hashing function.
1701 (xpm_cache_color): Don't possibly over-allocate memory.
1702 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1703 (gif_memory_source):
1704 Use ptrdiff_t, not int or size_t, to record sizes.
1705 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1706 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1707 either works, as we prefer signed integers.
1708 (tiff_read_from_memory, tiff_write_from_memory):
1709 Return tsize_t, not size_t, since that's what the TIFF API wants.
1710 (tiff_read_from_memory): Don't fail simply because the read would
1711 go past EOF; instead, return a short read.
1712 (tiff_load): Omit no-longer-needed casts.
1713 (Fimagemagick_types): Don't assume size fits into 'int'.
1714
1715 Improve hashing quality when configured --with-wide-int.
1716 * fns.c (hash_string): New function, taken from sxhash_string.
1717 Do not discard information about ASCII character case; this
1718 discarding is no longer needed.
1719 (sxhash-string): Use it. Change sig to match it. Caller changed.
1720 * lisp.h: Declare it.
1721 * lread.c (hash_string): Remove, since we now use fns.c's version.
1722 The fns.c version returns a wider integer if --with-wide-int is
1723 specified, so this should help the quality of the hashing a bit.
1724
1725 * emacs.c: Integer overflow minor fix.
1726 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1727 Define only if GNU_LINUX.
1728 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1729
1730 * dispnew.c: Integer signedness and overflow fixes.
1731 Remove unnecessary forward decls, that were a maintenance hassle.
1732 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1733 All uses changed.
1734 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1735 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1736 (prepare_desired_row, line_draw_cost):
1737 Use int, not unsigned, where either works.
1738 (save_current_matrix, restore_current_matrix):
1739 Use ptrdiff_t, not size_t, where either works.
1740 (init_display): Check for overflow more accurately, and without
1741 relying on undefined behavior.
1742
1743 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1744 Remove, replacing with the new symbols in lisp.h. All uses changed.
1745 * fileio.c (make_temp_name):
1746 * filelock.c (lock_file_1, lock_file):
1747 * xdisp.c (message_dolog):
1748 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1749 Use pMd etc. instead.
1750 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1751 replacing the pWIDE etc. symbols removed from editfns.c.
1752
1753 * keyboard.h (num_input_events): Now uintmax_t.
1754 This is (very slightly) less likely to mess up due to wraparound.
1755 All uses changed.
1756
1757 * buffer.c: Integer signedness fixes.
1758 (alloc_buffer_text, enlarge_buffer_text):
1759 Use ptrdiff_t rather than size_t when either will do, as we prefer
1760 signed integers.
1761
1762 * alloc.c: Integer signedness and overflow fixes.
1763 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1764 (__malloc_size_t): Default to size_t, not to int.
1765 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1766 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1767 Prefer ptrdiff_t to size_t when either would do, as we prefer
1768 signed integers.
1769 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1770 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1771 Now const. Initialize with values that are in range even if char
1772 is signed.
1773 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1774 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1775 These functions do the right thing with sizes > 2**32.
1776 (check_depth): Now ptrdiff_t, not int.
1777 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1778 Adjust to new way of storing sizes. Check for size overflow bugs
1779 in rest of code.
1780 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1781 slightly wrong anyway, as it missed one instance of
1782 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1783 (refill_memory_reserve): Omit needless cast to size_t.
1784 (mark_object_loop_halt): Mark as externally visible.
1785
1786 * xselect.c: Integer signedness and overflow fixes.
1787 (Fx_register_dnd_atom, x_handle_dnd_message):
1788 Use ptrdiff_t, not size_t, since we prefer signed.
1789 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1790 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1791 x_dnd_atoms_size and x_dnd_atoms_length.
1792
1793 * doprnt.c: Prefer signed to unsigned when either works.
1794 * eval.c (verror):
1795 * doprnt.c (doprnt):
1796 * lisp.h (doprnt):
1797 * xdisp.c (vmessage):
1798 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1799 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1800 prefer signed arithmetic to avoid comparison confusion.
1801 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1802 but is a bit tricky.
1803
1804 Assume freestanding C89 headers, string.h, stdlib.h.
1805 * data.c, doprnt.c, floatfns.c, print.c:
1806 Include float.h unconditionally.
1807 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1808 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1809 * regex.c: Likewise for stddef.h, string.h.
1810 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1811 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1812 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1813 (STDC_HEADERS): Remove obsolete defines.
1814 * sysdep.c: Include limits.h unconditionally.
1815
1816 Assume support for memcmp, memcpy, memmove, memset.
1817 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1818 * regex.c (memcmp, memcpy):
1819 Remove; we assume C89 now.
1820
1821 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1822 (__malloc_safe_bcopy): Remove; no longer needed.
1823
1824 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1825 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1826 well either way, and we prefer signed to unsigned.
1827
1828 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1829
1830 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1831 closes the connection while we're reading (bug#9182).
1832
1833 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1834
1835 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1836 are specified (Bug#9168).
1837
1838 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1841 Found by GCC static checking and --with-wide-int on a 32-bit host.
1842
1843 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1844
1845 * xdisp.c (compute_display_string_pos): Fix logic of caching
1846 previous display string position. Initialize cached_prev_pos to
1847 -1. Fixes slow-down at the beginning of a buffer.
1848
1849 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1850
1851 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1852 for attrs[LFACE_FONTSET_INDEX].
1853
1854 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1855
1856 * xml.c (parse_region): Remove unused local
1857 that was recently introduced.
1858
1859 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1860
1861 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1862 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1863
1864 * xdisp.c (move_it_in_display_line_to): Record the best matching
1865 position for TO_CHARPOS while scanning the line, and restore it on
1866 exit if none of the characters scanned was an exact match.
1867 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1868 when exact match is impossible due to invisible text, and the
1869 lines are truncated.
1870
1871 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1872
1873 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1874 for OSX >= 10.7.
1875
1876 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1877
1878 Fix a significant slow-down of cursor motion with C-n, C-p,
1879 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1880 auto-repeat under bidi redisplay in fontified buffers.
1881 * xdisp.c (compute_stop_pos_backwards): New function.
1882 (next_element_from_buffer): Call compute_stop_pos_backwards to
1883 find a suitable prev_stop when we find ourselves before
1884 base_level_stop.
1885 (reseat): Don't look for prev_stop, as that could mean a very long
1886 run.
1887 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1888 <cached_disp_overlay_modiff>: Cache for last found display string
1889 position.
1890 (compute_display_string_pos): Return the cached position if asked
1891 about the same buffer in the same area of character positions, and
1892 the buffer wasn't changed since the time the display string
1893 position was cached.
1894
1895 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1896
1897 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1898 is an integer, which is important for empty lines. (Bug#9149)
1899
1900 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1901
1902 * frame.c (Fmodify_frame_parameters): In tty case, update the
1903 default face if necessary (Bug#4238).
1904
1905 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1906
1907 * editfns.c (Fstring_to_char): No need to explain what a character
1908 is in the docstring (Bug#6576).
1909
1910 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1911
1912 * xml.c (parse_region): Make sure we always return a tree.
1913
1914 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1915
1916 * xml.c (parse_region): If a document contains only comments,
1917 return that, too.
1918
1919 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1920
1921 * xml.c (make_dom): Return comments, too.
1922
1923 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 Port to OpenBSD.
1926 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1927 and the surrounding thread.
1928 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1929 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1930 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1931 timer goes off.
1932 * s/openbsd.h (BROKEN_SIGIO): Define.
1933 * unexelf.c (unexec) [__OpenBSD__]:
1934 Don't update the .mdebug section of the Alpha COFF symbol table.
1935
1936 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1937
1938 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1939 (bug#8460).
1940
1941 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1944 This fixes some race conditions on the permissions of any newly
1945 created file.
1946
1947 * alloc.c (valid_pointer_p): Use pipe, not open.
1948 This fixes some permissions issues when debugging.
1949
1950 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1951 If fchown fails to set both uid and gid, try to set just gid,
1952 as that is sometimes allowed. Adjust the file's mode to eliminate
1953 setuid or setgid bits that are inappropriate if fchown fails.
1954
1955 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1956
1957 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1958 to compare Lisp_Objects.
1959 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1960 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1961 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1962
1963 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1964
1965 * lread.c (read_integer): Unread even EOF character.
1966 (read1): Likewise. Properly record start position of symbol.
1967
1968 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1969 symbol character follows.
1970
1971 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1972
1973 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1974 This works around a problem with the previous change to Fcopy_file.
1975 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1976 and without this change, GCC might complain about discarding
1977 fchown's return value.
1978
1979 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1980
1981 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1982
1983 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1986
1987 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1988
1989 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1990 it's used from the C level.
1991
1992 * process.c: Use the same condition for POLL_FOR_INPUT in both
1993 keyboard.c and process.c (bug#1858).
1994
1995 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1996
1997 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1998 (Fgnutls_boot): Use it.
1999
2000 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2001
2002 * doc.c (Fsubstitute_command_keys): Revert last change.
2003
2004 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2005
2006 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2007 quotes the next character, and doesn't affect other longer
2008 sequences (bug#8935).
2009
2010 * lread.c (syms_of_lread): Clarify that is isn't only
2011 `eval-buffer' and `eval-defun' that's affected by
2012 `lexical-binding' (bug#8460).
2013
2014 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2015
2016 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2017 bidi redisplay when a line includes both an image and is
2018 truncated.
2019
2020 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 Fix minor problems found by static checking.
2023 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2024 (elsz): Now a signed constant, not a size_t var. We prefer signed
2025 types to unsigned, to avoid integer comparison confusion. Without
2026 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2027 "cannot optimize loop, the loop counter may overflow", a symptom
2028 of the confusion.
2029 * indent.c (Fvertical_motion): Mark locals as initialized.
2030 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2031
2032 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2033
2034 * search.c (Fre_search_backward): Mention `case-fold-search' in
2035 all the re_search_* functions (bug#8138).
2036
2037 * keyboard.c (Fopen_dribble_file): Document when the file is
2038 closed (bug#8056).
2039
2040 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2041
2042 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2043 bidi_cache_idx.
2044
2045 Support bidi reordering of display and overlay strings.
2046 * xdisp.c (compute_display_string_pos)
2047 (compute_display_string_end): Accept additional argument STRING.
2048 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2049 (reseat_to_string): Initialize bidi_it->string.s and
2050 bidi_it->string.schars.
2051 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2052 NULL (avoids a crash in bidi_paragraph_init).
2053 Initialize itb.string.lstring.
2054 (init_iterator): Call bidi_init_it only of a valid
2055 buffer position was specified. Initialize paragraph_embedding to
2056 L2R.
2057 (reseat_to_string): Initialize the bidi iterator.
2058 (display_string): If we need to ignore text properties of
2059 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2060 original value of -1 will not work with bidi.)
2061 (compute_display_string_pos): First arg is now struct
2062 `text_pos *'; all callers changed. Support display properties on
2063 Lisp strings.
2064 (compute_display_string_end): Support display properties on Lisp
2065 strings.
2066 (init_iterator, reseat_1, reseat_to_string): Initialize the
2067 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2068 when iterating on a string not from display properties).
2069 (compute_display_string_pos, compute_display_string_end):
2070 Fix calculation of the object to scan. Fixes an error when using
2071 arrow keys.
2072 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2073 base_level_stop; instead, set base_level_stop to BEGV.
2074 Fixes crashes in vertical-motion.
2075 (next_element_from_buffer): Improve commentary for when
2076 the iterator is before prev_stop.
2077 (init_iterator): Initialize bidi_p from the default value of
2078 bidi-display-reordering, not from buffer-local value. Use the
2079 buffer-local value only if initializing for buffer iteration.
2080 (handle_invisible_prop): Support invisible properties on strings
2081 that are being bidi-reordered.
2082 (set_iterator_to_next): Support bidi reordering of C strings and
2083 Lisp strings.
2084 (next_element_from_string): Support bidi reordering of Lisp
2085 strings.
2086 (handle_stop_backwards): Support Lisp strings as well.
2087 (display_string): Support display of R2L glyph rows.
2088 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2089 (init_iterator): Don't initialize it->bidi_p for strings
2090 here.
2091 (reseat_to_string): Initialize it->bidi_p for strings here.
2092 (next_element_from_string, next_element_from_c_string)
2093 (next_element_from_buffer): Add xassert's for correspondence
2094 between IT's object being iterated and it->bidi_it.string
2095 structure.
2096 (face_before_or_after_it_pos): Support bidi iteration.
2097 (next_element_from_c_string): Handle the case of the first string
2098 character that is not the first one in the visual order.
2099 (get_visually_first_element): New function, refactored from common
2100 parts of next_element_from_buffer, next_element_from_string, and
2101 next_element_from_c_string.
2102 (tool_bar_lines_needed, redisplay_tool_bar)
2103 (display_menu_bar): Force left-to-right direction. Add a FIXME
2104 comment for making that be controlled by a user option.
2105 (push_it, pop_it): Save and restore the state of the
2106 bidi iterator. Save and restore the bidi_p flag.
2107 (pop_it): Iterate out of display property for string iteration as
2108 well.
2109 (iterate_out_of_display_property): Support iteration over strings.
2110 (handle_single_display_spec): Set up it->bidi_it for iteration
2111 over a display string, and call bidi_init_it.
2112 (handle_single_display_spec, next_overlay_string)
2113 (get_overlay_strings_1, push_display_prop): Set up the bidi
2114 iterator for displaying display or overlay strings.
2115 (forward_to_next_line_start): Don't use the shortcut if
2116 bidi-iterating.
2117 (back_to_previous_visible_line_start): If handle_display_prop
2118 pushed the iterator stack, restore the internal state of the bidi
2119 iterator by calling bidi_pop_it same number of times.
2120 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2121 and we are bidi-iterating, don't decrement the iterator position;
2122 instead, set the first_elt flag in the bidi iterator, to produce
2123 the same effect.
2124 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2125 (push_display_prop): xassert that we are iterating a buffer.
2126 (push_it, pop_it): Save and restore paragraph_embedding member.
2127 (handle_single_display_spec, next_overlay_string)
2128 (get_overlay_strings_1, reseat_1, reseat_to_string)
2129 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2130 correctly. Don't assume unibyte strings are not bidi-reordered.
2131 (compute_display_string_pos)
2132 (compute_display_string_end): Fix handling the case of C string.
2133 (push_it, pop_it): Save and restore from_disp_prop_p.
2134 (handle_single_display_spec, push_display_prop): Set the
2135 from_disp_prop_p flag.
2136 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2137 (pop_it): Call iterate_out_of_display_property only if we are
2138 popping after iteration over a string that came from a display
2139 property. Fix a typo in popping stretch info. Add an assertion
2140 for verifying that the iterator position is in sync with the bidi
2141 iterator.
2142 (handle_single_display_spec, get_overlay_strings_1)
2143 (push_display_prop): Fix initialization of paragraph direction for
2144 string when that of the parent object is not yet determined.
2145 (reseat_1): Call bidi_init_it to resync the bidi
2146 iterator with IT's position. (Bug#7616)
2147 (find_row_edges): If ROW->start.pos gives position
2148 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2149 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2150 Reset the from_disp_prop_p flag.
2151 (SAVE_IT, RESTORE_IT): New macros.
2152 (pos_visible_p, face_before_or_after_it_pos)
2153 (back_to_previous_visible_line_start)
2154 (move_it_in_display_line_to, move_it_in_display_line)
2155 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2156 (try_scrolling, redisplay_window, display_line): Use them when
2157 saving a temporary copy of the iterator and restoring it back.
2158 (back_to_previous_visible_line_start, reseat_1)
2159 (init_iterator): Empty the bidi cache "stack".
2160 (move_it_in_display_line_to): If iterator ended up at
2161 EOL, but we never saw any buffer positions smaller than
2162 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2163 motion in bidi-reordered lines.
2164 (move_it_in_display_line_to): Record prev_method and prev_pos
2165 immediately before the call to set_iterator_to_next. Fixes cursor
2166 motion in bidi-reordered lines with stretch glyphs and strings
2167 displayed in margins. (Bug#8133) (Bug#8867)
2168 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2169 TO_CHARPOS.
2170 (pos_visible_p): Support positions in bidi-reordered lines.
2171 Save and restore bidi cache.
2172
2173 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2174 (bidi_paragraph_info): Delete unused struct.
2175 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2176 (bidi_cache_start): New variable.
2177 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2178 to zero.
2179 (bidi_cache_fetch_state, bidi_cache_search)
2180 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2181 (bidi_cache_find, bidi_peek_at_next_level)
2182 (bidi_level_of_next_char, bidi_find_other_level_edge)
2183 (bidi_move_to_visually_next): Compare cache index with
2184 bidi_cache_start rather than with zero.
2185 (bidi_fetch_char): Accept new argument STRING; all callers
2186 changed. Support iteration over a string. Support strings with
2187 display properties. Support unibyte strings. Fix the type of
2188 `len' according to what STRING_CHAR_AND_LENGTH expects.
2189 (bidi_paragraph_init, bidi_resolve_explicit_1)
2190 (bidi_resolve_explicit, bidi_resolve_weak)
2191 (bidi_level_of_next_char, bidi_move_to_visually_next):
2192 Support iteration over a string.
2193 (bidi_set_sor_type, bidi_resolve_explicit_1)
2194 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2195 can now be zero (for strings); special values 0 and -1 were
2196 changed to -1 and -2, respectively.
2197 (bidi_char_at_pos): New function.
2198 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2199 Call it instead of FETCH_MULTIBYTE_CHAR.
2200 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2201 initialized to valid values.
2202 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2203 values.
2204 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2205 the test for valid cached positions. Fix the logic for looking up
2206 the sentinel state in the cache. GCPRO the Lisp string we are
2207 iterating.
2208 (bidi_push_it, bidi_pop_it): New functions.
2209 (bidi_initialize): Initialize the bidi cache start stack pointer.
2210 (bidi_cache_ensure_space): New function, refactored from part of
2211 bidi_cache_iterator_state. Don't assume the required size is just
2212 one BIDI_CACHE_CHUNK away.
2213 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2214 (bidi_count_bytes, bidi_char_at_pos): New functions.
2215 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2216 always valid if bidi_cache_idx is valid.
2217 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2218 is valid if it's going to be used.
2219 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2220 (bidi_cache_fetch_state, bidi_cache_search)
2221 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2222 (bidi_cache_iterator_state, bidi_cache_find)
2223 (bidi_find_other_level_edge, bidi_cache_start_stack):
2224 All variables related to cache indices are now EMACS_INT.
2225
2226 * dispextern.h (struct bidi_string_data): New structure.
2227 (struct bidi_it): New member `string'. Make flag members be 1-bit
2228 fields, and put them last in the struct.
2229 (compute_display_string_pos, compute_display_string_end):
2230 Update prototypes.
2231 (bidi_push_it, bidi_pop_it): Add prototypes.
2232 (struct iterator_stack_entry): New members bidi_p,
2233 paragraph_embedding, and from_disp_prop_p.
2234 (struct it): Member bidi_p is now a bit field 1 bit wide.
2235 (bidi_shelve_cache, bidi_unshelve_cache):
2236 Declare prototypes.
2237
2238 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2239 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2240 and vector-like objects.
2241
2242 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2243 cache around display iteration.
2244
2245 * window.c (Fwindow_end, window_scroll_pixel_based)
2246 (displayed_window_lines, Frecenter): Save and restore the bidi
2247 cache around display iteration.
2248
2249 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2250
2251 * editfns.c (Fdelete_region): Clarify the use of the named
2252 parameters (bug#6788).
2253
2254 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2255
2256 * indent.c (Fvertical_motion): Set and restore w->pointm when
2257 saving and restoring the window's buffer (Bug#9006).
2258
2259 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2260
2261 * editfns.c (Fstring_to_char): Clarify just what is returned
2262 (bug#6576). Text by Eli Zaretskii.
2263
2264 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2265
2266 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2267
2268 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2269
2270 * buffer.c (mmap_find): Fix a typo.
2271
2272 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2273
2274 Fix execution of x selection hooks.
2275 * xselect.c (Qx_lost_selection_functions)
2276 (Qx_sent_selection_functions): New vars.
2277 (syms_of_xselect): DEFSYM them.
2278 (x_handle_selection_request): Pass Qx_sent_selection_functions
2279 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2280 (x_handle_selection_clear,x_clear_frame_selections):
2281 Pass Qx_lost_selection_functions rather than
2282 Vx_lost_selection_functions to Frun_hook_with_args.
2283
2284 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2285
2286 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2287 The old code sometimes used this field without initializing it.
2288
2289 * alloc.c (gc_sweep): Don't read past end of array.
2290 In theory, the old code could also have corrupted Emacs internals,
2291 though it'd be very unlikely.
2292
2293 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2294
2295 * character.c (Fcharacterp): Don't advertise optional ignored
2296 argument. (Bug#4026)
2297
2298 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2299
2300 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2301 key" (bug#4257).
2302
2303 * window.c (Fset_window_start): Doc fix (bug#4199).
2304 (Fset_window_hscroll): Ditto.
2305
2306 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2307
2308 Fix minor new problems caught by GCC 4.6.1.
2309 * term.c (init_tty): Remove unused local.
2310 * xsettings.c (store_monospaced_changed): Define this function only
2311 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2312 not used otherwise.
2313
2314 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2315
2316 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2317
2318 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2319
2320 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2321 are the mini-buffer and the echo area (bug#3320).
2322
2323 * term.c (init_tty): Remove support for supdup, c10 and perq
2324 terminals, which are no longer supported (bug#1482).
2325
2326 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2327
2328 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2329
2330 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2331
2332 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2333 for non-popups (Bug#3642).
2334
2335 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2336
2337 * alloc.c (reset_malloc_hooks): Protoize.
2338 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2339 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2340 * cm.c (losecursor): Likewise.
2341 * data.c (fmod): Likewise.
2342 * dispnew.c (swap_glyphs_in_rows): Likewise.
2343 * emacs.c (memory_warning_signal): Likewise.
2344 * floatfns.c (float_error): Likewise.
2345 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2346 (otf_open, font_otf_capability, generate_otf_features)
2347 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2348 Likewise.
2349 * image.c (pbm_read_file): Likewise.
2350 * indent.c (string_display_width): Likewise.
2351 * intervals.c (check_for_interval, search_for_interval)
2352 (inc_interval_count, count_intervals, root_interval)
2353 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2354 * lread.c (defalias): Likewise.
2355 * ralloc.c (r_alloc_check): Likewise.
2356 * regex.c (set_image_of_range_1, set_image_of_range)
2357 (regex_grow_registers): Likewise.
2358 * sysdep.c (strerror): Likewise.
2359 * termcap.c (valid_filename_p, tprint, main): Likewise.
2360 * tparam.c (main): Likewise.
2361 * unexhp9k800.c (run_time_remap, save_data_space)
2362 (update_file_ptrs, read_header, write_header, calculate_checksum)
2363 (copy_file, copy_rest, display_header): Likewise.
2364 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2365 Likewise.
2366 * xdisp.c (check_it): Likewise.
2367 * xfaces.c (register_color, unregister_color, unregister_colors):
2368 Likewise.
2369 * xfns.c (print_fontset_result): Likewise.
2370 * xrdb.c (member, fatal, main): Likewise.
2371
2372 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2373
2374 Fix minor problems found by static checking (Bug#9031).
2375 * chartab.c (char_table_set_range, map_sub_char_table):
2376 Remove unused locals.
2377 (uniprop_table): Now static.
2378 * composite.c (_work_char): Remove unused static var.
2379
2380 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2381
2382 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2383
2384 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2385
2386 * gtkutil.c (qttip_cb): Remove code without function.
2387
2388 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2389
2390 * w32.c (pthread_sigmask): New stub.
2391
2392 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2393
2394 Use pthread_sigmask, not sigprocmask (Bug#9010).
2395 sigprocmask is portable only for single-threaded applications, and
2396 Emacs can be multi-threaded when it uses GTK.
2397 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2398 (LIBES): Use it.
2399 * callproc.c (Fcall_process):
2400 * process.c (create_process):
2401 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2402 Use pthread_sigmask, not sigprocmask.
2403
2404 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2405
2406 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2407 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2408 wrong (Bug#8591).
2409
2410 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2411
2412 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2413 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2414 (xg_hide_tooltip): Fix comment.
2415
2416 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2417 in registerServicesMenuSendTypes.
2418 (validRequestorForSendType): Don't check ns_return_types.
2419
2420 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2421 ns_return_type.
2422
2423 2011-07-08 Jason Rumney <jasonr@gnu.org>
2424
2425 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2426 frame struct members of non-existent frames (Bug#6284).
2427
2428 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2429
2430 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2431 variable firstTime not needed on OSX >= 10.6.
2432 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2433 >= 10.5. Use setKnobProportion, setDoubleValue.
2434
2435 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2436 (MAC_OS_X_VERSION_10_5): Define if not defined.
2437 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2438 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2439 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2440
2441 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2442 cString and lossyCString on OSX >= 10.4
2443
2444 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2445 sizeToFit on OSX >= 10.2.
2446
2447 * nsimage.m (allocInitFromFile): Don't use deprecated method
2448 bestRepresentationForDevice on OSX >= 10.6.
2449
2450 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2451 to avoid warning.
2452
2453 * emacs.c: Declare unexec_init_emacs_zone.
2454
2455 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2456
2457 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2458
2459 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2460 on svcsMenu (Bug#8842).
2461
2462 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2463 ns_return_types.
2464 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2465
2466 * nsterm.m (QUTF8_STRING): Declare.
2467 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2468 (validRequestorForSendType): Return type is (id).
2469 Change indexOfObjectIdenticalTo to indexOfObject.
2470 Check if we have local selection before returning self (Bug#8842).
2471 (writeSelectionToPasteboard): Put local selection into paste board
2472 if we have a local selection (Bug#8842).
2473 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2474
2475 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2476 (ns_get_local_selection): Declare.
2477
2478 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2479
2480 * keymap.c (describe_map_tree): Don't insert a double newline at
2481 the end of the buffer (bug#1169) and return whether we inserted
2482 something.
2483
2484 * callint.c (Fcall_interactively): Change "reading args" to
2485 "providing args" to try to clarify what it does (bug#1010).
2486
2487 2011-07-07 Kenichi Handa <handa@m17n.org>
2488
2489 * composite.c (composition_compute_stop_pos): Ignore a static
2490 composition starting before CHARPOS (Bug#8915).
2491
2492 * xdisp.c (handle_composition_prop): Likewise.
2493
2494 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2495
2496 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2497 (Bug#9015)
2498
2499 2011-07-07 Kenichi Handa <handa@m17n.org>
2500
2501 * character.h (unicode_category_t): New enum type.
2502
2503 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2504 (Qchar_code_property_table): New variable.
2505 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2506 (UNIPROP_COMPRESSED_FORM_P): New macros.
2507 (char_table_ascii): Uncompress the compressed values.
2508 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2509 Uncompress the compressed values.
2510 (sub_char_table_ref_and_range): Likewise.
2511 (char_table_ref_and_range): Uncompress the compressed values.
2512 (sub_char_table_set): New arg is_uniprop. Callers changed.
2513 Uncompress the compressed values.
2514 (sub_char_table_set_range): Args changed. Callers changed.
2515 (char_table_set_range): Adjuted for the above change.
2516 (map_sub_char_table): Delete args default_val and parent. Add arg
2517 top. Give decoded values to a Lisp function.
2518 (map_char_table): Adjust for the above change. Give decoded
2519 values to a Lisp function. Gcpro more variables.
2520 (uniprop_table_uncompress)
2521 (uniprop_decode_value_run_length): New functions.
2522 (uniprop_decoder, uniprop_decoder_count): New variables.
2523 (uniprop_get_decoder, uniprop_encode_value_character)
2524 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2525 New functions.
2526 (uniprop_encoder, uniprop_encoder_count): New variables.
2527 (uniprop_get_encoder, uniprop_table)
2528 (Funicode_property_table_internal, Fget_unicode_property_internal)
2529 (Fput_unicode_property_internal): New functions.
2530 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2531 Sunicode_property_table_internal, Sget_unicode_property_internal,
2532 and Sput_unicode_property_internal. Defvar_lisp
2533 char-code-property-alist.
2534
2535 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2536 Vunicode_category_table.
2537
2538 * font.c (font_range): Adjust for the change of
2539 Vunicode_category_table.
2540
2541 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2542
2543 * m/iris4d.h: Remove file, move contents ...
2544 * s/irix6-5.h: ... here.
2545
2546 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2547
2548 Remove unportable assumption about struct layout (Bug#8884).
2549 * alloc.c (mark_buffer):
2550 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2551 (clone_per_buffer_values): Don't assume that
2552 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2553 This isn't true in general, and it's particularly not true
2554 if Emacs is configured with --with-wide-int.
2555 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2556 New macros, used in the buffer.c change.
2557
2558 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2559
2560 * xsettings.c: Use both GConf and GSettings if both are available.
2561 (store_config_changed_event): Add comment.
2562 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2563 (store_tool_bar_style_changed): New functions.
2564 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2565 (struct xsettings): Move font inside HAVE_XFT.
2566 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2567 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2568 Move inside HAVE_XFT.
2569 (something_changed_gsettingsCB): Rename from something_changedCB.
2570 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2571 also.
2572 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2573 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2574 (something_changed_gconfCB): Rename from something_changedCB.
2575 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2576 (parse_settings): Move check for font inside HAVE_XFT.
2577 (read_settings, apply_xft_settings): Add comment.
2578 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2579 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2580 call store_font_name_changed.
2581 (xft_settings_event): Add comment.
2582 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2583 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2584 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2585 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2586 (xsettings_initialize): Call init_gsettings last.
2587 (xsettings_get_system_font, xsettings_get_system_normal_font):
2588 Add comment.
2589
2590 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 Random fixes. E.g., (random) never returned negative values.
2593 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2594 subseconds part to the entropy, as that's a bit more random.
2595 Prefer signed to unsigned, since the signedness doesn't matter and
2596 in general we prefer signed. When given a limit, use a
2597 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2598 latter isn't right if USE_2_TAGS_FOR_INTS.
2599 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2600 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2601
2602 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2603
2604 * textprop.c (text_property_stickiness):
2605 Obey Vtext_property_default_nonsticky.
2606 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2607 * w32fns.c (syms_of_w32fns):
2608 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2609
2610 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2613 This is more efficient than Ffile_directory_p and avoids a minor race.
2614
2615 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2616
2617 * buffer.c (Foverlay_put): Say what the return value is
2618 (bug#7835).
2619
2620 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2621 is a directory before asking whether to use the file name
2622 (bug#7564).
2623 (barf_or_query_if_file_exists): Make the "File is a directory"
2624 error be more correct.
2625
2626 * fns.c (Frequire): Remove the mention of the .gz files, since
2627 that's installation-specific, but keep the mention of
2628 `get-load-suffixes'.
2629
2630 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2631
2632 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2633 Report string overflow if the output is too long.
2634
2635 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2636
2637 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2638 (syms_of_gnutls): Remove duplicate DEFSYM for
2639 Qgnutls_bootprop_verify_hostname_error, an error for
2640 Qgnutls_bootprop_verify_error (which is no longer used).
2641
2642 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2643 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2644 Also (re)move comments that are misplaced or no longer relevant.
2645
2646 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2647
2648 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2649
2650 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2651
2652 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2653 and background color parameters if they have been changed.
2654
2655 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2656
2657 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2658
2659 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 * xsettings.c (SYSTEM_FONT): Define only when used.
2662 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2663
2664 * keymap.c (access_keymap_1): Now static.
2665
2666 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2667
2668 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2669 leave any prefix arg for the up event (Bug#1586).
2670
2671 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2672
2673 * lread.c (syms_of_lread): Mention single symbols defined by
2674 `defvar' or `defconst' (bug#7154).
2675
2676 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2677 (Frequire): Mention get-load-suffixes.
2678
2679 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2680
2681 * window.h (window): Remove clone_number slot.
2682 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2683 Remove.
2684 (make_parent_window, make_window, saved_window)
2685 (Fset_window_configuration, save_window_save): Don't deal with
2686 clone numbers.
2687 * buffer.c (Qclone_number): Remove declaration.
2688 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2689
2690 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2691
2692 Add multiple inheritance to keymaps.
2693 * keymap.c (Fmake_composed_keymap): New function.
2694 (Fset_keymap_parent): Simplify.
2695 (fix_submap_inheritance): Remove.
2696 (access_keymap_1): New function extracted from access_keymap to handle
2697 embedded parents and handle lists of maps.
2698 (access_keymap): Use it.
2699 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2700 (Fcopy_keymap): Handle embedded parents.
2701 (Fcommand_remapping, define_as_prefix): Simplify.
2702 (Fkey_binding): Simplify.
2703 (syms_of_keymap): Move minibuffer-local-completion-map,
2704 minibuffer-local-filename-completion-map,
2705 minibuffer-local-must-match-map, and
2706 minibuffer-local-filename-must-match-map to Elisp.
2707 (syms_of_keymap): Defsubr make-composed-keymap.
2708 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2709 (parse_menu_item): Trivial simplification.
2710
2711 2011-07-01 Glenn Morris <rgm@gnu.org>
2712
2713 * Makefile.in (SETTINGS_LIBS): Fix typo.
2714
2715 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2716
2717 * coding.c (Fencode_coding_string): Record the last coding system
2718 used, as the function doc string says (bug#8738).
2719
2720 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2721
2722 * xsettings.c (store_monospaced_changed): Take new font as arg and
2723 check for change against current_mono_font.
2724 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2725 (emacs_settings_constructor, emacs_settings_get_property)
2726 (emacs_settings_set_property, emacs_settings_class_init)
2727 (emacs_settings_init, gsettings_obj): Remove.
2728 (something_changedCB): New function for HAVE_GSETTINGS.
2729 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2730 with value as argument.
2731 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2732 g_settings_new (Bug#8967). Do not create gsettings_obj.
2733 Remove calls to g_settings_bind. Connect something_changedCB to
2734 "changed".
2735
2736 * xgselect.c: Add defined (HAVE_GSETTINGS).
2737 (xgselect_initialize): Ditto.
2738
2739 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2740 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2741 xg_select.
2742
2743 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2744
2745 * eval.c (struct backtrace): Simplify and port the data structure.
2746 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2747 signed bit field, as this assumption is not portable and it makes
2748 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2749 "char debug_on_exit : 1" as this is not portable either; instead,
2750 use the portable "unsigned int debug_on_exit : 1". Remove unused
2751 member evalargs. Remove obsolete comments about cc bombing out.
2752
2753 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2754
2755 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2756 Let HAVE_GSETTINGS override HAVE_GCONF.
2757 (store_monospaced_changed): New function.
2758 (EMACS_SETTINGS): A new type derived from GObject to handle
2759 GSettings notifications.
2760 (emacs_settings_constructor, emacs_settings_get_property)
2761 (emacs_settings_set_property, emacs_settings_class_init):
2762 New functions.
2763 (gsettings_client, gsettings_obj): New variables.
2764 (GSETTINGS_SCHEMA): New define.
2765 (something_changedCB): Call store_monospaced_changed.
2766 (init_gsettings): New function.
2767 (xsettings_initialize): Call init_gsettings.
2768 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2769 to NULL.
2770
2771 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2772 GCONF_CFLAGS/LIBS.
2773
2774 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2775
2776 * window.c (resize_root_window, grow_mini_window)
2777 (shrink_mini_window): Rename Qresize_root_window to
2778 Qwindow_resize_root_window and Qresize_root_window_vertically to
2779 Qwindow_resize_root_window_vertically.
2780
2781 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2782
2783 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2784
2785 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2786
2787 * makefile.w32-in: Redesign dependencies so they reflect more
2788 clearly which files are directly included by each source file,
2789 and not through other includes.
2790
2791 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2792
2793 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2794 (sort_overlays, overlay_strings): When an overlay's clone number
2795 matches the window's clone number process the overlay even if
2796 the overlay's window property doesn't match the current window.
2797
2798 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2799 (Fwindow_hchild): Rename to Fwindow_left_child.
2800 (Fwindow_next): Rename to Fwindow_next_sibling.
2801 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2802 (resize_window_check): Rename to window_resize_check.
2803 (resize_window_apply): Rename to window_resize_apply.
2804 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2805 (Fdelete_other_windows_internal, resize_frame_windows)
2806 (Fsplit_window_internal, Fdelete_window_internal)
2807 (grow_mini_window, shrink_mini_window)
2808 (Fresize_mini_window_internal): Fix callers accordingly.
2809
2810 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2811
2812 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2813 (emacs_fixed_set_min_size): Remove.
2814 (emacs_fixed_new): Take frame as argument.
2815
2816 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2817 (_EmacsFixedPrivate): Remove minwidth/height.
2818 Add struct frame *f.
2819 (emacs_fixed_init): Initialize priv->f.
2820 (get_parent_class, emacs_fixed_set_min_size): Remove.
2821 (emacs_fixed_new): Set priv->f to argument.
2822 (emacs_fixed_get_preferred_width)
2823 (emacs_fixed_get_preferred_height): Use min_width/height from
2824 frames size_hint to set minimum and natural (Bug#8919).
2825 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2826 and use min_width/height from frames size_hint to set
2827 min_width/height (Bug#8919).
2828
2829 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2830 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2831 Fix indentation.
2832
2833 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2834
2835 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2836 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2837 called at ZV.
2838
2839 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2840
2841 * process.c (wait_reading_process_output): Bypass select if
2842 waiting for a cell while ignoring keyboard input, and input is
2843 pending. Suggested by Jan Djärv (Bug#8869).
2844
2845 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 Use gnulib's dup2 module instead of rolling our own.
2848 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2849
2850 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2851
2852 * dispnew.c (scrolling_window): Before scrolling, turn off a
2853 mouse-highlight in the window being scrolled.
2854
2855 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2856
2857 Move DEFSYM to lisp.h and use everywhere.
2858
2859 * character.h (DEFSYM): Move declaration...
2860 * lisp.h (DEFSYM): ...here.
2861
2862 * gnutls.c:
2863 * minibuf.c:
2864 * w32menu.c:
2865 * w32proc.c:
2866 * w32select.c: Don't include character.h.
2867
2868 * alloc.c (syms_of_alloc):
2869 * buffer.c (syms_of_buffer):
2870 * bytecode.c (syms_of_bytecode):
2871 * callint.c (syms_of_callint):
2872 * casefiddle.c (syms_of_casefiddle):
2873 * casetab.c (init_casetab_once):
2874 * category.c (init_category_once, syms_of_category):
2875 * ccl.c (syms_of_ccl):
2876 * cmds.c (syms_of_cmds):
2877 * composite.c (syms_of_composite):
2878 * dbusbind.c (syms_of_dbusbind):
2879 * dired.c (syms_of_dired):
2880 * dispnew.c (syms_of_display):
2881 * doc.c (syms_of_doc):
2882 * editfns.c (syms_of_editfns):
2883 * emacs.c (syms_of_emacs):
2884 * eval.c (syms_of_eval):
2885 * fileio.c (syms_of_fileio):
2886 * fns.c (syms_of_fns):
2887 * frame.c (syms_of_frame):
2888 * fringe.c (syms_of_fringe):
2889 * insdel.c (syms_of_insdel):
2890 * keymap.c (syms_of_keymap):
2891 * lread.c (init_obarray, syms_of_lread):
2892 * macros.c (syms_of_macros):
2893 * msdos.c (syms_of_msdos):
2894 * print.c (syms_of_print):
2895 * process.c (syms_of_process):
2896 * search.c (syms_of_search):
2897 * sound.c (syms_of_sound):
2898 * syntax.c (init_syntax_once, syms_of_syntax):
2899 * terminal.c (syms_of_terminal):
2900 * textprop.c (syms_of_textprop):
2901 * undo.c (syms_of_undo):
2902 * w32.c (globals_of_w32):
2903 * window.c (syms_of_window):
2904 * xdisp.c (syms_of_xdisp):
2905 * xfaces.c (syms_of_xfaces):
2906 * xfns.c (syms_of_xfns):
2907 * xmenu.c (syms_of_xmenu):
2908 * xsettings.c (syms_of_xsettings):
2909 * xterm.c (syms_of_xterm): Use DEFSYM.
2910
2911 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2912
2913 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2914
2915 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 Integer and buffer overflow fixes (Bug#8873).
2918
2919 * print.c (printchar, strout): Check for string overflow.
2920 (PRINTPREPARE, printchar, strout):
2921 Don't set size unless allocation succeeds.
2922
2923 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2924 for sizes. Check for string overflow more accurately.
2925 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2926
2927 * macros.c: Integer and buffer overflow fixes.
2928 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2929 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2930 Use ptrdiff_t, not int, for sizes.
2931 Don't increment bufsize until after realloc succeeds.
2932 Check for size-calculation overflow.
2933 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2934
2935 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2936
2937 * lread.c: Integer overflow fixes.
2938 (read_integer): Radix is now EMACS_INT, not int,
2939 to improve quality of diagnostics for out-of-range radices.
2940 Calculate buffer size correctly for out-of-range radices.
2941 (read1): Check for integer overflow in radices, and in
2942 read-circle numbers.
2943 (read_escape): Avoid int overflow.
2944 (Fload, openp, read_buffer_size, read1)
2945 (substitute_object_recurse, read_vector, read_list, map_obarray):
2946 Use ptrdiff_t, not int, for sizes.
2947 (read1): Use EMACS_INT, not int, for sizes.
2948 Check for size overflow.
2949
2950 * image.c (cache_image): Check for size arithmetic overflow.
2951
2952 * lread.c: Integer overflow issues.
2953 (saved_doc_string_size, saved_doc_string_length)
2954 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2955 Now ptrdiff_t, not int.
2956 (read1): Don't assume doc string length fits in int. Check for
2957 out-of-range doc string lengths.
2958 (read_list): Don't assume file position fits in int.
2959 (read_escape): Check for hex character overflow.
2960
2961 2011-06-22 Leo Liu <sdl.web@gmail.com>
2962
2963 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2964 Move to minibuffer.el.
2965
2966 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2969 The following patches are for when GLYPH_DEBUG && !XASSERT.
2970 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2971 * dispnew.c (flush_stdout):
2972 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2973 Mark as externally visible.
2974 * dispnew.c (check_window_matrix_pointers): Now static.
2975 * dispnew.c (window_to_frame_vpos):
2976 * xfns.c (unwind_create_frame):
2977 * xterm.c (x_check_font): Remove unused local.
2978 * scroll.c (CHECK_BOUNDS):
2979 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2980 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2981 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2982 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2983 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2984 Now static.
2985 (debug_method_add): Use va_list and vsprintf rather than relying
2986 on undefined behavior with wrong number of arguments.
2987 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2988 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2989 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2990 since we're not interested in debugging glyphs with old libraries.
2991 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2992 GCC 4.6.0's static checking.
2993
2994 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2995
2996 Integer overflow and signedness fixes (Bug#8873).
2997 A few related buffer overrun fixes, too.
2998
2999 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3000
3001 * dispextern.h (struct face.stipple):
3002 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3003 (x_bitmap_mask, x_allocate_bitmap_record)
3004 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3005 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3006 (x_create_bitmap_from_xpm_data):
3007 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3008 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3009 (.bitmaps_last):
3010 * xfaces.c (load_pixmap):
3011 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3012 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3013 (.bitmaps_last, struct x_output.icon_bitmap):
3014 Use ptrdiff_t, not int, for bitmap indexes.
3015 (x_allocate_bitmap_record): Check for size overflow.
3016 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3017
3018 Use ptrdiff_t, not int, for overlay counts.
3019 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3020 * editfns.c (overlays_around, get_pos_property):
3021 * textprop.c (get_char_property_and_overlay):
3022 * xdisp.c (next_overlay_change, note_mouse_highlight):
3023 * xfaces.c (face_at_buffer_position):
3024 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3025 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3026 (Fnext_overlay_change, Fprevious_overlay_change)
3027 (mouse_face_overlay_overlaps, Foverlays_in):
3028 Use ptrdiff_t, not int, for sizes.
3029 (overlays_at, overlays_in): Check for size-calculation overflow.
3030
3031 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3032
3033 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3034 (x_session_initialize): Do not assume string length fits in int.
3035
3036 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3037 This is unlikely, but can occur if DPI is outlandish.
3038
3039 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3040 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3041
3042 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3043 * xrdb.c (magic_file_p, search_magic_path):
3044 Omit last arg SUFFIX; it was always 0. All callers changed.
3045 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3046
3047 * xfont.c (xfont_match): Avoid need for strlen.
3048
3049 * xfns.c: Don't assume strlen fits in int.
3050 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3051
3052 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3053 not unsigned long, as we prefer signed integers. All callers changed.
3054 Detect integer overflow in repeat count.
3055 (message_dolog): Don't assume print length fits in 39 bytes.
3056 (display_mode_element): Don't assume strlen fits in int.
3057
3058 * termcap.c: Don't assume sizes fit in int and never overflow.
3059 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3060 (gobble_line): Check for size-calculation overflow.
3061
3062 * minibuf.c (Fread_buffer):
3063 * lread.c (intern, intern_c_string):
3064 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3065 Don't assume string length fits in int.
3066
3067 * keyboard.c (parse_tool_bar_item):
3068 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3069
3070 * font.c: Don't assume string length fits in int.
3071 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3072 Use ptrdiff_t, not int.
3073 (font_intern_prop): Don't assume string length fits in int.
3074 Don't assume integer property fits in fixnum.
3075 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3076
3077 * filelock.c: Fix some buffer overrun and integer overflow issues.
3078 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3079 Reformulate so as not to need the command string.
3080 Invoke gzip -cd rather than gunzip, as it's more portable.
3081 (lock_info_type, lock_file_1, lock_file):
3082 Don't assume pid_t and time_t fit in unsigned long.
3083 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3084 (current_lock_owner): Prefer signed type for sizes.
3085 Use memcpy, not strncpy, where memcpy is what is really wanted.
3086 Don't assume (via atoi) that time_t and pid_t fit in int.
3087 Check for time_t and/or pid_t out of range, e.g., via a network share.
3088 Don't alloca where an auto var works fine.
3089
3090 * fileio.c: Fix some integer overflow issues.
3091 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3092 Don't assume string length fits in int.
3093 (directory_file_name): Don't assume string length fits in long.
3094 (make_temp_name): Don't assume pid fits in int, or that its print
3095 length is less than 20.
3096
3097 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3098
3099 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3100
3101 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3102
3103 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3104 We prefer signed integers, even for size calculations.
3105
3106 * emacs.c: Don't assume string length fits in 'int'.
3107 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3108 (main): Don't invoke strlen when not needed.
3109
3110 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3111 (XD_DEBUG_MESSAGE): Don't waste a byte.
3112
3113 * callproc.c (getenv_internal_1, getenv_internal)
3114 (Fgetenv_internal):
3115 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3116
3117 * lread.c (invalid_syntax): Omit length argument.
3118 All uses changed. This doesn't fix a bug, but it simplifies the
3119 code away from its former Hollerith-constant appearance, and it's
3120 one less 'int' to worry about when looking at integer-overflow issues.
3121 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3122
3123 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3124 This didn't break anything, but it didn't help either.
3125 It's confusing to put a bogus integer in a place where the actual
3126 value does not matter.
3127 (LIST_END_P): Remove unused macro and its bogus comment.
3128 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3129
3130 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3131 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3132 implementation.
3133 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3134 We prefer signed types, and the value cannot exceed the EMACS_INT
3135 range anyway (because otherwise the length would not be representable).
3136 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3137 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3138 This avoids a GCC warning when WIDE_EMACS_INT.
3139
3140 * indent.c (sane_tab_width): New function.
3141 (current_column, scan_for_column, Findent_to, position_indentation)
3142 (compute_motion): Use it. This is just for clarity.
3143 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3144
3145 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3146
3147 * lisp.h (lint_assume): New macro.
3148 * composite.c (composition_gstring_put_cache):
3149 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3150
3151 * editfns.c, insdel.c:
3152 Omit unnecessary forward decls, to simplify future changes.
3153
3154 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3155
3156 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3157
3158 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3159 Use much-faster test for byte-length change.
3160 Don't assume string byte-length fits in 'int'.
3161 Check that character arg fits in 'int'.
3162 (mapcar1): Declare byte as byte, for clarity.
3163
3164 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3165
3166 * fns.c (concat): Catch string overflow earlier.
3167 Do not rely on integer wraparound.
3168
3169 * dispextern.h (struct it.overlay_strings_charpos)
3170 (struct it.selective): Now EMACS_INT, not int.
3171 * xdisp.c (forward_to_next_line_start)
3172 (back_to_previous_visible_line_start)
3173 (reseat_at_next_visible_line_start, next_element_from_buffer):
3174 Don't arbitrarily truncate the value of 'selective' to int.
3175
3176 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3177
3178 * composite.c: Don't truncate sizes to 'int'.
3179 (composition_gstring_p, composition_reseat_it)
3180 (composition_adjust_point): Use EMACS_INT, not int.
3181 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3182 not EMACS_UINT, for indexes.
3183
3184 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3185
3186 * buffer.c: Include <verify.h>.
3187 (struct sortvec.priority, struct sortstr.priority):
3188 Now EMACS_INT, not int.
3189 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3190 (struct sortstr.size, record_overlay_string)
3191 (struct sortstrlist.size, struct sortlist.used):
3192 Don't truncate size to int.
3193 (record_overlay_string): Check for size-calculation overflow.
3194 (init_buffer_once): Check at compile-time, not run-time.
3195
3196 2011-06-22 Jim Meyering <meyering@redhat.com>
3197
3198 Don't leak an XBM-image-sized buffer
3199 * image.c (xbm_load): Free the image buffer after using it.
3200
3201 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3202
3203 Port to Sun C.
3204 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3205 that Sun C diagnosed.
3206 * fns.c (secure_hash): Fix pointer signedness issue.
3207 * intervals.c (static_offset_intervals): New function.
3208 (offset_intervals): Use it.
3209
3210 2011-06-21 Leo Liu <sdl.web@gmail.com>
3211
3212 * deps.mk (fns.o):
3213 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3214 sha512.h.
3215
3216 * fns.c (secure_hash): Rename from crypto_hash_function and change
3217 the first arg to accept symbols.
3218 (Fsecure_hash): New primitive.
3219 (syms_of_fns): New symbols.
3220
3221 2011-06-20 Deniz Dogan <deniz@dogan.se>
3222
3223 * process.c (Fset_process_buffer): Clarify return value in
3224 docstring.
3225
3226 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3227
3228 * dispnew.c (add_window_display_history): Use BVAR.
3229
3230 * xdisp.c (debug_method_add): Use BVAR.
3231 (check_window_end, dump_glyph_matrix, dump_glyph)
3232 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3233
3234 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3235 Likewise.
3236
3237 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3238 check till after the cache is created in init_frame_faces.
3239
3240 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3241
3242 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3243
3244 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3245
3246 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3247 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3248 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3249
3250 Improve buffer-overflow checking (Bug#8873).
3251 * fileio.c (Finsert_file_contents):
3252 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3253 Remove the old (too-loose) buffer overflow checks.
3254 They weren't needed, since make_gap checks for buffer overflow.
3255 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3256 The old code merely checked for Emacs fixnum overflow, and relied
3257 on undefined (wraparound) behavior. The new code avoids undefined
3258 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3259
3260 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3261 Tune. Don't use wider integers than needed. Don't use alloca.
3262 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3263
3264 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3265
3266 * insdel.c, lisp.h (buffer_overflow): New function.
3267 (insert_from_buffer_1, replace_range, replace_range_2):
3268 * insdel.c (make_gap_larger):
3269 * editfns.c (Finsert_char):
3270 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3271
3272 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3273
3274 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 Integer overflow and signedness fixes (Bug#8873).
3277
3278 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3279 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3280
3281 * fileio.c: Don't assume EMACS_INT fits in off_t.
3282 (emacs_lseek): New static function.
3283 (Finsert_file_contents, Fwrite_region): Use it.
3284 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3285
3286 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3287
3288 * fns.c: Don't overflow int when computing a list length.
3289 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3290 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3291 truncation on 64-bit hosts. Check for QUIT every
3292 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3293 faster and is responsive enough.
3294 (Flength): Report an error instead of overflowing an integer.
3295 (Fsafe_length): Return a float if the value is not representable
3296 as a fixnum. This shouldn't happen except in contrived situations.
3297 (Fnthcdr, Fsort): Don't assume list length fits in int.
3298 (Fcopy_sequence): Don't assume vector length fits in int.
3299
3300 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3301 (header_size, word_size): New constants.
3302 (allocate_vectorlike): Don't check size overflow here.
3303 (allocate_vector): Check it here instead, since this is the only
3304 caller of allocate_vectorlike that could cause overflow.
3305 Check that the new vector's length is representable as a fixnum.
3306
3307 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3308 The previous code was bogus. For example, next_almost_prime (32)
3309 returned 39, which is undesirable as it is a multiple of 3; and
3310 next_almost_prime (24) returned 25, which is a multiple of 5 so
3311 why was the code bothering to check for multiples of 7?
3312
3313 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3314
3315 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3316
3317 Variadic C functions now count arguments with ptrdiff_t.
3318 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3319 Back then I didn't know that the Emacs coding style prefers signed int.
3320 Also, in the meantime I found a few more instances where arguments
3321 were being counted with int, which may truncate counts on 64-bit
3322 machines, or EMACS_INT, which may be unnecessarily wide.
3323 * lisp.h (struct Lisp_Subr.function.aMANY)
3324 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3325 Arg counts are now ptrdiff_t, not size_t.
3326 All variadic functions and their callers changed accordingly.
3327 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3328 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3329 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3330 * callint.c (Fcall_interactively): Check arg count for overflow,
3331 to avoid potential buffer overrun. Use signed char, not 'int',
3332 for 'varies' array, so that we needn't bother to check its size
3333 calculation for overflow.
3334 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3335 * eval.c (apply_lambda):
3336 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3337 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3338 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3339
3340 * callint.c (Fcall_interactively): Don't use index var as event count.
3341
3342 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3343 * mem-limits.h (SIZE): Remove; no longer used.
3344
3345 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3346
3347 Remove unnecessary casts.
3348 * xterm.c (x_term_init):
3349 * xfns.c (x_set_border_pixel):
3350 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3351 These aren't needed now that we assume ANSI C.
3352
3353 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3354 It's more likely to cause problems (due to unsigned overflow)
3355 than to cure them.
3356
3357 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3358
3359 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3360
3361 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3362
3363 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3364
3365 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3366
3367 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3368
3369 GLYPH_CODE_FACE returns EMACS_INT, not int.
3370 * dispextern.h (merge_faces):
3371 * xfaces.c (merge_faces):
3372 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3373 Don't assume EMACS_INT fits in int.
3374
3375 * character.h (CHAR_VALID_P): Remove unused parameter.
3376 * fontset.c, lisp.h, xdisp.c: All uses changed.
3377
3378 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3379
3380 * fns.c (concat): Minor tuning based on overflow analysis.
3381 This doesn't fix any bugs. Use int to hold character, instead
3382 of constantly refetching from Emacs object. Use XFASTINT, not
3383 XINT, for value known to be a character. Don't bother comparing
3384 a single byte to 0400, as it's always less.
3385
3386 * floatfns.c (Fexpt):
3387 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3388
3389 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3390 for characters.
3391
3392 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3393
3394 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3395 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3396 incorrectly succeed when S was a string, because 4294967386 was
3397 truncated before it was used.
3398
3399 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3400 Otherwise, an out-of-range integer could cause undefined behavior
3401 on a 64-bit host.
3402
3403 * composite.c: Use int, not EMACS_INT, for characters.
3404 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3405 EMACS_INT, for values that are known to be in character range.
3406 This doesn't fix any bugs but is the usual style inside Emacs and
3407 may generate better code on 32-bit machines.
3408
3409 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3410 This is for reasons similar to the recent CHAR_STRING fix.
3411 * charset.c (Fencode_char): Check that character arg is actually
3412 a character. Pass an int to ENCODE_CHAR.
3413 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3414 wider than 'int', as a compile-time check to prevent future regressions
3415 in this area.
3416
3417 * character.c (char_string): Remove unnecessary casts.
3418
3419 Make sure a 64-bit char is never passed to CHAR_STRING.
3420 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3421 by silently ignoring the top 32 bits, allowing some values
3422 that were far too large to be valid characters.
3423 * character.h: Include <verify.h>.
3424 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3425 arguments are no wider than unsigned, as a compile-time check
3426 to prevent future regressions in this area.
3427 * data.c (Faset):
3428 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3429 (Fsubst_char_in_region):
3430 * fns.c (concat):
3431 * xdisp.c (decode_mode_spec_coding):
3432 Adjust to CHAR_STRING's new requirement.
3433 * editfns.c (Finsert_char, Fsubst_char_in_region):
3434 * fns.c (concat): Check that character args are actually
3435 characters. Without this test, these functions did the wrong
3436 thing with wildly out-of-range values on 64-bit hosts.
3437
3438 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3439 These casts should not be needed on 32-bit hosts, either.
3440 * keyboard.c (read_char):
3441 * lread.c (Fload): Remove casts to unsigned.
3442
3443 * lisp.h (UNSIGNED_CMP): New macro.
3444 This fixes comparison bugs on 64-bit hosts.
3445 (ASCII_CHAR_P): Use it.
3446 * casefiddle.c (casify_object):
3447 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3448 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3449 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3450 * dispextern.h (FACE_FROM_ID):
3451 * keyboard.c (read_char): Use UNSIGNED_CMP.
3452
3453 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3454 not to EMACS_INT, to avoid GCC warning.
3455
3456 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3457
3458 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3459 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3460 isn't needed on 32-bit machines.
3461
3462 * buffer.c (Fgenerate_new_buffer_name):
3463 Use EMACS_INT for count, not int.
3464 (advance_to_char_boundary): Return EMACS_INT, not int.
3465
3466 * data.c (Qcompiled_function): Now static.
3467
3468 * window.c (window_body_lines): Now static.
3469
3470 * image.c (gif_load): Rename local to avoid shadowing.
3471
3472 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3473 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3474 * alloc.c (make_save_value): Integer argument is now of type
3475 ptrdiff_t, not int.
3476 (mark_object): Use ptrdiff_t, not int.
3477 * lisp.h (pD): New macro.
3478 * print.c (print_object): Use it.
3479
3480 * alloc.c: Use EMACS_INT, not int, to count objects.
3481 (total_conses, total_markers, total_symbols, total_vector_size)
3482 (total_free_conses, total_free_markers, total_free_symbols)
3483 (total_free_floats, total_floats, total_free_intervals)
3484 (total_intervals, total_strings, total_free_strings):
3485 Now EMACS_INT, not int. All uses changed.
3486 (Fgarbage_collect): Compute overall total using a double, so that
3487 integer overflow is less likely to be a problem. Check for overflow
3488 when converting back to an integer.
3489 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3490 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3491 These were 'int' variables that could overflow on 64-bit hosts;
3492 they were never used, so remove them instead of repairing them.
3493 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3494 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3495 Previously, this ceilinged at INT_MAX, but that doesn't work on
3496 64-bit machines.
3497 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3498
3499 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3500 (allocate_vectorlike): Check for ptrdiff_t overflow.
3501 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3502 when a (possibly-narrower) signed value would do just as well.
3503 We prefer using signed arithmetic, to avoid comparison confusion.
3504
3505 * alloc.c: Catch some string size overflows that we were missing.
3506 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3507 for convenience in STRING_BYTES_MAX.
3508 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3509 The definition here is exact; the one in lisp.h was approximate.
3510 (allocate_string_data): Check for string overflow. This catches
3511 some instances we weren't catching before. Also, it catches
3512 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3513 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3514 and ptrdiff_t and EMACS_INT are both 64 bits.
3515
3516 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3517 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3518 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3519
3520 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3521
3522 * alloc.c (Fmake_string): Check for out-of-range init.
3523
3524 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3525
3526 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3527
3528 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3529
3530 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3531 xg_get_default_scrollbar_width.
3532
3533 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3534 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3535 (style_changed_cb): Call update_theme_scrollbar_width and call
3536 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3537 all frames (Bug#8505).
3538 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3539 Call gtk_window_set_resizable if HAVE_GTK3.
3540 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3541 and height if HAVE_GTK3 (Bug#8505).
3542 (scroll_bar_width_for_theme): New variable.
3543 (update_theme_scrollbar_width): New function.
3544 (xg_get_default_scrollbar_width): Move code to
3545 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3546 (xg_initialize): Call update_theme_scrollbar_width.
3547
3548 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3549
3550 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3551
3552 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3553
3554 * frame.c (make_frame): Call other_buffer_safely instead of
3555 other_buffer.
3556
3557 * window.c (temp_output_buffer_show): Call display_buffer with
3558 second argument Vtemp_buffer_show_specifiers and reset latter
3559 immediately after the call.
3560 (Vtemp_buffer_show_specifiers): New variable.
3561 (auto_window_vscroll_p, next_screen_context_lines)
3562 (Vscroll_preserve_screen_position): Remove leading asterisks from
3563 doc-strings.
3564
3565 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 Fix minor problems found by GCC 4.6.0 static checking.
3568 * buffer.c (Qclone_number): Remove for now, as it's unused.
3569 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3570 (record_buffer): Remove unused local.
3571 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3572 (set_frame_buffer_list): Remove; unused.
3573 * frame.h (other_visible_frames): Remove decl.
3574 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3575 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3576 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3577 if HAVE_GPM.
3578 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3579 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3580 Define only if HAVE_GPM.
3581 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3582 (update_hints_inhibit): Remove; never set. All uses removed.
3583 * widgetprv.h (emacsFrameClassRec): Remove decl.
3584 * window.c (delete_deletable_window): Now returns void, since it
3585 wasn't returning anything.
3586 (compare_window_configurations): Remove unused locals.
3587 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3588 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3589 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3590 the same widths as pointers. This follows up on the 2011-05-06 patch.
3591 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3592 * xterm.h: Likewise.
3593 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3594
3595 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3596
3597 * makefile.w32-in: Update dependencies.
3598 (LISP_H): Add lib/intprops.h.
3599
3600 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3601
3602 * image.c (gif_load): Add animation frame delay to the metadata.
3603 (syms_of_image): Use DEFSYM. New symbol `delay'.
3604
3605 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3606
3607 * window.c (delete_deletable_window): Re-add.
3608 (Fset_window_configuration): Rewrite to handle dead buffers and
3609 consequently deletable windows.
3610 (window_tree, Fwindow_tree): Remove. Supply functionality in
3611 window.el.
3612 (compare_window_configurations): Simplify code.
3613
3614 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3615
3616 * image.c (imagemagick_load_image): Fix type mismatch.
3617 (Fimagemagick_types): Likewise.
3618
3619 * window.h (replace_buffer_in_windows): Declare.
3620
3621 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3622
3623 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3624 Qclone_number. Remove external declaration of Qdelete_window.
3625 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3626 code.
3627 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3628 Run Qbuffer_list_update_hook if allowed.
3629 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3630 buffer list implementation.
3631 (other_buffer_safely): New function.
3632 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3633 calls to replace_buffer_in_windows and
3634 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3635 if allowed.
3636 (record_buffer): Inhibit quitting and rewrite using quittable
3637 functions. Run Qbuffer_list_update_hook if allowed.
3638 (Frecord_buffer, Funrecord_buffer): New functions.
3639 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3640 Move switch-to-buffer to window.el.
3641 (bury-buffer): Move to window.el.
3642 (Vbuffer_list_update_hook): New variable.
3643
3644 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3645 section.
3646
3647 * window.h (resize_frame_windows): Move up in code.
3648 (Fwindow_frame): Remove EXFUN.
3649 (replace_buffer_in_all_windows): Remove prototype.
3650 (replace_buffer_in_windows_safely): Add prototype.
3651
3652 * window.c: Declare Qdelete_window static again. Move down
3653 declaration of select_count.
3654 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3655 (Fother_window): Move to window.el.
3656 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3657 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3658 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3659 window.el.
3660 (replace_buffer_in_windows): Implement by calling
3661 Qreplace_buffer_in_windows.
3662 (replace_buffer_in_all_windows): Remove with some functionality
3663 moved into replace_buffer_in_windows_safely.
3664 (replace_buffer_in_windows_safely): New function.
3665 (select_window_norecord, select_frame_norecord): Move in front
3666 of run_window_configuration_change_hook. Remove now obsolete
3667 declarations.
3668 (Fset_window_buffer): Rewrite doc-string.
3669 Call Qrecord_window_buffer.
3670 (keys_of_window): Move binding for other-window to window.el.
3671
3672 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3673
3674 * dispextern.h (struct image): Replace data member, whose int_val
3675 and ptr_val fields were not used by anything, with a single
3676 lisp_val object.
3677
3678 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3679 (gif_clear_image, gif_load, imagemagick_load_image)
3680 (gs_clear_image, gs_load): Callers changed.
3681
3682 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3683
3684 * buffer.h: Include <time.h>, for time_t.
3685 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3686
3687 Fix minor problems found by static checking.
3688
3689 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3690
3691 Make identifiers static if they are not used in other modules.
3692 * data.c (Qcompiled_function, Qframe, Qvector):
3693 * image.c (QimageMagick, Qsvg):
3694 * minibuf.c (Qmetadata):
3695 * window.c (resize_window_check, resize_root_window): Now static.
3696 * window.h (resize_window_check, resize_root_window): Remove decls.
3697
3698 * window.c (window_deletion_count, delete_deletable_window):
3699 Remove; unused.
3700 (window_body_lines): Now static.
3701 (Fdelete_other_windows_internal): Mark vars as initialized.
3702 Make sure 'resize_failed' is initialized.
3703 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3704 (resize_window_apply): Remove unused local.
3705 * window.h (delete_deletable_window): Remove decl.
3706
3707 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3708 (imagemagick_load_image): Fix pointer signedness problem by changing
3709 last arg from unsigned char * to char *. All uses changed.
3710 Also, fix a local for similar reasons.
3711 Remove unused locals. Remove locals to avoid shadowing.
3712 (fn_rsvg_handle_free): Remove; unused.
3713 (svg_load, svg_load_image): Fix pointer signedness problem.
3714 (imagemagick_load_image): Don't use garbage pointer image_wand.
3715
3716 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3717
3718 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3719
3720 * image.c (gif_load): Fix omitted cast error introduced by
3721 2011-06-06 change.
3722
3723 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3724
3725 * window.h (resize_proportionally, orig_total_lines)
3726 (orig_top_line): Remove from window structure.
3727 (set_window_height, set_window_width, change_window_heights)
3728 (Fdelete_window): Remove prototypes.
3729 (resize_frame_windows): Remove duplicate declaration.
3730
3731 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3732
3733 * window.h (resize_frame_windows, resize_window_check)
3734 (delete_deletable_window, resize_root_window)
3735 (resize_frame_windows): Declare prototypes.
3736
3737 * window.c (resize_window_apply): Make definition be "static" to
3738 match the prototype.
3739
3740 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3741
3742 * window.c: Remove declarations of Qwindow_size_fixed,
3743 window_min_size_1, window_min_size_2, window_min_size,
3744 size_window, window_fixed_size_p, enlarge_window, delete_window.
3745 Remove static from declaration of Qdelete_window, it's
3746 temporarily needed by Fbury_buffer.
3747 (replace_window): Don't assign orig_top_line and
3748 orig_total_lines.
3749 (Fdelete_window, delete_window): Remove. Window deletion is
3750 handled by window.el.
3751 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3752 Replace Fdelete_window calls with calls to Qdelete_window.
3753 (Fdelete_other_windows): Remove. Deleting other windows is
3754 handled by window.el.
3755 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3756 handled in window.el.
3757 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3758 Window minimum sizes are handled in window.el.
3759 (shrink_windows, size_window, set_window_height)
3760 (set_window_width, change_window_heights, window_height)
3761 (window_width, CURBEG, CURSIZE, enlarge_window)
3762 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3763 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3764 handled in window.el.
3765 (make_dummy_parent): Rename to make_parent_window and give it a
3766 second argument horflag.
3767 (make_window): Don't set resize_proportionally any more.
3768 (Fsplit_window): Remove. Windows are split in window.el.
3769 (save_restore_action, save_restore_orig_size)
3770 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3771 Resize mini windows in window.el.
3772 (grow_mini_window, shrink_mini_window): Implement by calling
3773 Qresize_root_window_vertically, resize_window_check and
3774 resize_window_apply.
3775 (saved_window, Fset_window_configuration, save_window_save):
3776 Do not handle orig_top_line, orig_total_lines, and
3777 resize_proportionally.
3778 (window_min_height, window_min_width): Move to window.el.
3779 (keys_of_window): Move bindings for delete-other-windows,
3780 split-window, delete-window and enlarge-window to window.el.
3781
3782 * buffer.c: Temporarily extern Qdelete_window.
3783 (Fbury_buffer): Temporarily call Qdelete_window instead of
3784 Fdelete_window (Fbury_buffer will move to window.el soon).
3785
3786 * frame.c (set_menu_bar_lines_1): Remove code handling
3787 orig_top_line and orig_total_lines.
3788
3789 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3790 set_window_height but set heights directly.
3791 (change_frame_size_1): Use resize_frame_windows.
3792
3793 * xdisp.c (init_xdisp): Don't use set_window_height but set
3794 heights directly.
3795
3796 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3797 Use resize_frame_windows instead of change_window_heights and run
3798 run_window_configuration_change_hook.
3799
3800 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3801 instead of change_window_heights and run
3802 run_window_configuration_change_hook.
3803
3804 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3805
3806 * window.c (replace_window): Rename second argument REPLACEMENT to
3807 NEW. New third argument SETFLAG. Rewrite.
3808 (delete_window, make_dummy_parent): Call replace_window with
3809 third argument 1.
3810 (window_list_1): Move down in code.
3811 (run_window_configuration_change_hook): Move set_buffer part
3812 before select_frame_norecord part in order to unwind correctly.
3813 Rename count1 to count.
3814 (recombine_windows, delete_deletable_window, resize_root_window)
3815 (Fdelete_other_windows_internal)
3816 (Frun_window_configuration_change_hook, make_parent_window)
3817 (resize_window_check, resize_window_apply, Fresize_window_apply)
3818 (resize_frame_windows, Fsplit_window_internal)
3819 (Fdelete_window_internal, Fresize_mini_window_internal):
3820 New functions.
3821 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3822
3823 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3824
3825 * window.h (window): Add some new members to window structure -
3826 normal_lines, normal_cols, new_total, new_normal, clone_number,
3827 splits, nest, prev_buffers, next_buffers.
3828 (WINDOW_TOTAL_SIZE): Move here from window.c.
3829 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3830
3831 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3832 Remove.
3833 (make_dummy_parent): Set new members of windows structure.
3834 (make_window): Move down in code. Handle new members of window
3835 structure.
3836 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3837 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3838 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3839 (Fset_window_prev_buffers, Fwindow_next_buffers)
3840 (Fset_window_next_buffers, Fset_window_clone_number):
3841 New functions.
3842 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3843 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3844 Doc-string fixes.
3845 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3846 Argument WINDOW can be now internal window too.
3847 (Fwindow_use_time): Move up in code.
3848 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3849 Rewrite doc-string.
3850 (Fset_window_configuration, saved_window)
3851 (Fcurrent_window_configuration, save_window_save): Handle new
3852 members of window structure.
3853 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3854 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3855 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3856 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3857 Qget_mru_window, Qresize_root_window,
3858 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3859 Qauto_buffer_name; staticpro them.
3860
3861 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3862
3863 * window.c (Fwindow_total_size, Fwindow_left_column)
3864 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3865 (Fwindow_list_1): New functions.
3866 (window_box_text_cols): Replace with window_body_cols.
3867 (Fwindow_width, Fscroll_left, Fscroll_right):
3868 Use window_body_cols instead of window_box_text_cols.
3869 (delete_window, Fset_window_configuration):
3870 Call delete_all_subwindows with window as argument.
3871 (delete_all_subwindows): Take a window as argument and not a
3872 structure. Rewrite.
3873 (window_loop): Remove handling of GET_LRU_WINDOW and
3874 GET_LARGEST_WINDOW.
3875 (Fget_lru_window, Fget_largest_window): Move to window.el.
3876
3877 * window.h: Extern window_body_cols instead of
3878 window_box_text_cols. delete_all_subwindows now takes a
3879 Lisp_Object as argument.
3880
3881 * indent.c (compute_motion, Fcompute_motion):
3882 Use window_body_cols instead of window_box_text_cols.
3883
3884 * frame.c (delete_frame): Call delete_all_subwindows with root
3885 window as argument.
3886
3887 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3888
3889 * fns.c (Fputhash): Document return value.
3890
3891 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3892
3893 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3894
3895 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 Cons<->int and similar integer overflow fixes (Bug#8794).
3898
3899 Check for overflow when converting integer to cons and back.
3900 * charset.c (Fdefine_charset_internal, Fdecode_char):
3901 Use cons_to_unsigned to catch overflow.
3902 (Fencode_char): Use INTEGER_TO_CONS.
3903 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3904 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3905 * data.c (long_to_cons, cons_to_long): Remove.
3906 (cons_to_unsigned, cons_to_signed): New functions.
3907 These signal an error for invalid or out-of-range values.
3908 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3909 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3910 * font.c (Ffont_variation_glyphs):
3911 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3912 * lisp.h: Include <intprops.h>.
3913 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3914 (cons_to_signed, cons_to_unsigned): New decls.
3915 (long_to_cons, cons_to_long): Remove decls.
3916 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3917 (Fprimitive_undo): Use CONS_TO_INTEGER.
3918 * xfns.c (Fx_window_property): Likewise.
3919 * xselect.c: Include <limits.h>.
3920 (x_own_selection, selection_data_to_lisp_data):
3921 Use INTEGER_TO_CONS.
3922 (x_handle_selection_request, x_handle_selection_clear)
3923 (x_get_foreign_selection, Fx_disown_selection_internal)
3924 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3925 (lisp_data_to_selection_data): Use cons_to_unsigned.
3926 (x_fill_property_data): Use cons_to_signed.
3927 Report values out of range.
3928
3929 Check for buffer and string overflow more precisely.
3930 * buffer.h (BUF_BYTES_MAX): New macro.
3931 * lisp.h (STRING_BYTES_MAX): New macro.
3932 * alloc.c (Fmake_string):
3933 * character.c (string_escape_byte8):
3934 * coding.c (coding_alloc_by_realloc):
3935 * doprnt.c (doprnt):
3936 * editfns.c (Fformat):
3937 * eval.c (verror):
3938 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3939 since they may not be the same number.
3940 * editfns.c (Finsert_char):
3941 * fileio.c (Finsert_file_contents):
3942 Likewise for BUF_BYTES_MAX.
3943
3944 * image.c: Use ptrdiff_t, not int, for sizes.
3945 (slurp_file): Switch from int to ptrdiff_t.
3946 All uses changed.
3947 (slurp_file): Check that file size fits in both size_t (for
3948 malloc) and ptrdiff_t (for sanity and safety).
3949
3950 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3951 if b->modtime has its maximal value.
3952
3953 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3954
3955 Don't assume time_t can fit into int.
3956 * buffer.h (struct buffer.modtime): Now time_t, not int.
3957 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3958 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3959
3960 Minor fixes for signed vs unsigned integers.
3961 * character.h (MAYBE_UNIFY_CHAR):
3962 * charset.c (maybe_unify_char):
3963 * keyboard.c (read_char, reorder_modifiers):
3964 XINT -> XFASTINT, since the integer must be nonnegative.
3965 * ftfont.c (ftfont_spec_pattern):
3966 * keymap.c (access_keymap, silly_event_symbol_error):
3967 XUINT -> XFASTINT, since the integer must be nonnegative.
3968 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3969 since it makes no difference and we prefer signed.
3970 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3971 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3972 nonnegative.
3973
3974 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3975
3976 * window.h (Fwindow_frame): Declare.
3977
3978 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3981 (SPARE_MEMORY): Always define.
3982 (LARGE_REQUEST): Remove.
3983 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3984
3985 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3986
3987 * lisp.h: Move EXFUNS for Fframe_root_window,
3988 Fframe_first_window and Fset_frame_selected_window to window.h.
3989
3990 * window.h: Move EXFUNS for Fframe_root_window,
3991 Fframe_first_window and Fset_frame_selected_window here from
3992 lisp.h.
3993
3994 * frame.c (Fwindow_frame, Fframe_first_window)
3995 (Fframe_root_window, Fframe_selected_window)
3996 (Fset_frame_selected_window): Move to window.c.
3997 (Factive_minibuffer_window): Move to minibuf.c.
3998 (Fother_visible_frames_p): New function.
3999
4000 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4001
4002 * window.c (decode_window, decode_any_window): Move up in code.
4003 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4004 (inhibit_frame_unsplittable): Remove unused variable.
4005 (Fwindow_buffer): Move up and rewrite doc-string.
4006 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4007 (Fwindow_prev): New functions.
4008 (Fwindow_frame): Move here from frame.c. Accept any window as
4009 argument.
4010 (Fframe_root_window, Fframe_first_window)
4011 (Fframe_selected_window): Move here from frame.c. Accept frame
4012 or arbitrary window as argument. Update doc-strings.
4013 (Fminibuffer_window): Move up in code.
4014 (Fwindow_minibuffer_p): Move up in code and simplify.
4015 (Fset_frame_selected_window): Move here from frame.c.
4016 Marginal rewrite.
4017 (Fselected_window, select_window, Fselect_window): Move up in
4018 code. Minor doc-string fixes.
4019
4020 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4023 Do not assume that spare memory exists; that assumption is valid
4024 only if SYSTEM_MALLOC.
4025 (LARGE_REQUEST): New macro, so that the issue of large requests
4026 is separated from the issue of spare memory.
4027
4028 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4029
4030 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4031 format. (Bug#8806)
4032
4033 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4034
4035 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4036 before statements.
4037
4038 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4039
4040 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4041
4042 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4043
4044 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4045 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4046
4047 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4048
4049 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4050
4051 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4052
4053 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4054 (x_clipboard_manager_save): Add return value.
4055 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4056 New error handlers.
4057 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4058 Obey Vx_select_enable_clipboard_manager. Catch errors in
4059 x_clipboard_manager_save (Bug#8779).
4060 (Vx_select_enable_clipboard_manager): New variable.
4061 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4062
4063 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4064
4065 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4066
4067 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4068
4069 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4070 in the current matrix if keep_current_p is non-zero.
4071
4072 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4073
4074 * bidi.c (bidi_level_of_next_char): Fix last change.
4075
4076 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4077
4078 Support bidi reordering of text covered by display properties.
4079
4080 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4081 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4082 (bidi_cache_search, bidi_cache_iterator_state)
4083 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4084 (bidi_level_of_next_char, bidi_move_to_visually_next):
4085 Support character positions inside a run of characters covered by a
4086 display string.
4087 (bidi_paragraph_init, bidi_resolve_explicit_1)
4088 (bidi_level_of_next_char): Call bidi_fetch_char and
4089 bidi_fetch_char_advance instead of FETCH_CHAR and
4090 FETCH_CHAR_ADVANCE.
4091 (bidi_init_it): Initialize new members.
4092 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4093 definitions.
4094 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4095 instead of using explicit *_CHAR codes.
4096 (bidi_resolve_explicit, bidi_resolve_weak):
4097 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4098 bidirectional text is supported only in multibyte buffers.
4099 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4100 it to initialize the frame_window_p member of struct bidi_it.
4101 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4102 (bidi_resolve_explicit, bidi_resolve_weak)
4103 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4104 bidi_it->nchars is non-positive.
4105 (bidi_level_of_next_char): Don't try to lookup the cache for the
4106 next/previous character if nothing is cached there yet, or if we
4107 were just reseat()'ed to a new position.
4108
4109 * xdisp.c (set_cursor_from_row): Set start and stop points
4110 according to the row's direction when priming the loop that looks
4111 for the glyph on which to display cursor.
4112 (single_display_spec_intangible_p): Function deleted.
4113 (display_prop_intangible_p): Reimplement to call
4114 handle_display_spec instead of single_display_spec_intangible_p.
4115 Accept 3 additional arguments needed by handle_display_spec.
4116 This fixes incorrect cursor motion across display property with complex
4117 values: lists, `(when COND...)' forms, etc.
4118 (single_display_spec_string_p): Support property values that are
4119 lists with the argument STRING its top-level element.
4120 (display_prop_string_p): Fix the condition for processing a
4121 property that is a list to be consistent with handle_display_spec.
4122 (handle_display_spec): New function, refactored from the
4123 last portion of handle_display_prop.
4124 (compute_display_string_pos): Accept additional argument
4125 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4126 value of a `display' property is a "replacing spec".
4127 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4128 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4129 the display property, but just return a value indicating whether
4130 the display property will replace the characters it covers.
4131 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4132 frame_window_p members of struct bidi_it.
4133 (compute_display_string_pos, compute_display_string_end):
4134 New functions.
4135 (push_it): Accept second argument POSITION, where pop_it should
4136 jump to continue iteration.
4137 (reseat_1): Initialize bidi_it.disp_pos.
4138
4139 * keyboard.c (adjust_point_for_property): Adjust the call to
4140 display_prop_intangible_p to its new signature.
4141
4142 * dispextern.h (struct bidi_it): New member frame_window_p.
4143 (bidi_init_it): Update prototypes.
4144 (display_prop_intangible_p): Update prototype.
4145 (compute_display_string_pos, compute_display_string_end):
4146 Declare prototypes.
4147 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4148 EMACS_INT.
4149
4150 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4151
4152 Malloc failure behavior now depends on size of allocation.
4153 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4154 * lisp.h: Change signatures accordingly.
4155 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4156 All callers changed. (Bug#8762)
4157
4158 * gnutls.c: Use Emacs's memory allocators.
4159 Without this change, the gnutls library would invoke malloc etc.
4160 directly, which causes problems on non-SYNC_INPUT hosts, and which
4161 runs afoul of improving memory_full behavior. (Bug#8761)
4162 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4163 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4164 xfree instead of the default malloc, realloc, free.
4165 (Fgnutls_boot): No need to check for memory allocation failure,
4166 since xmalloc does that for us.
4167
4168 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4169 * category.c (hash_get_category_set):
4170 * ccl.c (ccl_driver):
4171 * charset.c (Fdefine_charset_internal):
4172 * charset.h (struct charset.hash_index):
4173 * composite.c (get_composition_id, gstring_lookup_cache)
4174 (composition_gstring_put_cache):
4175 * composite.h (struct composition.hash_index):
4176 * dispextern.h (struct image.hash):
4177 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4178 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4179 (hashfn_equal, hashfn_user_defined, make_hash_table)
4180 (maybe_resize_hash_table, hash_lookup, hash_put)
4181 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4182 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4183 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4184 * image.c (make_image, search_image_cache, lookup_image)
4185 (xpm_put_color_table_h):
4186 * lisp.h (struct Lisp_Hash_Table):
4187 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4188 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4189 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4190 * alloc.c (allocate_vectorlike):
4191 Check for overflow in vector size calculations.
4192 * ccl.c (ccl_driver):
4193 Check for overflow when converting EMACS_INT to int.
4194 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4195 need to be updated by these changes.
4196 * fns.c (make_hash_table, maybe_resize_hash_table):
4197 Check for integer overflow with large hash tables.
4198 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4199 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4200 (SXHASH_REDUCE): New macro.
4201 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4202 Use it instead of discarding useful hash info with large hash values.
4203 (sxhash_float): New function.
4204 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4205 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4206 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4207 Rewrite to use FIXNUM_BITS, as this simplifies things.
4208 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4209 Adjust signatures to match updated version of code.
4210 (consing_since_gc): Now EMACS_INT, since a single hash table can
4211 use more than INT_MAX bytes.
4212
4213 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4214
4215 Make it possible to build with GCC-4.6+ -O2 -flto.
4216
4217 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4218
4219 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4220
4221 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4222 Call minibuffer-inactive-mode.
4223
4224 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4225
4226 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4227 Update dependencies.
4228
4229 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4230
4231 * data.c (init_data): Remove code for UTS, this system is not
4232 supported anymore.
4233
4234 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4235
4236 Don't force ./temacs to start in terminal mode.
4237
4238 * frame.c (make_initial_frame): Initialize faces in all cases, not
4239 only when CANNOT_DUMP is defined.
4240 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4241
4242 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4243
4244 * dispnew.c (add_window_display_history): Use const for the string
4245 pointer. Remove declaration, not needed.
4246
4247 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 Use 'inline', not 'INLINE'.
4250 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4251 * alloc.c, fontset.c (INLINE): Remove.
4252 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4253 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4254 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4255 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4256 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4257
4258 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4259
4260 Make it possible to run ./temacs.
4261
4262 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4263 syms_of_callproc does the same thing. Remove test for
4264 "initialized", do it in the caller.
4265 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4266
4267 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4268
4269 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4270 (read_minibuf): Use get_minibuffer.
4271 (syms_of_minibuf): Use DEFSYM.
4272 (Qmetadata): New var.
4273 * data.c (Qbuffer): Don't make it static.
4274 (syms_of_data): Use DEFSYM.
4275
4276 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4277
4278 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4279 (CCL_CODE_MIN): New macro.
4280
4281 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4282
4283 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4284
4285 * eval.c (Qdebug): Now static.
4286 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4287 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4288 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4289
4290 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4291
4292 * image.c: Various fixes to ImageMagick code comments.
4293 (Fimagemagick_types): Doc fix.
4294
4295 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4296
4297 Minor fixes prompted by GCC 4.6.0 warnings.
4298
4299 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4300
4301 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4302 (x_clipboard_manager_save_all): Move extern decl to ...
4303 * xterm.h: ... here, so that it can be checked for consistency.
4304
4305 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4306
4307 * xselect.c (x_clipboard_manager_save_frame)
4308 (x_clipboard_manager_save_all): New functions.
4309 (Fx_clipboard_manager_save): Lisp function deleted.
4310
4311 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4312 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4313
4314 * xterm.h: Update prototype.
4315
4316 2011-05-28 William Xu <william.xwl@gmail.com>
4317
4318 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4319 exiting (Bug#8239).
4320
4321 2011-05-28 Jim Meyering <meyering@redhat.com>
4322
4323 Avoid a sign-extension bug in crypto_hash_function.
4324 * fns.c (to_uchar): Define.
4325 (crypto_hash_function): Use it to convert some newly-signed
4326 variables to unsigned, to avoid sign-extension bugs. For example,
4327 without this change, (md5 "truc") would evaluate to
4328 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4329 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4330 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4331
4332 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 Integer overflow fixes.
4335
4336 * dbusbind.c: Serial number integer overflow fixes.
4337 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4338 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4339 to hold a serial number that is too large for a fixnum.
4340 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4341 Check for serial numbers out of range. Decode any serial number
4342 that was so large that it became a float. (Bug#8722)
4343
4344 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4345 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4346 Use XFASTINT rather than XUINT when numbers are nonnegative.
4347 (xd_append_arg, Fdbus_method_return_internal):
4348 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4349 arguments, check that Lisp number is nonnegative, rather than
4350 silently wrapping negative numbers around. (Bug#8722)
4351 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4352 (Bug#8722)
4353
4354 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4355
4356 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4357
4358 ccl: add integer overflow checks
4359 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4360 (IN_INT_RANGE): New macros.
4361 (ccl_driver): Use them to check for integer overflow when
4362 decoding a CCL program. Many of the new checks are whether XINT (x)
4363 fits in int; it doesn't always, on 64-bit hosts. The new version
4364 doesn't catch all possible integer overflows, but it's an
4365 improvement. (Bug#8719)
4366
4367 * alloc.c (make_event_array): Use XINT, not XUINT.
4368 There's no need for unsigned here.
4369
4370 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4371 This follows up to the 2011-05-06 change that substituted uintptr_t
4372 for EMACS_INT. This case wasn't caught back then.
4373
4374 Rework Fformat to avoid integer overflow issues.
4375 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4376 now (part of C89). Include <verify.h>.
4377 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4378 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4379 (Fformat): Avoid the prepass trying to compute sizes; it was only
4380 approximate and thus did not catch overflow reliably. Instead, walk
4381 through the format just once, formatting and computing sizes as we go,
4382 checking for integer overflow at every step, and allocating a larger
4383 buffer as needed. Keep track separately whether the format is
4384 multibyte. Keep only the most-recently calculated precision, rather
4385 than them all. Record whether each argument has been converted to
4386 string. Use EMACS_INT, not int, for byte and char and arg counts.
4387 Support field widths and precisions larger than INT_MAX. Avoid
4388 sprintf's undefined behavior with conversion specifications such as %#d
4389 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4390 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4391 formatting out-of-range floating point numbers with int
4392 formats. (Bug#8668)
4393
4394 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4395
4396 * data.c: Avoid integer truncation in expressions involving floats.
4397 * data.c: Include <intprops.h>.
4398 (arith_driver): When there's an integer overflow in an expression
4399 involving floating point, convert the integers to floating point
4400 so that the resulting value does not suffer from catastrophic
4401 integer truncation. For example, on a 64-bit host (* 4
4402 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4403 Do not rely on undefined behavior after integer overflow.
4404
4405 merge count_size_as_multibyte, parse_str_to_multibyte
4406 * character.c, character.h (count_size_as_multibyte):
4407 Rename from parse_str_to_multibyte; all uses changed.
4408 Check for integer overflow.
4409 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4410 since it's now a duplicate of the other. This is more of
4411 a character than a buffer op, so better that it's in character.c.
4412 * fns.c, print.c: Adjust to above changes.
4413
4414 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4415
4416 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4417
4418 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4419
4420 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4421 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4422 (x_clipboard_manager_save): Now static.
4423 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4424
4425 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4426 (crypto_hash_function): Now static.
4427 Fix pointer signedness problems. Avoid unnecessary initializations.
4428
4429 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4430
4431 * termhooks.h (Vselection_alist): Make it terminal-local.
4432
4433 * terminal.c (create_terminal): Initialize it.
4434
4435 * xselect.c: Support for clipboard managers.
4436 (Vselection_alist): Move to termhooks.h as terminal-local var.
4437 (LOCAL_SELECTION): New macro.
4438 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4439 (symbol_to_x_atom): Remove gratuitous arg.
4440 (x_handle_selection_request, lisp_data_to_selection_data)
4441 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4442 (x_own_selection, x_get_local_selection, x_convert_selection):
4443 New arg, specifying work frame. Use terminal-local Vselection_alist.
4444 (some_frame_on_display): Delete unused function.
4445 (Fx_own_selection_internal, Fx_get_selection_internal)
4446 (Fx_disown_selection_internal, Fx_selection_owner_p)
4447 (Fx_selection_exists_p): New optional frame arg.
4448 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4449 (x_handle_selection_clear): Don't treat other terminals with the
4450 same keyboard specially. Use the terminal-local Vselection_alist.
4451 (x_clear_frame_selections): Use Frun_hook_with_args.
4452
4453 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4454
4455 * xterm.h: Add support for those atoms.
4456
4457 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4458
4459 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4460 (converted_selections, conversion_fail_tag): New global variables.
4461 (x_selection_request_lisp_error): Free the above.
4462 (x_get_local_selection): Remove unnecessary code.
4463 (x_reply_selection_request): Args changed; handle arbitrary array
4464 of converted selections stored in converted_selections.
4465 Separate the XChangeProperty and SelectionNotify steps.
4466 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4467 (x_convert_selection): New function.
4468 (x_handle_selection_event): Simplify.
4469 (x_get_foreign_selection): Don't ignore incoming requests while
4470 waiting for an answer; this will fail when we implement
4471 SAVE_TARGETS, and seems unnecessary anyway.
4472 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4473 (Vx_sent_selection_functions): Doc fix.
4474
4475 2011-05-26 Leo Liu <sdl.web@gmail.com>
4476
4477 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4478
4479 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4480
4481 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4482
4483 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4484 for fringe update if it has periodic bitmap.
4485 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4486 and fringe_bitmap_periodic_p.
4487
4488 * fringe.c (get_fringe_bitmap_data): New function.
4489 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4490 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4491 row. Mark glyph row for fringe update if periodicity changed.
4492
4493 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4494 for fringe update unless it has periodic bitmap.
4495
4496 2011-05-25 Kenichi Handa <handa@m17n.org>
4497
4498 * xdisp.c (get_next_display_element): Set correct it->face_id for
4499 a static composition.
4500
4501 2011-05-24 Leo Liu <sdl.web@gmail.com>
4502
4503 * deps.mk (fns.o):
4504 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4505
4506 * fns.c (crypto_hash_function, Fsha1): New function.
4507 (Fmd5): Use crypto_hash_function.
4508 (syms_of_fns): Add Ssha1.
4509
4510 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4511
4512 * gnutls.c: Remove unused macros.
4513 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4514 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4515 Remove macros that are defined and never used.
4516 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4517
4518 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4519
4520 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4521 (Fx_get_selection_internal): Minor cleanup.
4522 (Fx_own_selection_internal): Rename arguments for consistency with
4523 select.el.
4524
4525 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4526
4527 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4528
4529 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4530
4531 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4532
4533 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4534
4535 * dispnew.c (scrolling_window): Don't exclude the case that the
4536 last enabled row in the desired matrix touches the bottom boundary.
4537
4538 2011-05-21 Glenn Morris <rgm@gnu.org>
4539
4540 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4541 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4542 and add some more files.
4543
4544 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4545
4546 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4547 report_file_error introduced by the change from 2011-05-07.
4548
4549 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4550
4551 * systime.h (Time): Define only if emacs is defined.
4552 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4553 where the include path doesn't have X11/X.h by default. See
4554 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4555
4556 2011-05-20 Kenichi Handa <handa@m17n.org>
4557
4558 * composite.c (find_automatic_composition): Fix previous change.
4559
4560 2011-05-20 Glenn Morris <rgm@gnu.org>
4561
4562 * lisp.mk: New file, split from Makefile.in.
4563 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4564 (shortlisp): Remove.
4565 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4566
4567 2011-05-19 Glenn Morris <rgm@gnu.org>
4568
4569 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4570 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4571 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4572 (lisp): Set the order to that of loadup.el.
4573 (shortlisp): Make it a copy of $lisp.
4574 (SOME_MACHINE_LISP): Remove.
4575 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4576 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4577
4578 2011-05-18 Kenichi Handa <handa@m17n.org>
4579
4580 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4581 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4582 (find_automatic_composition): Mostly rewrite for efficiency.
4583
4584 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4585
4586 * makefile.w32-in: Update dependencies.
4587
4588 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4589
4590 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4591 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4592
4593 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4594
4595 Fix some integer overflow issues, such as string length overflow.
4596
4597 * insdel.c (count_size_as_multibyte): Check for string overflow.
4598
4599 * character.c (lisp_string_width): Check for string overflow.
4600 Use EMACS_INT, not int, for string indexes and lengths; in
4601 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4602 the resulting string length overflows an EMACS_INT; instead,
4603 report a string overflow if no precision given. When checking for
4604 precision exhaustion, use a check that cannot possibly have
4605 integer overflow. (Bug#8675)
4606 * character.h (lisp_string_width): Adjust to new signature.
4607
4608 * alloc.c (string_overflow): New function.
4609 (Fmake_string): Use it. This doesn't change behavior, but saves
4610 a few bytes and will simplify future changes.
4611 * character.c (string_escape_byte8): Likewise.
4612 * lisp.h (string_overflow): New decl.
4613
4614 Fixups, following up to the user-interface timestamp change.
4615 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4616 for UI timestamps, instead of unsigned long.
4617 * msdos.c (mouse_get_pos): Likewise.
4618 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4619 * w32gui.h (Time): Define by including "systime.h" rather than by
4620 declaring it ourselves. (Bug#8664)
4621
4622 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4623 * image.c (clear_image_cache): Likewise.
4624
4625 * term.c (term_mouse_position): Don't assume time_t wraparound.
4626
4627 Be more systematic about user-interface timestamps.
4628 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4629 and sometimes 'EMACS_UINT', to represent these timestamps.
4630 This change causes it to use 'Time' uniformly, as that's what X uses.
4631 This makes the code easier to follow, and makes it easier to catch
4632 integer overflow bugs such as Bug#8664.
4633 * frame.c (Fmouse_position, Fmouse_pixel_position):
4634 Use Time, not unsigned long, for user-interface timestamps.
4635 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4636 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4637 * keyboard.h (last_event_timestamp): Likewise.
4638 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4639 * menu.h (xmenu_show): Likewise.
4640 * term.c (term_mouse_position): Likewise.
4641 * termhooks.h (struct input_event.timestamp): Likewise.
4642 (struct terminal.mouse_position_hook): Likewise.
4643 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4644 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4645 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4646 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4647 what it was before.
4648 * menu.h, termhooks.h: Include "systime.h", for Time.
4649
4650 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4651 Don't assume that the difference between two unsigned long values
4652 can fit into an integer. At this point, we know button_down_time
4653 <= event->timestamp, so the difference must be nonnegative, so
4654 there's no need to cast the result if double-click-time is
4655 nonnegative, as it should be; check that it's nonnegative, just in
4656 case. This bug is triggered when events are more than 2**31 ms
4657 apart (about 25 days). (Bug#8664)
4658
4659 * xselect.c (last_event_timestamp): Remove duplicate decl.
4660 (x_own_selection): Remove needless cast to unsigned long.
4661
4662 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4663 that always fit in int. Use a sentinel instead of a counter, to
4664 avoid a temp and to allay GCC's concerns about possible int overflow.
4665 * frame.h (struct frame): Use int for menu_bar_items_used
4666 instead of EMACS_INT, since it always fits in int.
4667
4668 * menu.c (grow_menu_items): Check for int overflow.
4669
4670 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4671
4672 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4673 Before, the code was not consistent. These values cannot exceed
4674 2**31 - 1 so there's no need to make them unsigned.
4675 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4676 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4677 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4678 as modifiers.
4679 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4680
4681 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4682 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4683 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4684 presumably because the widths might not match.
4685
4686 * window.c (size_window): Avoid needless test at loop start.
4687
4688 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4689
4690 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4691
4692 2011-05-12 Drew Adams <drew.adams@oracle.com>
4693
4694 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4695
4696 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4697
4698 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4699 `width' to `bar_area_x' and `bar_area_width', respectively.
4700 (x_scroll_run): Take account of fringe background extension.
4701
4702 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4703 Rename local vars `left' and `width' to `bar_area_x' and
4704 `bar_area_width', respectively.
4705 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4706 background extension.
4707
4708 2011-05-10 Jim Meyering <meyering@redhat.com>
4709
4710 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4711
4712 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4713
4714 * image.c (Finit_image_library): Return t for built-in image types,
4715 like pbm and xbm. (Bug#8640)
4716
4717 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4718
4719 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4720
4721 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4722
4723 * w32console.c (Fset_screen_color): Doc fix.
4724 (Fget_screen_color): New function.
4725 (syms_of_ntterm): Defsubr it.
4726
4727 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4728 unlink the temporary file if Fcall_process didn't create it in the
4729 first place.
4730 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4731 child process will be redirected to a file specified with `:file'.
4732 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4733 cue to call_process_cleanup not to close that handle.
4734
4735 2011-05-07 Ben Key <bkey76@gmail.com>
4736
4737 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4738 one of two shell specific rules, either bootstrap-temacs-CMD or
4739 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4740 to the previous implementation of the bootstrap-temacs rule.
4741 The bootstrap-temacs-CMD rule is similar to the previous
4742 implementation of the bootstrap-temacs rule except that it
4743 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4744 variable.
4745
4746 These changes, along with some changes to nt/configure.bat,
4747 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4748 earlier fix to add support for --cflags and --ldflags options
4749 that include quotes so that it works whether make uses cmd or
4750 sh as the shell.
4751
4752 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4753
4754 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4755 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4756 is a constant.
4757 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4758 a string. Handle both cases.
4759 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4760 (Fdbus_register_method): Use Qinvalid_function.
4761
4762 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4763
4764 * makefile.w32-in: Update dependencies.
4765 (LISP_H): Add inttypes.h and stdin.h.
4766 (PROCESS_H): Add unistd.h.
4767
4768 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4769
4770 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4771 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4772
4773 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4774
4775 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4776
4777 * term.c (vfatal): Remove stray call to va_end.
4778 It's not needed and the C Standard doesn't allow it here anyway.
4779
4780 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4781 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4782
4783 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4784 bytes.
4785
4786 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4787
4788 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4789
4790 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4791
4792 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4793
4794 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4795
4796 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4797 * charset.c (Fdefine_charset_internal): Don't initialize
4798 charset.code_space[15]. The value was garbage, on hosts with
4799 32-bit int (Bug#8600).
4800
4801 * lread.c (read_integer): Be more consistent with string-to-number.
4802 Use string_to_number to do the actual conversion; this avoids
4803 rounding errors and fixes some other screwups. Without this fix,
4804 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4805 (digit_to_number): Move earlier, for benefit of read_integer.
4806 Return -1 if the digit is out of range for the base, -2 if it is
4807 not a digit in any supported base. (Bug#8602)
4808
4809 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4810
4811 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4812 to match comment at start of function. This also removes a
4813 GCC warning about overflow in a 32+64-bit port.
4814
4815 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4816
4817 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4818 Reported by Stefan Monnier in
4819 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4820 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4821 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4822
4823 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4824 (EMACS_UINTPTR): Likewise, with uintptr_t.
4825
4826 * lisp.h: Prefer 64-bit EMACS_INT if available.
4827 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4828 on 32-bit hosts that have 64-bit int, so that they can access
4829 large files.
4830 However, temporarily disable this change unless the temporary
4831 symbol WIDE_EMACS_INT is defined.
4832
4833 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4834
4835 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4836 This removes an assumption that EMACS_INT and long are the same
4837 width as pointers. The assumption is true for Emacs porting targets
4838 now, but we want to make other targets possible.
4839 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4840 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4841 In the rest of the code, change types of integers that hold casted
4842 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4843 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4844 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4845 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4846 No need to cast type when ORing.
4847 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4848 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4849 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4850 assume EMACS_INT is the same width as char *.
4851 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4852 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4853 Remove no-longer-needed casts.
4854 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4855 (xg_tool_bar_help_callback, xg_make_tool_item):
4856 Use EMACS_INTPTR to hold an integer
4857 that will be cast to void *; this can avoid a GCC warning
4858 if EMACS_INT is not the same width as void *.
4859 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4860 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4861 (current_message_1, set_message_1):
4862 Use a local to convert to proper width without a cast.
4863 * xmenu.c (dialog_selection_callback): Likewise.
4864
4865 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4866 Also, don't assume VALBITS / RAND_BITS is less than 5,
4867 and don't rely on undefined behavior when shifting a 1 left into
4868 the sign bit.
4869 * lisp.h (get_random): Change signature to match.
4870
4871 * lread.c (hash_string): Use size_t, not int, for hash computation.
4872 Normally we prefer signed values; but hashing is special, because
4873 it's better to use unsigned division on hash table sizes so that
4874 the remainder is nonnegative. Also, size_t is the natural width
4875 for hashing into memory. The previous code used 'int', which doesn't
4876 retain enough info to hash well into very large tables.
4877 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4878
4879 * dbusbind.c: Don't possibly lose pointer info when converting.
4880 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4881 Use XPNTR rather than XHASH, so that the high-order bits of
4882 the pointer aren't lost when converting through void *.
4883
4884 * eval.c (Fautoload): Don't double-shift a pointer.
4885
4886 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4887
4888 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4889
4890 * gnutls.c (DEF_GNUTLS_FN):
4891 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4892
4893 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4894
4895 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4896 marker. (Bug#8610)
4897
4898 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4899
4900 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4901 New version that can reserve upto 2GB of heap space.
4902
4903 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4904
4905 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4906
4907 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4908
4909 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4910 `gnutls_certificate_set_x509_key_file'.
4911
4912 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4913
4914 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4915 Update dependencies.
4916
4917 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4918
4919 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4920 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4921 Remove unused parameter `fildes'.
4922 * process.c (read_process_output, send_process): Don't pass it.
4923
4924 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4925
4926 Fix previous change: the library cache is defined in w32.c.
4927 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4928 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4929
4930 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4931
4932 Implement dynamic loading of GnuTLS on Windows.
4933
4934 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4935 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4936 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4937 Declare.
4938
4939 * gnutls.c (Qgnutls_dll): Define.
4940 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4941 (gnutls_*): Declare function pointers.
4942 (init_gnutls_functions): New function to initialize function pointers.
4943 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4944 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4945 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4946 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4947 (emacs_gnutls_write, emacs_gnutls_read)
4948 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4949 (Fgnutls_available_p): New function.
4950 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4951 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4952 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4953
4954 * image.c: Include w32.h.
4955 (Vimage_type_cache): Delete.
4956 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4957 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4958 (w32_delayed_load): Move to w32.c.
4959
4960 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4961
4962 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4963 (w32_delayed_load): Move from image.c. When loading a library, record
4964 its filename in the :loaded-from property of the library id.
4965 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4966 Initialize and staticpro them.
4967 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4968
4969 * process.c: Include lisp.h before w32.h, not after.
4970 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4971 instead of gnutls_record_check_pending.
4972
4973 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4974
4975 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4976
4977 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4978 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4979 as passed in.
4980
4981 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4982
4983 * xterm.c (x_set_frame_alpha): Do not set property on anything
4984 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4985
4986 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4987
4988 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4989
4990 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4991
4992 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4993 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4994 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4995 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4996 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4997 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4998 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4999 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5000 (Qgnutls_bootprop_callbacks_verify): Make static.
5001
5002 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5003
5004 * callproc.c: Indentation fixup.
5005
5006 * sysdep.c (wait_for_termination_1): Make static.
5007 (wait_for_termination, interruptible_wait_for_termination):
5008 Move after wait_for_termination_1.
5009
5010 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5011
5012 * sysdep.c (interruptible_wait_for_termination): New function
5013 which is like wait_for_termination, but allows keyboard
5014 interruptions.
5015
5016 * callproc.c (Fcall_process): Add (:file "file") as an option for
5017 the STDOUT buffer.
5018 (Fcall_process_region): Ditto.
5019
5020 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5021
5022 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5023 rather than `XVECTOR (FOO)->size'.
5024
5025 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5026 inttypes.h, as a gnulib replacement is used if it not available in
5027 system headers.
5028
5029 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5030
5031 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5032 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5033 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5034
5035 * coding.c (coding_alloc_by_realloc): Error out if destination
5036 will grow beyond MOST_POSITIVE_FIXNUM.
5037 (decode_coding_emacs_mule): Abort if there isn't enough place in
5038 charbuf for the composition carryover bytes. Reserve an extra
5039 space for up to 2 characters produced in a loop.
5040 (decode_coding_iso_2022): Abort if there isn't enough place in
5041 charbuf for the composition carryover bytes.
5042
5043 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5044
5045 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5046 aborting when %lld or %lll format is passed.
5047 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5048 %llo or %llx format is passed. (Bug#8545)
5049
5050 * window.c (window_scroll_line_based): Use a marker instead of
5051 simple variables to record original value of point. (Bug#7952)
5052
5053 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5054 produced by %s or %c overflows available buffer space. (Bug#8545)
5055
5056 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5057
5058 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5059 (SIZE_MAX): Move defn after all includes, as they might #define it.
5060
5061 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5062
5063 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5064
5065 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5066
5067 * keyboard.c (Qdelayed_warnings_hook): Define.
5068 (command_loop_1): Run `delayed-warnings-hook'
5069 if Vdelayed_warnings_list is non-nil.
5070 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5071 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5072
5073 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5074
5075 * doprnt.c (doprnt): Don't return value smaller than the buffer
5076 size if the message was truncated. (Bug#8545).
5077
5078 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5079
5080 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5081 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5082
5083 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5084
5085 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5086
5087 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5088
5089 * makefile.w32-in: Update dependencies.
5090
5091 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5092
5093 Improve `doprnt' and its usage. (Bug#8545)
5094 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5095 `format_end'. Remove support for %l as a conversion specifier.
5096 Don't use xrealloc. Improve diagnostics when the %l size modifier
5097 is used. Update the commentary.
5098
5099 * eval.c (verror): Simplify calculation of size_t.
5100
5101 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5102 messages.
5103
5104 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5105
5106 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5107 change.
5108
5109 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5110
5111 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5112 This makes this file independent of the recent pseudovector change.
5113
5114 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5115
5116 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5117
5118 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5119 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5120 Remove unused local.
5121 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5122
5123 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5124 GCC 4.6.0 optimizes based on type-based alias analysis.
5125 For example, if b is of type struct buffer * and v of type struct
5126 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5127 != &v->size, and therefore "v->size = 1; b->size = 2; return
5128 v->size;" must therefore return 1. This assumption is incorrect
5129 for Emacs, since it type-puns struct Lisp_Vector * with many other
5130 types. To fix this problem, this patch adds a new type struct
5131 vectorlike_header that documents the constraints on layout of vectors
5132 and pseudovectors, and helps optimizing compilers not get fooled
5133 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5134 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5135 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5136 the size member.
5137 (XSETPVECTYPE): Rewrite in terms of new macro.
5138 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5139 This is a bit clearer, and further avoids the possibility of
5140 undesirable aliasing.
5141 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5142 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5143 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5144 since Lisp_Subr is a special case (no "next" field).
5145 (ASIZE): Now uses header.size rather than size.
5146 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5147 to avoid the hassle of writing XVECTOR (foo)->header.size.
5148 (struct vectorlike_header): New type.
5149 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5150 object, to help avoid aliasing.
5151 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5152 (SUBRP): Likewise, since Lisp_Subr is a special case.
5153 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5154 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5155 (struct Lisp_Hash_Table): Combine first two members into a single
5156 struct vectorlike_header member. All uses of "size" and "next" members
5157 changed to be "header.size" and "header.next".
5158 * buffer.h (struct buffer): Likewise.
5159 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5160 * frame.h (struct frame): Likewise.
5161 * process.h (struct Lisp_Process): Likewise.
5162 * termhooks.h (struct terminal): Likewise.
5163 * window.c (struct save_window_data, struct saved_window): Likewise.
5164 * window.h (struct window): Likewise.
5165 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5166 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5167 * buffer.c (init_buffer_once): Likewise.
5168 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5169 special case.
5170 * process.c (Fformat_network_address): Use local var for size,
5171 for brevity.
5172
5173 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5174
5175 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5176 * data.c (atof): Remove decl; no longer used or needed.
5177 (digit_to_number): Move to lread.c.
5178 (Fstring_to_number): Use new string_to_number function, to be
5179 consistent with how the Lisp reader treats infinities and NaNs.
5180 Do not assume that floating-point numbers represent EMACS_INT
5181 without losing information; this is not true on most 64-bit hosts.
5182 Avoid double-rounding errors, by insisting on integers when
5183 parsing non-base-10 numbers, as the documentation specifies.
5184 * lisp.h (string_to_number): New decl, replacing ...
5185 (isfloat_string): Remove.
5186 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5187 (read1): Do not accept +. and -. as integers; this
5188 appears to have been a coding error. Similarly, do not accept
5189 strings like +-1e0 as floating point numbers. Do not report
5190 overflow for integer overflows unless the base is not 10 which
5191 means we have no simple and reliable way to continue.
5192 Break out the floating-point parsing into a new
5193 function string_to_number, so that Fstring_to_number parses
5194 floating point numbers consistently with the Lisp reader.
5195 (digit_to_number): Move here from data.c. Make it static inline.
5196 (E_CHAR, EXP_INT): Remove, replacing with ...
5197 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5198 (string_to_number): New function, replacing isfloat_string.
5199 This function checks for valid syntax and produces the resulting
5200 Lisp float number too. Rework it so that string-to-number
5201 no longer mishandles examples like "1.0e+". Use strtoumax,
5202 so that overflow for non-base-10 numbers is reported only when
5203 there's no portable and simple way to convert to floating point.
5204
5205 * textprop.c (set_text_properties_1): Rewrite for clarity,
5206 and to avoid GCC warning about integer overflow.
5207
5208 * intervals.h (struct interval): Use EMACS_INT for members
5209 where EMACS_UINT might cause problems. See
5210 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5211 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5212 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5213 All uses changed.
5214 (offset_intervals): Tell GCC not to worry about length overflow
5215 when negating a negative length.
5216
5217 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5218 (overrun_check_free): Likewise.
5219
5220 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5221 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5222 word size.
5223
5224 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5225 (gnutls_make_error): Rename local to avoid shadowing.
5226 (gnutls_emacs_global_deinit): ifdef out; not used.
5227 (Fgnutls_boot): Use const for pointer to readonly storage.
5228 Comment out unused local. Fix pointer signedness problems.
5229
5230 * lread.c (openp): Don't stuff size_t into an 'int'.
5231 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5232 about possible signed overflow.
5233
5234 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5235 (GDK_KEY_g): Don't define if already defined.
5236 (xg_prepare_tooltip): Avoid pointer signedness problem.
5237 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5238
5239 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5240 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5241
5242 * xfns.c (Fx_window_property): Simplify a bit,
5243 to make a bit faster and to avoid GCC 4.6.0 warning.
5244 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5245
5246 * fns.c (internal_equal): Don't assume size_t fits in int.
5247
5248 * alloc.c (compact_small_strings): Tighten assertion a little.
5249
5250 Replace pEd with more-general pI, and fix some printf arg casts.
5251 * lisp.h (pI): New macro, generalizing old pEd macro to other
5252 conversion specifiers. For example, use "...%"pI"d..." rather
5253 than "...%"pEd"...".
5254 (pEd): Remove. All uses replaced with similar uses of pI.
5255 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5256 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5257 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5258 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5259 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5260 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5261 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5262 64-bit hosts.
5263 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5264 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5265 * print.c (safe_debug_print, print_object): Likewise.
5266 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5267 to int.
5268 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5269 avoiding the 0 flag, which is not portable.
5270 * process.c (Fmake_network_process): Use pI to avoid cast.
5271 * region-cache.c (pp_cache): Likewise.
5272 * xdisp.c (decode_mode_spec): Likewise.
5273 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5274 behavior on 64-bit hosts with printf arg.
5275 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5276 (x_stop_queuing_selection_requests): Likewise.
5277 (x_get_window_property): Don't truncate byte count to an 'int'
5278 when tracing.
5279
5280 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5281 here, since it parses constructs like leading '-' and spaces,
5282 which are not wanted; and it overflows with large numbers.
5283 Instead, simply match F[0-9]+, which is what is wanted anyway.
5284
5285 * alloc.c: Remove unportable assumptions about struct layout.
5286 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5287 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5288 (allocate_vectorlike, make_pure_vector): Use the new macros,
5289 plus offsetof, to remove unportable assumptions about struct layout.
5290 These assumptions hold on all porting targets that I know of, but
5291 they are not guaranteed, they're easy to remove, and removing them
5292 makes further changes easier.
5293
5294 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5295 This doesn't fix a bug but makes the code clearer.
5296 (string_overrun_cookie): Now const. Use initializers that
5297 don't formally overflow signed char, to avoid warnings.
5298 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5299 can cause Emacs to crash when string overrun checking is enabled.
5300 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5301 multiple of sizeof (EMACS_INT); it need not be, if
5302 alignof(EMACS_INT) < sizeof (EMACS_INT).
5303 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5304
5305 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5306
5307 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5308
5309 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5310
5311 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5312 supposed to be handshaking. (Bug#8556)
5313 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5314
5315 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5316
5317 * lisp.h (Qdebug): List symbol.
5318 * eval.c (Qdebug): Restore global linkage.
5319 * keyboard.c (debug-on-event): New variable.
5320 (handle_user_signal): Break into debugger when debug-on-event
5321 matches the current signal symbol.
5322
5323 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5324
5325 * alloc.c (check_sblock, check_string_bytes)
5326 (check_string_free_list): Convert to standard C.
5327
5328 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5329
5330 * w32.c (emacs_gnutls_push): Fix typo.
5331
5332 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5333
5334 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5335 "cast to pointer from integer of different size".
5336
5337 Improve doprnt and its use in verror. (Bug#8545)
5338 * doprnt.c (doprnt): Document the set of format control sequences
5339 supported by the function. Use SAFE_ALLOCA instead of always
5340 using `alloca'.
5341
5342 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5343 is one byte too soon. Don't use xrealloc; instead xfree and
5344 xmalloc anew.
5345
5346 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5347
5348 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5349 callbacks stage.
5350
5351 * gnutls.c: Renamed global_initialized to
5352 gnutls_global_initialized. Added internals for the
5353 :verify-hostname-error, :verify-error, and :verify-flags
5354 parameters of `gnutls-boot' and documented those parameters in the
5355 docstring. Start callback support.
5356 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5357 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5358 on error. Return error code.
5359 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5360 (emacs_gnutls_read): Likewise.
5361 (Fgnutls_boot): Return handshake error code.
5362 (emacs_gnutls_handle_error): New function.
5363 (wsaerror_to_errno): Likewise.
5364
5365 * w32.h (emacs_gnutls_pull): Add prototype.
5366 (emacs_gnutls_push): Likewise.
5367
5368 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5369 (emacs_gnutls_push): Likewise.
5370
5371 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5372
5373 * process.c (wait_reading_process_output): Check if GnuTLS
5374 buffered some data internally if no FDs are set for TLS
5375 connections.
5376
5377 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5378 (LIBS): Link to USER_LIBS.
5379 ($(BLD)/gnutls.$(0)): New target.
5380
5381 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5382
5383 * xdisp.c (handle_single_display_spec): Rename the
5384 display_replaced_before_p argument into display_replaced_p, to
5385 make it consistent with the commentary. Fix typos in the
5386 commentary.
5387
5388 * textprop.c (syms_of_textprop): Remove dead code.
5389 (copy_text_properties): Delete obsolete commentary about an
5390 interface that was deleted long ago. Fix typos in the description
5391 of arguments.
5392
5393 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5394 to changes in oldXMenu/XMenu.h from 2011-04-16.
5395 <menu_help_message, prev_menu_help_message>: Constify.
5396 (IT_menu_make_room): menu->help_text is now `const char **';
5397 adjust.
5398
5399 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5400 to changes in oldXMenu/XMenu.h from 2011-04-16.
5401 (struct XMenu): Declare `help_text' `const char **'.
5402
5403 * xfaces.c <Qunspecified>: Make extern again.
5404
5405 * syntax.c: Include sys/types.h before including regex.h, as
5406 required by Posix.
5407
5408 * doc.c (get_doc_string): Improve the format passed to `error'.
5409
5410 * doprnt.c (doprnt): Improve commentary.
5411
5412 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5413
5414 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5415 them with etags.
5416
5417 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5418 changes in globals.h immediately force recompilation.
5419 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5420 $(CURDIR)/s/ms-w32.h.
5421 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5422
5423 * character.c (Fchar_direction): Function deleted.
5424 (syms_of_character): Don't defsubr it.
5425 <char-direction-table>: Deleted.
5426
5427 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5428
5429 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5430 * doprnt.c: Include limits.h.
5431 (SIZE_MAX): New macro.
5432 (doprnt): Return a size_t value. 2nd arg is now size_t.
5433 Many local variables are now size_t instead of int or unsigned.
5434 Improve overflow protection. Support `l' modifier for integer
5435 conversions. Support %l conversion. Don't assume an EMACS_INT
5436 argument for integer conversions and for %c.
5437
5438 * lisp.h (doprnt): Restore prototype.
5439
5440 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5441 $(SRC)/character.h.
5442
5443 * Makefile.in (base_obj): Add back doprnt.o.
5444
5445 * deps.mk (doprnt.o): Add back prerequisites.
5446 (callint.o): Depend on character.h.
5447
5448 * eval.c (internal_lisp_condition_case): Include the handler
5449 representation in the error message.
5450 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5451 when breaking from the loop.
5452
5453 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5454
5455 * callint.c (Fcall_interactively): When displaying error message
5456 about invalid control letter, pass the character's codepoint, not
5457 a pointer to its multibyte form. Improve display of the character
5458 in octal and display also its hex code.
5459
5460 * character.c (char_string): Use %x to display the (unsigned)
5461 codepoint of an invalid character, to avoid displaying a bogus
5462 negative value.
5463
5464 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5465 `error', not SYMBOL_NAME itself.
5466
5467 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5468 character arguments to `error'.
5469
5470 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5471 to `error' in error message about FINAL_CHAR argument. Make sure
5472 FINAL_CHAR is a character, and use %c when it is passed as
5473 argument to `error'.
5474
5475 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5476
5477 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5478
5479 * w32.c: Include <time.h>.
5480 (sys_localtime): New function.
5481
5482 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5483
5484 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5485
5486 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5487
5488 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5489
5490 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5491 zombies (Bug#8467).
5492
5493 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5494
5495 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5496 gl_state.e_property when gl_state.object is Qt.
5497
5498 * insdel.c (make_gap_larger): Remove limitation of buffer size
5499 to <= INT_MAX.
5500
5501 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5502
5503 * xdisp.c (lookup_glyphless_char_display)
5504 (produce_glyphless_glyph): Handle cons cell entry in
5505 glyphless-char-display.
5506 (Vglyphless_char_display): Document it.
5507
5508 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5509 glyphless-char-display.
5510
5511 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5512
5513 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5514
5515 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5516
5517 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5518 definition for no-X builds.
5519
5520 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5521
5522 Static checks with GCC 4.6.0 and non-default toolkits.
5523
5524 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5525
5526 * process.c (keyboard_bit_set): Define only if SIGIO.
5527 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5528 (send_process): Repair possible setjmp clobbering.
5529
5530 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5531
5532 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5533
5534 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5535
5536 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5537 Define only if needed.
5538
5539 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5540 by pacifying GCC about it. Maybe it's time to retire it?
5541 * xfaces.c (USG, __TIMEVAL__): Likewise.
5542
5543 * dispextern.h (struct redisplay_interface): Rename param
5544 to avoid shadowing.
5545 * termhooks.h (struct terminal): Likewise.
5546 * xterm.c (xembed_send_message): Likewise.
5547
5548 * insdel.c (make_gap_smaller): Define only if
5549 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5550
5551 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5552 it.
5553
5554 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5555 so that we aren't warned about unused symbols.
5556
5557 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5558
5559 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5560
5561 * xfns.c (x_real_positions): Mark locals as initialized.
5562
5563 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5564
5565 * xterm.c: Fix problems found by static analysis with other toolkits.
5566 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5567 (x_dispatch_event): Declare static if USE_GTK, and
5568 define if USE_GTK || USE_X_TOOLKIT.
5569 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5570 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5571 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5572 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5573
5574 * xmenu.c (menu_help_callback): Pointer type fixes.
5575 Use const pointers when pointing at readonly data. Avoid pointer
5576 signedness clashes.
5577 (FALSE): Remove unused macro.
5578 (update_frame_menubar): Remove unused decl.
5579
5580 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5581
5582 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5583 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5584 (single_menu_item): Rename local to avoid shadowing.
5585
5586 * keyboard.c (make_lispy_event): Remove unused local var.
5587
5588 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5589 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5590
5591 * bitmaps: Change bitmaps from unsigned char back to the X11
5592 compatible char. Avoid the old compiler warnings about
5593 out-of-range initializers by using, for example, '\xab' rather
5594 than 0xab.
5595
5596 * xgselect.c (xgselect_initialize): Check vs interface
5597 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5598
5599 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5600
5601 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5602 to read-only memory.
5603
5604 * fns.c (vector): Remove; this old hack is no longer needed.
5605
5606 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5607 Remove unused var.
5608 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5609
5610 * xrdb.c (x_load_resources): Omit unused local.
5611
5612 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5613 (x_window): Rename locals to avoid shadowing.
5614 (USG): Use the kludged USG macro, to pacify gcc.
5615
5616 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5617 (x_term_init): Remove local to avoid shadowing.
5618
5619 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5620
5621 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5622 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5623
5624 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5625
5626 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5627
5628 Fix regex.c, syntax.c and friends for buffers > 2GB.
5629 * syntax.h (struct gl_state_s): Declare character position members
5630 EMACS_INT.
5631
5632 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5633
5634 * textprop.c (verify_interval_modification, interval_of):
5635 Declare arguments EMACS_INT.
5636
5637 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5638 EMACS_INT.
5639
5640 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5641
5642 * indent.c (Fvertical_motion): Local variable it_start is now
5643 EMACS_INT.
5644
5645 * regex.c (re_match, re_match_2, re_match_2_internal)
5646 (bcmp_translate, regcomp, regexec, print_double_string)
5647 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5648 (re_compile_pattern, re_exec): Declare arguments and local
5649 variables `size_t' and `ssize_t' and return values `regoff_t', as
5650 appropriate.
5651 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5652 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5653 <compile_stack_type>: `size' and `avail' are now `size_t'.
5654
5655 * regex.h <regoff_t>: Use ssize_t, not int.
5656 (re_search, re_search_2, re_match, re_match_2): Arguments that
5657 specify buffer/string position and length are now ssize_t and
5658 size_t. Return type is regoff_t.
5659
5660 2011-04-16 Ben Key <bkey76@gmail.com>
5661
5662 * nsfont.m: Fixed bugs in ns_get_family and
5663 ns_descriptor_to_entity that were caused by using free to
5664 deallocate memory blocks that were allocated by xmalloc (via
5665 xstrdup). This caused Emacs to crash when compiled with
5666 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5667 --enable-checking=xmallocoverrun). xfree is now used to
5668 deallocate these memory blocks.
5669
5670 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5671
5672 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5673
5674 emacs_write: Accept and return EMACS_INT for sizes.
5675 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5676 et seq.
5677 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5678 Accept and return EMACS_INT.
5679 (emacs_gnutls_write): Return the number of bytes written on
5680 partial writes.
5681 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5682 (emacs_read, emacs_write): Remove check for negative size, as the
5683 Emacs source code has been audited now.
5684 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5685 (emacs_read, emacs_write): Use it.
5686 * process.c (send_process): Adjust to the new signatures of
5687 emacs_write and emacs_gnutls_write. Do not attempt to store
5688 a byte offset into an 'int'; it might overflow.
5689 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5690
5691 * sound.c: Don't assume sizes fit in 'int'.
5692 (struct sound_device.period_size, alsa_period_size):
5693 Return EMACS_INT, not int.
5694 (struct sound_device.write, vox_write, alsa_write):
5695 Accept EMACS_INT, not int.
5696 (wav_play, au_play): Use EMACS_INT to store sizes and to
5697 record read return values.
5698
5699 2011-04-15 Ben Key <bkey76@gmail.com>
5700
5701 * keyboard.c (Qundefined): Don't declare static since it is used
5702 in nsfns.m.
5703 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5704 static since they are used in nsfont.m.
5705
5706 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5707
5708 * process.c (Qprocessp): Don't declare static.
5709 * lisp.h (Qprocessp): Declare again.
5710
5711 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5712
5713 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5714
5715 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5716
5717 Improve C-level modularity by making more things 'static'.
5718
5719 Don't publish debugger-only interfaces to other modules.
5720 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5721 (verify_bytepos, count_markers): Move decls to the only modules
5722 that need them.
5723 * region-cache.h (pp_cache): Likewise.
5724 * window.h (check_all_windows): Likewise.
5725 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5726
5727 * sysdep.c (croak): Now static, if
5728 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5729 * syssignal.h (croak): Declare only if not static.
5730
5731 * alloc.c (refill_memory_reserve): Now static if
5732 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5733 * lisp.h (refill_memory_reserve): Declare only if not static.
5734
5735 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5736 Define only if USE_LUCID.
5737
5738 * xrdb.c (x_customization_string, x_rm_string): Now static.
5739
5740 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5741 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5742
5743 * xdisp.c (draw_row_with_mouse_face): Now static.
5744 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5745
5746 * window.h (check_all_windows): Mark externally visible.
5747
5748 * window.c (window_deletion_count): Now static.
5749
5750 * undo.c: Make symbols static if they're not exported.
5751 (last_undo_buffer, last_boundary_position, pending_boundary):
5752 Now static.
5753
5754 * textprop.c (interval_insert_behind_hooks): Now static.
5755 (interval_insert_in_front_hooks): Likewise.
5756
5757 * term.c: Make symbols static if they're not exported.
5758 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5759 (max_frame_lines, tty_set_terminal_modes):
5760 (tty_reset_terminal_modes, tty_turn_off_highlight):
5761 (get_tty_terminal): Now static.
5762 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5763 * termhooks.h (term_mouse_moveto): Do not declare if
5764 HAVE_WINDOW_SYSTEM.
5765 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5766 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5767
5768 * sysdep.c: Make symbols static if they're not exported.
5769 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5770 Now static.
5771 (sigprocmask_set, full_mask): Remove; unused.
5772 (wait_debugging): Mark as visible.
5773 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5774 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5775
5776 * syntax.c (syntax_temp): Define only if !__GNUC__.
5777
5778 * sound.c (current_sound_device, current_sound): Now static.
5779
5780 * search.c (searchbufs, searchbuf_head): Now static.
5781
5782 * scroll.c (scroll_cost): Remove; unused.
5783 * dispextern.h (scroll_cost): Remove decl.
5784
5785 * region-cache.h (pp_cache): Mark as externally visible.
5786
5787 * process.c: Make symbols static if they're not exported.
5788 (process_tick, update_tick, create_process, chan_process):
5789 (Vprocess_alist, proc_buffered_char, datagram_access):
5790 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5791 (deactivate_process): Mark defn as static, as well as decl.
5792 * lisp.h (create_process): Remove decl.
5793 * process.h (chan_process, Vprocess_alist): Remove decls.
5794
5795 * print.c: Make symbols static if they're not exported.
5796 (print_depth, new_backquote_output, being_printed, print_buffer):
5797 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5798 (print_interval, print_number_index, initial_stderr_stream):
5799 Now static.
5800 * lisp.h (Fprinc): Remove decl.
5801 (debug_output_compilation_hack): Mark as externally visible.
5802
5803 * sysdep.c (croak): Move decl from here to syssignal.h.
5804 * syssignal.h (croak): Put it here, so the API can be checked when
5805 'croak' is called from dissociate_if_controlling_tty.
5806
5807 * minibuf.c: Make symbols static if they're not exported.
5808 (minibuf_save_list, choose_minibuf_frame): Now static.
5809 * lisp.h (choose_minibuf_frame): Remove decl.
5810
5811 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5812
5813 * lread.c: Make symbols static if they're not exported.
5814 (read_objects, initial_obarray, oblookup_last_bucket_number):
5815 Now static.
5816 (make_symbol): Remove; unused.
5817 * lisp.h (initial_obarray, make_symbol): Remove decls.
5818
5819 * keyboard.c: Make symbols static if they're not exported.
5820 (single_kboard, recent_keys_index, total_keys, recent_keys):
5821 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5822 (this_single_command_key_start, echoing, last_auto_save):
5823 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5824 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5825 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5826 (Vlispy_mouse_stem, double_click_count):
5827 Now static.
5828 (force_auto_save_soon): Define only if SIGDANGER.
5829 (ignore_mouse_drag_p): Now static if
5830 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5831 (print_help): Remove; unused.
5832 (stop_character, last_timer_event): Mark as externally visible.
5833 * keyboard.h (ignore_mouse_drag_p): Declare only if
5834 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5835 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5836 * lisp.h (echoing): Remove decl.
5837 (force_auto_save_soon): Declare only if SIGDANGER.
5838 * xdisp.c (redisplay_window): Simplify code, to make it more
5839 obvious that ignore_mouse_drag_p is not accessed if !defined
5840 USE_GTK && !defined HAVE_NS.
5841
5842 * intervals.c: Make symbols static if they're not exported.
5843 (merge_properties_sticky, merge_interval_right, delete_interval):
5844 Now static.
5845 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5846
5847 * insdel.c: Make symbols static if they're not exported.
5848 However, leave prepare_to_modify_buffer alone. It's never
5849 called from outside this function, but that appears to be a bug.
5850 (combine_after_change_list, combine_after_change_buffer):
5851 (adjust_after_replace, signal_before_change): Now static.
5852 (adjust_after_replace_noundo): Remove; unused.
5853 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5854 (signal_before_change): Remove decls.
5855
5856 * indent.c (val_compute_motion, val_vmotion): Now static.
5857
5858 * image.c: Make symbols static if they're not exported.
5859 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5860 if USE_GTK.
5861 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5862 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5863
5864 * fringe.c (standard_bitmaps): Now static.
5865 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5866
5867 * frame.c: Make symbols static if they're not exported.
5868 (x_report_frame_params, make_terminal_frame): Now static.
5869 (get_frame_param): Now static, unless HAVE_NS.
5870 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5871 (x_get_resource_string): Remove; not used.
5872 * frame.h (make_terminal_frame, x_report_frame_params):
5873 (x_get_resource_string); Remove decls.
5874 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5875 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5876
5877 * font.c, fontset.c: Make symbols static if they're not exported.
5878 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5879 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5880 * font.c (font_close_object): Now static.
5881 * font.h (font_close_object): Remove.
5882 * fontset.c (FONTSET_OBJLIST): Remove.
5883 (free_realized_fontset) #if-0 the body, which does nothing.
5884 (face_suitable_for_char_p): #if-0, as it's never called.
5885 * fontset.h (face_suitable_for_char_p): Remove decl.
5886 * xfaces.c (face_at_string_position):
5887 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5888 since 0 is always ASCII.
5889
5890 * fns.c (weak_hash_tables): Now static.
5891
5892 * fileio.c: Make symbols static if they're not exported.
5893 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5894 (Vwrite_region_annotation_buffers): Now static.
5895
5896 * eval.c: Make symbols static if they're not exported.
5897 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5898 * lisp.h (backtrace_list): Remove decl.
5899
5900 * emacs.c: Make symbols static if they're not exported.
5901 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5902 (fatal_error_code, fatal_error_signal_hook, standard_args):
5903 Now static.
5904 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5905 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5906 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5907 * lisp.h (fatal_error_signal_hook): Remove decl.
5908 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5909
5910 * editfns.c: Move a (normally-unused) function to its only use.
5911 * editfns.c, lisp.h (get_operating_system_release): Remove.
5912 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5913 worth the hassle of breaking this out.
5914
5915 * xterm.c: Make symbols static if they're not exported.
5916 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5917 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5918 (x_destroy_window, x_delete_display):
5919 Now static.
5920 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5921 (x_mouse_leave): Remove; unused.
5922 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5923 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5924 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5925 Remove decls.
5926 (x_mouse_leave): Declare only if WINDOWSNT.
5927 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5928 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5929 USE_X_TOOLKIT.
5930
5931 * ftxfont.c: Make symbols static if they're not exported.
5932 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5933 HAVE_FREETYPE.
5934 * font.h (ftxfont_driver): Likewise.
5935
5936 * xfns.c: Make symbols static if they're not exported.
5937 (x_last_font_name, x_display_info_for_name):
5938 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5939 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5940 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5941 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5942 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5943 (last_show_tip_args): Now static.
5944 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5945 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5946 (x_screen_planes): Remove; unused.
5947 * dispextern.h (x_screen_planes): Remove decl.
5948
5949 * dispnew.c: Make symbols static if they're not exported.
5950 * dispextern.h (redraw_garbaged_frames, scrolling):
5951 (increment_row_positions): Remove.
5952 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5953 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5954 Now static.
5955 (redraw_garbaged_frames): Remove; unused.
5956
5957 * xfaces.c: Make symbols static if they're not exported.
5958 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5959 Remove decls.
5960 * xterm.h (defined_color): Remove decls.
5961 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5962 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5963 (menu_face_changed_default, defined_color, free_realized_face):
5964 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5965 (ascii_face_of_lisp_face): Remove; unused.
5966
5967 * xdisp.c: Make symbols static if they're not exported.
5968 * dispextern.h (scratch_glyph_row, window_box_edges):
5969 (glyph_to_pixel_coords, set_cursor_from_row):
5970 (get_next_display_element, set_iterator_to_next):
5971 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5972 (show_mouse_face): Remove decls
5973 * frame.h (message_buf_print): Likewise.
5974 * lisp.h (pop_message, set_message, check_point_in_composition):
5975 Likewise.
5976 * xterm.h (set_vertical_scroll_bar): Likewise.
5977 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5978 (message_buf_print, scratch_glyph_row, displayed_buffer):
5979 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5980 (get_next_display_element, show_mouse_face, window_box_edges):
5981 (frame_to_window_pixel_xy, check_point_in_composition):
5982 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5983 (glyph_to_pixel_coords): Remove; unused.
5984
5985 * dired.c (file_name_completion): Now static.
5986
5987 * dbusbind.c (xd_in_read_queued_messages): Now static.
5988
5989 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5990 * data.c (circular_list_error): Remove.
5991
5992 * commands.h (last_point_position, last_point_position_buffer):
5993 (last_point_position_window): Remove decls.
5994 * keyboard.c: Make these variables static.
5995
5996 * coding.h (coding, code_convert_region, encode_coding_gap):
5997 Remove decls.
5998 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5999 (iso_code_class, detect_coding, code_convert_region): Now static.
6000 (encode_coding_gap): Remove; unused.
6001
6002 * chartab.c (chartab_chars, chartab_bits): Now static.
6003
6004 * charset.h (charset_iso_8859_1): Remove decl.
6005 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6006 Now static.
6007
6008 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6009 * ccl.c (Vccl_program_table): Now static.
6010 (check_ccl_update): Remove; unused.
6011
6012 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6013 * category.h: ... from here.
6014 * category.c (check_category_table, set_category_set): Now static.
6015
6016 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6017 * lisp.h: Remove these decls.
6018
6019 * buffer.c (buffer_count): Remove unused var.
6020
6021 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6022 so that it's not optimized away.
6023 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6024 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6025 exported only to the debugger.
6026
6027 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6028 * atimer.h (run_all_atimers): Remove; not exported.
6029
6030 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6031 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6032 was inaccessible from Lisp.
6033 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6034 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6035
6036 alloc.c: Import and export fewer symbols, and remove unused items.
6037 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6038 is defined.
6039 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6040 it's not optimized away by whole-program optimization.
6041 (message_enable_multibyte, free_misc): Remove.
6042 (catchlist, handlerlist, mark_backtrace):
6043 Declare only if BYTE_MARK_STACK.
6044 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6045 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6046 (message_enable_multibyte): Remove decl.
6047 (free_misc, interval_free_list, float_block, float_block_index):
6048 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6049 (cons_free_list, last_marked_index):
6050 Now static.
6051 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6052 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6053 (mark_backtrace): Define only if BYTE_MARK_STACK.
6054 * xdisp.c (message_enable_multibyte): Now static.
6055
6056 Declare Lisp_Object Q* variables to be 'static' if not exported.
6057 This makes it easier for human readers (and static analyzers)
6058 to see whether these variables are used from other modules.
6059 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6060 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6061 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6062 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6063 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6064 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6065 * xmenu.c, xselect.c:
6066 Declare Q* vars static if they are not used in other modules.
6067 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6068 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6069 Remove decls of unexported vars.
6070 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6071
6072 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6073
6074 Make Emacs functions such as Fatom 'static' by default.
6075 This makes it easier for human readers (and static analyzers)
6076 to see whether these functions can be called from other modules.
6077 DEFUN now defines a static function. To make the function external
6078 so that it can be used in other C modules, use the new macro DEFUE.
6079 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6080 (Finit_image_library):
6081 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6082 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6083 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6084 Remove decls, since these functions are now static.
6085 (Funintern, Fget_internal_run_time): New decls, since these functions
6086 were already external.
6087
6088 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6089 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6090 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6091 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6092 * keyboard.c, keymap.c, lread.c:
6093 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6094 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6095 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6096 Mark functions with DEFUE instead of DEFUN,
6097 if they are used in other modules.
6098 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6099 decls for now-static functions.
6100 * buffer.h (Fdelete_overlay): Remove decl.
6101 * callproc.c (Fgetenv_internal): Mark as internal.
6102 * composite.c (Fremove_list_of_text_properties): Remove decl.
6103 (Fcomposition_get_gstring): New forward static decl.
6104 * composite.h (Fcomposite_get_gstring): Remove decl.
6105 * dired.c (Ffile_attributes): New forward static decl.
6106 * doc.c (Fdocumntation_property): New forward static decl.
6107 * eval.c (Ffetch_bytecode): New forward static decl.
6108 (Funintern): Remove extern decl; now in .h file where it belongs.
6109 * fileio.c (Fmake_symbolic_link): New forward static decl.
6110 * image.c (Finit_image_library): New forward static decl.
6111 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6112 * intervals.h (Fprevious_property_change):
6113 (Fremove_list_of_text_properties): Remove decls.
6114 * keyboard.c (Fthis_command_keys): Remove decl.
6115 (Fcommand_execute): New forward static decl.
6116 * keymap.c (Flookup_key): New forward static decl.
6117 (Fcopy_keymap): Now static.
6118 * keymap.h (Flookup_key): Remove decl.
6119 * process.c (Fget_process): New forward static decl.
6120 (Fprocess_datagram_address): Mark as internal.
6121 * syntax.c (Fsyntax_table_p): New forward static decl.
6122 (skip_chars): Remove duplicate decl.
6123 * textprop.c (Fprevious_property_change): New forward static decl.
6124 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6125 Now internal.
6126 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6127 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6128
6129 * editfns.c (Fformat): Remove unreachable code.
6130
6131 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6132
6133 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6134 change. (Bug#8496)
6135
6136 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6137
6138 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6139 when at ZV. (Bug#8487)
6140
6141 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6142
6143 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6144 (Bug#8437)
6145 * keyboard.c (parse_tool_bar_item): Likewise.
6146 * sound.c (sound_cleanup, alsa_close): Likewise.
6147 * termcap.c (tgetent): Likewise.
6148 * xfns.c (x_default_font_parameter): Likewise.
6149 * xsettings.c (read_and_apply_settings): Likewise.
6150
6151 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6152 (overrun_check_free): Protoize.
6153
6154 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6155
6156 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6157 since callers should never pass a negative size.
6158 Change the signature to match that of plain 'read' and 'write'; see
6159 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6160 * lisp.h: Update prototypes of emacs_write and emacs_read.
6161
6162 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6163
6164 * xdisp.c (redisplay_window): Don't try to determine the character
6165 position of the scroll margin if the window start point w->startp
6166 is outside the buffer's accessible region. (Bug#8468)
6167
6168 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6169
6170 Fix write-region and its subroutines for buffers > 2GB.
6171 * fileio.c (a_write, e_write): Modify declaration of arguments and
6172 local variables to support buffers larger than 2GB.
6173 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6174
6175 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6176 argument, local variables, and return value.
6177
6178 * lisp.h: Update prototypes of emacs_write and emacs_read.
6179
6180 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6181
6182 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6183
6184 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6185
6186 Fix more problems found by GCC 4.6.0's static checks.
6187
6188 * xdisp.c (vmessage): Use a better test for character truncation.
6189
6190 * charset.c (load_charset_map): <, not <=, for optimization,
6191 and to avoid potential problems with integer overflow.
6192 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6193 * casetab.c (set_identity, shuffle): Likewise.
6194 * editfns.c (Fformat): Likewise.
6195 * syntax.c (skip_chars): Likewise.
6196
6197 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6198 This also lets GCC 4.6.0 generate slightly better loop code.
6199
6200 * callint.c (Fcall_interactively): <, not <=, for optimization.
6201 (Fcall_interactively): Count the number of arguments produced,
6202 not the number of arguments given. This is simpler and lets GCC
6203 4.6.0 generate slightly better code.
6204
6205 * ftfont.c: Distingish more carefully between FcChar8 and char.
6206 The previous code passed unsigned char * to a functions like
6207 strlen and xstrcasecmp that expect char *, which does not
6208 conform to the C standard.
6209 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6210 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6211 char * when the C standard requires it.
6212
6213 * keyboard.c (read_char): Remove unused var.
6214
6215 * eval.c: Port to Windows vsnprintf (Bug#8435).
6216 Include <limits.h>.
6217 (SIZE_MAX): Define if the headers do not.
6218 (verror): Do not give up if vsnprintf returns a negative count.
6219 Instead, grow the buffer. This ports to Windows vsnprintf, which
6220 does not conform to C99. Problem reported by Eli Zaretskii.
6221 Also, simplify the allocation scheme, by avoiding the need for
6222 calling realloc, and removing the ALLOCATED variable.
6223
6224 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6225
6226 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6227 But keep the doprint source code for now, as we might revamp it
6228 and use it again (Bug#8435).
6229 * lisp.h (doprnt): Remove.
6230 * Makefile.in (base_obj): Remove doprnt.o.
6231 * deps.mk (doprnt.o): Remove.
6232
6233 error: Print 32- and 64-bit integers portably (Bug#8435).
6234 Without this change, on typical 64-bit hosts error ("...%d...", N)
6235 was used to print both 32- and 64-bit integers N, which relied on
6236 undefined behavior.
6237 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6238 New macro.
6239 * lisp.h (error, verror): Mark as printf-like functions.
6240 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6241 Report overflow in size calculations when allocating printf buffer.
6242 Do not truncate output string at its first null byte.
6243 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6244 Truncate the output at a character boundary, since vsnprintf does not
6245 do that.
6246 * charset.c (check_iso_charset_parameter): Convert internal
6247 character to string before calling 'error', since %c now has the
6248 printf meaning.
6249 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6250 overflow when computing char to be passed to 'error'. Do not
6251 pass Lisp_Object to 'error'; pass the integer instead.
6252 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6253 formatted with plain %d.
6254
6255 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6256
6257 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6258
6259 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6260
6261 * xterm.c (x_catch_errors): Remove duplicate declaration.
6262
6263 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6264
6265 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6266
6267 2011-04-10 Jim Meyering <meyering@redhat.com>
6268
6269 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6270 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6271 return ssize_t not "int", and use size_t as the buffer length.
6272 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6273 * gnutls.h: Update declarations.
6274 * process.c (read_process_output): Use ssize_t, to match.
6275 (send_process): Likewise.
6276
6277 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6278
6279 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6280
6281 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6282
6283 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6284 Use unsigned char, to match FcChar8 type definition.
6285
6286 * xterm.c (handle_one_xevent):
6287 * xmenu.c (create_and_show_popup_menu):
6288 * xselect.c (x_decline_selection_request)
6289 (x_reply_selection_request): Avoid type-punned deref of X events.
6290
6291 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6292
6293 Fix some uses of `int' instead of EMACS_INT.
6294 * search.c (string_match_1, fast_string_match)
6295 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6296 (scan_buffer, find_next_newline_no_quit)
6297 (find_before_next_newline, search_command, Freplace_match)
6298 (Fmatch_data): Make some `int' variables be EMACS_INT.
6299
6300 * xdisp.c (display_count_lines): 3rd argument and return value now
6301 EMACS_INT. All callers changed.
6302 (pint2hrstr): Last argument is now EMACS_INT.
6303
6304 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6305 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6306 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6307 (decode_coding_utf_16, decode_coding_emacs_mule)
6308 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6309 (decode_coding_ccl, decode_coding_charset)
6310 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6311 (decode_coding_iso_2022, decode_coding_emacs_mule)
6312 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6313 <char_offset, last_offset>: Declare EMACS_INT.
6314 (encode_coding_utf_8, encode_coding_utf_16)
6315 (encode_coding_emacs_mule, encode_invocation_designation)
6316 (encode_designation_at_bol, encode_coding_iso_2022)
6317 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6318 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6319 Declare EMACS_INT.
6320 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6321 (encode_invocation_designation): Last argument P_NCHARS is now
6322 EMACS_INT.
6323 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6324 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6325
6326 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6327 All users changed.
6328
6329 * ccl.c (Fccl_execute_on_string): Declare some variables
6330 EMACS_INT.
6331
6332 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6333
6334 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6335
6336 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6337
6338 * process.c (Fformat_network_address): Doc fix.
6339
6340 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6341
6342 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6343
6344 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6345
6346 * keyboard.c (read_char): Call Lisp function help-form-show,
6347 instead of using internal_with_output_to_temp_buffer.
6348 (Qhelp_form_show): New var.
6349 (syms_of_keyboard): Use DEFSYM macro.
6350
6351 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6352
6353 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6354
6355 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6356
6357 * process.c (Flist_processes): Remove to Lisp.
6358 (list_processes_1): Delete.
6359
6360 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6361
6362 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6363
6364 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6365
6366 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6367
6368 Fix more problems found by GCC 4.6.0's static checks.
6369
6370 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6371
6372 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6373
6374 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6375
6376 * xdisp.c (vmessage): Mark as a printf-like function.
6377
6378 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6379
6380 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6381
6382 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6383 printf-like functions.
6384 (tiff_load): Add casts to remove these marks before passing them
6385 to system-supplied API.
6386
6387 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6388
6389 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6390 This avoids several warnings with gcc -Wstrict-overflow.
6391 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6392 directly, rather than having caller test rule sign. This avoids
6393 some unnecessary tests.
6394 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6395 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6396 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6397
6398 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6399 (xfont_open): Avoid unnecessary tests.
6400
6401 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6402
6403 * composite.h, composite.c (composition_gstring_put_cache):
6404 Use EMACS_INT, not int, for length.
6405
6406 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6407 breaking out part of COMPOSITION_DECODE_RULE.
6408 (COMPOSITION_DECODE_RULE): Use it.
6409 * composite.c (get_composition_id): Remove unused local vars,
6410 by using the new macro.
6411
6412 * textprop.c (set_text_properties_1): Change while to do-while,
6413 since the condition is always true at first.
6414
6415 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6416 (interval_deletion_adjustment): Return unsigned value.
6417 All uses changed.
6418
6419 * process.c (list_processes_1, create_pty, read_process_output):
6420 (exec_sentinel): Remove vars that were set but not used.
6421 (create_pty): Remove unnecessary "volatile"s.
6422 (Fnetwork_interface_info): Avoid possibility of int overflow.
6423 (read_process_output): Do adaptive read buffering even if carryover.
6424 (read_process_output): Simplify nbytes computation if buffered.
6425
6426 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6427
6428 * syntax.c (scan_words): Remove var that was set but not used.
6429 (update_syntax_table): Use unsigned instead of int.
6430
6431 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6432 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6433 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6434
6435 * print.c (print_error_message): Avoid int overflow.
6436
6437 * font.c (font_list_entities): Redo for clarity,
6438 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6439
6440 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6441 (font_score): Avoid potential overflow in diff calculation.
6442
6443 * fns.c (substring_both): Remove var that is set but not used.
6444 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6445
6446 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6447
6448 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6449 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6450 can always succeed if overflow has undefined behavior.
6451
6452 * search.c (boyer_moore, wordify): Remove vars set but not used.
6453 (wordify): Omit three unnecessary tests.
6454
6455 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6456 All callers changed. This avoids the need for an unused var.
6457
6458 * casefiddle.c (casify_region): Remove var that is set but not used.
6459
6460 * dired.c (file_name_completion): Remove var that is set but not used.
6461
6462 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6463
6464 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6465 (Finsert_file_contents): Remove unnecessary code checking fd.
6466
6467 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6468 Check for integer overflow on size calculations.
6469
6470 * buffer.c (Fprevious_overlay_change): Remove var that is set
6471 but not used.
6472
6473 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6474 Remove vars that are set but not used.
6475 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6476 (timer_check_2): Mark vars as initialized.
6477
6478 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6479
6480 * image.c (lookup_image): Remove var that is set but not used.
6481 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6482
6483 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6484 that are set but not used.
6485
6486 * xfns.c (make_invisible_cursor): Don't return garbage
6487 if XCreateBitmapFromData fails (Bug#8410).
6488
6489 * xselect.c (x_get_local_selection, x_handle_property_notify):
6490 Remove vars that are set but not used.
6491
6492 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6493 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6494
6495 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6496 Remove var that is set but not used.
6497 (scroll_bar_windows_size): Now size_t, not int.
6498 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6499 Check for overflow.
6500
6501 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6502 (map_tty_color) [!defined MSDOS]: Likewise.
6503
6504 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6505
6506 * coding.c: Remove vars that are set but not used.
6507 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6508 All callers changed.
6509 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6510 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6511 (decode_coding_charset): Remove vars that are set but not used.
6512
6513 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6514 that is set but not used.
6515
6516 * print.c (print_object): Remove var that is set but not used.
6517
6518 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6519 The gnulib version avoids calling malloc in the usual case,
6520 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6521 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6522 * filelock.c (current_lock_owner): Likewise.
6523 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6524 * sysdep.c: Include allocator.h, careadlinkat.h.
6525 (emacs_no_realloc_allocator): New static constant.
6526 (emacs_readlink): New function.
6527 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6528 ../lib/careadlinkat.h.
6529
6530 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6531
6532 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6533 first non-nil return value).
6534
6535 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6536
6537 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6538 if not defined (Bug#8403).
6539
6540 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6541
6542 * xdisp.c (display_count_lines): Remove parameter `start',
6543 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6544 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6545 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6546 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6547 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6548 and thereabouts. All callers changed.
6549 (get_per_char_metric): Remove parameter `f', unused since
6550 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6551
6552 2011-04-02 Jim Meyering <meyering@redhat.com>
6553
6554 do not dereference NULL upon failed strdup
6555 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6556 (ns_get_family): Likewise.
6557
6558 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6559
6560 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6561
6562 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6563
6564 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6565 later (Bug#8403).
6566
6567 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6568
6569 Add lexical binding.
6570
6571 * window.c (Ftemp_output_buffer_show): New fun.
6572 (Fsave_window_excursion):
6573 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6574
6575 * lread.c (lisp_file_lexically_bound_p): New function.
6576 (Fload): Bind Qlexical_binding.
6577 (readevalloop): Remove `evalfun' arg.
6578 Bind Qinternal_interpreter_environment.
6579 (Feval_buffer): Bind Qlexical_binding.
6580 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6581 Mark as dynamic.
6582 (syms_of_lread): Declare `lexical-binding'.
6583
6584 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6585
6586 * keyboard.c (eval_dyn): New fun.
6587 (menu_item_eval_property): Use it.
6588
6589 * image.c (parse_image_spec): Use Ffunctionp.
6590
6591 * fns.c (concat, mapcar1): Accept byte-code-functions.
6592
6593 * eval.c (Fsetq): Handle lexical vars.
6594 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6595 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6596 (FletX, Flet): Obey lexical binding.
6597 (Fcommandp): Handle closures.
6598 (Feval): New `lexical' arg.
6599 (eval_sub): New function extracted from Feval. Use it almost
6600 everywhere where Feval was used. Look up vars in lexical env.
6601 Handle closures.
6602 (Ffunctionp): Move from subr.el.
6603 (Ffuncall): Handle closures.
6604 (apply_lambda): Remove `eval_flags'.
6605 (funcall_lambda): Handle closures and new byte-code-functions.
6606 (Fspecial_variable_p): New function.
6607 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6608 but without exporting it to Lisp.
6609
6610 * doc.c (Fdocumentation, store_function_docstring):
6611 * data.c (Finteractive_form): Handle closures.
6612
6613 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6614 interactive spec.
6615
6616 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6617 New byte-codes.
6618 (exec_byte_code): New function extracted from Fbyte_code to handle new
6619 calling convention for byte-code-functions. Add new byte-codes.
6620
6621 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6622
6623 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6624
6625 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6626
6627 * xdisp.c (redisplay_internal): Fix prototype.
6628
6629 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6630
6631 * xdisp.c (SCROLL_LIMIT): New macro.
6632 (try_scrolling): Use it when setting scroll_limit.
6633 Limit scrolling to 100 screen lines.
6634 (redisplay_window): Even when falling back on "recentering",
6635 position point in the window according to scroll-conservatively,
6636 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6637
6638 (try_scrolling): When point is above the window, allow searching
6639 as far as scroll_max, or one screenful, to compute vertical
6640 distance from PT to the scroll margin position. This prevents
6641 try_scrolling from unnecessarily failing when
6642 scroll-conservatively is set to a value slightly larger than the
6643 window height. Clean up the case of PT below the margin at bottom
6644 of window: scroll_max can no longer be INT_MAX. When aggressive
6645 scrolling is in use, don't let point enter the opposite scroll
6646 margin as result of the scroll.
6647 (syms_of_xdisp) <scroll-conservatively>: Document the
6648 threshold of 100 lines for never-recentering scrolling.
6649
6650 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6651
6652 * dispextern.h (move_it_by_lines):
6653 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6654 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6655 (message_log_check_duplicate): Remove parameters `prev_bol' and
6656 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6657 (redisplay_internal): Remove parameter `preserve_echo_area',
6658 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6659
6660 * indent.c (Fvertical_motion):
6661 * window.c (window_scroll_pixel_based, Frecenter):
6662 Don't pass `need_y_p' to `move_it_by_lines'.
6663
6664 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6665
6666 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6667 steal a few bits to be more compact.
6668 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6669 Remove unneeded casts.
6670
6671 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6672
6673 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6674
6675 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6676 binding" message (bug#7967).
6677
6678 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6679
6680 Fix more problems found by GCC 4.6.0's static checks.
6681
6682 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6683 Remove unused local var.
6684
6685 * editfns.c (Fmessage_box): Remove unused local var.
6686
6687 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6688 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6689 Omit unused local vars.
6690 * window.c (shrink_windows): Omit unused local var.
6691 * menu.c (digest_single_submenu): Omit unused local var.
6692 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6693 Omit unused local var.
6694
6695 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6696 Don't assume string length fits in int.
6697 (keyremap_step, read_key_sequence): Use size_t for sizes.
6698 (read_key_sequence): Don't check last_real_key_start redundantly.
6699
6700 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6701 instead of alloca (Bug#8344).
6702
6703 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6704 (Fbacktrace_frame): Don't assume nframes fits in int.
6705
6706 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6707
6708 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6709 concerns.
6710
6711 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6712
6713 * cm.c (calccost): Turn while-do into do-while, for clarity.
6714
6715 * keyboard.c (syms_of_keyboard): Use the same style as later
6716 in this function when indexing through an array. This also
6717 works around GCC bug 48267.
6718
6719 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6720
6721 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6722
6723 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6724 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6725
6726 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6727 This avoids undefined behavior on integer overflow, and is a bit
6728 more convenient anyway since it is compared to a size_t variable.
6729
6730 Variadic C functions now count arguments with size_t, not int.
6731 This avoids an unnecessary limitation on 64-bit machines, which
6732 caused (substring ...) to crash on large vectors (Bug#8344).
6733 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6734 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6735 All variadic functions and their callers changed accordingly.
6736 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6737 * data.c (arith_driver, float_arith_driver): Likewise.
6738 * editfns.c (general_insert_function): Likewise.
6739 * eval.c (struct backtrace.nargs, interactive_p)
6740 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6741 (funcall_lambda, mark_backtrace): Likewise.
6742 * fns.c (concat): Likewise.
6743 * frame.c (x_set_frame_parameters): Likewise.
6744 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6745 0 if not found, not -1. All callers changed.
6746
6747 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6748 (stack_copy_size): Now size_t, not int.
6749 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6750
6751 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6752
6753 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6754 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6755 All callers changed.
6756
6757 * lisp.h (multibyte_char_to_unibyte):
6758 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6759 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6760 * character.h (CHAR_TO_BYTE8):
6761 * cmds.c (internal_self_insert):
6762 * editfns.c (general_insert_function):
6763 * keymap.c (push_key_description):
6764 * search.c (Freplace_match):
6765 * xdisp.c (message_dolog, set_message_1): All callers changed.
6766
6767 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6768
6769 * keyboard.c (safe_run_hook_funcall): New function.
6770 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6771 don't set the hook to nil, but remove the offending function instead.
6772 (Qcommand_hook_internal): Remove, unused.
6773 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6774 Vcommand_hook_internal.
6775
6776 * eval.c (enum run_hooks_condition): Remove.
6777 (funcall_nil, funcall_not): New functions.
6778 (run_hook_with_args): Call each function through a `funcall' argument.
6779 Remove `cond' argument, now redundant.
6780 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6781 (Frun_hook_with_args_until_failure): Adjust accordingly.
6782 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6783
6784 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6785
6786 * dispextern.h (string_buffer_position): Remove declaration.
6787
6788 * print.c (strout): Remove parameter `multibyte', unused since
6789 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6790
6791 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6792 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6793 All callers changed.
6794
6795 * w32.c (_wsa_errlist): Use braces for struct initializers.
6796
6797 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6798 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6799 All callers changed.
6800 (string_buffer_position): Likewise. Also, make static (it's never
6801 used outside xdisp.c).
6802 (cursor_row_p): Remove parameter `w', unused since
6803 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6804 (decode_mode_spec): Remove parameter `precision', introduced during
6805 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6806 All callers changed.
6807
6808 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6809
6810 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6811
6812 2011-03-27 Anders Lindgren <andlind@gmail.com>
6813
6814 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6815 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6816 (ns_update_auto_hide_menu_bar): New functions.
6817 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6818 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6819 ns_constrain_all_frames.
6820 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6821 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6822
6823 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6824
6825 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6826
6827 2011-03-27 Glenn Morris <rgm@gnu.org>
6828
6829 * syssignal.h: Replace RETSIGTYPE with void.
6830 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6831 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6832 Replace SIGTYPE with void everywhere.
6833 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6834 * s/template.h (SIGTYPE): Remove commented out definition.
6835
6836 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6837
6838 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6839 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6840
6841 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6842
6843 * w32.c (read_unc_volume): Use parameter `henum', instead of
6844 global variable `wget_enum_handle'.
6845
6846 * keymap.c (describe_vector): Remove parameters `indices' and
6847 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6848 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6849
6850 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6851
6852 * keyboard.c (timer_check): Remove parameter `do_it_now',
6853 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6854 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6855 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6856
6857 * keyboard.c (read_char):
6858 * w32menu.c (w32_menu_display_help):
6859 * xmenu.c (show_help_event, menu_help_callback):
6860 Adjust calls to `show_help_echo'.
6861
6862 * gtkutil.c (xg_maybe_add_timer):
6863 * keyboard.c (readable_events):
6864 * process.c (wait_reading_process_output):
6865 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6866
6867 * insdel.c (adjust_markers_gap_motion):
6868 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6869 (gap_left, gap_right): Don't call it.
6870
6871 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6872
6873 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6874 incurred during fontification.
6875
6876 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6877
6878 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6879 (DEFVAR_PER_BUFFER): Don't pass it.
6880
6881 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6882 (scrolling_window): Don't pass it.
6883
6884 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6885
6886 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6887
6888 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6889 and `suffix'.
6890 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6891 of variables specific to SELinux and computation of `encoded_absname'.
6892
6893 * image.c (XPutPixel): Remove unused variable `height'.
6894
6895 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6896
6897 * unexw32.c (get_section_info): Remove unused variable `section'.
6898
6899 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6900 (system_process_attributes): Remove unused variable `sess'.
6901 (sys_read): Remove unused variable `err'.
6902
6903 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6904 (w32_wnd_proc): Remove unused variable `isdead'.
6905 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6906 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6907 (x_create_tip_frame): Remove unused variable `tem'.
6908
6909 * w32inevt.c (w32_console_read_socket):
6910 Remove unused variable `no_events'.
6911
6912 * w32term.c (x_draw_composite_glyph_string_foreground):
6913 Remove unused variable `width'.
6914
6915 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6916
6917 * w32term.c (x_set_glyph_string_clipping):
6918 Don't pass uninitialized region to CombineRgn.
6919
6920 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6921
6922 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6923 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6924 (Fx_close_connection): Remove unused variable `i'.
6925
6926 * w32font.c (w32font_draw): Return number of glyphs.
6927 (w32font_open_internal): Remove unused variable `i'.
6928 (w32font_driver): Add missing initializer.
6929
6930 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6931 (fill_in_menu): Remove unused variable `items_added'.
6932
6933 * w32term.c (last_mouse_press_frame): Remove static global variable.
6934 (w32_clip_to_row): Remove unused variable `f'.
6935 (x_delete_terminal): Remove unused variable `i'.
6936
6937 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6938 (NOTHING): Remove unused static global variable.
6939 (uniscribe_check_otf): Remove unused variable `table'.
6940 (uniscribe_font_driver): Add missing initializers.
6941
6942 2011-03-23 Julien Danjou <julien@danjou.info>
6943
6944 * term.c (Fsuspend_tty, Fresume_tty):
6945 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6946 * window.c (temp_output_buffer_show):
6947 * insdel.c (signal_before_change):
6948 * frame.c (Fhandle_switch_frame):
6949 * fileio.c (Fdo_auto_save):
6950 * emacs.c (Fkill_emacs):
6951 * editfns.c (save_excursion_restore):
6952 * cmds.c (internal_self_insert):
6953 * callint.c (Fcall_interactively):
6954 * buffer.c (Fkill_all_local_variables):
6955 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6956 Use Frun_hooks.
6957 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6958 unconditionnaly since it does the check itself.
6959
6960 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6961
6962 Fix more problems found by GCC 4.5.2's static checks.
6963
6964 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6965 the first time through the loop, since we know p0 < p1 then.
6966 This also avoids a gcc -Wstrict-overflow warning.
6967
6968 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6969 leading to a memory leak, possible in functions like
6970 load_charset_map_from_file that can allocate an unbounded number
6971 of objects (Bug#8318).
6972
6973 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6974 that could (at least in theory) be that large.
6975
6976 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6977 This is less likely to overflow, and avoids undefined behavior if
6978 overflow does occur. All callers changed. Use strtoul to scan
6979 for the unsigned long integer.
6980 (pint2hrstr): Simplify and tune code slightly.
6981 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6982
6983 * scroll.c (do_scrolling): Work around GCC bug 48228.
6984 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6985
6986 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6987 This also avoids a warning with gcc -Wstrict-overflow.
6988 (validate_x_resource_name): Simplify count usage.
6989 This also avoids a warning with gcc -Wstrict-overflow.
6990
6991 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6992 fail (Bug#8306).
6993
6994 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6995
6996 * process.c (Fmake_network_process): Use socklen_t, not int,
6997 where POSIX says socklen_t is required in portable programs.
6998 This fixes a porting bug on hosts like 64-bit HP-UX, where
6999 socklen_t is wider than int (Bug#8277).
7000 (Fmake_network_process, server_accept_connection):
7001 (wait_reading_process_output, read_process_output):
7002 Likewise.
7003
7004 * process.c: Rename or move locals to avoid shadowing.
7005 (list_processes_1, Fmake_network_process):
7006 (read_process_output_error_handler, exec_sentinel_error_handler):
7007 Rename or move locals.
7008 (Fmake_network_process): Define label "retry_connect" only if needed.
7009 (Fnetwork_interface_info): Fix pointer signedness.
7010 (process_send_signal): Add cast to avoid pointer signedness problem.
7011 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7012 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7013
7014 Make tparam.h and terminfo.c consistent.
7015 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7016 Include tparam.h instead, since it declares them.
7017 * cm.h (PC): Remove extern decl; tparam.h now does this.
7018 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7019 * terminfo.c: Include tparam.h, to check interfaces.
7020 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7021 (tparam): Adjust signature to match interface in tparam.h;
7022 this removes some undefined behavior. Check that outstring and len
7023 are zero, which they always are with Emacs.
7024 * tparam.h (PC, BC, UP): New extern decls.
7025
7026 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7027 (xftfont_open): Rename locals to avoid shadowing.
7028
7029 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7030 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7031 (OTF_TAG_SYM): Omit macro if not needed.
7032 (ftfont_list): Remove unused local.
7033 (get_adstyle_property, ftfont_pattern_entity):
7034 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7035 Rename locals to avoid shadowing.
7036
7037 * xfont.c (xfont_list_family): Mark var as initialized.
7038
7039 * xml.c (make_dom): Now static.
7040
7041 * composite.c (composition_compute_stop_pos): Rename local to
7042 avoid shadowing.
7043 (composition_reseat_it): Remove unused locals.
7044 (find_automatic_composition, composition_adjust_point): Likewise.
7045 (composition_update_it): Mark var as initialized.
7046 (find_automatic_composition): Mark vars as initialized,
7047 with a FIXME (Bug#8290).
7048
7049 character.h: Rename locals to avoid shadowing.
7050 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7051 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7052 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7053 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7054 to avoid shadowing.
7055
7056 * textprop.c (property_change_between_p): Remove; unused.
7057
7058 * intervals.c (interval_start_pos): Now static.
7059
7060 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7061
7062 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7063 Rename locals to avoid shadowing.
7064
7065 * sound.c (wav_play, au_play, Fplay_sound_internal):
7066 Fix pointer signedness.
7067 (alsa_choose_format): Remove unused local var.
7068 (wav_play): Initialize a variable to 0, to prevent undefined
7069 behavior (Bug#8278).
7070
7071 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7072
7073 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7074
7075 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7076 clobbering (Bug#8298).
7077 * sysdep.c (sys_subshell): Likewise.
7078 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7079
7080 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7081 This should get cleaned up, so that child_setup has the
7082 same signature on all platforms.
7083
7084 * callproc.c (call_process_cleanup): Now static.
7085 (relocate_fd): Rename locals to avoid shadowing.
7086
7087 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7088
7089 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7090 not to be necessary, and produces flickering.
7091
7092 2011-03-20 Glenn Morris <rgm@gnu.org>
7093
7094 * config.in: Remove file.
7095
7096 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7097
7098 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7099 are now in src/globals.h.
7100 (syms_of_minibuf): Remove spurious & from previous change.
7101
7102 2011-03-20 Leo <sdl.web@gmail.com>
7103
7104 * minibuf.c (completing-read-function): New variable.
7105 (completing-read-default): Rename from completing-read.
7106 (completing-read): Call completing-read-function.
7107
7108 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7109
7110 * xfaces.c (Fx_load_color_file):
7111 Read color file from absolute filename (bug#8250).
7112
7113 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7114
7115 * makefile.w32-in: Update dependencies.
7116
7117 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7118
7119 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7120
7121 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7122
7123 Fix more problems found by GCC 4.5.2's static checks.
7124
7125 * process.c (make_serial_process_unwind, send_process_trap):
7126 (sigchld_handler): Now static.
7127
7128 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7129 That way, the code declares only the vars that it needs.
7130 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7131 * s/cygwin.h (PTY_ITERATION): Likewise.
7132 * s/darwin.h (PTY_ITERATION): Likewise.
7133 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7134
7135 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7136 * process.c (allocate_pty): Don't declare stb unless it's needed.
7137
7138 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7139 (CONSTANTLIM): Remove; unused.
7140 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7141 Define only if needed.
7142
7143 * unexelf.c (unexec): Name an expression,
7144 to avoid gcc -Wbad-function-cast warning.
7145 Use a different way to cause a compilation error if anyone uses
7146 n rather than nn, a way that does not involve shadowing.
7147 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7148
7149 * deps.mk (unexalpha.o): Remove; unused.
7150
7151 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7152 * unexec.h: New file.
7153 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7154 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7155 Depend on unexec.h.
7156 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7157 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7158 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7159 Change as necessary to match prototype in unexec.h.
7160
7161 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7162 shadowing.
7163 (back_comment, skip_chars): Mark vars as initialized.
7164
7165 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7166 Rename locals to avoid shadowing.
7167
7168 * lread.c (read1): Rewrite so as not to use empty "else".
7169 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7170
7171 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7172
7173 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7174 warning when compiling print.c.
7175
7176 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7177 instead of using an uninitialized var.
7178 (font_sort_entities): Mark var as initialized.
7179
7180 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7181
7182 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7183 pointers to constants.
7184 (font_parse_fcname): Remove unused vars.
7185 (font_delete_unmatched): Now static.
7186 (font_get_spec): Remove; unused.
7187 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7188 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7189 Rename or move locals to avoid shadowing.
7190
7191 * fns.c (require_nesting_list, require_unwind): Now static.
7192 (Ffillarray): Rename locals to avoid shadowing.
7193
7194 * floatfns.c (domain_error2): Define only if needed.
7195 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7196
7197 * alloc.c (mark_backtrace): Move decl from here ...
7198 * lisp.h: ... to here, so that it can be checked.
7199
7200 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7201 (Fdefvar): Rewrite so as not to use empty "else".
7202 (lisp_indirect_variable): Name an expression,
7203 to avoid gcc -Wbad-function-cast warning.
7204 (Fdefvar): Rename locals to avoid shadowing.
7205
7206 * callint.c (quotify_arg, quotify_args): Now static.
7207 (Fcall_interactively): Rename locals to avoid shadowing.
7208 Use const pointer when appropriate.
7209
7210 * lisp.h (get_system_name, get_operating_system_release):
7211 Move decls here, to check interfaces.
7212 * process.c (get_operating_system_release): Move decl to lisp.h.
7213 * xrdb.c (get_system_name): Likewise.
7214 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7215 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7216 some of which prompt warnings from gcc -Wbad-function-cast.
7217 (Fformat_time_string, Fencode_time, Finsert_char):
7218 (Ftranslate_region_internal, Fformat):
7219 Rename or remove local vars to avoid shadowing.
7220 (Ftranslate_region_internal): Mark var as initialized.
7221
7222 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7223 avoid shadowing.
7224
7225 * lisp.h (eassert): Check that the argument compiles, even if
7226 ENABLE_CHECKING is not defined.
7227
7228 * data.c (Findirect_variable): Name an expression, to avoid
7229 gcc -Wbad-function-cast warning.
7230 (default_value, arithcompare, arith_driver, arith_error): Now static.
7231 (store_symval_forwarding): Rename local to avoid shadowing.
7232 (Fmake_variable_buffer_local, Fmake_local_variable):
7233 Mark variables as initialized.
7234 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7235
7236 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7237 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7238 Rename locals to avoid shadowing.
7239 (mark_stack): Move local variables into the #ifdef region where
7240 they're used.
7241 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7242 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7243 needed otherwise.
7244 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7245 (GC_STRING_CHARS): Remove; not used.
7246 (Fmemory_limit): Cast sbrk's returned value to char *.
7247
7248 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7249 avoids undefined behavior in theory.
7250
7251 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7252
7253 Use functions, not macros, for up- and down-casing (Bug#8254).
7254 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7255 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7256 to use the following functions instead of these macros.
7257 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7258 EMACS_INT, since callers assume the returned value fits in int.
7259 (upcase1): Likewise, for UPCASE_TABLE.
7260 (uppercasep, lowercasep, upcase): New static inline functions.
7261 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7262 the race-condition problem in the old DOWNCASE.
7263
7264 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7265 Rename locals to avoid shadowing.
7266 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7267 (regex_compile, re_search_2, re_match_2_internal):
7268 Remove unused local vars.
7269 (FREE_VAR): Rewrite so as not to use empty "else",
7270 which gcc can warn about.
7271 (regex_compile, re_match_2_internal): Mark locals as initialized.
7272 (RETALLOC_IF): Define only if needed.
7273 (WORDCHAR_P): Likewise. This one is never needed, but is used
7274 only in a comment talking about a compiler bug, so put inside
7275 the #if 0 of that comment.
7276 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7277 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7278 Remove; unused.
7279
7280 * search.c (boyer_moore): Rename locals to avoid shadowing.
7281 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7282 (PREV_CHAR_BOUNDARY): Likewise.
7283
7284 * search.c (simple_search): Remove unused var.
7285
7286 * dired.c (compile_pattern): Move decl from here ...
7287 * lisp.h: ... to here, so that it can be checked.
7288 (struct re_registers): New forward decl.
7289
7290 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7291
7292 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7293 All uses changed.
7294 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7295 Rename locals to avoid shadowing.
7296 (Fvertical_motion): Mark locals as initialized.
7297
7298 * casefiddle.c (casify_object, casify_region): Now static.
7299 (casify_region): Mark local as initialized.
7300
7301 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7302
7303 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7304 New macros, so that the caller can use some names other than
7305 gcpro1, gcpro2, etc.
7306 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7307 of the new macros.
7308 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7309 argument, for consistency with GCPRO2_VAR, etc: it is now the
7310 prefix of the variable, not the variable itself. All uses
7311 changed.
7312 * dired.c (directory_files_internal, file_name_completion):
7313 Rename locals to avoid shadowing.
7314
7315 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7316 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7317 dired.c's scmp function, had undefined behavior.
7318 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7319 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7320 * buffer.h: ... to here, because these macros use current_buffer,
7321 and the new implementation with inline functions needs to have
7322 current_buffer in scope now, rather than later when the macros
7323 are used.
7324 (downcase, upcase1): New static inline functions.
7325 (DOWNCASE, UPCASE1): Reimplement using these functions.
7326 This avoids undefined behavior in expressions like
7327 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7328 from race conditions in accessing the global variables
7329 case_temp1 and case_temp2.
7330 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7331 * lisp.h (case_temp1, case_temp2): Remove their decls.
7332 * character.h (ASCII_CHAR_P): Move from here ...
7333 * lisp.h: ... to here, so that the inline functions mentioned
7334 above can use them.
7335
7336 * dired.c (directory_files_internal_unwind): Now static.
7337
7338 * fileio.c (file_name_as_directory, directory_file_name):
7339 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7340 Now static.
7341 (file_name_as_directory): Use const pointers when appropriate.
7342 (Fexpand_file_name): Likewise. In particular, newdir might
7343 point at constant storage, so make it a const pointer.
7344 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7345 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7346 signedness issues.
7347 (Fset_file_times, Finsert_file_contents, auto_save_error):
7348 Rename locals to avoid shadowing.
7349
7350 * minibuf.c (choose_minibuf_frame_1): Now static.
7351 (Ftry_completion, Fall_completions): Rename or remove locals
7352 to avoid shadowing.
7353
7354 * marker.c (bytepos_to_charpos): Remove; unused.
7355
7356 * lisp.h (verify_bytepos, count_markers): New decls,
7357 so that gcc does not warn that these functions aren't declared.
7358
7359 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7360 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7361 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7362 (copy_text): Remove unused local var.
7363
7364 * filelock.c (within_one_second): Now static.
7365 (lock_file_1): Rename local to avoid shadowing.
7366
7367 * buffer.c (fix_overlays_before): Mark locals as initialized.
7368 (fix_start_end_in_overlays): Likewise. This function should be
7369 simplified by using pointers-to-pointers, but that's a different
7370 matter.
7371 (switch_to_buffer_1): Now static.
7372 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7373 (report_overlay_modification): Rename locals to avoid shadowing.
7374
7375 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7376 Fix pointer signedness issue.
7377 (sys_subshell): Mark local as volatile if checking for lint,
7378 to suppress a gcc -Wclobbered warning that does not seem to be right.
7379 (MAXPATHLEN): Define only if needed.
7380
7381 * process.c (serial_open, serial_configure): Move decls from here ...
7382 * systty.h: ... to here, so that they can be checked.
7383
7384 * fns.c (get_random, seed_random): Move extern decls from here ...
7385 * lisp.h: ... to here, so that they can be checked.
7386
7387 * sysdep.c (reset_io): Now static.
7388 (wait_for_termination_signal): Remove; unused.
7389
7390 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7391 (copy_keymap_item, append_key, push_text_char_description):
7392 Now static.
7393 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7394 (DENSE_TABLE_SIZE): Remove; unused.
7395 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7396 (describe_map_tree):
7397 Rename locals to avoid shadowing.
7398
7399 * keyboard.c: Declare functions static if they are not used elsewhere.
7400 (echo_char, echo_dash, cmd_error, top_level_2):
7401 (poll_for_input, handle_async_input): Now static.
7402 (read_char, kbd_buffer_get_event, make_lispy_position):
7403 (make_lispy_event, make_lispy_movement, apply_modifiers):
7404 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7405 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7406 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7407 (read_key_sequence, read_char): Mark locals as initialized.
7408 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7409
7410 * keyboard.h (make_ctrl_char): New decl.
7411 (mark_kboards): Move decl here ...
7412 * alloc.c (mark_kboards): ... from here.
7413
7414 * lisp.h (force_auto_save_soon): New decl.
7415
7416 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7417 (DEFINE_DUMMY_FUNCTION): New macro.
7418 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7419 Use it.
7420 (main): Add casts to avoid warnings
7421 if GCC considers string literals to be constants.
7422
7423 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7424
7425 * dbusbind.c: Pointer signedness fixes.
7426 (xd_signature, xd_append_arg, xd_initialize):
7427 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7428 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7429 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7430 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7431
7432 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7433 if GCC considers string literals to be constants.
7434 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7435
7436 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7437
7438 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7439 (print_preprocess, print_object): New macro to fix last change.
7440
7441 * print.c (print_preprocess): Don't forget font objects.
7442
7443 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7444
7445 * emacs.c (USAGE3): Doc fixes.
7446
7447 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7448
7449 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7450 structure.
7451
7452 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7453
7454 * lisp.h (VWindow_system, Qfile_name_history):
7455 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7456 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7457 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7458
7459 * w32select.c: Don't #include "keyboard.h".
7460 (run_protected): Add extern declaration for waiting_for_input.
7461
7462 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7463 * w32console.c (detect_input_pending, read_input_pending)
7464 (encode_terminal_code):
7465 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7466 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7467 (w32_system_caret_y, Qfile_name_history):
7468 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7469 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7470 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7471 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7472 * w32proc.c (Qlocal, report_file_error):
7473 * w32term.c (Vwindow_system, updating_frame):
7474 * w32uniscribe.c (initialized, uniscribe_font_driver):
7475 Remove unneeded extern declarations.
7476
7477 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7478
7479 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7480
7481 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7482
7483 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7484 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7485 These macros can no longer be used for assignment.
7486
7487 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7488 Assign struct members directly, instead of using BUF_BEGV etc.
7489 (record_buffer_markers, fetch_buffer_markers): New functions for
7490 recording and fetching special buffer markers.
7491 (set_buffer_internal_1, set_buffer_temp): Use them.
7492
7493 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7494
7495 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7496
7497 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7498 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7499
7500 * xdisp.c (hscroll_window_tree):
7501 (reconsider_clip_changes): Use PT instead of BUF_PT.
7502
7503 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7504
7505 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7506 $(EMACS_ROOT)/lib/intprops.h.
7507
7508 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7509
7510 Fix more problems found by GCC 4.5.2's static checks.
7511
7512 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7513 to unsigned char * to avoid compiler diagnostic.
7514 (xg_free_frame_widgets): Make it clear that a local variable is
7515 needed only if USE_GTK_TOOLTIP.
7516 (gdk_window_get_screen): Make it clear that this macro is needed
7517 only if USE_GTK_TOOLTIP.
7518 (int_gtk_range_get_value): New function, which avoids a diagnostic
7519 from gcc -Wbad-function-cast.
7520 (xg_set_toolkit_scroll_bar_thumb): Use it.
7521 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7522 diagnostic from gcc -Wbad-function-cast.
7523 (get_utf8_string, xg_get_file_with_chooser):
7524 Rename locals to avoid shadowing.
7525 (create_dialog): Move locals to avoid shadowing.
7526
7527 * xgselect.c (xg_select): Remove unused var.
7528
7529 * image.c (four_corners_best): Mark locals as initialized.
7530 (gif_load): Initialize transparent_p to zero (Bug#8238).
7531 Mark another local as initialized.
7532 (my_png_error, my_error_exit): Mark with NO_RETURN.
7533
7534 * image.c (clear_image_cache): Now static.
7535 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7536 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7537 (x_edge_detection): Remove unnecessary cast that
7538 gcc -Wbad-function-cast diagnoses.
7539 (gif_load): Fix pointer signedness.
7540 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7541 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7542
7543 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7544
7545 Improve quality of tests for time stamp overflow.
7546 For example, without this patch (encode-time 0 0 0 1 1
7547 1152921504606846976) returns the obviously-bogus value (-948597
7548 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7549 reports time overflow. See
7550 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7551 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7552 * editfns.c: Include limits.h and intprops.h.
7553 (TIME_T_MIN, TIME_T_MAX): New macros.
7554 (time_overflow): Move earlier, to before first use.
7555 (hi_time, lo_time): New functions, for an accurate test for
7556 out-of-range times.
7557 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7558 (Fget_internal_run_time): Don't assume time_t fits in int.
7559 (make_time): Use list2 instead of Fcons twice.
7560 (Fdecode_time): More accurate test for out-of-range times.
7561 (check_tm_member): New function.
7562 (Fencode_time): Use it, to test for out-of-range times.
7563 (lisp_time_argument): Don't rely on undefined left-shift and
7564 right-shift behavior when checking for time stamp overflow.
7565
7566 * editfns.c (time_overflow): New function, refactoring common code.
7567 (Fformat_time_string, Fdecode_time, Fencode_time):
7568 (Fcurrent_time_string): Use it.
7569
7570 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7571 * dired.c (make_time): Move to ...
7572 * editfns.c (make_time): ... here.
7573 * systime.h: Note the move.
7574
7575 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7576
7577 * fringe.c (update_window_fringes): Remove unused variables.
7578
7579 * unexmacosx.c (copy_data_segment): Also copy __got section.
7580 (Bug#8223)
7581
7582 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7583
7584 * termcap.c [MSDOS]: Include "msdos.h".
7585 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7586 Constify `char *' arguments and their references according to
7587 prototypes in tparam.h.
7588
7589 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7590
7591 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7592 Adapt all references accordingly.
7593
7594 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7595
7596 2011-03-11 Tom Tromey <tromey@redhat.com>
7597
7598 * buffer.c (syms_of_buffer): Remove obsolete comment.
7599
7600 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7601
7602 * termhooks.h (encode_terminal_code): Declare prototype.
7603
7604 * msdos.c (encode_terminal_code): Don't declare prototype.
7605
7606 * term.c (encode_terminal_code): Now external again, used by
7607 w32console.c and msdos.c.
7608
7609 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7610 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7611
7612 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7613
7614 Fix some minor problems found by GCC 4.5.2's static checks.
7615
7616 * fringe.c (update_window_fringes): Mark locals as initialized
7617 (Bug#8227).
7618 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7619
7620 * alloc.c (mark_fringe_data): Move decl from here ...
7621 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7622 to check its interface.
7623 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7624
7625 * fontset.c (free_realized_fontset): Now static.
7626 (Fset_fontset_font): Rename local to avoid shadowing.
7627 (fontset_font): Mark local as initialized.
7628 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7629
7630 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7631
7632 * xselect.c (x_disown_buffer_selections): Remove; not used.
7633 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7634 (x_own_selection, Fx_disown_selection_internal): Rename locals
7635 to avoid shadowing.
7636 (x_handle_dnd_message): Remove local to avoid shadowing.
7637
7638 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7639 so that the caller can use some name other than gcpro1.
7640 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7641 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7642 (Fx_backspace_delete_keys_p):
7643 Use them to avoid shadowing, and rename vars to avoid shadowing.
7644 (x_decode_color, x_set_name, x_window): Now static.
7645 (Fx_create_frame): Add braces to silence GCC warning.
7646 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7647 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7648 Remove unused locals.
7649 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7650 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7651 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7652 macros.
7653
7654 * xterm.h (x_mouse_leave): New decl.
7655
7656 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7657 Remove unused functions.
7658 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7659 (x_calc_absolute_position): Now static.
7660 (XTread_socket): Don't define label "out" unless it's used.
7661 Don't declare local "event" unless it's used.
7662 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7663 unless they are used.
7664 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7665 (x_fatal_error_signal): Remove; not used.
7666 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7667 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7668 (x_error_catcher, x_connection_closed, x_error_handler):
7669 (x_error_quitter, xembed_send_message, x_iconify_frame):
7670 (my_log_handler): Rename locals to avoid shadowing.
7671 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7672 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7673
7674 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7675 Rename or move locals to avoid shadowing.
7676 (tty_defined_color, merge_face_heights): Now static.
7677 (free_realized_faces_for_fontset): Remove; not used.
7678 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7679 does not deduce is never used uninitialized.
7680 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7681 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7682
7683 * terminal.c (store_terminal_param): Now static.
7684
7685 * xmenu.c (menu_highlight_callback): Now static.
7686 (set_frame_menubar): Remove unused local.
7687 (xmenu_show): Rename parameter to avoid shadowing.
7688 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7689 since they might point to immutable storage.
7690 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7691 since it's unused otherwise.
7692
7693 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7694 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7695 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7696 avoids a gcc -Wuninitialized diagnostic.
7697 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7698 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7699 does not deduce are never used uninitialized.
7700
7701 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7702
7703 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7704 * window.c (window_loop, size_window):
7705 (run_window_configuration_change_hook, enlarge_window): Likewise.
7706
7707 * window.c (display_buffer): Now static.
7708 (size_window): Mark variables that gcc -Wuninitialized
7709 does not deduce are never used uninitialized.
7710 * window.h (check_all_windows): New decl, to forestall
7711 gcc -Wmissing-prototypes diagnostic.
7712 * dispextern.h (bidi_dump_cached_states): Likewise.
7713
7714 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7715 shadowing.
7716 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7717 Include <limits.h>.
7718 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7719 and to avoid gcc -Wuninitialized warning.
7720 (load_charset_map): Mark variables that gcc -Wuninitialized
7721 does not deduce are never used uninitialized.
7722 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7723
7724 * coding.c (coding_set_source, coding_set_destination):
7725 Use "else { /* comment */ }" rather than "else /* comment */;"
7726 for clarity, and to avoid gcc -Wempty-body warning.
7727 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7728 a block, when the outer 'i' will do.
7729 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7730 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7731 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7732 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7733 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7734 Rename locals to avoid shadowing.
7735 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7736 * coding.c (emacs_mule_char, encode_invocation_designation):
7737 Now static, since they're not used elsewhere.
7738 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7739 (decode_coding_object, encode_coding_object, detect_coding_system):
7740 (decode_coding_emacs_mule): Mark variables that gcc
7741 -Wuninitialized does not deduce are never used uninitialized.
7742 (detect_coding_iso_2022): Initialize a local variable that might
7743 be used uninitialized. Leave a FIXME because it's not clear that
7744 this initialization is needed. (Bug#8211)
7745 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7746 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7747 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7748 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7749 Remove unused macros.
7750
7751 * category.c (hash_get_category_set): Remove unused local var.
7752 (copy_category_table): Now static, since it's not used elsewhere.
7753 * character.c (string_count_byte8): Likewise.
7754
7755 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7756 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7757
7758 * chartab.c (copy_sub_char_table): Now static, since it's not used
7759 elsewhere.
7760 (sub_char_table_ref_and_range, char_table_ref_and_range):
7761 Rename locals to avoid shadowing.
7762 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7763
7764 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7765 (BIDI_BOB): Remove unused macro.
7766
7767 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7768 deduce are never used uninitialized.
7769 * term.c (encode_terminal_code): Likewise.
7770
7771 * term.c (encode_terminal_code): Now static. Remove unused local.
7772
7773 * tparam.h: New file.
7774 * term.c, tparam.h: Include it.
7775 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7776 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7777 Move these decls to tparam.h, and make them agree with what
7778 is actually in tparam.c. The previous trick of using incompatible
7779 decls in different modules does not conform to the C standard.
7780 All callers of tparam changed to use tparam's actual API.
7781 * tparam.c (tparam1, tparam, tgoto):
7782 Use const pointers where appropriate.
7783
7784 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7785 * cm.h (struct cm): Likewise.
7786 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7787 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7788 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7789 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7790 (turn_on_face, init_tty): Likewise.
7791 * termchar.h (struct tty_display_info): Likewise.
7792
7793 * term.c (term_mouse_position): Rename local to avoid shadowing.
7794
7795 * alloc.c (mark_ttys): Move decl from here ...
7796 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7797
7798 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7799
7800 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7801
7802 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7803
7804 * search.c (compile_pattern_1): Remove argument regp, unused since
7805 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7806 (compile_pattern): Don't pass it.
7807
7808 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7809
7810 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7811 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7812 for ! HAVE_GTK3.
7813 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7814
7815 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7816
7817 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7818 gdk_window_get_screen, gdk_window_get_geometry,
7819 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7820 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7821 (xg_get_pixbuf_from_pixmap): New function.
7822 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7823 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7824 Call xg_get_pixbuf_from_pixmap instead of
7825 gdk_pixbuf_get_from_drawable.
7826 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7827 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7828 (xg_check_special_colors): Use GtkStyleContext and its functions
7829 for HAVE_GTK3.
7830 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7831 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7832 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7833 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7834 Call gtk_widget_get_preferred_size.
7835 (xg_frame_resized): gdk_window_get_geometry only takes 5
7836 parameters.
7837 (xg_win_to_widget, xg_event_is_for_menubar):
7838 Call gdk_x11_window_lookup_for_display.
7839 (xg_set_widget_bg): New function.
7840 (delete_cb): New function.
7841 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7842 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7843 (xg_set_background_color): Call xg_set_widget_bg.
7844 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7845 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7846 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7847 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7848 if ! HAVE_GTK3.
7849 (update_frame_tool_bar): Call gtk_widget_hide.
7850 (xg_initialize): Use GDK_KEY_g.
7851
7852 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7853 if ! HAVE_GTK3
7854 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7855
7856 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7857 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7858 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7859
7860 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7861
7862 * w32xfns.c (select_palette): Check success of RealizePalette against
7863 GDI_ERROR, not zero.
7864
7865 See ChangeLog.11 for earlier changes.
7866
7867 ;; Local Variables:
7868 ;; coding: utf-8
7869 ;; End:
7870
7871 Copyright (C) 2011 Free Software Foundation, Inc.
7872
7873 This file is part of GNU Emacs.
7874
7875 GNU Emacs is free software: you can redistribute it and/or modify
7876 it under the terms of the GNU General Public License as published by
7877 the Free Software Foundation, either version 3 of the License, or
7878 (at your option) any later version.
7879
7880 GNU Emacs is distributed in the hope that it will be useful,
7881 but WITHOUT ANY WARRANTY; without even the implied warranty of
7882 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7883 GNU General Public License for more details.
7884
7885 You should have received a copy of the GNU General Public License
7886 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.