1 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6 2012-06-08 Eli Zaretskii <eliz@gnu.org>
8 * alloc.c (allocate_vectorlike): Fix last change.
10 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
12 Block-based vector allocation of small vectors.
13 * lisp.h (struct vectorlike_header): New field `nbytes',
14 adjust comment accordingly.
15 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
16 to denote vector blocks. Adjust users (live_vector_p,
17 mark_maybe_pointer, valid_lisp_object_p) accordingly.
18 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
19 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
20 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
21 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
22 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
23 (roundup_size): New constant.
24 (struct vector_block): New data type.
25 (vector_blocks, vector_free_lists, zero_vector): New variables.
26 (all_vectors): Renamed to `large_vectors'.
27 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
28 (sweep_vectors): New functions.
29 (allocate_vectorlike): Return `zero_vector' as the only vector of
30 0 items. Allocate new vector from block if vector size is less than
31 or equal to VBLOCK_BYTES_MAX.
32 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
33 (init_alloc_once): Add call to init_vectors.
35 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
37 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
39 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
41 * doprnt.c (doprnt): Truncate multibyte char correctly.
42 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
43 would mishandle a string argument "Xc" if X was a multibyte
44 character of length 2: it would truncate after X's first byte
45 rather than including all of X.
47 2012-06-06 Chong Yidong <cyd@gnu.org>
49 * buffer.c (word_wrap): Doc fix.
51 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
53 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
55 2012-06-03 Glenn Morris <rgm@gnu.org>
57 * xdisp.c (tool-bar-style): Doc fix.
59 2012-06-03 Ulrich Müller <ulm@gentoo.org>
61 * Makefile.in (PAXCTL): Define.
62 (temacs$(EXEEXT)): Disable memory randomization for the temacs
63 binary via PaX flags if the paxctl utility is available.
64 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
65 Restore PaX flags to their default. (Bug#11398)
67 2012-06-03 Chong Yidong <cyd@gnu.org>
69 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
72 2012-06-03 Chong Yidong <cyd@gnu.org>
74 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
75 (note_mode_line_or_margin_highlight): If there is no help echo,
76 use mode-line-default-help-echo. Handle the case where the mouse
77 position is past the end of the mode line string.
79 * buffer.c (buffer_local_value_1): New function, split from
80 Fbuffer_local_value; can return Qunbound.
81 (Fbuffer_local_value): Use it.
82 (Vmode_line_format): Docstring tweaks.
84 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
86 * sysdep.c (system_process_attributes): Improve comment.
88 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
90 * keyboard.c: Export real-this-command to Elisp.
91 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
92 and DEFVAR it. Update all users.
94 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
96 * minibuf.c (Fassoc_string): Remove duplicate declaration.
98 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
99 Convert pctcpu and pctmem to Lisp float properly.
100 Let the compiler fold better, as 100.0/0x8000 is exact.
102 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
104 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
107 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
109 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
111 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
113 For a 'struct window', replace some Lisp_Object fields to
114 bitfields where appropriate, remove unused fields.
115 * window.h (struct window): Remove unused 'last_mark_x' and
116 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
117 change it's type from Lisp_Object to bitfield.
118 Change type of 'force_start', 'optional_new_start',
119 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
120 fields from Lisp_Object to bitfield. Adjust users accordingly.
122 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
124 Pacify gcc -Wdouble-precision when using Xaw.
125 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
126 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
127 Use 'float' consistently, rather than 'float' in most places
128 and 'double' in a couple of places.
130 2012-05-31 Eli Zaretskii <eliz@gnu.org>
132 * xdisp.c (handle_stop): Detect whether we have overlay strings
133 loaded by testing it->current.overlay_string_index to be
134 non-negative, instead of checking whether n_overlay_strings is
135 positive. (Bug#11587)
137 2012-05-31 Chong Yidong <cyd@gnu.org>
139 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
141 * doc.c (Fsubstitute_command_keys): Doc fix.
143 2012-05-31 Eli Zaretskii <eliz@gnu.org>
145 * search.c (search_buffer): Remove calls to
146 r_alloc_inhibit_buffer_relocation, as it is now called by
147 maybe_unify_char, which was the cause of relocation of buffer text
150 2012-05-31 Eli Zaretskii <eliz@gnu.org>
152 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
153 for the duration of call to load_charset, to avoid problems with
154 callers of maybe_unify_char that access buffer text through C
157 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
158 decrement the inhibition flag, instead of just setting or
161 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
163 Remove obsolete '#define static' cruft.
164 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
165 This #undef was "temporary" in 2000; it is no longer needed
166 now that '#define static' has gone away.
167 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
168 (gray_bitmap_bits): Remove; no longer needed.
169 All uses replaced with definiens.
170 * xterm.c: Include "bitmaps/gray.xbm".
172 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
174 Clean up __executable_start, monstartup when --enable-profiling.
175 The following changes affect the code only when profiling.
176 * dispnew.c (__executable_start): Rename from safe_bcopy.
177 Define only on platforms that need it.
178 * emacs.c: Include <sys/gmon.h> when profiling.
179 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
180 (__executable_start): Remove decl, since lisp.h does it now.
181 (safe_bcopy): Remove decl; no longer has that name.
182 (main): Coalesce #if into single bit of code, for simplicity.
183 Cast pointers to uintptr_t, since standard libraries want integers
185 * lisp.h (__executable_start): New decl.
187 2012-05-31 Glenn Morris <rgm@gnu.org>
189 * image.c (Fimagemagick_types): Doc fix.
191 2012-05-30 Jim Meyering <meyering@redhat.com>
193 * callproc.c (Fcall_process_region): Include directory component
194 in mkstemp error message (Bug#11586).
196 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
198 * alloc.c, lisp.h (make_pure_vector): Now static.
200 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
202 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
204 (Fautoload): Do the hash-doc more carefully.
205 * data.c (Fdefalias): Purify definition, except for keymaps.
206 (Qdefun): Move from eval.c.
207 * lisp.h (Qdefun): Remove.
208 * lread.c (read1): Tiny simplification.
210 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
212 Do not create empty overlays with the evaporate property (Bug#9642).
213 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
214 Bug#9642, but explicitly check that the buffer the overlay would
215 be moved to is live and rearrange lines to make sure that errors
216 will not put the overlay in an inconsistent state.
217 (Fdelete_overlay): Cosmetics.
219 2012-05-28 Eli Zaretskii <eliz@gnu.org>
221 * w32term.c (my_bring_window_to_top): New function.
222 (x_raise_frame): Use handle returned by DeferWindowPos, which
223 could be different from the original one.
224 Call my_bring_window_to_top instead of my_set_foreground_window.
227 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
228 by calling BringWindowToTop.
230 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
231 (WM_EMACS_END): Increase by one.
233 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
235 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
236 This avoids undefined behavior that might cause the eassert
237 to not catch an out-of-range value.
239 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
241 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
244 2012-05-27 Eli Zaretskii <eliz@gnu.org>
246 * bidi.c (bidi_mirror_char): Fix last change.
248 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
250 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
251 when referring to sectname field in printf format.
253 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
255 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
256 Only r_alloc_inhibit_buffer_relocation needed to be added;
257 the others were already declared.
259 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
260 before checking whether it's out of range. Put the check inside
262 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
264 2012-05-27 Ken Brown <kbrown@cornell.edu>
266 * callproc.c (Fcall_process): Restore a line that was accidentally
267 commented out in the 2011-02-13 change (bug#11547).
269 2012-05-27 Eli Zaretskii <eliz@gnu.org>
271 * lisp.h [REL_ALLOC]: Add prototypes for external functions
274 * buffer.c [REL_ALLOC]: Remove prototypes of
275 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
276 they are now on lisp.h.
278 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
280 * search.c (search_buffer): Use it to inhibit relocation of buffer
281 text while re_search_2 is doing its job, because re_search_2 is
282 passed C pointers to buffer text. (Bug#11519)
284 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
287 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
288 state after an additional call to move_it_in_display_line_to, keep
289 the values of it->max_ascent and it->max_descent found for the
291 (pos_visible_p): Revert the comparison against bottom_y to what it
292 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
295 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
297 Fix coding-related core dumps with gcc -ftrapv.
298 The code was computing A - B, where A and B are pointers, and B is
299 random garbage. This can lead to core dumps on platforms that
300 have special pointer registers, and it also leads to core dumps on
301 x86-64 when compiled with gcc -ftrapv. The fix is to compute
302 A - B only when B is initialized properly.
303 * coding.c (coding_set_source, coding_set_destination): Return void.
304 (coding_change_source, coding_change_destinations): New functions,
305 with the old behaviors of coding_set_source and coding_set_destination.
306 All callers that need an offset changed to use these new functions.
308 2012-05-26 Glenn Morris <rgm@gnu.org>
310 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
312 2012-05-26 Eli Zaretskii <eliz@gnu.org>
314 Extend mouse support on W32 text-mode console.
315 * xdisp.c (draw_row_with_mouse_face):
316 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
318 * w32console.c: Include window.h.
319 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
321 (initialize_w32_display): Initialize mouse-highlight data.
323 * w32inevt.c: Include termchar.h and window.h.
324 (do_mouse_event): Support mouse-autoselect-window. When the mouse
325 moves, call note_mouse_highlight. If help_echo changed, call
326 gen_help_event to produce help-echo message in the echo area.
327 Call clear_mouse_face if mouse_face_hidden is set in the mouse
330 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
332 * lread.c (read1): Simplify slightly to avoid an overflow warning
333 with GCC 4.7.0 on x86-64.
335 2012-05-26 Eli Zaretskii <eliz@gnu.org>
337 * bidi.c (bidi_mirror_char): Revert last change: an int is
338 definitely wide enough here.
340 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
342 Fix integer width and related bugs (Bug#9874).
343 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
344 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
345 (string_bytes, check_sblock, allocate_string_data):
346 (compact_small_strings, Fmake_bool_vector, make_string)
347 (make_unibyte_string, make_multibyte_string)
348 (make_string_from_bytes, make_specified_string)
349 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
350 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
353 (allocate_pseudovector):
354 Use int, not EMACS_INT, where int is wide enough.
355 (inhibit_garbage_collection, Fgarbage_collect):
356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
357 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
358 int might not be wide enough.
359 (bidi_cache_search, bidi_cache_find, bidi_init_it)
360 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
361 (bidi_at_paragraph_end, bidi_find_paragraph_start)
362 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
363 (bidi_level_of_next_char, bidi_move_to_visually_next):
364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
365 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
366 (Fkill_buffer, Fset_buffer_major_mode)
367 (advance_to_char_boundary, Fbuffer_swap_text)
368 (Fset_buffer_multibyte, overlays_at, overlays_in)
369 (overlay_touches_p, struct sortvec, record_overlay_string)
370 (overlay_strings, recenter_overlay_lists)
371 (adjust_overlays_for_insert, adjust_overlays_for_delete)
372 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
373 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
374 (Foverlay_recenter, last_overlay_modification_hooks_used)
375 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
377 (validate_region): Omit unnecessary test for b <= e,
378 since that's guaranteed by the previous test.
379 (adjust_overlays_for_delete): Avoid pos + length overflow.
380 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
381 (report_overlay_modification):
382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
383 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
384 Omit pointer cast, which isn't needed anyway, and doesn't work
385 after the EMACS_INT -> ptrdiff_t change.
386 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
387 * buffer.h: Adjust decls to match defn changes elsewhere.
388 (struct buffer_text, struct buffer):
389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
390 Use EMACS_INT, not int, where int might not be wide enough.
391 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
392 not int, to avoid needless 32-bit limit on 64-bit hosts.
393 (exec_byte_code): Use tighter memory-full test, one that checks
394 for alloca overflow. Don't compute the address of the object just
395 before an array, as that's not portable. Use EMACS_INT, not
396 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
397 * callint.c (Fcall_interactively):
398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
399 * callproc.c (call_process_kill, Fcall_process):
400 Don't assume pid_t fits into an Emacs fixnum.
401 (call_process_cleanup, Fcall_process, child_setup):
402 Don't assume pid_t fits into int.
403 (call_process_cleanup, Fcall_process, delete_temp_file)
404 (Fcall_process_region):
405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
406 (Fcall_process): Simplify handling of volatile integers.
407 Use int, not EMACS_INT, where int will do.
408 * casefiddle.c (casify_object, casify_region, operate_on_word)
409 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
411 (casify_object): Avoid integer overflow when overallocating buffer.
412 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
413 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
414 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
415 * category.h (CATEGORYP): Don't assume arg is nonnegative.
416 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
417 integers are now checked earlier. All uses replaced with XINT.
419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
420 For CCL_MapSingle, check that content and value are in int range.
421 (ccl_driver, Fregister_code_conversion_map):
422 Check that Vcode_version_map_vector is a vector.
423 (resolve_symbol_ccl_program): Check that vector header is in range.
424 Always copy the vector, so that we can check its contents reliably
425 now rather than having to recheck each instruction as it's being
426 executed. Check that vector words fit in 'int'.
427 (ccl_get_compiled_code, Fregister_ccl_program)
428 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
429 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
430 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
431 contents are in range.
432 (Fccl_execute_on_string): Check that status is in range.
433 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
434 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
435 Accept and return EMACS_INT, not int, because callers can pass values
437 (c_string_width, strwidth, lisp_string_width, chars_in_text)
438 (multibyte_chars_in_text, parse_str_as_multibyte)
439 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
440 (str_as_unibyte, str_to_unibyte, string_count_byte8)
441 (string_escape_byte8, Fget_byte):
442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
443 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
444 avoid mishandling large integers.
445 * character.h: Adjust decls to match defn changes elsewhere.
446 * charset.c (load_charset_map_from_file, find_charsets_in_text)
447 (Ffind_charset_region):
448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
449 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
450 (load_charset_map_from_vector, Fdefine_charset_internal):
451 Don't assume fixnum fits in int.
452 (load_charset_map_from_vector, Fmap_charset_chars):
453 Remove now-unnecessary CHECK_NATNUMs.
454 (Fdefine_charset_internal): Check ranges here, more carefully.
455 Don't rely on undefined behavior with signed left shift overflow.
456 Don't assume unsigned int fits into fixnum, or that fixnum fits
457 into unsigned int. Don't require max_code to be a valid fixnum;
458 that's not true for gb10830 4-byte on a 32-bit host. Allow
459 invalid_code to be a cons, for the same reason. Require code_offset
460 to be a character. Avoid int overflow if max_char is close
462 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
463 this is intended anyway and avoids some undefined behavior.
464 (load_charset_map): Pass unsigned, not int, as 2nd arg of
465 INDEX_TO_CODE_POINT, as that's what it expects.
466 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
467 * charset.h (DECODE_CHAR): Return int, not unsigned;
468 this is what was intended anyway, and it avoids undefined behavior.
469 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
470 integer-overflow issues.
471 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
472 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
473 where the argument is EMACS_INT, and this behavior is not intended.
474 * chartab.c (Fmake_char_table, Fset_char_table_range)
475 (uniprop_get_decoder, uniprop_get_encoder):
476 Don't assume fixnum fits in int.
477 * cmds.c (move_point): New function, that does the gist of
478 Fforward_char and Fbackward_char, but does so while checking
479 for integer overflow more accurately.
480 (Fforward_char, Fbackward_char): Use it.
481 (Fforward_line, Fend_of_line, internal_self_insert)
482 (internal_self_insert):
483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
484 Fix a FIXME, by checking for integer overflow when calculating
485 target_clm and actual_clm.
486 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
487 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
488 (ASSURE_DESTINATION, coding_alloc_by_realloc)
489 (coding_alloc_by_making_gap, alloc_destination)
490 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
491 (encode_coding_utf_16, detect_coding_emacs_mule)
492 (decode_coding_emacs_mule, encode_coding_emacs_mule)
493 (detect_coding_iso_2022, decode_coding_iso_2022)
494 (encode_invocation_designation, encode_designation_at_bol)
495 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
496 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
497 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
498 (encode_coding_ccl, encode_coding_raw_text)
499 (detect_coding_charset, decode_coding_charset)
500 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
501 (produce_composition, produce_charset, produce_annotation)
502 (decode_coding, handle_composition_annotation)
503 (handle_charset_annotation, consume_chars, decode_coding_gap)
504 (decode_coding_object, encode_coding_object, detect_coding_system)
505 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
506 (code_convert_region, code_convert_string)
507 (Fdefine_coding_system_internal)
508 (coding_set_source, coding_set_destination):
509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
510 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
511 (Fdefine_coding_system_internal):
512 Don't assume fixnums fit in int.
513 (decode_coding_gap, decode_coding_object, encode_coding_object)
514 (Fread_coding_system, Fdetect_coding_region)
515 (Funencodable_char_position, Fcheck_coding_systems_region)
516 (get_translation, handle_composition_annotation, consume_chars):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (consume_chars): Rewrite to not calculate an address outside buffer.
519 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
520 Don't access memory outside of the args array.
521 (Fdefine_coding_system_internal): Check for charset-id overflow.
522 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
523 result of ENCODE_CHAR.
524 * coding.h: Adjust decls to match defn changes elsewhere.
525 (struct coding_system):
526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
527 * composite.c (get_composition_id, find_composition)
528 (run_composition_function, update_compositions)
529 (compose_text, composition_gstring_put_cache)
530 (composition_gstring_p, composition_gstring_width)
531 (fill_gstring_header, fill_gstring_body, autocmp_chars)
532 (composition_compute_stop_pos, composition_reseat_it)
533 (composition_update_it, struct position_record)
534 (find_automatic_composition, composition_adjust_point)
535 (Fcomposition_get_gstring, Ffind_composition_internal):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (update_compositions):
538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
539 * composite.h: Adjust decls to match defn changes elsewhere.
540 (struct composition):
541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
542 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
543 Do not attempt to compute the address of the object just before a
544 buffer; this is not portable.
546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
547 (Faset): Use int, not EMACS_INT, where int is wide enough.
548 (Fstring_to_number): Don't assume fixnums fit in int.
549 (Frem): Don't assume arg is nonnegative.
550 * dbusbind.c (xd_append_arg): Check for integers out of range.
551 (Fdbus_call_method): Don't overflow the timeout int.
552 (extract_signed, extract_unsigned): New functions.
553 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
554 (xd_get_connection_references): Return ptrdiff_t, not int.
556 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
558 Use int, not unsigned, where the dbus API uses int.
559 (Fdbus_message_internal): Don't overflow mtype.
560 (syms_of_dbusbind): Allocate right-sized buffer for integers.
561 * dired.c (directory_files_internal, file_name_completion, scmp)
562 (file_name_completion_stat):
563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
564 (file_name_completion): Don't overflow matchcount.
565 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
566 * dispextern.h: Adjust decls to match defn changes elsewhere.
567 (struct text_pos, struct glyph, struct bidi_saved_info)
568 (struct bidi_string_data, struct bidi_it, struct composition_it)
570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
571 (struct display_pos, struct composition_it, struct it):
572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
573 * dispnew.c (increment_matrix_positions)
574 (increment_row_positions, mode_line_string)
575 (marginal_area_string):
576 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
577 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
579 (duration_to_sec_usec): New function, to check for overflow better.
580 (Fsleep_for, sit_for): Use it.
581 * doc.c (get_doc_string, store_function_docstring):
582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
583 (get_doc_string, Fsnarf_documentation):
584 Use int, not EMACS_INT, where int is wide enough.
586 Use SAFE_ALLOCA, not alloca.
587 Check for overflow when converting EMACS_INT to off_t.
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
591 Don't assume uid_t fits into fixnum.
592 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
593 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
594 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
595 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
596 (general_insert_function)
597 (Finsert_char, make_buffer_string, make_buffer_string_both)
598 (update_buffer_properties, Fbuffer_substring)
599 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
600 (Fsubst_char_in_region, check_translation)
601 (Ftranslate_region_internal, save_restriction_restore, Fformat)
602 (transpose_markers, Ftranspose_regions):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
604 (clip_to_bounds): Move to lisp.h as an inline function).
605 (Fconstrain_to_field): Don't assume integers are nonnegative.
606 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
607 (Fsubst_char_in_region, Fsave_restriction):
608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
609 (Femacs_pid): Don't assume pid_t fits into fixnum.
610 (lo_time): Use int, not EMACS_INT, when int suffices.
611 (lisp_time_argument): Check for usec out of range.
612 (Fencode_time): Don't assume fixnum fits in int.
613 (Fuser_login_name, Fuser_full_name): Signal an error
614 if a uid argument is out of range, rather than relying on
616 (Fformat_time_string): Remove now-unnecessary check.
617 lisp_time_argument checks for out-of-range usec now.
618 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
619 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
620 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
621 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
622 (init_cmdargs, Fdump_emacs):
623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
624 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
625 the bottom (typically) 32 bits of the fixnum.
626 * eval.c (specpdl_size, call_debugger):
627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
628 (when_entered_debugger, Fbacktrace_debug):
629 Don't assume fixnum can fit in int.
630 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
631 the object just before a buffer; this is not portable.
632 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
633 (grow_specpdl, unbind_to):
634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
635 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
636 (grow_specpdl): Simplify allocation by using xpalloc.
637 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
638 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
639 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
640 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
641 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
644 (Fcopy_file, non_regular_nbytes, read_non_regular)
645 (Finsert_file_contents):
646 Use int, not EMACS_INT, where int is wide enough.
647 (READ_BUF_SIZE): Verify that it fits in int.
648 (Finsert_file_contents): Check that counts are in proper range,
649 rather than assuming fixnums fit into ptrdiff_t etc.
650 Don't assume fixnums fit into int.
651 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
652 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
653 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
654 (string_char_to_byte, string_byte_to_char)
655 (string_make_multibyte, string_to_multibyte)
656 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
657 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
658 (substring_both, Fdelete, internal_equal, Ffillarray)
659 (Fclear_string, mapcar1)
660 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
661 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
662 (larger_vector, make_hash_table, maybe_resize_hash_table)
663 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
664 (Fmaphash, secure_hash):
665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
666 (concat): Check for string index and length overflow.
667 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
670 (larger_vector): New API (vec, incr_min, size_max) replaces old
671 one (vec, new_size, init). This catches size overflow.
672 INIT was removed because it was always Qnil.
674 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
675 the upper bound on a hash table index size.
676 (make_hash_table, maybe_resize_hash_table): Use it.
677 (secure_hash): Computer start_byte and end_byte only after
678 they're known to be in ptrdiff_t range.
679 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
680 (Ffont_get_glyphs, Ffont_at):
681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
682 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
683 (Flist_fonts, Fopen_font):
684 Don't assume fixnum can fit in int.
685 (check_gstring): Don't assume index can fit in int.
686 (font_match_p): Check that fixnum is a character, not a nonnegative
687 fixnum, since the later code needs to stuff it into an int.
688 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
689 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
690 conversion overflow issues.
691 (Fopen_font): Check for integer out of range.
692 (Ffont_get_glyphs): Don't assume index can fit in int.
693 * font.h: Adjust decls to match defn changes elsewhere.
694 * fontset.c (reorder_font_vector): Redo score calculation to avoid
696 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
697 printmax_t, where ptrdiff_t is wide enough.
698 (Finternal_char_font):
699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
700 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
701 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
702 (Fset_frame_position, x_set_frame_parameters)
703 (x_set_line_spacing, x_set_border_width)
704 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
705 Check that fixnums are in proper range for system types.
706 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
708 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
709 Use SAFE_ALLOCA_LISP, not alloca.
710 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
711 intptr_t is wide enough.
712 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
713 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
714 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
715 Check for fixnum out of range.
716 * ftfont.c (ftfont_list): Don't assume index fits in int.
717 Check that fixnums are in proper range for system types.
718 (ftfont_shape_by_flt):
719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
720 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
722 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
723 Check that fixnums are in proper range for system types.
724 * gnutls.h: Adjust decls to match defn changes elsewhere.
725 * gtkutil.c (xg_dialog_run):
726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
727 (update_frame_tool_bar):
728 Check that fixnums are in proper range for system types.
729 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
730 (lookup_image): Check that fixnums are in range for system types.
731 * indent.c (last_known_column, last_known_column_point):
732 (current_column_bol_cache):
733 (skip_invisible, current_column, check_display_width):
734 (check_display_width, scan_for_column, current_column_1)
735 (Findent_to, Fcurrent_indentation, position_indentation)
736 (indented_beyond_p, Fmove_to_column, compute_motion):
737 (Fcompute_motion, Fvertical_motion):
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
739 (last_known_column_modified): Use EMACS_INT, not int.
740 (check_display_width):
742 Check that fixnums and floats are in proper range for system types.
743 (compute_motion): Don't assume index or fixnum fits in int.
744 (compute_motion, Fcompute_motion):
745 Use int, not EMACS_INT, when it is wide enough.
746 (vmotion): Omit local var start_hpos that is always 0; that way
747 we don't need to worry about overflow in expressions involving it.
748 * indent.h: Adjust decls to match defn changes elsewhere.
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 Use int, not EMACS_INT, where int is wide enough.
752 Remove unused members ovstring_chars_done and tab_offset;
754 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
755 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
756 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
757 (make_gap, copy_text, insert, insert_and_inherit)
758 (insert_before_markers, insert_before_markers_and_inherit)
759 (insert_1, count_combining_before, count_combining_after)
760 (insert_1_both, insert_from_string)
761 (insert_from_string_before_markers, insert_from_string_1)
762 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
763 (adjust_after_replace, adjust_after_insert, replace_range)
764 (replace_range_2, del_range, del_range_1, del_range_byte)
765 (del_range_both, del_range_2, modify_region)
766 (prepare_to_modify_buffer, signal_before_change)
767 (signal_after_change, Fcombine_after_change_execute):
768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
769 * intervals.c (traverse_intervals, rotate_right, rotate_left)
770 (balance_an_interval, split_interval_right, split_interval_left)
771 (find_interval, next_interval, update_interval)
772 (adjust_intervals_for_insertion, delete_node, delete_interval)
773 (interval_deletion_adjustment, adjust_intervals_for_deletion)
774 (static_offset_intervals, offset_intervals)
775 (merge_interval_right, merge_interval_left, make_new_interval)
776 (graft_intervals_into_buffer, temp_set_point_both)
777 (temp_set_point, set_point, adjust_for_invis_intang)
778 (set_point_both, move_if_not_intangible, get_property_and_range)
779 (get_local_map, copy_intervals, copy_intervals_to_string)
780 (compare_string_intervals, set_intervals_multibyte_1):
781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
782 * intervals.h: Adjust decls to match defn changes elsewhere.
784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
785 * keyboard.c (this_command_key_count, this_single_command_key_start)
786 (before_command_key_count, before_command_echo_length, echo_now)
787 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
788 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
789 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
790 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
792 (last_non_minibuf_size, last_point_position, echo_truncate)
793 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
794 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
795 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
796 (stuff_buffered_input):
797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
798 (last_auto_save, command_loop_1, read_char):
799 Use EMACS_INT, not int, to avoid integer overflow.
800 (record_char): Avoid overflow in total_keys computation.
801 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
802 * keyboard.h: Adjust decls to match defn changes elsewhere.
803 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
804 (Fkey_description, Fdescribe_vector, Flookup_key):
805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
806 (click_position): New function, to check that positions are in range.
807 (Fcurrent_active_maps):
809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
810 (Faccessible_keymaps, Fkey_description):
811 (preferred_sequence_p):
812 Don't assume fixnum can fit into int.
813 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
814 Check for integer overflow in size calculations.
815 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
816 avoid mishandling large integers.
817 * lisp.h: Adjust decls to match defn changes elsewhere.
818 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
819 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
820 (struct Lisp_Marker):
821 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
822 (clip_to_bounds): Now an inline function, moved here from editfns.c.
823 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
824 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
826 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
827 Assume the arg has valid form, since it always does.
828 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
829 unsigned integer system type.
830 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
831 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
833 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
834 (duration_to_sec_usec): New decl.
835 * lread.c (read_from_string_index, read_from_string_index_byte)
836 (read_from_string_limit, readchar, unreadchar, openp)
837 (read_internal_start, read1, oblookup):
838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
839 (Fload, readevalloop, Feval_buffer, Feval_region):
840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
841 (openp): Check for out-of-range argument to 'access'.
842 (read1): Use int, not EMACS_INT, where int is wide enough.
843 Don't assume fixnum fits into int.
844 Fix off-by-one error that can read outside a buffer.
845 (read_filtered_event): Use duration_to_sec_usec
846 to do proper overflow checking on durations.
847 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
849 (Fexecute_kbd_macro):
850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
851 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
852 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
853 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
854 (set_marker_both, set_marker_restricted_both, marker_position)
855 (marker_byte_position, Fbuffer_has_markers_at):
856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
857 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
858 * menu.c (ensure_menu_items): Rename from grow_menu_items.
859 It now merely ensures that the menu is large enough, without
860 necessarily growing it, as this avoids some integer overflow issues.
862 (keymap_panes, parse_single_submenu, Fx_popup_menu):
863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
864 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
865 Use SAFE_ALLOCA_LISP, not alloca.
866 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
867 to EMACS_INT. Check that fixnums are in proper range for system types.
868 * minibuf.c (minibuf_prompt_width, string_to_object)
869 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
870 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
872 (get_minibuffer, read_minibuf_unwind):
873 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
874 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
875 this simplifies overflow checking. All callers changed.
876 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
879 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
880 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
881 Check that fixnums are in proper range for system types.
882 (Fx_create_frame, Fx_show_tip):
883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
884 * nsfont.m (ns_findfonts, nsfont_list_family):
885 Don't assume fixnum fits in long.
886 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
888 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
890 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
892 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
893 (PRINTDECLARE, PRINTPREPARE):
894 (strout, print_string):
895 (print, print_preprocess, print_check_string_charset_prop)
897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
899 (temp_output_buffer_setup, Fprin1_to_string, print_object):
900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
901 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
902 (printchar, strout): Use xpalloc to catch size calculation overflow.
903 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
904 (print_error_message): Use SAFE_ALLOCA, not alloca.
905 (print_object): Use int, not EMACS_INT, where int is wide enough.
906 (print_depth, new_backquote_output, print_number_index):
907 Use ptrdiff_t, not int, where int might not be wide enough.
908 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
909 (Fset_process_window_size, Fformat_network_address)
910 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
912 Check that fixnums are in proper range for system types.
913 (Fsignal_process): Simplify by avoiding a goto.
914 Check for process-ids out of pid_t range rather than relying on
916 (process_tick, update_tick): Use EMACS_INT, not int.
917 (Fformat_network_address, read_process_output, send_process)
918 (Fprocess_send_region, status_notify):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
921 (wait_reading_process_output, read_process_output, exec_sentinel):
922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
923 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
924 (Faccept_process_output): Use duration_to_sec_usec to do proper
925 overflow checking on durations.
926 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
927 Don't assume pid_t fits in int.
928 * process.h (struct Lisp_Process): Members tick and update_tick
929 are now of type EMACS_INT, not int.
930 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
931 configured --with-wide-int.
932 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
933 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
934 * search.c (looking_at_1, string_match_1):
935 (fast_string_match, fast_c_string_match_ignore_case)
936 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
937 (scan_newline, find_before_next_newline, search_command)
938 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
939 (set_search_regs, wordify):
942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
943 (string_match_1, search_buffer, set_search_regs):
945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
946 (wordify): Check for overflow in size calculation.
947 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
948 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
949 Check that fixnums are in proper range for system types.
950 * sound.c (struct sound_device)
951 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
953 (Fplay_sound_internal):
954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
955 * syntax.c (struct lisp_parse_state, find_start_modiff)
956 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
957 (Fparse_partial_sexp):
958 Don't assume fixnums can fit in int.
959 (struct lisp_parse_state, find_start_pos, find_start_value)
960 (find_start_value_byte, find_start_begv)
961 (update_syntax_table, char_quoted, dec_bytepos)
962 (find_defun_start, prev_char_comend_first, back_comment):
963 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
964 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
966 (Finternal_describe_syntax_value): Check that match_lisp is a
967 character, not an integer, since the code stuffs it into int.
968 (scan_words, scan_sexps_forward):
969 Check that fixnums are in proper range for system types.
971 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
972 (scan_sexps_forward):
973 Use CHARACTERP, not INTEGERP, since the value must fit into int.
974 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
975 * syntax.h: Adjust decls to match defn changes elsewhere.
977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
978 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
979 MOST_POSITIVE_FIXNUM.
980 * sysdep.c (wait_for_termination_1, wait_for_termination)
981 (interruptible_wait_for_termination, mkdir):
982 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
983 (emacs_read, emacs_write):
984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
985 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
986 and double all fit in int.
987 * term.c (set_tty_color_mode):
988 Check that fixnums are in proper range for system types.
989 * termhooks.h (struct input_event):
990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
991 * textprop.c (validate_interval_range, interval_of)
992 (Fadd_text_properties, set_text_properties_1)
993 (Fremove_text_properties, Fremove_list_of_text_properties)
994 (Ftext_property_any, Ftext_property_not_all)
995 (copy_text_properties, text_property_list, extend_property_ranges)
996 (verify_interval_modification):
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 (Fnext_single_char_property_change)
999 (Fprevious_single_char_property_change):
1000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1001 (copy_text_properties):
1002 Check for integer overflow in index calculation.
1003 * undo.c (last_boundary_position, record_point, record_insert)
1004 (record_delete, record_marker_adjustment, record_change)
1005 (record_property_change):
1006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1007 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1009 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1010 (Fx_hide_tip, Fx_file_dialog):
1011 * w32menu.c (set_frame_menubar):
1012 Use ptrdiff_t, not int, for consistency with rest of code.
1013 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1014 (select_window, Fdelete_other_windows_internal)
1015 (window_scroll_pixel_based, window_scroll_line_based)
1016 (Frecenter, Fset_window_configuration):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (Fset_window_hscroll, run_window_configuration_change_hook)
1019 (set_window_buffer, temp_output_buffer_show, scroll_command)
1020 (Fscroll_other_window, Frecenter):
1021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1022 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1023 Don't assume fixnum fits in int.
1024 (Fset_window_scroll_bars):
1025 Check that fixnums are in proper range for system types.
1026 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1027 (string_pos, c_string_pos, number_of_chars, init_iterator)
1028 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1029 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1030 (compute_display_string_end, handle_face_prop)
1031 (face_before_or_after_it_pos, handle_invisible_prop)
1032 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1033 (display_prop_intangible_p, string_buffer_position_lim)
1034 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1035 (get_overlay_strings_1, get_overlay_strings)
1036 (iterate_out_of_display_property, forward_to_next_line_start)
1037 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1038 (get_next_display_element, set_iterator_to_next)
1039 (get_visually_first_element, compute_stop_pos_backwards)
1040 (handle_stop_backwards, next_element_from_buffer)
1041 (move_it_in_display_line_to, move_it_in_display_line)
1042 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1043 (add_to_log, message_dolog, message_log_check_duplicate)
1044 (message2, message2_nolog, message3, message3_nolog
1045 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1046 (current_message_1, truncate_echo_area, truncate_message_1)
1047 (set_message, set_message_1, store_mode_line_noprop)
1048 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1049 (text_outside_line_unchanged_p, check_point_in_composition)
1050 (reconsider_clip_changes)
1051 (redisplay_internal, set_cursor_from_row, try_scrolling)
1052 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1053 (redisplay_window, find_last_unchanged_at_beg_row)
1054 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1055 (trailing_whitespace_p, find_row_edges, display_line)
1056 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1057 (display_mode_element, store_mode_line_string)
1058 (pint2str, pint2hrstr, decode_mode_spec)
1059 (display_count_lines, display_string, draw_glyphs)
1060 (x_produce_glyphs, x_insert_glyphs)
1061 (rows_from_pos_range, mouse_face_from_buffer_pos)
1062 (fast_find_string_pos, mouse_face_from_string_pos)
1063 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1065 (safe_call, init_from_display_pos, handle_fontified_prop)
1066 (handle_single_display_spec, load_overlay_strings)
1067 (with_echo_area_buffer, setup_echo_area_for_printing)
1068 (display_echo_area, echo_area_display)
1069 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1070 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1071 (redisplay_window, dump_glyph_row, display_mode_line)
1072 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1073 (handle_display_spec, display_prop_string_p):
1074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1075 (handle_single_display_spec, build_desired_tool_bar_string)
1076 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1077 (get_specified_cursor_type):
1078 Check that fixnums are in proper range for system types.
1079 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1080 (Flookup_image_map):
1081 Don't assume fixnums fit in int.
1082 (compare_overlay_entries):
1083 Avoid mishandling comparisons due to subtraction overflow.
1084 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1085 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1086 (handle_tool_bar_click):
1087 Use int, not unsigned, since we prefer signed and the signedness
1088 doesn't matter here.
1089 (get_next_display_element, next_element_from_display_vector):
1090 Use int, not EMACS_INT, when int is wide enough.
1091 (start_hourglass): Use duration_to_sec_usec to do proper
1092 overflow checking on durations.
1093 * xfaces.c (Fbitmap_spec_p):
1094 Check that fixnums are in proper range for system types.
1095 (compare_fonts_by_sort_order):
1096 Avoid mishandling comparisons due to subtraction overflow.
1097 (Fx_family_fonts, realize_basic_faces):
1098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1100 Don't assume fixnum fits in int.
1101 Use SAFE_ALLOCA_LISP, not alloca.
1102 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1103 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1104 (face_at_buffer_position, face_for_overlay_string)
1105 (face_at_string_position):
1106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1107 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1108 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1110 Check that fixnums are in proper range for system types.
1111 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1112 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1114 (Fx_change_window_property): Don't assume fixnums fit in int.
1115 * xfont.c (xfont_chars_supported):
1116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1117 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1118 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1120 * xml.c (parse_region):
1121 * xrdb.c (magic_file_p):
1122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1123 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1124 (x_get_local_selection, x_reply_selection_request)
1125 (x_handle_selection_request, wait_for_property_change):
1126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1127 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1128 short is wide enough.
1129 (x_send_client_event): Don't assume fixnum fits in int.
1130 * xterm.c (x_x_to_emacs_modifiers):
1131 Don't assume EMACS_INT overflows nicely into int.
1132 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1134 (handle_one_xevent): NATNUMP can eval its arg twice.
1135 (x_connection_closed):
1136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1137 * xterm.h: Adjust decls to match defn changes elsewhere.
1138 (struct scroll_bar): Use struct vectorlike_header
1139 rather than rolling our own approximation.
1140 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1142 2012-05-25 Glenn Morris <rgm@gnu.org>
1144 * lisp.mk (lisp): Update for more files being compiled now.
1146 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1148 * lread.c: Remove `read_pure' which makes no difference.
1149 (read_pure): Remove var.
1150 (unreadpure): Remove function.
1151 (readevalloop): Don't call read_list with -1 flag.
1152 (read1, read_vector): Don't test read_pure any more.
1153 (read_list): Simplify.
1155 * fileio.c, character.h: Minor style tweaks.
1157 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1159 * window.h (clip_changed): Remove useless declaration.
1161 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1163 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1164 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1166 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1169 This directory predates autoconf and is no longer needed nowadays.
1170 Move its few remaining bits of functionality to where they're needed.
1171 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1172 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1173 * m/template.h: Remove.
1174 * Makefile.in (M_FILE): Remove. All uses removed.
1175 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1176 * lisp.h (USE_LSB_TAG):
1177 * mem-limits.h (EXCEEDS_LISP_PTR):
1178 Use VAL_MAX, not VALBITS, in #if.
1179 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1180 (EMACS_UINT): Define unconditionally now.
1181 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1182 (BITS_PER_EMACS_INT): New constants, replacing
1183 what used to be in config.h, but not useful in #if.
1184 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1185 define them any more.
1186 (VAL_MAX): New macro.
1188 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1189 BITS_PER_EMACS_INT, in #if.
1190 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1191 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1192 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1193 * s/ms-w32.h (DATA_START):
1194 Move here from removed file m/intel386.h.
1195 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1196 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1198 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1200 Assume C89 or later.
1201 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1202 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1204 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1205 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1206 * textprop.c, tparam.c (NULL): Remove.
1207 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1208 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1209 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1210 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1211 * xterm.c (input_signal_count): Assume volatile works.
1213 2012-05-21 Ken Brown <kbrown@cornell.edu>
1215 * xgselect.c (xg_select): Fix first argument in call to 'select'
1218 2012-05-20 Ken Brown <kbrown@cornell.edu>
1220 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1221 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1223 2012-05-19 Ken Brown <kbrown@cornell.edu>
1225 * xfns.c (x_in_use): Remove `static' qualifier.
1226 * xterm.h (x_in_use): Declare.
1227 * xgselect.c: Include xterm.h.
1228 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1229 and `display_arg' (bug#9754).
1231 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1233 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1235 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1236 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1238 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1240 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1242 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1243 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1245 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1246 reference to image_cache->refcount.
1247 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1249 2012-05-17 Juri Linkov <juri@jurta.org>
1251 * search.c (Fword_search_regexp, Fword_search_backward)
1252 (Fword_search_forward, Fword_search_backward_lax)
1253 (Fword_search_forward_lax): Move functions to isearch.el
1254 (bug#10145, bug#11381).
1256 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1258 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1260 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1262 * lread.c (init_obarray): Declare Qt and Qnil as special.
1264 2012-05-14 Glenn Morris <rgm@gnu.org>
1266 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1267 Put "libexec" before "bin", for the sake of init_callproc_1.
1269 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1271 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1273 * unexaix.c: Port to more-recent AIX compilers.
1274 (report_error, report_error_1, make_hdr, copy_sym)
1275 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1276 Make arguments const char *, not char *, to avoid violations of C
1277 standard and to fix some AIX warnings reported by Gilles Pion.
1279 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1281 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1282 already have overlays loaded.
1283 (handle_single_display_spec): Before returning without displaying
1284 fringe bitmap, synchronize the bidi iterator with the main display
1285 iterator, by calling iterate_out_of_display_property.
1286 (iterate_out_of_display_property): Detect buffer iteration by
1287 testing that it->string is a Lisp string.
1288 (get_next_display_element): When the current object is exhausted,
1289 and there's something on it->stack, call set_iterator_to_next to
1290 proceed with what's on the stack, instead of returning zero.
1291 (set_iterator_to_next): If called at the end of a Lisp string,
1292 proceed to consider_string_end without incrementing string
1293 position. Don't increment display vector index past the end of
1294 the display vector. (Bug#11417)
1295 (pos_visible_p): Don't report a position visible when move_it_to
1296 stopped at the last line of window, which happens to be scanned
1297 backwards by the bidi iteration. (Bug#11464)
1299 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1301 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1302 and right-margin display specs even if the spec is invalid or we
1303 are on a TTY, and thus unable to display on the fringes.
1304 That's because the text with the property will not be displayed anyway,
1305 so we need to signal to the caller that this is a "replacing"
1306 display spec. This fixes display when the spec is invalid or we
1309 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1311 * unexaix.c (make_hdr): Fix typo in prototype.
1312 This bug broke the build on AIX. Problem reported by Gilles Pion.
1314 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1316 * keyboard.c (kbd_buffer_get_event): Read special events also in
1317 batch mode. (Bug#11415)
1319 2012-05-12 Glenn Morris <rgm@gnu.org>
1321 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1323 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1325 * lisp.mk (lisp): Add newcomment.elc.
1327 2012-05-12 Glenn Morris <rgm@gnu.org>
1329 * Makefile.in (MKDIR_P): New, set by configure.
1330 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1332 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1334 Remove unused function hourglass_started.
1335 * dispextern.h (hourglass_started):
1336 * w32fns.c (hourglass_started):
1337 * xdisp.c (hourglass_started): Remove.
1339 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1341 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1342 Update dependencies.
1344 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1346 * xgselect.c (xg_select): Put maxfds+1 into a var.
1347 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1349 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1351 2012-05-10 Dave Abrahams <dave@boostpro.com>
1353 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1354 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1356 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1358 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1359 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1360 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1361 Initialize xd_registered_buses.
1363 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1365 Untag more efficiently if USE_LSB_TAG.
1366 This is based on a proposal by YAMAMOTO Mitsuharu in
1367 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1368 For an admittedly artificial (nth 8000 longlist) benchmark on
1369 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1370 Emacs's overall text size by 1%.
1371 * lisp.h (XUNTAG): New macro.
1372 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1373 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1374 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1375 * eval.c (Fautoload):
1376 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1377 * frame.h (XFRAME): Use XUNTAG.
1379 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1380 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1381 Remove unportable assumptions about print widths of types like
1383 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1384 intptr_t when converting between pointer and integer, to avoid GCC
1385 warnings about wrong width.
1387 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1389 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1390 stack for each reader_thread, instead of defaulting to 8MB
1391 determined by the linker. This avoids failures in creating
1392 subprocesses on Windows 7, see the discussion in this thread:
1393 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1395 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1397 Fix up display of the *Minibuf-0* buffer in the mini window.
1398 * keyboard.c (read_char): Don't clear the echo area if there's no
1400 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1401 contents of *Minibuf-0*) if there's no message displayed in its stead.
1403 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1405 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1408 2012-05-06 Chong Yidong <cyd@gnu.org>
1410 * lisp.mk (lisp): Update.
1412 2012-05-05 Jim Meyering <meyering@redhat.com>
1414 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1416 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1418 * data.c (PUT_ERROR): New macro.
1419 (syms_of_data): Use it. Add new error type `user-error'.
1420 * undo.c (user_error): New function.
1421 (Fprimitive_undo): Use it.
1422 * print.c (print_error_message): Adjust print style for `user-error'.
1423 * keyboard.c (user_error): New function.
1424 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1426 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1428 Do not limit current-time-string to years 1000..9999.
1429 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1430 (Fcurrent_time_string): Support any year that is supported by the
1431 underlying localtime representation. Don't use asctime, as it
1432 has undefined behavior for years outside the range -999..9999.
1434 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1436 Fix race conditions involving setenv, gmtime, localtime, asctime.
1437 Without this fix, interrupts could mess up code that uses these
1438 nonreentrant functions, since setting TZ invalidates existing
1439 tm_zone or tzname values, and since most of these functions return
1440 pointers to static storage.
1441 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1442 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1443 Grow the critical sections to include not just invoking
1444 localtime/gmtime, but also accessing these functions' results
1445 including their tm_zone values if any, and any related TZ setting.
1446 (format_time_string): Last arg is now struct tm *, not struct tm **,
1447 so that the struct tm is saved in the critical section.
1448 All callers changed. Simplify allocation of initial buffer, partly
1449 motivated by the fact that memory allocation needs to be outside
1450 the critical section.
1452 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1454 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1455 with RESET_INTERVAL.
1457 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1458 Remove duplicated buffer name initialization.
1460 2012-05-02 Jim Meyering <jim@meyering.net>
1462 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1464 * xfns.c (x_window): Use xstrdup (Bug#11375).
1466 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1468 * xdisp.c (pos_visible_p): If already at a newline from the
1469 display string before the 'while' loop, don't walk back the glyphs
1470 from it3.glyph_row. Solves assertion violation when the display
1471 string begins with a newline (egg.el). (Bug#11367)
1473 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1475 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1478 2012-05-01 Glenn Morris <rgm@gnu.org>
1480 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1481 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1482 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1483 All were removed before 23.1.
1485 * dispnew.c: Remove HAVE_LIBNCURSES test;
1486 it is always true on relevant platforms.
1488 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1489 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1491 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1493 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1495 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1496 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1499 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1501 Do not avoid creating empty evaporating overlays (Bug#9642).
1502 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1503 That is, do not delete an evaporating overlay if it becomes
1504 empty after its bounds are adjusted to fit within its buffer.
1505 This fix caused other problems, and I'm reverting it until we get
1506 to the bottom of them.
1508 2012-04-27 Chong Yidong <cyd@gnu.org>
1510 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1512 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1514 * xdisp.c (pos_visible_p): If the window start position is beyond
1515 ZV, start the display from buffer beginning. Prevents assertion
1516 violation in init_iterator when the minibuffer window is scrolled
1519 * window.c (window_scroll_pixel_based): Likewise.
1521 2012-04-27 Chong Yidong <cyd@gnu.org>
1523 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1525 2012-04-27 Glenn Morris <rgm@gnu.org>
1527 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1528 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1530 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1532 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1533 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1535 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1537 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1538 display element, check also the underlying string or buffer
1539 character. (Bug#11341)
1541 * w32menu.c: Include w32heap.h.
1542 (add_menu_item): If the call to AppendMenuW (via
1543 unicode_append_menu) fails, disable Unicode menus only if we are
1544 running on Windows 9X/Me.
1546 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1548 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1549 (xgetint): Add missing shift for LSB tags.
1551 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1553 * keyboard.c (read_char): Don't wipe echo area for select window
1554 events: These might get delayed via `mouse-autoselect-window'
1557 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1559 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1560 manipulation of :loaded-from data.
1562 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1564 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1565 now a cons (bug#11311).
1567 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1569 Do not create empty overlays with the evaporate property (Bug#9642).
1570 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1571 if it becomes empty after its bounds are adjusted to fit within
1572 its buffer. Without this fix, in a nonempty buffer (let ((o
1573 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1574 yields an empty overlay that has the evaporate property, which is
1575 not supposed to happen.
1577 Fix minor GTK3 problems found by static checking.
1578 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1579 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1580 (struct _EmacsFixedClass, emacs_fixed_get_type):
1581 Move decls here from emacsgtkfixed.h, since they needn't be public.
1582 (emacs_fixed_get_type): Now static.
1583 (emacs_fixed_class_init): Omit unused local.
1584 (emacs_fixed_child_type): Remove; unused.
1585 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1586 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1587 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1588 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1589 (EMACS_FIXED_GET_CLASS): Remove; unused.
1590 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1592 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1593 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1595 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1597 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1598 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1599 (__malloc_size_t, __malloc_ptrdiff_t):
1600 Remove. All uses removed, replaced by the definiens if needed,
1601 since we can assume C89 or better now.
1602 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1603 (protect_malloc_state, align, get_contiguous_space)
1604 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1605 (malloc_atfork_handler_child, malloc_enable_thread)
1606 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1607 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1608 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1609 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1610 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1611 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1612 Define using prototypes, not old style.
1613 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1614 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1615 (align): Don't assume that signed integer overflow wraps around.
1616 Omit unused local var.
1617 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1618 (_free_internal_nolock, memalign, mallochook, reallochook):
1619 Omit no-longer-needed casts.
1620 (valloc): Use getpagesize, not __getpagesize.
1621 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1622 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1624 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1626 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1628 Move functions from C to Lisp. Make non-blocking method calls
1629 the default. Implement further D-Bus standard interfaces.
1631 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1632 (QCdbus_request_name_allow_replacement)
1633 (QCdbus_request_name_replace_existing)
1634 (QCdbus_request_name_do_not_queue)
1635 (QCdbus_request_name_reply_primary_owner)
1636 (QCdbus_request_name_reply_in_queue)
1637 (QCdbus_request_name_reply_exists)
1638 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1639 (QCdbus_registered_serial, QCdbus_registered_method)
1640 (QCdbus_registered_signal): New Lisp objects.
1641 (XD_DEBUG_MESSAGE): Use sizeof.
1642 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1643 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1644 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1645 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1646 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1647 (xd_signature, xd_append_arg): Allow float for integer types.
1648 (xd_get_connection_references): New function.
1649 (xd_get_connection_address): Rename from xd_initialize.
1650 Return cached address.
1651 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1652 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1654 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1655 Return number of refcounts.
1656 (Fdbus_get_unique_name): Make stronger parameter check.
1657 (Fdbus_message_internal): New defun.
1658 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1659 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1660 (Fdbus_send_signal, Fdbus_register_service)
1661 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1662 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1663 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1664 (Vdbus_compiled_version, Vdbus_runtime_version)
1665 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1666 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1667 (Vdbus_message_type_signal): New defvars.
1668 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1671 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1673 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1674 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1675 Do not assume ptrdiff_t is the same width as 'int'.
1677 * alloc.c: Handle unusual debugging option combinations.
1678 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1679 since the two debugging options are incompatible.
1680 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1682 (mem_init, mem_insert, mem_insert_fixup):
1683 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1684 (NEED_MEM_INSERT): Remove; no longer needed.
1686 2012-04-22 Leo Liu <sdl.web@gmail.com>
1688 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1690 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1692 * sysdep.c [__FreeBSD__]: Minor cleanups.
1693 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1694 Use Emacs indenting style more consistently. Avoid some casts.
1695 Use 'double' consistently rather than mixing 'float' and 'double'.
1697 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1699 * sysdep.c (list_system_processes, system_process_attributes):
1700 Add implementation for FreeBSD (Bug#5243).
1702 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1704 * lisp.mk (lisp): Update.
1706 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1708 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1709 It is never used otherwise.
1711 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1713 * print.c (print_preprocess): Only check print_depth if print-circle
1715 (print_object): Check for cycles even when print-circle is nil and
1716 print-gensym is t, but only check print_depth if print-circle is nil.
1718 2012-04-20 Chong Yidong <cyd@gnu.org>
1720 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1721 set the status to "failed" and ensure that sentinel is run.
1723 2012-04-20 Glenn Morris <rgm@gnu.org>
1725 * process.c (Fset_process_inherit_coding_system_flag)
1726 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1727 (Fmake_network_process, Fmake_serial_process): Doc fix.
1729 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1731 * xdisp.c (string_buffer_position_lim): Limit starting position to
1733 (set_cursor_from_row): If called for a mode-line or header-line
1734 row, return zero immediately.
1735 (try_cursor_movement): If inside continuation line, don't back up
1736 farther than the first row after the header line, if any.
1737 Don't consider the header-line row as "partially visible", even if
1738 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1740 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1742 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1745 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1746 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1748 configure: new option --enable-gcc-warnings (Bug#11207)
1749 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1750 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1751 (ALL_CFLAGS): Use new macros rather than old.
1752 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1753 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1754 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1755 -Wunused-result, -Wunused-variable. This should go away once
1756 the Emacs and Gnulib regex code is merged.
1757 (xmalloc, xrealloc): Now static.
1759 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1761 * dired.c (Fsystem_groups): Remove unused local.
1763 2012-04-17 Glenn Morris <rgm@gnu.org>
1765 * dired.c (Fsystem_users): Doc fix.
1767 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1769 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1770 (syms_of_dired): Add them.
1772 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1774 Fix minor alloc.c problems found by static checking.
1775 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1776 New extern decls, to avoid calling undeclared functions.
1777 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1778 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1779 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1780 (NEED_MEM_INSERT): New macro.
1781 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1782 Remove one incorrect comment and fix another.
1784 Fix minor ralloc.c problems found by static checking.
1785 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1786 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1787 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1788 (r_alloc_sbrk): Now static.
1790 Improve ralloc.c interface checking.
1791 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1792 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1793 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1794 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1795 [REL_ALLOC]: ... to here, to check interface.
1796 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1797 Remove decls. This fixes an "It stinks!".
1799 * alloc.c (which_symbols): Fix alignment issue / type clash.
1801 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1803 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1804 (struct Lisp_Misc_Any): Likewise.
1805 (struct Lisp_Free): Likewise.
1806 * alloc.c (union aligned_Lisp_Symbol): Define.
1807 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1808 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1809 (union aligned_Lisp_Misc): Define.
1810 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1811 aligned_Lisp_Misc instead of union Lisp_Misc.
1812 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1814 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1816 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1817 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1818 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1819 * s/netbsd.h, s/sol2-6.h:
1820 Remove definition of GC_MARK_STACK, since the default now works.
1821 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1822 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1823 no longer the default.
1824 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1826 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1828 * lread.c (lisp_file_lexically_bound_p):
1829 Fix hang at ";-*-\n" (bug#11238).
1831 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1833 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1834 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1836 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1838 * nsterm.m (constrainFrameRect): Always constrain when there is only
1839 one screen (Bug#10962).
1841 2012-04-13 Ken Brown <kbrown@cornell.edu>
1843 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1845 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1847 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1849 2012-04-11 Daniel Colascione <dancol@dancol.org>
1851 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1852 against is gone. It's better to use vfork now so that when Cygwin
1853 gains a new, working vfork, we use it automatically (bug#10398).
1855 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1857 * window.c (save_window_save): Obey window-point-insertion-type.
1859 2012-04-11 Glenn Morris <rgm@gnu.org>
1861 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1863 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1865 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1867 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1869 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1870 (force_quit_count): New var.
1871 (handle_interrupt): Use it.
1873 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1875 * w32.c (w32_delayed_load): Record the full path of the library
1876 being loaded (bug#10424).
1878 2012-04-09 Glenn Morris <rgm@gnu.org>
1880 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1881 not just in the obarray, before snarfing them. (Bug#11036)
1883 * Makefile.in ($(leimdir)/leim-list.el):
1884 Pass EMACS rather than BUILT_EMACS.
1886 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1888 * process.c (make_process):
1889 * process.h: Add integer `gnutls_handshakes_tried' member to
1892 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1893 Add convenience `GNUTLS_LOG2i' macro.
1895 * gnutls.c (gnutls_log_function2i): Convenience log function.
1896 (emacs_gnutls_read): Use new log functions,
1897 `gnutls_handshakes_tried' process member, and
1898 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1899 attempts per process (connection).
1901 2012-04-09 Chong Yidong <cyd@gnu.org>
1903 * eval.c (Fuser_variable_p, user_variable_p_eh)
1904 (lisp_indirect_variable): Functions deleted.
1905 (Fdefvar): Caller changed.
1907 * callint.c (Finteractive, Fcall_interactively):
1908 * minibuf.c (Fread_variable): Callers changed.
1910 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1912 * xdisp.c (set_cursor_from_row): If the display string appears in
1913 the buffer at position that is closer to point than the position
1914 after the display string, display the cursor on the first glyph of
1915 the display string. Fixes cursor display when a 'display' text
1916 property immediately follows invisible text. (Bug#11094)
1918 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1920 composite.c: use 'double' consistently
1921 * composite.c (get_composition_id): Use 'double' consistently
1922 instead of converting 'float' to 'double' and vice versa; this is
1923 easier to understand and avoids a GCC warning.
1925 2012-04-09 Glenn Morris <rgm@gnu.org>
1927 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1928 preparation for dumping it with emacs. (Bug#4789)
1929 (leimdir): New variable.
1930 ($(leimdir)/leim-list.el): New rule.
1931 (emacs$(EXEEXT)): Depend on leim-list.el.
1933 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1934 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1935 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1937 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1939 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1942 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1944 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1945 Remove unused local variable.
1947 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1949 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1950 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1951 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1952 objects, as mark_maybe_pointer will catch them otherwise.
1953 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1954 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1956 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1958 Fix typo that broke non-Windows builds.
1959 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1961 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1963 Support building on MS-Windows with libxml2.
1965 * makefile.w32-in (OBJ2): Add xml.$(O).
1966 (GLOBAL_SOURCES): Add xml.c.
1967 ($(BLD)/xml.$(O)): New dependency list.
1969 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1970 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1971 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1972 [!WINDOWSNT]: New macros.
1973 (init_libxml2_functions, libxml2_loaded_p): New functions.
1974 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1975 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1976 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1977 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1979 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1980 Call init_libxml2_functions before calling libxml2 functions.
1981 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1983 * emacs.c: Don't include libxml/parser.h.
1984 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1985 xmlCleanupParser directly.
1987 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1989 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1991 * indent.c (Fvertical_motion): If there is a display string at
1992 point, use it.vpos to compute how many lines to backtrack after
1993 move_it_to point. (Bug#11133)
1995 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1997 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1998 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1999 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2000 macros related to unification of CJK characters. For the details,
2001 see the discussion following the message here:
2002 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2004 2012-04-04 Chong Yidong <cyd@gnu.org>
2006 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2008 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2010 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2011 instead of alloca. (Bug#11138)
2013 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2015 * w32menu.c (is_simple_dialog): Properly check lisp types.
2018 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2020 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2021 position we get to after a call to move_it_to fails the
2022 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2023 only if we wind up in a string from display property. (Bug#11063)
2025 * window.c (Fdelete_other_windows_internal): Invalidate the row
2026 and column information about mouse highlight, so that redisplay
2027 restores it after reallocating the glyph matrices. (Bug#7464)
2029 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2030 string comes from a `display' text property, use the buffer
2031 position of that property as if we actually saw that position in
2033 (move_it_by_lines): Remove the assertion that
2034 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2035 violated when there's a before-string at the beginning of a line.
2038 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2040 * xdisp.c (append_space_for_newline): If the default face was
2041 remapped, use the remapped face for the appended newline.
2042 (extend_face_to_end_of_line): Use the remapped default face for
2043 extending the face to the end of the line.
2044 (display_line): Call extend_face_to_end_of_line when the default
2045 face was remapped. (Bug#11068)
2047 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2049 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2051 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2053 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2055 2012-03-27 Glenn Morris <rgm@gnu.org>
2057 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2060 2012-03-26 Kenichi Handa <handa@m17n.org>
2062 * dispextern.h (struct glyph): Fix previous change. Change the
2063 bit length of glyphless.ch to 25 (Bug#11082).
2065 2012-03-26 Chong Yidong <cyd@gnu.org>
2067 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2068 (command_loop_1): Use it; inhibit selection update for
2069 handle-select-window too (Bug#8996).
2071 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2073 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2075 2012-03-25 Kenichi Handa <handa@m17n.org>
2077 * dispextern.h (struct glyph): Change the bit length of
2078 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2080 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2082 * s/ms-w32.h (tzname): Include time.h before redirecting to
2083 _tzname. Fixes the MSVC build. (Bug#9960)
2085 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2087 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2090 * xterm.c (XTread_socket): Only modify handling_signal if
2091 !SYNC_INPUT. (Bug#11080)
2093 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2095 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2096 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2097 when fetching a multibyte character consumes more bytes than
2098 CHAR_BYTES returns, due to unification of CJK characters in
2099 string_char. (Bug#11073)
2101 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2103 * process.c (wait_reading_process_output): Handle pty disconnect
2104 by refraining from sending oneself a SIGCHLD (bug#10933).
2106 2012-03-22 Chong Yidong <cyd@gnu.org>
2108 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2110 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2111 Mark string as coming from a prefix property.
2112 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2113 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2115 2012-03-21 Chong Yidong <cyd@gnu.org>
2117 * xfaces.c (Vface_remapping_alist): Doc fix.
2119 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2121 * w32proc.c (Fw32_set_console_codepage)
2122 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2125 2012-03-20 Chong Yidong <cyd@gnu.org>
2127 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2128 to reflect default non-nil value of redisplay-dont-pause.
2130 2012-03-19 Kenichi Handa <handa@m17n.org>
2132 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2133 it fit in a valid range (Bug#11003).
2135 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2137 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2138 that is not from display property, accept the row as a "cursor
2139 row" if one of the string's character has a non-nil `cursor'
2140 property. Fixes cursor positioning when there are newlines in
2141 overlay strings, e.g. in icomplete.el. (Bug#11035)
2143 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2145 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2147 2012-03-12 Chong Yidong <cyd@gnu.org>
2149 * eval.c (inhibit_lisp_code): Rename from
2150 inhibit_window_configuration_change_hook; move from window.c.
2152 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2153 * window.c (run_window_configuration_change_hook)
2154 (syms_of_window): Callers changed.
2156 2012-03-11 Chong Yidong <cyd@gnu.org>
2158 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2160 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2162 2012-03-10 Chong Yidong <cyd@gnu.org>
2164 * frame.c (other_visible_frames): Don't assume the selected frame
2165 is visible (Bug#10955).
2167 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2169 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2171 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2173 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2174 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2177 2012-03-03 Glenn Morris <rgm@gnu.org>
2179 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2181 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2183 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2184 position past the first glyph_row that ends at ZV. (Bug#10902)
2185 (redisplay_window, next_element_from_string): Fix typos in
2187 (redisplay_window): Pass to move_it_vertically the margin in
2188 pixels, not in screen lines.
2190 2012-03-02 Glenn Morris <rgm@gnu.org>
2192 * buffer.c (buffer-list-update-hook): Doc fix.
2194 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2196 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2197 push_it before setting up the iterator for the first overlay
2198 string, even if we have an empty string loaded.
2199 (next_overlay_string): If there's an empty string on the iterator
2200 stack, pop the stack. (Bug#10903)
2202 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2204 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2205 Suggested by Stefan Monnier in
2206 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2207 * alloc.c (widen_to_Lisp_Object): New static function.
2208 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2209 and widening them to Lisp_Objects. This would work even if
2210 USE_LSB_TAG is defined and wide integers are used, which might
2211 happen in a future version of Emacs.
2213 2012-02-25 Chong Yidong <cyd@gnu.org>
2215 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2218 * xselect.c (Fx_selection_exists_p): Doc fix.
2219 (x_clipboard_manager_save_all): Print an informative message
2220 before saving to clipboard manager.
2222 2012-02-24 Chong Yidong <cyd@gnu.org>
2224 * keyboard.c (process_special_events): Handle all X selection
2225 requests in kbd_buffer, not just the next one (Bug#8869).
2227 2012-02-23 Chong Yidong <cyd@gnu.org>
2229 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2230 call when setting menu-bar-lines and tool-bar-lines parameters.
2231 (unwind_create_frame_1): New helper function.
2233 * window.c (inhibit_window_configuration_change_hook): New var.
2234 (run_window_configuration_change_hook): Obey it.
2235 (syms_of_window): Initialize it.
2237 2012-02-22 Chong Yidong <cyd@gnu.org>
2239 * xterm.c (x_draw_image_relief): Add missing type check for
2240 Vtool_bar_button_margin (Bug#10743).
2242 2012-02-21 Chong Yidong <cyd@gnu.org>
2244 * fileio.c (Vfile_name_handler_alist): Doc fix.
2246 * buffer.c (Fget_file_buffer): Protect against invalid file
2247 handler return value.
2249 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2251 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2252 when computing $valmask.
2254 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2255 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2256 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2257 It's useless in that case, and it can cause problems on hosts
2258 that allocate halves of EMACS_INT values separately.
2259 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2260 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2261 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2262 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2263 it avoids undefined behavior on hosts where shifting right by more
2264 than the word width has undefined behavior.
2266 2012-02-19 Chong Yidong <cyd@gnu.org>
2268 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2269 (Funhandled_file_name_directory, Ffile_name_as_directory)
2270 (Fdirectory_file_name, Fexpand_file_name)
2271 (Fsubstitute_in_file_name): Protect against invalid file handler
2272 return values (Bug#10845).
2274 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2276 * .gdbinit (pitx): Fix incorrect references to fields of the
2279 2012-02-17 Chong Yidong <cyd@gnu.org>
2281 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2283 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2285 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2286 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2288 2012-02-15 Chong Yidong <cyd@gnu.org>
2290 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2291 marked as special. Also, starting docstrings with * is obsolete.
2293 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2295 * gnutls.c (emacs_gnutls_write): Fix last change.
2297 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2299 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2302 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2304 * keymap.c (Fsingle_key_description): Handle char ranges.
2306 2012-02-12 Chong Yidong <cyd@gnu.org>
2308 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2309 as that creates a dangerous corner case.
2311 * window.c (Fdelete_window_internal): Invalidate the mouse
2312 highlight (Bug#9904).
2314 2012-02-12 Glenn Morris <rgm@gnu.org>
2316 * xselect.c (Fx_own_selection_internal)
2317 (Fx_get_selection_internal, Fx_disown_selection_internal)
2318 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2319 * nsselect.m (Fx_own_selection_internal)
2320 (Fx_disown_selection_internal, Fx_selection_exists_p)
2321 (Fx_selection_owner_p, Fx_get_selection_internal):
2322 Sync docs and argument specs with the xselect.c versions.
2324 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2326 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2328 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2330 * w32select.c (Fx_selection_exists_p): Sync doc string and
2331 argument list with xselect.c. (Bug#10783)
2333 * w16select.c (Fx_selection_exists_p): Sync doc string and
2334 argument list with xselect.c. (Bug#10783)
2336 2012-02-10 Glenn Morris <rgm@gnu.org>
2338 * fns.c (Fsecure_hash): Doc fix.
2340 2012-02-09 Kenichi Handa <handa@m17n.org>
2342 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2344 2012-02-07 Chong Yidong <cyd@gnu.org>
2346 * buffer.c (Fbuffer_local_variables)
2347 (buffer_lisp_local_variables): Handle unbound vars correctly;
2348 don't let Qunbound leak into Lisp.
2350 2012-02-07 Glenn Morris <rgm@gnu.org>
2352 * image.c (Fimagemagick_types): Doc fix.
2354 * image.c (imagemagick-render-type): Change it from a lisp object
2355 to an integer. Move the doc here from the lisp manual.
2356 Treat all values not equal to 0 the same.
2358 2012-02-06 Chong Yidong <cyd@gnu.org>
2360 * doc.c (store_function_docstring): Avoid applying docstring of
2361 alias to base function (Bug#2603).
2363 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2365 * .gdbinit (pp1, pv1): Remove redundant defines.
2368 2012-02-04 Chong Yidong <cyd@gnu.org>
2370 * nsterm.m: Declare a global (Bug#10694).
2372 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2374 * w32.c (get_emacs_configuration_options):
2375 Include --enable-checking, if specified, in the return value.
2377 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2379 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2380 after rounding frame sizes. (Bug#9723)
2382 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2384 * keyboard.c (adjust_point_for_property): Don't position point
2385 before BEGV. (Bug#10696)
2387 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2389 Handle overflow when computing char display width (Bug#9496).
2390 * character.c (char_width): Return EMACS_INT, not int.
2391 (char_width, c_string_width): Check for overflow when
2392 computing the width; this is possible now that individual
2393 characters can have unbounded width. Problem introduced
2394 by merge from Emacs 23 on 2012-01-19.
2396 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2398 * dbusbind.c (Fdbus_register_method): Mention the return value
2399 :ignore in the docstring.
2401 2012-02-02 Glenn Morris <rgm@gnu.org>
2403 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2405 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2406 Unconditionally set to t. (Bug#10673)
2407 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2408 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2409 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2411 2012-02-02 Kenichi Handa <handa@m17n.org>
2413 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2414 0, do not call append_composite_glyph.
2416 2012-02-02 Kenichi Handa <handa@m17n.org>
2418 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2420 (x_produce_glyphs): If the component of a composition is a null
2421 string, set it->pixel_width to 1 to avoid zero-width glyph.
2423 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2425 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2426 first 2 arguments are identical. This makes inserting large
2427 output from a subprocess an order of magnitude faster on
2428 MS-Windows, where all sbrk'ed memory is always contiguous.
2430 2012-01-31 Glenn Morris <rgm@gnu.org>
2432 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2433 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2434 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2436 2012-01-29 Glenn Morris <rgm@gnu.org>
2438 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2440 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2442 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2444 2012-01-28 Chong Yidong <cyd@gnu.org>
2446 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2448 2012-01-26 Chong Yidong <cyd@gnu.org>
2450 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2452 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2453 repeat counts (Bug#10507).
2455 2012-01-26 Glenn Morris <rgm@gnu.org>
2457 * lread.c (syms_of_lread): Doc fix.
2459 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2461 * coding.c (encode_designation_at_bol): Change return value to
2464 2012-01-25 Chong Yidong <cyd@gnu.org>
2466 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2468 2012-01-21 Chong Yidong <cyd@gnu.org>
2470 * floatfns.c (Fcopysign): Make the second argument non-optional,
2471 since nil is not allowed anyway.
2473 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2475 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2476 (send_process): Likewise.
2478 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2480 * window.c (save_window_save, Fcurrent_window_configuration)
2481 (Vwindow_persistent_parameters): Do not use Qstate.
2482 Rewrite doc-strings.
2484 2012-01-19 Kenichi Handa <handa@m17n.org>
2486 * character.c (char_width): New function.
2487 (Fchar_width, c_string_width, lisp_string_width):
2488 Use char_width (Bug#9496).
2490 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2492 * window.c (Vwindow_persistent_parameters): New variable.
2493 (Fset_window_configuration, save_window_save): Handle persistent
2496 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2498 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2499 thrashing the stack of the thread. (Bug#9087)
2501 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2503 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2505 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2507 * xdisp.c (rows_from_pos_range): Handle the case where the
2508 highlight ends on a newline. (Bug#10464)
2509 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2510 he end column for display of highlight that ends on a newline
2513 2012-01-11 Glenn Morris <rgm@gnu.org>
2515 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2516 from load-path also when installation-directory is nil. (Bug#10208)
2518 2012-01-10 Glenn Morris <rgm@gnu.org>
2520 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2522 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2523 Update template values to be closer to their typical values these days.
2525 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2527 * xdisp.c (rows_from_pos_range): Accept additional argument
2528 DISP_STRING, and accept any glyph in a row whose object is that
2529 string as eligible for mouse highlight. Fixes mouse highlight of
2530 display strings from overlays. (Bug#10464)
2532 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2534 emacs: fix an auto-save permissions race condition (Bug#10400)
2535 * fileio.c (auto_saving_dir_umask): New static var.
2536 (Fmake_directory_internal): Use it.
2537 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2538 creating the directory. The old code temporarily assigns
2539 too-generous permissions to the directory.
2540 (do_auto_save_eh): Clear it.
2541 (Fdo_auto_save): Catch all errors, not just file errors, so
2542 that the var is always cleared.
2544 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2546 * search.c (scan_buffer): Pass character positions to
2547 know_region_cache, not byte positions. (Bug#6540)
2549 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2551 * w32.c (sys_rename): Report EXDEV when rename of a directory
2552 fails because the target is on another logical disk. (Bug#10284)
2554 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2556 * xterm.c (x_embed_request_focus): New function.
2558 * xterm.h: Add prototype.
2560 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2562 2012-01-05 Glenn Morris <rgm@gnu.org>
2564 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2566 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2568 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2569 Load gnutls_transport_set_lowat only if GnuTLS version is below
2571 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2572 GnuTLS versions below 2.11.1.
2574 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2576 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2577 to the doc string advising against its use for altering the way
2578 windows are scrolled.
2580 2011-12-28 Kenichi Handa <handa@m17n.org>
2582 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2583 coding-system ASCII compatible only when it does not produce BOM
2584 on encoding (Bug#10383).
2586 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2588 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2590 (create_and_show_popup_menu): Always use menu_position_func for
2593 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2595 * callint.c (Fcall_interactively): Don't truncate prompt string.
2597 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2599 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2600 property that ends at ZV, so that the bidi iteration could be
2601 resumed from there (after widening). (Bug#10360)
2603 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2605 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2607 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2609 * nsterm.m (x_free_frame_resources):
2610 Release f->output_data.ns->miniimage.
2611 (ns_index_color): Fix indentation. Do not retain
2612 color_table->colors[i].
2614 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2617 * nsfns.m (x_set_background_color): Assign return value from
2618 ns_index_color to face-background instead of NSColor*.
2619 (ns_implicitly_set_icon_type): Fix indentation.
2620 Change assignment in for loop to comparison.
2622 * emacs.c (ns_pool): New variable.
2623 (main): Assign ns_pool.
2624 (Fkill_emacs): Call ns_release_autorelease_pool.
2626 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2627 autorelease fdesc, release fdAttrs and tdict.
2628 (ns_get_covering_families): Release charset.
2629 (ns_findfonts): Release NSFontDescriptor created with new.
2630 (ns_uni_to_glyphs): Fix indentation.
2631 (setString): Release attrStr before assigning new value.
2633 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2635 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2637 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2638 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2640 2011-12-18 David Reitter <reitter@cmu.edu>
2642 * nsterm.m (ns_term_init): Subscribe for notifications
2643 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2644 to method trackingNotification in EmacsMenu.
2646 * nsmenu.m (trackingMenu): New variable.
2647 (trackingNotification): New method (from Aquamacs).
2648 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2649 from Aquamacs (Bug#7030).
2651 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2653 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2654 (symbol_to_nsstring): Fix indentation.
2655 (ns_symbol_to_pb): New function.
2656 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2657 (Fns_rotate_cut_buffers_internal): Remove.
2658 (Fns_store_selection_internal): Rename from
2659 Fns_store_cut_buffer_internal.
2660 (ns_get_foreign_selection, Fx_own_selection_internal)
2661 (Fx_disown_selection_internal, Fx_selection_exists_p)
2662 (Fns_get_selection_internal, Fns_store_selection_internal):
2663 Use ns_symbol_to_pb and check if return value is nil.
2664 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2665 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2666 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2667 renamed to Sns_store_selection_internal.
2668 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2669 and remove this function.
2670 (ns_handle_selection_clear): Remove, never used.
2671 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2674 2011-12-17 Ken Brown <kbrown@cornell.edu>
2676 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2677 GID is unknown (Bug#10257).
2679 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2681 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2682 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2683 which caused a build failure on GNU/Linux IA-64. This problem was
2684 introduced by my 2011-10-07 patch.
2686 2011-12-15 Juri Linkov <juri@jurta.org>
2688 * image.c (imagemagick_error): New function. (Bug#10112)
2689 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2690 Use `imagemagick_error' where ImageMagick functions return
2692 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2695 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2697 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2698 fill background (Bug#8992).
2700 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2702 * window.c (Vwindow_combination_resize)
2703 (Vwindow_combination_limit): Use t instead of non-nil in
2705 (Vrecenter_redisplay): Add first sentence of doc-string on
2707 (Frecenter): Fix doc-string typo.
2709 2011-12-11 Kenichi Handa <handa@m17n.org>
2711 * coding.c (Funencodable_char_position): Pay attention to the
2712 buffer text relocation (Bug#9389).
2714 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2716 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2717 gtk_init (Bug#10100).
2719 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2721 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2722 IT->string is nil. (Bug#10263)
2724 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2726 * nsterm.h (x_free_frame_resources): Declare.
2728 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2729 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2731 * nsterm.h (ns_get_defaults_value): Declare.
2733 * nsterm.m (ns_default): Call ns_get_defaults_value.
2735 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2737 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2740 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2742 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2743 that where the value of an _OBJC_* symbol points to is in the .bss
2744 section (Bug#10240).
2746 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2748 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2749 after the loop to call ccl_driver at least once (Bug#8619).
2751 2011-12-08 Kenichi Handa <handa@m17n.org>
2753 * ftfont.c (get_adstyle_property): Fix previous change
2756 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2758 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2759 dirs from the default value of EMACSLOADPATH (bug#10208).
2761 2011-12-07 Glenn Morris <rgm@gnu.org>
2763 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2764 installation and source directories as well. (Bug#10208)
2766 2011-12-06 Chong Yidong <cyd@gnu.org>
2768 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2770 2011-12-06 Glenn Morris <rgm@gnu.org>
2772 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2773 as an error, not just -1. (Bug#10217)
2775 2011-12-05 Chong Yidong <cyd@gnu.org>
2777 * keyboard.c (process_special_events): New function.
2778 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2780 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2782 * coding.c (encode_designation_at_bol): Don't use uninitialized
2783 local variable (Bug#9318).
2785 2011-12-05 Kenichi Handa <handa@m17n.org>
2787 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2788 return Qnil (Bug#8046, Bug#10193).
2790 2011-12-05 Kenichi Handa <handa@m17n.org>
2792 * coding.c (encode_designation_at_bol): New args charbuf_end and
2793 dst. Return the number of produced bytes. Callers changed.
2794 (coding_set_source): Return how many bytes coding->source was
2796 (coding_set_destination): Return how many bytes
2797 coding->destination was relocated.
2798 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2799 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2801 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2803 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2804 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2807 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2809 The following changes are to fix Bug#9318.
2811 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2812 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2813 (encode_coding_iso_2022, encode_coding_sjis)
2814 (encode_coding_big5, encode_coding_charset): Use the above macros.
2816 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2818 * lisp.h (process_quit_flag): Fix external declaration.
2820 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2822 Don't macro-inline non-performance-critical code.
2823 * eval.c (process_quit_flag): New function.
2824 * lisp.h (QUIT): Use it.
2826 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2828 * nsfns.m (get_geometry_from_preferences): New function.
2829 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2831 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2833 * emacs.c (Qkill_emacs): Define.
2834 (syms_of_emacs): Initialize it.
2835 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2836 Qquit_flag to `kill-emacs' instead.
2837 (quit_throw_to_read_char): Add parameter `from_signal'.
2838 All callers changed. Call Fkill_emacs if requested and safe.
2839 * lisp.h (QUIT): Call Fkill_emacs if requested.
2841 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2843 * widget.c (update_wm_hints): Return if wmshell is null.
2844 (widget_update_wm_size_hints): New function.
2846 * widget.h (widget_update_wm_size_hints): Declare.
2848 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2849 widget_update_wm_size_hints (Bug#10104).
2851 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2853 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2854 before a newline, prepare the bidi iterator for consuming the
2855 newline, and keep the current paragraph direction. (Bug#10183)
2856 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2858 2011-12-02 Juri Linkov <juri@jurta.org>
2860 * search.c (Fword_search_regexp): New Lisp function created from
2861 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2862 (Fword_search_backward, Fword_search_forward)
2863 (Fword_search_backward_lax, Fword_search_forward_lax):
2864 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2865 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2867 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2869 * fileio.c (Finsert_file_contents): Move after-change-function call
2870 to before the "handled:" label, since all "goto handled" appear in
2871 cases where the *-change-functions have already been properly called
2874 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2876 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2877 waiting for input. (Bug#10169)
2879 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2881 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2882 verifies glyph row's hash code--we have just reallocated the
2883 glyphs, so their contents can be complete garbage. (Bug#10164)
2885 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2887 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2889 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2891 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2892 attributes are tested _before_ calling verify_row_hash, to protect
2893 against GCC re-ordering of the tests. (Bug#10164)
2895 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2897 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2899 * xterm.c (handle_one_xevent): Only set async_visible and friends
2900 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2901 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2902 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2904 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2906 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2907 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2908 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2909 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2910 All uses changed to use GCPRO1 etc.
2911 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2912 Revert to old implementation (i.e., before 2011-03-11).
2914 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2916 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2917 of scroll runs so as to avoid assigning disabled bogus rows and
2918 unnecessary graphics copy operations.
2920 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2922 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2923 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2924 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2925 (malloc, free, realloc, calloc): Redirect to e_* only when
2928 * lisp.h (GCTYPEBITS): Move before first use.
2929 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2930 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2931 this macro definition.
2933 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2936 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2938 * gtkutil.c (xg_create_frame_widgets):
2939 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2940 present with Gtk+ 2.0.
2942 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2944 * fileio.c (Finsert_file_contents): Undo previous change; see
2945 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2947 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2949 Rename locals to avoid shadowing.
2950 * fileio.c (Finsert_file_contents):
2951 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2952 * process.c (wait_reading_process_output):
2953 Rename inner 'proc' to 'p' to avoid shadowing.
2954 Indent for consistency with usual Emacs style.
2956 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2958 * xdisp.c (redisplay_window): If cursor row is not fully visible
2959 after recentering, and scroll-conservatively is set to a large
2960 number, scroll window by a few more lines to make the cursor fully
2961 visible and out of scroll-margin. (Bug#10105)
2962 (start_display): Don't move to the next line if the display should
2963 start at a newline that is part of a display vector or an overlay
2966 2011-11-24 Juri Linkov <juri@jurta.org>
2968 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2969 after the `MagickPingImage' call. (Bug#10112)
2971 2011-11-23 Chong Yidong <cyd@gnu.org>
2973 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2975 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2977 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2978 making another buffer current. (Bug#10114)
2980 2011-11-23 Glenn Morris <rgm@gnu.org>
2982 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2984 2011-11-23 Chong Yidong <cyd@gnu.org>
2986 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2987 using it (Bug#5984).
2989 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2991 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2992 and header-lines, as they don't have one computed for them.
2995 * .gdbinit (prow): Make displayed values more self-explaining.
2996 Add row's hash code.
2998 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3000 * process.c (wait_reading_process_output): Fix asynchrounous
3001 GnuTLS socket handling on some versions of the GnuTLS library.
3002 (wait_reading_process_output): Add comment and URL.
3004 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3006 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3008 2011-11-21 Chong Yidong <cyd@gnu.org>
3010 * window.c (Fnext_window, Fprevious_window): Doc fix.
3012 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3014 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3016 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3018 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3020 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3022 * window.c (Fset_window_combination_limit): Rename argument
3024 (Vwindow_combination_limit): Remove "status" from doc-string.
3026 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3028 * m/ibms390.h: Remove.
3029 * m/ibms390x.h: Don't include "ibms390.h".
3031 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3033 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3034 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3036 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3038 * casetab.c (Fset_case_table):
3039 * charset.c (Fcharset_after): Fix typos.
3041 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3043 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3044 Otherwise, valgrind does not work on some platforms.
3045 Problem reported by Andreas Schwab in
3046 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3047 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3048 is set, removing the need for VIRT_ADDRESS_VARIES.
3049 (PURE_P): Use a more-efficient implementation that needs just one
3050 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3051 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3052 to 4 (xorl, subq, cmpq, setbe).
3053 * alloc.c (pure): Always extern now, since that's the
3054 VIRT_ADDR_VARIES behavior.
3055 (PURE_POINTER_P): Use a single comparison, not two, for
3056 consistency with the new puresize.h.
3057 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3058 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3059 Remove VIRT_ADDR_VARIES no longer needed.
3061 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3063 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3064 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3065 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3066 behave as if the cursor position were at the window margin.
3068 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3069 and the cursor position is out of bounds, behave as if the cursor
3070 position were at the window margin. (Bug#10075)
3072 2011-11-18 Chong Yidong <cyd@gnu.org>
3074 * window.c (Fwindow_combination_limit): Make first argument
3075 non-optional, since it is meaningless for live windows like the
3078 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3080 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3082 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3084 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3085 (graft_intervals_into_buffer): Simplify.
3087 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3089 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3090 hash values of the two rows.
3091 (copy_row_except_pointers): Preserve the used[] arrays and the
3092 hash values of the two rows. (Bug#10035)
3093 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3095 * xdisp.c (row_hash): New function, body extracted from
3096 compute_line_metrics.
3097 (compute_line_metrics): Call row_hash, instead of computing the
3100 * dispnew.c (verify_row_hash): Call row_hash for computing the
3101 hash code of a row, instead of duplicating code from xdisp.c.
3103 * dispextern.h (row_hash): Add prototype.
3105 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3107 * frame.c (delete_frame): Don't delete the terminal when the last
3108 X frame is closed if emacs is built with GTK toolkit.
3110 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3112 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3114 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3116 * window.c (Vwindow_splits): Rename to
3117 Vwindow_combination_resize. Suggested by Juri Linkov.
3118 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3121 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3123 * nsfns.m (Fns_font_name):
3124 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3126 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3128 * window.h (window): Rename slot "nest" to "combination_limit".
3129 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3130 (Fset_window_nest): Rename to Fset_window_combination_limit.
3131 (Vwindow_nest): Rename to Vwindow_combination_limit.
3132 (recombine_windows, make_parent_window, make_window)
3133 (Fsplit_window_internal, saved_window)
3134 (Fset_window_configuration, save_window_save): Rename all
3135 occurrences of window_nest to window_combination_limit.
3137 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3139 * image.c (imagemagick_load_image): Fix typo.
3141 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3143 * xdisp.c (display_line): Move the call to
3144 highlight_trailing_whitespace before the call to
3145 compute_line_metrics, since the latter needs to see the final
3146 faces of all the glyphs to compute ROW's hash value.
3147 Fixes assertion violations in row_equal_p. (Bug#10035)
3149 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3151 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3152 just return (bug#10044).
3154 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3156 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3157 with user-defined heap size. Bump the default size of the temacs
3158 heap to 27MB, to avoid memory warning when running temacs.
3159 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3161 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3162 current_matrix and desired_matrix. (Bug#9990)
3163 (verify_row_hash) [XASSERTS]: New function.
3164 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3165 that the hash value of glyph rows is correct.
3167 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3169 * window.h (window): Remove splits slot.
3170 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3171 (Fdelete_other_windows_internal, make_parent_window)
3172 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3173 (Fset_window_configuration, save_window_save): Don't deal with
3174 split status of windows.
3175 (saved_window): Remove splits slot.
3176 (Vwindow_splits): Rewrite doc-string.
3178 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3180 * xfns.c (unwind_create_frame):
3181 * nsfns.m (unwind_create_frame):
3182 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3183 Vframe_list (Bug#9999).
3185 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3187 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3189 2011-11-11 Kenichi Handa <handa@m17n.org>
3191 * callproc.c (Fcall_process): Set the member dst_multibyte of
3194 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3196 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3197 avoid a crash (bug#9496).
3199 2011-11-09 Chong Yidong <cyd@gnu.org>
3201 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3202 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3204 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3206 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3208 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3210 Avoid some portability problems by eschewing 'extern inline' functions.
3211 The trivial performance wins aren't worth the portability hassles; see
3212 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3214 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3215 (window_box_width, window_box_left, window_box_left_offset)
3216 (window_box_right, window_box_right_offset): Undo previous change,
3217 by removing the "extern"s.
3218 * intervals.c (adjust_intervals_for_insertion)
3219 (adjust_intervals_for_deletion): Undo previous change,
3220 making these static again.
3221 (offset_intervals, temp_set_point_both, temp_set_point)
3222 (copy_intervals_to_string): No longer inline.
3223 * xdisp.c (window_text_bottom_y, window_box_width)
3224 (window_box_height, window_box_left_offset)
3225 (window_box_right_offset, window_box_left, window_box_right)
3226 (window_box): No longer inline.
3228 2011-11-08 Chong Yidong <cyd@gnu.org>
3230 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3231 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3232 Signal an error if not a live window.
3233 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3234 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3236 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3238 * lisp.h (syms_of_abbrev): Remove declaration.
3239 Reported by CHENG Gao <chenggao@royau.me>.
3241 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3243 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3244 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3245 of temacs in GUI mode.
3247 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3249 * window.h: Declare delete_all_child_windows instead of
3250 delete_all_subwindows.
3251 * window.c (Fwindow_nest, Fset_window_nest)
3252 (Fset_window_new_total, Fset_window_new_normal)
3253 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3254 (delete_all_subwindows): Rename to delete_all_child_windows.
3255 (Fdelete_other_windows_internal, Fset_window_configuration):
3256 Call delete_all_child_windows instead of delete_all_subwindows.
3257 * frame.c (delete_frame): Call delete_all_child_windows instead
3258 of delete_all_subwindows.
3260 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3262 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3263 This is also needed for porting to any host where GC_MARK_STACK is
3264 not GC_MAKE_GCPROS_NOOPS.
3265 (which_symbols): Use it.
3267 2011-11-07 Kenichi Handa <handa@m17n.org>
3269 * coding.c (coding_set_destination): Check coding->src_pos only
3270 when coding->src_object is a buffer (bug#9910).
3272 * process.c (send_process): Set the member src_multibyte of coding
3273 to 0 (bug#9911) when sending a unibyte text.
3275 * callproc.c (Fcall_process): Set the member src_multibyte of
3276 process_coding to 0 (bug#9912).
3278 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3280 * xmenu.c (cleanup_widget_value_tree): New function.
3281 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3282 calling free_menubar_widget_value_tree directly (Bug#9830).
3284 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3286 Fix some portability problems with 'inline'.
3287 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3288 (window_box_width, window_box_left, window_box_left_offset)
3289 (window_box_right, window_box_right_offset): Declare extern.
3290 Otherwise, these inline functions do not conform to C99 and
3291 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3292 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3293 * intervals.c (adjust_intervals_for_insertion)
3294 (adjust_intervals_for_deletion): Now extern, because otherwise the
3295 extern inline functions 'offset_intervals' couldn't refer to it.
3296 (static_offset_intervals): Remove.
3297 (offset_intervals): Rewrite using the old contents of
3298 static_offset_intervals. The old version didn't conform to C99
3299 because an extern inline function contained a reference to an
3300 identifier with static linkage.
3302 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3304 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3307 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3309 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3310 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3311 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3312 return Qleft_to_right.
3314 2011-11-06 Chong Yidong <cyd@gnu.org>
3316 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3317 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3318 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3319 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3320 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3321 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3322 (Fwindow_vscroll): Doc fix.
3323 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3324 argument, since it makes no sense to pass a live window and for
3325 consistency with window-child.
3327 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3329 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3332 2011-11-05 Jason Rumney <jasonr@gnu.org>
3334 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3335 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3337 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3338 bitwise arithmetic preventing use of unicode-sip and non-truetype
3341 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3343 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3346 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3347 initialization code to keep similarity to xfns.c after changes
3350 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3352 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3353 (unwind_create_frame): New function (Bug#9943).
3354 (Fx_create_frame): Restructure code to be more similar to the one in
3355 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3356 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3357 Move terminal->reference_count++ just before making the frame official
3360 * nsterm.m (x_free_frame_resources): New function.
3361 (x_destroy_window): Move code to x_free_frame_resources.
3363 * xfns.c (unwind_create_frame): Fix comment.
3364 (Fx_create_frame, x_create_tip_frame):
3365 Move terminal->reference_count++ just before making the frame
3366 official. Move initialization of image_cache_refcount and
3367 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3369 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3371 Support MSVC build with newer versions of Visual Studio.
3372 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3373 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3376 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3377 which are not supported by MSVC.
3378 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3379 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3381 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3383 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3385 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3387 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3389 Support MSVC build with newer versions of Visual Studio.
3390 * w32.c: Don't include w32api.h for MSVC.
3391 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3393 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3394 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3395 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3396 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3398 (alloca) [_MSC_VER]: Define to _alloca.
3400 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3402 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3404 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3406 * xdisp.c (note_mouse_highlight): If either of
3407 previous/next-single-property-change returns nil, treat that as
3408 the beginning or the end of the buffer. (Bug#9955)
3410 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3412 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3413 label is not null (Bug#9951).
3414 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3417 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3419 * window.c (Fwindow_body_size): Mention in the doc string that the
3420 return value is in frame's canonical units. (Bug#9949)
3422 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3424 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3426 * w32fns.c (unwind_create_frame): If needed, free the glyph
3427 matrices of the partially constructed frame. (Bug#9943)
3428 * xfns.c (unwind_create_frame): Likewise.
3430 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3432 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3433 Don't stop backward scan on the continuation glyph, even though
3434 its CHARPOS is positive.
3435 (mouse_face_from_buffer_pos, note_mouse_highlight):
3436 Rename cover_string to disp_string.
3438 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3440 * window.c (temp_output_buffer_show): Don't use
3441 Vtemp_buffer_show_specifiers.
3442 (Vtemp_buffer_show_specifiers): Remove unused variable.
3444 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3446 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3447 past the beginning of the current glyph matrix.
3449 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3451 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3452 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3453 HAVE_GTK3 (Bug#9869).
3455 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3456 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3458 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3460 * xterm.c: Declare x_handle_net_wm_state to return int.
3461 (handle_one_xevent): Check if we are iconified but don't have
3462 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3463 (get_current_wm_state): Return non-zero if not hidden,
3464 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3465 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3466 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3467 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3469 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3471 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3472 so that this new function doesn't get optimized away by a
3473 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3475 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3477 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3479 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3481 Fix the `xbytecode' command.
3482 * .gdbinit (xprintbytestr): New command.
3483 (xwhichsymbols): Rename from `which'; all callers changed.
3484 (xbytecode): Print the byte-code string as well.
3486 2011-10-29 Kim Storm <storm@cua.dk>
3488 * alloc.c (which_symbols): New function.
3490 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3492 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3495 2011-10-29 Glenn Morris <rgm@gnu.org>
3497 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3498 Not clear what it was for, and it causes various bugs. (Bug#9839)
3500 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3502 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3503 possible random value that matches one of those tested as
3504 condition to clear the mouse face.
3506 2011-10-28 Chong Yidong <cyd@gnu.org>
3508 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3510 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3512 * window.c (make_window): Initialize phys_cursor_on_p.
3514 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3516 * lisp.h (struct Lisp_Symbol): Update comments.
3518 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3520 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3522 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3524 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3525 <oslsachem@gmail.com> for helping to debug this.
3527 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3528 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3529 (g_b_init_get_glyph_outline_w): New static variables.
3530 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3531 (GetGlyphOutlineW_Proc): New typedefs.
3532 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3533 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3535 (w32font_open_internal, compute_metrics):
3536 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3537 instead of calling the "wide" APIs directly.
3539 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3541 * w32.h (syms_of_w32font): Add prototype.
3543 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3545 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3546 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3547 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3548 (Fmove_to_window_line): Doc fix.
3550 2011-10-27 Chong Yidong <cyd@gnu.org>
3552 * process.c (make_process): Set gnutls_state to NULL.
3554 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3555 non-NULL, regardless of GNUTLS_INITSTAGE.
3556 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3557 an error. Set process slots as soon as we allocate them.
3559 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3561 2011-10-27 Chong Yidong <cyd@gnu.org>
3563 * gnutls.c (emacs_gnutls_deinit): New function.
3564 Deallocate credentials structures as well as calling gnutls_deinit.
3565 (Fgnutls_deinit, Fgnutls_boot): Use it.
3567 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3568 (deactivate_process): Call emacs_gnutls_deinit.
3570 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3572 * image.c (x_create_x_image_and_pixmap):
3573 * w32.c (sys_rename, w32_delayed_load):
3574 * w32font.c (fill_in_logfont):
3575 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3577 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3579 * w32fns.c (w32_default_color_map): New function,
3580 extracted from Fw32_default_color_map.
3581 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3583 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3585 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3587 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3589 * keyboard.c (test_undefined): New function (bug#9751).
3590 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3592 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3594 * sysdep.c (init_sys_modes): Fix the check for the controlling
3595 terminal (Bug#6649).
3597 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3599 * dispextern.h (struct bidi_it): New member next_en_type.
3601 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3602 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3603 current character, check also for next_en_type being WEAK_EN.
3604 (bidi_resolve_weak): Don't enter the expensive loop if the current
3605 position is before next_en_pos. Record the bidi type of the first
3606 non-ET, non-BN character we find, in addition to its position.
3607 (bidi_level_of_next_char): Invalidate next_en_type when
3608 next_en_pos is over-stepped.
3610 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3612 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3613 * editfns.c: Rewrite current-time-zone so that it invokes
3614 the equivalent of (format-time-string "%Z") to get the time zone name.
3615 This fixes a bug when the time zone name contains characters that
3616 need converting from the system time locale to Emacs internal format.
3617 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3618 that patch fixed format-time-string to do the conversion, but
3619 I forgot to fix current-time-zone.
3620 (format_time_string): New function, containing most of
3621 what Fformat_time_string used to contain.
3622 (Fformat_time_string): Rewrite in terms of format_time_string.
3623 This doesn't change this function's behavior.
3624 (current-time-zone): Rewrite to use format_time_string.
3625 This fixes the bug reported by Michael Schierl in
3626 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3627 Jason Rumney's 2007-06-07 change worked around this bug, but
3629 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3631 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3633 * xdisp.c (start_display): If the character at POS is displayed
3634 via a display vector, reset IT->current.dpvec_index to zero.
3635 (try_window_reusing_current_matrix): If a line ends in a display
3636 vector or the next line starts in a display vector, continue
3637 redrawing the window even though the character position of
3638 start_row was reached.
3641 2011-10-18 Chong Yidong <cyd@gnu.org>
3643 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3644 with nobreak-char-display too.
3646 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3648 Fix part 3 of bug#9771.
3649 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3650 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3651 non-neutral characters if the current character is a paragraph
3652 separator (a.k.a. Newline). This avoids running the same
3653 expensive loop twice, once when we consume the preceding newline
3654 and the other time when the line actually needs to be displayed.
3655 Avoid the loop when we see neutrals on the base embedding level
3656 following a character whose directionality is the same as the
3657 paragraph's. This avoids running the expensive loop when a line
3658 ends in a long sequence of neutrals, like control characters.
3659 Add assertion against STRONG_AL type. Slightly rearrange code
3660 that determines the type of a neutral given the first non-neutral
3662 (bidi_level_of_next_char): Set next_en_pos to zero when
3663 invalidating its info.
3665 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3667 * xdisp.c (push_display_prop): Determine whether to record string
3668 or buffer position by IT->string, not by IT->method. Allow
3669 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3670 (move_it_vertically_backward): Don't look for character position
3671 immediately after the newline when in a continuation line.
3674 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3676 * window.c (coordinates_in_window): Rewrite and delabelize
3677 vertical border check. (Bug#5357) (Bug#9618)
3679 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3681 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3682 errors in XSetWindowBorder (bug#9310).
3684 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3686 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3687 avoid crash when xmalloc overrun checking is enabled.
3689 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3691 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3692 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3693 cursor motion with <left> and <right> arrow keys.
3695 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3696 some callers set that themselves.
3698 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3700 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3701 display string and the previous row comes from the same string and
3702 is empty. (Bug#9739) (Bug#9738)
3704 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3706 * doc.c (get_doc_string): Encode file name (bug#9735).
3708 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3710 * bidi.c (bidi_level_of_next_char):
3711 * xdisp.c (get_visually_first_element): Remove old incorrect
3712 comments regarding the Unicode Line Separator character.
3714 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3716 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3718 * alloc.c (Fgc_status): Do not access beyond zombies array
3719 boundary if nzombies > MAX_ZOMBIES.
3720 * alloc.c (dump_zombies): Add missing format specifier.
3722 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3724 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3725 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3727 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3728 Some packages use them to denote characters with modifiers.
3730 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3732 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3733 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3734 matching a pp-number. Rename parameter var to var1.
3736 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3738 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3740 2011-10-08 Glenn Morris <rgm@gnu.org>
3742 * callint.c (Fcall_interactively): Give a more explicit error for the
3743 'c' case with a non-character input. (Bug#8479)
3745 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3747 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3749 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3750 lines that are hscrolled on the left.
3752 * dispnew.c (buffer_posn_from_coords): Account for a possible
3753 presence of header-line. (Bug#4426)
3755 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3757 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3758 Don't advertise functionality which we discourage or doesn't work.
3760 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3762 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3763 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3764 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3765 this makes Emacs dump core during garbage collection on rare
3766 occasions. sizeof is obviously inferior to offsetof here, so
3767 stick with offsetof.
3768 (GC_POINTER_ALIGNMENT): New macro.
3769 (mark_memory): Omit 3rd (offset) arg; caller changed.
3770 Don't assume EMACS_INT alignment is the same as pointer alignment.
3772 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3774 * keyboard.c (read_key_sequence_remapped): New var.
3775 (read_key_sequence): Compute remapping in the right buffer.
3776 (command_loop_1): Use read_key_sequence's remapping directly.
3778 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3780 * dired.c (file_name_completion): Don't expand file name.
3781 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3782 before checking file name handler.
3784 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3785 they've been requested explicitly (bug#9591).
3787 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3789 * keymap.c (Fsingle_key_description): Use make_specified_string
3790 instead of build_string to build string from push_key_description.
3793 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3795 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3796 This fixes a Y2038 bug on 64-bit hosts.
3797 * buffer.c (reset_buffer):
3798 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3799 (Fclear_buffer_auto_save_failure):
3800 Use 0, not -1, to represent an unset failure time, since time_t
3801 might not be signed.
3803 Remove dependency on glibc malloc internals.
3804 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3805 Move back here from lisp.h, but with their new implementations.
3806 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3807 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3808 * charset.c (charset_table_init): New static var.
3809 (syms_of_charset): Use it instead of xmalloc. This removes a
3810 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3811 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3812 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3813 Move back to alloc.c.
3814 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3815 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3817 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3819 * nsterm.m (windowDidResize): Call x_set_window_size only when
3820 ns_in_resize is true. Otherwise set pixelwidth/height and
3821 call change_frame_size (Bug#9628).
3823 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3825 Port --enable-checking=all to Fedora 14 x86-64.
3826 * charset.c (syms_of_charset): Also account for glibc malloc's
3827 internal overhead when calculating the initial malloc maximum.
3829 Port --enable-checking=all to Fedora 14 x86.
3830 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3832 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3833 (overrun_check_realloc, overrun_check_free):
3834 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3835 That way, xmalloc returns a properly-aligned pointer even if
3836 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3837 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3838 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3839 into account when calculating the initial malloc maximum.
3840 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3841 Move here from alloc.c, so that charset.c can use it too.
3842 Properly align; the old code wasn't right for common 32-bit hosts
3843 when configured with --enable-checking=all.
3844 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3845 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3847 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3849 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3852 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3854 * xdisp.c (compute_display_string_end): If there's no display
3855 string at CHARPOS, return -1.
3857 * bidi.c (bidi_fetch_char): When compute_display_string_end
3858 returns a negative value, treat the character as a normal
3859 character not covered by a display string. (Bug#9624)
3861 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3863 * lread.c (Fread_from_string): Fix typo in docstring.
3865 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3867 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3868 newline, reseat the iterator instead of bidi-iterating there one
3869 character at a time. (Bug#9610)
3870 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3871 TO_CHARPOS if the bidi iterator is at base embedding level.
3873 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3875 * lread.c (readevalloop): Use correct code for NBSP.
3876 (read1): Likewise. (Bug#9608)
3878 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3880 * dbusbind.c (Fdbus_register_signal): When service is not
3881 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3883 2011-09-25 Glenn Morris <rgm@gnu.org>
3885 * buffer.c (truncate-lines): Doc fix.
3887 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3889 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3890 (Fset_window_next_buffers): Doc fix.
3892 2011-09-24 Glenn Morris <rgm@gnu.org>
3894 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3896 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3898 Fix minor problems found by static checking.
3899 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3900 * indent.c (Fvertical_motion): Fix == vs = typo.
3902 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3904 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3905 Default value is now t. Doc fix.
3907 * indent.c (Fvertical_motion): Compute and apply the overshoot
3908 logic when moving up, not only when moving down. Fix the
3909 confusing name and values of the it_overshoot_expected variable;
3910 logic changes accordingly. (Bug#9254) (Bug#9549)
3912 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3913 CHARPOS is covered by a display string which includes newlines.
3914 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3915 is covered by a display string with embedded newlines.
3917 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3919 * dbusbind.c (Fdbus_register_signal): Add match rule to
3920 Vdbus_registered_objects_table. (Bug#9581)
3921 (Fdbus_register_method, Vdbus_registered_objects_table):
3924 2011-09-24 Jim Meyering <meyering@redhat.com>
3926 do not ignore write error for any output size
3927 The previous change was incomplete.
3928 While it makes emacs --batch detect the vast majority of stdout
3929 write failures, errors were still ignored whenever the output size is
3930 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3931 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3932 && echo FAIL: ignored write error
3933 FAIL: ignored write error
3934 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3935 && echo FAIL: ignored write error
3936 FAIL: ignored write error
3937 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3939 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3941 * emacs.c (Fkill_emacs): In noninteractive mode exit
3942 non-successfully if a write error occurred on stdout. (Bug#9574)
3944 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3946 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3949 * dispextern.h (struct it): Update the comment documenting what
3952 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3954 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3955 a display string, extend search for cursor position to end of row.
3956 (find_row_edges): If the row ends in a newline from a display
3957 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3958 Handle the case of a display string with multiple newlines.
3959 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3960 non-empty line. Fixes confusing cursor motion with arrow keys at
3961 the beginning of a line that starts with whitespace.
3963 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3965 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3968 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3970 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3973 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3975 * xdisp.c (display_line): Record maximum and minimum buffer
3976 positions even if no glyphs were produced (e.g., by a zero-width
3977 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3978 buffer positions that will be removed from the glyph row because
3980 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3981 column is beyond frame width: don't subtract 1 "pixel" when
3982 computing width of the stretch.
3983 (reseat_at_next_visible_line_start): Undo the change made on
3984 2011-09-17 that saved paragraph information and restored it after
3985 the call to `reseat'. (Bug#9545)
3987 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3989 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3990 and turn window cursor on if cleared (Bug#9415).
3992 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3994 * search.c (boyer_moore): Take unibyte characters from pattern
3995 literally. (Bug#9458)
3997 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3999 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4001 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4003 Fix minor problem found by static checking.
4004 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4005 initialized, to pacify gcc -Wuninitialized.
4007 * fileio.c: Report proper errno when syscall falls.
4008 (Finsert_file_contents): Save and restore errno,
4009 so that report_file_error outputs the correct diagnostic.
4010 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4012 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4014 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4016 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4018 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4019 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4021 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4023 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4024 about the current paragraph and restore it after the call to reseat.
4026 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4027 (bidi_find_paragraph_start): Search back for paragraph beginning
4028 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4029 (bidi_move_to_visually_next): Only trigger paragraph-related
4030 computations when the last character is a newline or at EOB, not
4031 just any NEUTRAL_B. (Bug#9470)
4033 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4034 truncated lines if point is covered by a display string. (Bug#9524)
4036 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4038 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4039 (cons_to_x_long): New function.
4040 (lisp_data_to_selection_data): Use it. Correct the test for
4041 short-versus-long data; it was negated. Break out of vector
4042 loop, for efficiency, when a long datum is discovered.
4044 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4046 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4048 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4050 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4051 GCC PR/17406) by declaring this function with external scope.
4053 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4055 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4056 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4058 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4060 * editfns.c (Fformat): Correctly handle text properties on "%%".
4062 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4064 * xterm.c (x_draw_composite_glyph_string_foreground):
4065 * w32term.c (x_draw_composite_glyph_string_foreground):
4066 * term.c (encode_terminal_code):
4067 * composite.c (composition_update_it, get_composition_id):
4068 * xdisp.c (get_next_display_element)
4069 (fill_composite_glyph_string): Add comments about special meaning
4070 of TAB characters in a composition.
4072 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4074 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4075 This occurs when processing a multibyte format.
4076 Problem reported by Wolfgang Jenker.
4078 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4080 * xdisp.c (try_cursor_movement): Only check for exact match if
4081 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4083 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4085 Remove unused external symbols.
4086 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4087 * xdisp.c (calc_pixel_width_or_height): Now static.
4088 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4089 * indent.c (check_display_width):
4090 * w32term.c: Fix comment to match code.
4091 * xterm.c, xterm.h (x_catching_errors): Remove.
4093 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4095 * xselect.c: Use signed conversions more consistently (Bug#9498).
4096 (selection_data_to_lisp_data): Assume incoming selection data are
4097 signed integers, not unsigned. This is to be consistent with
4098 outgoing selection data, which was modified to use signed integers
4099 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4100 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4101 expects long, not unsigned long.
4103 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4105 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4106 computation of loop end. Reported by Johan Bockgård
4109 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4111 * frame.c (Fother_visible_frames_p): Function deleted.
4113 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4115 * indent.c (compute_motion): Process display vector front to back
4116 rather than the other way around. (Bug#2496)
4118 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4120 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4122 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4124 * minibuf.c (Fread_from_minibuffer): Doc fix.
4126 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4128 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4129 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4131 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4133 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4134 value for non-existent files.
4136 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4138 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4139 set its "size" to -1. This will set the modtime_size field of
4140 the corresponding buffer to -1, which is what
4141 verify-visited-file-modtime expects for files that do not exist.
4144 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4146 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4148 * lisp.h: ... from here. push_key_description is no longer
4149 defined in keyboard.c, so its declaration should not be in
4150 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4151 logically belongs with push_key_description.
4153 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4155 * buffer.h: Include <sys/types.h> instead of <time.h>.
4156 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4157 Problem reported by Herbert J. Skuhra.
4159 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4161 * xml.c (parse_region): Make the parsing work for
4162 non-comment-starting XML files again (bug#9144).
4164 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4166 * image.c (gif_load): Fix calculation of bottom and right corner.
4169 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4171 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4172 redisplay in small windows.
4174 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4176 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4178 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4180 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4181 Operate on live windows only.
4183 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4185 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4187 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4189 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4190 only under bidi iteration.
4192 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4194 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4196 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4198 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4199 Without this fix, the command to link temacs failed due to an
4200 undefined symbol __builtin_isnan. This is because
4201 /usr/include/iso/math_c99.h #defines isnan(x) to
4202 __builtin_isnan(x), but the bundled gcc, which identifies itself
4203 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4205 * floatfns.c (isnan): #undef, and then #define to a clone of
4207 (Fisnan): Always define, since it's always available now.
4208 (syms_of_floatfns): Always define isnan at the Lisp level.
4210 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4212 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4214 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4216 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4217 The previous code assumed that file offsets (off_t values) fit in
4218 EMACS_INT variables, which is not true on typical 32-bit hosts.
4219 The code messed up by falsely reporting buffer overflow in cases
4220 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4221 when "big" contains more than 2**29 bytes, even though this
4222 inserts just one byte and does not overflow the buffer.
4223 (Finsert_file_contents): Store file offsets as off_t
4224 values, not as EMACS_INT values. Check for overflow when
4225 converting between EMACS_INT and off_t. When checking for
4226 buffer overflow or for overlap, take the offsets into account.
4227 Don't use EMACS_INT for small values where int suffices.
4228 When checking for overlap, fix a typo: ZV was used where
4229 ZV_BYTE was intended.
4230 (Fwrite_region): Don't assume off_t fits into 'long'.
4231 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4233 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4235 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4237 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4239 sprintf-related integer and memory overflow issues (Bug#9412).
4241 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4242 (esprintf, exprintf, evxprintf): New functions.
4243 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4244 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4245 (modify_event_symbol): Do not assume that the length of
4246 name_alist_or_stem is safe to alloca and fits in int.
4247 (Fexecute_extended_command): Likewise for function name and binding.
4248 (Frecursion_depth): Wrap around reliably on integer overflow.
4249 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4250 since some callers pass EMACS_INT values.
4251 (Fsingle_key_description): Don't crash if symbol name contains more
4252 than MAX_ALLOCA bytes.
4253 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4254 (get_minibuffer): Arg is now EMACS_INT, not int.
4255 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4256 (esprintf, exprintf, evxprintf): New decls.
4257 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4259 * dbusbind.c (signature_cat): New function.
4260 (xd_signature, Fdbus_register_signal):
4261 Do not overrun buffer; instead, report string overflow.
4263 * dispnew.c (add_window_display_history): Don't overrun buffer.
4264 Truncate instead; this is OK since it's just a log.
4266 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4267 even if the time zone offset is outlandishly large.
4268 Don't mishandle offset == INT_MIN.
4270 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4271 when creating daemon; the previous buffer-overflow check was incorrect.
4273 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4274 which has the guts of the old verror function.
4276 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4277 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4279 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4280 (font_unparse_xlfd): Don't blindly alloca long strings.
4281 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4282 fits in int, when using sprintf. Use single snprintf to count
4283 length of string rather than counting it via multiple sprintfs;
4284 that's simpler and more reliable.
4285 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4286 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4287 sprintf, in case result does not fit in int.
4289 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4290 (fontset_from_font): Print it.
4292 * frame.c (tty_frame_count): Now printmax_t, not int.
4293 (make_terminal_frame, set_term_frame_name): Print it.
4294 (x_report_frame_params): In X, window IDs are unsigned long,
4295 not signed long, so print them as unsigned.
4296 (validate_x_resource_name): Check for implausibly long names,
4297 and don't assume name length fits in 'int'.
4298 (x_get_resource_string): Don't blindly alloca invocation name;
4299 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4302 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4303 (xg_check_special_colors, xg_set_geometry):
4304 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4306 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4307 Use esprintf, not sprintf, in case result does not fit in int.
4309 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4310 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4311 it as a large positive number.
4312 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4313 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4315 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4316 in case result does not fit in int.
4318 * print.c (float_to_string): Detect width overflow more reliably.
4319 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4320 buffer overrun. Don't assume list length fits in 'int'. Treat
4321 print length of 0 as 0, not as infinity; to be consistent with other
4322 uses of print length in this function. Don't overflow print length
4323 index. Don't assume hash table size fits in 'long', or that
4324 vectorlike size fits in 'unsigned long'.
4326 * process.c (make_process): Use printmax_t, not int, to format
4327 process-name gensyms.
4329 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4331 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4332 to avoid potential buffer overrun.
4334 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4335 if X resource line is longer than 512 bytes.
4337 * xfns.c (x_window): Make sprintf buffer a bit bigger
4338 to avoid potential buffer overrun.
4340 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4342 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4344 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4346 Integer overflow fixes for scrolling, etc.
4347 Without these, Emacs silently mishandles large integers sometimes.
4348 For example, "C-u 4294967297 M-x recenter" was treated as if
4349 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4351 * xdisp.c (try_window_id): Check Emacs fixnum range before
4352 converting to 'int'.
4354 * window.c (window_scroll_line_based, Frecenter):
4355 Check that an Emacs fixnum is in range before assigning it to 'int'.
4356 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4357 values converted from Emacs fixnums.
4358 (Frecenter): Don't wrap around a line count if it is out of 'int'
4359 range; instead, treat it as an extreme value.
4360 (Fset_window_configuration, compare_window_configurations):
4361 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4363 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4364 that can exceed INT_MAX. Check that EMACS_INT value is in range
4365 before assigning it to the (possibly-narrower) index.
4366 (match_limit): Don't assume that a fixnum can fit in 'int'.
4368 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4371 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4372 (Fvertical_motion): Don't wrap around LINES values that don't fit
4373 in 'int'. Instead, treat them as extreme values. This is good
4374 enough for windows, which can't have more than INT_MAX lines anyway.
4376 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4378 * Require libxml/parser.h to avoid compilation warning.
4380 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4382 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4383 since this reportedly can destroy thread storage.
4385 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4387 * syntax.c (find_defun_start): Update all cache variables if
4388 exiting early (Bug#9401).
4390 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4392 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4394 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4395 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4396 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4398 * term.c (tty_append_glyph): New function.
4399 (produce_stretch_glyph): Static function and its prototype deleted.
4401 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4404 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4406 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4407 when checking :margin (Bug#9390).
4408 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4409 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4410 so that the name doesn't mislead. All uses changed.
4412 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4414 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4417 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4419 * xdisp.c (move_it_to): Don't bail out early when reaching
4420 position beyond to_charpos, if we are scanning backwards.
4421 (move_it_vertically_backward): When DY == 0, make sure we get to
4422 the first character in the line after the newline.
4424 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4426 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4427 (ccl_driver): Do not generate an out-of-range pointer.
4428 (Fccl_execute_on_string): Remove unnecessary check for
4429 integer overflow, noted by Stefan Monnier in
4430 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4431 Remove a FIXME that didn't need fixing.
4432 Simplify the newly-introduced buffer reallocation code.
4434 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4436 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4438 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4440 Integer and memory overflow issues (Bug#9196).
4442 * doc.c (get_doc_string): Rework so that
4443 get_doc_string_buffer_size is the actual buffer size, rather than
4444 being 1 less than the actual buffer size; this makes xpalloc more
4447 * image.c (x_allocate_bitmap_record, cache_image):
4448 * xselect.c (Fx_register_dnd_atom):
4449 Simplify previous changes by using xpalloc.
4451 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4452 since either will do and ptrdiff_t is convenient with xpalloc.
4454 * charset.c (charset_table_size)
4455 (struct charset_sort_data.priority): Now ptrdiff_t.
4456 (charset_compare): Don't overflow if priorities differ greatly.
4457 (Fsort_charsets): Don't assume list length fits in int.
4458 Check for size-calculation overflow when allocating sort data.
4459 (syms_of_charset): Allocate an initial charset table that is
4460 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4462 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4464 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4465 The actual value is always <= INT_MAX, and leaving it unsigned made
4466 overflow checking harder.
4468 * dispextern.h (struct glyph_matrix.rows_allocated)
4469 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4470 with xpalloc. The values are still always <= INT_MAX.
4472 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4474 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4475 (SAFE_NALLOCA): New macro.
4477 * region-cache.c (struct boundary.pos, find_cache_boundary)
4478 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4479 (set_cache_region, invalidate_region_cache)
4480 (revalidate_region_cache, know_region_cache, region_cache_forward)
4481 (region_cache_backward, pp_cache):
4482 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4483 so that ptrdiff_t * can be passed to xpalloc.
4484 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4485 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4486 (pp_cache): Don't assume cache_len fits in int.
4487 * region-cache.h: Adjust extern decls to match.
4489 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4490 EMACS_INT, since either will do, for xpalloc.
4492 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4493 (xnmalloc, xnrealloc, xpalloc): New functions.
4495 * bidi.c (bidi_shelve_header_size): New constant.
4496 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4497 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4499 * bidi.c (bidi_cache_shrink):
4500 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4502 Don't update size of array until after memory allocation succeeds,
4503 because xmalloc/xrealloc may not return.
4504 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4505 now that we have proper integer overflow checking.
4506 (record_overlay_string, overlay_strings): Catch overflows when
4507 calculating size of overlay_str_buf.
4509 * callproc.c (Fcall_process): Check for size overflow when
4510 calculating size of args2.
4511 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4512 Normally we prefer signed values, but sticking with ptrdiff_t would
4513 require adding more-complicated checks.
4515 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4516 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4517 Redo buffer-overflow calculations to avoid integer overflow.
4518 Add a FIXME comment where memory seems to be over-allocated.
4520 * character.c (Fstring): Check for size-calculation overflow.
4522 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4523 unnecessary integer overflow. Check for size overflow.
4524 (encode_coding_object): Don't update size until xmalloc succeeds.
4526 * composite.c (get_composition_id): Check for overflow in glyph
4527 length calculations.
4529 Integer and memory overflow fixes for display code.
4530 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4531 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4532 (scrolling_window): Check for overflow in size calculations.
4533 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4534 Don't assume glyph table len fits in int.
4535 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4536 (row_table_size): Now ptrdiff_t, not int.
4537 (scrolling_window): Avoid overflow in size calculations.
4538 Don't update size until allocation succeeds.
4539 * fns.c (concat): Check for overflow in size calculations.
4540 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4541 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4542 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4544 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4545 (get_doc_string): Check for size calculation overflow.
4546 Don't update size until allocation succeeds.
4547 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4548 EMACS_INT, where ptrdiff_t will do.
4549 (Fsubstitute_command_keys): Check for string overflow.
4551 * editfns.c (set_time_zone_rule): Don't assume environment length
4553 (message_length): Now ptrdiff_t, not int.
4554 (Fmessage_box): Don't update size until allocation succeeds.
4555 Don't assume message length fits in int.
4556 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4558 * emacs.c (main): Do not reallocate argv, since there is a null at
4559 the end that can be overwritten, and this way there's no need to
4560 worry about size-calculation overflow.
4561 (sort_args): Check for size-calculation overflow.
4563 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4565 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4567 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4568 (x_set_scroll_bar_width, x_figure_window_size):
4569 Check for integer overflow.
4570 (x_set_alpha): Do not assume XINT fits in int.
4572 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4573 This is for the members text_lines, text_cols, total_lines, total_cols,
4574 where the system imposes an 'int' limit.
4576 * fringe.c (Fdefine_fringe_bitmap):
4577 Don't update size until alloc works.
4579 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4580 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4582 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4583 Check for size-calculation overflow.
4584 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4585 do, as we prefer signed integers.
4586 (id_to_widget.max_size, id_to_widget.used)
4587 (xg_store_widget_in_map, xg_remove_widget_from_map)
4588 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4589 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4590 Use and return ptrdiff_t, not int.
4591 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4592 * gtkutil.h: Change prototypes to match the above.
4594 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4595 are duplicate now that they've been promoted to lisp.h.
4596 (x_allocate_bitmap_record, x_alloc_image_color)
4597 (make_image_cache, cache_image, xpm_load):
4598 Don't update size until alloc is done.
4599 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4601 Check for size calculation overflow.
4602 (ct_colors_allocated_max): New constant.
4603 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4606 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4607 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4608 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4609 Use ptrdiff_t, not int, to count maps.
4610 (read_char_minibuf_menu_prompt): Check for overflow in size
4611 calculations. Don't update size until allocation succeeds.
4612 Redo calculations to avoid overflow.
4613 * keyboard.h: Change prototypes to match the above.
4615 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4617 (current_minor_maps): Check for size calculation overflow.
4618 * keymap.h: Change prototypes to match the above.
4620 * lread.c (read1, init_obarray): Don't update size until alloc done.
4622 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4623 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4625 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4626 Now ptrdiff_t, not int.
4627 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4628 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4630 * process.c (Fnetwork_interface_list): Check for overflow
4631 in size calculation.
4633 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4635 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4636 overflow. Don't bother calling xmalloc when xrealloc will do.
4638 * search.c (Freplace_match): Check for size calculation overflow.
4639 (Fset_match_data): Don't assume list lengths fit in 'int'.
4641 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4642 for command line length. Do not attempt to address one before the
4643 beginning of an array, as that's not portable.
4645 * term.c (max_frame_lines): Remove; unused.
4646 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4648 (encode_terminal_code, calculate_costs): Check for size
4649 calculation overflow.
4650 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4651 table lengths and related sizes. Don't update size until alloc
4652 done. Redo calculations to avoid overflow.
4653 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4655 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4656 subtracting pointers.
4657 (gobble_line): Check for overflow more carefully. Don't update size
4660 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4661 Don't update size until alloc done.
4662 Redo size calculations to avoid overflow.
4663 Check for size calculation overflow.
4664 (main) [DEBUG]: Fix typo in invoking tparam1.
4666 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4667 Use ptrdiff_t, not int, for sizes.
4668 (store_mode_line_noprop_char): Don't update size until alloc done.
4670 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4671 Use ptrdiff_t, not int, for sizes.
4672 (Finternal_make_lisp_face, cache_face):
4673 Check for size calculation overflow.
4674 (cache_face): Treat size calculation overflows as if they were
4675 memory exhaustion (the usual treatment), rather than aborting.
4677 * xfns.c (x_encode_text, x_set_name_internal)
4678 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4679 sizes, since they can exceed INT_MAX in size. Check for size
4680 calculation overflow.
4682 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4683 (xg_select): Check for size calculation overflow.
4684 Don't update size until alloc done.
4686 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4687 as sprintf is limited to int lengths.
4689 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4690 (X_LONG_MIN): New macros.
4691 Use them to make the following changes clearer.
4692 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4693 This change doesn't affect the value now, but it may help remind
4694 future maintainers not to raise the value too much later.
4695 (SELECTION_QUANTUM): Remove, replacing with ...
4696 (selection_quantum): ... new function, which avoids overflow.
4698 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4699 assumption that selection length fits in 'int'.
4700 (x_reply_selection_request, x_handle_selection_request)
4701 (x_get_window_property, receive_incremental_selection)
4702 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4703 (lisp_data_to_selection_data, clean_local_selection_data):
4704 Use ptrdiff_t, not int, to record length of selection.
4705 (x_reply_selection_request, x_get_window_property)
4706 (receive_incremental_selection, x_property_data_to_lisp):
4707 Redo calculations to avoid overflow.
4708 (x_reply_selection_request): When sending hint, ceiling it at
4709 X_LONG_MAX rather than relying on wraparound overflow to send
4711 (x_get_window_property, receive_incremental_selection)
4712 (lisp_data_to_selection_data, x_property_data_to_lisp):
4713 Check for size-calculation overflow.
4714 (x_get_window_property, receive_incremental_selection)
4715 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4716 Don't store size until memory allocation succeeds.
4717 (x_get_window_property): Plug memory leak on memory exhaustion.
4718 Don't double-block input; malloc is safe here. Don't assume 2**34
4719 - 4 fits in unsigned long. Add an xassert to check
4720 XGetWindowProperty overflow. Be more careful about overflow
4721 calculations, and distinguish size from memory overflow better.
4722 (receive_incremental_selection): When tracing, don't assume
4723 unsigned int is less than INT_MAX.
4724 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4725 harmful) conversions of unsigned short to int.
4726 (lisp_data_to_selection_data): Don't assume that integers
4727 in the range -65535 through -1 fit in an X unsigned short.
4728 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4729 result parameters unless successful. Rely on cons_to_unsigned
4730 to report problems with elements; the old code wasn't right anyway.
4731 (x_check_property_data): Check for int overflow; we cannot use
4732 a wider type due to X limits.
4733 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4735 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4737 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4738 (x_term_init): Check for size calculation overflow.
4739 (x_color_cells): Don't store size until memory allocation succeeds.
4740 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4741 Don't assume alloca size is less than MAX_ALLOCA.
4742 (x_term_init): Don't assume length fits in int (sprintf is limited
4745 Use ptrdiff_t for composition IDs.
4746 * character.c (lisp_string_width):
4747 * composite.c (composition_table_size, n_compositions)
4748 (get_composition_id, composition_gstring_from_id):
4749 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4750 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4751 * window.c (Frecenter):
4752 Use ptrdiff_t, not int, for composition IDs.
4753 * composite.c (get_composition_id): Check for integer overflow.
4754 * composite.h: Adjust prototypes to match the above changes.
4756 Use ptrdiff_t for hash table indexes.
4757 * category.c (hash_get_category_set):
4758 * ccl.c (ccl_driver):
4759 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4760 * coding.c (coding_system_charset_list, detect_coding_system):
4761 * coding.h (struct coding_system.id):
4762 * composite.c (get_composition_id, gstring_lookup_cache):
4763 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4764 * image.c (xpm_get_color_table_h):
4765 * lisp.h (hash_lookup, hash_put):
4766 * minibuf.c (Ftest_completion):
4767 Use ptrdiff_t for hash table indexes, not int (which is too
4768 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4769 32-bit --with-wide-int hosts).
4771 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4772 Add a FIXME comment about memory leaks.
4773 (syms_of_charset): Don't assume xmalloc returns.
4775 Don't assume that stated character widths fit in int.
4776 * character.c (Fchar_width, c_string_width, lisp_string_width):
4777 * character.h (CHAR_WIDTH):
4778 * indent.c (MULTIBYTE_BYTES_WIDTH):
4779 Use sanitize_char_width to avoid undefined and/or bad behavior
4780 with outlandish widths.
4781 * character.h (sanitize_tab_width): Rename from sanitize_width,
4782 now that we have two such functions. All uses changed.
4783 (sanitize_char_width): New inline function.
4785 Don't assume that tab-width fits in int.
4786 * character.h (sanitize_width): New inline function.
4787 (SANE_TAB_WIDTH): New macro.
4788 (ASCII_CHAR_WIDTH): Use it.
4789 * indent.c (sane_tab_width): Remove. All uses replaced by
4790 SANE_TAB_WIDTH (current_buffer).
4791 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4793 * fileio.c: Integer overflow issues with file modes.
4794 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4796 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4797 Remove unreachable code.
4798 (read_hex, load_charset_map_from_file): Check for integer overflow.
4800 * xterm.c: Don't go over XClientMessageEvent limit.
4801 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4802 (x_send_scroll_bar_event): Likewise. Check that the size does not
4803 exceed limits imposed by XClientMessageEvent, as well as the usual
4804 ptrdiff_t and size_t limits.
4806 * keyboard.c: Overflow, signedness and related fixes.
4807 (make_lispy_movement): Use same integer type in forward decl
4808 that is used in the definition.
4809 (read_key_sequence, keyremap_step):
4810 Change bufsize argument back to int, undoing my 2011-03-30 change.
4811 We prefer signed types, and int is wide enough here.
4812 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4813 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4814 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4815 length, not size_t. Use ptrdiff_t for index, not int.
4816 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4817 possibility of integer overflow.
4819 Overflow, signedness and related fixes for images.
4821 * dispextern.h (struct it.stack[0].u.image.image_id)
4822 (struct_it.image_id, struct image.id, struct image_cache.size)
4823 (struct image_cache.used, struct image_cache.ref_count):
4824 * gtkutil.c (update_frame_tool_bar):
4825 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4826 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4827 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4828 * nsmenu.m (update_frame_tool_bar):
4829 * xdisp.c (calc_pixel_width_or_height):
4830 * xfns.c (image_cache_refcount):
4831 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4832 on typical 64-bit hosts.
4834 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4835 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4836 Omit unnecessary casts to int.
4837 (parse_image_spec): Check that integers fall into 'int' range
4838 when the callers expect that.
4839 (image_ascent): Redo ascent calculation to avoid int overflow.
4840 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4841 (lookup_image): Remove unnecessary tests.
4842 (xbm_image_p): Locals are now of int, not EMACS_INT,
4843 since parse_image_check makes sure they fit into int.
4844 (png_load, gif_load, svg_load_image):
4845 Prefer int to unsigned where either will do.
4846 (tiff_handler): New function, combining the cores of the
4847 old tiff_error_handler and tiff_warning_handler.
4848 This function is rewritten to use vsnprintf and thereby avoid
4849 stack buffer overflows. It uses only the features of vsnprintf
4850 that are common to both POSIX and native Microsoft.
4851 (tiff_error_handler, tiff_warning_handler): Use it.
4852 (tiff_load, gif_load, imagemagick_load_image):
4853 Don't assume :index value fits in 'int'.
4854 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4855 (imagemagick_load_image): Check that crop parameters fit into
4856 the integer types that MagickCropImage accepts. Don't assume
4857 Vimagemagick_render_type has a nonnegative value. Don't assume
4858 size_t fits in 'long'.
4859 (gs_load): Use printmax_t to print the widest integers possible.
4860 Check for integer overflow when computing image height and width.
4862 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4864 * xdisp.c (redisplay_window): Don't force window start if point
4865 will be invisible in the resulting window. (Bug#9324)
4867 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4869 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4870 the display spec is of the form `(space ...)'.
4871 (handle_display_spec): Return the value returned by
4872 handle_single_display_spec, not just 1 or zero.
4873 (handle_single_display_spec): If the display spec is of the form
4874 `(space ...)', and specifies display in the text area, return 2
4876 (try_cursor_movement): Check for the need to scroll more
4877 accurately, and prefer exact match for point under bidi.
4878 Don't advance `row' beyond the last row of the window.
4880 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4881 into disp_prop; all users changed.
4883 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4884 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4885 for the text covered by the display property.
4887 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4889 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4890 Change return value to nil.
4891 (Frecord_buffer): Delete unused function.
4893 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4895 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4896 buffers, return left-to-right.
4897 (set_cursor_from_row): Consider candidate row a win if its glyph
4898 represents a newline and point is on that newline. Fixes cursor
4899 positioning on the newline at EOL of R2L text within L2R
4900 paragraph, and vice versa.
4901 (try_cursor_movement): Check continued rows, in addition to
4902 continuation rows. Fixes unwarranted scroll when point enters a
4903 continued line of R2L text within an L2R paragraph, or vice versa.
4904 (cursor_row_p): Consider the case of point being equal to
4905 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4906 from the end of a short line to the beginning of a continued line
4907 of R2L text within L2R paragraph.
4908 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4909 composed characters.
4911 * bidi.c (bidi_check_type): Use xassert.
4912 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4915 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4917 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4920 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4922 * nsfont.m (ns_otf_to_script): Fix typo.
4924 2011-08-22 Kenichi Handa <handa@m17n.org>
4926 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4927 extra slot even if the purpose is char-code-property-table.
4929 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4931 * xdisp.c (redisplay_window): When computing centering_position,
4932 account for the height of the header line. (Bug#8874)
4934 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4935 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4936 candidate is selected by the mouse, and that candidate has a
4937 composed character under the mouse.
4939 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4940 coordinates reported by pos-visible-in-window-p for a composed
4941 character in column zero.
4943 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4945 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4947 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4949 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4950 consider it a hit if to_charpos is anywhere in the range of the
4951 composed buffer positions.
4953 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4955 * image.c (gif_load): Don't assume that each subimage has the same
4956 dimensions as the base image. Handle disposal method that is
4957 "undefined" by the gif spec (Bug#9335).
4959 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4961 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4962 (Fcondition_case): Document `debug' symbol in error handler.
4964 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4966 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4967 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4968 from an Org mode buffer to a Speedbar frame.
4970 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4971 a composition, take its buffer position from IT->cmp_it.charpos.
4972 Fixes cursor positioning at the beginning of a line that begins
4973 with a composed character.
4975 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4977 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4978 character bidirectional type, use STRONG_L instead. Fixes crashes
4979 in a buffer produced by `describe-categories'.
4981 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4982 members before the level stack, so they would be saved and
4983 restored when copying iterator state. Fixes incorrect reordering
4984 around TABs covered by display properties.
4986 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4988 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4990 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4992 * eval.c (internal_condition_case, internal_condition_case_1)
4993 (internal_condition_case_2, internal_condition_case_n):
4994 Remove unnecessary aborts (Bug#9081).
4996 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4998 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4999 has no `load' handler, try opening the file locally. (Bug#9311)
5001 2011-08-16 Ken Brown <kbrown@cornell.edu>
5003 * gmalloc.c: Expand comment.
5005 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5007 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5008 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5010 2011-08-16 Ken Brown <kbrown@cornell.edu>
5012 Fix memory allocation problems in Cygwin build (Bug#9273).
5014 * unexcw.c ( __malloc_initialized): Declare external variable.
5015 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5017 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5019 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5021 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5023 [CYGWIN] (special_realloc): New function.
5024 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5025 requests to realloc storage in the static heap.
5027 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5029 * bidi.c (bidi_initialize): Remove unused local.
5031 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5034 * biditype.h: Remove file.
5035 * makefile.w32-in ($(BLD)/bidi.$(O)):
5036 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5038 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5040 * chartab.c: Improve commentary for the uniprop_table API.
5042 * bidi.c (bidi_paragraph_init): Support zero value of
5043 bidi_ignore_explicit_marks_for_paragraph_level.
5044 (bidi_initialize): Use uniprop_table instead of including
5045 biditype.h and bidimirror.h.
5047 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5048 coordinates of the iterator when restoring from ppos_it.
5051 2011-08-14 Kenichi Handa <handa@m17n.org>
5053 * process.c (create_process): Call setup_process_coding_systems
5054 after the pid of the process is set to -1 (Bug#8162).
5056 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5058 * xdisp.c (move_it_in_display_line_to): Don't invoke
5059 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5060 ppos_it. Fixes vertical cursor motion when line beginning is
5061 covered by an image. (Bug#9296)
5063 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5065 * nsterm.h (ns_run_ascript): Declare.
5066 (NSAPP_DATA2_RUNASSCRIPT): Define.
5068 * nsfns.m (as_script, as_result, as_status): New static variables.
5069 (ns_run_ascript): New function.
5070 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5071 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5072 the event loop. Get status from as_status (Bug#7276).
5074 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5075 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5076 the event loop (Bug#7276).
5078 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5080 * gnutls.c (QCgnutls_bootprop_priority)
5081 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5082 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5083 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5084 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5085 (QCgnutls_bootprop_verify_hostname_error)
5086 (QCgnutls_bootprop_callbacks_verify): Rename from
5087 Qgnutls_bootprop_..., all uses changed.
5089 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5092 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5094 * xfaces.c (Qframe_set_background_mode): Now static.
5095 * dispextern.h (Qframe_set_background_mode): Remove decl.
5097 * process.c (Fnetwork_interface_info): Declare local only if needed.
5099 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5101 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5102 (Fnetwork_interface_list): Allocate in increments of bytes instead
5103 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5104 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5106 (struct ifflag_def): notrailers is smart on OSX.
5107 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5108 Get hardware address with getifaddrs if available.
5110 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5112 * xdisp.c (iterate_out_of_display_property): xassert that
5113 IT->position is set to within IT->object's boundaries. Break from
5114 the loop as soon as EOB is reached; avoids infloops in redisplay
5115 when IT->position is set up wrongly due to some bug.
5116 Set IT->current to match the bidi iterator unconditionally.
5117 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5118 entry. Force push_it to save on the stack the current
5119 buffer/string position, to be restored by pop_it. Fix flags in
5120 the iterator structure wrt the object coming from a display
5121 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5122 properties. (Bug#9284)
5124 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5126 * fontset.c (fontset_get_font_group): Add proper type checks.
5129 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5131 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5132 and LC_VERSION_MIN_MACOSX.
5133 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5134 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5136 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5138 * xdisp.c (forward_to_next_line_start): Allow to use the
5139 no-display-properties-and-no-overlays under bidi display.
5140 Set disp_pos in the bidi iterator to avoid searches for display
5141 properties and overlays.
5143 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5145 * editfns.c (Fset_time_zone_rule): Document relationship with the
5148 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5149 the font entity extracted from the cache (Bug#8109).
5151 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5153 * composite.c (autocmp_chars): Don't reset point. That is done by
5154 restore_point_unwind (Bug#5984).
5156 2011-08-07 Juri Linkov <juri@jurta.org>
5158 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5159 to show the arg `TIME' instead of `TIMEVAL'.
5161 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5163 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5164 display property strides EOL and includes a newline, as in
5165 longlines-mode. (Bug#9254)
5166 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5167 word-wrap under bidirectional display. (Bug#9224)
5169 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5170 is non-zero, even if the data buffer is NULL. Fixes a crash in
5171 vertical-motion with longlines-mode. (Bug#9254)
5173 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5175 * bidi.c <bidi_cache_total_alloc>: Now static.
5176 (bidi_initialize): Initialize bidi_cache_total_alloc.
5178 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5181 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5182 amount allocated this far in `bidi_cache_total_alloc'.
5183 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5184 non-zero, only free the data buffer without restoring the cache
5185 contents. All callers changed.
5187 * dispextern.h (bidi_unshelve_cache): Update prototype.
5189 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5190 (move_it_in_display_line, move_it_to)
5191 (move_it_vertically_backward, move_it_by_lines): Replace the call
5192 to xfree to an equivalent call to bidi_unshelve_cache.
5193 (move_it_in_display_line_to): Fix logic of returning
5194 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5196 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5198 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5199 came from a string character with a `cursor' property. (Bug#9229)
5201 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5203 * Makefile.in (LIB_PTHREAD): New variable.
5204 (LIBES): Add LIB_PTHREAD (Bug#9216).
5206 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5207 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5209 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5211 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5213 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5215 * xterm.c (x_find_topmost_parent): New function.
5216 (x_set_frame_alpha): Find topmost parent window with
5217 x_find_topmost_parent and set the property there also (bug#9181).
5218 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5220 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5222 * callproc.c (Fcall_process): Avoid vfork clobbering
5223 the local vars buffer, coding_systems, current_dir.
5225 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5227 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5229 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5231 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5232 so that it is not optimized away.
5234 * xdisp.c (compute_display_string_pos): Remove unused local.
5236 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5238 Fix slow cursor motion and scrolling in large buffers with
5239 selective display, like Org Mode buffers. (Bug#9218)
5241 * dispextern.h (struct bidi_it): New member disp_prop_p.
5243 * xdisp.c: Remove one-slot cache of display string positions.
5244 (compute_display_string_pos): Accept an additional argument
5245 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5246 for a display string or property. If found, set DISP_PROP_P
5249 * bidi.c (bidi_fetch_char): Accept an additional argument
5250 DISP_PROP_P, and pass it to compute_display_string_pos.
5251 Only handle text covered by a display string if DISP_PROP_P is returned
5252 non-zero. All callers of bidi_fetch_char changed.
5254 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5256 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5258 2010-12-03 Don March <don@ohspite.net>
5260 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5261 last character M-[char] is translated to ESC [char] (bug#7541).
5263 2011-08-02 Kenichi Handa <handa@m17n.org>
5265 * lisp.h (uniprop_table): Extern it.
5267 * chartab.c (uniprop_table): Make it non-static.
5269 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5271 * xdisp.c (forward_to_next_line_start): Accept additional argument
5272 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5274 (reseat_at_next_visible_line_start): Use the bidi iterator state
5275 returned by forward_to_next_line_start to restore the state of
5276 it->bidi_it after backing up to previous newline. (Bug#9212)
5278 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5280 * regex.c (re_comp): Protoize.
5281 (re_exec): Fix return type.
5282 (regexec): Fix type of `ret'. (Bug#9203)
5284 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5286 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5287 This is needed if max-image-size is a floating-point number.
5289 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5291 * print.c (print_object): Print empty symbol as ##.
5293 * lread.c (read1): Read ## as empty symbol.
5295 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5297 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5298 setting frame foreground color (Bug#9175).
5299 (x_set_background_color): Likewise.
5301 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5302 contents (Bug#9176).
5303 (EmacsTooltip -init): Remove bezels and add shadows to
5306 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5307 or scroll bar (Bug#8470).
5309 * nsfont.m (nsfont_open): Remove assignment to voffset and
5310 unnecessary vars hshink, expand, hd, full_height, min_height.
5311 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5313 * nsterm.h (nsfont_info): Remove voffset field.
5315 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5317 Implement strike-through and overline on NextStep (Bug#8863).
5319 * nsfont.m (nsfont_open): Use underline position provided by font,
5320 instead of hard-coded value of 2.
5321 (nsfont_draw): Call ns_draw_text_decoration instead.
5323 * nsterm.h: Add declaration for ns_draw_text_decoration.
5325 * nsterm.m (ns_draw_text_decoration): New function for drawing
5326 underline, overline, and strike-through.
5327 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5328 ns_draw_text_decoration. Change treatment of cursor drawing to
5329 accommodate underlining, etc.
5331 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5333 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5336 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5338 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5339 Without this fix, if a signal arrives just after memory fills up,
5340 'malloc' might be invoked reentrantly.
5342 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5343 In other words, assume that every image size is allowed, on non-X
5344 hosts. This assumption is probably wrong, but it lets Emacs compile.
5346 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5348 * regex.c (re_iswctype): Convert return values to boolean.
5350 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5352 * xdisp.c (compute_display_string_pos): Don't use cached display
5353 string position if the buffer had its restriction changed.
5356 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5358 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5360 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5362 Integer signedness and overflow and related fixes. (Bug#9079)
5364 * bidi.c: Integer size and overflow fixes.
5365 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5366 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5367 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5368 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5369 (bidi_find_other_level_edge):
5370 Use ptrdiff_t instead of EMACS_INT where either will do.
5371 This works better on 32-bit hosts configured --with-wide-int.
5372 (bidi_cache_ensure_space): Check for size-calculation overflow.
5373 Use % rather than repeated addition, for better worst-case speed.
5374 Don't set bidi_cache_size until after xrealloc returns, because it
5376 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5377 (bidi_cache_ensure_space): Also check that the bidi cache size
5378 does not exceed that of the largest Lisp string or buffer. See Eli
5379 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5381 * alloc.c (__malloc_size_t): Remove.
5382 All uses replaced by size_t. See Andreas Schwab's note
5383 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5385 * image.c: Improve checking for integer overflow.
5386 (check_image_size): Assume that f is nonnull, since
5387 it is always nonnull in practice. This is one less thing to
5388 worry about when checking for integer overflow later.
5389 (x_check_image_size): New function, which checks for integer
5390 overflow issues inside X.
5391 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5392 This removes the need for a memory_full check.
5393 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5394 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5395 (xbm_read_bitmap_data): Change locals back to 'int', since
5396 their values must fit in 'int'.
5397 (xpm_load_image, png_load, tiff_load):
5398 Invoke x_create_x_image_and_pixmap earlier,
5399 to avoid much needless work if the image is too large.
5400 (tiff_load): Treat overly large images as if
5401 x_create_x_image_and_pixmap failed, not as malloc failures.
5402 (gs_load): Use x_check_image_size.
5404 * gtkutil.c: Omit integer casts.
5405 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5406 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5408 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5410 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5411 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5412 would wrongly return t on a 64-bit host.
5414 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5415 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5416 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5417 and therefore cause GCC to emit a bogus diagnostic in some cases.
5419 * image.c: Integer signedness and overflow and related fixes.
5420 This is not an exhaustive set of fixes, but it's time to
5421 record what I've got.
5422 (lookup_pixel_color, check_image_size): Remove redundant decls.
5423 (check_image_size): Don't assume that arbitrary EMACS_INT values
5424 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5425 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5426 (tiff_load, imagemagick_load_image):
5427 Check for overflow in size calculations.
5428 (x_create_x_image_and_pixmap): Remove unnecessary test for
5429 xmalloc returning NULL; that can't happen.
5430 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5431 (xpm_color_bucket): Use better integer hashing function.
5432 (xpm_cache_color): Don't possibly over-allocate memory.
5433 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5434 (gif_memory_source):
5435 Use ptrdiff_t, not int or size_t, to record sizes.
5436 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5437 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5438 either works, as we prefer signed integers.
5439 (tiff_read_from_memory, tiff_write_from_memory):
5440 Return tsize_t, not size_t, since that's what the TIFF API wants.
5441 (tiff_read_from_memory): Don't fail simply because the read would
5442 go past EOF; instead, return a short read.
5443 (tiff_load): Omit no-longer-needed casts.
5444 (Fimagemagick_types): Don't assume size fits into 'int'.
5446 Improve hashing quality when configured --with-wide-int.
5447 * fns.c (hash_string): New function, taken from sxhash_string.
5448 Do not discard information about ASCII character case; this
5449 discarding is no longer needed.
5450 (sxhash-string): Use it. Change sig to match it. Caller changed.
5451 * lisp.h: Declare it.
5452 * lread.c (hash_string): Remove, since we now use fns.c's version.
5453 The fns.c version returns a wider integer if --with-wide-int is
5454 specified, so this should help the quality of the hashing a bit.
5456 * emacs.c: Integer overflow minor fix.
5457 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5458 Define only if GNU_LINUX.
5459 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5461 * dispnew.c: Integer signedness and overflow fixes.
5462 Remove unnecessary forward decls, that were a maintenance hassle.
5463 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5465 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5466 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5467 (prepare_desired_row, line_draw_cost):
5468 Use int, not unsigned, where either works.
5469 (save_current_matrix, restore_current_matrix):
5470 Use ptrdiff_t, not size_t, where either works.
5471 (init_display): Check for overflow more accurately, and without
5472 relying on undefined behavior.
5474 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5475 Remove, replacing with the new symbols in lisp.h. All uses changed.
5476 * fileio.c (make_temp_name):
5477 * filelock.c (lock_file_1, lock_file):
5478 * xdisp.c (message_dolog):
5479 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5480 Use pMd etc. instead.
5481 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5482 replacing the pWIDE etc. symbols removed from editfns.c.
5484 * keyboard.h (num_input_events): Now uintmax_t.
5485 This is (very slightly) less likely to mess up due to wraparound.
5488 * buffer.c: Integer signedness fixes.
5489 (alloc_buffer_text, enlarge_buffer_text):
5490 Use ptrdiff_t rather than size_t when either will do, as we prefer
5493 * alloc.c: Integer signedness and overflow fixes.
5494 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5495 (__malloc_size_t): Default to size_t, not to int.
5496 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5497 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5498 Prefer ptrdiff_t to size_t when either would do, as we prefer
5500 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5501 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5502 Now const. Initialize with values that are in range even if char
5504 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5505 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5506 These functions do the right thing with sizes > 2**32.
5507 (check_depth): Now ptrdiff_t, not int.
5508 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5509 Adjust to new way of storing sizes. Check for size overflow bugs
5511 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5512 slightly wrong anyway, as it missed one instance of
5513 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5514 (refill_memory_reserve): Omit needless cast to size_t.
5515 (mark_object_loop_halt): Mark as externally visible.
5517 * xselect.c: Integer signedness and overflow fixes.
5518 (Fx_register_dnd_atom, x_handle_dnd_message):
5519 Use ptrdiff_t, not size_t, since we prefer signed.
5520 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5521 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5522 x_dnd_atoms_size and x_dnd_atoms_length.
5524 * doprnt.c: Prefer signed to unsigned when either works.
5526 * doprnt.c (doprnt):
5528 * xdisp.c (vmessage):
5529 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5530 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5531 prefer signed arithmetic to avoid comparison confusion.
5532 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5533 but is a bit tricky.
5535 Assume freestanding C89 headers, string.h, stdlib.h.
5536 * data.c, doprnt.c, floatfns.c, print.c:
5537 Include float.h unconditionally.
5538 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5539 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5540 * regex.c: Likewise for stddef.h, string.h.
5541 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5542 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5543 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5544 (STDC_HEADERS): Remove obsolete defines.
5545 * sysdep.c: Include limits.h unconditionally.
5547 Assume support for memcmp, memcpy, memmove, memset.
5548 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5549 * regex.c (memcmp, memcpy):
5550 Remove; we assume C89 now.
5552 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5553 (__malloc_safe_bcopy): Remove; no longer needed.
5555 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5556 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5557 well either way, and we prefer signed to unsigned.
5559 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5561 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5562 closes the connection while we're reading (bug#9182).
5564 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5566 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5567 are specified (Bug#9168).
5569 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5571 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5572 Found by GCC static checking and --with-wide-int on a 32-bit host.
5574 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5576 * xdisp.c (compute_display_string_pos): Fix logic of caching
5577 previous display string position. Initialize cached_prev_pos to
5578 -1. Fixes slow-down at the beginning of a buffer.
5580 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5582 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5583 for attrs[LFACE_FONTSET_INDEX].
5585 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5587 * xml.c (parse_region): Remove unused local
5588 that was recently introduced.
5590 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5592 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5593 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5595 * xdisp.c (move_it_in_display_line_to): Record the best matching
5596 position for TO_CHARPOS while scanning the line, and restore it on
5597 exit if none of the characters scanned was an exact match.
5598 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5599 when exact match is impossible due to invisible text, and the
5600 lines are truncated.
5602 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5604 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5607 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5609 Fix a significant slow-down of cursor motion with C-n, C-p,
5610 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5611 auto-repeat under bidi redisplay in fontified buffers.
5612 * xdisp.c (compute_stop_pos_backwards): New function.
5613 (next_element_from_buffer): Call compute_stop_pos_backwards to
5614 find a suitable prev_stop when we find ourselves before
5616 (reseat): Don't look for prev_stop, as that could mean a very long
5618 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5619 <cached_disp_overlay_modiff>: Cache for last found display string
5621 (compute_display_string_pos): Return the cached position if asked
5622 about the same buffer in the same area of character positions, and
5623 the buffer wasn't changed since the time the display string
5624 position was cached.
5626 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5628 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5629 is an integer, which is important for empty lines. (Bug#9149)
5631 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5633 * frame.c (Fmodify_frame_parameters): In tty case, update the
5634 default face if necessary (Bug#4238).
5636 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5638 * editfns.c (Fstring_to_char): No need to explain what a character
5639 is in the docstring (Bug#6576).
5641 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5643 * xml.c (parse_region): Make sure we always return a tree.
5645 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5647 * xml.c (parse_region): If a document contains only comments,
5650 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5652 * xml.c (make_dom): Return comments, too.
5654 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5657 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5658 and the surrounding thread.
5659 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5660 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5661 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5663 * s/openbsd.h (BROKEN_SIGIO): Define.
5664 * unexelf.c (unexec) [__OpenBSD__]:
5665 Don't update the .mdebug section of the Alpha COFF symbol table.
5667 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5669 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5672 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5674 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5675 This fixes some race conditions on the permissions of any newly
5678 * alloc.c (valid_pointer_p): Use pipe, not open.
5679 This fixes some permissions issues when debugging.
5681 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5682 If fchown fails to set both uid and gid, try to set just gid,
5683 as that is sometimes allowed. Adjust the file's mode to eliminate
5684 setuid or setgid bits that are inappropriate if fchown fails.
5686 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5688 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5689 to compare Lisp_Objects.
5690 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5691 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5692 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5694 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5696 * lread.c (read_integer): Unread even EOF character.
5697 (read1): Likewise. Properly record start position of symbol.
5699 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5700 symbol character follows.
5702 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5704 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5705 This works around a problem with the previous change to Fcopy_file.
5706 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5707 and without this change, GCC might complain about discarding
5708 fchown's return value.
5710 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5712 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5714 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5716 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5718 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5720 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5721 it's used from the C level.
5723 * process.c: Use the same condition for POLL_FOR_INPUT in both
5724 keyboard.c and process.c (bug#1858).
5726 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5728 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5729 (Fgnutls_boot): Use it.
5731 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5733 * doc.c (Fsubstitute_command_keys): Revert last change.
5735 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5737 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5738 quotes the next character, and doesn't affect other longer
5739 sequences (bug#8935).
5741 * lread.c (syms_of_lread): Clarify that is isn't only
5742 `eval-buffer' and `eval-defun' that's affected by
5743 `lexical-binding' (bug#8460).
5745 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5747 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5748 bidi redisplay when a line includes both an image and is truncated.
5750 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5752 Fix minor problems found by static checking.
5753 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5754 (elsz): Now a signed constant, not a size_t var. We prefer signed
5755 types to unsigned, to avoid integer comparison confusion. Without
5756 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5757 "cannot optimize loop, the loop counter may overflow", a symptom
5759 * indent.c (Fvertical_motion): Mark locals as initialized.
5760 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5762 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5764 * search.c (Fre_search_backward): Mention `case-fold-search' in
5765 all the re_search_* functions (bug#8138).
5767 * keyboard.c (Fopen_dribble_file): Document when the file is
5770 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5772 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5775 Support bidi reordering of display and overlay strings.
5776 * xdisp.c (compute_display_string_pos)
5777 (compute_display_string_end): Accept additional argument STRING.
5778 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5779 (reseat_to_string): Initialize bidi_it->string.s and
5780 bidi_it->string.schars.
5781 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5782 NULL (avoids a crash in bidi_paragraph_init).
5783 Initialize itb.string.lstring.
5784 (init_iterator): Call bidi_init_it only of a valid
5785 buffer position was specified. Initialize paragraph_embedding to
5787 (reseat_to_string): Initialize the bidi iterator.
5788 (display_string): If we need to ignore text properties of
5789 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5790 original value of -1 will not work with bidi.)
5791 (compute_display_string_pos): First arg is now struct
5792 `text_pos *'; all callers changed. Support display properties on
5794 (compute_display_string_end): Support display properties on Lisp
5796 (init_iterator, reseat_1, reseat_to_string): Initialize the
5797 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5798 when iterating on a string not from display properties).
5799 (compute_display_string_pos, compute_display_string_end):
5800 Fix calculation of the object to scan. Fixes an error when using
5802 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5803 base_level_stop; instead, set base_level_stop to BEGV.
5804 Fixes crashes in vertical-motion.
5805 (next_element_from_buffer): Improve commentary for when
5806 the iterator is before prev_stop.
5807 (init_iterator): Initialize bidi_p from the default value of
5808 bidi-display-reordering, not from buffer-local value. Use the
5809 buffer-local value only if initializing for buffer iteration.
5810 (handle_invisible_prop): Support invisible properties on strings
5811 that are being bidi-reordered.
5812 (set_iterator_to_next): Support bidi reordering of C strings and
5814 (next_element_from_string): Support bidi reordering of Lisp
5816 (handle_stop_backwards): Support Lisp strings as well.
5817 (display_string): Support display of R2L glyph rows.
5818 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5819 (init_iterator): Don't initialize it->bidi_p for strings
5821 (reseat_to_string): Initialize it->bidi_p for strings here.
5822 (next_element_from_string, next_element_from_c_string)
5823 (next_element_from_buffer): Add xassert's for correspondence
5824 between IT's object being iterated and it->bidi_it.string
5826 (face_before_or_after_it_pos): Support bidi iteration.
5827 (next_element_from_c_string): Handle the case of the first string
5828 character that is not the first one in the visual order.
5829 (get_visually_first_element): New function, refactored from common
5830 parts of next_element_from_buffer, next_element_from_string, and
5831 next_element_from_c_string.
5832 (tool_bar_lines_needed, redisplay_tool_bar)
5833 (display_menu_bar): Force left-to-right direction. Add a FIXME
5834 comment for making that be controlled by a user option.
5835 (push_it, pop_it): Save and restore the state of the
5836 bidi iterator. Save and restore the bidi_p flag.
5837 (pop_it): Iterate out of display property for string iteration as
5839 (iterate_out_of_display_property): Support iteration over strings.
5840 (handle_single_display_spec): Set up it->bidi_it for iteration
5841 over a display string, and call bidi_init_it.
5842 (handle_single_display_spec, next_overlay_string)
5843 (get_overlay_strings_1, push_display_prop): Set up the bidi
5844 iterator for displaying display or overlay strings.
5845 (forward_to_next_line_start): Don't use the shortcut if
5847 (back_to_previous_visible_line_start): If handle_display_prop
5848 pushed the iterator stack, restore the internal state of the bidi
5849 iterator by calling bidi_pop_it same number of times.
5850 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5851 and we are bidi-iterating, don't decrement the iterator position;
5852 instead, set the first_elt flag in the bidi iterator, to produce
5854 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5855 (push_display_prop): xassert that we are iterating a buffer.
5856 (push_it, pop_it): Save and restore paragraph_embedding member.
5857 (handle_single_display_spec, next_overlay_string)
5858 (get_overlay_strings_1, reseat_1, reseat_to_string)
5859 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5860 correctly. Don't assume unibyte strings are not bidi-reordered.
5861 (compute_display_string_pos)
5862 (compute_display_string_end): Fix handling the case of C string.
5863 (push_it, pop_it): Save and restore from_disp_prop_p.
5864 (handle_single_display_spec, push_display_prop): Set the
5865 from_disp_prop_p flag.
5866 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5867 (pop_it): Call iterate_out_of_display_property only if we are
5868 popping after iteration over a string that came from a display
5869 property. Fix a typo in popping stretch info. Add an assertion
5870 for verifying that the iterator position is in sync with the bidi
5872 (handle_single_display_spec, get_overlay_strings_1)
5873 (push_display_prop): Fix initialization of paragraph direction for
5874 string when that of the parent object is not yet determined.
5875 (reseat_1): Call bidi_init_it to resync the bidi
5876 iterator with IT's position. (Bug#7616)
5877 (find_row_edges): If ROW->start.pos gives position
5878 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5879 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5880 Reset the from_disp_prop_p flag.
5881 (SAVE_IT, RESTORE_IT): New macros.
5882 (pos_visible_p, face_before_or_after_it_pos)
5883 (back_to_previous_visible_line_start)
5884 (move_it_in_display_line_to, move_it_in_display_line)
5885 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5886 (try_scrolling, redisplay_window, display_line): Use them when
5887 saving a temporary copy of the iterator and restoring it back.
5888 (back_to_previous_visible_line_start, reseat_1)
5889 (init_iterator): Empty the bidi cache "stack".
5890 (move_it_in_display_line_to): If iterator ended up at
5891 EOL, but we never saw any buffer positions smaller than
5892 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5893 motion in bidi-reordered lines.
5894 (move_it_in_display_line_to): Record prev_method and prev_pos
5895 immediately before the call to set_iterator_to_next. Fixes cursor
5896 motion in bidi-reordered lines with stretch glyphs and strings
5897 displayed in margins. (Bug#8133) (Bug#8867)
5898 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5900 (pos_visible_p): Support positions in bidi-reordered lines.
5901 Save and restore bidi cache.
5903 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5904 (bidi_paragraph_info): Delete unused struct.
5905 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5906 (bidi_cache_start): New variable.
5907 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5909 (bidi_cache_fetch_state, bidi_cache_search)
5910 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5911 (bidi_cache_find, bidi_peek_at_next_level)
5912 (bidi_level_of_next_char, bidi_find_other_level_edge)
5913 (bidi_move_to_visually_next): Compare cache index with
5914 bidi_cache_start rather than with zero.
5915 (bidi_fetch_char): Accept new argument STRING; all callers
5916 changed. Support iteration over a string. Support strings with
5917 display properties. Support unibyte strings. Fix the type of
5918 `len' according to what STRING_CHAR_AND_LENGTH expects.
5919 (bidi_paragraph_init, bidi_resolve_explicit_1)
5920 (bidi_resolve_explicit, bidi_resolve_weak)
5921 (bidi_level_of_next_char, bidi_move_to_visually_next):
5922 Support iteration over a string.
5923 (bidi_set_sor_type, bidi_resolve_explicit_1)
5924 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5925 can now be zero (for strings); special values 0 and -1 were
5926 changed to -1 and -2, respectively.
5927 (bidi_char_at_pos): New function.
5928 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5929 Call it instead of FETCH_MULTIBYTE_CHAR.
5930 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5931 initialized to valid values.
5932 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5934 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5935 the test for valid cached positions. Fix the logic for looking up
5936 the sentinel state in the cache. GCPRO the Lisp string we are
5938 (bidi_push_it, bidi_pop_it): New functions.
5939 (bidi_initialize): Initialize the bidi cache start stack pointer.
5940 (bidi_cache_ensure_space): New function, refactored from part of
5941 bidi_cache_iterator_state. Don't assume the required size is just
5942 one BIDI_CACHE_CHUNK away.
5943 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5944 (bidi_count_bytes, bidi_char_at_pos): New functions.
5945 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5946 always valid if bidi_cache_idx is valid.
5947 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5948 is valid if it's going to be used.
5949 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5950 (bidi_cache_fetch_state, bidi_cache_search)
5951 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5952 (bidi_cache_iterator_state, bidi_cache_find)
5953 (bidi_find_other_level_edge, bidi_cache_start_stack):
5954 All variables related to cache indices are now EMACS_INT.
5956 * dispextern.h (struct bidi_string_data): New structure.
5957 (struct bidi_it): New member `string'. Make flag members be 1-bit
5958 fields, and put them last in the struct.
5959 (compute_display_string_pos, compute_display_string_end):
5961 (bidi_push_it, bidi_pop_it): Add prototypes.
5962 (struct iterator_stack_entry): New members bidi_p,
5963 paragraph_embedding, and from_disp_prop_p.
5964 (struct it): Member bidi_p is now a bit field 1 bit wide.
5965 (bidi_shelve_cache, bidi_unshelve_cache):
5968 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5969 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5970 and vector-like objects.
5972 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5973 cache around display iteration.
5975 * window.c (Fwindow_end, window_scroll_pixel_based)
5976 (displayed_window_lines, Frecenter): Save and restore the bidi
5977 cache around display iteration.
5979 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5981 * editfns.c (Fdelete_region): Clarify the use of the named
5982 parameters (bug#6788).
5984 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5986 * indent.c (Fvertical_motion): Set and restore w->pointm when
5987 saving and restoring the window's buffer (Bug#9006).
5989 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5991 * editfns.c (Fstring_to_char): Clarify just what is returned
5992 (bug#6576). Text by Eli Zaretskii.
5994 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5996 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5998 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6000 * buffer.c (mmap_find): Fix a typo.
6002 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6004 Fix execution of x selection hooks.
6005 * xselect.c (Qx_lost_selection_functions)
6006 (Qx_sent_selection_functions): New vars.
6007 (syms_of_xselect): DEFSYM them.
6008 (x_handle_selection_request): Pass Qx_sent_selection_functions
6009 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6010 (x_handle_selection_clear,x_clear_frame_selections):
6011 Pass Qx_lost_selection_functions rather than
6012 Vx_lost_selection_functions to Frun_hook_with_args.
6014 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6016 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6017 The old code sometimes used this field without initializing it.
6019 * alloc.c (gc_sweep): Don't read past end of array.
6020 In theory, the old code could also have corrupted Emacs internals,
6021 though it'd be very unlikely.
6023 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6025 * character.c (Fcharacterp): Don't advertise optional ignored
6026 argument. (Bug#4026)
6028 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6030 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6033 * window.c (Fset_window_start): Doc fix (bug#4199).
6034 (Fset_window_hscroll): Ditto.
6036 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6038 Fix minor new problems caught by GCC 4.6.1.
6039 * term.c (init_tty): Remove unused local.
6040 * xsettings.c (store_monospaced_changed): Define this function only
6041 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6044 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6046 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6048 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6050 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6051 are the mini-buffer and the echo area (bug#3320).
6053 * term.c (init_tty): Remove support for supdup, c10 and perq
6054 terminals, which are no longer supported (bug#1482).
6056 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6058 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6060 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6062 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6063 for non-popups (Bug#3642).
6065 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6067 * alloc.c (reset_malloc_hooks): Protoize.
6068 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6069 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6070 * cm.c (losecursor): Likewise.
6071 * data.c (fmod): Likewise.
6072 * dispnew.c (swap_glyphs_in_rows): Likewise.
6073 * emacs.c (memory_warning_signal): Likewise.
6074 * floatfns.c (float_error): Likewise.
6075 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6076 (otf_open, font_otf_capability, generate_otf_features)
6077 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6079 * image.c (pbm_read_file): Likewise.
6080 * indent.c (string_display_width): Likewise.
6081 * intervals.c (check_for_interval, search_for_interval)
6082 (inc_interval_count, count_intervals, root_interval)
6083 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6084 * lread.c (defalias): Likewise.
6085 * ralloc.c (r_alloc_check): Likewise.
6086 * regex.c (set_image_of_range_1, set_image_of_range)
6087 (regex_grow_registers): Likewise.
6088 * sysdep.c (strerror): Likewise.
6089 * termcap.c (valid_filename_p, tprint, main): Likewise.
6090 * tparam.c (main): Likewise.
6091 * unexhp9k800.c (run_time_remap, save_data_space)
6092 (update_file_ptrs, read_header, write_header, calculate_checksum)
6093 (copy_file, copy_rest, display_header): Likewise.
6094 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6096 * xdisp.c (check_it): Likewise.
6097 * xfaces.c (register_color, unregister_color, unregister_colors):
6099 * xfns.c (print_fontset_result): Likewise.
6100 * xrdb.c (member, fatal, main): Likewise.
6102 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6104 Fix minor problems found by static checking (Bug#9031).
6105 * chartab.c (char_table_set_range, map_sub_char_table):
6106 Remove unused locals.
6107 (uniprop_table): Now static.
6108 * composite.c (_work_char): Remove unused static var.
6110 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6112 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6114 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6116 * gtkutil.c (qttip_cb): Remove code without function.
6118 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6120 * w32.c (pthread_sigmask): New stub.
6122 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6124 Use pthread_sigmask, not sigprocmask (Bug#9010).
6125 sigprocmask is portable only for single-threaded applications, and
6126 Emacs can be multi-threaded when it uses GTK.
6127 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6129 * callproc.c (Fcall_process):
6130 * process.c (create_process):
6131 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6132 Use pthread_sigmask, not sigprocmask.
6134 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6136 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6137 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6140 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6142 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6143 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6144 (xg_hide_tooltip): Fix comment.
6146 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6147 in registerServicesMenuSendTypes.
6148 (validRequestorForSendType): Don't check ns_return_types.
6150 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6153 2011-07-08 Jason Rumney <jasonr@gnu.org>
6155 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6156 SH_SHOW for hidden windows (Bug#5482).
6158 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6159 frame struct members of non-existent frames (Bug#6284).
6161 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6163 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6164 variable firstTime not needed on OSX >= 10.6.
6165 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6166 >= 10.5. Use setKnobProportion, setDoubleValue.
6168 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6169 (MAC_OS_X_VERSION_10_5): Define if not defined.
6170 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6171 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6172 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6174 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6175 cString and lossyCString on OSX >= 10.4
6177 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6178 sizeToFit on OSX >= 10.2.
6180 * nsimage.m (allocInitFromFile): Don't use deprecated method
6181 bestRepresentationForDevice on OSX >= 10.6.
6183 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6186 * emacs.c: Declare unexec_init_emacs_zone.
6188 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6190 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6192 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6193 on svcsMenu (Bug#8842).
6195 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6197 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6199 * nsterm.m (QUTF8_STRING): Declare.
6200 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6201 (validRequestorForSendType): Return type is (id).
6202 Change indexOfObjectIdenticalTo to indexOfObject.
6203 Check if we have local selection before returning self (Bug#8842).
6204 (writeSelectionToPasteboard): Put local selection into paste board
6205 if we have a local selection (Bug#8842).
6206 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6208 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6209 (ns_get_local_selection): Declare.
6211 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6213 * keymap.c (describe_map_tree): Don't insert a double newline at
6214 the end of the buffer (bug#1169) and return whether we inserted
6217 * callint.c (Fcall_interactively): Change "reading args" to
6218 "providing args" to try to clarify what it does (bug#1010).
6220 2011-07-07 Kenichi Handa <handa@m17n.org>
6222 * composite.c (composition_compute_stop_pos): Ignore a static
6223 composition starting before CHARPOS (Bug#8915).
6225 * xdisp.c (handle_composition_prop): Likewise.
6227 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6229 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6232 2011-07-07 Kenichi Handa <handa@m17n.org>
6234 * character.h (unicode_category_t): New enum type.
6236 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6237 (Qchar_code_property_table): New variable.
6238 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6239 (UNIPROP_COMPRESSED_FORM_P): New macros.
6240 (char_table_ascii): Uncompress the compressed values.
6241 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6242 Uncompress the compressed values.
6243 (sub_char_table_ref_and_range): Likewise.
6244 (char_table_ref_and_range): Uncompress the compressed values.
6245 (sub_char_table_set): New arg is_uniprop. Callers changed.
6246 Uncompress the compressed values.
6247 (sub_char_table_set_range): Args changed. Callers changed.
6248 (char_table_set_range): Adjuted for the above change.
6249 (map_sub_char_table): Delete args default_val and parent. Add arg
6250 top. Give decoded values to a Lisp function.
6251 (map_char_table): Adjust for the above change. Give decoded
6252 values to a Lisp function. Gcpro more variables.
6253 (uniprop_table_uncompress)
6254 (uniprop_decode_value_run_length): New functions.
6255 (uniprop_decoder, uniprop_decoder_count): New variables.
6256 (uniprop_get_decoder, uniprop_encode_value_character)
6257 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6259 (uniprop_encoder, uniprop_encoder_count): New variables.
6260 (uniprop_get_encoder, uniprop_table)
6261 (Funicode_property_table_internal, Fget_unicode_property_internal)
6262 (Fput_unicode_property_internal): New functions.
6263 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6264 Sunicode_property_table_internal, Sget_unicode_property_internal,
6265 and Sput_unicode_property_internal. Defvar_lisp
6266 char-code-property-alist.
6268 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6269 Vunicode_category_table.
6271 * font.c (font_range): Adjust for the change of
6272 Vunicode_category_table.
6274 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6276 * m/iris4d.h: Remove file, move contents ...
6277 * s/irix6-5.h: ... here.
6279 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6281 Remove unportable assumption about struct layout (Bug#8884).
6282 * alloc.c (mark_buffer):
6283 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6284 (clone_per_buffer_values): Don't assume that
6285 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6286 This isn't true in general, and it's particularly not true
6287 if Emacs is configured with --with-wide-int.
6288 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6289 New macros, used in the buffer.c change.
6291 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6293 * xsettings.c: Use both GConf and GSettings if both are available.
6294 (store_config_changed_event): Add comment.
6295 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6296 (store_tool_bar_style_changed): New functions.
6297 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6298 (struct xsettings): Move font inside HAVE_XFT.
6299 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6300 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6301 Move inside HAVE_XFT.
6302 (something_changed_gsettingsCB): Rename from something_changedCB.
6303 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6305 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6306 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6307 (something_changed_gconfCB): Rename from something_changedCB.
6308 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6309 (parse_settings): Move check for font inside HAVE_XFT.
6310 (read_settings, apply_xft_settings): Add comment.
6311 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6312 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6313 call store_font_name_changed.
6314 (xft_settings_event): Add comment.
6315 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6316 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6317 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6318 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6319 (xsettings_initialize): Call init_gsettings last.
6320 (xsettings_get_system_font, xsettings_get_system_normal_font):
6323 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6325 Random fixes. E.g., (random) never returned negative values.
6326 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6327 subseconds part to the entropy, as that's a bit more random.
6328 Prefer signed to unsigned, since the signedness doesn't matter and
6329 in general we prefer signed. When given a limit, use a
6330 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6331 latter isn't right if USE_2_TAGS_FOR_INTS.
6332 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6333 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6335 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6337 * textprop.c (text_property_stickiness):
6338 Obey Vtext_property_default_nonsticky.
6339 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6340 * w32fns.c (syms_of_w32fns):
6341 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6343 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6345 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6346 This is more efficient than Ffile_directory_p and avoids a minor race.
6348 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6350 * buffer.c (Foverlay_put): Say what the return value is
6353 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6354 is a directory before asking whether to use the file name
6356 (barf_or_query_if_file_exists): Make the "File is a directory"
6357 error be more correct.
6359 * fns.c (Frequire): Remove the mention of the .gz files, since
6360 that's installation-specific, but keep the mention of
6361 `get-load-suffixes'.
6363 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6365 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6366 Report string overflow if the output is too long.
6368 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6370 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6371 (syms_of_gnutls): Remove duplicate DEFSYM for
6372 Qgnutls_bootprop_verify_hostname_error, an error for
6373 Qgnutls_bootprop_verify_error (which is no longer used).
6375 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6376 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6377 Also (re)move comments that are misplaced or no longer relevant.
6379 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6381 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6383 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6385 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6386 and background color parameters if they have been changed.
6388 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6390 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6392 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6394 * xsettings.c (SYSTEM_FONT): Define only when used.
6395 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6397 * keymap.c (access_keymap_1): Now static.
6399 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6401 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6402 leave any prefix arg for the up event (Bug#1586).
6404 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6406 * lread.c (syms_of_lread): Mention single symbols defined by
6407 `defvar' or `defconst' (bug#7154).
6409 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6410 (Frequire): Mention get-load-suffixes.
6412 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6414 * window.h (window): Remove clone_number slot.
6415 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6417 (make_parent_window, make_window, saved_window)
6418 (Fset_window_configuration, save_window_save): Don't deal with
6420 * buffer.c (Qclone_number): Remove declaration.
6421 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6423 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6425 Add multiple inheritance to keymaps.
6426 * keymap.c (Fmake_composed_keymap): New function.
6427 (Fset_keymap_parent): Simplify.
6428 (fix_submap_inheritance): Remove.
6429 (access_keymap_1): New function extracted from access_keymap to handle
6430 embedded parents and handle lists of maps.
6431 (access_keymap): Use it.
6432 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6433 (Fcopy_keymap): Handle embedded parents.
6434 (Fcommand_remapping, define_as_prefix): Simplify.
6435 (Fkey_binding): Simplify.
6436 (syms_of_keymap): Move minibuffer-local-completion-map,
6437 minibuffer-local-filename-completion-map,
6438 minibuffer-local-must-match-map, and
6439 minibuffer-local-filename-must-match-map to Elisp.
6440 (syms_of_keymap): Defsubr make-composed-keymap.
6441 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6442 (parse_menu_item): Trivial simplification.
6444 2011-07-01 Glenn Morris <rgm@gnu.org>
6446 * Makefile.in (SETTINGS_LIBS): Fix typo.
6448 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6450 * coding.c (Fencode_coding_string): Record the last coding system
6451 used, as the function doc string says (bug#8738).
6453 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6455 * xsettings.c (store_monospaced_changed): Take new font as arg and
6456 check for change against current_mono_font.
6457 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6458 (emacs_settings_constructor, emacs_settings_get_property)
6459 (emacs_settings_set_property, emacs_settings_class_init)
6460 (emacs_settings_init, gsettings_obj): Remove.
6461 (something_changedCB): New function for HAVE_GSETTINGS.
6462 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6463 with value as argument.
6464 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6465 g_settings_new (Bug#8967). Do not create gsettings_obj.
6466 Remove calls to g_settings_bind. Connect something_changedCB to
6469 * xgselect.c: Add defined (HAVE_GSETTINGS).
6470 (xgselect_initialize): Ditto.
6472 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6473 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6476 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6478 * eval.c (struct backtrace): Simplify and port the data structure.
6479 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6480 signed bit field, as this assumption is not portable and it makes
6481 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6482 "char debug_on_exit : 1" as this is not portable either; instead,
6483 use the portable "unsigned int debug_on_exit : 1". Remove unused
6484 member evalargs. Remove obsolete comments about cc bombing out.
6486 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6488 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6489 Let HAVE_GSETTINGS override HAVE_GCONF.
6490 (store_monospaced_changed): New function.
6491 (EMACS_SETTINGS): A new type derived from GObject to handle
6492 GSettings notifications.
6493 (emacs_settings_constructor, emacs_settings_get_property)
6494 (emacs_settings_set_property, emacs_settings_class_init):
6496 (gsettings_client, gsettings_obj): New variables.
6497 (GSETTINGS_SCHEMA): New define.
6498 (something_changedCB): Call store_monospaced_changed.
6499 (init_gsettings): New function.
6500 (xsettings_initialize): Call init_gsettings.
6501 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6504 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6507 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6509 * window.c (resize_root_window, grow_mini_window)
6510 (shrink_mini_window): Rename Qresize_root_window to
6511 Qwindow_resize_root_window and Qresize_root_window_vertically to
6512 Qwindow_resize_root_window_vertically.
6514 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6516 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6518 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6520 * makefile.w32-in: Redesign dependencies so they reflect more
6521 clearly which files are directly included by each source file,
6522 and not through other includes.
6524 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6526 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6527 (sort_overlays, overlay_strings): When an overlay's clone number
6528 matches the window's clone number process the overlay even if
6529 the overlay's window property doesn't match the current window.
6531 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6532 (Fwindow_hchild): Rename to Fwindow_left_child.
6533 (Fwindow_next): Rename to Fwindow_next_sibling.
6534 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6535 (resize_window_check): Rename to window_resize_check.
6536 (resize_window_apply): Rename to window_resize_apply.
6537 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6538 (Fdelete_other_windows_internal, resize_frame_windows)
6539 (Fsplit_window_internal, Fdelete_window_internal)
6540 (grow_mini_window, shrink_mini_window)
6541 (Fresize_mini_window_internal): Fix callers accordingly.
6543 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6545 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6546 (emacs_fixed_set_min_size): Remove.
6547 (emacs_fixed_new): Take frame as argument.
6549 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6550 (_EmacsFixedPrivate): Remove minwidth/height.
6551 Add struct frame *f.
6552 (emacs_fixed_init): Initialize priv->f.
6553 (get_parent_class, emacs_fixed_set_min_size): Remove.
6554 (emacs_fixed_new): Set priv->f to argument.
6555 (emacs_fixed_get_preferred_width)
6556 (emacs_fixed_get_preferred_height): Use min_width/height from
6557 frames size_hint to set minimum and natural (Bug#8919).
6558 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6559 and use min_width/height from frames size_hint to set
6560 min_width/height (Bug#8919).
6562 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6563 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6566 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6568 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6569 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6572 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6574 * process.c (wait_reading_process_output): Bypass select if
6575 waiting for a cell while ignoring keyboard input, and input is
6576 pending. Suggested by Jan Djärv (Bug#8869).
6578 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6580 Use gnulib's dup2 module instead of rolling our own.
6581 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6583 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6585 * dispnew.c (scrolling_window): Before scrolling, turn off a
6586 mouse-highlight in the window being scrolled.
6588 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6590 Move DEFSYM to lisp.h and use everywhere.
6592 * character.h (DEFSYM): Move declaration...
6593 * lisp.h (DEFSYM): ...here.
6599 * w32select.c: Don't include character.h.
6601 * alloc.c (syms_of_alloc):
6602 * buffer.c (syms_of_buffer):
6603 * bytecode.c (syms_of_bytecode):
6604 * callint.c (syms_of_callint):
6605 * casefiddle.c (syms_of_casefiddle):
6606 * casetab.c (init_casetab_once):
6607 * category.c (init_category_once, syms_of_category):
6608 * ccl.c (syms_of_ccl):
6609 * cmds.c (syms_of_cmds):
6610 * composite.c (syms_of_composite):
6611 * dbusbind.c (syms_of_dbusbind):
6612 * dired.c (syms_of_dired):
6613 * dispnew.c (syms_of_display):
6614 * doc.c (syms_of_doc):
6615 * editfns.c (syms_of_editfns):
6616 * emacs.c (syms_of_emacs):
6617 * eval.c (syms_of_eval):
6618 * fileio.c (syms_of_fileio):
6619 * fns.c (syms_of_fns):
6620 * frame.c (syms_of_frame):
6621 * fringe.c (syms_of_fringe):
6622 * insdel.c (syms_of_insdel):
6623 * keymap.c (syms_of_keymap):
6624 * lread.c (init_obarray, syms_of_lread):
6625 * macros.c (syms_of_macros):
6626 * msdos.c (syms_of_msdos):
6627 * print.c (syms_of_print):
6628 * process.c (syms_of_process):
6629 * search.c (syms_of_search):
6630 * sound.c (syms_of_sound):
6631 * syntax.c (init_syntax_once, syms_of_syntax):
6632 * terminal.c (syms_of_terminal):
6633 * textprop.c (syms_of_textprop):
6634 * undo.c (syms_of_undo):
6635 * w32.c (globals_of_w32):
6636 * window.c (syms_of_window):
6637 * xdisp.c (syms_of_xdisp):
6638 * xfaces.c (syms_of_xfaces):
6639 * xfns.c (syms_of_xfns):
6640 * xmenu.c (syms_of_xmenu):
6641 * xsettings.c (syms_of_xsettings):
6642 * xterm.c (syms_of_xterm): Use DEFSYM.
6644 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6646 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6648 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6650 Integer and buffer overflow fixes (Bug#8873).
6652 * print.c (printchar, strout): Check for string overflow.
6653 (PRINTPREPARE, printchar, strout):
6654 Don't set size unless allocation succeeds.
6656 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6657 for sizes. Check for string overflow more accurately.
6658 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6660 * macros.c: Integer and buffer overflow fixes.
6661 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6662 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6663 Use ptrdiff_t, not int, for sizes.
6664 Don't increment bufsize until after realloc succeeds.
6665 Check for size-calculation overflow.
6666 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6668 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6670 * lread.c: Integer overflow fixes.
6671 (read_integer): Radix is now EMACS_INT, not int,
6672 to improve quality of diagnostics for out-of-range radices.
6673 Calculate buffer size correctly for out-of-range radices.
6674 (read1): Check for integer overflow in radices, and in
6675 read-circle numbers.
6676 (read_escape): Avoid int overflow.
6677 (Fload, openp, read_buffer_size, read1)
6678 (substitute_object_recurse, read_vector, read_list, map_obarray):
6679 Use ptrdiff_t, not int, for sizes.
6680 (read1): Use EMACS_INT, not int, for sizes.
6681 Check for size overflow.
6683 * image.c (cache_image): Check for size arithmetic overflow.
6685 * lread.c: Integer overflow issues.
6686 (saved_doc_string_size, saved_doc_string_length)
6687 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6688 Now ptrdiff_t, not int.
6689 (read1): Don't assume doc string length fits in int. Check for
6690 out-of-range doc string lengths.
6691 (read_list): Don't assume file position fits in int.
6692 (read_escape): Check for hex character overflow.
6694 2011-06-22 Leo Liu <sdl.web@gmail.com>
6696 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6697 Move to minibuffer.el.
6699 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6701 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6702 The following patches are for when GLYPH_DEBUG && !XASSERT.
6703 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6704 * dispnew.c (flush_stdout):
6705 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6706 Mark as externally visible.
6707 * dispnew.c (check_window_matrix_pointers): Now static.
6708 * dispnew.c (window_to_frame_vpos):
6709 * xfns.c (unwind_create_frame):
6710 * xterm.c (x_check_font): Remove unused local.
6711 * scroll.c (CHECK_BOUNDS):
6712 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6713 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6714 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6715 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6716 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6718 (debug_method_add): Use va_list and vsprintf rather than relying
6719 on undefined behavior with wrong number of arguments.
6720 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6721 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6722 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6723 since we're not interested in debugging glyphs with old libraries.
6724 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6725 GCC 4.6.0's static checking.
6727 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6729 Integer overflow and signedness fixes (Bug#8873).
6730 A few related buffer overrun fixes, too.
6732 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6734 * dispextern.h (struct face.stipple):
6735 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6736 (x_bitmap_mask, x_allocate_bitmap_record)
6737 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6738 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6739 (x_create_bitmap_from_xpm_data):
6740 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6741 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6743 * xfaces.c (load_pixmap):
6744 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6745 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6746 (.bitmaps_last, struct x_output.icon_bitmap):
6747 Use ptrdiff_t, not int, for bitmap indexes.
6748 (x_allocate_bitmap_record): Check for size overflow.
6749 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6751 Use ptrdiff_t, not int, for overlay counts.
6752 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6753 * editfns.c (overlays_around, get_pos_property):
6754 * textprop.c (get_char_property_and_overlay):
6755 * xdisp.c (next_overlay_change, note_mouse_highlight):
6756 * xfaces.c (face_at_buffer_position):
6757 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6758 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6759 (Fnext_overlay_change, Fprevious_overlay_change)
6760 (mouse_face_overlay_overlaps, Foverlays_in):
6761 Use ptrdiff_t, not int, for sizes.
6762 (overlays_at, overlays_in): Check for size-calculation overflow.
6764 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6766 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6767 (x_session_initialize): Do not assume string length fits in int.
6769 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6770 This is unlikely, but can occur if DPI is outlandish.
6772 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6773 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6775 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6776 * xrdb.c (magic_file_p, search_magic_path):
6777 Omit last arg SUFFIX; it was always 0. All callers changed.
6778 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6780 * xfont.c (xfont_match): Avoid need for strlen.
6782 * xfns.c: Don't assume strlen fits in int.
6783 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6785 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6786 not unsigned long, as we prefer signed integers. All callers changed.
6787 Detect integer overflow in repeat count.
6788 (message_dolog): Don't assume print length fits in 39 bytes.
6789 (display_mode_element): Don't assume strlen fits in int.
6791 * termcap.c: Don't assume sizes fit in int and never overflow.
6792 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6793 (gobble_line): Check for size-calculation overflow.
6795 * minibuf.c (Fread_buffer):
6796 * lread.c (intern, intern_c_string):
6797 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6798 Don't assume string length fits in int.
6800 * keyboard.c (parse_tool_bar_item):
6801 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6803 * font.c: Don't assume string length fits in int.
6804 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6805 Use ptrdiff_t, not int.
6806 (font_intern_prop): Don't assume string length fits in int.
6807 Don't assume integer property fits in fixnum.
6808 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6810 * filelock.c: Fix some buffer overrun and integer overflow issues.
6811 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6812 Reformulate so as not to need the command string.
6813 Invoke gzip -cd rather than gunzip, as it's more portable.
6814 (lock_info_type, lock_file_1, lock_file):
6815 Don't assume pid_t and time_t fit in unsigned long.
6816 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6817 (current_lock_owner): Prefer signed type for sizes.
6818 Use memcpy, not strncpy, where memcpy is what is really wanted.
6819 Don't assume (via atoi) that time_t and pid_t fit in int.
6820 Check for time_t and/or pid_t out of range, e.g., via a network share.
6821 Don't alloca where an auto var works fine.
6823 * fileio.c: Fix some integer overflow issues.
6824 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6825 Don't assume string length fits in int.
6826 (directory_file_name): Don't assume string length fits in long.
6827 (make_temp_name): Don't assume pid fits in int, or that its print
6828 length is less than 20.
6830 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6832 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6834 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6836 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6837 We prefer signed integers, even for size calculations.
6839 * emacs.c: Don't assume string length fits in 'int'.
6840 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6841 (main): Don't invoke strlen when not needed.
6843 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6844 (XD_DEBUG_MESSAGE): Don't waste a byte.
6846 * callproc.c (getenv_internal_1, getenv_internal)
6848 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6850 * lread.c (invalid_syntax): Omit length argument.
6851 All uses changed. This doesn't fix a bug, but it simplifies the
6852 code away from its former Hollerith-constant appearance, and it's
6853 one less 'int' to worry about when looking at integer-overflow issues.
6854 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6856 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6857 This didn't break anything, but it didn't help either.
6858 It's confusing to put a bogus integer in a place where the actual
6859 value does not matter.
6860 (LIST_END_P): Remove unused macro and its bogus comment.
6861 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6863 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6864 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6866 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6867 We prefer signed types, and the value cannot exceed the EMACS_INT
6868 range anyway (because otherwise the length would not be representable).
6869 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6870 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6871 This avoids a GCC warning when WIDE_EMACS_INT.
6873 * indent.c (sane_tab_width): New function.
6874 (current_column, scan_for_column, Findent_to, position_indentation)
6875 (compute_motion): Use it. This is just for clarity.
6876 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6878 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6880 * lisp.h (lint_assume): New macro.
6881 * composite.c (composition_gstring_put_cache):
6882 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6884 * editfns.c, insdel.c:
6885 Omit unnecessary forward decls, to simplify future changes.
6887 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6889 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6891 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6892 Use much-faster test for byte-length change.
6893 Don't assume string byte-length fits in 'int'.
6894 Check that character arg fits in 'int'.
6895 (mapcar1): Declare byte as byte, for clarity.
6897 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6899 * fns.c (concat): Catch string overflow earlier.
6900 Do not rely on integer wraparound.
6902 * dispextern.h (struct it.overlay_strings_charpos)
6903 (struct it.selective): Now EMACS_INT, not int.
6904 * xdisp.c (forward_to_next_line_start)
6905 (back_to_previous_visible_line_start)
6906 (reseat_at_next_visible_line_start, next_element_from_buffer):
6907 Don't arbitrarily truncate the value of 'selective' to int.
6909 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6911 * composite.c: Don't truncate sizes to 'int'.
6912 (composition_gstring_p, composition_reseat_it)
6913 (composition_adjust_point): Use EMACS_INT, not int.
6914 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6915 not EMACS_UINT, for indexes.
6917 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6919 * buffer.c: Include <verify.h>.
6920 (struct sortvec.priority, struct sortstr.priority):
6921 Now EMACS_INT, not int.
6922 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6923 (struct sortstr.size, record_overlay_string)
6924 (struct sortstrlist.size, struct sortlist.used):
6925 Don't truncate size to int.
6926 (record_overlay_string): Check for size-calculation overflow.
6927 (init_buffer_once): Check at compile-time, not run-time.
6929 2011-06-22 Jim Meyering <meyering@redhat.com>
6931 Don't leak an XBM-image-sized buffer
6932 * image.c (xbm_load): Free the image buffer after using it.
6934 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6937 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6938 that Sun C diagnosed.
6939 * fns.c (secure_hash): Fix pointer signedness issue.
6940 * intervals.c (static_offset_intervals): New function.
6941 (offset_intervals): Use it.
6943 2011-06-21 Leo Liu <sdl.web@gmail.com>
6946 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6949 * fns.c (secure_hash): Rename from crypto_hash_function and change
6950 the first arg to accept symbols.
6951 (Fsecure_hash): New primitive.
6952 (syms_of_fns): New symbols.
6954 2011-06-20 Deniz Dogan <deniz@dogan.se>
6956 * process.c (Fset_process_buffer): Clarify return value in
6959 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6961 * dispnew.c (add_window_display_history): Use BVAR.
6963 * xdisp.c (debug_method_add): Use BVAR.
6964 (check_window_end, dump_glyph_matrix, dump_glyph)
6965 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6967 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6970 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6971 check till after the cache is created in init_frame_faces.
6973 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6975 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6977 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6979 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6980 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6981 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6983 Improve buffer-overflow checking (Bug#8873).
6984 * fileio.c (Finsert_file_contents):
6985 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6986 Remove the old (too-loose) buffer overflow checks.
6987 They weren't needed, since make_gap checks for buffer overflow.
6988 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6989 The old code merely checked for Emacs fixnum overflow, and relied
6990 on undefined (wraparound) behavior. The new code avoids undefined
6991 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6993 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6994 Tune. Don't use wider integers than needed. Don't use alloca.
6995 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6997 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6999 * insdel.c, lisp.h (buffer_overflow): New function.
7000 (insert_from_buffer_1, replace_range, replace_range_2):
7001 * insdel.c (make_gap_larger):
7002 * editfns.c (Finsert_char):
7003 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7005 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7007 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7009 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7011 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7012 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7014 * fileio.c: Don't assume EMACS_INT fits in off_t.
7015 (emacs_lseek): New static function.
7016 (Finsert_file_contents, Fwrite_region): Use it.
7017 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7019 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7021 * fns.c: Don't overflow int when computing a list length.
7022 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7023 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7024 truncation on 64-bit hosts. Check for QUIT every
7025 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7026 faster and is responsive enough.
7027 (Flength): Report an error instead of overflowing an integer.
7028 (Fsafe_length): Return a float if the value is not representable
7029 as a fixnum. This shouldn't happen except in contrived situations.
7030 (Fnthcdr, Fsort): Don't assume list length fits in int.
7031 (Fcopy_sequence): Don't assume vector length fits in int.
7033 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7034 (header_size, word_size): New constants.
7035 (allocate_vectorlike): Don't check size overflow here.
7036 (allocate_vector): Check it here instead, since this is the only
7037 caller of allocate_vectorlike that could cause overflow.
7038 Check that the new vector's length is representable as a fixnum.
7040 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7041 The previous code was bogus. For example, next_almost_prime (32)
7042 returned 39, which is undesirable as it is a multiple of 3; and
7043 next_almost_prime (24) returned 25, which is a multiple of 5 so
7044 why was the code bothering to check for multiples of 7?
7046 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7048 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7050 Variadic C functions now count arguments with ptrdiff_t.
7051 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7052 Back then I didn't know that the Emacs coding style prefers signed int.
7053 Also, in the meantime I found a few more instances where arguments
7054 were being counted with int, which may truncate counts on 64-bit
7055 machines, or EMACS_INT, which may be unnecessarily wide.
7056 * lisp.h (struct Lisp_Subr.function.aMANY)
7057 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7058 Arg counts are now ptrdiff_t, not size_t.
7059 All variadic functions and their callers changed accordingly.
7060 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7061 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7062 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7063 * callint.c (Fcall_interactively): Check arg count for overflow,
7064 to avoid potential buffer overrun. Use signed char, not 'int',
7065 for 'varies' array, so that we needn't bother to check its size
7066 calculation for overflow.
7067 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7068 * eval.c (apply_lambda):
7069 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7070 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7071 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7073 * callint.c (Fcall_interactively): Don't use index var as event count.
7075 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7076 * mem-limits.h (SIZE): Remove; no longer used.
7078 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7080 Remove unnecessary casts.
7081 * xterm.c (x_term_init):
7082 * xfns.c (x_set_border_pixel):
7083 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7084 These aren't needed now that we assume ANSI C.
7086 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7087 It's more likely to cause problems (due to unsigned overflow)
7090 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7092 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7094 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7096 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7098 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7100 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7102 GLYPH_CODE_FACE returns EMACS_INT, not int.
7103 * dispextern.h (merge_faces):
7104 * xfaces.c (merge_faces):
7105 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7106 Don't assume EMACS_INT fits in int.
7108 * character.h (CHAR_VALID_P): Remove unused parameter.
7109 * fontset.c, lisp.h, xdisp.c: All uses changed.
7111 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7113 * fns.c (concat): Minor tuning based on overflow analysis.
7114 This doesn't fix any bugs. Use int to hold character, instead
7115 of constantly refetching from Emacs object. Use XFASTINT, not
7116 XINT, for value known to be a character. Don't bother comparing
7117 a single byte to 0400, as it's always less.
7119 * floatfns.c (Fexpt):
7120 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7122 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7125 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7127 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7128 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7129 incorrectly succeed when S was a string, because 4294967386 was
7130 truncated before it was used.
7132 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7133 Otherwise, an out-of-range integer could cause undefined behavior
7136 * composite.c: Use int, not EMACS_INT, for characters.
7137 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7138 EMACS_INT, for values that are known to be in character range.
7139 This doesn't fix any bugs but is the usual style inside Emacs and
7140 may generate better code on 32-bit machines.
7142 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7143 This is for reasons similar to the recent CHAR_STRING fix.
7144 * charset.c (Fencode_char): Check that character arg is actually
7145 a character. Pass an int to ENCODE_CHAR.
7146 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7147 wider than 'int', as a compile-time check to prevent future regressions
7150 * character.c (char_string): Remove unnecessary casts.
7152 Make sure a 64-bit char is never passed to CHAR_STRING.
7153 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7154 by silently ignoring the top 32 bits, allowing some values
7155 that were far too large to be valid characters.
7156 * character.h: Include <verify.h>.
7157 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7158 arguments are no wider than unsigned, as a compile-time check
7159 to prevent future regressions in this area.
7161 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7162 (Fsubst_char_in_region):
7164 * xdisp.c (decode_mode_spec_coding):
7165 Adjust to CHAR_STRING's new requirement.
7166 * editfns.c (Finsert_char, Fsubst_char_in_region):
7167 * fns.c (concat): Check that character args are actually
7168 characters. Without this test, these functions did the wrong
7169 thing with wildly out-of-range values on 64-bit hosts.
7171 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7172 These casts should not be needed on 32-bit hosts, either.
7173 * keyboard.c (read_char):
7174 * lread.c (Fload): Remove casts to unsigned.
7176 * lisp.h (UNSIGNED_CMP): New macro.
7177 This fixes comparison bugs on 64-bit hosts.
7178 (ASCII_CHAR_P): Use it.
7179 * casefiddle.c (casify_object):
7180 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7181 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7182 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7183 * dispextern.h (FACE_FROM_ID):
7184 * keyboard.c (read_char): Use UNSIGNED_CMP.
7186 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7187 not to EMACS_INT, to avoid GCC warning.
7189 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7191 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7192 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7193 isn't needed on 32-bit machines.
7195 * buffer.c (Fgenerate_new_buffer_name):
7196 Use EMACS_INT for count, not int.
7197 (advance_to_char_boundary): Return EMACS_INT, not int.
7199 * data.c (Qcompiled_function): Now static.
7201 * window.c (window_body_lines): Now static.
7203 * image.c (gif_load): Rename local to avoid shadowing.
7205 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7206 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7207 * alloc.c (make_save_value): Integer argument is now of type
7209 (mark_object): Use ptrdiff_t, not int.
7210 * lisp.h (pD): New macro.
7211 * print.c (print_object): Use it.
7213 * alloc.c: Use EMACS_INT, not int, to count objects.
7214 (total_conses, total_markers, total_symbols, total_vector_size)
7215 (total_free_conses, total_free_markers, total_free_symbols)
7216 (total_free_floats, total_floats, total_free_intervals)
7217 (total_intervals, total_strings, total_free_strings):
7218 Now EMACS_INT, not int. All uses changed.
7219 (Fgarbage_collect): Compute overall total using a double, so that
7220 integer overflow is less likely to be a problem. Check for overflow
7221 when converting back to an integer.
7222 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7223 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7224 These were 'int' variables that could overflow on 64-bit hosts;
7225 they were never used, so remove them instead of repairing them.
7226 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7227 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7228 Previously, this ceilinged at INT_MAX, but that doesn't work on
7230 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7232 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7233 (allocate_vectorlike): Check for ptrdiff_t overflow.
7234 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7235 when a (possibly-narrower) signed value would do just as well.
7236 We prefer using signed arithmetic, to avoid comparison confusion.
7238 * alloc.c: Catch some string size overflows that we were missing.
7239 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7240 for convenience in STRING_BYTES_MAX.
7241 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7242 The definition here is exact; the one in lisp.h was approximate.
7243 (allocate_string_data): Check for string overflow. This catches
7244 some instances we weren't catching before. Also, it catches
7245 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7246 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7247 and ptrdiff_t and EMACS_INT are both 64 bits.
7249 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7250 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7251 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7253 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7255 * alloc.c (Fmake_string): Check for out-of-range init.
7257 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7259 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7261 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7263 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7264 xg_get_default_scrollbar_width.
7266 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7267 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7268 (style_changed_cb): Call update_theme_scrollbar_width and call
7269 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7270 all frames (Bug#8505).
7271 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7272 Call gtk_window_set_resizable if HAVE_GTK3.
7273 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7274 and height if HAVE_GTK3 (Bug#8505).
7275 (scroll_bar_width_for_theme): New variable.
7276 (update_theme_scrollbar_width): New function.
7277 (xg_get_default_scrollbar_width): Move code to
7278 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7279 (xg_initialize): Call update_theme_scrollbar_width.
7281 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7283 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7285 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7287 * frame.c (make_frame): Call other_buffer_safely instead of
7290 * window.c (temp_output_buffer_show): Call display_buffer with
7291 second argument Vtemp_buffer_show_specifiers and reset latter
7292 immediately after the call.
7293 (Vtemp_buffer_show_specifiers): New variable.
7294 (auto_window_vscroll_p, next_screen_context_lines)
7295 (Vscroll_preserve_screen_position): Remove leading asterisks from
7298 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7300 Fix minor problems found by GCC 4.6.0 static checking.
7301 * buffer.c (Qclone_number): Remove for now, as it's unused.
7302 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7303 (record_buffer): Remove unused local.
7304 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7305 (set_frame_buffer_list): Remove; unused.
7306 * frame.h (other_visible_frames): Remove decl.
7307 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7308 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7309 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7311 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7312 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7313 Define only if HAVE_GPM.
7314 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7315 (update_hints_inhibit): Remove; never set. All uses removed.
7316 * widgetprv.h (emacsFrameClassRec): Remove decl.
7317 * window.c (delete_deletable_window): Now returns void, since it
7318 wasn't returning anything.
7319 (compare_window_configurations): Remove unused locals.
7320 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7321 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7322 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7323 the same widths as pointers. This follows up on the 2011-05-06 patch.
7324 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7325 * xterm.h: Likewise.
7326 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7328 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7330 * makefile.w32-in: Update dependencies.
7331 (LISP_H): Add lib/intprops.h.
7333 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7335 * image.c (gif_load): Add animation frame delay to the metadata.
7336 (syms_of_image): Use DEFSYM. New symbol `delay'.
7338 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7340 * window.c (delete_deletable_window): Re-add.
7341 (Fset_window_configuration): Rewrite to handle dead buffers and
7342 consequently deletable windows.
7343 (window_tree, Fwindow_tree): Remove. Supply functionality in
7345 (compare_window_configurations): Simplify code.
7347 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7349 * image.c (imagemagick_load_image): Fix type mismatch.
7350 (Fimagemagick_types): Likewise.
7352 * window.h (replace_buffer_in_windows): Declare.
7354 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7356 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7357 Qclone_number. Remove external declaration of Qdelete_window.
7358 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7360 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7361 Run Qbuffer_list_update_hook if allowed.
7362 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7363 buffer list implementation.
7364 (other_buffer_safely): New function.
7365 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7366 calls to replace_buffer_in_windows and
7367 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7369 (record_buffer): Inhibit quitting and rewrite using quittable
7370 functions. Run Qbuffer_list_update_hook if allowed.
7371 (Frecord_buffer, Funrecord_buffer): New functions.
7372 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7373 Move switch-to-buffer to window.el.
7374 (bury-buffer): Move to window.el.
7375 (Vbuffer_list_update_hook): New variable.
7377 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7380 * window.h (resize_frame_windows): Move up in code.
7381 (Fwindow_frame): Remove EXFUN.
7382 (replace_buffer_in_all_windows): Remove prototype.
7383 (replace_buffer_in_windows_safely): Add prototype.
7385 * window.c: Declare Qdelete_window static again. Move down
7386 declaration of select_count.
7387 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7388 (Fother_window): Move to window.el.
7389 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7390 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7391 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7393 (replace_buffer_in_windows): Implement by calling
7394 Qreplace_buffer_in_windows.
7395 (replace_buffer_in_all_windows): Remove with some functionality
7396 moved into replace_buffer_in_windows_safely.
7397 (replace_buffer_in_windows_safely): New function.
7398 (select_window_norecord, select_frame_norecord): Move in front
7399 of run_window_configuration_change_hook. Remove now obsolete
7401 (Fset_window_buffer): Rewrite doc-string.
7402 Call Qrecord_window_buffer.
7403 (keys_of_window): Move binding for other-window to window.el.
7405 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7407 * dispextern.h (struct image): Replace data member, whose int_val
7408 and ptr_val fields were not used by anything, with a single
7411 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7412 (gif_clear_image, gif_load, imagemagick_load_image)
7413 (gs_clear_image, gs_load): Callers changed.
7415 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7417 * buffer.h: Include <time.h>, for time_t.
7418 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7420 Fix minor problems found by static checking.
7422 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7424 Make identifiers static if they are not used in other modules.
7425 * data.c (Qcompiled_function, Qframe, Qvector):
7426 * image.c (QimageMagick, Qsvg):
7427 * minibuf.c (Qmetadata):
7428 * window.c (resize_window_check, resize_root_window): Now static.
7429 * window.h (resize_window_check, resize_root_window): Remove decls.
7431 * window.c (window_deletion_count, delete_deletable_window):
7433 (window_body_lines): Now static.
7434 (Fdelete_other_windows_internal): Mark vars as initialized.
7435 Make sure 'resize_failed' is initialized.
7436 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7437 (resize_window_apply): Remove unused local.
7438 * window.h (delete_deletable_window): Remove decl.
7440 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7441 (imagemagick_load_image): Fix pointer signedness problem by changing
7442 last arg from unsigned char * to char *. All uses changed.
7443 Also, fix a local for similar reasons.
7444 Remove unused locals. Remove locals to avoid shadowing.
7445 (fn_rsvg_handle_free): Remove; unused.
7446 (svg_load, svg_load_image): Fix pointer signedness problem.
7447 (imagemagick_load_image): Don't use garbage pointer image_wand.
7449 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7451 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7453 * image.c (gif_load): Fix omitted cast error introduced by
7456 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7458 * window.h (resize_proportionally, orig_total_lines)
7459 (orig_top_line): Remove from window structure.
7460 (set_window_height, set_window_width, change_window_heights)
7461 (Fdelete_window): Remove prototypes.
7462 (resize_frame_windows): Remove duplicate declaration.
7464 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7466 * window.h (resize_frame_windows, resize_window_check)
7467 (delete_deletable_window, resize_root_window)
7468 (resize_frame_windows): Declare prototypes.
7470 * window.c (resize_window_apply): Make definition be "static" to
7471 match the prototype.
7473 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7475 * window.c: Remove declarations of Qwindow_size_fixed,
7476 window_min_size_1, window_min_size_2, window_min_size,
7477 size_window, window_fixed_size_p, enlarge_window, delete_window.
7478 Remove static from declaration of Qdelete_window, it's
7479 temporarily needed by Fbury_buffer.
7480 (replace_window): Don't assign orig_top_line and
7482 (Fdelete_window, delete_window): Remove. Window deletion is
7483 handled by window.el.
7484 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7485 Replace Fdelete_window calls with calls to Qdelete_window.
7486 (Fdelete_other_windows): Remove. Deleting other windows is
7487 handled by window.el.
7488 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7489 handled in window.el.
7490 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7491 Window minimum sizes are handled in window.el.
7492 (shrink_windows, size_window, set_window_height)
7493 (set_window_width, change_window_heights, window_height)
7494 (window_width, CURBEG, CURSIZE, enlarge_window)
7495 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7496 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7497 handled in window.el.
7498 (make_dummy_parent): Rename to make_parent_window and give it a
7499 second argument horflag.
7500 (make_window): Don't set resize_proportionally any more.
7501 (Fsplit_window): Remove. Windows are split in window.el.
7502 (save_restore_action, save_restore_orig_size)
7503 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7504 Resize mini windows in window.el.
7505 (grow_mini_window, shrink_mini_window): Implement by calling
7506 Qresize_root_window_vertically, resize_window_check and
7507 resize_window_apply.
7508 (saved_window, Fset_window_configuration, save_window_save):
7509 Do not handle orig_top_line, orig_total_lines, and
7510 resize_proportionally.
7511 (window_min_height, window_min_width): Move to window.el.
7512 (keys_of_window): Move bindings for delete-other-windows,
7513 split-window, delete-window and enlarge-window to window.el.
7515 * buffer.c: Temporarily extern Qdelete_window.
7516 (Fbury_buffer): Temporarily call Qdelete_window instead of
7517 Fdelete_window (Fbury_buffer will move to window.el soon).
7519 * frame.c (set_menu_bar_lines_1): Remove code handling
7520 orig_top_line and orig_total_lines.
7522 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7523 set_window_height but set heights directly.
7524 (change_frame_size_1): Use resize_frame_windows.
7526 * xdisp.c (init_xdisp): Don't use set_window_height but set
7529 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7530 Use resize_frame_windows instead of change_window_heights and run
7531 run_window_configuration_change_hook.
7533 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7534 instead of change_window_heights and run
7535 run_window_configuration_change_hook.
7537 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7539 * window.c (replace_window): Rename second argument REPLACEMENT to
7540 NEW. New third argument SETFLAG. Rewrite.
7541 (delete_window, make_dummy_parent): Call replace_window with
7543 (window_list_1): Move down in code.
7544 (run_window_configuration_change_hook): Move set_buffer part
7545 before select_frame_norecord part in order to unwind correctly.
7546 Rename count1 to count.
7547 (recombine_windows, delete_deletable_window, resize_root_window)
7548 (Fdelete_other_windows_internal)
7549 (Frun_window_configuration_change_hook, make_parent_window)
7550 (resize_window_check, resize_window_apply, Fresize_window_apply)
7551 (resize_frame_windows, Fsplit_window_internal)
7552 (Fdelete_window_internal, Fresize_mini_window_internal):
7554 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7556 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7558 * window.h (window): Add some new members to window structure -
7559 normal_lines, normal_cols, new_total, new_normal, clone_number,
7560 splits, nest, prev_buffers, next_buffers.
7561 (WINDOW_TOTAL_SIZE): Move here from window.c.
7562 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7564 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7566 (make_dummy_parent): Set new members of windows structure.
7567 (make_window): Move down in code. Handle new members of window
7569 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7570 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7571 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7572 (Fset_window_prev_buffers, Fwindow_next_buffers)
7573 (Fset_window_next_buffers, Fset_window_clone_number):
7575 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7576 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7578 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7579 Argument WINDOW can be now internal window too.
7580 (Fwindow_use_time): Move up in code.
7581 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7583 (Fset_window_configuration, saved_window)
7584 (Fcurrent_window_configuration, save_window_save): Handle new
7585 members of window structure.
7586 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7587 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7588 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7589 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7590 Qget_mru_window, Qresize_root_window,
7591 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7592 Qauto_buffer_name; staticpro them.
7594 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7596 * window.c (Fwindow_total_size, Fwindow_left_column)
7597 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7598 (Fwindow_list_1): New functions.
7599 (window_box_text_cols): Replace with window_body_cols.
7600 (Fwindow_width, Fscroll_left, Fscroll_right):
7601 Use window_body_cols instead of window_box_text_cols.
7602 (delete_window, Fset_window_configuration):
7603 Call delete_all_subwindows with window as argument.
7604 (delete_all_subwindows): Take a window as argument and not a
7606 (window_loop): Remove handling of GET_LRU_WINDOW and
7608 (Fget_lru_window, Fget_largest_window): Move to window.el.
7610 * window.h: Extern window_body_cols instead of
7611 window_box_text_cols. delete_all_subwindows now takes a
7612 Lisp_Object as argument.
7614 * indent.c (compute_motion, Fcompute_motion):
7615 Use window_body_cols instead of window_box_text_cols.
7617 * frame.c (delete_frame): Call delete_all_subwindows with root
7620 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7622 * fns.c (Fputhash): Document return value.
7624 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7626 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7628 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7630 Cons<->int and similar integer overflow fixes (Bug#8794).
7632 Check for overflow when converting integer to cons and back.
7633 * charset.c (Fdefine_charset_internal, Fdecode_char):
7634 Use cons_to_unsigned to catch overflow.
7635 (Fencode_char): Use INTEGER_TO_CONS.
7636 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7637 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7638 * data.c (long_to_cons, cons_to_long): Remove.
7639 (cons_to_unsigned, cons_to_signed): New functions.
7640 These signal an error for invalid or out-of-range values.
7641 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7642 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7643 * font.c (Ffont_variation_glyphs):
7644 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7645 * lisp.h: Include <intprops.h>.
7646 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7647 (cons_to_signed, cons_to_unsigned): New decls.
7648 (long_to_cons, cons_to_long): Remove decls.
7649 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7650 (Fprimitive_undo): Use CONS_TO_INTEGER.
7651 * xfns.c (Fx_window_property): Likewise.
7652 * xselect.c: Include <limits.h>.
7653 (x_own_selection, selection_data_to_lisp_data):
7654 Use INTEGER_TO_CONS.
7655 (x_handle_selection_request, x_handle_selection_clear)
7656 (x_get_foreign_selection, Fx_disown_selection_internal)
7657 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7658 (lisp_data_to_selection_data): Use cons_to_unsigned.
7659 (x_fill_property_data): Use cons_to_signed.
7660 Report values out of range.
7662 Check for buffer and string overflow more precisely.
7663 * buffer.h (BUF_BYTES_MAX): New macro.
7664 * lisp.h (STRING_BYTES_MAX): New macro.
7665 * alloc.c (Fmake_string):
7666 * character.c (string_escape_byte8):
7667 * coding.c (coding_alloc_by_realloc):
7668 * doprnt.c (doprnt):
7669 * editfns.c (Fformat):
7671 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7672 since they may not be the same number.
7673 * editfns.c (Finsert_char):
7674 * fileio.c (Finsert_file_contents):
7675 Likewise for BUF_BYTES_MAX.
7677 * image.c: Use ptrdiff_t, not int, for sizes.
7678 (slurp_file): Switch from int to ptrdiff_t.
7680 (slurp_file): Check that file size fits in both size_t (for
7681 malloc) and ptrdiff_t (for sanity and safety).
7683 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7684 if b->modtime has its maximal value.
7686 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7688 Don't assume time_t can fit into int.
7689 * buffer.h (struct buffer.modtime): Now time_t, not int.
7690 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7691 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7693 Minor fixes for signed vs unsigned integers.
7694 * character.h (MAYBE_UNIFY_CHAR):
7695 * charset.c (maybe_unify_char):
7696 * keyboard.c (read_char, reorder_modifiers):
7697 XINT -> XFASTINT, since the integer must be nonnegative.
7698 * ftfont.c (ftfont_spec_pattern):
7699 * keymap.c (access_keymap, silly_event_symbol_error):
7700 XUINT -> XFASTINT, since the integer must be nonnegative.
7701 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7702 since it makes no difference and we prefer signed.
7703 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7704 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7707 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7709 * window.h (Fwindow_frame): Declare.
7711 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7713 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7714 (SPARE_MEMORY): Always define.
7715 (LARGE_REQUEST): Remove.
7716 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7718 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7720 * lisp.h: Move EXFUNS for Fframe_root_window,
7721 Fframe_first_window and Fset_frame_selected_window to window.h.
7723 * window.h: Move EXFUNS for Fframe_root_window,
7724 Fframe_first_window and Fset_frame_selected_window here from
7727 * frame.c (Fwindow_frame, Fframe_first_window)
7728 (Fframe_root_window, Fframe_selected_window)
7729 (Fset_frame_selected_window): Move to window.c.
7730 (Factive_minibuffer_window): Move to minibuf.c.
7731 (Fother_visible_frames_p): New function.
7733 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7735 * window.c (decode_window, decode_any_window): Move up in code.
7736 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7737 (inhibit_frame_unsplittable): Remove unused variable.
7738 (Fwindow_buffer): Move up and rewrite doc-string.
7739 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7740 (Fwindow_prev): New functions.
7741 (Fwindow_frame): Move here from frame.c. Accept any window as
7743 (Fframe_root_window, Fframe_first_window)
7744 (Fframe_selected_window): Move here from frame.c. Accept frame
7745 or arbitrary window as argument. Update doc-strings.
7746 (Fminibuffer_window): Move up in code.
7747 (Fwindow_minibuffer_p): Move up in code and simplify.
7748 (Fset_frame_selected_window): Move here from frame.c.
7750 (Fselected_window, select_window, Fselect_window): Move up in
7751 code. Minor doc-string fixes.
7753 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7755 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7756 Do not assume that spare memory exists; that assumption is valid
7757 only if SYSTEM_MALLOC.
7758 (LARGE_REQUEST): New macro, so that the issue of large requests
7759 is separated from the issue of spare memory.
7761 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7763 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7766 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7768 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7771 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7773 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7775 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7777 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7778 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7780 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7782 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7784 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7786 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7787 (x_clipboard_manager_save): Add return value.
7788 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7790 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7791 Obey Vx_select_enable_clipboard_manager. Catch errors in
7792 x_clipboard_manager_save (Bug#8779).
7793 (Vx_select_enable_clipboard_manager): New variable.
7794 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7796 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7798 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7800 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7802 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7803 in the current matrix if keep_current_p is non-zero.
7805 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7807 * bidi.c (bidi_level_of_next_char): Fix last change.
7809 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7811 Support bidi reordering of text covered by display properties.
7813 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7814 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7815 (bidi_cache_search, bidi_cache_iterator_state)
7816 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7817 (bidi_level_of_next_char, bidi_move_to_visually_next):
7818 Support character positions inside a run of characters covered by a
7820 (bidi_paragraph_init, bidi_resolve_explicit_1)
7821 (bidi_level_of_next_char): Call bidi_fetch_char and
7822 bidi_fetch_char_advance instead of FETCH_CHAR and
7824 (bidi_init_it): Initialize new members.
7825 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7827 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7828 instead of using explicit *_CHAR codes.
7829 (bidi_resolve_explicit, bidi_resolve_weak):
7830 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7831 bidirectional text is supported only in multibyte buffers.
7832 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7833 it to initialize the frame_window_p member of struct bidi_it.
7834 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7835 (bidi_resolve_explicit, bidi_resolve_weak)
7836 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7837 bidi_it->nchars is non-positive.
7838 (bidi_level_of_next_char): Don't try to lookup the cache for the
7839 next/previous character if nothing is cached there yet, or if we
7840 were just reseat()'ed to a new position.
7842 * xdisp.c (set_cursor_from_row): Set start and stop points
7843 according to the row's direction when priming the loop that looks
7844 for the glyph on which to display cursor.
7845 (single_display_spec_intangible_p): Function deleted.
7846 (display_prop_intangible_p): Reimplement to call
7847 handle_display_spec instead of single_display_spec_intangible_p.
7848 Accept 3 additional arguments needed by handle_display_spec.
7849 This fixes incorrect cursor motion across display property with complex
7850 values: lists, `(when COND...)' forms, etc.
7851 (single_display_spec_string_p): Support property values that are
7852 lists with the argument STRING its top-level element.
7853 (display_prop_string_p): Fix the condition for processing a
7854 property that is a list to be consistent with handle_display_spec.
7855 (handle_display_spec): New function, refactored from the
7856 last portion of handle_display_prop.
7857 (compute_display_string_pos): Accept additional argument
7858 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7859 value of a `display' property is a "replacing spec".
7860 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7861 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7862 the display property, but just return a value indicating whether
7863 the display property will replace the characters it covers.
7864 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7865 frame_window_p members of struct bidi_it.
7866 (compute_display_string_pos, compute_display_string_end):
7868 (push_it): Accept second argument POSITION, where pop_it should
7869 jump to continue iteration.
7870 (reseat_1): Initialize bidi_it.disp_pos.
7872 * keyboard.c (adjust_point_for_property): Adjust the call to
7873 display_prop_intangible_p to its new signature.
7875 * dispextern.h (struct bidi_it): New member frame_window_p.
7876 (bidi_init_it): Update prototypes.
7877 (display_prop_intangible_p): Update prototype.
7878 (compute_display_string_pos, compute_display_string_end):
7880 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7883 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7885 Malloc failure behavior now depends on size of allocation.
7886 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7887 * lisp.h: Change signatures accordingly.
7888 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7889 All callers changed. (Bug#8762)
7891 * gnutls.c: Use Emacs's memory allocators.
7892 Without this change, the gnutls library would invoke malloc etc.
7893 directly, which causes problems on non-SYNC_INPUT hosts, and which
7894 runs afoul of improving memory_full behavior. (Bug#8761)
7895 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7896 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7897 xfree instead of the default malloc, realloc, free.
7898 (Fgnutls_boot): No need to check for memory allocation failure,
7899 since xmalloc does that for us.
7901 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7902 * category.c (hash_get_category_set):
7903 * ccl.c (ccl_driver):
7904 * charset.c (Fdefine_charset_internal):
7905 * charset.h (struct charset.hash_index):
7906 * composite.c (get_composition_id, gstring_lookup_cache)
7907 (composition_gstring_put_cache):
7908 * composite.h (struct composition.hash_index):
7909 * dispextern.h (struct image.hash):
7910 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7911 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7912 (hashfn_equal, hashfn_user_defined, make_hash_table)
7913 (maybe_resize_hash_table, hash_lookup, hash_put)
7914 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7915 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7916 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7917 * image.c (make_image, search_image_cache, lookup_image)
7918 (xpm_put_color_table_h):
7919 * lisp.h (struct Lisp_Hash_Table):
7920 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7921 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7922 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7923 * alloc.c (allocate_vectorlike):
7924 Check for overflow in vector size calculations.
7925 * ccl.c (ccl_driver):
7926 Check for overflow when converting EMACS_INT to int.
7927 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7928 need to be updated by these changes.
7929 * fns.c (make_hash_table, maybe_resize_hash_table):
7930 Check for integer overflow with large hash tables.
7931 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7932 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7933 (SXHASH_REDUCE): New macro.
7934 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7935 Use it instead of discarding useful hash info with large hash values.
7936 (sxhash_float): New function.
7937 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7938 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7939 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7940 Rewrite to use FIXNUM_BITS, as this simplifies things.
7941 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7942 Adjust signatures to match updated version of code.
7943 (consing_since_gc): Now EMACS_INT, since a single hash table can
7944 use more than INT_MAX bytes.
7946 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7948 Make it possible to build with GCC-4.6+ -O2 -flto.
7950 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7952 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7954 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7955 Call minibuffer-inactive-mode.
7957 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7959 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7960 Update dependencies.
7962 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7964 * data.c (init_data): Remove code for UTS, this system is not
7967 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7969 Don't force ./temacs to start in terminal mode.
7971 * frame.c (make_initial_frame): Initialize faces in all cases, not
7972 only when CANNOT_DUMP is defined.
7973 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7975 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7977 * dispnew.c (add_window_display_history): Use const for the string
7978 pointer. Remove declaration, not needed.
7980 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7982 Use 'inline', not 'INLINE'.
7983 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7984 * alloc.c, fontset.c (INLINE): Remove.
7985 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7986 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7987 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7988 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7989 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7991 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7993 Make it possible to run ./temacs.
7995 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7996 syms_of_callproc does the same thing. Remove test for
7997 "initialized", do it in the caller.
7998 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8000 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8002 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8003 (read_minibuf): Use get_minibuffer.
8004 (syms_of_minibuf): Use DEFSYM.
8005 (Qmetadata): New var.
8006 * data.c (Qbuffer): Don't make it static.
8007 (syms_of_data): Use DEFSYM.
8009 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8011 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8012 (CCL_CODE_MIN): New macro.
8014 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8016 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8018 * eval.c (Qdebug): Now static.
8019 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8020 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8021 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8023 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8025 * image.c: Various fixes to ImageMagick code comments.
8026 (Fimagemagick_types): Doc fix.
8028 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8030 Minor fixes prompted by GCC 4.6.0 warnings.
8032 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8034 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8035 (x_clipboard_manager_save_all): Move extern decl to ...
8036 * xterm.h: ... here, so that it can be checked for consistency.
8038 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8040 * xselect.c (x_clipboard_manager_save_frame)
8041 (x_clipboard_manager_save_all): New functions.
8042 (Fx_clipboard_manager_save): Lisp function deleted.
8044 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8045 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8047 * xterm.h: Update prototype.
8049 2011-05-28 William Xu <william.xwl@gmail.com>
8051 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8054 2011-05-28 Jim Meyering <meyering@redhat.com>
8056 Avoid a sign-extension bug in crypto_hash_function.
8057 * fns.c (to_uchar): Define.
8058 (crypto_hash_function): Use it to convert some newly-signed
8059 variables to unsigned, to avoid sign-extension bugs. For example,
8060 without this change, (md5 "truc") would evaluate to
8061 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8062 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8063 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8065 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8067 Integer overflow fixes.
8069 * dbusbind.c: Serial number integer overflow fixes.
8070 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8071 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8072 to hold a serial number that is too large for a fixnum.
8073 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8074 Check for serial numbers out of range. Decode any serial number
8075 that was so large that it became a float. (Bug#8722)
8077 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8078 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8079 Use XFASTINT rather than XUINT when numbers are nonnegative.
8080 (xd_append_arg, Fdbus_method_return_internal):
8081 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8082 arguments, check that Lisp number is nonnegative, rather than
8083 silently wrapping negative numbers around. (Bug#8722)
8084 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8087 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8089 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8091 ccl: Add integer overflow checks.
8092 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8093 (IN_INT_RANGE): New macros.
8094 (ccl_driver): Use them to check for integer overflow when
8095 decoding a CCL program. Many of the new checks are whether XINT (x)
8096 fits in int; it doesn't always, on 64-bit hosts. The new version
8097 doesn't catch all possible integer overflows, but it's an
8098 improvement. (Bug#8719)
8100 * alloc.c (make_event_array): Use XINT, not XUINT.
8101 There's no need for unsigned here.
8103 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8104 This follows up to the 2011-05-06 change that substituted uintptr_t
8105 for EMACS_INT. This case wasn't caught back then.
8107 Rework Fformat to avoid integer overflow issues.
8108 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8109 now (part of C89). Include <verify.h>.
8110 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8111 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8112 (Fformat): Avoid the prepass trying to compute sizes; it was only
8113 approximate and thus did not catch overflow reliably. Instead, walk
8114 through the format just once, formatting and computing sizes as we go,
8115 checking for integer overflow at every step, and allocating a larger
8116 buffer as needed. Keep track separately whether the format is
8117 multibyte. Keep only the most-recently calculated precision, rather
8118 than them all. Record whether each argument has been converted to
8119 string. Use EMACS_INT, not int, for byte and char and arg counts.
8120 Support field widths and precisions larger than INT_MAX. Avoid
8121 sprintf's undefined behavior with conversion specifications such as %#d
8122 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8123 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8124 formatting out-of-range floating point numbers with int
8127 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8129 * data.c: Avoid integer truncation in expressions involving floats.
8130 * data.c: Include <intprops.h>.
8131 (arith_driver): When there's an integer overflow in an expression
8132 involving floating point, convert the integers to floating point
8133 so that the resulting value does not suffer from catastrophic
8134 integer truncation. For example, on a 64-bit host (* 4
8135 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8136 Do not rely on undefined behavior after integer overflow.
8138 merge count_size_as_multibyte, parse_str_to_multibyte
8139 * character.c, character.h (count_size_as_multibyte):
8140 Rename from parse_str_to_multibyte; all uses changed.
8141 Check for integer overflow.
8142 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8143 since it's now a duplicate of the other. This is more of
8144 a character than a buffer op, so better that it's in character.c.
8145 * fns.c, print.c: Adjust to above changes.
8147 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8149 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8151 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8153 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8154 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8155 (x_clipboard_manager_save): Now static.
8156 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8158 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8159 (crypto_hash_function): Now static.
8160 Fix pointer signedness problems. Avoid unnecessary initializations.
8162 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8164 * termhooks.h (Vselection_alist): Make it terminal-local.
8166 * terminal.c (create_terminal): Initialize it.
8168 * xselect.c: Support for clipboard managers.
8169 (Vselection_alist): Move to termhooks.h as terminal-local var.
8170 (LOCAL_SELECTION): New macro.
8171 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8172 (symbol_to_x_atom): Remove gratuitous arg.
8173 (x_handle_selection_request, lisp_data_to_selection_data)
8174 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8175 (x_own_selection, x_get_local_selection, x_convert_selection):
8176 New arg, specifying work frame. Use terminal-local Vselection_alist.
8177 (some_frame_on_display): Delete unused function.
8178 (Fx_own_selection_internal, Fx_get_selection_internal)
8179 (Fx_disown_selection_internal, Fx_selection_owner_p)
8180 (Fx_selection_exists_p): New optional frame arg.
8181 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8182 (x_handle_selection_clear): Don't treat other terminals with the
8183 same keyboard specially. Use the terminal-local Vselection_alist.
8184 (x_clear_frame_selections): Use Frun_hook_with_args.
8186 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8188 * xterm.h: Add support for those atoms.
8190 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8192 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8193 (converted_selections, conversion_fail_tag): New global variables.
8194 (x_selection_request_lisp_error): Free the above.
8195 (x_get_local_selection): Remove unnecessary code.
8196 (x_reply_selection_request): Args changed; handle arbitrary array
8197 of converted selections stored in converted_selections.
8198 Separate the XChangeProperty and SelectionNotify steps.
8199 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8200 (x_convert_selection): New function.
8201 (x_handle_selection_event): Simplify.
8202 (x_get_foreign_selection): Don't ignore incoming requests while
8203 waiting for an answer; this will fail when we implement
8204 SAVE_TARGETS, and seems unnecessary anyway.
8205 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8206 (Vx_sent_selection_functions): Doc fix.
8208 2011-05-26 Leo Liu <sdl.web@gmail.com>
8210 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8212 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8214 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8216 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8217 for fringe update if it has periodic bitmap.
8218 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8219 and fringe_bitmap_periodic_p.
8221 * fringe.c (get_fringe_bitmap_data): New function.
8222 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8223 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8224 row. Mark glyph row for fringe update if periodicity changed.
8226 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8227 for fringe update unless it has periodic bitmap.
8229 2011-05-25 Kenichi Handa <handa@m17n.org>
8231 * xdisp.c (get_next_display_element): Set correct it->face_id for
8232 a static composition.
8234 2011-05-24 Leo Liu <sdl.web@gmail.com>
8237 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8239 * fns.c (crypto_hash_function, Fsha1): New function.
8240 (Fmd5): Use crypto_hash_function.
8241 (syms_of_fns): Add Ssha1.
8243 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8245 * gnutls.c: Remove unused macros.
8246 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8247 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8248 Remove macros that are defined and never used.
8249 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8251 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8253 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8254 (Fx_get_selection_internal): Minor cleanup.
8255 (Fx_own_selection_internal): Rename arguments for consistency with
8258 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8260 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8262 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8264 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8266 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8268 * dispnew.c (scrolling_window): Don't exclude the case that the
8269 last enabled row in the desired matrix touches the bottom boundary.
8271 2011-05-21 Glenn Morris <rgm@gnu.org>
8273 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8274 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8275 and add some more files.
8277 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8279 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8280 report_file_error introduced by the change from 2011-05-07.
8282 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8284 * systime.h (Time): Define only if emacs is defined.
8285 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8286 where the include path doesn't have X11/X.h by default. See
8287 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8289 2011-05-20 Kenichi Handa <handa@m17n.org>
8291 * composite.c (find_automatic_composition): Fix previous change.
8293 2011-05-20 Glenn Morris <rgm@gnu.org>
8295 * lisp.mk: New file, split from Makefile.in.
8296 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8297 (shortlisp): Remove.
8298 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8300 2011-05-19 Glenn Morris <rgm@gnu.org>
8302 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8303 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8304 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8305 (lisp): Set the order to that of loadup.el.
8306 (shortlisp): Make it a copy of $lisp.
8307 (SOME_MACHINE_LISP): Remove.
8308 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8309 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8311 2011-05-18 Kenichi Handa <handa@m17n.org>
8313 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8314 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8315 (find_automatic_composition): Mostly rewrite for efficiency.
8317 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8319 * makefile.w32-in: Update dependencies.
8321 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8323 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8324 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8326 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8328 Fix some integer overflow issues, such as string length overflow.
8330 * insdel.c (count_size_as_multibyte): Check for string overflow.
8332 * character.c (lisp_string_width): Check for string overflow.
8333 Use EMACS_INT, not int, for string indexes and lengths; in
8334 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8335 the resulting string length overflows an EMACS_INT; instead,
8336 report a string overflow if no precision given. When checking for
8337 precision exhaustion, use a check that cannot possibly have
8338 integer overflow. (Bug#8675)
8339 * character.h (lisp_string_width): Adjust to new signature.
8341 * alloc.c (string_overflow): New function.
8342 (Fmake_string): Use it. This doesn't change behavior, but saves
8343 a few bytes and will simplify future changes.
8344 * character.c (string_escape_byte8): Likewise.
8345 * lisp.h (string_overflow): New decl.
8347 Fixups, following up to the user-interface timestamp change.
8348 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8349 for UI timestamps, instead of unsigned long.
8350 * msdos.c (mouse_get_pos): Likewise.
8351 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8352 * w32gui.h (Time): Define by including "systime.h" rather than by
8353 declaring it ourselves. (Bug#8664)
8355 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8356 * image.c (clear_image_cache): Likewise.
8358 * term.c (term_mouse_position): Don't assume time_t wraparound.
8360 Be more systematic about user-interface timestamps.
8361 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8362 and sometimes 'EMACS_UINT', to represent these timestamps.
8363 This change causes it to use 'Time' uniformly, as that's what X uses.
8364 This makes the code easier to follow, and makes it easier to catch
8365 integer overflow bugs such as Bug#8664.
8366 * frame.c (Fmouse_position, Fmouse_pixel_position):
8367 Use Time, not unsigned long, for user-interface timestamps.
8368 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8369 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8370 * keyboard.h (last_event_timestamp): Likewise.
8371 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8372 * menu.h (xmenu_show): Likewise.
8373 * term.c (term_mouse_position): Likewise.
8374 * termhooks.h (struct input_event.timestamp): Likewise.
8375 (struct terminal.mouse_position_hook): Likewise.
8376 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8377 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8378 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8379 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8381 * menu.h, termhooks.h: Include "systime.h", for Time.
8383 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8384 Don't assume that the difference between two unsigned long values
8385 can fit into an integer. At this point, we know button_down_time
8386 <= event->timestamp, so the difference must be nonnegative, so
8387 there's no need to cast the result if double-click-time is
8388 nonnegative, as it should be; check that it's nonnegative, just in
8389 case. This bug is triggered when events are more than 2**31 ms
8390 apart (about 25 days). (Bug#8664)
8392 * xselect.c (last_event_timestamp): Remove duplicate decl.
8393 (x_own_selection): Remove needless cast to unsigned long.
8395 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8396 that always fit in int. Use a sentinel instead of a counter, to
8397 avoid a temp and to allay GCC's concerns about possible int overflow.
8398 * frame.h (struct frame): Use int for menu_bar_items_used
8399 instead of EMACS_INT, since it always fits in int.
8401 * menu.c (grow_menu_items): Check for int overflow.
8403 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8405 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8406 Before, the code was not consistent. These values cannot exceed
8407 2**31 - 1 so there's no need to make them unsigned.
8408 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8409 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8410 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8412 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8414 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8415 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8416 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8417 presumably because the widths might not match.
8419 * window.c (size_window): Avoid needless test at loop start.
8421 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8423 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8425 2011-05-12 Drew Adams <drew.adams@oracle.com>
8427 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8429 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8431 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8432 `width' to `bar_area_x' and `bar_area_width', respectively.
8433 (x_scroll_run): Take account of fringe background extension.
8435 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8436 Rename local vars `left' and `width' to `bar_area_x' and
8437 `bar_area_width', respectively.
8438 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8439 background extension.
8441 2011-05-10 Jim Meyering <meyering@redhat.com>
8443 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8445 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8447 * image.c (Finit_image_library): Return t for built-in image types,
8448 like pbm and xbm. (Bug#8640)
8450 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8452 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8454 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8456 * w32console.c (Fset_screen_color): Doc fix.
8457 (Fget_screen_color): New function.
8458 (syms_of_ntterm): Defsubr it.
8460 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8461 unlink the temporary file if Fcall_process didn't create it in the
8463 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8464 child process will be redirected to a file specified with `:file'.
8465 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8466 cue to call_process_cleanup not to close that handle.
8468 2011-05-07 Ben Key <bkey76@gmail.com>
8470 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8471 one of two shell specific rules, either bootstrap-temacs-CMD or
8472 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8473 to the previous implementation of the bootstrap-temacs rule.
8474 The bootstrap-temacs-CMD rule is similar to the previous
8475 implementation of the bootstrap-temacs rule except that it
8476 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8479 These changes, along with some changes to nt/configure.bat,
8480 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8481 earlier fix to add support for --cflags and --ldflags options
8482 that include quotes so that it works whether make uses cmd or
8485 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8487 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8488 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8490 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8491 a string. Handle both cases.
8492 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8493 (Fdbus_register_method): Use Qinvalid_function.
8495 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8497 * makefile.w32-in: Update dependencies.
8498 (LISP_H): Add inttypes.h and stdin.h.
8499 (PROCESS_H): Add unistd.h.
8501 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8503 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8504 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8506 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8508 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8510 * term.c (vfatal): Remove stray call to va_end.
8511 It's not needed and the C Standard doesn't allow it here anyway.
8513 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8514 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8516 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8519 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8521 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8523 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8525 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8527 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8529 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8530 * charset.c (Fdefine_charset_internal): Don't initialize
8531 charset.code_space[15]. The value was garbage, on hosts with
8532 32-bit int (Bug#8600).
8534 * lread.c (read_integer): Be more consistent with string-to-number.
8535 Use string_to_number to do the actual conversion; this avoids
8536 rounding errors and fixes some other screwups. Without this fix,
8537 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8538 (digit_to_number): Move earlier, for benefit of read_integer.
8539 Return -1 if the digit is out of range for the base, -2 if it is
8540 not a digit in any supported base. (Bug#8602)
8542 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8544 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8545 to match comment at start of function. This also removes a
8546 GCC warning about overflow in a 32+64-bit port.
8548 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8550 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8551 Reported by Stefan Monnier in
8552 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8553 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8554 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8556 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8557 (EMACS_UINTPTR): Likewise, with uintptr_t.
8559 * lisp.h: Prefer 64-bit EMACS_INT if available.
8560 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8561 on 32-bit hosts that have 64-bit int, so that they can access
8563 However, temporarily disable this change unless the temporary
8564 symbol WIDE_EMACS_INT is defined.
8566 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8568 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8569 This removes an assumption that EMACS_INT and long are the same
8570 width as pointers. The assumption is true for Emacs porting targets
8571 now, but we want to make other targets possible.
8572 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8573 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8574 In the rest of the code, change types of integers that hold casted
8575 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8576 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8577 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8578 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8579 No need to cast type when ORing.
8580 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8581 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8582 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8583 assume EMACS_INT is the same width as char *.
8584 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8585 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8586 Remove no-longer-needed casts.
8587 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8588 (xg_tool_bar_help_callback, xg_make_tool_item):
8589 Use EMACS_INTPTR to hold an integer
8590 that will be cast to void *; this can avoid a GCC warning
8591 if EMACS_INT is not the same width as void *.
8592 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8593 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8594 (current_message_1, set_message_1):
8595 Use a local to convert to proper width without a cast.
8596 * xmenu.c (dialog_selection_callback): Likewise.
8598 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8599 Also, don't assume VALBITS / RAND_BITS is less than 5,
8600 and don't rely on undefined behavior when shifting a 1 left into
8602 * lisp.h (get_random): Change signature to match.
8604 * lread.c (hash_string): Use size_t, not int, for hash computation.
8605 Normally we prefer signed values; but hashing is special, because
8606 it's better to use unsigned division on hash table sizes so that
8607 the remainder is nonnegative. Also, size_t is the natural width
8608 for hashing into memory. The previous code used 'int', which doesn't
8609 retain enough info to hash well into very large tables.
8610 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8612 * dbusbind.c: Don't possibly lose pointer info when converting.
8613 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8614 Use XPNTR rather than XHASH, so that the high-order bits of
8615 the pointer aren't lost when converting through void *.
8617 * eval.c (Fautoload): Don't double-shift a pointer.
8619 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8621 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8623 * gnutls.c (DEF_GNUTLS_FN):
8624 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8626 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8628 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8631 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8633 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8634 New version that can reserve upto 2GB of heap space.
8636 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8638 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8640 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8642 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8643 `gnutls_certificate_set_x509_key_file'.
8645 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8647 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8648 Update dependencies.
8650 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8652 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8653 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8654 Remove unused parameter `fildes'.
8655 * process.c (read_process_output, send_process): Don't pass it.
8657 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8659 Fix previous change: the library cache is defined in w32.c.
8660 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8661 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8663 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8665 Implement dynamic loading of GnuTLS on Windows.
8667 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8668 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8669 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8672 * gnutls.c (Qgnutls_dll): Define.
8673 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8674 (gnutls_*): Declare function pointers.
8675 (init_gnutls_functions): New function to initialize function pointers.
8676 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8677 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8678 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8679 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8680 (emacs_gnutls_write, emacs_gnutls_read)
8681 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8682 (Fgnutls_available_p): New function.
8683 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8684 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8685 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8687 * image.c: Include w32.h.
8688 (Vimage_type_cache): Delete.
8689 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8690 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8691 (w32_delayed_load): Move to w32.c.
8693 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8695 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8696 (w32_delayed_load): Move from image.c. When loading a library, record
8697 its filename in the :loaded-from property of the library id.
8698 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8699 Initialize and staticpro them.
8700 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8702 * process.c: Include lisp.h before w32.h, not after.
8703 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8704 instead of gnutls_record_check_pending.
8706 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8708 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8710 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8711 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8714 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8716 * xterm.c (x_set_frame_alpha): Do not set property on anything
8717 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8719 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8721 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8723 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8725 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8726 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8727 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8728 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8729 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8730 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8731 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8732 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8733 (Qgnutls_bootprop_callbacks_verify): Make static.
8735 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8737 * callproc.c: Indentation fixup.
8739 * sysdep.c (wait_for_termination_1): Make static.
8740 (wait_for_termination, interruptible_wait_for_termination):
8741 Move after wait_for_termination_1.
8743 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8745 * sysdep.c (interruptible_wait_for_termination): New function
8746 which is like wait_for_termination, but allows keyboard
8749 * callproc.c (Fcall_process): Add (:file "file") as an option for
8751 (Fcall_process_region): Ditto.
8753 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8755 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8756 rather than `XVECTOR (FOO)->size'.
8758 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8759 inttypes.h, as a gnulib replacement is used if it not available in
8762 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8764 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8765 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8766 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8768 * coding.c (coding_alloc_by_realloc): Error out if destination
8769 will grow beyond MOST_POSITIVE_FIXNUM.
8770 (decode_coding_emacs_mule): Abort if there isn't enough place in
8771 charbuf for the composition carryover bytes. Reserve an extra
8772 space for up to 2 characters produced in a loop.
8773 (decode_coding_iso_2022): Abort if there isn't enough place in
8774 charbuf for the composition carryover bytes.
8776 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8778 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8779 aborting when %lld or %lll format is passed.
8780 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8781 %llo or %llx format is passed. (Bug#8545)
8783 * window.c (window_scroll_line_based): Use a marker instead of
8784 simple variables to record original value of point. (Bug#7952)
8786 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8787 produced by %s or %c overflows available buffer space. (Bug#8545)
8789 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8791 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8792 (SIZE_MAX): Move defn after all includes, as they might #define it.
8794 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8796 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8798 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8800 * keyboard.c (Qdelayed_warnings_hook): Define.
8801 (command_loop_1): Run `delayed-warnings-hook'
8802 if Vdelayed_warnings_list is non-nil.
8803 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8804 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8806 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8808 * doprnt.c (doprnt): Don't return value smaller than the buffer
8809 size if the message was truncated. (Bug#8545).
8811 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8813 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8814 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8816 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8818 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8820 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8822 * makefile.w32-in: Update dependencies.
8824 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8826 Improve `doprnt' and its usage. (Bug#8545)
8827 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8828 `format_end'. Remove support for %l as a conversion specifier.
8829 Don't use xrealloc. Improve diagnostics when the %l size modifier
8830 is used. Update the commentary.
8832 * eval.c (verror): Simplify calculation of size_t.
8834 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8837 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8839 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8842 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8844 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8845 This makes this file independent of the recent pseudovector change.
8847 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8849 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8851 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8852 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8853 Remove unused local.
8854 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8856 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8857 GCC 4.6.0 optimizes based on type-based alias analysis.
8858 For example, if b is of type struct buffer * and v of type struct
8859 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8860 != &v->size, and therefore "v->size = 1; b->size = 2; return
8861 v->size;" must therefore return 1. This assumption is incorrect
8862 for Emacs, since it type-puns struct Lisp_Vector * with many other
8863 types. To fix this problem, this patch adds a new type struct
8864 vectorlike_header that documents the constraints on layout of vectors
8865 and pseudovectors, and helps optimizing compilers not get fooled
8866 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8867 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8868 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8870 (XSETPVECTYPE): Rewrite in terms of new macro.
8871 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8872 This is a bit clearer, and further avoids the possibility of
8873 undesirable aliasing.
8874 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8875 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8876 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8877 since Lisp_Subr is a special case (no "next" field).
8878 (ASIZE): Now uses header.size rather than size.
8879 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8880 to avoid the hassle of writing XVECTOR (foo)->header.size.
8881 (struct vectorlike_header): New type.
8882 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8883 object, to help avoid aliasing.
8884 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8885 (SUBRP): Likewise, since Lisp_Subr is a special case.
8886 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8887 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8888 (struct Lisp_Hash_Table): Combine first two members into a single
8889 struct vectorlike_header member. All uses of "size" and "next" members
8890 changed to be "header.size" and "header.next".
8891 * buffer.h (struct buffer): Likewise.
8892 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8893 * frame.h (struct frame): Likewise.
8894 * process.h (struct Lisp_Process): Likewise.
8895 * termhooks.h (struct terminal): Likewise.
8896 * window.c (struct save_window_data, struct saved_window): Likewise.
8897 * window.h (struct window): Likewise.
8898 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8899 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8900 * buffer.c (init_buffer_once): Likewise.
8901 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8903 * process.c (Fformat_network_address): Use local var for size,
8906 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8908 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8909 * data.c (atof): Remove decl; no longer used or needed.
8910 (digit_to_number): Move to lread.c.
8911 (Fstring_to_number): Use new string_to_number function, to be
8912 consistent with how the Lisp reader treats infinities and NaNs.
8913 Do not assume that floating-point numbers represent EMACS_INT
8914 without losing information; this is not true on most 64-bit hosts.
8915 Avoid double-rounding errors, by insisting on integers when
8916 parsing non-base-10 numbers, as the documentation specifies.
8917 * lisp.h (string_to_number): New decl, replacing ...
8918 (isfloat_string): Remove.
8919 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8920 (read1): Do not accept +. and -. as integers; this
8921 appears to have been a coding error. Similarly, do not accept
8922 strings like +-1e0 as floating point numbers. Do not report
8923 overflow for integer overflows unless the base is not 10 which
8924 means we have no simple and reliable way to continue.
8925 Break out the floating-point parsing into a new
8926 function string_to_number, so that Fstring_to_number parses
8927 floating point numbers consistently with the Lisp reader.
8928 (digit_to_number): Move here from data.c. Make it static inline.
8929 (E_CHAR, EXP_INT): Remove, replacing with ...
8930 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8931 (string_to_number): New function, replacing isfloat_string.
8932 This function checks for valid syntax and produces the resulting
8933 Lisp float number too. Rework it so that string-to-number
8934 no longer mishandles examples like "1.0e+". Use strtoumax,
8935 so that overflow for non-base-10 numbers is reported only when
8936 there's no portable and simple way to convert to floating point.
8938 * textprop.c (set_text_properties_1): Rewrite for clarity,
8939 and to avoid GCC warning about integer overflow.
8941 * intervals.h (struct interval): Use EMACS_INT for members
8942 where EMACS_UINT might cause problems. See
8943 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8944 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8945 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8947 (offset_intervals): Tell GCC not to worry about length overflow
8948 when negating a negative length.
8950 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8951 (overrun_check_free): Likewise.
8953 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8954 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8957 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8958 (gnutls_make_error): Rename local to avoid shadowing.
8959 (gnutls_emacs_global_deinit): ifdef out; not used.
8960 (Fgnutls_boot): Use const for pointer to readonly storage.
8961 Comment out unused local. Fix pointer signedness problems.
8963 * lread.c (openp): Don't stuff size_t into an 'int'.
8964 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8965 about possible signed overflow.
8967 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8968 (GDK_KEY_g): Don't define if already defined.
8969 (xg_prepare_tooltip): Avoid pointer signedness problem.
8970 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8972 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8973 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8975 * xfns.c (Fx_window_property): Simplify a bit,
8976 to make a bit faster and to avoid GCC 4.6.0 warning.
8977 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8979 * fns.c (internal_equal): Don't assume size_t fits in int.
8981 * alloc.c (compact_small_strings): Tighten assertion a little.
8983 Replace pEd with more-general pI, and fix some printf arg casts.
8984 * lisp.h (pI): New macro, generalizing old pEd macro to other
8985 conversion specifiers. For example, use "...%"pI"d..." rather
8986 than "...%"pEd"...".
8987 (pEd): Remove. All uses replaced with similar uses of pI.
8988 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8989 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8990 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8991 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8992 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8993 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8994 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8996 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8997 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8998 * print.c (safe_debug_print, print_object): Likewise.
8999 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9001 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9002 avoiding the 0 flag, which is not portable.
9003 * process.c (Fmake_network_process): Use pI to avoid cast.
9004 * region-cache.c (pp_cache): Likewise.
9005 * xdisp.c (decode_mode_spec): Likewise.
9006 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9007 behavior on 64-bit hosts with printf arg.
9008 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9009 (x_stop_queuing_selection_requests): Likewise.
9010 (x_get_window_property): Don't truncate byte count to an 'int'
9013 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9014 here, since it parses constructs like leading '-' and spaces,
9015 which are not wanted; and it overflows with large numbers.
9016 Instead, simply match F[0-9]+, which is what is wanted anyway.
9018 * alloc.c: Remove unportable assumptions about struct layout.
9019 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9020 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9021 (allocate_vectorlike, make_pure_vector): Use the new macros,
9022 plus offsetof, to remove unportable assumptions about struct layout.
9023 These assumptions hold on all porting targets that I know of, but
9024 they are not guaranteed, they're easy to remove, and removing them
9025 makes further changes easier.
9027 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9028 This doesn't fix a bug but makes the code clearer.
9029 (string_overrun_cookie): Now const. Use initializers that
9030 don't formally overflow signed char, to avoid warnings.
9031 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9032 can cause Emacs to crash when string overrun checking is enabled.
9033 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9034 multiple of sizeof (EMACS_INT); it need not be, if
9035 alignof(EMACS_INT) < sizeof (EMACS_INT).
9036 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9038 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9040 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9042 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9044 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9045 supposed to be handshaking. (Bug#8556)
9046 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9048 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9050 * lisp.h (Qdebug): List symbol.
9051 * eval.c (Qdebug): Restore global linkage.
9052 * keyboard.c (debug-on-event): New variable.
9053 (handle_user_signal): Break into debugger when debug-on-event
9054 matches the current signal symbol.
9056 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9058 * alloc.c (check_sblock, check_string_bytes)
9059 (check_string_free_list): Convert to standard C.
9061 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9063 * w32.c (emacs_gnutls_push): Fix typo.
9065 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9067 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9068 "cast to pointer from integer of different size".
9070 Improve doprnt and its use in verror. (Bug#8545)
9071 * doprnt.c (doprnt): Document the set of format control sequences
9072 supported by the function. Use SAFE_ALLOCA instead of always
9075 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9076 is one byte too soon. Don't use xrealloc; instead xfree and
9079 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9081 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9084 * gnutls.c: Renamed global_initialized to
9085 gnutls_global_initialized. Added internals for the
9086 :verify-hostname-error, :verify-error, and :verify-flags
9087 parameters of `gnutls-boot' and documented those parameters in the
9088 docstring. Start callback support.
9089 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9090 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9091 on error. Return error code.
9092 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9093 (emacs_gnutls_read): Likewise.
9094 (Fgnutls_boot): Return handshake error code.
9095 (emacs_gnutls_handle_error): New function.
9096 (wsaerror_to_errno): Likewise.
9098 * w32.h (emacs_gnutls_pull): Add prototype.
9099 (emacs_gnutls_push): Likewise.
9101 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9102 (emacs_gnutls_push): Likewise.
9104 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9106 * process.c (wait_reading_process_output): Check if GnuTLS
9107 buffered some data internally if no FDs are set for TLS
9110 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9111 (LIBS): Link to USER_LIBS.
9112 ($(BLD)/gnutls.$(0)): New target.
9114 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9116 * xdisp.c (handle_single_display_spec): Rename the
9117 display_replaced_before_p argument into display_replaced_p, to
9118 make it consistent with the commentary. Fix typos in the
9121 * textprop.c (syms_of_textprop): Remove dead code.
9122 (copy_text_properties): Delete obsolete commentary about an
9123 interface that was deleted long ago. Fix typos in the description
9126 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9127 to changes in oldXMenu/XMenu.h from 2011-04-16.
9128 <menu_help_message, prev_menu_help_message>: Constify.
9129 (IT_menu_make_room): menu->help_text is now `const char **';
9132 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9133 to changes in oldXMenu/XMenu.h from 2011-04-16.
9134 (struct XMenu): Declare `help_text' `const char **'.
9136 * xfaces.c <Qunspecified>: Make extern again.
9138 * syntax.c: Include sys/types.h before including regex.h, as
9141 * doc.c (get_doc_string): Improve the format passed to `error'.
9143 * doprnt.c (doprnt): Improve commentary.
9145 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9147 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9150 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9151 changes in globals.h immediately force recompilation.
9152 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9153 $(CURDIR)/s/ms-w32.h.
9154 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9156 * character.c (Fchar_direction): Function deleted.
9157 (syms_of_character): Don't defsubr it.
9158 <char-direction-table>: Deleted.
9160 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9162 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9163 * doprnt.c: Include limits.h.
9164 (SIZE_MAX): New macro.
9165 (doprnt): Return a size_t value. 2nd arg is now size_t.
9166 Many local variables are now size_t instead of int or unsigned.
9167 Improve overflow protection. Support `l' modifier for integer
9168 conversions. Support %l conversion. Don't assume an EMACS_INT
9169 argument for integer conversions and for %c.
9171 * lisp.h (doprnt): Restore prototype.
9173 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9176 * Makefile.in (base_obj): Add back doprnt.o.
9178 * deps.mk (doprnt.o): Add back prerequisites.
9179 (callint.o): Depend on character.h.
9181 * eval.c (internal_lisp_condition_case): Include the handler
9182 representation in the error message.
9183 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9184 when breaking from the loop.
9186 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9188 * callint.c (Fcall_interactively): When displaying error message
9189 about invalid control letter, pass the character's codepoint, not
9190 a pointer to its multibyte form. Improve display of the character
9191 in octal and display also its hex code.
9193 * character.c (char_string): Use %x to display the (unsigned)
9194 codepoint of an invalid character, to avoid displaying a bogus
9197 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9198 `error', not SYMBOL_NAME itself.
9200 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9201 character arguments to `error'.
9203 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9204 to `error' in error message about FINAL_CHAR argument. Make sure
9205 FINAL_CHAR is a character, and use %c when it is passed as
9206 argument to `error'.
9208 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9210 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9212 * w32.c: Include <time.h>.
9213 (sys_localtime): New function.
9215 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9217 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9219 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9221 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9223 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9226 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9228 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9229 gl_state.e_property when gl_state.object is Qt.
9231 * insdel.c (make_gap_larger): Remove limitation of buffer size
9234 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9236 * xdisp.c (lookup_glyphless_char_display)
9237 (produce_glyphless_glyph): Handle cons cell entry in
9238 glyphless-char-display.
9239 (Vglyphless_char_display): Document it.
9241 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9242 glyphless-char-display.
9244 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9246 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9248 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9250 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9251 definition for no-X builds.
9253 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9255 Static checks with GCC 4.6.0 and non-default toolkits.
9257 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9259 * process.c (keyboard_bit_set): Define only if SIGIO.
9260 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9261 (send_process): Repair possible setjmp clobbering.
9263 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9265 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9267 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9269 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9270 Define only if needed.
9272 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9273 by pacifying GCC about it. Maybe it's time to retire it?
9274 * xfaces.c (USG, __TIMEVAL__): Likewise.
9276 * dispextern.h (struct redisplay_interface): Rename param
9278 * termhooks.h (struct terminal): Likewise.
9279 * xterm.c (xembed_send_message): Likewise.
9281 * insdel.c (make_gap_smaller): Define only if
9282 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9284 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9287 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9288 so that we aren't warned about unused symbols.
9290 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9292 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9294 * xfns.c (x_real_positions): Mark locals as initialized.
9296 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9298 * xterm.c: Fix problems found by static analysis with other toolkits.
9299 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9300 (x_dispatch_event): Declare static if USE_GTK, and
9301 define if USE_GTK || USE_X_TOOLKIT.
9302 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9303 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9304 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9305 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9307 * xmenu.c (menu_help_callback): Pointer type fixes.
9308 Use const pointers when pointing at readonly data. Avoid pointer
9310 (FALSE): Remove unused macro.
9311 (update_frame_menubar): Remove unused decl.
9313 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9315 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9316 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9317 (single_menu_item): Rename local to avoid shadowing.
9319 * keyboard.c (make_lispy_event): Remove unused local var.
9321 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9322 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9324 * bitmaps: Change bitmaps from unsigned char back to the X11
9325 compatible char. Avoid the old compiler warnings about
9326 out-of-range initializers by using, for example, '\xab' rather
9329 * xgselect.c (xgselect_initialize): Check vs interface
9330 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9332 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9334 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9335 to read-only memory.
9337 * fns.c (vector): Remove; this old hack is no longer needed.
9339 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9341 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9343 * xrdb.c (x_load_resources): Omit unused local.
9345 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9346 (x_window): Rename locals to avoid shadowing.
9347 (USG): Use the kludged USG macro, to pacify gcc.
9349 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9350 (x_term_init): Remove local to avoid shadowing.
9352 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9354 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9355 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9357 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9359 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9361 Fix regex.c, syntax.c and friends for buffers > 2GB.
9362 * syntax.h (struct gl_state_s): Declare character position members
9365 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9367 * textprop.c (verify_interval_modification, interval_of):
9368 Declare arguments EMACS_INT.
9370 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9373 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9375 * indent.c (Fvertical_motion): Local variable it_start is now
9378 * regex.c (re_match, re_match_2, re_match_2_internal)
9379 (bcmp_translate, regcomp, regexec, print_double_string)
9380 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9381 (re_compile_pattern, re_exec): Declare arguments and local
9382 variables `size_t' and `ssize_t' and return values `regoff_t', as
9384 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9385 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9386 <compile_stack_type>: `size' and `avail' are now `size_t'.
9388 * regex.h <regoff_t>: Use ssize_t, not int.
9389 (re_search, re_search_2, re_match, re_match_2): Arguments that
9390 specify buffer/string position and length are now ssize_t and
9391 size_t. Return type is regoff_t.
9393 2011-04-16 Ben Key <bkey76@gmail.com>
9395 * nsfont.m: Fixed bugs in ns_get_family and
9396 ns_descriptor_to_entity that were caused by using free to
9397 deallocate memory blocks that were allocated by xmalloc (via
9398 xstrdup). This caused Emacs to crash when compiled with
9399 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9400 --enable-checking=xmallocoverrun). xfree is now used to
9401 deallocate these memory blocks.
9403 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9405 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9407 emacs_write: Accept and return EMACS_INT for sizes.
9408 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9410 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9411 Accept and return EMACS_INT.
9412 (emacs_gnutls_write): Return the number of bytes written on
9414 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9415 (emacs_read, emacs_write): Remove check for negative size, as the
9416 Emacs source code has been audited now.
9417 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9418 (emacs_read, emacs_write): Use it.
9419 * process.c (send_process): Adjust to the new signatures of
9420 emacs_write and emacs_gnutls_write. Do not attempt to store
9421 a byte offset into an 'int'; it might overflow.
9422 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9424 * sound.c: Don't assume sizes fit in 'int'.
9425 (struct sound_device.period_size, alsa_period_size):
9426 Return EMACS_INT, not int.
9427 (struct sound_device.write, vox_write, alsa_write):
9428 Accept EMACS_INT, not int.
9429 (wav_play, au_play): Use EMACS_INT to store sizes and to
9430 record read return values.
9432 2011-04-15 Ben Key <bkey76@gmail.com>
9434 * keyboard.c (Qundefined): Don't declare static since it is used
9436 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9437 static since they are used in nsfont.m.
9439 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9441 * process.c (Qprocessp): Don't declare static.
9442 * lisp.h (Qprocessp): Declare again.
9444 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9446 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9448 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9450 Improve C-level modularity by making more things 'static'.
9452 Don't publish debugger-only interfaces to other modules.
9453 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9454 (verify_bytepos, count_markers): Move decls to the only modules
9456 * region-cache.h (pp_cache): Likewise.
9457 * window.h (check_all_windows): Likewise.
9458 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9460 * sysdep.c (croak): Now static, if
9461 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9462 * syssignal.h (croak): Declare only if not static.
9464 * alloc.c (refill_memory_reserve): Now static if
9465 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9466 * lisp.h (refill_memory_reserve): Declare only if not static.
9468 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9469 Define only if USE_LUCID.
9471 * xrdb.c (x_customization_string, x_rm_string): Now static.
9473 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9474 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9476 * xdisp.c (draw_row_with_mouse_face): Now static.
9477 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9479 * window.h (check_all_windows): Mark externally visible.
9481 * window.c (window_deletion_count): Now static.
9483 * undo.c: Make symbols static if they're not exported.
9484 (last_undo_buffer, last_boundary_position, pending_boundary):
9487 * textprop.c (interval_insert_behind_hooks): Now static.
9488 (interval_insert_in_front_hooks): Likewise.
9490 * term.c: Make symbols static if they're not exported.
9491 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9492 (max_frame_lines, tty_set_terminal_modes):
9493 (tty_reset_terminal_modes, tty_turn_off_highlight):
9494 (get_tty_terminal): Now static.
9495 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9496 * termhooks.h (term_mouse_moveto): Do not declare if
9498 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9499 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9501 * sysdep.c: Make symbols static if they're not exported.
9502 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9504 (sigprocmask_set, full_mask): Remove; unused.
9505 (wait_debugging): Mark as visible.
9506 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9507 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9509 * syntax.c (syntax_temp): Define only if !__GNUC__.
9511 * sound.c (current_sound_device, current_sound): Now static.
9513 * search.c (searchbufs, searchbuf_head): Now static.
9515 * scroll.c (scroll_cost): Remove; unused.
9516 * dispextern.h (scroll_cost): Remove decl.
9518 * region-cache.h (pp_cache): Mark as externally visible.
9520 * process.c: Make symbols static if they're not exported.
9521 (process_tick, update_tick, create_process, chan_process):
9522 (Vprocess_alist, proc_buffered_char, datagram_access):
9523 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9524 (deactivate_process): Mark defn as static, as well as decl.
9525 * lisp.h (create_process): Remove decl.
9526 * process.h (chan_process, Vprocess_alist): Remove decls.
9528 * print.c: Make symbols static if they're not exported.
9529 (print_depth, new_backquote_output, being_printed, print_buffer):
9530 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9531 (print_interval, print_number_index, initial_stderr_stream):
9533 * lisp.h (Fprinc): Remove decl.
9534 (debug_output_compilation_hack): Mark as externally visible.
9536 * sysdep.c (croak): Move decl from here to syssignal.h.
9537 * syssignal.h (croak): Put it here, so the API can be checked when
9538 'croak' is called from dissociate_if_controlling_tty.
9540 * minibuf.c: Make symbols static if they're not exported.
9541 (minibuf_save_list, choose_minibuf_frame): Now static.
9542 * lisp.h (choose_minibuf_frame): Remove decl.
9544 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9546 * lread.c: Make symbols static if they're not exported.
9547 (read_objects, initial_obarray, oblookup_last_bucket_number):
9549 (make_symbol): Remove; unused.
9550 * lisp.h (initial_obarray, make_symbol): Remove decls.
9552 * keyboard.c: Make symbols static if they're not exported.
9553 (single_kboard, recent_keys_index, total_keys, recent_keys):
9554 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9555 (this_single_command_key_start, echoing, last_auto_save):
9556 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9557 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9558 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9559 (Vlispy_mouse_stem, double_click_count):
9561 (force_auto_save_soon): Define only if SIGDANGER.
9562 (ignore_mouse_drag_p): Now static if
9563 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9564 (print_help): Remove; unused.
9565 (stop_character, last_timer_event): Mark as externally visible.
9566 * keyboard.h (ignore_mouse_drag_p): Declare only if
9567 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9568 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9569 * lisp.h (echoing): Remove decl.
9570 (force_auto_save_soon): Declare only if SIGDANGER.
9571 * xdisp.c (redisplay_window): Simplify code, to make it more
9572 obvious that ignore_mouse_drag_p is not accessed if !defined
9573 USE_GTK && !defined HAVE_NS.
9575 * intervals.c: Make symbols static if they're not exported.
9576 (merge_properties_sticky, merge_interval_right, delete_interval):
9578 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9580 * insdel.c: Make symbols static if they're not exported.
9581 However, leave prepare_to_modify_buffer alone. It's never
9582 called from outside this function, but that appears to be a bug.
9583 (combine_after_change_list, combine_after_change_buffer):
9584 (adjust_after_replace, signal_before_change): Now static.
9585 (adjust_after_replace_noundo): Remove; unused.
9586 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9587 (signal_before_change): Remove decls.
9589 * indent.c (val_compute_motion, val_vmotion): Now static.
9591 * image.c: Make symbols static if they're not exported.
9592 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9594 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9595 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9597 * fringe.c (standard_bitmaps): Now static.
9598 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9600 * frame.c: Make symbols static if they're not exported.
9601 (x_report_frame_params, make_terminal_frame): Now static.
9602 (get_frame_param): Now static, unless HAVE_NS.
9603 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9604 (x_get_resource_string): Remove; not used.
9605 * frame.h (make_terminal_frame, x_report_frame_params):
9606 (x_get_resource_string); Remove decls.
9607 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9608 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9610 * font.c, fontset.c: Make symbols static if they're not exported.
9611 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9612 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9613 * font.c (font_close_object): Now static.
9614 * font.h (font_close_object): Remove.
9615 * fontset.c (FONTSET_OBJLIST): Remove.
9616 (free_realized_fontset) #if-0 the body, which does nothing.
9617 (face_suitable_for_char_p): #if-0, as it's never called.
9618 * fontset.h (face_suitable_for_char_p): Remove decl.
9619 * xfaces.c (face_at_string_position):
9620 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9621 since 0 is always ASCII.
9623 * fns.c (weak_hash_tables): Now static.
9625 * fileio.c: Make symbols static if they're not exported.
9626 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9627 (Vwrite_region_annotation_buffers): Now static.
9629 * eval.c: Make symbols static if they're not exported.
9630 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9631 * lisp.h (backtrace_list): Remove decl.
9633 * emacs.c: Make symbols static if they're not exported.
9634 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9635 (fatal_error_code, fatal_error_signal_hook, standard_args):
9637 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9638 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9639 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9640 * lisp.h (fatal_error_signal_hook): Remove decl.
9641 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9643 * editfns.c: Move a (normally-unused) function to its only use.
9644 * editfns.c, lisp.h (get_operating_system_release): Remove.
9645 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9646 worth the hassle of breaking this out.
9648 * xterm.c: Make symbols static if they're not exported.
9649 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9650 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9651 (x_destroy_window, x_delete_display):
9653 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9654 (x_mouse_leave): Remove; unused.
9655 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9656 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9657 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9659 (x_mouse_leave): Declare only if WINDOWSNT.
9660 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9661 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9664 * ftxfont.c: Make symbols static if they're not exported.
9665 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9667 * font.h (ftxfont_driver): Likewise.
9669 * xfns.c: Make symbols static if they're not exported.
9670 (x_last_font_name, x_display_info_for_name):
9671 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9672 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9673 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9674 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9675 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9676 (last_show_tip_args): Now static.
9677 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9678 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9679 (x_screen_planes): Remove; unused.
9680 * dispextern.h (x_screen_planes): Remove decl.
9682 * dispnew.c: Make symbols static if they're not exported.
9683 * dispextern.h (redraw_garbaged_frames, scrolling):
9684 (increment_row_positions): Remove.
9685 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9686 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9688 (redraw_garbaged_frames): Remove; unused.
9690 * xfaces.c: Make symbols static if they're not exported.
9691 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9693 * xterm.h (defined_color): Remove decls.
9694 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9695 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9696 (menu_face_changed_default, defined_color, free_realized_face):
9697 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9698 (ascii_face_of_lisp_face): Remove; unused.
9700 * xdisp.c: Make symbols static if they're not exported.
9701 * dispextern.h (scratch_glyph_row, window_box_edges):
9702 (glyph_to_pixel_coords, set_cursor_from_row):
9703 (get_next_display_element, set_iterator_to_next):
9704 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9705 (show_mouse_face): Remove decls
9706 * frame.h (message_buf_print): Likewise.
9707 * lisp.h (pop_message, set_message, check_point_in_composition):
9709 * xterm.h (set_vertical_scroll_bar): Likewise.
9710 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9711 (message_buf_print, scratch_glyph_row, displayed_buffer):
9712 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9713 (get_next_display_element, show_mouse_face, window_box_edges):
9714 (frame_to_window_pixel_xy, check_point_in_composition):
9715 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9716 (glyph_to_pixel_coords): Remove; unused.
9718 * dired.c (file_name_completion): Now static.
9720 * dbusbind.c (xd_in_read_queued_messages): Now static.
9722 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9723 * data.c (circular_list_error): Remove.
9725 * commands.h (last_point_position, last_point_position_buffer):
9726 (last_point_position_window): Remove decls.
9727 * keyboard.c: Make these variables static.
9729 * coding.h (coding, code_convert_region, encode_coding_gap):
9731 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9732 (iso_code_class, detect_coding, code_convert_region): Now static.
9733 (encode_coding_gap): Remove; unused.
9735 * chartab.c (chartab_chars, chartab_bits): Now static.
9737 * charset.h (charset_iso_8859_1): Remove decl.
9738 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9741 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9742 * ccl.c (Vccl_program_table): Now static.
9743 (check_ccl_update): Remove; unused.
9745 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9746 * category.h: ... from here.
9747 * category.c (check_category_table, set_category_set): Now static.
9749 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9750 * lisp.h: Remove these decls.
9752 * buffer.c (buffer_count): Remove unused var.
9754 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9755 so that it's not optimized away.
9756 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9757 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9758 exported only to the debugger.
9760 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9761 * atimer.h (run_all_atimers): Remove; not exported.
9763 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9764 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9765 was inaccessible from Lisp.
9766 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9767 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9769 alloc.c: Import and export fewer symbols, and remove unused items.
9770 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9772 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9773 it's not optimized away by whole-program optimization.
9774 (message_enable_multibyte, free_misc): Remove.
9775 (catchlist, handlerlist, mark_backtrace):
9776 Declare only if BYTE_MARK_STACK.
9777 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9778 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9779 (message_enable_multibyte): Remove decl.
9780 (free_misc, interval_free_list, float_block, float_block_index):
9781 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9782 (cons_free_list, last_marked_index):
9784 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9785 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9786 (mark_backtrace): Define only if BYTE_MARK_STACK.
9787 * xdisp.c (message_enable_multibyte): Now static.
9789 Declare Lisp_Object Q* variables to be 'static' if not exported.
9790 This makes it easier for human readers (and static analyzers)
9791 to see whether these variables are used from other modules.
9792 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9793 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9794 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9795 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9796 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9797 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9798 * xmenu.c, xselect.c:
9799 Declare Q* vars static if they are not used in other modules.
9800 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9801 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9802 Remove decls of unexported vars.
9803 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9805 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9807 Make Emacs functions such as Fatom 'static' by default.
9808 This makes it easier for human readers (and static analyzers)
9809 to see whether these functions can be called from other modules.
9810 DEFUN now defines a static function. To make the function external
9811 so that it can be used in other C modules, use the new macro DEFUE.
9812 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9813 (Finit_image_library):
9814 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9815 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9816 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9817 Remove decls, since these functions are now static.
9818 (Funintern, Fget_internal_run_time): New decls, since these functions
9819 were already external.
9821 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9822 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9823 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9824 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9825 * keyboard.c, keymap.c, lread.c:
9826 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9827 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9828 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9829 Mark functions with DEFUE instead of DEFUN,
9830 if they are used in other modules.
9831 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9832 decls for now-static functions.
9833 * buffer.h (Fdelete_overlay): Remove decl.
9834 * callproc.c (Fgetenv_internal): Mark as internal.
9835 * composite.c (Fremove_list_of_text_properties): Remove decl.
9836 (Fcomposition_get_gstring): New forward static decl.
9837 * composite.h (Fcomposite_get_gstring): Remove decl.
9838 * dired.c (Ffile_attributes): New forward static decl.
9839 * doc.c (Fdocumntation_property): New forward static decl.
9840 * eval.c (Ffetch_bytecode): New forward static decl.
9841 (Funintern): Remove extern decl; now in .h file where it belongs.
9842 * fileio.c (Fmake_symbolic_link): New forward static decl.
9843 * image.c (Finit_image_library): New forward static decl.
9844 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9845 * intervals.h (Fprevious_property_change):
9846 (Fremove_list_of_text_properties): Remove decls.
9847 * keyboard.c (Fthis_command_keys): Remove decl.
9848 (Fcommand_execute): New forward static decl.
9849 * keymap.c (Flookup_key): New forward static decl.
9850 (Fcopy_keymap): Now static.
9851 * keymap.h (Flookup_key): Remove decl.
9852 * process.c (Fget_process): New forward static decl.
9853 (Fprocess_datagram_address): Mark as internal.
9854 * syntax.c (Fsyntax_table_p): New forward static decl.
9855 (skip_chars): Remove duplicate decl.
9856 * textprop.c (Fprevious_property_change): New forward static decl.
9857 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9859 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9860 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9862 * editfns.c (Fformat): Remove unreachable code.
9864 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9866 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9869 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9871 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9872 when at ZV. (Bug#8487)
9874 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9876 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9878 * keyboard.c (parse_tool_bar_item): Likewise.
9879 * sound.c (sound_cleanup, alsa_close): Likewise.
9880 * termcap.c (tgetent): Likewise.
9881 * xfns.c (x_default_font_parameter): Likewise.
9882 * xsettings.c (read_and_apply_settings): Likewise.
9884 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9885 (overrun_check_free): Protoize.
9887 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9889 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9890 since callers should never pass a negative size.
9891 Change the signature to match that of plain 'read' and 'write'; see
9892 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9893 * lisp.h: Update prototypes of emacs_write and emacs_read.
9895 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9897 * xdisp.c (redisplay_window): Don't try to determine the character
9898 position of the scroll margin if the window start point w->startp
9899 is outside the buffer's accessible region. (Bug#8468)
9901 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9903 Fix write-region and its subroutines for buffers > 2GB.
9904 * fileio.c (a_write, e_write): Modify declaration of arguments and
9905 local variables to support buffers larger than 2GB.
9906 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9908 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9909 argument, local variables, and return value.
9911 * lisp.h: Update prototypes of emacs_write and emacs_read.
9913 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9915 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9917 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9919 Fix more problems found by GCC 4.6.0's static checks.
9921 * xdisp.c (vmessage): Use a better test for character truncation.
9923 * charset.c (load_charset_map): <, not <=, for optimization,
9924 and to avoid potential problems with integer overflow.
9925 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9926 * casetab.c (set_identity, shuffle): Likewise.
9927 * editfns.c (Fformat): Likewise.
9928 * syntax.c (skip_chars): Likewise.
9930 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9931 This also lets GCC 4.6.0 generate slightly better loop code.
9933 * callint.c (Fcall_interactively): <, not <=, for optimization.
9934 (Fcall_interactively): Count the number of arguments produced,
9935 not the number of arguments given. This is simpler and lets GCC
9936 4.6.0 generate slightly better code.
9938 * ftfont.c: Distingish more carefully between FcChar8 and char.
9939 The previous code passed unsigned char * to a functions like
9940 strlen and xstrcasecmp that expect char *, which does not
9941 conform to the C standard.
9942 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9943 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9944 char * when the C standard requires it.
9946 * keyboard.c (read_char): Remove unused var.
9948 * eval.c: Port to Windows vsnprintf (Bug#8435).
9950 (SIZE_MAX): Define if the headers do not.
9951 (verror): Do not give up if vsnprintf returns a negative count.
9952 Instead, grow the buffer. This ports to Windows vsnprintf, which
9953 does not conform to C99. Problem reported by Eli Zaretskii.
9954 Also, simplify the allocation scheme, by avoiding the need for
9955 calling realloc, and removing the ALLOCATED variable.
9957 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9959 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9960 But keep the doprint source code for now, as we might revamp it
9961 and use it again (Bug#8435).
9962 * lisp.h (doprnt): Remove.
9963 * Makefile.in (base_obj): Remove doprnt.o.
9964 * deps.mk (doprnt.o): Remove.
9966 error: Print 32- and 64-bit integers portably (Bug#8435).
9967 Without this change, on typical 64-bit hosts error ("...%d...", N)
9968 was used to print both 32- and 64-bit integers N, which relied on
9970 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9971 * lisp.h (error, verror): Mark as printf-like functions.
9972 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9973 Report overflow in size calculations when allocating printf buffer.
9974 Do not truncate output string at its first null byte.
9975 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9976 Truncate the output at a character boundary, since vsnprintf does not
9978 * charset.c (check_iso_charset_parameter): Convert internal
9979 character to string before calling 'error', since %c now has the
9981 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9982 overflow when computing char to be passed to 'error'. Do not
9983 pass Lisp_Object to 'error'; pass the integer instead.
9984 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9985 formatted with plain %d.
9987 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9989 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9991 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9993 * xterm.c (x_catch_errors): Remove duplicate declaration.
9995 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9997 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9999 2011-04-10 Jim Meyering <meyering@redhat.com>
10001 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10002 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10003 return ssize_t not "int", and use size_t as the buffer length.
10004 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10005 * gnutls.h: Update declarations.
10006 * process.c (read_process_output): Use ssize_t, to match.
10007 (send_process): Likewise.
10009 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10011 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10013 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10015 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10016 Use unsigned char, to match FcChar8 type definition.
10018 * xterm.c (handle_one_xevent):
10019 * xmenu.c (create_and_show_popup_menu):
10020 * xselect.c (x_decline_selection_request)
10021 (x_reply_selection_request): Avoid type-punned deref of X events.
10023 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10025 Fix some uses of `int' instead of EMACS_INT.
10026 * search.c (string_match_1, fast_string_match)
10027 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10028 (scan_buffer, find_next_newline_no_quit)
10029 (find_before_next_newline, search_command, Freplace_match)
10030 (Fmatch_data): Make some `int' variables be EMACS_INT.
10032 * xdisp.c (display_count_lines): 3rd argument and return value now
10033 EMACS_INT. All callers changed.
10034 (pint2hrstr): Last argument is now EMACS_INT.
10036 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10037 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10038 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10039 (decode_coding_utf_16, decode_coding_emacs_mule)
10040 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10041 (decode_coding_ccl, decode_coding_charset)
10042 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10043 (decode_coding_iso_2022, decode_coding_emacs_mule)
10044 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10045 <char_offset, last_offset>: Declare EMACS_INT.
10046 (encode_coding_utf_8, encode_coding_utf_16)
10047 (encode_coding_emacs_mule, encode_invocation_designation)
10048 (encode_designation_at_bol, encode_coding_iso_2022)
10049 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10050 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10052 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10053 (encode_invocation_designation): Last argument P_NCHARS is now
10055 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10056 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10058 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10061 * ccl.c (Fccl_execute_on_string): Declare some variables
10064 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10066 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10068 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10070 * process.c (Fformat_network_address): Doc fix.
10072 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10074 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10076 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10078 * keyboard.c (read_char): Call Lisp function help-form-show,
10079 instead of using internal_with_output_to_temp_buffer.
10080 (Qhelp_form_show): New var.
10081 (syms_of_keyboard): Use DEFSYM macro.
10083 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10085 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10087 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10089 * process.c (Flist_processes): Remove to Lisp.
10090 (list_processes_1): Delete.
10092 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10094 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10096 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10098 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10100 Fix more problems found by GCC 4.6.0's static checks.
10102 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10104 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10106 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10108 * xdisp.c (vmessage): Mark as a printf-like function.
10110 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10112 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10114 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10115 printf-like functions.
10116 (tiff_load): Add casts to remove these marks before passing them
10117 to system-supplied API.
10119 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10121 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10122 This avoids several warnings with gcc -Wstrict-overflow.
10123 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10124 directly, rather than having caller test rule sign. This avoids
10125 some unnecessary tests.
10126 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10127 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10128 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10130 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10131 (xfont_open): Avoid unnecessary tests.
10133 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10135 * composite.h, composite.c (composition_gstring_put_cache):
10136 Use EMACS_INT, not int, for length.
10138 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10139 breaking out part of COMPOSITION_DECODE_RULE.
10140 (COMPOSITION_DECODE_RULE): Use it.
10141 * composite.c (get_composition_id): Remove unused local vars,
10142 by using the new macro.
10144 * textprop.c (set_text_properties_1): Change while to do-while,
10145 since the condition is always true at first.
10147 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10148 (interval_deletion_adjustment): Return unsigned value.
10151 * process.c (list_processes_1, create_pty, read_process_output):
10152 (exec_sentinel): Remove vars that were set but not used.
10153 (create_pty): Remove unnecessary "volatile"s.
10154 (Fnetwork_interface_info): Avoid possibility of int overflow.
10155 (read_process_output): Do adaptive read buffering even if carryover.
10156 (read_process_output): Simplify nbytes computation if buffered.
10158 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10160 * syntax.c (scan_words): Remove var that was set but not used.
10161 (update_syntax_table): Use unsigned instead of int.
10163 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10164 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10165 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10167 * print.c (print_error_message): Avoid int overflow.
10169 * font.c (font_list_entities): Redo for clarity,
10170 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10172 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10173 (font_score): Avoid potential overflow in diff calculation.
10175 * fns.c (substring_both): Remove var that is set but not used.
10176 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10178 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10180 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10181 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10182 can always succeed if overflow has undefined behavior.
10184 * search.c (boyer_moore, wordify): Remove vars set but not used.
10185 (wordify): Omit three unnecessary tests.
10187 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10188 All callers changed. This avoids the need for an unused var.
10190 * casefiddle.c (casify_region): Remove var that is set but not used.
10192 * dired.c (file_name_completion): Remove var that is set but not used.
10194 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10196 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10197 (Finsert_file_contents): Remove unnecessary code checking fd.
10199 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10200 Check for integer overflow on size calculations.
10202 * buffer.c (Fprevious_overlay_change): Remove var that is set
10205 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10206 Remove vars that are set but not used.
10207 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10208 (timer_check_2): Mark vars as initialized.
10210 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10212 * image.c (lookup_image): Remove var that is set but not used.
10213 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10215 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10216 that are set but not used.
10218 * xfns.c (make_invisible_cursor): Don't return garbage
10219 if XCreateBitmapFromData fails (Bug#8410).
10221 * xselect.c (x_get_local_selection, x_handle_property_notify):
10222 Remove vars that are set but not used.
10224 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10225 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10227 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10228 Remove var that is set but not used.
10229 (scroll_bar_windows_size): Now size_t, not int.
10230 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10231 Check for overflow.
10233 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10234 (map_tty_color) [!defined MSDOS]: Likewise.
10236 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10238 * coding.c: Remove vars that are set but not used.
10239 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10240 All callers changed.
10241 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10242 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10243 (decode_coding_charset): Remove vars that are set but not used.
10245 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10246 that is set but not used.
10248 * print.c (print_object): Remove var that is set but not used.
10250 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10251 The gnulib version avoids calling malloc in the usual case,
10252 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10253 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10254 * filelock.c (current_lock_owner): Likewise.
10255 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10256 * sysdep.c: Include allocator.h, careadlinkat.h.
10257 (emacs_no_realloc_allocator): New static constant.
10258 (emacs_readlink): New function.
10259 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10260 ../lib/careadlinkat.h.
10262 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10264 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10265 first non-nil return value).
10267 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10269 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10270 if not defined (Bug#8403).
10272 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10274 * xdisp.c (display_count_lines): Remove parameter `start',
10275 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10276 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10277 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10278 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10279 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10280 and thereabouts. All callers changed.
10281 (get_per_char_metric): Remove parameter `f', unused since
10282 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10284 2011-04-02 Jim Meyering <meyering@redhat.com>
10286 do not dereference NULL upon failed strdup
10287 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10288 (ns_get_family): Likewise.
10290 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10292 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10294 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10296 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10299 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10301 Add lexical binding.
10303 * window.c (Ftemp_output_buffer_show): New fun.
10304 (Fsave_window_excursion):
10305 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10307 * lread.c (lisp_file_lexically_bound_p): New function.
10308 (Fload): Bind Qlexical_binding.
10309 (readevalloop): Remove `evalfun' arg.
10310 Bind Qinternal_interpreter_environment.
10311 (Feval_buffer): Bind Qlexical_binding.
10312 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10314 (syms_of_lread): Declare `lexical-binding'.
10316 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10318 * keyboard.c (eval_dyn): New fun.
10319 (menu_item_eval_property): Use it.
10321 * image.c (parse_image_spec): Use Ffunctionp.
10323 * fns.c (concat, mapcar1): Accept byte-code-functions.
10325 * eval.c (Fsetq): Handle lexical vars.
10326 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10327 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10328 (FletX, Flet): Obey lexical binding.
10329 (Fcommandp): Handle closures.
10330 (Feval): New `lexical' arg.
10331 (eval_sub): New function extracted from Feval. Use it almost
10332 everywhere where Feval was used. Look up vars in lexical env.
10334 (Ffunctionp): Move from subr.el.
10335 (Ffuncall): Handle closures.
10336 (apply_lambda): Remove `eval_flags'.
10337 (funcall_lambda): Handle closures and new byte-code-functions.
10338 (Fspecial_variable_p): New function.
10339 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10340 but without exporting it to Lisp.
10342 * doc.c (Fdocumentation, store_function_docstring):
10343 * data.c (Finteractive_form): Handle closures.
10345 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10348 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10350 (exec_byte_code): New function extracted from Fbyte_code to handle new
10351 calling convention for byte-code-functions. Add new byte-codes.
10353 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10355 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10357 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10359 * xdisp.c (redisplay_internal): Fix prototype.
10361 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10363 * xdisp.c (SCROLL_LIMIT): New macro.
10364 (try_scrolling): Use it when setting scroll_limit.
10365 Limit scrolling to 100 screen lines.
10366 (redisplay_window): Even when falling back on "recentering",
10367 position point in the window according to scroll-conservatively,
10368 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10370 (try_scrolling): When point is above the window, allow searching
10371 as far as scroll_max, or one screenful, to compute vertical
10372 distance from PT to the scroll margin position. This prevents
10373 try_scrolling from unnecessarily failing when
10374 scroll-conservatively is set to a value slightly larger than the
10375 window height. Clean up the case of PT below the margin at bottom
10376 of window: scroll_max can no longer be INT_MAX. When aggressive
10377 scrolling is in use, don't let point enter the opposite scroll
10378 margin as result of the scroll.
10379 (syms_of_xdisp) <scroll-conservatively>: Document the
10380 threshold of 100 lines for never-recentering scrolling.
10382 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10384 * dispextern.h (move_it_by_lines):
10385 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10386 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10387 (message_log_check_duplicate): Remove parameters `prev_bol' and
10388 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10389 (redisplay_internal): Remove parameter `preserve_echo_area',
10390 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10392 * indent.c (Fvertical_motion):
10393 * window.c (window_scroll_pixel_based, Frecenter):
10394 Don't pass `need_y_p' to `move_it_by_lines'.
10396 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10398 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10399 steal a few bits to be more compact.
10400 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10401 Remove unneeded casts.
10403 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10405 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10407 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10408 binding" message (bug#7967).
10410 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10412 Fix more problems found by GCC 4.6.0's static checks.
10414 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10415 Remove unused local var.
10417 * editfns.c (Fmessage_box): Remove unused local var.
10419 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10420 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10421 Omit unused local vars.
10422 * window.c (shrink_windows): Omit unused local var.
10423 * menu.c (digest_single_submenu): Omit unused local var.
10424 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10425 Omit unused local var.
10427 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10428 Don't assume string length fits in int.
10429 (keyremap_step, read_key_sequence): Use size_t for sizes.
10430 (read_key_sequence): Don't check last_real_key_start redundantly.
10432 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10433 instead of alloca (Bug#8344).
10435 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10436 (Fbacktrace_frame): Don't assume nframes fits in int.
10438 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10440 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10443 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10445 * cm.c (calccost): Turn while-do into do-while, for clarity.
10447 * keyboard.c (syms_of_keyboard): Use the same style as later
10448 in this function when indexing through an array. This also
10449 works around GCC bug 48267.
10451 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10453 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10455 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10456 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10458 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10459 This avoids undefined behavior on integer overflow, and is a bit
10460 more convenient anyway since it is compared to a size_t variable.
10462 Variadic C functions now count arguments with size_t, not int.
10463 This avoids an unnecessary limitation on 64-bit machines, which
10464 caused (substring ...) to crash on large vectors (Bug#8344).
10465 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10466 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10467 All variadic functions and their callers changed accordingly.
10468 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10469 * data.c (arith_driver, float_arith_driver): Likewise.
10470 * editfns.c (general_insert_function): Likewise.
10471 * eval.c (struct backtrace.nargs, interactive_p)
10472 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10473 (funcall_lambda, mark_backtrace): Likewise.
10474 * fns.c (concat): Likewise.
10475 * frame.c (x_set_frame_parameters): Likewise.
10476 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10477 0 if not found, not -1. All callers changed.
10479 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10480 (stack_copy_size): Now size_t, not int.
10481 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10483 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10485 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10486 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10487 All callers changed.
10489 * lisp.h (multibyte_char_to_unibyte):
10490 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10491 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10492 * character.h (CHAR_TO_BYTE8):
10493 * cmds.c (internal_self_insert):
10494 * editfns.c (general_insert_function):
10495 * keymap.c (push_key_description):
10496 * search.c (Freplace_match):
10497 * xdisp.c (message_dolog, set_message_1): All callers changed.
10499 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10501 * keyboard.c (safe_run_hook_funcall): New function.
10502 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10503 don't set the hook to nil, but remove the offending function instead.
10504 (Qcommand_hook_internal): Remove, unused.
10505 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10506 Vcommand_hook_internal.
10508 * eval.c (enum run_hooks_condition): Remove.
10509 (funcall_nil, funcall_not): New functions.
10510 (run_hook_with_args): Call each function through a `funcall' argument.
10511 Remove `cond' argument, now redundant.
10512 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10513 (Frun_hook_with_args_until_failure): Adjust accordingly.
10514 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10516 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10518 * dispextern.h (string_buffer_position): Remove declaration.
10520 * print.c (strout): Remove parameter `multibyte', unused since
10521 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10523 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10524 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10525 All callers changed.
10527 * w32.c (_wsa_errlist): Use braces for struct initializers.
10529 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10530 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10531 All callers changed.
10532 (string_buffer_position): Likewise. Also, make static (it's never
10533 used outside xdisp.c).
10534 (cursor_row_p): Remove parameter `w', unused since
10535 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10536 (decode_mode_spec): Remove parameter `precision', introduced during
10537 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10538 All callers changed.
10540 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10542 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10544 2011-03-27 Anders Lindgren <andlind@gmail.com>
10546 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10547 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10548 (ns_update_auto_hide_menu_bar): New functions.
10549 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10550 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10551 ns_constrain_all_frames.
10552 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10553 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10555 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10557 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10559 2011-03-27 Glenn Morris <rgm@gnu.org>
10561 * syssignal.h: Replace RETSIGTYPE with void.
10562 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10563 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10564 Replace SIGTYPE with void everywhere.
10565 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10566 * s/template.h (SIGTYPE): Remove commented out definition.
10568 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10570 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10571 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10573 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10575 * w32.c (read_unc_volume): Use parameter `henum', instead of
10576 global variable `wget_enum_handle'.
10578 * keymap.c (describe_vector): Remove parameters `indices' and
10579 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10580 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10582 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10584 * keyboard.c (timer_check): Remove parameter `do_it_now',
10585 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10586 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10587 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10589 * keyboard.c (read_char):
10590 * w32menu.c (w32_menu_display_help):
10591 * xmenu.c (show_help_event, menu_help_callback):
10592 Adjust calls to `show_help_echo'.
10594 * gtkutil.c (xg_maybe_add_timer):
10595 * keyboard.c (readable_events):
10596 * process.c (wait_reading_process_output):
10597 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10599 * insdel.c (adjust_markers_gap_motion):
10600 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10601 (gap_left, gap_right): Don't call it.
10603 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10605 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10606 incurred during fontification.
10608 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10610 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10611 (DEFVAR_PER_BUFFER): Don't pass it.
10613 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10614 (scrolling_window): Don't pass it.
10616 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10618 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10620 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10622 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10623 of variables specific to SELinux and computation of `encoded_absname'.
10625 * image.c (XPutPixel): Remove unused variable `height'.
10627 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10629 * unexw32.c (get_section_info): Remove unused variable `section'.
10631 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10632 (system_process_attributes): Remove unused variable `sess'.
10633 (sys_read): Remove unused variable `err'.
10635 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10636 (w32_wnd_proc): Remove unused variable `isdead'.
10637 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10638 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10639 (x_create_tip_frame): Remove unused variable `tem'.
10641 * w32inevt.c (w32_console_read_socket):
10642 Remove unused variable `no_events'.
10644 * w32term.c (x_draw_composite_glyph_string_foreground):
10645 Remove unused variable `width'.
10647 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10649 * w32term.c (x_set_glyph_string_clipping):
10650 Don't pass uninitialized region to CombineRgn.
10652 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10654 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10655 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10656 (Fx_close_connection): Remove unused variable `i'.
10658 * w32font.c (w32font_draw): Return number of glyphs.
10659 (w32font_open_internal): Remove unused variable `i'.
10660 (w32font_driver): Add missing initializer.
10662 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10663 (fill_in_menu): Remove unused variable `items_added'.
10665 * w32term.c (last_mouse_press_frame): Remove static global variable.
10666 (w32_clip_to_row): Remove unused variable `f'.
10667 (x_delete_terminal): Remove unused variable `i'.
10669 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10670 (NOTHING): Remove unused static global variable.
10671 (uniscribe_check_otf): Remove unused variable `table'.
10672 (uniscribe_font_driver): Add missing initializers.
10674 2011-03-23 Julien Danjou <julien@danjou.info>
10676 * term.c (Fsuspend_tty, Fresume_tty):
10677 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10678 * window.c (temp_output_buffer_show):
10679 * insdel.c (signal_before_change):
10680 * frame.c (Fhandle_switch_frame):
10681 * fileio.c (Fdo_auto_save):
10682 * emacs.c (Fkill_emacs):
10683 * editfns.c (save_excursion_restore):
10684 * cmds.c (internal_self_insert):
10685 * callint.c (Fcall_interactively):
10686 * buffer.c (Fkill_all_local_variables):
10687 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10689 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10690 unconditionally since it does the check itself.
10692 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10694 Fix more problems found by GCC 4.5.2's static checks.
10696 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10697 the first time through the loop, since we know p0 < p1 then.
10698 This also avoids a gcc -Wstrict-overflow warning.
10700 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10701 leading to a memory leak, possible in functions like
10702 load_charset_map_from_file that can allocate an unbounded number
10703 of objects (Bug#8318).
10705 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10706 that could (at least in theory) be that large.
10708 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10709 This is less likely to overflow, and avoids undefined behavior if
10710 overflow does occur. All callers changed. Use strtoul to scan
10711 for the unsigned long integer.
10712 (pint2hrstr): Simplify and tune code slightly.
10713 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10715 * scroll.c (do_scrolling): Work around GCC bug 48228.
10716 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10718 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10719 This also avoids a warning with gcc -Wstrict-overflow.
10720 (validate_x_resource_name): Simplify count usage.
10721 This also avoids a warning with gcc -Wstrict-overflow.
10723 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10726 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10728 * process.c (Fmake_network_process): Use socklen_t, not int,
10729 where POSIX says socklen_t is required in portable programs.
10730 This fixes a porting bug on hosts like 64-bit HP-UX, where
10731 socklen_t is wider than int (Bug#8277).
10732 (Fmake_network_process, server_accept_connection):
10733 (wait_reading_process_output, read_process_output):
10736 * process.c: Rename or move locals to avoid shadowing.
10737 (list_processes_1, Fmake_network_process):
10738 (read_process_output_error_handler, exec_sentinel_error_handler):
10739 Rename or move locals.
10740 (Fmake_network_process): Define label "retry_connect" only if needed.
10741 (Fnetwork_interface_info): Fix pointer signedness.
10742 (process_send_signal): Add cast to avoid pointer signedness problem.
10743 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10744 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10746 Make tparam.h and terminfo.c consistent.
10747 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10748 Include tparam.h instead, since it declares them.
10749 * cm.h (PC): Remove extern decl; tparam.h now does this.
10750 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10751 * terminfo.c: Include tparam.h, to check interfaces.
10752 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10753 (tparam): Adjust signature to match interface in tparam.h;
10754 this removes some undefined behavior. Check that outstring and len
10755 are zero, which they always are with Emacs.
10756 * tparam.h (PC, BC, UP): New extern decls.
10758 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10759 (xftfont_open): Rename locals to avoid shadowing.
10761 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10762 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10763 (OTF_TAG_SYM): Omit macro if not needed.
10764 (ftfont_list): Remove unused local.
10765 (get_adstyle_property, ftfont_pattern_entity):
10766 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10767 Rename locals to avoid shadowing.
10769 * xfont.c (xfont_list_family): Mark var as initialized.
10771 * xml.c (make_dom): Now static.
10773 * composite.c (composition_compute_stop_pos): Rename local to
10775 (composition_reseat_it): Remove unused locals.
10776 (find_automatic_composition, composition_adjust_point): Likewise.
10777 (composition_update_it): Mark var as initialized.
10778 (find_automatic_composition): Mark vars as initialized,
10779 with a FIXME (Bug#8290).
10781 character.h: Rename locals to avoid shadowing.
10782 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10783 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10784 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10785 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10786 to avoid shadowing.
10788 * textprop.c (property_change_between_p): Remove; unused.
10790 * intervals.c (interval_start_pos): Now static.
10792 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10794 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10795 Rename locals to avoid shadowing.
10797 * sound.c (wav_play, au_play, Fplay_sound_internal):
10798 Fix pointer signedness.
10799 (alsa_choose_format): Remove unused local var.
10800 (wav_play): Initialize a variable to 0, to prevent undefined
10801 behavior (Bug#8278).
10803 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10805 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10807 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10808 clobbering (Bug#8298).
10809 * sysdep.c (sys_subshell): Likewise.
10810 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10812 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10813 This should get cleaned up, so that child_setup has the
10814 same signature on all platforms.
10816 * callproc.c (call_process_cleanup): Now static.
10817 (relocate_fd): Rename locals to avoid shadowing.
10819 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10821 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10822 not to be necessary, and produces flickering.
10824 2011-03-20 Glenn Morris <rgm@gnu.org>
10826 * config.in: Remove file.
10828 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10830 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10831 are now in src/globals.h.
10832 (syms_of_minibuf): Remove spurious & from previous change.
10834 2011-03-20 Leo Liu <sdl.web@gmail.com>
10836 * minibuf.c (completing-read-function): New variable.
10837 (completing-read-default): Rename from completing-read.
10838 (completing-read): Call completing-read-function.
10840 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10842 * xfaces.c (Fx_load_color_file):
10843 Read color file from absolute filename (bug#8250).
10845 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10847 * makefile.w32-in: Update dependencies.
10849 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10851 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10853 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10855 Fix more problems found by GCC 4.5.2's static checks.
10857 * process.c (make_serial_process_unwind, send_process_trap):
10858 (sigchld_handler): Now static.
10860 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10861 That way, the code declares only the vars that it needs.
10862 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10863 * s/cygwin.h (PTY_ITERATION): Likewise.
10864 * s/darwin.h (PTY_ITERATION): Likewise.
10865 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10867 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10868 * process.c (allocate_pty): Don't declare stb unless it's needed.
10870 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10871 (CONSTANTLIM): Remove; unused.
10872 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10873 Define only if needed.
10875 * unexelf.c (unexec): Name an expression,
10876 to avoid gcc -Wbad-function-cast warning.
10877 Use a different way to cause a compilation error if anyone uses
10878 n rather than nn, a way that does not involve shadowing.
10879 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10881 * deps.mk (unexalpha.o): Remove; unused.
10883 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10884 * unexec.h: New file.
10885 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10886 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10887 Depend on unexec.h.
10888 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10889 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10890 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10891 Change as necessary to match prototype in unexec.h.
10893 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10895 (back_comment, skip_chars): Mark vars as initialized.
10897 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10898 Rename locals to avoid shadowing.
10900 * lread.c (read1): Rewrite so as not to use empty "else".
10901 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10903 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10905 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10906 warning when compiling print.c.
10908 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10909 instead of using an uninitialized var.
10910 (font_sort_entities): Mark var as initialized.
10912 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10914 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10915 pointers to constants.
10916 (font_parse_fcname): Remove unused vars.
10917 (font_delete_unmatched): Now static.
10918 (font_get_spec): Remove; unused.
10919 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10920 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10921 Rename or move locals to avoid shadowing.
10923 * fns.c (require_nesting_list, require_unwind): Now static.
10924 (Ffillarray): Rename locals to avoid shadowing.
10926 * floatfns.c (domain_error2): Define only if needed.
10927 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10929 * alloc.c (mark_backtrace): Move decl from here ...
10930 * lisp.h: ... to here, so that it can be checked.
10932 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10933 (Fdefvar): Rewrite so as not to use empty "else".
10934 (lisp_indirect_variable): Name an expression,
10935 to avoid gcc -Wbad-function-cast warning.
10936 (Fdefvar): Rename locals to avoid shadowing.
10938 * callint.c (quotify_arg, quotify_args): Now static.
10939 (Fcall_interactively): Rename locals to avoid shadowing.
10940 Use const pointer when appropriate.
10942 * lisp.h (get_system_name, get_operating_system_release):
10943 Move decls here, to check interfaces.
10944 * process.c (get_operating_system_release): Move decl to lisp.h.
10945 * xrdb.c (get_system_name): Likewise.
10946 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10947 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10948 some of which prompt warnings from gcc -Wbad-function-cast.
10949 (Fformat_time_string, Fencode_time, Finsert_char):
10950 (Ftranslate_region_internal, Fformat):
10951 Rename or remove local vars to avoid shadowing.
10952 (Ftranslate_region_internal): Mark var as initialized.
10954 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10957 * lisp.h (eassert): Check that the argument compiles, even if
10958 ENABLE_CHECKING is not defined.
10960 * data.c (Findirect_variable): Name an expression, to avoid
10961 gcc -Wbad-function-cast warning.
10962 (default_value, arithcompare, arith_driver, arith_error): Now static.
10963 (store_symval_forwarding): Rename local to avoid shadowing.
10964 (Fmake_variable_buffer_local, Fmake_local_variable):
10965 Mark variables as initialized.
10966 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10968 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10969 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10970 Rename locals to avoid shadowing.
10971 (mark_stack): Move local variables into the #ifdef region where
10973 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10974 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10976 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10977 (GC_STRING_CHARS): Remove; not used.
10978 (Fmemory_limit): Cast sbrk's returned value to char *.
10980 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10981 avoids undefined behavior in theory.
10983 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10985 Use functions, not macros, for up- and down-casing (Bug#8254).
10986 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10987 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10988 to use the following functions instead of these macros.
10989 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10990 EMACS_INT, since callers assume the returned value fits in int.
10991 (upcase1): Likewise, for UPCASE_TABLE.
10992 (uppercasep, lowercasep, upcase): New static inline functions.
10993 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10994 the race-condition problem in the old DOWNCASE.
10996 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10997 Rename locals to avoid shadowing.
10998 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10999 (regex_compile, re_search_2, re_match_2_internal):
11000 Remove unused local vars.
11001 (FREE_VAR): Rewrite so as not to use empty "else",
11002 which gcc can warn about.
11003 (regex_compile, re_match_2_internal): Mark locals as initialized.
11004 (RETALLOC_IF): Define only if needed.
11005 (WORDCHAR_P): Likewise. This one is never needed, but is used
11006 only in a comment talking about a compiler bug, so put inside
11007 the #if 0 of that comment.
11008 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11009 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11012 * search.c (boyer_moore): Rename locals to avoid shadowing.
11013 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11014 (PREV_CHAR_BOUNDARY): Likewise.
11016 * search.c (simple_search): Remove unused var.
11018 * dired.c (compile_pattern): Move decl from here ...
11019 * lisp.h: ... to here, so that it can be checked.
11020 (struct re_registers): New forward decl.
11022 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11024 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11026 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11027 Rename locals to avoid shadowing.
11028 (Fvertical_motion): Mark locals as initialized.
11030 * casefiddle.c (casify_object, casify_region): Now static.
11031 (casify_region): Mark local as initialized.
11033 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11035 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11036 New macros, so that the caller can use some names other than
11037 gcpro1, gcpro2, etc.
11038 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11040 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11041 argument, for consistency with GCPRO2_VAR, etc: it is now the
11042 prefix of the variable, not the variable itself. All uses
11044 * dired.c (directory_files_internal, file_name_completion):
11045 Rename locals to avoid shadowing.
11047 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11048 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11049 dired.c's scmp function, had undefined behavior.
11050 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11051 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11052 * buffer.h: ... to here, because these macros use current_buffer,
11053 and the new implementation with inline functions needs to have
11054 current_buffer in scope now, rather than later when the macros
11056 (downcase, upcase1): New static inline functions.
11057 (DOWNCASE, UPCASE1): Reimplement using these functions.
11058 This avoids undefined behavior in expressions like
11059 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11060 from race conditions in accessing the global variables
11061 case_temp1 and case_temp2.
11062 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11063 * lisp.h (case_temp1, case_temp2): Remove their decls.
11064 * character.h (ASCII_CHAR_P): Move from here ...
11065 * lisp.h: ... to here, so that the inline functions mentioned
11066 above can use them.
11068 * dired.c (directory_files_internal_unwind): Now static.
11070 * fileio.c (file_name_as_directory, directory_file_name):
11071 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11073 (file_name_as_directory): Use const pointers when appropriate.
11074 (Fexpand_file_name): Likewise. In particular, newdir might
11075 point at constant storage, so make it a const pointer.
11076 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11077 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11079 (Fset_file_times, Finsert_file_contents, auto_save_error):
11080 Rename locals to avoid shadowing.
11082 * minibuf.c (choose_minibuf_frame_1): Now static.
11083 (Ftry_completion, Fall_completions): Rename or remove locals
11084 to avoid shadowing.
11086 * marker.c (bytepos_to_charpos): Remove; unused.
11088 * lisp.h (verify_bytepos, count_markers): New decls,
11089 so that gcc does not warn that these functions aren't declared.
11091 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11092 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11093 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11094 (copy_text): Remove unused local var.
11096 * filelock.c (within_one_second): Now static.
11097 (lock_file_1): Rename local to avoid shadowing.
11099 * buffer.c (fix_overlays_before): Mark locals as initialized.
11100 (fix_start_end_in_overlays): Likewise. This function should be
11101 simplified by using pointers-to-pointers, but that's a different
11103 (switch_to_buffer_1): Now static.
11104 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11105 (report_overlay_modification): Rename locals to avoid shadowing.
11107 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11108 Fix pointer signedness issue.
11109 (sys_subshell): Mark local as volatile if checking for lint,
11110 to suppress a gcc -Wclobbered warning that does not seem to be right.
11111 (MAXPATHLEN): Define only if needed.
11113 * process.c (serial_open, serial_configure): Move decls from here ...
11114 * systty.h: ... to here, so that they can be checked.
11116 * fns.c (get_random, seed_random): Move extern decls from here ...
11117 * lisp.h: ... to here, so that they can be checked.
11119 * sysdep.c (reset_io): Now static.
11120 (wait_for_termination_signal): Remove; unused.
11122 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11123 (copy_keymap_item, append_key, push_text_char_description):
11125 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11126 (DENSE_TABLE_SIZE): Remove; unused.
11127 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11128 (describe_map_tree):
11129 Rename locals to avoid shadowing.
11131 * keyboard.c: Declare functions static if they are not used elsewhere.
11132 (echo_char, echo_dash, cmd_error, top_level_2):
11133 (poll_for_input, handle_async_input): Now static.
11134 (read_char, kbd_buffer_get_event, make_lispy_position):
11135 (make_lispy_event, make_lispy_movement, apply_modifiers):
11136 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11137 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11138 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11139 (read_key_sequence, read_char): Mark locals as initialized.
11140 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11142 * keyboard.h (make_ctrl_char): New decl.
11143 (mark_kboards): Move decl here ...
11144 * alloc.c (mark_kboards): ... from here.
11146 * lisp.h (force_auto_save_soon): New decl.
11148 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11149 (DEFINE_DUMMY_FUNCTION): New macro.
11150 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11152 (main): Add casts to avoid warnings
11153 if GCC considers string literals to be constants.
11155 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11157 * dbusbind.c: Pointer signedness fixes.
11158 (xd_signature, xd_append_arg, xd_initialize):
11159 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11160 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11161 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11162 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11164 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11165 if GCC considers string literals to be constants.
11166 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11168 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11170 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11171 (print_preprocess, print_object): New macro to fix last change.
11173 * print.c (print_preprocess): Don't forget font objects.
11175 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11177 * emacs.c (USAGE3): Doc fixes.
11179 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11181 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11184 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11186 * lisp.h (VWindow_system, Qfile_name_history):
11187 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11188 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11189 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11191 * w32select.c: Don't #include "keyboard.h".
11192 (run_protected): Add extern declaration for waiting_for_input.
11194 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11195 * w32console.c (detect_input_pending, read_input_pending)
11196 (encode_terminal_code):
11197 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11198 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11199 (w32_system_caret_y, Qfile_name_history):
11200 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11201 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11202 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11203 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11204 * w32proc.c (Qlocal, report_file_error):
11205 * w32term.c (Vwindow_system, updating_frame):
11206 * w32uniscribe.c (initialized, uniscribe_font_driver):
11207 Remove unneeded extern declarations.
11209 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11211 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11213 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11215 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11216 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11217 These macros can no longer be used for assignment.
11219 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11220 Assign struct members directly, instead of using BUF_BEGV etc.
11221 (record_buffer_markers, fetch_buffer_markers): New functions for
11222 recording and fetching special buffer markers.
11223 (set_buffer_internal_1, set_buffer_temp): Use them.
11225 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11227 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11229 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11230 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11232 * xdisp.c (hscroll_window_tree):
11233 (reconsider_clip_changes): Use PT instead of BUF_PT.
11235 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11237 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11238 $(EMACS_ROOT)/lib/intprops.h.
11240 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11242 Fix more problems found by GCC 4.5.2's static checks.
11244 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11245 to unsigned char * to avoid compiler diagnostic.
11246 (xg_free_frame_widgets): Make it clear that a local variable is
11247 needed only if USE_GTK_TOOLTIP.
11248 (gdk_window_get_screen): Make it clear that this macro is needed
11249 only if USE_GTK_TOOLTIP.
11250 (int_gtk_range_get_value): New function, which avoids a diagnostic
11251 from gcc -Wbad-function-cast.
11252 (xg_set_toolkit_scroll_bar_thumb): Use it.
11253 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11254 diagnostic from gcc -Wbad-function-cast.
11255 (get_utf8_string, xg_get_file_with_chooser):
11256 Rename locals to avoid shadowing.
11257 (create_dialog): Move locals to avoid shadowing.
11259 * xgselect.c (xg_select): Remove unused var.
11261 * image.c (four_corners_best): Mark locals as initialized.
11262 (gif_load): Initialize transparent_p to zero (Bug#8238).
11263 Mark another local as initialized.
11264 (my_png_error, my_error_exit): Mark with NO_RETURN.
11266 * image.c (clear_image_cache): Now static.
11267 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11268 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11269 (x_edge_detection): Remove unnecessary cast that
11270 gcc -Wbad-function-cast diagnoses.
11271 (gif_load): Fix pointer signedness.
11272 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11273 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11275 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11277 Improve quality of tests for time stamp overflow.
11278 For example, without this patch (encode-time 0 0 0 1 1
11279 1152921504606846976) returns the obviously-bogus value (-948597
11280 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11281 reports time overflow. See
11282 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11283 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11284 * editfns.c: Include limits.h and intprops.h.
11285 (TIME_T_MIN, TIME_T_MAX): New macros.
11286 (time_overflow): Move earlier, to before first use.
11287 (hi_time, lo_time): New functions, for an accurate test for
11288 out-of-range times.
11289 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11290 (Fget_internal_run_time): Don't assume time_t fits in int.
11291 (make_time): Use list2 instead of Fcons twice.
11292 (Fdecode_time): More accurate test for out-of-range times.
11293 (check_tm_member): New function.
11294 (Fencode_time): Use it, to test for out-of-range times.
11295 (lisp_time_argument): Don't rely on undefined left-shift and
11296 right-shift behavior when checking for time stamp overflow.
11298 * editfns.c (time_overflow): New function, refactoring common code.
11299 (Fformat_time_string, Fdecode_time, Fencode_time):
11300 (Fcurrent_time_string): Use it.
11302 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11303 * dired.c (make_time): Move to ...
11304 * editfns.c (make_time): ... here.
11305 * systime.h: Note the move.
11307 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11309 * fringe.c (update_window_fringes): Remove unused variables.
11311 * unexmacosx.c (copy_data_segment): Also copy __got section.
11314 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11316 * termcap.c [MSDOS]: Include "msdos.h".
11317 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11318 Constify `char *' arguments and their references according to
11319 prototypes in tparam.h.
11321 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11323 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11324 Adapt all references accordingly.
11326 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11328 2011-03-11 Tom Tromey <tromey@redhat.com>
11330 * buffer.c (syms_of_buffer): Remove obsolete comment.
11332 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11334 * termhooks.h (encode_terminal_code): Declare prototype.
11336 * msdos.c (encode_terminal_code): Don't declare prototype.
11338 * term.c (encode_terminal_code): Now external again, used by
11339 w32console.c and msdos.c.
11341 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11342 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11344 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11346 Fix some minor problems found by GCC 4.5.2's static checks.
11348 * fringe.c (update_window_fringes): Mark locals as initialized
11350 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11352 * alloc.c (mark_fringe_data): Move decl from here ...
11353 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11354 to check its interface.
11355 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11357 * fontset.c (free_realized_fontset): Now static.
11358 (Fset_fontset_font): Rename local to avoid shadowing.
11359 (fontset_font): Mark local as initialized.
11360 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11362 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11364 * xselect.c (x_disown_buffer_selections): Remove; not used.
11365 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11366 (x_own_selection, Fx_disown_selection_internal): Rename locals
11367 to avoid shadowing.
11368 (x_handle_dnd_message): Remove local to avoid shadowing.
11370 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11371 so that the caller can use some name other than gcpro1.
11372 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11373 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11374 (Fx_backspace_delete_keys_p):
11375 Use them to avoid shadowing, and rename vars to avoid shadowing.
11376 (x_decode_color, x_set_name, x_window): Now static.
11377 (Fx_create_frame): Add braces to silence GCC warning.
11378 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11379 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11380 Remove unused locals.
11381 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11382 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11383 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11386 * xterm.h (x_mouse_leave): New decl.
11388 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11389 Remove unused functions.
11390 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11391 (x_calc_absolute_position): Now static.
11392 (XTread_socket): Don't define label "out" unless it's used.
11393 Don't declare local "event" unless it's used.
11394 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11395 unless they are used.
11396 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11397 (x_fatal_error_signal): Remove; not used.
11398 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11399 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11400 (x_error_catcher, x_connection_closed, x_error_handler):
11401 (x_error_quitter, xembed_send_message, x_iconify_frame):
11402 (my_log_handler): Rename locals to avoid shadowing.
11403 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11404 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11406 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11407 Rename or move locals to avoid shadowing.
11408 (tty_defined_color, merge_face_heights): Now static.
11409 (free_realized_faces_for_fontset): Remove; not used.
11410 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11411 does not deduce is never used uninitialized.
11412 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11413 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11415 * terminal.c (store_terminal_param): Now static.
11417 * xmenu.c (menu_highlight_callback): Now static.
11418 (set_frame_menubar): Remove unused local.
11419 (xmenu_show): Rename parameter to avoid shadowing.
11420 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11421 since they might point to immutable storage.
11422 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11423 since it's unused otherwise.
11425 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11426 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11427 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11428 avoids a gcc -Wuninitialized diagnostic.
11429 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11430 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11431 does not deduce are never used uninitialized.
11433 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11435 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11436 * window.c (window_loop, size_window):
11437 (run_window_configuration_change_hook, enlarge_window): Likewise.
11439 * window.c (display_buffer): Now static.
11440 (size_window): Mark variables that gcc -Wuninitialized
11441 does not deduce are never used uninitialized.
11442 * window.h (check_all_windows): New decl, to forestall
11443 gcc -Wmissing-prototypes diagnostic.
11444 * dispextern.h (bidi_dump_cached_states): Likewise.
11446 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11448 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11449 Include <limits.h>.
11450 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11451 and to avoid gcc -Wuninitialized warning.
11452 (load_charset_map): Mark variables that gcc -Wuninitialized
11453 does not deduce are never used uninitialized.
11454 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11456 * coding.c (coding_set_source, coding_set_destination):
11457 Use "else { /* comment */ }" rather than "else /* comment */;"
11458 for clarity, and to avoid gcc -Wempty-body warning.
11459 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11460 a block, when the outer 'i' will do.
11461 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11462 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11463 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11464 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11465 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11466 Rename locals to avoid shadowing.
11467 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11468 * coding.c (emacs_mule_char, encode_invocation_designation):
11469 Now static, since they're not used elsewhere.
11470 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11471 (decode_coding_object, encode_coding_object, detect_coding_system):
11472 (decode_coding_emacs_mule): Mark variables that gcc
11473 -Wuninitialized does not deduce are never used uninitialized.
11474 (detect_coding_iso_2022): Initialize a local variable that might
11475 be used uninitialized. Leave a FIXME because it's not clear that
11476 this initialization is needed. (Bug#8211)
11477 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11478 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11479 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11480 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11481 Remove unused macros.
11483 * category.c (hash_get_category_set): Remove unused local var.
11484 (copy_category_table): Now static, since it's not used elsewhere.
11485 * character.c (string_count_byte8): Likewise.
11487 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11488 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11490 * chartab.c (copy_sub_char_table): Now static, since it's not used
11492 (sub_char_table_ref_and_range, char_table_ref_and_range):
11493 Rename locals to avoid shadowing.
11494 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11496 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11497 (BIDI_BOB): Remove unused macro.
11499 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11500 deduce are never used uninitialized.
11501 * term.c (encode_terminal_code): Likewise.
11503 * term.c (encode_terminal_code): Now static. Remove unused local.
11505 * tparam.h: New file.
11506 * term.c, tparam.h: Include it.
11507 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11508 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11509 Move these decls to tparam.h, and make them agree with what
11510 is actually in tparam.c. The previous trick of using incompatible
11511 decls in different modules does not conform to the C standard.
11512 All callers of tparam changed to use tparam's actual API.
11513 * tparam.c (tparam1, tparam, tgoto):
11514 Use const pointers where appropriate.
11516 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11517 * cm.h (struct cm): Likewise.
11518 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11519 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11520 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11521 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11522 (turn_on_face, init_tty): Likewise.
11523 * termchar.h (struct tty_display_info): Likewise.
11525 * term.c (term_mouse_position): Rename local to avoid shadowing.
11527 * alloc.c (mark_ttys): Move decl from here ...
11528 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11530 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11532 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11534 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11536 * search.c (compile_pattern_1): Remove argument regp, unused since
11537 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11538 (compile_pattern): Don't pass it.
11540 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11542 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11543 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11545 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11547 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11549 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11550 gdk_window_get_screen, gdk_window_get_geometry,
11551 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11552 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11553 (xg_get_pixbuf_from_pixmap): New function.
11554 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11555 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11556 Call xg_get_pixbuf_from_pixmap instead of
11557 gdk_pixbuf_get_from_drawable.
11558 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11559 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11560 (xg_check_special_colors): Use GtkStyleContext and its functions
11562 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11563 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11564 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11565 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11566 Call gtk_widget_get_preferred_size.
11567 (xg_frame_resized): gdk_window_get_geometry only takes 5
11569 (xg_win_to_widget, xg_event_is_for_menubar):
11570 Call gdk_x11_window_lookup_for_display.
11571 (xg_set_widget_bg): New function.
11572 (delete_cb): New function.
11573 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11574 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11575 (xg_set_background_color): Call xg_set_widget_bg.
11576 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11577 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11578 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11579 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11581 (update_frame_tool_bar): Call gtk_widget_hide.
11582 (xg_initialize): Use GDK_KEY_g.
11584 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11586 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11588 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11589 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11590 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11592 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11594 * w32xfns.c (select_palette): Check success of RealizePalette against
11595 GDI_ERROR, not zero.
11597 See ChangeLog.11 for earlier changes.
11599 ;; Local Variables:
11603 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11605 This file is part of GNU Emacs.
11607 GNU Emacs is free software: you can redistribute it and/or modify
11608 it under the terms of the GNU General Public License as published by
11609 the Free Software Foundation, either version 3 of the License, or
11610 (at your option) any later version.
11612 GNU Emacs is distributed in the hope that it will be useful,
11613 but WITHOUT ANY WARRANTY; without even the implied warranty of
11614 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11615 GNU General Public License for more details.
11617 You should have received a copy of the GNU General Public License
11618 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.