]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Revert inadvertent commit in dispnew.c as part of 2012-06-08T08:44:45Z!eliz@gnu.org.
[gnu-emacs] / src / ChangeLog
1 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2
3 * dispnew.c (showing_window_margins_p): Undo last change, which
4 was done due to an inadvertent commit.
5 (adjust_frame_glyphs_for_frame_redisplay): Do call
6 showing_window_margins_p.
7
8 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
9
10 * eval.c (Fmake_var_non_special): New primitive.
11 (syms_of_eval): Defsubr it.
12 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
13
14 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
15
16 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
17 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
18
19 2012-06-08 Eli Zaretskii <eliz@gnu.org>
20
21 * alloc.c (allocate_vectorlike): Fix last change.
22
23 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
24
25 Block-based vector allocation of small vectors.
26 * lisp.h (struct vectorlike_header): New field `nbytes',
27 adjust comment accordingly.
28 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
29 to denote vector blocks. Adjust users (live_vector_p,
30 mark_maybe_pointer, valid_lisp_object_p) accordingly.
31 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
32 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
33 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
34 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
35 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
36 (roundup_size): New constant.
37 (struct vector_block): New data type.
38 (vector_blocks, vector_free_lists, zero_vector): New variables.
39 (all_vectors): Rename to `large_vectors'.
40 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
41 (sweep_vectors): New functions.
42 (allocate_vectorlike): Return `zero_vector' as the only vector of
43 0 items. Allocate new vector from block if vector size is less than
44 or equal to VBLOCK_BYTES_MAX.
45 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
46 (init_alloc_once): Add call to init_vectors.
47
48 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
49
50 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
51
52 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
53
54 * doprnt.c (doprnt): Truncate multibyte char correctly.
55 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
56 would mishandle a string argument "Xc" if X was a multibyte
57 character of length 2: it would truncate after X's first byte
58 rather than including all of X.
59
60 2012-06-06 Chong Yidong <cyd@gnu.org>
61
62 * buffer.c (word_wrap): Doc fix.
63
64 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
65
66 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
67
68 2012-06-03 Glenn Morris <rgm@gnu.org>
69
70 * xdisp.c (tool-bar-style): Doc fix.
71
72 2012-06-03 Ulrich Müller <ulm@gentoo.org>
73
74 * Makefile.in (PAXCTL): Define.
75 (temacs$(EXEEXT)): Disable memory randomization for the temacs
76 binary via PaX flags if the paxctl utility is available.
77 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
78 Restore PaX flags to their default. (Bug#11398)
79
80 2012-06-03 Chong Yidong <cyd@gnu.org>
81
82 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
83 buffer (Bug#11226).
84
85 2012-06-03 Chong Yidong <cyd@gnu.org>
86
87 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
88 (note_mode_line_or_margin_highlight): If there is no help echo,
89 use mode-line-default-help-echo. Handle the case where the mouse
90 position is past the end of the mode line string.
91
92 * buffer.c (buffer_local_value_1): New function, split from
93 Fbuffer_local_value; can return Qunbound.
94 (Fbuffer_local_value): Use it.
95 (Vmode_line_format): Docstring tweaks.
96
97 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
98
99 * sysdep.c (system_process_attributes): Improve comment.
100
101 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
102
103 * keyboard.c: Export real-this-command to Elisp.
104 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
105 and DEFVAR it. Update all users.
106
107 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
108
109 * minibuf.c (Fassoc_string): Remove duplicate declaration.
110
111 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
112 Convert pctcpu and pctmem to Lisp float properly.
113 Let the compiler fold better, as 100.0/0x8000 is exact.
114
115 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
116
117 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
118 cons_block.
119
120 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
121
122 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
123
124 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
125
126 For a 'struct window', replace some Lisp_Object fields to
127 bitfields where appropriate, remove unused fields.
128 * window.h (struct window): Remove unused 'last_mark_x' and
129 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
130 change it's type from Lisp_Object to bitfield.
131 Change type of 'force_start', 'optional_new_start',
132 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
133 fields from Lisp_Object to bitfield. Adjust users accordingly.
134
135 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
136
137 Pacify gcc -Wdouble-precision when using Xaw.
138 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
139 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
140 Use 'float' consistently, rather than 'float' in most places
141 and 'double' in a couple of places.
142
143 2012-05-31 Eli Zaretskii <eliz@gnu.org>
144
145 * xdisp.c (handle_stop): Detect whether we have overlay strings
146 loaded by testing it->current.overlay_string_index to be
147 non-negative, instead of checking whether n_overlay_strings is
148 positive. (Bug#11587)
149
150 2012-05-31 Chong Yidong <cyd@gnu.org>
151
152 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
153
154 * doc.c (Fsubstitute_command_keys): Doc fix.
155
156 2012-05-31 Eli Zaretskii <eliz@gnu.org>
157
158 * search.c (search_buffer): Remove calls to
159 r_alloc_inhibit_buffer_relocation, as it is now called by
160 maybe_unify_char, which was the cause of relocation of buffer text
161 in bug#11519.
162
163 2012-05-31 Eli Zaretskii <eliz@gnu.org>
164
165 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
166 for the duration of call to load_charset, to avoid problems with
167 callers of maybe_unify_char that access buffer text through C
168 pointers.
169
170 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
171 decrement the inhibition flag, instead of just setting or
172 resetting it.
173
174 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
175
176 Remove obsolete '#define static' cruft.
177 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
178 This #undef was "temporary" in 2000; it is no longer needed
179 now that '#define static' has gone away.
180 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
181 (gray_bitmap_bits): Remove; no longer needed.
182 All uses replaced with definiens.
183 * xterm.c: Include "bitmaps/gray.xbm".
184
185 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
186
187 Clean up __executable_start, monstartup when --enable-profiling.
188 The following changes affect the code only when profiling.
189 * dispnew.c (__executable_start): Rename from safe_bcopy.
190 Define only on platforms that need it.
191 * emacs.c: Include <sys/gmon.h> when profiling.
192 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
193 (__executable_start): Remove decl, since lisp.h does it now.
194 (safe_bcopy): Remove decl; no longer has that name.
195 (main): Coalesce #if into single bit of code, for simplicity.
196 Cast pointers to uintptr_t, since standard libraries want integers
197 and not pointers.
198 * lisp.h (__executable_start): New decl.
199
200 2012-05-31 Glenn Morris <rgm@gnu.org>
201
202 * image.c (Fimagemagick_types): Doc fix.
203
204 2012-05-30 Jim Meyering <meyering@redhat.com>
205
206 * callproc.c (Fcall_process_region): Include directory component
207 in mkstemp error message (Bug#11586).
208
209 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
210
211 * alloc.c, lisp.h (make_pure_vector): Now static.
212
213 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
214
215 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
216 Move to byte-run.el.
217 (Fautoload): Do the hash-doc more carefully.
218 * data.c (Fdefalias): Purify definition, except for keymaps.
219 (Qdefun): Move from eval.c.
220 * lisp.h (Qdefun): Remove.
221 * lread.c (read1): Tiny simplification.
222
223 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
224
225 Do not create empty overlays with the evaporate property (Bug#9642).
226 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
227 Bug#9642, but explicitly check that the buffer the overlay would
228 be moved to is live and rearrange lines to make sure that errors
229 will not put the overlay in an inconsistent state.
230 (Fdelete_overlay): Cosmetics.
231
232 2012-05-28 Eli Zaretskii <eliz@gnu.org>
233
234 * w32term.c (my_bring_window_to_top): New function.
235 (x_raise_frame): Use handle returned by DeferWindowPos, which
236 could be different from the original one.
237 Call my_bring_window_to_top instead of my_set_foreground_window.
238 (Bug#11513)
239
240 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
241 by calling BringWindowToTop.
242
243 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
244 (WM_EMACS_END): Increase by one.
245
246 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
247
248 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
249 This avoids undefined behavior that might cause the eassert
250 to not catch an out-of-range value.
251
252 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
253
254 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
255 Update dependencies.
256
257 2012-05-27 Eli Zaretskii <eliz@gnu.org>
258
259 * bidi.c (bidi_mirror_char): Fix last change.
260
261 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
262
263 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
264 when referring to sectname field in printf format.
265
266 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
267
268 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
269 Only r_alloc_inhibit_buffer_relocation needed to be added;
270 the others were already declared.
271
272 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
273 before checking whether it's out of range. Put the check inside
274 eassert. See
275 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
276
277 2012-05-27 Ken Brown <kbrown@cornell.edu>
278
279 * callproc.c (Fcall_process): Restore a line that was accidentally
280 commented out in the 2011-02-13 change (bug#11547).
281
282 2012-05-27 Eli Zaretskii <eliz@gnu.org>
283
284 * lisp.h [REL_ALLOC]: Add prototypes for external functions
285 defined on ralloc.c.
286
287 * buffer.c [REL_ALLOC]: Remove prototypes of
288 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
289 they are now on lisp.h.
290
291 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
292
293 * search.c (search_buffer): Use it to inhibit relocation of buffer
294 text while re_search_2 is doing its job, because re_search_2 is
295 passed C pointers to buffer text. (Bug#11519)
296
297 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
298 Update value to 24.
299
300 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
301 state after an additional call to move_it_in_display_line_to, keep
302 the values of it->max_ascent and it->max_descent found for the
303 entire line.
304 (pos_visible_p): Revert the comparison against bottom_y to what it
305 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
306 (Bug#11464)
307
308 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
309
310 Fix coding-related core dumps with gcc -ftrapv.
311 The code was computing A - B, where A and B are pointers, and B is
312 random garbage. This can lead to core dumps on platforms that
313 have special pointer registers, and it also leads to core dumps on
314 x86-64 when compiled with gcc -ftrapv. The fix is to compute
315 A - B only when B is initialized properly.
316 * coding.c (coding_set_source, coding_set_destination): Return void.
317 (coding_change_source, coding_change_destinations): New functions,
318 with the old behaviors of coding_set_source and coding_set_destination.
319 All callers that need an offset changed to use these new functions.
320
321 2012-05-26 Glenn Morris <rgm@gnu.org>
322
323 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
324
325 2012-05-26 Eli Zaretskii <eliz@gnu.org>
326
327 Extend mouse support on W32 text-mode console.
328 * xdisp.c (draw_row_with_mouse_face):
329 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
330
331 * w32console.c: Include window.h.
332 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
333 New functions.
334 (initialize_w32_display): Initialize mouse-highlight data.
335
336 * w32inevt.c: Include termchar.h and window.h.
337 (do_mouse_event): Support mouse-autoselect-window. When the mouse
338 moves, call note_mouse_highlight. If help_echo changed, call
339 gen_help_event to produce help-echo message in the echo area.
340 Call clear_mouse_face if mouse_face_hidden is set in the mouse
341 highlight info.
342
343 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
344
345 * lread.c (read1): Simplify slightly to avoid an overflow warning
346 with GCC 4.7.0 on x86-64.
347
348 2012-05-26 Eli Zaretskii <eliz@gnu.org>
349
350 * bidi.c (bidi_mirror_char): Revert last change: an int is
351 definitely wide enough here.
352
353 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
354
355 Fix integer width and related bugs (Bug#9874).
356 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
357 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
358 (string_bytes, check_sblock, allocate_string_data):
359 (compact_small_strings, Fmake_bool_vector, make_string)
360 (make_unibyte_string, make_multibyte_string)
361 (make_string_from_bytes, make_specified_string)
362 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
363 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
364 (mark_vectorlike):
365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
366 (allocate_pseudovector):
367 Use int, not EMACS_INT, where int is wide enough.
368 (inhibit_garbage_collection, Fgarbage_collect):
369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
370 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
371 int might not be wide enough.
372 (bidi_cache_search, bidi_cache_find, bidi_init_it)
373 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
374 (bidi_at_paragraph_end, bidi_find_paragraph_start)
375 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
376 (bidi_level_of_next_char, bidi_move_to_visually_next):
377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
378 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
379 (Fkill_buffer, Fset_buffer_major_mode)
380 (advance_to_char_boundary, Fbuffer_swap_text)
381 (Fset_buffer_multibyte, overlays_at, overlays_in)
382 (overlay_touches_p, struct sortvec, record_overlay_string)
383 (overlay_strings, recenter_overlay_lists)
384 (adjust_overlays_for_insert, adjust_overlays_for_delete)
385 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
386 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
387 (Foverlay_recenter, last_overlay_modification_hooks_used)
388 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
390 (validate_region): Omit unnecessary test for b <= e,
391 since that's guaranteed by the previous test.
392 (adjust_overlays_for_delete): Avoid pos + length overflow.
393 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
394 (report_overlay_modification):
395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
396 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
397 Omit pointer cast, which isn't needed anyway, and doesn't work
398 after the EMACS_INT -> ptrdiff_t change.
399 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
400 * buffer.h: Adjust decls to match defn changes elsewhere.
401 (struct buffer_text, struct buffer):
402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
403 Use EMACS_INT, not int, where int might not be wide enough.
404 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
405 not int, to avoid needless 32-bit limit on 64-bit hosts.
406 (exec_byte_code): Use tighter memory-full test, one that checks
407 for alloca overflow. Don't compute the address of the object just
408 before an array, as that's not portable. Use EMACS_INT, not
409 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
410 * callint.c (Fcall_interactively):
411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
412 * callproc.c (call_process_kill, Fcall_process):
413 Don't assume pid_t fits into an Emacs fixnum.
414 (call_process_cleanup, Fcall_process, child_setup):
415 Don't assume pid_t fits into int.
416 (call_process_cleanup, Fcall_process, delete_temp_file)
417 (Fcall_process_region):
418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
419 (Fcall_process): Simplify handling of volatile integers.
420 Use int, not EMACS_INT, where int will do.
421 * casefiddle.c (casify_object, casify_region, operate_on_word)
422 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
424 (casify_object): Avoid integer overflow when overallocating buffer.
425 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
426 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
427 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
428 * category.h (CATEGORYP): Don't assume arg is nonnegative.
429 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
430 integers are now checked earlier. All uses replaced with XINT.
431 (ccl_driver):
432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
433 For CCL_MapSingle, check that content and value are in int range.
434 (ccl_driver, Fregister_code_conversion_map):
435 Check that Vcode_version_map_vector is a vector.
436 (resolve_symbol_ccl_program): Check that vector header is in range.
437 Always copy the vector, so that we can check its contents reliably
438 now rather than having to recheck each instruction as it's being
439 executed. Check that vector words fit in 'int'.
440 (ccl_get_compiled_code, Fregister_ccl_program)
441 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
442 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
443 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
444 contents are in range.
445 (Fccl_execute_on_string): Check that status is in range.
446 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
447 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
448 Accept and return EMACS_INT, not int, because callers can pass values
449 out of 'int' range.
450 (c_string_width, strwidth, lisp_string_width, chars_in_text)
451 (multibyte_chars_in_text, parse_str_as_multibyte)
452 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
453 (str_as_unibyte, str_to_unibyte, string_count_byte8)
454 (string_escape_byte8, Fget_byte):
455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
456 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
457 avoid mishandling large integers.
458 * character.h: Adjust decls to match defn changes elsewhere.
459 * charset.c (load_charset_map_from_file, find_charsets_in_text)
460 (Ffind_charset_region):
461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
462 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
463 (load_charset_map_from_vector, Fdefine_charset_internal):
464 Don't assume fixnum fits in int.
465 (load_charset_map_from_vector, Fmap_charset_chars):
466 Remove now-unnecessary CHECK_NATNUMs.
467 (Fdefine_charset_internal): Check ranges here, more carefully.
468 Don't rely on undefined behavior with signed left shift overflow.
469 Don't assume unsigned int fits into fixnum, or that fixnum fits
470 into unsigned int. Don't require max_code to be a valid fixnum;
471 that's not true for gb10830 4-byte on a 32-bit host. Allow
472 invalid_code to be a cons, for the same reason. Require code_offset
473 to be a character. Avoid int overflow if max_char is close
474 to INT_MAX.
475 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
476 this is intended anyway and avoids some undefined behavior.
477 (load_charset_map): Pass unsigned, not int, as 2nd arg of
478 INDEX_TO_CODE_POINT, as that's what it expects.
479 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
480 * charset.h (DECODE_CHAR): Return int, not unsigned;
481 this is what was intended anyway, and it avoids undefined behavior.
482 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
483 integer-overflow issues.
484 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
485 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
486 where the argument is EMACS_INT, and this behavior is not intended.
487 * chartab.c (Fmake_char_table, Fset_char_table_range)
488 (uniprop_get_decoder, uniprop_get_encoder):
489 Don't assume fixnum fits in int.
490 * cmds.c (move_point): New function, that does the gist of
491 Fforward_char and Fbackward_char, but does so while checking
492 for integer overflow more accurately.
493 (Fforward_char, Fbackward_char): Use it.
494 (Fforward_line, Fend_of_line, internal_self_insert)
495 (internal_self_insert):
496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
497 Fix a FIXME, by checking for integer overflow when calculating
498 target_clm and actual_clm.
499 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
500 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
501 (ASSURE_DESTINATION, coding_alloc_by_realloc)
502 (coding_alloc_by_making_gap, alloc_destination)
503 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
504 (encode_coding_utf_16, detect_coding_emacs_mule)
505 (decode_coding_emacs_mule, encode_coding_emacs_mule)
506 (detect_coding_iso_2022, decode_coding_iso_2022)
507 (encode_invocation_designation, encode_designation_at_bol)
508 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
509 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
510 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
511 (encode_coding_ccl, encode_coding_raw_text)
512 (detect_coding_charset, decode_coding_charset)
513 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
514 (produce_composition, produce_charset, produce_annotation)
515 (decode_coding, handle_composition_annotation)
516 (handle_charset_annotation, consume_chars, decode_coding_gap)
517 (decode_coding_object, encode_coding_object, detect_coding_system)
518 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
519 (code_convert_region, code_convert_string)
520 (Fdefine_coding_system_internal)
521 (coding_set_source, coding_set_destination):
522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
523 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
524 (Fdefine_coding_system_internal):
525 Don't assume fixnums fit in int.
526 (decode_coding_gap, decode_coding_object, encode_coding_object)
527 (Fread_coding_system, Fdetect_coding_region)
528 (Funencodable_char_position, Fcheck_coding_systems_region)
529 (get_translation, handle_composition_annotation, consume_chars):
530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
531 (consume_chars): Rewrite to not calculate an address outside buffer.
532 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
533 Don't access memory outside of the args array.
534 (Fdefine_coding_system_internal): Check for charset-id overflow.
535 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
536 result of ENCODE_CHAR.
537 * coding.h: Adjust decls to match defn changes elsewhere.
538 (struct coding_system):
539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
540 * composite.c (get_composition_id, find_composition)
541 (run_composition_function, update_compositions)
542 (compose_text, composition_gstring_put_cache)
543 (composition_gstring_p, composition_gstring_width)
544 (fill_gstring_header, fill_gstring_body, autocmp_chars)
545 (composition_compute_stop_pos, composition_reseat_it)
546 (composition_update_it, struct position_record)
547 (find_automatic_composition, composition_adjust_point)
548 (Fcomposition_get_gstring, Ffind_composition_internal):
549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
550 (update_compositions):
551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
552 * composite.h: Adjust decls to match defn changes elsewhere.
553 (struct composition):
554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
555 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
556 Do not attempt to compute the address of the object just before a
557 buffer; this is not portable.
558 (Faref, Faset):
559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
560 (Faset): Use int, not EMACS_INT, where int is wide enough.
561 (Fstring_to_number): Don't assume fixnums fit in int.
562 (Frem): Don't assume arg is nonnegative.
563 * dbusbind.c (xd_append_arg): Check for integers out of range.
564 (Fdbus_call_method): Don't overflow the timeout int.
565 (extract_signed, extract_unsigned): New functions.
566 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
567 (xd_get_connection_references): Return ptrdiff_t, not int.
568 All uses changed.
569 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
570 (xd_read_message_1):
571 Use int, not unsigned, where the dbus API uses int.
572 (Fdbus_message_internal): Don't overflow mtype.
573 (syms_of_dbusbind): Allocate right-sized buffer for integers.
574 * dired.c (directory_files_internal, file_name_completion, scmp)
575 (file_name_completion_stat):
576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
577 (file_name_completion): Don't overflow matchcount.
578 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
579 * dispextern.h: Adjust decls to match defn changes elsewhere.
580 (struct text_pos, struct glyph, struct bidi_saved_info)
581 (struct bidi_string_data, struct bidi_it, struct composition_it)
582 (struct it):
583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
584 (struct display_pos, struct composition_it, struct it):
585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
586 * dispnew.c (increment_matrix_positions)
587 (increment_row_positions, mode_line_string)
588 (marginal_area_string):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
592 (duration_to_sec_usec): New function, to check for overflow better.
593 (Fsleep_for, sit_for): Use it.
594 * doc.c (get_doc_string, store_function_docstring):
595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
596 (get_doc_string, Fsnarf_documentation):
597 Use int, not EMACS_INT, where int is wide enough.
598 (get_doc_string):
599 Use SAFE_ALLOCA, not alloca.
600 Check for overflow when converting EMACS_INT to off_t.
601 * doprnt.c (doprnt):
602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
603 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
604 Don't assume uid_t fits into fixnum.
605 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
606 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
607 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
608 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
609 (general_insert_function)
610 (Finsert_char, make_buffer_string, make_buffer_string_both)
611 (update_buffer_properties, Fbuffer_substring)
612 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
613 (Fsubst_char_in_region, check_translation)
614 (Ftranslate_region_internal, save_restriction_restore, Fformat)
615 (transpose_markers, Ftranspose_regions):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 (clip_to_bounds): Move to lisp.h as an inline function).
618 (Fconstrain_to_field): Don't assume integers are nonnegative.
619 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
620 (Fsubst_char_in_region, Fsave_restriction):
621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
622 (Femacs_pid): Don't assume pid_t fits into fixnum.
623 (lo_time): Use int, not EMACS_INT, when int suffices.
624 (lisp_time_argument): Check for usec out of range.
625 (Fencode_time): Don't assume fixnum fits in int.
626 (Fuser_login_name, Fuser_full_name): Signal an error
627 if a uid argument is out of range, rather than relying on
628 undefined behavior.
629 (Fformat_time_string): Remove now-unnecessary check.
630 lisp_time_argument checks for out-of-range usec now.
631 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
632 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
633 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
634 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
635 (init_cmdargs, Fdump_emacs):
636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
637 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
638 the bottom (typically) 32 bits of the fixnum.
639 * eval.c (specpdl_size, call_debugger):
640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
641 (when_entered_debugger, Fbacktrace_debug):
642 Don't assume fixnum can fit in int.
643 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
644 the object just before a buffer; this is not portable.
645 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
646 (grow_specpdl, unbind_to):
647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
648 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
649 (grow_specpdl): Simplify allocation by using xpalloc.
650 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
651 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
652 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
654 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
655 (a_write, e_write):
656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
657 (Fcopy_file, non_regular_nbytes, read_non_regular)
658 (Finsert_file_contents):
659 Use int, not EMACS_INT, where int is wide enough.
660 (READ_BUF_SIZE): Verify that it fits in int.
661 (Finsert_file_contents): Check that counts are in proper range,
662 rather than assuming fixnums fit into ptrdiff_t etc.
663 Don't assume fixnums fit into int.
664 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
665 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
666 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
667 (string_char_to_byte, string_byte_to_char)
668 (string_make_multibyte, string_to_multibyte)
669 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
670 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
671 (substring_both, Fdelete, internal_equal, Ffillarray)
672 (Fclear_string, mapcar1)
673 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
674 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
675 (larger_vector, make_hash_table, maybe_resize_hash_table)
676 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
677 (Fmaphash, secure_hash):
678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
679 (concat): Check for string index and length overflow.
680 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
681 (Frequire):
682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
683 (larger_vector): New API (vec, incr_min, size_max) replaces old
684 one (vec, new_size, init). This catches size overflow.
685 INIT was removed because it was always Qnil.
686 All callers changed.
687 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
688 the upper bound on a hash table index size.
689 (make_hash_table, maybe_resize_hash_table): Use it.
690 (secure_hash): Computer start_byte and end_byte only after
691 they're known to be in ptrdiff_t range.
692 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
693 (Ffont_get_glyphs, Ffont_at):
694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
695 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
696 (Flist_fonts, Fopen_font):
697 Don't assume fixnum can fit in int.
698 (check_gstring): Don't assume index can fit in int.
699 (font_match_p): Check that fixnum is a character, not a nonnegative
700 fixnum, since the later code needs to stuff it into an int.
701 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
702 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
703 conversion overflow issues.
704 (Fopen_font): Check for integer out of range.
705 (Ffont_get_glyphs): Don't assume index can fit in int.
706 * font.h: Adjust decls to match defn changes elsewhere.
707 * fontset.c (reorder_font_vector): Redo score calculation to avoid
708 integer overflow.
709 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
710 printmax_t, where ptrdiff_t is wide enough.
711 (Finternal_char_font):
712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
713 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
714 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
715 (Fset_frame_position, x_set_frame_parameters)
716 (x_set_line_spacing, x_set_border_width)
717 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
718 Check that fixnums are in proper range for system types.
719 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
721 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
722 Use SAFE_ALLOCA_LISP, not alloca.
723 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
724 intptr_t is wide enough.
725 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
726 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
727 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
728 Check for fixnum out of range.
729 * ftfont.c (ftfont_list): Don't assume index fits in int.
730 Check that fixnums are in proper range for system types.
731 (ftfont_shape_by_flt):
732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
733 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
736 Check that fixnums are in proper range for system types.
737 * gnutls.h: Adjust decls to match defn changes elsewhere.
738 * gtkutil.c (xg_dialog_run):
739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
740 (update_frame_tool_bar):
741 Check that fixnums are in proper range for system types.
742 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
743 (lookup_image): Check that fixnums are in range for system types.
744 * indent.c (last_known_column, last_known_column_point):
745 (current_column_bol_cache):
746 (skip_invisible, current_column, check_display_width):
747 (check_display_width, scan_for_column, current_column_1)
748 (Findent_to, Fcurrent_indentation, position_indentation)
749 (indented_beyond_p, Fmove_to_column, compute_motion):
750 (Fcompute_motion, Fvertical_motion):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 (last_known_column_modified): Use EMACS_INT, not int.
753 (check_display_width):
754 (Fcompute_motion):
755 Check that fixnums and floats are in proper range for system types.
756 (compute_motion): Don't assume index or fixnum fits in int.
757 (compute_motion, Fcompute_motion):
758 Use int, not EMACS_INT, when it is wide enough.
759 (vmotion): Omit local var start_hpos that is always 0; that way
760 we don't need to worry about overflow in expressions involving it.
761 * indent.h: Adjust decls to match defn changes elsewhere.
762 (struct position):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 Use int, not EMACS_INT, where int is wide enough.
765 Remove unused members ovstring_chars_done and tab_offset;
766 all uses removed.
767 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
768 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
769 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
770 (make_gap, copy_text, insert, insert_and_inherit)
771 (insert_before_markers, insert_before_markers_and_inherit)
772 (insert_1, count_combining_before, count_combining_after)
773 (insert_1_both, insert_from_string)
774 (insert_from_string_before_markers, insert_from_string_1)
775 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
776 (adjust_after_replace, adjust_after_insert, replace_range)
777 (replace_range_2, del_range, del_range_1, del_range_byte)
778 (del_range_both, del_range_2, modify_region)
779 (prepare_to_modify_buffer, signal_before_change)
780 (signal_after_change, Fcombine_after_change_execute):
781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
782 * intervals.c (traverse_intervals, rotate_right, rotate_left)
783 (balance_an_interval, split_interval_right, split_interval_left)
784 (find_interval, next_interval, update_interval)
785 (adjust_intervals_for_insertion, delete_node, delete_interval)
786 (interval_deletion_adjustment, adjust_intervals_for_deletion)
787 (static_offset_intervals, offset_intervals)
788 (merge_interval_right, merge_interval_left, make_new_interval)
789 (graft_intervals_into_buffer, temp_set_point_both)
790 (temp_set_point, set_point, adjust_for_invis_intang)
791 (set_point_both, move_if_not_intangible, get_property_and_range)
792 (get_local_map, copy_intervals, copy_intervals_to_string)
793 (compare_string_intervals, set_intervals_multibyte_1):
794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
795 * intervals.h: Adjust decls to match defn changes elsewhere.
796 (struct interval):
797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
798 * keyboard.c (this_command_key_count, this_single_command_key_start)
799 (before_command_key_count, before_command_echo_length, echo_now)
800 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
801 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
802 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
803 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
805 (last_non_minibuf_size, last_point_position, echo_truncate)
806 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
807 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
808 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
809 (stuff_buffered_input):
810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
811 (last_auto_save, command_loop_1, read_char):
812 Use EMACS_INT, not int, to avoid integer overflow.
813 (record_char): Avoid overflow in total_keys computation.
814 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
815 * keyboard.h: Adjust decls to match defn changes elsewhere.
816 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
817 (Fkey_description, Fdescribe_vector, Flookup_key):
818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
819 (click_position): New function, to check that positions are in range.
820 (Fcurrent_active_maps):
821 (describe_command):
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 (Faccessible_keymaps, Fkey_description):
824 (preferred_sequence_p):
825 Don't assume fixnum can fit into int.
826 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
827 Check for integer overflow in size calculations.
828 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
829 avoid mishandling large integers.
830 * lisp.h: Adjust decls to match defn changes elsewhere.
831 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
832 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
833 (struct Lisp_Marker):
834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
835 (clip_to_bounds): Now an inline function, moved here from editfns.c.
836 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
837 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
838 All callers changed.
839 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
840 Assume the arg has valid form, since it always does.
841 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
842 unsigned integer system type.
843 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
844 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
846 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
847 (duration_to_sec_usec): New decl.
848 * lread.c (read_from_string_index, read_from_string_index_byte)
849 (read_from_string_limit, readchar, unreadchar, openp)
850 (read_internal_start, read1, oblookup):
851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
852 (Fload, readevalloop, Feval_buffer, Feval_region):
853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
854 (openp): Check for out-of-range argument to 'access'.
855 (read1): Use int, not EMACS_INT, where int is wide enough.
856 Don't assume fixnum fits into int.
857 Fix off-by-one error that can read outside a buffer.
858 (read_filtered_event): Use duration_to_sec_usec
859 to do proper overflow checking on durations.
860 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
861 in size calculation.
862 (Fexecute_kbd_macro):
863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
864 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
865 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
866 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
867 (set_marker_both, set_marker_restricted_both, marker_position)
868 (marker_byte_position, Fbuffer_has_markers_at):
869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
870 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
871 * menu.c (ensure_menu_items): Rename from grow_menu_items.
872 It now merely ensures that the menu is large enough, without
873 necessarily growing it, as this avoids some integer overflow issues.
874 All callers changed.
875 (keymap_panes, parse_single_submenu, Fx_popup_menu):
876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
877 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
878 Use SAFE_ALLOCA_LISP, not alloca.
879 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
880 to EMACS_INT. Check that fixnums are in proper range for system types.
881 * minibuf.c (minibuf_prompt_width, string_to_object)
882 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
883 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
885 (get_minibuffer, read_minibuf_unwind):
886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
887 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
888 this simplifies overflow checking. All callers changed.
889 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
890 (Ftest_completion):
891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
892 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
893 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
894 Check that fixnums are in proper range for system types.
895 (Fx_create_frame, Fx_show_tip):
896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
897 * nsfont.m (ns_findfonts, nsfont_list_family):
898 Don't assume fixnum fits in long.
899 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
901 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
902 wide enough.
903 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
905 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
906 (PRINTDECLARE, PRINTPREPARE):
907 (strout, print_string):
908 (print, print_preprocess, print_check_string_charset_prop)
909 (print_object):
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 (PRINTDECLARE):
912 (temp_output_buffer_setup, Fprin1_to_string, print_object):
913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
914 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
915 (printchar, strout): Use xpalloc to catch size calculation overflow.
916 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
917 (print_error_message): Use SAFE_ALLOCA, not alloca.
918 (print_object): Use int, not EMACS_INT, where int is wide enough.
919 (print_depth, new_backquote_output, print_number_index):
920 Use ptrdiff_t, not int, where int might not be wide enough.
921 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
922 (Fset_process_window_size, Fformat_network_address)
923 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
924 (sigchld_handler):
925 Check that fixnums are in proper range for system types.
926 (Fsignal_process): Simplify by avoiding a goto.
927 Check for process-ids out of pid_t range rather than relying on
928 undefined behavior.
929 (process_tick, update_tick): Use EMACS_INT, not int.
930 (Fformat_network_address, read_process_output, send_process)
931 (Fprocess_send_region, status_notify):
932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
933 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
934 (wait_reading_process_output, read_process_output, exec_sentinel):
935 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
936 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
937 (Faccept_process_output): Use duration_to_sec_usec to do proper
938 overflow checking on durations.
939 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
940 Don't assume pid_t fits in int.
941 * process.h (struct Lisp_Process): Members tick and update_tick
942 are now of type EMACS_INT, not int.
943 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
944 configured --with-wide-int.
945 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
946 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
947 * search.c (looking_at_1, string_match_1):
948 (fast_string_match, fast_c_string_match_ignore_case)
949 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
950 (scan_newline, find_before_next_newline, search_command)
951 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
952 (set_search_regs, wordify):
953 (Freplace_match):
954 (Fmatch_data):
955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
956 (string_match_1, search_buffer, set_search_regs):
957 (Fmatch_data):
958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
959 (wordify): Check for overflow in size calculation.
960 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
961 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
962 Check that fixnums are in proper range for system types.
963 * sound.c (struct sound_device)
964 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
966 (Fplay_sound_internal):
967 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
968 * syntax.c (struct lisp_parse_state, find_start_modiff)
969 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
970 (Fparse_partial_sexp):
971 Don't assume fixnums can fit in int.
972 (struct lisp_parse_state, find_start_pos, find_start_value)
973 (find_start_value_byte, find_start_begv)
974 (update_syntax_table, char_quoted, dec_bytepos)
975 (find_defun_start, prev_char_comend_first, back_comment):
976 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
977 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
979 (Finternal_describe_syntax_value): Check that match_lisp is a
980 character, not an integer, since the code stuffs it into int.
981 (scan_words, scan_sexps_forward):
982 Check that fixnums are in proper range for system types.
983 (Fforward_word):
984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
985 (scan_sexps_forward):
986 Use CHARACTERP, not INTEGERP, since the value must fit into int.
987 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
988 * syntax.h: Adjust decls to match defn changes elsewhere.
989 (struct gl_state_s):
990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
991 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
992 MOST_POSITIVE_FIXNUM.
993 * sysdep.c (wait_for_termination_1, wait_for_termination)
994 (interruptible_wait_for_termination, mkdir):
995 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
996 (emacs_read, emacs_write):
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
999 and double all fit in int.
1000 * term.c (set_tty_color_mode):
1001 Check that fixnums are in proper range for system types.
1002 * termhooks.h (struct input_event):
1003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1004 * textprop.c (validate_interval_range, interval_of)
1005 (Fadd_text_properties, set_text_properties_1)
1006 (Fremove_text_properties, Fremove_list_of_text_properties)
1007 (Ftext_property_any, Ftext_property_not_all)
1008 (copy_text_properties, text_property_list, extend_property_ranges)
1009 (verify_interval_modification):
1010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1011 (Fnext_single_char_property_change)
1012 (Fprevious_single_char_property_change):
1013 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1014 (copy_text_properties):
1015 Check for integer overflow in index calculation.
1016 * undo.c (last_boundary_position, record_point, record_insert)
1017 (record_delete, record_marker_adjustment, record_change)
1018 (record_property_change):
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1020 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1022 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1023 (Fx_hide_tip, Fx_file_dialog):
1024 * w32menu.c (set_frame_menubar):
1025 Use ptrdiff_t, not int, for consistency with rest of code.
1026 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1027 (select_window, Fdelete_other_windows_internal)
1028 (window_scroll_pixel_based, window_scroll_line_based)
1029 (Frecenter, Fset_window_configuration):
1030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1031 (Fset_window_hscroll, run_window_configuration_change_hook)
1032 (set_window_buffer, temp_output_buffer_show, scroll_command)
1033 (Fscroll_other_window, Frecenter):
1034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1035 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1036 Don't assume fixnum fits in int.
1037 (Fset_window_scroll_bars):
1038 Check that fixnums are in proper range for system types.
1039 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1040 (string_pos, c_string_pos, number_of_chars, init_iterator)
1041 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1042 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1043 (compute_display_string_end, handle_face_prop)
1044 (face_before_or_after_it_pos, handle_invisible_prop)
1045 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1046 (display_prop_intangible_p, string_buffer_position_lim)
1047 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1048 (get_overlay_strings_1, get_overlay_strings)
1049 (iterate_out_of_display_property, forward_to_next_line_start)
1050 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1051 (get_next_display_element, set_iterator_to_next)
1052 (get_visually_first_element, compute_stop_pos_backwards)
1053 (handle_stop_backwards, next_element_from_buffer)
1054 (move_it_in_display_line_to, move_it_in_display_line)
1055 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1056 (add_to_log, message_dolog, message_log_check_duplicate)
1057 (message2, message2_nolog, message3, message3_nolog
1058 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1059 (current_message_1, truncate_echo_area, truncate_message_1)
1060 (set_message, set_message_1, store_mode_line_noprop)
1061 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1062 (text_outside_line_unchanged_p, check_point_in_composition)
1063 (reconsider_clip_changes)
1064 (redisplay_internal, set_cursor_from_row, try_scrolling)
1065 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1066 (redisplay_window, find_last_unchanged_at_beg_row)
1067 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1068 (trailing_whitespace_p, find_row_edges, display_line)
1069 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1070 (display_mode_element, store_mode_line_string)
1071 (pint2str, pint2hrstr, decode_mode_spec)
1072 (display_count_lines, display_string, draw_glyphs)
1073 (x_produce_glyphs, x_insert_glyphs)
1074 (rows_from_pos_range, mouse_face_from_buffer_pos)
1075 (fast_find_string_pos, mouse_face_from_string_pos)
1076 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1078 (safe_call, init_from_display_pos, handle_fontified_prop)
1079 (handle_single_display_spec, load_overlay_strings)
1080 (with_echo_area_buffer, setup_echo_area_for_printing)
1081 (display_echo_area, echo_area_display)
1082 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1083 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1084 (redisplay_window, dump_glyph_row, display_mode_line)
1085 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1086 (handle_display_spec, display_prop_string_p):
1087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1088 (handle_single_display_spec, build_desired_tool_bar_string)
1089 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1090 (get_specified_cursor_type):
1091 Check that fixnums are in proper range for system types.
1092 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1093 (Flookup_image_map):
1094 Don't assume fixnums fit in int.
1095 (compare_overlay_entries):
1096 Avoid mishandling comparisons due to subtraction overflow.
1097 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1098 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1099 (handle_tool_bar_click):
1100 Use int, not unsigned, since we prefer signed and the signedness
1101 doesn't matter here.
1102 (get_next_display_element, next_element_from_display_vector):
1103 Use int, not EMACS_INT, when int is wide enough.
1104 (start_hourglass): Use duration_to_sec_usec to do proper
1105 overflow checking on durations.
1106 * xfaces.c (Fbitmap_spec_p):
1107 Check that fixnums are in proper range for system types.
1108 (compare_fonts_by_sort_order):
1109 Avoid mishandling comparisons due to subtraction overflow.
1110 (Fx_family_fonts, realize_basic_faces):
1111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1112 (Fx_family_fonts):
1113 Don't assume fixnum fits in int.
1114 Use SAFE_ALLOCA_LISP, not alloca.
1115 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1116 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1117 (face_at_buffer_position, face_for_overlay_string)
1118 (face_at_string_position):
1119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1120 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1121 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1122 (Fx_show_tip):
1123 Check that fixnums are in proper range for system types.
1124 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1125 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1127 (Fx_change_window_property): Don't assume fixnums fit in int.
1128 * xfont.c (xfont_chars_supported):
1129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1130 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1131 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1133 * xml.c (parse_region):
1134 * xrdb.c (magic_file_p):
1135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1136 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1137 (x_get_local_selection, x_reply_selection_request)
1138 (x_handle_selection_request, wait_for_property_change):
1139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1140 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1141 short is wide enough.
1142 (x_send_client_event): Don't assume fixnum fits in int.
1143 * xterm.c (x_x_to_emacs_modifiers):
1144 Don't assume EMACS_INT overflows nicely into int.
1145 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1146 may come from Lisp.
1147 (handle_one_xevent): NATNUMP can eval its arg twice.
1148 (x_connection_closed):
1149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1150 * xterm.h: Adjust decls to match defn changes elsewhere.
1151 (struct scroll_bar): Use struct vectorlike_header
1152 rather than rolling our own approximation.
1153 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1154
1155 2012-05-25 Glenn Morris <rgm@gnu.org>
1156
1157 * lisp.mk (lisp): Update for more files being compiled now.
1158
1159 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1160
1161 * lread.c: Remove `read_pure' which makes no difference.
1162 (read_pure): Remove var.
1163 (unreadpure): Remove function.
1164 (readevalloop): Don't call read_list with -1 flag.
1165 (read1, read_vector): Don't test read_pure any more.
1166 (read_list): Simplify.
1167
1168 * fileio.c, character.h: Minor style tweaks.
1169
1170 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 * window.h (clip_changed): Remove useless declaration.
1173
1174 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1175
1176 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1177 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1178
1179 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 Remove src/m/*.
1182 This directory predates autoconf and is no longer needed nowadays.
1183 Move its few remaining bits of functionality to where they're needed.
1184 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1185 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1186 * m/template.h: Remove.
1187 * Makefile.in (M_FILE): Remove. All uses removed.
1188 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1189 * lisp.h (USE_LSB_TAG):
1190 * mem-limits.h (EXCEEDS_LISP_PTR):
1191 Use VAL_MAX, not VALBITS, in #if.
1192 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1193 (EMACS_UINT): Define unconditionally now.
1194 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1195 (BITS_PER_EMACS_INT): New constants, replacing
1196 what used to be in config.h, but not useful in #if.
1197 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1198 define them any more.
1199 (VAL_MAX): New macro.
1200 (VALMASK): Use it.
1201 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1202 BITS_PER_EMACS_INT, in #if.
1203 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1204 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1205 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1206 * s/ms-w32.h (DATA_START):
1207 Move here from removed file m/intel386.h.
1208 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1209 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1210
1211 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 Assume C89 or later.
1214 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1215 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1216 (xrealloc):
1217 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1218 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1219 * textprop.c, tparam.c (NULL): Remove.
1220 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1221 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1222 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1223 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1224 * xterm.c (input_signal_count): Assume volatile works.
1225
1226 2012-05-21 Ken Brown <kbrown@cornell.edu>
1227
1228 * xgselect.c (xg_select): Fix first argument in call to 'select'
1229 (bug#11508).
1230
1231 2012-05-20 Ken Brown <kbrown@cornell.edu>
1232
1233 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1234 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1235
1236 2012-05-19 Ken Brown <kbrown@cornell.edu>
1237
1238 * xfns.c (x_in_use): Remove `static' qualifier.
1239 * xterm.h (x_in_use): Declare.
1240 * xgselect.c: Include xterm.h.
1241 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1242 and `display_arg' (bug#9754).
1243
1244 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1247
1248 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1249 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1250
1251 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1252
1253 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1254
1255 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1256 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1257
1258 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1259 reference to image_cache->refcount.
1260 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1261
1262 2012-05-17 Juri Linkov <juri@jurta.org>
1263
1264 * search.c (Fword_search_regexp, Fword_search_backward)
1265 (Fword_search_forward, Fword_search_backward_lax)
1266 (Fword_search_forward_lax): Move functions to isearch.el
1267 (bug#10145, bug#11381).
1268
1269 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1270
1271 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1272
1273 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1274
1275 * lread.c (init_obarray): Declare Qt and Qnil as special.
1276
1277 2012-05-14 Glenn Morris <rgm@gnu.org>
1278
1279 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1280 Put "libexec" before "bin", for the sake of init_callproc_1.
1281
1282 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1285
1286 * unexaix.c: Port to more-recent AIX compilers.
1287 (report_error, report_error_1, make_hdr, copy_sym)
1288 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1289 Make arguments const char *, not char *, to avoid violations of C
1290 standard and to fix some AIX warnings reported by Gilles Pion.
1291
1292 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1293
1294 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1295 already have overlays loaded.
1296 (handle_single_display_spec): Before returning without displaying
1297 fringe bitmap, synchronize the bidi iterator with the main display
1298 iterator, by calling iterate_out_of_display_property.
1299 (iterate_out_of_display_property): Detect buffer iteration by
1300 testing that it->string is a Lisp string.
1301 (get_next_display_element): When the current object is exhausted,
1302 and there's something on it->stack, call set_iterator_to_next to
1303 proceed with what's on the stack, instead of returning zero.
1304 (set_iterator_to_next): If called at the end of a Lisp string,
1305 proceed to consider_string_end without incrementing string
1306 position. Don't increment display vector index past the end of
1307 the display vector. (Bug#11417)
1308 (pos_visible_p): Don't report a position visible when move_it_to
1309 stopped at the last line of window, which happens to be scanned
1310 backwards by the bidi iteration. (Bug#11464)
1311
1312 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1313
1314 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1315 and right-margin display specs even if the spec is invalid or we
1316 are on a TTY, and thus unable to display on the fringes.
1317 That's because the text with the property will not be displayed anyway,
1318 so we need to signal to the caller that this is a "replacing"
1319 display spec. This fixes display when the spec is invalid or we
1320 are on a TTY.
1321
1322 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1323
1324 * unexaix.c (make_hdr): Fix typo in prototype.
1325 This bug broke the build on AIX. Problem reported by Gilles Pion.
1326
1327 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1328
1329 * keyboard.c (kbd_buffer_get_event): Read special events also in
1330 batch mode. (Bug#11415)
1331
1332 2012-05-12 Glenn Morris <rgm@gnu.org>
1333
1334 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1335
1336 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1337
1338 * lisp.mk (lisp): Add newcomment.elc.
1339
1340 2012-05-12 Glenn Morris <rgm@gnu.org>
1341
1342 * Makefile.in (MKDIR_P): New, set by configure.
1343 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1344
1345 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 Remove unused function hourglass_started.
1348 * dispextern.h (hourglass_started):
1349 * w32fns.c (hourglass_started):
1350 * xdisp.c (hourglass_started): Remove.
1351
1352 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1355 Update dependencies.
1356
1357 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 * xgselect.c (xg_select): Put maxfds+1 into a var.
1360 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1361
1362 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1363
1364 2012-05-10 Dave Abrahams <dave@boostpro.com>
1365
1366 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1367 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1368
1369 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1370
1371 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1372 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1373 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1374 Initialize xd_registered_buses.
1375
1376 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1377
1378 Untag more efficiently if USE_LSB_TAG.
1379 This is based on a proposal by YAMAMOTO Mitsuharu in
1380 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1381 For an admittedly artificial (nth 8000 longlist) benchmark on
1382 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1383 Emacs's overall text size by 1%.
1384 * lisp.h (XUNTAG): New macro.
1385 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1386 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1387 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1388 * eval.c (Fautoload):
1389 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1390 * frame.h (XFRAME): Use XUNTAG.
1391
1392 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1393 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1394 Remove unportable assumptions about print widths of types like
1395 dbus_uint32_t.
1396 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1397 intptr_t when converting between pointer and integer, to avoid GCC
1398 warnings about wrong width.
1399
1400 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1401
1402 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1403 stack for each reader_thread, instead of defaulting to 8MB
1404 determined by the linker. This avoids failures in creating
1405 subprocesses on Windows 7, see the discussion in this thread:
1406 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1407
1408 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1409
1410 Fix up display of the *Minibuf-0* buffer in the mini window.
1411 * keyboard.c (read_char): Don't clear the echo area if there's no
1412 message to clear.
1413 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1414 contents of *Minibuf-0*) if there's no message displayed in its stead.
1415
1416 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1417
1418 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1419 batch mode.
1420
1421 2012-05-06 Chong Yidong <cyd@gnu.org>
1422
1423 * lisp.mk (lisp): Update.
1424
1425 2012-05-05 Jim Meyering <meyering@redhat.com>
1426
1427 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1428
1429 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1430
1431 * data.c (PUT_ERROR): New macro.
1432 (syms_of_data): Use it. Add new error type `user-error'.
1433 * undo.c (user_error): New function.
1434 (Fprimitive_undo): Use it.
1435 * print.c (print_error_message): Adjust print style for `user-error'.
1436 * keyboard.c (user_error): New function.
1437 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1438
1439 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1440
1441 Do not limit current-time-string to years 1000..9999.
1442 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1443 (Fcurrent_time_string): Support any year that is supported by the
1444 underlying localtime representation. Don't use asctime, as it
1445 has undefined behavior for years outside the range -999..9999.
1446
1447 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 Fix race conditions involving setenv, gmtime, localtime, asctime.
1450 Without this fix, interrupts could mess up code that uses these
1451 nonreentrant functions, since setting TZ invalidates existing
1452 tm_zone or tzname values, and since most of these functions return
1453 pointers to static storage.
1454 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1455 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1456 Grow the critical sections to include not just invoking
1457 localtime/gmtime, but also accessing these functions' results
1458 including their tm_zone values if any, and any related TZ setting.
1459 (format_time_string): Last arg is now struct tm *, not struct tm **,
1460 so that the struct tm is saved in the critical section.
1461 All callers changed. Simplify allocation of initial buffer, partly
1462 motivated by the fact that memory allocation needs to be outside
1463 the critical section.
1464
1465 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1466
1467 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1468 with RESET_INTERVAL.
1469
1470 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1471 Remove duplicated buffer name initialization.
1472
1473 2012-05-02 Jim Meyering <jim@meyering.net>
1474
1475 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1476
1477 * xfns.c (x_window): Use xstrdup (Bug#11375).
1478
1479 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (pos_visible_p): If already at a newline from the
1482 display string before the 'while' loop, don't walk back the glyphs
1483 from it3.glyph_row. Solves assertion violation when the display
1484 string begins with a newline (egg.el). (Bug#11367)
1485
1486 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1487
1488 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1489 Move to simple.el.
1490
1491 2012-05-01 Glenn Morris <rgm@gnu.org>
1492
1493 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1494 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1495 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1496 All were removed before 23.1.
1497
1498 * dispnew.c: Remove HAVE_LIBNCURSES test;
1499 it is always true on relevant platforms.
1500
1501 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1502 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1503
1504 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1505
1506 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1507
1508 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1509 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1510 Remove.
1511
1512 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1513
1514 Do not avoid creating empty evaporating overlays (Bug#9642).
1515 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1516 That is, do not delete an evaporating overlay if it becomes
1517 empty after its bounds are adjusted to fit within its buffer.
1518 This fix caused other problems, and I'm reverting it until we get
1519 to the bottom of them.
1520
1521 2012-04-27 Chong Yidong <cyd@gnu.org>
1522
1523 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1524
1525 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1526
1527 * xdisp.c (pos_visible_p): If the window start position is beyond
1528 ZV, start the display from buffer beginning. Prevents assertion
1529 violation in init_iterator when the minibuffer window is scrolled
1530 via the scroll bar.
1531
1532 * window.c (window_scroll_pixel_based): Likewise.
1533
1534 2012-04-27 Chong Yidong <cyd@gnu.org>
1535
1536 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1537
1538 2012-04-27 Glenn Morris <rgm@gnu.org>
1539
1540 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1541 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1542
1543 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1544
1545 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1546 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1547
1548 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1549
1550 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1551 display element, check also the underlying string or buffer
1552 character. (Bug#11341)
1553
1554 * w32menu.c: Include w32heap.h.
1555 (add_menu_item): If the call to AppendMenuW (via
1556 unicode_append_menu) fails, disable Unicode menus only if we are
1557 running on Windows 9X/Me.
1558
1559 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1560
1561 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1562 (xgetint): Add missing shift for LSB tags.
1563
1564 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1565
1566 * keyboard.c (read_char): Don't wipe echo area for select window
1567 events: These might get delayed via `mouse-autoselect-window'
1568 (Bug#11304).
1569
1570 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1571
1572 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1573 manipulation of :loaded-from data.
1574
1575 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1576
1577 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1578 now a cons (bug#11311).
1579
1580 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1581
1582 Do not create empty overlays with the evaporate property (Bug#9642).
1583 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1584 if it becomes empty after its bounds are adjusted to fit within
1585 its buffer. Without this fix, in a nonempty buffer (let ((o
1586 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1587 yields an empty overlay that has the evaporate property, which is
1588 not supposed to happen.
1589
1590 Fix minor GTK3 problems found by static checking.
1591 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1592 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1593 (struct _EmacsFixedClass, emacs_fixed_get_type):
1594 Move decls here from emacsgtkfixed.h, since they needn't be public.
1595 (emacs_fixed_get_type): Now static.
1596 (emacs_fixed_class_init): Omit unused local.
1597 (emacs_fixed_child_type): Remove; unused.
1598 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1599 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1600 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1601 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1602 (EMACS_FIXED_GET_CLASS): Remove; unused.
1603 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1604
1605 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1606 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1607
1608 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1609
1610 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1611 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1612 (__malloc_size_t, __malloc_ptrdiff_t):
1613 Remove. All uses removed, replaced by the definiens if needed,
1614 since we can assume C89 or better now.
1615 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1616 (protect_malloc_state, align, get_contiguous_space)
1617 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1618 (malloc_atfork_handler_child, malloc_enable_thread)
1619 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1620 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1621 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1622 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1623 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1624 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1625 Define using prototypes, not old style.
1626 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1627 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1628 (align): Don't assume that signed integer overflow wraps around.
1629 Omit unused local var.
1630 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1631 (_free_internal_nolock, memalign, mallochook, reallochook):
1632 Omit no-longer-needed casts.
1633 (valloc): Use getpagesize, not __getpagesize.
1634 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1635 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1636
1637 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1638
1639 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1640
1641 Move functions from C to Lisp. Make non-blocking method calls
1642 the default. Implement further D-Bus standard interfaces.
1643
1644 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1645 (QCdbus_request_name_allow_replacement)
1646 (QCdbus_request_name_replace_existing)
1647 (QCdbus_request_name_do_not_queue)
1648 (QCdbus_request_name_reply_primary_owner)
1649 (QCdbus_request_name_reply_in_queue)
1650 (QCdbus_request_name_reply_exists)
1651 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1652 (QCdbus_registered_serial, QCdbus_registered_method)
1653 (QCdbus_registered_signal): New Lisp objects.
1654 (XD_DEBUG_MESSAGE): Use sizeof.
1655 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1656 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1657 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1658 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1659 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1660 (xd_signature, xd_append_arg): Allow float for integer types.
1661 (xd_get_connection_references): New function.
1662 (xd_get_connection_address): Rename from xd_initialize.
1663 Return cached address.
1664 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1665 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1666 level.
1667 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1668 Return number of refcounts.
1669 (Fdbus_get_unique_name): Make stronger parameter check.
1670 (Fdbus_message_internal): New defun.
1671 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1672 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1673 (Fdbus_send_signal, Fdbus_register_service)
1674 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1675 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1676 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1677 (Vdbus_compiled_version, Vdbus_runtime_version)
1678 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1679 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1680 (Vdbus_message_type_signal): New defvars.
1681 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1682 Adapt docstring.
1683
1684 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1685
1686 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1687 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1688 Do not assume ptrdiff_t is the same width as 'int'.
1689
1690 * alloc.c: Handle unusual debugging option combinations.
1691 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1692 since the two debugging options are incompatible.
1693 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1694 is defined.
1695 (mem_init, mem_insert, mem_insert_fixup):
1696 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1697 (NEED_MEM_INSERT): Remove; no longer needed.
1698
1699 2012-04-22 Leo Liu <sdl.web@gmail.com>
1700
1701 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1702
1703 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1704
1705 * sysdep.c [__FreeBSD__]: Minor cleanups.
1706 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1707 Use Emacs indenting style more consistently. Avoid some casts.
1708 Use 'double' consistently rather than mixing 'float' and 'double'.
1709
1710 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1711
1712 * sysdep.c (list_system_processes, system_process_attributes):
1713 Add implementation for FreeBSD (Bug#5243).
1714
1715 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1716
1717 * lisp.mk (lisp): Update.
1718
1719 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1722 It is never used otherwise.
1723
1724 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1725
1726 * print.c (print_preprocess): Only check print_depth if print-circle
1727 is nil.
1728 (print_object): Check for cycles even when print-circle is nil and
1729 print-gensym is t, but only check print_depth if print-circle is nil.
1730
1731 2012-04-20 Chong Yidong <cyd@gnu.org>
1732
1733 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1734 set the status to "failed" and ensure that sentinel is run.
1735
1736 2012-04-20 Glenn Morris <rgm@gnu.org>
1737
1738 * process.c (Fset_process_inherit_coding_system_flag)
1739 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1740 (Fmake_network_process, Fmake_serial_process): Doc fix.
1741
1742 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1743
1744 * xdisp.c (string_buffer_position_lim): Limit starting position to
1745 BEGV.
1746 (set_cursor_from_row): If called for a mode-line or header-line
1747 row, return zero immediately.
1748 (try_cursor_movement): If inside continuation line, don't back up
1749 farther than the first row after the header line, if any.
1750 Don't consider the header-line row as "partially visible", even if
1751 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1752
1753 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1754
1755 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1756 (bug#11238).
1757
1758 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1759 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1760
1761 configure: new option --enable-gcc-warnings (Bug#11207)
1762 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1763 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1764 (ALL_CFLAGS): Use new macros rather than old.
1765 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1766 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1767 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1768 -Wunused-result, -Wunused-variable. This should go away once
1769 the Emacs and Gnulib regex code is merged.
1770 (xmalloc, xrealloc): Now static.
1771
1772 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 * dired.c (Fsystem_groups): Remove unused local.
1775
1776 2012-04-17 Glenn Morris <rgm@gnu.org>
1777
1778 * dired.c (Fsystem_users): Doc fix.
1779
1780 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1781
1782 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1783 (syms_of_dired): Add them.
1784
1785 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 Fix minor alloc.c problems found by static checking.
1788 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1789 New extern decls, to avoid calling undeclared functions.
1790 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1791 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1792 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1793 (NEED_MEM_INSERT): New macro.
1794 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1795 Remove one incorrect comment and fix another.
1796
1797 Fix minor ralloc.c problems found by static checking.
1798 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1799 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1800 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1801 (r_alloc_sbrk): Now static.
1802
1803 Improve ralloc.c interface checking.
1804 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1805 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1806 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1807 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1808 [REL_ALLOC]: ... to here, to check interface.
1809 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1810 Remove decls. This fixes an "It stinks!".
1811
1812 * alloc.c (which_symbols): Fix alignment issue / type clash.
1813
1814 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1815
1816 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1817 (struct Lisp_Misc_Any): Likewise.
1818 (struct Lisp_Free): Likewise.
1819 * alloc.c (union aligned_Lisp_Symbol): Define.
1820 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1821 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1822 (union aligned_Lisp_Misc): Define.
1823 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1824 aligned_Lisp_Misc instead of union Lisp_Misc.
1825 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1826
1827 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1830 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1831 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1832 * s/netbsd.h, s/sol2-6.h:
1833 Remove definition of GC_MARK_STACK, since the default now works.
1834 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1835 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1836 no longer the default.
1837 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1838
1839 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1840
1841 * lread.c (lisp_file_lexically_bound_p):
1842 Fix hang at ";-*-\n" (bug#11238).
1843
1844 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1845
1846 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1847 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1848
1849 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1850
1851 * nsterm.m (constrainFrameRect): Always constrain when there is only
1852 one screen (Bug#10962).
1853
1854 2012-04-13 Ken Brown <kbrown@cornell.edu>
1855
1856 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1857
1858 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1859
1860 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1861
1862 2012-04-11 Daniel Colascione <dancol@dancol.org>
1863
1864 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1865 against is gone. It's better to use vfork now so that when Cygwin
1866 gains a new, working vfork, we use it automatically (bug#10398).
1867
1868 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1869
1870 * window.c (save_window_save): Obey window-point-insertion-type.
1871
1872 2012-04-11 Glenn Morris <rgm@gnu.org>
1873
1874 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1875
1876 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1877
1878 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1879
1880 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1881
1882 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1883 (force_quit_count): New var.
1884 (handle_interrupt): Use it.
1885
1886 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1887
1888 * w32.c (w32_delayed_load): Record the full path of the library
1889 being loaded (bug#10424).
1890
1891 2012-04-09 Glenn Morris <rgm@gnu.org>
1892
1893 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1894 not just in the obarray, before snarfing them. (Bug#11036)
1895
1896 * Makefile.in ($(leimdir)/leim-list.el):
1897 Pass EMACS rather than BUILT_EMACS.
1898
1899 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1900
1901 * process.c (make_process):
1902 * process.h: Add integer `gnutls_handshakes_tried' member to
1903 process struct.
1904
1905 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1906 Add convenience `GNUTLS_LOG2i' macro.
1907
1908 * gnutls.c (gnutls_log_function2i): Convenience log function.
1909 (emacs_gnutls_read): Use new log functions,
1910 `gnutls_handshakes_tried' process member, and
1911 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1912 attempts per process (connection).
1913
1914 2012-04-09 Chong Yidong <cyd@gnu.org>
1915
1916 * eval.c (Fuser_variable_p, user_variable_p_eh)
1917 (lisp_indirect_variable): Functions deleted.
1918 (Fdefvar): Caller changed.
1919
1920 * callint.c (Finteractive, Fcall_interactively):
1921 * minibuf.c (Fread_variable): Callers changed.
1922
1923 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1924
1925 * xdisp.c (set_cursor_from_row): If the display string appears in
1926 the buffer at position that is closer to point than the position
1927 after the display string, display the cursor on the first glyph of
1928 the display string. Fixes cursor display when a 'display' text
1929 property immediately follows invisible text. (Bug#11094)
1930
1931 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 composite.c: use 'double' consistently
1934 * composite.c (get_composition_id): Use 'double' consistently
1935 instead of converting 'float' to 'double' and vice versa; this is
1936 easier to understand and avoids a GCC warning.
1937
1938 2012-04-09 Glenn Morris <rgm@gnu.org>
1939
1940 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1941 preparation for dumping it with emacs. (Bug#4789)
1942 (leimdir): New variable.
1943 ($(leimdir)/leim-list.el): New rule.
1944 (emacs$(EXEEXT)): Depend on leim-list.el.
1945
1946 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1947 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1948 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1949
1950 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1951
1952 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1953 proper alignment.
1954
1955 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1956
1957 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1958 Remove unused local variable.
1959
1960 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1961
1962 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1963 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1964 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1965 objects, as mark_maybe_pointer will catch them otherwise.
1966 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1967 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1968
1969 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1970
1971 Fix typo that broke non-Windows builds.
1972 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1973
1974 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1975
1976 Support building on MS-Windows with libxml2.
1977
1978 * makefile.w32-in (OBJ2): Add xml.$(O).
1979 (GLOBAL_SOURCES): Add xml.c.
1980 ($(BLD)/xml.$(O)): New dependency list.
1981
1982 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1983 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1984 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1985 [!WINDOWSNT]: New macros.
1986 (init_libxml2_functions, libxml2_loaded_p): New functions.
1987 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1988 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1989 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1990 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1991 linked in).
1992 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1993 Call init_libxml2_functions before calling libxml2 functions.
1994 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1995
1996 * emacs.c: Don't include libxml/parser.h.
1997 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1998 xmlCleanupParser directly.
1999
2000 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2001
2002 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2003
2004 * indent.c (Fvertical_motion): If there is a display string at
2005 point, use it.vpos to compute how many lines to backtrack after
2006 move_it_to point. (Bug#11133)
2007
2008 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2009
2010 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2011 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2012 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2013 macros related to unification of CJK characters. For the details,
2014 see the discussion following the message here:
2015 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2016
2017 2012-04-04 Chong Yidong <cyd@gnu.org>
2018
2019 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2020
2021 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2022
2023 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2024 instead of alloca. (Bug#11138)
2025
2026 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2027
2028 * w32menu.c (is_simple_dialog): Properly check lisp types.
2029 (Bug#11141)
2030
2031 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2032
2033 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2034 position we get to after a call to move_it_to fails the
2035 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2036 only if we wind up in a string from display property. (Bug#11063)
2037
2038 * window.c (Fdelete_other_windows_internal): Invalidate the row
2039 and column information about mouse highlight, so that redisplay
2040 restores it after reallocating the glyph matrices. (Bug#7464)
2041
2042 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2043 string comes from a `display' text property, use the buffer
2044 position of that property as if we actually saw that position in
2045 the row's glyphs.
2046 (move_it_by_lines): Remove the assertion that
2047 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2048 violated when there's a before-string at the beginning of a line.
2049 (Bug#11063)
2050
2051 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2052
2053 * xdisp.c (append_space_for_newline): If the default face was
2054 remapped, use the remapped face for the appended newline.
2055 (extend_face_to_end_of_line): Use the remapped default face for
2056 extending the face to the end of the line.
2057 (display_line): Call extend_face_to_end_of_line when the default
2058 face was remapped. (Bug#11068)
2059
2060 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2061
2062 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2063
2064 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2065
2066 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2067
2068 2012-03-27 Glenn Morris <rgm@gnu.org>
2069
2070 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2071 Doc fixes.
2072
2073 2012-03-26 Kenichi Handa <handa@m17n.org>
2074
2075 * dispextern.h (struct glyph): Fix previous change. Change the
2076 bit length of glyphless.ch to 25 (Bug#11082).
2077
2078 2012-03-26 Chong Yidong <cyd@gnu.org>
2079
2080 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2081 (command_loop_1): Use it; inhibit selection update for
2082 handle-select-window too (Bug#8996).
2083
2084 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2085
2086 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2087
2088 2012-03-25 Kenichi Handa <handa@m17n.org>
2089
2090 * dispextern.h (struct glyph): Change the bit length of
2091 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2092
2093 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2094
2095 * s/ms-w32.h (tzname): Include time.h before redirecting to
2096 _tzname. Fixes the MSVC build. (Bug#9960)
2097
2098 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2099
2100 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2101 characters.
2102
2103 * xterm.c (XTread_socket): Only modify handling_signal if
2104 !SYNC_INPUT. (Bug#11080)
2105
2106 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2107
2108 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2109 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2110 when fetching a multibyte character consumes more bytes than
2111 CHAR_BYTES returns, due to unification of CJK characters in
2112 string_char. (Bug#11073)
2113
2114 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2115
2116 * process.c (wait_reading_process_output): Handle pty disconnect
2117 by refraining from sending oneself a SIGCHLD (bug#10933).
2118
2119 2012-03-22 Chong Yidong <cyd@gnu.org>
2120
2121 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2122
2123 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2124 Mark string as coming from a prefix property.
2125 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2126 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2127
2128 2012-03-21 Chong Yidong <cyd@gnu.org>
2129
2130 * xfaces.c (Vface_remapping_alist): Doc fix.
2131
2132 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2133
2134 * w32proc.c (Fw32_set_console_codepage)
2135 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2136 Doc fixes.
2137
2138 2012-03-20 Chong Yidong <cyd@gnu.org>
2139
2140 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2141 to reflect default non-nil value of redisplay-dont-pause.
2142
2143 2012-03-19 Kenichi Handa <handa@m17n.org>
2144
2145 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2146 it fit in a valid range (Bug#11003).
2147
2148 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2149
2150 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2151 that is not from display property, accept the row as a "cursor
2152 row" if one of the string's character has a non-nil `cursor'
2153 property. Fixes cursor positioning when there are newlines in
2154 overlay strings, e.g. in icomplete.el. (Bug#11035)
2155
2156 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2157
2158 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2159
2160 2012-03-12 Chong Yidong <cyd@gnu.org>
2161
2162 * eval.c (inhibit_lisp_code): Rename from
2163 inhibit_window_configuration_change_hook; move from window.c.
2164
2165 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2166 * window.c (run_window_configuration_change_hook)
2167 (syms_of_window): Callers changed.
2168
2169 2012-03-11 Chong Yidong <cyd@gnu.org>
2170
2171 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2172
2173 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2174
2175 2012-03-10 Chong Yidong <cyd@gnu.org>
2176
2177 * frame.c (other_visible_frames): Don't assume the selected frame
2178 is visible (Bug#10955).
2179
2180 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2181
2182 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2183
2184 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2185
2186 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2187 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2188 zero (Bug#10954).
2189
2190 2012-03-03 Glenn Morris <rgm@gnu.org>
2191
2192 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2193
2194 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2195
2196 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2197 position past the first glyph_row that ends at ZV. (Bug#10902)
2198 (redisplay_window, next_element_from_string): Fix typos in
2199 comments.
2200 (redisplay_window): Pass to move_it_vertically the margin in
2201 pixels, not in screen lines.
2202
2203 2012-03-02 Glenn Morris <rgm@gnu.org>
2204
2205 * buffer.c (buffer-list-update-hook): Doc fix.
2206
2207 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2208
2209 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2210 push_it before setting up the iterator for the first overlay
2211 string, even if we have an empty string loaded.
2212 (next_overlay_string): If there's an empty string on the iterator
2213 stack, pop the stack. (Bug#10903)
2214
2215 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2216
2217 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2218 Suggested by Stefan Monnier in
2219 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2220 * alloc.c (widen_to_Lisp_Object): New static function.
2221 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2222 and widening them to Lisp_Objects. This would work even if
2223 USE_LSB_TAG is defined and wide integers are used, which might
2224 happen in a future version of Emacs.
2225
2226 2012-02-25 Chong Yidong <cyd@gnu.org>
2227
2228 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2229 Doc fix.
2230
2231 * xselect.c (Fx_selection_exists_p): Doc fix.
2232 (x_clipboard_manager_save_all): Print an informative message
2233 before saving to clipboard manager.
2234
2235 2012-02-24 Chong Yidong <cyd@gnu.org>
2236
2237 * keyboard.c (process_special_events): Handle all X selection
2238 requests in kbd_buffer, not just the next one (Bug#8869).
2239
2240 2012-02-23 Chong Yidong <cyd@gnu.org>
2241
2242 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2243 call when setting menu-bar-lines and tool-bar-lines parameters.
2244 (unwind_create_frame_1): New helper function.
2245
2246 * window.c (inhibit_window_configuration_change_hook): New var.
2247 (run_window_configuration_change_hook): Obey it.
2248 (syms_of_window): Initialize it.
2249
2250 2012-02-22 Chong Yidong <cyd@gnu.org>
2251
2252 * xterm.c (x_draw_image_relief): Add missing type check for
2253 Vtool_bar_button_margin (Bug#10743).
2254
2255 2012-02-21 Chong Yidong <cyd@gnu.org>
2256
2257 * fileio.c (Vfile_name_handler_alist): Doc fix.
2258
2259 * buffer.c (Fget_file_buffer): Protect against invalid file
2260 handler return value.
2261
2262 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2263
2264 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2265 when computing $valmask.
2266
2267 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2268 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2269 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2270 It's useless in that case, and it can cause problems on hosts
2271 that allocate halves of EMACS_INT values separately.
2272 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2273 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2274 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2275 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2276 it avoids undefined behavior on hosts where shifting right by more
2277 than the word width has undefined behavior.
2278
2279 2012-02-19 Chong Yidong <cyd@gnu.org>
2280
2281 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2282 (Funhandled_file_name_directory, Ffile_name_as_directory)
2283 (Fdirectory_file_name, Fexpand_file_name)
2284 (Fsubstitute_in_file_name): Protect against invalid file handler
2285 return values (Bug#10845).
2286
2287 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2288
2289 * .gdbinit (pitx): Fix incorrect references to fields of the
2290 iterator stack.
2291
2292 2012-02-17 Chong Yidong <cyd@gnu.org>
2293
2294 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2295
2296 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2297
2298 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2299 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2300
2301 2012-02-15 Chong Yidong <cyd@gnu.org>
2302
2303 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2304 marked as special. Also, starting docstrings with * is obsolete.
2305
2306 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2307
2308 * gnutls.c (emacs_gnutls_write): Fix last change.
2309
2310 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2311
2312 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2313 send_process.
2314
2315 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2316
2317 * keymap.c (Fsingle_key_description): Handle char ranges.
2318
2319 2012-02-12 Chong Yidong <cyd@gnu.org>
2320
2321 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2322 as that creates a dangerous corner case.
2323
2324 * window.c (Fdelete_window_internal): Invalidate the mouse
2325 highlight (Bug#9904).
2326
2327 2012-02-12 Glenn Morris <rgm@gnu.org>
2328
2329 * xselect.c (Fx_own_selection_internal)
2330 (Fx_get_selection_internal, Fx_disown_selection_internal)
2331 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2332 * nsselect.m (Fx_own_selection_internal)
2333 (Fx_disown_selection_internal, Fx_selection_exists_p)
2334 (Fx_selection_owner_p, Fx_get_selection_internal):
2335 Sync docs and argument specs with the xselect.c versions.
2336
2337 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2338
2339 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2340
2341 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2342
2343 * w32select.c (Fx_selection_exists_p): Sync doc string and
2344 argument list with xselect.c. (Bug#10783)
2345
2346 * w16select.c (Fx_selection_exists_p): Sync doc string and
2347 argument list with xselect.c. (Bug#10783)
2348
2349 2012-02-10 Glenn Morris <rgm@gnu.org>
2350
2351 * fns.c (Fsecure_hash): Doc fix.
2352
2353 2012-02-09 Kenichi Handa <handa@m17n.org>
2354
2355 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2356
2357 2012-02-07 Chong Yidong <cyd@gnu.org>
2358
2359 * buffer.c (Fbuffer_local_variables)
2360 (buffer_lisp_local_variables): Handle unbound vars correctly;
2361 don't let Qunbound leak into Lisp.
2362
2363 2012-02-07 Glenn Morris <rgm@gnu.org>
2364
2365 * image.c (Fimagemagick_types): Doc fix.
2366
2367 * image.c (imagemagick-render-type): Change it from a lisp object
2368 to an integer. Move the doc here from the lisp manual.
2369 Treat all values not equal to 0 the same.
2370
2371 2012-02-06 Chong Yidong <cyd@gnu.org>
2372
2373 * doc.c (store_function_docstring): Avoid applying docstring of
2374 alias to base function (Bug#2603).
2375
2376 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2377
2378 * .gdbinit (pp1, pv1): Remove redundant defines.
2379 (pr): Use pp.
2380
2381 2012-02-04 Chong Yidong <cyd@gnu.org>
2382
2383 * nsterm.m: Declare a global (Bug#10694).
2384
2385 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2386
2387 * w32.c (get_emacs_configuration_options):
2388 Include --enable-checking, if specified, in the return value.
2389
2390 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2391
2392 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2393 after rounding frame sizes. (Bug#9723)
2394
2395 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2396
2397 * keyboard.c (adjust_point_for_property): Don't position point
2398 before BEGV. (Bug#10696)
2399
2400 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 Handle overflow when computing char display width (Bug#9496).
2403 * character.c (char_width): Return EMACS_INT, not int.
2404 (char_width, c_string_width): Check for overflow when
2405 computing the width; this is possible now that individual
2406 characters can have unbounded width. Problem introduced
2407 by merge from Emacs 23 on 2012-01-19.
2408
2409 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2410
2411 * dbusbind.c (Fdbus_register_method): Mention the return value
2412 :ignore in the docstring.
2413
2414 2012-02-02 Glenn Morris <rgm@gnu.org>
2415
2416 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2417
2418 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2419 Unconditionally set to t. (Bug#10673)
2420 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2421 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2422 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2423
2424 2012-02-02 Kenichi Handa <handa@m17n.org>
2425
2426 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2427 0, do not call append_composite_glyph.
2428
2429 2012-02-02 Kenichi Handa <handa@m17n.org>
2430
2431 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2432 NULL (Bug#6988).
2433 (x_produce_glyphs): If the component of a composition is a null
2434 string, set it->pixel_width to 1 to avoid zero-width glyph.
2435
2436 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2437
2438 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2439 first 2 arguments are identical. This makes inserting large
2440 output from a subprocess an order of magnitude faster on
2441 MS-Windows, where all sbrk'ed memory is always contiguous.
2442
2443 2012-01-31 Glenn Morris <rgm@gnu.org>
2444
2445 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2446 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2447 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2448
2449 2012-01-29 Glenn Morris <rgm@gnu.org>
2450
2451 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2452
2453 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2454
2455 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2456
2457 2012-01-28 Chong Yidong <cyd@gnu.org>
2458
2459 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2460
2461 2012-01-26 Chong Yidong <cyd@gnu.org>
2462
2463 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2464
2465 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2466 repeat counts (Bug#10507).
2467
2468 2012-01-26 Glenn Morris <rgm@gnu.org>
2469
2470 * lread.c (syms_of_lread): Doc fix.
2471
2472 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2473
2474 * coding.c (encode_designation_at_bol): Change return value to
2475 EMACS_INT.
2476
2477 2012-01-25 Chong Yidong <cyd@gnu.org>
2478
2479 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2480
2481 2012-01-21 Chong Yidong <cyd@gnu.org>
2482
2483 * floatfns.c (Fcopysign): Make the second argument non-optional,
2484 since nil is not allowed anyway.
2485
2486 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2487
2488 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2489 (send_process): Likewise.
2490
2491 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2492
2493 * window.c (save_window_save, Fcurrent_window_configuration)
2494 (Vwindow_persistent_parameters): Do not use Qstate.
2495 Rewrite doc-strings.
2496
2497 2012-01-19 Kenichi Handa <handa@m17n.org>
2498
2499 * character.c (char_width): New function.
2500 (Fchar_width, c_string_width, lisp_string_width):
2501 Use char_width (Bug#9496).
2502
2503 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2504
2505 * window.c (Vwindow_persistent_parameters): New variable.
2506 (Fset_window_configuration, save_window_save): Handle persistent
2507 window parameters.
2508
2509 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2510
2511 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2512 thrashing the stack of the thread. (Bug#9087)
2513
2514 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2515
2516 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2517
2518 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2519
2520 * xdisp.c (rows_from_pos_range): Handle the case where the
2521 highlight ends on a newline. (Bug#10464)
2522 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2523 he end column for display of highlight that ends on a newline
2524 before a R2L line.
2525
2526 2012-01-11 Glenn Morris <rgm@gnu.org>
2527
2528 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2529 from load-path also when installation-directory is nil. (Bug#10208)
2530
2531 2012-01-10 Glenn Morris <rgm@gnu.org>
2532
2533 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2534
2535 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2536 Update template values to be closer to their typical values these days.
2537
2538 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2539
2540 * xdisp.c (rows_from_pos_range): Accept additional argument
2541 DISP_STRING, and accept any glyph in a row whose object is that
2542 string as eligible for mouse highlight. Fixes mouse highlight of
2543 display strings from overlays. (Bug#10464)
2544
2545 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2546
2547 emacs: fix an auto-save permissions race condition (Bug#10400)
2548 * fileio.c (auto_saving_dir_umask): New static var.
2549 (Fmake_directory_internal): Use it.
2550 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2551 creating the directory. The old code temporarily assigns
2552 too-generous permissions to the directory.
2553 (do_auto_save_eh): Clear it.
2554 (Fdo_auto_save): Catch all errors, not just file errors, so
2555 that the var is always cleared.
2556
2557 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2558
2559 * search.c (scan_buffer): Pass character positions to
2560 know_region_cache, not byte positions. (Bug#6540)
2561
2562 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2563
2564 * w32.c (sys_rename): Report EXDEV when rename of a directory
2565 fails because the target is on another logical disk. (Bug#10284)
2566
2567 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2568
2569 * xterm.c (x_embed_request_focus): New function.
2570
2571 * xterm.h: Add prototype.
2572
2573 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2574
2575 2012-01-05 Glenn Morris <rgm@gnu.org>
2576
2577 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2578
2579 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2580
2581 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2582 Load gnutls_transport_set_lowat only if GnuTLS version is below
2583 2.11.1.
2584 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2585 GnuTLS versions below 2.11.1.
2586
2587 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2588
2589 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2590 to the doc string advising against its use for altering the way
2591 windows are scrolled.
2592
2593 2011-12-28 Kenichi Handa <handa@m17n.org>
2594
2595 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2596 coding-system ASCII compatible only when it does not produce BOM
2597 on encoding (Bug#10383).
2598
2599 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2600
2601 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2602 can scroll.
2603 (create_and_show_popup_menu): Always use menu_position_func for
2604 Gtk3 (Bug#10361).
2605
2606 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2607
2608 * callint.c (Fcall_interactively): Don't truncate prompt string.
2609
2610 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2611
2612 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2613 property that ends at ZV, so that the bidi iteration could be
2614 resumed from there (after widening). (Bug#10360)
2615
2616 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2617
2618 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2619
2620 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2621
2622 * nsterm.m (x_free_frame_resources):
2623 Release f->output_data.ns->miniimage.
2624 (ns_index_color): Fix indentation. Do not retain
2625 color_table->colors[i].
2626
2627 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2628 before returning.
2629
2630 * nsfns.m (x_set_background_color): Assign return value from
2631 ns_index_color to face-background instead of NSColor*.
2632 (ns_implicitly_set_icon_type): Fix indentation.
2633 Change assignment in for loop to comparison.
2634
2635 * emacs.c (ns_pool): New variable.
2636 (main): Assign ns_pool.
2637 (Fkill_emacs): Call ns_release_autorelease_pool.
2638
2639 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2640 autorelease fdesc, release fdAttrs and tdict.
2641 (ns_get_covering_families): Release charset.
2642 (ns_findfonts): Release NSFontDescriptor created with new.
2643 (ns_uni_to_glyphs): Fix indentation.
2644 (setString): Release attrStr before assigning new value.
2645
2646 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2647
2648 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2649 and NS_IMPL_COCOA.
2650 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2651 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2652
2653 2011-12-18 David Reitter <reitter@cmu.edu>
2654
2655 * nsterm.m (ns_term_init): Subscribe for notifications
2656 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2657 to method trackingNotification in EmacsMenu.
2658
2659 * nsmenu.m (trackingMenu): New variable.
2660 (trackingNotification): New method (from Aquamacs).
2661 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2662 from Aquamacs (Bug#7030).
2663
2664 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2665
2666 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2667 (symbol_to_nsstring): Fix indentation.
2668 (ns_symbol_to_pb): New function.
2669 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2670 (Fns_rotate_cut_buffers_internal): Remove.
2671 (Fns_store_selection_internal): Rename from
2672 Fns_store_cut_buffer_internal.
2673 (ns_get_foreign_selection, Fx_own_selection_internal)
2674 (Fx_disown_selection_internal, Fx_selection_exists_p)
2675 (Fns_get_selection_internal, Fns_store_selection_internal):
2676 Use ns_symbol_to_pb and check if return value is nil.
2677 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2678 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2679 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2680 renamed to Sns_store_selection_internal.
2681 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2682 and remove this function.
2683 (ns_handle_selection_clear): Remove, never used.
2684 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2685 here.
2686
2687 2011-12-17 Ken Brown <kbrown@cornell.edu>
2688
2689 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2690 GID is unknown (Bug#10257).
2691
2692 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2693
2694 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2695 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2696 which caused a build failure on GNU/Linux IA-64. This problem was
2697 introduced by my 2011-10-07 patch.
2698
2699 2011-12-15 Juri Linkov <juri@jurta.org>
2700
2701 * image.c (imagemagick_error): New function. (Bug#10112)
2702 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2703 Use `imagemagick_error' where ImageMagick functions return
2704 `MagickFalse'.
2705 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2706 proper order.
2707
2708 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2709
2710 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2711 fill background (Bug#8992).
2712
2713 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2714
2715 * window.c (Vwindow_combination_resize)
2716 (Vwindow_combination_limit): Use t instead of non-nil in
2717 doc-strings.
2718 (Vrecenter_redisplay): Add first sentence of doc-string on
2719 separate line.
2720 (Frecenter): Fix doc-string typo.
2721
2722 2011-12-11 Kenichi Handa <handa@m17n.org>
2723
2724 * coding.c (Funencodable_char_position): Pay attention to the
2725 buffer text relocation (Bug#9389).
2726
2727 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2728
2729 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2730 gtk_init (Bug#10100).
2731
2732 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2733
2734 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2735 IT->string is nil. (Bug#10263)
2736
2737 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2738
2739 * nsterm.h (x_free_frame_resources): Declare.
2740
2741 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2742 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2743
2744 * nsterm.h (ns_get_defaults_value): Declare.
2745
2746 * nsterm.m (ns_default): Call ns_get_defaults_value.
2747
2748 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2749
2750 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2751 (Bug#10170)
2752
2753 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2754
2755 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2756 that where the value of an _OBJC_* symbol points to is in the .bss
2757 section (Bug#10240).
2758
2759 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2760
2761 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2762 after the loop to call ccl_driver at least once (Bug#8619).
2763
2764 2011-12-08 Kenichi Handa <handa@m17n.org>
2765
2766 * ftfont.c (get_adstyle_property): Fix previous change
2767 (Bug#10233).
2768
2769 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2770
2771 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2772 dirs from the default value of EMACSLOADPATH (bug#10208).
2773
2774 2011-12-07 Glenn Morris <rgm@gnu.org>
2775
2776 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2777 installation and source directories as well. (Bug#10208)
2778
2779 2011-12-06 Chong Yidong <cyd@gnu.org>
2780
2781 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2782
2783 2011-12-06 Glenn Morris <rgm@gnu.org>
2784
2785 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2786 as an error, not just -1. (Bug#10217)
2787
2788 2011-12-05 Chong Yidong <cyd@gnu.org>
2789
2790 * keyboard.c (process_special_events): New function.
2791 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2792
2793 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2794
2795 * coding.c (encode_designation_at_bol): Don't use uninitialized
2796 local variable (Bug#9318).
2797
2798 2011-12-05 Kenichi Handa <handa@m17n.org>
2799
2800 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2801 return Qnil (Bug#8046, Bug#10193).
2802
2803 2011-12-05 Kenichi Handa <handa@m17n.org>
2804
2805 * coding.c (encode_designation_at_bol): New args charbuf_end and
2806 dst. Return the number of produced bytes. Callers changed.
2807 (coding_set_source): Return how many bytes coding->source was
2808 relocated.
2809 (coding_set_destination): Return how many bytes
2810 coding->destination was relocated.
2811 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2812 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2813
2814 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2815
2816 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2817 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2818 macro (Bug#9318).
2819
2820 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2821
2822 The following changes are to fix Bug#9318.
2823
2824 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2825 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2826 (encode_coding_iso_2022, encode_coding_sjis)
2827 (encode_coding_big5, encode_coding_charset): Use the above macros.
2828
2829 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2830
2831 * lisp.h (process_quit_flag): Fix external declaration.
2832
2833 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2834
2835 Don't macro-inline non-performance-critical code.
2836 * eval.c (process_quit_flag): New function.
2837 * lisp.h (QUIT): Use it.
2838
2839 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2840
2841 * nsfns.m (get_geometry_from_preferences): New function.
2842 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2843
2844 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2845
2846 * emacs.c (Qkill_emacs): Define.
2847 (syms_of_emacs): Initialize it.
2848 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2849 Qquit_flag to `kill-emacs' instead.
2850 (quit_throw_to_read_char): Add parameter `from_signal'.
2851 All callers changed. Call Fkill_emacs if requested and safe.
2852 * lisp.h (QUIT): Call Fkill_emacs if requested.
2853
2854 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2855
2856 * widget.c (update_wm_hints): Return if wmshell is null.
2857 (widget_update_wm_size_hints): New function.
2858
2859 * widget.h (widget_update_wm_size_hints): Declare.
2860
2861 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2862 widget_update_wm_size_hints (Bug#10104).
2863
2864 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2865
2866 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2867 before a newline, prepare the bidi iterator for consuming the
2868 newline, and keep the current paragraph direction. (Bug#10183)
2869 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2870
2871 2011-12-02 Juri Linkov <juri@jurta.org>
2872
2873 * search.c (Fword_search_regexp): New Lisp function created from
2874 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2875 (Fword_search_backward, Fword_search_forward)
2876 (Fword_search_backward_lax, Fword_search_forward_lax):
2877 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2878 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2879
2880 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2881
2882 * fileio.c (Finsert_file_contents): Move after-change-function call
2883 to before the "handled:" label, since all "goto handled" appear in
2884 cases where the *-change-functions have already been properly called
2885 (bug#10117).
2886
2887 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2888
2889 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2890 waiting for input. (Bug#10169)
2891
2892 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2893
2894 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2895 verifies glyph row's hash code--we have just reallocated the
2896 glyphs, so their contents can be complete garbage. (Bug#10164)
2897
2898 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2899
2900 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2901
2902 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2903
2904 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2905 attributes are tested _before_ calling verify_row_hash, to protect
2906 against GCC re-ordering of the tests. (Bug#10164)
2907
2908 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2909
2910 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2911
2912 * xterm.c (handle_one_xevent): Only set async_visible and friends
2913 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2914 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2915 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2916
2917 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2918
2919 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2920 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2921 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2922 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2923 All uses changed to use GCPRO1 etc.
2924 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2925 Revert to old implementation (i.e., before 2011-03-11).
2926
2927 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2928
2929 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2930 of scroll runs so as to avoid assigning disabled bogus rows and
2931 unnecessary graphics copy operations.
2932
2933 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2934
2935 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2936 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2937 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2938 (malloc, free, realloc, calloc): Redirect to e_* only when
2939 compiling Emacs.
2940
2941 * lisp.h (GCTYPEBITS): Move before first use.
2942 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2943 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2944 this macro definition.
2945
2946 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2947 _MSC_VER.
2948
2949 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2950
2951 * gtkutil.c (xg_create_frame_widgets):
2952 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2953 present with Gtk+ 2.0.
2954
2955 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2956
2957 * fileio.c (Finsert_file_contents): Undo previous change; see
2958 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2959
2960 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2961
2962 Rename locals to avoid shadowing.
2963 * fileio.c (Finsert_file_contents):
2964 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2965 * process.c (wait_reading_process_output):
2966 Rename inner 'proc' to 'p' to avoid shadowing.
2967 Indent for consistency with usual Emacs style.
2968
2969 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2970
2971 * xdisp.c (redisplay_window): If cursor row is not fully visible
2972 after recentering, and scroll-conservatively is set to a large
2973 number, scroll window by a few more lines to make the cursor fully
2974 visible and out of scroll-margin. (Bug#10105)
2975 (start_display): Don't move to the next line if the display should
2976 start at a newline that is part of a display vector or an overlay
2977 string. (Bug#10119)
2978
2979 2011-11-24 Juri Linkov <juri@jurta.org>
2980
2981 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2982 after the `MagickPingImage' call. (Bug#10112)
2983
2984 2011-11-23 Chong Yidong <cyd@gnu.org>
2985
2986 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2987
2988 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2989
2990 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2991 making another buffer current. (Bug#10114)
2992
2993 2011-11-23 Glenn Morris <rgm@gnu.org>
2994
2995 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2996
2997 2011-11-23 Chong Yidong <cyd@gnu.org>
2998
2999 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3000 using it (Bug#5984).
3001
3002 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3003
3004 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3005 and header-lines, as they don't have one computed for them.
3006 (Bug#10098)
3007
3008 * .gdbinit (prow): Make displayed values more self-explaining.
3009 Add row's hash code.
3010
3011 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3012
3013 * process.c (wait_reading_process_output): Fix asynchrounous
3014 GnuTLS socket handling on some versions of the GnuTLS library.
3015 (wait_reading_process_output): Add comment and URL.
3016
3017 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3018
3019 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3020
3021 2011-11-21 Chong Yidong <cyd@gnu.org>
3022
3023 * window.c (Fnext_window, Fprevious_window): Doc fix.
3024
3025 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3026
3027 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3028
3029 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3030
3031 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3032
3033 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3034
3035 * window.c (Fset_window_combination_limit): Rename argument
3036 STATUS to LIMIT.
3037 (Vwindow_combination_limit): Remove "status" from doc-string.
3038
3039 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3040
3041 * m/ibms390.h: Remove.
3042 * m/ibms390x.h: Don't include "ibms390.h".
3043
3044 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3045
3046 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3047 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3048
3049 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3050
3051 * casetab.c (Fset_case_table):
3052 * charset.c (Fcharset_after): Fix typos.
3053
3054 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3057 Otherwise, valgrind does not work on some platforms.
3058 Problem reported by Andreas Schwab in
3059 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3060 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3061 is set, removing the need for VIRT_ADDRESS_VARIES.
3062 (PURE_P): Use a more-efficient implementation that needs just one
3063 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3064 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3065 to 4 (xorl, subq, cmpq, setbe).
3066 * alloc.c (pure): Always extern now, since that's the
3067 VIRT_ADDR_VARIES behavior.
3068 (PURE_POINTER_P): Use a single comparison, not two, for
3069 consistency with the new puresize.h.
3070 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3071 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3072 Remove VIRT_ADDR_VARIES no longer needed.
3073
3074 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3075
3076 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3077 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3078 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3079 behave as if the cursor position were at the window margin.
3080
3081 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3082 and the cursor position is out of bounds, behave as if the cursor
3083 position were at the window margin. (Bug#10075)
3084
3085 2011-11-18 Chong Yidong <cyd@gnu.org>
3086
3087 * window.c (Fwindow_combination_limit): Make first argument
3088 non-optional, since it is meaningless for live windows like the
3089 selected window.
3090
3091 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3092
3093 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3094
3095 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3096
3097 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3098 (graft_intervals_into_buffer): Simplify.
3099
3100 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3101
3102 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3103 hash values of the two rows.
3104 (copy_row_except_pointers): Preserve the used[] arrays and the
3105 hash values of the two rows. (Bug#10035)
3106 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3107
3108 * xdisp.c (row_hash): New function, body extracted from
3109 compute_line_metrics.
3110 (compute_line_metrics): Call row_hash, instead of computing the
3111 hash code inline.
3112
3113 * dispnew.c (verify_row_hash): Call row_hash for computing the
3114 hash code of a row, instead of duplicating code from xdisp.c.
3115
3116 * dispextern.h (row_hash): Add prototype.
3117
3118 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3119
3120 * frame.c (delete_frame): Don't delete the terminal when the last
3121 X frame is closed if emacs is built with GTK toolkit.
3122
3123 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3124
3125 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3126
3127 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3128
3129 * window.c (Vwindow_splits): Rename to
3130 Vwindow_combination_resize. Suggested by Juri Linkov.
3131 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3132 of Vwindow_splits.
3133
3134 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3135
3136 * nsfns.m (Fns_font_name):
3137 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3138
3139 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3140
3141 * window.h (window): Rename slot "nest" to "combination_limit".
3142 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3143 (Fset_window_nest): Rename to Fset_window_combination_limit.
3144 (Vwindow_nest): Rename to Vwindow_combination_limit.
3145 (recombine_windows, make_parent_window, make_window)
3146 (Fsplit_window_internal, saved_window)
3147 (Fset_window_configuration, save_window_save): Rename all
3148 occurrences of window_nest to window_combination_limit.
3149
3150 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3151
3152 * image.c (imagemagick_load_image): Fix typo.
3153
3154 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3155
3156 * xdisp.c (display_line): Move the call to
3157 highlight_trailing_whitespace before the call to
3158 compute_line_metrics, since the latter needs to see the final
3159 faces of all the glyphs to compute ROW's hash value.
3160 Fixes assertion violations in row_equal_p. (Bug#10035)
3161
3162 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3163
3164 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3165 just return (bug#10044).
3166
3167 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3168
3169 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3170 with user-defined heap size. Bump the default size of the temacs
3171 heap to 27MB, to avoid memory warning when running temacs.
3172 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3173
3174 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3175 current_matrix and desired_matrix. (Bug#9990)
3176 (verify_row_hash) [XASSERTS]: New function.
3177 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3178 that the hash value of glyph rows is correct.
3179
3180 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3181
3182 * window.h (window): Remove splits slot.
3183 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3184 (Fdelete_other_windows_internal, make_parent_window)
3185 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3186 (Fset_window_configuration, save_window_save): Don't deal with
3187 split status of windows.
3188 (saved_window): Remove splits slot.
3189 (Vwindow_splits): Rewrite doc-string.
3190
3191 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3192
3193 * xfns.c (unwind_create_frame):
3194 * nsfns.m (unwind_create_frame):
3195 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3196 Vframe_list (Bug#9999).
3197
3198 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3199
3200 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3201
3202 2011-11-11 Kenichi Handa <handa@m17n.org>
3203
3204 * callproc.c (Fcall_process): Set the member dst_multibyte of
3205 process_coding.
3206
3207 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3208
3209 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3210 avoid a crash (bug#9496).
3211
3212 2011-11-09 Chong Yidong <cyd@gnu.org>
3213
3214 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3215 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3216
3217 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3218
3219 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3220
3221 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3222
3223 Avoid some portability problems by eschewing 'extern inline' functions.
3224 The trivial performance wins aren't worth the portability hassles; see
3225 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3226 et seq.
3227 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3228 (window_box_width, window_box_left, window_box_left_offset)
3229 (window_box_right, window_box_right_offset): Undo previous change,
3230 by removing the "extern"s.
3231 * intervals.c (adjust_intervals_for_insertion)
3232 (adjust_intervals_for_deletion): Undo previous change,
3233 making these static again.
3234 (offset_intervals, temp_set_point_both, temp_set_point)
3235 (copy_intervals_to_string): No longer inline.
3236 * xdisp.c (window_text_bottom_y, window_box_width)
3237 (window_box_height, window_box_left_offset)
3238 (window_box_right_offset, window_box_left, window_box_right)
3239 (window_box): No longer inline.
3240
3241 2011-11-08 Chong Yidong <cyd@gnu.org>
3242
3243 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3244 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3245 Signal an error if not a live window.
3246 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3247 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3248
3249 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * lisp.h (syms_of_abbrev): Remove declaration.
3252 Reported by CHENG Gao <chenggao@royau.me>.
3253
3254 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3255
3256 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3257 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3258 of temacs in GUI mode.
3259
3260 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3261
3262 * window.h: Declare delete_all_child_windows instead of
3263 delete_all_subwindows.
3264 * window.c (Fwindow_nest, Fset_window_nest)
3265 (Fset_window_new_total, Fset_window_new_normal)
3266 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3267 (delete_all_subwindows): Rename to delete_all_child_windows.
3268 (Fdelete_other_windows_internal, Fset_window_configuration):
3269 Call delete_all_child_windows instead of delete_all_subwindows.
3270 * frame.c (delete_frame): Call delete_all_child_windows instead
3271 of delete_all_subwindows.
3272
3273 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3276 This is also needed for porting to any host where GC_MARK_STACK is
3277 not GC_MAKE_GCPROS_NOOPS.
3278 (which_symbols): Use it.
3279
3280 2011-11-07 Kenichi Handa <handa@m17n.org>
3281
3282 * coding.c (coding_set_destination): Check coding->src_pos only
3283 when coding->src_object is a buffer (bug#9910).
3284
3285 * process.c (send_process): Set the member src_multibyte of coding
3286 to 0 (bug#9911) when sending a unibyte text.
3287
3288 * callproc.c (Fcall_process): Set the member src_multibyte of
3289 process_coding to 0 (bug#9912).
3290
3291 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3292
3293 * xmenu.c (cleanup_widget_value_tree): New function.
3294 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3295 calling free_menubar_widget_value_tree directly (Bug#9830).
3296
3297 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3298
3299 Fix some portability problems with 'inline'.
3300 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3301 (window_box_width, window_box_left, window_box_left_offset)
3302 (window_box_right, window_box_right_offset): Declare extern.
3303 Otherwise, these inline functions do not conform to C99 and
3304 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3305 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3306 * intervals.c (adjust_intervals_for_insertion)
3307 (adjust_intervals_for_deletion): Now extern, because otherwise the
3308 extern inline functions 'offset_intervals' couldn't refer to it.
3309 (static_offset_intervals): Remove.
3310 (offset_intervals): Rewrite using the old contents of
3311 static_offset_intervals. The old version didn't conform to C99
3312 because an extern inline function contained a reference to an
3313 identifier with static linkage.
3314
3315 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3316
3317 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3318 GC.
3319
3320 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3321
3322 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3323 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3324 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3325 return Qleft_to_right.
3326
3327 2011-11-06 Chong Yidong <cyd@gnu.org>
3328
3329 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3330 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3331 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3332 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3333 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3334 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3335 (Fwindow_vscroll): Doc fix.
3336 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3337 argument, since it makes no sense to pass a live window and for
3338 consistency with window-child.
3339
3340 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3341
3342 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3343 support MSVC.
3344
3345 2011-11-05 Jason Rumney <jasonr@gnu.org>
3346
3347 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3348 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3349 fonts (Bug#6029).
3350 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3351 bitwise arithmetic preventing use of unicode-sip and non-truetype
3352 opentype fonts.
3353
3354 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3355
3356 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3357 "emacs"-only part.
3358
3359 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3360 initialization code to keep similarity to xfns.c after changes
3361 from 2011-11-05.
3362
3363 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3364
3365 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3366 (unwind_create_frame): New function (Bug#9943).
3367 (Fx_create_frame): Restructure code to be more similar to the one in
3368 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3369 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3370 Move terminal->reference_count++ just before making the frame official
3371 (Bug#9943).
3372
3373 * nsterm.m (x_free_frame_resources): New function.
3374 (x_destroy_window): Move code to x_free_frame_resources.
3375
3376 * xfns.c (unwind_create_frame): Fix comment.
3377 (Fx_create_frame, x_create_tip_frame):
3378 Move terminal->reference_count++ just before making the frame
3379 official. Move initialization of image_cache_refcount and
3380 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3381
3382 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3383
3384 Support MSVC build with newer versions of Visual Studio.
3385 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3386 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3387 nt/gmake.defs.
3388
3389 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3390 which are not supported by MSVC.
3391 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3392 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3393 bitfields.
3394 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3395 types in bitfields.
3396 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3397
3398 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3399
3400 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3401
3402 Support MSVC build with newer versions of Visual Studio.
3403 * w32.c: Don't include w32api.h for MSVC.
3404 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3405
3406 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3407 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3408 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3409 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3410 e_* cousins.
3411 (alloca) [_MSC_VER]: Define to _alloca.
3412
3413 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3414
3415 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3416
3417 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3418
3419 * xdisp.c (note_mouse_highlight): If either of
3420 previous/next-single-property-change returns nil, treat that as
3421 the beginning or the end of the buffer. (Bug#9955)
3422
3423 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3424
3425 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3426 label is not null (Bug#9951).
3427 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3428 may be NULL.
3429
3430 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3431
3432 * window.c (Fwindow_body_size): Mention in the doc string that the
3433 return value is in frame's canonical units. (Bug#9949)
3434
3435 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3436
3437 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3438
3439 * w32fns.c (unwind_create_frame): If needed, free the glyph
3440 matrices of the partially constructed frame. (Bug#9943)
3441 * xfns.c (unwind_create_frame): Likewise.
3442
3443 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3444
3445 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3446 Don't stop backward scan on the continuation glyph, even though
3447 its CHARPOS is positive.
3448 (mouse_face_from_buffer_pos, note_mouse_highlight):
3449 Rename cover_string to disp_string.
3450
3451 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3452
3453 * window.c (temp_output_buffer_show): Don't use
3454 Vtemp_buffer_show_specifiers.
3455 (Vtemp_buffer_show_specifiers): Remove unused variable.
3456
3457 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3458
3459 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3460 past the beginning of the current glyph matrix.
3461
3462 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3463
3464 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3465 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3466 HAVE_GTK3 (Bug#9869).
3467
3468 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3469 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3470
3471 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3472
3473 * xterm.c: Declare x_handle_net_wm_state to return int.
3474 (handle_one_xevent): Check if we are iconified but don't have
3475 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3476 (get_current_wm_state): Return non-zero if not hidden,
3477 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3478 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3479 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3480 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3481
3482 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3483
3484 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3485 so that this new function doesn't get optimized away by a
3486 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3487
3488 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3489
3490 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3491
3492 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3493
3494 Fix the `xbytecode' command.
3495 * .gdbinit (xprintbytestr): New command.
3496 (xwhichsymbols): Rename from `which'; all callers changed.
3497 (xbytecode): Print the byte-code string as well.
3498
3499 2011-10-29 Kim Storm <storm@cua.dk>
3500
3501 * alloc.c (which_symbols): New function.
3502
3503 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3504
3505 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3506 line. (Bug#9903)
3507
3508 2011-10-29 Glenn Morris <rgm@gnu.org>
3509
3510 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3511 Not clear what it was for, and it causes various bugs. (Bug#9839)
3512
3513 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3514
3515 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3516 possible random value that matches one of those tested as
3517 condition to clear the mouse face.
3518
3519 2011-10-28 Chong Yidong <cyd@gnu.org>
3520
3521 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3522
3523 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3524
3525 * window.c (make_window): Initialize phys_cursor_on_p.
3526
3527 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3528
3529 * lisp.h (struct Lisp_Symbol): Update comments.
3530
3531 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3532
3533 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3534
3535 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3536
3537 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3538 <oslsachem@gmail.com> for helping to debug this.
3539
3540 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3541 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3542 (g_b_init_get_glyph_outline_w): New static variables.
3543 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3544 (GetGlyphOutlineW_Proc): New typedefs.
3545 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3546 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3547 New functions.
3548 (w32font_open_internal, compute_metrics):
3549 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3550 instead of calling the "wide" APIs directly.
3551
3552 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3553
3554 * w32.h (syms_of_w32font): Add prototype.
3555
3556 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3557
3558 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3559 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3560 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3561 (Fmove_to_window_line): Doc fix.
3562
3563 2011-10-27 Chong Yidong <cyd@gnu.org>
3564
3565 * process.c (make_process): Set gnutls_state to NULL.
3566
3567 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3568 non-NULL, regardless of GNUTLS_INITSTAGE.
3569 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3570 an error. Set process slots as soon as we allocate them.
3571
3572 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3573
3574 2011-10-27 Chong Yidong <cyd@gnu.org>
3575
3576 * gnutls.c (emacs_gnutls_deinit): New function.
3577 Deallocate credentials structures as well as calling gnutls_deinit.
3578 (Fgnutls_deinit, Fgnutls_boot): Use it.
3579
3580 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3581 (deactivate_process): Call emacs_gnutls_deinit.
3582
3583 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3584
3585 * image.c (x_create_x_image_and_pixmap):
3586 * w32.c (sys_rename, w32_delayed_load):
3587 * w32font.c (fill_in_logfont):
3588 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3589
3590 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3591
3592 * w32fns.c (w32_default_color_map): New function,
3593 extracted from Fw32_default_color_map.
3594 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3595
3596 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3597
3598 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3599
3600 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3601
3602 * keyboard.c (test_undefined): New function (bug#9751).
3603 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3604
3605 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3606
3607 * sysdep.c (init_sys_modes): Fix the check for the controlling
3608 terminal (Bug#6649).
3609
3610 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3611
3612 * dispextern.h (struct bidi_it): New member next_en_type.
3613
3614 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3615 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3616 current character, check also for next_en_type being WEAK_EN.
3617 (bidi_resolve_weak): Don't enter the expensive loop if the current
3618 position is before next_en_pos. Record the bidi type of the first
3619 non-ET, non-BN character we find, in addition to its position.
3620 (bidi_level_of_next_char): Invalidate next_en_type when
3621 next_en_pos is over-stepped.
3622
3623 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3624
3625 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3626 * editfns.c: Rewrite current-time-zone so that it invokes
3627 the equivalent of (format-time-string "%Z") to get the time zone name.
3628 This fixes a bug when the time zone name contains characters that
3629 need converting from the system time locale to Emacs internal format.
3630 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3631 that patch fixed format-time-string to do the conversion, but
3632 I forgot to fix current-time-zone.
3633 (format_time_string): New function, containing most of
3634 what Fformat_time_string used to contain.
3635 (Fformat_time_string): Rewrite in terms of format_time_string.
3636 This doesn't change this function's behavior.
3637 (current-time-zone): Rewrite to use format_time_string.
3638 This fixes the bug reported by Michael Schierl in
3639 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3640 Jason Rumney's 2007-06-07 change worked around this bug, but
3641 didn't fix it.
3642 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3643
3644 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3645
3646 * xdisp.c (start_display): If the character at POS is displayed
3647 via a display vector, reset IT->current.dpvec_index to zero.
3648 (try_window_reusing_current_matrix): If a line ends in a display
3649 vector or the next line starts in a display vector, continue
3650 redrawing the window even though the character position of
3651 start_row was reached.
3652 (Bug#9771, part 2)
3653
3654 2011-10-18 Chong Yidong <cyd@gnu.org>
3655
3656 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3657 with nobreak-char-display too.
3658
3659 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3660
3661 Fix part 3 of bug#9771.
3662 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3663 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3664 non-neutral characters if the current character is a paragraph
3665 separator (a.k.a. Newline). This avoids running the same
3666 expensive loop twice, once when we consume the preceding newline
3667 and the other time when the line actually needs to be displayed.
3668 Avoid the loop when we see neutrals on the base embedding level
3669 following a character whose directionality is the same as the
3670 paragraph's. This avoids running the expensive loop when a line
3671 ends in a long sequence of neutrals, like control characters.
3672 Add assertion against STRONG_AL type. Slightly rearrange code
3673 that determines the type of a neutral given the first non-neutral
3674 that follows it.
3675 (bidi_level_of_next_char): Set next_en_pos to zero when
3676 invalidating its info.
3677
3678 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3679
3680 * xdisp.c (push_display_prop): Determine whether to record string
3681 or buffer position by IT->string, not by IT->method. Allow
3682 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3683 (move_it_vertically_backward): Don't look for character position
3684 immediately after the newline when in a continuation line.
3685 (Bug#9771, part 1)
3686
3687 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3688
3689 * window.c (coordinates_in_window): Rewrite and delabelize
3690 vertical border check. (Bug#5357) (Bug#9618)
3691
3692 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3693
3694 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3695 errors in XSetWindowBorder (bug#9310).
3696
3697 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3698
3699 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3700 avoid crash when xmalloc overrun checking is enabled.
3701
3702 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3703
3704 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3705 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3706 cursor motion with <left> and <right> arrow keys.
3707
3708 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3709 some callers set that themselves.
3710
3711 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3712
3713 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3714 display string and the previous row comes from the same string and
3715 is empty. (Bug#9739) (Bug#9738)
3716
3717 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3718
3719 * doc.c (get_doc_string): Encode file name (bug#9735).
3720
3721 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3722
3723 * bidi.c (bidi_level_of_next_char):
3724 * xdisp.c (get_visually_first_element): Remove old incorrect
3725 comments regarding the Unicode Line Separator character.
3726
3727 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3728
3729 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3730
3731 * alloc.c (Fgc_status): Do not access beyond zombies array
3732 boundary if nzombies > MAX_ZOMBIES.
3733 * alloc.c (dump_zombies): Add missing format specifier.
3734
3735 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3738 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3739
3740 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3741 Some packages use them to denote characters with modifiers.
3742
3743 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3744
3745 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3746 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3747 matching a pp-number. Rename parameter var to var1.
3748
3749 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3750
3751 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3752
3753 2011-10-08 Glenn Morris <rgm@gnu.org>
3754
3755 * callint.c (Fcall_interactively): Give a more explicit error for the
3756 'c' case with a non-character input. (Bug#8479)
3757
3758 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3759
3760 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3761 lines.
3762 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3763 lines that are hscrolled on the left.
3764
3765 * dispnew.c (buffer_posn_from_coords): Account for a possible
3766 presence of header-line. (Bug#4426)
3767
3768 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3769
3770 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3771 Don't advertise functionality which we discourage or doesn't work.
3772
3773 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3774
3775 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3776 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3777 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3778 this makes Emacs dump core during garbage collection on rare
3779 occasions. sizeof is obviously inferior to offsetof here, so
3780 stick with offsetof.
3781 (GC_POINTER_ALIGNMENT): New macro.
3782 (mark_memory): Omit 3rd (offset) arg; caller changed.
3783 Don't assume EMACS_INT alignment is the same as pointer alignment.
3784
3785 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3786
3787 * keyboard.c (read_key_sequence_remapped): New var.
3788 (read_key_sequence): Compute remapping in the right buffer.
3789 (command_loop_1): Use read_key_sequence's remapping directly.
3790
3791 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3792
3793 * dired.c (file_name_completion): Don't expand file name.
3794 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3795 before checking file name handler.
3796
3797 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3798 they've been requested explicitly (bug#9591).
3799
3800 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3801
3802 * keymap.c (Fsingle_key_description): Use make_specified_string
3803 instead of build_string to build string from push_key_description.
3804 (Bug#5193)
3805
3806 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3809 This fixes a Y2038 bug on 64-bit hosts.
3810 * buffer.c (reset_buffer):
3811 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3812 (Fclear_buffer_auto_save_failure):
3813 Use 0, not -1, to represent an unset failure time, since time_t
3814 might not be signed.
3815
3816 Remove dependency on glibc malloc internals.
3817 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3818 Move back here from lisp.h, but with their new implementations.
3819 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3820 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3821 * charset.c (charset_table_init): New static var.
3822 (syms_of_charset): Use it instead of xmalloc. This removes a
3823 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3824 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3825 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3826 Move back to alloc.c.
3827 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3828 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3829
3830 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3831
3832 * nsterm.m (windowDidResize): Call x_set_window_size only when
3833 ns_in_resize is true. Otherwise set pixelwidth/height and
3834 call change_frame_size (Bug#9628).
3835
3836 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3837
3838 Port --enable-checking=all to Fedora 14 x86-64.
3839 * charset.c (syms_of_charset): Also account for glibc malloc's
3840 internal overhead when calculating the initial malloc maximum.
3841
3842 Port --enable-checking=all to Fedora 14 x86.
3843 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3844 Move to lisp.h.
3845 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3846 (overrun_check_realloc, overrun_check_free):
3847 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3848 That way, xmalloc returns a properly-aligned pointer even if
3849 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3850 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3851 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3852 into account when calculating the initial malloc maximum.
3853 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3854 Move here from alloc.c, so that charset.c can use it too.
3855 Properly align; the old code wasn't right for common 32-bit hosts
3856 when configured with --enable-checking=all.
3857 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3858 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3859
3860 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3861
3862 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3863 use EDOM.
3864
3865 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3866
3867 * xdisp.c (compute_display_string_end): If there's no display
3868 string at CHARPOS, return -1.
3869
3870 * bidi.c (bidi_fetch_char): When compute_display_string_end
3871 returns a negative value, treat the character as a normal
3872 character not covered by a display string. (Bug#9624)
3873
3874 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3875
3876 * lread.c (Fread_from_string): Fix typo in docstring.
3877
3878 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3879
3880 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3881 newline, reseat the iterator instead of bidi-iterating there one
3882 character at a time. (Bug#9610)
3883 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3884 TO_CHARPOS if the bidi iterator is at base embedding level.
3885
3886 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3887
3888 * lread.c (readevalloop): Use correct code for NBSP.
3889 (read1): Likewise. (Bug#9608)
3890
3891 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3892
3893 * dbusbind.c (Fdbus_register_signal): When service is not
3894 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3895
3896 2011-09-25 Glenn Morris <rgm@gnu.org>
3897
3898 * buffer.c (truncate-lines): Doc fix.
3899
3900 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3901
3902 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3903 (Fset_window_next_buffers): Doc fix.
3904
3905 2011-09-24 Glenn Morris <rgm@gnu.org>
3906
3907 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3908
3909 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 Fix minor problems found by static checking.
3912 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3913 * indent.c (Fvertical_motion): Fix == vs = typo.
3914
3915 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3916
3917 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3918 Default value is now t. Doc fix.
3919
3920 * indent.c (Fvertical_motion): Compute and apply the overshoot
3921 logic when moving up, not only when moving down. Fix the
3922 confusing name and values of the it_overshoot_expected variable;
3923 logic changes accordingly. (Bug#9254) (Bug#9549)
3924
3925 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3926 CHARPOS is covered by a display string which includes newlines.
3927 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3928 is covered by a display string with embedded newlines.
3929
3930 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3931
3932 * dbusbind.c (Fdbus_register_signal): Add match rule to
3933 Vdbus_registered_objects_table. (Bug#9581)
3934 (Fdbus_register_method, Vdbus_registered_objects_table):
3935 Fix docstring.
3936
3937 2011-09-24 Jim Meyering <meyering@redhat.com>
3938
3939 do not ignore write error for any output size
3940 The previous change was incomplete.
3941 While it makes emacs --batch detect the vast majority of stdout
3942 write failures, errors were still ignored whenever the output size is
3943 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3944 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3945 && echo FAIL: ignored write error
3946 FAIL: ignored write error
3947 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3948 && echo FAIL: ignored write error
3949 FAIL: ignored write error
3950 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3951
3952 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3953
3954 * emacs.c (Fkill_emacs): In noninteractive mode exit
3955 non-successfully if a write error occurred on stdout. (Bug#9574)
3956
3957 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3958
3959 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3960 the xassert test.
3961
3962 * dispextern.h (struct it): Update the comment documenting what
3963 can it->OBJECT be.
3964
3965 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3966
3967 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3968 a display string, extend search for cursor position to end of row.
3969 (find_row_edges): If the row ends in a newline from a display
3970 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3971 Handle the case of a display string with multiple newlines.
3972 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3973 non-empty line. Fixes confusing cursor motion with arrow keys at
3974 the beginning of a line that starts with whitespace.
3975
3976 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3977
3978 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3979 (bug#9493).
3980
3981 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3982
3983 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3984 boolean (Bug#9154).
3985
3986 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3987
3988 * xdisp.c (display_line): Record maximum and minimum buffer
3989 positions even if no glyphs were produced (e.g., by a zero-width
3990 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3991 buffer positions that will be removed from the glyph row because
3992 they don't fit.
3993 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3994 column is beyond frame width: don't subtract 1 "pixel" when
3995 computing width of the stretch.
3996 (reseat_at_next_visible_line_start): Undo the change made on
3997 2011-09-17 that saved paragraph information and restored it after
3998 the call to `reseat'. (Bug#9545)
3999
4000 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4001
4002 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4003 and turn window cursor on if cleared (Bug#9415).
4004
4005 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4006
4007 * search.c (boyer_moore): Take unibyte characters from pattern
4008 literally. (Bug#9458)
4009
4010 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4011
4012 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4013
4014 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 Fix minor problem found by static checking.
4017 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4018 initialized, to pacify gcc -Wuninitialized.
4019
4020 * fileio.c: Report proper errno when syscall falls.
4021 (Finsert_file_contents): Save and restore errno,
4022 so that report_file_error outputs the correct diagnostic.
4023 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4024
4025 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4026
4027 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4028
4029 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4030
4031 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4032 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4033
4034 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4035
4036 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4037 about the current paragraph and restore it after the call to reseat.
4038
4039 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4040 (bidi_find_paragraph_start): Search back for paragraph beginning
4041 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4042 (bidi_move_to_visually_next): Only trigger paragraph-related
4043 computations when the last character is a newline or at EOB, not
4044 just any NEUTRAL_B. (Bug#9470)
4045
4046 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4047 truncated lines if point is covered by a display string. (Bug#9524)
4048
4049 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4050
4051 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4052 (cons_to_x_long): New function.
4053 (lisp_data_to_selection_data): Use it. Correct the test for
4054 short-versus-long data; it was negated. Break out of vector
4055 loop, for efficiency, when a long datum is discovered.
4056
4057 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4058
4059 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4060
4061 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4062
4063 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4064 GCC PR/17406) by declaring this function with external scope.
4065
4066 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4067
4068 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4069 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4070
4071 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4072
4073 * editfns.c (Fformat): Correctly handle text properties on "%%".
4074
4075 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4076
4077 * xterm.c (x_draw_composite_glyph_string_foreground):
4078 * w32term.c (x_draw_composite_glyph_string_foreground):
4079 * term.c (encode_terminal_code):
4080 * composite.c (composition_update_it, get_composition_id):
4081 * xdisp.c (get_next_display_element)
4082 (fill_composite_glyph_string): Add comments about special meaning
4083 of TAB characters in a composition.
4084
4085 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4086
4087 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4088 This occurs when processing a multibyte format.
4089 Problem reported by Wolfgang Jenker.
4090
4091 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4092
4093 * xdisp.c (try_cursor_movement): Only check for exact match if
4094 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4095
4096 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4097
4098 Remove unused external symbols.
4099 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4100 * xdisp.c (calc_pixel_width_or_height): Now static.
4101 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4102 * indent.c (check_display_width):
4103 * w32term.c: Fix comment to match code.
4104 * xterm.c, xterm.h (x_catching_errors): Remove.
4105
4106 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4107
4108 * xselect.c: Use signed conversions more consistently (Bug#9498).
4109 (selection_data_to_lisp_data): Assume incoming selection data are
4110 signed integers, not unsigned. This is to be consistent with
4111 outgoing selection data, which was modified to use signed integers
4112 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4113 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4114 expects long, not unsigned long.
4115
4116 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4117
4118 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4119 computation of loop end. Reported by Johan Bockgård
4120 <bojohan@gnu.org>.
4121
4122 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4123
4124 * frame.c (Fother_visible_frames_p): Function deleted.
4125
4126 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4127
4128 * indent.c (compute_motion): Process display vector front to back
4129 rather than the other way around. (Bug#2496)
4130
4131 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4132
4133 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4134
4135 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4136
4137 * minibuf.c (Fread_from_minibuffer): Doc fix.
4138
4139 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4140
4141 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4142 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4143
4144 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4145
4146 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4147 value for non-existent files.
4148
4149 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4150
4151 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4152 set its "size" to -1. This will set the modtime_size field of
4153 the corresponding buffer to -1, which is what
4154 verify-visited-file-modtime expects for files that do not exist.
4155 (Bug#9139)
4156
4157 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4160 here ...
4161 * lisp.h: ... from here. push_key_description is no longer
4162 defined in keyboard.c, so its declaration should not be in
4163 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4164 logically belongs with push_key_description.
4165
4166 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 * buffer.h: Include <sys/types.h> instead of <time.h>.
4169 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4170 Problem reported by Herbert J. Skuhra.
4171
4172 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4173
4174 * xml.c (parse_region): Make the parsing work for
4175 non-comment-starting XML files again (bug#9144).
4176
4177 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4178
4179 * image.c (gif_load): Fix calculation of bottom and right corner.
4180 (Bug#9468)
4181
4182 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4183
4184 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4185 redisplay in small windows.
4186
4187 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4188
4189 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4190
4191 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4192
4193 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4194 Operate on live windows only.
4195
4196 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4197
4198 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4199
4200 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4201
4202 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4203 only under bidi iteration.
4204
4205 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4206
4207 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4208
4209 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4210
4211 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4212 Without this fix, the command to link temacs failed due to an
4213 undefined symbol __builtin_isnan. This is because
4214 /usr/include/iso/math_c99.h #defines isnan(x) to
4215 __builtin_isnan(x), but the bundled gcc, which identifies itself
4216 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4217 a __builtin_isnan.
4218 * floatfns.c (isnan): #undef, and then #define to a clone of
4219 what's in data.c.
4220 (Fisnan): Always define, since it's always available now.
4221 (syms_of_floatfns): Always define isnan at the Lisp level.
4222
4223 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4224
4225 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4226
4227 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4228
4229 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4230 The previous code assumed that file offsets (off_t values) fit in
4231 EMACS_INT variables, which is not true on typical 32-bit hosts.
4232 The code messed up by falsely reporting buffer overflow in cases
4233 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4234 when "big" contains more than 2**29 bytes, even though this
4235 inserts just one byte and does not overflow the buffer.
4236 (Finsert_file_contents): Store file offsets as off_t
4237 values, not as EMACS_INT values. Check for overflow when
4238 converting between EMACS_INT and off_t. When checking for
4239 buffer overflow or for overlap, take the offsets into account.
4240 Don't use EMACS_INT for small values where int suffices.
4241 When checking for overlap, fix a typo: ZV was used where
4242 ZV_BYTE was intended.
4243 (Fwrite_region): Don't assume off_t fits into 'long'.
4244 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4245
4246 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4247
4248 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4249
4250 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4251
4252 sprintf-related integer and memory overflow issues (Bug#9412).
4253
4254 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4255 (esprintf, exprintf, evxprintf): New functions.
4256 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4257 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4258 (modify_event_symbol): Do not assume that the length of
4259 name_alist_or_stem is safe to alloca and fits in int.
4260 (Fexecute_extended_command): Likewise for function name and binding.
4261 (Frecursion_depth): Wrap around reliably on integer overflow.
4262 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4263 since some callers pass EMACS_INT values.
4264 (Fsingle_key_description): Don't crash if symbol name contains more
4265 than MAX_ALLOCA bytes.
4266 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4267 (get_minibuffer): Arg is now EMACS_INT, not int.
4268 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4269 (esprintf, exprintf, evxprintf): New decls.
4270 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4271
4272 * dbusbind.c (signature_cat): New function.
4273 (xd_signature, Fdbus_register_signal):
4274 Do not overrun buffer; instead, report string overflow.
4275
4276 * dispnew.c (add_window_display_history): Don't overrun buffer.
4277 Truncate instead; this is OK since it's just a log.
4278
4279 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4280 even if the time zone offset is outlandishly large.
4281 Don't mishandle offset == INT_MIN.
4282
4283 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4284 when creating daemon; the previous buffer-overflow check was incorrect.
4285
4286 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4287 which has the guts of the old verror function.
4288
4289 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4290 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4291
4292 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4293 (font_unparse_xlfd): Don't blindly alloca long strings.
4294 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4295 fits in int, when using sprintf. Use single snprintf to count
4296 length of string rather than counting it via multiple sprintfs;
4297 that's simpler and more reliable.
4298 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4299 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4300 sprintf, in case result does not fit in int.
4301
4302 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4303 (fontset_from_font): Print it.
4304
4305 * frame.c (tty_frame_count): Now printmax_t, not int.
4306 (make_terminal_frame, set_term_frame_name): Print it.
4307 (x_report_frame_params): In X, window IDs are unsigned long,
4308 not signed long, so print them as unsigned.
4309 (validate_x_resource_name): Check for implausibly long names,
4310 and don't assume name length fits in 'int'.
4311 (x_get_resource_string): Don't blindly alloca invocation name;
4312 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4313 not fit in int.
4314
4315 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4316 (xg_check_special_colors, xg_set_geometry):
4317 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4318
4319 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4320 Use esprintf, not sprintf, in case result does not fit in int.
4321
4322 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4323 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4324 it as a large positive number.
4325 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4326 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4327
4328 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4329 in case result does not fit in int.
4330
4331 * print.c (float_to_string): Detect width overflow more reliably.
4332 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4333 buffer overrun. Don't assume list length fits in 'int'. Treat
4334 print length of 0 as 0, not as infinity; to be consistent with other
4335 uses of print length in this function. Don't overflow print length
4336 index. Don't assume hash table size fits in 'long', or that
4337 vectorlike size fits in 'unsigned long'.
4338
4339 * process.c (make_process): Use printmax_t, not int, to format
4340 process-name gensyms.
4341
4342 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4343
4344 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4345 to avoid potential buffer overrun.
4346
4347 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4348 if X resource line is longer than 512 bytes.
4349
4350 * xfns.c (x_window): Make sprintf buffer a bit bigger
4351 to avoid potential buffer overrun.
4352
4353 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4354
4355 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4356
4357 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4358
4359 Integer overflow fixes for scrolling, etc.
4360 Without these, Emacs silently mishandles large integers sometimes.
4361 For example, "C-u 4294967297 M-x recenter" was treated as if
4362 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4363
4364 * xdisp.c (try_window_id): Check Emacs fixnum range before
4365 converting to 'int'.
4366
4367 * window.c (window_scroll_line_based, Frecenter):
4368 Check that an Emacs fixnum is in range before assigning it to 'int'.
4369 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4370 values converted from Emacs fixnums.
4371 (Frecenter): Don't wrap around a line count if it is out of 'int'
4372 range; instead, treat it as an extreme value.
4373 (Fset_window_configuration, compare_window_configurations):
4374 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4375
4376 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4377 that can exceed INT_MAX. Check that EMACS_INT value is in range
4378 before assigning it to the (possibly-narrower) index.
4379 (match_limit): Don't assume that a fixnum can fit in 'int'.
4380
4381 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4382 exceed INT_MAX.
4383
4384 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4385 (Fvertical_motion): Don't wrap around LINES values that don't fit
4386 in 'int'. Instead, treat them as extreme values. This is good
4387 enough for windows, which can't have more than INT_MAX lines anyway.
4388
4389 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4390
4391 * Require libxml/parser.h to avoid compilation warning.
4392
4393 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4394
4395 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4396 since this reportedly can destroy thread storage.
4397
4398 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4399
4400 * syntax.c (find_defun_start): Update all cache variables if
4401 exiting early (Bug#9401).
4402
4403 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4404
4405 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4406
4407 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4408 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4409 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4410
4411 * term.c (tty_append_glyph): New function.
4412 (produce_stretch_glyph): Static function and its prototype deleted.
4413
4414 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4415 Add prototypes.
4416
4417 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4420 when checking :margin (Bug#9390).
4421 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4422 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4423 so that the name doesn't mislead. All uses changed.
4424
4425 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4426
4427 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4428 set_tty_hooks.
4429
4430 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4431
4432 * xdisp.c (move_it_to): Don't bail out early when reaching
4433 position beyond to_charpos, if we are scanning backwards.
4434 (move_it_vertically_backward): When DY == 0, make sure we get to
4435 the first character in the line after the newline.
4436
4437 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4438
4439 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4440 (ccl_driver): Do not generate an out-of-range pointer.
4441 (Fccl_execute_on_string): Remove unnecessary check for
4442 integer overflow, noted by Stefan Monnier in
4443 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4444 Remove a FIXME that didn't need fixing.
4445 Simplify the newly-introduced buffer reallocation code.
4446
4447 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4448
4449 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4450
4451 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4452
4453 Integer and memory overflow issues (Bug#9196).
4454
4455 * doc.c (get_doc_string): Rework so that
4456 get_doc_string_buffer_size is the actual buffer size, rather than
4457 being 1 less than the actual buffer size; this makes xpalloc more
4458 convenient.
4459
4460 * image.c (x_allocate_bitmap_record, cache_image):
4461 * xselect.c (Fx_register_dnd_atom):
4462 Simplify previous changes by using xpalloc.
4463
4464 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4465 since either will do and ptrdiff_t is convenient with xpalloc.
4466
4467 * charset.c (charset_table_size)
4468 (struct charset_sort_data.priority): Now ptrdiff_t.
4469 (charset_compare): Don't overflow if priorities differ greatly.
4470 (Fsort_charsets): Don't assume list length fits in int.
4471 Check for size-calculation overflow when allocating sort data.
4472 (syms_of_charset): Allocate an initial charset table that is
4473 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4474
4475 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4476
4477 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4478 The actual value is always <= INT_MAX, and leaving it unsigned made
4479 overflow checking harder.
4480
4481 * dispextern.h (struct glyph_matrix.rows_allocated)
4482 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4483 with xpalloc. The values are still always <= INT_MAX.
4484
4485 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4486
4487 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4488 (SAFE_NALLOCA): New macro.
4489
4490 * region-cache.c (struct boundary.pos, find_cache_boundary)
4491 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4492 (set_cache_region, invalidate_region_cache)
4493 (revalidate_region_cache, know_region_cache, region_cache_forward)
4494 (region_cache_backward, pp_cache):
4495 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4496 so that ptrdiff_t * can be passed to xpalloc.
4497 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4498 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4499 (pp_cache): Don't assume cache_len fits in int.
4500 * region-cache.h: Adjust extern decls to match.
4501
4502 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4503 EMACS_INT, since either will do, for xpalloc.
4504
4505 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4506 (xnmalloc, xnrealloc, xpalloc): New functions.
4507
4508 * bidi.c (bidi_shelve_header_size): New constant.
4509 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4510 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4511
4512 * bidi.c (bidi_cache_shrink):
4513 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4514 (overlay_strings):
4515 Don't update size of array until after memory allocation succeeds,
4516 because xmalloc/xrealloc may not return.
4517 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4518 now that we have proper integer overflow checking.
4519 (record_overlay_string, overlay_strings): Catch overflows when
4520 calculating size of overlay_str_buf.
4521
4522 * callproc.c (Fcall_process): Check for size overflow when
4523 calculating size of args2.
4524 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4525 Normally we prefer signed values, but sticking with ptrdiff_t would
4526 require adding more-complicated checks.
4527
4528 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4529 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4530 Redo buffer-overflow calculations to avoid integer overflow.
4531 Add a FIXME comment where memory seems to be over-allocated.
4532
4533 * character.c (Fstring): Check for size-calculation overflow.
4534
4535 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4536 unnecessary integer overflow. Check for size overflow.
4537 (encode_coding_object): Don't update size until xmalloc succeeds.
4538
4539 * composite.c (get_composition_id): Check for overflow in glyph
4540 length calculations.
4541
4542 Integer and memory overflow fixes for display code.
4543 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4544 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4545 (scrolling_window): Check for overflow in size calculations.
4546 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4547 Don't assume glyph table len fits in int.
4548 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4549 (row_table_size): Now ptrdiff_t, not int.
4550 (scrolling_window): Avoid overflow in size calculations.
4551 Don't update size until allocation succeeds.
4552 * fns.c (concat): Check for overflow in size calculations.
4553 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4554 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4555 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4556
4557 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4558 (get_doc_string): Check for size calculation overflow.
4559 Don't update size until allocation succeeds.
4560 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4561 EMACS_INT, where ptrdiff_t will do.
4562 (Fsubstitute_command_keys): Check for string overflow.
4563
4564 * editfns.c (set_time_zone_rule): Don't assume environment length
4565 fits in int.
4566 (message_length): Now ptrdiff_t, not int.
4567 (Fmessage_box): Don't update size until allocation succeeds.
4568 Don't assume message length fits in int.
4569 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4570
4571 * emacs.c (main): Do not reallocate argv, since there is a null at
4572 the end that can be overwritten, and this way there's no need to
4573 worry about size-calculation overflow.
4574 (sort_args): Check for size-calculation overflow.
4575
4576 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4577 alloc succeeds.
4578 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4579
4580 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4581 (x_set_scroll_bar_width, x_figure_window_size):
4582 Check for integer overflow.
4583 (x_set_alpha): Do not assume XINT fits in int.
4584
4585 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4586 This is for the members text_lines, text_cols, total_lines, total_cols,
4587 where the system imposes an 'int' limit.
4588
4589 * fringe.c (Fdefine_fringe_bitmap):
4590 Don't update size until alloc works.
4591
4592 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4593 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4594
4595 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4596 Check for size-calculation overflow.
4597 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4598 do, as we prefer signed integers.
4599 (id_to_widget.max_size, id_to_widget.used)
4600 (xg_store_widget_in_map, xg_remove_widget_from_map)
4601 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4602 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4603 Use and return ptrdiff_t, not int.
4604 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4605 * gtkutil.h: Change prototypes to match the above.
4606
4607 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4608 are duplicate now that they've been promoted to lisp.h.
4609 (x_allocate_bitmap_record, x_alloc_image_color)
4610 (make_image_cache, cache_image, xpm_load):
4611 Don't update size until alloc is done.
4612 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4613 (x_detect_edges):
4614 Check for size calculation overflow.
4615 (ct_colors_allocated_max): New constant.
4616 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4617 overflow.
4618
4619 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4620 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4621 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4622 Use ptrdiff_t, not int, to count maps.
4623 (read_char_minibuf_menu_prompt): Check for overflow in size
4624 calculations. Don't update size until allocation succeeds.
4625 Redo calculations to avoid overflow.
4626 * keyboard.h: Change prototypes to match the above.
4627
4628 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4629 to count maps.
4630 (current_minor_maps): Check for size calculation overflow.
4631 * keymap.h: Change prototypes to match the above.
4632
4633 * lread.c (read1, init_obarray): Don't update size until alloc done.
4634
4635 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4636 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4637
4638 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4639 Now ptrdiff_t, not int.
4640 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4641 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4642
4643 * process.c (Fnetwork_interface_list): Check for overflow
4644 in size calculation.
4645
4646 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4647
4648 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4649 overflow. Don't bother calling xmalloc when xrealloc will do.
4650
4651 * search.c (Freplace_match): Check for size calculation overflow.
4652 (Fset_match_data): Don't assume list lengths fit in 'int'.
4653
4654 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4655 for command line length. Do not attempt to address one before the
4656 beginning of an array, as that's not portable.
4657
4658 * term.c (max_frame_lines): Remove; unused.
4659 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4660 not int.
4661 (encode_terminal_code, calculate_costs): Check for size
4662 calculation overflow.
4663 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4664 table lengths and related sizes. Don't update size until alloc
4665 done. Redo calculations to avoid overflow.
4666 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4667
4668 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4669 subtracting pointers.
4670 (gobble_line): Check for overflow more carefully. Don't update size
4671 until alloc done.
4672
4673 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4674 Don't update size until alloc done.
4675 Redo size calculations to avoid overflow.
4676 Check for size calculation overflow.
4677 (main) [DEBUG]: Fix typo in invoking tparam1.
4678
4679 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4680 Use ptrdiff_t, not int, for sizes.
4681 (store_mode_line_noprop_char): Don't update size until alloc done.
4682
4683 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4684 Use ptrdiff_t, not int, for sizes.
4685 (Finternal_make_lisp_face, cache_face):
4686 Check for size calculation overflow.
4687 (cache_face): Treat size calculation overflows as if they were
4688 memory exhaustion (the usual treatment), rather than aborting.
4689
4690 * xfns.c (x_encode_text, x_set_name_internal)
4691 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4692 sizes, since they can exceed INT_MAX in size. Check for size
4693 calculation overflow.
4694
4695 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4696 (xg_select): Check for size calculation overflow.
4697 Don't update size until alloc done.
4698
4699 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4700 as sprintf is limited to int lengths.
4701
4702 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4703 (X_LONG_MIN): New macros.
4704 Use them to make the following changes clearer.
4705 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4706 This change doesn't affect the value now, but it may help remind
4707 future maintainers not to raise the value too much later.
4708 (SELECTION_QUANTUM): Remove, replacing with ...
4709 (selection_quantum): ... new function, which avoids overflow.
4710 All uses changed.
4711 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4712 assumption that selection length fits in 'int'.
4713 (x_reply_selection_request, x_handle_selection_request)
4714 (x_get_window_property, receive_incremental_selection)
4715 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4716 (lisp_data_to_selection_data, clean_local_selection_data):
4717 Use ptrdiff_t, not int, to record length of selection.
4718 (x_reply_selection_request, x_get_window_property)
4719 (receive_incremental_selection, x_property_data_to_lisp):
4720 Redo calculations to avoid overflow.
4721 (x_reply_selection_request): When sending hint, ceiling it at
4722 X_LONG_MAX rather than relying on wraparound overflow to send
4723 something.
4724 (x_get_window_property, receive_incremental_selection)
4725 (lisp_data_to_selection_data, x_property_data_to_lisp):
4726 Check for size-calculation overflow.
4727 (x_get_window_property, receive_incremental_selection)
4728 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4729 Don't store size until memory allocation succeeds.
4730 (x_get_window_property): Plug memory leak on memory exhaustion.
4731 Don't double-block input; malloc is safe here. Don't assume 2**34
4732 - 4 fits in unsigned long. Add an xassert to check
4733 XGetWindowProperty overflow. Be more careful about overflow
4734 calculations, and distinguish size from memory overflow better.
4735 (receive_incremental_selection): When tracing, don't assume
4736 unsigned int is less than INT_MAX.
4737 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4738 harmful) conversions of unsigned short to int.
4739 (lisp_data_to_selection_data): Don't assume that integers
4740 in the range -65535 through -1 fit in an X unsigned short.
4741 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4742 result parameters unless successful. Rely on cons_to_unsigned
4743 to report problems with elements; the old code wasn't right anyway.
4744 (x_check_property_data): Check for int overflow; we cannot use
4745 a wider type due to X limits.
4746 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4747
4748 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4749
4750 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4751 (x_term_init): Check for size calculation overflow.
4752 (x_color_cells): Don't store size until memory allocation succeeds.
4753 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4754 Don't assume alloca size is less than MAX_ALLOCA.
4755 (x_term_init): Don't assume length fits in int (sprintf is limited
4756 to int size).
4757
4758 Use ptrdiff_t for composition IDs.
4759 * character.c (lisp_string_width):
4760 * composite.c (composition_table_size, n_compositions)
4761 (get_composition_id, composition_gstring_from_id):
4762 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4763 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4764 * window.c (Frecenter):
4765 Use ptrdiff_t, not int, for composition IDs.
4766 * composite.c (get_composition_id): Check for integer overflow.
4767 * composite.h: Adjust prototypes to match the above changes.
4768
4769 Use ptrdiff_t for hash table indexes.
4770 * category.c (hash_get_category_set):
4771 * ccl.c (ccl_driver):
4772 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4773 * coding.c (coding_system_charset_list, detect_coding_system):
4774 * coding.h (struct coding_system.id):
4775 * composite.c (get_composition_id, gstring_lookup_cache):
4776 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4777 * image.c (xpm_get_color_table_h):
4778 * lisp.h (hash_lookup, hash_put):
4779 * minibuf.c (Ftest_completion):
4780 Use ptrdiff_t for hash table indexes, not int (which is too
4781 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4782 32-bit --with-wide-int hosts).
4783
4784 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4785 Add a FIXME comment about memory leaks.
4786 (syms_of_charset): Don't assume xmalloc returns.
4787
4788 Don't assume that stated character widths fit in int.
4789 * character.c (Fchar_width, c_string_width, lisp_string_width):
4790 * character.h (CHAR_WIDTH):
4791 * indent.c (MULTIBYTE_BYTES_WIDTH):
4792 Use sanitize_char_width to avoid undefined and/or bad behavior
4793 with outlandish widths.
4794 * character.h (sanitize_tab_width): Rename from sanitize_width,
4795 now that we have two such functions. All uses changed.
4796 (sanitize_char_width): New inline function.
4797
4798 Don't assume that tab-width fits in int.
4799 * character.h (sanitize_width): New inline function.
4800 (SANE_TAB_WIDTH): New macro.
4801 (ASCII_CHAR_WIDTH): Use it.
4802 * indent.c (sane_tab_width): Remove. All uses replaced by
4803 SANE_TAB_WIDTH (current_buffer).
4804 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4805
4806 * fileio.c: Integer overflow issues with file modes.
4807 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4808
4809 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4810 Remove unreachable code.
4811 (read_hex, load_charset_map_from_file): Check for integer overflow.
4812
4813 * xterm.c: Don't go over XClientMessageEvent limit.
4814 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4815 (x_send_scroll_bar_event): Likewise. Check that the size does not
4816 exceed limits imposed by XClientMessageEvent, as well as the usual
4817 ptrdiff_t and size_t limits.
4818
4819 * keyboard.c: Overflow, signedness and related fixes.
4820 (make_lispy_movement): Use same integer type in forward decl
4821 that is used in the definition.
4822 (read_key_sequence, keyremap_step):
4823 Change bufsize argument back to int, undoing my 2011-03-30 change.
4824 We prefer signed types, and int is wide enough here.
4825 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4826 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4827 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4828 length, not size_t. Use ptrdiff_t for index, not int.
4829 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4830 possibility of integer overflow.
4831
4832 Overflow, signedness and related fixes for images.
4833
4834 * dispextern.h (struct it.stack[0].u.image.image_id)
4835 (struct_it.image_id, struct image.id, struct image_cache.size)
4836 (struct image_cache.used, struct image_cache.ref_count):
4837 * gtkutil.c (update_frame_tool_bar):
4838 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4839 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4840 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4841 * nsmenu.m (update_frame_tool_bar):
4842 * xdisp.c (calc_pixel_width_or_height):
4843 * xfns.c (image_cache_refcount):
4844 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4845 on typical 64-bit hosts.
4846
4847 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4848 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4849 Omit unnecessary casts to int.
4850 (parse_image_spec): Check that integers fall into 'int' range
4851 when the callers expect that.
4852 (image_ascent): Redo ascent calculation to avoid int overflow.
4853 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4854 (lookup_image): Remove unnecessary tests.
4855 (xbm_image_p): Locals are now of int, not EMACS_INT,
4856 since parse_image_check makes sure they fit into int.
4857 (png_load, gif_load, svg_load_image):
4858 Prefer int to unsigned where either will do.
4859 (tiff_handler): New function, combining the cores of the
4860 old tiff_error_handler and tiff_warning_handler.
4861 This function is rewritten to use vsnprintf and thereby avoid
4862 stack buffer overflows. It uses only the features of vsnprintf
4863 that are common to both POSIX and native Microsoft.
4864 (tiff_error_handler, tiff_warning_handler): Use it.
4865 (tiff_load, gif_load, imagemagick_load_image):
4866 Don't assume :index value fits in 'int'.
4867 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4868 (imagemagick_load_image): Check that crop parameters fit into
4869 the integer types that MagickCropImage accepts. Don't assume
4870 Vimagemagick_render_type has a nonnegative value. Don't assume
4871 size_t fits in 'long'.
4872 (gs_load): Use printmax_t to print the widest integers possible.
4873 Check for integer overflow when computing image height and width.
4874
4875 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4876
4877 * xdisp.c (redisplay_window): Don't force window start if point
4878 will be invisible in the resulting window. (Bug#9324)
4879
4880 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4881
4882 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4883 the display spec is of the form `(space ...)'.
4884 (handle_display_spec): Return the value returned by
4885 handle_single_display_spec, not just 1 or zero.
4886 (handle_single_display_spec): If the display spec is of the form
4887 `(space ...)', and specifies display in the text area, return 2
4888 rather than 1.
4889 (try_cursor_movement): Check for the need to scroll more
4890 accurately, and prefer exact match for point under bidi.
4891 Don't advance `row' beyond the last row of the window.
4892
4893 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4894 into disp_prop; all users changed.
4895
4896 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4897 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4898 for the text covered by the display property.
4899
4900 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4901
4902 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4903 Change return value to nil.
4904 (Frecord_buffer): Delete unused function.
4905
4906 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4907
4908 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4909 buffers, return left-to-right.
4910 (set_cursor_from_row): Consider candidate row a win if its glyph
4911 represents a newline and point is on that newline. Fixes cursor
4912 positioning on the newline at EOL of R2L text within L2R
4913 paragraph, and vice versa.
4914 (try_cursor_movement): Check continued rows, in addition to
4915 continuation rows. Fixes unwarranted scroll when point enters a
4916 continued line of R2L text within an L2R paragraph, or vice versa.
4917 (cursor_row_p): Consider the case of point being equal to
4918 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4919 from the end of a short line to the beginning of a continued line
4920 of R2L text within L2R paragraph.
4921 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4922 composed characters.
4923
4924 * bidi.c (bidi_check_type): Use xassert.
4925 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4926 members.
4927
4928 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4929
4930 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4931 a character.
4932
4933 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4934
4935 * nsfont.m (ns_otf_to_script): Fix typo.
4936
4937 2011-08-22 Kenichi Handa <handa@m17n.org>
4938
4939 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4940 extra slot even if the purpose is char-code-property-table.
4941
4942 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4943
4944 * xdisp.c (redisplay_window): When computing centering_position,
4945 account for the height of the header line. (Bug#8874)
4946
4947 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4948 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4949 candidate is selected by the mouse, and that candidate has a
4950 composed character under the mouse.
4951
4952 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4953 coordinates reported by pos-visible-in-window-p for a composed
4954 character in column zero.
4955
4956 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4957
4958 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4959
4960 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4961
4962 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4963 consider it a hit if to_charpos is anywhere in the range of the
4964 composed buffer positions.
4965
4966 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4967
4968 * image.c (gif_load): Don't assume that each subimage has the same
4969 dimensions as the base image. Handle disposal method that is
4970 "undefined" by the gif spec (Bug#9335).
4971
4972 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4973
4974 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4975 (Fcondition_case): Document `debug' symbol in error handler.
4976
4977 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4978
4979 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4980 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4981 from an Org mode buffer to a Speedbar frame.
4982
4983 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4984 a composition, take its buffer position from IT->cmp_it.charpos.
4985 Fixes cursor positioning at the beginning of a line that begins
4986 with a composed character.
4987
4988 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4989
4990 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4991 character bidirectional type, use STRONG_L instead. Fixes crashes
4992 in a buffer produced by `describe-categories'.
4993
4994 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4995 members before the level stack, so they would be saved and
4996 restored when copying iterator state. Fixes incorrect reordering
4997 around TABs covered by display properties.
4998
4999 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5000
5001 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5002
5003 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5004
5005 * eval.c (internal_condition_case, internal_condition_case_1)
5006 (internal_condition_case_2, internal_condition_case_n):
5007 Remove unnecessary aborts (Bug#9081).
5008
5009 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5010
5011 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5012 has no `load' handler, try opening the file locally. (Bug#9311)
5013
5014 2011-08-16 Ken Brown <kbrown@cornell.edu>
5015
5016 * gmalloc.c: Expand comment.
5017
5018 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5019
5020 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5021 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5022
5023 2011-08-16 Ken Brown <kbrown@cornell.edu>
5024
5025 Fix memory allocation problems in Cygwin build (Bug#9273).
5026
5027 * unexcw.c ( __malloc_initialized): Declare external variable.
5028 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5029
5030 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5031 New variables.
5032 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5033 dumped emacs.
5034 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5035 in the static heap.
5036 [CYGWIN] (special_realloc): New function.
5037 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5038 requests to realloc storage in the static heap.
5039
5040 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5041
5042 * bidi.c (bidi_initialize): Remove unused local.
5043
5044 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5045
5046 * bidimirror.h:
5047 * biditype.h: Remove file.
5048 * makefile.w32-in ($(BLD)/bidi.$(O)):
5049 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5050
5051 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5052
5053 * chartab.c: Improve commentary for the uniprop_table API.
5054
5055 * bidi.c (bidi_paragraph_init): Support zero value of
5056 bidi_ignore_explicit_marks_for_paragraph_level.
5057 (bidi_initialize): Use uniprop_table instead of including
5058 biditype.h and bidimirror.h.
5059
5060 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5061 coordinates of the iterator when restoring from ppos_it.
5062 (Bug#9296)
5063
5064 2011-08-14 Kenichi Handa <handa@m17n.org>
5065
5066 * process.c (create_process): Call setup_process_coding_systems
5067 after the pid of the process is set to -1 (Bug#8162).
5068
5069 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5070
5071 * xdisp.c (move_it_in_display_line_to): Don't invoke
5072 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5073 ppos_it. Fixes vertical cursor motion when line beginning is
5074 covered by an image. (Bug#9296)
5075
5076 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5077
5078 * nsterm.h (ns_run_ascript): Declare.
5079 (NSAPP_DATA2_RUNASSCRIPT): Define.
5080
5081 * nsfns.m (as_script, as_result, as_status): New static variables.
5082 (ns_run_ascript): New function.
5083 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5084 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5085 the event loop. Get status from as_status (Bug#7276).
5086
5087 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5088 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5089 the event loop (Bug#7276).
5090
5091 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5092
5093 * gnutls.c (QCgnutls_bootprop_priority)
5094 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5095 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5096 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5097 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5098 (QCgnutls_bootprop_verify_hostname_error)
5099 (QCgnutls_bootprop_callbacks_verify): Rename from
5100 Qgnutls_bootprop_..., all uses changed.
5101
5102 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5103 uses changed.
5104
5105 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5106
5107 * xfaces.c (Qframe_set_background_mode): Now static.
5108 * dispextern.h (Qframe_set_background_mode): Remove decl.
5109
5110 * process.c (Fnetwork_interface_info): Declare local only if needed.
5111
5112 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5113
5114 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5115 (Fnetwork_interface_list): Allocate in increments of bytes instead
5116 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5117 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5118 sockaddr.
5119 (struct ifflag_def): notrailers is smart on OSX.
5120 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5121 Get hardware address with getifaddrs if available.
5122
5123 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5124
5125 * xdisp.c (iterate_out_of_display_property): xassert that
5126 IT->position is set to within IT->object's boundaries. Break from
5127 the loop as soon as EOB is reached; avoids infloops in redisplay
5128 when IT->position is set up wrongly due to some bug.
5129 Set IT->current to match the bidi iterator unconditionally.
5130 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5131 entry. Force push_it to save on the stack the current
5132 buffer/string position, to be restored by pop_it. Fix flags in
5133 the iterator structure wrt the object coming from a display
5134 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5135 properties. (Bug#9284)
5136
5137 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5138
5139 * fontset.c (fontset_get_font_group): Add proper type checks.
5140 (Bug#9172)
5141
5142 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5143
5144 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5145 and LC_VERSION_MIN_MACOSX.
5146 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5147 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5148
5149 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5150
5151 * xdisp.c (forward_to_next_line_start): Allow to use the
5152 no-display-properties-and-no-overlays under bidi display.
5153 Set disp_pos in the bidi iterator to avoid searches for display
5154 properties and overlays.
5155
5156 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5157
5158 * editfns.c (Fset_time_zone_rule): Document relationship with the
5159 setenv function.
5160
5161 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5162 the font entity extracted from the cache (Bug#8109).
5163
5164 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5165
5166 * composite.c (autocmp_chars): Don't reset point. That is done by
5167 restore_point_unwind (Bug#5984).
5168
5169 2011-08-07 Juri Linkov <juri@jurta.org>
5170
5171 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5172 to show the arg `TIME' instead of `TIMEVAL'.
5173
5174 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5175
5176 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5177 display property strides EOL and includes a newline, as in
5178 longlines-mode. (Bug#9254)
5179 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5180 word-wrap under bidirectional display. (Bug#9224)
5181
5182 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5183 is non-zero, even if the data buffer is NULL. Fixes a crash in
5184 vertical-motion with longlines-mode. (Bug#9254)
5185
5186 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5187
5188 * bidi.c <bidi_cache_total_alloc>: Now static.
5189 (bidi_initialize): Initialize bidi_cache_total_alloc.
5190
5191 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5192 cache. (Bug#9221)
5193
5194 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5195 amount allocated this far in `bidi_cache_total_alloc'.
5196 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5197 non-zero, only free the data buffer without restoring the cache
5198 contents. All callers changed.
5199
5200 * dispextern.h (bidi_unshelve_cache): Update prototype.
5201
5202 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5203 (move_it_in_display_line, move_it_to)
5204 (move_it_vertically_backward, move_it_by_lines): Replace the call
5205 to xfree to an equivalent call to bidi_unshelve_cache.
5206 (move_it_in_display_line_to): Fix logic of returning
5207 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5208
5209 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5210
5211 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5212 came from a string character with a `cursor' property. (Bug#9229)
5213
5214 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5215
5216 * Makefile.in (LIB_PTHREAD): New variable.
5217 (LIBES): Add LIB_PTHREAD (Bug#9216).
5218
5219 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5220 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5221
5222 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5223
5224 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5225
5226 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5227
5228 * xterm.c (x_find_topmost_parent): New function.
5229 (x_set_frame_alpha): Find topmost parent window with
5230 x_find_topmost_parent and set the property there also (bug#9181).
5231 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5232
5233 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5234
5235 * callproc.c (Fcall_process): Avoid vfork clobbering
5236 the local vars buffer, coding_systems, current_dir.
5237
5238 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5239
5240 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5241
5242 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5243
5244 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5245 so that it is not optimized away.
5246
5247 * xdisp.c (compute_display_string_pos): Remove unused local.
5248
5249 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5250
5251 Fix slow cursor motion and scrolling in large buffers with
5252 selective display, like Org Mode buffers. (Bug#9218)
5253
5254 * dispextern.h (struct bidi_it): New member disp_prop_p.
5255
5256 * xdisp.c: Remove one-slot cache of display string positions.
5257 (compute_display_string_pos): Accept an additional argument
5258 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5259 for a display string or property. If found, set DISP_PROP_P
5260 non-zero.
5261
5262 * bidi.c (bidi_fetch_char): Accept an additional argument
5263 DISP_PROP_P, and pass it to compute_display_string_pos.
5264 Only handle text covered by a display string if DISP_PROP_P is returned
5265 non-zero. All callers of bidi_fetch_char changed.
5266
5267 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5268
5269 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5270
5271 2010-12-03 Don March <don@ohspite.net>
5272
5273 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5274 last character M-[char] is translated to ESC [char] (bug#7541).
5275
5276 2011-08-02 Kenichi Handa <handa@m17n.org>
5277
5278 * lisp.h (uniprop_table): Extern it.
5279
5280 * chartab.c (uniprop_table): Make it non-static.
5281
5282 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5283
5284 * xdisp.c (forward_to_next_line_start): Accept additional argument
5285 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5286 on the newline.
5287 (reseat_at_next_visible_line_start): Use the bidi iterator state
5288 returned by forward_to_next_line_start to restore the state of
5289 it->bidi_it after backing up to previous newline. (Bug#9212)
5290
5291 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5292
5293 * regex.c (re_comp): Protoize.
5294 (re_exec): Fix return type.
5295 (regexec): Fix type of `ret'. (Bug#9203)
5296
5297 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5298
5299 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5300 This is needed if max-image-size is a floating-point number.
5301
5302 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5303
5304 * print.c (print_object): Print empty symbol as ##.
5305
5306 * lread.c (read1): Read ## as empty symbol.
5307
5308 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5309
5310 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5311 setting frame foreground color (Bug#9175).
5312 (x_set_background_color): Likewise.
5313
5314 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5315 contents (Bug#9176).
5316 (EmacsTooltip -init): Remove bezels and add shadows to
5317 tooltip windows.
5318
5319 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5320 or scroll bar (Bug#8470).
5321
5322 * nsfont.m (nsfont_open): Remove assignment to voffset and
5323 unnecessary vars hshink, expand, hd, full_height, min_height.
5324 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5325
5326 * nsterm.h (nsfont_info): Remove voffset field.
5327
5328 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5329
5330 Implement strike-through and overline on NextStep (Bug#8863).
5331
5332 * nsfont.m (nsfont_open): Use underline position provided by font,
5333 instead of hard-coded value of 2.
5334 (nsfont_draw): Call ns_draw_text_decoration instead.
5335
5336 * nsterm.h: Add declaration for ns_draw_text_decoration.
5337
5338 * nsterm.m (ns_draw_text_decoration): New function for drawing
5339 underline, overline, and strike-through.
5340 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5341 ns_draw_text_decoration. Change treatment of cursor drawing to
5342 accommodate underlining, etc.
5343
5344 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5345
5346 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5347 default.
5348
5349 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5350
5351 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5352 Without this fix, if a signal arrives just after memory fills up,
5353 'malloc' might be invoked reentrantly.
5354
5355 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5356 In other words, assume that every image size is allowed, on non-X
5357 hosts. This assumption is probably wrong, but it lets Emacs compile.
5358
5359 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5360
5361 * regex.c (re_iswctype): Convert return values to boolean.
5362
5363 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5364
5365 * xdisp.c (compute_display_string_pos): Don't use cached display
5366 string position if the buffer had its restriction changed.
5367 (Bug#9184)
5368
5369 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5370
5371 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5372
5373 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5374
5375 Integer signedness and overflow and related fixes. (Bug#9079)
5376
5377 * bidi.c: Integer size and overflow fixes.
5378 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5379 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5380 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5381 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5382 (bidi_find_other_level_edge):
5383 Use ptrdiff_t instead of EMACS_INT where either will do.
5384 This works better on 32-bit hosts configured --with-wide-int.
5385 (bidi_cache_ensure_space): Check for size-calculation overflow.
5386 Use % rather than repeated addition, for better worst-case speed.
5387 Don't set bidi_cache_size until after xrealloc returns, because it
5388 might not return.
5389 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5390 (bidi_cache_ensure_space): Also check that the bidi cache size
5391 does not exceed that of the largest Lisp string or buffer. See Eli
5392 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5393
5394 * alloc.c (__malloc_size_t): Remove.
5395 All uses replaced by size_t. See Andreas Schwab's note
5396 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5397
5398 * image.c: Improve checking for integer overflow.
5399 (check_image_size): Assume that f is nonnull, since
5400 it is always nonnull in practice. This is one less thing to
5401 worry about when checking for integer overflow later.
5402 (x_check_image_size): New function, which checks for integer
5403 overflow issues inside X.
5404 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5405 This removes the need for a memory_full check.
5406 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5407 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5408 (xbm_read_bitmap_data): Change locals back to 'int', since
5409 their values must fit in 'int'.
5410 (xpm_load_image, png_load, tiff_load):
5411 Invoke x_create_x_image_and_pixmap earlier,
5412 to avoid much needless work if the image is too large.
5413 (tiff_load): Treat overly large images as if
5414 x_create_x_image_and_pixmap failed, not as malloc failures.
5415 (gs_load): Use x_check_image_size.
5416
5417 * gtkutil.c: Omit integer casts.
5418 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5419 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5420
5421 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5422
5423 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5424 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5425 would wrongly return t on a 64-bit host.
5426
5427 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5428 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5429 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5430 and therefore cause GCC to emit a bogus diagnostic in some cases.
5431
5432 * image.c: Integer signedness and overflow and related fixes.
5433 This is not an exhaustive set of fixes, but it's time to
5434 record what I've got.
5435 (lookup_pixel_color, check_image_size): Remove redundant decls.
5436 (check_image_size): Don't assume that arbitrary EMACS_INT values
5437 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5438 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5439 (tiff_load, imagemagick_load_image):
5440 Check for overflow in size calculations.
5441 (x_create_x_image_and_pixmap): Remove unnecessary test for
5442 xmalloc returning NULL; that can't happen.
5443 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5444 (xpm_color_bucket): Use better integer hashing function.
5445 (xpm_cache_color): Don't possibly over-allocate memory.
5446 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5447 (gif_memory_source):
5448 Use ptrdiff_t, not int or size_t, to record sizes.
5449 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5450 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5451 either works, as we prefer signed integers.
5452 (tiff_read_from_memory, tiff_write_from_memory):
5453 Return tsize_t, not size_t, since that's what the TIFF API wants.
5454 (tiff_read_from_memory): Don't fail simply because the read would
5455 go past EOF; instead, return a short read.
5456 (tiff_load): Omit no-longer-needed casts.
5457 (Fimagemagick_types): Don't assume size fits into 'int'.
5458
5459 Improve hashing quality when configured --with-wide-int.
5460 * fns.c (hash_string): New function, taken from sxhash_string.
5461 Do not discard information about ASCII character case; this
5462 discarding is no longer needed.
5463 (sxhash-string): Use it. Change sig to match it. Caller changed.
5464 * lisp.h: Declare it.
5465 * lread.c (hash_string): Remove, since we now use fns.c's version.
5466 The fns.c version returns a wider integer if --with-wide-int is
5467 specified, so this should help the quality of the hashing a bit.
5468
5469 * emacs.c: Integer overflow minor fix.
5470 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5471 Define only if GNU_LINUX.
5472 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5473
5474 * dispnew.c: Integer signedness and overflow fixes.
5475 Remove unnecessary forward decls, that were a maintenance hassle.
5476 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5477 All uses changed.
5478 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5479 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5480 (prepare_desired_row, line_draw_cost):
5481 Use int, not unsigned, where either works.
5482 (save_current_matrix, restore_current_matrix):
5483 Use ptrdiff_t, not size_t, where either works.
5484 (init_display): Check for overflow more accurately, and without
5485 relying on undefined behavior.
5486
5487 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5488 Remove, replacing with the new symbols in lisp.h. All uses changed.
5489 * fileio.c (make_temp_name):
5490 * filelock.c (lock_file_1, lock_file):
5491 * xdisp.c (message_dolog):
5492 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5493 Use pMd etc. instead.
5494 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5495 replacing the pWIDE etc. symbols removed from editfns.c.
5496
5497 * keyboard.h (num_input_events): Now uintmax_t.
5498 This is (very slightly) less likely to mess up due to wraparound.
5499 All uses changed.
5500
5501 * buffer.c: Integer signedness fixes.
5502 (alloc_buffer_text, enlarge_buffer_text):
5503 Use ptrdiff_t rather than size_t when either will do, as we prefer
5504 signed integers.
5505
5506 * alloc.c: Integer signedness and overflow fixes.
5507 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5508 (__malloc_size_t): Default to size_t, not to int.
5509 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5510 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5511 Prefer ptrdiff_t to size_t when either would do, as we prefer
5512 signed integers.
5513 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5514 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5515 Now const. Initialize with values that are in range even if char
5516 is signed.
5517 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5518 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5519 These functions do the right thing with sizes > 2**32.
5520 (check_depth): Now ptrdiff_t, not int.
5521 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5522 Adjust to new way of storing sizes. Check for size overflow bugs
5523 in rest of code.
5524 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5525 slightly wrong anyway, as it missed one instance of
5526 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5527 (refill_memory_reserve): Omit needless cast to size_t.
5528 (mark_object_loop_halt): Mark as externally visible.
5529
5530 * xselect.c: Integer signedness and overflow fixes.
5531 (Fx_register_dnd_atom, x_handle_dnd_message):
5532 Use ptrdiff_t, not size_t, since we prefer signed.
5533 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5534 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5535 x_dnd_atoms_size and x_dnd_atoms_length.
5536
5537 * doprnt.c: Prefer signed to unsigned when either works.
5538 * eval.c (verror):
5539 * doprnt.c (doprnt):
5540 * lisp.h (doprnt):
5541 * xdisp.c (vmessage):
5542 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5543 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5544 prefer signed arithmetic to avoid comparison confusion.
5545 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5546 but is a bit tricky.
5547
5548 Assume freestanding C89 headers, string.h, stdlib.h.
5549 * data.c, doprnt.c, floatfns.c, print.c:
5550 Include float.h unconditionally.
5551 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5552 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5553 * regex.c: Likewise for stddef.h, string.h.
5554 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5555 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5556 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5557 (STDC_HEADERS): Remove obsolete defines.
5558 * sysdep.c: Include limits.h unconditionally.
5559
5560 Assume support for memcmp, memcpy, memmove, memset.
5561 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5562 * regex.c (memcmp, memcpy):
5563 Remove; we assume C89 now.
5564
5565 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5566 (__malloc_safe_bcopy): Remove; no longer needed.
5567
5568 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5569 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5570 well either way, and we prefer signed to unsigned.
5571
5572 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5573
5574 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5575 closes the connection while we're reading (bug#9182).
5576
5577 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5578
5579 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5580 are specified (Bug#9168).
5581
5582 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5583
5584 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5585 Found by GCC static checking and --with-wide-int on a 32-bit host.
5586
5587 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5588
5589 * xdisp.c (compute_display_string_pos): Fix logic of caching
5590 previous display string position. Initialize cached_prev_pos to
5591 -1. Fixes slow-down at the beginning of a buffer.
5592
5593 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5594
5595 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5596 for attrs[LFACE_FONTSET_INDEX].
5597
5598 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5599
5600 * xml.c (parse_region): Remove unused local
5601 that was recently introduced.
5602
5603 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5604
5605 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5606 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5607
5608 * xdisp.c (move_it_in_display_line_to): Record the best matching
5609 position for TO_CHARPOS while scanning the line, and restore it on
5610 exit if none of the characters scanned was an exact match.
5611 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5612 when exact match is impossible due to invisible text, and the
5613 lines are truncated.
5614
5615 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5616
5617 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5618 for OSX >= 10.7.
5619
5620 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5621
5622 Fix a significant slow-down of cursor motion with C-n, C-p,
5623 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5624 auto-repeat under bidi redisplay in fontified buffers.
5625 * xdisp.c (compute_stop_pos_backwards): New function.
5626 (next_element_from_buffer): Call compute_stop_pos_backwards to
5627 find a suitable prev_stop when we find ourselves before
5628 base_level_stop.
5629 (reseat): Don't look for prev_stop, as that could mean a very long
5630 run.
5631 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5632 <cached_disp_overlay_modiff>: Cache for last found display string
5633 position.
5634 (compute_display_string_pos): Return the cached position if asked
5635 about the same buffer in the same area of character positions, and
5636 the buffer wasn't changed since the time the display string
5637 position was cached.
5638
5639 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5640
5641 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5642 is an integer, which is important for empty lines. (Bug#9149)
5643
5644 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5645
5646 * frame.c (Fmodify_frame_parameters): In tty case, update the
5647 default face if necessary (Bug#4238).
5648
5649 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5650
5651 * editfns.c (Fstring_to_char): No need to explain what a character
5652 is in the docstring (Bug#6576).
5653
5654 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5655
5656 * xml.c (parse_region): Make sure we always return a tree.
5657
5658 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5659
5660 * xml.c (parse_region): If a document contains only comments,
5661 return that, too.
5662
5663 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5664
5665 * xml.c (make_dom): Return comments, too.
5666
5667 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5668
5669 Port to OpenBSD.
5670 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5671 and the surrounding thread.
5672 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5673 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5674 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5675 timer goes off.
5676 * s/openbsd.h (BROKEN_SIGIO): Define.
5677 * unexelf.c (unexec) [__OpenBSD__]:
5678 Don't update the .mdebug section of the Alpha COFF symbol table.
5679
5680 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5681
5682 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5683 (bug#8460).
5684
5685 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5686
5687 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5688 This fixes some race conditions on the permissions of any newly
5689 created file.
5690
5691 * alloc.c (valid_pointer_p): Use pipe, not open.
5692 This fixes some permissions issues when debugging.
5693
5694 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5695 If fchown fails to set both uid and gid, try to set just gid,
5696 as that is sometimes allowed. Adjust the file's mode to eliminate
5697 setuid or setgid bits that are inappropriate if fchown fails.
5698
5699 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5700
5701 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5702 to compare Lisp_Objects.
5703 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5704 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5705 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5706
5707 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5708
5709 * lread.c (read_integer): Unread even EOF character.
5710 (read1): Likewise. Properly record start position of symbol.
5711
5712 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5713 symbol character follows.
5714
5715 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5716
5717 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5718 This works around a problem with the previous change to Fcopy_file.
5719 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5720 and without this change, GCC might complain about discarding
5721 fchown's return value.
5722
5723 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5724
5725 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5726
5727 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5730
5731 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5732
5733 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5734 it's used from the C level.
5735
5736 * process.c: Use the same condition for POLL_FOR_INPUT in both
5737 keyboard.c and process.c (bug#1858).
5738
5739 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5740
5741 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5742 (Fgnutls_boot): Use it.
5743
5744 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5745
5746 * doc.c (Fsubstitute_command_keys): Revert last change.
5747
5748 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5749
5750 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5751 quotes the next character, and doesn't affect other longer
5752 sequences (bug#8935).
5753
5754 * lread.c (syms_of_lread): Clarify that is isn't only
5755 `eval-buffer' and `eval-defun' that's affected by
5756 `lexical-binding' (bug#8460).
5757
5758 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5759
5760 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5761 bidi redisplay when a line includes both an image and is truncated.
5762
5763 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5764
5765 Fix minor problems found by static checking.
5766 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5767 (elsz): Now a signed constant, not a size_t var. We prefer signed
5768 types to unsigned, to avoid integer comparison confusion. Without
5769 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5770 "cannot optimize loop, the loop counter may overflow", a symptom
5771 of the confusion.
5772 * indent.c (Fvertical_motion): Mark locals as initialized.
5773 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5774
5775 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5776
5777 * search.c (Fre_search_backward): Mention `case-fold-search' in
5778 all the re_search_* functions (bug#8138).
5779
5780 * keyboard.c (Fopen_dribble_file): Document when the file is
5781 closed (bug#8056).
5782
5783 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5784
5785 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5786 bidi_cache_idx.
5787
5788 Support bidi reordering of display and overlay strings.
5789 * xdisp.c (compute_display_string_pos)
5790 (compute_display_string_end): Accept additional argument STRING.
5791 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5792 (reseat_to_string): Initialize bidi_it->string.s and
5793 bidi_it->string.schars.
5794 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5795 NULL (avoids a crash in bidi_paragraph_init).
5796 Initialize itb.string.lstring.
5797 (init_iterator): Call bidi_init_it only of a valid
5798 buffer position was specified. Initialize paragraph_embedding to
5799 L2R.
5800 (reseat_to_string): Initialize the bidi iterator.
5801 (display_string): If we need to ignore text properties of
5802 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5803 original value of -1 will not work with bidi.)
5804 (compute_display_string_pos): First arg is now struct
5805 `text_pos *'; all callers changed. Support display properties on
5806 Lisp strings.
5807 (compute_display_string_end): Support display properties on Lisp
5808 strings.
5809 (init_iterator, reseat_1, reseat_to_string): Initialize the
5810 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5811 when iterating on a string not from display properties).
5812 (compute_display_string_pos, compute_display_string_end):
5813 Fix calculation of the object to scan. Fixes an error when using
5814 arrow keys.
5815 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5816 base_level_stop; instead, set base_level_stop to BEGV.
5817 Fixes crashes in vertical-motion.
5818 (next_element_from_buffer): Improve commentary for when
5819 the iterator is before prev_stop.
5820 (init_iterator): Initialize bidi_p from the default value of
5821 bidi-display-reordering, not from buffer-local value. Use the
5822 buffer-local value only if initializing for buffer iteration.
5823 (handle_invisible_prop): Support invisible properties on strings
5824 that are being bidi-reordered.
5825 (set_iterator_to_next): Support bidi reordering of C strings and
5826 Lisp strings.
5827 (next_element_from_string): Support bidi reordering of Lisp
5828 strings.
5829 (handle_stop_backwards): Support Lisp strings as well.
5830 (display_string): Support display of R2L glyph rows.
5831 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5832 (init_iterator): Don't initialize it->bidi_p for strings
5833 here.
5834 (reseat_to_string): Initialize it->bidi_p for strings here.
5835 (next_element_from_string, next_element_from_c_string)
5836 (next_element_from_buffer): Add xassert's for correspondence
5837 between IT's object being iterated and it->bidi_it.string
5838 structure.
5839 (face_before_or_after_it_pos): Support bidi iteration.
5840 (next_element_from_c_string): Handle the case of the first string
5841 character that is not the first one in the visual order.
5842 (get_visually_first_element): New function, refactored from common
5843 parts of next_element_from_buffer, next_element_from_string, and
5844 next_element_from_c_string.
5845 (tool_bar_lines_needed, redisplay_tool_bar)
5846 (display_menu_bar): Force left-to-right direction. Add a FIXME
5847 comment for making that be controlled by a user option.
5848 (push_it, pop_it): Save and restore the state of the
5849 bidi iterator. Save and restore the bidi_p flag.
5850 (pop_it): Iterate out of display property for string iteration as
5851 well.
5852 (iterate_out_of_display_property): Support iteration over strings.
5853 (handle_single_display_spec): Set up it->bidi_it for iteration
5854 over a display string, and call bidi_init_it.
5855 (handle_single_display_spec, next_overlay_string)
5856 (get_overlay_strings_1, push_display_prop): Set up the bidi
5857 iterator for displaying display or overlay strings.
5858 (forward_to_next_line_start): Don't use the shortcut if
5859 bidi-iterating.
5860 (back_to_previous_visible_line_start): If handle_display_prop
5861 pushed the iterator stack, restore the internal state of the bidi
5862 iterator by calling bidi_pop_it same number of times.
5863 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5864 and we are bidi-iterating, don't decrement the iterator position;
5865 instead, set the first_elt flag in the bidi iterator, to produce
5866 the same effect.
5867 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5868 (push_display_prop): xassert that we are iterating a buffer.
5869 (push_it, pop_it): Save and restore paragraph_embedding member.
5870 (handle_single_display_spec, next_overlay_string)
5871 (get_overlay_strings_1, reseat_1, reseat_to_string)
5872 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5873 correctly. Don't assume unibyte strings are not bidi-reordered.
5874 (compute_display_string_pos)
5875 (compute_display_string_end): Fix handling the case of C string.
5876 (push_it, pop_it): Save and restore from_disp_prop_p.
5877 (handle_single_display_spec, push_display_prop): Set the
5878 from_disp_prop_p flag.
5879 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5880 (pop_it): Call iterate_out_of_display_property only if we are
5881 popping after iteration over a string that came from a display
5882 property. Fix a typo in popping stretch info. Add an assertion
5883 for verifying that the iterator position is in sync with the bidi
5884 iterator.
5885 (handle_single_display_spec, get_overlay_strings_1)
5886 (push_display_prop): Fix initialization of paragraph direction for
5887 string when that of the parent object is not yet determined.
5888 (reseat_1): Call bidi_init_it to resync the bidi
5889 iterator with IT's position. (Bug#7616)
5890 (find_row_edges): If ROW->start.pos gives position
5891 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5892 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5893 Reset the from_disp_prop_p flag.
5894 (SAVE_IT, RESTORE_IT): New macros.
5895 (pos_visible_p, face_before_or_after_it_pos)
5896 (back_to_previous_visible_line_start)
5897 (move_it_in_display_line_to, move_it_in_display_line)
5898 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5899 (try_scrolling, redisplay_window, display_line): Use them when
5900 saving a temporary copy of the iterator and restoring it back.
5901 (back_to_previous_visible_line_start, reseat_1)
5902 (init_iterator): Empty the bidi cache "stack".
5903 (move_it_in_display_line_to): If iterator ended up at
5904 EOL, but we never saw any buffer positions smaller than
5905 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5906 motion in bidi-reordered lines.
5907 (move_it_in_display_line_to): Record prev_method and prev_pos
5908 immediately before the call to set_iterator_to_next. Fixes cursor
5909 motion in bidi-reordered lines with stretch glyphs and strings
5910 displayed in margins. (Bug#8133) (Bug#8867)
5911 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5912 TO_CHARPOS.
5913 (pos_visible_p): Support positions in bidi-reordered lines.
5914 Save and restore bidi cache.
5915
5916 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5917 (bidi_paragraph_info): Delete unused struct.
5918 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5919 (bidi_cache_start): New variable.
5920 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5921 to zero.
5922 (bidi_cache_fetch_state, bidi_cache_search)
5923 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5924 (bidi_cache_find, bidi_peek_at_next_level)
5925 (bidi_level_of_next_char, bidi_find_other_level_edge)
5926 (bidi_move_to_visually_next): Compare cache index with
5927 bidi_cache_start rather than with zero.
5928 (bidi_fetch_char): Accept new argument STRING; all callers
5929 changed. Support iteration over a string. Support strings with
5930 display properties. Support unibyte strings. Fix the type of
5931 `len' according to what STRING_CHAR_AND_LENGTH expects.
5932 (bidi_paragraph_init, bidi_resolve_explicit_1)
5933 (bidi_resolve_explicit, bidi_resolve_weak)
5934 (bidi_level_of_next_char, bidi_move_to_visually_next):
5935 Support iteration over a string.
5936 (bidi_set_sor_type, bidi_resolve_explicit_1)
5937 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5938 can now be zero (for strings); special values 0 and -1 were
5939 changed to -1 and -2, respectively.
5940 (bidi_char_at_pos): New function.
5941 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5942 Call it instead of FETCH_MULTIBYTE_CHAR.
5943 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5944 initialized to valid values.
5945 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5946 values.
5947 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5948 the test for valid cached positions. Fix the logic for looking up
5949 the sentinel state in the cache. GCPRO the Lisp string we are
5950 iterating.
5951 (bidi_push_it, bidi_pop_it): New functions.
5952 (bidi_initialize): Initialize the bidi cache start stack pointer.
5953 (bidi_cache_ensure_space): New function, refactored from part of
5954 bidi_cache_iterator_state. Don't assume the required size is just
5955 one BIDI_CACHE_CHUNK away.
5956 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5957 (bidi_count_bytes, bidi_char_at_pos): New functions.
5958 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5959 always valid if bidi_cache_idx is valid.
5960 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5961 is valid if it's going to be used.
5962 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5963 (bidi_cache_fetch_state, bidi_cache_search)
5964 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5965 (bidi_cache_iterator_state, bidi_cache_find)
5966 (bidi_find_other_level_edge, bidi_cache_start_stack):
5967 All variables related to cache indices are now EMACS_INT.
5968
5969 * dispextern.h (struct bidi_string_data): New structure.
5970 (struct bidi_it): New member `string'. Make flag members be 1-bit
5971 fields, and put them last in the struct.
5972 (compute_display_string_pos, compute_display_string_end):
5973 Update prototypes.
5974 (bidi_push_it, bidi_pop_it): Add prototypes.
5975 (struct iterator_stack_entry): New members bidi_p,
5976 paragraph_embedding, and from_disp_prop_p.
5977 (struct it): Member bidi_p is now a bit field 1 bit wide.
5978 (bidi_shelve_cache, bidi_unshelve_cache):
5979 Declare prototypes.
5980
5981 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5982 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5983 and vector-like objects.
5984
5985 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5986 cache around display iteration.
5987
5988 * window.c (Fwindow_end, window_scroll_pixel_based)
5989 (displayed_window_lines, Frecenter): Save and restore the bidi
5990 cache around display iteration.
5991
5992 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5993
5994 * editfns.c (Fdelete_region): Clarify the use of the named
5995 parameters (bug#6788).
5996
5997 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5998
5999 * indent.c (Fvertical_motion): Set and restore w->pointm when
6000 saving and restoring the window's buffer (Bug#9006).
6001
6002 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6003
6004 * editfns.c (Fstring_to_char): Clarify just what is returned
6005 (bug#6576). Text by Eli Zaretskii.
6006
6007 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6008
6009 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6010
6011 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6012
6013 * buffer.c (mmap_find): Fix a typo.
6014
6015 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6016
6017 Fix execution of x selection hooks.
6018 * xselect.c (Qx_lost_selection_functions)
6019 (Qx_sent_selection_functions): New vars.
6020 (syms_of_xselect): DEFSYM them.
6021 (x_handle_selection_request): Pass Qx_sent_selection_functions
6022 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6023 (x_handle_selection_clear,x_clear_frame_selections):
6024 Pass Qx_lost_selection_functions rather than
6025 Vx_lost_selection_functions to Frun_hook_with_args.
6026
6027 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6030 The old code sometimes used this field without initializing it.
6031
6032 * alloc.c (gc_sweep): Don't read past end of array.
6033 In theory, the old code could also have corrupted Emacs internals,
6034 though it'd be very unlikely.
6035
6036 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6037
6038 * character.c (Fcharacterp): Don't advertise optional ignored
6039 argument. (Bug#4026)
6040
6041 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6042
6043 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6044 key" (bug#4257).
6045
6046 * window.c (Fset_window_start): Doc fix (bug#4199).
6047 (Fset_window_hscroll): Ditto.
6048
6049 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 Fix minor new problems caught by GCC 4.6.1.
6052 * term.c (init_tty): Remove unused local.
6053 * xsettings.c (store_monospaced_changed): Define this function only
6054 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6055 not used otherwise.
6056
6057 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6058
6059 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6060
6061 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6062
6063 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6064 are the mini-buffer and the echo area (bug#3320).
6065
6066 * term.c (init_tty): Remove support for supdup, c10 and perq
6067 terminals, which are no longer supported (bug#1482).
6068
6069 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6070
6071 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6072
6073 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6074
6075 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6076 for non-popups (Bug#3642).
6077
6078 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6079
6080 * alloc.c (reset_malloc_hooks): Protoize.
6081 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6082 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6083 * cm.c (losecursor): Likewise.
6084 * data.c (fmod): Likewise.
6085 * dispnew.c (swap_glyphs_in_rows): Likewise.
6086 * emacs.c (memory_warning_signal): Likewise.
6087 * floatfns.c (float_error): Likewise.
6088 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6089 (otf_open, font_otf_capability, generate_otf_features)
6090 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6091 Likewise.
6092 * image.c (pbm_read_file): Likewise.
6093 * indent.c (string_display_width): Likewise.
6094 * intervals.c (check_for_interval, search_for_interval)
6095 (inc_interval_count, count_intervals, root_interval)
6096 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6097 * lread.c (defalias): Likewise.
6098 * ralloc.c (r_alloc_check): Likewise.
6099 * regex.c (set_image_of_range_1, set_image_of_range)
6100 (regex_grow_registers): Likewise.
6101 * sysdep.c (strerror): Likewise.
6102 * termcap.c (valid_filename_p, tprint, main): Likewise.
6103 * tparam.c (main): Likewise.
6104 * unexhp9k800.c (run_time_remap, save_data_space)
6105 (update_file_ptrs, read_header, write_header, calculate_checksum)
6106 (copy_file, copy_rest, display_header): Likewise.
6107 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6108 Likewise.
6109 * xdisp.c (check_it): Likewise.
6110 * xfaces.c (register_color, unregister_color, unregister_colors):
6111 Likewise.
6112 * xfns.c (print_fontset_result): Likewise.
6113 * xrdb.c (member, fatal, main): Likewise.
6114
6115 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6116
6117 Fix minor problems found by static checking (Bug#9031).
6118 * chartab.c (char_table_set_range, map_sub_char_table):
6119 Remove unused locals.
6120 (uniprop_table): Now static.
6121 * composite.c (_work_char): Remove unused static var.
6122
6123 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6124
6125 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6126
6127 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6128
6129 * gtkutil.c (qttip_cb): Remove code without function.
6130
6131 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6132
6133 * w32.c (pthread_sigmask): New stub.
6134
6135 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6136
6137 Use pthread_sigmask, not sigprocmask (Bug#9010).
6138 sigprocmask is portable only for single-threaded applications, and
6139 Emacs can be multi-threaded when it uses GTK.
6140 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6141 (LIBES): Use it.
6142 * callproc.c (Fcall_process):
6143 * process.c (create_process):
6144 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6145 Use pthread_sigmask, not sigprocmask.
6146
6147 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6148
6149 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6150 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6151 wrong (Bug#8591).
6152
6153 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6154
6155 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6156 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6157 (xg_hide_tooltip): Fix comment.
6158
6159 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6160 in registerServicesMenuSendTypes.
6161 (validRequestorForSendType): Don't check ns_return_types.
6162
6163 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6164 ns_return_type.
6165
6166 2011-07-08 Jason Rumney <jasonr@gnu.org>
6167
6168 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6169 SH_SHOW for hidden windows (Bug#5482).
6170
6171 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6172 frame struct members of non-existent frames (Bug#6284).
6173
6174 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6175
6176 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6177 variable firstTime not needed on OSX >= 10.6.
6178 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6179 >= 10.5. Use setKnobProportion, setDoubleValue.
6180
6181 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6182 (MAC_OS_X_VERSION_10_5): Define if not defined.
6183 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6184 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6185 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6186
6187 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6188 cString and lossyCString on OSX >= 10.4
6189
6190 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6191 sizeToFit on OSX >= 10.2.
6192
6193 * nsimage.m (allocInitFromFile): Don't use deprecated method
6194 bestRepresentationForDevice on OSX >= 10.6.
6195
6196 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6197 to avoid warning.
6198
6199 * emacs.c: Declare unexec_init_emacs_zone.
6200
6201 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6202
6203 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6204
6205 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6206 on svcsMenu (Bug#8842).
6207
6208 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6209 ns_return_types.
6210 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6211
6212 * nsterm.m (QUTF8_STRING): Declare.
6213 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6214 (validRequestorForSendType): Return type is (id).
6215 Change indexOfObjectIdenticalTo to indexOfObject.
6216 Check if we have local selection before returning self (Bug#8842).
6217 (writeSelectionToPasteboard): Put local selection into paste board
6218 if we have a local selection (Bug#8842).
6219 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6220
6221 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6222 (ns_get_local_selection): Declare.
6223
6224 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6225
6226 * keymap.c (describe_map_tree): Don't insert a double newline at
6227 the end of the buffer (bug#1169) and return whether we inserted
6228 something.
6229
6230 * callint.c (Fcall_interactively): Change "reading args" to
6231 "providing args" to try to clarify what it does (bug#1010).
6232
6233 2011-07-07 Kenichi Handa <handa@m17n.org>
6234
6235 * composite.c (composition_compute_stop_pos): Ignore a static
6236 composition starting before CHARPOS (Bug#8915).
6237
6238 * xdisp.c (handle_composition_prop): Likewise.
6239
6240 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6241
6242 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6243 (Bug#9015)
6244
6245 2011-07-07 Kenichi Handa <handa@m17n.org>
6246
6247 * character.h (unicode_category_t): New enum type.
6248
6249 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6250 (Qchar_code_property_table): New variable.
6251 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6252 (UNIPROP_COMPRESSED_FORM_P): New macros.
6253 (char_table_ascii): Uncompress the compressed values.
6254 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6255 Uncompress the compressed values.
6256 (sub_char_table_ref_and_range): Likewise.
6257 (char_table_ref_and_range): Uncompress the compressed values.
6258 (sub_char_table_set): New arg is_uniprop. Callers changed.
6259 Uncompress the compressed values.
6260 (sub_char_table_set_range): Args changed. Callers changed.
6261 (char_table_set_range): Adjuted for the above change.
6262 (map_sub_char_table): Delete args default_val and parent. Add arg
6263 top. Give decoded values to a Lisp function.
6264 (map_char_table): Adjust for the above change. Give decoded
6265 values to a Lisp function. Gcpro more variables.
6266 (uniprop_table_uncompress)
6267 (uniprop_decode_value_run_length): New functions.
6268 (uniprop_decoder, uniprop_decoder_count): New variables.
6269 (uniprop_get_decoder, uniprop_encode_value_character)
6270 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6271 New functions.
6272 (uniprop_encoder, uniprop_encoder_count): New variables.
6273 (uniprop_get_encoder, uniprop_table)
6274 (Funicode_property_table_internal, Fget_unicode_property_internal)
6275 (Fput_unicode_property_internal): New functions.
6276 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6277 Sunicode_property_table_internal, Sget_unicode_property_internal,
6278 and Sput_unicode_property_internal. Defvar_lisp
6279 char-code-property-alist.
6280
6281 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6282 Vunicode_category_table.
6283
6284 * font.c (font_range): Adjust for the change of
6285 Vunicode_category_table.
6286
6287 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6288
6289 * m/iris4d.h: Remove file, move contents ...
6290 * s/irix6-5.h: ... here.
6291
6292 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6293
6294 Remove unportable assumption about struct layout (Bug#8884).
6295 * alloc.c (mark_buffer):
6296 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6297 (clone_per_buffer_values): Don't assume that
6298 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6299 This isn't true in general, and it's particularly not true
6300 if Emacs is configured with --with-wide-int.
6301 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6302 New macros, used in the buffer.c change.
6303
6304 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6305
6306 * xsettings.c: Use both GConf and GSettings if both are available.
6307 (store_config_changed_event): Add comment.
6308 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6309 (store_tool_bar_style_changed): New functions.
6310 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6311 (struct xsettings): Move font inside HAVE_XFT.
6312 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6313 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6314 Move inside HAVE_XFT.
6315 (something_changed_gsettingsCB): Rename from something_changedCB.
6316 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6317 also.
6318 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6319 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6320 (something_changed_gconfCB): Rename from something_changedCB.
6321 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6322 (parse_settings): Move check for font inside HAVE_XFT.
6323 (read_settings, apply_xft_settings): Add comment.
6324 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6325 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6326 call store_font_name_changed.
6327 (xft_settings_event): Add comment.
6328 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6329 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6330 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6331 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6332 (xsettings_initialize): Call init_gsettings last.
6333 (xsettings_get_system_font, xsettings_get_system_normal_font):
6334 Add comment.
6335
6336 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6337
6338 Random fixes. E.g., (random) never returned negative values.
6339 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6340 subseconds part to the entropy, as that's a bit more random.
6341 Prefer signed to unsigned, since the signedness doesn't matter and
6342 in general we prefer signed. When given a limit, use a
6343 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6344 latter isn't right if USE_2_TAGS_FOR_INTS.
6345 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6346 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6347
6348 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6349
6350 * textprop.c (text_property_stickiness):
6351 Obey Vtext_property_default_nonsticky.
6352 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6353 * w32fns.c (syms_of_w32fns):
6354 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6355
6356 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6357
6358 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6359 This is more efficient than Ffile_directory_p and avoids a minor race.
6360
6361 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6362
6363 * buffer.c (Foverlay_put): Say what the return value is
6364 (bug#7835).
6365
6366 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6367 is a directory before asking whether to use the file name
6368 (bug#7564).
6369 (barf_or_query_if_file_exists): Make the "File is a directory"
6370 error be more correct.
6371
6372 * fns.c (Frequire): Remove the mention of the .gz files, since
6373 that's installation-specific, but keep the mention of
6374 `get-load-suffixes'.
6375
6376 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6379 Report string overflow if the output is too long.
6380
6381 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6382
6383 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6384 (syms_of_gnutls): Remove duplicate DEFSYM for
6385 Qgnutls_bootprop_verify_hostname_error, an error for
6386 Qgnutls_bootprop_verify_error (which is no longer used).
6387
6388 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6389 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6390 Also (re)move comments that are misplaced or no longer relevant.
6391
6392 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6393
6394 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6395
6396 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6397
6398 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6399 and background color parameters if they have been changed.
6400
6401 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6402
6403 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6404
6405 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6406
6407 * xsettings.c (SYSTEM_FONT): Define only when used.
6408 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6409
6410 * keymap.c (access_keymap_1): Now static.
6411
6412 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6413
6414 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6415 leave any prefix arg for the up event (Bug#1586).
6416
6417 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6418
6419 * lread.c (syms_of_lread): Mention single symbols defined by
6420 `defvar' or `defconst' (bug#7154).
6421
6422 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6423 (Frequire): Mention get-load-suffixes.
6424
6425 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6426
6427 * window.h (window): Remove clone_number slot.
6428 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6429 Remove.
6430 (make_parent_window, make_window, saved_window)
6431 (Fset_window_configuration, save_window_save): Don't deal with
6432 clone numbers.
6433 * buffer.c (Qclone_number): Remove declaration.
6434 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6435
6436 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6437
6438 Add multiple inheritance to keymaps.
6439 * keymap.c (Fmake_composed_keymap): New function.
6440 (Fset_keymap_parent): Simplify.
6441 (fix_submap_inheritance): Remove.
6442 (access_keymap_1): New function extracted from access_keymap to handle
6443 embedded parents and handle lists of maps.
6444 (access_keymap): Use it.
6445 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6446 (Fcopy_keymap): Handle embedded parents.
6447 (Fcommand_remapping, define_as_prefix): Simplify.
6448 (Fkey_binding): Simplify.
6449 (syms_of_keymap): Move minibuffer-local-completion-map,
6450 minibuffer-local-filename-completion-map,
6451 minibuffer-local-must-match-map, and
6452 minibuffer-local-filename-must-match-map to Elisp.
6453 (syms_of_keymap): Defsubr make-composed-keymap.
6454 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6455 (parse_menu_item): Trivial simplification.
6456
6457 2011-07-01 Glenn Morris <rgm@gnu.org>
6458
6459 * Makefile.in (SETTINGS_LIBS): Fix typo.
6460
6461 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6462
6463 * coding.c (Fencode_coding_string): Record the last coding system
6464 used, as the function doc string says (bug#8738).
6465
6466 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6467
6468 * xsettings.c (store_monospaced_changed): Take new font as arg and
6469 check for change against current_mono_font.
6470 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6471 (emacs_settings_constructor, emacs_settings_get_property)
6472 (emacs_settings_set_property, emacs_settings_class_init)
6473 (emacs_settings_init, gsettings_obj): Remove.
6474 (something_changedCB): New function for HAVE_GSETTINGS.
6475 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6476 with value as argument.
6477 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6478 g_settings_new (Bug#8967). Do not create gsettings_obj.
6479 Remove calls to g_settings_bind. Connect something_changedCB to
6480 "changed".
6481
6482 * xgselect.c: Add defined (HAVE_GSETTINGS).
6483 (xgselect_initialize): Ditto.
6484
6485 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6486 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6487 xg_select.
6488
6489 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6490
6491 * eval.c (struct backtrace): Simplify and port the data structure.
6492 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6493 signed bit field, as this assumption is not portable and it makes
6494 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6495 "char debug_on_exit : 1" as this is not portable either; instead,
6496 use the portable "unsigned int debug_on_exit : 1". Remove unused
6497 member evalargs. Remove obsolete comments about cc bombing out.
6498
6499 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6500
6501 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6502 Let HAVE_GSETTINGS override HAVE_GCONF.
6503 (store_monospaced_changed): New function.
6504 (EMACS_SETTINGS): A new type derived from GObject to handle
6505 GSettings notifications.
6506 (emacs_settings_constructor, emacs_settings_get_property)
6507 (emacs_settings_set_property, emacs_settings_class_init):
6508 New functions.
6509 (gsettings_client, gsettings_obj): New variables.
6510 (GSETTINGS_SCHEMA): New define.
6511 (something_changedCB): Call store_monospaced_changed.
6512 (init_gsettings): New function.
6513 (xsettings_initialize): Call init_gsettings.
6514 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6515 to NULL.
6516
6517 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6518 GCONF_CFLAGS/LIBS.
6519
6520 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6521
6522 * window.c (resize_root_window, grow_mini_window)
6523 (shrink_mini_window): Rename Qresize_root_window to
6524 Qwindow_resize_root_window and Qresize_root_window_vertically to
6525 Qwindow_resize_root_window_vertically.
6526
6527 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6528
6529 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6530
6531 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6532
6533 * makefile.w32-in: Redesign dependencies so they reflect more
6534 clearly which files are directly included by each source file,
6535 and not through other includes.
6536
6537 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6538
6539 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6540 (sort_overlays, overlay_strings): When an overlay's clone number
6541 matches the window's clone number process the overlay even if
6542 the overlay's window property doesn't match the current window.
6543
6544 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6545 (Fwindow_hchild): Rename to Fwindow_left_child.
6546 (Fwindow_next): Rename to Fwindow_next_sibling.
6547 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6548 (resize_window_check): Rename to window_resize_check.
6549 (resize_window_apply): Rename to window_resize_apply.
6550 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6551 (Fdelete_other_windows_internal, resize_frame_windows)
6552 (Fsplit_window_internal, Fdelete_window_internal)
6553 (grow_mini_window, shrink_mini_window)
6554 (Fresize_mini_window_internal): Fix callers accordingly.
6555
6556 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6557
6558 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6559 (emacs_fixed_set_min_size): Remove.
6560 (emacs_fixed_new): Take frame as argument.
6561
6562 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6563 (_EmacsFixedPrivate): Remove minwidth/height.
6564 Add struct frame *f.
6565 (emacs_fixed_init): Initialize priv->f.
6566 (get_parent_class, emacs_fixed_set_min_size): Remove.
6567 (emacs_fixed_new): Set priv->f to argument.
6568 (emacs_fixed_get_preferred_width)
6569 (emacs_fixed_get_preferred_height): Use min_width/height from
6570 frames size_hint to set minimum and natural (Bug#8919).
6571 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6572 and use min_width/height from frames size_hint to set
6573 min_width/height (Bug#8919).
6574
6575 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6576 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6577 Fix indentation.
6578
6579 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6580
6581 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6582 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6583 called at ZV.
6584
6585 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6586
6587 * process.c (wait_reading_process_output): Bypass select if
6588 waiting for a cell while ignoring keyboard input, and input is
6589 pending. Suggested by Jan Djärv (Bug#8869).
6590
6591 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6592
6593 Use gnulib's dup2 module instead of rolling our own.
6594 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6595
6596 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6597
6598 * dispnew.c (scrolling_window): Before scrolling, turn off a
6599 mouse-highlight in the window being scrolled.
6600
6601 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6602
6603 Move DEFSYM to lisp.h and use everywhere.
6604
6605 * character.h (DEFSYM): Move declaration...
6606 * lisp.h (DEFSYM): ...here.
6607
6608 * gnutls.c:
6609 * minibuf.c:
6610 * w32menu.c:
6611 * w32proc.c:
6612 * w32select.c: Don't include character.h.
6613
6614 * alloc.c (syms_of_alloc):
6615 * buffer.c (syms_of_buffer):
6616 * bytecode.c (syms_of_bytecode):
6617 * callint.c (syms_of_callint):
6618 * casefiddle.c (syms_of_casefiddle):
6619 * casetab.c (init_casetab_once):
6620 * category.c (init_category_once, syms_of_category):
6621 * ccl.c (syms_of_ccl):
6622 * cmds.c (syms_of_cmds):
6623 * composite.c (syms_of_composite):
6624 * dbusbind.c (syms_of_dbusbind):
6625 * dired.c (syms_of_dired):
6626 * dispnew.c (syms_of_display):
6627 * doc.c (syms_of_doc):
6628 * editfns.c (syms_of_editfns):
6629 * emacs.c (syms_of_emacs):
6630 * eval.c (syms_of_eval):
6631 * fileio.c (syms_of_fileio):
6632 * fns.c (syms_of_fns):
6633 * frame.c (syms_of_frame):
6634 * fringe.c (syms_of_fringe):
6635 * insdel.c (syms_of_insdel):
6636 * keymap.c (syms_of_keymap):
6637 * lread.c (init_obarray, syms_of_lread):
6638 * macros.c (syms_of_macros):
6639 * msdos.c (syms_of_msdos):
6640 * print.c (syms_of_print):
6641 * process.c (syms_of_process):
6642 * search.c (syms_of_search):
6643 * sound.c (syms_of_sound):
6644 * syntax.c (init_syntax_once, syms_of_syntax):
6645 * terminal.c (syms_of_terminal):
6646 * textprop.c (syms_of_textprop):
6647 * undo.c (syms_of_undo):
6648 * w32.c (globals_of_w32):
6649 * window.c (syms_of_window):
6650 * xdisp.c (syms_of_xdisp):
6651 * xfaces.c (syms_of_xfaces):
6652 * xfns.c (syms_of_xfns):
6653 * xmenu.c (syms_of_xmenu):
6654 * xsettings.c (syms_of_xsettings):
6655 * xterm.c (syms_of_xterm): Use DEFSYM.
6656
6657 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6658
6659 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6660
6661 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6662
6663 Integer and buffer overflow fixes (Bug#8873).
6664
6665 * print.c (printchar, strout): Check for string overflow.
6666 (PRINTPREPARE, printchar, strout):
6667 Don't set size unless allocation succeeds.
6668
6669 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6670 for sizes. Check for string overflow more accurately.
6671 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6672
6673 * macros.c: Integer and buffer overflow fixes.
6674 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6675 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6676 Use ptrdiff_t, not int, for sizes.
6677 Don't increment bufsize until after realloc succeeds.
6678 Check for size-calculation overflow.
6679 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6680
6681 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6682
6683 * lread.c: Integer overflow fixes.
6684 (read_integer): Radix is now EMACS_INT, not int,
6685 to improve quality of diagnostics for out-of-range radices.
6686 Calculate buffer size correctly for out-of-range radices.
6687 (read1): Check for integer overflow in radices, and in
6688 read-circle numbers.
6689 (read_escape): Avoid int overflow.
6690 (Fload, openp, read_buffer_size, read1)
6691 (substitute_object_recurse, read_vector, read_list, map_obarray):
6692 Use ptrdiff_t, not int, for sizes.
6693 (read1): Use EMACS_INT, not int, for sizes.
6694 Check for size overflow.
6695
6696 * image.c (cache_image): Check for size arithmetic overflow.
6697
6698 * lread.c: Integer overflow issues.
6699 (saved_doc_string_size, saved_doc_string_length)
6700 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6701 Now ptrdiff_t, not int.
6702 (read1): Don't assume doc string length fits in int. Check for
6703 out-of-range doc string lengths.
6704 (read_list): Don't assume file position fits in int.
6705 (read_escape): Check for hex character overflow.
6706
6707 2011-06-22 Leo Liu <sdl.web@gmail.com>
6708
6709 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6710 Move to minibuffer.el.
6711
6712 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6713
6714 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6715 The following patches are for when GLYPH_DEBUG && !XASSERT.
6716 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6717 * dispnew.c (flush_stdout):
6718 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6719 Mark as externally visible.
6720 * dispnew.c (check_window_matrix_pointers): Now static.
6721 * dispnew.c (window_to_frame_vpos):
6722 * xfns.c (unwind_create_frame):
6723 * xterm.c (x_check_font): Remove unused local.
6724 * scroll.c (CHECK_BOUNDS):
6725 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6726 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6727 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6728 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6729 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6730 Now static.
6731 (debug_method_add): Use va_list and vsprintf rather than relying
6732 on undefined behavior with wrong number of arguments.
6733 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6734 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6735 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6736 since we're not interested in debugging glyphs with old libraries.
6737 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6738 GCC 4.6.0's static checking.
6739
6740 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6741
6742 Integer overflow and signedness fixes (Bug#8873).
6743 A few related buffer overrun fixes, too.
6744
6745 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6746
6747 * dispextern.h (struct face.stipple):
6748 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6749 (x_bitmap_mask, x_allocate_bitmap_record)
6750 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6751 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6752 (x_create_bitmap_from_xpm_data):
6753 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6754 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6755 (.bitmaps_last):
6756 * xfaces.c (load_pixmap):
6757 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6758 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6759 (.bitmaps_last, struct x_output.icon_bitmap):
6760 Use ptrdiff_t, not int, for bitmap indexes.
6761 (x_allocate_bitmap_record): Check for size overflow.
6762 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6763
6764 Use ptrdiff_t, not int, for overlay counts.
6765 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6766 * editfns.c (overlays_around, get_pos_property):
6767 * textprop.c (get_char_property_and_overlay):
6768 * xdisp.c (next_overlay_change, note_mouse_highlight):
6769 * xfaces.c (face_at_buffer_position):
6770 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6771 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6772 (Fnext_overlay_change, Fprevious_overlay_change)
6773 (mouse_face_overlay_overlaps, Foverlays_in):
6774 Use ptrdiff_t, not int, for sizes.
6775 (overlays_at, overlays_in): Check for size-calculation overflow.
6776
6777 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6778
6779 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6780 (x_session_initialize): Do not assume string length fits in int.
6781
6782 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6783 This is unlikely, but can occur if DPI is outlandish.
6784
6785 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6786 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6787
6788 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6789 * xrdb.c (magic_file_p, search_magic_path):
6790 Omit last arg SUFFIX; it was always 0. All callers changed.
6791 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6792
6793 * xfont.c (xfont_match): Avoid need for strlen.
6794
6795 * xfns.c: Don't assume strlen fits in int.
6796 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6797
6798 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6799 not unsigned long, as we prefer signed integers. All callers changed.
6800 Detect integer overflow in repeat count.
6801 (message_dolog): Don't assume print length fits in 39 bytes.
6802 (display_mode_element): Don't assume strlen fits in int.
6803
6804 * termcap.c: Don't assume sizes fit in int and never overflow.
6805 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6806 (gobble_line): Check for size-calculation overflow.
6807
6808 * minibuf.c (Fread_buffer):
6809 * lread.c (intern, intern_c_string):
6810 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6811 Don't assume string length fits in int.
6812
6813 * keyboard.c (parse_tool_bar_item):
6814 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6815
6816 * font.c: Don't assume string length fits in int.
6817 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6818 Use ptrdiff_t, not int.
6819 (font_intern_prop): Don't assume string length fits in int.
6820 Don't assume integer property fits in fixnum.
6821 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6822
6823 * filelock.c: Fix some buffer overrun and integer overflow issues.
6824 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6825 Reformulate so as not to need the command string.
6826 Invoke gzip -cd rather than gunzip, as it's more portable.
6827 (lock_info_type, lock_file_1, lock_file):
6828 Don't assume pid_t and time_t fit in unsigned long.
6829 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6830 (current_lock_owner): Prefer signed type for sizes.
6831 Use memcpy, not strncpy, where memcpy is what is really wanted.
6832 Don't assume (via atoi) that time_t and pid_t fit in int.
6833 Check for time_t and/or pid_t out of range, e.g., via a network share.
6834 Don't alloca where an auto var works fine.
6835
6836 * fileio.c: Fix some integer overflow issues.
6837 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6838 Don't assume string length fits in int.
6839 (directory_file_name): Don't assume string length fits in long.
6840 (make_temp_name): Don't assume pid fits in int, or that its print
6841 length is less than 20.
6842
6843 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6844
6845 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6846
6847 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6848
6849 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6850 We prefer signed integers, even for size calculations.
6851
6852 * emacs.c: Don't assume string length fits in 'int'.
6853 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6854 (main): Don't invoke strlen when not needed.
6855
6856 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6857 (XD_DEBUG_MESSAGE): Don't waste a byte.
6858
6859 * callproc.c (getenv_internal_1, getenv_internal)
6860 (Fgetenv_internal):
6861 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6862
6863 * lread.c (invalid_syntax): Omit length argument.
6864 All uses changed. This doesn't fix a bug, but it simplifies the
6865 code away from its former Hollerith-constant appearance, and it's
6866 one less 'int' to worry about when looking at integer-overflow issues.
6867 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6868
6869 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6870 This didn't break anything, but it didn't help either.
6871 It's confusing to put a bogus integer in a place where the actual
6872 value does not matter.
6873 (LIST_END_P): Remove unused macro and its bogus comment.
6874 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6875
6876 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6877 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6878 implementation.
6879 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6880 We prefer signed types, and the value cannot exceed the EMACS_INT
6881 range anyway (because otherwise the length would not be representable).
6882 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6883 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6884 This avoids a GCC warning when WIDE_EMACS_INT.
6885
6886 * indent.c (sane_tab_width): New function.
6887 (current_column, scan_for_column, Findent_to, position_indentation)
6888 (compute_motion): Use it. This is just for clarity.
6889 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6890
6891 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6892
6893 * lisp.h (lint_assume): New macro.
6894 * composite.c (composition_gstring_put_cache):
6895 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6896
6897 * editfns.c, insdel.c:
6898 Omit unnecessary forward decls, to simplify future changes.
6899
6900 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6901
6902 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6903
6904 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6905 Use much-faster test for byte-length change.
6906 Don't assume string byte-length fits in 'int'.
6907 Check that character arg fits in 'int'.
6908 (mapcar1): Declare byte as byte, for clarity.
6909
6910 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6911
6912 * fns.c (concat): Catch string overflow earlier.
6913 Do not rely on integer wraparound.
6914
6915 * dispextern.h (struct it.overlay_strings_charpos)
6916 (struct it.selective): Now EMACS_INT, not int.
6917 * xdisp.c (forward_to_next_line_start)
6918 (back_to_previous_visible_line_start)
6919 (reseat_at_next_visible_line_start, next_element_from_buffer):
6920 Don't arbitrarily truncate the value of 'selective' to int.
6921
6922 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6923
6924 * composite.c: Don't truncate sizes to 'int'.
6925 (composition_gstring_p, composition_reseat_it)
6926 (composition_adjust_point): Use EMACS_INT, not int.
6927 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6928 not EMACS_UINT, for indexes.
6929
6930 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6931
6932 * buffer.c: Include <verify.h>.
6933 (struct sortvec.priority, struct sortstr.priority):
6934 Now EMACS_INT, not int.
6935 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6936 (struct sortstr.size, record_overlay_string)
6937 (struct sortstrlist.size, struct sortlist.used):
6938 Don't truncate size to int.
6939 (record_overlay_string): Check for size-calculation overflow.
6940 (init_buffer_once): Check at compile-time, not run-time.
6941
6942 2011-06-22 Jim Meyering <meyering@redhat.com>
6943
6944 Don't leak an XBM-image-sized buffer
6945 * image.c (xbm_load): Free the image buffer after using it.
6946
6947 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6948
6949 Port to Sun C.
6950 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6951 that Sun C diagnosed.
6952 * fns.c (secure_hash): Fix pointer signedness issue.
6953 * intervals.c (static_offset_intervals): New function.
6954 (offset_intervals): Use it.
6955
6956 2011-06-21 Leo Liu <sdl.web@gmail.com>
6957
6958 * deps.mk (fns.o):
6959 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6960 sha512.h.
6961
6962 * fns.c (secure_hash): Rename from crypto_hash_function and change
6963 the first arg to accept symbols.
6964 (Fsecure_hash): New primitive.
6965 (syms_of_fns): New symbols.
6966
6967 2011-06-20 Deniz Dogan <deniz@dogan.se>
6968
6969 * process.c (Fset_process_buffer): Clarify return value in
6970 docstring.
6971
6972 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6973
6974 * dispnew.c (add_window_display_history): Use BVAR.
6975
6976 * xdisp.c (debug_method_add): Use BVAR.
6977 (check_window_end, dump_glyph_matrix, dump_glyph)
6978 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6979
6980 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6981 Likewise.
6982
6983 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6984 check till after the cache is created in init_frame_faces.
6985
6986 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6987
6988 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6989
6990 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6991
6992 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6993 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6994 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6995
6996 Improve buffer-overflow checking (Bug#8873).
6997 * fileio.c (Finsert_file_contents):
6998 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6999 Remove the old (too-loose) buffer overflow checks.
7000 They weren't needed, since make_gap checks for buffer overflow.
7001 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7002 The old code merely checked for Emacs fixnum overflow, and relied
7003 on undefined (wraparound) behavior. The new code avoids undefined
7004 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7005
7006 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7007 Tune. Don't use wider integers than needed. Don't use alloca.
7008 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7009
7010 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7011
7012 * insdel.c, lisp.h (buffer_overflow): New function.
7013 (insert_from_buffer_1, replace_range, replace_range_2):
7014 * insdel.c (make_gap_larger):
7015 * editfns.c (Finsert_char):
7016 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7017
7018 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7019
7020 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7021
7022 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7023
7024 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7025 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7026
7027 * fileio.c: Don't assume EMACS_INT fits in off_t.
7028 (emacs_lseek): New static function.
7029 (Finsert_file_contents, Fwrite_region): Use it.
7030 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7031
7032 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7033
7034 * fns.c: Don't overflow int when computing a list length.
7035 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7036 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7037 truncation on 64-bit hosts. Check for QUIT every
7038 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7039 faster and is responsive enough.
7040 (Flength): Report an error instead of overflowing an integer.
7041 (Fsafe_length): Return a float if the value is not representable
7042 as a fixnum. This shouldn't happen except in contrived situations.
7043 (Fnthcdr, Fsort): Don't assume list length fits in int.
7044 (Fcopy_sequence): Don't assume vector length fits in int.
7045
7046 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7047 (header_size, word_size): New constants.
7048 (allocate_vectorlike): Don't check size overflow here.
7049 (allocate_vector): Check it here instead, since this is the only
7050 caller of allocate_vectorlike that could cause overflow.
7051 Check that the new vector's length is representable as a fixnum.
7052
7053 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7054 The previous code was bogus. For example, next_almost_prime (32)
7055 returned 39, which is undesirable as it is a multiple of 3; and
7056 next_almost_prime (24) returned 25, which is a multiple of 5 so
7057 why was the code bothering to check for multiples of 7?
7058
7059 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7060
7061 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7062
7063 Variadic C functions now count arguments with ptrdiff_t.
7064 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7065 Back then I didn't know that the Emacs coding style prefers signed int.
7066 Also, in the meantime I found a few more instances where arguments
7067 were being counted with int, which may truncate counts on 64-bit
7068 machines, or EMACS_INT, which may be unnecessarily wide.
7069 * lisp.h (struct Lisp_Subr.function.aMANY)
7070 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7071 Arg counts are now ptrdiff_t, not size_t.
7072 All variadic functions and their callers changed accordingly.
7073 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7074 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7075 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7076 * callint.c (Fcall_interactively): Check arg count for overflow,
7077 to avoid potential buffer overrun. Use signed char, not 'int',
7078 for 'varies' array, so that we needn't bother to check its size
7079 calculation for overflow.
7080 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7081 * eval.c (apply_lambda):
7082 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7083 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7084 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7085
7086 * callint.c (Fcall_interactively): Don't use index var as event count.
7087
7088 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7089 * mem-limits.h (SIZE): Remove; no longer used.
7090
7091 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7092
7093 Remove unnecessary casts.
7094 * xterm.c (x_term_init):
7095 * xfns.c (x_set_border_pixel):
7096 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7097 These aren't needed now that we assume ANSI C.
7098
7099 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7100 It's more likely to cause problems (due to unsigned overflow)
7101 than to cure them.
7102
7103 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7104
7105 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7106
7107 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7108
7109 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7110
7111 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7112
7113 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7114
7115 GLYPH_CODE_FACE returns EMACS_INT, not int.
7116 * dispextern.h (merge_faces):
7117 * xfaces.c (merge_faces):
7118 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7119 Don't assume EMACS_INT fits in int.
7120
7121 * character.h (CHAR_VALID_P): Remove unused parameter.
7122 * fontset.c, lisp.h, xdisp.c: All uses changed.
7123
7124 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7125
7126 * fns.c (concat): Minor tuning based on overflow analysis.
7127 This doesn't fix any bugs. Use int to hold character, instead
7128 of constantly refetching from Emacs object. Use XFASTINT, not
7129 XINT, for value known to be a character. Don't bother comparing
7130 a single byte to 0400, as it's always less.
7131
7132 * floatfns.c (Fexpt):
7133 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7134
7135 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7136 for characters.
7137
7138 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7139
7140 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7141 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7142 incorrectly succeed when S was a string, because 4294967386 was
7143 truncated before it was used.
7144
7145 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7146 Otherwise, an out-of-range integer could cause undefined behavior
7147 on a 64-bit host.
7148
7149 * composite.c: Use int, not EMACS_INT, for characters.
7150 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7151 EMACS_INT, for values that are known to be in character range.
7152 This doesn't fix any bugs but is the usual style inside Emacs and
7153 may generate better code on 32-bit machines.
7154
7155 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7156 This is for reasons similar to the recent CHAR_STRING fix.
7157 * charset.c (Fencode_char): Check that character arg is actually
7158 a character. Pass an int to ENCODE_CHAR.
7159 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7160 wider than 'int', as a compile-time check to prevent future regressions
7161 in this area.
7162
7163 * character.c (char_string): Remove unnecessary casts.
7164
7165 Make sure a 64-bit char is never passed to CHAR_STRING.
7166 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7167 by silently ignoring the top 32 bits, allowing some values
7168 that were far too large to be valid characters.
7169 * character.h: Include <verify.h>.
7170 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7171 arguments are no wider than unsigned, as a compile-time check
7172 to prevent future regressions in this area.
7173 * data.c (Faset):
7174 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7175 (Fsubst_char_in_region):
7176 * fns.c (concat):
7177 * xdisp.c (decode_mode_spec_coding):
7178 Adjust to CHAR_STRING's new requirement.
7179 * editfns.c (Finsert_char, Fsubst_char_in_region):
7180 * fns.c (concat): Check that character args are actually
7181 characters. Without this test, these functions did the wrong
7182 thing with wildly out-of-range values on 64-bit hosts.
7183
7184 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7185 These casts should not be needed on 32-bit hosts, either.
7186 * keyboard.c (read_char):
7187 * lread.c (Fload): Remove casts to unsigned.
7188
7189 * lisp.h (UNSIGNED_CMP): New macro.
7190 This fixes comparison bugs on 64-bit hosts.
7191 (ASCII_CHAR_P): Use it.
7192 * casefiddle.c (casify_object):
7193 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7194 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7195 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7196 * dispextern.h (FACE_FROM_ID):
7197 * keyboard.c (read_char): Use UNSIGNED_CMP.
7198
7199 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7200 not to EMACS_INT, to avoid GCC warning.
7201
7202 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7203
7204 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7205 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7206 isn't needed on 32-bit machines.
7207
7208 * buffer.c (Fgenerate_new_buffer_name):
7209 Use EMACS_INT for count, not int.
7210 (advance_to_char_boundary): Return EMACS_INT, not int.
7211
7212 * data.c (Qcompiled_function): Now static.
7213
7214 * window.c (window_body_lines): Now static.
7215
7216 * image.c (gif_load): Rename local to avoid shadowing.
7217
7218 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7219 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7220 * alloc.c (make_save_value): Integer argument is now of type
7221 ptrdiff_t, not int.
7222 (mark_object): Use ptrdiff_t, not int.
7223 * lisp.h (pD): New macro.
7224 * print.c (print_object): Use it.
7225
7226 * alloc.c: Use EMACS_INT, not int, to count objects.
7227 (total_conses, total_markers, total_symbols, total_vector_size)
7228 (total_free_conses, total_free_markers, total_free_symbols)
7229 (total_free_floats, total_floats, total_free_intervals)
7230 (total_intervals, total_strings, total_free_strings):
7231 Now EMACS_INT, not int. All uses changed.
7232 (Fgarbage_collect): Compute overall total using a double, so that
7233 integer overflow is less likely to be a problem. Check for overflow
7234 when converting back to an integer.
7235 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7236 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7237 These were 'int' variables that could overflow on 64-bit hosts;
7238 they were never used, so remove them instead of repairing them.
7239 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7240 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7241 Previously, this ceilinged at INT_MAX, but that doesn't work on
7242 64-bit machines.
7243 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7244
7245 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7246 (allocate_vectorlike): Check for ptrdiff_t overflow.
7247 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7248 when a (possibly-narrower) signed value would do just as well.
7249 We prefer using signed arithmetic, to avoid comparison confusion.
7250
7251 * alloc.c: Catch some string size overflows that we were missing.
7252 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7253 for convenience in STRING_BYTES_MAX.
7254 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7255 The definition here is exact; the one in lisp.h was approximate.
7256 (allocate_string_data): Check for string overflow. This catches
7257 some instances we weren't catching before. Also, it catches
7258 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7259 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7260 and ptrdiff_t and EMACS_INT are both 64 bits.
7261
7262 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7263 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7264 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7265
7266 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7267
7268 * alloc.c (Fmake_string): Check for out-of-range init.
7269
7270 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7271
7272 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7273
7274 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7275
7276 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7277 xg_get_default_scrollbar_width.
7278
7279 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7280 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7281 (style_changed_cb): Call update_theme_scrollbar_width and call
7282 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7283 all frames (Bug#8505).
7284 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7285 Call gtk_window_set_resizable if HAVE_GTK3.
7286 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7287 and height if HAVE_GTK3 (Bug#8505).
7288 (scroll_bar_width_for_theme): New variable.
7289 (update_theme_scrollbar_width): New function.
7290 (xg_get_default_scrollbar_width): Move code to
7291 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7292 (xg_initialize): Call update_theme_scrollbar_width.
7293
7294 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7295
7296 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7297
7298 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7299
7300 * frame.c (make_frame): Call other_buffer_safely instead of
7301 other_buffer.
7302
7303 * window.c (temp_output_buffer_show): Call display_buffer with
7304 second argument Vtemp_buffer_show_specifiers and reset latter
7305 immediately after the call.
7306 (Vtemp_buffer_show_specifiers): New variable.
7307 (auto_window_vscroll_p, next_screen_context_lines)
7308 (Vscroll_preserve_screen_position): Remove leading asterisks from
7309 doc-strings.
7310
7311 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7312
7313 Fix minor problems found by GCC 4.6.0 static checking.
7314 * buffer.c (Qclone_number): Remove for now, as it's unused.
7315 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7316 (record_buffer): Remove unused local.
7317 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7318 (set_frame_buffer_list): Remove; unused.
7319 * frame.h (other_visible_frames): Remove decl.
7320 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7321 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7322 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7323 if HAVE_GPM.
7324 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7325 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7326 Define only if HAVE_GPM.
7327 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7328 (update_hints_inhibit): Remove; never set. All uses removed.
7329 * widgetprv.h (emacsFrameClassRec): Remove decl.
7330 * window.c (delete_deletable_window): Now returns void, since it
7331 wasn't returning anything.
7332 (compare_window_configurations): Remove unused locals.
7333 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7334 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7335 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7336 the same widths as pointers. This follows up on the 2011-05-06 patch.
7337 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7338 * xterm.h: Likewise.
7339 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7340
7341 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7342
7343 * makefile.w32-in: Update dependencies.
7344 (LISP_H): Add lib/intprops.h.
7345
7346 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7347
7348 * image.c (gif_load): Add animation frame delay to the metadata.
7349 (syms_of_image): Use DEFSYM. New symbol `delay'.
7350
7351 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7352
7353 * window.c (delete_deletable_window): Re-add.
7354 (Fset_window_configuration): Rewrite to handle dead buffers and
7355 consequently deletable windows.
7356 (window_tree, Fwindow_tree): Remove. Supply functionality in
7357 window.el.
7358 (compare_window_configurations): Simplify code.
7359
7360 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7361
7362 * image.c (imagemagick_load_image): Fix type mismatch.
7363 (Fimagemagick_types): Likewise.
7364
7365 * window.h (replace_buffer_in_windows): Declare.
7366
7367 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7368
7369 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7370 Qclone_number. Remove external declaration of Qdelete_window.
7371 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7372 code.
7373 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7374 Run Qbuffer_list_update_hook if allowed.
7375 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7376 buffer list implementation.
7377 (other_buffer_safely): New function.
7378 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7379 calls to replace_buffer_in_windows and
7380 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7381 if allowed.
7382 (record_buffer): Inhibit quitting and rewrite using quittable
7383 functions. Run Qbuffer_list_update_hook if allowed.
7384 (Frecord_buffer, Funrecord_buffer): New functions.
7385 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7386 Move switch-to-buffer to window.el.
7387 (bury-buffer): Move to window.el.
7388 (Vbuffer_list_update_hook): New variable.
7389
7390 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7391 section.
7392
7393 * window.h (resize_frame_windows): Move up in code.
7394 (Fwindow_frame): Remove EXFUN.
7395 (replace_buffer_in_all_windows): Remove prototype.
7396 (replace_buffer_in_windows_safely): Add prototype.
7397
7398 * window.c: Declare Qdelete_window static again. Move down
7399 declaration of select_count.
7400 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7401 (Fother_window): Move to window.el.
7402 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7403 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7404 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7405 window.el.
7406 (replace_buffer_in_windows): Implement by calling
7407 Qreplace_buffer_in_windows.
7408 (replace_buffer_in_all_windows): Remove with some functionality
7409 moved into replace_buffer_in_windows_safely.
7410 (replace_buffer_in_windows_safely): New function.
7411 (select_window_norecord, select_frame_norecord): Move in front
7412 of run_window_configuration_change_hook. Remove now obsolete
7413 declarations.
7414 (Fset_window_buffer): Rewrite doc-string.
7415 Call Qrecord_window_buffer.
7416 (keys_of_window): Move binding for other-window to window.el.
7417
7418 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7419
7420 * dispextern.h (struct image): Replace data member, whose int_val
7421 and ptr_val fields were not used by anything, with a single
7422 lisp_val object.
7423
7424 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7425 (gif_clear_image, gif_load, imagemagick_load_image)
7426 (gs_clear_image, gs_load): Callers changed.
7427
7428 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7429
7430 * buffer.h: Include <time.h>, for time_t.
7431 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7432
7433 Fix minor problems found by static checking.
7434
7435 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7436
7437 Make identifiers static if they are not used in other modules.
7438 * data.c (Qcompiled_function, Qframe, Qvector):
7439 * image.c (QimageMagick, Qsvg):
7440 * minibuf.c (Qmetadata):
7441 * window.c (resize_window_check, resize_root_window): Now static.
7442 * window.h (resize_window_check, resize_root_window): Remove decls.
7443
7444 * window.c (window_deletion_count, delete_deletable_window):
7445 Remove; unused.
7446 (window_body_lines): Now static.
7447 (Fdelete_other_windows_internal): Mark vars as initialized.
7448 Make sure 'resize_failed' is initialized.
7449 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7450 (resize_window_apply): Remove unused local.
7451 * window.h (delete_deletable_window): Remove decl.
7452
7453 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7454 (imagemagick_load_image): Fix pointer signedness problem by changing
7455 last arg from unsigned char * to char *. All uses changed.
7456 Also, fix a local for similar reasons.
7457 Remove unused locals. Remove locals to avoid shadowing.
7458 (fn_rsvg_handle_free): Remove; unused.
7459 (svg_load, svg_load_image): Fix pointer signedness problem.
7460 (imagemagick_load_image): Don't use garbage pointer image_wand.
7461
7462 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7463
7464 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7465
7466 * image.c (gif_load): Fix omitted cast error introduced by
7467 2011-06-06 change.
7468
7469 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7470
7471 * window.h (resize_proportionally, orig_total_lines)
7472 (orig_top_line): Remove from window structure.
7473 (set_window_height, set_window_width, change_window_heights)
7474 (Fdelete_window): Remove prototypes.
7475 (resize_frame_windows): Remove duplicate declaration.
7476
7477 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7478
7479 * window.h (resize_frame_windows, resize_window_check)
7480 (delete_deletable_window, resize_root_window)
7481 (resize_frame_windows): Declare prototypes.
7482
7483 * window.c (resize_window_apply): Make definition be "static" to
7484 match the prototype.
7485
7486 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7487
7488 * window.c: Remove declarations of Qwindow_size_fixed,
7489 window_min_size_1, window_min_size_2, window_min_size,
7490 size_window, window_fixed_size_p, enlarge_window, delete_window.
7491 Remove static from declaration of Qdelete_window, it's
7492 temporarily needed by Fbury_buffer.
7493 (replace_window): Don't assign orig_top_line and
7494 orig_total_lines.
7495 (Fdelete_window, delete_window): Remove. Window deletion is
7496 handled by window.el.
7497 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7498 Replace Fdelete_window calls with calls to Qdelete_window.
7499 (Fdelete_other_windows): Remove. Deleting other windows is
7500 handled by window.el.
7501 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7502 handled in window.el.
7503 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7504 Window minimum sizes are handled in window.el.
7505 (shrink_windows, size_window, set_window_height)
7506 (set_window_width, change_window_heights, window_height)
7507 (window_width, CURBEG, CURSIZE, enlarge_window)
7508 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7509 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7510 handled in window.el.
7511 (make_dummy_parent): Rename to make_parent_window and give it a
7512 second argument horflag.
7513 (make_window): Don't set resize_proportionally any more.
7514 (Fsplit_window): Remove. Windows are split in window.el.
7515 (save_restore_action, save_restore_orig_size)
7516 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7517 Resize mini windows in window.el.
7518 (grow_mini_window, shrink_mini_window): Implement by calling
7519 Qresize_root_window_vertically, resize_window_check and
7520 resize_window_apply.
7521 (saved_window, Fset_window_configuration, save_window_save):
7522 Do not handle orig_top_line, orig_total_lines, and
7523 resize_proportionally.
7524 (window_min_height, window_min_width): Move to window.el.
7525 (keys_of_window): Move bindings for delete-other-windows,
7526 split-window, delete-window and enlarge-window to window.el.
7527
7528 * buffer.c: Temporarily extern Qdelete_window.
7529 (Fbury_buffer): Temporarily call Qdelete_window instead of
7530 Fdelete_window (Fbury_buffer will move to window.el soon).
7531
7532 * frame.c (set_menu_bar_lines_1): Remove code handling
7533 orig_top_line and orig_total_lines.
7534
7535 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7536 set_window_height but set heights directly.
7537 (change_frame_size_1): Use resize_frame_windows.
7538
7539 * xdisp.c (init_xdisp): Don't use set_window_height but set
7540 heights directly.
7541
7542 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7543 Use resize_frame_windows instead of change_window_heights and run
7544 run_window_configuration_change_hook.
7545
7546 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7547 instead of change_window_heights and run
7548 run_window_configuration_change_hook.
7549
7550 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7551
7552 * window.c (replace_window): Rename second argument REPLACEMENT to
7553 NEW. New third argument SETFLAG. Rewrite.
7554 (delete_window, make_dummy_parent): Call replace_window with
7555 third argument 1.
7556 (window_list_1): Move down in code.
7557 (run_window_configuration_change_hook): Move set_buffer part
7558 before select_frame_norecord part in order to unwind correctly.
7559 Rename count1 to count.
7560 (recombine_windows, delete_deletable_window, resize_root_window)
7561 (Fdelete_other_windows_internal)
7562 (Frun_window_configuration_change_hook, make_parent_window)
7563 (resize_window_check, resize_window_apply, Fresize_window_apply)
7564 (resize_frame_windows, Fsplit_window_internal)
7565 (Fdelete_window_internal, Fresize_mini_window_internal):
7566 New functions.
7567 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7568
7569 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7570
7571 * window.h (window): Add some new members to window structure -
7572 normal_lines, normal_cols, new_total, new_normal, clone_number,
7573 splits, nest, prev_buffers, next_buffers.
7574 (WINDOW_TOTAL_SIZE): Move here from window.c.
7575 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7576
7577 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7578 Remove.
7579 (make_dummy_parent): Set new members of windows structure.
7580 (make_window): Move down in code. Handle new members of window
7581 structure.
7582 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7583 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7584 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7585 (Fset_window_prev_buffers, Fwindow_next_buffers)
7586 (Fset_window_next_buffers, Fset_window_clone_number):
7587 New functions.
7588 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7589 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7590 Doc-string fixes.
7591 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7592 Argument WINDOW can be now internal window too.
7593 (Fwindow_use_time): Move up in code.
7594 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7595 Rewrite doc-string.
7596 (Fset_window_configuration, saved_window)
7597 (Fcurrent_window_configuration, save_window_save): Handle new
7598 members of window structure.
7599 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7600 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7601 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7602 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7603 Qget_mru_window, Qresize_root_window,
7604 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7605 Qauto_buffer_name; staticpro them.
7606
7607 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7608
7609 * window.c (Fwindow_total_size, Fwindow_left_column)
7610 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7611 (Fwindow_list_1): New functions.
7612 (window_box_text_cols): Replace with window_body_cols.
7613 (Fwindow_width, Fscroll_left, Fscroll_right):
7614 Use window_body_cols instead of window_box_text_cols.
7615 (delete_window, Fset_window_configuration):
7616 Call delete_all_subwindows with window as argument.
7617 (delete_all_subwindows): Take a window as argument and not a
7618 structure. Rewrite.
7619 (window_loop): Remove handling of GET_LRU_WINDOW and
7620 GET_LARGEST_WINDOW.
7621 (Fget_lru_window, Fget_largest_window): Move to window.el.
7622
7623 * window.h: Extern window_body_cols instead of
7624 window_box_text_cols. delete_all_subwindows now takes a
7625 Lisp_Object as argument.
7626
7627 * indent.c (compute_motion, Fcompute_motion):
7628 Use window_body_cols instead of window_box_text_cols.
7629
7630 * frame.c (delete_frame): Call delete_all_subwindows with root
7631 window as argument.
7632
7633 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7634
7635 * fns.c (Fputhash): Document return value.
7636
7637 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7638
7639 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7640
7641 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7642
7643 Cons<->int and similar integer overflow fixes (Bug#8794).
7644
7645 Check for overflow when converting integer to cons and back.
7646 * charset.c (Fdefine_charset_internal, Fdecode_char):
7647 Use cons_to_unsigned to catch overflow.
7648 (Fencode_char): Use INTEGER_TO_CONS.
7649 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7650 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7651 * data.c (long_to_cons, cons_to_long): Remove.
7652 (cons_to_unsigned, cons_to_signed): New functions.
7653 These signal an error for invalid or out-of-range values.
7654 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7655 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7656 * font.c (Ffont_variation_glyphs):
7657 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7658 * lisp.h: Include <intprops.h>.
7659 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7660 (cons_to_signed, cons_to_unsigned): New decls.
7661 (long_to_cons, cons_to_long): Remove decls.
7662 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7663 (Fprimitive_undo): Use CONS_TO_INTEGER.
7664 * xfns.c (Fx_window_property): Likewise.
7665 * xselect.c: Include <limits.h>.
7666 (x_own_selection, selection_data_to_lisp_data):
7667 Use INTEGER_TO_CONS.
7668 (x_handle_selection_request, x_handle_selection_clear)
7669 (x_get_foreign_selection, Fx_disown_selection_internal)
7670 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7671 (lisp_data_to_selection_data): Use cons_to_unsigned.
7672 (x_fill_property_data): Use cons_to_signed.
7673 Report values out of range.
7674
7675 Check for buffer and string overflow more precisely.
7676 * buffer.h (BUF_BYTES_MAX): New macro.
7677 * lisp.h (STRING_BYTES_MAX): New macro.
7678 * alloc.c (Fmake_string):
7679 * character.c (string_escape_byte8):
7680 * coding.c (coding_alloc_by_realloc):
7681 * doprnt.c (doprnt):
7682 * editfns.c (Fformat):
7683 * eval.c (verror):
7684 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7685 since they may not be the same number.
7686 * editfns.c (Finsert_char):
7687 * fileio.c (Finsert_file_contents):
7688 Likewise for BUF_BYTES_MAX.
7689
7690 * image.c: Use ptrdiff_t, not int, for sizes.
7691 (slurp_file): Switch from int to ptrdiff_t.
7692 All uses changed.
7693 (slurp_file): Check that file size fits in both size_t (for
7694 malloc) and ptrdiff_t (for sanity and safety).
7695
7696 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7697 if b->modtime has its maximal value.
7698
7699 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7700
7701 Don't assume time_t can fit into int.
7702 * buffer.h (struct buffer.modtime): Now time_t, not int.
7703 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7704 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7705
7706 Minor fixes for signed vs unsigned integers.
7707 * character.h (MAYBE_UNIFY_CHAR):
7708 * charset.c (maybe_unify_char):
7709 * keyboard.c (read_char, reorder_modifiers):
7710 XINT -> XFASTINT, since the integer must be nonnegative.
7711 * ftfont.c (ftfont_spec_pattern):
7712 * keymap.c (access_keymap, silly_event_symbol_error):
7713 XUINT -> XFASTINT, since the integer must be nonnegative.
7714 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7715 since it makes no difference and we prefer signed.
7716 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7717 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7718 nonnegative.
7719
7720 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7721
7722 * window.h (Fwindow_frame): Declare.
7723
7724 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7725
7726 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7727 (SPARE_MEMORY): Always define.
7728 (LARGE_REQUEST): Remove.
7729 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7730
7731 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7732
7733 * lisp.h: Move EXFUNS for Fframe_root_window,
7734 Fframe_first_window and Fset_frame_selected_window to window.h.
7735
7736 * window.h: Move EXFUNS for Fframe_root_window,
7737 Fframe_first_window and Fset_frame_selected_window here from
7738 lisp.h.
7739
7740 * frame.c (Fwindow_frame, Fframe_first_window)
7741 (Fframe_root_window, Fframe_selected_window)
7742 (Fset_frame_selected_window): Move to window.c.
7743 (Factive_minibuffer_window): Move to minibuf.c.
7744 (Fother_visible_frames_p): New function.
7745
7746 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7747
7748 * window.c (decode_window, decode_any_window): Move up in code.
7749 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7750 (inhibit_frame_unsplittable): Remove unused variable.
7751 (Fwindow_buffer): Move up and rewrite doc-string.
7752 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7753 (Fwindow_prev): New functions.
7754 (Fwindow_frame): Move here from frame.c. Accept any window as
7755 argument.
7756 (Fframe_root_window, Fframe_first_window)
7757 (Fframe_selected_window): Move here from frame.c. Accept frame
7758 or arbitrary window as argument. Update doc-strings.
7759 (Fminibuffer_window): Move up in code.
7760 (Fwindow_minibuffer_p): Move up in code and simplify.
7761 (Fset_frame_selected_window): Move here from frame.c.
7762 Marginal rewrite.
7763 (Fselected_window, select_window, Fselect_window): Move up in
7764 code. Minor doc-string fixes.
7765
7766 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7767
7768 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7769 Do not assume that spare memory exists; that assumption is valid
7770 only if SYSTEM_MALLOC.
7771 (LARGE_REQUEST): New macro, so that the issue of large requests
7772 is separated from the issue of spare memory.
7773
7774 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7775
7776 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7777 format. (Bug#8806)
7778
7779 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7780
7781 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7782 before statements.
7783
7784 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7785
7786 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7787
7788 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7789
7790 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7791 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7792
7793 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7794
7795 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7796
7797 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7798
7799 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7800 (x_clipboard_manager_save): Add return value.
7801 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7802 New error handlers.
7803 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7804 Obey Vx_select_enable_clipboard_manager. Catch errors in
7805 x_clipboard_manager_save (Bug#8779).
7806 (Vx_select_enable_clipboard_manager): New variable.
7807 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7808
7809 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7810
7811 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7812
7813 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7814
7815 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7816 in the current matrix if keep_current_p is non-zero.
7817
7818 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7819
7820 * bidi.c (bidi_level_of_next_char): Fix last change.
7821
7822 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7823
7824 Support bidi reordering of text covered by display properties.
7825
7826 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7827 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7828 (bidi_cache_search, bidi_cache_iterator_state)
7829 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7830 (bidi_level_of_next_char, bidi_move_to_visually_next):
7831 Support character positions inside a run of characters covered by a
7832 display string.
7833 (bidi_paragraph_init, bidi_resolve_explicit_1)
7834 (bidi_level_of_next_char): Call bidi_fetch_char and
7835 bidi_fetch_char_advance instead of FETCH_CHAR and
7836 FETCH_CHAR_ADVANCE.
7837 (bidi_init_it): Initialize new members.
7838 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7839 definitions.
7840 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7841 instead of using explicit *_CHAR codes.
7842 (bidi_resolve_explicit, bidi_resolve_weak):
7843 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7844 bidirectional text is supported only in multibyte buffers.
7845 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7846 it to initialize the frame_window_p member of struct bidi_it.
7847 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7848 (bidi_resolve_explicit, bidi_resolve_weak)
7849 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7850 bidi_it->nchars is non-positive.
7851 (bidi_level_of_next_char): Don't try to lookup the cache for the
7852 next/previous character if nothing is cached there yet, or if we
7853 were just reseat()'ed to a new position.
7854
7855 * xdisp.c (set_cursor_from_row): Set start and stop points
7856 according to the row's direction when priming the loop that looks
7857 for the glyph on which to display cursor.
7858 (single_display_spec_intangible_p): Function deleted.
7859 (display_prop_intangible_p): Reimplement to call
7860 handle_display_spec instead of single_display_spec_intangible_p.
7861 Accept 3 additional arguments needed by handle_display_spec.
7862 This fixes incorrect cursor motion across display property with complex
7863 values: lists, `(when COND...)' forms, etc.
7864 (single_display_spec_string_p): Support property values that are
7865 lists with the argument STRING its top-level element.
7866 (display_prop_string_p): Fix the condition for processing a
7867 property that is a list to be consistent with handle_display_spec.
7868 (handle_display_spec): New function, refactored from the
7869 last portion of handle_display_prop.
7870 (compute_display_string_pos): Accept additional argument
7871 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7872 value of a `display' property is a "replacing spec".
7873 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7874 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7875 the display property, but just return a value indicating whether
7876 the display property will replace the characters it covers.
7877 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7878 frame_window_p members of struct bidi_it.
7879 (compute_display_string_pos, compute_display_string_end):
7880 New functions.
7881 (push_it): Accept second argument POSITION, where pop_it should
7882 jump to continue iteration.
7883 (reseat_1): Initialize bidi_it.disp_pos.
7884
7885 * keyboard.c (adjust_point_for_property): Adjust the call to
7886 display_prop_intangible_p to its new signature.
7887
7888 * dispextern.h (struct bidi_it): New member frame_window_p.
7889 (bidi_init_it): Update prototypes.
7890 (display_prop_intangible_p): Update prototype.
7891 (compute_display_string_pos, compute_display_string_end):
7892 Declare prototypes.
7893 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7894 EMACS_INT.
7895
7896 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7897
7898 Malloc failure behavior now depends on size of allocation.
7899 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7900 * lisp.h: Change signatures accordingly.
7901 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7902 All callers changed. (Bug#8762)
7903
7904 * gnutls.c: Use Emacs's memory allocators.
7905 Without this change, the gnutls library would invoke malloc etc.
7906 directly, which causes problems on non-SYNC_INPUT hosts, and which
7907 runs afoul of improving memory_full behavior. (Bug#8761)
7908 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7909 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7910 xfree instead of the default malloc, realloc, free.
7911 (Fgnutls_boot): No need to check for memory allocation failure,
7912 since xmalloc does that for us.
7913
7914 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7915 * category.c (hash_get_category_set):
7916 * ccl.c (ccl_driver):
7917 * charset.c (Fdefine_charset_internal):
7918 * charset.h (struct charset.hash_index):
7919 * composite.c (get_composition_id, gstring_lookup_cache)
7920 (composition_gstring_put_cache):
7921 * composite.h (struct composition.hash_index):
7922 * dispextern.h (struct image.hash):
7923 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7924 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7925 (hashfn_equal, hashfn_user_defined, make_hash_table)
7926 (maybe_resize_hash_table, hash_lookup, hash_put)
7927 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7928 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7929 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7930 * image.c (make_image, search_image_cache, lookup_image)
7931 (xpm_put_color_table_h):
7932 * lisp.h (struct Lisp_Hash_Table):
7933 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7934 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7935 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7936 * alloc.c (allocate_vectorlike):
7937 Check for overflow in vector size calculations.
7938 * ccl.c (ccl_driver):
7939 Check for overflow when converting EMACS_INT to int.
7940 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7941 need to be updated by these changes.
7942 * fns.c (make_hash_table, maybe_resize_hash_table):
7943 Check for integer overflow with large hash tables.
7944 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7945 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7946 (SXHASH_REDUCE): New macro.
7947 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7948 Use it instead of discarding useful hash info with large hash values.
7949 (sxhash_float): New function.
7950 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7951 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7952 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7953 Rewrite to use FIXNUM_BITS, as this simplifies things.
7954 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7955 Adjust signatures to match updated version of code.
7956 (consing_since_gc): Now EMACS_INT, since a single hash table can
7957 use more than INT_MAX bytes.
7958
7959 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7960
7961 Make it possible to build with GCC-4.6+ -O2 -flto.
7962
7963 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7964
7965 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7966
7967 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7968 Call minibuffer-inactive-mode.
7969
7970 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7971
7972 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7973 Update dependencies.
7974
7975 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7976
7977 * data.c (init_data): Remove code for UTS, this system is not
7978 supported anymore.
7979
7980 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7981
7982 Don't force ./temacs to start in terminal mode.
7983
7984 * frame.c (make_initial_frame): Initialize faces in all cases, not
7985 only when CANNOT_DUMP is defined.
7986 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7987
7988 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7989
7990 * dispnew.c (add_window_display_history): Use const for the string
7991 pointer. Remove declaration, not needed.
7992
7993 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7994
7995 Use 'inline', not 'INLINE'.
7996 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7997 * alloc.c, fontset.c (INLINE): Remove.
7998 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7999 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8000 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8001 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8002 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8003
8004 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8005
8006 Make it possible to run ./temacs.
8007
8008 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8009 syms_of_callproc does the same thing. Remove test for
8010 "initialized", do it in the caller.
8011 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8012
8013 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8014
8015 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8016 (read_minibuf): Use get_minibuffer.
8017 (syms_of_minibuf): Use DEFSYM.
8018 (Qmetadata): New var.
8019 * data.c (Qbuffer): Don't make it static.
8020 (syms_of_data): Use DEFSYM.
8021
8022 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8023
8024 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8025 (CCL_CODE_MIN): New macro.
8026
8027 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8028
8029 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8030
8031 * eval.c (Qdebug): Now static.
8032 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8033 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8034 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8035
8036 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8037
8038 * image.c: Various fixes to ImageMagick code comments.
8039 (Fimagemagick_types): Doc fix.
8040
8041 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8042
8043 Minor fixes prompted by GCC 4.6.0 warnings.
8044
8045 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8046
8047 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8048 (x_clipboard_manager_save_all): Move extern decl to ...
8049 * xterm.h: ... here, so that it can be checked for consistency.
8050
8051 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8052
8053 * xselect.c (x_clipboard_manager_save_frame)
8054 (x_clipboard_manager_save_all): New functions.
8055 (Fx_clipboard_manager_save): Lisp function deleted.
8056
8057 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8058 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8059
8060 * xterm.h: Update prototype.
8061
8062 2011-05-28 William Xu <william.xwl@gmail.com>
8063
8064 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8065 exiting (Bug#8239).
8066
8067 2011-05-28 Jim Meyering <meyering@redhat.com>
8068
8069 Avoid a sign-extension bug in crypto_hash_function.
8070 * fns.c (to_uchar): Define.
8071 (crypto_hash_function): Use it to convert some newly-signed
8072 variables to unsigned, to avoid sign-extension bugs. For example,
8073 without this change, (md5 "truc") would evaluate to
8074 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8075 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8076 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8077
8078 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8079
8080 Integer overflow fixes.
8081
8082 * dbusbind.c: Serial number integer overflow fixes.
8083 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8084 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8085 to hold a serial number that is too large for a fixnum.
8086 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8087 Check for serial numbers out of range. Decode any serial number
8088 that was so large that it became a float. (Bug#8722)
8089
8090 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8091 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8092 Use XFASTINT rather than XUINT when numbers are nonnegative.
8093 (xd_append_arg, Fdbus_method_return_internal):
8094 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8095 arguments, check that Lisp number is nonnegative, rather than
8096 silently wrapping negative numbers around. (Bug#8722)
8097 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8098 (Bug#8722)
8099
8100 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8101
8102 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8103
8104 ccl: Add integer overflow checks.
8105 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8106 (IN_INT_RANGE): New macros.
8107 (ccl_driver): Use them to check for integer overflow when
8108 decoding a CCL program. Many of the new checks are whether XINT (x)
8109 fits in int; it doesn't always, on 64-bit hosts. The new version
8110 doesn't catch all possible integer overflows, but it's an
8111 improvement. (Bug#8719)
8112
8113 * alloc.c (make_event_array): Use XINT, not XUINT.
8114 There's no need for unsigned here.
8115
8116 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8117 This follows up to the 2011-05-06 change that substituted uintptr_t
8118 for EMACS_INT. This case wasn't caught back then.
8119
8120 Rework Fformat to avoid integer overflow issues.
8121 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8122 now (part of C89). Include <verify.h>.
8123 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8124 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8125 (Fformat): Avoid the prepass trying to compute sizes; it was only
8126 approximate and thus did not catch overflow reliably. Instead, walk
8127 through the format just once, formatting and computing sizes as we go,
8128 checking for integer overflow at every step, and allocating a larger
8129 buffer as needed. Keep track separately whether the format is
8130 multibyte. Keep only the most-recently calculated precision, rather
8131 than them all. Record whether each argument has been converted to
8132 string. Use EMACS_INT, not int, for byte and char and arg counts.
8133 Support field widths and precisions larger than INT_MAX. Avoid
8134 sprintf's undefined behavior with conversion specifications such as %#d
8135 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8136 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8137 formatting out-of-range floating point numbers with int
8138 formats. (Bug#8668)
8139
8140 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8141
8142 * data.c: Avoid integer truncation in expressions involving floats.
8143 * data.c: Include <intprops.h>.
8144 (arith_driver): When there's an integer overflow in an expression
8145 involving floating point, convert the integers to floating point
8146 so that the resulting value does not suffer from catastrophic
8147 integer truncation. For example, on a 64-bit host (* 4
8148 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8149 Do not rely on undefined behavior after integer overflow.
8150
8151 merge count_size_as_multibyte, parse_str_to_multibyte
8152 * character.c, character.h (count_size_as_multibyte):
8153 Rename from parse_str_to_multibyte; all uses changed.
8154 Check for integer overflow.
8155 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8156 since it's now a duplicate of the other. This is more of
8157 a character than a buffer op, so better that it's in character.c.
8158 * fns.c, print.c: Adjust to above changes.
8159
8160 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8161
8162 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8163
8164 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8165
8166 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8167 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8168 (x_clipboard_manager_save): Now static.
8169 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8170
8171 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8172 (crypto_hash_function): Now static.
8173 Fix pointer signedness problems. Avoid unnecessary initializations.
8174
8175 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8176
8177 * termhooks.h (Vselection_alist): Make it terminal-local.
8178
8179 * terminal.c (create_terminal): Initialize it.
8180
8181 * xselect.c: Support for clipboard managers.
8182 (Vselection_alist): Move to termhooks.h as terminal-local var.
8183 (LOCAL_SELECTION): New macro.
8184 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8185 (symbol_to_x_atom): Remove gratuitous arg.
8186 (x_handle_selection_request, lisp_data_to_selection_data)
8187 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8188 (x_own_selection, x_get_local_selection, x_convert_selection):
8189 New arg, specifying work frame. Use terminal-local Vselection_alist.
8190 (some_frame_on_display): Delete unused function.
8191 (Fx_own_selection_internal, Fx_get_selection_internal)
8192 (Fx_disown_selection_internal, Fx_selection_owner_p)
8193 (Fx_selection_exists_p): New optional frame arg.
8194 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8195 (x_handle_selection_clear): Don't treat other terminals with the
8196 same keyboard specially. Use the terminal-local Vselection_alist.
8197 (x_clear_frame_selections): Use Frun_hook_with_args.
8198
8199 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8200
8201 * xterm.h: Add support for those atoms.
8202
8203 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8204
8205 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8206 (converted_selections, conversion_fail_tag): New global variables.
8207 (x_selection_request_lisp_error): Free the above.
8208 (x_get_local_selection): Remove unnecessary code.
8209 (x_reply_selection_request): Args changed; handle arbitrary array
8210 of converted selections stored in converted_selections.
8211 Separate the XChangeProperty and SelectionNotify steps.
8212 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8213 (x_convert_selection): New function.
8214 (x_handle_selection_event): Simplify.
8215 (x_get_foreign_selection): Don't ignore incoming requests while
8216 waiting for an answer; this will fail when we implement
8217 SAVE_TARGETS, and seems unnecessary anyway.
8218 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8219 (Vx_sent_selection_functions): Doc fix.
8220
8221 2011-05-26 Leo Liu <sdl.web@gmail.com>
8222
8223 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8224
8225 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8226
8227 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8228
8229 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8230 for fringe update if it has periodic bitmap.
8231 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8232 and fringe_bitmap_periodic_p.
8233
8234 * fringe.c (get_fringe_bitmap_data): New function.
8235 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8236 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8237 row. Mark glyph row for fringe update if periodicity changed.
8238
8239 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8240 for fringe update unless it has periodic bitmap.
8241
8242 2011-05-25 Kenichi Handa <handa@m17n.org>
8243
8244 * xdisp.c (get_next_display_element): Set correct it->face_id for
8245 a static composition.
8246
8247 2011-05-24 Leo Liu <sdl.web@gmail.com>
8248
8249 * deps.mk (fns.o):
8250 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8251
8252 * fns.c (crypto_hash_function, Fsha1): New function.
8253 (Fmd5): Use crypto_hash_function.
8254 (syms_of_fns): Add Ssha1.
8255
8256 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8257
8258 * gnutls.c: Remove unused macros.
8259 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8260 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8261 Remove macros that are defined and never used.
8262 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8263
8264 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8265
8266 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8267 (Fx_get_selection_internal): Minor cleanup.
8268 (Fx_own_selection_internal): Rename arguments for consistency with
8269 select.el.
8270
8271 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8272
8273 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8274
8275 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8276
8277 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8278
8279 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8280
8281 * dispnew.c (scrolling_window): Don't exclude the case that the
8282 last enabled row in the desired matrix touches the bottom boundary.
8283
8284 2011-05-21 Glenn Morris <rgm@gnu.org>
8285
8286 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8287 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8288 and add some more files.
8289
8290 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8291
8292 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8293 report_file_error introduced by the change from 2011-05-07.
8294
8295 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8296
8297 * systime.h (Time): Define only if emacs is defined.
8298 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8299 where the include path doesn't have X11/X.h by default. See
8300 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8301
8302 2011-05-20 Kenichi Handa <handa@m17n.org>
8303
8304 * composite.c (find_automatic_composition): Fix previous change.
8305
8306 2011-05-20 Glenn Morris <rgm@gnu.org>
8307
8308 * lisp.mk: New file, split from Makefile.in.
8309 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8310 (shortlisp): Remove.
8311 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8312
8313 2011-05-19 Glenn Morris <rgm@gnu.org>
8314
8315 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8316 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8317 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8318 (lisp): Set the order to that of loadup.el.
8319 (shortlisp): Make it a copy of $lisp.
8320 (SOME_MACHINE_LISP): Remove.
8321 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8322 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8323
8324 2011-05-18 Kenichi Handa <handa@m17n.org>
8325
8326 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8327 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8328 (find_automatic_composition): Mostly rewrite for efficiency.
8329
8330 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8331
8332 * makefile.w32-in: Update dependencies.
8333
8334 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8335
8336 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8337 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8338
8339 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8340
8341 Fix some integer overflow issues, such as string length overflow.
8342
8343 * insdel.c (count_size_as_multibyte): Check for string overflow.
8344
8345 * character.c (lisp_string_width): Check for string overflow.
8346 Use EMACS_INT, not int, for string indexes and lengths; in
8347 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8348 the resulting string length overflows an EMACS_INT; instead,
8349 report a string overflow if no precision given. When checking for
8350 precision exhaustion, use a check that cannot possibly have
8351 integer overflow. (Bug#8675)
8352 * character.h (lisp_string_width): Adjust to new signature.
8353
8354 * alloc.c (string_overflow): New function.
8355 (Fmake_string): Use it. This doesn't change behavior, but saves
8356 a few bytes and will simplify future changes.
8357 * character.c (string_escape_byte8): Likewise.
8358 * lisp.h (string_overflow): New decl.
8359
8360 Fixups, following up to the user-interface timestamp change.
8361 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8362 for UI timestamps, instead of unsigned long.
8363 * msdos.c (mouse_get_pos): Likewise.
8364 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8365 * w32gui.h (Time): Define by including "systime.h" rather than by
8366 declaring it ourselves. (Bug#8664)
8367
8368 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8369 * image.c (clear_image_cache): Likewise.
8370
8371 * term.c (term_mouse_position): Don't assume time_t wraparound.
8372
8373 Be more systematic about user-interface timestamps.
8374 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8375 and sometimes 'EMACS_UINT', to represent these timestamps.
8376 This change causes it to use 'Time' uniformly, as that's what X uses.
8377 This makes the code easier to follow, and makes it easier to catch
8378 integer overflow bugs such as Bug#8664.
8379 * frame.c (Fmouse_position, Fmouse_pixel_position):
8380 Use Time, not unsigned long, for user-interface timestamps.
8381 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8382 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8383 * keyboard.h (last_event_timestamp): Likewise.
8384 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8385 * menu.h (xmenu_show): Likewise.
8386 * term.c (term_mouse_position): Likewise.
8387 * termhooks.h (struct input_event.timestamp): Likewise.
8388 (struct terminal.mouse_position_hook): Likewise.
8389 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8390 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8391 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8392 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8393 what it was before.
8394 * menu.h, termhooks.h: Include "systime.h", for Time.
8395
8396 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8397 Don't assume that the difference between two unsigned long values
8398 can fit into an integer. At this point, we know button_down_time
8399 <= event->timestamp, so the difference must be nonnegative, so
8400 there's no need to cast the result if double-click-time is
8401 nonnegative, as it should be; check that it's nonnegative, just in
8402 case. This bug is triggered when events are more than 2**31 ms
8403 apart (about 25 days). (Bug#8664)
8404
8405 * xselect.c (last_event_timestamp): Remove duplicate decl.
8406 (x_own_selection): Remove needless cast to unsigned long.
8407
8408 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8409 that always fit in int. Use a sentinel instead of a counter, to
8410 avoid a temp and to allay GCC's concerns about possible int overflow.
8411 * frame.h (struct frame): Use int for menu_bar_items_used
8412 instead of EMACS_INT, since it always fits in int.
8413
8414 * menu.c (grow_menu_items): Check for int overflow.
8415
8416 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8417
8418 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8419 Before, the code was not consistent. These values cannot exceed
8420 2**31 - 1 so there's no need to make them unsigned.
8421 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8422 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8423 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8424 as modifiers.
8425 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8426
8427 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8428 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8429 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8430 presumably because the widths might not match.
8431
8432 * window.c (size_window): Avoid needless test at loop start.
8433
8434 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8435
8436 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8437
8438 2011-05-12 Drew Adams <drew.adams@oracle.com>
8439
8440 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8441
8442 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8443
8444 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8445 `width' to `bar_area_x' and `bar_area_width', respectively.
8446 (x_scroll_run): Take account of fringe background extension.
8447
8448 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8449 Rename local vars `left' and `width' to `bar_area_x' and
8450 `bar_area_width', respectively.
8451 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8452 background extension.
8453
8454 2011-05-10 Jim Meyering <meyering@redhat.com>
8455
8456 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8457
8458 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8459
8460 * image.c (Finit_image_library): Return t for built-in image types,
8461 like pbm and xbm. (Bug#8640)
8462
8463 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8464
8465 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8466
8467 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8468
8469 * w32console.c (Fset_screen_color): Doc fix.
8470 (Fget_screen_color): New function.
8471 (syms_of_ntterm): Defsubr it.
8472
8473 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8474 unlink the temporary file if Fcall_process didn't create it in the
8475 first place.
8476 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8477 child process will be redirected to a file specified with `:file'.
8478 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8479 cue to call_process_cleanup not to close that handle.
8480
8481 2011-05-07 Ben Key <bkey76@gmail.com>
8482
8483 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8484 one of two shell specific rules, either bootstrap-temacs-CMD or
8485 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8486 to the previous implementation of the bootstrap-temacs rule.
8487 The bootstrap-temacs-CMD rule is similar to the previous
8488 implementation of the bootstrap-temacs rule except that it
8489 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8490 variable.
8491
8492 These changes, along with some changes to nt/configure.bat,
8493 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8494 earlier fix to add support for --cflags and --ldflags options
8495 that include quotes so that it works whether make uses cmd or
8496 sh as the shell.
8497
8498 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8499
8500 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8501 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8502 is a constant.
8503 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8504 a string. Handle both cases.
8505 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8506 (Fdbus_register_method): Use Qinvalid_function.
8507
8508 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8509
8510 * makefile.w32-in: Update dependencies.
8511 (LISP_H): Add inttypes.h and stdin.h.
8512 (PROCESS_H): Add unistd.h.
8513
8514 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8515
8516 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8517 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8518
8519 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8520
8521 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8522
8523 * term.c (vfatal): Remove stray call to va_end.
8524 It's not needed and the C Standard doesn't allow it here anyway.
8525
8526 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8527 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8528
8529 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8530 bytes.
8531
8532 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8533
8534 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8535
8536 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8537
8538 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8539
8540 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8541
8542 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8543 * charset.c (Fdefine_charset_internal): Don't initialize
8544 charset.code_space[15]. The value was garbage, on hosts with
8545 32-bit int (Bug#8600).
8546
8547 * lread.c (read_integer): Be more consistent with string-to-number.
8548 Use string_to_number to do the actual conversion; this avoids
8549 rounding errors and fixes some other screwups. Without this fix,
8550 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8551 (digit_to_number): Move earlier, for benefit of read_integer.
8552 Return -1 if the digit is out of range for the base, -2 if it is
8553 not a digit in any supported base. (Bug#8602)
8554
8555 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8556
8557 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8558 to match comment at start of function. This also removes a
8559 GCC warning about overflow in a 32+64-bit port.
8560
8561 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8562
8563 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8564 Reported by Stefan Monnier in
8565 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8566 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8567 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8568
8569 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8570 (EMACS_UINTPTR): Likewise, with uintptr_t.
8571
8572 * lisp.h: Prefer 64-bit EMACS_INT if available.
8573 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8574 on 32-bit hosts that have 64-bit int, so that they can access
8575 large files.
8576 However, temporarily disable this change unless the temporary
8577 symbol WIDE_EMACS_INT is defined.
8578
8579 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8580
8581 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8582 This removes an assumption that EMACS_INT and long are the same
8583 width as pointers. The assumption is true for Emacs porting targets
8584 now, but we want to make other targets possible.
8585 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8586 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8587 In the rest of the code, change types of integers that hold casted
8588 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8589 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8590 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8591 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8592 No need to cast type when ORing.
8593 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8594 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8595 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8596 assume EMACS_INT is the same width as char *.
8597 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8598 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8599 Remove no-longer-needed casts.
8600 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8601 (xg_tool_bar_help_callback, xg_make_tool_item):
8602 Use EMACS_INTPTR to hold an integer
8603 that will be cast to void *; this can avoid a GCC warning
8604 if EMACS_INT is not the same width as void *.
8605 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8606 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8607 (current_message_1, set_message_1):
8608 Use a local to convert to proper width without a cast.
8609 * xmenu.c (dialog_selection_callback): Likewise.
8610
8611 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8612 Also, don't assume VALBITS / RAND_BITS is less than 5,
8613 and don't rely on undefined behavior when shifting a 1 left into
8614 the sign bit.
8615 * lisp.h (get_random): Change signature to match.
8616
8617 * lread.c (hash_string): Use size_t, not int, for hash computation.
8618 Normally we prefer signed values; but hashing is special, because
8619 it's better to use unsigned division on hash table sizes so that
8620 the remainder is nonnegative. Also, size_t is the natural width
8621 for hashing into memory. The previous code used 'int', which doesn't
8622 retain enough info to hash well into very large tables.
8623 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8624
8625 * dbusbind.c: Don't possibly lose pointer info when converting.
8626 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8627 Use XPNTR rather than XHASH, so that the high-order bits of
8628 the pointer aren't lost when converting through void *.
8629
8630 * eval.c (Fautoload): Don't double-shift a pointer.
8631
8632 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8633
8634 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8635
8636 * gnutls.c (DEF_GNUTLS_FN):
8637 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8638
8639 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8640
8641 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8642 marker. (Bug#8610)
8643
8644 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8645
8646 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8647 New version that can reserve upto 2GB of heap space.
8648
8649 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8650
8651 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8652
8653 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8654
8655 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8656 `gnutls_certificate_set_x509_key_file'.
8657
8658 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8659
8660 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8661 Update dependencies.
8662
8663 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8664
8665 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8666 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8667 Remove unused parameter `fildes'.
8668 * process.c (read_process_output, send_process): Don't pass it.
8669
8670 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8671
8672 Fix previous change: the library cache is defined in w32.c.
8673 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8674 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8675
8676 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8677
8678 Implement dynamic loading of GnuTLS on Windows.
8679
8680 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8681 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8682 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8683 Declare.
8684
8685 * gnutls.c (Qgnutls_dll): Define.
8686 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8687 (gnutls_*): Declare function pointers.
8688 (init_gnutls_functions): New function to initialize function pointers.
8689 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8690 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8691 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8692 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8693 (emacs_gnutls_write, emacs_gnutls_read)
8694 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8695 (Fgnutls_available_p): New function.
8696 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8697 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8698 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8699
8700 * image.c: Include w32.h.
8701 (Vimage_type_cache): Delete.
8702 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8703 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8704 (w32_delayed_load): Move to w32.c.
8705
8706 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8707
8708 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8709 (w32_delayed_load): Move from image.c. When loading a library, record
8710 its filename in the :loaded-from property of the library id.
8711 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8712 Initialize and staticpro them.
8713 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8714
8715 * process.c: Include lisp.h before w32.h, not after.
8716 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8717 instead of gnutls_record_check_pending.
8718
8719 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8720
8721 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8722
8723 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8724 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8725 as passed in.
8726
8727 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8728
8729 * xterm.c (x_set_frame_alpha): Do not set property on anything
8730 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8731
8732 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8733
8734 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8735
8736 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8739 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8740 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8741 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8742 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8743 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8744 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8745 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8746 (Qgnutls_bootprop_callbacks_verify): Make static.
8747
8748 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8749
8750 * callproc.c: Indentation fixup.
8751
8752 * sysdep.c (wait_for_termination_1): Make static.
8753 (wait_for_termination, interruptible_wait_for_termination):
8754 Move after wait_for_termination_1.
8755
8756 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8757
8758 * sysdep.c (interruptible_wait_for_termination): New function
8759 which is like wait_for_termination, but allows keyboard
8760 interruptions.
8761
8762 * callproc.c (Fcall_process): Add (:file "file") as an option for
8763 the STDOUT buffer.
8764 (Fcall_process_region): Ditto.
8765
8766 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8767
8768 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8769 rather than `XVECTOR (FOO)->size'.
8770
8771 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8772 inttypes.h, as a gnulib replacement is used if it not available in
8773 system headers.
8774
8775 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8776
8777 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8778 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8779 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8780
8781 * coding.c (coding_alloc_by_realloc): Error out if destination
8782 will grow beyond MOST_POSITIVE_FIXNUM.
8783 (decode_coding_emacs_mule): Abort if there isn't enough place in
8784 charbuf for the composition carryover bytes. Reserve an extra
8785 space for up to 2 characters produced in a loop.
8786 (decode_coding_iso_2022): Abort if there isn't enough place in
8787 charbuf for the composition carryover bytes.
8788
8789 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8790
8791 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8792 aborting when %lld or %lll format is passed.
8793 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8794 %llo or %llx format is passed. (Bug#8545)
8795
8796 * window.c (window_scroll_line_based): Use a marker instead of
8797 simple variables to record original value of point. (Bug#7952)
8798
8799 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8800 produced by %s or %c overflows available buffer space. (Bug#8545)
8801
8802 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8803
8804 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8805 (SIZE_MAX): Move defn after all includes, as they might #define it.
8806
8807 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8808
8809 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8810
8811 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8812
8813 * keyboard.c (Qdelayed_warnings_hook): Define.
8814 (command_loop_1): Run `delayed-warnings-hook'
8815 if Vdelayed_warnings_list is non-nil.
8816 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8817 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8818
8819 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8820
8821 * doprnt.c (doprnt): Don't return value smaller than the buffer
8822 size if the message was truncated. (Bug#8545).
8823
8824 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8825
8826 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8827 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8828
8829 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8830
8831 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8832
8833 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8834
8835 * makefile.w32-in: Update dependencies.
8836
8837 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8838
8839 Improve `doprnt' and its usage. (Bug#8545)
8840 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8841 `format_end'. Remove support for %l as a conversion specifier.
8842 Don't use xrealloc. Improve diagnostics when the %l size modifier
8843 is used. Update the commentary.
8844
8845 * eval.c (verror): Simplify calculation of size_t.
8846
8847 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8848 messages.
8849
8850 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8851
8852 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8853 change.
8854
8855 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8856
8857 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8858 This makes this file independent of the recent pseudovector change.
8859
8860 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8861
8862 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8863
8864 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8865 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8866 Remove unused local.
8867 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8868
8869 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8870 GCC 4.6.0 optimizes based on type-based alias analysis.
8871 For example, if b is of type struct buffer * and v of type struct
8872 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8873 != &v->size, and therefore "v->size = 1; b->size = 2; return
8874 v->size;" must therefore return 1. This assumption is incorrect
8875 for Emacs, since it type-puns struct Lisp_Vector * with many other
8876 types. To fix this problem, this patch adds a new type struct
8877 vectorlike_header that documents the constraints on layout of vectors
8878 and pseudovectors, and helps optimizing compilers not get fooled
8879 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8880 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8881 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8882 the size member.
8883 (XSETPVECTYPE): Rewrite in terms of new macro.
8884 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8885 This is a bit clearer, and further avoids the possibility of
8886 undesirable aliasing.
8887 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8888 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8889 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8890 since Lisp_Subr is a special case (no "next" field).
8891 (ASIZE): Now uses header.size rather than size.
8892 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8893 to avoid the hassle of writing XVECTOR (foo)->header.size.
8894 (struct vectorlike_header): New type.
8895 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8896 object, to help avoid aliasing.
8897 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8898 (SUBRP): Likewise, since Lisp_Subr is a special case.
8899 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8900 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8901 (struct Lisp_Hash_Table): Combine first two members into a single
8902 struct vectorlike_header member. All uses of "size" and "next" members
8903 changed to be "header.size" and "header.next".
8904 * buffer.h (struct buffer): Likewise.
8905 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8906 * frame.h (struct frame): Likewise.
8907 * process.h (struct Lisp_Process): Likewise.
8908 * termhooks.h (struct terminal): Likewise.
8909 * window.c (struct save_window_data, struct saved_window): Likewise.
8910 * window.h (struct window): Likewise.
8911 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8912 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8913 * buffer.c (init_buffer_once): Likewise.
8914 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8915 special case.
8916 * process.c (Fformat_network_address): Use local var for size,
8917 for brevity.
8918
8919 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8920
8921 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8922 * data.c (atof): Remove decl; no longer used or needed.
8923 (digit_to_number): Move to lread.c.
8924 (Fstring_to_number): Use new string_to_number function, to be
8925 consistent with how the Lisp reader treats infinities and NaNs.
8926 Do not assume that floating-point numbers represent EMACS_INT
8927 without losing information; this is not true on most 64-bit hosts.
8928 Avoid double-rounding errors, by insisting on integers when
8929 parsing non-base-10 numbers, as the documentation specifies.
8930 * lisp.h (string_to_number): New decl, replacing ...
8931 (isfloat_string): Remove.
8932 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8933 (read1): Do not accept +. and -. as integers; this
8934 appears to have been a coding error. Similarly, do not accept
8935 strings like +-1e0 as floating point numbers. Do not report
8936 overflow for integer overflows unless the base is not 10 which
8937 means we have no simple and reliable way to continue.
8938 Break out the floating-point parsing into a new
8939 function string_to_number, so that Fstring_to_number parses
8940 floating point numbers consistently with the Lisp reader.
8941 (digit_to_number): Move here from data.c. Make it static inline.
8942 (E_CHAR, EXP_INT): Remove, replacing with ...
8943 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8944 (string_to_number): New function, replacing isfloat_string.
8945 This function checks for valid syntax and produces the resulting
8946 Lisp float number too. Rework it so that string-to-number
8947 no longer mishandles examples like "1.0e+". Use strtoumax,
8948 so that overflow for non-base-10 numbers is reported only when
8949 there's no portable and simple way to convert to floating point.
8950
8951 * textprop.c (set_text_properties_1): Rewrite for clarity,
8952 and to avoid GCC warning about integer overflow.
8953
8954 * intervals.h (struct interval): Use EMACS_INT for members
8955 where EMACS_UINT might cause problems. See
8956 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8957 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8958 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8959 All uses changed.
8960 (offset_intervals): Tell GCC not to worry about length overflow
8961 when negating a negative length.
8962
8963 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8964 (overrun_check_free): Likewise.
8965
8966 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8967 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8968 word size.
8969
8970 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8971 (gnutls_make_error): Rename local to avoid shadowing.
8972 (gnutls_emacs_global_deinit): ifdef out; not used.
8973 (Fgnutls_boot): Use const for pointer to readonly storage.
8974 Comment out unused local. Fix pointer signedness problems.
8975
8976 * lread.c (openp): Don't stuff size_t into an 'int'.
8977 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8978 about possible signed overflow.
8979
8980 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8981 (GDK_KEY_g): Don't define if already defined.
8982 (xg_prepare_tooltip): Avoid pointer signedness problem.
8983 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8984
8985 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8986 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8987
8988 * xfns.c (Fx_window_property): Simplify a bit,
8989 to make a bit faster and to avoid GCC 4.6.0 warning.
8990 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8991
8992 * fns.c (internal_equal): Don't assume size_t fits in int.
8993
8994 * alloc.c (compact_small_strings): Tighten assertion a little.
8995
8996 Replace pEd with more-general pI, and fix some printf arg casts.
8997 * lisp.h (pI): New macro, generalizing old pEd macro to other
8998 conversion specifiers. For example, use "...%"pI"d..." rather
8999 than "...%"pEd"...".
9000 (pEd): Remove. All uses replaced with similar uses of pI.
9001 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9002 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9003 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9004 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9005 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9006 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9007 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9008 64-bit hosts.
9009 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9010 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9011 * print.c (safe_debug_print, print_object): Likewise.
9012 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9013 to int.
9014 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9015 avoiding the 0 flag, which is not portable.
9016 * process.c (Fmake_network_process): Use pI to avoid cast.
9017 * region-cache.c (pp_cache): Likewise.
9018 * xdisp.c (decode_mode_spec): Likewise.
9019 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9020 behavior on 64-bit hosts with printf arg.
9021 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9022 (x_stop_queuing_selection_requests): Likewise.
9023 (x_get_window_property): Don't truncate byte count to an 'int'
9024 when tracing.
9025
9026 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9027 here, since it parses constructs like leading '-' and spaces,
9028 which are not wanted; and it overflows with large numbers.
9029 Instead, simply match F[0-9]+, which is what is wanted anyway.
9030
9031 * alloc.c: Remove unportable assumptions about struct layout.
9032 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9033 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9034 (allocate_vectorlike, make_pure_vector): Use the new macros,
9035 plus offsetof, to remove unportable assumptions about struct layout.
9036 These assumptions hold on all porting targets that I know of, but
9037 they are not guaranteed, they're easy to remove, and removing them
9038 makes further changes easier.
9039
9040 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9041 This doesn't fix a bug but makes the code clearer.
9042 (string_overrun_cookie): Now const. Use initializers that
9043 don't formally overflow signed char, to avoid warnings.
9044 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9045 can cause Emacs to crash when string overrun checking is enabled.
9046 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9047 multiple of sizeof (EMACS_INT); it need not be, if
9048 alignof(EMACS_INT) < sizeof (EMACS_INT).
9049 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9050
9051 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9052
9053 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9054
9055 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9056
9057 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9058 supposed to be handshaking. (Bug#8556)
9059 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9060
9061 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9062
9063 * lisp.h (Qdebug): List symbol.
9064 * eval.c (Qdebug): Restore global linkage.
9065 * keyboard.c (debug-on-event): New variable.
9066 (handle_user_signal): Break into debugger when debug-on-event
9067 matches the current signal symbol.
9068
9069 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9070
9071 * alloc.c (check_sblock, check_string_bytes)
9072 (check_string_free_list): Convert to standard C.
9073
9074 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9075
9076 * w32.c (emacs_gnutls_push): Fix typo.
9077
9078 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9079
9080 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9081 "cast to pointer from integer of different size".
9082
9083 Improve doprnt and its use in verror. (Bug#8545)
9084 * doprnt.c (doprnt): Document the set of format control sequences
9085 supported by the function. Use SAFE_ALLOCA instead of always
9086 using `alloca'.
9087
9088 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9089 is one byte too soon. Don't use xrealloc; instead xfree and
9090 xmalloc anew.
9091
9092 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9093
9094 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9095 callbacks stage.
9096
9097 * gnutls.c: Renamed global_initialized to
9098 gnutls_global_initialized. Added internals for the
9099 :verify-hostname-error, :verify-error, and :verify-flags
9100 parameters of `gnutls-boot' and documented those parameters in the
9101 docstring. Start callback support.
9102 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9103 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9104 on error. Return error code.
9105 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9106 (emacs_gnutls_read): Likewise.
9107 (Fgnutls_boot): Return handshake error code.
9108 (emacs_gnutls_handle_error): New function.
9109 (wsaerror_to_errno): Likewise.
9110
9111 * w32.h (emacs_gnutls_pull): Add prototype.
9112 (emacs_gnutls_push): Likewise.
9113
9114 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9115 (emacs_gnutls_push): Likewise.
9116
9117 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9118
9119 * process.c (wait_reading_process_output): Check if GnuTLS
9120 buffered some data internally if no FDs are set for TLS
9121 connections.
9122
9123 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9124 (LIBS): Link to USER_LIBS.
9125 ($(BLD)/gnutls.$(0)): New target.
9126
9127 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9128
9129 * xdisp.c (handle_single_display_spec): Rename the
9130 display_replaced_before_p argument into display_replaced_p, to
9131 make it consistent with the commentary. Fix typos in the
9132 commentary.
9133
9134 * textprop.c (syms_of_textprop): Remove dead code.
9135 (copy_text_properties): Delete obsolete commentary about an
9136 interface that was deleted long ago. Fix typos in the description
9137 of arguments.
9138
9139 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9140 to changes in oldXMenu/XMenu.h from 2011-04-16.
9141 <menu_help_message, prev_menu_help_message>: Constify.
9142 (IT_menu_make_room): menu->help_text is now `const char **';
9143 adjust.
9144
9145 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9146 to changes in oldXMenu/XMenu.h from 2011-04-16.
9147 (struct XMenu): Declare `help_text' `const char **'.
9148
9149 * xfaces.c <Qunspecified>: Make extern again.
9150
9151 * syntax.c: Include sys/types.h before including regex.h, as
9152 required by POSIX.
9153
9154 * doc.c (get_doc_string): Improve the format passed to `error'.
9155
9156 * doprnt.c (doprnt): Improve commentary.
9157
9158 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9159
9160 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9161 them with etags.
9162
9163 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9164 changes in globals.h immediately force recompilation.
9165 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9166 $(CURDIR)/s/ms-w32.h.
9167 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9168
9169 * character.c (Fchar_direction): Function deleted.
9170 (syms_of_character): Don't defsubr it.
9171 <char-direction-table>: Deleted.
9172
9173 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9174
9175 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9176 * doprnt.c: Include limits.h.
9177 (SIZE_MAX): New macro.
9178 (doprnt): Return a size_t value. 2nd arg is now size_t.
9179 Many local variables are now size_t instead of int or unsigned.
9180 Improve overflow protection. Support `l' modifier for integer
9181 conversions. Support %l conversion. Don't assume an EMACS_INT
9182 argument for integer conversions and for %c.
9183
9184 * lisp.h (doprnt): Restore prototype.
9185
9186 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9187 $(SRC)/character.h.
9188
9189 * Makefile.in (base_obj): Add back doprnt.o.
9190
9191 * deps.mk (doprnt.o): Add back prerequisites.
9192 (callint.o): Depend on character.h.
9193
9194 * eval.c (internal_lisp_condition_case): Include the handler
9195 representation in the error message.
9196 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9197 when breaking from the loop.
9198
9199 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9200
9201 * callint.c (Fcall_interactively): When displaying error message
9202 about invalid control letter, pass the character's codepoint, not
9203 a pointer to its multibyte form. Improve display of the character
9204 in octal and display also its hex code.
9205
9206 * character.c (char_string): Use %x to display the (unsigned)
9207 codepoint of an invalid character, to avoid displaying a bogus
9208 negative value.
9209
9210 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9211 `error', not SYMBOL_NAME itself.
9212
9213 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9214 character arguments to `error'.
9215
9216 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9217 to `error' in error message about FINAL_CHAR argument. Make sure
9218 FINAL_CHAR is a character, and use %c when it is passed as
9219 argument to `error'.
9220
9221 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9222
9223 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9224
9225 * w32.c: Include <time.h>.
9226 (sys_localtime): New function.
9227
9228 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9229
9230 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9231
9232 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9233
9234 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9235
9236 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9237 zombies (Bug#8467).
9238
9239 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9240
9241 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9242 gl_state.e_property when gl_state.object is Qt.
9243
9244 * insdel.c (make_gap_larger): Remove limitation of buffer size
9245 to <= INT_MAX.
9246
9247 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9248
9249 * xdisp.c (lookup_glyphless_char_display)
9250 (produce_glyphless_glyph): Handle cons cell entry in
9251 glyphless-char-display.
9252 (Vglyphless_char_display): Document it.
9253
9254 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9255 glyphless-char-display.
9256
9257 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9258
9259 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9260
9261 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9262
9263 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9264 definition for no-X builds.
9265
9266 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9267
9268 Static checks with GCC 4.6.0 and non-default toolkits.
9269
9270 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9271
9272 * process.c (keyboard_bit_set): Define only if SIGIO.
9273 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9274 (send_process): Repair possible setjmp clobbering.
9275
9276 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9277
9278 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9279
9280 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9281
9282 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9283 Define only if needed.
9284
9285 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9286 by pacifying GCC about it. Maybe it's time to retire it?
9287 * xfaces.c (USG, __TIMEVAL__): Likewise.
9288
9289 * dispextern.h (struct redisplay_interface): Rename param
9290 to avoid shadowing.
9291 * termhooks.h (struct terminal): Likewise.
9292 * xterm.c (xembed_send_message): Likewise.
9293
9294 * insdel.c (make_gap_smaller): Define only if
9295 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9296
9297 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9298 it.
9299
9300 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9301 so that we aren't warned about unused symbols.
9302
9303 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9304
9305 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9306
9307 * xfns.c (x_real_positions): Mark locals as initialized.
9308
9309 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9310
9311 * xterm.c: Fix problems found by static analysis with other toolkits.
9312 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9313 (x_dispatch_event): Declare static if USE_GTK, and
9314 define if USE_GTK || USE_X_TOOLKIT.
9315 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9316 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9317 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9318 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9319
9320 * xmenu.c (menu_help_callback): Pointer type fixes.
9321 Use const pointers when pointing at readonly data. Avoid pointer
9322 signedness clashes.
9323 (FALSE): Remove unused macro.
9324 (update_frame_menubar): Remove unused decl.
9325
9326 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9327
9328 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9329 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9330 (single_menu_item): Rename local to avoid shadowing.
9331
9332 * keyboard.c (make_lispy_event): Remove unused local var.
9333
9334 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9335 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9336
9337 * bitmaps: Change bitmaps from unsigned char back to the X11
9338 compatible char. Avoid the old compiler warnings about
9339 out-of-range initializers by using, for example, '\xab' rather
9340 than 0xab.
9341
9342 * xgselect.c (xgselect_initialize): Check vs interface
9343 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9344
9345 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9346
9347 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9348 to read-only memory.
9349
9350 * fns.c (vector): Remove; this old hack is no longer needed.
9351
9352 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9353 Remove unused var.
9354 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9355
9356 * xrdb.c (x_load_resources): Omit unused local.
9357
9358 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9359 (x_window): Rename locals to avoid shadowing.
9360 (USG): Use the kludged USG macro, to pacify gcc.
9361
9362 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9363 (x_term_init): Remove local to avoid shadowing.
9364
9365 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9366
9367 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9368 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9369
9370 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9371
9372 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9373
9374 Fix regex.c, syntax.c and friends for buffers > 2GB.
9375 * syntax.h (struct gl_state_s): Declare character position members
9376 EMACS_INT.
9377
9378 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9379
9380 * textprop.c (verify_interval_modification, interval_of):
9381 Declare arguments EMACS_INT.
9382
9383 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9384 EMACS_INT.
9385
9386 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9387
9388 * indent.c (Fvertical_motion): Local variable it_start is now
9389 EMACS_INT.
9390
9391 * regex.c (re_match, re_match_2, re_match_2_internal)
9392 (bcmp_translate, regcomp, regexec, print_double_string)
9393 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9394 (re_compile_pattern, re_exec): Declare arguments and local
9395 variables `size_t' and `ssize_t' and return values `regoff_t', as
9396 appropriate.
9397 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9398 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9399 <compile_stack_type>: `size' and `avail' are now `size_t'.
9400
9401 * regex.h <regoff_t>: Use ssize_t, not int.
9402 (re_search, re_search_2, re_match, re_match_2): Arguments that
9403 specify buffer/string position and length are now ssize_t and
9404 size_t. Return type is regoff_t.
9405
9406 2011-04-16 Ben Key <bkey76@gmail.com>
9407
9408 * nsfont.m: Fixed bugs in ns_get_family and
9409 ns_descriptor_to_entity that were caused by using free to
9410 deallocate memory blocks that were allocated by xmalloc (via
9411 xstrdup). This caused Emacs to crash when compiled with
9412 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9413 --enable-checking=xmallocoverrun). xfree is now used to
9414 deallocate these memory blocks.
9415
9416 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9417
9418 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9419
9420 emacs_write: Accept and return EMACS_INT for sizes.
9421 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9422 et seq.
9423 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9424 Accept and return EMACS_INT.
9425 (emacs_gnutls_write): Return the number of bytes written on
9426 partial writes.
9427 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9428 (emacs_read, emacs_write): Remove check for negative size, as the
9429 Emacs source code has been audited now.
9430 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9431 (emacs_read, emacs_write): Use it.
9432 * process.c (send_process): Adjust to the new signatures of
9433 emacs_write and emacs_gnutls_write. Do not attempt to store
9434 a byte offset into an 'int'; it might overflow.
9435 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9436
9437 * sound.c: Don't assume sizes fit in 'int'.
9438 (struct sound_device.period_size, alsa_period_size):
9439 Return EMACS_INT, not int.
9440 (struct sound_device.write, vox_write, alsa_write):
9441 Accept EMACS_INT, not int.
9442 (wav_play, au_play): Use EMACS_INT to store sizes and to
9443 record read return values.
9444
9445 2011-04-15 Ben Key <bkey76@gmail.com>
9446
9447 * keyboard.c (Qundefined): Don't declare static since it is used
9448 in nsfns.m.
9449 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9450 static since they are used in nsfont.m.
9451
9452 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9453
9454 * process.c (Qprocessp): Don't declare static.
9455 * lisp.h (Qprocessp): Declare again.
9456
9457 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9458
9459 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9460
9461 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9462
9463 Improve C-level modularity by making more things 'static'.
9464
9465 Don't publish debugger-only interfaces to other modules.
9466 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9467 (verify_bytepos, count_markers): Move decls to the only modules
9468 that need them.
9469 * region-cache.h (pp_cache): Likewise.
9470 * window.h (check_all_windows): Likewise.
9471 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9472
9473 * sysdep.c (croak): Now static, if
9474 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9475 * syssignal.h (croak): Declare only if not static.
9476
9477 * alloc.c (refill_memory_reserve): Now static if
9478 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9479 * lisp.h (refill_memory_reserve): Declare only if not static.
9480
9481 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9482 Define only if USE_LUCID.
9483
9484 * xrdb.c (x_customization_string, x_rm_string): Now static.
9485
9486 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9487 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9488
9489 * xdisp.c (draw_row_with_mouse_face): Now static.
9490 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9491
9492 * window.h (check_all_windows): Mark externally visible.
9493
9494 * window.c (window_deletion_count): Now static.
9495
9496 * undo.c: Make symbols static if they're not exported.
9497 (last_undo_buffer, last_boundary_position, pending_boundary):
9498 Now static.
9499
9500 * textprop.c (interval_insert_behind_hooks): Now static.
9501 (interval_insert_in_front_hooks): Likewise.
9502
9503 * term.c: Make symbols static if they're not exported.
9504 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9505 (max_frame_lines, tty_set_terminal_modes):
9506 (tty_reset_terminal_modes, tty_turn_off_highlight):
9507 (get_tty_terminal): Now static.
9508 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9509 * termhooks.h (term_mouse_moveto): Do not declare if
9510 HAVE_WINDOW_SYSTEM.
9511 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9512 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9513
9514 * sysdep.c: Make symbols static if they're not exported.
9515 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9516 Now static.
9517 (sigprocmask_set, full_mask): Remove; unused.
9518 (wait_debugging): Mark as visible.
9519 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9520 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9521
9522 * syntax.c (syntax_temp): Define only if !__GNUC__.
9523
9524 * sound.c (current_sound_device, current_sound): Now static.
9525
9526 * search.c (searchbufs, searchbuf_head): Now static.
9527
9528 * scroll.c (scroll_cost): Remove; unused.
9529 * dispextern.h (scroll_cost): Remove decl.
9530
9531 * region-cache.h (pp_cache): Mark as externally visible.
9532
9533 * process.c: Make symbols static if they're not exported.
9534 (process_tick, update_tick, create_process, chan_process):
9535 (Vprocess_alist, proc_buffered_char, datagram_access):
9536 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9537 (deactivate_process): Mark defn as static, as well as decl.
9538 * lisp.h (create_process): Remove decl.
9539 * process.h (chan_process, Vprocess_alist): Remove decls.
9540
9541 * print.c: Make symbols static if they're not exported.
9542 (print_depth, new_backquote_output, being_printed, print_buffer):
9543 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9544 (print_interval, print_number_index, initial_stderr_stream):
9545 Now static.
9546 * lisp.h (Fprinc): Remove decl.
9547 (debug_output_compilation_hack): Mark as externally visible.
9548
9549 * sysdep.c (croak): Move decl from here to syssignal.h.
9550 * syssignal.h (croak): Put it here, so the API can be checked when
9551 'croak' is called from dissociate_if_controlling_tty.
9552
9553 * minibuf.c: Make symbols static if they're not exported.
9554 (minibuf_save_list, choose_minibuf_frame): Now static.
9555 * lisp.h (choose_minibuf_frame): Remove decl.
9556
9557 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9558
9559 * lread.c: Make symbols static if they're not exported.
9560 (read_objects, initial_obarray, oblookup_last_bucket_number):
9561 Now static.
9562 (make_symbol): Remove; unused.
9563 * lisp.h (initial_obarray, make_symbol): Remove decls.
9564
9565 * keyboard.c: Make symbols static if they're not exported.
9566 (single_kboard, recent_keys_index, total_keys, recent_keys):
9567 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9568 (this_single_command_key_start, echoing, last_auto_save):
9569 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9570 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9571 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9572 (Vlispy_mouse_stem, double_click_count):
9573 Now static.
9574 (force_auto_save_soon): Define only if SIGDANGER.
9575 (ignore_mouse_drag_p): Now static if
9576 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9577 (print_help): Remove; unused.
9578 (stop_character, last_timer_event): Mark as externally visible.
9579 * keyboard.h (ignore_mouse_drag_p): Declare only if
9580 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9581 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9582 * lisp.h (echoing): Remove decl.
9583 (force_auto_save_soon): Declare only if SIGDANGER.
9584 * xdisp.c (redisplay_window): Simplify code, to make it more
9585 obvious that ignore_mouse_drag_p is not accessed if !defined
9586 USE_GTK && !defined HAVE_NS.
9587
9588 * intervals.c: Make symbols static if they're not exported.
9589 (merge_properties_sticky, merge_interval_right, delete_interval):
9590 Now static.
9591 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9592
9593 * insdel.c: Make symbols static if they're not exported.
9594 However, leave prepare_to_modify_buffer alone. It's never
9595 called from outside this function, but that appears to be a bug.
9596 (combine_after_change_list, combine_after_change_buffer):
9597 (adjust_after_replace, signal_before_change): Now static.
9598 (adjust_after_replace_noundo): Remove; unused.
9599 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9600 (signal_before_change): Remove decls.
9601
9602 * indent.c (val_compute_motion, val_vmotion): Now static.
9603
9604 * image.c: Make symbols static if they're not exported.
9605 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9606 if USE_GTK.
9607 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9608 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9609
9610 * fringe.c (standard_bitmaps): Now static.
9611 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9612
9613 * frame.c: Make symbols static if they're not exported.
9614 (x_report_frame_params, make_terminal_frame): Now static.
9615 (get_frame_param): Now static, unless HAVE_NS.
9616 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9617 (x_get_resource_string): Remove; not used.
9618 * frame.h (make_terminal_frame, x_report_frame_params):
9619 (x_get_resource_string); Remove decls.
9620 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9621 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9622
9623 * font.c, fontset.c: Make symbols static if they're not exported.
9624 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9625 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9626 * font.c (font_close_object): Now static.
9627 * font.h (font_close_object): Remove.
9628 * fontset.c (FONTSET_OBJLIST): Remove.
9629 (free_realized_fontset) #if-0 the body, which does nothing.
9630 (face_suitable_for_char_p): #if-0, as it's never called.
9631 * fontset.h (face_suitable_for_char_p): Remove decl.
9632 * xfaces.c (face_at_string_position):
9633 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9634 since 0 is always ASCII.
9635
9636 * fns.c (weak_hash_tables): Now static.
9637
9638 * fileio.c: Make symbols static if they're not exported.
9639 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9640 (Vwrite_region_annotation_buffers): Now static.
9641
9642 * eval.c: Make symbols static if they're not exported.
9643 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9644 * lisp.h (backtrace_list): Remove decl.
9645
9646 * emacs.c: Make symbols static if they're not exported.
9647 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9648 (fatal_error_code, fatal_error_signal_hook, standard_args):
9649 Now static.
9650 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9651 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9652 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9653 * lisp.h (fatal_error_signal_hook): Remove decl.
9654 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9655
9656 * editfns.c: Move a (normally-unused) function to its only use.
9657 * editfns.c, lisp.h (get_operating_system_release): Remove.
9658 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9659 worth the hassle of breaking this out.
9660
9661 * xterm.c: Make symbols static if they're not exported.
9662 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9663 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9664 (x_destroy_window, x_delete_display):
9665 Now static.
9666 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9667 (x_mouse_leave): Remove; unused.
9668 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9669 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9670 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9671 Remove decls.
9672 (x_mouse_leave): Declare only if WINDOWSNT.
9673 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9674 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9675 USE_X_TOOLKIT.
9676
9677 * ftxfont.c: Make symbols static if they're not exported.
9678 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9679 HAVE_FREETYPE.
9680 * font.h (ftxfont_driver): Likewise.
9681
9682 * xfns.c: Make symbols static if they're not exported.
9683 (x_last_font_name, x_display_info_for_name):
9684 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9685 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9686 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9687 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9688 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9689 (last_show_tip_args): Now static.
9690 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9691 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9692 (x_screen_planes): Remove; unused.
9693 * dispextern.h (x_screen_planes): Remove decl.
9694
9695 * dispnew.c: Make symbols static if they're not exported.
9696 * dispextern.h (redraw_garbaged_frames, scrolling):
9697 (increment_row_positions): Remove.
9698 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9699 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9700 Now static.
9701 (redraw_garbaged_frames): Remove; unused.
9702
9703 * xfaces.c: Make symbols static if they're not exported.
9704 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9705 Remove decls.
9706 * xterm.h (defined_color): Remove decls.
9707 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9708 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9709 (menu_face_changed_default, defined_color, free_realized_face):
9710 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9711 (ascii_face_of_lisp_face): Remove; unused.
9712
9713 * xdisp.c: Make symbols static if they're not exported.
9714 * dispextern.h (scratch_glyph_row, window_box_edges):
9715 (glyph_to_pixel_coords, set_cursor_from_row):
9716 (get_next_display_element, set_iterator_to_next):
9717 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9718 (show_mouse_face): Remove decls
9719 * frame.h (message_buf_print): Likewise.
9720 * lisp.h (pop_message, set_message, check_point_in_composition):
9721 Likewise.
9722 * xterm.h (set_vertical_scroll_bar): Likewise.
9723 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9724 (message_buf_print, scratch_glyph_row, displayed_buffer):
9725 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9726 (get_next_display_element, show_mouse_face, window_box_edges):
9727 (frame_to_window_pixel_xy, check_point_in_composition):
9728 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9729 (glyph_to_pixel_coords): Remove; unused.
9730
9731 * dired.c (file_name_completion): Now static.
9732
9733 * dbusbind.c (xd_in_read_queued_messages): Now static.
9734
9735 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9736 * data.c (circular_list_error): Remove.
9737
9738 * commands.h (last_point_position, last_point_position_buffer):
9739 (last_point_position_window): Remove decls.
9740 * keyboard.c: Make these variables static.
9741
9742 * coding.h (coding, code_convert_region, encode_coding_gap):
9743 Remove decls.
9744 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9745 (iso_code_class, detect_coding, code_convert_region): Now static.
9746 (encode_coding_gap): Remove; unused.
9747
9748 * chartab.c (chartab_chars, chartab_bits): Now static.
9749
9750 * charset.h (charset_iso_8859_1): Remove decl.
9751 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9752 Now static.
9753
9754 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9755 * ccl.c (Vccl_program_table): Now static.
9756 (check_ccl_update): Remove; unused.
9757
9758 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9759 * category.h: ... from here.
9760 * category.c (check_category_table, set_category_set): Now static.
9761
9762 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9763 * lisp.h: Remove these decls.
9764
9765 * buffer.c (buffer_count): Remove unused var.
9766
9767 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9768 so that it's not optimized away.
9769 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9770 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9771 exported only to the debugger.
9772
9773 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9774 * atimer.h (run_all_atimers): Remove; not exported.
9775
9776 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9777 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9778 was inaccessible from Lisp.
9779 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9780 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9781
9782 alloc.c: Import and export fewer symbols, and remove unused items.
9783 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9784 is defined.
9785 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9786 it's not optimized away by whole-program optimization.
9787 (message_enable_multibyte, free_misc): Remove.
9788 (catchlist, handlerlist, mark_backtrace):
9789 Declare only if BYTE_MARK_STACK.
9790 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9791 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9792 (message_enable_multibyte): Remove decl.
9793 (free_misc, interval_free_list, float_block, float_block_index):
9794 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9795 (cons_free_list, last_marked_index):
9796 Now static.
9797 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9798 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9799 (mark_backtrace): Define only if BYTE_MARK_STACK.
9800 * xdisp.c (message_enable_multibyte): Now static.
9801
9802 Declare Lisp_Object Q* variables to be 'static' if not exported.
9803 This makes it easier for human readers (and static analyzers)
9804 to see whether these variables are used from other modules.
9805 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9806 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9807 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9808 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9809 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9810 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9811 * xmenu.c, xselect.c:
9812 Declare Q* vars static if they are not used in other modules.
9813 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9814 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9815 Remove decls of unexported vars.
9816 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9817
9818 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9819
9820 Make Emacs functions such as Fatom 'static' by default.
9821 This makes it easier for human readers (and static analyzers)
9822 to see whether these functions can be called from other modules.
9823 DEFUN now defines a static function. To make the function external
9824 so that it can be used in other C modules, use the new macro DEFUE.
9825 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9826 (Finit_image_library):
9827 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9828 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9829 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9830 Remove decls, since these functions are now static.
9831 (Funintern, Fget_internal_run_time): New decls, since these functions
9832 were already external.
9833
9834 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9835 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9836 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9837 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9838 * keyboard.c, keymap.c, lread.c:
9839 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9840 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9841 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9842 Mark functions with DEFUE instead of DEFUN,
9843 if they are used in other modules.
9844 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9845 decls for now-static functions.
9846 * buffer.h (Fdelete_overlay): Remove decl.
9847 * callproc.c (Fgetenv_internal): Mark as internal.
9848 * composite.c (Fremove_list_of_text_properties): Remove decl.
9849 (Fcomposition_get_gstring): New forward static decl.
9850 * composite.h (Fcomposite_get_gstring): Remove decl.
9851 * dired.c (Ffile_attributes): New forward static decl.
9852 * doc.c (Fdocumntation_property): New forward static decl.
9853 * eval.c (Ffetch_bytecode): New forward static decl.
9854 (Funintern): Remove extern decl; now in .h file where it belongs.
9855 * fileio.c (Fmake_symbolic_link): New forward static decl.
9856 * image.c (Finit_image_library): New forward static decl.
9857 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9858 * intervals.h (Fprevious_property_change):
9859 (Fremove_list_of_text_properties): Remove decls.
9860 * keyboard.c (Fthis_command_keys): Remove decl.
9861 (Fcommand_execute): New forward static decl.
9862 * keymap.c (Flookup_key): New forward static decl.
9863 (Fcopy_keymap): Now static.
9864 * keymap.h (Flookup_key): Remove decl.
9865 * process.c (Fget_process): New forward static decl.
9866 (Fprocess_datagram_address): Mark as internal.
9867 * syntax.c (Fsyntax_table_p): New forward static decl.
9868 (skip_chars): Remove duplicate decl.
9869 * textprop.c (Fprevious_property_change): New forward static decl.
9870 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9871 Now internal.
9872 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9873 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9874
9875 * editfns.c (Fformat): Remove unreachable code.
9876
9877 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9878
9879 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9880 change. (Bug#8496)
9881
9882 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9883
9884 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9885 when at ZV. (Bug#8487)
9886
9887 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9888
9889 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9890 (Bug#8437)
9891 * keyboard.c (parse_tool_bar_item): Likewise.
9892 * sound.c (sound_cleanup, alsa_close): Likewise.
9893 * termcap.c (tgetent): Likewise.
9894 * xfns.c (x_default_font_parameter): Likewise.
9895 * xsettings.c (read_and_apply_settings): Likewise.
9896
9897 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9898 (overrun_check_free): Protoize.
9899
9900 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9901
9902 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9903 since callers should never pass a negative size.
9904 Change the signature to match that of plain 'read' and 'write'; see
9905 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9906 * lisp.h: Update prototypes of emacs_write and emacs_read.
9907
9908 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9909
9910 * xdisp.c (redisplay_window): Don't try to determine the character
9911 position of the scroll margin if the window start point w->startp
9912 is outside the buffer's accessible region. (Bug#8468)
9913
9914 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9915
9916 Fix write-region and its subroutines for buffers > 2GB.
9917 * fileio.c (a_write, e_write): Modify declaration of arguments and
9918 local variables to support buffers larger than 2GB.
9919 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9920
9921 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9922 argument, local variables, and return value.
9923
9924 * lisp.h: Update prototypes of emacs_write and emacs_read.
9925
9926 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9927
9928 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9929
9930 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9931
9932 Fix more problems found by GCC 4.6.0's static checks.
9933
9934 * xdisp.c (vmessage): Use a better test for character truncation.
9935
9936 * charset.c (load_charset_map): <, not <=, for optimization,
9937 and to avoid potential problems with integer overflow.
9938 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9939 * casetab.c (set_identity, shuffle): Likewise.
9940 * editfns.c (Fformat): Likewise.
9941 * syntax.c (skip_chars): Likewise.
9942
9943 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9944 This also lets GCC 4.6.0 generate slightly better loop code.
9945
9946 * callint.c (Fcall_interactively): <, not <=, for optimization.
9947 (Fcall_interactively): Count the number of arguments produced,
9948 not the number of arguments given. This is simpler and lets GCC
9949 4.6.0 generate slightly better code.
9950
9951 * ftfont.c: Distingish more carefully between FcChar8 and char.
9952 The previous code passed unsigned char * to a functions like
9953 strlen and xstrcasecmp that expect char *, which does not
9954 conform to the C standard.
9955 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9956 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9957 char * when the C standard requires it.
9958
9959 * keyboard.c (read_char): Remove unused var.
9960
9961 * eval.c: Port to Windows vsnprintf (Bug#8435).
9962 Include <limits.h>.
9963 (SIZE_MAX): Define if the headers do not.
9964 (verror): Do not give up if vsnprintf returns a negative count.
9965 Instead, grow the buffer. This ports to Windows vsnprintf, which
9966 does not conform to C99. Problem reported by Eli Zaretskii.
9967 Also, simplify the allocation scheme, by avoiding the need for
9968 calling realloc, and removing the ALLOCATED variable.
9969
9970 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9971
9972 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9973 But keep the doprint source code for now, as we might revamp it
9974 and use it again (Bug#8435).
9975 * lisp.h (doprnt): Remove.
9976 * Makefile.in (base_obj): Remove doprnt.o.
9977 * deps.mk (doprnt.o): Remove.
9978
9979 error: Print 32- and 64-bit integers portably (Bug#8435).
9980 Without this change, on typical 64-bit hosts error ("...%d...", N)
9981 was used to print both 32- and 64-bit integers N, which relied on
9982 undefined behavior.
9983 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9984 * lisp.h (error, verror): Mark as printf-like functions.
9985 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9986 Report overflow in size calculations when allocating printf buffer.
9987 Do not truncate output string at its first null byte.
9988 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9989 Truncate the output at a character boundary, since vsnprintf does not
9990 do that.
9991 * charset.c (check_iso_charset_parameter): Convert internal
9992 character to string before calling 'error', since %c now has the
9993 printf meaning.
9994 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9995 overflow when computing char to be passed to 'error'. Do not
9996 pass Lisp_Object to 'error'; pass the integer instead.
9997 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9998 formatted with plain %d.
9999
10000 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10001
10002 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10003
10004 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10005
10006 * xterm.c (x_catch_errors): Remove duplicate declaration.
10007
10008 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10009
10010 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10011
10012 2011-04-10 Jim Meyering <meyering@redhat.com>
10013
10014 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10015 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10016 return ssize_t not "int", and use size_t as the buffer length.
10017 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10018 * gnutls.h: Update declarations.
10019 * process.c (read_process_output): Use ssize_t, to match.
10020 (send_process): Likewise.
10021
10022 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10023
10024 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10025
10026 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10027
10028 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10029 Use unsigned char, to match FcChar8 type definition.
10030
10031 * xterm.c (handle_one_xevent):
10032 * xmenu.c (create_and_show_popup_menu):
10033 * xselect.c (x_decline_selection_request)
10034 (x_reply_selection_request): Avoid type-punned deref of X events.
10035
10036 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10037
10038 Fix some uses of `int' instead of EMACS_INT.
10039 * search.c (string_match_1, fast_string_match)
10040 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10041 (scan_buffer, find_next_newline_no_quit)
10042 (find_before_next_newline, search_command, Freplace_match)
10043 (Fmatch_data): Make some `int' variables be EMACS_INT.
10044
10045 * xdisp.c (display_count_lines): 3rd argument and return value now
10046 EMACS_INT. All callers changed.
10047 (pint2hrstr): Last argument is now EMACS_INT.
10048
10049 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10050 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10051 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10052 (decode_coding_utf_16, decode_coding_emacs_mule)
10053 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10054 (decode_coding_ccl, decode_coding_charset)
10055 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10056 (decode_coding_iso_2022, decode_coding_emacs_mule)
10057 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10058 <char_offset, last_offset>: Declare EMACS_INT.
10059 (encode_coding_utf_8, encode_coding_utf_16)
10060 (encode_coding_emacs_mule, encode_invocation_designation)
10061 (encode_designation_at_bol, encode_coding_iso_2022)
10062 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10063 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10064 Declare EMACS_INT.
10065 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10066 (encode_invocation_designation): Last argument P_NCHARS is now
10067 EMACS_INT.
10068 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10069 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10070
10071 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10072 All users changed.
10073
10074 * ccl.c (Fccl_execute_on_string): Declare some variables
10075 EMACS_INT.
10076
10077 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10078
10079 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10080
10081 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10082
10083 * process.c (Fformat_network_address): Doc fix.
10084
10085 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10086
10087 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10088
10089 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10090
10091 * keyboard.c (read_char): Call Lisp function help-form-show,
10092 instead of using internal_with_output_to_temp_buffer.
10093 (Qhelp_form_show): New var.
10094 (syms_of_keyboard): Use DEFSYM macro.
10095
10096 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10097
10098 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10099
10100 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10101
10102 * process.c (Flist_processes): Remove to Lisp.
10103 (list_processes_1): Delete.
10104
10105 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10106
10107 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10108
10109 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10110
10111 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10112
10113 Fix more problems found by GCC 4.6.0's static checks.
10114
10115 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10116
10117 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10118
10119 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10120
10121 * xdisp.c (vmessage): Mark as a printf-like function.
10122
10123 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10124
10125 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10126
10127 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10128 printf-like functions.
10129 (tiff_load): Add casts to remove these marks before passing them
10130 to system-supplied API.
10131
10132 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10133
10134 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10135 This avoids several warnings with gcc -Wstrict-overflow.
10136 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10137 directly, rather than having caller test rule sign. This avoids
10138 some unnecessary tests.
10139 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10140 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10141 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10142
10143 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10144 (xfont_open): Avoid unnecessary tests.
10145
10146 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10147
10148 * composite.h, composite.c (composition_gstring_put_cache):
10149 Use EMACS_INT, not int, for length.
10150
10151 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10152 breaking out part of COMPOSITION_DECODE_RULE.
10153 (COMPOSITION_DECODE_RULE): Use it.
10154 * composite.c (get_composition_id): Remove unused local vars,
10155 by using the new macro.
10156
10157 * textprop.c (set_text_properties_1): Change while to do-while,
10158 since the condition is always true at first.
10159
10160 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10161 (interval_deletion_adjustment): Return unsigned value.
10162 All uses changed.
10163
10164 * process.c (list_processes_1, create_pty, read_process_output):
10165 (exec_sentinel): Remove vars that were set but not used.
10166 (create_pty): Remove unnecessary "volatile"s.
10167 (Fnetwork_interface_info): Avoid possibility of int overflow.
10168 (read_process_output): Do adaptive read buffering even if carryover.
10169 (read_process_output): Simplify nbytes computation if buffered.
10170
10171 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10172
10173 * syntax.c (scan_words): Remove var that was set but not used.
10174 (update_syntax_table): Use unsigned instead of int.
10175
10176 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10177 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10178 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10179
10180 * print.c (print_error_message): Avoid int overflow.
10181
10182 * font.c (font_list_entities): Redo for clarity,
10183 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10184
10185 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10186 (font_score): Avoid potential overflow in diff calculation.
10187
10188 * fns.c (substring_both): Remove var that is set but not used.
10189 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10190
10191 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10192
10193 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10194 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10195 can always succeed if overflow has undefined behavior.
10196
10197 * search.c (boyer_moore, wordify): Remove vars set but not used.
10198 (wordify): Omit three unnecessary tests.
10199
10200 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10201 All callers changed. This avoids the need for an unused var.
10202
10203 * casefiddle.c (casify_region): Remove var that is set but not used.
10204
10205 * dired.c (file_name_completion): Remove var that is set but not used.
10206
10207 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10208
10209 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10210 (Finsert_file_contents): Remove unnecessary code checking fd.
10211
10212 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10213 Check for integer overflow on size calculations.
10214
10215 * buffer.c (Fprevious_overlay_change): Remove var that is set
10216 but not used.
10217
10218 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10219 Remove vars that are set but not used.
10220 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10221 (timer_check_2): Mark vars as initialized.
10222
10223 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10224
10225 * image.c (lookup_image): Remove var that is set but not used.
10226 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10227
10228 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10229 that are set but not used.
10230
10231 * xfns.c (make_invisible_cursor): Don't return garbage
10232 if XCreateBitmapFromData fails (Bug#8410).
10233
10234 * xselect.c (x_get_local_selection, x_handle_property_notify):
10235 Remove vars that are set but not used.
10236
10237 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10238 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10239
10240 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10241 Remove var that is set but not used.
10242 (scroll_bar_windows_size): Now size_t, not int.
10243 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10244 Check for overflow.
10245
10246 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10247 (map_tty_color) [!defined MSDOS]: Likewise.
10248
10249 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10250
10251 * coding.c: Remove vars that are set but not used.
10252 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10253 All callers changed.
10254 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10255 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10256 (decode_coding_charset): Remove vars that are set but not used.
10257
10258 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10259 that is set but not used.
10260
10261 * print.c (print_object): Remove var that is set but not used.
10262
10263 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10264 The gnulib version avoids calling malloc in the usual case,
10265 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10266 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10267 * filelock.c (current_lock_owner): Likewise.
10268 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10269 * sysdep.c: Include allocator.h, careadlinkat.h.
10270 (emacs_no_realloc_allocator): New static constant.
10271 (emacs_readlink): New function.
10272 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10273 ../lib/careadlinkat.h.
10274
10275 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10276
10277 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10278 first non-nil return value).
10279
10280 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10281
10282 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10283 if not defined (Bug#8403).
10284
10285 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10286
10287 * xdisp.c (display_count_lines): Remove parameter `start',
10288 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10289 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10290 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10291 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10292 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10293 and thereabouts. All callers changed.
10294 (get_per_char_metric): Remove parameter `f', unused since
10295 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10296
10297 2011-04-02 Jim Meyering <meyering@redhat.com>
10298
10299 do not dereference NULL upon failed strdup
10300 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10301 (ns_get_family): Likewise.
10302
10303 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10304
10305 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10306
10307 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10308
10309 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10310 later (Bug#8403).
10311
10312 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10313
10314 Add lexical binding.
10315
10316 * window.c (Ftemp_output_buffer_show): New fun.
10317 (Fsave_window_excursion):
10318 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10319
10320 * lread.c (lisp_file_lexically_bound_p): New function.
10321 (Fload): Bind Qlexical_binding.
10322 (readevalloop): Remove `evalfun' arg.
10323 Bind Qinternal_interpreter_environment.
10324 (Feval_buffer): Bind Qlexical_binding.
10325 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10326 Mark as dynamic.
10327 (syms_of_lread): Declare `lexical-binding'.
10328
10329 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10330
10331 * keyboard.c (eval_dyn): New fun.
10332 (menu_item_eval_property): Use it.
10333
10334 * image.c (parse_image_spec): Use Ffunctionp.
10335
10336 * fns.c (concat, mapcar1): Accept byte-code-functions.
10337
10338 * eval.c (Fsetq): Handle lexical vars.
10339 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10340 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10341 (FletX, Flet): Obey lexical binding.
10342 (Fcommandp): Handle closures.
10343 (Feval): New `lexical' arg.
10344 (eval_sub): New function extracted from Feval. Use it almost
10345 everywhere where Feval was used. Look up vars in lexical env.
10346 Handle closures.
10347 (Ffunctionp): Move from subr.el.
10348 (Ffuncall): Handle closures.
10349 (apply_lambda): Remove `eval_flags'.
10350 (funcall_lambda): Handle closures and new byte-code-functions.
10351 (Fspecial_variable_p): New function.
10352 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10353 but without exporting it to Lisp.
10354
10355 * doc.c (Fdocumentation, store_function_docstring):
10356 * data.c (Finteractive_form): Handle closures.
10357
10358 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10359 interactive spec.
10360
10361 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10362 New byte-codes.
10363 (exec_byte_code): New function extracted from Fbyte_code to handle new
10364 calling convention for byte-code-functions. Add new byte-codes.
10365
10366 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10367
10368 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10369
10370 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10371
10372 * xdisp.c (redisplay_internal): Fix prototype.
10373
10374 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10375
10376 * xdisp.c (SCROLL_LIMIT): New macro.
10377 (try_scrolling): Use it when setting scroll_limit.
10378 Limit scrolling to 100 screen lines.
10379 (redisplay_window): Even when falling back on "recentering",
10380 position point in the window according to scroll-conservatively,
10381 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10382
10383 (try_scrolling): When point is above the window, allow searching
10384 as far as scroll_max, or one screenful, to compute vertical
10385 distance from PT to the scroll margin position. This prevents
10386 try_scrolling from unnecessarily failing when
10387 scroll-conservatively is set to a value slightly larger than the
10388 window height. Clean up the case of PT below the margin at bottom
10389 of window: scroll_max can no longer be INT_MAX. When aggressive
10390 scrolling is in use, don't let point enter the opposite scroll
10391 margin as result of the scroll.
10392 (syms_of_xdisp) <scroll-conservatively>: Document the
10393 threshold of 100 lines for never-recentering scrolling.
10394
10395 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10396
10397 * dispextern.h (move_it_by_lines):
10398 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10399 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10400 (message_log_check_duplicate): Remove parameters `prev_bol' and
10401 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10402 (redisplay_internal): Remove parameter `preserve_echo_area',
10403 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10404
10405 * indent.c (Fvertical_motion):
10406 * window.c (window_scroll_pixel_based, Frecenter):
10407 Don't pass `need_y_p' to `move_it_by_lines'.
10408
10409 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10410
10411 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10412 steal a few bits to be more compact.
10413 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10414 Remove unneeded casts.
10415
10416 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10417
10418 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10419
10420 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10421 binding" message (bug#7967).
10422
10423 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10424
10425 Fix more problems found by GCC 4.6.0's static checks.
10426
10427 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10428 Remove unused local var.
10429
10430 * editfns.c (Fmessage_box): Remove unused local var.
10431
10432 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10433 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10434 Omit unused local vars.
10435 * window.c (shrink_windows): Omit unused local var.
10436 * menu.c (digest_single_submenu): Omit unused local var.
10437 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10438 Omit unused local var.
10439
10440 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10441 Don't assume string length fits in int.
10442 (keyremap_step, read_key_sequence): Use size_t for sizes.
10443 (read_key_sequence): Don't check last_real_key_start redundantly.
10444
10445 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10446 instead of alloca (Bug#8344).
10447
10448 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10449 (Fbacktrace_frame): Don't assume nframes fits in int.
10450
10451 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10452
10453 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10454 concerns.
10455
10456 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10457
10458 * cm.c (calccost): Turn while-do into do-while, for clarity.
10459
10460 * keyboard.c (syms_of_keyboard): Use the same style as later
10461 in this function when indexing through an array. This also
10462 works around GCC bug 48267.
10463
10464 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10465
10466 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10467
10468 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10469 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10470
10471 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10472 This avoids undefined behavior on integer overflow, and is a bit
10473 more convenient anyway since it is compared to a size_t variable.
10474
10475 Variadic C functions now count arguments with size_t, not int.
10476 This avoids an unnecessary limitation on 64-bit machines, which
10477 caused (substring ...) to crash on large vectors (Bug#8344).
10478 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10479 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10480 All variadic functions and their callers changed accordingly.
10481 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10482 * data.c (arith_driver, float_arith_driver): Likewise.
10483 * editfns.c (general_insert_function): Likewise.
10484 * eval.c (struct backtrace.nargs, interactive_p)
10485 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10486 (funcall_lambda, mark_backtrace): Likewise.
10487 * fns.c (concat): Likewise.
10488 * frame.c (x_set_frame_parameters): Likewise.
10489 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10490 0 if not found, not -1. All callers changed.
10491
10492 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10493 (stack_copy_size): Now size_t, not int.
10494 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10495
10496 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10497
10498 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10499 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10500 All callers changed.
10501
10502 * lisp.h (multibyte_char_to_unibyte):
10503 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10504 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10505 * character.h (CHAR_TO_BYTE8):
10506 * cmds.c (internal_self_insert):
10507 * editfns.c (general_insert_function):
10508 * keymap.c (push_key_description):
10509 * search.c (Freplace_match):
10510 * xdisp.c (message_dolog, set_message_1): All callers changed.
10511
10512 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10513
10514 * keyboard.c (safe_run_hook_funcall): New function.
10515 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10516 don't set the hook to nil, but remove the offending function instead.
10517 (Qcommand_hook_internal): Remove, unused.
10518 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10519 Vcommand_hook_internal.
10520
10521 * eval.c (enum run_hooks_condition): Remove.
10522 (funcall_nil, funcall_not): New functions.
10523 (run_hook_with_args): Call each function through a `funcall' argument.
10524 Remove `cond' argument, now redundant.
10525 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10526 (Frun_hook_with_args_until_failure): Adjust accordingly.
10527 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10528
10529 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10530
10531 * dispextern.h (string_buffer_position): Remove declaration.
10532
10533 * print.c (strout): Remove parameter `multibyte', unused since
10534 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10535
10536 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10537 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10538 All callers changed.
10539
10540 * w32.c (_wsa_errlist): Use braces for struct initializers.
10541
10542 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10543 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10544 All callers changed.
10545 (string_buffer_position): Likewise. Also, make static (it's never
10546 used outside xdisp.c).
10547 (cursor_row_p): Remove parameter `w', unused since
10548 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10549 (decode_mode_spec): Remove parameter `precision', introduced during
10550 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10551 All callers changed.
10552
10553 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10554
10555 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10556
10557 2011-03-27 Anders Lindgren <andlind@gmail.com>
10558
10559 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10560 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10561 (ns_update_auto_hide_menu_bar): New functions.
10562 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10563 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10564 ns_constrain_all_frames.
10565 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10566 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10567
10568 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10569
10570 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10571
10572 2011-03-27 Glenn Morris <rgm@gnu.org>
10573
10574 * syssignal.h: Replace RETSIGTYPE with void.
10575 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10576 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10577 Replace SIGTYPE with void everywhere.
10578 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10579 * s/template.h (SIGTYPE): Remove commented out definition.
10580
10581 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10582
10583 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10584 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10585
10586 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10587
10588 * w32.c (read_unc_volume): Use parameter `henum', instead of
10589 global variable `wget_enum_handle'.
10590
10591 * keymap.c (describe_vector): Remove parameters `indices' and
10592 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10593 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10594
10595 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10596
10597 * keyboard.c (timer_check): Remove parameter `do_it_now',
10598 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10599 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10600 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10601
10602 * keyboard.c (read_char):
10603 * w32menu.c (w32_menu_display_help):
10604 * xmenu.c (show_help_event, menu_help_callback):
10605 Adjust calls to `show_help_echo'.
10606
10607 * gtkutil.c (xg_maybe_add_timer):
10608 * keyboard.c (readable_events):
10609 * process.c (wait_reading_process_output):
10610 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10611
10612 * insdel.c (adjust_markers_gap_motion):
10613 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10614 (gap_left, gap_right): Don't call it.
10615
10616 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10617
10618 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10619 incurred during fontification.
10620
10621 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10622
10623 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10624 (DEFVAR_PER_BUFFER): Don't pass it.
10625
10626 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10627 (scrolling_window): Don't pass it.
10628
10629 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10630
10631 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10632
10633 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10634 and `suffix'.
10635 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10636 of variables specific to SELinux and computation of `encoded_absname'.
10637
10638 * image.c (XPutPixel): Remove unused variable `height'.
10639
10640 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10641
10642 * unexw32.c (get_section_info): Remove unused variable `section'.
10643
10644 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10645 (system_process_attributes): Remove unused variable `sess'.
10646 (sys_read): Remove unused variable `err'.
10647
10648 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10649 (w32_wnd_proc): Remove unused variable `isdead'.
10650 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10651 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10652 (x_create_tip_frame): Remove unused variable `tem'.
10653
10654 * w32inevt.c (w32_console_read_socket):
10655 Remove unused variable `no_events'.
10656
10657 * w32term.c (x_draw_composite_glyph_string_foreground):
10658 Remove unused variable `width'.
10659
10660 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10661
10662 * w32term.c (x_set_glyph_string_clipping):
10663 Don't pass uninitialized region to CombineRgn.
10664
10665 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10666
10667 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10668 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10669 (Fx_close_connection): Remove unused variable `i'.
10670
10671 * w32font.c (w32font_draw): Return number of glyphs.
10672 (w32font_open_internal): Remove unused variable `i'.
10673 (w32font_driver): Add missing initializer.
10674
10675 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10676 (fill_in_menu): Remove unused variable `items_added'.
10677
10678 * w32term.c (last_mouse_press_frame): Remove static global variable.
10679 (w32_clip_to_row): Remove unused variable `f'.
10680 (x_delete_terminal): Remove unused variable `i'.
10681
10682 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10683 (NOTHING): Remove unused static global variable.
10684 (uniscribe_check_otf): Remove unused variable `table'.
10685 (uniscribe_font_driver): Add missing initializers.
10686
10687 2011-03-23 Julien Danjou <julien@danjou.info>
10688
10689 * term.c (Fsuspend_tty, Fresume_tty):
10690 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10691 * window.c (temp_output_buffer_show):
10692 * insdel.c (signal_before_change):
10693 * frame.c (Fhandle_switch_frame):
10694 * fileio.c (Fdo_auto_save):
10695 * emacs.c (Fkill_emacs):
10696 * editfns.c (save_excursion_restore):
10697 * cmds.c (internal_self_insert):
10698 * callint.c (Fcall_interactively):
10699 * buffer.c (Fkill_all_local_variables):
10700 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10701 Use Frun_hooks.
10702 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10703 unconditionally since it does the check itself.
10704
10705 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10706
10707 Fix more problems found by GCC 4.5.2's static checks.
10708
10709 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10710 the first time through the loop, since we know p0 < p1 then.
10711 This also avoids a gcc -Wstrict-overflow warning.
10712
10713 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10714 leading to a memory leak, possible in functions like
10715 load_charset_map_from_file that can allocate an unbounded number
10716 of objects (Bug#8318).
10717
10718 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10719 that could (at least in theory) be that large.
10720
10721 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10722 This is less likely to overflow, and avoids undefined behavior if
10723 overflow does occur. All callers changed. Use strtoul to scan
10724 for the unsigned long integer.
10725 (pint2hrstr): Simplify and tune code slightly.
10726 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10727
10728 * scroll.c (do_scrolling): Work around GCC bug 48228.
10729 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10730
10731 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10732 This also avoids a warning with gcc -Wstrict-overflow.
10733 (validate_x_resource_name): Simplify count usage.
10734 This also avoids a warning with gcc -Wstrict-overflow.
10735
10736 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10737 fail (Bug#8306).
10738
10739 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10740
10741 * process.c (Fmake_network_process): Use socklen_t, not int,
10742 where POSIX says socklen_t is required in portable programs.
10743 This fixes a porting bug on hosts like 64-bit HP-UX, where
10744 socklen_t is wider than int (Bug#8277).
10745 (Fmake_network_process, server_accept_connection):
10746 (wait_reading_process_output, read_process_output):
10747 Likewise.
10748
10749 * process.c: Rename or move locals to avoid shadowing.
10750 (list_processes_1, Fmake_network_process):
10751 (read_process_output_error_handler, exec_sentinel_error_handler):
10752 Rename or move locals.
10753 (Fmake_network_process): Define label "retry_connect" only if needed.
10754 (Fnetwork_interface_info): Fix pointer signedness.
10755 (process_send_signal): Add cast to avoid pointer signedness problem.
10756 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10757 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10758
10759 Make tparam.h and terminfo.c consistent.
10760 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10761 Include tparam.h instead, since it declares them.
10762 * cm.h (PC): Remove extern decl; tparam.h now does this.
10763 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10764 * terminfo.c: Include tparam.h, to check interfaces.
10765 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10766 (tparam): Adjust signature to match interface in tparam.h;
10767 this removes some undefined behavior. Check that outstring and len
10768 are zero, which they always are with Emacs.
10769 * tparam.h (PC, BC, UP): New extern decls.
10770
10771 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10772 (xftfont_open): Rename locals to avoid shadowing.
10773
10774 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10775 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10776 (OTF_TAG_SYM): Omit macro if not needed.
10777 (ftfont_list): Remove unused local.
10778 (get_adstyle_property, ftfont_pattern_entity):
10779 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10780 Rename locals to avoid shadowing.
10781
10782 * xfont.c (xfont_list_family): Mark var as initialized.
10783
10784 * xml.c (make_dom): Now static.
10785
10786 * composite.c (composition_compute_stop_pos): Rename local to
10787 avoid shadowing.
10788 (composition_reseat_it): Remove unused locals.
10789 (find_automatic_composition, composition_adjust_point): Likewise.
10790 (composition_update_it): Mark var as initialized.
10791 (find_automatic_composition): Mark vars as initialized,
10792 with a FIXME (Bug#8290).
10793
10794 character.h: Rename locals to avoid shadowing.
10795 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10796 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10797 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10798 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10799 to avoid shadowing.
10800
10801 * textprop.c (property_change_between_p): Remove; unused.
10802
10803 * intervals.c (interval_start_pos): Now static.
10804
10805 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10806
10807 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10808 Rename locals to avoid shadowing.
10809
10810 * sound.c (wav_play, au_play, Fplay_sound_internal):
10811 Fix pointer signedness.
10812 (alsa_choose_format): Remove unused local var.
10813 (wav_play): Initialize a variable to 0, to prevent undefined
10814 behavior (Bug#8278).
10815
10816 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10817
10818 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10819
10820 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10821 clobbering (Bug#8298).
10822 * sysdep.c (sys_subshell): Likewise.
10823 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10824
10825 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10826 This should get cleaned up, so that child_setup has the
10827 same signature on all platforms.
10828
10829 * callproc.c (call_process_cleanup): Now static.
10830 (relocate_fd): Rename locals to avoid shadowing.
10831
10832 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10833
10834 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10835 not to be necessary, and produces flickering.
10836
10837 2011-03-20 Glenn Morris <rgm@gnu.org>
10838
10839 * config.in: Remove file.
10840
10841 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10842
10843 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10844 are now in src/globals.h.
10845 (syms_of_minibuf): Remove spurious & from previous change.
10846
10847 2011-03-20 Leo Liu <sdl.web@gmail.com>
10848
10849 * minibuf.c (completing-read-function): New variable.
10850 (completing-read-default): Rename from completing-read.
10851 (completing-read): Call completing-read-function.
10852
10853 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10854
10855 * xfaces.c (Fx_load_color_file):
10856 Read color file from absolute filename (bug#8250).
10857
10858 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10859
10860 * makefile.w32-in: Update dependencies.
10861
10862 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10863
10864 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10865
10866 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10867
10868 Fix more problems found by GCC 4.5.2's static checks.
10869
10870 * process.c (make_serial_process_unwind, send_process_trap):
10871 (sigchld_handler): Now static.
10872
10873 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10874 That way, the code declares only the vars that it needs.
10875 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10876 * s/cygwin.h (PTY_ITERATION): Likewise.
10877 * s/darwin.h (PTY_ITERATION): Likewise.
10878 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10879
10880 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10881 * process.c (allocate_pty): Don't declare stb unless it's needed.
10882
10883 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10884 (CONSTANTLIM): Remove; unused.
10885 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10886 Define only if needed.
10887
10888 * unexelf.c (unexec): Name an expression,
10889 to avoid gcc -Wbad-function-cast warning.
10890 Use a different way to cause a compilation error if anyone uses
10891 n rather than nn, a way that does not involve shadowing.
10892 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10893
10894 * deps.mk (unexalpha.o): Remove; unused.
10895
10896 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10897 * unexec.h: New file.
10898 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10899 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10900 Depend on unexec.h.
10901 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10902 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10903 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10904 Change as necessary to match prototype in unexec.h.
10905
10906 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10907 shadowing.
10908 (back_comment, skip_chars): Mark vars as initialized.
10909
10910 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10911 Rename locals to avoid shadowing.
10912
10913 * lread.c (read1): Rewrite so as not to use empty "else".
10914 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10915
10916 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10917
10918 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10919 warning when compiling print.c.
10920
10921 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10922 instead of using an uninitialized var.
10923 (font_sort_entities): Mark var as initialized.
10924
10925 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10926
10927 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10928 pointers to constants.
10929 (font_parse_fcname): Remove unused vars.
10930 (font_delete_unmatched): Now static.
10931 (font_get_spec): Remove; unused.
10932 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10933 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10934 Rename or move locals to avoid shadowing.
10935
10936 * fns.c (require_nesting_list, require_unwind): Now static.
10937 (Ffillarray): Rename locals to avoid shadowing.
10938
10939 * floatfns.c (domain_error2): Define only if needed.
10940 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10941
10942 * alloc.c (mark_backtrace): Move decl from here ...
10943 * lisp.h: ... to here, so that it can be checked.
10944
10945 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10946 (Fdefvar): Rewrite so as not to use empty "else".
10947 (lisp_indirect_variable): Name an expression,
10948 to avoid gcc -Wbad-function-cast warning.
10949 (Fdefvar): Rename locals to avoid shadowing.
10950
10951 * callint.c (quotify_arg, quotify_args): Now static.
10952 (Fcall_interactively): Rename locals to avoid shadowing.
10953 Use const pointer when appropriate.
10954
10955 * lisp.h (get_system_name, get_operating_system_release):
10956 Move decls here, to check interfaces.
10957 * process.c (get_operating_system_release): Move decl to lisp.h.
10958 * xrdb.c (get_system_name): Likewise.
10959 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10960 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10961 some of which prompt warnings from gcc -Wbad-function-cast.
10962 (Fformat_time_string, Fencode_time, Finsert_char):
10963 (Ftranslate_region_internal, Fformat):
10964 Rename or remove local vars to avoid shadowing.
10965 (Ftranslate_region_internal): Mark var as initialized.
10966
10967 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10968 avoid shadowing.
10969
10970 * lisp.h (eassert): Check that the argument compiles, even if
10971 ENABLE_CHECKING is not defined.
10972
10973 * data.c (Findirect_variable): Name an expression, to avoid
10974 gcc -Wbad-function-cast warning.
10975 (default_value, arithcompare, arith_driver, arith_error): Now static.
10976 (store_symval_forwarding): Rename local to avoid shadowing.
10977 (Fmake_variable_buffer_local, Fmake_local_variable):
10978 Mark variables as initialized.
10979 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10980
10981 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10982 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10983 Rename locals to avoid shadowing.
10984 (mark_stack): Move local variables into the #ifdef region where
10985 they're used.
10986 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10987 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10988 needed otherwise.
10989 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10990 (GC_STRING_CHARS): Remove; not used.
10991 (Fmemory_limit): Cast sbrk's returned value to char *.
10992
10993 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10994 avoids undefined behavior in theory.
10995
10996 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10997
10998 Use functions, not macros, for up- and down-casing (Bug#8254).
10999 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11000 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11001 to use the following functions instead of these macros.
11002 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11003 EMACS_INT, since callers assume the returned value fits in int.
11004 (upcase1): Likewise, for UPCASE_TABLE.
11005 (uppercasep, lowercasep, upcase): New static inline functions.
11006 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11007 the race-condition problem in the old DOWNCASE.
11008
11009 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11010 Rename locals to avoid shadowing.
11011 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11012 (regex_compile, re_search_2, re_match_2_internal):
11013 Remove unused local vars.
11014 (FREE_VAR): Rewrite so as not to use empty "else",
11015 which gcc can warn about.
11016 (regex_compile, re_match_2_internal): Mark locals as initialized.
11017 (RETALLOC_IF): Define only if needed.
11018 (WORDCHAR_P): Likewise. This one is never needed, but is used
11019 only in a comment talking about a compiler bug, so put inside
11020 the #if 0 of that comment.
11021 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11022 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11023 Remove; unused.
11024
11025 * search.c (boyer_moore): Rename locals to avoid shadowing.
11026 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11027 (PREV_CHAR_BOUNDARY): Likewise.
11028
11029 * search.c (simple_search): Remove unused var.
11030
11031 * dired.c (compile_pattern): Move decl from here ...
11032 * lisp.h: ... to here, so that it can be checked.
11033 (struct re_registers): New forward decl.
11034
11035 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11036
11037 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11038 All uses changed.
11039 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11040 Rename locals to avoid shadowing.
11041 (Fvertical_motion): Mark locals as initialized.
11042
11043 * casefiddle.c (casify_object, casify_region): Now static.
11044 (casify_region): Mark local as initialized.
11045
11046 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11047
11048 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11049 New macros, so that the caller can use some names other than
11050 gcpro1, gcpro2, etc.
11051 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11052 of the new macros.
11053 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11054 argument, for consistency with GCPRO2_VAR, etc: it is now the
11055 prefix of the variable, not the variable itself. All uses
11056 changed.
11057 * dired.c (directory_files_internal, file_name_completion):
11058 Rename locals to avoid shadowing.
11059
11060 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11061 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11062 dired.c's scmp function, had undefined behavior.
11063 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11064 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11065 * buffer.h: ... to here, because these macros use current_buffer,
11066 and the new implementation with inline functions needs to have
11067 current_buffer in scope now, rather than later when the macros
11068 are used.
11069 (downcase, upcase1): New static inline functions.
11070 (DOWNCASE, UPCASE1): Reimplement using these functions.
11071 This avoids undefined behavior in expressions like
11072 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11073 from race conditions in accessing the global variables
11074 case_temp1 and case_temp2.
11075 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11076 * lisp.h (case_temp1, case_temp2): Remove their decls.
11077 * character.h (ASCII_CHAR_P): Move from here ...
11078 * lisp.h: ... to here, so that the inline functions mentioned
11079 above can use them.
11080
11081 * dired.c (directory_files_internal_unwind): Now static.
11082
11083 * fileio.c (file_name_as_directory, directory_file_name):
11084 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11085 Now static.
11086 (file_name_as_directory): Use const pointers when appropriate.
11087 (Fexpand_file_name): Likewise. In particular, newdir might
11088 point at constant storage, so make it a const pointer.
11089 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11090 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11091 signedness issues.
11092 (Fset_file_times, Finsert_file_contents, auto_save_error):
11093 Rename locals to avoid shadowing.
11094
11095 * minibuf.c (choose_minibuf_frame_1): Now static.
11096 (Ftry_completion, Fall_completions): Rename or remove locals
11097 to avoid shadowing.
11098
11099 * marker.c (bytepos_to_charpos): Remove; unused.
11100
11101 * lisp.h (verify_bytepos, count_markers): New decls,
11102 so that gcc does not warn that these functions aren't declared.
11103
11104 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11105 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11106 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11107 (copy_text): Remove unused local var.
11108
11109 * filelock.c (within_one_second): Now static.
11110 (lock_file_1): Rename local to avoid shadowing.
11111
11112 * buffer.c (fix_overlays_before): Mark locals as initialized.
11113 (fix_start_end_in_overlays): Likewise. This function should be
11114 simplified by using pointers-to-pointers, but that's a different
11115 matter.
11116 (switch_to_buffer_1): Now static.
11117 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11118 (report_overlay_modification): Rename locals to avoid shadowing.
11119
11120 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11121 Fix pointer signedness issue.
11122 (sys_subshell): Mark local as volatile if checking for lint,
11123 to suppress a gcc -Wclobbered warning that does not seem to be right.
11124 (MAXPATHLEN): Define only if needed.
11125
11126 * process.c (serial_open, serial_configure): Move decls from here ...
11127 * systty.h: ... to here, so that they can be checked.
11128
11129 * fns.c (get_random, seed_random): Move extern decls from here ...
11130 * lisp.h: ... to here, so that they can be checked.
11131
11132 * sysdep.c (reset_io): Now static.
11133 (wait_for_termination_signal): Remove; unused.
11134
11135 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11136 (copy_keymap_item, append_key, push_text_char_description):
11137 Now static.
11138 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11139 (DENSE_TABLE_SIZE): Remove; unused.
11140 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11141 (describe_map_tree):
11142 Rename locals to avoid shadowing.
11143
11144 * keyboard.c: Declare functions static if they are not used elsewhere.
11145 (echo_char, echo_dash, cmd_error, top_level_2):
11146 (poll_for_input, handle_async_input): Now static.
11147 (read_char, kbd_buffer_get_event, make_lispy_position):
11148 (make_lispy_event, make_lispy_movement, apply_modifiers):
11149 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11150 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11151 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11152 (read_key_sequence, read_char): Mark locals as initialized.
11153 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11154
11155 * keyboard.h (make_ctrl_char): New decl.
11156 (mark_kboards): Move decl here ...
11157 * alloc.c (mark_kboards): ... from here.
11158
11159 * lisp.h (force_auto_save_soon): New decl.
11160
11161 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11162 (DEFINE_DUMMY_FUNCTION): New macro.
11163 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11164 Use it.
11165 (main): Add casts to avoid warnings
11166 if GCC considers string literals to be constants.
11167
11168 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11169
11170 * dbusbind.c: Pointer signedness fixes.
11171 (xd_signature, xd_append_arg, xd_initialize):
11172 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11173 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11174 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11175 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11176
11177 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11178 if GCC considers string literals to be constants.
11179 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11180
11181 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11182
11183 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11184 (print_preprocess, print_object): New macro to fix last change.
11185
11186 * print.c (print_preprocess): Don't forget font objects.
11187
11188 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11189
11190 * emacs.c (USAGE3): Doc fixes.
11191
11192 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11193
11194 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11195 structure.
11196
11197 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11198
11199 * lisp.h (VWindow_system, Qfile_name_history):
11200 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11201 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11202 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11203
11204 * w32select.c: Don't #include "keyboard.h".
11205 (run_protected): Add extern declaration for waiting_for_input.
11206
11207 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11208 * w32console.c (detect_input_pending, read_input_pending)
11209 (encode_terminal_code):
11210 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11211 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11212 (w32_system_caret_y, Qfile_name_history):
11213 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11214 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11215 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11216 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11217 * w32proc.c (Qlocal, report_file_error):
11218 * w32term.c (Vwindow_system, updating_frame):
11219 * w32uniscribe.c (initialized, uniscribe_font_driver):
11220 Remove unneeded extern declarations.
11221
11222 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11223
11224 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11225
11226 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11227
11228 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11229 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11230 These macros can no longer be used for assignment.
11231
11232 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11233 Assign struct members directly, instead of using BUF_BEGV etc.
11234 (record_buffer_markers, fetch_buffer_markers): New functions for
11235 recording and fetching special buffer markers.
11236 (set_buffer_internal_1, set_buffer_temp): Use them.
11237
11238 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11239
11240 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11241
11242 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11243 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11244
11245 * xdisp.c (hscroll_window_tree):
11246 (reconsider_clip_changes): Use PT instead of BUF_PT.
11247
11248 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11249
11250 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11251 $(EMACS_ROOT)/lib/intprops.h.
11252
11253 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11254
11255 Fix more problems found by GCC 4.5.2's static checks.
11256
11257 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11258 to unsigned char * to avoid compiler diagnostic.
11259 (xg_free_frame_widgets): Make it clear that a local variable is
11260 needed only if USE_GTK_TOOLTIP.
11261 (gdk_window_get_screen): Make it clear that this macro is needed
11262 only if USE_GTK_TOOLTIP.
11263 (int_gtk_range_get_value): New function, which avoids a diagnostic
11264 from gcc -Wbad-function-cast.
11265 (xg_set_toolkit_scroll_bar_thumb): Use it.
11266 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11267 diagnostic from gcc -Wbad-function-cast.
11268 (get_utf8_string, xg_get_file_with_chooser):
11269 Rename locals to avoid shadowing.
11270 (create_dialog): Move locals to avoid shadowing.
11271
11272 * xgselect.c (xg_select): Remove unused var.
11273
11274 * image.c (four_corners_best): Mark locals as initialized.
11275 (gif_load): Initialize transparent_p to zero (Bug#8238).
11276 Mark another local as initialized.
11277 (my_png_error, my_error_exit): Mark with NO_RETURN.
11278
11279 * image.c (clear_image_cache): Now static.
11280 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11281 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11282 (x_edge_detection): Remove unnecessary cast that
11283 gcc -Wbad-function-cast diagnoses.
11284 (gif_load): Fix pointer signedness.
11285 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11286 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11287
11288 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11289
11290 Improve quality of tests for time stamp overflow.
11291 For example, without this patch (encode-time 0 0 0 1 1
11292 1152921504606846976) returns the obviously-bogus value (-948597
11293 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11294 reports time overflow. See
11295 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11296 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11297 * editfns.c: Include limits.h and intprops.h.
11298 (TIME_T_MIN, TIME_T_MAX): New macros.
11299 (time_overflow): Move earlier, to before first use.
11300 (hi_time, lo_time): New functions, for an accurate test for
11301 out-of-range times.
11302 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11303 (Fget_internal_run_time): Don't assume time_t fits in int.
11304 (make_time): Use list2 instead of Fcons twice.
11305 (Fdecode_time): More accurate test for out-of-range times.
11306 (check_tm_member): New function.
11307 (Fencode_time): Use it, to test for out-of-range times.
11308 (lisp_time_argument): Don't rely on undefined left-shift and
11309 right-shift behavior when checking for time stamp overflow.
11310
11311 * editfns.c (time_overflow): New function, refactoring common code.
11312 (Fformat_time_string, Fdecode_time, Fencode_time):
11313 (Fcurrent_time_string): Use it.
11314
11315 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11316 * dired.c (make_time): Move to ...
11317 * editfns.c (make_time): ... here.
11318 * systime.h: Note the move.
11319
11320 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11321
11322 * fringe.c (update_window_fringes): Remove unused variables.
11323
11324 * unexmacosx.c (copy_data_segment): Also copy __got section.
11325 (Bug#8223)
11326
11327 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11328
11329 * termcap.c [MSDOS]: Include "msdos.h".
11330 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11331 Constify `char *' arguments and their references according to
11332 prototypes in tparam.h.
11333
11334 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11335
11336 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11337 Adapt all references accordingly.
11338
11339 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11340
11341 2011-03-11 Tom Tromey <tromey@redhat.com>
11342
11343 * buffer.c (syms_of_buffer): Remove obsolete comment.
11344
11345 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11346
11347 * termhooks.h (encode_terminal_code): Declare prototype.
11348
11349 * msdos.c (encode_terminal_code): Don't declare prototype.
11350
11351 * term.c (encode_terminal_code): Now external again, used by
11352 w32console.c and msdos.c.
11353
11354 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11355 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11356
11357 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11358
11359 Fix some minor problems found by GCC 4.5.2's static checks.
11360
11361 * fringe.c (update_window_fringes): Mark locals as initialized
11362 (Bug#8227).
11363 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11364
11365 * alloc.c (mark_fringe_data): Move decl from here ...
11366 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11367 to check its interface.
11368 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11369
11370 * fontset.c (free_realized_fontset): Now static.
11371 (Fset_fontset_font): Rename local to avoid shadowing.
11372 (fontset_font): Mark local as initialized.
11373 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11374
11375 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11376
11377 * xselect.c (x_disown_buffer_selections): Remove; not used.
11378 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11379 (x_own_selection, Fx_disown_selection_internal): Rename locals
11380 to avoid shadowing.
11381 (x_handle_dnd_message): Remove local to avoid shadowing.
11382
11383 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11384 so that the caller can use some name other than gcpro1.
11385 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11386 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11387 (Fx_backspace_delete_keys_p):
11388 Use them to avoid shadowing, and rename vars to avoid shadowing.
11389 (x_decode_color, x_set_name, x_window): Now static.
11390 (Fx_create_frame): Add braces to silence GCC warning.
11391 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11392 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11393 Remove unused locals.
11394 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11395 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11396 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11397 macros.
11398
11399 * xterm.h (x_mouse_leave): New decl.
11400
11401 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11402 Remove unused functions.
11403 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11404 (x_calc_absolute_position): Now static.
11405 (XTread_socket): Don't define label "out" unless it's used.
11406 Don't declare local "event" unless it's used.
11407 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11408 unless they are used.
11409 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11410 (x_fatal_error_signal): Remove; not used.
11411 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11412 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11413 (x_error_catcher, x_connection_closed, x_error_handler):
11414 (x_error_quitter, xembed_send_message, x_iconify_frame):
11415 (my_log_handler): Rename locals to avoid shadowing.
11416 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11417 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11418
11419 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11420 Rename or move locals to avoid shadowing.
11421 (tty_defined_color, merge_face_heights): Now static.
11422 (free_realized_faces_for_fontset): Remove; not used.
11423 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11424 does not deduce is never used uninitialized.
11425 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11426 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11427
11428 * terminal.c (store_terminal_param): Now static.
11429
11430 * xmenu.c (menu_highlight_callback): Now static.
11431 (set_frame_menubar): Remove unused local.
11432 (xmenu_show): Rename parameter to avoid shadowing.
11433 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11434 since they might point to immutable storage.
11435 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11436 since it's unused otherwise.
11437
11438 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11439 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11440 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11441 avoids a gcc -Wuninitialized diagnostic.
11442 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11443 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11444 does not deduce are never used uninitialized.
11445
11446 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11447
11448 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11449 * window.c (window_loop, size_window):
11450 (run_window_configuration_change_hook, enlarge_window): Likewise.
11451
11452 * window.c (display_buffer): Now static.
11453 (size_window): Mark variables that gcc -Wuninitialized
11454 does not deduce are never used uninitialized.
11455 * window.h (check_all_windows): New decl, to forestall
11456 gcc -Wmissing-prototypes diagnostic.
11457 * dispextern.h (bidi_dump_cached_states): Likewise.
11458
11459 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11460 shadowing.
11461 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11462 Include <limits.h>.
11463 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11464 and to avoid gcc -Wuninitialized warning.
11465 (load_charset_map): Mark variables that gcc -Wuninitialized
11466 does not deduce are never used uninitialized.
11467 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11468
11469 * coding.c (coding_set_source, coding_set_destination):
11470 Use "else { /* comment */ }" rather than "else /* comment */;"
11471 for clarity, and to avoid gcc -Wempty-body warning.
11472 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11473 a block, when the outer 'i' will do.
11474 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11475 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11476 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11477 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11478 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11479 Rename locals to avoid shadowing.
11480 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11481 * coding.c (emacs_mule_char, encode_invocation_designation):
11482 Now static, since they're not used elsewhere.
11483 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11484 (decode_coding_object, encode_coding_object, detect_coding_system):
11485 (decode_coding_emacs_mule): Mark variables that gcc
11486 -Wuninitialized does not deduce are never used uninitialized.
11487 (detect_coding_iso_2022): Initialize a local variable that might
11488 be used uninitialized. Leave a FIXME because it's not clear that
11489 this initialization is needed. (Bug#8211)
11490 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11491 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11492 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11493 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11494 Remove unused macros.
11495
11496 * category.c (hash_get_category_set): Remove unused local var.
11497 (copy_category_table): Now static, since it's not used elsewhere.
11498 * character.c (string_count_byte8): Likewise.
11499
11500 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11501 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11502
11503 * chartab.c (copy_sub_char_table): Now static, since it's not used
11504 elsewhere.
11505 (sub_char_table_ref_and_range, char_table_ref_and_range):
11506 Rename locals to avoid shadowing.
11507 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11508
11509 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11510 (BIDI_BOB): Remove unused macro.
11511
11512 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11513 deduce are never used uninitialized.
11514 * term.c (encode_terminal_code): Likewise.
11515
11516 * term.c (encode_terminal_code): Now static. Remove unused local.
11517
11518 * tparam.h: New file.
11519 * term.c, tparam.h: Include it.
11520 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11521 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11522 Move these decls to tparam.h, and make them agree with what
11523 is actually in tparam.c. The previous trick of using incompatible
11524 decls in different modules does not conform to the C standard.
11525 All callers of tparam changed to use tparam's actual API.
11526 * tparam.c (tparam1, tparam, tgoto):
11527 Use const pointers where appropriate.
11528
11529 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11530 * cm.h (struct cm): Likewise.
11531 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11532 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11533 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11534 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11535 (turn_on_face, init_tty): Likewise.
11536 * termchar.h (struct tty_display_info): Likewise.
11537
11538 * term.c (term_mouse_position): Rename local to avoid shadowing.
11539
11540 * alloc.c (mark_ttys): Move decl from here ...
11541 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11542
11543 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11544
11545 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11546
11547 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11548
11549 * search.c (compile_pattern_1): Remove argument regp, unused since
11550 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11551 (compile_pattern): Don't pass it.
11552
11553 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11554
11555 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11556 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11557 for ! HAVE_GTK3.
11558 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11559
11560 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11561
11562 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11563 gdk_window_get_screen, gdk_window_get_geometry,
11564 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11565 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11566 (xg_get_pixbuf_from_pixmap): New function.
11567 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11568 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11569 Call xg_get_pixbuf_from_pixmap instead of
11570 gdk_pixbuf_get_from_drawable.
11571 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11572 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11573 (xg_check_special_colors): Use GtkStyleContext and its functions
11574 for HAVE_GTK3.
11575 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11576 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11577 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11578 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11579 Call gtk_widget_get_preferred_size.
11580 (xg_frame_resized): gdk_window_get_geometry only takes 5
11581 parameters.
11582 (xg_win_to_widget, xg_event_is_for_menubar):
11583 Call gdk_x11_window_lookup_for_display.
11584 (xg_set_widget_bg): New function.
11585 (delete_cb): New function.
11586 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11587 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11588 (xg_set_background_color): Call xg_set_widget_bg.
11589 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11590 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11591 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11592 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11593 if ! HAVE_GTK3.
11594 (update_frame_tool_bar): Call gtk_widget_hide.
11595 (xg_initialize): Use GDK_KEY_g.
11596
11597 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11598 if ! HAVE_GTK3
11599 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11600
11601 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11602 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11603 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11604
11605 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11606
11607 * w32xfns.c (select_palette): Check success of RealizePalette against
11608 GDI_ERROR, not zero.
11609
11610 See ChangeLog.11 for earlier changes.
11611
11612 ;; Local Variables:
11613 ;; coding: utf-8
11614 ;; End:
11615
11616 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11617
11618 This file is part of GNU Emacs.
11619
11620 GNU Emacs is free software: you can redistribute it and/or modify
11621 it under the terms of the GNU General Public License as published by
11622 the Free Software Foundation, either version 3 of the License, or
11623 (at your option) any later version.
11624
11625 GNU Emacs is distributed in the hope that it will be useful,
11626 but WITHOUT ANY WARRANTY; without even the implied warranty of
11627 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11628 GNU General Public License for more details.
11629
11630 You should have received a copy of the GNU General Public License
11631 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.