1 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3 * xdisp.c (vmessage): Treat frame message as multibyte.
4 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
5 would generate the diagnostic "Making \302\247 buffer-local while
8 2012-06-08 Eli Zaretskii <eliz@gnu.org>
10 * dispnew.c (showing_window_margins_p): Undo last change, which
11 was done due to an inadvertent commit.
12 (adjust_frame_glyphs_for_frame_redisplay): Do call
13 showing_window_margins_p.
15 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
17 * eval.c (Fmake_var_non_special): New primitive.
18 (syms_of_eval): Defsubr it.
19 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
21 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
23 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
24 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
26 2012-06-08 Eli Zaretskii <eliz@gnu.org>
28 * alloc.c (allocate_vectorlike): Fix last change.
30 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
32 Block-based vector allocation of small vectors.
33 * lisp.h (struct vectorlike_header): New field `nbytes',
34 adjust comment accordingly.
35 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
36 to denote vector blocks. Adjust users (live_vector_p,
37 mark_maybe_pointer, valid_lisp_object_p) accordingly.
38 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
39 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
40 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
41 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
42 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
43 (roundup_size): New constant.
44 (struct vector_block): New data type.
45 (vector_blocks, vector_free_lists, zero_vector): New variables.
46 (all_vectors): Rename to `large_vectors'.
47 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
48 (sweep_vectors): New functions.
49 (allocate_vectorlike): Return `zero_vector' as the only vector of
50 0 items. Allocate new vector from block if vector size is less than
51 or equal to VBLOCK_BYTES_MAX.
52 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
53 (init_alloc_once): Add call to init_vectors.
55 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
57 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
59 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
61 * doprnt.c (doprnt): Truncate multibyte char correctly.
62 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
63 would mishandle a string argument "Xc" if X was a multibyte
64 character of length 2: it would truncate after X's first byte
65 rather than including all of X.
67 2012-06-06 Chong Yidong <cyd@gnu.org>
69 * buffer.c (word_wrap): Doc fix.
71 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
73 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
75 2012-06-03 Glenn Morris <rgm@gnu.org>
77 * xdisp.c (tool-bar-style): Doc fix.
79 2012-06-03 Ulrich Müller <ulm@gentoo.org>
81 * Makefile.in (PAXCTL): Define.
82 (temacs$(EXEEXT)): Disable memory randomization for the temacs
83 binary via PaX flags if the paxctl utility is available.
84 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
85 Restore PaX flags to their default. (Bug#11398)
87 2012-06-03 Chong Yidong <cyd@gnu.org>
89 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
92 2012-06-03 Chong Yidong <cyd@gnu.org>
94 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
95 (note_mode_line_or_margin_highlight): If there is no help echo,
96 use mode-line-default-help-echo. Handle the case where the mouse
97 position is past the end of the mode line string.
99 * buffer.c (buffer_local_value_1): New function, split from
100 Fbuffer_local_value; can return Qunbound.
101 (Fbuffer_local_value): Use it.
102 (Vmode_line_format): Docstring tweaks.
104 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
106 * sysdep.c (system_process_attributes): Improve comment.
108 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
110 * keyboard.c: Export real-this-command to Elisp.
111 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
112 and DEFVAR it. Update all users.
114 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
116 * minibuf.c (Fassoc_string): Remove duplicate declaration.
118 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
119 Convert pctcpu and pctmem to Lisp float properly.
120 Let the compiler fold better, as 100.0/0x8000 is exact.
122 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
124 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
127 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
129 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
131 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
133 For a 'struct window', replace some Lisp_Object fields to
134 bitfields where appropriate, remove unused fields.
135 * window.h (struct window): Remove unused 'last_mark_x' and
136 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
137 change it's type from Lisp_Object to bitfield.
138 Change type of 'force_start', 'optional_new_start',
139 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
140 fields from Lisp_Object to bitfield. Adjust users accordingly.
142 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
144 Pacify gcc -Wdouble-precision when using Xaw.
145 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
146 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
147 Use 'float' consistently, rather than 'float' in most places
148 and 'double' in a couple of places.
150 2012-05-31 Eli Zaretskii <eliz@gnu.org>
152 * xdisp.c (handle_stop): Detect whether we have overlay strings
153 loaded by testing it->current.overlay_string_index to be
154 non-negative, instead of checking whether n_overlay_strings is
155 positive. (Bug#11587)
157 2012-05-31 Chong Yidong <cyd@gnu.org>
159 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
161 * doc.c (Fsubstitute_command_keys): Doc fix.
163 2012-05-31 Eli Zaretskii <eliz@gnu.org>
165 * search.c (search_buffer): Remove calls to
166 r_alloc_inhibit_buffer_relocation, as it is now called by
167 maybe_unify_char, which was the cause of relocation of buffer text
170 2012-05-31 Eli Zaretskii <eliz@gnu.org>
172 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
173 for the duration of call to load_charset, to avoid problems with
174 callers of maybe_unify_char that access buffer text through C
177 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
178 decrement the inhibition flag, instead of just setting or
181 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
183 Remove obsolete '#define static' cruft.
184 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
185 This #undef was "temporary" in 2000; it is no longer needed
186 now that '#define static' has gone away.
187 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
188 (gray_bitmap_bits): Remove; no longer needed.
189 All uses replaced with definiens.
190 * xterm.c: Include "bitmaps/gray.xbm".
192 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
194 Clean up __executable_start, monstartup when --enable-profiling.
195 The following changes affect the code only when profiling.
196 * dispnew.c (__executable_start): Rename from safe_bcopy.
197 Define only on platforms that need it.
198 * emacs.c: Include <sys/gmon.h> when profiling.
199 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
200 (__executable_start): Remove decl, since lisp.h does it now.
201 (safe_bcopy): Remove decl; no longer has that name.
202 (main): Coalesce #if into single bit of code, for simplicity.
203 Cast pointers to uintptr_t, since standard libraries want integers
205 * lisp.h (__executable_start): New decl.
207 2012-05-31 Glenn Morris <rgm@gnu.org>
209 * image.c (Fimagemagick_types): Doc fix.
211 2012-05-30 Jim Meyering <meyering@redhat.com>
213 * callproc.c (Fcall_process_region): Include directory component
214 in mkstemp error message (Bug#11586).
216 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
218 * alloc.c, lisp.h (make_pure_vector): Now static.
220 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
222 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
224 (Fautoload): Do the hash-doc more carefully.
225 * data.c (Fdefalias): Purify definition, except for keymaps.
226 (Qdefun): Move from eval.c.
227 * lisp.h (Qdefun): Remove.
228 * lread.c (read1): Tiny simplification.
230 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
232 Do not create empty overlays with the evaporate property (Bug#9642).
233 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
234 Bug#9642, but explicitly check that the buffer the overlay would
235 be moved to is live and rearrange lines to make sure that errors
236 will not put the overlay in an inconsistent state.
237 (Fdelete_overlay): Cosmetics.
239 2012-05-28 Eli Zaretskii <eliz@gnu.org>
241 * w32term.c (my_bring_window_to_top): New function.
242 (x_raise_frame): Use handle returned by DeferWindowPos, which
243 could be different from the original one.
244 Call my_bring_window_to_top instead of my_set_foreground_window.
247 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
248 by calling BringWindowToTop.
250 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
251 (WM_EMACS_END): Increase by one.
253 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
255 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
256 This avoids undefined behavior that might cause the eassert
257 to not catch an out-of-range value.
259 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
261 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
264 2012-05-27 Eli Zaretskii <eliz@gnu.org>
266 * bidi.c (bidi_mirror_char): Fix last change.
268 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
270 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
271 when referring to sectname field in printf format.
273 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
275 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
276 Only r_alloc_inhibit_buffer_relocation needed to be added;
277 the others were already declared.
279 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
280 before checking whether it's out of range. Put the check inside
282 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
284 2012-05-27 Ken Brown <kbrown@cornell.edu>
286 * callproc.c (Fcall_process): Restore a line that was accidentally
287 commented out in the 2011-02-13 change (bug#11547).
289 2012-05-27 Eli Zaretskii <eliz@gnu.org>
291 * lisp.h [REL_ALLOC]: Add prototypes for external functions
294 * buffer.c [REL_ALLOC]: Remove prototypes of
295 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
296 they are now on lisp.h.
298 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
300 * search.c (search_buffer): Use it to inhibit relocation of buffer
301 text while re_search_2 is doing its job, because re_search_2 is
302 passed C pointers to buffer text. (Bug#11519)
304 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
307 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
308 state after an additional call to move_it_in_display_line_to, keep
309 the values of it->max_ascent and it->max_descent found for the
311 (pos_visible_p): Revert the comparison against bottom_y to what it
312 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
315 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
317 Fix coding-related core dumps with gcc -ftrapv.
318 The code was computing A - B, where A and B are pointers, and B is
319 random garbage. This can lead to core dumps on platforms that
320 have special pointer registers, and it also leads to core dumps on
321 x86-64 when compiled with gcc -ftrapv. The fix is to compute
322 A - B only when B is initialized properly.
323 * coding.c (coding_set_source, coding_set_destination): Return void.
324 (coding_change_source, coding_change_destinations): New functions,
325 with the old behaviors of coding_set_source and coding_set_destination.
326 All callers that need an offset changed to use these new functions.
328 2012-05-26 Glenn Morris <rgm@gnu.org>
330 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
332 2012-05-26 Eli Zaretskii <eliz@gnu.org>
334 Extend mouse support on W32 text-mode console.
335 * xdisp.c (draw_row_with_mouse_face):
336 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
338 * w32console.c: Include window.h.
339 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
341 (initialize_w32_display): Initialize mouse-highlight data.
343 * w32inevt.c: Include termchar.h and window.h.
344 (do_mouse_event): Support mouse-autoselect-window. When the mouse
345 moves, call note_mouse_highlight. If help_echo changed, call
346 gen_help_event to produce help-echo message in the echo area.
347 Call clear_mouse_face if mouse_face_hidden is set in the mouse
350 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
352 * lread.c (read1): Simplify slightly to avoid an overflow warning
353 with GCC 4.7.0 on x86-64.
355 2012-05-26 Eli Zaretskii <eliz@gnu.org>
357 * bidi.c (bidi_mirror_char): Revert last change: an int is
358 definitely wide enough here.
360 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
362 Fix integer width and related bugs (Bug#9874).
363 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
364 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
365 (string_bytes, check_sblock, allocate_string_data):
366 (compact_small_strings, Fmake_bool_vector, make_string)
367 (make_unibyte_string, make_multibyte_string)
368 (make_string_from_bytes, make_specified_string)
369 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
370 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
373 (allocate_pseudovector):
374 Use int, not EMACS_INT, where int is wide enough.
375 (inhibit_garbage_collection, Fgarbage_collect):
376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
377 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
378 int might not be wide enough.
379 (bidi_cache_search, bidi_cache_find, bidi_init_it)
380 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
381 (bidi_at_paragraph_end, bidi_find_paragraph_start)
382 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
383 (bidi_level_of_next_char, bidi_move_to_visually_next):
384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
385 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
386 (Fkill_buffer, Fset_buffer_major_mode)
387 (advance_to_char_boundary, Fbuffer_swap_text)
388 (Fset_buffer_multibyte, overlays_at, overlays_in)
389 (overlay_touches_p, struct sortvec, record_overlay_string)
390 (overlay_strings, recenter_overlay_lists)
391 (adjust_overlays_for_insert, adjust_overlays_for_delete)
392 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
393 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
394 (Foverlay_recenter, last_overlay_modification_hooks_used)
395 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
397 (validate_region): Omit unnecessary test for b <= e,
398 since that's guaranteed by the previous test.
399 (adjust_overlays_for_delete): Avoid pos + length overflow.
400 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
401 (report_overlay_modification):
402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
403 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
404 Omit pointer cast, which isn't needed anyway, and doesn't work
405 after the EMACS_INT -> ptrdiff_t change.
406 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
407 * buffer.h: Adjust decls to match defn changes elsewhere.
408 (struct buffer_text, struct buffer):
409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
410 Use EMACS_INT, not int, where int might not be wide enough.
411 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
412 not int, to avoid needless 32-bit limit on 64-bit hosts.
413 (exec_byte_code): Use tighter memory-full test, one that checks
414 for alloca overflow. Don't compute the address of the object just
415 before an array, as that's not portable. Use EMACS_INT, not
416 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
417 * callint.c (Fcall_interactively):
418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
419 * callproc.c (call_process_kill, Fcall_process):
420 Don't assume pid_t fits into an Emacs fixnum.
421 (call_process_cleanup, Fcall_process, child_setup):
422 Don't assume pid_t fits into int.
423 (call_process_cleanup, Fcall_process, delete_temp_file)
424 (Fcall_process_region):
425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
426 (Fcall_process): Simplify handling of volatile integers.
427 Use int, not EMACS_INT, where int will do.
428 * casefiddle.c (casify_object, casify_region, operate_on_word)
429 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
431 (casify_object): Avoid integer overflow when overallocating buffer.
432 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
433 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
434 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
435 * category.h (CATEGORYP): Don't assume arg is nonnegative.
436 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
437 integers are now checked earlier. All uses replaced with XINT.
439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
440 For CCL_MapSingle, check that content and value are in int range.
441 (ccl_driver, Fregister_code_conversion_map):
442 Check that Vcode_version_map_vector is a vector.
443 (resolve_symbol_ccl_program): Check that vector header is in range.
444 Always copy the vector, so that we can check its contents reliably
445 now rather than having to recheck each instruction as it's being
446 executed. Check that vector words fit in 'int'.
447 (ccl_get_compiled_code, Fregister_ccl_program)
448 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
449 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
450 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
451 contents are in range.
452 (Fccl_execute_on_string): Check that status is in range.
453 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
454 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
455 Accept and return EMACS_INT, not int, because callers can pass values
457 (c_string_width, strwidth, lisp_string_width, chars_in_text)
458 (multibyte_chars_in_text, parse_str_as_multibyte)
459 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
460 (str_as_unibyte, str_to_unibyte, string_count_byte8)
461 (string_escape_byte8, Fget_byte):
462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
463 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
464 avoid mishandling large integers.
465 * character.h: Adjust decls to match defn changes elsewhere.
466 * charset.c (load_charset_map_from_file, find_charsets_in_text)
467 (Ffind_charset_region):
468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
469 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
470 (load_charset_map_from_vector, Fdefine_charset_internal):
471 Don't assume fixnum fits in int.
472 (load_charset_map_from_vector, Fmap_charset_chars):
473 Remove now-unnecessary CHECK_NATNUMs.
474 (Fdefine_charset_internal): Check ranges here, more carefully.
475 Don't rely on undefined behavior with signed left shift overflow.
476 Don't assume unsigned int fits into fixnum, or that fixnum fits
477 into unsigned int. Don't require max_code to be a valid fixnum;
478 that's not true for gb10830 4-byte on a 32-bit host. Allow
479 invalid_code to be a cons, for the same reason. Require code_offset
480 to be a character. Avoid int overflow if max_char is close
482 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
483 this is intended anyway and avoids some undefined behavior.
484 (load_charset_map): Pass unsigned, not int, as 2nd arg of
485 INDEX_TO_CODE_POINT, as that's what it expects.
486 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
487 * charset.h (DECODE_CHAR): Return int, not unsigned;
488 this is what was intended anyway, and it avoids undefined behavior.
489 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
490 integer-overflow issues.
491 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
492 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
493 where the argument is EMACS_INT, and this behavior is not intended.
494 * chartab.c (Fmake_char_table, Fset_char_table_range)
495 (uniprop_get_decoder, uniprop_get_encoder):
496 Don't assume fixnum fits in int.
497 * cmds.c (move_point): New function, that does the gist of
498 Fforward_char and Fbackward_char, but does so while checking
499 for integer overflow more accurately.
500 (Fforward_char, Fbackward_char): Use it.
501 (Fforward_line, Fend_of_line, internal_self_insert)
502 (internal_self_insert):
503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
504 Fix a FIXME, by checking for integer overflow when calculating
505 target_clm and actual_clm.
506 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
507 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
508 (ASSURE_DESTINATION, coding_alloc_by_realloc)
509 (coding_alloc_by_making_gap, alloc_destination)
510 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
511 (encode_coding_utf_16, detect_coding_emacs_mule)
512 (decode_coding_emacs_mule, encode_coding_emacs_mule)
513 (detect_coding_iso_2022, decode_coding_iso_2022)
514 (encode_invocation_designation, encode_designation_at_bol)
515 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
516 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
517 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
518 (encode_coding_ccl, encode_coding_raw_text)
519 (detect_coding_charset, decode_coding_charset)
520 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
521 (produce_composition, produce_charset, produce_annotation)
522 (decode_coding, handle_composition_annotation)
523 (handle_charset_annotation, consume_chars, decode_coding_gap)
524 (decode_coding_object, encode_coding_object, detect_coding_system)
525 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
526 (code_convert_region, code_convert_string)
527 (Fdefine_coding_system_internal)
528 (coding_set_source, coding_set_destination):
529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
530 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
531 (Fdefine_coding_system_internal):
532 Don't assume fixnums fit in int.
533 (decode_coding_gap, decode_coding_object, encode_coding_object)
534 (Fread_coding_system, Fdetect_coding_region)
535 (Funencodable_char_position, Fcheck_coding_systems_region)
536 (get_translation, handle_composition_annotation, consume_chars):
537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
538 (consume_chars): Rewrite to not calculate an address outside buffer.
539 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
540 Don't access memory outside of the args array.
541 (Fdefine_coding_system_internal): Check for charset-id overflow.
542 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
543 result of ENCODE_CHAR.
544 * coding.h: Adjust decls to match defn changes elsewhere.
545 (struct coding_system):
546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
547 * composite.c (get_composition_id, find_composition)
548 (run_composition_function, update_compositions)
549 (compose_text, composition_gstring_put_cache)
550 (composition_gstring_p, composition_gstring_width)
551 (fill_gstring_header, fill_gstring_body, autocmp_chars)
552 (composition_compute_stop_pos, composition_reseat_it)
553 (composition_update_it, struct position_record)
554 (find_automatic_composition, composition_adjust_point)
555 (Fcomposition_get_gstring, Ffind_composition_internal):
556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
557 (update_compositions):
558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
559 * composite.h: Adjust decls to match defn changes elsewhere.
560 (struct composition):
561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
562 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
563 Do not attempt to compute the address of the object just before a
564 buffer; this is not portable.
566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
567 (Faset): Use int, not EMACS_INT, where int is wide enough.
568 (Fstring_to_number): Don't assume fixnums fit in int.
569 (Frem): Don't assume arg is nonnegative.
570 * dbusbind.c (xd_append_arg): Check for integers out of range.
571 (Fdbus_call_method): Don't overflow the timeout int.
572 (extract_signed, extract_unsigned): New functions.
573 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
574 (xd_get_connection_references): Return ptrdiff_t, not int.
576 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
578 Use int, not unsigned, where the dbus API uses int.
579 (Fdbus_message_internal): Don't overflow mtype.
580 (syms_of_dbusbind): Allocate right-sized buffer for integers.
581 * dired.c (directory_files_internal, file_name_completion, scmp)
582 (file_name_completion_stat):
583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
584 (file_name_completion): Don't overflow matchcount.
585 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
586 * dispextern.h: Adjust decls to match defn changes elsewhere.
587 (struct text_pos, struct glyph, struct bidi_saved_info)
588 (struct bidi_string_data, struct bidi_it, struct composition_it)
590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
591 (struct display_pos, struct composition_it, struct it):
592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
593 * dispnew.c (increment_matrix_positions)
594 (increment_row_positions, mode_line_string)
595 (marginal_area_string):
596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
597 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
599 (duration_to_sec_usec): New function, to check for overflow better.
600 (Fsleep_for, sit_for): Use it.
601 * doc.c (get_doc_string, store_function_docstring):
602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
603 (get_doc_string, Fsnarf_documentation):
604 Use int, not EMACS_INT, where int is wide enough.
606 Use SAFE_ALLOCA, not alloca.
607 Check for overflow when converting EMACS_INT to off_t.
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
611 Don't assume uid_t fits into fixnum.
612 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
613 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
614 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
615 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
616 (general_insert_function)
617 (Finsert_char, make_buffer_string, make_buffer_string_both)
618 (update_buffer_properties, Fbuffer_substring)
619 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
620 (Fsubst_char_in_region, check_translation)
621 (Ftranslate_region_internal, save_restriction_restore, Fformat)
622 (transpose_markers, Ftranspose_regions):
623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
624 (clip_to_bounds): Move to lisp.h as an inline function).
625 (Fconstrain_to_field): Don't assume integers are nonnegative.
626 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
627 (Fsubst_char_in_region, Fsave_restriction):
628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
629 (Femacs_pid): Don't assume pid_t fits into fixnum.
630 (lo_time): Use int, not EMACS_INT, when int suffices.
631 (lisp_time_argument): Check for usec out of range.
632 (Fencode_time): Don't assume fixnum fits in int.
633 (Fuser_login_name, Fuser_full_name): Signal an error
634 if a uid argument is out of range, rather than relying on
636 (Fformat_time_string): Remove now-unnecessary check.
637 lisp_time_argument checks for out-of-range usec now.
638 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
639 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
640 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
641 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
642 (init_cmdargs, Fdump_emacs):
643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
644 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
645 the bottom (typically) 32 bits of the fixnum.
646 * eval.c (specpdl_size, call_debugger):
647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
648 (when_entered_debugger, Fbacktrace_debug):
649 Don't assume fixnum can fit in int.
650 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
651 the object just before a buffer; this is not portable.
652 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
653 (grow_specpdl, unbind_to):
654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
655 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
656 (grow_specpdl): Simplify allocation by using xpalloc.
657 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
658 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
659 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
661 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 (Fcopy_file, non_regular_nbytes, read_non_regular)
665 (Finsert_file_contents):
666 Use int, not EMACS_INT, where int is wide enough.
667 (READ_BUF_SIZE): Verify that it fits in int.
668 (Finsert_file_contents): Check that counts are in proper range,
669 rather than assuming fixnums fit into ptrdiff_t etc.
670 Don't assume fixnums fit into int.
671 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
672 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
673 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
674 (string_char_to_byte, string_byte_to_char)
675 (string_make_multibyte, string_to_multibyte)
676 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
677 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
678 (substring_both, Fdelete, internal_equal, Ffillarray)
679 (Fclear_string, mapcar1)
680 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
681 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
682 (larger_vector, make_hash_table, maybe_resize_hash_table)
683 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
684 (Fmaphash, secure_hash):
685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
686 (concat): Check for string index and length overflow.
687 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
690 (larger_vector): New API (vec, incr_min, size_max) replaces old
691 one (vec, new_size, init). This catches size overflow.
692 INIT was removed because it was always Qnil.
694 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
695 the upper bound on a hash table index size.
696 (make_hash_table, maybe_resize_hash_table): Use it.
697 (secure_hash): Computer start_byte and end_byte only after
698 they're known to be in ptrdiff_t range.
699 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
700 (Ffont_get_glyphs, Ffont_at):
701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
702 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
703 (Flist_fonts, Fopen_font):
704 Don't assume fixnum can fit in int.
705 (check_gstring): Don't assume index can fit in int.
706 (font_match_p): Check that fixnum is a character, not a nonnegative
707 fixnum, since the later code needs to stuff it into an int.
708 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
709 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
710 conversion overflow issues.
711 (Fopen_font): Check for integer out of range.
712 (Ffont_get_glyphs): Don't assume index can fit in int.
713 * font.h: Adjust decls to match defn changes elsewhere.
714 * fontset.c (reorder_font_vector): Redo score calculation to avoid
716 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
717 printmax_t, where ptrdiff_t is wide enough.
718 (Finternal_char_font):
719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
720 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
721 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
722 (Fset_frame_position, x_set_frame_parameters)
723 (x_set_line_spacing, x_set_border_width)
724 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
725 Check that fixnums are in proper range for system types.
726 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
728 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
729 Use SAFE_ALLOCA_LISP, not alloca.
730 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
731 intptr_t is wide enough.
732 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
733 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
734 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
735 Check for fixnum out of range.
736 * ftfont.c (ftfont_list): Don't assume index fits in int.
737 Check that fixnums are in proper range for system types.
738 (ftfont_shape_by_flt):
739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
740 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
742 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
743 Check that fixnums are in proper range for system types.
744 * gnutls.h: Adjust decls to match defn changes elsewhere.
745 * gtkutil.c (xg_dialog_run):
746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
747 (update_frame_tool_bar):
748 Check that fixnums are in proper range for system types.
749 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
750 (lookup_image): Check that fixnums are in range for system types.
751 * indent.c (last_known_column, last_known_column_point):
752 (current_column_bol_cache):
753 (skip_invisible, current_column, check_display_width):
754 (check_display_width, scan_for_column, current_column_1)
755 (Findent_to, Fcurrent_indentation, position_indentation)
756 (indented_beyond_p, Fmove_to_column, compute_motion):
757 (Fcompute_motion, Fvertical_motion):
758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
759 (last_known_column_modified): Use EMACS_INT, not int.
760 (check_display_width):
762 Check that fixnums and floats are in proper range for system types.
763 (compute_motion): Don't assume index or fixnum fits in int.
764 (compute_motion, Fcompute_motion):
765 Use int, not EMACS_INT, when it is wide enough.
766 (vmotion): Omit local var start_hpos that is always 0; that way
767 we don't need to worry about overflow in expressions involving it.
768 * indent.h: Adjust decls to match defn changes elsewhere.
770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
771 Use int, not EMACS_INT, where int is wide enough.
772 Remove unused members ovstring_chars_done and tab_offset;
774 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
775 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
776 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
777 (make_gap, copy_text, insert, insert_and_inherit)
778 (insert_before_markers, insert_before_markers_and_inherit)
779 (insert_1, count_combining_before, count_combining_after)
780 (insert_1_both, insert_from_string)
781 (insert_from_string_before_markers, insert_from_string_1)
782 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
783 (adjust_after_replace, adjust_after_insert, replace_range)
784 (replace_range_2, del_range, del_range_1, del_range_byte)
785 (del_range_both, del_range_2, modify_region)
786 (prepare_to_modify_buffer, signal_before_change)
787 (signal_after_change, Fcombine_after_change_execute):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 * intervals.c (traverse_intervals, rotate_right, rotate_left)
790 (balance_an_interval, split_interval_right, split_interval_left)
791 (find_interval, next_interval, update_interval)
792 (adjust_intervals_for_insertion, delete_node, delete_interval)
793 (interval_deletion_adjustment, adjust_intervals_for_deletion)
794 (static_offset_intervals, offset_intervals)
795 (merge_interval_right, merge_interval_left, make_new_interval)
796 (graft_intervals_into_buffer, temp_set_point_both)
797 (temp_set_point, set_point, adjust_for_invis_intang)
798 (set_point_both, move_if_not_intangible, get_property_and_range)
799 (get_local_map, copy_intervals, copy_intervals_to_string)
800 (compare_string_intervals, set_intervals_multibyte_1):
801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
802 * intervals.h: Adjust decls to match defn changes elsewhere.
804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
805 * keyboard.c (this_command_key_count, this_single_command_key_start)
806 (before_command_key_count, before_command_echo_length, echo_now)
807 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
808 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
809 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
810 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
812 (last_non_minibuf_size, last_point_position, echo_truncate)
813 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
814 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
815 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
816 (stuff_buffered_input):
817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
818 (last_auto_save, command_loop_1, read_char):
819 Use EMACS_INT, not int, to avoid integer overflow.
820 (record_char): Avoid overflow in total_keys computation.
821 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
822 * keyboard.h: Adjust decls to match defn changes elsewhere.
823 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
824 (Fkey_description, Fdescribe_vector, Flookup_key):
825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
826 (click_position): New function, to check that positions are in range.
827 (Fcurrent_active_maps):
829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
830 (Faccessible_keymaps, Fkey_description):
831 (preferred_sequence_p):
832 Don't assume fixnum can fit into int.
833 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
834 Check for integer overflow in size calculations.
835 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
836 avoid mishandling large integers.
837 * lisp.h: Adjust decls to match defn changes elsewhere.
838 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
839 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
840 (struct Lisp_Marker):
841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
842 (clip_to_bounds): Now an inline function, moved here from editfns.c.
843 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
844 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
846 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
847 Assume the arg has valid form, since it always does.
848 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
849 unsigned integer system type.
850 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
851 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
853 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
854 (duration_to_sec_usec): New decl.
855 * lread.c (read_from_string_index, read_from_string_index_byte)
856 (read_from_string_limit, readchar, unreadchar, openp)
857 (read_internal_start, read1, oblookup):
858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
859 (Fload, readevalloop, Feval_buffer, Feval_region):
860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
861 (openp): Check for out-of-range argument to 'access'.
862 (read1): Use int, not EMACS_INT, where int is wide enough.
863 Don't assume fixnum fits into int.
864 Fix off-by-one error that can read outside a buffer.
865 (read_filtered_event): Use duration_to_sec_usec
866 to do proper overflow checking on durations.
867 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
869 (Fexecute_kbd_macro):
870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
871 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
872 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
873 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
874 (set_marker_both, set_marker_restricted_both, marker_position)
875 (marker_byte_position, Fbuffer_has_markers_at):
876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
877 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
878 * menu.c (ensure_menu_items): Rename from grow_menu_items.
879 It now merely ensures that the menu is large enough, without
880 necessarily growing it, as this avoids some integer overflow issues.
882 (keymap_panes, parse_single_submenu, Fx_popup_menu):
883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
884 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
885 Use SAFE_ALLOCA_LISP, not alloca.
886 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
887 to EMACS_INT. Check that fixnums are in proper range for system types.
888 * minibuf.c (minibuf_prompt_width, string_to_object)
889 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
890 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
892 (get_minibuffer, read_minibuf_unwind):
893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
894 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
895 this simplifies overflow checking. All callers changed.
896 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
899 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
900 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
901 Check that fixnums are in proper range for system types.
902 (Fx_create_frame, Fx_show_tip):
903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
904 * nsfont.m (ns_findfonts, nsfont_list_family):
905 Don't assume fixnum fits in long.
906 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
908 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
910 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
912 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
913 (PRINTDECLARE, PRINTPREPARE):
914 (strout, print_string):
915 (print, print_preprocess, print_check_string_charset_prop)
917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
919 (temp_output_buffer_setup, Fprin1_to_string, print_object):
920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
921 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
922 (printchar, strout): Use xpalloc to catch size calculation overflow.
923 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
924 (print_error_message): Use SAFE_ALLOCA, not alloca.
925 (print_object): Use int, not EMACS_INT, where int is wide enough.
926 (print_depth, new_backquote_output, print_number_index):
927 Use ptrdiff_t, not int, where int might not be wide enough.
928 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
929 (Fset_process_window_size, Fformat_network_address)
930 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
932 Check that fixnums are in proper range for system types.
933 (Fsignal_process): Simplify by avoiding a goto.
934 Check for process-ids out of pid_t range rather than relying on
936 (process_tick, update_tick): Use EMACS_INT, not int.
937 (Fformat_network_address, read_process_output, send_process)
938 (Fprocess_send_region, status_notify):
939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
940 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
941 (wait_reading_process_output, read_process_output, exec_sentinel):
942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
943 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
944 (Faccept_process_output): Use duration_to_sec_usec to do proper
945 overflow checking on durations.
946 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
947 Don't assume pid_t fits in int.
948 * process.h (struct Lisp_Process): Members tick and update_tick
949 are now of type EMACS_INT, not int.
950 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
951 configured --with-wide-int.
952 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
953 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
954 * search.c (looking_at_1, string_match_1):
955 (fast_string_match, fast_c_string_match_ignore_case)
956 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
957 (scan_newline, find_before_next_newline, search_command)
958 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
959 (set_search_regs, wordify):
962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
963 (string_match_1, search_buffer, set_search_regs):
965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
966 (wordify): Check for overflow in size calculation.
967 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
968 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
969 Check that fixnums are in proper range for system types.
970 * sound.c (struct sound_device)
971 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
973 (Fplay_sound_internal):
974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
975 * syntax.c (struct lisp_parse_state, find_start_modiff)
976 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
977 (Fparse_partial_sexp):
978 Don't assume fixnums can fit in int.
979 (struct lisp_parse_state, find_start_pos, find_start_value)
980 (find_start_value_byte, find_start_begv)
981 (update_syntax_table, char_quoted, dec_bytepos)
982 (find_defun_start, prev_char_comend_first, back_comment):
983 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
984 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
986 (Finternal_describe_syntax_value): Check that match_lisp is a
987 character, not an integer, since the code stuffs it into int.
988 (scan_words, scan_sexps_forward):
989 Check that fixnums are in proper range for system types.
991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
992 (scan_sexps_forward):
993 Use CHARACTERP, not INTEGERP, since the value must fit into int.
994 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
995 * syntax.h: Adjust decls to match defn changes elsewhere.
997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
998 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
999 MOST_POSITIVE_FIXNUM.
1000 * sysdep.c (wait_for_termination_1, wait_for_termination)
1001 (interruptible_wait_for_termination, mkdir):
1002 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1003 (emacs_read, emacs_write):
1004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1005 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1006 and double all fit in int.
1007 * term.c (set_tty_color_mode):
1008 Check that fixnums are in proper range for system types.
1009 * termhooks.h (struct input_event):
1010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1011 * textprop.c (validate_interval_range, interval_of)
1012 (Fadd_text_properties, set_text_properties_1)
1013 (Fremove_text_properties, Fremove_list_of_text_properties)
1014 (Ftext_property_any, Ftext_property_not_all)
1015 (copy_text_properties, text_property_list, extend_property_ranges)
1016 (verify_interval_modification):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (Fnext_single_char_property_change)
1019 (Fprevious_single_char_property_change):
1020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1021 (copy_text_properties):
1022 Check for integer overflow in index calculation.
1023 * undo.c (last_boundary_position, record_point, record_insert)
1024 (record_delete, record_marker_adjustment, record_change)
1025 (record_property_change):
1026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1027 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1029 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1030 (Fx_hide_tip, Fx_file_dialog):
1031 * w32menu.c (set_frame_menubar):
1032 Use ptrdiff_t, not int, for consistency with rest of code.
1033 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1034 (select_window, Fdelete_other_windows_internal)
1035 (window_scroll_pixel_based, window_scroll_line_based)
1036 (Frecenter, Fset_window_configuration):
1037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1038 (Fset_window_hscroll, run_window_configuration_change_hook)
1039 (set_window_buffer, temp_output_buffer_show, scroll_command)
1040 (Fscroll_other_window, Frecenter):
1041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1042 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1043 Don't assume fixnum fits in int.
1044 (Fset_window_scroll_bars):
1045 Check that fixnums are in proper range for system types.
1046 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1047 (string_pos, c_string_pos, number_of_chars, init_iterator)
1048 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1049 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1050 (compute_display_string_end, handle_face_prop)
1051 (face_before_or_after_it_pos, handle_invisible_prop)
1052 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1053 (display_prop_intangible_p, string_buffer_position_lim)
1054 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1055 (get_overlay_strings_1, get_overlay_strings)
1056 (iterate_out_of_display_property, forward_to_next_line_start)
1057 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1058 (get_next_display_element, set_iterator_to_next)
1059 (get_visually_first_element, compute_stop_pos_backwards)
1060 (handle_stop_backwards, next_element_from_buffer)
1061 (move_it_in_display_line_to, move_it_in_display_line)
1062 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1063 (add_to_log, message_dolog, message_log_check_duplicate)
1064 (message2, message2_nolog, message3, message3_nolog
1065 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1066 (current_message_1, truncate_echo_area, truncate_message_1)
1067 (set_message, set_message_1, store_mode_line_noprop)
1068 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1069 (text_outside_line_unchanged_p, check_point_in_composition)
1070 (reconsider_clip_changes)
1071 (redisplay_internal, set_cursor_from_row, try_scrolling)
1072 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1073 (redisplay_window, find_last_unchanged_at_beg_row)
1074 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1075 (trailing_whitespace_p, find_row_edges, display_line)
1076 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1077 (display_mode_element, store_mode_line_string)
1078 (pint2str, pint2hrstr, decode_mode_spec)
1079 (display_count_lines, display_string, draw_glyphs)
1080 (x_produce_glyphs, x_insert_glyphs)
1081 (rows_from_pos_range, mouse_face_from_buffer_pos)
1082 (fast_find_string_pos, mouse_face_from_string_pos)
1083 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1085 (safe_call, init_from_display_pos, handle_fontified_prop)
1086 (handle_single_display_spec, load_overlay_strings)
1087 (with_echo_area_buffer, setup_echo_area_for_printing)
1088 (display_echo_area, echo_area_display)
1089 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1090 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1091 (redisplay_window, dump_glyph_row, display_mode_line)
1092 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1093 (handle_display_spec, display_prop_string_p):
1094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1095 (handle_single_display_spec, build_desired_tool_bar_string)
1096 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1097 (get_specified_cursor_type):
1098 Check that fixnums are in proper range for system types.
1099 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1100 (Flookup_image_map):
1101 Don't assume fixnums fit in int.
1102 (compare_overlay_entries):
1103 Avoid mishandling comparisons due to subtraction overflow.
1104 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1105 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1106 (handle_tool_bar_click):
1107 Use int, not unsigned, since we prefer signed and the signedness
1108 doesn't matter here.
1109 (get_next_display_element, next_element_from_display_vector):
1110 Use int, not EMACS_INT, when int is wide enough.
1111 (start_hourglass): Use duration_to_sec_usec to do proper
1112 overflow checking on durations.
1113 * xfaces.c (Fbitmap_spec_p):
1114 Check that fixnums are in proper range for system types.
1115 (compare_fonts_by_sort_order):
1116 Avoid mishandling comparisons due to subtraction overflow.
1117 (Fx_family_fonts, realize_basic_faces):
1118 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1120 Don't assume fixnum fits in int.
1121 Use SAFE_ALLOCA_LISP, not alloca.
1122 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1123 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1124 (face_at_buffer_position, face_for_overlay_string)
1125 (face_at_string_position):
1126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1127 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1128 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1130 Check that fixnums are in proper range for system types.
1131 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1132 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1134 (Fx_change_window_property): Don't assume fixnums fit in int.
1135 * xfont.c (xfont_chars_supported):
1136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1137 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1138 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1140 * xml.c (parse_region):
1141 * xrdb.c (magic_file_p):
1142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1143 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1144 (x_get_local_selection, x_reply_selection_request)
1145 (x_handle_selection_request, wait_for_property_change):
1146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1147 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1148 short is wide enough.
1149 (x_send_client_event): Don't assume fixnum fits in int.
1150 * xterm.c (x_x_to_emacs_modifiers):
1151 Don't assume EMACS_INT overflows nicely into int.
1152 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1154 (handle_one_xevent): NATNUMP can eval its arg twice.
1155 (x_connection_closed):
1156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1157 * xterm.h: Adjust decls to match defn changes elsewhere.
1158 (struct scroll_bar): Use struct vectorlike_header
1159 rather than rolling our own approximation.
1160 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1162 2012-05-25 Glenn Morris <rgm@gnu.org>
1164 * lisp.mk (lisp): Update for more files being compiled now.
1166 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1168 * lread.c: Remove `read_pure' which makes no difference.
1169 (read_pure): Remove var.
1170 (unreadpure): Remove function.
1171 (readevalloop): Don't call read_list with -1 flag.
1172 (read1, read_vector): Don't test read_pure any more.
1173 (read_list): Simplify.
1175 * fileio.c, character.h: Minor style tweaks.
1177 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1179 * window.h (clip_changed): Remove useless declaration.
1181 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1183 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1184 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1186 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1189 This directory predates autoconf and is no longer needed nowadays.
1190 Move its few remaining bits of functionality to where they're needed.
1191 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1192 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1193 * m/template.h: Remove.
1194 * Makefile.in (M_FILE): Remove. All uses removed.
1195 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1196 * lisp.h (USE_LSB_TAG):
1197 * mem-limits.h (EXCEEDS_LISP_PTR):
1198 Use VAL_MAX, not VALBITS, in #if.
1199 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1200 (EMACS_UINT): Define unconditionally now.
1201 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1202 (BITS_PER_EMACS_INT): New constants, replacing
1203 what used to be in config.h, but not useful in #if.
1204 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1205 define them any more.
1206 (VAL_MAX): New macro.
1208 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1209 BITS_PER_EMACS_INT, in #if.
1210 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1211 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1212 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1213 * s/ms-w32.h (DATA_START):
1214 Move here from removed file m/intel386.h.
1215 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1216 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1218 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1220 Assume C89 or later.
1221 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1222 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1224 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1225 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1226 * textprop.c, tparam.c (NULL): Remove.
1227 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1228 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1229 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1230 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1231 * xterm.c (input_signal_count): Assume volatile works.
1233 2012-05-21 Ken Brown <kbrown@cornell.edu>
1235 * xgselect.c (xg_select): Fix first argument in call to 'select'
1238 2012-05-20 Ken Brown <kbrown@cornell.edu>
1240 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1241 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1243 2012-05-19 Ken Brown <kbrown@cornell.edu>
1245 * xfns.c (x_in_use): Remove `static' qualifier.
1246 * xterm.h (x_in_use): Declare.
1247 * xgselect.c: Include xterm.h.
1248 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1249 and `display_arg' (bug#9754).
1251 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1253 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1255 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1256 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1258 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1260 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1262 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1263 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1265 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1266 reference to image_cache->refcount.
1267 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1269 2012-05-17 Juri Linkov <juri@jurta.org>
1271 * search.c (Fword_search_regexp, Fword_search_backward)
1272 (Fword_search_forward, Fword_search_backward_lax)
1273 (Fword_search_forward_lax): Move functions to isearch.el
1274 (bug#10145, bug#11381).
1276 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1278 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1280 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1282 * lread.c (init_obarray): Declare Qt and Qnil as special.
1284 2012-05-14 Glenn Morris <rgm@gnu.org>
1286 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1287 Put "libexec" before "bin", for the sake of init_callproc_1.
1289 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1291 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1293 * unexaix.c: Port to more-recent AIX compilers.
1294 (report_error, report_error_1, make_hdr, copy_sym)
1295 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1296 Make arguments const char *, not char *, to avoid violations of C
1297 standard and to fix some AIX warnings reported by Gilles Pion.
1299 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1301 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1302 already have overlays loaded.
1303 (handle_single_display_spec): Before returning without displaying
1304 fringe bitmap, synchronize the bidi iterator with the main display
1305 iterator, by calling iterate_out_of_display_property.
1306 (iterate_out_of_display_property): Detect buffer iteration by
1307 testing that it->string is a Lisp string.
1308 (get_next_display_element): When the current object is exhausted,
1309 and there's something on it->stack, call set_iterator_to_next to
1310 proceed with what's on the stack, instead of returning zero.
1311 (set_iterator_to_next): If called at the end of a Lisp string,
1312 proceed to consider_string_end without incrementing string
1313 position. Don't increment display vector index past the end of
1314 the display vector. (Bug#11417)
1315 (pos_visible_p): Don't report a position visible when move_it_to
1316 stopped at the last line of window, which happens to be scanned
1317 backwards by the bidi iteration. (Bug#11464)
1319 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1321 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1322 and right-margin display specs even if the spec is invalid or we
1323 are on a TTY, and thus unable to display on the fringes.
1324 That's because the text with the property will not be displayed anyway,
1325 so we need to signal to the caller that this is a "replacing"
1326 display spec. This fixes display when the spec is invalid or we
1329 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1331 * unexaix.c (make_hdr): Fix typo in prototype.
1332 This bug broke the build on AIX. Problem reported by Gilles Pion.
1334 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1336 * keyboard.c (kbd_buffer_get_event): Read special events also in
1337 batch mode. (Bug#11415)
1339 2012-05-12 Glenn Morris <rgm@gnu.org>
1341 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1343 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1345 * lisp.mk (lisp): Add newcomment.elc.
1347 2012-05-12 Glenn Morris <rgm@gnu.org>
1349 * Makefile.in (MKDIR_P): New, set by configure.
1350 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1352 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1354 Remove unused function hourglass_started.
1355 * dispextern.h (hourglass_started):
1356 * w32fns.c (hourglass_started):
1357 * xdisp.c (hourglass_started): Remove.
1359 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1361 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1362 Update dependencies.
1364 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1366 * xgselect.c (xg_select): Put maxfds+1 into a var.
1367 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1369 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1371 2012-05-10 Dave Abrahams <dave@boostpro.com>
1373 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1374 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1376 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1378 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1379 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1380 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1381 Initialize xd_registered_buses.
1383 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1385 Untag more efficiently if USE_LSB_TAG.
1386 This is based on a proposal by YAMAMOTO Mitsuharu in
1387 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1388 For an admittedly artificial (nth 8000 longlist) benchmark on
1389 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1390 Emacs's overall text size by 1%.
1391 * lisp.h (XUNTAG): New macro.
1392 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1393 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1394 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1395 * eval.c (Fautoload):
1396 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1397 * frame.h (XFRAME): Use XUNTAG.
1399 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1400 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1401 Remove unportable assumptions about print widths of types like
1403 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1404 intptr_t when converting between pointer and integer, to avoid GCC
1405 warnings about wrong width.
1407 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1409 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1410 stack for each reader_thread, instead of defaulting to 8MB
1411 determined by the linker. This avoids failures in creating
1412 subprocesses on Windows 7, see the discussion in this thread:
1413 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1415 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1417 Fix up display of the *Minibuf-0* buffer in the mini window.
1418 * keyboard.c (read_char): Don't clear the echo area if there's no
1420 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1421 contents of *Minibuf-0*) if there's no message displayed in its stead.
1423 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1425 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1428 2012-05-06 Chong Yidong <cyd@gnu.org>
1430 * lisp.mk (lisp): Update.
1432 2012-05-05 Jim Meyering <meyering@redhat.com>
1434 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1436 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1438 * data.c (PUT_ERROR): New macro.
1439 (syms_of_data): Use it. Add new error type `user-error'.
1440 * undo.c (user_error): New function.
1441 (Fprimitive_undo): Use it.
1442 * print.c (print_error_message): Adjust print style for `user-error'.
1443 * keyboard.c (user_error): New function.
1444 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1446 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1448 Do not limit current-time-string to years 1000..9999.
1449 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1450 (Fcurrent_time_string): Support any year that is supported by the
1451 underlying localtime representation. Don't use asctime, as it
1452 has undefined behavior for years outside the range -999..9999.
1454 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1456 Fix race conditions involving setenv, gmtime, localtime, asctime.
1457 Without this fix, interrupts could mess up code that uses these
1458 nonreentrant functions, since setting TZ invalidates existing
1459 tm_zone or tzname values, and since most of these functions return
1460 pointers to static storage.
1461 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1462 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1463 Grow the critical sections to include not just invoking
1464 localtime/gmtime, but also accessing these functions' results
1465 including their tm_zone values if any, and any related TZ setting.
1466 (format_time_string): Last arg is now struct tm *, not struct tm **,
1467 so that the struct tm is saved in the critical section.
1468 All callers changed. Simplify allocation of initial buffer, partly
1469 motivated by the fact that memory allocation needs to be outside
1470 the critical section.
1472 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1474 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1475 with RESET_INTERVAL.
1477 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1478 Remove duplicated buffer name initialization.
1480 2012-05-02 Jim Meyering <jim@meyering.net>
1482 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1484 * xfns.c (x_window): Use xstrdup (Bug#11375).
1486 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1488 * xdisp.c (pos_visible_p): If already at a newline from the
1489 display string before the 'while' loop, don't walk back the glyphs
1490 from it3.glyph_row. Solves assertion violation when the display
1491 string begins with a newline (egg.el). (Bug#11367)
1493 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1495 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1498 2012-05-01 Glenn Morris <rgm@gnu.org>
1500 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1501 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1502 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1503 All were removed before 23.1.
1505 * dispnew.c: Remove HAVE_LIBNCURSES test;
1506 it is always true on relevant platforms.
1508 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1509 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1511 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1513 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1515 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1516 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1519 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1521 Do not avoid creating empty evaporating overlays (Bug#9642).
1522 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1523 That is, do not delete an evaporating overlay if it becomes
1524 empty after its bounds are adjusted to fit within its buffer.
1525 This fix caused other problems, and I'm reverting it until we get
1526 to the bottom of them.
1528 2012-04-27 Chong Yidong <cyd@gnu.org>
1530 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1532 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1534 * xdisp.c (pos_visible_p): If the window start position is beyond
1535 ZV, start the display from buffer beginning. Prevents assertion
1536 violation in init_iterator when the minibuffer window is scrolled
1539 * window.c (window_scroll_pixel_based): Likewise.
1541 2012-04-27 Chong Yidong <cyd@gnu.org>
1543 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1545 2012-04-27 Glenn Morris <rgm@gnu.org>
1547 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1548 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1550 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1552 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1553 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1555 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1557 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1558 display element, check also the underlying string or buffer
1559 character. (Bug#11341)
1561 * w32menu.c: Include w32heap.h.
1562 (add_menu_item): If the call to AppendMenuW (via
1563 unicode_append_menu) fails, disable Unicode menus only if we are
1564 running on Windows 9X/Me.
1566 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1568 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1569 (xgetint): Add missing shift for LSB tags.
1571 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1573 * keyboard.c (read_char): Don't wipe echo area for select window
1574 events: These might get delayed via `mouse-autoselect-window'
1577 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1579 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1580 manipulation of :loaded-from data.
1582 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1584 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1585 now a cons (bug#11311).
1587 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1589 Do not create empty overlays with the evaporate property (Bug#9642).
1590 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1591 if it becomes empty after its bounds are adjusted to fit within
1592 its buffer. Without this fix, in a nonempty buffer (let ((o
1593 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1594 yields an empty overlay that has the evaporate property, which is
1595 not supposed to happen.
1597 Fix minor GTK3 problems found by static checking.
1598 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1599 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1600 (struct _EmacsFixedClass, emacs_fixed_get_type):
1601 Move decls here from emacsgtkfixed.h, since they needn't be public.
1602 (emacs_fixed_get_type): Now static.
1603 (emacs_fixed_class_init): Omit unused local.
1604 (emacs_fixed_child_type): Remove; unused.
1605 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1606 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1607 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1608 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1609 (EMACS_FIXED_GET_CLASS): Remove; unused.
1610 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1612 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1613 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1615 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1617 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1618 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1619 (__malloc_size_t, __malloc_ptrdiff_t):
1620 Remove. All uses removed, replaced by the definiens if needed,
1621 since we can assume C89 or better now.
1622 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1623 (protect_malloc_state, align, get_contiguous_space)
1624 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1625 (malloc_atfork_handler_child, malloc_enable_thread)
1626 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1627 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1628 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1629 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1630 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1631 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1632 Define using prototypes, not old style.
1633 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1634 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1635 (align): Don't assume that signed integer overflow wraps around.
1636 Omit unused local var.
1637 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1638 (_free_internal_nolock, memalign, mallochook, reallochook):
1639 Omit no-longer-needed casts.
1640 (valloc): Use getpagesize, not __getpagesize.
1641 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1642 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1644 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1646 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1648 Move functions from C to Lisp. Make non-blocking method calls
1649 the default. Implement further D-Bus standard interfaces.
1651 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1652 (QCdbus_request_name_allow_replacement)
1653 (QCdbus_request_name_replace_existing)
1654 (QCdbus_request_name_do_not_queue)
1655 (QCdbus_request_name_reply_primary_owner)
1656 (QCdbus_request_name_reply_in_queue)
1657 (QCdbus_request_name_reply_exists)
1658 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1659 (QCdbus_registered_serial, QCdbus_registered_method)
1660 (QCdbus_registered_signal): New Lisp objects.
1661 (XD_DEBUG_MESSAGE): Use sizeof.
1662 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1663 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1664 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1665 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1666 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1667 (xd_signature, xd_append_arg): Allow float for integer types.
1668 (xd_get_connection_references): New function.
1669 (xd_get_connection_address): Rename from xd_initialize.
1670 Return cached address.
1671 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1672 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1674 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1675 Return number of refcounts.
1676 (Fdbus_get_unique_name): Make stronger parameter check.
1677 (Fdbus_message_internal): New defun.
1678 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1679 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1680 (Fdbus_send_signal, Fdbus_register_service)
1681 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1682 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1683 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1684 (Vdbus_compiled_version, Vdbus_runtime_version)
1685 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1686 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1687 (Vdbus_message_type_signal): New defvars.
1688 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1691 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1693 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1694 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1695 Do not assume ptrdiff_t is the same width as 'int'.
1697 * alloc.c: Handle unusual debugging option combinations.
1698 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1699 since the two debugging options are incompatible.
1700 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1702 (mem_init, mem_insert, mem_insert_fixup):
1703 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1704 (NEED_MEM_INSERT): Remove; no longer needed.
1706 2012-04-22 Leo Liu <sdl.web@gmail.com>
1708 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1710 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1712 * sysdep.c [__FreeBSD__]: Minor cleanups.
1713 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1714 Use Emacs indenting style more consistently. Avoid some casts.
1715 Use 'double' consistently rather than mixing 'float' and 'double'.
1717 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1719 * sysdep.c (list_system_processes, system_process_attributes):
1720 Add implementation for FreeBSD (Bug#5243).
1722 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1724 * lisp.mk (lisp): Update.
1726 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1728 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1729 It is never used otherwise.
1731 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1733 * print.c (print_preprocess): Only check print_depth if print-circle
1735 (print_object): Check for cycles even when print-circle is nil and
1736 print-gensym is t, but only check print_depth if print-circle is nil.
1738 2012-04-20 Chong Yidong <cyd@gnu.org>
1740 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1741 set the status to "failed" and ensure that sentinel is run.
1743 2012-04-20 Glenn Morris <rgm@gnu.org>
1745 * process.c (Fset_process_inherit_coding_system_flag)
1746 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1747 (Fmake_network_process, Fmake_serial_process): Doc fix.
1749 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1751 * xdisp.c (string_buffer_position_lim): Limit starting position to
1753 (set_cursor_from_row): If called for a mode-line or header-line
1754 row, return zero immediately.
1755 (try_cursor_movement): If inside continuation line, don't back up
1756 farther than the first row after the header line, if any.
1757 Don't consider the header-line row as "partially visible", even if
1758 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1760 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1762 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1765 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1766 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1768 configure: new option --enable-gcc-warnings (Bug#11207)
1769 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1770 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1771 (ALL_CFLAGS): Use new macros rather than old.
1772 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1773 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1774 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1775 -Wunused-result, -Wunused-variable. This should go away once
1776 the Emacs and Gnulib regex code is merged.
1777 (xmalloc, xrealloc): Now static.
1779 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1781 * dired.c (Fsystem_groups): Remove unused local.
1783 2012-04-17 Glenn Morris <rgm@gnu.org>
1785 * dired.c (Fsystem_users): Doc fix.
1787 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1789 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1790 (syms_of_dired): Add them.
1792 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1794 Fix minor alloc.c problems found by static checking.
1795 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1796 New extern decls, to avoid calling undeclared functions.
1797 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1798 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1799 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1800 (NEED_MEM_INSERT): New macro.
1801 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1802 Remove one incorrect comment and fix another.
1804 Fix minor ralloc.c problems found by static checking.
1805 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1806 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1807 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1808 (r_alloc_sbrk): Now static.
1810 Improve ralloc.c interface checking.
1811 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1812 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1813 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1814 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1815 [REL_ALLOC]: ... to here, to check interface.
1816 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1817 Remove decls. This fixes an "It stinks!".
1819 * alloc.c (which_symbols): Fix alignment issue / type clash.
1821 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1823 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1824 (struct Lisp_Misc_Any): Likewise.
1825 (struct Lisp_Free): Likewise.
1826 * alloc.c (union aligned_Lisp_Symbol): Define.
1827 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1828 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1829 (union aligned_Lisp_Misc): Define.
1830 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1831 aligned_Lisp_Misc instead of union Lisp_Misc.
1832 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1834 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1836 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1837 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1838 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1839 * s/netbsd.h, s/sol2-6.h:
1840 Remove definition of GC_MARK_STACK, since the default now works.
1841 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1842 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1843 no longer the default.
1844 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1846 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1848 * lread.c (lisp_file_lexically_bound_p):
1849 Fix hang at ";-*-\n" (bug#11238).
1851 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1853 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1854 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1856 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1858 * nsterm.m (constrainFrameRect): Always constrain when there is only
1859 one screen (Bug#10962).
1861 2012-04-13 Ken Brown <kbrown@cornell.edu>
1863 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1865 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1867 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1869 2012-04-11 Daniel Colascione <dancol@dancol.org>
1871 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1872 against is gone. It's better to use vfork now so that when Cygwin
1873 gains a new, working vfork, we use it automatically (bug#10398).
1875 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1877 * window.c (save_window_save): Obey window-point-insertion-type.
1879 2012-04-11 Glenn Morris <rgm@gnu.org>
1881 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1883 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1885 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1887 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1889 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1890 (force_quit_count): New var.
1891 (handle_interrupt): Use it.
1893 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1895 * w32.c (w32_delayed_load): Record the full path of the library
1896 being loaded (bug#10424).
1898 2012-04-09 Glenn Morris <rgm@gnu.org>
1900 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1901 not just in the obarray, before snarfing them. (Bug#11036)
1903 * Makefile.in ($(leimdir)/leim-list.el):
1904 Pass EMACS rather than BUILT_EMACS.
1906 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1908 * process.c (make_process):
1909 * process.h: Add integer `gnutls_handshakes_tried' member to
1912 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1913 Add convenience `GNUTLS_LOG2i' macro.
1915 * gnutls.c (gnutls_log_function2i): Convenience log function.
1916 (emacs_gnutls_read): Use new log functions,
1917 `gnutls_handshakes_tried' process member, and
1918 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1919 attempts per process (connection).
1921 2012-04-09 Chong Yidong <cyd@gnu.org>
1923 * eval.c (Fuser_variable_p, user_variable_p_eh)
1924 (lisp_indirect_variable): Functions deleted.
1925 (Fdefvar): Caller changed.
1927 * callint.c (Finteractive, Fcall_interactively):
1928 * minibuf.c (Fread_variable): Callers changed.
1930 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1932 * xdisp.c (set_cursor_from_row): If the display string appears in
1933 the buffer at position that is closer to point than the position
1934 after the display string, display the cursor on the first glyph of
1935 the display string. Fixes cursor display when a 'display' text
1936 property immediately follows invisible text. (Bug#11094)
1938 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1940 composite.c: use 'double' consistently
1941 * composite.c (get_composition_id): Use 'double' consistently
1942 instead of converting 'float' to 'double' and vice versa; this is
1943 easier to understand and avoids a GCC warning.
1945 2012-04-09 Glenn Morris <rgm@gnu.org>
1947 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1948 preparation for dumping it with emacs. (Bug#4789)
1949 (leimdir): New variable.
1950 ($(leimdir)/leim-list.el): New rule.
1951 (emacs$(EXEEXT)): Depend on leim-list.el.
1953 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1954 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1955 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1957 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1959 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1962 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1964 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1965 Remove unused local variable.
1967 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1969 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1970 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1971 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1972 objects, as mark_maybe_pointer will catch them otherwise.
1973 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1974 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1976 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1978 Fix typo that broke non-Windows builds.
1979 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1981 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1983 Support building on MS-Windows with libxml2.
1985 * makefile.w32-in (OBJ2): Add xml.$(O).
1986 (GLOBAL_SOURCES): Add xml.c.
1987 ($(BLD)/xml.$(O)): New dependency list.
1989 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1990 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1991 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1992 [!WINDOWSNT]: New macros.
1993 (init_libxml2_functions, libxml2_loaded_p): New functions.
1994 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1995 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1996 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1997 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1999 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2000 Call init_libxml2_functions before calling libxml2 functions.
2001 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2003 * emacs.c: Don't include libxml/parser.h.
2004 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2005 xmlCleanupParser directly.
2007 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2009 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2011 * indent.c (Fvertical_motion): If there is a display string at
2012 point, use it.vpos to compute how many lines to backtrack after
2013 move_it_to point. (Bug#11133)
2015 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2017 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2018 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2019 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2020 macros related to unification of CJK characters. For the details,
2021 see the discussion following the message here:
2022 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2024 2012-04-04 Chong Yidong <cyd@gnu.org>
2026 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2028 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2030 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2031 instead of alloca. (Bug#11138)
2033 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2035 * w32menu.c (is_simple_dialog): Properly check lisp types.
2038 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2040 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2041 position we get to after a call to move_it_to fails the
2042 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2043 only if we wind up in a string from display property. (Bug#11063)
2045 * window.c (Fdelete_other_windows_internal): Invalidate the row
2046 and column information about mouse highlight, so that redisplay
2047 restores it after reallocating the glyph matrices. (Bug#7464)
2049 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2050 string comes from a `display' text property, use the buffer
2051 position of that property as if we actually saw that position in
2053 (move_it_by_lines): Remove the assertion that
2054 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2055 violated when there's a before-string at the beginning of a line.
2058 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2060 * xdisp.c (append_space_for_newline): If the default face was
2061 remapped, use the remapped face for the appended newline.
2062 (extend_face_to_end_of_line): Use the remapped default face for
2063 extending the face to the end of the line.
2064 (display_line): Call extend_face_to_end_of_line when the default
2065 face was remapped. (Bug#11068)
2067 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2069 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2071 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2073 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2075 2012-03-27 Glenn Morris <rgm@gnu.org>
2077 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2080 2012-03-26 Kenichi Handa <handa@m17n.org>
2082 * dispextern.h (struct glyph): Fix previous change. Change the
2083 bit length of glyphless.ch to 25 (Bug#11082).
2085 2012-03-26 Chong Yidong <cyd@gnu.org>
2087 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2088 (command_loop_1): Use it; inhibit selection update for
2089 handle-select-window too (Bug#8996).
2091 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2093 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2095 2012-03-25 Kenichi Handa <handa@m17n.org>
2097 * dispextern.h (struct glyph): Change the bit length of
2098 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2100 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2102 * s/ms-w32.h (tzname): Include time.h before redirecting to
2103 _tzname. Fixes the MSVC build. (Bug#9960)
2105 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2107 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2110 * xterm.c (XTread_socket): Only modify handling_signal if
2111 !SYNC_INPUT. (Bug#11080)
2113 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2115 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2116 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2117 when fetching a multibyte character consumes more bytes than
2118 CHAR_BYTES returns, due to unification of CJK characters in
2119 string_char. (Bug#11073)
2121 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2123 * process.c (wait_reading_process_output): Handle pty disconnect
2124 by refraining from sending oneself a SIGCHLD (bug#10933).
2126 2012-03-22 Chong Yidong <cyd@gnu.org>
2128 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2130 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2131 Mark string as coming from a prefix property.
2132 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2133 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2135 2012-03-21 Chong Yidong <cyd@gnu.org>
2137 * xfaces.c (Vface_remapping_alist): Doc fix.
2139 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2141 * w32proc.c (Fw32_set_console_codepage)
2142 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2145 2012-03-20 Chong Yidong <cyd@gnu.org>
2147 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2148 to reflect default non-nil value of redisplay-dont-pause.
2150 2012-03-19 Kenichi Handa <handa@m17n.org>
2152 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2153 it fit in a valid range (Bug#11003).
2155 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2157 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2158 that is not from display property, accept the row as a "cursor
2159 row" if one of the string's character has a non-nil `cursor'
2160 property. Fixes cursor positioning when there are newlines in
2161 overlay strings, e.g. in icomplete.el. (Bug#11035)
2163 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2165 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2167 2012-03-12 Chong Yidong <cyd@gnu.org>
2169 * eval.c (inhibit_lisp_code): Rename from
2170 inhibit_window_configuration_change_hook; move from window.c.
2172 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2173 * window.c (run_window_configuration_change_hook)
2174 (syms_of_window): Callers changed.
2176 2012-03-11 Chong Yidong <cyd@gnu.org>
2178 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2180 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2182 2012-03-10 Chong Yidong <cyd@gnu.org>
2184 * frame.c (other_visible_frames): Don't assume the selected frame
2185 is visible (Bug#10955).
2187 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2189 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2191 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2193 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2194 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2197 2012-03-03 Glenn Morris <rgm@gnu.org>
2199 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2201 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2203 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2204 position past the first glyph_row that ends at ZV. (Bug#10902)
2205 (redisplay_window, next_element_from_string): Fix typos in
2207 (redisplay_window): Pass to move_it_vertically the margin in
2208 pixels, not in screen lines.
2210 2012-03-02 Glenn Morris <rgm@gnu.org>
2212 * buffer.c (buffer-list-update-hook): Doc fix.
2214 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2216 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2217 push_it before setting up the iterator for the first overlay
2218 string, even if we have an empty string loaded.
2219 (next_overlay_string): If there's an empty string on the iterator
2220 stack, pop the stack. (Bug#10903)
2222 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2224 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2225 Suggested by Stefan Monnier in
2226 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2227 * alloc.c (widen_to_Lisp_Object): New static function.
2228 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2229 and widening them to Lisp_Objects. This would work even if
2230 USE_LSB_TAG is defined and wide integers are used, which might
2231 happen in a future version of Emacs.
2233 2012-02-25 Chong Yidong <cyd@gnu.org>
2235 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2238 * xselect.c (Fx_selection_exists_p): Doc fix.
2239 (x_clipboard_manager_save_all): Print an informative message
2240 before saving to clipboard manager.
2242 2012-02-24 Chong Yidong <cyd@gnu.org>
2244 * keyboard.c (process_special_events): Handle all X selection
2245 requests in kbd_buffer, not just the next one (Bug#8869).
2247 2012-02-23 Chong Yidong <cyd@gnu.org>
2249 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2250 call when setting menu-bar-lines and tool-bar-lines parameters.
2251 (unwind_create_frame_1): New helper function.
2253 * window.c (inhibit_window_configuration_change_hook): New var.
2254 (run_window_configuration_change_hook): Obey it.
2255 (syms_of_window): Initialize it.
2257 2012-02-22 Chong Yidong <cyd@gnu.org>
2259 * xterm.c (x_draw_image_relief): Add missing type check for
2260 Vtool_bar_button_margin (Bug#10743).
2262 2012-02-21 Chong Yidong <cyd@gnu.org>
2264 * fileio.c (Vfile_name_handler_alist): Doc fix.
2266 * buffer.c (Fget_file_buffer): Protect against invalid file
2267 handler return value.
2269 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2271 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2272 when computing $valmask.
2274 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2275 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2276 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2277 It's useless in that case, and it can cause problems on hosts
2278 that allocate halves of EMACS_INT values separately.
2279 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2280 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2281 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2282 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2283 it avoids undefined behavior on hosts where shifting right by more
2284 than the word width has undefined behavior.
2286 2012-02-19 Chong Yidong <cyd@gnu.org>
2288 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2289 (Funhandled_file_name_directory, Ffile_name_as_directory)
2290 (Fdirectory_file_name, Fexpand_file_name)
2291 (Fsubstitute_in_file_name): Protect against invalid file handler
2292 return values (Bug#10845).
2294 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2296 * .gdbinit (pitx): Fix incorrect references to fields of the
2299 2012-02-17 Chong Yidong <cyd@gnu.org>
2301 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2303 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2305 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2306 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2308 2012-02-15 Chong Yidong <cyd@gnu.org>
2310 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2311 marked as special. Also, starting docstrings with * is obsolete.
2313 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2315 * gnutls.c (emacs_gnutls_write): Fix last change.
2317 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2319 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2322 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2324 * keymap.c (Fsingle_key_description): Handle char ranges.
2326 2012-02-12 Chong Yidong <cyd@gnu.org>
2328 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2329 as that creates a dangerous corner case.
2331 * window.c (Fdelete_window_internal): Invalidate the mouse
2332 highlight (Bug#9904).
2334 2012-02-12 Glenn Morris <rgm@gnu.org>
2336 * xselect.c (Fx_own_selection_internal)
2337 (Fx_get_selection_internal, Fx_disown_selection_internal)
2338 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2339 * nsselect.m (Fx_own_selection_internal)
2340 (Fx_disown_selection_internal, Fx_selection_exists_p)
2341 (Fx_selection_owner_p, Fx_get_selection_internal):
2342 Sync docs and argument specs with the xselect.c versions.
2344 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2346 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2348 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2350 * w32select.c (Fx_selection_exists_p): Sync doc string and
2351 argument list with xselect.c. (Bug#10783)
2353 * w16select.c (Fx_selection_exists_p): Sync doc string and
2354 argument list with xselect.c. (Bug#10783)
2356 2012-02-10 Glenn Morris <rgm@gnu.org>
2358 * fns.c (Fsecure_hash): Doc fix.
2360 2012-02-09 Kenichi Handa <handa@m17n.org>
2362 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2364 2012-02-07 Chong Yidong <cyd@gnu.org>
2366 * buffer.c (Fbuffer_local_variables)
2367 (buffer_lisp_local_variables): Handle unbound vars correctly;
2368 don't let Qunbound leak into Lisp.
2370 2012-02-07 Glenn Morris <rgm@gnu.org>
2372 * image.c (Fimagemagick_types): Doc fix.
2374 * image.c (imagemagick-render-type): Change it from a lisp object
2375 to an integer. Move the doc here from the lisp manual.
2376 Treat all values not equal to 0 the same.
2378 2012-02-06 Chong Yidong <cyd@gnu.org>
2380 * doc.c (store_function_docstring): Avoid applying docstring of
2381 alias to base function (Bug#2603).
2383 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2385 * .gdbinit (pp1, pv1): Remove redundant defines.
2388 2012-02-04 Chong Yidong <cyd@gnu.org>
2390 * nsterm.m: Declare a global (Bug#10694).
2392 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2394 * w32.c (get_emacs_configuration_options):
2395 Include --enable-checking, if specified, in the return value.
2397 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2399 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2400 after rounding frame sizes. (Bug#9723)
2402 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2404 * keyboard.c (adjust_point_for_property): Don't position point
2405 before BEGV. (Bug#10696)
2407 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2409 Handle overflow when computing char display width (Bug#9496).
2410 * character.c (char_width): Return EMACS_INT, not int.
2411 (char_width, c_string_width): Check for overflow when
2412 computing the width; this is possible now that individual
2413 characters can have unbounded width. Problem introduced
2414 by merge from Emacs 23 on 2012-01-19.
2416 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2418 * dbusbind.c (Fdbus_register_method): Mention the return value
2419 :ignore in the docstring.
2421 2012-02-02 Glenn Morris <rgm@gnu.org>
2423 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2425 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2426 Unconditionally set to t. (Bug#10673)
2427 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2428 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2429 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2431 2012-02-02 Kenichi Handa <handa@m17n.org>
2433 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2434 0, do not call append_composite_glyph.
2436 2012-02-02 Kenichi Handa <handa@m17n.org>
2438 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2440 (x_produce_glyphs): If the component of a composition is a null
2441 string, set it->pixel_width to 1 to avoid zero-width glyph.
2443 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2445 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2446 first 2 arguments are identical. This makes inserting large
2447 output from a subprocess an order of magnitude faster on
2448 MS-Windows, where all sbrk'ed memory is always contiguous.
2450 2012-01-31 Glenn Morris <rgm@gnu.org>
2452 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2453 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2454 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2456 2012-01-29 Glenn Morris <rgm@gnu.org>
2458 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2460 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2462 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2464 2012-01-28 Chong Yidong <cyd@gnu.org>
2466 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2468 2012-01-26 Chong Yidong <cyd@gnu.org>
2470 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2472 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2473 repeat counts (Bug#10507).
2475 2012-01-26 Glenn Morris <rgm@gnu.org>
2477 * lread.c (syms_of_lread): Doc fix.
2479 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2481 * coding.c (encode_designation_at_bol): Change return value to
2484 2012-01-25 Chong Yidong <cyd@gnu.org>
2486 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2488 2012-01-21 Chong Yidong <cyd@gnu.org>
2490 * floatfns.c (Fcopysign): Make the second argument non-optional,
2491 since nil is not allowed anyway.
2493 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2495 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2496 (send_process): Likewise.
2498 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2500 * window.c (save_window_save, Fcurrent_window_configuration)
2501 (Vwindow_persistent_parameters): Do not use Qstate.
2502 Rewrite doc-strings.
2504 2012-01-19 Kenichi Handa <handa@m17n.org>
2506 * character.c (char_width): New function.
2507 (Fchar_width, c_string_width, lisp_string_width):
2508 Use char_width (Bug#9496).
2510 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2512 * window.c (Vwindow_persistent_parameters): New variable.
2513 (Fset_window_configuration, save_window_save): Handle persistent
2516 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2518 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2519 thrashing the stack of the thread. (Bug#9087)
2521 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2523 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2525 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2527 * xdisp.c (rows_from_pos_range): Handle the case where the
2528 highlight ends on a newline. (Bug#10464)
2529 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2530 he end column for display of highlight that ends on a newline
2533 2012-01-11 Glenn Morris <rgm@gnu.org>
2535 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2536 from load-path also when installation-directory is nil. (Bug#10208)
2538 2012-01-10 Glenn Morris <rgm@gnu.org>
2540 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2542 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2543 Update template values to be closer to their typical values these days.
2545 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2547 * xdisp.c (rows_from_pos_range): Accept additional argument
2548 DISP_STRING, and accept any glyph in a row whose object is that
2549 string as eligible for mouse highlight. Fixes mouse highlight of
2550 display strings from overlays. (Bug#10464)
2552 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2554 emacs: fix an auto-save permissions race condition (Bug#10400)
2555 * fileio.c (auto_saving_dir_umask): New static var.
2556 (Fmake_directory_internal): Use it.
2557 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2558 creating the directory. The old code temporarily assigns
2559 too-generous permissions to the directory.
2560 (do_auto_save_eh): Clear it.
2561 (Fdo_auto_save): Catch all errors, not just file errors, so
2562 that the var is always cleared.
2564 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2566 * search.c (scan_buffer): Pass character positions to
2567 know_region_cache, not byte positions. (Bug#6540)
2569 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2571 * w32.c (sys_rename): Report EXDEV when rename of a directory
2572 fails because the target is on another logical disk. (Bug#10284)
2574 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2576 * xterm.c (x_embed_request_focus): New function.
2578 * xterm.h: Add prototype.
2580 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2582 2012-01-05 Glenn Morris <rgm@gnu.org>
2584 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2586 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2588 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2589 Load gnutls_transport_set_lowat only if GnuTLS version is below
2591 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2592 GnuTLS versions below 2.11.1.
2594 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2596 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2597 to the doc string advising against its use for altering the way
2598 windows are scrolled.
2600 2011-12-28 Kenichi Handa <handa@m17n.org>
2602 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2603 coding-system ASCII compatible only when it does not produce BOM
2604 on encoding (Bug#10383).
2606 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2608 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2610 (create_and_show_popup_menu): Always use menu_position_func for
2613 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2615 * callint.c (Fcall_interactively): Don't truncate prompt string.
2617 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2619 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2620 property that ends at ZV, so that the bidi iteration could be
2621 resumed from there (after widening). (Bug#10360)
2623 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2625 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2627 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2629 * nsterm.m (x_free_frame_resources):
2630 Release f->output_data.ns->miniimage.
2631 (ns_index_color): Fix indentation. Do not retain
2632 color_table->colors[i].
2634 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2637 * nsfns.m (x_set_background_color): Assign return value from
2638 ns_index_color to face-background instead of NSColor*.
2639 (ns_implicitly_set_icon_type): Fix indentation.
2640 Change assignment in for loop to comparison.
2642 * emacs.c (ns_pool): New variable.
2643 (main): Assign ns_pool.
2644 (Fkill_emacs): Call ns_release_autorelease_pool.
2646 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2647 autorelease fdesc, release fdAttrs and tdict.
2648 (ns_get_covering_families): Release charset.
2649 (ns_findfonts): Release NSFontDescriptor created with new.
2650 (ns_uni_to_glyphs): Fix indentation.
2651 (setString): Release attrStr before assigning new value.
2653 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2655 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2657 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2658 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2660 2011-12-18 David Reitter <reitter@cmu.edu>
2662 * nsterm.m (ns_term_init): Subscribe for notifications
2663 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2664 to method trackingNotification in EmacsMenu.
2666 * nsmenu.m (trackingMenu): New variable.
2667 (trackingNotification): New method (from Aquamacs).
2668 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2669 from Aquamacs (Bug#7030).
2671 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2673 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2674 (symbol_to_nsstring): Fix indentation.
2675 (ns_symbol_to_pb): New function.
2676 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2677 (Fns_rotate_cut_buffers_internal): Remove.
2678 (Fns_store_selection_internal): Rename from
2679 Fns_store_cut_buffer_internal.
2680 (ns_get_foreign_selection, Fx_own_selection_internal)
2681 (Fx_disown_selection_internal, Fx_selection_exists_p)
2682 (Fns_get_selection_internal, Fns_store_selection_internal):
2683 Use ns_symbol_to_pb and check if return value is nil.
2684 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2685 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2686 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2687 renamed to Sns_store_selection_internal.
2688 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2689 and remove this function.
2690 (ns_handle_selection_clear): Remove, never used.
2691 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2694 2011-12-17 Ken Brown <kbrown@cornell.edu>
2696 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2697 GID is unknown (Bug#10257).
2699 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2701 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2702 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2703 which caused a build failure on GNU/Linux IA-64. This problem was
2704 introduced by my 2011-10-07 patch.
2706 2011-12-15 Juri Linkov <juri@jurta.org>
2708 * image.c (imagemagick_error): New function. (Bug#10112)
2709 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2710 Use `imagemagick_error' where ImageMagick functions return
2712 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2715 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2717 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2718 fill background (Bug#8992).
2720 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2722 * window.c (Vwindow_combination_resize)
2723 (Vwindow_combination_limit): Use t instead of non-nil in
2725 (Vrecenter_redisplay): Add first sentence of doc-string on
2727 (Frecenter): Fix doc-string typo.
2729 2011-12-11 Kenichi Handa <handa@m17n.org>
2731 * coding.c (Funencodable_char_position): Pay attention to the
2732 buffer text relocation (Bug#9389).
2734 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2736 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2737 gtk_init (Bug#10100).
2739 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2741 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2742 IT->string is nil. (Bug#10263)
2744 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2746 * nsterm.h (x_free_frame_resources): Declare.
2748 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2749 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2751 * nsterm.h (ns_get_defaults_value): Declare.
2753 * nsterm.m (ns_default): Call ns_get_defaults_value.
2755 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2757 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2760 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2762 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2763 that where the value of an _OBJC_* symbol points to is in the .bss
2764 section (Bug#10240).
2766 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2768 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2769 after the loop to call ccl_driver at least once (Bug#8619).
2771 2011-12-08 Kenichi Handa <handa@m17n.org>
2773 * ftfont.c (get_adstyle_property): Fix previous change
2776 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2778 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2779 dirs from the default value of EMACSLOADPATH (bug#10208).
2781 2011-12-07 Glenn Morris <rgm@gnu.org>
2783 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2784 installation and source directories as well. (Bug#10208)
2786 2011-12-06 Chong Yidong <cyd@gnu.org>
2788 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2790 2011-12-06 Glenn Morris <rgm@gnu.org>
2792 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2793 as an error, not just -1. (Bug#10217)
2795 2011-12-05 Chong Yidong <cyd@gnu.org>
2797 * keyboard.c (process_special_events): New function.
2798 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2800 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2802 * coding.c (encode_designation_at_bol): Don't use uninitialized
2803 local variable (Bug#9318).
2805 2011-12-05 Kenichi Handa <handa@m17n.org>
2807 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2808 return Qnil (Bug#8046, Bug#10193).
2810 2011-12-05 Kenichi Handa <handa@m17n.org>
2812 * coding.c (encode_designation_at_bol): New args charbuf_end and
2813 dst. Return the number of produced bytes. Callers changed.
2814 (coding_set_source): Return how many bytes coding->source was
2816 (coding_set_destination): Return how many bytes
2817 coding->destination was relocated.
2818 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2819 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2821 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2823 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2824 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2827 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2829 The following changes are to fix Bug#9318.
2831 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2832 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2833 (encode_coding_iso_2022, encode_coding_sjis)
2834 (encode_coding_big5, encode_coding_charset): Use the above macros.
2836 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2838 * lisp.h (process_quit_flag): Fix external declaration.
2840 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2842 Don't macro-inline non-performance-critical code.
2843 * eval.c (process_quit_flag): New function.
2844 * lisp.h (QUIT): Use it.
2846 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2848 * nsfns.m (get_geometry_from_preferences): New function.
2849 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2851 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2853 * emacs.c (Qkill_emacs): Define.
2854 (syms_of_emacs): Initialize it.
2855 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2856 Qquit_flag to `kill-emacs' instead.
2857 (quit_throw_to_read_char): Add parameter `from_signal'.
2858 All callers changed. Call Fkill_emacs if requested and safe.
2859 * lisp.h (QUIT): Call Fkill_emacs if requested.
2861 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2863 * widget.c (update_wm_hints): Return if wmshell is null.
2864 (widget_update_wm_size_hints): New function.
2866 * widget.h (widget_update_wm_size_hints): Declare.
2868 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2869 widget_update_wm_size_hints (Bug#10104).
2871 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2873 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2874 before a newline, prepare the bidi iterator for consuming the
2875 newline, and keep the current paragraph direction. (Bug#10183)
2876 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2878 2011-12-02 Juri Linkov <juri@jurta.org>
2880 * search.c (Fword_search_regexp): New Lisp function created from
2881 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2882 (Fword_search_backward, Fword_search_forward)
2883 (Fword_search_backward_lax, Fword_search_forward_lax):
2884 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2885 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2887 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2889 * fileio.c (Finsert_file_contents): Move after-change-function call
2890 to before the "handled:" label, since all "goto handled" appear in
2891 cases where the *-change-functions have already been properly called
2894 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2896 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2897 waiting for input. (Bug#10169)
2899 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2901 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2902 verifies glyph row's hash code--we have just reallocated the
2903 glyphs, so their contents can be complete garbage. (Bug#10164)
2905 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2907 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2909 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2911 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2912 attributes are tested _before_ calling verify_row_hash, to protect
2913 against GCC re-ordering of the tests. (Bug#10164)
2915 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2917 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2919 * xterm.c (handle_one_xevent): Only set async_visible and friends
2920 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2921 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2922 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2924 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2926 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2927 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2928 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2929 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2930 All uses changed to use GCPRO1 etc.
2931 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2932 Revert to old implementation (i.e., before 2011-03-11).
2934 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2936 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2937 of scroll runs so as to avoid assigning disabled bogus rows and
2938 unnecessary graphics copy operations.
2940 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2942 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2943 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2944 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2945 (malloc, free, realloc, calloc): Redirect to e_* only when
2948 * lisp.h (GCTYPEBITS): Move before first use.
2949 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2950 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2951 this macro definition.
2953 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2956 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2958 * gtkutil.c (xg_create_frame_widgets):
2959 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2960 present with Gtk+ 2.0.
2962 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2964 * fileio.c (Finsert_file_contents): Undo previous change; see
2965 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2967 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2969 Rename locals to avoid shadowing.
2970 * fileio.c (Finsert_file_contents):
2971 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2972 * process.c (wait_reading_process_output):
2973 Rename inner 'proc' to 'p' to avoid shadowing.
2974 Indent for consistency with usual Emacs style.
2976 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2978 * xdisp.c (redisplay_window): If cursor row is not fully visible
2979 after recentering, and scroll-conservatively is set to a large
2980 number, scroll window by a few more lines to make the cursor fully
2981 visible and out of scroll-margin. (Bug#10105)
2982 (start_display): Don't move to the next line if the display should
2983 start at a newline that is part of a display vector or an overlay
2986 2011-11-24 Juri Linkov <juri@jurta.org>
2988 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2989 after the `MagickPingImage' call. (Bug#10112)
2991 2011-11-23 Chong Yidong <cyd@gnu.org>
2993 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2995 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2997 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2998 making another buffer current. (Bug#10114)
3000 2011-11-23 Glenn Morris <rgm@gnu.org>
3002 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3004 2011-11-23 Chong Yidong <cyd@gnu.org>
3006 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3007 using it (Bug#5984).
3009 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3011 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3012 and header-lines, as they don't have one computed for them.
3015 * .gdbinit (prow): Make displayed values more self-explaining.
3016 Add row's hash code.
3018 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3020 * process.c (wait_reading_process_output): Fix asynchrounous
3021 GnuTLS socket handling on some versions of the GnuTLS library.
3022 (wait_reading_process_output): Add comment and URL.
3024 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3026 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3028 2011-11-21 Chong Yidong <cyd@gnu.org>
3030 * window.c (Fnext_window, Fprevious_window): Doc fix.
3032 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3034 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3036 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3038 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3040 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3042 * window.c (Fset_window_combination_limit): Rename argument
3044 (Vwindow_combination_limit): Remove "status" from doc-string.
3046 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3048 * m/ibms390.h: Remove.
3049 * m/ibms390x.h: Don't include "ibms390.h".
3051 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3053 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3054 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3056 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3058 * casetab.c (Fset_case_table):
3059 * charset.c (Fcharset_after): Fix typos.
3061 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3063 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3064 Otherwise, valgrind does not work on some platforms.
3065 Problem reported by Andreas Schwab in
3066 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3067 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3068 is set, removing the need for VIRT_ADDRESS_VARIES.
3069 (PURE_P): Use a more-efficient implementation that needs just one
3070 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3071 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3072 to 4 (xorl, subq, cmpq, setbe).
3073 * alloc.c (pure): Always extern now, since that's the
3074 VIRT_ADDR_VARIES behavior.
3075 (PURE_POINTER_P): Use a single comparison, not two, for
3076 consistency with the new puresize.h.
3077 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3078 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3079 Remove VIRT_ADDR_VARIES no longer needed.
3081 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3083 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3084 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3085 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3086 behave as if the cursor position were at the window margin.
3088 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3089 and the cursor position is out of bounds, behave as if the cursor
3090 position were at the window margin. (Bug#10075)
3092 2011-11-18 Chong Yidong <cyd@gnu.org>
3094 * window.c (Fwindow_combination_limit): Make first argument
3095 non-optional, since it is meaningless for live windows like the
3098 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3100 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3102 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3104 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3105 (graft_intervals_into_buffer): Simplify.
3107 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3109 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3110 hash values of the two rows.
3111 (copy_row_except_pointers): Preserve the used[] arrays and the
3112 hash values of the two rows. (Bug#10035)
3113 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3115 * xdisp.c (row_hash): New function, body extracted from
3116 compute_line_metrics.
3117 (compute_line_metrics): Call row_hash, instead of computing the
3120 * dispnew.c (verify_row_hash): Call row_hash for computing the
3121 hash code of a row, instead of duplicating code from xdisp.c.
3123 * dispextern.h (row_hash): Add prototype.
3125 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3127 * frame.c (delete_frame): Don't delete the terminal when the last
3128 X frame is closed if emacs is built with GTK toolkit.
3130 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3132 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3134 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3136 * window.c (Vwindow_splits): Rename to
3137 Vwindow_combination_resize. Suggested by Juri Linkov.
3138 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3141 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3143 * nsfns.m (Fns_font_name):
3144 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3146 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3148 * window.h (window): Rename slot "nest" to "combination_limit".
3149 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3150 (Fset_window_nest): Rename to Fset_window_combination_limit.
3151 (Vwindow_nest): Rename to Vwindow_combination_limit.
3152 (recombine_windows, make_parent_window, make_window)
3153 (Fsplit_window_internal, saved_window)
3154 (Fset_window_configuration, save_window_save): Rename all
3155 occurrences of window_nest to window_combination_limit.
3157 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3159 * image.c (imagemagick_load_image): Fix typo.
3161 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3163 * xdisp.c (display_line): Move the call to
3164 highlight_trailing_whitespace before the call to
3165 compute_line_metrics, since the latter needs to see the final
3166 faces of all the glyphs to compute ROW's hash value.
3167 Fixes assertion violations in row_equal_p. (Bug#10035)
3169 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3171 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3172 just return (bug#10044).
3174 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3176 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3177 with user-defined heap size. Bump the default size of the temacs
3178 heap to 27MB, to avoid memory warning when running temacs.
3179 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3181 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3182 current_matrix and desired_matrix. (Bug#9990)
3183 (verify_row_hash) [XASSERTS]: New function.
3184 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3185 that the hash value of glyph rows is correct.
3187 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3189 * window.h (window): Remove splits slot.
3190 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3191 (Fdelete_other_windows_internal, make_parent_window)
3192 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3193 (Fset_window_configuration, save_window_save): Don't deal with
3194 split status of windows.
3195 (saved_window): Remove splits slot.
3196 (Vwindow_splits): Rewrite doc-string.
3198 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3200 * xfns.c (unwind_create_frame):
3201 * nsfns.m (unwind_create_frame):
3202 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3203 Vframe_list (Bug#9999).
3205 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3207 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3209 2011-11-11 Kenichi Handa <handa@m17n.org>
3211 * callproc.c (Fcall_process): Set the member dst_multibyte of
3214 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3216 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3217 avoid a crash (bug#9496).
3219 2011-11-09 Chong Yidong <cyd@gnu.org>
3221 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3222 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3224 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3226 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3228 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3230 Avoid some portability problems by eschewing 'extern inline' functions.
3231 The trivial performance wins aren't worth the portability hassles; see
3232 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3234 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3235 (window_box_width, window_box_left, window_box_left_offset)
3236 (window_box_right, window_box_right_offset): Undo previous change,
3237 by removing the "extern"s.
3238 * intervals.c (adjust_intervals_for_insertion)
3239 (adjust_intervals_for_deletion): Undo previous change,
3240 making these static again.
3241 (offset_intervals, temp_set_point_both, temp_set_point)
3242 (copy_intervals_to_string): No longer inline.
3243 * xdisp.c (window_text_bottom_y, window_box_width)
3244 (window_box_height, window_box_left_offset)
3245 (window_box_right_offset, window_box_left, window_box_right)
3246 (window_box): No longer inline.
3248 2011-11-08 Chong Yidong <cyd@gnu.org>
3250 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3251 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3252 Signal an error if not a live window.
3253 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3254 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3256 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3258 * lisp.h (syms_of_abbrev): Remove declaration.
3259 Reported by CHENG Gao <chenggao@royau.me>.
3261 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3263 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3264 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3265 of temacs in GUI mode.
3267 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3269 * window.h: Declare delete_all_child_windows instead of
3270 delete_all_subwindows.
3271 * window.c (Fwindow_nest, Fset_window_nest)
3272 (Fset_window_new_total, Fset_window_new_normal)
3273 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3274 (delete_all_subwindows): Rename to delete_all_child_windows.
3275 (Fdelete_other_windows_internal, Fset_window_configuration):
3276 Call delete_all_child_windows instead of delete_all_subwindows.
3277 * frame.c (delete_frame): Call delete_all_child_windows instead
3278 of delete_all_subwindows.
3280 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3282 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3283 This is also needed for porting to any host where GC_MARK_STACK is
3284 not GC_MAKE_GCPROS_NOOPS.
3285 (which_symbols): Use it.
3287 2011-11-07 Kenichi Handa <handa@m17n.org>
3289 * coding.c (coding_set_destination): Check coding->src_pos only
3290 when coding->src_object is a buffer (bug#9910).
3292 * process.c (send_process): Set the member src_multibyte of coding
3293 to 0 (bug#9911) when sending a unibyte text.
3295 * callproc.c (Fcall_process): Set the member src_multibyte of
3296 process_coding to 0 (bug#9912).
3298 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3300 * xmenu.c (cleanup_widget_value_tree): New function.
3301 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3302 calling free_menubar_widget_value_tree directly (Bug#9830).
3304 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3306 Fix some portability problems with 'inline'.
3307 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3308 (window_box_width, window_box_left, window_box_left_offset)
3309 (window_box_right, window_box_right_offset): Declare extern.
3310 Otherwise, these inline functions do not conform to C99 and
3311 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3312 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3313 * intervals.c (adjust_intervals_for_insertion)
3314 (adjust_intervals_for_deletion): Now extern, because otherwise the
3315 extern inline functions 'offset_intervals' couldn't refer to it.
3316 (static_offset_intervals): Remove.
3317 (offset_intervals): Rewrite using the old contents of
3318 static_offset_intervals. The old version didn't conform to C99
3319 because an extern inline function contained a reference to an
3320 identifier with static linkage.
3322 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3324 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3327 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3329 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3330 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3331 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3332 return Qleft_to_right.
3334 2011-11-06 Chong Yidong <cyd@gnu.org>
3336 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3337 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3338 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3339 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3340 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3341 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3342 (Fwindow_vscroll): Doc fix.
3343 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3344 argument, since it makes no sense to pass a live window and for
3345 consistency with window-child.
3347 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3349 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3352 2011-11-05 Jason Rumney <jasonr@gnu.org>
3354 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3355 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3357 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3358 bitwise arithmetic preventing use of unicode-sip and non-truetype
3361 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3363 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3366 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3367 initialization code to keep similarity to xfns.c after changes
3370 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3372 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3373 (unwind_create_frame): New function (Bug#9943).
3374 (Fx_create_frame): Restructure code to be more similar to the one in
3375 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3376 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3377 Move terminal->reference_count++ just before making the frame official
3380 * nsterm.m (x_free_frame_resources): New function.
3381 (x_destroy_window): Move code to x_free_frame_resources.
3383 * xfns.c (unwind_create_frame): Fix comment.
3384 (Fx_create_frame, x_create_tip_frame):
3385 Move terminal->reference_count++ just before making the frame
3386 official. Move initialization of image_cache_refcount and
3387 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3389 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3391 Support MSVC build with newer versions of Visual Studio.
3392 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3393 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3396 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3397 which are not supported by MSVC.
3398 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3399 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3401 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3403 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3405 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3407 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3409 Support MSVC build with newer versions of Visual Studio.
3410 * w32.c: Don't include w32api.h for MSVC.
3411 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3413 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3414 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3415 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3416 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3418 (alloca) [_MSC_VER]: Define to _alloca.
3420 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3422 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3424 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3426 * xdisp.c (note_mouse_highlight): If either of
3427 previous/next-single-property-change returns nil, treat that as
3428 the beginning or the end of the buffer. (Bug#9955)
3430 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3432 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3433 label is not null (Bug#9951).
3434 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3437 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3439 * window.c (Fwindow_body_size): Mention in the doc string that the
3440 return value is in frame's canonical units. (Bug#9949)
3442 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3444 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3446 * w32fns.c (unwind_create_frame): If needed, free the glyph
3447 matrices of the partially constructed frame. (Bug#9943)
3448 * xfns.c (unwind_create_frame): Likewise.
3450 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3452 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3453 Don't stop backward scan on the continuation glyph, even though
3454 its CHARPOS is positive.
3455 (mouse_face_from_buffer_pos, note_mouse_highlight):
3456 Rename cover_string to disp_string.
3458 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3460 * window.c (temp_output_buffer_show): Don't use
3461 Vtemp_buffer_show_specifiers.
3462 (Vtemp_buffer_show_specifiers): Remove unused variable.
3464 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3466 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3467 past the beginning of the current glyph matrix.
3469 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3471 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3472 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3473 HAVE_GTK3 (Bug#9869).
3475 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3476 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3478 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3480 * xterm.c: Declare x_handle_net_wm_state to return int.
3481 (handle_one_xevent): Check if we are iconified but don't have
3482 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3483 (get_current_wm_state): Return non-zero if not hidden,
3484 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3485 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3486 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3487 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3489 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3491 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3492 so that this new function doesn't get optimized away by a
3493 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3495 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3497 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3499 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3501 Fix the `xbytecode' command.
3502 * .gdbinit (xprintbytestr): New command.
3503 (xwhichsymbols): Rename from `which'; all callers changed.
3504 (xbytecode): Print the byte-code string as well.
3506 2011-10-29 Kim Storm <storm@cua.dk>
3508 * alloc.c (which_symbols): New function.
3510 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3512 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3515 2011-10-29 Glenn Morris <rgm@gnu.org>
3517 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3518 Not clear what it was for, and it causes various bugs. (Bug#9839)
3520 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3522 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3523 possible random value that matches one of those tested as
3524 condition to clear the mouse face.
3526 2011-10-28 Chong Yidong <cyd@gnu.org>
3528 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3530 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3532 * window.c (make_window): Initialize phys_cursor_on_p.
3534 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3536 * lisp.h (struct Lisp_Symbol): Update comments.
3538 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3540 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3542 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3544 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3545 <oslsachem@gmail.com> for helping to debug this.
3547 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3548 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3549 (g_b_init_get_glyph_outline_w): New static variables.
3550 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3551 (GetGlyphOutlineW_Proc): New typedefs.
3552 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3553 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3555 (w32font_open_internal, compute_metrics):
3556 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3557 instead of calling the "wide" APIs directly.
3559 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3561 * w32.h (syms_of_w32font): Add prototype.
3563 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3565 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3566 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3567 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3568 (Fmove_to_window_line): Doc fix.
3570 2011-10-27 Chong Yidong <cyd@gnu.org>
3572 * process.c (make_process): Set gnutls_state to NULL.
3574 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3575 non-NULL, regardless of GNUTLS_INITSTAGE.
3576 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3577 an error. Set process slots as soon as we allocate them.
3579 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3581 2011-10-27 Chong Yidong <cyd@gnu.org>
3583 * gnutls.c (emacs_gnutls_deinit): New function.
3584 Deallocate credentials structures as well as calling gnutls_deinit.
3585 (Fgnutls_deinit, Fgnutls_boot): Use it.
3587 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3588 (deactivate_process): Call emacs_gnutls_deinit.
3590 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3592 * image.c (x_create_x_image_and_pixmap):
3593 * w32.c (sys_rename, w32_delayed_load):
3594 * w32font.c (fill_in_logfont):
3595 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3597 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3599 * w32fns.c (w32_default_color_map): New function,
3600 extracted from Fw32_default_color_map.
3601 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3603 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3605 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3607 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3609 * keyboard.c (test_undefined): New function (bug#9751).
3610 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3612 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3614 * sysdep.c (init_sys_modes): Fix the check for the controlling
3615 terminal (Bug#6649).
3617 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3619 * dispextern.h (struct bidi_it): New member next_en_type.
3621 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3622 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3623 current character, check also for next_en_type being WEAK_EN.
3624 (bidi_resolve_weak): Don't enter the expensive loop if the current
3625 position is before next_en_pos. Record the bidi type of the first
3626 non-ET, non-BN character we find, in addition to its position.
3627 (bidi_level_of_next_char): Invalidate next_en_type when
3628 next_en_pos is over-stepped.
3630 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3632 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3633 * editfns.c: Rewrite current-time-zone so that it invokes
3634 the equivalent of (format-time-string "%Z") to get the time zone name.
3635 This fixes a bug when the time zone name contains characters that
3636 need converting from the system time locale to Emacs internal format.
3637 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3638 that patch fixed format-time-string to do the conversion, but
3639 I forgot to fix current-time-zone.
3640 (format_time_string): New function, containing most of
3641 what Fformat_time_string used to contain.
3642 (Fformat_time_string): Rewrite in terms of format_time_string.
3643 This doesn't change this function's behavior.
3644 (current-time-zone): Rewrite to use format_time_string.
3645 This fixes the bug reported by Michael Schierl in
3646 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3647 Jason Rumney's 2007-06-07 change worked around this bug, but
3649 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3651 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3653 * xdisp.c (start_display): If the character at POS is displayed
3654 via a display vector, reset IT->current.dpvec_index to zero.
3655 (try_window_reusing_current_matrix): If a line ends in a display
3656 vector or the next line starts in a display vector, continue
3657 redrawing the window even though the character position of
3658 start_row was reached.
3661 2011-10-18 Chong Yidong <cyd@gnu.org>
3663 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3664 with nobreak-char-display too.
3666 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3668 Fix part 3 of bug#9771.
3669 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3670 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3671 non-neutral characters if the current character is a paragraph
3672 separator (a.k.a. Newline). This avoids running the same
3673 expensive loop twice, once when we consume the preceding newline
3674 and the other time when the line actually needs to be displayed.
3675 Avoid the loop when we see neutrals on the base embedding level
3676 following a character whose directionality is the same as the
3677 paragraph's. This avoids running the expensive loop when a line
3678 ends in a long sequence of neutrals, like control characters.
3679 Add assertion against STRONG_AL type. Slightly rearrange code
3680 that determines the type of a neutral given the first non-neutral
3682 (bidi_level_of_next_char): Set next_en_pos to zero when
3683 invalidating its info.
3685 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3687 * xdisp.c (push_display_prop): Determine whether to record string
3688 or buffer position by IT->string, not by IT->method. Allow
3689 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3690 (move_it_vertically_backward): Don't look for character position
3691 immediately after the newline when in a continuation line.
3694 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3696 * window.c (coordinates_in_window): Rewrite and delabelize
3697 vertical border check. (Bug#5357) (Bug#9618)
3699 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3701 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3702 errors in XSetWindowBorder (bug#9310).
3704 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3706 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3707 avoid crash when xmalloc overrun checking is enabled.
3709 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3711 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3712 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3713 cursor motion with <left> and <right> arrow keys.
3715 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3716 some callers set that themselves.
3718 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3720 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3721 display string and the previous row comes from the same string and
3722 is empty. (Bug#9739) (Bug#9738)
3724 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3726 * doc.c (get_doc_string): Encode file name (bug#9735).
3728 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3730 * bidi.c (bidi_level_of_next_char):
3731 * xdisp.c (get_visually_first_element): Remove old incorrect
3732 comments regarding the Unicode Line Separator character.
3734 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3736 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3738 * alloc.c (Fgc_status): Do not access beyond zombies array
3739 boundary if nzombies > MAX_ZOMBIES.
3740 * alloc.c (dump_zombies): Add missing format specifier.
3742 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3744 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3745 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3747 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3748 Some packages use them to denote characters with modifiers.
3750 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3752 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3753 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3754 matching a pp-number. Rename parameter var to var1.
3756 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3758 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3760 2011-10-08 Glenn Morris <rgm@gnu.org>
3762 * callint.c (Fcall_interactively): Give a more explicit error for the
3763 'c' case with a non-character input. (Bug#8479)
3765 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3767 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3769 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3770 lines that are hscrolled on the left.
3772 * dispnew.c (buffer_posn_from_coords): Account for a possible
3773 presence of header-line. (Bug#4426)
3775 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3777 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3778 Don't advertise functionality which we discourage or doesn't work.
3780 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3782 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3783 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3784 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3785 this makes Emacs dump core during garbage collection on rare
3786 occasions. sizeof is obviously inferior to offsetof here, so
3787 stick with offsetof.
3788 (GC_POINTER_ALIGNMENT): New macro.
3789 (mark_memory): Omit 3rd (offset) arg; caller changed.
3790 Don't assume EMACS_INT alignment is the same as pointer alignment.
3792 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3794 * keyboard.c (read_key_sequence_remapped): New var.
3795 (read_key_sequence): Compute remapping in the right buffer.
3796 (command_loop_1): Use read_key_sequence's remapping directly.
3798 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3800 * dired.c (file_name_completion): Don't expand file name.
3801 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3802 before checking file name handler.
3804 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3805 they've been requested explicitly (bug#9591).
3807 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3809 * keymap.c (Fsingle_key_description): Use make_specified_string
3810 instead of build_string to build string from push_key_description.
3813 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3815 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3816 This fixes a Y2038 bug on 64-bit hosts.
3817 * buffer.c (reset_buffer):
3818 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3819 (Fclear_buffer_auto_save_failure):
3820 Use 0, not -1, to represent an unset failure time, since time_t
3821 might not be signed.
3823 Remove dependency on glibc malloc internals.
3824 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3825 Move back here from lisp.h, but with their new implementations.
3826 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3827 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3828 * charset.c (charset_table_init): New static var.
3829 (syms_of_charset): Use it instead of xmalloc. This removes a
3830 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3831 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3832 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3833 Move back to alloc.c.
3834 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3835 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3837 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3839 * nsterm.m (windowDidResize): Call x_set_window_size only when
3840 ns_in_resize is true. Otherwise set pixelwidth/height and
3841 call change_frame_size (Bug#9628).
3843 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3845 Port --enable-checking=all to Fedora 14 x86-64.
3846 * charset.c (syms_of_charset): Also account for glibc malloc's
3847 internal overhead when calculating the initial malloc maximum.
3849 Port --enable-checking=all to Fedora 14 x86.
3850 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3852 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3853 (overrun_check_realloc, overrun_check_free):
3854 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3855 That way, xmalloc returns a properly-aligned pointer even if
3856 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3857 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3858 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3859 into account when calculating the initial malloc maximum.
3860 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3861 Move here from alloc.c, so that charset.c can use it too.
3862 Properly align; the old code wasn't right for common 32-bit hosts
3863 when configured with --enable-checking=all.
3864 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3865 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3867 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3869 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3872 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3874 * xdisp.c (compute_display_string_end): If there's no display
3875 string at CHARPOS, return -1.
3877 * bidi.c (bidi_fetch_char): When compute_display_string_end
3878 returns a negative value, treat the character as a normal
3879 character not covered by a display string. (Bug#9624)
3881 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3883 * lread.c (Fread_from_string): Fix typo in docstring.
3885 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3887 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3888 newline, reseat the iterator instead of bidi-iterating there one
3889 character at a time. (Bug#9610)
3890 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3891 TO_CHARPOS if the bidi iterator is at base embedding level.
3893 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3895 * lread.c (readevalloop): Use correct code for NBSP.
3896 (read1): Likewise. (Bug#9608)
3898 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3900 * dbusbind.c (Fdbus_register_signal): When service is not
3901 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3903 2011-09-25 Glenn Morris <rgm@gnu.org>
3905 * buffer.c (truncate-lines): Doc fix.
3907 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3909 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3910 (Fset_window_next_buffers): Doc fix.
3912 2011-09-24 Glenn Morris <rgm@gnu.org>
3914 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3916 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3918 Fix minor problems found by static checking.
3919 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3920 * indent.c (Fvertical_motion): Fix == vs = typo.
3922 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3924 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3925 Default value is now t. Doc fix.
3927 * indent.c (Fvertical_motion): Compute and apply the overshoot
3928 logic when moving up, not only when moving down. Fix the
3929 confusing name and values of the it_overshoot_expected variable;
3930 logic changes accordingly. (Bug#9254) (Bug#9549)
3932 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3933 CHARPOS is covered by a display string which includes newlines.
3934 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3935 is covered by a display string with embedded newlines.
3937 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3939 * dbusbind.c (Fdbus_register_signal): Add match rule to
3940 Vdbus_registered_objects_table. (Bug#9581)
3941 (Fdbus_register_method, Vdbus_registered_objects_table):
3944 2011-09-24 Jim Meyering <meyering@redhat.com>
3946 do not ignore write error for any output size
3947 The previous change was incomplete.
3948 While it makes emacs --batch detect the vast majority of stdout
3949 write failures, errors were still ignored whenever the output size is
3950 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3951 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3952 && echo FAIL: ignored write error
3953 FAIL: ignored write error
3954 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3955 && echo FAIL: ignored write error
3956 FAIL: ignored write error
3957 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3959 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3961 * emacs.c (Fkill_emacs): In noninteractive mode exit
3962 non-successfully if a write error occurred on stdout. (Bug#9574)
3964 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3966 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3969 * dispextern.h (struct it): Update the comment documenting what
3972 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3974 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3975 a display string, extend search for cursor position to end of row.
3976 (find_row_edges): If the row ends in a newline from a display
3977 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3978 Handle the case of a display string with multiple newlines.
3979 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3980 non-empty line. Fixes confusing cursor motion with arrow keys at
3981 the beginning of a line that starts with whitespace.
3983 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3985 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3988 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3990 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3993 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3995 * xdisp.c (display_line): Record maximum and minimum buffer
3996 positions even if no glyphs were produced (e.g., by a zero-width
3997 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3998 buffer positions that will be removed from the glyph row because
4000 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4001 column is beyond frame width: don't subtract 1 "pixel" when
4002 computing width of the stretch.
4003 (reseat_at_next_visible_line_start): Undo the change made on
4004 2011-09-17 that saved paragraph information and restored it after
4005 the call to `reseat'. (Bug#9545)
4007 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4009 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4010 and turn window cursor on if cleared (Bug#9415).
4012 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4014 * search.c (boyer_moore): Take unibyte characters from pattern
4015 literally. (Bug#9458)
4017 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4019 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4021 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4023 Fix minor problem found by static checking.
4024 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4025 initialized, to pacify gcc -Wuninitialized.
4027 * fileio.c: Report proper errno when syscall falls.
4028 (Finsert_file_contents): Save and restore errno,
4029 so that report_file_error outputs the correct diagnostic.
4030 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4032 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4034 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4036 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4038 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4039 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4041 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4043 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4044 about the current paragraph and restore it after the call to reseat.
4046 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4047 (bidi_find_paragraph_start): Search back for paragraph beginning
4048 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4049 (bidi_move_to_visually_next): Only trigger paragraph-related
4050 computations when the last character is a newline or at EOB, not
4051 just any NEUTRAL_B. (Bug#9470)
4053 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4054 truncated lines if point is covered by a display string. (Bug#9524)
4056 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4058 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4059 (cons_to_x_long): New function.
4060 (lisp_data_to_selection_data): Use it. Correct the test for
4061 short-versus-long data; it was negated. Break out of vector
4062 loop, for efficiency, when a long datum is discovered.
4064 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4066 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4068 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4070 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4071 GCC PR/17406) by declaring this function with external scope.
4073 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4075 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4076 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4078 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4080 * editfns.c (Fformat): Correctly handle text properties on "%%".
4082 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4084 * xterm.c (x_draw_composite_glyph_string_foreground):
4085 * w32term.c (x_draw_composite_glyph_string_foreground):
4086 * term.c (encode_terminal_code):
4087 * composite.c (composition_update_it, get_composition_id):
4088 * xdisp.c (get_next_display_element)
4089 (fill_composite_glyph_string): Add comments about special meaning
4090 of TAB characters in a composition.
4092 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4094 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4095 This occurs when processing a multibyte format.
4096 Problem reported by Wolfgang Jenker.
4098 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4100 * xdisp.c (try_cursor_movement): Only check for exact match if
4101 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4103 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4105 Remove unused external symbols.
4106 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4107 * xdisp.c (calc_pixel_width_or_height): Now static.
4108 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4109 * indent.c (check_display_width):
4110 * w32term.c: Fix comment to match code.
4111 * xterm.c, xterm.h (x_catching_errors): Remove.
4113 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4115 * xselect.c: Use signed conversions more consistently (Bug#9498).
4116 (selection_data_to_lisp_data): Assume incoming selection data are
4117 signed integers, not unsigned. This is to be consistent with
4118 outgoing selection data, which was modified to use signed integers
4119 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4120 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4121 expects long, not unsigned long.
4123 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4125 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4126 computation of loop end. Reported by Johan Bockgård
4129 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4131 * frame.c (Fother_visible_frames_p): Function deleted.
4133 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4135 * indent.c (compute_motion): Process display vector front to back
4136 rather than the other way around. (Bug#2496)
4138 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4140 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4142 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4144 * minibuf.c (Fread_from_minibuffer): Doc fix.
4146 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4148 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4149 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4151 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4153 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4154 value for non-existent files.
4156 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4158 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4159 set its "size" to -1. This will set the modtime_size field of
4160 the corresponding buffer to -1, which is what
4161 verify-visited-file-modtime expects for files that do not exist.
4164 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4166 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4168 * lisp.h: ... from here. push_key_description is no longer
4169 defined in keyboard.c, so its declaration should not be in
4170 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4171 logically belongs with push_key_description.
4173 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4175 * buffer.h: Include <sys/types.h> instead of <time.h>.
4176 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4177 Problem reported by Herbert J. Skuhra.
4179 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4181 * xml.c (parse_region): Make the parsing work for
4182 non-comment-starting XML files again (bug#9144).
4184 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4186 * image.c (gif_load): Fix calculation of bottom and right corner.
4189 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4191 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4192 redisplay in small windows.
4194 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4196 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4198 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4200 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4201 Operate on live windows only.
4203 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4205 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4207 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4209 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4210 only under bidi iteration.
4212 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4214 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4216 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4218 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4219 Without this fix, the command to link temacs failed due to an
4220 undefined symbol __builtin_isnan. This is because
4221 /usr/include/iso/math_c99.h #defines isnan(x) to
4222 __builtin_isnan(x), but the bundled gcc, which identifies itself
4223 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4225 * floatfns.c (isnan): #undef, and then #define to a clone of
4227 (Fisnan): Always define, since it's always available now.
4228 (syms_of_floatfns): Always define isnan at the Lisp level.
4230 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4232 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4234 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4236 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4237 The previous code assumed that file offsets (off_t values) fit in
4238 EMACS_INT variables, which is not true on typical 32-bit hosts.
4239 The code messed up by falsely reporting buffer overflow in cases
4240 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4241 when "big" contains more than 2**29 bytes, even though this
4242 inserts just one byte and does not overflow the buffer.
4243 (Finsert_file_contents): Store file offsets as off_t
4244 values, not as EMACS_INT values. Check for overflow when
4245 converting between EMACS_INT and off_t. When checking for
4246 buffer overflow or for overlap, take the offsets into account.
4247 Don't use EMACS_INT for small values where int suffices.
4248 When checking for overlap, fix a typo: ZV was used where
4249 ZV_BYTE was intended.
4250 (Fwrite_region): Don't assume off_t fits into 'long'.
4251 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4253 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4255 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4257 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4259 sprintf-related integer and memory overflow issues (Bug#9412).
4261 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4262 (esprintf, exprintf, evxprintf): New functions.
4263 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4264 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4265 (modify_event_symbol): Do not assume that the length of
4266 name_alist_or_stem is safe to alloca and fits in int.
4267 (Fexecute_extended_command): Likewise for function name and binding.
4268 (Frecursion_depth): Wrap around reliably on integer overflow.
4269 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4270 since some callers pass EMACS_INT values.
4271 (Fsingle_key_description): Don't crash if symbol name contains more
4272 than MAX_ALLOCA bytes.
4273 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4274 (get_minibuffer): Arg is now EMACS_INT, not int.
4275 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4276 (esprintf, exprintf, evxprintf): New decls.
4277 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4279 * dbusbind.c (signature_cat): New function.
4280 (xd_signature, Fdbus_register_signal):
4281 Do not overrun buffer; instead, report string overflow.
4283 * dispnew.c (add_window_display_history): Don't overrun buffer.
4284 Truncate instead; this is OK since it's just a log.
4286 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4287 even if the time zone offset is outlandishly large.
4288 Don't mishandle offset == INT_MIN.
4290 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4291 when creating daemon; the previous buffer-overflow check was incorrect.
4293 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4294 which has the guts of the old verror function.
4296 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4297 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4299 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4300 (font_unparse_xlfd): Don't blindly alloca long strings.
4301 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4302 fits in int, when using sprintf. Use single snprintf to count
4303 length of string rather than counting it via multiple sprintfs;
4304 that's simpler and more reliable.
4305 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4306 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4307 sprintf, in case result does not fit in int.
4309 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4310 (fontset_from_font): Print it.
4312 * frame.c (tty_frame_count): Now printmax_t, not int.
4313 (make_terminal_frame, set_term_frame_name): Print it.
4314 (x_report_frame_params): In X, window IDs are unsigned long,
4315 not signed long, so print them as unsigned.
4316 (validate_x_resource_name): Check for implausibly long names,
4317 and don't assume name length fits in 'int'.
4318 (x_get_resource_string): Don't blindly alloca invocation name;
4319 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4322 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4323 (xg_check_special_colors, xg_set_geometry):
4324 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4326 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4327 Use esprintf, not sprintf, in case result does not fit in int.
4329 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4330 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4331 it as a large positive number.
4332 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4333 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4335 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4336 in case result does not fit in int.
4338 * print.c (float_to_string): Detect width overflow more reliably.
4339 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4340 buffer overrun. Don't assume list length fits in 'int'. Treat
4341 print length of 0 as 0, not as infinity; to be consistent with other
4342 uses of print length in this function. Don't overflow print length
4343 index. Don't assume hash table size fits in 'long', or that
4344 vectorlike size fits in 'unsigned long'.
4346 * process.c (make_process): Use printmax_t, not int, to format
4347 process-name gensyms.
4349 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4351 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4352 to avoid potential buffer overrun.
4354 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4355 if X resource line is longer than 512 bytes.
4357 * xfns.c (x_window): Make sprintf buffer a bit bigger
4358 to avoid potential buffer overrun.
4360 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4362 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4364 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4366 Integer overflow fixes for scrolling, etc.
4367 Without these, Emacs silently mishandles large integers sometimes.
4368 For example, "C-u 4294967297 M-x recenter" was treated as if
4369 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4371 * xdisp.c (try_window_id): Check Emacs fixnum range before
4372 converting to 'int'.
4374 * window.c (window_scroll_line_based, Frecenter):
4375 Check that an Emacs fixnum is in range before assigning it to 'int'.
4376 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4377 values converted from Emacs fixnums.
4378 (Frecenter): Don't wrap around a line count if it is out of 'int'
4379 range; instead, treat it as an extreme value.
4380 (Fset_window_configuration, compare_window_configurations):
4381 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4383 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4384 that can exceed INT_MAX. Check that EMACS_INT value is in range
4385 before assigning it to the (possibly-narrower) index.
4386 (match_limit): Don't assume that a fixnum can fit in 'int'.
4388 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4391 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4392 (Fvertical_motion): Don't wrap around LINES values that don't fit
4393 in 'int'. Instead, treat them as extreme values. This is good
4394 enough for windows, which can't have more than INT_MAX lines anyway.
4396 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4398 * Require libxml/parser.h to avoid compilation warning.
4400 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4402 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4403 since this reportedly can destroy thread storage.
4405 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4407 * syntax.c (find_defun_start): Update all cache variables if
4408 exiting early (Bug#9401).
4410 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4412 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4414 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4415 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4416 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4418 * term.c (tty_append_glyph): New function.
4419 (produce_stretch_glyph): Static function and its prototype deleted.
4421 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4424 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4426 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4427 when checking :margin (Bug#9390).
4428 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4429 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4430 so that the name doesn't mislead. All uses changed.
4432 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4434 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4437 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4439 * xdisp.c (move_it_to): Don't bail out early when reaching
4440 position beyond to_charpos, if we are scanning backwards.
4441 (move_it_vertically_backward): When DY == 0, make sure we get to
4442 the first character in the line after the newline.
4444 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4446 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4447 (ccl_driver): Do not generate an out-of-range pointer.
4448 (Fccl_execute_on_string): Remove unnecessary check for
4449 integer overflow, noted by Stefan Monnier in
4450 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4451 Remove a FIXME that didn't need fixing.
4452 Simplify the newly-introduced buffer reallocation code.
4454 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4456 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4458 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4460 Integer and memory overflow issues (Bug#9196).
4462 * doc.c (get_doc_string): Rework so that
4463 get_doc_string_buffer_size is the actual buffer size, rather than
4464 being 1 less than the actual buffer size; this makes xpalloc more
4467 * image.c (x_allocate_bitmap_record, cache_image):
4468 * xselect.c (Fx_register_dnd_atom):
4469 Simplify previous changes by using xpalloc.
4471 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4472 since either will do and ptrdiff_t is convenient with xpalloc.
4474 * charset.c (charset_table_size)
4475 (struct charset_sort_data.priority): Now ptrdiff_t.
4476 (charset_compare): Don't overflow if priorities differ greatly.
4477 (Fsort_charsets): Don't assume list length fits in int.
4478 Check for size-calculation overflow when allocating sort data.
4479 (syms_of_charset): Allocate an initial charset table that is
4480 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4482 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4484 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4485 The actual value is always <= INT_MAX, and leaving it unsigned made
4486 overflow checking harder.
4488 * dispextern.h (struct glyph_matrix.rows_allocated)
4489 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4490 with xpalloc. The values are still always <= INT_MAX.
4492 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4494 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4495 (SAFE_NALLOCA): New macro.
4497 * region-cache.c (struct boundary.pos, find_cache_boundary)
4498 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4499 (set_cache_region, invalidate_region_cache)
4500 (revalidate_region_cache, know_region_cache, region_cache_forward)
4501 (region_cache_backward, pp_cache):
4502 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4503 so that ptrdiff_t * can be passed to xpalloc.
4504 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4505 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4506 (pp_cache): Don't assume cache_len fits in int.
4507 * region-cache.h: Adjust extern decls to match.
4509 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4510 EMACS_INT, since either will do, for xpalloc.
4512 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4513 (xnmalloc, xnrealloc, xpalloc): New functions.
4515 * bidi.c (bidi_shelve_header_size): New constant.
4516 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4517 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4519 * bidi.c (bidi_cache_shrink):
4520 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4522 Don't update size of array until after memory allocation succeeds,
4523 because xmalloc/xrealloc may not return.
4524 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4525 now that we have proper integer overflow checking.
4526 (record_overlay_string, overlay_strings): Catch overflows when
4527 calculating size of overlay_str_buf.
4529 * callproc.c (Fcall_process): Check for size overflow when
4530 calculating size of args2.
4531 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4532 Normally we prefer signed values, but sticking with ptrdiff_t would
4533 require adding more-complicated checks.
4535 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4536 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4537 Redo buffer-overflow calculations to avoid integer overflow.
4538 Add a FIXME comment where memory seems to be over-allocated.
4540 * character.c (Fstring): Check for size-calculation overflow.
4542 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4543 unnecessary integer overflow. Check for size overflow.
4544 (encode_coding_object): Don't update size until xmalloc succeeds.
4546 * composite.c (get_composition_id): Check for overflow in glyph
4547 length calculations.
4549 Integer and memory overflow fixes for display code.
4550 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4551 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4552 (scrolling_window): Check for overflow in size calculations.
4553 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4554 Don't assume glyph table len fits in int.
4555 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4556 (row_table_size): Now ptrdiff_t, not int.
4557 (scrolling_window): Avoid overflow in size calculations.
4558 Don't update size until allocation succeeds.
4559 * fns.c (concat): Check for overflow in size calculations.
4560 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4561 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4562 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4564 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4565 (get_doc_string): Check for size calculation overflow.
4566 Don't update size until allocation succeeds.
4567 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4568 EMACS_INT, where ptrdiff_t will do.
4569 (Fsubstitute_command_keys): Check for string overflow.
4571 * editfns.c (set_time_zone_rule): Don't assume environment length
4573 (message_length): Now ptrdiff_t, not int.
4574 (Fmessage_box): Don't update size until allocation succeeds.
4575 Don't assume message length fits in int.
4576 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4578 * emacs.c (main): Do not reallocate argv, since there is a null at
4579 the end that can be overwritten, and this way there's no need to
4580 worry about size-calculation overflow.
4581 (sort_args): Check for size-calculation overflow.
4583 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4585 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4587 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4588 (x_set_scroll_bar_width, x_figure_window_size):
4589 Check for integer overflow.
4590 (x_set_alpha): Do not assume XINT fits in int.
4592 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4593 This is for the members text_lines, text_cols, total_lines, total_cols,
4594 where the system imposes an 'int' limit.
4596 * fringe.c (Fdefine_fringe_bitmap):
4597 Don't update size until alloc works.
4599 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4600 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4602 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4603 Check for size-calculation overflow.
4604 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4605 do, as we prefer signed integers.
4606 (id_to_widget.max_size, id_to_widget.used)
4607 (xg_store_widget_in_map, xg_remove_widget_from_map)
4608 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4609 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4610 Use and return ptrdiff_t, not int.
4611 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4612 * gtkutil.h: Change prototypes to match the above.
4614 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4615 are duplicate now that they've been promoted to lisp.h.
4616 (x_allocate_bitmap_record, x_alloc_image_color)
4617 (make_image_cache, cache_image, xpm_load):
4618 Don't update size until alloc is done.
4619 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4621 Check for size calculation overflow.
4622 (ct_colors_allocated_max): New constant.
4623 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4626 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4627 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4628 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4629 Use ptrdiff_t, not int, to count maps.
4630 (read_char_minibuf_menu_prompt): Check for overflow in size
4631 calculations. Don't update size until allocation succeeds.
4632 Redo calculations to avoid overflow.
4633 * keyboard.h: Change prototypes to match the above.
4635 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4637 (current_minor_maps): Check for size calculation overflow.
4638 * keymap.h: Change prototypes to match the above.
4640 * lread.c (read1, init_obarray): Don't update size until alloc done.
4642 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4643 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4645 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4646 Now ptrdiff_t, not int.
4647 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4648 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4650 * process.c (Fnetwork_interface_list): Check for overflow
4651 in size calculation.
4653 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4655 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4656 overflow. Don't bother calling xmalloc when xrealloc will do.
4658 * search.c (Freplace_match): Check for size calculation overflow.
4659 (Fset_match_data): Don't assume list lengths fit in 'int'.
4661 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4662 for command line length. Do not attempt to address one before the
4663 beginning of an array, as that's not portable.
4665 * term.c (max_frame_lines): Remove; unused.
4666 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4668 (encode_terminal_code, calculate_costs): Check for size
4669 calculation overflow.
4670 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4671 table lengths and related sizes. Don't update size until alloc
4672 done. Redo calculations to avoid overflow.
4673 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4675 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4676 subtracting pointers.
4677 (gobble_line): Check for overflow more carefully. Don't update size
4680 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4681 Don't update size until alloc done.
4682 Redo size calculations to avoid overflow.
4683 Check for size calculation overflow.
4684 (main) [DEBUG]: Fix typo in invoking tparam1.
4686 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4687 Use ptrdiff_t, not int, for sizes.
4688 (store_mode_line_noprop_char): Don't update size until alloc done.
4690 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4691 Use ptrdiff_t, not int, for sizes.
4692 (Finternal_make_lisp_face, cache_face):
4693 Check for size calculation overflow.
4694 (cache_face): Treat size calculation overflows as if they were
4695 memory exhaustion (the usual treatment), rather than aborting.
4697 * xfns.c (x_encode_text, x_set_name_internal)
4698 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4699 sizes, since they can exceed INT_MAX in size. Check for size
4700 calculation overflow.
4702 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4703 (xg_select): Check for size calculation overflow.
4704 Don't update size until alloc done.
4706 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4707 as sprintf is limited to int lengths.
4709 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4710 (X_LONG_MIN): New macros.
4711 Use them to make the following changes clearer.
4712 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4713 This change doesn't affect the value now, but it may help remind
4714 future maintainers not to raise the value too much later.
4715 (SELECTION_QUANTUM): Remove, replacing with ...
4716 (selection_quantum): ... new function, which avoids overflow.
4718 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4719 assumption that selection length fits in 'int'.
4720 (x_reply_selection_request, x_handle_selection_request)
4721 (x_get_window_property, receive_incremental_selection)
4722 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4723 (lisp_data_to_selection_data, clean_local_selection_data):
4724 Use ptrdiff_t, not int, to record length of selection.
4725 (x_reply_selection_request, x_get_window_property)
4726 (receive_incremental_selection, x_property_data_to_lisp):
4727 Redo calculations to avoid overflow.
4728 (x_reply_selection_request): When sending hint, ceiling it at
4729 X_LONG_MAX rather than relying on wraparound overflow to send
4731 (x_get_window_property, receive_incremental_selection)
4732 (lisp_data_to_selection_data, x_property_data_to_lisp):
4733 Check for size-calculation overflow.
4734 (x_get_window_property, receive_incremental_selection)
4735 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4736 Don't store size until memory allocation succeeds.
4737 (x_get_window_property): Plug memory leak on memory exhaustion.
4738 Don't double-block input; malloc is safe here. Don't assume 2**34
4739 - 4 fits in unsigned long. Add an xassert to check
4740 XGetWindowProperty overflow. Be more careful about overflow
4741 calculations, and distinguish size from memory overflow better.
4742 (receive_incremental_selection): When tracing, don't assume
4743 unsigned int is less than INT_MAX.
4744 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4745 harmful) conversions of unsigned short to int.
4746 (lisp_data_to_selection_data): Don't assume that integers
4747 in the range -65535 through -1 fit in an X unsigned short.
4748 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4749 result parameters unless successful. Rely on cons_to_unsigned
4750 to report problems with elements; the old code wasn't right anyway.
4751 (x_check_property_data): Check for int overflow; we cannot use
4752 a wider type due to X limits.
4753 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4755 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4757 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4758 (x_term_init): Check for size calculation overflow.
4759 (x_color_cells): Don't store size until memory allocation succeeds.
4760 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4761 Don't assume alloca size is less than MAX_ALLOCA.
4762 (x_term_init): Don't assume length fits in int (sprintf is limited
4765 Use ptrdiff_t for composition IDs.
4766 * character.c (lisp_string_width):
4767 * composite.c (composition_table_size, n_compositions)
4768 (get_composition_id, composition_gstring_from_id):
4769 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4770 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4771 * window.c (Frecenter):
4772 Use ptrdiff_t, not int, for composition IDs.
4773 * composite.c (get_composition_id): Check for integer overflow.
4774 * composite.h: Adjust prototypes to match the above changes.
4776 Use ptrdiff_t for hash table indexes.
4777 * category.c (hash_get_category_set):
4778 * ccl.c (ccl_driver):
4779 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4780 * coding.c (coding_system_charset_list, detect_coding_system):
4781 * coding.h (struct coding_system.id):
4782 * composite.c (get_composition_id, gstring_lookup_cache):
4783 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4784 * image.c (xpm_get_color_table_h):
4785 * lisp.h (hash_lookup, hash_put):
4786 * minibuf.c (Ftest_completion):
4787 Use ptrdiff_t for hash table indexes, not int (which is too
4788 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4789 32-bit --with-wide-int hosts).
4791 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4792 Add a FIXME comment about memory leaks.
4793 (syms_of_charset): Don't assume xmalloc returns.
4795 Don't assume that stated character widths fit in int.
4796 * character.c (Fchar_width, c_string_width, lisp_string_width):
4797 * character.h (CHAR_WIDTH):
4798 * indent.c (MULTIBYTE_BYTES_WIDTH):
4799 Use sanitize_char_width to avoid undefined and/or bad behavior
4800 with outlandish widths.
4801 * character.h (sanitize_tab_width): Rename from sanitize_width,
4802 now that we have two such functions. All uses changed.
4803 (sanitize_char_width): New inline function.
4805 Don't assume that tab-width fits in int.
4806 * character.h (sanitize_width): New inline function.
4807 (SANE_TAB_WIDTH): New macro.
4808 (ASCII_CHAR_WIDTH): Use it.
4809 * indent.c (sane_tab_width): Remove. All uses replaced by
4810 SANE_TAB_WIDTH (current_buffer).
4811 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4813 * fileio.c: Integer overflow issues with file modes.
4814 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4816 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4817 Remove unreachable code.
4818 (read_hex, load_charset_map_from_file): Check for integer overflow.
4820 * xterm.c: Don't go over XClientMessageEvent limit.
4821 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4822 (x_send_scroll_bar_event): Likewise. Check that the size does not
4823 exceed limits imposed by XClientMessageEvent, as well as the usual
4824 ptrdiff_t and size_t limits.
4826 * keyboard.c: Overflow, signedness and related fixes.
4827 (make_lispy_movement): Use same integer type in forward decl
4828 that is used in the definition.
4829 (read_key_sequence, keyremap_step):
4830 Change bufsize argument back to int, undoing my 2011-03-30 change.
4831 We prefer signed types, and int is wide enough here.
4832 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4833 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4834 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4835 length, not size_t. Use ptrdiff_t for index, not int.
4836 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4837 possibility of integer overflow.
4839 Overflow, signedness and related fixes for images.
4841 * dispextern.h (struct it.stack[0].u.image.image_id)
4842 (struct_it.image_id, struct image.id, struct image_cache.size)
4843 (struct image_cache.used, struct image_cache.ref_count):
4844 * gtkutil.c (update_frame_tool_bar):
4845 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4846 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4847 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4848 * nsmenu.m (update_frame_tool_bar):
4849 * xdisp.c (calc_pixel_width_or_height):
4850 * xfns.c (image_cache_refcount):
4851 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4852 on typical 64-bit hosts.
4854 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4855 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4856 Omit unnecessary casts to int.
4857 (parse_image_spec): Check that integers fall into 'int' range
4858 when the callers expect that.
4859 (image_ascent): Redo ascent calculation to avoid int overflow.
4860 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4861 (lookup_image): Remove unnecessary tests.
4862 (xbm_image_p): Locals are now of int, not EMACS_INT,
4863 since parse_image_check makes sure they fit into int.
4864 (png_load, gif_load, svg_load_image):
4865 Prefer int to unsigned where either will do.
4866 (tiff_handler): New function, combining the cores of the
4867 old tiff_error_handler and tiff_warning_handler.
4868 This function is rewritten to use vsnprintf and thereby avoid
4869 stack buffer overflows. It uses only the features of vsnprintf
4870 that are common to both POSIX and native Microsoft.
4871 (tiff_error_handler, tiff_warning_handler): Use it.
4872 (tiff_load, gif_load, imagemagick_load_image):
4873 Don't assume :index value fits in 'int'.
4874 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4875 (imagemagick_load_image): Check that crop parameters fit into
4876 the integer types that MagickCropImage accepts. Don't assume
4877 Vimagemagick_render_type has a nonnegative value. Don't assume
4878 size_t fits in 'long'.
4879 (gs_load): Use printmax_t to print the widest integers possible.
4880 Check for integer overflow when computing image height and width.
4882 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4884 * xdisp.c (redisplay_window): Don't force window start if point
4885 will be invisible in the resulting window. (Bug#9324)
4887 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4889 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4890 the display spec is of the form `(space ...)'.
4891 (handle_display_spec): Return the value returned by
4892 handle_single_display_spec, not just 1 or zero.
4893 (handle_single_display_spec): If the display spec is of the form
4894 `(space ...)', and specifies display in the text area, return 2
4896 (try_cursor_movement): Check for the need to scroll more
4897 accurately, and prefer exact match for point under bidi.
4898 Don't advance `row' beyond the last row of the window.
4900 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4901 into disp_prop; all users changed.
4903 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4904 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4905 for the text covered by the display property.
4907 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4909 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4910 Change return value to nil.
4911 (Frecord_buffer): Delete unused function.
4913 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4915 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4916 buffers, return left-to-right.
4917 (set_cursor_from_row): Consider candidate row a win if its glyph
4918 represents a newline and point is on that newline. Fixes cursor
4919 positioning on the newline at EOL of R2L text within L2R
4920 paragraph, and vice versa.
4921 (try_cursor_movement): Check continued rows, in addition to
4922 continuation rows. Fixes unwarranted scroll when point enters a
4923 continued line of R2L text within an L2R paragraph, or vice versa.
4924 (cursor_row_p): Consider the case of point being equal to
4925 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4926 from the end of a short line to the beginning of a continued line
4927 of R2L text within L2R paragraph.
4928 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4929 composed characters.
4931 * bidi.c (bidi_check_type): Use xassert.
4932 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4935 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4937 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4940 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4942 * nsfont.m (ns_otf_to_script): Fix typo.
4944 2011-08-22 Kenichi Handa <handa@m17n.org>
4946 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4947 extra slot even if the purpose is char-code-property-table.
4949 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4951 * xdisp.c (redisplay_window): When computing centering_position,
4952 account for the height of the header line. (Bug#8874)
4954 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4955 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4956 candidate is selected by the mouse, and that candidate has a
4957 composed character under the mouse.
4959 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4960 coordinates reported by pos-visible-in-window-p for a composed
4961 character in column zero.
4963 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4965 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4967 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4969 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4970 consider it a hit if to_charpos is anywhere in the range of the
4971 composed buffer positions.
4973 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4975 * image.c (gif_load): Don't assume that each subimage has the same
4976 dimensions as the base image. Handle disposal method that is
4977 "undefined" by the gif spec (Bug#9335).
4979 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4981 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4982 (Fcondition_case): Document `debug' symbol in error handler.
4984 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4986 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4987 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4988 from an Org mode buffer to a Speedbar frame.
4990 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4991 a composition, take its buffer position from IT->cmp_it.charpos.
4992 Fixes cursor positioning at the beginning of a line that begins
4993 with a composed character.
4995 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4997 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4998 character bidirectional type, use STRONG_L instead. Fixes crashes
4999 in a buffer produced by `describe-categories'.
5001 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5002 members before the level stack, so they would be saved and
5003 restored when copying iterator state. Fixes incorrect reordering
5004 around TABs covered by display properties.
5006 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5008 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5010 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5012 * eval.c (internal_condition_case, internal_condition_case_1)
5013 (internal_condition_case_2, internal_condition_case_n):
5014 Remove unnecessary aborts (Bug#9081).
5016 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5018 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5019 has no `load' handler, try opening the file locally. (Bug#9311)
5021 2011-08-16 Ken Brown <kbrown@cornell.edu>
5023 * gmalloc.c: Expand comment.
5025 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5027 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5028 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5030 2011-08-16 Ken Brown <kbrown@cornell.edu>
5032 Fix memory allocation problems in Cygwin build (Bug#9273).
5034 * unexcw.c ( __malloc_initialized): Declare external variable.
5035 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5037 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5039 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5041 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5043 [CYGWIN] (special_realloc): New function.
5044 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5045 requests to realloc storage in the static heap.
5047 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5049 * bidi.c (bidi_initialize): Remove unused local.
5051 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5054 * biditype.h: Remove file.
5055 * makefile.w32-in ($(BLD)/bidi.$(O)):
5056 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5058 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5060 * chartab.c: Improve commentary for the uniprop_table API.
5062 * bidi.c (bidi_paragraph_init): Support zero value of
5063 bidi_ignore_explicit_marks_for_paragraph_level.
5064 (bidi_initialize): Use uniprop_table instead of including
5065 biditype.h and bidimirror.h.
5067 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5068 coordinates of the iterator when restoring from ppos_it.
5071 2011-08-14 Kenichi Handa <handa@m17n.org>
5073 * process.c (create_process): Call setup_process_coding_systems
5074 after the pid of the process is set to -1 (Bug#8162).
5076 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5078 * xdisp.c (move_it_in_display_line_to): Don't invoke
5079 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5080 ppos_it. Fixes vertical cursor motion when line beginning is
5081 covered by an image. (Bug#9296)
5083 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5085 * nsterm.h (ns_run_ascript): Declare.
5086 (NSAPP_DATA2_RUNASSCRIPT): Define.
5088 * nsfns.m (as_script, as_result, as_status): New static variables.
5089 (ns_run_ascript): New function.
5090 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5091 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5092 the event loop. Get status from as_status (Bug#7276).
5094 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5095 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5096 the event loop (Bug#7276).
5098 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5100 * gnutls.c (QCgnutls_bootprop_priority)
5101 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5102 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5103 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5104 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5105 (QCgnutls_bootprop_verify_hostname_error)
5106 (QCgnutls_bootprop_callbacks_verify): Rename from
5107 Qgnutls_bootprop_..., all uses changed.
5109 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5112 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5114 * xfaces.c (Qframe_set_background_mode): Now static.
5115 * dispextern.h (Qframe_set_background_mode): Remove decl.
5117 * process.c (Fnetwork_interface_info): Declare local only if needed.
5119 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5121 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5122 (Fnetwork_interface_list): Allocate in increments of bytes instead
5123 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5124 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5126 (struct ifflag_def): notrailers is smart on OSX.
5127 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5128 Get hardware address with getifaddrs if available.
5130 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5132 * xdisp.c (iterate_out_of_display_property): xassert that
5133 IT->position is set to within IT->object's boundaries. Break from
5134 the loop as soon as EOB is reached; avoids infloops in redisplay
5135 when IT->position is set up wrongly due to some bug.
5136 Set IT->current to match the bidi iterator unconditionally.
5137 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5138 entry. Force push_it to save on the stack the current
5139 buffer/string position, to be restored by pop_it. Fix flags in
5140 the iterator structure wrt the object coming from a display
5141 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5142 properties. (Bug#9284)
5144 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5146 * fontset.c (fontset_get_font_group): Add proper type checks.
5149 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5151 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5152 and LC_VERSION_MIN_MACOSX.
5153 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5154 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5156 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5158 * xdisp.c (forward_to_next_line_start): Allow to use the
5159 no-display-properties-and-no-overlays under bidi display.
5160 Set disp_pos in the bidi iterator to avoid searches for display
5161 properties and overlays.
5163 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5165 * editfns.c (Fset_time_zone_rule): Document relationship with the
5168 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5169 the font entity extracted from the cache (Bug#8109).
5171 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5173 * composite.c (autocmp_chars): Don't reset point. That is done by
5174 restore_point_unwind (Bug#5984).
5176 2011-08-07 Juri Linkov <juri@jurta.org>
5178 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5179 to show the arg `TIME' instead of `TIMEVAL'.
5181 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5183 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5184 display property strides EOL and includes a newline, as in
5185 longlines-mode. (Bug#9254)
5186 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5187 word-wrap under bidirectional display. (Bug#9224)
5189 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5190 is non-zero, even if the data buffer is NULL. Fixes a crash in
5191 vertical-motion with longlines-mode. (Bug#9254)
5193 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5195 * bidi.c <bidi_cache_total_alloc>: Now static.
5196 (bidi_initialize): Initialize bidi_cache_total_alloc.
5198 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5201 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5202 amount allocated this far in `bidi_cache_total_alloc'.
5203 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5204 non-zero, only free the data buffer without restoring the cache
5205 contents. All callers changed.
5207 * dispextern.h (bidi_unshelve_cache): Update prototype.
5209 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5210 (move_it_in_display_line, move_it_to)
5211 (move_it_vertically_backward, move_it_by_lines): Replace the call
5212 to xfree to an equivalent call to bidi_unshelve_cache.
5213 (move_it_in_display_line_to): Fix logic of returning
5214 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5216 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5218 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5219 came from a string character with a `cursor' property. (Bug#9229)
5221 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5223 * Makefile.in (LIB_PTHREAD): New variable.
5224 (LIBES): Add LIB_PTHREAD (Bug#9216).
5226 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5227 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5229 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5231 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5233 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5235 * xterm.c (x_find_topmost_parent): New function.
5236 (x_set_frame_alpha): Find topmost parent window with
5237 x_find_topmost_parent and set the property there also (bug#9181).
5238 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5240 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5242 * callproc.c (Fcall_process): Avoid vfork clobbering
5243 the local vars buffer, coding_systems, current_dir.
5245 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5247 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5249 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5251 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5252 so that it is not optimized away.
5254 * xdisp.c (compute_display_string_pos): Remove unused local.
5256 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5258 Fix slow cursor motion and scrolling in large buffers with
5259 selective display, like Org Mode buffers. (Bug#9218)
5261 * dispextern.h (struct bidi_it): New member disp_prop_p.
5263 * xdisp.c: Remove one-slot cache of display string positions.
5264 (compute_display_string_pos): Accept an additional argument
5265 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5266 for a display string or property. If found, set DISP_PROP_P
5269 * bidi.c (bidi_fetch_char): Accept an additional argument
5270 DISP_PROP_P, and pass it to compute_display_string_pos.
5271 Only handle text covered by a display string if DISP_PROP_P is returned
5272 non-zero. All callers of bidi_fetch_char changed.
5274 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5276 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5278 2010-12-03 Don March <don@ohspite.net>
5280 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5281 last character M-[char] is translated to ESC [char] (bug#7541).
5283 2011-08-02 Kenichi Handa <handa@m17n.org>
5285 * lisp.h (uniprop_table): Extern it.
5287 * chartab.c (uniprop_table): Make it non-static.
5289 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5291 * xdisp.c (forward_to_next_line_start): Accept additional argument
5292 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5294 (reseat_at_next_visible_line_start): Use the bidi iterator state
5295 returned by forward_to_next_line_start to restore the state of
5296 it->bidi_it after backing up to previous newline. (Bug#9212)
5298 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5300 * regex.c (re_comp): Protoize.
5301 (re_exec): Fix return type.
5302 (regexec): Fix type of `ret'. (Bug#9203)
5304 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5306 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5307 This is needed if max-image-size is a floating-point number.
5309 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5311 * print.c (print_object): Print empty symbol as ##.
5313 * lread.c (read1): Read ## as empty symbol.
5315 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5317 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5318 setting frame foreground color (Bug#9175).
5319 (x_set_background_color): Likewise.
5321 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5322 contents (Bug#9176).
5323 (EmacsTooltip -init): Remove bezels and add shadows to
5326 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5327 or scroll bar (Bug#8470).
5329 * nsfont.m (nsfont_open): Remove assignment to voffset and
5330 unnecessary vars hshink, expand, hd, full_height, min_height.
5331 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5333 * nsterm.h (nsfont_info): Remove voffset field.
5335 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5337 Implement strike-through and overline on NextStep (Bug#8863).
5339 * nsfont.m (nsfont_open): Use underline position provided by font,
5340 instead of hard-coded value of 2.
5341 (nsfont_draw): Call ns_draw_text_decoration instead.
5343 * nsterm.h: Add declaration for ns_draw_text_decoration.
5345 * nsterm.m (ns_draw_text_decoration): New function for drawing
5346 underline, overline, and strike-through.
5347 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5348 ns_draw_text_decoration. Change treatment of cursor drawing to
5349 accommodate underlining, etc.
5351 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5353 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5356 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5358 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5359 Without this fix, if a signal arrives just after memory fills up,
5360 'malloc' might be invoked reentrantly.
5362 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5363 In other words, assume that every image size is allowed, on non-X
5364 hosts. This assumption is probably wrong, but it lets Emacs compile.
5366 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5368 * regex.c (re_iswctype): Convert return values to boolean.
5370 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5372 * xdisp.c (compute_display_string_pos): Don't use cached display
5373 string position if the buffer had its restriction changed.
5376 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5378 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5380 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5382 Integer signedness and overflow and related fixes. (Bug#9079)
5384 * bidi.c: Integer size and overflow fixes.
5385 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5386 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5387 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5388 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5389 (bidi_find_other_level_edge):
5390 Use ptrdiff_t instead of EMACS_INT where either will do.
5391 This works better on 32-bit hosts configured --with-wide-int.
5392 (bidi_cache_ensure_space): Check for size-calculation overflow.
5393 Use % rather than repeated addition, for better worst-case speed.
5394 Don't set bidi_cache_size until after xrealloc returns, because it
5396 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5397 (bidi_cache_ensure_space): Also check that the bidi cache size
5398 does not exceed that of the largest Lisp string or buffer. See Eli
5399 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5401 * alloc.c (__malloc_size_t): Remove.
5402 All uses replaced by size_t. See Andreas Schwab's note
5403 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5405 * image.c: Improve checking for integer overflow.
5406 (check_image_size): Assume that f is nonnull, since
5407 it is always nonnull in practice. This is one less thing to
5408 worry about when checking for integer overflow later.
5409 (x_check_image_size): New function, which checks for integer
5410 overflow issues inside X.
5411 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5412 This removes the need for a memory_full check.
5413 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5414 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5415 (xbm_read_bitmap_data): Change locals back to 'int', since
5416 their values must fit in 'int'.
5417 (xpm_load_image, png_load, tiff_load):
5418 Invoke x_create_x_image_and_pixmap earlier,
5419 to avoid much needless work if the image is too large.
5420 (tiff_load): Treat overly large images as if
5421 x_create_x_image_and_pixmap failed, not as malloc failures.
5422 (gs_load): Use x_check_image_size.
5424 * gtkutil.c: Omit integer casts.
5425 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5426 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5428 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5430 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5431 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5432 would wrongly return t on a 64-bit host.
5434 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5435 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5436 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5437 and therefore cause GCC to emit a bogus diagnostic in some cases.
5439 * image.c: Integer signedness and overflow and related fixes.
5440 This is not an exhaustive set of fixes, but it's time to
5441 record what I've got.
5442 (lookup_pixel_color, check_image_size): Remove redundant decls.
5443 (check_image_size): Don't assume that arbitrary EMACS_INT values
5444 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5445 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5446 (tiff_load, imagemagick_load_image):
5447 Check for overflow in size calculations.
5448 (x_create_x_image_and_pixmap): Remove unnecessary test for
5449 xmalloc returning NULL; that can't happen.
5450 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5451 (xpm_color_bucket): Use better integer hashing function.
5452 (xpm_cache_color): Don't possibly over-allocate memory.
5453 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5454 (gif_memory_source):
5455 Use ptrdiff_t, not int or size_t, to record sizes.
5456 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5457 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5458 either works, as we prefer signed integers.
5459 (tiff_read_from_memory, tiff_write_from_memory):
5460 Return tsize_t, not size_t, since that's what the TIFF API wants.
5461 (tiff_read_from_memory): Don't fail simply because the read would
5462 go past EOF; instead, return a short read.
5463 (tiff_load): Omit no-longer-needed casts.
5464 (Fimagemagick_types): Don't assume size fits into 'int'.
5466 Improve hashing quality when configured --with-wide-int.
5467 * fns.c (hash_string): New function, taken from sxhash_string.
5468 Do not discard information about ASCII character case; this
5469 discarding is no longer needed.
5470 (sxhash-string): Use it. Change sig to match it. Caller changed.
5471 * lisp.h: Declare it.
5472 * lread.c (hash_string): Remove, since we now use fns.c's version.
5473 The fns.c version returns a wider integer if --with-wide-int is
5474 specified, so this should help the quality of the hashing a bit.
5476 * emacs.c: Integer overflow minor fix.
5477 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5478 Define only if GNU_LINUX.
5479 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5481 * dispnew.c: Integer signedness and overflow fixes.
5482 Remove unnecessary forward decls, that were a maintenance hassle.
5483 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5485 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5486 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5487 (prepare_desired_row, line_draw_cost):
5488 Use int, not unsigned, where either works.
5489 (save_current_matrix, restore_current_matrix):
5490 Use ptrdiff_t, not size_t, where either works.
5491 (init_display): Check for overflow more accurately, and without
5492 relying on undefined behavior.
5494 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5495 Remove, replacing with the new symbols in lisp.h. All uses changed.
5496 * fileio.c (make_temp_name):
5497 * filelock.c (lock_file_1, lock_file):
5498 * xdisp.c (message_dolog):
5499 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5500 Use pMd etc. instead.
5501 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5502 replacing the pWIDE etc. symbols removed from editfns.c.
5504 * keyboard.h (num_input_events): Now uintmax_t.
5505 This is (very slightly) less likely to mess up due to wraparound.
5508 * buffer.c: Integer signedness fixes.
5509 (alloc_buffer_text, enlarge_buffer_text):
5510 Use ptrdiff_t rather than size_t when either will do, as we prefer
5513 * alloc.c: Integer signedness and overflow fixes.
5514 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5515 (__malloc_size_t): Default to size_t, not to int.
5516 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5517 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5518 Prefer ptrdiff_t to size_t when either would do, as we prefer
5520 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5521 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5522 Now const. Initialize with values that are in range even if char
5524 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5525 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5526 These functions do the right thing with sizes > 2**32.
5527 (check_depth): Now ptrdiff_t, not int.
5528 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5529 Adjust to new way of storing sizes. Check for size overflow bugs
5531 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5532 slightly wrong anyway, as it missed one instance of
5533 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5534 (refill_memory_reserve): Omit needless cast to size_t.
5535 (mark_object_loop_halt): Mark as externally visible.
5537 * xselect.c: Integer signedness and overflow fixes.
5538 (Fx_register_dnd_atom, x_handle_dnd_message):
5539 Use ptrdiff_t, not size_t, since we prefer signed.
5540 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5541 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5542 x_dnd_atoms_size and x_dnd_atoms_length.
5544 * doprnt.c: Prefer signed to unsigned when either works.
5546 * doprnt.c (doprnt):
5548 * xdisp.c (vmessage):
5549 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5550 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5551 prefer signed arithmetic to avoid comparison confusion.
5552 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5553 but is a bit tricky.
5555 Assume freestanding C89 headers, string.h, stdlib.h.
5556 * data.c, doprnt.c, floatfns.c, print.c:
5557 Include float.h unconditionally.
5558 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5559 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5560 * regex.c: Likewise for stddef.h, string.h.
5561 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5562 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5563 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5564 (STDC_HEADERS): Remove obsolete defines.
5565 * sysdep.c: Include limits.h unconditionally.
5567 Assume support for memcmp, memcpy, memmove, memset.
5568 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5569 * regex.c (memcmp, memcpy):
5570 Remove; we assume C89 now.
5572 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5573 (__malloc_safe_bcopy): Remove; no longer needed.
5575 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5576 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5577 well either way, and we prefer signed to unsigned.
5579 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5581 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5582 closes the connection while we're reading (bug#9182).
5584 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5586 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5587 are specified (Bug#9168).
5589 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5591 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5592 Found by GCC static checking and --with-wide-int on a 32-bit host.
5594 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5596 * xdisp.c (compute_display_string_pos): Fix logic of caching
5597 previous display string position. Initialize cached_prev_pos to
5598 -1. Fixes slow-down at the beginning of a buffer.
5600 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5602 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5603 for attrs[LFACE_FONTSET_INDEX].
5605 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5607 * xml.c (parse_region): Remove unused local
5608 that was recently introduced.
5610 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5612 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5613 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5615 * xdisp.c (move_it_in_display_line_to): Record the best matching
5616 position for TO_CHARPOS while scanning the line, and restore it on
5617 exit if none of the characters scanned was an exact match.
5618 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5619 when exact match is impossible due to invisible text, and the
5620 lines are truncated.
5622 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5624 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5627 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5629 Fix a significant slow-down of cursor motion with C-n, C-p,
5630 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5631 auto-repeat under bidi redisplay in fontified buffers.
5632 * xdisp.c (compute_stop_pos_backwards): New function.
5633 (next_element_from_buffer): Call compute_stop_pos_backwards to
5634 find a suitable prev_stop when we find ourselves before
5636 (reseat): Don't look for prev_stop, as that could mean a very long
5638 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5639 <cached_disp_overlay_modiff>: Cache for last found display string
5641 (compute_display_string_pos): Return the cached position if asked
5642 about the same buffer in the same area of character positions, and
5643 the buffer wasn't changed since the time the display string
5644 position was cached.
5646 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5648 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5649 is an integer, which is important for empty lines. (Bug#9149)
5651 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5653 * frame.c (Fmodify_frame_parameters): In tty case, update the
5654 default face if necessary (Bug#4238).
5656 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5658 * editfns.c (Fstring_to_char): No need to explain what a character
5659 is in the docstring (Bug#6576).
5661 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5663 * xml.c (parse_region): Make sure we always return a tree.
5665 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5667 * xml.c (parse_region): If a document contains only comments,
5670 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5672 * xml.c (make_dom): Return comments, too.
5674 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5677 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5678 and the surrounding thread.
5679 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5680 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5681 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5683 * s/openbsd.h (BROKEN_SIGIO): Define.
5684 * unexelf.c (unexec) [__OpenBSD__]:
5685 Don't update the .mdebug section of the Alpha COFF symbol table.
5687 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5689 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5692 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5694 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5695 This fixes some race conditions on the permissions of any newly
5698 * alloc.c (valid_pointer_p): Use pipe, not open.
5699 This fixes some permissions issues when debugging.
5701 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5702 If fchown fails to set both uid and gid, try to set just gid,
5703 as that is sometimes allowed. Adjust the file's mode to eliminate
5704 setuid or setgid bits that are inappropriate if fchown fails.
5706 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5708 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5709 to compare Lisp_Objects.
5710 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5711 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5712 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5714 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5716 * lread.c (read_integer): Unread even EOF character.
5717 (read1): Likewise. Properly record start position of symbol.
5719 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5720 symbol character follows.
5722 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5724 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5725 This works around a problem with the previous change to Fcopy_file.
5726 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5727 and without this change, GCC might complain about discarding
5728 fchown's return value.
5730 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5732 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5734 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5736 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5738 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5740 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5741 it's used from the C level.
5743 * process.c: Use the same condition for POLL_FOR_INPUT in both
5744 keyboard.c and process.c (bug#1858).
5746 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5748 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5749 (Fgnutls_boot): Use it.
5751 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5753 * doc.c (Fsubstitute_command_keys): Revert last change.
5755 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5757 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5758 quotes the next character, and doesn't affect other longer
5759 sequences (bug#8935).
5761 * lread.c (syms_of_lread): Clarify that is isn't only
5762 `eval-buffer' and `eval-defun' that's affected by
5763 `lexical-binding' (bug#8460).
5765 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5767 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5768 bidi redisplay when a line includes both an image and is truncated.
5770 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5772 Fix minor problems found by static checking.
5773 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5774 (elsz): Now a signed constant, not a size_t var. We prefer signed
5775 types to unsigned, to avoid integer comparison confusion. Without
5776 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5777 "cannot optimize loop, the loop counter may overflow", a symptom
5779 * indent.c (Fvertical_motion): Mark locals as initialized.
5780 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5782 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5784 * search.c (Fre_search_backward): Mention `case-fold-search' in
5785 all the re_search_* functions (bug#8138).
5787 * keyboard.c (Fopen_dribble_file): Document when the file is
5790 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5792 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5795 Support bidi reordering of display and overlay strings.
5796 * xdisp.c (compute_display_string_pos)
5797 (compute_display_string_end): Accept additional argument STRING.
5798 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5799 (reseat_to_string): Initialize bidi_it->string.s and
5800 bidi_it->string.schars.
5801 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5802 NULL (avoids a crash in bidi_paragraph_init).
5803 Initialize itb.string.lstring.
5804 (init_iterator): Call bidi_init_it only of a valid
5805 buffer position was specified. Initialize paragraph_embedding to
5807 (reseat_to_string): Initialize the bidi iterator.
5808 (display_string): If we need to ignore text properties of
5809 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5810 original value of -1 will not work with bidi.)
5811 (compute_display_string_pos): First arg is now struct
5812 `text_pos *'; all callers changed. Support display properties on
5814 (compute_display_string_end): Support display properties on Lisp
5816 (init_iterator, reseat_1, reseat_to_string): Initialize the
5817 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5818 when iterating on a string not from display properties).
5819 (compute_display_string_pos, compute_display_string_end):
5820 Fix calculation of the object to scan. Fixes an error when using
5822 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5823 base_level_stop; instead, set base_level_stop to BEGV.
5824 Fixes crashes in vertical-motion.
5825 (next_element_from_buffer): Improve commentary for when
5826 the iterator is before prev_stop.
5827 (init_iterator): Initialize bidi_p from the default value of
5828 bidi-display-reordering, not from buffer-local value. Use the
5829 buffer-local value only if initializing for buffer iteration.
5830 (handle_invisible_prop): Support invisible properties on strings
5831 that are being bidi-reordered.
5832 (set_iterator_to_next): Support bidi reordering of C strings and
5834 (next_element_from_string): Support bidi reordering of Lisp
5836 (handle_stop_backwards): Support Lisp strings as well.
5837 (display_string): Support display of R2L glyph rows.
5838 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5839 (init_iterator): Don't initialize it->bidi_p for strings
5841 (reseat_to_string): Initialize it->bidi_p for strings here.
5842 (next_element_from_string, next_element_from_c_string)
5843 (next_element_from_buffer): Add xassert's for correspondence
5844 between IT's object being iterated and it->bidi_it.string
5846 (face_before_or_after_it_pos): Support bidi iteration.
5847 (next_element_from_c_string): Handle the case of the first string
5848 character that is not the first one in the visual order.
5849 (get_visually_first_element): New function, refactored from common
5850 parts of next_element_from_buffer, next_element_from_string, and
5851 next_element_from_c_string.
5852 (tool_bar_lines_needed, redisplay_tool_bar)
5853 (display_menu_bar): Force left-to-right direction. Add a FIXME
5854 comment for making that be controlled by a user option.
5855 (push_it, pop_it): Save and restore the state of the
5856 bidi iterator. Save and restore the bidi_p flag.
5857 (pop_it): Iterate out of display property for string iteration as
5859 (iterate_out_of_display_property): Support iteration over strings.
5860 (handle_single_display_spec): Set up it->bidi_it for iteration
5861 over a display string, and call bidi_init_it.
5862 (handle_single_display_spec, next_overlay_string)
5863 (get_overlay_strings_1, push_display_prop): Set up the bidi
5864 iterator for displaying display or overlay strings.
5865 (forward_to_next_line_start): Don't use the shortcut if
5867 (back_to_previous_visible_line_start): If handle_display_prop
5868 pushed the iterator stack, restore the internal state of the bidi
5869 iterator by calling bidi_pop_it same number of times.
5870 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5871 and we are bidi-iterating, don't decrement the iterator position;
5872 instead, set the first_elt flag in the bidi iterator, to produce
5874 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5875 (push_display_prop): xassert that we are iterating a buffer.
5876 (push_it, pop_it): Save and restore paragraph_embedding member.
5877 (handle_single_display_spec, next_overlay_string)
5878 (get_overlay_strings_1, reseat_1, reseat_to_string)
5879 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5880 correctly. Don't assume unibyte strings are not bidi-reordered.
5881 (compute_display_string_pos)
5882 (compute_display_string_end): Fix handling the case of C string.
5883 (push_it, pop_it): Save and restore from_disp_prop_p.
5884 (handle_single_display_spec, push_display_prop): Set the
5885 from_disp_prop_p flag.
5886 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5887 (pop_it): Call iterate_out_of_display_property only if we are
5888 popping after iteration over a string that came from a display
5889 property. Fix a typo in popping stretch info. Add an assertion
5890 for verifying that the iterator position is in sync with the bidi
5892 (handle_single_display_spec, get_overlay_strings_1)
5893 (push_display_prop): Fix initialization of paragraph direction for
5894 string when that of the parent object is not yet determined.
5895 (reseat_1): Call bidi_init_it to resync the bidi
5896 iterator with IT's position. (Bug#7616)
5897 (find_row_edges): If ROW->start.pos gives position
5898 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5899 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5900 Reset the from_disp_prop_p flag.
5901 (SAVE_IT, RESTORE_IT): New macros.
5902 (pos_visible_p, face_before_or_after_it_pos)
5903 (back_to_previous_visible_line_start)
5904 (move_it_in_display_line_to, move_it_in_display_line)
5905 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5906 (try_scrolling, redisplay_window, display_line): Use them when
5907 saving a temporary copy of the iterator and restoring it back.
5908 (back_to_previous_visible_line_start, reseat_1)
5909 (init_iterator): Empty the bidi cache "stack".
5910 (move_it_in_display_line_to): If iterator ended up at
5911 EOL, but we never saw any buffer positions smaller than
5912 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5913 motion in bidi-reordered lines.
5914 (move_it_in_display_line_to): Record prev_method and prev_pos
5915 immediately before the call to set_iterator_to_next. Fixes cursor
5916 motion in bidi-reordered lines with stretch glyphs and strings
5917 displayed in margins. (Bug#8133) (Bug#8867)
5918 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5920 (pos_visible_p): Support positions in bidi-reordered lines.
5921 Save and restore bidi cache.
5923 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5924 (bidi_paragraph_info): Delete unused struct.
5925 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5926 (bidi_cache_start): New variable.
5927 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5929 (bidi_cache_fetch_state, bidi_cache_search)
5930 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5931 (bidi_cache_find, bidi_peek_at_next_level)
5932 (bidi_level_of_next_char, bidi_find_other_level_edge)
5933 (bidi_move_to_visually_next): Compare cache index with
5934 bidi_cache_start rather than with zero.
5935 (bidi_fetch_char): Accept new argument STRING; all callers
5936 changed. Support iteration over a string. Support strings with
5937 display properties. Support unibyte strings. Fix the type of
5938 `len' according to what STRING_CHAR_AND_LENGTH expects.
5939 (bidi_paragraph_init, bidi_resolve_explicit_1)
5940 (bidi_resolve_explicit, bidi_resolve_weak)
5941 (bidi_level_of_next_char, bidi_move_to_visually_next):
5942 Support iteration over a string.
5943 (bidi_set_sor_type, bidi_resolve_explicit_1)
5944 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5945 can now be zero (for strings); special values 0 and -1 were
5946 changed to -1 and -2, respectively.
5947 (bidi_char_at_pos): New function.
5948 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5949 Call it instead of FETCH_MULTIBYTE_CHAR.
5950 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5951 initialized to valid values.
5952 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5954 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5955 the test for valid cached positions. Fix the logic for looking up
5956 the sentinel state in the cache. GCPRO the Lisp string we are
5958 (bidi_push_it, bidi_pop_it): New functions.
5959 (bidi_initialize): Initialize the bidi cache start stack pointer.
5960 (bidi_cache_ensure_space): New function, refactored from part of
5961 bidi_cache_iterator_state. Don't assume the required size is just
5962 one BIDI_CACHE_CHUNK away.
5963 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5964 (bidi_count_bytes, bidi_char_at_pos): New functions.
5965 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5966 always valid if bidi_cache_idx is valid.
5967 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5968 is valid if it's going to be used.
5969 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5970 (bidi_cache_fetch_state, bidi_cache_search)
5971 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5972 (bidi_cache_iterator_state, bidi_cache_find)
5973 (bidi_find_other_level_edge, bidi_cache_start_stack):
5974 All variables related to cache indices are now EMACS_INT.
5976 * dispextern.h (struct bidi_string_data): New structure.
5977 (struct bidi_it): New member `string'. Make flag members be 1-bit
5978 fields, and put them last in the struct.
5979 (compute_display_string_pos, compute_display_string_end):
5981 (bidi_push_it, bidi_pop_it): Add prototypes.
5982 (struct iterator_stack_entry): New members bidi_p,
5983 paragraph_embedding, and from_disp_prop_p.
5984 (struct it): Member bidi_p is now a bit field 1 bit wide.
5985 (bidi_shelve_cache, bidi_unshelve_cache):
5988 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5989 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5990 and vector-like objects.
5992 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5993 cache around display iteration.
5995 * window.c (Fwindow_end, window_scroll_pixel_based)
5996 (displayed_window_lines, Frecenter): Save and restore the bidi
5997 cache around display iteration.
5999 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6001 * editfns.c (Fdelete_region): Clarify the use of the named
6002 parameters (bug#6788).
6004 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6006 * indent.c (Fvertical_motion): Set and restore w->pointm when
6007 saving and restoring the window's buffer (Bug#9006).
6009 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6011 * editfns.c (Fstring_to_char): Clarify just what is returned
6012 (bug#6576). Text by Eli Zaretskii.
6014 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6016 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6018 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6020 * buffer.c (mmap_find): Fix a typo.
6022 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6024 Fix execution of x selection hooks.
6025 * xselect.c (Qx_lost_selection_functions)
6026 (Qx_sent_selection_functions): New vars.
6027 (syms_of_xselect): DEFSYM them.
6028 (x_handle_selection_request): Pass Qx_sent_selection_functions
6029 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6030 (x_handle_selection_clear,x_clear_frame_selections):
6031 Pass Qx_lost_selection_functions rather than
6032 Vx_lost_selection_functions to Frun_hook_with_args.
6034 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6036 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6037 The old code sometimes used this field without initializing it.
6039 * alloc.c (gc_sweep): Don't read past end of array.
6040 In theory, the old code could also have corrupted Emacs internals,
6041 though it'd be very unlikely.
6043 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6045 * character.c (Fcharacterp): Don't advertise optional ignored
6046 argument. (Bug#4026)
6048 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6050 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6053 * window.c (Fset_window_start): Doc fix (bug#4199).
6054 (Fset_window_hscroll): Ditto.
6056 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6058 Fix minor new problems caught by GCC 4.6.1.
6059 * term.c (init_tty): Remove unused local.
6060 * xsettings.c (store_monospaced_changed): Define this function only
6061 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6064 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6066 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6068 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6070 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6071 are the mini-buffer and the echo area (bug#3320).
6073 * term.c (init_tty): Remove support for supdup, c10 and perq
6074 terminals, which are no longer supported (bug#1482).
6076 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6078 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6080 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6082 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6083 for non-popups (Bug#3642).
6085 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6087 * alloc.c (reset_malloc_hooks): Protoize.
6088 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6089 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6090 * cm.c (losecursor): Likewise.
6091 * data.c (fmod): Likewise.
6092 * dispnew.c (swap_glyphs_in_rows): Likewise.
6093 * emacs.c (memory_warning_signal): Likewise.
6094 * floatfns.c (float_error): Likewise.
6095 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6096 (otf_open, font_otf_capability, generate_otf_features)
6097 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6099 * image.c (pbm_read_file): Likewise.
6100 * indent.c (string_display_width): Likewise.
6101 * intervals.c (check_for_interval, search_for_interval)
6102 (inc_interval_count, count_intervals, root_interval)
6103 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6104 * lread.c (defalias): Likewise.
6105 * ralloc.c (r_alloc_check): Likewise.
6106 * regex.c (set_image_of_range_1, set_image_of_range)
6107 (regex_grow_registers): Likewise.
6108 * sysdep.c (strerror): Likewise.
6109 * termcap.c (valid_filename_p, tprint, main): Likewise.
6110 * tparam.c (main): Likewise.
6111 * unexhp9k800.c (run_time_remap, save_data_space)
6112 (update_file_ptrs, read_header, write_header, calculate_checksum)
6113 (copy_file, copy_rest, display_header): Likewise.
6114 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6116 * xdisp.c (check_it): Likewise.
6117 * xfaces.c (register_color, unregister_color, unregister_colors):
6119 * xfns.c (print_fontset_result): Likewise.
6120 * xrdb.c (member, fatal, main): Likewise.
6122 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6124 Fix minor problems found by static checking (Bug#9031).
6125 * chartab.c (char_table_set_range, map_sub_char_table):
6126 Remove unused locals.
6127 (uniprop_table): Now static.
6128 * composite.c (_work_char): Remove unused static var.
6130 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6132 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6134 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6136 * gtkutil.c (qttip_cb): Remove code without function.
6138 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6140 * w32.c (pthread_sigmask): New stub.
6142 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6144 Use pthread_sigmask, not sigprocmask (Bug#9010).
6145 sigprocmask is portable only for single-threaded applications, and
6146 Emacs can be multi-threaded when it uses GTK.
6147 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6149 * callproc.c (Fcall_process):
6150 * process.c (create_process):
6151 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6152 Use pthread_sigmask, not sigprocmask.
6154 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6156 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6157 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6160 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6162 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6163 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6164 (xg_hide_tooltip): Fix comment.
6166 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6167 in registerServicesMenuSendTypes.
6168 (validRequestorForSendType): Don't check ns_return_types.
6170 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6173 2011-07-08 Jason Rumney <jasonr@gnu.org>
6175 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6176 SH_SHOW for hidden windows (Bug#5482).
6178 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6179 frame struct members of non-existent frames (Bug#6284).
6181 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6183 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6184 variable firstTime not needed on OSX >= 10.6.
6185 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6186 >= 10.5. Use setKnobProportion, setDoubleValue.
6188 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6189 (MAC_OS_X_VERSION_10_5): Define if not defined.
6190 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6191 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6192 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6194 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6195 cString and lossyCString on OSX >= 10.4
6197 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6198 sizeToFit on OSX >= 10.2.
6200 * nsimage.m (allocInitFromFile): Don't use deprecated method
6201 bestRepresentationForDevice on OSX >= 10.6.
6203 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6206 * emacs.c: Declare unexec_init_emacs_zone.
6208 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6210 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6212 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6213 on svcsMenu (Bug#8842).
6215 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6217 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6219 * nsterm.m (QUTF8_STRING): Declare.
6220 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6221 (validRequestorForSendType): Return type is (id).
6222 Change indexOfObjectIdenticalTo to indexOfObject.
6223 Check if we have local selection before returning self (Bug#8842).
6224 (writeSelectionToPasteboard): Put local selection into paste board
6225 if we have a local selection (Bug#8842).
6226 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6228 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6229 (ns_get_local_selection): Declare.
6231 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6233 * keymap.c (describe_map_tree): Don't insert a double newline at
6234 the end of the buffer (bug#1169) and return whether we inserted
6237 * callint.c (Fcall_interactively): Change "reading args" to
6238 "providing args" to try to clarify what it does (bug#1010).
6240 2011-07-07 Kenichi Handa <handa@m17n.org>
6242 * composite.c (composition_compute_stop_pos): Ignore a static
6243 composition starting before CHARPOS (Bug#8915).
6245 * xdisp.c (handle_composition_prop): Likewise.
6247 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6249 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6252 2011-07-07 Kenichi Handa <handa@m17n.org>
6254 * character.h (unicode_category_t): New enum type.
6256 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6257 (Qchar_code_property_table): New variable.
6258 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6259 (UNIPROP_COMPRESSED_FORM_P): New macros.
6260 (char_table_ascii): Uncompress the compressed values.
6261 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6262 Uncompress the compressed values.
6263 (sub_char_table_ref_and_range): Likewise.
6264 (char_table_ref_and_range): Uncompress the compressed values.
6265 (sub_char_table_set): New arg is_uniprop. Callers changed.
6266 Uncompress the compressed values.
6267 (sub_char_table_set_range): Args changed. Callers changed.
6268 (char_table_set_range): Adjuted for the above change.
6269 (map_sub_char_table): Delete args default_val and parent. Add arg
6270 top. Give decoded values to a Lisp function.
6271 (map_char_table): Adjust for the above change. Give decoded
6272 values to a Lisp function. Gcpro more variables.
6273 (uniprop_table_uncompress)
6274 (uniprop_decode_value_run_length): New functions.
6275 (uniprop_decoder, uniprop_decoder_count): New variables.
6276 (uniprop_get_decoder, uniprop_encode_value_character)
6277 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6279 (uniprop_encoder, uniprop_encoder_count): New variables.
6280 (uniprop_get_encoder, uniprop_table)
6281 (Funicode_property_table_internal, Fget_unicode_property_internal)
6282 (Fput_unicode_property_internal): New functions.
6283 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6284 Sunicode_property_table_internal, Sget_unicode_property_internal,
6285 and Sput_unicode_property_internal. Defvar_lisp
6286 char-code-property-alist.
6288 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6289 Vunicode_category_table.
6291 * font.c (font_range): Adjust for the change of
6292 Vunicode_category_table.
6294 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6296 * m/iris4d.h: Remove file, move contents ...
6297 * s/irix6-5.h: ... here.
6299 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6301 Remove unportable assumption about struct layout (Bug#8884).
6302 * alloc.c (mark_buffer):
6303 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6304 (clone_per_buffer_values): Don't assume that
6305 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6306 This isn't true in general, and it's particularly not true
6307 if Emacs is configured with --with-wide-int.
6308 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6309 New macros, used in the buffer.c change.
6311 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6313 * xsettings.c: Use both GConf and GSettings if both are available.
6314 (store_config_changed_event): Add comment.
6315 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6316 (store_tool_bar_style_changed): New functions.
6317 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6318 (struct xsettings): Move font inside HAVE_XFT.
6319 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6320 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6321 Move inside HAVE_XFT.
6322 (something_changed_gsettingsCB): Rename from something_changedCB.
6323 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6325 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6326 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6327 (something_changed_gconfCB): Rename from something_changedCB.
6328 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6329 (parse_settings): Move check for font inside HAVE_XFT.
6330 (read_settings, apply_xft_settings): Add comment.
6331 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6332 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6333 call store_font_name_changed.
6334 (xft_settings_event): Add comment.
6335 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6336 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6337 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6338 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6339 (xsettings_initialize): Call init_gsettings last.
6340 (xsettings_get_system_font, xsettings_get_system_normal_font):
6343 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6345 Random fixes. E.g., (random) never returned negative values.
6346 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6347 subseconds part to the entropy, as that's a bit more random.
6348 Prefer signed to unsigned, since the signedness doesn't matter and
6349 in general we prefer signed. When given a limit, use a
6350 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6351 latter isn't right if USE_2_TAGS_FOR_INTS.
6352 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6353 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6355 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6357 * textprop.c (text_property_stickiness):
6358 Obey Vtext_property_default_nonsticky.
6359 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6360 * w32fns.c (syms_of_w32fns):
6361 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6363 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6365 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6366 This is more efficient than Ffile_directory_p and avoids a minor race.
6368 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6370 * buffer.c (Foverlay_put): Say what the return value is
6373 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6374 is a directory before asking whether to use the file name
6376 (barf_or_query_if_file_exists): Make the "File is a directory"
6377 error be more correct.
6379 * fns.c (Frequire): Remove the mention of the .gz files, since
6380 that's installation-specific, but keep the mention of
6381 `get-load-suffixes'.
6383 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6385 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6386 Report string overflow if the output is too long.
6388 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6390 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6391 (syms_of_gnutls): Remove duplicate DEFSYM for
6392 Qgnutls_bootprop_verify_hostname_error, an error for
6393 Qgnutls_bootprop_verify_error (which is no longer used).
6395 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6396 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6397 Also (re)move comments that are misplaced or no longer relevant.
6399 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6401 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6403 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6405 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6406 and background color parameters if they have been changed.
6408 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6410 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6412 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6414 * xsettings.c (SYSTEM_FONT): Define only when used.
6415 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6417 * keymap.c (access_keymap_1): Now static.
6419 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6421 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6422 leave any prefix arg for the up event (Bug#1586).
6424 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6426 * lread.c (syms_of_lread): Mention single symbols defined by
6427 `defvar' or `defconst' (bug#7154).
6429 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6430 (Frequire): Mention get-load-suffixes.
6432 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6434 * window.h (window): Remove clone_number slot.
6435 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6437 (make_parent_window, make_window, saved_window)
6438 (Fset_window_configuration, save_window_save): Don't deal with
6440 * buffer.c (Qclone_number): Remove declaration.
6441 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6443 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6445 Add multiple inheritance to keymaps.
6446 * keymap.c (Fmake_composed_keymap): New function.
6447 (Fset_keymap_parent): Simplify.
6448 (fix_submap_inheritance): Remove.
6449 (access_keymap_1): New function extracted from access_keymap to handle
6450 embedded parents and handle lists of maps.
6451 (access_keymap): Use it.
6452 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6453 (Fcopy_keymap): Handle embedded parents.
6454 (Fcommand_remapping, define_as_prefix): Simplify.
6455 (Fkey_binding): Simplify.
6456 (syms_of_keymap): Move minibuffer-local-completion-map,
6457 minibuffer-local-filename-completion-map,
6458 minibuffer-local-must-match-map, and
6459 minibuffer-local-filename-must-match-map to Elisp.
6460 (syms_of_keymap): Defsubr make-composed-keymap.
6461 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6462 (parse_menu_item): Trivial simplification.
6464 2011-07-01 Glenn Morris <rgm@gnu.org>
6466 * Makefile.in (SETTINGS_LIBS): Fix typo.
6468 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6470 * coding.c (Fencode_coding_string): Record the last coding system
6471 used, as the function doc string says (bug#8738).
6473 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6475 * xsettings.c (store_monospaced_changed): Take new font as arg and
6476 check for change against current_mono_font.
6477 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6478 (emacs_settings_constructor, emacs_settings_get_property)
6479 (emacs_settings_set_property, emacs_settings_class_init)
6480 (emacs_settings_init, gsettings_obj): Remove.
6481 (something_changedCB): New function for HAVE_GSETTINGS.
6482 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6483 with value as argument.
6484 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6485 g_settings_new (Bug#8967). Do not create gsettings_obj.
6486 Remove calls to g_settings_bind. Connect something_changedCB to
6489 * xgselect.c: Add defined (HAVE_GSETTINGS).
6490 (xgselect_initialize): Ditto.
6492 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6493 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6496 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6498 * eval.c (struct backtrace): Simplify and port the data structure.
6499 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6500 signed bit field, as this assumption is not portable and it makes
6501 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6502 "char debug_on_exit : 1" as this is not portable either; instead,
6503 use the portable "unsigned int debug_on_exit : 1". Remove unused
6504 member evalargs. Remove obsolete comments about cc bombing out.
6506 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6508 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6509 Let HAVE_GSETTINGS override HAVE_GCONF.
6510 (store_monospaced_changed): New function.
6511 (EMACS_SETTINGS): A new type derived from GObject to handle
6512 GSettings notifications.
6513 (emacs_settings_constructor, emacs_settings_get_property)
6514 (emacs_settings_set_property, emacs_settings_class_init):
6516 (gsettings_client, gsettings_obj): New variables.
6517 (GSETTINGS_SCHEMA): New define.
6518 (something_changedCB): Call store_monospaced_changed.
6519 (init_gsettings): New function.
6520 (xsettings_initialize): Call init_gsettings.
6521 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6524 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6527 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6529 * window.c (resize_root_window, grow_mini_window)
6530 (shrink_mini_window): Rename Qresize_root_window to
6531 Qwindow_resize_root_window and Qresize_root_window_vertically to
6532 Qwindow_resize_root_window_vertically.
6534 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6536 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6538 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6540 * makefile.w32-in: Redesign dependencies so they reflect more
6541 clearly which files are directly included by each source file,
6542 and not through other includes.
6544 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6546 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6547 (sort_overlays, overlay_strings): When an overlay's clone number
6548 matches the window's clone number process the overlay even if
6549 the overlay's window property doesn't match the current window.
6551 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6552 (Fwindow_hchild): Rename to Fwindow_left_child.
6553 (Fwindow_next): Rename to Fwindow_next_sibling.
6554 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6555 (resize_window_check): Rename to window_resize_check.
6556 (resize_window_apply): Rename to window_resize_apply.
6557 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6558 (Fdelete_other_windows_internal, resize_frame_windows)
6559 (Fsplit_window_internal, Fdelete_window_internal)
6560 (grow_mini_window, shrink_mini_window)
6561 (Fresize_mini_window_internal): Fix callers accordingly.
6563 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6565 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6566 (emacs_fixed_set_min_size): Remove.
6567 (emacs_fixed_new): Take frame as argument.
6569 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6570 (_EmacsFixedPrivate): Remove minwidth/height.
6571 Add struct frame *f.
6572 (emacs_fixed_init): Initialize priv->f.
6573 (get_parent_class, emacs_fixed_set_min_size): Remove.
6574 (emacs_fixed_new): Set priv->f to argument.
6575 (emacs_fixed_get_preferred_width)
6576 (emacs_fixed_get_preferred_height): Use min_width/height from
6577 frames size_hint to set minimum and natural (Bug#8919).
6578 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6579 and use min_width/height from frames size_hint to set
6580 min_width/height (Bug#8919).
6582 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6583 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6586 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6588 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6589 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6592 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6594 * process.c (wait_reading_process_output): Bypass select if
6595 waiting for a cell while ignoring keyboard input, and input is
6596 pending. Suggested by Jan Djärv (Bug#8869).
6598 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6600 Use gnulib's dup2 module instead of rolling our own.
6601 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6603 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6605 * dispnew.c (scrolling_window): Before scrolling, turn off a
6606 mouse-highlight in the window being scrolled.
6608 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6610 Move DEFSYM to lisp.h and use everywhere.
6612 * character.h (DEFSYM): Move declaration...
6613 * lisp.h (DEFSYM): ...here.
6619 * w32select.c: Don't include character.h.
6621 * alloc.c (syms_of_alloc):
6622 * buffer.c (syms_of_buffer):
6623 * bytecode.c (syms_of_bytecode):
6624 * callint.c (syms_of_callint):
6625 * casefiddle.c (syms_of_casefiddle):
6626 * casetab.c (init_casetab_once):
6627 * category.c (init_category_once, syms_of_category):
6628 * ccl.c (syms_of_ccl):
6629 * cmds.c (syms_of_cmds):
6630 * composite.c (syms_of_composite):
6631 * dbusbind.c (syms_of_dbusbind):
6632 * dired.c (syms_of_dired):
6633 * dispnew.c (syms_of_display):
6634 * doc.c (syms_of_doc):
6635 * editfns.c (syms_of_editfns):
6636 * emacs.c (syms_of_emacs):
6637 * eval.c (syms_of_eval):
6638 * fileio.c (syms_of_fileio):
6639 * fns.c (syms_of_fns):
6640 * frame.c (syms_of_frame):
6641 * fringe.c (syms_of_fringe):
6642 * insdel.c (syms_of_insdel):
6643 * keymap.c (syms_of_keymap):
6644 * lread.c (init_obarray, syms_of_lread):
6645 * macros.c (syms_of_macros):
6646 * msdos.c (syms_of_msdos):
6647 * print.c (syms_of_print):
6648 * process.c (syms_of_process):
6649 * search.c (syms_of_search):
6650 * sound.c (syms_of_sound):
6651 * syntax.c (init_syntax_once, syms_of_syntax):
6652 * terminal.c (syms_of_terminal):
6653 * textprop.c (syms_of_textprop):
6654 * undo.c (syms_of_undo):
6655 * w32.c (globals_of_w32):
6656 * window.c (syms_of_window):
6657 * xdisp.c (syms_of_xdisp):
6658 * xfaces.c (syms_of_xfaces):
6659 * xfns.c (syms_of_xfns):
6660 * xmenu.c (syms_of_xmenu):
6661 * xsettings.c (syms_of_xsettings):
6662 * xterm.c (syms_of_xterm): Use DEFSYM.
6664 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6666 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6668 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6670 Integer and buffer overflow fixes (Bug#8873).
6672 * print.c (printchar, strout): Check for string overflow.
6673 (PRINTPREPARE, printchar, strout):
6674 Don't set size unless allocation succeeds.
6676 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6677 for sizes. Check for string overflow more accurately.
6678 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6680 * macros.c: Integer and buffer overflow fixes.
6681 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6682 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6683 Use ptrdiff_t, not int, for sizes.
6684 Don't increment bufsize until after realloc succeeds.
6685 Check for size-calculation overflow.
6686 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6688 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6690 * lread.c: Integer overflow fixes.
6691 (read_integer): Radix is now EMACS_INT, not int,
6692 to improve quality of diagnostics for out-of-range radices.
6693 Calculate buffer size correctly for out-of-range radices.
6694 (read1): Check for integer overflow in radices, and in
6695 read-circle numbers.
6696 (read_escape): Avoid int overflow.
6697 (Fload, openp, read_buffer_size, read1)
6698 (substitute_object_recurse, read_vector, read_list, map_obarray):
6699 Use ptrdiff_t, not int, for sizes.
6700 (read1): Use EMACS_INT, not int, for sizes.
6701 Check for size overflow.
6703 * image.c (cache_image): Check for size arithmetic overflow.
6705 * lread.c: Integer overflow issues.
6706 (saved_doc_string_size, saved_doc_string_length)
6707 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6708 Now ptrdiff_t, not int.
6709 (read1): Don't assume doc string length fits in int. Check for
6710 out-of-range doc string lengths.
6711 (read_list): Don't assume file position fits in int.
6712 (read_escape): Check for hex character overflow.
6714 2011-06-22 Leo Liu <sdl.web@gmail.com>
6716 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6717 Move to minibuffer.el.
6719 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6721 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6722 The following patches are for when GLYPH_DEBUG && !XASSERT.
6723 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6724 * dispnew.c (flush_stdout):
6725 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6726 Mark as externally visible.
6727 * dispnew.c (check_window_matrix_pointers): Now static.
6728 * dispnew.c (window_to_frame_vpos):
6729 * xfns.c (unwind_create_frame):
6730 * xterm.c (x_check_font): Remove unused local.
6731 * scroll.c (CHECK_BOUNDS):
6732 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6733 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6734 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6735 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6736 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6738 (debug_method_add): Use va_list and vsprintf rather than relying
6739 on undefined behavior with wrong number of arguments.
6740 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6741 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6742 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6743 since we're not interested in debugging glyphs with old libraries.
6744 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6745 GCC 4.6.0's static checking.
6747 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6749 Integer overflow and signedness fixes (Bug#8873).
6750 A few related buffer overrun fixes, too.
6752 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6754 * dispextern.h (struct face.stipple):
6755 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6756 (x_bitmap_mask, x_allocate_bitmap_record)
6757 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6758 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6759 (x_create_bitmap_from_xpm_data):
6760 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6761 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6763 * xfaces.c (load_pixmap):
6764 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6765 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6766 (.bitmaps_last, struct x_output.icon_bitmap):
6767 Use ptrdiff_t, not int, for bitmap indexes.
6768 (x_allocate_bitmap_record): Check for size overflow.
6769 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6771 Use ptrdiff_t, not int, for overlay counts.
6772 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6773 * editfns.c (overlays_around, get_pos_property):
6774 * textprop.c (get_char_property_and_overlay):
6775 * xdisp.c (next_overlay_change, note_mouse_highlight):
6776 * xfaces.c (face_at_buffer_position):
6777 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6778 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6779 (Fnext_overlay_change, Fprevious_overlay_change)
6780 (mouse_face_overlay_overlaps, Foverlays_in):
6781 Use ptrdiff_t, not int, for sizes.
6782 (overlays_at, overlays_in): Check for size-calculation overflow.
6784 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6786 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6787 (x_session_initialize): Do not assume string length fits in int.
6789 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6790 This is unlikely, but can occur if DPI is outlandish.
6792 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6793 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6795 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6796 * xrdb.c (magic_file_p, search_magic_path):
6797 Omit last arg SUFFIX; it was always 0. All callers changed.
6798 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6800 * xfont.c (xfont_match): Avoid need for strlen.
6802 * xfns.c: Don't assume strlen fits in int.
6803 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6805 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6806 not unsigned long, as we prefer signed integers. All callers changed.
6807 Detect integer overflow in repeat count.
6808 (message_dolog): Don't assume print length fits in 39 bytes.
6809 (display_mode_element): Don't assume strlen fits in int.
6811 * termcap.c: Don't assume sizes fit in int and never overflow.
6812 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6813 (gobble_line): Check for size-calculation overflow.
6815 * minibuf.c (Fread_buffer):
6816 * lread.c (intern, intern_c_string):
6817 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6818 Don't assume string length fits in int.
6820 * keyboard.c (parse_tool_bar_item):
6821 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6823 * font.c: Don't assume string length fits in int.
6824 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6825 Use ptrdiff_t, not int.
6826 (font_intern_prop): Don't assume string length fits in int.
6827 Don't assume integer property fits in fixnum.
6828 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6830 * filelock.c: Fix some buffer overrun and integer overflow issues.
6831 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6832 Reformulate so as not to need the command string.
6833 Invoke gzip -cd rather than gunzip, as it's more portable.
6834 (lock_info_type, lock_file_1, lock_file):
6835 Don't assume pid_t and time_t fit in unsigned long.
6836 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6837 (current_lock_owner): Prefer signed type for sizes.
6838 Use memcpy, not strncpy, where memcpy is what is really wanted.
6839 Don't assume (via atoi) that time_t and pid_t fit in int.
6840 Check for time_t and/or pid_t out of range, e.g., via a network share.
6841 Don't alloca where an auto var works fine.
6843 * fileio.c: Fix some integer overflow issues.
6844 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6845 Don't assume string length fits in int.
6846 (directory_file_name): Don't assume string length fits in long.
6847 (make_temp_name): Don't assume pid fits in int, or that its print
6848 length is less than 20.
6850 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6852 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6854 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6856 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6857 We prefer signed integers, even for size calculations.
6859 * emacs.c: Don't assume string length fits in 'int'.
6860 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6861 (main): Don't invoke strlen when not needed.
6863 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6864 (XD_DEBUG_MESSAGE): Don't waste a byte.
6866 * callproc.c (getenv_internal_1, getenv_internal)
6868 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6870 * lread.c (invalid_syntax): Omit length argument.
6871 All uses changed. This doesn't fix a bug, but it simplifies the
6872 code away from its former Hollerith-constant appearance, and it's
6873 one less 'int' to worry about when looking at integer-overflow issues.
6874 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6876 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6877 This didn't break anything, but it didn't help either.
6878 It's confusing to put a bogus integer in a place where the actual
6879 value does not matter.
6880 (LIST_END_P): Remove unused macro and its bogus comment.
6881 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6883 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6884 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6886 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6887 We prefer signed types, and the value cannot exceed the EMACS_INT
6888 range anyway (because otherwise the length would not be representable).
6889 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6890 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6891 This avoids a GCC warning when WIDE_EMACS_INT.
6893 * indent.c (sane_tab_width): New function.
6894 (current_column, scan_for_column, Findent_to, position_indentation)
6895 (compute_motion): Use it. This is just for clarity.
6896 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6898 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6900 * lisp.h (lint_assume): New macro.
6901 * composite.c (composition_gstring_put_cache):
6902 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6904 * editfns.c, insdel.c:
6905 Omit unnecessary forward decls, to simplify future changes.
6907 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6909 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6911 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6912 Use much-faster test for byte-length change.
6913 Don't assume string byte-length fits in 'int'.
6914 Check that character arg fits in 'int'.
6915 (mapcar1): Declare byte as byte, for clarity.
6917 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6919 * fns.c (concat): Catch string overflow earlier.
6920 Do not rely on integer wraparound.
6922 * dispextern.h (struct it.overlay_strings_charpos)
6923 (struct it.selective): Now EMACS_INT, not int.
6924 * xdisp.c (forward_to_next_line_start)
6925 (back_to_previous_visible_line_start)
6926 (reseat_at_next_visible_line_start, next_element_from_buffer):
6927 Don't arbitrarily truncate the value of 'selective' to int.
6929 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6931 * composite.c: Don't truncate sizes to 'int'.
6932 (composition_gstring_p, composition_reseat_it)
6933 (composition_adjust_point): Use EMACS_INT, not int.
6934 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6935 not EMACS_UINT, for indexes.
6937 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6939 * buffer.c: Include <verify.h>.
6940 (struct sortvec.priority, struct sortstr.priority):
6941 Now EMACS_INT, not int.
6942 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6943 (struct sortstr.size, record_overlay_string)
6944 (struct sortstrlist.size, struct sortlist.used):
6945 Don't truncate size to int.
6946 (record_overlay_string): Check for size-calculation overflow.
6947 (init_buffer_once): Check at compile-time, not run-time.
6949 2011-06-22 Jim Meyering <meyering@redhat.com>
6951 Don't leak an XBM-image-sized buffer
6952 * image.c (xbm_load): Free the image buffer after using it.
6954 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6957 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6958 that Sun C diagnosed.
6959 * fns.c (secure_hash): Fix pointer signedness issue.
6960 * intervals.c (static_offset_intervals): New function.
6961 (offset_intervals): Use it.
6963 2011-06-21 Leo Liu <sdl.web@gmail.com>
6966 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6969 * fns.c (secure_hash): Rename from crypto_hash_function and change
6970 the first arg to accept symbols.
6971 (Fsecure_hash): New primitive.
6972 (syms_of_fns): New symbols.
6974 2011-06-20 Deniz Dogan <deniz@dogan.se>
6976 * process.c (Fset_process_buffer): Clarify return value in
6979 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6981 * dispnew.c (add_window_display_history): Use BVAR.
6983 * xdisp.c (debug_method_add): Use BVAR.
6984 (check_window_end, dump_glyph_matrix, dump_glyph)
6985 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6987 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6990 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6991 check till after the cache is created in init_frame_faces.
6993 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6995 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6997 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6999 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7000 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7001 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7003 Improve buffer-overflow checking (Bug#8873).
7004 * fileio.c (Finsert_file_contents):
7005 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7006 Remove the old (too-loose) buffer overflow checks.
7007 They weren't needed, since make_gap checks for buffer overflow.
7008 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7009 The old code merely checked for Emacs fixnum overflow, and relied
7010 on undefined (wraparound) behavior. The new code avoids undefined
7011 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7013 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7014 Tune. Don't use wider integers than needed. Don't use alloca.
7015 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7017 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7019 * insdel.c, lisp.h (buffer_overflow): New function.
7020 (insert_from_buffer_1, replace_range, replace_range_2):
7021 * insdel.c (make_gap_larger):
7022 * editfns.c (Finsert_char):
7023 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7025 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7027 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7029 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7031 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7032 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7034 * fileio.c: Don't assume EMACS_INT fits in off_t.
7035 (emacs_lseek): New static function.
7036 (Finsert_file_contents, Fwrite_region): Use it.
7037 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7039 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7041 * fns.c: Don't overflow int when computing a list length.
7042 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7043 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7044 truncation on 64-bit hosts. Check for QUIT every
7045 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7046 faster and is responsive enough.
7047 (Flength): Report an error instead of overflowing an integer.
7048 (Fsafe_length): Return a float if the value is not representable
7049 as a fixnum. This shouldn't happen except in contrived situations.
7050 (Fnthcdr, Fsort): Don't assume list length fits in int.
7051 (Fcopy_sequence): Don't assume vector length fits in int.
7053 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7054 (header_size, word_size): New constants.
7055 (allocate_vectorlike): Don't check size overflow here.
7056 (allocate_vector): Check it here instead, since this is the only
7057 caller of allocate_vectorlike that could cause overflow.
7058 Check that the new vector's length is representable as a fixnum.
7060 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7061 The previous code was bogus. For example, next_almost_prime (32)
7062 returned 39, which is undesirable as it is a multiple of 3; and
7063 next_almost_prime (24) returned 25, which is a multiple of 5 so
7064 why was the code bothering to check for multiples of 7?
7066 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7068 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7070 Variadic C functions now count arguments with ptrdiff_t.
7071 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7072 Back then I didn't know that the Emacs coding style prefers signed int.
7073 Also, in the meantime I found a few more instances where arguments
7074 were being counted with int, which may truncate counts on 64-bit
7075 machines, or EMACS_INT, which may be unnecessarily wide.
7076 * lisp.h (struct Lisp_Subr.function.aMANY)
7077 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7078 Arg counts are now ptrdiff_t, not size_t.
7079 All variadic functions and their callers changed accordingly.
7080 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7081 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7082 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7083 * callint.c (Fcall_interactively): Check arg count for overflow,
7084 to avoid potential buffer overrun. Use signed char, not 'int',
7085 for 'varies' array, so that we needn't bother to check its size
7086 calculation for overflow.
7087 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7088 * eval.c (apply_lambda):
7089 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7090 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7091 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7093 * callint.c (Fcall_interactively): Don't use index var as event count.
7095 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7096 * mem-limits.h (SIZE): Remove; no longer used.
7098 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7100 Remove unnecessary casts.
7101 * xterm.c (x_term_init):
7102 * xfns.c (x_set_border_pixel):
7103 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7104 These aren't needed now that we assume ANSI C.
7106 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7107 It's more likely to cause problems (due to unsigned overflow)
7110 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7112 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7114 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7116 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7118 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7120 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7122 GLYPH_CODE_FACE returns EMACS_INT, not int.
7123 * dispextern.h (merge_faces):
7124 * xfaces.c (merge_faces):
7125 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7126 Don't assume EMACS_INT fits in int.
7128 * character.h (CHAR_VALID_P): Remove unused parameter.
7129 * fontset.c, lisp.h, xdisp.c: All uses changed.
7131 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7133 * fns.c (concat): Minor tuning based on overflow analysis.
7134 This doesn't fix any bugs. Use int to hold character, instead
7135 of constantly refetching from Emacs object. Use XFASTINT, not
7136 XINT, for value known to be a character. Don't bother comparing
7137 a single byte to 0400, as it's always less.
7139 * floatfns.c (Fexpt):
7140 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7142 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7145 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7147 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7148 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7149 incorrectly succeed when S was a string, because 4294967386 was
7150 truncated before it was used.
7152 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7153 Otherwise, an out-of-range integer could cause undefined behavior
7156 * composite.c: Use int, not EMACS_INT, for characters.
7157 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7158 EMACS_INT, for values that are known to be in character range.
7159 This doesn't fix any bugs but is the usual style inside Emacs and
7160 may generate better code on 32-bit machines.
7162 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7163 This is for reasons similar to the recent CHAR_STRING fix.
7164 * charset.c (Fencode_char): Check that character arg is actually
7165 a character. Pass an int to ENCODE_CHAR.
7166 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7167 wider than 'int', as a compile-time check to prevent future regressions
7170 * character.c (char_string): Remove unnecessary casts.
7172 Make sure a 64-bit char is never passed to CHAR_STRING.
7173 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7174 by silently ignoring the top 32 bits, allowing some values
7175 that were far too large to be valid characters.
7176 * character.h: Include <verify.h>.
7177 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7178 arguments are no wider than unsigned, as a compile-time check
7179 to prevent future regressions in this area.
7181 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7182 (Fsubst_char_in_region):
7184 * xdisp.c (decode_mode_spec_coding):
7185 Adjust to CHAR_STRING's new requirement.
7186 * editfns.c (Finsert_char, Fsubst_char_in_region):
7187 * fns.c (concat): Check that character args are actually
7188 characters. Without this test, these functions did the wrong
7189 thing with wildly out-of-range values on 64-bit hosts.
7191 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7192 These casts should not be needed on 32-bit hosts, either.
7193 * keyboard.c (read_char):
7194 * lread.c (Fload): Remove casts to unsigned.
7196 * lisp.h (UNSIGNED_CMP): New macro.
7197 This fixes comparison bugs on 64-bit hosts.
7198 (ASCII_CHAR_P): Use it.
7199 * casefiddle.c (casify_object):
7200 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7201 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7202 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7203 * dispextern.h (FACE_FROM_ID):
7204 * keyboard.c (read_char): Use UNSIGNED_CMP.
7206 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7207 not to EMACS_INT, to avoid GCC warning.
7209 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7211 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7212 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7213 isn't needed on 32-bit machines.
7215 * buffer.c (Fgenerate_new_buffer_name):
7216 Use EMACS_INT for count, not int.
7217 (advance_to_char_boundary): Return EMACS_INT, not int.
7219 * data.c (Qcompiled_function): Now static.
7221 * window.c (window_body_lines): Now static.
7223 * image.c (gif_load): Rename local to avoid shadowing.
7225 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7226 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7227 * alloc.c (make_save_value): Integer argument is now of type
7229 (mark_object): Use ptrdiff_t, not int.
7230 * lisp.h (pD): New macro.
7231 * print.c (print_object): Use it.
7233 * alloc.c: Use EMACS_INT, not int, to count objects.
7234 (total_conses, total_markers, total_symbols, total_vector_size)
7235 (total_free_conses, total_free_markers, total_free_symbols)
7236 (total_free_floats, total_floats, total_free_intervals)
7237 (total_intervals, total_strings, total_free_strings):
7238 Now EMACS_INT, not int. All uses changed.
7239 (Fgarbage_collect): Compute overall total using a double, so that
7240 integer overflow is less likely to be a problem. Check for overflow
7241 when converting back to an integer.
7242 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7243 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7244 These were 'int' variables that could overflow on 64-bit hosts;
7245 they were never used, so remove them instead of repairing them.
7246 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7247 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7248 Previously, this ceilinged at INT_MAX, but that doesn't work on
7250 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7252 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7253 (allocate_vectorlike): Check for ptrdiff_t overflow.
7254 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7255 when a (possibly-narrower) signed value would do just as well.
7256 We prefer using signed arithmetic, to avoid comparison confusion.
7258 * alloc.c: Catch some string size overflows that we were missing.
7259 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7260 for convenience in STRING_BYTES_MAX.
7261 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7262 The definition here is exact; the one in lisp.h was approximate.
7263 (allocate_string_data): Check for string overflow. This catches
7264 some instances we weren't catching before. Also, it catches
7265 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7266 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7267 and ptrdiff_t and EMACS_INT are both 64 bits.
7269 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7270 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7271 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7273 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7275 * alloc.c (Fmake_string): Check for out-of-range init.
7277 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7279 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7281 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7283 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7284 xg_get_default_scrollbar_width.
7286 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7287 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7288 (style_changed_cb): Call update_theme_scrollbar_width and call
7289 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7290 all frames (Bug#8505).
7291 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7292 Call gtk_window_set_resizable if HAVE_GTK3.
7293 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7294 and height if HAVE_GTK3 (Bug#8505).
7295 (scroll_bar_width_for_theme): New variable.
7296 (update_theme_scrollbar_width): New function.
7297 (xg_get_default_scrollbar_width): Move code to
7298 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7299 (xg_initialize): Call update_theme_scrollbar_width.
7301 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7303 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7305 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7307 * frame.c (make_frame): Call other_buffer_safely instead of
7310 * window.c (temp_output_buffer_show): Call display_buffer with
7311 second argument Vtemp_buffer_show_specifiers and reset latter
7312 immediately after the call.
7313 (Vtemp_buffer_show_specifiers): New variable.
7314 (auto_window_vscroll_p, next_screen_context_lines)
7315 (Vscroll_preserve_screen_position): Remove leading asterisks from
7318 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7320 Fix minor problems found by GCC 4.6.0 static checking.
7321 * buffer.c (Qclone_number): Remove for now, as it's unused.
7322 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7323 (record_buffer): Remove unused local.
7324 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7325 (set_frame_buffer_list): Remove; unused.
7326 * frame.h (other_visible_frames): Remove decl.
7327 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7328 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7329 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7331 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7332 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7333 Define only if HAVE_GPM.
7334 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7335 (update_hints_inhibit): Remove; never set. All uses removed.
7336 * widgetprv.h (emacsFrameClassRec): Remove decl.
7337 * window.c (delete_deletable_window): Now returns void, since it
7338 wasn't returning anything.
7339 (compare_window_configurations): Remove unused locals.
7340 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7341 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7342 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7343 the same widths as pointers. This follows up on the 2011-05-06 patch.
7344 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7345 * xterm.h: Likewise.
7346 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7348 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7350 * makefile.w32-in: Update dependencies.
7351 (LISP_H): Add lib/intprops.h.
7353 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7355 * image.c (gif_load): Add animation frame delay to the metadata.
7356 (syms_of_image): Use DEFSYM. New symbol `delay'.
7358 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7360 * window.c (delete_deletable_window): Re-add.
7361 (Fset_window_configuration): Rewrite to handle dead buffers and
7362 consequently deletable windows.
7363 (window_tree, Fwindow_tree): Remove. Supply functionality in
7365 (compare_window_configurations): Simplify code.
7367 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7369 * image.c (imagemagick_load_image): Fix type mismatch.
7370 (Fimagemagick_types): Likewise.
7372 * window.h (replace_buffer_in_windows): Declare.
7374 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7376 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7377 Qclone_number. Remove external declaration of Qdelete_window.
7378 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7380 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7381 Run Qbuffer_list_update_hook if allowed.
7382 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7383 buffer list implementation.
7384 (other_buffer_safely): New function.
7385 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7386 calls to replace_buffer_in_windows and
7387 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7389 (record_buffer): Inhibit quitting and rewrite using quittable
7390 functions. Run Qbuffer_list_update_hook if allowed.
7391 (Frecord_buffer, Funrecord_buffer): New functions.
7392 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7393 Move switch-to-buffer to window.el.
7394 (bury-buffer): Move to window.el.
7395 (Vbuffer_list_update_hook): New variable.
7397 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7400 * window.h (resize_frame_windows): Move up in code.
7401 (Fwindow_frame): Remove EXFUN.
7402 (replace_buffer_in_all_windows): Remove prototype.
7403 (replace_buffer_in_windows_safely): Add prototype.
7405 * window.c: Declare Qdelete_window static again. Move down
7406 declaration of select_count.
7407 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7408 (Fother_window): Move to window.el.
7409 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7410 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7411 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7413 (replace_buffer_in_windows): Implement by calling
7414 Qreplace_buffer_in_windows.
7415 (replace_buffer_in_all_windows): Remove with some functionality
7416 moved into replace_buffer_in_windows_safely.
7417 (replace_buffer_in_windows_safely): New function.
7418 (select_window_norecord, select_frame_norecord): Move in front
7419 of run_window_configuration_change_hook. Remove now obsolete
7421 (Fset_window_buffer): Rewrite doc-string.
7422 Call Qrecord_window_buffer.
7423 (keys_of_window): Move binding for other-window to window.el.
7425 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7427 * dispextern.h (struct image): Replace data member, whose int_val
7428 and ptr_val fields were not used by anything, with a single
7431 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7432 (gif_clear_image, gif_load, imagemagick_load_image)
7433 (gs_clear_image, gs_load): Callers changed.
7435 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7437 * buffer.h: Include <time.h>, for time_t.
7438 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7440 Fix minor problems found by static checking.
7442 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7444 Make identifiers static if they are not used in other modules.
7445 * data.c (Qcompiled_function, Qframe, Qvector):
7446 * image.c (QimageMagick, Qsvg):
7447 * minibuf.c (Qmetadata):
7448 * window.c (resize_window_check, resize_root_window): Now static.
7449 * window.h (resize_window_check, resize_root_window): Remove decls.
7451 * window.c (window_deletion_count, delete_deletable_window):
7453 (window_body_lines): Now static.
7454 (Fdelete_other_windows_internal): Mark vars as initialized.
7455 Make sure 'resize_failed' is initialized.
7456 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7457 (resize_window_apply): Remove unused local.
7458 * window.h (delete_deletable_window): Remove decl.
7460 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7461 (imagemagick_load_image): Fix pointer signedness problem by changing
7462 last arg from unsigned char * to char *. All uses changed.
7463 Also, fix a local for similar reasons.
7464 Remove unused locals. Remove locals to avoid shadowing.
7465 (fn_rsvg_handle_free): Remove; unused.
7466 (svg_load, svg_load_image): Fix pointer signedness problem.
7467 (imagemagick_load_image): Don't use garbage pointer image_wand.
7469 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7471 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7473 * image.c (gif_load): Fix omitted cast error introduced by
7476 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7478 * window.h (resize_proportionally, orig_total_lines)
7479 (orig_top_line): Remove from window structure.
7480 (set_window_height, set_window_width, change_window_heights)
7481 (Fdelete_window): Remove prototypes.
7482 (resize_frame_windows): Remove duplicate declaration.
7484 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7486 * window.h (resize_frame_windows, resize_window_check)
7487 (delete_deletable_window, resize_root_window)
7488 (resize_frame_windows): Declare prototypes.
7490 * window.c (resize_window_apply): Make definition be "static" to
7491 match the prototype.
7493 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7495 * window.c: Remove declarations of Qwindow_size_fixed,
7496 window_min_size_1, window_min_size_2, window_min_size,
7497 size_window, window_fixed_size_p, enlarge_window, delete_window.
7498 Remove static from declaration of Qdelete_window, it's
7499 temporarily needed by Fbury_buffer.
7500 (replace_window): Don't assign orig_top_line and
7502 (Fdelete_window, delete_window): Remove. Window deletion is
7503 handled by window.el.
7504 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7505 Replace Fdelete_window calls with calls to Qdelete_window.
7506 (Fdelete_other_windows): Remove. Deleting other windows is
7507 handled by window.el.
7508 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7509 handled in window.el.
7510 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7511 Window minimum sizes are handled in window.el.
7512 (shrink_windows, size_window, set_window_height)
7513 (set_window_width, change_window_heights, window_height)
7514 (window_width, CURBEG, CURSIZE, enlarge_window)
7515 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7516 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7517 handled in window.el.
7518 (make_dummy_parent): Rename to make_parent_window and give it a
7519 second argument horflag.
7520 (make_window): Don't set resize_proportionally any more.
7521 (Fsplit_window): Remove. Windows are split in window.el.
7522 (save_restore_action, save_restore_orig_size)
7523 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7524 Resize mini windows in window.el.
7525 (grow_mini_window, shrink_mini_window): Implement by calling
7526 Qresize_root_window_vertically, resize_window_check and
7527 resize_window_apply.
7528 (saved_window, Fset_window_configuration, save_window_save):
7529 Do not handle orig_top_line, orig_total_lines, and
7530 resize_proportionally.
7531 (window_min_height, window_min_width): Move to window.el.
7532 (keys_of_window): Move bindings for delete-other-windows,
7533 split-window, delete-window and enlarge-window to window.el.
7535 * buffer.c: Temporarily extern Qdelete_window.
7536 (Fbury_buffer): Temporarily call Qdelete_window instead of
7537 Fdelete_window (Fbury_buffer will move to window.el soon).
7539 * frame.c (set_menu_bar_lines_1): Remove code handling
7540 orig_top_line and orig_total_lines.
7542 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7543 set_window_height but set heights directly.
7544 (change_frame_size_1): Use resize_frame_windows.
7546 * xdisp.c (init_xdisp): Don't use set_window_height but set
7549 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7550 Use resize_frame_windows instead of change_window_heights and run
7551 run_window_configuration_change_hook.
7553 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7554 instead of change_window_heights and run
7555 run_window_configuration_change_hook.
7557 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7559 * window.c (replace_window): Rename second argument REPLACEMENT to
7560 NEW. New third argument SETFLAG. Rewrite.
7561 (delete_window, make_dummy_parent): Call replace_window with
7563 (window_list_1): Move down in code.
7564 (run_window_configuration_change_hook): Move set_buffer part
7565 before select_frame_norecord part in order to unwind correctly.
7566 Rename count1 to count.
7567 (recombine_windows, delete_deletable_window, resize_root_window)
7568 (Fdelete_other_windows_internal)
7569 (Frun_window_configuration_change_hook, make_parent_window)
7570 (resize_window_check, resize_window_apply, Fresize_window_apply)
7571 (resize_frame_windows, Fsplit_window_internal)
7572 (Fdelete_window_internal, Fresize_mini_window_internal):
7574 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7576 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7578 * window.h (window): Add some new members to window structure -
7579 normal_lines, normal_cols, new_total, new_normal, clone_number,
7580 splits, nest, prev_buffers, next_buffers.
7581 (WINDOW_TOTAL_SIZE): Move here from window.c.
7582 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7584 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7586 (make_dummy_parent): Set new members of windows structure.
7587 (make_window): Move down in code. Handle new members of window
7589 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7590 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7591 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7592 (Fset_window_prev_buffers, Fwindow_next_buffers)
7593 (Fset_window_next_buffers, Fset_window_clone_number):
7595 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7596 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7598 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7599 Argument WINDOW can be now internal window too.
7600 (Fwindow_use_time): Move up in code.
7601 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7603 (Fset_window_configuration, saved_window)
7604 (Fcurrent_window_configuration, save_window_save): Handle new
7605 members of window structure.
7606 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7607 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7608 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7609 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7610 Qget_mru_window, Qresize_root_window,
7611 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7612 Qauto_buffer_name; staticpro them.
7614 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7616 * window.c (Fwindow_total_size, Fwindow_left_column)
7617 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7618 (Fwindow_list_1): New functions.
7619 (window_box_text_cols): Replace with window_body_cols.
7620 (Fwindow_width, Fscroll_left, Fscroll_right):
7621 Use window_body_cols instead of window_box_text_cols.
7622 (delete_window, Fset_window_configuration):
7623 Call delete_all_subwindows with window as argument.
7624 (delete_all_subwindows): Take a window as argument and not a
7626 (window_loop): Remove handling of GET_LRU_WINDOW and
7628 (Fget_lru_window, Fget_largest_window): Move to window.el.
7630 * window.h: Extern window_body_cols instead of
7631 window_box_text_cols. delete_all_subwindows now takes a
7632 Lisp_Object as argument.
7634 * indent.c (compute_motion, Fcompute_motion):
7635 Use window_body_cols instead of window_box_text_cols.
7637 * frame.c (delete_frame): Call delete_all_subwindows with root
7640 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7642 * fns.c (Fputhash): Document return value.
7644 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7646 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7648 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7650 Cons<->int and similar integer overflow fixes (Bug#8794).
7652 Check for overflow when converting integer to cons and back.
7653 * charset.c (Fdefine_charset_internal, Fdecode_char):
7654 Use cons_to_unsigned to catch overflow.
7655 (Fencode_char): Use INTEGER_TO_CONS.
7656 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7657 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7658 * data.c (long_to_cons, cons_to_long): Remove.
7659 (cons_to_unsigned, cons_to_signed): New functions.
7660 These signal an error for invalid or out-of-range values.
7661 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7662 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7663 * font.c (Ffont_variation_glyphs):
7664 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7665 * lisp.h: Include <intprops.h>.
7666 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7667 (cons_to_signed, cons_to_unsigned): New decls.
7668 (long_to_cons, cons_to_long): Remove decls.
7669 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7670 (Fprimitive_undo): Use CONS_TO_INTEGER.
7671 * xfns.c (Fx_window_property): Likewise.
7672 * xselect.c: Include <limits.h>.
7673 (x_own_selection, selection_data_to_lisp_data):
7674 Use INTEGER_TO_CONS.
7675 (x_handle_selection_request, x_handle_selection_clear)
7676 (x_get_foreign_selection, Fx_disown_selection_internal)
7677 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7678 (lisp_data_to_selection_data): Use cons_to_unsigned.
7679 (x_fill_property_data): Use cons_to_signed.
7680 Report values out of range.
7682 Check for buffer and string overflow more precisely.
7683 * buffer.h (BUF_BYTES_MAX): New macro.
7684 * lisp.h (STRING_BYTES_MAX): New macro.
7685 * alloc.c (Fmake_string):
7686 * character.c (string_escape_byte8):
7687 * coding.c (coding_alloc_by_realloc):
7688 * doprnt.c (doprnt):
7689 * editfns.c (Fformat):
7691 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7692 since they may not be the same number.
7693 * editfns.c (Finsert_char):
7694 * fileio.c (Finsert_file_contents):
7695 Likewise for BUF_BYTES_MAX.
7697 * image.c: Use ptrdiff_t, not int, for sizes.
7698 (slurp_file): Switch from int to ptrdiff_t.
7700 (slurp_file): Check that file size fits in both size_t (for
7701 malloc) and ptrdiff_t (for sanity and safety).
7703 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7704 if b->modtime has its maximal value.
7706 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7708 Don't assume time_t can fit into int.
7709 * buffer.h (struct buffer.modtime): Now time_t, not int.
7710 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7711 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7713 Minor fixes for signed vs unsigned integers.
7714 * character.h (MAYBE_UNIFY_CHAR):
7715 * charset.c (maybe_unify_char):
7716 * keyboard.c (read_char, reorder_modifiers):
7717 XINT -> XFASTINT, since the integer must be nonnegative.
7718 * ftfont.c (ftfont_spec_pattern):
7719 * keymap.c (access_keymap, silly_event_symbol_error):
7720 XUINT -> XFASTINT, since the integer must be nonnegative.
7721 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7722 since it makes no difference and we prefer signed.
7723 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7724 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7727 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7729 * window.h (Fwindow_frame): Declare.
7731 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7733 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7734 (SPARE_MEMORY): Always define.
7735 (LARGE_REQUEST): Remove.
7736 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7738 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7740 * lisp.h: Move EXFUNS for Fframe_root_window,
7741 Fframe_first_window and Fset_frame_selected_window to window.h.
7743 * window.h: Move EXFUNS for Fframe_root_window,
7744 Fframe_first_window and Fset_frame_selected_window here from
7747 * frame.c (Fwindow_frame, Fframe_first_window)
7748 (Fframe_root_window, Fframe_selected_window)
7749 (Fset_frame_selected_window): Move to window.c.
7750 (Factive_minibuffer_window): Move to minibuf.c.
7751 (Fother_visible_frames_p): New function.
7753 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7755 * window.c (decode_window, decode_any_window): Move up in code.
7756 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7757 (inhibit_frame_unsplittable): Remove unused variable.
7758 (Fwindow_buffer): Move up and rewrite doc-string.
7759 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7760 (Fwindow_prev): New functions.
7761 (Fwindow_frame): Move here from frame.c. Accept any window as
7763 (Fframe_root_window, Fframe_first_window)
7764 (Fframe_selected_window): Move here from frame.c. Accept frame
7765 or arbitrary window as argument. Update doc-strings.
7766 (Fminibuffer_window): Move up in code.
7767 (Fwindow_minibuffer_p): Move up in code and simplify.
7768 (Fset_frame_selected_window): Move here from frame.c.
7770 (Fselected_window, select_window, Fselect_window): Move up in
7771 code. Minor doc-string fixes.
7773 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7775 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7776 Do not assume that spare memory exists; that assumption is valid
7777 only if SYSTEM_MALLOC.
7778 (LARGE_REQUEST): New macro, so that the issue of large requests
7779 is separated from the issue of spare memory.
7781 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7783 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7786 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7788 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7791 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7793 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7795 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7797 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7798 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7800 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7802 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7804 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7806 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7807 (x_clipboard_manager_save): Add return value.
7808 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7810 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7811 Obey Vx_select_enable_clipboard_manager. Catch errors in
7812 x_clipboard_manager_save (Bug#8779).
7813 (Vx_select_enable_clipboard_manager): New variable.
7814 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7816 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7818 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7820 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7822 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7823 in the current matrix if keep_current_p is non-zero.
7825 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7827 * bidi.c (bidi_level_of_next_char): Fix last change.
7829 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7831 Support bidi reordering of text covered by display properties.
7833 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7834 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7835 (bidi_cache_search, bidi_cache_iterator_state)
7836 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7837 (bidi_level_of_next_char, bidi_move_to_visually_next):
7838 Support character positions inside a run of characters covered by a
7840 (bidi_paragraph_init, bidi_resolve_explicit_1)
7841 (bidi_level_of_next_char): Call bidi_fetch_char and
7842 bidi_fetch_char_advance instead of FETCH_CHAR and
7844 (bidi_init_it): Initialize new members.
7845 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7847 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7848 instead of using explicit *_CHAR codes.
7849 (bidi_resolve_explicit, bidi_resolve_weak):
7850 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7851 bidirectional text is supported only in multibyte buffers.
7852 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7853 it to initialize the frame_window_p member of struct bidi_it.
7854 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7855 (bidi_resolve_explicit, bidi_resolve_weak)
7856 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7857 bidi_it->nchars is non-positive.
7858 (bidi_level_of_next_char): Don't try to lookup the cache for the
7859 next/previous character if nothing is cached there yet, or if we
7860 were just reseat()'ed to a new position.
7862 * xdisp.c (set_cursor_from_row): Set start and stop points
7863 according to the row's direction when priming the loop that looks
7864 for the glyph on which to display cursor.
7865 (single_display_spec_intangible_p): Function deleted.
7866 (display_prop_intangible_p): Reimplement to call
7867 handle_display_spec instead of single_display_spec_intangible_p.
7868 Accept 3 additional arguments needed by handle_display_spec.
7869 This fixes incorrect cursor motion across display property with complex
7870 values: lists, `(when COND...)' forms, etc.
7871 (single_display_spec_string_p): Support property values that are
7872 lists with the argument STRING its top-level element.
7873 (display_prop_string_p): Fix the condition for processing a
7874 property that is a list to be consistent with handle_display_spec.
7875 (handle_display_spec): New function, refactored from the
7876 last portion of handle_display_prop.
7877 (compute_display_string_pos): Accept additional argument
7878 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7879 value of a `display' property is a "replacing spec".
7880 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7881 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7882 the display property, but just return a value indicating whether
7883 the display property will replace the characters it covers.
7884 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7885 frame_window_p members of struct bidi_it.
7886 (compute_display_string_pos, compute_display_string_end):
7888 (push_it): Accept second argument POSITION, where pop_it should
7889 jump to continue iteration.
7890 (reseat_1): Initialize bidi_it.disp_pos.
7892 * keyboard.c (adjust_point_for_property): Adjust the call to
7893 display_prop_intangible_p to its new signature.
7895 * dispextern.h (struct bidi_it): New member frame_window_p.
7896 (bidi_init_it): Update prototypes.
7897 (display_prop_intangible_p): Update prototype.
7898 (compute_display_string_pos, compute_display_string_end):
7900 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7903 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7905 Malloc failure behavior now depends on size of allocation.
7906 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7907 * lisp.h: Change signatures accordingly.
7908 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7909 All callers changed. (Bug#8762)
7911 * gnutls.c: Use Emacs's memory allocators.
7912 Without this change, the gnutls library would invoke malloc etc.
7913 directly, which causes problems on non-SYNC_INPUT hosts, and which
7914 runs afoul of improving memory_full behavior. (Bug#8761)
7915 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7916 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7917 xfree instead of the default malloc, realloc, free.
7918 (Fgnutls_boot): No need to check for memory allocation failure,
7919 since xmalloc does that for us.
7921 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7922 * category.c (hash_get_category_set):
7923 * ccl.c (ccl_driver):
7924 * charset.c (Fdefine_charset_internal):
7925 * charset.h (struct charset.hash_index):
7926 * composite.c (get_composition_id, gstring_lookup_cache)
7927 (composition_gstring_put_cache):
7928 * composite.h (struct composition.hash_index):
7929 * dispextern.h (struct image.hash):
7930 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7931 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7932 (hashfn_equal, hashfn_user_defined, make_hash_table)
7933 (maybe_resize_hash_table, hash_lookup, hash_put)
7934 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7935 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7936 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7937 * image.c (make_image, search_image_cache, lookup_image)
7938 (xpm_put_color_table_h):
7939 * lisp.h (struct Lisp_Hash_Table):
7940 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7941 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7942 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7943 * alloc.c (allocate_vectorlike):
7944 Check for overflow in vector size calculations.
7945 * ccl.c (ccl_driver):
7946 Check for overflow when converting EMACS_INT to int.
7947 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7948 need to be updated by these changes.
7949 * fns.c (make_hash_table, maybe_resize_hash_table):
7950 Check for integer overflow with large hash tables.
7951 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7952 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7953 (SXHASH_REDUCE): New macro.
7954 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7955 Use it instead of discarding useful hash info with large hash values.
7956 (sxhash_float): New function.
7957 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7958 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7959 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7960 Rewrite to use FIXNUM_BITS, as this simplifies things.
7961 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7962 Adjust signatures to match updated version of code.
7963 (consing_since_gc): Now EMACS_INT, since a single hash table can
7964 use more than INT_MAX bytes.
7966 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7968 Make it possible to build with GCC-4.6+ -O2 -flto.
7970 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7972 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7974 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7975 Call minibuffer-inactive-mode.
7977 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7979 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7980 Update dependencies.
7982 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7984 * data.c (init_data): Remove code for UTS, this system is not
7987 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7989 Don't force ./temacs to start in terminal mode.
7991 * frame.c (make_initial_frame): Initialize faces in all cases, not
7992 only when CANNOT_DUMP is defined.
7993 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7995 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7997 * dispnew.c (add_window_display_history): Use const for the string
7998 pointer. Remove declaration, not needed.
8000 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8002 Use 'inline', not 'INLINE'.
8003 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8004 * alloc.c, fontset.c (INLINE): Remove.
8005 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8006 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8007 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8008 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8009 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8011 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8013 Make it possible to run ./temacs.
8015 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8016 syms_of_callproc does the same thing. Remove test for
8017 "initialized", do it in the caller.
8018 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8020 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8022 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8023 (read_minibuf): Use get_minibuffer.
8024 (syms_of_minibuf): Use DEFSYM.
8025 (Qmetadata): New var.
8026 * data.c (Qbuffer): Don't make it static.
8027 (syms_of_data): Use DEFSYM.
8029 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8031 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8032 (CCL_CODE_MIN): New macro.
8034 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8036 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8038 * eval.c (Qdebug): Now static.
8039 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8040 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8041 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8043 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8045 * image.c: Various fixes to ImageMagick code comments.
8046 (Fimagemagick_types): Doc fix.
8048 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8050 Minor fixes prompted by GCC 4.6.0 warnings.
8052 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8054 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8055 (x_clipboard_manager_save_all): Move extern decl to ...
8056 * xterm.h: ... here, so that it can be checked for consistency.
8058 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8060 * xselect.c (x_clipboard_manager_save_frame)
8061 (x_clipboard_manager_save_all): New functions.
8062 (Fx_clipboard_manager_save): Lisp function deleted.
8064 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8065 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8067 * xterm.h: Update prototype.
8069 2011-05-28 William Xu <william.xwl@gmail.com>
8071 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8074 2011-05-28 Jim Meyering <meyering@redhat.com>
8076 Avoid a sign-extension bug in crypto_hash_function.
8077 * fns.c (to_uchar): Define.
8078 (crypto_hash_function): Use it to convert some newly-signed
8079 variables to unsigned, to avoid sign-extension bugs. For example,
8080 without this change, (md5 "truc") would evaluate to
8081 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8082 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8083 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8085 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8087 Integer overflow fixes.
8089 * dbusbind.c: Serial number integer overflow fixes.
8090 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8091 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8092 to hold a serial number that is too large for a fixnum.
8093 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8094 Check for serial numbers out of range. Decode any serial number
8095 that was so large that it became a float. (Bug#8722)
8097 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8098 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8099 Use XFASTINT rather than XUINT when numbers are nonnegative.
8100 (xd_append_arg, Fdbus_method_return_internal):
8101 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8102 arguments, check that Lisp number is nonnegative, rather than
8103 silently wrapping negative numbers around. (Bug#8722)
8104 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8107 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8109 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8111 ccl: Add integer overflow checks.
8112 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8113 (IN_INT_RANGE): New macros.
8114 (ccl_driver): Use them to check for integer overflow when
8115 decoding a CCL program. Many of the new checks are whether XINT (x)
8116 fits in int; it doesn't always, on 64-bit hosts. The new version
8117 doesn't catch all possible integer overflows, but it's an
8118 improvement. (Bug#8719)
8120 * alloc.c (make_event_array): Use XINT, not XUINT.
8121 There's no need for unsigned here.
8123 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8124 This follows up to the 2011-05-06 change that substituted uintptr_t
8125 for EMACS_INT. This case wasn't caught back then.
8127 Rework Fformat to avoid integer overflow issues.
8128 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8129 now (part of C89). Include <verify.h>.
8130 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8131 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8132 (Fformat): Avoid the prepass trying to compute sizes; it was only
8133 approximate and thus did not catch overflow reliably. Instead, walk
8134 through the format just once, formatting and computing sizes as we go,
8135 checking for integer overflow at every step, and allocating a larger
8136 buffer as needed. Keep track separately whether the format is
8137 multibyte. Keep only the most-recently calculated precision, rather
8138 than them all. Record whether each argument has been converted to
8139 string. Use EMACS_INT, not int, for byte and char and arg counts.
8140 Support field widths and precisions larger than INT_MAX. Avoid
8141 sprintf's undefined behavior with conversion specifications such as %#d
8142 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8143 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8144 formatting out-of-range floating point numbers with int
8147 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8149 * data.c: Avoid integer truncation in expressions involving floats.
8150 * data.c: Include <intprops.h>.
8151 (arith_driver): When there's an integer overflow in an expression
8152 involving floating point, convert the integers to floating point
8153 so that the resulting value does not suffer from catastrophic
8154 integer truncation. For example, on a 64-bit host (* 4
8155 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8156 Do not rely on undefined behavior after integer overflow.
8158 merge count_size_as_multibyte, parse_str_to_multibyte
8159 * character.c, character.h (count_size_as_multibyte):
8160 Rename from parse_str_to_multibyte; all uses changed.
8161 Check for integer overflow.
8162 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8163 since it's now a duplicate of the other. This is more of
8164 a character than a buffer op, so better that it's in character.c.
8165 * fns.c, print.c: Adjust to above changes.
8167 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8169 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8171 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8173 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8174 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8175 (x_clipboard_manager_save): Now static.
8176 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8178 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8179 (crypto_hash_function): Now static.
8180 Fix pointer signedness problems. Avoid unnecessary initializations.
8182 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8184 * termhooks.h (Vselection_alist): Make it terminal-local.
8186 * terminal.c (create_terminal): Initialize it.
8188 * xselect.c: Support for clipboard managers.
8189 (Vselection_alist): Move to termhooks.h as terminal-local var.
8190 (LOCAL_SELECTION): New macro.
8191 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8192 (symbol_to_x_atom): Remove gratuitous arg.
8193 (x_handle_selection_request, lisp_data_to_selection_data)
8194 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8195 (x_own_selection, x_get_local_selection, x_convert_selection):
8196 New arg, specifying work frame. Use terminal-local Vselection_alist.
8197 (some_frame_on_display): Delete unused function.
8198 (Fx_own_selection_internal, Fx_get_selection_internal)
8199 (Fx_disown_selection_internal, Fx_selection_owner_p)
8200 (Fx_selection_exists_p): New optional frame arg.
8201 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8202 (x_handle_selection_clear): Don't treat other terminals with the
8203 same keyboard specially. Use the terminal-local Vselection_alist.
8204 (x_clear_frame_selections): Use Frun_hook_with_args.
8206 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8208 * xterm.h: Add support for those atoms.
8210 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8212 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8213 (converted_selections, conversion_fail_tag): New global variables.
8214 (x_selection_request_lisp_error): Free the above.
8215 (x_get_local_selection): Remove unnecessary code.
8216 (x_reply_selection_request): Args changed; handle arbitrary array
8217 of converted selections stored in converted_selections.
8218 Separate the XChangeProperty and SelectionNotify steps.
8219 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8220 (x_convert_selection): New function.
8221 (x_handle_selection_event): Simplify.
8222 (x_get_foreign_selection): Don't ignore incoming requests while
8223 waiting for an answer; this will fail when we implement
8224 SAVE_TARGETS, and seems unnecessary anyway.
8225 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8226 (Vx_sent_selection_functions): Doc fix.
8228 2011-05-26 Leo Liu <sdl.web@gmail.com>
8230 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8232 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8234 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8236 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8237 for fringe update if it has periodic bitmap.
8238 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8239 and fringe_bitmap_periodic_p.
8241 * fringe.c (get_fringe_bitmap_data): New function.
8242 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8243 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8244 row. Mark glyph row for fringe update if periodicity changed.
8246 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8247 for fringe update unless it has periodic bitmap.
8249 2011-05-25 Kenichi Handa <handa@m17n.org>
8251 * xdisp.c (get_next_display_element): Set correct it->face_id for
8252 a static composition.
8254 2011-05-24 Leo Liu <sdl.web@gmail.com>
8257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8259 * fns.c (crypto_hash_function, Fsha1): New function.
8260 (Fmd5): Use crypto_hash_function.
8261 (syms_of_fns): Add Ssha1.
8263 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8265 * gnutls.c: Remove unused macros.
8266 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8267 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8268 Remove macros that are defined and never used.
8269 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8271 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8273 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8274 (Fx_get_selection_internal): Minor cleanup.
8275 (Fx_own_selection_internal): Rename arguments for consistency with
8278 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8280 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8282 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8284 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8286 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8288 * dispnew.c (scrolling_window): Don't exclude the case that the
8289 last enabled row in the desired matrix touches the bottom boundary.
8291 2011-05-21 Glenn Morris <rgm@gnu.org>
8293 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8294 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8295 and add some more files.
8297 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8299 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8300 report_file_error introduced by the change from 2011-05-07.
8302 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8304 * systime.h (Time): Define only if emacs is defined.
8305 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8306 where the include path doesn't have X11/X.h by default. See
8307 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8309 2011-05-20 Kenichi Handa <handa@m17n.org>
8311 * composite.c (find_automatic_composition): Fix previous change.
8313 2011-05-20 Glenn Morris <rgm@gnu.org>
8315 * lisp.mk: New file, split from Makefile.in.
8316 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8317 (shortlisp): Remove.
8318 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8320 2011-05-19 Glenn Morris <rgm@gnu.org>
8322 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8323 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8324 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8325 (lisp): Set the order to that of loadup.el.
8326 (shortlisp): Make it a copy of $lisp.
8327 (SOME_MACHINE_LISP): Remove.
8328 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8329 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8331 2011-05-18 Kenichi Handa <handa@m17n.org>
8333 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8334 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8335 (find_automatic_composition): Mostly rewrite for efficiency.
8337 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8339 * makefile.w32-in: Update dependencies.
8341 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8343 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8344 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8346 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8348 Fix some integer overflow issues, such as string length overflow.
8350 * insdel.c (count_size_as_multibyte): Check for string overflow.
8352 * character.c (lisp_string_width): Check for string overflow.
8353 Use EMACS_INT, not int, for string indexes and lengths; in
8354 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8355 the resulting string length overflows an EMACS_INT; instead,
8356 report a string overflow if no precision given. When checking for
8357 precision exhaustion, use a check that cannot possibly have
8358 integer overflow. (Bug#8675)
8359 * character.h (lisp_string_width): Adjust to new signature.
8361 * alloc.c (string_overflow): New function.
8362 (Fmake_string): Use it. This doesn't change behavior, but saves
8363 a few bytes and will simplify future changes.
8364 * character.c (string_escape_byte8): Likewise.
8365 * lisp.h (string_overflow): New decl.
8367 Fixups, following up to the user-interface timestamp change.
8368 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8369 for UI timestamps, instead of unsigned long.
8370 * msdos.c (mouse_get_pos): Likewise.
8371 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8372 * w32gui.h (Time): Define by including "systime.h" rather than by
8373 declaring it ourselves. (Bug#8664)
8375 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8376 * image.c (clear_image_cache): Likewise.
8378 * term.c (term_mouse_position): Don't assume time_t wraparound.
8380 Be more systematic about user-interface timestamps.
8381 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8382 and sometimes 'EMACS_UINT', to represent these timestamps.
8383 This change causes it to use 'Time' uniformly, as that's what X uses.
8384 This makes the code easier to follow, and makes it easier to catch
8385 integer overflow bugs such as Bug#8664.
8386 * frame.c (Fmouse_position, Fmouse_pixel_position):
8387 Use Time, not unsigned long, for user-interface timestamps.
8388 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8389 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8390 * keyboard.h (last_event_timestamp): Likewise.
8391 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8392 * menu.h (xmenu_show): Likewise.
8393 * term.c (term_mouse_position): Likewise.
8394 * termhooks.h (struct input_event.timestamp): Likewise.
8395 (struct terminal.mouse_position_hook): Likewise.
8396 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8397 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8398 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8399 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8401 * menu.h, termhooks.h: Include "systime.h", for Time.
8403 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8404 Don't assume that the difference between two unsigned long values
8405 can fit into an integer. At this point, we know button_down_time
8406 <= event->timestamp, so the difference must be nonnegative, so
8407 there's no need to cast the result if double-click-time is
8408 nonnegative, as it should be; check that it's nonnegative, just in
8409 case. This bug is triggered when events are more than 2**31 ms
8410 apart (about 25 days). (Bug#8664)
8412 * xselect.c (last_event_timestamp): Remove duplicate decl.
8413 (x_own_selection): Remove needless cast to unsigned long.
8415 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8416 that always fit in int. Use a sentinel instead of a counter, to
8417 avoid a temp and to allay GCC's concerns about possible int overflow.
8418 * frame.h (struct frame): Use int for menu_bar_items_used
8419 instead of EMACS_INT, since it always fits in int.
8421 * menu.c (grow_menu_items): Check for int overflow.
8423 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8425 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8426 Before, the code was not consistent. These values cannot exceed
8427 2**31 - 1 so there's no need to make them unsigned.
8428 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8429 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8430 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8432 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8434 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8435 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8436 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8437 presumably because the widths might not match.
8439 * window.c (size_window): Avoid needless test at loop start.
8441 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8443 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8445 2011-05-12 Drew Adams <drew.adams@oracle.com>
8447 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8449 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8451 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8452 `width' to `bar_area_x' and `bar_area_width', respectively.
8453 (x_scroll_run): Take account of fringe background extension.
8455 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8456 Rename local vars `left' and `width' to `bar_area_x' and
8457 `bar_area_width', respectively.
8458 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8459 background extension.
8461 2011-05-10 Jim Meyering <meyering@redhat.com>
8463 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8465 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8467 * image.c (Finit_image_library): Return t for built-in image types,
8468 like pbm and xbm. (Bug#8640)
8470 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8472 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8474 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8476 * w32console.c (Fset_screen_color): Doc fix.
8477 (Fget_screen_color): New function.
8478 (syms_of_ntterm): Defsubr it.
8480 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8481 unlink the temporary file if Fcall_process didn't create it in the
8483 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8484 child process will be redirected to a file specified with `:file'.
8485 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8486 cue to call_process_cleanup not to close that handle.
8488 2011-05-07 Ben Key <bkey76@gmail.com>
8490 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8491 one of two shell specific rules, either bootstrap-temacs-CMD or
8492 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8493 to the previous implementation of the bootstrap-temacs rule.
8494 The bootstrap-temacs-CMD rule is similar to the previous
8495 implementation of the bootstrap-temacs rule except that it
8496 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8499 These changes, along with some changes to nt/configure.bat,
8500 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8501 earlier fix to add support for --cflags and --ldflags options
8502 that include quotes so that it works whether make uses cmd or
8505 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8507 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8508 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8510 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8511 a string. Handle both cases.
8512 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8513 (Fdbus_register_method): Use Qinvalid_function.
8515 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8517 * makefile.w32-in: Update dependencies.
8518 (LISP_H): Add inttypes.h and stdin.h.
8519 (PROCESS_H): Add unistd.h.
8521 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8523 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8524 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8526 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8528 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8530 * term.c (vfatal): Remove stray call to va_end.
8531 It's not needed and the C Standard doesn't allow it here anyway.
8533 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8534 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8536 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8539 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8541 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8543 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8545 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8547 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8549 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8550 * charset.c (Fdefine_charset_internal): Don't initialize
8551 charset.code_space[15]. The value was garbage, on hosts with
8552 32-bit int (Bug#8600).
8554 * lread.c (read_integer): Be more consistent with string-to-number.
8555 Use string_to_number to do the actual conversion; this avoids
8556 rounding errors and fixes some other screwups. Without this fix,
8557 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8558 (digit_to_number): Move earlier, for benefit of read_integer.
8559 Return -1 if the digit is out of range for the base, -2 if it is
8560 not a digit in any supported base. (Bug#8602)
8562 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8564 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8565 to match comment at start of function. This also removes a
8566 GCC warning about overflow in a 32+64-bit port.
8568 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8570 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8571 Reported by Stefan Monnier in
8572 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8573 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8574 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8576 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8577 (EMACS_UINTPTR): Likewise, with uintptr_t.
8579 * lisp.h: Prefer 64-bit EMACS_INT if available.
8580 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8581 on 32-bit hosts that have 64-bit int, so that they can access
8583 However, temporarily disable this change unless the temporary
8584 symbol WIDE_EMACS_INT is defined.
8586 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8588 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8589 This removes an assumption that EMACS_INT and long are the same
8590 width as pointers. The assumption is true for Emacs porting targets
8591 now, but we want to make other targets possible.
8592 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8593 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8594 In the rest of the code, change types of integers that hold casted
8595 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8596 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8597 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8598 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8599 No need to cast type when ORing.
8600 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8601 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8602 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8603 assume EMACS_INT is the same width as char *.
8604 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8605 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8606 Remove no-longer-needed casts.
8607 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8608 (xg_tool_bar_help_callback, xg_make_tool_item):
8609 Use EMACS_INTPTR to hold an integer
8610 that will be cast to void *; this can avoid a GCC warning
8611 if EMACS_INT is not the same width as void *.
8612 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8613 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8614 (current_message_1, set_message_1):
8615 Use a local to convert to proper width without a cast.
8616 * xmenu.c (dialog_selection_callback): Likewise.
8618 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8619 Also, don't assume VALBITS / RAND_BITS is less than 5,
8620 and don't rely on undefined behavior when shifting a 1 left into
8622 * lisp.h (get_random): Change signature to match.
8624 * lread.c (hash_string): Use size_t, not int, for hash computation.
8625 Normally we prefer signed values; but hashing is special, because
8626 it's better to use unsigned division on hash table sizes so that
8627 the remainder is nonnegative. Also, size_t is the natural width
8628 for hashing into memory. The previous code used 'int', which doesn't
8629 retain enough info to hash well into very large tables.
8630 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8632 * dbusbind.c: Don't possibly lose pointer info when converting.
8633 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8634 Use XPNTR rather than XHASH, so that the high-order bits of
8635 the pointer aren't lost when converting through void *.
8637 * eval.c (Fautoload): Don't double-shift a pointer.
8639 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8641 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8643 * gnutls.c (DEF_GNUTLS_FN):
8644 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8646 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8648 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8651 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8653 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8654 New version that can reserve upto 2GB of heap space.
8656 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8658 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8660 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8662 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8663 `gnutls_certificate_set_x509_key_file'.
8665 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8667 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8668 Update dependencies.
8670 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8672 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8673 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8674 Remove unused parameter `fildes'.
8675 * process.c (read_process_output, send_process): Don't pass it.
8677 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8679 Fix previous change: the library cache is defined in w32.c.
8680 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8681 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8683 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8685 Implement dynamic loading of GnuTLS on Windows.
8687 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8688 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8689 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8692 * gnutls.c (Qgnutls_dll): Define.
8693 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8694 (gnutls_*): Declare function pointers.
8695 (init_gnutls_functions): New function to initialize function pointers.
8696 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8697 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8698 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8699 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8700 (emacs_gnutls_write, emacs_gnutls_read)
8701 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8702 (Fgnutls_available_p): New function.
8703 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8704 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8705 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8707 * image.c: Include w32.h.
8708 (Vimage_type_cache): Delete.
8709 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8710 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8711 (w32_delayed_load): Move to w32.c.
8713 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8715 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8716 (w32_delayed_load): Move from image.c. When loading a library, record
8717 its filename in the :loaded-from property of the library id.
8718 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8719 Initialize and staticpro them.
8720 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8722 * process.c: Include lisp.h before w32.h, not after.
8723 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8724 instead of gnutls_record_check_pending.
8726 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8728 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8730 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8731 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8734 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8736 * xterm.c (x_set_frame_alpha): Do not set property on anything
8737 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8739 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8741 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8743 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8745 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8746 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8747 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8748 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8749 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8750 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8751 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8752 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8753 (Qgnutls_bootprop_callbacks_verify): Make static.
8755 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8757 * callproc.c: Indentation fixup.
8759 * sysdep.c (wait_for_termination_1): Make static.
8760 (wait_for_termination, interruptible_wait_for_termination):
8761 Move after wait_for_termination_1.
8763 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8765 * sysdep.c (interruptible_wait_for_termination): New function
8766 which is like wait_for_termination, but allows keyboard
8769 * callproc.c (Fcall_process): Add (:file "file") as an option for
8771 (Fcall_process_region): Ditto.
8773 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8775 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8776 rather than `XVECTOR (FOO)->size'.
8778 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8779 inttypes.h, as a gnulib replacement is used if it not available in
8782 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8784 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8785 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8786 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8788 * coding.c (coding_alloc_by_realloc): Error out if destination
8789 will grow beyond MOST_POSITIVE_FIXNUM.
8790 (decode_coding_emacs_mule): Abort if there isn't enough place in
8791 charbuf for the composition carryover bytes. Reserve an extra
8792 space for up to 2 characters produced in a loop.
8793 (decode_coding_iso_2022): Abort if there isn't enough place in
8794 charbuf for the composition carryover bytes.
8796 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8798 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8799 aborting when %lld or %lll format is passed.
8800 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8801 %llo or %llx format is passed. (Bug#8545)
8803 * window.c (window_scroll_line_based): Use a marker instead of
8804 simple variables to record original value of point. (Bug#7952)
8806 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8807 produced by %s or %c overflows available buffer space. (Bug#8545)
8809 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8811 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8812 (SIZE_MAX): Move defn after all includes, as they might #define it.
8814 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8816 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8818 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8820 * keyboard.c (Qdelayed_warnings_hook): Define.
8821 (command_loop_1): Run `delayed-warnings-hook'
8822 if Vdelayed_warnings_list is non-nil.
8823 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8824 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8826 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8828 * doprnt.c (doprnt): Don't return value smaller than the buffer
8829 size if the message was truncated. (Bug#8545).
8831 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8833 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8834 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8836 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8838 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8840 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8842 * makefile.w32-in: Update dependencies.
8844 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8846 Improve `doprnt' and its usage. (Bug#8545)
8847 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8848 `format_end'. Remove support for %l as a conversion specifier.
8849 Don't use xrealloc. Improve diagnostics when the %l size modifier
8850 is used. Update the commentary.
8852 * eval.c (verror): Simplify calculation of size_t.
8854 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8857 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8859 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8862 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8864 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8865 This makes this file independent of the recent pseudovector change.
8867 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8869 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8871 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8872 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8873 Remove unused local.
8874 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8876 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8877 GCC 4.6.0 optimizes based on type-based alias analysis.
8878 For example, if b is of type struct buffer * and v of type struct
8879 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8880 != &v->size, and therefore "v->size = 1; b->size = 2; return
8881 v->size;" must therefore return 1. This assumption is incorrect
8882 for Emacs, since it type-puns struct Lisp_Vector * with many other
8883 types. To fix this problem, this patch adds a new type struct
8884 vectorlike_header that documents the constraints on layout of vectors
8885 and pseudovectors, and helps optimizing compilers not get fooled
8886 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8887 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8888 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8890 (XSETPVECTYPE): Rewrite in terms of new macro.
8891 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8892 This is a bit clearer, and further avoids the possibility of
8893 undesirable aliasing.
8894 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8895 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8896 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8897 since Lisp_Subr is a special case (no "next" field).
8898 (ASIZE): Now uses header.size rather than size.
8899 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8900 to avoid the hassle of writing XVECTOR (foo)->header.size.
8901 (struct vectorlike_header): New type.
8902 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8903 object, to help avoid aliasing.
8904 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8905 (SUBRP): Likewise, since Lisp_Subr is a special case.
8906 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8907 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8908 (struct Lisp_Hash_Table): Combine first two members into a single
8909 struct vectorlike_header member. All uses of "size" and "next" members
8910 changed to be "header.size" and "header.next".
8911 * buffer.h (struct buffer): Likewise.
8912 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8913 * frame.h (struct frame): Likewise.
8914 * process.h (struct Lisp_Process): Likewise.
8915 * termhooks.h (struct terminal): Likewise.
8916 * window.c (struct save_window_data, struct saved_window): Likewise.
8917 * window.h (struct window): Likewise.
8918 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8919 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8920 * buffer.c (init_buffer_once): Likewise.
8921 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8923 * process.c (Fformat_network_address): Use local var for size,
8926 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8928 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8929 * data.c (atof): Remove decl; no longer used or needed.
8930 (digit_to_number): Move to lread.c.
8931 (Fstring_to_number): Use new string_to_number function, to be
8932 consistent with how the Lisp reader treats infinities and NaNs.
8933 Do not assume that floating-point numbers represent EMACS_INT
8934 without losing information; this is not true on most 64-bit hosts.
8935 Avoid double-rounding errors, by insisting on integers when
8936 parsing non-base-10 numbers, as the documentation specifies.
8937 * lisp.h (string_to_number): New decl, replacing ...
8938 (isfloat_string): Remove.
8939 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8940 (read1): Do not accept +. and -. as integers; this
8941 appears to have been a coding error. Similarly, do not accept
8942 strings like +-1e0 as floating point numbers. Do not report
8943 overflow for integer overflows unless the base is not 10 which
8944 means we have no simple and reliable way to continue.
8945 Break out the floating-point parsing into a new
8946 function string_to_number, so that Fstring_to_number parses
8947 floating point numbers consistently with the Lisp reader.
8948 (digit_to_number): Move here from data.c. Make it static inline.
8949 (E_CHAR, EXP_INT): Remove, replacing with ...
8950 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8951 (string_to_number): New function, replacing isfloat_string.
8952 This function checks for valid syntax and produces the resulting
8953 Lisp float number too. Rework it so that string-to-number
8954 no longer mishandles examples like "1.0e+". Use strtoumax,
8955 so that overflow for non-base-10 numbers is reported only when
8956 there's no portable and simple way to convert to floating point.
8958 * textprop.c (set_text_properties_1): Rewrite for clarity,
8959 and to avoid GCC warning about integer overflow.
8961 * intervals.h (struct interval): Use EMACS_INT for members
8962 where EMACS_UINT might cause problems. See
8963 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8964 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8965 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8967 (offset_intervals): Tell GCC not to worry about length overflow
8968 when negating a negative length.
8970 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8971 (overrun_check_free): Likewise.
8973 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8974 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8977 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8978 (gnutls_make_error): Rename local to avoid shadowing.
8979 (gnutls_emacs_global_deinit): ifdef out; not used.
8980 (Fgnutls_boot): Use const for pointer to readonly storage.
8981 Comment out unused local. Fix pointer signedness problems.
8983 * lread.c (openp): Don't stuff size_t into an 'int'.
8984 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8985 about possible signed overflow.
8987 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8988 (GDK_KEY_g): Don't define if already defined.
8989 (xg_prepare_tooltip): Avoid pointer signedness problem.
8990 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8992 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8993 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8995 * xfns.c (Fx_window_property): Simplify a bit,
8996 to make a bit faster and to avoid GCC 4.6.0 warning.
8997 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8999 * fns.c (internal_equal): Don't assume size_t fits in int.
9001 * alloc.c (compact_small_strings): Tighten assertion a little.
9003 Replace pEd with more-general pI, and fix some printf arg casts.
9004 * lisp.h (pI): New macro, generalizing old pEd macro to other
9005 conversion specifiers. For example, use "...%"pI"d..." rather
9006 than "...%"pEd"...".
9007 (pEd): Remove. All uses replaced with similar uses of pI.
9008 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9009 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9010 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9011 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9012 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9013 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9014 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9016 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9017 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9018 * print.c (safe_debug_print, print_object): Likewise.
9019 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9021 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9022 avoiding the 0 flag, which is not portable.
9023 * process.c (Fmake_network_process): Use pI to avoid cast.
9024 * region-cache.c (pp_cache): Likewise.
9025 * xdisp.c (decode_mode_spec): Likewise.
9026 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9027 behavior on 64-bit hosts with printf arg.
9028 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9029 (x_stop_queuing_selection_requests): Likewise.
9030 (x_get_window_property): Don't truncate byte count to an 'int'
9033 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9034 here, since it parses constructs like leading '-' and spaces,
9035 which are not wanted; and it overflows with large numbers.
9036 Instead, simply match F[0-9]+, which is what is wanted anyway.
9038 * alloc.c: Remove unportable assumptions about struct layout.
9039 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9040 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9041 (allocate_vectorlike, make_pure_vector): Use the new macros,
9042 plus offsetof, to remove unportable assumptions about struct layout.
9043 These assumptions hold on all porting targets that I know of, but
9044 they are not guaranteed, they're easy to remove, and removing them
9045 makes further changes easier.
9047 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9048 This doesn't fix a bug but makes the code clearer.
9049 (string_overrun_cookie): Now const. Use initializers that
9050 don't formally overflow signed char, to avoid warnings.
9051 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9052 can cause Emacs to crash when string overrun checking is enabled.
9053 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9054 multiple of sizeof (EMACS_INT); it need not be, if
9055 alignof(EMACS_INT) < sizeof (EMACS_INT).
9056 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9058 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9060 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9062 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9064 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9065 supposed to be handshaking. (Bug#8556)
9066 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9068 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9070 * lisp.h (Qdebug): List symbol.
9071 * eval.c (Qdebug): Restore global linkage.
9072 * keyboard.c (debug-on-event): New variable.
9073 (handle_user_signal): Break into debugger when debug-on-event
9074 matches the current signal symbol.
9076 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9078 * alloc.c (check_sblock, check_string_bytes)
9079 (check_string_free_list): Convert to standard C.
9081 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9083 * w32.c (emacs_gnutls_push): Fix typo.
9085 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9087 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9088 "cast to pointer from integer of different size".
9090 Improve doprnt and its use in verror. (Bug#8545)
9091 * doprnt.c (doprnt): Document the set of format control sequences
9092 supported by the function. Use SAFE_ALLOCA instead of always
9095 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9096 is one byte too soon. Don't use xrealloc; instead xfree and
9099 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9101 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9104 * gnutls.c: Renamed global_initialized to
9105 gnutls_global_initialized. Added internals for the
9106 :verify-hostname-error, :verify-error, and :verify-flags
9107 parameters of `gnutls-boot' and documented those parameters in the
9108 docstring. Start callback support.
9109 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9110 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9111 on error. Return error code.
9112 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9113 (emacs_gnutls_read): Likewise.
9114 (Fgnutls_boot): Return handshake error code.
9115 (emacs_gnutls_handle_error): New function.
9116 (wsaerror_to_errno): Likewise.
9118 * w32.h (emacs_gnutls_pull): Add prototype.
9119 (emacs_gnutls_push): Likewise.
9121 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9122 (emacs_gnutls_push): Likewise.
9124 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9126 * process.c (wait_reading_process_output): Check if GnuTLS
9127 buffered some data internally if no FDs are set for TLS
9130 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9131 (LIBS): Link to USER_LIBS.
9132 ($(BLD)/gnutls.$(0)): New target.
9134 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9136 * xdisp.c (handle_single_display_spec): Rename the
9137 display_replaced_before_p argument into display_replaced_p, to
9138 make it consistent with the commentary. Fix typos in the
9141 * textprop.c (syms_of_textprop): Remove dead code.
9142 (copy_text_properties): Delete obsolete commentary about an
9143 interface that was deleted long ago. Fix typos in the description
9146 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9147 to changes in oldXMenu/XMenu.h from 2011-04-16.
9148 <menu_help_message, prev_menu_help_message>: Constify.
9149 (IT_menu_make_room): menu->help_text is now `const char **';
9152 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9153 to changes in oldXMenu/XMenu.h from 2011-04-16.
9154 (struct XMenu): Declare `help_text' `const char **'.
9156 * xfaces.c <Qunspecified>: Make extern again.
9158 * syntax.c: Include sys/types.h before including regex.h, as
9161 * doc.c (get_doc_string): Improve the format passed to `error'.
9163 * doprnt.c (doprnt): Improve commentary.
9165 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9167 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9170 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9171 changes in globals.h immediately force recompilation.
9172 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9173 $(CURDIR)/s/ms-w32.h.
9174 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9176 * character.c (Fchar_direction): Function deleted.
9177 (syms_of_character): Don't defsubr it.
9178 <char-direction-table>: Deleted.
9180 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9182 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9183 * doprnt.c: Include limits.h.
9184 (SIZE_MAX): New macro.
9185 (doprnt): Return a size_t value. 2nd arg is now size_t.
9186 Many local variables are now size_t instead of int or unsigned.
9187 Improve overflow protection. Support `l' modifier for integer
9188 conversions. Support %l conversion. Don't assume an EMACS_INT
9189 argument for integer conversions and for %c.
9191 * lisp.h (doprnt): Restore prototype.
9193 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9196 * Makefile.in (base_obj): Add back doprnt.o.
9198 * deps.mk (doprnt.o): Add back prerequisites.
9199 (callint.o): Depend on character.h.
9201 * eval.c (internal_lisp_condition_case): Include the handler
9202 representation in the error message.
9203 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9204 when breaking from the loop.
9206 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9208 * callint.c (Fcall_interactively): When displaying error message
9209 about invalid control letter, pass the character's codepoint, not
9210 a pointer to its multibyte form. Improve display of the character
9211 in octal and display also its hex code.
9213 * character.c (char_string): Use %x to display the (unsigned)
9214 codepoint of an invalid character, to avoid displaying a bogus
9217 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9218 `error', not SYMBOL_NAME itself.
9220 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9221 character arguments to `error'.
9223 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9224 to `error' in error message about FINAL_CHAR argument. Make sure
9225 FINAL_CHAR is a character, and use %c when it is passed as
9226 argument to `error'.
9228 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9230 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9232 * w32.c: Include <time.h>.
9233 (sys_localtime): New function.
9235 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9237 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9239 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9241 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9243 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9246 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9248 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9249 gl_state.e_property when gl_state.object is Qt.
9251 * insdel.c (make_gap_larger): Remove limitation of buffer size
9254 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9256 * xdisp.c (lookup_glyphless_char_display)
9257 (produce_glyphless_glyph): Handle cons cell entry in
9258 glyphless-char-display.
9259 (Vglyphless_char_display): Document it.
9261 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9262 glyphless-char-display.
9264 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9266 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9268 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9270 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9271 definition for no-X builds.
9273 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9275 Static checks with GCC 4.6.0 and non-default toolkits.
9277 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9279 * process.c (keyboard_bit_set): Define only if SIGIO.
9280 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9281 (send_process): Repair possible setjmp clobbering.
9283 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9285 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9287 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9289 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9290 Define only if needed.
9292 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9293 by pacifying GCC about it. Maybe it's time to retire it?
9294 * xfaces.c (USG, __TIMEVAL__): Likewise.
9296 * dispextern.h (struct redisplay_interface): Rename param
9298 * termhooks.h (struct terminal): Likewise.
9299 * xterm.c (xembed_send_message): Likewise.
9301 * insdel.c (make_gap_smaller): Define only if
9302 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9304 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9307 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9308 so that we aren't warned about unused symbols.
9310 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9312 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9314 * xfns.c (x_real_positions): Mark locals as initialized.
9316 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9318 * xterm.c: Fix problems found by static analysis with other toolkits.
9319 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9320 (x_dispatch_event): Declare static if USE_GTK, and
9321 define if USE_GTK || USE_X_TOOLKIT.
9322 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9323 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9324 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9325 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9327 * xmenu.c (menu_help_callback): Pointer type fixes.
9328 Use const pointers when pointing at readonly data. Avoid pointer
9330 (FALSE): Remove unused macro.
9331 (update_frame_menubar): Remove unused decl.
9333 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9335 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9336 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9337 (single_menu_item): Rename local to avoid shadowing.
9339 * keyboard.c (make_lispy_event): Remove unused local var.
9341 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9342 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9344 * bitmaps: Change bitmaps from unsigned char back to the X11
9345 compatible char. Avoid the old compiler warnings about
9346 out-of-range initializers by using, for example, '\xab' rather
9349 * xgselect.c (xgselect_initialize): Check vs interface
9350 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9352 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9354 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9355 to read-only memory.
9357 * fns.c (vector): Remove; this old hack is no longer needed.
9359 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9361 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9363 * xrdb.c (x_load_resources): Omit unused local.
9365 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9366 (x_window): Rename locals to avoid shadowing.
9367 (USG): Use the kludged USG macro, to pacify gcc.
9369 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9370 (x_term_init): Remove local to avoid shadowing.
9372 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9374 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9375 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9377 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9379 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9381 Fix regex.c, syntax.c and friends for buffers > 2GB.
9382 * syntax.h (struct gl_state_s): Declare character position members
9385 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9387 * textprop.c (verify_interval_modification, interval_of):
9388 Declare arguments EMACS_INT.
9390 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9393 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9395 * indent.c (Fvertical_motion): Local variable it_start is now
9398 * regex.c (re_match, re_match_2, re_match_2_internal)
9399 (bcmp_translate, regcomp, regexec, print_double_string)
9400 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9401 (re_compile_pattern, re_exec): Declare arguments and local
9402 variables `size_t' and `ssize_t' and return values `regoff_t', as
9404 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9405 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9406 <compile_stack_type>: `size' and `avail' are now `size_t'.
9408 * regex.h <regoff_t>: Use ssize_t, not int.
9409 (re_search, re_search_2, re_match, re_match_2): Arguments that
9410 specify buffer/string position and length are now ssize_t and
9411 size_t. Return type is regoff_t.
9413 2011-04-16 Ben Key <bkey76@gmail.com>
9415 * nsfont.m: Fixed bugs in ns_get_family and
9416 ns_descriptor_to_entity that were caused by using free to
9417 deallocate memory blocks that were allocated by xmalloc (via
9418 xstrdup). This caused Emacs to crash when compiled with
9419 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9420 --enable-checking=xmallocoverrun). xfree is now used to
9421 deallocate these memory blocks.
9423 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9425 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9427 emacs_write: Accept and return EMACS_INT for sizes.
9428 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9430 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9431 Accept and return EMACS_INT.
9432 (emacs_gnutls_write): Return the number of bytes written on
9434 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9435 (emacs_read, emacs_write): Remove check for negative size, as the
9436 Emacs source code has been audited now.
9437 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9438 (emacs_read, emacs_write): Use it.
9439 * process.c (send_process): Adjust to the new signatures of
9440 emacs_write and emacs_gnutls_write. Do not attempt to store
9441 a byte offset into an 'int'; it might overflow.
9442 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9444 * sound.c: Don't assume sizes fit in 'int'.
9445 (struct sound_device.period_size, alsa_period_size):
9446 Return EMACS_INT, not int.
9447 (struct sound_device.write, vox_write, alsa_write):
9448 Accept EMACS_INT, not int.
9449 (wav_play, au_play): Use EMACS_INT to store sizes and to
9450 record read return values.
9452 2011-04-15 Ben Key <bkey76@gmail.com>
9454 * keyboard.c (Qundefined): Don't declare static since it is used
9456 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9457 static since they are used in nsfont.m.
9459 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9461 * process.c (Qprocessp): Don't declare static.
9462 * lisp.h (Qprocessp): Declare again.
9464 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9466 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9468 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9470 Improve C-level modularity by making more things 'static'.
9472 Don't publish debugger-only interfaces to other modules.
9473 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9474 (verify_bytepos, count_markers): Move decls to the only modules
9476 * region-cache.h (pp_cache): Likewise.
9477 * window.h (check_all_windows): Likewise.
9478 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9480 * sysdep.c (croak): Now static, if
9481 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9482 * syssignal.h (croak): Declare only if not static.
9484 * alloc.c (refill_memory_reserve): Now static if
9485 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9486 * lisp.h (refill_memory_reserve): Declare only if not static.
9488 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9489 Define only if USE_LUCID.
9491 * xrdb.c (x_customization_string, x_rm_string): Now static.
9493 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9494 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9496 * xdisp.c (draw_row_with_mouse_face): Now static.
9497 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9499 * window.h (check_all_windows): Mark externally visible.
9501 * window.c (window_deletion_count): Now static.
9503 * undo.c: Make symbols static if they're not exported.
9504 (last_undo_buffer, last_boundary_position, pending_boundary):
9507 * textprop.c (interval_insert_behind_hooks): Now static.
9508 (interval_insert_in_front_hooks): Likewise.
9510 * term.c: Make symbols static if they're not exported.
9511 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9512 (max_frame_lines, tty_set_terminal_modes):
9513 (tty_reset_terminal_modes, tty_turn_off_highlight):
9514 (get_tty_terminal): Now static.
9515 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9516 * termhooks.h (term_mouse_moveto): Do not declare if
9518 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9519 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9521 * sysdep.c: Make symbols static if they're not exported.
9522 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9524 (sigprocmask_set, full_mask): Remove; unused.
9525 (wait_debugging): Mark as visible.
9526 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9527 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9529 * syntax.c (syntax_temp): Define only if !__GNUC__.
9531 * sound.c (current_sound_device, current_sound): Now static.
9533 * search.c (searchbufs, searchbuf_head): Now static.
9535 * scroll.c (scroll_cost): Remove; unused.
9536 * dispextern.h (scroll_cost): Remove decl.
9538 * region-cache.h (pp_cache): Mark as externally visible.
9540 * process.c: Make symbols static if they're not exported.
9541 (process_tick, update_tick, create_process, chan_process):
9542 (Vprocess_alist, proc_buffered_char, datagram_access):
9543 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9544 (deactivate_process): Mark defn as static, as well as decl.
9545 * lisp.h (create_process): Remove decl.
9546 * process.h (chan_process, Vprocess_alist): Remove decls.
9548 * print.c: Make symbols static if they're not exported.
9549 (print_depth, new_backquote_output, being_printed, print_buffer):
9550 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9551 (print_interval, print_number_index, initial_stderr_stream):
9553 * lisp.h (Fprinc): Remove decl.
9554 (debug_output_compilation_hack): Mark as externally visible.
9556 * sysdep.c (croak): Move decl from here to syssignal.h.
9557 * syssignal.h (croak): Put it here, so the API can be checked when
9558 'croak' is called from dissociate_if_controlling_tty.
9560 * minibuf.c: Make symbols static if they're not exported.
9561 (minibuf_save_list, choose_minibuf_frame): Now static.
9562 * lisp.h (choose_minibuf_frame): Remove decl.
9564 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9566 * lread.c: Make symbols static if they're not exported.
9567 (read_objects, initial_obarray, oblookup_last_bucket_number):
9569 (make_symbol): Remove; unused.
9570 * lisp.h (initial_obarray, make_symbol): Remove decls.
9572 * keyboard.c: Make symbols static if they're not exported.
9573 (single_kboard, recent_keys_index, total_keys, recent_keys):
9574 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9575 (this_single_command_key_start, echoing, last_auto_save):
9576 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9577 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9578 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9579 (Vlispy_mouse_stem, double_click_count):
9581 (force_auto_save_soon): Define only if SIGDANGER.
9582 (ignore_mouse_drag_p): Now static if
9583 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9584 (print_help): Remove; unused.
9585 (stop_character, last_timer_event): Mark as externally visible.
9586 * keyboard.h (ignore_mouse_drag_p): Declare only if
9587 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9588 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9589 * lisp.h (echoing): Remove decl.
9590 (force_auto_save_soon): Declare only if SIGDANGER.
9591 * xdisp.c (redisplay_window): Simplify code, to make it more
9592 obvious that ignore_mouse_drag_p is not accessed if !defined
9593 USE_GTK && !defined HAVE_NS.
9595 * intervals.c: Make symbols static if they're not exported.
9596 (merge_properties_sticky, merge_interval_right, delete_interval):
9598 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9600 * insdel.c: Make symbols static if they're not exported.
9601 However, leave prepare_to_modify_buffer alone. It's never
9602 called from outside this function, but that appears to be a bug.
9603 (combine_after_change_list, combine_after_change_buffer):
9604 (adjust_after_replace, signal_before_change): Now static.
9605 (adjust_after_replace_noundo): Remove; unused.
9606 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9607 (signal_before_change): Remove decls.
9609 * indent.c (val_compute_motion, val_vmotion): Now static.
9611 * image.c: Make symbols static if they're not exported.
9612 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9614 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9615 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9617 * fringe.c (standard_bitmaps): Now static.
9618 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9620 * frame.c: Make symbols static if they're not exported.
9621 (x_report_frame_params, make_terminal_frame): Now static.
9622 (get_frame_param): Now static, unless HAVE_NS.
9623 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9624 (x_get_resource_string): Remove; not used.
9625 * frame.h (make_terminal_frame, x_report_frame_params):
9626 (x_get_resource_string); Remove decls.
9627 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9628 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9630 * font.c, fontset.c: Make symbols static if they're not exported.
9631 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9632 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9633 * font.c (font_close_object): Now static.
9634 * font.h (font_close_object): Remove.
9635 * fontset.c (FONTSET_OBJLIST): Remove.
9636 (free_realized_fontset) #if-0 the body, which does nothing.
9637 (face_suitable_for_char_p): #if-0, as it's never called.
9638 * fontset.h (face_suitable_for_char_p): Remove decl.
9639 * xfaces.c (face_at_string_position):
9640 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9641 since 0 is always ASCII.
9643 * fns.c (weak_hash_tables): Now static.
9645 * fileio.c: Make symbols static if they're not exported.
9646 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9647 (Vwrite_region_annotation_buffers): Now static.
9649 * eval.c: Make symbols static if they're not exported.
9650 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9651 * lisp.h (backtrace_list): Remove decl.
9653 * emacs.c: Make symbols static if they're not exported.
9654 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9655 (fatal_error_code, fatal_error_signal_hook, standard_args):
9657 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9658 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9659 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9660 * lisp.h (fatal_error_signal_hook): Remove decl.
9661 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9663 * editfns.c: Move a (normally-unused) function to its only use.
9664 * editfns.c, lisp.h (get_operating_system_release): Remove.
9665 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9666 worth the hassle of breaking this out.
9668 * xterm.c: Make symbols static if they're not exported.
9669 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9670 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9671 (x_destroy_window, x_delete_display):
9673 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9674 (x_mouse_leave): Remove; unused.
9675 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9676 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9677 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9679 (x_mouse_leave): Declare only if WINDOWSNT.
9680 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9681 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9684 * ftxfont.c: Make symbols static if they're not exported.
9685 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9687 * font.h (ftxfont_driver): Likewise.
9689 * xfns.c: Make symbols static if they're not exported.
9690 (x_last_font_name, x_display_info_for_name):
9691 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9692 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9693 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9694 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9695 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9696 (last_show_tip_args): Now static.
9697 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9698 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9699 (x_screen_planes): Remove; unused.
9700 * dispextern.h (x_screen_planes): Remove decl.
9702 * dispnew.c: Make symbols static if they're not exported.
9703 * dispextern.h (redraw_garbaged_frames, scrolling):
9704 (increment_row_positions): Remove.
9705 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9706 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9708 (redraw_garbaged_frames): Remove; unused.
9710 * xfaces.c: Make symbols static if they're not exported.
9711 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9713 * xterm.h (defined_color): Remove decls.
9714 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9715 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9716 (menu_face_changed_default, defined_color, free_realized_face):
9717 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9718 (ascii_face_of_lisp_face): Remove; unused.
9720 * xdisp.c: Make symbols static if they're not exported.
9721 * dispextern.h (scratch_glyph_row, window_box_edges):
9722 (glyph_to_pixel_coords, set_cursor_from_row):
9723 (get_next_display_element, set_iterator_to_next):
9724 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9725 (show_mouse_face): Remove decls
9726 * frame.h (message_buf_print): Likewise.
9727 * lisp.h (pop_message, set_message, check_point_in_composition):
9729 * xterm.h (set_vertical_scroll_bar): Likewise.
9730 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9731 (message_buf_print, scratch_glyph_row, displayed_buffer):
9732 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9733 (get_next_display_element, show_mouse_face, window_box_edges):
9734 (frame_to_window_pixel_xy, check_point_in_composition):
9735 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9736 (glyph_to_pixel_coords): Remove; unused.
9738 * dired.c (file_name_completion): Now static.
9740 * dbusbind.c (xd_in_read_queued_messages): Now static.
9742 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9743 * data.c (circular_list_error): Remove.
9745 * commands.h (last_point_position, last_point_position_buffer):
9746 (last_point_position_window): Remove decls.
9747 * keyboard.c: Make these variables static.
9749 * coding.h (coding, code_convert_region, encode_coding_gap):
9751 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9752 (iso_code_class, detect_coding, code_convert_region): Now static.
9753 (encode_coding_gap): Remove; unused.
9755 * chartab.c (chartab_chars, chartab_bits): Now static.
9757 * charset.h (charset_iso_8859_1): Remove decl.
9758 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9761 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9762 * ccl.c (Vccl_program_table): Now static.
9763 (check_ccl_update): Remove; unused.
9765 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9766 * category.h: ... from here.
9767 * category.c (check_category_table, set_category_set): Now static.
9769 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9770 * lisp.h: Remove these decls.
9772 * buffer.c (buffer_count): Remove unused var.
9774 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9775 so that it's not optimized away.
9776 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9777 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9778 exported only to the debugger.
9780 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9781 * atimer.h (run_all_atimers): Remove; not exported.
9783 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9784 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9785 was inaccessible from Lisp.
9786 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9787 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9789 alloc.c: Import and export fewer symbols, and remove unused items.
9790 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9792 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9793 it's not optimized away by whole-program optimization.
9794 (message_enable_multibyte, free_misc): Remove.
9795 (catchlist, handlerlist, mark_backtrace):
9796 Declare only if BYTE_MARK_STACK.
9797 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9798 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9799 (message_enable_multibyte): Remove decl.
9800 (free_misc, interval_free_list, float_block, float_block_index):
9801 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9802 (cons_free_list, last_marked_index):
9804 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9805 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9806 (mark_backtrace): Define only if BYTE_MARK_STACK.
9807 * xdisp.c (message_enable_multibyte): Now static.
9809 Declare Lisp_Object Q* variables to be 'static' if not exported.
9810 This makes it easier for human readers (and static analyzers)
9811 to see whether these variables are used from other modules.
9812 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9813 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9814 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9815 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9816 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9817 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9818 * xmenu.c, xselect.c:
9819 Declare Q* vars static if they are not used in other modules.
9820 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9821 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9822 Remove decls of unexported vars.
9823 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9825 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9827 Make Emacs functions such as Fatom 'static' by default.
9828 This makes it easier for human readers (and static analyzers)
9829 to see whether these functions can be called from other modules.
9830 DEFUN now defines a static function. To make the function external
9831 so that it can be used in other C modules, use the new macro DEFUE.
9832 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9833 (Finit_image_library):
9834 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9835 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9836 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9837 Remove decls, since these functions are now static.
9838 (Funintern, Fget_internal_run_time): New decls, since these functions
9839 were already external.
9841 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9842 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9843 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9844 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9845 * keyboard.c, keymap.c, lread.c:
9846 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9847 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9848 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9849 Mark functions with DEFUE instead of DEFUN,
9850 if they are used in other modules.
9851 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9852 decls for now-static functions.
9853 * buffer.h (Fdelete_overlay): Remove decl.
9854 * callproc.c (Fgetenv_internal): Mark as internal.
9855 * composite.c (Fremove_list_of_text_properties): Remove decl.
9856 (Fcomposition_get_gstring): New forward static decl.
9857 * composite.h (Fcomposite_get_gstring): Remove decl.
9858 * dired.c (Ffile_attributes): New forward static decl.
9859 * doc.c (Fdocumntation_property): New forward static decl.
9860 * eval.c (Ffetch_bytecode): New forward static decl.
9861 (Funintern): Remove extern decl; now in .h file where it belongs.
9862 * fileio.c (Fmake_symbolic_link): New forward static decl.
9863 * image.c (Finit_image_library): New forward static decl.
9864 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9865 * intervals.h (Fprevious_property_change):
9866 (Fremove_list_of_text_properties): Remove decls.
9867 * keyboard.c (Fthis_command_keys): Remove decl.
9868 (Fcommand_execute): New forward static decl.
9869 * keymap.c (Flookup_key): New forward static decl.
9870 (Fcopy_keymap): Now static.
9871 * keymap.h (Flookup_key): Remove decl.
9872 * process.c (Fget_process): New forward static decl.
9873 (Fprocess_datagram_address): Mark as internal.
9874 * syntax.c (Fsyntax_table_p): New forward static decl.
9875 (skip_chars): Remove duplicate decl.
9876 * textprop.c (Fprevious_property_change): New forward static decl.
9877 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9879 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9880 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9882 * editfns.c (Fformat): Remove unreachable code.
9884 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9886 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9889 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9891 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9892 when at ZV. (Bug#8487)
9894 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9896 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9898 * keyboard.c (parse_tool_bar_item): Likewise.
9899 * sound.c (sound_cleanup, alsa_close): Likewise.
9900 * termcap.c (tgetent): Likewise.
9901 * xfns.c (x_default_font_parameter): Likewise.
9902 * xsettings.c (read_and_apply_settings): Likewise.
9904 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9905 (overrun_check_free): Protoize.
9907 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9909 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9910 since callers should never pass a negative size.
9911 Change the signature to match that of plain 'read' and 'write'; see
9912 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9913 * lisp.h: Update prototypes of emacs_write and emacs_read.
9915 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9917 * xdisp.c (redisplay_window): Don't try to determine the character
9918 position of the scroll margin if the window start point w->startp
9919 is outside the buffer's accessible region. (Bug#8468)
9921 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9923 Fix write-region and its subroutines for buffers > 2GB.
9924 * fileio.c (a_write, e_write): Modify declaration of arguments and
9925 local variables to support buffers larger than 2GB.
9926 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9928 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9929 argument, local variables, and return value.
9931 * lisp.h: Update prototypes of emacs_write and emacs_read.
9933 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9935 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9937 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9939 Fix more problems found by GCC 4.6.0's static checks.
9941 * xdisp.c (vmessage): Use a better test for character truncation.
9943 * charset.c (load_charset_map): <, not <=, for optimization,
9944 and to avoid potential problems with integer overflow.
9945 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9946 * casetab.c (set_identity, shuffle): Likewise.
9947 * editfns.c (Fformat): Likewise.
9948 * syntax.c (skip_chars): Likewise.
9950 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9951 This also lets GCC 4.6.0 generate slightly better loop code.
9953 * callint.c (Fcall_interactively): <, not <=, for optimization.
9954 (Fcall_interactively): Count the number of arguments produced,
9955 not the number of arguments given. This is simpler and lets GCC
9956 4.6.0 generate slightly better code.
9958 * ftfont.c: Distingish more carefully between FcChar8 and char.
9959 The previous code passed unsigned char * to a functions like
9960 strlen and xstrcasecmp that expect char *, which does not
9961 conform to the C standard.
9962 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9963 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9964 char * when the C standard requires it.
9966 * keyboard.c (read_char): Remove unused var.
9968 * eval.c: Port to Windows vsnprintf (Bug#8435).
9970 (SIZE_MAX): Define if the headers do not.
9971 (verror): Do not give up if vsnprintf returns a negative count.
9972 Instead, grow the buffer. This ports to Windows vsnprintf, which
9973 does not conform to C99. Problem reported by Eli Zaretskii.
9974 Also, simplify the allocation scheme, by avoiding the need for
9975 calling realloc, and removing the ALLOCATED variable.
9977 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9979 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9980 But keep the doprint source code for now, as we might revamp it
9981 and use it again (Bug#8435).
9982 * lisp.h (doprnt): Remove.
9983 * Makefile.in (base_obj): Remove doprnt.o.
9984 * deps.mk (doprnt.o): Remove.
9986 error: Print 32- and 64-bit integers portably (Bug#8435).
9987 Without this change, on typical 64-bit hosts error ("...%d...", N)
9988 was used to print both 32- and 64-bit integers N, which relied on
9990 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9991 * lisp.h (error, verror): Mark as printf-like functions.
9992 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9993 Report overflow in size calculations when allocating printf buffer.
9994 Do not truncate output string at its first null byte.
9995 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9996 Truncate the output at a character boundary, since vsnprintf does not
9998 * charset.c (check_iso_charset_parameter): Convert internal
9999 character to string before calling 'error', since %c now has the
10001 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10002 overflow when computing char to be passed to 'error'. Do not
10003 pass Lisp_Object to 'error'; pass the integer instead.
10004 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10005 formatted with plain %d.
10007 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10009 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10011 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10013 * xterm.c (x_catch_errors): Remove duplicate declaration.
10015 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10017 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10019 2011-04-10 Jim Meyering <meyering@redhat.com>
10021 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10022 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10023 return ssize_t not "int", and use size_t as the buffer length.
10024 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10025 * gnutls.h: Update declarations.
10026 * process.c (read_process_output): Use ssize_t, to match.
10027 (send_process): Likewise.
10029 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10031 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10033 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10035 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10036 Use unsigned char, to match FcChar8 type definition.
10038 * xterm.c (handle_one_xevent):
10039 * xmenu.c (create_and_show_popup_menu):
10040 * xselect.c (x_decline_selection_request)
10041 (x_reply_selection_request): Avoid type-punned deref of X events.
10043 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10045 Fix some uses of `int' instead of EMACS_INT.
10046 * search.c (string_match_1, fast_string_match)
10047 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10048 (scan_buffer, find_next_newline_no_quit)
10049 (find_before_next_newline, search_command, Freplace_match)
10050 (Fmatch_data): Make some `int' variables be EMACS_INT.
10052 * xdisp.c (display_count_lines): 3rd argument and return value now
10053 EMACS_INT. All callers changed.
10054 (pint2hrstr): Last argument is now EMACS_INT.
10056 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10057 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10058 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10059 (decode_coding_utf_16, decode_coding_emacs_mule)
10060 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10061 (decode_coding_ccl, decode_coding_charset)
10062 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10063 (decode_coding_iso_2022, decode_coding_emacs_mule)
10064 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10065 <char_offset, last_offset>: Declare EMACS_INT.
10066 (encode_coding_utf_8, encode_coding_utf_16)
10067 (encode_coding_emacs_mule, encode_invocation_designation)
10068 (encode_designation_at_bol, encode_coding_iso_2022)
10069 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10070 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10072 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10073 (encode_invocation_designation): Last argument P_NCHARS is now
10075 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10076 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10078 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10081 * ccl.c (Fccl_execute_on_string): Declare some variables
10084 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10086 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10088 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10090 * process.c (Fformat_network_address): Doc fix.
10092 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10094 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10096 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10098 * keyboard.c (read_char): Call Lisp function help-form-show,
10099 instead of using internal_with_output_to_temp_buffer.
10100 (Qhelp_form_show): New var.
10101 (syms_of_keyboard): Use DEFSYM macro.
10103 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10105 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10107 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10109 * process.c (Flist_processes): Remove to Lisp.
10110 (list_processes_1): Delete.
10112 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10114 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10116 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10118 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10120 Fix more problems found by GCC 4.6.0's static checks.
10122 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10124 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10126 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10128 * xdisp.c (vmessage): Mark as a printf-like function.
10130 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10132 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10134 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10135 printf-like functions.
10136 (tiff_load): Add casts to remove these marks before passing them
10137 to system-supplied API.
10139 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10141 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10142 This avoids several warnings with gcc -Wstrict-overflow.
10143 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10144 directly, rather than having caller test rule sign. This avoids
10145 some unnecessary tests.
10146 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10147 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10148 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10150 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10151 (xfont_open): Avoid unnecessary tests.
10153 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10155 * composite.h, composite.c (composition_gstring_put_cache):
10156 Use EMACS_INT, not int, for length.
10158 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10159 breaking out part of COMPOSITION_DECODE_RULE.
10160 (COMPOSITION_DECODE_RULE): Use it.
10161 * composite.c (get_composition_id): Remove unused local vars,
10162 by using the new macro.
10164 * textprop.c (set_text_properties_1): Change while to do-while,
10165 since the condition is always true at first.
10167 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10168 (interval_deletion_adjustment): Return unsigned value.
10171 * process.c (list_processes_1, create_pty, read_process_output):
10172 (exec_sentinel): Remove vars that were set but not used.
10173 (create_pty): Remove unnecessary "volatile"s.
10174 (Fnetwork_interface_info): Avoid possibility of int overflow.
10175 (read_process_output): Do adaptive read buffering even if carryover.
10176 (read_process_output): Simplify nbytes computation if buffered.
10178 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10180 * syntax.c (scan_words): Remove var that was set but not used.
10181 (update_syntax_table): Use unsigned instead of int.
10183 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10184 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10185 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10187 * print.c (print_error_message): Avoid int overflow.
10189 * font.c (font_list_entities): Redo for clarity,
10190 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10192 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10193 (font_score): Avoid potential overflow in diff calculation.
10195 * fns.c (substring_both): Remove var that is set but not used.
10196 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10198 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10200 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10201 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10202 can always succeed if overflow has undefined behavior.
10204 * search.c (boyer_moore, wordify): Remove vars set but not used.
10205 (wordify): Omit three unnecessary tests.
10207 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10208 All callers changed. This avoids the need for an unused var.
10210 * casefiddle.c (casify_region): Remove var that is set but not used.
10212 * dired.c (file_name_completion): Remove var that is set but not used.
10214 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10216 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10217 (Finsert_file_contents): Remove unnecessary code checking fd.
10219 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10220 Check for integer overflow on size calculations.
10222 * buffer.c (Fprevious_overlay_change): Remove var that is set
10225 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10226 Remove vars that are set but not used.
10227 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10228 (timer_check_2): Mark vars as initialized.
10230 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10232 * image.c (lookup_image): Remove var that is set but not used.
10233 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10235 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10236 that are set but not used.
10238 * xfns.c (make_invisible_cursor): Don't return garbage
10239 if XCreateBitmapFromData fails (Bug#8410).
10241 * xselect.c (x_get_local_selection, x_handle_property_notify):
10242 Remove vars that are set but not used.
10244 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10245 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10247 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10248 Remove var that is set but not used.
10249 (scroll_bar_windows_size): Now size_t, not int.
10250 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10251 Check for overflow.
10253 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10254 (map_tty_color) [!defined MSDOS]: Likewise.
10256 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10258 * coding.c: Remove vars that are set but not used.
10259 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10260 All callers changed.
10261 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10262 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10263 (decode_coding_charset): Remove vars that are set but not used.
10265 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10266 that is set but not used.
10268 * print.c (print_object): Remove var that is set but not used.
10270 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10271 The gnulib version avoids calling malloc in the usual case,
10272 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10273 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10274 * filelock.c (current_lock_owner): Likewise.
10275 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10276 * sysdep.c: Include allocator.h, careadlinkat.h.
10277 (emacs_no_realloc_allocator): New static constant.
10278 (emacs_readlink): New function.
10279 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10280 ../lib/careadlinkat.h.
10282 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10284 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10285 first non-nil return value).
10287 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10289 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10290 if not defined (Bug#8403).
10292 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10294 * xdisp.c (display_count_lines): Remove parameter `start',
10295 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10296 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10297 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10298 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10299 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10300 and thereabouts. All callers changed.
10301 (get_per_char_metric): Remove parameter `f', unused since
10302 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10304 2011-04-02 Jim Meyering <meyering@redhat.com>
10306 do not dereference NULL upon failed strdup
10307 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10308 (ns_get_family): Likewise.
10310 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10312 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10314 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10316 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10319 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10321 Add lexical binding.
10323 * window.c (Ftemp_output_buffer_show): New fun.
10324 (Fsave_window_excursion):
10325 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10327 * lread.c (lisp_file_lexically_bound_p): New function.
10328 (Fload): Bind Qlexical_binding.
10329 (readevalloop): Remove `evalfun' arg.
10330 Bind Qinternal_interpreter_environment.
10331 (Feval_buffer): Bind Qlexical_binding.
10332 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10334 (syms_of_lread): Declare `lexical-binding'.
10336 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10338 * keyboard.c (eval_dyn): New fun.
10339 (menu_item_eval_property): Use it.
10341 * image.c (parse_image_spec): Use Ffunctionp.
10343 * fns.c (concat, mapcar1): Accept byte-code-functions.
10345 * eval.c (Fsetq): Handle lexical vars.
10346 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10347 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10348 (FletX, Flet): Obey lexical binding.
10349 (Fcommandp): Handle closures.
10350 (Feval): New `lexical' arg.
10351 (eval_sub): New function extracted from Feval. Use it almost
10352 everywhere where Feval was used. Look up vars in lexical env.
10354 (Ffunctionp): Move from subr.el.
10355 (Ffuncall): Handle closures.
10356 (apply_lambda): Remove `eval_flags'.
10357 (funcall_lambda): Handle closures and new byte-code-functions.
10358 (Fspecial_variable_p): New function.
10359 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10360 but without exporting it to Lisp.
10362 * doc.c (Fdocumentation, store_function_docstring):
10363 * data.c (Finteractive_form): Handle closures.
10365 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10368 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10370 (exec_byte_code): New function extracted from Fbyte_code to handle new
10371 calling convention for byte-code-functions. Add new byte-codes.
10373 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10375 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10377 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10379 * xdisp.c (redisplay_internal): Fix prototype.
10381 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10383 * xdisp.c (SCROLL_LIMIT): New macro.
10384 (try_scrolling): Use it when setting scroll_limit.
10385 Limit scrolling to 100 screen lines.
10386 (redisplay_window): Even when falling back on "recentering",
10387 position point in the window according to scroll-conservatively,
10388 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10390 (try_scrolling): When point is above the window, allow searching
10391 as far as scroll_max, or one screenful, to compute vertical
10392 distance from PT to the scroll margin position. This prevents
10393 try_scrolling from unnecessarily failing when
10394 scroll-conservatively is set to a value slightly larger than the
10395 window height. Clean up the case of PT below the margin at bottom
10396 of window: scroll_max can no longer be INT_MAX. When aggressive
10397 scrolling is in use, don't let point enter the opposite scroll
10398 margin as result of the scroll.
10399 (syms_of_xdisp) <scroll-conservatively>: Document the
10400 threshold of 100 lines for never-recentering scrolling.
10402 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10404 * dispextern.h (move_it_by_lines):
10405 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10406 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10407 (message_log_check_duplicate): Remove parameters `prev_bol' and
10408 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10409 (redisplay_internal): Remove parameter `preserve_echo_area',
10410 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10412 * indent.c (Fvertical_motion):
10413 * window.c (window_scroll_pixel_based, Frecenter):
10414 Don't pass `need_y_p' to `move_it_by_lines'.
10416 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10418 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10419 steal a few bits to be more compact.
10420 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10421 Remove unneeded casts.
10423 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10425 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10427 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10428 binding" message (bug#7967).
10430 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10432 Fix more problems found by GCC 4.6.0's static checks.
10434 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10435 Remove unused local var.
10437 * editfns.c (Fmessage_box): Remove unused local var.
10439 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10440 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10441 Omit unused local vars.
10442 * window.c (shrink_windows): Omit unused local var.
10443 * menu.c (digest_single_submenu): Omit unused local var.
10444 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10445 Omit unused local var.
10447 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10448 Don't assume string length fits in int.
10449 (keyremap_step, read_key_sequence): Use size_t for sizes.
10450 (read_key_sequence): Don't check last_real_key_start redundantly.
10452 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10453 instead of alloca (Bug#8344).
10455 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10456 (Fbacktrace_frame): Don't assume nframes fits in int.
10458 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10460 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10463 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10465 * cm.c (calccost): Turn while-do into do-while, for clarity.
10467 * keyboard.c (syms_of_keyboard): Use the same style as later
10468 in this function when indexing through an array. This also
10469 works around GCC bug 48267.
10471 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10473 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10475 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10476 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10478 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10479 This avoids undefined behavior on integer overflow, and is a bit
10480 more convenient anyway since it is compared to a size_t variable.
10482 Variadic C functions now count arguments with size_t, not int.
10483 This avoids an unnecessary limitation on 64-bit machines, which
10484 caused (substring ...) to crash on large vectors (Bug#8344).
10485 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10486 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10487 All variadic functions and their callers changed accordingly.
10488 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10489 * data.c (arith_driver, float_arith_driver): Likewise.
10490 * editfns.c (general_insert_function): Likewise.
10491 * eval.c (struct backtrace.nargs, interactive_p)
10492 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10493 (funcall_lambda, mark_backtrace): Likewise.
10494 * fns.c (concat): Likewise.
10495 * frame.c (x_set_frame_parameters): Likewise.
10496 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10497 0 if not found, not -1. All callers changed.
10499 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10500 (stack_copy_size): Now size_t, not int.
10501 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10503 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10505 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10506 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10507 All callers changed.
10509 * lisp.h (multibyte_char_to_unibyte):
10510 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10511 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10512 * character.h (CHAR_TO_BYTE8):
10513 * cmds.c (internal_self_insert):
10514 * editfns.c (general_insert_function):
10515 * keymap.c (push_key_description):
10516 * search.c (Freplace_match):
10517 * xdisp.c (message_dolog, set_message_1): All callers changed.
10519 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10521 * keyboard.c (safe_run_hook_funcall): New function.
10522 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10523 don't set the hook to nil, but remove the offending function instead.
10524 (Qcommand_hook_internal): Remove, unused.
10525 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10526 Vcommand_hook_internal.
10528 * eval.c (enum run_hooks_condition): Remove.
10529 (funcall_nil, funcall_not): New functions.
10530 (run_hook_with_args): Call each function through a `funcall' argument.
10531 Remove `cond' argument, now redundant.
10532 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10533 (Frun_hook_with_args_until_failure): Adjust accordingly.
10534 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10536 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10538 * dispextern.h (string_buffer_position): Remove declaration.
10540 * print.c (strout): Remove parameter `multibyte', unused since
10541 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10543 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10544 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10545 All callers changed.
10547 * w32.c (_wsa_errlist): Use braces for struct initializers.
10549 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10550 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10551 All callers changed.
10552 (string_buffer_position): Likewise. Also, make static (it's never
10553 used outside xdisp.c).
10554 (cursor_row_p): Remove parameter `w', unused since
10555 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10556 (decode_mode_spec): Remove parameter `precision', introduced during
10557 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10558 All callers changed.
10560 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10562 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10564 2011-03-27 Anders Lindgren <andlind@gmail.com>
10566 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10567 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10568 (ns_update_auto_hide_menu_bar): New functions.
10569 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10570 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10571 ns_constrain_all_frames.
10572 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10573 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10575 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10577 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10579 2011-03-27 Glenn Morris <rgm@gnu.org>
10581 * syssignal.h: Replace RETSIGTYPE with void.
10582 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10583 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10584 Replace SIGTYPE with void everywhere.
10585 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10586 * s/template.h (SIGTYPE): Remove commented out definition.
10588 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10590 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10591 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10593 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10595 * w32.c (read_unc_volume): Use parameter `henum', instead of
10596 global variable `wget_enum_handle'.
10598 * keymap.c (describe_vector): Remove parameters `indices' and
10599 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10600 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10602 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10604 * keyboard.c (timer_check): Remove parameter `do_it_now',
10605 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10606 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10607 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10609 * keyboard.c (read_char):
10610 * w32menu.c (w32_menu_display_help):
10611 * xmenu.c (show_help_event, menu_help_callback):
10612 Adjust calls to `show_help_echo'.
10614 * gtkutil.c (xg_maybe_add_timer):
10615 * keyboard.c (readable_events):
10616 * process.c (wait_reading_process_output):
10617 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10619 * insdel.c (adjust_markers_gap_motion):
10620 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10621 (gap_left, gap_right): Don't call it.
10623 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10625 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10626 incurred during fontification.
10628 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10630 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10631 (DEFVAR_PER_BUFFER): Don't pass it.
10633 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10634 (scrolling_window): Don't pass it.
10636 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10638 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10640 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10642 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10643 of variables specific to SELinux and computation of `encoded_absname'.
10645 * image.c (XPutPixel): Remove unused variable `height'.
10647 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10649 * unexw32.c (get_section_info): Remove unused variable `section'.
10651 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10652 (system_process_attributes): Remove unused variable `sess'.
10653 (sys_read): Remove unused variable `err'.
10655 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10656 (w32_wnd_proc): Remove unused variable `isdead'.
10657 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10658 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10659 (x_create_tip_frame): Remove unused variable `tem'.
10661 * w32inevt.c (w32_console_read_socket):
10662 Remove unused variable `no_events'.
10664 * w32term.c (x_draw_composite_glyph_string_foreground):
10665 Remove unused variable `width'.
10667 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10669 * w32term.c (x_set_glyph_string_clipping):
10670 Don't pass uninitialized region to CombineRgn.
10672 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10674 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10675 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10676 (Fx_close_connection): Remove unused variable `i'.
10678 * w32font.c (w32font_draw): Return number of glyphs.
10679 (w32font_open_internal): Remove unused variable `i'.
10680 (w32font_driver): Add missing initializer.
10682 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10683 (fill_in_menu): Remove unused variable `items_added'.
10685 * w32term.c (last_mouse_press_frame): Remove static global variable.
10686 (w32_clip_to_row): Remove unused variable `f'.
10687 (x_delete_terminal): Remove unused variable `i'.
10689 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10690 (NOTHING): Remove unused static global variable.
10691 (uniscribe_check_otf): Remove unused variable `table'.
10692 (uniscribe_font_driver): Add missing initializers.
10694 2011-03-23 Julien Danjou <julien@danjou.info>
10696 * term.c (Fsuspend_tty, Fresume_tty):
10697 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10698 * window.c (temp_output_buffer_show):
10699 * insdel.c (signal_before_change):
10700 * frame.c (Fhandle_switch_frame):
10701 * fileio.c (Fdo_auto_save):
10702 * emacs.c (Fkill_emacs):
10703 * editfns.c (save_excursion_restore):
10704 * cmds.c (internal_self_insert):
10705 * callint.c (Fcall_interactively):
10706 * buffer.c (Fkill_all_local_variables):
10707 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10709 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10710 unconditionally since it does the check itself.
10712 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10714 Fix more problems found by GCC 4.5.2's static checks.
10716 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10717 the first time through the loop, since we know p0 < p1 then.
10718 This also avoids a gcc -Wstrict-overflow warning.
10720 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10721 leading to a memory leak, possible in functions like
10722 load_charset_map_from_file that can allocate an unbounded number
10723 of objects (Bug#8318).
10725 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10726 that could (at least in theory) be that large.
10728 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10729 This is less likely to overflow, and avoids undefined behavior if
10730 overflow does occur. All callers changed. Use strtoul to scan
10731 for the unsigned long integer.
10732 (pint2hrstr): Simplify and tune code slightly.
10733 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10735 * scroll.c (do_scrolling): Work around GCC bug 48228.
10736 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10738 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10739 This also avoids a warning with gcc -Wstrict-overflow.
10740 (validate_x_resource_name): Simplify count usage.
10741 This also avoids a warning with gcc -Wstrict-overflow.
10743 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10746 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10748 * process.c (Fmake_network_process): Use socklen_t, not int,
10749 where POSIX says socklen_t is required in portable programs.
10750 This fixes a porting bug on hosts like 64-bit HP-UX, where
10751 socklen_t is wider than int (Bug#8277).
10752 (Fmake_network_process, server_accept_connection):
10753 (wait_reading_process_output, read_process_output):
10756 * process.c: Rename or move locals to avoid shadowing.
10757 (list_processes_1, Fmake_network_process):
10758 (read_process_output_error_handler, exec_sentinel_error_handler):
10759 Rename or move locals.
10760 (Fmake_network_process): Define label "retry_connect" only if needed.
10761 (Fnetwork_interface_info): Fix pointer signedness.
10762 (process_send_signal): Add cast to avoid pointer signedness problem.
10763 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10764 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10766 Make tparam.h and terminfo.c consistent.
10767 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10768 Include tparam.h instead, since it declares them.
10769 * cm.h (PC): Remove extern decl; tparam.h now does this.
10770 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10771 * terminfo.c: Include tparam.h, to check interfaces.
10772 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10773 (tparam): Adjust signature to match interface in tparam.h;
10774 this removes some undefined behavior. Check that outstring and len
10775 are zero, which they always are with Emacs.
10776 * tparam.h (PC, BC, UP): New extern decls.
10778 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10779 (xftfont_open): Rename locals to avoid shadowing.
10781 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10782 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10783 (OTF_TAG_SYM): Omit macro if not needed.
10784 (ftfont_list): Remove unused local.
10785 (get_adstyle_property, ftfont_pattern_entity):
10786 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10787 Rename locals to avoid shadowing.
10789 * xfont.c (xfont_list_family): Mark var as initialized.
10791 * xml.c (make_dom): Now static.
10793 * composite.c (composition_compute_stop_pos): Rename local to
10795 (composition_reseat_it): Remove unused locals.
10796 (find_automatic_composition, composition_adjust_point): Likewise.
10797 (composition_update_it): Mark var as initialized.
10798 (find_automatic_composition): Mark vars as initialized,
10799 with a FIXME (Bug#8290).
10801 character.h: Rename locals to avoid shadowing.
10802 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10803 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10804 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10805 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10806 to avoid shadowing.
10808 * textprop.c (property_change_between_p): Remove; unused.
10810 * intervals.c (interval_start_pos): Now static.
10812 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10814 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10815 Rename locals to avoid shadowing.
10817 * sound.c (wav_play, au_play, Fplay_sound_internal):
10818 Fix pointer signedness.
10819 (alsa_choose_format): Remove unused local var.
10820 (wav_play): Initialize a variable to 0, to prevent undefined
10821 behavior (Bug#8278).
10823 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10825 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10827 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10828 clobbering (Bug#8298).
10829 * sysdep.c (sys_subshell): Likewise.
10830 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10832 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10833 This should get cleaned up, so that child_setup has the
10834 same signature on all platforms.
10836 * callproc.c (call_process_cleanup): Now static.
10837 (relocate_fd): Rename locals to avoid shadowing.
10839 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10841 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10842 not to be necessary, and produces flickering.
10844 2011-03-20 Glenn Morris <rgm@gnu.org>
10846 * config.in: Remove file.
10848 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10850 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10851 are now in src/globals.h.
10852 (syms_of_minibuf): Remove spurious & from previous change.
10854 2011-03-20 Leo Liu <sdl.web@gmail.com>
10856 * minibuf.c (completing-read-function): New variable.
10857 (completing-read-default): Rename from completing-read.
10858 (completing-read): Call completing-read-function.
10860 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10862 * xfaces.c (Fx_load_color_file):
10863 Read color file from absolute filename (bug#8250).
10865 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10867 * makefile.w32-in: Update dependencies.
10869 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10871 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10873 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10875 Fix more problems found by GCC 4.5.2's static checks.
10877 * process.c (make_serial_process_unwind, send_process_trap):
10878 (sigchld_handler): Now static.
10880 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10881 That way, the code declares only the vars that it needs.
10882 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10883 * s/cygwin.h (PTY_ITERATION): Likewise.
10884 * s/darwin.h (PTY_ITERATION): Likewise.
10885 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10887 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10888 * process.c (allocate_pty): Don't declare stb unless it's needed.
10890 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10891 (CONSTANTLIM): Remove; unused.
10892 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10893 Define only if needed.
10895 * unexelf.c (unexec): Name an expression,
10896 to avoid gcc -Wbad-function-cast warning.
10897 Use a different way to cause a compilation error if anyone uses
10898 n rather than nn, a way that does not involve shadowing.
10899 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10901 * deps.mk (unexalpha.o): Remove; unused.
10903 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10904 * unexec.h: New file.
10905 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10906 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10907 Depend on unexec.h.
10908 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10909 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10910 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10911 Change as necessary to match prototype in unexec.h.
10913 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10915 (back_comment, skip_chars): Mark vars as initialized.
10917 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10918 Rename locals to avoid shadowing.
10920 * lread.c (read1): Rewrite so as not to use empty "else".
10921 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10923 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10925 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10926 warning when compiling print.c.
10928 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10929 instead of using an uninitialized var.
10930 (font_sort_entities): Mark var as initialized.
10932 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10934 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10935 pointers to constants.
10936 (font_parse_fcname): Remove unused vars.
10937 (font_delete_unmatched): Now static.
10938 (font_get_spec): Remove; unused.
10939 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10940 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10941 Rename or move locals to avoid shadowing.
10943 * fns.c (require_nesting_list, require_unwind): Now static.
10944 (Ffillarray): Rename locals to avoid shadowing.
10946 * floatfns.c (domain_error2): Define only if needed.
10947 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10949 * alloc.c (mark_backtrace): Move decl from here ...
10950 * lisp.h: ... to here, so that it can be checked.
10952 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10953 (Fdefvar): Rewrite so as not to use empty "else".
10954 (lisp_indirect_variable): Name an expression,
10955 to avoid gcc -Wbad-function-cast warning.
10956 (Fdefvar): Rename locals to avoid shadowing.
10958 * callint.c (quotify_arg, quotify_args): Now static.
10959 (Fcall_interactively): Rename locals to avoid shadowing.
10960 Use const pointer when appropriate.
10962 * lisp.h (get_system_name, get_operating_system_release):
10963 Move decls here, to check interfaces.
10964 * process.c (get_operating_system_release): Move decl to lisp.h.
10965 * xrdb.c (get_system_name): Likewise.
10966 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10967 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10968 some of which prompt warnings from gcc -Wbad-function-cast.
10969 (Fformat_time_string, Fencode_time, Finsert_char):
10970 (Ftranslate_region_internal, Fformat):
10971 Rename or remove local vars to avoid shadowing.
10972 (Ftranslate_region_internal): Mark var as initialized.
10974 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10977 * lisp.h (eassert): Check that the argument compiles, even if
10978 ENABLE_CHECKING is not defined.
10980 * data.c (Findirect_variable): Name an expression, to avoid
10981 gcc -Wbad-function-cast warning.
10982 (default_value, arithcompare, arith_driver, arith_error): Now static.
10983 (store_symval_forwarding): Rename local to avoid shadowing.
10984 (Fmake_variable_buffer_local, Fmake_local_variable):
10985 Mark variables as initialized.
10986 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10988 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10989 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10990 Rename locals to avoid shadowing.
10991 (mark_stack): Move local variables into the #ifdef region where
10993 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10994 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10996 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10997 (GC_STRING_CHARS): Remove; not used.
10998 (Fmemory_limit): Cast sbrk's returned value to char *.
11000 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11001 avoids undefined behavior in theory.
11003 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11005 Use functions, not macros, for up- and down-casing (Bug#8254).
11006 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11007 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11008 to use the following functions instead of these macros.
11009 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11010 EMACS_INT, since callers assume the returned value fits in int.
11011 (upcase1): Likewise, for UPCASE_TABLE.
11012 (uppercasep, lowercasep, upcase): New static inline functions.
11013 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11014 the race-condition problem in the old DOWNCASE.
11016 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11017 Rename locals to avoid shadowing.
11018 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11019 (regex_compile, re_search_2, re_match_2_internal):
11020 Remove unused local vars.
11021 (FREE_VAR): Rewrite so as not to use empty "else",
11022 which gcc can warn about.
11023 (regex_compile, re_match_2_internal): Mark locals as initialized.
11024 (RETALLOC_IF): Define only if needed.
11025 (WORDCHAR_P): Likewise. This one is never needed, but is used
11026 only in a comment talking about a compiler bug, so put inside
11027 the #if 0 of that comment.
11028 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11029 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11032 * search.c (boyer_moore): Rename locals to avoid shadowing.
11033 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11034 (PREV_CHAR_BOUNDARY): Likewise.
11036 * search.c (simple_search): Remove unused var.
11038 * dired.c (compile_pattern): Move decl from here ...
11039 * lisp.h: ... to here, so that it can be checked.
11040 (struct re_registers): New forward decl.
11042 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11044 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11046 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11047 Rename locals to avoid shadowing.
11048 (Fvertical_motion): Mark locals as initialized.
11050 * casefiddle.c (casify_object, casify_region): Now static.
11051 (casify_region): Mark local as initialized.
11053 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11055 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11056 New macros, so that the caller can use some names other than
11057 gcpro1, gcpro2, etc.
11058 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11060 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11061 argument, for consistency with GCPRO2_VAR, etc: it is now the
11062 prefix of the variable, not the variable itself. All uses
11064 * dired.c (directory_files_internal, file_name_completion):
11065 Rename locals to avoid shadowing.
11067 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11068 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11069 dired.c's scmp function, had undefined behavior.
11070 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11071 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11072 * buffer.h: ... to here, because these macros use current_buffer,
11073 and the new implementation with inline functions needs to have
11074 current_buffer in scope now, rather than later when the macros
11076 (downcase, upcase1): New static inline functions.
11077 (DOWNCASE, UPCASE1): Reimplement using these functions.
11078 This avoids undefined behavior in expressions like
11079 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11080 from race conditions in accessing the global variables
11081 case_temp1 and case_temp2.
11082 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11083 * lisp.h (case_temp1, case_temp2): Remove their decls.
11084 * character.h (ASCII_CHAR_P): Move from here ...
11085 * lisp.h: ... to here, so that the inline functions mentioned
11086 above can use them.
11088 * dired.c (directory_files_internal_unwind): Now static.
11090 * fileio.c (file_name_as_directory, directory_file_name):
11091 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11093 (file_name_as_directory): Use const pointers when appropriate.
11094 (Fexpand_file_name): Likewise. In particular, newdir might
11095 point at constant storage, so make it a const pointer.
11096 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11097 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11099 (Fset_file_times, Finsert_file_contents, auto_save_error):
11100 Rename locals to avoid shadowing.
11102 * minibuf.c (choose_minibuf_frame_1): Now static.
11103 (Ftry_completion, Fall_completions): Rename or remove locals
11104 to avoid shadowing.
11106 * marker.c (bytepos_to_charpos): Remove; unused.
11108 * lisp.h (verify_bytepos, count_markers): New decls,
11109 so that gcc does not warn that these functions aren't declared.
11111 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11112 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11113 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11114 (copy_text): Remove unused local var.
11116 * filelock.c (within_one_second): Now static.
11117 (lock_file_1): Rename local to avoid shadowing.
11119 * buffer.c (fix_overlays_before): Mark locals as initialized.
11120 (fix_start_end_in_overlays): Likewise. This function should be
11121 simplified by using pointers-to-pointers, but that's a different
11123 (switch_to_buffer_1): Now static.
11124 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11125 (report_overlay_modification): Rename locals to avoid shadowing.
11127 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11128 Fix pointer signedness issue.
11129 (sys_subshell): Mark local as volatile if checking for lint,
11130 to suppress a gcc -Wclobbered warning that does not seem to be right.
11131 (MAXPATHLEN): Define only if needed.
11133 * process.c (serial_open, serial_configure): Move decls from here ...
11134 * systty.h: ... to here, so that they can be checked.
11136 * fns.c (get_random, seed_random): Move extern decls from here ...
11137 * lisp.h: ... to here, so that they can be checked.
11139 * sysdep.c (reset_io): Now static.
11140 (wait_for_termination_signal): Remove; unused.
11142 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11143 (copy_keymap_item, append_key, push_text_char_description):
11145 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11146 (DENSE_TABLE_SIZE): Remove; unused.
11147 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11148 (describe_map_tree):
11149 Rename locals to avoid shadowing.
11151 * keyboard.c: Declare functions static if they are not used elsewhere.
11152 (echo_char, echo_dash, cmd_error, top_level_2):
11153 (poll_for_input, handle_async_input): Now static.
11154 (read_char, kbd_buffer_get_event, make_lispy_position):
11155 (make_lispy_event, make_lispy_movement, apply_modifiers):
11156 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11157 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11158 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11159 (read_key_sequence, read_char): Mark locals as initialized.
11160 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11162 * keyboard.h (make_ctrl_char): New decl.
11163 (mark_kboards): Move decl here ...
11164 * alloc.c (mark_kboards): ... from here.
11166 * lisp.h (force_auto_save_soon): New decl.
11168 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11169 (DEFINE_DUMMY_FUNCTION): New macro.
11170 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11172 (main): Add casts to avoid warnings
11173 if GCC considers string literals to be constants.
11175 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11177 * dbusbind.c: Pointer signedness fixes.
11178 (xd_signature, xd_append_arg, xd_initialize):
11179 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11180 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11181 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11182 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11184 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11185 if GCC considers string literals to be constants.
11186 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11188 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11190 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11191 (print_preprocess, print_object): New macro to fix last change.
11193 * print.c (print_preprocess): Don't forget font objects.
11195 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11197 * emacs.c (USAGE3): Doc fixes.
11199 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11201 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11204 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11206 * lisp.h (VWindow_system, Qfile_name_history):
11207 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11208 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11209 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11211 * w32select.c: Don't #include "keyboard.h".
11212 (run_protected): Add extern declaration for waiting_for_input.
11214 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11215 * w32console.c (detect_input_pending, read_input_pending)
11216 (encode_terminal_code):
11217 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11218 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11219 (w32_system_caret_y, Qfile_name_history):
11220 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11221 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11222 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11223 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11224 * w32proc.c (Qlocal, report_file_error):
11225 * w32term.c (Vwindow_system, updating_frame):
11226 * w32uniscribe.c (initialized, uniscribe_font_driver):
11227 Remove unneeded extern declarations.
11229 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11231 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11233 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11235 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11236 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11237 These macros can no longer be used for assignment.
11239 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11240 Assign struct members directly, instead of using BUF_BEGV etc.
11241 (record_buffer_markers, fetch_buffer_markers): New functions for
11242 recording and fetching special buffer markers.
11243 (set_buffer_internal_1, set_buffer_temp): Use them.
11245 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11247 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11249 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11250 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11252 * xdisp.c (hscroll_window_tree):
11253 (reconsider_clip_changes): Use PT instead of BUF_PT.
11255 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11257 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11258 $(EMACS_ROOT)/lib/intprops.h.
11260 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11262 Fix more problems found by GCC 4.5.2's static checks.
11264 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11265 to unsigned char * to avoid compiler diagnostic.
11266 (xg_free_frame_widgets): Make it clear that a local variable is
11267 needed only if USE_GTK_TOOLTIP.
11268 (gdk_window_get_screen): Make it clear that this macro is needed
11269 only if USE_GTK_TOOLTIP.
11270 (int_gtk_range_get_value): New function, which avoids a diagnostic
11271 from gcc -Wbad-function-cast.
11272 (xg_set_toolkit_scroll_bar_thumb): Use it.
11273 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11274 diagnostic from gcc -Wbad-function-cast.
11275 (get_utf8_string, xg_get_file_with_chooser):
11276 Rename locals to avoid shadowing.
11277 (create_dialog): Move locals to avoid shadowing.
11279 * xgselect.c (xg_select): Remove unused var.
11281 * image.c (four_corners_best): Mark locals as initialized.
11282 (gif_load): Initialize transparent_p to zero (Bug#8238).
11283 Mark another local as initialized.
11284 (my_png_error, my_error_exit): Mark with NO_RETURN.
11286 * image.c (clear_image_cache): Now static.
11287 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11288 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11289 (x_edge_detection): Remove unnecessary cast that
11290 gcc -Wbad-function-cast diagnoses.
11291 (gif_load): Fix pointer signedness.
11292 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11293 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11295 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11297 Improve quality of tests for time stamp overflow.
11298 For example, without this patch (encode-time 0 0 0 1 1
11299 1152921504606846976) returns the obviously-bogus value (-948597
11300 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11301 reports time overflow. See
11302 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11303 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11304 * editfns.c: Include limits.h and intprops.h.
11305 (TIME_T_MIN, TIME_T_MAX): New macros.
11306 (time_overflow): Move earlier, to before first use.
11307 (hi_time, lo_time): New functions, for an accurate test for
11308 out-of-range times.
11309 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11310 (Fget_internal_run_time): Don't assume time_t fits in int.
11311 (make_time): Use list2 instead of Fcons twice.
11312 (Fdecode_time): More accurate test for out-of-range times.
11313 (check_tm_member): New function.
11314 (Fencode_time): Use it, to test for out-of-range times.
11315 (lisp_time_argument): Don't rely on undefined left-shift and
11316 right-shift behavior when checking for time stamp overflow.
11318 * editfns.c (time_overflow): New function, refactoring common code.
11319 (Fformat_time_string, Fdecode_time, Fencode_time):
11320 (Fcurrent_time_string): Use it.
11322 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11323 * dired.c (make_time): Move to ...
11324 * editfns.c (make_time): ... here.
11325 * systime.h: Note the move.
11327 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11329 * fringe.c (update_window_fringes): Remove unused variables.
11331 * unexmacosx.c (copy_data_segment): Also copy __got section.
11334 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11336 * termcap.c [MSDOS]: Include "msdos.h".
11337 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11338 Constify `char *' arguments and their references according to
11339 prototypes in tparam.h.
11341 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11343 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11344 Adapt all references accordingly.
11346 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11348 2011-03-11 Tom Tromey <tromey@redhat.com>
11350 * buffer.c (syms_of_buffer): Remove obsolete comment.
11352 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11354 * termhooks.h (encode_terminal_code): Declare prototype.
11356 * msdos.c (encode_terminal_code): Don't declare prototype.
11358 * term.c (encode_terminal_code): Now external again, used by
11359 w32console.c and msdos.c.
11361 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11362 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11364 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11366 Fix some minor problems found by GCC 4.5.2's static checks.
11368 * fringe.c (update_window_fringes): Mark locals as initialized
11370 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11372 * alloc.c (mark_fringe_data): Move decl from here ...
11373 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11374 to check its interface.
11375 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11377 * fontset.c (free_realized_fontset): Now static.
11378 (Fset_fontset_font): Rename local to avoid shadowing.
11379 (fontset_font): Mark local as initialized.
11380 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11382 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11384 * xselect.c (x_disown_buffer_selections): Remove; not used.
11385 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11386 (x_own_selection, Fx_disown_selection_internal): Rename locals
11387 to avoid shadowing.
11388 (x_handle_dnd_message): Remove local to avoid shadowing.
11390 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11391 so that the caller can use some name other than gcpro1.
11392 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11393 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11394 (Fx_backspace_delete_keys_p):
11395 Use them to avoid shadowing, and rename vars to avoid shadowing.
11396 (x_decode_color, x_set_name, x_window): Now static.
11397 (Fx_create_frame): Add braces to silence GCC warning.
11398 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11399 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11400 Remove unused locals.
11401 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11402 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11403 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11406 * xterm.h (x_mouse_leave): New decl.
11408 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11409 Remove unused functions.
11410 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11411 (x_calc_absolute_position): Now static.
11412 (XTread_socket): Don't define label "out" unless it's used.
11413 Don't declare local "event" unless it's used.
11414 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11415 unless they are used.
11416 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11417 (x_fatal_error_signal): Remove; not used.
11418 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11419 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11420 (x_error_catcher, x_connection_closed, x_error_handler):
11421 (x_error_quitter, xembed_send_message, x_iconify_frame):
11422 (my_log_handler): Rename locals to avoid shadowing.
11423 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11424 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11426 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11427 Rename or move locals to avoid shadowing.
11428 (tty_defined_color, merge_face_heights): Now static.
11429 (free_realized_faces_for_fontset): Remove; not used.
11430 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11431 does not deduce is never used uninitialized.
11432 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11433 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11435 * terminal.c (store_terminal_param): Now static.
11437 * xmenu.c (menu_highlight_callback): Now static.
11438 (set_frame_menubar): Remove unused local.
11439 (xmenu_show): Rename parameter to avoid shadowing.
11440 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11441 since they might point to immutable storage.
11442 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11443 since it's unused otherwise.
11445 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11446 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11447 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11448 avoids a gcc -Wuninitialized diagnostic.
11449 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11450 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11451 does not deduce are never used uninitialized.
11453 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11455 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11456 * window.c (window_loop, size_window):
11457 (run_window_configuration_change_hook, enlarge_window): Likewise.
11459 * window.c (display_buffer): Now static.
11460 (size_window): Mark variables that gcc -Wuninitialized
11461 does not deduce are never used uninitialized.
11462 * window.h (check_all_windows): New decl, to forestall
11463 gcc -Wmissing-prototypes diagnostic.
11464 * dispextern.h (bidi_dump_cached_states): Likewise.
11466 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11468 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11469 Include <limits.h>.
11470 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11471 and to avoid gcc -Wuninitialized warning.
11472 (load_charset_map): Mark variables that gcc -Wuninitialized
11473 does not deduce are never used uninitialized.
11474 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11476 * coding.c (coding_set_source, coding_set_destination):
11477 Use "else { /* comment */ }" rather than "else /* comment */;"
11478 for clarity, and to avoid gcc -Wempty-body warning.
11479 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11480 a block, when the outer 'i' will do.
11481 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11482 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11483 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11484 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11485 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11486 Rename locals to avoid shadowing.
11487 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11488 * coding.c (emacs_mule_char, encode_invocation_designation):
11489 Now static, since they're not used elsewhere.
11490 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11491 (decode_coding_object, encode_coding_object, detect_coding_system):
11492 (decode_coding_emacs_mule): Mark variables that gcc
11493 -Wuninitialized does not deduce are never used uninitialized.
11494 (detect_coding_iso_2022): Initialize a local variable that might
11495 be used uninitialized. Leave a FIXME because it's not clear that
11496 this initialization is needed. (Bug#8211)
11497 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11498 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11499 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11500 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11501 Remove unused macros.
11503 * category.c (hash_get_category_set): Remove unused local var.
11504 (copy_category_table): Now static, since it's not used elsewhere.
11505 * character.c (string_count_byte8): Likewise.
11507 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11508 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11510 * chartab.c (copy_sub_char_table): Now static, since it's not used
11512 (sub_char_table_ref_and_range, char_table_ref_and_range):
11513 Rename locals to avoid shadowing.
11514 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11516 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11517 (BIDI_BOB): Remove unused macro.
11519 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11520 deduce are never used uninitialized.
11521 * term.c (encode_terminal_code): Likewise.
11523 * term.c (encode_terminal_code): Now static. Remove unused local.
11525 * tparam.h: New file.
11526 * term.c, tparam.h: Include it.
11527 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11528 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11529 Move these decls to tparam.h, and make them agree with what
11530 is actually in tparam.c. The previous trick of using incompatible
11531 decls in different modules does not conform to the C standard.
11532 All callers of tparam changed to use tparam's actual API.
11533 * tparam.c (tparam1, tparam, tgoto):
11534 Use const pointers where appropriate.
11536 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11537 * cm.h (struct cm): Likewise.
11538 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11539 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11540 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11541 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11542 (turn_on_face, init_tty): Likewise.
11543 * termchar.h (struct tty_display_info): Likewise.
11545 * term.c (term_mouse_position): Rename local to avoid shadowing.
11547 * alloc.c (mark_ttys): Move decl from here ...
11548 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11550 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11552 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11554 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11556 * search.c (compile_pattern_1): Remove argument regp, unused since
11557 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11558 (compile_pattern): Don't pass it.
11560 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11562 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11563 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11565 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11567 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11569 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11570 gdk_window_get_screen, gdk_window_get_geometry,
11571 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11572 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11573 (xg_get_pixbuf_from_pixmap): New function.
11574 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11575 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11576 Call xg_get_pixbuf_from_pixmap instead of
11577 gdk_pixbuf_get_from_drawable.
11578 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11579 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11580 (xg_check_special_colors): Use GtkStyleContext and its functions
11582 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11583 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11584 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11585 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11586 Call gtk_widget_get_preferred_size.
11587 (xg_frame_resized): gdk_window_get_geometry only takes 5
11589 (xg_win_to_widget, xg_event_is_for_menubar):
11590 Call gdk_x11_window_lookup_for_display.
11591 (xg_set_widget_bg): New function.
11592 (delete_cb): New function.
11593 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11594 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11595 (xg_set_background_color): Call xg_set_widget_bg.
11596 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11597 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11598 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11599 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11601 (update_frame_tool_bar): Call gtk_widget_hide.
11602 (xg_initialize): Use GDK_KEY_g.
11604 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11606 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11608 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11609 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11610 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11612 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11614 * w32xfns.c (select_palette): Check success of RealizePalette against
11615 GDI_ERROR, not zero.
11617 See ChangeLog.11 for earlier changes.
11619 ;; Local Variables:
11623 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11625 This file is part of GNU Emacs.
11627 GNU Emacs is free software: you can redistribute it and/or modify
11628 it under the terms of the GNU General Public License as published by
11629 the Free Software Foundation, either version 3 of the License, or
11630 (at your option) any later version.
11632 GNU Emacs is distributed in the hope that it will be useful,
11633 but WITHOUT ANY WARRANTY; without even the implied warranty of
11634 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11635 GNU General Public License for more details.
11637 You should have received a copy of the GNU General Public License
11638 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.