]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Fix vertical cursor motion under bidi on auto-composed characters.
[gnu-emacs] / src / ChangeLog
1 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4 consider it a hit if to_charpos is anywhere in the range of the
5 composed buffer positions.
6
7 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8
9 * image.c (gif_load): Don't assume that each subimage has the same
10 dimensions as the base image. Handle disposal method that is
11 "undefined" by the gif spec (Bug#9335).
12
13 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
14
15 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
16 (Fcondition_case): Document `debug' symbol in error handler.
17
18 2011-08-19 Eli Zaretskii <eliz@gnu.org>
19
20 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
21 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
22 from an Org mode buffer to a Speedbar frame.
23
24 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
25 a composition, take its buffer position from IT->cmp_it.charpos.
26 Fixes cursor positioning at the beginning of a line that begins
27 with a composed character.
28
29 2011-08-18 Eli Zaretskii <eliz@gnu.org>
30
31 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
32 character bidirectional type, use STRONG_L instead. Fixes crashes
33 in a buffer produced by `describe-categories'.
34
35 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
36 members before the level stack, so they would be saved and
37 restored when copying iterator state. Fixes incorrect reordering
38 around TABs covered by display properties.
39
40 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
41
42 * process.c (Fnetwork_interface_list): Correctly determine buffer
43 size.
44
45 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
46
47 * eval.c (internal_condition_case, internal_condition_case_1)
48 (internal_condition_case_2, internal_condition_case_n): Remove
49 unnecessary aborts (Bug#9081).
50
51 2011-08-17 Eli Zaretskii <eliz@gnu.org>
52
53 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
54 has no `load' handler, try opening the file locally. (Bug#9311)
55
56 2011-08-16 Ken Brown <kbrown@cornell.edu>
57
58 * gmalloc.c: Expand comment.
59
60 2011-08-16 Eli Zaretskii <eliz@gnu.org>
61
62 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
63 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
64
65 2011-08-16 Ken Brown <kbrown@cornell.edu>
66
67 Fix memory allocation problems in Cygwin build (Bug#9273).
68
69 * unexcw.c ( __malloc_initialized): Declare external variable.
70 (fixup_executable): Force the dumped emacs to reinitialize malloc.
71
72 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
73 variables.
74 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
75 dumped emacs.
76 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
77 in the static heap.
78 [CYGWIN] (special_realloc): New function.
79 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
80 requests to realloc storage in the static heap.
81
82 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
83
84 * bidi.c (bidi_initialize): Remove unused local.
85
86 2011-08-15 Eli Zaretskii <eliz@gnu.org>
87
88 * biditype.h: File removed.
89
90 * bidimirror.h: File removed.
91
92 * deps.mk (bidi.o): Remove biditype.h and
93 bidimirror.h.
94
95 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
96 bidimirror.h.
97
98 * dispextern.h: Fix a typo in the comment to bidi_type_t.
99
100 * chartab.c: Improve commentary for the uniprop_table API.
101
102 * bidi.c (bidi_paragraph_init): Support zero value of
103 bidi_ignore_explicit_marks_for_paragraph_level.
104 (bidi_initialize): Use uniprop_table instead of including
105 biditype.h and bidimirror.h.
106
107 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
108 coordinates of the iterator when restoring from ppos_it.
109 (Bug#9296)
110
111 2011-08-14 Kenichi Handa <handa@m17n.org>
112
113 * process.c (create_process): Call setup_process_coding_systems
114 after the pid of the process is set to -1 (Bug#8162).
115
116 2011-08-14 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (move_it_in_display_line_to): Don't invoke
119 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
120 ppos_it. Fixes vertical cursor motion when line beginning is
121 covered by an image. (Bug#9296)
122
123 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
124
125 * nsterm.h (ns_run_ascript): Declare.
126 (NSAPP_DATA2_RUNASSCRIPT): Define.
127
128 * nsfns.m (as_script, as_result, as_status): New static variables.
129 (ns_run_ascript): New function.
130 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
131 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
132 the event loop. Get status from as_status (Bug#7276).
133
134 * nsterm.m (sendEvent): If event is NSApplicationDefined and
135 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
136 the event loop (Bug#7276).
137
138 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
139
140 * gnutls.c (QCgnutls_bootprop_priority)
141 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
142 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
143 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
144 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
145 (QCgnutls_bootprop_verify_hostname_error)
146 (QCgnutls_bootprop_callbacks_verify): Rename from
147 Qgnutls_bootprop_..., all uses changed.
148
149 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
150 uses changed.
151
152 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
153
154 * xfaces.c (Qframe_set_background_mode): Now static.
155 * dispextern.h (Qframe_set_background_mode): Remove decl.
156
157 * process.c (Fnetwork_interface_info): Declare local only if needed.
158
159 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
160
161 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
162 (Fnetwork_interface_list): Allocate in increments of bytes instead
163 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
164 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
165 sockaddr.
166 (struct ifflag_def): notrailers is smart on OSX.
167 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
168 Get hardware address with getifaddrs if available.
169
170 2011-08-12 Eli Zaretskii <eliz@gnu.org>
171
172 * xdisp.c (iterate_out_of_display_property): xassert that
173 IT->position is set to within IT->object's boundaries. Break from
174 the loop as soon as EOB is reached; avoids infloops in redisplay
175 when IT->position is set up wrongly due to some bug. Set
176 IT->current to match the bidi iterator unconditionally.
177 (push_display_prop): Allow GET_FROM_STRING as IT->method on
178 entry. Force push_it to save on the stack the current
179 buffer/string position, to be restored by pop_it. Fix flags in
180 the iterator structure wrt the object coming from a display
181 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
182 properties. (Bug#9284)
183
184 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
185
186 * fontset.c (fontset_get_font_group): Add proper type checks.
187 (Bug#9172)
188
189 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
190
191 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
192 and LC_VERSION_MIN_MACOSX.
193 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
194 (dump_it) [LC_FUNCTION_STARTS]: Use it.
195
196 2011-08-08 Eli Zaretskii <eliz@gnu.org>
197
198 * xdisp.c (forward_to_next_line_start): Allow to use the
199 no-display-properties-and-no-overlays under bidi display. Set
200 disp_pos in the bidi iterator to avoid searches for display
201 properties and overlays.
202
203 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
204
205 * editfns.c (Fset_time_zone_rule): Document relationship with the
206 setenv function.
207
208 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
209 the font entity extracted from the cache (Bug#8109).
210
211 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
212
213 * composite.c (autocmp_chars): Don't reset point. That is done by
214 restore_point_unwind (Bug#5984).
215
216 2011-08-07 Juri Linkov <juri@jurta.org>
217
218 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
219 to show the arg `TIME' instead of `TIMEVAL'.
220
221 2011-08-06 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
224 display property strides EOL and includes a newline, as in
225 longlines-mode. (Bug#9254)
226 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
227 word-wrap under bidirectional display. (Bug#9224)
228
229 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
230 is non-zero, even if the data buffer is NULL. Fixes a crash in
231 vertical-motion with longlines-mode. (Bug#9254)
232
233 2011-08-05 Eli Zaretskii <eliz@gnu.org>
234
235 * bidi.c <bidi_cache_total_alloc>: Now static.
236 (bidi_initialize): Initialize bidi_cache_total_alloc.
237
238 *xdisp.c (display_line): Release buffer allocated for shelved bidi
239 cache. (Bug#9221)
240
241 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
242 amount allocated this far in `bidi_cache_total_alloc'.
243 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
244 non-zero, only free the data buffer without restoring the cache
245 contents. All callers changed.
246
247 * dispextern.h (bidi_unshelve_cache): Update prototype.
248
249 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
250 (move_it_in_display_line, move_it_to)
251 (move_it_vertically_backward, move_it_by_lines): Replace the call
252 to xfree to an equivalent call to bidi_unshelve_cache.
253 (move_it_in_display_line_to): Fix logic of returning
254 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
255
256 2011-08-05 Eli Zaretskii <eliz@gnu.org>
257
258 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
259 came from a string character with a `cursor' property. (Bug#9229)
260
261 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
262
263 * Makefile.in (LIB_PTHREAD): New variable.
264 (LIBES): Add LIB_PTHREAD (Bug#9216).
265
266 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
267 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
268
269 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
270
271 * regex.c (re_iswctype): Remove some redundant boolean
272 conversions.
273
274 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
275
276 * xterm.c (x_find_topmost_parent): New function.
277 (x_set_frame_alpha): Find topmost parent window with
278 x_find_topmost_parent and set the property there also (bug#9181).
279 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
280
281 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
282
283 * callproc.c (Fcall_process): Avoid vfork clobbering
284 the local vars buffer, coding_systems, current_dir.
285
286 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
287
288 * keymap.c (Fmake_composed_keymap): Move to subr.el.
289
290 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
291
292 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
293 so that it is not optimized away.
294
295 * xdisp.c (compute_display_string_pos): Remove unused local.
296
297 2011-08-02 Eli Zaretskii <eliz@gnu.org>
298
299 Fix slow cursor motion and scrolling in large buffers with
300 selective display, like Org Mode buffers. (Bug#9218)
301
302 * dispextern.h (struct bidi_it): New member disp_prop_p.
303
304 * xdisp.c: Remove one-slot cache of display string positions.
305 (compute_display_string_pos): Accept an additional argument
306 DISP_PROP_P; callers changed. Scan at most 5K characters forward
307 for a display string or property. If found, set DISP_PROP_P
308 non-zero.
309
310 * bidi.c (bidi_fetch_char): Accept an additional argument
311 DISP_PROP_P, and pass it to compute_display_string_pos.
312 Only handle text covered by a display string if DISP_PROP_P is returned
313 non-zero. All callers of bidi_fetch_char changed.
314
315 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
316
317 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
318
319 2010-12-03 Don March <don@ohspite.net>
320
321 * keymap.c (Fdefine_key): Fix non-prefix key error message when
322 last character M-[char] is translated to ESC [char] (bug#7541).
323
324 2011-08-02 Kenichi Handa <handa@m17n.org>
325
326 * lisp.h (uniprop_table): Extern it.
327
328 * chartab.c (uniprop_table): Make it non-static.
329
330 2011-08-01 Eli Zaretskii <eliz@gnu.org>
331
332 * xdisp.c (forward_to_next_line_start): Accept additional argument
333 BIDI_IT_PREV, and store into it the state of the bidi iterator had
334 on the newline.
335 (reseat_at_next_visible_line_start): Use the bidi iterator state
336 returned by forward_to_next_line_start to restore the state of
337 it->bidi_it after backing up to previous newline. (Bug#9212)
338
339 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
340
341 * regex.c (re_comp): Protoize.
342 (re_exec): Fix return type.
343 (regexec): Fix type of `ret'. (Bug#9203)
344
345 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
346
347 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
348 This is needed if max-image-size is a floating-point number.
349
350 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
351
352 * print.c (print_object): Print empty symbol as ##.
353
354 * lread.c (read1): Read ## as empty symbol.
355
356 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
357
358 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
359 setting frame foreground color (Bug#9175).
360 (x_set_background_color): Likewise.
361
362 * nsmenu.m (-setText): Size tooltip dimensions precisely to
363 contents (Bug#9176).
364 (EmacsTooltip -init): Remove bezels and add shadows to
365 tooltip windows.
366
367 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
368 or scroll bar (Bug#8470).
369
370 * nsfont.m (nsfont_open): Remove assignment to voffset and
371 unnecessary vars hshink, expand, hd, full_height, min_height.
372 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
373
374 * nsterm.h (nsfont_info): Remove voffset field.
375
376 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
377
378 Implement strike-through and overline on NextStep (Bug#8863).
379
380 * nsfont.m (nsfont_open): Use underline position provided by font,
381 instead of hard-coded value of 2.
382 (nsfont_draw): Call ns_draw_text_decoration instead.
383
384 * nsterm.h: Add declaration for ns_draw_text_decoration.
385
386 * nsterm.m (ns_draw_text_decoration): New function for drawing
387 underline, overline, and strike-through.
388 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
389 ns_draw_text_decoration. Change treatment of cursor drawing to
390 accomodate underlining, etc.
391
392 2011-07-28 Eli Zaretskii <eliz@gnu.org>
393
394 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
395 default.
396
397 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
398
399 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
400 Without this fix, if a signal arrives just after memory fills up,
401 'malloc' might be invoked reentrantly.
402
403 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
404 In other words, assume that every image size is allowed, on non-X
405 hosts. This assumption is probably wrong, but it lets Emacs compile.
406
407 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
408
409 * regex.c (re_iswctype): Convert return values to boolean.
410
411 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
412
413 * xdisp.c (compute_display_string_pos): Don't use cached display
414 string position if the buffer had its restriction changed.
415 (Bug#9184)
416
417 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
418
419 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
420
421 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
422
423 Integer signedness and overflow and related fixes. (Bug#9079)
424
425 * bidi.c: Integer size and overflow fixes.
426 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
427 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
428 (bidi_cache_find_level_change, bidi_cache_ensure_space)
429 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
430 (bidi_find_other_level_edge):
431 Use ptrdiff_t instead of EMACS_INT where either will do.
432 This works better on 32-bit hosts configured --with-wide-int.
433 (bidi_cache_ensure_space): Check for size-calculation overflow.
434 Use % rather than repeated addition, for better worst-case speed.
435 Don't set bidi_cache_size until after xrealloc returns, because it
436 might not return.
437 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
438 (bidi_cache_ensure_space): Also check that the bidi cache size
439 does not exceed that of the largest Lisp string or buffer. See Eli
440 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
441
442 * alloc.c (__malloc_size_t): Remove.
443 All uses replaced by size_t. See Andreas Schwab's note
444 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
445
446 * image.c: Improve checking for integer overflow.
447 (check_image_size): Assume that f is nonnull, since
448 it is always nonnull in practice. This is one less thing to
449 worry about when checking for integer overflow later.
450 (x_check_image_size): New function, which checks for integer
451 overflow issues inside X.
452 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
453 This removes the need for a memory_full check.
454 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
455 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
456 (xbm_read_bitmap_data): Change locals back to 'int', since
457 their values must fit in 'int'.
458 (xpm_load_image, png_load, tiff_load):
459 Invoke x_create_x_image_and_pixmap earlier,
460 to avoid much needless work if the image is too large.
461 (tiff_load): Treat overly large images as if
462 x_create_x_image_and_pixmap failed, not as malloc failures.
463 (gs_load): Use x_check_image_size.
464
465 * gtkutil.c: Omit integer casts.
466 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
467 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
468
469 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
470
471 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
472 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
473 would wrongly return t on a 64-bit host.
474
475 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
476 The plain *_OVERFLOW macros run afoul of GCC bug 49705
477 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
478 and therefore cause GCC to emit a bogus diagnostic in some cases.
479
480 * image.c: Integer signedness and overflow and related fixes.
481 This is not an exhaustive set of fixes, but it's time to
482 record what I've got.
483 (lookup_pixel_color, check_image_size): Remove redundant decls.
484 (check_image_size): Don't assume that arbitrary EMACS_INT values
485 fit in 'int', or that arbitrary 'double' values fit in 'int'.
486 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
487 (tiff_load, imagemagick_load_image):
488 Check for overflow in size calculations.
489 (x_create_x_image_and_pixmap): Remove unnecessary test for
490 xmalloc returning NULL; that can't happen.
491 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
492 (xpm_color_bucket): Use better integer hashing function.
493 (xpm_cache_color): Don't possibly over-allocate memory.
494 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
495 (gif_memory_source):
496 Use ptrdiff_t, not int or size_t, to record sizes.
497 (png_load): Don't assume values greater than 2**31 fit in 'int'.
498 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
499 either works, as we prefer signed integers.
500 (tiff_read_from_memory, tiff_write_from_memory):
501 Return tsize_t, not size_t, since that's what the TIFF API wants.
502 (tiff_read_from_memory): Don't fail simply because the read would
503 go past EOF; instead, return a short read.
504 (tiff_load): Omit no-longer-needed casts.
505 (Fimagemagick_types): Don't assume size fits into 'int'.
506
507 Improve hashing quality when configured --with-wide-int.
508 * fns.c (hash_string): New function, taken from sxhash_string.
509 Do not discard information about ASCII character case; this
510 discarding is no longer needed.
511 (sxhash-string): Use it. Change sig to match it. Caller changed.
512 * lisp.h: Declare it.
513 * lread.c (hash_string): Remove, since we now use fns.c's version.
514 The fns.c version returns a wider integer if --with-wide-int is
515 specified, so this should help the quality of the hashing a bit.
516
517 * emacs.c: Integer overflow minor fix.
518 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
519 Define only if GNU_LINUX.
520 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
521
522 * dispnew.c: Integer signedness and overflow fixes.
523 Remove unnecessary forward decls, that were a maintenance hassle.
524 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
525 All uses changed.
526 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
527 (scrolling_window): Use ptrdiff_t, not int, for byte count.
528 (prepare_desired_row, line_draw_cost):
529 Use int, not unsigned, where either works.
530 (save_current_matrix, restore_current_matrix):
531 Use ptrdiff_t, not size_t, where either works.
532 (init_display): Check for overflow more accurately, and without
533 relying on undefined behavior.
534
535 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
536 Remove, replacing with the new symbols in lisp.h. All uses changed.
537 * fileio.c (make_temp_name):
538 * filelock.c (lock_file_1, lock_file):
539 * xdisp.c (message_dolog):
540 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
541 Use pMd etc. instead.
542 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
543 replacing the pWIDE etc. symbols removed from editfns.c.
544
545 * keyboard.h (num_input_events): Now uintmax_t.
546 This is (very slightly) less likely to mess up due to wraparound.
547 All uses changed.
548
549 * buffer.c: Integer signedness fixes.
550 (alloc_buffer_text, enlarge_buffer_text):
551 Use ptrdiff_t rather than size_t when either will do, as we prefer
552 signed integers.
553
554 * alloc.c: Integer signedness and overflow fixes.
555 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
556 (__malloc_size_t): Default to size_t, not to int.
557 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
558 (Fgarbage_collect, mark_object_loop_halt, mark_object):
559 Prefer ptrdiff_t to size_t when either would do, as we prefer
560 signed integers.
561 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
562 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
563 Now const. Initialize with values that are in range even if char
564 is signed.
565 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
566 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
567 These functions do the right thing with sizes > 2**32.
568 (check_depth): Now ptrdiff_t, not int.
569 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
570 Adjust to new way of storing sizes. Check for size overflow bugs
571 in rest of code.
572 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
573 slightly wrong anyway, as it missed one instance of
574 XMALLOC_OVERRUN_CHECK_OVERHEAD.
575 (refill_memory_reserve): Omit needless cast to size_t.
576 (mark_object_loop_halt): Mark as externally visible.
577
578 * xselect.c: Integer signedness and overflow fixes.
579 (Fx_register_dnd_atom, x_handle_dnd_message):
580 Use ptrdiff_t, not size_t, since we prefer signed.
581 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
582 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
583 x_dnd_atoms_size and x_dnd_atoms_length.
584
585 * doprnt.c: Prefer signed to unsigned when either works.
586 * eval.c (verror):
587 * doprnt.c (doprnt):
588 * lisp.h (doprnt):
589 * xdisp.c (vmessage):
590 Use ptrdiff_t, not size_t, when using or implementing doprnt,
591 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
592 prefer signed arithmetic to avoid comparison confusion.
593 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
594 but is a bit tricky.
595
596 Assume freestanding C89 headers, string.h, stdlib.h.
597 * data.c, doprnt.c, floatfns.c, print.c:
598 Include float.h unconditionally.
599 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
600 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
601 * regex.c: Likewise for stddef.h, string.h.
602 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
603 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
604 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
605 (STDC_HEADERS): Remove obsolete defines.
606 * sysdep.c: Include limits.h unconditionally.
607
608 Assume support for memcmp, memcpy, memmove, memset.
609 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
610 * regex.c (memcmp, memcpy):
611 Remove; we assume C89 now.
612
613 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
614 (__malloc_safe_bcopy): Remove; no longer needed.
615
616 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
617 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
618 well either way, and we prefer signed to unsigned.
619
620 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
621
622 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
623 closes the connection while we're reading (bug#9182).
624
625 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
626
627 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
628 are specified (Bug#9168).
629
630 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
631
632 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
633 Found by GCC static checking and --with-wide-int on a 32-bit host.
634
635 2011-07-25 Eli Zaretskii <eliz@gnu.org>
636
637 * xdisp.c (compute_display_string_pos): Fix logic of caching
638 previous display string position. Initialize cached_prev_pos to
639 -1. Fixes slow-down at the beginning of a buffer.
640
641 2011-07-24 Eli Zaretskii <eliz@gnu.org>
642
643 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
644 for attrs[LFACE_FONTSET_INDEX].
645
646 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
647
648 * xml.c (parse_region): Remove unused local
649 that was recently introduced.
650
651 2011-07-23 Eli Zaretskii <eliz@gnu.org>
652
653 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
654 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
655
656 * xdisp.c (move_it_in_display_line_to): Record the best matching
657 position for TO_CHARPOS while scanning the line, and restore it on
658 exit if none of the characters scanned was an exact match.
659 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
660 when exact match is impossible due to invisible text, and the
661 lines are truncated.
662
663 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
664
665 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
666 for OSX >= 10.7.
667
668 2011-07-22 Eli Zaretskii <eliz@gnu.org>
669
670 Fix a significant slow-down of cursor motion with C-n, C-p,
671 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
672 auto-repeat under bidi redisplay in fontified buffers.
673 * xdisp.c (compute_stop_pos_backwards): New function.
674 (next_element_from_buffer): Call compute_stop_pos_backwards to
675 find a suitable prev_stop when we find ourselves before
676 base_level_stop.
677 (reseat): Don't look for prev_stop, as that could mean a very long
678 run.
679 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
680 <cached_disp_overlay_modiff>: Cache for last found display string
681 position.
682 (compute_display_string_pos): Return the cached position if asked
683 about the same buffer in the same area of character positions, and
684 the buffer wasn't changed since the time the display string
685 position was cached.
686
687 2011-07-22 Eli Zaretskii <eliz@gnu.org>
688
689 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
690 is an integer, which is important for empty lines. (Bug#9149)
691
692 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
693
694 * frame.c (Fmodify_frame_parameters): In tty case, update the
695 default face if necessary (Bug#4238).
696
697 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
698
699 * editfns.c (Fstring_to_char): No need to explain what a character
700 is in the docstring (Bug#6576).
701
702 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
703
704 * xml.c (parse_region): Make sure we always return a tree.
705
706 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
707
708 * xml.c (parse_region): If a document contains only comments,
709 return that, too.
710
711 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
712
713 * xml.c (make_dom): Return comments, too.
714
715 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
716
717 Port to OpenBSD.
718 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
719 and the surrounding thread.
720 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
721 rather than fgets, and retry after EINTR. Otherwise, 'emacs
722 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
723 timer goes off.
724 * s/openbsd.h (BROKEN_SIGIO): Define.
725 * unexelf.c (unexec) [__OpenBSD__]:
726 Don't update the .mdebug section of the Alpha COFF symbol table.
727
728 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
729
730 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
731 (bug#8460).
732
733 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
734
735 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
736 This fixes some race conditions on the permissions of any newly
737 created file.
738
739 * alloc.c (valid_pointer_p): Use pipe, not open.
740 This fixes some permissions issues when debugging.
741
742 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
743 If fchown fails to set both uid and gid, try to set just gid,
744 as that is sometimes allowed. Adjust the file's mode to eliminate
745 setuid or setgid bits that are inappropriate if fchown fails.
746
747 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
748
749 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
750 to compare Lisp_Objects.
751 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
752 global_gnutls_log_level, don't mistake it for a Lisp_Object.
753 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
754
755 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
756
757 * lread.c (read_integer): Unread even EOF character.
758 (read1): Likewise. Properly record start position of symbol.
759
760 * lread.c (read1): Read `#:' as empty uninterned symbol if no
761 symbol character follows.
762
763 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
764
765 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
766 This works around a problem with the previous change to Fcopy_file.
767 Recent glibc declares fchown with __attribute__((warn_unused_result)),
768 and without this change, GCC might complain about discarding
769 fchown's return value.
770
771 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
772
773 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
774
775 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
776
777 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
778
779 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
780
781 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
782 it's used from the C level.
783
784 * process.c: Use the same condition for POLL_FOR_INPUT in both
785 keyboard.c and process.c (bug#1858).
786
787 2011-07-09 Lawrence Mitchell <wence@gmx.li>
788
789 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
790 (Fgnutls_boot): Use it.
791
792 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
793
794 * doc.c (Fsubstitute_command_keys): Revert last change.
795
796 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
797
798 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
799 quotes the next character, and doesn't affect other longer
800 sequences (bug#8935).
801
802 * lread.c (syms_of_lread): Clarify that is isn't only
803 `eval-buffer' and `eval-defun' that's affected by
804 `lexical-binding' (bug#8460).
805
806 2011-07-15 Eli Zaretskii <eliz@gnu.org>
807
808 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
809 bidi redisplay when a line includes both an image and is
810 truncated.
811
812 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
813
814 Fix minor problems found by static checking.
815 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
816 (elsz): Now a signed constant, not a size_t var. We prefer signed
817 types to unsigned, to avoid integer comparison confusion. Without
818 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
819 "cannot optimize loop, the loop counter may overflow", a symptom
820 of the confusion.
821 * indent.c (Fvertical_motion): Mark locals as initialized.
822 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
823
824 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
825
826 * search.c (Fre_search_backward): Mention `case-fold-search' in
827 all the re_search_* functions (bug#8138).
828
829 * keyboard.c (Fopen_dribble_file): Document when the file is
830 closed (bug#8056).
831
832 2011-07-14 Eli Zaretskii <eliz@gnu.org>
833
834 * bidi.c (bidi_dump_cached_states): Fix format of displaying
835 bidi_cache_idx.
836
837 Support bidi reordering of display and overlay strings.
838 * xdisp.c (compute_display_string_pos)
839 (compute_display_string_end): Accept additional argument STRING.
840 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
841 (reseat_to_string): Initialize bidi_it->string.s and
842 bidi_it->string.schars.
843 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
844 NULL (avoids a crash in bidi_paragraph_init).
845 Initialize itb.string.lstring.
846 (init_iterator): Call bidi_init_it only of a valid
847 buffer position was specified. Initialize paragraph_embedding to
848 L2R.
849 (reseat_to_string): Initialize the bidi iterator.
850 (display_string): If we need to ignore text properties of
851 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
852 original value of -1 will not work with bidi.)
853 (compute_display_string_pos): First arg is now struct
854 `text_pos *'; all callers changed. Support display properties on
855 Lisp strings.
856 (compute_display_string_end): Support display properties on Lisp
857 strings.
858 (init_iterator, reseat_1, reseat_to_string): Initialize the
859 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
860 when iterating on a string not from display properties).
861 (compute_display_string_pos, compute_display_string_end):
862 Fix calculation of the object to scan. Fixes an error when using
863 arrow keys.
864 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
865 base_level_stop; instead, set base_level_stop to BEGV.
866 Fixes crashes in vertical-motion.
867 (next_element_from_buffer): Improve commentary for when
868 the iterator is before prev_stop.
869 (init_iterator): Initialize bidi_p from the default value of
870 bidi-display-reordering, not from buffer-local value. Use the
871 buffer-local value only if initializing for buffer iteration.
872 (handle_invisible_prop): Support invisible properties on strings
873 that are being bidi-reordered.
874 (set_iterator_to_next): Support bidi reordering of C strings and
875 Lisp strings.
876 (next_element_from_string): Support bidi reordering of Lisp
877 strings.
878 (handle_stop_backwards): Support Lisp strings as well.
879 (display_string): Support display of R2L glyph rows.
880 Use IT_STRING_CHARPOS when displaying from a Lisp string.
881 (init_iterator): Don't initialize it->bidi_p for strings
882 here.
883 (reseat_to_string): Initialize it->bidi_p for strings here.
884 (next_element_from_string, next_element_from_c_string)
885 (next_element_from_buffer): Add xassert's for correspondence
886 between IT's object being iterated and it->bidi_it.string
887 structure.
888 (face_before_or_after_it_pos): Support bidi iteration.
889 (next_element_from_c_string): Handle the case of the first string
890 character that is not the first one in the visual order.
891 (get_visually_first_element): New function, refactored from common
892 parts of next_element_from_buffer, next_element_from_string, and
893 next_element_from_c_string.
894 (tool_bar_lines_needed, redisplay_tool_bar)
895 (display_menu_bar): Force left-to-right direction. Add a FIXME
896 comment for making that be controlled by a user option.
897 (push_it, pop_it): Save and restore the state of the
898 bidi iterator. Save and restore the bidi_p flag.
899 (pop_it): Iterate out of display property for string iteration as
900 well.
901 (iterate_out_of_display_property): Support iteration over strings.
902 (handle_single_display_spec): Set up it->bidi_it for iteration
903 over a display string, and call bidi_init_it.
904 (handle_single_display_spec, next_overlay_string)
905 (get_overlay_strings_1, push_display_prop): Set up the bidi
906 iterator for displaying display or overlay strings.
907 (forward_to_next_line_start): Don't use the shortcut if
908 bidi-iterating.
909 (back_to_previous_visible_line_start): If handle_display_prop
910 pushed the iterator stack, restore the internal state of the bidi
911 iterator by calling bidi_pop_it same number of times.
912 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
913 and we are bidi-iterating, don't decrement the iterator position;
914 instead, set the first_elt flag in the bidi iterator, to produce
915 the same effect.
916 (reseat_1): Remove redundant setting of string_from_display_prop_p.
917 (push_display_prop): xassert that we are iterating a buffer.
918 (push_it, pop_it): Save and restore paragraph_embedding member.
919 (handle_single_display_spec, next_overlay_string)
920 (get_overlay_strings_1, reseat_1, reseat_to_string)
921 (push_display_prop): Set up the `unibyte' member of bidi_it.string
922 correctly. Don't assume unibyte strings are not bidi-reordered.
923 (compute_display_string_pos)
924 (compute_display_string_end): Fix handling the case of C string.
925 (push_it, pop_it): Save and restore from_disp_prop_p.
926 (handle_single_display_spec, push_display_prop): Set the
927 from_disp_prop_p flag.
928 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
929 (pop_it): Call iterate_out_of_display_property only if we are
930 popping after iteration over a string that came from a display
931 property. Fix a typo in popping stretch info. Add an assertion
932 for verifying that the iterator position is in sync with the bidi
933 iterator.
934 (handle_single_display_spec, get_overlay_strings_1)
935 (push_display_prop): Fix initialization of paragraph direction for
936 string when that of the parent object is not yet determined.
937 (reseat_1): Call bidi_init_it to resync the bidi
938 iterator with IT's position. (Bug#7616)
939 (find_row_edges): If ROW->start.pos gives position
940 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
941 (handle_stop, back_to_previous_visible_line_start, reseat_1):
942 Reset the from_disp_prop_p flag.
943 (SAVE_IT, RESTORE_IT): New macros.
944 (pos_visible_p, face_before_or_after_it_pos)
945 (back_to_previous_visible_line_start)
946 (move_it_in_display_line_to, move_it_in_display_line)
947 (move_it_to, move_it_vertically_backward, move_it_by_lines)
948 (try_scrolling, redisplay_window, display_line): Use them when
949 saving a temporary copy of the iterator and restoring it back.
950 (back_to_previous_visible_line_start, reseat_1)
951 (init_iterator): Empty the bidi cache "stack".
952 (move_it_in_display_line_to): If iterator ended up at
953 EOL, but we never saw any buffer positions smaller than
954 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
955 motion in bidi-reordered lines.
956 (move_it_in_display_line_to): Record prev_method and prev_pos
957 immediately before the call to set_iterator_to_next. Fixes cursor
958 motion in bidi-reordered lines with stretch glyphs and strings
959 displayed in margins. (Bug#8133) (Bug#8867)
960 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
961 TO_CHARPOS.
962 (pos_visible_p): Support positions in bidi-reordered lines.
963 Save and restore bidi cache.
964
965 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
966 (bidi_paragraph_info): Delete unused struct.
967 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
968 (bidi_cache_start): New variable.
969 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
970 to zero.
971 (bidi_cache_fetch_state, bidi_cache_search)
972 (bidi_cache_find_level_change, bidi_cache_iterator_state)
973 (bidi_cache_find, bidi_peek_at_next_level)
974 (bidi_level_of_next_char, bidi_find_other_level_edge)
975 (bidi_move_to_visually_next): Compare cache index with
976 bidi_cache_start rather than with zero.
977 (bidi_fetch_char): Accept new argument STRING; all callers
978 changed. Support iteration over a string. Support strings with
979 display properties. Support unibyte strings. Fix the type of
980 `len' according to what STRING_CHAR_AND_LENGTH expects.
981 (bidi_paragraph_init, bidi_resolve_explicit_1)
982 (bidi_resolve_explicit, bidi_resolve_weak)
983 (bidi_level_of_next_char, bidi_move_to_visually_next):
984 Support iteration over a string.
985 (bidi_set_sor_type, bidi_resolve_explicit_1)
986 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
987 can now be zero (for strings); special values 0 and -1 were
988 changed to -1 and -2, respectively.
989 (bidi_char_at_pos): New function.
990 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
991 Call it instead of FETCH_MULTIBYTE_CHAR.
992 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
993 initialized to valid values.
994 (bidi_init_it): Don't initialize charpos and bytepos with invalid
995 values.
996 (bidi_level_of_next_char): Allow the sentinel "position" to pass
997 the test for valid cached positions. Fix the logic for looking up
998 the sentinel state in the cache. GCPRO the Lisp string we are
999 iterating.
1000 (bidi_push_it, bidi_pop_it): New functions.
1001 (bidi_initialize): Initialize the bidi cache start stack pointer.
1002 (bidi_cache_ensure_space): New function, refactored from part of
1003 bidi_cache_iterator_state. Don't assume the required size is just
1004 one BIDI_CACHE_CHUNK away.
1005 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1006 (bidi_count_bytes, bidi_char_at_pos): New functions.
1007 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1008 always valid if bidi_cache_idx is valid.
1009 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1010 is valid if it's going to be used.
1011 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1012 (bidi_cache_fetch_state, bidi_cache_search)
1013 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1014 (bidi_cache_iterator_state, bidi_cache_find)
1015 (bidi_find_other_level_edge, bidi_cache_start_stack):
1016 All variables related to cache indices are now EMACS_INT.
1017
1018 * dispextern.h (struct bidi_string_data): New structure.
1019 (struct bidi_it): New member `string'. Make flag members be 1-bit
1020 fields, and put them last in the struct.
1021 (compute_display_string_pos, compute_display_string_end):
1022 Update prototypes.
1023 (bidi_push_it, bidi_pop_it): Add prototypes.
1024 (struct iterator_stack_entry): New members bidi_p,
1025 paragraph_embedding, and from_disp_prop_p.
1026 (struct it): Member bidi_p is now a bit field 1 bit wide.
1027 (bidi_shelve_cache, bidi_unshelve_cache):
1028 Declare prototypes.
1029
1030 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1031 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1032 and vector-like objects.
1033
1034 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1035 cache around display iteration.
1036
1037 * window.c (Fwindow_end, window_scroll_pixel_based)
1038 (displayed_window_lines, Frecenter): Save and restore the bidi
1039 cache around display iteration.
1040
1041 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1042
1043 * editfns.c (Fdelete_region): Clarify the use of the named
1044 parameters (bug#6788).
1045
1046 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1047
1048 * indent.c (Fvertical_motion): Set and restore w->pointm when
1049 saving and restoring the window's buffer (Bug#9006).
1050
1051 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1052
1053 * editfns.c (Fstring_to_char): Clarify just what is returned
1054 (bug#6576). Text by Eli Zaretskii.
1055
1056 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1057
1058 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1059
1060 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1061
1062 * buffer.c (mmap_find): Fix a typo.
1063
1064 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1065
1066 Fix execution of x selection hooks.
1067 * xselect.c (Qx_lost_selection_functions)
1068 (Qx_sent_selection_functions): New vars.
1069 (syms_of_xselect): DEFSYM them.
1070 (x_handle_selection_request): Pass Qx_sent_selection_functions
1071 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1072 (x_handle_selection_clear,x_clear_frame_selections):
1073 Pass Qx_lost_selection_functions rather than
1074 Vx_lost_selection_functions to Frun_hook_with_args.
1075
1076 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1079 The old code sometimes used this field without initializing it.
1080
1081 * alloc.c (gc_sweep): Don't read past end of array.
1082 In theory, the old code could also have corrupted Emacs internals,
1083 though it'd be very unlikely.
1084
1085 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1086
1087 * character.c (Fcharacterp): Don't advertise optional ignored
1088 argument. (Bug#4026)
1089
1090 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1091
1092 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1093 key" (bug#4257).
1094
1095 * window.c (Fset_window_start): Doc fix (bug#4199).
1096 (Fset_window_hscroll): Ditto.
1097
1098 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 Fix minor new problems caught by GCC 4.6.1.
1101 * term.c (init_tty): Remove unused local.
1102 * xsettings.c (store_monospaced_changed): Define this function only
1103 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1104 not used otherwise.
1105
1106 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1107
1108 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1109
1110 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1111
1112 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1113 are the mini-buffer and the echo area (bug#3320).
1114
1115 * term.c (init_tty): Remove support for supdup, c10 and perq
1116 terminals, which are no longer supported (bug#1482).
1117
1118 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1119
1120 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1121
1122 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1123
1124 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1125 for non-popups (Bug#3642).
1126
1127 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1128
1129 * alloc.c (reset_malloc_hooks): Protoize.
1130 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1131 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1132 * cm.c (losecursor): Likewise.
1133 * data.c (fmod): Likewise.
1134 * dispnew.c (swap_glyphs_in_rows): Likewise.
1135 * emacs.c (memory_warning_signal): Likewise.
1136 * floatfns.c (float_error): Likewise.
1137 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1138 (otf_open, font_otf_capability, generate_otf_features)
1139 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1140 Likewise.
1141 * image.c (pbm_read_file): Likewise.
1142 * indent.c (string_display_width): Likewise.
1143 * intervals.c (check_for_interval, search_for_interval)
1144 (inc_interval_count, count_intervals, root_interval)
1145 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1146 * lread.c (defalias): Likewise.
1147 * ralloc.c (r_alloc_check): Likewise.
1148 * regex.c (set_image_of_range_1, set_image_of_range)
1149 (regex_grow_registers): Likewise.
1150 * sysdep.c (strerror): Likewise.
1151 * termcap.c (valid_filename_p, tprint, main): Likewise.
1152 * tparam.c (main): Likewise.
1153 * unexhp9k800.c (run_time_remap, save_data_space)
1154 (update_file_ptrs, read_header, write_header, calculate_checksum)
1155 (copy_file, copy_rest, display_header): Likewise.
1156 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1157 Likewise.
1158 * xdisp.c (check_it): Likewise.
1159 * xfaces.c (register_color, unregister_color, unregister_colors):
1160 Likewise.
1161 * xfns.c (print_fontset_result): Likewise.
1162 * xrdb.c (member, fatal, main): Likewise.
1163
1164 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1165
1166 Fix minor problems found by static checking (Bug#9031).
1167 * chartab.c (char_table_set_range, map_sub_char_table):
1168 Remove unused locals.
1169 (uniprop_table): Now static.
1170 * composite.c (_work_char): Remove unused static var.
1171
1172 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1173
1174 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1175
1176 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1177
1178 * gtkutil.c (qttip_cb): Remove code without function.
1179
1180 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1181
1182 * w32.c (pthread_sigmask): New stub.
1183
1184 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 Use pthread_sigmask, not sigprocmask (Bug#9010).
1187 sigprocmask is portable only for single-threaded applications, and
1188 Emacs can be multi-threaded when it uses GTK.
1189 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1190 (LIBES): Use it.
1191 * callproc.c (Fcall_process):
1192 * process.c (create_process):
1193 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1194 Use pthread_sigmask, not sigprocmask.
1195
1196 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1197
1198 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1199 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1200 wrong (Bug#8591).
1201
1202 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1203
1204 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1205 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1206 (xg_hide_tooltip): Fix comment.
1207
1208 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1209 in registerServicesMenuSendTypes.
1210 (validRequestorForSendType): Don't check ns_return_types.
1211
1212 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1213 ns_return_type.
1214
1215 2011-07-08 Jason Rumney <jasonr@gnu.org>
1216
1217 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1218 frame struct members of non-existent frames (Bug#6284).
1219
1220 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1221
1222 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1223 variable firstTime not needed on OSX >= 10.6.
1224 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1225 >= 10.5. Use setKnobProportion, setDoubleValue.
1226
1227 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1228 (MAC_OS_X_VERSION_10_5): Define if not defined.
1229 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1230 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1231 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1232
1233 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1234 cString and lossyCString on OSX >= 10.4
1235
1236 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1237 sizeToFit on OSX >= 10.2.
1238
1239 * nsimage.m (allocInitFromFile): Don't use deprecated method
1240 bestRepresentationForDevice on OSX >= 10.6.
1241
1242 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1243 to avoid warning.
1244
1245 * emacs.c: Declare unexec_init_emacs_zone.
1246
1247 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1248
1249 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1250
1251 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1252 on svcsMenu (Bug#8842).
1253
1254 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1255 ns_return_types.
1256 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1257
1258 * nsterm.m (QUTF8_STRING): Declare.
1259 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1260 (validRequestorForSendType): Return type is (id).
1261 Change indexOfObjectIdenticalTo to indexOfObject.
1262 Check if we have local selection before returning self (Bug#8842).
1263 (writeSelectionToPasteboard): Put local selection into paste board
1264 if we have a local selection (Bug#8842).
1265 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1266
1267 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1268 (ns_get_local_selection): Declare.
1269
1270 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1271
1272 * keymap.c (describe_map_tree): Don't insert a double newline at
1273 the end of the buffer (bug#1169) and return whether we inserted
1274 something.
1275
1276 * callint.c (Fcall_interactively): Change "reading args" to
1277 "providing args" to try to clarify what it does (bug#1010).
1278
1279 2011-07-07 Kenichi Handa <handa@m17n.org>
1280
1281 * composite.c (composition_compute_stop_pos): Ignore a static
1282 composition starting before CHARPOS (Bug#8915).
1283
1284 * xdisp.c (handle_composition_prop): Likewise.
1285
1286 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1287
1288 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1289 (Bug#9015)
1290
1291 2011-07-07 Kenichi Handa <handa@m17n.org>
1292
1293 * character.h (unicode_category_t): New enum type.
1294
1295 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1296 (Qchar_code_property_table): New variable.
1297 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1298 (UNIPROP_COMPRESSED_FORM_P): New macros.
1299 (char_table_ascii): Uncompress the compressed values.
1300 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1301 Uncompress the compressed values.
1302 (sub_char_table_ref_and_range): Likewise.
1303 (char_table_ref_and_range): Uncompress the compressed values.
1304 (sub_char_table_set): New arg is_uniprop. Callers changed.
1305 Uncompress the compressed values.
1306 (sub_char_table_set_range): Args changed. Callers changed.
1307 (char_table_set_range): Adjuted for the above change.
1308 (map_sub_char_table): Delete args default_val and parent. Add arg
1309 top. Give decoded values to a Lisp function.
1310 (map_char_table): Adjust for the above change. Give decoded
1311 values to a Lisp function. Gcpro more variables.
1312 (uniprop_table_uncompress)
1313 (uniprop_decode_value_run_length): New functions.
1314 (uniprop_decoder, uniprop_decoder_count): New variables.
1315 (uniprop_get_decoder, uniprop_encode_value_character)
1316 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1317 New functions.
1318 (uniprop_encoder, uniprop_encoder_count): New variables.
1319 (uniprop_get_encoder, uniprop_table)
1320 (Funicode_property_table_internal, Fget_unicode_property_internal)
1321 (Fput_unicode_property_internal): New functions.
1322 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1323 Sunicode_property_table_internal, Sget_unicode_property_internal,
1324 and Sput_unicode_property_internal. Defvar_lisp
1325 char-code-property-alist.
1326
1327 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1328 Vunicode_category_table.
1329
1330 * font.c (font_range): Adjust for the change of
1331 Vunicode_category_table.
1332
1333 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1334
1335 * m/iris4d.h: Remove file, move contents ...
1336 * s/irix6-5.h: ... here.
1337
1338 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Remove unportable assumption about struct layout (Bug#8884).
1341 * alloc.c (mark_buffer):
1342 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1343 (clone_per_buffer_values): Don't assume that
1344 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1345 This isn't true in general, and it's particularly not true
1346 if Emacs is configured with --with-wide-int.
1347 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1348 New macros, used in the buffer.c change.
1349
1350 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1351
1352 * xsettings.c: Use both GConf and GSettings if both are available.
1353 (store_config_changed_event): Add comment.
1354 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1355 (store_tool_bar_style_changed): New functions.
1356 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1357 (struct xsettings): Move font inside HAVE_XFT.
1358 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1359 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1360 Move inside HAVE_XFT.
1361 (something_changed_gsettingsCB): Rename from something_changedCB.
1362 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1363 also.
1364 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1365 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1366 (something_changed_gconfCB): Rename from something_changedCB.
1367 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1368 (parse_settings): Move check for font inside HAVE_XFT.
1369 (read_settings, apply_xft_settings): Add comment.
1370 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1371 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1372 call store_font_name_changed.
1373 (xft_settings_event): Add comment.
1374 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1375 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1376 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1377 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1378 (xsettings_initialize): Call init_gsettings last.
1379 (xsettings_get_system_font, xsettings_get_system_normal_font):
1380 Add comment.
1381
1382 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 Random fixes. E.g., (random) never returned negative values.
1385 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1386 subseconds part to the entropy, as that's a bit more random.
1387 Prefer signed to unsigned, since the signedness doesn't matter and
1388 in general we prefer signed. When given a limit, use a
1389 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1390 latter isn't right if USE_2_TAGS_FOR_INTS.
1391 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1392 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1393
1394 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1395
1396 * textprop.c (text_property_stickiness):
1397 Obey Vtext_property_default_nonsticky.
1398 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1399 * w32fns.c (syms_of_w32fns):
1400 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1401
1402 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1403
1404 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1405 This is more efficient than Ffile_directory_p and avoids a minor race.
1406
1407 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1408
1409 * buffer.c (Foverlay_put): Say what the return value is
1410 (bug#7835).
1411
1412 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1413 is a directory before asking whether to use the file name
1414 (bug#7564).
1415 (barf_or_query_if_file_exists): Make the "File is a directory"
1416 error be more correct.
1417
1418 * fns.c (Frequire): Remove the mention of the .gz files, since
1419 that's installation-specific, but keep the mention of
1420 `get-load-suffixes'.
1421
1422 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1425 Report string overflow if the output is too long.
1426
1427 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1428
1429 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1430 (syms_of_gnutls): Remove duplicate DEFSYM for
1431 Qgnutls_bootprop_verify_hostname_error, an error for
1432 Qgnutls_bootprop_verify_error (which is no longer used).
1433
1434 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1435 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1436 Also (re)move comments that are misplaced or no longer relevant.
1437
1438 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1439
1440 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1441
1442 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1443
1444 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1445 and background color parameters if they have been changed.
1446
1447 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1448
1449 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1450
1451 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1452
1453 * xsettings.c (SYSTEM_FONT): Define only when used.
1454 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1455
1456 * keymap.c (access_keymap_1): Now static.
1457
1458 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1459
1460 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1461 leave any prefix arg for the up event (Bug#1586).
1462
1463 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1464
1465 * lread.c (syms_of_lread): Mention single symbols defined by
1466 `defvar' or `defconst' (bug#7154).
1467
1468 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1469 (Frequire): Mention get-load-suffixes.
1470
1471 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1472
1473 * window.h (window): Remove clone_number slot.
1474 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1475 Remove.
1476 (make_parent_window, make_window, saved_window)
1477 (Fset_window_configuration, save_window_save): Don't deal with
1478 clone numbers.
1479 * buffer.c (Qclone_number): Remove declaration.
1480 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1481
1482 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1483
1484 Add multiple inheritance to keymaps.
1485 * keymap.c (Fmake_composed_keymap): New function.
1486 (Fset_keymap_parent): Simplify.
1487 (fix_submap_inheritance): Remove.
1488 (access_keymap_1): New function extracted from access_keymap to handle
1489 embedded parents and handle lists of maps.
1490 (access_keymap): Use it.
1491 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1492 (Fcopy_keymap): Handle embedded parents.
1493 (Fcommand_remapping, define_as_prefix): Simplify.
1494 (Fkey_binding): Simplify.
1495 (syms_of_keymap): Move minibuffer-local-completion-map,
1496 minibuffer-local-filename-completion-map,
1497 minibuffer-local-must-match-map, and
1498 minibuffer-local-filename-must-match-map to Elisp.
1499 (syms_of_keymap): Defsubr make-composed-keymap.
1500 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1501 (parse_menu_item): Trivial simplification.
1502
1503 2011-07-01 Glenn Morris <rgm@gnu.org>
1504
1505 * Makefile.in (SETTINGS_LIBS): Fix typo.
1506
1507 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1508
1509 * coding.c (Fencode_coding_string): Record the last coding system
1510 used, as the function doc string says (bug#8738).
1511
1512 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1513
1514 * xsettings.c (store_monospaced_changed): Take new font as arg and
1515 check for change against current_mono_font.
1516 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1517 (emacs_settings_constructor, emacs_settings_get_property)
1518 (emacs_settings_set_property, emacs_settings_class_init)
1519 (emacs_settings_init, gsettings_obj): Remove.
1520 (something_changedCB): New function for HAVE_GSETTINGS.
1521 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1522 with value as argument.
1523 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1524 g_settings_new (Bug#8967). Do not create gsettings_obj.
1525 Remove calls to g_settings_bind. Connect something_changedCB to
1526 "changed".
1527
1528 * xgselect.c: Add defined (HAVE_GSETTINGS).
1529 (xgselect_initialize): Ditto.
1530
1531 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1532 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1533 xg_select.
1534
1535 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1536
1537 * eval.c (struct backtrace): Simplify and port the data structure.
1538 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1539 signed bit field, as this assumption is not portable and it makes
1540 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1541 "char debug_on_exit : 1" as this is not portable either; instead,
1542 use the portable "unsigned int debug_on_exit : 1". Remove unused
1543 member evalargs. Remove obsolete comments about cc bombing out.
1544
1545 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1546
1547 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1548 Let HAVE_GSETTINGS override HAVE_GCONF.
1549 (store_monospaced_changed): New function.
1550 (EMACS_SETTINGS): A new type derived from GObject to handle
1551 GSettings notifications.
1552 (emacs_settings_constructor, emacs_settings_get_property)
1553 (emacs_settings_set_property, emacs_settings_class_init):
1554 New functions.
1555 (gsettings_client, gsettings_obj): New variables.
1556 (GSETTINGS_SCHEMA): New define.
1557 (something_changedCB): Call store_monospaced_changed.
1558 (init_gsettings): New function.
1559 (xsettings_initialize): Call init_gsettings.
1560 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1561 to NULL.
1562
1563 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1564 GCONF_CFLAGS/LIBS.
1565
1566 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1567
1568 * window.c (resize_root_window, grow_mini_window)
1569 (shrink_mini_window): Rename Qresize_root_window to
1570 Qwindow_resize_root_window and Qresize_root_window_vertically to
1571 Qwindow_resize_root_window_vertically.
1572
1573 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1576
1577 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1578
1579 * makefile.w32-in: Redesign dependencies so they reflect more
1580 clearly which files are directly included by each source file,
1581 and not through other includes.
1582
1583 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1584
1585 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1586 (sort_overlays, overlay_strings): When an overlay's clone number
1587 matches the window's clone number process the overlay even if
1588 the overlay's window property doesn't match the current window.
1589
1590 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1591 (Fwindow_hchild): Rename to Fwindow_left_child.
1592 (Fwindow_next): Rename to Fwindow_next_sibling.
1593 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1594 (resize_window_check): Rename to window_resize_check.
1595 (resize_window_apply): Rename to window_resize_apply.
1596 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1597 (Fdelete_other_windows_internal, resize_frame_windows)
1598 (Fsplit_window_internal, Fdelete_window_internal)
1599 (grow_mini_window, shrink_mini_window)
1600 (Fresize_mini_window_internal): Fix callers accordingly.
1601
1602 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1603
1604 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1605 (emacs_fixed_set_min_size): Remove.
1606 (emacs_fixed_new): Take frame as argument.
1607
1608 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1609 (_EmacsFixedPrivate): Remove minwidth/height.
1610 Add struct frame *f.
1611 (emacs_fixed_init): Initialize priv->f.
1612 (get_parent_class, emacs_fixed_set_min_size): Remove.
1613 (emacs_fixed_new): Set priv->f to argument.
1614 (emacs_fixed_get_preferred_width)
1615 (emacs_fixed_get_preferred_height): Use min_width/height from
1616 frames size_hint to set minimum and natural (Bug#8919).
1617 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1618 and use min_width/height from frames size_hint to set
1619 min_width/height (Bug#8919).
1620
1621 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1622 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1623 Fix indentation.
1624
1625 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1626
1627 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1628 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1629 called at ZV.
1630
1631 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1632
1633 * process.c (wait_reading_process_output): Bypass select if
1634 waiting for a cell while ignoring keyboard input, and input is
1635 pending. Suggested by Jan Djärv (Bug#8869).
1636
1637 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1638
1639 Use gnulib's dup2 module instead of rolling our own.
1640 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1641
1642 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1643
1644 * dispnew.c (scrolling_window): Before scrolling, turn off a
1645 mouse-highlight in the window being scrolled.
1646
1647 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1648
1649 Move DEFSYM to lisp.h and use everywhere.
1650
1651 * character.h (DEFSYM): Move declaration...
1652 * lisp.h (DEFSYM): ...here.
1653
1654 * gnutls.c:
1655 * minibuf.c:
1656 * w32menu.c:
1657 * w32proc.c:
1658 * w32select.c: Don't include character.h.
1659
1660 * alloc.c (syms_of_alloc):
1661 * buffer.c (syms_of_buffer):
1662 * bytecode.c (syms_of_bytecode):
1663 * callint.c (syms_of_callint):
1664 * casefiddle.c (syms_of_casefiddle):
1665 * casetab.c (init_casetab_once):
1666 * category.c (init_category_once, syms_of_category):
1667 * ccl.c (syms_of_ccl):
1668 * cmds.c (syms_of_cmds):
1669 * composite.c (syms_of_composite):
1670 * dbusbind.c (syms_of_dbusbind):
1671 * dired.c (syms_of_dired):
1672 * dispnew.c (syms_of_display):
1673 * doc.c (syms_of_doc):
1674 * editfns.c (syms_of_editfns):
1675 * emacs.c (syms_of_emacs):
1676 * eval.c (syms_of_eval):
1677 * fileio.c (syms_of_fileio):
1678 * fns.c (syms_of_fns):
1679 * frame.c (syms_of_frame):
1680 * fringe.c (syms_of_fringe):
1681 * insdel.c (syms_of_insdel):
1682 * keymap.c (syms_of_keymap):
1683 * lread.c (init_obarray, syms_of_lread):
1684 * macros.c (syms_of_macros):
1685 * msdos.c (syms_of_msdos):
1686 * print.c (syms_of_print):
1687 * process.c (syms_of_process):
1688 * search.c (syms_of_search):
1689 * sound.c (syms_of_sound):
1690 * syntax.c (init_syntax_once, syms_of_syntax):
1691 * terminal.c (syms_of_terminal):
1692 * textprop.c (syms_of_textprop):
1693 * undo.c (syms_of_undo):
1694 * w32.c (globals_of_w32):
1695 * window.c (syms_of_window):
1696 * xdisp.c (syms_of_xdisp):
1697 * xfaces.c (syms_of_xfaces):
1698 * xfns.c (syms_of_xfns):
1699 * xmenu.c (syms_of_xmenu):
1700 * xsettings.c (syms_of_xsettings):
1701 * xterm.c (syms_of_xterm): Use DEFSYM.
1702
1703 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1704
1705 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1706
1707 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 Integer and buffer overflow fixes (Bug#8873).
1710
1711 * print.c (printchar, strout): Check for string overflow.
1712 (PRINTPREPARE, printchar, strout):
1713 Don't set size unless allocation succeeds.
1714
1715 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1716 for sizes. Check for string overflow more accurately.
1717 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1718
1719 * macros.c: Integer and buffer overflow fixes.
1720 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1721 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1722 Use ptrdiff_t, not int, for sizes.
1723 Don't increment bufsize until after realloc succeeds.
1724 Check for size-calculation overflow.
1725 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1726
1727 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1728
1729 * lread.c: Integer overflow fixes.
1730 (read_integer): Radix is now EMACS_INT, not int,
1731 to improve quality of diagnostics for out-of-range radices.
1732 Calculate buffer size correctly for out-of-range radices.
1733 (read1): Check for integer overflow in radices, and in
1734 read-circle numbers.
1735 (read_escape): Avoid int overflow.
1736 (Fload, openp, read_buffer_size, read1)
1737 (substitute_object_recurse, read_vector, read_list, map_obarray):
1738 Use ptrdiff_t, not int, for sizes.
1739 (read1): Use EMACS_INT, not int, for sizes.
1740 Check for size overflow.
1741
1742 * image.c (cache_image): Check for size arithmetic overflow.
1743
1744 * lread.c: Integer overflow issues.
1745 (saved_doc_string_size, saved_doc_string_length)
1746 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1747 Now ptrdiff_t, not int.
1748 (read1): Don't assume doc string length fits in int. Check for
1749 out-of-range doc string lengths.
1750 (read_list): Don't assume file position fits in int.
1751 (read_escape): Check for hex character overflow.
1752
1753 2011-06-22 Leo Liu <sdl.web@gmail.com>
1754
1755 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1756 Move to minibuffer.el.
1757
1758 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1759
1760 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1761 The following patches are for when GLYPH_DEBUG && !XASSERT.
1762 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1763 * dispnew.c (flush_stdout):
1764 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1765 Mark as externally visible.
1766 * dispnew.c (check_window_matrix_pointers): Now static.
1767 * dispnew.c (window_to_frame_vpos):
1768 * xfns.c (unwind_create_frame):
1769 * xterm.c (x_check_font): Remove unused local.
1770 * scroll.c (CHECK_BOUNDS):
1771 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1772 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1773 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1774 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1775 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1776 Now static.
1777 (debug_method_add): Use va_list and vsprintf rather than relying
1778 on undefined behavior with wrong number of arguments.
1779 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1780 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1781 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1782 since we're not interested in debugging glyphs with old libraries.
1783 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1784 GCC 4.6.0's static checking.
1785
1786 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 Integer overflow and signedness fixes (Bug#8873).
1789 A few related buffer overrun fixes, too.
1790
1791 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1792
1793 * dispextern.h (struct face.stipple):
1794 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1795 (x_bitmap_mask, x_allocate_bitmap_record)
1796 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1797 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1798 (x_create_bitmap_from_xpm_data):
1799 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1800 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1801 (.bitmaps_last):
1802 * xfaces.c (load_pixmap):
1803 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1804 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1805 (.bitmaps_last, struct x_output.icon_bitmap):
1806 Use ptrdiff_t, not int, for bitmap indexes.
1807 (x_allocate_bitmap_record): Check for size overflow.
1808 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1809
1810 Use ptrdiff_t, not int, for overlay counts.
1811 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1812 * editfns.c (overlays_around, get_pos_property):
1813 * textprop.c (get_char_property_and_overlay):
1814 * xdisp.c (next_overlay_change, note_mouse_highlight):
1815 * xfaces.c (face_at_buffer_position):
1816 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1817 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1818 (Fnext_overlay_change, Fprevious_overlay_change)
1819 (mouse_face_overlay_overlaps, Foverlays_in):
1820 Use ptrdiff_t, not int, for sizes.
1821 (overlays_at, overlays_in): Check for size-calculation overflow.
1822
1823 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1824
1825 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1826 (x_session_initialize): Do not assume string length fits in int.
1827
1828 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1829 This is unlikely, but can occur if DPI is outlandish.
1830
1831 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1832 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1833
1834 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1835 * xrdb.c (magic_file_p, search_magic_path):
1836 Omit last arg SUFFIX; it was always 0. All callers changed.
1837 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1838
1839 * xfont.c (xfont_match): Avoid need for strlen.
1840
1841 * xfns.c: Don't assume strlen fits in int.
1842 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1843
1844 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1845 not unsigned long, as we prefer signed integers. All callers changed.
1846 Detect integer overflow in repeat count.
1847 (message_dolog): Don't assume print length fits in 39 bytes.
1848 (display_mode_element): Don't assume strlen fits in int.
1849
1850 * termcap.c: Don't assume sizes fit in int and never overflow.
1851 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1852 (gobble_line): Check for size-calculation overflow.
1853
1854 * minibuf.c (Fread_buffer):
1855 * lread.c (intern, intern_c_string):
1856 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1857 Don't assume string length fits in int.
1858
1859 * keyboard.c (parse_tool_bar_item):
1860 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1861
1862 * font.c: Don't assume string length fits in int.
1863 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1864 Use ptrdiff_t, not int.
1865 (font_intern_prop): Don't assume string length fits in int.
1866 Don't assume integer property fits in fixnum.
1867 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1868
1869 * filelock.c: Fix some buffer overrun and integer overflow issues.
1870 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1871 Reformulate so as not to need the command string.
1872 Invoke gzip -cd rather than gunzip, as it's more portable.
1873 (lock_info_type, lock_file_1, lock_file):
1874 Don't assume pid_t and time_t fit in unsigned long.
1875 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1876 (current_lock_owner): Prefer signed type for sizes.
1877 Use memcpy, not strncpy, where memcpy is what is really wanted.
1878 Don't assume (via atoi) that time_t and pid_t fit in int.
1879 Check for time_t and/or pid_t out of range, e.g., via a network share.
1880 Don't alloca where an auto var works fine.
1881
1882 * fileio.c: Fix some integer overflow issues.
1883 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1884 Don't assume string length fits in int.
1885 (directory_file_name): Don't assume string length fits in long.
1886 (make_temp_name): Don't assume pid fits in int, or that its print
1887 length is less than 20.
1888
1889 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1890
1891 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1892
1893 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1894
1895 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1896 We prefer signed integers, even for size calculations.
1897
1898 * emacs.c: Don't assume string length fits in 'int'.
1899 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1900 (main): Don't invoke strlen when not needed.
1901
1902 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1903 (XD_DEBUG_MESSAGE): Don't waste a byte.
1904
1905 * callproc.c (getenv_internal_1, getenv_internal)
1906 (Fgetenv_internal):
1907 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1908
1909 * lread.c (invalid_syntax): Omit length argument.
1910 All uses changed. This doesn't fix a bug, but it simplifies the
1911 code away from its former Hollerith-constant appearance, and it's
1912 one less 'int' to worry about when looking at integer-overflow issues.
1913 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1914
1915 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1916 This didn't break anything, but it didn't help either.
1917 It's confusing to put a bogus integer in a place where the actual
1918 value does not matter.
1919 (LIST_END_P): Remove unused macro and its bogus comment.
1920 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1921
1922 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1923 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1924 implementation.
1925 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1926 We prefer signed types, and the value cannot exceed the EMACS_INT
1927 range anyway (because otherwise the length would not be representable).
1928 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1929 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1930 This avoids a GCC warning when WIDE_EMACS_INT.
1931
1932 * indent.c (sane_tab_width): New function.
1933 (current_column, scan_for_column, Findent_to, position_indentation)
1934 (compute_motion): Use it. This is just for clarity.
1935 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1936
1937 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1938
1939 * lisp.h (lint_assume): New macro.
1940 * composite.c (composition_gstring_put_cache):
1941 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1942
1943 * editfns.c, insdel.c:
1944 Omit unnecessary forward decls, to simplify future changes.
1945
1946 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1947
1948 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1949
1950 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1951 Use much-faster test for byte-length change.
1952 Don't assume string byte-length fits in 'int'.
1953 Check that character arg fits in 'int'.
1954 (mapcar1): Declare byte as byte, for clarity.
1955
1956 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1957
1958 * fns.c (concat): Catch string overflow earlier.
1959 Do not rely on integer wraparound.
1960
1961 * dispextern.h (struct it.overlay_strings_charpos)
1962 (struct it.selective): Now EMACS_INT, not int.
1963 * xdisp.c (forward_to_next_line_start)
1964 (back_to_previous_visible_line_start)
1965 (reseat_at_next_visible_line_start, next_element_from_buffer):
1966 Don't arbitrarily truncate the value of 'selective' to int.
1967
1968 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1969
1970 * composite.c: Don't truncate sizes to 'int'.
1971 (composition_gstring_p, composition_reseat_it)
1972 (composition_adjust_point): Use EMACS_INT, not int.
1973 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1974 not EMACS_UINT, for indexes.
1975
1976 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1977
1978 * buffer.c: Include <verify.h>.
1979 (struct sortvec.priority, struct sortstr.priority):
1980 Now EMACS_INT, not int.
1981 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1982 (struct sortstr.size, record_overlay_string)
1983 (struct sortstrlist.size, struct sortlist.used):
1984 Don't truncate size to int.
1985 (record_overlay_string): Check for size-calculation overflow.
1986 (init_buffer_once): Check at compile-time, not run-time.
1987
1988 2011-06-22 Jim Meyering <meyering@redhat.com>
1989
1990 Don't leak an XBM-image-sized buffer
1991 * image.c (xbm_load): Free the image buffer after using it.
1992
1993 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 Port to Sun C.
1996 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1997 that Sun C diagnosed.
1998 * fns.c (secure_hash): Fix pointer signedness issue.
1999 * intervals.c (static_offset_intervals): New function.
2000 (offset_intervals): Use it.
2001
2002 2011-06-21 Leo Liu <sdl.web@gmail.com>
2003
2004 * deps.mk (fns.o):
2005 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2006 sha512.h.
2007
2008 * fns.c (secure_hash): Rename from crypto_hash_function and change
2009 the first arg to accept symbols.
2010 (Fsecure_hash): New primitive.
2011 (syms_of_fns): New symbols.
2012
2013 2011-06-20 Deniz Dogan <deniz@dogan.se>
2014
2015 * process.c (Fset_process_buffer): Clarify return value in
2016 docstring.
2017
2018 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2019
2020 * dispnew.c (add_window_display_history): Use BVAR.
2021
2022 * xdisp.c (debug_method_add): Use BVAR.
2023 (check_window_end, dump_glyph_matrix, dump_glyph)
2024 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2025
2026 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2027 Likewise.
2028
2029 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2030 check till after the cache is created in init_frame_faces.
2031
2032 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2033
2034 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2035
2036 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2039 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2040 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2041
2042 Improve buffer-overflow checking (Bug#8873).
2043 * fileio.c (Finsert_file_contents):
2044 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2045 Remove the old (too-loose) buffer overflow checks.
2046 They weren't needed, since make_gap checks for buffer overflow.
2047 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2048 The old code merely checked for Emacs fixnum overflow, and relied
2049 on undefined (wraparound) behavior. The new code avoids undefined
2050 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2051
2052 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2053 Tune. Don't use wider integers than needed. Don't use alloca.
2054 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2055
2056 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2057
2058 * insdel.c, lisp.h (buffer_overflow): New function.
2059 (insert_from_buffer_1, replace_range, replace_range_2):
2060 * insdel.c (make_gap_larger):
2061 * editfns.c (Finsert_char):
2062 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2063
2064 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2065
2066 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2067
2068 Integer overflow and signedness fixes (Bug#8873).
2069
2070 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2071 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2072
2073 * fileio.c: Don't assume EMACS_INT fits in off_t.
2074 (emacs_lseek): New static function.
2075 (Finsert_file_contents, Fwrite_region): Use it.
2076 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2077
2078 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2079
2080 * fns.c: Don't overflow int when computing a list length.
2081 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2082 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2083 truncation on 64-bit hosts. Check for QUIT every
2084 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2085 faster and is responsive enough.
2086 (Flength): Report an error instead of overflowing an integer.
2087 (Fsafe_length): Return a float if the value is not representable
2088 as a fixnum. This shouldn't happen except in contrived situations.
2089 (Fnthcdr, Fsort): Don't assume list length fits in int.
2090 (Fcopy_sequence): Don't assume vector length fits in int.
2091
2092 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2093 (header_size, word_size): New constants.
2094 (allocate_vectorlike): Don't check size overflow here.
2095 (allocate_vector): Check it here instead, since this is the only
2096 caller of allocate_vectorlike that could cause overflow.
2097 Check that the new vector's length is representable as a fixnum.
2098
2099 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2100 The previous code was bogus. For example, next_almost_prime (32)
2101 returned 39, which is undesirable as it is a multiple of 3; and
2102 next_almost_prime (24) returned 25, which is a multiple of 5 so
2103 why was the code bothering to check for multiples of 7?
2104
2105 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2106
2107 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2108
2109 Variadic C functions now count arguments with ptrdiff_t.
2110 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2111 Back then I didn't know that the Emacs coding style prefers signed int.
2112 Also, in the meantime I found a few more instances where arguments
2113 were being counted with int, which may truncate counts on 64-bit
2114 machines, or EMACS_INT, which may be unnecessarily wide.
2115 * lisp.h (struct Lisp_Subr.function.aMANY)
2116 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2117 Arg counts are now ptrdiff_t, not size_t.
2118 All variadic functions and their callers changed accordingly.
2119 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2120 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2121 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2122 * callint.c (Fcall_interactively): Check arg count for overflow,
2123 to avoid potential buffer overrun. Use signed char, not 'int',
2124 for 'varies' array, so that we needn't bother to check its size
2125 calculation for overflow.
2126 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2127 * eval.c (apply_lambda):
2128 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2129 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2130 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2131
2132 * callint.c (Fcall_interactively): Don't use index var as event count.
2133
2134 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2135 * mem-limits.h (SIZE): Remove; no longer used.
2136
2137 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2138
2139 Remove unnecessary casts.
2140 * xterm.c (x_term_init):
2141 * xfns.c (x_set_border_pixel):
2142 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2143 These aren't needed now that we assume ANSI C.
2144
2145 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2146 It's more likely to cause problems (due to unsigned overflow)
2147 than to cure them.
2148
2149 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2150
2151 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2152
2153 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2154
2155 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2156
2157 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2158
2159 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2160
2161 GLYPH_CODE_FACE returns EMACS_INT, not int.
2162 * dispextern.h (merge_faces):
2163 * xfaces.c (merge_faces):
2164 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2165 Don't assume EMACS_INT fits in int.
2166
2167 * character.h (CHAR_VALID_P): Remove unused parameter.
2168 * fontset.c, lisp.h, xdisp.c: All uses changed.
2169
2170 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2171
2172 * fns.c (concat): Minor tuning based on overflow analysis.
2173 This doesn't fix any bugs. Use int to hold character, instead
2174 of constantly refetching from Emacs object. Use XFASTINT, not
2175 XINT, for value known to be a character. Don't bother comparing
2176 a single byte to 0400, as it's always less.
2177
2178 * floatfns.c (Fexpt):
2179 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2180
2181 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2182 for characters.
2183
2184 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2185
2186 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2187 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2188 incorrectly succeed when S was a string, because 4294967386 was
2189 truncated before it was used.
2190
2191 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2192 Otherwise, an out-of-range integer could cause undefined behavior
2193 on a 64-bit host.
2194
2195 * composite.c: Use int, not EMACS_INT, for characters.
2196 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2197 EMACS_INT, for values that are known to be in character range.
2198 This doesn't fix any bugs but is the usual style inside Emacs and
2199 may generate better code on 32-bit machines.
2200
2201 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2202 This is for reasons similar to the recent CHAR_STRING fix.
2203 * charset.c (Fencode_char): Check that character arg is actually
2204 a character. Pass an int to ENCODE_CHAR.
2205 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2206 wider than 'int', as a compile-time check to prevent future regressions
2207 in this area.
2208
2209 * character.c (char_string): Remove unnecessary casts.
2210
2211 Make sure a 64-bit char is never passed to CHAR_STRING.
2212 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2213 by silently ignoring the top 32 bits, allowing some values
2214 that were far too large to be valid characters.
2215 * character.h: Include <verify.h>.
2216 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2217 arguments are no wider than unsigned, as a compile-time check
2218 to prevent future regressions in this area.
2219 * data.c (Faset):
2220 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2221 (Fsubst_char_in_region):
2222 * fns.c (concat):
2223 * xdisp.c (decode_mode_spec_coding):
2224 Adjust to CHAR_STRING's new requirement.
2225 * editfns.c (Finsert_char, Fsubst_char_in_region):
2226 * fns.c (concat): Check that character args are actually
2227 characters. Without this test, these functions did the wrong
2228 thing with wildly out-of-range values on 64-bit hosts.
2229
2230 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2231 These casts should not be needed on 32-bit hosts, either.
2232 * keyboard.c (read_char):
2233 * lread.c (Fload): Remove casts to unsigned.
2234
2235 * lisp.h (UNSIGNED_CMP): New macro.
2236 This fixes comparison bugs on 64-bit hosts.
2237 (ASCII_CHAR_P): Use it.
2238 * casefiddle.c (casify_object):
2239 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2240 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2241 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2242 * dispextern.h (FACE_FROM_ID):
2243 * keyboard.c (read_char): Use UNSIGNED_CMP.
2244
2245 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2246 not to EMACS_INT, to avoid GCC warning.
2247
2248 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2249
2250 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2251 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2252 isn't needed on 32-bit machines.
2253
2254 * buffer.c (Fgenerate_new_buffer_name):
2255 Use EMACS_INT for count, not int.
2256 (advance_to_char_boundary): Return EMACS_INT, not int.
2257
2258 * data.c (Qcompiled_function): Now static.
2259
2260 * window.c (window_body_lines): Now static.
2261
2262 * image.c (gif_load): Rename local to avoid shadowing.
2263
2264 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2265 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2266 * alloc.c (make_save_value): Integer argument is now of type
2267 ptrdiff_t, not int.
2268 (mark_object): Use ptrdiff_t, not int.
2269 * lisp.h (pD): New macro.
2270 * print.c (print_object): Use it.
2271
2272 * alloc.c: Use EMACS_INT, not int, to count objects.
2273 (total_conses, total_markers, total_symbols, total_vector_size)
2274 (total_free_conses, total_free_markers, total_free_symbols)
2275 (total_free_floats, total_floats, total_free_intervals)
2276 (total_intervals, total_strings, total_free_strings):
2277 Now EMACS_INT, not int. All uses changed.
2278 (Fgarbage_collect): Compute overall total using a double, so that
2279 integer overflow is less likely to be a problem. Check for overflow
2280 when converting back to an integer.
2281 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2282 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2283 These were 'int' variables that could overflow on 64-bit hosts;
2284 they were never used, so remove them instead of repairing them.
2285 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2286 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2287 Previously, this ceilinged at INT_MAX, but that doesn't work on
2288 64-bit machines.
2289 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2290
2291 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2292 (allocate_vectorlike): Check for ptrdiff_t overflow.
2293 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2294 when a (possibly-narrower) signed value would do just as well.
2295 We prefer using signed arithmetic, to avoid comparison confusion.
2296
2297 * alloc.c: Catch some string size overflows that we were missing.
2298 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2299 for convenience in STRING_BYTES_MAX.
2300 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2301 The definition here is exact; the one in lisp.h was approximate.
2302 (allocate_string_data): Check for string overflow. This catches
2303 some instances we weren't catching before. Also, it catches
2304 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2305 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2306 and ptrdiff_t and EMACS_INT are both 64 bits.
2307
2308 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2309 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2310 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2311
2312 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2313
2314 * alloc.c (Fmake_string): Check for out-of-range init.
2315
2316 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2317
2318 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2319
2320 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2321
2322 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2323 xg_get_default_scrollbar_width.
2324
2325 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2326 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2327 (style_changed_cb): Call update_theme_scrollbar_width and call
2328 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2329 all frames (Bug#8505).
2330 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2331 Call gtk_window_set_resizable if HAVE_GTK3.
2332 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2333 and height if HAVE_GTK3 (Bug#8505).
2334 (scroll_bar_width_for_theme): New variable.
2335 (update_theme_scrollbar_width): New function.
2336 (xg_get_default_scrollbar_width): Move code to
2337 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2338 (xg_initialize): Call update_theme_scrollbar_width.
2339
2340 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2341
2342 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2343
2344 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2345
2346 * frame.c (make_frame): Call other_buffer_safely instead of
2347 other_buffer.
2348
2349 * window.c (temp_output_buffer_show): Call display_buffer with
2350 second argument Vtemp_buffer_show_specifiers and reset latter
2351 immediately after the call.
2352 (Vtemp_buffer_show_specifiers): New variable.
2353 (auto_window_vscroll_p, next_screen_context_lines)
2354 (Vscroll_preserve_screen_position): Remove leading asterisks from
2355 doc-strings.
2356
2357 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 Fix minor problems found by GCC 4.6.0 static checking.
2360 * buffer.c (Qclone_number): Remove for now, as it's unused.
2361 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2362 (record_buffer): Remove unused local.
2363 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2364 (set_frame_buffer_list): Remove; unused.
2365 * frame.h (other_visible_frames): Remove decl.
2366 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2367 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2368 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2369 if HAVE_GPM.
2370 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2371 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2372 Define only if HAVE_GPM.
2373 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2374 (update_hints_inhibit): Remove; never set. All uses removed.
2375 * widgetprv.h (emacsFrameClassRec): Remove decl.
2376 * window.c (delete_deletable_window): Now returns void, since it
2377 wasn't returning anything.
2378 (compare_window_configurations): Remove unused locals.
2379 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2380 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2381 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2382 the same widths as pointers. This follows up on the 2011-05-06 patch.
2383 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2384 * xterm.h: Likewise.
2385 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2386
2387 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2388
2389 * makefile.w32-in: Update dependencies.
2390 (LISP_H): Add lib/intprops.h.
2391
2392 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2393
2394 * image.c (gif_load): Add animation frame delay to the metadata.
2395 (syms_of_image): Use DEFSYM. New symbol `delay'.
2396
2397 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2398
2399 * window.c (delete_deletable_window): Re-add.
2400 (Fset_window_configuration): Rewrite to handle dead buffers and
2401 consequently deletable windows.
2402 (window_tree, Fwindow_tree): Remove. Supply functionality in
2403 window.el.
2404 (compare_window_configurations): Simplify code.
2405
2406 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2407
2408 * image.c (imagemagick_load_image): Fix type mismatch.
2409 (Fimagemagick_types): Likewise.
2410
2411 * window.h (replace_buffer_in_windows): Declare.
2412
2413 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2414
2415 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2416 Qclone_number. Remove external declaration of Qdelete_window.
2417 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2418 code.
2419 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2420 Run Qbuffer_list_update_hook if allowed.
2421 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2422 buffer list implementation.
2423 (other_buffer_safely): New function.
2424 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2425 calls to replace_buffer_in_windows and
2426 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2427 if allowed.
2428 (record_buffer): Inhibit quitting and rewrite using quittable
2429 functions. Run Qbuffer_list_update_hook if allowed.
2430 (Frecord_buffer, Funrecord_buffer): New functions.
2431 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2432 Move switch-to-buffer to window.el.
2433 (bury-buffer): Move to window.el.
2434 (Vbuffer_list_update_hook): New variable.
2435
2436 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2437 section.
2438
2439 * window.h (resize_frame_windows): Move up in code.
2440 (Fwindow_frame): Remove EXFUN.
2441 (replace_buffer_in_all_windows): Remove prototype.
2442 (replace_buffer_in_windows_safely): Add prototype.
2443
2444 * window.c: Declare Qdelete_window static again. Move down
2445 declaration of select_count.
2446 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2447 (Fother_window): Move to window.el.
2448 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2449 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2450 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2451 window.el.
2452 (replace_buffer_in_windows): Implement by calling
2453 Qreplace_buffer_in_windows.
2454 (replace_buffer_in_all_windows): Remove with some functionality
2455 moved into replace_buffer_in_windows_safely.
2456 (replace_buffer_in_windows_safely): New function.
2457 (select_window_norecord, select_frame_norecord): Move in front
2458 of run_window_configuration_change_hook. Remove now obsolete
2459 declarations.
2460 (Fset_window_buffer): Rewrite doc-string.
2461 Call Qrecord_window_buffer.
2462 (keys_of_window): Move binding for other-window to window.el.
2463
2464 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2465
2466 * dispextern.h (struct image): Replace data member, whose int_val
2467 and ptr_val fields were not used by anything, with a single
2468 lisp_val object.
2469
2470 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2471 (gif_clear_image, gif_load, imagemagick_load_image)
2472 (gs_clear_image, gs_load): Callers changed.
2473
2474 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2475
2476 * buffer.h: Include <time.h>, for time_t.
2477 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2478
2479 Fix minor problems found by static checking.
2480
2481 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2482
2483 Make identifiers static if they are not used in other modules.
2484 * data.c (Qcompiled_function, Qframe, Qvector):
2485 * image.c (QimageMagick, Qsvg):
2486 * minibuf.c (Qmetadata):
2487 * window.c (resize_window_check, resize_root_window): Now static.
2488 * window.h (resize_window_check, resize_root_window): Remove decls.
2489
2490 * window.c (window_deletion_count, delete_deletable_window):
2491 Remove; unused.
2492 (window_body_lines): Now static.
2493 (Fdelete_other_windows_internal): Mark vars as initialized.
2494 Make sure 'resize_failed' is initialized.
2495 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2496 (resize_window_apply): Remove unused local.
2497 * window.h (delete_deletable_window): Remove decl.
2498
2499 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2500 (imagemagick_load_image): Fix pointer signedness problem by changing
2501 last arg from unsigned char * to char *. All uses changed.
2502 Also, fix a local for similar reasons.
2503 Remove unused locals. Remove locals to avoid shadowing.
2504 (fn_rsvg_handle_free): Remove; unused.
2505 (svg_load, svg_load_image): Fix pointer signedness problem.
2506 (imagemagick_load_image): Don't use garbage pointer image_wand.
2507
2508 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2509
2510 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2511
2512 * image.c (gif_load): Fix omitted cast error introduced by
2513 2011-06-06 change.
2514
2515 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2516
2517 * window.h (resize_proportionally, orig_total_lines)
2518 (orig_top_line): Remove from window structure.
2519 (set_window_height, set_window_width, change_window_heights)
2520 (Fdelete_window): Remove prototypes.
2521 (resize_frame_windows): Remove duplicate declaration.
2522
2523 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2524
2525 * window.h (resize_frame_windows, resize_window_check)
2526 (delete_deletable_window, resize_root_window)
2527 (resize_frame_windows): Declare prototypes.
2528
2529 * window.c (resize_window_apply): Make definition be "static" to
2530 match the prototype.
2531
2532 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2533
2534 * window.c: Remove declarations of Qwindow_size_fixed,
2535 window_min_size_1, window_min_size_2, window_min_size,
2536 size_window, window_fixed_size_p, enlarge_window, delete_window.
2537 Remove static from declaration of Qdelete_window, it's
2538 temporarily needed by Fbury_buffer.
2539 (replace_window): Don't assign orig_top_line and
2540 orig_total_lines.
2541 (Fdelete_window, delete_window): Remove. Window deletion is
2542 handled by window.el.
2543 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2544 Replace Fdelete_window calls with calls to Qdelete_window.
2545 (Fdelete_other_windows): Remove. Deleting other windows is
2546 handled by window.el.
2547 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2548 handled in window.el.
2549 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2550 Window minimum sizes are handled in window.el.
2551 (shrink_windows, size_window, set_window_height)
2552 (set_window_width, change_window_heights, window_height)
2553 (window_width, CURBEG, CURSIZE, enlarge_window)
2554 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2555 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2556 handled in window.el.
2557 (make_dummy_parent): Rename to make_parent_window and give it a
2558 second argument horflag.
2559 (make_window): Don't set resize_proportionally any more.
2560 (Fsplit_window): Remove. Windows are split in window.el.
2561 (save_restore_action, save_restore_orig_size)
2562 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2563 Resize mini windows in window.el.
2564 (grow_mini_window, shrink_mini_window): Implement by calling
2565 Qresize_root_window_vertically, resize_window_check and
2566 resize_window_apply.
2567 (saved_window, Fset_window_configuration, save_window_save):
2568 Do not handle orig_top_line, orig_total_lines, and
2569 resize_proportionally.
2570 (window_min_height, window_min_width): Move to window.el.
2571 (keys_of_window): Move bindings for delete-other-windows,
2572 split-window, delete-window and enlarge-window to window.el.
2573
2574 * buffer.c: Temporarily extern Qdelete_window.
2575 (Fbury_buffer): Temporarily call Qdelete_window instead of
2576 Fdelete_window (Fbury_buffer will move to window.el soon).
2577
2578 * frame.c (set_menu_bar_lines_1): Remove code handling
2579 orig_top_line and orig_total_lines.
2580
2581 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2582 set_window_height but set heights directly.
2583 (change_frame_size_1): Use resize_frame_windows.
2584
2585 * xdisp.c (init_xdisp): Don't use set_window_height but set
2586 heights directly.
2587
2588 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2589 Use resize_frame_windows instead of change_window_heights and run
2590 run_window_configuration_change_hook.
2591
2592 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2593 instead of change_window_heights and run
2594 run_window_configuration_change_hook.
2595
2596 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2597
2598 * window.c (replace_window): Rename second argument REPLACEMENT to
2599 NEW. New third argument SETFLAG. Rewrite.
2600 (delete_window, make_dummy_parent): Call replace_window with
2601 third argument 1.
2602 (window_list_1): Move down in code.
2603 (run_window_configuration_change_hook): Move set_buffer part
2604 before select_frame_norecord part in order to unwind correctly.
2605 Rename count1 to count.
2606 (recombine_windows, delete_deletable_window, resize_root_window)
2607 (Fdelete_other_windows_internal)
2608 (Frun_window_configuration_change_hook, make_parent_window)
2609 (resize_window_check, resize_window_apply, Fresize_window_apply)
2610 (resize_frame_windows, Fsplit_window_internal)
2611 (Fdelete_window_internal, Fresize_mini_window_internal):
2612 New functions.
2613 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2614
2615 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2616
2617 * window.h (window): Add some new members to window structure -
2618 normal_lines, normal_cols, new_total, new_normal, clone_number,
2619 splits, nest, prev_buffers, next_buffers.
2620 (WINDOW_TOTAL_SIZE): Move here from window.c.
2621 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2622
2623 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2624 Remove.
2625 (make_dummy_parent): Set new members of windows structure.
2626 (make_window): Move down in code. Handle new members of window
2627 structure.
2628 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2629 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2630 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2631 (Fset_window_prev_buffers, Fwindow_next_buffers)
2632 (Fset_window_next_buffers, Fset_window_clone_number):
2633 New functions.
2634 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2635 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2636 Doc-string fixes.
2637 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2638 Argument WINDOW can be now internal window too.
2639 (Fwindow_use_time): Move up in code.
2640 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2641 Rewrite doc-string.
2642 (Fset_window_configuration, saved_window)
2643 (Fcurrent_window_configuration, save_window_save): Handle new
2644 members of window structure.
2645 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2646 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2647 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2648 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2649 Qget_mru_window, Qresize_root_window,
2650 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2651 Qauto_buffer_name; staticpro them.
2652
2653 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2654
2655 * window.c (Fwindow_total_size, Fwindow_left_column)
2656 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2657 (Fwindow_list_1): New functions.
2658 (window_box_text_cols): Replace with window_body_cols.
2659 (Fwindow_width, Fscroll_left, Fscroll_right):
2660 Use window_body_cols instead of window_box_text_cols.
2661 (delete_window, Fset_window_configuration):
2662 Call delete_all_subwindows with window as argument.
2663 (delete_all_subwindows): Take a window as argument and not a
2664 structure. Rewrite.
2665 (window_loop): Remove handling of GET_LRU_WINDOW and
2666 GET_LARGEST_WINDOW.
2667 (Fget_lru_window, Fget_largest_window): Move to window.el.
2668
2669 * window.h: Extern window_body_cols instead of
2670 window_box_text_cols. delete_all_subwindows now takes a
2671 Lisp_Object as argument.
2672
2673 * indent.c (compute_motion, Fcompute_motion):
2674 Use window_body_cols instead of window_box_text_cols.
2675
2676 * frame.c (delete_frame): Call delete_all_subwindows with root
2677 window as argument.
2678
2679 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2680
2681 * fns.c (Fputhash): Document return value.
2682
2683 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2684
2685 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2686
2687 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 Cons<->int and similar integer overflow fixes (Bug#8794).
2690
2691 Check for overflow when converting integer to cons and back.
2692 * charset.c (Fdefine_charset_internal, Fdecode_char):
2693 Use cons_to_unsigned to catch overflow.
2694 (Fencode_char): Use INTEGER_TO_CONS.
2695 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2696 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2697 * data.c (long_to_cons, cons_to_long): Remove.
2698 (cons_to_unsigned, cons_to_signed): New functions.
2699 These signal an error for invalid or out-of-range values.
2700 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2701 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2702 * font.c (Ffont_variation_glyphs):
2703 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2704 * lisp.h: Include <intprops.h>.
2705 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2706 (cons_to_signed, cons_to_unsigned): New decls.
2707 (long_to_cons, cons_to_long): Remove decls.
2708 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2709 (Fprimitive_undo): Use CONS_TO_INTEGER.
2710 * xfns.c (Fx_window_property): Likewise.
2711 * xselect.c: Include <limits.h>.
2712 (x_own_selection, selection_data_to_lisp_data):
2713 Use INTEGER_TO_CONS.
2714 (x_handle_selection_request, x_handle_selection_clear)
2715 (x_get_foreign_selection, Fx_disown_selection_internal)
2716 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2717 (lisp_data_to_selection_data): Use cons_to_unsigned.
2718 (x_fill_property_data): Use cons_to_signed.
2719 Report values out of range.
2720
2721 Check for buffer and string overflow more precisely.
2722 * buffer.h (BUF_BYTES_MAX): New macro.
2723 * lisp.h (STRING_BYTES_MAX): New macro.
2724 * alloc.c (Fmake_string):
2725 * character.c (string_escape_byte8):
2726 * coding.c (coding_alloc_by_realloc):
2727 * doprnt.c (doprnt):
2728 * editfns.c (Fformat):
2729 * eval.c (verror):
2730 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2731 since they may not be the same number.
2732 * editfns.c (Finsert_char):
2733 * fileio.c (Finsert_file_contents):
2734 Likewise for BUF_BYTES_MAX.
2735
2736 * image.c: Use ptrdiff_t, not int, for sizes.
2737 (slurp_file): Switch from int to ptrdiff_t.
2738 All uses changed.
2739 (slurp_file): Check that file size fits in both size_t (for
2740 malloc) and ptrdiff_t (for sanity and safety).
2741
2742 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2743 if b->modtime has its maximal value.
2744
2745 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2746
2747 Don't assume time_t can fit into int.
2748 * buffer.h (struct buffer.modtime): Now time_t, not int.
2749 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2750 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2751
2752 Minor fixes for signed vs unsigned integers.
2753 * character.h (MAYBE_UNIFY_CHAR):
2754 * charset.c (maybe_unify_char):
2755 * keyboard.c (read_char, reorder_modifiers):
2756 XINT -> XFASTINT, since the integer must be nonnegative.
2757 * ftfont.c (ftfont_spec_pattern):
2758 * keymap.c (access_keymap, silly_event_symbol_error):
2759 XUINT -> XFASTINT, since the integer must be nonnegative.
2760 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2761 since it makes no difference and we prefer signed.
2762 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2763 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2764 nonnegative.
2765
2766 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2767
2768 * window.h (Fwindow_frame): Declare.
2769
2770 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2773 (SPARE_MEMORY): Always define.
2774 (LARGE_REQUEST): Remove.
2775 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2776
2777 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2778
2779 * lisp.h: Move EXFUNS for Fframe_root_window,
2780 Fframe_first_window and Fset_frame_selected_window to window.h.
2781
2782 * window.h: Move EXFUNS for Fframe_root_window,
2783 Fframe_first_window and Fset_frame_selected_window here from
2784 lisp.h.
2785
2786 * frame.c (Fwindow_frame, Fframe_first_window)
2787 (Fframe_root_window, Fframe_selected_window)
2788 (Fset_frame_selected_window): Move to window.c.
2789 (Factive_minibuffer_window): Move to minibuf.c.
2790 (Fother_visible_frames_p): New function.
2791
2792 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2793
2794 * window.c (decode_window, decode_any_window): Move up in code.
2795 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2796 (inhibit_frame_unsplittable): Remove unused variable.
2797 (Fwindow_buffer): Move up and rewrite doc-string.
2798 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2799 (Fwindow_prev): New functions.
2800 (Fwindow_frame): Move here from frame.c. Accept any window as
2801 argument.
2802 (Fframe_root_window, Fframe_first_window)
2803 (Fframe_selected_window): Move here from frame.c. Accept frame
2804 or arbitrary window as argument. Update doc-strings.
2805 (Fminibuffer_window): Move up in code.
2806 (Fwindow_minibuffer_p): Move up in code and simplify.
2807 (Fset_frame_selected_window): Move here from frame.c.
2808 Marginal rewrite.
2809 (Fselected_window, select_window, Fselect_window): Move up in
2810 code. Minor doc-string fixes.
2811
2812 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2813
2814 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2815 Do not assume that spare memory exists; that assumption is valid
2816 only if SYSTEM_MALLOC.
2817 (LARGE_REQUEST): New macro, so that the issue of large requests
2818 is separated from the issue of spare memory.
2819
2820 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2821
2822 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2823 format. (Bug#8806)
2824
2825 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2826
2827 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2828 before statements.
2829
2830 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2831
2832 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2833
2834 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2835
2836 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2837 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2838
2839 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2840
2841 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2842
2843 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2844
2845 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2846 (x_clipboard_manager_save): Add return value.
2847 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2848 New error handlers.
2849 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2850 Obey Vx_select_enable_clipboard_manager. Catch errors in
2851 x_clipboard_manager_save (Bug#8779).
2852 (Vx_select_enable_clipboard_manager): New variable.
2853 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2854
2855 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2856
2857 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2858
2859 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2860
2861 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2862 in the current matrix if keep_current_p is non-zero.
2863
2864 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2865
2866 * bidi.c (bidi_level_of_next_char): Fix last change.
2867
2868 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2869
2870 Support bidi reordering of text covered by display properties.
2871
2872 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2873 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2874 (bidi_cache_search, bidi_cache_iterator_state)
2875 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2876 (bidi_level_of_next_char, bidi_move_to_visually_next):
2877 Support character positions inside a run of characters covered by a
2878 display string.
2879 (bidi_paragraph_init, bidi_resolve_explicit_1)
2880 (bidi_level_of_next_char): Call bidi_fetch_char and
2881 bidi_fetch_char_advance instead of FETCH_CHAR and
2882 FETCH_CHAR_ADVANCE.
2883 (bidi_init_it): Initialize new members.
2884 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2885 definitions.
2886 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2887 instead of using explicit *_CHAR codes.
2888 (bidi_resolve_explicit, bidi_resolve_weak):
2889 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2890 bidirectional text is supported only in multibyte buffers.
2891 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2892 it to initialize the frame_window_p member of struct bidi_it.
2893 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2894 (bidi_resolve_explicit, bidi_resolve_weak)
2895 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2896 bidi_it->nchars is non-positive.
2897 (bidi_level_of_next_char): Don't try to lookup the cache for the
2898 next/previous character if nothing is cached there yet, or if we
2899 were just reseat()'ed to a new position.
2900
2901 * xdisp.c (set_cursor_from_row): Set start and stop points
2902 according to the row's direction when priming the loop that looks
2903 for the glyph on which to display cursor.
2904 (single_display_spec_intangible_p): Function deleted.
2905 (display_prop_intangible_p): Reimplement to call
2906 handle_display_spec instead of single_display_spec_intangible_p.
2907 Accept 3 additional arguments needed by handle_display_spec.
2908 This fixes incorrect cursor motion across display property with complex
2909 values: lists, `(when COND...)' forms, etc.
2910 (single_display_spec_string_p): Support property values that are
2911 lists with the argument STRING its top-level element.
2912 (display_prop_string_p): Fix the condition for processing a
2913 property that is a list to be consistent with handle_display_spec.
2914 (handle_display_spec): New function, refactored from the
2915 last portion of handle_display_prop.
2916 (compute_display_string_pos): Accept additional argument
2917 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2918 value of a `display' property is a "replacing spec".
2919 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2920 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2921 the display property, but just return a value indicating whether
2922 the display property will replace the characters it covers.
2923 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2924 frame_window_p members of struct bidi_it.
2925 (compute_display_string_pos, compute_display_string_end):
2926 New functions.
2927 (push_it): Accept second argument POSITION, where pop_it should
2928 jump to continue iteration.
2929 (reseat_1): Initialize bidi_it.disp_pos.
2930
2931 * keyboard.c (adjust_point_for_property): Adjust the call to
2932 display_prop_intangible_p to its new signature.
2933
2934 * dispextern.h (struct bidi_it): New member frame_window_p.
2935 (bidi_init_it): Update prototypes.
2936 (display_prop_intangible_p): Update prototype.
2937 (compute_display_string_pos, compute_display_string_end):
2938 Declare prototypes.
2939 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2940 EMACS_INT.
2941
2942 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 Malloc failure behavior now depends on size of allocation.
2945 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2946 * lisp.h: Change signatures accordingly.
2947 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2948 All callers changed. (Bug#8762)
2949
2950 * gnutls.c: Use Emacs's memory allocators.
2951 Without this change, the gnutls library would invoke malloc etc.
2952 directly, which causes problems on non-SYNC_INPUT hosts, and which
2953 runs afoul of improving memory_full behavior. (Bug#8761)
2954 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2955 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2956 xfree instead of the default malloc, realloc, free.
2957 (Fgnutls_boot): No need to check for memory allocation failure,
2958 since xmalloc does that for us.
2959
2960 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2961 * category.c (hash_get_category_set):
2962 * ccl.c (ccl_driver):
2963 * charset.c (Fdefine_charset_internal):
2964 * charset.h (struct charset.hash_index):
2965 * composite.c (get_composition_id, gstring_lookup_cache)
2966 (composition_gstring_put_cache):
2967 * composite.h (struct composition.hash_index):
2968 * dispextern.h (struct image.hash):
2969 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2970 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2971 (hashfn_equal, hashfn_user_defined, make_hash_table)
2972 (maybe_resize_hash_table, hash_lookup, hash_put)
2973 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2974 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2975 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2976 * image.c (make_image, search_image_cache, lookup_image)
2977 (xpm_put_color_table_h):
2978 * lisp.h (struct Lisp_Hash_Table):
2979 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2980 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2981 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2982 * alloc.c (allocate_vectorlike):
2983 Check for overflow in vector size calculations.
2984 * ccl.c (ccl_driver):
2985 Check for overflow when converting EMACS_INT to int.
2986 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2987 need to be updated by these changes.
2988 * fns.c (make_hash_table, maybe_resize_hash_table):
2989 Check for integer overflow with large hash tables.
2990 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2991 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2992 (SXHASH_REDUCE): New macro.
2993 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2994 Use it instead of discarding useful hash info with large hash values.
2995 (sxhash_float): New function.
2996 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2997 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2998 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2999 Rewrite to use FIXNUM_BITS, as this simplifies things.
3000 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3001 Adjust signatures to match updated version of code.
3002 (consing_since_gc): Now EMACS_INT, since a single hash table can
3003 use more than INT_MAX bytes.
3004
3005 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3006
3007 Make it possible to build with GCC-4.6+ -O2 -flto.
3008
3009 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3010
3011 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3012
3013 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3014 Call minibuffer-inactive-mode.
3015
3016 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3017
3018 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3019 Update dependencies.
3020
3021 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3022
3023 * data.c (init_data): Remove code for UTS, this system is not
3024 supported anymore.
3025
3026 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3027
3028 Don't force ./temacs to start in terminal mode.
3029
3030 * frame.c (make_initial_frame): Initialize faces in all cases, not
3031 only when CANNOT_DUMP is defined.
3032 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3033
3034 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3035
3036 * dispnew.c (add_window_display_history): Use const for the string
3037 pointer. Remove declaration, not needed.
3038
3039 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3040
3041 Use 'inline', not 'INLINE'.
3042 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3043 * alloc.c, fontset.c (INLINE): Remove.
3044 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3045 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3046 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3047 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3048 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3049
3050 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3051
3052 Make it possible to run ./temacs.
3053
3054 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3055 syms_of_callproc does the same thing. Remove test for
3056 "initialized", do it in the caller.
3057 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3058
3059 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3060
3061 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3062 (read_minibuf): Use get_minibuffer.
3063 (syms_of_minibuf): Use DEFSYM.
3064 (Qmetadata): New var.
3065 * data.c (Qbuffer): Don't make it static.
3066 (syms_of_data): Use DEFSYM.
3067
3068 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3069
3070 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3071 (CCL_CODE_MIN): New macro.
3072
3073 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3076
3077 * eval.c (Qdebug): Now static.
3078 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3079 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3080 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3081
3082 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3083
3084 * image.c: Various fixes to ImageMagick code comments.
3085 (Fimagemagick_types): Doc fix.
3086
3087 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3088
3089 Minor fixes prompted by GCC 4.6.0 warnings.
3090
3091 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3092
3093 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3094 (x_clipboard_manager_save_all): Move extern decl to ...
3095 * xterm.h: ... here, so that it can be checked for consistency.
3096
3097 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3098
3099 * xselect.c (x_clipboard_manager_save_frame)
3100 (x_clipboard_manager_save_all): New functions.
3101 (Fx_clipboard_manager_save): Lisp function deleted.
3102
3103 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3104 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3105
3106 * xterm.h: Update prototype.
3107
3108 2011-05-28 William Xu <william.xwl@gmail.com>
3109
3110 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3111 exiting (Bug#8239).
3112
3113 2011-05-28 Jim Meyering <meyering@redhat.com>
3114
3115 Avoid a sign-extension bug in crypto_hash_function.
3116 * fns.c (to_uchar): Define.
3117 (crypto_hash_function): Use it to convert some newly-signed
3118 variables to unsigned, to avoid sign-extension bugs. For example,
3119 without this change, (md5 "truc") would evaluate to
3120 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3121 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3122 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3123
3124 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3125
3126 Integer overflow fixes.
3127
3128 * dbusbind.c: Serial number integer overflow fixes.
3129 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3130 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3131 to hold a serial number that is too large for a fixnum.
3132 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3133 Check for serial numbers out of range. Decode any serial number
3134 that was so large that it became a float. (Bug#8722)
3135
3136 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3137 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3138 Use XFASTINT rather than XUINT when numbers are nonnegative.
3139 (xd_append_arg, Fdbus_method_return_internal):
3140 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3141 arguments, check that Lisp number is nonnegative, rather than
3142 silently wrapping negative numbers around. (Bug#8722)
3143 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3144 (Bug#8722)
3145
3146 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3147
3148 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3149
3150 ccl: add integer overflow checks
3151 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3152 (IN_INT_RANGE): New macros.
3153 (ccl_driver): Use them to check for integer overflow when
3154 decoding a CCL program. Many of the new checks are whether XINT (x)
3155 fits in int; it doesn't always, on 64-bit hosts. The new version
3156 doesn't catch all possible integer overflows, but it's an
3157 improvement. (Bug#8719)
3158
3159 * alloc.c (make_event_array): Use XINT, not XUINT.
3160 There's no need for unsigned here.
3161
3162 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3163 This follows up to the 2011-05-06 change that substituted uintptr_t
3164 for EMACS_INT. This case wasn't caught back then.
3165
3166 Rework Fformat to avoid integer overflow issues.
3167 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3168 now (part of C89). Include <verify.h>.
3169 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3170 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3171 (Fformat): Avoid the prepass trying to compute sizes; it was only
3172 approximate and thus did not catch overflow reliably. Instead, walk
3173 through the format just once, formatting and computing sizes as we go,
3174 checking for integer overflow at every step, and allocating a larger
3175 buffer as needed. Keep track separately whether the format is
3176 multibyte. Keep only the most-recently calculated precision, rather
3177 than them all. Record whether each argument has been converted to
3178 string. Use EMACS_INT, not int, for byte and char and arg counts.
3179 Support field widths and precisions larger than INT_MAX. Avoid
3180 sprintf's undefined behavior with conversion specifications such as %#d
3181 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3182 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3183 formatting out-of-range floating point numbers with int
3184 formats. (Bug#8668)
3185
3186 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3187
3188 * data.c: Avoid integer truncation in expressions involving floats.
3189 * data.c: Include <intprops.h>.
3190 (arith_driver): When there's an integer overflow in an expression
3191 involving floating point, convert the integers to floating point
3192 so that the resulting value does not suffer from catastrophic
3193 integer truncation. For example, on a 64-bit host (* 4
3194 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3195 Do not rely on undefined behavior after integer overflow.
3196
3197 merge count_size_as_multibyte, parse_str_to_multibyte
3198 * character.c, character.h (count_size_as_multibyte):
3199 Rename from parse_str_to_multibyte; all uses changed.
3200 Check for integer overflow.
3201 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3202 since it's now a duplicate of the other. This is more of
3203 a character than a buffer op, so better that it's in character.c.
3204 * fns.c, print.c: Adjust to above changes.
3205
3206 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3207
3208 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3209
3210 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3213 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3214 (x_clipboard_manager_save): Now static.
3215 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3216
3217 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3218 (crypto_hash_function): Now static.
3219 Fix pointer signedness problems. Avoid unnecessary initializations.
3220
3221 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3222
3223 * termhooks.h (Vselection_alist): Make it terminal-local.
3224
3225 * terminal.c (create_terminal): Initialize it.
3226
3227 * xselect.c: Support for clipboard managers.
3228 (Vselection_alist): Move to termhooks.h as terminal-local var.
3229 (LOCAL_SELECTION): New macro.
3230 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3231 (symbol_to_x_atom): Remove gratuitous arg.
3232 (x_handle_selection_request, lisp_data_to_selection_data)
3233 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3234 (x_own_selection, x_get_local_selection, x_convert_selection):
3235 New arg, specifying work frame. Use terminal-local Vselection_alist.
3236 (some_frame_on_display): Delete unused function.
3237 (Fx_own_selection_internal, Fx_get_selection_internal)
3238 (Fx_disown_selection_internal, Fx_selection_owner_p)
3239 (Fx_selection_exists_p): New optional frame arg.
3240 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3241 (x_handle_selection_clear): Don't treat other terminals with the
3242 same keyboard specially. Use the terminal-local Vselection_alist.
3243 (x_clear_frame_selections): Use Frun_hook_with_args.
3244
3245 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3246
3247 * xterm.h: Add support for those atoms.
3248
3249 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3250
3251 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3252 (converted_selections, conversion_fail_tag): New global variables.
3253 (x_selection_request_lisp_error): Free the above.
3254 (x_get_local_selection): Remove unnecessary code.
3255 (x_reply_selection_request): Args changed; handle arbitrary array
3256 of converted selections stored in converted_selections.
3257 Separate the XChangeProperty and SelectionNotify steps.
3258 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3259 (x_convert_selection): New function.
3260 (x_handle_selection_event): Simplify.
3261 (x_get_foreign_selection): Don't ignore incoming requests while
3262 waiting for an answer; this will fail when we implement
3263 SAVE_TARGETS, and seems unnecessary anyway.
3264 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3265 (Vx_sent_selection_functions): Doc fix.
3266
3267 2011-05-26 Leo Liu <sdl.web@gmail.com>
3268
3269 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3270
3271 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3272
3273 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3274
3275 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3276 for fringe update if it has periodic bitmap.
3277 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3278 and fringe_bitmap_periodic_p.
3279
3280 * fringe.c (get_fringe_bitmap_data): New function.
3281 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3282 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3283 row. Mark glyph row for fringe update if periodicity changed.
3284
3285 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3286 for fringe update unless it has periodic bitmap.
3287
3288 2011-05-25 Kenichi Handa <handa@m17n.org>
3289
3290 * xdisp.c (get_next_display_element): Set correct it->face_id for
3291 a static composition.
3292
3293 2011-05-24 Leo Liu <sdl.web@gmail.com>
3294
3295 * deps.mk (fns.o):
3296 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3297
3298 * fns.c (crypto_hash_function, Fsha1): New function.
3299 (Fmd5): Use crypto_hash_function.
3300 (syms_of_fns): Add Ssha1.
3301
3302 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3303
3304 * gnutls.c: Remove unused macros.
3305 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3306 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3307 Remove macros that are defined and never used.
3308 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3309
3310 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3311
3312 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3313 (Fx_get_selection_internal): Minor cleanup.
3314 (Fx_own_selection_internal): Rename arguments for consistency with
3315 select.el.
3316
3317 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3320
3321 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3322
3323 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3324
3325 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3326
3327 * dispnew.c (scrolling_window): Don't exclude the case that the
3328 last enabled row in the desired matrix touches the bottom boundary.
3329
3330 2011-05-21 Glenn Morris <rgm@gnu.org>
3331
3332 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3333 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3334 and add some more files.
3335
3336 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3337
3338 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3339 report_file_error introduced by the change from 2011-05-07.
3340
3341 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3342
3343 * systime.h (Time): Define only if emacs is defined.
3344 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3345 where the include path doesn't have X11/X.h by default. See
3346 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3347
3348 2011-05-20 Kenichi Handa <handa@m17n.org>
3349
3350 * composite.c (find_automatic_composition): Fix previous change.
3351
3352 2011-05-20 Glenn Morris <rgm@gnu.org>
3353
3354 * lisp.mk: New file, split from Makefile.in.
3355 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3356 (shortlisp): Remove.
3357 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3358
3359 2011-05-19 Glenn Morris <rgm@gnu.org>
3360
3361 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3362 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3363 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3364 (lisp): Set the order to that of loadup.el.
3365 (shortlisp): Make it a copy of $lisp.
3366 (SOME_MACHINE_LISP): Remove.
3367 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3368 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3369
3370 2011-05-18 Kenichi Handa <handa@m17n.org>
3371
3372 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3373 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3374 (find_automatic_composition): Mostly rewrite for efficiency.
3375
3376 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3377
3378 * makefile.w32-in: Update dependencies.
3379
3380 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3381
3382 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3383 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3384
3385 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3386
3387 Fix some integer overflow issues, such as string length overflow.
3388
3389 * insdel.c (count_size_as_multibyte): Check for string overflow.
3390
3391 * character.c (lisp_string_width): Check for string overflow.
3392 Use EMACS_INT, not int, for string indexes and lengths; in
3393 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3394 the resulting string length overflows an EMACS_INT; instead,
3395 report a string overflow if no precision given. When checking for
3396 precision exhaustion, use a check that cannot possibly have
3397 integer overflow. (Bug#8675)
3398 * character.h (lisp_string_width): Adjust to new signature.
3399
3400 * alloc.c (string_overflow): New function.
3401 (Fmake_string): Use it. This doesn't change behavior, but saves
3402 a few bytes and will simplify future changes.
3403 * character.c (string_escape_byte8): Likewise.
3404 * lisp.h (string_overflow): New decl.
3405
3406 Fixups, following up to the user-interface timestamp change.
3407 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3408 for UI timestamps, instead of unsigned long.
3409 * msdos.c (mouse_get_pos): Likewise.
3410 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3411 * w32gui.h (Time): Define by including "systime.h" rather than by
3412 declaring it ourselves. (Bug#8664)
3413
3414 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3415 * image.c (clear_image_cache): Likewise.
3416
3417 * term.c (term_mouse_position): Don't assume time_t wraparound.
3418
3419 Be more systematic about user-interface timestamps.
3420 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3421 and sometimes 'EMACS_UINT', to represent these timestamps.
3422 This change causes it to use 'Time' uniformly, as that's what X uses.
3423 This makes the code easier to follow, and makes it easier to catch
3424 integer overflow bugs such as Bug#8664.
3425 * frame.c (Fmouse_position, Fmouse_pixel_position):
3426 Use Time, not unsigned long, for user-interface timestamps.
3427 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3428 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3429 * keyboard.h (last_event_timestamp): Likewise.
3430 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3431 * menu.h (xmenu_show): Likewise.
3432 * term.c (term_mouse_position): Likewise.
3433 * termhooks.h (struct input_event.timestamp): Likewise.
3434 (struct terminal.mouse_position_hook): Likewise.
3435 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3436 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3437 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3438 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3439 what it was before.
3440 * menu.h, termhooks.h: Include "systime.h", for Time.
3441
3442 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3443 Don't assume that the difference between two unsigned long values
3444 can fit into an integer. At this point, we know button_down_time
3445 <= event->timestamp, so the difference must be nonnegative, so
3446 there's no need to cast the result if double-click-time is
3447 nonnegative, as it should be; check that it's nonnegative, just in
3448 case. This bug is triggered when events are more than 2**31 ms
3449 apart (about 25 days). (Bug#8664)
3450
3451 * xselect.c (last_event_timestamp): Remove duplicate decl.
3452 (x_own_selection): Remove needless cast to unsigned long.
3453
3454 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3455 that always fit in int. Use a sentinel instead of a counter, to
3456 avoid a temp and to allay GCC's concerns about possible int overflow.
3457 * frame.h (struct frame): Use int for menu_bar_items_used
3458 instead of EMACS_INT, since it always fits in int.
3459
3460 * menu.c (grow_menu_items): Check for int overflow.
3461
3462 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3463
3464 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3465 Before, the code was not consistent. These values cannot exceed
3466 2**31 - 1 so there's no need to make them unsigned.
3467 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3468 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3469 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3470 as modifiers.
3471 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3472
3473 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3474 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3475 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3476 presumably because the widths might not match.
3477
3478 * window.c (size_window): Avoid needless test at loop start.
3479
3480 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3481
3482 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3483
3484 2011-05-12 Drew Adams <drew.adams@oracle.com>
3485
3486 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3487
3488 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3489
3490 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3491 `width' to `bar_area_x' and `bar_area_width', respectively.
3492 (x_scroll_run): Take account of fringe background extension.
3493
3494 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3495 Rename local vars `left' and `width' to `bar_area_x' and
3496 `bar_area_width', respectively.
3497 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3498 background extension.
3499
3500 2011-05-10 Jim Meyering <meyering@redhat.com>
3501
3502 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3503
3504 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3505
3506 * image.c (Finit_image_library): Return t for built-in image types,
3507 like pbm and xbm. (Bug#8640)
3508
3509 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3510
3511 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3512
3513 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3514
3515 * w32console.c (Fset_screen_color): Doc fix.
3516 (Fget_screen_color): New function.
3517 (syms_of_ntterm): Defsubr it.
3518
3519 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3520 unlink the temporary file if Fcall_process didn't create it in the
3521 first place.
3522 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3523 child process will be redirected to a file specified with `:file'.
3524 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3525 cue to call_process_cleanup not to close that handle.
3526
3527 2011-05-07 Ben Key <bkey76@gmail.com>
3528
3529 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3530 one of two shell specific rules, either bootstrap-temacs-CMD or
3531 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3532 to the previous implementation of the bootstrap-temacs rule.
3533 The bootstrap-temacs-CMD rule is similar to the previous
3534 implementation of the bootstrap-temacs rule except that it
3535 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3536 variable.
3537
3538 These changes, along with some changes to nt/configure.bat,
3539 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3540 earlier fix to add support for --cflags and --ldflags options
3541 that include quotes so that it works whether make uses cmd or
3542 sh as the shell.
3543
3544 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3545
3546 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3547 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3548 is a constant.
3549 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3550 a string. Handle both cases.
3551 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3552 (Fdbus_register_method): Use Qinvalid_function.
3553
3554 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3555
3556 * makefile.w32-in: Update dependencies.
3557 (LISP_H): Add inttypes.h and stdin.h.
3558 (PROCESS_H): Add unistd.h.
3559
3560 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3561
3562 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3563 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3564
3565 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3566
3567 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3568
3569 * term.c (vfatal): Remove stray call to va_end.
3570 It's not needed and the C Standard doesn't allow it here anyway.
3571
3572 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3573 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3574
3575 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3576 bytes.
3577
3578 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3579
3580 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3581
3582 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3583
3584 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3585
3586 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3587
3588 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3589 * charset.c (Fdefine_charset_internal): Don't initialize
3590 charset.code_space[15]. The value was garbage, on hosts with
3591 32-bit int (Bug#8600).
3592
3593 * lread.c (read_integer): Be more consistent with string-to-number.
3594 Use string_to_number to do the actual conversion; this avoids
3595 rounding errors and fixes some other screwups. Without this fix,
3596 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3597 (digit_to_number): Move earlier, for benefit of read_integer.
3598 Return -1 if the digit is out of range for the base, -2 if it is
3599 not a digit in any supported base. (Bug#8602)
3600
3601 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3602
3603 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3604 to match comment at start of function. This also removes a
3605 GCC warning about overflow in a 32+64-bit port.
3606
3607 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3608
3609 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3610 Reported by Stefan Monnier in
3611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3612 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3613 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3614
3615 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3616 (EMACS_UINTPTR): Likewise, with uintptr_t.
3617
3618 * lisp.h: Prefer 64-bit EMACS_INT if available.
3619 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3620 on 32-bit hosts that have 64-bit int, so that they can access
3621 large files.
3622 However, temporarily disable this change unless the temporary
3623 symbol WIDE_EMACS_INT is defined.
3624
3625 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3626
3627 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3628 This removes an assumption that EMACS_INT and long are the same
3629 width as pointers. The assumption is true for Emacs porting targets
3630 now, but we want to make other targets possible.
3631 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3632 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3633 In the rest of the code, change types of integers that hold casted
3634 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3635 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3636 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3637 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3638 No need to cast type when ORing.
3639 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3640 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3641 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3642 assume EMACS_INT is the same width as char *.
3643 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3644 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3645 Remove no-longer-needed casts.
3646 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3647 (xg_tool_bar_help_callback, xg_make_tool_item):
3648 Use EMACS_INTPTR to hold an integer
3649 that will be cast to void *; this can avoid a GCC warning
3650 if EMACS_INT is not the same width as void *.
3651 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3652 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3653 (current_message_1, set_message_1):
3654 Use a local to convert to proper width without a cast.
3655 * xmenu.c (dialog_selection_callback): Likewise.
3656
3657 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3658 Also, don't assume VALBITS / RAND_BITS is less than 5,
3659 and don't rely on undefined behavior when shifting a 1 left into
3660 the sign bit.
3661 * lisp.h (get_random): Change signature to match.
3662
3663 * lread.c (hash_string): Use size_t, not int, for hash computation.
3664 Normally we prefer signed values; but hashing is special, because
3665 it's better to use unsigned division on hash table sizes so that
3666 the remainder is nonnegative. Also, size_t is the natural width
3667 for hashing into memory. The previous code used 'int', which doesn't
3668 retain enough info to hash well into very large tables.
3669 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3670
3671 * dbusbind.c: Don't possibly lose pointer info when converting.
3672 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3673 Use XPNTR rather than XHASH, so that the high-order bits of
3674 the pointer aren't lost when converting through void *.
3675
3676 * eval.c (Fautoload): Don't double-shift a pointer.
3677
3678 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3679
3680 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3681
3682 * gnutls.c (DEF_GNUTLS_FN):
3683 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3684
3685 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3686
3687 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3688 marker. (Bug#8610)
3689
3690 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3691
3692 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3693 New version that can reserve upto 2GB of heap space.
3694
3695 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3696
3697 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3698
3699 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3700
3701 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3702 `gnutls_certificate_set_x509_key_file'.
3703
3704 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3705
3706 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3707 Update dependencies.
3708
3709 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3710
3711 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3712 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3713 Remove unused parameter `fildes'.
3714 * process.c (read_process_output, send_process): Don't pass it.
3715
3716 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3717
3718 Fix previous change: the library cache is defined in w32.c.
3719 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3720 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3721
3722 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3723
3724 Implement dynamic loading of GnuTLS on Windows.
3725
3726 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3727 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3728 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3729 Declare.
3730
3731 * gnutls.c (Qgnutls_dll): Define.
3732 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3733 (gnutls_*): Declare function pointers.
3734 (init_gnutls_functions): New function to initialize function pointers.
3735 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3736 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3737 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3738 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3739 (emacs_gnutls_write, emacs_gnutls_read)
3740 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3741 (Fgnutls_available_p): New function.
3742 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3743 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3744 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3745
3746 * image.c: Include w32.h.
3747 (Vimage_type_cache): Delete.
3748 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3749 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3750 (w32_delayed_load): Move to w32.c.
3751
3752 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3753
3754 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3755 (w32_delayed_load): Move from image.c. When loading a library, record
3756 its filename in the :loaded-from property of the library id.
3757 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3758 Initialize and staticpro them.
3759 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3760
3761 * process.c: Include lisp.h before w32.h, not after.
3762 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3763 instead of gnutls_record_check_pending.
3764
3765 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3766
3767 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3768
3769 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3770 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3771 as passed in.
3772
3773 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3774
3775 * xterm.c (x_set_frame_alpha): Do not set property on anything
3776 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3777
3778 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3779
3780 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3781
3782 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3783
3784 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3785 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3786 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3787 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3788 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3789 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3790 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3791 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3792 (Qgnutls_bootprop_callbacks_verify): Make static.
3793
3794 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3795
3796 * callproc.c: Indentation fixup.
3797
3798 * sysdep.c (wait_for_termination_1): Make static.
3799 (wait_for_termination, interruptible_wait_for_termination):
3800 Move after wait_for_termination_1.
3801
3802 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3803
3804 * sysdep.c (interruptible_wait_for_termination): New function
3805 which is like wait_for_termination, but allows keyboard
3806 interruptions.
3807
3808 * callproc.c (Fcall_process): Add (:file "file") as an option for
3809 the STDOUT buffer.
3810 (Fcall_process_region): Ditto.
3811
3812 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3813
3814 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3815 rather than `XVECTOR (FOO)->size'.
3816
3817 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3818 inttypes.h, as a gnulib replacement is used if it not available in
3819 system headers.
3820
3821 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3822
3823 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3824 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3825 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3826
3827 * coding.c (coding_alloc_by_realloc): Error out if destination
3828 will grow beyond MOST_POSITIVE_FIXNUM.
3829 (decode_coding_emacs_mule): Abort if there isn't enough place in
3830 charbuf for the composition carryover bytes. Reserve an extra
3831 space for up to 2 characters produced in a loop.
3832 (decode_coding_iso_2022): Abort if there isn't enough place in
3833 charbuf for the composition carryover bytes.
3834
3835 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3836
3837 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3838 aborting when %lld or %lll format is passed.
3839 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3840 %llo or %llx format is passed. (Bug#8545)
3841
3842 * window.c (window_scroll_line_based): Use a marker instead of
3843 simple variables to record original value of point. (Bug#7952)
3844
3845 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3846 produced by %s or %c overflows available buffer space. (Bug#8545)
3847
3848 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3851 (SIZE_MAX): Move defn after all includes, as they might #define it.
3852
3853 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3854
3855 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3856
3857 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3858
3859 * keyboard.c (Qdelayed_warnings_hook): Define.
3860 (command_loop_1): Run `delayed-warnings-hook'
3861 if Vdelayed_warnings_list is non-nil.
3862 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3863 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3864
3865 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3866
3867 * doprnt.c (doprnt): Don't return value smaller than the buffer
3868 size if the message was truncated. (Bug#8545).
3869
3870 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3871
3872 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3873 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3874
3875 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3878
3879 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3880
3881 * makefile.w32-in: Update dependencies.
3882
3883 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3884
3885 Improve `doprnt' and its usage. (Bug#8545)
3886 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3887 `format_end'. Remove support for %l as a conversion specifier.
3888 Don't use xrealloc. Improve diagnostics when the %l size modifier
3889 is used. Update the commentary.
3890
3891 * eval.c (verror): Simplify calculation of size_t.
3892
3893 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3894 messages.
3895
3896 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3897
3898 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3899 change.
3900
3901 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3904 This makes this file independent of the recent pseudovector change.
3905
3906 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3907
3908 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3909
3910 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3911 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3912 Remove unused local.
3913 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3914
3915 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3916 GCC 4.6.0 optimizes based on type-based alias analysis.
3917 For example, if b is of type struct buffer * and v of type struct
3918 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3919 != &v->size, and therefore "v->size = 1; b->size = 2; return
3920 v->size;" must therefore return 1. This assumption is incorrect
3921 for Emacs, since it type-puns struct Lisp_Vector * with many other
3922 types. To fix this problem, this patch adds a new type struct
3923 vectorlike_header that documents the constraints on layout of vectors
3924 and pseudovectors, and helps optimizing compilers not get fooled
3925 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3926 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3927 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3928 the size member.
3929 (XSETPVECTYPE): Rewrite in terms of new macro.
3930 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3931 This is a bit clearer, and further avoids the possibility of
3932 undesirable aliasing.
3933 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3934 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3935 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3936 since Lisp_Subr is a special case (no "next" field).
3937 (ASIZE): Now uses header.size rather than size.
3938 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3939 to avoid the hassle of writing XVECTOR (foo)->header.size.
3940 (struct vectorlike_header): New type.
3941 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3942 object, to help avoid aliasing.
3943 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3944 (SUBRP): Likewise, since Lisp_Subr is a special case.
3945 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3946 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3947 (struct Lisp_Hash_Table): Combine first two members into a single
3948 struct vectorlike_header member. All uses of "size" and "next" members
3949 changed to be "header.size" and "header.next".
3950 * buffer.h (struct buffer): Likewise.
3951 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3952 * frame.h (struct frame): Likewise.
3953 * process.h (struct Lisp_Process): Likewise.
3954 * termhooks.h (struct terminal): Likewise.
3955 * window.c (struct save_window_data, struct saved_window): Likewise.
3956 * window.h (struct window): Likewise.
3957 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3958 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3959 * buffer.c (init_buffer_once): Likewise.
3960 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3961 special case.
3962 * process.c (Fformat_network_address): Use local var for size,
3963 for brevity.
3964
3965 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3966
3967 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3968 * data.c (atof): Remove decl; no longer used or needed.
3969 (digit_to_number): Move to lread.c.
3970 (Fstring_to_number): Use new string_to_number function, to be
3971 consistent with how the Lisp reader treats infinities and NaNs.
3972 Do not assume that floating-point numbers represent EMACS_INT
3973 without losing information; this is not true on most 64-bit hosts.
3974 Avoid double-rounding errors, by insisting on integers when
3975 parsing non-base-10 numbers, as the documentation specifies.
3976 * lisp.h (string_to_number): New decl, replacing ...
3977 (isfloat_string): Remove.
3978 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3979 (read1): Do not accept +. and -. as integers; this
3980 appears to have been a coding error. Similarly, do not accept
3981 strings like +-1e0 as floating point numbers. Do not report
3982 overflow for integer overflows unless the base is not 10 which
3983 means we have no simple and reliable way to continue.
3984 Break out the floating-point parsing into a new
3985 function string_to_number, so that Fstring_to_number parses
3986 floating point numbers consistently with the Lisp reader.
3987 (digit_to_number): Move here from data.c. Make it static inline.
3988 (E_CHAR, EXP_INT): Remove, replacing with ...
3989 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3990 (string_to_number): New function, replacing isfloat_string.
3991 This function checks for valid syntax and produces the resulting
3992 Lisp float number too. Rework it so that string-to-number
3993 no longer mishandles examples like "1.0e+". Use strtoumax,
3994 so that overflow for non-base-10 numbers is reported only when
3995 there's no portable and simple way to convert to floating point.
3996
3997 * textprop.c (set_text_properties_1): Rewrite for clarity,
3998 and to avoid GCC warning about integer overflow.
3999
4000 * intervals.h (struct interval): Use EMACS_INT for members
4001 where EMACS_UINT might cause problems. See
4002 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4003 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4004 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4005 All uses changed.
4006 (offset_intervals): Tell GCC not to worry about length overflow
4007 when negating a negative length.
4008
4009 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4010 (overrun_check_free): Likewise.
4011
4012 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4013 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4014 word size.
4015
4016 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4017 (gnutls_make_error): Rename local to avoid shadowing.
4018 (gnutls_emacs_global_deinit): ifdef out; not used.
4019 (Fgnutls_boot): Use const for pointer to readonly storage.
4020 Comment out unused local. Fix pointer signedness problems.
4021
4022 * lread.c (openp): Don't stuff size_t into an 'int'.
4023 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4024 about possible signed overflow.
4025
4026 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4027 (GDK_KEY_g): Don't define if already defined.
4028 (xg_prepare_tooltip): Avoid pointer signedness problem.
4029 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4030
4031 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4032 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4033
4034 * xfns.c (Fx_window_property): Simplify a bit,
4035 to make a bit faster and to avoid GCC 4.6.0 warning.
4036 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4037
4038 * fns.c (internal_equal): Don't assume size_t fits in int.
4039
4040 * alloc.c (compact_small_strings): Tighten assertion a little.
4041
4042 Replace pEd with more-general pI, and fix some printf arg casts.
4043 * lisp.h (pI): New macro, generalizing old pEd macro to other
4044 conversion specifiers. For example, use "...%"pI"d..." rather
4045 than "...%"pEd"...".
4046 (pEd): Remove. All uses replaced with similar uses of pI.
4047 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4048 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4049 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4050 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4051 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4052 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4053 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4054 64-bit hosts.
4055 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4056 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4057 * print.c (safe_debug_print, print_object): Likewise.
4058 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4059 to int.
4060 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4061 avoiding the 0 flag, which is not portable.
4062 * process.c (Fmake_network_process): Use pI to avoid cast.
4063 * region-cache.c (pp_cache): Likewise.
4064 * xdisp.c (decode_mode_spec): Likewise.
4065 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4066 behavior on 64-bit hosts with printf arg.
4067 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4068 (x_stop_queuing_selection_requests): Likewise.
4069 (x_get_window_property): Don't truncate byte count to an 'int'
4070 when tracing.
4071
4072 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4073 here, since it parses constructs like leading '-' and spaces,
4074 which are not wanted; and it overflows with large numbers.
4075 Instead, simply match F[0-9]+, which is what is wanted anyway.
4076
4077 * alloc.c: Remove unportable assumptions about struct layout.
4078 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4079 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4080 (allocate_vectorlike, make_pure_vector): Use the new macros,
4081 plus offsetof, to remove unportable assumptions about struct layout.
4082 These assumptions hold on all porting targets that I know of, but
4083 they are not guaranteed, they're easy to remove, and removing them
4084 makes further changes easier.
4085
4086 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4087 This doesn't fix a bug but makes the code clearer.
4088 (string_overrun_cookie): Now const. Use initializers that
4089 don't formally overflow signed char, to avoid warnings.
4090 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4091 can cause Emacs to crash when string overrun checking is enabled.
4092 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4093 multiple of sizeof (EMACS_INT); it need not be, if
4094 alignof(EMACS_INT) < sizeof (EMACS_INT).
4095 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4096
4097 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4098
4099 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4100
4101 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4102
4103 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4104 supposed to be handshaking. (Bug#8556)
4105 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4106
4107 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4108
4109 * lisp.h (Qdebug): List symbol.
4110 * eval.c (Qdebug): Restore global linkage.
4111 * keyboard.c (debug-on-event): New variable.
4112 (handle_user_signal): Break into debugger when debug-on-event
4113 matches the current signal symbol.
4114
4115 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4116
4117 * alloc.c (check_sblock, check_string_bytes)
4118 (check_string_free_list): Convert to standard C.
4119
4120 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4121
4122 * w32.c (emacs_gnutls_push): Fix typo.
4123
4124 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4125
4126 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4127 "cast to pointer from integer of different size".
4128
4129 Improve doprnt and its use in verror. (Bug#8545)
4130 * doprnt.c (doprnt): Document the set of format control sequences
4131 supported by the function. Use SAFE_ALLOCA instead of always
4132 using `alloca'.
4133
4134 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4135 is one byte too soon. Don't use xrealloc; instead xfree and
4136 xmalloc anew.
4137
4138 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4139
4140 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4141 callbacks stage.
4142
4143 * gnutls.c: Renamed global_initialized to
4144 gnutls_global_initialized. Added internals for the
4145 :verify-hostname-error, :verify-error, and :verify-flags
4146 parameters of `gnutls-boot' and documented those parameters in the
4147 docstring. Start callback support.
4148 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4149 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4150 on error. Return error code.
4151 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4152 (emacs_gnutls_read): Likewise.
4153 (Fgnutls_boot): Return handshake error code.
4154 (emacs_gnutls_handle_error): New function.
4155 (wsaerror_to_errno): Likewise.
4156
4157 * w32.h (emacs_gnutls_pull): Add prototype.
4158 (emacs_gnutls_push): Likewise.
4159
4160 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4161 (emacs_gnutls_push): Likewise.
4162
4163 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4164
4165 * process.c (wait_reading_process_output): Check if GnuTLS
4166 buffered some data internally if no FDs are set for TLS
4167 connections.
4168
4169 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4170 (LIBS): Link to USER_LIBS.
4171 ($(BLD)/gnutls.$(0)): New target.
4172
4173 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4174
4175 * xdisp.c (handle_single_display_spec): Rename the
4176 display_replaced_before_p argument into display_replaced_p, to
4177 make it consistent with the commentary. Fix typos in the
4178 commentary.
4179
4180 * textprop.c (syms_of_textprop): Remove dead code.
4181 (copy_text_properties): Delete obsolete commentary about an
4182 interface that was deleted long ago. Fix typos in the description
4183 of arguments.
4184
4185 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4186 to changes in oldXMenu/XMenu.h from 2011-04-16.
4187 <menu_help_message, prev_menu_help_message>: Constify.
4188 (IT_menu_make_room): menu->help_text is now `const char **';
4189 adjust.
4190
4191 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4192 to changes in oldXMenu/XMenu.h from 2011-04-16.
4193 (struct XMenu): Declare `help_text' `const char **'.
4194
4195 * xfaces.c <Qunspecified>: Make extern again.
4196
4197 * syntax.c: Include sys/types.h before including regex.h, as
4198 required by Posix.
4199
4200 * doc.c (get_doc_string): Improve the format passed to `error'.
4201
4202 * doprnt.c (doprnt): Improve commentary.
4203
4204 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4205
4206 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4207 them with etags.
4208
4209 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4210 changes in globals.h immediately force recompilation.
4211 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4212 $(CURDIR)/s/ms-w32.h.
4213 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4214
4215 * character.c (Fchar_direction): Function deleted.
4216 (syms_of_character): Don't defsubr it.
4217 <char-direction-table>: Deleted.
4218
4219 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4220
4221 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4222 * doprnt.c: Include limits.h.
4223 (SIZE_MAX): New macro.
4224 (doprnt): Return a size_t value. 2nd arg is now size_t.
4225 Many local variables are now size_t instead of int or unsigned.
4226 Improve overflow protection. Support `l' modifier for integer
4227 conversions. Support %l conversion. Don't assume an EMACS_INT
4228 argument for integer conversions and for %c.
4229
4230 * lisp.h (doprnt): Restore prototype.
4231
4232 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4233 $(SRC)/character.h.
4234
4235 * Makefile.in (base_obj): Add back doprnt.o.
4236
4237 * deps.mk (doprnt.o): Add back prerequisites.
4238 (callint.o): Depend on character.h.
4239
4240 * eval.c (internal_lisp_condition_case): Include the handler
4241 representation in the error message.
4242 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4243 when breaking from the loop.
4244
4245 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4246
4247 * callint.c (Fcall_interactively): When displaying error message
4248 about invalid control letter, pass the character's codepoint, not
4249 a pointer to its multibyte form. Improve display of the character
4250 in octal and display also its hex code.
4251
4252 * character.c (char_string): Use %x to display the (unsigned)
4253 codepoint of an invalid character, to avoid displaying a bogus
4254 negative value.
4255
4256 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4257 `error', not SYMBOL_NAME itself.
4258
4259 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4260 character arguments to `error'.
4261
4262 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4263 to `error' in error message about FINAL_CHAR argument. Make sure
4264 FINAL_CHAR is a character, and use %c when it is passed as
4265 argument to `error'.
4266
4267 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4268
4269 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4270
4271 * w32.c: Include <time.h>.
4272 (sys_localtime): New function.
4273
4274 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4275
4276 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4277
4278 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4279
4280 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4281
4282 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4283 zombies (Bug#8467).
4284
4285 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4286
4287 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4288 gl_state.e_property when gl_state.object is Qt.
4289
4290 * insdel.c (make_gap_larger): Remove limitation of buffer size
4291 to <= INT_MAX.
4292
4293 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4294
4295 * xdisp.c (lookup_glyphless_char_display)
4296 (produce_glyphless_glyph): Handle cons cell entry in
4297 glyphless-char-display.
4298 (Vglyphless_char_display): Document it.
4299
4300 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4301 glyphless-char-display.
4302
4303 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4304
4305 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4306
4307 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4308
4309 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4310 definition for no-X builds.
4311
4312 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4313
4314 Static checks with GCC 4.6.0 and non-default toolkits.
4315
4316 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4317
4318 * process.c (keyboard_bit_set): Define only if SIGIO.
4319 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4320 (send_process): Repair possible setjmp clobbering.
4321
4322 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4323
4324 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4325
4326 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4327
4328 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4329 Define only if needed.
4330
4331 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4332 by pacifying GCC about it. Maybe it's time to retire it?
4333 * xfaces.c (USG, __TIMEVAL__): Likewise.
4334
4335 * dispextern.h (struct redisplay_interface): Rename param
4336 to avoid shadowing.
4337 * termhooks.h (struct terminal): Likewise.
4338 * xterm.c (xembed_send_message): Likewise.
4339
4340 * insdel.c (make_gap_smaller): Define only if
4341 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4342
4343 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4344 it.
4345
4346 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4347 so that we aren't warned about unused symbols.
4348
4349 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4350
4351 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4352
4353 * xfns.c (x_real_positions): Mark locals as initialized.
4354
4355 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4356
4357 * xterm.c: Fix problems found by static analysis with other toolkits.
4358 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4359 (x_dispatch_event): Declare static if USE_GTK, and
4360 define if USE_GTK || USE_X_TOOLKIT.
4361 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4362 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4363 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4364 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4365
4366 * xmenu.c (menu_help_callback): Pointer type fixes.
4367 Use const pointers when pointing at readonly data. Avoid pointer
4368 signedness clashes.
4369 (FALSE): Remove unused macro.
4370 (update_frame_menubar): Remove unused decl.
4371
4372 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4373
4374 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4375 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4376 (single_menu_item): Rename local to avoid shadowing.
4377
4378 * keyboard.c (make_lispy_event): Remove unused local var.
4379
4380 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4381 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4382
4383 * bitmaps: Change bitmaps from unsigned char back to the X11
4384 compatible char. Avoid the old compiler warnings about
4385 out-of-range initializers by using, for example, '\xab' rather
4386 than 0xab.
4387
4388 * xgselect.c (xgselect_initialize): Check vs interface
4389 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4390
4391 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4392
4393 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4394 to read-only memory.
4395
4396 * fns.c (vector): Remove; this old hack is no longer needed.
4397
4398 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4399 Remove unused var.
4400 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4401
4402 * xrdb.c (x_load_resources): Omit unused local.
4403
4404 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4405 (x_window): Rename locals to avoid shadowing.
4406 (USG): Use the kludged USG macro, to pacify gcc.
4407
4408 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4409 (x_term_init): Remove local to avoid shadowing.
4410
4411 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4412
4413 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4414 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4415
4416 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4417
4418 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4419
4420 Fix regex.c, syntax.c and friends for buffers > 2GB.
4421 * syntax.h (struct gl_state_s): Declare character position members
4422 EMACS_INT.
4423
4424 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4425
4426 * textprop.c (verify_interval_modification, interval_of):
4427 Declare arguments EMACS_INT.
4428
4429 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4430 EMACS_INT.
4431
4432 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4433
4434 * indent.c (Fvertical_motion): Local variable it_start is now
4435 EMACS_INT.
4436
4437 * regex.c (re_match, re_match_2, re_match_2_internal)
4438 (bcmp_translate, regcomp, regexec, print_double_string)
4439 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4440 (re_compile_pattern, re_exec): Declare arguments and local
4441 variables `size_t' and `ssize_t' and return values `regoff_t', as
4442 appropriate.
4443 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4444 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4445 <compile_stack_type>: `size' and `avail' are now `size_t'.
4446
4447 * regex.h <regoff_t>: Use ssize_t, not int.
4448 (re_search, re_search_2, re_match, re_match_2): Arguments that
4449 specify buffer/string position and length are now ssize_t and
4450 size_t. Return type is regoff_t.
4451
4452 2011-04-16 Ben Key <bkey76@gmail.com>
4453
4454 * nsfont.m: Fixed bugs in ns_get_family and
4455 ns_descriptor_to_entity that were caused by using free to
4456 deallocate memory blocks that were allocated by xmalloc (via
4457 xstrdup). This caused Emacs to crash when compiled with
4458 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4459 --enable-checking=xmallocoverrun). xfree is now used to
4460 deallocate these memory blocks.
4461
4462 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4465
4466 emacs_write: Accept and return EMACS_INT for sizes.
4467 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4468 et seq.
4469 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4470 Accept and return EMACS_INT.
4471 (emacs_gnutls_write): Return the number of bytes written on
4472 partial writes.
4473 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4474 (emacs_read, emacs_write): Remove check for negative size, as the
4475 Emacs source code has been audited now.
4476 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4477 (emacs_read, emacs_write): Use it.
4478 * process.c (send_process): Adjust to the new signatures of
4479 emacs_write and emacs_gnutls_write. Do not attempt to store
4480 a byte offset into an 'int'; it might overflow.
4481 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4482
4483 * sound.c: Don't assume sizes fit in 'int'.
4484 (struct sound_device.period_size, alsa_period_size):
4485 Return EMACS_INT, not int.
4486 (struct sound_device.write, vox_write, alsa_write):
4487 Accept EMACS_INT, not int.
4488 (wav_play, au_play): Use EMACS_INT to store sizes and to
4489 record read return values.
4490
4491 2011-04-15 Ben Key <bkey76@gmail.com>
4492
4493 * keyboard.c (Qundefined): Don't declare static since it is used
4494 in nsfns.m.
4495 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4496 static since they are used in nsfont.m.
4497
4498 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4499
4500 * process.c (Qprocessp): Don't declare static.
4501 * lisp.h (Qprocessp): Declare again.
4502
4503 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4504
4505 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4506
4507 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 Improve C-level modularity by making more things 'static'.
4510
4511 Don't publish debugger-only interfaces to other modules.
4512 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4513 (verify_bytepos, count_markers): Move decls to the only modules
4514 that need them.
4515 * region-cache.h (pp_cache): Likewise.
4516 * window.h (check_all_windows): Likewise.
4517 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4518
4519 * sysdep.c (croak): Now static, if
4520 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4521 * syssignal.h (croak): Declare only if not static.
4522
4523 * alloc.c (refill_memory_reserve): Now static if
4524 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4525 * lisp.h (refill_memory_reserve): Declare only if not static.
4526
4527 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4528 Define only if USE_LUCID.
4529
4530 * xrdb.c (x_customization_string, x_rm_string): Now static.
4531
4532 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4533 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4534
4535 * xdisp.c (draw_row_with_mouse_face): Now static.
4536 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4537
4538 * window.h (check_all_windows): Mark externally visible.
4539
4540 * window.c (window_deletion_count): Now static.
4541
4542 * undo.c: Make symbols static if they're not exported.
4543 (last_undo_buffer, last_boundary_position, pending_boundary):
4544 Now static.
4545
4546 * textprop.c (interval_insert_behind_hooks): Now static.
4547 (interval_insert_in_front_hooks): Likewise.
4548
4549 * term.c: Make symbols static if they're not exported.
4550 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4551 (max_frame_lines, tty_set_terminal_modes):
4552 (tty_reset_terminal_modes, tty_turn_off_highlight):
4553 (get_tty_terminal): Now static.
4554 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4555 * termhooks.h (term_mouse_moveto): Do not declare if
4556 HAVE_WINDOW_SYSTEM.
4557 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4558 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4559
4560 * sysdep.c: Make symbols static if they're not exported.
4561 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4562 Now static.
4563 (sigprocmask_set, full_mask): Remove; unused.
4564 (wait_debugging): Mark as visible.
4565 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4566 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4567
4568 * syntax.c (syntax_temp): Define only if !__GNUC__.
4569
4570 * sound.c (current_sound_device, current_sound): Now static.
4571
4572 * search.c (searchbufs, searchbuf_head): Now static.
4573
4574 * scroll.c (scroll_cost): Remove; unused.
4575 * dispextern.h (scroll_cost): Remove decl.
4576
4577 * region-cache.h (pp_cache): Mark as externally visible.
4578
4579 * process.c: Make symbols static if they're not exported.
4580 (process_tick, update_tick, create_process, chan_process):
4581 (Vprocess_alist, proc_buffered_char, datagram_access):
4582 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4583 (deactivate_process): Mark defn as static, as well as decl.
4584 * lisp.h (create_process): Remove decl.
4585 * process.h (chan_process, Vprocess_alist): Remove decls.
4586
4587 * print.c: Make symbols static if they're not exported.
4588 (print_depth, new_backquote_output, being_printed, print_buffer):
4589 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4590 (print_interval, print_number_index, initial_stderr_stream):
4591 Now static.
4592 * lisp.h (Fprinc): Remove decl.
4593 (debug_output_compilation_hack): Mark as externally visible.
4594
4595 * sysdep.c (croak): Move decl from here to syssignal.h.
4596 * syssignal.h (croak): Put it here, so the API can be checked when
4597 'croak' is called from dissociate_if_controlling_tty.
4598
4599 * minibuf.c: Make symbols static if they're not exported.
4600 (minibuf_save_list, choose_minibuf_frame): Now static.
4601 * lisp.h (choose_minibuf_frame): Remove decl.
4602
4603 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4604
4605 * lread.c: Make symbols static if they're not exported.
4606 (read_objects, initial_obarray, oblookup_last_bucket_number):
4607 Now static.
4608 (make_symbol): Remove; unused.
4609 * lisp.h (initial_obarray, make_symbol): Remove decls.
4610
4611 * keyboard.c: Make symbols static if they're not exported.
4612 (single_kboard, recent_keys_index, total_keys, recent_keys):
4613 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4614 (this_single_command_key_start, echoing, last_auto_save):
4615 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4616 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4617 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4618 (Vlispy_mouse_stem, double_click_count):
4619 Now static.
4620 (force_auto_save_soon): Define only if SIGDANGER.
4621 (ignore_mouse_drag_p): Now static if
4622 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4623 (print_help): Remove; unused.
4624 (stop_character, last_timer_event): Mark as externally visible.
4625 * keyboard.h (ignore_mouse_drag_p): Declare only if
4626 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4627 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4628 * lisp.h (echoing): Remove decl.
4629 (force_auto_save_soon): Declare only if SIGDANGER.
4630 * xdisp.c (redisplay_window): Simplify code, to make it more
4631 obvious that ignore_mouse_drag_p is not accessed if !defined
4632 USE_GTK && !defined HAVE_NS.
4633
4634 * intervals.c: Make symbols static if they're not exported.
4635 (merge_properties_sticky, merge_interval_right, delete_interval):
4636 Now static.
4637 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4638
4639 * insdel.c: Make symbols static if they're not exported.
4640 However, leave prepare_to_modify_buffer alone. It's never
4641 called from outside this function, but that appears to be a bug.
4642 (combine_after_change_list, combine_after_change_buffer):
4643 (adjust_after_replace, signal_before_change): Now static.
4644 (adjust_after_replace_noundo): Remove; unused.
4645 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4646 (signal_before_change): Remove decls.
4647
4648 * indent.c (val_compute_motion, val_vmotion): Now static.
4649
4650 * image.c: Make symbols static if they're not exported.
4651 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4652 if USE_GTK.
4653 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4654 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4655
4656 * fringe.c (standard_bitmaps): Now static.
4657 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4658
4659 * frame.c: Make symbols static if they're not exported.
4660 (x_report_frame_params, make_terminal_frame): Now static.
4661 (get_frame_param): Now static, unless HAVE_NS.
4662 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4663 (x_get_resource_string): Remove; not used.
4664 * frame.h (make_terminal_frame, x_report_frame_params):
4665 (x_get_resource_string); Remove decls.
4666 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4667 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4668
4669 * font.c, fontset.c: Make symbols static if they're not exported.
4670 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4671 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4672 * font.c (font_close_object): Now static.
4673 * font.h (font_close_object): Remove.
4674 * fontset.c (FONTSET_OBJLIST): Remove.
4675 (free_realized_fontset) #if-0 the body, which does nothing.
4676 (face_suitable_for_char_p): #if-0, as it's never called.
4677 * fontset.h (face_suitable_for_char_p): Remove decl.
4678 * xfaces.c (face_at_string_position):
4679 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4680 since 0 is always ASCII.
4681
4682 * fns.c (weak_hash_tables): Now static.
4683
4684 * fileio.c: Make symbols static if they're not exported.
4685 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4686 (Vwrite_region_annotation_buffers): Now static.
4687
4688 * eval.c: Make symbols static if they're not exported.
4689 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4690 * lisp.h (backtrace_list): Remove decl.
4691
4692 * emacs.c: Make symbols static if they're not exported.
4693 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4694 (fatal_error_code, fatal_error_signal_hook, standard_args):
4695 Now static.
4696 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4697 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4698 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4699 * lisp.h (fatal_error_signal_hook): Remove decl.
4700 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4701
4702 * editfns.c: Move a (normally-unused) function to its only use.
4703 * editfns.c, lisp.h (get_operating_system_release): Remove.
4704 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4705 worth the hassle of breaking this out.
4706
4707 * xterm.c: Make symbols static if they're not exported.
4708 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4709 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4710 (x_destroy_window, x_delete_display):
4711 Now static.
4712 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4713 (x_mouse_leave): Remove; unused.
4714 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4715 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4716 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4717 Remove decls.
4718 (x_mouse_leave): Declare only if WINDOWSNT.
4719 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4720 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4721 USE_X_TOOLKIT.
4722
4723 * ftxfont.c: Make symbols static if they're not exported.
4724 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4725 HAVE_FREETYPE.
4726 * font.h (ftxfont_driver): Likewise.
4727
4728 * xfns.c: Make symbols static if they're not exported.
4729 (x_last_font_name, x_display_info_for_name):
4730 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4731 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4732 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4733 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4734 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4735 (last_show_tip_args): Now static.
4736 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4737 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4738 (x_screen_planes): Remove; unused.
4739 * dispextern.h (x_screen_planes): Remove decl.
4740
4741 * dispnew.c: Make symbols static if they're not exported.
4742 * dispextern.h (redraw_garbaged_frames, scrolling):
4743 (increment_row_positions): Remove.
4744 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4745 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4746 Now static.
4747 (redraw_garbaged_frames): Remove; unused.
4748
4749 * xfaces.c: Make symbols static if they're not exported.
4750 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4751 Remove decls.
4752 * xterm.h (defined_color): Remove decls.
4753 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4754 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4755 (menu_face_changed_default, defined_color, free_realized_face):
4756 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4757 (ascii_face_of_lisp_face): Remove; unused.
4758
4759 * xdisp.c: Make symbols static if they're not exported.
4760 * dispextern.h (scratch_glyph_row, window_box_edges):
4761 (glyph_to_pixel_coords, set_cursor_from_row):
4762 (get_next_display_element, set_iterator_to_next):
4763 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4764 (show_mouse_face): Remove decls
4765 * frame.h (message_buf_print): Likewise.
4766 * lisp.h (pop_message, set_message, check_point_in_composition):
4767 Likewise.
4768 * xterm.h (set_vertical_scroll_bar): Likewise.
4769 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4770 (message_buf_print, scratch_glyph_row, displayed_buffer):
4771 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4772 (get_next_display_element, show_mouse_face, window_box_edges):
4773 (frame_to_window_pixel_xy, check_point_in_composition):
4774 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4775 (glyph_to_pixel_coords): Remove; unused.
4776
4777 * dired.c (file_name_completion): Now static.
4778
4779 * dbusbind.c (xd_in_read_queued_messages): Now static.
4780
4781 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4782 * data.c (circular_list_error): Remove.
4783
4784 * commands.h (last_point_position, last_point_position_buffer):
4785 (last_point_position_window): Remove decls.
4786 * keyboard.c: Make these variables static.
4787
4788 * coding.h (coding, code_convert_region, encode_coding_gap):
4789 Remove decls.
4790 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4791 (iso_code_class, detect_coding, code_convert_region): Now static.
4792 (encode_coding_gap): Remove; unused.
4793
4794 * chartab.c (chartab_chars, chartab_bits): Now static.
4795
4796 * charset.h (charset_iso_8859_1): Remove decl.
4797 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4798 Now static.
4799
4800 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4801 * ccl.c (Vccl_program_table): Now static.
4802 (check_ccl_update): Remove; unused.
4803
4804 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4805 * category.h: ... from here.
4806 * category.c (check_category_table, set_category_set): Now static.
4807
4808 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4809 * lisp.h: Remove these decls.
4810
4811 * buffer.c (buffer_count): Remove unused var.
4812
4813 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4814 so that it's not optimized away.
4815 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4816 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4817 exported only to the debugger.
4818
4819 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4820 * atimer.h (run_all_atimers): Remove; not exported.
4821
4822 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4823 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4824 was inaccessible from Lisp.
4825 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4826 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4827
4828 alloc.c: Import and export fewer symbols, and remove unused items.
4829 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4830 is defined.
4831 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4832 it's not optimized away by whole-program optimization.
4833 (message_enable_multibyte, free_misc): Remove.
4834 (catchlist, handlerlist, mark_backtrace):
4835 Declare only if BYTE_MARK_STACK.
4836 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4837 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4838 (message_enable_multibyte): Remove decl.
4839 (free_misc, interval_free_list, float_block, float_block_index):
4840 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4841 (cons_free_list, last_marked_index):
4842 Now static.
4843 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4844 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4845 (mark_backtrace): Define only if BYTE_MARK_STACK.
4846 * xdisp.c (message_enable_multibyte): Now static.
4847
4848 Declare Lisp_Object Q* variables to be 'static' if not exported.
4849 This makes it easier for human readers (and static analyzers)
4850 to see whether these variables are used from other modules.
4851 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4852 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4853 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4854 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4855 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4856 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4857 * xmenu.c, xselect.c:
4858 Declare Q* vars static if they are not used in other modules.
4859 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4860 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4861 Remove decls of unexported vars.
4862 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4863
4864 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4865
4866 Make Emacs functions such as Fatom 'static' by default.
4867 This makes it easier for human readers (and static analyzers)
4868 to see whether these functions can be called from other modules.
4869 DEFUN now defines a static function. To make the function external
4870 so that it can be used in other C modules, use the new macro DEFUE.
4871 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4872 (Finit_image_library):
4873 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4874 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4875 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4876 Remove decls, since these functions are now static.
4877 (Funintern, Fget_internal_run_time): New decls, since these functions
4878 were already external.
4879
4880 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4881 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4882 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4883 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4884 * keyboard.c, keymap.c, lread.c:
4885 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4886 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4887 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4888 Mark functions with DEFUE instead of DEFUN,
4889 if they are used in other modules.
4890 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4891 decls for now-static functions.
4892 * buffer.h (Fdelete_overlay): Remove decl.
4893 * callproc.c (Fgetenv_internal): Mark as internal.
4894 * composite.c (Fremove_list_of_text_properties): Remove decl.
4895 (Fcomposition_get_gstring): New forward static decl.
4896 * composite.h (Fcomposite_get_gstring): Remove decl.
4897 * dired.c (Ffile_attributes): New forward static decl.
4898 * doc.c (Fdocumntation_property): New forward static decl.
4899 * eval.c (Ffetch_bytecode): New forward static decl.
4900 (Funintern): Remove extern decl; now in .h file where it belongs.
4901 * fileio.c (Fmake_symbolic_link): New forward static decl.
4902 * image.c (Finit_image_library): New forward static decl.
4903 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4904 * intervals.h (Fprevious_property_change):
4905 (Fremove_list_of_text_properties): Remove decls.
4906 * keyboard.c (Fthis_command_keys): Remove decl.
4907 (Fcommand_execute): New forward static decl.
4908 * keymap.c (Flookup_key): New forward static decl.
4909 (Fcopy_keymap): Now static.
4910 * keymap.h (Flookup_key): Remove decl.
4911 * process.c (Fget_process): New forward static decl.
4912 (Fprocess_datagram_address): Mark as internal.
4913 * syntax.c (Fsyntax_table_p): New forward static decl.
4914 (skip_chars): Remove duplicate decl.
4915 * textprop.c (Fprevious_property_change): New forward static decl.
4916 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4917 Now internal.
4918 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4919 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4920
4921 * editfns.c (Fformat): Remove unreachable code.
4922
4923 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4924
4925 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4926 change. (Bug#8496)
4927
4928 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4929
4930 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4931 when at ZV. (Bug#8487)
4932
4933 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4934
4935 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4936 (Bug#8437)
4937 * keyboard.c (parse_tool_bar_item): Likewise.
4938 * sound.c (sound_cleanup, alsa_close): Likewise.
4939 * termcap.c (tgetent): Likewise.
4940 * xfns.c (x_default_font_parameter): Likewise.
4941 * xsettings.c (read_and_apply_settings): Likewise.
4942
4943 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4944 (overrun_check_free): Protoize.
4945
4946 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4947
4948 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4949 since callers should never pass a negative size.
4950 Change the signature to match that of plain 'read' and 'write'; see
4951 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4952 * lisp.h: Update prototypes of emacs_write and emacs_read.
4953
4954 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4955
4956 * xdisp.c (redisplay_window): Don't try to determine the character
4957 position of the scroll margin if the window start point w->startp
4958 is outside the buffer's accessible region. (Bug#8468)
4959
4960 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4961
4962 Fix write-region and its subroutines for buffers > 2GB.
4963 * fileio.c (a_write, e_write): Modify declaration of arguments and
4964 local variables to support buffers larger than 2GB.
4965 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4966
4967 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4968 argument, local variables, and return value.
4969
4970 * lisp.h: Update prototypes of emacs_write and emacs_read.
4971
4972 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4973
4974 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4975
4976 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4977
4978 Fix more problems found by GCC 4.6.0's static checks.
4979
4980 * xdisp.c (vmessage): Use a better test for character truncation.
4981
4982 * charset.c (load_charset_map): <, not <=, for optimization,
4983 and to avoid potential problems with integer overflow.
4984 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4985 * casetab.c (set_identity, shuffle): Likewise.
4986 * editfns.c (Fformat): Likewise.
4987 * syntax.c (skip_chars): Likewise.
4988
4989 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4990 This also lets GCC 4.6.0 generate slightly better loop code.
4991
4992 * callint.c (Fcall_interactively): <, not <=, for optimization.
4993 (Fcall_interactively): Count the number of arguments produced,
4994 not the number of arguments given. This is simpler and lets GCC
4995 4.6.0 generate slightly better code.
4996
4997 * ftfont.c: Distingish more carefully between FcChar8 and char.
4998 The previous code passed unsigned char * to a functions like
4999 strlen and xstrcasecmp that expect char *, which does not
5000 conform to the C standard.
5001 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5002 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5003 char * when the C standard requires it.
5004
5005 * keyboard.c (read_char): Remove unused var.
5006
5007 * eval.c: Port to Windows vsnprintf (Bug#8435).
5008 Include <limits.h>.
5009 (SIZE_MAX): Define if the headers do not.
5010 (verror): Do not give up if vsnprintf returns a negative count.
5011 Instead, grow the buffer. This ports to Windows vsnprintf, which
5012 does not conform to C99. Problem reported by Eli Zaretskii.
5013 Also, simplify the allocation scheme, by avoiding the need for
5014 calling realloc, and removing the ALLOCATED variable.
5015
5016 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5017
5018 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5019 But keep the doprint source code for now, as we might revamp it
5020 and use it again (Bug#8435).
5021 * lisp.h (doprnt): Remove.
5022 * Makefile.in (base_obj): Remove doprnt.o.
5023 * deps.mk (doprnt.o): Remove.
5024
5025 error: Print 32- and 64-bit integers portably (Bug#8435).
5026 Without this change, on typical 64-bit hosts error ("...%d...", N)
5027 was used to print both 32- and 64-bit integers N, which relied on
5028 undefined behavior.
5029 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5030 New macro.
5031 * lisp.h (error, verror): Mark as printf-like functions.
5032 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5033 Report overflow in size calculations when allocating printf buffer.
5034 Do not truncate output string at its first null byte.
5035 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5036 Truncate the output at a character boundary, since vsnprintf does not
5037 do that.
5038 * charset.c (check_iso_charset_parameter): Convert internal
5039 character to string before calling 'error', since %c now has the
5040 printf meaning.
5041 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5042 overflow when computing char to be passed to 'error'. Do not
5043 pass Lisp_Object to 'error'; pass the integer instead.
5044 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5045 formatted with plain %d.
5046
5047 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5048
5049 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5050
5051 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5052
5053 * xterm.c (x_catch_errors): Remove duplicate declaration.
5054
5055 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5056
5057 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5058
5059 2011-04-10 Jim Meyering <meyering@redhat.com>
5060
5061 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5062 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5063 return ssize_t not "int", and use size_t as the buffer length.
5064 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5065 * gnutls.h: Update declarations.
5066 * process.c (read_process_output): Use ssize_t, to match.
5067 (send_process): Likewise.
5068
5069 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5070
5071 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5072
5073 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5074
5075 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5076 Use unsigned char, to match FcChar8 type definition.
5077
5078 * xterm.c (handle_one_xevent):
5079 * xmenu.c (create_and_show_popup_menu):
5080 * xselect.c (x_decline_selection_request)
5081 (x_reply_selection_request): Avoid type-punned deref of X events.
5082
5083 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5084
5085 Fix some uses of `int' instead of EMACS_INT.
5086 * search.c (string_match_1, fast_string_match)
5087 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5088 (scan_buffer, find_next_newline_no_quit)
5089 (find_before_next_newline, search_command, Freplace_match)
5090 (Fmatch_data): Make some `int' variables be EMACS_INT.
5091
5092 * xdisp.c (display_count_lines): 3rd argument and return value now
5093 EMACS_INT. All callers changed.
5094 (pint2hrstr): Last argument is now EMACS_INT.
5095
5096 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5097 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5098 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5099 (decode_coding_utf_16, decode_coding_emacs_mule)
5100 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5101 (decode_coding_ccl, decode_coding_charset)
5102 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5103 (decode_coding_iso_2022, decode_coding_emacs_mule)
5104 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5105 <char_offset, last_offset>: Declare EMACS_INT.
5106 (encode_coding_utf_8, encode_coding_utf_16)
5107 (encode_coding_emacs_mule, encode_invocation_designation)
5108 (encode_designation_at_bol, encode_coding_iso_2022)
5109 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5110 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5111 Declare EMACS_INT.
5112 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5113 (encode_invocation_designation): Last argument P_NCHARS is now
5114 EMACS_INT.
5115 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5116 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5117
5118 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5119 All users changed.
5120
5121 * ccl.c (Fccl_execute_on_string): Declare some variables
5122 EMACS_INT.
5123
5124 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5125
5126 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5127
5128 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5129
5130 * process.c (Fformat_network_address): Doc fix.
5131
5132 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5133
5134 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5135
5136 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5137
5138 * keyboard.c (read_char): Call Lisp function help-form-show,
5139 instead of using internal_with_output_to_temp_buffer.
5140 (Qhelp_form_show): New var.
5141 (syms_of_keyboard): Use DEFSYM macro.
5142
5143 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5144
5145 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5146
5147 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5148
5149 * process.c (Flist_processes): Remove to Lisp.
5150 (list_processes_1): Delete.
5151
5152 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5153
5154 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5155
5156 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5157
5158 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5159
5160 Fix more problems found by GCC 4.6.0's static checks.
5161
5162 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5163
5164 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5165
5166 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5167
5168 * xdisp.c (vmessage): Mark as a printf-like function.
5169
5170 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5171
5172 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5173
5174 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5175 printf-like functions.
5176 (tiff_load): Add casts to remove these marks before passing them
5177 to system-supplied API.
5178
5179 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5180
5181 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5182 This avoids several warnings with gcc -Wstrict-overflow.
5183 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5184 directly, rather than having caller test rule sign. This avoids
5185 some unnecessary tests.
5186 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5187 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5188 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5189
5190 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5191 (xfont_open): Avoid unnecessary tests.
5192
5193 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5194
5195 * composite.h, composite.c (composition_gstring_put_cache):
5196 Use EMACS_INT, not int, for length.
5197
5198 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5199 breaking out part of COMPOSITION_DECODE_RULE.
5200 (COMPOSITION_DECODE_RULE): Use it.
5201 * composite.c (get_composition_id): Remove unused local vars,
5202 by using the new macro.
5203
5204 * textprop.c (set_text_properties_1): Change while to do-while,
5205 since the condition is always true at first.
5206
5207 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5208 (interval_deletion_adjustment): Return unsigned value.
5209 All uses changed.
5210
5211 * process.c (list_processes_1, create_pty, read_process_output):
5212 (exec_sentinel): Remove vars that were set but not used.
5213 (create_pty): Remove unnecessary "volatile"s.
5214 (Fnetwork_interface_info): Avoid possibility of int overflow.
5215 (read_process_output): Do adaptive read buffering even if carryover.
5216 (read_process_output): Simplify nbytes computation if buffered.
5217
5218 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5219
5220 * syntax.c (scan_words): Remove var that was set but not used.
5221 (update_syntax_table): Use unsigned instead of int.
5222
5223 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5224 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5225 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5226
5227 * print.c (print_error_message): Avoid int overflow.
5228
5229 * font.c (font_list_entities): Redo for clarity,
5230 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5231
5232 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5233 (font_score): Avoid potential overflow in diff calculation.
5234
5235 * fns.c (substring_both): Remove var that is set but not used.
5236 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5237
5238 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5239
5240 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5241 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5242 can always succeed if overflow has undefined behavior.
5243
5244 * search.c (boyer_moore, wordify): Remove vars set but not used.
5245 (wordify): Omit three unnecessary tests.
5246
5247 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5248 All callers changed. This avoids the need for an unused var.
5249
5250 * casefiddle.c (casify_region): Remove var that is set but not used.
5251
5252 * dired.c (file_name_completion): Remove var that is set but not used.
5253
5254 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5255
5256 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5257 (Finsert_file_contents): Remove unnecessary code checking fd.
5258
5259 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5260 Check for integer overflow on size calculations.
5261
5262 * buffer.c (Fprevious_overlay_change): Remove var that is set
5263 but not used.
5264
5265 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5266 Remove vars that are set but not used.
5267 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5268 (timer_check_2): Mark vars as initialized.
5269
5270 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5271
5272 * image.c (lookup_image): Remove var that is set but not used.
5273 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5274
5275 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5276 that are set but not used.
5277
5278 * xfns.c (make_invisible_cursor): Don't return garbage
5279 if XCreateBitmapFromData fails (Bug#8410).
5280
5281 * xselect.c (x_get_local_selection, x_handle_property_notify):
5282 Remove vars that are set but not used.
5283
5284 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5285 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5286
5287 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5288 Remove var that is set but not used.
5289 (scroll_bar_windows_size): Now size_t, not int.
5290 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5291 Check for overflow.
5292
5293 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5294 (map_tty_color) [!defined MSDOS]: Likewise.
5295
5296 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5297
5298 * coding.c: Remove vars that are set but not used.
5299 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5300 All callers changed.
5301 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5302 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5303 (decode_coding_charset): Remove vars that are set but not used.
5304
5305 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5306 that is set but not used.
5307
5308 * print.c (print_object): Remove var that is set but not used.
5309
5310 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5311 The gnulib version avoids calling malloc in the usual case,
5312 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5313 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5314 * filelock.c (current_lock_owner): Likewise.
5315 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5316 * sysdep.c: Include allocator.h, careadlinkat.h.
5317 (emacs_no_realloc_allocator): New static constant.
5318 (emacs_readlink): New function.
5319 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5320 ../lib/careadlinkat.h.
5321
5322 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5323
5324 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5325 first non-nil return value).
5326
5327 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5328
5329 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5330 if not defined (Bug#8403).
5331
5332 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * xdisp.c (display_count_lines): Remove parameter `start',
5335 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5336 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5337 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5338 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5339 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5340 and thereabouts. All callers changed.
5341 (get_per_char_metric): Remove parameter `f', unused since
5342 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5343
5344 2011-04-02 Jim Meyering <meyering@redhat.com>
5345
5346 do not dereference NULL upon failed strdup
5347 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5348 (ns_get_family): Likewise.
5349
5350 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5351
5352 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5353
5354 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5355
5356 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5357 later (Bug#8403).
5358
5359 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5360
5361 Add lexical binding.
5362
5363 * window.c (Ftemp_output_buffer_show): New fun.
5364 (Fsave_window_excursion):
5365 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5366
5367 * lread.c (lisp_file_lexically_bound_p): New function.
5368 (Fload): Bind Qlexical_binding.
5369 (readevalloop): Remove `evalfun' arg.
5370 Bind Qinternal_interpreter_environment.
5371 (Feval_buffer): Bind Qlexical_binding.
5372 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5373 Mark as dynamic.
5374 (syms_of_lread): Declare `lexical-binding'.
5375
5376 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5377
5378 * keyboard.c (eval_dyn): New fun.
5379 (menu_item_eval_property): Use it.
5380
5381 * image.c (parse_image_spec): Use Ffunctionp.
5382
5383 * fns.c (concat, mapcar1): Accept byte-code-functions.
5384
5385 * eval.c (Fsetq): Handle lexical vars.
5386 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5387 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5388 (FletX, Flet): Obey lexical binding.
5389 (Fcommandp): Handle closures.
5390 (Feval): New `lexical' arg.
5391 (eval_sub): New function extracted from Feval. Use it almost
5392 everywhere where Feval was used. Look up vars in lexical env.
5393 Handle closures.
5394 (Ffunctionp): Move from subr.el.
5395 (Ffuncall): Handle closures.
5396 (apply_lambda): Remove `eval_flags'.
5397 (funcall_lambda): Handle closures and new byte-code-functions.
5398 (Fspecial_variable_p): New function.
5399 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5400 but without exporting it to Lisp.
5401
5402 * doc.c (Fdocumentation, store_function_docstring):
5403 * data.c (Finteractive_form): Handle closures.
5404
5405 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5406 interactive spec.
5407
5408 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5409 New byte-codes.
5410 (exec_byte_code): New function extracted from Fbyte_code to handle new
5411 calling convention for byte-code-functions. Add new byte-codes.
5412
5413 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5414
5415 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5416
5417 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5418
5419 * xdisp.c (redisplay_internal): Fix prototype.
5420
5421 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5422
5423 * xdisp.c (SCROLL_LIMIT): New macro.
5424 (try_scrolling): Use it when setting scroll_limit.
5425 Limit scrolling to 100 screen lines.
5426 (redisplay_window): Even when falling back on "recentering",
5427 position point in the window according to scroll-conservatively,
5428 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5429
5430 (try_scrolling): When point is above the window, allow searching
5431 as far as scroll_max, or one screenful, to compute vertical
5432 distance from PT to the scroll margin position. This prevents
5433 try_scrolling from unnecessarily failing when
5434 scroll-conservatively is set to a value slightly larger than the
5435 window height. Clean up the case of PT below the margin at bottom
5436 of window: scroll_max can no longer be INT_MAX. When aggressive
5437 scrolling is in use, don't let point enter the opposite scroll
5438 margin as result of the scroll.
5439 (syms_of_xdisp) <scroll-conservatively>: Document the
5440 threshold of 100 lines for never-recentering scrolling.
5441
5442 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5443
5444 * dispextern.h (move_it_by_lines):
5445 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5446 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5447 (message_log_check_duplicate): Remove parameters `prev_bol' and
5448 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5449 (redisplay_internal): Remove parameter `preserve_echo_area',
5450 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5451
5452 * indent.c (Fvertical_motion):
5453 * window.c (window_scroll_pixel_based, Frecenter):
5454 Don't pass `need_y_p' to `move_it_by_lines'.
5455
5456 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5457
5458 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5459 steal a few bits to be more compact.
5460 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5461 Remove unneeded casts.
5462
5463 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5464
5465 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5466
5467 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5468 binding" message (bug#7967).
5469
5470 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5471
5472 Fix more problems found by GCC 4.6.0's static checks.
5473
5474 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5475 Remove unused local var.
5476
5477 * editfns.c (Fmessage_box): Remove unused local var.
5478
5479 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5480 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5481 Omit unused local vars.
5482 * window.c (shrink_windows): Omit unused local var.
5483 * menu.c (digest_single_submenu): Omit unused local var.
5484 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5485 Omit unused local var.
5486
5487 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5488 Don't assume string length fits in int.
5489 (keyremap_step, read_key_sequence): Use size_t for sizes.
5490 (read_key_sequence): Don't check last_real_key_start redundantly.
5491
5492 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5493 instead of alloca (Bug#8344).
5494
5495 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5496 (Fbacktrace_frame): Don't assume nframes fits in int.
5497
5498 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5499
5500 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5501 concerns.
5502
5503 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5504
5505 * cm.c (calccost): Turn while-do into do-while, for clarity.
5506
5507 * keyboard.c (syms_of_keyboard): Use the same style as later
5508 in this function when indexing through an array. This also
5509 works around GCC bug 48267.
5510
5511 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5512
5513 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5514
5515 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5516 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5517
5518 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5519 This avoids undefined behavior on integer overflow, and is a bit
5520 more convenient anyway since it is compared to a size_t variable.
5521
5522 Variadic C functions now count arguments with size_t, not int.
5523 This avoids an unnecessary limitation on 64-bit machines, which
5524 caused (substring ...) to crash on large vectors (Bug#8344).
5525 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5526 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5527 All variadic functions and their callers changed accordingly.
5528 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5529 * data.c (arith_driver, float_arith_driver): Likewise.
5530 * editfns.c (general_insert_function): Likewise.
5531 * eval.c (struct backtrace.nargs, interactive_p)
5532 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5533 (funcall_lambda, mark_backtrace): Likewise.
5534 * fns.c (concat): Likewise.
5535 * frame.c (x_set_frame_parameters): Likewise.
5536 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5537 0 if not found, not -1. All callers changed.
5538
5539 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5540 (stack_copy_size): Now size_t, not int.
5541 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5542
5543 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5544
5545 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5546 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5547 All callers changed.
5548
5549 * lisp.h (multibyte_char_to_unibyte):
5550 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5551 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5552 * character.h (CHAR_TO_BYTE8):
5553 * cmds.c (internal_self_insert):
5554 * editfns.c (general_insert_function):
5555 * keymap.c (push_key_description):
5556 * search.c (Freplace_match):
5557 * xdisp.c (message_dolog, set_message_1): All callers changed.
5558
5559 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5560
5561 * keyboard.c (safe_run_hook_funcall): New function.
5562 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5563 don't set the hook to nil, but remove the offending function instead.
5564 (Qcommand_hook_internal): Remove, unused.
5565 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5566 Vcommand_hook_internal.
5567
5568 * eval.c (enum run_hooks_condition): Remove.
5569 (funcall_nil, funcall_not): New functions.
5570 (run_hook_with_args): Call each function through a `funcall' argument.
5571 Remove `cond' argument, now redundant.
5572 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5573 (Frun_hook_with_args_until_failure): Adjust accordingly.
5574 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5575
5576 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5577
5578 * dispextern.h (string_buffer_position): Remove declaration.
5579
5580 * print.c (strout): Remove parameter `multibyte', unused since
5581 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5582
5583 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5584 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5585 All callers changed.
5586
5587 * w32.c (_wsa_errlist): Use braces for struct initializers.
5588
5589 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5590 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5591 All callers changed.
5592 (string_buffer_position): Likewise. Also, make static (it's never
5593 used outside xdisp.c).
5594 (cursor_row_p): Remove parameter `w', unused since
5595 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5596 (decode_mode_spec): Remove parameter `precision', introduced during
5597 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5598 All callers changed.
5599
5600 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5601
5602 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5603
5604 2011-03-27 Anders Lindgren <andlind@gmail.com>
5605
5606 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5607 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5608 (ns_update_auto_hide_menu_bar): New functions.
5609 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5610 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5611 ns_constrain_all_frames.
5612 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5613 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5614
5615 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5616
5617 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5618
5619 2011-03-27 Glenn Morris <rgm@gnu.org>
5620
5621 * syssignal.h: Replace RETSIGTYPE with void.
5622 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5623 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5624 Replace SIGTYPE with void everywhere.
5625 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5626 * s/template.h (SIGTYPE): Remove commented out definition.
5627
5628 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5629
5630 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5631 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5632
5633 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5634
5635 * w32.c (read_unc_volume): Use parameter `henum', instead of
5636 global variable `wget_enum_handle'.
5637
5638 * keymap.c (describe_vector): Remove parameters `indices' and
5639 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5640 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5641
5642 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5643
5644 * keyboard.c (timer_check): Remove parameter `do_it_now',
5645 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5646 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5647 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5648
5649 * keyboard.c (read_char):
5650 * w32menu.c (w32_menu_display_help):
5651 * xmenu.c (show_help_event, menu_help_callback):
5652 Adjust calls to `show_help_echo'.
5653
5654 * gtkutil.c (xg_maybe_add_timer):
5655 * keyboard.c (readable_events):
5656 * process.c (wait_reading_process_output):
5657 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5658
5659 * insdel.c (adjust_markers_gap_motion):
5660 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5661 (gap_left, gap_right): Don't call it.
5662
5663 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5664
5665 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5666 incurred during fontification.
5667
5668 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5669
5670 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5671 (DEFVAR_PER_BUFFER): Don't pass it.
5672
5673 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5674 (scrolling_window): Don't pass it.
5675
5676 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5677
5678 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5679
5680 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5681 and `suffix'.
5682 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5683 of variables specific to SELinux and computation of `encoded_absname'.
5684
5685 * image.c (XPutPixel): Remove unused variable `height'.
5686
5687 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5688
5689 * unexw32.c (get_section_info): Remove unused variable `section'.
5690
5691 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5692 (system_process_attributes): Remove unused variable `sess'.
5693 (sys_read): Remove unused variable `err'.
5694
5695 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5696 (w32_wnd_proc): Remove unused variable `isdead'.
5697 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5698 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5699 (x_create_tip_frame): Remove unused variable `tem'.
5700
5701 * w32inevt.c (w32_console_read_socket):
5702 Remove unused variable `no_events'.
5703
5704 * w32term.c (x_draw_composite_glyph_string_foreground):
5705 Remove unused variable `width'.
5706
5707 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5708
5709 * w32term.c (x_set_glyph_string_clipping):
5710 Don't pass uninitialized region to CombineRgn.
5711
5712 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5713
5714 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5715 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5716 (Fx_close_connection): Remove unused variable `i'.
5717
5718 * w32font.c (w32font_draw): Return number of glyphs.
5719 (w32font_open_internal): Remove unused variable `i'.
5720 (w32font_driver): Add missing initializer.
5721
5722 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5723 (fill_in_menu): Remove unused variable `items_added'.
5724
5725 * w32term.c (last_mouse_press_frame): Remove static global variable.
5726 (w32_clip_to_row): Remove unused variable `f'.
5727 (x_delete_terminal): Remove unused variable `i'.
5728
5729 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5730 (NOTHING): Remove unused static global variable.
5731 (uniscribe_check_otf): Remove unused variable `table'.
5732 (uniscribe_font_driver): Add missing initializers.
5733
5734 2011-03-23 Julien Danjou <julien@danjou.info>
5735
5736 * term.c (Fsuspend_tty, Fresume_tty):
5737 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5738 * window.c (temp_output_buffer_show):
5739 * insdel.c (signal_before_change):
5740 * frame.c (Fhandle_switch_frame):
5741 * fileio.c (Fdo_auto_save):
5742 * emacs.c (Fkill_emacs):
5743 * editfns.c (save_excursion_restore):
5744 * cmds.c (internal_self_insert):
5745 * callint.c (Fcall_interactively):
5746 * buffer.c (Fkill_all_local_variables):
5747 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5748 Use Frun_hooks.
5749 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5750 unconditionnaly since it does the check itself.
5751
5752 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5753
5754 Fix more problems found by GCC 4.5.2's static checks.
5755
5756 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5757 the first time through the loop, since we know p0 < p1 then.
5758 This also avoids a gcc -Wstrict-overflow warning.
5759
5760 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5761 leading to a memory leak, possible in functions like
5762 load_charset_map_from_file that can allocate an unbounded number
5763 of objects (Bug#8318).
5764
5765 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5766 that could (at least in theory) be that large.
5767
5768 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5769 This is less likely to overflow, and avoids undefined behavior if
5770 overflow does occur. All callers changed. Use strtoul to scan
5771 for the unsigned long integer.
5772 (pint2hrstr): Simplify and tune code slightly.
5773 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5774
5775 * scroll.c (do_scrolling): Work around GCC bug 48228.
5776 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5777
5778 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5779 This also avoids a warning with gcc -Wstrict-overflow.
5780 (validate_x_resource_name): Simplify count usage.
5781 This also avoids a warning with gcc -Wstrict-overflow.
5782
5783 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5784 fail (Bug#8306).
5785
5786 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5787
5788 * process.c (Fmake_network_process): Use socklen_t, not int,
5789 where POSIX says socklen_t is required in portable programs.
5790 This fixes a porting bug on hosts like 64-bit HP-UX, where
5791 socklen_t is wider than int (Bug#8277).
5792 (Fmake_network_process, server_accept_connection):
5793 (wait_reading_process_output, read_process_output):
5794 Likewise.
5795
5796 * process.c: Rename or move locals to avoid shadowing.
5797 (list_processes_1, Fmake_network_process):
5798 (read_process_output_error_handler, exec_sentinel_error_handler):
5799 Rename or move locals.
5800 (Fmake_network_process): Define label "retry_connect" only if needed.
5801 (Fnetwork_interface_info): Fix pointer signedness.
5802 (process_send_signal): Add cast to avoid pointer signedness problem.
5803 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5804 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5805
5806 Make tparam.h and terminfo.c consistent.
5807 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5808 Include tparam.h instead, since it declares them.
5809 * cm.h (PC): Remove extern decl; tparam.h now does this.
5810 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5811 * terminfo.c: Include tparam.h, to check interfaces.
5812 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5813 (tparam): Adjust signature to match interface in tparam.h;
5814 this removes some undefined behavior. Check that outstring and len
5815 are zero, which they always are with Emacs.
5816 * tparam.h (PC, BC, UP): New extern decls.
5817
5818 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5819 (xftfont_open): Rename locals to avoid shadowing.
5820
5821 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5822 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5823 (OTF_TAG_SYM): Omit macro if not needed.
5824 (ftfont_list): Remove unused local.
5825 (get_adstyle_property, ftfont_pattern_entity):
5826 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5827 Rename locals to avoid shadowing.
5828
5829 * xfont.c (xfont_list_family): Mark var as initialized.
5830
5831 * xml.c (make_dom): Now static.
5832
5833 * composite.c (composition_compute_stop_pos): Rename local to
5834 avoid shadowing.
5835 (composition_reseat_it): Remove unused locals.
5836 (find_automatic_composition, composition_adjust_point): Likewise.
5837 (composition_update_it): Mark var as initialized.
5838 (find_automatic_composition): Mark vars as initialized,
5839 with a FIXME (Bug#8290).
5840
5841 character.h: Rename locals to avoid shadowing.
5842 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5843 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5844 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5845 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5846 to avoid shadowing.
5847
5848 * textprop.c (property_change_between_p): Remove; unused.
5849
5850 * intervals.c (interval_start_pos): Now static.
5851
5852 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5853
5854 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5855 Rename locals to avoid shadowing.
5856
5857 * sound.c (wav_play, au_play, Fplay_sound_internal):
5858 Fix pointer signedness.
5859 (alsa_choose_format): Remove unused local var.
5860 (wav_play): Initialize a variable to 0, to prevent undefined
5861 behavior (Bug#8278).
5862
5863 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5864
5865 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5866
5867 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5868 clobbering (Bug#8298).
5869 * sysdep.c (sys_subshell): Likewise.
5870 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5871
5872 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5873 This should get cleaned up, so that child_setup has the
5874 same signature on all platforms.
5875
5876 * callproc.c (call_process_cleanup): Now static.
5877 (relocate_fd): Rename locals to avoid shadowing.
5878
5879 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5880
5881 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5882 not to be necessary, and produces flickering.
5883
5884 2011-03-20 Glenn Morris <rgm@gnu.org>
5885
5886 * config.in: Remove file.
5887
5888 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5889
5890 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5891 are now in src/globals.h.
5892 (syms_of_minibuf): Remove spurious & from previous change.
5893
5894 2011-03-20 Leo <sdl.web@gmail.com>
5895
5896 * minibuf.c (completing-read-function): New variable.
5897 (completing-read-default): Rename from completing-read.
5898 (completing-read): Call completing-read-function.
5899
5900 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5901
5902 * xfaces.c (Fx_load_color_file):
5903 Read color file from absolute filename (bug#8250).
5904
5905 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5906
5907 * makefile.w32-in: Update dependencies.
5908
5909 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5910
5911 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5912
5913 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5914
5915 Fix more problems found by GCC 4.5.2's static checks.
5916
5917 * process.c (make_serial_process_unwind, send_process_trap):
5918 (sigchld_handler): Now static.
5919
5920 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5921 That way, the code declares only the vars that it needs.
5922 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5923 * s/cygwin.h (PTY_ITERATION): Likewise.
5924 * s/darwin.h (PTY_ITERATION): Likewise.
5925 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5926
5927 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5928 * process.c (allocate_pty): Don't declare stb unless it's needed.
5929
5930 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5931 (CONSTANTLIM): Remove; unused.
5932 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5933 Define only if needed.
5934
5935 * unexelf.c (unexec): Name an expression,
5936 to avoid gcc -Wbad-function-cast warning.
5937 Use a different way to cause a compilation error if anyone uses
5938 n rather than nn, a way that does not involve shadowing.
5939 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5940
5941 * deps.mk (unexalpha.o): Remove; unused.
5942
5943 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5944 * unexec.h: New file.
5945 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5946 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5947 Depend on unexec.h.
5948 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5949 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5950 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5951 Change as necessary to match prototype in unexec.h.
5952
5953 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5954 shadowing.
5955 (back_comment, skip_chars): Mark vars as initialized.
5956
5957 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5958 Rename locals to avoid shadowing.
5959
5960 * lread.c (read1): Rewrite so as not to use empty "else".
5961 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5962
5963 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5964
5965 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5966 warning when compiling print.c.
5967
5968 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5969 instead of using an uninitialized var.
5970 (font_sort_entities): Mark var as initialized.
5971
5972 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5973
5974 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5975 pointers to constants.
5976 (font_parse_fcname): Remove unused vars.
5977 (font_delete_unmatched): Now static.
5978 (font_get_spec): Remove; unused.
5979 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5980 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5981 Rename or move locals to avoid shadowing.
5982
5983 * fns.c (require_nesting_list, require_unwind): Now static.
5984 (Ffillarray): Rename locals to avoid shadowing.
5985
5986 * floatfns.c (domain_error2): Define only if needed.
5987 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5988
5989 * alloc.c (mark_backtrace): Move decl from here ...
5990 * lisp.h: ... to here, so that it can be checked.
5991
5992 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5993 (Fdefvar): Rewrite so as not to use empty "else".
5994 (lisp_indirect_variable): Name an expression,
5995 to avoid gcc -Wbad-function-cast warning.
5996 (Fdefvar): Rename locals to avoid shadowing.
5997
5998 * callint.c (quotify_arg, quotify_args): Now static.
5999 (Fcall_interactively): Rename locals to avoid shadowing.
6000 Use const pointer when appropriate.
6001
6002 * lisp.h (get_system_name, get_operating_system_release):
6003 Move decls here, to check interfaces.
6004 * process.c (get_operating_system_release): Move decl to lisp.h.
6005 * xrdb.c (get_system_name): Likewise.
6006 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6007 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6008 some of which prompt warnings from gcc -Wbad-function-cast.
6009 (Fformat_time_string, Fencode_time, Finsert_char):
6010 (Ftranslate_region_internal, Fformat):
6011 Rename or remove local vars to avoid shadowing.
6012 (Ftranslate_region_internal): Mark var as initialized.
6013
6014 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6015 avoid shadowing.
6016
6017 * lisp.h (eassert): Check that the argument compiles, even if
6018 ENABLE_CHECKING is not defined.
6019
6020 * data.c (Findirect_variable): Name an expression, to avoid
6021 gcc -Wbad-function-cast warning.
6022 (default_value, arithcompare, arith_driver, arith_error): Now static.
6023 (store_symval_forwarding): Rename local to avoid shadowing.
6024 (Fmake_variable_buffer_local, Fmake_local_variable):
6025 Mark variables as initialized.
6026 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6027
6028 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6029 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6030 Rename locals to avoid shadowing.
6031 (mark_stack): Move local variables into the #ifdef region where
6032 they're used.
6033 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6034 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6035 needed otherwise.
6036 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6037 (GC_STRING_CHARS): Remove; not used.
6038 (Fmemory_limit): Cast sbrk's returned value to char *.
6039
6040 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6041 avoids undefined behavior in theory.
6042
6043 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6044
6045 Use functions, not macros, for up- and down-casing (Bug#8254).
6046 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6047 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6048 to use the following functions instead of these macros.
6049 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6050 EMACS_INT, since callers assume the returned value fits in int.
6051 (upcase1): Likewise, for UPCASE_TABLE.
6052 (uppercasep, lowercasep, upcase): New static inline functions.
6053 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6054 the race-condition problem in the old DOWNCASE.
6055
6056 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6057 Rename locals to avoid shadowing.
6058 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6059 (regex_compile, re_search_2, re_match_2_internal):
6060 Remove unused local vars.
6061 (FREE_VAR): Rewrite so as not to use empty "else",
6062 which gcc can warn about.
6063 (regex_compile, re_match_2_internal): Mark locals as initialized.
6064 (RETALLOC_IF): Define only if needed.
6065 (WORDCHAR_P): Likewise. This one is never needed, but is used
6066 only in a comment talking about a compiler bug, so put inside
6067 the #if 0 of that comment.
6068 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6069 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6070 Remove; unused.
6071
6072 * search.c (boyer_moore): Rename locals to avoid shadowing.
6073 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6074 (PREV_CHAR_BOUNDARY): Likewise.
6075
6076 * search.c (simple_search): Remove unused var.
6077
6078 * dired.c (compile_pattern): Move decl from here ...
6079 * lisp.h: ... to here, so that it can be checked.
6080 (struct re_registers): New forward decl.
6081
6082 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6083
6084 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6085 All uses changed.
6086 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6087 Rename locals to avoid shadowing.
6088 (Fvertical_motion): Mark locals as initialized.
6089
6090 * casefiddle.c (casify_object, casify_region): Now static.
6091 (casify_region): Mark local as initialized.
6092
6093 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6094
6095 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6096 New macros, so that the caller can use some names other than
6097 gcpro1, gcpro2, etc.
6098 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6099 of the new macros.
6100 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6101 argument, for consistency with GCPRO2_VAR, etc: it is now the
6102 prefix of the variable, not the variable itself. All uses
6103 changed.
6104 * dired.c (directory_files_internal, file_name_completion):
6105 Rename locals to avoid shadowing.
6106
6107 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6108 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6109 dired.c's scmp function, had undefined behavior.
6110 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6111 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6112 * buffer.h: ... to here, because these macros use current_buffer,
6113 and the new implementation with inline functions needs to have
6114 current_buffer in scope now, rather than later when the macros
6115 are used.
6116 (downcase, upcase1): New static inline functions.
6117 (DOWNCASE, UPCASE1): Reimplement using these functions.
6118 This avoids undefined behavior in expressions like
6119 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6120 from race conditions in accessing the global variables
6121 case_temp1 and case_temp2.
6122 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6123 * lisp.h (case_temp1, case_temp2): Remove their decls.
6124 * character.h (ASCII_CHAR_P): Move from here ...
6125 * lisp.h: ... to here, so that the inline functions mentioned
6126 above can use them.
6127
6128 * dired.c (directory_files_internal_unwind): Now static.
6129
6130 * fileio.c (file_name_as_directory, directory_file_name):
6131 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6132 Now static.
6133 (file_name_as_directory): Use const pointers when appropriate.
6134 (Fexpand_file_name): Likewise. In particular, newdir might
6135 point at constant storage, so make it a const pointer.
6136 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6137 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6138 signedness issues.
6139 (Fset_file_times, Finsert_file_contents, auto_save_error):
6140 Rename locals to avoid shadowing.
6141
6142 * minibuf.c (choose_minibuf_frame_1): Now static.
6143 (Ftry_completion, Fall_completions): Rename or remove locals
6144 to avoid shadowing.
6145
6146 * marker.c (bytepos_to_charpos): Remove; unused.
6147
6148 * lisp.h (verify_bytepos, count_markers): New decls,
6149 so that gcc does not warn that these functions aren't declared.
6150
6151 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6152 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6153 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6154 (copy_text): Remove unused local var.
6155
6156 * filelock.c (within_one_second): Now static.
6157 (lock_file_1): Rename local to avoid shadowing.
6158
6159 * buffer.c (fix_overlays_before): Mark locals as initialized.
6160 (fix_start_end_in_overlays): Likewise. This function should be
6161 simplified by using pointers-to-pointers, but that's a different
6162 matter.
6163 (switch_to_buffer_1): Now static.
6164 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6165 (report_overlay_modification): Rename locals to avoid shadowing.
6166
6167 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6168 Fix pointer signedness issue.
6169 (sys_subshell): Mark local as volatile if checking for lint,
6170 to suppress a gcc -Wclobbered warning that does not seem to be right.
6171 (MAXPATHLEN): Define only if needed.
6172
6173 * process.c (serial_open, serial_configure): Move decls from here ...
6174 * systty.h: ... to here, so that they can be checked.
6175
6176 * fns.c (get_random, seed_random): Move extern decls from here ...
6177 * lisp.h: ... to here, so that they can be checked.
6178
6179 * sysdep.c (reset_io): Now static.
6180 (wait_for_termination_signal): Remove; unused.
6181
6182 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6183 (copy_keymap_item, append_key, push_text_char_description):
6184 Now static.
6185 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6186 (DENSE_TABLE_SIZE): Remove; unused.
6187 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6188 (describe_map_tree):
6189 Rename locals to avoid shadowing.
6190
6191 * keyboard.c: Declare functions static if they are not used elsewhere.
6192 (echo_char, echo_dash, cmd_error, top_level_2):
6193 (poll_for_input, handle_async_input): Now static.
6194 (read_char, kbd_buffer_get_event, make_lispy_position):
6195 (make_lispy_event, make_lispy_movement, apply_modifiers):
6196 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6197 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6198 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6199 (read_key_sequence, read_char): Mark locals as initialized.
6200 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6201
6202 * keyboard.h (make_ctrl_char): New decl.
6203 (mark_kboards): Move decl here ...
6204 * alloc.c (mark_kboards): ... from here.
6205
6206 * lisp.h (force_auto_save_soon): New decl.
6207
6208 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6209 (DEFINE_DUMMY_FUNCTION): New macro.
6210 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6211 Use it.
6212 (main): Add casts to avoid warnings
6213 if GCC considers string literals to be constants.
6214
6215 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6216
6217 * dbusbind.c: Pointer signedness fixes.
6218 (xd_signature, xd_append_arg, xd_initialize):
6219 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6220 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6221 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6222 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6223
6224 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6225 if GCC considers string literals to be constants.
6226 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6227
6228 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6229
6230 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6231 (print_preprocess, print_object): New macro to fix last change.
6232
6233 * print.c (print_preprocess): Don't forget font objects.
6234
6235 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6236
6237 * emacs.c (USAGE3): Doc fixes.
6238
6239 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6240
6241 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6242 structure.
6243
6244 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6245
6246 * lisp.h (VWindow_system, Qfile_name_history):
6247 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6248 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6249 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6250
6251 * w32select.c: Don't #include "keyboard.h".
6252 (run_protected): Add extern declaration for waiting_for_input.
6253
6254 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6255 * w32console.c (detect_input_pending, read_input_pending)
6256 (encode_terminal_code):
6257 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6258 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6259 (w32_system_caret_y, Qfile_name_history):
6260 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6261 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6262 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6263 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6264 * w32proc.c (Qlocal, report_file_error):
6265 * w32term.c (Vwindow_system, updating_frame):
6266 * w32uniscribe.c (initialized, uniscribe_font_driver):
6267 Remove unneeded extern declarations.
6268
6269 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6270
6271 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6272
6273 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6274
6275 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6276 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6277 These macros can no longer be used for assignment.
6278
6279 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6280 Assign struct members directly, instead of using BUF_BEGV etc.
6281 (record_buffer_markers, fetch_buffer_markers): New functions for
6282 recording and fetching special buffer markers.
6283 (set_buffer_internal_1, set_buffer_temp): Use them.
6284
6285 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6286
6287 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6288
6289 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6290 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6291
6292 * xdisp.c (hscroll_window_tree):
6293 (reconsider_clip_changes): Use PT instead of BUF_PT.
6294
6295 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6296
6297 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6298 $(EMACS_ROOT)/lib/intprops.h.
6299
6300 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6301
6302 Fix more problems found by GCC 4.5.2's static checks.
6303
6304 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6305 to unsigned char * to avoid compiler diagnostic.
6306 (xg_free_frame_widgets): Make it clear that a local variable is
6307 needed only if USE_GTK_TOOLTIP.
6308 (gdk_window_get_screen): Make it clear that this macro is needed
6309 only if USE_GTK_TOOLTIP.
6310 (int_gtk_range_get_value): New function, which avoids a diagnostic
6311 from gcc -Wbad-function-cast.
6312 (xg_set_toolkit_scroll_bar_thumb): Use it.
6313 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6314 diagnostic from gcc -Wbad-function-cast.
6315 (get_utf8_string, xg_get_file_with_chooser):
6316 Rename locals to avoid shadowing.
6317 (create_dialog): Move locals to avoid shadowing.
6318
6319 * xgselect.c (xg_select): Remove unused var.
6320
6321 * image.c (four_corners_best): Mark locals as initialized.
6322 (gif_load): Initialize transparent_p to zero (Bug#8238).
6323 Mark another local as initialized.
6324 (my_png_error, my_error_exit): Mark with NO_RETURN.
6325
6326 * image.c (clear_image_cache): Now static.
6327 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6328 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6329 (x_edge_detection): Remove unnecessary cast that
6330 gcc -Wbad-function-cast diagnoses.
6331 (gif_load): Fix pointer signedness.
6332 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6333 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6334
6335 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6336
6337 Improve quality of tests for time stamp overflow.
6338 For example, without this patch (encode-time 0 0 0 1 1
6339 1152921504606846976) returns the obviously-bogus value (-948597
6340 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6341 reports time overflow. See
6342 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6343 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6344 * editfns.c: Include limits.h and intprops.h.
6345 (TIME_T_MIN, TIME_T_MAX): New macros.
6346 (time_overflow): Move earlier, to before first use.
6347 (hi_time, lo_time): New functions, for an accurate test for
6348 out-of-range times.
6349 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6350 (Fget_internal_run_time): Don't assume time_t fits in int.
6351 (make_time): Use list2 instead of Fcons twice.
6352 (Fdecode_time): More accurate test for out-of-range times.
6353 (check_tm_member): New function.
6354 (Fencode_time): Use it, to test for out-of-range times.
6355 (lisp_time_argument): Don't rely on undefined left-shift and
6356 right-shift behavior when checking for time stamp overflow.
6357
6358 * editfns.c (time_overflow): New function, refactoring common code.
6359 (Fformat_time_string, Fdecode_time, Fencode_time):
6360 (Fcurrent_time_string): Use it.
6361
6362 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6363 * dired.c (make_time): Move to ...
6364 * editfns.c (make_time): ... here.
6365 * systime.h: Note the move.
6366
6367 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6368
6369 * fringe.c (update_window_fringes): Remove unused variables.
6370
6371 * unexmacosx.c (copy_data_segment): Also copy __got section.
6372 (Bug#8223)
6373
6374 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6375
6376 * termcap.c [MSDOS]: Include "msdos.h".
6377 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6378 Constify `char *' arguments and their references according to
6379 prototypes in tparam.h.
6380
6381 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6382
6383 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6384 Adapt all references accordingly.
6385
6386 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6387
6388 2011-03-11 Tom Tromey <tromey@redhat.com>
6389
6390 * buffer.c (syms_of_buffer): Remove obsolete comment.
6391
6392 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6393
6394 * termhooks.h (encode_terminal_code): Declare prototype.
6395
6396 * msdos.c (encode_terminal_code): Don't declare prototype.
6397
6398 * term.c (encode_terminal_code): Now external again, used by
6399 w32console.c and msdos.c.
6400
6401 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6402 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6403
6404 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6405
6406 Fix some minor problems found by GCC 4.5.2's static checks.
6407
6408 * fringe.c (update_window_fringes): Mark locals as initialized
6409 (Bug#8227).
6410 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6411
6412 * alloc.c (mark_fringe_data): Move decl from here ...
6413 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6414 to check its interface.
6415 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6416
6417 * fontset.c (free_realized_fontset): Now static.
6418 (Fset_fontset_font): Rename local to avoid shadowing.
6419 (fontset_font): Mark local as initialized.
6420 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6421
6422 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6423
6424 * xselect.c (x_disown_buffer_selections): Remove; not used.
6425 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6426 (x_own_selection, Fx_disown_selection_internal): Rename locals
6427 to avoid shadowing.
6428 (x_handle_dnd_message): Remove local to avoid shadowing.
6429
6430 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6431 so that the caller can use some name other than gcpro1.
6432 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6433 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6434 (Fx_backspace_delete_keys_p):
6435 Use them to avoid shadowing, and rename vars to avoid shadowing.
6436 (x_decode_color, x_set_name, x_window): Now static.
6437 (Fx_create_frame): Add braces to silence GCC warning.
6438 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6439 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6440 Remove unused locals.
6441 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6442 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6443 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6444 macros.
6445
6446 * xterm.h (x_mouse_leave): New decl.
6447
6448 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6449 Remove unused functions.
6450 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6451 (x_calc_absolute_position): Now static.
6452 (XTread_socket): Don't define label "out" unless it's used.
6453 Don't declare local "event" unless it's used.
6454 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6455 unless they are used.
6456 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6457 (x_fatal_error_signal): Remove; not used.
6458 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6459 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6460 (x_error_catcher, x_connection_closed, x_error_handler):
6461 (x_error_quitter, xembed_send_message, x_iconify_frame):
6462 (my_log_handler): Rename locals to avoid shadowing.
6463 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6464 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6465
6466 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6467 Rename or move locals to avoid shadowing.
6468 (tty_defined_color, merge_face_heights): Now static.
6469 (free_realized_faces_for_fontset): Remove; not used.
6470 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6471 does not deduce is never used uninitialized.
6472 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6473 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6474
6475 * terminal.c (store_terminal_param): Now static.
6476
6477 * xmenu.c (menu_highlight_callback): Now static.
6478 (set_frame_menubar): Remove unused local.
6479 (xmenu_show): Rename parameter to avoid shadowing.
6480 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6481 since they might point to immutable storage.
6482 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6483 since it's unused otherwise.
6484
6485 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6486 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6487 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6488 avoids a gcc -Wuninitialized diagnostic.
6489 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6490 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6491 does not deduce are never used uninitialized.
6492
6493 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6494
6495 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6496 * window.c (window_loop, size_window):
6497 (run_window_configuration_change_hook, enlarge_window): Likewise.
6498
6499 * window.c (display_buffer): Now static.
6500 (size_window): Mark variables that gcc -Wuninitialized
6501 does not deduce are never used uninitialized.
6502 * window.h (check_all_windows): New decl, to forestall
6503 gcc -Wmissing-prototypes diagnostic.
6504 * dispextern.h (bidi_dump_cached_states): Likewise.
6505
6506 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6507 shadowing.
6508 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6509 Include <limits.h>.
6510 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6511 and to avoid gcc -Wuninitialized warning.
6512 (load_charset_map): Mark variables that gcc -Wuninitialized
6513 does not deduce are never used uninitialized.
6514 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6515
6516 * coding.c (coding_set_source, coding_set_destination):
6517 Use "else { /* comment */ }" rather than "else /* comment */;"
6518 for clarity, and to avoid gcc -Wempty-body warning.
6519 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6520 a block, when the outer 'i' will do.
6521 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6522 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6523 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6524 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6525 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6526 Rename locals to avoid shadowing.
6527 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6528 * coding.c (emacs_mule_char, encode_invocation_designation):
6529 Now static, since they're not used elsewhere.
6530 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6531 (decode_coding_object, encode_coding_object, detect_coding_system):
6532 (decode_coding_emacs_mule): Mark variables that gcc
6533 -Wuninitialized does not deduce are never used uninitialized.
6534 (detect_coding_iso_2022): Initialize a local variable that might
6535 be used uninitialized. Leave a FIXME because it's not clear that
6536 this initialization is needed. (Bug#8211)
6537 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6538 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6539 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6540 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6541 Remove unused macros.
6542
6543 * category.c (hash_get_category_set): Remove unused local var.
6544 (copy_category_table): Now static, since it's not used elsewhere.
6545 * character.c (string_count_byte8): Likewise.
6546
6547 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6548 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6549
6550 * chartab.c (copy_sub_char_table): Now static, since it's not used
6551 elsewhere.
6552 (sub_char_table_ref_and_range, char_table_ref_and_range):
6553 Rename locals to avoid shadowing.
6554 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6555
6556 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6557 (BIDI_BOB): Remove unused macro.
6558
6559 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6560 deduce are never used uninitialized.
6561 * term.c (encode_terminal_code): Likewise.
6562
6563 * term.c (encode_terminal_code): Now static. Remove unused local.
6564
6565 * tparam.h: New file.
6566 * term.c, tparam.h: Include it.
6567 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6568 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6569 Move these decls to tparam.h, and make them agree with what
6570 is actually in tparam.c. The previous trick of using incompatible
6571 decls in different modules does not conform to the C standard.
6572 All callers of tparam changed to use tparam's actual API.
6573 * tparam.c (tparam1, tparam, tgoto):
6574 Use const pointers where appropriate.
6575
6576 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6577 * cm.h (struct cm): Likewise.
6578 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6579 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6580 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6581 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6582 (turn_on_face, init_tty): Likewise.
6583 * termchar.h (struct tty_display_info): Likewise.
6584
6585 * term.c (term_mouse_position): Rename local to avoid shadowing.
6586
6587 * alloc.c (mark_ttys): Move decl from here ...
6588 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6589
6590 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6591
6592 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6593
6594 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * search.c (compile_pattern_1): Remove argument regp, unused since
6597 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6598 (compile_pattern): Don't pass it.
6599
6600 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6601
6602 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6603 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6604 for ! HAVE_GTK3.
6605 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6606
6607 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6608
6609 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6610 gdk_window_get_screen, gdk_window_get_geometry,
6611 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6612 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6613 (xg_get_pixbuf_from_pixmap): New function.
6614 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6615 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6616 Call xg_get_pixbuf_from_pixmap instead of
6617 gdk_pixbuf_get_from_drawable.
6618 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6619 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6620 (xg_check_special_colors): Use GtkStyleContext and its functions
6621 for HAVE_GTK3.
6622 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6623 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6624 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6625 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6626 Call gtk_widget_get_preferred_size.
6627 (xg_frame_resized): gdk_window_get_geometry only takes 5
6628 parameters.
6629 (xg_win_to_widget, xg_event_is_for_menubar):
6630 Call gdk_x11_window_lookup_for_display.
6631 (xg_set_widget_bg): New function.
6632 (delete_cb): New function.
6633 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6634 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6635 (xg_set_background_color): Call xg_set_widget_bg.
6636 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6637 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6638 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6639 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6640 if ! HAVE_GTK3.
6641 (update_frame_tool_bar): Call gtk_widget_hide.
6642 (xg_initialize): Use GDK_KEY_g.
6643
6644 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6645 if ! HAVE_GTK3
6646 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6647
6648 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6649 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6650 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6651
6652 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6653
6654 * w32xfns.c (select_palette): Check success of RealizePalette against
6655 GDI_ERROR, not zero.
6656
6657 See ChangeLog.11 for earlier changes.
6658
6659 ;; Local Variables:
6660 ;; coding: utf-8
6661 ;; End:
6662
6663 Copyright (C) 2011 Free Software Foundation, Inc.
6664
6665 This file is part of GNU Emacs.
6666
6667 GNU Emacs is free software: you can redistribute it and/or modify
6668 it under the terms of the GNU General Public License as published by
6669 the Free Software Foundation, either version 3 of the License, or
6670 (at your option) any later version.
6671
6672 GNU Emacs is distributed in the hope that it will be useful,
6673 but WITHOUT ANY WARRANTY; without even the implied warranty of
6674 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6675 GNU General Public License for more details.
6676
6677 You should have received a copy of the GNU General Public License
6678 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.