]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Bump version to 24.2
[gnu-emacs] / src / ChangeLog
1 2012-08-15 Chong Yidong <cyd@gnu.org>
2
3 * Version 24.2 released.
4
5 2012-08-14 Glenn Morris <rgm@gnu.org>
6
7 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
8
9 2012-08-14 Ulrich Mueller <ulm@gentoo.org>
10
11 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
12 (Bug#11712).
13
14 2012-08-13 Eli Zaretskii <eliz@gnu.org>
15
16 * w32menu.c: Include w32heap.h.
17 (add_menu_item): If the call to AppendMenuW (via
18 unicode_append_menu) fails, disable Unicode menus only if we are
19 running on Windows 9X/Me.
20
21 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
22
23 * window.c (Fdelete_other_windows_internal)
24 (Fdelete_window_internal): Don't access frame's mouse highlight
25 info of the initial frame. (Bug#11677)
26
27 2012-08-12 Jan Djärv <jan.h.d@swipnet.se>
28
29 * nsterm.m (ns_read_socket): Return early if there is a modal
30 window (Bug#12043).
31
32 * nsmenu.m (Popdown_data): New struct.
33 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
34 free Popdown_data.
35 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
36 (initWithContentRect): Make imgView and contentView non-static
37 and autorelease them. Also autorelease img and matrix (Bug#12005).
38 (dealloc): Remove (Bug#12005).
39
40 * nsterm.m (keyDown:): Interpret flags without left/right bits
41 as the left key (Bug#11670).
42
43 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
44
45 2012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
46
47 * unexmacosx.c (copy_data_segment): Copy initialized data in
48 statically linked libraries from input file rather than memory.
49
50 2012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
51
52 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
53 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
54 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
55
56 2012-07-19 Chong Yidong <cyd@gnu.org>
57
58 * window.c (Fwindow_absolute_pixel_edges)
59 (Fdelete_other_windows_internal): Signal an error if the window is
60 on a dead frame (Bug#11984).
61
62 2012-07-14 Eli Zaretskii <eliz@gnu.org>
63
64 Remove FILE_SYSTEM_CASE.
65 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
66
67 * fileio.c (FILE_SYSTEM_CASE): Don't define.
68 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
69 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
70 call-process-region passes it through expand-file-name.
71
72 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
73
74 2012-07-12 Andreas Schwab <schwab@linux-m68k.org>
75
76 Fix crash when creating indirect buffer (Bug#11917)
77 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
78 Don't handle unbound variables specially if non-zero.
79 (Fbuffer_local_variables): Pass zero.
80 (clone_per_buffer_values): Pass non-zero.
81
82 2012-06-28 Andreas Schwab <schwab@linux-m68k.org>
83
84 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
85 to make the loop interruptible.
86
87 2012-06-26 Andreas Schwab <schwab@linux-m68k.org>
88
89 * gnutls.c (emacs_gnutls_handshake): Only retry if
90 GNUTLS_E_INTERRUPTED.
91
92 2012-06-23 Eli Zaretskii <eliz@gnu.org>
93
94 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
95 in the logic of incrementing and decrementing the value of
96 use_relocatable_buffers.
97
98 2012-06-21 Glenn Morris <rgm@gnu.org>
99
100 * charset.c (init_charset): Make lack of etc/charsets fatal.
101
102 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
103
104 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
105 referenced (Bug#11583).
106
107 2012-06-01 Chong Yidong <cyd@gnu.org>
108
109 * Version 24.1 released.
110
111 2012-05-30 Eli Zaretskii <eliz@gnu.org>
112
113 * xdisp.c (handle_stop): Detect whether we have overlay strings
114 loaded by testing it->current.overlay_string_index to be
115 non-negative, instead of checking whether n_overlay_strings is
116 positive. (Bug#11587)
117
118 2012-05-30 Chong Yidong <cyd@gnu.org>
119
120 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
121
122 * doc.c (Fsubstitute_command_keys): Doc fix.
123
124 2012-05-29 Eli Zaretskii <eliz@gnu.org>
125
126 * search.c (search_buffer): Remove calls to
127 r_alloc_inhibit_buffer_relocation, as it is now called by
128 maybe_unify_char, which was the cause of relocation of buffer text
129 in bug#11519.
130
131 2012-05-23 Eli Zaretskii <eliz@gnu.org>
132
133 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
134 for the duration of call to load_charset, to avoid problems with
135 callers of maybe_unify_char that access buffer text through C
136 pointers.
137
138 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
139 decrement the inhibition flag, instead of just setting or
140 resetting it.
141
142 2012-05-24 Ken Brown <kbrown@cornell.edu>
143
144 * callproc.c (Fcall_process): Restore a line that was accidentally
145 commented out in the 2011-02-13 change (bug#11547).
146
147 2012-05-23 Eli Zaretskii <eliz@gnu.org>
148
149 * lisp.h [REL_ALLOC]: Add prototypes for external functions
150 defined on ralloc.c.
151
152 * buffer.c [REL_ALLOC]: Remove prototypes of
153 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
154 they are now on lisp.h.
155
156 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
157
158 * search.c (search_buffer): Use it to inhibit relocation of buffer
159 text while re_search_2 is doing its job, because re_search_2 is
160 passed C pointers to buffer text. (Bug#11519)
161
162 2012-05-21 Eli Zaretskii <eliz@gnu.org>
163
164 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
165 Update value to 24.
166
167 2012-05-19 Eli Zaretskii <eliz@gnu.org>
168
169 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
170 state after an additional call to move_it_in_display_line_to, keep
171 the values of it->max_ascent and it->max_descent found for the
172 entire line.
173 (pos_visible_p): Revert the comparison against bottom_y to what it
174 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
175 (Bug#11464)
176
177 2012-05-15 Eli Zaretskii <eliz@gnu.org>
178
179 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
180
181 2012-05-13 Eli Zaretskii <eliz@gnu.org>
182
183 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
184 already have overlays loaded.
185 (handle_single_display_spec): Before returning without displaying
186 fringe bitmap, synchronize the bidi iterator with the main display
187 iterator, by calling iterate_out_of_display_property.
188 (iterate_out_of_display_property): Detect buffer iteration by
189 testing that it->string is a Lisp string.
190 (get_next_display_element): When the current object is exhausted,
191 and there's something on it->stack, call set_iterator_to_next to
192 proceed with what's on the stack, instead of returning zero.
193 (set_iterator_to_next): If called at the end of a Lisp string,
194 proceed to consider_string_end without incrementing string
195 position. Don't increment display vector index past the end of
196 the display vector. (Bug#11417)
197 (pos_visible_p): Don't report a position visible when move_it_to
198 stopped at the last line of window, which happens to be scanned
199 backwards by the bidi iteration. (Bug#11464)
200
201 2012-05-11 Eli Zaretskii <eliz@gnu.org>
202
203 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
204 and right-margin display specs even if the spec is invalid or we
205 are on a TTY, and thus unable to display on the fringes. That's
206 because the text with the property will not be displayed anyway,
207 so we need to signal to the caller that this is a "replacing"
208 display spec. This fixes display when the spec is invalid or we
209 are on a TTY.
210
211 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
212
213 * unexaix.c (make_hdr): Fix typo in prototype.
214 This bug broke the build on AIX. Problem reported by Gilles Pion.
215
216 2012-05-05 Eli Zaretskii <eliz@gnu.org>
217
218 * w32proc.c (new_child): Force Windows to reserve only 64KB of
219 stack for each reader_thread, instead of defaulting to 8MB
220 determined by the linker. This avoids failures in creating
221 subprocesses on Windows 7, see the discussion in this thread:
222 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
223
224 2012-05-02 Jim Meyering <meyering@redhat.com>
225
226 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
227
228 2012-04-29 Eli Zaretskii <eliz@gnu.org>
229
230 * xdisp.c (pos_visible_p): If already at a newline from the
231 display string before the 'while' loop, don't walk back the glyphs
232 from it3.glyph_row. Solves assertion violation when the display
233 string begins with a newline (egg.el). (Bug#11367)
234
235 2012-04-24 Chong Yidong <cyd@gnu.org>
236
237 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
238
239 2012-04-23 Eli Zaretskii <eliz@gnu.org>
240
241 * xdisp.c (pos_visible_p): If the window start position is beyond
242 ZV, start the display from buffer beginning. Prevents assertion
243 violation in init_iterator when the minibuffer window is scrolled
244 via the scroll bar.
245
246 * window.c (window_scroll_pixel_based): Likewise.
247
248 2012-04-23 Chong Yidong <cyd@gnu.org>
249
250 * keymap.c (where_is_internal): Doc fix (Bug#10872).
251
252 2012-04-20 Glenn Morris <rgm@gnu.org>
253
254 * fileio.c (Fcopy_file, Fset_file_selinux_context):
255 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
256
257 2012-04-20 Eli Zaretskii <eliz@gnu.org>
258
259 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
260 overrun array limits of glyph row's used[] array. (Bug#11288)
261
262 2012-04-20 Chong Yidong <cyd@gnu.org>
263
264 * process.c (wait_reading_process_output): If EIO occurs on a pty,
265 set the status to "failed" and ensure that sentinel is run.
266
267 2012-04-18 Glenn Morris <rgm@gnu.org>
268
269 * process.c (Fset_process_inherit_coding_system_flag)
270 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
271 (Fmake_network_process, Fmake_serial_process): Doc fix.
272
273 2012-04-17 Eli Zaretskii <eliz@gnu.org>
274
275 * xdisp.c (string_buffer_position_lim): Limit starting position to
276 BEGV.
277 (set_cursor_from_row): If called for a mode-line or header-line
278 row, return zero immediately.
279 (try_cursor_movement): If inside continuation line, don't back up
280 farther than the first row after the header line, if any. Don't
281 consider the header-line row as "partially visible", even if
282 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
283
284 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
285
286 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
287
288 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
289
290 * process.c (make_process):
291 * process.h: Add integer `gnutls_handshakes_tried' member to
292 process struct.
293
294 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
295 Add convenience `GNUTLS_LOG2i' macro.
296
297 * gnutls.c (gnutls_log_function2i): Convenience log function.
298 (emacs_gnutls_read): Use new log functions,
299 `gnutls_handshakes_tried' process member, and
300 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
301 attempts per process (connection).
302
303 2012-04-09 Eli Zaretskii <eliz@gnu.org>
304
305 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
306 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
307
308 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
309
310 * nsterm.m (constrainFrameRect): Always constrain when there is only
311 one screen (Bug#10962).
312
313 2012-04-06 Eli Zaretskii <eliz@gnu.org>
314
315 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
316 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
317 about subtle differences between FETCH_CHAR* and STRING_CHAR*
318 macros related to unification of CJK characters. For the details,
319 see the discussion following the message here:
320 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
321
322 2012-04-04 Chong Yidong <cyd@gnu.org>
323
324 * keyboard.c (Vdelayed_warnings_list): Doc fix.
325
326 2012-04-01 Eli Zaretskii <eliz@gnu.org>
327
328 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
329 instead of alloca. (Bug#11138)
330
331 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
332
333 * w32menu.c (is_simple_dialog): Properly check lisp types.
334 (Bug#11141)
335
336 2012-03-31 Eli Zaretskii <eliz@gnu.org>
337
338 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
339 position we get to after a call to move_it_to fails the
340 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
341 only if we wind up in a string from display property. (Bug#11063)
342
343 * window.c (Fdelete_other_windows_internal): Invalidate the row
344 and column information about mouse highlight, so that redisplay
345 restores it after reallocating the glyph matrices. (Bug#7464)
346
347 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
348 string comes from a `display' text property, use the buffer
349 position of that property as if we actually saw that position in
350 the row's glyphs.
351 (move_it_by_lines): Remove the assertion that
352 "it->current_x == 0 && it->hpos == 0" which can be legitimately
353 violated when there's a before-string at the beginning of a line.
354 (Bug#11063)
355
356 2012-03-30 Eli Zaretskii <eliz@gnu.org>
357
358 * xdisp.c (append_space_for_newline): If the default face was
359 remapped, use the remapped face for the appended newline.
360 (extend_face_to_end_of_line): Use the remapped default face for
361 extending the face to the end of the line.
362 (display_line): Call extend_face_to_end_of_line when the default
363 face was remapped. (Bug#11068)
364
365 2012-03-29 Eli Zaretskii <eliz@gnu.org>
366
367 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
368
369 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
370
371 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
372
373 2012-03-27 Glenn Morris <rgm@gnu.org>
374
375 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
376 Doc fixes.
377
378 2012-03-26 Kenichi Handa <handa@m17n.org>
379
380 * dispextern.h (struct glyph): Fix previous change. Change the
381 bit length of glyphless.ch to 25 (Bug#11082).
382
383 2012-03-26 Chong Yidong <cyd@gnu.org>
384
385 * keyboard.c (Vselection_inhibit_update_commands): New variable.
386 (command_loop_1): Use it; inhibit selection update for
387 handle-select-window too (Bug#8996).
388
389 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
390
391 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
392
393 2012-03-25 Kenichi Handa <handa@m17n.org>
394
395 * dispextern.h (struct glyph): Change the bit length of
396 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
397
398 2012-03-24 Eli Zaretskii <eliz@gnu.org>
399
400 * s/ms-w32.h (tzname): Include time.h before redirecting to
401 _tzname. Fixes the MSVC build. (Bug#9960)
402
403 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
404
405 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
406 characters.
407
408 * xterm.c (XTread_socket): Only modify handling_signal if
409 !SYNC_INPUT. (Bug#11080)
410
411 2012-03-23 Eli Zaretskii <eliz@gnu.org>
412
413 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
414 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
415 when fetching a multibyte character consumes more bytes than
416 CHAR_BYTES returns, due to unification of CJK characters in
417 string_char. (Bug#11073)
418
419 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
420
421 * process.c (wait_reading_process_output): Handle pty disconnect
422 by refraining from sending oneself a SIGCHLD (bug#10933).
423
424 2012-03-22 Chong Yidong <cyd@gnu.org>
425
426 * dispextern.h (struct it): New member string_from_prefix_prop_p.
427
428 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
429 Mark string as coming from a prefix property.
430 (handle_face_prop): Use default face for prefix strings (Bug#4281).
431 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
432
433 2012-03-21 Chong Yidong <cyd@gnu.org>
434
435 * xfaces.c (Vface_remapping_alist): Doc fix.
436
437 2012-03-20 Eli Zaretskii <eliz@gnu.org>
438
439 * w32proc.c (Fw32_set_console_codepage)
440 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
441 Doc fixes.
442
443 2012-03-20 Chong Yidong <cyd@gnu.org>
444
445 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
446 to reflect default non-nil value of redisplay-dont-pause.
447
448 2012-03-19 Kenichi Handa <handa@m17n.org>
449
450 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
451 it fit in a valid range (Bug#11003).
452
453 2012-03-18 Eli Zaretskii <eliz@gnu.org>
454
455 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
456 that is not from display property, accept the row as a "cursor
457 row" if one of the string's character has a non-nil `cursor'
458 property. Fixes cursor positioning when there are newlines in
459 overlay strings, e.g. in icomplete.el. (Bug#11035)
460
461 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
462
463 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
464
465 2012-03-12 Chong Yidong <cyd@gnu.org>
466
467 * eval.c (inhibit_lisp_code): Rename from
468 inhibit_window_configuration_change_hook; move from window.c.
469
470 * xfns.c (unwind_create_frame_1, Fx_create_frame):
471 * window.c (run_window_configuration_change_hook)
472 (syms_of_window): Callers changed.
473
474 2012-03-11 Chong Yidong <cyd@gnu.org>
475
476 * keymap.c (Fkey_description): Doc fix (Bug#9700).
477
478 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
479
480 2012-03-10 Chong Yidong <cyd@gnu.org>
481
482 * frame.c (other_visible_frames): Don't assume the selected frame
483 is visible (Bug#10955).
484
485 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
486
487 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
488
489 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
490
491 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
492 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
493 zero (Bug#10954).
494
495 2012-03-03 Glenn Morris <rgm@gnu.org>
496
497 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
498
499 2012-03-02 Eli Zaretskii <eliz@gnu.org>
500
501 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
502 position past the first glyph_row that ends at ZV. (Bug#10902)
503 (redisplay_window, next_element_from_string): Fix typos in
504 comments.
505 (redisplay_window): Pass to move_it_vertically the margin in
506 pixels, not in screen lines.
507
508 2012-03-02 Glenn Morris <rgm@gnu.org>
509
510 * buffer.c (buffer-list-update-hook): Doc fix.
511
512 2012-02-29 Eli Zaretskii <eliz@gnu.org>
513
514 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
515 push_it before setting up the iterator for the first overlay
516 string, even if we have an empty string loaded.
517 (next_overlay_string): If there's an empty string on the iterator
518 stack, pop the stack. (Bug#10903)
519
520 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
521
522 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
523 Suggested by Stefan Monnier in
524 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
525 * alloc.c (widen_to_Lisp_Object): New static function.
526 (mark_memory): Also mark Lisp_Objects by fetching pointer words
527 and widening them to Lisp_Objects. This would work even if
528 USE_LSB_TAG is defined and wide integers are used, which might
529 happen in a future version of Emacs.
530
531 2012-02-25 Chong Yidong <cyd@gnu.org>
532
533 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
534 Doc fix.
535
536 * xselect.c (Fx_selection_exists_p): Doc fix.
537 (x_clipboard_manager_save_all): Print an informative message
538 before saving to clipboard manager.
539
540 2012-02-24 Chong Yidong <cyd@gnu.org>
541
542 * keyboard.c (process_special_events): Handle all X selection
543 requests in kbd_buffer, not just the next one (Bug#8869).
544
545 2012-02-23 Chong Yidong <cyd@gnu.org>
546
547 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
548 call when setting menu-bar-lines and tool-bar-lines parameters.
549 (unwind_create_frame_1): New helper function.
550
551 * window.c (inhibit_window_configuration_change_hook): New var.
552 (run_window_configuration_change_hook): Obey it.
553 (syms_of_window): Initialize it.
554
555 2012-02-22 Chong Yidong <cyd@gnu.org>
556
557 * xterm.c (x_draw_image_relief): Add missing type check for
558 Vtool_bar_button_margin (Bug#10743).
559
560 2012-02-21 Chong Yidong <cyd@gnu.org>
561
562 * fileio.c (Vfile_name_handler_alist): Doc fix.
563
564 * buffer.c (Fget_file_buffer): Protect against invalid file
565 handler return value.
566
567 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
568
569 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
570 when computing $valmask.
571
572 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
573 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
574 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
575 It's useless in that case, and it can cause problems on hosts
576 that allocate halves of EMACS_INT values separately.
577 Reported by Dan Horák. Diagnosed by Andreas Schwab in
578 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
579 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
580 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
581 it avoids undefined behavior on hosts where shifting right by more
582 than the word width has undefined behavior.
583
584 2012-02-19 Chong Yidong <cyd@gnu.org>
585
586 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
587 (Funhandled_file_name_directory, Ffile_name_as_directory)
588 (Fdirectory_file_name, Fexpand_file_name)
589 (Fsubstitute_in_file_name): Protect against invalid file handler
590 return values (Bug#10845).
591
592 2012-02-18 Eli Zaretskii <eliz@gnu.org>
593
594 * .gdbinit (pitx): Fix incorrect references to fields of the
595 iterator stack.
596
597 2012-02-17 Chong Yidong <cyd@gnu.org>
598
599 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
600
601 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
602
603 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
604 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
605
606 2012-02-15 Chong Yidong <cyd@gnu.org>
607
608 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
609 marked as special. Also, starting docstrings with * is obsolete.
610
611 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
612
613 * gnutls.c (emacs_gnutls_write): Fix last change.
614
615 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
616
617 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
618 send_process.
619
620 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
621
622 * keymap.c (Fsingle_key_description): Handle char ranges.
623
624 2012-02-12 Chong Yidong <cyd@gnu.org>
625
626 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
627 as that creates a dangerous corner case.
628
629 * window.c (Fdelete_window_internal): Invalidate the mouse
630 highlight (Bug#9904).
631
632 2012-02-12 Glenn Morris <rgm@gnu.org>
633
634 * xselect.c (Fx_own_selection_internal)
635 (Fx_get_selection_internal, Fx_disown_selection_internal)
636 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
637 * nsselect.m (Fx_own_selection_internal)
638 (Fx_disown_selection_internal, Fx_selection_exists_p)
639 (Fx_selection_owner_p, Fx_get_selection_internal):
640 Sync docs and argument specs with the xselect.c versions.
641
642 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
643
644 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
645
646 2012-02-11 Eli Zaretskii <eliz@gnu.org>
647
648 * w32select.c (Fx_selection_exists_p): Sync doc string and
649 argument list with xselect.c. (Bug#10783)
650
651 * w16select.c (Fx_selection_exists_p): Sync doc string and
652 argument list with xselect.c. (Bug#10783)
653
654 2012-02-10 Glenn Morris <rgm@gnu.org>
655
656 * fns.c (Fsecure_hash): Doc fix.
657
658 2012-02-09 Kenichi Handa <handa@m17n.org>
659
660 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
661
662 2012-02-07 Chong Yidong <cyd@gnu.org>
663
664 * buffer.c (Fbuffer_local_variables)
665 (buffer_lisp_local_variables): Handle unbound vars correctly;
666 don't let Qunbound leak into Lisp.
667
668 2012-02-07 Glenn Morris <rgm@gnu.org>
669
670 * image.c (Fimagemagick_types): Doc fix.
671
672 * image.c (imagemagick-render-type): Change it from a lisp object
673 to an integer. Move the doc here from the lisp manual.
674 Treat all values not equal to 0 the same.
675
676 2012-02-06 Chong Yidong <cyd@gnu.org>
677
678 * doc.c (store_function_docstring): Avoid applying docstring of
679 alias to base function (Bug#2603).
680
681 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
682
683 * .gdbinit (pp1, pv1): Remove redundant defines.
684 (pr): Use pp.
685
686 2012-02-04 Chong Yidong <cyd@gnu.org>
687
688 * nsterm.m: Declare a global (Bug#10694).
689
690 2012-02-04 Eli Zaretskii <eliz@gnu.org>
691
692 * w32.c (get_emacs_configuration_options):
693 Include --enable-checking, if specified, in the return value.
694
695 2012-02-04 Martin Rudalics <rudalics@gmx.at>
696
697 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
698 after rounding frame sizes. (Bug#9723)
699
700 2012-02-04 Eli Zaretskii <eliz@gnu.org>
701
702 * keyboard.c (adjust_point_for_property): Don't position point
703 before BEGV. (Bug#10696)
704
705 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
706
707 Handle overflow when computing char display width (Bug#9496).
708 * character.c (char_width): Return EMACS_INT, not int.
709 (char_width, c_string_width): Check for overflow when
710 computing the width; this is possible now that individual
711 characters can have unbounded width. Problem introduced
712 by merge from Emacs 23 on 2012-01-19.
713
714 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
715
716 * dbusbind.c (Fdbus_register_method): Mention the return value
717 :ignore in the docstring.
718
719 2012-02-02 Glenn Morris <rgm@gnu.org>
720
721 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
722
723 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
724 Unconditionally set to t. (Bug#10673)
725 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
726 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
727 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
728
729 2012-02-02 Kenichi Handa <handa@m17n.org>
730
731 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
732 0, do not call append_composite_glyph.
733
734 2012-02-02 Kenichi Handa <handa@m17n.org>
735
736 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
737 NULL (Bug#6988).
738 (x_produce_glyphs): If the component of a composition is a null
739 string, set it->pixel_width to 1 to avoid zero-width glyph.
740
741 2012-02-01 Eli Zaretskii <eliz@gnu.org>
742
743 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
744 first 2 arguments are identical. This makes inserting large
745 output from a subprocess an order of magnitude faster on
746 MS-Windows, where all sbrk'ed memory is always contiguous.
747
748 2012-01-31 Glenn Morris <rgm@gnu.org>
749
750 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
751 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
752 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
753
754 2012-01-29 Glenn Morris <rgm@gnu.org>
755
756 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
757
758 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
759
760 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
761
762 2012-01-28 Chong Yidong <cyd@gnu.org>
763
764 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
765
766 2012-01-26 Chong Yidong <cyd@gnu.org>
767
768 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
769
770 * search.c (Fsearch_forward, Fsearch_backward): Document negative
771 repeat counts (Bug#10507).
772
773 2012-01-26 Glenn Morris <rgm@gnu.org>
774
775 * lread.c (syms_of_lread): Doc fix.
776
777 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
778
779 * coding.c (encode_designation_at_bol): Change return value to
780 EMACS_INT.
781
782 2012-01-25 Chong Yidong <cyd@gnu.org>
783
784 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
785
786 2012-01-21 Chong Yidong <cyd@gnu.org>
787
788 * floatfns.c (Fcopysign): Make the second argument non-optional,
789 since nil is not allowed anyway.
790
791 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
792
793 * process.c (read_process_output): Use p instead of XPROCESS (proc).
794 (send_process): Likewise.
795
796 2012-01-19 Martin Rudalics <rudalics@gmx.at>
797
798 * window.c (save_window_save, Fcurrent_window_configuration)
799 (Vwindow_persistent_parameters): Do not use Qstate.
800 Rewrite doc-strings.
801
802 2012-01-19 Kenichi Handa <handa@m17n.org>
803
804 * character.c (char_width): New function.
805 (Fchar_width, c_string_width, lisp_string_width):
806 Use char_width (Bug#9496).
807
808 2012-01-16 Martin Rudalics <rudalics@gmx.at>
809
810 * window.c (Vwindow_persistent_parameters): New variable.
811 (Fset_window_configuration, save_window_save): Handle persistent
812 window parameters.
813
814 2012-01-14 Eli Zaretskii <eliz@gnu.org>
815
816 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
817 thrashing the stack of the thread. (Bug#9087)
818
819 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
820
821 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
822
823 2012-01-11 Eli Zaretskii <eliz@gnu.org>
824
825 * xdisp.c (rows_from_pos_range): Handle the case where the
826 highlight ends on a newline. (Bug#10464)
827 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
828 he end column for display of highlight that ends on a newline
829 before a R2L line.
830
831 2012-01-11 Glenn Morris <rgm@gnu.org>
832
833 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
834 from load-path also when installation-directory is nil. (Bug#10208)
835
836 2012-01-10 Glenn Morris <rgm@gnu.org>
837
838 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
839
840 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
841 Update template values to be closer to their typical values these days.
842
843 2012-01-09 Eli Zaretskii <eliz@gnu.org>
844
845 * xdisp.c (rows_from_pos_range): Accept additional argument
846 DISP_STRING, and accept any glyph in a row whose object is that
847 string as eligible for mouse highlight. Fixes mouse highlight of
848 display strings from overlays. (Bug#10464)
849
850 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
851
852 emacs: fix an auto-save permissions race condition (Bug#10400)
853 * fileio.c (auto_saving_dir_umask): New static var.
854 (Fmake_directory_internal): Use it.
855 (do_auto_save_make_dir): Set it, instead of invoking chmod after
856 creating the directory. The old code temporarily assigns
857 too-generous permissions to the directory.
858 (do_auto_save_eh): Clear it.
859 (Fdo_auto_save): Catch all errors, not just file errors, so
860 that the var is always cleared.
861
862 2012-01-07 Eli Zaretskii <eliz@gnu.org>
863
864 * search.c (scan_buffer): Pass character positions to
865 know_region_cache, not byte positions. (Bug#6540)
866
867 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
868
869 * w32.c (sys_rename): Report EXDEV when rename of a directory
870 fails because the target is on another logical disk. (Bug#10284)
871
872 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
873
874 * xterm.c (x_embed_request_focus): New function.
875
876 * xterm.h: Add prototype.
877
878 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
879
880 2012-01-05 Glenn Morris <rgm@gnu.org>
881
882 * emacs.c (emacs_copyright): Update short copyright year to 2012.
883
884 2012-01-01 Eli Zaretskii <eliz@gnu.org>
885
886 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
887 Load gnutls_transport_set_lowat only if GnuTLS version is below
888 2.11.1.
889 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
890 GnuTLS versions below 2.11.1.
891
892 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
893
894 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
895 to the doc string advising against its use for altering the way
896 windows are scrolled.
897
898 2011-12-28 Kenichi Handa <handa@m17n.org>
899
900 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
901 coding-system ASCII compatible only when it does not produce BOM
902 on encoding (Bug#10383).
903
904 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
905
906 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
907 can scroll.
908 (create_and_show_popup_menu): Always use menu_position_func for
909 Gtk3 (Bug#10361).
910
911 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
912
913 * callint.c (Fcall_interactively): Don't truncate prompt string.
914
915 2011-12-23 Eli Zaretskii <eliz@gnu.org>
916
917 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
918 property that ends at ZV, so that the bidi iteration could be
919 resumed from there (after widening). (Bug#10360)
920
921 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
922
923 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
924
925 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
926
927 * nsterm.m (x_free_frame_resources):
928 Release f->output_data.ns->miniimage.
929 (ns_index_color): Fix indentation. Do not retain
930 color_table->colors[i].
931
932 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
933 before returning.
934
935 * nsfns.m (x_set_background_color): Assign return value from
936 ns_index_color to face-background instead of NSColor*.
937 (ns_implicitly_set_icon_type): Fix indentation.
938 Change assignment in for loop to comparison.
939
940 * emacs.c (ns_pool): New variable.
941 (main): Assign ns_pool.
942 (Fkill_emacs): Call ns_release_autorelease_pool.
943
944 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
945 autorelease fdesc, release fdAttrs and tdict.
946 (ns_get_covering_families): Release charset.
947 (ns_findfonts): Release NSFontDescriptor created with new.
948 (ns_uni_to_glyphs): Fix indentation.
949 (setString): Release attrStr before assigning new value.
950
951 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
952
953 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
954 and NS_IMPL_COCOA.
955 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
956 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
957
958 2011-12-18 David Reitter <reitter@cmu.edu>
959
960 * nsterm.m (ns_term_init): Subscribe for notifications
961 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
962 to method trackingNotification in EmacsMenu.
963
964 * nsmenu.m (trackingMenu): New variable.
965 (trackingNotification): New method (from Aquamacs).
966 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
967 from Aquamacs (Bug#7030).
968
969 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
970
971 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
972 (symbol_to_nsstring): Fix indentation.
973 (ns_symbol_to_pb): New function.
974 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
975 (Fns_rotate_cut_buffers_internal): Remove.
976 (Fns_store_selection_internal): Rename from
977 Fns_store_cut_buffer_internal.
978 (ns_get_foreign_selection, Fx_own_selection_internal)
979 (Fx_disown_selection_internal, Fx_selection_exists_p)
980 (Fns_get_selection_internal, Fns_store_selection_internal):
981 Use ns_symbol_to_pb and check if return value is nil.
982 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
983 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
984 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
985 renamed to Sns_store_selection_internal.
986 (ns_handle_selection_request): Move code to Fx_own_selection_internal
987 and remove this function.
988 (ns_handle_selection_clear): Remove, never used.
989 (Fx_own_selection_internal): Move code from ns_handle_selection_request
990 here.
991
992 2011-12-17 Ken Brown <kbrown@cornell.edu>
993
994 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
995 GID is unknown (Bug#10257).
996
997 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
998
999 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1000 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1001 which caused a build failure on GNU/Linux IA-64. This problem was
1002 introduced by my 2011-10-07 patch.
1003
1004 2011-12-15 Juri Linkov <juri@jurta.org>
1005
1006 * image.c (imagemagick_error): New function. (Bug#10112)
1007 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1008 Use `imagemagick_error' where ImageMagick functions return
1009 `MagickFalse'.
1010 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1011 proper order.
1012
1013 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1014
1015 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1016 fill background (Bug#8992).
1017
1018 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1019
1020 * window.c (Vwindow_combination_resize)
1021 (Vwindow_combination_limit): Use t instead of non-nil in
1022 doc-strings.
1023 (Vrecenter_redisplay): Add first sentence of doc-string on
1024 separate line.
1025 (Frecenter): Fix doc-string typo.
1026
1027 2011-12-11 Kenichi Handa <handa@m17n.org>
1028
1029 * coding.c (Funencodable_char_position): Pay attention to the
1030 buffer text relocation (Bug#9389).
1031
1032 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1033
1034 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1035 gtk_init (Bug#10100).
1036
1037 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1038
1039 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1040 IT->string is nil. (Bug#10263)
1041
1042 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1043
1044 * nsterm.h (x_free_frame_resources): Declare.
1045
1046 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1047 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1048
1049 * nsterm.h (ns_get_defaults_value): Declare.
1050
1051 * nsterm.m (ns_default): Call ns_get_defaults_value.
1052
1053 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1054
1055 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1056 (Bug#10170)
1057
1058 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1059
1060 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1061 that where the value of an _OBJC_* symbol points to is in the .bss
1062 section (Bug#10240).
1063
1064 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1065
1066 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1067 after the loop to call ccl_driver at least once (Bug#8619).
1068
1069 2011-12-08 Kenichi Handa <handa@m17n.org>
1070
1071 * ftfont.c (get_adstyle_property): Fix previous change
1072 (Bug#10233).
1073
1074 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1075
1076 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1077 dirs from the default value of EMACSLOADPATH (bug#10208).
1078
1079 2011-12-07 Glenn Morris <rgm@gnu.org>
1080
1081 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1082 installation and source directories as well. (Bug#10208)
1083
1084 2011-12-06 Chong Yidong <cyd@gnu.org>
1085
1086 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1087
1088 2011-12-06 Glenn Morris <rgm@gnu.org>
1089
1090 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1091 as an error, not just -1. (Bug#10217)
1092
1093 2011-12-05 Chong Yidong <cyd@gnu.org>
1094
1095 * keyboard.c (process_special_events): New function.
1096 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1097
1098 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * coding.c (encode_designation_at_bol): Don't use uninitialized
1101 local variable (Bug#9318).
1102
1103 2011-12-05 Kenichi Handa <handa@m17n.org>
1104
1105 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1106 return Qnil (Bug#8046, Bug#10193).
1107
1108 2011-12-05 Kenichi Handa <handa@m17n.org>
1109
1110 * coding.c (encode_designation_at_bol): New args charbuf_end and
1111 dst. Return the number of produced bytes. Callers changed.
1112 (coding_set_source): Return how many bytes coding->source was
1113 relocated.
1114 (coding_set_destination): Return how many bytes
1115 coding->destination was relocated.
1116 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1117 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1118
1119 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1120
1121 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1122 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1123 macro (Bug#9318).
1124
1125 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1126
1127 The following changes are to fix Bug#9318.
1128
1129 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1130 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1131 (encode_coding_iso_2022, encode_coding_sjis)
1132 (encode_coding_big5, encode_coding_charset): Use the above macros.
1133
1134 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1135
1136 * lisp.h (process_quit_flag): Fix external declaration.
1137
1138 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1139
1140 Don't macro-inline non-performance-critical code.
1141 * eval.c (process_quit_flag): New function.
1142 * lisp.h (QUIT): Use it.
1143
1144 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1145
1146 * nsfns.m (get_geometry_from_preferences): New function.
1147 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1148
1149 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1150
1151 * emacs.c (Qkill_emacs): Define.
1152 (syms_of_emacs): Initialize it.
1153 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1154 Qquit_flag to `kill-emacs' instead.
1155 (quit_throw_to_read_char): Add parameter `from_signal'.
1156 All callers changed. Call Fkill_emacs if requested and safe.
1157 * lisp.h (QUIT): Call Fkill_emacs if requested.
1158
1159 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1160
1161 * widget.c (update_wm_hints): Return if wmshell is null.
1162 (widget_update_wm_size_hints): New function.
1163
1164 * widget.h (widget_update_wm_size_hints): Declare.
1165
1166 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1167 widget_update_wm_size_hints (Bug#10104).
1168
1169 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1170
1171 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1172 before a newline, prepare the bidi iterator for consuming the
1173 newline, and keep the current paragraph direction. (Bug#10183)
1174 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1175
1176 2011-12-02 Juri Linkov <juri@jurta.org>
1177
1178 * search.c (Fword_search_regexp): New Lisp function created from
1179 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1180 (Fword_search_backward, Fword_search_forward)
1181 (Fword_search_backward_lax, Fword_search_forward_lax):
1182 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1183 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1184
1185 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1186
1187 * fileio.c (Finsert_file_contents): Move after-change-function call
1188 to before the "handled:" label, since all "goto handled" appear in
1189 cases where the *-change-functions have already been properly called
1190 (bug#10117).
1191
1192 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1193
1194 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1195 waiting for input. (Bug#10169)
1196
1197 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1198
1199 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1200 verifies glyph row's hash code--we have just reallocated the
1201 glyphs, so their contents can be complete garbage. (Bug#10164)
1202
1203 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1204
1205 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1206
1207 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1208
1209 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1210 attributes are tested _before_ calling verify_row_hash, to protect
1211 against GCC re-ordering of the tests. (Bug#10164)
1212
1213 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1214
1215 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1216
1217 * xterm.c (handle_one_xevent): Only set async_visible and friends
1218 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1219 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1220 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1221
1222 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1223
1224 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1225 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1226 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1227 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1228 All uses changed to use GCPRO1 etc.
1229 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1230 Revert to old implementation (i.e., before 2011-03-11).
1231
1232 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1233
1234 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1235 of scroll runs so as to avoid assigning disabled bogus rows and
1236 unnecessary graphics copy operations.
1237
1238 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1239
1240 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1241 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1242 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1243 (malloc, free, realloc, calloc): Redirect to e_* only when
1244 compiling Emacs.
1245
1246 * lisp.h (GCTYPEBITS): Move before first use.
1247 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1248 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1249 this macro definition.
1250
1251 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1252 _MSC_VER.
1253
1254 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1255
1256 * gtkutil.c (xg_create_frame_widgets):
1257 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1258 present with Gtk+ 2.0.
1259
1260 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 * fileio.c (Finsert_file_contents): Undo previous change; see
1263 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1264
1265 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1266
1267 Rename locals to avoid shadowing.
1268 * fileio.c (Finsert_file_contents):
1269 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1270 * process.c (wait_reading_process_output):
1271 Rename inner 'proc' to 'p' to avoid shadowing.
1272 Indent for consistency with usual Emacs style.
1273
1274 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (redisplay_window): If cursor row is not fully visible
1277 after recentering, and scroll-conservatively is set to a large
1278 number, scroll window by a few more lines to make the cursor fully
1279 visible and out of scroll-margin. (Bug#10105)
1280 (start_display): Don't move to the next line if the display should
1281 start at a newline that is part of a display vector or an overlay
1282 string. (Bug#10119)
1283
1284 2011-11-24 Juri Linkov <juri@jurta.org>
1285
1286 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1287 after the `MagickPingImage' call. (Bug#10112)
1288
1289 2011-11-23 Chong Yidong <cyd@gnu.org>
1290
1291 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1292
1293 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1294
1295 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1296 making another buffer current. (Bug#10114)
1297
1298 2011-11-23 Glenn Morris <rgm@gnu.org>
1299
1300 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1301
1302 2011-11-23 Chong Yidong <cyd@gnu.org>
1303
1304 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1305 using it (Bug#5984).
1306
1307 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1308
1309 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1310 and header-lines, as they don't have one computed for them.
1311 (Bug#10098)
1312
1313 * .gdbinit (prow): Make displayed values more self-explaining.
1314 Add row's hash code.
1315
1316 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1317
1318 * process.c (wait_reading_process_output): Fix asynchrounous
1319 GnuTLS socket handling on some versions of the GnuTLS library.
1320 (wait_reading_process_output): Add comment and URL.
1321
1322 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1323
1324 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1325
1326 2011-11-21 Chong Yidong <cyd@gnu.org>
1327
1328 * window.c (Fnext_window, Fprevious_window): Doc fix.
1329
1330 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1331
1332 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1333
1334 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1335
1336 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1337
1338 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1339
1340 * window.c (Fset_window_combination_limit): Rename argument
1341 STATUS to LIMIT.
1342 (Vwindow_combination_limit): Remove "status" from doc-string.
1343
1344 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1345
1346 * m/ibms390.h: Remove.
1347 * m/ibms390x.h: Don't include "ibms390.h".
1348
1349 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1350
1351 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1352 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1353
1354 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1355
1356 * casetab.c (Fset_case_table):
1357 * charset.c (Fcharset_after): Fix typos.
1358
1359 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1362 Otherwise, valgrind does not work on some platforms.
1363 Problem reported by Andreas Schwab in
1364 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1365 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1366 is set, removing the need for VIRT_ADDRESS_VARIES.
1367 (PURE_P): Use a more-efficient implementation that needs just one
1368 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1369 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1370 to 4 (xorl, subq, cmpq, setbe).
1371 * alloc.c (pure): Always extern now, since that's the
1372 VIRT_ADDR_VARIES behavior.
1373 (PURE_POINTER_P): Use a single comparison, not two, for
1374 consistency with the new puresize.h.
1375 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1376 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1377 Remove VIRT_ADDR_VARIES no longer needed.
1378
1379 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1380
1381 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1382 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1383 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1384 behave as if the cursor position were at the window margin.
1385
1386 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1387 and the cursor position is out of bounds, behave as if the cursor
1388 position were at the window margin. (Bug#10075)
1389
1390 2011-11-18 Chong Yidong <cyd@gnu.org>
1391
1392 * window.c (Fwindow_combination_limit): Make first argument
1393 non-optional, since it is meaningless for live windows like the
1394 selected window.
1395
1396 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1397
1398 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1399
1400 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1401
1402 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1403 (graft_intervals_into_buffer): Simplify.
1404
1405 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1406
1407 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1408 hash values of the two rows.
1409 (copy_row_except_pointers): Preserve the used[] arrays and the
1410 hash values of the two rows. (Bug#10035)
1411 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1412
1413 * xdisp.c (row_hash): New function, body extracted from
1414 compute_line_metrics.
1415 (compute_line_metrics): Call row_hash, instead of computing the
1416 hash code inline.
1417
1418 * dispnew.c (verify_row_hash): Call row_hash for computing the
1419 hash code of a row, instead of duplicating code from xdisp.c.
1420
1421 * dispextern.h (row_hash): Add prototype.
1422
1423 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1424
1425 * frame.c (delete_frame): Don't delete the terminal when the last
1426 X frame is closed if emacs is built with GTK toolkit.
1427
1428 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1429
1430 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1431
1432 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1433
1434 * window.c (Vwindow_splits): Rename to
1435 Vwindow_combination_resize. Suggested by Juri Linkov.
1436 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1437 of Vwindow_splits.
1438
1439 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1440
1441 * nsfns.m (Fns_font_name):
1442 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1443
1444 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1445
1446 * window.h (window): Rename slot "nest" to "combination_limit".
1447 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1448 (Fset_window_nest): Rename to Fset_window_combination_limit.
1449 (Vwindow_nest): Rename to Vwindow_combination_limit.
1450 (recombine_windows, make_parent_window, make_window)
1451 (Fsplit_window_internal, saved_window)
1452 (Fset_window_configuration, save_window_save): Rename all
1453 occurrences of window_nest to window_combination_limit.
1454
1455 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1456
1457 * image.c (imagemagick_load_image): Fix typo.
1458
1459 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1460
1461 * xdisp.c (display_line): Move the call to
1462 highlight_trailing_whitespace before the call to
1463 compute_line_metrics, since the latter needs to see the final
1464 faces of all the glyphs to compute ROW's hash value.
1465 Fixes assertion violations in row_equal_p. (Bug#10035)
1466
1467 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1468
1469 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1470 just return (bug#10044).
1471
1472 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1473
1474 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1475 with user-defined heap size. Bump the default size of the temacs
1476 heap to 27MB, to avoid memory warning when running temacs.
1477 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1478
1479 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1480 current_matrix and desired_matrix. (Bug#9990)
1481 (verify_row_hash) [XASSERTS]: New function.
1482 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1483 that the hash value of glyph rows is correct.
1484
1485 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1486
1487 * window.h (window): Remove splits slot.
1488 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1489 (Fdelete_other_windows_internal, make_parent_window)
1490 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1491 (Fset_window_configuration, save_window_save): Don't deal with
1492 split status of windows.
1493 (saved_window): Remove splits slot.
1494 (Vwindow_splits): Rewrite doc-string.
1495
1496 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1497
1498 * xfns.c (unwind_create_frame):
1499 * nsfns.m (unwind_create_frame):
1500 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1501 Vframe_list (Bug#9999).
1502
1503 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1504
1505 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1506
1507 2011-11-11 Kenichi Handa <handa@m17n.org>
1508
1509 * callproc.c (Fcall_process): Set the member dst_multibyte of
1510 process_coding.
1511
1512 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1513
1514 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1515 avoid a crash (bug#9496).
1516
1517 2011-11-09 Chong Yidong <cyd@gnu.org>
1518
1519 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1520 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1521
1522 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1523
1524 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1525
1526 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 Avoid some portability problems by eschewing 'extern inline' functions.
1529 The trivial performance wins aren't worth the portability hassles; see
1530 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1531 et seq.
1532 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1533 (window_box_width, window_box_left, window_box_left_offset)
1534 (window_box_right, window_box_right_offset): Undo previous change,
1535 by removing the "extern"s.
1536 * intervals.c (adjust_intervals_for_insertion)
1537 (adjust_intervals_for_deletion): Undo previous change,
1538 making these static again.
1539 (offset_intervals, temp_set_point_both, temp_set_point)
1540 (copy_intervals_to_string): No longer inline.
1541 * xdisp.c (window_text_bottom_y, window_box_width)
1542 (window_box_height, window_box_left_offset)
1543 (window_box_right_offset, window_box_left, window_box_right)
1544 (window_box): No longer inline.
1545
1546 2011-11-08 Chong Yidong <cyd@gnu.org>
1547
1548 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1549 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1550 Signal an error if not a live window.
1551 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1552 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1553
1554 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1555
1556 * lisp.h (syms_of_abbrev): Remove declaration.
1557 Reported by CHENG Gao <chenggao@royau.me>.
1558
1559 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1560
1561 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1562 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1563 of temacs in GUI mode.
1564
1565 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1566
1567 * window.h: Declare delete_all_child_windows instead of
1568 delete_all_subwindows.
1569 * window.c (Fwindow_nest, Fset_window_nest)
1570 (Fset_window_new_total, Fset_window_new_normal)
1571 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1572 (delete_all_subwindows): Rename to delete_all_child_windows.
1573 (Fdelete_other_windows_internal, Fset_window_configuration):
1574 Call delete_all_child_windows instead of delete_all_subwindows.
1575 * frame.c (delete_frame): Call delete_all_child_windows instead
1576 of delete_all_subwindows.
1577
1578 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1581 This is also needed for porting to any host where GC_MARK_STACK is
1582 not GC_MAKE_GCPROS_NOOPS.
1583 (which_symbols): Use it.
1584
1585 2011-11-07 Kenichi Handa <handa@m17n.org>
1586
1587 * coding.c (coding_set_destination): Check coding->src_pos only
1588 when coding->src_object is a buffer (bug#9910).
1589
1590 * process.c (send_process): Set the member src_multibyte of coding
1591 to 0 (bug#9911) when sending a unibyte text.
1592
1593 * callproc.c (Fcall_process): Set the member src_multibyte of
1594 process_coding to 0 (bug#9912).
1595
1596 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1597
1598 * xmenu.c (cleanup_widget_value_tree): New function.
1599 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1600 calling free_menubar_widget_value_tree directly (Bug#9830).
1601
1602 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1603
1604 Fix some portability problems with 'inline'.
1605 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1606 (window_box_width, window_box_left, window_box_left_offset)
1607 (window_box_right, window_box_right_offset): Declare extern.
1608 Otherwise, these inline functions do not conform to C99 and
1609 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1610 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1611 * intervals.c (adjust_intervals_for_insertion)
1612 (adjust_intervals_for_deletion): Now extern, because otherwise the
1613 extern inline functions 'offset_intervals' couldn't refer to it.
1614 (static_offset_intervals): Remove.
1615 (offset_intervals): Rewrite using the old contents of
1616 static_offset_intervals. The old version didn't conform to C99
1617 because an extern inline function contained a reference to an
1618 identifier with static linkage.
1619
1620 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1621
1622 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1623 GC.
1624
1625 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1626
1627 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1628 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1629 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1630 return Qleft_to_right.
1631
1632 2011-11-06 Chong Yidong <cyd@gnu.org>
1633
1634 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1635 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1636 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1637 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1638 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1639 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1640 (Fwindow_vscroll): Doc fix.
1641 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1642 argument, since it makes no sense to pass a live window and for
1643 consistency with window-child.
1644
1645 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1646
1647 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1648 support MSVC.
1649
1650 2011-11-05 Jason Rumney <jasonr@gnu.org>
1651
1652 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1653 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1654 fonts (Bug#6029).
1655 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1656 bitwise arithmetic preventing use of unicode-sip and non-truetype
1657 opentype fonts.
1658
1659 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1660
1661 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1662 "emacs"-only part.
1663
1664 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1665 initialization code to keep similarity to xfns.c after changes
1666 from 2011-11-05.
1667
1668 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1669
1670 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1671 (unwind_create_frame): New function (Bug#9943).
1672 (Fx_create_frame): Restructure code to be more similar to the one in
1673 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1674 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1675 Move terminal->reference_count++ just before making the frame official
1676 (Bug#9943).
1677
1678 * nsterm.m (x_free_frame_resources): New function.
1679 (x_destroy_window): Move code to x_free_frame_resources.
1680
1681 * xfns.c (unwind_create_frame): Fix comment.
1682 (Fx_create_frame, x_create_tip_frame):
1683 Move terminal->reference_count++ just before making the frame
1684 official. Move initialization of image_cache_refcount and
1685 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1686
1687 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1688
1689 Support MSVC build with newer versions of Visual Studio.
1690 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1691 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1692 nt/gmake.defs.
1693
1694 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1695 which are not supported by MSVC.
1696 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1697 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1698 bitfields.
1699 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1700 types in bitfields.
1701 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1702
1703 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1704
1705 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1706
1707 Support MSVC build with newer versions of Visual Studio.
1708 * w32.c: Don't include w32api.h for MSVC.
1709 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1710
1711 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1712 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1713 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1714 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1715 e_* cousins.
1716 (alloca) [_MSC_VER]: Define to _alloca.
1717
1718 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1719
1720 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1721
1722 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1723
1724 * xdisp.c (note_mouse_highlight): If either of
1725 previous/next-single-property-change returns nil, treat that as
1726 the beginning or the end of the buffer. (Bug#9955)
1727
1728 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1729
1730 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1731 label is not null (Bug#9951).
1732 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1733 may be NULL.
1734
1735 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1736
1737 * window.c (Fwindow_body_size): Mention in the doc string that the
1738 return value is in frame's canonical units. (Bug#9949)
1739
1740 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1743
1744 * w32fns.c (unwind_create_frame): If needed, free the glyph
1745 matrices of the partially constructed frame. (Bug#9943)
1746 * xfns.c (unwind_create_frame): Likewise.
1747
1748 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1749
1750 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1751 Don't stop backward scan on the continuation glyph, even though
1752 its CHARPOS is positive.
1753 (mouse_face_from_buffer_pos, note_mouse_highlight):
1754 Rename cover_string to disp_string.
1755
1756 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1757
1758 * window.c (temp_output_buffer_show): Don't use
1759 Vtemp_buffer_show_specifiers.
1760 (Vtemp_buffer_show_specifiers): Remove unused variable.
1761
1762 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1763
1764 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1765 past the beginning of the current glyph matrix.
1766
1767 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1768
1769 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1770 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1771 HAVE_GTK3 (Bug#9869).
1772
1773 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1774 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1775
1776 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1777
1778 * xterm.c: Declare x_handle_net_wm_state to return int.
1779 (handle_one_xevent): Check if we are iconified but don't have
1780 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1781 (get_current_wm_state): Return non-zero if not hidden,
1782 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1783 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1784 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1785 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1786
1787 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1788
1789 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1790 so that this new function doesn't get optimized away by a
1791 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1792
1793 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1794
1795 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1796
1797 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1798
1799 Fix the `xbytecode' command.
1800 * .gdbinit (xprintbytestr): New command.
1801 (xwhichsymbols): Rename from `which'; all callers changed.
1802 (xbytecode): Print the byte-code string as well.
1803
1804 2011-10-29 Kim Storm <storm@cua.dk>
1805
1806 * alloc.c (which_symbols): New function.
1807
1808 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1809
1810 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1811 line. (Bug#9903)
1812
1813 2011-10-29 Glenn Morris <rgm@gnu.org>
1814
1815 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1816 Not clear what it was for, and it causes various bugs. (Bug#9839)
1817
1818 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1819
1820 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1821 possible random value that matches one of those tested as
1822 condition to clear the mouse face.
1823
1824 2011-10-28 Chong Yidong <cyd@gnu.org>
1825
1826 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1827
1828 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1829
1830 * window.c (make_window): Initialize phys_cursor_on_p.
1831
1832 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1833
1834 * lisp.h (struct Lisp_Symbol): Update comments.
1835
1836 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1837
1838 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1839
1840 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1841
1842 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1843 <oslsachem@gmail.com> for helping to debug this.
1844
1845 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1846 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1847 (g_b_init_get_glyph_outline_w): New static variables.
1848 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1849 (GetGlyphOutlineW_Proc): New typedefs.
1850 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1851 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1852 New functions.
1853 (w32font_open_internal, compute_metrics):
1854 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1855 instead of calling the "wide" APIs directly.
1856
1857 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1858
1859 * w32.h (syms_of_w32font): Add prototype.
1860
1861 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1862
1863 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1864 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1865 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1866 (Fmove_to_window_line): Doc fix.
1867
1868 2011-10-27 Chong Yidong <cyd@gnu.org>
1869
1870 * process.c (make_process): Set gnutls_state to NULL.
1871
1872 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1873 non-NULL, regardless of GNUTLS_INITSTAGE.
1874 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1875 an error. Set process slots as soon as we allocate them.
1876
1877 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1878
1879 2011-10-27 Chong Yidong <cyd@gnu.org>
1880
1881 * gnutls.c (emacs_gnutls_deinit): New function.
1882 Deallocate credentials structures as well as calling gnutls_deinit.
1883 (Fgnutls_deinit, Fgnutls_boot): Use it.
1884
1885 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1886 (deactivate_process): Call emacs_gnutls_deinit.
1887
1888 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1889
1890 * image.c (x_create_x_image_and_pixmap):
1891 * w32.c (sys_rename, w32_delayed_load):
1892 * w32font.c (fill_in_logfont):
1893 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1894
1895 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1896
1897 * w32fns.c (w32_default_color_map): New function,
1898 extracted from Fw32_default_color_map.
1899 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1900
1901 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1904
1905 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1906
1907 * keyboard.c (test_undefined): New function (bug#9751).
1908 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1909
1910 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1911
1912 * sysdep.c (init_sys_modes): Fix the check for the controlling
1913 terminal (Bug#6649).
1914
1915 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1916
1917 * dispextern.h (struct bidi_it): New member next_en_type.
1918
1919 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1920 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1921 current character, check also for next_en_type being WEAK_EN.
1922 (bidi_resolve_weak): Don't enter the expensive loop if the current
1923 position is before next_en_pos. Record the bidi type of the first
1924 non-ET, non-BN character we find, in addition to its position.
1925 (bidi_level_of_next_char): Invalidate next_en_type when
1926 next_en_pos is over-stepped.
1927
1928 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1929
1930 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1931 * editfns.c: Rewrite current-time-zone so that it invokes
1932 the equivalent of (format-time-string "%Z") to get the time zone name.
1933 This fixes a bug when the time zone name contains characters that
1934 need converting from the system time locale to Emacs internal format.
1935 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1936 that patch fixed format-time-string to do the conversion, but
1937 I forgot to fix current-time-zone.
1938 (format_time_string): New function, containing most of
1939 what Fformat_time_string used to contain.
1940 (Fformat_time_string): Rewrite in terms of format_time_string.
1941 This doesn't change this function's behavior.
1942 (current-time-zone): Rewrite to use format_time_string.
1943 This fixes the bug reported by Michael Schierl in
1944 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1945 Jason Rumney's 2007-06-07 change worked around this bug, but
1946 didn't fix it.
1947 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1948
1949 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1950
1951 * xdisp.c (start_display): If the character at POS is displayed
1952 via a display vector, reset IT->current.dpvec_index to zero.
1953 (try_window_reusing_current_matrix): If a line ends in a display
1954 vector or the next line starts in a display vector, continue
1955 redrawing the window even though the character position of
1956 start_row was reached.
1957 (Bug#9771, part 2)
1958
1959 2011-10-18 Chong Yidong <cyd@gnu.org>
1960
1961 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1962 with nobreak-char-display too.
1963
1964 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1965
1966 Fix part 3 of bug#9771.
1967 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1968 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1969 non-neutral characters if the current character is a paragraph
1970 separator (a.k.a. Newline). This avoids running the same
1971 expensive loop twice, once when we consume the preceding newline
1972 and the other time when the line actually needs to be displayed.
1973 Avoid the loop when we see neutrals on the base embedding level
1974 following a character whose directionality is the same as the
1975 paragraph's. This avoids running the expensive loop when a line
1976 ends in a long sequence of neutrals, like control characters.
1977 Add assertion against STRONG_AL type. Slightly rearrange code
1978 that determines the type of a neutral given the first non-neutral
1979 that follows it.
1980 (bidi_level_of_next_char): Set next_en_pos to zero when
1981 invalidating its info.
1982
1983 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1984
1985 * xdisp.c (push_display_prop): Determine whether to record string
1986 or buffer position by IT->string, not by IT->method. Allow
1987 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1988 (move_it_vertically_backward): Don't look for character position
1989 immediately after the newline when in a continuation line.
1990 (Bug#9771, part 1)
1991
1992 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1993
1994 * window.c (coordinates_in_window): Rewrite and delabelize
1995 vertical border check. (Bug#5357) (Bug#9618)
1996
1997 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1998
1999 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2000 errors in XSetWindowBorder (bug#9310).
2001
2002 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2003
2004 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2005 avoid crash when xmalloc overrun checking is enabled.
2006
2007 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2008
2009 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2010 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2011 cursor motion with <left> and <right> arrow keys.
2012
2013 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2014 some callers set that themselves.
2015
2016 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2017
2018 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2019 display string and the previous row comes from the same string and
2020 is empty. (Bug#9739) (Bug#9738)
2021
2022 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2023
2024 * doc.c (get_doc_string): Encode file name (bug#9735).
2025
2026 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2027
2028 * bidi.c (bidi_level_of_next_char):
2029 * xdisp.c (get_visually_first_element): Remove old incorrect
2030 comments regarding the Unicode Line Separator character.
2031
2032 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2033
2034 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2035
2036 * alloc.c (Fgc_status): Do not access beyond zombies array
2037 boundary if nzombies > MAX_ZOMBIES.
2038 * alloc.c (dump_zombies): Add missing format specifier.
2039
2040 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2041
2042 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2043 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2044
2045 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2046 Some packages use them to denote characters with modifiers.
2047
2048 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2049
2050 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2051 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2052 matching a pp-number. Rename parameter var to var1.
2053
2054 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2055
2056 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2057
2058 2011-10-08 Glenn Morris <rgm@gnu.org>
2059
2060 * callint.c (Fcall_interactively): Give a more explicit error for the
2061 'c' case with a non-character input. (Bug#8479)
2062
2063 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2064
2065 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2066 lines.
2067 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2068 lines that are hscrolled on the left.
2069
2070 * dispnew.c (buffer_posn_from_coords): Account for a possible
2071 presence of header-line. (Bug#4426)
2072
2073 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2074
2075 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2076 Don't advertise functionality which we discourage or doesn't work.
2077
2078 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2079
2080 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2081 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2082 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2083 this makes Emacs dump core during garbage collection on rare
2084 occasions. sizeof is obviously inferior to offsetof here, so
2085 stick with offsetof.
2086 (GC_POINTER_ALIGNMENT): New macro.
2087 (mark_memory): Omit 3rd (offset) arg; caller changed.
2088 Don't assume EMACS_INT alignment is the same as pointer alignment.
2089
2090 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2091
2092 * keyboard.c (read_key_sequence_remapped): New var.
2093 (read_key_sequence): Compute remapping in the right buffer.
2094 (command_loop_1): Use read_key_sequence's remapping directly.
2095
2096 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2097
2098 * dired.c (file_name_completion): Don't expand file name.
2099 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2100 before checking file name handler.
2101
2102 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2103 they've been requested explicitly (bug#9591).
2104
2105 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2106
2107 * keymap.c (Fsingle_key_description): Use make_specified_string
2108 instead of build_string to build string from push_key_description.
2109 (Bug#5193)
2110
2111 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2112
2113 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2114 This fixes a Y2038 bug on 64-bit hosts.
2115 * buffer.c (reset_buffer):
2116 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2117 (Fclear_buffer_auto_save_failure):
2118 Use 0, not -1, to represent an unset failure time, since time_t
2119 might not be signed.
2120
2121 Remove dependency on glibc malloc internals.
2122 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2123 Move back here from lisp.h, but with their new implementations.
2124 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2125 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2126 * charset.c (charset_table_init): New static var.
2127 (syms_of_charset): Use it instead of xmalloc. This removes a
2128 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2129 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2130 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2131 Move back to alloc.c.
2132 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2133 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2134
2135 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2136
2137 * nsterm.m (windowDidResize): Call x_set_window_size only when
2138 ns_in_resize is true. Otherwise set pixelwidth/height and
2139 call change_frame_size (Bug#9628).
2140
2141 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2142
2143 Port --enable-checking=all to Fedora 14 x86-64.
2144 * charset.c (syms_of_charset): Also account for glibc malloc's
2145 internal overhead when calculating the initial malloc maximum.
2146
2147 Port --enable-checking=all to Fedora 14 x86.
2148 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2149 Move to lisp.h.
2150 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2151 (overrun_check_realloc, overrun_check_free):
2152 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2153 That way, xmalloc returns a properly-aligned pointer even if
2154 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2155 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2156 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2157 into account when calculating the initial malloc maximum.
2158 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2159 Move here from alloc.c, so that charset.c can use it too.
2160 Properly align; the old code wasn't right for common 32-bit hosts
2161 when configured with --enable-checking=all.
2162 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2163 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2164
2165 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2166
2167 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2168 use EDOM.
2169
2170 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2171
2172 * xdisp.c (compute_display_string_end): If there's no display
2173 string at CHARPOS, return -1.
2174
2175 * bidi.c (bidi_fetch_char): When compute_display_string_end
2176 returns a negative value, treat the character as a normal
2177 character not covered by a display string. (Bug#9624)
2178
2179 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2180
2181 * lread.c (Fread_from_string): Fix typo in docstring.
2182
2183 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2184
2185 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2186 newline, reseat the iterator instead of bidi-iterating there one
2187 character at a time. (Bug#9610)
2188 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2189 TO_CHARPOS if the bidi iterator is at base embedding level.
2190
2191 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2192
2193 * lread.c (readevalloop): Use correct code for NBSP.
2194 (read1): Likewise. (Bug#9608)
2195
2196 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2197
2198 * dbusbind.c (Fdbus_register_signal): When service is not
2199 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2200
2201 2011-09-25 Glenn Morris <rgm@gnu.org>
2202
2203 * buffer.c (truncate-lines): Doc fix.
2204
2205 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2206
2207 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2208 (Fset_window_next_buffers): Doc fix.
2209
2210 2011-09-24 Glenn Morris <rgm@gnu.org>
2211
2212 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2213
2214 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2215
2216 Fix minor problems found by static checking.
2217 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2218 * indent.c (Fvertical_motion): Fix == vs = typo.
2219
2220 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2221
2222 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2223 Default value is now t. Doc fix.
2224
2225 * indent.c (Fvertical_motion): Compute and apply the overshoot
2226 logic when moving up, not only when moving down. Fix the
2227 confusing name and values of the it_overshoot_expected variable;
2228 logic changes accordingly. (Bug#9254) (Bug#9549)
2229
2230 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2231 CHARPOS is covered by a display string which includes newlines.
2232 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2233 is covered by a display string with embedded newlines.
2234
2235 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2236
2237 * dbusbind.c (Fdbus_register_signal): Add match rule to
2238 Vdbus_registered_objects_table. (Bug#9581)
2239 (Fdbus_register_method, Vdbus_registered_objects_table):
2240 Fix docstring.
2241
2242 2011-09-24 Jim Meyering <meyering@redhat.com>
2243
2244 do not ignore write error for any output size
2245 The previous change was incomplete.
2246 While it makes emacs --batch detect the vast majority of stdout
2247 write failures, errors were still ignored whenever the output size is
2248 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2249 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2250 && echo FAIL: ignored write error
2251 FAIL: ignored write error
2252 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2253 && echo FAIL: ignored write error
2254 FAIL: ignored write error
2255 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2256
2257 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2258
2259 * emacs.c (Fkill_emacs): In noninteractive mode exit
2260 non-successfully if a write error occurred on stdout. (Bug#9574)
2261
2262 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2263
2264 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2265 the xassert test.
2266
2267 * dispextern.h (struct it): Update the comment documenting what
2268 can it->OBJECT be.
2269
2270 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2271
2272 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2273 a display string, extend search for cursor position to end of row.
2274 (find_row_edges): If the row ends in a newline from a display
2275 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2276 Handle the case of a display string with multiple newlines.
2277 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2278 non-empty line. Fixes confusing cursor motion with arrow keys at
2279 the beginning of a line that starts with whitespace.
2280
2281 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2282
2283 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2284 (bug#9493).
2285
2286 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2287
2288 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2289 boolean (Bug#9154).
2290
2291 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2292
2293 * xdisp.c (display_line): Record maximum and minimum buffer
2294 positions even if no glyphs were produced (e.g., by a zero-width
2295 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2296 buffer positions that will be removed from the glyph row because
2297 they don't fit.
2298 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2299 column is beyond frame width: don't subtract 1 "pixel" when
2300 computing width of the stretch.
2301 (reseat_at_next_visible_line_start): Undo the change made on
2302 2011-09-17 that saved paragraph information and restored it after
2303 the call to `reseat'. (Bug#9545)
2304
2305 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2306
2307 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2308 and turn window cursor on if cleared (Bug#9415).
2309
2310 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2311
2312 * search.c (boyer_moore): Take unibyte characters from pattern
2313 literally. (Bug#9458)
2314
2315 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2316
2317 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2318
2319 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2320
2321 Fix minor problem found by static checking.
2322 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2323 initialized, to pacify gcc -Wuninitialized.
2324
2325 * fileio.c: Report proper errno when syscall falls.
2326 (Finsert_file_contents): Save and restore errno,
2327 so that report_file_error outputs the correct diagnostic.
2328 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2329
2330 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2331
2332 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2333
2334 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2335
2336 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2337 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2338
2339 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2340
2341 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2342 about the current paragraph and restore it after the call to reseat.
2343
2344 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2345 (bidi_find_paragraph_start): Search back for paragraph beginning
2346 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2347 (bidi_move_to_visually_next): Only trigger paragraph-related
2348 computations when the last character is a newline or at EOB, not
2349 just any NEUTRAL_B. (Bug#9470)
2350
2351 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2352 truncated lines if point is covered by a display string. (Bug#9524)
2353
2354 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2357 (cons_to_x_long): New function.
2358 (lisp_data_to_selection_data): Use it. Correct the test for
2359 short-versus-long data; it was negated. Break out of vector
2360 loop, for efficiency, when a long datum is discovered.
2361
2362 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2363
2364 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2365
2366 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2367
2368 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2369 GCC PR/17406) by declaring this function with external scope.
2370
2371 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2374 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2375
2376 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2377
2378 * editfns.c (Fformat): Correctly handle text properties on "%%".
2379
2380 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2381
2382 * xterm.c (x_draw_composite_glyph_string_foreground):
2383 * w32term.c (x_draw_composite_glyph_string_foreground):
2384 * term.c (encode_terminal_code):
2385 * composite.c (composition_update_it, get_composition_id):
2386 * xdisp.c (get_next_display_element)
2387 (fill_composite_glyph_string): Add comments about special meaning
2388 of TAB characters in a composition.
2389
2390 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2391
2392 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2393 This occurs when processing a multibyte format.
2394 Problem reported by Wolfgang Jenker.
2395
2396 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2397
2398 * xdisp.c (try_cursor_movement): Only check for exact match if
2399 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2400
2401 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2402
2403 Remove unused external symbols.
2404 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2405 * xdisp.c (calc_pixel_width_or_height): Now static.
2406 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2407 * indent.c (check_display_width):
2408 * w32term.c: Fix comment to match code.
2409 * xterm.c, xterm.h (x_catching_errors): Remove.
2410
2411 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2412
2413 * xselect.c: Use signed conversions more consistently (Bug#9498).
2414 (selection_data_to_lisp_data): Assume incoming selection data are
2415 signed integers, not unsigned. This is to be consistent with
2416 outgoing selection data, which was modified to use signed integers
2417 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2418 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2419 expects long, not unsigned long.
2420
2421 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2422
2423 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2424 computation of loop end. Reported by Johan Bockgård
2425 <bojohan@gnu.org>.
2426
2427 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2428
2429 * frame.c (Fother_visible_frames_p): Function deleted.
2430
2431 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2432
2433 * indent.c (compute_motion): Process display vector front to back
2434 rather than the other way around. (Bug#2496)
2435
2436 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2437
2438 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2439
2440 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2441
2442 * minibuf.c (Fread_from_minibuffer): Doc fix.
2443
2444 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2445
2446 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2447 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2448
2449 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2450
2451 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2452 value for non-existent files.
2453
2454 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2455
2456 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2457 set its "size" to -1. This will set the modtime_size field of
2458 the corresponding buffer to -1, which is what
2459 verify-visited-file-modtime expects for files that do not exist.
2460 (Bug#9139)
2461
2462 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2465 here ...
2466 * lisp.h: ... from here. push_key_description is no longer
2467 defined in keyboard.c, so its declaration should not be in
2468 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2469 logically belongs with push_key_description.
2470
2471 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2472
2473 * buffer.h: Include <sys/types.h> instead of <time.h>.
2474 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2475 Problem reported by Herbert J. Skuhra.
2476
2477 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2478
2479 * xml.c (parse_region): Make the parsing work for
2480 non-comment-starting XML files again (bug#9144).
2481
2482 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2483
2484 * image.c (gif_load): Fix calculation of bottom and right corner.
2485 (Bug#9468)
2486
2487 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2488
2489 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2490 redisplay in small windows.
2491
2492 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2493
2494 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2495
2496 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2497
2498 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2499 Operate on live windows only.
2500
2501 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2502
2503 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2504
2505 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2506
2507 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2508 only under bidi iteration.
2509
2510 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2511
2512 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2513
2514 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2515
2516 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2517 Without this fix, the command to link temacs failed due to an
2518 undefined symbol __builtin_isnan. This is because
2519 /usr/include/iso/math_c99.h #defines isnan(x) to
2520 __builtin_isnan(x), but the bundled gcc, which identifies itself
2521 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2522 a __builtin_isnan.
2523 * floatfns.c (isnan): #undef, and then #define to a clone of
2524 what's in data.c.
2525 (Fisnan): Always define, since it's always available now.
2526 (syms_of_floatfns): Always define isnan at the Lisp level.
2527
2528 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2529
2530 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2531
2532 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2533
2534 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2535 The previous code assumed that file offsets (off_t values) fit in
2536 EMACS_INT variables, which is not true on typical 32-bit hosts.
2537 The code messed up by falsely reporting buffer overflow in cases
2538 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2539 when "big" contains more than 2**29 bytes, even though this
2540 inserts just one byte and does not overflow the buffer.
2541 (Finsert_file_contents): Store file offsets as off_t
2542 values, not as EMACS_INT values. Check for overflow when
2543 converting between EMACS_INT and off_t. When checking for
2544 buffer overflow or for overlap, take the offsets into account.
2545 Don't use EMACS_INT for small values where int suffices.
2546 When checking for overlap, fix a typo: ZV was used where
2547 ZV_BYTE was intended.
2548 (Fwrite_region): Don't assume off_t fits into 'long'.
2549 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2550
2551 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2552
2553 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2554
2555 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2556
2557 sprintf-related integer and memory overflow issues (Bug#9412).
2558
2559 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2560 (esprintf, exprintf, evxprintf): New functions.
2561 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2562 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2563 (modify_event_symbol): Do not assume that the length of
2564 name_alist_or_stem is safe to alloca and fits in int.
2565 (Fexecute_extended_command): Likewise for function name and binding.
2566 (Frecursion_depth): Wrap around reliably on integer overflow.
2567 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2568 since some callers pass EMACS_INT values.
2569 (Fsingle_key_description): Don't crash if symbol name contains more
2570 than MAX_ALLOCA bytes.
2571 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2572 (get_minibuffer): Arg is now EMACS_INT, not int.
2573 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2574 (esprintf, exprintf, evxprintf): New decls.
2575 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2576
2577 * dbusbind.c (signature_cat): New function.
2578 (xd_signature, Fdbus_register_signal):
2579 Do not overrun buffer; instead, report string overflow.
2580
2581 * dispnew.c (add_window_display_history): Don't overrun buffer.
2582 Truncate instead; this is OK since it's just a log.
2583
2584 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2585 even if the time zone offset is outlandishly large.
2586 Don't mishandle offset == INT_MIN.
2587
2588 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2589 when creating daemon; the previous buffer-overflow check was incorrect.
2590
2591 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2592 which has the guts of the old verror function.
2593
2594 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2595 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2596
2597 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2598 (font_unparse_xlfd): Don't blindly alloca long strings.
2599 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2600 fits in int, when using sprintf. Use single snprintf to count
2601 length of string rather than counting it via multiple sprintfs;
2602 that's simpler and more reliable.
2603 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2604 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2605 sprintf, in case result does not fit in int.
2606
2607 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2608 (fontset_from_font): Print it.
2609
2610 * frame.c (tty_frame_count): Now printmax_t, not int.
2611 (make_terminal_frame, set_term_frame_name): Print it.
2612 (x_report_frame_params): In X, window IDs are unsigned long,
2613 not signed long, so print them as unsigned.
2614 (validate_x_resource_name): Check for implausibly long names,
2615 and don't assume name length fits in 'int'.
2616 (x_get_resource_string): Don't blindly alloca invocation name;
2617 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2618 not fit in int.
2619
2620 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2621 (xg_check_special_colors, xg_set_geometry):
2622 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2623
2624 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2625 Use esprintf, not sprintf, in case result does not fit in int.
2626
2627 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2628 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2629 it as a large positive number.
2630 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2631 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2632
2633 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2634 in case result does not fit in int.
2635
2636 * print.c (float_to_string): Detect width overflow more reliably.
2637 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2638 buffer overrun. Don't assume list length fits in 'int'. Treat
2639 print length of 0 as 0, not as infinity; to be consistent with other
2640 uses of print length in this function. Don't overflow print length
2641 index. Don't assume hash table size fits in 'long', or that
2642 vectorlike size fits in 'unsigned long'.
2643
2644 * process.c (make_process): Use printmax_t, not int, to format
2645 process-name gensyms.
2646
2647 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2648
2649 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2650 to avoid potential buffer overrun.
2651
2652 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2653 if X resource line is longer than 512 bytes.
2654
2655 * xfns.c (x_window): Make sprintf buffer a bit bigger
2656 to avoid potential buffer overrun.
2657
2658 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2659
2660 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2661
2662 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 Integer overflow fixes for scrolling, etc.
2665 Without these, Emacs silently mishandles large integers sometimes.
2666 For example, "C-u 4294967297 M-x recenter" was treated as if
2667 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2668
2669 * xdisp.c (try_window_id): Check Emacs fixnum range before
2670 converting to 'int'.
2671
2672 * window.c (window_scroll_line_based, Frecenter):
2673 Check that an Emacs fixnum is in range before assigning it to 'int'.
2674 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2675 values converted from Emacs fixnums.
2676 (Frecenter): Don't wrap around a line count if it is out of 'int'
2677 range; instead, treat it as an extreme value.
2678 (Fset_window_configuration, compare_window_configurations):
2679 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2680
2681 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2682 that can exceed INT_MAX. Check that EMACS_INT value is in range
2683 before assigning it to the (possibly-narrower) index.
2684 (match_limit): Don't assume that a fixnum can fit in 'int'.
2685
2686 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2687 exceed INT_MAX.
2688
2689 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2690 (Fvertical_motion): Don't wrap around LINES values that don't fit
2691 in 'int'. Instead, treat them as extreme values. This is good
2692 enough for windows, which can't have more than INT_MAX lines anyway.
2693
2694 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2695
2696 * Require libxml/parser.h to avoid compilation warning.
2697
2698 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2699
2700 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2701 since this reportedly can destroy thread storage.
2702
2703 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2704
2705 * syntax.c (find_defun_start): Update all cache variables if
2706 exiting early (Bug#9401).
2707
2708 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2709
2710 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2711
2712 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2713 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2714 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2715
2716 * term.c (tty_append_glyph): New function.
2717 (produce_stretch_glyph): Static function and its prototype deleted.
2718
2719 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2720 Add prototypes.
2721
2722 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2723
2724 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2725 when checking :margin (Bug#9390).
2726 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2727 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2728 so that the name doesn't mislead. All uses changed.
2729
2730 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2731
2732 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2733 set_tty_hooks.
2734
2735 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2736
2737 * xdisp.c (move_it_to): Don't bail out early when reaching
2738 position beyond to_charpos, if we are scanning backwards.
2739 (move_it_vertically_backward): When DY == 0, make sure we get to
2740 the first character in the line after the newline.
2741
2742 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2745 (ccl_driver): Do not generate an out-of-range pointer.
2746 (Fccl_execute_on_string): Remove unnecessary check for
2747 integer overflow, noted by Stefan Monnier in
2748 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2749 Remove a FIXME that didn't need fixing.
2750 Simplify the newly-introduced buffer reallocation code.
2751
2752 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2753
2754 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2755
2756 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2757
2758 Integer and memory overflow issues (Bug#9196).
2759
2760 * doc.c (get_doc_string): Rework so that
2761 get_doc_string_buffer_size is the actual buffer size, rather than
2762 being 1 less than the actual buffer size; this makes xpalloc more
2763 convenient.
2764
2765 * image.c (x_allocate_bitmap_record, cache_image):
2766 * xselect.c (Fx_register_dnd_atom):
2767 Simplify previous changes by using xpalloc.
2768
2769 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2770 since either will do and ptrdiff_t is convenient with xpalloc.
2771
2772 * charset.c (charset_table_size)
2773 (struct charset_sort_data.priority): Now ptrdiff_t.
2774 (charset_compare): Don't overflow if priorities differ greatly.
2775 (Fsort_charsets): Don't assume list length fits in int.
2776 Check for size-calculation overflow when allocating sort data.
2777 (syms_of_charset): Allocate an initial charset table that is
2778 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2779
2780 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2781
2782 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2783 The actual value is always <= INT_MAX, and leaving it unsigned made
2784 overflow checking harder.
2785
2786 * dispextern.h (struct glyph_matrix.rows_allocated)
2787 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2788 with xpalloc. The values are still always <= INT_MAX.
2789
2790 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2791
2792 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2793 (SAFE_NALLOCA): New macro.
2794
2795 * region-cache.c (struct boundary.pos, find_cache_boundary)
2796 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2797 (set_cache_region, invalidate_region_cache)
2798 (revalidate_region_cache, know_region_cache, region_cache_forward)
2799 (region_cache_backward, pp_cache):
2800 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2801 so that ptrdiff_t * can be passed to xpalloc.
2802 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2803 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2804 (pp_cache): Don't assume cache_len fits in int.
2805 * region-cache.h: Adjust extern decls to match.
2806
2807 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2808 EMACS_INT, since either will do, for xpalloc.
2809
2810 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2811 (xnmalloc, xnrealloc, xpalloc): New functions.
2812
2813 * bidi.c (bidi_shelve_header_size): New constant.
2814 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2815 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2816
2817 * bidi.c (bidi_cache_shrink):
2818 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2819 (overlay_strings):
2820 Don't update size of array until after memory allocation succeeds,
2821 because xmalloc/xrealloc may not return.
2822 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2823 now that we have proper integer overflow checking.
2824 (record_overlay_string, overlay_strings): Catch overflows when
2825 calculating size of overlay_str_buf.
2826
2827 * callproc.c (Fcall_process): Check for size overflow when
2828 calculating size of args2.
2829 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2830 Normally we prefer signed values, but sticking with ptrdiff_t would
2831 require adding more-complicated checks.
2832
2833 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2834 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2835 Redo buffer-overflow calculations to avoid integer overflow.
2836 Add a FIXME comment where memory seems to be over-allocated.
2837
2838 * character.c (Fstring): Check for size-calculation overflow.
2839
2840 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2841 unnecessary integer overflow. Check for size overflow.
2842 (encode_coding_object): Don't update size until xmalloc succeeds.
2843
2844 * composite.c (get_composition_id): Check for overflow in glyph
2845 length calculations.
2846
2847 Integer and memory overflow fixes for display code.
2848 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2849 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2850 (scrolling_window): Check for overflow in size calculations.
2851 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2852 Don't assume glyph table len fits in int.
2853 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2854 (row_table_size): Now ptrdiff_t, not int.
2855 (scrolling_window): Avoid overflow in size calculations.
2856 Don't update size until allocation succeeds.
2857 * fns.c (concat): Check for overflow in size calculations.
2858 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2859 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2860 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2861
2862 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2863 (get_doc_string): Check for size calculation overflow.
2864 Don't update size until allocation succeeds.
2865 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2866 EMACS_INT, where ptrdiff_t will do.
2867 (Fsubstitute_command_keys): Check for string overflow.
2868
2869 * editfns.c (set_time_zone_rule): Don't assume environment length
2870 fits in int.
2871 (message_length): Now ptrdiff_t, not int.
2872 (Fmessage_box): Don't update size until allocation succeeds.
2873 Don't assume message length fits in int.
2874 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2875
2876 * emacs.c (main): Do not reallocate argv, since there is a null at
2877 the end that can be overwritten, and this way there's no need to
2878 worry about size-calculation overflow.
2879 (sort_args): Check for size-calculation overflow.
2880
2881 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2882 alloc succeeds.
2883 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2884
2885 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2886 (x_set_scroll_bar_width, x_figure_window_size):
2887 Check for integer overflow.
2888 (x_set_alpha): Do not assume XINT fits in int.
2889
2890 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2891 This is for the members text_lines, text_cols, total_lines, total_cols,
2892 where the system imposes an 'int' limit.
2893
2894 * fringe.c (Fdefine_fringe_bitmap):
2895 Don't update size until alloc works.
2896
2897 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2898 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2899
2900 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2901 Check for size-calculation overflow.
2902 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2903 do, as we prefer signed integers.
2904 (id_to_widget.max_size, id_to_widget.used)
2905 (xg_store_widget_in_map, xg_remove_widget_from_map)
2906 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2907 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2908 Use and return ptrdiff_t, not int.
2909 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2910 * gtkutil.h: Change prototypes to match the above.
2911
2912 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2913 are duplicate now that they've been promoted to lisp.h.
2914 (x_allocate_bitmap_record, x_alloc_image_color)
2915 (make_image_cache, cache_image, xpm_load):
2916 Don't update size until alloc is done.
2917 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2918 (x_detect_edges):
2919 Check for size calculation overflow.
2920 (ct_colors_allocated_max): New constant.
2921 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2922 overflow.
2923
2924 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2925 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2926 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2927 Use ptrdiff_t, not int, to count maps.
2928 (read_char_minibuf_menu_prompt): Check for overflow in size
2929 calculations. Don't update size until allocation succeeds.
2930 Redo calculations to avoid overflow.
2931 * keyboard.h: Change prototypes to match the above.
2932
2933 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2934 to count maps.
2935 (current_minor_maps): Check for size calculation overflow.
2936 * keymap.h: Change prototypes to match the above.
2937
2938 * lread.c (read1, init_obarray): Don't update size until alloc done.
2939
2940 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2941 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2942
2943 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2944 Now ptrdiff_t, not int.
2945 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2946 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2947
2948 * process.c (Fnetwork_interface_list): Check for overflow
2949 in size calculation.
2950
2951 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2952
2953 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2954 overflow. Don't bother calling xmalloc when xrealloc will do.
2955
2956 * search.c (Freplace_match): Check for size calculation overflow.
2957 (Fset_match_data): Don't assume list lengths fit in 'int'.
2958
2959 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2960 for command line length. Do not attempt to address one before the
2961 beginning of an array, as that's not portable.
2962
2963 * term.c (max_frame_lines): Remove; unused.
2964 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2965 not int.
2966 (encode_terminal_code, calculate_costs): Check for size
2967 calculation overflow.
2968 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2969 table lengths and related sizes. Don't update size until alloc
2970 done. Redo calculations to avoid overflow.
2971 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2972
2973 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2974 subtracting pointers.
2975 (gobble_line): Check for overflow more carefully. Don't update size
2976 until alloc done.
2977
2978 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2979 Don't update size until alloc done.
2980 Redo size calculations to avoid overflow.
2981 Check for size calculation overflow.
2982 (main) [DEBUG]: Fix typo in invoking tparam1.
2983
2984 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2985 Use ptrdiff_t, not int, for sizes.
2986 (store_mode_line_noprop_char): Don't update size until alloc done.
2987
2988 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2989 Use ptrdiff_t, not int, for sizes.
2990 (Finternal_make_lisp_face, cache_face):
2991 Check for size calculation overflow.
2992 (cache_face): Treat size calculation overflows as if they were
2993 memory exhaustion (the usual treatment), rather than aborting.
2994
2995 * xfns.c (x_encode_text, x_set_name_internal)
2996 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2997 sizes, since they can exceed INT_MAX in size. Check for size
2998 calculation overflow.
2999
3000 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3001 (xg_select): Check for size calculation overflow.
3002 Don't update size until alloc done.
3003
3004 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3005 as sprintf is limited to int lengths.
3006
3007 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3008 (X_LONG_MIN): New macros.
3009 Use them to make the following changes clearer.
3010 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3011 This change doesn't affect the value now, but it may help remind
3012 future maintainers not to raise the value too much later.
3013 (SELECTION_QUANTUM): Remove, replacing with ...
3014 (selection_quantum): ... new function, which avoids overflow.
3015 All uses changed.
3016 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3017 assumption that selection length fits in 'int'.
3018 (x_reply_selection_request, x_handle_selection_request)
3019 (x_get_window_property, receive_incremental_selection)
3020 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3021 (lisp_data_to_selection_data, clean_local_selection_data):
3022 Use ptrdiff_t, not int, to record length of selection.
3023 (x_reply_selection_request, x_get_window_property)
3024 (receive_incremental_selection, x_property_data_to_lisp):
3025 Redo calculations to avoid overflow.
3026 (x_reply_selection_request): When sending hint, ceiling it at
3027 X_LONG_MAX rather than relying on wraparound overflow to send
3028 something.
3029 (x_get_window_property, receive_incremental_selection)
3030 (lisp_data_to_selection_data, x_property_data_to_lisp):
3031 Check for size-calculation overflow.
3032 (x_get_window_property, receive_incremental_selection)
3033 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3034 Don't store size until memory allocation succeeds.
3035 (x_get_window_property): Plug memory leak on memory exhaustion.
3036 Don't double-block input; malloc is safe here. Don't assume 2**34
3037 - 4 fits in unsigned long. Add an xassert to check
3038 XGetWindowProperty overflow. Be more careful about overflow
3039 calculations, and distinguish size from memory overflow better.
3040 (receive_incremental_selection): When tracing, don't assume
3041 unsigned int is less than INT_MAX.
3042 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3043 harmful) conversions of unsigned short to int.
3044 (lisp_data_to_selection_data): Don't assume that integers
3045 in the range -65535 through -1 fit in an X unsigned short.
3046 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3047 result parameters unless successful. Rely on cons_to_unsigned
3048 to report problems with elements; the old code wasn't right anyway.
3049 (x_check_property_data): Check for int overflow; we cannot use
3050 a wider type due to X limits.
3051 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3052
3053 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3054
3055 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3056 (x_term_init): Check for size calculation overflow.
3057 (x_color_cells): Don't store size until memory allocation succeeds.
3058 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3059 Don't assume alloca size is less than MAX_ALLOCA.
3060 (x_term_init): Don't assume length fits in int (sprintf is limited
3061 to int size).
3062
3063 Use ptrdiff_t for composition IDs.
3064 * character.c (lisp_string_width):
3065 * composite.c (composition_table_size, n_compositions)
3066 (get_composition_id, composition_gstring_from_id):
3067 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3068 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3069 * window.c (Frecenter):
3070 Use ptrdiff_t, not int, for composition IDs.
3071 * composite.c (get_composition_id): Check for integer overflow.
3072 * composite.h: Adjust prototypes to match the above changes.
3073
3074 Use ptrdiff_t for hash table indexes.
3075 * category.c (hash_get_category_set):
3076 * ccl.c (ccl_driver):
3077 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3078 * coding.c (coding_system_charset_list, detect_coding_system):
3079 * coding.h (struct coding_system.id):
3080 * composite.c (get_composition_id, gstring_lookup_cache):
3081 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3082 * image.c (xpm_get_color_table_h):
3083 * lisp.h (hash_lookup, hash_put):
3084 * minibuf.c (Ftest_completion):
3085 Use ptrdiff_t for hash table indexes, not int (which is too
3086 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3087 32-bit --with-wide-int hosts).
3088
3089 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3090 Add a FIXME comment about memory leaks.
3091 (syms_of_charset): Don't assume xmalloc returns.
3092
3093 Don't assume that stated character widths fit in int.
3094 * character.c (Fchar_width, c_string_width, lisp_string_width):
3095 * character.h (CHAR_WIDTH):
3096 * indent.c (MULTIBYTE_BYTES_WIDTH):
3097 Use sanitize_char_width to avoid undefined and/or bad behavior
3098 with outlandish widths.
3099 * character.h (sanitize_tab_width): Rename from sanitize_width,
3100 now that we have two such functions. All uses changed.
3101 (sanitize_char_width): New inline function.
3102
3103 Don't assume that tab-width fits in int.
3104 * character.h (sanitize_width): New inline function.
3105 (SANE_TAB_WIDTH): New macro.
3106 (ASCII_CHAR_WIDTH): Use it.
3107 * indent.c (sane_tab_width): Remove. All uses replaced by
3108 SANE_TAB_WIDTH (current_buffer).
3109 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3110
3111 * fileio.c: Integer overflow issues with file modes.
3112 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3113
3114 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3115 Remove unreachable code.
3116 (read_hex, load_charset_map_from_file): Check for integer overflow.
3117
3118 * xterm.c: Don't go over XClientMessageEvent limit.
3119 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3120 (x_send_scroll_bar_event): Likewise. Check that the size does not
3121 exceed limits imposed by XClientMessageEvent, as well as the usual
3122 ptrdiff_t and size_t limits.
3123
3124 * keyboard.c: Overflow, signedness and related fixes.
3125 (make_lispy_movement): Use same integer type in forward decl
3126 that is used in the definition.
3127 (read_key_sequence, keyremap_step):
3128 Change bufsize argument back to int, undoing my 2011-03-30 change.
3129 We prefer signed types, and int is wide enough here.
3130 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3131 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3132 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3133 length, not size_t. Use ptrdiff_t for index, not int.
3134 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3135 possibility of integer overflow.
3136
3137 Overflow, signedness and related fixes for images.
3138
3139 * dispextern.h (struct it.stack[0].u.image.image_id)
3140 (struct_it.image_id, struct image.id, struct image_cache.size)
3141 (struct image_cache.used, struct image_cache.ref_count):
3142 * gtkutil.c (update_frame_tool_bar):
3143 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3144 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3145 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3146 * nsmenu.m (update_frame_tool_bar):
3147 * xdisp.c (calc_pixel_width_or_height):
3148 * xfns.c (image_cache_refcount):
3149 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3150 on typical 64-bit hosts.
3151
3152 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3153 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3154 Omit unnecessary casts to int.
3155 (parse_image_spec): Check that integers fall into 'int' range
3156 when the callers expect that.
3157 (image_ascent): Redo ascent calculation to avoid int overflow.
3158 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3159 (lookup_image): Remove unnecessary tests.
3160 (xbm_image_p): Locals are now of int, not EMACS_INT,
3161 since parse_image_check makes sure they fit into int.
3162 (png_load, gif_load, svg_load_image):
3163 Prefer int to unsigned where either will do.
3164 (tiff_handler): New function, combining the cores of the
3165 old tiff_error_handler and tiff_warning_handler.
3166 This function is rewritten to use vsnprintf and thereby avoid
3167 stack buffer overflows. It uses only the features of vsnprintf
3168 that are common to both POSIX and native Microsoft.
3169 (tiff_error_handler, tiff_warning_handler): Use it.
3170 (tiff_load, gif_load, imagemagick_load_image):
3171 Don't assume :index value fits in 'int'.
3172 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3173 (imagemagick_load_image): Check that crop parameters fit into
3174 the integer types that MagickCropImage accepts. Don't assume
3175 Vimagemagick_render_type has a nonnegative value. Don't assume
3176 size_t fits in 'long'.
3177 (gs_load): Use printmax_t to print the widest integers possible.
3178 Check for integer overflow when computing image height and width.
3179
3180 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3181
3182 * xdisp.c (redisplay_window): Don't force window start if point
3183 will be invisible in the resulting window. (Bug#9324)
3184
3185 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3186
3187 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3188 the display spec is of the form `(space ...)'.
3189 (handle_display_spec): Return the value returned by
3190 handle_single_display_spec, not just 1 or zero.
3191 (handle_single_display_spec): If the display spec is of the form
3192 `(space ...)', and specifies display in the text area, return 2
3193 rather than 1.
3194 (try_cursor_movement): Check for the need to scroll more
3195 accurately, and prefer exact match for point under bidi.
3196 Don't advance `row' beyond the last row of the window.
3197
3198 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3199 into disp_prop; all users changed.
3200
3201 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3202 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3203 for the text covered by the display property.
3204
3205 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3206
3207 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3208 Change return value to nil.
3209 (Frecord_buffer): Delete unused function.
3210
3211 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3212
3213 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3214 buffers, return left-to-right.
3215 (set_cursor_from_row): Consider candidate row a win if its glyph
3216 represents a newline and point is on that newline. Fixes cursor
3217 positioning on the newline at EOL of R2L text within L2R
3218 paragraph, and vice versa.
3219 (try_cursor_movement): Check continued rows, in addition to
3220 continuation rows. Fixes unwarranted scroll when point enters a
3221 continued line of R2L text within an L2R paragraph, or vice versa.
3222 (cursor_row_p): Consider the case of point being equal to
3223 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3224 from the end of a short line to the beginning of a continued line
3225 of R2L text within L2R paragraph.
3226 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3227 composed characters.
3228
3229 * bidi.c (bidi_check_type): Use xassert.
3230 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3231 members.
3232
3233 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3234
3235 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3236 a character.
3237
3238 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3239
3240 * nsfont.m (ns_otf_to_script): Fix typo.
3241
3242 2011-08-22 Kenichi Handa <handa@m17n.org>
3243
3244 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3245 extra slot even if the purpose is char-code-property-table.
3246
3247 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3248
3249 * xdisp.c (redisplay_window): When computing centering_position,
3250 account for the height of the header line. (Bug#8874)
3251
3252 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3253 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3254 candidate is selected by the mouse, and that candidate has a
3255 composed character under the mouse.
3256
3257 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3258 coordinates reported by pos-visible-in-window-p for a composed
3259 character in column zero.
3260
3261 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3262
3263 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3264
3265 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3266
3267 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3268 consider it a hit if to_charpos is anywhere in the range of the
3269 composed buffer positions.
3270
3271 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3272
3273 * image.c (gif_load): Don't assume that each subimage has the same
3274 dimensions as the base image. Handle disposal method that is
3275 "undefined" by the gif spec (Bug#9335).
3276
3277 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3278
3279 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3280 (Fcondition_case): Document `debug' symbol in error handler.
3281
3282 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3283
3284 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3285 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3286 from an Org mode buffer to a Speedbar frame.
3287
3288 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3289 a composition, take its buffer position from IT->cmp_it.charpos.
3290 Fixes cursor positioning at the beginning of a line that begins
3291 with a composed character.
3292
3293 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3294
3295 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3296 character bidirectional type, use STRONG_L instead. Fixes crashes
3297 in a buffer produced by `describe-categories'.
3298
3299 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3300 members before the level stack, so they would be saved and
3301 restored when copying iterator state. Fixes incorrect reordering
3302 around TABs covered by display properties.
3303
3304 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3305
3306 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3307
3308 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3309
3310 * eval.c (internal_condition_case, internal_condition_case_1)
3311 (internal_condition_case_2, internal_condition_case_n):
3312 Remove unnecessary aborts (Bug#9081).
3313
3314 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3315
3316 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3317 has no `load' handler, try opening the file locally. (Bug#9311)
3318
3319 2011-08-16 Ken Brown <kbrown@cornell.edu>
3320
3321 * gmalloc.c: Expand comment.
3322
3323 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3324
3325 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3326 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3327
3328 2011-08-16 Ken Brown <kbrown@cornell.edu>
3329
3330 Fix memory allocation problems in Cygwin build (Bug#9273).
3331
3332 * unexcw.c ( __malloc_initialized): Declare external variable.
3333 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3334
3335 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3336 New variables.
3337 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3338 dumped emacs.
3339 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3340 in the static heap.
3341 [CYGWIN] (special_realloc): New function.
3342 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3343 requests to realloc storage in the static heap.
3344
3345 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3346
3347 * bidi.c (bidi_initialize): Remove unused local.
3348
3349 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3350
3351 * bidimirror.h:
3352 * biditype.h: Remove file.
3353 * makefile.w32-in ($(BLD)/bidi.$(O)):
3354 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3355
3356 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3357
3358 * chartab.c: Improve commentary for the uniprop_table API.
3359
3360 * bidi.c (bidi_paragraph_init): Support zero value of
3361 bidi_ignore_explicit_marks_for_paragraph_level.
3362 (bidi_initialize): Use uniprop_table instead of including
3363 biditype.h and bidimirror.h.
3364
3365 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3366 coordinates of the iterator when restoring from ppos_it.
3367 (Bug#9296)
3368
3369 2011-08-14 Kenichi Handa <handa@m17n.org>
3370
3371 * process.c (create_process): Call setup_process_coding_systems
3372 after the pid of the process is set to -1 (Bug#8162).
3373
3374 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3375
3376 * xdisp.c (move_it_in_display_line_to): Don't invoke
3377 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3378 ppos_it. Fixes vertical cursor motion when line beginning is
3379 covered by an image. (Bug#9296)
3380
3381 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3382
3383 * nsterm.h (ns_run_ascript): Declare.
3384 (NSAPP_DATA2_RUNASSCRIPT): Define.
3385
3386 * nsfns.m (as_script, as_result, as_status): New static variables.
3387 (ns_run_ascript): New function.
3388 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3389 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3390 the event loop. Get status from as_status (Bug#7276).
3391
3392 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3393 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3394 the event loop (Bug#7276).
3395
3396 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3397
3398 * gnutls.c (QCgnutls_bootprop_priority)
3399 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3400 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3401 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3402 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3403 (QCgnutls_bootprop_verify_hostname_error)
3404 (QCgnutls_bootprop_callbacks_verify): Rename from
3405 Qgnutls_bootprop_..., all uses changed.
3406
3407 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3408 uses changed.
3409
3410 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3411
3412 * xfaces.c (Qframe_set_background_mode): Now static.
3413 * dispextern.h (Qframe_set_background_mode): Remove decl.
3414
3415 * process.c (Fnetwork_interface_info): Declare local only if needed.
3416
3417 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3418
3419 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3420 (Fnetwork_interface_list): Allocate in increments of bytes instead
3421 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3422 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3423 sockaddr.
3424 (struct ifflag_def): notrailers is smart on OSX.
3425 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3426 Get hardware address with getifaddrs if available.
3427
3428 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3429
3430 * xdisp.c (iterate_out_of_display_property): xassert that
3431 IT->position is set to within IT->object's boundaries. Break from
3432 the loop as soon as EOB is reached; avoids infloops in redisplay
3433 when IT->position is set up wrongly due to some bug.
3434 Set IT->current to match the bidi iterator unconditionally.
3435 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3436 entry. Force push_it to save on the stack the current
3437 buffer/string position, to be restored by pop_it. Fix flags in
3438 the iterator structure wrt the object coming from a display
3439 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3440 properties. (Bug#9284)
3441
3442 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3443
3444 * fontset.c (fontset_get_font_group): Add proper type checks.
3445 (Bug#9172)
3446
3447 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3448
3449 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3450 and LC_VERSION_MIN_MACOSX.
3451 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3452 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3453
3454 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3455
3456 * xdisp.c (forward_to_next_line_start): Allow to use the
3457 no-display-properties-and-no-overlays under bidi display.
3458 Set disp_pos in the bidi iterator to avoid searches for display
3459 properties and overlays.
3460
3461 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3462
3463 * editfns.c (Fset_time_zone_rule): Document relationship with the
3464 setenv function.
3465
3466 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3467 the font entity extracted from the cache (Bug#8109).
3468
3469 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3470
3471 * composite.c (autocmp_chars): Don't reset point. That is done by
3472 restore_point_unwind (Bug#5984).
3473
3474 2011-08-07 Juri Linkov <juri@jurta.org>
3475
3476 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3477 to show the arg `TIME' instead of `TIMEVAL'.
3478
3479 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3480
3481 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3482 display property strides EOL and includes a newline, as in
3483 longlines-mode. (Bug#9254)
3484 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3485 word-wrap under bidirectional display. (Bug#9224)
3486
3487 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3488 is non-zero, even if the data buffer is NULL. Fixes a crash in
3489 vertical-motion with longlines-mode. (Bug#9254)
3490
3491 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3492
3493 * bidi.c <bidi_cache_total_alloc>: Now static.
3494 (bidi_initialize): Initialize bidi_cache_total_alloc.
3495
3496 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3497 cache. (Bug#9221)
3498
3499 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3500 amount allocated this far in `bidi_cache_total_alloc'.
3501 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3502 non-zero, only free the data buffer without restoring the cache
3503 contents. All callers changed.
3504
3505 * dispextern.h (bidi_unshelve_cache): Update prototype.
3506
3507 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3508 (move_it_in_display_line, move_it_to)
3509 (move_it_vertically_backward, move_it_by_lines): Replace the call
3510 to xfree to an equivalent call to bidi_unshelve_cache.
3511 (move_it_in_display_line_to): Fix logic of returning
3512 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3513
3514 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3515
3516 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3517 came from a string character with a `cursor' property. (Bug#9229)
3518
3519 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3520
3521 * Makefile.in (LIB_PTHREAD): New variable.
3522 (LIBES): Add LIB_PTHREAD (Bug#9216).
3523
3524 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3525 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3526
3527 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3528
3529 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3530
3531 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3532
3533 * xterm.c (x_find_topmost_parent): New function.
3534 (x_set_frame_alpha): Find topmost parent window with
3535 x_find_topmost_parent and set the property there also (bug#9181).
3536 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3537
3538 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3539
3540 * callproc.c (Fcall_process): Avoid vfork clobbering
3541 the local vars buffer, coding_systems, current_dir.
3542
3543 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3544
3545 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3546
3547 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3548
3549 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3550 so that it is not optimized away.
3551
3552 * xdisp.c (compute_display_string_pos): Remove unused local.
3553
3554 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3555
3556 Fix slow cursor motion and scrolling in large buffers with
3557 selective display, like Org Mode buffers. (Bug#9218)
3558
3559 * dispextern.h (struct bidi_it): New member disp_prop_p.
3560
3561 * xdisp.c: Remove one-slot cache of display string positions.
3562 (compute_display_string_pos): Accept an additional argument
3563 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3564 for a display string or property. If found, set DISP_PROP_P
3565 non-zero.
3566
3567 * bidi.c (bidi_fetch_char): Accept an additional argument
3568 DISP_PROP_P, and pass it to compute_display_string_pos.
3569 Only handle text covered by a display string if DISP_PROP_P is returned
3570 non-zero. All callers of bidi_fetch_char changed.
3571
3572 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3573
3574 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3575
3576 2010-12-03 Don March <don@ohspite.net>
3577
3578 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3579 last character M-[char] is translated to ESC [char] (bug#7541).
3580
3581 2011-08-02 Kenichi Handa <handa@m17n.org>
3582
3583 * lisp.h (uniprop_table): Extern it.
3584
3585 * chartab.c (uniprop_table): Make it non-static.
3586
3587 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3588
3589 * xdisp.c (forward_to_next_line_start): Accept additional argument
3590 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3591 on the newline.
3592 (reseat_at_next_visible_line_start): Use the bidi iterator state
3593 returned by forward_to_next_line_start to restore the state of
3594 it->bidi_it after backing up to previous newline. (Bug#9212)
3595
3596 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3597
3598 * regex.c (re_comp): Protoize.
3599 (re_exec): Fix return type.
3600 (regexec): Fix type of `ret'. (Bug#9203)
3601
3602 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3605 This is needed if max-image-size is a floating-point number.
3606
3607 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3608
3609 * print.c (print_object): Print empty symbol as ##.
3610
3611 * lread.c (read1): Read ## as empty symbol.
3612
3613 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3614
3615 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3616 setting frame foreground color (Bug#9175).
3617 (x_set_background_color): Likewise.
3618
3619 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3620 contents (Bug#9176).
3621 (EmacsTooltip -init): Remove bezels and add shadows to
3622 tooltip windows.
3623
3624 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3625 or scroll bar (Bug#8470).
3626
3627 * nsfont.m (nsfont_open): Remove assignment to voffset and
3628 unnecessary vars hshink, expand, hd, full_height, min_height.
3629 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3630
3631 * nsterm.h (nsfont_info): Remove voffset field.
3632
3633 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3634
3635 Implement strike-through and overline on NextStep (Bug#8863).
3636
3637 * nsfont.m (nsfont_open): Use underline position provided by font,
3638 instead of hard-coded value of 2.
3639 (nsfont_draw): Call ns_draw_text_decoration instead.
3640
3641 * nsterm.h: Add declaration for ns_draw_text_decoration.
3642
3643 * nsterm.m (ns_draw_text_decoration): New function for drawing
3644 underline, overline, and strike-through.
3645 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3646 ns_draw_text_decoration. Change treatment of cursor drawing to
3647 accommodate underlining, etc.
3648
3649 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3650
3651 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3652 default.
3653
3654 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3655
3656 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3657 Without this fix, if a signal arrives just after memory fills up,
3658 'malloc' might be invoked reentrantly.
3659
3660 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3661 In other words, assume that every image size is allowed, on non-X
3662 hosts. This assumption is probably wrong, but it lets Emacs compile.
3663
3664 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3665
3666 * regex.c (re_iswctype): Convert return values to boolean.
3667
3668 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3669
3670 * xdisp.c (compute_display_string_pos): Don't use cached display
3671 string position if the buffer had its restriction changed.
3672 (Bug#9184)
3673
3674 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3677
3678 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3679
3680 Integer signedness and overflow and related fixes. (Bug#9079)
3681
3682 * bidi.c: Integer size and overflow fixes.
3683 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3684 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3685 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3686 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3687 (bidi_find_other_level_edge):
3688 Use ptrdiff_t instead of EMACS_INT where either will do.
3689 This works better on 32-bit hosts configured --with-wide-int.
3690 (bidi_cache_ensure_space): Check for size-calculation overflow.
3691 Use % rather than repeated addition, for better worst-case speed.
3692 Don't set bidi_cache_size until after xrealloc returns, because it
3693 might not return.
3694 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3695 (bidi_cache_ensure_space): Also check that the bidi cache size
3696 does not exceed that of the largest Lisp string or buffer. See Eli
3697 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3698
3699 * alloc.c (__malloc_size_t): Remove.
3700 All uses replaced by size_t. See Andreas Schwab's note
3701 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3702
3703 * image.c: Improve checking for integer overflow.
3704 (check_image_size): Assume that f is nonnull, since
3705 it is always nonnull in practice. This is one less thing to
3706 worry about when checking for integer overflow later.
3707 (x_check_image_size): New function, which checks for integer
3708 overflow issues inside X.
3709 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3710 This removes the need for a memory_full check.
3711 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3712 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3713 (xbm_read_bitmap_data): Change locals back to 'int', since
3714 their values must fit in 'int'.
3715 (xpm_load_image, png_load, tiff_load):
3716 Invoke x_create_x_image_and_pixmap earlier,
3717 to avoid much needless work if the image is too large.
3718 (tiff_load): Treat overly large images as if
3719 x_create_x_image_and_pixmap failed, not as malloc failures.
3720 (gs_load): Use x_check_image_size.
3721
3722 * gtkutil.c: Omit integer casts.
3723 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3724 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3725
3726 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3727
3728 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3729 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3730 would wrongly return t on a 64-bit host.
3731
3732 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3733 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3734 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3735 and therefore cause GCC to emit a bogus diagnostic in some cases.
3736
3737 * image.c: Integer signedness and overflow and related fixes.
3738 This is not an exhaustive set of fixes, but it's time to
3739 record what I've got.
3740 (lookup_pixel_color, check_image_size): Remove redundant decls.
3741 (check_image_size): Don't assume that arbitrary EMACS_INT values
3742 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3743 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3744 (tiff_load, imagemagick_load_image):
3745 Check for overflow in size calculations.
3746 (x_create_x_image_and_pixmap): Remove unnecessary test for
3747 xmalloc returning NULL; that can't happen.
3748 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3749 (xpm_color_bucket): Use better integer hashing function.
3750 (xpm_cache_color): Don't possibly over-allocate memory.
3751 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3752 (gif_memory_source):
3753 Use ptrdiff_t, not int or size_t, to record sizes.
3754 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3755 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3756 either works, as we prefer signed integers.
3757 (tiff_read_from_memory, tiff_write_from_memory):
3758 Return tsize_t, not size_t, since that's what the TIFF API wants.
3759 (tiff_read_from_memory): Don't fail simply because the read would
3760 go past EOF; instead, return a short read.
3761 (tiff_load): Omit no-longer-needed casts.
3762 (Fimagemagick_types): Don't assume size fits into 'int'.
3763
3764 Improve hashing quality when configured --with-wide-int.
3765 * fns.c (hash_string): New function, taken from sxhash_string.
3766 Do not discard information about ASCII character case; this
3767 discarding is no longer needed.
3768 (sxhash-string): Use it. Change sig to match it. Caller changed.
3769 * lisp.h: Declare it.
3770 * lread.c (hash_string): Remove, since we now use fns.c's version.
3771 The fns.c version returns a wider integer if --with-wide-int is
3772 specified, so this should help the quality of the hashing a bit.
3773
3774 * emacs.c: Integer overflow minor fix.
3775 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3776 Define only if GNU_LINUX.
3777 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3778
3779 * dispnew.c: Integer signedness and overflow fixes.
3780 Remove unnecessary forward decls, that were a maintenance hassle.
3781 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3782 All uses changed.
3783 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3784 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3785 (prepare_desired_row, line_draw_cost):
3786 Use int, not unsigned, where either works.
3787 (save_current_matrix, restore_current_matrix):
3788 Use ptrdiff_t, not size_t, where either works.
3789 (init_display): Check for overflow more accurately, and without
3790 relying on undefined behavior.
3791
3792 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3793 Remove, replacing with the new symbols in lisp.h. All uses changed.
3794 * fileio.c (make_temp_name):
3795 * filelock.c (lock_file_1, lock_file):
3796 * xdisp.c (message_dolog):
3797 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3798 Use pMd etc. instead.
3799 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3800 replacing the pWIDE etc. symbols removed from editfns.c.
3801
3802 * keyboard.h (num_input_events): Now uintmax_t.
3803 This is (very slightly) less likely to mess up due to wraparound.
3804 All uses changed.
3805
3806 * buffer.c: Integer signedness fixes.
3807 (alloc_buffer_text, enlarge_buffer_text):
3808 Use ptrdiff_t rather than size_t when either will do, as we prefer
3809 signed integers.
3810
3811 * alloc.c: Integer signedness and overflow fixes.
3812 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3813 (__malloc_size_t): Default to size_t, not to int.
3814 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3815 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3816 Prefer ptrdiff_t to size_t when either would do, as we prefer
3817 signed integers.
3818 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3819 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3820 Now const. Initialize with values that are in range even if char
3821 is signed.
3822 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3823 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3824 These functions do the right thing with sizes > 2**32.
3825 (check_depth): Now ptrdiff_t, not int.
3826 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3827 Adjust to new way of storing sizes. Check for size overflow bugs
3828 in rest of code.
3829 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3830 slightly wrong anyway, as it missed one instance of
3831 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3832 (refill_memory_reserve): Omit needless cast to size_t.
3833 (mark_object_loop_halt): Mark as externally visible.
3834
3835 * xselect.c: Integer signedness and overflow fixes.
3836 (Fx_register_dnd_atom, x_handle_dnd_message):
3837 Use ptrdiff_t, not size_t, since we prefer signed.
3838 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3839 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3840 x_dnd_atoms_size and x_dnd_atoms_length.
3841
3842 * doprnt.c: Prefer signed to unsigned when either works.
3843 * eval.c (verror):
3844 * doprnt.c (doprnt):
3845 * lisp.h (doprnt):
3846 * xdisp.c (vmessage):
3847 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3848 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3849 prefer signed arithmetic to avoid comparison confusion.
3850 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3851 but is a bit tricky.
3852
3853 Assume freestanding C89 headers, string.h, stdlib.h.
3854 * data.c, doprnt.c, floatfns.c, print.c:
3855 Include float.h unconditionally.
3856 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3857 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3858 * regex.c: Likewise for stddef.h, string.h.
3859 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3860 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3861 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3862 (STDC_HEADERS): Remove obsolete defines.
3863 * sysdep.c: Include limits.h unconditionally.
3864
3865 Assume support for memcmp, memcpy, memmove, memset.
3866 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3867 * regex.c (memcmp, memcpy):
3868 Remove; we assume C89 now.
3869
3870 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3871 (__malloc_safe_bcopy): Remove; no longer needed.
3872
3873 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3874 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3875 well either way, and we prefer signed to unsigned.
3876
3877 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3878
3879 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3880 closes the connection while we're reading (bug#9182).
3881
3882 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3883
3884 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3885 are specified (Bug#9168).
3886
3887 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3888
3889 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3890 Found by GCC static checking and --with-wide-int on a 32-bit host.
3891
3892 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3893
3894 * xdisp.c (compute_display_string_pos): Fix logic of caching
3895 previous display string position. Initialize cached_prev_pos to
3896 -1. Fixes slow-down at the beginning of a buffer.
3897
3898 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3899
3900 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3901 for attrs[LFACE_FONTSET_INDEX].
3902
3903 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 * xml.c (parse_region): Remove unused local
3906 that was recently introduced.
3907
3908 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3909
3910 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3911 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3912
3913 * xdisp.c (move_it_in_display_line_to): Record the best matching
3914 position for TO_CHARPOS while scanning the line, and restore it on
3915 exit if none of the characters scanned was an exact match.
3916 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3917 when exact match is impossible due to invisible text, and the
3918 lines are truncated.
3919
3920 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3921
3922 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3923 for OSX >= 10.7.
3924
3925 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3926
3927 Fix a significant slow-down of cursor motion with C-n, C-p,
3928 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3929 auto-repeat under bidi redisplay in fontified buffers.
3930 * xdisp.c (compute_stop_pos_backwards): New function.
3931 (next_element_from_buffer): Call compute_stop_pos_backwards to
3932 find a suitable prev_stop when we find ourselves before
3933 base_level_stop.
3934 (reseat): Don't look for prev_stop, as that could mean a very long
3935 run.
3936 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3937 <cached_disp_overlay_modiff>: Cache for last found display string
3938 position.
3939 (compute_display_string_pos): Return the cached position if asked
3940 about the same buffer in the same area of character positions, and
3941 the buffer wasn't changed since the time the display string
3942 position was cached.
3943
3944 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3945
3946 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3947 is an integer, which is important for empty lines. (Bug#9149)
3948
3949 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3950
3951 * frame.c (Fmodify_frame_parameters): In tty case, update the
3952 default face if necessary (Bug#4238).
3953
3954 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3955
3956 * editfns.c (Fstring_to_char): No need to explain what a character
3957 is in the docstring (Bug#6576).
3958
3959 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3960
3961 * xml.c (parse_region): Make sure we always return a tree.
3962
3963 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3964
3965 * xml.c (parse_region): If a document contains only comments,
3966 return that, too.
3967
3968 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3969
3970 * xml.c (make_dom): Return comments, too.
3971
3972 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 Port to OpenBSD.
3975 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3976 and the surrounding thread.
3977 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3978 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3979 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3980 timer goes off.
3981 * s/openbsd.h (BROKEN_SIGIO): Define.
3982 * unexelf.c (unexec) [__OpenBSD__]:
3983 Don't update the .mdebug section of the Alpha COFF symbol table.
3984
3985 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3986
3987 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3988 (bug#8460).
3989
3990 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3991
3992 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3993 This fixes some race conditions on the permissions of any newly
3994 created file.
3995
3996 * alloc.c (valid_pointer_p): Use pipe, not open.
3997 This fixes some permissions issues when debugging.
3998
3999 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4000 If fchown fails to set both uid and gid, try to set just gid,
4001 as that is sometimes allowed. Adjust the file's mode to eliminate
4002 setuid or setgid bits that are inappropriate if fchown fails.
4003
4004 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4005
4006 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4007 to compare Lisp_Objects.
4008 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4009 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4010 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4011
4012 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4013
4014 * lread.c (read_integer): Unread even EOF character.
4015 (read1): Likewise. Properly record start position of symbol.
4016
4017 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4018 symbol character follows.
4019
4020 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4023 This works around a problem with the previous change to Fcopy_file.
4024 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4025 and without this change, GCC might complain about discarding
4026 fchown's return value.
4027
4028 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4029
4030 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4031
4032 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4033
4034 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4035
4036 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4037
4038 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4039 it's used from the C level.
4040
4041 * process.c: Use the same condition for POLL_FOR_INPUT in both
4042 keyboard.c and process.c (bug#1858).
4043
4044 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4045
4046 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4047 (Fgnutls_boot): Use it.
4048
4049 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4050
4051 * doc.c (Fsubstitute_command_keys): Revert last change.
4052
4053 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4054
4055 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4056 quotes the next character, and doesn't affect other longer
4057 sequences (bug#8935).
4058
4059 * lread.c (syms_of_lread): Clarify that is isn't only
4060 `eval-buffer' and `eval-defun' that's affected by
4061 `lexical-binding' (bug#8460).
4062
4063 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4064
4065 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4066 bidi redisplay when a line includes both an image and is truncated.
4067
4068 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4069
4070 Fix minor problems found by static checking.
4071 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4072 (elsz): Now a signed constant, not a size_t var. We prefer signed
4073 types to unsigned, to avoid integer comparison confusion. Without
4074 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4075 "cannot optimize loop, the loop counter may overflow", a symptom
4076 of the confusion.
4077 * indent.c (Fvertical_motion): Mark locals as initialized.
4078 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4079
4080 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4081
4082 * search.c (Fre_search_backward): Mention `case-fold-search' in
4083 all the re_search_* functions (bug#8138).
4084
4085 * keyboard.c (Fopen_dribble_file): Document when the file is
4086 closed (bug#8056).
4087
4088 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4089
4090 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4091 bidi_cache_idx.
4092
4093 Support bidi reordering of display and overlay strings.
4094 * xdisp.c (compute_display_string_pos)
4095 (compute_display_string_end): Accept additional argument STRING.
4096 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4097 (reseat_to_string): Initialize bidi_it->string.s and
4098 bidi_it->string.schars.
4099 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4100 NULL (avoids a crash in bidi_paragraph_init).
4101 Initialize itb.string.lstring.
4102 (init_iterator): Call bidi_init_it only of a valid
4103 buffer position was specified. Initialize paragraph_embedding to
4104 L2R.
4105 (reseat_to_string): Initialize the bidi iterator.
4106 (display_string): If we need to ignore text properties of
4107 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4108 original value of -1 will not work with bidi.)
4109 (compute_display_string_pos): First arg is now struct
4110 `text_pos *'; all callers changed. Support display properties on
4111 Lisp strings.
4112 (compute_display_string_end): Support display properties on Lisp
4113 strings.
4114 (init_iterator, reseat_1, reseat_to_string): Initialize the
4115 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4116 when iterating on a string not from display properties).
4117 (compute_display_string_pos, compute_display_string_end):
4118 Fix calculation of the object to scan. Fixes an error when using
4119 arrow keys.
4120 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4121 base_level_stop; instead, set base_level_stop to BEGV.
4122 Fixes crashes in vertical-motion.
4123 (next_element_from_buffer): Improve commentary for when
4124 the iterator is before prev_stop.
4125 (init_iterator): Initialize bidi_p from the default value of
4126 bidi-display-reordering, not from buffer-local value. Use the
4127 buffer-local value only if initializing for buffer iteration.
4128 (handle_invisible_prop): Support invisible properties on strings
4129 that are being bidi-reordered.
4130 (set_iterator_to_next): Support bidi reordering of C strings and
4131 Lisp strings.
4132 (next_element_from_string): Support bidi reordering of Lisp
4133 strings.
4134 (handle_stop_backwards): Support Lisp strings as well.
4135 (display_string): Support display of R2L glyph rows.
4136 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4137 (init_iterator): Don't initialize it->bidi_p for strings
4138 here.
4139 (reseat_to_string): Initialize it->bidi_p for strings here.
4140 (next_element_from_string, next_element_from_c_string)
4141 (next_element_from_buffer): Add xassert's for correspondence
4142 between IT's object being iterated and it->bidi_it.string
4143 structure.
4144 (face_before_or_after_it_pos): Support bidi iteration.
4145 (next_element_from_c_string): Handle the case of the first string
4146 character that is not the first one in the visual order.
4147 (get_visually_first_element): New function, refactored from common
4148 parts of next_element_from_buffer, next_element_from_string, and
4149 next_element_from_c_string.
4150 (tool_bar_lines_needed, redisplay_tool_bar)
4151 (display_menu_bar): Force left-to-right direction. Add a FIXME
4152 comment for making that be controlled by a user option.
4153 (push_it, pop_it): Save and restore the state of the
4154 bidi iterator. Save and restore the bidi_p flag.
4155 (pop_it): Iterate out of display property for string iteration as
4156 well.
4157 (iterate_out_of_display_property): Support iteration over strings.
4158 (handle_single_display_spec): Set up it->bidi_it for iteration
4159 over a display string, and call bidi_init_it.
4160 (handle_single_display_spec, next_overlay_string)
4161 (get_overlay_strings_1, push_display_prop): Set up the bidi
4162 iterator for displaying display or overlay strings.
4163 (forward_to_next_line_start): Don't use the shortcut if
4164 bidi-iterating.
4165 (back_to_previous_visible_line_start): If handle_display_prop
4166 pushed the iterator stack, restore the internal state of the bidi
4167 iterator by calling bidi_pop_it same number of times.
4168 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4169 and we are bidi-iterating, don't decrement the iterator position;
4170 instead, set the first_elt flag in the bidi iterator, to produce
4171 the same effect.
4172 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4173 (push_display_prop): xassert that we are iterating a buffer.
4174 (push_it, pop_it): Save and restore paragraph_embedding member.
4175 (handle_single_display_spec, next_overlay_string)
4176 (get_overlay_strings_1, reseat_1, reseat_to_string)
4177 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4178 correctly. Don't assume unibyte strings are not bidi-reordered.
4179 (compute_display_string_pos)
4180 (compute_display_string_end): Fix handling the case of C string.
4181 (push_it, pop_it): Save and restore from_disp_prop_p.
4182 (handle_single_display_spec, push_display_prop): Set the
4183 from_disp_prop_p flag.
4184 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4185 (pop_it): Call iterate_out_of_display_property only if we are
4186 popping after iteration over a string that came from a display
4187 property. Fix a typo in popping stretch info. Add an assertion
4188 for verifying that the iterator position is in sync with the bidi
4189 iterator.
4190 (handle_single_display_spec, get_overlay_strings_1)
4191 (push_display_prop): Fix initialization of paragraph direction for
4192 string when that of the parent object is not yet determined.
4193 (reseat_1): Call bidi_init_it to resync the bidi
4194 iterator with IT's position. (Bug#7616)
4195 (find_row_edges): If ROW->start.pos gives position
4196 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4197 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4198 Reset the from_disp_prop_p flag.
4199 (SAVE_IT, RESTORE_IT): New macros.
4200 (pos_visible_p, face_before_or_after_it_pos)
4201 (back_to_previous_visible_line_start)
4202 (move_it_in_display_line_to, move_it_in_display_line)
4203 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4204 (try_scrolling, redisplay_window, display_line): Use them when
4205 saving a temporary copy of the iterator and restoring it back.
4206 (back_to_previous_visible_line_start, reseat_1)
4207 (init_iterator): Empty the bidi cache "stack".
4208 (move_it_in_display_line_to): If iterator ended up at
4209 EOL, but we never saw any buffer positions smaller than
4210 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4211 motion in bidi-reordered lines.
4212 (move_it_in_display_line_to): Record prev_method and prev_pos
4213 immediately before the call to set_iterator_to_next. Fixes cursor
4214 motion in bidi-reordered lines with stretch glyphs and strings
4215 displayed in margins. (Bug#8133) (Bug#8867)
4216 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4217 TO_CHARPOS.
4218 (pos_visible_p): Support positions in bidi-reordered lines.
4219 Save and restore bidi cache.
4220
4221 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4222 (bidi_paragraph_info): Delete unused struct.
4223 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4224 (bidi_cache_start): New variable.
4225 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4226 to zero.
4227 (bidi_cache_fetch_state, bidi_cache_search)
4228 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4229 (bidi_cache_find, bidi_peek_at_next_level)
4230 (bidi_level_of_next_char, bidi_find_other_level_edge)
4231 (bidi_move_to_visually_next): Compare cache index with
4232 bidi_cache_start rather than with zero.
4233 (bidi_fetch_char): Accept new argument STRING; all callers
4234 changed. Support iteration over a string. Support strings with
4235 display properties. Support unibyte strings. Fix the type of
4236 `len' according to what STRING_CHAR_AND_LENGTH expects.
4237 (bidi_paragraph_init, bidi_resolve_explicit_1)
4238 (bidi_resolve_explicit, bidi_resolve_weak)
4239 (bidi_level_of_next_char, bidi_move_to_visually_next):
4240 Support iteration over a string.
4241 (bidi_set_sor_type, bidi_resolve_explicit_1)
4242 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4243 can now be zero (for strings); special values 0 and -1 were
4244 changed to -1 and -2, respectively.
4245 (bidi_char_at_pos): New function.
4246 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4247 Call it instead of FETCH_MULTIBYTE_CHAR.
4248 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4249 initialized to valid values.
4250 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4251 values.
4252 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4253 the test for valid cached positions. Fix the logic for looking up
4254 the sentinel state in the cache. GCPRO the Lisp string we are
4255 iterating.
4256 (bidi_push_it, bidi_pop_it): New functions.
4257 (bidi_initialize): Initialize the bidi cache start stack pointer.
4258 (bidi_cache_ensure_space): New function, refactored from part of
4259 bidi_cache_iterator_state. Don't assume the required size is just
4260 one BIDI_CACHE_CHUNK away.
4261 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4262 (bidi_count_bytes, bidi_char_at_pos): New functions.
4263 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4264 always valid if bidi_cache_idx is valid.
4265 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4266 is valid if it's going to be used.
4267 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4268 (bidi_cache_fetch_state, bidi_cache_search)
4269 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4270 (bidi_cache_iterator_state, bidi_cache_find)
4271 (bidi_find_other_level_edge, bidi_cache_start_stack):
4272 All variables related to cache indices are now EMACS_INT.
4273
4274 * dispextern.h (struct bidi_string_data): New structure.
4275 (struct bidi_it): New member `string'. Make flag members be 1-bit
4276 fields, and put them last in the struct.
4277 (compute_display_string_pos, compute_display_string_end):
4278 Update prototypes.
4279 (bidi_push_it, bidi_pop_it): Add prototypes.
4280 (struct iterator_stack_entry): New members bidi_p,
4281 paragraph_embedding, and from_disp_prop_p.
4282 (struct it): Member bidi_p is now a bit field 1 bit wide.
4283 (bidi_shelve_cache, bidi_unshelve_cache):
4284 Declare prototypes.
4285
4286 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4287 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4288 and vector-like objects.
4289
4290 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4291 cache around display iteration.
4292
4293 * window.c (Fwindow_end, window_scroll_pixel_based)
4294 (displayed_window_lines, Frecenter): Save and restore the bidi
4295 cache around display iteration.
4296
4297 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4298
4299 * editfns.c (Fdelete_region): Clarify the use of the named
4300 parameters (bug#6788).
4301
4302 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4303
4304 * indent.c (Fvertical_motion): Set and restore w->pointm when
4305 saving and restoring the window's buffer (Bug#9006).
4306
4307 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4308
4309 * editfns.c (Fstring_to_char): Clarify just what is returned
4310 (bug#6576). Text by Eli Zaretskii.
4311
4312 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4313
4314 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4315
4316 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4317
4318 * buffer.c (mmap_find): Fix a typo.
4319
4320 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4321
4322 Fix execution of x selection hooks.
4323 * xselect.c (Qx_lost_selection_functions)
4324 (Qx_sent_selection_functions): New vars.
4325 (syms_of_xselect): DEFSYM them.
4326 (x_handle_selection_request): Pass Qx_sent_selection_functions
4327 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4328 (x_handle_selection_clear,x_clear_frame_selections):
4329 Pass Qx_lost_selection_functions rather than
4330 Vx_lost_selection_functions to Frun_hook_with_args.
4331
4332 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4335 The old code sometimes used this field without initializing it.
4336
4337 * alloc.c (gc_sweep): Don't read past end of array.
4338 In theory, the old code could also have corrupted Emacs internals,
4339 though it'd be very unlikely.
4340
4341 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4342
4343 * character.c (Fcharacterp): Don't advertise optional ignored
4344 argument. (Bug#4026)
4345
4346 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4347
4348 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4349 key" (bug#4257).
4350
4351 * window.c (Fset_window_start): Doc fix (bug#4199).
4352 (Fset_window_hscroll): Ditto.
4353
4354 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4355
4356 Fix minor new problems caught by GCC 4.6.1.
4357 * term.c (init_tty): Remove unused local.
4358 * xsettings.c (store_monospaced_changed): Define this function only
4359 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4360 not used otherwise.
4361
4362 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4363
4364 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4365
4366 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4367
4368 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4369 are the mini-buffer and the echo area (bug#3320).
4370
4371 * term.c (init_tty): Remove support for supdup, c10 and perq
4372 terminals, which are no longer supported (bug#1482).
4373
4374 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4375
4376 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4377
4378 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4379
4380 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4381 for non-popups (Bug#3642).
4382
4383 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4384
4385 * alloc.c (reset_malloc_hooks): Protoize.
4386 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4387 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4388 * cm.c (losecursor): Likewise.
4389 * data.c (fmod): Likewise.
4390 * dispnew.c (swap_glyphs_in_rows): Likewise.
4391 * emacs.c (memory_warning_signal): Likewise.
4392 * floatfns.c (float_error): Likewise.
4393 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4394 (otf_open, font_otf_capability, generate_otf_features)
4395 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4396 Likewise.
4397 * image.c (pbm_read_file): Likewise.
4398 * indent.c (string_display_width): Likewise.
4399 * intervals.c (check_for_interval, search_for_interval)
4400 (inc_interval_count, count_intervals, root_interval)
4401 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4402 * lread.c (defalias): Likewise.
4403 * ralloc.c (r_alloc_check): Likewise.
4404 * regex.c (set_image_of_range_1, set_image_of_range)
4405 (regex_grow_registers): Likewise.
4406 * sysdep.c (strerror): Likewise.
4407 * termcap.c (valid_filename_p, tprint, main): Likewise.
4408 * tparam.c (main): Likewise.
4409 * unexhp9k800.c (run_time_remap, save_data_space)
4410 (update_file_ptrs, read_header, write_header, calculate_checksum)
4411 (copy_file, copy_rest, display_header): Likewise.
4412 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4413 Likewise.
4414 * xdisp.c (check_it): Likewise.
4415 * xfaces.c (register_color, unregister_color, unregister_colors):
4416 Likewise.
4417 * xfns.c (print_fontset_result): Likewise.
4418 * xrdb.c (member, fatal, main): Likewise.
4419
4420 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4421
4422 Fix minor problems found by static checking (Bug#9031).
4423 * chartab.c (char_table_set_range, map_sub_char_table):
4424 Remove unused locals.
4425 (uniprop_table): Now static.
4426 * composite.c (_work_char): Remove unused static var.
4427
4428 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4429
4430 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4431
4432 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4433
4434 * gtkutil.c (qttip_cb): Remove code without function.
4435
4436 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4437
4438 * w32.c (pthread_sigmask): New stub.
4439
4440 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4441
4442 Use pthread_sigmask, not sigprocmask (Bug#9010).
4443 sigprocmask is portable only for single-threaded applications, and
4444 Emacs can be multi-threaded when it uses GTK.
4445 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4446 (LIBES): Use it.
4447 * callproc.c (Fcall_process):
4448 * process.c (create_process):
4449 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4450 Use pthread_sigmask, not sigprocmask.
4451
4452 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4453
4454 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4455 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4456 wrong (Bug#8591).
4457
4458 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4459
4460 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4461 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4462 (xg_hide_tooltip): Fix comment.
4463
4464 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4465 in registerServicesMenuSendTypes.
4466 (validRequestorForSendType): Don't check ns_return_types.
4467
4468 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4469 ns_return_type.
4470
4471 2011-07-08 Jason Rumney <jasonr@gnu.org>
4472
4473 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4474 SH_SHOW for hidden windows (Bug#5482).
4475
4476 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4477 frame struct members of non-existent frames (Bug#6284).
4478
4479 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4480
4481 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4482 variable firstTime not needed on OSX >= 10.6.
4483 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4484 >= 10.5. Use setKnobProportion, setDoubleValue.
4485
4486 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4487 (MAC_OS_X_VERSION_10_5): Define if not defined.
4488 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4489 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4490 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4491
4492 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4493 cString and lossyCString on OSX >= 10.4
4494
4495 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4496 sizeToFit on OSX >= 10.2.
4497
4498 * nsimage.m (allocInitFromFile): Don't use deprecated method
4499 bestRepresentationForDevice on OSX >= 10.6.
4500
4501 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4502 to avoid warning.
4503
4504 * emacs.c: Declare unexec_init_emacs_zone.
4505
4506 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4507
4508 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4509
4510 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4511 on svcsMenu (Bug#8842).
4512
4513 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4514 ns_return_types.
4515 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4516
4517 * nsterm.m (QUTF8_STRING): Declare.
4518 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4519 (validRequestorForSendType): Return type is (id).
4520 Change indexOfObjectIdenticalTo to indexOfObject.
4521 Check if we have local selection before returning self (Bug#8842).
4522 (writeSelectionToPasteboard): Put local selection into paste board
4523 if we have a local selection (Bug#8842).
4524 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4525
4526 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4527 (ns_get_local_selection): Declare.
4528
4529 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4530
4531 * keymap.c (describe_map_tree): Don't insert a double newline at
4532 the end of the buffer (bug#1169) and return whether we inserted
4533 something.
4534
4535 * callint.c (Fcall_interactively): Change "reading args" to
4536 "providing args" to try to clarify what it does (bug#1010).
4537
4538 2011-07-07 Kenichi Handa <handa@m17n.org>
4539
4540 * composite.c (composition_compute_stop_pos): Ignore a static
4541 composition starting before CHARPOS (Bug#8915).
4542
4543 * xdisp.c (handle_composition_prop): Likewise.
4544
4545 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4546
4547 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4548 (Bug#9015)
4549
4550 2011-07-07 Kenichi Handa <handa@m17n.org>
4551
4552 * character.h (unicode_category_t): New enum type.
4553
4554 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4555 (Qchar_code_property_table): New variable.
4556 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4557 (UNIPROP_COMPRESSED_FORM_P): New macros.
4558 (char_table_ascii): Uncompress the compressed values.
4559 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4560 Uncompress the compressed values.
4561 (sub_char_table_ref_and_range): Likewise.
4562 (char_table_ref_and_range): Uncompress the compressed values.
4563 (sub_char_table_set): New arg is_uniprop. Callers changed.
4564 Uncompress the compressed values.
4565 (sub_char_table_set_range): Args changed. Callers changed.
4566 (char_table_set_range): Adjuted for the above change.
4567 (map_sub_char_table): Delete args default_val and parent. Add arg
4568 top. Give decoded values to a Lisp function.
4569 (map_char_table): Adjust for the above change. Give decoded
4570 values to a Lisp function. Gcpro more variables.
4571 (uniprop_table_uncompress)
4572 (uniprop_decode_value_run_length): New functions.
4573 (uniprop_decoder, uniprop_decoder_count): New variables.
4574 (uniprop_get_decoder, uniprop_encode_value_character)
4575 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4576 New functions.
4577 (uniprop_encoder, uniprop_encoder_count): New variables.
4578 (uniprop_get_encoder, uniprop_table)
4579 (Funicode_property_table_internal, Fget_unicode_property_internal)
4580 (Fput_unicode_property_internal): New functions.
4581 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4582 Sunicode_property_table_internal, Sget_unicode_property_internal,
4583 and Sput_unicode_property_internal. Defvar_lisp
4584 char-code-property-alist.
4585
4586 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4587 Vunicode_category_table.
4588
4589 * font.c (font_range): Adjust for the change of
4590 Vunicode_category_table.
4591
4592 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4593
4594 * m/iris4d.h: Remove file, move contents ...
4595 * s/irix6-5.h: ... here.
4596
4597 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4598
4599 Remove unportable assumption about struct layout (Bug#8884).
4600 * alloc.c (mark_buffer):
4601 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4602 (clone_per_buffer_values): Don't assume that
4603 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4604 This isn't true in general, and it's particularly not true
4605 if Emacs is configured with --with-wide-int.
4606 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4607 New macros, used in the buffer.c change.
4608
4609 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4610
4611 * xsettings.c: Use both GConf and GSettings if both are available.
4612 (store_config_changed_event): Add comment.
4613 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4614 (store_tool_bar_style_changed): New functions.
4615 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4616 (struct xsettings): Move font inside HAVE_XFT.
4617 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4618 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4619 Move inside HAVE_XFT.
4620 (something_changed_gsettingsCB): Rename from something_changedCB.
4621 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4622 also.
4623 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4624 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4625 (something_changed_gconfCB): Rename from something_changedCB.
4626 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4627 (parse_settings): Move check for font inside HAVE_XFT.
4628 (read_settings, apply_xft_settings): Add comment.
4629 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4630 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4631 call store_font_name_changed.
4632 (xft_settings_event): Add comment.
4633 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4634 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4635 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4636 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4637 (xsettings_initialize): Call init_gsettings last.
4638 (xsettings_get_system_font, xsettings_get_system_normal_font):
4639 Add comment.
4640
4641 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 Random fixes. E.g., (random) never returned negative values.
4644 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4645 subseconds part to the entropy, as that's a bit more random.
4646 Prefer signed to unsigned, since the signedness doesn't matter and
4647 in general we prefer signed. When given a limit, use a
4648 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4649 latter isn't right if USE_2_TAGS_FOR_INTS.
4650 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4651 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4652
4653 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4654
4655 * textprop.c (text_property_stickiness):
4656 Obey Vtext_property_default_nonsticky.
4657 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4658 * w32fns.c (syms_of_w32fns):
4659 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4660
4661 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4662
4663 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4664 This is more efficient than Ffile_directory_p and avoids a minor race.
4665
4666 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4667
4668 * buffer.c (Foverlay_put): Say what the return value is
4669 (bug#7835).
4670
4671 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4672 is a directory before asking whether to use the file name
4673 (bug#7564).
4674 (barf_or_query_if_file_exists): Make the "File is a directory"
4675 error be more correct.
4676
4677 * fns.c (Frequire): Remove the mention of the .gz files, since
4678 that's installation-specific, but keep the mention of
4679 `get-load-suffixes'.
4680
4681 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4682
4683 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4684 Report string overflow if the output is too long.
4685
4686 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4687
4688 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4689 (syms_of_gnutls): Remove duplicate DEFSYM for
4690 Qgnutls_bootprop_verify_hostname_error, an error for
4691 Qgnutls_bootprop_verify_error (which is no longer used).
4692
4693 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4694 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4695 Also (re)move comments that are misplaced or no longer relevant.
4696
4697 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4698
4699 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4700
4701 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4702
4703 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4704 and background color parameters if they have been changed.
4705
4706 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4707
4708 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4709
4710 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4711
4712 * xsettings.c (SYSTEM_FONT): Define only when used.
4713 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4714
4715 * keymap.c (access_keymap_1): Now static.
4716
4717 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4718
4719 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4720 leave any prefix arg for the up event (Bug#1586).
4721
4722 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4723
4724 * lread.c (syms_of_lread): Mention single symbols defined by
4725 `defvar' or `defconst' (bug#7154).
4726
4727 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4728 (Frequire): Mention get-load-suffixes.
4729
4730 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4731
4732 * window.h (window): Remove clone_number slot.
4733 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4734 Remove.
4735 (make_parent_window, make_window, saved_window)
4736 (Fset_window_configuration, save_window_save): Don't deal with
4737 clone numbers.
4738 * buffer.c (Qclone_number): Remove declaration.
4739 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4740
4741 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4742
4743 Add multiple inheritance to keymaps.
4744 * keymap.c (Fmake_composed_keymap): New function.
4745 (Fset_keymap_parent): Simplify.
4746 (fix_submap_inheritance): Remove.
4747 (access_keymap_1): New function extracted from access_keymap to handle
4748 embedded parents and handle lists of maps.
4749 (access_keymap): Use it.
4750 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4751 (Fcopy_keymap): Handle embedded parents.
4752 (Fcommand_remapping, define_as_prefix): Simplify.
4753 (Fkey_binding): Simplify.
4754 (syms_of_keymap): Move minibuffer-local-completion-map,
4755 minibuffer-local-filename-completion-map,
4756 minibuffer-local-must-match-map, and
4757 minibuffer-local-filename-must-match-map to Elisp.
4758 (syms_of_keymap): Defsubr make-composed-keymap.
4759 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4760 (parse_menu_item): Trivial simplification.
4761
4762 2011-07-01 Glenn Morris <rgm@gnu.org>
4763
4764 * Makefile.in (SETTINGS_LIBS): Fix typo.
4765
4766 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4767
4768 * coding.c (Fencode_coding_string): Record the last coding system
4769 used, as the function doc string says (bug#8738).
4770
4771 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4772
4773 * xsettings.c (store_monospaced_changed): Take new font as arg and
4774 check for change against current_mono_font.
4775 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4776 (emacs_settings_constructor, emacs_settings_get_property)
4777 (emacs_settings_set_property, emacs_settings_class_init)
4778 (emacs_settings_init, gsettings_obj): Remove.
4779 (something_changedCB): New function for HAVE_GSETTINGS.
4780 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4781 with value as argument.
4782 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4783 g_settings_new (Bug#8967). Do not create gsettings_obj.
4784 Remove calls to g_settings_bind. Connect something_changedCB to
4785 "changed".
4786
4787 * xgselect.c: Add defined (HAVE_GSETTINGS).
4788 (xgselect_initialize): Ditto.
4789
4790 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4791 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4792 xg_select.
4793
4794 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4795
4796 * eval.c (struct backtrace): Simplify and port the data structure.
4797 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4798 signed bit field, as this assumption is not portable and it makes
4799 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4800 "char debug_on_exit : 1" as this is not portable either; instead,
4801 use the portable "unsigned int debug_on_exit : 1". Remove unused
4802 member evalargs. Remove obsolete comments about cc bombing out.
4803
4804 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4805
4806 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4807 Let HAVE_GSETTINGS override HAVE_GCONF.
4808 (store_monospaced_changed): New function.
4809 (EMACS_SETTINGS): A new type derived from GObject to handle
4810 GSettings notifications.
4811 (emacs_settings_constructor, emacs_settings_get_property)
4812 (emacs_settings_set_property, emacs_settings_class_init):
4813 New functions.
4814 (gsettings_client, gsettings_obj): New variables.
4815 (GSETTINGS_SCHEMA): New define.
4816 (something_changedCB): Call store_monospaced_changed.
4817 (init_gsettings): New function.
4818 (xsettings_initialize): Call init_gsettings.
4819 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4820 to NULL.
4821
4822 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4823 GCONF_CFLAGS/LIBS.
4824
4825 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4826
4827 * window.c (resize_root_window, grow_mini_window)
4828 (shrink_mini_window): Rename Qresize_root_window to
4829 Qwindow_resize_root_window and Qresize_root_window_vertically to
4830 Qwindow_resize_root_window_vertically.
4831
4832 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4833
4834 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4835
4836 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4837
4838 * makefile.w32-in: Redesign dependencies so they reflect more
4839 clearly which files are directly included by each source file,
4840 and not through other includes.
4841
4842 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4843
4844 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4845 (sort_overlays, overlay_strings): When an overlay's clone number
4846 matches the window's clone number process the overlay even if
4847 the overlay's window property doesn't match the current window.
4848
4849 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4850 (Fwindow_hchild): Rename to Fwindow_left_child.
4851 (Fwindow_next): Rename to Fwindow_next_sibling.
4852 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4853 (resize_window_check): Rename to window_resize_check.
4854 (resize_window_apply): Rename to window_resize_apply.
4855 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4856 (Fdelete_other_windows_internal, resize_frame_windows)
4857 (Fsplit_window_internal, Fdelete_window_internal)
4858 (grow_mini_window, shrink_mini_window)
4859 (Fresize_mini_window_internal): Fix callers accordingly.
4860
4861 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4862
4863 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4864 (emacs_fixed_set_min_size): Remove.
4865 (emacs_fixed_new): Take frame as argument.
4866
4867 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4868 (_EmacsFixedPrivate): Remove minwidth/height.
4869 Add struct frame *f.
4870 (emacs_fixed_init): Initialize priv->f.
4871 (get_parent_class, emacs_fixed_set_min_size): Remove.
4872 (emacs_fixed_new): Set priv->f to argument.
4873 (emacs_fixed_get_preferred_width)
4874 (emacs_fixed_get_preferred_height): Use min_width/height from
4875 frames size_hint to set minimum and natural (Bug#8919).
4876 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4877 and use min_width/height from frames size_hint to set
4878 min_width/height (Bug#8919).
4879
4880 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4881 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4882 Fix indentation.
4883
4884 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4885
4886 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4887 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4888 called at ZV.
4889
4890 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4891
4892 * process.c (wait_reading_process_output): Bypass select if
4893 waiting for a cell while ignoring keyboard input, and input is
4894 pending. Suggested by Jan Djärv (Bug#8869).
4895
4896 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4897
4898 Use gnulib's dup2 module instead of rolling our own.
4899 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4900
4901 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4902
4903 * dispnew.c (scrolling_window): Before scrolling, turn off a
4904 mouse-highlight in the window being scrolled.
4905
4906 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4907
4908 Move DEFSYM to lisp.h and use everywhere.
4909
4910 * character.h (DEFSYM): Move declaration...
4911 * lisp.h (DEFSYM): ...here.
4912
4913 * gnutls.c:
4914 * minibuf.c:
4915 * w32menu.c:
4916 * w32proc.c:
4917 * w32select.c: Don't include character.h.
4918
4919 * alloc.c (syms_of_alloc):
4920 * buffer.c (syms_of_buffer):
4921 * bytecode.c (syms_of_bytecode):
4922 * callint.c (syms_of_callint):
4923 * casefiddle.c (syms_of_casefiddle):
4924 * casetab.c (init_casetab_once):
4925 * category.c (init_category_once, syms_of_category):
4926 * ccl.c (syms_of_ccl):
4927 * cmds.c (syms_of_cmds):
4928 * composite.c (syms_of_composite):
4929 * dbusbind.c (syms_of_dbusbind):
4930 * dired.c (syms_of_dired):
4931 * dispnew.c (syms_of_display):
4932 * doc.c (syms_of_doc):
4933 * editfns.c (syms_of_editfns):
4934 * emacs.c (syms_of_emacs):
4935 * eval.c (syms_of_eval):
4936 * fileio.c (syms_of_fileio):
4937 * fns.c (syms_of_fns):
4938 * frame.c (syms_of_frame):
4939 * fringe.c (syms_of_fringe):
4940 * insdel.c (syms_of_insdel):
4941 * keymap.c (syms_of_keymap):
4942 * lread.c (init_obarray, syms_of_lread):
4943 * macros.c (syms_of_macros):
4944 * msdos.c (syms_of_msdos):
4945 * print.c (syms_of_print):
4946 * process.c (syms_of_process):
4947 * search.c (syms_of_search):
4948 * sound.c (syms_of_sound):
4949 * syntax.c (init_syntax_once, syms_of_syntax):
4950 * terminal.c (syms_of_terminal):
4951 * textprop.c (syms_of_textprop):
4952 * undo.c (syms_of_undo):
4953 * w32.c (globals_of_w32):
4954 * window.c (syms_of_window):
4955 * xdisp.c (syms_of_xdisp):
4956 * xfaces.c (syms_of_xfaces):
4957 * xfns.c (syms_of_xfns):
4958 * xmenu.c (syms_of_xmenu):
4959 * xsettings.c (syms_of_xsettings):
4960 * xterm.c (syms_of_xterm): Use DEFSYM.
4961
4962 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4963
4964 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4965
4966 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 Integer and buffer overflow fixes (Bug#8873).
4969
4970 * print.c (printchar, strout): Check for string overflow.
4971 (PRINTPREPARE, printchar, strout):
4972 Don't set size unless allocation succeeds.
4973
4974 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4975 for sizes. Check for string overflow more accurately.
4976 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4977
4978 * macros.c: Integer and buffer overflow fixes.
4979 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4980 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4981 Use ptrdiff_t, not int, for sizes.
4982 Don't increment bufsize until after realloc succeeds.
4983 Check for size-calculation overflow.
4984 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4985
4986 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4987
4988 * lread.c: Integer overflow fixes.
4989 (read_integer): Radix is now EMACS_INT, not int,
4990 to improve quality of diagnostics for out-of-range radices.
4991 Calculate buffer size correctly for out-of-range radices.
4992 (read1): Check for integer overflow in radices, and in
4993 read-circle numbers.
4994 (read_escape): Avoid int overflow.
4995 (Fload, openp, read_buffer_size, read1)
4996 (substitute_object_recurse, read_vector, read_list, map_obarray):
4997 Use ptrdiff_t, not int, for sizes.
4998 (read1): Use EMACS_INT, not int, for sizes.
4999 Check for size overflow.
5000
5001 * image.c (cache_image): Check for size arithmetic overflow.
5002
5003 * lread.c: Integer overflow issues.
5004 (saved_doc_string_size, saved_doc_string_length)
5005 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5006 Now ptrdiff_t, not int.
5007 (read1): Don't assume doc string length fits in int. Check for
5008 out-of-range doc string lengths.
5009 (read_list): Don't assume file position fits in int.
5010 (read_escape): Check for hex character overflow.
5011
5012 2011-06-22 Leo Liu <sdl.web@gmail.com>
5013
5014 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5015 Move to minibuffer.el.
5016
5017 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5018
5019 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5020 The following patches are for when GLYPH_DEBUG && !XASSERT.
5021 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5022 * dispnew.c (flush_stdout):
5023 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5024 Mark as externally visible.
5025 * dispnew.c (check_window_matrix_pointers): Now static.
5026 * dispnew.c (window_to_frame_vpos):
5027 * xfns.c (unwind_create_frame):
5028 * xterm.c (x_check_font): Remove unused local.
5029 * scroll.c (CHECK_BOUNDS):
5030 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5031 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5032 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5033 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5034 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5035 Now static.
5036 (debug_method_add): Use va_list and vsprintf rather than relying
5037 on undefined behavior with wrong number of arguments.
5038 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5039 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5040 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5041 since we're not interested in debugging glyphs with old libraries.
5042 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5043 GCC 4.6.0's static checking.
5044
5045 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5046
5047 Integer overflow and signedness fixes (Bug#8873).
5048 A few related buffer overrun fixes, too.
5049
5050 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5051
5052 * dispextern.h (struct face.stipple):
5053 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5054 (x_bitmap_mask, x_allocate_bitmap_record)
5055 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5056 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5057 (x_create_bitmap_from_xpm_data):
5058 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5059 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5060 (.bitmaps_last):
5061 * xfaces.c (load_pixmap):
5062 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5063 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5064 (.bitmaps_last, struct x_output.icon_bitmap):
5065 Use ptrdiff_t, not int, for bitmap indexes.
5066 (x_allocate_bitmap_record): Check for size overflow.
5067 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5068
5069 Use ptrdiff_t, not int, for overlay counts.
5070 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5071 * editfns.c (overlays_around, get_pos_property):
5072 * textprop.c (get_char_property_and_overlay):
5073 * xdisp.c (next_overlay_change, note_mouse_highlight):
5074 * xfaces.c (face_at_buffer_position):
5075 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5076 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5077 (Fnext_overlay_change, Fprevious_overlay_change)
5078 (mouse_face_overlay_overlaps, Foverlays_in):
5079 Use ptrdiff_t, not int, for sizes.
5080 (overlays_at, overlays_in): Check for size-calculation overflow.
5081
5082 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5083
5084 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5085 (x_session_initialize): Do not assume string length fits in int.
5086
5087 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5088 This is unlikely, but can occur if DPI is outlandish.
5089
5090 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5091 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5092
5093 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5094 * xrdb.c (magic_file_p, search_magic_path):
5095 Omit last arg SUFFIX; it was always 0. All callers changed.
5096 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5097
5098 * xfont.c (xfont_match): Avoid need for strlen.
5099
5100 * xfns.c: Don't assume strlen fits in int.
5101 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5102
5103 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5104 not unsigned long, as we prefer signed integers. All callers changed.
5105 Detect integer overflow in repeat count.
5106 (message_dolog): Don't assume print length fits in 39 bytes.
5107 (display_mode_element): Don't assume strlen fits in int.
5108
5109 * termcap.c: Don't assume sizes fit in int and never overflow.
5110 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5111 (gobble_line): Check for size-calculation overflow.
5112
5113 * minibuf.c (Fread_buffer):
5114 * lread.c (intern, intern_c_string):
5115 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5116 Don't assume string length fits in int.
5117
5118 * keyboard.c (parse_tool_bar_item):
5119 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5120
5121 * font.c: Don't assume string length fits in int.
5122 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5123 Use ptrdiff_t, not int.
5124 (font_intern_prop): Don't assume string length fits in int.
5125 Don't assume integer property fits in fixnum.
5126 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5127
5128 * filelock.c: Fix some buffer overrun and integer overflow issues.
5129 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5130 Reformulate so as not to need the command string.
5131 Invoke gzip -cd rather than gunzip, as it's more portable.
5132 (lock_info_type, lock_file_1, lock_file):
5133 Don't assume pid_t and time_t fit in unsigned long.
5134 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5135 (current_lock_owner): Prefer signed type for sizes.
5136 Use memcpy, not strncpy, where memcpy is what is really wanted.
5137 Don't assume (via atoi) that time_t and pid_t fit in int.
5138 Check for time_t and/or pid_t out of range, e.g., via a network share.
5139 Don't alloca where an auto var works fine.
5140
5141 * fileio.c: Fix some integer overflow issues.
5142 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5143 Don't assume string length fits in int.
5144 (directory_file_name): Don't assume string length fits in long.
5145 (make_temp_name): Don't assume pid fits in int, or that its print
5146 length is less than 20.
5147
5148 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5149
5150 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5151
5152 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5153
5154 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5155 We prefer signed integers, even for size calculations.
5156
5157 * emacs.c: Don't assume string length fits in 'int'.
5158 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5159 (main): Don't invoke strlen when not needed.
5160
5161 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5162 (XD_DEBUG_MESSAGE): Don't waste a byte.
5163
5164 * callproc.c (getenv_internal_1, getenv_internal)
5165 (Fgetenv_internal):
5166 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5167
5168 * lread.c (invalid_syntax): Omit length argument.
5169 All uses changed. This doesn't fix a bug, but it simplifies the
5170 code away from its former Hollerith-constant appearance, and it's
5171 one less 'int' to worry about when looking at integer-overflow issues.
5172 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5173
5174 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5175 This didn't break anything, but it didn't help either.
5176 It's confusing to put a bogus integer in a place where the actual
5177 value does not matter.
5178 (LIST_END_P): Remove unused macro and its bogus comment.
5179 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5180
5181 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5182 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5183 implementation.
5184 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5185 We prefer signed types, and the value cannot exceed the EMACS_INT
5186 range anyway (because otherwise the length would not be representable).
5187 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5188 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5189 This avoids a GCC warning when WIDE_EMACS_INT.
5190
5191 * indent.c (sane_tab_width): New function.
5192 (current_column, scan_for_column, Findent_to, position_indentation)
5193 (compute_motion): Use it. This is just for clarity.
5194 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5195
5196 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5197
5198 * lisp.h (lint_assume): New macro.
5199 * composite.c (composition_gstring_put_cache):
5200 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5201
5202 * editfns.c, insdel.c:
5203 Omit unnecessary forward decls, to simplify future changes.
5204
5205 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5206
5207 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5208
5209 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5210 Use much-faster test for byte-length change.
5211 Don't assume string byte-length fits in 'int'.
5212 Check that character arg fits in 'int'.
5213 (mapcar1): Declare byte as byte, for clarity.
5214
5215 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5216
5217 * fns.c (concat): Catch string overflow earlier.
5218 Do not rely on integer wraparound.
5219
5220 * dispextern.h (struct it.overlay_strings_charpos)
5221 (struct it.selective): Now EMACS_INT, not int.
5222 * xdisp.c (forward_to_next_line_start)
5223 (back_to_previous_visible_line_start)
5224 (reseat_at_next_visible_line_start, next_element_from_buffer):
5225 Don't arbitrarily truncate the value of 'selective' to int.
5226
5227 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5228
5229 * composite.c: Don't truncate sizes to 'int'.
5230 (composition_gstring_p, composition_reseat_it)
5231 (composition_adjust_point): Use EMACS_INT, not int.
5232 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5233 not EMACS_UINT, for indexes.
5234
5235 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5236
5237 * buffer.c: Include <verify.h>.
5238 (struct sortvec.priority, struct sortstr.priority):
5239 Now EMACS_INT, not int.
5240 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5241 (struct sortstr.size, record_overlay_string)
5242 (struct sortstrlist.size, struct sortlist.used):
5243 Don't truncate size to int.
5244 (record_overlay_string): Check for size-calculation overflow.
5245 (init_buffer_once): Check at compile-time, not run-time.
5246
5247 2011-06-22 Jim Meyering <meyering@redhat.com>
5248
5249 Don't leak an XBM-image-sized buffer
5250 * image.c (xbm_load): Free the image buffer after using it.
5251
5252 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5253
5254 Port to Sun C.
5255 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5256 that Sun C diagnosed.
5257 * fns.c (secure_hash): Fix pointer signedness issue.
5258 * intervals.c (static_offset_intervals): New function.
5259 (offset_intervals): Use it.
5260
5261 2011-06-21 Leo Liu <sdl.web@gmail.com>
5262
5263 * deps.mk (fns.o):
5264 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5265 sha512.h.
5266
5267 * fns.c (secure_hash): Rename from crypto_hash_function and change
5268 the first arg to accept symbols.
5269 (Fsecure_hash): New primitive.
5270 (syms_of_fns): New symbols.
5271
5272 2011-06-20 Deniz Dogan <deniz@dogan.se>
5273
5274 * process.c (Fset_process_buffer): Clarify return value in
5275 docstring.
5276
5277 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5278
5279 * dispnew.c (add_window_display_history): Use BVAR.
5280
5281 * xdisp.c (debug_method_add): Use BVAR.
5282 (check_window_end, dump_glyph_matrix, dump_glyph)
5283 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5284
5285 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5286 Likewise.
5287
5288 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5289 check till after the cache is created in init_frame_faces.
5290
5291 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5292
5293 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5294
5295 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5296
5297 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5298 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5299 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5300
5301 Improve buffer-overflow checking (Bug#8873).
5302 * fileio.c (Finsert_file_contents):
5303 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5304 Remove the old (too-loose) buffer overflow checks.
5305 They weren't needed, since make_gap checks for buffer overflow.
5306 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5307 The old code merely checked for Emacs fixnum overflow, and relied
5308 on undefined (wraparound) behavior. The new code avoids undefined
5309 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5310
5311 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5312 Tune. Don't use wider integers than needed. Don't use alloca.
5313 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5314
5315 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5316
5317 * insdel.c, lisp.h (buffer_overflow): New function.
5318 (insert_from_buffer_1, replace_range, replace_range_2):
5319 * insdel.c (make_gap_larger):
5320 * editfns.c (Finsert_char):
5321 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5322
5323 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5324
5325 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5326
5327 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5328
5329 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5330 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5331
5332 * fileio.c: Don't assume EMACS_INT fits in off_t.
5333 (emacs_lseek): New static function.
5334 (Finsert_file_contents, Fwrite_region): Use it.
5335 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5336
5337 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5338
5339 * fns.c: Don't overflow int when computing a list length.
5340 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5341 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5342 truncation on 64-bit hosts. Check for QUIT every
5343 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5344 faster and is responsive enough.
5345 (Flength): Report an error instead of overflowing an integer.
5346 (Fsafe_length): Return a float if the value is not representable
5347 as a fixnum. This shouldn't happen except in contrived situations.
5348 (Fnthcdr, Fsort): Don't assume list length fits in int.
5349 (Fcopy_sequence): Don't assume vector length fits in int.
5350
5351 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5352 (header_size, word_size): New constants.
5353 (allocate_vectorlike): Don't check size overflow here.
5354 (allocate_vector): Check it here instead, since this is the only
5355 caller of allocate_vectorlike that could cause overflow.
5356 Check that the new vector's length is representable as a fixnum.
5357
5358 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5359 The previous code was bogus. For example, next_almost_prime (32)
5360 returned 39, which is undesirable as it is a multiple of 3; and
5361 next_almost_prime (24) returned 25, which is a multiple of 5 so
5362 why was the code bothering to check for multiples of 7?
5363
5364 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5365
5366 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5367
5368 Variadic C functions now count arguments with ptrdiff_t.
5369 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5370 Back then I didn't know that the Emacs coding style prefers signed int.
5371 Also, in the meantime I found a few more instances where arguments
5372 were being counted with int, which may truncate counts on 64-bit
5373 machines, or EMACS_INT, which may be unnecessarily wide.
5374 * lisp.h (struct Lisp_Subr.function.aMANY)
5375 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5376 Arg counts are now ptrdiff_t, not size_t.
5377 All variadic functions and their callers changed accordingly.
5378 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5379 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5380 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5381 * callint.c (Fcall_interactively): Check arg count for overflow,
5382 to avoid potential buffer overrun. Use signed char, not 'int',
5383 for 'varies' array, so that we needn't bother to check its size
5384 calculation for overflow.
5385 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5386 * eval.c (apply_lambda):
5387 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5388 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5389 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5390
5391 * callint.c (Fcall_interactively): Don't use index var as event count.
5392
5393 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5394 * mem-limits.h (SIZE): Remove; no longer used.
5395
5396 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5397
5398 Remove unnecessary casts.
5399 * xterm.c (x_term_init):
5400 * xfns.c (x_set_border_pixel):
5401 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5402 These aren't needed now that we assume ANSI C.
5403
5404 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5405 It's more likely to cause problems (due to unsigned overflow)
5406 than to cure them.
5407
5408 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5409
5410 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5411
5412 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5413
5414 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5415
5416 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5417
5418 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5419
5420 GLYPH_CODE_FACE returns EMACS_INT, not int.
5421 * dispextern.h (merge_faces):
5422 * xfaces.c (merge_faces):
5423 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5424 Don't assume EMACS_INT fits in int.
5425
5426 * character.h (CHAR_VALID_P): Remove unused parameter.
5427 * fontset.c, lisp.h, xdisp.c: All uses changed.
5428
5429 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5430
5431 * fns.c (concat): Minor tuning based on overflow analysis.
5432 This doesn't fix any bugs. Use int to hold character, instead
5433 of constantly refetching from Emacs object. Use XFASTINT, not
5434 XINT, for value known to be a character. Don't bother comparing
5435 a single byte to 0400, as it's always less.
5436
5437 * floatfns.c (Fexpt):
5438 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5439
5440 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5441 for characters.
5442
5443 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5444
5445 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5446 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5447 incorrectly succeed when S was a string, because 4294967386 was
5448 truncated before it was used.
5449
5450 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5451 Otherwise, an out-of-range integer could cause undefined behavior
5452 on a 64-bit host.
5453
5454 * composite.c: Use int, not EMACS_INT, for characters.
5455 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5456 EMACS_INT, for values that are known to be in character range.
5457 This doesn't fix any bugs but is the usual style inside Emacs and
5458 may generate better code on 32-bit machines.
5459
5460 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5461 This is for reasons similar to the recent CHAR_STRING fix.
5462 * charset.c (Fencode_char): Check that character arg is actually
5463 a character. Pass an int to ENCODE_CHAR.
5464 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5465 wider than 'int', as a compile-time check to prevent future regressions
5466 in this area.
5467
5468 * character.c (char_string): Remove unnecessary casts.
5469
5470 Make sure a 64-bit char is never passed to CHAR_STRING.
5471 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5472 by silently ignoring the top 32 bits, allowing some values
5473 that were far too large to be valid characters.
5474 * character.h: Include <verify.h>.
5475 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5476 arguments are no wider than unsigned, as a compile-time check
5477 to prevent future regressions in this area.
5478 * data.c (Faset):
5479 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5480 (Fsubst_char_in_region):
5481 * fns.c (concat):
5482 * xdisp.c (decode_mode_spec_coding):
5483 Adjust to CHAR_STRING's new requirement.
5484 * editfns.c (Finsert_char, Fsubst_char_in_region):
5485 * fns.c (concat): Check that character args are actually
5486 characters. Without this test, these functions did the wrong
5487 thing with wildly out-of-range values on 64-bit hosts.
5488
5489 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5490 These casts should not be needed on 32-bit hosts, either.
5491 * keyboard.c (read_char):
5492 * lread.c (Fload): Remove casts to unsigned.
5493
5494 * lisp.h (UNSIGNED_CMP): New macro.
5495 This fixes comparison bugs on 64-bit hosts.
5496 (ASCII_CHAR_P): Use it.
5497 * casefiddle.c (casify_object):
5498 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5499 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5500 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5501 * dispextern.h (FACE_FROM_ID):
5502 * keyboard.c (read_char): Use UNSIGNED_CMP.
5503
5504 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5505 not to EMACS_INT, to avoid GCC warning.
5506
5507 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5508
5509 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5510 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5511 isn't needed on 32-bit machines.
5512
5513 * buffer.c (Fgenerate_new_buffer_name):
5514 Use EMACS_INT for count, not int.
5515 (advance_to_char_boundary): Return EMACS_INT, not int.
5516
5517 * data.c (Qcompiled_function): Now static.
5518
5519 * window.c (window_body_lines): Now static.
5520
5521 * image.c (gif_load): Rename local to avoid shadowing.
5522
5523 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5524 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5525 * alloc.c (make_save_value): Integer argument is now of type
5526 ptrdiff_t, not int.
5527 (mark_object): Use ptrdiff_t, not int.
5528 * lisp.h (pD): New macro.
5529 * print.c (print_object): Use it.
5530
5531 * alloc.c: Use EMACS_INT, not int, to count objects.
5532 (total_conses, total_markers, total_symbols, total_vector_size)
5533 (total_free_conses, total_free_markers, total_free_symbols)
5534 (total_free_floats, total_floats, total_free_intervals)
5535 (total_intervals, total_strings, total_free_strings):
5536 Now EMACS_INT, not int. All uses changed.
5537 (Fgarbage_collect): Compute overall total using a double, so that
5538 integer overflow is less likely to be a problem. Check for overflow
5539 when converting back to an integer.
5540 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5541 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5542 These were 'int' variables that could overflow on 64-bit hosts;
5543 they were never used, so remove them instead of repairing them.
5544 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5545 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5546 Previously, this ceilinged at INT_MAX, but that doesn't work on
5547 64-bit machines.
5548 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5549
5550 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5551 (allocate_vectorlike): Check for ptrdiff_t overflow.
5552 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5553 when a (possibly-narrower) signed value would do just as well.
5554 We prefer using signed arithmetic, to avoid comparison confusion.
5555
5556 * alloc.c: Catch some string size overflows that we were missing.
5557 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5558 for convenience in STRING_BYTES_MAX.
5559 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5560 The definition here is exact; the one in lisp.h was approximate.
5561 (allocate_string_data): Check for string overflow. This catches
5562 some instances we weren't catching before. Also, it catches
5563 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5564 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5565 and ptrdiff_t and EMACS_INT are both 64 bits.
5566
5567 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5568 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5569 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5570
5571 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5572
5573 * alloc.c (Fmake_string): Check for out-of-range init.
5574
5575 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5576
5577 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5578
5579 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5580
5581 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5582 xg_get_default_scrollbar_width.
5583
5584 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5585 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5586 (style_changed_cb): Call update_theme_scrollbar_width and call
5587 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5588 all frames (Bug#8505).
5589 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5590 Call gtk_window_set_resizable if HAVE_GTK3.
5591 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5592 and height if HAVE_GTK3 (Bug#8505).
5593 (scroll_bar_width_for_theme): New variable.
5594 (update_theme_scrollbar_width): New function.
5595 (xg_get_default_scrollbar_width): Move code to
5596 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5597 (xg_initialize): Call update_theme_scrollbar_width.
5598
5599 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5600
5601 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5602
5603 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5604
5605 * frame.c (make_frame): Call other_buffer_safely instead of
5606 other_buffer.
5607
5608 * window.c (temp_output_buffer_show): Call display_buffer with
5609 second argument Vtemp_buffer_show_specifiers and reset latter
5610 immediately after the call.
5611 (Vtemp_buffer_show_specifiers): New variable.
5612 (auto_window_vscroll_p, next_screen_context_lines)
5613 (Vscroll_preserve_screen_position): Remove leading asterisks from
5614 doc-strings.
5615
5616 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5617
5618 Fix minor problems found by GCC 4.6.0 static checking.
5619 * buffer.c (Qclone_number): Remove for now, as it's unused.
5620 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5621 (record_buffer): Remove unused local.
5622 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5623 (set_frame_buffer_list): Remove; unused.
5624 * frame.h (other_visible_frames): Remove decl.
5625 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5626 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5627 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5628 if HAVE_GPM.
5629 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5630 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5631 Define only if HAVE_GPM.
5632 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5633 (update_hints_inhibit): Remove; never set. All uses removed.
5634 * widgetprv.h (emacsFrameClassRec): Remove decl.
5635 * window.c (delete_deletable_window): Now returns void, since it
5636 wasn't returning anything.
5637 (compare_window_configurations): Remove unused locals.
5638 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5639 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5640 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5641 the same widths as pointers. This follows up on the 2011-05-06 patch.
5642 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5643 * xterm.h: Likewise.
5644 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5645
5646 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5647
5648 * makefile.w32-in: Update dependencies.
5649 (LISP_H): Add lib/intprops.h.
5650
5651 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5652
5653 * image.c (gif_load): Add animation frame delay to the metadata.
5654 (syms_of_image): Use DEFSYM. New symbol `delay'.
5655
5656 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5657
5658 * window.c (delete_deletable_window): Re-add.
5659 (Fset_window_configuration): Rewrite to handle dead buffers and
5660 consequently deletable windows.
5661 (window_tree, Fwindow_tree): Remove. Supply functionality in
5662 window.el.
5663 (compare_window_configurations): Simplify code.
5664
5665 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5666
5667 * image.c (imagemagick_load_image): Fix type mismatch.
5668 (Fimagemagick_types): Likewise.
5669
5670 * window.h (replace_buffer_in_windows): Declare.
5671
5672 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5673
5674 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5675 Qclone_number. Remove external declaration of Qdelete_window.
5676 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5677 code.
5678 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5679 Run Qbuffer_list_update_hook if allowed.
5680 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5681 buffer list implementation.
5682 (other_buffer_safely): New function.
5683 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5684 calls to replace_buffer_in_windows and
5685 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5686 if allowed.
5687 (record_buffer): Inhibit quitting and rewrite using quittable
5688 functions. Run Qbuffer_list_update_hook if allowed.
5689 (Frecord_buffer, Funrecord_buffer): New functions.
5690 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5691 Move switch-to-buffer to window.el.
5692 (bury-buffer): Move to window.el.
5693 (Vbuffer_list_update_hook): New variable.
5694
5695 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5696 section.
5697
5698 * window.h (resize_frame_windows): Move up in code.
5699 (Fwindow_frame): Remove EXFUN.
5700 (replace_buffer_in_all_windows): Remove prototype.
5701 (replace_buffer_in_windows_safely): Add prototype.
5702
5703 * window.c: Declare Qdelete_window static again. Move down
5704 declaration of select_count.
5705 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5706 (Fother_window): Move to window.el.
5707 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5708 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5709 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5710 window.el.
5711 (replace_buffer_in_windows): Implement by calling
5712 Qreplace_buffer_in_windows.
5713 (replace_buffer_in_all_windows): Remove with some functionality
5714 moved into replace_buffer_in_windows_safely.
5715 (replace_buffer_in_windows_safely): New function.
5716 (select_window_norecord, select_frame_norecord): Move in front
5717 of run_window_configuration_change_hook. Remove now obsolete
5718 declarations.
5719 (Fset_window_buffer): Rewrite doc-string.
5720 Call Qrecord_window_buffer.
5721 (keys_of_window): Move binding for other-window to window.el.
5722
5723 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5724
5725 * dispextern.h (struct image): Replace data member, whose int_val
5726 and ptr_val fields were not used by anything, with a single
5727 lisp_val object.
5728
5729 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5730 (gif_clear_image, gif_load, imagemagick_load_image)
5731 (gs_clear_image, gs_load): Callers changed.
5732
5733 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5734
5735 * buffer.h: Include <time.h>, for time_t.
5736 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5737
5738 Fix minor problems found by static checking.
5739
5740 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5741
5742 Make identifiers static if they are not used in other modules.
5743 * data.c (Qcompiled_function, Qframe, Qvector):
5744 * image.c (QimageMagick, Qsvg):
5745 * minibuf.c (Qmetadata):
5746 * window.c (resize_window_check, resize_root_window): Now static.
5747 * window.h (resize_window_check, resize_root_window): Remove decls.
5748
5749 * window.c (window_deletion_count, delete_deletable_window):
5750 Remove; unused.
5751 (window_body_lines): Now static.
5752 (Fdelete_other_windows_internal): Mark vars as initialized.
5753 Make sure 'resize_failed' is initialized.
5754 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5755 (resize_window_apply): Remove unused local.
5756 * window.h (delete_deletable_window): Remove decl.
5757
5758 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5759 (imagemagick_load_image): Fix pointer signedness problem by changing
5760 last arg from unsigned char * to char *. All uses changed.
5761 Also, fix a local for similar reasons.
5762 Remove unused locals. Remove locals to avoid shadowing.
5763 (fn_rsvg_handle_free): Remove; unused.
5764 (svg_load, svg_load_image): Fix pointer signedness problem.
5765 (imagemagick_load_image): Don't use garbage pointer image_wand.
5766
5767 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5768
5769 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5770
5771 * image.c (gif_load): Fix omitted cast error introduced by
5772 2011-06-06 change.
5773
5774 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5775
5776 * window.h (resize_proportionally, orig_total_lines)
5777 (orig_top_line): Remove from window structure.
5778 (set_window_height, set_window_width, change_window_heights)
5779 (Fdelete_window): Remove prototypes.
5780 (resize_frame_windows): Remove duplicate declaration.
5781
5782 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5783
5784 * window.h (resize_frame_windows, resize_window_check)
5785 (delete_deletable_window, resize_root_window)
5786 (resize_frame_windows): Declare prototypes.
5787
5788 * window.c (resize_window_apply): Make definition be "static" to
5789 match the prototype.
5790
5791 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5792
5793 * window.c: Remove declarations of Qwindow_size_fixed,
5794 window_min_size_1, window_min_size_2, window_min_size,
5795 size_window, window_fixed_size_p, enlarge_window, delete_window.
5796 Remove static from declaration of Qdelete_window, it's
5797 temporarily needed by Fbury_buffer.
5798 (replace_window): Don't assign orig_top_line and
5799 orig_total_lines.
5800 (Fdelete_window, delete_window): Remove. Window deletion is
5801 handled by window.el.
5802 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5803 Replace Fdelete_window calls with calls to Qdelete_window.
5804 (Fdelete_other_windows): Remove. Deleting other windows is
5805 handled by window.el.
5806 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5807 handled in window.el.
5808 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5809 Window minimum sizes are handled in window.el.
5810 (shrink_windows, size_window, set_window_height)
5811 (set_window_width, change_window_heights, window_height)
5812 (window_width, CURBEG, CURSIZE, enlarge_window)
5813 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5814 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5815 handled in window.el.
5816 (make_dummy_parent): Rename to make_parent_window and give it a
5817 second argument horflag.
5818 (make_window): Don't set resize_proportionally any more.
5819 (Fsplit_window): Remove. Windows are split in window.el.
5820 (save_restore_action, save_restore_orig_size)
5821 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5822 Resize mini windows in window.el.
5823 (grow_mini_window, shrink_mini_window): Implement by calling
5824 Qresize_root_window_vertically, resize_window_check and
5825 resize_window_apply.
5826 (saved_window, Fset_window_configuration, save_window_save):
5827 Do not handle orig_top_line, orig_total_lines, and
5828 resize_proportionally.
5829 (window_min_height, window_min_width): Move to window.el.
5830 (keys_of_window): Move bindings for delete-other-windows,
5831 split-window, delete-window and enlarge-window to window.el.
5832
5833 * buffer.c: Temporarily extern Qdelete_window.
5834 (Fbury_buffer): Temporarily call Qdelete_window instead of
5835 Fdelete_window (Fbury_buffer will move to window.el soon).
5836
5837 * frame.c (set_menu_bar_lines_1): Remove code handling
5838 orig_top_line and orig_total_lines.
5839
5840 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5841 set_window_height but set heights directly.
5842 (change_frame_size_1): Use resize_frame_windows.
5843
5844 * xdisp.c (init_xdisp): Don't use set_window_height but set
5845 heights directly.
5846
5847 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5848 Use resize_frame_windows instead of change_window_heights and run
5849 run_window_configuration_change_hook.
5850
5851 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5852 instead of change_window_heights and run
5853 run_window_configuration_change_hook.
5854
5855 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5856
5857 * window.c (replace_window): Rename second argument REPLACEMENT to
5858 NEW. New third argument SETFLAG. Rewrite.
5859 (delete_window, make_dummy_parent): Call replace_window with
5860 third argument 1.
5861 (window_list_1): Move down in code.
5862 (run_window_configuration_change_hook): Move set_buffer part
5863 before select_frame_norecord part in order to unwind correctly.
5864 Rename count1 to count.
5865 (recombine_windows, delete_deletable_window, resize_root_window)
5866 (Fdelete_other_windows_internal)
5867 (Frun_window_configuration_change_hook, make_parent_window)
5868 (resize_window_check, resize_window_apply, Fresize_window_apply)
5869 (resize_frame_windows, Fsplit_window_internal)
5870 (Fdelete_window_internal, Fresize_mini_window_internal):
5871 New functions.
5872 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5873
5874 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5875
5876 * window.h (window): Add some new members to window structure -
5877 normal_lines, normal_cols, new_total, new_normal, clone_number,
5878 splits, nest, prev_buffers, next_buffers.
5879 (WINDOW_TOTAL_SIZE): Move here from window.c.
5880 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5881
5882 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5883 Remove.
5884 (make_dummy_parent): Set new members of windows structure.
5885 (make_window): Move down in code. Handle new members of window
5886 structure.
5887 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5888 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5889 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5890 (Fset_window_prev_buffers, Fwindow_next_buffers)
5891 (Fset_window_next_buffers, Fset_window_clone_number):
5892 New functions.
5893 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5894 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5895 Doc-string fixes.
5896 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5897 Argument WINDOW can be now internal window too.
5898 (Fwindow_use_time): Move up in code.
5899 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5900 Rewrite doc-string.
5901 (Fset_window_configuration, saved_window)
5902 (Fcurrent_window_configuration, save_window_save): Handle new
5903 members of window structure.
5904 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5905 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5906 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5907 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5908 Qget_mru_window, Qresize_root_window,
5909 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5910 Qauto_buffer_name; staticpro them.
5911
5912 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5913
5914 * window.c (Fwindow_total_size, Fwindow_left_column)
5915 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5916 (Fwindow_list_1): New functions.
5917 (window_box_text_cols): Replace with window_body_cols.
5918 (Fwindow_width, Fscroll_left, Fscroll_right):
5919 Use window_body_cols instead of window_box_text_cols.
5920 (delete_window, Fset_window_configuration):
5921 Call delete_all_subwindows with window as argument.
5922 (delete_all_subwindows): Take a window as argument and not a
5923 structure. Rewrite.
5924 (window_loop): Remove handling of GET_LRU_WINDOW and
5925 GET_LARGEST_WINDOW.
5926 (Fget_lru_window, Fget_largest_window): Move to window.el.
5927
5928 * window.h: Extern window_body_cols instead of
5929 window_box_text_cols. delete_all_subwindows now takes a
5930 Lisp_Object as argument.
5931
5932 * indent.c (compute_motion, Fcompute_motion):
5933 Use window_body_cols instead of window_box_text_cols.
5934
5935 * frame.c (delete_frame): Call delete_all_subwindows with root
5936 window as argument.
5937
5938 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5939
5940 * fns.c (Fputhash): Document return value.
5941
5942 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5943
5944 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5945
5946 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5947
5948 Cons<->int and similar integer overflow fixes (Bug#8794).
5949
5950 Check for overflow when converting integer to cons and back.
5951 * charset.c (Fdefine_charset_internal, Fdecode_char):
5952 Use cons_to_unsigned to catch overflow.
5953 (Fencode_char): Use INTEGER_TO_CONS.
5954 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5955 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5956 * data.c (long_to_cons, cons_to_long): Remove.
5957 (cons_to_unsigned, cons_to_signed): New functions.
5958 These signal an error for invalid or out-of-range values.
5959 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5960 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5961 * font.c (Ffont_variation_glyphs):
5962 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5963 * lisp.h: Include <intprops.h>.
5964 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5965 (cons_to_signed, cons_to_unsigned): New decls.
5966 (long_to_cons, cons_to_long): Remove decls.
5967 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5968 (Fprimitive_undo): Use CONS_TO_INTEGER.
5969 * xfns.c (Fx_window_property): Likewise.
5970 * xselect.c: Include <limits.h>.
5971 (x_own_selection, selection_data_to_lisp_data):
5972 Use INTEGER_TO_CONS.
5973 (x_handle_selection_request, x_handle_selection_clear)
5974 (x_get_foreign_selection, Fx_disown_selection_internal)
5975 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5976 (lisp_data_to_selection_data): Use cons_to_unsigned.
5977 (x_fill_property_data): Use cons_to_signed.
5978 Report values out of range.
5979
5980 Check for buffer and string overflow more precisely.
5981 * buffer.h (BUF_BYTES_MAX): New macro.
5982 * lisp.h (STRING_BYTES_MAX): New macro.
5983 * alloc.c (Fmake_string):
5984 * character.c (string_escape_byte8):
5985 * coding.c (coding_alloc_by_realloc):
5986 * doprnt.c (doprnt):
5987 * editfns.c (Fformat):
5988 * eval.c (verror):
5989 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5990 since they may not be the same number.
5991 * editfns.c (Finsert_char):
5992 * fileio.c (Finsert_file_contents):
5993 Likewise for BUF_BYTES_MAX.
5994
5995 * image.c: Use ptrdiff_t, not int, for sizes.
5996 (slurp_file): Switch from int to ptrdiff_t.
5997 All uses changed.
5998 (slurp_file): Check that file size fits in both size_t (for
5999 malloc) and ptrdiff_t (for sanity and safety).
6000
6001 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6002 if b->modtime has its maximal value.
6003
6004 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6005
6006 Don't assume time_t can fit into int.
6007 * buffer.h (struct buffer.modtime): Now time_t, not int.
6008 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6009 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6010
6011 Minor fixes for signed vs unsigned integers.
6012 * character.h (MAYBE_UNIFY_CHAR):
6013 * charset.c (maybe_unify_char):
6014 * keyboard.c (read_char, reorder_modifiers):
6015 XINT -> XFASTINT, since the integer must be nonnegative.
6016 * ftfont.c (ftfont_spec_pattern):
6017 * keymap.c (access_keymap, silly_event_symbol_error):
6018 XUINT -> XFASTINT, since the integer must be nonnegative.
6019 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6020 since it makes no difference and we prefer signed.
6021 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6022 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6023 nonnegative.
6024
6025 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6026
6027 * window.h (Fwindow_frame): Declare.
6028
6029 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6030
6031 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6032 (SPARE_MEMORY): Always define.
6033 (LARGE_REQUEST): Remove.
6034 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6035
6036 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6037
6038 * lisp.h: Move EXFUNS for Fframe_root_window,
6039 Fframe_first_window and Fset_frame_selected_window to window.h.
6040
6041 * window.h: Move EXFUNS for Fframe_root_window,
6042 Fframe_first_window and Fset_frame_selected_window here from
6043 lisp.h.
6044
6045 * frame.c (Fwindow_frame, Fframe_first_window)
6046 (Fframe_root_window, Fframe_selected_window)
6047 (Fset_frame_selected_window): Move to window.c.
6048 (Factive_minibuffer_window): Move to minibuf.c.
6049 (Fother_visible_frames_p): New function.
6050
6051 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6052
6053 * window.c (decode_window, decode_any_window): Move up in code.
6054 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6055 (inhibit_frame_unsplittable): Remove unused variable.
6056 (Fwindow_buffer): Move up and rewrite doc-string.
6057 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6058 (Fwindow_prev): New functions.
6059 (Fwindow_frame): Move here from frame.c. Accept any window as
6060 argument.
6061 (Fframe_root_window, Fframe_first_window)
6062 (Fframe_selected_window): Move here from frame.c. Accept frame
6063 or arbitrary window as argument. Update doc-strings.
6064 (Fminibuffer_window): Move up in code.
6065 (Fwindow_minibuffer_p): Move up in code and simplify.
6066 (Fset_frame_selected_window): Move here from frame.c.
6067 Marginal rewrite.
6068 (Fselected_window, select_window, Fselect_window): Move up in
6069 code. Minor doc-string fixes.
6070
6071 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6072
6073 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6074 Do not assume that spare memory exists; that assumption is valid
6075 only if SYSTEM_MALLOC.
6076 (LARGE_REQUEST): New macro, so that the issue of large requests
6077 is separated from the issue of spare memory.
6078
6079 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6080
6081 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6082 format. (Bug#8806)
6083
6084 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6085
6086 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6087 before statements.
6088
6089 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6090
6091 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6092
6093 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6094
6095 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6096 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6097
6098 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6099
6100 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6101
6102 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6103
6104 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6105 (x_clipboard_manager_save): Add return value.
6106 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6107 New error handlers.
6108 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6109 Obey Vx_select_enable_clipboard_manager. Catch errors in
6110 x_clipboard_manager_save (Bug#8779).
6111 (Vx_select_enable_clipboard_manager): New variable.
6112 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6113
6114 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6115
6116 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6117
6118 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6119
6120 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6121 in the current matrix if keep_current_p is non-zero.
6122
6123 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6124
6125 * bidi.c (bidi_level_of_next_char): Fix last change.
6126
6127 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6128
6129 Support bidi reordering of text covered by display properties.
6130
6131 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6132 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6133 (bidi_cache_search, bidi_cache_iterator_state)
6134 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6135 (bidi_level_of_next_char, bidi_move_to_visually_next):
6136 Support character positions inside a run of characters covered by a
6137 display string.
6138 (bidi_paragraph_init, bidi_resolve_explicit_1)
6139 (bidi_level_of_next_char): Call bidi_fetch_char and
6140 bidi_fetch_char_advance instead of FETCH_CHAR and
6141 FETCH_CHAR_ADVANCE.
6142 (bidi_init_it): Initialize new members.
6143 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6144 definitions.
6145 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6146 instead of using explicit *_CHAR codes.
6147 (bidi_resolve_explicit, bidi_resolve_weak):
6148 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6149 bidirectional text is supported only in multibyte buffers.
6150 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6151 it to initialize the frame_window_p member of struct bidi_it.
6152 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6153 (bidi_resolve_explicit, bidi_resolve_weak)
6154 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6155 bidi_it->nchars is non-positive.
6156 (bidi_level_of_next_char): Don't try to lookup the cache for the
6157 next/previous character if nothing is cached there yet, or if we
6158 were just reseat()'ed to a new position.
6159
6160 * xdisp.c (set_cursor_from_row): Set start and stop points
6161 according to the row's direction when priming the loop that looks
6162 for the glyph on which to display cursor.
6163 (single_display_spec_intangible_p): Function deleted.
6164 (display_prop_intangible_p): Reimplement to call
6165 handle_display_spec instead of single_display_spec_intangible_p.
6166 Accept 3 additional arguments needed by handle_display_spec.
6167 This fixes incorrect cursor motion across display property with complex
6168 values: lists, `(when COND...)' forms, etc.
6169 (single_display_spec_string_p): Support property values that are
6170 lists with the argument STRING its top-level element.
6171 (display_prop_string_p): Fix the condition for processing a
6172 property that is a list to be consistent with handle_display_spec.
6173 (handle_display_spec): New function, refactored from the
6174 last portion of handle_display_prop.
6175 (compute_display_string_pos): Accept additional argument
6176 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6177 value of a `display' property is a "replacing spec".
6178 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6179 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6180 the display property, but just return a value indicating whether
6181 the display property will replace the characters it covers.
6182 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6183 frame_window_p members of struct bidi_it.
6184 (compute_display_string_pos, compute_display_string_end):
6185 New functions.
6186 (push_it): Accept second argument POSITION, where pop_it should
6187 jump to continue iteration.
6188 (reseat_1): Initialize bidi_it.disp_pos.
6189
6190 * keyboard.c (adjust_point_for_property): Adjust the call to
6191 display_prop_intangible_p to its new signature.
6192
6193 * dispextern.h (struct bidi_it): New member frame_window_p.
6194 (bidi_init_it): Update prototypes.
6195 (display_prop_intangible_p): Update prototype.
6196 (compute_display_string_pos, compute_display_string_end):
6197 Declare prototypes.
6198 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6199 EMACS_INT.
6200
6201 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6202
6203 Malloc failure behavior now depends on size of allocation.
6204 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6205 * lisp.h: Change signatures accordingly.
6206 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6207 All callers changed. (Bug#8762)
6208
6209 * gnutls.c: Use Emacs's memory allocators.
6210 Without this change, the gnutls library would invoke malloc etc.
6211 directly, which causes problems on non-SYNC_INPUT hosts, and which
6212 runs afoul of improving memory_full behavior. (Bug#8761)
6213 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6214 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6215 xfree instead of the default malloc, realloc, free.
6216 (Fgnutls_boot): No need to check for memory allocation failure,
6217 since xmalloc does that for us.
6218
6219 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6220 * category.c (hash_get_category_set):
6221 * ccl.c (ccl_driver):
6222 * charset.c (Fdefine_charset_internal):
6223 * charset.h (struct charset.hash_index):
6224 * composite.c (get_composition_id, gstring_lookup_cache)
6225 (composition_gstring_put_cache):
6226 * composite.h (struct composition.hash_index):
6227 * dispextern.h (struct image.hash):
6228 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6229 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6230 (hashfn_equal, hashfn_user_defined, make_hash_table)
6231 (maybe_resize_hash_table, hash_lookup, hash_put)
6232 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6233 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6234 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6235 * image.c (make_image, search_image_cache, lookup_image)
6236 (xpm_put_color_table_h):
6237 * lisp.h (struct Lisp_Hash_Table):
6238 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6239 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6240 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6241 * alloc.c (allocate_vectorlike):
6242 Check for overflow in vector size calculations.
6243 * ccl.c (ccl_driver):
6244 Check for overflow when converting EMACS_INT to int.
6245 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6246 need to be updated by these changes.
6247 * fns.c (make_hash_table, maybe_resize_hash_table):
6248 Check for integer overflow with large hash tables.
6249 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6250 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6251 (SXHASH_REDUCE): New macro.
6252 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6253 Use it instead of discarding useful hash info with large hash values.
6254 (sxhash_float): New function.
6255 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6256 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6257 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6258 Rewrite to use FIXNUM_BITS, as this simplifies things.
6259 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6260 Adjust signatures to match updated version of code.
6261 (consing_since_gc): Now EMACS_INT, since a single hash table can
6262 use more than INT_MAX bytes.
6263
6264 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6265
6266 Make it possible to build with GCC-4.6+ -O2 -flto.
6267
6268 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6269
6270 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6271
6272 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6273 Call minibuffer-inactive-mode.
6274
6275 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6276
6277 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6278 Update dependencies.
6279
6280 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6281
6282 * data.c (init_data): Remove code for UTS, this system is not
6283 supported anymore.
6284
6285 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6286
6287 Don't force ./temacs to start in terminal mode.
6288
6289 * frame.c (make_initial_frame): Initialize faces in all cases, not
6290 only when CANNOT_DUMP is defined.
6291 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6292
6293 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6294
6295 * dispnew.c (add_window_display_history): Use const for the string
6296 pointer. Remove declaration, not needed.
6297
6298 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6299
6300 Use 'inline', not 'INLINE'.
6301 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6302 * alloc.c, fontset.c (INLINE): Remove.
6303 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6304 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6305 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6306 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6307 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6308
6309 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6310
6311 Make it possible to run ./temacs.
6312
6313 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6314 syms_of_callproc does the same thing. Remove test for
6315 "initialized", do it in the caller.
6316 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6317
6318 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6319
6320 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6321 (read_minibuf): Use get_minibuffer.
6322 (syms_of_minibuf): Use DEFSYM.
6323 (Qmetadata): New var.
6324 * data.c (Qbuffer): Don't make it static.
6325 (syms_of_data): Use DEFSYM.
6326
6327 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6328
6329 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6330 (CCL_CODE_MIN): New macro.
6331
6332 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6333
6334 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6335
6336 * eval.c (Qdebug): Now static.
6337 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6338 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6339 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6340
6341 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6342
6343 * image.c: Various fixes to ImageMagick code comments.
6344 (Fimagemagick_types): Doc fix.
6345
6346 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6347
6348 Minor fixes prompted by GCC 4.6.0 warnings.
6349
6350 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6351
6352 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6353 (x_clipboard_manager_save_all): Move extern decl to ...
6354 * xterm.h: ... here, so that it can be checked for consistency.
6355
6356 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6357
6358 * xselect.c (x_clipboard_manager_save_frame)
6359 (x_clipboard_manager_save_all): New functions.
6360 (Fx_clipboard_manager_save): Lisp function deleted.
6361
6362 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6363 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6364
6365 * xterm.h: Update prototype.
6366
6367 2011-05-28 William Xu <william.xwl@gmail.com>
6368
6369 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6370 exiting (Bug#8239).
6371
6372 2011-05-28 Jim Meyering <meyering@redhat.com>
6373
6374 Avoid a sign-extension bug in crypto_hash_function.
6375 * fns.c (to_uchar): Define.
6376 (crypto_hash_function): Use it to convert some newly-signed
6377 variables to unsigned, to avoid sign-extension bugs. For example,
6378 without this change, (md5 "truc") would evaluate to
6379 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6380 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6381 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6382
6383 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6384
6385 Integer overflow fixes.
6386
6387 * dbusbind.c: Serial number integer overflow fixes.
6388 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6389 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6390 to hold a serial number that is too large for a fixnum.
6391 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6392 Check for serial numbers out of range. Decode any serial number
6393 that was so large that it became a float. (Bug#8722)
6394
6395 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6396 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6397 Use XFASTINT rather than XUINT when numbers are nonnegative.
6398 (xd_append_arg, Fdbus_method_return_internal):
6399 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6400 arguments, check that Lisp number is nonnegative, rather than
6401 silently wrapping negative numbers around. (Bug#8722)
6402 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6403 (Bug#8722)
6404
6405 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6406
6407 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6408
6409 ccl: Add integer overflow checks.
6410 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6411 (IN_INT_RANGE): New macros.
6412 (ccl_driver): Use them to check for integer overflow when
6413 decoding a CCL program. Many of the new checks are whether XINT (x)
6414 fits in int; it doesn't always, on 64-bit hosts. The new version
6415 doesn't catch all possible integer overflows, but it's an
6416 improvement. (Bug#8719)
6417
6418 * alloc.c (make_event_array): Use XINT, not XUINT.
6419 There's no need for unsigned here.
6420
6421 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6422 This follows up to the 2011-05-06 change that substituted uintptr_t
6423 for EMACS_INT. This case wasn't caught back then.
6424
6425 Rework Fformat to avoid integer overflow issues.
6426 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6427 now (part of C89). Include <verify.h>.
6428 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6429 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6430 (Fformat): Avoid the prepass trying to compute sizes; it was only
6431 approximate and thus did not catch overflow reliably. Instead, walk
6432 through the format just once, formatting and computing sizes as we go,
6433 checking for integer overflow at every step, and allocating a larger
6434 buffer as needed. Keep track separately whether the format is
6435 multibyte. Keep only the most-recently calculated precision, rather
6436 than them all. Record whether each argument has been converted to
6437 string. Use EMACS_INT, not int, for byte and char and arg counts.
6438 Support field widths and precisions larger than INT_MAX. Avoid
6439 sprintf's undefined behavior with conversion specifications such as %#d
6440 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6441 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6442 formatting out-of-range floating point numbers with int
6443 formats. (Bug#8668)
6444
6445 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6446
6447 * data.c: Avoid integer truncation in expressions involving floats.
6448 * data.c: Include <intprops.h>.
6449 (arith_driver): When there's an integer overflow in an expression
6450 involving floating point, convert the integers to floating point
6451 so that the resulting value does not suffer from catastrophic
6452 integer truncation. For example, on a 64-bit host (* 4
6453 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6454 Do not rely on undefined behavior after integer overflow.
6455
6456 merge count_size_as_multibyte, parse_str_to_multibyte
6457 * character.c, character.h (count_size_as_multibyte):
6458 Rename from parse_str_to_multibyte; all uses changed.
6459 Check for integer overflow.
6460 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6461 since it's now a duplicate of the other. This is more of
6462 a character than a buffer op, so better that it's in character.c.
6463 * fns.c, print.c: Adjust to above changes.
6464
6465 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6466
6467 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6468
6469 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6470
6471 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6472 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6473 (x_clipboard_manager_save): Now static.
6474 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6475
6476 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6477 (crypto_hash_function): Now static.
6478 Fix pointer signedness problems. Avoid unnecessary initializations.
6479
6480 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6481
6482 * termhooks.h (Vselection_alist): Make it terminal-local.
6483
6484 * terminal.c (create_terminal): Initialize it.
6485
6486 * xselect.c: Support for clipboard managers.
6487 (Vselection_alist): Move to termhooks.h as terminal-local var.
6488 (LOCAL_SELECTION): New macro.
6489 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6490 (symbol_to_x_atom): Remove gratuitous arg.
6491 (x_handle_selection_request, lisp_data_to_selection_data)
6492 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6493 (x_own_selection, x_get_local_selection, x_convert_selection):
6494 New arg, specifying work frame. Use terminal-local Vselection_alist.
6495 (some_frame_on_display): Delete unused function.
6496 (Fx_own_selection_internal, Fx_get_selection_internal)
6497 (Fx_disown_selection_internal, Fx_selection_owner_p)
6498 (Fx_selection_exists_p): New optional frame arg.
6499 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6500 (x_handle_selection_clear): Don't treat other terminals with the
6501 same keyboard specially. Use the terminal-local Vselection_alist.
6502 (x_clear_frame_selections): Use Frun_hook_with_args.
6503
6504 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6505
6506 * xterm.h: Add support for those atoms.
6507
6508 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6509
6510 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6511 (converted_selections, conversion_fail_tag): New global variables.
6512 (x_selection_request_lisp_error): Free the above.
6513 (x_get_local_selection): Remove unnecessary code.
6514 (x_reply_selection_request): Args changed; handle arbitrary array
6515 of converted selections stored in converted_selections.
6516 Separate the XChangeProperty and SelectionNotify steps.
6517 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6518 (x_convert_selection): New function.
6519 (x_handle_selection_event): Simplify.
6520 (x_get_foreign_selection): Don't ignore incoming requests while
6521 waiting for an answer; this will fail when we implement
6522 SAVE_TARGETS, and seems unnecessary anyway.
6523 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6524 (Vx_sent_selection_functions): Doc fix.
6525
6526 2011-05-26 Leo Liu <sdl.web@gmail.com>
6527
6528 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6529
6530 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6531
6532 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6533
6534 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6535 for fringe update if it has periodic bitmap.
6536 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6537 and fringe_bitmap_periodic_p.
6538
6539 * fringe.c (get_fringe_bitmap_data): New function.
6540 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6541 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6542 row. Mark glyph row for fringe update if periodicity changed.
6543
6544 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6545 for fringe update unless it has periodic bitmap.
6546
6547 2011-05-25 Kenichi Handa <handa@m17n.org>
6548
6549 * xdisp.c (get_next_display_element): Set correct it->face_id for
6550 a static composition.
6551
6552 2011-05-24 Leo Liu <sdl.web@gmail.com>
6553
6554 * deps.mk (fns.o):
6555 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6556
6557 * fns.c (crypto_hash_function, Fsha1): New function.
6558 (Fmd5): Use crypto_hash_function.
6559 (syms_of_fns): Add Ssha1.
6560
6561 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6562
6563 * gnutls.c: Remove unused macros.
6564 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6565 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6566 Remove macros that are defined and never used.
6567 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6568
6569 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6570
6571 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6572 (Fx_get_selection_internal): Minor cleanup.
6573 (Fx_own_selection_internal): Rename arguments for consistency with
6574 select.el.
6575
6576 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6577
6578 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6579
6580 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6581
6582 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6583
6584 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6585
6586 * dispnew.c (scrolling_window): Don't exclude the case that the
6587 last enabled row in the desired matrix touches the bottom boundary.
6588
6589 2011-05-21 Glenn Morris <rgm@gnu.org>
6590
6591 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6592 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6593 and add some more files.
6594
6595 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6596
6597 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6598 report_file_error introduced by the change from 2011-05-07.
6599
6600 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6601
6602 * systime.h (Time): Define only if emacs is defined.
6603 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6604 where the include path doesn't have X11/X.h by default. See
6605 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6606
6607 2011-05-20 Kenichi Handa <handa@m17n.org>
6608
6609 * composite.c (find_automatic_composition): Fix previous change.
6610
6611 2011-05-20 Glenn Morris <rgm@gnu.org>
6612
6613 * lisp.mk: New file, split from Makefile.in.
6614 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6615 (shortlisp): Remove.
6616 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6617
6618 2011-05-19 Glenn Morris <rgm@gnu.org>
6619
6620 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6621 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6622 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6623 (lisp): Set the order to that of loadup.el.
6624 (shortlisp): Make it a copy of $lisp.
6625 (SOME_MACHINE_LISP): Remove.
6626 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6627 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6628
6629 2011-05-18 Kenichi Handa <handa@m17n.org>
6630
6631 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6632 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6633 (find_automatic_composition): Mostly rewrite for efficiency.
6634
6635 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * makefile.w32-in: Update dependencies.
6638
6639 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6640
6641 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6642 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6643
6644 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6645
6646 Fix some integer overflow issues, such as string length overflow.
6647
6648 * insdel.c (count_size_as_multibyte): Check for string overflow.
6649
6650 * character.c (lisp_string_width): Check for string overflow.
6651 Use EMACS_INT, not int, for string indexes and lengths; in
6652 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6653 the resulting string length overflows an EMACS_INT; instead,
6654 report a string overflow if no precision given. When checking for
6655 precision exhaustion, use a check that cannot possibly have
6656 integer overflow. (Bug#8675)
6657 * character.h (lisp_string_width): Adjust to new signature.
6658
6659 * alloc.c (string_overflow): New function.
6660 (Fmake_string): Use it. This doesn't change behavior, but saves
6661 a few bytes and will simplify future changes.
6662 * character.c (string_escape_byte8): Likewise.
6663 * lisp.h (string_overflow): New decl.
6664
6665 Fixups, following up to the user-interface timestamp change.
6666 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6667 for UI timestamps, instead of unsigned long.
6668 * msdos.c (mouse_get_pos): Likewise.
6669 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6670 * w32gui.h (Time): Define by including "systime.h" rather than by
6671 declaring it ourselves. (Bug#8664)
6672
6673 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6674 * image.c (clear_image_cache): Likewise.
6675
6676 * term.c (term_mouse_position): Don't assume time_t wraparound.
6677
6678 Be more systematic about user-interface timestamps.
6679 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6680 and sometimes 'EMACS_UINT', to represent these timestamps.
6681 This change causes it to use 'Time' uniformly, as that's what X uses.
6682 This makes the code easier to follow, and makes it easier to catch
6683 integer overflow bugs such as Bug#8664.
6684 * frame.c (Fmouse_position, Fmouse_pixel_position):
6685 Use Time, not unsigned long, for user-interface timestamps.
6686 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6687 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6688 * keyboard.h (last_event_timestamp): Likewise.
6689 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6690 * menu.h (xmenu_show): Likewise.
6691 * term.c (term_mouse_position): Likewise.
6692 * termhooks.h (struct input_event.timestamp): Likewise.
6693 (struct terminal.mouse_position_hook): Likewise.
6694 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6695 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6696 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6697 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6698 what it was before.
6699 * menu.h, termhooks.h: Include "systime.h", for Time.
6700
6701 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6702 Don't assume that the difference between two unsigned long values
6703 can fit into an integer. At this point, we know button_down_time
6704 <= event->timestamp, so the difference must be nonnegative, so
6705 there's no need to cast the result if double-click-time is
6706 nonnegative, as it should be; check that it's nonnegative, just in
6707 case. This bug is triggered when events are more than 2**31 ms
6708 apart (about 25 days). (Bug#8664)
6709
6710 * xselect.c (last_event_timestamp): Remove duplicate decl.
6711 (x_own_selection): Remove needless cast to unsigned long.
6712
6713 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6714 that always fit in int. Use a sentinel instead of a counter, to
6715 avoid a temp and to allay GCC's concerns about possible int overflow.
6716 * frame.h (struct frame): Use int for menu_bar_items_used
6717 instead of EMACS_INT, since it always fits in int.
6718
6719 * menu.c (grow_menu_items): Check for int overflow.
6720
6721 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6722
6723 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6724 Before, the code was not consistent. These values cannot exceed
6725 2**31 - 1 so there's no need to make them unsigned.
6726 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6727 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6728 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6729 as modifiers.
6730 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6731
6732 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6733 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6734 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6735 presumably because the widths might not match.
6736
6737 * window.c (size_window): Avoid needless test at loop start.
6738
6739 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6740
6741 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6742
6743 2011-05-12 Drew Adams <drew.adams@oracle.com>
6744
6745 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6746
6747 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6748
6749 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6750 `width' to `bar_area_x' and `bar_area_width', respectively.
6751 (x_scroll_run): Take account of fringe background extension.
6752
6753 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6754 Rename local vars `left' and `width' to `bar_area_x' and
6755 `bar_area_width', respectively.
6756 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6757 background extension.
6758
6759 2011-05-10 Jim Meyering <meyering@redhat.com>
6760
6761 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6762
6763 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6764
6765 * image.c (Finit_image_library): Return t for built-in image types,
6766 like pbm and xbm. (Bug#8640)
6767
6768 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6769
6770 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6771
6772 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6773
6774 * w32console.c (Fset_screen_color): Doc fix.
6775 (Fget_screen_color): New function.
6776 (syms_of_ntterm): Defsubr it.
6777
6778 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6779 unlink the temporary file if Fcall_process didn't create it in the
6780 first place.
6781 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6782 child process will be redirected to a file specified with `:file'.
6783 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6784 cue to call_process_cleanup not to close that handle.
6785
6786 2011-05-07 Ben Key <bkey76@gmail.com>
6787
6788 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6789 one of two shell specific rules, either bootstrap-temacs-CMD or
6790 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6791 to the previous implementation of the bootstrap-temacs rule.
6792 The bootstrap-temacs-CMD rule is similar to the previous
6793 implementation of the bootstrap-temacs rule except that it
6794 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6795 variable.
6796
6797 These changes, along with some changes to nt/configure.bat,
6798 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6799 earlier fix to add support for --cflags and --ldflags options
6800 that include quotes so that it works whether make uses cmd or
6801 sh as the shell.
6802
6803 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6804
6805 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6806 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6807 is a constant.
6808 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6809 a string. Handle both cases.
6810 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6811 (Fdbus_register_method): Use Qinvalid_function.
6812
6813 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6814
6815 * makefile.w32-in: Update dependencies.
6816 (LISP_H): Add inttypes.h and stdin.h.
6817 (PROCESS_H): Add unistd.h.
6818
6819 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6820
6821 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6822 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6823
6824 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6825
6826 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6827
6828 * term.c (vfatal): Remove stray call to va_end.
6829 It's not needed and the C Standard doesn't allow it here anyway.
6830
6831 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6832 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6833
6834 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6835 bytes.
6836
6837 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6838
6839 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6840
6841 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6842
6843 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6844
6845 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6846
6847 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6848 * charset.c (Fdefine_charset_internal): Don't initialize
6849 charset.code_space[15]. The value was garbage, on hosts with
6850 32-bit int (Bug#8600).
6851
6852 * lread.c (read_integer): Be more consistent with string-to-number.
6853 Use string_to_number to do the actual conversion; this avoids
6854 rounding errors and fixes some other screwups. Without this fix,
6855 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6856 (digit_to_number): Move earlier, for benefit of read_integer.
6857 Return -1 if the digit is out of range for the base, -2 if it is
6858 not a digit in any supported base. (Bug#8602)
6859
6860 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6861
6862 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6863 to match comment at start of function. This also removes a
6864 GCC warning about overflow in a 32+64-bit port.
6865
6866 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6867
6868 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6869 Reported by Stefan Monnier in
6870 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6871 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6872 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6873
6874 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6875 (EMACS_UINTPTR): Likewise, with uintptr_t.
6876
6877 * lisp.h: Prefer 64-bit EMACS_INT if available.
6878 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6879 on 32-bit hosts that have 64-bit int, so that they can access
6880 large files.
6881 However, temporarily disable this change unless the temporary
6882 symbol WIDE_EMACS_INT is defined.
6883
6884 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6885
6886 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6887 This removes an assumption that EMACS_INT and long are the same
6888 width as pointers. The assumption is true for Emacs porting targets
6889 now, but we want to make other targets possible.
6890 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6891 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6892 In the rest of the code, change types of integers that hold casted
6893 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6894 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6895 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6896 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6897 No need to cast type when ORing.
6898 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6899 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6900 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6901 assume EMACS_INT is the same width as char *.
6902 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6903 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6904 Remove no-longer-needed casts.
6905 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6906 (xg_tool_bar_help_callback, xg_make_tool_item):
6907 Use EMACS_INTPTR to hold an integer
6908 that will be cast to void *; this can avoid a GCC warning
6909 if EMACS_INT is not the same width as void *.
6910 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6911 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6912 (current_message_1, set_message_1):
6913 Use a local to convert to proper width without a cast.
6914 * xmenu.c (dialog_selection_callback): Likewise.
6915
6916 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6917 Also, don't assume VALBITS / RAND_BITS is less than 5,
6918 and don't rely on undefined behavior when shifting a 1 left into
6919 the sign bit.
6920 * lisp.h (get_random): Change signature to match.
6921
6922 * lread.c (hash_string): Use size_t, not int, for hash computation.
6923 Normally we prefer signed values; but hashing is special, because
6924 it's better to use unsigned division on hash table sizes so that
6925 the remainder is nonnegative. Also, size_t is the natural width
6926 for hashing into memory. The previous code used 'int', which doesn't
6927 retain enough info to hash well into very large tables.
6928 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6929
6930 * dbusbind.c: Don't possibly lose pointer info when converting.
6931 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6932 Use XPNTR rather than XHASH, so that the high-order bits of
6933 the pointer aren't lost when converting through void *.
6934
6935 * eval.c (Fautoload): Don't double-shift a pointer.
6936
6937 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6938
6939 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6940
6941 * gnutls.c (DEF_GNUTLS_FN):
6942 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6943
6944 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6945
6946 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6947 marker. (Bug#8610)
6948
6949 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6950
6951 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6952 New version that can reserve upto 2GB of heap space.
6953
6954 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6955
6956 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6957
6958 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6959
6960 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6961 `gnutls_certificate_set_x509_key_file'.
6962
6963 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6964
6965 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6966 Update dependencies.
6967
6968 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6969
6970 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6971 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6972 Remove unused parameter `fildes'.
6973 * process.c (read_process_output, send_process): Don't pass it.
6974
6975 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6976
6977 Fix previous change: the library cache is defined in w32.c.
6978 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6979 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6980
6981 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6982
6983 Implement dynamic loading of GnuTLS on Windows.
6984
6985 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6986 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6987 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6988 Declare.
6989
6990 * gnutls.c (Qgnutls_dll): Define.
6991 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6992 (gnutls_*): Declare function pointers.
6993 (init_gnutls_functions): New function to initialize function pointers.
6994 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6995 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6996 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6997 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6998 (emacs_gnutls_write, emacs_gnutls_read)
6999 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7000 (Fgnutls_available_p): New function.
7001 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7002 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7003 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7004
7005 * image.c: Include w32.h.
7006 (Vimage_type_cache): Delete.
7007 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7008 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7009 (w32_delayed_load): Move to w32.c.
7010
7011 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7012
7013 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7014 (w32_delayed_load): Move from image.c. When loading a library, record
7015 its filename in the :loaded-from property of the library id.
7016 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7017 Initialize and staticpro them.
7018 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7019
7020 * process.c: Include lisp.h before w32.h, not after.
7021 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7022 instead of gnutls_record_check_pending.
7023
7024 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7025
7026 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7027
7028 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7029 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7030 as passed in.
7031
7032 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7033
7034 * xterm.c (x_set_frame_alpha): Do not set property on anything
7035 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7036
7037 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7038
7039 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7040
7041 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7042
7043 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7044 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7045 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7046 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7047 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7048 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7049 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7050 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7051 (Qgnutls_bootprop_callbacks_verify): Make static.
7052
7053 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7054
7055 * callproc.c: Indentation fixup.
7056
7057 * sysdep.c (wait_for_termination_1): Make static.
7058 (wait_for_termination, interruptible_wait_for_termination):
7059 Move after wait_for_termination_1.
7060
7061 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7062
7063 * sysdep.c (interruptible_wait_for_termination): New function
7064 which is like wait_for_termination, but allows keyboard
7065 interruptions.
7066
7067 * callproc.c (Fcall_process): Add (:file "file") as an option for
7068 the STDOUT buffer.
7069 (Fcall_process_region): Ditto.
7070
7071 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7072
7073 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7074 rather than `XVECTOR (FOO)->size'.
7075
7076 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7077 inttypes.h, as a gnulib replacement is used if it not available in
7078 system headers.
7079
7080 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7081
7082 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7083 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7084 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7085
7086 * coding.c (coding_alloc_by_realloc): Error out if destination
7087 will grow beyond MOST_POSITIVE_FIXNUM.
7088 (decode_coding_emacs_mule): Abort if there isn't enough place in
7089 charbuf for the composition carryover bytes. Reserve an extra
7090 space for up to 2 characters produced in a loop.
7091 (decode_coding_iso_2022): Abort if there isn't enough place in
7092 charbuf for the composition carryover bytes.
7093
7094 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7095
7096 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7097 aborting when %lld or %lll format is passed.
7098 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7099 %llo or %llx format is passed. (Bug#8545)
7100
7101 * window.c (window_scroll_line_based): Use a marker instead of
7102 simple variables to record original value of point. (Bug#7952)
7103
7104 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7105 produced by %s or %c overflows available buffer space. (Bug#8545)
7106
7107 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7108
7109 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7110 (SIZE_MAX): Move defn after all includes, as they might #define it.
7111
7112 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7113
7114 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7115
7116 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7117
7118 * keyboard.c (Qdelayed_warnings_hook): Define.
7119 (command_loop_1): Run `delayed-warnings-hook'
7120 if Vdelayed_warnings_list is non-nil.
7121 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7122 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7123
7124 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7125
7126 * doprnt.c (doprnt): Don't return value smaller than the buffer
7127 size if the message was truncated. (Bug#8545).
7128
7129 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7130
7131 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7132 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7133
7134 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7135
7136 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7137
7138 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7139
7140 * makefile.w32-in: Update dependencies.
7141
7142 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7143
7144 Improve `doprnt' and its usage. (Bug#8545)
7145 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7146 `format_end'. Remove support for %l as a conversion specifier.
7147 Don't use xrealloc. Improve diagnostics when the %l size modifier
7148 is used. Update the commentary.
7149
7150 * eval.c (verror): Simplify calculation of size_t.
7151
7152 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7153 messages.
7154
7155 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7156
7157 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7158 change.
7159
7160 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7161
7162 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7163 This makes this file independent of the recent pseudovector change.
7164
7165 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7166
7167 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7168
7169 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7170 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7171 Remove unused local.
7172 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7173
7174 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7175 GCC 4.6.0 optimizes based on type-based alias analysis.
7176 For example, if b is of type struct buffer * and v of type struct
7177 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7178 != &v->size, and therefore "v->size = 1; b->size = 2; return
7179 v->size;" must therefore return 1. This assumption is incorrect
7180 for Emacs, since it type-puns struct Lisp_Vector * with many other
7181 types. To fix this problem, this patch adds a new type struct
7182 vectorlike_header that documents the constraints on layout of vectors
7183 and pseudovectors, and helps optimizing compilers not get fooled
7184 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7185 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7186 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7187 the size member.
7188 (XSETPVECTYPE): Rewrite in terms of new macro.
7189 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7190 This is a bit clearer, and further avoids the possibility of
7191 undesirable aliasing.
7192 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7193 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7194 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7195 since Lisp_Subr is a special case (no "next" field).
7196 (ASIZE): Now uses header.size rather than size.
7197 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7198 to avoid the hassle of writing XVECTOR (foo)->header.size.
7199 (struct vectorlike_header): New type.
7200 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7201 object, to help avoid aliasing.
7202 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7203 (SUBRP): Likewise, since Lisp_Subr is a special case.
7204 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7205 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7206 (struct Lisp_Hash_Table): Combine first two members into a single
7207 struct vectorlike_header member. All uses of "size" and "next" members
7208 changed to be "header.size" and "header.next".
7209 * buffer.h (struct buffer): Likewise.
7210 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7211 * frame.h (struct frame): Likewise.
7212 * process.h (struct Lisp_Process): Likewise.
7213 * termhooks.h (struct terminal): Likewise.
7214 * window.c (struct save_window_data, struct saved_window): Likewise.
7215 * window.h (struct window): Likewise.
7216 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7217 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7218 * buffer.c (init_buffer_once): Likewise.
7219 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7220 special case.
7221 * process.c (Fformat_network_address): Use local var for size,
7222 for brevity.
7223
7224 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7225
7226 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7227 * data.c (atof): Remove decl; no longer used or needed.
7228 (digit_to_number): Move to lread.c.
7229 (Fstring_to_number): Use new string_to_number function, to be
7230 consistent with how the Lisp reader treats infinities and NaNs.
7231 Do not assume that floating-point numbers represent EMACS_INT
7232 without losing information; this is not true on most 64-bit hosts.
7233 Avoid double-rounding errors, by insisting on integers when
7234 parsing non-base-10 numbers, as the documentation specifies.
7235 * lisp.h (string_to_number): New decl, replacing ...
7236 (isfloat_string): Remove.
7237 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7238 (read1): Do not accept +. and -. as integers; this
7239 appears to have been a coding error. Similarly, do not accept
7240 strings like +-1e0 as floating point numbers. Do not report
7241 overflow for integer overflows unless the base is not 10 which
7242 means we have no simple and reliable way to continue.
7243 Break out the floating-point parsing into a new
7244 function string_to_number, so that Fstring_to_number parses
7245 floating point numbers consistently with the Lisp reader.
7246 (digit_to_number): Move here from data.c. Make it static inline.
7247 (E_CHAR, EXP_INT): Remove, replacing with ...
7248 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7249 (string_to_number): New function, replacing isfloat_string.
7250 This function checks for valid syntax and produces the resulting
7251 Lisp float number too. Rework it so that string-to-number
7252 no longer mishandles examples like "1.0e+". Use strtoumax,
7253 so that overflow for non-base-10 numbers is reported only when
7254 there's no portable and simple way to convert to floating point.
7255
7256 * textprop.c (set_text_properties_1): Rewrite for clarity,
7257 and to avoid GCC warning about integer overflow.
7258
7259 * intervals.h (struct interval): Use EMACS_INT for members
7260 where EMACS_UINT might cause problems. See
7261 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7262 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7263 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7264 All uses changed.
7265 (offset_intervals): Tell GCC not to worry about length overflow
7266 when negating a negative length.
7267
7268 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7269 (overrun_check_free): Likewise.
7270
7271 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7272 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7273 word size.
7274
7275 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7276 (gnutls_make_error): Rename local to avoid shadowing.
7277 (gnutls_emacs_global_deinit): ifdef out; not used.
7278 (Fgnutls_boot): Use const for pointer to readonly storage.
7279 Comment out unused local. Fix pointer signedness problems.
7280
7281 * lread.c (openp): Don't stuff size_t into an 'int'.
7282 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7283 about possible signed overflow.
7284
7285 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7286 (GDK_KEY_g): Don't define if already defined.
7287 (xg_prepare_tooltip): Avoid pointer signedness problem.
7288 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7289
7290 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7291 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7292
7293 * xfns.c (Fx_window_property): Simplify a bit,
7294 to make a bit faster and to avoid GCC 4.6.0 warning.
7295 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7296
7297 * fns.c (internal_equal): Don't assume size_t fits in int.
7298
7299 * alloc.c (compact_small_strings): Tighten assertion a little.
7300
7301 Replace pEd with more-general pI, and fix some printf arg casts.
7302 * lisp.h (pI): New macro, generalizing old pEd macro to other
7303 conversion specifiers. For example, use "...%"pI"d..." rather
7304 than "...%"pEd"...".
7305 (pEd): Remove. All uses replaced with similar uses of pI.
7306 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7307 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7308 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7309 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7310 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7311 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7312 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7313 64-bit hosts.
7314 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7315 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7316 * print.c (safe_debug_print, print_object): Likewise.
7317 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7318 to int.
7319 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7320 avoiding the 0 flag, which is not portable.
7321 * process.c (Fmake_network_process): Use pI to avoid cast.
7322 * region-cache.c (pp_cache): Likewise.
7323 * xdisp.c (decode_mode_spec): Likewise.
7324 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7325 behavior on 64-bit hosts with printf arg.
7326 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7327 (x_stop_queuing_selection_requests): Likewise.
7328 (x_get_window_property): Don't truncate byte count to an 'int'
7329 when tracing.
7330
7331 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7332 here, since it parses constructs like leading '-' and spaces,
7333 which are not wanted; and it overflows with large numbers.
7334 Instead, simply match F[0-9]+, which is what is wanted anyway.
7335
7336 * alloc.c: Remove unportable assumptions about struct layout.
7337 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7338 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7339 (allocate_vectorlike, make_pure_vector): Use the new macros,
7340 plus offsetof, to remove unportable assumptions about struct layout.
7341 These assumptions hold on all porting targets that I know of, but
7342 they are not guaranteed, they're easy to remove, and removing them
7343 makes further changes easier.
7344
7345 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7346 This doesn't fix a bug but makes the code clearer.
7347 (string_overrun_cookie): Now const. Use initializers that
7348 don't formally overflow signed char, to avoid warnings.
7349 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7350 can cause Emacs to crash when string overrun checking is enabled.
7351 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7352 multiple of sizeof (EMACS_INT); it need not be, if
7353 alignof(EMACS_INT) < sizeof (EMACS_INT).
7354 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7355
7356 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7357
7358 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7359
7360 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7361
7362 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7363 supposed to be handshaking. (Bug#8556)
7364 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7365
7366 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7367
7368 * lisp.h (Qdebug): List symbol.
7369 * eval.c (Qdebug): Restore global linkage.
7370 * keyboard.c (debug-on-event): New variable.
7371 (handle_user_signal): Break into debugger when debug-on-event
7372 matches the current signal symbol.
7373
7374 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7375
7376 * alloc.c (check_sblock, check_string_bytes)
7377 (check_string_free_list): Convert to standard C.
7378
7379 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7380
7381 * w32.c (emacs_gnutls_push): Fix typo.
7382
7383 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7384
7385 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7386 "cast to pointer from integer of different size".
7387
7388 Improve doprnt and its use in verror. (Bug#8545)
7389 * doprnt.c (doprnt): Document the set of format control sequences
7390 supported by the function. Use SAFE_ALLOCA instead of always
7391 using `alloca'.
7392
7393 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7394 is one byte too soon. Don't use xrealloc; instead xfree and
7395 xmalloc anew.
7396
7397 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7398
7399 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7400 callbacks stage.
7401
7402 * gnutls.c: Renamed global_initialized to
7403 gnutls_global_initialized. Added internals for the
7404 :verify-hostname-error, :verify-error, and :verify-flags
7405 parameters of `gnutls-boot' and documented those parameters in the
7406 docstring. Start callback support.
7407 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7408 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7409 on error. Return error code.
7410 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7411 (emacs_gnutls_read): Likewise.
7412 (Fgnutls_boot): Return handshake error code.
7413 (emacs_gnutls_handle_error): New function.
7414 (wsaerror_to_errno): Likewise.
7415
7416 * w32.h (emacs_gnutls_pull): Add prototype.
7417 (emacs_gnutls_push): Likewise.
7418
7419 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7420 (emacs_gnutls_push): Likewise.
7421
7422 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7423
7424 * process.c (wait_reading_process_output): Check if GnuTLS
7425 buffered some data internally if no FDs are set for TLS
7426 connections.
7427
7428 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7429 (LIBS): Link to USER_LIBS.
7430 ($(BLD)/gnutls.$(0)): New target.
7431
7432 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7433
7434 * xdisp.c (handle_single_display_spec): Rename the
7435 display_replaced_before_p argument into display_replaced_p, to
7436 make it consistent with the commentary. Fix typos in the
7437 commentary.
7438
7439 * textprop.c (syms_of_textprop): Remove dead code.
7440 (copy_text_properties): Delete obsolete commentary about an
7441 interface that was deleted long ago. Fix typos in the description
7442 of arguments.
7443
7444 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7445 to changes in oldXMenu/XMenu.h from 2011-04-16.
7446 <menu_help_message, prev_menu_help_message>: Constify.
7447 (IT_menu_make_room): menu->help_text is now `const char **';
7448 adjust.
7449
7450 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7451 to changes in oldXMenu/XMenu.h from 2011-04-16.
7452 (struct XMenu): Declare `help_text' `const char **'.
7453
7454 * xfaces.c <Qunspecified>: Make extern again.
7455
7456 * syntax.c: Include sys/types.h before including regex.h, as
7457 required by Posix.
7458
7459 * doc.c (get_doc_string): Improve the format passed to `error'.
7460
7461 * doprnt.c (doprnt): Improve commentary.
7462
7463 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7464
7465 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7466 them with etags.
7467
7468 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7469 changes in globals.h immediately force recompilation.
7470 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7471 $(CURDIR)/s/ms-w32.h.
7472 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7473
7474 * character.c (Fchar_direction): Function deleted.
7475 (syms_of_character): Don't defsubr it.
7476 <char-direction-table>: Deleted.
7477
7478 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7479
7480 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7481 * doprnt.c: Include limits.h.
7482 (SIZE_MAX): New macro.
7483 (doprnt): Return a size_t value. 2nd arg is now size_t.
7484 Many local variables are now size_t instead of int or unsigned.
7485 Improve overflow protection. Support `l' modifier for integer
7486 conversions. Support %l conversion. Don't assume an EMACS_INT
7487 argument for integer conversions and for %c.
7488
7489 * lisp.h (doprnt): Restore prototype.
7490
7491 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7492 $(SRC)/character.h.
7493
7494 * Makefile.in (base_obj): Add back doprnt.o.
7495
7496 * deps.mk (doprnt.o): Add back prerequisites.
7497 (callint.o): Depend on character.h.
7498
7499 * eval.c (internal_lisp_condition_case): Include the handler
7500 representation in the error message.
7501 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7502 when breaking from the loop.
7503
7504 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7505
7506 * callint.c (Fcall_interactively): When displaying error message
7507 about invalid control letter, pass the character's codepoint, not
7508 a pointer to its multibyte form. Improve display of the character
7509 in octal and display also its hex code.
7510
7511 * character.c (char_string): Use %x to display the (unsigned)
7512 codepoint of an invalid character, to avoid displaying a bogus
7513 negative value.
7514
7515 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7516 `error', not SYMBOL_NAME itself.
7517
7518 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7519 character arguments to `error'.
7520
7521 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7522 to `error' in error message about FINAL_CHAR argument. Make sure
7523 FINAL_CHAR is a character, and use %c when it is passed as
7524 argument to `error'.
7525
7526 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7527
7528 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7529
7530 * w32.c: Include <time.h>.
7531 (sys_localtime): New function.
7532
7533 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7534
7535 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7536
7537 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7538
7539 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7540
7541 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7542 zombies (Bug#8467).
7543
7544 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7545
7546 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7547 gl_state.e_property when gl_state.object is Qt.
7548
7549 * insdel.c (make_gap_larger): Remove limitation of buffer size
7550 to <= INT_MAX.
7551
7552 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7553
7554 * xdisp.c (lookup_glyphless_char_display)
7555 (produce_glyphless_glyph): Handle cons cell entry in
7556 glyphless-char-display.
7557 (Vglyphless_char_display): Document it.
7558
7559 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7560 glyphless-char-display.
7561
7562 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7563
7564 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7565
7566 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7567
7568 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7569 definition for no-X builds.
7570
7571 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7572
7573 Static checks with GCC 4.6.0 and non-default toolkits.
7574
7575 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7576
7577 * process.c (keyboard_bit_set): Define only if SIGIO.
7578 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7579 (send_process): Repair possible setjmp clobbering.
7580
7581 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7582
7583 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7584
7585 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7586
7587 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7588 Define only if needed.
7589
7590 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7591 by pacifying GCC about it. Maybe it's time to retire it?
7592 * xfaces.c (USG, __TIMEVAL__): Likewise.
7593
7594 * dispextern.h (struct redisplay_interface): Rename param
7595 to avoid shadowing.
7596 * termhooks.h (struct terminal): Likewise.
7597 * xterm.c (xembed_send_message): Likewise.
7598
7599 * insdel.c (make_gap_smaller): Define only if
7600 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7601
7602 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7603 it.
7604
7605 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7606 so that we aren't warned about unused symbols.
7607
7608 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7609
7610 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7611
7612 * xfns.c (x_real_positions): Mark locals as initialized.
7613
7614 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7615
7616 * xterm.c: Fix problems found by static analysis with other toolkits.
7617 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7618 (x_dispatch_event): Declare static if USE_GTK, and
7619 define if USE_GTK || USE_X_TOOLKIT.
7620 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7621 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7622 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7623 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7624
7625 * xmenu.c (menu_help_callback): Pointer type fixes.
7626 Use const pointers when pointing at readonly data. Avoid pointer
7627 signedness clashes.
7628 (FALSE): Remove unused macro.
7629 (update_frame_menubar): Remove unused decl.
7630
7631 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7632
7633 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7634 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7635 (single_menu_item): Rename local to avoid shadowing.
7636
7637 * keyboard.c (make_lispy_event): Remove unused local var.
7638
7639 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7640 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7641
7642 * bitmaps: Change bitmaps from unsigned char back to the X11
7643 compatible char. Avoid the old compiler warnings about
7644 out-of-range initializers by using, for example, '\xab' rather
7645 than 0xab.
7646
7647 * xgselect.c (xgselect_initialize): Check vs interface
7648 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7649
7650 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7651
7652 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7653 to read-only memory.
7654
7655 * fns.c (vector): Remove; this old hack is no longer needed.
7656
7657 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7658 Remove unused var.
7659 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7660
7661 * xrdb.c (x_load_resources): Omit unused local.
7662
7663 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7664 (x_window): Rename locals to avoid shadowing.
7665 (USG): Use the kludged USG macro, to pacify gcc.
7666
7667 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7668 (x_term_init): Remove local to avoid shadowing.
7669
7670 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7671
7672 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7673 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7674
7675 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7676
7677 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7678
7679 Fix regex.c, syntax.c and friends for buffers > 2GB.
7680 * syntax.h (struct gl_state_s): Declare character position members
7681 EMACS_INT.
7682
7683 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7684
7685 * textprop.c (verify_interval_modification, interval_of):
7686 Declare arguments EMACS_INT.
7687
7688 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7689 EMACS_INT.
7690
7691 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7692
7693 * indent.c (Fvertical_motion): Local variable it_start is now
7694 EMACS_INT.
7695
7696 * regex.c (re_match, re_match_2, re_match_2_internal)
7697 (bcmp_translate, regcomp, regexec, print_double_string)
7698 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7699 (re_compile_pattern, re_exec): Declare arguments and local
7700 variables `size_t' and `ssize_t' and return values `regoff_t', as
7701 appropriate.
7702 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7703 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7704 <compile_stack_type>: `size' and `avail' are now `size_t'.
7705
7706 * regex.h <regoff_t>: Use ssize_t, not int.
7707 (re_search, re_search_2, re_match, re_match_2): Arguments that
7708 specify buffer/string position and length are now ssize_t and
7709 size_t. Return type is regoff_t.
7710
7711 2011-04-16 Ben Key <bkey76@gmail.com>
7712
7713 * nsfont.m: Fixed bugs in ns_get_family and
7714 ns_descriptor_to_entity that were caused by using free to
7715 deallocate memory blocks that were allocated by xmalloc (via
7716 xstrdup). This caused Emacs to crash when compiled with
7717 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7718 --enable-checking=xmallocoverrun). xfree is now used to
7719 deallocate these memory blocks.
7720
7721 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7722
7723 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7724
7725 emacs_write: Accept and return EMACS_INT for sizes.
7726 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7727 et seq.
7728 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7729 Accept and return EMACS_INT.
7730 (emacs_gnutls_write): Return the number of bytes written on
7731 partial writes.
7732 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7733 (emacs_read, emacs_write): Remove check for negative size, as the
7734 Emacs source code has been audited now.
7735 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7736 (emacs_read, emacs_write): Use it.
7737 * process.c (send_process): Adjust to the new signatures of
7738 emacs_write and emacs_gnutls_write. Do not attempt to store
7739 a byte offset into an 'int'; it might overflow.
7740 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7741
7742 * sound.c: Don't assume sizes fit in 'int'.
7743 (struct sound_device.period_size, alsa_period_size):
7744 Return EMACS_INT, not int.
7745 (struct sound_device.write, vox_write, alsa_write):
7746 Accept EMACS_INT, not int.
7747 (wav_play, au_play): Use EMACS_INT to store sizes and to
7748 record read return values.
7749
7750 2011-04-15 Ben Key <bkey76@gmail.com>
7751
7752 * keyboard.c (Qundefined): Don't declare static since it is used
7753 in nsfns.m.
7754 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7755 static since they are used in nsfont.m.
7756
7757 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7758
7759 * process.c (Qprocessp): Don't declare static.
7760 * lisp.h (Qprocessp): Declare again.
7761
7762 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7763
7764 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7765
7766 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7767
7768 Improve C-level modularity by making more things 'static'.
7769
7770 Don't publish debugger-only interfaces to other modules.
7771 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7772 (verify_bytepos, count_markers): Move decls to the only modules
7773 that need them.
7774 * region-cache.h (pp_cache): Likewise.
7775 * window.h (check_all_windows): Likewise.
7776 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7777
7778 * sysdep.c (croak): Now static, if
7779 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7780 * syssignal.h (croak): Declare only if not static.
7781
7782 * alloc.c (refill_memory_reserve): Now static if
7783 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7784 * lisp.h (refill_memory_reserve): Declare only if not static.
7785
7786 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7787 Define only if USE_LUCID.
7788
7789 * xrdb.c (x_customization_string, x_rm_string): Now static.
7790
7791 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7792 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7793
7794 * xdisp.c (draw_row_with_mouse_face): Now static.
7795 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7796
7797 * window.h (check_all_windows): Mark externally visible.
7798
7799 * window.c (window_deletion_count): Now static.
7800
7801 * undo.c: Make symbols static if they're not exported.
7802 (last_undo_buffer, last_boundary_position, pending_boundary):
7803 Now static.
7804
7805 * textprop.c (interval_insert_behind_hooks): Now static.
7806 (interval_insert_in_front_hooks): Likewise.
7807
7808 * term.c: Make symbols static if they're not exported.
7809 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7810 (max_frame_lines, tty_set_terminal_modes):
7811 (tty_reset_terminal_modes, tty_turn_off_highlight):
7812 (get_tty_terminal): Now static.
7813 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7814 * termhooks.h (term_mouse_moveto): Do not declare if
7815 HAVE_WINDOW_SYSTEM.
7816 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7817 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7818
7819 * sysdep.c: Make symbols static if they're not exported.
7820 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7821 Now static.
7822 (sigprocmask_set, full_mask): Remove; unused.
7823 (wait_debugging): Mark as visible.
7824 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7825 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7826
7827 * syntax.c (syntax_temp): Define only if !__GNUC__.
7828
7829 * sound.c (current_sound_device, current_sound): Now static.
7830
7831 * search.c (searchbufs, searchbuf_head): Now static.
7832
7833 * scroll.c (scroll_cost): Remove; unused.
7834 * dispextern.h (scroll_cost): Remove decl.
7835
7836 * region-cache.h (pp_cache): Mark as externally visible.
7837
7838 * process.c: Make symbols static if they're not exported.
7839 (process_tick, update_tick, create_process, chan_process):
7840 (Vprocess_alist, proc_buffered_char, datagram_access):
7841 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7842 (deactivate_process): Mark defn as static, as well as decl.
7843 * lisp.h (create_process): Remove decl.
7844 * process.h (chan_process, Vprocess_alist): Remove decls.
7845
7846 * print.c: Make symbols static if they're not exported.
7847 (print_depth, new_backquote_output, being_printed, print_buffer):
7848 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7849 (print_interval, print_number_index, initial_stderr_stream):
7850 Now static.
7851 * lisp.h (Fprinc): Remove decl.
7852 (debug_output_compilation_hack): Mark as externally visible.
7853
7854 * sysdep.c (croak): Move decl from here to syssignal.h.
7855 * syssignal.h (croak): Put it here, so the API can be checked when
7856 'croak' is called from dissociate_if_controlling_tty.
7857
7858 * minibuf.c: Make symbols static if they're not exported.
7859 (minibuf_save_list, choose_minibuf_frame): Now static.
7860 * lisp.h (choose_minibuf_frame): Remove decl.
7861
7862 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7863
7864 * lread.c: Make symbols static if they're not exported.
7865 (read_objects, initial_obarray, oblookup_last_bucket_number):
7866 Now static.
7867 (make_symbol): Remove; unused.
7868 * lisp.h (initial_obarray, make_symbol): Remove decls.
7869
7870 * keyboard.c: Make symbols static if they're not exported.
7871 (single_kboard, recent_keys_index, total_keys, recent_keys):
7872 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7873 (this_single_command_key_start, echoing, last_auto_save):
7874 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7875 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7876 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7877 (Vlispy_mouse_stem, double_click_count):
7878 Now static.
7879 (force_auto_save_soon): Define only if SIGDANGER.
7880 (ignore_mouse_drag_p): Now static if
7881 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7882 (print_help): Remove; unused.
7883 (stop_character, last_timer_event): Mark as externally visible.
7884 * keyboard.h (ignore_mouse_drag_p): Declare only if
7885 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7886 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7887 * lisp.h (echoing): Remove decl.
7888 (force_auto_save_soon): Declare only if SIGDANGER.
7889 * xdisp.c (redisplay_window): Simplify code, to make it more
7890 obvious that ignore_mouse_drag_p is not accessed if !defined
7891 USE_GTK && !defined HAVE_NS.
7892
7893 * intervals.c: Make symbols static if they're not exported.
7894 (merge_properties_sticky, merge_interval_right, delete_interval):
7895 Now static.
7896 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7897
7898 * insdel.c: Make symbols static if they're not exported.
7899 However, leave prepare_to_modify_buffer alone. It's never
7900 called from outside this function, but that appears to be a bug.
7901 (combine_after_change_list, combine_after_change_buffer):
7902 (adjust_after_replace, signal_before_change): Now static.
7903 (adjust_after_replace_noundo): Remove; unused.
7904 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7905 (signal_before_change): Remove decls.
7906
7907 * indent.c (val_compute_motion, val_vmotion): Now static.
7908
7909 * image.c: Make symbols static if they're not exported.
7910 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7911 if USE_GTK.
7912 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7913 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7914
7915 * fringe.c (standard_bitmaps): Now static.
7916 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7917
7918 * frame.c: Make symbols static if they're not exported.
7919 (x_report_frame_params, make_terminal_frame): Now static.
7920 (get_frame_param): Now static, unless HAVE_NS.
7921 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7922 (x_get_resource_string): Remove; not used.
7923 * frame.h (make_terminal_frame, x_report_frame_params):
7924 (x_get_resource_string); Remove decls.
7925 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7926 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7927
7928 * font.c, fontset.c: Make symbols static if they're not exported.
7929 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7930 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7931 * font.c (font_close_object): Now static.
7932 * font.h (font_close_object): Remove.
7933 * fontset.c (FONTSET_OBJLIST): Remove.
7934 (free_realized_fontset) #if-0 the body, which does nothing.
7935 (face_suitable_for_char_p): #if-0, as it's never called.
7936 * fontset.h (face_suitable_for_char_p): Remove decl.
7937 * xfaces.c (face_at_string_position):
7938 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7939 since 0 is always ASCII.
7940
7941 * fns.c (weak_hash_tables): Now static.
7942
7943 * fileio.c: Make symbols static if they're not exported.
7944 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7945 (Vwrite_region_annotation_buffers): Now static.
7946
7947 * eval.c: Make symbols static if they're not exported.
7948 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7949 * lisp.h (backtrace_list): Remove decl.
7950
7951 * emacs.c: Make symbols static if they're not exported.
7952 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7953 (fatal_error_code, fatal_error_signal_hook, standard_args):
7954 Now static.
7955 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7956 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7957 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7958 * lisp.h (fatal_error_signal_hook): Remove decl.
7959 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7960
7961 * editfns.c: Move a (normally-unused) function to its only use.
7962 * editfns.c, lisp.h (get_operating_system_release): Remove.
7963 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7964 worth the hassle of breaking this out.
7965
7966 * xterm.c: Make symbols static if they're not exported.
7967 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7968 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7969 (x_destroy_window, x_delete_display):
7970 Now static.
7971 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7972 (x_mouse_leave): Remove; unused.
7973 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7974 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7975 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7976 Remove decls.
7977 (x_mouse_leave): Declare only if WINDOWSNT.
7978 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7979 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7980 USE_X_TOOLKIT.
7981
7982 * ftxfont.c: Make symbols static if they're not exported.
7983 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7984 HAVE_FREETYPE.
7985 * font.h (ftxfont_driver): Likewise.
7986
7987 * xfns.c: Make symbols static if they're not exported.
7988 (x_last_font_name, x_display_info_for_name):
7989 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7990 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7991 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7992 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7993 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7994 (last_show_tip_args): Now static.
7995 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7996 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7997 (x_screen_planes): Remove; unused.
7998 * dispextern.h (x_screen_planes): Remove decl.
7999
8000 * dispnew.c: Make symbols static if they're not exported.
8001 * dispextern.h (redraw_garbaged_frames, scrolling):
8002 (increment_row_positions): Remove.
8003 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8004 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8005 Now static.
8006 (redraw_garbaged_frames): Remove; unused.
8007
8008 * xfaces.c: Make symbols static if they're not exported.
8009 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8010 Remove decls.
8011 * xterm.h (defined_color): Remove decls.
8012 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8013 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8014 (menu_face_changed_default, defined_color, free_realized_face):
8015 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8016 (ascii_face_of_lisp_face): Remove; unused.
8017
8018 * xdisp.c: Make symbols static if they're not exported.
8019 * dispextern.h (scratch_glyph_row, window_box_edges):
8020 (glyph_to_pixel_coords, set_cursor_from_row):
8021 (get_next_display_element, set_iterator_to_next):
8022 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8023 (show_mouse_face): Remove decls
8024 * frame.h (message_buf_print): Likewise.
8025 * lisp.h (pop_message, set_message, check_point_in_composition):
8026 Likewise.
8027 * xterm.h (set_vertical_scroll_bar): Likewise.
8028 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8029 (message_buf_print, scratch_glyph_row, displayed_buffer):
8030 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8031 (get_next_display_element, show_mouse_face, window_box_edges):
8032 (frame_to_window_pixel_xy, check_point_in_composition):
8033 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8034 (glyph_to_pixel_coords): Remove; unused.
8035
8036 * dired.c (file_name_completion): Now static.
8037
8038 * dbusbind.c (xd_in_read_queued_messages): Now static.
8039
8040 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8041 * data.c (circular_list_error): Remove.
8042
8043 * commands.h (last_point_position, last_point_position_buffer):
8044 (last_point_position_window): Remove decls.
8045 * keyboard.c: Make these variables static.
8046
8047 * coding.h (coding, code_convert_region, encode_coding_gap):
8048 Remove decls.
8049 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8050 (iso_code_class, detect_coding, code_convert_region): Now static.
8051 (encode_coding_gap): Remove; unused.
8052
8053 * chartab.c (chartab_chars, chartab_bits): Now static.
8054
8055 * charset.h (charset_iso_8859_1): Remove decl.
8056 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8057 Now static.
8058
8059 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8060 * ccl.c (Vccl_program_table): Now static.
8061 (check_ccl_update): Remove; unused.
8062
8063 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8064 * category.h: ... from here.
8065 * category.c (check_category_table, set_category_set): Now static.
8066
8067 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8068 * lisp.h: Remove these decls.
8069
8070 * buffer.c (buffer_count): Remove unused var.
8071
8072 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8073 so that it's not optimized away.
8074 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8075 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8076 exported only to the debugger.
8077
8078 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8079 * atimer.h (run_all_atimers): Remove; not exported.
8080
8081 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8082 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8083 was inaccessible from Lisp.
8084 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8085 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8086
8087 alloc.c: Import and export fewer symbols, and remove unused items.
8088 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8089 is defined.
8090 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8091 it's not optimized away by whole-program optimization.
8092 (message_enable_multibyte, free_misc): Remove.
8093 (catchlist, handlerlist, mark_backtrace):
8094 Declare only if BYTE_MARK_STACK.
8095 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8096 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8097 (message_enable_multibyte): Remove decl.
8098 (free_misc, interval_free_list, float_block, float_block_index):
8099 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8100 (cons_free_list, last_marked_index):
8101 Now static.
8102 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8103 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8104 (mark_backtrace): Define only if BYTE_MARK_STACK.
8105 * xdisp.c (message_enable_multibyte): Now static.
8106
8107 Declare Lisp_Object Q* variables to be 'static' if not exported.
8108 This makes it easier for human readers (and static analyzers)
8109 to see whether these variables are used from other modules.
8110 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8111 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8112 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8113 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8114 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8115 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8116 * xmenu.c, xselect.c:
8117 Declare Q* vars static if they are not used in other modules.
8118 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8119 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8120 Remove decls of unexported vars.
8121 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8122
8123 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8124
8125 Make Emacs functions such as Fatom 'static' by default.
8126 This makes it easier for human readers (and static analyzers)
8127 to see whether these functions can be called from other modules.
8128 DEFUN now defines a static function. To make the function external
8129 so that it can be used in other C modules, use the new macro DEFUE.
8130 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8131 (Finit_image_library):
8132 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8133 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8134 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8135 Remove decls, since these functions are now static.
8136 (Funintern, Fget_internal_run_time): New decls, since these functions
8137 were already external.
8138
8139 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8140 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8141 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8142 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8143 * keyboard.c, keymap.c, lread.c:
8144 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8145 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8146 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8147 Mark functions with DEFUE instead of DEFUN,
8148 if they are used in other modules.
8149 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8150 decls for now-static functions.
8151 * buffer.h (Fdelete_overlay): Remove decl.
8152 * callproc.c (Fgetenv_internal): Mark as internal.
8153 * composite.c (Fremove_list_of_text_properties): Remove decl.
8154 (Fcomposition_get_gstring): New forward static decl.
8155 * composite.h (Fcomposite_get_gstring): Remove decl.
8156 * dired.c (Ffile_attributes): New forward static decl.
8157 * doc.c (Fdocumntation_property): New forward static decl.
8158 * eval.c (Ffetch_bytecode): New forward static decl.
8159 (Funintern): Remove extern decl; now in .h file where it belongs.
8160 * fileio.c (Fmake_symbolic_link): New forward static decl.
8161 * image.c (Finit_image_library): New forward static decl.
8162 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8163 * intervals.h (Fprevious_property_change):
8164 (Fremove_list_of_text_properties): Remove decls.
8165 * keyboard.c (Fthis_command_keys): Remove decl.
8166 (Fcommand_execute): New forward static decl.
8167 * keymap.c (Flookup_key): New forward static decl.
8168 (Fcopy_keymap): Now static.
8169 * keymap.h (Flookup_key): Remove decl.
8170 * process.c (Fget_process): New forward static decl.
8171 (Fprocess_datagram_address): Mark as internal.
8172 * syntax.c (Fsyntax_table_p): New forward static decl.
8173 (skip_chars): Remove duplicate decl.
8174 * textprop.c (Fprevious_property_change): New forward static decl.
8175 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8176 Now internal.
8177 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8178 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8179
8180 * editfns.c (Fformat): Remove unreachable code.
8181
8182 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8183
8184 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8185 change. (Bug#8496)
8186
8187 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8188
8189 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8190 when at ZV. (Bug#8487)
8191
8192 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8193
8194 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8195 (Bug#8437)
8196 * keyboard.c (parse_tool_bar_item): Likewise.
8197 * sound.c (sound_cleanup, alsa_close): Likewise.
8198 * termcap.c (tgetent): Likewise.
8199 * xfns.c (x_default_font_parameter): Likewise.
8200 * xsettings.c (read_and_apply_settings): Likewise.
8201
8202 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8203 (overrun_check_free): Protoize.
8204
8205 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8206
8207 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8208 since callers should never pass a negative size.
8209 Change the signature to match that of plain 'read' and 'write'; see
8210 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8211 * lisp.h: Update prototypes of emacs_write and emacs_read.
8212
8213 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8214
8215 * xdisp.c (redisplay_window): Don't try to determine the character
8216 position of the scroll margin if the window start point w->startp
8217 is outside the buffer's accessible region. (Bug#8468)
8218
8219 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8220
8221 Fix write-region and its subroutines for buffers > 2GB.
8222 * fileio.c (a_write, e_write): Modify declaration of arguments and
8223 local variables to support buffers larger than 2GB.
8224 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8225
8226 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8227 argument, local variables, and return value.
8228
8229 * lisp.h: Update prototypes of emacs_write and emacs_read.
8230
8231 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8232
8233 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8234
8235 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8236
8237 Fix more problems found by GCC 4.6.0's static checks.
8238
8239 * xdisp.c (vmessage): Use a better test for character truncation.
8240
8241 * charset.c (load_charset_map): <, not <=, for optimization,
8242 and to avoid potential problems with integer overflow.
8243 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8244 * casetab.c (set_identity, shuffle): Likewise.
8245 * editfns.c (Fformat): Likewise.
8246 * syntax.c (skip_chars): Likewise.
8247
8248 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8249 This also lets GCC 4.6.0 generate slightly better loop code.
8250
8251 * callint.c (Fcall_interactively): <, not <=, for optimization.
8252 (Fcall_interactively): Count the number of arguments produced,
8253 not the number of arguments given. This is simpler and lets GCC
8254 4.6.0 generate slightly better code.
8255
8256 * ftfont.c: Distingish more carefully between FcChar8 and char.
8257 The previous code passed unsigned char * to a functions like
8258 strlen and xstrcasecmp that expect char *, which does not
8259 conform to the C standard.
8260 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8261 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8262 char * when the C standard requires it.
8263
8264 * keyboard.c (read_char): Remove unused var.
8265
8266 * eval.c: Port to Windows vsnprintf (Bug#8435).
8267 Include <limits.h>.
8268 (SIZE_MAX): Define if the headers do not.
8269 (verror): Do not give up if vsnprintf returns a negative count.
8270 Instead, grow the buffer. This ports to Windows vsnprintf, which
8271 does not conform to C99. Problem reported by Eli Zaretskii.
8272 Also, simplify the allocation scheme, by avoiding the need for
8273 calling realloc, and removing the ALLOCATED variable.
8274
8275 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8276
8277 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8278 But keep the doprint source code for now, as we might revamp it
8279 and use it again (Bug#8435).
8280 * lisp.h (doprnt): Remove.
8281 * Makefile.in (base_obj): Remove doprnt.o.
8282 * deps.mk (doprnt.o): Remove.
8283
8284 error: Print 32- and 64-bit integers portably (Bug#8435).
8285 Without this change, on typical 64-bit hosts error ("...%d...", N)
8286 was used to print both 32- and 64-bit integers N, which relied on
8287 undefined behavior.
8288 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8289 * lisp.h (error, verror): Mark as printf-like functions.
8290 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8291 Report overflow in size calculations when allocating printf buffer.
8292 Do not truncate output string at its first null byte.
8293 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8294 Truncate the output at a character boundary, since vsnprintf does not
8295 do that.
8296 * charset.c (check_iso_charset_parameter): Convert internal
8297 character to string before calling 'error', since %c now has the
8298 printf meaning.
8299 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8300 overflow when computing char to be passed to 'error'. Do not
8301 pass Lisp_Object to 'error'; pass the integer instead.
8302 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8303 formatted with plain %d.
8304
8305 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8306
8307 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8308
8309 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8310
8311 * xterm.c (x_catch_errors): Remove duplicate declaration.
8312
8313 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8314
8315 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8316
8317 2011-04-10 Jim Meyering <meyering@redhat.com>
8318
8319 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8320 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8321 return ssize_t not "int", and use size_t as the buffer length.
8322 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8323 * gnutls.h: Update declarations.
8324 * process.c (read_process_output): Use ssize_t, to match.
8325 (send_process): Likewise.
8326
8327 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8328
8329 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8330
8331 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8332
8333 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8334 Use unsigned char, to match FcChar8 type definition.
8335
8336 * xterm.c (handle_one_xevent):
8337 * xmenu.c (create_and_show_popup_menu):
8338 * xselect.c (x_decline_selection_request)
8339 (x_reply_selection_request): Avoid type-punned deref of X events.
8340
8341 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8342
8343 Fix some uses of `int' instead of EMACS_INT.
8344 * search.c (string_match_1, fast_string_match)
8345 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8346 (scan_buffer, find_next_newline_no_quit)
8347 (find_before_next_newline, search_command, Freplace_match)
8348 (Fmatch_data): Make some `int' variables be EMACS_INT.
8349
8350 * xdisp.c (display_count_lines): 3rd argument and return value now
8351 EMACS_INT. All callers changed.
8352 (pint2hrstr): Last argument is now EMACS_INT.
8353
8354 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8355 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8356 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8357 (decode_coding_utf_16, decode_coding_emacs_mule)
8358 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8359 (decode_coding_ccl, decode_coding_charset)
8360 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8361 (decode_coding_iso_2022, decode_coding_emacs_mule)
8362 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8363 <char_offset, last_offset>: Declare EMACS_INT.
8364 (encode_coding_utf_8, encode_coding_utf_16)
8365 (encode_coding_emacs_mule, encode_invocation_designation)
8366 (encode_designation_at_bol, encode_coding_iso_2022)
8367 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8368 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8369 Declare EMACS_INT.
8370 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8371 (encode_invocation_designation): Last argument P_NCHARS is now
8372 EMACS_INT.
8373 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8374 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8375
8376 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8377 All users changed.
8378
8379 * ccl.c (Fccl_execute_on_string): Declare some variables
8380 EMACS_INT.
8381
8382 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8383
8384 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8385
8386 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8387
8388 * process.c (Fformat_network_address): Doc fix.
8389
8390 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8391
8392 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8393
8394 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8395
8396 * keyboard.c (read_char): Call Lisp function help-form-show,
8397 instead of using internal_with_output_to_temp_buffer.
8398 (Qhelp_form_show): New var.
8399 (syms_of_keyboard): Use DEFSYM macro.
8400
8401 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8402
8403 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8404
8405 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8406
8407 * process.c (Flist_processes): Remove to Lisp.
8408 (list_processes_1): Delete.
8409
8410 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8411
8412 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8413
8414 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8415
8416 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8417
8418 Fix more problems found by GCC 4.6.0's static checks.
8419
8420 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8421
8422 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8423
8424 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8425
8426 * xdisp.c (vmessage): Mark as a printf-like function.
8427
8428 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8429
8430 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8431
8432 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8433 printf-like functions.
8434 (tiff_load): Add casts to remove these marks before passing them
8435 to system-supplied API.
8436
8437 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8438
8439 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8440 This avoids several warnings with gcc -Wstrict-overflow.
8441 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8442 directly, rather than having caller test rule sign. This avoids
8443 some unnecessary tests.
8444 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8445 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8446 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8447
8448 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8449 (xfont_open): Avoid unnecessary tests.
8450
8451 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8452
8453 * composite.h, composite.c (composition_gstring_put_cache):
8454 Use EMACS_INT, not int, for length.
8455
8456 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8457 breaking out part of COMPOSITION_DECODE_RULE.
8458 (COMPOSITION_DECODE_RULE): Use it.
8459 * composite.c (get_composition_id): Remove unused local vars,
8460 by using the new macro.
8461
8462 * textprop.c (set_text_properties_1): Change while to do-while,
8463 since the condition is always true at first.
8464
8465 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8466 (interval_deletion_adjustment): Return unsigned value.
8467 All uses changed.
8468
8469 * process.c (list_processes_1, create_pty, read_process_output):
8470 (exec_sentinel): Remove vars that were set but not used.
8471 (create_pty): Remove unnecessary "volatile"s.
8472 (Fnetwork_interface_info): Avoid possibility of int overflow.
8473 (read_process_output): Do adaptive read buffering even if carryover.
8474 (read_process_output): Simplify nbytes computation if buffered.
8475
8476 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8477
8478 * syntax.c (scan_words): Remove var that was set but not used.
8479 (update_syntax_table): Use unsigned instead of int.
8480
8481 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8482 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8483 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8484
8485 * print.c (print_error_message): Avoid int overflow.
8486
8487 * font.c (font_list_entities): Redo for clarity,
8488 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8489
8490 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8491 (font_score): Avoid potential overflow in diff calculation.
8492
8493 * fns.c (substring_both): Remove var that is set but not used.
8494 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8495
8496 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8497
8498 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8499 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8500 can always succeed if overflow has undefined behavior.
8501
8502 * search.c (boyer_moore, wordify): Remove vars set but not used.
8503 (wordify): Omit three unnecessary tests.
8504
8505 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8506 All callers changed. This avoids the need for an unused var.
8507
8508 * casefiddle.c (casify_region): Remove var that is set but not used.
8509
8510 * dired.c (file_name_completion): Remove var that is set but not used.
8511
8512 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8513
8514 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8515 (Finsert_file_contents): Remove unnecessary code checking fd.
8516
8517 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8518 Check for integer overflow on size calculations.
8519
8520 * buffer.c (Fprevious_overlay_change): Remove var that is set
8521 but not used.
8522
8523 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8524 Remove vars that are set but not used.
8525 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8526 (timer_check_2): Mark vars as initialized.
8527
8528 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8529
8530 * image.c (lookup_image): Remove var that is set but not used.
8531 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8532
8533 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8534 that are set but not used.
8535
8536 * xfns.c (make_invisible_cursor): Don't return garbage
8537 if XCreateBitmapFromData fails (Bug#8410).
8538
8539 * xselect.c (x_get_local_selection, x_handle_property_notify):
8540 Remove vars that are set but not used.
8541
8542 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8543 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8544
8545 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8546 Remove var that is set but not used.
8547 (scroll_bar_windows_size): Now size_t, not int.
8548 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8549 Check for overflow.
8550
8551 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8552 (map_tty_color) [!defined MSDOS]: Likewise.
8553
8554 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8555
8556 * coding.c: Remove vars that are set but not used.
8557 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8558 All callers changed.
8559 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8560 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8561 (decode_coding_charset): Remove vars that are set but not used.
8562
8563 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8564 that is set but not used.
8565
8566 * print.c (print_object): Remove var that is set but not used.
8567
8568 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8569 The gnulib version avoids calling malloc in the usual case,
8570 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8571 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8572 * filelock.c (current_lock_owner): Likewise.
8573 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8574 * sysdep.c: Include allocator.h, careadlinkat.h.
8575 (emacs_no_realloc_allocator): New static constant.
8576 (emacs_readlink): New function.
8577 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8578 ../lib/careadlinkat.h.
8579
8580 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8581
8582 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8583 first non-nil return value).
8584
8585 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8586
8587 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8588 if not defined (Bug#8403).
8589
8590 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8591
8592 * xdisp.c (display_count_lines): Remove parameter `start',
8593 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8594 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8595 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8596 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8597 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8598 and thereabouts. All callers changed.
8599 (get_per_char_metric): Remove parameter `f', unused since
8600 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8601
8602 2011-04-02 Jim Meyering <meyering@redhat.com>
8603
8604 do not dereference NULL upon failed strdup
8605 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8606 (ns_get_family): Likewise.
8607
8608 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8609
8610 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8611
8612 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8613
8614 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8615 later (Bug#8403).
8616
8617 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8618
8619 Add lexical binding.
8620
8621 * window.c (Ftemp_output_buffer_show): New fun.
8622 (Fsave_window_excursion):
8623 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8624
8625 * lread.c (lisp_file_lexically_bound_p): New function.
8626 (Fload): Bind Qlexical_binding.
8627 (readevalloop): Remove `evalfun' arg.
8628 Bind Qinternal_interpreter_environment.
8629 (Feval_buffer): Bind Qlexical_binding.
8630 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8631 Mark as dynamic.
8632 (syms_of_lread): Declare `lexical-binding'.
8633
8634 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8635
8636 * keyboard.c (eval_dyn): New fun.
8637 (menu_item_eval_property): Use it.
8638
8639 * image.c (parse_image_spec): Use Ffunctionp.
8640
8641 * fns.c (concat, mapcar1): Accept byte-code-functions.
8642
8643 * eval.c (Fsetq): Handle lexical vars.
8644 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8645 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8646 (FletX, Flet): Obey lexical binding.
8647 (Fcommandp): Handle closures.
8648 (Feval): New `lexical' arg.
8649 (eval_sub): New function extracted from Feval. Use it almost
8650 everywhere where Feval was used. Look up vars in lexical env.
8651 Handle closures.
8652 (Ffunctionp): Move from subr.el.
8653 (Ffuncall): Handle closures.
8654 (apply_lambda): Remove `eval_flags'.
8655 (funcall_lambda): Handle closures and new byte-code-functions.
8656 (Fspecial_variable_p): New function.
8657 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8658 but without exporting it to Lisp.
8659
8660 * doc.c (Fdocumentation, store_function_docstring):
8661 * data.c (Finteractive_form): Handle closures.
8662
8663 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8664 interactive spec.
8665
8666 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8667 New byte-codes.
8668 (exec_byte_code): New function extracted from Fbyte_code to handle new
8669 calling convention for byte-code-functions. Add new byte-codes.
8670
8671 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8672
8673 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8674
8675 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8676
8677 * xdisp.c (redisplay_internal): Fix prototype.
8678
8679 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8680
8681 * xdisp.c (SCROLL_LIMIT): New macro.
8682 (try_scrolling): Use it when setting scroll_limit.
8683 Limit scrolling to 100 screen lines.
8684 (redisplay_window): Even when falling back on "recentering",
8685 position point in the window according to scroll-conservatively,
8686 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8687
8688 (try_scrolling): When point is above the window, allow searching
8689 as far as scroll_max, or one screenful, to compute vertical
8690 distance from PT to the scroll margin position. This prevents
8691 try_scrolling from unnecessarily failing when
8692 scroll-conservatively is set to a value slightly larger than the
8693 window height. Clean up the case of PT below the margin at bottom
8694 of window: scroll_max can no longer be INT_MAX. When aggressive
8695 scrolling is in use, don't let point enter the opposite scroll
8696 margin as result of the scroll.
8697 (syms_of_xdisp) <scroll-conservatively>: Document the
8698 threshold of 100 lines for never-recentering scrolling.
8699
8700 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8701
8702 * dispextern.h (move_it_by_lines):
8703 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8704 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8705 (message_log_check_duplicate): Remove parameters `prev_bol' and
8706 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8707 (redisplay_internal): Remove parameter `preserve_echo_area',
8708 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8709
8710 * indent.c (Fvertical_motion):
8711 * window.c (window_scroll_pixel_based, Frecenter):
8712 Don't pass `need_y_p' to `move_it_by_lines'.
8713
8714 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8715
8716 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8717 steal a few bits to be more compact.
8718 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8719 Remove unneeded casts.
8720
8721 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8722
8723 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8724
8725 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8726 binding" message (bug#7967).
8727
8728 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8729
8730 Fix more problems found by GCC 4.6.0's static checks.
8731
8732 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8733 Remove unused local var.
8734
8735 * editfns.c (Fmessage_box): Remove unused local var.
8736
8737 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8738 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8739 Omit unused local vars.
8740 * window.c (shrink_windows): Omit unused local var.
8741 * menu.c (digest_single_submenu): Omit unused local var.
8742 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8743 Omit unused local var.
8744
8745 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8746 Don't assume string length fits in int.
8747 (keyremap_step, read_key_sequence): Use size_t for sizes.
8748 (read_key_sequence): Don't check last_real_key_start redundantly.
8749
8750 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8751 instead of alloca (Bug#8344).
8752
8753 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8754 (Fbacktrace_frame): Don't assume nframes fits in int.
8755
8756 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8757
8758 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8759 concerns.
8760
8761 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8762
8763 * cm.c (calccost): Turn while-do into do-while, for clarity.
8764
8765 * keyboard.c (syms_of_keyboard): Use the same style as later
8766 in this function when indexing through an array. This also
8767 works around GCC bug 48267.
8768
8769 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8770
8771 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8772
8773 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8774 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8775
8776 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8777 This avoids undefined behavior on integer overflow, and is a bit
8778 more convenient anyway since it is compared to a size_t variable.
8779
8780 Variadic C functions now count arguments with size_t, not int.
8781 This avoids an unnecessary limitation on 64-bit machines, which
8782 caused (substring ...) to crash on large vectors (Bug#8344).
8783 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8784 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8785 All variadic functions and their callers changed accordingly.
8786 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8787 * data.c (arith_driver, float_arith_driver): Likewise.
8788 * editfns.c (general_insert_function): Likewise.
8789 * eval.c (struct backtrace.nargs, interactive_p)
8790 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8791 (funcall_lambda, mark_backtrace): Likewise.
8792 * fns.c (concat): Likewise.
8793 * frame.c (x_set_frame_parameters): Likewise.
8794 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8795 0 if not found, not -1. All callers changed.
8796
8797 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8798 (stack_copy_size): Now size_t, not int.
8799 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8800
8801 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8802
8803 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8804 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8805 All callers changed.
8806
8807 * lisp.h (multibyte_char_to_unibyte):
8808 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8809 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8810 * character.h (CHAR_TO_BYTE8):
8811 * cmds.c (internal_self_insert):
8812 * editfns.c (general_insert_function):
8813 * keymap.c (push_key_description):
8814 * search.c (Freplace_match):
8815 * xdisp.c (message_dolog, set_message_1): All callers changed.
8816
8817 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8818
8819 * keyboard.c (safe_run_hook_funcall): New function.
8820 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8821 don't set the hook to nil, but remove the offending function instead.
8822 (Qcommand_hook_internal): Remove, unused.
8823 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8824 Vcommand_hook_internal.
8825
8826 * eval.c (enum run_hooks_condition): Remove.
8827 (funcall_nil, funcall_not): New functions.
8828 (run_hook_with_args): Call each function through a `funcall' argument.
8829 Remove `cond' argument, now redundant.
8830 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8831 (Frun_hook_with_args_until_failure): Adjust accordingly.
8832 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8833
8834 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8835
8836 * dispextern.h (string_buffer_position): Remove declaration.
8837
8838 * print.c (strout): Remove parameter `multibyte', unused since
8839 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8840
8841 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8842 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8843 All callers changed.
8844
8845 * w32.c (_wsa_errlist): Use braces for struct initializers.
8846
8847 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8848 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8849 All callers changed.
8850 (string_buffer_position): Likewise. Also, make static (it's never
8851 used outside xdisp.c).
8852 (cursor_row_p): Remove parameter `w', unused since
8853 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8854 (decode_mode_spec): Remove parameter `precision', introduced during
8855 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8856 All callers changed.
8857
8858 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8859
8860 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8861
8862 2011-03-27 Anders Lindgren <andlind@gmail.com>
8863
8864 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8865 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8866 (ns_update_auto_hide_menu_bar): New functions.
8867 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8868 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8869 ns_constrain_all_frames.
8870 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8871 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8872
8873 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8874
8875 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8876
8877 2011-03-27 Glenn Morris <rgm@gnu.org>
8878
8879 * syssignal.h: Replace RETSIGTYPE with void.
8880 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8881 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8882 Replace SIGTYPE with void everywhere.
8883 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8884 * s/template.h (SIGTYPE): Remove commented out definition.
8885
8886 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8887
8888 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8889 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8890
8891 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8892
8893 * w32.c (read_unc_volume): Use parameter `henum', instead of
8894 global variable `wget_enum_handle'.
8895
8896 * keymap.c (describe_vector): Remove parameters `indices' and
8897 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8898 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8899
8900 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8901
8902 * keyboard.c (timer_check): Remove parameter `do_it_now',
8903 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8904 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8905 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8906
8907 * keyboard.c (read_char):
8908 * w32menu.c (w32_menu_display_help):
8909 * xmenu.c (show_help_event, menu_help_callback):
8910 Adjust calls to `show_help_echo'.
8911
8912 * gtkutil.c (xg_maybe_add_timer):
8913 * keyboard.c (readable_events):
8914 * process.c (wait_reading_process_output):
8915 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8916
8917 * insdel.c (adjust_markers_gap_motion):
8918 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8919 (gap_left, gap_right): Don't call it.
8920
8921 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8922
8923 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8924 incurred during fontification.
8925
8926 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8927
8928 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8929 (DEFVAR_PER_BUFFER): Don't pass it.
8930
8931 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8932 (scrolling_window): Don't pass it.
8933
8934 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8935
8936 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8937
8938 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8939 and `suffix'.
8940 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8941 of variables specific to SELinux and computation of `encoded_absname'.
8942
8943 * image.c (XPutPixel): Remove unused variable `height'.
8944
8945 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8946
8947 * unexw32.c (get_section_info): Remove unused variable `section'.
8948
8949 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8950 (system_process_attributes): Remove unused variable `sess'.
8951 (sys_read): Remove unused variable `err'.
8952
8953 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8954 (w32_wnd_proc): Remove unused variable `isdead'.
8955 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8956 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8957 (x_create_tip_frame): Remove unused variable `tem'.
8958
8959 * w32inevt.c (w32_console_read_socket):
8960 Remove unused variable `no_events'.
8961
8962 * w32term.c (x_draw_composite_glyph_string_foreground):
8963 Remove unused variable `width'.
8964
8965 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8966
8967 * w32term.c (x_set_glyph_string_clipping):
8968 Don't pass uninitialized region to CombineRgn.
8969
8970 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8971
8972 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8973 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8974 (Fx_close_connection): Remove unused variable `i'.
8975
8976 * w32font.c (w32font_draw): Return number of glyphs.
8977 (w32font_open_internal): Remove unused variable `i'.
8978 (w32font_driver): Add missing initializer.
8979
8980 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8981 (fill_in_menu): Remove unused variable `items_added'.
8982
8983 * w32term.c (last_mouse_press_frame): Remove static global variable.
8984 (w32_clip_to_row): Remove unused variable `f'.
8985 (x_delete_terminal): Remove unused variable `i'.
8986
8987 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8988 (NOTHING): Remove unused static global variable.
8989 (uniscribe_check_otf): Remove unused variable `table'.
8990 (uniscribe_font_driver): Add missing initializers.
8991
8992 2011-03-23 Julien Danjou <julien@danjou.info>
8993
8994 * term.c (Fsuspend_tty, Fresume_tty):
8995 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8996 * window.c (temp_output_buffer_show):
8997 * insdel.c (signal_before_change):
8998 * frame.c (Fhandle_switch_frame):
8999 * fileio.c (Fdo_auto_save):
9000 * emacs.c (Fkill_emacs):
9001 * editfns.c (save_excursion_restore):
9002 * cmds.c (internal_self_insert):
9003 * callint.c (Fcall_interactively):
9004 * buffer.c (Fkill_all_local_variables):
9005 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9006 Use Frun_hooks.
9007 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9008 unconditionally since it does the check itself.
9009
9010 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9011
9012 Fix more problems found by GCC 4.5.2's static checks.
9013
9014 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9015 the first time through the loop, since we know p0 < p1 then.
9016 This also avoids a gcc -Wstrict-overflow warning.
9017
9018 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9019 leading to a memory leak, possible in functions like
9020 load_charset_map_from_file that can allocate an unbounded number
9021 of objects (Bug#8318).
9022
9023 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9024 that could (at least in theory) be that large.
9025
9026 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9027 This is less likely to overflow, and avoids undefined behavior if
9028 overflow does occur. All callers changed. Use strtoul to scan
9029 for the unsigned long integer.
9030 (pint2hrstr): Simplify and tune code slightly.
9031 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9032
9033 * scroll.c (do_scrolling): Work around GCC bug 48228.
9034 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9035
9036 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9037 This also avoids a warning with gcc -Wstrict-overflow.
9038 (validate_x_resource_name): Simplify count usage.
9039 This also avoids a warning with gcc -Wstrict-overflow.
9040
9041 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9042 fail (Bug#8306).
9043
9044 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9045
9046 * process.c (Fmake_network_process): Use socklen_t, not int,
9047 where POSIX says socklen_t is required in portable programs.
9048 This fixes a porting bug on hosts like 64-bit HP-UX, where
9049 socklen_t is wider than int (Bug#8277).
9050 (Fmake_network_process, server_accept_connection):
9051 (wait_reading_process_output, read_process_output):
9052 Likewise.
9053
9054 * process.c: Rename or move locals to avoid shadowing.
9055 (list_processes_1, Fmake_network_process):
9056 (read_process_output_error_handler, exec_sentinel_error_handler):
9057 Rename or move locals.
9058 (Fmake_network_process): Define label "retry_connect" only if needed.
9059 (Fnetwork_interface_info): Fix pointer signedness.
9060 (process_send_signal): Add cast to avoid pointer signedness problem.
9061 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9062 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9063
9064 Make tparam.h and terminfo.c consistent.
9065 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9066 Include tparam.h instead, since it declares them.
9067 * cm.h (PC): Remove extern decl; tparam.h now does this.
9068 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9069 * terminfo.c: Include tparam.h, to check interfaces.
9070 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9071 (tparam): Adjust signature to match interface in tparam.h;
9072 this removes some undefined behavior. Check that outstring and len
9073 are zero, which they always are with Emacs.
9074 * tparam.h (PC, BC, UP): New extern decls.
9075
9076 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9077 (xftfont_open): Rename locals to avoid shadowing.
9078
9079 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9080 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9081 (OTF_TAG_SYM): Omit macro if not needed.
9082 (ftfont_list): Remove unused local.
9083 (get_adstyle_property, ftfont_pattern_entity):
9084 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9085 Rename locals to avoid shadowing.
9086
9087 * xfont.c (xfont_list_family): Mark var as initialized.
9088
9089 * xml.c (make_dom): Now static.
9090
9091 * composite.c (composition_compute_stop_pos): Rename local to
9092 avoid shadowing.
9093 (composition_reseat_it): Remove unused locals.
9094 (find_automatic_composition, composition_adjust_point): Likewise.
9095 (composition_update_it): Mark var as initialized.
9096 (find_automatic_composition): Mark vars as initialized,
9097 with a FIXME (Bug#8290).
9098
9099 character.h: Rename locals to avoid shadowing.
9100 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9101 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9102 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9103 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9104 to avoid shadowing.
9105
9106 * textprop.c (property_change_between_p): Remove; unused.
9107
9108 * intervals.c (interval_start_pos): Now static.
9109
9110 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9111
9112 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9113 Rename locals to avoid shadowing.
9114
9115 * sound.c (wav_play, au_play, Fplay_sound_internal):
9116 Fix pointer signedness.
9117 (alsa_choose_format): Remove unused local var.
9118 (wav_play): Initialize a variable to 0, to prevent undefined
9119 behavior (Bug#8278).
9120
9121 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9122
9123 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9124
9125 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9126 clobbering (Bug#8298).
9127 * sysdep.c (sys_subshell): Likewise.
9128 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9129
9130 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9131 This should get cleaned up, so that child_setup has the
9132 same signature on all platforms.
9133
9134 * callproc.c (call_process_cleanup): Now static.
9135 (relocate_fd): Rename locals to avoid shadowing.
9136
9137 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9138
9139 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9140 not to be necessary, and produces flickering.
9141
9142 2011-03-20 Glenn Morris <rgm@gnu.org>
9143
9144 * config.in: Remove file.
9145
9146 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9147
9148 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9149 are now in src/globals.h.
9150 (syms_of_minibuf): Remove spurious & from previous change.
9151
9152 2011-03-20 Leo Liu <sdl.web@gmail.com>
9153
9154 * minibuf.c (completing-read-function): New variable.
9155 (completing-read-default): Rename from completing-read.
9156 (completing-read): Call completing-read-function.
9157
9158 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9159
9160 * xfaces.c (Fx_load_color_file):
9161 Read color file from absolute filename (bug#8250).
9162
9163 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9164
9165 * makefile.w32-in: Update dependencies.
9166
9167 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9168
9169 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9170
9171 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9172
9173 Fix more problems found by GCC 4.5.2's static checks.
9174
9175 * process.c (make_serial_process_unwind, send_process_trap):
9176 (sigchld_handler): Now static.
9177
9178 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9179 That way, the code declares only the vars that it needs.
9180 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9181 * s/cygwin.h (PTY_ITERATION): Likewise.
9182 * s/darwin.h (PTY_ITERATION): Likewise.
9183 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9184
9185 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9186 * process.c (allocate_pty): Don't declare stb unless it's needed.
9187
9188 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9189 (CONSTANTLIM): Remove; unused.
9190 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9191 Define only if needed.
9192
9193 * unexelf.c (unexec): Name an expression,
9194 to avoid gcc -Wbad-function-cast warning.
9195 Use a different way to cause a compilation error if anyone uses
9196 n rather than nn, a way that does not involve shadowing.
9197 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9198
9199 * deps.mk (unexalpha.o): Remove; unused.
9200
9201 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9202 * unexec.h: New file.
9203 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9204 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9205 Depend on unexec.h.
9206 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9207 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9208 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9209 Change as necessary to match prototype in unexec.h.
9210
9211 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9212 shadowing.
9213 (back_comment, skip_chars): Mark vars as initialized.
9214
9215 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9216 Rename locals to avoid shadowing.
9217
9218 * lread.c (read1): Rewrite so as not to use empty "else".
9219 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9220
9221 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9222
9223 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9224 warning when compiling print.c.
9225
9226 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9227 instead of using an uninitialized var.
9228 (font_sort_entities): Mark var as initialized.
9229
9230 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9231
9232 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9233 pointers to constants.
9234 (font_parse_fcname): Remove unused vars.
9235 (font_delete_unmatched): Now static.
9236 (font_get_spec): Remove; unused.
9237 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9238 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9239 Rename or move locals to avoid shadowing.
9240
9241 * fns.c (require_nesting_list, require_unwind): Now static.
9242 (Ffillarray): Rename locals to avoid shadowing.
9243
9244 * floatfns.c (domain_error2): Define only if needed.
9245 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9246
9247 * alloc.c (mark_backtrace): Move decl from here ...
9248 * lisp.h: ... to here, so that it can be checked.
9249
9250 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9251 (Fdefvar): Rewrite so as not to use empty "else".
9252 (lisp_indirect_variable): Name an expression,
9253 to avoid gcc -Wbad-function-cast warning.
9254 (Fdefvar): Rename locals to avoid shadowing.
9255
9256 * callint.c (quotify_arg, quotify_args): Now static.
9257 (Fcall_interactively): Rename locals to avoid shadowing.
9258 Use const pointer when appropriate.
9259
9260 * lisp.h (get_system_name, get_operating_system_release):
9261 Move decls here, to check interfaces.
9262 * process.c (get_operating_system_release): Move decl to lisp.h.
9263 * xrdb.c (get_system_name): Likewise.
9264 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9265 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9266 some of which prompt warnings from gcc -Wbad-function-cast.
9267 (Fformat_time_string, Fencode_time, Finsert_char):
9268 (Ftranslate_region_internal, Fformat):
9269 Rename or remove local vars to avoid shadowing.
9270 (Ftranslate_region_internal): Mark var as initialized.
9271
9272 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9273 avoid shadowing.
9274
9275 * lisp.h (eassert): Check that the argument compiles, even if
9276 ENABLE_CHECKING is not defined.
9277
9278 * data.c (Findirect_variable): Name an expression, to avoid
9279 gcc -Wbad-function-cast warning.
9280 (default_value, arithcompare, arith_driver, arith_error): Now static.
9281 (store_symval_forwarding): Rename local to avoid shadowing.
9282 (Fmake_variable_buffer_local, Fmake_local_variable):
9283 Mark variables as initialized.
9284 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9285
9286 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9287 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9288 Rename locals to avoid shadowing.
9289 (mark_stack): Move local variables into the #ifdef region where
9290 they're used.
9291 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9292 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9293 needed otherwise.
9294 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9295 (GC_STRING_CHARS): Remove; not used.
9296 (Fmemory_limit): Cast sbrk's returned value to char *.
9297
9298 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9299 avoids undefined behavior in theory.
9300
9301 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9302
9303 Use functions, not macros, for up- and down-casing (Bug#8254).
9304 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9305 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9306 to use the following functions instead of these macros.
9307 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9308 EMACS_INT, since callers assume the returned value fits in int.
9309 (upcase1): Likewise, for UPCASE_TABLE.
9310 (uppercasep, lowercasep, upcase): New static inline functions.
9311 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9312 the race-condition problem in the old DOWNCASE.
9313
9314 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9315 Rename locals to avoid shadowing.
9316 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9317 (regex_compile, re_search_2, re_match_2_internal):
9318 Remove unused local vars.
9319 (FREE_VAR): Rewrite so as not to use empty "else",
9320 which gcc can warn about.
9321 (regex_compile, re_match_2_internal): Mark locals as initialized.
9322 (RETALLOC_IF): Define only if needed.
9323 (WORDCHAR_P): Likewise. This one is never needed, but is used
9324 only in a comment talking about a compiler bug, so put inside
9325 the #if 0 of that comment.
9326 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9327 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9328 Remove; unused.
9329
9330 * search.c (boyer_moore): Rename locals to avoid shadowing.
9331 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9332 (PREV_CHAR_BOUNDARY): Likewise.
9333
9334 * search.c (simple_search): Remove unused var.
9335
9336 * dired.c (compile_pattern): Move decl from here ...
9337 * lisp.h: ... to here, so that it can be checked.
9338 (struct re_registers): New forward decl.
9339
9340 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9341
9342 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9343 All uses changed.
9344 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9345 Rename locals to avoid shadowing.
9346 (Fvertical_motion): Mark locals as initialized.
9347
9348 * casefiddle.c (casify_object, casify_region): Now static.
9349 (casify_region): Mark local as initialized.
9350
9351 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9352
9353 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9354 New macros, so that the caller can use some names other than
9355 gcpro1, gcpro2, etc.
9356 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9357 of the new macros.
9358 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9359 argument, for consistency with GCPRO2_VAR, etc: it is now the
9360 prefix of the variable, not the variable itself. All uses
9361 changed.
9362 * dired.c (directory_files_internal, file_name_completion):
9363 Rename locals to avoid shadowing.
9364
9365 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9366 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9367 dired.c's scmp function, had undefined behavior.
9368 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9369 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9370 * buffer.h: ... to here, because these macros use current_buffer,
9371 and the new implementation with inline functions needs to have
9372 current_buffer in scope now, rather than later when the macros
9373 are used.
9374 (downcase, upcase1): New static inline functions.
9375 (DOWNCASE, UPCASE1): Reimplement using these functions.
9376 This avoids undefined behavior in expressions like
9377 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9378 from race conditions in accessing the global variables
9379 case_temp1 and case_temp2.
9380 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9381 * lisp.h (case_temp1, case_temp2): Remove their decls.
9382 * character.h (ASCII_CHAR_P): Move from here ...
9383 * lisp.h: ... to here, so that the inline functions mentioned
9384 above can use them.
9385
9386 * dired.c (directory_files_internal_unwind): Now static.
9387
9388 * fileio.c (file_name_as_directory, directory_file_name):
9389 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9390 Now static.
9391 (file_name_as_directory): Use const pointers when appropriate.
9392 (Fexpand_file_name): Likewise. In particular, newdir might
9393 point at constant storage, so make it a const pointer.
9394 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9395 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9396 signedness issues.
9397 (Fset_file_times, Finsert_file_contents, auto_save_error):
9398 Rename locals to avoid shadowing.
9399
9400 * minibuf.c (choose_minibuf_frame_1): Now static.
9401 (Ftry_completion, Fall_completions): Rename or remove locals
9402 to avoid shadowing.
9403
9404 * marker.c (bytepos_to_charpos): Remove; unused.
9405
9406 * lisp.h (verify_bytepos, count_markers): New decls,
9407 so that gcc does not warn that these functions aren't declared.
9408
9409 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9410 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9411 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9412 (copy_text): Remove unused local var.
9413
9414 * filelock.c (within_one_second): Now static.
9415 (lock_file_1): Rename local to avoid shadowing.
9416
9417 * buffer.c (fix_overlays_before): Mark locals as initialized.
9418 (fix_start_end_in_overlays): Likewise. This function should be
9419 simplified by using pointers-to-pointers, but that's a different
9420 matter.
9421 (switch_to_buffer_1): Now static.
9422 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9423 (report_overlay_modification): Rename locals to avoid shadowing.
9424
9425 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9426 Fix pointer signedness issue.
9427 (sys_subshell): Mark local as volatile if checking for lint,
9428 to suppress a gcc -Wclobbered warning that does not seem to be right.
9429 (MAXPATHLEN): Define only if needed.
9430
9431 * process.c (serial_open, serial_configure): Move decls from here ...
9432 * systty.h: ... to here, so that they can be checked.
9433
9434 * fns.c (get_random, seed_random): Move extern decls from here ...
9435 * lisp.h: ... to here, so that they can be checked.
9436
9437 * sysdep.c (reset_io): Now static.
9438 (wait_for_termination_signal): Remove; unused.
9439
9440 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9441 (copy_keymap_item, append_key, push_text_char_description):
9442 Now static.
9443 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9444 (DENSE_TABLE_SIZE): Remove; unused.
9445 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9446 (describe_map_tree):
9447 Rename locals to avoid shadowing.
9448
9449 * keyboard.c: Declare functions static if they are not used elsewhere.
9450 (echo_char, echo_dash, cmd_error, top_level_2):
9451 (poll_for_input, handle_async_input): Now static.
9452 (read_char, kbd_buffer_get_event, make_lispy_position):
9453 (make_lispy_event, make_lispy_movement, apply_modifiers):
9454 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9455 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9456 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9457 (read_key_sequence, read_char): Mark locals as initialized.
9458 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9459
9460 * keyboard.h (make_ctrl_char): New decl.
9461 (mark_kboards): Move decl here ...
9462 * alloc.c (mark_kboards): ... from here.
9463
9464 * lisp.h (force_auto_save_soon): New decl.
9465
9466 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9467 (DEFINE_DUMMY_FUNCTION): New macro.
9468 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9469 Use it.
9470 (main): Add casts to avoid warnings
9471 if GCC considers string literals to be constants.
9472
9473 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9474
9475 * dbusbind.c: Pointer signedness fixes.
9476 (xd_signature, xd_append_arg, xd_initialize):
9477 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9478 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9479 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9480 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9481
9482 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9483 if GCC considers string literals to be constants.
9484 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9485
9486 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9487
9488 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9489 (print_preprocess, print_object): New macro to fix last change.
9490
9491 * print.c (print_preprocess): Don't forget font objects.
9492
9493 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9494
9495 * emacs.c (USAGE3): Doc fixes.
9496
9497 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9498
9499 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9500 structure.
9501
9502 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9503
9504 * lisp.h (VWindow_system, Qfile_name_history):
9505 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9506 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9507 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9508
9509 * w32select.c: Don't #include "keyboard.h".
9510 (run_protected): Add extern declaration for waiting_for_input.
9511
9512 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9513 * w32console.c (detect_input_pending, read_input_pending)
9514 (encode_terminal_code):
9515 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9516 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9517 (w32_system_caret_y, Qfile_name_history):
9518 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9519 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9520 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9521 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9522 * w32proc.c (Qlocal, report_file_error):
9523 * w32term.c (Vwindow_system, updating_frame):
9524 * w32uniscribe.c (initialized, uniscribe_font_driver):
9525 Remove unneeded extern declarations.
9526
9527 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9528
9529 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9530
9531 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9532
9533 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9534 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9535 These macros can no longer be used for assignment.
9536
9537 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9538 Assign struct members directly, instead of using BUF_BEGV etc.
9539 (record_buffer_markers, fetch_buffer_markers): New functions for
9540 recording and fetching special buffer markers.
9541 (set_buffer_internal_1, set_buffer_temp): Use them.
9542
9543 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9544
9545 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9546
9547 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9548 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9549
9550 * xdisp.c (hscroll_window_tree):
9551 (reconsider_clip_changes): Use PT instead of BUF_PT.
9552
9553 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9554
9555 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9556 $(EMACS_ROOT)/lib/intprops.h.
9557
9558 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9559
9560 Fix more problems found by GCC 4.5.2's static checks.
9561
9562 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9563 to unsigned char * to avoid compiler diagnostic.
9564 (xg_free_frame_widgets): Make it clear that a local variable is
9565 needed only if USE_GTK_TOOLTIP.
9566 (gdk_window_get_screen): Make it clear that this macro is needed
9567 only if USE_GTK_TOOLTIP.
9568 (int_gtk_range_get_value): New function, which avoids a diagnostic
9569 from gcc -Wbad-function-cast.
9570 (xg_set_toolkit_scroll_bar_thumb): Use it.
9571 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9572 diagnostic from gcc -Wbad-function-cast.
9573 (get_utf8_string, xg_get_file_with_chooser):
9574 Rename locals to avoid shadowing.
9575 (create_dialog): Move locals to avoid shadowing.
9576
9577 * xgselect.c (xg_select): Remove unused var.
9578
9579 * image.c (four_corners_best): Mark locals as initialized.
9580 (gif_load): Initialize transparent_p to zero (Bug#8238).
9581 Mark another local as initialized.
9582 (my_png_error, my_error_exit): Mark with NO_RETURN.
9583
9584 * image.c (clear_image_cache): Now static.
9585 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9586 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9587 (x_edge_detection): Remove unnecessary cast that
9588 gcc -Wbad-function-cast diagnoses.
9589 (gif_load): Fix pointer signedness.
9590 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9591 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9592
9593 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9594
9595 Improve quality of tests for time stamp overflow.
9596 For example, without this patch (encode-time 0 0 0 1 1
9597 1152921504606846976) returns the obviously-bogus value (-948597
9598 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9599 reports time overflow. See
9600 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9601 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9602 * editfns.c: Include limits.h and intprops.h.
9603 (TIME_T_MIN, TIME_T_MAX): New macros.
9604 (time_overflow): Move earlier, to before first use.
9605 (hi_time, lo_time): New functions, for an accurate test for
9606 out-of-range times.
9607 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9608 (Fget_internal_run_time): Don't assume time_t fits in int.
9609 (make_time): Use list2 instead of Fcons twice.
9610 (Fdecode_time): More accurate test for out-of-range times.
9611 (check_tm_member): New function.
9612 (Fencode_time): Use it, to test for out-of-range times.
9613 (lisp_time_argument): Don't rely on undefined left-shift and
9614 right-shift behavior when checking for time stamp overflow.
9615
9616 * editfns.c (time_overflow): New function, refactoring common code.
9617 (Fformat_time_string, Fdecode_time, Fencode_time):
9618 (Fcurrent_time_string): Use it.
9619
9620 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9621 * dired.c (make_time): Move to ...
9622 * editfns.c (make_time): ... here.
9623 * systime.h: Note the move.
9624
9625 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9626
9627 * fringe.c (update_window_fringes): Remove unused variables.
9628
9629 * unexmacosx.c (copy_data_segment): Also copy __got section.
9630 (Bug#8223)
9631
9632 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9633
9634 * termcap.c [MSDOS]: Include "msdos.h".
9635 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9636 Constify `char *' arguments and their references according to
9637 prototypes in tparam.h.
9638
9639 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9640
9641 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9642 Adapt all references accordingly.
9643
9644 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9645
9646 2011-03-11 Tom Tromey <tromey@redhat.com>
9647
9648 * buffer.c (syms_of_buffer): Remove obsolete comment.
9649
9650 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9651
9652 * termhooks.h (encode_terminal_code): Declare prototype.
9653
9654 * msdos.c (encode_terminal_code): Don't declare prototype.
9655
9656 * term.c (encode_terminal_code): Now external again, used by
9657 w32console.c and msdos.c.
9658
9659 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9660 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9661
9662 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9663
9664 Fix some minor problems found by GCC 4.5.2's static checks.
9665
9666 * fringe.c (update_window_fringes): Mark locals as initialized
9667 (Bug#8227).
9668 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9669
9670 * alloc.c (mark_fringe_data): Move decl from here ...
9671 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9672 to check its interface.
9673 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9674
9675 * fontset.c (free_realized_fontset): Now static.
9676 (Fset_fontset_font): Rename local to avoid shadowing.
9677 (fontset_font): Mark local as initialized.
9678 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9679
9680 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9681
9682 * xselect.c (x_disown_buffer_selections): Remove; not used.
9683 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9684 (x_own_selection, Fx_disown_selection_internal): Rename locals
9685 to avoid shadowing.
9686 (x_handle_dnd_message): Remove local to avoid shadowing.
9687
9688 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9689 so that the caller can use some name other than gcpro1.
9690 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9691 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9692 (Fx_backspace_delete_keys_p):
9693 Use them to avoid shadowing, and rename vars to avoid shadowing.
9694 (x_decode_color, x_set_name, x_window): Now static.
9695 (Fx_create_frame): Add braces to silence GCC warning.
9696 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9697 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9698 Remove unused locals.
9699 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9700 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9701 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9702 macros.
9703
9704 * xterm.h (x_mouse_leave): New decl.
9705
9706 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9707 Remove unused functions.
9708 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9709 (x_calc_absolute_position): Now static.
9710 (XTread_socket): Don't define label "out" unless it's used.
9711 Don't declare local "event" unless it's used.
9712 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9713 unless they are used.
9714 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9715 (x_fatal_error_signal): Remove; not used.
9716 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9717 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9718 (x_error_catcher, x_connection_closed, x_error_handler):
9719 (x_error_quitter, xembed_send_message, x_iconify_frame):
9720 (my_log_handler): Rename locals to avoid shadowing.
9721 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9722 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9723
9724 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9725 Rename or move locals to avoid shadowing.
9726 (tty_defined_color, merge_face_heights): Now static.
9727 (free_realized_faces_for_fontset): Remove; not used.
9728 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9729 does not deduce is never used uninitialized.
9730 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9731 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9732
9733 * terminal.c (store_terminal_param): Now static.
9734
9735 * xmenu.c (menu_highlight_callback): Now static.
9736 (set_frame_menubar): Remove unused local.
9737 (xmenu_show): Rename parameter to avoid shadowing.
9738 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9739 since they might point to immutable storage.
9740 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9741 since it's unused otherwise.
9742
9743 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9744 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9745 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9746 avoids a gcc -Wuninitialized diagnostic.
9747 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9748 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9749 does not deduce are never used uninitialized.
9750
9751 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9752
9753 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9754 * window.c (window_loop, size_window):
9755 (run_window_configuration_change_hook, enlarge_window): Likewise.
9756
9757 * window.c (display_buffer): Now static.
9758 (size_window): Mark variables that gcc -Wuninitialized
9759 does not deduce are never used uninitialized.
9760 * window.h (check_all_windows): New decl, to forestall
9761 gcc -Wmissing-prototypes diagnostic.
9762 * dispextern.h (bidi_dump_cached_states): Likewise.
9763
9764 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9765 shadowing.
9766 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9767 Include <limits.h>.
9768 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9769 and to avoid gcc -Wuninitialized warning.
9770 (load_charset_map): Mark variables that gcc -Wuninitialized
9771 does not deduce are never used uninitialized.
9772 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9773
9774 * coding.c (coding_set_source, coding_set_destination):
9775 Use "else { /* comment */ }" rather than "else /* comment */;"
9776 for clarity, and to avoid gcc -Wempty-body warning.
9777 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9778 a block, when the outer 'i' will do.
9779 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9780 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9781 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9782 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9783 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9784 Rename locals to avoid shadowing.
9785 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9786 * coding.c (emacs_mule_char, encode_invocation_designation):
9787 Now static, since they're not used elsewhere.
9788 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9789 (decode_coding_object, encode_coding_object, detect_coding_system):
9790 (decode_coding_emacs_mule): Mark variables that gcc
9791 -Wuninitialized does not deduce are never used uninitialized.
9792 (detect_coding_iso_2022): Initialize a local variable that might
9793 be used uninitialized. Leave a FIXME because it's not clear that
9794 this initialization is needed. (Bug#8211)
9795 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9796 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9797 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9798 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9799 Remove unused macros.
9800
9801 * category.c (hash_get_category_set): Remove unused local var.
9802 (copy_category_table): Now static, since it's not used elsewhere.
9803 * character.c (string_count_byte8): Likewise.
9804
9805 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9806 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9807
9808 * chartab.c (copy_sub_char_table): Now static, since it's not used
9809 elsewhere.
9810 (sub_char_table_ref_and_range, char_table_ref_and_range):
9811 Rename locals to avoid shadowing.
9812 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9813
9814 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9815 (BIDI_BOB): Remove unused macro.
9816
9817 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9818 deduce are never used uninitialized.
9819 * term.c (encode_terminal_code): Likewise.
9820
9821 * term.c (encode_terminal_code): Now static. Remove unused local.
9822
9823 * tparam.h: New file.
9824 * term.c, tparam.h: Include it.
9825 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9826 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9827 Move these decls to tparam.h, and make them agree with what
9828 is actually in tparam.c. The previous trick of using incompatible
9829 decls in different modules does not conform to the C standard.
9830 All callers of tparam changed to use tparam's actual API.
9831 * tparam.c (tparam1, tparam, tgoto):
9832 Use const pointers where appropriate.
9833
9834 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9835 * cm.h (struct cm): Likewise.
9836 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9837 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9838 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9839 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9840 (turn_on_face, init_tty): Likewise.
9841 * termchar.h (struct tty_display_info): Likewise.
9842
9843 * term.c (term_mouse_position): Rename local to avoid shadowing.
9844
9845 * alloc.c (mark_ttys): Move decl from here ...
9846 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9847
9848 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9849
9850 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9851
9852 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9853
9854 * search.c (compile_pattern_1): Remove argument regp, unused since
9855 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9856 (compile_pattern): Don't pass it.
9857
9858 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9859
9860 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9861 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9862 for ! HAVE_GTK3.
9863 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9864
9865 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9866
9867 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9868 gdk_window_get_screen, gdk_window_get_geometry,
9869 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9870 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9871 (xg_get_pixbuf_from_pixmap): New function.
9872 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9873 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9874 Call xg_get_pixbuf_from_pixmap instead of
9875 gdk_pixbuf_get_from_drawable.
9876 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9877 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9878 (xg_check_special_colors): Use GtkStyleContext and its functions
9879 for HAVE_GTK3.
9880 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9881 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9882 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9883 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9884 Call gtk_widget_get_preferred_size.
9885 (xg_frame_resized): gdk_window_get_geometry only takes 5
9886 parameters.
9887 (xg_win_to_widget, xg_event_is_for_menubar):
9888 Call gdk_x11_window_lookup_for_display.
9889 (xg_set_widget_bg): New function.
9890 (delete_cb): New function.
9891 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9892 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9893 (xg_set_background_color): Call xg_set_widget_bg.
9894 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9895 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9896 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9897 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9898 if ! HAVE_GTK3.
9899 (update_frame_tool_bar): Call gtk_widget_hide.
9900 (xg_initialize): Use GDK_KEY_g.
9901
9902 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9903 if ! HAVE_GTK3
9904 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9905
9906 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9907 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9908 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9909
9910 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9911
9912 * w32xfns.c (select_palette): Check success of RealizePalette against
9913 GDI_ERROR, not zero.
9914
9915 See ChangeLog.11 for earlier changes.
9916
9917 ;; Local Variables:
9918 ;; coding: utf-8
9919 ;; End:
9920
9921 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9922
9923 This file is part of GNU Emacs.
9924
9925 GNU Emacs is free software: you can redistribute it and/or modify
9926 it under the terms of the GNU General Public License as published by
9927 the Free Software Foundation, either version 3 of the License, or
9928 (at your option) any later version.
9929
9930 GNU Emacs is distributed in the hope that it will be useful,
9931 but WITHOUT ANY WARRANTY; without even the implied warranty of
9932 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9933 GNU General Public License for more details.
9934
9935 You should have received a copy of the GNU General Public License
9936 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.