]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* src/xselect.c (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
[gnu-emacs] / src / ChangeLog
1 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2
3 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4 (x_clipboard_manager_save): Add return value.
5 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
6 error handlers.
7 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8 Obey Vx_select_enable_clipboard_manager. Catch errors in
9 x_clipboard_manager_save (Bug#8779).
10 (Vx_select_enable_clipboard_manager): New variable.
11 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
12
13 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
14
15 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
16
17 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
18
19 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
20 in the current matrix if keep_current_p is non-zero.
21
22 2011-06-04 Eli Zaretskii <eliz@gnu.org>
23
24 * bidi.c (bidi_level_of_next_char): Fix last change.
25
26 2011-06-03 Eli Zaretskii <eliz@gnu.org>
27
28 Support bidi reordering of text covered by display properties.
29
30 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
31 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
32 (bidi_cache_search, bidi_cache_iterator_state)
33 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
34 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
35 character positions inside a run of characters covered by a
36 display string.
37 (bidi_paragraph_init, bidi_resolve_explicit_1)
38 (bidi_level_of_next_char): Call bidi_fetch_char and
39 bidi_fetch_char_advance instead of FETCH_CHAR and
40 FETCH_CHAR_ADVANCE.
41 (bidi_init_it): Initialize new members.
42 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
43 definitions.
44 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
45 instead of using explicit *_CHAR codes.
46 (bidi_resolve_explicit, bidi_resolve_weak): Use
47 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
48 bidirectional text is supported only in multibyte buffers.
49 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
50 it to initialize the frame_window_p member of struct bidi_it.
51 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
52 (bidi_resolve_explicit, bidi_resolve_weak)
53 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
54 bidi_it->nchars is non-positive.
55 (bidi_level_of_next_char): Don't try to lookup the cache for the
56 next/previous character if nothing is cached there yet, or if we
57 were just reseat()'ed to a new position.
58
59 * xdisp.c (set_cursor_from_row): Set start and stop points
60 according to the row's direction when priming the loop that looks
61 for the glyph on which to display cursor.
62 (single_display_spec_intangible_p): Function deleted.
63 (display_prop_intangible_p): Reimplement to call
64 handle_display_spec instead of single_display_spec_intangible_p.
65 Accept 3 additional arguments needed by handle_display_spec. This
66 fixes incorrect cursor motion across display property with complex
67 values: lists, `(when COND...)' forms, etc.
68 (single_display_spec_string_p): Support property values that are
69 lists with the argument STRING its top-level element.
70 (display_prop_string_p): Fix the condition for processing a
71 property that is a list to be consistent with handle_display_spec.
72 (handle_display_spec): New function, refactored from the
73 last portion of handle_display_prop.
74 (compute_display_string_pos): Accept additional argument
75 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
76 value of a `display' property is a "replacing spec".
77 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
78 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
79 the display property, but just return a value indicating whether
80 the display property will replace the characters it covers.
81 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
82 frame_window_p members of struct bidi_it.
83 (compute_display_string_pos, compute_display_string_end): New
84 functions.
85 (push_it): Accept second argument POSITION, where pop_it should
86 jump to continue iteration.
87 (reseat_1): Initialize bidi_it.disp_pos.
88
89 * keyboard.c (adjust_point_for_property): Adjust the call to
90 display_prop_intangible_p to its new signature.
91
92 * dispextern.h (struct bidi_it): New member frame_window_p.
93 (bidi_init_it): Update prototypes.
94 (display_prop_intangible_p): Update prototype.
95 (compute_display_string_pos, compute_display_string_end): Declare
96 prototypes.
97 (struct bidi_it): New members nchars and disp_pos. ch_len is now
98 EMACS_INT.
99
100 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
101
102 Malloc failure behavior now depends on size of allocation.
103 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
104 * lisp.h: Change signatures accordingly.
105 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
106 All callers changed. (Bug#8762)
107
108 * gnutls.c: Use Emacs's memory allocators.
109 Without this change, the gnutls library would invoke malloc etc.
110 directly, which causes problems on non-SYNC_INPUT hosts, and which
111 runs afoul of improving memory_full behavior. (Bug#8761)
112 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
113 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
114 xfree instead of the default malloc, realloc, free.
115 (Fgnutls_boot): No need to check for memory allocation failure,
116 since xmalloc does that for us.
117
118 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
119 * category.c (hash_get_category_set):
120 * ccl.c (ccl_driver):
121 * charset.c (Fdefine_charset_internal):
122 * charset.h (struct charset.hash_index):
123 * composite.c (get_composition_id, gstring_lookup_cache)
124 (composition_gstring_put_cache):
125 * composite.h (struct composition.hash_index):
126 * dispextern.h (struct image.hash):
127 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
128 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
129 (hashfn_equal, hashfn_user_defined, make_hash_table)
130 (maybe_resize_hash_table, hash_lookup, hash_put)
131 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
132 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
133 (Fsxhash, Fgethash, Fputhash, Fmaphash):
134 * image.c (make_image, search_image_cache, lookup_image)
135 (xpm_put_color_table_h):
136 * lisp.h (struct Lisp_Hash_Table):
137 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
138 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
139 for hashes and hash indexes, instead of 'unsigned' and 'int'.
140 * alloc.c (allocate_vectorlike):
141 Check for overflow in vector size calculations.
142 * ccl.c (ccl_driver):
143 Check for overflow when converting EMACS_INT to int.
144 * fns.c, image.c: Remove unnecessary static decls that would otherwise
145 need to be updated by these changes.
146 * fns.c (make_hash_table, maybe_resize_hash_table):
147 Check for integer overflow with large hash tables.
148 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
149 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
150 (SXHASH_REDUCE): New macro.
151 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
152 Use it instead of discarding useful hash info with large hash values.
153 (sxhash_float): New function.
154 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
155 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
156 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
157 Rewrite to use FIXNUM_BITS, as this simplifies things.
158 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
159 Adjust signatures to match updated version of code.
160 (consing_since_gc): Now EMACS_INT, since a single hash table can
161 use more than INT_MAX bytes.
162
163 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
164
165 Make it possible to build with GCC-4.6+ -O2 -flto.
166
167 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
168
169 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
170
171 * minibuf.c (get_minibuffer, read_minibuf_unwind):
172 Call minibuffer-inactive-mode.
173
174 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
175
176 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
177 Update dependencies.
178
179 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
180
181 * data.c (init_data): Remove code for UTS, this system is not
182 supported anymore.
183
184 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
185
186 Don't force ./temacs to start in terminal mode.
187
188 * frame.c (make_initial_frame): Initialize faces in all cases, not
189 only when CANNOT_DUMP is defined.
190 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
191
192 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
193
194 * dispnew.c (add_window_display_history): Use const for the string
195 pointer. Remove declaration, not needed.
196
197 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
198
199 Use 'inline', not 'INLINE'.
200 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
201 * alloc.c, fontset.c (INLINE): Remove.
202 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
203 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
204 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
205 * gmalloc.c (register_heapinfo): Use inline unconditionally.
206 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
207
208 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
209
210 Make it possible to run ./temacs.
211
212 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
213 syms_of_callproc does the same thing. Remove test for
214 "initialized", do it in the caller.
215 * emacs.c (main): Avoid calling set_initial_environment when dumping.
216
217 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
218
219 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
220 (read_minibuf): Use get_minibuffer.
221 (syms_of_minibuf): Use DEFSYM.
222 (Qmetadata): New var.
223 * data.c (Qbuffer): Don't make it static.
224 (syms_of_data): Use DEFSYM.
225
226 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
227
228 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
229 (CCL_CODE_MIN): New macro.
230
231 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
232
233 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
234
235 * eval.c (Qdebug): Now static.
236 * lisp.h (Qdebug): Remove decl. This reverts a part of the
237 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
238 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
239
240 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
241
242 * image.c: Various fixes to ImageMagick code comments.
243 (Fimagemagick_types): Doc fix.
244
245 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
246
247 Minor fixes prompted by GCC 4.6.0 warnings.
248
249 * xselect.c (converted_selections, conversion_fail_tag): Now static.
250
251 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
252 (x_clipboard_manager_save_all): Move extern decl to ...
253 * xterm.h: ... here, so that it can be checked for consistency.
254
255 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
256
257 * xselect.c (x_clipboard_manager_save_frame)
258 (x_clipboard_manager_save_all): New functions.
259 (Fx_clipboard_manager_save): Lisp function deleted.
260
261 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
262 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
263
264 * xterm.h: Update prototype.
265
266 2011-05-28 William Xu <william.xwl@gmail.com>
267
268 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
269 exiting (Bug#8239).
270
271 2011-05-28 Jim Meyering <meyering@redhat.com>
272
273 Avoid a sign-extension bug in crypto_hash_function.
274 * fns.c (to_uchar): Define.
275 (crypto_hash_function): Use it to convert some newly-signed
276 variables to unsigned, to avoid sign-extension bugs. For example,
277 without this change, (md5 "truc") would evaluate to
278 45723a2aff78ff4fff7fff1114760e62 rather than the expected
279 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
280 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
281
282 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
283
284 Integer overflow fixes.
285
286 * dbusbind.c: Serial number integer overflow fixes.
287 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
288 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
289 to hold a serial number that is too large for a fixnum.
290 (Fdbus_method_return_internal, Fdbus_method_error_internal):
291 Check for serial numbers out of range. Decode any serial number
292 that was so large that it became a float. (Bug#8722)
293
294 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
295 (Fdbus_call_method, Fdbus_call_method_asynchronously):
296 Use XFASTINT rather than XUINT when numbers are nonnegative.
297 (xd_append_arg, Fdbus_method_return_internal):
298 (Fdbus_method_error_internal): Likewise. Also, for unsigned
299 arguments, check that Lisp number is nonnegative, rather than
300 silently wrapping negative numbers around. (Bug#8722)
301 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
302 (Bug#8722)
303
304 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
305
306 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
307
308 ccl: add integer overflow checks
309 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
310 (IN_INT_RANGE): New macros.
311 (ccl_driver): Use them to check for integer overflow when
312 decoding a CCL program. Many of the new checks are whether XINT (x)
313 fits in int; it doesn't always, on 64-bit hosts. The new version
314 doesn't catch all possible integer overflows, but it's an
315 improvement. (Bug#8719)
316
317 * alloc.c (make_event_array): Use XINT, not XUINT.
318 There's no need for unsigned here.
319
320 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
321 This follows up to the 2011-05-06 change that substituted uintptr_t
322 for EMACS_INT. This case wasn't caught back then.
323
324 Rework Fformat to avoid integer overflow issues.
325 * editfns.c: Include <float.h> unconditionally, as it's everywhere
326 now (part of C89). Include <verify.h>.
327 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
328 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
329 (Fformat): Avoid the prepass trying to compute sizes; it was only
330 approximate and thus did not catch overflow reliably. Instead, walk
331 through the format just once, formatting and computing sizes as we go,
332 checking for integer overflow at every step, and allocating a larger
333 buffer as needed. Keep track separately whether the format is
334 multibyte. Keep only the most-recently calculated precision, rather
335 than them all. Record whether each argument has been converted to
336 string. Use EMACS_INT, not int, for byte and char and arg counts.
337 Support field widths and precisions larger than INT_MAX. Avoid
338 sprintf's undefined behavior with conversion specifications such as %#d
339 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
340 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
341 formatting out-of-range floating point numbers with int
342 formats. (Bug#8668)
343
344 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
345
346 * data.c: Avoid integer truncation in expressions involving floats.
347 * data.c: Include <intprops.h>.
348 (arith_driver): When there's an integer overflow in an expression
349 involving floating point, convert the integers to floating point
350 so that the resulting value does not suffer from catastrophic
351 integer truncation. For example, on a 64-bit host (* 4
352 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
353 Do not rely on undefined behavior after integer overflow.
354
355 merge count_size_as_multibyte, parse_str_to_multibyte
356 * character.c, character.h (count_size_as_multibyte):
357 Rename from parse_str_to_multibyte; all uses changed.
358 Check for integer overflow.
359 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
360 since it's now a duplicate of the other. This is more of
361 a character than a buffer op, so better that it's in character.c.
362 * fns.c, print.c: Adjust to above changes.
363
364 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
365
366 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
367
368 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
369
370 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
371 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
372 (x_clipboard_manager_save): Now static.
373 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
374
375 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
376 (crypto_hash_function): Now static.
377 Fix pointer signedness problems. Avoid unnecessary initializations.
378
379 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
380
381 * termhooks.h (Vselection_alist): Make it terminal-local.
382
383 * terminal.c (create_terminal): Initialize it.
384
385 * xselect.c: Support for clipboard managers.
386 (Vselection_alist): Move to termhooks.h as terminal-local var.
387 (LOCAL_SELECTION): New macro.
388 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
389 (symbol_to_x_atom): Remove gratuitous arg.
390 (x_handle_selection_request, lisp_data_to_selection_data)
391 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
392 (x_own_selection, x_get_local_selection, x_convert_selection):
393 New arg, specifying work frame. Use terminal-local Vselection_alist.
394 (some_frame_on_display): Delete unused function.
395 (Fx_own_selection_internal, Fx_get_selection_internal)
396 (Fx_disown_selection_internal, Fx_selection_owner_p)
397 (Fx_selection_exists_p): New optional frame arg.
398 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
399 (x_handle_selection_clear): Don't treat other terminals with the
400 same keyboard specially. Use the terminal-local Vselection_alist.
401 (x_clear_frame_selections): Use Frun_hook_with_args.
402
403 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
404
405 * xterm.h: Add support for those atoms.
406
407 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
408
409 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
410 (converted_selections, conversion_fail_tag): New global variables.
411 (x_selection_request_lisp_error): Free the above.
412 (x_get_local_selection): Remove unnecessary code.
413 (x_reply_selection_request): Args changed; handle arbitrary array
414 of converted selections stored in converted_selections.
415 Separate the XChangeProperty and SelectionNotify steps.
416 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
417 (x_convert_selection): New function.
418 (x_handle_selection_event): Simplify.
419 (x_get_foreign_selection): Don't ignore incoming requests while
420 waiting for an answer; this will fail when we implement
421 SAVE_TARGETS, and seems unnecessary anyway.
422 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
423 (Vx_sent_selection_functions): Doc fix.
424
425 2011-05-26 Leo Liu <sdl.web@gmail.com>
426
427 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
428
429 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
430
431 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
432
433 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
434 for fringe update if it has periodic bitmap.
435 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
436 and fringe_bitmap_periodic_p.
437
438 * fringe.c (get_fringe_bitmap_data): New function.
439 (draw_fringe_bitmap_1, update_window_fringes): Use it.
440 (update_window_fringes): Record periodicity of fringe bitmap in glyph
441 row. Mark glyph row for fringe update if periodicity changed.
442
443 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
444 for fringe update unless it has periodic bitmap.
445
446 2011-05-25 Kenichi Handa <handa@m17n.org>
447
448 * xdisp.c (get_next_display_element): Set correct it->face_id for
449 a static composition.
450
451 2011-05-24 Leo Liu <sdl.web@gmail.com>
452
453 * deps.mk (fns.o):
454 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
455
456 * fns.c (crypto_hash_function, Fsha1): New function.
457 (Fmd5): Use crypto_hash_function.
458 (syms_of_fns): Add Ssha1.
459
460 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
461
462 * gnutls.c: Remove unused macros.
463 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
464 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
465 Remove macros that are defined and never used.
466 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
467
468 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
469
470 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
471 (Fx_get_selection_internal): Minor cleanup.
472 (Fx_own_selection_internal): Rename arguments for consistency with
473 select.el.
474
475 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
476
477 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
478
479 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
480
481 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
482
483 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
484
485 * dispnew.c (scrolling_window): Don't exclude the case that the
486 last enabled row in the desired matrix touches the bottom boundary.
487
488 2011-05-21 Glenn Morris <rgm@gnu.org>
489
490 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
491 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
492 and add some more files.
493
494 2011-05-20 Eli Zaretskii <eliz@gnu.org>
495
496 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
497 report_file_error introduced by the change from 2011-05-07.
498
499 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
500
501 * systime.h (Time): Define only if emacs is defined.
502 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
503 where the include path doesn't have X11/X.h by default. See
504 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
505
506 2011-05-20 Kenichi Handa <handa@m17n.org>
507
508 * composite.c (find_automatic_composition): Fix previous change.
509
510 2011-05-20 Glenn Morris <rgm@gnu.org>
511
512 * lisp.mk: New file, split from Makefile.in.
513 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
514 (shortlisp): Remove.
515 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
516
517 2011-05-19 Glenn Morris <rgm@gnu.org>
518
519 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
520 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
521 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
522 (lisp): Set the order to that of loadup.el.
523 (shortlisp): Make it a copy of $lisp.
524 (SOME_MACHINE_LISP): Remove.
525 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
526 Use just $shortlisp, not $SOME_MACHINE_LISP too.
527
528 2011-05-18 Kenichi Handa <handa@m17n.org>
529
530 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
531 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
532 (find_automatic_composition): Mostly rewrite for efficiency.
533
534 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
535
536 * makefile.w32-in: Update dependencies.
537
538 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
539
540 * menu.c: Include limits.h (fixes the MS-Windows build broken by
541 revision 104625).
542
543 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
544
545 Fix some integer overflow issues, such as string length overflow.
546
547 * insdel.c (count_size_as_multibyte): Check for string overflow.
548
549 * character.c (lisp_string_width): Check for string overflow.
550 Use EMACS_INT, not int, for string indexes and lengths; in
551 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
552 the resulting string length overflows an EMACS_INT; instead,
553 report a string overflow if no precision given. When checking for
554 precision exhaustion, use a check that cannot possibly have
555 integer overflow. (Bug#8675)
556 * character.h (lisp_string_width): Adjust to new signature.
557
558 * alloc.c (string_overflow): New function.
559 (Fmake_string): Use it. This doesn't change behavior, but saves
560 a few bytes and will simplify future changes.
561 * character.c (string_escape_byte8): Likewise.
562 * lisp.h (string_overflow): New decl.
563
564 Fixups, following up to the user-interface timestamp change.
565 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
566 for UI timestamps, instead of unsigned long.
567 * msdos.c (mouse_get_pos): Likewise.
568 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
569 * w32gui.h (Time): Define by including "systime.h" rather than by
570 declaring it ourselves. (Bug#8664)
571
572 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
573 * image.c (clear_image_cache): Likewise.
574
575 * term.c (term_mouse_position): Don't assume time_t wraparound.
576
577 Be more systematic about user-interface timestamps.
578 Before, the code sometimes used 'Time', sometimes 'unsigned long',
579 and sometimes 'EMACS_UINT', to represent these timestamps.
580 This change causes it to use 'Time' uniformly, as that's what X uses.
581 This makes the code easier to follow, and makes it easier to catch
582 integer overflow bugs such as Bug#8664.
583 * frame.c (Fmouse_position, Fmouse_pixel_position):
584 Use Time, not unsigned long, for user-interface timestamps.
585 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
586 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
587 * keyboard.h (last_event_timestamp): Likewise.
588 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
589 * menu.h (xmenu_show): Likewise.
590 * term.c (term_mouse_position): Likewise.
591 * termhooks.h (struct input_event.timestamp): Likewise.
592 (struct terminal.mouse_position_hook): Likewise.
593 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
594 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
595 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
596 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
597 what it was before.
598 * menu.h, termhooks.h: Include "systime.h", for Time.
599
600 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
601 Don't assume that the difference between two unsigned long values
602 can fit into an integer. At this point, we know button_down_time
603 <= event->timestamp, so the difference must be nonnegative, so
604 there's no need to cast the result if double-click-time is
605 nonnegative, as it should be; check that it's nonnegative, just in
606 case. This bug is triggered when events are more than 2**31 ms
607 apart (about 25 days). (Bug#8664)
608
609 * xselect.c (last_event_timestamp): Remove duplicate decl.
610 (x_own_selection): Remove needless cast to unsigned long.
611
612 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
613 that always fit in int. Use a sentinel instead of a counter, to
614 avoid a temp and to allay GCC's concerns about possible int overflow.
615 * frame.h (struct frame): Use int for menu_bar_items_used
616 instead of EMACS_INT, since it always fits in int.
617
618 * menu.c (grow_menu_items): Check for int overflow.
619
620 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
621
622 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
623 Before, the code was not consistent. These values cannot exceed
624 2**31 - 1 so there's no need to make them unsigned.
625 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
626 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
627 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
628 as modifiers.
629 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
630
631 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
632 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
633 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
634 presumably because the widths might not match.
635
636 * window.c (size_window): Avoid needless test at loop start.
637
638 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
639
640 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
641
642 2011-05-12 Drew Adams <drew.adams@oracle.com>
643
644 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
645
646 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
647
648 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
649 `width' to `bar_area_x' and `bar_area_width', respectively.
650 (x_scroll_run): Take account of fringe background extension.
651
652 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
653 Rename local vars `left' and `width' to `bar_area_x' and
654 `bar_area_width', respectively.
655 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
656 background extension.
657
658 2011-05-10 Jim Meyering <meyering@redhat.com>
659
660 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
661
662 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
663
664 * image.c (Finit_image_library): Return t for built-in image types,
665 like pbm and xbm. (Bug#8640)
666
667 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
668
669 * w32menu.c (set_frame_menubar): Fix submenu allocation.
670
671 2011-05-07 Eli Zaretskii <eliz@gnu.org>
672
673 * w32console.c (Fset_screen_color): Doc fix.
674 (Fget_screen_color): New function.
675 (syms_of_ntterm): Defsubr it.
676
677 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
678 unlink the temporary file if Fcall_process didn't create it in the
679 first place.
680 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
681 child process will be redirected to a file specified with `:file'.
682 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
683 cue to call_process_cleanup not to close that handle.
684
685 2011-05-07 Ben Key <bkey76@gmail.com>
686
687 * makefile.w32-in: The bootstrap-temacs rule now makes use of
688 one of two shell specific rules, either bootstrap-temacs-CMD or
689 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
690 to the previous implementation of the bootstrap-temacs rule.
691 The bootstrap-temacs-CMD rule is similar to the previous
692 implementation of the bootstrap-temacs rule except that it
693 makes use of the ESC_CFLAGS variable instead of the CFLAGS
694 variable.
695
696 These changes, along with some changes to nt/configure.bat,
697 nt/gmake.defs, and nt/nmake.defs, are required to extend my
698 earlier fix to add support for --cflags and --ldflags options
699 that include quotes so that it works whether make uses cmd or
700 sh as the shell.
701
702 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
703
704 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
705 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
706 is a constant.
707 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
708 a string. Handle both cases.
709 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
710 (Fdbus_register_method): Use Qinvalid_function.
711
712 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
713
714 * makefile.w32-in: Update dependencies.
715 (LISP_H): Add inttypes.h and stdin.h.
716 (PROCESS_H): Add unistd.h.
717
718 2011-05-06 Eli Zaretskii <eliz@gnu.org>
719
720 * lread.c: Include limits.h (fixes the MS-Windows build broken by
721 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
722
723 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
724
725 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
726
727 * term.c (vfatal): Remove stray call to va_end.
728 It's not needed and the C Standard doesn't allow it here anyway.
729
730 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
731 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
732
733 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
734 bytes.
735
736 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
737
738 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
739
740 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
741
742 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
743
744 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
745
746 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
747 * charset.c (Fdefine_charset_internal): Don't initialize
748 charset.code_space[15]. The value was garbage, on hosts with
749 32-bit int (Bug#8600).
750
751 * lread.c (read_integer): Be more consistent with string-to-number.
752 Use string_to_number to do the actual conversion; this avoids
753 rounding errors and fixes some other screwups. Without this fix,
754 for example, #x1fffffffffffffff was misread as -2305843009213693952.
755 (digit_to_number): Move earlier, for benefit of read_integer.
756 Return -1 if the digit is out of range for the base, -2 if it is
757 not a digit in any supported base. (Bug#8602)
758
759 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
760
761 * dispnew.c (scrolling_window): Return 1 if we scrolled,
762 to match comment at start of function. This also removes a
763 GCC warning about overflow in a 32+64-bit port.
764
765 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
766
767 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
768 Reported by Stefan Monnier in
769 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
770 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
771 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
772
773 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
774 (EMACS_UINTPTR): Likewise, with uintptr_t.
775
776 * lisp.h: Prefer 64-bit EMACS_INT if available.
777 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
778 on 32-bit hosts that have 64-bit int, so that they can access
779 large files.
780 However, temporarily disable this change unless the temporary
781 symbol WIDE_EMACS_INT is defined.
782
783 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
784
785 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
786 This removes an assumption that EMACS_INT and long are the same
787 width as pointers. The assumption is true for Emacs porting targets
788 now, but we want to make other targets possible.
789 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
790 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
791 In the rest of the code, change types of integers that hold casted
792 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
793 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
794 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
795 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
796 No need to cast type when ORing.
797 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
798 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
799 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
800 assume EMACS_INT is the same width as char *.
801 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
802 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
803 Remove no-longer-needed casts.
804 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
805 (xg_tool_bar_help_callback, xg_make_tool_item):
806 Use EMACS_INTPTR to hold an integer
807 that will be cast to void *; this can avoid a GCC warning
808 if EMACS_INT is not the same width as void *.
809 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
810 * xdisp.c (display_echo_area_1, resize_mini_window_1):
811 (current_message_1, set_message_1):
812 Use a local to convert to proper width without a cast.
813 * xmenu.c (dialog_selection_callback): Likewise.
814
815 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
816 Also, don't assume VALBITS / RAND_BITS is less than 5,
817 and don't rely on undefined behavior when shifting a 1 left into
818 the sign bit.
819 * lisp.h (get_random): Change signature to match.
820
821 * lread.c (hash_string): Use size_t, not int, for hash computation.
822 Normally we prefer signed values; but hashing is special, because
823 it's better to use unsigned division on hash table sizes so that
824 the remainder is nonnegative. Also, size_t is the natural width
825 for hashing into memory. The previous code used 'int', which doesn't
826 retain enough info to hash well into very large tables.
827 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
828
829 * dbusbind.c: Don't possibly lose pointer info when converting.
830 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
831 Use XPNTR rather than XHASH, so that the high-order bits of
832 the pointer aren't lost when converting through void *.
833
834 * eval.c (Fautoload): Don't double-shift a pointer.
835
836 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
837
838 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
839
840 * gnutls.c (DEF_GNUTLS_FN):
841 * image.c (DEF_IMGLIB_FN): Make function pointers static.
842
843 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
844
845 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
846 marker. (Bug#8610)
847
848 2011-05-05 Eli Zaretskii <eliz@gnu.org>
849
850 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
851 New version that can reserve upto 2GB of heap space.
852
853 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
854
855 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
856
857 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
858
859 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
860 `gnutls_certificate_set_x509_key_file'.
861
862 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
863
864 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
865 Update dependencies.
866
867 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
868
869 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
870 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
871 Remove unused parameter `fildes'.
872 * process.c (read_process_output, send_process): Don't pass it.
873
874 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
875
876 Fix previous change: the library cache is defined in w32.c.
877 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
878 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
879
880 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
881
882 Implement dynamic loading of GnuTLS on Windows.
883
884 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
885 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
886 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
887 Declare.
888
889 * gnutls.c (Qgnutls_dll): Define.
890 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
891 (gnutls_*): Declare function pointers.
892 (init_gnutls_functions): New function to initialize function pointers.
893 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
894 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
895 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
896 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
897 (emacs_gnutls_write, emacs_gnutls_read)
898 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
899 (Fgnutls_available_p): New function.
900 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
901 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
902 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
903
904 * image.c: Include w32.h.
905 (Vimage_type_cache): Delete.
906 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
907 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
908 (w32_delayed_load): Move to w32.c.
909
910 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
911
912 * w32.c (QCloaded_from, Vlibrary_cache): Define.
913 (w32_delayed_load): Move from image.c. When loading a library, record
914 its filename in the :loaded-from property of the library id.
915 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
916 Initialize and staticpro them.
917 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
918
919 * process.c: Include lisp.h before w32.h, not after.
920 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
921 instead of gnutls_record_check_pending.
922
923 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
924
925 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
926
927 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
928 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
929 as passed in.
930
931 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
932
933 * xterm.c (x_set_frame_alpha): Do not set property on anything
934 else than FRAME_X_OUTER_WINDOW (Bug#8608).
935
936 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
937
938 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
939
940 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
941
942 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
943 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
944 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
945 (gnutls_global_initialized, Qgnutls_bootprop_priority)
946 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
947 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
948 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
949 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
950 (Qgnutls_bootprop_callbacks_verify): Make static.
951
952 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
953
954 * callproc.c: Indentation fixup.
955
956 * sysdep.c (wait_for_termination_1): Make static.
957 (wait_for_termination, interruptible_wait_for_termination):
958 Move after wait_for_termination_1.
959
960 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
961
962 * sysdep.c (interruptible_wait_for_termination): New function
963 which is like wait_for_termination, but allows keyboard
964 interruptions.
965
966 * callproc.c (Fcall_process): Add (:file "file") as an option for
967 the STDOUT buffer.
968 (Fcall_process_region): Ditto.
969
970 2011-04-30 Eli Zaretskii <eliz@gnu.org>
971
972 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
973 rather than `XVECTOR (FOO)->size'.
974
975 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
976 inttypes.h, as a gnulib replacement is used if it not available in
977 system headers.
978
979 2011-04-21 Eli Zaretskii <eliz@gnu.org>
980
981 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
982 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
983 of MOST_POSITIVE_FIXNUM. (Bug#8528)
984
985 * coding.c (coding_alloc_by_realloc): Error out if destination
986 will grow beyond MOST_POSITIVE_FIXNUM.
987 (decode_coding_emacs_mule): Abort if there isn't enough place in
988 charbuf for the composition carryover bytes. Reserve an extra
989 space for up to 2 characters produced in a loop.
990 (decode_coding_iso_2022): Abort if there isn't enough place in
991 charbuf for the composition carryover bytes.
992
993 2011-04-21 Eli Zaretskii <eliz@gnu.org>
994
995 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
996 aborting when %lld or %lll format is passed.
997 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
998 %llo or %llx format is passed. (Bug#8545)
999
1000 * window.c (window_scroll_line_based): Use a marker instead of
1001 simple variables to record original value of point. (Bug#7952)
1002
1003 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1004 produced by %s or %c overflows available buffer space. (Bug#8545)
1005
1006 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1009 (SIZE_MAX): Move defn after all includes, as they might #define it.
1010
1011 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1012
1013 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1014
1015 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1016
1017 * keyboard.c (Qdelayed_warnings_hook): Define.
1018 (command_loop_1): Run `delayed-warnings-hook'
1019 if Vdelayed_warnings_list is non-nil.
1020 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1021 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1022
1023 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1024
1025 * doprnt.c (doprnt): Don't return value smaller than the buffer
1026 size if the message was truncated. (Bug#8545).
1027
1028 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1031 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1032
1033 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1036
1037 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1038
1039 * makefile.w32-in: Update dependencies.
1040
1041 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1042
1043 Improve `doprnt' and its usage. (Bug#8545)
1044 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1045 `format_end'. Remove support for %l as a conversion specifier.
1046 Don't use xrealloc. Improve diagnostics when the %l size modifier
1047 is used. Update the commentary.
1048
1049 * eval.c (verror): Simplify calculation of size_t.
1050
1051 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1052 messages.
1053
1054 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1055
1056 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1057 change.
1058
1059 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1060
1061 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1062 This makes this file independent of the recent pseudovector change.
1063
1064 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1065
1066 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1067
1068 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1069 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1070 Remove unused local.
1071 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1072
1073 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1074 GCC 4.6.0 optimizes based on type-based alias analysis.
1075 For example, if b is of type struct buffer * and v of type struct
1076 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1077 != &v->size, and therefore "v->size = 1; b->size = 2; return
1078 v->size;" must therefore return 1. This assumption is incorrect
1079 for Emacs, since it type-puns struct Lisp_Vector * with many other
1080 types. To fix this problem, this patch adds a new type struct
1081 vectorlike_header that documents the constraints on layout of vectors
1082 and pseudovectors, and helps optimizing compilers not get fooled
1083 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1084 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1085 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1086 the size member.
1087 (XSETPVECTYPE): Rewrite in terms of new macro.
1088 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1089 This is a bit clearer, and further avoids the possibility of
1090 undesirable aliasing.
1091 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1092 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1093 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1094 since Lisp_Subr is a special case (no "next" field).
1095 (ASIZE): Now uses header.size rather than size.
1096 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1097 to avoid the hassle of writing XVECTOR (foo)->header.size.
1098 (struct vectorlike_header): New type.
1099 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1100 object, to help avoid aliasing.
1101 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1102 (SUBRP): Likewise, since Lisp_Subr is a special case.
1103 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1104 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1105 (struct Lisp_Hash_Table): Combine first two members into a single
1106 struct vectorlike_header member. All uses of "size" and "next" members
1107 changed to be "header.size" and "header.next".
1108 * buffer.h (struct buffer): Likewise.
1109 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1110 * frame.h (struct frame): Likewise.
1111 * process.h (struct Lisp_Process): Likewise.
1112 * termhooks.h (struct terminal): Likewise.
1113 * window.c (struct save_window_data, struct saved_window): Likewise.
1114 * window.h (struct window): Likewise.
1115 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1116 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1117 * buffer.c (init_buffer_once): Likewise.
1118 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1119 special case.
1120 * process.c (Fformat_network_address): Use local var for size,
1121 for brevity.
1122
1123 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1124
1125 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1126 * data.c (atof): Remove decl; no longer used or needed.
1127 (digit_to_number): Move to lread.c.
1128 (Fstring_to_number): Use new string_to_number function, to be
1129 consistent with how the Lisp reader treats infinities and NaNs.
1130 Do not assume that floating-point numbers represent EMACS_INT
1131 without losing information; this is not true on most 64-bit hosts.
1132 Avoid double-rounding errors, by insisting on integers when
1133 parsing non-base-10 numbers, as the documentation specifies.
1134 * lisp.h (string_to_number): New decl, replacing ...
1135 (isfloat_string): Remove.
1136 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1137 (read1): Do not accept +. and -. as integers; this
1138 appears to have been a coding error. Similarly, do not accept
1139 strings like +-1e0 as floating point numbers. Do not report
1140 overflow for integer overflows unless the base is not 10 which
1141 means we have no simple and reliable way to continue.
1142 Break out the floating-point parsing into a new
1143 function string_to_number, so that Fstring_to_number parses
1144 floating point numbers consistently with the Lisp reader.
1145 (digit_to_number): Move here from data.c. Make it static inline.
1146 (E_CHAR, EXP_INT): Remove, replacing with ...
1147 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1148 (string_to_number): New function, replacing isfloat_string.
1149 This function checks for valid syntax and produces the resulting
1150 Lisp float number too. Rework it so that string-to-number
1151 no longer mishandles examples like "1.0e+". Use strtoumax,
1152 so that overflow for non-base-10 numbers is reported only when
1153 there's no portable and simple way to convert to floating point.
1154
1155 * textprop.c (set_text_properties_1): Rewrite for clarity,
1156 and to avoid GCC warning about integer overflow.
1157
1158 * intervals.h (struct interval): Use EMACS_INT for members
1159 where EMACS_UINT might cause problems. See
1160 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1161 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1162 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1163 All uses changed.
1164 (offset_intervals): Tell GCC not to worry about length overflow
1165 when negating a negative length.
1166
1167 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1168 (overrun_check_free): Likewise.
1169
1170 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1171 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1172 word size.
1173
1174 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1175 (gnutls_make_error): Rename local to avoid shadowing.
1176 (gnutls_emacs_global_deinit): ifdef out; not used.
1177 (Fgnutls_boot): Use const for pointer to readonly storage.
1178 Comment out unused local. Fix pointer signedness problems.
1179
1180 * lread.c (openp): Don't stuff size_t into an 'int'.
1181 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1182 about possible signed overflow.
1183
1184 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1185 (GDK_KEY_g): Don't define if already defined.
1186 (xg_prepare_tooltip): Avoid pointer signedness problem.
1187 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1188
1189 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1190 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1191
1192 * xfns.c (Fx_window_property): Simplify a bit,
1193 to make a bit faster and to avoid GCC 4.6.0 warning.
1194 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1195
1196 * fns.c (internal_equal): Don't assume size_t fits in int.
1197
1198 * alloc.c (compact_small_strings): Tighten assertion a little.
1199
1200 Replace pEd with more-general pI, and fix some printf arg casts.
1201 * lisp.h (pI): New macro, generalizing old pEd macro to other
1202 conversion specifiers. For example, use "...%"pI"d..." rather
1203 than "...%"pEd"...".
1204 (pEd): Remove. All uses replaced with similar uses of pI.
1205 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1206 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1207 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1208 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1209 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1210 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1211 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1212 64-bit hosts.
1213 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1214 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1215 * print.c (safe_debug_print, print_object): Likewise.
1216 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1217 to int.
1218 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1219 avoiding the 0 flag, which is not portable.
1220 * process.c (Fmake_network_process): Use pI to avoid cast.
1221 * region-cache.c (pp_cache): Likewise.
1222 * xdisp.c (decode_mode_spec): Likewise.
1223 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1224 behavior on 64-bit hosts with printf arg.
1225 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1226 (x_stop_queuing_selection_requests): Likewise.
1227 (x_get_window_property): Don't truncate byte count to an 'int'
1228 when tracing.
1229
1230 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1231 here, since it parses constructs like leading '-' and spaces,
1232 which are not wanted; and it overflows with large numbers.
1233 Instead, simply match F[0-9]+, which is what is wanted anyway.
1234
1235 * alloc.c: Remove unportable assumptions about struct layout.
1236 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1237 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1238 (allocate_vectorlike, make_pure_vector): Use the new macros,
1239 plus offsetof, to remove unportable assumptions about struct layout.
1240 These assumptions hold on all porting targets that I know of, but
1241 they are not guaranteed, they're easy to remove, and removing them
1242 makes further changes easier.
1243
1244 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1245 This doesn't fix a bug but makes the code clearer.
1246 (string_overrun_cookie): Now const. Use initializers that
1247 don't formally overflow signed char, to avoid warnings.
1248 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1249 can cause Emacs to crash when string overrun checking is enabled.
1250 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1251 multiple of sizeof (EMACS_INT); it need not be, if
1252 alignof(EMACS_INT) < sizeof (EMACS_INT).
1253 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1254
1255 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1256
1257 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1258
1259 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1260
1261 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1262 supposed to be handshaking. (Bug#8556)
1263 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1264
1265 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1266
1267 * lisp.h (Qdebug): List symbol.
1268 * eval.c (Qdebug): Restore global linkage.
1269 * keyboard.c (debug-on-event): New variable.
1270 (handle_user_signal): Break into debugger when debug-on-event
1271 matches the current signal symbol.
1272
1273 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1274
1275 * alloc.c (check_sblock, check_string_bytes)
1276 (check_string_free_list): Convert to standard C.
1277
1278 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1279
1280 * w32.c (emacs_gnutls_push): Fix typo.
1281
1282 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1283
1284 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1285 "cast to pointer from integer of different size".
1286
1287 Improve doprnt and its use in verror. (Bug#8545)
1288 * doprnt.c (doprnt): Document the set of format control sequences
1289 supported by the function. Use SAFE_ALLOCA instead of always
1290 using `alloca'.
1291
1292 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1293 is one byte too soon. Don't use xrealloc; instead xfree and
1294 xmalloc anew.
1295
1296 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1297
1298 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1299 callbacks stage.
1300
1301 * gnutls.c: Renamed global_initialized to
1302 gnutls_global_initialized. Added internals for the
1303 :verify-hostname-error, :verify-error, and :verify-flags
1304 parameters of `gnutls-boot' and documented those parameters in the
1305 docstring. Start callback support.
1306 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1307 unless a fatal error occured. Call gnutls_alert_send_appropriate
1308 on error. Return error code.
1309 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1310 (emacs_gnutls_read): Likewise.
1311 (Fgnutls_boot): Return handshake error code.
1312 (emacs_gnutls_handle_error): New function.
1313 (wsaerror_to_errno): Likewise.
1314
1315 * w32.h (emacs_gnutls_pull): Add prototype.
1316 (emacs_gnutls_push): Likewise.
1317
1318 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1319 (emacs_gnutls_push): Likewise.
1320
1321 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1322
1323 * process.c (wait_reading_process_output): Check if GnuTLS
1324 buffered some data internally if no FDs are set for TLS
1325 connections.
1326
1327 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1328 (LIBS): Link to USER_LIBS.
1329 ($(BLD)/gnutls.$(0)): New target.
1330
1331 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1332
1333 * xdisp.c (handle_single_display_spec): Rename the
1334 display_replaced_before_p argument into display_replaced_p, to
1335 make it consistent with the commentary. Fix typos in the
1336 commentary.
1337
1338 * textprop.c (syms_of_textprop): Remove dead code.
1339 (copy_text_properties): Delete obsolete commentary about an
1340 interface that was deleted long ago. Fix typos in the description
1341 of arguments.
1342
1343 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1344 to changes in oldXMenu/XMenu.h from 2011-04-16.
1345 <menu_help_message, prev_menu_help_message>: Constify.
1346 (IT_menu_make_room): menu->help_text is now `const char **';
1347 adjust.
1348
1349 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1350 to changes in oldXMenu/XMenu.h from 2011-04-16.
1351 (struct XMenu): Declare `help_text' `const char **'.
1352
1353 * xfaces.c <Qunspecified>: Make extern again.
1354
1355 * syntax.c: Include sys/types.h before including regex.h, as
1356 required by Posix.
1357
1358 * doc.c (get_doc_string): Improve the format passed to `error'.
1359
1360 * doprnt.c (doprnt): Improve commentary.
1361
1362 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1363
1364 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1365 them with etags.
1366
1367 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1368 changes in globals.h immediately force recompilation.
1369 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1370 $(CURDIR)/s/ms-w32.h.
1371 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1372
1373 * character.c (Fchar_direction): Function deleted.
1374 (syms_of_character): Don't defsubr it.
1375 <char-direction-table>: Deleted.
1376
1377 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1378
1379 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1380 * doprnt.c: Include limits.h.
1381 (SIZE_MAX): New macro.
1382 (doprnt): Return a size_t value. 2nd arg is now size_t.
1383 Many local variables are now size_t instead of int or unsigned.
1384 Improve overflow protection. Support `l' modifier for integer
1385 conversions. Support %l conversion. Don't assume an EMACS_INT
1386 argument for integer conversions and for %c.
1387
1388 * lisp.h (doprnt): Restore prototype.
1389
1390 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1391 $(SRC)/character.h.
1392
1393 * Makefile.in (base_obj): Add back doprnt.o.
1394
1395 * deps.mk (doprnt.o): Add back prerequisites.
1396 (callint.o): Depend on character.h.
1397
1398 * eval.c (internal_lisp_condition_case): Include the handler
1399 representation in the error message.
1400 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1401 when breaking from the loop.
1402
1403 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1404
1405 * callint.c (Fcall_interactively): When displaying error message
1406 about invalid control letter, pass the character's codepoint, not
1407 a pointer to its multibyte form. Improve display of the character
1408 in octal and display also its hex code.
1409
1410 * character.c (char_string): Use %x to display the (unsigned)
1411 codepoint of an invalid character, to avoid displaying a bogus
1412 negative value.
1413
1414 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1415 `error', not SYMBOL_NAME itself.
1416
1417 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1418 character arguments to `error'.
1419
1420 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1421 to `error' in error message about FINAL_CHAR argument. Make sure
1422 FINAL_CHAR is a character, and use %c when it is passed as
1423 argument to `error'.
1424
1425 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1426
1427 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1428
1429 * w32.c: Include <time.h>.
1430 (sys_localtime): New function.
1431
1432 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1433
1434 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1435
1436 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1437
1438 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1439
1440 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1441 zombies (Bug#8467).
1442
1443 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1444
1445 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1446 gl_state.e_property when gl_state.object is Qt.
1447
1448 * insdel.c (make_gap_larger): Remove limitation of buffer size
1449 to <= INT_MAX.
1450
1451 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1452
1453 * xdisp.c (lookup_glyphless_char_display)
1454 (produce_glyphless_glyph): Handle cons cell entry in
1455 glyphless-char-display.
1456 (Vglyphless_char_display): Document it.
1457
1458 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1459 glyphless-char-display.
1460
1461 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1462
1463 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1464
1465 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1466
1467 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1468 definition for no-X builds.
1469
1470 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 Static checks with GCC 4.6.0 and non-default toolkits.
1473
1474 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1475
1476 * process.c (keyboard_bit_set): Define only if SIGIO.
1477 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1478 (send_process): Repair possible setjmp clobbering.
1479
1480 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1481
1482 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1483
1484 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1485
1486 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1487 Define only if needed.
1488
1489 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1490 by pacifying GCC about it. Maybe it's time to retire it?
1491 * xfaces.c (USG, __TIMEVAL__): Likewise.
1492
1493 * dispextern.h (struct redisplay_interface): Rename param
1494 to avoid shadowing.
1495 * termhooks.h (struct terminal): Likewise.
1496 * xterm.c (xembed_send_message): Likewise.
1497
1498 * insdel.c (make_gap_smaller): Define only if
1499 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1500
1501 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1502 it.
1503
1504 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1505 so that we aren't warned about unused symbols.
1506
1507 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1508
1509 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1510
1511 * xfns.c (x_real_positions): Mark locals as initialized.
1512
1513 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1514
1515 * xterm.c: Fix problems found by static analysis with other toolkits.
1516 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1517 (x_dispatch_event): Declare static if USE_GTK, and
1518 define if USE_GTK || USE_X_TOOLKIT.
1519 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1520 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1521 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1522 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1523
1524 * xmenu.c (menu_help_callback): Pointer type fixes.
1525 Use const pointers when pointing at readonly data. Avoid pointer
1526 signedness clashes.
1527 (FALSE): Remove unused macro.
1528 (update_frame_menubar): Remove unused decl.
1529
1530 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1531
1532 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1533 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1534 (single_menu_item): Rename local to avoid shadowing.
1535
1536 * keyboard.c (make_lispy_event): Remove unused local var.
1537
1538 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1539 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1540
1541 * bitmaps: Change bitmaps from unsigned char back to the X11
1542 compatible char. Avoid the old compiler warnings about
1543 out-of-range initializers by using, for example, '\xab' rather
1544 than 0xab.
1545
1546 * xgselect.c (xgselect_initialize): Check vs interface
1547 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1548
1549 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1550
1551 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1552 to read-only memory.
1553
1554 * fns.c (vector): Remove; this old hack is no longer needed.
1555
1556 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1557 Remove unused var.
1558 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1559
1560 * xrdb.c (x_load_resources): Omit unused local.
1561
1562 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1563 (x_window): Rename locals to avoid shadowing.
1564 (USG): Use the kludged USG macro, to pacify gcc.
1565
1566 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1567 (x_term_init): Remove local to avoid shadowing.
1568
1569 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1570
1571 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1572 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1573
1574 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1575
1576 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1577
1578 Fix regex.c, syntax.c and friends for buffers > 2GB.
1579 * syntax.h (struct gl_state_s): Declare character position members
1580 EMACS_INT.
1581
1582 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1583
1584 * textprop.c (verify_interval_modification, interval_of):
1585 Declare arguments EMACS_INT.
1586
1587 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1588 EMACS_INT.
1589
1590 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1591
1592 * indent.c (Fvertical_motion): Local variable it_start is now
1593 EMACS_INT.
1594
1595 * regex.c (re_match, re_match_2, re_match_2_internal)
1596 (bcmp_translate, regcomp, regexec, print_double_string)
1597 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1598 (re_compile_pattern, re_exec): Declare arguments and local
1599 variables `size_t' and `ssize_t' and return values `regoff_t', as
1600 appropriate.
1601 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1602 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1603 <compile_stack_type>: `size' and `avail' are now `size_t'.
1604
1605 * regex.h <regoff_t>: Use ssize_t, not int.
1606 (re_search, re_search_2, re_match, re_match_2): Arguments that
1607 specify buffer/string position and length are now ssize_t and
1608 size_t. Return type is regoff_t.
1609
1610 2011-04-16 Ben Key <bkey76@gmail.com>
1611
1612 * nsfont.m: Fixed bugs in ns_get_family and
1613 ns_descriptor_to_entity that were caused by using free to
1614 deallocate memory blocks that were allocated by xmalloc (via
1615 xstrdup). This caused Emacs to crash when compiled with
1616 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1617 --enable-checking=xmallocoverrun). xfree is now used to
1618 deallocate these memory blocks.
1619
1620 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1623
1624 emacs_write: Accept and return EMACS_INT for sizes.
1625 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1626 et seq.
1627 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1628 Accept and return EMACS_INT.
1629 (emacs_gnutls_write): Return the number of bytes written on
1630 partial writes.
1631 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1632 (emacs_read, emacs_write): Remove check for negative size, as the
1633 Emacs source code has been audited now.
1634 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1635 (emacs_read, emacs_write): Use it.
1636 * process.c (send_process): Adjust to the new signatures of
1637 emacs_write and emacs_gnutls_write. Do not attempt to store
1638 a byte offset into an 'int'; it might overflow.
1639 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1640
1641 * sound.c: Don't assume sizes fit in 'int'.
1642 (struct sound_device.period_size, alsa_period_size):
1643 Return EMACS_INT, not int.
1644 (struct sound_device.write, vox_write, alsa_write):
1645 Accept EMACS_INT, not int.
1646 (wav_play, au_play): Use EMACS_INT to store sizes and to
1647 record read return values.
1648
1649 2011-04-15 Ben Key <bkey76@gmail.com>
1650
1651 * keyboard.c (Qundefined): Don't declare static since it is used
1652 in nsfns.m.
1653 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1654 static since they are used in nsfont.m.
1655
1656 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1657
1658 * process.c (Qprocessp): Don't declare static.
1659 * lisp.h (Qprocessp): Declare again.
1660
1661 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1664
1665 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 Improve C-level modularity by making more things 'static'.
1668
1669 Don't publish debugger-only interfaces to other modules.
1670 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1671 (verify_bytepos, count_markers): Move decls to the only modules
1672 that need them.
1673 * region-cache.h (pp_cache): Likewise.
1674 * window.h (check_all_windows): Likewise.
1675 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1676
1677 * sysdep.c (croak): Now static, if
1678 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1679 * syssignal.h (croak): Declare only if not static.
1680
1681 * alloc.c (refill_memory_reserve): Now static if
1682 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1683 * lisp.h (refill_memory_reserve): Declare only if not static.
1684
1685 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1686 Define only if USE_LUCID.
1687
1688 * xrdb.c (x_customization_string, x_rm_string): Now static.
1689
1690 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1691 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1692
1693 * xdisp.c (draw_row_with_mouse_face): Now static.
1694 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1695
1696 * window.h (check_all_windows): Mark externally visible.
1697
1698 * window.c (window_deletion_count): Now static.
1699
1700 * undo.c: Make symbols static if they're not exported.
1701 (last_undo_buffer, last_boundary_position, pending_boundary):
1702 Now static.
1703
1704 * textprop.c (interval_insert_behind_hooks): Now static.
1705 (interval_insert_in_front_hooks): Likewise.
1706
1707 * term.c: Make symbols static if they're not exported.
1708 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1709 (max_frame_lines, tty_set_terminal_modes):
1710 (tty_reset_terminal_modes, tty_turn_off_highlight):
1711 (get_tty_terminal): Now static.
1712 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1713 * termhooks.h (term_mouse_moveto): Do not declare if
1714 HAVE_WINDOW_SYSTEM.
1715 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1716 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1717
1718 * sysdep.c: Make symbols static if they're not exported.
1719 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1720 Now static.
1721 (sigprocmask_set, full_mask): Remove; unused.
1722 (wait_debugging): Mark as visible.
1723 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1724 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1725
1726 * syntax.c (syntax_temp): Define only if !__GNUC__.
1727
1728 * sound.c (current_sound_device, current_sound): Now static.
1729
1730 * search.c (searchbufs, searchbuf_head): Now static.
1731
1732 * scroll.c (scroll_cost): Remove; unused.
1733 * dispextern.h (scroll_cost): Remove decl.
1734
1735 * region-cache.h (pp_cache): Mark as externally visible.
1736
1737 * process.c: Make symbols static if they're not exported.
1738 (process_tick, update_tick, create_process, chan_process):
1739 (Vprocess_alist, proc_buffered_char, datagram_access):
1740 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1741 (deactivate_process): Mark defn as static, as well as decl.
1742 * lisp.h (create_process): Remove decl.
1743 * process.h (chan_process, Vprocess_alist): Remove decls.
1744
1745 * print.c: Make symbols static if they're not exported.
1746 (print_depth, new_backquote_output, being_printed, print_buffer):
1747 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1748 (print_interval, print_number_index, initial_stderr_stream):
1749 Now static.
1750 * lisp.h (Fprinc): Remove decl.
1751 (debug_output_compilation_hack): Mark as externally visible.
1752
1753 * sysdep.c (croak): Move decl from here to syssignal.h.
1754 * syssignal.h (croak): Put it here, so the API can be checked when
1755 'croak' is called from dissociate_if_controlling_tty.
1756
1757 * minibuf.c: Make symbols static if they're not exported.
1758 (minibuf_save_list, choose_minibuf_frame): Now static.
1759 * lisp.h (choose_minibuf_frame): Remove decl.
1760
1761 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1762
1763 * lread.c: Make symbols static if they're not exported.
1764 (read_objects, initial_obarray, oblookup_last_bucket_number):
1765 Now static.
1766 (make_symbol): Remove; unused.
1767 * lisp.h (initial_obarray, make_symbol): Remove decls.
1768
1769 * keyboard.c: Make symbols static if they're not exported.
1770 (single_kboard, recent_keys_index, total_keys, recent_keys):
1771 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1772 (this_single_command_key_start, echoing, last_auto_save):
1773 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1774 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1775 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1776 (Vlispy_mouse_stem, double_click_count):
1777 Now static.
1778 (force_auto_save_soon): Define only if SIGDANGER.
1779 (ignore_mouse_drag_p): Now static if
1780 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1781 (print_help): Remove; unused.
1782 (stop_character, last_timer_event): Mark as externally visible.
1783 * keyboard.h (ignore_mouse_drag_p): Declare only if
1784 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1785 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1786 * lisp.h (echoing): Remove decl.
1787 (force_auto_save_soon): Declare only if SIGDANGER.
1788 * xdisp.c (redisplay_window): Simplify code, to make it more
1789 obvious that ignore_mouse_drag_p is not accessed if !defined
1790 USE_GTK && !defined HAVE_NS.
1791
1792 * intervals.c: Make symbols static if they're not exported.
1793 (merge_properties_sticky, merge_interval_right, delete_interval):
1794 Now static.
1795 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1796
1797 * insdel.c: Make symbols static if they're not exported.
1798 However, leave prepare_to_modify_buffer alone. It's never
1799 called from outside this function, but that appears to be a bug.
1800 (combine_after_change_list, combine_after_change_buffer):
1801 (adjust_after_replace, signal_before_change): Now static.
1802 (adjust_after_replace_noundo): Remove; unused.
1803 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1804 (signal_before_change): Remove decls.
1805
1806 * indent.c (val_compute_motion, val_vmotion): Now static.
1807
1808 * image.c: Make symbols static if they're not exported.
1809 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1810 if USE_GTK.
1811 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1812 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1813
1814 * fringe.c (standard_bitmaps): Now static.
1815 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1816
1817 * frame.c: Make symbols static if they're not exported.
1818 (x_report_frame_params, make_terminal_frame): Now static.
1819 (get_frame_param): Now static, unless HAVE_NS.
1820 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1821 (x_get_resource_string): Remove; not used.
1822 * frame.h (make_terminal_frame, x_report_frame_params):
1823 (x_get_resource_string); Remove decls.
1824 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1825 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1826
1827 * font.c, fontset.c: Make symbols static if they're not exported.
1828 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1829 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1830 * font.c (font_close_object): Now static.
1831 * font.h (font_close_object): Remove.
1832 * fontset.c (FONTSET_OBJLIST): Remove.
1833 (free_realized_fontset) #if-0 the body, which does nothing.
1834 (face_suitable_for_char_p): #if-0, as it's never called.
1835 * fontset.h (face_suitable_for_char_p): Remove decl.
1836 * xfaces.c (face_at_string_position):
1837 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1838 since 0 is always ASCII.
1839
1840 * fns.c (weak_hash_tables): Now static.
1841
1842 * fileio.c: Make symbols static if they're not exported.
1843 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1844 (Vwrite_region_annotation_buffers): Now static.
1845
1846 * eval.c: Make symbols static if they're not exported.
1847 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1848 * lisp.h (backtrace_list): Remove decl.
1849
1850 * emacs.c: Make symbols static if they're not exported.
1851 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1852 (fatal_error_code, fatal_error_signal_hook, standard_args):
1853 Now static.
1854 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1855 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1856 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1857 * lisp.h (fatal_error_signal_hook): Remove decl.
1858 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1859
1860 * editfns.c: Move a (normally-unused) function to its only use.
1861 * editfns.c, lisp.h (get_operating_system_release): Remove.
1862 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1863 worth the hassle of breaking this out.
1864
1865 * xterm.c: Make symbols static if they're not exported.
1866 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1867 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1868 (x_destroy_window, x_delete_display):
1869 Now static.
1870 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1871 (x_mouse_leave): Remove; unused.
1872 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1873 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1874 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1875 Remove decls.
1876 (x_mouse_leave): Declare only if WINDOWSNT.
1877 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1878 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1879 USE_X_TOOLKIT.
1880
1881 * ftxfont.c: Make symbols static if they're not exported.
1882 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1883 HAVE_FREETYPE.
1884 * font.h (ftxfont_driver): Likewise.
1885
1886 * xfns.c: Make symbols static if they're not exported.
1887 (x_last_font_name, x_display_info_for_name):
1888 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1889 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1890 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1891 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1892 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1893 (last_show_tip_args): Now static.
1894 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1895 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1896 (x_screen_planes): Remove; unused.
1897 * dispextern.h (x_screen_planes): Remove decl.
1898
1899 * dispnew.c: Make symbols static if they're not exported.
1900 * dispextern.h (redraw_garbaged_frames, scrolling):
1901 (increment_row_positions): Remove.
1902 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1903 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1904 Now static.
1905 (redraw_garbaged_frames): Remove; unused.
1906
1907 * xfaces.c: Make symbols static if they're not exported.
1908 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1909 Remove decls.
1910 * xterm.h (defined_color): Remove decls.
1911 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1912 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1913 (menu_face_changed_default, defined_color, free_realized_face):
1914 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1915 (ascii_face_of_lisp_face): Remove; unused.
1916
1917 * xdisp.c: Make symbols static if they're not exported.
1918 * dispextern.h (scratch_glyph_row, window_box_edges):
1919 (glyph_to_pixel_coords, set_cursor_from_row):
1920 (get_next_display_element, set_iterator_to_next):
1921 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1922 (show_mouse_face): Remove decls
1923 * frame.h (message_buf_print): Likewise.
1924 * lisp.h (pop_message, set_message, check_point_in_composition):
1925 Likewise.
1926 * xterm.h (set_vertical_scroll_bar): Likewise.
1927 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1928 (message_buf_print, scratch_glyph_row, displayed_buffer):
1929 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1930 (get_next_display_element, show_mouse_face, window_box_edges):
1931 (frame_to_window_pixel_xy, check_point_in_composition):
1932 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1933 (glyph_to_pixel_coords): Remove; unused.
1934
1935 * dired.c (file_name_completion): Now static.
1936
1937 * dbusbind.c (xd_in_read_queued_messages): Now static.
1938
1939 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1940 * data.c (circular_list_error): Remove.
1941
1942 * commands.h (last_point_position, last_point_position_buffer):
1943 (last_point_position_window): Remove decls.
1944 * keyboard.c: Make these variables static.
1945
1946 * coding.h (coding, code_convert_region, encode_coding_gap):
1947 Remove decls.
1948 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1949 (iso_code_class, detect_coding, code_convert_region): Now static.
1950 (encode_coding_gap): Remove; unused.
1951
1952 * chartab.c (chartab_chars, chartab_bits): Now static.
1953
1954 * charset.h (charset_iso_8859_1): Remove decl.
1955 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1956 Now static.
1957
1958 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1959 * ccl.c (Vccl_program_table): Now static.
1960 (check_ccl_update): Remove; unused.
1961
1962 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1963 * category.h: ... from here.
1964 * category.c (check_category_table, set_category_set): Now static.
1965
1966 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1967 * lisp.h: Remove these decls.
1968
1969 * buffer.c (buffer_count): Remove unused var.
1970
1971 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1972 so that it's not optimized away.
1973 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1974 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1975 exported only to the debugger.
1976
1977 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1978 * atimer.h (run_all_atimers): Remove; not exported.
1979
1980 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1981 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1982 was inaccessible from Lisp.
1983 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1984 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1985
1986 alloc.c: Import and export fewer symbols, and remove unused items.
1987 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1988 is defined.
1989 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1990 it's not optimized away by whole-program optimization.
1991 (message_enable_multibyte, free_misc): Remove.
1992 (catchlist, handlerlist, mark_backtrace):
1993 Declare only if BYTE_MARK_STACK.
1994 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1995 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1996 (message_enable_multibyte): Remove decl.
1997 (free_misc, interval_free_list, float_block, float_block_index):
1998 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1999 (cons_free_list, last_marked_index):
2000 Now static.
2001 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2002 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2003 (mark_backtrace): Define only if BYTE_MARK_STACK.
2004 * xdisp.c (message_enable_multibyte): Now static.
2005
2006 Declare Lisp_Object Q* variables to be 'static' if not exported.
2007 This makes it easier for human readers (and static analyzers)
2008 to see whether these variables are used from other modules.
2009 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2010 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2011 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2012 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2013 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2014 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2015 * xmenu.c, xselect.c:
2016 Declare Q* vars static if they are not used in other modules.
2017 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2018 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2019 Remove decls of unexported vars.
2020 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2021
2022 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2023
2024 Make Emacs functions such as Fatom 'static' by default.
2025 This makes it easier for human readers (and static analyzers)
2026 to see whether these functions can be called from other modules.
2027 DEFUN now defines a static function. To make the function external
2028 so that it can be used in other C modules, use the new macro DEFUE.
2029 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2030 (Finit_image_library):
2031 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2032 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2033 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2034 Remove decls, since these functions are now static.
2035 (Funintern, Fget_internal_run_time): New decls, since these functions
2036 were already external.
2037
2038 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2039 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2040 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2041 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2042 * keyboard.c, keymap.c, lread.c:
2043 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2044 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2045 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2046 Mark functions with DEFUE instead of DEFUN,
2047 if they are used in other modules.
2048 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2049 decls for now-static functions.
2050 * buffer.h (Fdelete_overlay): Remove decl.
2051 * callproc.c (Fgetenv_internal): Mark as internal.
2052 * composite.c (Fremove_list_of_text_properties): Remove decl.
2053 (Fcomposition_get_gstring): New forward static decl.
2054 * composite.h (Fcomposite_get_gstring): Remove decl.
2055 * dired.c (Ffile_attributes): New forward static decl.
2056 * doc.c (Fdocumntation_property): New forward static decl.
2057 * eval.c (Ffetch_bytecode): New forward static decl.
2058 (Funintern): Remove extern decl; now in .h file where it belongs.
2059 * fileio.c (Fmake_symbolic_link): New forward static decl.
2060 * image.c (Finit_image_library): New forward static decl.
2061 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2062 * intervals.h (Fprevious_property_change):
2063 (Fremove_list_of_text_properties): Remove decls.
2064 * keyboard.c (Fthis_command_keys): Remove decl.
2065 (Fcommand_execute): New forward static decl.
2066 * keymap.c (Flookup_key): New forward static decl.
2067 (Fcopy_keymap): Now static.
2068 * keymap.h (Flookup_key): Remove decl.
2069 * process.c (Fget_process): New forward static decl.
2070 (Fprocess_datagram_address): Mark as internal.
2071 * syntax.c (Fsyntax_table_p): New forward static decl.
2072 (skip_chars): Remove duplicate decl.
2073 * textprop.c (Fprevious_property_change): New forward static decl.
2074 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2075 Now internal.
2076 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2077 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2078
2079 * editfns.c (Fformat): Remove unreachable code.
2080
2081 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2082
2083 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2084 change. (Bug#8496)
2085
2086 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2087
2088 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2089 when at ZV. (Bug#8487)
2090
2091 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2092
2093 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2094 (Bug#8437)
2095 * keyboard.c (parse_tool_bar_item): Likewise.
2096 * sound.c (sound_cleanup, alsa_close): Likewise.
2097 * termcap.c (tgetent): Likewise.
2098 * xfns.c (x_default_font_parameter): Likewise.
2099 * xsettings.c (read_and_apply_settings): Likewise.
2100
2101 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2102 (overrun_check_free): Protoize.
2103
2104 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2107 since callers should never pass a negative size.
2108 Change the signature to match that of plain 'read' and 'write'; see
2109 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2110 * lisp.h: Update prototypes of emacs_write and emacs_read.
2111
2112 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2113
2114 * xdisp.c (redisplay_window): Don't try to determine the character
2115 position of the scroll margin if the window start point w->startp
2116 is outside the buffer's accessible region. (Bug#8468)
2117
2118 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2119
2120 Fix write-region and its subroutines for buffers > 2GB.
2121 * fileio.c (a_write, e_write): Modify declaration of arguments and
2122 local variables to support buffers larger than 2GB.
2123 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2124
2125 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2126 argument, local variables, and return value.
2127
2128 * lisp.h: Update prototypes of emacs_write and emacs_read.
2129
2130 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2131
2132 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2133
2134 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2135
2136 Fix more problems found by GCC 4.6.0's static checks.
2137
2138 * xdisp.c (vmessage): Use a better test for character truncation.
2139
2140 * charset.c (load_charset_map): <, not <=, for optimization,
2141 and to avoid potential problems with integer overflow.
2142 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2143 * casetab.c (set_identity, shuffle): Likewise.
2144 * editfns.c (Fformat): Likewise.
2145 * syntax.c (skip_chars): Likewise.
2146
2147 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2148 This also lets GCC 4.6.0 generate slightly better loop code.
2149
2150 * callint.c (Fcall_interactively): <, not <=, for optimization.
2151 (Fcall_interactively): Count the number of arguments produced,
2152 not the number of arguments given. This is simpler and lets GCC
2153 4.6.0 generate slightly better code.
2154
2155 * ftfont.c: Distingish more carefully between FcChar8 and char.
2156 The previous code passed unsigned char * to a functions like
2157 strlen and xstrcasecmp that expect char *, which does not
2158 conform to the C standard.
2159 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2160 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2161 char * when the C standard requires it.
2162
2163 * keyboard.c (read_char): Remove unused var.
2164
2165 * eval.c: Port to Windows vsnprintf (Bug#8435).
2166 Include <limits.h>.
2167 (SIZE_MAX): Define if the headers do not.
2168 (verror): Do not give up if vsnprintf returns a negative count.
2169 Instead, grow the buffer. This ports to Windows vsnprintf, which
2170 does not conform to C99. Problem reported by Eli Zaretskii.
2171 Also, simplify the allocation scheme, by avoiding the need for
2172 calling realloc, and removing the ALLOCATED variable.
2173
2174 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2175
2176 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2177 But keep the doprint source code for now, as we might revamp it
2178 and use it again (Bug#8435).
2179 * lisp.h (doprnt): Remove.
2180 * Makefile.in (base_obj): Remove doprnt.o.
2181 * deps.mk (doprnt.o): Remove.
2182
2183 error: Print 32- and 64-bit integers portably (Bug#8435).
2184 Without this change, on typical 64-bit hosts error ("...%d...", N)
2185 was used to print both 32- and 64-bit integers N, which relied on
2186 undefined behavior.
2187 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2188 New macro.
2189 * lisp.h (error, verror): Mark as printf-like functions.
2190 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2191 Report overflow in size calculations when allocating printf buffer.
2192 Do not truncate output string at its first null byte.
2193 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2194 Truncate the output at a character boundary, since vsnprintf does not
2195 do that.
2196 * charset.c (check_iso_charset_parameter): Convert internal
2197 character to string before calling 'error', since %c now has the
2198 printf meaning.
2199 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2200 overflow when computing char to be passed to 'error'. Do not
2201 pass Lisp_Object to 'error'; pass the integer instead.
2202 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2203 formatted with plain %d.
2204
2205 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2206
2207 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2208
2209 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2210
2211 * xterm.c (x_catch_errors): Remove duplicate declaration.
2212
2213 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2214
2215 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2216
2217 2011-04-10 Jim Meyering <meyering@redhat.com>
2218
2219 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2220 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2221 return ssize_t not "int", and use size_t as the buffer length.
2222 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2223 * gnutls.h: Update declarations.
2224 * process.c (read_process_output): Use ssize_t, to match.
2225 (send_process): Likewise.
2226
2227 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2228
2229 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2230
2231 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2232
2233 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2234 Use unsigned char, to match FcChar8 type definition.
2235
2236 * xterm.c (handle_one_xevent):
2237 * xmenu.c (create_and_show_popup_menu):
2238 * xselect.c (x_decline_selection_request)
2239 (x_reply_selection_request): Avoid type-punned deref of X events.
2240
2241 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2242
2243 Fix some uses of `int' instead of EMACS_INT.
2244 * search.c (string_match_1, fast_string_match)
2245 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2246 (scan_buffer, find_next_newline_no_quit)
2247 (find_before_next_newline, search_command, Freplace_match)
2248 (Fmatch_data): Make some `int' variables be EMACS_INT.
2249
2250 * xdisp.c (display_count_lines): 3rd argument and return value now
2251 EMACS_INT. All callers changed.
2252 (pint2hrstr): Last argument is now EMACS_INT.
2253
2254 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2255 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2256 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2257 (decode_coding_utf_16, decode_coding_emacs_mule)
2258 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2259 (decode_coding_ccl, decode_coding_charset)
2260 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2261 (decode_coding_iso_2022, decode_coding_emacs_mule)
2262 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2263 <char_offset, last_offset>: Declare EMACS_INT.
2264 (encode_coding_utf_8, encode_coding_utf_16)
2265 (encode_coding_emacs_mule, encode_invocation_designation)
2266 (encode_designation_at_bol, encode_coding_iso_2022)
2267 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2268 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2269 Declare EMACS_INT.
2270 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2271 (encode_invocation_designation): Last argument P_NCHARS is now
2272 EMACS_INT.
2273 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2274 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2275
2276 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2277 All users changed.
2278
2279 * ccl.c (Fccl_execute_on_string): Declare some variables
2280 EMACS_INT.
2281
2282 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2283
2284 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2285
2286 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2287
2288 * process.c (Fformat_network_address): Doc fix.
2289
2290 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2291
2292 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2293
2294 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2295
2296 * keyboard.c (read_char): Call Lisp function help-form-show,
2297 instead of using internal_with_output_to_temp_buffer.
2298 (Qhelp_form_show): New var.
2299 (syms_of_keyboard): Use DEFSYM macro.
2300
2301 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2302
2303 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2304
2305 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2306
2307 * process.c (Flist_processes): Remove to Lisp.
2308 (list_processes_1): Delete.
2309
2310 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2311
2312 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2313
2314 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2315
2316 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 Fix more problems found by GCC 4.6.0's static checks.
2319
2320 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2321
2322 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2323
2324 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2325
2326 * xdisp.c (vmessage): Mark as a printf-like function.
2327
2328 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2329
2330 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2331
2332 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2333 printf-like functions.
2334 (tiff_load): Add casts to remove these marks before passing them
2335 to system-supplied API.
2336
2337 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2338
2339 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2340 This avoids several warnings with gcc -Wstrict-overflow.
2341 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2342 directly, rather than having caller test rule sign. This avoids
2343 some unnecessary tests.
2344 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2345 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2346 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2347
2348 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2349 (xfont_open): Avoid unnecessary tests.
2350
2351 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2352
2353 * composite.h, composite.c (composition_gstring_put_cache):
2354 Use EMACS_INT, not int, for length.
2355
2356 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2357 breaking out part of COMPOSITION_DECODE_RULE.
2358 (COMPOSITION_DECODE_RULE): Use it.
2359 * composite.c (get_composition_id): Remove unused local vars,
2360 by using the new macro.
2361
2362 * textprop.c (set_text_properties_1): Change while to do-while,
2363 since the condition is always true at first.
2364
2365 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2366 (interval_deletion_adjustment): Return unsigned value.
2367 All uses changed.
2368
2369 * process.c (list_processes_1, create_pty, read_process_output):
2370 (exec_sentinel): Remove vars that were set but not used.
2371 (create_pty): Remove unnecessary "volatile"s.
2372 (Fnetwork_interface_info): Avoid possibility of int overflow.
2373 (read_process_output): Do adaptive read buffering even if carryover.
2374 (read_process_output): Simplify nbytes computation if buffered.
2375
2376 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2377
2378 * syntax.c (scan_words): Remove var that was set but not used.
2379 (update_syntax_table): Use unsigned instead of int.
2380
2381 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2382 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2383 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2384
2385 * print.c (print_error_message): Avoid int overflow.
2386
2387 * font.c (font_list_entities): Redo for clarity,
2388 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2389
2390 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2391 (font_score): Avoid potential overflow in diff calculation.
2392
2393 * fns.c (substring_both): Remove var that is set but not used.
2394 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2395
2396 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2397
2398 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2399 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2400 can always succeed if overflow has undefined behavior.
2401
2402 * search.c (boyer_moore, wordify): Remove vars set but not used.
2403 (wordify): Omit three unnecessary tests.
2404
2405 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2406 All callers changed. This avoids the need for an unused var.
2407
2408 * casefiddle.c (casify_region): Remove var that is set but not used.
2409
2410 * dired.c (file_name_completion): Remove var that is set but not used.
2411
2412 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2413
2414 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2415 (Finsert_file_contents): Remove unnecessary code checking fd.
2416
2417 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2418 Check for integer overflow on size calculations.
2419
2420 * buffer.c (Fprevious_overlay_change): Remove var that is set
2421 but not used.
2422
2423 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2424 Remove vars that are set but not used.
2425 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2426 (timer_check_2): Mark vars as initialized.
2427
2428 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2429
2430 * image.c (lookup_image): Remove var that is set but not used.
2431 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2432
2433 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2434 that are set but not used.
2435
2436 * xfns.c (make_invisible_cursor): Don't return garbage
2437 if XCreateBitmapFromData fails (Bug#8410).
2438
2439 * xselect.c (x_get_local_selection, x_handle_property_notify):
2440 Remove vars that are set but not used.
2441
2442 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2443 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2444
2445 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2446 Remove var that is set but not used.
2447 (scroll_bar_windows_size): Now size_t, not int.
2448 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2449 Check for overflow.
2450
2451 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2452 (map_tty_color) [!defined MSDOS]: Likewise.
2453
2454 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2455
2456 * coding.c: Remove vars that are set but not used.
2457 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2458 All callers changed.
2459 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2460 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2461 (decode_coding_charset): Remove vars that are set but not used.
2462
2463 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2464 that is set but not used.
2465
2466 * print.c (print_object): Remove var that is set but not used.
2467
2468 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2469 The gnulib version avoids calling malloc in the usual case,
2470 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2471 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2472 * filelock.c (current_lock_owner): Likewise.
2473 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2474 * sysdep.c: Include allocator.h, careadlinkat.h.
2475 (emacs_no_realloc_allocator): New static constant.
2476 (emacs_readlink): New function.
2477 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2478 ../lib/careadlinkat.h.
2479
2480 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2481
2482 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2483 first non-nil return value).
2484
2485 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2486
2487 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2488 if not defined (Bug#8403).
2489
2490 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2491
2492 * xdisp.c (display_count_lines): Remove parameter `start',
2493 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2494 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2495 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2496 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2497 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2498 and thereabouts. All callers changed.
2499 (get_per_char_metric): Remove parameter `f', unused since
2500 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2501
2502 2011-04-02 Jim Meyering <meyering@redhat.com>
2503
2504 do not dereference NULL upon failed strdup
2505 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2506 (ns_get_family): Likewise.
2507
2508 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2509
2510 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2511
2512 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2513
2514 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2515 later (Bug#8403).
2516
2517 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2518
2519 Add lexical binding.
2520
2521 * window.c (Ftemp_output_buffer_show): New fun.
2522 (Fsave_window_excursion):
2523 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2524
2525 * lread.c (lisp_file_lexically_bound_p): New function.
2526 (Fload): Bind Qlexical_binding.
2527 (readevalloop): Remove `evalfun' arg.
2528 Bind Qinternal_interpreter_environment.
2529 (Feval_buffer): Bind Qlexical_binding.
2530 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2531 Mark as dynamic.
2532 (syms_of_lread): Declare `lexical-binding'.
2533
2534 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2535
2536 * keyboard.c (eval_dyn): New fun.
2537 (menu_item_eval_property): Use it.
2538
2539 * image.c (parse_image_spec): Use Ffunctionp.
2540
2541 * fns.c (concat, mapcar1): Accept byte-code-functions.
2542
2543 * eval.c (Fsetq): Handle lexical vars.
2544 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2545 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2546 (FletX, Flet): Obey lexical binding.
2547 (Fcommandp): Handle closures.
2548 (Feval): New `lexical' arg.
2549 (eval_sub): New function extracted from Feval. Use it almost
2550 everywhere where Feval was used. Look up vars in lexical env.
2551 Handle closures.
2552 (Ffunctionp): Move from subr.el.
2553 (Ffuncall): Handle closures.
2554 (apply_lambda): Remove `eval_flags'.
2555 (funcall_lambda): Handle closures and new byte-code-functions.
2556 (Fspecial_variable_p): New function.
2557 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2558 but without exporting it to Lisp.
2559
2560 * doc.c (Fdocumentation, store_function_docstring):
2561 * data.c (Finteractive_form): Handle closures.
2562
2563 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2564 interactive spec.
2565
2566 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2567 New byte-codes.
2568 (exec_byte_code): New function extracted from Fbyte_code to handle new
2569 calling convention for byte-code-functions. Add new byte-codes.
2570
2571 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2572
2573 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2574
2575 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2576
2577 * xdisp.c (redisplay_internal): Fix prototype.
2578
2579 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2580
2581 * xdisp.c (SCROLL_LIMIT): New macro.
2582 (try_scrolling): Use it when setting scroll_limit.
2583 Limit scrolling to 100 screen lines.
2584 (redisplay_window): Even when falling back on "recentering",
2585 position point in the window according to scroll-conservatively,
2586 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2587
2588 (try_scrolling): When point is above the window, allow searching
2589 as far as scroll_max, or one screenful, to compute vertical
2590 distance from PT to the scroll margin position. This prevents
2591 try_scrolling from unnecessarily failing when
2592 scroll-conservatively is set to a value slightly larger than the
2593 window height. Clean up the case of PT below the margin at bottom
2594 of window: scroll_max can no longer be INT_MAX. When aggressive
2595 scrolling is in use, don't let point enter the opposite scroll
2596 margin as result of the scroll.
2597 (syms_of_xdisp) <scroll-conservatively>: Document the
2598 threshold of 100 lines for never-recentering scrolling.
2599
2600 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2601
2602 * dispextern.h (move_it_by_lines):
2603 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2604 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2605 (message_log_check_duplicate): Remove parameters `prev_bol' and
2606 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2607 (redisplay_internal): Remove parameter `preserve_echo_area',
2608 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2609
2610 * indent.c (Fvertical_motion):
2611 * window.c (window_scroll_pixel_based, Frecenter):
2612 Don't pass `need_y_p' to `move_it_by_lines'.
2613
2614 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2615
2616 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2617 steal a few bits to be more compact.
2618 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2619 Remove unneeded casts.
2620
2621 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2622
2623 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2624
2625 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2626 binding" message (bug#7967).
2627
2628 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 Fix more problems found by GCC 4.6.0's static checks.
2631
2632 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2633 Remove unused local var.
2634
2635 * editfns.c (Fmessage_box): Remove unused local var.
2636
2637 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2638 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2639 Omit unused local vars.
2640 * window.c (shrink_windows): Omit unused local var.
2641 * menu.c (digest_single_submenu): Omit unused local var.
2642 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2643 Omit unused local var.
2644
2645 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2646 Don't assume string length fits in int.
2647 (keyremap_step, read_key_sequence): Use size_t for sizes.
2648 (read_key_sequence): Don't check last_real_key_start redundantly.
2649
2650 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2651 instead of alloca (Bug#8344).
2652
2653 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2654 (Fbacktrace_frame): Don't assume nframes fits in int.
2655
2656 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2657
2658 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2659 concerns.
2660
2661 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2662
2663 * cm.c (calccost): Turn while-do into do-while, for clarity.
2664
2665 * keyboard.c (syms_of_keyboard): Use the same style as later
2666 in this function when indexing through an array. This also
2667 works around GCC bug 48267.
2668
2669 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2670
2671 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2672
2673 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2674 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2675
2676 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2677 This avoids undefined behavior on integer overflow, and is a bit
2678 more convenient anyway since it is compared to a size_t variable.
2679
2680 Variadic C functions now count arguments with size_t, not int.
2681 This avoids an unnecessary limitation on 64-bit machines, which
2682 caused (substring ...) to crash on large vectors (Bug#8344).
2683 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2684 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2685 All variadic functions and their callers changed accordingly.
2686 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2687 * data.c (arith_driver, float_arith_driver): Likewise.
2688 * editfns.c (general_insert_function): Likewise.
2689 * eval.c (struct backtrace.nargs, interactive_p)
2690 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2691 (funcall_lambda, mark_backtrace): Likewise.
2692 * fns.c (concat): Likewise.
2693 * frame.c (x_set_frame_parameters): Likewise.
2694 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2695 0 if not found, not -1. All callers changed.
2696
2697 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2698 (stack_copy_size): Now size_t, not int.
2699 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2700
2701 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2702
2703 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2704 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2705 All callers changed.
2706
2707 * lisp.h (multibyte_char_to_unibyte):
2708 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2709 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2710 * character.h (CHAR_TO_BYTE8):
2711 * cmds.c (internal_self_insert):
2712 * editfns.c (general_insert_function):
2713 * keymap.c (push_key_description):
2714 * search.c (Freplace_match):
2715 * xdisp.c (message_dolog, set_message_1): All callers changed.
2716
2717 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2718
2719 * keyboard.c (safe_run_hook_funcall): New function.
2720 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2721 don't set the hook to nil, but remove the offending function instead.
2722 (Qcommand_hook_internal): Remove, unused.
2723 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2724 Vcommand_hook_internal.
2725
2726 * eval.c (enum run_hooks_condition): Remove.
2727 (funcall_nil, funcall_not): New functions.
2728 (run_hook_with_args): Call each function through a `funcall' argument.
2729 Remove `cond' argument, now redundant.
2730 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2731 (Frun_hook_with_args_until_failure): Adjust accordingly.
2732 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2733
2734 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2735
2736 * dispextern.h (string_buffer_position): Remove declaration.
2737
2738 * print.c (strout): Remove parameter `multibyte', unused since
2739 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2740
2741 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2742 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2743 All callers changed.
2744
2745 * w32.c (_wsa_errlist): Use braces for struct initializers.
2746
2747 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2748 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2749 All callers changed.
2750 (string_buffer_position): Likewise. Also, make static (it's never
2751 used outside xdisp.c).
2752 (cursor_row_p): Remove parameter `w', unused since
2753 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2754 (decode_mode_spec): Remove parameter `precision', introduced during
2755 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2756 All callers changed.
2757
2758 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2759
2760 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2761
2762 2011-03-27 Anders Lindgren <andlind@gmail.com>
2763
2764 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2765 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2766 (ns_update_auto_hide_menu_bar): New functions.
2767 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2768 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2769 ns_constrain_all_frames.
2770 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2771 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2772
2773 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2774
2775 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2776
2777 2011-03-27 Glenn Morris <rgm@gnu.org>
2778
2779 * syssignal.h: Replace RETSIGTYPE with void.
2780 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2781 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2782 Replace SIGTYPE with void everywhere.
2783 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2784 * s/template.h (SIGTYPE): Remove commented out definition.
2785
2786 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2787
2788 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2789 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2790
2791 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2792
2793 * w32.c (read_unc_volume): Use parameter `henum', instead of
2794 global variable `wget_enum_handle'.
2795
2796 * keymap.c (describe_vector): Remove parameters `indices' and
2797 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2798 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2799
2800 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2801
2802 * keyboard.c (timer_check): Remove parameter `do_it_now',
2803 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2804 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2805 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2806
2807 * keyboard.c (read_char):
2808 * w32menu.c (w32_menu_display_help):
2809 * xmenu.c (show_help_event, menu_help_callback):
2810 Adjust calls to `show_help_echo'.
2811
2812 * gtkutil.c (xg_maybe_add_timer):
2813 * keyboard.c (readable_events):
2814 * process.c (wait_reading_process_output):
2815 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2816
2817 * insdel.c (adjust_markers_gap_motion):
2818 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2819 (gap_left, gap_right): Don't call it.
2820
2821 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2822
2823 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2824 incurred during fontification.
2825
2826 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2827
2828 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2829 (DEFVAR_PER_BUFFER): Don't pass it.
2830
2831 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2832 (scrolling_window): Don't pass it.
2833
2834 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2835
2836 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2837
2838 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2839 and `suffix'.
2840 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2841 of variables specific to SELinux and computation of `encoded_absname'.
2842
2843 * image.c (XPutPixel): Remove unused variable `height'.
2844
2845 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2846
2847 * unexw32.c (get_section_info): Remove unused variable `section'.
2848
2849 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2850 (system_process_attributes): Remove unused variable `sess'.
2851 (sys_read): Remove unused variable `err'.
2852
2853 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2854 (w32_wnd_proc): Remove unused variable `isdead'.
2855 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2856 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2857 (x_create_tip_frame): Remove unused variable `tem'.
2858
2859 * w32inevt.c (w32_console_read_socket):
2860 Remove unused variable `no_events'.
2861
2862 * w32term.c (x_draw_composite_glyph_string_foreground):
2863 Remove unused variable `width'.
2864
2865 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2866
2867 * w32term.c (x_set_glyph_string_clipping):
2868 Don't pass uninitialized region to CombineRgn.
2869
2870 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2871
2872 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2873 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2874 (Fx_close_connection): Remove unused variable `i'.
2875
2876 * w32font.c (w32font_draw): Return number of glyphs.
2877 (w32font_open_internal): Remove unused variable `i'.
2878 (w32font_driver): Add missing initializer.
2879
2880 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2881 (fill_in_menu): Remove unused variable `items_added'.
2882
2883 * w32term.c (last_mouse_press_frame): Remove static global variable.
2884 (w32_clip_to_row): Remove unused variable `f'.
2885 (x_delete_terminal): Remove unused variable `i'.
2886
2887 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2888 (NOTHING): Remove unused static global variable.
2889 (uniscribe_check_otf): Remove unused variable `table'.
2890 (uniscribe_font_driver): Add missing initializers.
2891
2892 2011-03-23 Julien Danjou <julien@danjou.info>
2893
2894 * term.c (Fsuspend_tty, Fresume_tty):
2895 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2896 * window.c (temp_output_buffer_show):
2897 * insdel.c (signal_before_change):
2898 * frame.c (Fhandle_switch_frame):
2899 * fileio.c (Fdo_auto_save):
2900 * emacs.c (Fkill_emacs):
2901 * editfns.c (save_excursion_restore):
2902 * cmds.c (internal_self_insert):
2903 * callint.c (Fcall_interactively):
2904 * buffer.c (Fkill_all_local_variables):
2905 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2906 Use Frun_hooks.
2907 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2908 unconditionnaly since it does the check itself.
2909
2910 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 Fix more problems found by GCC 4.5.2's static checks.
2913
2914 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2915 the first time through the loop, since we know p0 < p1 then.
2916 This also avoids a gcc -Wstrict-overflow warning.
2917
2918 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2919 leading to a memory leak, possible in functions like
2920 load_charset_map_from_file that can allocate an unbounded number
2921 of objects (Bug#8318).
2922
2923 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2924 that could (at least in theory) be that large.
2925
2926 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2927 This is less likely to overflow, and avoids undefined behavior if
2928 overflow does occur. All callers changed. Use strtoul to scan
2929 for the unsigned long integer.
2930 (pint2hrstr): Simplify and tune code slightly.
2931 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2932
2933 * scroll.c (do_scrolling): Work around GCC bug 48228.
2934 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2935
2936 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2937 This also avoids a warning with gcc -Wstrict-overflow.
2938 (validate_x_resource_name): Simplify count usage.
2939 This also avoids a warning with gcc -Wstrict-overflow.
2940
2941 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2942 fail (Bug#8306).
2943
2944 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2945
2946 * process.c (Fmake_network_process): Use socklen_t, not int,
2947 where POSIX says socklen_t is required in portable programs.
2948 This fixes a porting bug on hosts like 64-bit HP-UX, where
2949 socklen_t is wider than int (Bug#8277).
2950 (Fmake_network_process, server_accept_connection):
2951 (wait_reading_process_output, read_process_output):
2952 Likewise.
2953
2954 * process.c: Rename or move locals to avoid shadowing.
2955 (list_processes_1, Fmake_network_process):
2956 (read_process_output_error_handler, exec_sentinel_error_handler):
2957 Rename or move locals.
2958 (Fmake_network_process): Define label "retry_connect" only if needed.
2959 (Fnetwork_interface_info): Fix pointer signedness.
2960 (process_send_signal): Add cast to avoid pointer signedness problem.
2961 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2962 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2963
2964 Make tparam.h and terminfo.c consistent.
2965 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2966 Include tparam.h instead, since it declares them.
2967 * cm.h (PC): Remove extern decl; tparam.h now does this.
2968 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2969 * terminfo.c: Include tparam.h, to check interfaces.
2970 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2971 (tparam): Adjust signature to match interface in tparam.h;
2972 this removes some undefined behavior. Check that outstring and len
2973 are zero, which they always are with Emacs.
2974 * tparam.h (PC, BC, UP): New extern decls.
2975
2976 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2977 (xftfont_open): Rename locals to avoid shadowing.
2978
2979 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2980 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2981 (OTF_TAG_SYM): Omit macro if not needed.
2982 (ftfont_list): Remove unused local.
2983 (get_adstyle_property, ftfont_pattern_entity):
2984 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2985 Rename locals to avoid shadowing.
2986
2987 * xfont.c (xfont_list_family): Mark var as initialized.
2988
2989 * xml.c (make_dom): Now static.
2990
2991 * composite.c (composition_compute_stop_pos): Rename local to
2992 avoid shadowing.
2993 (composition_reseat_it): Remove unused locals.
2994 (find_automatic_composition, composition_adjust_point): Likewise.
2995 (composition_update_it): Mark var as initialized.
2996 (find_automatic_composition): Mark vars as initialized,
2997 with a FIXME (Bug#8290).
2998
2999 character.h: Rename locals to avoid shadowing.
3000 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3001 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3002 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3003 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3004 to avoid shadowing.
3005
3006 * textprop.c (property_change_between_p): Remove; unused.
3007
3008 * intervals.c (interval_start_pos): Now static.
3009
3010 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3011
3012 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3013 Rename locals to avoid shadowing.
3014
3015 * sound.c (wav_play, au_play, Fplay_sound_internal):
3016 Fix pointer signedness.
3017 (alsa_choose_format): Remove unused local var.
3018 (wav_play): Initialize a variable to 0, to prevent undefined
3019 behavior (Bug#8278).
3020
3021 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3022
3023 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3024
3025 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3026 clobbering (Bug#8298).
3027 * sysdep.c (sys_subshell): Likewise.
3028 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3029
3030 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3031 This should get cleaned up, so that child_setup has the
3032 same signature on all platforms.
3033
3034 * callproc.c (call_process_cleanup): Now static.
3035 (relocate_fd): Rename locals to avoid shadowing.
3036
3037 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3038
3039 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3040 not to be necessary, and produces flickering.
3041
3042 2011-03-20 Glenn Morris <rgm@gnu.org>
3043
3044 * config.in: Remove file.
3045
3046 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3047
3048 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3049 are now in src/globals.h.
3050 (syms_of_minibuf): Remove spurious & from previous change.
3051
3052 2011-03-20 Leo <sdl.web@gmail.com>
3053
3054 * minibuf.c (completing-read-function): New variable.
3055 (completing-read-default): Rename from completing-read.
3056 (completing-read): Call completing-read-function.
3057
3058 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3059
3060 * xfaces.c (Fx_load_color_file):
3061 Read color file from absolute filename (bug#8250).
3062
3063 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3064
3065 * makefile.w32-in: Update dependencies.
3066
3067 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3068
3069 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3070
3071 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3072
3073 Fix more problems found by GCC 4.5.2's static checks.
3074
3075 * process.c (make_serial_process_unwind, send_process_trap):
3076 (sigchld_handler): Now static.
3077
3078 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3079 That way, the code declares only the vars that it needs.
3080 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3081 * s/cygwin.h (PTY_ITERATION): Likewise.
3082 * s/darwin.h (PTY_ITERATION): Likewise.
3083 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3084
3085 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3086 * process.c (allocate_pty): Don't declare stb unless it's needed.
3087
3088 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3089 (CONSTANTLIM): Remove; unused.
3090 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3091 Define only if needed.
3092
3093 * unexelf.c (unexec): Name an expression,
3094 to avoid gcc -Wbad-function-cast warning.
3095 Use a different way to cause a compilation error if anyone uses
3096 n rather than nn, a way that does not involve shadowing.
3097 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3098
3099 * deps.mk (unexalpha.o): Remove; unused.
3100
3101 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3102 * unexec.h: New file.
3103 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3104 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3105 Depend on unexec.h.
3106 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3107 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3108 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3109 Change as necessary to match prototype in unexec.h.
3110
3111 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3112 shadowing.
3113 (back_comment, skip_chars): Mark vars as initialized.
3114
3115 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3116 Rename locals to avoid shadowing.
3117
3118 * lread.c (read1): Rewrite so as not to use empty "else".
3119 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3120
3121 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3122
3123 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3124 warning when compiling print.c.
3125
3126 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3127 instead of using an uninitialized var.
3128 (font_sort_entities): Mark var as initialized.
3129
3130 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3131
3132 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3133 pointers to constants.
3134 (font_parse_fcname): Remove unused vars.
3135 (font_delete_unmatched): Now static.
3136 (font_get_spec): Remove; unused.
3137 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3138 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3139 Rename or move locals to avoid shadowing.
3140
3141 * fns.c (require_nesting_list, require_unwind): Now static.
3142 (Ffillarray): Rename locals to avoid shadowing.
3143
3144 * floatfns.c (domain_error2): Define only if needed.
3145 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3146
3147 * alloc.c (mark_backtrace): Move decl from here ...
3148 * lisp.h: ... to here, so that it can be checked.
3149
3150 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3151 (Fdefvar): Rewrite so as not to use empty "else".
3152 (lisp_indirect_variable): Name an expression,
3153 to avoid gcc -Wbad-function-cast warning.
3154 (Fdefvar): Rename locals to avoid shadowing.
3155
3156 * callint.c (quotify_arg, quotify_args): Now static.
3157 (Fcall_interactively): Rename locals to avoid shadowing.
3158 Use const pointer when appropriate.
3159
3160 * lisp.h (get_system_name, get_operating_system_release):
3161 Move decls here, to check interfaces.
3162 * process.c (get_operating_system_release): Move decl to lisp.h.
3163 * xrdb.c (get_system_name): Likewise.
3164 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3165 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3166 some of which prompt warnings from gcc -Wbad-function-cast.
3167 (Fformat_time_string, Fencode_time, Finsert_char):
3168 (Ftranslate_region_internal, Fformat):
3169 Rename or remove local vars to avoid shadowing.
3170 (Ftranslate_region_internal): Mark var as initialized.
3171
3172 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3173 avoid shadowing.
3174
3175 * lisp.h (eassert): Check that the argument compiles, even if
3176 ENABLE_CHECKING is not defined.
3177
3178 * data.c (Findirect_variable): Name an expression, to avoid
3179 gcc -Wbad-function-cast warning.
3180 (default_value, arithcompare, arith_driver, arith_error): Now static.
3181 (store_symval_forwarding): Rename local to avoid shadowing.
3182 (Fmake_variable_buffer_local, Fmake_local_variable):
3183 Mark variables as initialized.
3184 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3185
3186 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3187 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3188 Rename locals to avoid shadowing.
3189 (mark_stack): Move local variables into the #ifdef region where
3190 they're used.
3191 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3192 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3193 needed otherwise.
3194 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3195 (GC_STRING_CHARS): Remove; not used.
3196 (Fmemory_limit): Cast sbrk's returned value to char *.
3197
3198 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3199 avoids undefined behavior in theory.
3200
3201 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3202
3203 Use functions, not macros, for up- and down-casing (Bug#8254).
3204 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3205 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3206 to use the following functions instead of these macros.
3207 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3208 EMACS_INT, since callers assume the returned value fits in int.
3209 (upcase1): Likewise, for UPCASE_TABLE.
3210 (uppercasep, lowercasep, upcase): New static inline functions.
3211 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3212 the race-condition problem in the old DOWNCASE.
3213
3214 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3215 Rename locals to avoid shadowing.
3216 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3217 (regex_compile, re_search_2, re_match_2_internal):
3218 Remove unused local vars.
3219 (FREE_VAR): Rewrite so as not to use empty "else",
3220 which gcc can warn about.
3221 (regex_compile, re_match_2_internal): Mark locals as initialized.
3222 (RETALLOC_IF): Define only if needed.
3223 (WORDCHAR_P): Likewise. This one is never needed, but is used
3224 only in a comment talking about a compiler bug, so put inside
3225 the #if 0 of that comment.
3226 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3227 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3228 Remove; unused.
3229
3230 * search.c (boyer_moore): Rename locals to avoid shadowing.
3231 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3232 (PREV_CHAR_BOUNDARY): Likewise.
3233
3234 * search.c (simple_search): Remove unused var.
3235
3236 * dired.c (compile_pattern): Move decl from here ...
3237 * lisp.h: ... to here, so that it can be checked.
3238 (struct re_registers): New forward decl.
3239
3240 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3241
3242 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3243 All uses changed.
3244 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3245 Rename locals to avoid shadowing.
3246 (Fvertical_motion): Mark locals as initialized.
3247
3248 * casefiddle.c (casify_object, casify_region): Now static.
3249 (casify_region): Mark local as initialized.
3250
3251 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3252
3253 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3254 New macros, so that the caller can use some names other than
3255 gcpro1, gcpro2, etc.
3256 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3257 of the new macros.
3258 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3259 argument, for consistency with GCPRO2_VAR, etc: it is now the
3260 prefix of the variable, not the variable itself. All uses
3261 changed.
3262 * dired.c (directory_files_internal, file_name_completion):
3263 Rename locals to avoid shadowing.
3264
3265 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3266 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3267 dired.c's scmp function, had undefined behavior.
3268 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3269 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3270 * buffer.h: ... to here, because these macros use current_buffer,
3271 and the new implementation with inline functions needs to have
3272 current_buffer in scope now, rather than later when the macros
3273 are used.
3274 (downcase, upcase1): New static inline functions.
3275 (DOWNCASE, UPCASE1): Reimplement using these functions.
3276 This avoids undefined behavior in expressions like
3277 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3278 from race conditions in accessing the global variables
3279 case_temp1 and case_temp2.
3280 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3281 * lisp.h (case_temp1, case_temp2): Remove their decls.
3282 * character.h (ASCII_CHAR_P): Move from here ...
3283 * lisp.h: ... to here, so that the inline functions mentioned
3284 above can use them.
3285
3286 * dired.c (directory_files_internal_unwind): Now static.
3287
3288 * fileio.c (file_name_as_directory, directory_file_name):
3289 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3290 Now static.
3291 (file_name_as_directory): Use const pointers when appropriate.
3292 (Fexpand_file_name): Likewise. In particular, newdir might
3293 point at constant storage, so make it a const pointer.
3294 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3295 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3296 signedness issues.
3297 (Fset_file_times, Finsert_file_contents, auto_save_error):
3298 Rename locals to avoid shadowing.
3299
3300 * minibuf.c (choose_minibuf_frame_1): Now static.
3301 (Ftry_completion, Fall_completions): Rename or remove locals
3302 to avoid shadowing.
3303
3304 * marker.c (bytepos_to_charpos): Remove; unused.
3305
3306 * lisp.h (verify_bytepos, count_markers): New decls,
3307 so that gcc does not warn that these functions aren't declared.
3308
3309 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3310 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3311 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3312 (copy_text): Remove unused local var.
3313
3314 * filelock.c (within_one_second): Now static.
3315 (lock_file_1): Rename local to avoid shadowing.
3316
3317 * buffer.c (fix_overlays_before): Mark locals as initialized.
3318 (fix_start_end_in_overlays): Likewise. This function should be
3319 simplified by using pointers-to-pointers, but that's a different
3320 matter.
3321 (switch_to_buffer_1): Now static.
3322 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3323 (report_overlay_modification): Rename locals to avoid shadowing.
3324
3325 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3326 Fix pointer signedness issue.
3327 (sys_subshell): Mark local as volatile if checking for lint,
3328 to suppress a gcc -Wclobbered warning that does not seem to be right.
3329 (MAXPATHLEN): Define only if needed.
3330
3331 * process.c (serial_open, serial_configure): Move decls from here ...
3332 * systty.h: ... to here, so that they can be checked.
3333
3334 * fns.c (get_random, seed_random): Move extern decls from here ...
3335 * lisp.h: ... to here, so that they can be checked.
3336
3337 * sysdep.c (reset_io): Now static.
3338 (wait_for_termination_signal): Remove; unused.
3339
3340 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3341 (copy_keymap_item, append_key, push_text_char_description):
3342 Now static.
3343 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3344 (DENSE_TABLE_SIZE): Remove; unused.
3345 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3346 (describe_map_tree):
3347 Rename locals to avoid shadowing.
3348
3349 * keyboard.c: Declare functions static if they are not used elsewhere.
3350 (echo_char, echo_dash, cmd_error, top_level_2):
3351 (poll_for_input, handle_async_input): Now static.
3352 (read_char, kbd_buffer_get_event, make_lispy_position):
3353 (make_lispy_event, make_lispy_movement, apply_modifiers):
3354 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3355 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3356 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3357 (read_key_sequence, read_char): Mark locals as initialized.
3358 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3359
3360 * keyboard.h (make_ctrl_char): New decl.
3361 (mark_kboards): Move decl here ...
3362 * alloc.c (mark_kboards): ... from here.
3363
3364 * lisp.h (force_auto_save_soon): New decl.
3365
3366 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3367 (DEFINE_DUMMY_FUNCTION): New macro.
3368 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3369 Use it.
3370 (main): Add casts to avoid warnings
3371 if GCC considers string literals to be constants.
3372
3373 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3374
3375 * dbusbind.c: Pointer signedness fixes.
3376 (xd_signature, xd_append_arg, xd_initialize):
3377 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3378 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3379 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3380 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3381
3382 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3383 if GCC considers string literals to be constants.
3384 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3385
3386 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3387
3388 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3389 (print_preprocess, print_object): New macro to fix last change.
3390
3391 * print.c (print_preprocess): Don't forget font objects.
3392
3393 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3394
3395 * emacs.c (USAGE3): Doc fixes.
3396
3397 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3398
3399 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3400 structure.
3401
3402 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3403
3404 * lisp.h (VWindow_system, Qfile_name_history):
3405 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3406 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3407 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3408
3409 * w32select.c: Don't #include "keyboard.h".
3410 (run_protected): Add extern declaration for waiting_for_input.
3411
3412 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3413 * w32console.c (detect_input_pending, read_input_pending)
3414 (encode_terminal_code):
3415 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3416 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3417 (w32_system_caret_y, Qfile_name_history):
3418 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3419 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3420 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3421 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3422 * w32proc.c (Qlocal, report_file_error):
3423 * w32term.c (Vwindow_system, updating_frame):
3424 * w32uniscribe.c (initialized, uniscribe_font_driver):
3425 Remove unneeded extern declarations.
3426
3427 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3428
3429 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3430
3431 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3432
3433 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3434 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3435 These macros can no longer be used for assignment.
3436
3437 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3438 Assign struct members directly, instead of using BUF_BEGV etc.
3439 (record_buffer_markers, fetch_buffer_markers): New functions for
3440 recording and fetching special buffer markers.
3441 (set_buffer_internal_1, set_buffer_temp): Use them.
3442
3443 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3444
3445 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3446
3447 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3448 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3449
3450 * xdisp.c (hscroll_window_tree):
3451 (reconsider_clip_changes): Use PT instead of BUF_PT.
3452
3453 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3454
3455 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3456 $(EMACS_ROOT)/lib/intprops.h.
3457
3458 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3459
3460 Fix more problems found by GCC 4.5.2's static checks.
3461
3462 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3463 to unsigned char * to avoid compiler diagnostic.
3464 (xg_free_frame_widgets): Make it clear that a local variable is
3465 needed only if USE_GTK_TOOLTIP.
3466 (gdk_window_get_screen): Make it clear that this macro is needed
3467 only if USE_GTK_TOOLTIP.
3468 (int_gtk_range_get_value): New function, which avoids a diagnostic
3469 from gcc -Wbad-function-cast.
3470 (xg_set_toolkit_scroll_bar_thumb): Use it.
3471 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3472 diagnostic from gcc -Wbad-function-cast.
3473 (get_utf8_string, xg_get_file_with_chooser):
3474 Rename locals to avoid shadowing.
3475 (create_dialog): Move locals to avoid shadowing.
3476
3477 * xgselect.c (xg_select): Remove unused var.
3478
3479 * image.c (four_corners_best): Mark locals as initialized.
3480 (gif_load): Initialize transparent_p to zero (Bug#8238).
3481 Mark another local as initialized.
3482 (my_png_error, my_error_exit): Mark with NO_RETURN.
3483
3484 * image.c (clear_image_cache): Now static.
3485 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3486 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3487 (x_edge_detection): Remove unnecessary cast that
3488 gcc -Wbad-function-cast diagnoses.
3489 (gif_load): Fix pointer signedness.
3490 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3491 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3492
3493 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 Improve quality of tests for time stamp overflow.
3496 For example, without this patch (encode-time 0 0 0 1 1
3497 1152921504606846976) returns the obviously-bogus value (-948597
3498 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3499 reports time overflow. See
3500 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3501 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3502 * editfns.c: Include limits.h and intprops.h.
3503 (TIME_T_MIN, TIME_T_MAX): New macros.
3504 (time_overflow): Move earlier, to before first use.
3505 (hi_time, lo_time): New functions, for an accurate test for
3506 out-of-range times.
3507 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3508 (Fget_internal_run_time): Don't assume time_t fits in int.
3509 (make_time): Use list2 instead of Fcons twice.
3510 (Fdecode_time): More accurate test for out-of-range times.
3511 (check_tm_member): New function.
3512 (Fencode_time): Use it, to test for out-of-range times.
3513 (lisp_time_argument): Don't rely on undefined left-shift and
3514 right-shift behavior when checking for time stamp overflow.
3515
3516 * editfns.c (time_overflow): New function, refactoring common code.
3517 (Fformat_time_string, Fdecode_time, Fencode_time):
3518 (Fcurrent_time_string): Use it.
3519
3520 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3521 * dired.c (make_time): Move to ...
3522 * editfns.c (make_time): ... here.
3523 * systime.h: Note the move.
3524
3525 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3526
3527 * fringe.c (update_window_fringes): Remove unused variables.
3528
3529 * unexmacosx.c (copy_data_segment): Also copy __got section.
3530 (Bug#8223)
3531
3532 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3533
3534 * termcap.c [MSDOS]: Include "msdos.h".
3535 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3536 Constify `char *' arguments and their references according to
3537 prototypes in tparam.h.
3538
3539 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3540
3541 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3542 Adapt all references accordingly.
3543
3544 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3545
3546 2011-03-11 Tom Tromey <tromey@redhat.com>
3547
3548 * buffer.c (syms_of_buffer): Remove obsolete comment.
3549
3550 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3551
3552 * termhooks.h (encode_terminal_code): Declare prototype.
3553
3554 * msdos.c (encode_terminal_code): Don't declare prototype.
3555
3556 * term.c (encode_terminal_code): Now external again, used by
3557 w32console.c and msdos.c.
3558
3559 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3560 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3561
3562 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3563
3564 Fix some minor problems found by GCC 4.5.2's static checks.
3565
3566 * fringe.c (update_window_fringes): Mark locals as initialized
3567 (Bug#8227).
3568 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3569
3570 * alloc.c (mark_fringe_data): Move decl from here ...
3571 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3572 to check its interface.
3573 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3574
3575 * fontset.c (free_realized_fontset): Now static.
3576 (Fset_fontset_font): Rename local to avoid shadowing.
3577 (fontset_font): Mark local as initialized.
3578 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3579
3580 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3581
3582 * xselect.c (x_disown_buffer_selections): Remove; not used.
3583 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3584 (x_own_selection, Fx_disown_selection_internal): Rename locals
3585 to avoid shadowing.
3586 (x_handle_dnd_message): Remove local to avoid shadowing.
3587
3588 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3589 so that the caller can use some name other than gcpro1.
3590 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3591 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3592 (Fx_backspace_delete_keys_p):
3593 Use them to avoid shadowing, and rename vars to avoid shadowing.
3594 (x_decode_color, x_set_name, x_window): Now static.
3595 (Fx_create_frame): Add braces to silence GCC warning.
3596 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3597 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3598 Remove unused locals.
3599 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3600 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3601 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3602 macros.
3603
3604 * xterm.h (x_mouse_leave): New decl.
3605
3606 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3607 Remove unused functions.
3608 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3609 (x_calc_absolute_position): Now static.
3610 (XTread_socket): Don't define label "out" unless it's used.
3611 Don't declare local "event" unless it's used.
3612 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3613 unless they are used.
3614 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3615 (x_fatal_error_signal): Remove; not used.
3616 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3617 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3618 (x_error_catcher, x_connection_closed, x_error_handler):
3619 (x_error_quitter, xembed_send_message, x_iconify_frame):
3620 (my_log_handler): Rename locals to avoid shadowing.
3621 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3622 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3623
3624 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3625 Rename or move locals to avoid shadowing.
3626 (tty_defined_color, merge_face_heights): Now static.
3627 (free_realized_faces_for_fontset): Remove; not used.
3628 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3629 does not deduce is never used uninitialized.
3630 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3631 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3632
3633 * terminal.c (store_terminal_param): Now static.
3634
3635 * xmenu.c (menu_highlight_callback): Now static.
3636 (set_frame_menubar): Remove unused local.
3637 (xmenu_show): Rename parameter to avoid shadowing.
3638 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3639 since they might point to immutable storage.
3640 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3641 since it's unused otherwise.
3642
3643 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3644 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3645 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3646 avoids a gcc -Wuninitialized diagnostic.
3647 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3648 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3649 does not deduce are never used uninitialized.
3650
3651 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3652
3653 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3654 * window.c (window_loop, size_window):
3655 (run_window_configuration_change_hook, enlarge_window): Likewise.
3656
3657 * window.c (display_buffer): Now static.
3658 (size_window): Mark variables that gcc -Wuninitialized
3659 does not deduce are never used uninitialized.
3660 * window.h (check_all_windows): New decl, to forestall
3661 gcc -Wmissing-prototypes diagnostic.
3662 * dispextern.h (bidi_dump_cached_states): Likewise.
3663
3664 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3665 shadowing.
3666 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3667 Include <limits.h>.
3668 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3669 and to avoid gcc -Wuninitialized warning.
3670 (load_charset_map): Mark variables that gcc -Wuninitialized
3671 does not deduce are never used uninitialized.
3672 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3673
3674 * coding.c (coding_set_source, coding_set_destination):
3675 Use "else { /* comment */ }" rather than "else /* comment */;"
3676 for clarity, and to avoid gcc -Wempty-body warning.
3677 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3678 a block, when the outer 'i' will do.
3679 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3680 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3681 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3682 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3683 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3684 Rename locals to avoid shadowing.
3685 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3686 * coding.c (emacs_mule_char, encode_invocation_designation):
3687 Now static, since they're not used elsewhere.
3688 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3689 (decode_coding_object, encode_coding_object, detect_coding_system):
3690 (decode_coding_emacs_mule): Mark variables that gcc
3691 -Wuninitialized does not deduce are never used uninitialized.
3692 (detect_coding_iso_2022): Initialize a local variable that might
3693 be used uninitialized. Leave a FIXME because it's not clear that
3694 this initialization is needed. (Bug#8211)
3695 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3696 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3697 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3698 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3699 Remove unused macros.
3700
3701 * category.c (hash_get_category_set): Remove unused local var.
3702 (copy_category_table): Now static, since it's not used elsewhere.
3703 * character.c (string_count_byte8): Likewise.
3704
3705 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3706 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3707
3708 * chartab.c (copy_sub_char_table): Now static, since it's not used
3709 elsewhere.
3710 (sub_char_table_ref_and_range, char_table_ref_and_range):
3711 Rename locals to avoid shadowing.
3712 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3713
3714 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3715 (BIDI_BOB): Remove unused macro.
3716
3717 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3718 deduce are never used uninitialized.
3719 * term.c (encode_terminal_code): Likewise.
3720
3721 * term.c (encode_terminal_code): Now static. Remove unused local.
3722
3723 * tparam.h: New file.
3724 * term.c, tparam.h: Include it.
3725 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3726 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3727 Move these decls to tparam.h, and make them agree with what
3728 is actually in tparam.c. The previous trick of using incompatible
3729 decls in different modules does not conform to the C standard.
3730 All callers of tparam changed to use tparam's actual API.
3731 * tparam.c (tparam1, tparam, tgoto):
3732 Use const pointers where appropriate.
3733
3734 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3735 * cm.h (struct cm): Likewise.
3736 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3737 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3738 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3739 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3740 (turn_on_face, init_tty): Likewise.
3741 * termchar.h (struct tty_display_info): Likewise.
3742
3743 * term.c (term_mouse_position): Rename local to avoid shadowing.
3744
3745 * alloc.c (mark_ttys): Move decl from here ...
3746 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3747
3748 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3749
3750 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3751
3752 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3753
3754 * search.c (compile_pattern_1): Remove argument regp, unused since
3755 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3756 (compile_pattern): Don't pass it.
3757
3758 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3759
3760 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3761 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3762 for ! HAVE_GTK3.
3763 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3764
3765 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3766
3767 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3768 gdk_window_get_screen, gdk_window_get_geometry,
3769 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3770 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3771 (xg_get_pixbuf_from_pixmap): New function.
3772 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3773 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3774 Call xg_get_pixbuf_from_pixmap instead of
3775 gdk_pixbuf_get_from_drawable.
3776 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3777 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3778 (xg_check_special_colors): Use GtkStyleContext and its functions
3779 for HAVE_GTK3.
3780 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3781 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3782 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3783 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3784 Call gtk_widget_get_preferred_size.
3785 (xg_frame_resized): gdk_window_get_geometry only takes 5
3786 parameters.
3787 (xg_win_to_widget, xg_event_is_for_menubar):
3788 Call gdk_x11_window_lookup_for_display.
3789 (xg_set_widget_bg): New function.
3790 (delete_cb): New function.
3791 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3792 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3793 (xg_set_background_color): Call xg_set_widget_bg.
3794 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3795 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3796 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3797 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3798 if ! HAVE_GTK3.
3799 (update_frame_tool_bar): Call gtk_widget_hide.
3800 (xg_initialize): Use GDK_KEY_g.
3801
3802 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3803 if ! HAVE_GTK3
3804 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3805
3806 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3807 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3808 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3809
3810 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3811
3812 * w32xfns.c (select_palette): Check success of RealizePalette against
3813 GDI_ERROR, not zero.
3814
3815 See ChangeLog.11 for earlier changes.
3816
3817 ;; Local Variables:
3818 ;; coding: utf-8
3819 ;; End:
3820
3821 Copyright (C) 2011 Free Software Foundation, Inc.
3822
3823 This file is part of GNU Emacs.
3824
3825 GNU Emacs is free software: you can redistribute it and/or modify
3826 it under the terms of the GNU General Public License as published by
3827 the Free Software Foundation, either version 3 of the License, or
3828 (at your option) any later version.
3829
3830 GNU Emacs is distributed in the hope that it will be useful,
3831 but WITHOUT ANY WARRANTY; without even the implied warranty of
3832 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3833 GNU General Public License for more details.
3834
3835 You should have received a copy of the GNU General Public License
3836 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.