]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
[gnu-emacs] / src / ChangeLog
1 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2
3 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4 (CCL_CODE_MIN): New macro.
5
6 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7
8 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9
10 * eval.c (Qdebug): Now static.
11 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
13 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
14
15 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
16
17 * image.c: Various fixes to ImageMagick code comments.
18 (Fimagemagick_types): Doc fix.
19
20 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
21
22 Minor fixes prompted by GCC 4.6.0 warnings.
23
24 * xselect.c (converted_selections, conversion_fail_tag): Now static.
25
26 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
27 (x_clipboard_manager_save_all): Move extern decl to ...
28 * xterm.h: ... here, so that it can be checked for consistency.
29
30 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
31
32 * xselect.c (x_clipboard_manager_save_frame)
33 (x_clipboard_manager_save_all): New functions.
34 (Fx_clipboard_manager_save): Lisp function deleted.
35
36 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
37 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
38
39 * xterm.h: Update prototype.
40
41 2011-05-28 William Xu <william.xwl@gmail.com>
42
43 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
44 exiting (Bug#8239).
45
46 2011-05-28 Jim Meyering <meyering@redhat.com>
47
48 Avoid a sign-extension bug in crypto_hash_function.
49 * fns.c (to_uchar): Define.
50 (crypto_hash_function): Use it to convert some newly-signed
51 variables to unsigned, to avoid sign-extension bugs. For example,
52 without this change, (md5 "truc") would evaluate to
53 45723a2aff78ff4fff7fff1114760e62 rather than the expected
54 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
55 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
56
57 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
58
59 Integer overflow fixes.
60
61 * dbusbind.c: Serial number integer overflow fixes.
62 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
63 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
64 to hold a serial number that is too large for a fixnum.
65 (Fdbus_method_return_internal, Fdbus_method_error_internal):
66 Check for serial numbers out of range. Decode any serial number
67 that was so large that it became a float. (Bug#8722)
68
69 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
70 (Fdbus_call_method, Fdbus_call_method_asynchronously):
71 Use XFASTINT rather than XUINT when numbers are nonnegative.
72 (xd_append_arg, Fdbus_method_return_internal):
73 (Fdbus_method_error_internal): Likewise. Also, for unsigned
74 arguments, check that Lisp number is nonnegative, rather than
75 silently wrapping negative numbers around. (Bug#8722)
76 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
77 (Bug#8722)
78
79 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
80
81 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
82
83 ccl: add integer overflow checks
84 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
85 (IN_INT_RANGE): New macros.
86 (ccl_driver): Use them to check for integer overflow when
87 decoding a CCL program. Many of the new checks are whether XINT (x)
88 fits in int; it doesn't always, on 64-bit hosts. The new version
89 doesn't catch all possible integer overflows, but it's an
90 improvement. (Bug#8719)
91
92 * alloc.c (make_event_array): Use XINT, not XUINT.
93 There's no need for unsigned here.
94
95 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
96 This follows up to the 2011-05-06 change that substituted uintptr_t
97 for EMACS_INT. This case wasn't caught back then.
98
99 Rework Fformat to avoid integer overflow issues.
100 * editfns.c: Include <float.h> unconditionally, as it's everywhere
101 now (part of C89). Include <verify.h>.
102 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
103 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
104 (Fformat): Avoid the prepass trying to compute sizes; it was only
105 approximate and thus did not catch overflow reliably. Instead, walk
106 through the format just once, formatting and computing sizes as we go,
107 checking for integer overflow at every step, and allocating a larger
108 buffer as needed. Keep track separately whether the format is
109 multibyte. Keep only the most-recently calculated precision, rather
110 than them all. Record whether each argument has been converted to
111 string. Use EMACS_INT, not int, for byte and char and arg counts.
112 Support field widths and precisions larger than INT_MAX. Avoid
113 sprintf's undefined behavior with conversion specifications such as %#d
114 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
115 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
116 formatting out-of-range floating point numbers with int
117 formats. (Bug#8668)
118
119 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
120
121 * data.c: Avoid integer truncation in expressions involving floats.
122 * data.c: Include <intprops.h>.
123 (arith_driver): When there's an integer overflow in an expression
124 involving floating point, convert the integers to floating point
125 so that the resulting value does not suffer from catastrophic
126 integer truncation. For example, on a 64-bit host (* 4
127 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
128 Do not rely on undefined behavior after integer overflow.
129
130 merge count_size_as_multibyte, parse_str_to_multibyte
131 * character.c, character.h (count_size_as_multibyte):
132 Renamed from parse_str_to_multibyte; all uses changed.
133 Check for integer overflow.
134 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
135 since it's now a duplicate of the other. This is more of
136 a character than a buffer op, so better that it's in character.c.
137 * fns.c, print.c: Adjust to above changes.
138
139 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
140
141 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
142
143 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
144
145 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
146 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
147 (x_clipboard_manager_save): Now static.
148 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
149
150 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
151 (crypto_hash_function): Now static.
152 Fix pointer signedness problems. Avoid unnecessary initializations.
153
154 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
155
156 * termhooks.h (Vselection_alist): Make it terminal-local.
157
158 * terminal.c (create_terminal): Initialize it.
159
160 * xselect.c: Support for clipboard managers.
161 (Vselection_alist): Move to termhooks.h as terminal-local var.
162 (LOCAL_SELECTION): New macro.
163 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
164 (symbol_to_x_atom): Remove gratuitous arg.
165 (x_handle_selection_request, lisp_data_to_selection_data)
166 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
167 (x_own_selection, x_get_local_selection, x_convert_selection): New
168 arg, specifying work frame. Use terminal-local Vselection_alist.
169 (some_frame_on_display): Delete unused function.
170 (Fx_own_selection_internal, Fx_get_selection_internal)
171 (Fx_disown_selection_internal, Fx_selection_owner_p)
172 (Fx_selection_exists_p): New optional frame arg.
173 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
174 (x_handle_selection_clear): Don't treat other terminals with the
175 same keyboard specially. Use the terminal-local Vselection_alist.
176 (x_clear_frame_selections): Use Frun_hook_with_args.
177
178 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
179
180 * xterm.h: Add support for those atoms.
181
182 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
183
184 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
185 (converted_selections, conversion_fail_tag): New global variables.
186 (x_selection_request_lisp_error): Free the above.
187 (x_get_local_selection): Remove unnecessary code.
188 (x_reply_selection_request): Args changed; handle arbitrary array
189 of converted selections stored in converted_selections. Separate
190 the XChangeProperty and SelectionNotify steps.
191 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
192 (x_convert_selection): New function.
193 (x_handle_selection_event): Simplify.
194 (x_get_foreign_selection): Don't ignore incoming requests while
195 waiting for an answer; this will fail when we implement
196 SAVE_TARGETS, and seems unnecessary anyway.
197 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
198 (Vx_sent_selection_functions): Doc fix.
199
200 2011-05-26 Leo Liu <sdl.web@gmail.com>
201
202 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
203
204 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
205
206 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
207
208 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
209 for fringe update if it has periodic bitmap.
210 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
211 and fringe_bitmap_periodic_p.
212
213 * fringe.c (get_fringe_bitmap_data): New function.
214 (draw_fringe_bitmap_1, update_window_fringes): Use it.
215 (update_window_fringes): Record periodicity of fringe bitmap in glyph
216 row. Mark glyph row for fringe update if periodicity changed.
217
218 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
219 for fringe update unless it has periodic bitmap.
220
221 2011-05-25 Kenichi Handa <handa@m17n.org>
222
223 * xdisp.c (get_next_display_element): Set correct it->face_id for
224 a static composition.
225
226 2011-05-24 Leo Liu <sdl.web@gmail.com>
227
228 * deps.mk (fns.o):
229 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
230
231 * fns.c (crypto_hash_function, Fsha1): New function.
232 (Fmd5): Use crypto_hash_function.
233 (syms_of_fns): Add Ssha1.
234
235 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
236
237 * gnutls.c: Remove unused macros.
238 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
239 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
240 Remove macros that are defined and never used.
241 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
242
243 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
244
245 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
246 (Fx_get_selection_internal): Minor cleanup.
247 (Fx_own_selection_internal): Rename arguments for consistency with
248 select.el.
249
250 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
251
252 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
253
254 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
255
256 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
257
258 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
259
260 * dispnew.c (scrolling_window): Don't exclude the case that the
261 last enabled row in the desired matrix touches the bottom boundary.
262
263 2011-05-21 Glenn Morris <rgm@gnu.org>
264
265 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
266 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
267 and add some more files.
268
269 2011-05-20 Eli Zaretskii <eliz@gnu.org>
270
271 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
272 report_file_error introduced by the change from 2011-05-07.
273
274 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
275
276 * systime.h (Time): Define only if emacs is defined.
277 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
278 where the include path doesn't have X11/X.h by default. See
279 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
280
281 2011-05-20 Kenichi Handa <handa@m17n.org>
282
283 * composite.c (find_automatic_composition): Fix previous change.
284
285 2011-05-20 Glenn Morris <rgm@gnu.org>
286
287 * lisp.mk: New file, split from Makefile.in.
288 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
289 (shortlisp): Remove.
290 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
291
292 2011-05-19 Glenn Morris <rgm@gnu.org>
293
294 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
295 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
296 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
297 (lisp): Set the order to that of loadup.el.
298 (shortlisp): Make it a copy of $lisp.
299 (SOME_MACHINE_LISP): Remove.
300 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
301 Use just $shortlisp, not $SOME_MACHINE_LISP too.
302
303 2011-05-18 Kenichi Handa <handa@m17n.org>
304
305 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
306 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
307 (find_automatic_composition): Mostly rewrite for efficiency.
308
309 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
310
311 * makefile.w32-in: Update dependencies.
312
313 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
314
315 * menu.c: Include limits.h (fixes the MS-Windows build broken by
316 revision 104625).
317
318 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
319
320 Fix some integer overflow issues, such as string length overflow.
321
322 * insdel.c (count_size_as_multibyte): Check for string overflow.
323
324 * character.c (lisp_string_width): Check for string overflow.
325 Use EMACS_INT, not int, for string indexes and lengths; in
326 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
327 the resulting string length overflows an EMACS_INT; instead,
328 report a string overflow if no precision given. When checking for
329 precision exhaustion, use a check that cannot possibly have
330 integer overflow. (Bug#8675)
331 * character.h (lisp_string_width): Adjust to new signature.
332
333 * alloc.c (string_overflow): New function.
334 (Fmake_string): Use it. This doesn't change behavior, but saves
335 a few bytes and will simplify future changes.
336 * character.c (string_escape_byte8): Likewise.
337 * lisp.h (string_overflow): New decl.
338
339 Fixups, following up to the user-interface timestamp change.
340 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
341 for UI timestamps, instead of unsigned long.
342 * msdos.c (mouse_get_pos): Likewise.
343 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
344 * w32gui.h (Time): Define by including "systime.h" rather than by
345 declaring it ourselves. (Bug#8664)
346
347 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
348 * image.c (clear_image_cache): Likewise.
349
350 * term.c (term_mouse_position): Don't assume time_t wraparound.
351
352 Be more systematic about user-interface timestamps.
353 Before, the code sometimes used 'Time', sometimes 'unsigned long',
354 and sometimes 'EMACS_UINT', to represent these timestamps. This
355 change causes it to use 'Time' uniformly, as that's what X uses.
356 This makes the code easier to follow, and makes it easier to catch
357 integer overflow bugs such as Bug#8664.
358 * frame.c (Fmouse_position, Fmouse_pixel_position):
359 Use Time, not unsigned long, for user-interface timestamps.
360 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
361 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
362 * keyboard.h (last_event_timestamp): Likewise.
363 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
364 * menu.h (xmenu_show): Likewise.
365 * term.c (term_mouse_position): Likewise.
366 * termhooks.h (struct input_event.timestamp): Likewise.
367 (struct terminal.mouse_position_hook): Likewise.
368 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
369 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
370 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
371 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
372 what it was before.
373 * menu.h, termhooks.h: Include "systime.h", for Time.
374
375 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
376 Don't assume that the difference between two unsigned long values
377 can fit into an integer. At this point, we know button_down_time
378 <= event->timestamp, so the difference must be nonnegative, so
379 there's no need to cast the result if double-click-time is
380 nonnegative, as it should be; check that it's nonnegative, just in
381 case. This bug is triggered when events are more than 2**31 ms
382 apart (about 25 days). (Bug#8664)
383
384 * xselect.c (last_event_timestamp): Remove duplicate decl.
385 (x_own_selection): Remove needless cast to unsigned long.
386
387 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
388 that always fit in int. Use a sentinel instead of a counter, to
389 avoid a temp and to allay GCC's concerns about possible int overflow.
390 * frame.h (struct frame): Use int for menu_bar_items_used
391 instead of EMACS_INT, since it always fits in int.
392
393 * menu.c (grow_menu_items): Check for int overflow.
394
395 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
396
397 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
398 Before, the code was not consistent. These values cannot exceed
399 2**31 - 1 so there's no need to make them unsigned.
400 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
401 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
402 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
403 as modifiers.
404 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
405
406 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
407 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
408 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
409 presumably because the widths might not match.
410
411 * window.c (size_window): Avoid needless test at loop start.
412
413 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
414
415 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
416
417 2011-05-12 Drew Adams <drew.adams@oracle.com>
418
419 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
420
421 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
422
423 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
424 `width' to `bar_area_x' and `bar_area_width', respectively.
425 (x_scroll_run): Take account of fringe background extension.
426
427 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
428 Rename local vars `left' and `width' to `bar_area_x' and
429 `bar_area_width', respectively.
430 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
431 background extension.
432
433 2011-05-10 Jim Meyering <meyering@redhat.com>
434
435 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
436
437 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
438
439 * image.c (Finit_image_library): Return t for built-in image types,
440 like pbm and xbm. (Bug#8640)
441
442 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
443
444 * w32menu.c (set_frame_menubar): Fix submenu allocation.
445
446 2011-05-07 Eli Zaretskii <eliz@gnu.org>
447
448 * w32console.c (Fset_screen_color): Doc fix.
449 (Fget_screen_color): New function.
450 (syms_of_ntterm): Defsubr it.
451
452 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
453 unlink the temporary file if Fcall_process didn't create it in the
454 first place.
455 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
456 child process will be redirected to a file specified with `:file'.
457 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
458 cue to call_process_cleanup not to close that handle.
459
460 2011-05-07 Ben Key <bkey76@gmail.com>
461
462 * makefile.w32-in: The bootstrap-temacs rule now makes use of
463 one of two shell specific rules, either bootstrap-temacs-CMD or
464 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
465 to the previous implementation of the bootstrap-temacs rule.
466 The bootstrap-temacs-CMD rule is similar to the previous
467 implementation of the bootstrap-temacs rule except that it
468 makes use of the ESC_CFLAGS variable instead of the CFLAGS
469 variable.
470
471 These changes, along with some changes to nt/configure.bat,
472 nt/gmake.defs, and nt/nmake.defs, are required to extend my
473 earlier fix to add support for --cflags and --ldflags options
474 that include quotes so that it works whether make uses cmd or
475 sh as the shell.
476
477 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
478
479 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
480 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
481 is a constant.
482 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
483 a string. Handle both cases.
484 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
485 (Fdbus_register_method): Use Qinvalid_function.
486
487 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
488
489 * makefile.w32-in: Update dependencies.
490 (LISP_H): Add inttypes.h and stdin.h.
491 (PROCESS_H): Add unistd.h.
492
493 2011-05-06 Eli Zaretskii <eliz@gnu.org>
494
495 * lread.c: Include limits.h (fixes the MS-Windows build broken by
496 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
497
498 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
499
500 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
501
502 * term.c (vfatal): Remove stray call to va_end.
503 It's not needed and the C Standard doesn't allow it here anyway.
504
505 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
506 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
507
508 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
509 bytes.
510
511 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
512
513 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
514
515 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
516
517 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
518
519 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
520
521 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
522 * charset.c (Fdefine_charset_internal): Don't initialize
523 charset.code_space[15]. The value was garbage, on hosts with
524 32-bit int (Bug#8600).
525
526 * lread.c (read_integer): Be more consistent with string-to-number.
527 Use string_to_number to do the actual conversion; this avoids
528 rounding errors and fixes some other screwups. Without this fix,
529 for example, #x1fffffffffffffff was misread as -2305843009213693952.
530 (digit_to_number): Move earlier, for benefit of read_integer.
531 Return -1 if the digit is out of range for the base, -2 if it is
532 not a digit in any supported base. (Bug#8602)
533
534 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
535
536 * dispnew.c (scrolling_window): Return 1 if we scrolled,
537 to match comment at start of function. This also removes a
538 GCC warning about overflow in a 32+64-bit port.
539
540 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
541
542 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
543 Reported by Stefan Monnier in
544 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
545 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
546 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
547
548 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
549 (EMACS_UINTPTR): Likewise, with uintptr_t.
550
551 * lisp.h: Prefer 64-bit EMACS_INT if available.
552 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
553 on 32-bit hosts that have 64-bit int, so that they can access
554 large files.
555 However, temporarily disable this change unless the temporary
556 symbol WIDE_EMACS_INT is defined.
557
558 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
559
560 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
561 This removes an assumption that EMACS_INT and long are the same
562 width as pointers. The assumption is true for Emacs porting targets
563 now, but we want to make other targets possible.
564 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
565 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
566 In the rest of the code, change types of integers that hold casted
567 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
568 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
569 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
570 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
571 No need to cast type when ORing.
572 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
573 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
574 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
575 assume EMACS_INT is the same width as char *.
576 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
577 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
578 Remove no-longer-needed casts.
579 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
580 (xg_tool_bar_help_callback, xg_make_tool_item):
581 Use EMACS_INTPTR to hold an integer
582 that will be cast to void *; this can avoid a GCC warning
583 if EMACS_INT is not the same width as void *.
584 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
585 * xdisp.c (display_echo_area_1, resize_mini_window_1):
586 (current_message_1, set_message_1):
587 Use a local to convert to proper width without a cast.
588 * xmenu.c (dialog_selection_callback): Likewise.
589
590 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
591 Also, don't assume VALBITS / RAND_BITS is less than 5,
592 and don't rely on undefined behavior when shifting a 1 left into
593 the sign bit.
594 * lisp.h (get_random): Change signature to match.
595
596 * lread.c (hash_string): Use size_t, not int, for hash computation.
597 Normally we prefer signed values; but hashing is special, because
598 it's better to use unsigned division on hash table sizes so that
599 the remainder is nonnegative. Also, size_t is the natural width
600 for hashing into memory. The previous code used 'int', which doesn't
601 retain enough info to hash well into very large tables.
602 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
603
604 * dbusbind.c: Don't possibly lose pointer info when converting.
605 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
606 Use XPNTR rather than XHASH, so that the high-order bits of
607 the pointer aren't lost when converting through void *.
608
609 * eval.c (Fautoload): Don't double-shift a pointer.
610
611 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
612
613 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
614
615 * gnutls.c (DEF_GNUTLS_FN):
616 * image.c (DEF_IMGLIB_FN): Make function pointers static.
617
618 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
619
620 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
621 marker. (Bug#8610)
622
623 2011-05-05 Eli Zaretskii <eliz@gnu.org>
624
625 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
626 New version that can reserve upto 2GB of heap space.
627
628 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
629
630 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
631
632 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
633
634 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
635 `gnutls_certificate_set_x509_key_file'.
636
637 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
638
639 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
640 Update dependencies.
641
642 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
643
644 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
645 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
646 Remove unused parameter `fildes'.
647 * process.c (read_process_output, send_process): Don't pass it.
648
649 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
650
651 Fix previous change: the library cache is defined in w32.c.
652 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
653 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
654
655 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
656
657 Implement dynamic loading of GnuTLS on Windows.
658
659 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
660 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
661 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
662 Declare.
663
664 * gnutls.c (Qgnutls_dll): Define.
665 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
666 (gnutls_*): Declare function pointers.
667 (init_gnutls_functions): New function to initialize function pointers.
668 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
669 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
670 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
671 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
672 (emacs_gnutls_write, emacs_gnutls_read)
673 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
674 (Fgnutls_available_p): New function.
675 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
676 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
677 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
678
679 * image.c: Include w32.h.
680 (Vimage_type_cache): Delete.
681 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
682 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
683 (w32_delayed_load): Move to w32.c.
684
685 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
686
687 * w32.c (QCloaded_from, Vlibrary_cache): Define.
688 (w32_delayed_load): Move from image.c. When loading a library, record
689 its filename in the :loaded-from property of the library id.
690 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
691 Initialize and staticpro them.
692 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
693
694 * process.c: Include lisp.h before w32.h, not after.
695 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
696 instead of gnutls_record_check_pending.
697
698 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
699
700 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
701
702 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
703 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
704 as passed in.
705
706 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
707
708 * xterm.c (x_set_frame_alpha): Do not set property on anything
709 else than FRAME_X_OUTER_WINDOW (Bug#8608).
710
711 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
712
713 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
714
715 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
716
717 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
718 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
719 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
720 (gnutls_global_initialized, Qgnutls_bootprop_priority)
721 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
722 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
723 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
724 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
725 (Qgnutls_bootprop_callbacks_verify): Make static.
726
727 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
728
729 * callproc.c: Indentation fixup.
730
731 * sysdep.c (wait_for_termination_1): Make static.
732 (wait_for_termination, interruptible_wait_for_termination):
733 Move after wait_for_termination_1.
734
735 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
736
737 * sysdep.c (interruptible_wait_for_termination): New function
738 which is like wait_for_termination, but allows keyboard
739 interruptions.
740
741 * callproc.c (Fcall_process): Add (:file "file") as an option for
742 the STDOUT buffer.
743 (Fcall_process_region): Ditto.
744
745 2011-04-30 Eli Zaretskii <eliz@gnu.org>
746
747 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
748 rather than `XVECTOR (FOO)->size'.
749
750 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
751 inttypes.h, as a gnulib replacement is used if it not available in
752 system headers.
753
754 2011-04-21 Eli Zaretskii <eliz@gnu.org>
755
756 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
757 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
758 of MOST_POSITIVE_FIXNUM. (Bug#8528)
759
760 * coding.c (coding_alloc_by_realloc): Error out if destination
761 will grow beyond MOST_POSITIVE_FIXNUM.
762 (decode_coding_emacs_mule): Abort if there isn't enough place in
763 charbuf for the composition carryover bytes. Reserve an extra
764 space for up to 2 characters produced in a loop.
765 (decode_coding_iso_2022): Abort if there isn't enough place in
766 charbuf for the composition carryover bytes.
767
768 2011-04-21 Eli Zaretskii <eliz@gnu.org>
769
770 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
771 aborting when %lld or %lll format is passed.
772 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
773 %llo or %llx format is passed. (Bug#8545)
774
775 * window.c (window_scroll_line_based): Use a marker instead of
776 simple variables to record original value of point. (Bug#7952)
777
778 * doprnt.c (doprnt): Fix the case where a multibyte sequence
779 produced by %s or %c overflows available buffer space. (Bug#8545)
780
781 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
782
783 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
784 (SIZE_MAX): Move defn after all includes, as they might #define it.
785
786 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
787
788 * w32.c (init_environment): Warn about defaulting HOME to C:\.
789
790 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
791
792 * keyboard.c (Qdelayed_warnings_hook): Define.
793 (command_loop_1): Run `delayed-warnings-hook'
794 if Vdelayed_warnings_list is non-nil.
795 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
796 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
797
798 2011-04-28 Eli Zaretskii <eliz@gnu.org>
799
800 * doprnt.c (doprnt): Don't return value smaller than the buffer
801 size if the message was truncated. (Bug#8545).
802
803 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
804
805 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
806 (Fx_window_property): #if-0 the whole functions, not just the bodies.
807
808 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
809
810 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
811
812 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
813
814 * makefile.w32-in: Update dependencies.
815
816 2011-04-27 Eli Zaretskii <eliz@gnu.org>
817
818 Improve `doprnt' and its usage. (Bug#8545)
819 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
820 `format_end'. Remove support for %l as a conversion specifier.
821 Don't use xrealloc. Improve diagnostics when the %l size modifier
822 is used. Update the commentary.
823
824 * eval.c (verror): Simplify calculation of size_t.
825
826 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
827 messages.
828
829 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
830
831 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
832 change.
833
834 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
835
836 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
837 This makes this file independent of the recent pseudovector change.
838
839 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
840
841 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
842
843 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
844 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
845 Remove unused local.
846 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
847
848 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
849 GCC 4.6.0 optimizes based on type-based alias analysis.
850 For example, if b is of type struct buffer * and v of type struct
851 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
852 != &v->size, and therefore "v->size = 1; b->size = 2; return
853 v->size;" must therefore return 1. This assumption is incorrect
854 for Emacs, since it type-puns struct Lisp_Vector * with many other
855 types. To fix this problem, this patch adds a new type struct
856 vectorlike_header that documents the constraints on layout of vectors
857 and pseudovectors, and helps optimizing compilers not get fooled
858 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
859 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
860 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
861 the size member.
862 (XSETPVECTYPE): Rewrite in terms of new macro.
863 (XSETPVECTYPESIZE): New macro, specifying both type and size.
864 This is a bit clearer, and further avoids the possibility of
865 undesirable aliasing.
866 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
867 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
868 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
869 since Lisp_Subr is a special case (no "next" field).
870 (ASIZE): Now uses header.size rather than size.
871 All previous uses of XVECTOR (foo)->size replaced to use this macro,
872 to avoid the hassle of writing XVECTOR (foo)->header.size.
873 (struct vectorlike_header): New type.
874 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
875 object, to help avoid aliasing.
876 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
877 (SUBRP): Likewise, since Lisp_Subr is a special case.
878 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
879 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
880 (struct Lisp_Hash_Table): Combine first two members into a single
881 struct vectorlike_header member. All uses of "size" and "next" members
882 changed to be "header.size" and "header.next".
883 * buffer.h (struct buffer): Likewise.
884 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
885 * frame.h (struct frame): Likewise.
886 * process.h (struct Lisp_Process): Likewise.
887 * termhooks.h (struct terminal): Likewise.
888 * window.c (struct save_window_data, struct saved_window): Likewise.
889 * window.h (struct window): Likewise.
890 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
891 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
892 * buffer.c (init_buffer_once): Likewise.
893 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
894 special case.
895 * process.c (Fformat_network_address): Use local var for size,
896 for brevity.
897
898 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
899
900 Make the Lisp reader and string-to-float more consistent (Bug#8525)
901 * data.c (atof): Remove decl; no longer used or needed.
902 (digit_to_number): Move to lread.c.
903 (Fstring_to_number): Use new string_to_number function, to be
904 consistent with how the Lisp reader treats infinities and NaNs.
905 Do not assume that floating-point numbers represent EMACS_INT
906 without losing information; this is not true on most 64-bit hosts.
907 Avoid double-rounding errors, by insisting on integers when
908 parsing non-base-10 numbers, as the documentation specifies.
909 * lisp.h (string_to_number): New decl, replacing ...
910 (isfloat_string): Remove.
911 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
912 (read1): Do not accept +. and -. as integers; this
913 appears to have been a coding error. Similarly, do not accept
914 strings like +-1e0 as floating point numbers. Do not report
915 overflow for integer overflows unless the base is not 10 which
916 means we have no simple and reliable way to continue.
917 Break out the floating-point parsing into a new
918 function string_to_number, so that Fstring_to_number parses
919 floating point numbers consistently with the Lisp reader.
920 (digit_to_number): Move here from data.c. Make it static inline.
921 (E_CHAR, EXP_INT): Remove, replacing with ...
922 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
923 (string_to_number): New function, replacing isfloat_string.
924 This function checks for valid syntax and produces the resulting
925 Lisp float number too. Rework it so that string-to-number
926 no longer mishandles examples like "1.0e+". Use strtoumax,
927 so that overflow for non-base-10 numbers is reported only when
928 there's no portable and simple way to convert to floating point.
929
930 * textprop.c (set_text_properties_1): Rewrite for clarity,
931 and to avoid GCC warning about integer overflow.
932
933 * intervals.h (struct interval): Use EMACS_INT for members
934 where EMACS_UINT might cause problems. See
935 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
936 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
937 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
938 All uses changed.
939 (offset_intervals): Tell GCC not to worry about length overflow
940 when negating a negative length.
941
942 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
943 (overrun_check_free): Likewise.
944
945 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
946 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
947 word size.
948
949 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
950 (gnutls_make_error): Rename local to avoid shadowing.
951 (gnutls_emacs_global_deinit): ifdef out; not used.
952 (Fgnutls_boot): Use const for pointer to readonly storage.
953 Comment out unused local. Fix pointer signedness problems.
954
955 * lread.c (openp): Don't stuff size_t into an 'int'.
956 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
957 about possible signed overflow.
958
959 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
960 (GDK_KEY_g): Don't define if already defined.
961 (xg_prepare_tooltip): Avoid pointer signedness problem.
962 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
963
964 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
965 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
966
967 * xfns.c (Fx_window_property): Simplify a bit,
968 to make a bit faster and to avoid GCC 4.6.0 warning.
969 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
970
971 * fns.c (internal_equal): Don't assume size_t fits in int.
972
973 * alloc.c (compact_small_strings): Tighten assertion a little.
974
975 Replace pEd with more-general pI, and fix some printf arg casts.
976 * lisp.h (pI): New macro, generalizing old pEd macro to other
977 conversion specifiers. For example, use "...%"pI"d..." rather
978 than "...%"pEd"...".
979 (pEd): Remove. All uses replaced with similar uses of pI.
980 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
981 * alloc.c (check_pure_size): Don't overflow by converting size to int.
982 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
983 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
984 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
985 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
986 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
987 64-bit hosts.
988 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
989 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
990 * print.c (safe_debug_print, print_object): Likewise.
991 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
992 to int.
993 Use pI instead of if-then-else-abort. Use %p to avoid casts,
994 avoiding the 0 flag, which is not portable.
995 * process.c (Fmake_network_process): Use pI to avoid cast.
996 * region-cache.c (pp_cache): Likewise.
997 * xdisp.c (decode_mode_spec): Likewise.
998 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
999 behavior on 64-bit hosts with printf arg.
1000 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1001 (x_stop_queuing_selection_requests): Likewise.
1002 (x_get_window_property): Don't truncate byte count to an 'int'
1003 when tracing.
1004
1005 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1006 here, since it parses constructs like leading '-' and spaces,
1007 which are not wanted; and it overflows with large numbers.
1008 Instead, simply match F[0-9]+, which is what is wanted anyway.
1009
1010 * alloc.c: Remove unportable assumptions about struct layout.
1011 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1012 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1013 (allocate_vectorlike, make_pure_vector): Use the new macros,
1014 plus offsetof, to remove unportable assumptions about struct layout.
1015 These assumptions hold on all porting targets that I know of, but
1016 they are not guaranteed, they're easy to remove, and removing them
1017 makes further changes easier.
1018
1019 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1020 This doesn't fix a bug but makes the code clearer.
1021 (string_overrun_cookie): Now const. Use initializers that
1022 don't formally overflow signed char, to avoid warnings.
1023 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1024 can cause Emacs to crash when string overrun checking is enabled.
1025 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1026 multiple of sizeof (EMACS_INT); it need not be, if
1027 alignof(EMACS_INT) < sizeof (EMACS_INT).
1028 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1029
1030 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1031
1032 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1033
1034 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1035
1036 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1037 supposed to be handshaking. (Bug#8556)
1038 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1039
1040 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1041
1042 * lisp.h (Qdebug): List symbol.
1043 * eval.c (Qdebug): Restore global linkage.
1044 * keyboard.c (debug-on-event): New variable.
1045 (handle_user_signal): Break into debugger when debug-on-event
1046 matches the current signal symbol.
1047
1048 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1049
1050 * alloc.c (check_sblock, check_string_bytes)
1051 (check_string_free_list): Convert to standard C.
1052
1053 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1054
1055 * w32.c (emacs_gnutls_push): Fix typo.
1056
1057 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1058
1059 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1060 "cast to pointer from integer of different size".
1061
1062 Improve doprnt and its use in verror. (Bug#8545)
1063 * doprnt.c (doprnt): Document the set of format control sequences
1064 supported by the function. Use SAFE_ALLOCA instead of always
1065 using `alloca'.
1066
1067 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1068 is one byte too soon. Don't use xrealloc; instead xfree and
1069 xmalloc anew.
1070
1071 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1072
1073 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1074 callbacks stage.
1075
1076 * gnutls.c: Renamed global_initialized to
1077 gnutls_global_initialized. Added internals for the
1078 :verify-hostname-error, :verify-error, and :verify-flags
1079 parameters of `gnutls-boot' and documented those parameters in the
1080 docstring. Start callback support.
1081 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1082 unless a fatal error occured. Call gnutls_alert_send_appropriate
1083 on error. Return error code.
1084 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1085 (emacs_gnutls_read): Likewise.
1086 (Fgnutls_boot): Return handshake error code.
1087 (emacs_gnutls_handle_error): New function.
1088 (wsaerror_to_errno): Likewise.
1089
1090 * w32.h (emacs_gnutls_pull): Add prototype.
1091 (emacs_gnutls_push): Likewise.
1092
1093 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1094 (emacs_gnutls_push): Likewise.
1095
1096 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1097
1098 * process.c (wait_reading_process_output): Check if GnuTLS
1099 buffered some data internally if no FDs are set for TLS
1100 connections.
1101
1102 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1103 (LIBS): Link to USER_LIBS.
1104 ($(BLD)/gnutls.$(0)): New target.
1105
1106 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1107
1108 * xdisp.c (handle_single_display_spec): Rename the
1109 display_replaced_before_p argument into display_replaced_p, to
1110 make it consistent with the commentary. Fix typos in the
1111 commentary.
1112
1113 * textprop.c (syms_of_textprop): Remove dead code.
1114 (copy_text_properties): Delete obsolete commentary about an
1115 interface that was deleted long ago. Fix typos in the description
1116 of arguments.
1117
1118 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1119 to changes in oldXMenu/XMenu.h from 2011-04-16.
1120 <menu_help_message, prev_menu_help_message>: Constify.
1121 (IT_menu_make_room): menu->help_text is now `const char **';
1122 adjust.
1123
1124 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1125 to changes in oldXMenu/XMenu.h from 2011-04-16.
1126 (struct XMenu): Declare `help_text' `const char **'.
1127
1128 * xfaces.c <Qunspecified>: Make extern again.
1129
1130 * syntax.c: Include sys/types.h before including regex.h, as
1131 required by Posix.
1132
1133 * doc.c (get_doc_string): Improve the format passed to `error'.
1134
1135 * doprnt.c (doprnt): Improve commentary.
1136
1137 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1138
1139 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1140 them with etags.
1141
1142 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1143 changes in globals.h immediately force recompilation.
1144 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1145 $(CURDIR)/s/ms-w32.h.
1146 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1147
1148 * character.c (Fchar_direction): Function deleted.
1149 (syms_of_character): Don't defsubr it.
1150 <char-direction-table>: Deleted.
1151
1152 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1153
1154 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1155 * doprnt.c: Include limits.h.
1156 (SIZE_MAX): New macro.
1157 (doprnt): Return a size_t value. 2nd arg is now size_t.
1158 Many local variables are now size_t instead of int or unsigned.
1159 Improve overflow protection. Support `l' modifier for integer
1160 conversions. Support %l conversion. Don't assume an EMACS_INT
1161 argument for integer conversions and for %c.
1162
1163 * lisp.h (doprnt): Restore prototype.
1164
1165 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1166 $(SRC)/character.h.
1167
1168 * Makefile.in (base_obj): Add back doprnt.o.
1169
1170 * deps.mk (doprnt.o): Add back prerequisites.
1171 (callint.o): Depend on character.h.
1172
1173 * eval.c (internal_lisp_condition_case): Include the handler
1174 representation in the error message.
1175 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1176 when breaking from the loop.
1177
1178 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1179
1180 * callint.c (Fcall_interactively): When displaying error message
1181 about invalid control letter, pass the character's codepoint, not
1182 a pointer to its multibyte form. Improve display of the character
1183 in octal and display also its hex code.
1184
1185 * character.c (char_string): Use %x to display the (unsigned)
1186 codepoint of an invalid character, to avoid displaying a bogus
1187 negative value.
1188
1189 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1190 `error', not SYMBOL_NAME itself.
1191
1192 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1193 character arguments to `error'.
1194
1195 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1196 to `error' in error message about FINAL_CHAR argument. Make sure
1197 FINAL_CHAR is a character, and use %c when it is passed as
1198 argument to `error'.
1199
1200 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1201
1202 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1203
1204 * w32.c: Include <time.h>.
1205 (sys_localtime): New function.
1206
1207 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1208
1209 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1210
1211 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1212
1213 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1214
1215 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1216 zombies (Bug#8467).
1217
1218 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1219
1220 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1221 gl_state.e_property when gl_state.object is Qt.
1222
1223 * insdel.c (make_gap_larger): Remove limitation of buffer size
1224 to <= INT_MAX.
1225
1226 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1227
1228 * xdisp.c (lookup_glyphless_char_display)
1229 (produce_glyphless_glyph): Handle cons cell entry in
1230 glyphless-char-display.
1231 (Vglyphless_char_display): Document it.
1232
1233 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1234 glyphless-char-display.
1235
1236 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1237
1238 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1239
1240 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1241
1242 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1243 definition for no-X builds.
1244
1245 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1246
1247 Static checks with GCC 4.6.0 and non-default toolkits.
1248
1249 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1250
1251 * process.c (keyboard_bit_set): Define only if SIGIO.
1252 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1253 (send_process): Repair possible setjmp clobbering.
1254
1255 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1256
1257 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1258
1259 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1260
1261 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1262 Define only if needed.
1263
1264 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1265 by pacifying GCC about it. Maybe it's time to retire it?
1266 * xfaces.c (USG, __TIMEVAL__): Likewise.
1267
1268 * dispextern.h (struct redisplay_interface): Rename param
1269 to avoid shadowing.
1270 * termhooks.h (struct terminal): Likewise.
1271 * xterm.c (xembed_send_message): Likewise.
1272
1273 * insdel.c (make_gap_smaller): Define only if
1274 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1275
1276 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1277 it.
1278
1279 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1280 so that we aren't warned about unused symbols.
1281
1282 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1283
1284 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1285
1286 * xfns.c (x_real_positions): Mark locals as initialized.
1287
1288 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1289
1290 * xterm.c: Fix problems found by static analysis with other toolkits.
1291 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1292 (x_dispatch_event): Declare static if USE_GTK, and
1293 define if USE_GTK || USE_X_TOOLKIT.
1294 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1295 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1296 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1297 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1298
1299 * xmenu.c (menu_help_callback): Pointer type fixes.
1300 Use const pointers when pointing at readonly data. Avoid pointer
1301 signedness clashes.
1302 (FALSE): Remove unused macro.
1303 (update_frame_menubar): Remove unused decl.
1304
1305 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1306
1307 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1308 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1309 (single_menu_item): Rename local to avoid shadowing.
1310
1311 * keyboard.c (make_lispy_event): Remove unused local var.
1312
1313 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1314 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1315
1316 * bitmaps: Change bitmaps from unsigned char back to the X11
1317 compatible char. Avoid the old compiler warnings about
1318 out-of-range initializers by using, for example, '\xab' rather
1319 than 0xab.
1320
1321 * xgselect.c (xgselect_initialize): Check vs interface
1322 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1323
1324 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1325
1326 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1327 to read-only memory.
1328
1329 * fns.c (vector): Remove; this old hack is no longer needed.
1330
1331 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1332 Remove unused var.
1333 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1334
1335 * xrdb.c (x_load_resources): Omit unused local.
1336
1337 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1338 (x_window): Rename locals to avoid shadowing.
1339 (USG): Use the kludged USG macro, to pacify gcc.
1340
1341 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1342 (x_term_init): Remove local to avoid shadowing.
1343
1344 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1345
1346 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1347 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1348
1349 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1350
1351 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1352
1353 Fix regex.c, syntax.c and friends for buffers > 2GB.
1354 * syntax.h (struct gl_state_s): Declare character position members
1355 EMACS_INT.
1356
1357 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1358
1359 * textprop.c (verify_interval_modification, interval_of):
1360 Declare arguments EMACS_INT.
1361
1362 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1363 EMACS_INT.
1364
1365 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1366
1367 * indent.c (Fvertical_motion): Local variable it_start is now
1368 EMACS_INT.
1369
1370 * regex.c (re_match, re_match_2, re_match_2_internal)
1371 (bcmp_translate, regcomp, regexec, print_double_string)
1372 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1373 (re_compile_pattern, re_exec): Declare arguments and local
1374 variables `size_t' and `ssize_t' and return values `regoff_t', as
1375 appropriate.
1376 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1377 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1378 <compile_stack_type>: `size' and `avail' are now `size_t'.
1379
1380 * regex.h <regoff_t>: Use ssize_t, not int.
1381 (re_search, re_search_2, re_match, re_match_2): Arguments that
1382 specify buffer/string position and length are now ssize_t and
1383 size_t. Return type is regoff_t.
1384
1385 2011-04-16 Ben Key <bkey76@gmail.com>
1386
1387 * nsfont.m: Fixed bugs in ns_get_family and
1388 ns_descriptor_to_entity that were caused by using free to
1389 deallocate memory blocks that were allocated by xmalloc (via
1390 xstrdup). This caused Emacs to crash when compiled with
1391 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1392 --enable-checking=xmallocoverrun). xfree is now used to
1393 deallocate these memory blocks.
1394
1395 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1398
1399 emacs_write: Accept and return EMACS_INT for sizes.
1400 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1401 et seq.
1402 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1403 Accept and return EMACS_INT.
1404 (emacs_gnutls_write): Return the number of bytes written on
1405 partial writes.
1406 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1407 (emacs_read, emacs_write): Remove check for negative size, as the
1408 Emacs source code has been audited now.
1409 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1410 (emacs_read, emacs_write): Use it.
1411 * process.c (send_process): Adjust to the new signatures of
1412 emacs_write and emacs_gnutls_write. Do not attempt to store
1413 a byte offset into an 'int'; it might overflow.
1414 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1415
1416 * sound.c: Don't assume sizes fit in 'int'.
1417 (struct sound_device.period_size, alsa_period_size):
1418 Return EMACS_INT, not int.
1419 (struct sound_device.write, vox_write, alsa_write):
1420 Accept EMACS_INT, not int.
1421 (wav_play, au_play): Use EMACS_INT to store sizes and to
1422 record read return values.
1423
1424 2011-04-15 Ben Key <bkey76@gmail.com>
1425
1426 * keyboard.c (Qundefined): Don't declare static since it is used
1427 in nsfns.m.
1428 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1429 static since they are used in nsfont.m.
1430
1431 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1432
1433 * process.c (Qprocessp): Don't declare static.
1434 * lisp.h (Qprocessp): Declare again.
1435
1436 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1437
1438 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1439
1440 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 Improve C-level modularity by making more things 'static'.
1443
1444 Don't publish debugger-only interfaces to other modules.
1445 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1446 (verify_bytepos, count_markers): Move decls to the only modules
1447 that need them.
1448 * region-cache.h (pp_cache): Likewise.
1449 * window.h (check_all_windows): Likewise.
1450 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1451
1452 * sysdep.c (croak): Now static, if
1453 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1454 * syssignal.h (croak): Declare only if not static.
1455
1456 * alloc.c (refill_memory_reserve): Now static if
1457 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1458 * lisp.h (refill_memory_reserve): Declare only if not static.
1459
1460 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1461 Define only if USE_LUCID.
1462
1463 * xrdb.c (x_customization_string, x_rm_string): Now static.
1464
1465 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1466 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1467
1468 * xdisp.c (draw_row_with_mouse_face): Now static.
1469 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1470
1471 * window.h (check_all_windows): Mark externally visible.
1472
1473 * window.c (window_deletion_count): Now static.
1474
1475 * undo.c: Make symbols static if they're not exported.
1476 (last_undo_buffer, last_boundary_position, pending_boundary):
1477 Now static.
1478
1479 * textprop.c (interval_insert_behind_hooks): Now static.
1480 (interval_insert_in_front_hooks): Likewise.
1481
1482 * term.c: Make symbols static if they're not exported.
1483 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1484 (max_frame_lines, tty_set_terminal_modes):
1485 (tty_reset_terminal_modes, tty_turn_off_highlight):
1486 (get_tty_terminal): Now static.
1487 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1488 * termhooks.h (term_mouse_moveto): Do not declare if
1489 HAVE_WINDOW_SYSTEM.
1490 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1491 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1492
1493 * sysdep.c: Make symbols static if they're not exported.
1494 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1495 Now static.
1496 (sigprocmask_set, full_mask): Remove; unused.
1497 (wait_debugging): Mark as visible.
1498 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1499 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1500
1501 * syntax.c (syntax_temp): Define only if !__GNUC__.
1502
1503 * sound.c (current_sound_device, current_sound): Now static.
1504
1505 * search.c (searchbufs, searchbuf_head): Now static.
1506
1507 * scroll.c (scroll_cost): Remove; unused.
1508 * dispextern.h (scroll_cost): Remove decl.
1509
1510 * region-cache.h (pp_cache): Mark as externally visible.
1511
1512 * process.c: Make symbols static if they're not exported.
1513 (process_tick, update_tick, create_process, chan_process):
1514 (Vprocess_alist, proc_buffered_char, datagram_access):
1515 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1516 (deactivate_process): Mark defn as static, as well as decl.
1517 * lisp.h (create_process): Remove decl.
1518 * process.h (chan_process, Vprocess_alist): Remove decls.
1519
1520 * print.c: Make symbols static if they're not exported.
1521 (print_depth, new_backquote_output, being_printed, print_buffer):
1522 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1523 (print_interval, print_number_index, initial_stderr_stream):
1524 Now static.
1525 * lisp.h (Fprinc): Remove decl.
1526 (debug_output_compilation_hack): Mark as externally visible.
1527
1528 * sysdep.c (croak): Move decl from here to syssignal.h.
1529 * syssignal.h (croak): Put it here, so the API can be checked when
1530 'croak' is called from dissociate_if_controlling_tty.
1531
1532 * minibuf.c: Make symbols static if they're not exported.
1533 (minibuf_save_list, choose_minibuf_frame): Now static.
1534 * lisp.h (choose_minibuf_frame): Remove decl.
1535
1536 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1537
1538 * lread.c: Make symbols static if they're not exported.
1539 (read_objects, initial_obarray, oblookup_last_bucket_number):
1540 Now static.
1541 (make_symbol): Remove; unused.
1542 * lisp.h (initial_obarray, make_symbol): Remove decls.
1543
1544 * keyboard.c: Make symbols static if they're not exported.
1545 (single_kboard, recent_keys_index, total_keys, recent_keys):
1546 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1547 (this_single_command_key_start, echoing, last_auto_save):
1548 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1549 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1550 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1551 (Vlispy_mouse_stem, double_click_count):
1552 Now static.
1553 (force_auto_save_soon): Define only if SIGDANGER.
1554 (ignore_mouse_drag_p): Now static if
1555 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1556 (print_help): Remove; unused.
1557 (stop_character, last_timer_event): Mark as externally visible.
1558 * keyboard.h (ignore_mouse_drag_p): Declare only if
1559 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1560 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1561 * lisp.h (echoing): Remove decl.
1562 (force_auto_save_soon): Declare only if SIGDANGER.
1563 * xdisp.c (redisplay_window): Simplify code, to make it more
1564 obvious that ignore_mouse_drag_p is not accessed if !defined
1565 USE_GTK && !defined HAVE_NS.
1566
1567 * intervals.c: Make symbols static if they're not exported.
1568 (merge_properties_sticky, merge_interval_right, delete_interval):
1569 Now static.
1570 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1571
1572 * insdel.c: Make symbols static if they're not exported.
1573 However, leave prepare_to_modify_buffer alone. It's never
1574 called from outside this function, but that appears to be a bug.
1575 (combine_after_change_list, combine_after_change_buffer):
1576 (adjust_after_replace, signal_before_change): Now static.
1577 (adjust_after_replace_noundo): Remove; unused.
1578 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1579 (signal_before_change): Remove decls.
1580
1581 * indent.c (val_compute_motion, val_vmotion): Now static.
1582
1583 * image.c: Make symbols static if they're not exported.
1584 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1585 if USE_GTK.
1586 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1587 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1588
1589 * fringe.c (standard_bitmaps): Now static.
1590 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1591
1592 * frame.c: Make symbols static if they're not exported.
1593 (x_report_frame_params, make_terminal_frame): Now static.
1594 (get_frame_param): Now static, unless HAVE_NS.
1595 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1596 (x_get_resource_string): Remove; not used.
1597 * frame.h (make_terminal_frame, x_report_frame_params):
1598 (x_get_resource_string); Remove decls.
1599 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1600 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1601
1602 * font.c, fontset.c: Make symbols static if they're not exported.
1603 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1604 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1605 * font.c (font_close_object): Now static.
1606 * font.h (font_close_object): Remove.
1607 * fontset.c (FONTSET_OBJLIST): Remove.
1608 (free_realized_fontset) #if-0 the body, which does nothing.
1609 (face_suitable_for_char_p): #if-0, as it's never called.
1610 * fontset.h (face_suitable_for_char_p): Remove decl.
1611 * xfaces.c (face_at_string_position):
1612 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1613 since 0 is always ASCII.
1614
1615 * fns.c (weak_hash_tables): Now static.
1616
1617 * fileio.c: Make symbols static if they're not exported.
1618 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1619 (Vwrite_region_annotation_buffers): Now static.
1620
1621 * eval.c: Make symbols static if they're not exported.
1622 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1623 * lisp.h (backtrace_list): Remove decl.
1624
1625 * emacs.c: Make symbols static if they're not exported.
1626 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1627 (fatal_error_code, fatal_error_signal_hook, standard_args):
1628 Now static.
1629 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1630 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1631 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1632 * lisp.h (fatal_error_signal_hook): Remove decl.
1633 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1634
1635 * editfns.c: Move a (normally-unused) function to its only use.
1636 * editfns.c, lisp.h (get_operating_system_release): Remove.
1637 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1638 worth the hassle of breaking this out.
1639
1640 * xterm.c: Make symbols static if they're not exported.
1641 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1642 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1643 (x_destroy_window, x_delete_display):
1644 Now static.
1645 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1646 (x_mouse_leave): Remove; unused.
1647 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1648 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1649 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1650 Remove decls.
1651 (x_mouse_leave): Declare only if WINDOWSNT.
1652 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1653 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1654 USE_X_TOOLKIT.
1655
1656 * ftxfont.c: Make symbols static if they're not exported.
1657 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1658 HAVE_FREETYPE.
1659 * font.h (ftxfont_driver): Likewise.
1660
1661 * xfns.c: Make symbols static if they're not exported.
1662 (x_last_font_name, x_display_info_for_name):
1663 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1664 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1665 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1666 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1667 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1668 (last_show_tip_args): Now static.
1669 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1670 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1671 (x_screen_planes): Remove; unused.
1672 * dispextern.h (x_screen_planes): Remove decl.
1673
1674 * dispnew.c: Make symbols static if they're not exported.
1675 * dispextern.h (redraw_garbaged_frames, scrolling):
1676 (increment_row_positions): Remove.
1677 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1678 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1679 Now static.
1680 (redraw_garbaged_frames): Remove; unused.
1681
1682 * xfaces.c: Make symbols static if they're not exported.
1683 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1684 Remove decls.
1685 * xterm.h (defined_color): Remove decls.
1686 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1687 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1688 (menu_face_changed_default, defined_color, free_realized_face):
1689 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1690 (ascii_face_of_lisp_face): Remove; unused.
1691
1692 * xdisp.c: Make symbols static if they're not exported.
1693 * dispextern.h (scratch_glyph_row, window_box_edges):
1694 (glyph_to_pixel_coords, set_cursor_from_row):
1695 (get_next_display_element, set_iterator_to_next):
1696 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1697 (show_mouse_face): Remove decls
1698 * frame.h (message_buf_print): Likewise.
1699 * lisp.h (pop_message, set_message, check_point_in_composition):
1700 Likewise.
1701 * xterm.h (set_vertical_scroll_bar): Likewise.
1702 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1703 (message_buf_print, scratch_glyph_row, displayed_buffer):
1704 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1705 (get_next_display_element, show_mouse_face, window_box_edges):
1706 (frame_to_window_pixel_xy, check_point_in_composition):
1707 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1708 (glyph_to_pixel_coords): Remove; unused.
1709
1710 * dired.c (file_name_completion): Now static.
1711
1712 * dbusbind.c (xd_in_read_queued_messages): Now static.
1713
1714 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1715 * data.c (circular_list_error): Remove.
1716
1717 * commands.h (last_point_position, last_point_position_buffer):
1718 (last_point_position_window): Remove decls.
1719 * keyboard.c: Make these variables static.
1720
1721 * coding.h (coding, code_convert_region, encode_coding_gap):
1722 Remove decls.
1723 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1724 (iso_code_class, detect_coding, code_convert_region): Now static.
1725 (encode_coding_gap): Remove; unused.
1726
1727 * chartab.c (chartab_chars, chartab_bits): Now static.
1728
1729 * charset.h (charset_iso_8859_1): Remove decl.
1730 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1731 Now static.
1732
1733 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1734 * ccl.c (Vccl_program_table): Now static.
1735 (check_ccl_update): Remove; unused.
1736
1737 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1738 * category.h: ... from here.
1739 * category.c (check_category_table, set_category_set): Now static.
1740
1741 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1742 * lisp.h: Remove these decls.
1743
1744 * buffer.c (buffer_count): Remove unused var.
1745
1746 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1747 so that it's not optimized away.
1748 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1749 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1750 exported only to the debugger.
1751
1752 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1753 * atimer.h (run_all_atimers): Remove; not exported.
1754
1755 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1756 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1757 was inaccessible from Lisp.
1758 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1759 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1760
1761 alloc.c: Import and export fewer symbols, and remove unused items.
1762 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1763 is defined.
1764 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1765 it's not optimized away by whole-program optimization.
1766 (message_enable_multibyte, free_misc): Remove.
1767 (catchlist, handlerlist, mark_backtrace):
1768 Declare only if BYTE_MARK_STACK.
1769 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1770 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1771 (message_enable_multibyte): Remove decl.
1772 (free_misc, interval_free_list, float_block, float_block_index):
1773 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1774 (cons_free_list, last_marked_index):
1775 Now static.
1776 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1777 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1778 (mark_backtrace): Define only if BYTE_MARK_STACK.
1779 * xdisp.c (message_enable_multibyte): Now static.
1780
1781 Declare Lisp_Object Q* variables to be 'static' if not exported.
1782 This makes it easier for human readers (and static analyzers)
1783 to see whether these variables are used from other modules.
1784 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1785 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1786 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1787 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1788 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1789 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1790 * xmenu.c, xselect.c:
1791 Declare Q* vars static if they are not used in other modules.
1792 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1793 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1794 Remove decls of unexported vars.
1795 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1796
1797 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1798
1799 Make Emacs functions such as Fatom 'static' by default.
1800 This makes it easier for human readers (and static analyzers)
1801 to see whether these functions can be called from other modules.
1802 DEFUN now defines a static function. To make the function external
1803 so that it can be used in other C modules, use the new macro DEFUE.
1804 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1805 (Finit_image_library):
1806 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1807 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1808 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1809 Remove decls, since these functions are now static.
1810 (Funintern, Fget_internal_run_time): New decls, since these functions
1811 were already external.
1812
1813 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1814 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1815 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1816 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1817 * keyboard.c, keymap.c, lread.c:
1818 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1819 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1820 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1821 Mark functions with DEFUE instead of DEFUN,
1822 if they are used in other modules.
1823 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1824 decls for now-static functions.
1825 * buffer.h (Fdelete_overlay): Remove decl.
1826 * callproc.c (Fgetenv_internal): Mark as internal.
1827 * composite.c (Fremove_list_of_text_properties): Remove decl.
1828 (Fcomposition_get_gstring): New forward static decl.
1829 * composite.h (Fcomposite_get_gstring): Remove decl.
1830 * dired.c (Ffile_attributes): New forward static decl.
1831 * doc.c (Fdocumntation_property): New forward static decl.
1832 * eval.c (Ffetch_bytecode): New forward static decl.
1833 (Funintern): Remove extern decl; now in .h file where it belongs.
1834 * fileio.c (Fmake_symbolic_link): New forward static decl.
1835 * image.c (Finit_image_library): New forward static decl.
1836 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1837 * intervals.h (Fprevious_property_change):
1838 (Fremove_list_of_text_properties): Remove decls.
1839 * keyboard.c (Fthis_command_keys): Remove decl.
1840 (Fcommand_execute): New forward static decl.
1841 * keymap.c (Flookup_key): New forward static decl.
1842 (Fcopy_keymap): Now static.
1843 * keymap.h (Flookup_key): Remove decl.
1844 * process.c (Fget_process): New forward static decl.
1845 (Fprocess_datagram_address): Mark as internal.
1846 * syntax.c (Fsyntax_table_p): New forward static decl.
1847 (skip_chars): Remove duplicate decl.
1848 * textprop.c (Fprevious_property_change): New forward static decl.
1849 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1850 Now internal.
1851 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1852 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1853
1854 * editfns.c (Fformat): Remove unreachable code.
1855
1856 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1857
1858 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1859 change. (Bug#8496)
1860
1861 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1862
1863 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1864 when at ZV. (Bug#8487)
1865
1866 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1867
1868 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1869 (Bug#8437)
1870 * keyboard.c (parse_tool_bar_item): Likewise.
1871 * sound.c (sound_cleanup, alsa_close): Likewise.
1872 * termcap.c (tgetent): Likewise.
1873 * xfns.c (x_default_font_parameter): Likewise.
1874 * xsettings.c (read_and_apply_settings): Likewise.
1875
1876 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1877 (overrun_check_free): Protoize.
1878
1879 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1880
1881 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1882 since callers should never pass a negative size.
1883 Change the signature to match that of plain 'read' and 'write'; see
1884 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1885 * lisp.h: Update prototypes of emacs_write and emacs_read.
1886
1887 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1888
1889 * xdisp.c (redisplay_window): Don't try to determine the character
1890 position of the scroll margin if the window start point w->startp
1891 is outside the buffer's accessible region. (Bug#8468)
1892
1893 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1894
1895 Fix write-region and its subroutines for buffers > 2GB.
1896 * fileio.c (a_write, e_write): Modify declaration of arguments and
1897 local variables to support buffers larger than 2GB.
1898 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1899
1900 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1901 argument, local variables, and return value.
1902
1903 * lisp.h: Update prototypes of emacs_write and emacs_read.
1904
1905 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1906
1907 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1910
1911 Fix more problems found by GCC 4.6.0's static checks.
1912
1913 * xdisp.c (vmessage): Use a better test for character truncation.
1914
1915 * charset.c (load_charset_map): <, not <=, for optimization,
1916 and to avoid potential problems with integer overflow.
1917 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1918 * casetab.c (set_identity, shuffle): Likewise.
1919 * editfns.c (Fformat): Likewise.
1920 * syntax.c (skip_chars): Likewise.
1921
1922 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1923 This also lets GCC 4.6.0 generate slightly better loop code.
1924
1925 * callint.c (Fcall_interactively): <, not <=, for optimization.
1926 (Fcall_interactively): Count the number of arguments produced,
1927 not the number of arguments given. This is simpler and lets GCC
1928 4.6.0 generate slightly better code.
1929
1930 * ftfont.c: Distingish more carefully between FcChar8 and char.
1931 The previous code passed unsigned char * to a functions like
1932 strlen and xstrcasecmp that expect char *, which does not
1933 conform to the C standard.
1934 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1935 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1936 char * when the C standard requires it.
1937
1938 * keyboard.c (read_char): Remove unused var.
1939
1940 * eval.c: Port to Windows vsnprintf (Bug#8435).
1941 Include <limits.h>.
1942 (SIZE_MAX): Define if the headers do not.
1943 (verror): Do not give up if vsnprintf returns a negative count.
1944 Instead, grow the buffer. This ports to Windows vsnprintf, which
1945 does not conform to C99. Problem reported by Eli Zaretskii.
1946 Also, simplify the allocation scheme, by avoiding the need for
1947 calling realloc, and removing the ALLOCATED variable.
1948
1949 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1950
1951 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1952 But keep the doprint source code for now, as we might revamp it
1953 and use it again (Bug#8435).
1954 * lisp.h (doprnt): Remove.
1955 * Makefile.in (base_obj): Remove doprnt.o.
1956 * deps.mk (doprnt.o): Remove.
1957
1958 error: Print 32- and 64-bit integers portably (Bug#8435).
1959 Without this change, on typical 64-bit hosts error ("...%d...", N)
1960 was used to print both 32- and 64-bit integers N, which relied on
1961 undefined behavior.
1962 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1963 New macro.
1964 * lisp.h (error, verror): Mark as printf-like functions.
1965 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1966 Report overflow in size calculations when allocating printf buffer.
1967 Do not truncate output string at its first null byte.
1968 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1969 Truncate the output at a character boundary, since vsnprintf does not
1970 do that.
1971 * charset.c (check_iso_charset_parameter): Convert internal
1972 character to string before calling 'error', since %c now has the
1973 printf meaning.
1974 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1975 overflow when computing char to be passed to 'error'. Do not
1976 pass Lisp_Object to 'error'; pass the integer instead.
1977 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1978 formatted with plain %d.
1979
1980 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1981
1982 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1983
1984 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1985
1986 * xterm.c (x_catch_errors): Remove duplicate declaration.
1987
1988 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1989
1990 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1991
1992 2011-04-10 Jim Meyering <meyering@redhat.com>
1993
1994 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1995 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1996 return ssize_t not "int", and use size_t as the buffer length.
1997 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1998 * gnutls.h: Update declarations.
1999 * process.c (read_process_output): Use ssize_t, to match.
2000 (send_process): Likewise.
2001
2002 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2003
2004 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2005
2006 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2007
2008 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2009 Use unsigned char, to match FcChar8 type definition.
2010
2011 * xterm.c (handle_one_xevent):
2012 * xmenu.c (create_and_show_popup_menu):
2013 * xselect.c (x_decline_selection_request)
2014 (x_reply_selection_request): Avoid type-punned deref of X events.
2015
2016 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2017
2018 Fix some uses of `int' instead of EMACS_INT.
2019 * search.c (string_match_1, fast_string_match)
2020 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2021 (scan_buffer, find_next_newline_no_quit)
2022 (find_before_next_newline, search_command, Freplace_match)
2023 (Fmatch_data): Make some `int' variables be EMACS_INT.
2024
2025 * xdisp.c (display_count_lines): 3rd argument and return value now
2026 EMACS_INT. All callers changed.
2027 (pint2hrstr): Last argument is now EMACS_INT.
2028
2029 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2030 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2031 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2032 (decode_coding_utf_16, decode_coding_emacs_mule)
2033 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2034 (decode_coding_ccl, decode_coding_charset)
2035 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2036 (decode_coding_iso_2022, decode_coding_emacs_mule)
2037 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2038 <char_offset, last_offset>: Declare EMACS_INT.
2039 (encode_coding_utf_8, encode_coding_utf_16)
2040 (encode_coding_emacs_mule, encode_invocation_designation)
2041 (encode_designation_at_bol, encode_coding_iso_2022)
2042 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2043 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2044 Declare EMACS_INT.
2045 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2046 (encode_invocation_designation): Last argument P_NCHARS is now
2047 EMACS_INT.
2048 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2049 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2050
2051 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2052 All users changed.
2053
2054 * ccl.c (Fccl_execute_on_string): Declare some variables
2055 EMACS_INT.
2056
2057 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2058
2059 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2060
2061 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2062
2063 * process.c (Fformat_network_address): Doc fix.
2064
2065 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2066
2067 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2068
2069 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2070
2071 * keyboard.c (read_char): Call Lisp function help-form-show,
2072 instead of using internal_with_output_to_temp_buffer.
2073 (Qhelp_form_show): New var.
2074 (syms_of_keyboard): Use DEFSYM macro.
2075
2076 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2077
2078 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2079
2080 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2081
2082 * process.c (Flist_processes): Remove to Lisp.
2083 (list_processes_1): Delete.
2084
2085 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2086
2087 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2088
2089 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2090
2091 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2092
2093 Fix more problems found by GCC 4.6.0's static checks.
2094
2095 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2096
2097 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2098
2099 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2100
2101 * xdisp.c (vmessage): Mark as a printf-like function.
2102
2103 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2104
2105 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2106
2107 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2108 printf-like functions.
2109 (tiff_load): Add casts to remove these marks before passing them
2110 to system-supplied API.
2111
2112 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2113
2114 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2115 This avoids several warnings with gcc -Wstrict-overflow.
2116 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2117 directly, rather than having caller test rule sign. This avoids
2118 some unnecessary tests.
2119 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2120 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2121 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2122
2123 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2124 (xfont_open): Avoid unnecessary tests.
2125
2126 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2127
2128 * composite.h, composite.c (composition_gstring_put_cache):
2129 Use EMACS_INT, not int, for length.
2130
2131 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2132 breaking out part of COMPOSITION_DECODE_RULE.
2133 (COMPOSITION_DECODE_RULE): Use it.
2134 * composite.c (get_composition_id): Remove unused local vars,
2135 by using the new macro.
2136
2137 * textprop.c (set_text_properties_1): Change while to do-while,
2138 since the condition is always true at first.
2139
2140 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2141 (interval_deletion_adjustment): Return unsigned value.
2142 All uses changed.
2143
2144 * process.c (list_processes_1, create_pty, read_process_output):
2145 (exec_sentinel): Remove vars that were set but not used.
2146 (create_pty): Remove unnecessary "volatile"s.
2147 (Fnetwork_interface_info): Avoid possibility of int overflow.
2148 (read_process_output): Do adaptive read buffering even if carryover.
2149 (read_process_output): Simplify nbytes computation if buffered.
2150
2151 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2152
2153 * syntax.c (scan_words): Remove var that was set but not used.
2154 (update_syntax_table): Use unsigned instead of int.
2155
2156 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2157 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2158 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2159
2160 * print.c (print_error_message): Avoid int overflow.
2161
2162 * font.c (font_list_entities): Redo for clarity,
2163 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2164
2165 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2166 (font_score): Avoid potential overflow in diff calculation.
2167
2168 * fns.c (substring_both): Remove var that is set but not used.
2169 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2170
2171 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2172
2173 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2174 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2175 can always succeed if overflow has undefined behavior.
2176
2177 * search.c (boyer_moore, wordify): Remove vars set but not used.
2178 (wordify): Omit three unnecessary tests.
2179
2180 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2181 All callers changed. This avoids the need for an unused var.
2182
2183 * casefiddle.c (casify_region): Remove var that is set but not used.
2184
2185 * dired.c (file_name_completion): Remove var that is set but not used.
2186
2187 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2188
2189 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2190 (Finsert_file_contents): Remove unnecessary code checking fd.
2191
2192 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2193 Check for integer overflow on size calculations.
2194
2195 * buffer.c (Fprevious_overlay_change): Remove var that is set
2196 but not used.
2197
2198 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2199 Remove vars that are set but not used.
2200 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2201 (timer_check_2): Mark vars as initialized.
2202
2203 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2204
2205 * image.c (lookup_image): Remove var that is set but not used.
2206 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2207
2208 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2209 that are set but not used.
2210
2211 * xfns.c (make_invisible_cursor): Don't return garbage
2212 if XCreateBitmapFromData fails (Bug#8410).
2213
2214 * xselect.c (x_get_local_selection, x_handle_property_notify):
2215 Remove vars that are set but not used.
2216
2217 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2218 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2219
2220 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2221 Remove var that is set but not used.
2222 (scroll_bar_windows_size): Now size_t, not int.
2223 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2224 Check for overflow.
2225
2226 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2227 (map_tty_color) [!defined MSDOS]: Likewise.
2228
2229 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2230
2231 * coding.c: Remove vars that are set but not used.
2232 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2233 All callers changed.
2234 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2235 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2236 (decode_coding_charset): Remove vars that are set but not used.
2237
2238 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2239 that is set but not used.
2240
2241 * print.c (print_object): Remove var that is set but not used.
2242
2243 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2244 The gnulib version avoids calling malloc in the usual case,
2245 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2246 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2247 * filelock.c (current_lock_owner): Likewise.
2248 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2249 * sysdep.c: Include allocator.h, careadlinkat.h.
2250 (emacs_no_realloc_allocator): New static constant.
2251 (emacs_readlink): New function.
2252 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2253 ../lib/careadlinkat.h.
2254
2255 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2256
2257 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2258 first non-nil return value).
2259
2260 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2261
2262 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2263 if not defined (Bug#8403).
2264
2265 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2266
2267 * xdisp.c (display_count_lines): Remove parameter `start',
2268 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2269 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2270 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2271 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2272 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2273 and thereabouts. All callers changed.
2274 (get_per_char_metric): Remove parameter `f', unused since
2275 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2276
2277 2011-04-02 Jim Meyering <meyering@redhat.com>
2278
2279 do not dereference NULL upon failed strdup
2280 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2281 (ns_get_family): Likewise.
2282
2283 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2284
2285 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2286
2287 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2288
2289 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2290 later (Bug#8403).
2291
2292 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2293
2294 Add lexical binding.
2295
2296 * window.c (Ftemp_output_buffer_show): New fun.
2297 (Fsave_window_excursion):
2298 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2299
2300 * lread.c (lisp_file_lexically_bound_p): New function.
2301 (Fload): Bind Qlexical_binding.
2302 (readevalloop): Remove `evalfun' arg.
2303 Bind Qinternal_interpreter_environment.
2304 (Feval_buffer): Bind Qlexical_binding.
2305 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2306 Mark as dynamic.
2307 (syms_of_lread): Declare `lexical-binding'.
2308
2309 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2310
2311 * keyboard.c (eval_dyn): New fun.
2312 (menu_item_eval_property): Use it.
2313
2314 * image.c (parse_image_spec): Use Ffunctionp.
2315
2316 * fns.c (concat, mapcar1): Accept byte-code-functions.
2317
2318 * eval.c (Fsetq): Handle lexical vars.
2319 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2320 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2321 (FletX, Flet): Obey lexical binding.
2322 (Fcommandp): Handle closures.
2323 (Feval): New `lexical' arg.
2324 (eval_sub): New function extracted from Feval. Use it almost
2325 everywhere where Feval was used. Look up vars in lexical env.
2326 Handle closures.
2327 (Ffunctionp): Move from subr.el.
2328 (Ffuncall): Handle closures.
2329 (apply_lambda): Remove `eval_flags'.
2330 (funcall_lambda): Handle closures and new byte-code-functions.
2331 (Fspecial_variable_p): New function.
2332 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2333 but without exporting it to Lisp.
2334
2335 * doc.c (Fdocumentation, store_function_docstring):
2336 * data.c (Finteractive_form): Handle closures.
2337
2338 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2339 interactive spec.
2340
2341 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2342 New byte-codes.
2343 (exec_byte_code): New function extracted from Fbyte_code to handle new
2344 calling convention for byte-code-functions. Add new byte-codes.
2345
2346 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2347
2348 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2349
2350 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2351
2352 * xdisp.c (redisplay_internal): Fix prototype.
2353
2354 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2355
2356 * xdisp.c (SCROLL_LIMIT): New macro.
2357 (try_scrolling): Use it when setting scroll_limit.
2358 Limit scrolling to 100 screen lines.
2359 (redisplay_window): Even when falling back on "recentering",
2360 position point in the window according to scroll-conservatively,
2361 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2362
2363 (try_scrolling): When point is above the window, allow searching
2364 as far as scroll_max, or one screenful, to compute vertical
2365 distance from PT to the scroll margin position. This prevents
2366 try_scrolling from unnecessarily failing when
2367 scroll-conservatively is set to a value slightly larger than the
2368 window height. Clean up the case of PT below the margin at bottom
2369 of window: scroll_max can no longer be INT_MAX. When aggressive
2370 scrolling is in use, don't let point enter the opposite scroll
2371 margin as result of the scroll.
2372 (syms_of_xdisp) <scroll-conservatively>: Document the
2373 threshold of 100 lines for never-recentering scrolling.
2374
2375 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2376
2377 * dispextern.h (move_it_by_lines):
2378 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2379 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2380 (message_log_check_duplicate): Remove parameters `prev_bol' and
2381 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2382 (redisplay_internal): Remove parameter `preserve_echo_area',
2383 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2384
2385 * indent.c (Fvertical_motion):
2386 * window.c (window_scroll_pixel_based, Frecenter):
2387 Don't pass `need_y_p' to `move_it_by_lines'.
2388
2389 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2390
2391 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2392 steal a few bits to be more compact.
2393 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2394 Remove unneeded casts.
2395
2396 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2397
2398 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2399
2400 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2401 binding" message (bug#7967).
2402
2403 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2404
2405 Fix more problems found by GCC 4.6.0's static checks.
2406
2407 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2408 Remove unused local var.
2409
2410 * editfns.c (Fmessage_box): Remove unused local var.
2411
2412 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2413 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2414 Omit unused local vars.
2415 * window.c (shrink_windows): Omit unused local var.
2416 * menu.c (digest_single_submenu): Omit unused local var.
2417 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2418 Omit unused local var.
2419
2420 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2421 Don't assume string length fits in int.
2422 (keyremap_step, read_key_sequence): Use size_t for sizes.
2423 (read_key_sequence): Don't check last_real_key_start redundantly.
2424
2425 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2426 instead of alloca (Bug#8344).
2427
2428 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2429 (Fbacktrace_frame): Don't assume nframes fits in int.
2430
2431 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2432
2433 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2434 concerns.
2435
2436 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2437
2438 * cm.c (calccost): Turn while-do into do-while, for clarity.
2439
2440 * keyboard.c (syms_of_keyboard): Use the same style as later
2441 in this function when indexing through an array. This also
2442 works around GCC bug 48267.
2443
2444 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2445
2446 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2447
2448 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2449 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2450
2451 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2452 This avoids undefined behavior on integer overflow, and is a bit
2453 more convenient anyway since it is compared to a size_t variable.
2454
2455 Variadic C functions now count arguments with size_t, not int.
2456 This avoids an unnecessary limitation on 64-bit machines, which
2457 caused (substring ...) to crash on large vectors (Bug#8344).
2458 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2459 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2460 All variadic functions and their callers changed accordingly.
2461 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2462 * data.c (arith_driver, float_arith_driver): Likewise.
2463 * editfns.c (general_insert_function): Likewise.
2464 * eval.c (struct backtrace.nargs, interactive_p)
2465 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2466 (funcall_lambda, mark_backtrace): Likewise.
2467 * fns.c (concat): Likewise.
2468 * frame.c (x_set_frame_parameters): Likewise.
2469 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2470 0 if not found, not -1. All callers changed.
2471
2472 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2473 (stack_copy_size): Now size_t, not int.
2474 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2475
2476 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2477
2478 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2479 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2480 All callers changed.
2481
2482 * lisp.h (multibyte_char_to_unibyte):
2483 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2484 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2485 * character.h (CHAR_TO_BYTE8):
2486 * cmds.c (internal_self_insert):
2487 * editfns.c (general_insert_function):
2488 * keymap.c (push_key_description):
2489 * search.c (Freplace_match):
2490 * xdisp.c (message_dolog, set_message_1): All callers changed.
2491
2492 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2493
2494 * keyboard.c (safe_run_hook_funcall): New function.
2495 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2496 don't set the hook to nil, but remove the offending function instead.
2497 (Qcommand_hook_internal): Remove, unused.
2498 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2499 Vcommand_hook_internal.
2500
2501 * eval.c (enum run_hooks_condition): Remove.
2502 (funcall_nil, funcall_not): New functions.
2503 (run_hook_with_args): Call each function through a `funcall' argument.
2504 Remove `cond' argument, now redundant.
2505 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2506 (Frun_hook_with_args_until_failure): Adjust accordingly.
2507 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2508
2509 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2510
2511 * dispextern.h (string_buffer_position): Remove declaration.
2512
2513 * print.c (strout): Remove parameter `multibyte', unused since
2514 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2515
2516 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2517 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2518 All callers changed.
2519
2520 * w32.c (_wsa_errlist): Use braces for struct initializers.
2521
2522 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2523 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2524 All callers changed.
2525 (string_buffer_position): Likewise. Also, make static (it's never
2526 used outside xdisp.c).
2527 (cursor_row_p): Remove parameter `w', unused since
2528 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2529 (decode_mode_spec): Remove parameter `precision', introduced during
2530 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2531 All callers changed.
2532
2533 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2534
2535 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2536
2537 2011-03-27 Anders Lindgren <andlind@gmail.com>
2538
2539 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2540 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2541 (ns_update_auto_hide_menu_bar): New functions.
2542 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2543 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2544 ns_constrain_all_frames.
2545 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2546 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2547
2548 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2549
2550 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2551
2552 2011-03-27 Glenn Morris <rgm@gnu.org>
2553
2554 * syssignal.h: Replace RETSIGTYPE with void.
2555 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2556 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2557 Replace SIGTYPE with void everywhere.
2558 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2559 * s/template.h (SIGTYPE): Remove commented out definition.
2560
2561 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2562
2563 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2564 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2565
2566 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2567
2568 * w32.c (read_unc_volume): Use parameter `henum', instead of
2569 global variable `wget_enum_handle'.
2570
2571 * keymap.c (describe_vector): Remove parameters `indices' and
2572 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2573 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2574
2575 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2576
2577 * keyboard.c (timer_check): Remove parameter `do_it_now',
2578 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2579 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2580 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2581
2582 * keyboard.c (read_char):
2583 * w32menu.c (w32_menu_display_help):
2584 * xmenu.c (show_help_event, menu_help_callback):
2585 Adjust calls to `show_help_echo'.
2586
2587 * gtkutil.c (xg_maybe_add_timer):
2588 * keyboard.c (readable_events):
2589 * process.c (wait_reading_process_output):
2590 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2591
2592 * insdel.c (adjust_markers_gap_motion):
2593 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2594 (gap_left, gap_right): Don't call it.
2595
2596 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2597
2598 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2599 incurred during fontification.
2600
2601 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2602
2603 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2604 (DEFVAR_PER_BUFFER): Don't pass it.
2605
2606 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2607 (scrolling_window): Don't pass it.
2608
2609 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2610
2611 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2612
2613 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2614 and `suffix'.
2615 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2616 of variables specific to SELinux and computation of `encoded_absname'.
2617
2618 * image.c (XPutPixel): Remove unused variable `height'.
2619
2620 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2621
2622 * unexw32.c (get_section_info): Remove unused variable `section'.
2623
2624 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2625 (system_process_attributes): Remove unused variable `sess'.
2626 (sys_read): Remove unused variable `err'.
2627
2628 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2629 (w32_wnd_proc): Remove unused variable `isdead'.
2630 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2631 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2632 (x_create_tip_frame): Remove unused variable `tem'.
2633
2634 * w32inevt.c (w32_console_read_socket):
2635 Remove unused variable `no_events'.
2636
2637 * w32term.c (x_draw_composite_glyph_string_foreground):
2638 Remove unused variable `width'.
2639
2640 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2641
2642 * w32term.c (x_set_glyph_string_clipping):
2643 Don't pass uninitialized region to CombineRgn.
2644
2645 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2646
2647 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2648 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2649 (Fx_close_connection): Remove unused variable `i'.
2650
2651 * w32font.c (w32font_draw): Return number of glyphs.
2652 (w32font_open_internal): Remove unused variable `i'.
2653 (w32font_driver): Add missing initializer.
2654
2655 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2656 (fill_in_menu): Remove unused variable `items_added'.
2657
2658 * w32term.c (last_mouse_press_frame): Remove static global variable.
2659 (w32_clip_to_row): Remove unused variable `f'.
2660 (x_delete_terminal): Remove unused variable `i'.
2661
2662 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2663 (NOTHING): Remove unused static global variable.
2664 (uniscribe_check_otf): Remove unused variable `table'.
2665 (uniscribe_font_driver): Add missing initializers.
2666
2667 2011-03-23 Julien Danjou <julien@danjou.info>
2668
2669 * term.c (Fsuspend_tty, Fresume_tty):
2670 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2671 * window.c (temp_output_buffer_show):
2672 * insdel.c (signal_before_change):
2673 * frame.c (Fhandle_switch_frame):
2674 * fileio.c (Fdo_auto_save):
2675 * emacs.c (Fkill_emacs):
2676 * editfns.c (save_excursion_restore):
2677 * cmds.c (internal_self_insert):
2678 * callint.c (Fcall_interactively):
2679 * buffer.c (Fkill_all_local_variables):
2680 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2681 Use Frun_hooks.
2682 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2683 unconditionnaly since it does the check itself.
2684
2685 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 Fix more problems found by GCC 4.5.2's static checks.
2688
2689 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2690 the first time through the loop, since we know p0 < p1 then.
2691 This also avoids a gcc -Wstrict-overflow warning.
2692
2693 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2694 leading to a memory leak, possible in functions like
2695 load_charset_map_from_file that can allocate an unbounded number
2696 of objects (Bug#8318).
2697
2698 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2699 that could (at least in theory) be that large.
2700
2701 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2702 This is less likely to overflow, and avoids undefined behavior if
2703 overflow does occur. All callers changed. Use strtoul to scan
2704 for the unsigned long integer.
2705 (pint2hrstr): Simplify and tune code slightly.
2706 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2707
2708 * scroll.c (do_scrolling): Work around GCC bug 48228.
2709 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2710
2711 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2712 This also avoids a warning with gcc -Wstrict-overflow.
2713 (validate_x_resource_name): Simplify count usage.
2714 This also avoids a warning with gcc -Wstrict-overflow.
2715
2716 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2717 fail (Bug#8306).
2718
2719 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2720
2721 * process.c (Fmake_network_process): Use socklen_t, not int,
2722 where POSIX says socklen_t is required in portable programs.
2723 This fixes a porting bug on hosts like 64-bit HP-UX, where
2724 socklen_t is wider than int (Bug#8277).
2725 (Fmake_network_process, server_accept_connection):
2726 (wait_reading_process_output, read_process_output):
2727 Likewise.
2728
2729 * process.c: Rename or move locals to avoid shadowing.
2730 (list_processes_1, Fmake_network_process):
2731 (read_process_output_error_handler, exec_sentinel_error_handler):
2732 Rename or move locals.
2733 (Fmake_network_process): Define label "retry_connect" only if needed.
2734 (Fnetwork_interface_info): Fix pointer signedness.
2735 (process_send_signal): Add cast to avoid pointer signedness problem.
2736 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2737 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2738
2739 Make tparam.h and terminfo.c consistent.
2740 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2741 Include tparam.h instead, since it declares them.
2742 * cm.h (PC): Remove extern decl; tparam.h now does this.
2743 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2744 * terminfo.c: Include tparam.h, to check interfaces.
2745 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2746 (tparam): Adjust signature to match interface in tparam.h;
2747 this removes some undefined behavior. Check that outstring and len
2748 are zero, which they always are with Emacs.
2749 * tparam.h (PC, BC, UP): New extern decls.
2750
2751 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2752 (xftfont_open): Rename locals to avoid shadowing.
2753
2754 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2755 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2756 (OTF_TAG_SYM): Omit macro if not needed.
2757 (ftfont_list): Remove unused local.
2758 (get_adstyle_property, ftfont_pattern_entity):
2759 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2760 Rename locals to avoid shadowing.
2761
2762 * xfont.c (xfont_list_family): Mark var as initialized.
2763
2764 * xml.c (make_dom): Now static.
2765
2766 * composite.c (composition_compute_stop_pos): Rename local to
2767 avoid shadowing.
2768 (composition_reseat_it): Remove unused locals.
2769 (find_automatic_composition, composition_adjust_point): Likewise.
2770 (composition_update_it): Mark var as initialized.
2771 (find_automatic_composition): Mark vars as initialized,
2772 with a FIXME (Bug#8290).
2773
2774 character.h: Rename locals to avoid shadowing.
2775 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2776 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2777 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2778 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2779 to avoid shadowing.
2780
2781 * textprop.c (property_change_between_p): Remove; unused.
2782
2783 * intervals.c (interval_start_pos): Now static.
2784
2785 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2786
2787 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2788 Rename locals to avoid shadowing.
2789
2790 * sound.c (wav_play, au_play, Fplay_sound_internal):
2791 Fix pointer signedness.
2792 (alsa_choose_format): Remove unused local var.
2793 (wav_play): Initialize a variable to 0, to prevent undefined
2794 behavior (Bug#8278).
2795
2796 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2797
2798 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2799
2800 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2801 clobbering (Bug#8298).
2802 * sysdep.c (sys_subshell): Likewise.
2803 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2804
2805 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2806 This should get cleaned up, so that child_setup has the
2807 same signature on all platforms.
2808
2809 * callproc.c (call_process_cleanup): Now static.
2810 (relocate_fd): Rename locals to avoid shadowing.
2811
2812 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2813
2814 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2815 not to be necessary, and produces flickering.
2816
2817 2011-03-20 Glenn Morris <rgm@gnu.org>
2818
2819 * config.in: Remove file.
2820
2821 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2822
2823 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2824 are now in src/globals.h.
2825 (syms_of_minibuf): Remove spurious & from previous change.
2826
2827 2011-03-20 Leo <sdl.web@gmail.com>
2828
2829 * minibuf.c (completing-read-function): New variable.
2830 (completing-read-default): Rename from completing-read.
2831 (completing-read): Call completing-read-function.
2832
2833 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2834
2835 * xfaces.c (Fx_load_color_file):
2836 Read color file from absolute filename (bug#8250).
2837
2838 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2839
2840 * makefile.w32-in: Update dependencies.
2841
2842 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2843
2844 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2845
2846 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 Fix more problems found by GCC 4.5.2's static checks.
2849
2850 * process.c (make_serial_process_unwind, send_process_trap):
2851 (sigchld_handler): Now static.
2852
2853 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2854 That way, the code declares only the vars that it needs.
2855 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2856 * s/cygwin.h (PTY_ITERATION): Likewise.
2857 * s/darwin.h (PTY_ITERATION): Likewise.
2858 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2859
2860 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2861 * process.c (allocate_pty): Don't declare stb unless it's needed.
2862
2863 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2864 (CONSTANTLIM): Remove; unused.
2865 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2866 Define only if needed.
2867
2868 * unexelf.c (unexec): Name an expression,
2869 to avoid gcc -Wbad-function-cast warning.
2870 Use a different way to cause a compilation error if anyone uses
2871 n rather than nn, a way that does not involve shadowing.
2872 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2873
2874 * deps.mk (unexalpha.o): Remove; unused.
2875
2876 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2877 * unexec.h: New file.
2878 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2879 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2880 Depend on unexec.h.
2881 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2882 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2883 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2884 Change as necessary to match prototype in unexec.h.
2885
2886 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2887 shadowing.
2888 (back_comment, skip_chars): Mark vars as initialized.
2889
2890 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2891 Rename locals to avoid shadowing.
2892
2893 * lread.c (read1): Rewrite so as not to use empty "else".
2894 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2895
2896 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2897
2898 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2899 warning when compiling print.c.
2900
2901 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2902 instead of using an uninitialized var.
2903 (font_sort_entities): Mark var as initialized.
2904
2905 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2906
2907 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2908 pointers to constants.
2909 (font_parse_fcname): Remove unused vars.
2910 (font_delete_unmatched): Now static.
2911 (font_get_spec): Remove; unused.
2912 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2913 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2914 Rename or move locals to avoid shadowing.
2915
2916 * fns.c (require_nesting_list, require_unwind): Now static.
2917 (Ffillarray): Rename locals to avoid shadowing.
2918
2919 * floatfns.c (domain_error2): Define only if needed.
2920 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2921
2922 * alloc.c (mark_backtrace): Move decl from here ...
2923 * lisp.h: ... to here, so that it can be checked.
2924
2925 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2926 (Fdefvar): Rewrite so as not to use empty "else".
2927 (lisp_indirect_variable): Name an expression,
2928 to avoid gcc -Wbad-function-cast warning.
2929 (Fdefvar): Rename locals to avoid shadowing.
2930
2931 * callint.c (quotify_arg, quotify_args): Now static.
2932 (Fcall_interactively): Rename locals to avoid shadowing.
2933 Use const pointer when appropriate.
2934
2935 * lisp.h (get_system_name, get_operating_system_release):
2936 Move decls here, to check interfaces.
2937 * process.c (get_operating_system_release): Move decl to lisp.h.
2938 * xrdb.c (get_system_name): Likewise.
2939 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2940 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2941 some of which prompt warnings from gcc -Wbad-function-cast.
2942 (Fformat_time_string, Fencode_time, Finsert_char):
2943 (Ftranslate_region_internal, Fformat):
2944 Rename or remove local vars to avoid shadowing.
2945 (Ftranslate_region_internal): Mark var as initialized.
2946
2947 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2948 avoid shadowing.
2949
2950 * lisp.h (eassert): Check that the argument compiles, even if
2951 ENABLE_CHECKING is not defined.
2952
2953 * data.c (Findirect_variable): Name an expression, to avoid
2954 gcc -Wbad-function-cast warning.
2955 (default_value, arithcompare, arith_driver, arith_error): Now static.
2956 (store_symval_forwarding): Rename local to avoid shadowing.
2957 (Fmake_variable_buffer_local, Fmake_local_variable):
2958 Mark variables as initialized.
2959 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2960
2961 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2962 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2963 Rename locals to avoid shadowing.
2964 (mark_stack): Move local variables into the #ifdef region where
2965 they're used.
2966 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2967 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2968 needed otherwise.
2969 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2970 (GC_STRING_CHARS): Remove; not used.
2971 (Fmemory_limit): Cast sbrk's returned value to char *.
2972
2973 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2974 avoids undefined behavior in theory.
2975
2976 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2977
2978 Use functions, not macros, for up- and down-casing (Bug#8254).
2979 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2980 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2981 to use the following functions instead of these macros.
2982 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2983 EMACS_INT, since callers assume the returned value fits in int.
2984 (upcase1): Likewise, for UPCASE_TABLE.
2985 (uppercasep, lowercasep, upcase): New static inline functions.
2986 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2987 the race-condition problem in the old DOWNCASE.
2988
2989 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2990 Rename locals to avoid shadowing.
2991 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2992 (regex_compile, re_search_2, re_match_2_internal):
2993 Remove unused local vars.
2994 (FREE_VAR): Rewrite so as not to use empty "else",
2995 which gcc can warn about.
2996 (regex_compile, re_match_2_internal): Mark locals as initialized.
2997 (RETALLOC_IF): Define only if needed.
2998 (WORDCHAR_P): Likewise. This one is never needed, but is used
2999 only in a comment talking about a compiler bug, so put inside
3000 the #if 0 of that comment.
3001 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3002 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3003 Remove; unused.
3004
3005 * search.c (boyer_moore): Rename locals to avoid shadowing.
3006 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3007 (PREV_CHAR_BOUNDARY): Likewise.
3008
3009 * search.c (simple_search): Remove unused var.
3010
3011 * dired.c (compile_pattern): Move decl from here ...
3012 * lisp.h: ... to here, so that it can be checked.
3013 (struct re_registers): New forward decl.
3014
3015 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3016
3017 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3018 All uses changed.
3019 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3020 Rename locals to avoid shadowing.
3021 (Fvertical_motion): Mark locals as initialized.
3022
3023 * casefiddle.c (casify_object, casify_region): Now static.
3024 (casify_region): Mark local as initialized.
3025
3026 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3027
3028 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3029 New macros, so that the caller can use some names other than
3030 gcpro1, gcpro2, etc.
3031 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3032 of the new macros.
3033 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3034 argument, for consistency with GCPRO2_VAR, etc: it is now the
3035 prefix of the variable, not the variable itself. All uses
3036 changed.
3037 * dired.c (directory_files_internal, file_name_completion):
3038 Rename locals to avoid shadowing.
3039
3040 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3041 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3042 dired.c's scmp function, had undefined behavior.
3043 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3044 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3045 * buffer.h: ... to here, because these macros use current_buffer,
3046 and the new implementation with inline functions needs to have
3047 current_buffer in scope now, rather than later when the macros
3048 are used.
3049 (downcase, upcase1): New static inline functions.
3050 (DOWNCASE, UPCASE1): Reimplement using these functions.
3051 This avoids undefined behavior in expressions like
3052 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3053 from race conditions in accessing the global variables
3054 case_temp1 and case_temp2.
3055 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3056 * lisp.h (case_temp1, case_temp2): Remove their decls.
3057 * character.h (ASCII_CHAR_P): Move from here ...
3058 * lisp.h: ... to here, so that the inline functions mentioned
3059 above can use them.
3060
3061 * dired.c (directory_files_internal_unwind): Now static.
3062
3063 * fileio.c (file_name_as_directory, directory_file_name):
3064 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3065 Now static.
3066 (file_name_as_directory): Use const pointers when appropriate.
3067 (Fexpand_file_name): Likewise. In particular, newdir might
3068 point at constant storage, so make it a const pointer.
3069 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3070 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3071 signedness issues.
3072 (Fset_file_times, Finsert_file_contents, auto_save_error):
3073 Rename locals to avoid shadowing.
3074
3075 * minibuf.c (choose_minibuf_frame_1): Now static.
3076 (Ftry_completion, Fall_completions): Rename or remove locals
3077 to avoid shadowing.
3078
3079 * marker.c (bytepos_to_charpos): Remove; unused.
3080
3081 * lisp.h (verify_bytepos, count_markers): New decls,
3082 so that gcc does not warn that these functions aren't declared.
3083
3084 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3085 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3086 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3087 (copy_text): Remove unused local var.
3088
3089 * filelock.c (within_one_second): Now static.
3090 (lock_file_1): Rename local to avoid shadowing.
3091
3092 * buffer.c (fix_overlays_before): Mark locals as initialized.
3093 (fix_start_end_in_overlays): Likewise. This function should be
3094 simplified by using pointers-to-pointers, but that's a different
3095 matter.
3096 (switch_to_buffer_1): Now static.
3097 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3098 (report_overlay_modification): Rename locals to avoid shadowing.
3099
3100 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3101 Fix pointer signedness issue.
3102 (sys_subshell): Mark local as volatile if checking for lint,
3103 to suppress a gcc -Wclobbered warning that does not seem to be right.
3104 (MAXPATHLEN): Define only if needed.
3105
3106 * process.c (serial_open, serial_configure): Move decls from here ...
3107 * systty.h: ... to here, so that they can be checked.
3108
3109 * fns.c (get_random, seed_random): Move extern decls from here ...
3110 * lisp.h: ... to here, so that they can be checked.
3111
3112 * sysdep.c (reset_io): Now static.
3113 (wait_for_termination_signal): Remove; unused.
3114
3115 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3116 (copy_keymap_item, append_key, push_text_char_description):
3117 Now static.
3118 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3119 (DENSE_TABLE_SIZE): Remove; unused.
3120 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3121 (describe_map_tree):
3122 Rename locals to avoid shadowing.
3123
3124 * keyboard.c: Declare functions static if they are not used elsewhere.
3125 (echo_char, echo_dash, cmd_error, top_level_2):
3126 (poll_for_input, handle_async_input): Now static.
3127 (read_char, kbd_buffer_get_event, make_lispy_position):
3128 (make_lispy_event, make_lispy_movement, apply_modifiers):
3129 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3130 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3131 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3132 (read_key_sequence, read_char): Mark locals as initialized.
3133 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3134
3135 * keyboard.h (make_ctrl_char): New decl.
3136 (mark_kboards): Move decl here ...
3137 * alloc.c (mark_kboards): ... from here.
3138
3139 * lisp.h (force_auto_save_soon): New decl.
3140
3141 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3142 (DEFINE_DUMMY_FUNCTION): New macro.
3143 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3144 Use it.
3145 (main): Add casts to avoid warnings
3146 if GCC considers string literals to be constants.
3147
3148 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3149
3150 * dbusbind.c: Pointer signedness fixes.
3151 (xd_signature, xd_append_arg, xd_initialize):
3152 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3153 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3154 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3155 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3156
3157 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3158 if GCC considers string literals to be constants.
3159 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3160
3161 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3162
3163 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3164 (print_preprocess, print_object): New macro to fix last change.
3165
3166 * print.c (print_preprocess): Don't forget font objects.
3167
3168 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3169
3170 * emacs.c (USAGE3): Doc fixes.
3171
3172 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3173
3174 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3175 structure.
3176
3177 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3178
3179 * lisp.h (VWindow_system, Qfile_name_history):
3180 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3181 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3182 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3183
3184 * w32select.c: Don't #include "keyboard.h".
3185 (run_protected): Add extern declaration for waiting_for_input.
3186
3187 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3188 * w32console.c (detect_input_pending, read_input_pending)
3189 (encode_terminal_code):
3190 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3191 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3192 (w32_system_caret_y, Qfile_name_history):
3193 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3194 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3195 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3196 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3197 * w32proc.c (Qlocal, report_file_error):
3198 * w32term.c (Vwindow_system, updating_frame):
3199 * w32uniscribe.c (initialized, uniscribe_font_driver):
3200 Remove unneeded extern declarations.
3201
3202 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3203
3204 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3205
3206 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3207
3208 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3209 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3210 These macros can no longer be used for assignment.
3211
3212 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3213 Assign struct members directly, instead of using BUF_BEGV etc.
3214 (record_buffer_markers, fetch_buffer_markers): New functions for
3215 recording and fetching special buffer markers.
3216 (set_buffer_internal_1, set_buffer_temp): Use them.
3217
3218 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3219
3220 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3221
3222 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3223 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3224
3225 * xdisp.c (hscroll_window_tree):
3226 (reconsider_clip_changes): Use PT instead of BUF_PT.
3227
3228 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3229
3230 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3231 $(EMACS_ROOT)/lib/intprops.h.
3232
3233 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3234
3235 Fix more problems found by GCC 4.5.2's static checks.
3236
3237 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3238 to unsigned char * to avoid compiler diagnostic.
3239 (xg_free_frame_widgets): Make it clear that a local variable is
3240 needed only if USE_GTK_TOOLTIP.
3241 (gdk_window_get_screen): Make it clear that this macro is needed
3242 only if USE_GTK_TOOLTIP.
3243 (int_gtk_range_get_value): New function, which avoids a diagnostic
3244 from gcc -Wbad-function-cast.
3245 (xg_set_toolkit_scroll_bar_thumb): Use it.
3246 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3247 diagnostic from gcc -Wbad-function-cast.
3248 (get_utf8_string, xg_get_file_with_chooser):
3249 Rename locals to avoid shadowing.
3250 (create_dialog): Move locals to avoid shadowing.
3251
3252 * xgselect.c (xg_select): Remove unused var.
3253
3254 * image.c (four_corners_best): Mark locals as initialized.
3255 (gif_load): Initialize transparent_p to zero (Bug#8238).
3256 Mark another local as initialized.
3257 (my_png_error, my_error_exit): Mark with NO_RETURN.
3258
3259 * image.c (clear_image_cache): Now static.
3260 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3261 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3262 (x_edge_detection): Remove unnecessary cast that
3263 gcc -Wbad-function-cast diagnoses.
3264 (gif_load): Fix pointer signedness.
3265 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3266 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3267
3268 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3269
3270 Improve quality of tests for time stamp overflow.
3271 For example, without this patch (encode-time 0 0 0 1 1
3272 1152921504606846976) returns the obviously-bogus value (-948597
3273 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3274 reports time overflow. See
3275 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3276 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3277 * editfns.c: Include limits.h and intprops.h.
3278 (TIME_T_MIN, TIME_T_MAX): New macros.
3279 (time_overflow): Move earlier, to before first use.
3280 (hi_time, lo_time): New functions, for an accurate test for
3281 out-of-range times.
3282 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3283 (Fget_internal_run_time): Don't assume time_t fits in int.
3284 (make_time): Use list2 instead of Fcons twice.
3285 (Fdecode_time): More accurate test for out-of-range times.
3286 (check_tm_member): New function.
3287 (Fencode_time): Use it, to test for out-of-range times.
3288 (lisp_time_argument): Don't rely on undefined left-shift and
3289 right-shift behavior when checking for time stamp overflow.
3290
3291 * editfns.c (time_overflow): New function, refactoring common code.
3292 (Fformat_time_string, Fdecode_time, Fencode_time):
3293 (Fcurrent_time_string): Use it.
3294
3295 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3296 * dired.c (make_time): Move to ...
3297 * editfns.c (make_time): ... here.
3298 * systime.h: Note the move.
3299
3300 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3301
3302 * fringe.c (update_window_fringes): Remove unused variables.
3303
3304 * unexmacosx.c (copy_data_segment): Also copy __got section.
3305 (Bug#8223)
3306
3307 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3308
3309 * termcap.c [MSDOS]: Include "msdos.h".
3310 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3311 Constify `char *' arguments and their references according to
3312 prototypes in tparam.h.
3313
3314 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3315
3316 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3317 Adapt all references accordingly.
3318
3319 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3320
3321 2011-03-11 Tom Tromey <tromey@redhat.com>
3322
3323 * buffer.c (syms_of_buffer): Remove obsolete comment.
3324
3325 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3326
3327 * termhooks.h (encode_terminal_code): Declare prototype.
3328
3329 * msdos.c (encode_terminal_code): Don't declare prototype.
3330
3331 * term.c (encode_terminal_code): Now external again, used by
3332 w32console.c and msdos.c.
3333
3334 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3335 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3336
3337 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3338
3339 Fix some minor problems found by GCC 4.5.2's static checks.
3340
3341 * fringe.c (update_window_fringes): Mark locals as initialized
3342 (Bug#8227).
3343 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3344
3345 * alloc.c (mark_fringe_data): Move decl from here ...
3346 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3347 to check its interface.
3348 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3349
3350 * fontset.c (free_realized_fontset): Now static.
3351 (Fset_fontset_font): Rename local to avoid shadowing.
3352 (fontset_font): Mark local as initialized.
3353 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3354
3355 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3356
3357 * xselect.c (x_disown_buffer_selections): Remove; not used.
3358 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3359 (x_own_selection, Fx_disown_selection_internal): Rename locals
3360 to avoid shadowing.
3361 (x_handle_dnd_message): Remove local to avoid shadowing.
3362
3363 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3364 so that the caller can use some name other than gcpro1.
3365 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3366 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3367 (Fx_backspace_delete_keys_p):
3368 Use them to avoid shadowing, and rename vars to avoid shadowing.
3369 (x_decode_color, x_set_name, x_window): Now static.
3370 (Fx_create_frame): Add braces to silence GCC warning.
3371 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3372 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3373 Remove unused locals.
3374 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3375 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3376 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3377 macros.
3378
3379 * xterm.h (x_mouse_leave): New decl.
3380
3381 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3382 Remove unused functions.
3383 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3384 (x_calc_absolute_position): Now static.
3385 (XTread_socket): Don't define label "out" unless it's used.
3386 Don't declare local "event" unless it's used.
3387 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3388 unless they are used.
3389 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3390 (x_fatal_error_signal): Remove; not used.
3391 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3392 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3393 (x_error_catcher, x_connection_closed, x_error_handler):
3394 (x_error_quitter, xembed_send_message, x_iconify_frame):
3395 (my_log_handler): Rename locals to avoid shadowing.
3396 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3397 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3398
3399 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3400 Rename or move locals to avoid shadowing.
3401 (tty_defined_color, merge_face_heights): Now static.
3402 (free_realized_faces_for_fontset): Remove; not used.
3403 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3404 does not deduce is never used uninitialized.
3405 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3406 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3407
3408 * terminal.c (store_terminal_param): Now static.
3409
3410 * xmenu.c (menu_highlight_callback): Now static.
3411 (set_frame_menubar): Remove unused local.
3412 (xmenu_show): Rename parameter to avoid shadowing.
3413 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3414 since they might point to immutable storage.
3415 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3416 since it's unused otherwise.
3417
3418 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3419 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3420 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3421 avoids a gcc -Wuninitialized diagnostic.
3422 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3423 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3424 does not deduce are never used uninitialized.
3425
3426 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3427
3428 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3429 * window.c (window_loop, size_window):
3430 (run_window_configuration_change_hook, enlarge_window): Likewise.
3431
3432 * window.c (display_buffer): Now static.
3433 (size_window): Mark variables that gcc -Wuninitialized
3434 does not deduce are never used uninitialized.
3435 * window.h (check_all_windows): New decl, to forestall
3436 gcc -Wmissing-prototypes diagnostic.
3437 * dispextern.h (bidi_dump_cached_states): Likewise.
3438
3439 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3440 shadowing.
3441 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3442 Include <limits.h>.
3443 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3444 and to avoid gcc -Wuninitialized warning.
3445 (load_charset_map): Mark variables that gcc -Wuninitialized
3446 does not deduce are never used uninitialized.
3447 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3448
3449 * coding.c (coding_set_source, coding_set_destination):
3450 Use "else { /* comment */ }" rather than "else /* comment */;"
3451 for clarity, and to avoid gcc -Wempty-body warning.
3452 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3453 a block, when the outer 'i' will do.
3454 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3455 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3456 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3457 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3458 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3459 Rename locals to avoid shadowing.
3460 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3461 * coding.c (emacs_mule_char, encode_invocation_designation):
3462 Now static, since they're not used elsewhere.
3463 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3464 (decode_coding_object, encode_coding_object, detect_coding_system):
3465 (decode_coding_emacs_mule): Mark variables that gcc
3466 -Wuninitialized does not deduce are never used uninitialized.
3467 (detect_coding_iso_2022): Initialize a local variable that might
3468 be used uninitialized. Leave a FIXME because it's not clear that
3469 this initialization is needed. (Bug#8211)
3470 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3471 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3472 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3473 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3474 Remove unused macros.
3475
3476 * category.c (hash_get_category_set): Remove unused local var.
3477 (copy_category_table): Now static, since it's not used elsewhere.
3478 * character.c (string_count_byte8): Likewise.
3479
3480 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3481 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3482
3483 * chartab.c (copy_sub_char_table): Now static, since it's not used
3484 elsewhere.
3485 (sub_char_table_ref_and_range, char_table_ref_and_range):
3486 Rename locals to avoid shadowing.
3487 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3488
3489 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3490 (BIDI_BOB): Remove unused macro.
3491
3492 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3493 deduce are never used uninitialized.
3494 * term.c (encode_terminal_code): Likewise.
3495
3496 * term.c (encode_terminal_code): Now static. Remove unused local.
3497
3498 * tparam.h: New file.
3499 * term.c, tparam.h: Include it.
3500 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3501 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3502 Move these decls to tparam.h, and make them agree with what
3503 is actually in tparam.c. The previous trick of using incompatible
3504 decls in different modules does not conform to the C standard.
3505 All callers of tparam changed to use tparam's actual API.
3506 * tparam.c (tparam1, tparam, tgoto):
3507 Use const pointers where appropriate.
3508
3509 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3510 * cm.h (struct cm): Likewise.
3511 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3512 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3513 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3514 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3515 (turn_on_face, init_tty): Likewise.
3516 * termchar.h (struct tty_display_info): Likewise.
3517
3518 * term.c (term_mouse_position): Rename local to avoid shadowing.
3519
3520 * alloc.c (mark_ttys): Move decl from here ...
3521 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3522
3523 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3524
3525 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3526
3527 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * search.c (compile_pattern_1): Remove argument regp, unused since
3530 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3531 (compile_pattern): Don't pass it.
3532
3533 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3534
3535 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3536 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3537 for ! HAVE_GTK3.
3538 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3539
3540 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3541
3542 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3543 gdk_window_get_screen, gdk_window_get_geometry,
3544 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3545 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3546 (xg_get_pixbuf_from_pixmap): New function.
3547 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3548 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3549 Call xg_get_pixbuf_from_pixmap instead of
3550 gdk_pixbuf_get_from_drawable.
3551 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3552 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3553 (xg_check_special_colors): Use GtkStyleContext and its functions
3554 for HAVE_GTK3.
3555 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3556 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3557 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3558 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3559 Call gtk_widget_get_preferred_size.
3560 (xg_frame_resized): gdk_window_get_geometry only takes 5
3561 parameters.
3562 (xg_win_to_widget, xg_event_is_for_menubar):
3563 Call gdk_x11_window_lookup_for_display.
3564 (xg_set_widget_bg): New function.
3565 (delete_cb): New function.
3566 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3567 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3568 (xg_set_background_color): Call xg_set_widget_bg.
3569 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3570 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3571 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3572 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3573 if ! HAVE_GTK3.
3574 (update_frame_tool_bar): Call gtk_widget_hide.
3575 (xg_initialize): Use GDK_KEY_g.
3576
3577 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3578 if ! HAVE_GTK3
3579 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3580
3581 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3582 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3583 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3584
3585 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3586
3587 * w32xfns.c (select_palette): Check success of RealizePalette against
3588 GDI_ERROR, not zero.
3589
3590 See ChangeLog.11 for earlier changes.
3591
3592 ;; Local Variables:
3593 ;; coding: utf-8
3594 ;; End:
3595
3596 Copyright (C) 2011 Free Software Foundation, Inc.
3597
3598 This file is part of GNU Emacs.
3599
3600 GNU Emacs is free software: you can redistribute it and/or modify
3601 it under the terms of the GNU General Public License as published by
3602 the Free Software Foundation, either version 3 of the License, or
3603 (at your option) any later version.
3604
3605 GNU Emacs is distributed in the hope that it will be useful,
3606 but WITHOUT ANY WARRANTY; without even the implied warranty of
3607 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3608 GNU General Public License for more details.
3609
3610 You should have received a copy of the GNU General Public License
3611 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.