]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Fix bug #9229 with cursor positioning on display strings.
[gnu-emacs] / src / ChangeLog
1 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4 came from a string character with a `cursor' property. (Bug#9229)
5
6 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7
8 * Makefile.in (LIB_PTHREAD): New variable.
9 (LIBES): Add LIB_PTHREAD (Bug#9216).
10
11 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
12 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
13
14 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
15
16 * regex.c (re_iswctype): Remove some redundant boolean
17 conversions.
18
19 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
20
21 * xterm.c (x_find_topmost_parent): New function.
22 (x_set_frame_alpha): Find topmost parent window with
23 x_find_topmost_parent and set the property there also (bug#9181).
24 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
25
26 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
27
28 * callproc.c (Fcall_process): Avoid vfork clobbering
29 the local vars buffer, coding_systems, current_dir.
30
31 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
32
33 * keymap.c (Fmake_composed_keymap): Move to subr.el.
34
35 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
36
37 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
38 so that it is not optimized away.
39
40 * xdisp.c (compute_display_string_pos): Remove unused local.
41
42 2011-08-02 Eli Zaretskii <eliz@gnu.org>
43
44 Fix slow cursor motion and scrolling in large buffers with
45 selective display, like Org Mode buffers. (Bug#9218)
46
47 * dispextern.h (struct bidi_it): New member disp_prop_p.
48
49 * xdisp.c: Remove one-slot cache of display string positions.
50 (compute_display_string_pos): Accept an additional argument
51 DISP_PROP_P; callers changed. Scan at most 5K characters forward
52 for a display string or property. If found, set DISP_PROP_P
53 non-zero.
54
55 * bidi.c (bidi_fetch_char): Accept an additional argument
56 DISP_PROP_P, and pass it to compute_display_string_pos.
57 Only handle text covered by a display string if DISP_PROP_P is returned
58 non-zero. All callers of bidi_fetch_char changed.
59
60 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
61
62 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
63
64 2010-12-03 Don March <don@ohspite.net>
65
66 * keymap.c (Fdefine_key): Fix non-prefix key error message when
67 last character M-[char] is translated to ESC [char] (bug#7541).
68
69 2011-08-02 Kenichi Handa <handa@m17n.org>
70
71 * lisp.h (uniprop_table): Extern it.
72
73 * chartab.c (uniprop_table): Make it non-static.
74
75 2011-08-01 Eli Zaretskii <eliz@gnu.org>
76
77 * xdisp.c (forward_to_next_line_start): Accept additional argument
78 BIDI_IT_PREV, and store into it the state of the bidi iterator had
79 on the newline.
80 (reseat_at_next_visible_line_start): Use the bidi iterator state
81 returned by forward_to_next_line_start to restore the state of
82 it->bidi_it after backing up to previous newline. (Bug#9212)
83
84 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
85
86 * regex.c (re_comp): Protoize.
87 (re_exec): Fix return type.
88 (regexec): Fix type of `ret'. (Bug#9203)
89
90 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
91
92 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
93 This is needed if max-image-size is a floating-point number.
94
95 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
96
97 * print.c (print_object): Print empty symbol as ##.
98
99 * lread.c (read1): Read ## as empty symbol.
100
101 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
102
103 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
104 setting frame foreground color (Bug#9175).
105 (x_set_background_color): Likewise.
106
107 * nsmenu.m (-setText): Size tooltip dimensions precisely to
108 contents (Bug#9176).
109 (EmacsTooltip -init): Remove bezels and add shadows to
110 tooltip windows.
111
112 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
113 or scroll bar (Bug#8470).
114
115 * nsfont.m (nsfont_open): Remove assignment to voffset and
116 unnecessary vars hshink, expand, hd, full_height, min_height.
117 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
118
119 * nsterm.h (nsfont_info): Remove voffset field.
120
121 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
122
123 Implement strike-through and overline on NextStep (Bug#8863).
124
125 * nsfont.m (nsfont_open): Use underline position provided by font,
126 instead of hard-coded value of 2.
127 (nsfont_draw): Call ns_draw_text_decoration instead.
128
129 * nsterm.h: Add declaration for ns_draw_text_decoration.
130
131 * nsterm.m (ns_draw_text_decoration): New function for drawing
132 underline, overline, and strike-through.
133 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
134 ns_draw_text_decoration. Change treatment of cursor drawing to
135 accomodate underlining, etc.
136
137 2011-07-28 Eli Zaretskii <eliz@gnu.org>
138
139 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
140 default.
141
142 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
143
144 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
145 Without this fix, if a signal arrives just after memory fills up,
146 'malloc' might be invoked reentrantly.
147
148 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
149 In other words, assume that every image size is allowed, on non-X
150 hosts. This assumption is probably wrong, but it lets Emacs compile.
151
152 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
153
154 * regex.c (re_iswctype): Convert return values to boolean.
155
156 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
157
158 * xdisp.c (compute_display_string_pos): Don't use cached display
159 string position if the buffer had its restriction changed.
160 (Bug#9184)
161
162 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
163
164 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
165
166 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
167
168 Integer signedness and overflow and related fixes. (Bug#9079)
169
170 * bidi.c: Integer size and overflow fixes.
171 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
172 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
173 (bidi_cache_find_level_change, bidi_cache_ensure_space)
174 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
175 (bidi_find_other_level_edge):
176 Use ptrdiff_t instead of EMACS_INT where either will do.
177 This works better on 32-bit hosts configured --with-wide-int.
178 (bidi_cache_ensure_space): Check for size-calculation overflow.
179 Use % rather than repeated addition, for better worst-case speed.
180 Don't set bidi_cache_size until after xrealloc returns, because it
181 might not return.
182 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
183 (bidi_cache_ensure_space): Also check that the bidi cache size
184 does not exceed that of the largest Lisp string or buffer. See Eli
185 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
186
187 * alloc.c (__malloc_size_t): Remove.
188 All uses replaced by size_t. See Andreas Schwab's note
189 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
190
191 * image.c: Improve checking for integer overflow.
192 (check_image_size): Assume that f is nonnull, since
193 it is always nonnull in practice. This is one less thing to
194 worry about when checking for integer overflow later.
195 (x_check_image_size): New function, which checks for integer
196 overflow issues inside X.
197 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
198 This removes the need for a memory_full check.
199 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
200 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
201 (xbm_read_bitmap_data): Change locals back to 'int', since
202 their values must fit in 'int'.
203 (xpm_load_image, png_load, tiff_load):
204 Invoke x_create_x_image_and_pixmap earlier,
205 to avoid much needless work if the image is too large.
206 (tiff_load): Treat overly large images as if
207 x_create_x_image_and_pixmap failed, not as malloc failures.
208 (gs_load): Use x_check_image_size.
209
210 * gtkutil.c: Omit integer casts.
211 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
212 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
213
214 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
215
216 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
217 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
218 would wrongly return t on a 64-bit host.
219
220 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
221 The plain *_OVERFLOW macros run afoul of GCC bug 49705
222 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
223 and therefore cause GCC to emit a bogus diagnostic in some cases.
224
225 * image.c: Integer signedness and overflow and related fixes.
226 This is not an exhaustive set of fixes, but it's time to
227 record what I've got.
228 (lookup_pixel_color, check_image_size): Remove redundant decls.
229 (check_image_size): Don't assume that arbitrary EMACS_INT values
230 fit in 'int', or that arbitrary 'double' values fit in 'int'.
231 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
232 (tiff_load, imagemagick_load_image):
233 Check for overflow in size calculations.
234 (x_create_x_image_and_pixmap): Remove unnecessary test for
235 xmalloc returning NULL; that can't happen.
236 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
237 (xpm_color_bucket): Use better integer hashing function.
238 (xpm_cache_color): Don't possibly over-allocate memory.
239 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
240 (gif_memory_source):
241 Use ptrdiff_t, not int or size_t, to record sizes.
242 (png_load): Don't assume values greater than 2**31 fit in 'int'.
243 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
244 either works, as we prefer signed integers.
245 (tiff_read_from_memory, tiff_write_from_memory):
246 Return tsize_t, not size_t, since that's what the TIFF API wants.
247 (tiff_read_from_memory): Don't fail simply because the read would
248 go past EOF; instead, return a short read.
249 (tiff_load): Omit no-longer-needed casts.
250 (Fimagemagick_types): Don't assume size fits into 'int'.
251
252 Improve hashing quality when configured --with-wide-int.
253 * fns.c (hash_string): New function, taken from sxhash_string.
254 Do not discard information about ASCII character case; this
255 discarding is no longer needed.
256 (sxhash-string): Use it. Change sig to match it. Caller changed.
257 * lisp.h: Declare it.
258 * lread.c (hash_string): Remove, since we now use fns.c's version.
259 The fns.c version returns a wider integer if --with-wide-int is
260 specified, so this should help the quality of the hashing a bit.
261
262 * emacs.c: Integer overflow minor fix.
263 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
264 Define only if GNU_LINUX.
265 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
266
267 * dispnew.c: Integer signedness and overflow fixes.
268 Remove unnecessary forward decls, that were a maintenance hassle.
269 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
270 All uses changed.
271 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
272 (scrolling_window): Use ptrdiff_t, not int, for byte count.
273 (prepare_desired_row, line_draw_cost):
274 Use int, not unsigned, where either works.
275 (save_current_matrix, restore_current_matrix):
276 Use ptrdiff_t, not size_t, where either works.
277 (init_display): Check for overflow more accurately, and without
278 relying on undefined behavior.
279
280 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
281 Remove, replacing with the new symbols in lisp.h. All uses changed.
282 * fileio.c (make_temp_name):
283 * filelock.c (lock_file_1, lock_file):
284 * xdisp.c (message_dolog):
285 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
286 Use pMd etc. instead.
287 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
288 replacing the pWIDE etc. symbols removed from editfns.c.
289
290 * keyboard.h (num_input_events): Now uintmax_t.
291 This is (very slightly) less likely to mess up due to wraparound.
292 All uses changed.
293
294 * buffer.c: Integer signedness fixes.
295 (alloc_buffer_text, enlarge_buffer_text):
296 Use ptrdiff_t rather than size_t when either will do, as we prefer
297 signed integers.
298
299 * alloc.c: Integer signedness and overflow fixes.
300 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
301 (__malloc_size_t): Default to size_t, not to int.
302 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
303 (Fgarbage_collect, mark_object_loop_halt, mark_object):
304 Prefer ptrdiff_t to size_t when either would do, as we prefer
305 signed integers.
306 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
307 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
308 Now const. Initialize with values that are in range even if char
309 is signed.
310 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
311 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
312 These functions do the right thing with sizes > 2**32.
313 (check_depth): Now ptrdiff_t, not int.
314 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
315 Adjust to new way of storing sizes. Check for size overflow bugs
316 in rest of code.
317 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
318 slightly wrong anyway, as it missed one instance of
319 XMALLOC_OVERRUN_CHECK_OVERHEAD.
320 (refill_memory_reserve): Omit needless cast to size_t.
321 (mark_object_loop_halt): Mark as externally visible.
322
323 * xselect.c: Integer signedness and overflow fixes.
324 (Fx_register_dnd_atom, x_handle_dnd_message):
325 Use ptrdiff_t, not size_t, since we prefer signed.
326 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
327 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
328 x_dnd_atoms_size and x_dnd_atoms_length.
329
330 * doprnt.c: Prefer signed to unsigned when either works.
331 * eval.c (verror):
332 * doprnt.c (doprnt):
333 * lisp.h (doprnt):
334 * xdisp.c (vmessage):
335 Use ptrdiff_t, not size_t, when using or implementing doprnt,
336 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
337 prefer signed arithmetic to avoid comparison confusion.
338 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
339 but is a bit tricky.
340
341 Assume freestanding C89 headers, string.h, stdlib.h.
342 * data.c, doprnt.c, floatfns.c, print.c:
343 Include float.h unconditionally.
344 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
345 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
346 * regex.c: Likewise for stddef.h, string.h.
347 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
348 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
349 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
350 (STDC_HEADERS): Remove obsolete defines.
351 * sysdep.c: Include limits.h unconditionally.
352
353 Assume support for memcmp, memcpy, memmove, memset.
354 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
355 * regex.c (memcmp, memcpy):
356 Remove; we assume C89 now.
357
358 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
359 (__malloc_safe_bcopy): Remove; no longer needed.
360
361 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
362 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
363 well either way, and we prefer signed to unsigned.
364
365 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
366
367 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
368 closes the connection while we're reading (bug#9182).
369
370 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
371
372 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
373 are specified (Bug#9168).
374
375 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
376
377 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
378 Found by GCC static checking and --with-wide-int on a 32-bit host.
379
380 2011-07-25 Eli Zaretskii <eliz@gnu.org>
381
382 * xdisp.c (compute_display_string_pos): Fix logic of caching
383 previous display string position. Initialize cached_prev_pos to
384 -1. Fixes slow-down at the beginning of a buffer.
385
386 2011-07-24 Eli Zaretskii <eliz@gnu.org>
387
388 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
389 for attrs[LFACE_FONTSET_INDEX].
390
391 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
392
393 * xml.c (parse_region): Remove unused local
394 that was recently introduced.
395
396 2011-07-23 Eli Zaretskii <eliz@gnu.org>
397
398 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
399 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
400
401 * xdisp.c (move_it_in_display_line_to): Record the best matching
402 position for TO_CHARPOS while scanning the line, and restore it on
403 exit if none of the characters scanned was an exact match.
404 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
405 when exact match is impossible due to invisible text, and the
406 lines are truncated.
407
408 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
409
410 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
411 for OSX >= 10.7.
412
413 2011-07-22 Eli Zaretskii <eliz@gnu.org>
414
415 Fix a significant slow-down of cursor motion with C-n, C-p,
416 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
417 auto-repeat under bidi redisplay in fontified buffers.
418 * xdisp.c (compute_stop_pos_backwards): New function.
419 (next_element_from_buffer): Call compute_stop_pos_backwards to
420 find a suitable prev_stop when we find ourselves before
421 base_level_stop.
422 (reseat): Don't look for prev_stop, as that could mean a very long
423 run.
424 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
425 <cached_disp_overlay_modiff>: Cache for last found display string
426 position.
427 (compute_display_string_pos): Return the cached position if asked
428 about the same buffer in the same area of character positions, and
429 the buffer wasn't changed since the time the display string
430 position was cached.
431
432 2011-07-22 Eli Zaretskii <eliz@gnu.org>
433
434 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
435 is an integer, which is important for empty lines. (Bug#9149)
436
437 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
438
439 * frame.c (Fmodify_frame_parameters): In tty case, update the
440 default face if necessary (Bug#4238).
441
442 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
443
444 * editfns.c (Fstring_to_char): No need to explain what a character
445 is in the docstring (Bug#6576).
446
447 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
448
449 * xml.c (parse_region): Make sure we always return a tree.
450
451 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
452
453 * xml.c (parse_region): If a document contains only comments,
454 return that, too.
455
456 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
457
458 * xml.c (make_dom): Return comments, too.
459
460 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
461
462 Port to OpenBSD.
463 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
464 and the surrounding thread.
465 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
466 rather than fgets, and retry after EINTR. Otherwise, 'emacs
467 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
468 timer goes off.
469 * s/openbsd.h (BROKEN_SIGIO): Define.
470 * unexelf.c (unexec) [__OpenBSD__]:
471 Don't update the .mdebug section of the Alpha COFF symbol table.
472
473 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
474
475 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
476 (bug#8460).
477
478 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
479
480 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
481 This fixes some race conditions on the permissions of any newly
482 created file.
483
484 * alloc.c (valid_pointer_p): Use pipe, not open.
485 This fixes some permissions issues when debugging.
486
487 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
488 If fchown fails to set both uid and gid, try to set just gid,
489 as that is sometimes allowed. Adjust the file's mode to eliminate
490 setuid or setgid bits that are inappropriate if fchown fails.
491
492 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
493
494 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
495 to compare Lisp_Objects.
496 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
497 global_gnutls_log_level, don't mistake it for a Lisp_Object.
498 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
499
500 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
501
502 * lread.c (read_integer): Unread even EOF character.
503 (read1): Likewise. Properly record start position of symbol.
504
505 * lread.c (read1): Read `#:' as empty uninterned symbol if no
506 symbol character follows.
507
508 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
509
510 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
511 This works around a problem with the previous change to Fcopy_file.
512 Recent glibc declares fchown with __attribute__((warn_unused_result)),
513 and without this change, GCC might complain about discarding
514 fchown's return value.
515
516 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
517
518 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
519
520 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
521
522 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
523
524 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
525
526 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
527 it's used from the C level.
528
529 * process.c: Use the same condition for POLL_FOR_INPUT in both
530 keyboard.c and process.c (bug#1858).
531
532 2011-07-09 Lawrence Mitchell <wence@gmx.li>
533
534 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
535 (Fgnutls_boot): Use it.
536
537 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
538
539 * doc.c (Fsubstitute_command_keys): Revert last change.
540
541 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
542
543 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
544 quotes the next character, and doesn't affect other longer
545 sequences (bug#8935).
546
547 * lread.c (syms_of_lread): Clarify that is isn't only
548 `eval-buffer' and `eval-defun' that's affected by
549 `lexical-binding' (bug#8460).
550
551 2011-07-15 Eli Zaretskii <eliz@gnu.org>
552
553 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
554 bidi redisplay when a line includes both an image and is
555 truncated.
556
557 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
558
559 Fix minor problems found by static checking.
560 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
561 (elsz): Now a signed constant, not a size_t var. We prefer signed
562 types to unsigned, to avoid integer comparison confusion. Without
563 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
564 "cannot optimize loop, the loop counter may overflow", a symptom
565 of the confusion.
566 * indent.c (Fvertical_motion): Mark locals as initialized.
567 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
568
569 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
570
571 * search.c (Fre_search_backward): Mention `case-fold-search' in
572 all the re_search_* functions (bug#8138).
573
574 * keyboard.c (Fopen_dribble_file): Document when the file is
575 closed (bug#8056).
576
577 2011-07-14 Eli Zaretskii <eliz@gnu.org>
578
579 * bidi.c (bidi_dump_cached_states): Fix format of displaying
580 bidi_cache_idx.
581
582 Support bidi reordering of display and overlay strings.
583 * xdisp.c (compute_display_string_pos)
584 (compute_display_string_end): Accept additional argument STRING.
585 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
586 (reseat_to_string): Initialize bidi_it->string.s and
587 bidi_it->string.schars.
588 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
589 NULL (avoids a crash in bidi_paragraph_init).
590 Initialize itb.string.lstring.
591 (init_iterator): Call bidi_init_it only of a valid
592 buffer position was specified. Initialize paragraph_embedding to
593 L2R.
594 (reseat_to_string): Initialize the bidi iterator.
595 (display_string): If we need to ignore text properties of
596 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
597 original value of -1 will not work with bidi.)
598 (compute_display_string_pos): First arg is now struct
599 `text_pos *'; all callers changed. Support display properties on
600 Lisp strings.
601 (compute_display_string_end): Support display properties on Lisp
602 strings.
603 (init_iterator, reseat_1, reseat_to_string): Initialize the
604 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
605 when iterating on a string not from display properties).
606 (compute_display_string_pos, compute_display_string_end):
607 Fix calculation of the object to scan. Fixes an error when using
608 arrow keys.
609 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
610 base_level_stop; instead, set base_level_stop to BEGV.
611 Fixes crashes in vertical-motion.
612 (next_element_from_buffer): Improve commentary for when
613 the iterator is before prev_stop.
614 (init_iterator): Initialize bidi_p from the default value of
615 bidi-display-reordering, not from buffer-local value. Use the
616 buffer-local value only if initializing for buffer iteration.
617 (handle_invisible_prop): Support invisible properties on strings
618 that are being bidi-reordered.
619 (set_iterator_to_next): Support bidi reordering of C strings and
620 Lisp strings.
621 (next_element_from_string): Support bidi reordering of Lisp
622 strings.
623 (handle_stop_backwards): Support Lisp strings as well.
624 (display_string): Support display of R2L glyph rows.
625 Use IT_STRING_CHARPOS when displaying from a Lisp string.
626 (init_iterator): Don't initialize it->bidi_p for strings
627 here.
628 (reseat_to_string): Initialize it->bidi_p for strings here.
629 (next_element_from_string, next_element_from_c_string)
630 (next_element_from_buffer): Add xassert's for correspondence
631 between IT's object being iterated and it->bidi_it.string
632 structure.
633 (face_before_or_after_it_pos): Support bidi iteration.
634 (next_element_from_c_string): Handle the case of the first string
635 character that is not the first one in the visual order.
636 (get_visually_first_element): New function, refactored from common
637 parts of next_element_from_buffer, next_element_from_string, and
638 next_element_from_c_string.
639 (tool_bar_lines_needed, redisplay_tool_bar)
640 (display_menu_bar): Force left-to-right direction. Add a FIXME
641 comment for making that be controlled by a user option.
642 (push_it, pop_it): Save and restore the state of the
643 bidi iterator. Save and restore the bidi_p flag.
644 (pop_it): Iterate out of display property for string iteration as
645 well.
646 (iterate_out_of_display_property): Support iteration over strings.
647 (handle_single_display_spec): Set up it->bidi_it for iteration
648 over a display string, and call bidi_init_it.
649 (handle_single_display_spec, next_overlay_string)
650 (get_overlay_strings_1, push_display_prop): Set up the bidi
651 iterator for displaying display or overlay strings.
652 (forward_to_next_line_start): Don't use the shortcut if
653 bidi-iterating.
654 (back_to_previous_visible_line_start): If handle_display_prop
655 pushed the iterator stack, restore the internal state of the bidi
656 iterator by calling bidi_pop_it same number of times.
657 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
658 and we are bidi-iterating, don't decrement the iterator position;
659 instead, set the first_elt flag in the bidi iterator, to produce
660 the same effect.
661 (reseat_1): Remove redundant setting of string_from_display_prop_p.
662 (push_display_prop): xassert that we are iterating a buffer.
663 (push_it, pop_it): Save and restore paragraph_embedding member.
664 (handle_single_display_spec, next_overlay_string)
665 (get_overlay_strings_1, reseat_1, reseat_to_string)
666 (push_display_prop): Set up the `unibyte' member of bidi_it.string
667 correctly. Don't assume unibyte strings are not bidi-reordered.
668 (compute_display_string_pos)
669 (compute_display_string_end): Fix handling the case of C string.
670 (push_it, pop_it): Save and restore from_disp_prop_p.
671 (handle_single_display_spec, push_display_prop): Set the
672 from_disp_prop_p flag.
673 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
674 (pop_it): Call iterate_out_of_display_property only if we are
675 popping after iteration over a string that came from a display
676 property. Fix a typo in popping stretch info. Add an assertion
677 for verifying that the iterator position is in sync with the bidi
678 iterator.
679 (handle_single_display_spec, get_overlay_strings_1)
680 (push_display_prop): Fix initialization of paragraph direction for
681 string when that of the parent object is not yet determined.
682 (reseat_1): Call bidi_init_it to resync the bidi
683 iterator with IT's position. (Bug#7616)
684 (find_row_edges): If ROW->start.pos gives position
685 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
686 (handle_stop, back_to_previous_visible_line_start, reseat_1):
687 Reset the from_disp_prop_p flag.
688 (SAVE_IT, RESTORE_IT): New macros.
689 (pos_visible_p, face_before_or_after_it_pos)
690 (back_to_previous_visible_line_start)
691 (move_it_in_display_line_to, move_it_in_display_line)
692 (move_it_to, move_it_vertically_backward, move_it_by_lines)
693 (try_scrolling, redisplay_window, display_line): Use them when
694 saving a temporary copy of the iterator and restoring it back.
695 (back_to_previous_visible_line_start, reseat_1)
696 (init_iterator): Empty the bidi cache "stack".
697 (move_it_in_display_line_to): If iterator ended up at
698 EOL, but we never saw any buffer positions smaller than
699 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
700 motion in bidi-reordered lines.
701 (move_it_in_display_line_to): Record prev_method and prev_pos
702 immediately before the call to set_iterator_to_next. Fixes cursor
703 motion in bidi-reordered lines with stretch glyphs and strings
704 displayed in margins. (Bug#8133) (Bug#8867)
705 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
706 TO_CHARPOS.
707 (pos_visible_p): Support positions in bidi-reordered lines.
708 Save and restore bidi cache.
709
710 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
711 (bidi_paragraph_info): Delete unused struct.
712 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
713 (bidi_cache_start): New variable.
714 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
715 to zero.
716 (bidi_cache_fetch_state, bidi_cache_search)
717 (bidi_cache_find_level_change, bidi_cache_iterator_state)
718 (bidi_cache_find, bidi_peek_at_next_level)
719 (bidi_level_of_next_char, bidi_find_other_level_edge)
720 (bidi_move_to_visually_next): Compare cache index with
721 bidi_cache_start rather than with zero.
722 (bidi_fetch_char): Accept new argument STRING; all callers
723 changed. Support iteration over a string. Support strings with
724 display properties. Support unibyte strings. Fix the type of
725 `len' according to what STRING_CHAR_AND_LENGTH expects.
726 (bidi_paragraph_init, bidi_resolve_explicit_1)
727 (bidi_resolve_explicit, bidi_resolve_weak)
728 (bidi_level_of_next_char, bidi_move_to_visually_next):
729 Support iteration over a string.
730 (bidi_set_sor_type, bidi_resolve_explicit_1)
731 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
732 can now be zero (for strings); special values 0 and -1 were
733 changed to -1 and -2, respectively.
734 (bidi_char_at_pos): New function.
735 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
736 Call it instead of FETCH_MULTIBYTE_CHAR.
737 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
738 initialized to valid values.
739 (bidi_init_it): Don't initialize charpos and bytepos with invalid
740 values.
741 (bidi_level_of_next_char): Allow the sentinel "position" to pass
742 the test for valid cached positions. Fix the logic for looking up
743 the sentinel state in the cache. GCPRO the Lisp string we are
744 iterating.
745 (bidi_push_it, bidi_pop_it): New functions.
746 (bidi_initialize): Initialize the bidi cache start stack pointer.
747 (bidi_cache_ensure_space): New function, refactored from part of
748 bidi_cache_iterator_state. Don't assume the required size is just
749 one BIDI_CACHE_CHUNK away.
750 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
751 (bidi_count_bytes, bidi_char_at_pos): New functions.
752 (bidi_cache_search): Don't assume bidi_cache_last_idx is
753 always valid if bidi_cache_idx is valid.
754 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
755 is valid if it's going to be used.
756 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
757 (bidi_cache_fetch_state, bidi_cache_search)
758 (bidi_cache_find_level_change, bidi_cache_ensure_space)
759 (bidi_cache_iterator_state, bidi_cache_find)
760 (bidi_find_other_level_edge, bidi_cache_start_stack):
761 All variables related to cache indices are now EMACS_INT.
762
763 * dispextern.h (struct bidi_string_data): New structure.
764 (struct bidi_it): New member `string'. Make flag members be 1-bit
765 fields, and put them last in the struct.
766 (compute_display_string_pos, compute_display_string_end):
767 Update prototypes.
768 (bidi_push_it, bidi_pop_it): Add prototypes.
769 (struct iterator_stack_entry): New members bidi_p,
770 paragraph_embedding, and from_disp_prop_p.
771 (struct it): Member bidi_p is now a bit field 1 bit wide.
772 (bidi_shelve_cache, bidi_unshelve_cache):
773 Declare prototypes.
774
775 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
776 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
777 and vector-like objects.
778
779 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
780 cache around display iteration.
781
782 * window.c (Fwindow_end, window_scroll_pixel_based)
783 (displayed_window_lines, Frecenter): Save and restore the bidi
784 cache around display iteration.
785
786 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
787
788 * editfns.c (Fdelete_region): Clarify the use of the named
789 parameters (bug#6788).
790
791 2011-07-14 Martin Rudalics <rudalics@gmx.at>
792
793 * indent.c (Fvertical_motion): Set and restore w->pointm when
794 saving and restoring the window's buffer (Bug#9006).
795
796 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
797
798 * editfns.c (Fstring_to_char): Clarify just what is returned
799 (bug#6576). Text by Eli Zaretskii.
800
801 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
802
803 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
804
805 2011-07-13 Eli Zaretskii <eliz@gnu.org>
806
807 * buffer.c (mmap_find): Fix a typo.
808
809 2011-07-13 Johan Bockgård <bojohan@gnu.org>
810
811 Fix execution of x selection hooks.
812 * xselect.c (Qx_lost_selection_functions)
813 (Qx_sent_selection_functions): New vars.
814 (syms_of_xselect): DEFSYM them.
815 (x_handle_selection_request): Pass Qx_sent_selection_functions
816 rather than Vx_sent_selection_functions to Frun_hook_with_args.
817 (x_handle_selection_clear,x_clear_frame_selections):
818 Pass Qx_lost_selection_functions rather than
819 Vx_lost_selection_functions to Frun_hook_with_args.
820
821 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
822
823 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
824 The old code sometimes used this field without initializing it.
825
826 * alloc.c (gc_sweep): Don't read past end of array.
827 In theory, the old code could also have corrupted Emacs internals,
828 though it'd be very unlikely.
829
830 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
831
832 * character.c (Fcharacterp): Don't advertise optional ignored
833 argument. (Bug#4026)
834
835 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
836
837 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
838 key" (bug#4257).
839
840 * window.c (Fset_window_start): Doc fix (bug#4199).
841 (Fset_window_hscroll): Ditto.
842
843 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
844
845 Fix minor new problems caught by GCC 4.6.1.
846 * term.c (init_tty): Remove unused local.
847 * xsettings.c (store_monospaced_changed): Define this function only
848 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
849 not used otherwise.
850
851 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
852
853 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
854
855 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
856
857 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
858 are the mini-buffer and the echo area (bug#3320).
859
860 * term.c (init_tty): Remove support for supdup, c10 and perq
861 terminals, which are no longer supported (bug#1482).
862
863 2011-07-10 Johan Bockgård <bojohan@gnu.org>
864
865 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
866
867 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
868
869 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
870 for non-popups (Bug#3642).
871
872 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
873
874 * alloc.c (reset_malloc_hooks): Protoize.
875 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
876 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
877 * cm.c (losecursor): Likewise.
878 * data.c (fmod): Likewise.
879 * dispnew.c (swap_glyphs_in_rows): Likewise.
880 * emacs.c (memory_warning_signal): Likewise.
881 * floatfns.c (float_error): Likewise.
882 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
883 (otf_open, font_otf_capability, generate_otf_features)
884 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
885 Likewise.
886 * image.c (pbm_read_file): Likewise.
887 * indent.c (string_display_width): Likewise.
888 * intervals.c (check_for_interval, search_for_interval)
889 (inc_interval_count, count_intervals, root_interval)
890 (adjust_intervals_for_insertion, make_new_interval): Likewise.
891 * lread.c (defalias): Likewise.
892 * ralloc.c (r_alloc_check): Likewise.
893 * regex.c (set_image_of_range_1, set_image_of_range)
894 (regex_grow_registers): Likewise.
895 * sysdep.c (strerror): Likewise.
896 * termcap.c (valid_filename_p, tprint, main): Likewise.
897 * tparam.c (main): Likewise.
898 * unexhp9k800.c (run_time_remap, save_data_space)
899 (update_file_ptrs, read_header, write_header, calculate_checksum)
900 (copy_file, copy_rest, display_header): Likewise.
901 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
902 Likewise.
903 * xdisp.c (check_it): Likewise.
904 * xfaces.c (register_color, unregister_color, unregister_colors):
905 Likewise.
906 * xfns.c (print_fontset_result): Likewise.
907 * xrdb.c (member, fatal, main): Likewise.
908
909 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
910
911 Fix minor problems found by static checking (Bug#9031).
912 * chartab.c (char_table_set_range, map_sub_char_table):
913 Remove unused locals.
914 (uniprop_table): Now static.
915 * composite.c (_work_char): Remove unused static var.
916
917 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
918
919 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
920
921 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
922
923 * gtkutil.c (qttip_cb): Remove code without function.
924
925 2011-07-09 Eli Zaretskii <eliz@gnu.org>
926
927 * w32.c (pthread_sigmask): New stub.
928
929 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
930
931 Use pthread_sigmask, not sigprocmask (Bug#9010).
932 sigprocmask is portable only for single-threaded applications, and
933 Emacs can be multi-threaded when it uses GTK.
934 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
935 (LIBES): Use it.
936 * callproc.c (Fcall_process):
937 * process.c (create_process):
938 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
939 Use pthread_sigmask, not sigprocmask.
940
941 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
942
943 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
944 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
945 wrong (Bug#8591).
946
947 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
948
949 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
950 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
951 (xg_hide_tooltip): Fix comment.
952
953 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
954 in registerServicesMenuSendTypes.
955 (validRequestorForSendType): Don't check ns_return_types.
956
957 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
958 ns_return_type.
959
960 2011-07-08 Jason Rumney <jasonr@gnu.org>
961
962 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
963 frame struct members of non-existent frames (Bug#6284).
964
965 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
966
967 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
968 variable firstTime not needed on OSX >= 10.6.
969 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
970 >= 10.5. Use setKnobProportion, setDoubleValue.
971
972 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
973 (MAC_OS_X_VERSION_10_5): Define if not defined.
974 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
975 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
976 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
977
978 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
979 cString and lossyCString on OSX >= 10.4
980
981 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
982 sizeToFit on OSX >= 10.2.
983
984 * nsimage.m (allocInitFromFile): Don't use deprecated method
985 bestRepresentationForDevice on OSX >= 10.6.
986
987 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
988 to avoid warning.
989
990 * emacs.c: Declare unexec_init_emacs_zone.
991
992 * nsgui.h: Fix compiler warning about gnulib redefining verify.
993
994 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
995
996 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
997 on svcsMenu (Bug#8842).
998
999 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1000 ns_return_types.
1001 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1002
1003 * nsterm.m (QUTF8_STRING): Declare.
1004 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1005 (validRequestorForSendType): Return type is (id).
1006 Change indexOfObjectIdenticalTo to indexOfObject.
1007 Check if we have local selection before returning self (Bug#8842).
1008 (writeSelectionToPasteboard): Put local selection into paste board
1009 if we have a local selection (Bug#8842).
1010 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1011
1012 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1013 (ns_get_local_selection): Declare.
1014
1015 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1016
1017 * keymap.c (describe_map_tree): Don't insert a double newline at
1018 the end of the buffer (bug#1169) and return whether we inserted
1019 something.
1020
1021 * callint.c (Fcall_interactively): Change "reading args" to
1022 "providing args" to try to clarify what it does (bug#1010).
1023
1024 2011-07-07 Kenichi Handa <handa@m17n.org>
1025
1026 * composite.c (composition_compute_stop_pos): Ignore a static
1027 composition starting before CHARPOS (Bug#8915).
1028
1029 * xdisp.c (handle_composition_prop): Likewise.
1030
1031 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1032
1033 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1034 (Bug#9015)
1035
1036 2011-07-07 Kenichi Handa <handa@m17n.org>
1037
1038 * character.h (unicode_category_t): New enum type.
1039
1040 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1041 (Qchar_code_property_table): New variable.
1042 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1043 (UNIPROP_COMPRESSED_FORM_P): New macros.
1044 (char_table_ascii): Uncompress the compressed values.
1045 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1046 Uncompress the compressed values.
1047 (sub_char_table_ref_and_range): Likewise.
1048 (char_table_ref_and_range): Uncompress the compressed values.
1049 (sub_char_table_set): New arg is_uniprop. Callers changed.
1050 Uncompress the compressed values.
1051 (sub_char_table_set_range): Args changed. Callers changed.
1052 (char_table_set_range): Adjuted for the above change.
1053 (map_sub_char_table): Delete args default_val and parent. Add arg
1054 top. Give decoded values to a Lisp function.
1055 (map_char_table): Adjust for the above change. Give decoded
1056 values to a Lisp function. Gcpro more variables.
1057 (uniprop_table_uncompress)
1058 (uniprop_decode_value_run_length): New functions.
1059 (uniprop_decoder, uniprop_decoder_count): New variables.
1060 (uniprop_get_decoder, uniprop_encode_value_character)
1061 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1062 New functions.
1063 (uniprop_encoder, uniprop_encoder_count): New variables.
1064 (uniprop_get_encoder, uniprop_table)
1065 (Funicode_property_table_internal, Fget_unicode_property_internal)
1066 (Fput_unicode_property_internal): New functions.
1067 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1068 Sunicode_property_table_internal, Sget_unicode_property_internal,
1069 and Sput_unicode_property_internal. Defvar_lisp
1070 char-code-property-alist.
1071
1072 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1073 Vunicode_category_table.
1074
1075 * font.c (font_range): Adjust for the change of
1076 Vunicode_category_table.
1077
1078 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1079
1080 * m/iris4d.h: Remove file, move contents ...
1081 * s/irix6-5.h: ... here.
1082
1083 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 Remove unportable assumption about struct layout (Bug#8884).
1086 * alloc.c (mark_buffer):
1087 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1088 (clone_per_buffer_values): Don't assume that
1089 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1090 This isn't true in general, and it's particularly not true
1091 if Emacs is configured with --with-wide-int.
1092 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1093 New macros, used in the buffer.c change.
1094
1095 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1096
1097 * xsettings.c: Use both GConf and GSettings if both are available.
1098 (store_config_changed_event): Add comment.
1099 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1100 (store_tool_bar_style_changed): New functions.
1101 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1102 (struct xsettings): Move font inside HAVE_XFT.
1103 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1104 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1105 Move inside HAVE_XFT.
1106 (something_changed_gsettingsCB): Rename from something_changedCB.
1107 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1108 also.
1109 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1110 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1111 (something_changed_gconfCB): Rename from something_changedCB.
1112 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1113 (parse_settings): Move check for font inside HAVE_XFT.
1114 (read_settings, apply_xft_settings): Add comment.
1115 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1116 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1117 call store_font_name_changed.
1118 (xft_settings_event): Add comment.
1119 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1120 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1121 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1122 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1123 (xsettings_initialize): Call init_gsettings last.
1124 (xsettings_get_system_font, xsettings_get_system_normal_font):
1125 Add comment.
1126
1127 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1128
1129 Random fixes. E.g., (random) never returned negative values.
1130 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1131 subseconds part to the entropy, as that's a bit more random.
1132 Prefer signed to unsigned, since the signedness doesn't matter and
1133 in general we prefer signed. When given a limit, use a
1134 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1135 latter isn't right if USE_2_TAGS_FOR_INTS.
1136 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1137 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1138
1139 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1140
1141 * textprop.c (text_property_stickiness):
1142 Obey Vtext_property_default_nonsticky.
1143 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1144 * w32fns.c (syms_of_w32fns):
1145 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1146
1147 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1148
1149 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1150 This is more efficient than Ffile_directory_p and avoids a minor race.
1151
1152 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1153
1154 * buffer.c (Foverlay_put): Say what the return value is
1155 (bug#7835).
1156
1157 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1158 is a directory before asking whether to use the file name
1159 (bug#7564).
1160 (barf_or_query_if_file_exists): Make the "File is a directory"
1161 error be more correct.
1162
1163 * fns.c (Frequire): Remove the mention of the .gz files, since
1164 that's installation-specific, but keep the mention of
1165 `get-load-suffixes'.
1166
1167 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1170 Report string overflow if the output is too long.
1171
1172 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1173
1174 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1175 (syms_of_gnutls): Remove duplicate DEFSYM for
1176 Qgnutls_bootprop_verify_hostname_error, an error for
1177 Qgnutls_bootprop_verify_error (which is no longer used).
1178
1179 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1180 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1181 Also (re)move comments that are misplaced or no longer relevant.
1182
1183 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1184
1185 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1186
1187 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1188
1189 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1190 and background color parameters if they have been changed.
1191
1192 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1193
1194 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1195
1196 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 * xsettings.c (SYSTEM_FONT): Define only when used.
1199 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1200
1201 * keymap.c (access_keymap_1): Now static.
1202
1203 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1204
1205 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1206 leave any prefix arg for the up event (Bug#1586).
1207
1208 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1209
1210 * lread.c (syms_of_lread): Mention single symbols defined by
1211 `defvar' or `defconst' (bug#7154).
1212
1213 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1214 (Frequire): Mention get-load-suffixes.
1215
1216 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1217
1218 * window.h (window): Remove clone_number slot.
1219 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1220 Remove.
1221 (make_parent_window, make_window, saved_window)
1222 (Fset_window_configuration, save_window_save): Don't deal with
1223 clone numbers.
1224 * buffer.c (Qclone_number): Remove declaration.
1225 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1226
1227 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1228
1229 Add multiple inheritance to keymaps.
1230 * keymap.c (Fmake_composed_keymap): New function.
1231 (Fset_keymap_parent): Simplify.
1232 (fix_submap_inheritance): Remove.
1233 (access_keymap_1): New function extracted from access_keymap to handle
1234 embedded parents and handle lists of maps.
1235 (access_keymap): Use it.
1236 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1237 (Fcopy_keymap): Handle embedded parents.
1238 (Fcommand_remapping, define_as_prefix): Simplify.
1239 (Fkey_binding): Simplify.
1240 (syms_of_keymap): Move minibuffer-local-completion-map,
1241 minibuffer-local-filename-completion-map,
1242 minibuffer-local-must-match-map, and
1243 minibuffer-local-filename-must-match-map to Elisp.
1244 (syms_of_keymap): Defsubr make-composed-keymap.
1245 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1246 (parse_menu_item): Trivial simplification.
1247
1248 2011-07-01 Glenn Morris <rgm@gnu.org>
1249
1250 * Makefile.in (SETTINGS_LIBS): Fix typo.
1251
1252 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1253
1254 * coding.c (Fencode_coding_string): Record the last coding system
1255 used, as the function doc string says (bug#8738).
1256
1257 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1258
1259 * xsettings.c (store_monospaced_changed): Take new font as arg and
1260 check for change against current_mono_font.
1261 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1262 (emacs_settings_constructor, emacs_settings_get_property)
1263 (emacs_settings_set_property, emacs_settings_class_init)
1264 (emacs_settings_init, gsettings_obj): Remove.
1265 (something_changedCB): New function for HAVE_GSETTINGS.
1266 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1267 with value as argument.
1268 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1269 g_settings_new (Bug#8967). Do not create gsettings_obj.
1270 Remove calls to g_settings_bind. Connect something_changedCB to
1271 "changed".
1272
1273 * xgselect.c: Add defined (HAVE_GSETTINGS).
1274 (xgselect_initialize): Ditto.
1275
1276 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1277 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1278 xg_select.
1279
1280 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * eval.c (struct backtrace): Simplify and port the data structure.
1283 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1284 signed bit field, as this assumption is not portable and it makes
1285 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1286 "char debug_on_exit : 1" as this is not portable either; instead,
1287 use the portable "unsigned int debug_on_exit : 1". Remove unused
1288 member evalargs. Remove obsolete comments about cc bombing out.
1289
1290 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1291
1292 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1293 Let HAVE_GSETTINGS override HAVE_GCONF.
1294 (store_monospaced_changed): New function.
1295 (EMACS_SETTINGS): A new type derived from GObject to handle
1296 GSettings notifications.
1297 (emacs_settings_constructor, emacs_settings_get_property)
1298 (emacs_settings_set_property, emacs_settings_class_init):
1299 New functions.
1300 (gsettings_client, gsettings_obj): New variables.
1301 (GSETTINGS_SCHEMA): New define.
1302 (something_changedCB): Call store_monospaced_changed.
1303 (init_gsettings): New function.
1304 (xsettings_initialize): Call init_gsettings.
1305 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1306 to NULL.
1307
1308 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1309 GCONF_CFLAGS/LIBS.
1310
1311 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1312
1313 * window.c (resize_root_window, grow_mini_window)
1314 (shrink_mini_window): Rename Qresize_root_window to
1315 Qwindow_resize_root_window and Qresize_root_window_vertically to
1316 Qwindow_resize_root_window_vertically.
1317
1318 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1321
1322 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1323
1324 * makefile.w32-in: Redesign dependencies so they reflect more
1325 clearly which files are directly included by each source file,
1326 and not through other includes.
1327
1328 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1329
1330 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1331 (sort_overlays, overlay_strings): When an overlay's clone number
1332 matches the window's clone number process the overlay even if
1333 the overlay's window property doesn't match the current window.
1334
1335 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1336 (Fwindow_hchild): Rename to Fwindow_left_child.
1337 (Fwindow_next): Rename to Fwindow_next_sibling.
1338 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1339 (resize_window_check): Rename to window_resize_check.
1340 (resize_window_apply): Rename to window_resize_apply.
1341 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1342 (Fdelete_other_windows_internal, resize_frame_windows)
1343 (Fsplit_window_internal, Fdelete_window_internal)
1344 (grow_mini_window, shrink_mini_window)
1345 (Fresize_mini_window_internal): Fix callers accordingly.
1346
1347 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1348
1349 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1350 (emacs_fixed_set_min_size): Remove.
1351 (emacs_fixed_new): Take frame as argument.
1352
1353 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1354 (_EmacsFixedPrivate): Remove minwidth/height.
1355 Add struct frame *f.
1356 (emacs_fixed_init): Initialize priv->f.
1357 (get_parent_class, emacs_fixed_set_min_size): Remove.
1358 (emacs_fixed_new): Set priv->f to argument.
1359 (emacs_fixed_get_preferred_width)
1360 (emacs_fixed_get_preferred_height): Use min_width/height from
1361 frames size_hint to set minimum and natural (Bug#8919).
1362 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1363 and use min_width/height from frames size_hint to set
1364 min_width/height (Bug#8919).
1365
1366 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1367 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1368 Fix indentation.
1369
1370 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1371
1372 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1373 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1374 called at ZV.
1375
1376 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1377
1378 * process.c (wait_reading_process_output): Bypass select if
1379 waiting for a cell while ignoring keyboard input, and input is
1380 pending. Suggested by Jan Djärv (Bug#8869).
1381
1382 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 Use gnulib's dup2 module instead of rolling our own.
1385 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1386
1387 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1388
1389 * dispnew.c (scrolling_window): Before scrolling, turn off a
1390 mouse-highlight in the window being scrolled.
1391
1392 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1393
1394 Move DEFSYM to lisp.h and use everywhere.
1395
1396 * character.h (DEFSYM): Move declaration...
1397 * lisp.h (DEFSYM): ...here.
1398
1399 * gnutls.c:
1400 * minibuf.c:
1401 * w32menu.c:
1402 * w32proc.c:
1403 * w32select.c: Don't include character.h.
1404
1405 * alloc.c (syms_of_alloc):
1406 * buffer.c (syms_of_buffer):
1407 * bytecode.c (syms_of_bytecode):
1408 * callint.c (syms_of_callint):
1409 * casefiddle.c (syms_of_casefiddle):
1410 * casetab.c (init_casetab_once):
1411 * category.c (init_category_once, syms_of_category):
1412 * ccl.c (syms_of_ccl):
1413 * cmds.c (syms_of_cmds):
1414 * composite.c (syms_of_composite):
1415 * dbusbind.c (syms_of_dbusbind):
1416 * dired.c (syms_of_dired):
1417 * dispnew.c (syms_of_display):
1418 * doc.c (syms_of_doc):
1419 * editfns.c (syms_of_editfns):
1420 * emacs.c (syms_of_emacs):
1421 * eval.c (syms_of_eval):
1422 * fileio.c (syms_of_fileio):
1423 * fns.c (syms_of_fns):
1424 * frame.c (syms_of_frame):
1425 * fringe.c (syms_of_fringe):
1426 * insdel.c (syms_of_insdel):
1427 * keymap.c (syms_of_keymap):
1428 * lread.c (init_obarray, syms_of_lread):
1429 * macros.c (syms_of_macros):
1430 * msdos.c (syms_of_msdos):
1431 * print.c (syms_of_print):
1432 * process.c (syms_of_process):
1433 * search.c (syms_of_search):
1434 * sound.c (syms_of_sound):
1435 * syntax.c (init_syntax_once, syms_of_syntax):
1436 * terminal.c (syms_of_terminal):
1437 * textprop.c (syms_of_textprop):
1438 * undo.c (syms_of_undo):
1439 * w32.c (globals_of_w32):
1440 * window.c (syms_of_window):
1441 * xdisp.c (syms_of_xdisp):
1442 * xfaces.c (syms_of_xfaces):
1443 * xfns.c (syms_of_xfns):
1444 * xmenu.c (syms_of_xmenu):
1445 * xsettings.c (syms_of_xsettings):
1446 * xterm.c (syms_of_xterm): Use DEFSYM.
1447
1448 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1449
1450 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1451
1452 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 Integer and buffer overflow fixes (Bug#8873).
1455
1456 * print.c (printchar, strout): Check for string overflow.
1457 (PRINTPREPARE, printchar, strout):
1458 Don't set size unless allocation succeeds.
1459
1460 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1461 for sizes. Check for string overflow more accurately.
1462 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1463
1464 * macros.c: Integer and buffer overflow fixes.
1465 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1466 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1467 Use ptrdiff_t, not int, for sizes.
1468 Don't increment bufsize until after realloc succeeds.
1469 Check for size-calculation overflow.
1470 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1471
1472 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1473
1474 * lread.c: Integer overflow fixes.
1475 (read_integer): Radix is now EMACS_INT, not int,
1476 to improve quality of diagnostics for out-of-range radices.
1477 Calculate buffer size correctly for out-of-range radices.
1478 (read1): Check for integer overflow in radices, and in
1479 read-circle numbers.
1480 (read_escape): Avoid int overflow.
1481 (Fload, openp, read_buffer_size, read1)
1482 (substitute_object_recurse, read_vector, read_list, map_obarray):
1483 Use ptrdiff_t, not int, for sizes.
1484 (read1): Use EMACS_INT, not int, for sizes.
1485 Check for size overflow.
1486
1487 * image.c (cache_image): Check for size arithmetic overflow.
1488
1489 * lread.c: Integer overflow issues.
1490 (saved_doc_string_size, saved_doc_string_length)
1491 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1492 Now ptrdiff_t, not int.
1493 (read1): Don't assume doc string length fits in int. Check for
1494 out-of-range doc string lengths.
1495 (read_list): Don't assume file position fits in int.
1496 (read_escape): Check for hex character overflow.
1497
1498 2011-06-22 Leo Liu <sdl.web@gmail.com>
1499
1500 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1501 Move to minibuffer.el.
1502
1503 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1506 The following patches are for when GLYPH_DEBUG && !XASSERT.
1507 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1508 * dispnew.c (flush_stdout):
1509 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1510 Mark as externally visible.
1511 * dispnew.c (check_window_matrix_pointers): Now static.
1512 * dispnew.c (window_to_frame_vpos):
1513 * xfns.c (unwind_create_frame):
1514 * xterm.c (x_check_font): Remove unused local.
1515 * scroll.c (CHECK_BOUNDS):
1516 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1517 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1518 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1519 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1520 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1521 Now static.
1522 (debug_method_add): Use va_list and vsprintf rather than relying
1523 on undefined behavior with wrong number of arguments.
1524 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1525 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1526 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1527 since we're not interested in debugging glyphs with old libraries.
1528 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1529 GCC 4.6.0's static checking.
1530
1531 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 Integer overflow and signedness fixes (Bug#8873).
1534 A few related buffer overrun fixes, too.
1535
1536 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1537
1538 * dispextern.h (struct face.stipple):
1539 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1540 (x_bitmap_mask, x_allocate_bitmap_record)
1541 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1542 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1543 (x_create_bitmap_from_xpm_data):
1544 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1545 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1546 (.bitmaps_last):
1547 * xfaces.c (load_pixmap):
1548 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1549 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1550 (.bitmaps_last, struct x_output.icon_bitmap):
1551 Use ptrdiff_t, not int, for bitmap indexes.
1552 (x_allocate_bitmap_record): Check for size overflow.
1553 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1554
1555 Use ptrdiff_t, not int, for overlay counts.
1556 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1557 * editfns.c (overlays_around, get_pos_property):
1558 * textprop.c (get_char_property_and_overlay):
1559 * xdisp.c (next_overlay_change, note_mouse_highlight):
1560 * xfaces.c (face_at_buffer_position):
1561 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1562 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1563 (Fnext_overlay_change, Fprevious_overlay_change)
1564 (mouse_face_overlay_overlaps, Foverlays_in):
1565 Use ptrdiff_t, not int, for sizes.
1566 (overlays_at, overlays_in): Check for size-calculation overflow.
1567
1568 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1569
1570 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1571 (x_session_initialize): Do not assume string length fits in int.
1572
1573 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1574 This is unlikely, but can occur if DPI is outlandish.
1575
1576 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1577 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1578
1579 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1580 * xrdb.c (magic_file_p, search_magic_path):
1581 Omit last arg SUFFIX; it was always 0. All callers changed.
1582 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1583
1584 * xfont.c (xfont_match): Avoid need for strlen.
1585
1586 * xfns.c: Don't assume strlen fits in int.
1587 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1588
1589 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1590 not unsigned long, as we prefer signed integers. All callers changed.
1591 Detect integer overflow in repeat count.
1592 (message_dolog): Don't assume print length fits in 39 bytes.
1593 (display_mode_element): Don't assume strlen fits in int.
1594
1595 * termcap.c: Don't assume sizes fit in int and never overflow.
1596 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1597 (gobble_line): Check for size-calculation overflow.
1598
1599 * minibuf.c (Fread_buffer):
1600 * lread.c (intern, intern_c_string):
1601 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1602 Don't assume string length fits in int.
1603
1604 * keyboard.c (parse_tool_bar_item):
1605 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1606
1607 * font.c: Don't assume string length fits in int.
1608 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1609 Use ptrdiff_t, not int.
1610 (font_intern_prop): Don't assume string length fits in int.
1611 Don't assume integer property fits in fixnum.
1612 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1613
1614 * filelock.c: Fix some buffer overrun and integer overflow issues.
1615 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1616 Reformulate so as not to need the command string.
1617 Invoke gzip -cd rather than gunzip, as it's more portable.
1618 (lock_info_type, lock_file_1, lock_file):
1619 Don't assume pid_t and time_t fit in unsigned long.
1620 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1621 (current_lock_owner): Prefer signed type for sizes.
1622 Use memcpy, not strncpy, where memcpy is what is really wanted.
1623 Don't assume (via atoi) that time_t and pid_t fit in int.
1624 Check for time_t and/or pid_t out of range, e.g., via a network share.
1625 Don't alloca where an auto var works fine.
1626
1627 * fileio.c: Fix some integer overflow issues.
1628 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1629 Don't assume string length fits in int.
1630 (directory_file_name): Don't assume string length fits in long.
1631 (make_temp_name): Don't assume pid fits in int, or that its print
1632 length is less than 20.
1633
1634 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1635
1636 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1637
1638 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1639
1640 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1641 We prefer signed integers, even for size calculations.
1642
1643 * emacs.c: Don't assume string length fits in 'int'.
1644 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1645 (main): Don't invoke strlen when not needed.
1646
1647 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1648 (XD_DEBUG_MESSAGE): Don't waste a byte.
1649
1650 * callproc.c (getenv_internal_1, getenv_internal)
1651 (Fgetenv_internal):
1652 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1653
1654 * lread.c (invalid_syntax): Omit length argument.
1655 All uses changed. This doesn't fix a bug, but it simplifies the
1656 code away from its former Hollerith-constant appearance, and it's
1657 one less 'int' to worry about when looking at integer-overflow issues.
1658 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1659
1660 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1661 This didn't break anything, but it didn't help either.
1662 It's confusing to put a bogus integer in a place where the actual
1663 value does not matter.
1664 (LIST_END_P): Remove unused macro and its bogus comment.
1665 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1666
1667 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1668 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1669 implementation.
1670 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1671 We prefer signed types, and the value cannot exceed the EMACS_INT
1672 range anyway (because otherwise the length would not be representable).
1673 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1674 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1675 This avoids a GCC warning when WIDE_EMACS_INT.
1676
1677 * indent.c (sane_tab_width): New function.
1678 (current_column, scan_for_column, Findent_to, position_indentation)
1679 (compute_motion): Use it. This is just for clarity.
1680 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1681
1682 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1683
1684 * lisp.h (lint_assume): New macro.
1685 * composite.c (composition_gstring_put_cache):
1686 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1687
1688 * editfns.c, insdel.c:
1689 Omit unnecessary forward decls, to simplify future changes.
1690
1691 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1692
1693 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1694
1695 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1696 Use much-faster test for byte-length change.
1697 Don't assume string byte-length fits in 'int'.
1698 Check that character arg fits in 'int'.
1699 (mapcar1): Declare byte as byte, for clarity.
1700
1701 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1702
1703 * fns.c (concat): Catch string overflow earlier.
1704 Do not rely on integer wraparound.
1705
1706 * dispextern.h (struct it.overlay_strings_charpos)
1707 (struct it.selective): Now EMACS_INT, not int.
1708 * xdisp.c (forward_to_next_line_start)
1709 (back_to_previous_visible_line_start)
1710 (reseat_at_next_visible_line_start, next_element_from_buffer):
1711 Don't arbitrarily truncate the value of 'selective' to int.
1712
1713 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1714
1715 * composite.c: Don't truncate sizes to 'int'.
1716 (composition_gstring_p, composition_reseat_it)
1717 (composition_adjust_point): Use EMACS_INT, not int.
1718 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1719 not EMACS_UINT, for indexes.
1720
1721 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1722
1723 * buffer.c: Include <verify.h>.
1724 (struct sortvec.priority, struct sortstr.priority):
1725 Now EMACS_INT, not int.
1726 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1727 (struct sortstr.size, record_overlay_string)
1728 (struct sortstrlist.size, struct sortlist.used):
1729 Don't truncate size to int.
1730 (record_overlay_string): Check for size-calculation overflow.
1731 (init_buffer_once): Check at compile-time, not run-time.
1732
1733 2011-06-22 Jim Meyering <meyering@redhat.com>
1734
1735 Don't leak an XBM-image-sized buffer
1736 * image.c (xbm_load): Free the image buffer after using it.
1737
1738 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 Port to Sun C.
1741 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1742 that Sun C diagnosed.
1743 * fns.c (secure_hash): Fix pointer signedness issue.
1744 * intervals.c (static_offset_intervals): New function.
1745 (offset_intervals): Use it.
1746
1747 2011-06-21 Leo Liu <sdl.web@gmail.com>
1748
1749 * deps.mk (fns.o):
1750 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1751 sha512.h.
1752
1753 * fns.c (secure_hash): Rename from crypto_hash_function and change
1754 the first arg to accept symbols.
1755 (Fsecure_hash): New primitive.
1756 (syms_of_fns): New symbols.
1757
1758 2011-06-20 Deniz Dogan <deniz@dogan.se>
1759
1760 * process.c (Fset_process_buffer): Clarify return value in
1761 docstring.
1762
1763 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1764
1765 * dispnew.c (add_window_display_history): Use BVAR.
1766
1767 * xdisp.c (debug_method_add): Use BVAR.
1768 (check_window_end, dump_glyph_matrix, dump_glyph)
1769 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1770
1771 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1772 Likewise.
1773
1774 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1775 check till after the cache is created in init_frame_faces.
1776
1777 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1778
1779 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1780
1781 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1784 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1785 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1786
1787 Improve buffer-overflow checking (Bug#8873).
1788 * fileio.c (Finsert_file_contents):
1789 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1790 Remove the old (too-loose) buffer overflow checks.
1791 They weren't needed, since make_gap checks for buffer overflow.
1792 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1793 The old code merely checked for Emacs fixnum overflow, and relied
1794 on undefined (wraparound) behavior. The new code avoids undefined
1795 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1796
1797 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1798 Tune. Don't use wider integers than needed. Don't use alloca.
1799 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1800
1801 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1802
1803 * insdel.c, lisp.h (buffer_overflow): New function.
1804 (insert_from_buffer_1, replace_range, replace_range_2):
1805 * insdel.c (make_gap_larger):
1806 * editfns.c (Finsert_char):
1807 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1808
1809 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1810
1811 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1812
1813 Integer overflow and signedness fixes (Bug#8873).
1814
1815 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1816 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1817
1818 * fileio.c: Don't assume EMACS_INT fits in off_t.
1819 (emacs_lseek): New static function.
1820 (Finsert_file_contents, Fwrite_region): Use it.
1821 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1822
1823 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1824
1825 * fns.c: Don't overflow int when computing a list length.
1826 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1827 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1828 truncation on 64-bit hosts. Check for QUIT every
1829 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1830 faster and is responsive enough.
1831 (Flength): Report an error instead of overflowing an integer.
1832 (Fsafe_length): Return a float if the value is not representable
1833 as a fixnum. This shouldn't happen except in contrived situations.
1834 (Fnthcdr, Fsort): Don't assume list length fits in int.
1835 (Fcopy_sequence): Don't assume vector length fits in int.
1836
1837 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1838 (header_size, word_size): New constants.
1839 (allocate_vectorlike): Don't check size overflow here.
1840 (allocate_vector): Check it here instead, since this is the only
1841 caller of allocate_vectorlike that could cause overflow.
1842 Check that the new vector's length is representable as a fixnum.
1843
1844 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1845 The previous code was bogus. For example, next_almost_prime (32)
1846 returned 39, which is undesirable as it is a multiple of 3; and
1847 next_almost_prime (24) returned 25, which is a multiple of 5 so
1848 why was the code bothering to check for multiples of 7?
1849
1850 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1851
1852 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1853
1854 Variadic C functions now count arguments with ptrdiff_t.
1855 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1856 Back then I didn't know that the Emacs coding style prefers signed int.
1857 Also, in the meantime I found a few more instances where arguments
1858 were being counted with int, which may truncate counts on 64-bit
1859 machines, or EMACS_INT, which may be unnecessarily wide.
1860 * lisp.h (struct Lisp_Subr.function.aMANY)
1861 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1862 Arg counts are now ptrdiff_t, not size_t.
1863 All variadic functions and their callers changed accordingly.
1864 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1865 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1866 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1867 * callint.c (Fcall_interactively): Check arg count for overflow,
1868 to avoid potential buffer overrun. Use signed char, not 'int',
1869 for 'varies' array, so that we needn't bother to check its size
1870 calculation for overflow.
1871 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1872 * eval.c (apply_lambda):
1873 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1874 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1875 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1876
1877 * callint.c (Fcall_interactively): Don't use index var as event count.
1878
1879 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1880 * mem-limits.h (SIZE): Remove; no longer used.
1881
1882 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1883
1884 Remove unnecessary casts.
1885 * xterm.c (x_term_init):
1886 * xfns.c (x_set_border_pixel):
1887 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1888 These aren't needed now that we assume ANSI C.
1889
1890 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1891 It's more likely to cause problems (due to unsigned overflow)
1892 than to cure them.
1893
1894 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1895
1896 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1897
1898 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1899
1900 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1901
1902 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1903
1904 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1905
1906 GLYPH_CODE_FACE returns EMACS_INT, not int.
1907 * dispextern.h (merge_faces):
1908 * xfaces.c (merge_faces):
1909 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1910 Don't assume EMACS_INT fits in int.
1911
1912 * character.h (CHAR_VALID_P): Remove unused parameter.
1913 * fontset.c, lisp.h, xdisp.c: All uses changed.
1914
1915 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1916
1917 * fns.c (concat): Minor tuning based on overflow analysis.
1918 This doesn't fix any bugs. Use int to hold character, instead
1919 of constantly refetching from Emacs object. Use XFASTINT, not
1920 XINT, for value known to be a character. Don't bother comparing
1921 a single byte to 0400, as it's always less.
1922
1923 * floatfns.c (Fexpt):
1924 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1925
1926 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1927 for characters.
1928
1929 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1930
1931 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1932 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1933 incorrectly succeed when S was a string, because 4294967386 was
1934 truncated before it was used.
1935
1936 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1937 Otherwise, an out-of-range integer could cause undefined behavior
1938 on a 64-bit host.
1939
1940 * composite.c: Use int, not EMACS_INT, for characters.
1941 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1942 EMACS_INT, for values that are known to be in character range.
1943 This doesn't fix any bugs but is the usual style inside Emacs and
1944 may generate better code on 32-bit machines.
1945
1946 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1947 This is for reasons similar to the recent CHAR_STRING fix.
1948 * charset.c (Fencode_char): Check that character arg is actually
1949 a character. Pass an int to ENCODE_CHAR.
1950 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1951 wider than 'int', as a compile-time check to prevent future regressions
1952 in this area.
1953
1954 * character.c (char_string): Remove unnecessary casts.
1955
1956 Make sure a 64-bit char is never passed to CHAR_STRING.
1957 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1958 by silently ignoring the top 32 bits, allowing some values
1959 that were far too large to be valid characters.
1960 * character.h: Include <verify.h>.
1961 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1962 arguments are no wider than unsigned, as a compile-time check
1963 to prevent future regressions in this area.
1964 * data.c (Faset):
1965 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1966 (Fsubst_char_in_region):
1967 * fns.c (concat):
1968 * xdisp.c (decode_mode_spec_coding):
1969 Adjust to CHAR_STRING's new requirement.
1970 * editfns.c (Finsert_char, Fsubst_char_in_region):
1971 * fns.c (concat): Check that character args are actually
1972 characters. Without this test, these functions did the wrong
1973 thing with wildly out-of-range values on 64-bit hosts.
1974
1975 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1976 These casts should not be needed on 32-bit hosts, either.
1977 * keyboard.c (read_char):
1978 * lread.c (Fload): Remove casts to unsigned.
1979
1980 * lisp.h (UNSIGNED_CMP): New macro.
1981 This fixes comparison bugs on 64-bit hosts.
1982 (ASCII_CHAR_P): Use it.
1983 * casefiddle.c (casify_object):
1984 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1985 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1986 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1987 * dispextern.h (FACE_FROM_ID):
1988 * keyboard.c (read_char): Use UNSIGNED_CMP.
1989
1990 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1991 not to EMACS_INT, to avoid GCC warning.
1992
1993 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1994
1995 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1996 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1997 isn't needed on 32-bit machines.
1998
1999 * buffer.c (Fgenerate_new_buffer_name):
2000 Use EMACS_INT for count, not int.
2001 (advance_to_char_boundary): Return EMACS_INT, not int.
2002
2003 * data.c (Qcompiled_function): Now static.
2004
2005 * window.c (window_body_lines): Now static.
2006
2007 * image.c (gif_load): Rename local to avoid shadowing.
2008
2009 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2010 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2011 * alloc.c (make_save_value): Integer argument is now of type
2012 ptrdiff_t, not int.
2013 (mark_object): Use ptrdiff_t, not int.
2014 * lisp.h (pD): New macro.
2015 * print.c (print_object): Use it.
2016
2017 * alloc.c: Use EMACS_INT, not int, to count objects.
2018 (total_conses, total_markers, total_symbols, total_vector_size)
2019 (total_free_conses, total_free_markers, total_free_symbols)
2020 (total_free_floats, total_floats, total_free_intervals)
2021 (total_intervals, total_strings, total_free_strings):
2022 Now EMACS_INT, not int. All uses changed.
2023 (Fgarbage_collect): Compute overall total using a double, so that
2024 integer overflow is less likely to be a problem. Check for overflow
2025 when converting back to an integer.
2026 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2027 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2028 These were 'int' variables that could overflow on 64-bit hosts;
2029 they were never used, so remove them instead of repairing them.
2030 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2031 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2032 Previously, this ceilinged at INT_MAX, but that doesn't work on
2033 64-bit machines.
2034 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2035
2036 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2037 (allocate_vectorlike): Check for ptrdiff_t overflow.
2038 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2039 when a (possibly-narrower) signed value would do just as well.
2040 We prefer using signed arithmetic, to avoid comparison confusion.
2041
2042 * alloc.c: Catch some string size overflows that we were missing.
2043 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2044 for convenience in STRING_BYTES_MAX.
2045 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2046 The definition here is exact; the one in lisp.h was approximate.
2047 (allocate_string_data): Check for string overflow. This catches
2048 some instances we weren't catching before. Also, it catches
2049 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2050 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2051 and ptrdiff_t and EMACS_INT are both 64 bits.
2052
2053 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2054 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2055 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2056
2057 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2058
2059 * alloc.c (Fmake_string): Check for out-of-range init.
2060
2061 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2062
2063 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2064
2065 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2066
2067 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2068 xg_get_default_scrollbar_width.
2069
2070 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2071 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2072 (style_changed_cb): Call update_theme_scrollbar_width and call
2073 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2074 all frames (Bug#8505).
2075 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2076 Call gtk_window_set_resizable if HAVE_GTK3.
2077 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2078 and height if HAVE_GTK3 (Bug#8505).
2079 (scroll_bar_width_for_theme): New variable.
2080 (update_theme_scrollbar_width): New function.
2081 (xg_get_default_scrollbar_width): Move code to
2082 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2083 (xg_initialize): Call update_theme_scrollbar_width.
2084
2085 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2086
2087 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2088
2089 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2090
2091 * frame.c (make_frame): Call other_buffer_safely instead of
2092 other_buffer.
2093
2094 * window.c (temp_output_buffer_show): Call display_buffer with
2095 second argument Vtemp_buffer_show_specifiers and reset latter
2096 immediately after the call.
2097 (Vtemp_buffer_show_specifiers): New variable.
2098 (auto_window_vscroll_p, next_screen_context_lines)
2099 (Vscroll_preserve_screen_position): Remove leading asterisks from
2100 doc-strings.
2101
2102 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2103
2104 Fix minor problems found by GCC 4.6.0 static checking.
2105 * buffer.c (Qclone_number): Remove for now, as it's unused.
2106 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2107 (record_buffer): Remove unused local.
2108 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2109 (set_frame_buffer_list): Remove; unused.
2110 * frame.h (other_visible_frames): Remove decl.
2111 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2112 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2113 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2114 if HAVE_GPM.
2115 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2116 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2117 Define only if HAVE_GPM.
2118 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2119 (update_hints_inhibit): Remove; never set. All uses removed.
2120 * widgetprv.h (emacsFrameClassRec): Remove decl.
2121 * window.c (delete_deletable_window): Now returns void, since it
2122 wasn't returning anything.
2123 (compare_window_configurations): Remove unused locals.
2124 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2125 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2126 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2127 the same widths as pointers. This follows up on the 2011-05-06 patch.
2128 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2129 * xterm.h: Likewise.
2130 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2131
2132 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2133
2134 * makefile.w32-in: Update dependencies.
2135 (LISP_H): Add lib/intprops.h.
2136
2137 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2138
2139 * image.c (gif_load): Add animation frame delay to the metadata.
2140 (syms_of_image): Use DEFSYM. New symbol `delay'.
2141
2142 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2143
2144 * window.c (delete_deletable_window): Re-add.
2145 (Fset_window_configuration): Rewrite to handle dead buffers and
2146 consequently deletable windows.
2147 (window_tree, Fwindow_tree): Remove. Supply functionality in
2148 window.el.
2149 (compare_window_configurations): Simplify code.
2150
2151 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2152
2153 * image.c (imagemagick_load_image): Fix type mismatch.
2154 (Fimagemagick_types): Likewise.
2155
2156 * window.h (replace_buffer_in_windows): Declare.
2157
2158 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2159
2160 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2161 Qclone_number. Remove external declaration of Qdelete_window.
2162 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2163 code.
2164 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2165 Run Qbuffer_list_update_hook if allowed.
2166 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2167 buffer list implementation.
2168 (other_buffer_safely): New function.
2169 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2170 calls to replace_buffer_in_windows and
2171 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2172 if allowed.
2173 (record_buffer): Inhibit quitting and rewrite using quittable
2174 functions. Run Qbuffer_list_update_hook if allowed.
2175 (Frecord_buffer, Funrecord_buffer): New functions.
2176 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2177 Move switch-to-buffer to window.el.
2178 (bury-buffer): Move to window.el.
2179 (Vbuffer_list_update_hook): New variable.
2180
2181 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2182 section.
2183
2184 * window.h (resize_frame_windows): Move up in code.
2185 (Fwindow_frame): Remove EXFUN.
2186 (replace_buffer_in_all_windows): Remove prototype.
2187 (replace_buffer_in_windows_safely): Add prototype.
2188
2189 * window.c: Declare Qdelete_window static again. Move down
2190 declaration of select_count.
2191 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2192 (Fother_window): Move to window.el.
2193 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2194 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2195 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2196 window.el.
2197 (replace_buffer_in_windows): Implement by calling
2198 Qreplace_buffer_in_windows.
2199 (replace_buffer_in_all_windows): Remove with some functionality
2200 moved into replace_buffer_in_windows_safely.
2201 (replace_buffer_in_windows_safely): New function.
2202 (select_window_norecord, select_frame_norecord): Move in front
2203 of run_window_configuration_change_hook. Remove now obsolete
2204 declarations.
2205 (Fset_window_buffer): Rewrite doc-string.
2206 Call Qrecord_window_buffer.
2207 (keys_of_window): Move binding for other-window to window.el.
2208
2209 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2210
2211 * dispextern.h (struct image): Replace data member, whose int_val
2212 and ptr_val fields were not used by anything, with a single
2213 lisp_val object.
2214
2215 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2216 (gif_clear_image, gif_load, imagemagick_load_image)
2217 (gs_clear_image, gs_load): Callers changed.
2218
2219 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 * buffer.h: Include <time.h>, for time_t.
2222 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2223
2224 Fix minor problems found by static checking.
2225
2226 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2227
2228 Make identifiers static if they are not used in other modules.
2229 * data.c (Qcompiled_function, Qframe, Qvector):
2230 * image.c (QimageMagick, Qsvg):
2231 * minibuf.c (Qmetadata):
2232 * window.c (resize_window_check, resize_root_window): Now static.
2233 * window.h (resize_window_check, resize_root_window): Remove decls.
2234
2235 * window.c (window_deletion_count, delete_deletable_window):
2236 Remove; unused.
2237 (window_body_lines): Now static.
2238 (Fdelete_other_windows_internal): Mark vars as initialized.
2239 Make sure 'resize_failed' is initialized.
2240 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2241 (resize_window_apply): Remove unused local.
2242 * window.h (delete_deletable_window): Remove decl.
2243
2244 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2245 (imagemagick_load_image): Fix pointer signedness problem by changing
2246 last arg from unsigned char * to char *. All uses changed.
2247 Also, fix a local for similar reasons.
2248 Remove unused locals. Remove locals to avoid shadowing.
2249 (fn_rsvg_handle_free): Remove; unused.
2250 (svg_load, svg_load_image): Fix pointer signedness problem.
2251 (imagemagick_load_image): Don't use garbage pointer image_wand.
2252
2253 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2254
2255 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2256
2257 * image.c (gif_load): Fix omitted cast error introduced by
2258 2011-06-06 change.
2259
2260 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2261
2262 * window.h (resize_proportionally, orig_total_lines)
2263 (orig_top_line): Remove from window structure.
2264 (set_window_height, set_window_width, change_window_heights)
2265 (Fdelete_window): Remove prototypes.
2266 (resize_frame_windows): Remove duplicate declaration.
2267
2268 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2269
2270 * window.h (resize_frame_windows, resize_window_check)
2271 (delete_deletable_window, resize_root_window)
2272 (resize_frame_windows): Declare prototypes.
2273
2274 * window.c (resize_window_apply): Make definition be "static" to
2275 match the prototype.
2276
2277 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2278
2279 * window.c: Remove declarations of Qwindow_size_fixed,
2280 window_min_size_1, window_min_size_2, window_min_size,
2281 size_window, window_fixed_size_p, enlarge_window, delete_window.
2282 Remove static from declaration of Qdelete_window, it's
2283 temporarily needed by Fbury_buffer.
2284 (replace_window): Don't assign orig_top_line and
2285 orig_total_lines.
2286 (Fdelete_window, delete_window): Remove. Window deletion is
2287 handled by window.el.
2288 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2289 Replace Fdelete_window calls with calls to Qdelete_window.
2290 (Fdelete_other_windows): Remove. Deleting other windows is
2291 handled by window.el.
2292 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2293 handled in window.el.
2294 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2295 Window minimum sizes are handled in window.el.
2296 (shrink_windows, size_window, set_window_height)
2297 (set_window_width, change_window_heights, window_height)
2298 (window_width, CURBEG, CURSIZE, enlarge_window)
2299 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2300 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2301 handled in window.el.
2302 (make_dummy_parent): Rename to make_parent_window and give it a
2303 second argument horflag.
2304 (make_window): Don't set resize_proportionally any more.
2305 (Fsplit_window): Remove. Windows are split in window.el.
2306 (save_restore_action, save_restore_orig_size)
2307 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2308 Resize mini windows in window.el.
2309 (grow_mini_window, shrink_mini_window): Implement by calling
2310 Qresize_root_window_vertically, resize_window_check and
2311 resize_window_apply.
2312 (saved_window, Fset_window_configuration, save_window_save):
2313 Do not handle orig_top_line, orig_total_lines, and
2314 resize_proportionally.
2315 (window_min_height, window_min_width): Move to window.el.
2316 (keys_of_window): Move bindings for delete-other-windows,
2317 split-window, delete-window and enlarge-window to window.el.
2318
2319 * buffer.c: Temporarily extern Qdelete_window.
2320 (Fbury_buffer): Temporarily call Qdelete_window instead of
2321 Fdelete_window (Fbury_buffer will move to window.el soon).
2322
2323 * frame.c (set_menu_bar_lines_1): Remove code handling
2324 orig_top_line and orig_total_lines.
2325
2326 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2327 set_window_height but set heights directly.
2328 (change_frame_size_1): Use resize_frame_windows.
2329
2330 * xdisp.c (init_xdisp): Don't use set_window_height but set
2331 heights directly.
2332
2333 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2334 Use resize_frame_windows instead of change_window_heights and run
2335 run_window_configuration_change_hook.
2336
2337 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2338 instead of change_window_heights and run
2339 run_window_configuration_change_hook.
2340
2341 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2342
2343 * window.c (replace_window): Rename second argument REPLACEMENT to
2344 NEW. New third argument SETFLAG. Rewrite.
2345 (delete_window, make_dummy_parent): Call replace_window with
2346 third argument 1.
2347 (window_list_1): Move down in code.
2348 (run_window_configuration_change_hook): Move set_buffer part
2349 before select_frame_norecord part in order to unwind correctly.
2350 Rename count1 to count.
2351 (recombine_windows, delete_deletable_window, resize_root_window)
2352 (Fdelete_other_windows_internal)
2353 (Frun_window_configuration_change_hook, make_parent_window)
2354 (resize_window_check, resize_window_apply, Fresize_window_apply)
2355 (resize_frame_windows, Fsplit_window_internal)
2356 (Fdelete_window_internal, Fresize_mini_window_internal):
2357 New functions.
2358 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2359
2360 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2361
2362 * window.h (window): Add some new members to window structure -
2363 normal_lines, normal_cols, new_total, new_normal, clone_number,
2364 splits, nest, prev_buffers, next_buffers.
2365 (WINDOW_TOTAL_SIZE): Move here from window.c.
2366 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2367
2368 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2369 Remove.
2370 (make_dummy_parent): Set new members of windows structure.
2371 (make_window): Move down in code. Handle new members of window
2372 structure.
2373 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2374 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2375 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2376 (Fset_window_prev_buffers, Fwindow_next_buffers)
2377 (Fset_window_next_buffers, Fset_window_clone_number):
2378 New functions.
2379 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2380 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2381 Doc-string fixes.
2382 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2383 Argument WINDOW can be now internal window too.
2384 (Fwindow_use_time): Move up in code.
2385 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2386 Rewrite doc-string.
2387 (Fset_window_configuration, saved_window)
2388 (Fcurrent_window_configuration, save_window_save): Handle new
2389 members of window structure.
2390 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2391 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2392 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2393 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2394 Qget_mru_window, Qresize_root_window,
2395 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2396 Qauto_buffer_name; staticpro them.
2397
2398 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2399
2400 * window.c (Fwindow_total_size, Fwindow_left_column)
2401 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2402 (Fwindow_list_1): New functions.
2403 (window_box_text_cols): Replace with window_body_cols.
2404 (Fwindow_width, Fscroll_left, Fscroll_right):
2405 Use window_body_cols instead of window_box_text_cols.
2406 (delete_window, Fset_window_configuration):
2407 Call delete_all_subwindows with window as argument.
2408 (delete_all_subwindows): Take a window as argument and not a
2409 structure. Rewrite.
2410 (window_loop): Remove handling of GET_LRU_WINDOW and
2411 GET_LARGEST_WINDOW.
2412 (Fget_lru_window, Fget_largest_window): Move to window.el.
2413
2414 * window.h: Extern window_body_cols instead of
2415 window_box_text_cols. delete_all_subwindows now takes a
2416 Lisp_Object as argument.
2417
2418 * indent.c (compute_motion, Fcompute_motion):
2419 Use window_body_cols instead of window_box_text_cols.
2420
2421 * frame.c (delete_frame): Call delete_all_subwindows with root
2422 window as argument.
2423
2424 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2425
2426 * fns.c (Fputhash): Document return value.
2427
2428 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2429
2430 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2431
2432 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2433
2434 Cons<->int and similar integer overflow fixes (Bug#8794).
2435
2436 Check for overflow when converting integer to cons and back.
2437 * charset.c (Fdefine_charset_internal, Fdecode_char):
2438 Use cons_to_unsigned to catch overflow.
2439 (Fencode_char): Use INTEGER_TO_CONS.
2440 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2441 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2442 * data.c (long_to_cons, cons_to_long): Remove.
2443 (cons_to_unsigned, cons_to_signed): New functions.
2444 These signal an error for invalid or out-of-range values.
2445 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2446 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2447 * font.c (Ffont_variation_glyphs):
2448 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2449 * lisp.h: Include <intprops.h>.
2450 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2451 (cons_to_signed, cons_to_unsigned): New decls.
2452 (long_to_cons, cons_to_long): Remove decls.
2453 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2454 (Fprimitive_undo): Use CONS_TO_INTEGER.
2455 * xfns.c (Fx_window_property): Likewise.
2456 * xselect.c: Include <limits.h>.
2457 (x_own_selection, selection_data_to_lisp_data):
2458 Use INTEGER_TO_CONS.
2459 (x_handle_selection_request, x_handle_selection_clear)
2460 (x_get_foreign_selection, Fx_disown_selection_internal)
2461 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2462 (lisp_data_to_selection_data): Use cons_to_unsigned.
2463 (x_fill_property_data): Use cons_to_signed.
2464 Report values out of range.
2465
2466 Check for buffer and string overflow more precisely.
2467 * buffer.h (BUF_BYTES_MAX): New macro.
2468 * lisp.h (STRING_BYTES_MAX): New macro.
2469 * alloc.c (Fmake_string):
2470 * character.c (string_escape_byte8):
2471 * coding.c (coding_alloc_by_realloc):
2472 * doprnt.c (doprnt):
2473 * editfns.c (Fformat):
2474 * eval.c (verror):
2475 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2476 since they may not be the same number.
2477 * editfns.c (Finsert_char):
2478 * fileio.c (Finsert_file_contents):
2479 Likewise for BUF_BYTES_MAX.
2480
2481 * image.c: Use ptrdiff_t, not int, for sizes.
2482 (slurp_file): Switch from int to ptrdiff_t.
2483 All uses changed.
2484 (slurp_file): Check that file size fits in both size_t (for
2485 malloc) and ptrdiff_t (for sanity and safety).
2486
2487 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2488 if b->modtime has its maximal value.
2489
2490 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2491
2492 Don't assume time_t can fit into int.
2493 * buffer.h (struct buffer.modtime): Now time_t, not int.
2494 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2495 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2496
2497 Minor fixes for signed vs unsigned integers.
2498 * character.h (MAYBE_UNIFY_CHAR):
2499 * charset.c (maybe_unify_char):
2500 * keyboard.c (read_char, reorder_modifiers):
2501 XINT -> XFASTINT, since the integer must be nonnegative.
2502 * ftfont.c (ftfont_spec_pattern):
2503 * keymap.c (access_keymap, silly_event_symbol_error):
2504 XUINT -> XFASTINT, since the integer must be nonnegative.
2505 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2506 since it makes no difference and we prefer signed.
2507 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2508 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2509 nonnegative.
2510
2511 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2512
2513 * window.h (Fwindow_frame): Declare.
2514
2515 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2516
2517 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2518 (SPARE_MEMORY): Always define.
2519 (LARGE_REQUEST): Remove.
2520 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2521
2522 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2523
2524 * lisp.h: Move EXFUNS for Fframe_root_window,
2525 Fframe_first_window and Fset_frame_selected_window to window.h.
2526
2527 * window.h: Move EXFUNS for Fframe_root_window,
2528 Fframe_first_window and Fset_frame_selected_window here from
2529 lisp.h.
2530
2531 * frame.c (Fwindow_frame, Fframe_first_window)
2532 (Fframe_root_window, Fframe_selected_window)
2533 (Fset_frame_selected_window): Move to window.c.
2534 (Factive_minibuffer_window): Move to minibuf.c.
2535 (Fother_visible_frames_p): New function.
2536
2537 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2538
2539 * window.c (decode_window, decode_any_window): Move up in code.
2540 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2541 (inhibit_frame_unsplittable): Remove unused variable.
2542 (Fwindow_buffer): Move up and rewrite doc-string.
2543 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2544 (Fwindow_prev): New functions.
2545 (Fwindow_frame): Move here from frame.c. Accept any window as
2546 argument.
2547 (Fframe_root_window, Fframe_first_window)
2548 (Fframe_selected_window): Move here from frame.c. Accept frame
2549 or arbitrary window as argument. Update doc-strings.
2550 (Fminibuffer_window): Move up in code.
2551 (Fwindow_minibuffer_p): Move up in code and simplify.
2552 (Fset_frame_selected_window): Move here from frame.c.
2553 Marginal rewrite.
2554 (Fselected_window, select_window, Fselect_window): Move up in
2555 code. Minor doc-string fixes.
2556
2557 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2560 Do not assume that spare memory exists; that assumption is valid
2561 only if SYSTEM_MALLOC.
2562 (LARGE_REQUEST): New macro, so that the issue of large requests
2563 is separated from the issue of spare memory.
2564
2565 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2566
2567 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2568 format. (Bug#8806)
2569
2570 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2571
2572 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2573 before statements.
2574
2575 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2576
2577 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2578
2579 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2580
2581 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2582 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2583
2584 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2585
2586 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2587
2588 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2589
2590 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2591 (x_clipboard_manager_save): Add return value.
2592 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2593 New error handlers.
2594 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2595 Obey Vx_select_enable_clipboard_manager. Catch errors in
2596 x_clipboard_manager_save (Bug#8779).
2597 (Vx_select_enable_clipboard_manager): New variable.
2598 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2599
2600 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2601
2602 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2603
2604 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2605
2606 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2607 in the current matrix if keep_current_p is non-zero.
2608
2609 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2610
2611 * bidi.c (bidi_level_of_next_char): Fix last change.
2612
2613 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2614
2615 Support bidi reordering of text covered by display properties.
2616
2617 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2618 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2619 (bidi_cache_search, bidi_cache_iterator_state)
2620 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2621 (bidi_level_of_next_char, bidi_move_to_visually_next):
2622 Support character positions inside a run of characters covered by a
2623 display string.
2624 (bidi_paragraph_init, bidi_resolve_explicit_1)
2625 (bidi_level_of_next_char): Call bidi_fetch_char and
2626 bidi_fetch_char_advance instead of FETCH_CHAR and
2627 FETCH_CHAR_ADVANCE.
2628 (bidi_init_it): Initialize new members.
2629 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2630 definitions.
2631 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2632 instead of using explicit *_CHAR codes.
2633 (bidi_resolve_explicit, bidi_resolve_weak):
2634 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2635 bidirectional text is supported only in multibyte buffers.
2636 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2637 it to initialize the frame_window_p member of struct bidi_it.
2638 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2639 (bidi_resolve_explicit, bidi_resolve_weak)
2640 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2641 bidi_it->nchars is non-positive.
2642 (bidi_level_of_next_char): Don't try to lookup the cache for the
2643 next/previous character if nothing is cached there yet, or if we
2644 were just reseat()'ed to a new position.
2645
2646 * xdisp.c (set_cursor_from_row): Set start and stop points
2647 according to the row's direction when priming the loop that looks
2648 for the glyph on which to display cursor.
2649 (single_display_spec_intangible_p): Function deleted.
2650 (display_prop_intangible_p): Reimplement to call
2651 handle_display_spec instead of single_display_spec_intangible_p.
2652 Accept 3 additional arguments needed by handle_display_spec.
2653 This fixes incorrect cursor motion across display property with complex
2654 values: lists, `(when COND...)' forms, etc.
2655 (single_display_spec_string_p): Support property values that are
2656 lists with the argument STRING its top-level element.
2657 (display_prop_string_p): Fix the condition for processing a
2658 property that is a list to be consistent with handle_display_spec.
2659 (handle_display_spec): New function, refactored from the
2660 last portion of handle_display_prop.
2661 (compute_display_string_pos): Accept additional argument
2662 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2663 value of a `display' property is a "replacing spec".
2664 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2665 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2666 the display property, but just return a value indicating whether
2667 the display property will replace the characters it covers.
2668 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2669 frame_window_p members of struct bidi_it.
2670 (compute_display_string_pos, compute_display_string_end):
2671 New functions.
2672 (push_it): Accept second argument POSITION, where pop_it should
2673 jump to continue iteration.
2674 (reseat_1): Initialize bidi_it.disp_pos.
2675
2676 * keyboard.c (adjust_point_for_property): Adjust the call to
2677 display_prop_intangible_p to its new signature.
2678
2679 * dispextern.h (struct bidi_it): New member frame_window_p.
2680 (bidi_init_it): Update prototypes.
2681 (display_prop_intangible_p): Update prototype.
2682 (compute_display_string_pos, compute_display_string_end):
2683 Declare prototypes.
2684 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2685 EMACS_INT.
2686
2687 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 Malloc failure behavior now depends on size of allocation.
2690 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2691 * lisp.h: Change signatures accordingly.
2692 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2693 All callers changed. (Bug#8762)
2694
2695 * gnutls.c: Use Emacs's memory allocators.
2696 Without this change, the gnutls library would invoke malloc etc.
2697 directly, which causes problems on non-SYNC_INPUT hosts, and which
2698 runs afoul of improving memory_full behavior. (Bug#8761)
2699 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2700 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2701 xfree instead of the default malloc, realloc, free.
2702 (Fgnutls_boot): No need to check for memory allocation failure,
2703 since xmalloc does that for us.
2704
2705 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2706 * category.c (hash_get_category_set):
2707 * ccl.c (ccl_driver):
2708 * charset.c (Fdefine_charset_internal):
2709 * charset.h (struct charset.hash_index):
2710 * composite.c (get_composition_id, gstring_lookup_cache)
2711 (composition_gstring_put_cache):
2712 * composite.h (struct composition.hash_index):
2713 * dispextern.h (struct image.hash):
2714 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2715 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2716 (hashfn_equal, hashfn_user_defined, make_hash_table)
2717 (maybe_resize_hash_table, hash_lookup, hash_put)
2718 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2719 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2720 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2721 * image.c (make_image, search_image_cache, lookup_image)
2722 (xpm_put_color_table_h):
2723 * lisp.h (struct Lisp_Hash_Table):
2724 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2725 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2726 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2727 * alloc.c (allocate_vectorlike):
2728 Check for overflow in vector size calculations.
2729 * ccl.c (ccl_driver):
2730 Check for overflow when converting EMACS_INT to int.
2731 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2732 need to be updated by these changes.
2733 * fns.c (make_hash_table, maybe_resize_hash_table):
2734 Check for integer overflow with large hash tables.
2735 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2736 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2737 (SXHASH_REDUCE): New macro.
2738 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2739 Use it instead of discarding useful hash info with large hash values.
2740 (sxhash_float): New function.
2741 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2742 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2743 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2744 Rewrite to use FIXNUM_BITS, as this simplifies things.
2745 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2746 Adjust signatures to match updated version of code.
2747 (consing_since_gc): Now EMACS_INT, since a single hash table can
2748 use more than INT_MAX bytes.
2749
2750 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2751
2752 Make it possible to build with GCC-4.6+ -O2 -flto.
2753
2754 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2755
2756 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2757
2758 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2759 Call minibuffer-inactive-mode.
2760
2761 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2762
2763 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2764 Update dependencies.
2765
2766 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2767
2768 * data.c (init_data): Remove code for UTS, this system is not
2769 supported anymore.
2770
2771 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2772
2773 Don't force ./temacs to start in terminal mode.
2774
2775 * frame.c (make_initial_frame): Initialize faces in all cases, not
2776 only when CANNOT_DUMP is defined.
2777 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2778
2779 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2780
2781 * dispnew.c (add_window_display_history): Use const for the string
2782 pointer. Remove declaration, not needed.
2783
2784 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2785
2786 Use 'inline', not 'INLINE'.
2787 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2788 * alloc.c, fontset.c (INLINE): Remove.
2789 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2790 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2791 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2792 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2793 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2794
2795 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2796
2797 Make it possible to run ./temacs.
2798
2799 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2800 syms_of_callproc does the same thing. Remove test for
2801 "initialized", do it in the caller.
2802 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2803
2804 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2805
2806 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2807 (read_minibuf): Use get_minibuffer.
2808 (syms_of_minibuf): Use DEFSYM.
2809 (Qmetadata): New var.
2810 * data.c (Qbuffer): Don't make it static.
2811 (syms_of_data): Use DEFSYM.
2812
2813 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2814
2815 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2816 (CCL_CODE_MIN): New macro.
2817
2818 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2819
2820 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2821
2822 * eval.c (Qdebug): Now static.
2823 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2824 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2825 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2826
2827 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2828
2829 * image.c: Various fixes to ImageMagick code comments.
2830 (Fimagemagick_types): Doc fix.
2831
2832 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 Minor fixes prompted by GCC 4.6.0 warnings.
2835
2836 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2837
2838 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2839 (x_clipboard_manager_save_all): Move extern decl to ...
2840 * xterm.h: ... here, so that it can be checked for consistency.
2841
2842 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2843
2844 * xselect.c (x_clipboard_manager_save_frame)
2845 (x_clipboard_manager_save_all): New functions.
2846 (Fx_clipboard_manager_save): Lisp function deleted.
2847
2848 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2849 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2850
2851 * xterm.h: Update prototype.
2852
2853 2011-05-28 William Xu <william.xwl@gmail.com>
2854
2855 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2856 exiting (Bug#8239).
2857
2858 2011-05-28 Jim Meyering <meyering@redhat.com>
2859
2860 Avoid a sign-extension bug in crypto_hash_function.
2861 * fns.c (to_uchar): Define.
2862 (crypto_hash_function): Use it to convert some newly-signed
2863 variables to unsigned, to avoid sign-extension bugs. For example,
2864 without this change, (md5 "truc") would evaluate to
2865 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2866 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2867 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2868
2869 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2870
2871 Integer overflow fixes.
2872
2873 * dbusbind.c: Serial number integer overflow fixes.
2874 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2875 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2876 to hold a serial number that is too large for a fixnum.
2877 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2878 Check for serial numbers out of range. Decode any serial number
2879 that was so large that it became a float. (Bug#8722)
2880
2881 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2882 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2883 Use XFASTINT rather than XUINT when numbers are nonnegative.
2884 (xd_append_arg, Fdbus_method_return_internal):
2885 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2886 arguments, check that Lisp number is nonnegative, rather than
2887 silently wrapping negative numbers around. (Bug#8722)
2888 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2889 (Bug#8722)
2890
2891 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2892
2893 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2894
2895 ccl: add integer overflow checks
2896 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2897 (IN_INT_RANGE): New macros.
2898 (ccl_driver): Use them to check for integer overflow when
2899 decoding a CCL program. Many of the new checks are whether XINT (x)
2900 fits in int; it doesn't always, on 64-bit hosts. The new version
2901 doesn't catch all possible integer overflows, but it's an
2902 improvement. (Bug#8719)
2903
2904 * alloc.c (make_event_array): Use XINT, not XUINT.
2905 There's no need for unsigned here.
2906
2907 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2908 This follows up to the 2011-05-06 change that substituted uintptr_t
2909 for EMACS_INT. This case wasn't caught back then.
2910
2911 Rework Fformat to avoid integer overflow issues.
2912 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2913 now (part of C89). Include <verify.h>.
2914 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2915 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2916 (Fformat): Avoid the prepass trying to compute sizes; it was only
2917 approximate and thus did not catch overflow reliably. Instead, walk
2918 through the format just once, formatting and computing sizes as we go,
2919 checking for integer overflow at every step, and allocating a larger
2920 buffer as needed. Keep track separately whether the format is
2921 multibyte. Keep only the most-recently calculated precision, rather
2922 than them all. Record whether each argument has been converted to
2923 string. Use EMACS_INT, not int, for byte and char and arg counts.
2924 Support field widths and precisions larger than INT_MAX. Avoid
2925 sprintf's undefined behavior with conversion specifications such as %#d
2926 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2927 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2928 formatting out-of-range floating point numbers with int
2929 formats. (Bug#8668)
2930
2931 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2932
2933 * data.c: Avoid integer truncation in expressions involving floats.
2934 * data.c: Include <intprops.h>.
2935 (arith_driver): When there's an integer overflow in an expression
2936 involving floating point, convert the integers to floating point
2937 so that the resulting value does not suffer from catastrophic
2938 integer truncation. For example, on a 64-bit host (* 4
2939 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2940 Do not rely on undefined behavior after integer overflow.
2941
2942 merge count_size_as_multibyte, parse_str_to_multibyte
2943 * character.c, character.h (count_size_as_multibyte):
2944 Rename from parse_str_to_multibyte; all uses changed.
2945 Check for integer overflow.
2946 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2947 since it's now a duplicate of the other. This is more of
2948 a character than a buffer op, so better that it's in character.c.
2949 * fns.c, print.c: Adjust to above changes.
2950
2951 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2952
2953 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2954
2955 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2956
2957 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2958 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2959 (x_clipboard_manager_save): Now static.
2960 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2961
2962 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2963 (crypto_hash_function): Now static.
2964 Fix pointer signedness problems. Avoid unnecessary initializations.
2965
2966 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2967
2968 * termhooks.h (Vselection_alist): Make it terminal-local.
2969
2970 * terminal.c (create_terminal): Initialize it.
2971
2972 * xselect.c: Support for clipboard managers.
2973 (Vselection_alist): Move to termhooks.h as terminal-local var.
2974 (LOCAL_SELECTION): New macro.
2975 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2976 (symbol_to_x_atom): Remove gratuitous arg.
2977 (x_handle_selection_request, lisp_data_to_selection_data)
2978 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2979 (x_own_selection, x_get_local_selection, x_convert_selection):
2980 New arg, specifying work frame. Use terminal-local Vselection_alist.
2981 (some_frame_on_display): Delete unused function.
2982 (Fx_own_selection_internal, Fx_get_selection_internal)
2983 (Fx_disown_selection_internal, Fx_selection_owner_p)
2984 (Fx_selection_exists_p): New optional frame arg.
2985 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2986 (x_handle_selection_clear): Don't treat other terminals with the
2987 same keyboard specially. Use the terminal-local Vselection_alist.
2988 (x_clear_frame_selections): Use Frun_hook_with_args.
2989
2990 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2991
2992 * xterm.h: Add support for those atoms.
2993
2994 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2995
2996 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2997 (converted_selections, conversion_fail_tag): New global variables.
2998 (x_selection_request_lisp_error): Free the above.
2999 (x_get_local_selection): Remove unnecessary code.
3000 (x_reply_selection_request): Args changed; handle arbitrary array
3001 of converted selections stored in converted_selections.
3002 Separate the XChangeProperty and SelectionNotify steps.
3003 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3004 (x_convert_selection): New function.
3005 (x_handle_selection_event): Simplify.
3006 (x_get_foreign_selection): Don't ignore incoming requests while
3007 waiting for an answer; this will fail when we implement
3008 SAVE_TARGETS, and seems unnecessary anyway.
3009 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3010 (Vx_sent_selection_functions): Doc fix.
3011
3012 2011-05-26 Leo Liu <sdl.web@gmail.com>
3013
3014 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3015
3016 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3017
3018 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3019
3020 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3021 for fringe update if it has periodic bitmap.
3022 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3023 and fringe_bitmap_periodic_p.
3024
3025 * fringe.c (get_fringe_bitmap_data): New function.
3026 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3027 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3028 row. Mark glyph row for fringe update if periodicity changed.
3029
3030 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3031 for fringe update unless it has periodic bitmap.
3032
3033 2011-05-25 Kenichi Handa <handa@m17n.org>
3034
3035 * xdisp.c (get_next_display_element): Set correct it->face_id for
3036 a static composition.
3037
3038 2011-05-24 Leo Liu <sdl.web@gmail.com>
3039
3040 * deps.mk (fns.o):
3041 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3042
3043 * fns.c (crypto_hash_function, Fsha1): New function.
3044 (Fmd5): Use crypto_hash_function.
3045 (syms_of_fns): Add Ssha1.
3046
3047 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3048
3049 * gnutls.c: Remove unused macros.
3050 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3051 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3052 Remove macros that are defined and never used.
3053 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3054
3055 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3056
3057 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3058 (Fx_get_selection_internal): Minor cleanup.
3059 (Fx_own_selection_internal): Rename arguments for consistency with
3060 select.el.
3061
3062 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3065
3066 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3067
3068 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3069
3070 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3071
3072 * dispnew.c (scrolling_window): Don't exclude the case that the
3073 last enabled row in the desired matrix touches the bottom boundary.
3074
3075 2011-05-21 Glenn Morris <rgm@gnu.org>
3076
3077 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3078 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3079 and add some more files.
3080
3081 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3082
3083 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3084 report_file_error introduced by the change from 2011-05-07.
3085
3086 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 * systime.h (Time): Define only if emacs is defined.
3089 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3090 where the include path doesn't have X11/X.h by default. See
3091 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3092
3093 2011-05-20 Kenichi Handa <handa@m17n.org>
3094
3095 * composite.c (find_automatic_composition): Fix previous change.
3096
3097 2011-05-20 Glenn Morris <rgm@gnu.org>
3098
3099 * lisp.mk: New file, split from Makefile.in.
3100 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3101 (shortlisp): Remove.
3102 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3103
3104 2011-05-19 Glenn Morris <rgm@gnu.org>
3105
3106 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3107 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3108 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3109 (lisp): Set the order to that of loadup.el.
3110 (shortlisp): Make it a copy of $lisp.
3111 (SOME_MACHINE_LISP): Remove.
3112 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3113 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3114
3115 2011-05-18 Kenichi Handa <handa@m17n.org>
3116
3117 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3118 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3119 (find_automatic_composition): Mostly rewrite for efficiency.
3120
3121 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3122
3123 * makefile.w32-in: Update dependencies.
3124
3125 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3126
3127 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3128 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3129
3130 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3131
3132 Fix some integer overflow issues, such as string length overflow.
3133
3134 * insdel.c (count_size_as_multibyte): Check for string overflow.
3135
3136 * character.c (lisp_string_width): Check for string overflow.
3137 Use EMACS_INT, not int, for string indexes and lengths; in
3138 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3139 the resulting string length overflows an EMACS_INT; instead,
3140 report a string overflow if no precision given. When checking for
3141 precision exhaustion, use a check that cannot possibly have
3142 integer overflow. (Bug#8675)
3143 * character.h (lisp_string_width): Adjust to new signature.
3144
3145 * alloc.c (string_overflow): New function.
3146 (Fmake_string): Use it. This doesn't change behavior, but saves
3147 a few bytes and will simplify future changes.
3148 * character.c (string_escape_byte8): Likewise.
3149 * lisp.h (string_overflow): New decl.
3150
3151 Fixups, following up to the user-interface timestamp change.
3152 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3153 for UI timestamps, instead of unsigned long.
3154 * msdos.c (mouse_get_pos): Likewise.
3155 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3156 * w32gui.h (Time): Define by including "systime.h" rather than by
3157 declaring it ourselves. (Bug#8664)
3158
3159 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3160 * image.c (clear_image_cache): Likewise.
3161
3162 * term.c (term_mouse_position): Don't assume time_t wraparound.
3163
3164 Be more systematic about user-interface timestamps.
3165 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3166 and sometimes 'EMACS_UINT', to represent these timestamps.
3167 This change causes it to use 'Time' uniformly, as that's what X uses.
3168 This makes the code easier to follow, and makes it easier to catch
3169 integer overflow bugs such as Bug#8664.
3170 * frame.c (Fmouse_position, Fmouse_pixel_position):
3171 Use Time, not unsigned long, for user-interface timestamps.
3172 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3173 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3174 * keyboard.h (last_event_timestamp): Likewise.
3175 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3176 * menu.h (xmenu_show): Likewise.
3177 * term.c (term_mouse_position): Likewise.
3178 * termhooks.h (struct input_event.timestamp): Likewise.
3179 (struct terminal.mouse_position_hook): Likewise.
3180 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3181 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3182 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3183 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3184 what it was before.
3185 * menu.h, termhooks.h: Include "systime.h", for Time.
3186
3187 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3188 Don't assume that the difference between two unsigned long values
3189 can fit into an integer. At this point, we know button_down_time
3190 <= event->timestamp, so the difference must be nonnegative, so
3191 there's no need to cast the result if double-click-time is
3192 nonnegative, as it should be; check that it's nonnegative, just in
3193 case. This bug is triggered when events are more than 2**31 ms
3194 apart (about 25 days). (Bug#8664)
3195
3196 * xselect.c (last_event_timestamp): Remove duplicate decl.
3197 (x_own_selection): Remove needless cast to unsigned long.
3198
3199 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3200 that always fit in int. Use a sentinel instead of a counter, to
3201 avoid a temp and to allay GCC's concerns about possible int overflow.
3202 * frame.h (struct frame): Use int for menu_bar_items_used
3203 instead of EMACS_INT, since it always fits in int.
3204
3205 * menu.c (grow_menu_items): Check for int overflow.
3206
3207 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3208
3209 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3210 Before, the code was not consistent. These values cannot exceed
3211 2**31 - 1 so there's no need to make them unsigned.
3212 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3213 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3214 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3215 as modifiers.
3216 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3217
3218 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3219 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3220 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3221 presumably because the widths might not match.
3222
3223 * window.c (size_window): Avoid needless test at loop start.
3224
3225 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3226
3227 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3228
3229 2011-05-12 Drew Adams <drew.adams@oracle.com>
3230
3231 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3232
3233 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3234
3235 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3236 `width' to `bar_area_x' and `bar_area_width', respectively.
3237 (x_scroll_run): Take account of fringe background extension.
3238
3239 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3240 Rename local vars `left' and `width' to `bar_area_x' and
3241 `bar_area_width', respectively.
3242 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3243 background extension.
3244
3245 2011-05-10 Jim Meyering <meyering@redhat.com>
3246
3247 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3248
3249 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * image.c (Finit_image_library): Return t for built-in image types,
3252 like pbm and xbm. (Bug#8640)
3253
3254 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3255
3256 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3257
3258 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3259
3260 * w32console.c (Fset_screen_color): Doc fix.
3261 (Fget_screen_color): New function.
3262 (syms_of_ntterm): Defsubr it.
3263
3264 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3265 unlink the temporary file if Fcall_process didn't create it in the
3266 first place.
3267 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3268 child process will be redirected to a file specified with `:file'.
3269 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3270 cue to call_process_cleanup not to close that handle.
3271
3272 2011-05-07 Ben Key <bkey76@gmail.com>
3273
3274 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3275 one of two shell specific rules, either bootstrap-temacs-CMD or
3276 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3277 to the previous implementation of the bootstrap-temacs rule.
3278 The bootstrap-temacs-CMD rule is similar to the previous
3279 implementation of the bootstrap-temacs rule except that it
3280 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3281 variable.
3282
3283 These changes, along with some changes to nt/configure.bat,
3284 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3285 earlier fix to add support for --cflags and --ldflags options
3286 that include quotes so that it works whether make uses cmd or
3287 sh as the shell.
3288
3289 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3290
3291 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3292 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3293 is a constant.
3294 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3295 a string. Handle both cases.
3296 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3297 (Fdbus_register_method): Use Qinvalid_function.
3298
3299 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3300
3301 * makefile.w32-in: Update dependencies.
3302 (LISP_H): Add inttypes.h and stdin.h.
3303 (PROCESS_H): Add unistd.h.
3304
3305 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3306
3307 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3308 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3309
3310 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3313
3314 * term.c (vfatal): Remove stray call to va_end.
3315 It's not needed and the C Standard doesn't allow it here anyway.
3316
3317 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3318 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3319
3320 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3321 bytes.
3322
3323 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3324
3325 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3326
3327 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3328
3329 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3330
3331 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3332
3333 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3334 * charset.c (Fdefine_charset_internal): Don't initialize
3335 charset.code_space[15]. The value was garbage, on hosts with
3336 32-bit int (Bug#8600).
3337
3338 * lread.c (read_integer): Be more consistent with string-to-number.
3339 Use string_to_number to do the actual conversion; this avoids
3340 rounding errors and fixes some other screwups. Without this fix,
3341 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3342 (digit_to_number): Move earlier, for benefit of read_integer.
3343 Return -1 if the digit is out of range for the base, -2 if it is
3344 not a digit in any supported base. (Bug#8602)
3345
3346 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3347
3348 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3349 to match comment at start of function. This also removes a
3350 GCC warning about overflow in a 32+64-bit port.
3351
3352 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3353
3354 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3355 Reported by Stefan Monnier in
3356 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3357 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3358 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3359
3360 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3361 (EMACS_UINTPTR): Likewise, with uintptr_t.
3362
3363 * lisp.h: Prefer 64-bit EMACS_INT if available.
3364 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3365 on 32-bit hosts that have 64-bit int, so that they can access
3366 large files.
3367 However, temporarily disable this change unless the temporary
3368 symbol WIDE_EMACS_INT is defined.
3369
3370 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3371
3372 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3373 This removes an assumption that EMACS_INT and long are the same
3374 width as pointers. The assumption is true for Emacs porting targets
3375 now, but we want to make other targets possible.
3376 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3377 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3378 In the rest of the code, change types of integers that hold casted
3379 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3380 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3381 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3382 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3383 No need to cast type when ORing.
3384 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3385 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3386 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3387 assume EMACS_INT is the same width as char *.
3388 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3389 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3390 Remove no-longer-needed casts.
3391 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3392 (xg_tool_bar_help_callback, xg_make_tool_item):
3393 Use EMACS_INTPTR to hold an integer
3394 that will be cast to void *; this can avoid a GCC warning
3395 if EMACS_INT is not the same width as void *.
3396 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3397 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3398 (current_message_1, set_message_1):
3399 Use a local to convert to proper width without a cast.
3400 * xmenu.c (dialog_selection_callback): Likewise.
3401
3402 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3403 Also, don't assume VALBITS / RAND_BITS is less than 5,
3404 and don't rely on undefined behavior when shifting a 1 left into
3405 the sign bit.
3406 * lisp.h (get_random): Change signature to match.
3407
3408 * lread.c (hash_string): Use size_t, not int, for hash computation.
3409 Normally we prefer signed values; but hashing is special, because
3410 it's better to use unsigned division on hash table sizes so that
3411 the remainder is nonnegative. Also, size_t is the natural width
3412 for hashing into memory. The previous code used 'int', which doesn't
3413 retain enough info to hash well into very large tables.
3414 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3415
3416 * dbusbind.c: Don't possibly lose pointer info when converting.
3417 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3418 Use XPNTR rather than XHASH, so that the high-order bits of
3419 the pointer aren't lost when converting through void *.
3420
3421 * eval.c (Fautoload): Don't double-shift a pointer.
3422
3423 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3424
3425 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3426
3427 * gnutls.c (DEF_GNUTLS_FN):
3428 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3429
3430 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3431
3432 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3433 marker. (Bug#8610)
3434
3435 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3436
3437 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3438 New version that can reserve upto 2GB of heap space.
3439
3440 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3441
3442 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3443
3444 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3445
3446 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3447 `gnutls_certificate_set_x509_key_file'.
3448
3449 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3450
3451 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3452 Update dependencies.
3453
3454 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3455
3456 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3457 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3458 Remove unused parameter `fildes'.
3459 * process.c (read_process_output, send_process): Don't pass it.
3460
3461 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3462
3463 Fix previous change: the library cache is defined in w32.c.
3464 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3465 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3466
3467 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3468
3469 Implement dynamic loading of GnuTLS on Windows.
3470
3471 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3472 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3473 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3474 Declare.
3475
3476 * gnutls.c (Qgnutls_dll): Define.
3477 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3478 (gnutls_*): Declare function pointers.
3479 (init_gnutls_functions): New function to initialize function pointers.
3480 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3481 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3482 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3483 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3484 (emacs_gnutls_write, emacs_gnutls_read)
3485 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3486 (Fgnutls_available_p): New function.
3487 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3488 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3489 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3490
3491 * image.c: Include w32.h.
3492 (Vimage_type_cache): Delete.
3493 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3494 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3495 (w32_delayed_load): Move to w32.c.
3496
3497 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3498
3499 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3500 (w32_delayed_load): Move from image.c. When loading a library, record
3501 its filename in the :loaded-from property of the library id.
3502 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3503 Initialize and staticpro them.
3504 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3505
3506 * process.c: Include lisp.h before w32.h, not after.
3507 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3508 instead of gnutls_record_check_pending.
3509
3510 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3511
3512 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3513
3514 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3515 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3516 as passed in.
3517
3518 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3519
3520 * xterm.c (x_set_frame_alpha): Do not set property on anything
3521 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3522
3523 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3524
3525 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3526
3527 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3530 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3531 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3532 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3533 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3534 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3535 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3536 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3537 (Qgnutls_bootprop_callbacks_verify): Make static.
3538
3539 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3540
3541 * callproc.c: Indentation fixup.
3542
3543 * sysdep.c (wait_for_termination_1): Make static.
3544 (wait_for_termination, interruptible_wait_for_termination):
3545 Move after wait_for_termination_1.
3546
3547 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3548
3549 * sysdep.c (interruptible_wait_for_termination): New function
3550 which is like wait_for_termination, but allows keyboard
3551 interruptions.
3552
3553 * callproc.c (Fcall_process): Add (:file "file") as an option for
3554 the STDOUT buffer.
3555 (Fcall_process_region): Ditto.
3556
3557 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3558
3559 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3560 rather than `XVECTOR (FOO)->size'.
3561
3562 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3563 inttypes.h, as a gnulib replacement is used if it not available in
3564 system headers.
3565
3566 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3567
3568 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3569 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3570 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3571
3572 * coding.c (coding_alloc_by_realloc): Error out if destination
3573 will grow beyond MOST_POSITIVE_FIXNUM.
3574 (decode_coding_emacs_mule): Abort if there isn't enough place in
3575 charbuf for the composition carryover bytes. Reserve an extra
3576 space for up to 2 characters produced in a loop.
3577 (decode_coding_iso_2022): Abort if there isn't enough place in
3578 charbuf for the composition carryover bytes.
3579
3580 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3581
3582 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3583 aborting when %lld or %lll format is passed.
3584 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3585 %llo or %llx format is passed. (Bug#8545)
3586
3587 * window.c (window_scroll_line_based): Use a marker instead of
3588 simple variables to record original value of point. (Bug#7952)
3589
3590 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3591 produced by %s or %c overflows available buffer space. (Bug#8545)
3592
3593 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3594
3595 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3596 (SIZE_MAX): Move defn after all includes, as they might #define it.
3597
3598 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3599
3600 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3601
3602 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * keyboard.c (Qdelayed_warnings_hook): Define.
3605 (command_loop_1): Run `delayed-warnings-hook'
3606 if Vdelayed_warnings_list is non-nil.
3607 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3608 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3609
3610 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3611
3612 * doprnt.c (doprnt): Don't return value smaller than the buffer
3613 size if the message was truncated. (Bug#8545).
3614
3615 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3616
3617 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3618 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3619
3620 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3623
3624 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3625
3626 * makefile.w32-in: Update dependencies.
3627
3628 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3629
3630 Improve `doprnt' and its usage. (Bug#8545)
3631 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3632 `format_end'. Remove support for %l as a conversion specifier.
3633 Don't use xrealloc. Improve diagnostics when the %l size modifier
3634 is used. Update the commentary.
3635
3636 * eval.c (verror): Simplify calculation of size_t.
3637
3638 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3639 messages.
3640
3641 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3642
3643 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3644 change.
3645
3646 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3647
3648 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3649 This makes this file independent of the recent pseudovector change.
3650
3651 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3654
3655 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3656 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3657 Remove unused local.
3658 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3659
3660 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3661 GCC 4.6.0 optimizes based on type-based alias analysis.
3662 For example, if b is of type struct buffer * and v of type struct
3663 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3664 != &v->size, and therefore "v->size = 1; b->size = 2; return
3665 v->size;" must therefore return 1. This assumption is incorrect
3666 for Emacs, since it type-puns struct Lisp_Vector * with many other
3667 types. To fix this problem, this patch adds a new type struct
3668 vectorlike_header that documents the constraints on layout of vectors
3669 and pseudovectors, and helps optimizing compilers not get fooled
3670 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3671 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3672 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3673 the size member.
3674 (XSETPVECTYPE): Rewrite in terms of new macro.
3675 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3676 This is a bit clearer, and further avoids the possibility of
3677 undesirable aliasing.
3678 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3679 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3680 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3681 since Lisp_Subr is a special case (no "next" field).
3682 (ASIZE): Now uses header.size rather than size.
3683 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3684 to avoid the hassle of writing XVECTOR (foo)->header.size.
3685 (struct vectorlike_header): New type.
3686 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3687 object, to help avoid aliasing.
3688 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3689 (SUBRP): Likewise, since Lisp_Subr is a special case.
3690 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3691 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3692 (struct Lisp_Hash_Table): Combine first two members into a single
3693 struct vectorlike_header member. All uses of "size" and "next" members
3694 changed to be "header.size" and "header.next".
3695 * buffer.h (struct buffer): Likewise.
3696 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3697 * frame.h (struct frame): Likewise.
3698 * process.h (struct Lisp_Process): Likewise.
3699 * termhooks.h (struct terminal): Likewise.
3700 * window.c (struct save_window_data, struct saved_window): Likewise.
3701 * window.h (struct window): Likewise.
3702 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3703 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3704 * buffer.c (init_buffer_once): Likewise.
3705 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3706 special case.
3707 * process.c (Fformat_network_address): Use local var for size,
3708 for brevity.
3709
3710 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3711
3712 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3713 * data.c (atof): Remove decl; no longer used or needed.
3714 (digit_to_number): Move to lread.c.
3715 (Fstring_to_number): Use new string_to_number function, to be
3716 consistent with how the Lisp reader treats infinities and NaNs.
3717 Do not assume that floating-point numbers represent EMACS_INT
3718 without losing information; this is not true on most 64-bit hosts.
3719 Avoid double-rounding errors, by insisting on integers when
3720 parsing non-base-10 numbers, as the documentation specifies.
3721 * lisp.h (string_to_number): New decl, replacing ...
3722 (isfloat_string): Remove.
3723 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3724 (read1): Do not accept +. and -. as integers; this
3725 appears to have been a coding error. Similarly, do not accept
3726 strings like +-1e0 as floating point numbers. Do not report
3727 overflow for integer overflows unless the base is not 10 which
3728 means we have no simple and reliable way to continue.
3729 Break out the floating-point parsing into a new
3730 function string_to_number, so that Fstring_to_number parses
3731 floating point numbers consistently with the Lisp reader.
3732 (digit_to_number): Move here from data.c. Make it static inline.
3733 (E_CHAR, EXP_INT): Remove, replacing with ...
3734 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3735 (string_to_number): New function, replacing isfloat_string.
3736 This function checks for valid syntax and produces the resulting
3737 Lisp float number too. Rework it so that string-to-number
3738 no longer mishandles examples like "1.0e+". Use strtoumax,
3739 so that overflow for non-base-10 numbers is reported only when
3740 there's no portable and simple way to convert to floating point.
3741
3742 * textprop.c (set_text_properties_1): Rewrite for clarity,
3743 and to avoid GCC warning about integer overflow.
3744
3745 * intervals.h (struct interval): Use EMACS_INT for members
3746 where EMACS_UINT might cause problems. See
3747 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3748 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3749 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3750 All uses changed.
3751 (offset_intervals): Tell GCC not to worry about length overflow
3752 when negating a negative length.
3753
3754 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3755 (overrun_check_free): Likewise.
3756
3757 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3758 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3759 word size.
3760
3761 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3762 (gnutls_make_error): Rename local to avoid shadowing.
3763 (gnutls_emacs_global_deinit): ifdef out; not used.
3764 (Fgnutls_boot): Use const for pointer to readonly storage.
3765 Comment out unused local. Fix pointer signedness problems.
3766
3767 * lread.c (openp): Don't stuff size_t into an 'int'.
3768 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3769 about possible signed overflow.
3770
3771 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3772 (GDK_KEY_g): Don't define if already defined.
3773 (xg_prepare_tooltip): Avoid pointer signedness problem.
3774 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3775
3776 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3777 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3778
3779 * xfns.c (Fx_window_property): Simplify a bit,
3780 to make a bit faster and to avoid GCC 4.6.0 warning.
3781 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3782
3783 * fns.c (internal_equal): Don't assume size_t fits in int.
3784
3785 * alloc.c (compact_small_strings): Tighten assertion a little.
3786
3787 Replace pEd with more-general pI, and fix some printf arg casts.
3788 * lisp.h (pI): New macro, generalizing old pEd macro to other
3789 conversion specifiers. For example, use "...%"pI"d..." rather
3790 than "...%"pEd"...".
3791 (pEd): Remove. All uses replaced with similar uses of pI.
3792 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3793 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3794 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3795 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3796 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3797 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3798 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3799 64-bit hosts.
3800 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3801 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3802 * print.c (safe_debug_print, print_object): Likewise.
3803 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3804 to int.
3805 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3806 avoiding the 0 flag, which is not portable.
3807 * process.c (Fmake_network_process): Use pI to avoid cast.
3808 * region-cache.c (pp_cache): Likewise.
3809 * xdisp.c (decode_mode_spec): Likewise.
3810 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3811 behavior on 64-bit hosts with printf arg.
3812 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3813 (x_stop_queuing_selection_requests): Likewise.
3814 (x_get_window_property): Don't truncate byte count to an 'int'
3815 when tracing.
3816
3817 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3818 here, since it parses constructs like leading '-' and spaces,
3819 which are not wanted; and it overflows with large numbers.
3820 Instead, simply match F[0-9]+, which is what is wanted anyway.
3821
3822 * alloc.c: Remove unportable assumptions about struct layout.
3823 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3824 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3825 (allocate_vectorlike, make_pure_vector): Use the new macros,
3826 plus offsetof, to remove unportable assumptions about struct layout.
3827 These assumptions hold on all porting targets that I know of, but
3828 they are not guaranteed, they're easy to remove, and removing them
3829 makes further changes easier.
3830
3831 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3832 This doesn't fix a bug but makes the code clearer.
3833 (string_overrun_cookie): Now const. Use initializers that
3834 don't formally overflow signed char, to avoid warnings.
3835 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3836 can cause Emacs to crash when string overrun checking is enabled.
3837 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3838 multiple of sizeof (EMACS_INT); it need not be, if
3839 alignof(EMACS_INT) < sizeof (EMACS_INT).
3840 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3841
3842 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3843
3844 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3845
3846 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3847
3848 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3849 supposed to be handshaking. (Bug#8556)
3850 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3851
3852 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3853
3854 * lisp.h (Qdebug): List symbol.
3855 * eval.c (Qdebug): Restore global linkage.
3856 * keyboard.c (debug-on-event): New variable.
3857 (handle_user_signal): Break into debugger when debug-on-event
3858 matches the current signal symbol.
3859
3860 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3861
3862 * alloc.c (check_sblock, check_string_bytes)
3863 (check_string_free_list): Convert to standard C.
3864
3865 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3866
3867 * w32.c (emacs_gnutls_push): Fix typo.
3868
3869 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3870
3871 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3872 "cast to pointer from integer of different size".
3873
3874 Improve doprnt and its use in verror. (Bug#8545)
3875 * doprnt.c (doprnt): Document the set of format control sequences
3876 supported by the function. Use SAFE_ALLOCA instead of always
3877 using `alloca'.
3878
3879 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3880 is one byte too soon. Don't use xrealloc; instead xfree and
3881 xmalloc anew.
3882
3883 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3884
3885 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3886 callbacks stage.
3887
3888 * gnutls.c: Renamed global_initialized to
3889 gnutls_global_initialized. Added internals for the
3890 :verify-hostname-error, :verify-error, and :verify-flags
3891 parameters of `gnutls-boot' and documented those parameters in the
3892 docstring. Start callback support.
3893 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3894 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3895 on error. Return error code.
3896 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3897 (emacs_gnutls_read): Likewise.
3898 (Fgnutls_boot): Return handshake error code.
3899 (emacs_gnutls_handle_error): New function.
3900 (wsaerror_to_errno): Likewise.
3901
3902 * w32.h (emacs_gnutls_pull): Add prototype.
3903 (emacs_gnutls_push): Likewise.
3904
3905 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3906 (emacs_gnutls_push): Likewise.
3907
3908 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3909
3910 * process.c (wait_reading_process_output): Check if GnuTLS
3911 buffered some data internally if no FDs are set for TLS
3912 connections.
3913
3914 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3915 (LIBS): Link to USER_LIBS.
3916 ($(BLD)/gnutls.$(0)): New target.
3917
3918 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3919
3920 * xdisp.c (handle_single_display_spec): Rename the
3921 display_replaced_before_p argument into display_replaced_p, to
3922 make it consistent with the commentary. Fix typos in the
3923 commentary.
3924
3925 * textprop.c (syms_of_textprop): Remove dead code.
3926 (copy_text_properties): Delete obsolete commentary about an
3927 interface that was deleted long ago. Fix typos in the description
3928 of arguments.
3929
3930 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3931 to changes in oldXMenu/XMenu.h from 2011-04-16.
3932 <menu_help_message, prev_menu_help_message>: Constify.
3933 (IT_menu_make_room): menu->help_text is now `const char **';
3934 adjust.
3935
3936 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3937 to changes in oldXMenu/XMenu.h from 2011-04-16.
3938 (struct XMenu): Declare `help_text' `const char **'.
3939
3940 * xfaces.c <Qunspecified>: Make extern again.
3941
3942 * syntax.c: Include sys/types.h before including regex.h, as
3943 required by Posix.
3944
3945 * doc.c (get_doc_string): Improve the format passed to `error'.
3946
3947 * doprnt.c (doprnt): Improve commentary.
3948
3949 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3950
3951 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3952 them with etags.
3953
3954 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3955 changes in globals.h immediately force recompilation.
3956 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3957 $(CURDIR)/s/ms-w32.h.
3958 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3959
3960 * character.c (Fchar_direction): Function deleted.
3961 (syms_of_character): Don't defsubr it.
3962 <char-direction-table>: Deleted.
3963
3964 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3965
3966 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3967 * doprnt.c: Include limits.h.
3968 (SIZE_MAX): New macro.
3969 (doprnt): Return a size_t value. 2nd arg is now size_t.
3970 Many local variables are now size_t instead of int or unsigned.
3971 Improve overflow protection. Support `l' modifier for integer
3972 conversions. Support %l conversion. Don't assume an EMACS_INT
3973 argument for integer conversions and for %c.
3974
3975 * lisp.h (doprnt): Restore prototype.
3976
3977 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3978 $(SRC)/character.h.
3979
3980 * Makefile.in (base_obj): Add back doprnt.o.
3981
3982 * deps.mk (doprnt.o): Add back prerequisites.
3983 (callint.o): Depend on character.h.
3984
3985 * eval.c (internal_lisp_condition_case): Include the handler
3986 representation in the error message.
3987 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3988 when breaking from the loop.
3989
3990 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3991
3992 * callint.c (Fcall_interactively): When displaying error message
3993 about invalid control letter, pass the character's codepoint, not
3994 a pointer to its multibyte form. Improve display of the character
3995 in octal and display also its hex code.
3996
3997 * character.c (char_string): Use %x to display the (unsigned)
3998 codepoint of an invalid character, to avoid displaying a bogus
3999 negative value.
4000
4001 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4002 `error', not SYMBOL_NAME itself.
4003
4004 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4005 character arguments to `error'.
4006
4007 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4008 to `error' in error message about FINAL_CHAR argument. Make sure
4009 FINAL_CHAR is a character, and use %c when it is passed as
4010 argument to `error'.
4011
4012 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4013
4014 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4015
4016 * w32.c: Include <time.h>.
4017 (sys_localtime): New function.
4018
4019 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4020
4021 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4022
4023 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4024
4025 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4026
4027 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4028 zombies (Bug#8467).
4029
4030 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4031
4032 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4033 gl_state.e_property when gl_state.object is Qt.
4034
4035 * insdel.c (make_gap_larger): Remove limitation of buffer size
4036 to <= INT_MAX.
4037
4038 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4039
4040 * xdisp.c (lookup_glyphless_char_display)
4041 (produce_glyphless_glyph): Handle cons cell entry in
4042 glyphless-char-display.
4043 (Vglyphless_char_display): Document it.
4044
4045 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4046 glyphless-char-display.
4047
4048 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4049
4050 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4051
4052 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4053
4054 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4055 definition for no-X builds.
4056
4057 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4058
4059 Static checks with GCC 4.6.0 and non-default toolkits.
4060
4061 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4062
4063 * process.c (keyboard_bit_set): Define only if SIGIO.
4064 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4065 (send_process): Repair possible setjmp clobbering.
4066
4067 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4068
4069 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4070
4071 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4072
4073 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4074 Define only if needed.
4075
4076 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4077 by pacifying GCC about it. Maybe it's time to retire it?
4078 * xfaces.c (USG, __TIMEVAL__): Likewise.
4079
4080 * dispextern.h (struct redisplay_interface): Rename param
4081 to avoid shadowing.
4082 * termhooks.h (struct terminal): Likewise.
4083 * xterm.c (xembed_send_message): Likewise.
4084
4085 * insdel.c (make_gap_smaller): Define only if
4086 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4087
4088 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4089 it.
4090
4091 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4092 so that we aren't warned about unused symbols.
4093
4094 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4095
4096 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4097
4098 * xfns.c (x_real_positions): Mark locals as initialized.
4099
4100 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4101
4102 * xterm.c: Fix problems found by static analysis with other toolkits.
4103 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4104 (x_dispatch_event): Declare static if USE_GTK, and
4105 define if USE_GTK || USE_X_TOOLKIT.
4106 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4107 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4108 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4109 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4110
4111 * xmenu.c (menu_help_callback): Pointer type fixes.
4112 Use const pointers when pointing at readonly data. Avoid pointer
4113 signedness clashes.
4114 (FALSE): Remove unused macro.
4115 (update_frame_menubar): Remove unused decl.
4116
4117 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4118
4119 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4120 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4121 (single_menu_item): Rename local to avoid shadowing.
4122
4123 * keyboard.c (make_lispy_event): Remove unused local var.
4124
4125 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4126 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4127
4128 * bitmaps: Change bitmaps from unsigned char back to the X11
4129 compatible char. Avoid the old compiler warnings about
4130 out-of-range initializers by using, for example, '\xab' rather
4131 than 0xab.
4132
4133 * xgselect.c (xgselect_initialize): Check vs interface
4134 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4135
4136 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4137
4138 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4139 to read-only memory.
4140
4141 * fns.c (vector): Remove; this old hack is no longer needed.
4142
4143 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4144 Remove unused var.
4145 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4146
4147 * xrdb.c (x_load_resources): Omit unused local.
4148
4149 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4150 (x_window): Rename locals to avoid shadowing.
4151 (USG): Use the kludged USG macro, to pacify gcc.
4152
4153 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4154 (x_term_init): Remove local to avoid shadowing.
4155
4156 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4157
4158 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4159 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4160
4161 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4162
4163 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4164
4165 Fix regex.c, syntax.c and friends for buffers > 2GB.
4166 * syntax.h (struct gl_state_s): Declare character position members
4167 EMACS_INT.
4168
4169 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4170
4171 * textprop.c (verify_interval_modification, interval_of):
4172 Declare arguments EMACS_INT.
4173
4174 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4175 EMACS_INT.
4176
4177 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4178
4179 * indent.c (Fvertical_motion): Local variable it_start is now
4180 EMACS_INT.
4181
4182 * regex.c (re_match, re_match_2, re_match_2_internal)
4183 (bcmp_translate, regcomp, regexec, print_double_string)
4184 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4185 (re_compile_pattern, re_exec): Declare arguments and local
4186 variables `size_t' and `ssize_t' and return values `regoff_t', as
4187 appropriate.
4188 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4189 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4190 <compile_stack_type>: `size' and `avail' are now `size_t'.
4191
4192 * regex.h <regoff_t>: Use ssize_t, not int.
4193 (re_search, re_search_2, re_match, re_match_2): Arguments that
4194 specify buffer/string position and length are now ssize_t and
4195 size_t. Return type is regoff_t.
4196
4197 2011-04-16 Ben Key <bkey76@gmail.com>
4198
4199 * nsfont.m: Fixed bugs in ns_get_family and
4200 ns_descriptor_to_entity that were caused by using free to
4201 deallocate memory blocks that were allocated by xmalloc (via
4202 xstrdup). This caused Emacs to crash when compiled with
4203 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4204 --enable-checking=xmallocoverrun). xfree is now used to
4205 deallocate these memory blocks.
4206
4207 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4208
4209 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4210
4211 emacs_write: Accept and return EMACS_INT for sizes.
4212 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4213 et seq.
4214 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4215 Accept and return EMACS_INT.
4216 (emacs_gnutls_write): Return the number of bytes written on
4217 partial writes.
4218 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4219 (emacs_read, emacs_write): Remove check for negative size, as the
4220 Emacs source code has been audited now.
4221 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4222 (emacs_read, emacs_write): Use it.
4223 * process.c (send_process): Adjust to the new signatures of
4224 emacs_write and emacs_gnutls_write. Do not attempt to store
4225 a byte offset into an 'int'; it might overflow.
4226 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4227
4228 * sound.c: Don't assume sizes fit in 'int'.
4229 (struct sound_device.period_size, alsa_period_size):
4230 Return EMACS_INT, not int.
4231 (struct sound_device.write, vox_write, alsa_write):
4232 Accept EMACS_INT, not int.
4233 (wav_play, au_play): Use EMACS_INT to store sizes and to
4234 record read return values.
4235
4236 2011-04-15 Ben Key <bkey76@gmail.com>
4237
4238 * keyboard.c (Qundefined): Don't declare static since it is used
4239 in nsfns.m.
4240 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4241 static since they are used in nsfont.m.
4242
4243 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 * process.c (Qprocessp): Don't declare static.
4246 * lisp.h (Qprocessp): Declare again.
4247
4248 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4249
4250 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4251
4252 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4253
4254 Improve C-level modularity by making more things 'static'.
4255
4256 Don't publish debugger-only interfaces to other modules.
4257 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4258 (verify_bytepos, count_markers): Move decls to the only modules
4259 that need them.
4260 * region-cache.h (pp_cache): Likewise.
4261 * window.h (check_all_windows): Likewise.
4262 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4263
4264 * sysdep.c (croak): Now static, if
4265 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4266 * syssignal.h (croak): Declare only if not static.
4267
4268 * alloc.c (refill_memory_reserve): Now static if
4269 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4270 * lisp.h (refill_memory_reserve): Declare only if not static.
4271
4272 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4273 Define only if USE_LUCID.
4274
4275 * xrdb.c (x_customization_string, x_rm_string): Now static.
4276
4277 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4278 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4279
4280 * xdisp.c (draw_row_with_mouse_face): Now static.
4281 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4282
4283 * window.h (check_all_windows): Mark externally visible.
4284
4285 * window.c (window_deletion_count): Now static.
4286
4287 * undo.c: Make symbols static if they're not exported.
4288 (last_undo_buffer, last_boundary_position, pending_boundary):
4289 Now static.
4290
4291 * textprop.c (interval_insert_behind_hooks): Now static.
4292 (interval_insert_in_front_hooks): Likewise.
4293
4294 * term.c: Make symbols static if they're not exported.
4295 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4296 (max_frame_lines, tty_set_terminal_modes):
4297 (tty_reset_terminal_modes, tty_turn_off_highlight):
4298 (get_tty_terminal): Now static.
4299 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4300 * termhooks.h (term_mouse_moveto): Do not declare if
4301 HAVE_WINDOW_SYSTEM.
4302 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4303 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4304
4305 * sysdep.c: Make symbols static if they're not exported.
4306 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4307 Now static.
4308 (sigprocmask_set, full_mask): Remove; unused.
4309 (wait_debugging): Mark as visible.
4310 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4311 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4312
4313 * syntax.c (syntax_temp): Define only if !__GNUC__.
4314
4315 * sound.c (current_sound_device, current_sound): Now static.
4316
4317 * search.c (searchbufs, searchbuf_head): Now static.
4318
4319 * scroll.c (scroll_cost): Remove; unused.
4320 * dispextern.h (scroll_cost): Remove decl.
4321
4322 * region-cache.h (pp_cache): Mark as externally visible.
4323
4324 * process.c: Make symbols static if they're not exported.
4325 (process_tick, update_tick, create_process, chan_process):
4326 (Vprocess_alist, proc_buffered_char, datagram_access):
4327 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4328 (deactivate_process): Mark defn as static, as well as decl.
4329 * lisp.h (create_process): Remove decl.
4330 * process.h (chan_process, Vprocess_alist): Remove decls.
4331
4332 * print.c: Make symbols static if they're not exported.
4333 (print_depth, new_backquote_output, being_printed, print_buffer):
4334 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4335 (print_interval, print_number_index, initial_stderr_stream):
4336 Now static.
4337 * lisp.h (Fprinc): Remove decl.
4338 (debug_output_compilation_hack): Mark as externally visible.
4339
4340 * sysdep.c (croak): Move decl from here to syssignal.h.
4341 * syssignal.h (croak): Put it here, so the API can be checked when
4342 'croak' is called from dissociate_if_controlling_tty.
4343
4344 * minibuf.c: Make symbols static if they're not exported.
4345 (minibuf_save_list, choose_minibuf_frame): Now static.
4346 * lisp.h (choose_minibuf_frame): Remove decl.
4347
4348 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4349
4350 * lread.c: Make symbols static if they're not exported.
4351 (read_objects, initial_obarray, oblookup_last_bucket_number):
4352 Now static.
4353 (make_symbol): Remove; unused.
4354 * lisp.h (initial_obarray, make_symbol): Remove decls.
4355
4356 * keyboard.c: Make symbols static if they're not exported.
4357 (single_kboard, recent_keys_index, total_keys, recent_keys):
4358 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4359 (this_single_command_key_start, echoing, last_auto_save):
4360 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4361 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4362 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4363 (Vlispy_mouse_stem, double_click_count):
4364 Now static.
4365 (force_auto_save_soon): Define only if SIGDANGER.
4366 (ignore_mouse_drag_p): Now static if
4367 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4368 (print_help): Remove; unused.
4369 (stop_character, last_timer_event): Mark as externally visible.
4370 * keyboard.h (ignore_mouse_drag_p): Declare only if
4371 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4372 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4373 * lisp.h (echoing): Remove decl.
4374 (force_auto_save_soon): Declare only if SIGDANGER.
4375 * xdisp.c (redisplay_window): Simplify code, to make it more
4376 obvious that ignore_mouse_drag_p is not accessed if !defined
4377 USE_GTK && !defined HAVE_NS.
4378
4379 * intervals.c: Make symbols static if they're not exported.
4380 (merge_properties_sticky, merge_interval_right, delete_interval):
4381 Now static.
4382 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4383
4384 * insdel.c: Make symbols static if they're not exported.
4385 However, leave prepare_to_modify_buffer alone. It's never
4386 called from outside this function, but that appears to be a bug.
4387 (combine_after_change_list, combine_after_change_buffer):
4388 (adjust_after_replace, signal_before_change): Now static.
4389 (adjust_after_replace_noundo): Remove; unused.
4390 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4391 (signal_before_change): Remove decls.
4392
4393 * indent.c (val_compute_motion, val_vmotion): Now static.
4394
4395 * image.c: Make symbols static if they're not exported.
4396 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4397 if USE_GTK.
4398 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4399 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4400
4401 * fringe.c (standard_bitmaps): Now static.
4402 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4403
4404 * frame.c: Make symbols static if they're not exported.
4405 (x_report_frame_params, make_terminal_frame): Now static.
4406 (get_frame_param): Now static, unless HAVE_NS.
4407 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4408 (x_get_resource_string): Remove; not used.
4409 * frame.h (make_terminal_frame, x_report_frame_params):
4410 (x_get_resource_string); Remove decls.
4411 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4412 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4413
4414 * font.c, fontset.c: Make symbols static if they're not exported.
4415 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4416 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4417 * font.c (font_close_object): Now static.
4418 * font.h (font_close_object): Remove.
4419 * fontset.c (FONTSET_OBJLIST): Remove.
4420 (free_realized_fontset) #if-0 the body, which does nothing.
4421 (face_suitable_for_char_p): #if-0, as it's never called.
4422 * fontset.h (face_suitable_for_char_p): Remove decl.
4423 * xfaces.c (face_at_string_position):
4424 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4425 since 0 is always ASCII.
4426
4427 * fns.c (weak_hash_tables): Now static.
4428
4429 * fileio.c: Make symbols static if they're not exported.
4430 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4431 (Vwrite_region_annotation_buffers): Now static.
4432
4433 * eval.c: Make symbols static if they're not exported.
4434 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4435 * lisp.h (backtrace_list): Remove decl.
4436
4437 * emacs.c: Make symbols static if they're not exported.
4438 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4439 (fatal_error_code, fatal_error_signal_hook, standard_args):
4440 Now static.
4441 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4442 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4443 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4444 * lisp.h (fatal_error_signal_hook): Remove decl.
4445 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4446
4447 * editfns.c: Move a (normally-unused) function to its only use.
4448 * editfns.c, lisp.h (get_operating_system_release): Remove.
4449 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4450 worth the hassle of breaking this out.
4451
4452 * xterm.c: Make symbols static if they're not exported.
4453 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4454 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4455 (x_destroy_window, x_delete_display):
4456 Now static.
4457 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4458 (x_mouse_leave): Remove; unused.
4459 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4460 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4461 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4462 Remove decls.
4463 (x_mouse_leave): Declare only if WINDOWSNT.
4464 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4465 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4466 USE_X_TOOLKIT.
4467
4468 * ftxfont.c: Make symbols static if they're not exported.
4469 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4470 HAVE_FREETYPE.
4471 * font.h (ftxfont_driver): Likewise.
4472
4473 * xfns.c: Make symbols static if they're not exported.
4474 (x_last_font_name, x_display_info_for_name):
4475 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4476 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4477 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4478 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4479 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4480 (last_show_tip_args): Now static.
4481 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4482 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4483 (x_screen_planes): Remove; unused.
4484 * dispextern.h (x_screen_planes): Remove decl.
4485
4486 * dispnew.c: Make symbols static if they're not exported.
4487 * dispextern.h (redraw_garbaged_frames, scrolling):
4488 (increment_row_positions): Remove.
4489 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4490 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4491 Now static.
4492 (redraw_garbaged_frames): Remove; unused.
4493
4494 * xfaces.c: Make symbols static if they're not exported.
4495 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4496 Remove decls.
4497 * xterm.h (defined_color): Remove decls.
4498 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4499 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4500 (menu_face_changed_default, defined_color, free_realized_face):
4501 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4502 (ascii_face_of_lisp_face): Remove; unused.
4503
4504 * xdisp.c: Make symbols static if they're not exported.
4505 * dispextern.h (scratch_glyph_row, window_box_edges):
4506 (glyph_to_pixel_coords, set_cursor_from_row):
4507 (get_next_display_element, set_iterator_to_next):
4508 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4509 (show_mouse_face): Remove decls
4510 * frame.h (message_buf_print): Likewise.
4511 * lisp.h (pop_message, set_message, check_point_in_composition):
4512 Likewise.
4513 * xterm.h (set_vertical_scroll_bar): Likewise.
4514 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4515 (message_buf_print, scratch_glyph_row, displayed_buffer):
4516 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4517 (get_next_display_element, show_mouse_face, window_box_edges):
4518 (frame_to_window_pixel_xy, check_point_in_composition):
4519 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4520 (glyph_to_pixel_coords): Remove; unused.
4521
4522 * dired.c (file_name_completion): Now static.
4523
4524 * dbusbind.c (xd_in_read_queued_messages): Now static.
4525
4526 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4527 * data.c (circular_list_error): Remove.
4528
4529 * commands.h (last_point_position, last_point_position_buffer):
4530 (last_point_position_window): Remove decls.
4531 * keyboard.c: Make these variables static.
4532
4533 * coding.h (coding, code_convert_region, encode_coding_gap):
4534 Remove decls.
4535 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4536 (iso_code_class, detect_coding, code_convert_region): Now static.
4537 (encode_coding_gap): Remove; unused.
4538
4539 * chartab.c (chartab_chars, chartab_bits): Now static.
4540
4541 * charset.h (charset_iso_8859_1): Remove decl.
4542 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4543 Now static.
4544
4545 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4546 * ccl.c (Vccl_program_table): Now static.
4547 (check_ccl_update): Remove; unused.
4548
4549 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4550 * category.h: ... from here.
4551 * category.c (check_category_table, set_category_set): Now static.
4552
4553 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4554 * lisp.h: Remove these decls.
4555
4556 * buffer.c (buffer_count): Remove unused var.
4557
4558 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4559 so that it's not optimized away.
4560 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4561 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4562 exported only to the debugger.
4563
4564 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4565 * atimer.h (run_all_atimers): Remove; not exported.
4566
4567 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4568 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4569 was inaccessible from Lisp.
4570 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4571 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4572
4573 alloc.c: Import and export fewer symbols, and remove unused items.
4574 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4575 is defined.
4576 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4577 it's not optimized away by whole-program optimization.
4578 (message_enable_multibyte, free_misc): Remove.
4579 (catchlist, handlerlist, mark_backtrace):
4580 Declare only if BYTE_MARK_STACK.
4581 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4582 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4583 (message_enable_multibyte): Remove decl.
4584 (free_misc, interval_free_list, float_block, float_block_index):
4585 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4586 (cons_free_list, last_marked_index):
4587 Now static.
4588 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4589 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4590 (mark_backtrace): Define only if BYTE_MARK_STACK.
4591 * xdisp.c (message_enable_multibyte): Now static.
4592
4593 Declare Lisp_Object Q* variables to be 'static' if not exported.
4594 This makes it easier for human readers (and static analyzers)
4595 to see whether these variables are used from other modules.
4596 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4597 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4598 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4599 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4600 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4601 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4602 * xmenu.c, xselect.c:
4603 Declare Q* vars static if they are not used in other modules.
4604 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4605 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4606 Remove decls of unexported vars.
4607 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4608
4609 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4610
4611 Make Emacs functions such as Fatom 'static' by default.
4612 This makes it easier for human readers (and static analyzers)
4613 to see whether these functions can be called from other modules.
4614 DEFUN now defines a static function. To make the function external
4615 so that it can be used in other C modules, use the new macro DEFUE.
4616 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4617 (Finit_image_library):
4618 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4619 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4620 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4621 Remove decls, since these functions are now static.
4622 (Funintern, Fget_internal_run_time): New decls, since these functions
4623 were already external.
4624
4625 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4626 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4627 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4628 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4629 * keyboard.c, keymap.c, lread.c:
4630 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4631 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4632 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4633 Mark functions with DEFUE instead of DEFUN,
4634 if they are used in other modules.
4635 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4636 decls for now-static functions.
4637 * buffer.h (Fdelete_overlay): Remove decl.
4638 * callproc.c (Fgetenv_internal): Mark as internal.
4639 * composite.c (Fremove_list_of_text_properties): Remove decl.
4640 (Fcomposition_get_gstring): New forward static decl.
4641 * composite.h (Fcomposite_get_gstring): Remove decl.
4642 * dired.c (Ffile_attributes): New forward static decl.
4643 * doc.c (Fdocumntation_property): New forward static decl.
4644 * eval.c (Ffetch_bytecode): New forward static decl.
4645 (Funintern): Remove extern decl; now in .h file where it belongs.
4646 * fileio.c (Fmake_symbolic_link): New forward static decl.
4647 * image.c (Finit_image_library): New forward static decl.
4648 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4649 * intervals.h (Fprevious_property_change):
4650 (Fremove_list_of_text_properties): Remove decls.
4651 * keyboard.c (Fthis_command_keys): Remove decl.
4652 (Fcommand_execute): New forward static decl.
4653 * keymap.c (Flookup_key): New forward static decl.
4654 (Fcopy_keymap): Now static.
4655 * keymap.h (Flookup_key): Remove decl.
4656 * process.c (Fget_process): New forward static decl.
4657 (Fprocess_datagram_address): Mark as internal.
4658 * syntax.c (Fsyntax_table_p): New forward static decl.
4659 (skip_chars): Remove duplicate decl.
4660 * textprop.c (Fprevious_property_change): New forward static decl.
4661 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4662 Now internal.
4663 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4664 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4665
4666 * editfns.c (Fformat): Remove unreachable code.
4667
4668 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4669
4670 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4671 change. (Bug#8496)
4672
4673 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4674
4675 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4676 when at ZV. (Bug#8487)
4677
4678 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4679
4680 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4681 (Bug#8437)
4682 * keyboard.c (parse_tool_bar_item): Likewise.
4683 * sound.c (sound_cleanup, alsa_close): Likewise.
4684 * termcap.c (tgetent): Likewise.
4685 * xfns.c (x_default_font_parameter): Likewise.
4686 * xsettings.c (read_and_apply_settings): Likewise.
4687
4688 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4689 (overrun_check_free): Protoize.
4690
4691 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4694 since callers should never pass a negative size.
4695 Change the signature to match that of plain 'read' and 'write'; see
4696 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4697 * lisp.h: Update prototypes of emacs_write and emacs_read.
4698
4699 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4700
4701 * xdisp.c (redisplay_window): Don't try to determine the character
4702 position of the scroll margin if the window start point w->startp
4703 is outside the buffer's accessible region. (Bug#8468)
4704
4705 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4706
4707 Fix write-region and its subroutines for buffers > 2GB.
4708 * fileio.c (a_write, e_write): Modify declaration of arguments and
4709 local variables to support buffers larger than 2GB.
4710 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4711
4712 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4713 argument, local variables, and return value.
4714
4715 * lisp.h: Update prototypes of emacs_write and emacs_read.
4716
4717 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4718
4719 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4720
4721 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4722
4723 Fix more problems found by GCC 4.6.0's static checks.
4724
4725 * xdisp.c (vmessage): Use a better test for character truncation.
4726
4727 * charset.c (load_charset_map): <, not <=, for optimization,
4728 and to avoid potential problems with integer overflow.
4729 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4730 * casetab.c (set_identity, shuffle): Likewise.
4731 * editfns.c (Fformat): Likewise.
4732 * syntax.c (skip_chars): Likewise.
4733
4734 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4735 This also lets GCC 4.6.0 generate slightly better loop code.
4736
4737 * callint.c (Fcall_interactively): <, not <=, for optimization.
4738 (Fcall_interactively): Count the number of arguments produced,
4739 not the number of arguments given. This is simpler and lets GCC
4740 4.6.0 generate slightly better code.
4741
4742 * ftfont.c: Distingish more carefully between FcChar8 and char.
4743 The previous code passed unsigned char * to a functions like
4744 strlen and xstrcasecmp that expect char *, which does not
4745 conform to the C standard.
4746 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4747 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4748 char * when the C standard requires it.
4749
4750 * keyboard.c (read_char): Remove unused var.
4751
4752 * eval.c: Port to Windows vsnprintf (Bug#8435).
4753 Include <limits.h>.
4754 (SIZE_MAX): Define if the headers do not.
4755 (verror): Do not give up if vsnprintf returns a negative count.
4756 Instead, grow the buffer. This ports to Windows vsnprintf, which
4757 does not conform to C99. Problem reported by Eli Zaretskii.
4758 Also, simplify the allocation scheme, by avoiding the need for
4759 calling realloc, and removing the ALLOCATED variable.
4760
4761 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4762
4763 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4764 But keep the doprint source code for now, as we might revamp it
4765 and use it again (Bug#8435).
4766 * lisp.h (doprnt): Remove.
4767 * Makefile.in (base_obj): Remove doprnt.o.
4768 * deps.mk (doprnt.o): Remove.
4769
4770 error: Print 32- and 64-bit integers portably (Bug#8435).
4771 Without this change, on typical 64-bit hosts error ("...%d...", N)
4772 was used to print both 32- and 64-bit integers N, which relied on
4773 undefined behavior.
4774 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4775 New macro.
4776 * lisp.h (error, verror): Mark as printf-like functions.
4777 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4778 Report overflow in size calculations when allocating printf buffer.
4779 Do not truncate output string at its first null byte.
4780 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4781 Truncate the output at a character boundary, since vsnprintf does not
4782 do that.
4783 * charset.c (check_iso_charset_parameter): Convert internal
4784 character to string before calling 'error', since %c now has the
4785 printf meaning.
4786 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4787 overflow when computing char to be passed to 'error'. Do not
4788 pass Lisp_Object to 'error'; pass the integer instead.
4789 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4790 formatted with plain %d.
4791
4792 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4793
4794 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4795
4796 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4797
4798 * xterm.c (x_catch_errors): Remove duplicate declaration.
4799
4800 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4801
4802 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4803
4804 2011-04-10 Jim Meyering <meyering@redhat.com>
4805
4806 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4807 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4808 return ssize_t not "int", and use size_t as the buffer length.
4809 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4810 * gnutls.h: Update declarations.
4811 * process.c (read_process_output): Use ssize_t, to match.
4812 (send_process): Likewise.
4813
4814 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4815
4816 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4817
4818 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4819
4820 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4821 Use unsigned char, to match FcChar8 type definition.
4822
4823 * xterm.c (handle_one_xevent):
4824 * xmenu.c (create_and_show_popup_menu):
4825 * xselect.c (x_decline_selection_request)
4826 (x_reply_selection_request): Avoid type-punned deref of X events.
4827
4828 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4829
4830 Fix some uses of `int' instead of EMACS_INT.
4831 * search.c (string_match_1, fast_string_match)
4832 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4833 (scan_buffer, find_next_newline_no_quit)
4834 (find_before_next_newline, search_command, Freplace_match)
4835 (Fmatch_data): Make some `int' variables be EMACS_INT.
4836
4837 * xdisp.c (display_count_lines): 3rd argument and return value now
4838 EMACS_INT. All callers changed.
4839 (pint2hrstr): Last argument is now EMACS_INT.
4840
4841 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4842 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4843 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4844 (decode_coding_utf_16, decode_coding_emacs_mule)
4845 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4846 (decode_coding_ccl, decode_coding_charset)
4847 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4848 (decode_coding_iso_2022, decode_coding_emacs_mule)
4849 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4850 <char_offset, last_offset>: Declare EMACS_INT.
4851 (encode_coding_utf_8, encode_coding_utf_16)
4852 (encode_coding_emacs_mule, encode_invocation_designation)
4853 (encode_designation_at_bol, encode_coding_iso_2022)
4854 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4855 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4856 Declare EMACS_INT.
4857 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4858 (encode_invocation_designation): Last argument P_NCHARS is now
4859 EMACS_INT.
4860 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4861 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4862
4863 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4864 All users changed.
4865
4866 * ccl.c (Fccl_execute_on_string): Declare some variables
4867 EMACS_INT.
4868
4869 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4870
4871 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4872
4873 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4874
4875 * process.c (Fformat_network_address): Doc fix.
4876
4877 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4878
4879 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4880
4881 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4882
4883 * keyboard.c (read_char): Call Lisp function help-form-show,
4884 instead of using internal_with_output_to_temp_buffer.
4885 (Qhelp_form_show): New var.
4886 (syms_of_keyboard): Use DEFSYM macro.
4887
4888 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4889
4890 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4891
4892 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4893
4894 * process.c (Flist_processes): Remove to Lisp.
4895 (list_processes_1): Delete.
4896
4897 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4898
4899 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4900
4901 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4902
4903 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 Fix more problems found by GCC 4.6.0's static checks.
4906
4907 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4908
4909 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4910
4911 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4912
4913 * xdisp.c (vmessage): Mark as a printf-like function.
4914
4915 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4916
4917 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4918
4919 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4920 printf-like functions.
4921 (tiff_load): Add casts to remove these marks before passing them
4922 to system-supplied API.
4923
4924 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4925
4926 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4927 This avoids several warnings with gcc -Wstrict-overflow.
4928 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4929 directly, rather than having caller test rule sign. This avoids
4930 some unnecessary tests.
4931 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4932 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4933 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4934
4935 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4936 (xfont_open): Avoid unnecessary tests.
4937
4938 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4939
4940 * composite.h, composite.c (composition_gstring_put_cache):
4941 Use EMACS_INT, not int, for length.
4942
4943 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4944 breaking out part of COMPOSITION_DECODE_RULE.
4945 (COMPOSITION_DECODE_RULE): Use it.
4946 * composite.c (get_composition_id): Remove unused local vars,
4947 by using the new macro.
4948
4949 * textprop.c (set_text_properties_1): Change while to do-while,
4950 since the condition is always true at first.
4951
4952 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4953 (interval_deletion_adjustment): Return unsigned value.
4954 All uses changed.
4955
4956 * process.c (list_processes_1, create_pty, read_process_output):
4957 (exec_sentinel): Remove vars that were set but not used.
4958 (create_pty): Remove unnecessary "volatile"s.
4959 (Fnetwork_interface_info): Avoid possibility of int overflow.
4960 (read_process_output): Do adaptive read buffering even if carryover.
4961 (read_process_output): Simplify nbytes computation if buffered.
4962
4963 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4964
4965 * syntax.c (scan_words): Remove var that was set but not used.
4966 (update_syntax_table): Use unsigned instead of int.
4967
4968 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4969 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4970 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4971
4972 * print.c (print_error_message): Avoid int overflow.
4973
4974 * font.c (font_list_entities): Redo for clarity,
4975 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4976
4977 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4978 (font_score): Avoid potential overflow in diff calculation.
4979
4980 * fns.c (substring_both): Remove var that is set but not used.
4981 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4982
4983 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4984
4985 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4986 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4987 can always succeed if overflow has undefined behavior.
4988
4989 * search.c (boyer_moore, wordify): Remove vars set but not used.
4990 (wordify): Omit three unnecessary tests.
4991
4992 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4993 All callers changed. This avoids the need for an unused var.
4994
4995 * casefiddle.c (casify_region): Remove var that is set but not used.
4996
4997 * dired.c (file_name_completion): Remove var that is set but not used.
4998
4999 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5000
5001 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5002 (Finsert_file_contents): Remove unnecessary code checking fd.
5003
5004 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5005 Check for integer overflow on size calculations.
5006
5007 * buffer.c (Fprevious_overlay_change): Remove var that is set
5008 but not used.
5009
5010 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5011 Remove vars that are set but not used.
5012 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5013 (timer_check_2): Mark vars as initialized.
5014
5015 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5016
5017 * image.c (lookup_image): Remove var that is set but not used.
5018 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5019
5020 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5021 that are set but not used.
5022
5023 * xfns.c (make_invisible_cursor): Don't return garbage
5024 if XCreateBitmapFromData fails (Bug#8410).
5025
5026 * xselect.c (x_get_local_selection, x_handle_property_notify):
5027 Remove vars that are set but not used.
5028
5029 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5030 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5031
5032 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5033 Remove var that is set but not used.
5034 (scroll_bar_windows_size): Now size_t, not int.
5035 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5036 Check for overflow.
5037
5038 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5039 (map_tty_color) [!defined MSDOS]: Likewise.
5040
5041 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5042
5043 * coding.c: Remove vars that are set but not used.
5044 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5045 All callers changed.
5046 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5047 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5048 (decode_coding_charset): Remove vars that are set but not used.
5049
5050 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5051 that is set but not used.
5052
5053 * print.c (print_object): Remove var that is set but not used.
5054
5055 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5056 The gnulib version avoids calling malloc in the usual case,
5057 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5058 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5059 * filelock.c (current_lock_owner): Likewise.
5060 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5061 * sysdep.c: Include allocator.h, careadlinkat.h.
5062 (emacs_no_realloc_allocator): New static constant.
5063 (emacs_readlink): New function.
5064 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5065 ../lib/careadlinkat.h.
5066
5067 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5068
5069 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5070 first non-nil return value).
5071
5072 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5073
5074 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5075 if not defined (Bug#8403).
5076
5077 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5078
5079 * xdisp.c (display_count_lines): Remove parameter `start',
5080 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5081 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5082 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5083 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5084 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5085 and thereabouts. All callers changed.
5086 (get_per_char_metric): Remove parameter `f', unused since
5087 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5088
5089 2011-04-02 Jim Meyering <meyering@redhat.com>
5090
5091 do not dereference NULL upon failed strdup
5092 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5093 (ns_get_family): Likewise.
5094
5095 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5096
5097 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5098
5099 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5100
5101 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5102 later (Bug#8403).
5103
5104 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5105
5106 Add lexical binding.
5107
5108 * window.c (Ftemp_output_buffer_show): New fun.
5109 (Fsave_window_excursion):
5110 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5111
5112 * lread.c (lisp_file_lexically_bound_p): New function.
5113 (Fload): Bind Qlexical_binding.
5114 (readevalloop): Remove `evalfun' arg.
5115 Bind Qinternal_interpreter_environment.
5116 (Feval_buffer): Bind Qlexical_binding.
5117 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5118 Mark as dynamic.
5119 (syms_of_lread): Declare `lexical-binding'.
5120
5121 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5122
5123 * keyboard.c (eval_dyn): New fun.
5124 (menu_item_eval_property): Use it.
5125
5126 * image.c (parse_image_spec): Use Ffunctionp.
5127
5128 * fns.c (concat, mapcar1): Accept byte-code-functions.
5129
5130 * eval.c (Fsetq): Handle lexical vars.
5131 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5132 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5133 (FletX, Flet): Obey lexical binding.
5134 (Fcommandp): Handle closures.
5135 (Feval): New `lexical' arg.
5136 (eval_sub): New function extracted from Feval. Use it almost
5137 everywhere where Feval was used. Look up vars in lexical env.
5138 Handle closures.
5139 (Ffunctionp): Move from subr.el.
5140 (Ffuncall): Handle closures.
5141 (apply_lambda): Remove `eval_flags'.
5142 (funcall_lambda): Handle closures and new byte-code-functions.
5143 (Fspecial_variable_p): New function.
5144 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5145 but without exporting it to Lisp.
5146
5147 * doc.c (Fdocumentation, store_function_docstring):
5148 * data.c (Finteractive_form): Handle closures.
5149
5150 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5151 interactive spec.
5152
5153 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5154 New byte-codes.
5155 (exec_byte_code): New function extracted from Fbyte_code to handle new
5156 calling convention for byte-code-functions. Add new byte-codes.
5157
5158 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5159
5160 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5161
5162 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5163
5164 * xdisp.c (redisplay_internal): Fix prototype.
5165
5166 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5167
5168 * xdisp.c (SCROLL_LIMIT): New macro.
5169 (try_scrolling): Use it when setting scroll_limit.
5170 Limit scrolling to 100 screen lines.
5171 (redisplay_window): Even when falling back on "recentering",
5172 position point in the window according to scroll-conservatively,
5173 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5174
5175 (try_scrolling): When point is above the window, allow searching
5176 as far as scroll_max, or one screenful, to compute vertical
5177 distance from PT to the scroll margin position. This prevents
5178 try_scrolling from unnecessarily failing when
5179 scroll-conservatively is set to a value slightly larger than the
5180 window height. Clean up the case of PT below the margin at bottom
5181 of window: scroll_max can no longer be INT_MAX. When aggressive
5182 scrolling is in use, don't let point enter the opposite scroll
5183 margin as result of the scroll.
5184 (syms_of_xdisp) <scroll-conservatively>: Document the
5185 threshold of 100 lines for never-recentering scrolling.
5186
5187 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5188
5189 * dispextern.h (move_it_by_lines):
5190 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5191 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5192 (message_log_check_duplicate): Remove parameters `prev_bol' and
5193 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5194 (redisplay_internal): Remove parameter `preserve_echo_area',
5195 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5196
5197 * indent.c (Fvertical_motion):
5198 * window.c (window_scroll_pixel_based, Frecenter):
5199 Don't pass `need_y_p' to `move_it_by_lines'.
5200
5201 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5202
5203 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5204 steal a few bits to be more compact.
5205 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5206 Remove unneeded casts.
5207
5208 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5209
5210 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5211
5212 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5213 binding" message (bug#7967).
5214
5215 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5216
5217 Fix more problems found by GCC 4.6.0's static checks.
5218
5219 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5220 Remove unused local var.
5221
5222 * editfns.c (Fmessage_box): Remove unused local var.
5223
5224 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5225 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5226 Omit unused local vars.
5227 * window.c (shrink_windows): Omit unused local var.
5228 * menu.c (digest_single_submenu): Omit unused local var.
5229 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5230 Omit unused local var.
5231
5232 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5233 Don't assume string length fits in int.
5234 (keyremap_step, read_key_sequence): Use size_t for sizes.
5235 (read_key_sequence): Don't check last_real_key_start redundantly.
5236
5237 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5238 instead of alloca (Bug#8344).
5239
5240 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5241 (Fbacktrace_frame): Don't assume nframes fits in int.
5242
5243 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5244
5245 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5246 concerns.
5247
5248 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5249
5250 * cm.c (calccost): Turn while-do into do-while, for clarity.
5251
5252 * keyboard.c (syms_of_keyboard): Use the same style as later
5253 in this function when indexing through an array. This also
5254 works around GCC bug 48267.
5255
5256 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5257
5258 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5259
5260 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5261 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5262
5263 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5264 This avoids undefined behavior on integer overflow, and is a bit
5265 more convenient anyway since it is compared to a size_t variable.
5266
5267 Variadic C functions now count arguments with size_t, not int.
5268 This avoids an unnecessary limitation on 64-bit machines, which
5269 caused (substring ...) to crash on large vectors (Bug#8344).
5270 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5271 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5272 All variadic functions and their callers changed accordingly.
5273 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5274 * data.c (arith_driver, float_arith_driver): Likewise.
5275 * editfns.c (general_insert_function): Likewise.
5276 * eval.c (struct backtrace.nargs, interactive_p)
5277 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5278 (funcall_lambda, mark_backtrace): Likewise.
5279 * fns.c (concat): Likewise.
5280 * frame.c (x_set_frame_parameters): Likewise.
5281 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5282 0 if not found, not -1. All callers changed.
5283
5284 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5285 (stack_copy_size): Now size_t, not int.
5286 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5287
5288 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5289
5290 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5291 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5292 All callers changed.
5293
5294 * lisp.h (multibyte_char_to_unibyte):
5295 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5296 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5297 * character.h (CHAR_TO_BYTE8):
5298 * cmds.c (internal_self_insert):
5299 * editfns.c (general_insert_function):
5300 * keymap.c (push_key_description):
5301 * search.c (Freplace_match):
5302 * xdisp.c (message_dolog, set_message_1): All callers changed.
5303
5304 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5305
5306 * keyboard.c (safe_run_hook_funcall): New function.
5307 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5308 don't set the hook to nil, but remove the offending function instead.
5309 (Qcommand_hook_internal): Remove, unused.
5310 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5311 Vcommand_hook_internal.
5312
5313 * eval.c (enum run_hooks_condition): Remove.
5314 (funcall_nil, funcall_not): New functions.
5315 (run_hook_with_args): Call each function through a `funcall' argument.
5316 Remove `cond' argument, now redundant.
5317 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5318 (Frun_hook_with_args_until_failure): Adjust accordingly.
5319 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5320
5321 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5322
5323 * dispextern.h (string_buffer_position): Remove declaration.
5324
5325 * print.c (strout): Remove parameter `multibyte', unused since
5326 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5327
5328 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5329 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5330 All callers changed.
5331
5332 * w32.c (_wsa_errlist): Use braces for struct initializers.
5333
5334 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5335 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5336 All callers changed.
5337 (string_buffer_position): Likewise. Also, make static (it's never
5338 used outside xdisp.c).
5339 (cursor_row_p): Remove parameter `w', unused since
5340 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5341 (decode_mode_spec): Remove parameter `precision', introduced during
5342 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5343 All callers changed.
5344
5345 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5346
5347 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5348
5349 2011-03-27 Anders Lindgren <andlind@gmail.com>
5350
5351 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5352 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5353 (ns_update_auto_hide_menu_bar): New functions.
5354 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5355 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5356 ns_constrain_all_frames.
5357 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5358 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5359
5360 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5361
5362 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5363
5364 2011-03-27 Glenn Morris <rgm@gnu.org>
5365
5366 * syssignal.h: Replace RETSIGTYPE with void.
5367 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5368 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5369 Replace SIGTYPE with void everywhere.
5370 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5371 * s/template.h (SIGTYPE): Remove commented out definition.
5372
5373 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5374
5375 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5376 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5377
5378 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5379
5380 * w32.c (read_unc_volume): Use parameter `henum', instead of
5381 global variable `wget_enum_handle'.
5382
5383 * keymap.c (describe_vector): Remove parameters `indices' and
5384 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5385 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5386
5387 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5388
5389 * keyboard.c (timer_check): Remove parameter `do_it_now',
5390 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5391 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5392 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5393
5394 * keyboard.c (read_char):
5395 * w32menu.c (w32_menu_display_help):
5396 * xmenu.c (show_help_event, menu_help_callback):
5397 Adjust calls to `show_help_echo'.
5398
5399 * gtkutil.c (xg_maybe_add_timer):
5400 * keyboard.c (readable_events):
5401 * process.c (wait_reading_process_output):
5402 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5403
5404 * insdel.c (adjust_markers_gap_motion):
5405 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5406 (gap_left, gap_right): Don't call it.
5407
5408 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5409
5410 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5411 incurred during fontification.
5412
5413 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5414
5415 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5416 (DEFVAR_PER_BUFFER): Don't pass it.
5417
5418 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5419 (scrolling_window): Don't pass it.
5420
5421 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5422
5423 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5424
5425 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5426 and `suffix'.
5427 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5428 of variables specific to SELinux and computation of `encoded_absname'.
5429
5430 * image.c (XPutPixel): Remove unused variable `height'.
5431
5432 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5433
5434 * unexw32.c (get_section_info): Remove unused variable `section'.
5435
5436 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5437 (system_process_attributes): Remove unused variable `sess'.
5438 (sys_read): Remove unused variable `err'.
5439
5440 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5441 (w32_wnd_proc): Remove unused variable `isdead'.
5442 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5443 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5444 (x_create_tip_frame): Remove unused variable `tem'.
5445
5446 * w32inevt.c (w32_console_read_socket):
5447 Remove unused variable `no_events'.
5448
5449 * w32term.c (x_draw_composite_glyph_string_foreground):
5450 Remove unused variable `width'.
5451
5452 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5453
5454 * w32term.c (x_set_glyph_string_clipping):
5455 Don't pass uninitialized region to CombineRgn.
5456
5457 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5458
5459 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5460 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5461 (Fx_close_connection): Remove unused variable `i'.
5462
5463 * w32font.c (w32font_draw): Return number of glyphs.
5464 (w32font_open_internal): Remove unused variable `i'.
5465 (w32font_driver): Add missing initializer.
5466
5467 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5468 (fill_in_menu): Remove unused variable `items_added'.
5469
5470 * w32term.c (last_mouse_press_frame): Remove static global variable.
5471 (w32_clip_to_row): Remove unused variable `f'.
5472 (x_delete_terminal): Remove unused variable `i'.
5473
5474 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5475 (NOTHING): Remove unused static global variable.
5476 (uniscribe_check_otf): Remove unused variable `table'.
5477 (uniscribe_font_driver): Add missing initializers.
5478
5479 2011-03-23 Julien Danjou <julien@danjou.info>
5480
5481 * term.c (Fsuspend_tty, Fresume_tty):
5482 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5483 * window.c (temp_output_buffer_show):
5484 * insdel.c (signal_before_change):
5485 * frame.c (Fhandle_switch_frame):
5486 * fileio.c (Fdo_auto_save):
5487 * emacs.c (Fkill_emacs):
5488 * editfns.c (save_excursion_restore):
5489 * cmds.c (internal_self_insert):
5490 * callint.c (Fcall_interactively):
5491 * buffer.c (Fkill_all_local_variables):
5492 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5493 Use Frun_hooks.
5494 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5495 unconditionnaly since it does the check itself.
5496
5497 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5498
5499 Fix more problems found by GCC 4.5.2's static checks.
5500
5501 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5502 the first time through the loop, since we know p0 < p1 then.
5503 This also avoids a gcc -Wstrict-overflow warning.
5504
5505 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5506 leading to a memory leak, possible in functions like
5507 load_charset_map_from_file that can allocate an unbounded number
5508 of objects (Bug#8318).
5509
5510 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5511 that could (at least in theory) be that large.
5512
5513 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5514 This is less likely to overflow, and avoids undefined behavior if
5515 overflow does occur. All callers changed. Use strtoul to scan
5516 for the unsigned long integer.
5517 (pint2hrstr): Simplify and tune code slightly.
5518 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5519
5520 * scroll.c (do_scrolling): Work around GCC bug 48228.
5521 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5522
5523 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5524 This also avoids a warning with gcc -Wstrict-overflow.
5525 (validate_x_resource_name): Simplify count usage.
5526 This also avoids a warning with gcc -Wstrict-overflow.
5527
5528 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5529 fail (Bug#8306).
5530
5531 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5532
5533 * process.c (Fmake_network_process): Use socklen_t, not int,
5534 where POSIX says socklen_t is required in portable programs.
5535 This fixes a porting bug on hosts like 64-bit HP-UX, where
5536 socklen_t is wider than int (Bug#8277).
5537 (Fmake_network_process, server_accept_connection):
5538 (wait_reading_process_output, read_process_output):
5539 Likewise.
5540
5541 * process.c: Rename or move locals to avoid shadowing.
5542 (list_processes_1, Fmake_network_process):
5543 (read_process_output_error_handler, exec_sentinel_error_handler):
5544 Rename or move locals.
5545 (Fmake_network_process): Define label "retry_connect" only if needed.
5546 (Fnetwork_interface_info): Fix pointer signedness.
5547 (process_send_signal): Add cast to avoid pointer signedness problem.
5548 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5549 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5550
5551 Make tparam.h and terminfo.c consistent.
5552 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5553 Include tparam.h instead, since it declares them.
5554 * cm.h (PC): Remove extern decl; tparam.h now does this.
5555 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5556 * terminfo.c: Include tparam.h, to check interfaces.
5557 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5558 (tparam): Adjust signature to match interface in tparam.h;
5559 this removes some undefined behavior. Check that outstring and len
5560 are zero, which they always are with Emacs.
5561 * tparam.h (PC, BC, UP): New extern decls.
5562
5563 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5564 (xftfont_open): Rename locals to avoid shadowing.
5565
5566 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5567 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5568 (OTF_TAG_SYM): Omit macro if not needed.
5569 (ftfont_list): Remove unused local.
5570 (get_adstyle_property, ftfont_pattern_entity):
5571 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5572 Rename locals to avoid shadowing.
5573
5574 * xfont.c (xfont_list_family): Mark var as initialized.
5575
5576 * xml.c (make_dom): Now static.
5577
5578 * composite.c (composition_compute_stop_pos): Rename local to
5579 avoid shadowing.
5580 (composition_reseat_it): Remove unused locals.
5581 (find_automatic_composition, composition_adjust_point): Likewise.
5582 (composition_update_it): Mark var as initialized.
5583 (find_automatic_composition): Mark vars as initialized,
5584 with a FIXME (Bug#8290).
5585
5586 character.h: Rename locals to avoid shadowing.
5587 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5588 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5589 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5590 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5591 to avoid shadowing.
5592
5593 * textprop.c (property_change_between_p): Remove; unused.
5594
5595 * intervals.c (interval_start_pos): Now static.
5596
5597 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5598
5599 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5600 Rename locals to avoid shadowing.
5601
5602 * sound.c (wav_play, au_play, Fplay_sound_internal):
5603 Fix pointer signedness.
5604 (alsa_choose_format): Remove unused local var.
5605 (wav_play): Initialize a variable to 0, to prevent undefined
5606 behavior (Bug#8278).
5607
5608 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5609
5610 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5611
5612 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5613 clobbering (Bug#8298).
5614 * sysdep.c (sys_subshell): Likewise.
5615 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5616
5617 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5618 This should get cleaned up, so that child_setup has the
5619 same signature on all platforms.
5620
5621 * callproc.c (call_process_cleanup): Now static.
5622 (relocate_fd): Rename locals to avoid shadowing.
5623
5624 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5625
5626 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5627 not to be necessary, and produces flickering.
5628
5629 2011-03-20 Glenn Morris <rgm@gnu.org>
5630
5631 * config.in: Remove file.
5632
5633 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5634
5635 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5636 are now in src/globals.h.
5637 (syms_of_minibuf): Remove spurious & from previous change.
5638
5639 2011-03-20 Leo <sdl.web@gmail.com>
5640
5641 * minibuf.c (completing-read-function): New variable.
5642 (completing-read-default): Rename from completing-read.
5643 (completing-read): Call completing-read-function.
5644
5645 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5646
5647 * xfaces.c (Fx_load_color_file):
5648 Read color file from absolute filename (bug#8250).
5649
5650 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5651
5652 * makefile.w32-in: Update dependencies.
5653
5654 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5655
5656 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5657
5658 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5659
5660 Fix more problems found by GCC 4.5.2's static checks.
5661
5662 * process.c (make_serial_process_unwind, send_process_trap):
5663 (sigchld_handler): Now static.
5664
5665 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5666 That way, the code declares only the vars that it needs.
5667 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5668 * s/cygwin.h (PTY_ITERATION): Likewise.
5669 * s/darwin.h (PTY_ITERATION): Likewise.
5670 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5671
5672 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5673 * process.c (allocate_pty): Don't declare stb unless it's needed.
5674
5675 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5676 (CONSTANTLIM): Remove; unused.
5677 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5678 Define only if needed.
5679
5680 * unexelf.c (unexec): Name an expression,
5681 to avoid gcc -Wbad-function-cast warning.
5682 Use a different way to cause a compilation error if anyone uses
5683 n rather than nn, a way that does not involve shadowing.
5684 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5685
5686 * deps.mk (unexalpha.o): Remove; unused.
5687
5688 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5689 * unexec.h: New file.
5690 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5691 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5692 Depend on unexec.h.
5693 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5694 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5695 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5696 Change as necessary to match prototype in unexec.h.
5697
5698 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5699 shadowing.
5700 (back_comment, skip_chars): Mark vars as initialized.
5701
5702 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5703 Rename locals to avoid shadowing.
5704
5705 * lread.c (read1): Rewrite so as not to use empty "else".
5706 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5707
5708 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5709
5710 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5711 warning when compiling print.c.
5712
5713 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5714 instead of using an uninitialized var.
5715 (font_sort_entities): Mark var as initialized.
5716
5717 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5718
5719 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5720 pointers to constants.
5721 (font_parse_fcname): Remove unused vars.
5722 (font_delete_unmatched): Now static.
5723 (font_get_spec): Remove; unused.
5724 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5725 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5726 Rename or move locals to avoid shadowing.
5727
5728 * fns.c (require_nesting_list, require_unwind): Now static.
5729 (Ffillarray): Rename locals to avoid shadowing.
5730
5731 * floatfns.c (domain_error2): Define only if needed.
5732 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5733
5734 * alloc.c (mark_backtrace): Move decl from here ...
5735 * lisp.h: ... to here, so that it can be checked.
5736
5737 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5738 (Fdefvar): Rewrite so as not to use empty "else".
5739 (lisp_indirect_variable): Name an expression,
5740 to avoid gcc -Wbad-function-cast warning.
5741 (Fdefvar): Rename locals to avoid shadowing.
5742
5743 * callint.c (quotify_arg, quotify_args): Now static.
5744 (Fcall_interactively): Rename locals to avoid shadowing.
5745 Use const pointer when appropriate.
5746
5747 * lisp.h (get_system_name, get_operating_system_release):
5748 Move decls here, to check interfaces.
5749 * process.c (get_operating_system_release): Move decl to lisp.h.
5750 * xrdb.c (get_system_name): Likewise.
5751 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5752 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5753 some of which prompt warnings from gcc -Wbad-function-cast.
5754 (Fformat_time_string, Fencode_time, Finsert_char):
5755 (Ftranslate_region_internal, Fformat):
5756 Rename or remove local vars to avoid shadowing.
5757 (Ftranslate_region_internal): Mark var as initialized.
5758
5759 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5760 avoid shadowing.
5761
5762 * lisp.h (eassert): Check that the argument compiles, even if
5763 ENABLE_CHECKING is not defined.
5764
5765 * data.c (Findirect_variable): Name an expression, to avoid
5766 gcc -Wbad-function-cast warning.
5767 (default_value, arithcompare, arith_driver, arith_error): Now static.
5768 (store_symval_forwarding): Rename local to avoid shadowing.
5769 (Fmake_variable_buffer_local, Fmake_local_variable):
5770 Mark variables as initialized.
5771 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5772
5773 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5774 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5775 Rename locals to avoid shadowing.
5776 (mark_stack): Move local variables into the #ifdef region where
5777 they're used.
5778 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5779 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5780 needed otherwise.
5781 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5782 (GC_STRING_CHARS): Remove; not used.
5783 (Fmemory_limit): Cast sbrk's returned value to char *.
5784
5785 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5786 avoids undefined behavior in theory.
5787
5788 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5789
5790 Use functions, not macros, for up- and down-casing (Bug#8254).
5791 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5792 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5793 to use the following functions instead of these macros.
5794 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5795 EMACS_INT, since callers assume the returned value fits in int.
5796 (upcase1): Likewise, for UPCASE_TABLE.
5797 (uppercasep, lowercasep, upcase): New static inline functions.
5798 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5799 the race-condition problem in the old DOWNCASE.
5800
5801 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5802 Rename locals to avoid shadowing.
5803 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5804 (regex_compile, re_search_2, re_match_2_internal):
5805 Remove unused local vars.
5806 (FREE_VAR): Rewrite so as not to use empty "else",
5807 which gcc can warn about.
5808 (regex_compile, re_match_2_internal): Mark locals as initialized.
5809 (RETALLOC_IF): Define only if needed.
5810 (WORDCHAR_P): Likewise. This one is never needed, but is used
5811 only in a comment talking about a compiler bug, so put inside
5812 the #if 0 of that comment.
5813 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5814 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5815 Remove; unused.
5816
5817 * search.c (boyer_moore): Rename locals to avoid shadowing.
5818 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5819 (PREV_CHAR_BOUNDARY): Likewise.
5820
5821 * search.c (simple_search): Remove unused var.
5822
5823 * dired.c (compile_pattern): Move decl from here ...
5824 * lisp.h: ... to here, so that it can be checked.
5825 (struct re_registers): New forward decl.
5826
5827 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5828
5829 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5830 All uses changed.
5831 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5832 Rename locals to avoid shadowing.
5833 (Fvertical_motion): Mark locals as initialized.
5834
5835 * casefiddle.c (casify_object, casify_region): Now static.
5836 (casify_region): Mark local as initialized.
5837
5838 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5839
5840 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5841 New macros, so that the caller can use some names other than
5842 gcpro1, gcpro2, etc.
5843 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5844 of the new macros.
5845 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5846 argument, for consistency with GCPRO2_VAR, etc: it is now the
5847 prefix of the variable, not the variable itself. All uses
5848 changed.
5849 * dired.c (directory_files_internal, file_name_completion):
5850 Rename locals to avoid shadowing.
5851
5852 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5853 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5854 dired.c's scmp function, had undefined behavior.
5855 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5856 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5857 * buffer.h: ... to here, because these macros use current_buffer,
5858 and the new implementation with inline functions needs to have
5859 current_buffer in scope now, rather than later when the macros
5860 are used.
5861 (downcase, upcase1): New static inline functions.
5862 (DOWNCASE, UPCASE1): Reimplement using these functions.
5863 This avoids undefined behavior in expressions like
5864 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5865 from race conditions in accessing the global variables
5866 case_temp1 and case_temp2.
5867 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5868 * lisp.h (case_temp1, case_temp2): Remove their decls.
5869 * character.h (ASCII_CHAR_P): Move from here ...
5870 * lisp.h: ... to here, so that the inline functions mentioned
5871 above can use them.
5872
5873 * dired.c (directory_files_internal_unwind): Now static.
5874
5875 * fileio.c (file_name_as_directory, directory_file_name):
5876 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5877 Now static.
5878 (file_name_as_directory): Use const pointers when appropriate.
5879 (Fexpand_file_name): Likewise. In particular, newdir might
5880 point at constant storage, so make it a const pointer.
5881 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5882 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5883 signedness issues.
5884 (Fset_file_times, Finsert_file_contents, auto_save_error):
5885 Rename locals to avoid shadowing.
5886
5887 * minibuf.c (choose_minibuf_frame_1): Now static.
5888 (Ftry_completion, Fall_completions): Rename or remove locals
5889 to avoid shadowing.
5890
5891 * marker.c (bytepos_to_charpos): Remove; unused.
5892
5893 * lisp.h (verify_bytepos, count_markers): New decls,
5894 so that gcc does not warn that these functions aren't declared.
5895
5896 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5897 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5898 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5899 (copy_text): Remove unused local var.
5900
5901 * filelock.c (within_one_second): Now static.
5902 (lock_file_1): Rename local to avoid shadowing.
5903
5904 * buffer.c (fix_overlays_before): Mark locals as initialized.
5905 (fix_start_end_in_overlays): Likewise. This function should be
5906 simplified by using pointers-to-pointers, but that's a different
5907 matter.
5908 (switch_to_buffer_1): Now static.
5909 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5910 (report_overlay_modification): Rename locals to avoid shadowing.
5911
5912 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5913 Fix pointer signedness issue.
5914 (sys_subshell): Mark local as volatile if checking for lint,
5915 to suppress a gcc -Wclobbered warning that does not seem to be right.
5916 (MAXPATHLEN): Define only if needed.
5917
5918 * process.c (serial_open, serial_configure): Move decls from here ...
5919 * systty.h: ... to here, so that they can be checked.
5920
5921 * fns.c (get_random, seed_random): Move extern decls from here ...
5922 * lisp.h: ... to here, so that they can be checked.
5923
5924 * sysdep.c (reset_io): Now static.
5925 (wait_for_termination_signal): Remove; unused.
5926
5927 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5928 (copy_keymap_item, append_key, push_text_char_description):
5929 Now static.
5930 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5931 (DENSE_TABLE_SIZE): Remove; unused.
5932 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5933 (describe_map_tree):
5934 Rename locals to avoid shadowing.
5935
5936 * keyboard.c: Declare functions static if they are not used elsewhere.
5937 (echo_char, echo_dash, cmd_error, top_level_2):
5938 (poll_for_input, handle_async_input): Now static.
5939 (read_char, kbd_buffer_get_event, make_lispy_position):
5940 (make_lispy_event, make_lispy_movement, apply_modifiers):
5941 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5942 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5943 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5944 (read_key_sequence, read_char): Mark locals as initialized.
5945 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5946
5947 * keyboard.h (make_ctrl_char): New decl.
5948 (mark_kboards): Move decl here ...
5949 * alloc.c (mark_kboards): ... from here.
5950
5951 * lisp.h (force_auto_save_soon): New decl.
5952
5953 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5954 (DEFINE_DUMMY_FUNCTION): New macro.
5955 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5956 Use it.
5957 (main): Add casts to avoid warnings
5958 if GCC considers string literals to be constants.
5959
5960 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5961
5962 * dbusbind.c: Pointer signedness fixes.
5963 (xd_signature, xd_append_arg, xd_initialize):
5964 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5965 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5966 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5967 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5968
5969 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5970 if GCC considers string literals to be constants.
5971 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5972
5973 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5974
5975 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5976 (print_preprocess, print_object): New macro to fix last change.
5977
5978 * print.c (print_preprocess): Don't forget font objects.
5979
5980 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5981
5982 * emacs.c (USAGE3): Doc fixes.
5983
5984 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5985
5986 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5987 structure.
5988
5989 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5990
5991 * lisp.h (VWindow_system, Qfile_name_history):
5992 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5993 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5994 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5995
5996 * w32select.c: Don't #include "keyboard.h".
5997 (run_protected): Add extern declaration for waiting_for_input.
5998
5999 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6000 * w32console.c (detect_input_pending, read_input_pending)
6001 (encode_terminal_code):
6002 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6003 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6004 (w32_system_caret_y, Qfile_name_history):
6005 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6006 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6007 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6008 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6009 * w32proc.c (Qlocal, report_file_error):
6010 * w32term.c (Vwindow_system, updating_frame):
6011 * w32uniscribe.c (initialized, uniscribe_font_driver):
6012 Remove unneeded extern declarations.
6013
6014 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6015
6016 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6017
6018 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6019
6020 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6021 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6022 These macros can no longer be used for assignment.
6023
6024 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6025 Assign struct members directly, instead of using BUF_BEGV etc.
6026 (record_buffer_markers, fetch_buffer_markers): New functions for
6027 recording and fetching special buffer markers.
6028 (set_buffer_internal_1, set_buffer_temp): Use them.
6029
6030 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6031
6032 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6033
6034 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6035 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6036
6037 * xdisp.c (hscroll_window_tree):
6038 (reconsider_clip_changes): Use PT instead of BUF_PT.
6039
6040 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6041
6042 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6043 $(EMACS_ROOT)/lib/intprops.h.
6044
6045 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6046
6047 Fix more problems found by GCC 4.5.2's static checks.
6048
6049 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6050 to unsigned char * to avoid compiler diagnostic.
6051 (xg_free_frame_widgets): Make it clear that a local variable is
6052 needed only if USE_GTK_TOOLTIP.
6053 (gdk_window_get_screen): Make it clear that this macro is needed
6054 only if USE_GTK_TOOLTIP.
6055 (int_gtk_range_get_value): New function, which avoids a diagnostic
6056 from gcc -Wbad-function-cast.
6057 (xg_set_toolkit_scroll_bar_thumb): Use it.
6058 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6059 diagnostic from gcc -Wbad-function-cast.
6060 (get_utf8_string, xg_get_file_with_chooser):
6061 Rename locals to avoid shadowing.
6062 (create_dialog): Move locals to avoid shadowing.
6063
6064 * xgselect.c (xg_select): Remove unused var.
6065
6066 * image.c (four_corners_best): Mark locals as initialized.
6067 (gif_load): Initialize transparent_p to zero (Bug#8238).
6068 Mark another local as initialized.
6069 (my_png_error, my_error_exit): Mark with NO_RETURN.
6070
6071 * image.c (clear_image_cache): Now static.
6072 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6073 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6074 (x_edge_detection): Remove unnecessary cast that
6075 gcc -Wbad-function-cast diagnoses.
6076 (gif_load): Fix pointer signedness.
6077 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6078 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6079
6080 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6081
6082 Improve quality of tests for time stamp overflow.
6083 For example, without this patch (encode-time 0 0 0 1 1
6084 1152921504606846976) returns the obviously-bogus value (-948597
6085 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6086 reports time overflow. See
6087 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6088 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6089 * editfns.c: Include limits.h and intprops.h.
6090 (TIME_T_MIN, TIME_T_MAX): New macros.
6091 (time_overflow): Move earlier, to before first use.
6092 (hi_time, lo_time): New functions, for an accurate test for
6093 out-of-range times.
6094 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6095 (Fget_internal_run_time): Don't assume time_t fits in int.
6096 (make_time): Use list2 instead of Fcons twice.
6097 (Fdecode_time): More accurate test for out-of-range times.
6098 (check_tm_member): New function.
6099 (Fencode_time): Use it, to test for out-of-range times.
6100 (lisp_time_argument): Don't rely on undefined left-shift and
6101 right-shift behavior when checking for time stamp overflow.
6102
6103 * editfns.c (time_overflow): New function, refactoring common code.
6104 (Fformat_time_string, Fdecode_time, Fencode_time):
6105 (Fcurrent_time_string): Use it.
6106
6107 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6108 * dired.c (make_time): Move to ...
6109 * editfns.c (make_time): ... here.
6110 * systime.h: Note the move.
6111
6112 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6113
6114 * fringe.c (update_window_fringes): Remove unused variables.
6115
6116 * unexmacosx.c (copy_data_segment): Also copy __got section.
6117 (Bug#8223)
6118
6119 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6120
6121 * termcap.c [MSDOS]: Include "msdos.h".
6122 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6123 Constify `char *' arguments and their references according to
6124 prototypes in tparam.h.
6125
6126 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6127
6128 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6129 Adapt all references accordingly.
6130
6131 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6132
6133 2011-03-11 Tom Tromey <tromey@redhat.com>
6134
6135 * buffer.c (syms_of_buffer): Remove obsolete comment.
6136
6137 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6138
6139 * termhooks.h (encode_terminal_code): Declare prototype.
6140
6141 * msdos.c (encode_terminal_code): Don't declare prototype.
6142
6143 * term.c (encode_terminal_code): Now external again, used by
6144 w32console.c and msdos.c.
6145
6146 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6147 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6148
6149 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6150
6151 Fix some minor problems found by GCC 4.5.2's static checks.
6152
6153 * fringe.c (update_window_fringes): Mark locals as initialized
6154 (Bug#8227).
6155 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6156
6157 * alloc.c (mark_fringe_data): Move decl from here ...
6158 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6159 to check its interface.
6160 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6161
6162 * fontset.c (free_realized_fontset): Now static.
6163 (Fset_fontset_font): Rename local to avoid shadowing.
6164 (fontset_font): Mark local as initialized.
6165 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6166
6167 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6168
6169 * xselect.c (x_disown_buffer_selections): Remove; not used.
6170 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6171 (x_own_selection, Fx_disown_selection_internal): Rename locals
6172 to avoid shadowing.
6173 (x_handle_dnd_message): Remove local to avoid shadowing.
6174
6175 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6176 so that the caller can use some name other than gcpro1.
6177 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6178 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6179 (Fx_backspace_delete_keys_p):
6180 Use them to avoid shadowing, and rename vars to avoid shadowing.
6181 (x_decode_color, x_set_name, x_window): Now static.
6182 (Fx_create_frame): Add braces to silence GCC warning.
6183 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6184 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6185 Remove unused locals.
6186 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6187 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6188 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6189 macros.
6190
6191 * xterm.h (x_mouse_leave): New decl.
6192
6193 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6194 Remove unused functions.
6195 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6196 (x_calc_absolute_position): Now static.
6197 (XTread_socket): Don't define label "out" unless it's used.
6198 Don't declare local "event" unless it's used.
6199 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6200 unless they are used.
6201 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6202 (x_fatal_error_signal): Remove; not used.
6203 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6204 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6205 (x_error_catcher, x_connection_closed, x_error_handler):
6206 (x_error_quitter, xembed_send_message, x_iconify_frame):
6207 (my_log_handler): Rename locals to avoid shadowing.
6208 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6209 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6210
6211 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6212 Rename or move locals to avoid shadowing.
6213 (tty_defined_color, merge_face_heights): Now static.
6214 (free_realized_faces_for_fontset): Remove; not used.
6215 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6216 does not deduce is never used uninitialized.
6217 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6218 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6219
6220 * terminal.c (store_terminal_param): Now static.
6221
6222 * xmenu.c (menu_highlight_callback): Now static.
6223 (set_frame_menubar): Remove unused local.
6224 (xmenu_show): Rename parameter to avoid shadowing.
6225 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6226 since they might point to immutable storage.
6227 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6228 since it's unused otherwise.
6229
6230 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6231 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6232 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6233 avoids a gcc -Wuninitialized diagnostic.
6234 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6235 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6236 does not deduce are never used uninitialized.
6237
6238 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6239
6240 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6241 * window.c (window_loop, size_window):
6242 (run_window_configuration_change_hook, enlarge_window): Likewise.
6243
6244 * window.c (display_buffer): Now static.
6245 (size_window): Mark variables that gcc -Wuninitialized
6246 does not deduce are never used uninitialized.
6247 * window.h (check_all_windows): New decl, to forestall
6248 gcc -Wmissing-prototypes diagnostic.
6249 * dispextern.h (bidi_dump_cached_states): Likewise.
6250
6251 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6252 shadowing.
6253 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6254 Include <limits.h>.
6255 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6256 and to avoid gcc -Wuninitialized warning.
6257 (load_charset_map): Mark variables that gcc -Wuninitialized
6258 does not deduce are never used uninitialized.
6259 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6260
6261 * coding.c (coding_set_source, coding_set_destination):
6262 Use "else { /* comment */ }" rather than "else /* comment */;"
6263 for clarity, and to avoid gcc -Wempty-body warning.
6264 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6265 a block, when the outer 'i' will do.
6266 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6267 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6268 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6269 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6270 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6271 Rename locals to avoid shadowing.
6272 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6273 * coding.c (emacs_mule_char, encode_invocation_designation):
6274 Now static, since they're not used elsewhere.
6275 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6276 (decode_coding_object, encode_coding_object, detect_coding_system):
6277 (decode_coding_emacs_mule): Mark variables that gcc
6278 -Wuninitialized does not deduce are never used uninitialized.
6279 (detect_coding_iso_2022): Initialize a local variable that might
6280 be used uninitialized. Leave a FIXME because it's not clear that
6281 this initialization is needed. (Bug#8211)
6282 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6283 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6284 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6285 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6286 Remove unused macros.
6287
6288 * category.c (hash_get_category_set): Remove unused local var.
6289 (copy_category_table): Now static, since it's not used elsewhere.
6290 * character.c (string_count_byte8): Likewise.
6291
6292 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6293 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6294
6295 * chartab.c (copy_sub_char_table): Now static, since it's not used
6296 elsewhere.
6297 (sub_char_table_ref_and_range, char_table_ref_and_range):
6298 Rename locals to avoid shadowing.
6299 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6300
6301 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6302 (BIDI_BOB): Remove unused macro.
6303
6304 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6305 deduce are never used uninitialized.
6306 * term.c (encode_terminal_code): Likewise.
6307
6308 * term.c (encode_terminal_code): Now static. Remove unused local.
6309
6310 * tparam.h: New file.
6311 * term.c, tparam.h: Include it.
6312 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6313 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6314 Move these decls to tparam.h, and make them agree with what
6315 is actually in tparam.c. The previous trick of using incompatible
6316 decls in different modules does not conform to the C standard.
6317 All callers of tparam changed to use tparam's actual API.
6318 * tparam.c (tparam1, tparam, tgoto):
6319 Use const pointers where appropriate.
6320
6321 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6322 * cm.h (struct cm): Likewise.
6323 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6324 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6325 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6326 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6327 (turn_on_face, init_tty): Likewise.
6328 * termchar.h (struct tty_display_info): Likewise.
6329
6330 * term.c (term_mouse_position): Rename local to avoid shadowing.
6331
6332 * alloc.c (mark_ttys): Move decl from here ...
6333 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6334
6335 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6336
6337 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6338
6339 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6340
6341 * search.c (compile_pattern_1): Remove argument regp, unused since
6342 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6343 (compile_pattern): Don't pass it.
6344
6345 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6346
6347 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6348 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6349 for ! HAVE_GTK3.
6350 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6351
6352 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6353
6354 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6355 gdk_window_get_screen, gdk_window_get_geometry,
6356 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6357 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6358 (xg_get_pixbuf_from_pixmap): New function.
6359 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6360 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6361 Call xg_get_pixbuf_from_pixmap instead of
6362 gdk_pixbuf_get_from_drawable.
6363 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6364 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6365 (xg_check_special_colors): Use GtkStyleContext and its functions
6366 for HAVE_GTK3.
6367 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6368 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6369 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6370 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6371 Call gtk_widget_get_preferred_size.
6372 (xg_frame_resized): gdk_window_get_geometry only takes 5
6373 parameters.
6374 (xg_win_to_widget, xg_event_is_for_menubar):
6375 Call gdk_x11_window_lookup_for_display.
6376 (xg_set_widget_bg): New function.
6377 (delete_cb): New function.
6378 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6379 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6380 (xg_set_background_color): Call xg_set_widget_bg.
6381 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6382 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6383 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6384 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6385 if ! HAVE_GTK3.
6386 (update_frame_tool_bar): Call gtk_widget_hide.
6387 (xg_initialize): Use GDK_KEY_g.
6388
6389 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6390 if ! HAVE_GTK3
6391 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6392
6393 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6394 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6395 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6396
6397 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6398
6399 * w32xfns.c (select_palette): Check success of RealizePalette against
6400 GDI_ERROR, not zero.
6401
6402 See ChangeLog.11 for earlier changes.
6403
6404 ;; Local Variables:
6405 ;; coding: utf-8
6406 ;; End:
6407
6408 Copyright (C) 2011 Free Software Foundation, Inc.
6409
6410 This file is part of GNU Emacs.
6411
6412 GNU Emacs is free software: you can redistribute it and/or modify
6413 it under the terms of the GNU General Public License as published by
6414 the Free Software Foundation, either version 3 of the License, or
6415 (at your option) any later version.
6416
6417 GNU Emacs is distributed in the hope that it will be useful,
6418 but WITHOUT ANY WARRANTY; without even the implied warranty of
6419 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6420 GNU General Public License for more details.
6421
6422 You should have received a copy of the GNU General Public License
6423 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.