]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from trunk.
[gnu-emacs] / src / ChangeLog
1 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4 not to EMACS_INT, to avoid GCC warning.
5
6 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7
8 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10 isn't needed on 32-bit machines.
11
12 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
13 (advance_to_char_boundary): Return EMACS_INT, not int.
14
15 * data.c (Qcompiled_function): Now static.
16
17 * window.c (window_body_lines): Now static.
18
19 * image.c (gif_load): Rename local to avoid shadowing.
20
21 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
22 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
23 * alloc.c (make_save_value): Integer argument is now of type
24 ptrdiff_t, not int.
25 (mark_object): Use ptrdiff_t, not int.
26 * lisp.h (pD): New macro.
27 * print.c (print_object): Use it.
28
29 * alloc.c: Use EMACS_INT, not int, to count objects.
30 (total_conses, total_markers, total_symbols, total_vector_size)
31 (total_free_conses, total_free_markers, total_free_symbols)
32 (total_free_floats, total_floats, total_free_intervals, total_intervals)
33 (total_strings, total_free_strings):
34 Now EMACS_INT, not int. All uses changed.
35 (Fgarbage_collect): Compute overall total using a double, so that
36 integer overflow is less likely to be a problem. Check for overflow
37 when converting back to an integer.
38 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
39 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
40 These were 'int' variables that could overflow on 64-bit hosts;
41 they were never used, so remove them instead of repairing them.
42 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
43 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
44 Previously, this ceilinged at INT_MAX, but that doesn't work on
45 64-bit machines.
46 (allocate_pseudovector): Don't use EMACS_INT when int would do.
47
48 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
49 (allocate_vectorlike): Check for ptrdiff_t overflow.
50 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
51 when a (possibly-narrower) signed value would do just as well.
52 We prefer using signed arithmetic, to avoid comparison confusion.
53
54 * alloc.c: Catch some string size overflows that we were missing.
55 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
56 for convenience in STRING_BYTES_MAX.
57 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
58 The definition here is exact; the one in lisp.h was approximate.
59 (allocate_string_data): Check for string overflow. This catches
60 some instances we weren't catching before. Also, it catches
61 size_t overflow on (unusual) hosts where SIZE_MAX <= min
62 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
63 and ptrdiff_t and EMACS_INT are both 64 bits.
64
65 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
66 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
67 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
68
69 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
70
71 * alloc.c (Fmake_string): Check for out-of-range init.
72
73 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
74
75 * image.c (gif_load): Fix omitted cast error introduced by
76 2011-06-06 change.
77
78 2011-06-10 Martin Rudalics <rudalics@gmx.at>
79
80 * window.h (resize_proportionally, orig_total_lines)
81 (orig_top_line): Remove from window structure.
82 (set_window_height, set_window_width, change_window_heights)
83 (Fdelete_window): Remove prototypes.
84 (resize_frame_windows): Remove duplicate declaration.
85
86 2011-06-10 Eli Zaretskii <eliz@gnu.org>
87
88 * window.h (resize_frame_windows, resize_window_check)
89 (delete_deletable_window, resize_root_window)
90 (resize_frame_windows): Declare prototypes.
91
92 * window.c (resize_window_apply): Make definition be "static" to
93 match the prototype.
94
95 2011-06-10 Martin Rudalics <rudalics@gmx.at>
96
97 * window.c: Remove declarations of Qwindow_size_fixed,
98 window_min_size_1, window_min_size_2, window_min_size,
99 size_window, window_fixed_size_p, enlarge_window, delete_window.
100 Remove static from declaration of Qdelete_window, it's
101 temporarily needed by Fbury_buffer.
102 (replace_window): Don't assign orig_top_line and
103 orig_total_lines.
104 (Fdelete_window, delete_window): Remove. Window deletion is
105 handled by window.el.
106 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
107 Fdelete_window calls with calls to Qdelete_window.
108 (Fdelete_other_windows): Remove. Deleting other windows is
109 handled by window.el.
110 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
111 handled in window.el.
112 (window_min_size_2, window_min_size_1, window_min_size): Remove.
113 Window minimum sizes are handled in window.el.
114 (shrink_windows, size_window, set_window_height)
115 (set_window_width, change_window_heights, window_height)
116 (window_width, CURBEG, CURSIZE, enlarge_window)
117 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
118 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
119 handled in window.el.
120 (make_dummy_parent): Rename to make_parent_window and give it a
121 second argument horflag.
122 (make_window): Don't set resize_proportionally any more.
123 (Fsplit_window): Remove. Windows are split in window.el.
124 (save_restore_action, save_restore_orig_size)
125 (shrink_window_lowest_first, save_restore_orig_size): Remove.
126 Resize mini windows in window.el.
127 (grow_mini_window, shrink_mini_window): Implement by calling
128 Qresize_root_window_vertically, resize_window_check and
129 resize_window_apply.
130 (saved_window, Fset_window_configuration, save_window_save): Do
131 not handle orig_top_line, orig_total_lines, and
132 resize_proportionally.
133 (window_min_height, window_min_width): Move to window.el.
134 (keys_of_window): Move bindings for delete-other-windows,
135 split-window, delete-window and enlarge-window to window.el.
136
137 * buffer.c: Temporarily extern Qdelete_window.
138 (Fbury_buffer): Temporarily call Qdelete_window instead of
139 Fdelete_window (Fbury_buffer will move to window.el soon).
140
141 * frame.c (set_menu_bar_lines_1): Remove code handling
142 orig_top_line and orig_total_lines.
143
144 * dispnew.c (adjust_frame_glyphs_initially): Don't use
145 set_window_height but set heights directly.
146 (change_frame_size_1): Use resize_frame_windows.
147
148 * xdisp.c (init_xdisp): Don't use set_window_height but set
149 heights directly.
150
151 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
152 resize_frame_windows instead of change_window_heights and run
153 run_window_configuration_change_hook.
154
155 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
156 instead of change_window_heights and run
157 run_window_configuration_change_hook.
158
159 2011-06-09 Martin Rudalics <rudalics@gmx.at>
160
161 * window.c (replace_window): Rename second argument REPLACEMENT to
162 NEW. New third argument SETFLAG. Rewrite.
163 (delete_window, make_dummy_parent): Call replace_window with
164 third argument 1.
165 (window_list_1): Move down in code.
166 (run_window_configuration_change_hook): Move set_buffer part
167 before select_frame_norecord part in order to unwind correctly.
168 Rename count1 to count.
169 (recombine_windows, delete_deletable_window, resize_root_window)
170 (Fdelete_other_windows_internal)
171 (Frun_window_configuration_change_hook, make_parent_window)
172 (resize_window_check, resize_window_apply, Fresize_window_apply)
173 (resize_frame_windows, Fsplit_window_internal)
174 (Fdelete_window_internal, Fresize_mini_window_internal): New
175 functions.
176 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
177
178 2011-06-08 Martin Rudalics <rudalics@gmx.at>
179
180 * window.h (window): Add some new members to window structure -
181 normal_lines, normal_cols, new_total, new_normal, clone_number,
182 splits, nest, prev_buffers, next_buffers.
183 (WINDOW_TOTAL_SIZE): Move here from window.c.
184 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
185
186 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
187 Remove.
188 (make_dummy_parent): Set new members of windows structure.
189 (make_window): Move down in code. Handle new members of window
190 structure.
191 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
192 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
193 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
194 (Fset_window_prev_buffers, Fwindow_next_buffers)
195 (Fset_window_next_buffers, Fset_window_clone_number): New
196 functions.
197 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
198 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
199 Doc-string fixes.
200 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
201 Argument WINDOW can be now internal window too.
202 (Fwindow_use_time): Move up in code.
203 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
204 Rewrite doc-string.
205 (Fset_window_configuration, saved_window)
206 (Fcurrent_window_configuration, save_window_save): Handle new
207 members of window structure.
208 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
209 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
210 (syms_of_window): New Lisp objects Qrecord_window_buffer,
211 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
212 Qget_mru_window, Qresize_root_window,
213 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
214 Qauto_buffer_name; staticpro them.
215
216 2011-06-07 Martin Rudalics <rudalics@gmx.at>
217
218 * window.c (Fwindow_total_size, Fwindow_left_column)
219 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
220 (Fwindow_list_1): New functions.
221 (window_box_text_cols): Replace with window_body_cols.
222 (Fwindow_width, Fscroll_left, Fscroll_right): Use
223 window_body_cols instead of window_box_text_cols.
224 (delete_window, Fset_window_configuration): Call
225 delete_all_subwindows with window as argument.
226 (delete_all_subwindows): Take a window as argument and not a
227 structure. Rewrite.
228 (window_loop): Remove handling of GET_LRU_WINDOW and
229 GET_LARGEST_WINDOW.
230 (Fget_lru_window, Fget_largest_window): Move to window.el.
231
232 * window.h: Extern window_body_cols instead of
233 window_box_text_cols. delete_all_subwindows now takes a
234 Lisp_Object as argument.
235
236 * indent.c (compute_motion, Fcompute_motion): Use
237 window_body_cols instead of window_box_text_cols.
238
239 * frame.c (delete_frame): Call delete_all_subwindows with root
240 window as argument.
241
242 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
243
244 * fns.c (Fputhash): Document return value.
245
246 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
247
248 * image.c (gif_load): Implement gif89a spec "no disposal" method.
249
250 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
251
252 Cons<->int and similar integer overflow fixes (Bug#8794).
253
254 Check for overflow when converting integer to cons and back.
255 * charset.c (Fdefine_charset_internal, Fdecode_char):
256 Use cons_to_unsigned to catch overflow.
257 (Fencode_char): Use INTEGER_TO_CONS.
258 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
259 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
260 * data.c (long_to_cons, cons_to_long): Remove.
261 (cons_to_unsigned, cons_to_signed): New functions.
262 These signal an error for invalid or out-of-range values.
263 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
264 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
265 * font.c (Ffont_variation_glyphs):
266 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
267 * lisp.h: Include <intprops.h>.
268 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
269 (cons_to_signed, cons_to_unsigned): New decls.
270 (long_to_cons, cons_to_long): Remove decls.
271 * undo.c (record_first_change): Use INTEGER_TO_CONS.
272 (Fprimitive_undo): Use CONS_TO_INTEGER.
273 * xfns.c (Fx_window_property): Likewise.
274 * xselect.c: Include <limits.h>.
275 (x_own_selection, selection_data_to_lisp_data):
276 Use INTEGER_TO_CONS.
277 (x_handle_selection_request, x_handle_selection_clear)
278 (x_get_foreign_selection, Fx_disown_selection_internal)
279 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
280 (lisp_data_to_selection_data): Use cons_to_unsigned.
281 (x_fill_property_data): Use cons_to_signed.
282 Report values out of range.
283
284 Check for buffer and string overflow more precisely.
285 * buffer.h (BUF_BYTES_MAX): New macro.
286 * lisp.h (STRING_BYTES_MAX): New macro.
287 * alloc.c (Fmake_string):
288 * character.c (string_escape_byte8):
289 * coding.c (coding_alloc_by_realloc):
290 * doprnt.c (doprnt):
291 * editfns.c (Fformat):
292 * eval.c (verror):
293 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
294 since they may not be the same number.
295 * editfns.c (Finsert_char):
296 * fileio.c (Finsert_file_contents):
297 Likewise for BUF_BYTES_MAX.
298
299 * image.c: Use ptrdiff_t, not int, for sizes.
300 (slurp_file): Switch from int to ptrdiff_t.
301 All uses changed.
302 (slurp_file): Check that file size fits in both size_t (for
303 malloc) and ptrdiff_t (for sanity and safety).
304
305 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
306 if b->modtime has its maximal value.
307
308 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
309
310 Don't assume time_t can fit into int.
311 * buffer.h (struct buffer.modtime): Now time_t, not int.
312 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
313 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
314
315 Minor fixes for signed vs unsigned integers.
316 * character.h (MAYBE_UNIFY_CHAR):
317 * charset.c (maybe_unify_char):
318 * keyboard.c (read_char, reorder_modifiers):
319 XINT -> XFASTINT, since the integer must be nonnegative.
320 * ftfont.c (ftfont_spec_pattern):
321 * keymap.c (access_keymap, silly_event_symbol_error):
322 XUINT -> XFASTINT, since the integer must be nonnegative.
323 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
324 since it makes no difference and we prefer signed.
325 * keyboard.c (record_char): Use XUINT when all the neighbors do.
326 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
327 nonnegative.
328
329 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
330
331 * window.h (Fwindow_frame): Declare.
332
333 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
334
335 * alloc.c: Simplify handling of large-request failures (Bug#8800).
336 (SPARE_MEMORY): Always define.
337 (LARGE_REQUEST): Remove.
338 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
339
340 2011-06-06 Martin Rudalics <rudalics@gmx.at>
341
342 * lisp.h: Move EXFUNS for Fframe_root_window,
343 Fframe_first_window and Fset_frame_selected_window to window.h.
344
345 * window.h: Move EXFUNS for Fframe_root_window,
346 Fframe_first_window and Fset_frame_selected_window here from
347 lisp.h.
348
349 * frame.c (Fwindow_frame, Fframe_first_window)
350 (Fframe_root_window, Fframe_selected_window)
351 (Fset_frame_selected_window): Move to window.c.
352 (Factive_minibuffer_window): Move to minibuf.c.
353 (Fother_visible_frames_p): New function.
354
355 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
356
357 * window.c (decode_window, decode_any_window): Move up in code.
358 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
359 (inhibit_frame_unsplittable): Remove unused variable.
360 (Fwindow_buffer): Move up and rewrite doc-string.
361 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
362 (Fwindow_prev): New functions.
363 (Fwindow_frame): Move here from frame.c. Accept any window as
364 argument.
365 (Fframe_root_window, Fframe_first_window)
366 (Fframe_selected_window): Move here from frame.c. Accept frame
367 or arbitrary window as argument. Update doc-strings.
368 (Fminibuffer_window): Move up in code.
369 (Fwindow_minibuffer_p): Move up in code and simplify.
370 (Fset_frame_selected_window): Move here from frame.c.
371 Marginal rewrite.
372 (Fselected_window, select_window, Fselect_window): Move up in
373 code. Minor doc-string fixes.
374
375 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
376
377 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
378 Do not assume that spare memory exists; that assumption is valid
379 only if SYSTEM_MALLOC.
380 (LARGE_REQUEST): New macro, so that the issue of large requests
381 is separated from the issue of spare memory.
382
383 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
384
385 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
386 format. (Bug#8806)
387
388 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
389
390 * xfns.c (x_set_scroll_bar_default_width): Move declarations
391 before statements.
392
393 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
394
395 * gtkutil.c (xg_get_default_scrollbar_width): New function.
396
397 * gtkutil.h: Declare xg_get_default_scrollbar_width.
398
399 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
400 min width by calling x_set_scroll_bar_default_width (Bug#8505).
401
402 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
403
404 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
405
406 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
407
408 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
409 (x_clipboard_manager_save): Add return value.
410 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
411 New error handlers.
412 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
413 Obey Vx_select_enable_clipboard_manager. Catch errors in
414 x_clipboard_manager_save (Bug#8779).
415 (Vx_select_enable_clipboard_manager): New variable.
416 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
417
418 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
419
420 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
421
422 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
423
424 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
425 in the current matrix if keep_current_p is non-zero.
426
427 2011-06-04 Eli Zaretskii <eliz@gnu.org>
428
429 * bidi.c (bidi_level_of_next_char): Fix last change.
430
431 2011-06-03 Eli Zaretskii <eliz@gnu.org>
432
433 Support bidi reordering of text covered by display properties.
434
435 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
436 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
437 (bidi_cache_search, bidi_cache_iterator_state)
438 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
439 (bidi_level_of_next_char, bidi_move_to_visually_next):
440 Support character positions inside a run of characters covered by a
441 display string.
442 (bidi_paragraph_init, bidi_resolve_explicit_1)
443 (bidi_level_of_next_char): Call bidi_fetch_char and
444 bidi_fetch_char_advance instead of FETCH_CHAR and
445 FETCH_CHAR_ADVANCE.
446 (bidi_init_it): Initialize new members.
447 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
448 definitions.
449 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
450 instead of using explicit *_CHAR codes.
451 (bidi_resolve_explicit, bidi_resolve_weak):
452 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
453 bidirectional text is supported only in multibyte buffers.
454 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
455 it to initialize the frame_window_p member of struct bidi_it.
456 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
457 (bidi_resolve_explicit, bidi_resolve_weak)
458 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
459 bidi_it->nchars is non-positive.
460 (bidi_level_of_next_char): Don't try to lookup the cache for the
461 next/previous character if nothing is cached there yet, or if we
462 were just reseat()'ed to a new position.
463
464 * xdisp.c (set_cursor_from_row): Set start and stop points
465 according to the row's direction when priming the loop that looks
466 for the glyph on which to display cursor.
467 (single_display_spec_intangible_p): Function deleted.
468 (display_prop_intangible_p): Reimplement to call
469 handle_display_spec instead of single_display_spec_intangible_p.
470 Accept 3 additional arguments needed by handle_display_spec.
471 This fixes incorrect cursor motion across display property with complex
472 values: lists, `(when COND...)' forms, etc.
473 (single_display_spec_string_p): Support property values that are
474 lists with the argument STRING its top-level element.
475 (display_prop_string_p): Fix the condition for processing a
476 property that is a list to be consistent with handle_display_spec.
477 (handle_display_spec): New function, refactored from the
478 last portion of handle_display_prop.
479 (compute_display_string_pos): Accept additional argument
480 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
481 value of a `display' property is a "replacing spec".
482 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
483 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
484 the display property, but just return a value indicating whether
485 the display property will replace the characters it covers.
486 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
487 frame_window_p members of struct bidi_it.
488 (compute_display_string_pos, compute_display_string_end):
489 New functions.
490 (push_it): Accept second argument POSITION, where pop_it should
491 jump to continue iteration.
492 (reseat_1): Initialize bidi_it.disp_pos.
493
494 * keyboard.c (adjust_point_for_property): Adjust the call to
495 display_prop_intangible_p to its new signature.
496
497 * dispextern.h (struct bidi_it): New member frame_window_p.
498 (bidi_init_it): Update prototypes.
499 (display_prop_intangible_p): Update prototype.
500 (compute_display_string_pos, compute_display_string_end):
501 Declare prototypes.
502 (struct bidi_it): New members nchars and disp_pos. ch_len is now
503 EMACS_INT.
504
505 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
506
507 Malloc failure behavior now depends on size of allocation.
508 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
509 * lisp.h: Change signatures accordingly.
510 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
511 All callers changed. (Bug#8762)
512
513 * gnutls.c: Use Emacs's memory allocators.
514 Without this change, the gnutls library would invoke malloc etc.
515 directly, which causes problems on non-SYNC_INPUT hosts, and which
516 runs afoul of improving memory_full behavior. (Bug#8761)
517 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
518 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
519 xfree instead of the default malloc, realloc, free.
520 (Fgnutls_boot): No need to check for memory allocation failure,
521 since xmalloc does that for us.
522
523 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
524 * category.c (hash_get_category_set):
525 * ccl.c (ccl_driver):
526 * charset.c (Fdefine_charset_internal):
527 * charset.h (struct charset.hash_index):
528 * composite.c (get_composition_id, gstring_lookup_cache)
529 (composition_gstring_put_cache):
530 * composite.h (struct composition.hash_index):
531 * dispextern.h (struct image.hash):
532 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
533 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
534 (hashfn_equal, hashfn_user_defined, make_hash_table)
535 (maybe_resize_hash_table, hash_lookup, hash_put)
536 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
537 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
538 (Fsxhash, Fgethash, Fputhash, Fmaphash):
539 * image.c (make_image, search_image_cache, lookup_image)
540 (xpm_put_color_table_h):
541 * lisp.h (struct Lisp_Hash_Table):
542 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
543 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
544 for hashes and hash indexes, instead of 'unsigned' and 'int'.
545 * alloc.c (allocate_vectorlike):
546 Check for overflow in vector size calculations.
547 * ccl.c (ccl_driver):
548 Check for overflow when converting EMACS_INT to int.
549 * fns.c, image.c: Remove unnecessary static decls that would otherwise
550 need to be updated by these changes.
551 * fns.c (make_hash_table, maybe_resize_hash_table):
552 Check for integer overflow with large hash tables.
553 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
554 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
555 (SXHASH_REDUCE): New macro.
556 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
557 Use it instead of discarding useful hash info with large hash values.
558 (sxhash_float): New function.
559 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
560 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
561 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
562 Rewrite to use FIXNUM_BITS, as this simplifies things.
563 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
564 Adjust signatures to match updated version of code.
565 (consing_since_gc): Now EMACS_INT, since a single hash table can
566 use more than INT_MAX bytes.
567
568 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
569
570 Make it possible to build with GCC-4.6+ -O2 -flto.
571
572 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
573
574 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
575
576 * minibuf.c (get_minibuffer, read_minibuf_unwind):
577 Call minibuffer-inactive-mode.
578
579 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
580
581 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
582 Update dependencies.
583
584 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
585
586 * data.c (init_data): Remove code for UTS, this system is not
587 supported anymore.
588
589 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
590
591 Don't force ./temacs to start in terminal mode.
592
593 * frame.c (make_initial_frame): Initialize faces in all cases, not
594 only when CANNOT_DUMP is defined.
595 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
596
597 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
598
599 * dispnew.c (add_window_display_history): Use const for the string
600 pointer. Remove declaration, not needed.
601
602 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
603
604 Use 'inline', not 'INLINE'.
605 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
606 * alloc.c, fontset.c (INLINE): Remove.
607 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
608 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
609 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
610 * gmalloc.c (register_heapinfo): Use inline unconditionally.
611 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
612
613 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
614
615 Make it possible to run ./temacs.
616
617 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
618 syms_of_callproc does the same thing. Remove test for
619 "initialized", do it in the caller.
620 * emacs.c (main): Avoid calling set_initial_environment when dumping.
621
622 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
623
624 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
625 (read_minibuf): Use get_minibuffer.
626 (syms_of_minibuf): Use DEFSYM.
627 (Qmetadata): New var.
628 * data.c (Qbuffer): Don't make it static.
629 (syms_of_data): Use DEFSYM.
630
631 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
632
633 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
634 (CCL_CODE_MIN): New macro.
635
636 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
637
638 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
639
640 * eval.c (Qdebug): Now static.
641 * lisp.h (Qdebug): Remove decl. This reverts a part of the
642 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
643 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
644
645 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
646
647 * image.c: Various fixes to ImageMagick code comments.
648 (Fimagemagick_types): Doc fix.
649
650 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
651
652 Minor fixes prompted by GCC 4.6.0 warnings.
653
654 * xselect.c (converted_selections, conversion_fail_tag): Now static.
655
656 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
657 (x_clipboard_manager_save_all): Move extern decl to ...
658 * xterm.h: ... here, so that it can be checked for consistency.
659
660 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
661
662 * xselect.c (x_clipboard_manager_save_frame)
663 (x_clipboard_manager_save_all): New functions.
664 (Fx_clipboard_manager_save): Lisp function deleted.
665
666 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
667 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
668
669 * xterm.h: Update prototype.
670
671 2011-05-28 William Xu <william.xwl@gmail.com>
672
673 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
674 exiting (Bug#8239).
675
676 2011-05-28 Jim Meyering <meyering@redhat.com>
677
678 Avoid a sign-extension bug in crypto_hash_function.
679 * fns.c (to_uchar): Define.
680 (crypto_hash_function): Use it to convert some newly-signed
681 variables to unsigned, to avoid sign-extension bugs. For example,
682 without this change, (md5 "truc") would evaluate to
683 45723a2aff78ff4fff7fff1114760e62 rather than the expected
684 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
685 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
686
687 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
688
689 Integer overflow fixes.
690
691 * dbusbind.c: Serial number integer overflow fixes.
692 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
693 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
694 to hold a serial number that is too large for a fixnum.
695 (Fdbus_method_return_internal, Fdbus_method_error_internal):
696 Check for serial numbers out of range. Decode any serial number
697 that was so large that it became a float. (Bug#8722)
698
699 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
700 (Fdbus_call_method, Fdbus_call_method_asynchronously):
701 Use XFASTINT rather than XUINT when numbers are nonnegative.
702 (xd_append_arg, Fdbus_method_return_internal):
703 (Fdbus_method_error_internal): Likewise. Also, for unsigned
704 arguments, check that Lisp number is nonnegative, rather than
705 silently wrapping negative numbers around. (Bug#8722)
706 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
707 (Bug#8722)
708
709 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
710
711 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
712
713 ccl: add integer overflow checks
714 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
715 (IN_INT_RANGE): New macros.
716 (ccl_driver): Use them to check for integer overflow when
717 decoding a CCL program. Many of the new checks are whether XINT (x)
718 fits in int; it doesn't always, on 64-bit hosts. The new version
719 doesn't catch all possible integer overflows, but it's an
720 improvement. (Bug#8719)
721
722 * alloc.c (make_event_array): Use XINT, not XUINT.
723 There's no need for unsigned here.
724
725 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
726 This follows up to the 2011-05-06 change that substituted uintptr_t
727 for EMACS_INT. This case wasn't caught back then.
728
729 Rework Fformat to avoid integer overflow issues.
730 * editfns.c: Include <float.h> unconditionally, as it's everywhere
731 now (part of C89). Include <verify.h>.
732 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
733 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
734 (Fformat): Avoid the prepass trying to compute sizes; it was only
735 approximate and thus did not catch overflow reliably. Instead, walk
736 through the format just once, formatting and computing sizes as we go,
737 checking for integer overflow at every step, and allocating a larger
738 buffer as needed. Keep track separately whether the format is
739 multibyte. Keep only the most-recently calculated precision, rather
740 than them all. Record whether each argument has been converted to
741 string. Use EMACS_INT, not int, for byte and char and arg counts.
742 Support field widths and precisions larger than INT_MAX. Avoid
743 sprintf's undefined behavior with conversion specifications such as %#d
744 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
745 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
746 formatting out-of-range floating point numbers with int
747 formats. (Bug#8668)
748
749 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
750
751 * data.c: Avoid integer truncation in expressions involving floats.
752 * data.c: Include <intprops.h>.
753 (arith_driver): When there's an integer overflow in an expression
754 involving floating point, convert the integers to floating point
755 so that the resulting value does not suffer from catastrophic
756 integer truncation. For example, on a 64-bit host (* 4
757 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
758 Do not rely on undefined behavior after integer overflow.
759
760 merge count_size_as_multibyte, parse_str_to_multibyte
761 * character.c, character.h (count_size_as_multibyte):
762 Rename from parse_str_to_multibyte; all uses changed.
763 Check for integer overflow.
764 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
765 since it's now a duplicate of the other. This is more of
766 a character than a buffer op, so better that it's in character.c.
767 * fns.c, print.c: Adjust to above changes.
768
769 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
770
771 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
772
773 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
774
775 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
776 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
777 (x_clipboard_manager_save): Now static.
778 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
779
780 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
781 (crypto_hash_function): Now static.
782 Fix pointer signedness problems. Avoid unnecessary initializations.
783
784 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
785
786 * termhooks.h (Vselection_alist): Make it terminal-local.
787
788 * terminal.c (create_terminal): Initialize it.
789
790 * xselect.c: Support for clipboard managers.
791 (Vselection_alist): Move to termhooks.h as terminal-local var.
792 (LOCAL_SELECTION): New macro.
793 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
794 (symbol_to_x_atom): Remove gratuitous arg.
795 (x_handle_selection_request, lisp_data_to_selection_data)
796 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
797 (x_own_selection, x_get_local_selection, x_convert_selection):
798 New arg, specifying work frame. Use terminal-local Vselection_alist.
799 (some_frame_on_display): Delete unused function.
800 (Fx_own_selection_internal, Fx_get_selection_internal)
801 (Fx_disown_selection_internal, Fx_selection_owner_p)
802 (Fx_selection_exists_p): New optional frame arg.
803 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
804 (x_handle_selection_clear): Don't treat other terminals with the
805 same keyboard specially. Use the terminal-local Vselection_alist.
806 (x_clear_frame_selections): Use Frun_hook_with_args.
807
808 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
809
810 * xterm.h: Add support for those atoms.
811
812 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
813
814 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
815 (converted_selections, conversion_fail_tag): New global variables.
816 (x_selection_request_lisp_error): Free the above.
817 (x_get_local_selection): Remove unnecessary code.
818 (x_reply_selection_request): Args changed; handle arbitrary array
819 of converted selections stored in converted_selections.
820 Separate the XChangeProperty and SelectionNotify steps.
821 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
822 (x_convert_selection): New function.
823 (x_handle_selection_event): Simplify.
824 (x_get_foreign_selection): Don't ignore incoming requests while
825 waiting for an answer; this will fail when we implement
826 SAVE_TARGETS, and seems unnecessary anyway.
827 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
828 (Vx_sent_selection_functions): Doc fix.
829
830 2011-05-26 Leo Liu <sdl.web@gmail.com>
831
832 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
833
834 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
835
836 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
837
838 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
839 for fringe update if it has periodic bitmap.
840 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
841 and fringe_bitmap_periodic_p.
842
843 * fringe.c (get_fringe_bitmap_data): New function.
844 (draw_fringe_bitmap_1, update_window_fringes): Use it.
845 (update_window_fringes): Record periodicity of fringe bitmap in glyph
846 row. Mark glyph row for fringe update if periodicity changed.
847
848 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
849 for fringe update unless it has periodic bitmap.
850
851 2011-05-25 Kenichi Handa <handa@m17n.org>
852
853 * xdisp.c (get_next_display_element): Set correct it->face_id for
854 a static composition.
855
856 2011-05-24 Leo Liu <sdl.web@gmail.com>
857
858 * deps.mk (fns.o):
859 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
860
861 * fns.c (crypto_hash_function, Fsha1): New function.
862 (Fmd5): Use crypto_hash_function.
863 (syms_of_fns): Add Ssha1.
864
865 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
866
867 * gnutls.c: Remove unused macros.
868 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
869 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
870 Remove macros that are defined and never used.
871 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
872
873 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
874
875 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
876 (Fx_get_selection_internal): Minor cleanup.
877 (Fx_own_selection_internal): Rename arguments for consistency with
878 select.el.
879
880 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
881
882 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
883
884 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
885
886 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
887
888 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
889
890 * dispnew.c (scrolling_window): Don't exclude the case that the
891 last enabled row in the desired matrix touches the bottom boundary.
892
893 2011-05-21 Glenn Morris <rgm@gnu.org>
894
895 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
896 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
897 and add some more files.
898
899 2011-05-20 Eli Zaretskii <eliz@gnu.org>
900
901 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
902 report_file_error introduced by the change from 2011-05-07.
903
904 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
905
906 * systime.h (Time): Define only if emacs is defined.
907 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
908 where the include path doesn't have X11/X.h by default. See
909 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
910
911 2011-05-20 Kenichi Handa <handa@m17n.org>
912
913 * composite.c (find_automatic_composition): Fix previous change.
914
915 2011-05-20 Glenn Morris <rgm@gnu.org>
916
917 * lisp.mk: New file, split from Makefile.in.
918 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
919 (shortlisp): Remove.
920 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
921
922 2011-05-19 Glenn Morris <rgm@gnu.org>
923
924 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
925 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
926 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
927 (lisp): Set the order to that of loadup.el.
928 (shortlisp): Make it a copy of $lisp.
929 (SOME_MACHINE_LISP): Remove.
930 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
931 Use just $shortlisp, not $SOME_MACHINE_LISP too.
932
933 2011-05-18 Kenichi Handa <handa@m17n.org>
934
935 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
936 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
937 (find_automatic_composition): Mostly rewrite for efficiency.
938
939 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
940
941 * makefile.w32-in: Update dependencies.
942
943 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
944
945 * menu.c: Include limits.h (fixes the MS-Windows build broken by
946 revision 104625).
947
948 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
949
950 Fix some integer overflow issues, such as string length overflow.
951
952 * insdel.c (count_size_as_multibyte): Check for string overflow.
953
954 * character.c (lisp_string_width): Check for string overflow.
955 Use EMACS_INT, not int, for string indexes and lengths; in
956 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
957 the resulting string length overflows an EMACS_INT; instead,
958 report a string overflow if no precision given. When checking for
959 precision exhaustion, use a check that cannot possibly have
960 integer overflow. (Bug#8675)
961 * character.h (lisp_string_width): Adjust to new signature.
962
963 * alloc.c (string_overflow): New function.
964 (Fmake_string): Use it. This doesn't change behavior, but saves
965 a few bytes and will simplify future changes.
966 * character.c (string_escape_byte8): Likewise.
967 * lisp.h (string_overflow): New decl.
968
969 Fixups, following up to the user-interface timestamp change.
970 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
971 for UI timestamps, instead of unsigned long.
972 * msdos.c (mouse_get_pos): Likewise.
973 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
974 * w32gui.h (Time): Define by including "systime.h" rather than by
975 declaring it ourselves. (Bug#8664)
976
977 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
978 * image.c (clear_image_cache): Likewise.
979
980 * term.c (term_mouse_position): Don't assume time_t wraparound.
981
982 Be more systematic about user-interface timestamps.
983 Before, the code sometimes used 'Time', sometimes 'unsigned long',
984 and sometimes 'EMACS_UINT', to represent these timestamps.
985 This change causes it to use 'Time' uniformly, as that's what X uses.
986 This makes the code easier to follow, and makes it easier to catch
987 integer overflow bugs such as Bug#8664.
988 * frame.c (Fmouse_position, Fmouse_pixel_position):
989 Use Time, not unsigned long, for user-interface timestamps.
990 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
991 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
992 * keyboard.h (last_event_timestamp): Likewise.
993 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
994 * menu.h (xmenu_show): Likewise.
995 * term.c (term_mouse_position): Likewise.
996 * termhooks.h (struct input_event.timestamp): Likewise.
997 (struct terminal.mouse_position_hook): Likewise.
998 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
999 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1000 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1001 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1002 what it was before.
1003 * menu.h, termhooks.h: Include "systime.h", for Time.
1004
1005 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1006 Don't assume that the difference between two unsigned long values
1007 can fit into an integer. At this point, we know button_down_time
1008 <= event->timestamp, so the difference must be nonnegative, so
1009 there's no need to cast the result if double-click-time is
1010 nonnegative, as it should be; check that it's nonnegative, just in
1011 case. This bug is triggered when events are more than 2**31 ms
1012 apart (about 25 days). (Bug#8664)
1013
1014 * xselect.c (last_event_timestamp): Remove duplicate decl.
1015 (x_own_selection): Remove needless cast to unsigned long.
1016
1017 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1018 that always fit in int. Use a sentinel instead of a counter, to
1019 avoid a temp and to allay GCC's concerns about possible int overflow.
1020 * frame.h (struct frame): Use int for menu_bar_items_used
1021 instead of EMACS_INT, since it always fits in int.
1022
1023 * menu.c (grow_menu_items): Check for int overflow.
1024
1025 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1026
1027 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1028 Before, the code was not consistent. These values cannot exceed
1029 2**31 - 1 so there's no need to make them unsigned.
1030 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1031 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1032 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1033 as modifiers.
1034 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1035
1036 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1037 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1038 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1039 presumably because the widths might not match.
1040
1041 * window.c (size_window): Avoid needless test at loop start.
1042
1043 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1044
1045 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1046
1047 2011-05-12 Drew Adams <drew.adams@oracle.com>
1048
1049 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1050
1051 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1052
1053 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1054 `width' to `bar_area_x' and `bar_area_width', respectively.
1055 (x_scroll_run): Take account of fringe background extension.
1056
1057 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1058 Rename local vars `left' and `width' to `bar_area_x' and
1059 `bar_area_width', respectively.
1060 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1061 background extension.
1062
1063 2011-05-10 Jim Meyering <meyering@redhat.com>
1064
1065 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1066
1067 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1068
1069 * image.c (Finit_image_library): Return t for built-in image types,
1070 like pbm and xbm. (Bug#8640)
1071
1072 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1073
1074 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1075
1076 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1077
1078 * w32console.c (Fset_screen_color): Doc fix.
1079 (Fget_screen_color): New function.
1080 (syms_of_ntterm): Defsubr it.
1081
1082 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1083 unlink the temporary file if Fcall_process didn't create it in the
1084 first place.
1085 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1086 child process will be redirected to a file specified with `:file'.
1087 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1088 cue to call_process_cleanup not to close that handle.
1089
1090 2011-05-07 Ben Key <bkey76@gmail.com>
1091
1092 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1093 one of two shell specific rules, either bootstrap-temacs-CMD or
1094 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1095 to the previous implementation of the bootstrap-temacs rule.
1096 The bootstrap-temacs-CMD rule is similar to the previous
1097 implementation of the bootstrap-temacs rule except that it
1098 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1099 variable.
1100
1101 These changes, along with some changes to nt/configure.bat,
1102 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1103 earlier fix to add support for --cflags and --ldflags options
1104 that include quotes so that it works whether make uses cmd or
1105 sh as the shell.
1106
1107 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1108
1109 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1110 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1111 is a constant.
1112 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1113 a string. Handle both cases.
1114 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1115 (Fdbus_register_method): Use Qinvalid_function.
1116
1117 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1118
1119 * makefile.w32-in: Update dependencies.
1120 (LISP_H): Add inttypes.h and stdin.h.
1121 (PROCESS_H): Add unistd.h.
1122
1123 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1124
1125 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1126 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1127
1128 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1131
1132 * term.c (vfatal): Remove stray call to va_end.
1133 It's not needed and the C Standard doesn't allow it here anyway.
1134
1135 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1136 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1137
1138 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1139 bytes.
1140
1141 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1142
1143 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1144
1145 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1146
1147 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1148
1149 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1150
1151 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1152 * charset.c (Fdefine_charset_internal): Don't initialize
1153 charset.code_space[15]. The value was garbage, on hosts with
1154 32-bit int (Bug#8600).
1155
1156 * lread.c (read_integer): Be more consistent with string-to-number.
1157 Use string_to_number to do the actual conversion; this avoids
1158 rounding errors and fixes some other screwups. Without this fix,
1159 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1160 (digit_to_number): Move earlier, for benefit of read_integer.
1161 Return -1 if the digit is out of range for the base, -2 if it is
1162 not a digit in any supported base. (Bug#8602)
1163
1164 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1165
1166 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1167 to match comment at start of function. This also removes a
1168 GCC warning about overflow in a 32+64-bit port.
1169
1170 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1171
1172 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1173 Reported by Stefan Monnier in
1174 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1175 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1176 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1177
1178 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1179 (EMACS_UINTPTR): Likewise, with uintptr_t.
1180
1181 * lisp.h: Prefer 64-bit EMACS_INT if available.
1182 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1183 on 32-bit hosts that have 64-bit int, so that they can access
1184 large files.
1185 However, temporarily disable this change unless the temporary
1186 symbol WIDE_EMACS_INT is defined.
1187
1188 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1189
1190 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1191 This removes an assumption that EMACS_INT and long are the same
1192 width as pointers. The assumption is true for Emacs porting targets
1193 now, but we want to make other targets possible.
1194 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1195 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1196 In the rest of the code, change types of integers that hold casted
1197 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1198 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1199 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1200 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1201 No need to cast type when ORing.
1202 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1203 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1204 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1205 assume EMACS_INT is the same width as char *.
1206 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1207 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1208 Remove no-longer-needed casts.
1209 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1210 (xg_tool_bar_help_callback, xg_make_tool_item):
1211 Use EMACS_INTPTR to hold an integer
1212 that will be cast to void *; this can avoid a GCC warning
1213 if EMACS_INT is not the same width as void *.
1214 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1215 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1216 (current_message_1, set_message_1):
1217 Use a local to convert to proper width without a cast.
1218 * xmenu.c (dialog_selection_callback): Likewise.
1219
1220 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1221 Also, don't assume VALBITS / RAND_BITS is less than 5,
1222 and don't rely on undefined behavior when shifting a 1 left into
1223 the sign bit.
1224 * lisp.h (get_random): Change signature to match.
1225
1226 * lread.c (hash_string): Use size_t, not int, for hash computation.
1227 Normally we prefer signed values; but hashing is special, because
1228 it's better to use unsigned division on hash table sizes so that
1229 the remainder is nonnegative. Also, size_t is the natural width
1230 for hashing into memory. The previous code used 'int', which doesn't
1231 retain enough info to hash well into very large tables.
1232 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1233
1234 * dbusbind.c: Don't possibly lose pointer info when converting.
1235 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1236 Use XPNTR rather than XHASH, so that the high-order bits of
1237 the pointer aren't lost when converting through void *.
1238
1239 * eval.c (Fautoload): Don't double-shift a pointer.
1240
1241 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1242
1243 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1244
1245 * gnutls.c (DEF_GNUTLS_FN):
1246 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1247
1248 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1249
1250 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1251 marker. (Bug#8610)
1252
1253 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1254
1255 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1256 New version that can reserve upto 2GB of heap space.
1257
1258 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1259
1260 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1261
1262 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1263
1264 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1265 `gnutls_certificate_set_x509_key_file'.
1266
1267 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1268
1269 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1270 Update dependencies.
1271
1272 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1273
1274 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1275 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1276 Remove unused parameter `fildes'.
1277 * process.c (read_process_output, send_process): Don't pass it.
1278
1279 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1280
1281 Fix previous change: the library cache is defined in w32.c.
1282 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1283 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1284
1285 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1286
1287 Implement dynamic loading of GnuTLS on Windows.
1288
1289 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1290 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1291 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1292 Declare.
1293
1294 * gnutls.c (Qgnutls_dll): Define.
1295 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1296 (gnutls_*): Declare function pointers.
1297 (init_gnutls_functions): New function to initialize function pointers.
1298 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1299 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1300 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1301 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1302 (emacs_gnutls_write, emacs_gnutls_read)
1303 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1304 (Fgnutls_available_p): New function.
1305 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1306 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1307 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1308
1309 * image.c: Include w32.h.
1310 (Vimage_type_cache): Delete.
1311 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1312 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1313 (w32_delayed_load): Move to w32.c.
1314
1315 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1316
1317 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1318 (w32_delayed_load): Move from image.c. When loading a library, record
1319 its filename in the :loaded-from property of the library id.
1320 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1321 Initialize and staticpro them.
1322 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1323
1324 * process.c: Include lisp.h before w32.h, not after.
1325 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1326 instead of gnutls_record_check_pending.
1327
1328 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1329
1330 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1331
1332 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1333 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1334 as passed in.
1335
1336 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1337
1338 * xterm.c (x_set_frame_alpha): Do not set property on anything
1339 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1340
1341 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1342
1343 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1344
1345 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1346
1347 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1348 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1349 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1350 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1351 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1352 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1353 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1354 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1355 (Qgnutls_bootprop_callbacks_verify): Make static.
1356
1357 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1358
1359 * callproc.c: Indentation fixup.
1360
1361 * sysdep.c (wait_for_termination_1): Make static.
1362 (wait_for_termination, interruptible_wait_for_termination):
1363 Move after wait_for_termination_1.
1364
1365 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1366
1367 * sysdep.c (interruptible_wait_for_termination): New function
1368 which is like wait_for_termination, but allows keyboard
1369 interruptions.
1370
1371 * callproc.c (Fcall_process): Add (:file "file") as an option for
1372 the STDOUT buffer.
1373 (Fcall_process_region): Ditto.
1374
1375 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1376
1377 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1378 rather than `XVECTOR (FOO)->size'.
1379
1380 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1381 inttypes.h, as a gnulib replacement is used if it not available in
1382 system headers.
1383
1384 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1385
1386 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1387 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1388 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1389
1390 * coding.c (coding_alloc_by_realloc): Error out if destination
1391 will grow beyond MOST_POSITIVE_FIXNUM.
1392 (decode_coding_emacs_mule): Abort if there isn't enough place in
1393 charbuf for the composition carryover bytes. Reserve an extra
1394 space for up to 2 characters produced in a loop.
1395 (decode_coding_iso_2022): Abort if there isn't enough place in
1396 charbuf for the composition carryover bytes.
1397
1398 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1399
1400 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1401 aborting when %lld or %lll format is passed.
1402 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1403 %llo or %llx format is passed. (Bug#8545)
1404
1405 * window.c (window_scroll_line_based): Use a marker instead of
1406 simple variables to record original value of point. (Bug#7952)
1407
1408 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1409 produced by %s or %c overflows available buffer space. (Bug#8545)
1410
1411 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1414 (SIZE_MAX): Move defn after all includes, as they might #define it.
1415
1416 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1417
1418 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1419
1420 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1421
1422 * keyboard.c (Qdelayed_warnings_hook): Define.
1423 (command_loop_1): Run `delayed-warnings-hook'
1424 if Vdelayed_warnings_list is non-nil.
1425 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1426 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1427
1428 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1429
1430 * doprnt.c (doprnt): Don't return value smaller than the buffer
1431 size if the message was truncated. (Bug#8545).
1432
1433 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1434
1435 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1436 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1437
1438 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1439
1440 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1441
1442 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1443
1444 * makefile.w32-in: Update dependencies.
1445
1446 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1447
1448 Improve `doprnt' and its usage. (Bug#8545)
1449 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1450 `format_end'. Remove support for %l as a conversion specifier.
1451 Don't use xrealloc. Improve diagnostics when the %l size modifier
1452 is used. Update the commentary.
1453
1454 * eval.c (verror): Simplify calculation of size_t.
1455
1456 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1457 messages.
1458
1459 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1460
1461 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1462 change.
1463
1464 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1465
1466 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1467 This makes this file independent of the recent pseudovector change.
1468
1469 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1470
1471 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1472
1473 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1474 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1475 Remove unused local.
1476 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1477
1478 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1479 GCC 4.6.0 optimizes based on type-based alias analysis.
1480 For example, if b is of type struct buffer * and v of type struct
1481 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1482 != &v->size, and therefore "v->size = 1; b->size = 2; return
1483 v->size;" must therefore return 1. This assumption is incorrect
1484 for Emacs, since it type-puns struct Lisp_Vector * with many other
1485 types. To fix this problem, this patch adds a new type struct
1486 vectorlike_header that documents the constraints on layout of vectors
1487 and pseudovectors, and helps optimizing compilers not get fooled
1488 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1489 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1490 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1491 the size member.
1492 (XSETPVECTYPE): Rewrite in terms of new macro.
1493 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1494 This is a bit clearer, and further avoids the possibility of
1495 undesirable aliasing.
1496 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1497 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1498 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1499 since Lisp_Subr is a special case (no "next" field).
1500 (ASIZE): Now uses header.size rather than size.
1501 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1502 to avoid the hassle of writing XVECTOR (foo)->header.size.
1503 (struct vectorlike_header): New type.
1504 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1505 object, to help avoid aliasing.
1506 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1507 (SUBRP): Likewise, since Lisp_Subr is a special case.
1508 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1509 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1510 (struct Lisp_Hash_Table): Combine first two members into a single
1511 struct vectorlike_header member. All uses of "size" and "next" members
1512 changed to be "header.size" and "header.next".
1513 * buffer.h (struct buffer): Likewise.
1514 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1515 * frame.h (struct frame): Likewise.
1516 * process.h (struct Lisp_Process): Likewise.
1517 * termhooks.h (struct terminal): Likewise.
1518 * window.c (struct save_window_data, struct saved_window): Likewise.
1519 * window.h (struct window): Likewise.
1520 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1521 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1522 * buffer.c (init_buffer_once): Likewise.
1523 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1524 special case.
1525 * process.c (Fformat_network_address): Use local var for size,
1526 for brevity.
1527
1528 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1529
1530 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1531 * data.c (atof): Remove decl; no longer used or needed.
1532 (digit_to_number): Move to lread.c.
1533 (Fstring_to_number): Use new string_to_number function, to be
1534 consistent with how the Lisp reader treats infinities and NaNs.
1535 Do not assume that floating-point numbers represent EMACS_INT
1536 without losing information; this is not true on most 64-bit hosts.
1537 Avoid double-rounding errors, by insisting on integers when
1538 parsing non-base-10 numbers, as the documentation specifies.
1539 * lisp.h (string_to_number): New decl, replacing ...
1540 (isfloat_string): Remove.
1541 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1542 (read1): Do not accept +. and -. as integers; this
1543 appears to have been a coding error. Similarly, do not accept
1544 strings like +-1e0 as floating point numbers. Do not report
1545 overflow for integer overflows unless the base is not 10 which
1546 means we have no simple and reliable way to continue.
1547 Break out the floating-point parsing into a new
1548 function string_to_number, so that Fstring_to_number parses
1549 floating point numbers consistently with the Lisp reader.
1550 (digit_to_number): Move here from data.c. Make it static inline.
1551 (E_CHAR, EXP_INT): Remove, replacing with ...
1552 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1553 (string_to_number): New function, replacing isfloat_string.
1554 This function checks for valid syntax and produces the resulting
1555 Lisp float number too. Rework it so that string-to-number
1556 no longer mishandles examples like "1.0e+". Use strtoumax,
1557 so that overflow for non-base-10 numbers is reported only when
1558 there's no portable and simple way to convert to floating point.
1559
1560 * textprop.c (set_text_properties_1): Rewrite for clarity,
1561 and to avoid GCC warning about integer overflow.
1562
1563 * intervals.h (struct interval): Use EMACS_INT for members
1564 where EMACS_UINT might cause problems. See
1565 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1566 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1567 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1568 All uses changed.
1569 (offset_intervals): Tell GCC not to worry about length overflow
1570 when negating a negative length.
1571
1572 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1573 (overrun_check_free): Likewise.
1574
1575 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1576 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1577 word size.
1578
1579 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1580 (gnutls_make_error): Rename local to avoid shadowing.
1581 (gnutls_emacs_global_deinit): ifdef out; not used.
1582 (Fgnutls_boot): Use const for pointer to readonly storage.
1583 Comment out unused local. Fix pointer signedness problems.
1584
1585 * lread.c (openp): Don't stuff size_t into an 'int'.
1586 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1587 about possible signed overflow.
1588
1589 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1590 (GDK_KEY_g): Don't define if already defined.
1591 (xg_prepare_tooltip): Avoid pointer signedness problem.
1592 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1593
1594 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1595 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1596
1597 * xfns.c (Fx_window_property): Simplify a bit,
1598 to make a bit faster and to avoid GCC 4.6.0 warning.
1599 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1600
1601 * fns.c (internal_equal): Don't assume size_t fits in int.
1602
1603 * alloc.c (compact_small_strings): Tighten assertion a little.
1604
1605 Replace pEd with more-general pI, and fix some printf arg casts.
1606 * lisp.h (pI): New macro, generalizing old pEd macro to other
1607 conversion specifiers. For example, use "...%"pI"d..." rather
1608 than "...%"pEd"...".
1609 (pEd): Remove. All uses replaced with similar uses of pI.
1610 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1611 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1612 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1613 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1614 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1615 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1616 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1617 64-bit hosts.
1618 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1619 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1620 * print.c (safe_debug_print, print_object): Likewise.
1621 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1622 to int.
1623 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1624 avoiding the 0 flag, which is not portable.
1625 * process.c (Fmake_network_process): Use pI to avoid cast.
1626 * region-cache.c (pp_cache): Likewise.
1627 * xdisp.c (decode_mode_spec): Likewise.
1628 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1629 behavior on 64-bit hosts with printf arg.
1630 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1631 (x_stop_queuing_selection_requests): Likewise.
1632 (x_get_window_property): Don't truncate byte count to an 'int'
1633 when tracing.
1634
1635 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1636 here, since it parses constructs like leading '-' and spaces,
1637 which are not wanted; and it overflows with large numbers.
1638 Instead, simply match F[0-9]+, which is what is wanted anyway.
1639
1640 * alloc.c: Remove unportable assumptions about struct layout.
1641 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1642 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1643 (allocate_vectorlike, make_pure_vector): Use the new macros,
1644 plus offsetof, to remove unportable assumptions about struct layout.
1645 These assumptions hold on all porting targets that I know of, but
1646 they are not guaranteed, they're easy to remove, and removing them
1647 makes further changes easier.
1648
1649 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1650 This doesn't fix a bug but makes the code clearer.
1651 (string_overrun_cookie): Now const. Use initializers that
1652 don't formally overflow signed char, to avoid warnings.
1653 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1654 can cause Emacs to crash when string overrun checking is enabled.
1655 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1656 multiple of sizeof (EMACS_INT); it need not be, if
1657 alignof(EMACS_INT) < sizeof (EMACS_INT).
1658 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1659
1660 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1663
1664 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1665
1666 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1667 supposed to be handshaking. (Bug#8556)
1668 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1669
1670 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1671
1672 * lisp.h (Qdebug): List symbol.
1673 * eval.c (Qdebug): Restore global linkage.
1674 * keyboard.c (debug-on-event): New variable.
1675 (handle_user_signal): Break into debugger when debug-on-event
1676 matches the current signal symbol.
1677
1678 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1679
1680 * alloc.c (check_sblock, check_string_bytes)
1681 (check_string_free_list): Convert to standard C.
1682
1683 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1684
1685 * w32.c (emacs_gnutls_push): Fix typo.
1686
1687 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1688
1689 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1690 "cast to pointer from integer of different size".
1691
1692 Improve doprnt and its use in verror. (Bug#8545)
1693 * doprnt.c (doprnt): Document the set of format control sequences
1694 supported by the function. Use SAFE_ALLOCA instead of always
1695 using `alloca'.
1696
1697 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1698 is one byte too soon. Don't use xrealloc; instead xfree and
1699 xmalloc anew.
1700
1701 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1702
1703 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1704 callbacks stage.
1705
1706 * gnutls.c: Renamed global_initialized to
1707 gnutls_global_initialized. Added internals for the
1708 :verify-hostname-error, :verify-error, and :verify-flags
1709 parameters of `gnutls-boot' and documented those parameters in the
1710 docstring. Start callback support.
1711 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1712 unless a fatal error occured. Call gnutls_alert_send_appropriate
1713 on error. Return error code.
1714 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1715 (emacs_gnutls_read): Likewise.
1716 (Fgnutls_boot): Return handshake error code.
1717 (emacs_gnutls_handle_error): New function.
1718 (wsaerror_to_errno): Likewise.
1719
1720 * w32.h (emacs_gnutls_pull): Add prototype.
1721 (emacs_gnutls_push): Likewise.
1722
1723 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1724 (emacs_gnutls_push): Likewise.
1725
1726 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1727
1728 * process.c (wait_reading_process_output): Check if GnuTLS
1729 buffered some data internally if no FDs are set for TLS
1730 connections.
1731
1732 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1733 (LIBS): Link to USER_LIBS.
1734 ($(BLD)/gnutls.$(0)): New target.
1735
1736 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1737
1738 * xdisp.c (handle_single_display_spec): Rename the
1739 display_replaced_before_p argument into display_replaced_p, to
1740 make it consistent with the commentary. Fix typos in the
1741 commentary.
1742
1743 * textprop.c (syms_of_textprop): Remove dead code.
1744 (copy_text_properties): Delete obsolete commentary about an
1745 interface that was deleted long ago. Fix typos in the description
1746 of arguments.
1747
1748 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1749 to changes in oldXMenu/XMenu.h from 2011-04-16.
1750 <menu_help_message, prev_menu_help_message>: Constify.
1751 (IT_menu_make_room): menu->help_text is now `const char **';
1752 adjust.
1753
1754 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1755 to changes in oldXMenu/XMenu.h from 2011-04-16.
1756 (struct XMenu): Declare `help_text' `const char **'.
1757
1758 * xfaces.c <Qunspecified>: Make extern again.
1759
1760 * syntax.c: Include sys/types.h before including regex.h, as
1761 required by Posix.
1762
1763 * doc.c (get_doc_string): Improve the format passed to `error'.
1764
1765 * doprnt.c (doprnt): Improve commentary.
1766
1767 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1768
1769 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1770 them with etags.
1771
1772 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1773 changes in globals.h immediately force recompilation.
1774 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1775 $(CURDIR)/s/ms-w32.h.
1776 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1777
1778 * character.c (Fchar_direction): Function deleted.
1779 (syms_of_character): Don't defsubr it.
1780 <char-direction-table>: Deleted.
1781
1782 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1783
1784 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1785 * doprnt.c: Include limits.h.
1786 (SIZE_MAX): New macro.
1787 (doprnt): Return a size_t value. 2nd arg is now size_t.
1788 Many local variables are now size_t instead of int or unsigned.
1789 Improve overflow protection. Support `l' modifier for integer
1790 conversions. Support %l conversion. Don't assume an EMACS_INT
1791 argument for integer conversions and for %c.
1792
1793 * lisp.h (doprnt): Restore prototype.
1794
1795 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1796 $(SRC)/character.h.
1797
1798 * Makefile.in (base_obj): Add back doprnt.o.
1799
1800 * deps.mk (doprnt.o): Add back prerequisites.
1801 (callint.o): Depend on character.h.
1802
1803 * eval.c (internal_lisp_condition_case): Include the handler
1804 representation in the error message.
1805 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1806 when breaking from the loop.
1807
1808 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1809
1810 * callint.c (Fcall_interactively): When displaying error message
1811 about invalid control letter, pass the character's codepoint, not
1812 a pointer to its multibyte form. Improve display of the character
1813 in octal and display also its hex code.
1814
1815 * character.c (char_string): Use %x to display the (unsigned)
1816 codepoint of an invalid character, to avoid displaying a bogus
1817 negative value.
1818
1819 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1820 `error', not SYMBOL_NAME itself.
1821
1822 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1823 character arguments to `error'.
1824
1825 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1826 to `error' in error message about FINAL_CHAR argument. Make sure
1827 FINAL_CHAR is a character, and use %c when it is passed as
1828 argument to `error'.
1829
1830 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1831
1832 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1833
1834 * w32.c: Include <time.h>.
1835 (sys_localtime): New function.
1836
1837 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1838
1839 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1840
1841 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1842
1843 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1844
1845 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1846 zombies (Bug#8467).
1847
1848 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1849
1850 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1851 gl_state.e_property when gl_state.object is Qt.
1852
1853 * insdel.c (make_gap_larger): Remove limitation of buffer size
1854 to <= INT_MAX.
1855
1856 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1857
1858 * xdisp.c (lookup_glyphless_char_display)
1859 (produce_glyphless_glyph): Handle cons cell entry in
1860 glyphless-char-display.
1861 (Vglyphless_char_display): Document it.
1862
1863 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1864 glyphless-char-display.
1865
1866 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1867
1868 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1869
1870 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1871
1872 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1873 definition for no-X builds.
1874
1875 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 Static checks with GCC 4.6.0 and non-default toolkits.
1878
1879 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1880
1881 * process.c (keyboard_bit_set): Define only if SIGIO.
1882 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1883 (send_process): Repair possible setjmp clobbering.
1884
1885 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1886
1887 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1888
1889 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1890
1891 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1892 Define only if needed.
1893
1894 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1895 by pacifying GCC about it. Maybe it's time to retire it?
1896 * xfaces.c (USG, __TIMEVAL__): Likewise.
1897
1898 * dispextern.h (struct redisplay_interface): Rename param
1899 to avoid shadowing.
1900 * termhooks.h (struct terminal): Likewise.
1901 * xterm.c (xembed_send_message): Likewise.
1902
1903 * insdel.c (make_gap_smaller): Define only if
1904 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1905
1906 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1907 it.
1908
1909 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1910 so that we aren't warned about unused symbols.
1911
1912 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1913
1914 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1915
1916 * xfns.c (x_real_positions): Mark locals as initialized.
1917
1918 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1919
1920 * xterm.c: Fix problems found by static analysis with other toolkits.
1921 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1922 (x_dispatch_event): Declare static if USE_GTK, and
1923 define if USE_GTK || USE_X_TOOLKIT.
1924 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1925 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1926 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1927 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1928
1929 * xmenu.c (menu_help_callback): Pointer type fixes.
1930 Use const pointers when pointing at readonly data. Avoid pointer
1931 signedness clashes.
1932 (FALSE): Remove unused macro.
1933 (update_frame_menubar): Remove unused decl.
1934
1935 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1936
1937 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1938 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1939 (single_menu_item): Rename local to avoid shadowing.
1940
1941 * keyboard.c (make_lispy_event): Remove unused local var.
1942
1943 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1944 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1945
1946 * bitmaps: Change bitmaps from unsigned char back to the X11
1947 compatible char. Avoid the old compiler warnings about
1948 out-of-range initializers by using, for example, '\xab' rather
1949 than 0xab.
1950
1951 * xgselect.c (xgselect_initialize): Check vs interface
1952 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1953
1954 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1955
1956 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1957 to read-only memory.
1958
1959 * fns.c (vector): Remove; this old hack is no longer needed.
1960
1961 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1962 Remove unused var.
1963 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1964
1965 * xrdb.c (x_load_resources): Omit unused local.
1966
1967 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1968 (x_window): Rename locals to avoid shadowing.
1969 (USG): Use the kludged USG macro, to pacify gcc.
1970
1971 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1972 (x_term_init): Remove local to avoid shadowing.
1973
1974 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1975
1976 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1977 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1978
1979 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1980
1981 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1982
1983 Fix regex.c, syntax.c and friends for buffers > 2GB.
1984 * syntax.h (struct gl_state_s): Declare character position members
1985 EMACS_INT.
1986
1987 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1988
1989 * textprop.c (verify_interval_modification, interval_of):
1990 Declare arguments EMACS_INT.
1991
1992 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1993 EMACS_INT.
1994
1995 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1996
1997 * indent.c (Fvertical_motion): Local variable it_start is now
1998 EMACS_INT.
1999
2000 * regex.c (re_match, re_match_2, re_match_2_internal)
2001 (bcmp_translate, regcomp, regexec, print_double_string)
2002 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2003 (re_compile_pattern, re_exec): Declare arguments and local
2004 variables `size_t' and `ssize_t' and return values `regoff_t', as
2005 appropriate.
2006 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2007 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2008 <compile_stack_type>: `size' and `avail' are now `size_t'.
2009
2010 * regex.h <regoff_t>: Use ssize_t, not int.
2011 (re_search, re_search_2, re_match, re_match_2): Arguments that
2012 specify buffer/string position and length are now ssize_t and
2013 size_t. Return type is regoff_t.
2014
2015 2011-04-16 Ben Key <bkey76@gmail.com>
2016
2017 * nsfont.m: Fixed bugs in ns_get_family and
2018 ns_descriptor_to_entity that were caused by using free to
2019 deallocate memory blocks that were allocated by xmalloc (via
2020 xstrdup). This caused Emacs to crash when compiled with
2021 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2022 --enable-checking=xmallocoverrun). xfree is now used to
2023 deallocate these memory blocks.
2024
2025 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2028
2029 emacs_write: Accept and return EMACS_INT for sizes.
2030 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2031 et seq.
2032 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2033 Accept and return EMACS_INT.
2034 (emacs_gnutls_write): Return the number of bytes written on
2035 partial writes.
2036 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2037 (emacs_read, emacs_write): Remove check for negative size, as the
2038 Emacs source code has been audited now.
2039 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2040 (emacs_read, emacs_write): Use it.
2041 * process.c (send_process): Adjust to the new signatures of
2042 emacs_write and emacs_gnutls_write. Do not attempt to store
2043 a byte offset into an 'int'; it might overflow.
2044 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2045
2046 * sound.c: Don't assume sizes fit in 'int'.
2047 (struct sound_device.period_size, alsa_period_size):
2048 Return EMACS_INT, not int.
2049 (struct sound_device.write, vox_write, alsa_write):
2050 Accept EMACS_INT, not int.
2051 (wav_play, au_play): Use EMACS_INT to store sizes and to
2052 record read return values.
2053
2054 2011-04-15 Ben Key <bkey76@gmail.com>
2055
2056 * keyboard.c (Qundefined): Don't declare static since it is used
2057 in nsfns.m.
2058 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2059 static since they are used in nsfont.m.
2060
2061 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2062
2063 * process.c (Qprocessp): Don't declare static.
2064 * lisp.h (Qprocessp): Declare again.
2065
2066 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2067
2068 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2069
2070 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 Improve C-level modularity by making more things 'static'.
2073
2074 Don't publish debugger-only interfaces to other modules.
2075 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2076 (verify_bytepos, count_markers): Move decls to the only modules
2077 that need them.
2078 * region-cache.h (pp_cache): Likewise.
2079 * window.h (check_all_windows): Likewise.
2080 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2081
2082 * sysdep.c (croak): Now static, if
2083 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2084 * syssignal.h (croak): Declare only if not static.
2085
2086 * alloc.c (refill_memory_reserve): Now static if
2087 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2088 * lisp.h (refill_memory_reserve): Declare only if not static.
2089
2090 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2091 Define only if USE_LUCID.
2092
2093 * xrdb.c (x_customization_string, x_rm_string): Now static.
2094
2095 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2096 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2097
2098 * xdisp.c (draw_row_with_mouse_face): Now static.
2099 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2100
2101 * window.h (check_all_windows): Mark externally visible.
2102
2103 * window.c (window_deletion_count): Now static.
2104
2105 * undo.c: Make symbols static if they're not exported.
2106 (last_undo_buffer, last_boundary_position, pending_boundary):
2107 Now static.
2108
2109 * textprop.c (interval_insert_behind_hooks): Now static.
2110 (interval_insert_in_front_hooks): Likewise.
2111
2112 * term.c: Make symbols static if they're not exported.
2113 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2114 (max_frame_lines, tty_set_terminal_modes):
2115 (tty_reset_terminal_modes, tty_turn_off_highlight):
2116 (get_tty_terminal): Now static.
2117 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2118 * termhooks.h (term_mouse_moveto): Do not declare if
2119 HAVE_WINDOW_SYSTEM.
2120 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2121 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2122
2123 * sysdep.c: Make symbols static if they're not exported.
2124 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2125 Now static.
2126 (sigprocmask_set, full_mask): Remove; unused.
2127 (wait_debugging): Mark as visible.
2128 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2129 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2130
2131 * syntax.c (syntax_temp): Define only if !__GNUC__.
2132
2133 * sound.c (current_sound_device, current_sound): Now static.
2134
2135 * search.c (searchbufs, searchbuf_head): Now static.
2136
2137 * scroll.c (scroll_cost): Remove; unused.
2138 * dispextern.h (scroll_cost): Remove decl.
2139
2140 * region-cache.h (pp_cache): Mark as externally visible.
2141
2142 * process.c: Make symbols static if they're not exported.
2143 (process_tick, update_tick, create_process, chan_process):
2144 (Vprocess_alist, proc_buffered_char, datagram_access):
2145 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2146 (deactivate_process): Mark defn as static, as well as decl.
2147 * lisp.h (create_process): Remove decl.
2148 * process.h (chan_process, Vprocess_alist): Remove decls.
2149
2150 * print.c: Make symbols static if they're not exported.
2151 (print_depth, new_backquote_output, being_printed, print_buffer):
2152 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2153 (print_interval, print_number_index, initial_stderr_stream):
2154 Now static.
2155 * lisp.h (Fprinc): Remove decl.
2156 (debug_output_compilation_hack): Mark as externally visible.
2157
2158 * sysdep.c (croak): Move decl from here to syssignal.h.
2159 * syssignal.h (croak): Put it here, so the API can be checked when
2160 'croak' is called from dissociate_if_controlling_tty.
2161
2162 * minibuf.c: Make symbols static if they're not exported.
2163 (minibuf_save_list, choose_minibuf_frame): Now static.
2164 * lisp.h (choose_minibuf_frame): Remove decl.
2165
2166 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2167
2168 * lread.c: Make symbols static if they're not exported.
2169 (read_objects, initial_obarray, oblookup_last_bucket_number):
2170 Now static.
2171 (make_symbol): Remove; unused.
2172 * lisp.h (initial_obarray, make_symbol): Remove decls.
2173
2174 * keyboard.c: Make symbols static if they're not exported.
2175 (single_kboard, recent_keys_index, total_keys, recent_keys):
2176 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2177 (this_single_command_key_start, echoing, last_auto_save):
2178 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2179 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2180 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2181 (Vlispy_mouse_stem, double_click_count):
2182 Now static.
2183 (force_auto_save_soon): Define only if SIGDANGER.
2184 (ignore_mouse_drag_p): Now static if
2185 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2186 (print_help): Remove; unused.
2187 (stop_character, last_timer_event): Mark as externally visible.
2188 * keyboard.h (ignore_mouse_drag_p): Declare only if
2189 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2190 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2191 * lisp.h (echoing): Remove decl.
2192 (force_auto_save_soon): Declare only if SIGDANGER.
2193 * xdisp.c (redisplay_window): Simplify code, to make it more
2194 obvious that ignore_mouse_drag_p is not accessed if !defined
2195 USE_GTK && !defined HAVE_NS.
2196
2197 * intervals.c: Make symbols static if they're not exported.
2198 (merge_properties_sticky, merge_interval_right, delete_interval):
2199 Now static.
2200 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2201
2202 * insdel.c: Make symbols static if they're not exported.
2203 However, leave prepare_to_modify_buffer alone. It's never
2204 called from outside this function, but that appears to be a bug.
2205 (combine_after_change_list, combine_after_change_buffer):
2206 (adjust_after_replace, signal_before_change): Now static.
2207 (adjust_after_replace_noundo): Remove; unused.
2208 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2209 (signal_before_change): Remove decls.
2210
2211 * indent.c (val_compute_motion, val_vmotion): Now static.
2212
2213 * image.c: Make symbols static if they're not exported.
2214 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2215 if USE_GTK.
2216 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2217 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2218
2219 * fringe.c (standard_bitmaps): Now static.
2220 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2221
2222 * frame.c: Make symbols static if they're not exported.
2223 (x_report_frame_params, make_terminal_frame): Now static.
2224 (get_frame_param): Now static, unless HAVE_NS.
2225 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2226 (x_get_resource_string): Remove; not used.
2227 * frame.h (make_terminal_frame, x_report_frame_params):
2228 (x_get_resource_string); Remove decls.
2229 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2230 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2231
2232 * font.c, fontset.c: Make symbols static if they're not exported.
2233 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2234 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2235 * font.c (font_close_object): Now static.
2236 * font.h (font_close_object): Remove.
2237 * fontset.c (FONTSET_OBJLIST): Remove.
2238 (free_realized_fontset) #if-0 the body, which does nothing.
2239 (face_suitable_for_char_p): #if-0, as it's never called.
2240 * fontset.h (face_suitable_for_char_p): Remove decl.
2241 * xfaces.c (face_at_string_position):
2242 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2243 since 0 is always ASCII.
2244
2245 * fns.c (weak_hash_tables): Now static.
2246
2247 * fileio.c: Make symbols static if they're not exported.
2248 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2249 (Vwrite_region_annotation_buffers): Now static.
2250
2251 * eval.c: Make symbols static if they're not exported.
2252 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2253 * lisp.h (backtrace_list): Remove decl.
2254
2255 * emacs.c: Make symbols static if they're not exported.
2256 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2257 (fatal_error_code, fatal_error_signal_hook, standard_args):
2258 Now static.
2259 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2260 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2261 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2262 * lisp.h (fatal_error_signal_hook): Remove decl.
2263 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2264
2265 * editfns.c: Move a (normally-unused) function to its only use.
2266 * editfns.c, lisp.h (get_operating_system_release): Remove.
2267 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2268 worth the hassle of breaking this out.
2269
2270 * xterm.c: Make symbols static if they're not exported.
2271 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2272 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2273 (x_destroy_window, x_delete_display):
2274 Now static.
2275 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2276 (x_mouse_leave): Remove; unused.
2277 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2278 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2279 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2280 Remove decls.
2281 (x_mouse_leave): Declare only if WINDOWSNT.
2282 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2283 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2284 USE_X_TOOLKIT.
2285
2286 * ftxfont.c: Make symbols static if they're not exported.
2287 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2288 HAVE_FREETYPE.
2289 * font.h (ftxfont_driver): Likewise.
2290
2291 * xfns.c: Make symbols static if they're not exported.
2292 (x_last_font_name, x_display_info_for_name):
2293 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2294 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2295 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2296 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2297 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2298 (last_show_tip_args): Now static.
2299 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2300 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2301 (x_screen_planes): Remove; unused.
2302 * dispextern.h (x_screen_planes): Remove decl.
2303
2304 * dispnew.c: Make symbols static if they're not exported.
2305 * dispextern.h (redraw_garbaged_frames, scrolling):
2306 (increment_row_positions): Remove.
2307 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2308 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2309 Now static.
2310 (redraw_garbaged_frames): Remove; unused.
2311
2312 * xfaces.c: Make symbols static if they're not exported.
2313 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2314 Remove decls.
2315 * xterm.h (defined_color): Remove decls.
2316 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2317 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2318 (menu_face_changed_default, defined_color, free_realized_face):
2319 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2320 (ascii_face_of_lisp_face): Remove; unused.
2321
2322 * xdisp.c: Make symbols static if they're not exported.
2323 * dispextern.h (scratch_glyph_row, window_box_edges):
2324 (glyph_to_pixel_coords, set_cursor_from_row):
2325 (get_next_display_element, set_iterator_to_next):
2326 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2327 (show_mouse_face): Remove decls
2328 * frame.h (message_buf_print): Likewise.
2329 * lisp.h (pop_message, set_message, check_point_in_composition):
2330 Likewise.
2331 * xterm.h (set_vertical_scroll_bar): Likewise.
2332 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2333 (message_buf_print, scratch_glyph_row, displayed_buffer):
2334 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2335 (get_next_display_element, show_mouse_face, window_box_edges):
2336 (frame_to_window_pixel_xy, check_point_in_composition):
2337 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2338 (glyph_to_pixel_coords): Remove; unused.
2339
2340 * dired.c (file_name_completion): Now static.
2341
2342 * dbusbind.c (xd_in_read_queued_messages): Now static.
2343
2344 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2345 * data.c (circular_list_error): Remove.
2346
2347 * commands.h (last_point_position, last_point_position_buffer):
2348 (last_point_position_window): Remove decls.
2349 * keyboard.c: Make these variables static.
2350
2351 * coding.h (coding, code_convert_region, encode_coding_gap):
2352 Remove decls.
2353 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2354 (iso_code_class, detect_coding, code_convert_region): Now static.
2355 (encode_coding_gap): Remove; unused.
2356
2357 * chartab.c (chartab_chars, chartab_bits): Now static.
2358
2359 * charset.h (charset_iso_8859_1): Remove decl.
2360 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2361 Now static.
2362
2363 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2364 * ccl.c (Vccl_program_table): Now static.
2365 (check_ccl_update): Remove; unused.
2366
2367 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2368 * category.h: ... from here.
2369 * category.c (check_category_table, set_category_set): Now static.
2370
2371 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2372 * lisp.h: Remove these decls.
2373
2374 * buffer.c (buffer_count): Remove unused var.
2375
2376 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2377 so that it's not optimized away.
2378 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2379 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2380 exported only to the debugger.
2381
2382 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2383 * atimer.h (run_all_atimers): Remove; not exported.
2384
2385 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2386 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2387 was inaccessible from Lisp.
2388 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2389 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2390
2391 alloc.c: Import and export fewer symbols, and remove unused items.
2392 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2393 is defined.
2394 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2395 it's not optimized away by whole-program optimization.
2396 (message_enable_multibyte, free_misc): Remove.
2397 (catchlist, handlerlist, mark_backtrace):
2398 Declare only if BYTE_MARK_STACK.
2399 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2400 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2401 (message_enable_multibyte): Remove decl.
2402 (free_misc, interval_free_list, float_block, float_block_index):
2403 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2404 (cons_free_list, last_marked_index):
2405 Now static.
2406 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2407 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2408 (mark_backtrace): Define only if BYTE_MARK_STACK.
2409 * xdisp.c (message_enable_multibyte): Now static.
2410
2411 Declare Lisp_Object Q* variables to be 'static' if not exported.
2412 This makes it easier for human readers (and static analyzers)
2413 to see whether these variables are used from other modules.
2414 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2415 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2416 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2417 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2418 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2419 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2420 * xmenu.c, xselect.c:
2421 Declare Q* vars static if they are not used in other modules.
2422 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2423 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2424 Remove decls of unexported vars.
2425 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2426
2427 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2428
2429 Make Emacs functions such as Fatom 'static' by default.
2430 This makes it easier for human readers (and static analyzers)
2431 to see whether these functions can be called from other modules.
2432 DEFUN now defines a static function. To make the function external
2433 so that it can be used in other C modules, use the new macro DEFUE.
2434 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2435 (Finit_image_library):
2436 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2437 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2438 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2439 Remove decls, since these functions are now static.
2440 (Funintern, Fget_internal_run_time): New decls, since these functions
2441 were already external.
2442
2443 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2444 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2445 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2446 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2447 * keyboard.c, keymap.c, lread.c:
2448 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2449 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2450 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2451 Mark functions with DEFUE instead of DEFUN,
2452 if they are used in other modules.
2453 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2454 decls for now-static functions.
2455 * buffer.h (Fdelete_overlay): Remove decl.
2456 * callproc.c (Fgetenv_internal): Mark as internal.
2457 * composite.c (Fremove_list_of_text_properties): Remove decl.
2458 (Fcomposition_get_gstring): New forward static decl.
2459 * composite.h (Fcomposite_get_gstring): Remove decl.
2460 * dired.c (Ffile_attributes): New forward static decl.
2461 * doc.c (Fdocumntation_property): New forward static decl.
2462 * eval.c (Ffetch_bytecode): New forward static decl.
2463 (Funintern): Remove extern decl; now in .h file where it belongs.
2464 * fileio.c (Fmake_symbolic_link): New forward static decl.
2465 * image.c (Finit_image_library): New forward static decl.
2466 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2467 * intervals.h (Fprevious_property_change):
2468 (Fremove_list_of_text_properties): Remove decls.
2469 * keyboard.c (Fthis_command_keys): Remove decl.
2470 (Fcommand_execute): New forward static decl.
2471 * keymap.c (Flookup_key): New forward static decl.
2472 (Fcopy_keymap): Now static.
2473 * keymap.h (Flookup_key): Remove decl.
2474 * process.c (Fget_process): New forward static decl.
2475 (Fprocess_datagram_address): Mark as internal.
2476 * syntax.c (Fsyntax_table_p): New forward static decl.
2477 (skip_chars): Remove duplicate decl.
2478 * textprop.c (Fprevious_property_change): New forward static decl.
2479 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2480 Now internal.
2481 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2482 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2483
2484 * editfns.c (Fformat): Remove unreachable code.
2485
2486 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2487
2488 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2489 change. (Bug#8496)
2490
2491 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2492
2493 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2494 when at ZV. (Bug#8487)
2495
2496 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2497
2498 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2499 (Bug#8437)
2500 * keyboard.c (parse_tool_bar_item): Likewise.
2501 * sound.c (sound_cleanup, alsa_close): Likewise.
2502 * termcap.c (tgetent): Likewise.
2503 * xfns.c (x_default_font_parameter): Likewise.
2504 * xsettings.c (read_and_apply_settings): Likewise.
2505
2506 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2507 (overrun_check_free): Protoize.
2508
2509 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2512 since callers should never pass a negative size.
2513 Change the signature to match that of plain 'read' and 'write'; see
2514 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2515 * lisp.h: Update prototypes of emacs_write and emacs_read.
2516
2517 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2518
2519 * xdisp.c (redisplay_window): Don't try to determine the character
2520 position of the scroll margin if the window start point w->startp
2521 is outside the buffer's accessible region. (Bug#8468)
2522
2523 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2524
2525 Fix write-region and its subroutines for buffers > 2GB.
2526 * fileio.c (a_write, e_write): Modify declaration of arguments and
2527 local variables to support buffers larger than 2GB.
2528 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2529
2530 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2531 argument, local variables, and return value.
2532
2533 * lisp.h: Update prototypes of emacs_write and emacs_read.
2534
2535 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2536
2537 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2538
2539 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2540
2541 Fix more problems found by GCC 4.6.0's static checks.
2542
2543 * xdisp.c (vmessage): Use a better test for character truncation.
2544
2545 * charset.c (load_charset_map): <, not <=, for optimization,
2546 and to avoid potential problems with integer overflow.
2547 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2548 * casetab.c (set_identity, shuffle): Likewise.
2549 * editfns.c (Fformat): Likewise.
2550 * syntax.c (skip_chars): Likewise.
2551
2552 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2553 This also lets GCC 4.6.0 generate slightly better loop code.
2554
2555 * callint.c (Fcall_interactively): <, not <=, for optimization.
2556 (Fcall_interactively): Count the number of arguments produced,
2557 not the number of arguments given. This is simpler and lets GCC
2558 4.6.0 generate slightly better code.
2559
2560 * ftfont.c: Distingish more carefully between FcChar8 and char.
2561 The previous code passed unsigned char * to a functions like
2562 strlen and xstrcasecmp that expect char *, which does not
2563 conform to the C standard.
2564 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2565 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2566 char * when the C standard requires it.
2567
2568 * keyboard.c (read_char): Remove unused var.
2569
2570 * eval.c: Port to Windows vsnprintf (Bug#8435).
2571 Include <limits.h>.
2572 (SIZE_MAX): Define if the headers do not.
2573 (verror): Do not give up if vsnprintf returns a negative count.
2574 Instead, grow the buffer. This ports to Windows vsnprintf, which
2575 does not conform to C99. Problem reported by Eli Zaretskii.
2576 Also, simplify the allocation scheme, by avoiding the need for
2577 calling realloc, and removing the ALLOCATED variable.
2578
2579 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2580
2581 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2582 But keep the doprint source code for now, as we might revamp it
2583 and use it again (Bug#8435).
2584 * lisp.h (doprnt): Remove.
2585 * Makefile.in (base_obj): Remove doprnt.o.
2586 * deps.mk (doprnt.o): Remove.
2587
2588 error: Print 32- and 64-bit integers portably (Bug#8435).
2589 Without this change, on typical 64-bit hosts error ("...%d...", N)
2590 was used to print both 32- and 64-bit integers N, which relied on
2591 undefined behavior.
2592 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2593 New macro.
2594 * lisp.h (error, verror): Mark as printf-like functions.
2595 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2596 Report overflow in size calculations when allocating printf buffer.
2597 Do not truncate output string at its first null byte.
2598 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2599 Truncate the output at a character boundary, since vsnprintf does not
2600 do that.
2601 * charset.c (check_iso_charset_parameter): Convert internal
2602 character to string before calling 'error', since %c now has the
2603 printf meaning.
2604 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2605 overflow when computing char to be passed to 'error'. Do not
2606 pass Lisp_Object to 'error'; pass the integer instead.
2607 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2608 formatted with plain %d.
2609
2610 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2611
2612 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2613
2614 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2615
2616 * xterm.c (x_catch_errors): Remove duplicate declaration.
2617
2618 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2619
2620 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2621
2622 2011-04-10 Jim Meyering <meyering@redhat.com>
2623
2624 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2625 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2626 return ssize_t not "int", and use size_t as the buffer length.
2627 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2628 * gnutls.h: Update declarations.
2629 * process.c (read_process_output): Use ssize_t, to match.
2630 (send_process): Likewise.
2631
2632 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2633
2634 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2635
2636 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2637
2638 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2639 Use unsigned char, to match FcChar8 type definition.
2640
2641 * xterm.c (handle_one_xevent):
2642 * xmenu.c (create_and_show_popup_menu):
2643 * xselect.c (x_decline_selection_request)
2644 (x_reply_selection_request): Avoid type-punned deref of X events.
2645
2646 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2647
2648 Fix some uses of `int' instead of EMACS_INT.
2649 * search.c (string_match_1, fast_string_match)
2650 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2651 (scan_buffer, find_next_newline_no_quit)
2652 (find_before_next_newline, search_command, Freplace_match)
2653 (Fmatch_data): Make some `int' variables be EMACS_INT.
2654
2655 * xdisp.c (display_count_lines): 3rd argument and return value now
2656 EMACS_INT. All callers changed.
2657 (pint2hrstr): Last argument is now EMACS_INT.
2658
2659 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2660 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2661 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2662 (decode_coding_utf_16, decode_coding_emacs_mule)
2663 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2664 (decode_coding_ccl, decode_coding_charset)
2665 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2666 (decode_coding_iso_2022, decode_coding_emacs_mule)
2667 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2668 <char_offset, last_offset>: Declare EMACS_INT.
2669 (encode_coding_utf_8, encode_coding_utf_16)
2670 (encode_coding_emacs_mule, encode_invocation_designation)
2671 (encode_designation_at_bol, encode_coding_iso_2022)
2672 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2673 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2674 Declare EMACS_INT.
2675 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2676 (encode_invocation_designation): Last argument P_NCHARS is now
2677 EMACS_INT.
2678 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2679 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2680
2681 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2682 All users changed.
2683
2684 * ccl.c (Fccl_execute_on_string): Declare some variables
2685 EMACS_INT.
2686
2687 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2688
2689 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2690
2691 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2692
2693 * process.c (Fformat_network_address): Doc fix.
2694
2695 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2696
2697 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2698
2699 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2700
2701 * keyboard.c (read_char): Call Lisp function help-form-show,
2702 instead of using internal_with_output_to_temp_buffer.
2703 (Qhelp_form_show): New var.
2704 (syms_of_keyboard): Use DEFSYM macro.
2705
2706 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2707
2708 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2709
2710 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2711
2712 * process.c (Flist_processes): Remove to Lisp.
2713 (list_processes_1): Delete.
2714
2715 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2716
2717 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2718
2719 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2720
2721 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2722
2723 Fix more problems found by GCC 4.6.0's static checks.
2724
2725 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2726
2727 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2728
2729 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2730
2731 * xdisp.c (vmessage): Mark as a printf-like function.
2732
2733 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2734
2735 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2736
2737 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2738 printf-like functions.
2739 (tiff_load): Add casts to remove these marks before passing them
2740 to system-supplied API.
2741
2742 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2743
2744 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2745 This avoids several warnings with gcc -Wstrict-overflow.
2746 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2747 directly, rather than having caller test rule sign. This avoids
2748 some unnecessary tests.
2749 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2750 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2751 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2752
2753 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2754 (xfont_open): Avoid unnecessary tests.
2755
2756 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2757
2758 * composite.h, composite.c (composition_gstring_put_cache):
2759 Use EMACS_INT, not int, for length.
2760
2761 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2762 breaking out part of COMPOSITION_DECODE_RULE.
2763 (COMPOSITION_DECODE_RULE): Use it.
2764 * composite.c (get_composition_id): Remove unused local vars,
2765 by using the new macro.
2766
2767 * textprop.c (set_text_properties_1): Change while to do-while,
2768 since the condition is always true at first.
2769
2770 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2771 (interval_deletion_adjustment): Return unsigned value.
2772 All uses changed.
2773
2774 * process.c (list_processes_1, create_pty, read_process_output):
2775 (exec_sentinel): Remove vars that were set but not used.
2776 (create_pty): Remove unnecessary "volatile"s.
2777 (Fnetwork_interface_info): Avoid possibility of int overflow.
2778 (read_process_output): Do adaptive read buffering even if carryover.
2779 (read_process_output): Simplify nbytes computation if buffered.
2780
2781 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2782
2783 * syntax.c (scan_words): Remove var that was set but not used.
2784 (update_syntax_table): Use unsigned instead of int.
2785
2786 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2787 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2788 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2789
2790 * print.c (print_error_message): Avoid int overflow.
2791
2792 * font.c (font_list_entities): Redo for clarity,
2793 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2794
2795 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2796 (font_score): Avoid potential overflow in diff calculation.
2797
2798 * fns.c (substring_both): Remove var that is set but not used.
2799 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2800
2801 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2802
2803 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2804 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2805 can always succeed if overflow has undefined behavior.
2806
2807 * search.c (boyer_moore, wordify): Remove vars set but not used.
2808 (wordify): Omit three unnecessary tests.
2809
2810 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2811 All callers changed. This avoids the need for an unused var.
2812
2813 * casefiddle.c (casify_region): Remove var that is set but not used.
2814
2815 * dired.c (file_name_completion): Remove var that is set but not used.
2816
2817 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2818
2819 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2820 (Finsert_file_contents): Remove unnecessary code checking fd.
2821
2822 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2823 Check for integer overflow on size calculations.
2824
2825 * buffer.c (Fprevious_overlay_change): Remove var that is set
2826 but not used.
2827
2828 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2829 Remove vars that are set but not used.
2830 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2831 (timer_check_2): Mark vars as initialized.
2832
2833 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2834
2835 * image.c (lookup_image): Remove var that is set but not used.
2836 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2837
2838 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2839 that are set but not used.
2840
2841 * xfns.c (make_invisible_cursor): Don't return garbage
2842 if XCreateBitmapFromData fails (Bug#8410).
2843
2844 * xselect.c (x_get_local_selection, x_handle_property_notify):
2845 Remove vars that are set but not used.
2846
2847 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2848 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2849
2850 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2851 Remove var that is set but not used.
2852 (scroll_bar_windows_size): Now size_t, not int.
2853 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2854 Check for overflow.
2855
2856 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2857 (map_tty_color) [!defined MSDOS]: Likewise.
2858
2859 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2860
2861 * coding.c: Remove vars that are set but not used.
2862 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2863 All callers changed.
2864 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2865 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2866 (decode_coding_charset): Remove vars that are set but not used.
2867
2868 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2869 that is set but not used.
2870
2871 * print.c (print_object): Remove var that is set but not used.
2872
2873 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2874 The gnulib version avoids calling malloc in the usual case,
2875 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2876 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2877 * filelock.c (current_lock_owner): Likewise.
2878 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2879 * sysdep.c: Include allocator.h, careadlinkat.h.
2880 (emacs_no_realloc_allocator): New static constant.
2881 (emacs_readlink): New function.
2882 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2883 ../lib/careadlinkat.h.
2884
2885 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2886
2887 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2888 first non-nil return value).
2889
2890 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2891
2892 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2893 if not defined (Bug#8403).
2894
2895 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2896
2897 * xdisp.c (display_count_lines): Remove parameter `start',
2898 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2899 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2900 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2901 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2902 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2903 and thereabouts. All callers changed.
2904 (get_per_char_metric): Remove parameter `f', unused since
2905 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2906
2907 2011-04-02 Jim Meyering <meyering@redhat.com>
2908
2909 do not dereference NULL upon failed strdup
2910 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2911 (ns_get_family): Likewise.
2912
2913 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2914
2915 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2916
2917 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2918
2919 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2920 later (Bug#8403).
2921
2922 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2923
2924 Add lexical binding.
2925
2926 * window.c (Ftemp_output_buffer_show): New fun.
2927 (Fsave_window_excursion):
2928 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2929
2930 * lread.c (lisp_file_lexically_bound_p): New function.
2931 (Fload): Bind Qlexical_binding.
2932 (readevalloop): Remove `evalfun' arg.
2933 Bind Qinternal_interpreter_environment.
2934 (Feval_buffer): Bind Qlexical_binding.
2935 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2936 Mark as dynamic.
2937 (syms_of_lread): Declare `lexical-binding'.
2938
2939 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2940
2941 * keyboard.c (eval_dyn): New fun.
2942 (menu_item_eval_property): Use it.
2943
2944 * image.c (parse_image_spec): Use Ffunctionp.
2945
2946 * fns.c (concat, mapcar1): Accept byte-code-functions.
2947
2948 * eval.c (Fsetq): Handle lexical vars.
2949 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2950 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2951 (FletX, Flet): Obey lexical binding.
2952 (Fcommandp): Handle closures.
2953 (Feval): New `lexical' arg.
2954 (eval_sub): New function extracted from Feval. Use it almost
2955 everywhere where Feval was used. Look up vars in lexical env.
2956 Handle closures.
2957 (Ffunctionp): Move from subr.el.
2958 (Ffuncall): Handle closures.
2959 (apply_lambda): Remove `eval_flags'.
2960 (funcall_lambda): Handle closures and new byte-code-functions.
2961 (Fspecial_variable_p): New function.
2962 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2963 but without exporting it to Lisp.
2964
2965 * doc.c (Fdocumentation, store_function_docstring):
2966 * data.c (Finteractive_form): Handle closures.
2967
2968 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2969 interactive spec.
2970
2971 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2972 New byte-codes.
2973 (exec_byte_code): New function extracted from Fbyte_code to handle new
2974 calling convention for byte-code-functions. Add new byte-codes.
2975
2976 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2977
2978 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2979
2980 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2981
2982 * xdisp.c (redisplay_internal): Fix prototype.
2983
2984 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2985
2986 * xdisp.c (SCROLL_LIMIT): New macro.
2987 (try_scrolling): Use it when setting scroll_limit.
2988 Limit scrolling to 100 screen lines.
2989 (redisplay_window): Even when falling back on "recentering",
2990 position point in the window according to scroll-conservatively,
2991 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2992
2993 (try_scrolling): When point is above the window, allow searching
2994 as far as scroll_max, or one screenful, to compute vertical
2995 distance from PT to the scroll margin position. This prevents
2996 try_scrolling from unnecessarily failing when
2997 scroll-conservatively is set to a value slightly larger than the
2998 window height. Clean up the case of PT below the margin at bottom
2999 of window: scroll_max can no longer be INT_MAX. When aggressive
3000 scrolling is in use, don't let point enter the opposite scroll
3001 margin as result of the scroll.
3002 (syms_of_xdisp) <scroll-conservatively>: Document the
3003 threshold of 100 lines for never-recentering scrolling.
3004
3005 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3006
3007 * dispextern.h (move_it_by_lines):
3008 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3009 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3010 (message_log_check_duplicate): Remove parameters `prev_bol' and
3011 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3012 (redisplay_internal): Remove parameter `preserve_echo_area',
3013 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3014
3015 * indent.c (Fvertical_motion):
3016 * window.c (window_scroll_pixel_based, Frecenter):
3017 Don't pass `need_y_p' to `move_it_by_lines'.
3018
3019 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3020
3021 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3022 steal a few bits to be more compact.
3023 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3024 Remove unneeded casts.
3025
3026 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3027
3028 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3029
3030 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3031 binding" message (bug#7967).
3032
3033 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 Fix more problems found by GCC 4.6.0's static checks.
3036
3037 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3038 Remove unused local var.
3039
3040 * editfns.c (Fmessage_box): Remove unused local var.
3041
3042 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3043 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3044 Omit unused local vars.
3045 * window.c (shrink_windows): Omit unused local var.
3046 * menu.c (digest_single_submenu): Omit unused local var.
3047 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3048 Omit unused local var.
3049
3050 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3051 Don't assume string length fits in int.
3052 (keyremap_step, read_key_sequence): Use size_t for sizes.
3053 (read_key_sequence): Don't check last_real_key_start redundantly.
3054
3055 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3056 instead of alloca (Bug#8344).
3057
3058 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3059 (Fbacktrace_frame): Don't assume nframes fits in int.
3060
3061 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3062
3063 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3064 concerns.
3065
3066 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3067
3068 * cm.c (calccost): Turn while-do into do-while, for clarity.
3069
3070 * keyboard.c (syms_of_keyboard): Use the same style as later
3071 in this function when indexing through an array. This also
3072 works around GCC bug 48267.
3073
3074 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3075
3076 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3077
3078 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3079 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3080
3081 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3082 This avoids undefined behavior on integer overflow, and is a bit
3083 more convenient anyway since it is compared to a size_t variable.
3084
3085 Variadic C functions now count arguments with size_t, not int.
3086 This avoids an unnecessary limitation on 64-bit machines, which
3087 caused (substring ...) to crash on large vectors (Bug#8344).
3088 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3089 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3090 All variadic functions and their callers changed accordingly.
3091 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3092 * data.c (arith_driver, float_arith_driver): Likewise.
3093 * editfns.c (general_insert_function): Likewise.
3094 * eval.c (struct backtrace.nargs, interactive_p)
3095 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3096 (funcall_lambda, mark_backtrace): Likewise.
3097 * fns.c (concat): Likewise.
3098 * frame.c (x_set_frame_parameters): Likewise.
3099 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3100 0 if not found, not -1. All callers changed.
3101
3102 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3103 (stack_copy_size): Now size_t, not int.
3104 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3105
3106 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3107
3108 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3109 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3110 All callers changed.
3111
3112 * lisp.h (multibyte_char_to_unibyte):
3113 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3114 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3115 * character.h (CHAR_TO_BYTE8):
3116 * cmds.c (internal_self_insert):
3117 * editfns.c (general_insert_function):
3118 * keymap.c (push_key_description):
3119 * search.c (Freplace_match):
3120 * xdisp.c (message_dolog, set_message_1): All callers changed.
3121
3122 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3123
3124 * keyboard.c (safe_run_hook_funcall): New function.
3125 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3126 don't set the hook to nil, but remove the offending function instead.
3127 (Qcommand_hook_internal): Remove, unused.
3128 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3129 Vcommand_hook_internal.
3130
3131 * eval.c (enum run_hooks_condition): Remove.
3132 (funcall_nil, funcall_not): New functions.
3133 (run_hook_with_args): Call each function through a `funcall' argument.
3134 Remove `cond' argument, now redundant.
3135 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3136 (Frun_hook_with_args_until_failure): Adjust accordingly.
3137 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3138
3139 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3140
3141 * dispextern.h (string_buffer_position): Remove declaration.
3142
3143 * print.c (strout): Remove parameter `multibyte', unused since
3144 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3145
3146 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3147 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3148 All callers changed.
3149
3150 * w32.c (_wsa_errlist): Use braces for struct initializers.
3151
3152 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3153 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3154 All callers changed.
3155 (string_buffer_position): Likewise. Also, make static (it's never
3156 used outside xdisp.c).
3157 (cursor_row_p): Remove parameter `w', unused since
3158 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3159 (decode_mode_spec): Remove parameter `precision', introduced during
3160 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3161 All callers changed.
3162
3163 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3164
3165 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3166
3167 2011-03-27 Anders Lindgren <andlind@gmail.com>
3168
3169 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3170 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3171 (ns_update_auto_hide_menu_bar): New functions.
3172 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3173 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3174 ns_constrain_all_frames.
3175 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3176 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3177
3178 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3179
3180 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3181
3182 2011-03-27 Glenn Morris <rgm@gnu.org>
3183
3184 * syssignal.h: Replace RETSIGTYPE with void.
3185 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3186 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3187 Replace SIGTYPE with void everywhere.
3188 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3189 * s/template.h (SIGTYPE): Remove commented out definition.
3190
3191 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3192
3193 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3194 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3195
3196 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3197
3198 * w32.c (read_unc_volume): Use parameter `henum', instead of
3199 global variable `wget_enum_handle'.
3200
3201 * keymap.c (describe_vector): Remove parameters `indices' and
3202 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3203 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3204
3205 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3206
3207 * keyboard.c (timer_check): Remove parameter `do_it_now',
3208 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3209 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3210 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3211
3212 * keyboard.c (read_char):
3213 * w32menu.c (w32_menu_display_help):
3214 * xmenu.c (show_help_event, menu_help_callback):
3215 Adjust calls to `show_help_echo'.
3216
3217 * gtkutil.c (xg_maybe_add_timer):
3218 * keyboard.c (readable_events):
3219 * process.c (wait_reading_process_output):
3220 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3221
3222 * insdel.c (adjust_markers_gap_motion):
3223 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3224 (gap_left, gap_right): Don't call it.
3225
3226 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3227
3228 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3229 incurred during fontification.
3230
3231 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3234 (DEFVAR_PER_BUFFER): Don't pass it.
3235
3236 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3237 (scrolling_window): Don't pass it.
3238
3239 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3240
3241 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3242
3243 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3244 and `suffix'.
3245 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3246 of variables specific to SELinux and computation of `encoded_absname'.
3247
3248 * image.c (XPutPixel): Remove unused variable `height'.
3249
3250 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3251
3252 * unexw32.c (get_section_info): Remove unused variable `section'.
3253
3254 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3255 (system_process_attributes): Remove unused variable `sess'.
3256 (sys_read): Remove unused variable `err'.
3257
3258 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3259 (w32_wnd_proc): Remove unused variable `isdead'.
3260 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3261 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3262 (x_create_tip_frame): Remove unused variable `tem'.
3263
3264 * w32inevt.c (w32_console_read_socket):
3265 Remove unused variable `no_events'.
3266
3267 * w32term.c (x_draw_composite_glyph_string_foreground):
3268 Remove unused variable `width'.
3269
3270 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3271
3272 * w32term.c (x_set_glyph_string_clipping):
3273 Don't pass uninitialized region to CombineRgn.
3274
3275 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3276
3277 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3278 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3279 (Fx_close_connection): Remove unused variable `i'.
3280
3281 * w32font.c (w32font_draw): Return number of glyphs.
3282 (w32font_open_internal): Remove unused variable `i'.
3283 (w32font_driver): Add missing initializer.
3284
3285 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3286 (fill_in_menu): Remove unused variable `items_added'.
3287
3288 * w32term.c (last_mouse_press_frame): Remove static global variable.
3289 (w32_clip_to_row): Remove unused variable `f'.
3290 (x_delete_terminal): Remove unused variable `i'.
3291
3292 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3293 (NOTHING): Remove unused static global variable.
3294 (uniscribe_check_otf): Remove unused variable `table'.
3295 (uniscribe_font_driver): Add missing initializers.
3296
3297 2011-03-23 Julien Danjou <julien@danjou.info>
3298
3299 * term.c (Fsuspend_tty, Fresume_tty):
3300 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3301 * window.c (temp_output_buffer_show):
3302 * insdel.c (signal_before_change):
3303 * frame.c (Fhandle_switch_frame):
3304 * fileio.c (Fdo_auto_save):
3305 * emacs.c (Fkill_emacs):
3306 * editfns.c (save_excursion_restore):
3307 * cmds.c (internal_self_insert):
3308 * callint.c (Fcall_interactively):
3309 * buffer.c (Fkill_all_local_variables):
3310 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3311 Use Frun_hooks.
3312 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3313 unconditionnaly since it does the check itself.
3314
3315 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3316
3317 Fix more problems found by GCC 4.5.2's static checks.
3318
3319 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3320 the first time through the loop, since we know p0 < p1 then.
3321 This also avoids a gcc -Wstrict-overflow warning.
3322
3323 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3324 leading to a memory leak, possible in functions like
3325 load_charset_map_from_file that can allocate an unbounded number
3326 of objects (Bug#8318).
3327
3328 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3329 that could (at least in theory) be that large.
3330
3331 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3332 This is less likely to overflow, and avoids undefined behavior if
3333 overflow does occur. All callers changed. Use strtoul to scan
3334 for the unsigned long integer.
3335 (pint2hrstr): Simplify and tune code slightly.
3336 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3337
3338 * scroll.c (do_scrolling): Work around GCC bug 48228.
3339 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3340
3341 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3342 This also avoids a warning with gcc -Wstrict-overflow.
3343 (validate_x_resource_name): Simplify count usage.
3344 This also avoids a warning with gcc -Wstrict-overflow.
3345
3346 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3347 fail (Bug#8306).
3348
3349 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3350
3351 * process.c (Fmake_network_process): Use socklen_t, not int,
3352 where POSIX says socklen_t is required in portable programs.
3353 This fixes a porting bug on hosts like 64-bit HP-UX, where
3354 socklen_t is wider than int (Bug#8277).
3355 (Fmake_network_process, server_accept_connection):
3356 (wait_reading_process_output, read_process_output):
3357 Likewise.
3358
3359 * process.c: Rename or move locals to avoid shadowing.
3360 (list_processes_1, Fmake_network_process):
3361 (read_process_output_error_handler, exec_sentinel_error_handler):
3362 Rename or move locals.
3363 (Fmake_network_process): Define label "retry_connect" only if needed.
3364 (Fnetwork_interface_info): Fix pointer signedness.
3365 (process_send_signal): Add cast to avoid pointer signedness problem.
3366 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3367 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3368
3369 Make tparam.h and terminfo.c consistent.
3370 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3371 Include tparam.h instead, since it declares them.
3372 * cm.h (PC): Remove extern decl; tparam.h now does this.
3373 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3374 * terminfo.c: Include tparam.h, to check interfaces.
3375 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3376 (tparam): Adjust signature to match interface in tparam.h;
3377 this removes some undefined behavior. Check that outstring and len
3378 are zero, which they always are with Emacs.
3379 * tparam.h (PC, BC, UP): New extern decls.
3380
3381 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3382 (xftfont_open): Rename locals to avoid shadowing.
3383
3384 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3385 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3386 (OTF_TAG_SYM): Omit macro if not needed.
3387 (ftfont_list): Remove unused local.
3388 (get_adstyle_property, ftfont_pattern_entity):
3389 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3390 Rename locals to avoid shadowing.
3391
3392 * xfont.c (xfont_list_family): Mark var as initialized.
3393
3394 * xml.c (make_dom): Now static.
3395
3396 * composite.c (composition_compute_stop_pos): Rename local to
3397 avoid shadowing.
3398 (composition_reseat_it): Remove unused locals.
3399 (find_automatic_composition, composition_adjust_point): Likewise.
3400 (composition_update_it): Mark var as initialized.
3401 (find_automatic_composition): Mark vars as initialized,
3402 with a FIXME (Bug#8290).
3403
3404 character.h: Rename locals to avoid shadowing.
3405 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3406 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3407 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3408 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3409 to avoid shadowing.
3410
3411 * textprop.c (property_change_between_p): Remove; unused.
3412
3413 * intervals.c (interval_start_pos): Now static.
3414
3415 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3416
3417 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3418 Rename locals to avoid shadowing.
3419
3420 * sound.c (wav_play, au_play, Fplay_sound_internal):
3421 Fix pointer signedness.
3422 (alsa_choose_format): Remove unused local var.
3423 (wav_play): Initialize a variable to 0, to prevent undefined
3424 behavior (Bug#8278).
3425
3426 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3427
3428 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3429
3430 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3431 clobbering (Bug#8298).
3432 * sysdep.c (sys_subshell): Likewise.
3433 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3434
3435 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3436 This should get cleaned up, so that child_setup has the
3437 same signature on all platforms.
3438
3439 * callproc.c (call_process_cleanup): Now static.
3440 (relocate_fd): Rename locals to avoid shadowing.
3441
3442 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3443
3444 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3445 not to be necessary, and produces flickering.
3446
3447 2011-03-20 Glenn Morris <rgm@gnu.org>
3448
3449 * config.in: Remove file.
3450
3451 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3452
3453 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3454 are now in src/globals.h.
3455 (syms_of_minibuf): Remove spurious & from previous change.
3456
3457 2011-03-20 Leo <sdl.web@gmail.com>
3458
3459 * minibuf.c (completing-read-function): New variable.
3460 (completing-read-default): Rename from completing-read.
3461 (completing-read): Call completing-read-function.
3462
3463 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3464
3465 * xfaces.c (Fx_load_color_file):
3466 Read color file from absolute filename (bug#8250).
3467
3468 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3469
3470 * makefile.w32-in: Update dependencies.
3471
3472 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3473
3474 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3475
3476 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3477
3478 Fix more problems found by GCC 4.5.2's static checks.
3479
3480 * process.c (make_serial_process_unwind, send_process_trap):
3481 (sigchld_handler): Now static.
3482
3483 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3484 That way, the code declares only the vars that it needs.
3485 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3486 * s/cygwin.h (PTY_ITERATION): Likewise.
3487 * s/darwin.h (PTY_ITERATION): Likewise.
3488 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3489
3490 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3491 * process.c (allocate_pty): Don't declare stb unless it's needed.
3492
3493 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3494 (CONSTANTLIM): Remove; unused.
3495 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3496 Define only if needed.
3497
3498 * unexelf.c (unexec): Name an expression,
3499 to avoid gcc -Wbad-function-cast warning.
3500 Use a different way to cause a compilation error if anyone uses
3501 n rather than nn, a way that does not involve shadowing.
3502 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3503
3504 * deps.mk (unexalpha.o): Remove; unused.
3505
3506 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3507 * unexec.h: New file.
3508 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3509 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3510 Depend on unexec.h.
3511 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3512 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3513 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3514 Change as necessary to match prototype in unexec.h.
3515
3516 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3517 shadowing.
3518 (back_comment, skip_chars): Mark vars as initialized.
3519
3520 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3521 Rename locals to avoid shadowing.
3522
3523 * lread.c (read1): Rewrite so as not to use empty "else".
3524 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3525
3526 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3527
3528 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3529 warning when compiling print.c.
3530
3531 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3532 instead of using an uninitialized var.
3533 (font_sort_entities): Mark var as initialized.
3534
3535 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3536
3537 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3538 pointers to constants.
3539 (font_parse_fcname): Remove unused vars.
3540 (font_delete_unmatched): Now static.
3541 (font_get_spec): Remove; unused.
3542 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3543 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3544 Rename or move locals to avoid shadowing.
3545
3546 * fns.c (require_nesting_list, require_unwind): Now static.
3547 (Ffillarray): Rename locals to avoid shadowing.
3548
3549 * floatfns.c (domain_error2): Define only if needed.
3550 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3551
3552 * alloc.c (mark_backtrace): Move decl from here ...
3553 * lisp.h: ... to here, so that it can be checked.
3554
3555 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3556 (Fdefvar): Rewrite so as not to use empty "else".
3557 (lisp_indirect_variable): Name an expression,
3558 to avoid gcc -Wbad-function-cast warning.
3559 (Fdefvar): Rename locals to avoid shadowing.
3560
3561 * callint.c (quotify_arg, quotify_args): Now static.
3562 (Fcall_interactively): Rename locals to avoid shadowing.
3563 Use const pointer when appropriate.
3564
3565 * lisp.h (get_system_name, get_operating_system_release):
3566 Move decls here, to check interfaces.
3567 * process.c (get_operating_system_release): Move decl to lisp.h.
3568 * xrdb.c (get_system_name): Likewise.
3569 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3570 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3571 some of which prompt warnings from gcc -Wbad-function-cast.
3572 (Fformat_time_string, Fencode_time, Finsert_char):
3573 (Ftranslate_region_internal, Fformat):
3574 Rename or remove local vars to avoid shadowing.
3575 (Ftranslate_region_internal): Mark var as initialized.
3576
3577 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3578 avoid shadowing.
3579
3580 * lisp.h (eassert): Check that the argument compiles, even if
3581 ENABLE_CHECKING is not defined.
3582
3583 * data.c (Findirect_variable): Name an expression, to avoid
3584 gcc -Wbad-function-cast warning.
3585 (default_value, arithcompare, arith_driver, arith_error): Now static.
3586 (store_symval_forwarding): Rename local to avoid shadowing.
3587 (Fmake_variable_buffer_local, Fmake_local_variable):
3588 Mark variables as initialized.
3589 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3590
3591 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3592 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3593 Rename locals to avoid shadowing.
3594 (mark_stack): Move local variables into the #ifdef region where
3595 they're used.
3596 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3597 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3598 needed otherwise.
3599 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3600 (GC_STRING_CHARS): Remove; not used.
3601 (Fmemory_limit): Cast sbrk's returned value to char *.
3602
3603 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3604 avoids undefined behavior in theory.
3605
3606 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3607
3608 Use functions, not macros, for up- and down-casing (Bug#8254).
3609 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3610 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3611 to use the following functions instead of these macros.
3612 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3613 EMACS_INT, since callers assume the returned value fits in int.
3614 (upcase1): Likewise, for UPCASE_TABLE.
3615 (uppercasep, lowercasep, upcase): New static inline functions.
3616 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3617 the race-condition problem in the old DOWNCASE.
3618
3619 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3620 Rename locals to avoid shadowing.
3621 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3622 (regex_compile, re_search_2, re_match_2_internal):
3623 Remove unused local vars.
3624 (FREE_VAR): Rewrite so as not to use empty "else",
3625 which gcc can warn about.
3626 (regex_compile, re_match_2_internal): Mark locals as initialized.
3627 (RETALLOC_IF): Define only if needed.
3628 (WORDCHAR_P): Likewise. This one is never needed, but is used
3629 only in a comment talking about a compiler bug, so put inside
3630 the #if 0 of that comment.
3631 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3632 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3633 Remove; unused.
3634
3635 * search.c (boyer_moore): Rename locals to avoid shadowing.
3636 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3637 (PREV_CHAR_BOUNDARY): Likewise.
3638
3639 * search.c (simple_search): Remove unused var.
3640
3641 * dired.c (compile_pattern): Move decl from here ...
3642 * lisp.h: ... to here, so that it can be checked.
3643 (struct re_registers): New forward decl.
3644
3645 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3646
3647 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3648 All uses changed.
3649 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3650 Rename locals to avoid shadowing.
3651 (Fvertical_motion): Mark locals as initialized.
3652
3653 * casefiddle.c (casify_object, casify_region): Now static.
3654 (casify_region): Mark local as initialized.
3655
3656 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3657
3658 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3659 New macros, so that the caller can use some names other than
3660 gcpro1, gcpro2, etc.
3661 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3662 of the new macros.
3663 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3664 argument, for consistency with GCPRO2_VAR, etc: it is now the
3665 prefix of the variable, not the variable itself. All uses
3666 changed.
3667 * dired.c (directory_files_internal, file_name_completion):
3668 Rename locals to avoid shadowing.
3669
3670 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3671 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3672 dired.c's scmp function, had undefined behavior.
3673 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3674 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3675 * buffer.h: ... to here, because these macros use current_buffer,
3676 and the new implementation with inline functions needs to have
3677 current_buffer in scope now, rather than later when the macros
3678 are used.
3679 (downcase, upcase1): New static inline functions.
3680 (DOWNCASE, UPCASE1): Reimplement using these functions.
3681 This avoids undefined behavior in expressions like
3682 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3683 from race conditions in accessing the global variables
3684 case_temp1 and case_temp2.
3685 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3686 * lisp.h (case_temp1, case_temp2): Remove their decls.
3687 * character.h (ASCII_CHAR_P): Move from here ...
3688 * lisp.h: ... to here, so that the inline functions mentioned
3689 above can use them.
3690
3691 * dired.c (directory_files_internal_unwind): Now static.
3692
3693 * fileio.c (file_name_as_directory, directory_file_name):
3694 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3695 Now static.
3696 (file_name_as_directory): Use const pointers when appropriate.
3697 (Fexpand_file_name): Likewise. In particular, newdir might
3698 point at constant storage, so make it a const pointer.
3699 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3700 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3701 signedness issues.
3702 (Fset_file_times, Finsert_file_contents, auto_save_error):
3703 Rename locals to avoid shadowing.
3704
3705 * minibuf.c (choose_minibuf_frame_1): Now static.
3706 (Ftry_completion, Fall_completions): Rename or remove locals
3707 to avoid shadowing.
3708
3709 * marker.c (bytepos_to_charpos): Remove; unused.
3710
3711 * lisp.h (verify_bytepos, count_markers): New decls,
3712 so that gcc does not warn that these functions aren't declared.
3713
3714 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3715 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3716 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3717 (copy_text): Remove unused local var.
3718
3719 * filelock.c (within_one_second): Now static.
3720 (lock_file_1): Rename local to avoid shadowing.
3721
3722 * buffer.c (fix_overlays_before): Mark locals as initialized.
3723 (fix_start_end_in_overlays): Likewise. This function should be
3724 simplified by using pointers-to-pointers, but that's a different
3725 matter.
3726 (switch_to_buffer_1): Now static.
3727 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3728 (report_overlay_modification): Rename locals to avoid shadowing.
3729
3730 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3731 Fix pointer signedness issue.
3732 (sys_subshell): Mark local as volatile if checking for lint,
3733 to suppress a gcc -Wclobbered warning that does not seem to be right.
3734 (MAXPATHLEN): Define only if needed.
3735
3736 * process.c (serial_open, serial_configure): Move decls from here ...
3737 * systty.h: ... to here, so that they can be checked.
3738
3739 * fns.c (get_random, seed_random): Move extern decls from here ...
3740 * lisp.h: ... to here, so that they can be checked.
3741
3742 * sysdep.c (reset_io): Now static.
3743 (wait_for_termination_signal): Remove; unused.
3744
3745 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3746 (copy_keymap_item, append_key, push_text_char_description):
3747 Now static.
3748 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3749 (DENSE_TABLE_SIZE): Remove; unused.
3750 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3751 (describe_map_tree):
3752 Rename locals to avoid shadowing.
3753
3754 * keyboard.c: Declare functions static if they are not used elsewhere.
3755 (echo_char, echo_dash, cmd_error, top_level_2):
3756 (poll_for_input, handle_async_input): Now static.
3757 (read_char, kbd_buffer_get_event, make_lispy_position):
3758 (make_lispy_event, make_lispy_movement, apply_modifiers):
3759 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3760 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3761 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3762 (read_key_sequence, read_char): Mark locals as initialized.
3763 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3764
3765 * keyboard.h (make_ctrl_char): New decl.
3766 (mark_kboards): Move decl here ...
3767 * alloc.c (mark_kboards): ... from here.
3768
3769 * lisp.h (force_auto_save_soon): New decl.
3770
3771 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3772 (DEFINE_DUMMY_FUNCTION): New macro.
3773 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3774 Use it.
3775 (main): Add casts to avoid warnings
3776 if GCC considers string literals to be constants.
3777
3778 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3779
3780 * dbusbind.c: Pointer signedness fixes.
3781 (xd_signature, xd_append_arg, xd_initialize):
3782 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3783 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3784 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3785 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3786
3787 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3788 if GCC considers string literals to be constants.
3789 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3790
3791 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3792
3793 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3794 (print_preprocess, print_object): New macro to fix last change.
3795
3796 * print.c (print_preprocess): Don't forget font objects.
3797
3798 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3799
3800 * emacs.c (USAGE3): Doc fixes.
3801
3802 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3805 structure.
3806
3807 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3808
3809 * lisp.h (VWindow_system, Qfile_name_history):
3810 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3811 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3812 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3813
3814 * w32select.c: Don't #include "keyboard.h".
3815 (run_protected): Add extern declaration for waiting_for_input.
3816
3817 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3818 * w32console.c (detect_input_pending, read_input_pending)
3819 (encode_terminal_code):
3820 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3821 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3822 (w32_system_caret_y, Qfile_name_history):
3823 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3824 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3825 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3826 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3827 * w32proc.c (Qlocal, report_file_error):
3828 * w32term.c (Vwindow_system, updating_frame):
3829 * w32uniscribe.c (initialized, uniscribe_font_driver):
3830 Remove unneeded extern declarations.
3831
3832 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3833
3834 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3835
3836 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3837
3838 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3839 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3840 These macros can no longer be used for assignment.
3841
3842 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3843 Assign struct members directly, instead of using BUF_BEGV etc.
3844 (record_buffer_markers, fetch_buffer_markers): New functions for
3845 recording and fetching special buffer markers.
3846 (set_buffer_internal_1, set_buffer_temp): Use them.
3847
3848 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3849
3850 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3851
3852 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3853 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3854
3855 * xdisp.c (hscroll_window_tree):
3856 (reconsider_clip_changes): Use PT instead of BUF_PT.
3857
3858 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3859
3860 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3861 $(EMACS_ROOT)/lib/intprops.h.
3862
3863 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3864
3865 Fix more problems found by GCC 4.5.2's static checks.
3866
3867 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3868 to unsigned char * to avoid compiler diagnostic.
3869 (xg_free_frame_widgets): Make it clear that a local variable is
3870 needed only if USE_GTK_TOOLTIP.
3871 (gdk_window_get_screen): Make it clear that this macro is needed
3872 only if USE_GTK_TOOLTIP.
3873 (int_gtk_range_get_value): New function, which avoids a diagnostic
3874 from gcc -Wbad-function-cast.
3875 (xg_set_toolkit_scroll_bar_thumb): Use it.
3876 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3877 diagnostic from gcc -Wbad-function-cast.
3878 (get_utf8_string, xg_get_file_with_chooser):
3879 Rename locals to avoid shadowing.
3880 (create_dialog): Move locals to avoid shadowing.
3881
3882 * xgselect.c (xg_select): Remove unused var.
3883
3884 * image.c (four_corners_best): Mark locals as initialized.
3885 (gif_load): Initialize transparent_p to zero (Bug#8238).
3886 Mark another local as initialized.
3887 (my_png_error, my_error_exit): Mark with NO_RETURN.
3888
3889 * image.c (clear_image_cache): Now static.
3890 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3891 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3892 (x_edge_detection): Remove unnecessary cast that
3893 gcc -Wbad-function-cast diagnoses.
3894 (gif_load): Fix pointer signedness.
3895 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3896 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3897
3898 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 Improve quality of tests for time stamp overflow.
3901 For example, without this patch (encode-time 0 0 0 1 1
3902 1152921504606846976) returns the obviously-bogus value (-948597
3903 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3904 reports time overflow. See
3905 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3906 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3907 * editfns.c: Include limits.h and intprops.h.
3908 (TIME_T_MIN, TIME_T_MAX): New macros.
3909 (time_overflow): Move earlier, to before first use.
3910 (hi_time, lo_time): New functions, for an accurate test for
3911 out-of-range times.
3912 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3913 (Fget_internal_run_time): Don't assume time_t fits in int.
3914 (make_time): Use list2 instead of Fcons twice.
3915 (Fdecode_time): More accurate test for out-of-range times.
3916 (check_tm_member): New function.
3917 (Fencode_time): Use it, to test for out-of-range times.
3918 (lisp_time_argument): Don't rely on undefined left-shift and
3919 right-shift behavior when checking for time stamp overflow.
3920
3921 * editfns.c (time_overflow): New function, refactoring common code.
3922 (Fformat_time_string, Fdecode_time, Fencode_time):
3923 (Fcurrent_time_string): Use it.
3924
3925 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3926 * dired.c (make_time): Move to ...
3927 * editfns.c (make_time): ... here.
3928 * systime.h: Note the move.
3929
3930 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3931
3932 * fringe.c (update_window_fringes): Remove unused variables.
3933
3934 * unexmacosx.c (copy_data_segment): Also copy __got section.
3935 (Bug#8223)
3936
3937 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3938
3939 * termcap.c [MSDOS]: Include "msdos.h".
3940 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3941 Constify `char *' arguments and their references according to
3942 prototypes in tparam.h.
3943
3944 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3945
3946 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3947 Adapt all references accordingly.
3948
3949 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3950
3951 2011-03-11 Tom Tromey <tromey@redhat.com>
3952
3953 * buffer.c (syms_of_buffer): Remove obsolete comment.
3954
3955 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3956
3957 * termhooks.h (encode_terminal_code): Declare prototype.
3958
3959 * msdos.c (encode_terminal_code): Don't declare prototype.
3960
3961 * term.c (encode_terminal_code): Now external again, used by
3962 w32console.c and msdos.c.
3963
3964 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3965 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3966
3967 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3968
3969 Fix some minor problems found by GCC 4.5.2's static checks.
3970
3971 * fringe.c (update_window_fringes): Mark locals as initialized
3972 (Bug#8227).
3973 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3974
3975 * alloc.c (mark_fringe_data): Move decl from here ...
3976 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3977 to check its interface.
3978 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3979
3980 * fontset.c (free_realized_fontset): Now static.
3981 (Fset_fontset_font): Rename local to avoid shadowing.
3982 (fontset_font): Mark local as initialized.
3983 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3984
3985 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3986
3987 * xselect.c (x_disown_buffer_selections): Remove; not used.
3988 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3989 (x_own_selection, Fx_disown_selection_internal): Rename locals
3990 to avoid shadowing.
3991 (x_handle_dnd_message): Remove local to avoid shadowing.
3992
3993 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3994 so that the caller can use some name other than gcpro1.
3995 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3996 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3997 (Fx_backspace_delete_keys_p):
3998 Use them to avoid shadowing, and rename vars to avoid shadowing.
3999 (x_decode_color, x_set_name, x_window): Now static.
4000 (Fx_create_frame): Add braces to silence GCC warning.
4001 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4002 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4003 Remove unused locals.
4004 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4005 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4006 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4007 macros.
4008
4009 * xterm.h (x_mouse_leave): New decl.
4010
4011 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4012 Remove unused functions.
4013 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4014 (x_calc_absolute_position): Now static.
4015 (XTread_socket): Don't define label "out" unless it's used.
4016 Don't declare local "event" unless it's used.
4017 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4018 unless they are used.
4019 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4020 (x_fatal_error_signal): Remove; not used.
4021 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4022 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4023 (x_error_catcher, x_connection_closed, x_error_handler):
4024 (x_error_quitter, xembed_send_message, x_iconify_frame):
4025 (my_log_handler): Rename locals to avoid shadowing.
4026 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4027 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4028
4029 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4030 Rename or move locals to avoid shadowing.
4031 (tty_defined_color, merge_face_heights): Now static.
4032 (free_realized_faces_for_fontset): Remove; not used.
4033 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4034 does not deduce is never used uninitialized.
4035 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4036 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4037
4038 * terminal.c (store_terminal_param): Now static.
4039
4040 * xmenu.c (menu_highlight_callback): Now static.
4041 (set_frame_menubar): Remove unused local.
4042 (xmenu_show): Rename parameter to avoid shadowing.
4043 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4044 since they might point to immutable storage.
4045 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4046 since it's unused otherwise.
4047
4048 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4049 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4050 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4051 avoids a gcc -Wuninitialized diagnostic.
4052 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4053 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4054 does not deduce are never used uninitialized.
4055
4056 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4057
4058 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4059 * window.c (window_loop, size_window):
4060 (run_window_configuration_change_hook, enlarge_window): Likewise.
4061
4062 * window.c (display_buffer): Now static.
4063 (size_window): Mark variables that gcc -Wuninitialized
4064 does not deduce are never used uninitialized.
4065 * window.h (check_all_windows): New decl, to forestall
4066 gcc -Wmissing-prototypes diagnostic.
4067 * dispextern.h (bidi_dump_cached_states): Likewise.
4068
4069 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4070 shadowing.
4071 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4072 Include <limits.h>.
4073 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4074 and to avoid gcc -Wuninitialized warning.
4075 (load_charset_map): Mark variables that gcc -Wuninitialized
4076 does not deduce are never used uninitialized.
4077 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4078
4079 * coding.c (coding_set_source, coding_set_destination):
4080 Use "else { /* comment */ }" rather than "else /* comment */;"
4081 for clarity, and to avoid gcc -Wempty-body warning.
4082 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4083 a block, when the outer 'i' will do.
4084 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4085 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4086 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4087 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4088 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4089 Rename locals to avoid shadowing.
4090 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4091 * coding.c (emacs_mule_char, encode_invocation_designation):
4092 Now static, since they're not used elsewhere.
4093 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4094 (decode_coding_object, encode_coding_object, detect_coding_system):
4095 (decode_coding_emacs_mule): Mark variables that gcc
4096 -Wuninitialized does not deduce are never used uninitialized.
4097 (detect_coding_iso_2022): Initialize a local variable that might
4098 be used uninitialized. Leave a FIXME because it's not clear that
4099 this initialization is needed. (Bug#8211)
4100 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4101 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4102 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4103 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4104 Remove unused macros.
4105
4106 * category.c (hash_get_category_set): Remove unused local var.
4107 (copy_category_table): Now static, since it's not used elsewhere.
4108 * character.c (string_count_byte8): Likewise.
4109
4110 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4111 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4112
4113 * chartab.c (copy_sub_char_table): Now static, since it's not used
4114 elsewhere.
4115 (sub_char_table_ref_and_range, char_table_ref_and_range):
4116 Rename locals to avoid shadowing.
4117 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4118
4119 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4120 (BIDI_BOB): Remove unused macro.
4121
4122 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4123 deduce are never used uninitialized.
4124 * term.c (encode_terminal_code): Likewise.
4125
4126 * term.c (encode_terminal_code): Now static. Remove unused local.
4127
4128 * tparam.h: New file.
4129 * term.c, tparam.h: Include it.
4130 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4131 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4132 Move these decls to tparam.h, and make them agree with what
4133 is actually in tparam.c. The previous trick of using incompatible
4134 decls in different modules does not conform to the C standard.
4135 All callers of tparam changed to use tparam's actual API.
4136 * tparam.c (tparam1, tparam, tgoto):
4137 Use const pointers where appropriate.
4138
4139 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4140 * cm.h (struct cm): Likewise.
4141 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4142 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4143 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4144 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4145 (turn_on_face, init_tty): Likewise.
4146 * termchar.h (struct tty_display_info): Likewise.
4147
4148 * term.c (term_mouse_position): Rename local to avoid shadowing.
4149
4150 * alloc.c (mark_ttys): Move decl from here ...
4151 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4152
4153 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4154
4155 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4156
4157 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4158
4159 * search.c (compile_pattern_1): Remove argument regp, unused since
4160 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4161 (compile_pattern): Don't pass it.
4162
4163 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4164
4165 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4166 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4167 for ! HAVE_GTK3.
4168 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4169
4170 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4171
4172 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4173 gdk_window_get_screen, gdk_window_get_geometry,
4174 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4175 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4176 (xg_get_pixbuf_from_pixmap): New function.
4177 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4178 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4179 Call xg_get_pixbuf_from_pixmap instead of
4180 gdk_pixbuf_get_from_drawable.
4181 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4182 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4183 (xg_check_special_colors): Use GtkStyleContext and its functions
4184 for HAVE_GTK3.
4185 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4186 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4187 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4188 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4189 Call gtk_widget_get_preferred_size.
4190 (xg_frame_resized): gdk_window_get_geometry only takes 5
4191 parameters.
4192 (xg_win_to_widget, xg_event_is_for_menubar):
4193 Call gdk_x11_window_lookup_for_display.
4194 (xg_set_widget_bg): New function.
4195 (delete_cb): New function.
4196 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4197 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4198 (xg_set_background_color): Call xg_set_widget_bg.
4199 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4200 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4201 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4202 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4203 if ! HAVE_GTK3.
4204 (update_frame_tool_bar): Call gtk_widget_hide.
4205 (xg_initialize): Use GDK_KEY_g.
4206
4207 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4208 if ! HAVE_GTK3
4209 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4210
4211 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4212 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4213 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4214
4215 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4216
4217 * w32xfns.c (select_palette): Check success of RealizePalette against
4218 GDI_ERROR, not zero.
4219
4220 See ChangeLog.11 for earlier changes.
4221
4222 ;; Local Variables:
4223 ;; coding: utf-8
4224 ;; End:
4225
4226 Copyright (C) 2011 Free Software Foundation, Inc.
4227
4228 This file is part of GNU Emacs.
4229
4230 GNU Emacs is free software: you can redistribute it and/or modify
4231 it under the terms of the GNU General Public License as published by
4232 the Free Software Foundation, either version 3 of the License, or
4233 (at your option) any later version.
4234
4235 GNU Emacs is distributed in the hope that it will be useful,
4236 but WITHOUT ANY WARRANTY; without even the implied warranty of
4237 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4238 GNU General Public License for more details.
4239
4240 You should have received a copy of the GNU General Public License
4241 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.