]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* alloc.c (allocate_pseudovector): Don't use EMACS_INT when int would do.
[gnu-emacs] / src / ChangeLog
1 2011-06-08 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c: Use EMACS_INT, not int, to count objects.
4 (total_conses, total_markers, total_symbols, total_vector_size)
5 (total_free_conses, total_free_markers, total_free_symbols)
6 (total_free_floats, total_floats, total_free_intervals, total_intervals)
7 (total_strings, total_free_strings):
8 Now EMACS_INT, not int. All uses changed.
9 (Fgarbage_collect): Compute overall total using a double, so that
10 integer overflow is less likely to be a problem. Check for overflow
11 when converting back to an integer.
12 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
14 These were 'int' variables that could overflow on 64-bit hosts;
15 they were never used, so remove them instead of repairing them.
16 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
17 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
18 Previously, this ceilinged at INT_MAX, but that doesn't work on
19 64-bit machines.
20 (allocate_pseudovector): Don't use EMACS_INT when int would do.
21
22 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
23 (allocate_vectorlike): Check for ptrdiff_t overflow.
24 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
25 when a (possibly-narrower) signed value would do just as well.
26 We prefer using signed arithmetic, to avoid comparison confusion.
27
28 * alloc.c: Catch some string size overflows that we were missing.
29 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
30 for convenience in STRING_BYTES_MAX.
31 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
32 The definition here is exact; the one in lisp.h was approximate.
33 (allocate_string_data): Check for string overflow. This catches
34 some instances we weren't catching before. Also, it catches
35 size_t overflow on (unusual) hosts where SIZE_MAX <= min
36 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
37 and ptrdiff_t and EMACS_INT are both 64 bits.
38
39 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
40 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
41 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
42
43 2011-06-07 Paul Eggert <eggert@cs.ucla.edu>
44
45 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
46
47 * alloc.c (Fmake_string): Check for out-of-range init.
48
49 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
50
51 * fns.c (Fputhash): Document return value.
52
53 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
54
55 * image.c (gif_load): Implement gif89a spec "no disposal" method.
56
57 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
58
59 Cons<->int and similar integer overflow fixes (Bug#8794).
60
61 Check for overflow when converting integer to cons and back.
62 * charset.c (Fdefine_charset_internal, Fdecode_char):
63 Use cons_to_unsigned to catch overflow.
64 (Fencode_char): Use INTEGER_TO_CONS.
65 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
66 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
67 * data.c (long_to_cons, cons_to_long): Remove.
68 (cons_to_unsigned, cons_to_signed): New functions.
69 These signal an error for invalid or out-of-range values.
70 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
71 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
72 * font.c (Ffont_variation_glyphs):
73 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
74 * lisp.h: Include <intprops.h>.
75 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
76 (cons_to_signed, cons_to_unsigned): New decls.
77 (long_to_cons, cons_to_long): Remove decls.
78 * undo.c (record_first_change): Use INTEGER_TO_CONS.
79 (Fprimitive_undo): Use CONS_TO_INTEGER.
80 * xfns.c (Fx_window_property): Likewise.
81 * xselect.c: Include <limits.h>.
82 (x_own_selection, selection_data_to_lisp_data):
83 Use INTEGER_TO_CONS.
84 (x_handle_selection_request, x_handle_selection_clear)
85 (x_get_foreign_selection, Fx_disown_selection_internal)
86 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
87 (lisp_data_to_selection_data): Use cons_to_unsigned.
88 (x_fill_property_data): Use cons_to_signed.
89 Report values out of range.
90
91 Check for buffer and string overflow more precisely.
92 * buffer.h (BUF_BYTES_MAX): New macro.
93 * lisp.h (STRING_BYTES_MAX): New macro.
94 * alloc.c (Fmake_string):
95 * character.c (string_escape_byte8):
96 * coding.c (coding_alloc_by_realloc):
97 * doprnt.c (doprnt):
98 * editfns.c (Fformat):
99 * eval.c (verror):
100 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
101 since they may not be the same number.
102 * editfns.c (Finsert_char):
103 * fileio.c (Finsert_file_contents):
104 Likewise for BUF_BYTES_MAX.
105
106 * image.c: Use ptrdiff_t, not int, for sizes.
107 (slurp_file): Switch from int to ptrdiff_t.
108 All uses changed.
109 (slurp_file): Check that file size fits in both size_t (for
110 malloc) and ptrdiff_t (for sanity and safety).
111
112 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
113 if b->modtime has its maximal value.
114
115 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
116
117 Don't assume time_t can fit into int.
118 * buffer.h (struct buffer.modtime): Now time_t, not int.
119 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
120 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
121
122 Minor fixes for signed vs unsigned integers.
123 * character.h (MAYBE_UNIFY_CHAR):
124 * charset.c (maybe_unify_char):
125 * keyboard.c (read_char, reorder_modifiers):
126 XINT -> XFASTINT, since the integer must be nonnegative.
127 * ftfont.c (ftfont_spec_pattern):
128 * keymap.c (access_keymap, silly_event_symbol_error):
129 XUINT -> XFASTINT, since the integer must be nonnegative.
130 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
131 since it makes no difference and we prefer signed.
132 * keyboard.c (record_char): Use XUINT when all the neighbors do.
133 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
134 nonnegative.
135
136 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
137
138 * window.h (Fwindow_frame): Declare.
139
140 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
141
142 * alloc.c: Simplify handling of large-request failures (Bug#8800).
143 (SPARE_MEMORY): Always define.
144 (LARGE_REQUEST): Remove.
145 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
146
147 2011-06-06 Martin Rudalics <rudalics@gmx.at>
148
149 * lisp.h: Move EXFUNS for Fframe_root_window,
150 Fframe_first_window and Fset_frame_selected_window to window.h.
151
152 * window.h: Move EXFUNS for Fframe_root_window,
153 Fframe_first_window and Fset_frame_selected_window here from
154 lisp.h.
155
156 * frame.c (Fwindow_frame, Fframe_first_window)
157 (Fframe_root_window, Fframe_selected_window)
158 (Fset_frame_selected_window): Move to window.c.
159 (Factive_minibuffer_window): Move to minibuf.c.
160 (Fother_visible_frames_p): New function.
161
162 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
163
164 * window.c (decode_window, decode_any_window): Move up in code.
165 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
166 (inhibit_frame_unsplittable): Remove unused variable.
167 (Fwindow_buffer): Move up and rewrite doc-string.
168 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
169 (Fwindow_prev): New functions.
170 (Fwindow_frame): Move here from frame.c. Accept any window as
171 argument.
172 (Fframe_root_window, Fframe_first_window)
173 (Fframe_selected_window): Move here from frame.c. Accept frame
174 or arbitrary window as argument. Update doc-strings.
175 (Fminibuffer_window): Move up in code.
176 (Fwindow_minibuffer_p): Move up in code and simplify.
177 (Fset_frame_selected_window): Move here from frame.c.
178 Marginal rewrite.
179 (Fselected_window, select_window, Fselect_window): Move up in
180 code. Minor doc-string fixes.
181
182 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
183
184 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
185 Do not assume that spare memory exists; that assumption is valid
186 only if SYSTEM_MALLOC.
187 (LARGE_REQUEST): New macro, so that the issue of large requests
188 is separated from the issue of spare memory.
189
190 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
191
192 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
193 format. (Bug#8806)
194
195 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
196
197 * xfns.c (x_set_scroll_bar_default_width): Move declarations
198 before statements.
199
200 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
201
202 * gtkutil.c (xg_get_default_scrollbar_width): New function.
203
204 * gtkutil.h: Declare xg_get_default_scrollbar_width.
205
206 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
207 min width by calling x_set_scroll_bar_default_width (Bug#8505).
208
209 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
210
211 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
212
213 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
214
215 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
216 (x_clipboard_manager_save): Add return value.
217 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
218 New error handlers.
219 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
220 Obey Vx_select_enable_clipboard_manager. Catch errors in
221 x_clipboard_manager_save (Bug#8779).
222 (Vx_select_enable_clipboard_manager): New variable.
223 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
224
225 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
226
227 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
228
229 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
230
231 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
232 in the current matrix if keep_current_p is non-zero.
233
234 2011-06-04 Eli Zaretskii <eliz@gnu.org>
235
236 * bidi.c (bidi_level_of_next_char): Fix last change.
237
238 2011-06-03 Eli Zaretskii <eliz@gnu.org>
239
240 Support bidi reordering of text covered by display properties.
241
242 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
243 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
244 (bidi_cache_search, bidi_cache_iterator_state)
245 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
246 (bidi_level_of_next_char, bidi_move_to_visually_next):
247 Support character positions inside a run of characters covered by a
248 display string.
249 (bidi_paragraph_init, bidi_resolve_explicit_1)
250 (bidi_level_of_next_char): Call bidi_fetch_char and
251 bidi_fetch_char_advance instead of FETCH_CHAR and
252 FETCH_CHAR_ADVANCE.
253 (bidi_init_it): Initialize new members.
254 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
255 definitions.
256 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
257 instead of using explicit *_CHAR codes.
258 (bidi_resolve_explicit, bidi_resolve_weak):
259 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
260 bidirectional text is supported only in multibyte buffers.
261 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
262 it to initialize the frame_window_p member of struct bidi_it.
263 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
264 (bidi_resolve_explicit, bidi_resolve_weak)
265 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
266 bidi_it->nchars is non-positive.
267 (bidi_level_of_next_char): Don't try to lookup the cache for the
268 next/previous character if nothing is cached there yet, or if we
269 were just reseat()'ed to a new position.
270
271 * xdisp.c (set_cursor_from_row): Set start and stop points
272 according to the row's direction when priming the loop that looks
273 for the glyph on which to display cursor.
274 (single_display_spec_intangible_p): Function deleted.
275 (display_prop_intangible_p): Reimplement to call
276 handle_display_spec instead of single_display_spec_intangible_p.
277 Accept 3 additional arguments needed by handle_display_spec.
278 This fixes incorrect cursor motion across display property with complex
279 values: lists, `(when COND...)' forms, etc.
280 (single_display_spec_string_p): Support property values that are
281 lists with the argument STRING its top-level element.
282 (display_prop_string_p): Fix the condition for processing a
283 property that is a list to be consistent with handle_display_spec.
284 (handle_display_spec): New function, refactored from the
285 last portion of handle_display_prop.
286 (compute_display_string_pos): Accept additional argument
287 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
288 value of a `display' property is a "replacing spec".
289 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
290 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
291 the display property, but just return a value indicating whether
292 the display property will replace the characters it covers.
293 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
294 frame_window_p members of struct bidi_it.
295 (compute_display_string_pos, compute_display_string_end):
296 New functions.
297 (push_it): Accept second argument POSITION, where pop_it should
298 jump to continue iteration.
299 (reseat_1): Initialize bidi_it.disp_pos.
300
301 * keyboard.c (adjust_point_for_property): Adjust the call to
302 display_prop_intangible_p to its new signature.
303
304 * dispextern.h (struct bidi_it): New member frame_window_p.
305 (bidi_init_it): Update prototypes.
306 (display_prop_intangible_p): Update prototype.
307 (compute_display_string_pos, compute_display_string_end):
308 Declare prototypes.
309 (struct bidi_it): New members nchars and disp_pos. ch_len is now
310 EMACS_INT.
311
312 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
313
314 Malloc failure behavior now depends on size of allocation.
315 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
316 * lisp.h: Change signatures accordingly.
317 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
318 All callers changed. (Bug#8762)
319
320 * gnutls.c: Use Emacs's memory allocators.
321 Without this change, the gnutls library would invoke malloc etc.
322 directly, which causes problems on non-SYNC_INPUT hosts, and which
323 runs afoul of improving memory_full behavior. (Bug#8761)
324 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
325 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
326 xfree instead of the default malloc, realloc, free.
327 (Fgnutls_boot): No need to check for memory allocation failure,
328 since xmalloc does that for us.
329
330 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
331 * category.c (hash_get_category_set):
332 * ccl.c (ccl_driver):
333 * charset.c (Fdefine_charset_internal):
334 * charset.h (struct charset.hash_index):
335 * composite.c (get_composition_id, gstring_lookup_cache)
336 (composition_gstring_put_cache):
337 * composite.h (struct composition.hash_index):
338 * dispextern.h (struct image.hash):
339 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
340 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
341 (hashfn_equal, hashfn_user_defined, make_hash_table)
342 (maybe_resize_hash_table, hash_lookup, hash_put)
343 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
344 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
345 (Fsxhash, Fgethash, Fputhash, Fmaphash):
346 * image.c (make_image, search_image_cache, lookup_image)
347 (xpm_put_color_table_h):
348 * lisp.h (struct Lisp_Hash_Table):
349 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
350 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
351 for hashes and hash indexes, instead of 'unsigned' and 'int'.
352 * alloc.c (allocate_vectorlike):
353 Check for overflow in vector size calculations.
354 * ccl.c (ccl_driver):
355 Check for overflow when converting EMACS_INT to int.
356 * fns.c, image.c: Remove unnecessary static decls that would otherwise
357 need to be updated by these changes.
358 * fns.c (make_hash_table, maybe_resize_hash_table):
359 Check for integer overflow with large hash tables.
360 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
361 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
362 (SXHASH_REDUCE): New macro.
363 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
364 Use it instead of discarding useful hash info with large hash values.
365 (sxhash_float): New function.
366 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
367 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
368 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
369 Rewrite to use FIXNUM_BITS, as this simplifies things.
370 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
371 Adjust signatures to match updated version of code.
372 (consing_since_gc): Now EMACS_INT, since a single hash table can
373 use more than INT_MAX bytes.
374
375 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
376
377 Make it possible to build with GCC-4.6+ -O2 -flto.
378
379 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
380
381 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
382
383 * minibuf.c (get_minibuffer, read_minibuf_unwind):
384 Call minibuffer-inactive-mode.
385
386 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
387
388 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
389 Update dependencies.
390
391 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
392
393 * data.c (init_data): Remove code for UTS, this system is not
394 supported anymore.
395
396 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
397
398 Don't force ./temacs to start in terminal mode.
399
400 * frame.c (make_initial_frame): Initialize faces in all cases, not
401 only when CANNOT_DUMP is defined.
402 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
403
404 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
405
406 * dispnew.c (add_window_display_history): Use const for the string
407 pointer. Remove declaration, not needed.
408
409 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
410
411 Use 'inline', not 'INLINE'.
412 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
413 * alloc.c, fontset.c (INLINE): Remove.
414 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
415 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
416 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
417 * gmalloc.c (register_heapinfo): Use inline unconditionally.
418 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
419
420 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
421
422 Make it possible to run ./temacs.
423
424 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
425 syms_of_callproc does the same thing. Remove test for
426 "initialized", do it in the caller.
427 * emacs.c (main): Avoid calling set_initial_environment when dumping.
428
429 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
430
431 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
432 (read_minibuf): Use get_minibuffer.
433 (syms_of_minibuf): Use DEFSYM.
434 (Qmetadata): New var.
435 * data.c (Qbuffer): Don't make it static.
436 (syms_of_data): Use DEFSYM.
437
438 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
439
440 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
441 (CCL_CODE_MIN): New macro.
442
443 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
444
445 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
446
447 * eval.c (Qdebug): Now static.
448 * lisp.h (Qdebug): Remove decl. This reverts a part of the
449 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
450 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
451
452 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
453
454 * image.c: Various fixes to ImageMagick code comments.
455 (Fimagemagick_types): Doc fix.
456
457 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
458
459 Minor fixes prompted by GCC 4.6.0 warnings.
460
461 * xselect.c (converted_selections, conversion_fail_tag): Now static.
462
463 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
464 (x_clipboard_manager_save_all): Move extern decl to ...
465 * xterm.h: ... here, so that it can be checked for consistency.
466
467 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
468
469 * xselect.c (x_clipboard_manager_save_frame)
470 (x_clipboard_manager_save_all): New functions.
471 (Fx_clipboard_manager_save): Lisp function deleted.
472
473 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
474 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
475
476 * xterm.h: Update prototype.
477
478 2011-05-28 William Xu <william.xwl@gmail.com>
479
480 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
481 exiting (Bug#8239).
482
483 2011-05-28 Jim Meyering <meyering@redhat.com>
484
485 Avoid a sign-extension bug in crypto_hash_function.
486 * fns.c (to_uchar): Define.
487 (crypto_hash_function): Use it to convert some newly-signed
488 variables to unsigned, to avoid sign-extension bugs. For example,
489 without this change, (md5 "truc") would evaluate to
490 45723a2aff78ff4fff7fff1114760e62 rather than the expected
491 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
492 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
493
494 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
495
496 Integer overflow fixes.
497
498 * dbusbind.c: Serial number integer overflow fixes.
499 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
500 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
501 to hold a serial number that is too large for a fixnum.
502 (Fdbus_method_return_internal, Fdbus_method_error_internal):
503 Check for serial numbers out of range. Decode any serial number
504 that was so large that it became a float. (Bug#8722)
505
506 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
507 (Fdbus_call_method, Fdbus_call_method_asynchronously):
508 Use XFASTINT rather than XUINT when numbers are nonnegative.
509 (xd_append_arg, Fdbus_method_return_internal):
510 (Fdbus_method_error_internal): Likewise. Also, for unsigned
511 arguments, check that Lisp number is nonnegative, rather than
512 silently wrapping negative numbers around. (Bug#8722)
513 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
514 (Bug#8722)
515
516 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
517
518 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
519
520 ccl: add integer overflow checks
521 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
522 (IN_INT_RANGE): New macros.
523 (ccl_driver): Use them to check for integer overflow when
524 decoding a CCL program. Many of the new checks are whether XINT (x)
525 fits in int; it doesn't always, on 64-bit hosts. The new version
526 doesn't catch all possible integer overflows, but it's an
527 improvement. (Bug#8719)
528
529 * alloc.c (make_event_array): Use XINT, not XUINT.
530 There's no need for unsigned here.
531
532 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
533 This follows up to the 2011-05-06 change that substituted uintptr_t
534 for EMACS_INT. This case wasn't caught back then.
535
536 Rework Fformat to avoid integer overflow issues.
537 * editfns.c: Include <float.h> unconditionally, as it's everywhere
538 now (part of C89). Include <verify.h>.
539 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
540 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
541 (Fformat): Avoid the prepass trying to compute sizes; it was only
542 approximate and thus did not catch overflow reliably. Instead, walk
543 through the format just once, formatting and computing sizes as we go,
544 checking for integer overflow at every step, and allocating a larger
545 buffer as needed. Keep track separately whether the format is
546 multibyte. Keep only the most-recently calculated precision, rather
547 than them all. Record whether each argument has been converted to
548 string. Use EMACS_INT, not int, for byte and char and arg counts.
549 Support field widths and precisions larger than INT_MAX. Avoid
550 sprintf's undefined behavior with conversion specifications such as %#d
551 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
552 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
553 formatting out-of-range floating point numbers with int
554 formats. (Bug#8668)
555
556 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
557
558 * data.c: Avoid integer truncation in expressions involving floats.
559 * data.c: Include <intprops.h>.
560 (arith_driver): When there's an integer overflow in an expression
561 involving floating point, convert the integers to floating point
562 so that the resulting value does not suffer from catastrophic
563 integer truncation. For example, on a 64-bit host (* 4
564 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
565 Do not rely on undefined behavior after integer overflow.
566
567 merge count_size_as_multibyte, parse_str_to_multibyte
568 * character.c, character.h (count_size_as_multibyte):
569 Rename from parse_str_to_multibyte; all uses changed.
570 Check for integer overflow.
571 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
572 since it's now a duplicate of the other. This is more of
573 a character than a buffer op, so better that it's in character.c.
574 * fns.c, print.c: Adjust to above changes.
575
576 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
577
578 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
579
580 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
581
582 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
583 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
584 (x_clipboard_manager_save): Now static.
585 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
586
587 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
588 (crypto_hash_function): Now static.
589 Fix pointer signedness problems. Avoid unnecessary initializations.
590
591 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
592
593 * termhooks.h (Vselection_alist): Make it terminal-local.
594
595 * terminal.c (create_terminal): Initialize it.
596
597 * xselect.c: Support for clipboard managers.
598 (Vselection_alist): Move to termhooks.h as terminal-local var.
599 (LOCAL_SELECTION): New macro.
600 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
601 (symbol_to_x_atom): Remove gratuitous arg.
602 (x_handle_selection_request, lisp_data_to_selection_data)
603 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
604 (x_own_selection, x_get_local_selection, x_convert_selection):
605 New arg, specifying work frame. Use terminal-local Vselection_alist.
606 (some_frame_on_display): Delete unused function.
607 (Fx_own_selection_internal, Fx_get_selection_internal)
608 (Fx_disown_selection_internal, Fx_selection_owner_p)
609 (Fx_selection_exists_p): New optional frame arg.
610 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
611 (x_handle_selection_clear): Don't treat other terminals with the
612 same keyboard specially. Use the terminal-local Vselection_alist.
613 (x_clear_frame_selections): Use Frun_hook_with_args.
614
615 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
616
617 * xterm.h: Add support for those atoms.
618
619 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
620
621 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
622 (converted_selections, conversion_fail_tag): New global variables.
623 (x_selection_request_lisp_error): Free the above.
624 (x_get_local_selection): Remove unnecessary code.
625 (x_reply_selection_request): Args changed; handle arbitrary array
626 of converted selections stored in converted_selections.
627 Separate the XChangeProperty and SelectionNotify steps.
628 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
629 (x_convert_selection): New function.
630 (x_handle_selection_event): Simplify.
631 (x_get_foreign_selection): Don't ignore incoming requests while
632 waiting for an answer; this will fail when we implement
633 SAVE_TARGETS, and seems unnecessary anyway.
634 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
635 (Vx_sent_selection_functions): Doc fix.
636
637 2011-05-26 Leo Liu <sdl.web@gmail.com>
638
639 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
640
641 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
642
643 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
644
645 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
646 for fringe update if it has periodic bitmap.
647 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
648 and fringe_bitmap_periodic_p.
649
650 * fringe.c (get_fringe_bitmap_data): New function.
651 (draw_fringe_bitmap_1, update_window_fringes): Use it.
652 (update_window_fringes): Record periodicity of fringe bitmap in glyph
653 row. Mark glyph row for fringe update if periodicity changed.
654
655 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
656 for fringe update unless it has periodic bitmap.
657
658 2011-05-25 Kenichi Handa <handa@m17n.org>
659
660 * xdisp.c (get_next_display_element): Set correct it->face_id for
661 a static composition.
662
663 2011-05-24 Leo Liu <sdl.web@gmail.com>
664
665 * deps.mk (fns.o):
666 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
667
668 * fns.c (crypto_hash_function, Fsha1): New function.
669 (Fmd5): Use crypto_hash_function.
670 (syms_of_fns): Add Ssha1.
671
672 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
673
674 * gnutls.c: Remove unused macros.
675 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
676 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
677 Remove macros that are defined and never used.
678 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
679
680 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
681
682 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
683 (Fx_get_selection_internal): Minor cleanup.
684 (Fx_own_selection_internal): Rename arguments for consistency with
685 select.el.
686
687 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
688
689 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
690
691 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
692
693 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
694
695 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
696
697 * dispnew.c (scrolling_window): Don't exclude the case that the
698 last enabled row in the desired matrix touches the bottom boundary.
699
700 2011-05-21 Glenn Morris <rgm@gnu.org>
701
702 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
703 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
704 and add some more files.
705
706 2011-05-20 Eli Zaretskii <eliz@gnu.org>
707
708 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
709 report_file_error introduced by the change from 2011-05-07.
710
711 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
712
713 * systime.h (Time): Define only if emacs is defined.
714 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
715 where the include path doesn't have X11/X.h by default. See
716 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
717
718 2011-05-20 Kenichi Handa <handa@m17n.org>
719
720 * composite.c (find_automatic_composition): Fix previous change.
721
722 2011-05-20 Glenn Morris <rgm@gnu.org>
723
724 * lisp.mk: New file, split from Makefile.in.
725 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
726 (shortlisp): Remove.
727 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
728
729 2011-05-19 Glenn Morris <rgm@gnu.org>
730
731 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
732 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
733 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
734 (lisp): Set the order to that of loadup.el.
735 (shortlisp): Make it a copy of $lisp.
736 (SOME_MACHINE_LISP): Remove.
737 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
738 Use just $shortlisp, not $SOME_MACHINE_LISP too.
739
740 2011-05-18 Kenichi Handa <handa@m17n.org>
741
742 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
743 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
744 (find_automatic_composition): Mostly rewrite for efficiency.
745
746 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
747
748 * makefile.w32-in: Update dependencies.
749
750 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
751
752 * menu.c: Include limits.h (fixes the MS-Windows build broken by
753 revision 104625).
754
755 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
756
757 Fix some integer overflow issues, such as string length overflow.
758
759 * insdel.c (count_size_as_multibyte): Check for string overflow.
760
761 * character.c (lisp_string_width): Check for string overflow.
762 Use EMACS_INT, not int, for string indexes and lengths; in
763 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
764 the resulting string length overflows an EMACS_INT; instead,
765 report a string overflow if no precision given. When checking for
766 precision exhaustion, use a check that cannot possibly have
767 integer overflow. (Bug#8675)
768 * character.h (lisp_string_width): Adjust to new signature.
769
770 * alloc.c (string_overflow): New function.
771 (Fmake_string): Use it. This doesn't change behavior, but saves
772 a few bytes and will simplify future changes.
773 * character.c (string_escape_byte8): Likewise.
774 * lisp.h (string_overflow): New decl.
775
776 Fixups, following up to the user-interface timestamp change.
777 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
778 for UI timestamps, instead of unsigned long.
779 * msdos.c (mouse_get_pos): Likewise.
780 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
781 * w32gui.h (Time): Define by including "systime.h" rather than by
782 declaring it ourselves. (Bug#8664)
783
784 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
785 * image.c (clear_image_cache): Likewise.
786
787 * term.c (term_mouse_position): Don't assume time_t wraparound.
788
789 Be more systematic about user-interface timestamps.
790 Before, the code sometimes used 'Time', sometimes 'unsigned long',
791 and sometimes 'EMACS_UINT', to represent these timestamps.
792 This change causes it to use 'Time' uniformly, as that's what X uses.
793 This makes the code easier to follow, and makes it easier to catch
794 integer overflow bugs such as Bug#8664.
795 * frame.c (Fmouse_position, Fmouse_pixel_position):
796 Use Time, not unsigned long, for user-interface timestamps.
797 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
798 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
799 * keyboard.h (last_event_timestamp): Likewise.
800 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
801 * menu.h (xmenu_show): Likewise.
802 * term.c (term_mouse_position): Likewise.
803 * termhooks.h (struct input_event.timestamp): Likewise.
804 (struct terminal.mouse_position_hook): Likewise.
805 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
806 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
807 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
808 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
809 what it was before.
810 * menu.h, termhooks.h: Include "systime.h", for Time.
811
812 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
813 Don't assume that the difference between two unsigned long values
814 can fit into an integer. At this point, we know button_down_time
815 <= event->timestamp, so the difference must be nonnegative, so
816 there's no need to cast the result if double-click-time is
817 nonnegative, as it should be; check that it's nonnegative, just in
818 case. This bug is triggered when events are more than 2**31 ms
819 apart (about 25 days). (Bug#8664)
820
821 * xselect.c (last_event_timestamp): Remove duplicate decl.
822 (x_own_selection): Remove needless cast to unsigned long.
823
824 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
825 that always fit in int. Use a sentinel instead of a counter, to
826 avoid a temp and to allay GCC's concerns about possible int overflow.
827 * frame.h (struct frame): Use int for menu_bar_items_used
828 instead of EMACS_INT, since it always fits in int.
829
830 * menu.c (grow_menu_items): Check for int overflow.
831
832 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
833
834 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
835 Before, the code was not consistent. These values cannot exceed
836 2**31 - 1 so there's no need to make them unsigned.
837 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
838 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
839 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
840 as modifiers.
841 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
842
843 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
844 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
845 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
846 presumably because the widths might not match.
847
848 * window.c (size_window): Avoid needless test at loop start.
849
850 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
851
852 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
853
854 2011-05-12 Drew Adams <drew.adams@oracle.com>
855
856 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
857
858 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
859
860 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
861 `width' to `bar_area_x' and `bar_area_width', respectively.
862 (x_scroll_run): Take account of fringe background extension.
863
864 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
865 Rename local vars `left' and `width' to `bar_area_x' and
866 `bar_area_width', respectively.
867 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
868 background extension.
869
870 2011-05-10 Jim Meyering <meyering@redhat.com>
871
872 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
873
874 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
875
876 * image.c (Finit_image_library): Return t for built-in image types,
877 like pbm and xbm. (Bug#8640)
878
879 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
880
881 * w32menu.c (set_frame_menubar): Fix submenu allocation.
882
883 2011-05-07 Eli Zaretskii <eliz@gnu.org>
884
885 * w32console.c (Fset_screen_color): Doc fix.
886 (Fget_screen_color): New function.
887 (syms_of_ntterm): Defsubr it.
888
889 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
890 unlink the temporary file if Fcall_process didn't create it in the
891 first place.
892 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
893 child process will be redirected to a file specified with `:file'.
894 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
895 cue to call_process_cleanup not to close that handle.
896
897 2011-05-07 Ben Key <bkey76@gmail.com>
898
899 * makefile.w32-in: The bootstrap-temacs rule now makes use of
900 one of two shell specific rules, either bootstrap-temacs-CMD or
901 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
902 to the previous implementation of the bootstrap-temacs rule.
903 The bootstrap-temacs-CMD rule is similar to the previous
904 implementation of the bootstrap-temacs rule except that it
905 makes use of the ESC_CFLAGS variable instead of the CFLAGS
906 variable.
907
908 These changes, along with some changes to nt/configure.bat,
909 nt/gmake.defs, and nt/nmake.defs, are required to extend my
910 earlier fix to add support for --cflags and --ldflags options
911 that include quotes so that it works whether make uses cmd or
912 sh as the shell.
913
914 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
915
916 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
917 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
918 is a constant.
919 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
920 a string. Handle both cases.
921 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
922 (Fdbus_register_method): Use Qinvalid_function.
923
924 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
925
926 * makefile.w32-in: Update dependencies.
927 (LISP_H): Add inttypes.h and stdin.h.
928 (PROCESS_H): Add unistd.h.
929
930 2011-05-06 Eli Zaretskii <eliz@gnu.org>
931
932 * lread.c: Include limits.h (fixes the MS-Windows build broken by
933 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
934
935 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
936
937 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
938
939 * term.c (vfatal): Remove stray call to va_end.
940 It's not needed and the C Standard doesn't allow it here anyway.
941
942 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
943 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
944
945 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
946 bytes.
947
948 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
949
950 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
951
952 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
953
954 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
955
956 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
957
958 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
959 * charset.c (Fdefine_charset_internal): Don't initialize
960 charset.code_space[15]. The value was garbage, on hosts with
961 32-bit int (Bug#8600).
962
963 * lread.c (read_integer): Be more consistent with string-to-number.
964 Use string_to_number to do the actual conversion; this avoids
965 rounding errors and fixes some other screwups. Without this fix,
966 for example, #x1fffffffffffffff was misread as -2305843009213693952.
967 (digit_to_number): Move earlier, for benefit of read_integer.
968 Return -1 if the digit is out of range for the base, -2 if it is
969 not a digit in any supported base. (Bug#8602)
970
971 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
972
973 * dispnew.c (scrolling_window): Return 1 if we scrolled,
974 to match comment at start of function. This also removes a
975 GCC warning about overflow in a 32+64-bit port.
976
977 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
978
979 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
980 Reported by Stefan Monnier in
981 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
982 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
983 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
984
985 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
986 (EMACS_UINTPTR): Likewise, with uintptr_t.
987
988 * lisp.h: Prefer 64-bit EMACS_INT if available.
989 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
990 on 32-bit hosts that have 64-bit int, so that they can access
991 large files.
992 However, temporarily disable this change unless the temporary
993 symbol WIDE_EMACS_INT is defined.
994
995 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
996
997 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
998 This removes an assumption that EMACS_INT and long are the same
999 width as pointers. The assumption is true for Emacs porting targets
1000 now, but we want to make other targets possible.
1001 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1002 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1003 In the rest of the code, change types of integers that hold casted
1004 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1005 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1006 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1007 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1008 No need to cast type when ORing.
1009 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1010 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1011 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1012 assume EMACS_INT is the same width as char *.
1013 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1014 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1015 Remove no-longer-needed casts.
1016 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1017 (xg_tool_bar_help_callback, xg_make_tool_item):
1018 Use EMACS_INTPTR to hold an integer
1019 that will be cast to void *; this can avoid a GCC warning
1020 if EMACS_INT is not the same width as void *.
1021 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1022 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1023 (current_message_1, set_message_1):
1024 Use a local to convert to proper width without a cast.
1025 * xmenu.c (dialog_selection_callback): Likewise.
1026
1027 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1028 Also, don't assume VALBITS / RAND_BITS is less than 5,
1029 and don't rely on undefined behavior when shifting a 1 left into
1030 the sign bit.
1031 * lisp.h (get_random): Change signature to match.
1032
1033 * lread.c (hash_string): Use size_t, not int, for hash computation.
1034 Normally we prefer signed values; but hashing is special, because
1035 it's better to use unsigned division on hash table sizes so that
1036 the remainder is nonnegative. Also, size_t is the natural width
1037 for hashing into memory. The previous code used 'int', which doesn't
1038 retain enough info to hash well into very large tables.
1039 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1040
1041 * dbusbind.c: Don't possibly lose pointer info when converting.
1042 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1043 Use XPNTR rather than XHASH, so that the high-order bits of
1044 the pointer aren't lost when converting through void *.
1045
1046 * eval.c (Fautoload): Don't double-shift a pointer.
1047
1048 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1049
1050 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1051
1052 * gnutls.c (DEF_GNUTLS_FN):
1053 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1054
1055 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1056
1057 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1058 marker. (Bug#8610)
1059
1060 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1061
1062 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1063 New version that can reserve upto 2GB of heap space.
1064
1065 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1066
1067 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1068
1069 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1070
1071 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1072 `gnutls_certificate_set_x509_key_file'.
1073
1074 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1075
1076 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1077 Update dependencies.
1078
1079 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1080
1081 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1082 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1083 Remove unused parameter `fildes'.
1084 * process.c (read_process_output, send_process): Don't pass it.
1085
1086 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1087
1088 Fix previous change: the library cache is defined in w32.c.
1089 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1090 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1091
1092 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1093
1094 Implement dynamic loading of GnuTLS on Windows.
1095
1096 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1097 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1098 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1099 Declare.
1100
1101 * gnutls.c (Qgnutls_dll): Define.
1102 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1103 (gnutls_*): Declare function pointers.
1104 (init_gnutls_functions): New function to initialize function pointers.
1105 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1106 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1107 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1108 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1109 (emacs_gnutls_write, emacs_gnutls_read)
1110 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1111 (Fgnutls_available_p): New function.
1112 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1113 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1114 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1115
1116 * image.c: Include w32.h.
1117 (Vimage_type_cache): Delete.
1118 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1119 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1120 (w32_delayed_load): Move to w32.c.
1121
1122 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1123
1124 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1125 (w32_delayed_load): Move from image.c. When loading a library, record
1126 its filename in the :loaded-from property of the library id.
1127 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1128 Initialize and staticpro them.
1129 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1130
1131 * process.c: Include lisp.h before w32.h, not after.
1132 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1133 instead of gnutls_record_check_pending.
1134
1135 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1136
1137 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1138
1139 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1140 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1141 as passed in.
1142
1143 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1144
1145 * xterm.c (x_set_frame_alpha): Do not set property on anything
1146 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1147
1148 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1149
1150 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1151
1152 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1153
1154 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1155 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1156 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1157 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1158 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1159 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1160 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1161 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1162 (Qgnutls_bootprop_callbacks_verify): Make static.
1163
1164 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1165
1166 * callproc.c: Indentation fixup.
1167
1168 * sysdep.c (wait_for_termination_1): Make static.
1169 (wait_for_termination, interruptible_wait_for_termination):
1170 Move after wait_for_termination_1.
1171
1172 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1173
1174 * sysdep.c (interruptible_wait_for_termination): New function
1175 which is like wait_for_termination, but allows keyboard
1176 interruptions.
1177
1178 * callproc.c (Fcall_process): Add (:file "file") as an option for
1179 the STDOUT buffer.
1180 (Fcall_process_region): Ditto.
1181
1182 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1183
1184 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1185 rather than `XVECTOR (FOO)->size'.
1186
1187 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1188 inttypes.h, as a gnulib replacement is used if it not available in
1189 system headers.
1190
1191 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1192
1193 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1194 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1195 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1196
1197 * coding.c (coding_alloc_by_realloc): Error out if destination
1198 will grow beyond MOST_POSITIVE_FIXNUM.
1199 (decode_coding_emacs_mule): Abort if there isn't enough place in
1200 charbuf for the composition carryover bytes. Reserve an extra
1201 space for up to 2 characters produced in a loop.
1202 (decode_coding_iso_2022): Abort if there isn't enough place in
1203 charbuf for the composition carryover bytes.
1204
1205 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1206
1207 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1208 aborting when %lld or %lll format is passed.
1209 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1210 %llo or %llx format is passed. (Bug#8545)
1211
1212 * window.c (window_scroll_line_based): Use a marker instead of
1213 simple variables to record original value of point. (Bug#7952)
1214
1215 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1216 produced by %s or %c overflows available buffer space. (Bug#8545)
1217
1218 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1219
1220 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1221 (SIZE_MAX): Move defn after all includes, as they might #define it.
1222
1223 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1224
1225 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1226
1227 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1228
1229 * keyboard.c (Qdelayed_warnings_hook): Define.
1230 (command_loop_1): Run `delayed-warnings-hook'
1231 if Vdelayed_warnings_list is non-nil.
1232 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1233 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1234
1235 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1236
1237 * doprnt.c (doprnt): Don't return value smaller than the buffer
1238 size if the message was truncated. (Bug#8545).
1239
1240 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1241
1242 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1243 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1244
1245 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1246
1247 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1248
1249 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1250
1251 * makefile.w32-in: Update dependencies.
1252
1253 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1254
1255 Improve `doprnt' and its usage. (Bug#8545)
1256 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1257 `format_end'. Remove support for %l as a conversion specifier.
1258 Don't use xrealloc. Improve diagnostics when the %l size modifier
1259 is used. Update the commentary.
1260
1261 * eval.c (verror): Simplify calculation of size_t.
1262
1263 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1264 messages.
1265
1266 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1267
1268 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1269 change.
1270
1271 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1274 This makes this file independent of the recent pseudovector change.
1275
1276 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1279
1280 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1281 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1282 Remove unused local.
1283 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1284
1285 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1286 GCC 4.6.0 optimizes based on type-based alias analysis.
1287 For example, if b is of type struct buffer * and v of type struct
1288 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1289 != &v->size, and therefore "v->size = 1; b->size = 2; return
1290 v->size;" must therefore return 1. This assumption is incorrect
1291 for Emacs, since it type-puns struct Lisp_Vector * with many other
1292 types. To fix this problem, this patch adds a new type struct
1293 vectorlike_header that documents the constraints on layout of vectors
1294 and pseudovectors, and helps optimizing compilers not get fooled
1295 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1296 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1297 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1298 the size member.
1299 (XSETPVECTYPE): Rewrite in terms of new macro.
1300 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1301 This is a bit clearer, and further avoids the possibility of
1302 undesirable aliasing.
1303 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1304 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1305 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1306 since Lisp_Subr is a special case (no "next" field).
1307 (ASIZE): Now uses header.size rather than size.
1308 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1309 to avoid the hassle of writing XVECTOR (foo)->header.size.
1310 (struct vectorlike_header): New type.
1311 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1312 object, to help avoid aliasing.
1313 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1314 (SUBRP): Likewise, since Lisp_Subr is a special case.
1315 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1316 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1317 (struct Lisp_Hash_Table): Combine first two members into a single
1318 struct vectorlike_header member. All uses of "size" and "next" members
1319 changed to be "header.size" and "header.next".
1320 * buffer.h (struct buffer): Likewise.
1321 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1322 * frame.h (struct frame): Likewise.
1323 * process.h (struct Lisp_Process): Likewise.
1324 * termhooks.h (struct terminal): Likewise.
1325 * window.c (struct save_window_data, struct saved_window): Likewise.
1326 * window.h (struct window): Likewise.
1327 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1328 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1329 * buffer.c (init_buffer_once): Likewise.
1330 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1331 special case.
1332 * process.c (Fformat_network_address): Use local var for size,
1333 for brevity.
1334
1335 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1336
1337 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1338 * data.c (atof): Remove decl; no longer used or needed.
1339 (digit_to_number): Move to lread.c.
1340 (Fstring_to_number): Use new string_to_number function, to be
1341 consistent with how the Lisp reader treats infinities and NaNs.
1342 Do not assume that floating-point numbers represent EMACS_INT
1343 without losing information; this is not true on most 64-bit hosts.
1344 Avoid double-rounding errors, by insisting on integers when
1345 parsing non-base-10 numbers, as the documentation specifies.
1346 * lisp.h (string_to_number): New decl, replacing ...
1347 (isfloat_string): Remove.
1348 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1349 (read1): Do not accept +. and -. as integers; this
1350 appears to have been a coding error. Similarly, do not accept
1351 strings like +-1e0 as floating point numbers. Do not report
1352 overflow for integer overflows unless the base is not 10 which
1353 means we have no simple and reliable way to continue.
1354 Break out the floating-point parsing into a new
1355 function string_to_number, so that Fstring_to_number parses
1356 floating point numbers consistently with the Lisp reader.
1357 (digit_to_number): Move here from data.c. Make it static inline.
1358 (E_CHAR, EXP_INT): Remove, replacing with ...
1359 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1360 (string_to_number): New function, replacing isfloat_string.
1361 This function checks for valid syntax and produces the resulting
1362 Lisp float number too. Rework it so that string-to-number
1363 no longer mishandles examples like "1.0e+". Use strtoumax,
1364 so that overflow for non-base-10 numbers is reported only when
1365 there's no portable and simple way to convert to floating point.
1366
1367 * textprop.c (set_text_properties_1): Rewrite for clarity,
1368 and to avoid GCC warning about integer overflow.
1369
1370 * intervals.h (struct interval): Use EMACS_INT for members
1371 where EMACS_UINT might cause problems. See
1372 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1373 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1374 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1375 All uses changed.
1376 (offset_intervals): Tell GCC not to worry about length overflow
1377 when negating a negative length.
1378
1379 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1380 (overrun_check_free): Likewise.
1381
1382 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1383 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1384 word size.
1385
1386 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1387 (gnutls_make_error): Rename local to avoid shadowing.
1388 (gnutls_emacs_global_deinit): ifdef out; not used.
1389 (Fgnutls_boot): Use const for pointer to readonly storage.
1390 Comment out unused local. Fix pointer signedness problems.
1391
1392 * lread.c (openp): Don't stuff size_t into an 'int'.
1393 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1394 about possible signed overflow.
1395
1396 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1397 (GDK_KEY_g): Don't define if already defined.
1398 (xg_prepare_tooltip): Avoid pointer signedness problem.
1399 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1400
1401 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1402 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1403
1404 * xfns.c (Fx_window_property): Simplify a bit,
1405 to make a bit faster and to avoid GCC 4.6.0 warning.
1406 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1407
1408 * fns.c (internal_equal): Don't assume size_t fits in int.
1409
1410 * alloc.c (compact_small_strings): Tighten assertion a little.
1411
1412 Replace pEd with more-general pI, and fix some printf arg casts.
1413 * lisp.h (pI): New macro, generalizing old pEd macro to other
1414 conversion specifiers. For example, use "...%"pI"d..." rather
1415 than "...%"pEd"...".
1416 (pEd): Remove. All uses replaced with similar uses of pI.
1417 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1418 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1419 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1420 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1421 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1422 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1423 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1424 64-bit hosts.
1425 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1426 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1427 * print.c (safe_debug_print, print_object): Likewise.
1428 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1429 to int.
1430 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1431 avoiding the 0 flag, which is not portable.
1432 * process.c (Fmake_network_process): Use pI to avoid cast.
1433 * region-cache.c (pp_cache): Likewise.
1434 * xdisp.c (decode_mode_spec): Likewise.
1435 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1436 behavior on 64-bit hosts with printf arg.
1437 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1438 (x_stop_queuing_selection_requests): Likewise.
1439 (x_get_window_property): Don't truncate byte count to an 'int'
1440 when tracing.
1441
1442 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1443 here, since it parses constructs like leading '-' and spaces,
1444 which are not wanted; and it overflows with large numbers.
1445 Instead, simply match F[0-9]+, which is what is wanted anyway.
1446
1447 * alloc.c: Remove unportable assumptions about struct layout.
1448 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1449 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1450 (allocate_vectorlike, make_pure_vector): Use the new macros,
1451 plus offsetof, to remove unportable assumptions about struct layout.
1452 These assumptions hold on all porting targets that I know of, but
1453 they are not guaranteed, they're easy to remove, and removing them
1454 makes further changes easier.
1455
1456 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1457 This doesn't fix a bug but makes the code clearer.
1458 (string_overrun_cookie): Now const. Use initializers that
1459 don't formally overflow signed char, to avoid warnings.
1460 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1461 can cause Emacs to crash when string overrun checking is enabled.
1462 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1463 multiple of sizeof (EMACS_INT); it need not be, if
1464 alignof(EMACS_INT) < sizeof (EMACS_INT).
1465 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1466
1467 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1468
1469 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1470
1471 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1472
1473 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1474 supposed to be handshaking. (Bug#8556)
1475 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1476
1477 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1478
1479 * lisp.h (Qdebug): List symbol.
1480 * eval.c (Qdebug): Restore global linkage.
1481 * keyboard.c (debug-on-event): New variable.
1482 (handle_user_signal): Break into debugger when debug-on-event
1483 matches the current signal symbol.
1484
1485 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1486
1487 * alloc.c (check_sblock, check_string_bytes)
1488 (check_string_free_list): Convert to standard C.
1489
1490 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1491
1492 * w32.c (emacs_gnutls_push): Fix typo.
1493
1494 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1495
1496 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1497 "cast to pointer from integer of different size".
1498
1499 Improve doprnt and its use in verror. (Bug#8545)
1500 * doprnt.c (doprnt): Document the set of format control sequences
1501 supported by the function. Use SAFE_ALLOCA instead of always
1502 using `alloca'.
1503
1504 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1505 is one byte too soon. Don't use xrealloc; instead xfree and
1506 xmalloc anew.
1507
1508 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1509
1510 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1511 callbacks stage.
1512
1513 * gnutls.c: Renamed global_initialized to
1514 gnutls_global_initialized. Added internals for the
1515 :verify-hostname-error, :verify-error, and :verify-flags
1516 parameters of `gnutls-boot' and documented those parameters in the
1517 docstring. Start callback support.
1518 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1519 unless a fatal error occured. Call gnutls_alert_send_appropriate
1520 on error. Return error code.
1521 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1522 (emacs_gnutls_read): Likewise.
1523 (Fgnutls_boot): Return handshake error code.
1524 (emacs_gnutls_handle_error): New function.
1525 (wsaerror_to_errno): Likewise.
1526
1527 * w32.h (emacs_gnutls_pull): Add prototype.
1528 (emacs_gnutls_push): Likewise.
1529
1530 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1531 (emacs_gnutls_push): Likewise.
1532
1533 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1534
1535 * process.c (wait_reading_process_output): Check if GnuTLS
1536 buffered some data internally if no FDs are set for TLS
1537 connections.
1538
1539 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1540 (LIBS): Link to USER_LIBS.
1541 ($(BLD)/gnutls.$(0)): New target.
1542
1543 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1544
1545 * xdisp.c (handle_single_display_spec): Rename the
1546 display_replaced_before_p argument into display_replaced_p, to
1547 make it consistent with the commentary. Fix typos in the
1548 commentary.
1549
1550 * textprop.c (syms_of_textprop): Remove dead code.
1551 (copy_text_properties): Delete obsolete commentary about an
1552 interface that was deleted long ago. Fix typos in the description
1553 of arguments.
1554
1555 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1556 to changes in oldXMenu/XMenu.h from 2011-04-16.
1557 <menu_help_message, prev_menu_help_message>: Constify.
1558 (IT_menu_make_room): menu->help_text is now `const char **';
1559 adjust.
1560
1561 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1562 to changes in oldXMenu/XMenu.h from 2011-04-16.
1563 (struct XMenu): Declare `help_text' `const char **'.
1564
1565 * xfaces.c <Qunspecified>: Make extern again.
1566
1567 * syntax.c: Include sys/types.h before including regex.h, as
1568 required by Posix.
1569
1570 * doc.c (get_doc_string): Improve the format passed to `error'.
1571
1572 * doprnt.c (doprnt): Improve commentary.
1573
1574 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1575
1576 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1577 them with etags.
1578
1579 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1580 changes in globals.h immediately force recompilation.
1581 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1582 $(CURDIR)/s/ms-w32.h.
1583 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1584
1585 * character.c (Fchar_direction): Function deleted.
1586 (syms_of_character): Don't defsubr it.
1587 <char-direction-table>: Deleted.
1588
1589 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1590
1591 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1592 * doprnt.c: Include limits.h.
1593 (SIZE_MAX): New macro.
1594 (doprnt): Return a size_t value. 2nd arg is now size_t.
1595 Many local variables are now size_t instead of int or unsigned.
1596 Improve overflow protection. Support `l' modifier for integer
1597 conversions. Support %l conversion. Don't assume an EMACS_INT
1598 argument for integer conversions and for %c.
1599
1600 * lisp.h (doprnt): Restore prototype.
1601
1602 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1603 $(SRC)/character.h.
1604
1605 * Makefile.in (base_obj): Add back doprnt.o.
1606
1607 * deps.mk (doprnt.o): Add back prerequisites.
1608 (callint.o): Depend on character.h.
1609
1610 * eval.c (internal_lisp_condition_case): Include the handler
1611 representation in the error message.
1612 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1613 when breaking from the loop.
1614
1615 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1616
1617 * callint.c (Fcall_interactively): When displaying error message
1618 about invalid control letter, pass the character's codepoint, not
1619 a pointer to its multibyte form. Improve display of the character
1620 in octal and display also its hex code.
1621
1622 * character.c (char_string): Use %x to display the (unsigned)
1623 codepoint of an invalid character, to avoid displaying a bogus
1624 negative value.
1625
1626 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1627 `error', not SYMBOL_NAME itself.
1628
1629 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1630 character arguments to `error'.
1631
1632 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1633 to `error' in error message about FINAL_CHAR argument. Make sure
1634 FINAL_CHAR is a character, and use %c when it is passed as
1635 argument to `error'.
1636
1637 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1638
1639 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1640
1641 * w32.c: Include <time.h>.
1642 (sys_localtime): New function.
1643
1644 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1645
1646 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1647
1648 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1649
1650 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1651
1652 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1653 zombies (Bug#8467).
1654
1655 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1656
1657 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1658 gl_state.e_property when gl_state.object is Qt.
1659
1660 * insdel.c (make_gap_larger): Remove limitation of buffer size
1661 to <= INT_MAX.
1662
1663 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1664
1665 * xdisp.c (lookup_glyphless_char_display)
1666 (produce_glyphless_glyph): Handle cons cell entry in
1667 glyphless-char-display.
1668 (Vglyphless_char_display): Document it.
1669
1670 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1671 glyphless-char-display.
1672
1673 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1674
1675 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1676
1677 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1678
1679 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1680 definition for no-X builds.
1681
1682 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1683
1684 Static checks with GCC 4.6.0 and non-default toolkits.
1685
1686 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1687
1688 * process.c (keyboard_bit_set): Define only if SIGIO.
1689 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1690 (send_process): Repair possible setjmp clobbering.
1691
1692 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1693
1694 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1695
1696 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1697
1698 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1699 Define only if needed.
1700
1701 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1702 by pacifying GCC about it. Maybe it's time to retire it?
1703 * xfaces.c (USG, __TIMEVAL__): Likewise.
1704
1705 * dispextern.h (struct redisplay_interface): Rename param
1706 to avoid shadowing.
1707 * termhooks.h (struct terminal): Likewise.
1708 * xterm.c (xembed_send_message): Likewise.
1709
1710 * insdel.c (make_gap_smaller): Define only if
1711 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1712
1713 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1714 it.
1715
1716 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1717 so that we aren't warned about unused symbols.
1718
1719 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1720
1721 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1722
1723 * xfns.c (x_real_positions): Mark locals as initialized.
1724
1725 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1726
1727 * xterm.c: Fix problems found by static analysis with other toolkits.
1728 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1729 (x_dispatch_event): Declare static if USE_GTK, and
1730 define if USE_GTK || USE_X_TOOLKIT.
1731 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1732 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1733 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1734 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1735
1736 * xmenu.c (menu_help_callback): Pointer type fixes.
1737 Use const pointers when pointing at readonly data. Avoid pointer
1738 signedness clashes.
1739 (FALSE): Remove unused macro.
1740 (update_frame_menubar): Remove unused decl.
1741
1742 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1743
1744 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1745 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1746 (single_menu_item): Rename local to avoid shadowing.
1747
1748 * keyboard.c (make_lispy_event): Remove unused local var.
1749
1750 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1751 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1752
1753 * bitmaps: Change bitmaps from unsigned char back to the X11
1754 compatible char. Avoid the old compiler warnings about
1755 out-of-range initializers by using, for example, '\xab' rather
1756 than 0xab.
1757
1758 * xgselect.c (xgselect_initialize): Check vs interface
1759 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1760
1761 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1762
1763 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1764 to read-only memory.
1765
1766 * fns.c (vector): Remove; this old hack is no longer needed.
1767
1768 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1769 Remove unused var.
1770 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1771
1772 * xrdb.c (x_load_resources): Omit unused local.
1773
1774 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1775 (x_window): Rename locals to avoid shadowing.
1776 (USG): Use the kludged USG macro, to pacify gcc.
1777
1778 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1779 (x_term_init): Remove local to avoid shadowing.
1780
1781 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1782
1783 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1784 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1785
1786 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1787
1788 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1789
1790 Fix regex.c, syntax.c and friends for buffers > 2GB.
1791 * syntax.h (struct gl_state_s): Declare character position members
1792 EMACS_INT.
1793
1794 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1795
1796 * textprop.c (verify_interval_modification, interval_of):
1797 Declare arguments EMACS_INT.
1798
1799 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1800 EMACS_INT.
1801
1802 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1803
1804 * indent.c (Fvertical_motion): Local variable it_start is now
1805 EMACS_INT.
1806
1807 * regex.c (re_match, re_match_2, re_match_2_internal)
1808 (bcmp_translate, regcomp, regexec, print_double_string)
1809 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1810 (re_compile_pattern, re_exec): Declare arguments and local
1811 variables `size_t' and `ssize_t' and return values `regoff_t', as
1812 appropriate.
1813 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1814 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1815 <compile_stack_type>: `size' and `avail' are now `size_t'.
1816
1817 * regex.h <regoff_t>: Use ssize_t, not int.
1818 (re_search, re_search_2, re_match, re_match_2): Arguments that
1819 specify buffer/string position and length are now ssize_t and
1820 size_t. Return type is regoff_t.
1821
1822 2011-04-16 Ben Key <bkey76@gmail.com>
1823
1824 * nsfont.m: Fixed bugs in ns_get_family and
1825 ns_descriptor_to_entity that were caused by using free to
1826 deallocate memory blocks that were allocated by xmalloc (via
1827 xstrdup). This caused Emacs to crash when compiled with
1828 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1829 --enable-checking=xmallocoverrun). xfree is now used to
1830 deallocate these memory blocks.
1831
1832 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1833
1834 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1835
1836 emacs_write: Accept and return EMACS_INT for sizes.
1837 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1838 et seq.
1839 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1840 Accept and return EMACS_INT.
1841 (emacs_gnutls_write): Return the number of bytes written on
1842 partial writes.
1843 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1844 (emacs_read, emacs_write): Remove check for negative size, as the
1845 Emacs source code has been audited now.
1846 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1847 (emacs_read, emacs_write): Use it.
1848 * process.c (send_process): Adjust to the new signatures of
1849 emacs_write and emacs_gnutls_write. Do not attempt to store
1850 a byte offset into an 'int'; it might overflow.
1851 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1852
1853 * sound.c: Don't assume sizes fit in 'int'.
1854 (struct sound_device.period_size, alsa_period_size):
1855 Return EMACS_INT, not int.
1856 (struct sound_device.write, vox_write, alsa_write):
1857 Accept EMACS_INT, not int.
1858 (wav_play, au_play): Use EMACS_INT to store sizes and to
1859 record read return values.
1860
1861 2011-04-15 Ben Key <bkey76@gmail.com>
1862
1863 * keyboard.c (Qundefined): Don't declare static since it is used
1864 in nsfns.m.
1865 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1866 static since they are used in nsfont.m.
1867
1868 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1869
1870 * process.c (Qprocessp): Don't declare static.
1871 * lisp.h (Qprocessp): Declare again.
1872
1873 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1876
1877 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1878
1879 Improve C-level modularity by making more things 'static'.
1880
1881 Don't publish debugger-only interfaces to other modules.
1882 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1883 (verify_bytepos, count_markers): Move decls to the only modules
1884 that need them.
1885 * region-cache.h (pp_cache): Likewise.
1886 * window.h (check_all_windows): Likewise.
1887 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1888
1889 * sysdep.c (croak): Now static, if
1890 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1891 * syssignal.h (croak): Declare only if not static.
1892
1893 * alloc.c (refill_memory_reserve): Now static if
1894 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1895 * lisp.h (refill_memory_reserve): Declare only if not static.
1896
1897 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1898 Define only if USE_LUCID.
1899
1900 * xrdb.c (x_customization_string, x_rm_string): Now static.
1901
1902 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1903 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1904
1905 * xdisp.c (draw_row_with_mouse_face): Now static.
1906 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1907
1908 * window.h (check_all_windows): Mark externally visible.
1909
1910 * window.c (window_deletion_count): Now static.
1911
1912 * undo.c: Make symbols static if they're not exported.
1913 (last_undo_buffer, last_boundary_position, pending_boundary):
1914 Now static.
1915
1916 * textprop.c (interval_insert_behind_hooks): Now static.
1917 (interval_insert_in_front_hooks): Likewise.
1918
1919 * term.c: Make symbols static if they're not exported.
1920 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1921 (max_frame_lines, tty_set_terminal_modes):
1922 (tty_reset_terminal_modes, tty_turn_off_highlight):
1923 (get_tty_terminal): Now static.
1924 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1925 * termhooks.h (term_mouse_moveto): Do not declare if
1926 HAVE_WINDOW_SYSTEM.
1927 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1928 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1929
1930 * sysdep.c: Make symbols static if they're not exported.
1931 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1932 Now static.
1933 (sigprocmask_set, full_mask): Remove; unused.
1934 (wait_debugging): Mark as visible.
1935 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1936 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1937
1938 * syntax.c (syntax_temp): Define only if !__GNUC__.
1939
1940 * sound.c (current_sound_device, current_sound): Now static.
1941
1942 * search.c (searchbufs, searchbuf_head): Now static.
1943
1944 * scroll.c (scroll_cost): Remove; unused.
1945 * dispextern.h (scroll_cost): Remove decl.
1946
1947 * region-cache.h (pp_cache): Mark as externally visible.
1948
1949 * process.c: Make symbols static if they're not exported.
1950 (process_tick, update_tick, create_process, chan_process):
1951 (Vprocess_alist, proc_buffered_char, datagram_access):
1952 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1953 (deactivate_process): Mark defn as static, as well as decl.
1954 * lisp.h (create_process): Remove decl.
1955 * process.h (chan_process, Vprocess_alist): Remove decls.
1956
1957 * print.c: Make symbols static if they're not exported.
1958 (print_depth, new_backquote_output, being_printed, print_buffer):
1959 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1960 (print_interval, print_number_index, initial_stderr_stream):
1961 Now static.
1962 * lisp.h (Fprinc): Remove decl.
1963 (debug_output_compilation_hack): Mark as externally visible.
1964
1965 * sysdep.c (croak): Move decl from here to syssignal.h.
1966 * syssignal.h (croak): Put it here, so the API can be checked when
1967 'croak' is called from dissociate_if_controlling_tty.
1968
1969 * minibuf.c: Make symbols static if they're not exported.
1970 (minibuf_save_list, choose_minibuf_frame): Now static.
1971 * lisp.h (choose_minibuf_frame): Remove decl.
1972
1973 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1974
1975 * lread.c: Make symbols static if they're not exported.
1976 (read_objects, initial_obarray, oblookup_last_bucket_number):
1977 Now static.
1978 (make_symbol): Remove; unused.
1979 * lisp.h (initial_obarray, make_symbol): Remove decls.
1980
1981 * keyboard.c: Make symbols static if they're not exported.
1982 (single_kboard, recent_keys_index, total_keys, recent_keys):
1983 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1984 (this_single_command_key_start, echoing, last_auto_save):
1985 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1986 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1987 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1988 (Vlispy_mouse_stem, double_click_count):
1989 Now static.
1990 (force_auto_save_soon): Define only if SIGDANGER.
1991 (ignore_mouse_drag_p): Now static if
1992 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1993 (print_help): Remove; unused.
1994 (stop_character, last_timer_event): Mark as externally visible.
1995 * keyboard.h (ignore_mouse_drag_p): Declare only if
1996 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1997 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1998 * lisp.h (echoing): Remove decl.
1999 (force_auto_save_soon): Declare only if SIGDANGER.
2000 * xdisp.c (redisplay_window): Simplify code, to make it more
2001 obvious that ignore_mouse_drag_p is not accessed if !defined
2002 USE_GTK && !defined HAVE_NS.
2003
2004 * intervals.c: Make symbols static if they're not exported.
2005 (merge_properties_sticky, merge_interval_right, delete_interval):
2006 Now static.
2007 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2008
2009 * insdel.c: Make symbols static if they're not exported.
2010 However, leave prepare_to_modify_buffer alone. It's never
2011 called from outside this function, but that appears to be a bug.
2012 (combine_after_change_list, combine_after_change_buffer):
2013 (adjust_after_replace, signal_before_change): Now static.
2014 (adjust_after_replace_noundo): Remove; unused.
2015 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2016 (signal_before_change): Remove decls.
2017
2018 * indent.c (val_compute_motion, val_vmotion): Now static.
2019
2020 * image.c: Make symbols static if they're not exported.
2021 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2022 if USE_GTK.
2023 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2024 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2025
2026 * fringe.c (standard_bitmaps): Now static.
2027 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2028
2029 * frame.c: Make symbols static if they're not exported.
2030 (x_report_frame_params, make_terminal_frame): Now static.
2031 (get_frame_param): Now static, unless HAVE_NS.
2032 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2033 (x_get_resource_string): Remove; not used.
2034 * frame.h (make_terminal_frame, x_report_frame_params):
2035 (x_get_resource_string); Remove decls.
2036 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2037 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2038
2039 * font.c, fontset.c: Make symbols static if they're not exported.
2040 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2041 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2042 * font.c (font_close_object): Now static.
2043 * font.h (font_close_object): Remove.
2044 * fontset.c (FONTSET_OBJLIST): Remove.
2045 (free_realized_fontset) #if-0 the body, which does nothing.
2046 (face_suitable_for_char_p): #if-0, as it's never called.
2047 * fontset.h (face_suitable_for_char_p): Remove decl.
2048 * xfaces.c (face_at_string_position):
2049 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2050 since 0 is always ASCII.
2051
2052 * fns.c (weak_hash_tables): Now static.
2053
2054 * fileio.c: Make symbols static if they're not exported.
2055 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2056 (Vwrite_region_annotation_buffers): Now static.
2057
2058 * eval.c: Make symbols static if they're not exported.
2059 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2060 * lisp.h (backtrace_list): Remove decl.
2061
2062 * emacs.c: Make symbols static if they're not exported.
2063 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2064 (fatal_error_code, fatal_error_signal_hook, standard_args):
2065 Now static.
2066 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2067 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2068 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2069 * lisp.h (fatal_error_signal_hook): Remove decl.
2070 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2071
2072 * editfns.c: Move a (normally-unused) function to its only use.
2073 * editfns.c, lisp.h (get_operating_system_release): Remove.
2074 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2075 worth the hassle of breaking this out.
2076
2077 * xterm.c: Make symbols static if they're not exported.
2078 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2079 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2080 (x_destroy_window, x_delete_display):
2081 Now static.
2082 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2083 (x_mouse_leave): Remove; unused.
2084 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2085 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2086 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2087 Remove decls.
2088 (x_mouse_leave): Declare only if WINDOWSNT.
2089 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2090 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2091 USE_X_TOOLKIT.
2092
2093 * ftxfont.c: Make symbols static if they're not exported.
2094 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2095 HAVE_FREETYPE.
2096 * font.h (ftxfont_driver): Likewise.
2097
2098 * xfns.c: Make symbols static if they're not exported.
2099 (x_last_font_name, x_display_info_for_name):
2100 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2101 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2102 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2103 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2104 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2105 (last_show_tip_args): Now static.
2106 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2107 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2108 (x_screen_planes): Remove; unused.
2109 * dispextern.h (x_screen_planes): Remove decl.
2110
2111 * dispnew.c: Make symbols static if they're not exported.
2112 * dispextern.h (redraw_garbaged_frames, scrolling):
2113 (increment_row_positions): Remove.
2114 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2115 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2116 Now static.
2117 (redraw_garbaged_frames): Remove; unused.
2118
2119 * xfaces.c: Make symbols static if they're not exported.
2120 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2121 Remove decls.
2122 * xterm.h (defined_color): Remove decls.
2123 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2124 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2125 (menu_face_changed_default, defined_color, free_realized_face):
2126 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2127 (ascii_face_of_lisp_face): Remove; unused.
2128
2129 * xdisp.c: Make symbols static if they're not exported.
2130 * dispextern.h (scratch_glyph_row, window_box_edges):
2131 (glyph_to_pixel_coords, set_cursor_from_row):
2132 (get_next_display_element, set_iterator_to_next):
2133 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2134 (show_mouse_face): Remove decls
2135 * frame.h (message_buf_print): Likewise.
2136 * lisp.h (pop_message, set_message, check_point_in_composition):
2137 Likewise.
2138 * xterm.h (set_vertical_scroll_bar): Likewise.
2139 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2140 (message_buf_print, scratch_glyph_row, displayed_buffer):
2141 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2142 (get_next_display_element, show_mouse_face, window_box_edges):
2143 (frame_to_window_pixel_xy, check_point_in_composition):
2144 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2145 (glyph_to_pixel_coords): Remove; unused.
2146
2147 * dired.c (file_name_completion): Now static.
2148
2149 * dbusbind.c (xd_in_read_queued_messages): Now static.
2150
2151 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2152 * data.c (circular_list_error): Remove.
2153
2154 * commands.h (last_point_position, last_point_position_buffer):
2155 (last_point_position_window): Remove decls.
2156 * keyboard.c: Make these variables static.
2157
2158 * coding.h (coding, code_convert_region, encode_coding_gap):
2159 Remove decls.
2160 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2161 (iso_code_class, detect_coding, code_convert_region): Now static.
2162 (encode_coding_gap): Remove; unused.
2163
2164 * chartab.c (chartab_chars, chartab_bits): Now static.
2165
2166 * charset.h (charset_iso_8859_1): Remove decl.
2167 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2168 Now static.
2169
2170 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2171 * ccl.c (Vccl_program_table): Now static.
2172 (check_ccl_update): Remove; unused.
2173
2174 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2175 * category.h: ... from here.
2176 * category.c (check_category_table, set_category_set): Now static.
2177
2178 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2179 * lisp.h: Remove these decls.
2180
2181 * buffer.c (buffer_count): Remove unused var.
2182
2183 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2184 so that it's not optimized away.
2185 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2186 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2187 exported only to the debugger.
2188
2189 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2190 * atimer.h (run_all_atimers): Remove; not exported.
2191
2192 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2193 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2194 was inaccessible from Lisp.
2195 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2196 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2197
2198 alloc.c: Import and export fewer symbols, and remove unused items.
2199 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2200 is defined.
2201 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2202 it's not optimized away by whole-program optimization.
2203 (message_enable_multibyte, free_misc): Remove.
2204 (catchlist, handlerlist, mark_backtrace):
2205 Declare only if BYTE_MARK_STACK.
2206 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2207 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2208 (message_enable_multibyte): Remove decl.
2209 (free_misc, interval_free_list, float_block, float_block_index):
2210 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2211 (cons_free_list, last_marked_index):
2212 Now static.
2213 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2214 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2215 (mark_backtrace): Define only if BYTE_MARK_STACK.
2216 * xdisp.c (message_enable_multibyte): Now static.
2217
2218 Declare Lisp_Object Q* variables to be 'static' if not exported.
2219 This makes it easier for human readers (and static analyzers)
2220 to see whether these variables are used from other modules.
2221 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2222 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2223 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2224 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2225 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2226 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2227 * xmenu.c, xselect.c:
2228 Declare Q* vars static if they are not used in other modules.
2229 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2230 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2231 Remove decls of unexported vars.
2232 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2233
2234 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2235
2236 Make Emacs functions such as Fatom 'static' by default.
2237 This makes it easier for human readers (and static analyzers)
2238 to see whether these functions can be called from other modules.
2239 DEFUN now defines a static function. To make the function external
2240 so that it can be used in other C modules, use the new macro DEFUE.
2241 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2242 (Finit_image_library):
2243 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2244 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2245 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2246 Remove decls, since these functions are now static.
2247 (Funintern, Fget_internal_run_time): New decls, since these functions
2248 were already external.
2249
2250 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2251 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2252 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2253 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2254 * keyboard.c, keymap.c, lread.c:
2255 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2256 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2257 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2258 Mark functions with DEFUE instead of DEFUN,
2259 if they are used in other modules.
2260 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2261 decls for now-static functions.
2262 * buffer.h (Fdelete_overlay): Remove decl.
2263 * callproc.c (Fgetenv_internal): Mark as internal.
2264 * composite.c (Fremove_list_of_text_properties): Remove decl.
2265 (Fcomposition_get_gstring): New forward static decl.
2266 * composite.h (Fcomposite_get_gstring): Remove decl.
2267 * dired.c (Ffile_attributes): New forward static decl.
2268 * doc.c (Fdocumntation_property): New forward static decl.
2269 * eval.c (Ffetch_bytecode): New forward static decl.
2270 (Funintern): Remove extern decl; now in .h file where it belongs.
2271 * fileio.c (Fmake_symbolic_link): New forward static decl.
2272 * image.c (Finit_image_library): New forward static decl.
2273 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2274 * intervals.h (Fprevious_property_change):
2275 (Fremove_list_of_text_properties): Remove decls.
2276 * keyboard.c (Fthis_command_keys): Remove decl.
2277 (Fcommand_execute): New forward static decl.
2278 * keymap.c (Flookup_key): New forward static decl.
2279 (Fcopy_keymap): Now static.
2280 * keymap.h (Flookup_key): Remove decl.
2281 * process.c (Fget_process): New forward static decl.
2282 (Fprocess_datagram_address): Mark as internal.
2283 * syntax.c (Fsyntax_table_p): New forward static decl.
2284 (skip_chars): Remove duplicate decl.
2285 * textprop.c (Fprevious_property_change): New forward static decl.
2286 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2287 Now internal.
2288 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2289 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2290
2291 * editfns.c (Fformat): Remove unreachable code.
2292
2293 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2294
2295 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2296 change. (Bug#8496)
2297
2298 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2299
2300 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2301 when at ZV. (Bug#8487)
2302
2303 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2304
2305 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2306 (Bug#8437)
2307 * keyboard.c (parse_tool_bar_item): Likewise.
2308 * sound.c (sound_cleanup, alsa_close): Likewise.
2309 * termcap.c (tgetent): Likewise.
2310 * xfns.c (x_default_font_parameter): Likewise.
2311 * xsettings.c (read_and_apply_settings): Likewise.
2312
2313 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2314 (overrun_check_free): Protoize.
2315
2316 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2319 since callers should never pass a negative size.
2320 Change the signature to match that of plain 'read' and 'write'; see
2321 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2322 * lisp.h: Update prototypes of emacs_write and emacs_read.
2323
2324 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2325
2326 * xdisp.c (redisplay_window): Don't try to determine the character
2327 position of the scroll margin if the window start point w->startp
2328 is outside the buffer's accessible region. (Bug#8468)
2329
2330 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2331
2332 Fix write-region and its subroutines for buffers > 2GB.
2333 * fileio.c (a_write, e_write): Modify declaration of arguments and
2334 local variables to support buffers larger than 2GB.
2335 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2336
2337 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2338 argument, local variables, and return value.
2339
2340 * lisp.h: Update prototypes of emacs_write and emacs_read.
2341
2342 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2343
2344 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2345
2346 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2347
2348 Fix more problems found by GCC 4.6.0's static checks.
2349
2350 * xdisp.c (vmessage): Use a better test for character truncation.
2351
2352 * charset.c (load_charset_map): <, not <=, for optimization,
2353 and to avoid potential problems with integer overflow.
2354 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2355 * casetab.c (set_identity, shuffle): Likewise.
2356 * editfns.c (Fformat): Likewise.
2357 * syntax.c (skip_chars): Likewise.
2358
2359 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2360 This also lets GCC 4.6.0 generate slightly better loop code.
2361
2362 * callint.c (Fcall_interactively): <, not <=, for optimization.
2363 (Fcall_interactively): Count the number of arguments produced,
2364 not the number of arguments given. This is simpler and lets GCC
2365 4.6.0 generate slightly better code.
2366
2367 * ftfont.c: Distingish more carefully between FcChar8 and char.
2368 The previous code passed unsigned char * to a functions like
2369 strlen and xstrcasecmp that expect char *, which does not
2370 conform to the C standard.
2371 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2372 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2373 char * when the C standard requires it.
2374
2375 * keyboard.c (read_char): Remove unused var.
2376
2377 * eval.c: Port to Windows vsnprintf (Bug#8435).
2378 Include <limits.h>.
2379 (SIZE_MAX): Define if the headers do not.
2380 (verror): Do not give up if vsnprintf returns a negative count.
2381 Instead, grow the buffer. This ports to Windows vsnprintf, which
2382 does not conform to C99. Problem reported by Eli Zaretskii.
2383 Also, simplify the allocation scheme, by avoiding the need for
2384 calling realloc, and removing the ALLOCATED variable.
2385
2386 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2387
2388 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2389 But keep the doprint source code for now, as we might revamp it
2390 and use it again (Bug#8435).
2391 * lisp.h (doprnt): Remove.
2392 * Makefile.in (base_obj): Remove doprnt.o.
2393 * deps.mk (doprnt.o): Remove.
2394
2395 error: Print 32- and 64-bit integers portably (Bug#8435).
2396 Without this change, on typical 64-bit hosts error ("...%d...", N)
2397 was used to print both 32- and 64-bit integers N, which relied on
2398 undefined behavior.
2399 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2400 New macro.
2401 * lisp.h (error, verror): Mark as printf-like functions.
2402 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2403 Report overflow in size calculations when allocating printf buffer.
2404 Do not truncate output string at its first null byte.
2405 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2406 Truncate the output at a character boundary, since vsnprintf does not
2407 do that.
2408 * charset.c (check_iso_charset_parameter): Convert internal
2409 character to string before calling 'error', since %c now has the
2410 printf meaning.
2411 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2412 overflow when computing char to be passed to 'error'. Do not
2413 pass Lisp_Object to 'error'; pass the integer instead.
2414 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2415 formatted with plain %d.
2416
2417 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2418
2419 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2420
2421 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2422
2423 * xterm.c (x_catch_errors): Remove duplicate declaration.
2424
2425 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2426
2427 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2428
2429 2011-04-10 Jim Meyering <meyering@redhat.com>
2430
2431 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2432 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2433 return ssize_t not "int", and use size_t as the buffer length.
2434 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2435 * gnutls.h: Update declarations.
2436 * process.c (read_process_output): Use ssize_t, to match.
2437 (send_process): Likewise.
2438
2439 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2440
2441 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2442
2443 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2444
2445 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2446 Use unsigned char, to match FcChar8 type definition.
2447
2448 * xterm.c (handle_one_xevent):
2449 * xmenu.c (create_and_show_popup_menu):
2450 * xselect.c (x_decline_selection_request)
2451 (x_reply_selection_request): Avoid type-punned deref of X events.
2452
2453 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2454
2455 Fix some uses of `int' instead of EMACS_INT.
2456 * search.c (string_match_1, fast_string_match)
2457 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2458 (scan_buffer, find_next_newline_no_quit)
2459 (find_before_next_newline, search_command, Freplace_match)
2460 (Fmatch_data): Make some `int' variables be EMACS_INT.
2461
2462 * xdisp.c (display_count_lines): 3rd argument and return value now
2463 EMACS_INT. All callers changed.
2464 (pint2hrstr): Last argument is now EMACS_INT.
2465
2466 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2467 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2468 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2469 (decode_coding_utf_16, decode_coding_emacs_mule)
2470 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2471 (decode_coding_ccl, decode_coding_charset)
2472 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2473 (decode_coding_iso_2022, decode_coding_emacs_mule)
2474 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2475 <char_offset, last_offset>: Declare EMACS_INT.
2476 (encode_coding_utf_8, encode_coding_utf_16)
2477 (encode_coding_emacs_mule, encode_invocation_designation)
2478 (encode_designation_at_bol, encode_coding_iso_2022)
2479 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2480 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2481 Declare EMACS_INT.
2482 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2483 (encode_invocation_designation): Last argument P_NCHARS is now
2484 EMACS_INT.
2485 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2486 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2487
2488 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2489 All users changed.
2490
2491 * ccl.c (Fccl_execute_on_string): Declare some variables
2492 EMACS_INT.
2493
2494 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2495
2496 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2497
2498 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2499
2500 * process.c (Fformat_network_address): Doc fix.
2501
2502 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2503
2504 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2505
2506 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2507
2508 * keyboard.c (read_char): Call Lisp function help-form-show,
2509 instead of using internal_with_output_to_temp_buffer.
2510 (Qhelp_form_show): New var.
2511 (syms_of_keyboard): Use DEFSYM macro.
2512
2513 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2514
2515 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2516
2517 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2518
2519 * process.c (Flist_processes): Remove to Lisp.
2520 (list_processes_1): Delete.
2521
2522 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2523
2524 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2525
2526 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2527
2528 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2529
2530 Fix more problems found by GCC 4.6.0's static checks.
2531
2532 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2533
2534 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2535
2536 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2537
2538 * xdisp.c (vmessage): Mark as a printf-like function.
2539
2540 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2541
2542 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2543
2544 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2545 printf-like functions.
2546 (tiff_load): Add casts to remove these marks before passing them
2547 to system-supplied API.
2548
2549 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2550
2551 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2552 This avoids several warnings with gcc -Wstrict-overflow.
2553 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2554 directly, rather than having caller test rule sign. This avoids
2555 some unnecessary tests.
2556 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2557 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2558 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2559
2560 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2561 (xfont_open): Avoid unnecessary tests.
2562
2563 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2564
2565 * composite.h, composite.c (composition_gstring_put_cache):
2566 Use EMACS_INT, not int, for length.
2567
2568 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2569 breaking out part of COMPOSITION_DECODE_RULE.
2570 (COMPOSITION_DECODE_RULE): Use it.
2571 * composite.c (get_composition_id): Remove unused local vars,
2572 by using the new macro.
2573
2574 * textprop.c (set_text_properties_1): Change while to do-while,
2575 since the condition is always true at first.
2576
2577 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2578 (interval_deletion_adjustment): Return unsigned value.
2579 All uses changed.
2580
2581 * process.c (list_processes_1, create_pty, read_process_output):
2582 (exec_sentinel): Remove vars that were set but not used.
2583 (create_pty): Remove unnecessary "volatile"s.
2584 (Fnetwork_interface_info): Avoid possibility of int overflow.
2585 (read_process_output): Do adaptive read buffering even if carryover.
2586 (read_process_output): Simplify nbytes computation if buffered.
2587
2588 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2589
2590 * syntax.c (scan_words): Remove var that was set but not used.
2591 (update_syntax_table): Use unsigned instead of int.
2592
2593 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2594 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2595 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2596
2597 * print.c (print_error_message): Avoid int overflow.
2598
2599 * font.c (font_list_entities): Redo for clarity,
2600 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2601
2602 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2603 (font_score): Avoid potential overflow in diff calculation.
2604
2605 * fns.c (substring_both): Remove var that is set but not used.
2606 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2607
2608 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2609
2610 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2611 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2612 can always succeed if overflow has undefined behavior.
2613
2614 * search.c (boyer_moore, wordify): Remove vars set but not used.
2615 (wordify): Omit three unnecessary tests.
2616
2617 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2618 All callers changed. This avoids the need for an unused var.
2619
2620 * casefiddle.c (casify_region): Remove var that is set but not used.
2621
2622 * dired.c (file_name_completion): Remove var that is set but not used.
2623
2624 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2625
2626 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2627 (Finsert_file_contents): Remove unnecessary code checking fd.
2628
2629 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2630 Check for integer overflow on size calculations.
2631
2632 * buffer.c (Fprevious_overlay_change): Remove var that is set
2633 but not used.
2634
2635 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2636 Remove vars that are set but not used.
2637 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2638 (timer_check_2): Mark vars as initialized.
2639
2640 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2641
2642 * image.c (lookup_image): Remove var that is set but not used.
2643 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2644
2645 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2646 that are set but not used.
2647
2648 * xfns.c (make_invisible_cursor): Don't return garbage
2649 if XCreateBitmapFromData fails (Bug#8410).
2650
2651 * xselect.c (x_get_local_selection, x_handle_property_notify):
2652 Remove vars that are set but not used.
2653
2654 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2655 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2656
2657 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2658 Remove var that is set but not used.
2659 (scroll_bar_windows_size): Now size_t, not int.
2660 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2661 Check for overflow.
2662
2663 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2664 (map_tty_color) [!defined MSDOS]: Likewise.
2665
2666 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2667
2668 * coding.c: Remove vars that are set but not used.
2669 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2670 All callers changed.
2671 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2672 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2673 (decode_coding_charset): Remove vars that are set but not used.
2674
2675 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2676 that is set but not used.
2677
2678 * print.c (print_object): Remove var that is set but not used.
2679
2680 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2681 The gnulib version avoids calling malloc in the usual case,
2682 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2683 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2684 * filelock.c (current_lock_owner): Likewise.
2685 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2686 * sysdep.c: Include allocator.h, careadlinkat.h.
2687 (emacs_no_realloc_allocator): New static constant.
2688 (emacs_readlink): New function.
2689 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2690 ../lib/careadlinkat.h.
2691
2692 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2693
2694 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2695 first non-nil return value).
2696
2697 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2698
2699 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2700 if not defined (Bug#8403).
2701
2702 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2703
2704 * xdisp.c (display_count_lines): Remove parameter `start',
2705 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2706 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2707 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2708 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2709 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2710 and thereabouts. All callers changed.
2711 (get_per_char_metric): Remove parameter `f', unused since
2712 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2713
2714 2011-04-02 Jim Meyering <meyering@redhat.com>
2715
2716 do not dereference NULL upon failed strdup
2717 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2718 (ns_get_family): Likewise.
2719
2720 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2721
2722 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2723
2724 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2725
2726 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2727 later (Bug#8403).
2728
2729 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2730
2731 Add lexical binding.
2732
2733 * window.c (Ftemp_output_buffer_show): New fun.
2734 (Fsave_window_excursion):
2735 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2736
2737 * lread.c (lisp_file_lexically_bound_p): New function.
2738 (Fload): Bind Qlexical_binding.
2739 (readevalloop): Remove `evalfun' arg.
2740 Bind Qinternal_interpreter_environment.
2741 (Feval_buffer): Bind Qlexical_binding.
2742 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2743 Mark as dynamic.
2744 (syms_of_lread): Declare `lexical-binding'.
2745
2746 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2747
2748 * keyboard.c (eval_dyn): New fun.
2749 (menu_item_eval_property): Use it.
2750
2751 * image.c (parse_image_spec): Use Ffunctionp.
2752
2753 * fns.c (concat, mapcar1): Accept byte-code-functions.
2754
2755 * eval.c (Fsetq): Handle lexical vars.
2756 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2757 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2758 (FletX, Flet): Obey lexical binding.
2759 (Fcommandp): Handle closures.
2760 (Feval): New `lexical' arg.
2761 (eval_sub): New function extracted from Feval. Use it almost
2762 everywhere where Feval was used. Look up vars in lexical env.
2763 Handle closures.
2764 (Ffunctionp): Move from subr.el.
2765 (Ffuncall): Handle closures.
2766 (apply_lambda): Remove `eval_flags'.
2767 (funcall_lambda): Handle closures and new byte-code-functions.
2768 (Fspecial_variable_p): New function.
2769 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2770 but without exporting it to Lisp.
2771
2772 * doc.c (Fdocumentation, store_function_docstring):
2773 * data.c (Finteractive_form): Handle closures.
2774
2775 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2776 interactive spec.
2777
2778 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2779 New byte-codes.
2780 (exec_byte_code): New function extracted from Fbyte_code to handle new
2781 calling convention for byte-code-functions. Add new byte-codes.
2782
2783 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2784
2785 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2786
2787 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2788
2789 * xdisp.c (redisplay_internal): Fix prototype.
2790
2791 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2792
2793 * xdisp.c (SCROLL_LIMIT): New macro.
2794 (try_scrolling): Use it when setting scroll_limit.
2795 Limit scrolling to 100 screen lines.
2796 (redisplay_window): Even when falling back on "recentering",
2797 position point in the window according to scroll-conservatively,
2798 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2799
2800 (try_scrolling): When point is above the window, allow searching
2801 as far as scroll_max, or one screenful, to compute vertical
2802 distance from PT to the scroll margin position. This prevents
2803 try_scrolling from unnecessarily failing when
2804 scroll-conservatively is set to a value slightly larger than the
2805 window height. Clean up the case of PT below the margin at bottom
2806 of window: scroll_max can no longer be INT_MAX. When aggressive
2807 scrolling is in use, don't let point enter the opposite scroll
2808 margin as result of the scroll.
2809 (syms_of_xdisp) <scroll-conservatively>: Document the
2810 threshold of 100 lines for never-recentering scrolling.
2811
2812 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2813
2814 * dispextern.h (move_it_by_lines):
2815 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2816 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2817 (message_log_check_duplicate): Remove parameters `prev_bol' and
2818 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2819 (redisplay_internal): Remove parameter `preserve_echo_area',
2820 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2821
2822 * indent.c (Fvertical_motion):
2823 * window.c (window_scroll_pixel_based, Frecenter):
2824 Don't pass `need_y_p' to `move_it_by_lines'.
2825
2826 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2827
2828 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2829 steal a few bits to be more compact.
2830 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2831 Remove unneeded casts.
2832
2833 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2834
2835 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2836
2837 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2838 binding" message (bug#7967).
2839
2840 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 Fix more problems found by GCC 4.6.0's static checks.
2843
2844 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2845 Remove unused local var.
2846
2847 * editfns.c (Fmessage_box): Remove unused local var.
2848
2849 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2850 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2851 Omit unused local vars.
2852 * window.c (shrink_windows): Omit unused local var.
2853 * menu.c (digest_single_submenu): Omit unused local var.
2854 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2855 Omit unused local var.
2856
2857 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2858 Don't assume string length fits in int.
2859 (keyremap_step, read_key_sequence): Use size_t for sizes.
2860 (read_key_sequence): Don't check last_real_key_start redundantly.
2861
2862 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2863 instead of alloca (Bug#8344).
2864
2865 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2866 (Fbacktrace_frame): Don't assume nframes fits in int.
2867
2868 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2869
2870 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2871 concerns.
2872
2873 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2874
2875 * cm.c (calccost): Turn while-do into do-while, for clarity.
2876
2877 * keyboard.c (syms_of_keyboard): Use the same style as later
2878 in this function when indexing through an array. This also
2879 works around GCC bug 48267.
2880
2881 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2882
2883 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2884
2885 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2886 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2887
2888 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2889 This avoids undefined behavior on integer overflow, and is a bit
2890 more convenient anyway since it is compared to a size_t variable.
2891
2892 Variadic C functions now count arguments with size_t, not int.
2893 This avoids an unnecessary limitation on 64-bit machines, which
2894 caused (substring ...) to crash on large vectors (Bug#8344).
2895 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2896 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2897 All variadic functions and their callers changed accordingly.
2898 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2899 * data.c (arith_driver, float_arith_driver): Likewise.
2900 * editfns.c (general_insert_function): Likewise.
2901 * eval.c (struct backtrace.nargs, interactive_p)
2902 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2903 (funcall_lambda, mark_backtrace): Likewise.
2904 * fns.c (concat): Likewise.
2905 * frame.c (x_set_frame_parameters): Likewise.
2906 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2907 0 if not found, not -1. All callers changed.
2908
2909 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2910 (stack_copy_size): Now size_t, not int.
2911 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2912
2913 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2914
2915 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2916 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2917 All callers changed.
2918
2919 * lisp.h (multibyte_char_to_unibyte):
2920 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2921 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2922 * character.h (CHAR_TO_BYTE8):
2923 * cmds.c (internal_self_insert):
2924 * editfns.c (general_insert_function):
2925 * keymap.c (push_key_description):
2926 * search.c (Freplace_match):
2927 * xdisp.c (message_dolog, set_message_1): All callers changed.
2928
2929 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2930
2931 * keyboard.c (safe_run_hook_funcall): New function.
2932 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2933 don't set the hook to nil, but remove the offending function instead.
2934 (Qcommand_hook_internal): Remove, unused.
2935 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2936 Vcommand_hook_internal.
2937
2938 * eval.c (enum run_hooks_condition): Remove.
2939 (funcall_nil, funcall_not): New functions.
2940 (run_hook_with_args): Call each function through a `funcall' argument.
2941 Remove `cond' argument, now redundant.
2942 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2943 (Frun_hook_with_args_until_failure): Adjust accordingly.
2944 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2945
2946 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2947
2948 * dispextern.h (string_buffer_position): Remove declaration.
2949
2950 * print.c (strout): Remove parameter `multibyte', unused since
2951 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2952
2953 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2954 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2955 All callers changed.
2956
2957 * w32.c (_wsa_errlist): Use braces for struct initializers.
2958
2959 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2960 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2961 All callers changed.
2962 (string_buffer_position): Likewise. Also, make static (it's never
2963 used outside xdisp.c).
2964 (cursor_row_p): Remove parameter `w', unused since
2965 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2966 (decode_mode_spec): Remove parameter `precision', introduced during
2967 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2968 All callers changed.
2969
2970 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2971
2972 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2973
2974 2011-03-27 Anders Lindgren <andlind@gmail.com>
2975
2976 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2977 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2978 (ns_update_auto_hide_menu_bar): New functions.
2979 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2980 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2981 ns_constrain_all_frames.
2982 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2983 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2984
2985 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2986
2987 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2988
2989 2011-03-27 Glenn Morris <rgm@gnu.org>
2990
2991 * syssignal.h: Replace RETSIGTYPE with void.
2992 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2993 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2994 Replace SIGTYPE with void everywhere.
2995 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2996 * s/template.h (SIGTYPE): Remove commented out definition.
2997
2998 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2999
3000 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3001 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3002
3003 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3004
3005 * w32.c (read_unc_volume): Use parameter `henum', instead of
3006 global variable `wget_enum_handle'.
3007
3008 * keymap.c (describe_vector): Remove parameters `indices' and
3009 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3010 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3011
3012 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3013
3014 * keyboard.c (timer_check): Remove parameter `do_it_now',
3015 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3016 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3017 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3018
3019 * keyboard.c (read_char):
3020 * w32menu.c (w32_menu_display_help):
3021 * xmenu.c (show_help_event, menu_help_callback):
3022 Adjust calls to `show_help_echo'.
3023
3024 * gtkutil.c (xg_maybe_add_timer):
3025 * keyboard.c (readable_events):
3026 * process.c (wait_reading_process_output):
3027 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3028
3029 * insdel.c (adjust_markers_gap_motion):
3030 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3031 (gap_left, gap_right): Don't call it.
3032
3033 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3034
3035 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3036 incurred during fontification.
3037
3038 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3039
3040 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3041 (DEFVAR_PER_BUFFER): Don't pass it.
3042
3043 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3044 (scrolling_window): Don't pass it.
3045
3046 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3047
3048 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3049
3050 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3051 and `suffix'.
3052 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3053 of variables specific to SELinux and computation of `encoded_absname'.
3054
3055 * image.c (XPutPixel): Remove unused variable `height'.
3056
3057 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3058
3059 * unexw32.c (get_section_info): Remove unused variable `section'.
3060
3061 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3062 (system_process_attributes): Remove unused variable `sess'.
3063 (sys_read): Remove unused variable `err'.
3064
3065 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3066 (w32_wnd_proc): Remove unused variable `isdead'.
3067 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3068 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3069 (x_create_tip_frame): Remove unused variable `tem'.
3070
3071 * w32inevt.c (w32_console_read_socket):
3072 Remove unused variable `no_events'.
3073
3074 * w32term.c (x_draw_composite_glyph_string_foreground):
3075 Remove unused variable `width'.
3076
3077 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3078
3079 * w32term.c (x_set_glyph_string_clipping):
3080 Don't pass uninitialized region to CombineRgn.
3081
3082 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3083
3084 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3085 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3086 (Fx_close_connection): Remove unused variable `i'.
3087
3088 * w32font.c (w32font_draw): Return number of glyphs.
3089 (w32font_open_internal): Remove unused variable `i'.
3090 (w32font_driver): Add missing initializer.
3091
3092 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3093 (fill_in_menu): Remove unused variable `items_added'.
3094
3095 * w32term.c (last_mouse_press_frame): Remove static global variable.
3096 (w32_clip_to_row): Remove unused variable `f'.
3097 (x_delete_terminal): Remove unused variable `i'.
3098
3099 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3100 (NOTHING): Remove unused static global variable.
3101 (uniscribe_check_otf): Remove unused variable `table'.
3102 (uniscribe_font_driver): Add missing initializers.
3103
3104 2011-03-23 Julien Danjou <julien@danjou.info>
3105
3106 * term.c (Fsuspend_tty, Fresume_tty):
3107 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3108 * window.c (temp_output_buffer_show):
3109 * insdel.c (signal_before_change):
3110 * frame.c (Fhandle_switch_frame):
3111 * fileio.c (Fdo_auto_save):
3112 * emacs.c (Fkill_emacs):
3113 * editfns.c (save_excursion_restore):
3114 * cmds.c (internal_self_insert):
3115 * callint.c (Fcall_interactively):
3116 * buffer.c (Fkill_all_local_variables):
3117 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3118 Use Frun_hooks.
3119 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3120 unconditionnaly since it does the check itself.
3121
3122 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3123
3124 Fix more problems found by GCC 4.5.2's static checks.
3125
3126 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3127 the first time through the loop, since we know p0 < p1 then.
3128 This also avoids a gcc -Wstrict-overflow warning.
3129
3130 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3131 leading to a memory leak, possible in functions like
3132 load_charset_map_from_file that can allocate an unbounded number
3133 of objects (Bug#8318).
3134
3135 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3136 that could (at least in theory) be that large.
3137
3138 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3139 This is less likely to overflow, and avoids undefined behavior if
3140 overflow does occur. All callers changed. Use strtoul to scan
3141 for the unsigned long integer.
3142 (pint2hrstr): Simplify and tune code slightly.
3143 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3144
3145 * scroll.c (do_scrolling): Work around GCC bug 48228.
3146 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3147
3148 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3149 This also avoids a warning with gcc -Wstrict-overflow.
3150 (validate_x_resource_name): Simplify count usage.
3151 This also avoids a warning with gcc -Wstrict-overflow.
3152
3153 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3154 fail (Bug#8306).
3155
3156 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3157
3158 * process.c (Fmake_network_process): Use socklen_t, not int,
3159 where POSIX says socklen_t is required in portable programs.
3160 This fixes a porting bug on hosts like 64-bit HP-UX, where
3161 socklen_t is wider than int (Bug#8277).
3162 (Fmake_network_process, server_accept_connection):
3163 (wait_reading_process_output, read_process_output):
3164 Likewise.
3165
3166 * process.c: Rename or move locals to avoid shadowing.
3167 (list_processes_1, Fmake_network_process):
3168 (read_process_output_error_handler, exec_sentinel_error_handler):
3169 Rename or move locals.
3170 (Fmake_network_process): Define label "retry_connect" only if needed.
3171 (Fnetwork_interface_info): Fix pointer signedness.
3172 (process_send_signal): Add cast to avoid pointer signedness problem.
3173 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3174 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3175
3176 Make tparam.h and terminfo.c consistent.
3177 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3178 Include tparam.h instead, since it declares them.
3179 * cm.h (PC): Remove extern decl; tparam.h now does this.
3180 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3181 * terminfo.c: Include tparam.h, to check interfaces.
3182 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3183 (tparam): Adjust signature to match interface in tparam.h;
3184 this removes some undefined behavior. Check that outstring and len
3185 are zero, which they always are with Emacs.
3186 * tparam.h (PC, BC, UP): New extern decls.
3187
3188 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3189 (xftfont_open): Rename locals to avoid shadowing.
3190
3191 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3192 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3193 (OTF_TAG_SYM): Omit macro if not needed.
3194 (ftfont_list): Remove unused local.
3195 (get_adstyle_property, ftfont_pattern_entity):
3196 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3197 Rename locals to avoid shadowing.
3198
3199 * xfont.c (xfont_list_family): Mark var as initialized.
3200
3201 * xml.c (make_dom): Now static.
3202
3203 * composite.c (composition_compute_stop_pos): Rename local to
3204 avoid shadowing.
3205 (composition_reseat_it): Remove unused locals.
3206 (find_automatic_composition, composition_adjust_point): Likewise.
3207 (composition_update_it): Mark var as initialized.
3208 (find_automatic_composition): Mark vars as initialized,
3209 with a FIXME (Bug#8290).
3210
3211 character.h: Rename locals to avoid shadowing.
3212 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3213 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3214 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3215 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3216 to avoid shadowing.
3217
3218 * textprop.c (property_change_between_p): Remove; unused.
3219
3220 * intervals.c (interval_start_pos): Now static.
3221
3222 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3223
3224 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3225 Rename locals to avoid shadowing.
3226
3227 * sound.c (wav_play, au_play, Fplay_sound_internal):
3228 Fix pointer signedness.
3229 (alsa_choose_format): Remove unused local var.
3230 (wav_play): Initialize a variable to 0, to prevent undefined
3231 behavior (Bug#8278).
3232
3233 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3234
3235 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3236
3237 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3238 clobbering (Bug#8298).
3239 * sysdep.c (sys_subshell): Likewise.
3240 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3241
3242 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3243 This should get cleaned up, so that child_setup has the
3244 same signature on all platforms.
3245
3246 * callproc.c (call_process_cleanup): Now static.
3247 (relocate_fd): Rename locals to avoid shadowing.
3248
3249 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3250
3251 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3252 not to be necessary, and produces flickering.
3253
3254 2011-03-20 Glenn Morris <rgm@gnu.org>
3255
3256 * config.in: Remove file.
3257
3258 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3259
3260 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3261 are now in src/globals.h.
3262 (syms_of_minibuf): Remove spurious & from previous change.
3263
3264 2011-03-20 Leo <sdl.web@gmail.com>
3265
3266 * minibuf.c (completing-read-function): New variable.
3267 (completing-read-default): Rename from completing-read.
3268 (completing-read): Call completing-read-function.
3269
3270 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3271
3272 * xfaces.c (Fx_load_color_file):
3273 Read color file from absolute filename (bug#8250).
3274
3275 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3276
3277 * makefile.w32-in: Update dependencies.
3278
3279 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3280
3281 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3282
3283 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3284
3285 Fix more problems found by GCC 4.5.2's static checks.
3286
3287 * process.c (make_serial_process_unwind, send_process_trap):
3288 (sigchld_handler): Now static.
3289
3290 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3291 That way, the code declares only the vars that it needs.
3292 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3293 * s/cygwin.h (PTY_ITERATION): Likewise.
3294 * s/darwin.h (PTY_ITERATION): Likewise.
3295 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3296
3297 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3298 * process.c (allocate_pty): Don't declare stb unless it's needed.
3299
3300 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3301 (CONSTANTLIM): Remove; unused.
3302 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3303 Define only if needed.
3304
3305 * unexelf.c (unexec): Name an expression,
3306 to avoid gcc -Wbad-function-cast warning.
3307 Use a different way to cause a compilation error if anyone uses
3308 n rather than nn, a way that does not involve shadowing.
3309 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3310
3311 * deps.mk (unexalpha.o): Remove; unused.
3312
3313 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3314 * unexec.h: New file.
3315 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3316 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3317 Depend on unexec.h.
3318 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3319 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3320 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3321 Change as necessary to match prototype in unexec.h.
3322
3323 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3324 shadowing.
3325 (back_comment, skip_chars): Mark vars as initialized.
3326
3327 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3328 Rename locals to avoid shadowing.
3329
3330 * lread.c (read1): Rewrite so as not to use empty "else".
3331 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3332
3333 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3334
3335 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3336 warning when compiling print.c.
3337
3338 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3339 instead of using an uninitialized var.
3340 (font_sort_entities): Mark var as initialized.
3341
3342 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3343
3344 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3345 pointers to constants.
3346 (font_parse_fcname): Remove unused vars.
3347 (font_delete_unmatched): Now static.
3348 (font_get_spec): Remove; unused.
3349 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3350 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3351 Rename or move locals to avoid shadowing.
3352
3353 * fns.c (require_nesting_list, require_unwind): Now static.
3354 (Ffillarray): Rename locals to avoid shadowing.
3355
3356 * floatfns.c (domain_error2): Define only if needed.
3357 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3358
3359 * alloc.c (mark_backtrace): Move decl from here ...
3360 * lisp.h: ... to here, so that it can be checked.
3361
3362 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3363 (Fdefvar): Rewrite so as not to use empty "else".
3364 (lisp_indirect_variable): Name an expression,
3365 to avoid gcc -Wbad-function-cast warning.
3366 (Fdefvar): Rename locals to avoid shadowing.
3367
3368 * callint.c (quotify_arg, quotify_args): Now static.
3369 (Fcall_interactively): Rename locals to avoid shadowing.
3370 Use const pointer when appropriate.
3371
3372 * lisp.h (get_system_name, get_operating_system_release):
3373 Move decls here, to check interfaces.
3374 * process.c (get_operating_system_release): Move decl to lisp.h.
3375 * xrdb.c (get_system_name): Likewise.
3376 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3377 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3378 some of which prompt warnings from gcc -Wbad-function-cast.
3379 (Fformat_time_string, Fencode_time, Finsert_char):
3380 (Ftranslate_region_internal, Fformat):
3381 Rename or remove local vars to avoid shadowing.
3382 (Ftranslate_region_internal): Mark var as initialized.
3383
3384 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3385 avoid shadowing.
3386
3387 * lisp.h (eassert): Check that the argument compiles, even if
3388 ENABLE_CHECKING is not defined.
3389
3390 * data.c (Findirect_variable): Name an expression, to avoid
3391 gcc -Wbad-function-cast warning.
3392 (default_value, arithcompare, arith_driver, arith_error): Now static.
3393 (store_symval_forwarding): Rename local to avoid shadowing.
3394 (Fmake_variable_buffer_local, Fmake_local_variable):
3395 Mark variables as initialized.
3396 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3397
3398 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3399 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3400 Rename locals to avoid shadowing.
3401 (mark_stack): Move local variables into the #ifdef region where
3402 they're used.
3403 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3404 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3405 needed otherwise.
3406 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3407 (GC_STRING_CHARS): Remove; not used.
3408 (Fmemory_limit): Cast sbrk's returned value to char *.
3409
3410 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3411 avoids undefined behavior in theory.
3412
3413 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3414
3415 Use functions, not macros, for up- and down-casing (Bug#8254).
3416 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3417 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3418 to use the following functions instead of these macros.
3419 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3420 EMACS_INT, since callers assume the returned value fits in int.
3421 (upcase1): Likewise, for UPCASE_TABLE.
3422 (uppercasep, lowercasep, upcase): New static inline functions.
3423 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3424 the race-condition problem in the old DOWNCASE.
3425
3426 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3427 Rename locals to avoid shadowing.
3428 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3429 (regex_compile, re_search_2, re_match_2_internal):
3430 Remove unused local vars.
3431 (FREE_VAR): Rewrite so as not to use empty "else",
3432 which gcc can warn about.
3433 (regex_compile, re_match_2_internal): Mark locals as initialized.
3434 (RETALLOC_IF): Define only if needed.
3435 (WORDCHAR_P): Likewise. This one is never needed, but is used
3436 only in a comment talking about a compiler bug, so put inside
3437 the #if 0 of that comment.
3438 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3439 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3440 Remove; unused.
3441
3442 * search.c (boyer_moore): Rename locals to avoid shadowing.
3443 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3444 (PREV_CHAR_BOUNDARY): Likewise.
3445
3446 * search.c (simple_search): Remove unused var.
3447
3448 * dired.c (compile_pattern): Move decl from here ...
3449 * lisp.h: ... to here, so that it can be checked.
3450 (struct re_registers): New forward decl.
3451
3452 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3453
3454 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3455 All uses changed.
3456 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3457 Rename locals to avoid shadowing.
3458 (Fvertical_motion): Mark locals as initialized.
3459
3460 * casefiddle.c (casify_object, casify_region): Now static.
3461 (casify_region): Mark local as initialized.
3462
3463 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3464
3465 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3466 New macros, so that the caller can use some names other than
3467 gcpro1, gcpro2, etc.
3468 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3469 of the new macros.
3470 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3471 argument, for consistency with GCPRO2_VAR, etc: it is now the
3472 prefix of the variable, not the variable itself. All uses
3473 changed.
3474 * dired.c (directory_files_internal, file_name_completion):
3475 Rename locals to avoid shadowing.
3476
3477 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3478 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3479 dired.c's scmp function, had undefined behavior.
3480 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3481 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3482 * buffer.h: ... to here, because these macros use current_buffer,
3483 and the new implementation with inline functions needs to have
3484 current_buffer in scope now, rather than later when the macros
3485 are used.
3486 (downcase, upcase1): New static inline functions.
3487 (DOWNCASE, UPCASE1): Reimplement using these functions.
3488 This avoids undefined behavior in expressions like
3489 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3490 from race conditions in accessing the global variables
3491 case_temp1 and case_temp2.
3492 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3493 * lisp.h (case_temp1, case_temp2): Remove their decls.
3494 * character.h (ASCII_CHAR_P): Move from here ...
3495 * lisp.h: ... to here, so that the inline functions mentioned
3496 above can use them.
3497
3498 * dired.c (directory_files_internal_unwind): Now static.
3499
3500 * fileio.c (file_name_as_directory, directory_file_name):
3501 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3502 Now static.
3503 (file_name_as_directory): Use const pointers when appropriate.
3504 (Fexpand_file_name): Likewise. In particular, newdir might
3505 point at constant storage, so make it a const pointer.
3506 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3507 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3508 signedness issues.
3509 (Fset_file_times, Finsert_file_contents, auto_save_error):
3510 Rename locals to avoid shadowing.
3511
3512 * minibuf.c (choose_minibuf_frame_1): Now static.
3513 (Ftry_completion, Fall_completions): Rename or remove locals
3514 to avoid shadowing.
3515
3516 * marker.c (bytepos_to_charpos): Remove; unused.
3517
3518 * lisp.h (verify_bytepos, count_markers): New decls,
3519 so that gcc does not warn that these functions aren't declared.
3520
3521 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3522 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3523 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3524 (copy_text): Remove unused local var.
3525
3526 * filelock.c (within_one_second): Now static.
3527 (lock_file_1): Rename local to avoid shadowing.
3528
3529 * buffer.c (fix_overlays_before): Mark locals as initialized.
3530 (fix_start_end_in_overlays): Likewise. This function should be
3531 simplified by using pointers-to-pointers, but that's a different
3532 matter.
3533 (switch_to_buffer_1): Now static.
3534 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3535 (report_overlay_modification): Rename locals to avoid shadowing.
3536
3537 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3538 Fix pointer signedness issue.
3539 (sys_subshell): Mark local as volatile if checking for lint,
3540 to suppress a gcc -Wclobbered warning that does not seem to be right.
3541 (MAXPATHLEN): Define only if needed.
3542
3543 * process.c (serial_open, serial_configure): Move decls from here ...
3544 * systty.h: ... to here, so that they can be checked.
3545
3546 * fns.c (get_random, seed_random): Move extern decls from here ...
3547 * lisp.h: ... to here, so that they can be checked.
3548
3549 * sysdep.c (reset_io): Now static.
3550 (wait_for_termination_signal): Remove; unused.
3551
3552 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3553 (copy_keymap_item, append_key, push_text_char_description):
3554 Now static.
3555 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3556 (DENSE_TABLE_SIZE): Remove; unused.
3557 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3558 (describe_map_tree):
3559 Rename locals to avoid shadowing.
3560
3561 * keyboard.c: Declare functions static if they are not used elsewhere.
3562 (echo_char, echo_dash, cmd_error, top_level_2):
3563 (poll_for_input, handle_async_input): Now static.
3564 (read_char, kbd_buffer_get_event, make_lispy_position):
3565 (make_lispy_event, make_lispy_movement, apply_modifiers):
3566 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3567 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3568 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3569 (read_key_sequence, read_char): Mark locals as initialized.
3570 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3571
3572 * keyboard.h (make_ctrl_char): New decl.
3573 (mark_kboards): Move decl here ...
3574 * alloc.c (mark_kboards): ... from here.
3575
3576 * lisp.h (force_auto_save_soon): New decl.
3577
3578 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3579 (DEFINE_DUMMY_FUNCTION): New macro.
3580 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3581 Use it.
3582 (main): Add casts to avoid warnings
3583 if GCC considers string literals to be constants.
3584
3585 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3586
3587 * dbusbind.c: Pointer signedness fixes.
3588 (xd_signature, xd_append_arg, xd_initialize):
3589 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3590 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3591 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3592 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3593
3594 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3595 if GCC considers string literals to be constants.
3596 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3597
3598 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3599
3600 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3601 (print_preprocess, print_object): New macro to fix last change.
3602
3603 * print.c (print_preprocess): Don't forget font objects.
3604
3605 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * emacs.c (USAGE3): Doc fixes.
3608
3609 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3610
3611 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3612 structure.
3613
3614 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3615
3616 * lisp.h (VWindow_system, Qfile_name_history):
3617 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3618 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3619 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3620
3621 * w32select.c: Don't #include "keyboard.h".
3622 (run_protected): Add extern declaration for waiting_for_input.
3623
3624 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3625 * w32console.c (detect_input_pending, read_input_pending)
3626 (encode_terminal_code):
3627 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3628 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3629 (w32_system_caret_y, Qfile_name_history):
3630 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3631 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3632 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3633 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3634 * w32proc.c (Qlocal, report_file_error):
3635 * w32term.c (Vwindow_system, updating_frame):
3636 * w32uniscribe.c (initialized, uniscribe_font_driver):
3637 Remove unneeded extern declarations.
3638
3639 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3640
3641 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3642
3643 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3644
3645 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3646 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3647 These macros can no longer be used for assignment.
3648
3649 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3650 Assign struct members directly, instead of using BUF_BEGV etc.
3651 (record_buffer_markers, fetch_buffer_markers): New functions for
3652 recording and fetching special buffer markers.
3653 (set_buffer_internal_1, set_buffer_temp): Use them.
3654
3655 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3656
3657 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3658
3659 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3660 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3661
3662 * xdisp.c (hscroll_window_tree):
3663 (reconsider_clip_changes): Use PT instead of BUF_PT.
3664
3665 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3666
3667 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3668 $(EMACS_ROOT)/lib/intprops.h.
3669
3670 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3671
3672 Fix more problems found by GCC 4.5.2's static checks.
3673
3674 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3675 to unsigned char * to avoid compiler diagnostic.
3676 (xg_free_frame_widgets): Make it clear that a local variable is
3677 needed only if USE_GTK_TOOLTIP.
3678 (gdk_window_get_screen): Make it clear that this macro is needed
3679 only if USE_GTK_TOOLTIP.
3680 (int_gtk_range_get_value): New function, which avoids a diagnostic
3681 from gcc -Wbad-function-cast.
3682 (xg_set_toolkit_scroll_bar_thumb): Use it.
3683 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3684 diagnostic from gcc -Wbad-function-cast.
3685 (get_utf8_string, xg_get_file_with_chooser):
3686 Rename locals to avoid shadowing.
3687 (create_dialog): Move locals to avoid shadowing.
3688
3689 * xgselect.c (xg_select): Remove unused var.
3690
3691 * image.c (four_corners_best): Mark locals as initialized.
3692 (gif_load): Initialize transparent_p to zero (Bug#8238).
3693 Mark another local as initialized.
3694 (my_png_error, my_error_exit): Mark with NO_RETURN.
3695
3696 * image.c (clear_image_cache): Now static.
3697 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3698 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3699 (x_edge_detection): Remove unnecessary cast that
3700 gcc -Wbad-function-cast diagnoses.
3701 (gif_load): Fix pointer signedness.
3702 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3703 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3704
3705 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 Improve quality of tests for time stamp overflow.
3708 For example, without this patch (encode-time 0 0 0 1 1
3709 1152921504606846976) returns the obviously-bogus value (-948597
3710 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3711 reports time overflow. See
3712 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3713 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3714 * editfns.c: Include limits.h and intprops.h.
3715 (TIME_T_MIN, TIME_T_MAX): New macros.
3716 (time_overflow): Move earlier, to before first use.
3717 (hi_time, lo_time): New functions, for an accurate test for
3718 out-of-range times.
3719 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3720 (Fget_internal_run_time): Don't assume time_t fits in int.
3721 (make_time): Use list2 instead of Fcons twice.
3722 (Fdecode_time): More accurate test for out-of-range times.
3723 (check_tm_member): New function.
3724 (Fencode_time): Use it, to test for out-of-range times.
3725 (lisp_time_argument): Don't rely on undefined left-shift and
3726 right-shift behavior when checking for time stamp overflow.
3727
3728 * editfns.c (time_overflow): New function, refactoring common code.
3729 (Fformat_time_string, Fdecode_time, Fencode_time):
3730 (Fcurrent_time_string): Use it.
3731
3732 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3733 * dired.c (make_time): Move to ...
3734 * editfns.c (make_time): ... here.
3735 * systime.h: Note the move.
3736
3737 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3738
3739 * fringe.c (update_window_fringes): Remove unused variables.
3740
3741 * unexmacosx.c (copy_data_segment): Also copy __got section.
3742 (Bug#8223)
3743
3744 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3745
3746 * termcap.c [MSDOS]: Include "msdos.h".
3747 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3748 Constify `char *' arguments and their references according to
3749 prototypes in tparam.h.
3750
3751 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3752
3753 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3754 Adapt all references accordingly.
3755
3756 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3757
3758 2011-03-11 Tom Tromey <tromey@redhat.com>
3759
3760 * buffer.c (syms_of_buffer): Remove obsolete comment.
3761
3762 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3763
3764 * termhooks.h (encode_terminal_code): Declare prototype.
3765
3766 * msdos.c (encode_terminal_code): Don't declare prototype.
3767
3768 * term.c (encode_terminal_code): Now external again, used by
3769 w32console.c and msdos.c.
3770
3771 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3772 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3773
3774 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3775
3776 Fix some minor problems found by GCC 4.5.2's static checks.
3777
3778 * fringe.c (update_window_fringes): Mark locals as initialized
3779 (Bug#8227).
3780 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3781
3782 * alloc.c (mark_fringe_data): Move decl from here ...
3783 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3784 to check its interface.
3785 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3786
3787 * fontset.c (free_realized_fontset): Now static.
3788 (Fset_fontset_font): Rename local to avoid shadowing.
3789 (fontset_font): Mark local as initialized.
3790 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3791
3792 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3793
3794 * xselect.c (x_disown_buffer_selections): Remove; not used.
3795 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3796 (x_own_selection, Fx_disown_selection_internal): Rename locals
3797 to avoid shadowing.
3798 (x_handle_dnd_message): Remove local to avoid shadowing.
3799
3800 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3801 so that the caller can use some name other than gcpro1.
3802 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3803 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3804 (Fx_backspace_delete_keys_p):
3805 Use them to avoid shadowing, and rename vars to avoid shadowing.
3806 (x_decode_color, x_set_name, x_window): Now static.
3807 (Fx_create_frame): Add braces to silence GCC warning.
3808 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3809 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3810 Remove unused locals.
3811 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3812 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3813 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3814 macros.
3815
3816 * xterm.h (x_mouse_leave): New decl.
3817
3818 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3819 Remove unused functions.
3820 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3821 (x_calc_absolute_position): Now static.
3822 (XTread_socket): Don't define label "out" unless it's used.
3823 Don't declare local "event" unless it's used.
3824 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3825 unless they are used.
3826 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3827 (x_fatal_error_signal): Remove; not used.
3828 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3829 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3830 (x_error_catcher, x_connection_closed, x_error_handler):
3831 (x_error_quitter, xembed_send_message, x_iconify_frame):
3832 (my_log_handler): Rename locals to avoid shadowing.
3833 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3834 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3835
3836 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3837 Rename or move locals to avoid shadowing.
3838 (tty_defined_color, merge_face_heights): Now static.
3839 (free_realized_faces_for_fontset): Remove; not used.
3840 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3841 does not deduce is never used uninitialized.
3842 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3843 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3844
3845 * terminal.c (store_terminal_param): Now static.
3846
3847 * xmenu.c (menu_highlight_callback): Now static.
3848 (set_frame_menubar): Remove unused local.
3849 (xmenu_show): Rename parameter to avoid shadowing.
3850 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3851 since they might point to immutable storage.
3852 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3853 since it's unused otherwise.
3854
3855 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3856 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3857 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3858 avoids a gcc -Wuninitialized diagnostic.
3859 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3860 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3861 does not deduce are never used uninitialized.
3862
3863 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3864
3865 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3866 * window.c (window_loop, size_window):
3867 (run_window_configuration_change_hook, enlarge_window): Likewise.
3868
3869 * window.c (display_buffer): Now static.
3870 (size_window): Mark variables that gcc -Wuninitialized
3871 does not deduce are never used uninitialized.
3872 * window.h (check_all_windows): New decl, to forestall
3873 gcc -Wmissing-prototypes diagnostic.
3874 * dispextern.h (bidi_dump_cached_states): Likewise.
3875
3876 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3877 shadowing.
3878 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3879 Include <limits.h>.
3880 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3881 and to avoid gcc -Wuninitialized warning.
3882 (load_charset_map): Mark variables that gcc -Wuninitialized
3883 does not deduce are never used uninitialized.
3884 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3885
3886 * coding.c (coding_set_source, coding_set_destination):
3887 Use "else { /* comment */ }" rather than "else /* comment */;"
3888 for clarity, and to avoid gcc -Wempty-body warning.
3889 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3890 a block, when the outer 'i' will do.
3891 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3892 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3893 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3894 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3895 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3896 Rename locals to avoid shadowing.
3897 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3898 * coding.c (emacs_mule_char, encode_invocation_designation):
3899 Now static, since they're not used elsewhere.
3900 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3901 (decode_coding_object, encode_coding_object, detect_coding_system):
3902 (decode_coding_emacs_mule): Mark variables that gcc
3903 -Wuninitialized does not deduce are never used uninitialized.
3904 (detect_coding_iso_2022): Initialize a local variable that might
3905 be used uninitialized. Leave a FIXME because it's not clear that
3906 this initialization is needed. (Bug#8211)
3907 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3908 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3909 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3910 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3911 Remove unused macros.
3912
3913 * category.c (hash_get_category_set): Remove unused local var.
3914 (copy_category_table): Now static, since it's not used elsewhere.
3915 * character.c (string_count_byte8): Likewise.
3916
3917 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3918 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3919
3920 * chartab.c (copy_sub_char_table): Now static, since it's not used
3921 elsewhere.
3922 (sub_char_table_ref_and_range, char_table_ref_and_range):
3923 Rename locals to avoid shadowing.
3924 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3925
3926 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3927 (BIDI_BOB): Remove unused macro.
3928
3929 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3930 deduce are never used uninitialized.
3931 * term.c (encode_terminal_code): Likewise.
3932
3933 * term.c (encode_terminal_code): Now static. Remove unused local.
3934
3935 * tparam.h: New file.
3936 * term.c, tparam.h: Include it.
3937 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3938 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3939 Move these decls to tparam.h, and make them agree with what
3940 is actually in tparam.c. The previous trick of using incompatible
3941 decls in different modules does not conform to the C standard.
3942 All callers of tparam changed to use tparam's actual API.
3943 * tparam.c (tparam1, tparam, tgoto):
3944 Use const pointers where appropriate.
3945
3946 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3947 * cm.h (struct cm): Likewise.
3948 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3949 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3950 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3951 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3952 (turn_on_face, init_tty): Likewise.
3953 * termchar.h (struct tty_display_info): Likewise.
3954
3955 * term.c (term_mouse_position): Rename local to avoid shadowing.
3956
3957 * alloc.c (mark_ttys): Move decl from here ...
3958 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3959
3960 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3961
3962 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3963
3964 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3965
3966 * search.c (compile_pattern_1): Remove argument regp, unused since
3967 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3968 (compile_pattern): Don't pass it.
3969
3970 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3971
3972 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3973 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3974 for ! HAVE_GTK3.
3975 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3976
3977 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3978
3979 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3980 gdk_window_get_screen, gdk_window_get_geometry,
3981 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3982 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3983 (xg_get_pixbuf_from_pixmap): New function.
3984 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3985 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3986 Call xg_get_pixbuf_from_pixmap instead of
3987 gdk_pixbuf_get_from_drawable.
3988 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3989 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3990 (xg_check_special_colors): Use GtkStyleContext and its functions
3991 for HAVE_GTK3.
3992 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3993 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3994 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3995 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3996 Call gtk_widget_get_preferred_size.
3997 (xg_frame_resized): gdk_window_get_geometry only takes 5
3998 parameters.
3999 (xg_win_to_widget, xg_event_is_for_menubar):
4000 Call gdk_x11_window_lookup_for_display.
4001 (xg_set_widget_bg): New function.
4002 (delete_cb): New function.
4003 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4004 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4005 (xg_set_background_color): Call xg_set_widget_bg.
4006 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4007 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4008 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4009 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4010 if ! HAVE_GTK3.
4011 (update_frame_tool_bar): Call gtk_widget_hide.
4012 (xg_initialize): Use GDK_KEY_g.
4013
4014 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4015 if ! HAVE_GTK3
4016 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4017
4018 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4019 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4020 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4021
4022 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * w32xfns.c (select_palette): Check success of RealizePalette against
4025 GDI_ERROR, not zero.
4026
4027 See ChangeLog.11 for earlier changes.
4028
4029 ;; Local Variables:
4030 ;; coding: utf-8
4031 ;; End:
4032
4033 Copyright (C) 2011 Free Software Foundation, Inc.
4034
4035 This file is part of GNU Emacs.
4036
4037 GNU Emacs is free software: you can redistribute it and/or modify
4038 it under the terms of the GNU General Public License as published by
4039 the Free Software Foundation, either version 3 of the License, or
4040 (at your option) any later version.
4041
4042 GNU Emacs is distributed in the hope that it will be useful,
4043 but WITHOUT ANY WARRANTY; without even the implied warranty of
4044 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4045 GNU General Public License for more details.
4046
4047 You should have received a copy of the GNU General Public License
4048 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.