1 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4 Assume USE_2_TAGS_FOR_INTS.
5 (xreload): Adjust $tagmask width to match recent lisp.h change.
7 Simplify lisp.h in minor ways that should not affect code.
8 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
9 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
10 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
11 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
12 (INTTYPEBITS): New macro, for clarity.
13 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
14 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
15 now that USE_LSB_TAG is always defined.
16 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
17 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
19 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
21 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
23 2012-06-13 Glenn Morris <rgm@gnu.org>
25 * s/bsd-common.h (BSD4_3):
26 * s/usg5-4-common.h (USG5_4): No longer define; unused.
28 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
30 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
33 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
35 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
36 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
37 * alloc.c (widen_to_Lisp_Object): Removed.
38 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
39 * frame.c (delete_frame): Remove outdated comment.
40 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
42 (Fw32_unregister_hot_key): Likewise.
43 (Fw32_toggle_lock_key): Likewise.
44 * w32menu.c (add_menu_item): Likewise.
45 (w32_menu_display_help): Use XIL instead of checking
47 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
48 (init_heap): Likewise.
49 * w32term.c (w32_read_socket): Update comment.
51 2012-06-13 Glenn Morris <rgm@gnu.org>
53 * s/usg5-4-common.h, src/s/unixware.h:
54 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
56 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
58 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
60 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
61 * alloc.c (make_number) [!defined make_number]:
62 Remove, as lisp.h always defines this now.
63 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
64 (roundup_size): Verify that it is a power of 2.
65 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
66 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
67 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
68 -DUSE_LSB_TAG=0, to override the automatically-selected default.
69 USE_LSB_TAG now is always defined to be either 0 or 1.
71 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
72 code works fine either way, and efficiency is not a concern here,
73 as the union type is for debugging, not for production.
74 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
75 Use an inline function on all platforms when using the union type,
76 since this is simpler and 'static inline' can be used portably
78 (LISP_INITIALLY_ZERO): New macro.
79 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
80 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
82 2012-06-12 Glenn Morris <rgm@gnu.org>
84 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
86 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
88 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
89 Move BROKEN_SIGIO to configure.
91 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
92 Move NO_TERMIO to configure.
94 2012-06-12 Chong Yidong <cyd@gnu.org>
96 * image.c (imagemagick_load_image): Use MagickFlattenImage if
97 MagickMergeImageLayers is undefined. Use pixel pusher loop if
98 MagickExportImagePixels is undefined.
100 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
102 * image.c (imagemagick_load_image): Remove unused label.
104 2012-06-11 Glenn Morris <rgm@gnu.org>
106 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
107 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
108 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
109 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
111 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
113 * alloc.c (make_byte_code): New function.
114 (Fmake_byte_code): Use it. Don't purify here.
115 * lread.c (read1): Use it as well to avoid extra allocation.
117 2012-06-11 Chong Yidong <cyd@gnu.org>
119 * image.c (imagemagick_load_image): Implement transparency.
121 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
123 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
124 account for preceding backslashes. (Bug#11663)
126 2012-06-09 Chong Yidong <cyd@gnu.org>
128 * term.c: Support italics in capable terminals (Bug#9652).
129 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
130 (turn_on_face): Output using TS_enter_italic_mode if available.
131 Don't handle unused blinking and alt-charset cases.
132 (turn_off_face): Handle italic case; discard unused tty_blinking_p
133 and tty_alt_charset_p cases.
134 (tty_capable_p, init_tty): Support italics.
136 * termchar.h (struct tty_display_info): Add field for italics.
137 Remove unused blink field.
139 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
142 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
143 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
144 tty_alt_charset_p. Add tty_italic_p.
146 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
148 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
149 dbus_type_is_basic if available.
150 (xd_extract_signed, xd_extract_unsigned): Rename from
151 extract_signed and extract_unsigned, respectively. Adapt callers.
153 2012-06-09 Chong Yidong <cyd@gnu.org>
155 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
157 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
160 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
162 * xdisp.c (vmessage): Treat frame message as multibyte.
163 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
164 would generate the diagnostic "Making \302\247 buffer-local while
167 2012-06-08 Eli Zaretskii <eliz@gnu.org>
169 * dispnew.c (showing_window_margins_p): Undo last change, which
170 was done due to an inadvertent commit.
171 (adjust_frame_glyphs_for_frame_redisplay): Do call
172 showing_window_margins_p.
174 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
176 * eval.c (Fmake_var_non_special): New primitive.
177 (syms_of_eval): Defsubr it.
178 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
180 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
182 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
183 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
185 2012-06-08 Eli Zaretskii <eliz@gnu.org>
187 * alloc.c (allocate_vectorlike): Fix last change.
189 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
191 Block-based vector allocation of small vectors.
192 * lisp.h (struct vectorlike_header): New field `nbytes',
193 adjust comment accordingly.
194 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
195 to denote vector blocks. Adjust users (live_vector_p,
196 mark_maybe_pointer, valid_lisp_object_p) accordingly.
197 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
198 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
199 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
200 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
201 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
202 (roundup_size): New constant.
203 (struct vector_block): New data type.
204 (vector_blocks, vector_free_lists, zero_vector): New variables.
205 (all_vectors): Rename to `large_vectors'.
206 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
207 (sweep_vectors): New functions.
208 (allocate_vectorlike): Return `zero_vector' as the only vector of
209 0 items. Allocate new vector from block if vector size is less than
210 or equal to VBLOCK_BYTES_MAX.
211 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
212 (init_alloc_once): Add call to init_vectors.
214 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
216 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
218 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
220 * doprnt.c (doprnt): Truncate multibyte char correctly.
221 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
222 would mishandle a string argument "Xc" if X was a multibyte
223 character of length 2: it would truncate after X's first byte
224 rather than including all of X.
226 2012-06-06 Chong Yidong <cyd@gnu.org>
228 * buffer.c (word_wrap): Doc fix.
230 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
232 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
234 2012-06-03 Glenn Morris <rgm@gnu.org>
236 * xdisp.c (tool-bar-style): Doc fix.
238 2012-06-03 Ulrich Müller <ulm@gentoo.org>
240 * Makefile.in (PAXCTL): Define.
241 (temacs$(EXEEXT)): Disable memory randomization for the temacs
242 binary via PaX flags if the paxctl utility is available.
243 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
244 Restore PaX flags to their default. (Bug#11398)
246 2012-06-03 Chong Yidong <cyd@gnu.org>
248 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
251 2012-06-03 Chong Yidong <cyd@gnu.org>
253 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
254 (note_mode_line_or_margin_highlight): If there is no help echo,
255 use mode-line-default-help-echo. Handle the case where the mouse
256 position is past the end of the mode line string.
258 * buffer.c (buffer_local_value_1): New function, split from
259 Fbuffer_local_value; can return Qunbound.
260 (Fbuffer_local_value): Use it.
261 (Vmode_line_format): Docstring tweaks.
263 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
265 * sysdep.c (system_process_attributes): Improve comment.
267 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
269 * keyboard.c: Export real-this-command to Elisp.
270 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
271 and DEFVAR it. Update all users.
273 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
275 * minibuf.c (Fassoc_string): Remove duplicate declaration.
277 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
278 Convert pctcpu and pctmem to Lisp float properly.
279 Let the compiler fold better, as 100.0/0x8000 is exact.
281 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
283 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
286 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
288 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
290 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
292 For a 'struct window', replace some Lisp_Object fields to
293 bitfields where appropriate, remove unused fields.
294 * window.h (struct window): Remove unused 'last_mark_x' and
295 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
296 change it's type from Lisp_Object to bitfield.
297 Change type of 'force_start', 'optional_new_start',
298 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
299 fields from Lisp_Object to bitfield. Adjust users accordingly.
301 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
303 Pacify gcc -Wdouble-precision when using Xaw.
304 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
305 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
306 Use 'float' consistently, rather than 'float' in most places
307 and 'double' in a couple of places.
309 2012-05-31 Eli Zaretskii <eliz@gnu.org>
311 * xdisp.c (handle_stop): Detect whether we have overlay strings
312 loaded by testing it->current.overlay_string_index to be
313 non-negative, instead of checking whether n_overlay_strings is
314 positive. (Bug#11587)
316 2012-05-31 Chong Yidong <cyd@gnu.org>
318 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
320 * doc.c (Fsubstitute_command_keys): Doc fix.
322 2012-05-31 Eli Zaretskii <eliz@gnu.org>
324 * search.c (search_buffer): Remove calls to
325 r_alloc_inhibit_buffer_relocation, as it is now called by
326 maybe_unify_char, which was the cause of relocation of buffer text
329 2012-05-31 Eli Zaretskii <eliz@gnu.org>
331 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
332 for the duration of call to load_charset, to avoid problems with
333 callers of maybe_unify_char that access buffer text through C
336 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
337 decrement the inhibition flag, instead of just setting or
340 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
342 Remove obsolete '#define static' cruft.
343 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
344 This #undef was "temporary" in 2000; it is no longer needed
345 now that '#define static' has gone away.
346 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
347 (gray_bitmap_bits): Remove; no longer needed.
348 All uses replaced with definiens.
349 * xterm.c: Include "bitmaps/gray.xbm".
351 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
353 Clean up __executable_start, monstartup when --enable-profiling.
354 The following changes affect the code only when profiling.
355 * dispnew.c (__executable_start): Rename from safe_bcopy.
356 Define only on platforms that need it.
357 * emacs.c: Include <sys/gmon.h> when profiling.
358 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
359 (__executable_start): Remove decl, since lisp.h does it now.
360 (safe_bcopy): Remove decl; no longer has that name.
361 (main): Coalesce #if into single bit of code, for simplicity.
362 Cast pointers to uintptr_t, since standard libraries want integers
364 * lisp.h (__executable_start): New decl.
366 2012-05-31 Glenn Morris <rgm@gnu.org>
368 * image.c (Fimagemagick_types): Doc fix.
370 2012-05-30 Jim Meyering <meyering@redhat.com>
372 * callproc.c (Fcall_process_region): Include directory component
373 in mkstemp error message (Bug#11586).
375 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
377 * alloc.c, lisp.h (make_pure_vector): Now static.
379 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
381 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
383 (Fautoload): Do the hash-doc more carefully.
384 * data.c (Fdefalias): Purify definition, except for keymaps.
385 (Qdefun): Move from eval.c.
386 * lisp.h (Qdefun): Remove.
387 * lread.c (read1): Tiny simplification.
389 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
391 Do not create empty overlays with the evaporate property (Bug#9642).
392 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
393 Bug#9642, but explicitly check that the buffer the overlay would
394 be moved to is live and rearrange lines to make sure that errors
395 will not put the overlay in an inconsistent state.
396 (Fdelete_overlay): Cosmetics.
398 2012-05-28 Eli Zaretskii <eliz@gnu.org>
400 * w32term.c (my_bring_window_to_top): New function.
401 (x_raise_frame): Use handle returned by DeferWindowPos, which
402 could be different from the original one.
403 Call my_bring_window_to_top instead of my_set_foreground_window.
406 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
407 by calling BringWindowToTop.
409 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
410 (WM_EMACS_END): Increase by one.
412 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
414 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
415 This avoids undefined behavior that might cause the eassert
416 to not catch an out-of-range value.
418 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
420 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
423 2012-05-27 Eli Zaretskii <eliz@gnu.org>
425 * bidi.c (bidi_mirror_char): Fix last change.
427 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
429 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
430 when referring to sectname field in printf format.
432 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
434 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
435 Only r_alloc_inhibit_buffer_relocation needed to be added;
436 the others were already declared.
438 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
439 before checking whether it's out of range. Put the check inside
441 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
443 2012-05-27 Ken Brown <kbrown@cornell.edu>
445 * callproc.c (Fcall_process): Restore a line that was accidentally
446 commented out in the 2011-02-13 change (bug#11547).
448 2012-05-27 Eli Zaretskii <eliz@gnu.org>
450 * lisp.h [REL_ALLOC]: Add prototypes for external functions
453 * buffer.c [REL_ALLOC]: Remove prototypes of
454 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
455 they are now on lisp.h.
457 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
459 * search.c (search_buffer): Use it to inhibit relocation of buffer
460 text while re_search_2 is doing its job, because re_search_2 is
461 passed C pointers to buffer text. (Bug#11519)
463 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
466 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
467 state after an additional call to move_it_in_display_line_to, keep
468 the values of it->max_ascent and it->max_descent found for the
470 (pos_visible_p): Revert the comparison against bottom_y to what it
471 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
474 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
476 Fix coding-related core dumps with gcc -ftrapv.
477 The code was computing A - B, where A and B are pointers, and B is
478 random garbage. This can lead to core dumps on platforms that
479 have special pointer registers, and it also leads to core dumps on
480 x86-64 when compiled with gcc -ftrapv. The fix is to compute
481 A - B only when B is initialized properly.
482 * coding.c (coding_set_source, coding_set_destination): Return void.
483 (coding_change_source, coding_change_destinations): New functions,
484 with the old behaviors of coding_set_source and coding_set_destination.
485 All callers that need an offset changed to use these new functions.
487 2012-05-26 Glenn Morris <rgm@gnu.org>
489 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
491 2012-05-26 Eli Zaretskii <eliz@gnu.org>
493 Extend mouse support on W32 text-mode console.
494 * xdisp.c (draw_row_with_mouse_face):
495 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
497 * w32console.c: Include window.h.
498 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
500 (initialize_w32_display): Initialize mouse-highlight data.
502 * w32inevt.c: Include termchar.h and window.h.
503 (do_mouse_event): Support mouse-autoselect-window. When the mouse
504 moves, call note_mouse_highlight. If help_echo changed, call
505 gen_help_event to produce help-echo message in the echo area.
506 Call clear_mouse_face if mouse_face_hidden is set in the mouse
509 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
511 * lread.c (read1): Simplify slightly to avoid an overflow warning
512 with GCC 4.7.0 on x86-64.
514 2012-05-26 Eli Zaretskii <eliz@gnu.org>
516 * bidi.c (bidi_mirror_char): Revert last change: an int is
517 definitely wide enough here.
519 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
521 Fix integer width and related bugs (Bug#9874).
522 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
523 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
524 (string_bytes, check_sblock, allocate_string_data):
525 (compact_small_strings, Fmake_bool_vector, make_string)
526 (make_unibyte_string, make_multibyte_string)
527 (make_string_from_bytes, make_specified_string)
528 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
529 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
532 (allocate_pseudovector):
533 Use int, not EMACS_INT, where int is wide enough.
534 (inhibit_garbage_collection, Fgarbage_collect):
535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
536 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
537 int might not be wide enough.
538 (bidi_cache_search, bidi_cache_find, bidi_init_it)
539 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
540 (bidi_at_paragraph_end, bidi_find_paragraph_start)
541 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
542 (bidi_level_of_next_char, bidi_move_to_visually_next):
543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
544 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
545 (Fkill_buffer, Fset_buffer_major_mode)
546 (advance_to_char_boundary, Fbuffer_swap_text)
547 (Fset_buffer_multibyte, overlays_at, overlays_in)
548 (overlay_touches_p, struct sortvec, record_overlay_string)
549 (overlay_strings, recenter_overlay_lists)
550 (adjust_overlays_for_insert, adjust_overlays_for_delete)
551 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
552 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
553 (Foverlay_recenter, last_overlay_modification_hooks_used)
554 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
556 (validate_region): Omit unnecessary test for b <= e,
557 since that's guaranteed by the previous test.
558 (adjust_overlays_for_delete): Avoid pos + length overflow.
559 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
560 (report_overlay_modification):
561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
562 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
563 Omit pointer cast, which isn't needed anyway, and doesn't work
564 after the EMACS_INT -> ptrdiff_t change.
565 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
566 * buffer.h: Adjust decls to match defn changes elsewhere.
567 (struct buffer_text, struct buffer):
568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
569 Use EMACS_INT, not int, where int might not be wide enough.
570 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
571 not int, to avoid needless 32-bit limit on 64-bit hosts.
572 (exec_byte_code): Use tighter memory-full test, one that checks
573 for alloca overflow. Don't compute the address of the object just
574 before an array, as that's not portable. Use EMACS_INT, not
575 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
576 * callint.c (Fcall_interactively):
577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
578 * callproc.c (call_process_kill, Fcall_process):
579 Don't assume pid_t fits into an Emacs fixnum.
580 (call_process_cleanup, Fcall_process, child_setup):
581 Don't assume pid_t fits into int.
582 (call_process_cleanup, Fcall_process, delete_temp_file)
583 (Fcall_process_region):
584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
585 (Fcall_process): Simplify handling of volatile integers.
586 Use int, not EMACS_INT, where int will do.
587 * casefiddle.c (casify_object, casify_region, operate_on_word)
588 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
590 (casify_object): Avoid integer overflow when overallocating buffer.
591 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
592 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
593 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
594 * category.h (CATEGORYP): Don't assume arg is nonnegative.
595 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
596 integers are now checked earlier. All uses replaced with XINT.
598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
599 For CCL_MapSingle, check that content and value are in int range.
600 (ccl_driver, Fregister_code_conversion_map):
601 Check that Vcode_version_map_vector is a vector.
602 (resolve_symbol_ccl_program): Check that vector header is in range.
603 Always copy the vector, so that we can check its contents reliably
604 now rather than having to recheck each instruction as it's being
605 executed. Check that vector words fit in 'int'.
606 (ccl_get_compiled_code, Fregister_ccl_program)
607 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
608 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
609 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
610 contents are in range.
611 (Fccl_execute_on_string): Check that status is in range.
612 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
613 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
614 Accept and return EMACS_INT, not int, because callers can pass values
616 (c_string_width, strwidth, lisp_string_width, chars_in_text)
617 (multibyte_chars_in_text, parse_str_as_multibyte)
618 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
619 (str_as_unibyte, str_to_unibyte, string_count_byte8)
620 (string_escape_byte8, Fget_byte):
621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
622 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
623 avoid mishandling large integers.
624 * character.h: Adjust decls to match defn changes elsewhere.
625 * charset.c (load_charset_map_from_file, find_charsets_in_text)
626 (Ffind_charset_region):
627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
628 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
629 (load_charset_map_from_vector, Fdefine_charset_internal):
630 Don't assume fixnum fits in int.
631 (load_charset_map_from_vector, Fmap_charset_chars):
632 Remove now-unnecessary CHECK_NATNUMs.
633 (Fdefine_charset_internal): Check ranges here, more carefully.
634 Don't rely on undefined behavior with signed left shift overflow.
635 Don't assume unsigned int fits into fixnum, or that fixnum fits
636 into unsigned int. Don't require max_code to be a valid fixnum;
637 that's not true for gb10830 4-byte on a 32-bit host. Allow
638 invalid_code to be a cons, for the same reason. Require code_offset
639 to be a character. Avoid int overflow if max_char is close
641 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
642 this is intended anyway and avoids some undefined behavior.
643 (load_charset_map): Pass unsigned, not int, as 2nd arg of
644 INDEX_TO_CODE_POINT, as that's what it expects.
645 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
646 * charset.h (DECODE_CHAR): Return int, not unsigned;
647 this is what was intended anyway, and it avoids undefined behavior.
648 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
649 integer-overflow issues.
650 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
651 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
652 where the argument is EMACS_INT, and this behavior is not intended.
653 * chartab.c (Fmake_char_table, Fset_char_table_range)
654 (uniprop_get_decoder, uniprop_get_encoder):
655 Don't assume fixnum fits in int.
656 * cmds.c (move_point): New function, that does the gist of
657 Fforward_char and Fbackward_char, but does so while checking
658 for integer overflow more accurately.
659 (Fforward_char, Fbackward_char): Use it.
660 (Fforward_line, Fend_of_line, internal_self_insert)
661 (internal_self_insert):
662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
663 Fix a FIXME, by checking for integer overflow when calculating
664 target_clm and actual_clm.
665 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
666 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
667 (ASSURE_DESTINATION, coding_alloc_by_realloc)
668 (coding_alloc_by_making_gap, alloc_destination)
669 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
670 (encode_coding_utf_16, detect_coding_emacs_mule)
671 (decode_coding_emacs_mule, encode_coding_emacs_mule)
672 (detect_coding_iso_2022, decode_coding_iso_2022)
673 (encode_invocation_designation, encode_designation_at_bol)
674 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
675 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
676 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
677 (encode_coding_ccl, encode_coding_raw_text)
678 (detect_coding_charset, decode_coding_charset)
679 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
680 (produce_composition, produce_charset, produce_annotation)
681 (decode_coding, handle_composition_annotation)
682 (handle_charset_annotation, consume_chars, decode_coding_gap)
683 (decode_coding_object, encode_coding_object, detect_coding_system)
684 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
685 (code_convert_region, code_convert_string)
686 (Fdefine_coding_system_internal)
687 (coding_set_source, coding_set_destination):
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
690 (Fdefine_coding_system_internal):
691 Don't assume fixnums fit in int.
692 (decode_coding_gap, decode_coding_object, encode_coding_object)
693 (Fread_coding_system, Fdetect_coding_region)
694 (Funencodable_char_position, Fcheck_coding_systems_region)
695 (get_translation, handle_composition_annotation, consume_chars):
696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
697 (consume_chars): Rewrite to not calculate an address outside buffer.
698 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
699 Don't access memory outside of the args array.
700 (Fdefine_coding_system_internal): Check for charset-id overflow.
701 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
702 result of ENCODE_CHAR.
703 * coding.h: Adjust decls to match defn changes elsewhere.
704 (struct coding_system):
705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
706 * composite.c (get_composition_id, find_composition)
707 (run_composition_function, update_compositions)
708 (compose_text, composition_gstring_put_cache)
709 (composition_gstring_p, composition_gstring_width)
710 (fill_gstring_header, fill_gstring_body, autocmp_chars)
711 (composition_compute_stop_pos, composition_reseat_it)
712 (composition_update_it, struct position_record)
713 (find_automatic_composition, composition_adjust_point)
714 (Fcomposition_get_gstring, Ffind_composition_internal):
715 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
716 (update_compositions):
717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
718 * composite.h: Adjust decls to match defn changes elsewhere.
719 (struct composition):
720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
721 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
722 Do not attempt to compute the address of the object just before a
723 buffer; this is not portable.
725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
726 (Faset): Use int, not EMACS_INT, where int is wide enough.
727 (Fstring_to_number): Don't assume fixnums fit in int.
728 (Frem): Don't assume arg is nonnegative.
729 * dbusbind.c (xd_append_arg): Check for integers out of range.
730 (Fdbus_call_method): Don't overflow the timeout int.
731 (extract_signed, extract_unsigned): New functions.
732 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
733 (xd_get_connection_references): Return ptrdiff_t, not int.
735 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
737 Use int, not unsigned, where the dbus API uses int.
738 (Fdbus_message_internal): Don't overflow mtype.
739 (syms_of_dbusbind): Allocate right-sized buffer for integers.
740 * dired.c (directory_files_internal, file_name_completion, scmp)
741 (file_name_completion_stat):
742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
743 (file_name_completion): Don't overflow matchcount.
744 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
745 * dispextern.h: Adjust decls to match defn changes elsewhere.
746 (struct text_pos, struct glyph, struct bidi_saved_info)
747 (struct bidi_string_data, struct bidi_it, struct composition_it)
749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
750 (struct display_pos, struct composition_it, struct it):
751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
752 * dispnew.c (increment_matrix_positions)
753 (increment_row_positions, mode_line_string)
754 (marginal_area_string):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
758 (duration_to_sec_usec): New function, to check for overflow better.
759 (Fsleep_for, sit_for): Use it.
760 * doc.c (get_doc_string, store_function_docstring):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (get_doc_string, Fsnarf_documentation):
763 Use int, not EMACS_INT, where int is wide enough.
765 Use SAFE_ALLOCA, not alloca.
766 Check for overflow when converting EMACS_INT to off_t.
768 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
769 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
770 Don't assume uid_t fits into fixnum.
771 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
772 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
773 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
774 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
775 (general_insert_function)
776 (Finsert_char, make_buffer_string, make_buffer_string_both)
777 (update_buffer_properties, Fbuffer_substring)
778 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
779 (Fsubst_char_in_region, check_translation)
780 (Ftranslate_region_internal, save_restriction_restore, Fformat)
781 (transpose_markers, Ftranspose_regions):
782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
783 (clip_to_bounds): Move to lisp.h as an inline function).
784 (Fconstrain_to_field): Don't assume integers are nonnegative.
785 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
786 (Fsubst_char_in_region, Fsave_restriction):
787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
788 (Femacs_pid): Don't assume pid_t fits into fixnum.
789 (lo_time): Use int, not EMACS_INT, when int suffices.
790 (lisp_time_argument): Check for usec out of range.
791 (Fencode_time): Don't assume fixnum fits in int.
792 (Fuser_login_name, Fuser_full_name): Signal an error
793 if a uid argument is out of range, rather than relying on
795 (Fformat_time_string): Remove now-unnecessary check.
796 lisp_time_argument checks for out-of-range usec now.
797 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
798 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
799 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
800 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
801 (init_cmdargs, Fdump_emacs):
802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
803 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
804 the bottom (typically) 32 bits of the fixnum.
805 * eval.c (specpdl_size, call_debugger):
806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
807 (when_entered_debugger, Fbacktrace_debug):
808 Don't assume fixnum can fit in int.
809 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
810 the object just before a buffer; this is not portable.
811 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
812 (grow_specpdl, unbind_to):
813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
814 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
815 (grow_specpdl): Simplify allocation by using xpalloc.
816 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
817 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
818 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
820 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 (Fcopy_file, non_regular_nbytes, read_non_regular)
824 (Finsert_file_contents):
825 Use int, not EMACS_INT, where int is wide enough.
826 (READ_BUF_SIZE): Verify that it fits in int.
827 (Finsert_file_contents): Check that counts are in proper range,
828 rather than assuming fixnums fit into ptrdiff_t etc.
829 Don't assume fixnums fit into int.
830 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
831 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
832 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
833 (string_char_to_byte, string_byte_to_char)
834 (string_make_multibyte, string_to_multibyte)
835 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
836 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
837 (substring_both, Fdelete, internal_equal, Ffillarray)
838 (Fclear_string, mapcar1)
839 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
840 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
841 (larger_vector, make_hash_table, maybe_resize_hash_table)
842 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
843 (Fmaphash, secure_hash):
844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
845 (concat): Check for string index and length overflow.
846 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
849 (larger_vector): New API (vec, incr_min, size_max) replaces old
850 one (vec, new_size, init). This catches size overflow.
851 INIT was removed because it was always Qnil.
853 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
854 the upper bound on a hash table index size.
855 (make_hash_table, maybe_resize_hash_table): Use it.
856 (secure_hash): Computer start_byte and end_byte only after
857 they're known to be in ptrdiff_t range.
858 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
859 (Ffont_get_glyphs, Ffont_at):
860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
861 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
862 (Flist_fonts, Fopen_font):
863 Don't assume fixnum can fit in int.
864 (check_gstring): Don't assume index can fit in int.
865 (font_match_p): Check that fixnum is a character, not a nonnegative
866 fixnum, since the later code needs to stuff it into an int.
867 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
868 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
869 conversion overflow issues.
870 (Fopen_font): Check for integer out of range.
871 (Ffont_get_glyphs): Don't assume index can fit in int.
872 * font.h: Adjust decls to match defn changes elsewhere.
873 * fontset.c (reorder_font_vector): Redo score calculation to avoid
875 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
876 printmax_t, where ptrdiff_t is wide enough.
877 (Finternal_char_font):
878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
879 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
880 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
881 (Fset_frame_position, x_set_frame_parameters)
882 (x_set_line_spacing, x_set_border_width)
883 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
884 Check that fixnums are in proper range for system types.
885 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
887 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
888 Use SAFE_ALLOCA_LISP, not alloca.
889 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
890 intptr_t is wide enough.
891 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
892 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
893 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
894 Check for fixnum out of range.
895 * ftfont.c (ftfont_list): Don't assume index fits in int.
896 Check that fixnums are in proper range for system types.
897 (ftfont_shape_by_flt):
898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
899 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
901 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
902 Check that fixnums are in proper range for system types.
903 * gnutls.h: Adjust decls to match defn changes elsewhere.
904 * gtkutil.c (xg_dialog_run):
905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
906 (update_frame_tool_bar):
907 Check that fixnums are in proper range for system types.
908 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
909 (lookup_image): Check that fixnums are in range for system types.
910 * indent.c (last_known_column, last_known_column_point):
911 (current_column_bol_cache):
912 (skip_invisible, current_column, check_display_width):
913 (check_display_width, scan_for_column, current_column_1)
914 (Findent_to, Fcurrent_indentation, position_indentation)
915 (indented_beyond_p, Fmove_to_column, compute_motion):
916 (Fcompute_motion, Fvertical_motion):
917 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
918 (last_known_column_modified): Use EMACS_INT, not int.
919 (check_display_width):
921 Check that fixnums and floats are in proper range for system types.
922 (compute_motion): Don't assume index or fixnum fits in int.
923 (compute_motion, Fcompute_motion):
924 Use int, not EMACS_INT, when it is wide enough.
925 (vmotion): Omit local var start_hpos that is always 0; that way
926 we don't need to worry about overflow in expressions involving it.
927 * indent.h: Adjust decls to match defn changes elsewhere.
929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
930 Use int, not EMACS_INT, where int is wide enough.
931 Remove unused members ovstring_chars_done and tab_offset;
933 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
934 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
935 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
936 (make_gap, copy_text, insert, insert_and_inherit)
937 (insert_before_markers, insert_before_markers_and_inherit)
938 (insert_1, count_combining_before, count_combining_after)
939 (insert_1_both, insert_from_string)
940 (insert_from_string_before_markers, insert_from_string_1)
941 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
942 (adjust_after_replace, adjust_after_insert, replace_range)
943 (replace_range_2, del_range, del_range_1, del_range_byte)
944 (del_range_both, del_range_2, modify_region)
945 (prepare_to_modify_buffer, signal_before_change)
946 (signal_after_change, Fcombine_after_change_execute):
947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
948 * intervals.c (traverse_intervals, rotate_right, rotate_left)
949 (balance_an_interval, split_interval_right, split_interval_left)
950 (find_interval, next_interval, update_interval)
951 (adjust_intervals_for_insertion, delete_node, delete_interval)
952 (interval_deletion_adjustment, adjust_intervals_for_deletion)
953 (static_offset_intervals, offset_intervals)
954 (merge_interval_right, merge_interval_left, make_new_interval)
955 (graft_intervals_into_buffer, temp_set_point_both)
956 (temp_set_point, set_point, adjust_for_invis_intang)
957 (set_point_both, move_if_not_intangible, get_property_and_range)
958 (get_local_map, copy_intervals, copy_intervals_to_string)
959 (compare_string_intervals, set_intervals_multibyte_1):
960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
961 * intervals.h: Adjust decls to match defn changes elsewhere.
963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
964 * keyboard.c (this_command_key_count, this_single_command_key_start)
965 (before_command_key_count, before_command_echo_length, echo_now)
966 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
967 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
968 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
969 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
971 (last_non_minibuf_size, last_point_position, echo_truncate)
972 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
973 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
974 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
975 (stuff_buffered_input):
976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977 (last_auto_save, command_loop_1, read_char):
978 Use EMACS_INT, not int, to avoid integer overflow.
979 (record_char): Avoid overflow in total_keys computation.
980 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
981 * keyboard.h: Adjust decls to match defn changes elsewhere.
982 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
983 (Fkey_description, Fdescribe_vector, Flookup_key):
984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
985 (click_position): New function, to check that positions are in range.
986 (Fcurrent_active_maps):
988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
989 (Faccessible_keymaps, Fkey_description):
990 (preferred_sequence_p):
991 Don't assume fixnum can fit into int.
992 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
993 Check for integer overflow in size calculations.
994 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
995 avoid mishandling large integers.
996 * lisp.h: Adjust decls to match defn changes elsewhere.
997 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
998 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
999 (struct Lisp_Marker):
1000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1001 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1002 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1003 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1004 All callers changed.
1005 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1006 Assume the arg has valid form, since it always does.
1007 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1008 unsigned integer system type.
1009 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1010 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1012 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1013 (duration_to_sec_usec): New decl.
1014 * lread.c (read_from_string_index, read_from_string_index_byte)
1015 (read_from_string_limit, readchar, unreadchar, openp)
1016 (read_internal_start, read1, oblookup):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (Fload, readevalloop, Feval_buffer, Feval_region):
1019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1020 (openp): Check for out-of-range argument to 'access'.
1021 (read1): Use int, not EMACS_INT, where int is wide enough.
1022 Don't assume fixnum fits into int.
1023 Fix off-by-one error that can read outside a buffer.
1024 (read_filtered_event): Use duration_to_sec_usec
1025 to do proper overflow checking on durations.
1026 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1027 in size calculation.
1028 (Fexecute_kbd_macro):
1029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1030 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1031 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1032 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1033 (set_marker_both, set_marker_restricted_both, marker_position)
1034 (marker_byte_position, Fbuffer_has_markers_at):
1035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1036 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1037 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1038 It now merely ensures that the menu is large enough, without
1039 necessarily growing it, as this avoids some integer overflow issues.
1040 All callers changed.
1041 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1043 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1044 Use SAFE_ALLOCA_LISP, not alloca.
1045 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1046 to EMACS_INT. Check that fixnums are in proper range for system types.
1047 * minibuf.c (minibuf_prompt_width, string_to_object)
1048 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1049 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1051 (get_minibuffer, read_minibuf_unwind):
1052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1053 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1054 this simplifies overflow checking. All callers changed.
1055 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1058 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1059 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1060 Check that fixnums are in proper range for system types.
1061 (Fx_create_frame, Fx_show_tip):
1062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1063 * nsfont.m (ns_findfonts, nsfont_list_family):
1064 Don't assume fixnum fits in long.
1065 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1067 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1069 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1071 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1072 (PRINTDECLARE, PRINTPREPARE):
1073 (strout, print_string):
1074 (print, print_preprocess, print_check_string_charset_prop)
1076 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1078 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1080 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1081 (printchar, strout): Use xpalloc to catch size calculation overflow.
1082 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1083 (print_error_message): Use SAFE_ALLOCA, not alloca.
1084 (print_object): Use int, not EMACS_INT, where int is wide enough.
1085 (print_depth, new_backquote_output, print_number_index):
1086 Use ptrdiff_t, not int, where int might not be wide enough.
1087 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1088 (Fset_process_window_size, Fformat_network_address)
1089 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1091 Check that fixnums are in proper range for system types.
1092 (Fsignal_process): Simplify by avoiding a goto.
1093 Check for process-ids out of pid_t range rather than relying on
1095 (process_tick, update_tick): Use EMACS_INT, not int.
1096 (Fformat_network_address, read_process_output, send_process)
1097 (Fprocess_send_region, status_notify):
1098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1099 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1100 (wait_reading_process_output, read_process_output, exec_sentinel):
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1103 (Faccept_process_output): Use duration_to_sec_usec to do proper
1104 overflow checking on durations.
1105 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1106 Don't assume pid_t fits in int.
1107 * process.h (struct Lisp_Process): Members tick and update_tick
1108 are now of type EMACS_INT, not int.
1109 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1110 configured --with-wide-int.
1111 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1112 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1113 * search.c (looking_at_1, string_match_1):
1114 (fast_string_match, fast_c_string_match_ignore_case)
1115 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1116 (scan_newline, find_before_next_newline, search_command)
1117 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1118 (set_search_regs, wordify):
1121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1122 (string_match_1, search_buffer, set_search_regs):
1124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1125 (wordify): Check for overflow in size calculation.
1126 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1127 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1128 Check that fixnums are in proper range for system types.
1129 * sound.c (struct sound_device)
1130 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1132 (Fplay_sound_internal):
1133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1134 * syntax.c (struct lisp_parse_state, find_start_modiff)
1135 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1136 (Fparse_partial_sexp):
1137 Don't assume fixnums can fit in int.
1138 (struct lisp_parse_state, find_start_pos, find_start_value)
1139 (find_start_value_byte, find_start_begv)
1140 (update_syntax_table, char_quoted, dec_bytepos)
1141 (find_defun_start, prev_char_comend_first, back_comment):
1142 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1143 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1145 (Finternal_describe_syntax_value): Check that match_lisp is a
1146 character, not an integer, since the code stuffs it into int.
1147 (scan_words, scan_sexps_forward):
1148 Check that fixnums are in proper range for system types.
1150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1151 (scan_sexps_forward):
1152 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1153 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1154 * syntax.h: Adjust decls to match defn changes elsewhere.
1155 (struct gl_state_s):
1156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1157 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1158 MOST_POSITIVE_FIXNUM.
1159 * sysdep.c (wait_for_termination_1, wait_for_termination)
1160 (interruptible_wait_for_termination, mkdir):
1161 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1162 (emacs_read, emacs_write):
1163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1164 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1165 and double all fit in int.
1166 * term.c (set_tty_color_mode):
1167 Check that fixnums are in proper range for system types.
1168 * termhooks.h (struct input_event):
1169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1170 * textprop.c (validate_interval_range, interval_of)
1171 (Fadd_text_properties, set_text_properties_1)
1172 (Fremove_text_properties, Fremove_list_of_text_properties)
1173 (Ftext_property_any, Ftext_property_not_all)
1174 (copy_text_properties, text_property_list, extend_property_ranges)
1175 (verify_interval_modification):
1176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1177 (Fnext_single_char_property_change)
1178 (Fprevious_single_char_property_change):
1179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1180 (copy_text_properties):
1181 Check for integer overflow in index calculation.
1182 * undo.c (last_boundary_position, record_point, record_insert)
1183 (record_delete, record_marker_adjustment, record_change)
1184 (record_property_change):
1185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1186 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1188 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1189 (Fx_hide_tip, Fx_file_dialog):
1190 * w32menu.c (set_frame_menubar):
1191 Use ptrdiff_t, not int, for consistency with rest of code.
1192 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1193 (select_window, Fdelete_other_windows_internal)
1194 (window_scroll_pixel_based, window_scroll_line_based)
1195 (Frecenter, Fset_window_configuration):
1196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1197 (Fset_window_hscroll, run_window_configuration_change_hook)
1198 (set_window_buffer, temp_output_buffer_show, scroll_command)
1199 (Fscroll_other_window, Frecenter):
1200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1201 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1202 Don't assume fixnum fits in int.
1203 (Fset_window_scroll_bars):
1204 Check that fixnums are in proper range for system types.
1205 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1206 (string_pos, c_string_pos, number_of_chars, init_iterator)
1207 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1208 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1209 (compute_display_string_end, handle_face_prop)
1210 (face_before_or_after_it_pos, handle_invisible_prop)
1211 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1212 (display_prop_intangible_p, string_buffer_position_lim)
1213 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1214 (get_overlay_strings_1, get_overlay_strings)
1215 (iterate_out_of_display_property, forward_to_next_line_start)
1216 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1217 (get_next_display_element, set_iterator_to_next)
1218 (get_visually_first_element, compute_stop_pos_backwards)
1219 (handle_stop_backwards, next_element_from_buffer)
1220 (move_it_in_display_line_to, move_it_in_display_line)
1221 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1222 (add_to_log, message_dolog, message_log_check_duplicate)
1223 (message2, message2_nolog, message3, message3_nolog
1224 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1225 (current_message_1, truncate_echo_area, truncate_message_1)
1226 (set_message, set_message_1, store_mode_line_noprop)
1227 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1228 (text_outside_line_unchanged_p, check_point_in_composition)
1229 (reconsider_clip_changes)
1230 (redisplay_internal, set_cursor_from_row, try_scrolling)
1231 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1232 (redisplay_window, find_last_unchanged_at_beg_row)
1233 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1234 (trailing_whitespace_p, find_row_edges, display_line)
1235 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1236 (display_mode_element, store_mode_line_string)
1237 (pint2str, pint2hrstr, decode_mode_spec)
1238 (display_count_lines, display_string, draw_glyphs)
1239 (x_produce_glyphs, x_insert_glyphs)
1240 (rows_from_pos_range, mouse_face_from_buffer_pos)
1241 (fast_find_string_pos, mouse_face_from_string_pos)
1242 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1244 (safe_call, init_from_display_pos, handle_fontified_prop)
1245 (handle_single_display_spec, load_overlay_strings)
1246 (with_echo_area_buffer, setup_echo_area_for_printing)
1247 (display_echo_area, echo_area_display)
1248 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1249 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1250 (redisplay_window, dump_glyph_row, display_mode_line)
1251 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1252 (handle_display_spec, display_prop_string_p):
1253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1254 (handle_single_display_spec, build_desired_tool_bar_string)
1255 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1256 (get_specified_cursor_type):
1257 Check that fixnums are in proper range for system types.
1258 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1259 (Flookup_image_map):
1260 Don't assume fixnums fit in int.
1261 (compare_overlay_entries):
1262 Avoid mishandling comparisons due to subtraction overflow.
1263 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1264 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1265 (handle_tool_bar_click):
1266 Use int, not unsigned, since we prefer signed and the signedness
1267 doesn't matter here.
1268 (get_next_display_element, next_element_from_display_vector):
1269 Use int, not EMACS_INT, when int is wide enough.
1270 (start_hourglass): Use duration_to_sec_usec to do proper
1271 overflow checking on durations.
1272 * xfaces.c (Fbitmap_spec_p):
1273 Check that fixnums are in proper range for system types.
1274 (compare_fonts_by_sort_order):
1275 Avoid mishandling comparisons due to subtraction overflow.
1276 (Fx_family_fonts, realize_basic_faces):
1277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1279 Don't assume fixnum fits in int.
1280 Use SAFE_ALLOCA_LISP, not alloca.
1281 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1282 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1283 (face_at_buffer_position, face_for_overlay_string)
1284 (face_at_string_position):
1285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1286 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1287 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1289 Check that fixnums are in proper range for system types.
1290 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1291 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1293 (Fx_change_window_property): Don't assume fixnums fit in int.
1294 * xfont.c (xfont_chars_supported):
1295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1296 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1297 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1299 * xml.c (parse_region):
1300 * xrdb.c (magic_file_p):
1301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1302 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1303 (x_get_local_selection, x_reply_selection_request)
1304 (x_handle_selection_request, wait_for_property_change):
1305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1306 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1307 short is wide enough.
1308 (x_send_client_event): Don't assume fixnum fits in int.
1309 * xterm.c (x_x_to_emacs_modifiers):
1310 Don't assume EMACS_INT overflows nicely into int.
1311 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1313 (handle_one_xevent): NATNUMP can eval its arg twice.
1314 (x_connection_closed):
1315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1316 * xterm.h: Adjust decls to match defn changes elsewhere.
1317 (struct scroll_bar): Use struct vectorlike_header
1318 rather than rolling our own approximation.
1319 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1321 2012-05-25 Glenn Morris <rgm@gnu.org>
1323 * lisp.mk (lisp): Update for more files being compiled now.
1325 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1327 * lread.c: Remove `read_pure' which makes no difference.
1328 (read_pure): Remove var.
1329 (unreadpure): Remove function.
1330 (readevalloop): Don't call read_list with -1 flag.
1331 (read1, read_vector): Don't test read_pure any more.
1332 (read_list): Simplify.
1334 * fileio.c, character.h: Minor style tweaks.
1336 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1338 * window.h (clip_changed): Remove useless declaration.
1340 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1342 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1343 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1345 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1348 This directory predates autoconf and is no longer needed nowadays.
1349 Move its few remaining bits of functionality to where they're needed.
1350 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1351 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1352 * m/template.h: Remove.
1353 * Makefile.in (M_FILE): Remove. All uses removed.
1354 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1355 * lisp.h (USE_LSB_TAG):
1356 * mem-limits.h (EXCEEDS_LISP_PTR):
1357 Use VAL_MAX, not VALBITS, in #if.
1358 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1359 (EMACS_UINT): Define unconditionally now.
1360 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1361 (BITS_PER_EMACS_INT): New constants, replacing
1362 what used to be in config.h, but not useful in #if.
1363 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1364 define them any more.
1365 (VAL_MAX): New macro.
1367 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1368 BITS_PER_EMACS_INT, in #if.
1369 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1370 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1371 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1372 * s/ms-w32.h (DATA_START):
1373 Move here from removed file m/intel386.h.
1374 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1375 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1377 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1379 Assume C89 or later.
1380 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1381 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1383 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1384 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1385 * textprop.c, tparam.c (NULL): Remove.
1386 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1387 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1388 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1389 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1390 * xterm.c (input_signal_count): Assume volatile works.
1392 2012-05-21 Ken Brown <kbrown@cornell.edu>
1394 * xgselect.c (xg_select): Fix first argument in call to 'select'
1397 2012-05-20 Ken Brown <kbrown@cornell.edu>
1399 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1400 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1402 2012-05-19 Ken Brown <kbrown@cornell.edu>
1404 * xfns.c (x_in_use): Remove `static' qualifier.
1405 * xterm.h (x_in_use): Declare.
1406 * xgselect.c: Include xterm.h.
1407 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1408 and `display_arg' (bug#9754).
1410 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1412 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1414 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1415 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1417 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1419 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1421 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1422 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1424 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1425 reference to image_cache->refcount.
1426 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1428 2012-05-17 Juri Linkov <juri@jurta.org>
1430 * search.c (Fword_search_regexp, Fword_search_backward)
1431 (Fword_search_forward, Fword_search_backward_lax)
1432 (Fword_search_forward_lax): Move functions to isearch.el
1433 (bug#10145, bug#11381).
1435 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1437 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1439 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1441 * lread.c (init_obarray): Declare Qt and Qnil as special.
1443 2012-05-14 Glenn Morris <rgm@gnu.org>
1445 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1446 Put "libexec" before "bin", for the sake of init_callproc_1.
1448 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1450 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1452 * unexaix.c: Port to more-recent AIX compilers.
1453 (report_error, report_error_1, make_hdr, copy_sym)
1454 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1455 Make arguments const char *, not char *, to avoid violations of C
1456 standard and to fix some AIX warnings reported by Gilles Pion.
1458 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1460 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1461 already have overlays loaded.
1462 (handle_single_display_spec): Before returning without displaying
1463 fringe bitmap, synchronize the bidi iterator with the main display
1464 iterator, by calling iterate_out_of_display_property.
1465 (iterate_out_of_display_property): Detect buffer iteration by
1466 testing that it->string is a Lisp string.
1467 (get_next_display_element): When the current object is exhausted,
1468 and there's something on it->stack, call set_iterator_to_next to
1469 proceed with what's on the stack, instead of returning zero.
1470 (set_iterator_to_next): If called at the end of a Lisp string,
1471 proceed to consider_string_end without incrementing string
1472 position. Don't increment display vector index past the end of
1473 the display vector. (Bug#11417)
1474 (pos_visible_p): Don't report a position visible when move_it_to
1475 stopped at the last line of window, which happens to be scanned
1476 backwards by the bidi iteration. (Bug#11464)
1478 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1480 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1481 and right-margin display specs even if the spec is invalid or we
1482 are on a TTY, and thus unable to display on the fringes.
1483 That's because the text with the property will not be displayed anyway,
1484 so we need to signal to the caller that this is a "replacing"
1485 display spec. This fixes display when the spec is invalid or we
1488 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1490 * unexaix.c (make_hdr): Fix typo in prototype.
1491 This bug broke the build on AIX. Problem reported by Gilles Pion.
1493 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1495 * keyboard.c (kbd_buffer_get_event): Read special events also in
1496 batch mode. (Bug#11415)
1498 2012-05-12 Glenn Morris <rgm@gnu.org>
1500 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1502 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1504 * lisp.mk (lisp): Add newcomment.elc.
1506 2012-05-12 Glenn Morris <rgm@gnu.org>
1508 * Makefile.in (MKDIR_P): New, set by configure.
1509 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1511 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1513 Remove unused function hourglass_started.
1514 * dispextern.h (hourglass_started):
1515 * w32fns.c (hourglass_started):
1516 * xdisp.c (hourglass_started): Remove.
1518 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1520 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1521 Update dependencies.
1523 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1525 * xgselect.c (xg_select): Put maxfds+1 into a var.
1526 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1528 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1530 2012-05-10 Dave Abrahams <dave@boostpro.com>
1532 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1533 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1535 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1537 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1538 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1539 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1540 Initialize xd_registered_buses.
1542 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1544 Untag more efficiently if USE_LSB_TAG.
1545 This is based on a proposal by YAMAMOTO Mitsuharu in
1546 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1547 For an admittedly artificial (nth 8000 longlist) benchmark on
1548 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1549 Emacs's overall text size by 1%.
1550 * lisp.h (XUNTAG): New macro.
1551 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1552 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1553 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1554 * eval.c (Fautoload):
1555 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1556 * frame.h (XFRAME): Use XUNTAG.
1558 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1559 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1560 Remove unportable assumptions about print widths of types like
1562 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1563 intptr_t when converting between pointer and integer, to avoid GCC
1564 warnings about wrong width.
1566 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1568 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1569 stack for each reader_thread, instead of defaulting to 8MB
1570 determined by the linker. This avoids failures in creating
1571 subprocesses on Windows 7, see the discussion in this thread:
1572 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1574 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1576 Fix up display of the *Minibuf-0* buffer in the mini window.
1577 * keyboard.c (read_char): Don't clear the echo area if there's no
1579 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1580 contents of *Minibuf-0*) if there's no message displayed in its stead.
1582 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1584 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1587 2012-05-06 Chong Yidong <cyd@gnu.org>
1589 * lisp.mk (lisp): Update.
1591 2012-05-05 Jim Meyering <meyering@redhat.com>
1593 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1595 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1597 * data.c (PUT_ERROR): New macro.
1598 (syms_of_data): Use it. Add new error type `user-error'.
1599 * undo.c (user_error): New function.
1600 (Fprimitive_undo): Use it.
1601 * print.c (print_error_message): Adjust print style for `user-error'.
1602 * keyboard.c (user_error): New function.
1603 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1605 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1607 Do not limit current-time-string to years 1000..9999.
1608 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1609 (Fcurrent_time_string): Support any year that is supported by the
1610 underlying localtime representation. Don't use asctime, as it
1611 has undefined behavior for years outside the range -999..9999.
1613 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1615 Fix race conditions involving setenv, gmtime, localtime, asctime.
1616 Without this fix, interrupts could mess up code that uses these
1617 nonreentrant functions, since setting TZ invalidates existing
1618 tm_zone or tzname values, and since most of these functions return
1619 pointers to static storage.
1620 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1621 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1622 Grow the critical sections to include not just invoking
1623 localtime/gmtime, but also accessing these functions' results
1624 including their tm_zone values if any, and any related TZ setting.
1625 (format_time_string): Last arg is now struct tm *, not struct tm **,
1626 so that the struct tm is saved in the critical section.
1627 All callers changed. Simplify allocation of initial buffer, partly
1628 motivated by the fact that memory allocation needs to be outside
1629 the critical section.
1631 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1633 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1634 with RESET_INTERVAL.
1636 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1637 Remove duplicated buffer name initialization.
1639 2012-05-02 Jim Meyering <jim@meyering.net>
1641 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1643 * xfns.c (x_window): Use xstrdup (Bug#11375).
1645 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1647 * xdisp.c (pos_visible_p): If already at a newline from the
1648 display string before the 'while' loop, don't walk back the glyphs
1649 from it3.glyph_row. Solves assertion violation when the display
1650 string begins with a newline (egg.el). (Bug#11367)
1652 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1654 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1657 2012-05-01 Glenn Morris <rgm@gnu.org>
1659 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1660 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1661 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1662 All were removed before 23.1.
1664 * dispnew.c: Remove HAVE_LIBNCURSES test;
1665 it is always true on relevant platforms.
1667 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1668 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1670 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1672 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1674 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1675 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1678 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1680 Do not avoid creating empty evaporating overlays (Bug#9642).
1681 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1682 That is, do not delete an evaporating overlay if it becomes
1683 empty after its bounds are adjusted to fit within its buffer.
1684 This fix caused other problems, and I'm reverting it until we get
1685 to the bottom of them.
1687 2012-04-27 Chong Yidong <cyd@gnu.org>
1689 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1691 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1693 * xdisp.c (pos_visible_p): If the window start position is beyond
1694 ZV, start the display from buffer beginning. Prevents assertion
1695 violation in init_iterator when the minibuffer window is scrolled
1698 * window.c (window_scroll_pixel_based): Likewise.
1700 2012-04-27 Chong Yidong <cyd@gnu.org>
1702 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1704 2012-04-27 Glenn Morris <rgm@gnu.org>
1706 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1707 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1709 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1711 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1712 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1714 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1716 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1717 display element, check also the underlying string or buffer
1718 character. (Bug#11341)
1720 * w32menu.c: Include w32heap.h.
1721 (add_menu_item): If the call to AppendMenuW (via
1722 unicode_append_menu) fails, disable Unicode menus only if we are
1723 running on Windows 9X/Me.
1725 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1727 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1728 (xgetint): Add missing shift for LSB tags.
1730 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1732 * keyboard.c (read_char): Don't wipe echo area for select window
1733 events: These might get delayed via `mouse-autoselect-window'
1736 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1738 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1739 manipulation of :loaded-from data.
1741 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1743 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1744 now a cons (bug#11311).
1746 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1748 Do not create empty overlays with the evaporate property (Bug#9642).
1749 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1750 if it becomes empty after its bounds are adjusted to fit within
1751 its buffer. Without this fix, in a nonempty buffer (let ((o
1752 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1753 yields an empty overlay that has the evaporate property, which is
1754 not supposed to happen.
1756 Fix minor GTK3 problems found by static checking.
1757 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1758 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1759 (struct _EmacsFixedClass, emacs_fixed_get_type):
1760 Move decls here from emacsgtkfixed.h, since they needn't be public.
1761 (emacs_fixed_get_type): Now static.
1762 (emacs_fixed_class_init): Omit unused local.
1763 (emacs_fixed_child_type): Remove; unused.
1764 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1765 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1766 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1767 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1768 (EMACS_FIXED_GET_CLASS): Remove; unused.
1769 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1771 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1772 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1774 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1776 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1777 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1778 (__malloc_size_t, __malloc_ptrdiff_t):
1779 Remove. All uses removed, replaced by the definiens if needed,
1780 since we can assume C89 or better now.
1781 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1782 (protect_malloc_state, align, get_contiguous_space)
1783 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1784 (malloc_atfork_handler_child, malloc_enable_thread)
1785 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1786 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1787 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1788 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1789 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1790 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1791 Define using prototypes, not old style.
1792 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1793 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1794 (align): Don't assume that signed integer overflow wraps around.
1795 Omit unused local var.
1796 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1797 (_free_internal_nolock, memalign, mallochook, reallochook):
1798 Omit no-longer-needed casts.
1799 (valloc): Use getpagesize, not __getpagesize.
1800 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1801 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1803 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1805 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1807 Move functions from C to Lisp. Make non-blocking method calls
1808 the default. Implement further D-Bus standard interfaces.
1810 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1811 (QCdbus_request_name_allow_replacement)
1812 (QCdbus_request_name_replace_existing)
1813 (QCdbus_request_name_do_not_queue)
1814 (QCdbus_request_name_reply_primary_owner)
1815 (QCdbus_request_name_reply_in_queue)
1816 (QCdbus_request_name_reply_exists)
1817 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1818 (QCdbus_registered_serial, QCdbus_registered_method)
1819 (QCdbus_registered_signal): New Lisp objects.
1820 (XD_DEBUG_MESSAGE): Use sizeof.
1821 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1822 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1823 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1824 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1825 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1826 (xd_signature, xd_append_arg): Allow float for integer types.
1827 (xd_get_connection_references): New function.
1828 (xd_get_connection_address): Rename from xd_initialize.
1829 Return cached address.
1830 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1831 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1833 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1834 Return number of refcounts.
1835 (Fdbus_get_unique_name): Make stronger parameter check.
1836 (Fdbus_message_internal): New defun.
1837 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1838 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1839 (Fdbus_send_signal, Fdbus_register_service)
1840 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1841 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1842 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1843 (Vdbus_compiled_version, Vdbus_runtime_version)
1844 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1845 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1846 (Vdbus_message_type_signal): New defvars.
1847 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1850 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1852 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1853 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1854 Do not assume ptrdiff_t is the same width as 'int'.
1856 * alloc.c: Handle unusual debugging option combinations.
1857 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1858 since the two debugging options are incompatible.
1859 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1861 (mem_init, mem_insert, mem_insert_fixup):
1862 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1863 (NEED_MEM_INSERT): Remove; no longer needed.
1865 2012-04-22 Leo Liu <sdl.web@gmail.com>
1867 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1869 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1871 * sysdep.c [__FreeBSD__]: Minor cleanups.
1872 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1873 Use Emacs indenting style more consistently. Avoid some casts.
1874 Use 'double' consistently rather than mixing 'float' and 'double'.
1876 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1878 * sysdep.c (list_system_processes, system_process_attributes):
1879 Add implementation for FreeBSD (Bug#5243).
1881 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1883 * lisp.mk (lisp): Update.
1885 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1887 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1888 It is never used otherwise.
1890 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1892 * print.c (print_preprocess): Only check print_depth if print-circle
1894 (print_object): Check for cycles even when print-circle is nil and
1895 print-gensym is t, but only check print_depth if print-circle is nil.
1897 2012-04-20 Chong Yidong <cyd@gnu.org>
1899 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1900 set the status to "failed" and ensure that sentinel is run.
1902 2012-04-20 Glenn Morris <rgm@gnu.org>
1904 * process.c (Fset_process_inherit_coding_system_flag)
1905 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1906 (Fmake_network_process, Fmake_serial_process): Doc fix.
1908 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1910 * xdisp.c (string_buffer_position_lim): Limit starting position to
1912 (set_cursor_from_row): If called for a mode-line or header-line
1913 row, return zero immediately.
1914 (try_cursor_movement): If inside continuation line, don't back up
1915 farther than the first row after the header line, if any.
1916 Don't consider the header-line row as "partially visible", even if
1917 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1919 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1921 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1924 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1925 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1927 configure: new option --enable-gcc-warnings (Bug#11207)
1928 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1929 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1930 (ALL_CFLAGS): Use new macros rather than old.
1931 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1932 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1933 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1934 -Wunused-result, -Wunused-variable. This should go away once
1935 the Emacs and Gnulib regex code is merged.
1936 (xmalloc, xrealloc): Now static.
1938 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1940 * dired.c (Fsystem_groups): Remove unused local.
1942 2012-04-17 Glenn Morris <rgm@gnu.org>
1944 * dired.c (Fsystem_users): Doc fix.
1946 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1948 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1949 (syms_of_dired): Add them.
1951 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1953 Fix minor alloc.c problems found by static checking.
1954 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1955 New extern decls, to avoid calling undeclared functions.
1956 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1957 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1958 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1959 (NEED_MEM_INSERT): New macro.
1960 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1961 Remove one incorrect comment and fix another.
1963 Fix minor ralloc.c problems found by static checking.
1964 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1965 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1966 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1967 (r_alloc_sbrk): Now static.
1969 Improve ralloc.c interface checking.
1970 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1971 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1972 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1973 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1974 [REL_ALLOC]: ... to here, to check interface.
1975 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1976 Remove decls. This fixes an "It stinks!".
1978 * alloc.c (which_symbols): Fix alignment issue / type clash.
1980 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1982 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1983 (struct Lisp_Misc_Any): Likewise.
1984 (struct Lisp_Free): Likewise.
1985 * alloc.c (union aligned_Lisp_Symbol): Define.
1986 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1987 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1988 (union aligned_Lisp_Misc): Define.
1989 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1990 aligned_Lisp_Misc instead of union Lisp_Misc.
1991 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1993 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1995 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1996 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1997 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1998 * s/netbsd.h, s/sol2-6.h:
1999 Remove definition of GC_MARK_STACK, since the default now works.
2000 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2001 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2002 no longer the default.
2003 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2005 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2007 * lread.c (lisp_file_lexically_bound_p):
2008 Fix hang at ";-*-\n" (bug#11238).
2010 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2012 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2013 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2015 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2017 * nsterm.m (constrainFrameRect): Always constrain when there is only
2018 one screen (Bug#10962).
2020 2012-04-13 Ken Brown <kbrown@cornell.edu>
2022 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2024 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2026 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2028 2012-04-11 Daniel Colascione <dancol@dancol.org>
2030 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2031 against is gone. It's better to use vfork now so that when Cygwin
2032 gains a new, working vfork, we use it automatically (bug#10398).
2034 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2036 * window.c (save_window_save): Obey window-point-insertion-type.
2038 2012-04-11 Glenn Morris <rgm@gnu.org>
2040 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2042 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2044 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2046 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2048 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2049 (force_quit_count): New var.
2050 (handle_interrupt): Use it.
2052 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2054 * w32.c (w32_delayed_load): Record the full path of the library
2055 being loaded (bug#10424).
2057 2012-04-09 Glenn Morris <rgm@gnu.org>
2059 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2060 not just in the obarray, before snarfing them. (Bug#11036)
2062 * Makefile.in ($(leimdir)/leim-list.el):
2063 Pass EMACS rather than BUILT_EMACS.
2065 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2067 * process.c (make_process):
2068 * process.h: Add integer `gnutls_handshakes_tried' member to
2071 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2072 Add convenience `GNUTLS_LOG2i' macro.
2074 * gnutls.c (gnutls_log_function2i): Convenience log function.
2075 (emacs_gnutls_read): Use new log functions,
2076 `gnutls_handshakes_tried' process member, and
2077 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2078 attempts per process (connection).
2080 2012-04-09 Chong Yidong <cyd@gnu.org>
2082 * eval.c (Fuser_variable_p, user_variable_p_eh)
2083 (lisp_indirect_variable): Functions deleted.
2084 (Fdefvar): Caller changed.
2086 * callint.c (Finteractive, Fcall_interactively):
2087 * minibuf.c (Fread_variable): Callers changed.
2089 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2091 * xdisp.c (set_cursor_from_row): If the display string appears in
2092 the buffer at position that is closer to point than the position
2093 after the display string, display the cursor on the first glyph of
2094 the display string. Fixes cursor display when a 'display' text
2095 property immediately follows invisible text. (Bug#11094)
2097 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2099 composite.c: use 'double' consistently
2100 * composite.c (get_composition_id): Use 'double' consistently
2101 instead of converting 'float' to 'double' and vice versa; this is
2102 easier to understand and avoids a GCC warning.
2104 2012-04-09 Glenn Morris <rgm@gnu.org>
2106 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2107 preparation for dumping it with emacs. (Bug#4789)
2108 (leimdir): New variable.
2109 ($(leimdir)/leim-list.el): New rule.
2110 (emacs$(EXEEXT)): Depend on leim-list.el.
2112 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2113 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2114 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2116 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2118 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2121 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2123 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2124 Remove unused local variable.
2126 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2128 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2129 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2130 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2131 objects, as mark_maybe_pointer will catch them otherwise.
2132 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2133 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2135 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2137 Fix typo that broke non-Windows builds.
2138 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2140 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2142 Support building on MS-Windows with libxml2.
2144 * makefile.w32-in (OBJ2): Add xml.$(O).
2145 (GLOBAL_SOURCES): Add xml.c.
2146 ($(BLD)/xml.$(O)): New dependency list.
2148 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2149 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2150 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2151 [!WINDOWSNT]: New macros.
2152 (init_libxml2_functions, libxml2_loaded_p): New functions.
2153 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2154 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2155 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2156 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2158 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2159 Call init_libxml2_functions before calling libxml2 functions.
2160 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2162 * emacs.c: Don't include libxml/parser.h.
2163 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2164 xmlCleanupParser directly.
2166 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2168 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2170 * indent.c (Fvertical_motion): If there is a display string at
2171 point, use it.vpos to compute how many lines to backtrack after
2172 move_it_to point. (Bug#11133)
2174 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2176 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2177 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2178 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2179 macros related to unification of CJK characters. For the details,
2180 see the discussion following the message here:
2181 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2183 2012-04-04 Chong Yidong <cyd@gnu.org>
2185 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2187 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2189 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2190 instead of alloca. (Bug#11138)
2192 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2194 * w32menu.c (is_simple_dialog): Properly check lisp types.
2197 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2199 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2200 position we get to after a call to move_it_to fails the
2201 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2202 only if we wind up in a string from display property. (Bug#11063)
2204 * window.c (Fdelete_other_windows_internal): Invalidate the row
2205 and column information about mouse highlight, so that redisplay
2206 restores it after reallocating the glyph matrices. (Bug#7464)
2208 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2209 string comes from a `display' text property, use the buffer
2210 position of that property as if we actually saw that position in
2212 (move_it_by_lines): Remove the assertion that
2213 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2214 violated when there's a before-string at the beginning of a line.
2217 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2219 * xdisp.c (append_space_for_newline): If the default face was
2220 remapped, use the remapped face for the appended newline.
2221 (extend_face_to_end_of_line): Use the remapped default face for
2222 extending the face to the end of the line.
2223 (display_line): Call extend_face_to_end_of_line when the default
2224 face was remapped. (Bug#11068)
2226 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2228 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2230 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2232 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2234 2012-03-27 Glenn Morris <rgm@gnu.org>
2236 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2239 2012-03-26 Kenichi Handa <handa@m17n.org>
2241 * dispextern.h (struct glyph): Fix previous change. Change the
2242 bit length of glyphless.ch to 25 (Bug#11082).
2244 2012-03-26 Chong Yidong <cyd@gnu.org>
2246 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2247 (command_loop_1): Use it; inhibit selection update for
2248 handle-select-window too (Bug#8996).
2250 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2252 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2254 2012-03-25 Kenichi Handa <handa@m17n.org>
2256 * dispextern.h (struct glyph): Change the bit length of
2257 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2259 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2261 * s/ms-w32.h (tzname): Include time.h before redirecting to
2262 _tzname. Fixes the MSVC build. (Bug#9960)
2264 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2266 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2269 * xterm.c (XTread_socket): Only modify handling_signal if
2270 !SYNC_INPUT. (Bug#11080)
2272 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2274 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2275 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2276 when fetching a multibyte character consumes more bytes than
2277 CHAR_BYTES returns, due to unification of CJK characters in
2278 string_char. (Bug#11073)
2280 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2282 * process.c (wait_reading_process_output): Handle pty disconnect
2283 by refraining from sending oneself a SIGCHLD (bug#10933).
2285 2012-03-22 Chong Yidong <cyd@gnu.org>
2287 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2289 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2290 Mark string as coming from a prefix property.
2291 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2292 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2294 2012-03-21 Chong Yidong <cyd@gnu.org>
2296 * xfaces.c (Vface_remapping_alist): Doc fix.
2298 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2300 * w32proc.c (Fw32_set_console_codepage)
2301 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2304 2012-03-20 Chong Yidong <cyd@gnu.org>
2306 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2307 to reflect default non-nil value of redisplay-dont-pause.
2309 2012-03-19 Kenichi Handa <handa@m17n.org>
2311 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2312 it fit in a valid range (Bug#11003).
2314 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2316 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2317 that is not from display property, accept the row as a "cursor
2318 row" if one of the string's character has a non-nil `cursor'
2319 property. Fixes cursor positioning when there are newlines in
2320 overlay strings, e.g. in icomplete.el. (Bug#11035)
2322 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2324 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2326 2012-03-12 Chong Yidong <cyd@gnu.org>
2328 * eval.c (inhibit_lisp_code): Rename from
2329 inhibit_window_configuration_change_hook; move from window.c.
2331 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2332 * window.c (run_window_configuration_change_hook)
2333 (syms_of_window): Callers changed.
2335 2012-03-11 Chong Yidong <cyd@gnu.org>
2337 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2339 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2341 2012-03-10 Chong Yidong <cyd@gnu.org>
2343 * frame.c (other_visible_frames): Don't assume the selected frame
2344 is visible (Bug#10955).
2346 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2348 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2350 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2352 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2353 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2356 2012-03-03 Glenn Morris <rgm@gnu.org>
2358 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2360 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2362 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2363 position past the first glyph_row that ends at ZV. (Bug#10902)
2364 (redisplay_window, next_element_from_string): Fix typos in
2366 (redisplay_window): Pass to move_it_vertically the margin in
2367 pixels, not in screen lines.
2369 2012-03-02 Glenn Morris <rgm@gnu.org>
2371 * buffer.c (buffer-list-update-hook): Doc fix.
2373 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2375 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2376 push_it before setting up the iterator for the first overlay
2377 string, even if we have an empty string loaded.
2378 (next_overlay_string): If there's an empty string on the iterator
2379 stack, pop the stack. (Bug#10903)
2381 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2383 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2384 Suggested by Stefan Monnier in
2385 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2386 * alloc.c (widen_to_Lisp_Object): New static function.
2387 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2388 and widening them to Lisp_Objects. This would work even if
2389 USE_LSB_TAG is defined and wide integers are used, which might
2390 happen in a future version of Emacs.
2392 2012-02-25 Chong Yidong <cyd@gnu.org>
2394 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2397 * xselect.c (Fx_selection_exists_p): Doc fix.
2398 (x_clipboard_manager_save_all): Print an informative message
2399 before saving to clipboard manager.
2401 2012-02-24 Chong Yidong <cyd@gnu.org>
2403 * keyboard.c (process_special_events): Handle all X selection
2404 requests in kbd_buffer, not just the next one (Bug#8869).
2406 2012-02-23 Chong Yidong <cyd@gnu.org>
2408 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2409 call when setting menu-bar-lines and tool-bar-lines parameters.
2410 (unwind_create_frame_1): New helper function.
2412 * window.c (inhibit_window_configuration_change_hook): New var.
2413 (run_window_configuration_change_hook): Obey it.
2414 (syms_of_window): Initialize it.
2416 2012-02-22 Chong Yidong <cyd@gnu.org>
2418 * xterm.c (x_draw_image_relief): Add missing type check for
2419 Vtool_bar_button_margin (Bug#10743).
2421 2012-02-21 Chong Yidong <cyd@gnu.org>
2423 * fileio.c (Vfile_name_handler_alist): Doc fix.
2425 * buffer.c (Fget_file_buffer): Protect against invalid file
2426 handler return value.
2428 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2430 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2431 when computing $valmask.
2433 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2434 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2435 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2436 It's useless in that case, and it can cause problems on hosts
2437 that allocate halves of EMACS_INT values separately.
2438 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2439 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2440 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2441 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2442 it avoids undefined behavior on hosts where shifting right by more
2443 than the word width has undefined behavior.
2445 2012-02-19 Chong Yidong <cyd@gnu.org>
2447 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2448 (Funhandled_file_name_directory, Ffile_name_as_directory)
2449 (Fdirectory_file_name, Fexpand_file_name)
2450 (Fsubstitute_in_file_name): Protect against invalid file handler
2451 return values (Bug#10845).
2453 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2455 * .gdbinit (pitx): Fix incorrect references to fields of the
2458 2012-02-17 Chong Yidong <cyd@gnu.org>
2460 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2462 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2464 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2465 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2467 2012-02-15 Chong Yidong <cyd@gnu.org>
2469 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2470 marked as special. Also, starting docstrings with * is obsolete.
2472 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2474 * gnutls.c (emacs_gnutls_write): Fix last change.
2476 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2478 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2481 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2483 * keymap.c (Fsingle_key_description): Handle char ranges.
2485 2012-02-12 Chong Yidong <cyd@gnu.org>
2487 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2488 as that creates a dangerous corner case.
2490 * window.c (Fdelete_window_internal): Invalidate the mouse
2491 highlight (Bug#9904).
2493 2012-02-12 Glenn Morris <rgm@gnu.org>
2495 * xselect.c (Fx_own_selection_internal)
2496 (Fx_get_selection_internal, Fx_disown_selection_internal)
2497 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2498 * nsselect.m (Fx_own_selection_internal)
2499 (Fx_disown_selection_internal, Fx_selection_exists_p)
2500 (Fx_selection_owner_p, Fx_get_selection_internal):
2501 Sync docs and argument specs with the xselect.c versions.
2503 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2505 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2507 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2509 * w32select.c (Fx_selection_exists_p): Sync doc string and
2510 argument list with xselect.c. (Bug#10783)
2512 * w16select.c (Fx_selection_exists_p): Sync doc string and
2513 argument list with xselect.c. (Bug#10783)
2515 2012-02-10 Glenn Morris <rgm@gnu.org>
2517 * fns.c (Fsecure_hash): Doc fix.
2519 2012-02-09 Kenichi Handa <handa@m17n.org>
2521 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2523 2012-02-07 Chong Yidong <cyd@gnu.org>
2525 * buffer.c (Fbuffer_local_variables)
2526 (buffer_lisp_local_variables): Handle unbound vars correctly;
2527 don't let Qunbound leak into Lisp.
2529 2012-02-07 Glenn Morris <rgm@gnu.org>
2531 * image.c (Fimagemagick_types): Doc fix.
2533 * image.c (imagemagick-render-type): Change it from a lisp object
2534 to an integer. Move the doc here from the lisp manual.
2535 Treat all values not equal to 0 the same.
2537 2012-02-06 Chong Yidong <cyd@gnu.org>
2539 * doc.c (store_function_docstring): Avoid applying docstring of
2540 alias to base function (Bug#2603).
2542 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2544 * .gdbinit (pp1, pv1): Remove redundant defines.
2547 2012-02-04 Chong Yidong <cyd@gnu.org>
2549 * nsterm.m: Declare a global (Bug#10694).
2551 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2553 * w32.c (get_emacs_configuration_options):
2554 Include --enable-checking, if specified, in the return value.
2556 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2558 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2559 after rounding frame sizes. (Bug#9723)
2561 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2563 * keyboard.c (adjust_point_for_property): Don't position point
2564 before BEGV. (Bug#10696)
2566 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2568 Handle overflow when computing char display width (Bug#9496).
2569 * character.c (char_width): Return EMACS_INT, not int.
2570 (char_width, c_string_width): Check for overflow when
2571 computing the width; this is possible now that individual
2572 characters can have unbounded width. Problem introduced
2573 by merge from Emacs 23 on 2012-01-19.
2575 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2577 * dbusbind.c (Fdbus_register_method): Mention the return value
2578 :ignore in the docstring.
2580 2012-02-02 Glenn Morris <rgm@gnu.org>
2582 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2584 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2585 Unconditionally set to t. (Bug#10673)
2586 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2587 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2588 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2590 2012-02-02 Kenichi Handa <handa@m17n.org>
2592 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2593 0, do not call append_composite_glyph.
2595 2012-02-02 Kenichi Handa <handa@m17n.org>
2597 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2599 (x_produce_glyphs): If the component of a composition is a null
2600 string, set it->pixel_width to 1 to avoid zero-width glyph.
2602 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2604 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2605 first 2 arguments are identical. This makes inserting large
2606 output from a subprocess an order of magnitude faster on
2607 MS-Windows, where all sbrk'ed memory is always contiguous.
2609 2012-01-31 Glenn Morris <rgm@gnu.org>
2611 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2612 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2613 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2615 2012-01-29 Glenn Morris <rgm@gnu.org>
2617 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2619 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2621 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2623 2012-01-28 Chong Yidong <cyd@gnu.org>
2625 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2627 2012-01-26 Chong Yidong <cyd@gnu.org>
2629 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2631 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2632 repeat counts (Bug#10507).
2634 2012-01-26 Glenn Morris <rgm@gnu.org>
2636 * lread.c (syms_of_lread): Doc fix.
2638 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2640 * coding.c (encode_designation_at_bol): Change return value to
2643 2012-01-25 Chong Yidong <cyd@gnu.org>
2645 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2647 2012-01-21 Chong Yidong <cyd@gnu.org>
2649 * floatfns.c (Fcopysign): Make the second argument non-optional,
2650 since nil is not allowed anyway.
2652 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2654 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2655 (send_process): Likewise.
2657 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2659 * window.c (save_window_save, Fcurrent_window_configuration)
2660 (Vwindow_persistent_parameters): Do not use Qstate.
2661 Rewrite doc-strings.
2663 2012-01-19 Kenichi Handa <handa@m17n.org>
2665 * character.c (char_width): New function.
2666 (Fchar_width, c_string_width, lisp_string_width):
2667 Use char_width (Bug#9496).
2669 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2671 * window.c (Vwindow_persistent_parameters): New variable.
2672 (Fset_window_configuration, save_window_save): Handle persistent
2675 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2677 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2678 thrashing the stack of the thread. (Bug#9087)
2680 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2682 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2684 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2686 * xdisp.c (rows_from_pos_range): Handle the case where the
2687 highlight ends on a newline. (Bug#10464)
2688 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2689 he end column for display of highlight that ends on a newline
2692 2012-01-11 Glenn Morris <rgm@gnu.org>
2694 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2695 from load-path also when installation-directory is nil. (Bug#10208)
2697 2012-01-10 Glenn Morris <rgm@gnu.org>
2699 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2701 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2702 Update template values to be closer to their typical values these days.
2704 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2706 * xdisp.c (rows_from_pos_range): Accept additional argument
2707 DISP_STRING, and accept any glyph in a row whose object is that
2708 string as eligible for mouse highlight. Fixes mouse highlight of
2709 display strings from overlays. (Bug#10464)
2711 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2713 emacs: fix an auto-save permissions race condition (Bug#10400)
2714 * fileio.c (auto_saving_dir_umask): New static var.
2715 (Fmake_directory_internal): Use it.
2716 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2717 creating the directory. The old code temporarily assigns
2718 too-generous permissions to the directory.
2719 (do_auto_save_eh): Clear it.
2720 (Fdo_auto_save): Catch all errors, not just file errors, so
2721 that the var is always cleared.
2723 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2725 * search.c (scan_buffer): Pass character positions to
2726 know_region_cache, not byte positions. (Bug#6540)
2728 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2730 * w32.c (sys_rename): Report EXDEV when rename of a directory
2731 fails because the target is on another logical disk. (Bug#10284)
2733 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2735 * xterm.c (x_embed_request_focus): New function.
2737 * xterm.h: Add prototype.
2739 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2741 2012-01-05 Glenn Morris <rgm@gnu.org>
2743 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2745 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2747 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2748 Load gnutls_transport_set_lowat only if GnuTLS version is below
2750 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2751 GnuTLS versions below 2.11.1.
2753 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2755 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2756 to the doc string advising against its use for altering the way
2757 windows are scrolled.
2759 2011-12-28 Kenichi Handa <handa@m17n.org>
2761 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2762 coding-system ASCII compatible only when it does not produce BOM
2763 on encoding (Bug#10383).
2765 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2767 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2769 (create_and_show_popup_menu): Always use menu_position_func for
2772 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2774 * callint.c (Fcall_interactively): Don't truncate prompt string.
2776 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2778 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2779 property that ends at ZV, so that the bidi iteration could be
2780 resumed from there (after widening). (Bug#10360)
2782 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2784 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2786 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2788 * nsterm.m (x_free_frame_resources):
2789 Release f->output_data.ns->miniimage.
2790 (ns_index_color): Fix indentation. Do not retain
2791 color_table->colors[i].
2793 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2796 * nsfns.m (x_set_background_color): Assign return value from
2797 ns_index_color to face-background instead of NSColor*.
2798 (ns_implicitly_set_icon_type): Fix indentation.
2799 Change assignment in for loop to comparison.
2801 * emacs.c (ns_pool): New variable.
2802 (main): Assign ns_pool.
2803 (Fkill_emacs): Call ns_release_autorelease_pool.
2805 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2806 autorelease fdesc, release fdAttrs and tdict.
2807 (ns_get_covering_families): Release charset.
2808 (ns_findfonts): Release NSFontDescriptor created with new.
2809 (ns_uni_to_glyphs): Fix indentation.
2810 (setString): Release attrStr before assigning new value.
2812 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2814 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2816 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2817 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2819 2011-12-18 David Reitter <reitter@cmu.edu>
2821 * nsterm.m (ns_term_init): Subscribe for notifications
2822 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2823 to method trackingNotification in EmacsMenu.
2825 * nsmenu.m (trackingMenu): New variable.
2826 (trackingNotification): New method (from Aquamacs).
2827 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2828 from Aquamacs (Bug#7030).
2830 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2832 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2833 (symbol_to_nsstring): Fix indentation.
2834 (ns_symbol_to_pb): New function.
2835 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2836 (Fns_rotate_cut_buffers_internal): Remove.
2837 (Fns_store_selection_internal): Rename from
2838 Fns_store_cut_buffer_internal.
2839 (ns_get_foreign_selection, Fx_own_selection_internal)
2840 (Fx_disown_selection_internal, Fx_selection_exists_p)
2841 (Fns_get_selection_internal, Fns_store_selection_internal):
2842 Use ns_symbol_to_pb and check if return value is nil.
2843 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2844 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2845 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2846 renamed to Sns_store_selection_internal.
2847 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2848 and remove this function.
2849 (ns_handle_selection_clear): Remove, never used.
2850 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2853 2011-12-17 Ken Brown <kbrown@cornell.edu>
2855 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2856 GID is unknown (Bug#10257).
2858 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2860 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2861 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2862 which caused a build failure on GNU/Linux IA-64. This problem was
2863 introduced by my 2011-10-07 patch.
2865 2011-12-15 Juri Linkov <juri@jurta.org>
2867 * image.c (imagemagick_error): New function. (Bug#10112)
2868 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2869 Use `imagemagick_error' where ImageMagick functions return
2871 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2874 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2876 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2877 fill background (Bug#8992).
2879 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2881 * window.c (Vwindow_combination_resize)
2882 (Vwindow_combination_limit): Use t instead of non-nil in
2884 (Vrecenter_redisplay): Add first sentence of doc-string on
2886 (Frecenter): Fix doc-string typo.
2888 2011-12-11 Kenichi Handa <handa@m17n.org>
2890 * coding.c (Funencodable_char_position): Pay attention to the
2891 buffer text relocation (Bug#9389).
2893 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2895 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2896 gtk_init (Bug#10100).
2898 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2900 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2901 IT->string is nil. (Bug#10263)
2903 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2905 * nsterm.h (x_free_frame_resources): Declare.
2907 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2908 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2910 * nsterm.h (ns_get_defaults_value): Declare.
2912 * nsterm.m (ns_default): Call ns_get_defaults_value.
2914 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2916 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2919 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2921 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2922 that where the value of an _OBJC_* symbol points to is in the .bss
2923 section (Bug#10240).
2925 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2927 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2928 after the loop to call ccl_driver at least once (Bug#8619).
2930 2011-12-08 Kenichi Handa <handa@m17n.org>
2932 * ftfont.c (get_adstyle_property): Fix previous change
2935 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2937 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2938 dirs from the default value of EMACSLOADPATH (bug#10208).
2940 2011-12-07 Glenn Morris <rgm@gnu.org>
2942 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2943 installation and source directories as well. (Bug#10208)
2945 2011-12-06 Chong Yidong <cyd@gnu.org>
2947 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2949 2011-12-06 Glenn Morris <rgm@gnu.org>
2951 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2952 as an error, not just -1. (Bug#10217)
2954 2011-12-05 Chong Yidong <cyd@gnu.org>
2956 * keyboard.c (process_special_events): New function.
2957 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2959 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2961 * coding.c (encode_designation_at_bol): Don't use uninitialized
2962 local variable (Bug#9318).
2964 2011-12-05 Kenichi Handa <handa@m17n.org>
2966 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2967 return Qnil (Bug#8046, Bug#10193).
2969 2011-12-05 Kenichi Handa <handa@m17n.org>
2971 * coding.c (encode_designation_at_bol): New args charbuf_end and
2972 dst. Return the number of produced bytes. Callers changed.
2973 (coding_set_source): Return how many bytes coding->source was
2975 (coding_set_destination): Return how many bytes
2976 coding->destination was relocated.
2977 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2978 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2980 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2982 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2983 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2986 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2988 The following changes are to fix Bug#9318.
2990 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2991 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2992 (encode_coding_iso_2022, encode_coding_sjis)
2993 (encode_coding_big5, encode_coding_charset): Use the above macros.
2995 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2997 * lisp.h (process_quit_flag): Fix external declaration.
2999 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3001 Don't macro-inline non-performance-critical code.
3002 * eval.c (process_quit_flag): New function.
3003 * lisp.h (QUIT): Use it.
3005 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3007 * nsfns.m (get_geometry_from_preferences): New function.
3008 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3010 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3012 * emacs.c (Qkill_emacs): Define.
3013 (syms_of_emacs): Initialize it.
3014 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3015 Qquit_flag to `kill-emacs' instead.
3016 (quit_throw_to_read_char): Add parameter `from_signal'.
3017 All callers changed. Call Fkill_emacs if requested and safe.
3018 * lisp.h (QUIT): Call Fkill_emacs if requested.
3020 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3022 * widget.c (update_wm_hints): Return if wmshell is null.
3023 (widget_update_wm_size_hints): New function.
3025 * widget.h (widget_update_wm_size_hints): Declare.
3027 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3028 widget_update_wm_size_hints (Bug#10104).
3030 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3032 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3033 before a newline, prepare the bidi iterator for consuming the
3034 newline, and keep the current paragraph direction. (Bug#10183)
3035 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3037 2011-12-02 Juri Linkov <juri@jurta.org>
3039 * search.c (Fword_search_regexp): New Lisp function created from
3040 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3041 (Fword_search_backward, Fword_search_forward)
3042 (Fword_search_backward_lax, Fword_search_forward_lax):
3043 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3044 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3046 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3048 * fileio.c (Finsert_file_contents): Move after-change-function call
3049 to before the "handled:" label, since all "goto handled" appear in
3050 cases where the *-change-functions have already been properly called
3053 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3055 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3056 waiting for input. (Bug#10169)
3058 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3060 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3061 verifies glyph row's hash code--we have just reallocated the
3062 glyphs, so their contents can be complete garbage. (Bug#10164)
3064 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3066 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3068 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3070 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3071 attributes are tested _before_ calling verify_row_hash, to protect
3072 against GCC re-ordering of the tests. (Bug#10164)
3074 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3076 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3078 * xterm.c (handle_one_xevent): Only set async_visible and friends
3079 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3080 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3081 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3083 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3085 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3086 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3087 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3088 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3089 All uses changed to use GCPRO1 etc.
3090 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3091 Revert to old implementation (i.e., before 2011-03-11).
3093 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3095 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3096 of scroll runs so as to avoid assigning disabled bogus rows and
3097 unnecessary graphics copy operations.
3099 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3101 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3102 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3103 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3104 (malloc, free, realloc, calloc): Redirect to e_* only when
3107 * lisp.h (GCTYPEBITS): Move before first use.
3108 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3109 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3110 this macro definition.
3112 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3115 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3117 * gtkutil.c (xg_create_frame_widgets):
3118 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3119 present with Gtk+ 2.0.
3121 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3123 * fileio.c (Finsert_file_contents): Undo previous change; see
3124 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3126 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3128 Rename locals to avoid shadowing.
3129 * fileio.c (Finsert_file_contents):
3130 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3131 * process.c (wait_reading_process_output):
3132 Rename inner 'proc' to 'p' to avoid shadowing.
3133 Indent for consistency with usual Emacs style.
3135 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3137 * xdisp.c (redisplay_window): If cursor row is not fully visible
3138 after recentering, and scroll-conservatively is set to a large
3139 number, scroll window by a few more lines to make the cursor fully
3140 visible and out of scroll-margin. (Bug#10105)
3141 (start_display): Don't move to the next line if the display should
3142 start at a newline that is part of a display vector or an overlay
3145 2011-11-24 Juri Linkov <juri@jurta.org>
3147 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3148 after the `MagickPingImage' call. (Bug#10112)
3150 2011-11-23 Chong Yidong <cyd@gnu.org>
3152 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3154 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3156 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3157 making another buffer current. (Bug#10114)
3159 2011-11-23 Glenn Morris <rgm@gnu.org>
3161 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3163 2011-11-23 Chong Yidong <cyd@gnu.org>
3165 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3166 using it (Bug#5984).
3168 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3170 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3171 and header-lines, as they don't have one computed for them.
3174 * .gdbinit (prow): Make displayed values more self-explaining.
3175 Add row's hash code.
3177 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3179 * process.c (wait_reading_process_output): Fix asynchrounous
3180 GnuTLS socket handling on some versions of the GnuTLS library.
3181 (wait_reading_process_output): Add comment and URL.
3183 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3185 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3187 2011-11-21 Chong Yidong <cyd@gnu.org>
3189 * window.c (Fnext_window, Fprevious_window): Doc fix.
3191 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3193 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3195 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3197 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3199 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3201 * window.c (Fset_window_combination_limit): Rename argument
3203 (Vwindow_combination_limit): Remove "status" from doc-string.
3205 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3207 * m/ibms390.h: Remove.
3208 * m/ibms390x.h: Don't include "ibms390.h".
3210 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3212 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3213 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3215 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3217 * casetab.c (Fset_case_table):
3218 * charset.c (Fcharset_after): Fix typos.
3220 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3222 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3223 Otherwise, valgrind does not work on some platforms.
3224 Problem reported by Andreas Schwab in
3225 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3226 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3227 is set, removing the need for VIRT_ADDRESS_VARIES.
3228 (PURE_P): Use a more-efficient implementation that needs just one
3229 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3230 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3231 to 4 (xorl, subq, cmpq, setbe).
3232 * alloc.c (pure): Always extern now, since that's the
3233 VIRT_ADDR_VARIES behavior.
3234 (PURE_POINTER_P): Use a single comparison, not two, for
3235 consistency with the new puresize.h.
3236 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3237 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3238 Remove VIRT_ADDR_VARIES no longer needed.
3240 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3242 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3243 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3244 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3245 behave as if the cursor position were at the window margin.
3247 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3248 and the cursor position is out of bounds, behave as if the cursor
3249 position were at the window margin. (Bug#10075)
3251 2011-11-18 Chong Yidong <cyd@gnu.org>
3253 * window.c (Fwindow_combination_limit): Make first argument
3254 non-optional, since it is meaningless for live windows like the
3257 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3259 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3261 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3263 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3264 (graft_intervals_into_buffer): Simplify.
3266 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3268 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3269 hash values of the two rows.
3270 (copy_row_except_pointers): Preserve the used[] arrays and the
3271 hash values of the two rows. (Bug#10035)
3272 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3274 * xdisp.c (row_hash): New function, body extracted from
3275 compute_line_metrics.
3276 (compute_line_metrics): Call row_hash, instead of computing the
3279 * dispnew.c (verify_row_hash): Call row_hash for computing the
3280 hash code of a row, instead of duplicating code from xdisp.c.
3282 * dispextern.h (row_hash): Add prototype.
3284 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3286 * frame.c (delete_frame): Don't delete the terminal when the last
3287 X frame is closed if emacs is built with GTK toolkit.
3289 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3291 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3293 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3295 * window.c (Vwindow_splits): Rename to
3296 Vwindow_combination_resize. Suggested by Juri Linkov.
3297 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3300 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3302 * nsfns.m (Fns_font_name):
3303 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3305 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3307 * window.h (window): Rename slot "nest" to "combination_limit".
3308 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3309 (Fset_window_nest): Rename to Fset_window_combination_limit.
3310 (Vwindow_nest): Rename to Vwindow_combination_limit.
3311 (recombine_windows, make_parent_window, make_window)
3312 (Fsplit_window_internal, saved_window)
3313 (Fset_window_configuration, save_window_save): Rename all
3314 occurrences of window_nest to window_combination_limit.
3316 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3318 * image.c (imagemagick_load_image): Fix typo.
3320 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3322 * xdisp.c (display_line): Move the call to
3323 highlight_trailing_whitespace before the call to
3324 compute_line_metrics, since the latter needs to see the final
3325 faces of all the glyphs to compute ROW's hash value.
3326 Fixes assertion violations in row_equal_p. (Bug#10035)
3328 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3330 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3331 just return (bug#10044).
3333 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3335 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3336 with user-defined heap size. Bump the default size of the temacs
3337 heap to 27MB, to avoid memory warning when running temacs.
3338 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3340 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3341 current_matrix and desired_matrix. (Bug#9990)
3342 (verify_row_hash) [XASSERTS]: New function.
3343 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3344 that the hash value of glyph rows is correct.
3346 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3348 * window.h (window): Remove splits slot.
3349 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3350 (Fdelete_other_windows_internal, make_parent_window)
3351 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3352 (Fset_window_configuration, save_window_save): Don't deal with
3353 split status of windows.
3354 (saved_window): Remove splits slot.
3355 (Vwindow_splits): Rewrite doc-string.
3357 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3359 * xfns.c (unwind_create_frame):
3360 * nsfns.m (unwind_create_frame):
3361 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3362 Vframe_list (Bug#9999).
3364 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3366 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3368 2011-11-11 Kenichi Handa <handa@m17n.org>
3370 * callproc.c (Fcall_process): Set the member dst_multibyte of
3373 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3375 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3376 avoid a crash (bug#9496).
3378 2011-11-09 Chong Yidong <cyd@gnu.org>
3380 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3381 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3383 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3385 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3387 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3389 Avoid some portability problems by eschewing 'extern inline' functions.
3390 The trivial performance wins aren't worth the portability hassles; see
3391 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3393 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3394 (window_box_width, window_box_left, window_box_left_offset)
3395 (window_box_right, window_box_right_offset): Undo previous change,
3396 by removing the "extern"s.
3397 * intervals.c (adjust_intervals_for_insertion)
3398 (adjust_intervals_for_deletion): Undo previous change,
3399 making these static again.
3400 (offset_intervals, temp_set_point_both, temp_set_point)
3401 (copy_intervals_to_string): No longer inline.
3402 * xdisp.c (window_text_bottom_y, window_box_width)
3403 (window_box_height, window_box_left_offset)
3404 (window_box_right_offset, window_box_left, window_box_right)
3405 (window_box): No longer inline.
3407 2011-11-08 Chong Yidong <cyd@gnu.org>
3409 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3410 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3411 Signal an error if not a live window.
3412 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3413 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3415 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3417 * lisp.h (syms_of_abbrev): Remove declaration.
3418 Reported by CHENG Gao <chenggao@royau.me>.
3420 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3422 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3423 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3424 of temacs in GUI mode.
3426 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3428 * window.h: Declare delete_all_child_windows instead of
3429 delete_all_subwindows.
3430 * window.c (Fwindow_nest, Fset_window_nest)
3431 (Fset_window_new_total, Fset_window_new_normal)
3432 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3433 (delete_all_subwindows): Rename to delete_all_child_windows.
3434 (Fdelete_other_windows_internal, Fset_window_configuration):
3435 Call delete_all_child_windows instead of delete_all_subwindows.
3436 * frame.c (delete_frame): Call delete_all_child_windows instead
3437 of delete_all_subwindows.
3439 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3441 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3442 This is also needed for porting to any host where GC_MARK_STACK is
3443 not GC_MAKE_GCPROS_NOOPS.
3444 (which_symbols): Use it.
3446 2011-11-07 Kenichi Handa <handa@m17n.org>
3448 * coding.c (coding_set_destination): Check coding->src_pos only
3449 when coding->src_object is a buffer (bug#9910).
3451 * process.c (send_process): Set the member src_multibyte of coding
3452 to 0 (bug#9911) when sending a unibyte text.
3454 * callproc.c (Fcall_process): Set the member src_multibyte of
3455 process_coding to 0 (bug#9912).
3457 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3459 * xmenu.c (cleanup_widget_value_tree): New function.
3460 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3461 calling free_menubar_widget_value_tree directly (Bug#9830).
3463 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3465 Fix some portability problems with 'inline'.
3466 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3467 (window_box_width, window_box_left, window_box_left_offset)
3468 (window_box_right, window_box_right_offset): Declare extern.
3469 Otherwise, these inline functions do not conform to C99 and
3470 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3471 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3472 * intervals.c (adjust_intervals_for_insertion)
3473 (adjust_intervals_for_deletion): Now extern, because otherwise the
3474 extern inline functions 'offset_intervals' couldn't refer to it.
3475 (static_offset_intervals): Remove.
3476 (offset_intervals): Rewrite using the old contents of
3477 static_offset_intervals. The old version didn't conform to C99
3478 because an extern inline function contained a reference to an
3479 identifier with static linkage.
3481 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3483 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3486 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3488 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3489 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3490 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3491 return Qleft_to_right.
3493 2011-11-06 Chong Yidong <cyd@gnu.org>
3495 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3496 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3497 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3498 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3499 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3500 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3501 (Fwindow_vscroll): Doc fix.
3502 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3503 argument, since it makes no sense to pass a live window and for
3504 consistency with window-child.
3506 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3508 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3511 2011-11-05 Jason Rumney <jasonr@gnu.org>
3513 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3514 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3516 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3517 bitwise arithmetic preventing use of unicode-sip and non-truetype
3520 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3522 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3525 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3526 initialization code to keep similarity to xfns.c after changes
3529 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3531 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3532 (unwind_create_frame): New function (Bug#9943).
3533 (Fx_create_frame): Restructure code to be more similar to the one in
3534 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3535 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3536 Move terminal->reference_count++ just before making the frame official
3539 * nsterm.m (x_free_frame_resources): New function.
3540 (x_destroy_window): Move code to x_free_frame_resources.
3542 * xfns.c (unwind_create_frame): Fix comment.
3543 (Fx_create_frame, x_create_tip_frame):
3544 Move terminal->reference_count++ just before making the frame
3545 official. Move initialization of image_cache_refcount and
3546 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3548 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3550 Support MSVC build with newer versions of Visual Studio.
3551 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3552 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3555 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3556 which are not supported by MSVC.
3557 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3558 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3560 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3562 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3564 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3566 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3568 Support MSVC build with newer versions of Visual Studio.
3569 * w32.c: Don't include w32api.h for MSVC.
3570 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3572 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3573 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3574 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3575 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3577 (alloca) [_MSC_VER]: Define to _alloca.
3579 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3581 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3583 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3585 * xdisp.c (note_mouse_highlight): If either of
3586 previous/next-single-property-change returns nil, treat that as
3587 the beginning or the end of the buffer. (Bug#9955)
3589 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3591 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3592 label is not null (Bug#9951).
3593 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3596 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3598 * window.c (Fwindow_body_size): Mention in the doc string that the
3599 return value is in frame's canonical units. (Bug#9949)
3601 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3603 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3605 * w32fns.c (unwind_create_frame): If needed, free the glyph
3606 matrices of the partially constructed frame. (Bug#9943)
3607 * xfns.c (unwind_create_frame): Likewise.
3609 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3611 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3612 Don't stop backward scan on the continuation glyph, even though
3613 its CHARPOS is positive.
3614 (mouse_face_from_buffer_pos, note_mouse_highlight):
3615 Rename cover_string to disp_string.
3617 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3619 * window.c (temp_output_buffer_show): Don't use
3620 Vtemp_buffer_show_specifiers.
3621 (Vtemp_buffer_show_specifiers): Remove unused variable.
3623 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3625 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3626 past the beginning of the current glyph matrix.
3628 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3630 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3631 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3632 HAVE_GTK3 (Bug#9869).
3634 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3635 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3637 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3639 * xterm.c: Declare x_handle_net_wm_state to return int.
3640 (handle_one_xevent): Check if we are iconified but don't have
3641 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3642 (get_current_wm_state): Return non-zero if not hidden,
3643 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3644 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3645 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3646 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3648 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3650 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3651 so that this new function doesn't get optimized away by a
3652 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3654 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3656 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3658 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3660 Fix the `xbytecode' command.
3661 * .gdbinit (xprintbytestr): New command.
3662 (xwhichsymbols): Rename from `which'; all callers changed.
3663 (xbytecode): Print the byte-code string as well.
3665 2011-10-29 Kim Storm <storm@cua.dk>
3667 * alloc.c (which_symbols): New function.
3669 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3671 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3674 2011-10-29 Glenn Morris <rgm@gnu.org>
3676 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3677 Not clear what it was for, and it causes various bugs. (Bug#9839)
3679 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3681 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3682 possible random value that matches one of those tested as
3683 condition to clear the mouse face.
3685 2011-10-28 Chong Yidong <cyd@gnu.org>
3687 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3689 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3691 * window.c (make_window): Initialize phys_cursor_on_p.
3693 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3695 * lisp.h (struct Lisp_Symbol): Update comments.
3697 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3699 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3701 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3703 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3704 <oslsachem@gmail.com> for helping to debug this.
3706 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3707 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3708 (g_b_init_get_glyph_outline_w): New static variables.
3709 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3710 (GetGlyphOutlineW_Proc): New typedefs.
3711 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3712 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3714 (w32font_open_internal, compute_metrics):
3715 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3716 instead of calling the "wide" APIs directly.
3718 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3720 * w32.h (syms_of_w32font): Add prototype.
3722 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3724 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3725 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3726 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3727 (Fmove_to_window_line): Doc fix.
3729 2011-10-27 Chong Yidong <cyd@gnu.org>
3731 * process.c (make_process): Set gnutls_state to NULL.
3733 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3734 non-NULL, regardless of GNUTLS_INITSTAGE.
3735 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3736 an error. Set process slots as soon as we allocate them.
3738 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3740 2011-10-27 Chong Yidong <cyd@gnu.org>
3742 * gnutls.c (emacs_gnutls_deinit): New function.
3743 Deallocate credentials structures as well as calling gnutls_deinit.
3744 (Fgnutls_deinit, Fgnutls_boot): Use it.
3746 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3747 (deactivate_process): Call emacs_gnutls_deinit.
3749 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3751 * image.c (x_create_x_image_and_pixmap):
3752 * w32.c (sys_rename, w32_delayed_load):
3753 * w32font.c (fill_in_logfont):
3754 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3756 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3758 * w32fns.c (w32_default_color_map): New function,
3759 extracted from Fw32_default_color_map.
3760 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3762 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3764 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3766 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3768 * keyboard.c (test_undefined): New function (bug#9751).
3769 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3771 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3773 * sysdep.c (init_sys_modes): Fix the check for the controlling
3774 terminal (Bug#6649).
3776 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3778 * dispextern.h (struct bidi_it): New member next_en_type.
3780 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3781 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3782 current character, check also for next_en_type being WEAK_EN.
3783 (bidi_resolve_weak): Don't enter the expensive loop if the current
3784 position is before next_en_pos. Record the bidi type of the first
3785 non-ET, non-BN character we find, in addition to its position.
3786 (bidi_level_of_next_char): Invalidate next_en_type when
3787 next_en_pos is over-stepped.
3789 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3791 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3792 * editfns.c: Rewrite current-time-zone so that it invokes
3793 the equivalent of (format-time-string "%Z") to get the time zone name.
3794 This fixes a bug when the time zone name contains characters that
3795 need converting from the system time locale to Emacs internal format.
3796 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3797 that patch fixed format-time-string to do the conversion, but
3798 I forgot to fix current-time-zone.
3799 (format_time_string): New function, containing most of
3800 what Fformat_time_string used to contain.
3801 (Fformat_time_string): Rewrite in terms of format_time_string.
3802 This doesn't change this function's behavior.
3803 (current-time-zone): Rewrite to use format_time_string.
3804 This fixes the bug reported by Michael Schierl in
3805 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3806 Jason Rumney's 2007-06-07 change worked around this bug, but
3808 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3810 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3812 * xdisp.c (start_display): If the character at POS is displayed
3813 via a display vector, reset IT->current.dpvec_index to zero.
3814 (try_window_reusing_current_matrix): If a line ends in a display
3815 vector or the next line starts in a display vector, continue
3816 redrawing the window even though the character position of
3817 start_row was reached.
3820 2011-10-18 Chong Yidong <cyd@gnu.org>
3822 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3823 with nobreak-char-display too.
3825 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3827 Fix part 3 of bug#9771.
3828 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3829 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3830 non-neutral characters if the current character is a paragraph
3831 separator (a.k.a. Newline). This avoids running the same
3832 expensive loop twice, once when we consume the preceding newline
3833 and the other time when the line actually needs to be displayed.
3834 Avoid the loop when we see neutrals on the base embedding level
3835 following a character whose directionality is the same as the
3836 paragraph's. This avoids running the expensive loop when a line
3837 ends in a long sequence of neutrals, like control characters.
3838 Add assertion against STRONG_AL type. Slightly rearrange code
3839 that determines the type of a neutral given the first non-neutral
3841 (bidi_level_of_next_char): Set next_en_pos to zero when
3842 invalidating its info.
3844 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3846 * xdisp.c (push_display_prop): Determine whether to record string
3847 or buffer position by IT->string, not by IT->method. Allow
3848 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3849 (move_it_vertically_backward): Don't look for character position
3850 immediately after the newline when in a continuation line.
3853 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3855 * window.c (coordinates_in_window): Rewrite and delabelize
3856 vertical border check. (Bug#5357) (Bug#9618)
3858 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3860 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3861 errors in XSetWindowBorder (bug#9310).
3863 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3865 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3866 avoid crash when xmalloc overrun checking is enabled.
3868 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3870 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3871 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3872 cursor motion with <left> and <right> arrow keys.
3874 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3875 some callers set that themselves.
3877 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3879 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3880 display string and the previous row comes from the same string and
3881 is empty. (Bug#9739) (Bug#9738)
3883 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3885 * doc.c (get_doc_string): Encode file name (bug#9735).
3887 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3889 * bidi.c (bidi_level_of_next_char):
3890 * xdisp.c (get_visually_first_element): Remove old incorrect
3891 comments regarding the Unicode Line Separator character.
3893 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3895 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3897 * alloc.c (Fgc_status): Do not access beyond zombies array
3898 boundary if nzombies > MAX_ZOMBIES.
3899 * alloc.c (dump_zombies): Add missing format specifier.
3901 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3903 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3904 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3906 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3907 Some packages use them to denote characters with modifiers.
3909 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3911 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3912 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3913 matching a pp-number. Rename parameter var to var1.
3915 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3917 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3919 2011-10-08 Glenn Morris <rgm@gnu.org>
3921 * callint.c (Fcall_interactively): Give a more explicit error for the
3922 'c' case with a non-character input. (Bug#8479)
3924 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3926 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3928 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3929 lines that are hscrolled on the left.
3931 * dispnew.c (buffer_posn_from_coords): Account for a possible
3932 presence of header-line. (Bug#4426)
3934 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3936 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3937 Don't advertise functionality which we discourage or doesn't work.
3939 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3941 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3942 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3943 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3944 this makes Emacs dump core during garbage collection on rare
3945 occasions. sizeof is obviously inferior to offsetof here, so
3946 stick with offsetof.
3947 (GC_POINTER_ALIGNMENT): New macro.
3948 (mark_memory): Omit 3rd (offset) arg; caller changed.
3949 Don't assume EMACS_INT alignment is the same as pointer alignment.
3951 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3953 * keyboard.c (read_key_sequence_remapped): New var.
3954 (read_key_sequence): Compute remapping in the right buffer.
3955 (command_loop_1): Use read_key_sequence's remapping directly.
3957 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3959 * dired.c (file_name_completion): Don't expand file name.
3960 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3961 before checking file name handler.
3963 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3964 they've been requested explicitly (bug#9591).
3966 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3968 * keymap.c (Fsingle_key_description): Use make_specified_string
3969 instead of build_string to build string from push_key_description.
3972 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3974 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3975 This fixes a Y2038 bug on 64-bit hosts.
3976 * buffer.c (reset_buffer):
3977 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3978 (Fclear_buffer_auto_save_failure):
3979 Use 0, not -1, to represent an unset failure time, since time_t
3980 might not be signed.
3982 Remove dependency on glibc malloc internals.
3983 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3984 Move back here from lisp.h, but with their new implementations.
3985 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3986 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3987 * charset.c (charset_table_init): New static var.
3988 (syms_of_charset): Use it instead of xmalloc. This removes a
3989 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3990 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3991 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3992 Move back to alloc.c.
3993 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3994 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3996 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3998 * nsterm.m (windowDidResize): Call x_set_window_size only when
3999 ns_in_resize is true. Otherwise set pixelwidth/height and
4000 call change_frame_size (Bug#9628).
4002 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4004 Port --enable-checking=all to Fedora 14 x86-64.
4005 * charset.c (syms_of_charset): Also account for glibc malloc's
4006 internal overhead when calculating the initial malloc maximum.
4008 Port --enable-checking=all to Fedora 14 x86.
4009 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4011 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4012 (overrun_check_realloc, overrun_check_free):
4013 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4014 That way, xmalloc returns a properly-aligned pointer even if
4015 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4016 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4017 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4018 into account when calculating the initial malloc maximum.
4019 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4020 Move here from alloc.c, so that charset.c can use it too.
4021 Properly align; the old code wasn't right for common 32-bit hosts
4022 when configured with --enable-checking=all.
4023 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4024 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4026 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4028 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4031 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4033 * xdisp.c (compute_display_string_end): If there's no display
4034 string at CHARPOS, return -1.
4036 * bidi.c (bidi_fetch_char): When compute_display_string_end
4037 returns a negative value, treat the character as a normal
4038 character not covered by a display string. (Bug#9624)
4040 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4042 * lread.c (Fread_from_string): Fix typo in docstring.
4044 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4046 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4047 newline, reseat the iterator instead of bidi-iterating there one
4048 character at a time. (Bug#9610)
4049 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4050 TO_CHARPOS if the bidi iterator is at base embedding level.
4052 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4054 * lread.c (readevalloop): Use correct code for NBSP.
4055 (read1): Likewise. (Bug#9608)
4057 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4059 * dbusbind.c (Fdbus_register_signal): When service is not
4060 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4062 2011-09-25 Glenn Morris <rgm@gnu.org>
4064 * buffer.c (truncate-lines): Doc fix.
4066 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4068 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4069 (Fset_window_next_buffers): Doc fix.
4071 2011-09-24 Glenn Morris <rgm@gnu.org>
4073 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4075 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4077 Fix minor problems found by static checking.
4078 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4079 * indent.c (Fvertical_motion): Fix == vs = typo.
4081 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4083 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4084 Default value is now t. Doc fix.
4086 * indent.c (Fvertical_motion): Compute and apply the overshoot
4087 logic when moving up, not only when moving down. Fix the
4088 confusing name and values of the it_overshoot_expected variable;
4089 logic changes accordingly. (Bug#9254) (Bug#9549)
4091 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4092 CHARPOS is covered by a display string which includes newlines.
4093 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4094 is covered by a display string with embedded newlines.
4096 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4098 * dbusbind.c (Fdbus_register_signal): Add match rule to
4099 Vdbus_registered_objects_table. (Bug#9581)
4100 (Fdbus_register_method, Vdbus_registered_objects_table):
4103 2011-09-24 Jim Meyering <meyering@redhat.com>
4105 do not ignore write error for any output size
4106 The previous change was incomplete.
4107 While it makes emacs --batch detect the vast majority of stdout
4108 write failures, errors were still ignored whenever the output size is
4109 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4110 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4111 && echo FAIL: ignored write error
4112 FAIL: ignored write error
4113 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4114 && echo FAIL: ignored write error
4115 FAIL: ignored write error
4116 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4118 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4120 * emacs.c (Fkill_emacs): In noninteractive mode exit
4121 non-successfully if a write error occurred on stdout. (Bug#9574)
4123 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4125 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4128 * dispextern.h (struct it): Update the comment documenting what
4131 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4133 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4134 a display string, extend search for cursor position to end of row.
4135 (find_row_edges): If the row ends in a newline from a display
4136 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4137 Handle the case of a display string with multiple newlines.
4138 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4139 non-empty line. Fixes confusing cursor motion with arrow keys at
4140 the beginning of a line that starts with whitespace.
4142 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4144 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4147 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4149 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4152 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4154 * xdisp.c (display_line): Record maximum and minimum buffer
4155 positions even if no glyphs were produced (e.g., by a zero-width
4156 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4157 buffer positions that will be removed from the glyph row because
4159 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4160 column is beyond frame width: don't subtract 1 "pixel" when
4161 computing width of the stretch.
4162 (reseat_at_next_visible_line_start): Undo the change made on
4163 2011-09-17 that saved paragraph information and restored it after
4164 the call to `reseat'. (Bug#9545)
4166 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4168 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4169 and turn window cursor on if cleared (Bug#9415).
4171 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4173 * search.c (boyer_moore): Take unibyte characters from pattern
4174 literally. (Bug#9458)
4176 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4178 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4180 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4182 Fix minor problem found by static checking.
4183 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4184 initialized, to pacify gcc -Wuninitialized.
4186 * fileio.c: Report proper errno when syscall falls.
4187 (Finsert_file_contents): Save and restore errno,
4188 so that report_file_error outputs the correct diagnostic.
4189 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4191 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4193 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4195 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4197 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4198 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4200 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4202 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4203 about the current paragraph and restore it after the call to reseat.
4205 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4206 (bidi_find_paragraph_start): Search back for paragraph beginning
4207 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4208 (bidi_move_to_visually_next): Only trigger paragraph-related
4209 computations when the last character is a newline or at EOB, not
4210 just any NEUTRAL_B. (Bug#9470)
4212 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4213 truncated lines if point is covered by a display string. (Bug#9524)
4215 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4217 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4218 (cons_to_x_long): New function.
4219 (lisp_data_to_selection_data): Use it. Correct the test for
4220 short-versus-long data; it was negated. Break out of vector
4221 loop, for efficiency, when a long datum is discovered.
4223 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4225 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4227 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4229 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4230 GCC PR/17406) by declaring this function with external scope.
4232 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4234 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4235 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4237 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4239 * editfns.c (Fformat): Correctly handle text properties on "%%".
4241 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4243 * xterm.c (x_draw_composite_glyph_string_foreground):
4244 * w32term.c (x_draw_composite_glyph_string_foreground):
4245 * term.c (encode_terminal_code):
4246 * composite.c (composition_update_it, get_composition_id):
4247 * xdisp.c (get_next_display_element)
4248 (fill_composite_glyph_string): Add comments about special meaning
4249 of TAB characters in a composition.
4251 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4253 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4254 This occurs when processing a multibyte format.
4255 Problem reported by Wolfgang Jenker.
4257 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4259 * xdisp.c (try_cursor_movement): Only check for exact match if
4260 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4262 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4264 Remove unused external symbols.
4265 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4266 * xdisp.c (calc_pixel_width_or_height): Now static.
4267 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4268 * indent.c (check_display_width):
4269 * w32term.c: Fix comment to match code.
4270 * xterm.c, xterm.h (x_catching_errors): Remove.
4272 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4274 * xselect.c: Use signed conversions more consistently (Bug#9498).
4275 (selection_data_to_lisp_data): Assume incoming selection data are
4276 signed integers, not unsigned. This is to be consistent with
4277 outgoing selection data, which was modified to use signed integers
4278 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4279 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4280 expects long, not unsigned long.
4282 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4284 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4285 computation of loop end. Reported by Johan Bockgård
4288 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4290 * frame.c (Fother_visible_frames_p): Function deleted.
4292 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4294 * indent.c (compute_motion): Process display vector front to back
4295 rather than the other way around. (Bug#2496)
4297 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4299 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4301 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4303 * minibuf.c (Fread_from_minibuffer): Doc fix.
4305 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4307 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4308 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4310 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4312 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4313 value for non-existent files.
4315 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4317 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4318 set its "size" to -1. This will set the modtime_size field of
4319 the corresponding buffer to -1, which is what
4320 verify-visited-file-modtime expects for files that do not exist.
4323 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4325 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4327 * lisp.h: ... from here. push_key_description is no longer
4328 defined in keyboard.c, so its declaration should not be in
4329 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4330 logically belongs with push_key_description.
4332 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4334 * buffer.h: Include <sys/types.h> instead of <time.h>.
4335 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4336 Problem reported by Herbert J. Skuhra.
4338 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4340 * xml.c (parse_region): Make the parsing work for
4341 non-comment-starting XML files again (bug#9144).
4343 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4345 * image.c (gif_load): Fix calculation of bottom and right corner.
4348 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4350 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4351 redisplay in small windows.
4353 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4355 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4357 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4359 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4360 Operate on live windows only.
4362 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4364 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4366 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4368 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4369 only under bidi iteration.
4371 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4373 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4375 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4377 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4378 Without this fix, the command to link temacs failed due to an
4379 undefined symbol __builtin_isnan. This is because
4380 /usr/include/iso/math_c99.h #defines isnan(x) to
4381 __builtin_isnan(x), but the bundled gcc, which identifies itself
4382 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4384 * floatfns.c (isnan): #undef, and then #define to a clone of
4386 (Fisnan): Always define, since it's always available now.
4387 (syms_of_floatfns): Always define isnan at the Lisp level.
4389 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4391 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4393 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4395 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4396 The previous code assumed that file offsets (off_t values) fit in
4397 EMACS_INT variables, which is not true on typical 32-bit hosts.
4398 The code messed up by falsely reporting buffer overflow in cases
4399 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4400 when "big" contains more than 2**29 bytes, even though this
4401 inserts just one byte and does not overflow the buffer.
4402 (Finsert_file_contents): Store file offsets as off_t
4403 values, not as EMACS_INT values. Check for overflow when
4404 converting between EMACS_INT and off_t. When checking for
4405 buffer overflow or for overlap, take the offsets into account.
4406 Don't use EMACS_INT for small values where int suffices.
4407 When checking for overlap, fix a typo: ZV was used where
4408 ZV_BYTE was intended.
4409 (Fwrite_region): Don't assume off_t fits into 'long'.
4410 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4412 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4414 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4416 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4418 sprintf-related integer and memory overflow issues (Bug#9412).
4420 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4421 (esprintf, exprintf, evxprintf): New functions.
4422 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4423 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4424 (modify_event_symbol): Do not assume that the length of
4425 name_alist_or_stem is safe to alloca and fits in int.
4426 (Fexecute_extended_command): Likewise for function name and binding.
4427 (Frecursion_depth): Wrap around reliably on integer overflow.
4428 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4429 since some callers pass EMACS_INT values.
4430 (Fsingle_key_description): Don't crash if symbol name contains more
4431 than MAX_ALLOCA bytes.
4432 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4433 (get_minibuffer): Arg is now EMACS_INT, not int.
4434 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4435 (esprintf, exprintf, evxprintf): New decls.
4436 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4438 * dbusbind.c (signature_cat): New function.
4439 (xd_signature, Fdbus_register_signal):
4440 Do not overrun buffer; instead, report string overflow.
4442 * dispnew.c (add_window_display_history): Don't overrun buffer.
4443 Truncate instead; this is OK since it's just a log.
4445 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4446 even if the time zone offset is outlandishly large.
4447 Don't mishandle offset == INT_MIN.
4449 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4450 when creating daemon; the previous buffer-overflow check was incorrect.
4452 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4453 which has the guts of the old verror function.
4455 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4456 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4458 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4459 (font_unparse_xlfd): Don't blindly alloca long strings.
4460 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4461 fits in int, when using sprintf. Use single snprintf to count
4462 length of string rather than counting it via multiple sprintfs;
4463 that's simpler and more reliable.
4464 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4465 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4466 sprintf, in case result does not fit in int.
4468 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4469 (fontset_from_font): Print it.
4471 * frame.c (tty_frame_count): Now printmax_t, not int.
4472 (make_terminal_frame, set_term_frame_name): Print it.
4473 (x_report_frame_params): In X, window IDs are unsigned long,
4474 not signed long, so print them as unsigned.
4475 (validate_x_resource_name): Check for implausibly long names,
4476 and don't assume name length fits in 'int'.
4477 (x_get_resource_string): Don't blindly alloca invocation name;
4478 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4481 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4482 (xg_check_special_colors, xg_set_geometry):
4483 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4485 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4486 Use esprintf, not sprintf, in case result does not fit in int.
4488 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4489 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4490 it as a large positive number.
4491 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4492 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4494 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4495 in case result does not fit in int.
4497 * print.c (float_to_string): Detect width overflow more reliably.
4498 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4499 buffer overrun. Don't assume list length fits in 'int'. Treat
4500 print length of 0 as 0, not as infinity; to be consistent with other
4501 uses of print length in this function. Don't overflow print length
4502 index. Don't assume hash table size fits in 'long', or that
4503 vectorlike size fits in 'unsigned long'.
4505 * process.c (make_process): Use printmax_t, not int, to format
4506 process-name gensyms.
4508 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4510 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4511 to avoid potential buffer overrun.
4513 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4514 if X resource line is longer than 512 bytes.
4516 * xfns.c (x_window): Make sprintf buffer a bit bigger
4517 to avoid potential buffer overrun.
4519 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4521 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4523 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4525 Integer overflow fixes for scrolling, etc.
4526 Without these, Emacs silently mishandles large integers sometimes.
4527 For example, "C-u 4294967297 M-x recenter" was treated as if
4528 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4530 * xdisp.c (try_window_id): Check Emacs fixnum range before
4531 converting to 'int'.
4533 * window.c (window_scroll_line_based, Frecenter):
4534 Check that an Emacs fixnum is in range before assigning it to 'int'.
4535 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4536 values converted from Emacs fixnums.
4537 (Frecenter): Don't wrap around a line count if it is out of 'int'
4538 range; instead, treat it as an extreme value.
4539 (Fset_window_configuration, compare_window_configurations):
4540 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4542 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4543 that can exceed INT_MAX. Check that EMACS_INT value is in range
4544 before assigning it to the (possibly-narrower) index.
4545 (match_limit): Don't assume that a fixnum can fit in 'int'.
4547 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4550 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4551 (Fvertical_motion): Don't wrap around LINES values that don't fit
4552 in 'int'. Instead, treat them as extreme values. This is good
4553 enough for windows, which can't have more than INT_MAX lines anyway.
4555 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4557 * Require libxml/parser.h to avoid compilation warning.
4559 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4561 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4562 since this reportedly can destroy thread storage.
4564 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4566 * syntax.c (find_defun_start): Update all cache variables if
4567 exiting early (Bug#9401).
4569 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4571 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4573 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4574 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4575 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4577 * term.c (tty_append_glyph): New function.
4578 (produce_stretch_glyph): Static function and its prototype deleted.
4580 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4583 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4585 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4586 when checking :margin (Bug#9390).
4587 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4588 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4589 so that the name doesn't mislead. All uses changed.
4591 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4593 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4596 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4598 * xdisp.c (move_it_to): Don't bail out early when reaching
4599 position beyond to_charpos, if we are scanning backwards.
4600 (move_it_vertically_backward): When DY == 0, make sure we get to
4601 the first character in the line after the newline.
4603 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4605 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4606 (ccl_driver): Do not generate an out-of-range pointer.
4607 (Fccl_execute_on_string): Remove unnecessary check for
4608 integer overflow, noted by Stefan Monnier in
4609 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4610 Remove a FIXME that didn't need fixing.
4611 Simplify the newly-introduced buffer reallocation code.
4613 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4615 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4617 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4619 Integer and memory overflow issues (Bug#9196).
4621 * doc.c (get_doc_string): Rework so that
4622 get_doc_string_buffer_size is the actual buffer size, rather than
4623 being 1 less than the actual buffer size; this makes xpalloc more
4626 * image.c (x_allocate_bitmap_record, cache_image):
4627 * xselect.c (Fx_register_dnd_atom):
4628 Simplify previous changes by using xpalloc.
4630 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4631 since either will do and ptrdiff_t is convenient with xpalloc.
4633 * charset.c (charset_table_size)
4634 (struct charset_sort_data.priority): Now ptrdiff_t.
4635 (charset_compare): Don't overflow if priorities differ greatly.
4636 (Fsort_charsets): Don't assume list length fits in int.
4637 Check for size-calculation overflow when allocating sort data.
4638 (syms_of_charset): Allocate an initial charset table that is
4639 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4641 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4643 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4644 The actual value is always <= INT_MAX, and leaving it unsigned made
4645 overflow checking harder.
4647 * dispextern.h (struct glyph_matrix.rows_allocated)
4648 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4649 with xpalloc. The values are still always <= INT_MAX.
4651 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4653 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4654 (SAFE_NALLOCA): New macro.
4656 * region-cache.c (struct boundary.pos, find_cache_boundary)
4657 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4658 (set_cache_region, invalidate_region_cache)
4659 (revalidate_region_cache, know_region_cache, region_cache_forward)
4660 (region_cache_backward, pp_cache):
4661 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4662 so that ptrdiff_t * can be passed to xpalloc.
4663 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4664 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4665 (pp_cache): Don't assume cache_len fits in int.
4666 * region-cache.h: Adjust extern decls to match.
4668 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4669 EMACS_INT, since either will do, for xpalloc.
4671 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4672 (xnmalloc, xnrealloc, xpalloc): New functions.
4674 * bidi.c (bidi_shelve_header_size): New constant.
4675 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4676 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4678 * bidi.c (bidi_cache_shrink):
4679 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4681 Don't update size of array until after memory allocation succeeds,
4682 because xmalloc/xrealloc may not return.
4683 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4684 now that we have proper integer overflow checking.
4685 (record_overlay_string, overlay_strings): Catch overflows when
4686 calculating size of overlay_str_buf.
4688 * callproc.c (Fcall_process): Check for size overflow when
4689 calculating size of args2.
4690 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4691 Normally we prefer signed values, but sticking with ptrdiff_t would
4692 require adding more-complicated checks.
4694 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4695 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4696 Redo buffer-overflow calculations to avoid integer overflow.
4697 Add a FIXME comment where memory seems to be over-allocated.
4699 * character.c (Fstring): Check for size-calculation overflow.
4701 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4702 unnecessary integer overflow. Check for size overflow.
4703 (encode_coding_object): Don't update size until xmalloc succeeds.
4705 * composite.c (get_composition_id): Check for overflow in glyph
4706 length calculations.
4708 Integer and memory overflow fixes for display code.
4709 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4710 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4711 (scrolling_window): Check for overflow in size calculations.
4712 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4713 Don't assume glyph table len fits in int.
4714 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4715 (row_table_size): Now ptrdiff_t, not int.
4716 (scrolling_window): Avoid overflow in size calculations.
4717 Don't update size until allocation succeeds.
4718 * fns.c (concat): Check for overflow in size calculations.
4719 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4720 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4721 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4723 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4724 (get_doc_string): Check for size calculation overflow.
4725 Don't update size until allocation succeeds.
4726 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4727 EMACS_INT, where ptrdiff_t will do.
4728 (Fsubstitute_command_keys): Check for string overflow.
4730 * editfns.c (set_time_zone_rule): Don't assume environment length
4732 (message_length): Now ptrdiff_t, not int.
4733 (Fmessage_box): Don't update size until allocation succeeds.
4734 Don't assume message length fits in int.
4735 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4737 * emacs.c (main): Do not reallocate argv, since there is a null at
4738 the end that can be overwritten, and this way there's no need to
4739 worry about size-calculation overflow.
4740 (sort_args): Check for size-calculation overflow.
4742 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4744 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4746 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4747 (x_set_scroll_bar_width, x_figure_window_size):
4748 Check for integer overflow.
4749 (x_set_alpha): Do not assume XINT fits in int.
4751 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4752 This is for the members text_lines, text_cols, total_lines, total_cols,
4753 where the system imposes an 'int' limit.
4755 * fringe.c (Fdefine_fringe_bitmap):
4756 Don't update size until alloc works.
4758 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4759 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4761 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4762 Check for size-calculation overflow.
4763 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4764 do, as we prefer signed integers.
4765 (id_to_widget.max_size, id_to_widget.used)
4766 (xg_store_widget_in_map, xg_remove_widget_from_map)
4767 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4768 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4769 Use and return ptrdiff_t, not int.
4770 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4771 * gtkutil.h: Change prototypes to match the above.
4773 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4774 are duplicate now that they've been promoted to lisp.h.
4775 (x_allocate_bitmap_record, x_alloc_image_color)
4776 (make_image_cache, cache_image, xpm_load):
4777 Don't update size until alloc is done.
4778 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4780 Check for size calculation overflow.
4781 (ct_colors_allocated_max): New constant.
4782 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4785 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4786 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4787 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4788 Use ptrdiff_t, not int, to count maps.
4789 (read_char_minibuf_menu_prompt): Check for overflow in size
4790 calculations. Don't update size until allocation succeeds.
4791 Redo calculations to avoid overflow.
4792 * keyboard.h: Change prototypes to match the above.
4794 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4796 (current_minor_maps): Check for size calculation overflow.
4797 * keymap.h: Change prototypes to match the above.
4799 * lread.c (read1, init_obarray): Don't update size until alloc done.
4801 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4802 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4804 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4805 Now ptrdiff_t, not int.
4806 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4807 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4809 * process.c (Fnetwork_interface_list): Check for overflow
4810 in size calculation.
4812 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4814 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4815 overflow. Don't bother calling xmalloc when xrealloc will do.
4817 * search.c (Freplace_match): Check for size calculation overflow.
4818 (Fset_match_data): Don't assume list lengths fit in 'int'.
4820 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4821 for command line length. Do not attempt to address one before the
4822 beginning of an array, as that's not portable.
4824 * term.c (max_frame_lines): Remove; unused.
4825 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4827 (encode_terminal_code, calculate_costs): Check for size
4828 calculation overflow.
4829 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4830 table lengths and related sizes. Don't update size until alloc
4831 done. Redo calculations to avoid overflow.
4832 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4834 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4835 subtracting pointers.
4836 (gobble_line): Check for overflow more carefully. Don't update size
4839 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4840 Don't update size until alloc done.
4841 Redo size calculations to avoid overflow.
4842 Check for size calculation overflow.
4843 (main) [DEBUG]: Fix typo in invoking tparam1.
4845 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4846 Use ptrdiff_t, not int, for sizes.
4847 (store_mode_line_noprop_char): Don't update size until alloc done.
4849 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4850 Use ptrdiff_t, not int, for sizes.
4851 (Finternal_make_lisp_face, cache_face):
4852 Check for size calculation overflow.
4853 (cache_face): Treat size calculation overflows as if they were
4854 memory exhaustion (the usual treatment), rather than aborting.
4856 * xfns.c (x_encode_text, x_set_name_internal)
4857 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4858 sizes, since they can exceed INT_MAX in size. Check for size
4859 calculation overflow.
4861 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4862 (xg_select): Check for size calculation overflow.
4863 Don't update size until alloc done.
4865 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4866 as sprintf is limited to int lengths.
4868 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4869 (X_LONG_MIN): New macros.
4870 Use them to make the following changes clearer.
4871 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4872 This change doesn't affect the value now, but it may help remind
4873 future maintainers not to raise the value too much later.
4874 (SELECTION_QUANTUM): Remove, replacing with ...
4875 (selection_quantum): ... new function, which avoids overflow.
4877 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4878 assumption that selection length fits in 'int'.
4879 (x_reply_selection_request, x_handle_selection_request)
4880 (x_get_window_property, receive_incremental_selection)
4881 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4882 (lisp_data_to_selection_data, clean_local_selection_data):
4883 Use ptrdiff_t, not int, to record length of selection.
4884 (x_reply_selection_request, x_get_window_property)
4885 (receive_incremental_selection, x_property_data_to_lisp):
4886 Redo calculations to avoid overflow.
4887 (x_reply_selection_request): When sending hint, ceiling it at
4888 X_LONG_MAX rather than relying on wraparound overflow to send
4890 (x_get_window_property, receive_incremental_selection)
4891 (lisp_data_to_selection_data, x_property_data_to_lisp):
4892 Check for size-calculation overflow.
4893 (x_get_window_property, receive_incremental_selection)
4894 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4895 Don't store size until memory allocation succeeds.
4896 (x_get_window_property): Plug memory leak on memory exhaustion.
4897 Don't double-block input; malloc is safe here. Don't assume 2**34
4898 - 4 fits in unsigned long. Add an xassert to check
4899 XGetWindowProperty overflow. Be more careful about overflow
4900 calculations, and distinguish size from memory overflow better.
4901 (receive_incremental_selection): When tracing, don't assume
4902 unsigned int is less than INT_MAX.
4903 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4904 harmful) conversions of unsigned short to int.
4905 (lisp_data_to_selection_data): Don't assume that integers
4906 in the range -65535 through -1 fit in an X unsigned short.
4907 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4908 result parameters unless successful. Rely on cons_to_unsigned
4909 to report problems with elements; the old code wasn't right anyway.
4910 (x_check_property_data): Check for int overflow; we cannot use
4911 a wider type due to X limits.
4912 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4914 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4916 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4917 (x_term_init): Check for size calculation overflow.
4918 (x_color_cells): Don't store size until memory allocation succeeds.
4919 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4920 Don't assume alloca size is less than MAX_ALLOCA.
4921 (x_term_init): Don't assume length fits in int (sprintf is limited
4924 Use ptrdiff_t for composition IDs.
4925 * character.c (lisp_string_width):
4926 * composite.c (composition_table_size, n_compositions)
4927 (get_composition_id, composition_gstring_from_id):
4928 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4929 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4930 * window.c (Frecenter):
4931 Use ptrdiff_t, not int, for composition IDs.
4932 * composite.c (get_composition_id): Check for integer overflow.
4933 * composite.h: Adjust prototypes to match the above changes.
4935 Use ptrdiff_t for hash table indexes.
4936 * category.c (hash_get_category_set):
4937 * ccl.c (ccl_driver):
4938 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4939 * coding.c (coding_system_charset_list, detect_coding_system):
4940 * coding.h (struct coding_system.id):
4941 * composite.c (get_composition_id, gstring_lookup_cache):
4942 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4943 * image.c (xpm_get_color_table_h):
4944 * lisp.h (hash_lookup, hash_put):
4945 * minibuf.c (Ftest_completion):
4946 Use ptrdiff_t for hash table indexes, not int (which is too
4947 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4948 32-bit --with-wide-int hosts).
4950 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4951 Add a FIXME comment about memory leaks.
4952 (syms_of_charset): Don't assume xmalloc returns.
4954 Don't assume that stated character widths fit in int.
4955 * character.c (Fchar_width, c_string_width, lisp_string_width):
4956 * character.h (CHAR_WIDTH):
4957 * indent.c (MULTIBYTE_BYTES_WIDTH):
4958 Use sanitize_char_width to avoid undefined and/or bad behavior
4959 with outlandish widths.
4960 * character.h (sanitize_tab_width): Rename from sanitize_width,
4961 now that we have two such functions. All uses changed.
4962 (sanitize_char_width): New inline function.
4964 Don't assume that tab-width fits in int.
4965 * character.h (sanitize_width): New inline function.
4966 (SANE_TAB_WIDTH): New macro.
4967 (ASCII_CHAR_WIDTH): Use it.
4968 * indent.c (sane_tab_width): Remove. All uses replaced by
4969 SANE_TAB_WIDTH (current_buffer).
4970 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4972 * fileio.c: Integer overflow issues with file modes.
4973 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4975 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4976 Remove unreachable code.
4977 (read_hex, load_charset_map_from_file): Check for integer overflow.
4979 * xterm.c: Don't go over XClientMessageEvent limit.
4980 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4981 (x_send_scroll_bar_event): Likewise. Check that the size does not
4982 exceed limits imposed by XClientMessageEvent, as well as the usual
4983 ptrdiff_t and size_t limits.
4985 * keyboard.c: Overflow, signedness and related fixes.
4986 (make_lispy_movement): Use same integer type in forward decl
4987 that is used in the definition.
4988 (read_key_sequence, keyremap_step):
4989 Change bufsize argument back to int, undoing my 2011-03-30 change.
4990 We prefer signed types, and int is wide enough here.
4991 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4992 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4993 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4994 length, not size_t. Use ptrdiff_t for index, not int.
4995 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4996 possibility of integer overflow.
4998 Overflow, signedness and related fixes for images.
5000 * dispextern.h (struct it.stack[0].u.image.image_id)
5001 (struct_it.image_id, struct image.id, struct image_cache.size)
5002 (struct image_cache.used, struct image_cache.ref_count):
5003 * gtkutil.c (update_frame_tool_bar):
5004 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5005 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5006 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5007 * nsmenu.m (update_frame_tool_bar):
5008 * xdisp.c (calc_pixel_width_or_height):
5009 * xfns.c (image_cache_refcount):
5010 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5011 on typical 64-bit hosts.
5013 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5014 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5015 Omit unnecessary casts to int.
5016 (parse_image_spec): Check that integers fall into 'int' range
5017 when the callers expect that.
5018 (image_ascent): Redo ascent calculation to avoid int overflow.
5019 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5020 (lookup_image): Remove unnecessary tests.
5021 (xbm_image_p): Locals are now of int, not EMACS_INT,
5022 since parse_image_check makes sure they fit into int.
5023 (png_load, gif_load, svg_load_image):
5024 Prefer int to unsigned where either will do.
5025 (tiff_handler): New function, combining the cores of the
5026 old tiff_error_handler and tiff_warning_handler.
5027 This function is rewritten to use vsnprintf and thereby avoid
5028 stack buffer overflows. It uses only the features of vsnprintf
5029 that are common to both POSIX and native Microsoft.
5030 (tiff_error_handler, tiff_warning_handler): Use it.
5031 (tiff_load, gif_load, imagemagick_load_image):
5032 Don't assume :index value fits in 'int'.
5033 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5034 (imagemagick_load_image): Check that crop parameters fit into
5035 the integer types that MagickCropImage accepts. Don't assume
5036 Vimagemagick_render_type has a nonnegative value. Don't assume
5037 size_t fits in 'long'.
5038 (gs_load): Use printmax_t to print the widest integers possible.
5039 Check for integer overflow when computing image height and width.
5041 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5043 * xdisp.c (redisplay_window): Don't force window start if point
5044 will be invisible in the resulting window. (Bug#9324)
5046 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5048 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5049 the display spec is of the form `(space ...)'.
5050 (handle_display_spec): Return the value returned by
5051 handle_single_display_spec, not just 1 or zero.
5052 (handle_single_display_spec): If the display spec is of the form
5053 `(space ...)', and specifies display in the text area, return 2
5055 (try_cursor_movement): Check for the need to scroll more
5056 accurately, and prefer exact match for point under bidi.
5057 Don't advance `row' beyond the last row of the window.
5059 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5060 into disp_prop; all users changed.
5062 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5063 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5064 for the text covered by the display property.
5066 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5068 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5069 Change return value to nil.
5070 (Frecord_buffer): Delete unused function.
5072 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5074 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5075 buffers, return left-to-right.
5076 (set_cursor_from_row): Consider candidate row a win if its glyph
5077 represents a newline and point is on that newline. Fixes cursor
5078 positioning on the newline at EOL of R2L text within L2R
5079 paragraph, and vice versa.
5080 (try_cursor_movement): Check continued rows, in addition to
5081 continuation rows. Fixes unwarranted scroll when point enters a
5082 continued line of R2L text within an L2R paragraph, or vice versa.
5083 (cursor_row_p): Consider the case of point being equal to
5084 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5085 from the end of a short line to the beginning of a continued line
5086 of R2L text within L2R paragraph.
5087 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5088 composed characters.
5090 * bidi.c (bidi_check_type): Use xassert.
5091 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5094 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5096 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5099 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5101 * nsfont.m (ns_otf_to_script): Fix typo.
5103 2011-08-22 Kenichi Handa <handa@m17n.org>
5105 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5106 extra slot even if the purpose is char-code-property-table.
5108 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5110 * xdisp.c (redisplay_window): When computing centering_position,
5111 account for the height of the header line. (Bug#8874)
5113 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5114 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5115 candidate is selected by the mouse, and that candidate has a
5116 composed character under the mouse.
5118 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5119 coordinates reported by pos-visible-in-window-p for a composed
5120 character in column zero.
5122 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5124 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5126 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5128 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5129 consider it a hit if to_charpos is anywhere in the range of the
5130 composed buffer positions.
5132 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5134 * image.c (gif_load): Don't assume that each subimage has the same
5135 dimensions as the base image. Handle disposal method that is
5136 "undefined" by the gif spec (Bug#9335).
5138 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5140 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5141 (Fcondition_case): Document `debug' symbol in error handler.
5143 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5145 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5146 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5147 from an Org mode buffer to a Speedbar frame.
5149 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5150 a composition, take its buffer position from IT->cmp_it.charpos.
5151 Fixes cursor positioning at the beginning of a line that begins
5152 with a composed character.
5154 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5156 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5157 character bidirectional type, use STRONG_L instead. Fixes crashes
5158 in a buffer produced by `describe-categories'.
5160 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5161 members before the level stack, so they would be saved and
5162 restored when copying iterator state. Fixes incorrect reordering
5163 around TABs covered by display properties.
5165 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5167 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5169 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5171 * eval.c (internal_condition_case, internal_condition_case_1)
5172 (internal_condition_case_2, internal_condition_case_n):
5173 Remove unnecessary aborts (Bug#9081).
5175 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5177 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5178 has no `load' handler, try opening the file locally. (Bug#9311)
5180 2011-08-16 Ken Brown <kbrown@cornell.edu>
5182 * gmalloc.c: Expand comment.
5184 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5186 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5187 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5189 2011-08-16 Ken Brown <kbrown@cornell.edu>
5191 Fix memory allocation problems in Cygwin build (Bug#9273).
5193 * unexcw.c ( __malloc_initialized): Declare external variable.
5194 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5196 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5198 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5200 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5202 [CYGWIN] (special_realloc): New function.
5203 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5204 requests to realloc storage in the static heap.
5206 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5208 * bidi.c (bidi_initialize): Remove unused local.
5210 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5213 * biditype.h: Remove file.
5214 * makefile.w32-in ($(BLD)/bidi.$(O)):
5215 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5217 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5219 * chartab.c: Improve commentary for the uniprop_table API.
5221 * bidi.c (bidi_paragraph_init): Support zero value of
5222 bidi_ignore_explicit_marks_for_paragraph_level.
5223 (bidi_initialize): Use uniprop_table instead of including
5224 biditype.h and bidimirror.h.
5226 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5227 coordinates of the iterator when restoring from ppos_it.
5230 2011-08-14 Kenichi Handa <handa@m17n.org>
5232 * process.c (create_process): Call setup_process_coding_systems
5233 after the pid of the process is set to -1 (Bug#8162).
5235 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5237 * xdisp.c (move_it_in_display_line_to): Don't invoke
5238 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5239 ppos_it. Fixes vertical cursor motion when line beginning is
5240 covered by an image. (Bug#9296)
5242 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5244 * nsterm.h (ns_run_ascript): Declare.
5245 (NSAPP_DATA2_RUNASSCRIPT): Define.
5247 * nsfns.m (as_script, as_result, as_status): New static variables.
5248 (ns_run_ascript): New function.
5249 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5250 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5251 the event loop. Get status from as_status (Bug#7276).
5253 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5254 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5255 the event loop (Bug#7276).
5257 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5259 * gnutls.c (QCgnutls_bootprop_priority)
5260 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5261 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5262 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5263 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5264 (QCgnutls_bootprop_verify_hostname_error)
5265 (QCgnutls_bootprop_callbacks_verify): Rename from
5266 Qgnutls_bootprop_..., all uses changed.
5268 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5271 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5273 * xfaces.c (Qframe_set_background_mode): Now static.
5274 * dispextern.h (Qframe_set_background_mode): Remove decl.
5276 * process.c (Fnetwork_interface_info): Declare local only if needed.
5278 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5280 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5281 (Fnetwork_interface_list): Allocate in increments of bytes instead
5282 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5283 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5285 (struct ifflag_def): notrailers is smart on OSX.
5286 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5287 Get hardware address with getifaddrs if available.
5289 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5291 * xdisp.c (iterate_out_of_display_property): xassert that
5292 IT->position is set to within IT->object's boundaries. Break from
5293 the loop as soon as EOB is reached; avoids infloops in redisplay
5294 when IT->position is set up wrongly due to some bug.
5295 Set IT->current to match the bidi iterator unconditionally.
5296 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5297 entry. Force push_it to save on the stack the current
5298 buffer/string position, to be restored by pop_it. Fix flags in
5299 the iterator structure wrt the object coming from a display
5300 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5301 properties. (Bug#9284)
5303 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5305 * fontset.c (fontset_get_font_group): Add proper type checks.
5308 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5310 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5311 and LC_VERSION_MIN_MACOSX.
5312 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5313 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5315 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5317 * xdisp.c (forward_to_next_line_start): Allow to use the
5318 no-display-properties-and-no-overlays under bidi display.
5319 Set disp_pos in the bidi iterator to avoid searches for display
5320 properties and overlays.
5322 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5324 * editfns.c (Fset_time_zone_rule): Document relationship with the
5327 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5328 the font entity extracted from the cache (Bug#8109).
5330 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5332 * composite.c (autocmp_chars): Don't reset point. That is done by
5333 restore_point_unwind (Bug#5984).
5335 2011-08-07 Juri Linkov <juri@jurta.org>
5337 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5338 to show the arg `TIME' instead of `TIMEVAL'.
5340 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5342 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5343 display property strides EOL and includes a newline, as in
5344 longlines-mode. (Bug#9254)
5345 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5346 word-wrap under bidirectional display. (Bug#9224)
5348 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5349 is non-zero, even if the data buffer is NULL. Fixes a crash in
5350 vertical-motion with longlines-mode. (Bug#9254)
5352 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5354 * bidi.c <bidi_cache_total_alloc>: Now static.
5355 (bidi_initialize): Initialize bidi_cache_total_alloc.
5357 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5360 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5361 amount allocated this far in `bidi_cache_total_alloc'.
5362 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5363 non-zero, only free the data buffer without restoring the cache
5364 contents. All callers changed.
5366 * dispextern.h (bidi_unshelve_cache): Update prototype.
5368 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5369 (move_it_in_display_line, move_it_to)
5370 (move_it_vertically_backward, move_it_by_lines): Replace the call
5371 to xfree to an equivalent call to bidi_unshelve_cache.
5372 (move_it_in_display_line_to): Fix logic of returning
5373 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5375 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5377 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5378 came from a string character with a `cursor' property. (Bug#9229)
5380 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5382 * Makefile.in (LIB_PTHREAD): New variable.
5383 (LIBES): Add LIB_PTHREAD (Bug#9216).
5385 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5386 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5388 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5390 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5392 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5394 * xterm.c (x_find_topmost_parent): New function.
5395 (x_set_frame_alpha): Find topmost parent window with
5396 x_find_topmost_parent and set the property there also (bug#9181).
5397 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5399 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5401 * callproc.c (Fcall_process): Avoid vfork clobbering
5402 the local vars buffer, coding_systems, current_dir.
5404 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5406 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5408 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5410 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5411 so that it is not optimized away.
5413 * xdisp.c (compute_display_string_pos): Remove unused local.
5415 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5417 Fix slow cursor motion and scrolling in large buffers with
5418 selective display, like Org Mode buffers. (Bug#9218)
5420 * dispextern.h (struct bidi_it): New member disp_prop_p.
5422 * xdisp.c: Remove one-slot cache of display string positions.
5423 (compute_display_string_pos): Accept an additional argument
5424 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5425 for a display string or property. If found, set DISP_PROP_P
5428 * bidi.c (bidi_fetch_char): Accept an additional argument
5429 DISP_PROP_P, and pass it to compute_display_string_pos.
5430 Only handle text covered by a display string if DISP_PROP_P is returned
5431 non-zero. All callers of bidi_fetch_char changed.
5433 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5435 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5437 2010-12-03 Don March <don@ohspite.net>
5439 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5440 last character M-[char] is translated to ESC [char] (bug#7541).
5442 2011-08-02 Kenichi Handa <handa@m17n.org>
5444 * lisp.h (uniprop_table): Extern it.
5446 * chartab.c (uniprop_table): Make it non-static.
5448 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5450 * xdisp.c (forward_to_next_line_start): Accept additional argument
5451 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5453 (reseat_at_next_visible_line_start): Use the bidi iterator state
5454 returned by forward_to_next_line_start to restore the state of
5455 it->bidi_it after backing up to previous newline. (Bug#9212)
5457 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5459 * regex.c (re_comp): Protoize.
5460 (re_exec): Fix return type.
5461 (regexec): Fix type of `ret'. (Bug#9203)
5463 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5465 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5466 This is needed if max-image-size is a floating-point number.
5468 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5470 * print.c (print_object): Print empty symbol as ##.
5472 * lread.c (read1): Read ## as empty symbol.
5474 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5476 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5477 setting frame foreground color (Bug#9175).
5478 (x_set_background_color): Likewise.
5480 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5481 contents (Bug#9176).
5482 (EmacsTooltip -init): Remove bezels and add shadows to
5485 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5486 or scroll bar (Bug#8470).
5488 * nsfont.m (nsfont_open): Remove assignment to voffset and
5489 unnecessary vars hshink, expand, hd, full_height, min_height.
5490 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5492 * nsterm.h (nsfont_info): Remove voffset field.
5494 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5496 Implement strike-through and overline on NextStep (Bug#8863).
5498 * nsfont.m (nsfont_open): Use underline position provided by font,
5499 instead of hard-coded value of 2.
5500 (nsfont_draw): Call ns_draw_text_decoration instead.
5502 * nsterm.h: Add declaration for ns_draw_text_decoration.
5504 * nsterm.m (ns_draw_text_decoration): New function for drawing
5505 underline, overline, and strike-through.
5506 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5507 ns_draw_text_decoration. Change treatment of cursor drawing to
5508 accommodate underlining, etc.
5510 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5512 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5515 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5517 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5518 Without this fix, if a signal arrives just after memory fills up,
5519 'malloc' might be invoked reentrantly.
5521 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5522 In other words, assume that every image size is allowed, on non-X
5523 hosts. This assumption is probably wrong, but it lets Emacs compile.
5525 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5527 * regex.c (re_iswctype): Convert return values to boolean.
5529 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5531 * xdisp.c (compute_display_string_pos): Don't use cached display
5532 string position if the buffer had its restriction changed.
5535 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5537 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5539 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5541 Integer signedness and overflow and related fixes. (Bug#9079)
5543 * bidi.c: Integer size and overflow fixes.
5544 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5545 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5546 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5547 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5548 (bidi_find_other_level_edge):
5549 Use ptrdiff_t instead of EMACS_INT where either will do.
5550 This works better on 32-bit hosts configured --with-wide-int.
5551 (bidi_cache_ensure_space): Check for size-calculation overflow.
5552 Use % rather than repeated addition, for better worst-case speed.
5553 Don't set bidi_cache_size until after xrealloc returns, because it
5555 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5556 (bidi_cache_ensure_space): Also check that the bidi cache size
5557 does not exceed that of the largest Lisp string or buffer. See Eli
5558 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5560 * alloc.c (__malloc_size_t): Remove.
5561 All uses replaced by size_t. See Andreas Schwab's note
5562 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5564 * image.c: Improve checking for integer overflow.
5565 (check_image_size): Assume that f is nonnull, since
5566 it is always nonnull in practice. This is one less thing to
5567 worry about when checking for integer overflow later.
5568 (x_check_image_size): New function, which checks for integer
5569 overflow issues inside X.
5570 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5571 This removes the need for a memory_full check.
5572 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5573 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5574 (xbm_read_bitmap_data): Change locals back to 'int', since
5575 their values must fit in 'int'.
5576 (xpm_load_image, png_load, tiff_load):
5577 Invoke x_create_x_image_and_pixmap earlier,
5578 to avoid much needless work if the image is too large.
5579 (tiff_load): Treat overly large images as if
5580 x_create_x_image_and_pixmap failed, not as malloc failures.
5581 (gs_load): Use x_check_image_size.
5583 * gtkutil.c: Omit integer casts.
5584 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5585 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5587 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5589 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5590 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5591 would wrongly return t on a 64-bit host.
5593 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5594 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5595 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5596 and therefore cause GCC to emit a bogus diagnostic in some cases.
5598 * image.c: Integer signedness and overflow and related fixes.
5599 This is not an exhaustive set of fixes, but it's time to
5600 record what I've got.
5601 (lookup_pixel_color, check_image_size): Remove redundant decls.
5602 (check_image_size): Don't assume that arbitrary EMACS_INT values
5603 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5604 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5605 (tiff_load, imagemagick_load_image):
5606 Check for overflow in size calculations.
5607 (x_create_x_image_and_pixmap): Remove unnecessary test for
5608 xmalloc returning NULL; that can't happen.
5609 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5610 (xpm_color_bucket): Use better integer hashing function.
5611 (xpm_cache_color): Don't possibly over-allocate memory.
5612 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5613 (gif_memory_source):
5614 Use ptrdiff_t, not int or size_t, to record sizes.
5615 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5616 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5617 either works, as we prefer signed integers.
5618 (tiff_read_from_memory, tiff_write_from_memory):
5619 Return tsize_t, not size_t, since that's what the TIFF API wants.
5620 (tiff_read_from_memory): Don't fail simply because the read would
5621 go past EOF; instead, return a short read.
5622 (tiff_load): Omit no-longer-needed casts.
5623 (Fimagemagick_types): Don't assume size fits into 'int'.
5625 Improve hashing quality when configured --with-wide-int.
5626 * fns.c (hash_string): New function, taken from sxhash_string.
5627 Do not discard information about ASCII character case; this
5628 discarding is no longer needed.
5629 (sxhash-string): Use it. Change sig to match it. Caller changed.
5630 * lisp.h: Declare it.
5631 * lread.c (hash_string): Remove, since we now use fns.c's version.
5632 The fns.c version returns a wider integer if --with-wide-int is
5633 specified, so this should help the quality of the hashing a bit.
5635 * emacs.c: Integer overflow minor fix.
5636 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5637 Define only if GNU_LINUX.
5638 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5640 * dispnew.c: Integer signedness and overflow fixes.
5641 Remove unnecessary forward decls, that were a maintenance hassle.
5642 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5644 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5645 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5646 (prepare_desired_row, line_draw_cost):
5647 Use int, not unsigned, where either works.
5648 (save_current_matrix, restore_current_matrix):
5649 Use ptrdiff_t, not size_t, where either works.
5650 (init_display): Check for overflow more accurately, and without
5651 relying on undefined behavior.
5653 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5654 Remove, replacing with the new symbols in lisp.h. All uses changed.
5655 * fileio.c (make_temp_name):
5656 * filelock.c (lock_file_1, lock_file):
5657 * xdisp.c (message_dolog):
5658 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5659 Use pMd etc. instead.
5660 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5661 replacing the pWIDE etc. symbols removed from editfns.c.
5663 * keyboard.h (num_input_events): Now uintmax_t.
5664 This is (very slightly) less likely to mess up due to wraparound.
5667 * buffer.c: Integer signedness fixes.
5668 (alloc_buffer_text, enlarge_buffer_text):
5669 Use ptrdiff_t rather than size_t when either will do, as we prefer
5672 * alloc.c: Integer signedness and overflow fixes.
5673 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5674 (__malloc_size_t): Default to size_t, not to int.
5675 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5676 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5677 Prefer ptrdiff_t to size_t when either would do, as we prefer
5679 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5680 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5681 Now const. Initialize with values that are in range even if char
5683 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5684 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5685 These functions do the right thing with sizes > 2**32.
5686 (check_depth): Now ptrdiff_t, not int.
5687 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5688 Adjust to new way of storing sizes. Check for size overflow bugs
5690 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5691 slightly wrong anyway, as it missed one instance of
5692 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5693 (refill_memory_reserve): Omit needless cast to size_t.
5694 (mark_object_loop_halt): Mark as externally visible.
5696 * xselect.c: Integer signedness and overflow fixes.
5697 (Fx_register_dnd_atom, x_handle_dnd_message):
5698 Use ptrdiff_t, not size_t, since we prefer signed.
5699 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5700 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5701 x_dnd_atoms_size and x_dnd_atoms_length.
5703 * doprnt.c: Prefer signed to unsigned when either works.
5705 * doprnt.c (doprnt):
5707 * xdisp.c (vmessage):
5708 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5709 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5710 prefer signed arithmetic to avoid comparison confusion.
5711 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5712 but is a bit tricky.
5714 Assume freestanding C89 headers, string.h, stdlib.h.
5715 * data.c, doprnt.c, floatfns.c, print.c:
5716 Include float.h unconditionally.
5717 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5718 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5719 * regex.c: Likewise for stddef.h, string.h.
5720 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5721 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5722 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5723 (STDC_HEADERS): Remove obsolete defines.
5724 * sysdep.c: Include limits.h unconditionally.
5726 Assume support for memcmp, memcpy, memmove, memset.
5727 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5728 * regex.c (memcmp, memcpy):
5729 Remove; we assume C89 now.
5731 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5732 (__malloc_safe_bcopy): Remove; no longer needed.
5734 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5735 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5736 well either way, and we prefer signed to unsigned.
5738 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5740 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5741 closes the connection while we're reading (bug#9182).
5743 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5745 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5746 are specified (Bug#9168).
5748 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5750 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5751 Found by GCC static checking and --with-wide-int on a 32-bit host.
5753 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5755 * xdisp.c (compute_display_string_pos): Fix logic of caching
5756 previous display string position. Initialize cached_prev_pos to
5757 -1. Fixes slow-down at the beginning of a buffer.
5759 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5761 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5762 for attrs[LFACE_FONTSET_INDEX].
5764 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5766 * xml.c (parse_region): Remove unused local
5767 that was recently introduced.
5769 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5771 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5772 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5774 * xdisp.c (move_it_in_display_line_to): Record the best matching
5775 position for TO_CHARPOS while scanning the line, and restore it on
5776 exit if none of the characters scanned was an exact match.
5777 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5778 when exact match is impossible due to invisible text, and the
5779 lines are truncated.
5781 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5783 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5786 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5788 Fix a significant slow-down of cursor motion with C-n, C-p,
5789 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5790 auto-repeat under bidi redisplay in fontified buffers.
5791 * xdisp.c (compute_stop_pos_backwards): New function.
5792 (next_element_from_buffer): Call compute_stop_pos_backwards to
5793 find a suitable prev_stop when we find ourselves before
5795 (reseat): Don't look for prev_stop, as that could mean a very long
5797 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5798 <cached_disp_overlay_modiff>: Cache for last found display string
5800 (compute_display_string_pos): Return the cached position if asked
5801 about the same buffer in the same area of character positions, and
5802 the buffer wasn't changed since the time the display string
5803 position was cached.
5805 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5807 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5808 is an integer, which is important for empty lines. (Bug#9149)
5810 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5812 * frame.c (Fmodify_frame_parameters): In tty case, update the
5813 default face if necessary (Bug#4238).
5815 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5817 * editfns.c (Fstring_to_char): No need to explain what a character
5818 is in the docstring (Bug#6576).
5820 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5822 * xml.c (parse_region): Make sure we always return a tree.
5824 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5826 * xml.c (parse_region): If a document contains only comments,
5829 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5831 * xml.c (make_dom): Return comments, too.
5833 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5836 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5837 and the surrounding thread.
5838 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5839 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5840 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5842 * s/openbsd.h (BROKEN_SIGIO): Define.
5843 * unexelf.c (unexec) [__OpenBSD__]:
5844 Don't update the .mdebug section of the Alpha COFF symbol table.
5846 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5848 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5851 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5853 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5854 This fixes some race conditions on the permissions of any newly
5857 * alloc.c (valid_pointer_p): Use pipe, not open.
5858 This fixes some permissions issues when debugging.
5860 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5861 If fchown fails to set both uid and gid, try to set just gid,
5862 as that is sometimes allowed. Adjust the file's mode to eliminate
5863 setuid or setgid bits that are inappropriate if fchown fails.
5865 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5867 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5868 to compare Lisp_Objects.
5869 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5870 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5871 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5873 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5875 * lread.c (read_integer): Unread even EOF character.
5876 (read1): Likewise. Properly record start position of symbol.
5878 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5879 symbol character follows.
5881 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5883 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5884 This works around a problem with the previous change to Fcopy_file.
5885 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5886 and without this change, GCC might complain about discarding
5887 fchown's return value.
5889 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5891 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5893 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5895 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5897 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5899 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5900 it's used from the C level.
5902 * process.c: Use the same condition for POLL_FOR_INPUT in both
5903 keyboard.c and process.c (bug#1858).
5905 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5907 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5908 (Fgnutls_boot): Use it.
5910 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5912 * doc.c (Fsubstitute_command_keys): Revert last change.
5914 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5916 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5917 quotes the next character, and doesn't affect other longer
5918 sequences (bug#8935).
5920 * lread.c (syms_of_lread): Clarify that is isn't only
5921 `eval-buffer' and `eval-defun' that's affected by
5922 `lexical-binding' (bug#8460).
5924 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5926 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5927 bidi redisplay when a line includes both an image and is truncated.
5929 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5931 Fix minor problems found by static checking.
5932 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5933 (elsz): Now a signed constant, not a size_t var. We prefer signed
5934 types to unsigned, to avoid integer comparison confusion. Without
5935 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5936 "cannot optimize loop, the loop counter may overflow", a symptom
5938 * indent.c (Fvertical_motion): Mark locals as initialized.
5939 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5941 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5943 * search.c (Fre_search_backward): Mention `case-fold-search' in
5944 all the re_search_* functions (bug#8138).
5946 * keyboard.c (Fopen_dribble_file): Document when the file is
5949 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5951 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5954 Support bidi reordering of display and overlay strings.
5955 * xdisp.c (compute_display_string_pos)
5956 (compute_display_string_end): Accept additional argument STRING.
5957 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5958 (reseat_to_string): Initialize bidi_it->string.s and
5959 bidi_it->string.schars.
5960 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5961 NULL (avoids a crash in bidi_paragraph_init).
5962 Initialize itb.string.lstring.
5963 (init_iterator): Call bidi_init_it only of a valid
5964 buffer position was specified. Initialize paragraph_embedding to
5966 (reseat_to_string): Initialize the bidi iterator.
5967 (display_string): If we need to ignore text properties of
5968 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5969 original value of -1 will not work with bidi.)
5970 (compute_display_string_pos): First arg is now struct
5971 `text_pos *'; all callers changed. Support display properties on
5973 (compute_display_string_end): Support display properties on Lisp
5975 (init_iterator, reseat_1, reseat_to_string): Initialize the
5976 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5977 when iterating on a string not from display properties).
5978 (compute_display_string_pos, compute_display_string_end):
5979 Fix calculation of the object to scan. Fixes an error when using
5981 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5982 base_level_stop; instead, set base_level_stop to BEGV.
5983 Fixes crashes in vertical-motion.
5984 (next_element_from_buffer): Improve commentary for when
5985 the iterator is before prev_stop.
5986 (init_iterator): Initialize bidi_p from the default value of
5987 bidi-display-reordering, not from buffer-local value. Use the
5988 buffer-local value only if initializing for buffer iteration.
5989 (handle_invisible_prop): Support invisible properties on strings
5990 that are being bidi-reordered.
5991 (set_iterator_to_next): Support bidi reordering of C strings and
5993 (next_element_from_string): Support bidi reordering of Lisp
5995 (handle_stop_backwards): Support Lisp strings as well.
5996 (display_string): Support display of R2L glyph rows.
5997 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5998 (init_iterator): Don't initialize it->bidi_p for strings
6000 (reseat_to_string): Initialize it->bidi_p for strings here.
6001 (next_element_from_string, next_element_from_c_string)
6002 (next_element_from_buffer): Add xassert's for correspondence
6003 between IT's object being iterated and it->bidi_it.string
6005 (face_before_or_after_it_pos): Support bidi iteration.
6006 (next_element_from_c_string): Handle the case of the first string
6007 character that is not the first one in the visual order.
6008 (get_visually_first_element): New function, refactored from common
6009 parts of next_element_from_buffer, next_element_from_string, and
6010 next_element_from_c_string.
6011 (tool_bar_lines_needed, redisplay_tool_bar)
6012 (display_menu_bar): Force left-to-right direction. Add a FIXME
6013 comment for making that be controlled by a user option.
6014 (push_it, pop_it): Save and restore the state of the
6015 bidi iterator. Save and restore the bidi_p flag.
6016 (pop_it): Iterate out of display property for string iteration as
6018 (iterate_out_of_display_property): Support iteration over strings.
6019 (handle_single_display_spec): Set up it->bidi_it for iteration
6020 over a display string, and call bidi_init_it.
6021 (handle_single_display_spec, next_overlay_string)
6022 (get_overlay_strings_1, push_display_prop): Set up the bidi
6023 iterator for displaying display or overlay strings.
6024 (forward_to_next_line_start): Don't use the shortcut if
6026 (back_to_previous_visible_line_start): If handle_display_prop
6027 pushed the iterator stack, restore the internal state of the bidi
6028 iterator by calling bidi_pop_it same number of times.
6029 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6030 and we are bidi-iterating, don't decrement the iterator position;
6031 instead, set the first_elt flag in the bidi iterator, to produce
6033 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6034 (push_display_prop): xassert that we are iterating a buffer.
6035 (push_it, pop_it): Save and restore paragraph_embedding member.
6036 (handle_single_display_spec, next_overlay_string)
6037 (get_overlay_strings_1, reseat_1, reseat_to_string)
6038 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6039 correctly. Don't assume unibyte strings are not bidi-reordered.
6040 (compute_display_string_pos)
6041 (compute_display_string_end): Fix handling the case of C string.
6042 (push_it, pop_it): Save and restore from_disp_prop_p.
6043 (handle_single_display_spec, push_display_prop): Set the
6044 from_disp_prop_p flag.
6045 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6046 (pop_it): Call iterate_out_of_display_property only if we are
6047 popping after iteration over a string that came from a display
6048 property. Fix a typo in popping stretch info. Add an assertion
6049 for verifying that the iterator position is in sync with the bidi
6051 (handle_single_display_spec, get_overlay_strings_1)
6052 (push_display_prop): Fix initialization of paragraph direction for
6053 string when that of the parent object is not yet determined.
6054 (reseat_1): Call bidi_init_it to resync the bidi
6055 iterator with IT's position. (Bug#7616)
6056 (find_row_edges): If ROW->start.pos gives position
6057 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6058 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6059 Reset the from_disp_prop_p flag.
6060 (SAVE_IT, RESTORE_IT): New macros.
6061 (pos_visible_p, face_before_or_after_it_pos)
6062 (back_to_previous_visible_line_start)
6063 (move_it_in_display_line_to, move_it_in_display_line)
6064 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6065 (try_scrolling, redisplay_window, display_line): Use them when
6066 saving a temporary copy of the iterator and restoring it back.
6067 (back_to_previous_visible_line_start, reseat_1)
6068 (init_iterator): Empty the bidi cache "stack".
6069 (move_it_in_display_line_to): If iterator ended up at
6070 EOL, but we never saw any buffer positions smaller than
6071 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6072 motion in bidi-reordered lines.
6073 (move_it_in_display_line_to): Record prev_method and prev_pos
6074 immediately before the call to set_iterator_to_next. Fixes cursor
6075 motion in bidi-reordered lines with stretch glyphs and strings
6076 displayed in margins. (Bug#8133) (Bug#8867)
6077 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6079 (pos_visible_p): Support positions in bidi-reordered lines.
6080 Save and restore bidi cache.
6082 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6083 (bidi_paragraph_info): Delete unused struct.
6084 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6085 (bidi_cache_start): New variable.
6086 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6088 (bidi_cache_fetch_state, bidi_cache_search)
6089 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6090 (bidi_cache_find, bidi_peek_at_next_level)
6091 (bidi_level_of_next_char, bidi_find_other_level_edge)
6092 (bidi_move_to_visually_next): Compare cache index with
6093 bidi_cache_start rather than with zero.
6094 (bidi_fetch_char): Accept new argument STRING; all callers
6095 changed. Support iteration over a string. Support strings with
6096 display properties. Support unibyte strings. Fix the type of
6097 `len' according to what STRING_CHAR_AND_LENGTH expects.
6098 (bidi_paragraph_init, bidi_resolve_explicit_1)
6099 (bidi_resolve_explicit, bidi_resolve_weak)
6100 (bidi_level_of_next_char, bidi_move_to_visually_next):
6101 Support iteration over a string.
6102 (bidi_set_sor_type, bidi_resolve_explicit_1)
6103 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6104 can now be zero (for strings); special values 0 and -1 were
6105 changed to -1 and -2, respectively.
6106 (bidi_char_at_pos): New function.
6107 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6108 Call it instead of FETCH_MULTIBYTE_CHAR.
6109 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6110 initialized to valid values.
6111 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6113 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6114 the test for valid cached positions. Fix the logic for looking up
6115 the sentinel state in the cache. GCPRO the Lisp string we are
6117 (bidi_push_it, bidi_pop_it): New functions.
6118 (bidi_initialize): Initialize the bidi cache start stack pointer.
6119 (bidi_cache_ensure_space): New function, refactored from part of
6120 bidi_cache_iterator_state. Don't assume the required size is just
6121 one BIDI_CACHE_CHUNK away.
6122 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6123 (bidi_count_bytes, bidi_char_at_pos): New functions.
6124 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6125 always valid if bidi_cache_idx is valid.
6126 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6127 is valid if it's going to be used.
6128 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6129 (bidi_cache_fetch_state, bidi_cache_search)
6130 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6131 (bidi_cache_iterator_state, bidi_cache_find)
6132 (bidi_find_other_level_edge, bidi_cache_start_stack):
6133 All variables related to cache indices are now EMACS_INT.
6135 * dispextern.h (struct bidi_string_data): New structure.
6136 (struct bidi_it): New member `string'. Make flag members be 1-bit
6137 fields, and put them last in the struct.
6138 (compute_display_string_pos, compute_display_string_end):
6140 (bidi_push_it, bidi_pop_it): Add prototypes.
6141 (struct iterator_stack_entry): New members bidi_p,
6142 paragraph_embedding, and from_disp_prop_p.
6143 (struct it): Member bidi_p is now a bit field 1 bit wide.
6144 (bidi_shelve_cache, bidi_unshelve_cache):
6147 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6148 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6149 and vector-like objects.
6151 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6152 cache around display iteration.
6154 * window.c (Fwindow_end, window_scroll_pixel_based)
6155 (displayed_window_lines, Frecenter): Save and restore the bidi
6156 cache around display iteration.
6158 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6160 * editfns.c (Fdelete_region): Clarify the use of the named
6161 parameters (bug#6788).
6163 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6165 * indent.c (Fvertical_motion): Set and restore w->pointm when
6166 saving and restoring the window's buffer (Bug#9006).
6168 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6170 * editfns.c (Fstring_to_char): Clarify just what is returned
6171 (bug#6576). Text by Eli Zaretskii.
6173 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6175 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6177 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6179 * buffer.c (mmap_find): Fix a typo.
6181 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6183 Fix execution of x selection hooks.
6184 * xselect.c (Qx_lost_selection_functions)
6185 (Qx_sent_selection_functions): New vars.
6186 (syms_of_xselect): DEFSYM them.
6187 (x_handle_selection_request): Pass Qx_sent_selection_functions
6188 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6189 (x_handle_selection_clear,x_clear_frame_selections):
6190 Pass Qx_lost_selection_functions rather than
6191 Vx_lost_selection_functions to Frun_hook_with_args.
6193 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6195 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6196 The old code sometimes used this field without initializing it.
6198 * alloc.c (gc_sweep): Don't read past end of array.
6199 In theory, the old code could also have corrupted Emacs internals,
6200 though it'd be very unlikely.
6202 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6204 * character.c (Fcharacterp): Don't advertise optional ignored
6205 argument. (Bug#4026)
6207 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6209 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6212 * window.c (Fset_window_start): Doc fix (bug#4199).
6213 (Fset_window_hscroll): Ditto.
6215 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6217 Fix minor new problems caught by GCC 4.6.1.
6218 * term.c (init_tty): Remove unused local.
6219 * xsettings.c (store_monospaced_changed): Define this function only
6220 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6223 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6225 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6227 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6229 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6230 are the mini-buffer and the echo area (bug#3320).
6232 * term.c (init_tty): Remove support for supdup, c10 and perq
6233 terminals, which are no longer supported (bug#1482).
6235 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6237 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6239 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6241 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6242 for non-popups (Bug#3642).
6244 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6246 * alloc.c (reset_malloc_hooks): Protoize.
6247 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6248 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6249 * cm.c (losecursor): Likewise.
6250 * data.c (fmod): Likewise.
6251 * dispnew.c (swap_glyphs_in_rows): Likewise.
6252 * emacs.c (memory_warning_signal): Likewise.
6253 * floatfns.c (float_error): Likewise.
6254 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6255 (otf_open, font_otf_capability, generate_otf_features)
6256 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6258 * image.c (pbm_read_file): Likewise.
6259 * indent.c (string_display_width): Likewise.
6260 * intervals.c (check_for_interval, search_for_interval)
6261 (inc_interval_count, count_intervals, root_interval)
6262 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6263 * lread.c (defalias): Likewise.
6264 * ralloc.c (r_alloc_check): Likewise.
6265 * regex.c (set_image_of_range_1, set_image_of_range)
6266 (regex_grow_registers): Likewise.
6267 * sysdep.c (strerror): Likewise.
6268 * termcap.c (valid_filename_p, tprint, main): Likewise.
6269 * tparam.c (main): Likewise.
6270 * unexhp9k800.c (run_time_remap, save_data_space)
6271 (update_file_ptrs, read_header, write_header, calculate_checksum)
6272 (copy_file, copy_rest, display_header): Likewise.
6273 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6275 * xdisp.c (check_it): Likewise.
6276 * xfaces.c (register_color, unregister_color, unregister_colors):
6278 * xfns.c (print_fontset_result): Likewise.
6279 * xrdb.c (member, fatal, main): Likewise.
6281 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6283 Fix minor problems found by static checking (Bug#9031).
6284 * chartab.c (char_table_set_range, map_sub_char_table):
6285 Remove unused locals.
6286 (uniprop_table): Now static.
6287 * composite.c (_work_char): Remove unused static var.
6289 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6291 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6293 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6295 * gtkutil.c (qttip_cb): Remove code without function.
6297 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6299 * w32.c (pthread_sigmask): New stub.
6301 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6303 Use pthread_sigmask, not sigprocmask (Bug#9010).
6304 sigprocmask is portable only for single-threaded applications, and
6305 Emacs can be multi-threaded when it uses GTK.
6306 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6308 * callproc.c (Fcall_process):
6309 * process.c (create_process):
6310 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6311 Use pthread_sigmask, not sigprocmask.
6313 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6315 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6316 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6319 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6321 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6322 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6323 (xg_hide_tooltip): Fix comment.
6325 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6326 in registerServicesMenuSendTypes.
6327 (validRequestorForSendType): Don't check ns_return_types.
6329 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6332 2011-07-08 Jason Rumney <jasonr@gnu.org>
6334 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6335 SH_SHOW for hidden windows (Bug#5482).
6337 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6338 frame struct members of non-existent frames (Bug#6284).
6340 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6342 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6343 variable firstTime not needed on OSX >= 10.6.
6344 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6345 >= 10.5. Use setKnobProportion, setDoubleValue.
6347 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6348 (MAC_OS_X_VERSION_10_5): Define if not defined.
6349 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6350 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6351 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6353 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6354 cString and lossyCString on OSX >= 10.4
6356 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6357 sizeToFit on OSX >= 10.2.
6359 * nsimage.m (allocInitFromFile): Don't use deprecated method
6360 bestRepresentationForDevice on OSX >= 10.6.
6362 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6365 * emacs.c: Declare unexec_init_emacs_zone.
6367 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6369 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6371 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6372 on svcsMenu (Bug#8842).
6374 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6376 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6378 * nsterm.m (QUTF8_STRING): Declare.
6379 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6380 (validRequestorForSendType): Return type is (id).
6381 Change indexOfObjectIdenticalTo to indexOfObject.
6382 Check if we have local selection before returning self (Bug#8842).
6383 (writeSelectionToPasteboard): Put local selection into paste board
6384 if we have a local selection (Bug#8842).
6385 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6387 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6388 (ns_get_local_selection): Declare.
6390 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6392 * keymap.c (describe_map_tree): Don't insert a double newline at
6393 the end of the buffer (bug#1169) and return whether we inserted
6396 * callint.c (Fcall_interactively): Change "reading args" to
6397 "providing args" to try to clarify what it does (bug#1010).
6399 2011-07-07 Kenichi Handa <handa@m17n.org>
6401 * composite.c (composition_compute_stop_pos): Ignore a static
6402 composition starting before CHARPOS (Bug#8915).
6404 * xdisp.c (handle_composition_prop): Likewise.
6406 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6408 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6411 2011-07-07 Kenichi Handa <handa@m17n.org>
6413 * character.h (unicode_category_t): New enum type.
6415 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6416 (Qchar_code_property_table): New variable.
6417 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6418 (UNIPROP_COMPRESSED_FORM_P): New macros.
6419 (char_table_ascii): Uncompress the compressed values.
6420 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6421 Uncompress the compressed values.
6422 (sub_char_table_ref_and_range): Likewise.
6423 (char_table_ref_and_range): Uncompress the compressed values.
6424 (sub_char_table_set): New arg is_uniprop. Callers changed.
6425 Uncompress the compressed values.
6426 (sub_char_table_set_range): Args changed. Callers changed.
6427 (char_table_set_range): Adjuted for the above change.
6428 (map_sub_char_table): Delete args default_val and parent. Add arg
6429 top. Give decoded values to a Lisp function.
6430 (map_char_table): Adjust for the above change. Give decoded
6431 values to a Lisp function. Gcpro more variables.
6432 (uniprop_table_uncompress)
6433 (uniprop_decode_value_run_length): New functions.
6434 (uniprop_decoder, uniprop_decoder_count): New variables.
6435 (uniprop_get_decoder, uniprop_encode_value_character)
6436 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6438 (uniprop_encoder, uniprop_encoder_count): New variables.
6439 (uniprop_get_encoder, uniprop_table)
6440 (Funicode_property_table_internal, Fget_unicode_property_internal)
6441 (Fput_unicode_property_internal): New functions.
6442 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6443 Sunicode_property_table_internal, Sget_unicode_property_internal,
6444 and Sput_unicode_property_internal. Defvar_lisp
6445 char-code-property-alist.
6447 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6448 Vunicode_category_table.
6450 * font.c (font_range): Adjust for the change of
6451 Vunicode_category_table.
6453 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6455 * m/iris4d.h: Remove file, move contents ...
6456 * s/irix6-5.h: ... here.
6458 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6460 Remove unportable assumption about struct layout (Bug#8884).
6461 * alloc.c (mark_buffer):
6462 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6463 (clone_per_buffer_values): Don't assume that
6464 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6465 This isn't true in general, and it's particularly not true
6466 if Emacs is configured with --with-wide-int.
6467 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6468 New macros, used in the buffer.c change.
6470 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6472 * xsettings.c: Use both GConf and GSettings if both are available.
6473 (store_config_changed_event): Add comment.
6474 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6475 (store_tool_bar_style_changed): New functions.
6476 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6477 (struct xsettings): Move font inside HAVE_XFT.
6478 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6479 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6480 Move inside HAVE_XFT.
6481 (something_changed_gsettingsCB): Rename from something_changedCB.
6482 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6484 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6485 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6486 (something_changed_gconfCB): Rename from something_changedCB.
6487 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6488 (parse_settings): Move check for font inside HAVE_XFT.
6489 (read_settings, apply_xft_settings): Add comment.
6490 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6491 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6492 call store_font_name_changed.
6493 (xft_settings_event): Add comment.
6494 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6495 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6496 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6497 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6498 (xsettings_initialize): Call init_gsettings last.
6499 (xsettings_get_system_font, xsettings_get_system_normal_font):
6502 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6504 Random fixes. E.g., (random) never returned negative values.
6505 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6506 subseconds part to the entropy, as that's a bit more random.
6507 Prefer signed to unsigned, since the signedness doesn't matter and
6508 in general we prefer signed. When given a limit, use a
6509 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6510 latter isn't right if USE_2_TAGS_FOR_INTS.
6511 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6512 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6514 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6516 * textprop.c (text_property_stickiness):
6517 Obey Vtext_property_default_nonsticky.
6518 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6519 * w32fns.c (syms_of_w32fns):
6520 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6522 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6524 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6525 This is more efficient than Ffile_directory_p and avoids a minor race.
6527 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6529 * buffer.c (Foverlay_put): Say what the return value is
6532 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6533 is a directory before asking whether to use the file name
6535 (barf_or_query_if_file_exists): Make the "File is a directory"
6536 error be more correct.
6538 * fns.c (Frequire): Remove the mention of the .gz files, since
6539 that's installation-specific, but keep the mention of
6540 `get-load-suffixes'.
6542 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6544 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6545 Report string overflow if the output is too long.
6547 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6549 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6550 (syms_of_gnutls): Remove duplicate DEFSYM for
6551 Qgnutls_bootprop_verify_hostname_error, an error for
6552 Qgnutls_bootprop_verify_error (which is no longer used).
6554 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6555 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6556 Also (re)move comments that are misplaced or no longer relevant.
6558 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6560 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6562 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6564 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6565 and background color parameters if they have been changed.
6567 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6569 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6571 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6573 * xsettings.c (SYSTEM_FONT): Define only when used.
6574 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6576 * keymap.c (access_keymap_1): Now static.
6578 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6580 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6581 leave any prefix arg for the up event (Bug#1586).
6583 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6585 * lread.c (syms_of_lread): Mention single symbols defined by
6586 `defvar' or `defconst' (bug#7154).
6588 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6589 (Frequire): Mention get-load-suffixes.
6591 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6593 * window.h (window): Remove clone_number slot.
6594 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6596 (make_parent_window, make_window, saved_window)
6597 (Fset_window_configuration, save_window_save): Don't deal with
6599 * buffer.c (Qclone_number): Remove declaration.
6600 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6602 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6604 Add multiple inheritance to keymaps.
6605 * keymap.c (Fmake_composed_keymap): New function.
6606 (Fset_keymap_parent): Simplify.
6607 (fix_submap_inheritance): Remove.
6608 (access_keymap_1): New function extracted from access_keymap to handle
6609 embedded parents and handle lists of maps.
6610 (access_keymap): Use it.
6611 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6612 (Fcopy_keymap): Handle embedded parents.
6613 (Fcommand_remapping, define_as_prefix): Simplify.
6614 (Fkey_binding): Simplify.
6615 (syms_of_keymap): Move minibuffer-local-completion-map,
6616 minibuffer-local-filename-completion-map,
6617 minibuffer-local-must-match-map, and
6618 minibuffer-local-filename-must-match-map to Elisp.
6619 (syms_of_keymap): Defsubr make-composed-keymap.
6620 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6621 (parse_menu_item): Trivial simplification.
6623 2011-07-01 Glenn Morris <rgm@gnu.org>
6625 * Makefile.in (SETTINGS_LIBS): Fix typo.
6627 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6629 * coding.c (Fencode_coding_string): Record the last coding system
6630 used, as the function doc string says (bug#8738).
6632 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6634 * xsettings.c (store_monospaced_changed): Take new font as arg and
6635 check for change against current_mono_font.
6636 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6637 (emacs_settings_constructor, emacs_settings_get_property)
6638 (emacs_settings_set_property, emacs_settings_class_init)
6639 (emacs_settings_init, gsettings_obj): Remove.
6640 (something_changedCB): New function for HAVE_GSETTINGS.
6641 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6642 with value as argument.
6643 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6644 g_settings_new (Bug#8967). Do not create gsettings_obj.
6645 Remove calls to g_settings_bind. Connect something_changedCB to
6648 * xgselect.c: Add defined (HAVE_GSETTINGS).
6649 (xgselect_initialize): Ditto.
6651 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6652 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6655 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6657 * eval.c (struct backtrace): Simplify and port the data structure.
6658 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6659 signed bit field, as this assumption is not portable and it makes
6660 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6661 "char debug_on_exit : 1" as this is not portable either; instead,
6662 use the portable "unsigned int debug_on_exit : 1". Remove unused
6663 member evalargs. Remove obsolete comments about cc bombing out.
6665 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6667 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6668 Let HAVE_GSETTINGS override HAVE_GCONF.
6669 (store_monospaced_changed): New function.
6670 (EMACS_SETTINGS): A new type derived from GObject to handle
6671 GSettings notifications.
6672 (emacs_settings_constructor, emacs_settings_get_property)
6673 (emacs_settings_set_property, emacs_settings_class_init):
6675 (gsettings_client, gsettings_obj): New variables.
6676 (GSETTINGS_SCHEMA): New define.
6677 (something_changedCB): Call store_monospaced_changed.
6678 (init_gsettings): New function.
6679 (xsettings_initialize): Call init_gsettings.
6680 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6683 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6686 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6688 * window.c (resize_root_window, grow_mini_window)
6689 (shrink_mini_window): Rename Qresize_root_window to
6690 Qwindow_resize_root_window and Qresize_root_window_vertically to
6691 Qwindow_resize_root_window_vertically.
6693 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6695 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6697 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6699 * makefile.w32-in: Redesign dependencies so they reflect more
6700 clearly which files are directly included by each source file,
6701 and not through other includes.
6703 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6705 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6706 (sort_overlays, overlay_strings): When an overlay's clone number
6707 matches the window's clone number process the overlay even if
6708 the overlay's window property doesn't match the current window.
6710 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6711 (Fwindow_hchild): Rename to Fwindow_left_child.
6712 (Fwindow_next): Rename to Fwindow_next_sibling.
6713 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6714 (resize_window_check): Rename to window_resize_check.
6715 (resize_window_apply): Rename to window_resize_apply.
6716 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6717 (Fdelete_other_windows_internal, resize_frame_windows)
6718 (Fsplit_window_internal, Fdelete_window_internal)
6719 (grow_mini_window, shrink_mini_window)
6720 (Fresize_mini_window_internal): Fix callers accordingly.
6722 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6724 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6725 (emacs_fixed_set_min_size): Remove.
6726 (emacs_fixed_new): Take frame as argument.
6728 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6729 (_EmacsFixedPrivate): Remove minwidth/height.
6730 Add struct frame *f.
6731 (emacs_fixed_init): Initialize priv->f.
6732 (get_parent_class, emacs_fixed_set_min_size): Remove.
6733 (emacs_fixed_new): Set priv->f to argument.
6734 (emacs_fixed_get_preferred_width)
6735 (emacs_fixed_get_preferred_height): Use min_width/height from
6736 frames size_hint to set minimum and natural (Bug#8919).
6737 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6738 and use min_width/height from frames size_hint to set
6739 min_width/height (Bug#8919).
6741 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6742 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6745 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6747 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6748 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6751 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6753 * process.c (wait_reading_process_output): Bypass select if
6754 waiting for a cell while ignoring keyboard input, and input is
6755 pending. Suggested by Jan Djärv (Bug#8869).
6757 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6759 Use gnulib's dup2 module instead of rolling our own.
6760 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6762 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6764 * dispnew.c (scrolling_window): Before scrolling, turn off a
6765 mouse-highlight in the window being scrolled.
6767 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6769 Move DEFSYM to lisp.h and use everywhere.
6771 * character.h (DEFSYM): Move declaration...
6772 * lisp.h (DEFSYM): ...here.
6778 * w32select.c: Don't include character.h.
6780 * alloc.c (syms_of_alloc):
6781 * buffer.c (syms_of_buffer):
6782 * bytecode.c (syms_of_bytecode):
6783 * callint.c (syms_of_callint):
6784 * casefiddle.c (syms_of_casefiddle):
6785 * casetab.c (init_casetab_once):
6786 * category.c (init_category_once, syms_of_category):
6787 * ccl.c (syms_of_ccl):
6788 * cmds.c (syms_of_cmds):
6789 * composite.c (syms_of_composite):
6790 * dbusbind.c (syms_of_dbusbind):
6791 * dired.c (syms_of_dired):
6792 * dispnew.c (syms_of_display):
6793 * doc.c (syms_of_doc):
6794 * editfns.c (syms_of_editfns):
6795 * emacs.c (syms_of_emacs):
6796 * eval.c (syms_of_eval):
6797 * fileio.c (syms_of_fileio):
6798 * fns.c (syms_of_fns):
6799 * frame.c (syms_of_frame):
6800 * fringe.c (syms_of_fringe):
6801 * insdel.c (syms_of_insdel):
6802 * keymap.c (syms_of_keymap):
6803 * lread.c (init_obarray, syms_of_lread):
6804 * macros.c (syms_of_macros):
6805 * msdos.c (syms_of_msdos):
6806 * print.c (syms_of_print):
6807 * process.c (syms_of_process):
6808 * search.c (syms_of_search):
6809 * sound.c (syms_of_sound):
6810 * syntax.c (init_syntax_once, syms_of_syntax):
6811 * terminal.c (syms_of_terminal):
6812 * textprop.c (syms_of_textprop):
6813 * undo.c (syms_of_undo):
6814 * w32.c (globals_of_w32):
6815 * window.c (syms_of_window):
6816 * xdisp.c (syms_of_xdisp):
6817 * xfaces.c (syms_of_xfaces):
6818 * xfns.c (syms_of_xfns):
6819 * xmenu.c (syms_of_xmenu):
6820 * xsettings.c (syms_of_xsettings):
6821 * xterm.c (syms_of_xterm): Use DEFSYM.
6823 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6825 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6827 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6829 Integer and buffer overflow fixes (Bug#8873).
6831 * print.c (printchar, strout): Check for string overflow.
6832 (PRINTPREPARE, printchar, strout):
6833 Don't set size unless allocation succeeds.
6835 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6836 for sizes. Check for string overflow more accurately.
6837 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6839 * macros.c: Integer and buffer overflow fixes.
6840 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6841 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6842 Use ptrdiff_t, not int, for sizes.
6843 Don't increment bufsize until after realloc succeeds.
6844 Check for size-calculation overflow.
6845 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6847 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6849 * lread.c: Integer overflow fixes.
6850 (read_integer): Radix is now EMACS_INT, not int,
6851 to improve quality of diagnostics for out-of-range radices.
6852 Calculate buffer size correctly for out-of-range radices.
6853 (read1): Check for integer overflow in radices, and in
6854 read-circle numbers.
6855 (read_escape): Avoid int overflow.
6856 (Fload, openp, read_buffer_size, read1)
6857 (substitute_object_recurse, read_vector, read_list, map_obarray):
6858 Use ptrdiff_t, not int, for sizes.
6859 (read1): Use EMACS_INT, not int, for sizes.
6860 Check for size overflow.
6862 * image.c (cache_image): Check for size arithmetic overflow.
6864 * lread.c: Integer overflow issues.
6865 (saved_doc_string_size, saved_doc_string_length)
6866 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6867 Now ptrdiff_t, not int.
6868 (read1): Don't assume doc string length fits in int. Check for
6869 out-of-range doc string lengths.
6870 (read_list): Don't assume file position fits in int.
6871 (read_escape): Check for hex character overflow.
6873 2011-06-22 Leo Liu <sdl.web@gmail.com>
6875 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6876 Move to minibuffer.el.
6878 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6880 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6881 The following patches are for when GLYPH_DEBUG && !XASSERT.
6882 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6883 * dispnew.c (flush_stdout):
6884 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6885 Mark as externally visible.
6886 * dispnew.c (check_window_matrix_pointers): Now static.
6887 * dispnew.c (window_to_frame_vpos):
6888 * xfns.c (unwind_create_frame):
6889 * xterm.c (x_check_font): Remove unused local.
6890 * scroll.c (CHECK_BOUNDS):
6891 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6892 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6893 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6894 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6895 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6897 (debug_method_add): Use va_list and vsprintf rather than relying
6898 on undefined behavior with wrong number of arguments.
6899 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6900 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6901 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6902 since we're not interested in debugging glyphs with old libraries.
6903 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6904 GCC 4.6.0's static checking.
6906 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6908 Integer overflow and signedness fixes (Bug#8873).
6909 A few related buffer overrun fixes, too.
6911 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6913 * dispextern.h (struct face.stipple):
6914 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6915 (x_bitmap_mask, x_allocate_bitmap_record)
6916 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6917 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6918 (x_create_bitmap_from_xpm_data):
6919 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6920 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6922 * xfaces.c (load_pixmap):
6923 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6924 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6925 (.bitmaps_last, struct x_output.icon_bitmap):
6926 Use ptrdiff_t, not int, for bitmap indexes.
6927 (x_allocate_bitmap_record): Check for size overflow.
6928 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6930 Use ptrdiff_t, not int, for overlay counts.
6931 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6932 * editfns.c (overlays_around, get_pos_property):
6933 * textprop.c (get_char_property_and_overlay):
6934 * xdisp.c (next_overlay_change, note_mouse_highlight):
6935 * xfaces.c (face_at_buffer_position):
6936 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6937 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6938 (Fnext_overlay_change, Fprevious_overlay_change)
6939 (mouse_face_overlay_overlaps, Foverlays_in):
6940 Use ptrdiff_t, not int, for sizes.
6941 (overlays_at, overlays_in): Check for size-calculation overflow.
6943 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6945 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6946 (x_session_initialize): Do not assume string length fits in int.
6948 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6949 This is unlikely, but can occur if DPI is outlandish.
6951 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6952 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6954 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6955 * xrdb.c (magic_file_p, search_magic_path):
6956 Omit last arg SUFFIX; it was always 0. All callers changed.
6957 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6959 * xfont.c (xfont_match): Avoid need for strlen.
6961 * xfns.c: Don't assume strlen fits in int.
6962 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6964 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6965 not unsigned long, as we prefer signed integers. All callers changed.
6966 Detect integer overflow in repeat count.
6967 (message_dolog): Don't assume print length fits in 39 bytes.
6968 (display_mode_element): Don't assume strlen fits in int.
6970 * termcap.c: Don't assume sizes fit in int and never overflow.
6971 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6972 (gobble_line): Check for size-calculation overflow.
6974 * minibuf.c (Fread_buffer):
6975 * lread.c (intern, intern_c_string):
6976 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6977 Don't assume string length fits in int.
6979 * keyboard.c (parse_tool_bar_item):
6980 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6982 * font.c: Don't assume string length fits in int.
6983 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6984 Use ptrdiff_t, not int.
6985 (font_intern_prop): Don't assume string length fits in int.
6986 Don't assume integer property fits in fixnum.
6987 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6989 * filelock.c: Fix some buffer overrun and integer overflow issues.
6990 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6991 Reformulate so as not to need the command string.
6992 Invoke gzip -cd rather than gunzip, as it's more portable.
6993 (lock_info_type, lock_file_1, lock_file):
6994 Don't assume pid_t and time_t fit in unsigned long.
6995 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6996 (current_lock_owner): Prefer signed type for sizes.
6997 Use memcpy, not strncpy, where memcpy is what is really wanted.
6998 Don't assume (via atoi) that time_t and pid_t fit in int.
6999 Check for time_t and/or pid_t out of range, e.g., via a network share.
7000 Don't alloca where an auto var works fine.
7002 * fileio.c: Fix some integer overflow issues.
7003 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7004 Don't assume string length fits in int.
7005 (directory_file_name): Don't assume string length fits in long.
7006 (make_temp_name): Don't assume pid fits in int, or that its print
7007 length is less than 20.
7009 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7011 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7013 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7015 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7016 We prefer signed integers, even for size calculations.
7018 * emacs.c: Don't assume string length fits in 'int'.
7019 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7020 (main): Don't invoke strlen when not needed.
7022 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7023 (XD_DEBUG_MESSAGE): Don't waste a byte.
7025 * callproc.c (getenv_internal_1, getenv_internal)
7027 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7029 * lread.c (invalid_syntax): Omit length argument.
7030 All uses changed. This doesn't fix a bug, but it simplifies the
7031 code away from its former Hollerith-constant appearance, and it's
7032 one less 'int' to worry about when looking at integer-overflow issues.
7033 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7035 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7036 This didn't break anything, but it didn't help either.
7037 It's confusing to put a bogus integer in a place where the actual
7038 value does not matter.
7039 (LIST_END_P): Remove unused macro and its bogus comment.
7040 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7042 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7043 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7045 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7046 We prefer signed types, and the value cannot exceed the EMACS_INT
7047 range anyway (because otherwise the length would not be representable).
7048 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7049 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7050 This avoids a GCC warning when WIDE_EMACS_INT.
7052 * indent.c (sane_tab_width): New function.
7053 (current_column, scan_for_column, Findent_to, position_indentation)
7054 (compute_motion): Use it. This is just for clarity.
7055 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7057 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7059 * lisp.h (lint_assume): New macro.
7060 * composite.c (composition_gstring_put_cache):
7061 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7063 * editfns.c, insdel.c:
7064 Omit unnecessary forward decls, to simplify future changes.
7066 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7068 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7070 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7071 Use much-faster test for byte-length change.
7072 Don't assume string byte-length fits in 'int'.
7073 Check that character arg fits in 'int'.
7074 (mapcar1): Declare byte as byte, for clarity.
7076 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7078 * fns.c (concat): Catch string overflow earlier.
7079 Do not rely on integer wraparound.
7081 * dispextern.h (struct it.overlay_strings_charpos)
7082 (struct it.selective): Now EMACS_INT, not int.
7083 * xdisp.c (forward_to_next_line_start)
7084 (back_to_previous_visible_line_start)
7085 (reseat_at_next_visible_line_start, next_element_from_buffer):
7086 Don't arbitrarily truncate the value of 'selective' to int.
7088 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7090 * composite.c: Don't truncate sizes to 'int'.
7091 (composition_gstring_p, composition_reseat_it)
7092 (composition_adjust_point): Use EMACS_INT, not int.
7093 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7094 not EMACS_UINT, for indexes.
7096 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7098 * buffer.c: Include <verify.h>.
7099 (struct sortvec.priority, struct sortstr.priority):
7100 Now EMACS_INT, not int.
7101 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7102 (struct sortstr.size, record_overlay_string)
7103 (struct sortstrlist.size, struct sortlist.used):
7104 Don't truncate size to int.
7105 (record_overlay_string): Check for size-calculation overflow.
7106 (init_buffer_once): Check at compile-time, not run-time.
7108 2011-06-22 Jim Meyering <meyering@redhat.com>
7110 Don't leak an XBM-image-sized buffer
7111 * image.c (xbm_load): Free the image buffer after using it.
7113 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7116 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7117 that Sun C diagnosed.
7118 * fns.c (secure_hash): Fix pointer signedness issue.
7119 * intervals.c (static_offset_intervals): New function.
7120 (offset_intervals): Use it.
7122 2011-06-21 Leo Liu <sdl.web@gmail.com>
7125 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7128 * fns.c (secure_hash): Rename from crypto_hash_function and change
7129 the first arg to accept symbols.
7130 (Fsecure_hash): New primitive.
7131 (syms_of_fns): New symbols.
7133 2011-06-20 Deniz Dogan <deniz@dogan.se>
7135 * process.c (Fset_process_buffer): Clarify return value in
7138 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7140 * dispnew.c (add_window_display_history): Use BVAR.
7142 * xdisp.c (debug_method_add): Use BVAR.
7143 (check_window_end, dump_glyph_matrix, dump_glyph)
7144 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7146 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7149 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7150 check till after the cache is created in init_frame_faces.
7152 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7154 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7156 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7158 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7159 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7160 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7162 Improve buffer-overflow checking (Bug#8873).
7163 * fileio.c (Finsert_file_contents):
7164 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7165 Remove the old (too-loose) buffer overflow checks.
7166 They weren't needed, since make_gap checks for buffer overflow.
7167 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7168 The old code merely checked for Emacs fixnum overflow, and relied
7169 on undefined (wraparound) behavior. The new code avoids undefined
7170 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7172 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7173 Tune. Don't use wider integers than needed. Don't use alloca.
7174 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7176 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7178 * insdel.c, lisp.h (buffer_overflow): New function.
7179 (insert_from_buffer_1, replace_range, replace_range_2):
7180 * insdel.c (make_gap_larger):
7181 * editfns.c (Finsert_char):
7182 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7184 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7186 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7188 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7190 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7191 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7193 * fileio.c: Don't assume EMACS_INT fits in off_t.
7194 (emacs_lseek): New static function.
7195 (Finsert_file_contents, Fwrite_region): Use it.
7196 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7198 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7200 * fns.c: Don't overflow int when computing a list length.
7201 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7202 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7203 truncation on 64-bit hosts. Check for QUIT every
7204 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7205 faster and is responsive enough.
7206 (Flength): Report an error instead of overflowing an integer.
7207 (Fsafe_length): Return a float if the value is not representable
7208 as a fixnum. This shouldn't happen except in contrived situations.
7209 (Fnthcdr, Fsort): Don't assume list length fits in int.
7210 (Fcopy_sequence): Don't assume vector length fits in int.
7212 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7213 (header_size, word_size): New constants.
7214 (allocate_vectorlike): Don't check size overflow here.
7215 (allocate_vector): Check it here instead, since this is the only
7216 caller of allocate_vectorlike that could cause overflow.
7217 Check that the new vector's length is representable as a fixnum.
7219 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7220 The previous code was bogus. For example, next_almost_prime (32)
7221 returned 39, which is undesirable as it is a multiple of 3; and
7222 next_almost_prime (24) returned 25, which is a multiple of 5 so
7223 why was the code bothering to check for multiples of 7?
7225 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7227 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7229 Variadic C functions now count arguments with ptrdiff_t.
7230 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7231 Back then I didn't know that the Emacs coding style prefers signed int.
7232 Also, in the meantime I found a few more instances where arguments
7233 were being counted with int, which may truncate counts on 64-bit
7234 machines, or EMACS_INT, which may be unnecessarily wide.
7235 * lisp.h (struct Lisp_Subr.function.aMANY)
7236 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7237 Arg counts are now ptrdiff_t, not size_t.
7238 All variadic functions and their callers changed accordingly.
7239 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7240 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7241 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7242 * callint.c (Fcall_interactively): Check arg count for overflow,
7243 to avoid potential buffer overrun. Use signed char, not 'int',
7244 for 'varies' array, so that we needn't bother to check its size
7245 calculation for overflow.
7246 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7247 * eval.c (apply_lambda):
7248 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7249 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7250 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7252 * callint.c (Fcall_interactively): Don't use index var as event count.
7254 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7255 * mem-limits.h (SIZE): Remove; no longer used.
7257 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7259 Remove unnecessary casts.
7260 * xterm.c (x_term_init):
7261 * xfns.c (x_set_border_pixel):
7262 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7263 These aren't needed now that we assume ANSI C.
7265 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7266 It's more likely to cause problems (due to unsigned overflow)
7269 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7271 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7273 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7275 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7277 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7279 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7281 GLYPH_CODE_FACE returns EMACS_INT, not int.
7282 * dispextern.h (merge_faces):
7283 * xfaces.c (merge_faces):
7284 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7285 Don't assume EMACS_INT fits in int.
7287 * character.h (CHAR_VALID_P): Remove unused parameter.
7288 * fontset.c, lisp.h, xdisp.c: All uses changed.
7290 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7292 * fns.c (concat): Minor tuning based on overflow analysis.
7293 This doesn't fix any bugs. Use int to hold character, instead
7294 of constantly refetching from Emacs object. Use XFASTINT, not
7295 XINT, for value known to be a character. Don't bother comparing
7296 a single byte to 0400, as it's always less.
7298 * floatfns.c (Fexpt):
7299 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7301 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7304 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7306 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7307 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7308 incorrectly succeed when S was a string, because 4294967386 was
7309 truncated before it was used.
7311 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7312 Otherwise, an out-of-range integer could cause undefined behavior
7315 * composite.c: Use int, not EMACS_INT, for characters.
7316 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7317 EMACS_INT, for values that are known to be in character range.
7318 This doesn't fix any bugs but is the usual style inside Emacs and
7319 may generate better code on 32-bit machines.
7321 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7322 This is for reasons similar to the recent CHAR_STRING fix.
7323 * charset.c (Fencode_char): Check that character arg is actually
7324 a character. Pass an int to ENCODE_CHAR.
7325 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7326 wider than 'int', as a compile-time check to prevent future regressions
7329 * character.c (char_string): Remove unnecessary casts.
7331 Make sure a 64-bit char is never passed to CHAR_STRING.
7332 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7333 by silently ignoring the top 32 bits, allowing some values
7334 that were far too large to be valid characters.
7335 * character.h: Include <verify.h>.
7336 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7337 arguments are no wider than unsigned, as a compile-time check
7338 to prevent future regressions in this area.
7340 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7341 (Fsubst_char_in_region):
7343 * xdisp.c (decode_mode_spec_coding):
7344 Adjust to CHAR_STRING's new requirement.
7345 * editfns.c (Finsert_char, Fsubst_char_in_region):
7346 * fns.c (concat): Check that character args are actually
7347 characters. Without this test, these functions did the wrong
7348 thing with wildly out-of-range values on 64-bit hosts.
7350 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7351 These casts should not be needed on 32-bit hosts, either.
7352 * keyboard.c (read_char):
7353 * lread.c (Fload): Remove casts to unsigned.
7355 * lisp.h (UNSIGNED_CMP): New macro.
7356 This fixes comparison bugs on 64-bit hosts.
7357 (ASCII_CHAR_P): Use it.
7358 * casefiddle.c (casify_object):
7359 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7360 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7361 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7362 * dispextern.h (FACE_FROM_ID):
7363 * keyboard.c (read_char): Use UNSIGNED_CMP.
7365 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7366 not to EMACS_INT, to avoid GCC warning.
7368 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7370 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7371 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7372 isn't needed on 32-bit machines.
7374 * buffer.c (Fgenerate_new_buffer_name):
7375 Use EMACS_INT for count, not int.
7376 (advance_to_char_boundary): Return EMACS_INT, not int.
7378 * data.c (Qcompiled_function): Now static.
7380 * window.c (window_body_lines): Now static.
7382 * image.c (gif_load): Rename local to avoid shadowing.
7384 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7385 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7386 * alloc.c (make_save_value): Integer argument is now of type
7388 (mark_object): Use ptrdiff_t, not int.
7389 * lisp.h (pD): New macro.
7390 * print.c (print_object): Use it.
7392 * alloc.c: Use EMACS_INT, not int, to count objects.
7393 (total_conses, total_markers, total_symbols, total_vector_size)
7394 (total_free_conses, total_free_markers, total_free_symbols)
7395 (total_free_floats, total_floats, total_free_intervals)
7396 (total_intervals, total_strings, total_free_strings):
7397 Now EMACS_INT, not int. All uses changed.
7398 (Fgarbage_collect): Compute overall total using a double, so that
7399 integer overflow is less likely to be a problem. Check for overflow
7400 when converting back to an integer.
7401 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7402 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7403 These were 'int' variables that could overflow on 64-bit hosts;
7404 they were never used, so remove them instead of repairing them.
7405 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7406 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7407 Previously, this ceilinged at INT_MAX, but that doesn't work on
7409 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7411 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7412 (allocate_vectorlike): Check for ptrdiff_t overflow.
7413 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7414 when a (possibly-narrower) signed value would do just as well.
7415 We prefer using signed arithmetic, to avoid comparison confusion.
7417 * alloc.c: Catch some string size overflows that we were missing.
7418 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7419 for convenience in STRING_BYTES_MAX.
7420 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7421 The definition here is exact; the one in lisp.h was approximate.
7422 (allocate_string_data): Check for string overflow. This catches
7423 some instances we weren't catching before. Also, it catches
7424 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7425 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7426 and ptrdiff_t and EMACS_INT are both 64 bits.
7428 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7429 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7430 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7432 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7434 * alloc.c (Fmake_string): Check for out-of-range init.
7436 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7438 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7440 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7442 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7443 xg_get_default_scrollbar_width.
7445 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7446 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7447 (style_changed_cb): Call update_theme_scrollbar_width and call
7448 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7449 all frames (Bug#8505).
7450 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7451 Call gtk_window_set_resizable if HAVE_GTK3.
7452 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7453 and height if HAVE_GTK3 (Bug#8505).
7454 (scroll_bar_width_for_theme): New variable.
7455 (update_theme_scrollbar_width): New function.
7456 (xg_get_default_scrollbar_width): Move code to
7457 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7458 (xg_initialize): Call update_theme_scrollbar_width.
7460 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7462 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7464 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7466 * frame.c (make_frame): Call other_buffer_safely instead of
7469 * window.c (temp_output_buffer_show): Call display_buffer with
7470 second argument Vtemp_buffer_show_specifiers and reset latter
7471 immediately after the call.
7472 (Vtemp_buffer_show_specifiers): New variable.
7473 (auto_window_vscroll_p, next_screen_context_lines)
7474 (Vscroll_preserve_screen_position): Remove leading asterisks from
7477 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7479 Fix minor problems found by GCC 4.6.0 static checking.
7480 * buffer.c (Qclone_number): Remove for now, as it's unused.
7481 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7482 (record_buffer): Remove unused local.
7483 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7484 (set_frame_buffer_list): Remove; unused.
7485 * frame.h (other_visible_frames): Remove decl.
7486 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7487 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7488 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7490 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7491 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7492 Define only if HAVE_GPM.
7493 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7494 (update_hints_inhibit): Remove; never set. All uses removed.
7495 * widgetprv.h (emacsFrameClassRec): Remove decl.
7496 * window.c (delete_deletable_window): Now returns void, since it
7497 wasn't returning anything.
7498 (compare_window_configurations): Remove unused locals.
7499 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7500 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7501 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7502 the same widths as pointers. This follows up on the 2011-05-06 patch.
7503 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7504 * xterm.h: Likewise.
7505 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7507 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7509 * makefile.w32-in: Update dependencies.
7510 (LISP_H): Add lib/intprops.h.
7512 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7514 * image.c (gif_load): Add animation frame delay to the metadata.
7515 (syms_of_image): Use DEFSYM. New symbol `delay'.
7517 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7519 * window.c (delete_deletable_window): Re-add.
7520 (Fset_window_configuration): Rewrite to handle dead buffers and
7521 consequently deletable windows.
7522 (window_tree, Fwindow_tree): Remove. Supply functionality in
7524 (compare_window_configurations): Simplify code.
7526 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7528 * image.c (imagemagick_load_image): Fix type mismatch.
7529 (Fimagemagick_types): Likewise.
7531 * window.h (replace_buffer_in_windows): Declare.
7533 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7535 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7536 Qclone_number. Remove external declaration of Qdelete_window.
7537 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7539 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7540 Run Qbuffer_list_update_hook if allowed.
7541 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7542 buffer list implementation.
7543 (other_buffer_safely): New function.
7544 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7545 calls to replace_buffer_in_windows and
7546 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7548 (record_buffer): Inhibit quitting and rewrite using quittable
7549 functions. Run Qbuffer_list_update_hook if allowed.
7550 (Frecord_buffer, Funrecord_buffer): New functions.
7551 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7552 Move switch-to-buffer to window.el.
7553 (bury-buffer): Move to window.el.
7554 (Vbuffer_list_update_hook): New variable.
7556 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7559 * window.h (resize_frame_windows): Move up in code.
7560 (Fwindow_frame): Remove EXFUN.
7561 (replace_buffer_in_all_windows): Remove prototype.
7562 (replace_buffer_in_windows_safely): Add prototype.
7564 * window.c: Declare Qdelete_window static again. Move down
7565 declaration of select_count.
7566 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7567 (Fother_window): Move to window.el.
7568 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7569 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7570 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7572 (replace_buffer_in_windows): Implement by calling
7573 Qreplace_buffer_in_windows.
7574 (replace_buffer_in_all_windows): Remove with some functionality
7575 moved into replace_buffer_in_windows_safely.
7576 (replace_buffer_in_windows_safely): New function.
7577 (select_window_norecord, select_frame_norecord): Move in front
7578 of run_window_configuration_change_hook. Remove now obsolete
7580 (Fset_window_buffer): Rewrite doc-string.
7581 Call Qrecord_window_buffer.
7582 (keys_of_window): Move binding for other-window to window.el.
7584 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7586 * dispextern.h (struct image): Replace data member, whose int_val
7587 and ptr_val fields were not used by anything, with a single
7590 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7591 (gif_clear_image, gif_load, imagemagick_load_image)
7592 (gs_clear_image, gs_load): Callers changed.
7594 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7596 * buffer.h: Include <time.h>, for time_t.
7597 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7599 Fix minor problems found by static checking.
7601 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7603 Make identifiers static if they are not used in other modules.
7604 * data.c (Qcompiled_function, Qframe, Qvector):
7605 * image.c (QimageMagick, Qsvg):
7606 * minibuf.c (Qmetadata):
7607 * window.c (resize_window_check, resize_root_window): Now static.
7608 * window.h (resize_window_check, resize_root_window): Remove decls.
7610 * window.c (window_deletion_count, delete_deletable_window):
7612 (window_body_lines): Now static.
7613 (Fdelete_other_windows_internal): Mark vars as initialized.
7614 Make sure 'resize_failed' is initialized.
7615 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7616 (resize_window_apply): Remove unused local.
7617 * window.h (delete_deletable_window): Remove decl.
7619 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7620 (imagemagick_load_image): Fix pointer signedness problem by changing
7621 last arg from unsigned char * to char *. All uses changed.
7622 Also, fix a local for similar reasons.
7623 Remove unused locals. Remove locals to avoid shadowing.
7624 (fn_rsvg_handle_free): Remove; unused.
7625 (svg_load, svg_load_image): Fix pointer signedness problem.
7626 (imagemagick_load_image): Don't use garbage pointer image_wand.
7628 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7630 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7632 * image.c (gif_load): Fix omitted cast error introduced by
7635 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7637 * window.h (resize_proportionally, orig_total_lines)
7638 (orig_top_line): Remove from window structure.
7639 (set_window_height, set_window_width, change_window_heights)
7640 (Fdelete_window): Remove prototypes.
7641 (resize_frame_windows): Remove duplicate declaration.
7643 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7645 * window.h (resize_frame_windows, resize_window_check)
7646 (delete_deletable_window, resize_root_window)
7647 (resize_frame_windows): Declare prototypes.
7649 * window.c (resize_window_apply): Make definition be "static" to
7650 match the prototype.
7652 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7654 * window.c: Remove declarations of Qwindow_size_fixed,
7655 window_min_size_1, window_min_size_2, window_min_size,
7656 size_window, window_fixed_size_p, enlarge_window, delete_window.
7657 Remove static from declaration of Qdelete_window, it's
7658 temporarily needed by Fbury_buffer.
7659 (replace_window): Don't assign orig_top_line and
7661 (Fdelete_window, delete_window): Remove. Window deletion is
7662 handled by window.el.
7663 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7664 Replace Fdelete_window calls with calls to Qdelete_window.
7665 (Fdelete_other_windows): Remove. Deleting other windows is
7666 handled by window.el.
7667 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7668 handled in window.el.
7669 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7670 Window minimum sizes are handled in window.el.
7671 (shrink_windows, size_window, set_window_height)
7672 (set_window_width, change_window_heights, window_height)
7673 (window_width, CURBEG, CURSIZE, enlarge_window)
7674 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7675 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7676 handled in window.el.
7677 (make_dummy_parent): Rename to make_parent_window and give it a
7678 second argument horflag.
7679 (make_window): Don't set resize_proportionally any more.
7680 (Fsplit_window): Remove. Windows are split in window.el.
7681 (save_restore_action, save_restore_orig_size)
7682 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7683 Resize mini windows in window.el.
7684 (grow_mini_window, shrink_mini_window): Implement by calling
7685 Qresize_root_window_vertically, resize_window_check and
7686 resize_window_apply.
7687 (saved_window, Fset_window_configuration, save_window_save):
7688 Do not handle orig_top_line, orig_total_lines, and
7689 resize_proportionally.
7690 (window_min_height, window_min_width): Move to window.el.
7691 (keys_of_window): Move bindings for delete-other-windows,
7692 split-window, delete-window and enlarge-window to window.el.
7694 * buffer.c: Temporarily extern Qdelete_window.
7695 (Fbury_buffer): Temporarily call Qdelete_window instead of
7696 Fdelete_window (Fbury_buffer will move to window.el soon).
7698 * frame.c (set_menu_bar_lines_1): Remove code handling
7699 orig_top_line and orig_total_lines.
7701 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7702 set_window_height but set heights directly.
7703 (change_frame_size_1): Use resize_frame_windows.
7705 * xdisp.c (init_xdisp): Don't use set_window_height but set
7708 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7709 Use resize_frame_windows instead of change_window_heights and run
7710 run_window_configuration_change_hook.
7712 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7713 instead of change_window_heights and run
7714 run_window_configuration_change_hook.
7716 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7718 * window.c (replace_window): Rename second argument REPLACEMENT to
7719 NEW. New third argument SETFLAG. Rewrite.
7720 (delete_window, make_dummy_parent): Call replace_window with
7722 (window_list_1): Move down in code.
7723 (run_window_configuration_change_hook): Move set_buffer part
7724 before select_frame_norecord part in order to unwind correctly.
7725 Rename count1 to count.
7726 (recombine_windows, delete_deletable_window, resize_root_window)
7727 (Fdelete_other_windows_internal)
7728 (Frun_window_configuration_change_hook, make_parent_window)
7729 (resize_window_check, resize_window_apply, Fresize_window_apply)
7730 (resize_frame_windows, Fsplit_window_internal)
7731 (Fdelete_window_internal, Fresize_mini_window_internal):
7733 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7735 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7737 * window.h (window): Add some new members to window structure -
7738 normal_lines, normal_cols, new_total, new_normal, clone_number,
7739 splits, nest, prev_buffers, next_buffers.
7740 (WINDOW_TOTAL_SIZE): Move here from window.c.
7741 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7743 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7745 (make_dummy_parent): Set new members of windows structure.
7746 (make_window): Move down in code. Handle new members of window
7748 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7749 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7750 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7751 (Fset_window_prev_buffers, Fwindow_next_buffers)
7752 (Fset_window_next_buffers, Fset_window_clone_number):
7754 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7755 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7757 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7758 Argument WINDOW can be now internal window too.
7759 (Fwindow_use_time): Move up in code.
7760 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7762 (Fset_window_configuration, saved_window)
7763 (Fcurrent_window_configuration, save_window_save): Handle new
7764 members of window structure.
7765 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7766 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7767 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7768 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7769 Qget_mru_window, Qresize_root_window,
7770 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7771 Qauto_buffer_name; staticpro them.
7773 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7775 * window.c (Fwindow_total_size, Fwindow_left_column)
7776 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7777 (Fwindow_list_1): New functions.
7778 (window_box_text_cols): Replace with window_body_cols.
7779 (Fwindow_width, Fscroll_left, Fscroll_right):
7780 Use window_body_cols instead of window_box_text_cols.
7781 (delete_window, Fset_window_configuration):
7782 Call delete_all_subwindows with window as argument.
7783 (delete_all_subwindows): Take a window as argument and not a
7785 (window_loop): Remove handling of GET_LRU_WINDOW and
7787 (Fget_lru_window, Fget_largest_window): Move to window.el.
7789 * window.h: Extern window_body_cols instead of
7790 window_box_text_cols. delete_all_subwindows now takes a
7791 Lisp_Object as argument.
7793 * indent.c (compute_motion, Fcompute_motion):
7794 Use window_body_cols instead of window_box_text_cols.
7796 * frame.c (delete_frame): Call delete_all_subwindows with root
7799 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7801 * fns.c (Fputhash): Document return value.
7803 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7805 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7807 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7809 Cons<->int and similar integer overflow fixes (Bug#8794).
7811 Check for overflow when converting integer to cons and back.
7812 * charset.c (Fdefine_charset_internal, Fdecode_char):
7813 Use cons_to_unsigned to catch overflow.
7814 (Fencode_char): Use INTEGER_TO_CONS.
7815 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7816 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7817 * data.c (long_to_cons, cons_to_long): Remove.
7818 (cons_to_unsigned, cons_to_signed): New functions.
7819 These signal an error for invalid or out-of-range values.
7820 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7821 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7822 * font.c (Ffont_variation_glyphs):
7823 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7824 * lisp.h: Include <intprops.h>.
7825 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7826 (cons_to_signed, cons_to_unsigned): New decls.
7827 (long_to_cons, cons_to_long): Remove decls.
7828 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7829 (Fprimitive_undo): Use CONS_TO_INTEGER.
7830 * xfns.c (Fx_window_property): Likewise.
7831 * xselect.c: Include <limits.h>.
7832 (x_own_selection, selection_data_to_lisp_data):
7833 Use INTEGER_TO_CONS.
7834 (x_handle_selection_request, x_handle_selection_clear)
7835 (x_get_foreign_selection, Fx_disown_selection_internal)
7836 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7837 (lisp_data_to_selection_data): Use cons_to_unsigned.
7838 (x_fill_property_data): Use cons_to_signed.
7839 Report values out of range.
7841 Check for buffer and string overflow more precisely.
7842 * buffer.h (BUF_BYTES_MAX): New macro.
7843 * lisp.h (STRING_BYTES_MAX): New macro.
7844 * alloc.c (Fmake_string):
7845 * character.c (string_escape_byte8):
7846 * coding.c (coding_alloc_by_realloc):
7847 * doprnt.c (doprnt):
7848 * editfns.c (Fformat):
7850 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7851 since they may not be the same number.
7852 * editfns.c (Finsert_char):
7853 * fileio.c (Finsert_file_contents):
7854 Likewise for BUF_BYTES_MAX.
7856 * image.c: Use ptrdiff_t, not int, for sizes.
7857 (slurp_file): Switch from int to ptrdiff_t.
7859 (slurp_file): Check that file size fits in both size_t (for
7860 malloc) and ptrdiff_t (for sanity and safety).
7862 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7863 if b->modtime has its maximal value.
7865 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7867 Don't assume time_t can fit into int.
7868 * buffer.h (struct buffer.modtime): Now time_t, not int.
7869 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7870 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7872 Minor fixes for signed vs unsigned integers.
7873 * character.h (MAYBE_UNIFY_CHAR):
7874 * charset.c (maybe_unify_char):
7875 * keyboard.c (read_char, reorder_modifiers):
7876 XINT -> XFASTINT, since the integer must be nonnegative.
7877 * ftfont.c (ftfont_spec_pattern):
7878 * keymap.c (access_keymap, silly_event_symbol_error):
7879 XUINT -> XFASTINT, since the integer must be nonnegative.
7880 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7881 since it makes no difference and we prefer signed.
7882 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7883 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7886 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7888 * window.h (Fwindow_frame): Declare.
7890 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7892 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7893 (SPARE_MEMORY): Always define.
7894 (LARGE_REQUEST): Remove.
7895 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7897 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7899 * lisp.h: Move EXFUNS for Fframe_root_window,
7900 Fframe_first_window and Fset_frame_selected_window to window.h.
7902 * window.h: Move EXFUNS for Fframe_root_window,
7903 Fframe_first_window and Fset_frame_selected_window here from
7906 * frame.c (Fwindow_frame, Fframe_first_window)
7907 (Fframe_root_window, Fframe_selected_window)
7908 (Fset_frame_selected_window): Move to window.c.
7909 (Factive_minibuffer_window): Move to minibuf.c.
7910 (Fother_visible_frames_p): New function.
7912 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7914 * window.c (decode_window, decode_any_window): Move up in code.
7915 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7916 (inhibit_frame_unsplittable): Remove unused variable.
7917 (Fwindow_buffer): Move up and rewrite doc-string.
7918 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7919 (Fwindow_prev): New functions.
7920 (Fwindow_frame): Move here from frame.c. Accept any window as
7922 (Fframe_root_window, Fframe_first_window)
7923 (Fframe_selected_window): Move here from frame.c. Accept frame
7924 or arbitrary window as argument. Update doc-strings.
7925 (Fminibuffer_window): Move up in code.
7926 (Fwindow_minibuffer_p): Move up in code and simplify.
7927 (Fset_frame_selected_window): Move here from frame.c.
7929 (Fselected_window, select_window, Fselect_window): Move up in
7930 code. Minor doc-string fixes.
7932 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7934 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7935 Do not assume that spare memory exists; that assumption is valid
7936 only if SYSTEM_MALLOC.
7937 (LARGE_REQUEST): New macro, so that the issue of large requests
7938 is separated from the issue of spare memory.
7940 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7942 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7945 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7947 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7950 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7952 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7954 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7956 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7957 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7959 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7961 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7963 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7965 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7966 (x_clipboard_manager_save): Add return value.
7967 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7969 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7970 Obey Vx_select_enable_clipboard_manager. Catch errors in
7971 x_clipboard_manager_save (Bug#8779).
7972 (Vx_select_enable_clipboard_manager): New variable.
7973 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7975 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7977 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7979 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7981 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7982 in the current matrix if keep_current_p is non-zero.
7984 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7986 * bidi.c (bidi_level_of_next_char): Fix last change.
7988 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7990 Support bidi reordering of text covered by display properties.
7992 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7993 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7994 (bidi_cache_search, bidi_cache_iterator_state)
7995 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7996 (bidi_level_of_next_char, bidi_move_to_visually_next):
7997 Support character positions inside a run of characters covered by a
7999 (bidi_paragraph_init, bidi_resolve_explicit_1)
8000 (bidi_level_of_next_char): Call bidi_fetch_char and
8001 bidi_fetch_char_advance instead of FETCH_CHAR and
8003 (bidi_init_it): Initialize new members.
8004 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8006 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8007 instead of using explicit *_CHAR codes.
8008 (bidi_resolve_explicit, bidi_resolve_weak):
8009 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8010 bidirectional text is supported only in multibyte buffers.
8011 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8012 it to initialize the frame_window_p member of struct bidi_it.
8013 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8014 (bidi_resolve_explicit, bidi_resolve_weak)
8015 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8016 bidi_it->nchars is non-positive.
8017 (bidi_level_of_next_char): Don't try to lookup the cache for the
8018 next/previous character if nothing is cached there yet, or if we
8019 were just reseat()'ed to a new position.
8021 * xdisp.c (set_cursor_from_row): Set start and stop points
8022 according to the row's direction when priming the loop that looks
8023 for the glyph on which to display cursor.
8024 (single_display_spec_intangible_p): Function deleted.
8025 (display_prop_intangible_p): Reimplement to call
8026 handle_display_spec instead of single_display_spec_intangible_p.
8027 Accept 3 additional arguments needed by handle_display_spec.
8028 This fixes incorrect cursor motion across display property with complex
8029 values: lists, `(when COND...)' forms, etc.
8030 (single_display_spec_string_p): Support property values that are
8031 lists with the argument STRING its top-level element.
8032 (display_prop_string_p): Fix the condition for processing a
8033 property that is a list to be consistent with handle_display_spec.
8034 (handle_display_spec): New function, refactored from the
8035 last portion of handle_display_prop.
8036 (compute_display_string_pos): Accept additional argument
8037 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8038 value of a `display' property is a "replacing spec".
8039 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8040 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8041 the display property, but just return a value indicating whether
8042 the display property will replace the characters it covers.
8043 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8044 frame_window_p members of struct bidi_it.
8045 (compute_display_string_pos, compute_display_string_end):
8047 (push_it): Accept second argument POSITION, where pop_it should
8048 jump to continue iteration.
8049 (reseat_1): Initialize bidi_it.disp_pos.
8051 * keyboard.c (adjust_point_for_property): Adjust the call to
8052 display_prop_intangible_p to its new signature.
8054 * dispextern.h (struct bidi_it): New member frame_window_p.
8055 (bidi_init_it): Update prototypes.
8056 (display_prop_intangible_p): Update prototype.
8057 (compute_display_string_pos, compute_display_string_end):
8059 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8062 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8064 Malloc failure behavior now depends on size of allocation.
8065 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8066 * lisp.h: Change signatures accordingly.
8067 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8068 All callers changed. (Bug#8762)
8070 * gnutls.c: Use Emacs's memory allocators.
8071 Without this change, the gnutls library would invoke malloc etc.
8072 directly, which causes problems on non-SYNC_INPUT hosts, and which
8073 runs afoul of improving memory_full behavior. (Bug#8761)
8074 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8075 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8076 xfree instead of the default malloc, realloc, free.
8077 (Fgnutls_boot): No need to check for memory allocation failure,
8078 since xmalloc does that for us.
8080 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8081 * category.c (hash_get_category_set):
8082 * ccl.c (ccl_driver):
8083 * charset.c (Fdefine_charset_internal):
8084 * charset.h (struct charset.hash_index):
8085 * composite.c (get_composition_id, gstring_lookup_cache)
8086 (composition_gstring_put_cache):
8087 * composite.h (struct composition.hash_index):
8088 * dispextern.h (struct image.hash):
8089 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8090 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8091 (hashfn_equal, hashfn_user_defined, make_hash_table)
8092 (maybe_resize_hash_table, hash_lookup, hash_put)
8093 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8094 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8095 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8096 * image.c (make_image, search_image_cache, lookup_image)
8097 (xpm_put_color_table_h):
8098 * lisp.h (struct Lisp_Hash_Table):
8099 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8100 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8101 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8102 * alloc.c (allocate_vectorlike):
8103 Check for overflow in vector size calculations.
8104 * ccl.c (ccl_driver):
8105 Check for overflow when converting EMACS_INT to int.
8106 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8107 need to be updated by these changes.
8108 * fns.c (make_hash_table, maybe_resize_hash_table):
8109 Check for integer overflow with large hash tables.
8110 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8111 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8112 (SXHASH_REDUCE): New macro.
8113 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8114 Use it instead of discarding useful hash info with large hash values.
8115 (sxhash_float): New function.
8116 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8117 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8118 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8119 Rewrite to use FIXNUM_BITS, as this simplifies things.
8120 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8121 Adjust signatures to match updated version of code.
8122 (consing_since_gc): Now EMACS_INT, since a single hash table can
8123 use more than INT_MAX bytes.
8125 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8127 Make it possible to build with GCC-4.6+ -O2 -flto.
8129 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8131 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8133 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8134 Call minibuffer-inactive-mode.
8136 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8138 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8139 Update dependencies.
8141 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8143 * data.c (init_data): Remove code for UTS, this system is not
8146 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8148 Don't force ./temacs to start in terminal mode.
8150 * frame.c (make_initial_frame): Initialize faces in all cases, not
8151 only when CANNOT_DUMP is defined.
8152 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8154 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8156 * dispnew.c (add_window_display_history): Use const for the string
8157 pointer. Remove declaration, not needed.
8159 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8161 Use 'inline', not 'INLINE'.
8162 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8163 * alloc.c, fontset.c (INLINE): Remove.
8164 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8165 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8166 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8167 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8168 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8170 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8172 Make it possible to run ./temacs.
8174 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8175 syms_of_callproc does the same thing. Remove test for
8176 "initialized", do it in the caller.
8177 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8179 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8181 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8182 (read_minibuf): Use get_minibuffer.
8183 (syms_of_minibuf): Use DEFSYM.
8184 (Qmetadata): New var.
8185 * data.c (Qbuffer): Don't make it static.
8186 (syms_of_data): Use DEFSYM.
8188 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8190 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8191 (CCL_CODE_MIN): New macro.
8193 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8195 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8197 * eval.c (Qdebug): Now static.
8198 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8199 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8200 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8202 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8204 * image.c: Various fixes to ImageMagick code comments.
8205 (Fimagemagick_types): Doc fix.
8207 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8209 Minor fixes prompted by GCC 4.6.0 warnings.
8211 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8213 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8214 (x_clipboard_manager_save_all): Move extern decl to ...
8215 * xterm.h: ... here, so that it can be checked for consistency.
8217 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8219 * xselect.c (x_clipboard_manager_save_frame)
8220 (x_clipboard_manager_save_all): New functions.
8221 (Fx_clipboard_manager_save): Lisp function deleted.
8223 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8224 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8226 * xterm.h: Update prototype.
8228 2011-05-28 William Xu <william.xwl@gmail.com>
8230 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8233 2011-05-28 Jim Meyering <meyering@redhat.com>
8235 Avoid a sign-extension bug in crypto_hash_function.
8236 * fns.c (to_uchar): Define.
8237 (crypto_hash_function): Use it to convert some newly-signed
8238 variables to unsigned, to avoid sign-extension bugs. For example,
8239 without this change, (md5 "truc") would evaluate to
8240 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8241 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8242 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8244 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8246 Integer overflow fixes.
8248 * dbusbind.c: Serial number integer overflow fixes.
8249 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8250 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8251 to hold a serial number that is too large for a fixnum.
8252 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8253 Check for serial numbers out of range. Decode any serial number
8254 that was so large that it became a float. (Bug#8722)
8256 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8257 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8258 Use XFASTINT rather than XUINT when numbers are nonnegative.
8259 (xd_append_arg, Fdbus_method_return_internal):
8260 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8261 arguments, check that Lisp number is nonnegative, rather than
8262 silently wrapping negative numbers around. (Bug#8722)
8263 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8266 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8268 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8270 ccl: Add integer overflow checks.
8271 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8272 (IN_INT_RANGE): New macros.
8273 (ccl_driver): Use them to check for integer overflow when
8274 decoding a CCL program. Many of the new checks are whether XINT (x)
8275 fits in int; it doesn't always, on 64-bit hosts. The new version
8276 doesn't catch all possible integer overflows, but it's an
8277 improvement. (Bug#8719)
8279 * alloc.c (make_event_array): Use XINT, not XUINT.
8280 There's no need for unsigned here.
8282 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8283 This follows up to the 2011-05-06 change that substituted uintptr_t
8284 for EMACS_INT. This case wasn't caught back then.
8286 Rework Fformat to avoid integer overflow issues.
8287 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8288 now (part of C89). Include <verify.h>.
8289 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8290 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8291 (Fformat): Avoid the prepass trying to compute sizes; it was only
8292 approximate and thus did not catch overflow reliably. Instead, walk
8293 through the format just once, formatting and computing sizes as we go,
8294 checking for integer overflow at every step, and allocating a larger
8295 buffer as needed. Keep track separately whether the format is
8296 multibyte. Keep only the most-recently calculated precision, rather
8297 than them all. Record whether each argument has been converted to
8298 string. Use EMACS_INT, not int, for byte and char and arg counts.
8299 Support field widths and precisions larger than INT_MAX. Avoid
8300 sprintf's undefined behavior with conversion specifications such as %#d
8301 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8302 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8303 formatting out-of-range floating point numbers with int
8306 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8308 * data.c: Avoid integer truncation in expressions involving floats.
8309 * data.c: Include <intprops.h>.
8310 (arith_driver): When there's an integer overflow in an expression
8311 involving floating point, convert the integers to floating point
8312 so that the resulting value does not suffer from catastrophic
8313 integer truncation. For example, on a 64-bit host (* 4
8314 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8315 Do not rely on undefined behavior after integer overflow.
8317 merge count_size_as_multibyte, parse_str_to_multibyte
8318 * character.c, character.h (count_size_as_multibyte):
8319 Rename from parse_str_to_multibyte; all uses changed.
8320 Check for integer overflow.
8321 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8322 since it's now a duplicate of the other. This is more of
8323 a character than a buffer op, so better that it's in character.c.
8324 * fns.c, print.c: Adjust to above changes.
8326 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8328 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8330 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8332 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8333 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8334 (x_clipboard_manager_save): Now static.
8335 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8337 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8338 (crypto_hash_function): Now static.
8339 Fix pointer signedness problems. Avoid unnecessary initializations.
8341 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8343 * termhooks.h (Vselection_alist): Make it terminal-local.
8345 * terminal.c (create_terminal): Initialize it.
8347 * xselect.c: Support for clipboard managers.
8348 (Vselection_alist): Move to termhooks.h as terminal-local var.
8349 (LOCAL_SELECTION): New macro.
8350 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8351 (symbol_to_x_atom): Remove gratuitous arg.
8352 (x_handle_selection_request, lisp_data_to_selection_data)
8353 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8354 (x_own_selection, x_get_local_selection, x_convert_selection):
8355 New arg, specifying work frame. Use terminal-local Vselection_alist.
8356 (some_frame_on_display): Delete unused function.
8357 (Fx_own_selection_internal, Fx_get_selection_internal)
8358 (Fx_disown_selection_internal, Fx_selection_owner_p)
8359 (Fx_selection_exists_p): New optional frame arg.
8360 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8361 (x_handle_selection_clear): Don't treat other terminals with the
8362 same keyboard specially. Use the terminal-local Vselection_alist.
8363 (x_clear_frame_selections): Use Frun_hook_with_args.
8365 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8367 * xterm.h: Add support for those atoms.
8369 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8371 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8372 (converted_selections, conversion_fail_tag): New global variables.
8373 (x_selection_request_lisp_error): Free the above.
8374 (x_get_local_selection): Remove unnecessary code.
8375 (x_reply_selection_request): Args changed; handle arbitrary array
8376 of converted selections stored in converted_selections.
8377 Separate the XChangeProperty and SelectionNotify steps.
8378 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8379 (x_convert_selection): New function.
8380 (x_handle_selection_event): Simplify.
8381 (x_get_foreign_selection): Don't ignore incoming requests while
8382 waiting for an answer; this will fail when we implement
8383 SAVE_TARGETS, and seems unnecessary anyway.
8384 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8385 (Vx_sent_selection_functions): Doc fix.
8387 2011-05-26 Leo Liu <sdl.web@gmail.com>
8389 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8391 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8393 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8395 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8396 for fringe update if it has periodic bitmap.
8397 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8398 and fringe_bitmap_periodic_p.
8400 * fringe.c (get_fringe_bitmap_data): New function.
8401 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8402 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8403 row. Mark glyph row for fringe update if periodicity changed.
8405 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8406 for fringe update unless it has periodic bitmap.
8408 2011-05-25 Kenichi Handa <handa@m17n.org>
8410 * xdisp.c (get_next_display_element): Set correct it->face_id for
8411 a static composition.
8413 2011-05-24 Leo Liu <sdl.web@gmail.com>
8416 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8418 * fns.c (crypto_hash_function, Fsha1): New function.
8419 (Fmd5): Use crypto_hash_function.
8420 (syms_of_fns): Add Ssha1.
8422 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8424 * gnutls.c: Remove unused macros.
8425 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8426 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8427 Remove macros that are defined and never used.
8428 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8430 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8432 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8433 (Fx_get_selection_internal): Minor cleanup.
8434 (Fx_own_selection_internal): Rename arguments for consistency with
8437 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8439 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8441 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8443 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8445 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8447 * dispnew.c (scrolling_window): Don't exclude the case that the
8448 last enabled row in the desired matrix touches the bottom boundary.
8450 2011-05-21 Glenn Morris <rgm@gnu.org>
8452 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8453 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8454 and add some more files.
8456 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8458 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8459 report_file_error introduced by the change from 2011-05-07.
8461 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8463 * systime.h (Time): Define only if emacs is defined.
8464 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8465 where the include path doesn't have X11/X.h by default. See
8466 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8468 2011-05-20 Kenichi Handa <handa@m17n.org>
8470 * composite.c (find_automatic_composition): Fix previous change.
8472 2011-05-20 Glenn Morris <rgm@gnu.org>
8474 * lisp.mk: New file, split from Makefile.in.
8475 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8476 (shortlisp): Remove.
8477 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8479 2011-05-19 Glenn Morris <rgm@gnu.org>
8481 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8482 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8483 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8484 (lisp): Set the order to that of loadup.el.
8485 (shortlisp): Make it a copy of $lisp.
8486 (SOME_MACHINE_LISP): Remove.
8487 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8488 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8490 2011-05-18 Kenichi Handa <handa@m17n.org>
8492 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8493 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8494 (find_automatic_composition): Mostly rewrite for efficiency.
8496 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8498 * makefile.w32-in: Update dependencies.
8500 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8502 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8503 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8505 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8507 Fix some integer overflow issues, such as string length overflow.
8509 * insdel.c (count_size_as_multibyte): Check for string overflow.
8511 * character.c (lisp_string_width): Check for string overflow.
8512 Use EMACS_INT, not int, for string indexes and lengths; in
8513 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8514 the resulting string length overflows an EMACS_INT; instead,
8515 report a string overflow if no precision given. When checking for
8516 precision exhaustion, use a check that cannot possibly have
8517 integer overflow. (Bug#8675)
8518 * character.h (lisp_string_width): Adjust to new signature.
8520 * alloc.c (string_overflow): New function.
8521 (Fmake_string): Use it. This doesn't change behavior, but saves
8522 a few bytes and will simplify future changes.
8523 * character.c (string_escape_byte8): Likewise.
8524 * lisp.h (string_overflow): New decl.
8526 Fixups, following up to the user-interface timestamp change.
8527 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8528 for UI timestamps, instead of unsigned long.
8529 * msdos.c (mouse_get_pos): Likewise.
8530 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8531 * w32gui.h (Time): Define by including "systime.h" rather than by
8532 declaring it ourselves. (Bug#8664)
8534 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8535 * image.c (clear_image_cache): Likewise.
8537 * term.c (term_mouse_position): Don't assume time_t wraparound.
8539 Be more systematic about user-interface timestamps.
8540 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8541 and sometimes 'EMACS_UINT', to represent these timestamps.
8542 This change causes it to use 'Time' uniformly, as that's what X uses.
8543 This makes the code easier to follow, and makes it easier to catch
8544 integer overflow bugs such as Bug#8664.
8545 * frame.c (Fmouse_position, Fmouse_pixel_position):
8546 Use Time, not unsigned long, for user-interface timestamps.
8547 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8548 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8549 * keyboard.h (last_event_timestamp): Likewise.
8550 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8551 * menu.h (xmenu_show): Likewise.
8552 * term.c (term_mouse_position): Likewise.
8553 * termhooks.h (struct input_event.timestamp): Likewise.
8554 (struct terminal.mouse_position_hook): Likewise.
8555 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8556 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8557 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8558 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8560 * menu.h, termhooks.h: Include "systime.h", for Time.
8562 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8563 Don't assume that the difference between two unsigned long values
8564 can fit into an integer. At this point, we know button_down_time
8565 <= event->timestamp, so the difference must be nonnegative, so
8566 there's no need to cast the result if double-click-time is
8567 nonnegative, as it should be; check that it's nonnegative, just in
8568 case. This bug is triggered when events are more than 2**31 ms
8569 apart (about 25 days). (Bug#8664)
8571 * xselect.c (last_event_timestamp): Remove duplicate decl.
8572 (x_own_selection): Remove needless cast to unsigned long.
8574 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8575 that always fit in int. Use a sentinel instead of a counter, to
8576 avoid a temp and to allay GCC's concerns about possible int overflow.
8577 * frame.h (struct frame): Use int for menu_bar_items_used
8578 instead of EMACS_INT, since it always fits in int.
8580 * menu.c (grow_menu_items): Check for int overflow.
8582 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8584 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8585 Before, the code was not consistent. These values cannot exceed
8586 2**31 - 1 so there's no need to make them unsigned.
8587 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8588 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8589 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8591 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8593 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8594 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8595 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8596 presumably because the widths might not match.
8598 * window.c (size_window): Avoid needless test at loop start.
8600 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8602 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8604 2011-05-12 Drew Adams <drew.adams@oracle.com>
8606 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8608 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8610 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8611 `width' to `bar_area_x' and `bar_area_width', respectively.
8612 (x_scroll_run): Take account of fringe background extension.
8614 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8615 Rename local vars `left' and `width' to `bar_area_x' and
8616 `bar_area_width', respectively.
8617 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8618 background extension.
8620 2011-05-10 Jim Meyering <meyering@redhat.com>
8622 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8624 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8626 * image.c (Finit_image_library): Return t for built-in image types,
8627 like pbm and xbm. (Bug#8640)
8629 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8631 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8633 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8635 * w32console.c (Fset_screen_color): Doc fix.
8636 (Fget_screen_color): New function.
8637 (syms_of_ntterm): Defsubr it.
8639 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8640 unlink the temporary file if Fcall_process didn't create it in the
8642 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8643 child process will be redirected to a file specified with `:file'.
8644 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8645 cue to call_process_cleanup not to close that handle.
8647 2011-05-07 Ben Key <bkey76@gmail.com>
8649 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8650 one of two shell specific rules, either bootstrap-temacs-CMD or
8651 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8652 to the previous implementation of the bootstrap-temacs rule.
8653 The bootstrap-temacs-CMD rule is similar to the previous
8654 implementation of the bootstrap-temacs rule except that it
8655 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8658 These changes, along with some changes to nt/configure.bat,
8659 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8660 earlier fix to add support for --cflags and --ldflags options
8661 that include quotes so that it works whether make uses cmd or
8664 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8666 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8667 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8669 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8670 a string. Handle both cases.
8671 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8672 (Fdbus_register_method): Use Qinvalid_function.
8674 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8676 * makefile.w32-in: Update dependencies.
8677 (LISP_H): Add inttypes.h and stdin.h.
8678 (PROCESS_H): Add unistd.h.
8680 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8682 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8683 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8685 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8687 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8689 * term.c (vfatal): Remove stray call to va_end.
8690 It's not needed and the C Standard doesn't allow it here anyway.
8692 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8693 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8695 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8698 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8700 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8702 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8704 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8706 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8708 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8709 * charset.c (Fdefine_charset_internal): Don't initialize
8710 charset.code_space[15]. The value was garbage, on hosts with
8711 32-bit int (Bug#8600).
8713 * lread.c (read_integer): Be more consistent with string-to-number.
8714 Use string_to_number to do the actual conversion; this avoids
8715 rounding errors and fixes some other screwups. Without this fix,
8716 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8717 (digit_to_number): Move earlier, for benefit of read_integer.
8718 Return -1 if the digit is out of range for the base, -2 if it is
8719 not a digit in any supported base. (Bug#8602)
8721 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8723 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8724 to match comment at start of function. This also removes a
8725 GCC warning about overflow in a 32+64-bit port.
8727 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8729 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8730 Reported by Stefan Monnier in
8731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8732 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8733 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8735 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8736 (EMACS_UINTPTR): Likewise, with uintptr_t.
8738 * lisp.h: Prefer 64-bit EMACS_INT if available.
8739 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8740 on 32-bit hosts that have 64-bit int, so that they can access
8742 However, temporarily disable this change unless the temporary
8743 symbol WIDE_EMACS_INT is defined.
8745 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8747 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8748 This removes an assumption that EMACS_INT and long are the same
8749 width as pointers. The assumption is true for Emacs porting targets
8750 now, but we want to make other targets possible.
8751 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8752 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8753 In the rest of the code, change types of integers that hold casted
8754 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8755 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8756 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8757 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8758 No need to cast type when ORing.
8759 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8760 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8761 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8762 assume EMACS_INT is the same width as char *.
8763 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8764 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8765 Remove no-longer-needed casts.
8766 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8767 (xg_tool_bar_help_callback, xg_make_tool_item):
8768 Use EMACS_INTPTR to hold an integer
8769 that will be cast to void *; this can avoid a GCC warning
8770 if EMACS_INT is not the same width as void *.
8771 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8772 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8773 (current_message_1, set_message_1):
8774 Use a local to convert to proper width without a cast.
8775 * xmenu.c (dialog_selection_callback): Likewise.
8777 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8778 Also, don't assume VALBITS / RAND_BITS is less than 5,
8779 and don't rely on undefined behavior when shifting a 1 left into
8781 * lisp.h (get_random): Change signature to match.
8783 * lread.c (hash_string): Use size_t, not int, for hash computation.
8784 Normally we prefer signed values; but hashing is special, because
8785 it's better to use unsigned division on hash table sizes so that
8786 the remainder is nonnegative. Also, size_t is the natural width
8787 for hashing into memory. The previous code used 'int', which doesn't
8788 retain enough info to hash well into very large tables.
8789 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8791 * dbusbind.c: Don't possibly lose pointer info when converting.
8792 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8793 Use XPNTR rather than XHASH, so that the high-order bits of
8794 the pointer aren't lost when converting through void *.
8796 * eval.c (Fautoload): Don't double-shift a pointer.
8798 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8800 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8802 * gnutls.c (DEF_GNUTLS_FN):
8803 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8805 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8807 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8810 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8812 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8813 New version that can reserve upto 2GB of heap space.
8815 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8817 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8819 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8821 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8822 `gnutls_certificate_set_x509_key_file'.
8824 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8826 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8827 Update dependencies.
8829 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8831 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8832 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8833 Remove unused parameter `fildes'.
8834 * process.c (read_process_output, send_process): Don't pass it.
8836 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8838 Fix previous change: the library cache is defined in w32.c.
8839 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8840 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8842 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8844 Implement dynamic loading of GnuTLS on Windows.
8846 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8847 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8848 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8851 * gnutls.c (Qgnutls_dll): Define.
8852 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8853 (gnutls_*): Declare function pointers.
8854 (init_gnutls_functions): New function to initialize function pointers.
8855 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8856 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8857 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8858 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8859 (emacs_gnutls_write, emacs_gnutls_read)
8860 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8861 (Fgnutls_available_p): New function.
8862 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8863 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8864 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8866 * image.c: Include w32.h.
8867 (Vimage_type_cache): Delete.
8868 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8869 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8870 (w32_delayed_load): Move to w32.c.
8872 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8874 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8875 (w32_delayed_load): Move from image.c. When loading a library, record
8876 its filename in the :loaded-from property of the library id.
8877 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8878 Initialize and staticpro them.
8879 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8881 * process.c: Include lisp.h before w32.h, not after.
8882 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8883 instead of gnutls_record_check_pending.
8885 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8887 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8889 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8890 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8893 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8895 * xterm.c (x_set_frame_alpha): Do not set property on anything
8896 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8898 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8900 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8902 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8904 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8905 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8906 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8907 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8908 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8909 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8910 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8911 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8912 (Qgnutls_bootprop_callbacks_verify): Make static.
8914 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8916 * callproc.c: Indentation fixup.
8918 * sysdep.c (wait_for_termination_1): Make static.
8919 (wait_for_termination, interruptible_wait_for_termination):
8920 Move after wait_for_termination_1.
8922 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8924 * sysdep.c (interruptible_wait_for_termination): New function
8925 which is like wait_for_termination, but allows keyboard
8928 * callproc.c (Fcall_process): Add (:file "file") as an option for
8930 (Fcall_process_region): Ditto.
8932 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8934 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8935 rather than `XVECTOR (FOO)->size'.
8937 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8938 inttypes.h, as a gnulib replacement is used if it not available in
8941 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8943 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8944 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8945 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8947 * coding.c (coding_alloc_by_realloc): Error out if destination
8948 will grow beyond MOST_POSITIVE_FIXNUM.
8949 (decode_coding_emacs_mule): Abort if there isn't enough place in
8950 charbuf for the composition carryover bytes. Reserve an extra
8951 space for up to 2 characters produced in a loop.
8952 (decode_coding_iso_2022): Abort if there isn't enough place in
8953 charbuf for the composition carryover bytes.
8955 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8957 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8958 aborting when %lld or %lll format is passed.
8959 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8960 %llo or %llx format is passed. (Bug#8545)
8962 * window.c (window_scroll_line_based): Use a marker instead of
8963 simple variables to record original value of point. (Bug#7952)
8965 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8966 produced by %s or %c overflows available buffer space. (Bug#8545)
8968 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8970 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8971 (SIZE_MAX): Move defn after all includes, as they might #define it.
8973 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8975 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8977 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8979 * keyboard.c (Qdelayed_warnings_hook): Define.
8980 (command_loop_1): Run `delayed-warnings-hook'
8981 if Vdelayed_warnings_list is non-nil.
8982 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8983 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8985 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8987 * doprnt.c (doprnt): Don't return value smaller than the buffer
8988 size if the message was truncated. (Bug#8545).
8990 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8992 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8993 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8995 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8997 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8999 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9001 * makefile.w32-in: Update dependencies.
9003 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9005 Improve `doprnt' and its usage. (Bug#8545)
9006 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9007 `format_end'. Remove support for %l as a conversion specifier.
9008 Don't use xrealloc. Improve diagnostics when the %l size modifier
9009 is used. Update the commentary.
9011 * eval.c (verror): Simplify calculation of size_t.
9013 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9016 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9018 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9021 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9023 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9024 This makes this file independent of the recent pseudovector change.
9026 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9028 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9030 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9031 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9032 Remove unused local.
9033 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9035 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9036 GCC 4.6.0 optimizes based on type-based alias analysis.
9037 For example, if b is of type struct buffer * and v of type struct
9038 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9039 != &v->size, and therefore "v->size = 1; b->size = 2; return
9040 v->size;" must therefore return 1. This assumption is incorrect
9041 for Emacs, since it type-puns struct Lisp_Vector * with many other
9042 types. To fix this problem, this patch adds a new type struct
9043 vectorlike_header that documents the constraints on layout of vectors
9044 and pseudovectors, and helps optimizing compilers not get fooled
9045 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9046 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9047 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9049 (XSETPVECTYPE): Rewrite in terms of new macro.
9050 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9051 This is a bit clearer, and further avoids the possibility of
9052 undesirable aliasing.
9053 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9054 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9055 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9056 since Lisp_Subr is a special case (no "next" field).
9057 (ASIZE): Now uses header.size rather than size.
9058 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9059 to avoid the hassle of writing XVECTOR (foo)->header.size.
9060 (struct vectorlike_header): New type.
9061 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9062 object, to help avoid aliasing.
9063 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9064 (SUBRP): Likewise, since Lisp_Subr is a special case.
9065 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9066 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9067 (struct Lisp_Hash_Table): Combine first two members into a single
9068 struct vectorlike_header member. All uses of "size" and "next" members
9069 changed to be "header.size" and "header.next".
9070 * buffer.h (struct buffer): Likewise.
9071 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9072 * frame.h (struct frame): Likewise.
9073 * process.h (struct Lisp_Process): Likewise.
9074 * termhooks.h (struct terminal): Likewise.
9075 * window.c (struct save_window_data, struct saved_window): Likewise.
9076 * window.h (struct window): Likewise.
9077 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9078 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9079 * buffer.c (init_buffer_once): Likewise.
9080 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9082 * process.c (Fformat_network_address): Use local var for size,
9085 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9087 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9088 * data.c (atof): Remove decl; no longer used or needed.
9089 (digit_to_number): Move to lread.c.
9090 (Fstring_to_number): Use new string_to_number function, to be
9091 consistent with how the Lisp reader treats infinities and NaNs.
9092 Do not assume that floating-point numbers represent EMACS_INT
9093 without losing information; this is not true on most 64-bit hosts.
9094 Avoid double-rounding errors, by insisting on integers when
9095 parsing non-base-10 numbers, as the documentation specifies.
9096 * lisp.h (string_to_number): New decl, replacing ...
9097 (isfloat_string): Remove.
9098 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9099 (read1): Do not accept +. and -. as integers; this
9100 appears to have been a coding error. Similarly, do not accept
9101 strings like +-1e0 as floating point numbers. Do not report
9102 overflow for integer overflows unless the base is not 10 which
9103 means we have no simple and reliable way to continue.
9104 Break out the floating-point parsing into a new
9105 function string_to_number, so that Fstring_to_number parses
9106 floating point numbers consistently with the Lisp reader.
9107 (digit_to_number): Move here from data.c. Make it static inline.
9108 (E_CHAR, EXP_INT): Remove, replacing with ...
9109 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9110 (string_to_number): New function, replacing isfloat_string.
9111 This function checks for valid syntax and produces the resulting
9112 Lisp float number too. Rework it so that string-to-number
9113 no longer mishandles examples like "1.0e+". Use strtoumax,
9114 so that overflow for non-base-10 numbers is reported only when
9115 there's no portable and simple way to convert to floating point.
9117 * textprop.c (set_text_properties_1): Rewrite for clarity,
9118 and to avoid GCC warning about integer overflow.
9120 * intervals.h (struct interval): Use EMACS_INT for members
9121 where EMACS_UINT might cause problems. See
9122 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9123 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9124 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9126 (offset_intervals): Tell GCC not to worry about length overflow
9127 when negating a negative length.
9129 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9130 (overrun_check_free): Likewise.
9132 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9133 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9136 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9137 (gnutls_make_error): Rename local to avoid shadowing.
9138 (gnutls_emacs_global_deinit): ifdef out; not used.
9139 (Fgnutls_boot): Use const for pointer to readonly storage.
9140 Comment out unused local. Fix pointer signedness problems.
9142 * lread.c (openp): Don't stuff size_t into an 'int'.
9143 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9144 about possible signed overflow.
9146 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9147 (GDK_KEY_g): Don't define if already defined.
9148 (xg_prepare_tooltip): Avoid pointer signedness problem.
9149 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9151 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9152 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9154 * xfns.c (Fx_window_property): Simplify a bit,
9155 to make a bit faster and to avoid GCC 4.6.0 warning.
9156 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9158 * fns.c (internal_equal): Don't assume size_t fits in int.
9160 * alloc.c (compact_small_strings): Tighten assertion a little.
9162 Replace pEd with more-general pI, and fix some printf arg casts.
9163 * lisp.h (pI): New macro, generalizing old pEd macro to other
9164 conversion specifiers. For example, use "...%"pI"d..." rather
9165 than "...%"pEd"...".
9166 (pEd): Remove. All uses replaced with similar uses of pI.
9167 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9168 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9169 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9170 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9171 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9172 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9173 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9175 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9176 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9177 * print.c (safe_debug_print, print_object): Likewise.
9178 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9180 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9181 avoiding the 0 flag, which is not portable.
9182 * process.c (Fmake_network_process): Use pI to avoid cast.
9183 * region-cache.c (pp_cache): Likewise.
9184 * xdisp.c (decode_mode_spec): Likewise.
9185 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9186 behavior on 64-bit hosts with printf arg.
9187 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9188 (x_stop_queuing_selection_requests): Likewise.
9189 (x_get_window_property): Don't truncate byte count to an 'int'
9192 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9193 here, since it parses constructs like leading '-' and spaces,
9194 which are not wanted; and it overflows with large numbers.
9195 Instead, simply match F[0-9]+, which is what is wanted anyway.
9197 * alloc.c: Remove unportable assumptions about struct layout.
9198 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9199 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9200 (allocate_vectorlike, make_pure_vector): Use the new macros,
9201 plus offsetof, to remove unportable assumptions about struct layout.
9202 These assumptions hold on all porting targets that I know of, but
9203 they are not guaranteed, they're easy to remove, and removing them
9204 makes further changes easier.
9206 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9207 This doesn't fix a bug but makes the code clearer.
9208 (string_overrun_cookie): Now const. Use initializers that
9209 don't formally overflow signed char, to avoid warnings.
9210 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9211 can cause Emacs to crash when string overrun checking is enabled.
9212 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9213 multiple of sizeof (EMACS_INT); it need not be, if
9214 alignof(EMACS_INT) < sizeof (EMACS_INT).
9215 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9217 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9219 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9221 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9223 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9224 supposed to be handshaking. (Bug#8556)
9225 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9227 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9229 * lisp.h (Qdebug): List symbol.
9230 * eval.c (Qdebug): Restore global linkage.
9231 * keyboard.c (debug-on-event): New variable.
9232 (handle_user_signal): Break into debugger when debug-on-event
9233 matches the current signal symbol.
9235 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9237 * alloc.c (check_sblock, check_string_bytes)
9238 (check_string_free_list): Convert to standard C.
9240 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9242 * w32.c (emacs_gnutls_push): Fix typo.
9244 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9246 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9247 "cast to pointer from integer of different size".
9249 Improve doprnt and its use in verror. (Bug#8545)
9250 * doprnt.c (doprnt): Document the set of format control sequences
9251 supported by the function. Use SAFE_ALLOCA instead of always
9254 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9255 is one byte too soon. Don't use xrealloc; instead xfree and
9258 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9260 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9263 * gnutls.c: Renamed global_initialized to
9264 gnutls_global_initialized. Added internals for the
9265 :verify-hostname-error, :verify-error, and :verify-flags
9266 parameters of `gnutls-boot' and documented those parameters in the
9267 docstring. Start callback support.
9268 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9269 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9270 on error. Return error code.
9271 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9272 (emacs_gnutls_read): Likewise.
9273 (Fgnutls_boot): Return handshake error code.
9274 (emacs_gnutls_handle_error): New function.
9275 (wsaerror_to_errno): Likewise.
9277 * w32.h (emacs_gnutls_pull): Add prototype.
9278 (emacs_gnutls_push): Likewise.
9280 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9281 (emacs_gnutls_push): Likewise.
9283 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9285 * process.c (wait_reading_process_output): Check if GnuTLS
9286 buffered some data internally if no FDs are set for TLS
9289 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9290 (LIBS): Link to USER_LIBS.
9291 ($(BLD)/gnutls.$(0)): New target.
9293 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9295 * xdisp.c (handle_single_display_spec): Rename the
9296 display_replaced_before_p argument into display_replaced_p, to
9297 make it consistent with the commentary. Fix typos in the
9300 * textprop.c (syms_of_textprop): Remove dead code.
9301 (copy_text_properties): Delete obsolete commentary about an
9302 interface that was deleted long ago. Fix typos in the description
9305 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9306 to changes in oldXMenu/XMenu.h from 2011-04-16.
9307 <menu_help_message, prev_menu_help_message>: Constify.
9308 (IT_menu_make_room): menu->help_text is now `const char **';
9311 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9312 to changes in oldXMenu/XMenu.h from 2011-04-16.
9313 (struct XMenu): Declare `help_text' `const char **'.
9315 * xfaces.c <Qunspecified>: Make extern again.
9317 * syntax.c: Include sys/types.h before including regex.h, as
9320 * doc.c (get_doc_string): Improve the format passed to `error'.
9322 * doprnt.c (doprnt): Improve commentary.
9324 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9326 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9329 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9330 changes in globals.h immediately force recompilation.
9331 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9332 $(CURDIR)/s/ms-w32.h.
9333 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9335 * character.c (Fchar_direction): Function deleted.
9336 (syms_of_character): Don't defsubr it.
9337 <char-direction-table>: Deleted.
9339 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9341 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9342 * doprnt.c: Include limits.h.
9343 (SIZE_MAX): New macro.
9344 (doprnt): Return a size_t value. 2nd arg is now size_t.
9345 Many local variables are now size_t instead of int or unsigned.
9346 Improve overflow protection. Support `l' modifier for integer
9347 conversions. Support %l conversion. Don't assume an EMACS_INT
9348 argument for integer conversions and for %c.
9350 * lisp.h (doprnt): Restore prototype.
9352 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9355 * Makefile.in (base_obj): Add back doprnt.o.
9357 * deps.mk (doprnt.o): Add back prerequisites.
9358 (callint.o): Depend on character.h.
9360 * eval.c (internal_lisp_condition_case): Include the handler
9361 representation in the error message.
9362 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9363 when breaking from the loop.
9365 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9367 * callint.c (Fcall_interactively): When displaying error message
9368 about invalid control letter, pass the character's codepoint, not
9369 a pointer to its multibyte form. Improve display of the character
9370 in octal and display also its hex code.
9372 * character.c (char_string): Use %x to display the (unsigned)
9373 codepoint of an invalid character, to avoid displaying a bogus
9376 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9377 `error', not SYMBOL_NAME itself.
9379 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9380 character arguments to `error'.
9382 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9383 to `error' in error message about FINAL_CHAR argument. Make sure
9384 FINAL_CHAR is a character, and use %c when it is passed as
9385 argument to `error'.
9387 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9389 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9391 * w32.c: Include <time.h>.
9392 (sys_localtime): New function.
9394 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9396 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9398 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9400 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9402 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9405 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9407 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9408 gl_state.e_property when gl_state.object is Qt.
9410 * insdel.c (make_gap_larger): Remove limitation of buffer size
9413 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9415 * xdisp.c (lookup_glyphless_char_display)
9416 (produce_glyphless_glyph): Handle cons cell entry in
9417 glyphless-char-display.
9418 (Vglyphless_char_display): Document it.
9420 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9421 glyphless-char-display.
9423 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9425 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9427 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9429 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9430 definition for no-X builds.
9432 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9434 Static checks with GCC 4.6.0 and non-default toolkits.
9436 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9438 * process.c (keyboard_bit_set): Define only if SIGIO.
9439 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9440 (send_process): Repair possible setjmp clobbering.
9442 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9444 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9446 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9448 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9449 Define only if needed.
9451 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9452 by pacifying GCC about it. Maybe it's time to retire it?
9453 * xfaces.c (USG, __TIMEVAL__): Likewise.
9455 * dispextern.h (struct redisplay_interface): Rename param
9457 * termhooks.h (struct terminal): Likewise.
9458 * xterm.c (xembed_send_message): Likewise.
9460 * insdel.c (make_gap_smaller): Define only if
9461 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9463 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9466 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9467 so that we aren't warned about unused symbols.
9469 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9471 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9473 * xfns.c (x_real_positions): Mark locals as initialized.
9475 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9477 * xterm.c: Fix problems found by static analysis with other toolkits.
9478 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9479 (x_dispatch_event): Declare static if USE_GTK, and
9480 define if USE_GTK || USE_X_TOOLKIT.
9481 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9482 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9483 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9484 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9486 * xmenu.c (menu_help_callback): Pointer type fixes.
9487 Use const pointers when pointing at readonly data. Avoid pointer
9489 (FALSE): Remove unused macro.
9490 (update_frame_menubar): Remove unused decl.
9492 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9494 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9495 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9496 (single_menu_item): Rename local to avoid shadowing.
9498 * keyboard.c (make_lispy_event): Remove unused local var.
9500 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9501 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9503 * bitmaps: Change bitmaps from unsigned char back to the X11
9504 compatible char. Avoid the old compiler warnings about
9505 out-of-range initializers by using, for example, '\xab' rather
9508 * xgselect.c (xgselect_initialize): Check vs interface
9509 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9511 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9513 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9514 to read-only memory.
9516 * fns.c (vector): Remove; this old hack is no longer needed.
9518 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9520 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9522 * xrdb.c (x_load_resources): Omit unused local.
9524 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9525 (x_window): Rename locals to avoid shadowing.
9526 (USG): Use the kludged USG macro, to pacify gcc.
9528 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9529 (x_term_init): Remove local to avoid shadowing.
9531 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9533 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9534 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9536 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9538 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9540 Fix regex.c, syntax.c and friends for buffers > 2GB.
9541 * syntax.h (struct gl_state_s): Declare character position members
9544 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9546 * textprop.c (verify_interval_modification, interval_of):
9547 Declare arguments EMACS_INT.
9549 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9552 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9554 * indent.c (Fvertical_motion): Local variable it_start is now
9557 * regex.c (re_match, re_match_2, re_match_2_internal)
9558 (bcmp_translate, regcomp, regexec, print_double_string)
9559 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9560 (re_compile_pattern, re_exec): Declare arguments and local
9561 variables `size_t' and `ssize_t' and return values `regoff_t', as
9563 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9564 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9565 <compile_stack_type>: `size' and `avail' are now `size_t'.
9567 * regex.h <regoff_t>: Use ssize_t, not int.
9568 (re_search, re_search_2, re_match, re_match_2): Arguments that
9569 specify buffer/string position and length are now ssize_t and
9570 size_t. Return type is regoff_t.
9572 2011-04-16 Ben Key <bkey76@gmail.com>
9574 * nsfont.m: Fixed bugs in ns_get_family and
9575 ns_descriptor_to_entity that were caused by using free to
9576 deallocate memory blocks that were allocated by xmalloc (via
9577 xstrdup). This caused Emacs to crash when compiled with
9578 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9579 --enable-checking=xmallocoverrun). xfree is now used to
9580 deallocate these memory blocks.
9582 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9584 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9586 emacs_write: Accept and return EMACS_INT for sizes.
9587 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9589 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9590 Accept and return EMACS_INT.
9591 (emacs_gnutls_write): Return the number of bytes written on
9593 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9594 (emacs_read, emacs_write): Remove check for negative size, as the
9595 Emacs source code has been audited now.
9596 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9597 (emacs_read, emacs_write): Use it.
9598 * process.c (send_process): Adjust to the new signatures of
9599 emacs_write and emacs_gnutls_write. Do not attempt to store
9600 a byte offset into an 'int'; it might overflow.
9601 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9603 * sound.c: Don't assume sizes fit in 'int'.
9604 (struct sound_device.period_size, alsa_period_size):
9605 Return EMACS_INT, not int.
9606 (struct sound_device.write, vox_write, alsa_write):
9607 Accept EMACS_INT, not int.
9608 (wav_play, au_play): Use EMACS_INT to store sizes and to
9609 record read return values.
9611 2011-04-15 Ben Key <bkey76@gmail.com>
9613 * keyboard.c (Qundefined): Don't declare static since it is used
9615 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9616 static since they are used in nsfont.m.
9618 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9620 * process.c (Qprocessp): Don't declare static.
9621 * lisp.h (Qprocessp): Declare again.
9623 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9625 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9627 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9629 Improve C-level modularity by making more things 'static'.
9631 Don't publish debugger-only interfaces to other modules.
9632 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9633 (verify_bytepos, count_markers): Move decls to the only modules
9635 * region-cache.h (pp_cache): Likewise.
9636 * window.h (check_all_windows): Likewise.
9637 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9639 * sysdep.c (croak): Now static, if
9640 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9641 * syssignal.h (croak): Declare only if not static.
9643 * alloc.c (refill_memory_reserve): Now static if
9644 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9645 * lisp.h (refill_memory_reserve): Declare only if not static.
9647 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9648 Define only if USE_LUCID.
9650 * xrdb.c (x_customization_string, x_rm_string): Now static.
9652 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9653 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9655 * xdisp.c (draw_row_with_mouse_face): Now static.
9656 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9658 * window.h (check_all_windows): Mark externally visible.
9660 * window.c (window_deletion_count): Now static.
9662 * undo.c: Make symbols static if they're not exported.
9663 (last_undo_buffer, last_boundary_position, pending_boundary):
9666 * textprop.c (interval_insert_behind_hooks): Now static.
9667 (interval_insert_in_front_hooks): Likewise.
9669 * term.c: Make symbols static if they're not exported.
9670 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9671 (max_frame_lines, tty_set_terminal_modes):
9672 (tty_reset_terminal_modes, tty_turn_off_highlight):
9673 (get_tty_terminal): Now static.
9674 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9675 * termhooks.h (term_mouse_moveto): Do not declare if
9677 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9678 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9680 * sysdep.c: Make symbols static if they're not exported.
9681 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9683 (sigprocmask_set, full_mask): Remove; unused.
9684 (wait_debugging): Mark as visible.
9685 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9686 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9688 * syntax.c (syntax_temp): Define only if !__GNUC__.
9690 * sound.c (current_sound_device, current_sound): Now static.
9692 * search.c (searchbufs, searchbuf_head): Now static.
9694 * scroll.c (scroll_cost): Remove; unused.
9695 * dispextern.h (scroll_cost): Remove decl.
9697 * region-cache.h (pp_cache): Mark as externally visible.
9699 * process.c: Make symbols static if they're not exported.
9700 (process_tick, update_tick, create_process, chan_process):
9701 (Vprocess_alist, proc_buffered_char, datagram_access):
9702 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9703 (deactivate_process): Mark defn as static, as well as decl.
9704 * lisp.h (create_process): Remove decl.
9705 * process.h (chan_process, Vprocess_alist): Remove decls.
9707 * print.c: Make symbols static if they're not exported.
9708 (print_depth, new_backquote_output, being_printed, print_buffer):
9709 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9710 (print_interval, print_number_index, initial_stderr_stream):
9712 * lisp.h (Fprinc): Remove decl.
9713 (debug_output_compilation_hack): Mark as externally visible.
9715 * sysdep.c (croak): Move decl from here to syssignal.h.
9716 * syssignal.h (croak): Put it here, so the API can be checked when
9717 'croak' is called from dissociate_if_controlling_tty.
9719 * minibuf.c: Make symbols static if they're not exported.
9720 (minibuf_save_list, choose_minibuf_frame): Now static.
9721 * lisp.h (choose_minibuf_frame): Remove decl.
9723 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9725 * lread.c: Make symbols static if they're not exported.
9726 (read_objects, initial_obarray, oblookup_last_bucket_number):
9728 (make_symbol): Remove; unused.
9729 * lisp.h (initial_obarray, make_symbol): Remove decls.
9731 * keyboard.c: Make symbols static if they're not exported.
9732 (single_kboard, recent_keys_index, total_keys, recent_keys):
9733 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9734 (this_single_command_key_start, echoing, last_auto_save):
9735 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9736 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9737 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9738 (Vlispy_mouse_stem, double_click_count):
9740 (force_auto_save_soon): Define only if SIGDANGER.
9741 (ignore_mouse_drag_p): Now static if
9742 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9743 (print_help): Remove; unused.
9744 (stop_character, last_timer_event): Mark as externally visible.
9745 * keyboard.h (ignore_mouse_drag_p): Declare only if
9746 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9747 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9748 * lisp.h (echoing): Remove decl.
9749 (force_auto_save_soon): Declare only if SIGDANGER.
9750 * xdisp.c (redisplay_window): Simplify code, to make it more
9751 obvious that ignore_mouse_drag_p is not accessed if !defined
9752 USE_GTK && !defined HAVE_NS.
9754 * intervals.c: Make symbols static if they're not exported.
9755 (merge_properties_sticky, merge_interval_right, delete_interval):
9757 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9759 * insdel.c: Make symbols static if they're not exported.
9760 However, leave prepare_to_modify_buffer alone. It's never
9761 called from outside this function, but that appears to be a bug.
9762 (combine_after_change_list, combine_after_change_buffer):
9763 (adjust_after_replace, signal_before_change): Now static.
9764 (adjust_after_replace_noundo): Remove; unused.
9765 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9766 (signal_before_change): Remove decls.
9768 * indent.c (val_compute_motion, val_vmotion): Now static.
9770 * image.c: Make symbols static if they're not exported.
9771 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9773 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9774 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9776 * fringe.c (standard_bitmaps): Now static.
9777 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9779 * frame.c: Make symbols static if they're not exported.
9780 (x_report_frame_params, make_terminal_frame): Now static.
9781 (get_frame_param): Now static, unless HAVE_NS.
9782 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9783 (x_get_resource_string): Remove; not used.
9784 * frame.h (make_terminal_frame, x_report_frame_params):
9785 (x_get_resource_string); Remove decls.
9786 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9787 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9789 * font.c, fontset.c: Make symbols static if they're not exported.
9790 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9791 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9792 * font.c (font_close_object): Now static.
9793 * font.h (font_close_object): Remove.
9794 * fontset.c (FONTSET_OBJLIST): Remove.
9795 (free_realized_fontset) #if-0 the body, which does nothing.
9796 (face_suitable_for_char_p): #if-0, as it's never called.
9797 * fontset.h (face_suitable_for_char_p): Remove decl.
9798 * xfaces.c (face_at_string_position):
9799 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9800 since 0 is always ASCII.
9802 * fns.c (weak_hash_tables): Now static.
9804 * fileio.c: Make symbols static if they're not exported.
9805 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9806 (Vwrite_region_annotation_buffers): Now static.
9808 * eval.c: Make symbols static if they're not exported.
9809 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9810 * lisp.h (backtrace_list): Remove decl.
9812 * emacs.c: Make symbols static if they're not exported.
9813 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9814 (fatal_error_code, fatal_error_signal_hook, standard_args):
9816 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9817 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9818 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9819 * lisp.h (fatal_error_signal_hook): Remove decl.
9820 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9822 * editfns.c: Move a (normally-unused) function to its only use.
9823 * editfns.c, lisp.h (get_operating_system_release): Remove.
9824 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9825 worth the hassle of breaking this out.
9827 * xterm.c: Make symbols static if they're not exported.
9828 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9829 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9830 (x_destroy_window, x_delete_display):
9832 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9833 (x_mouse_leave): Remove; unused.
9834 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9835 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9836 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9838 (x_mouse_leave): Declare only if WINDOWSNT.
9839 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9840 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9843 * ftxfont.c: Make symbols static if they're not exported.
9844 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9846 * font.h (ftxfont_driver): Likewise.
9848 * xfns.c: Make symbols static if they're not exported.
9849 (x_last_font_name, x_display_info_for_name):
9850 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9851 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9852 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9853 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9854 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9855 (last_show_tip_args): Now static.
9856 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9857 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9858 (x_screen_planes): Remove; unused.
9859 * dispextern.h (x_screen_planes): Remove decl.
9861 * dispnew.c: Make symbols static if they're not exported.
9862 * dispextern.h (redraw_garbaged_frames, scrolling):
9863 (increment_row_positions): Remove.
9864 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9865 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9867 (redraw_garbaged_frames): Remove; unused.
9869 * xfaces.c: Make symbols static if they're not exported.
9870 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9872 * xterm.h (defined_color): Remove decls.
9873 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9874 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9875 (menu_face_changed_default, defined_color, free_realized_face):
9876 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9877 (ascii_face_of_lisp_face): Remove; unused.
9879 * xdisp.c: Make symbols static if they're not exported.
9880 * dispextern.h (scratch_glyph_row, window_box_edges):
9881 (glyph_to_pixel_coords, set_cursor_from_row):
9882 (get_next_display_element, set_iterator_to_next):
9883 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9884 (show_mouse_face): Remove decls
9885 * frame.h (message_buf_print): Likewise.
9886 * lisp.h (pop_message, set_message, check_point_in_composition):
9888 * xterm.h (set_vertical_scroll_bar): Likewise.
9889 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9890 (message_buf_print, scratch_glyph_row, displayed_buffer):
9891 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9892 (get_next_display_element, show_mouse_face, window_box_edges):
9893 (frame_to_window_pixel_xy, check_point_in_composition):
9894 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9895 (glyph_to_pixel_coords): Remove; unused.
9897 * dired.c (file_name_completion): Now static.
9899 * dbusbind.c (xd_in_read_queued_messages): Now static.
9901 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9902 * data.c (circular_list_error): Remove.
9904 * commands.h (last_point_position, last_point_position_buffer):
9905 (last_point_position_window): Remove decls.
9906 * keyboard.c: Make these variables static.
9908 * coding.h (coding, code_convert_region, encode_coding_gap):
9910 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9911 (iso_code_class, detect_coding, code_convert_region): Now static.
9912 (encode_coding_gap): Remove; unused.
9914 * chartab.c (chartab_chars, chartab_bits): Now static.
9916 * charset.h (charset_iso_8859_1): Remove decl.
9917 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9920 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9921 * ccl.c (Vccl_program_table): Now static.
9922 (check_ccl_update): Remove; unused.
9924 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9925 * category.h: ... from here.
9926 * category.c (check_category_table, set_category_set): Now static.
9928 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9929 * lisp.h: Remove these decls.
9931 * buffer.c (buffer_count): Remove unused var.
9933 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9934 so that it's not optimized away.
9935 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9936 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9937 exported only to the debugger.
9939 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9940 * atimer.h (run_all_atimers): Remove; not exported.
9942 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9943 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9944 was inaccessible from Lisp.
9945 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9946 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9948 alloc.c: Import and export fewer symbols, and remove unused items.
9949 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9951 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9952 it's not optimized away by whole-program optimization.
9953 (message_enable_multibyte, free_misc): Remove.
9954 (catchlist, handlerlist, mark_backtrace):
9955 Declare only if BYTE_MARK_STACK.
9956 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9957 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9958 (message_enable_multibyte): Remove decl.
9959 (free_misc, interval_free_list, float_block, float_block_index):
9960 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9961 (cons_free_list, last_marked_index):
9963 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9964 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9965 (mark_backtrace): Define only if BYTE_MARK_STACK.
9966 * xdisp.c (message_enable_multibyte): Now static.
9968 Declare Lisp_Object Q* variables to be 'static' if not exported.
9969 This makes it easier for human readers (and static analyzers)
9970 to see whether these variables are used from other modules.
9971 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9972 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9973 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9974 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9975 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9976 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9977 * xmenu.c, xselect.c:
9978 Declare Q* vars static if they are not used in other modules.
9979 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9980 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9981 Remove decls of unexported vars.
9982 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9984 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9986 Make Emacs functions such as Fatom 'static' by default.
9987 This makes it easier for human readers (and static analyzers)
9988 to see whether these functions can be called from other modules.
9989 DEFUN now defines a static function. To make the function external
9990 so that it can be used in other C modules, use the new macro DEFUE.
9991 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9992 (Finit_image_library):
9993 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9994 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9995 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9996 Remove decls, since these functions are now static.
9997 (Funintern, Fget_internal_run_time): New decls, since these functions
9998 were already external.
10000 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10001 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10002 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10003 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10004 * keyboard.c, keymap.c, lread.c:
10005 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10006 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10007 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10008 Mark functions with DEFUE instead of DEFUN,
10009 if they are used in other modules.
10010 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10011 decls for now-static functions.
10012 * buffer.h (Fdelete_overlay): Remove decl.
10013 * callproc.c (Fgetenv_internal): Mark as internal.
10014 * composite.c (Fremove_list_of_text_properties): Remove decl.
10015 (Fcomposition_get_gstring): New forward static decl.
10016 * composite.h (Fcomposite_get_gstring): Remove decl.
10017 * dired.c (Ffile_attributes): New forward static decl.
10018 * doc.c (Fdocumntation_property): New forward static decl.
10019 * eval.c (Ffetch_bytecode): New forward static decl.
10020 (Funintern): Remove extern decl; now in .h file where it belongs.
10021 * fileio.c (Fmake_symbolic_link): New forward static decl.
10022 * image.c (Finit_image_library): New forward static decl.
10023 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10024 * intervals.h (Fprevious_property_change):
10025 (Fremove_list_of_text_properties): Remove decls.
10026 * keyboard.c (Fthis_command_keys): Remove decl.
10027 (Fcommand_execute): New forward static decl.
10028 * keymap.c (Flookup_key): New forward static decl.
10029 (Fcopy_keymap): Now static.
10030 * keymap.h (Flookup_key): Remove decl.
10031 * process.c (Fget_process): New forward static decl.
10032 (Fprocess_datagram_address): Mark as internal.
10033 * syntax.c (Fsyntax_table_p): New forward static decl.
10034 (skip_chars): Remove duplicate decl.
10035 * textprop.c (Fprevious_property_change): New forward static decl.
10036 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10038 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10039 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10041 * editfns.c (Fformat): Remove unreachable code.
10043 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10045 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10048 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10050 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10051 when at ZV. (Bug#8487)
10053 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10055 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10057 * keyboard.c (parse_tool_bar_item): Likewise.
10058 * sound.c (sound_cleanup, alsa_close): Likewise.
10059 * termcap.c (tgetent): Likewise.
10060 * xfns.c (x_default_font_parameter): Likewise.
10061 * xsettings.c (read_and_apply_settings): Likewise.
10063 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10064 (overrun_check_free): Protoize.
10066 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10068 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10069 since callers should never pass a negative size.
10070 Change the signature to match that of plain 'read' and 'write'; see
10071 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10072 * lisp.h: Update prototypes of emacs_write and emacs_read.
10074 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10076 * xdisp.c (redisplay_window): Don't try to determine the character
10077 position of the scroll margin if the window start point w->startp
10078 is outside the buffer's accessible region. (Bug#8468)
10080 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10082 Fix write-region and its subroutines for buffers > 2GB.
10083 * fileio.c (a_write, e_write): Modify declaration of arguments and
10084 local variables to support buffers larger than 2GB.
10085 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10087 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10088 argument, local variables, and return value.
10090 * lisp.h: Update prototypes of emacs_write and emacs_read.
10092 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10094 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10096 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10098 Fix more problems found by GCC 4.6.0's static checks.
10100 * xdisp.c (vmessage): Use a better test for character truncation.
10102 * charset.c (load_charset_map): <, not <=, for optimization,
10103 and to avoid potential problems with integer overflow.
10104 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10105 * casetab.c (set_identity, shuffle): Likewise.
10106 * editfns.c (Fformat): Likewise.
10107 * syntax.c (skip_chars): Likewise.
10109 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10110 This also lets GCC 4.6.0 generate slightly better loop code.
10112 * callint.c (Fcall_interactively): <, not <=, for optimization.
10113 (Fcall_interactively): Count the number of arguments produced,
10114 not the number of arguments given. This is simpler and lets GCC
10115 4.6.0 generate slightly better code.
10117 * ftfont.c: Distingish more carefully between FcChar8 and char.
10118 The previous code passed unsigned char * to a functions like
10119 strlen and xstrcasecmp that expect char *, which does not
10120 conform to the C standard.
10121 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10122 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10123 char * when the C standard requires it.
10125 * keyboard.c (read_char): Remove unused var.
10127 * eval.c: Port to Windows vsnprintf (Bug#8435).
10128 Include <limits.h>.
10129 (SIZE_MAX): Define if the headers do not.
10130 (verror): Do not give up if vsnprintf returns a negative count.
10131 Instead, grow the buffer. This ports to Windows vsnprintf, which
10132 does not conform to C99. Problem reported by Eli Zaretskii.
10133 Also, simplify the allocation scheme, by avoiding the need for
10134 calling realloc, and removing the ALLOCATED variable.
10136 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10138 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10139 But keep the doprint source code for now, as we might revamp it
10140 and use it again (Bug#8435).
10141 * lisp.h (doprnt): Remove.
10142 * Makefile.in (base_obj): Remove doprnt.o.
10143 * deps.mk (doprnt.o): Remove.
10145 error: Print 32- and 64-bit integers portably (Bug#8435).
10146 Without this change, on typical 64-bit hosts error ("...%d...", N)
10147 was used to print both 32- and 64-bit integers N, which relied on
10148 undefined behavior.
10149 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10150 * lisp.h (error, verror): Mark as printf-like functions.
10151 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10152 Report overflow in size calculations when allocating printf buffer.
10153 Do not truncate output string at its first null byte.
10154 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10155 Truncate the output at a character boundary, since vsnprintf does not
10157 * charset.c (check_iso_charset_parameter): Convert internal
10158 character to string before calling 'error', since %c now has the
10160 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10161 overflow when computing char to be passed to 'error'. Do not
10162 pass Lisp_Object to 'error'; pass the integer instead.
10163 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10164 formatted with plain %d.
10166 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10168 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10170 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10172 * xterm.c (x_catch_errors): Remove duplicate declaration.
10174 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10176 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10178 2011-04-10 Jim Meyering <meyering@redhat.com>
10180 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10181 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10182 return ssize_t not "int", and use size_t as the buffer length.
10183 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10184 * gnutls.h: Update declarations.
10185 * process.c (read_process_output): Use ssize_t, to match.
10186 (send_process): Likewise.
10188 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10190 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10192 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10194 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10195 Use unsigned char, to match FcChar8 type definition.
10197 * xterm.c (handle_one_xevent):
10198 * xmenu.c (create_and_show_popup_menu):
10199 * xselect.c (x_decline_selection_request)
10200 (x_reply_selection_request): Avoid type-punned deref of X events.
10202 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10204 Fix some uses of `int' instead of EMACS_INT.
10205 * search.c (string_match_1, fast_string_match)
10206 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10207 (scan_buffer, find_next_newline_no_quit)
10208 (find_before_next_newline, search_command, Freplace_match)
10209 (Fmatch_data): Make some `int' variables be EMACS_INT.
10211 * xdisp.c (display_count_lines): 3rd argument and return value now
10212 EMACS_INT. All callers changed.
10213 (pint2hrstr): Last argument is now EMACS_INT.
10215 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10216 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10217 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10218 (decode_coding_utf_16, decode_coding_emacs_mule)
10219 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10220 (decode_coding_ccl, decode_coding_charset)
10221 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10222 (decode_coding_iso_2022, decode_coding_emacs_mule)
10223 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10224 <char_offset, last_offset>: Declare EMACS_INT.
10225 (encode_coding_utf_8, encode_coding_utf_16)
10226 (encode_coding_emacs_mule, encode_invocation_designation)
10227 (encode_designation_at_bol, encode_coding_iso_2022)
10228 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10229 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10231 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10232 (encode_invocation_designation): Last argument P_NCHARS is now
10234 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10235 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10237 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10240 * ccl.c (Fccl_execute_on_string): Declare some variables
10243 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10245 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10247 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10249 * process.c (Fformat_network_address): Doc fix.
10251 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10253 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10255 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10257 * keyboard.c (read_char): Call Lisp function help-form-show,
10258 instead of using internal_with_output_to_temp_buffer.
10259 (Qhelp_form_show): New var.
10260 (syms_of_keyboard): Use DEFSYM macro.
10262 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10264 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10266 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10268 * process.c (Flist_processes): Remove to Lisp.
10269 (list_processes_1): Delete.
10271 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10273 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10275 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10277 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10279 Fix more problems found by GCC 4.6.0's static checks.
10281 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10283 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10285 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10287 * xdisp.c (vmessage): Mark as a printf-like function.
10289 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10291 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10293 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10294 printf-like functions.
10295 (tiff_load): Add casts to remove these marks before passing them
10296 to system-supplied API.
10298 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10300 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10301 This avoids several warnings with gcc -Wstrict-overflow.
10302 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10303 directly, rather than having caller test rule sign. This avoids
10304 some unnecessary tests.
10305 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10306 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10307 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10309 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10310 (xfont_open): Avoid unnecessary tests.
10312 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10314 * composite.h, composite.c (composition_gstring_put_cache):
10315 Use EMACS_INT, not int, for length.
10317 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10318 breaking out part of COMPOSITION_DECODE_RULE.
10319 (COMPOSITION_DECODE_RULE): Use it.
10320 * composite.c (get_composition_id): Remove unused local vars,
10321 by using the new macro.
10323 * textprop.c (set_text_properties_1): Change while to do-while,
10324 since the condition is always true at first.
10326 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10327 (interval_deletion_adjustment): Return unsigned value.
10330 * process.c (list_processes_1, create_pty, read_process_output):
10331 (exec_sentinel): Remove vars that were set but not used.
10332 (create_pty): Remove unnecessary "volatile"s.
10333 (Fnetwork_interface_info): Avoid possibility of int overflow.
10334 (read_process_output): Do adaptive read buffering even if carryover.
10335 (read_process_output): Simplify nbytes computation if buffered.
10337 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10339 * syntax.c (scan_words): Remove var that was set but not used.
10340 (update_syntax_table): Use unsigned instead of int.
10342 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10343 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10344 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10346 * print.c (print_error_message): Avoid int overflow.
10348 * font.c (font_list_entities): Redo for clarity,
10349 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10351 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10352 (font_score): Avoid potential overflow in diff calculation.
10354 * fns.c (substring_both): Remove var that is set but not used.
10355 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10357 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10359 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10360 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10361 can always succeed if overflow has undefined behavior.
10363 * search.c (boyer_moore, wordify): Remove vars set but not used.
10364 (wordify): Omit three unnecessary tests.
10366 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10367 All callers changed. This avoids the need for an unused var.
10369 * casefiddle.c (casify_region): Remove var that is set but not used.
10371 * dired.c (file_name_completion): Remove var that is set but not used.
10373 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10375 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10376 (Finsert_file_contents): Remove unnecessary code checking fd.
10378 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10379 Check for integer overflow on size calculations.
10381 * buffer.c (Fprevious_overlay_change): Remove var that is set
10384 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10385 Remove vars that are set but not used.
10386 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10387 (timer_check_2): Mark vars as initialized.
10389 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10391 * image.c (lookup_image): Remove var that is set but not used.
10392 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10394 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10395 that are set but not used.
10397 * xfns.c (make_invisible_cursor): Don't return garbage
10398 if XCreateBitmapFromData fails (Bug#8410).
10400 * xselect.c (x_get_local_selection, x_handle_property_notify):
10401 Remove vars that are set but not used.
10403 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10404 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10406 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10407 Remove var that is set but not used.
10408 (scroll_bar_windows_size): Now size_t, not int.
10409 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10410 Check for overflow.
10412 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10413 (map_tty_color) [!defined MSDOS]: Likewise.
10415 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10417 * coding.c: Remove vars that are set but not used.
10418 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10419 All callers changed.
10420 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10421 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10422 (decode_coding_charset): Remove vars that are set but not used.
10424 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10425 that is set but not used.
10427 * print.c (print_object): Remove var that is set but not used.
10429 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10430 The gnulib version avoids calling malloc in the usual case,
10431 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10432 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10433 * filelock.c (current_lock_owner): Likewise.
10434 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10435 * sysdep.c: Include allocator.h, careadlinkat.h.
10436 (emacs_no_realloc_allocator): New static constant.
10437 (emacs_readlink): New function.
10438 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10439 ../lib/careadlinkat.h.
10441 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10443 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10444 first non-nil return value).
10446 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10448 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10449 if not defined (Bug#8403).
10451 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10453 * xdisp.c (display_count_lines): Remove parameter `start',
10454 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10455 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10456 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10457 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10458 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10459 and thereabouts. All callers changed.
10460 (get_per_char_metric): Remove parameter `f', unused since
10461 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10463 2011-04-02 Jim Meyering <meyering@redhat.com>
10465 do not dereference NULL upon failed strdup
10466 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10467 (ns_get_family): Likewise.
10469 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10471 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10473 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10475 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10478 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10480 Add lexical binding.
10482 * window.c (Ftemp_output_buffer_show): New fun.
10483 (Fsave_window_excursion):
10484 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10486 * lread.c (lisp_file_lexically_bound_p): New function.
10487 (Fload): Bind Qlexical_binding.
10488 (readevalloop): Remove `evalfun' arg.
10489 Bind Qinternal_interpreter_environment.
10490 (Feval_buffer): Bind Qlexical_binding.
10491 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10493 (syms_of_lread): Declare `lexical-binding'.
10495 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10497 * keyboard.c (eval_dyn): New fun.
10498 (menu_item_eval_property): Use it.
10500 * image.c (parse_image_spec): Use Ffunctionp.
10502 * fns.c (concat, mapcar1): Accept byte-code-functions.
10504 * eval.c (Fsetq): Handle lexical vars.
10505 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10506 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10507 (FletX, Flet): Obey lexical binding.
10508 (Fcommandp): Handle closures.
10509 (Feval): New `lexical' arg.
10510 (eval_sub): New function extracted from Feval. Use it almost
10511 everywhere where Feval was used. Look up vars in lexical env.
10513 (Ffunctionp): Move from subr.el.
10514 (Ffuncall): Handle closures.
10515 (apply_lambda): Remove `eval_flags'.
10516 (funcall_lambda): Handle closures and new byte-code-functions.
10517 (Fspecial_variable_p): New function.
10518 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10519 but without exporting it to Lisp.
10521 * doc.c (Fdocumentation, store_function_docstring):
10522 * data.c (Finteractive_form): Handle closures.
10524 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10527 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10529 (exec_byte_code): New function extracted from Fbyte_code to handle new
10530 calling convention for byte-code-functions. Add new byte-codes.
10532 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10534 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10536 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10538 * xdisp.c (redisplay_internal): Fix prototype.
10540 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10542 * xdisp.c (SCROLL_LIMIT): New macro.
10543 (try_scrolling): Use it when setting scroll_limit.
10544 Limit scrolling to 100 screen lines.
10545 (redisplay_window): Even when falling back on "recentering",
10546 position point in the window according to scroll-conservatively,
10547 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10549 (try_scrolling): When point is above the window, allow searching
10550 as far as scroll_max, or one screenful, to compute vertical
10551 distance from PT to the scroll margin position. This prevents
10552 try_scrolling from unnecessarily failing when
10553 scroll-conservatively is set to a value slightly larger than the
10554 window height. Clean up the case of PT below the margin at bottom
10555 of window: scroll_max can no longer be INT_MAX. When aggressive
10556 scrolling is in use, don't let point enter the opposite scroll
10557 margin as result of the scroll.
10558 (syms_of_xdisp) <scroll-conservatively>: Document the
10559 threshold of 100 lines for never-recentering scrolling.
10561 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10563 * dispextern.h (move_it_by_lines):
10564 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10565 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10566 (message_log_check_duplicate): Remove parameters `prev_bol' and
10567 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10568 (redisplay_internal): Remove parameter `preserve_echo_area',
10569 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10571 * indent.c (Fvertical_motion):
10572 * window.c (window_scroll_pixel_based, Frecenter):
10573 Don't pass `need_y_p' to `move_it_by_lines'.
10575 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10577 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10578 steal a few bits to be more compact.
10579 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10580 Remove unneeded casts.
10582 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10584 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10586 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10587 binding" message (bug#7967).
10589 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10591 Fix more problems found by GCC 4.6.0's static checks.
10593 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10594 Remove unused local var.
10596 * editfns.c (Fmessage_box): Remove unused local var.
10598 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10599 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10600 Omit unused local vars.
10601 * window.c (shrink_windows): Omit unused local var.
10602 * menu.c (digest_single_submenu): Omit unused local var.
10603 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10604 Omit unused local var.
10606 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10607 Don't assume string length fits in int.
10608 (keyremap_step, read_key_sequence): Use size_t for sizes.
10609 (read_key_sequence): Don't check last_real_key_start redundantly.
10611 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10612 instead of alloca (Bug#8344).
10614 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10615 (Fbacktrace_frame): Don't assume nframes fits in int.
10617 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10619 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10622 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10624 * cm.c (calccost): Turn while-do into do-while, for clarity.
10626 * keyboard.c (syms_of_keyboard): Use the same style as later
10627 in this function when indexing through an array. This also
10628 works around GCC bug 48267.
10630 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10632 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10634 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10635 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10637 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10638 This avoids undefined behavior on integer overflow, and is a bit
10639 more convenient anyway since it is compared to a size_t variable.
10641 Variadic C functions now count arguments with size_t, not int.
10642 This avoids an unnecessary limitation on 64-bit machines, which
10643 caused (substring ...) to crash on large vectors (Bug#8344).
10644 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10645 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10646 All variadic functions and their callers changed accordingly.
10647 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10648 * data.c (arith_driver, float_arith_driver): Likewise.
10649 * editfns.c (general_insert_function): Likewise.
10650 * eval.c (struct backtrace.nargs, interactive_p)
10651 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10652 (funcall_lambda, mark_backtrace): Likewise.
10653 * fns.c (concat): Likewise.
10654 * frame.c (x_set_frame_parameters): Likewise.
10655 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10656 0 if not found, not -1. All callers changed.
10658 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10659 (stack_copy_size): Now size_t, not int.
10660 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10662 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10664 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10665 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10666 All callers changed.
10668 * lisp.h (multibyte_char_to_unibyte):
10669 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10670 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10671 * character.h (CHAR_TO_BYTE8):
10672 * cmds.c (internal_self_insert):
10673 * editfns.c (general_insert_function):
10674 * keymap.c (push_key_description):
10675 * search.c (Freplace_match):
10676 * xdisp.c (message_dolog, set_message_1): All callers changed.
10678 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10680 * keyboard.c (safe_run_hook_funcall): New function.
10681 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10682 don't set the hook to nil, but remove the offending function instead.
10683 (Qcommand_hook_internal): Remove, unused.
10684 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10685 Vcommand_hook_internal.
10687 * eval.c (enum run_hooks_condition): Remove.
10688 (funcall_nil, funcall_not): New functions.
10689 (run_hook_with_args): Call each function through a `funcall' argument.
10690 Remove `cond' argument, now redundant.
10691 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10692 (Frun_hook_with_args_until_failure): Adjust accordingly.
10693 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10695 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10697 * dispextern.h (string_buffer_position): Remove declaration.
10699 * print.c (strout): Remove parameter `multibyte', unused since
10700 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10702 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10703 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10704 All callers changed.
10706 * w32.c (_wsa_errlist): Use braces for struct initializers.
10708 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10709 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10710 All callers changed.
10711 (string_buffer_position): Likewise. Also, make static (it's never
10712 used outside xdisp.c).
10713 (cursor_row_p): Remove parameter `w', unused since
10714 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10715 (decode_mode_spec): Remove parameter `precision', introduced during
10716 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10717 All callers changed.
10719 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10721 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10723 2011-03-27 Anders Lindgren <andlind@gmail.com>
10725 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10726 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10727 (ns_update_auto_hide_menu_bar): New functions.
10728 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10729 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10730 ns_constrain_all_frames.
10731 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10732 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10734 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10736 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10738 2011-03-27 Glenn Morris <rgm@gnu.org>
10740 * syssignal.h: Replace RETSIGTYPE with void.
10741 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10742 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10743 Replace SIGTYPE with void everywhere.
10744 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10745 * s/template.h (SIGTYPE): Remove commented out definition.
10747 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10749 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10750 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10752 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10754 * w32.c (read_unc_volume): Use parameter `henum', instead of
10755 global variable `wget_enum_handle'.
10757 * keymap.c (describe_vector): Remove parameters `indices' and
10758 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10759 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10761 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10763 * keyboard.c (timer_check): Remove parameter `do_it_now',
10764 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10765 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10766 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10768 * keyboard.c (read_char):
10769 * w32menu.c (w32_menu_display_help):
10770 * xmenu.c (show_help_event, menu_help_callback):
10771 Adjust calls to `show_help_echo'.
10773 * gtkutil.c (xg_maybe_add_timer):
10774 * keyboard.c (readable_events):
10775 * process.c (wait_reading_process_output):
10776 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10778 * insdel.c (adjust_markers_gap_motion):
10779 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10780 (gap_left, gap_right): Don't call it.
10782 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10784 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10785 incurred during fontification.
10787 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10789 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10790 (DEFVAR_PER_BUFFER): Don't pass it.
10792 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10793 (scrolling_window): Don't pass it.
10795 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10797 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10799 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10801 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10802 of variables specific to SELinux and computation of `encoded_absname'.
10804 * image.c (XPutPixel): Remove unused variable `height'.
10806 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10808 * unexw32.c (get_section_info): Remove unused variable `section'.
10810 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10811 (system_process_attributes): Remove unused variable `sess'.
10812 (sys_read): Remove unused variable `err'.
10814 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10815 (w32_wnd_proc): Remove unused variable `isdead'.
10816 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10817 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10818 (x_create_tip_frame): Remove unused variable `tem'.
10820 * w32inevt.c (w32_console_read_socket):
10821 Remove unused variable `no_events'.
10823 * w32term.c (x_draw_composite_glyph_string_foreground):
10824 Remove unused variable `width'.
10826 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10828 * w32term.c (x_set_glyph_string_clipping):
10829 Don't pass uninitialized region to CombineRgn.
10831 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10833 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10834 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10835 (Fx_close_connection): Remove unused variable `i'.
10837 * w32font.c (w32font_draw): Return number of glyphs.
10838 (w32font_open_internal): Remove unused variable `i'.
10839 (w32font_driver): Add missing initializer.
10841 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10842 (fill_in_menu): Remove unused variable `items_added'.
10844 * w32term.c (last_mouse_press_frame): Remove static global variable.
10845 (w32_clip_to_row): Remove unused variable `f'.
10846 (x_delete_terminal): Remove unused variable `i'.
10848 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10849 (NOTHING): Remove unused static global variable.
10850 (uniscribe_check_otf): Remove unused variable `table'.
10851 (uniscribe_font_driver): Add missing initializers.
10853 2011-03-23 Julien Danjou <julien@danjou.info>
10855 * term.c (Fsuspend_tty, Fresume_tty):
10856 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10857 * window.c (temp_output_buffer_show):
10858 * insdel.c (signal_before_change):
10859 * frame.c (Fhandle_switch_frame):
10860 * fileio.c (Fdo_auto_save):
10861 * emacs.c (Fkill_emacs):
10862 * editfns.c (save_excursion_restore):
10863 * cmds.c (internal_self_insert):
10864 * callint.c (Fcall_interactively):
10865 * buffer.c (Fkill_all_local_variables):
10866 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10868 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10869 unconditionally since it does the check itself.
10871 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10873 Fix more problems found by GCC 4.5.2's static checks.
10875 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10876 the first time through the loop, since we know p0 < p1 then.
10877 This also avoids a gcc -Wstrict-overflow warning.
10879 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10880 leading to a memory leak, possible in functions like
10881 load_charset_map_from_file that can allocate an unbounded number
10882 of objects (Bug#8318).
10884 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10885 that could (at least in theory) be that large.
10887 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10888 This is less likely to overflow, and avoids undefined behavior if
10889 overflow does occur. All callers changed. Use strtoul to scan
10890 for the unsigned long integer.
10891 (pint2hrstr): Simplify and tune code slightly.
10892 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10894 * scroll.c (do_scrolling): Work around GCC bug 48228.
10895 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10897 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10898 This also avoids a warning with gcc -Wstrict-overflow.
10899 (validate_x_resource_name): Simplify count usage.
10900 This also avoids a warning with gcc -Wstrict-overflow.
10902 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10905 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10907 * process.c (Fmake_network_process): Use socklen_t, not int,
10908 where POSIX says socklen_t is required in portable programs.
10909 This fixes a porting bug on hosts like 64-bit HP-UX, where
10910 socklen_t is wider than int (Bug#8277).
10911 (Fmake_network_process, server_accept_connection):
10912 (wait_reading_process_output, read_process_output):
10915 * process.c: Rename or move locals to avoid shadowing.
10916 (list_processes_1, Fmake_network_process):
10917 (read_process_output_error_handler, exec_sentinel_error_handler):
10918 Rename or move locals.
10919 (Fmake_network_process): Define label "retry_connect" only if needed.
10920 (Fnetwork_interface_info): Fix pointer signedness.
10921 (process_send_signal): Add cast to avoid pointer signedness problem.
10922 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10923 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10925 Make tparam.h and terminfo.c consistent.
10926 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10927 Include tparam.h instead, since it declares them.
10928 * cm.h (PC): Remove extern decl; tparam.h now does this.
10929 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10930 * terminfo.c: Include tparam.h, to check interfaces.
10931 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10932 (tparam): Adjust signature to match interface in tparam.h;
10933 this removes some undefined behavior. Check that outstring and len
10934 are zero, which they always are with Emacs.
10935 * tparam.h (PC, BC, UP): New extern decls.
10937 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10938 (xftfont_open): Rename locals to avoid shadowing.
10940 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10941 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10942 (OTF_TAG_SYM): Omit macro if not needed.
10943 (ftfont_list): Remove unused local.
10944 (get_adstyle_property, ftfont_pattern_entity):
10945 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10946 Rename locals to avoid shadowing.
10948 * xfont.c (xfont_list_family): Mark var as initialized.
10950 * xml.c (make_dom): Now static.
10952 * composite.c (composition_compute_stop_pos): Rename local to
10954 (composition_reseat_it): Remove unused locals.
10955 (find_automatic_composition, composition_adjust_point): Likewise.
10956 (composition_update_it): Mark var as initialized.
10957 (find_automatic_composition): Mark vars as initialized,
10958 with a FIXME (Bug#8290).
10960 character.h: Rename locals to avoid shadowing.
10961 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10962 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10963 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10964 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10965 to avoid shadowing.
10967 * textprop.c (property_change_between_p): Remove; unused.
10969 * intervals.c (interval_start_pos): Now static.
10971 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10973 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10974 Rename locals to avoid shadowing.
10976 * sound.c (wav_play, au_play, Fplay_sound_internal):
10977 Fix pointer signedness.
10978 (alsa_choose_format): Remove unused local var.
10979 (wav_play): Initialize a variable to 0, to prevent undefined
10980 behavior (Bug#8278).
10982 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10984 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10986 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10987 clobbering (Bug#8298).
10988 * sysdep.c (sys_subshell): Likewise.
10989 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10991 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10992 This should get cleaned up, so that child_setup has the
10993 same signature on all platforms.
10995 * callproc.c (call_process_cleanup): Now static.
10996 (relocate_fd): Rename locals to avoid shadowing.
10998 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11000 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11001 not to be necessary, and produces flickering.
11003 2011-03-20 Glenn Morris <rgm@gnu.org>
11005 * config.in: Remove file.
11007 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11009 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11010 are now in src/globals.h.
11011 (syms_of_minibuf): Remove spurious & from previous change.
11013 2011-03-20 Leo Liu <sdl.web@gmail.com>
11015 * minibuf.c (completing-read-function): New variable.
11016 (completing-read-default): Rename from completing-read.
11017 (completing-read): Call completing-read-function.
11019 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11021 * xfaces.c (Fx_load_color_file):
11022 Read color file from absolute filename (bug#8250).
11024 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11026 * makefile.w32-in: Update dependencies.
11028 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11030 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11032 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11034 Fix more problems found by GCC 4.5.2's static checks.
11036 * process.c (make_serial_process_unwind, send_process_trap):
11037 (sigchld_handler): Now static.
11039 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11040 That way, the code declares only the vars that it needs.
11041 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11042 * s/cygwin.h (PTY_ITERATION): Likewise.
11043 * s/darwin.h (PTY_ITERATION): Likewise.
11044 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11046 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11047 * process.c (allocate_pty): Don't declare stb unless it's needed.
11049 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11050 (CONSTANTLIM): Remove; unused.
11051 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11052 Define only if needed.
11054 * unexelf.c (unexec): Name an expression,
11055 to avoid gcc -Wbad-function-cast warning.
11056 Use a different way to cause a compilation error if anyone uses
11057 n rather than nn, a way that does not involve shadowing.
11058 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11060 * deps.mk (unexalpha.o): Remove; unused.
11062 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11063 * unexec.h: New file.
11064 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11065 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11066 Depend on unexec.h.
11067 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11068 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11069 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11070 Change as necessary to match prototype in unexec.h.
11072 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11074 (back_comment, skip_chars): Mark vars as initialized.
11076 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11077 Rename locals to avoid shadowing.
11079 * lread.c (read1): Rewrite so as not to use empty "else".
11080 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11082 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11084 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11085 warning when compiling print.c.
11087 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11088 instead of using an uninitialized var.
11089 (font_sort_entities): Mark var as initialized.
11091 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11093 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11094 pointers to constants.
11095 (font_parse_fcname): Remove unused vars.
11096 (font_delete_unmatched): Now static.
11097 (font_get_spec): Remove; unused.
11098 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11099 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11100 Rename or move locals to avoid shadowing.
11102 * fns.c (require_nesting_list, require_unwind): Now static.
11103 (Ffillarray): Rename locals to avoid shadowing.
11105 * floatfns.c (domain_error2): Define only if needed.
11106 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11108 * alloc.c (mark_backtrace): Move decl from here ...
11109 * lisp.h: ... to here, so that it can be checked.
11111 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11112 (Fdefvar): Rewrite so as not to use empty "else".
11113 (lisp_indirect_variable): Name an expression,
11114 to avoid gcc -Wbad-function-cast warning.
11115 (Fdefvar): Rename locals to avoid shadowing.
11117 * callint.c (quotify_arg, quotify_args): Now static.
11118 (Fcall_interactively): Rename locals to avoid shadowing.
11119 Use const pointer when appropriate.
11121 * lisp.h (get_system_name, get_operating_system_release):
11122 Move decls here, to check interfaces.
11123 * process.c (get_operating_system_release): Move decl to lisp.h.
11124 * xrdb.c (get_system_name): Likewise.
11125 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11126 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11127 some of which prompt warnings from gcc -Wbad-function-cast.
11128 (Fformat_time_string, Fencode_time, Finsert_char):
11129 (Ftranslate_region_internal, Fformat):
11130 Rename or remove local vars to avoid shadowing.
11131 (Ftranslate_region_internal): Mark var as initialized.
11133 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11136 * lisp.h (eassert): Check that the argument compiles, even if
11137 ENABLE_CHECKING is not defined.
11139 * data.c (Findirect_variable): Name an expression, to avoid
11140 gcc -Wbad-function-cast warning.
11141 (default_value, arithcompare, arith_driver, arith_error): Now static.
11142 (store_symval_forwarding): Rename local to avoid shadowing.
11143 (Fmake_variable_buffer_local, Fmake_local_variable):
11144 Mark variables as initialized.
11145 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11147 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11148 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11149 Rename locals to avoid shadowing.
11150 (mark_stack): Move local variables into the #ifdef region where
11152 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11153 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11155 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11156 (GC_STRING_CHARS): Remove; not used.
11157 (Fmemory_limit): Cast sbrk's returned value to char *.
11159 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11160 avoids undefined behavior in theory.
11162 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11164 Use functions, not macros, for up- and down-casing (Bug#8254).
11165 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11166 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11167 to use the following functions instead of these macros.
11168 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11169 EMACS_INT, since callers assume the returned value fits in int.
11170 (upcase1): Likewise, for UPCASE_TABLE.
11171 (uppercasep, lowercasep, upcase): New static inline functions.
11172 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11173 the race-condition problem in the old DOWNCASE.
11175 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11176 Rename locals to avoid shadowing.
11177 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11178 (regex_compile, re_search_2, re_match_2_internal):
11179 Remove unused local vars.
11180 (FREE_VAR): Rewrite so as not to use empty "else",
11181 which gcc can warn about.
11182 (regex_compile, re_match_2_internal): Mark locals as initialized.
11183 (RETALLOC_IF): Define only if needed.
11184 (WORDCHAR_P): Likewise. This one is never needed, but is used
11185 only in a comment talking about a compiler bug, so put inside
11186 the #if 0 of that comment.
11187 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11188 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11191 * search.c (boyer_moore): Rename locals to avoid shadowing.
11192 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11193 (PREV_CHAR_BOUNDARY): Likewise.
11195 * search.c (simple_search): Remove unused var.
11197 * dired.c (compile_pattern): Move decl from here ...
11198 * lisp.h: ... to here, so that it can be checked.
11199 (struct re_registers): New forward decl.
11201 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11203 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11205 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11206 Rename locals to avoid shadowing.
11207 (Fvertical_motion): Mark locals as initialized.
11209 * casefiddle.c (casify_object, casify_region): Now static.
11210 (casify_region): Mark local as initialized.
11212 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11214 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11215 New macros, so that the caller can use some names other than
11216 gcpro1, gcpro2, etc.
11217 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11219 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11220 argument, for consistency with GCPRO2_VAR, etc: it is now the
11221 prefix of the variable, not the variable itself. All uses
11223 * dired.c (directory_files_internal, file_name_completion):
11224 Rename locals to avoid shadowing.
11226 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11227 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11228 dired.c's scmp function, had undefined behavior.
11229 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11230 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11231 * buffer.h: ... to here, because these macros use current_buffer,
11232 and the new implementation with inline functions needs to have
11233 current_buffer in scope now, rather than later when the macros
11235 (downcase, upcase1): New static inline functions.
11236 (DOWNCASE, UPCASE1): Reimplement using these functions.
11237 This avoids undefined behavior in expressions like
11238 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11239 from race conditions in accessing the global variables
11240 case_temp1 and case_temp2.
11241 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11242 * lisp.h (case_temp1, case_temp2): Remove their decls.
11243 * character.h (ASCII_CHAR_P): Move from here ...
11244 * lisp.h: ... to here, so that the inline functions mentioned
11245 above can use them.
11247 * dired.c (directory_files_internal_unwind): Now static.
11249 * fileio.c (file_name_as_directory, directory_file_name):
11250 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11252 (file_name_as_directory): Use const pointers when appropriate.
11253 (Fexpand_file_name): Likewise. In particular, newdir might
11254 point at constant storage, so make it a const pointer.
11255 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11256 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11258 (Fset_file_times, Finsert_file_contents, auto_save_error):
11259 Rename locals to avoid shadowing.
11261 * minibuf.c (choose_minibuf_frame_1): Now static.
11262 (Ftry_completion, Fall_completions): Rename or remove locals
11263 to avoid shadowing.
11265 * marker.c (bytepos_to_charpos): Remove; unused.
11267 * lisp.h (verify_bytepos, count_markers): New decls,
11268 so that gcc does not warn that these functions aren't declared.
11270 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11271 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11272 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11273 (copy_text): Remove unused local var.
11275 * filelock.c (within_one_second): Now static.
11276 (lock_file_1): Rename local to avoid shadowing.
11278 * buffer.c (fix_overlays_before): Mark locals as initialized.
11279 (fix_start_end_in_overlays): Likewise. This function should be
11280 simplified by using pointers-to-pointers, but that's a different
11282 (switch_to_buffer_1): Now static.
11283 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11284 (report_overlay_modification): Rename locals to avoid shadowing.
11286 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11287 Fix pointer signedness issue.
11288 (sys_subshell): Mark local as volatile if checking for lint,
11289 to suppress a gcc -Wclobbered warning that does not seem to be right.
11290 (MAXPATHLEN): Define only if needed.
11292 * process.c (serial_open, serial_configure): Move decls from here ...
11293 * systty.h: ... to here, so that they can be checked.
11295 * fns.c (get_random, seed_random): Move extern decls from here ...
11296 * lisp.h: ... to here, so that they can be checked.
11298 * sysdep.c (reset_io): Now static.
11299 (wait_for_termination_signal): Remove; unused.
11301 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11302 (copy_keymap_item, append_key, push_text_char_description):
11304 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11305 (DENSE_TABLE_SIZE): Remove; unused.
11306 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11307 (describe_map_tree):
11308 Rename locals to avoid shadowing.
11310 * keyboard.c: Declare functions static if they are not used elsewhere.
11311 (echo_char, echo_dash, cmd_error, top_level_2):
11312 (poll_for_input, handle_async_input): Now static.
11313 (read_char, kbd_buffer_get_event, make_lispy_position):
11314 (make_lispy_event, make_lispy_movement, apply_modifiers):
11315 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11316 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11317 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11318 (read_key_sequence, read_char): Mark locals as initialized.
11319 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11321 * keyboard.h (make_ctrl_char): New decl.
11322 (mark_kboards): Move decl here ...
11323 * alloc.c (mark_kboards): ... from here.
11325 * lisp.h (force_auto_save_soon): New decl.
11327 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11328 (DEFINE_DUMMY_FUNCTION): New macro.
11329 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11331 (main): Add casts to avoid warnings
11332 if GCC considers string literals to be constants.
11334 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11336 * dbusbind.c: Pointer signedness fixes.
11337 (xd_signature, xd_append_arg, xd_initialize):
11338 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11339 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11340 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11341 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11343 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11344 if GCC considers string literals to be constants.
11345 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11347 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11349 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11350 (print_preprocess, print_object): New macro to fix last change.
11352 * print.c (print_preprocess): Don't forget font objects.
11354 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11356 * emacs.c (USAGE3): Doc fixes.
11358 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11360 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11363 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11365 * lisp.h (VWindow_system, Qfile_name_history):
11366 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11367 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11368 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11370 * w32select.c: Don't #include "keyboard.h".
11371 (run_protected): Add extern declaration for waiting_for_input.
11373 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11374 * w32console.c (detect_input_pending, read_input_pending)
11375 (encode_terminal_code):
11376 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11377 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11378 (w32_system_caret_y, Qfile_name_history):
11379 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11380 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11381 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11382 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11383 * w32proc.c (Qlocal, report_file_error):
11384 * w32term.c (Vwindow_system, updating_frame):
11385 * w32uniscribe.c (initialized, uniscribe_font_driver):
11386 Remove unneeded extern declarations.
11388 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11390 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11392 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11394 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11395 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11396 These macros can no longer be used for assignment.
11398 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11399 Assign struct members directly, instead of using BUF_BEGV etc.
11400 (record_buffer_markers, fetch_buffer_markers): New functions for
11401 recording and fetching special buffer markers.
11402 (set_buffer_internal_1, set_buffer_temp): Use them.
11404 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11406 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11408 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11409 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11411 * xdisp.c (hscroll_window_tree):
11412 (reconsider_clip_changes): Use PT instead of BUF_PT.
11414 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11416 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11417 $(EMACS_ROOT)/lib/intprops.h.
11419 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11421 Fix more problems found by GCC 4.5.2's static checks.
11423 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11424 to unsigned char * to avoid compiler diagnostic.
11425 (xg_free_frame_widgets): Make it clear that a local variable is
11426 needed only if USE_GTK_TOOLTIP.
11427 (gdk_window_get_screen): Make it clear that this macro is needed
11428 only if USE_GTK_TOOLTIP.
11429 (int_gtk_range_get_value): New function, which avoids a diagnostic
11430 from gcc -Wbad-function-cast.
11431 (xg_set_toolkit_scroll_bar_thumb): Use it.
11432 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11433 diagnostic from gcc -Wbad-function-cast.
11434 (get_utf8_string, xg_get_file_with_chooser):
11435 Rename locals to avoid shadowing.
11436 (create_dialog): Move locals to avoid shadowing.
11438 * xgselect.c (xg_select): Remove unused var.
11440 * image.c (four_corners_best): Mark locals as initialized.
11441 (gif_load): Initialize transparent_p to zero (Bug#8238).
11442 Mark another local as initialized.
11443 (my_png_error, my_error_exit): Mark with NO_RETURN.
11445 * image.c (clear_image_cache): Now static.
11446 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11447 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11448 (x_edge_detection): Remove unnecessary cast that
11449 gcc -Wbad-function-cast diagnoses.
11450 (gif_load): Fix pointer signedness.
11451 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11452 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11454 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11456 Improve quality of tests for time stamp overflow.
11457 For example, without this patch (encode-time 0 0 0 1 1
11458 1152921504606846976) returns the obviously-bogus value (-948597
11459 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11460 reports time overflow. See
11461 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11462 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11463 * editfns.c: Include limits.h and intprops.h.
11464 (TIME_T_MIN, TIME_T_MAX): New macros.
11465 (time_overflow): Move earlier, to before first use.
11466 (hi_time, lo_time): New functions, for an accurate test for
11467 out-of-range times.
11468 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11469 (Fget_internal_run_time): Don't assume time_t fits in int.
11470 (make_time): Use list2 instead of Fcons twice.
11471 (Fdecode_time): More accurate test for out-of-range times.
11472 (check_tm_member): New function.
11473 (Fencode_time): Use it, to test for out-of-range times.
11474 (lisp_time_argument): Don't rely on undefined left-shift and
11475 right-shift behavior when checking for time stamp overflow.
11477 * editfns.c (time_overflow): New function, refactoring common code.
11478 (Fformat_time_string, Fdecode_time, Fencode_time):
11479 (Fcurrent_time_string): Use it.
11481 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11482 * dired.c (make_time): Move to ...
11483 * editfns.c (make_time): ... here.
11484 * systime.h: Note the move.
11486 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11488 * fringe.c (update_window_fringes): Remove unused variables.
11490 * unexmacosx.c (copy_data_segment): Also copy __got section.
11493 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11495 * termcap.c [MSDOS]: Include "msdos.h".
11496 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11497 Constify `char *' arguments and their references according to
11498 prototypes in tparam.h.
11500 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11502 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11503 Adapt all references accordingly.
11505 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11507 2011-03-11 Tom Tromey <tromey@redhat.com>
11509 * buffer.c (syms_of_buffer): Remove obsolete comment.
11511 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11513 * termhooks.h (encode_terminal_code): Declare prototype.
11515 * msdos.c (encode_terminal_code): Don't declare prototype.
11517 * term.c (encode_terminal_code): Now external again, used by
11518 w32console.c and msdos.c.
11520 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11521 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11523 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11525 Fix some minor problems found by GCC 4.5.2's static checks.
11527 * fringe.c (update_window_fringes): Mark locals as initialized
11529 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11531 * alloc.c (mark_fringe_data): Move decl from here ...
11532 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11533 to check its interface.
11534 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11536 * fontset.c (free_realized_fontset): Now static.
11537 (Fset_fontset_font): Rename local to avoid shadowing.
11538 (fontset_font): Mark local as initialized.
11539 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11541 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11543 * xselect.c (x_disown_buffer_selections): Remove; not used.
11544 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11545 (x_own_selection, Fx_disown_selection_internal): Rename locals
11546 to avoid shadowing.
11547 (x_handle_dnd_message): Remove local to avoid shadowing.
11549 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11550 so that the caller can use some name other than gcpro1.
11551 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11552 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11553 (Fx_backspace_delete_keys_p):
11554 Use them to avoid shadowing, and rename vars to avoid shadowing.
11555 (x_decode_color, x_set_name, x_window): Now static.
11556 (Fx_create_frame): Add braces to silence GCC warning.
11557 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11558 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11559 Remove unused locals.
11560 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11561 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11562 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11565 * xterm.h (x_mouse_leave): New decl.
11567 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11568 Remove unused functions.
11569 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11570 (x_calc_absolute_position): Now static.
11571 (XTread_socket): Don't define label "out" unless it's used.
11572 Don't declare local "event" unless it's used.
11573 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11574 unless they are used.
11575 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11576 (x_fatal_error_signal): Remove; not used.
11577 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11578 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11579 (x_error_catcher, x_connection_closed, x_error_handler):
11580 (x_error_quitter, xembed_send_message, x_iconify_frame):
11581 (my_log_handler): Rename locals to avoid shadowing.
11582 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11583 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11585 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11586 Rename or move locals to avoid shadowing.
11587 (tty_defined_color, merge_face_heights): Now static.
11588 (free_realized_faces_for_fontset): Remove; not used.
11589 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11590 does not deduce is never used uninitialized.
11591 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11592 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11594 * terminal.c (store_terminal_param): Now static.
11596 * xmenu.c (menu_highlight_callback): Now static.
11597 (set_frame_menubar): Remove unused local.
11598 (xmenu_show): Rename parameter to avoid shadowing.
11599 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11600 since they might point to immutable storage.
11601 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11602 since it's unused otherwise.
11604 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11605 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11606 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11607 avoids a gcc -Wuninitialized diagnostic.
11608 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11609 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11610 does not deduce are never used uninitialized.
11612 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11614 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11615 * window.c (window_loop, size_window):
11616 (run_window_configuration_change_hook, enlarge_window): Likewise.
11618 * window.c (display_buffer): Now static.
11619 (size_window): Mark variables that gcc -Wuninitialized
11620 does not deduce are never used uninitialized.
11621 * window.h (check_all_windows): New decl, to forestall
11622 gcc -Wmissing-prototypes diagnostic.
11623 * dispextern.h (bidi_dump_cached_states): Likewise.
11625 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11627 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11628 Include <limits.h>.
11629 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11630 and to avoid gcc -Wuninitialized warning.
11631 (load_charset_map): Mark variables that gcc -Wuninitialized
11632 does not deduce are never used uninitialized.
11633 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11635 * coding.c (coding_set_source, coding_set_destination):
11636 Use "else { /* comment */ }" rather than "else /* comment */;"
11637 for clarity, and to avoid gcc -Wempty-body warning.
11638 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11639 a block, when the outer 'i' will do.
11640 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11641 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11642 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11643 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11644 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11645 Rename locals to avoid shadowing.
11646 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11647 * coding.c (emacs_mule_char, encode_invocation_designation):
11648 Now static, since they're not used elsewhere.
11649 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11650 (decode_coding_object, encode_coding_object, detect_coding_system):
11651 (decode_coding_emacs_mule): Mark variables that gcc
11652 -Wuninitialized does not deduce are never used uninitialized.
11653 (detect_coding_iso_2022): Initialize a local variable that might
11654 be used uninitialized. Leave a FIXME because it's not clear that
11655 this initialization is needed. (Bug#8211)
11656 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11657 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11658 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11659 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11660 Remove unused macros.
11662 * category.c (hash_get_category_set): Remove unused local var.
11663 (copy_category_table): Now static, since it's not used elsewhere.
11664 * character.c (string_count_byte8): Likewise.
11666 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11667 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11669 * chartab.c (copy_sub_char_table): Now static, since it's not used
11671 (sub_char_table_ref_and_range, char_table_ref_and_range):
11672 Rename locals to avoid shadowing.
11673 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11675 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11676 (BIDI_BOB): Remove unused macro.
11678 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11679 deduce are never used uninitialized.
11680 * term.c (encode_terminal_code): Likewise.
11682 * term.c (encode_terminal_code): Now static. Remove unused local.
11684 * tparam.h: New file.
11685 * term.c, tparam.h: Include it.
11686 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11687 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11688 Move these decls to tparam.h, and make them agree with what
11689 is actually in tparam.c. The previous trick of using incompatible
11690 decls in different modules does not conform to the C standard.
11691 All callers of tparam changed to use tparam's actual API.
11692 * tparam.c (tparam1, tparam, tgoto):
11693 Use const pointers where appropriate.
11695 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11696 * cm.h (struct cm): Likewise.
11697 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11698 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11699 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11700 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11701 (turn_on_face, init_tty): Likewise.
11702 * termchar.h (struct tty_display_info): Likewise.
11704 * term.c (term_mouse_position): Rename local to avoid shadowing.
11706 * alloc.c (mark_ttys): Move decl from here ...
11707 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11709 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11711 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11713 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11715 * search.c (compile_pattern_1): Remove argument regp, unused since
11716 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11717 (compile_pattern): Don't pass it.
11719 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11721 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11722 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11724 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11726 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11728 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11729 gdk_window_get_screen, gdk_window_get_geometry,
11730 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11731 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11732 (xg_get_pixbuf_from_pixmap): New function.
11733 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11734 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11735 Call xg_get_pixbuf_from_pixmap instead of
11736 gdk_pixbuf_get_from_drawable.
11737 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11738 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11739 (xg_check_special_colors): Use GtkStyleContext and its functions
11741 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11742 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11743 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11744 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11745 Call gtk_widget_get_preferred_size.
11746 (xg_frame_resized): gdk_window_get_geometry only takes 5
11748 (xg_win_to_widget, xg_event_is_for_menubar):
11749 Call gdk_x11_window_lookup_for_display.
11750 (xg_set_widget_bg): New function.
11751 (delete_cb): New function.
11752 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11753 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11754 (xg_set_background_color): Call xg_set_widget_bg.
11755 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11756 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11757 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11758 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11760 (update_frame_tool_bar): Call gtk_widget_hide.
11761 (xg_initialize): Use GDK_KEY_g.
11763 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11765 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11767 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11768 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11769 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11771 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11773 * w32xfns.c (select_palette): Check success of RealizePalette against
11774 GDI_ERROR, not zero.
11776 See ChangeLog.11 for earlier changes.
11778 ;; Local Variables:
11782 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11784 This file is part of GNU Emacs.
11786 GNU Emacs is free software: you can redistribute it and/or modify
11787 it under the terms of the GNU General Public License as published by
11788 the Free Software Foundation, either version 3 of the License, or
11789 (at your option) any later version.
11791 GNU Emacs is distributed in the hope that it will be useful,
11792 but WITHOUT ANY WARRANTY; without even the implied warranty of
11793 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11794 GNU General Public License for more details.
11796 You should have received a copy of the GNU General Public License
11797 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.