lisp.h: Fix a problem with aliasing and vector headers.

[gnu-emacs] / src / ChangeLog

2011-04-25  Paul Eggert  <eggert@cs.ucla.edu>

        lisp.h: Fix a problem with aliasing and vector headers.
        GCC 4.6.0 optimizes based on type-based alias analysis.  For
        example, if b is of type struct buffer * and v of type struct
        Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
        != &v->size, and therefore "v->size = 1; b->size = 2; return
        v->size;" must therefore return 1.  This assumption is incorrect
        for Emacs, since it type-puns struct Lisp_Vector * with many other
        types.  To fix this problem, this patch adds a new type struct
        vector_header that documents the constraints on layout of vectors
        and pseudovectors, and helps optimizing compilers not get fooled
        by Emacs's type punning.  It also adds the macros XSETTYPED_PVECTYPE
        XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
        * lisp.h (XVECTOR_SIZE): New convenience macro.  All previous uses of
        XVECTOR (foo)->size replaced to use this macro, to avoid the hassle
        of writing XVECTOR (foo)->header.size.
        (XVECTOR_HEADER_SIZE): New macro, for use in XSETPSEUDOVECTOR.
        (XSETTYPED_PVECTYPE): New macro, specifying the name of the size
        member.
        (XSETPVECTYPE): Rewrite in terms of new macro.
        (XSETPVECTYPESIZE): New macro, specifying both type and size.
        This is a bit clearer, and further avoids the possibility of
        undesirable aliasing.
        (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
        (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR
        and XVECTOR_HEADER_SIZE.
        (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
        since Lisp_Subr is a special case (no "next" field).
        (ASIZE): Rewrite in terms of XVECTOR_SIZE.
        (struct vector_header): New type.
        (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
        object, to help avoid aliasing.
        (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
        (SUBRP): Likewise, since Lisp_Subr is a special case.
        * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
        (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
        (struct Lisp_Hash_Table): Combine first two members into a single
        struct vector_header member.  All uses of "size" and "next" members
        changed to be "header.size" and "header.next".
        * buffer.h (struct buffer): Likewise.
        * font.h (struct font_spec, struct font_entity, struct font): Likewise.
        * frame.h (struct frame): Likewise.
        * process.h (struct Lisp_Process): Likewise.
        * termhooks.h (struct terminal): Likewise.
        * window.c (struct save_window_data, struct saved_window): Likewise.
        * window.h (struct window): Likewise.
        * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
        Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
        * buffer.c (init_buffer_once): Likewise.
        * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
        special case.
        * process.c (Fformat_network_address): Use local var for size,
        for brevity.

2011-04-24  Paul Eggert  <eggert@cs.ucla.edu>

        * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.

2011-04-21  Paul Eggert  <eggert@cs.ucla.edu>

        Make the Lisp reader and string-to-float more consistent.
        * data.c (atof): Remove decl; no longer used or needed.
        (digit_to_number): Move to lread.c.
        (Fstring_to_number): Use new string_to_number function, to be
        consistent with how the Lisp reader treats infinities and NaNs.
        Do not assume that floating-point numbers represent EMACS_INT
        without losing information; this is not true on most 64-bit hosts.
        Avoid double-rounding errors, by insisting on integers when
        parsing non-base-10 numbers, as the documentation specifies.
        * lisp.h (string_to_number): New decl, replacing ...
        (isfloat_string): Remove.
        * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
        (read1): Do not accept +. and -. as integers; this
        appears to have been a coding error.  Similarly, do not accept
        strings like +-1e0 as floating point numbers.  Do not report
        overflow for integer overflows unless the base is not 10 which
        means we have no simple and reliable way to continue.
        Break out the floating-point parsing into a new
        function string_to_number, so that Fstring_to_number parses
        floating point numbers consistently with the Lisp reader.
        (digit_to_number): Moved here from data.c.  Make it static inline.
        (E_CHAR, EXP_INT): Remove, replacing with ...
        (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
        (string_to_number): New function, replacing isfloat_string.
        This function checks for valid syntax and produces the resulting
        Lisp float number too.  Rework it so that string-to-number
        no longer mishandles examples like "1.0e+".  Use strtoumax,
        so that overflow for non-base-10 numbers is reported only when
        there's no portable and simple way to convert to floating point.

2011-04-20  Paul Eggert  <eggert@cs.ucla.edu>

        * textprop.c (set_text_properties_1): Rewrite for clarity,
        and to avoid GCC warning about integer overflow.

        * intervals.h (struct interval): Use EMACS_INT for members
        where EMACS_UINT might cause problems.  See
        <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
        (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
        * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
        All uses changed.
        (offset_intervals): Tell GCC not to worry about length overflow
        when negating a negative length.

        * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
        (overrun_check_free): Likewise.

        * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
        in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
        word size.

        * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
        (gnutls_make_error): Rename local to avoid shadowing.
        (gnutls_emacs_global_deinit): ifdef out; not used.
        (Fgnutls_boot): Use const for pointer to readonly storage.
        Comment out unused local.  Fix pointer signedness problems.

        * lread.c (openp): Don't stuff size_t into an 'int'.
        Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
        about possible signed overflow.

        * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
        (GDK_KEY_g): Don't define if already defined.
        (xg_prepare_tooltip): Avoid pointer signedness problem.
        (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.

        * process.c (Fnetwork_interface_info): Avoid left-shift undefined
        behavior with 1 << 31.  GCC 4.6.0 warns about this on 32-bit hosts.

        * xfns.c (Fx_window_property): Simplify a bit,
        to make a bit faster and to avoid GCC 4.6.0 warning.
        * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.

        * fns.c (internal_equal): Don't assume size_t fits in int.

        * alloc.c (compact_small_strings): Tighten assertion a little.

        Replace pEd with more-general pI, and fix some printf arg casts.
        * lisp.h (pI): New macro, generalizing old pEd macro to other
        conversion specifiers.  For example, use "...%"pI"d..." rather
        than "...%"pEd"...".
        (pEd): Remove.  All uses replaced with similar uses of pI.
        * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
        * alloc.c (check_pure_size): Don't overflow by converting size to int.
        * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
        * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
        * dbusbind.c (xd_append_arg): Use pI to avoid cast.
        (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
        * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
        64-bit hosts.
        (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
        * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
        * print.c (safe_debug_print, print_object): Likewise.
        (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
        to int.
        Use pI instead of if-then-else-abort.  Use %p to avoid casts,
        avoiding the 0 flag, which is not portable.
        * process.c (Fmake_network_process): Use pI to avoid cast.
        * region-cache.c (pp_cache): Likewise.
        * xdisp.c (decode_mode_spec): Likewise.
        * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
        behavior on 64-bit hosts with printf arg.
        * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
        (x_stop_queuing_selection_requests): Likewise.
        (x_get_window_property): Don't truncate byte count to an 'int'
        when tracing.

        * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
        here, since it parses constructs like leading '-' and spaces,
        which are not wanted; and it overflows with large numbers.
        Instead, simply match F[0-9]+, which is what is wanted anyway.

        * alloc.c: Remove unportable assumptions about struct layout.
        (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
        (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
        (allocate_vectorlike, make_pure_vector): Use the new macros,
        plus offsetof, to remove unportable assumptions about struct layout.
        These assumptions hold on all porting targets that I know of, but
        they are not guaranteed, they're easy to remove, and removing them
        makes further changes easier.

        * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
        This doesn't fix a bug but makes the code clearer.
        (string_overrun_cookie): Now const.  Use initializers that
        don't formally overflow signed char, to avoid warnings.
        (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
        can cause Emacs to crash when string overrun checking is enabled.
        (allocate_buffer): Don't assume sizeof (struct buffer) is a
        multiple of sizeof (EMACS_INT); it need not be, if
        alignof(EMACS_INT) < sizeof (EMACS_INT).
        (check_sblock, check_string_bytes, check_string_free_list): Protoize.

2011-04-19  Eli Zaretskii  <eliz@gnu.org>

        * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
        gl_state.e_property when gl_state.object is Qt.

        * insdel.c (make_gap_larger): Remove limitation of buffer size
        to <= INT_MAX.

2011-04-18  Chong Yidong  <cyd@stupidchicken.com>

        * xdisp.c (lookup_glyphless_char_display)
        (produce_glyphless_glyph): Handle cons cell entry in
        glyphless-char-display.
        (Vglyphless_char_display): Document it.

        * term.c (produce_glyphless_glyph): Handle cons cell entry in
        glyphless-char-display.

2011-04-17  Chong Yidong  <cyd@stupidchicken.com>

        * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.

        * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.

        * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
        definition for no-X builds.

2011-04-16  Paul Eggert  <eggert@cs.ucla.edu>

        Static checks with GCC 4.6.0 and non-default toolkits.

        * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.

        * process.c (keyboard_bit_set): Define only if SIGIO.
        (send_process_trap): Mark it with NO_RETURN if it doesn't return.
        (send_process): Repair possible setjmp clobbering.

        * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.

        * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.

        * data.c (arith_error): Mark with NO_RETURN if it doesn't return.

        * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
        Define only if needed.

        * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
        by pacifying GCC about it.  Maybe it's time to retire it?
        * xfaces.c (USG, __TIMEVAL__): Likewise.

        * dispextern.h (struct redisplay_interface): Rename param
        to avoid shadowing.
        * termhooks.h (struct terminal): Likewise.
        * xterm.c (xembed_send_message): Likewise.

        * insdel.c (make_gap_smaller): Define only if
        USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.

        * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
        it.

        * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
        so that we aren't warned about unused symbols.

        * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.

        * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).

        * xfns.c (x_real_positions): Mark locals as initialized.

        * xmenu.c (xmenu_show): Don't use uninitialized vars.

        * xterm.c: Fix problems found by static analysis with other toolkits.
        (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
        (x_dispatch_event): Declare static if USE_GTK, and
        define if USE_GTK || USE_X_TOOLKIT.
        (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
        * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
        * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
        defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.

        * xmenu.c (menu_help_callback): Pointer type fixes.
        Use const pointers when pointing at readonly data.  Avoid pointer
        signedness clashes.
        (FALSE): Remove unused macro.
        (update_frame_menubar): Remove unused decl.

        * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.

        * menu.c (push_submenu_start, push_submenu_end): Do not define unless
        USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
        (single_menu_item): Rename local to avoid shadowing.

        * keyboard.c (make_lispy_event): Remove unused local var.

        * frame.c, frame.h (x_get_resource_string): Bring this back, but
        only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.

        * bitmaps: Change bitmaps from unsigned char back to the X11
        compatible char.  Avoid the old compiler warnings about
        out-of-range initializers by using, for example, '\xab' rather
        than 0xab.

        * xgselect.c (xgselect_initialize): Check vs interface
        even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).

        * xmenu.c (xmenu_show): Rename parm to avoid shadowing.

        * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
        to read-only memory.

        * fns.c (vector): Remove; this old hack is no longer needed.

        * xsmfns.c (create_client_leader_window): Rename shadowing arg.
        Remove unused var.
        (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.

        * xrdb.c (x_load_resources): Omit unused local.

        * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
        (x_window): Rename locals to avoid shadowing.
        (USG): Use the kludged USG macro, to pacify gcc.

        * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
        (x_term_init): Remove local to avoid shadowing.

        * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.

        * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
        USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.

2011-04-16  Eli Zaretskii  <eliz@gnu.org>

        * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.

        Fix regex.c, syntax.c and friends for buffers > 2GB.
        * syntax.h (struct gl_state_s): Declare character position members
        EMACS_INT.

        * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.

        * textprop.c (verify_interval_modification, interval_of): Declare
        arguments EMACS_INT.

        * intervals.c (adjust_intervals_for_insertion): Declare arguments
        EMACS_INT.

        * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.

        * indent.c (Fvertical_motion): Local variable it_start is now
        EMACS_INT.

        * regex.c (re_match, re_match_2, re_match_2_internal)
        (bcmp_translate, regcomp, regexec, print_double_string)
        (group_in_compile_stack, re_search, re_search_2, regex_compile)
        (re_compile_pattern, re_exec): Declare arguments and local
        variables `size_t' and `ssize_t' and return values `regoff_t', as
        appropriate.
        (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
        (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
        <compile_stack_type>: `size' and `avail' are now `size_t'.

        * regex.h <regoff_t>: Use ssize_t, not int.
        (re_search, re_search_2, re_match, re_match_2): Arguments that
        specify buffer/string position and length are now ssize_t and
        size_t.  Return type is regoff_t.

2011-04-16  Ben Key  <bkey76@gmail.com>

        * nsfont.m: Fixed bugs in ns_get_family and
        ns_descriptor_to_entity that were caused by using free to
        deallocate memory blocks that were allocated by xmalloc (via
        xstrdup).  This caused Emacs to crash when compiled with
        XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
        --enable-checking=xmallocoverrun).  xfree is now used to
        deallocate these memory blocks.

2011-04-15  Paul Eggert  <eggert@cs.ucla.edu>

        * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.

        emacs_write: Accept and return EMACS_INT for sizes.
        See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
        et seq.
        * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
        Accept and return EMACS_INT.
        (emacs_gnutls_write): Return the number of bytes written on
        partial writes.
        * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
        (emacs_read, emacs_write): Remove check for negative size, as the
        Emacs source code has been audited now.
        * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
        (emacs_read, emacs_write): Use it.
        * process.c (send_process): Adjust to the new signatures of
        emacs_write and emacs_gnutls_write.  Do not attempt to store
        a byte offset into an 'int'; it might overflow.
        See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html

        * sound.c: Don't assume sizes fit in 'int'.
        (struct sound_device.period_size, alsa_period_size):
        Return EMACS_INT, not int.
        (struct sound_device.write, vox_write, alsa_write):
        Accept EMACS_INT, not int.
        (wav_play, au_play): Use EMACS_INT to store sizes and to
        record read return values.

2011-04-15  Ben Key  <bkey76@gmail.com>

        * keyboard.c (Qundefined): Don't declare static since it is used
        in nsfns.m.
        * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
        static since they are used in nsfont.m.

2011-04-15  Stefan Monnier  <monnier@iro.umontreal.ca>

        * process.c (Qprocessp): Don't declare static.
        * lisp.h (Qprocessp): Declare again.

2011-04-15  Juanma Barranquero  <lekktu@gmail.com>

        * font.c (Qopentype): Don't make static (used from w32uniscribe.c).

2011-04-14  Paul Eggert  <eggert@cs.ucla.edu>

        Improve C-level modularity by making more things 'static'.

        Don't publish debugger-only interfaces to other modules.
        * lisp.h (safe_debug_print, debug_output_compilation_hack):
        (verify_bytepos, count_markers): Move decls to the only modules
        that need them.
        * region-cache.h (pp_cache): Likewise.
        * window.h (check_all_windows): Likewise.
        * marker.c, print.c, region-cache.c, window.c: Decls moved here.

        * sysdep.c (croak): Now static, if
        defined TIOCNOTTY || defined USG5 || defined CYGWIN.
        * syssignal.h (croak): Declare only if not static.

        * alloc.c (refill_memory_reserve): Now static if
        !defined REL_ALLOC || defined SYSTEM_MALLOC.
        * lisp.h (refill_memory_reserve): Declare only if not static.

        * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
        Define only if USE_LUCID.

        * xrdb.c (x_customization_string, x_rm_string): Now static.

        * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
        * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.

        * xdisp.c (draw_row_with_mouse_face): Now static.
        * dispextern.h (draw_row_with_mouse_fave): Remove decl.

        * window.h (check_all_windows): Mark externally visible.

        * window.c (window_deletion_count): Now static.

        * undo.c: Make symbols static if they're not exported.
        (last_undo_buffer, last_boundary_position, pending_boundary):
        Now static.

        * textprop.c (interval_insert_behind_hooks): Now static.
        (interval_insert_in_front_hooks): Likewise.

        * term.c: Make symbols static if they're not exported.
        (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
        (max_frame_lines, tty_set_terminal_modes):
        (tty_reset_terminal_modes, tty_turn_off_highlight):
        (get_tty_terminal): Now static.
        (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
        * termhooks.h (term_mouse_moveto): Do not declare if
        HAVE_WINDOW_SYSTEM.
        * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
        (tty_turn_off_highlight, get_tty_terminal): Remove decls.

        * sysdep.c: Make symbols static if they're not exported.
        (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
        Now static.
        (sigprocmask_set, full_mask): Remove; unused.
        (wait_debugging): Mark as visible.
        * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
        * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.

        * syntax.c (syntax_temp): Define only if !__GNUC__.

        * sound.c (current_sound_device, current_sound): Now static.

        * search.c (searchbufs, searchbuf_head): Now static.

        * scroll.c (scroll_cost): Remove; unused.
        * dispextern.h (scroll_cost): Remove decl.

        * region-cache.h (pp_cache): Mark as externally visible.

        * process.c: Make symbols static if they're not exported.
        (process_tick, update_tick, create_process, chan_process):
        (Vprocess_alist, proc_buffered_char, datagram_access):
        (fd_callback_data, send_process_frame, process_sent_to): Now static.
        (deactivate_process): Mark defn as static, as well as decl.
        * lisp.h (create_process): Remove decl.
        * process.h (chan_process, Vprocess_alist): Remove decls.

        * print.c: Make symbols static if they're not exported.
        (print_depth, new_backquote_output, being_printed, print_buffer):
        (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
        (print_interval, print_number_index, initial_stderr_stream):
        Now static.
        * lisp.h (Fprinc): Remove decl.
        (debug_output_compilation_hack): Mark as externally visible.

        * sysdep.c (croak): Move decl from here to syssignal.h.
        * syssignal.h (croak): Put it here, so the API can be checked when
        'croak' is called from dissociate_if_controlling_tty.

        * minibuf.c: Make symbols static if they're not exported.
        (minibuf_save_list, choose_minibuf_frame): Now static.
        * lisp.h (choose_minibuf_frame): Remove decl.

        * lisp.h (verify_bytepos, count_markers): Mark as externally visible.

        * lread.c: Make symbols static if they're not exported.
        (read_objects, initial_obarray, oblookup_last_bucket_number):
        Now static.
        (make_symbol): Remove; unused.
        * lisp.h (initial_obarray, make_symbol): Remove decls.

        * keyboard.c: Make symbols static if they're not exported.
        (single_kboard, recent_keys_index, total_keys, recent_keys):
        (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
        (this_single_command_key_start, echoing, last_auto_save):
        (read_key_sequence_cmd, dribble, recursive_edit_unwind):
        (command_loop, echo_now, keyboard_init_hook, help_char_p):
        (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
        (Vlispy_mouse_stem, double_click_count):
        Now static.
        (force_auto_save_soon): Define only if SIGDANGER.
        (ignore_mouse_drag_p): Now static if
        !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
        (print_help): Remove; unused.
        (stop_character, last_timer_event): Mark as externally visible.
        * keyboard.h (ignore_mouse_drag_p): Declare only if
        defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
        (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
        * lisp.h (echoing): Remove decl.
        (force_auto_save_soon): Declare only if SIGDANGER.
        * xdisp.c (redisplay_window): Simplify code, to make it more
        obvious that ignore_mouse_drag_p is not accessed if !defined
        USE_GTK && !defined HAVE_NS.

        * intervals.c: Make symbols static if they're not exported.
        (merge_properties_sticky, merge_interval_right, delete_interval):
        Now static.
        * intervals.h (merge_interval_right, delete_interval): Remove decls.

        * insdel.c: Make symbols static if they're not exported.
        However, leave prepare_to_modify_buffer alone.  It's never
        called from outside this function, but that appears to be a bug.
        (combine_after_change_list, combine_after_change_buffer):
        (adjust_after_replace, signal_before_change): Now static.
        (adjust_after_replace_noundo): Remove; unused.
        * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
        (signal_before_change): Remove decls.

        * indent.c (val_compute_motion, val_vmotion): Now static.

        * image.c: Make symbols static if they're not exported.
        * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
        if USE_GTK.
        * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
        (xpm_color_cache, ct_table, ct_colors_allocated): Now static.

        * fringe.c (standard_bitmaps): Now static.
        (max_used_fringe_bitmap): Now static, unless HAVE_NS.

        * frame.c: Make symbols static if they're not exported.
        (x_report_frame_params, make_terminal_frame): Now static.
        (get_frame_param): Now static, unless HAVE_NS.
        (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
        (x_get_resource_string): Remove; not used.
        * frame.h (make_terminal_frame, x_report_frame_params):
        (x_get_resource_string); Remove decls.
        (x_fullscreen_adjust): Declare only if WINDOWSNT.
        * lisp.h (get_frame_param): Declare only if HAVE_NS.

        * font.c, fontset.c: Make symbols static if they're not exported.
        * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
        (FACE_SUITABLE_FOR_CHAR_P): Use it.
        * font.c (font_close_object): Now static.
        * font.h (font_close_object): Remove.
        * fontset.c (FONTSET_OBJLIST): Remove.
        (free_realized_fontset) #if-0 the body, which does nothing.
        (face_suitable_for_char_p): #if-0, as it's never called.
        * fontset.h (face_suitable_for_char_p): Remove decl.
        * xfaces.c (face_at_string_position): Use
        FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
        since 0 is always ASCII.

        * fns.c (weak_hash_tables): Now static.

        * fileio.c: Make symbols static if they're not exported.
        (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
        (Vwrite_region_annotation_buffers): Now static.

        * eval.c: Make symbols static if they're not exported.
        (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
        * lisp.h (backtrace_list): Remove decl.

        * emacs.c: Make symbols static if they're not exported.
        (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
        (fatal_error_code, fatal_error_signal_hook, standard_args):
        Now static.
        (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
        (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
        (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
        * lisp.h (fatal_error_signal_hook): Remove decl.
        (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.

        * editfns.c: Move a (normally-unused) function to its only use.
        * editfns.c, lisp.h (get_operating_system_release): Remove.
        * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
        worth the hassle of breaking this out.

        * xterm.c: Make symbols static if they're not exported.
        (x_raise_frame, x_lower_frame, x_wm_set_window_state):
        (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
        (x_destroy_window, x_delete_display):
        Now static.
        (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
        (x_mouse_leave): Remove; unused.
        * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
        (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
        (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
        Remove decls.
        (x_mouse_leave): Declare only if WINDOWSNT.
        (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
        (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
        USE_X_TOOLKIT.

        * ftxfont.c: Make symbols static if they're not exported.
        (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
        HAVE_FREETYPE.
        * font.h (ftxfont_driver): Likewise.

        * xfns.c: Make symbols static if they're not exported.
        (x_last_font_name, x_display_info_for_name):
        (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
        (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
        (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
        (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
        (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
        (last_show_tip_args): Now static.
        (xic_defaut_fontset, xic_create_fontsetname): Define only if
        defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
        (x_screen_planes): Remove; unused.
        * dispextern.h (x_screen_planes): Remove decl.

        * dispnew.c: Make symbols static if they're not exported.
        * dispextern.h (redraw_garbaged_frames, scrolling):
        (increment_row_positions): Remove.
        * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
        (delayed_size_change, glyph_matrix_count, glyph_pool_count):
        Now static.
        (redraw_garbaged_frames): Remove; unused.

        * xfaces.c: Make symbols static if they're not exported.
        * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
        Remove decls.
        * xterm.h (defined_color): Remove decls.
        (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
        * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
        (menu_face_changed_default, defined_color, free_realized_face):
        (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
        (ascii_face_of_lisp_face): Remove; unused.

        * xdisp.c: Make symbols static if they're not exported.
        * dispextern.h (scratch_glyph_row, window_box_edges):
        (glyph_to_pixel_coords, set_cursor_from_row):
        (get_next_display_element, set_iterator_to_next):
        (highlight_trailing_whitespace, frame_to_window_pixel_xy):
        (show_mouse_face): Remove decls
        * frame.h (message_buf_print): Likewise.
        * lisp.h (pop_message, set_message, check_point_in_composition):
        Likewise.
        * xterm.h (set_vertical_scroll_bar): Likewise.
        * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
        (message_buf_print, scratch_glyph_row, displayed_buffer):
        (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
        (get_next_display_element, show_mouse_face, window_box_edges):
        (frame_to_window_pixel_xy, check_point_in_composition):
        (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
        (glyph_to_pixel_coords): Remove; unused.

        * dired.c (file_name_completion): Now static.

        * dbusbind.c (xd_in_read_queued_messages): Now static.

        * lisp.h (circular_list_error, FOREACH): Remove; unused.
        * data.c (circular_list_error): Remove.

        * commands.h (last_point_position, last_point_position_buffer):
        (last_point_position_window): Remove decls.
        * keyboard.c: Make these variables static.

        * coding.h (coding, code_convert_region, encode_coding_gap): Remove
        decls.
        * coding.c (Vsjis_coding_system, Vbig5_coding_system):
        (iso_code_class, detect_coding, code_convert_region): Now static.
        (encode_coding_gap): Remove; unused.

        * chartab.c (chartab_chars, chartab_bits): Now static.

        * charset.h (charset_iso_8859_1): Remove decl.
        * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
        Now static.

        * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
        * ccl.c (Vccl_program_table): Now static.
        (check_ccl_update): Remove; unused.

        * category.c (SET_CATEGORY_SET, set_category_set): Move here.
        * category.h: ... from here.
        * category.c (check_category_table, set_category_set): Now static.

        * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
        * lisp.h: Remove these decls.

        * buffer.c (buffer_count): Remove unused var.

        * bidi.c (bidi_dump_cached_states): Mark as externally visible,
        so that it's not optimized away.
        (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
        * dispextern.h (bidi_dump_cached_states): Remove, since it's
        exported only to the debugger.

        * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
        * atimer.h (run_all_atimers): Removed; not exported.

        font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
        * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
        was inaccessible from Lisp.
        (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
        * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.

        alloc.c: Import and export fewer symbols, and remove unused items.
        * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
        is defined.
        (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
        it's not optimized away by whole-program optimization.
        (message_enable_multibyte, free_misc): Remove.
        (catchlist, handlerlist, mark_backtrace):
        Declare only if BYTE_MARK_STACK.
        (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
        * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
        (message_enable_multibyte): Remove decl.
        (free_misc, interval_free_list, float_block, float_block_index):
        (n_float_blocks, float_free_list, cons_block, cons_block_index):
        (cons_free_list, last_marked_index):
        Now static.
        (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
        * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
        (mark_backtrace): Define only if BYTE_MARK_STACK.
        * xdisp.c (message_enable_multibyte): Now static.

        Declare Lisp_Object Q* variables to be 'static' if not exported.
        This makes it easier for human readers (and static analyzers)
        to see whether these variables are used from other modules.
        * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
        * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
        * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
        * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
        * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
        * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
        * xmenu.c, xselect.c:
        Declare Q* vars static if they are not used in other modules.
        * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
        * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
        Remove decls of unexported vars.
        * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.

        * lisp.h (DEFINE_FUNC): Make sname 'static'.

        Make Emacs functions such as Fatom 'static' by default.
        This makes it easier for human readers (and static analyzers)
        to see whether these functions can be called from other modules.
        DEFUN now defines a static function.  To make the function external
        so that it can be used in other C modules, use the new macro DEFUE.
        * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
        (Finit_image_library):
        (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
        (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
        (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
        Remove decls, since these functions are now static.
        (Funintern, Fget_internal_run_time): New decls, since these functions
        were already external.

        * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
        * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
        * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
        * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
        * keyboard.c, keymap.c, lread.c:
        * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
        * syntax.c, term.c, terminal.c, textprop.c, undo.c:
        * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
        Mark functions with DEFUE instead of DEFUN,
        if they are used in other modules.
        * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
        decls for now-static functions.
        * buffer.h (Fdelete_overlay): Remove decl.
        * callproc.c (Fgetenv_internal): Mark as internal.
        * composite.c (Fremove_list_of_text_properties): Remove decl.
        (Fcomposition_get_gstring): New forward static decl.
        * composite.h (Fcomposite_get_gstring): Remove decl.
        * dired.c (Ffile_attributes): New forward static decl.
        * doc.c (Fdocumntation_property): New forward static decl.
        * eval.c (Ffetch_bytecode): New forward static decl.
        (Funintern): Remove extern decl; now in .h file where it belongs.
        * fileio.c (Fmake_symbolic_link): New forward static decl.
        * image.c (Finit_image_library): New forward static decl.
        * insdel.c (Fcombine_after_change_execute): Make forward decl static.
        * intervals.h (Fprevious_property_change):
        (Fremove_list_of_text_properties): Remove decls.
        * keyboard.c (Fthis_command_keys): Remove decl.
        (Fcommand_execute): New forward static decl.
        * keymap.c (Flookup_key): New forward static decl.
        (Fcopy_keymap): Now static.
        * keymap.h (Flookup_key): Remove decl.
        * process.c (Fget_process): New forward static decl.
        (Fprocess_datagram_address): Mark as internal.
        * syntax.c (Fsyntax_table_p): New forward static decl.
        (skip_chars): Remove duplicate decl.
        * textprop.c (Fprevious_property_change): New forward static decl.
        * window.c (Fset_window_fringes, Fset_window_scroll_bars):
        Now internal.
        (Fset_window_margins, Fset_window_vscroll): New forward static decls.
        * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.

        * editfns.c (Fformat): Remove unreachable code.

2011-04-14  Andreas Schwab  <schwab@linux-m68k.org>

        * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
        change.  (Bug#8496)

2011-04-13  Eli Zaretskii  <eliz@gnu.org>

        * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
        when at ZV.  (Bug#8487)

2011-04-12  Andreas Schwab  <schwab@linux-m68k.org>

        * charset.c (Fclear_charset_maps): Use xfree instead of free.
        (Bug#8437)
        * keyboard.c (parse_tool_bar_item): Likewise.
        * sound.c (sound_cleanup, alsa_close): Likewise.
        * termcap.c (tgetent): Likewise.
        * xfns.c (x_default_font_parameter): Likewise.
        * xsettings.c (read_and_apply_settings): Likewise.

        * alloc.c (overrun_check_malloc, overrun_check_realloc)
        (overrun_check_free): Protoize.

2011-04-12  Paul Eggert  <eggert@cs.ucla.edu>

        * sysdep.c (emacs_read, emacs_write): Check for negative sizes
        since callers should never pass a negative size.
        Change the signature to match that of plain 'read' and 'write'; see
        <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
        * lisp.h: Update prototypes of emacs_write and emacs_read.

2011-04-11  Eli Zaretskii  <eliz@gnu.org>

        * xdisp.c (redisplay_window): Don't try to determine the character
        position of the scroll margin if the window start point w->startp
        is outside the buffer's accessible region.  (Bug#8468)

2011-04-10  Eli Zaretskii  <eliz@gnu.org>

        Fix write-region and its subroutines for buffers > 2GB.
        * fileio.c (a_write, e_write): Modify declaration of arguments and
        local variables to support buffers larger than 2GB.
        (Fcopy_file): Use EMACS_INT for return value of emacs_read.

        * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
        argument, local variables, and return value.

        * lisp.h: Update prototypes of emacs_write and emacs_read.

        * sound.c (vox_write): Use ssize_t for return value of emacs_write.

2011-04-10  Paul Eggert  <eggert@cs.ucla.edu>

        * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.

        Fix more problems found by GCC 4.6.0's static checks.

        * xdisp.c (vmessage): Use a better test for character truncation.

        * charset.c (load_charset_map): <, not <=, for optimization,
        and to avoid potential problems with integer overflow.
        * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
        * casetab.c (set_identity, shuffle): Likewise.
        * editfns.c (Fformat): Likewise.
        * syntax.c (skip_chars): Likewise.

        * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
        This also lets GCC 4.6.0 generate slightly better loop code.

        * callint.c (Fcall_interactively): <, not <=, for optimization.
        (Fcall_interactively): Count the number of arguments produced,
        not the number of arguments given.  This is simpler and lets GCC
        4.6.0 generate slightly better code.

        * ftfont.c: Distingish more carefully between FcChar8 and char.
        The previous code passed unsigned char * to a functions like
        strlen and xstrcasecmp that expect char *, which does not
        conform to the C standard.
        (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
        arguments to FcPatternGetString, and explicitly cast FcChar8 * to
        char * when the C standard requires it.

        * keyboard.c (read_char): Remove unused var.

        * eval.c: Port to Windows vsnprintf (Bug#8435).
        Include <limits.h>.
        (SIZE_MAX): Define if the headers do not.
        (verror): Do not give up if vsnprintf returns a negative count.
        Instead, grow the buffer.  This ports to Windows vsnprintf, which
        does not conform to C99.  Problem reported by Eli Zaretskii.
        Also, simplify the allocation scheme, by avoiding the need for
        calling realloc, and removing the ALLOCATED variable.

        * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.

        Remove invocations of doprnt, as Emacs now uses vsnprintf.
        But keep the doprint source code for now, as we might revamp it
        and use it again (Bug#8435).
        * lisp.h (doprnt): Remove.
        * Makefile.in (base_obj): Remove doprnt.o.
        * deps.mk (doprnt.o): Remove.

        error: Print 32- and 64-bit integers portably (Bug#8435).
        Without this change, on typical 64-bit hosts error ("...%d...", N)
        was used to print both 32- and 64-bit integers N, which relied on
        undefined behavior.
        * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
        New macro.
        * lisp.h (error, verror): Mark as printf-like functions.
        * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
        Report overflow in size calculations when allocating printf buffer.
        Do not truncate output string at its first null byte.
        * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
        Truncate the output at a character boundary, since vsnprintf does not
        do that.
        * charset.c (check_iso_charset_parameter): Convert internal
        character to string before calling 'error', since %c now has the
        printf meaning.
        * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
        overflow when computing char to be passed to 'error'.  Do not
        pass Lisp_Object to 'error'; pass the integer instead.
        * nsfns.m (Fns_do_applescript): Use int, not long, since it's
        formatted with plain %d.

        * eval.c (internal_lisp_condition_case): Don't pass spurious arg.

        * keyboard.c (access_keymap_keyremap): Print func name, not garbage.

        * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.

        * xterm.c (x_catch_errors): Remove duplicate declaration.

        * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.

        * xdisp.c, lisp.h (message_nolog): Remove; unused.

2011-04-10  Jim Meyering  <meyering@redhat.com>

        use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
        * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
        return ssize_t not "int", and use size_t as the buffer length.
        (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
        * gnutls.h: Update declarations.
        * process.c (read_process_output): Use ssize_t, to match.
        (send_process): Likewise.

2011-04-09  Chong Yidong  <cyd@stupidchicken.com>

        * image.c (Fimagemagick_types): Doc fix, and comment cleanup.

2011-04-09  Chong Yidong  <cyd@stupidchicken.com>

        * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
        unsigned char, to match FcChar8 type definition.

        * xterm.c (handle_one_xevent):
        * xmenu.c (create_and_show_popup_menu):
        * xselect.c (x_decline_selection_request)
        (x_reply_selection_request): Avoid type-punned deref of X events.

2011-04-09  Eli Zaretskii  <eliz@gnu.org>

        Fix some uses of `int' instead of EMACS_INT.
        * search.c (string_match_1, fast_string_match)
        (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
        (scan_buffer, find_next_newline_no_quit)
        (find_before_next_newline, search_command, Freplace_match)
        (Fmatch_data): Make some `int' variables be EMACS_INT.

        * xdisp.c (display_count_lines): 3rd argument and return value now
        EMACS_INT.  All callers changed.
        (pint2hrstr): Last argument is now EMACS_INT.

        * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
        (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
        (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
        (decode_coding_utf_16, decode_coding_emacs_mule)
        (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
        (decode_coding_ccl, decode_coding_charset)
        <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
        (decode_coding_iso_2022, decode_coding_emacs_mule)
        (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
        <char_offset, last_offset>: Declare EMACS_INT.
        (encode_coding_utf_8, encode_coding_utf_16)
        (encode_coding_emacs_mule, encode_invocation_designation)
        (encode_designation_at_bol, encode_coding_iso_2022)
        (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
        (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
        Declare EMACS_INT.
        (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
        (encode_invocation_designation): Last argument P_NCHARS is now
        EMACS_INT.
        (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
        (produce_chars): from_nchars and to_nchars are now EMACS_INT.

        * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
        All users changed.

        * ccl.c (Fccl_execute_on_string): Declare some variables
        EMACS_INT.

2011-04-08  Samuel Thibault  <sthibault@debian.org>  (tiny change)

        * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).

2011-03-19  Christoph Scholtes  <cschol2112@googlemail.com>

        * process.c (Fformat_network_address): Doc fix.

2011-04-08  T.V. Raman  <tv.raman.tv@gmail.com>  (tiny change)

        * xml.c (parse_region): Avoid creating spurious whiespace nodes.

2011-04-08  Chong Yidong  <cyd@stupidchicken.com>

        * keyboard.c (read_char): Call Lisp function help-form-show,
        instead of using internal_with_output_to_temp_buffer.
        (Qhelp_form_show): New var.
        (syms_of_keyboard): Use DEFSYM macro.

        * print.c (internal_with_output_to_temp_buffer): Function deleted.

        * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.

2011-04-06  Chong Yidong  <cyd@stupidchicken.com>

        * process.c (Flist_processes): Removed to Lisp.
        (list_processes_1): Deleted.

2011-04-06  Eli Zaretskii  <eliz@gnu.org>

        * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.

        * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.

2011-04-06  Paul Eggert  <eggert@cs.ucla.edu>

        Fix more problems found by GCC 4.6.0's static checks.

        * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.

        * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.

        * lisp.h (message, message_nolog, fatal): Mark as printf-like.

        * xdisp.c (vmessage): Mark as a printf-like function.

        * term.c (vfatal, maybe_fatal): Mark as printf-like functions.

        * sound.c (sound_warning): Don't crash if arg contains a printf format.

        * image.c (tiff_error_handler, tiff_warning_handler): Mark as
        printf-like functions.
        (tiff_load): Add casts to remove these marks before passing them
        to system-supplied API.

        * eval.c (Fsignal): Remove excess argument to 'fatal'.

        * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
        This avoids several warnings with gcc -Wstrict-overflow.
        (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
        directly, rather than having caller test rule sign.  This avoids
        some unnecessary tests.
        * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
        (COMPOSITION_ENCODE_RULE): Arguments now must be valid.  This
        affects only one use, in DECODE_COMPOSITION_RULE, which is changed.

        * xfont.c (xfont_text_extents): Remove var that was set but not used.
        (xfont_open): Avoid unnecessary tests.

        * composite.c (composition_gstring_put_cache): Use unsigned integer.

        * composite.h, composite.c (composition_gstring_put_cache):
        Use EMACS_INT, not int, for length.

        * composite.h (COMPOSITION_DECODE_REFS): New macro,
        breaking out part of COMPOSITION_DECODE_RULE.
        (COMPOSITION_DECODE_RULE): Use it.
        * composite.c (get_composition_id): Remove unused local vars,
        by using the new macro.

        * textprop.c (set_text_properties_1): Change while to do-while,
        since the condition is always true at first.

        * intervals.c (graft_intervals_into_buffer): Mark var as used.
        (interval_deletion_adjustment): Return unsigned value.
        All uses changed.

        * process.c (list_processes_1, create_pty, read_process_output):
        (exec_sentinel): Remove vars that were set but not used.
        (create_pty): Remove unnecessary "volatile"s.
        (Fnetwork_interface_info): Avoid possibility of int overflow.
        (read_process_output): Do adaptive read buffering even if carryover.
        (read_process_output): Simplify nbytes computation if buffered.

        * bytecode.c (exec_byte_code): Rename local to avoid shadowing.

        * syntax.c (scan_words): Remove var that was set but not used.
        (update_syntax_table): Use unsigned instead of int.

        * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
        (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
        (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.

        * print.c (print_error_message): Avoid int overflow.

        * font.c (font_list_entities): Redo for clarity,
        so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.

        * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
        (font_score): Avoid potential overflow in diff calculation.

        * fns.c (substring_both): Remove var that is set but not used.
        (sxhash): Redo loop for clarity and to avoid wraparound warning.

        * eval.c (funcall_lambda): Rename local to avoid shadowing.

        * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
        Otherwise, GCC 4.6.0 optimizes the loop check away since the check
        can always succeed if overflow has undefined behavior.

        * search.c (boyer_moore, wordify): Remove vars set but not used.
        (wordify): Omit three unnecessary tests.

        * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
        All callers changed.  This avoids the need for an unused var.

        * casefiddle.c (casify_region): Remove var that is set but not used.

        * dired.c (file_name_completion): Remove var that is set but not used.

        * fileio.c (Finsert_file_contents): Make EOF condition clearer.

        * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
        (Finsert_file_contents): Remove unnecessary code checking fd.

        * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
        Check for integer overflow on size calculations.

        * buffer.c (Fprevious_overlay_change): Remove var that is set
        but not used.

        * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
        Remove vars that are set but not used.
        (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
        (timer_check_2): Mark vars as initialized.

        * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.

        * image.c (lookup_image): Remove var that is set but not used.
        (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.

        * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
        that are set but not used.

        * xfns.c (make_invisible_cursor): Don't return garbage
        if XCreateBitmapFromData fails (Bug#8410).

        * xselect.c (x_get_local_selection, x_handle_property_notify):
        Remove vars that are set but not used.

        * xfns.c (x_create_tip_frame): Remove var that is set but not used.
        (make_invisible_cursor): Initialize a possibly-uninitialized variable.

        * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
        Remove var that is set but not used.
        (scroll_bar_windows_size): Now size_t, not int.
        (x_send_scroll_bar_event): Use size_t, not int, for sizes.
        Check for overflow.

        * xfaces.c (realize_named_face): Remove vars that are set but not used.
        (map_tty_color) [!defined MSDOS]: Likewise.

        * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.

        * coding.c: Remove vars that are set but not used.
        (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
        All callers changed.
        (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
        (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
        (decode_coding_charset): Remove vars that are set but not used.

        * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
        that is set but not used.

        * print.c (print_object): Remove var that is set but not used.

        Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
        The gnulib version avoids calling malloc in the usual case,
        and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
        * fileio.c (Ffile_symlink_p): Use emacs_readlink.
        * filelock.c (current_lock_owner): Likewise.
        * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
        * sysdep.c: Include allocator.h, careadlinkat.h.
        (emacs_no_realloc_allocator): New static constant.
        (emacs_readlink): New function.
        * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
        ../lib/careadlinkat.h.

2011-04-04  Stefan Monnier  <monnier@iro.umontreal.ca>

        * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
        first non-nil return value).

2011-04-03  Jan Djärv  <jan.h.d@swipnet.se>

        * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
        if not defined (Bug#8403).

2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

        * xdisp.c (display_count_lines): Remove parameter `start',
        unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
        (get_char_face_and_encoding): Remove parameter `multibyte_p',
        unused since 2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.
        (fill_stretch_glyph_string): Remove parameters `row' and `area',
        unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
        and thereabouts.  All callers changed.
        (get_per_char_metric): Remove parameter `f', unused since
        2008-05-14T01:40:23Z!handa@m17n.org.  All callers changed.

2011-04-02  Jim Meyering  <meyering@redhat.com>

        do not dereference NULL upon failed strdup
        * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
        (ns_get_family): Likewise.

2011-04-02  Juanma Barranquero  <lekktu@gmail.com>

        * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.

2011-04-02  Jan Djärv  <jan.h.d@swipnet.se>

        * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
        later (Bug#8403).

2011-04-01  Stefan Monnier  <monnier@iro.umontreal.ca>

        Add lexical binding.

        * window.c (Ftemp_output_buffer_show): New fun.
        (Fsave_window_excursion):
        * print.c (Fwith_output_to_temp_buffer): Move to subr.el.

        * lread.c (lisp_file_lexically_bound_p): New function.
        (Fload): Bind Qlexical_binding.
        (readevalloop): Remove `evalfun' arg.
        Bind Qinternal_interpreter_environment.
        (Feval_buffer): Bind Qlexical_binding.
        (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
        Mark as dynamic.
        (syms_of_lread): Declare `lexical-binding'.

        * lisp.h (struct Lisp_Symbol): New field `declared_special'.

        * keyboard.c (eval_dyn): New fun.
        (menu_item_eval_property): Use it.

        * image.c (parse_image_spec): Use Ffunctionp.

        * fns.c (concat, mapcar1): Accept byte-code-functions.

        * eval.c (Fsetq): Handle lexical vars.
        (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
        (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
        (FletX, Flet): Obey lexical binding.
        (Fcommandp): Handle closures.
        (Feval): New `lexical' arg.
        (eval_sub): New function extracted from Feval.  Use it almost
        everywhere where Feval was used.  Look up vars in lexical env.
        Handle closures.
        (Ffunctionp): Move from subr.el.
        (Ffuncall): Handle closures.
        (apply_lambda): Remove `eval_flags'.
        (funcall_lambda): Handle closures and new byte-code-functions.
        (Fspecial_variable_p): New function.
        (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
        but without exporting it to Lisp.

        * doc.c (Fdocumentation, store_function_docstring):
        * data.c (Finteractive_form): Handle closures.

        * callint.c (Fcall_interactively): Preserve lexical-binding mode for
        interactive spec.

        * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
        byte-codes.
        (exec_byte_code): New function extracted from Fbyte_code to handle new
        calling convention for byte-code-functions.  Add new byte-codes.

        * buffer.c (defvar_per_buffer): Set new `declared_special' field.

        * alloc.c (Fmake_symbol): Init new `declared_special' field.

2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

        * xdisp.c (redisplay_internal): Fix prototype.

2011-03-31  Eli Zaretskii  <eliz@gnu.org>

        * xdisp.c (SCROLL_LIMIT): New macro.
        (try_scrolling): Use it when setting scroll_limit.  Limit
        scrolling to 100 screen lines.
        (redisplay_window): Even when falling back on "recentering",
        position point in the window according to scroll-conservatively,
        scroll-margin, and scroll-*-aggressively variables.  (Bug#6671)

        (try_scrolling): When point is above the window, allow searching
        as far as scroll_max, or one screenful, to compute vertical
        distance from PT to the scroll margin position.  This prevents
        try_scrolling from unnecessarily failing when
        scroll-conservatively is set to a value slightly larger than the
        window height.  Clean up the case of PT below the margin at bottom
        of window: scroll_max can no longer be INT_MAX.  When aggressive
        scrolling is in use, don't let point enter the opposite scroll
        margin as result of the scroll.
        (syms_of_xdisp) <scroll-conservatively>: Document the
        threshold of 100 lines for never-recentering scrolling.

2011-03-31  Juanma Barranquero  <lekktu@gmail.com>

        * dispextern.h (move_it_by_lines):
        * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
        since 2000-12-29T14:24:09Z!gerd@gnu.org.  All callers changed.
        (message_log_check_duplicate): Remove parameters `prev_bol' and
        `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org.  All callers changed.
        (redisplay_internal): Remove parameter `preserve_echo_area',
        unused since 1999-07-21T21:43:52Z!gerd@gnu.org.  All callers changed.

        * indent.c (Fvertical_motion):
        * window.c (window_scroll_pixel_based, Frecenter):
        Don't pass `need_y_p' to `move_it_by_lines'.

2011-03-30  Stefan Monnier  <monnier@iro.umontreal.ca>

        * eval.c (struct backtrace): Don't cheat with negative numbers, but do
        steal a few bits to be more compact.
        (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
        Remove unneeded casts.

        * bytecode.c (Fbyte_code): CAR and CDR can GC.

2011-03-30  Zachary Kanfer  <zkanfer@gmail.com>  (tiny change)

        * keyboard.c (Fexecute_extended_command): Do log the "suggest key
        binding" message (bug#7967).

2011-03-30  Paul Eggert  <eggert@cs.ucla.edu>

        Fix more problems found by GCC 4.6.0's static checks.

        * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
        Remove unused local var.

        * editfns.c (Fmessage_box): Remove unused local var.

        * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
        (note_mode_line_or_margin_highlight, note_mouse_highlight):
        Omit unused local vars.
        * window.c (shrink_windows): Omit unused local var.
        * menu.c (digest_single_submenu): Omit unused local var.
        * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
        Omit unused local var.

        * keyboard.c (parse_modifiers_uncached, parse_modifiers):
        Don't assume string length fits in int.
        (keyremap_step, read_key_sequence): Use size_t for sizes.
        (read_key_sequence): Don't check last_real_key_start redundantly.

        * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
        instead of alloca (Bug#8344).

        * eval.c (Fbacktrace): Don't assume nargs fits in int.
        (Fbacktrace_frame): Don't assume nframes fits in int.

        * syntax.c (scan_sexps_forward): Avoid pointer wraparound.

        * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
        concerns.

        * term.c (produce_glyphless_glyph): Remove unnecessary test.

        * cm.c (calccost): Turn while-do into do-while, for clarity.

        * keyboard.c (syms_of_keyboard): Use the same style as later
        in this function when indexing through an array.  This also
        works around GCC bug 48267.

        * image.c (tiff_load): Fix off-by-one image count (Bug#8336).

        * xselect.c (x_check_property_data): Return correct size (Bug#8335).

        * chartab.c (sub_char_table_ref_and_range): Redo for slight
        efficiency gain, and to bypass a gcc -Wstrict-overflow warning.

        * keyboard.c, keyboard.h (num_input_events): Now size_t.
        This avoids undefined behavior on integer overflow, and is a bit
        more convenient anyway since it is compared to a size_t variable.

        Variadic C functions now count arguments with size_t, not int.
        This avoids an unnecessary limitation on 64-bit machines, which
        caused (substring ...) to crash on large vectors (Bug#8344).
        * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
        (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
        All variadic functions and their callers changed accordingly.
        (struct gcpro.nvars): Now size_t, not int.  All uses changed.
        * data.c (arith_driver, float_arith_driver): Likewise.
        * editfns.c (general_insert_function): Likewise.
        * eval.c (struct backtrace.nargs, interactive_p)
        (internal_condition_case_n, run_hook_with_args, apply_lambda)
        (funcall_lambda, mark_backtrace): Likewise.
        * fns.c (concat): Likewise.
        * frame.c (x_set_frame_parameters): Likewise.
        * fns.c (get_key_arg): Now accepts and returns size_t, and returns
        0 if not found, not -1.  All callers changed.

        * alloc.c (garbage_collect): Don't assume stack size fits in int.
        (stack_copy_size): Now size_t, not int.
        (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.

2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

        * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
        unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
        All callers changed.

        * lisp.h (multibyte_char_to_unibyte):
        * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
        unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
        * character.h (CHAR_TO_BYTE8):
        * cmds.c (internal_self_insert):
        * editfns.c (general_insert_function):
        * keymap.c (push_key_description):
        * search.c (Freplace_match):
        * xdisp.c (message_dolog, set_message_1): All callers changed.

2011-03-28  Stefan Monnier  <monnier@iro.umontreal.ca>

        * keyboard.c (safe_run_hook_funcall): New function.
        (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
        don't set the hook to nil, but remove the offending function instead.
        (Qcommand_hook_internal): Remove, unused.
        (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
        Vcommand_hook_internal.

        * eval.c (enum run_hooks_condition): Remove.
        (funcall_nil, funcall_not): New functions.
        (run_hook_with_args): Call each function through a `funcall' argument.
        Remove `cond' argument, now redundant.
        (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
        (Frun_hook_with_args_until_failure): Adjust accordingly.
        (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.

2011-03-28  Juanma Barranquero  <lekktu@gmail.com>

        * dispextern.h (string_buffer_position): Remove declaration.

        * print.c (strout): Remove parameter `multibyte', unused since
        1999-08-21T19:30:21Z!gerd@gnu.org.  All callers changed.

        * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
        never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
        All callers changed.

        * w32.c (_wsa_errlist): Use braces for struct initializers.

        * xdisp.c (string_buffer_position_lim): Remove parameter `w',
        never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
        All callers changed.
        (string_buffer_position): Likewise.  Also, make static (it's never
        used outside xdisp.c).
        (cursor_row_p): Remove parameter `w', unused since
        2000-10-17T16:08:57Z!gerd@gnu.org.  All callers changed.
        (decode_mode_spec): Remove parameter `precision', introduced during
        Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
        All callers changed.

2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

        * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.

2011-03-27  Anders Lindgren  <andlind@gmail.com>

        * nsterm.m (ns_menu_bar_is_hidden): New variable.
        (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
        (ns_update_auto_hide_menu_bar): New functions.
        (ns_update_begin): Call ns_update_auto_hide_menu_bar.
        (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
        ns_constrain_all_frames.
        (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
        (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.

2011-03-27  Jan Djärv  <jan.h.d@swipnet.se>

        * nsmenu.m (runDialogAt): Remove argument to timer_check.

2011-03-27  Glenn Morris  <rgm@gnu.org>

        * syssignal.h: Replace RETSIGTYPE with void.
        * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
        * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
        Replace SIGTYPE with void everywhere.
        * s/usg5-4-common.h (SIGTYPE): Remove definition.
        * s/template.h (SIGTYPE): Remove commented out definition.

2011-03-26  Eli Zaretskii  <eliz@gnu.org>

        * xdisp.c (redisplay_window): Don't check buffer's clip_changed
        flag as a prerequisite for invoking try_scrolling.  (Bug#6671)

2011-03-26  Juanma Barranquero  <lekktu@gmail.com>

        * w32.c (read_unc_volume): Use parameter `henum', instead of
        global variable `wget_enum_handle'.

        * keymap.c (describe_vector): Remove parameters `indices' and
        `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
        (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.

        * keyboard.h (timer_check, show_help_echo): Remove unused parameters.

        * keyboard.c (timer_check): Remove parameter `do_it_now',
        unused since 1996-04-12T06:01:29Z!rms@gnu.org.
        (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
        unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.

        * keyboard.c (read_char):
        * w32menu.c (w32_menu_display_help):
        * xmenu.c (show_help_event, menu_help_callback):
        Adjust calls to `show_help_echo'.

        * gtkutil.c (xg_maybe_add_timer):
        * keyboard.c (readable_events):
        * process.c (wait_reading_process_output):
        * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.

        * insdel.c (adjust_markers_gap_motion):
        Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
        (gap_left, gap_right): Don't call it.

2011-03-25  Chong Yidong  <cyd@stupidchicken.com>

        * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
        incurred during fontification.

2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

        * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
        (DEFVAR_PER_BUFFER): Don't pass it.

        * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
        (scrolling_window): Don't pass it.

2011-03-25  Juanma Barranquero  <lekktu@gmail.com>

        * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.

        * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
        and `suffix'.
        (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
        of variables specific to SELinux and computation of `encoded_absname'.

        * image.c (XPutPixel): Remove unused variable `height'.

        * keyboard.c (make_lispy_event): Remove unused variable `hpos'.

        * unexw32.c (get_section_info): Remove unused variable `section'.

        * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
        (system_process_attributes): Remove unused variable `sess'.
        (sys_read): Remove unused variable `err'.

        * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
        (w32_wnd_proc): Remove unused variable `isdead'.
        (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
        (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
        (x_create_tip_frame): Remove unused variable `tem'.

        * w32inevt.c (w32_console_read_socket):
        Remove unused variable `no_events'.

        * w32term.c (x_draw_composite_glyph_string_foreground):
        Remove unused variable `width'.

2011-03-24  Juanma Barranquero  <lekktu@gmail.com>

        * w32term.c (x_set_glyph_string_clipping):
        Don't pass uninitialized region to CombineRgn.

2011-03-23  Juanma Barranquero  <lekktu@gmail.com>

        * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
        (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
        (Fx_close_connection): Remove unused variable `i'.

        * w32font.c (w32font_draw): Return number of glyphs.
        (w32font_open_internal): Remove unused variable `i'.
        (w32font_driver): Add missing initializer.

        * w32menu.c (utf8to16): Remove unused variable `utf16'.
        (fill_in_menu): Remove unused variable `items_added'.

        * w32term.c (last_mouse_press_frame): Remove static global variable.
        (w32_clip_to_row): Remove unused variable `f'.
        (x_delete_terminal): Remove unused variable `i'.

        * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
        (NOTHING): Remove unused static global variable.
        (uniscribe_check_otf): Remove unused variable `table'.
        (uniscribe_font_driver): Add missing initializers.

2011-03-23  Julien Danjou  <julien@danjou.info>

        * term.c (Fsuspend_tty, Fresume_tty):
        * minibuf.c (read_minibuf, run_exit_minibuf_hook):
        * window.c (temp_output_buffer_show):
        * insdel.c (signal_before_change):
        * frame.c (Fhandle_switch_frame):
        * fileio.c (Fdo_auto_save):
        * emacs.c (Fkill_emacs):
        * editfns.c (save_excursion_restore):
        * cmds.c (internal_self_insert):
        * callint.c (Fcall_interactively):
        * buffer.c (Fkill_all_local_variables):
        * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
        Use Frun_hooks.
        (command_loop_1): Use Frun_hooks.  Call safe_run_hooks
        unconditionnaly since it does the check itself.

2011-03-23  Paul Eggert  <eggert@cs.ucla.edu>

        Fix more problems found by GCC 4.5.2's static checks.

        * coding.c (encode_coding_raw_text): Avoid unnecessary test
        the first time through the loop, since we know p0 < p1 then.
        This also avoids a gcc -Wstrict-overflow warning.

        * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
        leading to a memory leak, possible in functions like
        load_charset_map_from_file that can allocate an unbounded number
        of objects (Bug#8318).

        * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
        that could (at least in theory) be that large.

        * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
        This is less likely to overflow, and avoids undefined behavior if
        overflow does occur.  All callers changed.  Use strtoul to scan
        for the unsigned long integer.
        (pint2hrstr): Simplify and tune code slightly.
        This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.

        * scroll.c (do_scrolling): Work around GCC bug 48228.
        See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.

        * frame.c (Fmodify_frame_parameters): Simplify loop counter.
        This also avoids a warning with gcc -Wstrict-overflow.
        (validate_x_resource_name): Simplify count usage.
        This also avoids a warning with gcc -Wstrict-overflow.

        * fileio.c (Fcopy_file): Report error if fchown or fchmod
        fail (Bug#8306).

        * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).

        * process.c (Fmake_network_process): Use socklen_t, not int,
        where POSIX says socklen_t is required in portable programs.
        This fixes a porting bug on hosts like 64-bit HP-UX, where
        socklen_t is wider than int (Bug#8277).
        (Fmake_network_process, server_accept_connection):
        (wait_reading_process_output, read_process_output):
        Likewise.

        * process.c: Rename or move locals to avoid shadowing.
        (list_processes_1, Fmake_network_process):
        (read_process_output_error_handler, exec_sentinel_error_handler):
        Rename or move locals.
        (Fmake_network_process): Define label "retry_connect" only if needed.
        (Fnetwork_interface_info): Fix pointer signedness.
        (process_send_signal): Add cast to avoid pointer signedness problem.
        (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
        (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).

        Make tparam.h and terminfo.c consistent.
        * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
        Include tparam.h instead, since it declares them.
        * cm.h (PC): Remove extern decl; tparam.h now does this.
        * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
        * terminfo.c: Include tparam.h, to check interfaces.
        (tparm): Make 1st arg a const pointer in decl.  Put it at top level.
        (tparam): Adjust signature to match interface in tparam.h;
        this removes some undefined behavior.  Check that outstring and len
        are zero, which they always are with Emacs.
        * tparam.h (PC, BC, UP): New extern decls.

        * xftfont.c (xftfont_shape): Now static, and defined only if needed.
        (xftfont_open): Rename locals to avoid shadowing.

        * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
        (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
        (OTF_TAG_SYM): Omit macro if not needed.
        (ftfont_list): Remove unused local.
        (get_adstyle_property, ftfont_pattern_entity):
        (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
        Rename locals to avoid shadowing.

        * xfont.c (xfont_list_family): Mark var as initialized.

        * xml.c (make_dom): Now static.

        * composite.c (composition_compute_stop_pos): Rename local to
        avoid shadowing.
        (composition_reseat_it): Remove unused locals.
        (find_automatic_composition, composition_adjust_point): Likewise.
        (composition_update_it): Mark var as initialized.
        (find_automatic_composition): Mark vars as initialized,
        with a FIXME (Bug#8290).

        character.h: Rename locals to avoid shadowing.
        * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
        (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
        (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
        (BUF_DEC_POS): Be more systematic about renaming local temporaries
        to avoid shadowing.

        * textprop.c (property_change_between_p): Remove; unused.

        * intervals.c (interval_start_pos): Now static.

        * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".

        * atimer.c (start_atimer, append_atimer_lists, set_alarm):
        Rename locals to avoid shadowing.

        * sound.c (wav_play, au_play, Fplay_sound_internal):
        Fix pointer signedness.
        (alsa_choose_format): Remove unused local var.
        (wav_play): Initialize a variable to 0, to prevent undefined
        behavior (Bug#8278).

        * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.

        * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.

        * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
        clobbering (Bug#8298).
        * sysdep.c (sys_subshell): Likewise.
        Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.

        * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
        This should get cleaned up, so that child_setup has the
        same signature on all platforms.

        * callproc.c (call_process_cleanup): Now static.
        (relocate_fd): Rename locals to avoid shadowing.

2011-03-22  Chong Yidong  <cyd@stupidchicken.com>

        * xterm.c (x_clear_frame): Remove XClearWindow call.  This appears
        not to be necessary, and produces flickering.

2011-03-20  Glenn Morris  <rgm@gnu.org>

        * config.in: Remove file.

2011-03-20  Juanma Barranquero  <lekktu@gmail.com>

        * minibuf.c (Vcompleting_read_function): Don't declare, global variables
        are now in src/globals.h.
        (syms_of_minibuf): Remove spurious & from previous change.

2011-03-20  Leo  <sdl.web@gmail.com>

        * minibuf.c (completing-read-function): New variable.
        (completing-read-default): Rename from completing-read.
        (completing-read): Call completing-read-function.

2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

        * xfaces.c (Fx_load_color_file):
        Read color file from absolute filename (bug#8250).

2011-03-19  Juanma Barranquero  <lekktu@gmail.com>

        * makefile.w32-in: Update dependencies.

2011-03-17  Eli Zaretskii  <eliz@gnu.org>

        * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.

2011-03-17  Paul Eggert  <eggert@cs.ucla.edu>

        Fix more problems found by GCC 4.5.2's static checks.

        * process.c (make_serial_process_unwind, send_process_trap):
        (sigchld_handler): Now static.

        * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
        That way, the code declares only the vars that it needs.
        * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
        * s/cygwin.h (PTY_ITERATION): Likewise.
        * s/darwin.h (PTY_ITERATION): Likewise.
        * s/gnu-linux.h (PTY_ITERATION): Likewise.

        * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
        * process.c (allocate_pty): Don't declare stb unless it's needed.

        * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
        (CONSTANTLIM): Remove; unused.
        (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
        Define only if needed.

        * unexelf.c (unexec): Name an expression,
        to avoid gcc -Wbad-function-cast warning.
        Use a different way to cause a compilation error if anyone uses
        n rather than nn, a way that does not involve shadowing.
        (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.

        * deps.mk (unexalpha.o): Remove; unused.

        New file unexec.h, the (simple) interface for unexec (Bug#8267).
        * unexec.h: New file.
        * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
        (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
        Depend on unexec.h.
        * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
        * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
        * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
        Change as necessary to match prototype in unexec.h.

        * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
        shadowing.
        (back_comment, skip_chars): Mark vars as initialized.

        * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
        Rename locals to avoid shadowing.

        * lread.c (read1): Rewrite so as not to use empty "else".
        (Fload, readevalloop, read1): Rename locals to avoid shadowing.

        * print.c (Fredirect_debugging_output): Fix pointer signedess.

        * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
        warning when compiling print.c.

        * font.c (font_unparse_fcname): Abort in an "impossible" situation
        instead of using an uninitialized var.
        (font_sort_entities): Mark var as initialized.

        * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.

        * font.c (font_unparse_xlfd): Don't mix pointers to variables with
        pointers to constants.
        (font_parse_fcname): Remove unused vars.
        (font_delete_unmatched): Now static.
        (font_get_spec): Remove; unused.
        (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
        (font_update_drivers, Ffont_get_glyphs, font_add_log):
        Rename or move locals to avoid shadowing.

        * fns.c (require_nesting_list, require_unwind): Now static.
        (Ffillarray): Rename locals to avoid shadowing.

        * floatfns.c (domain_error2): Define only if needed.
        (Ffrexp, Fldexp): Rename locals to avoid shadowing.

        * alloc.c (mark_backtrace): Move decl from here ...
        * lisp.h: ... to here, so that it can be checked.

        * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
        (Fdefvar): Rewrite so as not to use empty "else".
        (lisp_indirect_variable): Name an expression,
        to avoid gcc -Wbad-function-cast warning.
        (Fdefvar): Rename locals to avoid shadowing.

        * callint.c (quotify_arg, quotify_args): Now static.
        (Fcall_interactively): Rename locals to avoid shadowing.
        Use const pointer when appropriate.

        * lisp.h (get_system_name, get_operating_system_release):
        Move decls here, to check interfaces.
        * process.c (get_operating_system_release): Move decl to lisp.h.
        * xrdb.c (get_system_name): Likewise.
        * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
        (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
        some of which prompt warnings from gcc -Wbad-function-cast.
        (Fformat_time_string, Fencode_time, Finsert_char):
        (Ftranslate_region_internal, Fformat):
        Rename or remove local vars to avoid shadowing.
        (Ftranslate_region_internal): Mark var as initialized.

        * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
        avoid shadowing.

        * lisp.h (eassert): Check that the argument compiles, even if
        ENABLE_CHECKING is not defined.

        * data.c (Findirect_variable): Name an expression, to avoid
        gcc -Wbad-function-cast warning.
        (default_value, arithcompare, arith_driver, arith_error): Now static.
        (store_symval_forwarding): Rename local to avoid shadowing.
        (Fmake_variable_buffer_local, Fmake_local_variable):
        Mark variables as initialized.
        (do_blv_forwarding, do_symval_forwarding): Remove; unused.

        * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
        (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
        Rename locals to avoid shadowing.
        (mark_stack): Move local variables into the #ifdef region where
        they're used.
        (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
        ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
        needed otherwise.
        (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
        (GC_STRING_CHARS): Remove; not used.
        (Fmemory_limit): Cast sbrk's returned value to char *.

        * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
        avoids undefined behavior in theory.

        * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.

        Use functions, not macros, for up- and down-casing (Bug#8254).
        * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
        (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove.  All callers changed
        to use the following functions instead of these macros.
        (downcase): Adjust to lack of DOWNCASE_TABLE.  Return int, not
        EMACS_INT, since callers assume the returned value fits in int.
        (upcase1): Likewise, for UPCASE_TABLE.
        (uppercasep, lowercasep, upcase): New static inline functions.
        * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
        the race-condition problem in the old DOWNCASE.

        * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
        Rename locals to avoid shadowing.
        (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
        (regex_compile, re_search_2, re_match_2_internal):
        Remove unused local vars.
        (FREE_VAR): Rewrite so as not to use empty "else",
        which gcc can warn about.
        (regex_compile, re_match_2_internal): Mark locals as initialized.
        (RETALLOC_IF): Define only if needed.
        (WORDCHAR_P): Likewise.  This one is never needed, but is used
        only in a comment talking about a compiler bug, so put inside
        the #if 0 of that comment.
        (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
        (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
        Remove; unused.

        * search.c (boyer_moore): Rename locals to avoid shadowing.
        * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
        (PREV_CHAR_BOUNDARY): Likewise.

        * search.c (simple_search): Remove unused var.

        * dired.c (compile_pattern): Move decl from here ...
        * lisp.h: ... to here, so that it can be checked.
        (struct re_registers): New forward decl.

        * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.

        * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
        All uses changed.
        (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
        Rename locals to avoid shadowing.
        (Fvertical_motion): Mark locals as initialized.

        * casefiddle.c (casify_object, casify_region): Now static.
        (casify_region): Mark local as initialized.

        * cmds.c (internal_self_insert): Rename local to avoid shadowing.

        * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
        New macros, so that the caller can use some names other than
        gcpro1, gcpro2, etc.
        (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
        of the new macros.
        (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
        argument, for consistency with GCPRO2_VAR, etc: it is now the
        prefix of the variable, not the variable itself.  All uses
        changed.
        * dired.c (directory_files_internal, file_name_completion):
        Rename locals to avoid shadowing.

        Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
        An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
        dired.c's scmp function, had undefined behavior.
        * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
        (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
        * buffer.h: ... to here, because these macros use current_buffer,
        and the new implementation with inline functions needs to have
        current_buffer in scope now, rather than later when the macros
        are used.
        (downcase, upcase1): New static inline functions.
        (DOWNCASE, UPCASE1): Reimplement using these functions.
        This avoids undefined behavior in expressions like
        DOWNCASE (x) == DOWNCASE (y), which previously suffered
        from race conditions in accessing the global variables
        case_temp1 and case_temp2.
        * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
        * lisp.h (case_temp1, case_temp2): Remove their decls.
        * character.h (ASCII_CHAR_P): Move from here ...
        * lisp.h: ... to here, so that the inline functions mentioned
        above can use them.

        * dired.c (directory_files_internal_unwind): Now static.

        * fileio.c (file_name_as_directory, directory_file_name):
        (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
        Now static.
        (file_name_as_directory): Use const pointers when appropriate.
        (Fexpand_file_name): Likewise.  In particular, newdir might
        point at constant storage, so make it a const pointer.
        (Fmake_directory_internal, Fread_file_name): Remove unused vars.
        (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
        signedness issues.
        (Fset_file_times, Finsert_file_contents, auto_save_error):
        Rename locals to avoid shadowing.

        * minibuf.c (choose_minibuf_frame_1): Now static.
        (Ftry_completion, Fall_completions): Rename or remove locals
        to avoid shadowing.

        * marker.c (bytepos_to_charpos): Remove; unused.

        * lisp.h (verify_bytepos, count_markers): New decls,
        so that gcc does not warn that these functions aren't declared.

        * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
        (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
        (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
        (copy_text): Remove unused local var.

        * filelock.c (within_one_second): Now static.
        (lock_file_1): Rename local to avoid shadowing.

        * buffer.c (fix_overlays_before): Mark locals as initialized.
        (fix_start_end_in_overlays): Likewise.  This function should be
        simplified by using pointers-to-pointers, but that's a different
        matter.
        (switch_to_buffer_1): Now static.
        (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
        (report_overlay_modification): Rename locals to avoid shadowing.

        * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
        Fix pointer signedness issue.
        (sys_subshell): Mark local as volatile if checking for lint,
        to suppress a gcc -Wclobbered warning that does not seem to be right.
        (MAXPATHLEN): Define only if needed.

        * process.c (serial_open, serial_configure): Move decls from here ...
        * systty.h: ... to here, so that they can be checked.

        * fns.c (get_random, seed_random): Move extern decls from here ...
        * lisp.h: ... to here, so that they can be checked.

        * sysdep.c (reset_io): Now static.
        (wait_for_termination_signal): Remove; unused.

        * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
        (copy_keymap_item, append_key, push_text_char_description):
        Now static.
        (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
        (DENSE_TABLE_SIZE): Remove; unused.
        (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
        (describe_map_tree):
        Rename locals to avoid shadowing.

        * keyboard.c: Declare functions static if they are not used elsewhere.
        (echo_char, echo_dash, cmd_error, top_level_2):
        (poll_for_input, handle_async_input): Now static.
        (read_char, kbd_buffer_get_event, make_lispy_position):
        (make_lispy_event, make_lispy_movement, apply_modifiers):
        (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
        (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
        (Fread_key_sequence_vector): Rename locals to avoid shadowing.
        (read_key_sequence, read_char): Mark locals as initialized.
        (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.

        * keyboard.h (make_ctrl_char): New decl.
        (mark_kboards): Move decl here ...
        * alloc.c (mark_kboards): ... from here.

        * lisp.h (force_auto_save_soon): New decl.

        * emacs.c (init_cmdargs): Rename local to avoid shadowing.
        (DEFINE_DUMMY_FUNCTION): New macro.
        (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
        Use it.
        (main): Add casts to avoid warnings
        if GCC considers string literals to be constants.

        * lisp.h (fatal_error_signal): Add decl, since it's exported.

        * dbusbind.c: Pointer signedness fixes.
        (xd_signature, xd_append_arg, xd_initialize):
        (Fdbus_call_method, Fdbus_call_method_asynchronously):
        (Fdbus_method_return_internal, Fdbus_method_error_internal):
        (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
        (Fdbus_register_signal): Use SSDATA when the context wants char *.

        * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
        if GCC considers string literals to be constants.
        (Fdbus_register_service, Fdbus_register_method): Remove unused vars.

2011-03-16  Stefan Monnier  <monnier@iro.umontreal.ca>

        * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
        (print_preprocess, print_object): New macro to fix last change.

        * print.c (print_preprocess): Don't forget font objects.

2011-03-16  Juanma Barranquero  <lekktu@gmail.com>

        * emacs.c (USAGE3): Doc fixes.

2011-03-15  Andreas Schwab  <schwab@linux-m68k.org>

        * coding.c (detect_coding_iso_2022): Reorganize code to clarify
        structure.

2011-03-14  Juanma Barranquero  <lekktu@gmail.com>

        * lisp.h (VWindow_system, Qfile_name_history):
        * keyboard.h (lispy_function_keys) [WINDOWSNT]:
        * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
        (w32_system_caret_x, w32_system_caret_y): Declare extern.

        * w32select.c: Don't #include "keyboard.h".
        (run_protected): Add extern declaration for waiting_for_input.

        * w32.c (Qlocal, noninteractive1, inhibit_window_system):
        * w32console.c (detect_input_pending, read_input_pending)
        (encode_terminal_code):
        * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
        (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
        (w32_system_caret_y, Qfile_name_history):
        * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
        * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
        * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
        (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
        * w32proc.c (Qlocal, report_file_error):
        * w32term.c (Vwindow_system, updating_frame):
        * w32uniscribe.c (initialized, uniscribe_font_driver):
        Remove unneeded extern declarations.

2011-03-14  Chong Yidong  <cyd@stupidchicken.com>

        * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.

2011-03-13  Chong Yidong  <cyd@stupidchicken.com>

        * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
        (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
        These macros can no longer be used for assignment.

        * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
        Assign struct members directly, instead of using BUF_BEGV etc.
        (record_buffer_markers, fetch_buffer_markers): New functions for
        recording and fetching special buffer markers.
        (set_buffer_internal_1, set_buffer_temp): Use them.

        * lread.c (unreadchar): Use SET_BUF_PT_BOTH.

        * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.

        * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
        (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.

        * xdisp.c (hscroll_window_tree):
        (reconsider_clip_changes): Use PT instead of BUF_PT.

2011-03-13  Eli Zaretskii  <eliz@gnu.org>

        * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
        $(EMACS_ROOT)/lib/intprops.h.

2011-03-13  Paul Eggert  <eggert@cs.ucla.edu>

        Fix more problems found by GCC 4.5.2's static checks.

        * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
        to unsigned char * to avoid compiler diagnostic.
        (xg_free_frame_widgets): Make it clear that a local variable is
        needed only if USE_GTK_TOOLTIP.
        (gdk_window_get_screen): Make it clear that this macro is needed
        only if USE_GTK_TOOLTIP.
        (int_gtk_range_get_value): New function, which avoids a diagnostic
        from gcc -Wbad-function-cast.
        (xg_set_toolkit_scroll_bar_thumb): Use it.
        (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
        diagnostic from gcc -Wbad-function-cast.
        (get_utf8_string, xg_get_file_with_chooser):
        Rename locals to avoid shadowing.
        (create_dialog): Move locals to avoid shadowing.

        * xgselect.c (xg_select): Remove unused var.

        * image.c (four_corners_best): Mark locals as initialized.
        (gif_load): Initialize transparent_p to zero (Bug#8238).
        Mark another local as initialized.
        (my_png_error, my_error_exit): Mark with NO_RETURN.

        * image.c (clear_image_cache): Now static.
        (DIM, HAVE_STDLIB_H_1): Remove unused macros.
        (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
        (x_edge_detection): Remove unnecessary cast that
        gcc -Wbad-function-cast diagnoses.
        (gif_load): Fix pointer signedness.
        (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
        (jpeg_load, gif_load): Rename locals to avoid shadowing.

2011-03-12  Paul Eggert  <eggert@cs.ucla.edu>

        Improve quality of tests for time stamp overflow.
        For example, without this patch (encode-time 0 0 0 1 1
        1152921504606846976) returns the obviously-bogus value (-948597
        62170) on my RHEL 5.5 x86-64 host.  With the patch, it correctly
        reports time overflow.  See
        <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
        * deps.mk (editfns.o): Depend on ../lib/intprops.h.
        * editfns.c: Include limits.h and intprops.h.
        (TIME_T_MIN, TIME_T_MAX): New macros.
        (time_overflow): Move earlier, to before first use.
        (hi_time, lo_time): New functions, for an accurate test for
        out-of-range times.
        (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
        (Fget_internal_run_time): Don't assume time_t fits in int.
        (make_time): Use list2 instead of Fcons twice.
        (Fdecode_time): More accurate test for out-of-range times.
        (check_tm_member): New function.
        (Fencode_time): Use it, to test for out-of-range times.
        (lisp_time_argument): Don't rely on undefined left-shift and
        right-shift behavior when checking for time stamp overflow.

        * editfns.c (time_overflow): New function, refactoring common code.
        (Fformat_time_string, Fdecode_time, Fencode_time):
        (Fcurrent_time_string): Use it.

        Move 'make_time' to be next to its inverse 'lisp_time_argument'.
        * dired.c (make_time): Move to ...
        * editfns.c (make_time): ... here.
        * systime.h: Note the move.

2011-03-12  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>

        * fringe.c (update_window_fringes): Remove unused variables.

        * unexmacosx.c (copy_data_segment): Also copy __got section.
        (Bug#8223)

2011-03-12  Eli Zaretskii  <eliz@gnu.org>

        * termcap.c [MSDOS]: Include "msdos.h".
        (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
        Constify `char *' arguments and their references according to
        prototypes in tparam.h.

        * deps.mk (termcap.o): Depend on tparam.h and msdos.h.

        * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
        Adapt all references accordingly.

        * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.

2011-03-11  Tom Tromey  <tromey@redhat.com>

        * buffer.c (syms_of_buffer): Remove obsolete comment.

2011-03-11  Eli Zaretskii  <eliz@gnu.org>

        * termhooks.h (encode_terminal_code): Declare prototype.

        * msdos.c (encode_terminal_code): Don't declare prototype.

        * term.c (encode_terminal_code): Now external again, used by
        w32console.c and msdos.c.

        * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
        Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.

2011-03-11  Paul Eggert  <eggert@cs.ucla.edu>

        Fix some minor problems found by GCC 4.5.2's static checks.

        * fringe.c (update_window_fringes): Mark locals as initialized
        (Bug#8227).
        (destroy_fringe_bitmap, init_fringe_bitmap): Now static.

        * alloc.c (mark_fringe_data): Move decl from here ...
        * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
        to check its interface.
        (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.

        * fontset.c (free_realized_fontset): Now static.
        (Fset_fontset_font): Rename local to avoid shadowing.
        (fontset_font): Mark local as initialized.
        (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.

        * xrdb.c: Include "xterm.h", to check x_load_resources's interface.

        * xselect.c (x_disown_buffer_selections): Remove; not used.
        (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
        (x_own_selection, Fx_disown_selection_internal): Rename locals
        to avoid shadowing.
        (x_handle_dnd_message): Remove local to avoid shadowing.

        * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
        so that the caller can use some name other than gcpro1.
        (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
        * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
        (Fx_backspace_delete_keys_p):
        Use them to avoid shadowing, and rename vars to avoid shadowing.
        (x_decode_color, x_set_name, x_window): Now static.
        (Fx_create_frame): Add braces to silence GCC warning.
        (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
        (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
        Remove unused locals.
        (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
        (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
        Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
        macros.

        * xterm.h (x_mouse_leave): New decl.

        * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
        Remove unused functions.
        (x_shift_glyphs_for_insert, XTflash, XTring_bell):
        (x_calc_absolute_position): Now static.
        (XTread_socket): Don't define label "out" unless it's used.
        Don't declare local "event" unless it's used.
        (x_iconify_frame, x_free_frame_resources): Don't declare locals
        unless they are used.
        (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
        (x_fatal_error_signal): Remove; not used.
        (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
        (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
        (x_error_catcher, x_connection_closed, x_error_handler):
        (x_error_quitter, xembed_send_message, x_iconify_frame):
        (my_log_handler): Rename locals to avoid shadowing.
        (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
        (x_connection_closed): Tell GCC not to suggest NO_RETURN.

        * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
        Rename or move locals to avoid shadowing.
        (tty_defined_color, merge_face_heights): Now static.
        (free_realized_faces_for_fontset): Remove; not used.
        (Fx_list_fonts): Mark variable that gcc -Wuninitialized
        does not deduce is never used uninitialized.
        (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
        (LFACEP): Define only if XASSERTS, as it's not needed otherwise.

        * terminal.c (store_terminal_param): Now static.

        * xmenu.c (menu_highlight_callback): Now static.
        (set_frame_menubar): Remove unused local.
        (xmenu_show): Rename parameter to avoid shadowing.
        (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
        since they might point to immutable storage.
        (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
        since it's unused otherwise.

        * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
        Add a FIXME, since the code still doesn't look right.  (Bug#8215)
        (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
        avoids a gcc -Wuninitialized diagnostic.
        (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
        (note_mouse_highlight): Mark variables that gcc -Wuninitialized
        does not deduce are never used uninitialized.

        * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.

        * xdisp.c (redisplay_window): Rename local to avoid shadowing.
        * window.c (window_loop, size_window):
        (run_window_configuration_change_hook, enlarge_window): Likewise.

        * window.c (display_buffer): Now static.
        (size_window): Mark variables that gcc -Wuninitialized
        does not deduce are never used uninitialized.
        * window.h (check_all_windows): New decl, to forestall
        gcc -Wmissing-prototypes diagnostic.
        * dispextern.h (bidi_dump_cached_states): Likewise.

        * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
        shadowing.
        * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
        Include <limits.h>.
        (Fsort_charsets): Redo min/max calculation to shorten the code a bit
        and to avoid gcc -Wuninitialized warning.
        (load_charset_map): Mark variables that gcc -Wuninitialized
        does not deduce are never used uninitialized.
        (load_charset): Abort instead of using uninitialized var (Bug#8229).

        * coding.c (coding_set_source, coding_set_destination):
        Use "else { /* comment */ }" rather than "else /* comment */;"
        for clarity, and to avoid gcc -Wempty-body warning.
        (Fdefine_coding_system_internal): Don't redeclare 'i' inside
        a block, when the outer 'i' will do.
        (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
        (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
        (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
        (decode_coding_raw_text, decode_coding_charset, get_translation_table):
        (Fdecode_sjis_char, Fdefine_coding_system_internal):
        Rename locals to avoid shadowing.
        * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
        * coding.c (emacs_mule_char, encode_invocation_designation):
        Now static, since they're not used elsewhere.
        (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
        (decode_coding_object, encode_coding_object, detect_coding_system):
        (decode_coding_emacs_mule): Mark variables that gcc
        -Wuninitialized does not deduce are never used uninitialized.
        (detect_coding_iso_2022): Initialize a local variable that might
        be used uninitialized.  Leave a FIXME because it's not clear that
        this initialization is needed.  (Bug#8211)
        (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
        (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
        (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
        (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
        Remove unused macros.

        * category.c (hash_get_category_set): Remove unused local var.
        (copy_category_table): Now static, since it's not used elsewhere.
        * character.c (string_count_byte8): Likewise.

        * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
        (Fregister_code_conversion_map): Rename locals to avoid shadowing.

        * chartab.c (copy_sub_char_table): Now static, since it's not used
        elsewhere.
        (sub_char_table_ref_and_range, char_table_ref_and_range):
        Rename locals to avoid shadowing.
        (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.

        * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
        (BIDI_BOB): Remove unused macro.

        * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
        deduce are never used uninitialized.
        * term.c (encode_terminal_code): Likewise.

        * term.c (encode_terminal_code): Now static.  Remove unused local.

        * tparam.h: New file.
        * term.c, tparam.h: Include it.
        * deps.mk (term.o, tparam.o): Depend on tparam.h.
        * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
        Move these decls to tparam.h, and make them agree with what
        is actually in tparam.c.  The previous trick of using incompatible
        decls in different modules does not conform to the C standard.
        All callers of tparam changed to use tparam's actual API.
        * tparam.c (tparam1, tparam, tgoto):
        Use const pointers where appropriate.

        * cm.c (calccost, cmgoto): Use const pointers where appropriate.
        * cm.h (struct cm): Likewise.
        * dispextern.h (do_line_insertion_deletion_costs): Likewise.
        * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
        * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
        (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
        (turn_on_face, init_tty): Likewise.
        * termchar.h (struct tty_display_info): Likewise.

        * term.c (term_mouse_position): Rename local to avoid shadowing.

        * alloc.c (mark_ttys): Move decl from here ...
        * lisp.h (mark_ttys): ... to here, so that it's checked against defn.

2011-03-11  Andreas Schwab  <schwab@linux-m68k.org>

        * .gdbinit (pwinx, xbuffer): Fix access to buffer name.

2011-03-09  Juanma Barranquero  <lekktu@gmail.com>

        * search.c (compile_pattern_1): Remove argument regp, unused since
        revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
        (compile_pattern): Don't pass it.

2011-03-08  Jan Djärv  <jan.h.d@swipnet.se>

        * xterm.h (DEFAULT_GDK_DISPLAY): New define.
        (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
        for ! HAVE_GTK3.
        (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.

        * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.

        * gtkutil.c: Include gtkx.h if HAVE_GTK3.  If ! HAVE_GTK3, define
        gdk_window_get_screen, gdk_window_get_geometry,
        gdk_x11_window_lookup_for_display and GDK_KEY_g.
        (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
        (xg_get_pixbuf_from_pixmap): New function.
        (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
        to Pixmap, take frame as parameter, remove GdkColormap parameter.
        Call xg_get_pixbuf_from_pixmap instead of
        gdk_pixbuf_get_from_drawable.
        (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
        xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
        (xg_check_special_colors): Use GtkStyleContext and its functions
        for HAVE_GTK3.
        (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
        (xg_prepare_tooltip, create_dialog, menubar_map_cb)
        (xg_update_frame_menubar, xg_tool_bar_detach_callback)
        (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
        Call gtk_widget_get_preferred_size.
        (xg_frame_resized): gdk_window_get_geometry only takes 5
        parameters.
        (xg_win_to_widget, xg_event_is_for_menubar):
        Call gdk_x11_window_lookup_for_display.
        (xg_set_widget_bg): New function.
        (delete_cb): New function.
        (xg_create_frame_widgets): connect delete-event to delete_cb.
        Call xg_set_widget_bg.  Only set backgrund pixmap for ! HAVE_GTK3
        (xg_set_background_color): Call xg_set_widget_bg.
        (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
        (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
        Only call gtk_range_set_update_policy if ! HAVE_GTK3.
        (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
        if ! HAVE_GTK3.
        (update_frame_tool_bar): Call gtk_widget_hide.
        (xg_initialize): Use GDK_KEY_g.

        * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
        if ! HAVE_GTK3
        (x_session_initialize): Call gdk_x11_set_sm_client_id.

        * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
        (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
        Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.

2011-03-08  Juanma Barranquero  <lekktu@gmail.com>

        * w32xfns.c (select_palette): Check success of RealizePalette against
        GDI_ERROR, not zero.

See ChangeLog.11 for earlier changes.

;; Local Variables:
;; coding: utf-8
;; End:

  Copyright (C) 2011  Free Software Foundation, Inc.

  This file is part of GNU Emacs.

  GNU Emacs is free software: you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation, either version 3 of the License, or
  (at your option) any later version.

  GNU Emacs is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.

  You should have received a copy of the GNU General Public License
  along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.