1 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
3 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8 This is needed if max-image-size is a floating-point number.
10 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
12 * print.c (print_object): Print empty symbol as ##.
14 * lread.c (read1): Read ## as empty symbol.
16 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
18 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
19 setting frame foreground color (Bug#9175).
20 (x_set_background_color): Likewise.
22 * nsmenu.m (-setText): Size tooltip dimensions precisely to
24 (EmacsTooltip -init): Remove bezels and add shadows to
27 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
28 or scroll bar (Bug#8470).
30 * nsfont.m (nsfont_open): Remove assignment to voffset and
31 unnecessary vars hshink, expand, hd, full_height, min_height.
32 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
34 * nsterm.h (nsfont_info): Remove voffset field.
36 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
38 Implement strike-through and overline on NextStep (Bug#8863).
40 * nsfont.m (nsfont_open): Use underline position provided by font,
41 instead of hard-coded value of 2.
42 (nsfont_draw): Call ns_draw_text_decoration instead.
44 * nsterm.h: Add declaration for ns_draw_text_decoration.
46 * nsterm.m (ns_draw_text_decoration): New function for drawing
47 underline, overline, and strike-through.
48 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
49 ns_draw_text_decoration. Change treatment of cursor drawing to
50 accomodate underlining, etc.
52 2011-07-28 Eli Zaretskii <eliz@gnu.org>
54 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
57 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
59 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
60 Without this fix, if a signal arrives just after memory fills up,
61 'malloc' might be invoked reentrantly.
63 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
64 In other words, assume that every image size is allowed, on non-X
65 hosts. This assumption is probably wrong, but it lets Emacs compile.
67 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
69 * regex.c (re_iswctype): Convert return values to boolean.
71 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
73 * xdisp.c (compute_display_string_pos): Don't use cached display
74 string position if the buffer had its restriction changed.
77 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
79 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
81 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
83 Integer signedness and overflow and related fixes. (Bug#9079)
85 * bidi.c: Integer size and overflow fixes.
86 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
87 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
88 (bidi_cache_find_level_change, bidi_cache_ensure_space)
89 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
90 (bidi_find_other_level_edge):
91 Use ptrdiff_t instead of EMACS_INT where either will do.
92 This works better on 32-bit hosts configured --with-wide-int.
93 (bidi_cache_ensure_space): Check for size-calculation overflow.
94 Use % rather than repeated addition, for better worst-case speed.
95 Don't set bidi_cache_size until after xrealloc returns, because it
97 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
98 (bidi_cache_ensure_space): Also check that the bidi cache size
99 does not exceed that of the largest Lisp string or buffer. See Eli
100 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
102 * alloc.c (__malloc_size_t): Remove.
103 All uses replaced by size_t. See Andreas Schwab's note
104 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
106 * image.c: Improve checking for integer overflow.
107 (check_image_size): Assume that f is nonnull, since
108 it is always nonnull in practice. This is one less thing to
109 worry about when checking for integer overflow later.
110 (x_check_image_size): New function, which checks for integer
111 overflow issues inside X.
112 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
113 This removes the need for a memory_full check.
114 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
115 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
116 (xbm_read_bitmap_data): Change locals back to 'int', since
117 their values must fit in 'int'.
118 (xpm_load_image, png_load, tiff_load):
119 Invoke x_create_x_image_and_pixmap earlier,
120 to avoid much needless work if the image is too large.
121 (tiff_load): Treat overly large images as if
122 x_create_x_image_and_pixmap failed, not as malloc failures.
123 (gs_load): Use x_check_image_size.
125 * gtkutil.c: Omit integer casts.
126 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
127 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
129 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
131 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
132 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
133 would wrongly return t on a 64-bit host.
135 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
136 The plain *_OVERFLOW macros run afoul of GCC bug 49705
137 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
138 and therefore cause GCC to emit a bogus diagnostic in some cases.
140 * image.c: Integer signedness and overflow and related fixes.
141 This is not an exhaustive set of fixes, but it's time to
142 record what I've got.
143 (lookup_pixel_color, check_image_size): Remove redundant decls.
144 (check_image_size): Don't assume that arbitrary EMACS_INT values
145 fit in 'int', or that arbitrary 'double' values fit in 'int'.
146 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
147 (tiff_load, imagemagick_load_image):
148 Check for overflow in size calculations.
149 (x_create_x_image_and_pixmap): Remove unnecessary test for
150 xmalloc returning NULL; that can't happen.
151 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
152 (xpm_color_bucket): Use better integer hashing function.
153 (xpm_cache_color): Don't possibly over-allocate memory.
154 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
156 Use ptrdiff_t, not int or size_t, to record sizes.
157 (png_load): Don't assume values greater than 2**31 fit in 'int'.
158 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
159 either works, as we prefer signed integers.
160 (tiff_read_from_memory, tiff_write_from_memory):
161 Return tsize_t, not size_t, since that's what the TIFF API wants.
162 (tiff_read_from_memory): Don't fail simply because the read would
163 go past EOF; instead, return a short read.
164 (tiff_load): Omit no-longer-needed casts.
165 (Fimagemagick_types): Don't assume size fits into 'int'.
167 Improve hashing quality when configured --with-wide-int.
168 * fns.c (hash_string): New function, taken from sxhash_string.
169 Do not discard information about ASCII character case; this
170 discarding is no longer needed.
171 (sxhash-string): Use it. Change sig to match it. Caller changed.
172 * lisp.h: Declare it.
173 * lread.c (hash_string): Remove, since we now use fns.c's version.
174 The fns.c version returns a wider integer if --with-wide-int is
175 specified, so this should help the quality of the hashing a bit.
177 * emacs.c: Integer overflow minor fix.
178 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
179 Define only if GNU_LINUX.
180 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
182 * dispnew.c: Integer signedness and overflow fixes.
183 Remove unnecessary forward decls, that were a maintenance hassle.
184 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
186 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
187 (scrolling_window): Use ptrdiff_t, not int, for byte count.
188 (prepare_desired_row, line_draw_cost):
189 Use int, not unsigned, where either works.
190 (save_current_matrix, restore_current_matrix):
191 Use ptrdiff_t, not size_t, where either works.
192 (init_display): Check for overflow more accurately, and without
193 relying on undefined behavior.
195 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
196 Remove, replacing with the new symbols in lisp.h. All uses changed.
197 * fileio.c (make_temp_name):
198 * filelock.c (lock_file_1, lock_file):
199 * xdisp.c (message_dolog):
200 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
201 Use pMd etc. instead.
202 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
203 replacing the pWIDE etc. symbols removed from editfns.c.
205 * keyboard.h (num_input_events): Now uintmax_t.
206 This is (very slightly) less likely to mess up due to wraparound.
209 * buffer.c: Integer signedness fixes.
210 (alloc_buffer_text, enlarge_buffer_text):
211 Use ptrdiff_t rather than size_t when either will do, as we prefer
214 * alloc.c: Integer signedness and overflow fixes.
215 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
216 (__malloc_size_t): Default to size_t, not to int.
217 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
218 (Fgarbage_collect, mark_object_loop_halt, mark_object):
219 Prefer ptrdiff_t to size_t when either would do, as we prefer
221 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
222 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
223 Now const. Initialize with values that are in range even if char
225 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
226 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
227 These functions do the right thing with sizes > 2**32.
228 (check_depth): Now ptrdiff_t, not int.
229 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
230 Adjust to new way of storing sizes. Check for size overflow bugs
232 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
233 slightly wrong anyway, as it missed one instance of
234 XMALLOC_OVERRUN_CHECK_OVERHEAD.
235 (refill_memory_reserve): Omit needless cast to size_t.
236 (mark_object_loop_halt): Mark as externally visible.
238 * xselect.c: Integer signedness and overflow fixes.
239 (Fx_register_dnd_atom, x_handle_dnd_message):
240 Use ptrdiff_t, not size_t, since we prefer signed.
241 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
242 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
243 x_dnd_atoms_size and x_dnd_atoms_length.
245 * doprnt.c: Prefer signed to unsigned when either works.
249 * xdisp.c (vmessage):
250 Use ptrdiff_t, not size_t, when using or implementing doprnt,
251 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
252 prefer signed arithmetic to avoid comparison confusion.
253 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
256 Assume freestanding C89 headers, string.h, stdlib.h.
257 * data.c, doprnt.c, floatfns.c, print.c:
258 Include float.h unconditionally.
259 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
260 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
261 * regex.c: Likewise for stddef.h, string.h.
262 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
263 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
264 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
265 (STDC_HEADERS): Remove obsolete defines.
266 * sysdep.c: Include limits.h unconditionally.
268 Assume support for memcmp, memcpy, memmove, memset.
269 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
270 * regex.c (memcmp, memcpy):
271 Remove; we assume C89 now.
273 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
274 (__malloc_safe_bcopy): Remove; no longer needed.
276 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
277 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
278 well either way, and we prefer signed to unsigned.
280 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
282 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
283 closes the connection while we're reading (bug#9182).
285 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
287 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
288 are specified (Bug#9168).
290 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
292 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
293 Found by GCC static checking and --with-wide-int on a 32-bit host.
295 2011-07-25 Eli Zaretskii <eliz@gnu.org>
297 * xdisp.c (compute_display_string_pos): Fix logic of caching
298 previous display string position. Initialize cached_prev_pos to
299 -1. Fixes slow-down at the beginning of a buffer.
301 2011-07-24 Eli Zaretskii <eliz@gnu.org>
303 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
304 for attrs[LFACE_FONTSET_INDEX].
306 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
308 * xml.c (parse_region): Remove unused local
309 that was recently introduced.
311 2011-07-23 Eli Zaretskii <eliz@gnu.org>
313 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
314 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
316 * xdisp.c (move_it_in_display_line_to): Record the best matching
317 position for TO_CHARPOS while scanning the line, and restore it on
318 exit if none of the characters scanned was an exact match. Fixes
319 vertical-motion and pos-visible-in-window-p under bidi redisplay
320 when exact match is impossible due to invisible text, and the
323 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
325 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
328 2011-07-22 Eli Zaretskii <eliz@gnu.org>
330 Fix a significant slow-down of cursor motion with C-n, C-p,
331 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
332 auto-repeat under bidi redisplay in fontified buffers.
333 * xdisp.c (compute_stop_pos_backwards): New function.
334 (next_element_from_buffer): Call compute_stop_pos_backwards to
335 find a suitable prev_stop when we find ourselves before
337 (reseat): Don't look for prev_stop, as that could mean a very long
339 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
340 <cached_disp_overlay_modiff>: Cache for last found display string
342 (compute_display_string_pos): Return the cached position if asked
343 about the same buffer in the same area of character positions, and
344 the buffer wasn't changed since the time the display string
347 2011-07-22 Eli Zaretskii <eliz@gnu.org>
349 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
350 is an integer, which is important for empty lines. (Bug#9149)
352 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
354 * frame.c (Fmodify_frame_parameters): In tty case, update the
355 default face if necessary (Bug#4238).
357 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
359 * editfns.c (Fstring_to_char): No need to explain what a character
360 is in the docstring (Bug#6576).
362 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
364 * xml.c (parse_region): Make sure we always return a tree.
366 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
368 * xml.c (parse_region): If a document contains only comments,
371 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
373 * xml.c (make_dom): Return comments, too.
375 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
378 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
379 and the surrounding thread.
380 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
381 rather than fgets, and retry after EINTR. Otherwise, 'emacs
382 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
384 * s/openbsd.h (BROKEN_SIGIO): Define.
385 * unexelf.c (unexec) [__OpenBSD__]:
386 Don't update the .mdebug section of the Alpha COFF symbol table.
388 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
390 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
393 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
395 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
396 This fixes some race conditions on the permissions of any newly
399 * alloc.c (valid_pointer_p): Use pipe, not open.
400 This fixes some permissions issues when debugging.
402 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
403 If fchown fails to set both uid and gid, try to set just gid,
404 as that is sometimes allowed. Adjust the file's mode to eliminate
405 setuid or setgid bits that are inappropriate if fchown fails.
407 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
409 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
410 to compare Lisp_Objects.
411 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
412 global_gnutls_log_level, don't mistake it for a Lisp_Object.
413 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
415 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
417 * lread.c (read_integer): Unread even EOF character.
418 (read1): Likewise. Properly record start position of symbol.
420 * lread.c (read1): Read `#:' as empty uninterned symbol if no
421 symbol character follows.
423 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
425 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
426 This works around a problem with the previous change to Fcopy_file.
427 Recent glibc declares fchown with __attribute__((warn_unused_result)),
428 and without this change, GCC might complain about discarding
429 fchown's return value.
431 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
433 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
435 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
437 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
439 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
441 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
442 it's used from the C level.
444 * process.c: Use the same condition for POLL_FOR_INPUT in both
445 keyboard.c and process.c (bug#1858).
447 2011-07-09 Lawrence Mitchell <wence@gmx.li>
449 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
450 (Fgnutls_boot): Use it.
452 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
454 * doc.c (Fsubstitute_command_keys): Revert last change.
456 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
458 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
459 quotes the next character, and doesn't affect other longer
460 sequences (bug#8935).
462 * lread.c (syms_of_lread): Clarify that is isn't only
463 `eval-buffer' and `eval-defun' that's affected by
464 `lexical-binding' (bug#8460).
466 2011-07-15 Eli Zaretskii <eliz@gnu.org>
468 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
469 bidi redisplay when a line includes both an image and is
472 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
474 Fix minor problems found by static checking.
475 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
476 (elsz): Now a signed constant, not a size_t var. We prefer signed
477 types to unsigned, to avoid integer comparison confusion. Without
478 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
479 "cannot optimize loop, the loop counter may overflow", a symptom
481 * indent.c (Fvertical_motion): Mark locals as initialized.
482 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
484 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
486 * search.c (Fre_search_backward): Mention `case-fold-search' in
487 all the re_search_* functions (bug#8138).
489 * keyboard.c (Fopen_dribble_file): Document when the file is
492 2011-07-14 Eli Zaretskii <eliz@gnu.org>
494 * bidi.c (bidi_dump_cached_states): Fix format of displaying
497 Support bidi reordering of display and overlay strings.
498 * xdisp.c (compute_display_string_pos)
499 (compute_display_string_end): Accept additional argument STRING.
500 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
501 (reseat_to_string): Initialize bidi_it->string.s and
502 bidi_it->string.schars.
503 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
504 NULL (avoids a crash in bidi_paragraph_init). Initialize
506 (init_iterator): Call bidi_init_it only of a valid
507 buffer position was specified. Initialize paragraph_embedding to
509 (reseat_to_string): Initialize the bidi iterator.
510 (display_string): If we need to ignore text properties of
511 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
512 original value of -1 will not work with bidi.)
513 (compute_display_string_pos): First arg is now struct
514 `text_pos *'; all callers changed. Support display properties on
516 (compute_display_string_end): Support display properties on Lisp
518 (init_iterator, reseat_1, reseat_to_string): Initialize the
519 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
520 when iterating on a string not from display properties).
521 (compute_display_string_pos, compute_display_string_end): Fix
522 calculation of the object to scan. Fixes an error when using
524 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
525 base_level_stop; instead, set base_level_stop to BEGV. Fixes
526 crashes in vertical-motion.
527 (next_element_from_buffer): Improve commentary for when
528 the iterator is before prev_stop.
529 (init_iterator): Initialize bidi_p from the default value of
530 bidi-display-reordering, not from buffer-local value. Use the
531 buffer-local value only if initializing for buffer iteration.
532 (handle_invisible_prop): Support invisible properties on strings
533 that are being bidi-reordered.
534 (set_iterator_to_next): Support bidi reordering of C strings and
536 (next_element_from_string): Support bidi reordering of Lisp
538 (handle_stop_backwards): Support Lisp strings as well.
539 (display_string): Support display of R2L glyph rows. Use
540 IT_STRING_CHARPOS when displaying from a Lisp string.
541 (init_iterator): Don't initialize it->bidi_p for strings
543 (reseat_to_string): Initialize it->bidi_p for strings here.
544 (next_element_from_string, next_element_from_c_string)
545 (next_element_from_buffer): Add xassert's for correspondence
546 between IT's object being iterated and it->bidi_it.string
548 (face_before_or_after_it_pos): Support bidi iteration.
549 (next_element_from_c_string): Handle the case of the first string
550 character that is not the first one in the visual order.
551 (get_visually_first_element): New function, refactored from common
552 parts of next_element_from_buffer, next_element_from_string, and
553 next_element_from_c_string.
554 (tool_bar_lines_needed, redisplay_tool_bar)
555 (display_menu_bar): Force left-to-right direction. Add a FIXME
556 comment for making that be controlled by a user option.
557 (push_it, pop_it): Save and restore the state of the
558 bidi iterator. Save and restore the bidi_p flag.
559 (pop_it): Iterate out of display property for string iteration as
561 (iterate_out_of_display_property): Support iteration over strings.
562 (handle_single_display_spec): Set up it->bidi_it for iteration
563 over a display string, and call bidi_init_it.
564 (handle_single_display_spec, next_overlay_string)
565 (get_overlay_strings_1, push_display_prop): Set up the bidi
566 iterator for displaying display or overlay strings.
567 (forward_to_next_line_start): Don't use the shortcut if
569 (back_to_previous_visible_line_start): If handle_display_prop
570 pushed the iterator stack, restore the internal state of the bidi
571 iterator by calling bidi_pop_it same number of times.
572 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
573 and we are bidi-iterating, don't decrement the iterator position;
574 instead, set the first_elt flag in the bidi iterator, to produce
576 (reseat_1): Remove redundant setting of string_from_display_prop_p.
577 (push_display_prop): xassert that we are iterating a buffer.
578 (push_it, pop_it): Save and restore paragraph_embedding member.
579 (handle_single_display_spec, next_overlay_string)
580 (get_overlay_strings_1, reseat_1, reseat_to_string)
581 (push_display_prop): Set up the `unibyte' member of bidi_it.string
582 correctly. Don't assume unibyte strings are not bidi-reordered.
583 (compute_display_string_pos)
584 (compute_display_string_end): Fix handling the case of C string.
585 (push_it, pop_it): Save and restore from_disp_prop_p.
586 (handle_single_display_spec, push_display_prop): Set the
587 from_disp_prop_p flag.
588 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
589 (pop_it): Call iterate_out_of_display_property only if we are
590 popping after iteration over a string that came from a display
591 property. Fix a typo in popping stretch info. Add an assertion
592 for verifying that the iterator position is in sync with the bidi
594 (handle_single_display_spec, get_overlay_strings_1)
595 (push_display_prop): Fix initialization of paragraph direction for
596 string when that of the parent object is not yet determined.
597 (reseat_1): Call bidi_init_it to resync the bidi
598 iterator with IT's position. (Bug#7616)
599 (find_row_edges): If ROW->start.pos gives position
600 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
601 (handle_stop, back_to_previous_visible_line_start, reseat_1):
602 Reset the from_disp_prop_p flag.
603 (SAVE_IT, RESTORE_IT): New macros.
604 (pos_visible_p, face_before_or_after_it_pos)
605 (back_to_previous_visible_line_start)
606 (move_it_in_display_line_to, move_it_in_display_line)
607 (move_it_to, move_it_vertically_backward, move_it_by_lines)
608 (try_scrolling, redisplay_window, display_line): Use them when
609 saving a temporary copy of the iterator and restoring it back.
610 (back_to_previous_visible_line_start, reseat_1)
611 (init_iterator): Empty the bidi cache "stack".
612 (move_it_in_display_line_to): If iterator ended up at
613 EOL, but we never saw any buffer positions smaller than
614 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
615 motion in bidi-reordered lines.
616 (move_it_in_display_line_to): Record prev_method and prev_pos
617 immediately before the call to set_iterator_to_next. Fixes cursor
618 motion in bidi-reordered lines with stretch glyphs and strings
619 displayed in margins. (Bug#8133) (Bug#8867)
620 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
622 (pos_visible_p): Support positions in bidi-reordered lines. Save
623 and restore bidi cache.
625 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
626 (bidi_paragraph_info): Delete unused struct.
627 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
628 (bidi_cache_start): New variable.
629 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
631 (bidi_cache_fetch_state, bidi_cache_search)
632 (bidi_cache_find_level_change, bidi_cache_iterator_state)
633 (bidi_cache_find, bidi_peek_at_next_level)
634 (bidi_level_of_next_char, bidi_find_other_level_edge)
635 (bidi_move_to_visually_next): Compare cache index with
636 bidi_cache_start rather than with zero.
637 (bidi_fetch_char): Accept new argument STRING; all callers
638 changed. Support iteration over a string. Support strings with
639 display properties. Support unibyte strings. Fix the type of
640 `len' according to what STRING_CHAR_AND_LENGTH expects.
641 (bidi_paragraph_init, bidi_resolve_explicit_1)
642 (bidi_resolve_explicit, bidi_resolve_weak)
643 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
644 iteration over a string.
645 (bidi_set_sor_type, bidi_resolve_explicit_1)
646 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
647 can now be zero (for strings); special values 0 and -1 were
648 changed to -1 and -2, respectively.
649 (bidi_char_at_pos): New function.
650 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
651 Call it instead of FETCH_MULTIBYTE_CHAR.
652 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
653 initialized to valid values.
654 (bidi_init_it): Don't initialize charpos and bytepos with invalid
656 (bidi_level_of_next_char): Allow the sentinel "position" to pass
657 the test for valid cached positions. Fix the logic for looking up
658 the sentinel state in the cache. GCPRO the Lisp string we are
660 (bidi_push_it, bidi_pop_it): New functions.
661 (bidi_initialize): Initialize the bidi cache start stack pointer.
662 (bidi_cache_ensure_space): New function, refactored from part of
663 bidi_cache_iterator_state. Don't assume the required size is just
664 one BIDI_CACHE_CHUNK away.
665 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
666 (bidi_count_bytes, bidi_char_at_pos): New functions.
667 (bidi_cache_search): Don't assume bidi_cache_last_idx is
668 always valid if bidi_cache_idx is valid.
669 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
670 is valid if it's going to be used.
671 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
672 (bidi_cache_fetch_state, bidi_cache_search)
673 (bidi_cache_find_level_change, bidi_cache_ensure_space)
674 (bidi_cache_iterator_state, bidi_cache_find)
675 (bidi_find_other_level_edge, bidi_cache_start_stack): All
676 variables related to cache indices are now EMACS_INT.
678 * dispextern.h (struct bidi_string_data): New structure.
679 (struct bidi_it): New member `string'. Make flag members be 1-bit
680 fields, and put them last in the struct.
681 (compute_display_string_pos, compute_display_string_end): Update
683 (bidi_push_it, bidi_pop_it): Add prototypes.
684 (struct iterator_stack_entry): New members bidi_p,
685 paragraph_embedding, and from_disp_prop_p.
686 (struct it): Member bidi_p is now a bit field 1 bit wide.
687 (bidi_shelve_cache, bidi_unshelve_cache): Declare
690 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
691 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
692 and vector-like objects.
694 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
695 cache around display iteration.
697 * window.c (Fwindow_end, window_scroll_pixel_based)
698 (displayed_window_lines, Frecenter): Save and restore the bidi
699 cache around display iteration.
701 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
703 * editfns.c (Fdelete_region): Clarify the use of the named
704 parameters (bug#6788).
706 2011-07-14 Martin Rudalics <rudalics@gmx.at>
708 * indent.c (Fvertical_motion): Set and restore w->pointm when
709 saving and restoring the window's buffer (Bug#9006).
711 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
713 * editfns.c (Fstring_to_char): Clarify just what is returned
714 (bug#6576). Text by Eli Zaretskii.
716 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
718 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
720 2011-07-13 Eli Zaretskii <eliz@gnu.org>
722 * buffer.c (mmap_find): Fix a typo.
724 2011-07-13 Johan Bockgård <bojohan@gnu.org>
726 Fix execution of x selection hooks.
727 * xselect.c (Qx_lost_selection_functions)
728 (Qx_sent_selection_functions): New vars.
729 (syms_of_xselect): DEFSYM them.
730 (x_handle_selection_request): Pass Qx_sent_selection_functions
731 rather than Vx_sent_selection_functions to Frun_hook_with_args.
732 (x_handle_selection_clear,x_clear_frame_selections):
733 Pass Qx_lost_selection_functions rather than
734 Vx_lost_selection_functions to Frun_hook_with_args.
736 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
738 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
739 The old code sometimes used this field without initializing it.
741 * alloc.c (gc_sweep): Don't read past end of array.
742 In theory, the old code could also have corrupted Emacs internals,
743 though it'd be very unlikely.
745 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
747 * character.c (Fcharacterp): Don't advertise optional ignored
750 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
752 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
755 * window.c (Fset_window_start): Doc fix (bug#4199).
756 (Fset_window_hscroll): Ditto.
758 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
760 Fix minor new problems caught by GCC 4.6.1.
761 * term.c (init_tty): Remove unused local.
762 * xsettings.c (store_monospaced_changed): Define this function only
763 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
766 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
768 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
770 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
772 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
773 are the mini-buffer and the echo area (bug#3320).
775 * term.c (init_tty): Remove support for supdup, c10 and perq
776 terminals, which are no longer supported (bug#1482).
778 2011-07-10 Johan Bockgård <bojohan@gnu.org>
780 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
782 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
784 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
785 for non-popups (Bug#3642).
787 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
789 * alloc.c (reset_malloc_hooks): Protoize.
790 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
791 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
792 * cm.c (losecursor): Likewise.
793 * data.c (fmod): Likewise.
794 * dispnew.c (swap_glyphs_in_rows): Likewise.
795 * emacs.c (memory_warning_signal): Likewise.
796 * floatfns.c (float_error): Likewise.
797 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
798 (otf_open, font_otf_capability, generate_otf_features)
799 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
801 * image.c (pbm_read_file): Likewise.
802 * indent.c (string_display_width): Likewise.
803 * intervals.c (check_for_interval, search_for_interval)
804 (inc_interval_count, count_intervals, root_interval)
805 (adjust_intervals_for_insertion, make_new_interval): Likewise.
806 * lread.c (defalias): Likewise.
807 * ralloc.c (r_alloc_check): Likewise.
808 * regex.c (set_image_of_range_1, set_image_of_range)
809 (regex_grow_registers): Likewise.
810 * sysdep.c (strerror): Likewise.
811 * termcap.c (valid_filename_p, tprint, main): Likewise.
812 * tparam.c (main): Likewise.
813 * unexhp9k800.c (run_time_remap, save_data_space)
814 (update_file_ptrs, read_header, write_header, calculate_checksum)
815 (copy_file, copy_rest, display_header): Likewise.
816 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
818 * xdisp.c (check_it): Likewise.
819 * xfaces.c (register_color, unregister_color, unregister_colors):
821 * xfns.c (print_fontset_result): Likewise.
822 * xrdb.c (member, fatal, main): Likewise.
824 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
826 Fix minor problems found by static checking (Bug#9031).
827 * chartab.c (char_table_set_range, map_sub_char_table):
828 Remove unused locals.
829 (uniprop_table): Now static.
830 * composite.c (_work_char): Remove unused static var.
832 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
834 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
836 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
838 * gtkutil.c (qttip_cb): Remove code without function.
840 2011-07-09 Eli Zaretskii <eliz@gnu.org>
842 * w32.c (pthread_sigmask): New stub.
844 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
846 Use pthread_sigmask, not sigprocmask (Bug#9010).
847 sigprocmask is portable only for single-threaded applications, and
848 Emacs can be multi-threaded when it uses GTK.
849 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
851 * callproc.c (Fcall_process):
852 * process.c (create_process):
853 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
854 Use pthread_sigmask, not sigprocmask.
856 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
858 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
859 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
862 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
864 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
865 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
866 (xg_hide_tooltip): Fix comment.
868 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
869 in registerServicesMenuSendTypes.
870 (validRequestorForSendType): Don't check ns_return_types.
872 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
875 2011-07-08 Jason Rumney <jasonr@gnu.org>
877 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
878 frame struct members of non-existent frames (Bug#6284).
880 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
882 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
883 variable firstTime not needed on OSX >= 10.6.
884 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
885 >= 10.5. Use setKnobProportion, setDoubleValue.
887 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
888 (MAC_OS_X_VERSION_10_5): Define if not defined.
889 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
890 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
891 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
893 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
894 cString and lossyCString on OSX >= 10.4
896 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
897 sizeToFit on OSX >= 10.2.
899 * nsimage.m (allocInitFromFile): Don't use deprecated method
900 bestRepresentationForDevice on OSX >= 10.6.
902 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
905 * emacs.c: Declare unexec_init_emacs_zone.
907 * nsgui.h: Fix compiler warning about gnulib redefining verify.
909 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
911 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
912 on svcsMenu (Bug#8842).
914 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
916 (Fns_list_services): Just return Qnil on 10.6, code not working there.
918 * nsterm.m (QUTF8_STRING): Declare.
919 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
920 (validRequestorForSendType): Return type is (id).
921 Change indexOfObjectIdenticalTo to indexOfObject.
922 Check if we have local selection before returning self (Bug#8842).
923 (writeSelectionToPasteboard): Put local selection into paste board
924 if we have a local selection (Bug#8842).
925 (syms_of_nsterm): DEFSYM QUTF8_STRING.
927 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
928 (ns_get_local_selection): Declare.
930 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
932 * keymap.c (describe_map_tree): Don't insert a double newline at
933 the end of the buffer (bug#1169) and return whether we inserted
936 * callint.c (Fcall_interactively): Change "reading args" to
937 "providing args" to try to clarify what it does (bug#1010).
939 2011-07-07 Kenichi Handa <handa@m17n.org>
941 * composite.c (composition_compute_stop_pos): Ignore a static
942 composition starting before CHARPOS (Bug#8915).
944 * xdisp.c (handle_composition_prop): Likewise.
946 2011-07-07 Eli Zaretskii <eliz@gnu.org>
948 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
951 2011-07-07 Kenichi Handa <handa@m17n.org>
953 * character.h (unicode_category_t): New enum type.
955 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
956 (Qchar_code_property_table): New variable.
957 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
958 (UNIPROP_COMPRESSED_FORM_P): New macros.
959 (char_table_ascii): Uncompress the compressed values.
960 (sub_char_table_ref): New arg is_uniprop. Callers changed.
961 Uncompress the compressed values.
962 (sub_char_table_ref_and_range): Likewise.
963 (char_table_ref_and_range): Uncompress the compressed values.
964 (sub_char_table_set): New arg is_uniprop. Callers changed.
965 Uncompress the compressed values.
966 (sub_char_table_set_range): Args changed. Callers changed.
967 (char_table_set_range): Adjuted for the above change.
968 (map_sub_char_table): Delete args default_val and parent. Add arg
969 top. Give decoded values to a Lisp function.
970 (map_char_table): Adjusted for the above change. Give decoded
971 values to a Lisp function. Gcpro more variables.
972 (uniprop_table_uncompress)
973 (uniprop_decode_value_run_length): New functions.
974 (uniprop_decoder, uniprop_decoder_count): New variables.
975 (uniprop_get_decoder, uniprop_encode_value_character)
976 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
978 (uniprop_encoder, uniprop_encoder_count): New variables.
979 (uniprop_get_encoder, uniprop_table)
980 (Funicode_property_table_internal, Fget_unicode_property_internal)
981 (Fput_unicode_property_internal): New functions.
982 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
983 Sunicode_property_table_internal, Sget_unicode_property_internal,
984 and Sput_unicode_property_internal. Defvar_lisp
985 char-code-property-alist.
987 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
988 Vunicode_category_table.
990 * font.c (font_range): Adjusted for the change of
991 Vunicode_category_table.
993 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
995 * m/iris4d.h: Remove file, move contents ...
996 * s/irix6-5.h: ... here.
998 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1000 Remove unportable assumption about struct layout (Bug#8884).
1001 * alloc.c (mark_buffer):
1002 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1003 (clone_per_buffer_values): Don't assume that
1004 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1005 This isn't true in general, and it's particularly not true
1006 if Emacs is configured with --with-wide-int.
1007 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1008 New macros, used in the buffer.c change.
1010 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1012 * xsettings.c: Use both GConf and GSettings if both are available.
1013 (store_config_changed_event): Add comment.
1014 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1015 (store_tool_bar_style_changed): New functions.
1016 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1017 (struct xsettings): Move font inside HAVE_XFT.
1018 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1019 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1020 Move inside HAVE_XFT.
1021 (something_changed_gsettingsCB): Renamed from something_changedCB.
1022 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1024 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1025 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1026 (something_changed_gconfCB): Renamed from something_changedCB.
1027 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1028 (parse_settings): Move check for font inside HAVE_XFT.
1029 (read_settings, apply_xft_settings): Add comment.
1030 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1031 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1032 call store_font_name_changed.
1033 (xft_settings_event): Add comment.
1034 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1035 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1036 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1037 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1038 (xsettings_initialize): Call init_gsettings last.
1039 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1042 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1044 Random fixes. E.g., (random) never returned negative values.
1045 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1046 subseconds part to the entropy, as that's a bit more random.
1047 Prefer signed to unsigned, since the signedness doesn't matter and
1048 in general we prefer signed. When given a limit, use a
1049 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1050 latter isn't right if USE_2_TAGS_FOR_INTS.
1051 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1052 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1054 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1056 * textprop.c (text_property_stickiness):
1057 Obey Vtext_property_default_nonsticky.
1058 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1059 * w32fns.c (syms_of_w32fns):
1060 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1062 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1064 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1065 This is more efficient than Ffile_directory_p and avoids a minor race.
1067 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1069 * buffer.c (Foverlay_put): Say what the return value is
1072 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1073 is a directory before asking whether to use the file name
1075 (barf_or_query_if_file_exists): Make the "File is a directory"
1076 error be more correct.
1078 * fns.c (Frequire): Remove the mention of the .gz files, since
1079 that's installation-specific, but keep the mention of
1080 `get-load-suffixes'.
1082 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1084 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1085 Report string overflow if the output is too long.
1087 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1089 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1090 (syms_of_gnutls): Remove duplicate DEFSYM for
1091 Qgnutls_bootprop_verify_hostname_error, an error for
1092 Qgnutls_bootprop_verify_error (which is no longer used).
1094 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1095 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1096 Also (re)move comments that are misplaced or no longer relevant.
1098 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1100 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1102 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1104 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1105 and background color parameters if they have been changed.
1107 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1109 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1111 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1113 * xsettings.c (SYSTEM_FONT): Define only when used.
1114 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1116 * keymap.c (access_keymap_1): Now static.
1118 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1120 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1121 leave any prefix arg for the up event (Bug#1586).
1123 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1125 * lread.c (syms_of_lread): Mention single symbols defined by
1126 `defvar' or `defconst' (bug#7154).
1128 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1129 (Frequire): Mention get-load-suffixes.
1131 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1133 * window.h (window): Remove clone_number slot.
1134 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1136 (make_parent_window, make_window, saved_window)
1137 (Fset_window_configuration, save_window_save): Don't deal with
1139 * buffer.c (Qclone_number): Remove declaration.
1140 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1142 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1144 Add multiple inheritance to keymaps.
1145 * keymap.c (Fmake_composed_keymap): New function.
1146 (Fset_keymap_parent): Simplify.
1147 (fix_submap_inheritance): Remove.
1148 (access_keymap_1): New function extracted from access_keymap to handle
1149 embedded parents and handle lists of maps.
1150 (access_keymap): Use it.
1151 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1152 (Fcopy_keymap): Handle embedded parents.
1153 (Fcommand_remapping, define_as_prefix): Simplify.
1154 (Fkey_binding): Simplify.
1155 (syms_of_keymap): Move minibuffer-local-completion-map,
1156 minibuffer-local-filename-completion-map,
1157 minibuffer-local-must-match-map, and
1158 minibuffer-local-filename-must-match-map to Elisp.
1159 (syms_of_keymap): Defsubr make-composed-keymap.
1160 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1161 (parse_menu_item): Trivial simplification.
1163 2011-07-01 Glenn Morris <rgm@gnu.org>
1165 * Makefile.in (SETTINGS_LIBS): Fix typo.
1167 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1169 * coding.c (Fencode_coding_string): Record the last coding system
1170 used, as the function doc string says (bug#8738).
1172 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1174 * xsettings.c (store_monospaced_changed): Take new font as arg and
1175 check for change against current_mono_font.
1176 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1177 (emacs_settings_constructor, emacs_settings_get_property)
1178 (emacs_settings_set_property, emacs_settings_class_init)
1179 (emacs_settings_init, gsettings_obj): Remove.
1180 (something_changedCB): New function for HAVE_GSETTINGS.
1181 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1182 with value as argument.
1183 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1184 g_settings_new (Bug#8967). Do not create gsettings_obj.
1185 Remove calls to g_settings_bind. Connect something_changedCB to
1188 * xgselect.c: Add defined (HAVE_GSETTINGS).
1189 (xgselect_initialize): Ditto.
1191 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1192 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1195 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1197 * eval.c (struct backtrace): Simplify and port the data structure.
1198 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1199 signed bit field, as this assumption is not portable and it makes
1200 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1201 "char debug_on_exit : 1" as this is not portable either; instead,
1202 use the portable "unsigned int debug_on_exit : 1". Remove unused
1203 member evalargs. Remove obsolete comments about cc bombing out.
1205 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1207 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1208 Let HAVE_GSETTINGS override HAVE_GCONF.
1209 (store_monospaced_changed): New function.
1210 (EMACS_SETTINGS): A new type derived from GObject to handle
1211 GSettings notifications.
1212 (emacs_settings_constructor, emacs_settings_get_property)
1213 (emacs_settings_set_property, emacs_settings_class_init):
1215 (gsettings_client, gsettings_obj): New variables.
1216 (GSETTINGS_SCHEMA): New define.
1217 (something_changedCB): Call store_monospaced_changed.
1218 (init_gsettings): New function.
1219 (xsettings_initialize): Call init_gsettings.
1220 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1223 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1226 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1228 * window.c (resize_root_window, grow_mini_window)
1229 (shrink_mini_window): Rename Qresize_root_window to
1230 Qwindow_resize_root_window and Qresize_root_window_vertically to
1231 Qwindow_resize_root_window_vertically.
1233 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1235 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1237 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1239 * makefile.w32-in: Redesign dependencies so they reflect more
1240 clearly which files are directly included by each source file,
1241 and not through other includes.
1243 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1245 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1246 (sort_overlays, overlay_strings): When an overlay's clone number
1247 matches the window's clone number process the overlay even if
1248 the overlay's window property doesn't match the current window.
1250 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1251 (Fwindow_hchild): Rename to Fwindow_left_child.
1252 (Fwindow_next): Rename to Fwindow_next_sibling.
1253 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1254 (resize_window_check): Rename to window_resize_check.
1255 (resize_window_apply): Rename to window_resize_apply.
1256 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1257 (Fdelete_other_windows_internal, resize_frame_windows)
1258 (Fsplit_window_internal, Fdelete_window_internal)
1259 (grow_mini_window, shrink_mini_window)
1260 (Fresize_mini_window_internal): Fix callers accordingly.
1262 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1264 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1265 (emacs_fixed_set_min_size): Remove.
1266 (emacs_fixed_new): Take frame as argument.
1268 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1269 (_EmacsFixedPrivate): Remove minwidth/height.
1270 Add struct frame *f.
1271 (emacs_fixed_init): Initialize priv->f.
1272 (get_parent_class, emacs_fixed_set_min_size): Remove.
1273 (emacs_fixed_new): Set priv->f to argument.
1274 (emacs_fixed_get_preferred_width)
1275 (emacs_fixed_get_preferred_height): Use min_width/height from
1276 frames size_hint to set minimum and natural (Bug#8919).
1277 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1278 and use min_width/height from frames size_hint to set
1279 min_width/height (Bug#8919).
1281 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1282 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1285 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1287 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1288 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1291 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1293 * process.c (wait_reading_process_output): Bypass select if
1294 waiting for a cell while ignoring keyboard input, and input is
1295 pending. Suggested by Jan Djärv (Bug#8869).
1297 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1299 Use gnulib's dup2 module instead of rolling our own.
1300 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1302 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1304 * dispnew.c (scrolling_window): Before scrolling, turn off a
1305 mouse-highlight in the window being scrolled.
1307 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1309 Move DEFSYM to lisp.h and use everywhere.
1311 * character.h (DEFSYM): Move declaration...
1312 * lisp.h (DEFSYM): ...here.
1318 * w32select.c: Don't include character.h.
1320 * alloc.c (syms_of_alloc):
1321 * buffer.c (syms_of_buffer):
1322 * bytecode.c (syms_of_bytecode):
1323 * callint.c (syms_of_callint):
1324 * casefiddle.c (syms_of_casefiddle):
1325 * casetab.c (init_casetab_once):
1326 * category.c (init_category_once, syms_of_category):
1327 * ccl.c (syms_of_ccl):
1328 * cmds.c (syms_of_cmds):
1329 * composite.c (syms_of_composite):
1330 * dbusbind.c (syms_of_dbusbind):
1331 * dired.c (syms_of_dired):
1332 * dispnew.c (syms_of_display):
1333 * doc.c (syms_of_doc):
1334 * editfns.c (syms_of_editfns):
1335 * emacs.c (syms_of_emacs):
1336 * eval.c (syms_of_eval):
1337 * fileio.c (syms_of_fileio):
1338 * fns.c (syms_of_fns):
1339 * frame.c (syms_of_frame):
1340 * fringe.c (syms_of_fringe):
1341 * insdel.c (syms_of_insdel):
1342 * keymap.c (syms_of_keymap):
1343 * lread.c (init_obarray, syms_of_lread):
1344 * macros.c (syms_of_macros):
1345 * msdos.c (syms_of_msdos):
1346 * print.c (syms_of_print):
1347 * process.c (syms_of_process):
1348 * search.c (syms_of_search):
1349 * sound.c (syms_of_sound):
1350 * syntax.c (init_syntax_once, syms_of_syntax):
1351 * terminal.c (syms_of_terminal):
1352 * textprop.c (syms_of_textprop):
1353 * undo.c (syms_of_undo):
1354 * w32.c (globals_of_w32):
1355 * window.c (syms_of_window):
1356 * xdisp.c (syms_of_xdisp):
1357 * xfaces.c (syms_of_xfaces):
1358 * xfns.c (syms_of_xfns):
1359 * xmenu.c (syms_of_xmenu):
1360 * xsettings.c (syms_of_xsettings):
1361 * xterm.c (syms_of_xterm): Use DEFSYM.
1363 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1365 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1367 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1369 Integer and buffer overflow fixes (Bug#8873).
1371 * print.c (printchar, strout): Check for string overflow.
1372 (PRINTPREPARE, printchar, strout):
1373 Don't set size unless allocation succeeds.
1375 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1376 for sizes. Check for string overflow more accurately.
1377 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1379 * macros.c: Integer and buffer overflow fixes.
1380 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1381 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1382 Use ptrdiff_t, not int, for sizes.
1383 Don't increment bufsize until after realloc succeeds.
1384 Check for size-calculation overflow.
1385 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1387 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1389 * lread.c: Integer overflow fixes.
1390 (read_integer): Radix is now EMACS_INT, not int,
1391 to improve quality of diagnostics for out-of-range radices.
1392 Calculate buffer size correctly for out-of-range radices.
1393 (read1): Check for integer overflow in radices, and in
1394 read-circle numbers.
1395 (read_escape): Avoid int overflow.
1396 (Fload, openp, read_buffer_size, read1)
1397 (substitute_object_recurse, read_vector, read_list, map_obarray):
1398 Use ptrdiff_t, not int, for sizes.
1399 (read1): Use EMACS_INT, not int, for sizes.
1400 Check for size overflow.
1402 * image.c (cache_image): Check for size arithmetic overflow.
1404 * lread.c: Integer overflow issues.
1405 (saved_doc_string_size, saved_doc_string_length)
1406 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1407 Now ptrdiff_t, not int.
1408 (read1): Don't assume doc string length fits in int. Check for
1409 out-of-range doc string lengths.
1410 (read_list): Don't assume file position fits in int.
1411 (read_escape): Check for hex character overflow.
1413 2011-06-22 Leo Liu <sdl.web@gmail.com>
1415 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1416 Move to minibuffer.el.
1418 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1420 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1421 The following patches are for when GLYPH_DEBUG && !XASSERT.
1422 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1423 * dispnew.c (flush_stdout):
1424 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1425 Mark as externally visible.
1426 * dispnew.c (check_window_matrix_pointers): Now static.
1427 * dispnew.c (window_to_frame_vpos):
1428 * xfns.c (unwind_create_frame):
1429 * xterm.c (x_check_font): Remove unused local.
1430 * scroll.c (CHECK_BOUNDS):
1431 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1432 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1433 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1434 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1435 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1437 (debug_method_add): Use va_list and vsprintf rather than relying
1438 on undefined behavior with wrong number of arguments.
1439 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1440 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1441 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1442 since we're not interested in debugging glyphs with old libraries.
1443 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1444 GCC 4.6.0's static checking.
1446 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1448 Integer overflow and signedness fixes (Bug#8873).
1449 A few related buffer overrun fixes, too.
1451 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1453 * dispextern.h (struct face.stipple):
1454 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1455 (x_bitmap_mask, x_allocate_bitmap_record)
1456 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1457 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1458 (x_create_bitmap_from_xpm_data):
1459 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1460 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1462 * xfaces.c (load_pixmap):
1463 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1464 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1465 (.bitmaps_last, struct x_output.icon_bitmap):
1466 Use ptrdiff_t, not int, for bitmap indexes.
1467 (x_allocate_bitmap_record): Check for size overflow.
1468 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1470 Use ptrdiff_t, not int, for overlay counts.
1471 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1472 * editfns.c (overlays_around, get_pos_property):
1473 * textprop.c (get_char_property_and_overlay):
1474 * xdisp.c (next_overlay_change, note_mouse_highlight):
1475 * xfaces.c (face_at_buffer_position):
1476 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1477 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1478 (Fnext_overlay_change, Fprevious_overlay_change)
1479 (mouse_face_overlay_overlaps, Foverlays_in):
1480 Use ptrdiff_t, not int, for sizes.
1481 (overlays_at, overlays_in): Check for size-calculation overflow.
1483 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1485 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1486 (x_session_initialize): Do not assume string length fits in int.
1488 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1489 This is unlikely, but can occur if DPI is outlandish.
1491 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1492 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1494 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1495 * xrdb.c (magic_file_p, search_magic_path):
1496 Omit last arg SUFFIX; it was always 0. All callers changed.
1497 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1499 * xfont.c (xfont_match): Avoid need for strlen.
1501 * xfns.c: Don't assume strlen fits in int.
1502 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1504 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1505 not unsigned long, as we prefer signed integers. All callers changed.
1506 Detect integer overflow in repeat count.
1507 (message_dolog): Don't assume print length fits in 39 bytes.
1508 (display_mode_element): Don't assume strlen fits in int.
1510 * termcap.c: Don't assume sizes fit in int and never overflow.
1511 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1512 (gobble_line): Check for size-calculation overflow.
1514 * minibuf.c (Fread_buffer):
1515 * lread.c (intern, intern_c_string):
1516 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1517 Don't assume string length fits in int.
1519 * keyboard.c (parse_tool_bar_item):
1520 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1522 * font.c: Don't assume string length fits in int.
1523 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1524 Use ptrdiff_t, not int.
1525 (font_intern_prop): Don't assume string length fits in int.
1526 Don't assume integer property fits in fixnum.
1527 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1529 * filelock.c: Fix some buffer overrun and integer overflow issues.
1530 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1531 Reformulate so as not to need the command string.
1532 Invoke gzip -cd rather than gunzip, as it's more portable.
1533 (lock_info_type, lock_file_1, lock_file):
1534 Don't assume pid_t and time_t fit in unsigned long.
1535 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1536 (current_lock_owner): Prefer signed type for sizes.
1537 Use memcpy, not strncpy, where memcpy is what is really wanted.
1538 Don't assume (via atoi) that time_t and pid_t fit in int.
1539 Check for time_t and/or pid_t out of range, e.g., via a network share.
1540 Don't alloca where an auto var works fine.
1542 * fileio.c: Fix some integer overflow issues.
1543 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1544 Don't assume string length fits in int.
1545 (directory_file_name): Don't assume string length fits in long.
1546 (make_temp_name): Don't assume pid fits in int, or that its print
1547 length is less than 20.
1549 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1551 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1553 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1555 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1556 We prefer signed integers, even for size calculations.
1558 * emacs.c: Don't assume string length fits in 'int'.
1559 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1560 (main): Don't invoke strlen when not needed.
1562 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1563 (XD_DEBUG_MESSAGE): Don't waste a byte.
1565 * callproc.c (getenv_internal_1, getenv_internal)
1567 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1569 * lread.c (invalid_syntax): Omit length argument.
1570 All uses changed. This doesn't fix a bug, but it simplifies the
1571 code away from its former Hollerith-constant appearance, and it's
1572 one less 'int' to worry about when looking at integer-overflow issues.
1573 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1575 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1576 This didn't break anything, but it didn't help either.
1577 It's confusing to put a bogus integer in a place where the actual
1578 value does not matter.
1579 (LIST_END_P): Remove unused macro and its bogus comment.
1580 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1582 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1583 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1585 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1586 We prefer signed types, and the value cannot exceed the EMACS_INT
1587 range anyway (because otherwise the length would not be representable).
1588 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1589 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1590 This avoids a GCC warning when WIDE_EMACS_INT.
1592 * indent.c (sane_tab_width): New function.
1593 (current_column, scan_for_column, Findent_to, position_indentation)
1594 (compute_motion): Use it. This is just for clarity.
1595 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1597 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1599 * lisp.h (lint_assume): New macro.
1600 * composite.c (composition_gstring_put_cache):
1601 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1603 * editfns.c, insdel.c:
1604 Omit unnecessary forward decls, to simplify future changes.
1606 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1608 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1610 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1611 Use much-faster test for byte-length change.
1612 Don't assume string byte-length fits in 'int'.
1613 Check that character arg fits in 'int'.
1614 (mapcar1): Declare byte as byte, for clarity.
1616 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1618 * fns.c (concat): Catch string overflow earlier.
1619 Do not rely on integer wraparound.
1621 * dispextern.h (struct it.overlay_strings_charpos)
1622 (struct it.selective): Now EMACS_INT, not int.
1623 * xdisp.c (forward_to_next_line_start)
1624 (back_to_previous_visible_line_start)
1625 (reseat_at_next_visible_line_start, next_element_from_buffer):
1626 Don't arbitrarily truncate the value of 'selective' to int.
1628 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1630 * composite.c: Don't truncate sizes to 'int'.
1631 (composition_gstring_p, composition_reseat_it)
1632 (composition_adjust_point): Use EMACS_INT, not int.
1633 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1634 not EMACS_UINT, for indexes.
1636 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1638 * buffer.c: Include <verify.h>.
1639 (struct sortvec.priority, struct sortstr.priority):
1640 Now EMACS_INT, not int.
1641 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1642 (struct sortstr.size, record_overlay_string)
1643 (struct sortstrlist.size, struct sortlist.used):
1644 Don't truncate size to int.
1645 (record_overlay_string): Check for size-calculation overflow.
1646 (init_buffer_once): Check at compile-time, not run-time.
1648 2011-06-22 Jim Meyering <meyering@redhat.com>
1650 Don't leak an XBM-image-sized buffer
1651 * image.c (xbm_load): Free the image buffer after using it.
1653 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1656 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1657 that Sun C diagnosed.
1658 * fns.c (secure_hash): Fix pointer signedness issue.
1659 * intervals.c (static_offset_intervals): New function.
1660 (offset_intervals): Use it.
1662 2011-06-21 Leo Liu <sdl.web@gmail.com>
1665 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1668 * fns.c (secure_hash): Rename from crypto_hash_function and change
1669 the first arg to accept symbols.
1670 (Fsecure_hash): New primitive.
1671 (syms_of_fns): New symbols.
1673 2011-06-20 Deniz Dogan <deniz@dogan.se>
1675 * process.c (Fset_process_buffer): Clarify return value in
1678 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1680 * dispnew.c (add_window_display_history): Use BVAR.
1682 * xdisp.c (debug_method_add): Use BVAR.
1683 (check_window_end, dump_glyph_matrix, dump_glyph)
1684 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1686 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1689 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1690 check till after the cache is created in init_frame_faces.
1692 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1694 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1696 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1698 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1699 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1700 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1702 Improve buffer-overflow checking (Bug#8873).
1703 * fileio.c (Finsert_file_contents):
1704 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1705 Remove the old (too-loose) buffer overflow checks.
1706 They weren't needed, since make_gap checks for buffer overflow.
1707 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1708 The old code merely checked for Emacs fixnum overflow, and relied
1709 on undefined (wraparound) behavior. The new code avoids undefined
1710 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1712 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1713 Tune. Don't use wider integers than needed. Don't use alloca.
1714 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1716 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1718 * insdel.c, lisp.h (buffer_overflow): New function.
1719 (insert_from_buffer_1, replace_range, replace_range_2):
1720 * insdel.c (make_gap_larger):
1721 * editfns.c (Finsert_char):
1722 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1724 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1726 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1728 Integer overflow and signedness fixes (Bug#8873).
1730 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1731 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1733 * fileio.c: Don't assume EMACS_INT fits in off_t.
1734 (emacs_lseek): New static function.
1735 (Finsert_file_contents, Fwrite_region): Use it.
1736 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1738 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1740 * fns.c: Don't overflow int when computing a list length.
1741 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1742 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1743 truncation on 64-bit hosts. Check for QUIT every
1744 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1745 faster and is responsive enough.
1746 (Flength): Report an error instead of overflowing an integer.
1747 (Fsafe_length): Return a float if the value is not representable
1748 as a fixnum. This shouldn't happen except in contrived situations.
1749 (Fnthcdr, Fsort): Don't assume list length fits in int.
1750 (Fcopy_sequence): Don't assume vector length fits in int.
1752 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1753 (header_size, word_size): New constants.
1754 (allocate_vectorlike): Don't check size overflow here.
1755 (allocate_vector): Check it here instead, since this is the only
1756 caller of allocate_vectorlike that could cause overflow.
1757 Check that the new vector's length is representable as a fixnum.
1759 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1760 The previous code was bogus. For example, next_almost_prime (32)
1761 returned 39, which is undesirable as it is a multiple of 3; and
1762 next_almost_prime (24) returned 25, which is a multiple of 5 so
1763 why was the code bothering to check for multiples of 7?
1765 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1767 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1769 Variadic C functions now count arguments with ptrdiff_t.
1770 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1771 Back then I didn't know that the Emacs coding style prefers signed int.
1772 Also, in the meantime I found a few more instances where arguments
1773 were being counted with int, which may truncate counts on 64-bit
1774 machines, or EMACS_INT, which may be unnecessarily wide.
1775 * lisp.h (struct Lisp_Subr.function.aMANY)
1776 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1777 Arg counts are now ptrdiff_t, not size_t.
1778 All variadic functions and their callers changed accordingly.
1779 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1780 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1781 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1782 * callint.c (Fcall_interactively): Check arg count for overflow,
1783 to avoid potential buffer overrun. Use signed char, not 'int',
1784 for 'varies' array, so that we needn't bother to check its size
1785 calculation for overflow.
1786 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1787 * eval.c (apply_lambda):
1788 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1789 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1790 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1792 * callint.c (Fcall_interactively): Don't use index var as event count.
1794 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1795 * mem-limits.h (SIZE): Remove; no longer used.
1797 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1799 Remove unnecessary casts.
1800 * xterm.c (x_term_init):
1801 * xfns.c (x_set_border_pixel):
1802 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1803 These aren't needed now that we assume ANSI C.
1805 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1806 It's more likely to cause problems (due to unsigned overflow)
1809 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1811 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1813 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1815 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1817 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1819 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1821 GLYPH_CODE_FACE returns EMACS_INT, not int.
1822 * dispextern.h (merge_faces):
1823 * xfaces.c (merge_faces):
1824 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1825 Don't assume EMACS_INT fits in int.
1827 * character.h (CHAR_VALID_P): Remove unused parameter.
1828 * fontset.c, lisp.h, xdisp.c: All uses changed.
1830 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1832 * fns.c (concat): Minor tuning based on overflow analysis.
1833 This doesn't fix any bugs. Use int to hold character, instead
1834 of constantly refetching from Emacs object. Use XFASTINT, not
1835 XINT, for value known to be a character. Don't bother comparing
1836 a single byte to 0400, as it's always less.
1838 * floatfns.c (Fexpt):
1839 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1841 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1844 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1846 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1847 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1848 incorrectly succeed when S was a string, because 4294967386 was
1849 truncated before it was used.
1851 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1852 Otherwise, an out-of-range integer could cause undefined behavior
1855 * composite.c: Use int, not EMACS_INT, for characters.
1856 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1857 EMACS_INT, for values that are known to be in character range.
1858 This doesn't fix any bugs but is the usual style inside Emacs and
1859 may generate better code on 32-bit machines.
1861 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1862 This is for reasons similar to the recent CHAR_STRING fix.
1863 * charset.c (Fencode_char): Check that character arg is actually
1864 a character. Pass an int to ENCODE_CHAR.
1865 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1866 wider than 'int', as a compile-time check to prevent future regressions
1869 * character.c (char_string): Remove unnecessary casts.
1871 Make sure a 64-bit char is never passed to CHAR_STRING.
1872 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1873 by silently ignoring the top 32 bits, allowing some values
1874 that were far too large to be valid characters.
1875 * character.h: Include <verify.h>.
1876 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1877 arguments are no wider than unsigned, as a compile-time check
1878 to prevent future regressions in this area.
1880 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1881 (Fsubst_char_in_region):
1883 * xdisp.c (decode_mode_spec_coding):
1884 Adjust to CHAR_STRING's new requirement.
1885 * editfns.c (Finsert_char, Fsubst_char_in_region):
1886 * fns.c (concat): Check that character args are actually
1887 characters. Without this test, these functions did the wrong
1888 thing with wildly out-of-range values on 64-bit hosts.
1890 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1891 These casts should not be needed on 32-bit hosts, either.
1892 * keyboard.c (read_char):
1893 * lread.c (Fload): Remove casts to unsigned.
1895 * lisp.h (UNSIGNED_CMP): New macro.
1896 This fixes comparison bugs on 64-bit hosts.
1897 (ASCII_CHAR_P): Use it.
1898 * casefiddle.c (casify_object):
1899 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1900 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1901 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1902 * dispextern.h (FACE_FROM_ID):
1903 * keyboard.c (read_char): Use UNSIGNED_CMP.
1905 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1906 not to EMACS_INT, to avoid GCC warning.
1908 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1910 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1911 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1912 isn't needed on 32-bit machines.
1914 * buffer.c (Fgenerate_new_buffer_name):
1915 Use EMACS_INT for count, not int.
1916 (advance_to_char_boundary): Return EMACS_INT, not int.
1918 * data.c (Qcompiled_function): Now static.
1920 * window.c (window_body_lines): Now static.
1922 * image.c (gif_load): Rename local to avoid shadowing.
1924 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1925 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1926 * alloc.c (make_save_value): Integer argument is now of type
1928 (mark_object): Use ptrdiff_t, not int.
1929 * lisp.h (pD): New macro.
1930 * print.c (print_object): Use it.
1932 * alloc.c: Use EMACS_INT, not int, to count objects.
1933 (total_conses, total_markers, total_symbols, total_vector_size)
1934 (total_free_conses, total_free_markers, total_free_symbols)
1935 (total_free_floats, total_floats, total_free_intervals)
1936 (total_intervals, total_strings, total_free_strings):
1937 Now EMACS_INT, not int. All uses changed.
1938 (Fgarbage_collect): Compute overall total using a double, so that
1939 integer overflow is less likely to be a problem. Check for overflow
1940 when converting back to an integer.
1941 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1942 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1943 These were 'int' variables that could overflow on 64-bit hosts;
1944 they were never used, so remove them instead of repairing them.
1945 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1946 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1947 Previously, this ceilinged at INT_MAX, but that doesn't work on
1949 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1951 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1952 (allocate_vectorlike): Check for ptrdiff_t overflow.
1953 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1954 when a (possibly-narrower) signed value would do just as well.
1955 We prefer using signed arithmetic, to avoid comparison confusion.
1957 * alloc.c: Catch some string size overflows that we were missing.
1958 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1959 for convenience in STRING_BYTES_MAX.
1960 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1961 The definition here is exact; the one in lisp.h was approximate.
1962 (allocate_string_data): Check for string overflow. This catches
1963 some instances we weren't catching before. Also, it catches
1964 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1965 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1966 and ptrdiff_t and EMACS_INT are both 64 bits.
1968 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1969 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1970 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1972 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1974 * alloc.c (Fmake_string): Check for out-of-range init.
1976 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1978 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1980 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1982 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1983 xg_get_default_scrollbar_width.
1985 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1986 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1987 (style_changed_cb): Call update_theme_scrollbar_width and call
1988 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1989 all frames (Bug#8505).
1990 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1991 Call gtk_window_set_resizable if HAVE_GTK3.
1992 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1993 and height if HAVE_GTK3 (Bug#8505).
1994 (scroll_bar_width_for_theme): New variable.
1995 (update_theme_scrollbar_width): New function.
1996 (xg_get_default_scrollbar_width): Move code to
1997 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1998 (xg_initialize): Call update_theme_scrollbar_width.
2000 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2002 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2004 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2006 * frame.c (make_frame): Call other_buffer_safely instead of
2009 * window.c (temp_output_buffer_show): Call display_buffer with
2010 second argument Vtemp_buffer_show_specifiers and reset latter
2011 immediately after the call.
2012 (Vtemp_buffer_show_specifiers): New variable.
2013 (auto_window_vscroll_p, next_screen_context_lines)
2014 (Vscroll_preserve_screen_position): Remove leading asterisks from
2017 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2019 Fix minor problems found by GCC 4.6.0 static checking.
2020 * buffer.c (Qclone_number): Remove for now, as it's unused.
2021 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2022 (record_buffer): Remove unused local.
2023 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2024 (set_frame_buffer_list): Remove; unused.
2025 * frame.h (other_visible_frames): Remove decl.
2026 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2027 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2028 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2030 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2031 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2032 Define only if HAVE_GPM.
2033 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2034 (update_hints_inhibit): Remove; never set. All uses removed.
2035 * widgetprv.h (emacsFrameClassRec): Remove decl.
2036 * window.c (delete_deletable_window): Now returns void, since it
2037 wasn't returning anything.
2038 (compare_window_configurations): Remove unused locals.
2039 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2040 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2041 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2042 the same widths as pointers. This follows up on the 2011-05-06 patch.
2043 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2044 * xterm.h: Likewise.
2045 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2047 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2049 * makefile.w32-in: Update dependencies.
2050 (LISP_H): Add lib/intprops.h.
2052 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2054 * image.c (gif_load): Add animation frame delay to the metadata.
2055 (syms_of_image): Use DEFSYM. New symbol `delay'.
2057 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2059 * window.c (delete_deletable_window): Re-add.
2060 (Fset_window_configuration): Rewrite to handle dead buffers and
2061 consequently deletable windows.
2062 (window_tree, Fwindow_tree): Remove. Supply functionality in
2064 (compare_window_configurations): Simplify code.
2066 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2068 * image.c (imagemagick_load_image): Fix type mismatch.
2069 (Fimagemagick_types): Likewise.
2071 * window.h (replace_buffer_in_windows): Declare.
2073 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2075 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2076 Qclone_number. Remove external declaration of Qdelete_window.
2077 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2079 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2080 Qbuffer_list_update_hook if allowed.
2081 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2082 buffer list implementation.
2083 (other_buffer_safely): New function.
2084 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2085 calls to replace_buffer_in_windows and
2086 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2088 (record_buffer): Inhibit quitting and rewrite using quittable
2089 functions. Run Qbuffer_list_update_hook if allowed.
2090 (Frecord_buffer, Funrecord_buffer): New functions.
2091 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2092 switch-to-buffer to window.el.
2093 (bury-buffer): Move to window.el.
2094 (Vbuffer_list_update_hook): New variable.
2096 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2099 * window.h (resize_frame_windows): Move up in code.
2100 (Fwindow_frame): Remove EXFUN.
2101 (replace_buffer_in_all_windows): Remove prototype.
2102 (replace_buffer_in_windows_safely): Add prototype.
2104 * window.c: Declare Qdelete_window static again. Move down
2105 declaration of select_count.
2106 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2107 (Fother_window): Move to window.el.
2108 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2109 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2110 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2112 (replace_buffer_in_windows): Implement by calling
2113 Qreplace_buffer_in_windows.
2114 (replace_buffer_in_all_windows): Remove with some functionality
2115 moved into replace_buffer_in_windows_safely.
2116 (replace_buffer_in_windows_safely): New function.
2117 (select_window_norecord, select_frame_norecord): Move in front
2118 of run_window_configuration_change_hook. Remove now obsolete
2120 (Fset_window_buffer): Rewrite doc-string. Call
2121 Qrecord_window_buffer.
2122 (keys_of_window): Move binding for other-window to window.el.
2124 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2126 * dispextern.h (struct image): Replace data member, whose int_val
2127 and ptr_val fields were not used by anything, with a single
2130 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2131 (gif_clear_image, gif_load, imagemagick_load_image)
2132 (gs_clear_image, gs_load): Callers changed.
2134 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2136 * buffer.h: Include <time.h>, for time_t.
2137 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2139 Fix minor problems found by static checking.
2141 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2143 Make identifiers static if they are not used in other modules.
2144 * data.c (Qcompiled_function, Qframe, Qvector):
2145 * image.c (QimageMagick, Qsvg):
2146 * minibuf.c (Qmetadata):
2147 * window.c (resize_window_check, resize_root_window): Now static.
2148 * window.h (resize_window_check, resize_root_window): Remove decls.
2150 * window.c (window_deletion_count, delete_deletable_window):
2152 (window_body_lines): Now static.
2153 (Fdelete_other_windows_internal): Mark vars as initialized.
2154 Make sure 'resize_failed' is initialized.
2155 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2156 (resize_window_apply): Remove unused local.
2157 * window.h (delete_deletable_window): Remove decl.
2159 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2160 (imagemagick_load_image): Fix pointer signedness problem by changing
2161 last arg from unsigned char * to char *. All uses changed.
2162 Also, fix a local for similar reasons.
2163 Remove unused locals. Remove locals to avoid shadowing.
2164 (fn_rsvg_handle_free): Remove; unused.
2165 (svg_load, svg_load_image): Fix pointer signedness problem.
2166 (imagemagick_load_image): Don't use garbage pointer image_wand.
2168 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2170 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2172 * image.c (gif_load): Fix omitted cast error introduced by
2175 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2177 * window.h (resize_proportionally, orig_total_lines)
2178 (orig_top_line): Remove from window structure.
2179 (set_window_height, set_window_width, change_window_heights)
2180 (Fdelete_window): Remove prototypes.
2181 (resize_frame_windows): Remove duplicate declaration.
2183 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2185 * window.h (resize_frame_windows, resize_window_check)
2186 (delete_deletable_window, resize_root_window)
2187 (resize_frame_windows): Declare prototypes.
2189 * window.c (resize_window_apply): Make definition be "static" to
2190 match the prototype.
2192 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2194 * window.c: Remove declarations of Qwindow_size_fixed,
2195 window_min_size_1, window_min_size_2, window_min_size,
2196 size_window, window_fixed_size_p, enlarge_window, delete_window.
2197 Remove static from declaration of Qdelete_window, it's
2198 temporarily needed by Fbury_buffer.
2199 (replace_window): Don't assign orig_top_line and
2201 (Fdelete_window, delete_window): Remove. Window deletion is
2202 handled by window.el.
2203 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2204 Fdelete_window calls with calls to Qdelete_window.
2205 (Fdelete_other_windows): Remove. Deleting other windows is
2206 handled by window.el.
2207 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2208 handled in window.el.
2209 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2210 Window minimum sizes are handled in window.el.
2211 (shrink_windows, size_window, set_window_height)
2212 (set_window_width, change_window_heights, window_height)
2213 (window_width, CURBEG, CURSIZE, enlarge_window)
2214 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2215 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2216 handled in window.el.
2217 (make_dummy_parent): Rename to make_parent_window and give it a
2218 second argument horflag.
2219 (make_window): Don't set resize_proportionally any more.
2220 (Fsplit_window): Remove. Windows are split in window.el.
2221 (save_restore_action, save_restore_orig_size)
2222 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2223 Resize mini windows in window.el.
2224 (grow_mini_window, shrink_mini_window): Implement by calling
2225 Qresize_root_window_vertically, resize_window_check and
2226 resize_window_apply.
2227 (saved_window, Fset_window_configuration, save_window_save): Do
2228 not handle orig_top_line, orig_total_lines, and
2229 resize_proportionally.
2230 (window_min_height, window_min_width): Move to window.el.
2231 (keys_of_window): Move bindings for delete-other-windows,
2232 split-window, delete-window and enlarge-window to window.el.
2234 * buffer.c: Temporarily extern Qdelete_window.
2235 (Fbury_buffer): Temporarily call Qdelete_window instead of
2236 Fdelete_window (Fbury_buffer will move to window.el soon).
2238 * frame.c (set_menu_bar_lines_1): Remove code handling
2239 orig_top_line and orig_total_lines.
2241 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2242 set_window_height but set heights directly.
2243 (change_frame_size_1): Use resize_frame_windows.
2245 * xdisp.c (init_xdisp): Don't use set_window_height but set
2248 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2249 resize_frame_windows instead of change_window_heights and run
2250 run_window_configuration_change_hook.
2252 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2253 instead of change_window_heights and run
2254 run_window_configuration_change_hook.
2256 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2258 * window.c (replace_window): Rename second argument REPLACEMENT to
2259 NEW. New third argument SETFLAG. Rewrite.
2260 (delete_window, make_dummy_parent): Call replace_window with
2262 (window_list_1): Move down in code.
2263 (run_window_configuration_change_hook): Move set_buffer part
2264 before select_frame_norecord part in order to unwind correctly.
2265 Rename count1 to count.
2266 (recombine_windows, delete_deletable_window, resize_root_window)
2267 (Fdelete_other_windows_internal)
2268 (Frun_window_configuration_change_hook, make_parent_window)
2269 (resize_window_check, resize_window_apply, Fresize_window_apply)
2270 (resize_frame_windows, Fsplit_window_internal)
2271 (Fdelete_window_internal, Fresize_mini_window_internal): New
2273 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2275 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2277 * window.h (window): Add some new members to window structure -
2278 normal_lines, normal_cols, new_total, new_normal, clone_number,
2279 splits, nest, prev_buffers, next_buffers.
2280 (WINDOW_TOTAL_SIZE): Move here from window.c.
2281 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2283 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2285 (make_dummy_parent): Set new members of windows structure.
2286 (make_window): Move down in code. Handle new members of window
2288 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2289 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2290 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2291 (Fset_window_prev_buffers, Fwindow_next_buffers)
2292 (Fset_window_next_buffers, Fset_window_clone_number): New
2294 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2295 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2297 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2298 Argument WINDOW can be now internal window too.
2299 (Fwindow_use_time): Move up in code.
2300 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2302 (Fset_window_configuration, saved_window)
2303 (Fcurrent_window_configuration, save_window_save): Handle new
2304 members of window structure.
2305 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2306 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2307 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2308 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2309 Qget_mru_window, Qresize_root_window,
2310 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2311 Qauto_buffer_name; staticpro them.
2313 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2315 * window.c (Fwindow_total_size, Fwindow_left_column)
2316 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2317 (Fwindow_list_1): New functions.
2318 (window_box_text_cols): Replace with window_body_cols.
2319 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2320 window_body_cols instead of window_box_text_cols.
2321 (delete_window, Fset_window_configuration): Call
2322 delete_all_subwindows with window as argument.
2323 (delete_all_subwindows): Take a window as argument and not a
2325 (window_loop): Remove handling of GET_LRU_WINDOW and
2327 (Fget_lru_window, Fget_largest_window): Move to window.el.
2329 * window.h: Extern window_body_cols instead of
2330 window_box_text_cols. delete_all_subwindows now takes a
2331 Lisp_Object as argument.
2333 * indent.c (compute_motion, Fcompute_motion): Use
2334 window_body_cols instead of window_box_text_cols.
2336 * frame.c (delete_frame): Call delete_all_subwindows with root
2339 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2341 * fns.c (Fputhash): Document return value.
2343 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2345 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2347 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2349 Cons<->int and similar integer overflow fixes (Bug#8794).
2351 Check for overflow when converting integer to cons and back.
2352 * charset.c (Fdefine_charset_internal, Fdecode_char):
2353 Use cons_to_unsigned to catch overflow.
2354 (Fencode_char): Use INTEGER_TO_CONS.
2355 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2356 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2357 * data.c (long_to_cons, cons_to_long): Remove.
2358 (cons_to_unsigned, cons_to_signed): New functions.
2359 These signal an error for invalid or out-of-range values.
2360 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2361 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2362 * font.c (Ffont_variation_glyphs):
2363 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2364 * lisp.h: Include <intprops.h>.
2365 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2366 (cons_to_signed, cons_to_unsigned): New decls.
2367 (long_to_cons, cons_to_long): Remove decls.
2368 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2369 (Fprimitive_undo): Use CONS_TO_INTEGER.
2370 * xfns.c (Fx_window_property): Likewise.
2371 * xselect.c: Include <limits.h>.
2372 (x_own_selection, selection_data_to_lisp_data):
2373 Use INTEGER_TO_CONS.
2374 (x_handle_selection_request, x_handle_selection_clear)
2375 (x_get_foreign_selection, Fx_disown_selection_internal)
2376 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2377 (lisp_data_to_selection_data): Use cons_to_unsigned.
2378 (x_fill_property_data): Use cons_to_signed.
2379 Report values out of range.
2381 Check for buffer and string overflow more precisely.
2382 * buffer.h (BUF_BYTES_MAX): New macro.
2383 * lisp.h (STRING_BYTES_MAX): New macro.
2384 * alloc.c (Fmake_string):
2385 * character.c (string_escape_byte8):
2386 * coding.c (coding_alloc_by_realloc):
2387 * doprnt.c (doprnt):
2388 * editfns.c (Fformat):
2390 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2391 since they may not be the same number.
2392 * editfns.c (Finsert_char):
2393 * fileio.c (Finsert_file_contents):
2394 Likewise for BUF_BYTES_MAX.
2396 * image.c: Use ptrdiff_t, not int, for sizes.
2397 (slurp_file): Switch from int to ptrdiff_t.
2399 (slurp_file): Check that file size fits in both size_t (for
2400 malloc) and ptrdiff_t (for sanity and safety).
2402 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2403 if b->modtime has its maximal value.
2405 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2407 Don't assume time_t can fit into int.
2408 * buffer.h (struct buffer.modtime): Now time_t, not int.
2409 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2410 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2412 Minor fixes for signed vs unsigned integers.
2413 * character.h (MAYBE_UNIFY_CHAR):
2414 * charset.c (maybe_unify_char):
2415 * keyboard.c (read_char, reorder_modifiers):
2416 XINT -> XFASTINT, since the integer must be nonnegative.
2417 * ftfont.c (ftfont_spec_pattern):
2418 * keymap.c (access_keymap, silly_event_symbol_error):
2419 XUINT -> XFASTINT, since the integer must be nonnegative.
2420 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2421 since it makes no difference and we prefer signed.
2422 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2423 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2426 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2428 * window.h (Fwindow_frame): Declare.
2430 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2432 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2433 (SPARE_MEMORY): Always define.
2434 (LARGE_REQUEST): Remove.
2435 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2437 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2439 * lisp.h: Move EXFUNS for Fframe_root_window,
2440 Fframe_first_window and Fset_frame_selected_window to window.h.
2442 * window.h: Move EXFUNS for Fframe_root_window,
2443 Fframe_first_window and Fset_frame_selected_window here from
2446 * frame.c (Fwindow_frame, Fframe_first_window)
2447 (Fframe_root_window, Fframe_selected_window)
2448 (Fset_frame_selected_window): Move to window.c.
2449 (Factive_minibuffer_window): Move to minibuf.c.
2450 (Fother_visible_frames_p): New function.
2452 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2454 * window.c (decode_window, decode_any_window): Move up in code.
2455 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2456 (inhibit_frame_unsplittable): Remove unused variable.
2457 (Fwindow_buffer): Move up and rewrite doc-string.
2458 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2459 (Fwindow_prev): New functions.
2460 (Fwindow_frame): Move here from frame.c. Accept any window as
2462 (Fframe_root_window, Fframe_first_window)
2463 (Fframe_selected_window): Move here from frame.c. Accept frame
2464 or arbitrary window as argument. Update doc-strings.
2465 (Fminibuffer_window): Move up in code.
2466 (Fwindow_minibuffer_p): Move up in code and simplify.
2467 (Fset_frame_selected_window): Move here from frame.c.
2469 (Fselected_window, select_window, Fselect_window): Move up in
2470 code. Minor doc-string fixes.
2472 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2474 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2475 Do not assume that spare memory exists; that assumption is valid
2476 only if SYSTEM_MALLOC.
2477 (LARGE_REQUEST): New macro, so that the issue of large requests
2478 is separated from the issue of spare memory.
2480 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2482 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2485 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2487 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2490 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2492 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2494 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2496 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2497 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2499 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2501 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2503 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2505 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2506 (x_clipboard_manager_save): Add return value.
2507 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2509 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2510 Obey Vx_select_enable_clipboard_manager. Catch errors in
2511 x_clipboard_manager_save (Bug#8779).
2512 (Vx_select_enable_clipboard_manager): New variable.
2513 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2515 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2517 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2519 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2521 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2522 in the current matrix if keep_current_p is non-zero.
2524 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2526 * bidi.c (bidi_level_of_next_char): Fix last change.
2528 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2530 Support bidi reordering of text covered by display properties.
2532 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2533 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2534 (bidi_cache_search, bidi_cache_iterator_state)
2535 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2536 (bidi_level_of_next_char, bidi_move_to_visually_next):
2537 Support character positions inside a run of characters covered by a
2539 (bidi_paragraph_init, bidi_resolve_explicit_1)
2540 (bidi_level_of_next_char): Call bidi_fetch_char and
2541 bidi_fetch_char_advance instead of FETCH_CHAR and
2543 (bidi_init_it): Initialize new members.
2544 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2546 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2547 instead of using explicit *_CHAR codes.
2548 (bidi_resolve_explicit, bidi_resolve_weak):
2549 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2550 bidirectional text is supported only in multibyte buffers.
2551 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2552 it to initialize the frame_window_p member of struct bidi_it.
2553 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2554 (bidi_resolve_explicit, bidi_resolve_weak)
2555 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2556 bidi_it->nchars is non-positive.
2557 (bidi_level_of_next_char): Don't try to lookup the cache for the
2558 next/previous character if nothing is cached there yet, or if we
2559 were just reseat()'ed to a new position.
2561 * xdisp.c (set_cursor_from_row): Set start and stop points
2562 according to the row's direction when priming the loop that looks
2563 for the glyph on which to display cursor.
2564 (single_display_spec_intangible_p): Function deleted.
2565 (display_prop_intangible_p): Reimplement to call
2566 handle_display_spec instead of single_display_spec_intangible_p.
2567 Accept 3 additional arguments needed by handle_display_spec.
2568 This fixes incorrect cursor motion across display property with complex
2569 values: lists, `(when COND...)' forms, etc.
2570 (single_display_spec_string_p): Support property values that are
2571 lists with the argument STRING its top-level element.
2572 (display_prop_string_p): Fix the condition for processing a
2573 property that is a list to be consistent with handle_display_spec.
2574 (handle_display_spec): New function, refactored from the
2575 last portion of handle_display_prop.
2576 (compute_display_string_pos): Accept additional argument
2577 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2578 value of a `display' property is a "replacing spec".
2579 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2580 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2581 the display property, but just return a value indicating whether
2582 the display property will replace the characters it covers.
2583 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2584 frame_window_p members of struct bidi_it.
2585 (compute_display_string_pos, compute_display_string_end):
2587 (push_it): Accept second argument POSITION, where pop_it should
2588 jump to continue iteration.
2589 (reseat_1): Initialize bidi_it.disp_pos.
2591 * keyboard.c (adjust_point_for_property): Adjust the call to
2592 display_prop_intangible_p to its new signature.
2594 * dispextern.h (struct bidi_it): New member frame_window_p.
2595 (bidi_init_it): Update prototypes.
2596 (display_prop_intangible_p): Update prototype.
2597 (compute_display_string_pos, compute_display_string_end):
2599 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2602 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2604 Malloc failure behavior now depends on size of allocation.
2605 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2606 * lisp.h: Change signatures accordingly.
2607 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2608 All callers changed. (Bug#8762)
2610 * gnutls.c: Use Emacs's memory allocators.
2611 Without this change, the gnutls library would invoke malloc etc.
2612 directly, which causes problems on non-SYNC_INPUT hosts, and which
2613 runs afoul of improving memory_full behavior. (Bug#8761)
2614 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2615 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2616 xfree instead of the default malloc, realloc, free.
2617 (Fgnutls_boot): No need to check for memory allocation failure,
2618 since xmalloc does that for us.
2620 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2621 * category.c (hash_get_category_set):
2622 * ccl.c (ccl_driver):
2623 * charset.c (Fdefine_charset_internal):
2624 * charset.h (struct charset.hash_index):
2625 * composite.c (get_composition_id, gstring_lookup_cache)
2626 (composition_gstring_put_cache):
2627 * composite.h (struct composition.hash_index):
2628 * dispextern.h (struct image.hash):
2629 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2630 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2631 (hashfn_equal, hashfn_user_defined, make_hash_table)
2632 (maybe_resize_hash_table, hash_lookup, hash_put)
2633 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2634 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2635 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2636 * image.c (make_image, search_image_cache, lookup_image)
2637 (xpm_put_color_table_h):
2638 * lisp.h (struct Lisp_Hash_Table):
2639 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2640 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2641 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2642 * alloc.c (allocate_vectorlike):
2643 Check for overflow in vector size calculations.
2644 * ccl.c (ccl_driver):
2645 Check for overflow when converting EMACS_INT to int.
2646 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2647 need to be updated by these changes.
2648 * fns.c (make_hash_table, maybe_resize_hash_table):
2649 Check for integer overflow with large hash tables.
2650 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2651 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2652 (SXHASH_REDUCE): New macro.
2653 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2654 Use it instead of discarding useful hash info with large hash values.
2655 (sxhash_float): New function.
2656 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2657 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2658 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2659 Rewrite to use FIXNUM_BITS, as this simplifies things.
2660 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2661 Adjust signatures to match updated version of code.
2662 (consing_since_gc): Now EMACS_INT, since a single hash table can
2663 use more than INT_MAX bytes.
2665 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2667 Make it possible to build with GCC-4.6+ -O2 -flto.
2669 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2671 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2673 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2674 Call minibuffer-inactive-mode.
2676 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2678 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2679 Update dependencies.
2681 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2683 * data.c (init_data): Remove code for UTS, this system is not
2686 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2688 Don't force ./temacs to start in terminal mode.
2690 * frame.c (make_initial_frame): Initialize faces in all cases, not
2691 only when CANNOT_DUMP is defined.
2692 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2694 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2696 * dispnew.c (add_window_display_history): Use const for the string
2697 pointer. Remove declaration, not needed.
2699 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2701 Use 'inline', not 'INLINE'.
2702 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2703 * alloc.c, fontset.c (INLINE): Remove.
2704 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2705 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2706 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2707 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2708 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2710 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2712 Make it possible to run ./temacs.
2714 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2715 syms_of_callproc does the same thing. Remove test for
2716 "initialized", do it in the caller.
2717 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2719 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2721 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2722 (read_minibuf): Use get_minibuffer.
2723 (syms_of_minibuf): Use DEFSYM.
2724 (Qmetadata): New var.
2725 * data.c (Qbuffer): Don't make it static.
2726 (syms_of_data): Use DEFSYM.
2728 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2730 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2731 (CCL_CODE_MIN): New macro.
2733 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2735 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2737 * eval.c (Qdebug): Now static.
2738 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2739 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2740 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2742 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2744 * image.c: Various fixes to ImageMagick code comments.
2745 (Fimagemagick_types): Doc fix.
2747 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2749 Minor fixes prompted by GCC 4.6.0 warnings.
2751 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2753 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2754 (x_clipboard_manager_save_all): Move extern decl to ...
2755 * xterm.h: ... here, so that it can be checked for consistency.
2757 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2759 * xselect.c (x_clipboard_manager_save_frame)
2760 (x_clipboard_manager_save_all): New functions.
2761 (Fx_clipboard_manager_save): Lisp function deleted.
2763 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2764 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2766 * xterm.h: Update prototype.
2768 2011-05-28 William Xu <william.xwl@gmail.com>
2770 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2773 2011-05-28 Jim Meyering <meyering@redhat.com>
2775 Avoid a sign-extension bug in crypto_hash_function.
2776 * fns.c (to_uchar): Define.
2777 (crypto_hash_function): Use it to convert some newly-signed
2778 variables to unsigned, to avoid sign-extension bugs. For example,
2779 without this change, (md5 "truc") would evaluate to
2780 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2781 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2782 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2784 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2786 Integer overflow fixes.
2788 * dbusbind.c: Serial number integer overflow fixes.
2789 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2790 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2791 to hold a serial number that is too large for a fixnum.
2792 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2793 Check for serial numbers out of range. Decode any serial number
2794 that was so large that it became a float. (Bug#8722)
2796 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2797 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2798 Use XFASTINT rather than XUINT when numbers are nonnegative.
2799 (xd_append_arg, Fdbus_method_return_internal):
2800 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2801 arguments, check that Lisp number is nonnegative, rather than
2802 silently wrapping negative numbers around. (Bug#8722)
2803 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2806 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2808 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2810 ccl: add integer overflow checks
2811 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2812 (IN_INT_RANGE): New macros.
2813 (ccl_driver): Use them to check for integer overflow when
2814 decoding a CCL program. Many of the new checks are whether XINT (x)
2815 fits in int; it doesn't always, on 64-bit hosts. The new version
2816 doesn't catch all possible integer overflows, but it's an
2817 improvement. (Bug#8719)
2819 * alloc.c (make_event_array): Use XINT, not XUINT.
2820 There's no need for unsigned here.
2822 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2823 This follows up to the 2011-05-06 change that substituted uintptr_t
2824 for EMACS_INT. This case wasn't caught back then.
2826 Rework Fformat to avoid integer overflow issues.
2827 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2828 now (part of C89). Include <verify.h>.
2829 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2830 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2831 (Fformat): Avoid the prepass trying to compute sizes; it was only
2832 approximate and thus did not catch overflow reliably. Instead, walk
2833 through the format just once, formatting and computing sizes as we go,
2834 checking for integer overflow at every step, and allocating a larger
2835 buffer as needed. Keep track separately whether the format is
2836 multibyte. Keep only the most-recently calculated precision, rather
2837 than them all. Record whether each argument has been converted to
2838 string. Use EMACS_INT, not int, for byte and char and arg counts.
2839 Support field widths and precisions larger than INT_MAX. Avoid
2840 sprintf's undefined behavior with conversion specifications such as %#d
2841 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2842 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2843 formatting out-of-range floating point numbers with int
2846 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2848 * data.c: Avoid integer truncation in expressions involving floats.
2849 * data.c: Include <intprops.h>.
2850 (arith_driver): When there's an integer overflow in an expression
2851 involving floating point, convert the integers to floating point
2852 so that the resulting value does not suffer from catastrophic
2853 integer truncation. For example, on a 64-bit host (* 4
2854 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2855 Do not rely on undefined behavior after integer overflow.
2857 merge count_size_as_multibyte, parse_str_to_multibyte
2858 * character.c, character.h (count_size_as_multibyte):
2859 Rename from parse_str_to_multibyte; all uses changed.
2860 Check for integer overflow.
2861 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2862 since it's now a duplicate of the other. This is more of
2863 a character than a buffer op, so better that it's in character.c.
2864 * fns.c, print.c: Adjust to above changes.
2866 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2868 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2870 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2872 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2873 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2874 (x_clipboard_manager_save): Now static.
2875 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2877 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2878 (crypto_hash_function): Now static.
2879 Fix pointer signedness problems. Avoid unnecessary initializations.
2881 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2883 * termhooks.h (Vselection_alist): Make it terminal-local.
2885 * terminal.c (create_terminal): Initialize it.
2887 * xselect.c: Support for clipboard managers.
2888 (Vselection_alist): Move to termhooks.h as terminal-local var.
2889 (LOCAL_SELECTION): New macro.
2890 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2891 (symbol_to_x_atom): Remove gratuitous arg.
2892 (x_handle_selection_request, lisp_data_to_selection_data)
2893 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2894 (x_own_selection, x_get_local_selection, x_convert_selection):
2895 New arg, specifying work frame. Use terminal-local Vselection_alist.
2896 (some_frame_on_display): Delete unused function.
2897 (Fx_own_selection_internal, Fx_get_selection_internal)
2898 (Fx_disown_selection_internal, Fx_selection_owner_p)
2899 (Fx_selection_exists_p): New optional frame arg.
2900 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2901 (x_handle_selection_clear): Don't treat other terminals with the
2902 same keyboard specially. Use the terminal-local Vselection_alist.
2903 (x_clear_frame_selections): Use Frun_hook_with_args.
2905 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2907 * xterm.h: Add support for those atoms.
2909 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2911 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2912 (converted_selections, conversion_fail_tag): New global variables.
2913 (x_selection_request_lisp_error): Free the above.
2914 (x_get_local_selection): Remove unnecessary code.
2915 (x_reply_selection_request): Args changed; handle arbitrary array
2916 of converted selections stored in converted_selections.
2917 Separate the XChangeProperty and SelectionNotify steps.
2918 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2919 (x_convert_selection): New function.
2920 (x_handle_selection_event): Simplify.
2921 (x_get_foreign_selection): Don't ignore incoming requests while
2922 waiting for an answer; this will fail when we implement
2923 SAVE_TARGETS, and seems unnecessary anyway.
2924 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2925 (Vx_sent_selection_functions): Doc fix.
2927 2011-05-26 Leo Liu <sdl.web@gmail.com>
2929 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2931 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2933 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2935 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2936 for fringe update if it has periodic bitmap.
2937 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2938 and fringe_bitmap_periodic_p.
2940 * fringe.c (get_fringe_bitmap_data): New function.
2941 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2942 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2943 row. Mark glyph row for fringe update if periodicity changed.
2945 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2946 for fringe update unless it has periodic bitmap.
2948 2011-05-25 Kenichi Handa <handa@m17n.org>
2950 * xdisp.c (get_next_display_element): Set correct it->face_id for
2951 a static composition.
2953 2011-05-24 Leo Liu <sdl.web@gmail.com>
2956 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2958 * fns.c (crypto_hash_function, Fsha1): New function.
2959 (Fmd5): Use crypto_hash_function.
2960 (syms_of_fns): Add Ssha1.
2962 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2964 * gnutls.c: Remove unused macros.
2965 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2966 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2967 Remove macros that are defined and never used.
2968 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2970 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2972 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2973 (Fx_get_selection_internal): Minor cleanup.
2974 (Fx_own_selection_internal): Rename arguments for consistency with
2977 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2979 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2981 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2983 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2985 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2987 * dispnew.c (scrolling_window): Don't exclude the case that the
2988 last enabled row in the desired matrix touches the bottom boundary.
2990 2011-05-21 Glenn Morris <rgm@gnu.org>
2992 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2993 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2994 and add some more files.
2996 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2998 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2999 report_file_error introduced by the change from 2011-05-07.
3001 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3003 * systime.h (Time): Define only if emacs is defined.
3004 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3005 where the include path doesn't have X11/X.h by default. See
3006 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3008 2011-05-20 Kenichi Handa <handa@m17n.org>
3010 * composite.c (find_automatic_composition): Fix previous change.
3012 2011-05-20 Glenn Morris <rgm@gnu.org>
3014 * lisp.mk: New file, split from Makefile.in.
3015 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3016 (shortlisp): Remove.
3017 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3019 2011-05-19 Glenn Morris <rgm@gnu.org>
3021 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3022 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3023 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3024 (lisp): Set the order to that of loadup.el.
3025 (shortlisp): Make it a copy of $lisp.
3026 (SOME_MACHINE_LISP): Remove.
3027 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3028 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3030 2011-05-18 Kenichi Handa <handa@m17n.org>
3032 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3033 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3034 (find_automatic_composition): Mostly rewrite for efficiency.
3036 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3038 * makefile.w32-in: Update dependencies.
3040 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3042 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3043 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3045 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3047 Fix some integer overflow issues, such as string length overflow.
3049 * insdel.c (count_size_as_multibyte): Check for string overflow.
3051 * character.c (lisp_string_width): Check for string overflow.
3052 Use EMACS_INT, not int, for string indexes and lengths; in
3053 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3054 the resulting string length overflows an EMACS_INT; instead,
3055 report a string overflow if no precision given. When checking for
3056 precision exhaustion, use a check that cannot possibly have
3057 integer overflow. (Bug#8675)
3058 * character.h (lisp_string_width): Adjust to new signature.
3060 * alloc.c (string_overflow): New function.
3061 (Fmake_string): Use it. This doesn't change behavior, but saves
3062 a few bytes and will simplify future changes.
3063 * character.c (string_escape_byte8): Likewise.
3064 * lisp.h (string_overflow): New decl.
3066 Fixups, following up to the user-interface timestamp change.
3067 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3068 for UI timestamps, instead of unsigned long.
3069 * msdos.c (mouse_get_pos): Likewise.
3070 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3071 * w32gui.h (Time): Define by including "systime.h" rather than by
3072 declaring it ourselves. (Bug#8664)
3074 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3075 * image.c (clear_image_cache): Likewise.
3077 * term.c (term_mouse_position): Don't assume time_t wraparound.
3079 Be more systematic about user-interface timestamps.
3080 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3081 and sometimes 'EMACS_UINT', to represent these timestamps.
3082 This change causes it to use 'Time' uniformly, as that's what X uses.
3083 This makes the code easier to follow, and makes it easier to catch
3084 integer overflow bugs such as Bug#8664.
3085 * frame.c (Fmouse_position, Fmouse_pixel_position):
3086 Use Time, not unsigned long, for user-interface timestamps.
3087 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3088 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3089 * keyboard.h (last_event_timestamp): Likewise.
3090 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3091 * menu.h (xmenu_show): Likewise.
3092 * term.c (term_mouse_position): Likewise.
3093 * termhooks.h (struct input_event.timestamp): Likewise.
3094 (struct terminal.mouse_position_hook): Likewise.
3095 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3096 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3097 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3098 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3100 * menu.h, termhooks.h: Include "systime.h", for Time.
3102 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3103 Don't assume that the difference between two unsigned long values
3104 can fit into an integer. At this point, we know button_down_time
3105 <= event->timestamp, so the difference must be nonnegative, so
3106 there's no need to cast the result if double-click-time is
3107 nonnegative, as it should be; check that it's nonnegative, just in
3108 case. This bug is triggered when events are more than 2**31 ms
3109 apart (about 25 days). (Bug#8664)
3111 * xselect.c (last_event_timestamp): Remove duplicate decl.
3112 (x_own_selection): Remove needless cast to unsigned long.
3114 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3115 that always fit in int. Use a sentinel instead of a counter, to
3116 avoid a temp and to allay GCC's concerns about possible int overflow.
3117 * frame.h (struct frame): Use int for menu_bar_items_used
3118 instead of EMACS_INT, since it always fits in int.
3120 * menu.c (grow_menu_items): Check for int overflow.
3122 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3124 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3125 Before, the code was not consistent. These values cannot exceed
3126 2**31 - 1 so there's no need to make them unsigned.
3127 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3128 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3129 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3131 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3133 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3134 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3135 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3136 presumably because the widths might not match.
3138 * window.c (size_window): Avoid needless test at loop start.
3140 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3142 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3144 2011-05-12 Drew Adams <drew.adams@oracle.com>
3146 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3148 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3150 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3151 `width' to `bar_area_x' and `bar_area_width', respectively.
3152 (x_scroll_run): Take account of fringe background extension.
3154 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3155 Rename local vars `left' and `width' to `bar_area_x' and
3156 `bar_area_width', respectively.
3157 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3158 background extension.
3160 2011-05-10 Jim Meyering <meyering@redhat.com>
3162 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3164 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3166 * image.c (Finit_image_library): Return t for built-in image types,
3167 like pbm and xbm. (Bug#8640)
3169 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3171 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3173 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3175 * w32console.c (Fset_screen_color): Doc fix.
3176 (Fget_screen_color): New function.
3177 (syms_of_ntterm): Defsubr it.
3179 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3180 unlink the temporary file if Fcall_process didn't create it in the
3182 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3183 child process will be redirected to a file specified with `:file'.
3184 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3185 cue to call_process_cleanup not to close that handle.
3187 2011-05-07 Ben Key <bkey76@gmail.com>
3189 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3190 one of two shell specific rules, either bootstrap-temacs-CMD or
3191 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3192 to the previous implementation of the bootstrap-temacs rule.
3193 The bootstrap-temacs-CMD rule is similar to the previous
3194 implementation of the bootstrap-temacs rule except that it
3195 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3198 These changes, along with some changes to nt/configure.bat,
3199 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3200 earlier fix to add support for --cflags and --ldflags options
3201 that include quotes so that it works whether make uses cmd or
3204 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3206 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3207 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3209 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3210 a string. Handle both cases.
3211 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3212 (Fdbus_register_method): Use Qinvalid_function.
3214 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3216 * makefile.w32-in: Update dependencies.
3217 (LISP_H): Add inttypes.h and stdin.h.
3218 (PROCESS_H): Add unistd.h.
3220 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3222 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3223 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3225 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3227 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3229 * term.c (vfatal): Remove stray call to va_end.
3230 It's not needed and the C Standard doesn't allow it here anyway.
3232 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3233 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3235 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3238 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3240 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3242 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3244 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3246 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3248 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3249 * charset.c (Fdefine_charset_internal): Don't initialize
3250 charset.code_space[15]. The value was garbage, on hosts with
3251 32-bit int (Bug#8600).
3253 * lread.c (read_integer): Be more consistent with string-to-number.
3254 Use string_to_number to do the actual conversion; this avoids
3255 rounding errors and fixes some other screwups. Without this fix,
3256 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3257 (digit_to_number): Move earlier, for benefit of read_integer.
3258 Return -1 if the digit is out of range for the base, -2 if it is
3259 not a digit in any supported base. (Bug#8602)
3261 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3263 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3264 to match comment at start of function. This also removes a
3265 GCC warning about overflow in a 32+64-bit port.
3267 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3269 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3270 Reported by Stefan Monnier in
3271 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3272 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3273 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3275 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3276 (EMACS_UINTPTR): Likewise, with uintptr_t.
3278 * lisp.h: Prefer 64-bit EMACS_INT if available.
3279 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3280 on 32-bit hosts that have 64-bit int, so that they can access
3282 However, temporarily disable this change unless the temporary
3283 symbol WIDE_EMACS_INT is defined.
3285 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3287 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3288 This removes an assumption that EMACS_INT and long are the same
3289 width as pointers. The assumption is true for Emacs porting targets
3290 now, but we want to make other targets possible.
3291 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3292 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3293 In the rest of the code, change types of integers that hold casted
3294 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3295 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3296 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3297 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3298 No need to cast type when ORing.
3299 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3300 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3301 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3302 assume EMACS_INT is the same width as char *.
3303 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3304 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3305 Remove no-longer-needed casts.
3306 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3307 (xg_tool_bar_help_callback, xg_make_tool_item):
3308 Use EMACS_INTPTR to hold an integer
3309 that will be cast to void *; this can avoid a GCC warning
3310 if EMACS_INT is not the same width as void *.
3311 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3312 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3313 (current_message_1, set_message_1):
3314 Use a local to convert to proper width without a cast.
3315 * xmenu.c (dialog_selection_callback): Likewise.
3317 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3318 Also, don't assume VALBITS / RAND_BITS is less than 5,
3319 and don't rely on undefined behavior when shifting a 1 left into
3321 * lisp.h (get_random): Change signature to match.
3323 * lread.c (hash_string): Use size_t, not int, for hash computation.
3324 Normally we prefer signed values; but hashing is special, because
3325 it's better to use unsigned division on hash table sizes so that
3326 the remainder is nonnegative. Also, size_t is the natural width
3327 for hashing into memory. The previous code used 'int', which doesn't
3328 retain enough info to hash well into very large tables.
3329 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3331 * dbusbind.c: Don't possibly lose pointer info when converting.
3332 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3333 Use XPNTR rather than XHASH, so that the high-order bits of
3334 the pointer aren't lost when converting through void *.
3336 * eval.c (Fautoload): Don't double-shift a pointer.
3338 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3340 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3342 * gnutls.c (DEF_GNUTLS_FN):
3343 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3345 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3347 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3350 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3352 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3353 New version that can reserve upto 2GB of heap space.
3355 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3357 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3359 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3361 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3362 `gnutls_certificate_set_x509_key_file'.
3364 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3366 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3367 Update dependencies.
3369 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3371 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3372 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3373 Remove unused parameter `fildes'.
3374 * process.c (read_process_output, send_process): Don't pass it.
3376 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3378 Fix previous change: the library cache is defined in w32.c.
3379 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3380 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3382 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3384 Implement dynamic loading of GnuTLS on Windows.
3386 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3387 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3388 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3391 * gnutls.c (Qgnutls_dll): Define.
3392 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3393 (gnutls_*): Declare function pointers.
3394 (init_gnutls_functions): New function to initialize function pointers.
3395 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3396 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3397 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3398 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3399 (emacs_gnutls_write, emacs_gnutls_read)
3400 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3401 (Fgnutls_available_p): New function.
3402 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3403 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3404 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3406 * image.c: Include w32.h.
3407 (Vimage_type_cache): Delete.
3408 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3409 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3410 (w32_delayed_load): Move to w32.c.
3412 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3414 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3415 (w32_delayed_load): Move from image.c. When loading a library, record
3416 its filename in the :loaded-from property of the library id.
3417 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3418 Initialize and staticpro them.
3419 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3421 * process.c: Include lisp.h before w32.h, not after.
3422 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3423 instead of gnutls_record_check_pending.
3425 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3427 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3429 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3430 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3433 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3435 * xterm.c (x_set_frame_alpha): Do not set property on anything
3436 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3438 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3440 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3442 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3444 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3445 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3446 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3447 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3448 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3449 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3450 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3451 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3452 (Qgnutls_bootprop_callbacks_verify): Make static.
3454 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3456 * callproc.c: Indentation fixup.
3458 * sysdep.c (wait_for_termination_1): Make static.
3459 (wait_for_termination, interruptible_wait_for_termination):
3460 Move after wait_for_termination_1.
3462 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3464 * sysdep.c (interruptible_wait_for_termination): New function
3465 which is like wait_for_termination, but allows keyboard
3468 * callproc.c (Fcall_process): Add (:file "file") as an option for
3470 (Fcall_process_region): Ditto.
3472 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3474 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3475 rather than `XVECTOR (FOO)->size'.
3477 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3478 inttypes.h, as a gnulib replacement is used if it not available in
3481 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3483 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3484 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3485 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3487 * coding.c (coding_alloc_by_realloc): Error out if destination
3488 will grow beyond MOST_POSITIVE_FIXNUM.
3489 (decode_coding_emacs_mule): Abort if there isn't enough place in
3490 charbuf for the composition carryover bytes. Reserve an extra
3491 space for up to 2 characters produced in a loop.
3492 (decode_coding_iso_2022): Abort if there isn't enough place in
3493 charbuf for the composition carryover bytes.
3495 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3497 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3498 aborting when %lld or %lll format is passed.
3499 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3500 %llo or %llx format is passed. (Bug#8545)
3502 * window.c (window_scroll_line_based): Use a marker instead of
3503 simple variables to record original value of point. (Bug#7952)
3505 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3506 produced by %s or %c overflows available buffer space. (Bug#8545)
3508 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3510 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3511 (SIZE_MAX): Move defn after all includes, as they might #define it.
3513 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3515 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3517 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3519 * keyboard.c (Qdelayed_warnings_hook): Define.
3520 (command_loop_1): Run `delayed-warnings-hook'
3521 if Vdelayed_warnings_list is non-nil.
3522 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3523 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3525 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3527 * doprnt.c (doprnt): Don't return value smaller than the buffer
3528 size if the message was truncated. (Bug#8545).
3530 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3532 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3533 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3535 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3537 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3539 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3541 * makefile.w32-in: Update dependencies.
3543 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3545 Improve `doprnt' and its usage. (Bug#8545)
3546 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3547 `format_end'. Remove support for %l as a conversion specifier.
3548 Don't use xrealloc. Improve diagnostics when the %l size modifier
3549 is used. Update the commentary.
3551 * eval.c (verror): Simplify calculation of size_t.
3553 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3556 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3558 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3561 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3563 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3564 This makes this file independent of the recent pseudovector change.
3566 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3568 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3570 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3571 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3572 Remove unused local.
3573 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3575 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3576 GCC 4.6.0 optimizes based on type-based alias analysis.
3577 For example, if b is of type struct buffer * and v of type struct
3578 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3579 != &v->size, and therefore "v->size = 1; b->size = 2; return
3580 v->size;" must therefore return 1. This assumption is incorrect
3581 for Emacs, since it type-puns struct Lisp_Vector * with many other
3582 types. To fix this problem, this patch adds a new type struct
3583 vectorlike_header that documents the constraints on layout of vectors
3584 and pseudovectors, and helps optimizing compilers not get fooled
3585 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3586 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3587 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3589 (XSETPVECTYPE): Rewrite in terms of new macro.
3590 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3591 This is a bit clearer, and further avoids the possibility of
3592 undesirable aliasing.
3593 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3594 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3595 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3596 since Lisp_Subr is a special case (no "next" field).
3597 (ASIZE): Now uses header.size rather than size.
3598 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3599 to avoid the hassle of writing XVECTOR (foo)->header.size.
3600 (struct vectorlike_header): New type.
3601 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3602 object, to help avoid aliasing.
3603 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3604 (SUBRP): Likewise, since Lisp_Subr is a special case.
3605 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3606 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3607 (struct Lisp_Hash_Table): Combine first two members into a single
3608 struct vectorlike_header member. All uses of "size" and "next" members
3609 changed to be "header.size" and "header.next".
3610 * buffer.h (struct buffer): Likewise.
3611 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3612 * frame.h (struct frame): Likewise.
3613 * process.h (struct Lisp_Process): Likewise.
3614 * termhooks.h (struct terminal): Likewise.
3615 * window.c (struct save_window_data, struct saved_window): Likewise.
3616 * window.h (struct window): Likewise.
3617 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3618 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3619 * buffer.c (init_buffer_once): Likewise.
3620 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3622 * process.c (Fformat_network_address): Use local var for size,
3625 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3627 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3628 * data.c (atof): Remove decl; no longer used or needed.
3629 (digit_to_number): Move to lread.c.
3630 (Fstring_to_number): Use new string_to_number function, to be
3631 consistent with how the Lisp reader treats infinities and NaNs.
3632 Do not assume that floating-point numbers represent EMACS_INT
3633 without losing information; this is not true on most 64-bit hosts.
3634 Avoid double-rounding errors, by insisting on integers when
3635 parsing non-base-10 numbers, as the documentation specifies.
3636 * lisp.h (string_to_number): New decl, replacing ...
3637 (isfloat_string): Remove.
3638 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3639 (read1): Do not accept +. and -. as integers; this
3640 appears to have been a coding error. Similarly, do not accept
3641 strings like +-1e0 as floating point numbers. Do not report
3642 overflow for integer overflows unless the base is not 10 which
3643 means we have no simple and reliable way to continue.
3644 Break out the floating-point parsing into a new
3645 function string_to_number, so that Fstring_to_number parses
3646 floating point numbers consistently with the Lisp reader.
3647 (digit_to_number): Move here from data.c. Make it static inline.
3648 (E_CHAR, EXP_INT): Remove, replacing with ...
3649 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3650 (string_to_number): New function, replacing isfloat_string.
3651 This function checks for valid syntax and produces the resulting
3652 Lisp float number too. Rework it so that string-to-number
3653 no longer mishandles examples like "1.0e+". Use strtoumax,
3654 so that overflow for non-base-10 numbers is reported only when
3655 there's no portable and simple way to convert to floating point.
3657 * textprop.c (set_text_properties_1): Rewrite for clarity,
3658 and to avoid GCC warning about integer overflow.
3660 * intervals.h (struct interval): Use EMACS_INT for members
3661 where EMACS_UINT might cause problems. See
3662 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3663 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3664 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3666 (offset_intervals): Tell GCC not to worry about length overflow
3667 when negating a negative length.
3669 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3670 (overrun_check_free): Likewise.
3672 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3673 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3676 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3677 (gnutls_make_error): Rename local to avoid shadowing.
3678 (gnutls_emacs_global_deinit): ifdef out; not used.
3679 (Fgnutls_boot): Use const for pointer to readonly storage.
3680 Comment out unused local. Fix pointer signedness problems.
3682 * lread.c (openp): Don't stuff size_t into an 'int'.
3683 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3684 about possible signed overflow.
3686 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3687 (GDK_KEY_g): Don't define if already defined.
3688 (xg_prepare_tooltip): Avoid pointer signedness problem.
3689 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3691 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3692 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3694 * xfns.c (Fx_window_property): Simplify a bit,
3695 to make a bit faster and to avoid GCC 4.6.0 warning.
3696 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3698 * fns.c (internal_equal): Don't assume size_t fits in int.
3700 * alloc.c (compact_small_strings): Tighten assertion a little.
3702 Replace pEd with more-general pI, and fix some printf arg casts.
3703 * lisp.h (pI): New macro, generalizing old pEd macro to other
3704 conversion specifiers. For example, use "...%"pI"d..." rather
3705 than "...%"pEd"...".
3706 (pEd): Remove. All uses replaced with similar uses of pI.
3707 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3708 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3709 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3710 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3711 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3712 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3713 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3715 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3716 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3717 * print.c (safe_debug_print, print_object): Likewise.
3718 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3720 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3721 avoiding the 0 flag, which is not portable.
3722 * process.c (Fmake_network_process): Use pI to avoid cast.
3723 * region-cache.c (pp_cache): Likewise.
3724 * xdisp.c (decode_mode_spec): Likewise.
3725 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3726 behavior on 64-bit hosts with printf arg.
3727 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3728 (x_stop_queuing_selection_requests): Likewise.
3729 (x_get_window_property): Don't truncate byte count to an 'int'
3732 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3733 here, since it parses constructs like leading '-' and spaces,
3734 which are not wanted; and it overflows with large numbers.
3735 Instead, simply match F[0-9]+, which is what is wanted anyway.
3737 * alloc.c: Remove unportable assumptions about struct layout.
3738 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3739 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3740 (allocate_vectorlike, make_pure_vector): Use the new macros,
3741 plus offsetof, to remove unportable assumptions about struct layout.
3742 These assumptions hold on all porting targets that I know of, but
3743 they are not guaranteed, they're easy to remove, and removing them
3744 makes further changes easier.
3746 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3747 This doesn't fix a bug but makes the code clearer.
3748 (string_overrun_cookie): Now const. Use initializers that
3749 don't formally overflow signed char, to avoid warnings.
3750 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3751 can cause Emacs to crash when string overrun checking is enabled.
3752 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3753 multiple of sizeof (EMACS_INT); it need not be, if
3754 alignof(EMACS_INT) < sizeof (EMACS_INT).
3755 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3757 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3759 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3761 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3763 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3764 supposed to be handshaking. (Bug#8556)
3765 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3767 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3769 * lisp.h (Qdebug): List symbol.
3770 * eval.c (Qdebug): Restore global linkage.
3771 * keyboard.c (debug-on-event): New variable.
3772 (handle_user_signal): Break into debugger when debug-on-event
3773 matches the current signal symbol.
3775 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3777 * alloc.c (check_sblock, check_string_bytes)
3778 (check_string_free_list): Convert to standard C.
3780 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3782 * w32.c (emacs_gnutls_push): Fix typo.
3784 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3786 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3787 "cast to pointer from integer of different size".
3789 Improve doprnt and its use in verror. (Bug#8545)
3790 * doprnt.c (doprnt): Document the set of format control sequences
3791 supported by the function. Use SAFE_ALLOCA instead of always
3794 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3795 is one byte too soon. Don't use xrealloc; instead xfree and
3798 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3800 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3803 * gnutls.c: Renamed global_initialized to
3804 gnutls_global_initialized. Added internals for the
3805 :verify-hostname-error, :verify-error, and :verify-flags
3806 parameters of `gnutls-boot' and documented those parameters in the
3807 docstring. Start callback support.
3808 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3809 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3810 on error. Return error code.
3811 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3812 (emacs_gnutls_read): Likewise.
3813 (Fgnutls_boot): Return handshake error code.
3814 (emacs_gnutls_handle_error): New function.
3815 (wsaerror_to_errno): Likewise.
3817 * w32.h (emacs_gnutls_pull): Add prototype.
3818 (emacs_gnutls_push): Likewise.
3820 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3821 (emacs_gnutls_push): Likewise.
3823 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3825 * process.c (wait_reading_process_output): Check if GnuTLS
3826 buffered some data internally if no FDs are set for TLS
3829 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3830 (LIBS): Link to USER_LIBS.
3831 ($(BLD)/gnutls.$(0)): New target.
3833 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3835 * xdisp.c (handle_single_display_spec): Rename the
3836 display_replaced_before_p argument into display_replaced_p, to
3837 make it consistent with the commentary. Fix typos in the
3840 * textprop.c (syms_of_textprop): Remove dead code.
3841 (copy_text_properties): Delete obsolete commentary about an
3842 interface that was deleted long ago. Fix typos in the description
3845 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3846 to changes in oldXMenu/XMenu.h from 2011-04-16.
3847 <menu_help_message, prev_menu_help_message>: Constify.
3848 (IT_menu_make_room): menu->help_text is now `const char **';
3851 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3852 to changes in oldXMenu/XMenu.h from 2011-04-16.
3853 (struct XMenu): Declare `help_text' `const char **'.
3855 * xfaces.c <Qunspecified>: Make extern again.
3857 * syntax.c: Include sys/types.h before including regex.h, as
3860 * doc.c (get_doc_string): Improve the format passed to `error'.
3862 * doprnt.c (doprnt): Improve commentary.
3864 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3866 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3869 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3870 changes in globals.h immediately force recompilation.
3871 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3872 $(CURDIR)/s/ms-w32.h.
3873 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3875 * character.c (Fchar_direction): Function deleted.
3876 (syms_of_character): Don't defsubr it.
3877 <char-direction-table>: Deleted.
3879 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3881 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3882 * doprnt.c: Include limits.h.
3883 (SIZE_MAX): New macro.
3884 (doprnt): Return a size_t value. 2nd arg is now size_t.
3885 Many local variables are now size_t instead of int or unsigned.
3886 Improve overflow protection. Support `l' modifier for integer
3887 conversions. Support %l conversion. Don't assume an EMACS_INT
3888 argument for integer conversions and for %c.
3890 * lisp.h (doprnt): Restore prototype.
3892 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3895 * Makefile.in (base_obj): Add back doprnt.o.
3897 * deps.mk (doprnt.o): Add back prerequisites.
3898 (callint.o): Depend on character.h.
3900 * eval.c (internal_lisp_condition_case): Include the handler
3901 representation in the error message.
3902 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3903 when breaking from the loop.
3905 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3907 * callint.c (Fcall_interactively): When displaying error message
3908 about invalid control letter, pass the character's codepoint, not
3909 a pointer to its multibyte form. Improve display of the character
3910 in octal and display also its hex code.
3912 * character.c (char_string): Use %x to display the (unsigned)
3913 codepoint of an invalid character, to avoid displaying a bogus
3916 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3917 `error', not SYMBOL_NAME itself.
3919 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3920 character arguments to `error'.
3922 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3923 to `error' in error message about FINAL_CHAR argument. Make sure
3924 FINAL_CHAR is a character, and use %c when it is passed as
3925 argument to `error'.
3927 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3929 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3931 * w32.c: Include <time.h>.
3932 (sys_localtime): New function.
3934 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3936 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3938 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3940 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3942 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3945 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3947 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3948 gl_state.e_property when gl_state.object is Qt.
3950 * insdel.c (make_gap_larger): Remove limitation of buffer size
3953 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3955 * xdisp.c (lookup_glyphless_char_display)
3956 (produce_glyphless_glyph): Handle cons cell entry in
3957 glyphless-char-display.
3958 (Vglyphless_char_display): Document it.
3960 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3961 glyphless-char-display.
3963 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3965 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3967 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3969 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3970 definition for no-X builds.
3972 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3974 Static checks with GCC 4.6.0 and non-default toolkits.
3976 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3978 * process.c (keyboard_bit_set): Define only if SIGIO.
3979 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3980 (send_process): Repair possible setjmp clobbering.
3982 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3984 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3986 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3988 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3989 Define only if needed.
3991 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3992 by pacifying GCC about it. Maybe it's time to retire it?
3993 * xfaces.c (USG, __TIMEVAL__): Likewise.
3995 * dispextern.h (struct redisplay_interface): Rename param
3997 * termhooks.h (struct terminal): Likewise.
3998 * xterm.c (xembed_send_message): Likewise.
4000 * insdel.c (make_gap_smaller): Define only if
4001 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4003 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4006 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4007 so that we aren't warned about unused symbols.
4009 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4011 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4013 * xfns.c (x_real_positions): Mark locals as initialized.
4015 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4017 * xterm.c: Fix problems found by static analysis with other toolkits.
4018 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4019 (x_dispatch_event): Declare static if USE_GTK, and
4020 define if USE_GTK || USE_X_TOOLKIT.
4021 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4022 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4023 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4024 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4026 * xmenu.c (menu_help_callback): Pointer type fixes.
4027 Use const pointers when pointing at readonly data. Avoid pointer
4029 (FALSE): Remove unused macro.
4030 (update_frame_menubar): Remove unused decl.
4032 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4034 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4035 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4036 (single_menu_item): Rename local to avoid shadowing.
4038 * keyboard.c (make_lispy_event): Remove unused local var.
4040 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4041 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4043 * bitmaps: Change bitmaps from unsigned char back to the X11
4044 compatible char. Avoid the old compiler warnings about
4045 out-of-range initializers by using, for example, '\xab' rather
4048 * xgselect.c (xgselect_initialize): Check vs interface
4049 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4051 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4053 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4054 to read-only memory.
4056 * fns.c (vector): Remove; this old hack is no longer needed.
4058 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4060 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4062 * xrdb.c (x_load_resources): Omit unused local.
4064 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4065 (x_window): Rename locals to avoid shadowing.
4066 (USG): Use the kludged USG macro, to pacify gcc.
4068 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4069 (x_term_init): Remove local to avoid shadowing.
4071 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4073 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4074 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4076 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4078 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4080 Fix regex.c, syntax.c and friends for buffers > 2GB.
4081 * syntax.h (struct gl_state_s): Declare character position members
4084 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4086 * textprop.c (verify_interval_modification, interval_of):
4087 Declare arguments EMACS_INT.
4089 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4092 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4094 * indent.c (Fvertical_motion): Local variable it_start is now
4097 * regex.c (re_match, re_match_2, re_match_2_internal)
4098 (bcmp_translate, regcomp, regexec, print_double_string)
4099 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4100 (re_compile_pattern, re_exec): Declare arguments and local
4101 variables `size_t' and `ssize_t' and return values `regoff_t', as
4103 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4104 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4105 <compile_stack_type>: `size' and `avail' are now `size_t'.
4107 * regex.h <regoff_t>: Use ssize_t, not int.
4108 (re_search, re_search_2, re_match, re_match_2): Arguments that
4109 specify buffer/string position and length are now ssize_t and
4110 size_t. Return type is regoff_t.
4112 2011-04-16 Ben Key <bkey76@gmail.com>
4114 * nsfont.m: Fixed bugs in ns_get_family and
4115 ns_descriptor_to_entity that were caused by using free to
4116 deallocate memory blocks that were allocated by xmalloc (via
4117 xstrdup). This caused Emacs to crash when compiled with
4118 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4119 --enable-checking=xmallocoverrun). xfree is now used to
4120 deallocate these memory blocks.
4122 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4124 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4126 emacs_write: Accept and return EMACS_INT for sizes.
4127 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4129 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4130 Accept and return EMACS_INT.
4131 (emacs_gnutls_write): Return the number of bytes written on
4133 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4134 (emacs_read, emacs_write): Remove check for negative size, as the
4135 Emacs source code has been audited now.
4136 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4137 (emacs_read, emacs_write): Use it.
4138 * process.c (send_process): Adjust to the new signatures of
4139 emacs_write and emacs_gnutls_write. Do not attempt to store
4140 a byte offset into an 'int'; it might overflow.
4141 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4143 * sound.c: Don't assume sizes fit in 'int'.
4144 (struct sound_device.period_size, alsa_period_size):
4145 Return EMACS_INT, not int.
4146 (struct sound_device.write, vox_write, alsa_write):
4147 Accept EMACS_INT, not int.
4148 (wav_play, au_play): Use EMACS_INT to store sizes and to
4149 record read return values.
4151 2011-04-15 Ben Key <bkey76@gmail.com>
4153 * keyboard.c (Qundefined): Don't declare static since it is used
4155 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4156 static since they are used in nsfont.m.
4158 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4160 * process.c (Qprocessp): Don't declare static.
4161 * lisp.h (Qprocessp): Declare again.
4163 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4165 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4167 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4169 Improve C-level modularity by making more things 'static'.
4171 Don't publish debugger-only interfaces to other modules.
4172 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4173 (verify_bytepos, count_markers): Move decls to the only modules
4175 * region-cache.h (pp_cache): Likewise.
4176 * window.h (check_all_windows): Likewise.
4177 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4179 * sysdep.c (croak): Now static, if
4180 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4181 * syssignal.h (croak): Declare only if not static.
4183 * alloc.c (refill_memory_reserve): Now static if
4184 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4185 * lisp.h (refill_memory_reserve): Declare only if not static.
4187 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4188 Define only if USE_LUCID.
4190 * xrdb.c (x_customization_string, x_rm_string): Now static.
4192 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4193 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4195 * xdisp.c (draw_row_with_mouse_face): Now static.
4196 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4198 * window.h (check_all_windows): Mark externally visible.
4200 * window.c (window_deletion_count): Now static.
4202 * undo.c: Make symbols static if they're not exported.
4203 (last_undo_buffer, last_boundary_position, pending_boundary):
4206 * textprop.c (interval_insert_behind_hooks): Now static.
4207 (interval_insert_in_front_hooks): Likewise.
4209 * term.c: Make symbols static if they're not exported.
4210 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4211 (max_frame_lines, tty_set_terminal_modes):
4212 (tty_reset_terminal_modes, tty_turn_off_highlight):
4213 (get_tty_terminal): Now static.
4214 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4215 * termhooks.h (term_mouse_moveto): Do not declare if
4217 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4218 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4220 * sysdep.c: Make symbols static if they're not exported.
4221 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4223 (sigprocmask_set, full_mask): Remove; unused.
4224 (wait_debugging): Mark as visible.
4225 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4226 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4228 * syntax.c (syntax_temp): Define only if !__GNUC__.
4230 * sound.c (current_sound_device, current_sound): Now static.
4232 * search.c (searchbufs, searchbuf_head): Now static.
4234 * scroll.c (scroll_cost): Remove; unused.
4235 * dispextern.h (scroll_cost): Remove decl.
4237 * region-cache.h (pp_cache): Mark as externally visible.
4239 * process.c: Make symbols static if they're not exported.
4240 (process_tick, update_tick, create_process, chan_process):
4241 (Vprocess_alist, proc_buffered_char, datagram_access):
4242 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4243 (deactivate_process): Mark defn as static, as well as decl.
4244 * lisp.h (create_process): Remove decl.
4245 * process.h (chan_process, Vprocess_alist): Remove decls.
4247 * print.c: Make symbols static if they're not exported.
4248 (print_depth, new_backquote_output, being_printed, print_buffer):
4249 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4250 (print_interval, print_number_index, initial_stderr_stream):
4252 * lisp.h (Fprinc): Remove decl.
4253 (debug_output_compilation_hack): Mark as externally visible.
4255 * sysdep.c (croak): Move decl from here to syssignal.h.
4256 * syssignal.h (croak): Put it here, so the API can be checked when
4257 'croak' is called from dissociate_if_controlling_tty.
4259 * minibuf.c: Make symbols static if they're not exported.
4260 (minibuf_save_list, choose_minibuf_frame): Now static.
4261 * lisp.h (choose_minibuf_frame): Remove decl.
4263 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4265 * lread.c: Make symbols static if they're not exported.
4266 (read_objects, initial_obarray, oblookup_last_bucket_number):
4268 (make_symbol): Remove; unused.
4269 * lisp.h (initial_obarray, make_symbol): Remove decls.
4271 * keyboard.c: Make symbols static if they're not exported.
4272 (single_kboard, recent_keys_index, total_keys, recent_keys):
4273 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4274 (this_single_command_key_start, echoing, last_auto_save):
4275 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4276 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4277 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4278 (Vlispy_mouse_stem, double_click_count):
4280 (force_auto_save_soon): Define only if SIGDANGER.
4281 (ignore_mouse_drag_p): Now static if
4282 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4283 (print_help): Remove; unused.
4284 (stop_character, last_timer_event): Mark as externally visible.
4285 * keyboard.h (ignore_mouse_drag_p): Declare only if
4286 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4287 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4288 * lisp.h (echoing): Remove decl.
4289 (force_auto_save_soon): Declare only if SIGDANGER.
4290 * xdisp.c (redisplay_window): Simplify code, to make it more
4291 obvious that ignore_mouse_drag_p is not accessed if !defined
4292 USE_GTK && !defined HAVE_NS.
4294 * intervals.c: Make symbols static if they're not exported.
4295 (merge_properties_sticky, merge_interval_right, delete_interval):
4297 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4299 * insdel.c: Make symbols static if they're not exported.
4300 However, leave prepare_to_modify_buffer alone. It's never
4301 called from outside this function, but that appears to be a bug.
4302 (combine_after_change_list, combine_after_change_buffer):
4303 (adjust_after_replace, signal_before_change): Now static.
4304 (adjust_after_replace_noundo): Remove; unused.
4305 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4306 (signal_before_change): Remove decls.
4308 * indent.c (val_compute_motion, val_vmotion): Now static.
4310 * image.c: Make symbols static if they're not exported.
4311 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4313 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4314 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4316 * fringe.c (standard_bitmaps): Now static.
4317 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4319 * frame.c: Make symbols static if they're not exported.
4320 (x_report_frame_params, make_terminal_frame): Now static.
4321 (get_frame_param): Now static, unless HAVE_NS.
4322 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4323 (x_get_resource_string): Remove; not used.
4324 * frame.h (make_terminal_frame, x_report_frame_params):
4325 (x_get_resource_string); Remove decls.
4326 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4327 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4329 * font.c, fontset.c: Make symbols static if they're not exported.
4330 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4331 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4332 * font.c (font_close_object): Now static.
4333 * font.h (font_close_object): Remove.
4334 * fontset.c (FONTSET_OBJLIST): Remove.
4335 (free_realized_fontset) #if-0 the body, which does nothing.
4336 (face_suitable_for_char_p): #if-0, as it's never called.
4337 * fontset.h (face_suitable_for_char_p): Remove decl.
4338 * xfaces.c (face_at_string_position):
4339 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4340 since 0 is always ASCII.
4342 * fns.c (weak_hash_tables): Now static.
4344 * fileio.c: Make symbols static if they're not exported.
4345 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4346 (Vwrite_region_annotation_buffers): Now static.
4348 * eval.c: Make symbols static if they're not exported.
4349 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4350 * lisp.h (backtrace_list): Remove decl.
4352 * emacs.c: Make symbols static if they're not exported.
4353 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4354 (fatal_error_code, fatal_error_signal_hook, standard_args):
4356 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4357 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4358 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4359 * lisp.h (fatal_error_signal_hook): Remove decl.
4360 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4362 * editfns.c: Move a (normally-unused) function to its only use.
4363 * editfns.c, lisp.h (get_operating_system_release): Remove.
4364 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4365 worth the hassle of breaking this out.
4367 * xterm.c: Make symbols static if they're not exported.
4368 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4369 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4370 (x_destroy_window, x_delete_display):
4372 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4373 (x_mouse_leave): Remove; unused.
4374 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4375 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4376 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4378 (x_mouse_leave): Declare only if WINDOWSNT.
4379 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4380 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4383 * ftxfont.c: Make symbols static if they're not exported.
4384 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4386 * font.h (ftxfont_driver): Likewise.
4388 * xfns.c: Make symbols static if they're not exported.
4389 (x_last_font_name, x_display_info_for_name):
4390 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4391 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4392 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4393 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4394 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4395 (last_show_tip_args): Now static.
4396 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4397 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4398 (x_screen_planes): Remove; unused.
4399 * dispextern.h (x_screen_planes): Remove decl.
4401 * dispnew.c: Make symbols static if they're not exported.
4402 * dispextern.h (redraw_garbaged_frames, scrolling):
4403 (increment_row_positions): Remove.
4404 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4405 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4407 (redraw_garbaged_frames): Remove; unused.
4409 * xfaces.c: Make symbols static if they're not exported.
4410 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4412 * xterm.h (defined_color): Remove decls.
4413 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4414 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4415 (menu_face_changed_default, defined_color, free_realized_face):
4416 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4417 (ascii_face_of_lisp_face): Remove; unused.
4419 * xdisp.c: Make symbols static if they're not exported.
4420 * dispextern.h (scratch_glyph_row, window_box_edges):
4421 (glyph_to_pixel_coords, set_cursor_from_row):
4422 (get_next_display_element, set_iterator_to_next):
4423 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4424 (show_mouse_face): Remove decls
4425 * frame.h (message_buf_print): Likewise.
4426 * lisp.h (pop_message, set_message, check_point_in_composition):
4428 * xterm.h (set_vertical_scroll_bar): Likewise.
4429 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4430 (message_buf_print, scratch_glyph_row, displayed_buffer):
4431 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4432 (get_next_display_element, show_mouse_face, window_box_edges):
4433 (frame_to_window_pixel_xy, check_point_in_composition):
4434 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4435 (glyph_to_pixel_coords): Remove; unused.
4437 * dired.c (file_name_completion): Now static.
4439 * dbusbind.c (xd_in_read_queued_messages): Now static.
4441 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4442 * data.c (circular_list_error): Remove.
4444 * commands.h (last_point_position, last_point_position_buffer):
4445 (last_point_position_window): Remove decls.
4446 * keyboard.c: Make these variables static.
4448 * coding.h (coding, code_convert_region, encode_coding_gap):
4450 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4451 (iso_code_class, detect_coding, code_convert_region): Now static.
4452 (encode_coding_gap): Remove; unused.
4454 * chartab.c (chartab_chars, chartab_bits): Now static.
4456 * charset.h (charset_iso_8859_1): Remove decl.
4457 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4460 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4461 * ccl.c (Vccl_program_table): Now static.
4462 (check_ccl_update): Remove; unused.
4464 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4465 * category.h: ... from here.
4466 * category.c (check_category_table, set_category_set): Now static.
4468 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4469 * lisp.h: Remove these decls.
4471 * buffer.c (buffer_count): Remove unused var.
4473 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4474 so that it's not optimized away.
4475 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4476 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4477 exported only to the debugger.
4479 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4480 * atimer.h (run_all_atimers): Remove; not exported.
4482 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4483 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4484 was inaccessible from Lisp.
4485 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4486 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4488 alloc.c: Import and export fewer symbols, and remove unused items.
4489 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4491 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4492 it's not optimized away by whole-program optimization.
4493 (message_enable_multibyte, free_misc): Remove.
4494 (catchlist, handlerlist, mark_backtrace):
4495 Declare only if BYTE_MARK_STACK.
4496 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4497 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4498 (message_enable_multibyte): Remove decl.
4499 (free_misc, interval_free_list, float_block, float_block_index):
4500 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4501 (cons_free_list, last_marked_index):
4503 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4504 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4505 (mark_backtrace): Define only if BYTE_MARK_STACK.
4506 * xdisp.c (message_enable_multibyte): Now static.
4508 Declare Lisp_Object Q* variables to be 'static' if not exported.
4509 This makes it easier for human readers (and static analyzers)
4510 to see whether these variables are used from other modules.
4511 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4512 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4513 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4514 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4515 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4516 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4517 * xmenu.c, xselect.c:
4518 Declare Q* vars static if they are not used in other modules.
4519 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4520 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4521 Remove decls of unexported vars.
4522 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4524 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4526 Make Emacs functions such as Fatom 'static' by default.
4527 This makes it easier for human readers (and static analyzers)
4528 to see whether these functions can be called from other modules.
4529 DEFUN now defines a static function. To make the function external
4530 so that it can be used in other C modules, use the new macro DEFUE.
4531 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4532 (Finit_image_library):
4533 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4534 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4535 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4536 Remove decls, since these functions are now static.
4537 (Funintern, Fget_internal_run_time): New decls, since these functions
4538 were already external.
4540 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4541 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4542 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4543 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4544 * keyboard.c, keymap.c, lread.c:
4545 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4546 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4547 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4548 Mark functions with DEFUE instead of DEFUN,
4549 if they are used in other modules.
4550 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4551 decls for now-static functions.
4552 * buffer.h (Fdelete_overlay): Remove decl.
4553 * callproc.c (Fgetenv_internal): Mark as internal.
4554 * composite.c (Fremove_list_of_text_properties): Remove decl.
4555 (Fcomposition_get_gstring): New forward static decl.
4556 * composite.h (Fcomposite_get_gstring): Remove decl.
4557 * dired.c (Ffile_attributes): New forward static decl.
4558 * doc.c (Fdocumntation_property): New forward static decl.
4559 * eval.c (Ffetch_bytecode): New forward static decl.
4560 (Funintern): Remove extern decl; now in .h file where it belongs.
4561 * fileio.c (Fmake_symbolic_link): New forward static decl.
4562 * image.c (Finit_image_library): New forward static decl.
4563 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4564 * intervals.h (Fprevious_property_change):
4565 (Fremove_list_of_text_properties): Remove decls.
4566 * keyboard.c (Fthis_command_keys): Remove decl.
4567 (Fcommand_execute): New forward static decl.
4568 * keymap.c (Flookup_key): New forward static decl.
4569 (Fcopy_keymap): Now static.
4570 * keymap.h (Flookup_key): Remove decl.
4571 * process.c (Fget_process): New forward static decl.
4572 (Fprocess_datagram_address): Mark as internal.
4573 * syntax.c (Fsyntax_table_p): New forward static decl.
4574 (skip_chars): Remove duplicate decl.
4575 * textprop.c (Fprevious_property_change): New forward static decl.
4576 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4578 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4579 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4581 * editfns.c (Fformat): Remove unreachable code.
4583 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4585 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4588 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4590 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4591 when at ZV. (Bug#8487)
4593 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4595 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4597 * keyboard.c (parse_tool_bar_item): Likewise.
4598 * sound.c (sound_cleanup, alsa_close): Likewise.
4599 * termcap.c (tgetent): Likewise.
4600 * xfns.c (x_default_font_parameter): Likewise.
4601 * xsettings.c (read_and_apply_settings): Likewise.
4603 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4604 (overrun_check_free): Protoize.
4606 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4608 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4609 since callers should never pass a negative size.
4610 Change the signature to match that of plain 'read' and 'write'; see
4611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4612 * lisp.h: Update prototypes of emacs_write and emacs_read.
4614 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4616 * xdisp.c (redisplay_window): Don't try to determine the character
4617 position of the scroll margin if the window start point w->startp
4618 is outside the buffer's accessible region. (Bug#8468)
4620 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4622 Fix write-region and its subroutines for buffers > 2GB.
4623 * fileio.c (a_write, e_write): Modify declaration of arguments and
4624 local variables to support buffers larger than 2GB.
4625 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4627 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4628 argument, local variables, and return value.
4630 * lisp.h: Update prototypes of emacs_write and emacs_read.
4632 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4634 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4636 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4638 Fix more problems found by GCC 4.6.0's static checks.
4640 * xdisp.c (vmessage): Use a better test for character truncation.
4642 * charset.c (load_charset_map): <, not <=, for optimization,
4643 and to avoid potential problems with integer overflow.
4644 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4645 * casetab.c (set_identity, shuffle): Likewise.
4646 * editfns.c (Fformat): Likewise.
4647 * syntax.c (skip_chars): Likewise.
4649 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4650 This also lets GCC 4.6.0 generate slightly better loop code.
4652 * callint.c (Fcall_interactively): <, not <=, for optimization.
4653 (Fcall_interactively): Count the number of arguments produced,
4654 not the number of arguments given. This is simpler and lets GCC
4655 4.6.0 generate slightly better code.
4657 * ftfont.c: Distingish more carefully between FcChar8 and char.
4658 The previous code passed unsigned char * to a functions like
4659 strlen and xstrcasecmp that expect char *, which does not
4660 conform to the C standard.
4661 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4662 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4663 char * when the C standard requires it.
4665 * keyboard.c (read_char): Remove unused var.
4667 * eval.c: Port to Windows vsnprintf (Bug#8435).
4669 (SIZE_MAX): Define if the headers do not.
4670 (verror): Do not give up if vsnprintf returns a negative count.
4671 Instead, grow the buffer. This ports to Windows vsnprintf, which
4672 does not conform to C99. Problem reported by Eli Zaretskii.
4673 Also, simplify the allocation scheme, by avoiding the need for
4674 calling realloc, and removing the ALLOCATED variable.
4676 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4678 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4679 But keep the doprint source code for now, as we might revamp it
4680 and use it again (Bug#8435).
4681 * lisp.h (doprnt): Remove.
4682 * Makefile.in (base_obj): Remove doprnt.o.
4683 * deps.mk (doprnt.o): Remove.
4685 error: Print 32- and 64-bit integers portably (Bug#8435).
4686 Without this change, on typical 64-bit hosts error ("...%d...", N)
4687 was used to print both 32- and 64-bit integers N, which relied on
4689 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4691 * lisp.h (error, verror): Mark as printf-like functions.
4692 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4693 Report overflow in size calculations when allocating printf buffer.
4694 Do not truncate output string at its first null byte.
4695 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4696 Truncate the output at a character boundary, since vsnprintf does not
4698 * charset.c (check_iso_charset_parameter): Convert internal
4699 character to string before calling 'error', since %c now has the
4701 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4702 overflow when computing char to be passed to 'error'. Do not
4703 pass Lisp_Object to 'error'; pass the integer instead.
4704 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4705 formatted with plain %d.
4707 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4709 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4711 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4713 * xterm.c (x_catch_errors): Remove duplicate declaration.
4715 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4717 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4719 2011-04-10 Jim Meyering <meyering@redhat.com>
4721 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4722 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4723 return ssize_t not "int", and use size_t as the buffer length.
4724 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4725 * gnutls.h: Update declarations.
4726 * process.c (read_process_output): Use ssize_t, to match.
4727 (send_process): Likewise.
4729 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4731 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4733 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4735 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4736 Use unsigned char, to match FcChar8 type definition.
4738 * xterm.c (handle_one_xevent):
4739 * xmenu.c (create_and_show_popup_menu):
4740 * xselect.c (x_decline_selection_request)
4741 (x_reply_selection_request): Avoid type-punned deref of X events.
4743 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4745 Fix some uses of `int' instead of EMACS_INT.
4746 * search.c (string_match_1, fast_string_match)
4747 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4748 (scan_buffer, find_next_newline_no_quit)
4749 (find_before_next_newline, search_command, Freplace_match)
4750 (Fmatch_data): Make some `int' variables be EMACS_INT.
4752 * xdisp.c (display_count_lines): 3rd argument and return value now
4753 EMACS_INT. All callers changed.
4754 (pint2hrstr): Last argument is now EMACS_INT.
4756 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4757 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4758 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4759 (decode_coding_utf_16, decode_coding_emacs_mule)
4760 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4761 (decode_coding_ccl, decode_coding_charset)
4762 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4763 (decode_coding_iso_2022, decode_coding_emacs_mule)
4764 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4765 <char_offset, last_offset>: Declare EMACS_INT.
4766 (encode_coding_utf_8, encode_coding_utf_16)
4767 (encode_coding_emacs_mule, encode_invocation_designation)
4768 (encode_designation_at_bol, encode_coding_iso_2022)
4769 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4770 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4772 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4773 (encode_invocation_designation): Last argument P_NCHARS is now
4775 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4776 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4778 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4781 * ccl.c (Fccl_execute_on_string): Declare some variables
4784 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4786 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4788 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4790 * process.c (Fformat_network_address): Doc fix.
4792 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4794 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4796 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4798 * keyboard.c (read_char): Call Lisp function help-form-show,
4799 instead of using internal_with_output_to_temp_buffer.
4800 (Qhelp_form_show): New var.
4801 (syms_of_keyboard): Use DEFSYM macro.
4803 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4805 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4807 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4809 * process.c (Flist_processes): Remove to Lisp.
4810 (list_processes_1): Delete.
4812 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4814 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4816 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4818 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4820 Fix more problems found by GCC 4.6.0's static checks.
4822 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4824 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4826 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4828 * xdisp.c (vmessage): Mark as a printf-like function.
4830 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4832 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4834 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4835 printf-like functions.
4836 (tiff_load): Add casts to remove these marks before passing them
4837 to system-supplied API.
4839 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4841 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4842 This avoids several warnings with gcc -Wstrict-overflow.
4843 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4844 directly, rather than having caller test rule sign. This avoids
4845 some unnecessary tests.
4846 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4847 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4848 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4850 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4851 (xfont_open): Avoid unnecessary tests.
4853 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4855 * composite.h, composite.c (composition_gstring_put_cache):
4856 Use EMACS_INT, not int, for length.
4858 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4859 breaking out part of COMPOSITION_DECODE_RULE.
4860 (COMPOSITION_DECODE_RULE): Use it.
4861 * composite.c (get_composition_id): Remove unused local vars,
4862 by using the new macro.
4864 * textprop.c (set_text_properties_1): Change while to do-while,
4865 since the condition is always true at first.
4867 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4868 (interval_deletion_adjustment): Return unsigned value.
4871 * process.c (list_processes_1, create_pty, read_process_output):
4872 (exec_sentinel): Remove vars that were set but not used.
4873 (create_pty): Remove unnecessary "volatile"s.
4874 (Fnetwork_interface_info): Avoid possibility of int overflow.
4875 (read_process_output): Do adaptive read buffering even if carryover.
4876 (read_process_output): Simplify nbytes computation if buffered.
4878 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4880 * syntax.c (scan_words): Remove var that was set but not used.
4881 (update_syntax_table): Use unsigned instead of int.
4883 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4884 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4885 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4887 * print.c (print_error_message): Avoid int overflow.
4889 * font.c (font_list_entities): Redo for clarity,
4890 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4892 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4893 (font_score): Avoid potential overflow in diff calculation.
4895 * fns.c (substring_both): Remove var that is set but not used.
4896 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4898 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4900 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4901 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4902 can always succeed if overflow has undefined behavior.
4904 * search.c (boyer_moore, wordify): Remove vars set but not used.
4905 (wordify): Omit three unnecessary tests.
4907 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4908 All callers changed. This avoids the need for an unused var.
4910 * casefiddle.c (casify_region): Remove var that is set but not used.
4912 * dired.c (file_name_completion): Remove var that is set but not used.
4914 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4916 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4917 (Finsert_file_contents): Remove unnecessary code checking fd.
4919 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4920 Check for integer overflow on size calculations.
4922 * buffer.c (Fprevious_overlay_change): Remove var that is set
4925 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4926 Remove vars that are set but not used.
4927 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4928 (timer_check_2): Mark vars as initialized.
4930 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4932 * image.c (lookup_image): Remove var that is set but not used.
4933 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4935 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4936 that are set but not used.
4938 * xfns.c (make_invisible_cursor): Don't return garbage
4939 if XCreateBitmapFromData fails (Bug#8410).
4941 * xselect.c (x_get_local_selection, x_handle_property_notify):
4942 Remove vars that are set but not used.
4944 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4945 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4947 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4948 Remove var that is set but not used.
4949 (scroll_bar_windows_size): Now size_t, not int.
4950 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4953 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4954 (map_tty_color) [!defined MSDOS]: Likewise.
4956 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4958 * coding.c: Remove vars that are set but not used.
4959 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4960 All callers changed.
4961 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4962 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4963 (decode_coding_charset): Remove vars that are set but not used.
4965 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4966 that is set but not used.
4968 * print.c (print_object): Remove var that is set but not used.
4970 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4971 The gnulib version avoids calling malloc in the usual case,
4972 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4973 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4974 * filelock.c (current_lock_owner): Likewise.
4975 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4976 * sysdep.c: Include allocator.h, careadlinkat.h.
4977 (emacs_no_realloc_allocator): New static constant.
4978 (emacs_readlink): New function.
4979 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4980 ../lib/careadlinkat.h.
4982 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4984 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4985 first non-nil return value).
4987 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4989 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4990 if not defined (Bug#8403).
4992 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4994 * xdisp.c (display_count_lines): Remove parameter `start',
4995 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4996 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4997 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4998 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4999 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5000 and thereabouts. All callers changed.
5001 (get_per_char_metric): Remove parameter `f', unused since
5002 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5004 2011-04-02 Jim Meyering <meyering@redhat.com>
5006 do not dereference NULL upon failed strdup
5007 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5008 (ns_get_family): Likewise.
5010 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5012 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5014 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5016 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5019 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5021 Add lexical binding.
5023 * window.c (Ftemp_output_buffer_show): New fun.
5024 (Fsave_window_excursion):
5025 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5027 * lread.c (lisp_file_lexically_bound_p): New function.
5028 (Fload): Bind Qlexical_binding.
5029 (readevalloop): Remove `evalfun' arg.
5030 Bind Qinternal_interpreter_environment.
5031 (Feval_buffer): Bind Qlexical_binding.
5032 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5034 (syms_of_lread): Declare `lexical-binding'.
5036 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5038 * keyboard.c (eval_dyn): New fun.
5039 (menu_item_eval_property): Use it.
5041 * image.c (parse_image_spec): Use Ffunctionp.
5043 * fns.c (concat, mapcar1): Accept byte-code-functions.
5045 * eval.c (Fsetq): Handle lexical vars.
5046 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5047 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5048 (FletX, Flet): Obey lexical binding.
5049 (Fcommandp): Handle closures.
5050 (Feval): New `lexical' arg.
5051 (eval_sub): New function extracted from Feval. Use it almost
5052 everywhere where Feval was used. Look up vars in lexical env.
5054 (Ffunctionp): Move from subr.el.
5055 (Ffuncall): Handle closures.
5056 (apply_lambda): Remove `eval_flags'.
5057 (funcall_lambda): Handle closures and new byte-code-functions.
5058 (Fspecial_variable_p): New function.
5059 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5060 but without exporting it to Lisp.
5062 * doc.c (Fdocumentation, store_function_docstring):
5063 * data.c (Finteractive_form): Handle closures.
5065 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5068 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5070 (exec_byte_code): New function extracted from Fbyte_code to handle new
5071 calling convention for byte-code-functions. Add new byte-codes.
5073 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5075 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5077 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5079 * xdisp.c (redisplay_internal): Fix prototype.
5081 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5083 * xdisp.c (SCROLL_LIMIT): New macro.
5084 (try_scrolling): Use it when setting scroll_limit.
5085 Limit scrolling to 100 screen lines.
5086 (redisplay_window): Even when falling back on "recentering",
5087 position point in the window according to scroll-conservatively,
5088 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5090 (try_scrolling): When point is above the window, allow searching
5091 as far as scroll_max, or one screenful, to compute vertical
5092 distance from PT to the scroll margin position. This prevents
5093 try_scrolling from unnecessarily failing when
5094 scroll-conservatively is set to a value slightly larger than the
5095 window height. Clean up the case of PT below the margin at bottom
5096 of window: scroll_max can no longer be INT_MAX. When aggressive
5097 scrolling is in use, don't let point enter the opposite scroll
5098 margin as result of the scroll.
5099 (syms_of_xdisp) <scroll-conservatively>: Document the
5100 threshold of 100 lines for never-recentering scrolling.
5102 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5104 * dispextern.h (move_it_by_lines):
5105 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5106 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5107 (message_log_check_duplicate): Remove parameters `prev_bol' and
5108 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5109 (redisplay_internal): Remove parameter `preserve_echo_area',
5110 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5112 * indent.c (Fvertical_motion):
5113 * window.c (window_scroll_pixel_based, Frecenter):
5114 Don't pass `need_y_p' to `move_it_by_lines'.
5116 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5118 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5119 steal a few bits to be more compact.
5120 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5121 Remove unneeded casts.
5123 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5125 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5127 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5128 binding" message (bug#7967).
5130 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5132 Fix more problems found by GCC 4.6.0's static checks.
5134 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5135 Remove unused local var.
5137 * editfns.c (Fmessage_box): Remove unused local var.
5139 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5140 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5141 Omit unused local vars.
5142 * window.c (shrink_windows): Omit unused local var.
5143 * menu.c (digest_single_submenu): Omit unused local var.
5144 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5145 Omit unused local var.
5147 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5148 Don't assume string length fits in int.
5149 (keyremap_step, read_key_sequence): Use size_t for sizes.
5150 (read_key_sequence): Don't check last_real_key_start redundantly.
5152 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5153 instead of alloca (Bug#8344).
5155 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5156 (Fbacktrace_frame): Don't assume nframes fits in int.
5158 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5160 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5163 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5165 * cm.c (calccost): Turn while-do into do-while, for clarity.
5167 * keyboard.c (syms_of_keyboard): Use the same style as later
5168 in this function when indexing through an array. This also
5169 works around GCC bug 48267.
5171 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5173 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5175 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5176 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5178 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5179 This avoids undefined behavior on integer overflow, and is a bit
5180 more convenient anyway since it is compared to a size_t variable.
5182 Variadic C functions now count arguments with size_t, not int.
5183 This avoids an unnecessary limitation on 64-bit machines, which
5184 caused (substring ...) to crash on large vectors (Bug#8344).
5185 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5186 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5187 All variadic functions and their callers changed accordingly.
5188 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5189 * data.c (arith_driver, float_arith_driver): Likewise.
5190 * editfns.c (general_insert_function): Likewise.
5191 * eval.c (struct backtrace.nargs, interactive_p)
5192 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5193 (funcall_lambda, mark_backtrace): Likewise.
5194 * fns.c (concat): Likewise.
5195 * frame.c (x_set_frame_parameters): Likewise.
5196 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5197 0 if not found, not -1. All callers changed.
5199 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5200 (stack_copy_size): Now size_t, not int.
5201 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5203 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5205 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5206 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5207 All callers changed.
5209 * lisp.h (multibyte_char_to_unibyte):
5210 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5211 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5212 * character.h (CHAR_TO_BYTE8):
5213 * cmds.c (internal_self_insert):
5214 * editfns.c (general_insert_function):
5215 * keymap.c (push_key_description):
5216 * search.c (Freplace_match):
5217 * xdisp.c (message_dolog, set_message_1): All callers changed.
5219 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5221 * keyboard.c (safe_run_hook_funcall): New function.
5222 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5223 don't set the hook to nil, but remove the offending function instead.
5224 (Qcommand_hook_internal): Remove, unused.
5225 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5226 Vcommand_hook_internal.
5228 * eval.c (enum run_hooks_condition): Remove.
5229 (funcall_nil, funcall_not): New functions.
5230 (run_hook_with_args): Call each function through a `funcall' argument.
5231 Remove `cond' argument, now redundant.
5232 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5233 (Frun_hook_with_args_until_failure): Adjust accordingly.
5234 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5236 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5238 * dispextern.h (string_buffer_position): Remove declaration.
5240 * print.c (strout): Remove parameter `multibyte', unused since
5241 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5243 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5244 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5245 All callers changed.
5247 * w32.c (_wsa_errlist): Use braces for struct initializers.
5249 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5250 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5251 All callers changed.
5252 (string_buffer_position): Likewise. Also, make static (it's never
5253 used outside xdisp.c).
5254 (cursor_row_p): Remove parameter `w', unused since
5255 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5256 (decode_mode_spec): Remove parameter `precision', introduced during
5257 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5258 All callers changed.
5260 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5262 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5264 2011-03-27 Anders Lindgren <andlind@gmail.com>
5266 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5267 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5268 (ns_update_auto_hide_menu_bar): New functions.
5269 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5270 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5271 ns_constrain_all_frames.
5272 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5273 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5275 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5277 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5279 2011-03-27 Glenn Morris <rgm@gnu.org>
5281 * syssignal.h: Replace RETSIGTYPE with void.
5282 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5283 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5284 Replace SIGTYPE with void everywhere.
5285 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5286 * s/template.h (SIGTYPE): Remove commented out definition.
5288 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5290 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5291 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5293 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5295 * w32.c (read_unc_volume): Use parameter `henum', instead of
5296 global variable `wget_enum_handle'.
5298 * keymap.c (describe_vector): Remove parameters `indices' and
5299 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5300 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5302 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5304 * keyboard.c (timer_check): Remove parameter `do_it_now',
5305 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5306 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5307 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5309 * keyboard.c (read_char):
5310 * w32menu.c (w32_menu_display_help):
5311 * xmenu.c (show_help_event, menu_help_callback):
5312 Adjust calls to `show_help_echo'.
5314 * gtkutil.c (xg_maybe_add_timer):
5315 * keyboard.c (readable_events):
5316 * process.c (wait_reading_process_output):
5317 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5319 * insdel.c (adjust_markers_gap_motion):
5320 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5321 (gap_left, gap_right): Don't call it.
5323 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5325 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5326 incurred during fontification.
5328 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5330 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5331 (DEFVAR_PER_BUFFER): Don't pass it.
5333 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5334 (scrolling_window): Don't pass it.
5336 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5338 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5340 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5342 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5343 of variables specific to SELinux and computation of `encoded_absname'.
5345 * image.c (XPutPixel): Remove unused variable `height'.
5347 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5349 * unexw32.c (get_section_info): Remove unused variable `section'.
5351 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5352 (system_process_attributes): Remove unused variable `sess'.
5353 (sys_read): Remove unused variable `err'.
5355 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5356 (w32_wnd_proc): Remove unused variable `isdead'.
5357 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5358 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5359 (x_create_tip_frame): Remove unused variable `tem'.
5361 * w32inevt.c (w32_console_read_socket):
5362 Remove unused variable `no_events'.
5364 * w32term.c (x_draw_composite_glyph_string_foreground):
5365 Remove unused variable `width'.
5367 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5369 * w32term.c (x_set_glyph_string_clipping):
5370 Don't pass uninitialized region to CombineRgn.
5372 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5374 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5375 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5376 (Fx_close_connection): Remove unused variable `i'.
5378 * w32font.c (w32font_draw): Return number of glyphs.
5379 (w32font_open_internal): Remove unused variable `i'.
5380 (w32font_driver): Add missing initializer.
5382 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5383 (fill_in_menu): Remove unused variable `items_added'.
5385 * w32term.c (last_mouse_press_frame): Remove static global variable.
5386 (w32_clip_to_row): Remove unused variable `f'.
5387 (x_delete_terminal): Remove unused variable `i'.
5389 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5390 (NOTHING): Remove unused static global variable.
5391 (uniscribe_check_otf): Remove unused variable `table'.
5392 (uniscribe_font_driver): Add missing initializers.
5394 2011-03-23 Julien Danjou <julien@danjou.info>
5396 * term.c (Fsuspend_tty, Fresume_tty):
5397 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5398 * window.c (temp_output_buffer_show):
5399 * insdel.c (signal_before_change):
5400 * frame.c (Fhandle_switch_frame):
5401 * fileio.c (Fdo_auto_save):
5402 * emacs.c (Fkill_emacs):
5403 * editfns.c (save_excursion_restore):
5404 * cmds.c (internal_self_insert):
5405 * callint.c (Fcall_interactively):
5406 * buffer.c (Fkill_all_local_variables):
5407 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5409 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5410 unconditionnaly since it does the check itself.
5412 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5414 Fix more problems found by GCC 4.5.2's static checks.
5416 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5417 the first time through the loop, since we know p0 < p1 then.
5418 This also avoids a gcc -Wstrict-overflow warning.
5420 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5421 leading to a memory leak, possible in functions like
5422 load_charset_map_from_file that can allocate an unbounded number
5423 of objects (Bug#8318).
5425 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5426 that could (at least in theory) be that large.
5428 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5429 This is less likely to overflow, and avoids undefined behavior if
5430 overflow does occur. All callers changed. Use strtoul to scan
5431 for the unsigned long integer.
5432 (pint2hrstr): Simplify and tune code slightly.
5433 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5435 * scroll.c (do_scrolling): Work around GCC bug 48228.
5436 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5438 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5439 This also avoids a warning with gcc -Wstrict-overflow.
5440 (validate_x_resource_name): Simplify count usage.
5441 This also avoids a warning with gcc -Wstrict-overflow.
5443 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5446 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5448 * process.c (Fmake_network_process): Use socklen_t, not int,
5449 where POSIX says socklen_t is required in portable programs.
5450 This fixes a porting bug on hosts like 64-bit HP-UX, where
5451 socklen_t is wider than int (Bug#8277).
5452 (Fmake_network_process, server_accept_connection):
5453 (wait_reading_process_output, read_process_output):
5456 * process.c: Rename or move locals to avoid shadowing.
5457 (list_processes_1, Fmake_network_process):
5458 (read_process_output_error_handler, exec_sentinel_error_handler):
5459 Rename or move locals.
5460 (Fmake_network_process): Define label "retry_connect" only if needed.
5461 (Fnetwork_interface_info): Fix pointer signedness.
5462 (process_send_signal): Add cast to avoid pointer signedness problem.
5463 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5464 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5466 Make tparam.h and terminfo.c consistent.
5467 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5468 Include tparam.h instead, since it declares them.
5469 * cm.h (PC): Remove extern decl; tparam.h now does this.
5470 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5471 * terminfo.c: Include tparam.h, to check interfaces.
5472 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5473 (tparam): Adjust signature to match interface in tparam.h;
5474 this removes some undefined behavior. Check that outstring and len
5475 are zero, which they always are with Emacs.
5476 * tparam.h (PC, BC, UP): New extern decls.
5478 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5479 (xftfont_open): Rename locals to avoid shadowing.
5481 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5482 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5483 (OTF_TAG_SYM): Omit macro if not needed.
5484 (ftfont_list): Remove unused local.
5485 (get_adstyle_property, ftfont_pattern_entity):
5486 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5487 Rename locals to avoid shadowing.
5489 * xfont.c (xfont_list_family): Mark var as initialized.
5491 * xml.c (make_dom): Now static.
5493 * composite.c (composition_compute_stop_pos): Rename local to
5495 (composition_reseat_it): Remove unused locals.
5496 (find_automatic_composition, composition_adjust_point): Likewise.
5497 (composition_update_it): Mark var as initialized.
5498 (find_automatic_composition): Mark vars as initialized,
5499 with a FIXME (Bug#8290).
5501 character.h: Rename locals to avoid shadowing.
5502 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5503 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5504 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5505 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5508 * textprop.c (property_change_between_p): Remove; unused.
5510 * intervals.c (interval_start_pos): Now static.
5512 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5514 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5515 Rename locals to avoid shadowing.
5517 * sound.c (wav_play, au_play, Fplay_sound_internal):
5518 Fix pointer signedness.
5519 (alsa_choose_format): Remove unused local var.
5520 (wav_play): Initialize a variable to 0, to prevent undefined
5521 behavior (Bug#8278).
5523 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5525 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5527 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5528 clobbering (Bug#8298).
5529 * sysdep.c (sys_subshell): Likewise.
5530 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5532 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5533 This should get cleaned up, so that child_setup has the
5534 same signature on all platforms.
5536 * callproc.c (call_process_cleanup): Now static.
5537 (relocate_fd): Rename locals to avoid shadowing.
5539 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5541 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5542 not to be necessary, and produces flickering.
5544 2011-03-20 Glenn Morris <rgm@gnu.org>
5546 * config.in: Remove file.
5548 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5550 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5551 are now in src/globals.h.
5552 (syms_of_minibuf): Remove spurious & from previous change.
5554 2011-03-20 Leo <sdl.web@gmail.com>
5556 * minibuf.c (completing-read-function): New variable.
5557 (completing-read-default): Rename from completing-read.
5558 (completing-read): Call completing-read-function.
5560 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5562 * xfaces.c (Fx_load_color_file):
5563 Read color file from absolute filename (bug#8250).
5565 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5567 * makefile.w32-in: Update dependencies.
5569 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5571 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5573 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5575 Fix more problems found by GCC 4.5.2's static checks.
5577 * process.c (make_serial_process_unwind, send_process_trap):
5578 (sigchld_handler): Now static.
5580 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5581 That way, the code declares only the vars that it needs.
5582 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5583 * s/cygwin.h (PTY_ITERATION): Likewise.
5584 * s/darwin.h (PTY_ITERATION): Likewise.
5585 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5587 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5588 * process.c (allocate_pty): Don't declare stb unless it's needed.
5590 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5591 (CONSTANTLIM): Remove; unused.
5592 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5593 Define only if needed.
5595 * unexelf.c (unexec): Name an expression,
5596 to avoid gcc -Wbad-function-cast warning.
5597 Use a different way to cause a compilation error if anyone uses
5598 n rather than nn, a way that does not involve shadowing.
5599 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5601 * deps.mk (unexalpha.o): Remove; unused.
5603 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5604 * unexec.h: New file.
5605 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5606 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5608 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5609 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5610 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5611 Change as necessary to match prototype in unexec.h.
5613 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5615 (back_comment, skip_chars): Mark vars as initialized.
5617 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5618 Rename locals to avoid shadowing.
5620 * lread.c (read1): Rewrite so as not to use empty "else".
5621 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5623 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5625 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5626 warning when compiling print.c.
5628 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5629 instead of using an uninitialized var.
5630 (font_sort_entities): Mark var as initialized.
5632 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5634 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5635 pointers to constants.
5636 (font_parse_fcname): Remove unused vars.
5637 (font_delete_unmatched): Now static.
5638 (font_get_spec): Remove; unused.
5639 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5640 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5641 Rename or move locals to avoid shadowing.
5643 * fns.c (require_nesting_list, require_unwind): Now static.
5644 (Ffillarray): Rename locals to avoid shadowing.
5646 * floatfns.c (domain_error2): Define only if needed.
5647 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5649 * alloc.c (mark_backtrace): Move decl from here ...
5650 * lisp.h: ... to here, so that it can be checked.
5652 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5653 (Fdefvar): Rewrite so as not to use empty "else".
5654 (lisp_indirect_variable): Name an expression,
5655 to avoid gcc -Wbad-function-cast warning.
5656 (Fdefvar): Rename locals to avoid shadowing.
5658 * callint.c (quotify_arg, quotify_args): Now static.
5659 (Fcall_interactively): Rename locals to avoid shadowing.
5660 Use const pointer when appropriate.
5662 * lisp.h (get_system_name, get_operating_system_release):
5663 Move decls here, to check interfaces.
5664 * process.c (get_operating_system_release): Move decl to lisp.h.
5665 * xrdb.c (get_system_name): Likewise.
5666 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5667 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5668 some of which prompt warnings from gcc -Wbad-function-cast.
5669 (Fformat_time_string, Fencode_time, Finsert_char):
5670 (Ftranslate_region_internal, Fformat):
5671 Rename or remove local vars to avoid shadowing.
5672 (Ftranslate_region_internal): Mark var as initialized.
5674 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5677 * lisp.h (eassert): Check that the argument compiles, even if
5678 ENABLE_CHECKING is not defined.
5680 * data.c (Findirect_variable): Name an expression, to avoid
5681 gcc -Wbad-function-cast warning.
5682 (default_value, arithcompare, arith_driver, arith_error): Now static.
5683 (store_symval_forwarding): Rename local to avoid shadowing.
5684 (Fmake_variable_buffer_local, Fmake_local_variable):
5685 Mark variables as initialized.
5686 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5688 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5689 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5690 Rename locals to avoid shadowing.
5691 (mark_stack): Move local variables into the #ifdef region where
5693 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5694 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5696 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5697 (GC_STRING_CHARS): Remove; not used.
5698 (Fmemory_limit): Cast sbrk's returned value to char *.
5700 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5701 avoids undefined behavior in theory.
5703 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5705 Use functions, not macros, for up- and down-casing (Bug#8254).
5706 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5707 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5708 to use the following functions instead of these macros.
5709 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5710 EMACS_INT, since callers assume the returned value fits in int.
5711 (upcase1): Likewise, for UPCASE_TABLE.
5712 (uppercasep, lowercasep, upcase): New static inline functions.
5713 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5714 the race-condition problem in the old DOWNCASE.
5716 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5717 Rename locals to avoid shadowing.
5718 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5719 (regex_compile, re_search_2, re_match_2_internal):
5720 Remove unused local vars.
5721 (FREE_VAR): Rewrite so as not to use empty "else",
5722 which gcc can warn about.
5723 (regex_compile, re_match_2_internal): Mark locals as initialized.
5724 (RETALLOC_IF): Define only if needed.
5725 (WORDCHAR_P): Likewise. This one is never needed, but is used
5726 only in a comment talking about a compiler bug, so put inside
5727 the #if 0 of that comment.
5728 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5729 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5732 * search.c (boyer_moore): Rename locals to avoid shadowing.
5733 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5734 (PREV_CHAR_BOUNDARY): Likewise.
5736 * search.c (simple_search): Remove unused var.
5738 * dired.c (compile_pattern): Move decl from here ...
5739 * lisp.h: ... to here, so that it can be checked.
5740 (struct re_registers): New forward decl.
5742 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5744 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5746 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5747 Rename locals to avoid shadowing.
5748 (Fvertical_motion): Mark locals as initialized.
5750 * casefiddle.c (casify_object, casify_region): Now static.
5751 (casify_region): Mark local as initialized.
5753 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5755 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5756 New macros, so that the caller can use some names other than
5757 gcpro1, gcpro2, etc.
5758 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5760 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5761 argument, for consistency with GCPRO2_VAR, etc: it is now the
5762 prefix of the variable, not the variable itself. All uses
5764 * dired.c (directory_files_internal, file_name_completion):
5765 Rename locals to avoid shadowing.
5767 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5768 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5769 dired.c's scmp function, had undefined behavior.
5770 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5771 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5772 * buffer.h: ... to here, because these macros use current_buffer,
5773 and the new implementation with inline functions needs to have
5774 current_buffer in scope now, rather than later when the macros
5776 (downcase, upcase1): New static inline functions.
5777 (DOWNCASE, UPCASE1): Reimplement using these functions.
5778 This avoids undefined behavior in expressions like
5779 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5780 from race conditions in accessing the global variables
5781 case_temp1 and case_temp2.
5782 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5783 * lisp.h (case_temp1, case_temp2): Remove their decls.
5784 * character.h (ASCII_CHAR_P): Move from here ...
5785 * lisp.h: ... to here, so that the inline functions mentioned
5788 * dired.c (directory_files_internal_unwind): Now static.
5790 * fileio.c (file_name_as_directory, directory_file_name):
5791 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5793 (file_name_as_directory): Use const pointers when appropriate.
5794 (Fexpand_file_name): Likewise. In particular, newdir might
5795 point at constant storage, so make it a const pointer.
5796 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5797 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5799 (Fset_file_times, Finsert_file_contents, auto_save_error):
5800 Rename locals to avoid shadowing.
5802 * minibuf.c (choose_minibuf_frame_1): Now static.
5803 (Ftry_completion, Fall_completions): Rename or remove locals
5806 * marker.c (bytepos_to_charpos): Remove; unused.
5808 * lisp.h (verify_bytepos, count_markers): New decls,
5809 so that gcc does not warn that these functions aren't declared.
5811 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5812 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5813 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5814 (copy_text): Remove unused local var.
5816 * filelock.c (within_one_second): Now static.
5817 (lock_file_1): Rename local to avoid shadowing.
5819 * buffer.c (fix_overlays_before): Mark locals as initialized.
5820 (fix_start_end_in_overlays): Likewise. This function should be
5821 simplified by using pointers-to-pointers, but that's a different
5823 (switch_to_buffer_1): Now static.
5824 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5825 (report_overlay_modification): Rename locals to avoid shadowing.
5827 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5828 Fix pointer signedness issue.
5829 (sys_subshell): Mark local as volatile if checking for lint,
5830 to suppress a gcc -Wclobbered warning that does not seem to be right.
5831 (MAXPATHLEN): Define only if needed.
5833 * process.c (serial_open, serial_configure): Move decls from here ...
5834 * systty.h: ... to here, so that they can be checked.
5836 * fns.c (get_random, seed_random): Move extern decls from here ...
5837 * lisp.h: ... to here, so that they can be checked.
5839 * sysdep.c (reset_io): Now static.
5840 (wait_for_termination_signal): Remove; unused.
5842 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5843 (copy_keymap_item, append_key, push_text_char_description):
5845 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5846 (DENSE_TABLE_SIZE): Remove; unused.
5847 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5848 (describe_map_tree):
5849 Rename locals to avoid shadowing.
5851 * keyboard.c: Declare functions static if they are not used elsewhere.
5852 (echo_char, echo_dash, cmd_error, top_level_2):
5853 (poll_for_input, handle_async_input): Now static.
5854 (read_char, kbd_buffer_get_event, make_lispy_position):
5855 (make_lispy_event, make_lispy_movement, apply_modifiers):
5856 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5857 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5858 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5859 (read_key_sequence, read_char): Mark locals as initialized.
5860 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5862 * keyboard.h (make_ctrl_char): New decl.
5863 (mark_kboards): Move decl here ...
5864 * alloc.c (mark_kboards): ... from here.
5866 * lisp.h (force_auto_save_soon): New decl.
5868 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5869 (DEFINE_DUMMY_FUNCTION): New macro.
5870 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5872 (main): Add casts to avoid warnings
5873 if GCC considers string literals to be constants.
5875 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5877 * dbusbind.c: Pointer signedness fixes.
5878 (xd_signature, xd_append_arg, xd_initialize):
5879 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5880 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5881 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5882 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5884 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5885 if GCC considers string literals to be constants.
5886 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5888 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5890 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5891 (print_preprocess, print_object): New macro to fix last change.
5893 * print.c (print_preprocess): Don't forget font objects.
5895 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5897 * emacs.c (USAGE3): Doc fixes.
5899 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5901 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5904 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5906 * lisp.h (VWindow_system, Qfile_name_history):
5907 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5908 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5909 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5911 * w32select.c: Don't #include "keyboard.h".
5912 (run_protected): Add extern declaration for waiting_for_input.
5914 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5915 * w32console.c (detect_input_pending, read_input_pending)
5916 (encode_terminal_code):
5917 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5918 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5919 (w32_system_caret_y, Qfile_name_history):
5920 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5921 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5922 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5923 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5924 * w32proc.c (Qlocal, report_file_error):
5925 * w32term.c (Vwindow_system, updating_frame):
5926 * w32uniscribe.c (initialized, uniscribe_font_driver):
5927 Remove unneeded extern declarations.
5929 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5931 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5933 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5935 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5936 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5937 These macros can no longer be used for assignment.
5939 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5940 Assign struct members directly, instead of using BUF_BEGV etc.
5941 (record_buffer_markers, fetch_buffer_markers): New functions for
5942 recording and fetching special buffer markers.
5943 (set_buffer_internal_1, set_buffer_temp): Use them.
5945 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5947 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5949 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5950 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5952 * xdisp.c (hscroll_window_tree):
5953 (reconsider_clip_changes): Use PT instead of BUF_PT.
5955 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5957 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5958 $(EMACS_ROOT)/lib/intprops.h.
5960 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5962 Fix more problems found by GCC 4.5.2's static checks.
5964 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5965 to unsigned char * to avoid compiler diagnostic.
5966 (xg_free_frame_widgets): Make it clear that a local variable is
5967 needed only if USE_GTK_TOOLTIP.
5968 (gdk_window_get_screen): Make it clear that this macro is needed
5969 only if USE_GTK_TOOLTIP.
5970 (int_gtk_range_get_value): New function, which avoids a diagnostic
5971 from gcc -Wbad-function-cast.
5972 (xg_set_toolkit_scroll_bar_thumb): Use it.
5973 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5974 diagnostic from gcc -Wbad-function-cast.
5975 (get_utf8_string, xg_get_file_with_chooser):
5976 Rename locals to avoid shadowing.
5977 (create_dialog): Move locals to avoid shadowing.
5979 * xgselect.c (xg_select): Remove unused var.
5981 * image.c (four_corners_best): Mark locals as initialized.
5982 (gif_load): Initialize transparent_p to zero (Bug#8238).
5983 Mark another local as initialized.
5984 (my_png_error, my_error_exit): Mark with NO_RETURN.
5986 * image.c (clear_image_cache): Now static.
5987 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5988 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5989 (x_edge_detection): Remove unnecessary cast that
5990 gcc -Wbad-function-cast diagnoses.
5991 (gif_load): Fix pointer signedness.
5992 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5993 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5995 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5997 Improve quality of tests for time stamp overflow.
5998 For example, without this patch (encode-time 0 0 0 1 1
5999 1152921504606846976) returns the obviously-bogus value (-948597
6000 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6001 reports time overflow. See
6002 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6003 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6004 * editfns.c: Include limits.h and intprops.h.
6005 (TIME_T_MIN, TIME_T_MAX): New macros.
6006 (time_overflow): Move earlier, to before first use.
6007 (hi_time, lo_time): New functions, for an accurate test for
6009 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6010 (Fget_internal_run_time): Don't assume time_t fits in int.
6011 (make_time): Use list2 instead of Fcons twice.
6012 (Fdecode_time): More accurate test for out-of-range times.
6013 (check_tm_member): New function.
6014 (Fencode_time): Use it, to test for out-of-range times.
6015 (lisp_time_argument): Don't rely on undefined left-shift and
6016 right-shift behavior when checking for time stamp overflow.
6018 * editfns.c (time_overflow): New function, refactoring common code.
6019 (Fformat_time_string, Fdecode_time, Fencode_time):
6020 (Fcurrent_time_string): Use it.
6022 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6023 * dired.c (make_time): Move to ...
6024 * editfns.c (make_time): ... here.
6025 * systime.h: Note the move.
6027 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6029 * fringe.c (update_window_fringes): Remove unused variables.
6031 * unexmacosx.c (copy_data_segment): Also copy __got section.
6034 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6036 * termcap.c [MSDOS]: Include "msdos.h".
6037 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6038 Constify `char *' arguments and their references according to
6039 prototypes in tparam.h.
6041 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6043 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6044 Adapt all references accordingly.
6046 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6048 2011-03-11 Tom Tromey <tromey@redhat.com>
6050 * buffer.c (syms_of_buffer): Remove obsolete comment.
6052 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6054 * termhooks.h (encode_terminal_code): Declare prototype.
6056 * msdos.c (encode_terminal_code): Don't declare prototype.
6058 * term.c (encode_terminal_code): Now external again, used by
6059 w32console.c and msdos.c.
6061 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6062 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6064 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6066 Fix some minor problems found by GCC 4.5.2's static checks.
6068 * fringe.c (update_window_fringes): Mark locals as initialized
6070 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6072 * alloc.c (mark_fringe_data): Move decl from here ...
6073 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6074 to check its interface.
6075 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6077 * fontset.c (free_realized_fontset): Now static.
6078 (Fset_fontset_font): Rename local to avoid shadowing.
6079 (fontset_font): Mark local as initialized.
6080 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6082 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6084 * xselect.c (x_disown_buffer_selections): Remove; not used.
6085 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6086 (x_own_selection, Fx_disown_selection_internal): Rename locals
6088 (x_handle_dnd_message): Remove local to avoid shadowing.
6090 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6091 so that the caller can use some name other than gcpro1.
6092 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6093 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6094 (Fx_backspace_delete_keys_p):
6095 Use them to avoid shadowing, and rename vars to avoid shadowing.
6096 (x_decode_color, x_set_name, x_window): Now static.
6097 (Fx_create_frame): Add braces to silence GCC warning.
6098 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6099 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6100 Remove unused locals.
6101 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6102 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6103 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6106 * xterm.h (x_mouse_leave): New decl.
6108 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6109 Remove unused functions.
6110 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6111 (x_calc_absolute_position): Now static.
6112 (XTread_socket): Don't define label "out" unless it's used.
6113 Don't declare local "event" unless it's used.
6114 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6115 unless they are used.
6116 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6117 (x_fatal_error_signal): Remove; not used.
6118 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6119 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6120 (x_error_catcher, x_connection_closed, x_error_handler):
6121 (x_error_quitter, xembed_send_message, x_iconify_frame):
6122 (my_log_handler): Rename locals to avoid shadowing.
6123 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6124 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6126 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6127 Rename or move locals to avoid shadowing.
6128 (tty_defined_color, merge_face_heights): Now static.
6129 (free_realized_faces_for_fontset): Remove; not used.
6130 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6131 does not deduce is never used uninitialized.
6132 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6133 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6135 * terminal.c (store_terminal_param): Now static.
6137 * xmenu.c (menu_highlight_callback): Now static.
6138 (set_frame_menubar): Remove unused local.
6139 (xmenu_show): Rename parameter to avoid shadowing.
6140 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6141 since they might point to immutable storage.
6142 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6143 since it's unused otherwise.
6145 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6146 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6147 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6148 avoids a gcc -Wuninitialized diagnostic.
6149 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6150 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6151 does not deduce are never used uninitialized.
6153 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6155 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6156 * window.c (window_loop, size_window):
6157 (run_window_configuration_change_hook, enlarge_window): Likewise.
6159 * window.c (display_buffer): Now static.
6160 (size_window): Mark variables that gcc -Wuninitialized
6161 does not deduce are never used uninitialized.
6162 * window.h (check_all_windows): New decl, to forestall
6163 gcc -Wmissing-prototypes diagnostic.
6164 * dispextern.h (bidi_dump_cached_states): Likewise.
6166 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6168 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6170 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6171 and to avoid gcc -Wuninitialized warning.
6172 (load_charset_map): Mark variables that gcc -Wuninitialized
6173 does not deduce are never used uninitialized.
6174 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6176 * coding.c (coding_set_source, coding_set_destination):
6177 Use "else { /* comment */ }" rather than "else /* comment */;"
6178 for clarity, and to avoid gcc -Wempty-body warning.
6179 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6180 a block, when the outer 'i' will do.
6181 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6182 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6183 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6184 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6185 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6186 Rename locals to avoid shadowing.
6187 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6188 * coding.c (emacs_mule_char, encode_invocation_designation):
6189 Now static, since they're not used elsewhere.
6190 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6191 (decode_coding_object, encode_coding_object, detect_coding_system):
6192 (decode_coding_emacs_mule): Mark variables that gcc
6193 -Wuninitialized does not deduce are never used uninitialized.
6194 (detect_coding_iso_2022): Initialize a local variable that might
6195 be used uninitialized. Leave a FIXME because it's not clear that
6196 this initialization is needed. (Bug#8211)
6197 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6198 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6199 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6200 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6201 Remove unused macros.
6203 * category.c (hash_get_category_set): Remove unused local var.
6204 (copy_category_table): Now static, since it's not used elsewhere.
6205 * character.c (string_count_byte8): Likewise.
6207 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6208 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6210 * chartab.c (copy_sub_char_table): Now static, since it's not used
6212 (sub_char_table_ref_and_range, char_table_ref_and_range):
6213 Rename locals to avoid shadowing.
6214 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6216 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6217 (BIDI_BOB): Remove unused macro.
6219 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6220 deduce are never used uninitialized.
6221 * term.c (encode_terminal_code): Likewise.
6223 * term.c (encode_terminal_code): Now static. Remove unused local.
6225 * tparam.h: New file.
6226 * term.c, tparam.h: Include it.
6227 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6228 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6229 Move these decls to tparam.h, and make them agree with what
6230 is actually in tparam.c. The previous trick of using incompatible
6231 decls in different modules does not conform to the C standard.
6232 All callers of tparam changed to use tparam's actual API.
6233 * tparam.c (tparam1, tparam, tgoto):
6234 Use const pointers where appropriate.
6236 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6237 * cm.h (struct cm): Likewise.
6238 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6239 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6240 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6241 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6242 (turn_on_face, init_tty): Likewise.
6243 * termchar.h (struct tty_display_info): Likewise.
6245 * term.c (term_mouse_position): Rename local to avoid shadowing.
6247 * alloc.c (mark_ttys): Move decl from here ...
6248 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6250 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6252 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6254 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6256 * search.c (compile_pattern_1): Remove argument regp, unused since
6257 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6258 (compile_pattern): Don't pass it.
6260 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6262 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6263 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6265 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6267 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6269 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6270 gdk_window_get_screen, gdk_window_get_geometry,
6271 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6272 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6273 (xg_get_pixbuf_from_pixmap): New function.
6274 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6275 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6276 Call xg_get_pixbuf_from_pixmap instead of
6277 gdk_pixbuf_get_from_drawable.
6278 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6279 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6280 (xg_check_special_colors): Use GtkStyleContext and its functions
6282 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6283 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6284 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6285 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6286 Call gtk_widget_get_preferred_size.
6287 (xg_frame_resized): gdk_window_get_geometry only takes 5
6289 (xg_win_to_widget, xg_event_is_for_menubar):
6290 Call gdk_x11_window_lookup_for_display.
6291 (xg_set_widget_bg): New function.
6292 (delete_cb): New function.
6293 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6294 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6295 (xg_set_background_color): Call xg_set_widget_bg.
6296 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6297 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6298 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6299 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6301 (update_frame_tool_bar): Call gtk_widget_hide.
6302 (xg_initialize): Use GDK_KEY_g.
6304 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6306 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6308 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6309 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6310 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6312 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6314 * w32xfns.c (select_palette): Check success of RealizePalette against
6315 GDI_ERROR, not zero.
6317 See ChangeLog.11 for earlier changes.
6323 Copyright (C) 2011 Free Software Foundation, Inc.
6325 This file is part of GNU Emacs.
6327 GNU Emacs is free software: you can redistribute it and/or modify
6328 it under the terms of the GNU General Public License as published by
6329 the Free Software Foundation, either version 3 of the License, or
6330 (at your option) any later version.
6332 GNU Emacs is distributed in the hope that it will be useful,
6333 but WITHOUT ANY WARRANTY; without even the implied warranty of
6334 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6335 GNU General Public License for more details.
6337 You should have received a copy of the GNU General Public License
6338 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.