1 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3 Support mouse highlight on w32 text-mode frames.
4 * xdisp.c (draw_row_with_mouse_face): Call
5 tty_draw_row_with_mouse_face for WINDOWSNT as well.
7 * w32inevt.c (mouse_moved_to): When the mouse moves, call
10 * w32console.c: Include window.h.
11 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
13 (initialize_w32_display): Initialize mouse-highlight data.
15 2012-05-26 Eli Zaretskii <eliz@gnu.org>
17 * bidi.c (bidi_mirror_char): Revert last change: an int is
18 definitely wide enough here.
20 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
22 Fix integer width and related bugs (Bug#9874).
23 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
24 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
25 (string_bytes, check_sblock, allocate_string_data):
26 (compact_small_strings, Fmake_bool_vector, make_string)
27 (make_unibyte_string, make_multibyte_string)
28 (make_string_from_bytes, make_specified_string)
29 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
30 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
32 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
33 (allocate_pseudovector):
34 Use int, not EMACS_INT, where int is wide enough.
35 (inhibit_garbage_collection, Fgarbage_collect):
36 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
37 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
38 int might not be wide enough.
39 (bidi_cache_search, bidi_cache_find, bidi_init_it)
40 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
41 (bidi_at_paragraph_end, bidi_find_paragraph_start)
42 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
43 (bidi_level_of_next_char, bidi_move_to_visually_next):
44 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
45 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
46 (Fkill_buffer, Fset_buffer_major_mode)
47 (advance_to_char_boundary, Fbuffer_swap_text)
48 (Fset_buffer_multibyte, overlays_at, overlays_in)
49 (overlay_touches_p, struct sortvec, record_overlay_string)
50 (overlay_strings, recenter_overlay_lists)
51 (adjust_overlays_for_insert, adjust_overlays_for_delete)
52 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
53 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
54 (Foverlay_recenter, last_overlay_modification_hooks_used)
55 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
56 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
57 (validate_region): Omit unnecessary test for b <= e,
58 since that's guaranteed by the previous test.
59 (adjust_overlays_for_delete): Avoid pos + length overflow.
60 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
61 (report_overlay_modification):
62 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
63 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
64 Omit pointer cast, which isn't needed anyway, and doesn't work
65 after the EMACS_INT -> ptrdiff_t change.
66 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
67 * buffer.h: Adjust decls to match defn changes elsewhere.
68 (struct buffer_text, struct buffer):
69 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
70 Use EMACS_INT, not int, where int might not be wide enough.
71 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
72 not int, to avoid needless 32-bit limit on 64-bit hosts.
73 (exec_byte_code): Use tighter memory-full test, one that checks
74 for alloca overflow. Don't compute the address of the object just
75 before an array, as that's not portable. Use EMACS_INT, not
76 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
77 * callint.c (Fcall_interactively):
78 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
79 * callproc.c (call_process_kill, Fcall_process):
80 Don't assume pid_t fits into an Emacs fixnum.
81 (call_process_cleanup, Fcall_process, child_setup):
82 Don't assume pid_t fits into int.
83 (call_process_cleanup, Fcall_process, delete_temp_file)
84 (Fcall_process_region):
85 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
86 (Fcall_process): Simplify handling of volatile integers.
87 Use int, not EMACS_INT, where int will do.
88 * casefiddle.c (casify_object, casify_region, operate_on_word)
89 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
90 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
91 (casify_object): Avoid integer overflow when overallocating buffer.
92 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
93 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
94 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
95 * category.h (CATEGORYP): Don't assume arg is nonnegative.
96 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
97 integers are now checked earlier. All uses replaced with XINT.
99 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
100 For CCL_MapSingle, check that content and value are in int range.
101 (ccl_driver, Fregister_code_conversion_map):
102 Check that Vcode_version_map_vector is a vector.
103 (resolve_symbol_ccl_program): Check that vector header is in range.
104 Always copy the vector, so that we can check its contents reliably
105 now rather than having to recheck each instruction as it's being
106 executed. Check that vector words fit in 'int'.
107 (ccl_get_compiled_code, Fregister_ccl_program)
108 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
109 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
110 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
111 contents are in range.
112 (Fccl_execute_on_string): Check that status is in range.
113 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
114 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
115 Accept and return EMACS_INT, not int, because callers can pass values
117 (c_string_width, strwidth, lisp_string_width, chars_in_text)
118 (multibyte_chars_in_text, parse_str_as_multibyte)
119 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
120 (str_as_unibyte, str_to_unibyte, string_count_byte8)
121 (string_escape_byte8, Fget_byte):
122 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
123 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
124 avoid mishandling large integers.
125 * character.h: Adjust decls to match defn changes elsewhere.
126 * charset.c (load_charset_map_from_file, find_charsets_in_text)
127 (Ffind_charset_region):
128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
129 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
130 (load_charset_map_from_vector, Fdefine_charset_internal):
131 Don't assume fixnum fits in int.
132 (load_charset_map_from_vector, Fmap_charset_chars):
133 Remove now-unnecessary CHECK_NATNUMs.
134 (Fdefine_charset_internal): Check ranges here, more carefully.
135 Don't rely on undefined behavior with signed left shift overflow.
136 Don't assume unsigned int fits into fixnum, or that fixnum fits
137 into unsigned int. Don't require max_code to be a valid fixnum;
138 that's not true for gb10830 4-byte on a 32-bit host. Allow
139 invalid_code to be a cons, for the same reason. Require code_offset
140 to be a character. Avoid int overflow if max_char is close
142 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
143 this is intended anyway and avoids some undefined behavior.
144 (load_charset_map): Pass unsigned, not int, as 2nd arg of
145 INDEX_TO_CODE_POINT, as that's what it expects.
146 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
147 * charset.h (DECODE_CHAR): Return int, not unsigned;
148 this is what was intended anyway, and it avoids undefined behavior.
149 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
150 integer-overflow issues.
151 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
152 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
153 where the argument is EMACS_INT, and this behavior is not intended.
154 * chartab.c (Fmake_char_table, Fset_char_table_range)
155 (uniprop_get_decoder, uniprop_get_encoder):
156 Don't assume fixnum fits in int.
157 * cmds.c (move_point): New function, that does the gist of
158 Fforward_char and Fbackward_char, but does so while checking
159 for integer overflow more accurately.
160 (Fforward_char, Fbackward_char): Use it.
161 (Fforward_line, Fend_of_line, internal_self_insert)
162 (internal_self_insert):
163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
164 Fix a FIXME, by checking for integer overflow when calculating
165 target_clm and actual_clm.
166 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
167 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
168 (ASSURE_DESTINATION, coding_alloc_by_realloc)
169 (coding_alloc_by_making_gap, alloc_destination)
170 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
171 (encode_coding_utf_16, detect_coding_emacs_mule)
172 (decode_coding_emacs_mule, encode_coding_emacs_mule)
173 (detect_coding_iso_2022, decode_coding_iso_2022)
174 (encode_invocation_designation, encode_designation_at_bol)
175 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
176 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
177 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
178 (encode_coding_ccl, encode_coding_raw_text)
179 (detect_coding_charset, decode_coding_charset)
180 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
181 (produce_composition, produce_charset, produce_annotation)
182 (decode_coding, handle_composition_annotation)
183 (handle_charset_annotation, consume_chars, decode_coding_gap)
184 (decode_coding_object, encode_coding_object, detect_coding_system)
185 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
186 (code_convert_region, code_convert_string)
187 (Fdefine_coding_system_internal)
188 (coding_set_source, coding_set_destination):
189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
190 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
191 (Fdefine_coding_system_internal):
192 Don't assume fixnums fit in int.
193 (decode_coding_gap, decode_coding_object, encode_coding_object)
194 (Fread_coding_system, Fdetect_coding_region)
195 (Funencodable_char_position, Fcheck_coding_systems_region)
196 (get_translation, handle_composition_annotation, consume_chars):
197 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
198 (consume_chars): Rewrite to not calculate an address outside buffer.
199 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
200 Don't access memory outside of the args array.
201 (Fdefine_coding_system_internal): Check for charset-id overflow.
202 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
203 result of ENCODE_CHAR.
204 * coding.h: Adjust decls to match defn changes elsewhere.
205 (struct coding_system):
206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
207 * composite.c (get_composition_id, find_composition)
208 (run_composition_function, update_compositions)
209 (compose_text, composition_gstring_put_cache)
210 (composition_gstring_p, composition_gstring_width)
211 (fill_gstring_header, fill_gstring_body, autocmp_chars)
212 (composition_compute_stop_pos, composition_reseat_it)
213 (composition_update_it, struct position_record)
214 (find_automatic_composition, composition_adjust_point)
215 (Fcomposition_get_gstring, Ffind_composition_internal):
216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
217 (update_compositions):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 * composite.h: Adjust decls to match defn changes elsewhere.
220 (struct composition):
221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
222 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
223 Do not attempt to compute the address of the object just before a
224 buffer; this is not portable.
226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
227 (Faset): Use int, not EMACS_INT, where int is wide enough.
228 (Fstring_to_number): Don't assume fixnums fit in int.
229 (Frem): Don't assume arg is nonnegative.
230 * dbusbind.c (xd_append_arg): Check for integers out of range.
231 (Fdbus_call_method): Don't overflow the timeout int.
232 (extract_signed, extract_unsigned): New functions.
233 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
234 (xd_get_connection_references): Return ptrdiff_t, not int.
236 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
238 Use int, not unsigned, where the dbus API uses int.
239 (Fdbus_message_internal): Don't overflow mtype.
240 (syms_of_dbusbind): Allocate right-sized buffer for integers.
241 * dired.c (directory_files_internal, file_name_completion, scmp)
242 (file_name_completion_stat):
243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
244 (file_name_completion): Don't overflow matchcount.
245 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
246 * dispextern.h: Adjust decls to match defn changes elsewhere.
247 (struct text_pos, struct glyph, struct bidi_saved_info)
248 (struct bidi_string_data, struct bidi_it, struct composition_it)
250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
251 (struct display_pos, struct composition_it, struct it):
252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
253 * dispnew.c (increment_matrix_positions)
254 (increment_row_positions, mode_line_string)
255 (marginal_area_string):
256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
257 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
259 (duration_to_sec_usec): New function, to check for overflow better.
260 (Fsleep_for, sit_for): Use it.
261 * doc.c (get_doc_string, store_function_docstring):
262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
263 (get_doc_string, Fsnarf_documentation):
264 Use int, not EMACS_INT, where int is wide enough.
266 Use SAFE_ALLOCA, not alloca.
267 Check for overflow when converting EMACS_INT to off_t.
269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
270 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
271 Don't assume uid_t fits into fixnum.
272 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
273 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
274 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
275 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
276 (general_insert_function)
277 (Finsert_char, make_buffer_string, make_buffer_string_both)
278 (update_buffer_properties, Fbuffer_substring)
279 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
280 (Fsubst_char_in_region, check_translation)
281 (Ftranslate_region_internal, save_restriction_restore, Fformat)
282 (transpose_markers, Ftranspose_regions):
283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
284 (clip_to_bounds): Move to lisp.h as an inline function).
285 (Fconstrain_to_field): Don't assume integers are nonnegative.
286 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
287 (Fsubst_char_in_region, Fsave_restriction):
288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
289 (Femacs_pid): Don't assume pid_t fits into fixnum.
290 (lo_time): Use int, not EMACS_INT, when int suffices.
291 (lisp_time_argument): Check for usec out of range.
292 (Fencode_time): Don't assume fixnum fits in int.
293 (Fuser_login_name, Fuser_full_name): Signal an error
294 if a uid argument is out of range, rather than relying on
296 (Fformat_time_string): Remove now-unnecessary check.
297 lisp_time_argument checks for out-of-range usec now.
298 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
299 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
300 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
301 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
302 (init_cmdargs, Fdump_emacs):
303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
304 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
305 the bottom (typically) 32 bits of the fixnum.
306 * eval.c (specpdl_size, call_debugger):
307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
308 (when_entered_debugger, Fbacktrace_debug):
309 Don't assume fixnum can fit in int.
310 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
311 the object just before a buffer; this is not portable.
312 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
313 (grow_specpdl, unbind_to):
314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
315 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
316 (grow_specpdl): Simplify allocation by using xpalloc.
317 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
318 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
319 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
321 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
324 (Fcopy_file, non_regular_nbytes, read_non_regular)
325 (Finsert_file_contents):
326 Use int, not EMACS_INT, where int is wide enough.
327 (READ_BUF_SIZE): Verify that it fits in int.
328 (Finsert_file_contents): Check that counts are in proper range,
329 rather than assuming fixnums fit into ptrdiff_t etc.
330 Don't assume fixnums fit into int.
331 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
332 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
333 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
334 (string_char_to_byte, string_byte_to_char)
335 (string_make_multibyte, string_to_multibyte)
336 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
337 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
338 (substring_both, Fdelete, internal_equal, Ffillarray)
339 (Fclear_string, mapcar1)
340 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
341 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
342 (larger_vector, make_hash_table, maybe_resize_hash_table)
343 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
344 (Fmaphash, secure_hash):
345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
346 (concat): Check for string index and length overflow.
347 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
349 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
350 (larger_vector): New API (vec, incr_min, size_max) replaces old
351 one (vec, new_size, init). This catches size overflow.
352 INIT was removed because it was always Qnil.
354 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
355 the upper bound on a hash table index size.
356 (make_hash_table, maybe_resize_hash_table): Use it.
357 (secure_hash): Computer start_byte and end_byte only after
358 they're known to be in ptrdiff_t range.
359 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
360 (Ffont_get_glyphs, Ffont_at):
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
363 (Flist_fonts, Fopen_font):
364 Don't assume fixnum can fit in int.
365 (check_gstring): Don't assume index can fit in int.
366 (font_match_p): Check that fixnum is a character, not a nonnegative
367 fixnum, since the later code needs to stuff it into an int.
368 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
369 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
370 conversion overflow issues.
371 (Fopen_font): Check for integer out of range.
372 (Ffont_get_glyphs): Don't assume index can fit in int.
373 * font.h: Adjust decls to match defn changes elsewhere.
374 * fontset.c (reorder_font_vector): Redo score calculation to avoid
376 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
377 printmax_t, where ptrdiff_t is wide enough.
378 (Finternal_char_font):
379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
380 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
381 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
382 (Fset_frame_position, x_set_frame_parameters)
383 (x_set_line_spacing, x_set_border_width)
384 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
385 Check that fixnums are in proper range for system types.
386 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
389 Use SAFE_ALLOCA_LISP, not alloca.
390 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
391 intptr_t is wide enough.
392 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
393 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
394 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
395 Check for fixnum out of range.
396 * ftfont.c (ftfont_list): Don't assume index fits in int.
397 Check that fixnums are in proper range for system types.
398 (ftfont_shape_by_flt):
399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
400 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
402 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
403 Check that fixnums are in proper range for system types.
404 * gnutls.h: Adjust decls to match defn changes elsewhere.
405 * gtkutil.c (xg_dialog_run):
406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
407 (update_frame_tool_bar):
408 Check that fixnums are in proper range for system types.
409 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
410 (lookup_image): Check that fixnums are in range for system types.
411 * indent.c (last_known_column, last_known_column_point):
412 (current_column_bol_cache):
413 (skip_invisible, current_column, check_display_width):
414 (check_display_width, scan_for_column, current_column_1)
415 (Findent_to, Fcurrent_indentation, position_indentation)
416 (indented_beyond_p, Fmove_to_column, compute_motion):
417 (Fcompute_motion, Fvertical_motion):
418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
419 (last_known_column_modified): Use EMACS_INT, not int.
420 (check_display_width):
422 Check that fixnums and floats are in proper range for system types.
423 (compute_motion): Don't assume index or fixnum fits in int.
424 (compute_motion, Fcompute_motion):
425 Use int, not EMACS_INT, when it is wide enough.
426 (vmotion): Omit local var start_hpos that is always 0; that way
427 we don't need to worry about overflow in expressions involving it.
428 * indent.h: Adjust decls to match defn changes elsewhere.
430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
431 Use int, not EMACS_INT, where int is wide enough.
432 Remove unused members ovstring_chars_done and tab_offset;
434 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
435 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
436 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
437 (make_gap, copy_text, insert, insert_and_inherit)
438 (insert_before_markers, insert_before_markers_and_inherit)
439 (insert_1, count_combining_before, count_combining_after)
440 (insert_1_both, insert_from_string)
441 (insert_from_string_before_markers, insert_from_string_1)
442 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
443 (adjust_after_replace, adjust_after_insert, replace_range)
444 (replace_range_2, del_range, del_range_1, del_range_byte)
445 (del_range_both, del_range_2, modify_region)
446 (prepare_to_modify_buffer, signal_before_change)
447 (signal_after_change, Fcombine_after_change_execute):
448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
449 * intervals.c (traverse_intervals, rotate_right, rotate_left)
450 (balance_an_interval, split_interval_right, split_interval_left)
451 (find_interval, next_interval, update_interval)
452 (adjust_intervals_for_insertion, delete_node, delete_interval)
453 (interval_deletion_adjustment, adjust_intervals_for_deletion)
454 (static_offset_intervals, offset_intervals)
455 (merge_interval_right, merge_interval_left, make_new_interval)
456 (graft_intervals_into_buffer, temp_set_point_both)
457 (temp_set_point, set_point, adjust_for_invis_intang)
458 (set_point_both, move_if_not_intangible, get_property_and_range)
459 (get_local_map, copy_intervals, copy_intervals_to_string)
460 (compare_string_intervals, set_intervals_multibyte_1):
461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
462 * intervals.h: Adjust decls to match defn changes elsewhere.
464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
465 * keyboard.c (this_command_key_count, this_single_command_key_start)
466 (before_command_key_count, before_command_echo_length, echo_now)
467 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
468 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
469 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
470 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
472 (last_non_minibuf_size, last_point_position, echo_truncate)
473 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
474 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
475 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
476 (stuff_buffered_input):
477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
478 (last_auto_save, command_loop_1, read_char):
479 Use EMACS_INT, not int, to avoid integer overflow.
480 (record_char): Avoid overflow in total_keys computation.
481 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
482 * keyboard.h: Adjust decls to match defn changes elsewhere.
483 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
484 (Fkey_description, Fdescribe_vector, Flookup_key):
485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
486 (click_position): New function, to check that positions are in range.
487 (Fcurrent_active_maps):
489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
490 (Faccessible_keymaps, Fkey_description):
491 (preferred_sequence_p):
492 Don't assume fixnum can fit into int.
493 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
494 Check for integer overflow in size calculations.
495 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
496 avoid mishandling large integers.
497 * lisp.h: Adjust decls to match defn changes elsewhere.
498 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
499 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
500 (struct Lisp_Marker):
501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
502 (clip_to_bounds): Now an inline function, moved here from editfns.c.
503 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
504 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
506 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
507 Assume the arg has valid form, since it always does.
508 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
509 unsigned integer system type.
510 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
511 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
513 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
514 (duration_to_sec_usec): New decl.
515 * lread.c (read_from_string_index, read_from_string_index_byte)
516 (read_from_string_limit, readchar, unreadchar, openp)
517 (read_internal_start, read1, oblookup):
518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
519 (Fload, readevalloop, Feval_buffer, Feval_region):
520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
521 (openp): Check for out-of-range argument to 'access'.
522 (read1): Use int, not EMACS_INT, where int is wide enough.
523 Don't assume fixnum fits into int.
524 Fix off-by-one error that can read outside a buffer.
525 (read_filtered_event): Use duration_to_sec_usec
526 to do proper overflow checking on durations.
527 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
529 (Fexecute_kbd_macro):
530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
531 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
532 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
533 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
534 (set_marker_both, set_marker_restricted_both, marker_position)
535 (marker_byte_position, Fbuffer_has_markers_at):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
538 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
539 It now merely ensures that the menu is large enough, without
540 necessarily growing it, as this avoids some integer overflow issues.
542 (keymap_panes, parse_single_submenu, Fx_popup_menu):
543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
544 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
545 Use SAFE_ALLOCA_LISP, not alloca.
546 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
547 to EMACS_INT. Check that fixnums are in proper range for system types.
548 * minibuf.c (minibuf_prompt_width, string_to_object)
549 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
550 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
552 (get_minibuffer, read_minibuf_unwind):
553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
554 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
555 this simplifies overflow checking. All callers changed.
556 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
559 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
560 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
561 Check that fixnums are in proper range for system types.
562 (Fx_create_frame, Fx_show_tip):
563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
564 * nsfont.m (ns_findfonts, nsfont_list_family):
565 Don't assume fixnum fits in long.
566 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
568 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
570 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
572 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
573 (PRINTDECLARE, PRINTPREPARE):
574 (strout, print_string):
575 (print, print_preprocess, print_check_string_charset_prop)
577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
579 (temp_output_buffer_setup, Fprin1_to_string, print_object):
580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
581 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
582 (printchar, strout): Use xpalloc to catch size calculation overflow.
583 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
584 (print_error_message): Use SAFE_ALLOCA, not alloca.
585 (print_object): Use int, not EMACS_INT, where int is wide enough.
586 (print_depth, new_backquote_output, print_number_index):
587 Use ptrdiff_t, not int, where int might not be wide enough.
588 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
589 (Fset_process_window_size, Fformat_network_address)
590 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
592 Check that fixnums are in proper range for system types.
593 (Fsignal_process): Simplify by avoiding a goto.
594 Check for process-ids out of pid_t range rather than relying on
596 (process_tick, update_tick): Use EMACS_INT, not int.
597 (Fformat_network_address, read_process_output, send_process)
598 (Fprocess_send_region, status_notify):
599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
600 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
601 (wait_reading_process_output, read_process_output, exec_sentinel):
602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
603 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
604 (Faccept_process_output): Use duration_to_sec_usec to do proper
605 overflow checking on durations.
606 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
607 Don't assume pid_t fits in int.
608 * process.h (struct Lisp_Process): Members tick and update_tick
609 are now of type EMACS_INT, not int.
610 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
611 configured --with-wide-int.
612 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
613 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
614 * search.c (looking_at_1, string_match_1):
615 (fast_string_match, fast_c_string_match_ignore_case)
616 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
617 (scan_newline, find_before_next_newline, search_command)
618 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
619 (set_search_regs, wordify):
622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
623 (string_match_1, search_buffer, set_search_regs):
625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
626 (wordify): Check for overflow in size calculation.
627 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
628 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
629 Check that fixnums are in proper range for system types.
630 * sound.c (struct sound_device)
631 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
633 (Fplay_sound_internal):
634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
635 * syntax.c (struct lisp_parse_state, find_start_modiff)
636 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
637 (Fparse_partial_sexp):
638 Don't assume fixnums can fit in int.
639 (struct lisp_parse_state, find_start_pos, find_start_value)
640 (find_start_value_byte, find_start_begv)
641 (update_syntax_table, char_quoted, dec_bytepos)
642 (find_defun_start, prev_char_comend_first, back_comment):
643 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
644 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
646 (Finternal_describe_syntax_value): Check that match_lisp is a
647 character, not an integer, since the code stuffs it into int.
648 (scan_words, scan_sexps_forward):
649 Check that fixnums are in proper range for system types.
651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
652 (scan_sexps_forward):
653 Use CHARACTERP, not INTEGERP, since the value must fit into int.
654 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
655 * syntax.h: Adjust decls to match defn changes elsewhere.
657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
658 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
659 MOST_POSITIVE_FIXNUM.
660 * sysdep.c (wait_for_termination_1, wait_for_termination)
661 (interruptible_wait_for_termination, mkdir):
662 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
663 (emacs_read, emacs_write):
664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
665 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
666 and double all fit in int.
667 * term.c (set_tty_color_mode):
668 Check that fixnums are in proper range for system types.
669 * termhooks.h (struct input_event):
670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
671 * textprop.c (validate_interval_range, interval_of)
672 (Fadd_text_properties, set_text_properties_1)
673 (Fremove_text_properties, Fremove_list_of_text_properties)
674 (Ftext_property_any, Ftext_property_not_all)
675 (copy_text_properties, text_property_list, extend_property_ranges)
676 (verify_interval_modification):
677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
678 (Fnext_single_char_property_change)
679 (Fprevious_single_char_property_change):
680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
681 (copy_text_properties):
682 Check for integer overflow in index calculation.
683 * undo.c (last_boundary_position, record_point, record_insert)
684 (record_delete, record_marker_adjustment, record_change)
685 (record_property_change):
686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
687 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
689 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
690 (Fx_hide_tip, Fx_file_dialog):
691 * w32menu.c (set_frame_menubar):
692 Use ptrdiff_t, not int, for consistency with rest of code.
693 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
694 (select_window, Fdelete_other_windows_internal)
695 (window_scroll_pixel_based, window_scroll_line_based)
696 (Frecenter, Fset_window_configuration):
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 (Fset_window_hscroll, run_window_configuration_change_hook)
699 (set_window_buffer, temp_output_buffer_show, scroll_command)
700 (Fscroll_other_window, Frecenter):
701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
702 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
703 Don't assume fixnum fits in int.
704 (Fset_window_scroll_bars):
705 Check that fixnums are in proper range for system types.
706 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
707 (string_pos, c_string_pos, number_of_chars, init_iterator)
708 (in_ellipses_for_invisible_text_p, init_from_display_pos)
709 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
710 (compute_display_string_end, handle_face_prop)
711 (face_before_or_after_it_pos, handle_invisible_prop)
712 (handle_display_prop, handle_display_spec, handle_single_display_spec)
713 (display_prop_intangible_p, string_buffer_position_lim)
714 (string_buffer_position, handle_composition_prop, load_overlay_strings)
715 (get_overlay_strings_1, get_overlay_strings)
716 (iterate_out_of_display_property, forward_to_next_line_start)
717 (back_to_previous_visible_line_start, reseat, reseat_to_string)
718 (get_next_display_element, set_iterator_to_next)
719 (get_visually_first_element, compute_stop_pos_backwards)
720 (handle_stop_backwards, next_element_from_buffer)
721 (move_it_in_display_line_to, move_it_in_display_line)
722 (move_it_to, move_it_vertically_backward, move_it_by_lines)
723 (add_to_log, message_dolog, message_log_check_duplicate)
724 (message2, message2_nolog, message3, message3_nolog
725 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
726 (current_message_1, truncate_echo_area, truncate_message_1)
727 (set_message, set_message_1, store_mode_line_noprop)
728 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
729 (text_outside_line_unchanged_p, check_point_in_composition)
730 (reconsider_clip_changes)
731 (redisplay_internal, set_cursor_from_row, try_scrolling)
732 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
733 (redisplay_window, find_last_unchanged_at_beg_row)
734 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
735 (trailing_whitespace_p, find_row_edges, display_line)
736 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
737 (display_mode_element, store_mode_line_string)
738 (pint2str, pint2hrstr, decode_mode_spec)
739 (display_count_lines, display_string, draw_glyphs)
740 (x_produce_glyphs, x_insert_glyphs)
741 (rows_from_pos_range, mouse_face_from_buffer_pos)
742 (fast_find_string_pos, mouse_face_from_string_pos)
743 (note_mode_line_or_margin_highlight, note_mouse_highlight):
744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
745 (safe_call, init_from_display_pos, handle_fontified_prop)
746 (handle_single_display_spec, load_overlay_strings)
747 (with_echo_area_buffer, setup_echo_area_for_printing)
748 (display_echo_area, echo_area_display)
749 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
750 (update_tool_bar, hscroll_window_tree, redisplay_internal)
751 (redisplay_window, dump_glyph_row, display_mode_line)
752 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
753 (handle_display_spec, display_prop_string_p):
754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
755 (handle_single_display_spec, build_desired_tool_bar_string)
756 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
757 (get_specified_cursor_type):
758 Check that fixnums are in proper range for system types.
759 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
761 Don't assume fixnums fit in int.
762 (compare_overlay_entries):
763 Avoid mishandling comparisons due to subtraction overflow.
764 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
765 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
766 (handle_tool_bar_click):
767 Use int, not unsigned, since we prefer signed and the signedness
769 (get_next_display_element, next_element_from_display_vector):
770 Use int, not EMACS_INT, when int is wide enough.
771 (start_hourglass): Use duration_to_sec_usec to do proper
772 overflow checking on durations.
773 * xfaces.c (Fbitmap_spec_p):
774 Check that fixnums are in proper range for system types.
775 (compare_fonts_by_sort_order):
776 Avoid mishandling comparisons due to subtraction overflow.
777 (Fx_family_fonts, realize_basic_faces):
778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
780 Don't assume fixnum fits in int.
781 Use SAFE_ALLOCA_LISP, not alloca.
782 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
783 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
784 (face_at_buffer_position, face_for_overlay_string)
785 (face_at_string_position):
786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
787 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
788 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
790 Check that fixnums are in proper range for system types.
791 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
792 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
794 (Fx_change_window_property): Don't assume fixnums fit in int.
795 * xfont.c (xfont_chars_supported):
796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
797 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
798 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
800 * xml.c (parse_region):
801 * xrdb.c (magic_file_p):
802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
803 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
804 (x_get_local_selection, x_reply_selection_request)
805 (x_handle_selection_request, wait_for_property_change):
806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
807 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
808 short is wide enough.
809 (x_send_client_event): Don't assume fixnum fits in int.
810 * xterm.c (x_x_to_emacs_modifiers):
811 Don't assume EMACS_INT overflows nicely into int.
812 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
814 (handle_one_xevent): NATNUMP can eval its arg twice.
815 (x_connection_closed):
816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
817 * xterm.h: Adjust decls to match defn changes elsewhere.
818 (struct scroll_bar): Use struct vectorlike_header
819 rather than rolling our own approximation.
820 (SCROLL_BAR_VEC_SIZE): Remove; not used.
822 2012-05-25 Glenn Morris <rgm@gnu.org>
824 * lisp.mk (lisp): Update for more files being compiled now.
826 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
828 * lread.c: Remove `read_pure' which makes no difference.
829 (read_pure): Remove var.
830 (unreadpure): Remove function.
831 (readevalloop): Don't call read_list with -1 flag.
832 (read1, read_vector): Don't test read_pure any more.
833 (read_list): Simplify.
835 * fileio.c, character.h: Minor style tweaks.
837 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
839 * window.h (clip_changed): Remove useless declaration.
841 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
843 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
844 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
846 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
849 This directory predates autoconf and is no longer needed nowadays.
850 Move its few remaining bits of functionality to where they're needed.
851 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
852 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
853 * m/template.h: Remove.
854 * Makefile.in (M_FILE): Remove. All uses removed.
855 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
856 * lisp.h (USE_LSB_TAG):
857 * mem-limits.h (EXCEEDS_LISP_PTR):
858 Use VAL_MAX, not VALBITS, in #if.
859 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
860 (EMACS_UINT): Define unconditionally now.
861 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
862 (BITS_PER_EMACS_INT): New constants, replacing
863 what used to be in config.h, but not useful in #if.
864 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
865 define them any more.
866 (VAL_MAX): New macro.
868 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
869 BITS_PER_EMACS_INT, in #if.
870 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
871 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
872 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
873 * s/ms-w32.h (DATA_START):
874 Move here from removed file m/intel386.h.
875 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
876 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
878 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
881 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
882 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
884 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
885 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
886 * textprop.c, tparam.c (NULL): Remove.
887 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
888 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
889 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
890 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
891 * xterm.c (input_signal_count): Assume volatile works.
893 2012-05-21 Ken Brown <kbrown@cornell.edu>
895 * xgselect.c (xg_select): Fix first argument in call to 'select'
898 2012-05-20 Ken Brown <kbrown@cornell.edu>
900 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
901 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
903 2012-05-19 Ken Brown <kbrown@cornell.edu>
905 * xfns.c (x_in_use): Remove `static' qualifier.
906 * xterm.h (x_in_use): Declare.
907 * xgselect.c: Include xterm.h.
908 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
909 and `display_arg' (bug#9754).
911 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
913 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
915 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
916 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
918 2012-05-18 Eli Zaretskii <eliz@gnu.org>
920 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
922 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
923 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
925 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
926 reference to image_cache->refcount.
927 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
929 2012-05-17 Juri Linkov <juri@jurta.org>
931 * search.c (Fword_search_regexp, Fword_search_backward)
932 (Fword_search_forward, Fword_search_backward_lax)
933 (Fword_search_forward_lax): Move functions to isearch.el
934 (bug#10145, bug#11381).
936 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
938 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
940 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
942 * lread.c (init_obarray): Declare Qt and Qnil as special.
944 2012-05-14 Glenn Morris <rgm@gnu.org>
946 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
947 Put "libexec" before "bin", for the sake of init_callproc_1.
949 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
951 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
953 * unexaix.c: Port to more-recent AIX compilers.
954 (report_error, report_error_1, make_hdr, copy_sym)
955 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
956 Make arguments const char *, not char *, to avoid violations of C
957 standard and to fix some AIX warnings reported by Gilles Pion.
959 2012-05-14 Eli Zaretskii <eliz@gnu.org>
961 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
962 already have overlays loaded.
963 (handle_single_display_spec): Before returning without displaying
964 fringe bitmap, synchronize the bidi iterator with the main display
965 iterator, by calling iterate_out_of_display_property.
966 (iterate_out_of_display_property): Detect buffer iteration by
967 testing that it->string is a Lisp string.
968 (get_next_display_element): When the current object is exhausted,
969 and there's something on it->stack, call set_iterator_to_next to
970 proceed with what's on the stack, instead of returning zero.
971 (set_iterator_to_next): If called at the end of a Lisp string,
972 proceed to consider_string_end without incrementing string
973 position. Don't increment display vector index past the end of
974 the display vector. (Bug#11417)
975 (pos_visible_p): Don't report a position visible when move_it_to
976 stopped at the last line of window, which happens to be scanned
977 backwards by the bidi iteration. (Bug#11464)
979 2012-05-14 Eli Zaretskii <eliz@gnu.org>
981 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
982 and right-margin display specs even if the spec is invalid or we
983 are on a TTY, and thus unable to display on the fringes. That's
984 because the text with the property will not be displayed anyway,
985 so we need to signal to the caller that this is a "replacing"
986 display spec. This fixes display when the spec is invalid or we
989 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
991 * unexaix.c (make_hdr): Fix typo in prototype.
992 This bug broke the build on AIX. Problem reported by Gilles Pion.
994 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
996 * keyboard.c (kbd_buffer_get_event): Read special events also in
997 batch mode. (Bug#11415)
999 2012-05-12 Glenn Morris <rgm@gnu.org>
1001 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1003 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1005 * lisp.mk (lisp): Add newcomment.elc.
1007 2012-05-12 Glenn Morris <rgm@gnu.org>
1009 * Makefile.in (MKDIR_P): New, set by configure.
1010 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1012 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1014 Remove unused function hourglass_started.
1015 * dispextern.h (hourglass_started):
1016 * w32fns.c (hourglass_started):
1017 * xdisp.c (hourglass_started): Remove.
1019 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1021 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1022 Update dependencies.
1024 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1026 * xgselect.c (xg_select): Put maxfds+1 into a var.
1027 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1029 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1031 2012-05-10 Dave Abrahams <dave@boostpro.com>
1033 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1034 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1036 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1038 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1039 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1040 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1041 Initialize xd_registered_buses.
1043 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1045 Untag more efficiently if USE_LSB_TAG.
1046 This is based on a proposal by YAMAMOTO Mitsuharu in
1047 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1048 For an admittedly artificial (nth 8000 longlist) benchmark on
1049 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1050 Emacs's overall text size by 1%.
1051 * lisp.h (XUNTAG): New macro.
1052 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1053 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1054 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1055 * eval.c (Fautoload):
1056 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1057 * frame.h (XFRAME): Use XUNTAG.
1059 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1060 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1061 Remove unportable assumptions about print widths of types like
1063 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1064 intptr_t when converting between pointer and integer, to avoid GCC
1065 warnings about wrong width.
1067 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1069 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1070 stack for each reader_thread, instead of defaulting to 8MB
1071 determined by the linker. This avoids failures in creating
1072 subprocesses on Windows 7, see the discussion in this thread:
1073 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1075 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1077 Fix up display of the *Minibuf-0* buffer in the mini window.
1078 * keyboard.c (read_char): Don't clear the echo area if there's no
1080 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1081 contents of *Minibuf-0*) if there's no message displayed in its stead.
1083 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1085 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1088 2012-05-06 Chong Yidong <cyd@gnu.org>
1090 * lisp.mk (lisp): Update.
1092 2012-05-05 Jim Meyering <meyering@redhat.com>
1094 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1096 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1098 * data.c (PUT_ERROR): New macro.
1099 (syms_of_data): Use it. Add new error type `user-error'.
1100 * undo.c (user_error): New function.
1101 (Fprimitive_undo): Use it.
1102 * print.c (print_error_message): Adjust print style for `user-error'.
1103 * keyboard.c (user_error): New function.
1104 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1106 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1108 Do not limit current-time-string to years 1000..9999.
1109 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1110 (Fcurrent_time_string): Support any year that is supported by the
1111 underlying localtime representation. Don't use asctime, as it
1112 has undefined behavior for years outside the range -999..9999.
1114 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1116 Fix race conditions involving setenv, gmtime, localtime, asctime.
1117 Without this fix, interrupts could mess up code that uses these
1118 nonreentrant functions, since setting TZ invalidates existing
1119 tm_zone or tzname values, and since most of these functions return
1120 pointers to static storage.
1121 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1122 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1123 Grow the critical sections to include not just invoking
1124 localtime/gmtime, but also accessing these functions' results
1125 including their tm_zone values if any, and any related TZ setting.
1126 (format_time_string): Last arg is now struct tm *, not struct tm **,
1127 so that the struct tm is saved in the critical section.
1128 All callers changed. Simplify allocation of initial buffer, partly
1129 motivated by the fact that memory allocation needs to be outside
1130 the critical section.
1132 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1134 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1135 with RESET_INTERVAL.
1137 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1138 Remove duplicated buffer name initialization.
1140 2012-05-02 Jim Meyering <jim@meyering.net>
1142 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1144 * xfns.c (x_window): Use xstrdup (Bug#11375).
1146 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1148 * xdisp.c (pos_visible_p): If already at a newline from the
1149 display string before the 'while' loop, don't walk back the glyphs
1150 from it3.glyph_row. Solves assertion violation when the display
1151 string begins with a newline (egg.el). (Bug#11367)
1153 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1155 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1158 2012-05-01 Glenn Morris <rgm@gnu.org>
1160 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1161 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1162 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1163 All were removed before 23.1.
1165 * dispnew.c: Remove HAVE_LIBNCURSES test;
1166 it is always true on relevant platforms.
1168 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1169 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1171 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1173 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1175 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1176 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1179 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1181 Do not avoid creating empty evaporating overlays (Bug#9642).
1182 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1183 That is, do not delete an evaporating overlay if it becomes
1184 empty after its bounds are adjusted to fit within its buffer.
1185 This fix caused other problems, and I'm reverting it until we get
1186 to the bottom of them.
1188 2012-04-27 Chong Yidong <cyd@gnu.org>
1190 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1192 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1194 * xdisp.c (pos_visible_p): If the window start position is beyond
1195 ZV, start the display from buffer beginning. Prevents assertion
1196 violation in init_iterator when the minibuffer window is scrolled
1199 * window.c (window_scroll_pixel_based): Likewise.
1201 2012-04-27 Chong Yidong <cyd@gnu.org>
1203 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1205 2012-04-27 Glenn Morris <rgm@gnu.org>
1207 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1208 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1210 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1212 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1213 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1215 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1217 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1218 display element, check also the underlying string or buffer
1219 character. (Bug#11341)
1221 * w32menu.c: Include w32heap.h.
1222 (add_menu_item): If the call to AppendMenuW (via
1223 unicode_append_menu) fails, disable Unicode menus only if we are
1224 running on Windows 9X/Me.
1226 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1228 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1229 (xgetint): Add missing shift for LSB tags.
1231 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1233 * keyboard.c (read_char): Don't wipe echo area for select window
1234 events: These might get delayed via `mouse-autoselect-window'
1237 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1239 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1240 manipulation of :loaded-from data.
1242 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1244 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1245 now a cons (bug#11311).
1247 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1249 Do not create empty overlays with the evaporate property (Bug#9642).
1250 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1251 if it becomes empty after its bounds are adjusted to fit within
1252 its buffer. Without this fix, in a nonempty buffer (let ((o
1253 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1254 yields an empty overlay that has the evaporate property, which is
1255 not supposed to happen.
1257 Fix minor GTK3 problems found by static checking.
1258 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1259 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1260 (struct _EmacsFixedClass, emacs_fixed_get_type):
1261 Move decls here from emacsgtkfixed.h, since they needn't be public.
1262 (emacs_fixed_get_type): Now static.
1263 (emacs_fixed_class_init): Omit unused local.
1264 (emacs_fixed_child_type): Remove; unused.
1265 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1266 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1267 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1268 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1269 (EMACS_FIXED_GET_CLASS): Remove; unused.
1270 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1272 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1273 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1275 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1277 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1278 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1279 (__malloc_size_t, __malloc_ptrdiff_t):
1280 Remove. All uses removed, replaced by the definiens if needed,
1281 since we can assume C89 or better now.
1282 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1283 (protect_malloc_state, align, get_contiguous_space)
1284 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1285 (malloc_atfork_handler_child, malloc_enable_thread)
1286 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1287 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1288 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1289 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1290 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1291 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1292 Define using prototypes, not old style.
1293 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1294 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1295 (align): Don't assume that signed integer overflow wraps around.
1296 Omit unused local var.
1297 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1298 (_free_internal_nolock, memalign, mallochook, reallochook):
1299 Omit no-longer-needed casts.
1300 (valloc): Use getpagesize, not __getpagesize.
1301 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1302 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1304 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1306 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1308 Move functions from C to Lisp. Make non-blocking method calls
1309 the default. Implement further D-Bus standard interfaces.
1311 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1312 (QCdbus_request_name_allow_replacement)
1313 (QCdbus_request_name_replace_existing)
1314 (QCdbus_request_name_do_not_queue)
1315 (QCdbus_request_name_reply_primary_owner)
1316 (QCdbus_request_name_reply_in_queue)
1317 (QCdbus_request_name_reply_exists)
1318 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1319 (QCdbus_registered_serial, QCdbus_registered_method)
1320 (QCdbus_registered_signal): New Lisp objects.
1321 (XD_DEBUG_MESSAGE): Use sizeof.
1322 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1323 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1324 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1325 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1326 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1327 (xd_signature, xd_append_arg): Allow float for integer types.
1328 (xd_get_connection_references): New function.
1329 (xd_get_connection_address): Rename from xd_initialize.
1330 Return cached address.
1331 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1332 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1334 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1335 Return number of refcounts.
1336 (Fdbus_get_unique_name): Make stronger parameter check.
1337 (Fdbus_message_internal): New defun.
1338 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1339 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1340 (Fdbus_send_signal, Fdbus_register_service)
1341 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1342 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1343 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1344 (Vdbus_compiled_version, Vdbus_runtime_version)
1345 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1346 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1347 (Vdbus_message_type_signal): New defvars.
1348 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1351 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1353 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1354 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1355 Do not assume ptrdiff_t is the same width as 'int'.
1357 * alloc.c: Handle unusual debugging option combinations.
1358 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1359 since the two debugging options are incompatible.
1360 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1362 (mem_init, mem_insert, mem_insert_fixup):
1363 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1364 (NEED_MEM_INSERT): Remove; no longer needed.
1366 2012-04-22 Leo Liu <sdl.web@gmail.com>
1368 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1370 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1372 * sysdep.c [__FreeBSD__]: Minor cleanups.
1373 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1374 Use Emacs indenting style more consistently. Avoid some casts.
1375 Use 'double' consistently rather than mixing 'float' and 'double'.
1377 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1379 * sysdep.c (list_system_processes, system_process_attributes):
1380 Add implementation for FreeBSD (Bug#5243).
1382 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1384 * lisp.mk (lisp): Update.
1386 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1388 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1389 It is never used otherwise.
1391 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1393 * print.c (print_preprocess): Only check print_depth if print-circle
1395 (print_object): Check for cycles even when print-circle is nil and
1396 print-gensym is t, but only check print_depth if print-circle is nil.
1398 2012-04-20 Chong Yidong <cyd@gnu.org>
1400 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1401 set the status to "failed" and ensure that sentinel is run.
1403 2012-04-20 Glenn Morris <rgm@gnu.org>
1405 * process.c (Fset_process_inherit_coding_system_flag)
1406 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1407 (Fmake_network_process, Fmake_serial_process): Doc fix.
1409 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1411 * xdisp.c (string_buffer_position_lim): Limit starting position to
1413 (set_cursor_from_row): If called for a mode-line or header-line
1414 row, return zero immediately.
1415 (try_cursor_movement): If inside continuation line, don't back up
1416 farther than the first row after the header line, if any.
1417 Don't consider the header-line row as "partially visible", even if
1418 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1420 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1422 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1425 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1426 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1428 configure: new option --enable-gcc-warnings (Bug#11207)
1429 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1430 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1431 (ALL_CFLAGS): Use new macros rather than old.
1432 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1433 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1434 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1435 -Wunused-result, -Wunused-variable. This should go away once
1436 the Emacs and Gnulib regex code is merged.
1437 (xmalloc, xrealloc): Now static.
1439 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1441 * dired.c (Fsystem_groups): Remove unused local.
1443 2012-04-17 Glenn Morris <rgm@gnu.org>
1445 * dired.c (Fsystem_users): Doc fix.
1447 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1449 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1450 (syms_of_dired): Add them.
1452 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1454 Fix minor alloc.c problems found by static checking.
1455 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1456 New extern decls, to avoid calling undeclared functions.
1457 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1458 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1459 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1460 (NEED_MEM_INSERT): New macro.
1461 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1462 Remove one incorrect comment and fix another.
1464 Fix minor ralloc.c problems found by static checking.
1465 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1466 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1467 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1468 (r_alloc_sbrk): Now static.
1470 Improve ralloc.c interface checking.
1471 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1472 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1473 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1474 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1475 [REL_ALLOC]: ... to here, to check interface.
1476 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1477 Remove decls. This fixes an "It stinks!".
1479 * alloc.c (which_symbols): Fix alignment issue / type clash.
1481 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1483 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1484 (struct Lisp_Misc_Any): Likewise.
1485 (struct Lisp_Free): Likewise.
1486 * alloc.c (union aligned_Lisp_Symbol): Define.
1487 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1488 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1489 (union aligned_Lisp_Misc): Define.
1490 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1491 aligned_Lisp_Misc instead of union Lisp_Misc.
1492 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1494 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1496 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1497 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1498 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1499 * s/netbsd.h, s/sol2-6.h:
1500 Remove definition of GC_MARK_STACK, since the default now works.
1501 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1502 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1503 no longer the default.
1504 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1506 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1508 * lread.c (lisp_file_lexically_bound_p):
1509 Fix hang at ";-*-\n" (bug#11238).
1511 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1513 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1514 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1516 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1518 * nsterm.m (constrainFrameRect): Always constrain when there is only
1519 one screen (Bug#10962).
1521 2012-04-13 Ken Brown <kbrown@cornell.edu>
1523 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1525 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1527 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1529 2012-04-11 Daniel Colascione <dancol@dancol.org>
1531 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1532 against is gone. It's better to use vfork now so that when Cygwin
1533 gains a new, working vfork, we use it automatically (bug#10398).
1535 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1537 * window.c (save_window_save): Obey window-point-insertion-type.
1539 2012-04-11 Glenn Morris <rgm@gnu.org>
1541 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1543 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1545 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1547 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1549 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1550 (force_quit_count): New var.
1551 (handle_interrupt): Use it.
1553 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1555 * w32.c (w32_delayed_load): Record the full path of the library
1556 being loaded (bug#10424).
1558 2012-04-09 Glenn Morris <rgm@gnu.org>
1560 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1561 not just in the obarray, before snarfing them. (Bug#11036)
1563 * Makefile.in ($(leimdir)/leim-list.el):
1564 Pass EMACS rather than BUILT_EMACS.
1566 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1568 * process.c (make_process):
1569 * process.h: Add integer `gnutls_handshakes_tried' member to
1572 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1573 Add convenience `GNUTLS_LOG2i' macro.
1575 * gnutls.c (gnutls_log_function2i): Convenience log function.
1576 (emacs_gnutls_read): Use new log functions,
1577 `gnutls_handshakes_tried' process member, and
1578 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1579 attempts per process (connection).
1581 2012-04-09 Chong Yidong <cyd@gnu.org>
1583 * eval.c (Fuser_variable_p, user_variable_p_eh)
1584 (lisp_indirect_variable): Functions deleted.
1585 (Fdefvar): Caller changed.
1587 * callint.c (Finteractive, Fcall_interactively):
1588 * minibuf.c (Fread_variable): Callers changed.
1590 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1592 * xdisp.c (set_cursor_from_row): If the display string appears in
1593 the buffer at position that is closer to point than the position
1594 after the display string, display the cursor on the first glyph of
1595 the display string. Fixes cursor display when a 'display' text
1596 property immediately follows invisible text. (Bug#11094)
1598 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1600 composite.c: use 'double' consistently
1601 * composite.c (get_composition_id): Use 'double' consistently
1602 instead of converting 'float' to 'double' and vice versa; this is
1603 easier to understand and avoids a GCC warning.
1605 2012-04-09 Glenn Morris <rgm@gnu.org>
1607 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1608 preparation for dumping it with emacs. (Bug#4789)
1609 (leimdir): New variable.
1610 ($(leimdir)/leim-list.el): New rule.
1611 (emacs$(EXEEXT)): Depend on leim-list.el.
1613 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1614 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1615 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1617 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1619 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1622 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1624 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1625 Remove unused local variable.
1627 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1629 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1630 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1631 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1632 objects, as mark_maybe_pointer will catch them otherwise.
1633 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1634 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1636 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1638 Fix typo that broke non-Windows builds.
1639 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1641 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1643 Support building on MS-Windows with libxml2.
1645 * makefile.w32-in (OBJ2): Add xml.$(O).
1646 (GLOBAL_SOURCES): Add xml.c.
1647 ($(BLD)/xml.$(O)): New dependency list.
1649 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1650 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1651 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1652 [!WINDOWSNT]: New macros.
1653 (init_libxml2_functions, libxml2_loaded_p): New functions.
1654 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1655 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1656 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1657 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1659 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1660 Call init_libxml2_functions before calling libxml2 functions.
1661 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1663 * emacs.c: Don't include libxml/parser.h.
1664 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1665 xmlCleanupParser directly.
1667 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1669 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1671 * indent.c (Fvertical_motion): If there is a display string at
1672 point, use it.vpos to compute how many lines to backtrack after
1673 move_it_to point. (Bug#11133)
1675 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1677 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1678 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1679 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1680 macros related to unification of CJK characters. For the details,
1681 see the discussion following the message here:
1682 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1684 2012-04-04 Chong Yidong <cyd@gnu.org>
1686 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1688 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1690 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1691 instead of alloca. (Bug#11138)
1693 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1695 * w32menu.c (is_simple_dialog): Properly check lisp types.
1698 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1700 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1701 position we get to after a call to move_it_to fails the
1702 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1703 only if we wind up in a string from display property. (Bug#11063)
1705 * window.c (Fdelete_other_windows_internal): Invalidate the row
1706 and column information about mouse highlight, so that redisplay
1707 restores it after reallocating the glyph matrices. (Bug#7464)
1709 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1710 string comes from a `display' text property, use the buffer
1711 position of that property as if we actually saw that position in
1713 (move_it_by_lines): Remove the assertion that
1714 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1715 violated when there's a before-string at the beginning of a line.
1718 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1720 * xdisp.c (append_space_for_newline): If the default face was
1721 remapped, use the remapped face for the appended newline.
1722 (extend_face_to_end_of_line): Use the remapped default face for
1723 extending the face to the end of the line.
1724 (display_line): Call extend_face_to_end_of_line when the default
1725 face was remapped. (Bug#11068)
1727 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1729 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1731 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1733 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1735 2012-03-27 Glenn Morris <rgm@gnu.org>
1737 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1740 2012-03-26 Kenichi Handa <handa@m17n.org>
1742 * dispextern.h (struct glyph): Fix previous change. Change the
1743 bit length of glyphless.ch to 25 (Bug#11082).
1745 2012-03-26 Chong Yidong <cyd@gnu.org>
1747 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1748 (command_loop_1): Use it; inhibit selection update for
1749 handle-select-window too (Bug#8996).
1751 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1753 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1755 2012-03-25 Kenichi Handa <handa@m17n.org>
1757 * dispextern.h (struct glyph): Change the bit length of
1758 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1760 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1762 * s/ms-w32.h (tzname): Include time.h before redirecting to
1763 _tzname. Fixes the MSVC build. (Bug#9960)
1765 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1767 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1770 * xterm.c (XTread_socket): Only modify handling_signal if
1771 !SYNC_INPUT. (Bug#11080)
1773 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1775 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1776 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1777 when fetching a multibyte character consumes more bytes than
1778 CHAR_BYTES returns, due to unification of CJK characters in
1779 string_char. (Bug#11073)
1781 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1783 * process.c (wait_reading_process_output): Handle pty disconnect
1784 by refraining from sending oneself a SIGCHLD (bug#10933).
1786 2012-03-22 Chong Yidong <cyd@gnu.org>
1788 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1790 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1791 Mark string as coming from a prefix property.
1792 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1793 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1795 2012-03-21 Chong Yidong <cyd@gnu.org>
1797 * xfaces.c (Vface_remapping_alist): Doc fix.
1799 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1801 * w32proc.c (Fw32_set_console_codepage)
1802 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1805 2012-03-20 Chong Yidong <cyd@gnu.org>
1807 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1808 to reflect default non-nil value of redisplay-dont-pause.
1810 2012-03-19 Kenichi Handa <handa@m17n.org>
1812 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1813 it fit in a valid range (Bug#11003).
1815 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1817 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1818 that is not from display property, accept the row as a "cursor
1819 row" if one of the string's character has a non-nil `cursor'
1820 property. Fixes cursor positioning when there are newlines in
1821 overlay strings, e.g. in icomplete.el. (Bug#11035)
1823 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1825 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1827 2012-03-12 Chong Yidong <cyd@gnu.org>
1829 * eval.c (inhibit_lisp_code): Rename from
1830 inhibit_window_configuration_change_hook; move from window.c.
1832 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1833 * window.c (run_window_configuration_change_hook)
1834 (syms_of_window): Callers changed.
1836 2012-03-11 Chong Yidong <cyd@gnu.org>
1838 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1840 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1842 2012-03-10 Chong Yidong <cyd@gnu.org>
1844 * frame.c (other_visible_frames): Don't assume the selected frame
1845 is visible (Bug#10955).
1847 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1849 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1851 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1853 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1854 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1857 2012-03-03 Glenn Morris <rgm@gnu.org>
1859 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1861 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1863 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1864 position past the first glyph_row that ends at ZV. (Bug#10902)
1865 (redisplay_window, next_element_from_string): Fix typos in
1867 (redisplay_window): Pass to move_it_vertically the margin in
1868 pixels, not in screen lines.
1870 2012-03-02 Glenn Morris <rgm@gnu.org>
1872 * buffer.c (buffer-list-update-hook): Doc fix.
1874 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1876 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1877 push_it before setting up the iterator for the first overlay
1878 string, even if we have an empty string loaded.
1879 (next_overlay_string): If there's an empty string on the iterator
1880 stack, pop the stack. (Bug#10903)
1882 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1884 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1885 Suggested by Stefan Monnier in
1886 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1887 * alloc.c (widen_to_Lisp_Object): New static function.
1888 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1889 and widening them to Lisp_Objects. This would work even if
1890 USE_LSB_TAG is defined and wide integers are used, which might
1891 happen in a future version of Emacs.
1893 2012-02-25 Chong Yidong <cyd@gnu.org>
1895 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1898 * xselect.c (Fx_selection_exists_p): Doc fix.
1899 (x_clipboard_manager_save_all): Print an informative message
1900 before saving to clipboard manager.
1902 2012-02-24 Chong Yidong <cyd@gnu.org>
1904 * keyboard.c (process_special_events): Handle all X selection
1905 requests in kbd_buffer, not just the next one (Bug#8869).
1907 2012-02-23 Chong Yidong <cyd@gnu.org>
1909 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1910 call when setting menu-bar-lines and tool-bar-lines parameters.
1911 (unwind_create_frame_1): New helper function.
1913 * window.c (inhibit_window_configuration_change_hook): New var.
1914 (run_window_configuration_change_hook): Obey it.
1915 (syms_of_window): Initialize it.
1917 2012-02-22 Chong Yidong <cyd@gnu.org>
1919 * xterm.c (x_draw_image_relief): Add missing type check for
1920 Vtool_bar_button_margin (Bug#10743).
1922 2012-02-21 Chong Yidong <cyd@gnu.org>
1924 * fileio.c (Vfile_name_handler_alist): Doc fix.
1926 * buffer.c (Fget_file_buffer): Protect against invalid file
1927 handler return value.
1929 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1931 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1932 when computing $valmask.
1934 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1935 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1936 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1937 It's useless in that case, and it can cause problems on hosts
1938 that allocate halves of EMACS_INT values separately.
1939 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1940 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1941 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1942 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1943 it avoids undefined behavior on hosts where shifting right by more
1944 than the word width has undefined behavior.
1946 2012-02-19 Chong Yidong <cyd@gnu.org>
1948 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1949 (Funhandled_file_name_directory, Ffile_name_as_directory)
1950 (Fdirectory_file_name, Fexpand_file_name)
1951 (Fsubstitute_in_file_name): Protect against invalid file handler
1952 return values (Bug#10845).
1954 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1956 * .gdbinit (pitx): Fix incorrect references to fields of the
1959 2012-02-17 Chong Yidong <cyd@gnu.org>
1961 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1963 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1965 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1966 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1968 2012-02-15 Chong Yidong <cyd@gnu.org>
1970 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1971 marked as special. Also, starting docstrings with * is obsolete.
1973 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1975 * gnutls.c (emacs_gnutls_write): Fix last change.
1977 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1979 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1982 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1984 * keymap.c (Fsingle_key_description): Handle char ranges.
1986 2012-02-12 Chong Yidong <cyd@gnu.org>
1988 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1989 as that creates a dangerous corner case.
1991 * window.c (Fdelete_window_internal): Invalidate the mouse
1992 highlight (Bug#9904).
1994 2012-02-12 Glenn Morris <rgm@gnu.org>
1996 * xselect.c (Fx_own_selection_internal)
1997 (Fx_get_selection_internal, Fx_disown_selection_internal)
1998 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1999 * nsselect.m (Fx_own_selection_internal)
2000 (Fx_disown_selection_internal, Fx_selection_exists_p)
2001 (Fx_selection_owner_p, Fx_get_selection_internal):
2002 Sync docs and argument specs with the xselect.c versions.
2004 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2006 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2008 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2010 * w32select.c (Fx_selection_exists_p): Sync doc string and
2011 argument list with xselect.c. (Bug#10783)
2013 * w16select.c (Fx_selection_exists_p): Sync doc string and
2014 argument list with xselect.c. (Bug#10783)
2016 2012-02-10 Glenn Morris <rgm@gnu.org>
2018 * fns.c (Fsecure_hash): Doc fix.
2020 2012-02-09 Kenichi Handa <handa@m17n.org>
2022 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2024 2012-02-07 Chong Yidong <cyd@gnu.org>
2026 * buffer.c (Fbuffer_local_variables)
2027 (buffer_lisp_local_variables): Handle unbound vars correctly;
2028 don't let Qunbound leak into Lisp.
2030 2012-02-07 Glenn Morris <rgm@gnu.org>
2032 * image.c (Fimagemagick_types): Doc fix.
2034 * image.c (imagemagick-render-type): Change it from a lisp object
2035 to an integer. Move the doc here from the lisp manual.
2036 Treat all values not equal to 0 the same.
2038 2012-02-06 Chong Yidong <cyd@gnu.org>
2040 * doc.c (store_function_docstring): Avoid applying docstring of
2041 alias to base function (Bug#2603).
2043 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2045 * .gdbinit (pp1, pv1): Remove redundant defines.
2048 2012-02-04 Chong Yidong <cyd@gnu.org>
2050 * nsterm.m: Declare a global (Bug#10694).
2052 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2054 * w32.c (get_emacs_configuration_options):
2055 Include --enable-checking, if specified, in the return value.
2057 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2059 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2060 after rounding frame sizes. (Bug#9723)
2062 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2064 * keyboard.c (adjust_point_for_property): Don't position point
2065 before BEGV. (Bug#10696)
2067 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2069 Handle overflow when computing char display width (Bug#9496).
2070 * character.c (char_width): Return EMACS_INT, not int.
2071 (char_width, c_string_width): Check for overflow when
2072 computing the width; this is possible now that individual
2073 characters can have unbounded width. Problem introduced
2074 by merge from Emacs 23 on 2012-01-19.
2076 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2078 * dbusbind.c (Fdbus_register_method): Mention the return value
2079 :ignore in the docstring.
2081 2012-02-02 Glenn Morris <rgm@gnu.org>
2083 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2085 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2086 Unconditionally set to t. (Bug#10673)
2087 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2088 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2089 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2091 2012-02-02 Kenichi Handa <handa@m17n.org>
2093 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2094 0, do not call append_composite_glyph.
2096 2012-02-02 Kenichi Handa <handa@m17n.org>
2098 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2100 (x_produce_glyphs): If the component of a composition is a null
2101 string, set it->pixel_width to 1 to avoid zero-width glyph.
2103 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2105 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2106 first 2 arguments are identical. This makes inserting large
2107 output from a subprocess an order of magnitude faster on
2108 MS-Windows, where all sbrk'ed memory is always contiguous.
2110 2012-01-31 Glenn Morris <rgm@gnu.org>
2112 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2113 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2114 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2116 2012-01-29 Glenn Morris <rgm@gnu.org>
2118 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2120 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2122 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2124 2012-01-28 Chong Yidong <cyd@gnu.org>
2126 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2128 2012-01-26 Chong Yidong <cyd@gnu.org>
2130 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2132 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2133 repeat counts (Bug#10507).
2135 2012-01-26 Glenn Morris <rgm@gnu.org>
2137 * lread.c (syms_of_lread): Doc fix.
2139 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2141 * coding.c (encode_designation_at_bol): Change return value to
2144 2012-01-25 Chong Yidong <cyd@gnu.org>
2146 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2148 2012-01-21 Chong Yidong <cyd@gnu.org>
2150 * floatfns.c (Fcopysign): Make the second argument non-optional,
2151 since nil is not allowed anyway.
2153 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2155 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2156 (send_process): Likewise.
2158 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2160 * window.c (save_window_save, Fcurrent_window_configuration)
2161 (Vwindow_persistent_parameters): Do not use Qstate.
2162 Rewrite doc-strings.
2164 2012-01-19 Kenichi Handa <handa@m17n.org>
2166 * character.c (char_width): New function.
2167 (Fchar_width, c_string_width, lisp_string_width):
2168 Use char_width (Bug#9496).
2170 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2172 * window.c (Vwindow_persistent_parameters): New variable.
2173 (Fset_window_configuration, save_window_save): Handle persistent
2176 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2178 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2179 thrashing the stack of the thread. (Bug#9087)
2181 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2183 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2185 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2187 * xdisp.c (rows_from_pos_range): Handle the case where the
2188 highlight ends on a newline. (Bug#10464)
2189 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2190 he end column for display of highlight that ends on a newline
2193 2012-01-11 Glenn Morris <rgm@gnu.org>
2195 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2196 from load-path also when installation-directory is nil. (Bug#10208)
2198 2012-01-10 Glenn Morris <rgm@gnu.org>
2200 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2202 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2203 Update template values to be closer to their typical values these days.
2205 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2207 * xdisp.c (rows_from_pos_range): Accept additional argument
2208 DISP_STRING, and accept any glyph in a row whose object is that
2209 string as eligible for mouse highlight. Fixes mouse highlight of
2210 display strings from overlays. (Bug#10464)
2212 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2214 emacs: fix an auto-save permissions race condition (Bug#10400)
2215 * fileio.c (auto_saving_dir_umask): New static var.
2216 (Fmake_directory_internal): Use it.
2217 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2218 creating the directory. The old code temporarily assigns
2219 too-generous permissions to the directory.
2220 (do_auto_save_eh): Clear it.
2221 (Fdo_auto_save): Catch all errors, not just file errors, so
2222 that the var is always cleared.
2224 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2226 * search.c (scan_buffer): Pass character positions to
2227 know_region_cache, not byte positions. (Bug#6540)
2229 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2231 * w32.c (sys_rename): Report EXDEV when rename of a directory
2232 fails because the target is on another logical disk. (Bug#10284)
2234 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2236 * xterm.c (x_embed_request_focus): New function.
2238 * xterm.h: Add prototype.
2240 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2242 2012-01-05 Glenn Morris <rgm@gnu.org>
2244 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2246 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2248 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2249 Load gnutls_transport_set_lowat only if GnuTLS version is below
2251 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2252 GnuTLS versions below 2.11.1.
2254 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2256 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2257 to the doc string advising against its use for altering the way
2258 windows are scrolled.
2260 2011-12-28 Kenichi Handa <handa@m17n.org>
2262 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2263 coding-system ASCII compatible only when it does not produce BOM
2264 on encoding (Bug#10383).
2266 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2268 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2270 (create_and_show_popup_menu): Always use menu_position_func for
2273 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2275 * callint.c (Fcall_interactively): Don't truncate prompt string.
2277 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2279 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2280 property that ends at ZV, so that the bidi iteration could be
2281 resumed from there (after widening). (Bug#10360)
2283 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2285 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2287 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2289 * nsterm.m (x_free_frame_resources):
2290 Release f->output_data.ns->miniimage.
2291 (ns_index_color): Fix indentation. Do not retain
2292 color_table->colors[i].
2294 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2297 * nsfns.m (x_set_background_color): Assign return value from
2298 ns_index_color to face-background instead of NSColor*.
2299 (ns_implicitly_set_icon_type): Fix indentation.
2300 Change assignment in for loop to comparison.
2302 * emacs.c (ns_pool): New variable.
2303 (main): Assign ns_pool.
2304 (Fkill_emacs): Call ns_release_autorelease_pool.
2306 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2307 autorelease fdesc, release fdAttrs and tdict.
2308 (ns_get_covering_families): Release charset.
2309 (ns_findfonts): Release NSFontDescriptor created with new.
2310 (ns_uni_to_glyphs): Fix indentation.
2311 (setString): Release attrStr before assigning new value.
2313 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2315 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2317 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2318 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2320 2011-12-18 David Reitter <reitter@cmu.edu>
2322 * nsterm.m (ns_term_init): Subscribe for notifications
2323 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2324 to method trackingNotification in EmacsMenu.
2326 * nsmenu.m (trackingMenu): New variable.
2327 (trackingNotification): New method (from Aquamacs).
2328 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2329 from Aquamacs (Bug#7030).
2331 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2333 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2334 (symbol_to_nsstring): Fix indentation.
2335 (ns_symbol_to_pb): New function.
2336 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2337 (Fns_rotate_cut_buffers_internal): Remove.
2338 (Fns_store_selection_internal): Rename from
2339 Fns_store_cut_buffer_internal.
2340 (ns_get_foreign_selection, Fx_own_selection_internal)
2341 (Fx_disown_selection_internal, Fx_selection_exists_p)
2342 (Fns_get_selection_internal, Fns_store_selection_internal):
2343 Use ns_symbol_to_pb and check if return value is nil.
2344 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2345 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2346 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2347 renamed to Sns_store_selection_internal.
2348 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2349 and remove this function.
2350 (ns_handle_selection_clear): Remove, never used.
2351 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2354 2011-12-17 Ken Brown <kbrown@cornell.edu>
2356 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2357 GID is unknown (Bug#10257).
2359 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2361 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2362 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2363 which caused a build failure on GNU/Linux IA-64. This problem was
2364 introduced by my 2011-10-07 patch.
2366 2011-12-15 Juri Linkov <juri@jurta.org>
2368 * image.c (imagemagick_error): New function. (Bug#10112)
2369 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2370 Use `imagemagick_error' where ImageMagick functions return
2372 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2375 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2377 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2378 fill background (Bug#8992).
2380 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2382 * window.c (Vwindow_combination_resize)
2383 (Vwindow_combination_limit): Use t instead of non-nil in
2385 (Vrecenter_redisplay): Add first sentence of doc-string on
2387 (Frecenter): Fix doc-string typo.
2389 2011-12-11 Kenichi Handa <handa@m17n.org>
2391 * coding.c (Funencodable_char_position): Pay attention to the
2392 buffer text relocation (Bug#9389).
2394 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2396 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2397 gtk_init (Bug#10100).
2399 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2401 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2402 IT->string is nil. (Bug#10263)
2404 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2406 * nsterm.h (x_free_frame_resources): Declare.
2408 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2409 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2411 * nsterm.h (ns_get_defaults_value): Declare.
2413 * nsterm.m (ns_default): Call ns_get_defaults_value.
2415 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2417 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2420 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2422 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2423 that where the value of an _OBJC_* symbol points to is in the .bss
2424 section (Bug#10240).
2426 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2428 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2429 after the loop to call ccl_driver at least once (Bug#8619).
2431 2011-12-08 Kenichi Handa <handa@m17n.org>
2433 * ftfont.c (get_adstyle_property): Fix previous change
2436 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2438 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2439 dirs from the default value of EMACSLOADPATH (bug#10208).
2441 2011-12-07 Glenn Morris <rgm@gnu.org>
2443 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2444 installation and source directories as well. (Bug#10208)
2446 2011-12-06 Chong Yidong <cyd@gnu.org>
2448 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2450 2011-12-06 Glenn Morris <rgm@gnu.org>
2452 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2453 as an error, not just -1. (Bug#10217)
2455 2011-12-05 Chong Yidong <cyd@gnu.org>
2457 * keyboard.c (process_special_events): New function.
2458 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2460 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2462 * coding.c (encode_designation_at_bol): Don't use uninitialized
2463 local variable (Bug#9318).
2465 2011-12-05 Kenichi Handa <handa@m17n.org>
2467 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2468 return Qnil (Bug#8046, Bug#10193).
2470 2011-12-05 Kenichi Handa <handa@m17n.org>
2472 * coding.c (encode_designation_at_bol): New args charbuf_end and
2473 dst. Return the number of produced bytes. Callers changed.
2474 (coding_set_source): Return how many bytes coding->source was
2476 (coding_set_destination): Return how many bytes
2477 coding->destination was relocated.
2478 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2479 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2481 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2483 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2484 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2487 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2489 The following changes are to fix Bug#9318.
2491 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2492 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2493 (encode_coding_iso_2022, encode_coding_sjis)
2494 (encode_coding_big5, encode_coding_charset): Use the above macros.
2496 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2498 * lisp.h (process_quit_flag): Fix external declaration.
2500 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2502 Don't macro-inline non-performance-critical code.
2503 * eval.c (process_quit_flag): New function.
2504 * lisp.h (QUIT): Use it.
2506 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2508 * nsfns.m (get_geometry_from_preferences): New function.
2509 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2511 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2513 * emacs.c (Qkill_emacs): Define.
2514 (syms_of_emacs): Initialize it.
2515 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2516 Qquit_flag to `kill-emacs' instead.
2517 (quit_throw_to_read_char): Add parameter `from_signal'.
2518 All callers changed. Call Fkill_emacs if requested and safe.
2519 * lisp.h (QUIT): Call Fkill_emacs if requested.
2521 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2523 * widget.c (update_wm_hints): Return if wmshell is null.
2524 (widget_update_wm_size_hints): New function.
2526 * widget.h (widget_update_wm_size_hints): Declare.
2528 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2529 widget_update_wm_size_hints (Bug#10104).
2531 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2533 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2534 before a newline, prepare the bidi iterator for consuming the
2535 newline, and keep the current paragraph direction. (Bug#10183)
2536 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2538 2011-12-02 Juri Linkov <juri@jurta.org>
2540 * search.c (Fword_search_regexp): New Lisp function created from
2541 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2542 (Fword_search_backward, Fword_search_forward)
2543 (Fword_search_backward_lax, Fword_search_forward_lax):
2544 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2545 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2547 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2549 * fileio.c (Finsert_file_contents): Move after-change-function call
2550 to before the "handled:" label, since all "goto handled" appear in
2551 cases where the *-change-functions have already been properly called
2554 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2556 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2557 waiting for input. (Bug#10169)
2559 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2561 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2562 verifies glyph row's hash code--we have just reallocated the
2563 glyphs, so their contents can be complete garbage. (Bug#10164)
2565 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2567 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2569 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2571 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2572 attributes are tested _before_ calling verify_row_hash, to protect
2573 against GCC re-ordering of the tests. (Bug#10164)
2575 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2577 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2579 * xterm.c (handle_one_xevent): Only set async_visible and friends
2580 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2581 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2582 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2584 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2586 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2587 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2588 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2589 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2590 All uses changed to use GCPRO1 etc.
2591 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2592 Revert to old implementation (i.e., before 2011-03-11).
2594 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2596 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2597 of scroll runs so as to avoid assigning disabled bogus rows and
2598 unnecessary graphics copy operations.
2600 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2602 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2603 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2604 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2605 (malloc, free, realloc, calloc): Redirect to e_* only when
2608 * lisp.h (GCTYPEBITS): Move before first use.
2609 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2610 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2611 this macro definition.
2613 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2616 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2618 * gtkutil.c (xg_create_frame_widgets):
2619 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2620 present with Gtk+ 2.0.
2622 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2624 * fileio.c (Finsert_file_contents): Undo previous change; see
2625 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2627 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2629 Rename locals to avoid shadowing.
2630 * fileio.c (Finsert_file_contents):
2631 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2632 * process.c (wait_reading_process_output):
2633 Rename inner 'proc' to 'p' to avoid shadowing.
2634 Indent for consistency with usual Emacs style.
2636 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2638 * xdisp.c (redisplay_window): If cursor row is not fully visible
2639 after recentering, and scroll-conservatively is set to a large
2640 number, scroll window by a few more lines to make the cursor fully
2641 visible and out of scroll-margin. (Bug#10105)
2642 (start_display): Don't move to the next line if the display should
2643 start at a newline that is part of a display vector or an overlay
2646 2011-11-24 Juri Linkov <juri@jurta.org>
2648 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2649 after the `MagickPingImage' call. (Bug#10112)
2651 2011-11-23 Chong Yidong <cyd@gnu.org>
2653 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2655 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2657 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2658 making another buffer current. (Bug#10114)
2660 2011-11-23 Glenn Morris <rgm@gnu.org>
2662 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2664 2011-11-23 Chong Yidong <cyd@gnu.org>
2666 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2667 using it (Bug#5984).
2669 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2671 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2672 and header-lines, as they don't have one computed for them.
2675 * .gdbinit (prow): Make displayed values more self-explaining.
2676 Add row's hash code.
2678 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2680 * process.c (wait_reading_process_output): Fix asynchrounous
2681 GnuTLS socket handling on some versions of the GnuTLS library.
2682 (wait_reading_process_output): Add comment and URL.
2684 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2686 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2688 2011-11-21 Chong Yidong <cyd@gnu.org>
2690 * window.c (Fnext_window, Fprevious_window): Doc fix.
2692 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2694 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2696 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2698 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2700 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2702 * window.c (Fset_window_combination_limit): Rename argument
2704 (Vwindow_combination_limit): Remove "status" from doc-string.
2706 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2708 * m/ibms390.h: Remove.
2709 * m/ibms390x.h: Don't include "ibms390.h".
2711 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2713 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2714 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2716 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2718 * casetab.c (Fset_case_table):
2719 * charset.c (Fcharset_after): Fix typos.
2721 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2723 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2724 Otherwise, valgrind does not work on some platforms.
2725 Problem reported by Andreas Schwab in
2726 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2727 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2728 is set, removing the need for VIRT_ADDRESS_VARIES.
2729 (PURE_P): Use a more-efficient implementation that needs just one
2730 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2731 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2732 to 4 (xorl, subq, cmpq, setbe).
2733 * alloc.c (pure): Always extern now, since that's the
2734 VIRT_ADDR_VARIES behavior.
2735 (PURE_POINTER_P): Use a single comparison, not two, for
2736 consistency with the new puresize.h.
2737 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2738 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2739 Remove VIRT_ADDR_VARIES no longer needed.
2741 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2743 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2744 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2745 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2746 behave as if the cursor position were at the window margin.
2748 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2749 and the cursor position is out of bounds, behave as if the cursor
2750 position were at the window margin. (Bug#10075)
2752 2011-11-18 Chong Yidong <cyd@gnu.org>
2754 * window.c (Fwindow_combination_limit): Make first argument
2755 non-optional, since it is meaningless for live windows like the
2758 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2760 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2762 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2764 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2765 (graft_intervals_into_buffer): Simplify.
2767 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2769 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2770 hash values of the two rows.
2771 (copy_row_except_pointers): Preserve the used[] arrays and the
2772 hash values of the two rows. (Bug#10035)
2773 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2775 * xdisp.c (row_hash): New function, body extracted from
2776 compute_line_metrics.
2777 (compute_line_metrics): Call row_hash, instead of computing the
2780 * dispnew.c (verify_row_hash): Call row_hash for computing the
2781 hash code of a row, instead of duplicating code from xdisp.c.
2783 * dispextern.h (row_hash): Add prototype.
2785 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2787 * frame.c (delete_frame): Don't delete the terminal when the last
2788 X frame is closed if emacs is built with GTK toolkit.
2790 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2792 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2794 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2796 * window.c (Vwindow_splits): Rename to
2797 Vwindow_combination_resize. Suggested by Juri Linkov.
2798 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2801 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2803 * nsfns.m (Fns_font_name):
2804 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2806 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2808 * window.h (window): Rename slot "nest" to "combination_limit".
2809 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2810 (Fset_window_nest): Rename to Fset_window_combination_limit.
2811 (Vwindow_nest): Rename to Vwindow_combination_limit.
2812 (recombine_windows, make_parent_window, make_window)
2813 (Fsplit_window_internal, saved_window)
2814 (Fset_window_configuration, save_window_save): Rename all
2815 occurrences of window_nest to window_combination_limit.
2817 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2819 * image.c (imagemagick_load_image): Fix typo.
2821 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2823 * xdisp.c (display_line): Move the call to
2824 highlight_trailing_whitespace before the call to
2825 compute_line_metrics, since the latter needs to see the final
2826 faces of all the glyphs to compute ROW's hash value.
2827 Fixes assertion violations in row_equal_p. (Bug#10035)
2829 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2831 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2832 just return (bug#10044).
2834 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2836 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2837 with user-defined heap size. Bump the default size of the temacs
2838 heap to 27MB, to avoid memory warning when running temacs.
2839 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2841 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2842 current_matrix and desired_matrix. (Bug#9990)
2843 (verify_row_hash) [XASSERTS]: New function.
2844 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2845 that the hash value of glyph rows is correct.
2847 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2849 * window.h (window): Remove splits slot.
2850 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2851 (Fdelete_other_windows_internal, make_parent_window)
2852 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2853 (Fset_window_configuration, save_window_save): Don't deal with
2854 split status of windows.
2855 (saved_window): Remove splits slot.
2856 (Vwindow_splits): Rewrite doc-string.
2858 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2860 * xfns.c (unwind_create_frame):
2861 * nsfns.m (unwind_create_frame):
2862 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2863 Vframe_list (Bug#9999).
2865 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2867 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2869 2011-11-11 Kenichi Handa <handa@m17n.org>
2871 * callproc.c (Fcall_process): Set the member dst_multibyte of
2874 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2876 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2877 avoid a crash (bug#9496).
2879 2011-11-09 Chong Yidong <cyd@gnu.org>
2881 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2882 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2884 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2886 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2888 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2890 Avoid some portability problems by eschewing 'extern inline' functions.
2891 The trivial performance wins aren't worth the portability hassles; see
2892 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2894 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2895 (window_box_width, window_box_left, window_box_left_offset)
2896 (window_box_right, window_box_right_offset): Undo previous change,
2897 by removing the "extern"s.
2898 * intervals.c (adjust_intervals_for_insertion)
2899 (adjust_intervals_for_deletion): Undo previous change,
2900 making these static again.
2901 (offset_intervals, temp_set_point_both, temp_set_point)
2902 (copy_intervals_to_string): No longer inline.
2903 * xdisp.c (window_text_bottom_y, window_box_width)
2904 (window_box_height, window_box_left_offset)
2905 (window_box_right_offset, window_box_left, window_box_right)
2906 (window_box): No longer inline.
2908 2011-11-08 Chong Yidong <cyd@gnu.org>
2910 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2911 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2912 Signal an error if not a live window.
2913 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2914 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2916 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2918 * lisp.h (syms_of_abbrev): Remove declaration.
2919 Reported by CHENG Gao <chenggao@royau.me>.
2921 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2923 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2924 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2925 of temacs in GUI mode.
2927 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2929 * window.h: Declare delete_all_child_windows instead of
2930 delete_all_subwindows.
2931 * window.c (Fwindow_nest, Fset_window_nest)
2932 (Fset_window_new_total, Fset_window_new_normal)
2933 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2934 (delete_all_subwindows): Rename to delete_all_child_windows.
2935 (Fdelete_other_windows_internal, Fset_window_configuration):
2936 Call delete_all_child_windows instead of delete_all_subwindows.
2937 * frame.c (delete_frame): Call delete_all_child_windows instead
2938 of delete_all_subwindows.
2940 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2942 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2943 This is also needed for porting to any host where GC_MARK_STACK is
2944 not GC_MAKE_GCPROS_NOOPS.
2945 (which_symbols): Use it.
2947 2011-11-07 Kenichi Handa <handa@m17n.org>
2949 * coding.c (coding_set_destination): Check coding->src_pos only
2950 when coding->src_object is a buffer (bug#9910).
2952 * process.c (send_process): Set the member src_multibyte of coding
2953 to 0 (bug#9911) when sending a unibyte text.
2955 * callproc.c (Fcall_process): Set the member src_multibyte of
2956 process_coding to 0 (bug#9912).
2958 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2960 * xmenu.c (cleanup_widget_value_tree): New function.
2961 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2962 calling free_menubar_widget_value_tree directly (Bug#9830).
2964 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2966 Fix some portability problems with 'inline'.
2967 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2968 (window_box_width, window_box_left, window_box_left_offset)
2969 (window_box_right, window_box_right_offset): Declare extern.
2970 Otherwise, these inline functions do not conform to C99 and
2971 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2972 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2973 * intervals.c (adjust_intervals_for_insertion)
2974 (adjust_intervals_for_deletion): Now extern, because otherwise the
2975 extern inline functions 'offset_intervals' couldn't refer to it.
2976 (static_offset_intervals): Remove.
2977 (offset_intervals): Rewrite using the old contents of
2978 static_offset_intervals. The old version didn't conform to C99
2979 because an extern inline function contained a reference to an
2980 identifier with static linkage.
2982 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2984 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2987 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2989 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2990 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2991 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2992 return Qleft_to_right.
2994 2011-11-06 Chong Yidong <cyd@gnu.org>
2996 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2997 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2998 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2999 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3000 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3001 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3002 (Fwindow_vscroll): Doc fix.
3003 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3004 argument, since it makes no sense to pass a live window and for
3005 consistency with window-child.
3007 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3009 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3012 2011-11-05 Jason Rumney <jasonr@gnu.org>
3014 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3015 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3017 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3018 bitwise arithmetic preventing use of unicode-sip and non-truetype
3021 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3023 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3026 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3027 initialization code to keep similarity to xfns.c after changes
3030 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3032 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3033 (unwind_create_frame): New function (Bug#9943).
3034 (Fx_create_frame): Restructure code to be more similar to the one in
3035 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3036 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3037 Move terminal->reference_count++ just before making the frame official
3040 * nsterm.m (x_free_frame_resources): New function.
3041 (x_destroy_window): Move code to x_free_frame_resources.
3043 * xfns.c (unwind_create_frame): Fix comment.
3044 (Fx_create_frame, x_create_tip_frame):
3045 Move terminal->reference_count++ just before making the frame
3046 official. Move initialization of image_cache_refcount and
3047 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3049 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3051 Support MSVC build with newer versions of Visual Studio.
3052 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3053 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3056 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3057 which are not supported by MSVC.
3058 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3059 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3061 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3063 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3065 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3067 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3069 Support MSVC build with newer versions of Visual Studio.
3070 * w32.c: Don't include w32api.h for MSVC.
3071 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3073 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3074 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3075 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3076 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3078 (alloca) [_MSC_VER]: Define to _alloca.
3080 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3082 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3084 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3086 * xdisp.c (note_mouse_highlight): If either of
3087 previous/next-single-property-change returns nil, treat that as
3088 the beginning or the end of the buffer. (Bug#9955)
3090 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3092 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3093 label is not null (Bug#9951).
3094 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3097 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3099 * window.c (Fwindow_body_size): Mention in the doc string that the
3100 return value is in frame's canonical units. (Bug#9949)
3102 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3104 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3106 * w32fns.c (unwind_create_frame): If needed, free the glyph
3107 matrices of the partially constructed frame. (Bug#9943)
3108 * xfns.c (unwind_create_frame): Likewise.
3110 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3112 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3113 Don't stop backward scan on the continuation glyph, even though
3114 its CHARPOS is positive.
3115 (mouse_face_from_buffer_pos, note_mouse_highlight):
3116 Rename cover_string to disp_string.
3118 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3120 * window.c (temp_output_buffer_show): Don't use
3121 Vtemp_buffer_show_specifiers.
3122 (Vtemp_buffer_show_specifiers): Remove unused variable.
3124 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3126 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3127 past the beginning of the current glyph matrix.
3129 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3131 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3132 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3133 HAVE_GTK3 (Bug#9869).
3135 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3136 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3138 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3140 * xterm.c: Declare x_handle_net_wm_state to return int.
3141 (handle_one_xevent): Check if we are iconified but don't have
3142 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3143 (get_current_wm_state): Return non-zero if not hidden,
3144 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3145 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3146 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3147 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3149 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3151 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3152 so that this new function doesn't get optimized away by a
3153 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3155 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3157 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3159 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3161 Fix the `xbytecode' command.
3162 * .gdbinit (xprintbytestr): New command.
3163 (xwhichsymbols): Rename from `which'; all callers changed.
3164 (xbytecode): Print the byte-code string as well.
3166 2011-10-29 Kim Storm <storm@cua.dk>
3168 * alloc.c (which_symbols): New function.
3170 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3172 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3175 2011-10-29 Glenn Morris <rgm@gnu.org>
3177 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3178 Not clear what it was for, and it causes various bugs. (Bug#9839)
3180 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3182 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3183 possible random value that matches one of those tested as
3184 condition to clear the mouse face.
3186 2011-10-28 Chong Yidong <cyd@gnu.org>
3188 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3190 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3192 * window.c (make_window): Initialize phys_cursor_on_p.
3194 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3196 * lisp.h (struct Lisp_Symbol): Update comments.
3198 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3200 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3202 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3204 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3205 <oslsachem@gmail.com> for helping to debug this.
3207 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3208 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3209 (g_b_init_get_glyph_outline_w): New static variables.
3210 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3211 (GetGlyphOutlineW_Proc): New typedefs.
3212 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3213 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3215 (w32font_open_internal, compute_metrics):
3216 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3217 instead of calling the "wide" APIs directly.
3219 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3221 * w32.h (syms_of_w32font): Add prototype.
3223 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3225 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3226 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3227 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3228 (Fmove_to_window_line): Doc fix.
3230 2011-10-27 Chong Yidong <cyd@gnu.org>
3232 * process.c (make_process): Set gnutls_state to NULL.
3234 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3235 non-NULL, regardless of GNUTLS_INITSTAGE.
3236 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3237 an error. Set process slots as soon as we allocate them.
3239 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3241 2011-10-27 Chong Yidong <cyd@gnu.org>
3243 * gnutls.c (emacs_gnutls_deinit): New function.
3244 Deallocate credentials structures as well as calling gnutls_deinit.
3245 (Fgnutls_deinit, Fgnutls_boot): Use it.
3247 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3248 (deactivate_process): Call emacs_gnutls_deinit.
3250 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3252 * image.c (x_create_x_image_and_pixmap):
3253 * w32.c (sys_rename, w32_delayed_load):
3254 * w32font.c (fill_in_logfont):
3255 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3257 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3259 * w32fns.c (w32_default_color_map): New function,
3260 extracted from Fw32_default_color_map.
3261 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3263 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3265 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3267 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3269 * keyboard.c (test_undefined): New function (bug#9751).
3270 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3272 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3274 * sysdep.c (init_sys_modes): Fix the check for the controlling
3275 terminal (Bug#6649).
3277 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3279 * dispextern.h (struct bidi_it): New member next_en_type.
3281 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3282 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3283 current character, check also for next_en_type being WEAK_EN.
3284 (bidi_resolve_weak): Don't enter the expensive loop if the current
3285 position is before next_en_pos. Record the bidi type of the first
3286 non-ET, non-BN character we find, in addition to its position.
3287 (bidi_level_of_next_char): Invalidate next_en_type when
3288 next_en_pos is over-stepped.
3290 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3292 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3293 * editfns.c: Rewrite current-time-zone so that it invokes
3294 the equivalent of (format-time-string "%Z") to get the time zone name.
3295 This fixes a bug when the time zone name contains characters that
3296 need converting from the system time locale to Emacs internal format.
3297 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3298 that patch fixed format-time-string to do the conversion, but
3299 I forgot to fix current-time-zone.
3300 (format_time_string): New function, containing most of
3301 what Fformat_time_string used to contain.
3302 (Fformat_time_string): Rewrite in terms of format_time_string.
3303 This doesn't change this function's behavior.
3304 (current-time-zone): Rewrite to use format_time_string.
3305 This fixes the bug reported by Michael Schierl in
3306 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3307 Jason Rumney's 2007-06-07 change worked around this bug, but
3309 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3311 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3313 * xdisp.c (start_display): If the character at POS is displayed
3314 via a display vector, reset IT->current.dpvec_index to zero.
3315 (try_window_reusing_current_matrix): If a line ends in a display
3316 vector or the next line starts in a display vector, continue
3317 redrawing the window even though the character position of
3318 start_row was reached.
3321 2011-10-18 Chong Yidong <cyd@gnu.org>
3323 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3324 with nobreak-char-display too.
3326 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3328 Fix part 3 of bug#9771.
3329 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3330 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3331 non-neutral characters if the current character is a paragraph
3332 separator (a.k.a. Newline). This avoids running the same
3333 expensive loop twice, once when we consume the preceding newline
3334 and the other time when the line actually needs to be displayed.
3335 Avoid the loop when we see neutrals on the base embedding level
3336 following a character whose directionality is the same as the
3337 paragraph's. This avoids running the expensive loop when a line
3338 ends in a long sequence of neutrals, like control characters.
3339 Add assertion against STRONG_AL type. Slightly rearrange code
3340 that determines the type of a neutral given the first non-neutral
3342 (bidi_level_of_next_char): Set next_en_pos to zero when
3343 invalidating its info.
3345 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3347 * xdisp.c (push_display_prop): Determine whether to record string
3348 or buffer position by IT->string, not by IT->method. Allow
3349 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3350 (move_it_vertically_backward): Don't look for character position
3351 immediately after the newline when in a continuation line.
3354 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3356 * window.c (coordinates_in_window): Rewrite and delabelize
3357 vertical border check. (Bug#5357) (Bug#9618)
3359 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3361 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3362 errors in XSetWindowBorder (bug#9310).
3364 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3366 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3367 avoid crash when xmalloc overrun checking is enabled.
3369 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3371 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3372 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3373 cursor motion with <left> and <right> arrow keys.
3375 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3376 some callers set that themselves.
3378 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3380 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3381 display string and the previous row comes from the same string and
3382 is empty. (Bug#9739) (Bug#9738)
3384 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3386 * doc.c (get_doc_string): Encode file name (bug#9735).
3388 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3390 * bidi.c (bidi_level_of_next_char):
3391 * xdisp.c (get_visually_first_element): Remove old incorrect
3392 comments regarding the Unicode Line Separator character.
3394 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3396 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3398 * alloc.c (Fgc_status): Do not access beyond zombies array
3399 boundary if nzombies > MAX_ZOMBIES.
3400 * alloc.c (dump_zombies): Add missing format specifier.
3402 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3404 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3405 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3407 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3408 Some packages use them to denote characters with modifiers.
3410 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3412 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3413 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3414 matching a pp-number. Rename parameter var to var1.
3416 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3418 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3420 2011-10-08 Glenn Morris <rgm@gnu.org>
3422 * callint.c (Fcall_interactively): Give a more explicit error for the
3423 'c' case with a non-character input. (Bug#8479)
3425 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3427 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3429 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3430 lines that are hscrolled on the left.
3432 * dispnew.c (buffer_posn_from_coords): Account for a possible
3433 presence of header-line. (Bug#4426)
3435 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3437 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3438 Don't advertise functionality which we discourage or doesn't work.
3440 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3442 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3443 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3444 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3445 this makes Emacs dump core during garbage collection on rare
3446 occasions. sizeof is obviously inferior to offsetof here, so
3447 stick with offsetof.
3448 (GC_POINTER_ALIGNMENT): New macro.
3449 (mark_memory): Omit 3rd (offset) arg; caller changed.
3450 Don't assume EMACS_INT alignment is the same as pointer alignment.
3452 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3454 * keyboard.c (read_key_sequence_remapped): New var.
3455 (read_key_sequence): Compute remapping in the right buffer.
3456 (command_loop_1): Use read_key_sequence's remapping directly.
3458 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3460 * dired.c (file_name_completion): Don't expand file name.
3461 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3462 before checking file name handler.
3464 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3465 they've been requested explicitly (bug#9591).
3467 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3469 * keymap.c (Fsingle_key_description): Use make_specified_string
3470 instead of build_string to build string from push_key_description.
3473 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3475 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3476 This fixes a Y2038 bug on 64-bit hosts.
3477 * buffer.c (reset_buffer):
3478 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3479 (Fclear_buffer_auto_save_failure):
3480 Use 0, not -1, to represent an unset failure time, since time_t
3481 might not be signed.
3483 Remove dependency on glibc malloc internals.
3484 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3485 Move back here from lisp.h, but with their new implementations.
3486 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3487 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3488 * charset.c (charset_table_init): New static var.
3489 (syms_of_charset): Use it instead of xmalloc. This removes a
3490 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3491 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3492 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3493 Move back to alloc.c.
3494 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3495 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3497 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3499 * nsterm.m (windowDidResize): Call x_set_window_size only when
3500 ns_in_resize is true. Otherwise set pixelwidth/height and
3501 call change_frame_size (Bug#9628).
3503 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3505 Port --enable-checking=all to Fedora 14 x86-64.
3506 * charset.c (syms_of_charset): Also account for glibc malloc's
3507 internal overhead when calculating the initial malloc maximum.
3509 Port --enable-checking=all to Fedora 14 x86.
3510 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3512 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3513 (overrun_check_realloc, overrun_check_free):
3514 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3515 That way, xmalloc returns a properly-aligned pointer even if
3516 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3517 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3518 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3519 into account when calculating the initial malloc maximum.
3520 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3521 Move here from alloc.c, so that charset.c can use it too.
3522 Properly align; the old code wasn't right for common 32-bit hosts
3523 when configured with --enable-checking=all.
3524 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3525 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3527 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3529 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3532 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3534 * xdisp.c (compute_display_string_end): If there's no display
3535 string at CHARPOS, return -1.
3537 * bidi.c (bidi_fetch_char): When compute_display_string_end
3538 returns a negative value, treat the character as a normal
3539 character not covered by a display string. (Bug#9624)
3541 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3543 * lread.c (Fread_from_string): Fix typo in docstring.
3545 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3547 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3548 newline, reseat the iterator instead of bidi-iterating there one
3549 character at a time. (Bug#9610)
3550 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3551 TO_CHARPOS if the bidi iterator is at base embedding level.
3553 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3555 * lread.c (readevalloop): Use correct code for NBSP.
3556 (read1): Likewise. (Bug#9608)
3558 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3560 * dbusbind.c (Fdbus_register_signal): When service is not
3561 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3563 2011-09-25 Glenn Morris <rgm@gnu.org>
3565 * buffer.c (truncate-lines): Doc fix.
3567 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3569 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3570 (Fset_window_next_buffers): Doc fix.
3572 2011-09-24 Glenn Morris <rgm@gnu.org>
3574 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3576 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3578 Fix minor problems found by static checking.
3579 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3580 * indent.c (Fvertical_motion): Fix == vs = typo.
3582 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3584 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3585 Default value is now t. Doc fix.
3587 * indent.c (Fvertical_motion): Compute and apply the overshoot
3588 logic when moving up, not only when moving down. Fix the
3589 confusing name and values of the it_overshoot_expected variable;
3590 logic changes accordingly. (Bug#9254) (Bug#9549)
3592 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3593 CHARPOS is covered by a display string which includes newlines.
3594 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3595 is covered by a display string with embedded newlines.
3597 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3599 * dbusbind.c (Fdbus_register_signal): Add match rule to
3600 Vdbus_registered_objects_table. (Bug#9581)
3601 (Fdbus_register_method, Vdbus_registered_objects_table):
3604 2011-09-24 Jim Meyering <meyering@redhat.com>
3606 do not ignore write error for any output size
3607 The previous change was incomplete.
3608 While it makes emacs --batch detect the vast majority of stdout
3609 write failures, errors were still ignored whenever the output size is
3610 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3611 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3612 && echo FAIL: ignored write error
3613 FAIL: ignored write error
3614 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3615 && echo FAIL: ignored write error
3616 FAIL: ignored write error
3617 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3619 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3621 * emacs.c (Fkill_emacs): In noninteractive mode exit
3622 non-successfully if a write error occurred on stdout. (Bug#9574)
3624 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3626 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3629 * dispextern.h (struct it): Update the comment documenting what
3632 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3634 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3635 a display string, extend search for cursor position to end of row.
3636 (find_row_edges): If the row ends in a newline from a display
3637 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3638 Handle the case of a display string with multiple newlines.
3639 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3640 non-empty line. Fixes confusing cursor motion with arrow keys at
3641 the beginning of a line that starts with whitespace.
3643 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3645 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3648 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3650 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3653 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3655 * xdisp.c (display_line): Record maximum and minimum buffer
3656 positions even if no glyphs were produced (e.g., by a zero-width
3657 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3658 buffer positions that will be removed from the glyph row because
3660 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3661 column is beyond frame width: don't subtract 1 "pixel" when
3662 computing width of the stretch.
3663 (reseat_at_next_visible_line_start): Undo the change made on
3664 2011-09-17 that saved paragraph information and restored it after
3665 the call to `reseat'. (Bug#9545)
3667 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3669 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3670 and turn window cursor on if cleared (Bug#9415).
3672 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3674 * search.c (boyer_moore): Take unibyte characters from pattern
3675 literally. (Bug#9458)
3677 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3679 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3681 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3683 Fix minor problem found by static checking.
3684 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3685 initialized, to pacify gcc -Wuninitialized.
3687 * fileio.c: Report proper errno when syscall falls.
3688 (Finsert_file_contents): Save and restore errno,
3689 so that report_file_error outputs the correct diagnostic.
3690 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3692 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3694 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3696 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3698 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3699 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3701 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3703 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3704 about the current paragraph and restore it after the call to reseat.
3706 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3707 (bidi_find_paragraph_start): Search back for paragraph beginning
3708 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3709 (bidi_move_to_visually_next): Only trigger paragraph-related
3710 computations when the last character is a newline or at EOB, not
3711 just any NEUTRAL_B. (Bug#9470)
3713 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3714 truncated lines if point is covered by a display string. (Bug#9524)
3716 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3718 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3719 (cons_to_x_long): New function.
3720 (lisp_data_to_selection_data): Use it. Correct the test for
3721 short-versus-long data; it was negated. Break out of vector
3722 loop, for efficiency, when a long datum is discovered.
3724 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3726 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3728 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3730 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3731 GCC PR/17406) by declaring this function with external scope.
3733 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3735 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3736 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3738 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3740 * editfns.c (Fformat): Correctly handle text properties on "%%".
3742 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3744 * xterm.c (x_draw_composite_glyph_string_foreground):
3745 * w32term.c (x_draw_composite_glyph_string_foreground):
3746 * term.c (encode_terminal_code):
3747 * composite.c (composition_update_it, get_composition_id):
3748 * xdisp.c (get_next_display_element)
3749 (fill_composite_glyph_string): Add comments about special meaning
3750 of TAB characters in a composition.
3752 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3754 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3755 This occurs when processing a multibyte format.
3756 Problem reported by Wolfgang Jenker.
3758 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3760 * xdisp.c (try_cursor_movement): Only check for exact match if
3761 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3763 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3765 Remove unused external symbols.
3766 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3767 * xdisp.c (calc_pixel_width_or_height): Now static.
3768 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3769 * indent.c (check_display_width):
3770 * w32term.c: Fix comment to match code.
3771 * xterm.c, xterm.h (x_catching_errors): Remove.
3773 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3775 * xselect.c: Use signed conversions more consistently (Bug#9498).
3776 (selection_data_to_lisp_data): Assume incoming selection data are
3777 signed integers, not unsigned. This is to be consistent with
3778 outgoing selection data, which was modified to use signed integers
3779 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3780 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3781 expects long, not unsigned long.
3783 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3785 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3786 computation of loop end. Reported by Johan Bockgård
3789 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3791 * frame.c (Fother_visible_frames_p): Function deleted.
3793 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3795 * indent.c (compute_motion): Process display vector front to back
3796 rather than the other way around. (Bug#2496)
3798 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3800 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3802 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3804 * minibuf.c (Fread_from_minibuffer): Doc fix.
3806 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3808 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3809 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3811 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3813 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3814 value for non-existent files.
3816 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3818 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3819 set its "size" to -1. This will set the modtime_size field of
3820 the corresponding buffer to -1, which is what
3821 verify-visited-file-modtime expects for files that do not exist.
3824 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3826 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3828 * lisp.h: ... from here. push_key_description is no longer
3829 defined in keyboard.c, so its declaration should not be in
3830 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3831 logically belongs with push_key_description.
3833 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3835 * buffer.h: Include <sys/types.h> instead of <time.h>.
3836 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3837 Problem reported by Herbert J. Skuhra.
3839 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3841 * xml.c (parse_region): Make the parsing work for
3842 non-comment-starting XML files again (bug#9144).
3844 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3846 * image.c (gif_load): Fix calculation of bottom and right corner.
3849 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3851 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3852 redisplay in small windows.
3854 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3856 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3858 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3860 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3861 Operate on live windows only.
3863 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3865 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3867 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3869 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3870 only under bidi iteration.
3872 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3874 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3876 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3878 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3879 Without this fix, the command to link temacs failed due to an
3880 undefined symbol __builtin_isnan. This is because
3881 /usr/include/iso/math_c99.h #defines isnan(x) to
3882 __builtin_isnan(x), but the bundled gcc, which identifies itself
3883 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3885 * floatfns.c (isnan): #undef, and then #define to a clone of
3887 (Fisnan): Always define, since it's always available now.
3888 (syms_of_floatfns): Always define isnan at the Lisp level.
3890 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3892 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3894 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3896 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3897 The previous code assumed that file offsets (off_t values) fit in
3898 EMACS_INT variables, which is not true on typical 32-bit hosts.
3899 The code messed up by falsely reporting buffer overflow in cases
3900 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3901 when "big" contains more than 2**29 bytes, even though this
3902 inserts just one byte and does not overflow the buffer.
3903 (Finsert_file_contents): Store file offsets as off_t
3904 values, not as EMACS_INT values. Check for overflow when
3905 converting between EMACS_INT and off_t. When checking for
3906 buffer overflow or for overlap, take the offsets into account.
3907 Don't use EMACS_INT for small values where int suffices.
3908 When checking for overlap, fix a typo: ZV was used where
3909 ZV_BYTE was intended.
3910 (Fwrite_region): Don't assume off_t fits into 'long'.
3911 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3913 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3915 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3917 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3919 sprintf-related integer and memory overflow issues (Bug#9412).
3921 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3922 (esprintf, exprintf, evxprintf): New functions.
3923 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3924 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3925 (modify_event_symbol): Do not assume that the length of
3926 name_alist_or_stem is safe to alloca and fits in int.
3927 (Fexecute_extended_command): Likewise for function name and binding.
3928 (Frecursion_depth): Wrap around reliably on integer overflow.
3929 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3930 since some callers pass EMACS_INT values.
3931 (Fsingle_key_description): Don't crash if symbol name contains more
3932 than MAX_ALLOCA bytes.
3933 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3934 (get_minibuffer): Arg is now EMACS_INT, not int.
3935 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3936 (esprintf, exprintf, evxprintf): New decls.
3937 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3939 * dbusbind.c (signature_cat): New function.
3940 (xd_signature, Fdbus_register_signal):
3941 Do not overrun buffer; instead, report string overflow.
3943 * dispnew.c (add_window_display_history): Don't overrun buffer.
3944 Truncate instead; this is OK since it's just a log.
3946 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3947 even if the time zone offset is outlandishly large.
3948 Don't mishandle offset == INT_MIN.
3950 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3951 when creating daemon; the previous buffer-overflow check was incorrect.
3953 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3954 which has the guts of the old verror function.
3956 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3957 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3959 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3960 (font_unparse_xlfd): Don't blindly alloca long strings.
3961 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3962 fits in int, when using sprintf. Use single snprintf to count
3963 length of string rather than counting it via multiple sprintfs;
3964 that's simpler and more reliable.
3965 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3966 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3967 sprintf, in case result does not fit in int.
3969 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3970 (fontset_from_font): Print it.
3972 * frame.c (tty_frame_count): Now printmax_t, not int.
3973 (make_terminal_frame, set_term_frame_name): Print it.
3974 (x_report_frame_params): In X, window IDs are unsigned long,
3975 not signed long, so print them as unsigned.
3976 (validate_x_resource_name): Check for implausibly long names,
3977 and don't assume name length fits in 'int'.
3978 (x_get_resource_string): Don't blindly alloca invocation name;
3979 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3982 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3983 (xg_check_special_colors, xg_set_geometry):
3984 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3986 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3987 Use esprintf, not sprintf, in case result does not fit in int.
3989 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3990 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3991 it as a large positive number.
3992 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3993 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3995 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3996 in case result does not fit in int.
3998 * print.c (float_to_string): Detect width overflow more reliably.
3999 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4000 buffer overrun. Don't assume list length fits in 'int'. Treat
4001 print length of 0 as 0, not as infinity; to be consistent with other
4002 uses of print length in this function. Don't overflow print length
4003 index. Don't assume hash table size fits in 'long', or that
4004 vectorlike size fits in 'unsigned long'.
4006 * process.c (make_process): Use printmax_t, not int, to format
4007 process-name gensyms.
4009 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4011 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4012 to avoid potential buffer overrun.
4014 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4015 if X resource line is longer than 512 bytes.
4017 * xfns.c (x_window): Make sprintf buffer a bit bigger
4018 to avoid potential buffer overrun.
4020 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4022 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4024 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4026 Integer overflow fixes for scrolling, etc.
4027 Without these, Emacs silently mishandles large integers sometimes.
4028 For example, "C-u 4294967297 M-x recenter" was treated as if
4029 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4031 * xdisp.c (try_window_id): Check Emacs fixnum range before
4032 converting to 'int'.
4034 * window.c (window_scroll_line_based, Frecenter):
4035 Check that an Emacs fixnum is in range before assigning it to 'int'.
4036 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4037 values converted from Emacs fixnums.
4038 (Frecenter): Don't wrap around a line count if it is out of 'int'
4039 range; instead, treat it as an extreme value.
4040 (Fset_window_configuration, compare_window_configurations):
4041 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4043 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4044 that can exceed INT_MAX. Check that EMACS_INT value is in range
4045 before assigning it to the (possibly-narrower) index.
4046 (match_limit): Don't assume that a fixnum can fit in 'int'.
4048 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4051 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4052 (Fvertical_motion): Don't wrap around LINES values that don't fit
4053 in 'int'. Instead, treat them as extreme values. This is good
4054 enough for windows, which can't have more than INT_MAX lines anyway.
4056 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4058 * Require libxml/parser.h to avoid compilation warning.
4060 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4062 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4063 since this reportedly can destroy thread storage.
4065 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4067 * syntax.c (find_defun_start): Update all cache variables if
4068 exiting early (Bug#9401).
4070 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4072 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4074 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4075 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4076 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4078 * term.c (tty_append_glyph): New function.
4079 (produce_stretch_glyph): Static function and its prototype deleted.
4081 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4084 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4086 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4087 when checking :margin (Bug#9390).
4088 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4089 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4090 so that the name doesn't mislead. All uses changed.
4092 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4094 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4097 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4099 * xdisp.c (move_it_to): Don't bail out early when reaching
4100 position beyond to_charpos, if we are scanning backwards.
4101 (move_it_vertically_backward): When DY == 0, make sure we get to
4102 the first character in the line after the newline.
4104 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4106 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4107 (ccl_driver): Do not generate an out-of-range pointer.
4108 (Fccl_execute_on_string): Remove unnecessary check for
4109 integer overflow, noted by Stefan Monnier in
4110 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4111 Remove a FIXME that didn't need fixing.
4112 Simplify the newly-introduced buffer reallocation code.
4114 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4116 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4118 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4120 Integer and memory overflow issues (Bug#9196).
4122 * doc.c (get_doc_string): Rework so that
4123 get_doc_string_buffer_size is the actual buffer size, rather than
4124 being 1 less than the actual buffer size; this makes xpalloc more
4127 * image.c (x_allocate_bitmap_record, cache_image):
4128 * xselect.c (Fx_register_dnd_atom):
4129 Simplify previous changes by using xpalloc.
4131 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4132 since either will do and ptrdiff_t is convenient with xpalloc.
4134 * charset.c (charset_table_size)
4135 (struct charset_sort_data.priority): Now ptrdiff_t.
4136 (charset_compare): Don't overflow if priorities differ greatly.
4137 (Fsort_charsets): Don't assume list length fits in int.
4138 Check for size-calculation overflow when allocating sort data.
4139 (syms_of_charset): Allocate an initial charset table that is
4140 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4142 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4144 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4145 The actual value is always <= INT_MAX, and leaving it unsigned made
4146 overflow checking harder.
4148 * dispextern.h (struct glyph_matrix.rows_allocated)
4149 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4150 with xpalloc. The values are still always <= INT_MAX.
4152 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4154 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4155 (SAFE_NALLOCA): New macro.
4157 * region-cache.c (struct boundary.pos, find_cache_boundary)
4158 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4159 (set_cache_region, invalidate_region_cache)
4160 (revalidate_region_cache, know_region_cache, region_cache_forward)
4161 (region_cache_backward, pp_cache):
4162 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4163 so that ptrdiff_t * can be passed to xpalloc.
4164 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4165 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4166 (pp_cache): Don't assume cache_len fits in int.
4167 * region-cache.h: Adjust extern decls to match.
4169 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4170 EMACS_INT, since either will do, for xpalloc.
4172 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4173 (xnmalloc, xnrealloc, xpalloc): New functions.
4175 * bidi.c (bidi_shelve_header_size): New constant.
4176 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4177 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4179 * bidi.c (bidi_cache_shrink):
4180 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4182 Don't update size of array until after memory allocation succeeds,
4183 because xmalloc/xrealloc may not return.
4184 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4185 now that we have proper integer overflow checking.
4186 (record_overlay_string, overlay_strings): Catch overflows when
4187 calculating size of overlay_str_buf.
4189 * callproc.c (Fcall_process): Check for size overflow when
4190 calculating size of args2.
4191 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4192 Normally we prefer signed values, but sticking with ptrdiff_t would
4193 require adding more-complicated checks.
4195 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4196 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4197 Redo buffer-overflow calculations to avoid integer overflow.
4198 Add a FIXME comment where memory seems to be over-allocated.
4200 * character.c (Fstring): Check for size-calculation overflow.
4202 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4203 unnecessary integer overflow. Check for size overflow.
4204 (encode_coding_object): Don't update size until xmalloc succeeds.
4206 * composite.c (get_composition_id): Check for overflow in glyph
4207 length calculations.
4209 Integer and memory overflow fixes for display code.
4210 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4211 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4212 (scrolling_window): Check for overflow in size calculations.
4213 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4214 Don't assume glyph table len fits in int.
4215 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4216 (row_table_size): Now ptrdiff_t, not int.
4217 (scrolling_window): Avoid overflow in size calculations.
4218 Don't update size until allocation succeeds.
4219 * fns.c (concat): Check for overflow in size calculations.
4220 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4221 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4222 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4224 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4225 (get_doc_string): Check for size calculation overflow.
4226 Don't update size until allocation succeeds.
4227 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4228 EMACS_INT, where ptrdiff_t will do.
4229 (Fsubstitute_command_keys): Check for string overflow.
4231 * editfns.c (set_time_zone_rule): Don't assume environment length
4233 (message_length): Now ptrdiff_t, not int.
4234 (Fmessage_box): Don't update size until allocation succeeds.
4235 Don't assume message length fits in int.
4236 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4238 * emacs.c (main): Do not reallocate argv, since there is a null at
4239 the end that can be overwritten, and this way there's no need to
4240 worry about size-calculation overflow.
4241 (sort_args): Check for size-calculation overflow.
4243 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4245 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4247 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4248 (x_set_scroll_bar_width, x_figure_window_size):
4249 Check for integer overflow.
4250 (x_set_alpha): Do not assume XINT fits in int.
4252 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4253 This is for the members text_lines, text_cols, total_lines, total_cols,
4254 where the system imposes an 'int' limit.
4256 * fringe.c (Fdefine_fringe_bitmap):
4257 Don't update size until alloc works.
4259 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4260 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4262 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4263 Check for size-calculation overflow.
4264 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4265 do, as we prefer signed integers.
4266 (id_to_widget.max_size, id_to_widget.used)
4267 (xg_store_widget_in_map, xg_remove_widget_from_map)
4268 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4269 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4270 Use and return ptrdiff_t, not int.
4271 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4272 * gtkutil.h: Change prototypes to match the above.
4274 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4275 are duplicate now that they've been promoted to lisp.h.
4276 (x_allocate_bitmap_record, x_alloc_image_color)
4277 (make_image_cache, cache_image, xpm_load):
4278 Don't update size until alloc is done.
4279 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4281 Check for size calculation overflow.
4282 (ct_colors_allocated_max): New constant.
4283 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4286 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4287 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4288 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4289 Use ptrdiff_t, not int, to count maps.
4290 (read_char_minibuf_menu_prompt): Check for overflow in size
4291 calculations. Don't update size until allocation succeeds.
4292 Redo calculations to avoid overflow.
4293 * keyboard.h: Change prototypes to match the above.
4295 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4297 (current_minor_maps): Check for size calculation overflow.
4298 * keymap.h: Change prototypes to match the above.
4300 * lread.c (read1, init_obarray): Don't update size until alloc done.
4302 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4303 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4305 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4306 Now ptrdiff_t, not int.
4307 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4308 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4310 * process.c (Fnetwork_interface_list): Check for overflow
4311 in size calculation.
4313 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4315 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4316 overflow. Don't bother calling xmalloc when xrealloc will do.
4318 * search.c (Freplace_match): Check for size calculation overflow.
4319 (Fset_match_data): Don't assume list lengths fit in 'int'.
4321 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4322 for command line length. Do not attempt to address one before the
4323 beginning of an array, as that's not portable.
4325 * term.c (max_frame_lines): Remove; unused.
4326 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4328 (encode_terminal_code, calculate_costs): Check for size
4329 calculation overflow.
4330 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4331 table lengths and related sizes. Don't update size until alloc
4332 done. Redo calculations to avoid overflow.
4333 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4335 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4336 subtracting pointers.
4337 (gobble_line): Check for overflow more carefully. Don't update size
4340 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4341 Don't update size until alloc done.
4342 Redo size calculations to avoid overflow.
4343 Check for size calculation overflow.
4344 (main) [DEBUG]: Fix typo in invoking tparam1.
4346 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4347 Use ptrdiff_t, not int, for sizes.
4348 (store_mode_line_noprop_char): Don't update size until alloc done.
4350 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4351 Use ptrdiff_t, not int, for sizes.
4352 (Finternal_make_lisp_face, cache_face):
4353 Check for size calculation overflow.
4354 (cache_face): Treat size calculation overflows as if they were
4355 memory exhaustion (the usual treatment), rather than aborting.
4357 * xfns.c (x_encode_text, x_set_name_internal)
4358 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4359 sizes, since they can exceed INT_MAX in size. Check for size
4360 calculation overflow.
4362 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4363 (xg_select): Check for size calculation overflow.
4364 Don't update size until alloc done.
4366 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4367 as sprintf is limited to int lengths.
4369 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4370 (X_LONG_MIN): New macros.
4371 Use them to make the following changes clearer.
4372 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4373 This change doesn't affect the value now, but it may help remind
4374 future maintainers not to raise the value too much later.
4375 (SELECTION_QUANTUM): Remove, replacing with ...
4376 (selection_quantum): ... new function, which avoids overflow.
4378 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4379 assumption that selection length fits in 'int'.
4380 (x_reply_selection_request, x_handle_selection_request)
4381 (x_get_window_property, receive_incremental_selection)
4382 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4383 (lisp_data_to_selection_data, clean_local_selection_data):
4384 Use ptrdiff_t, not int, to record length of selection.
4385 (x_reply_selection_request, x_get_window_property)
4386 (receive_incremental_selection, x_property_data_to_lisp):
4387 Redo calculations to avoid overflow.
4388 (x_reply_selection_request): When sending hint, ceiling it at
4389 X_LONG_MAX rather than relying on wraparound overflow to send
4391 (x_get_window_property, receive_incremental_selection)
4392 (lisp_data_to_selection_data, x_property_data_to_lisp):
4393 Check for size-calculation overflow.
4394 (x_get_window_property, receive_incremental_selection)
4395 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4396 Don't store size until memory allocation succeeds.
4397 (x_get_window_property): Plug memory leak on memory exhaustion.
4398 Don't double-block input; malloc is safe here. Don't assume 2**34
4399 - 4 fits in unsigned long. Add an xassert to check
4400 XGetWindowProperty overflow. Be more careful about overflow
4401 calculations, and distinguish size from memory overflow better.
4402 (receive_incremental_selection): When tracing, don't assume
4403 unsigned int is less than INT_MAX.
4404 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4405 harmful) conversions of unsigned short to int.
4406 (lisp_data_to_selection_data): Don't assume that integers
4407 in the range -65535 through -1 fit in an X unsigned short.
4408 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4409 result parameters unless successful. Rely on cons_to_unsigned
4410 to report problems with elements; the old code wasn't right anyway.
4411 (x_check_property_data): Check for int overflow; we cannot use
4412 a wider type due to X limits.
4413 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4415 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4417 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4418 (x_term_init): Check for size calculation overflow.
4419 (x_color_cells): Don't store size until memory allocation succeeds.
4420 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4421 Don't assume alloca size is less than MAX_ALLOCA.
4422 (x_term_init): Don't assume length fits in int (sprintf is limited
4425 Use ptrdiff_t for composition IDs.
4426 * character.c (lisp_string_width):
4427 * composite.c (composition_table_size, n_compositions)
4428 (get_composition_id, composition_gstring_from_id):
4429 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4430 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4431 * window.c (Frecenter):
4432 Use ptrdiff_t, not int, for composition IDs.
4433 * composite.c (get_composition_id): Check for integer overflow.
4434 * composite.h: Adjust prototypes to match the above changes.
4436 Use ptrdiff_t for hash table indexes.
4437 * category.c (hash_get_category_set):
4438 * ccl.c (ccl_driver):
4439 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4440 * coding.c (coding_system_charset_list, detect_coding_system):
4441 * coding.h (struct coding_system.id):
4442 * composite.c (get_composition_id, gstring_lookup_cache):
4443 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4444 * image.c (xpm_get_color_table_h):
4445 * lisp.h (hash_lookup, hash_put):
4446 * minibuf.c (Ftest_completion):
4447 Use ptrdiff_t for hash table indexes, not int (which is too
4448 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4449 32-bit --with-wide-int hosts).
4451 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4452 Add a FIXME comment about memory leaks.
4453 (syms_of_charset): Don't assume xmalloc returns.
4455 Don't assume that stated character widths fit in int.
4456 * character.c (Fchar_width, c_string_width, lisp_string_width):
4457 * character.h (CHAR_WIDTH):
4458 * indent.c (MULTIBYTE_BYTES_WIDTH):
4459 Use sanitize_char_width to avoid undefined and/or bad behavior
4460 with outlandish widths.
4461 * character.h (sanitize_tab_width): Rename from sanitize_width,
4462 now that we have two such functions. All uses changed.
4463 (sanitize_char_width): New inline function.
4465 Don't assume that tab-width fits in int.
4466 * character.h (sanitize_width): New inline function.
4467 (SANE_TAB_WIDTH): New macro.
4468 (ASCII_CHAR_WIDTH): Use it.
4469 * indent.c (sane_tab_width): Remove. All uses replaced by
4470 SANE_TAB_WIDTH (current_buffer).
4471 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4473 * fileio.c: Integer overflow issues with file modes.
4474 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4476 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4477 Remove unreachable code.
4478 (read_hex, load_charset_map_from_file): Check for integer overflow.
4480 * xterm.c: Don't go over XClientMessageEvent limit.
4481 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4482 (x_send_scroll_bar_event): Likewise. Check that the size does not
4483 exceed limits imposed by XClientMessageEvent, as well as the usual
4484 ptrdiff_t and size_t limits.
4486 * keyboard.c: Overflow, signedness and related fixes.
4487 (make_lispy_movement): Use same integer type in forward decl
4488 that is used in the definition.
4489 (read_key_sequence, keyremap_step):
4490 Change bufsize argument back to int, undoing my 2011-03-30 change.
4491 We prefer signed types, and int is wide enough here.
4492 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4493 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4494 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4495 length, not size_t. Use ptrdiff_t for index, not int.
4496 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4497 possibility of integer overflow.
4499 Overflow, signedness and related fixes for images.
4501 * dispextern.h (struct it.stack[0].u.image.image_id)
4502 (struct_it.image_id, struct image.id, struct image_cache.size)
4503 (struct image_cache.used, struct image_cache.ref_count):
4504 * gtkutil.c (update_frame_tool_bar):
4505 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4506 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4507 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4508 * nsmenu.m (update_frame_tool_bar):
4509 * xdisp.c (calc_pixel_width_or_height):
4510 * xfns.c (image_cache_refcount):
4511 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4512 on typical 64-bit hosts.
4514 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4515 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4516 Omit unnecessary casts to int.
4517 (parse_image_spec): Check that integers fall into 'int' range
4518 when the callers expect that.
4519 (image_ascent): Redo ascent calculation to avoid int overflow.
4520 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4521 (lookup_image): Remove unnecessary tests.
4522 (xbm_image_p): Locals are now of int, not EMACS_INT,
4523 since parse_image_check makes sure they fit into int.
4524 (png_load, gif_load, svg_load_image):
4525 Prefer int to unsigned where either will do.
4526 (tiff_handler): New function, combining the cores of the
4527 old tiff_error_handler and tiff_warning_handler.
4528 This function is rewritten to use vsnprintf and thereby avoid
4529 stack buffer overflows. It uses only the features of vsnprintf
4530 that are common to both POSIX and native Microsoft.
4531 (tiff_error_handler, tiff_warning_handler): Use it.
4532 (tiff_load, gif_load, imagemagick_load_image):
4533 Don't assume :index value fits in 'int'.
4534 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4535 (imagemagick_load_image): Check that crop parameters fit into
4536 the integer types that MagickCropImage accepts. Don't assume
4537 Vimagemagick_render_type has a nonnegative value. Don't assume
4538 size_t fits in 'long'.
4539 (gs_load): Use printmax_t to print the widest integers possible.
4540 Check for integer overflow when computing image height and width.
4542 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4544 * xdisp.c (redisplay_window): Don't force window start if point
4545 will be invisible in the resulting window. (Bug#9324)
4547 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4549 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4550 the display spec is of the form `(space ...)'.
4551 (handle_display_spec): Return the value returned by
4552 handle_single_display_spec, not just 1 or zero.
4553 (handle_single_display_spec): If the display spec is of the form
4554 `(space ...)', and specifies display in the text area, return 2
4556 (try_cursor_movement): Check for the need to scroll more
4557 accurately, and prefer exact match for point under bidi.
4558 Don't advance `row' beyond the last row of the window.
4560 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4561 into disp_prop; all users changed.
4563 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4564 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4565 for the text covered by the display property.
4567 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4569 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4570 Change return value to nil.
4571 (Frecord_buffer): Delete unused function.
4573 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4575 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4576 buffers, return left-to-right.
4577 (set_cursor_from_row): Consider candidate row a win if its glyph
4578 represents a newline and point is on that newline. Fixes cursor
4579 positioning on the newline at EOL of R2L text within L2R
4580 paragraph, and vice versa.
4581 (try_cursor_movement): Check continued rows, in addition to
4582 continuation rows. Fixes unwarranted scroll when point enters a
4583 continued line of R2L text within an L2R paragraph, or vice versa.
4584 (cursor_row_p): Consider the case of point being equal to
4585 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4586 from the end of a short line to the beginning of a continued line
4587 of R2L text within L2R paragraph.
4588 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4589 composed characters.
4591 * bidi.c (bidi_check_type): Use xassert.
4592 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4595 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4597 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4600 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4602 * nsfont.m (ns_otf_to_script): Fix typo.
4604 2011-08-22 Kenichi Handa <handa@m17n.org>
4606 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4607 extra slot even if the purpose is char-code-property-table.
4609 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4611 * xdisp.c (redisplay_window): When computing centering_position,
4612 account for the height of the header line. (Bug#8874)
4614 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4615 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4616 candidate is selected by the mouse, and that candidate has a
4617 composed character under the mouse.
4619 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4620 coordinates reported by pos-visible-in-window-p for a composed
4621 character in column zero.
4623 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4625 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4627 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4629 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4630 consider it a hit if to_charpos is anywhere in the range of the
4631 composed buffer positions.
4633 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4635 * image.c (gif_load): Don't assume that each subimage has the same
4636 dimensions as the base image. Handle disposal method that is
4637 "undefined" by the gif spec (Bug#9335).
4639 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4641 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4642 (Fcondition_case): Document `debug' symbol in error handler.
4644 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4646 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4647 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4648 from an Org mode buffer to a Speedbar frame.
4650 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4651 a composition, take its buffer position from IT->cmp_it.charpos.
4652 Fixes cursor positioning at the beginning of a line that begins
4653 with a composed character.
4655 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4657 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4658 character bidirectional type, use STRONG_L instead. Fixes crashes
4659 in a buffer produced by `describe-categories'.
4661 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4662 members before the level stack, so they would be saved and
4663 restored when copying iterator state. Fixes incorrect reordering
4664 around TABs covered by display properties.
4666 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4668 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4670 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4672 * eval.c (internal_condition_case, internal_condition_case_1)
4673 (internal_condition_case_2, internal_condition_case_n):
4674 Remove unnecessary aborts (Bug#9081).
4676 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4678 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4679 has no `load' handler, try opening the file locally. (Bug#9311)
4681 2011-08-16 Ken Brown <kbrown@cornell.edu>
4683 * gmalloc.c: Expand comment.
4685 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4687 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4688 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4690 2011-08-16 Ken Brown <kbrown@cornell.edu>
4692 Fix memory allocation problems in Cygwin build (Bug#9273).
4694 * unexcw.c ( __malloc_initialized): Declare external variable.
4695 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4697 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4699 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4701 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4703 [CYGWIN] (special_realloc): New function.
4704 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4705 requests to realloc storage in the static heap.
4707 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4709 * bidi.c (bidi_initialize): Remove unused local.
4711 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4714 * biditype.h: Remove file.
4715 * makefile.w32-in ($(BLD)/bidi.$(O)):
4716 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4718 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4720 * chartab.c: Improve commentary for the uniprop_table API.
4722 * bidi.c (bidi_paragraph_init): Support zero value of
4723 bidi_ignore_explicit_marks_for_paragraph_level.
4724 (bidi_initialize): Use uniprop_table instead of including
4725 biditype.h and bidimirror.h.
4727 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4728 coordinates of the iterator when restoring from ppos_it.
4731 2011-08-14 Kenichi Handa <handa@m17n.org>
4733 * process.c (create_process): Call setup_process_coding_systems
4734 after the pid of the process is set to -1 (Bug#8162).
4736 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4738 * xdisp.c (move_it_in_display_line_to): Don't invoke
4739 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4740 ppos_it. Fixes vertical cursor motion when line beginning is
4741 covered by an image. (Bug#9296)
4743 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4745 * nsterm.h (ns_run_ascript): Declare.
4746 (NSAPP_DATA2_RUNASSCRIPT): Define.
4748 * nsfns.m (as_script, as_result, as_status): New static variables.
4749 (ns_run_ascript): New function.
4750 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4751 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4752 the event loop. Get status from as_status (Bug#7276).
4754 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4755 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4756 the event loop (Bug#7276).
4758 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4760 * gnutls.c (QCgnutls_bootprop_priority)
4761 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4762 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4763 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4764 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4765 (QCgnutls_bootprop_verify_hostname_error)
4766 (QCgnutls_bootprop_callbacks_verify): Rename from
4767 Qgnutls_bootprop_..., all uses changed.
4769 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4772 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4774 * xfaces.c (Qframe_set_background_mode): Now static.
4775 * dispextern.h (Qframe_set_background_mode): Remove decl.
4777 * process.c (Fnetwork_interface_info): Declare local only if needed.
4779 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4781 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4782 (Fnetwork_interface_list): Allocate in increments of bytes instead
4783 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4784 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4786 (struct ifflag_def): notrailers is smart on OSX.
4787 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4788 Get hardware address with getifaddrs if available.
4790 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4792 * xdisp.c (iterate_out_of_display_property): xassert that
4793 IT->position is set to within IT->object's boundaries. Break from
4794 the loop as soon as EOB is reached; avoids infloops in redisplay
4795 when IT->position is set up wrongly due to some bug.
4796 Set IT->current to match the bidi iterator unconditionally.
4797 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4798 entry. Force push_it to save on the stack the current
4799 buffer/string position, to be restored by pop_it. Fix flags in
4800 the iterator structure wrt the object coming from a display
4801 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4802 properties. (Bug#9284)
4804 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4806 * fontset.c (fontset_get_font_group): Add proper type checks.
4809 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4811 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4812 and LC_VERSION_MIN_MACOSX.
4813 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4814 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4816 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4818 * xdisp.c (forward_to_next_line_start): Allow to use the
4819 no-display-properties-and-no-overlays under bidi display.
4820 Set disp_pos in the bidi iterator to avoid searches for display
4821 properties and overlays.
4823 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4825 * editfns.c (Fset_time_zone_rule): Document relationship with the
4828 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4829 the font entity extracted from the cache (Bug#8109).
4831 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4833 * composite.c (autocmp_chars): Don't reset point. That is done by
4834 restore_point_unwind (Bug#5984).
4836 2011-08-07 Juri Linkov <juri@jurta.org>
4838 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4839 to show the arg `TIME' instead of `TIMEVAL'.
4841 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4843 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4844 display property strides EOL and includes a newline, as in
4845 longlines-mode. (Bug#9254)
4846 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4847 word-wrap under bidirectional display. (Bug#9224)
4849 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4850 is non-zero, even if the data buffer is NULL. Fixes a crash in
4851 vertical-motion with longlines-mode. (Bug#9254)
4853 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4855 * bidi.c <bidi_cache_total_alloc>: Now static.
4856 (bidi_initialize): Initialize bidi_cache_total_alloc.
4858 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4861 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4862 amount allocated this far in `bidi_cache_total_alloc'.
4863 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4864 non-zero, only free the data buffer without restoring the cache
4865 contents. All callers changed.
4867 * dispextern.h (bidi_unshelve_cache): Update prototype.
4869 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4870 (move_it_in_display_line, move_it_to)
4871 (move_it_vertically_backward, move_it_by_lines): Replace the call
4872 to xfree to an equivalent call to bidi_unshelve_cache.
4873 (move_it_in_display_line_to): Fix logic of returning
4874 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4876 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4878 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4879 came from a string character with a `cursor' property. (Bug#9229)
4881 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4883 * Makefile.in (LIB_PTHREAD): New variable.
4884 (LIBES): Add LIB_PTHREAD (Bug#9216).
4886 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4887 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4889 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4891 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4893 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4895 * xterm.c (x_find_topmost_parent): New function.
4896 (x_set_frame_alpha): Find topmost parent window with
4897 x_find_topmost_parent and set the property there also (bug#9181).
4898 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4900 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4902 * callproc.c (Fcall_process): Avoid vfork clobbering
4903 the local vars buffer, coding_systems, current_dir.
4905 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4907 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4909 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4911 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4912 so that it is not optimized away.
4914 * xdisp.c (compute_display_string_pos): Remove unused local.
4916 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4918 Fix slow cursor motion and scrolling in large buffers with
4919 selective display, like Org Mode buffers. (Bug#9218)
4921 * dispextern.h (struct bidi_it): New member disp_prop_p.
4923 * xdisp.c: Remove one-slot cache of display string positions.
4924 (compute_display_string_pos): Accept an additional argument
4925 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4926 for a display string or property. If found, set DISP_PROP_P
4929 * bidi.c (bidi_fetch_char): Accept an additional argument
4930 DISP_PROP_P, and pass it to compute_display_string_pos.
4931 Only handle text covered by a display string if DISP_PROP_P is returned
4932 non-zero. All callers of bidi_fetch_char changed.
4934 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4936 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4938 2010-12-03 Don March <don@ohspite.net>
4940 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4941 last character M-[char] is translated to ESC [char] (bug#7541).
4943 2011-08-02 Kenichi Handa <handa@m17n.org>
4945 * lisp.h (uniprop_table): Extern it.
4947 * chartab.c (uniprop_table): Make it non-static.
4949 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4951 * xdisp.c (forward_to_next_line_start): Accept additional argument
4952 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4954 (reseat_at_next_visible_line_start): Use the bidi iterator state
4955 returned by forward_to_next_line_start to restore the state of
4956 it->bidi_it after backing up to previous newline. (Bug#9212)
4958 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4960 * regex.c (re_comp): Protoize.
4961 (re_exec): Fix return type.
4962 (regexec): Fix type of `ret'. (Bug#9203)
4964 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4966 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4967 This is needed if max-image-size is a floating-point number.
4969 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4971 * print.c (print_object): Print empty symbol as ##.
4973 * lread.c (read1): Read ## as empty symbol.
4975 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4977 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4978 setting frame foreground color (Bug#9175).
4979 (x_set_background_color): Likewise.
4981 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4982 contents (Bug#9176).
4983 (EmacsTooltip -init): Remove bezels and add shadows to
4986 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4987 or scroll bar (Bug#8470).
4989 * nsfont.m (nsfont_open): Remove assignment to voffset and
4990 unnecessary vars hshink, expand, hd, full_height, min_height.
4991 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4993 * nsterm.h (nsfont_info): Remove voffset field.
4995 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4997 Implement strike-through and overline on NextStep (Bug#8863).
4999 * nsfont.m (nsfont_open): Use underline position provided by font,
5000 instead of hard-coded value of 2.
5001 (nsfont_draw): Call ns_draw_text_decoration instead.
5003 * nsterm.h: Add declaration for ns_draw_text_decoration.
5005 * nsterm.m (ns_draw_text_decoration): New function for drawing
5006 underline, overline, and strike-through.
5007 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5008 ns_draw_text_decoration. Change treatment of cursor drawing to
5009 accommodate underlining, etc.
5011 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5013 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5016 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5018 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5019 Without this fix, if a signal arrives just after memory fills up,
5020 'malloc' might be invoked reentrantly.
5022 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5023 In other words, assume that every image size is allowed, on non-X
5024 hosts. This assumption is probably wrong, but it lets Emacs compile.
5026 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5028 * regex.c (re_iswctype): Convert return values to boolean.
5030 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5032 * xdisp.c (compute_display_string_pos): Don't use cached display
5033 string position if the buffer had its restriction changed.
5036 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5038 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5040 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5042 Integer signedness and overflow and related fixes. (Bug#9079)
5044 * bidi.c: Integer size and overflow fixes.
5045 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5046 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5047 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5048 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5049 (bidi_find_other_level_edge):
5050 Use ptrdiff_t instead of EMACS_INT where either will do.
5051 This works better on 32-bit hosts configured --with-wide-int.
5052 (bidi_cache_ensure_space): Check for size-calculation overflow.
5053 Use % rather than repeated addition, for better worst-case speed.
5054 Don't set bidi_cache_size until after xrealloc returns, because it
5056 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5057 (bidi_cache_ensure_space): Also check that the bidi cache size
5058 does not exceed that of the largest Lisp string or buffer. See Eli
5059 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5061 * alloc.c (__malloc_size_t): Remove.
5062 All uses replaced by size_t. See Andreas Schwab's note
5063 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5065 * image.c: Improve checking for integer overflow.
5066 (check_image_size): Assume that f is nonnull, since
5067 it is always nonnull in practice. This is one less thing to
5068 worry about when checking for integer overflow later.
5069 (x_check_image_size): New function, which checks for integer
5070 overflow issues inside X.
5071 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5072 This removes the need for a memory_full check.
5073 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5074 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5075 (xbm_read_bitmap_data): Change locals back to 'int', since
5076 their values must fit in 'int'.
5077 (xpm_load_image, png_load, tiff_load):
5078 Invoke x_create_x_image_and_pixmap earlier,
5079 to avoid much needless work if the image is too large.
5080 (tiff_load): Treat overly large images as if
5081 x_create_x_image_and_pixmap failed, not as malloc failures.
5082 (gs_load): Use x_check_image_size.
5084 * gtkutil.c: Omit integer casts.
5085 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5086 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5088 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5090 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5091 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5092 would wrongly return t on a 64-bit host.
5094 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5095 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5096 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5097 and therefore cause GCC to emit a bogus diagnostic in some cases.
5099 * image.c: Integer signedness and overflow and related fixes.
5100 This is not an exhaustive set of fixes, but it's time to
5101 record what I've got.
5102 (lookup_pixel_color, check_image_size): Remove redundant decls.
5103 (check_image_size): Don't assume that arbitrary EMACS_INT values
5104 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5105 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5106 (tiff_load, imagemagick_load_image):
5107 Check for overflow in size calculations.
5108 (x_create_x_image_and_pixmap): Remove unnecessary test for
5109 xmalloc returning NULL; that can't happen.
5110 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5111 (xpm_color_bucket): Use better integer hashing function.
5112 (xpm_cache_color): Don't possibly over-allocate memory.
5113 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5114 (gif_memory_source):
5115 Use ptrdiff_t, not int or size_t, to record sizes.
5116 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5117 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5118 either works, as we prefer signed integers.
5119 (tiff_read_from_memory, tiff_write_from_memory):
5120 Return tsize_t, not size_t, since that's what the TIFF API wants.
5121 (tiff_read_from_memory): Don't fail simply because the read would
5122 go past EOF; instead, return a short read.
5123 (tiff_load): Omit no-longer-needed casts.
5124 (Fimagemagick_types): Don't assume size fits into 'int'.
5126 Improve hashing quality when configured --with-wide-int.
5127 * fns.c (hash_string): New function, taken from sxhash_string.
5128 Do not discard information about ASCII character case; this
5129 discarding is no longer needed.
5130 (sxhash-string): Use it. Change sig to match it. Caller changed.
5131 * lisp.h: Declare it.
5132 * lread.c (hash_string): Remove, since we now use fns.c's version.
5133 The fns.c version returns a wider integer if --with-wide-int is
5134 specified, so this should help the quality of the hashing a bit.
5136 * emacs.c: Integer overflow minor fix.
5137 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5138 Define only if GNU_LINUX.
5139 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5141 * dispnew.c: Integer signedness and overflow fixes.
5142 Remove unnecessary forward decls, that were a maintenance hassle.
5143 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5145 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5146 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5147 (prepare_desired_row, line_draw_cost):
5148 Use int, not unsigned, where either works.
5149 (save_current_matrix, restore_current_matrix):
5150 Use ptrdiff_t, not size_t, where either works.
5151 (init_display): Check for overflow more accurately, and without
5152 relying on undefined behavior.
5154 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5155 Remove, replacing with the new symbols in lisp.h. All uses changed.
5156 * fileio.c (make_temp_name):
5157 * filelock.c (lock_file_1, lock_file):
5158 * xdisp.c (message_dolog):
5159 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5160 Use pMd etc. instead.
5161 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5162 replacing the pWIDE etc. symbols removed from editfns.c.
5164 * keyboard.h (num_input_events): Now uintmax_t.
5165 This is (very slightly) less likely to mess up due to wraparound.
5168 * buffer.c: Integer signedness fixes.
5169 (alloc_buffer_text, enlarge_buffer_text):
5170 Use ptrdiff_t rather than size_t when either will do, as we prefer
5173 * alloc.c: Integer signedness and overflow fixes.
5174 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5175 (__malloc_size_t): Default to size_t, not to int.
5176 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5177 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5178 Prefer ptrdiff_t to size_t when either would do, as we prefer
5180 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5181 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5182 Now const. Initialize with values that are in range even if char
5184 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5185 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5186 These functions do the right thing with sizes > 2**32.
5187 (check_depth): Now ptrdiff_t, not int.
5188 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5189 Adjust to new way of storing sizes. Check for size overflow bugs
5191 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5192 slightly wrong anyway, as it missed one instance of
5193 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5194 (refill_memory_reserve): Omit needless cast to size_t.
5195 (mark_object_loop_halt): Mark as externally visible.
5197 * xselect.c: Integer signedness and overflow fixes.
5198 (Fx_register_dnd_atom, x_handle_dnd_message):
5199 Use ptrdiff_t, not size_t, since we prefer signed.
5200 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5201 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5202 x_dnd_atoms_size and x_dnd_atoms_length.
5204 * doprnt.c: Prefer signed to unsigned when either works.
5206 * doprnt.c (doprnt):
5208 * xdisp.c (vmessage):
5209 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5210 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5211 prefer signed arithmetic to avoid comparison confusion.
5212 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5213 but is a bit tricky.
5215 Assume freestanding C89 headers, string.h, stdlib.h.
5216 * data.c, doprnt.c, floatfns.c, print.c:
5217 Include float.h unconditionally.
5218 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5219 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5220 * regex.c: Likewise for stddef.h, string.h.
5221 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5222 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5223 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5224 (STDC_HEADERS): Remove obsolete defines.
5225 * sysdep.c: Include limits.h unconditionally.
5227 Assume support for memcmp, memcpy, memmove, memset.
5228 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5229 * regex.c (memcmp, memcpy):
5230 Remove; we assume C89 now.
5232 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5233 (__malloc_safe_bcopy): Remove; no longer needed.
5235 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5236 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5237 well either way, and we prefer signed to unsigned.
5239 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5241 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5242 closes the connection while we're reading (bug#9182).
5244 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5246 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5247 are specified (Bug#9168).
5249 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5251 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5252 Found by GCC static checking and --with-wide-int on a 32-bit host.
5254 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5256 * xdisp.c (compute_display_string_pos): Fix logic of caching
5257 previous display string position. Initialize cached_prev_pos to
5258 -1. Fixes slow-down at the beginning of a buffer.
5260 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5262 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5263 for attrs[LFACE_FONTSET_INDEX].
5265 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5267 * xml.c (parse_region): Remove unused local
5268 that was recently introduced.
5270 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5272 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5273 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5275 * xdisp.c (move_it_in_display_line_to): Record the best matching
5276 position for TO_CHARPOS while scanning the line, and restore it on
5277 exit if none of the characters scanned was an exact match.
5278 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5279 when exact match is impossible due to invisible text, and the
5280 lines are truncated.
5282 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5284 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5287 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5289 Fix a significant slow-down of cursor motion with C-n, C-p,
5290 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5291 auto-repeat under bidi redisplay in fontified buffers.
5292 * xdisp.c (compute_stop_pos_backwards): New function.
5293 (next_element_from_buffer): Call compute_stop_pos_backwards to
5294 find a suitable prev_stop when we find ourselves before
5296 (reseat): Don't look for prev_stop, as that could mean a very long
5298 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5299 <cached_disp_overlay_modiff>: Cache for last found display string
5301 (compute_display_string_pos): Return the cached position if asked
5302 about the same buffer in the same area of character positions, and
5303 the buffer wasn't changed since the time the display string
5304 position was cached.
5306 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5308 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5309 is an integer, which is important for empty lines. (Bug#9149)
5311 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5313 * frame.c (Fmodify_frame_parameters): In tty case, update the
5314 default face if necessary (Bug#4238).
5316 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5318 * editfns.c (Fstring_to_char): No need to explain what a character
5319 is in the docstring (Bug#6576).
5321 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5323 * xml.c (parse_region): Make sure we always return a tree.
5325 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5327 * xml.c (parse_region): If a document contains only comments,
5330 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5332 * xml.c (make_dom): Return comments, too.
5334 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5337 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5338 and the surrounding thread.
5339 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5340 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5341 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5343 * s/openbsd.h (BROKEN_SIGIO): Define.
5344 * unexelf.c (unexec) [__OpenBSD__]:
5345 Don't update the .mdebug section of the Alpha COFF symbol table.
5347 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5349 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5352 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5354 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5355 This fixes some race conditions on the permissions of any newly
5358 * alloc.c (valid_pointer_p): Use pipe, not open.
5359 This fixes some permissions issues when debugging.
5361 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5362 If fchown fails to set both uid and gid, try to set just gid,
5363 as that is sometimes allowed. Adjust the file's mode to eliminate
5364 setuid or setgid bits that are inappropriate if fchown fails.
5366 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5368 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5369 to compare Lisp_Objects.
5370 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5371 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5372 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5374 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5376 * lread.c (read_integer): Unread even EOF character.
5377 (read1): Likewise. Properly record start position of symbol.
5379 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5380 symbol character follows.
5382 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5384 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5385 This works around a problem with the previous change to Fcopy_file.
5386 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5387 and without this change, GCC might complain about discarding
5388 fchown's return value.
5390 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5392 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5394 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5396 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5398 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5400 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5401 it's used from the C level.
5403 * process.c: Use the same condition for POLL_FOR_INPUT in both
5404 keyboard.c and process.c (bug#1858).
5406 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5408 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5409 (Fgnutls_boot): Use it.
5411 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5413 * doc.c (Fsubstitute_command_keys): Revert last change.
5415 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5417 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5418 quotes the next character, and doesn't affect other longer
5419 sequences (bug#8935).
5421 * lread.c (syms_of_lread): Clarify that is isn't only
5422 `eval-buffer' and `eval-defun' that's affected by
5423 `lexical-binding' (bug#8460).
5425 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5427 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5428 bidi redisplay when a line includes both an image and is truncated.
5430 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5432 Fix minor problems found by static checking.
5433 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5434 (elsz): Now a signed constant, not a size_t var. We prefer signed
5435 types to unsigned, to avoid integer comparison confusion. Without
5436 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5437 "cannot optimize loop, the loop counter may overflow", a symptom
5439 * indent.c (Fvertical_motion): Mark locals as initialized.
5440 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5442 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5444 * search.c (Fre_search_backward): Mention `case-fold-search' in
5445 all the re_search_* functions (bug#8138).
5447 * keyboard.c (Fopen_dribble_file): Document when the file is
5450 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5452 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5455 Support bidi reordering of display and overlay strings.
5456 * xdisp.c (compute_display_string_pos)
5457 (compute_display_string_end): Accept additional argument STRING.
5458 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5459 (reseat_to_string): Initialize bidi_it->string.s and
5460 bidi_it->string.schars.
5461 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5462 NULL (avoids a crash in bidi_paragraph_init).
5463 Initialize itb.string.lstring.
5464 (init_iterator): Call bidi_init_it only of a valid
5465 buffer position was specified. Initialize paragraph_embedding to
5467 (reseat_to_string): Initialize the bidi iterator.
5468 (display_string): If we need to ignore text properties of
5469 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5470 original value of -1 will not work with bidi.)
5471 (compute_display_string_pos): First arg is now struct
5472 `text_pos *'; all callers changed. Support display properties on
5474 (compute_display_string_end): Support display properties on Lisp
5476 (init_iterator, reseat_1, reseat_to_string): Initialize the
5477 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5478 when iterating on a string not from display properties).
5479 (compute_display_string_pos, compute_display_string_end):
5480 Fix calculation of the object to scan. Fixes an error when using
5482 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5483 base_level_stop; instead, set base_level_stop to BEGV.
5484 Fixes crashes in vertical-motion.
5485 (next_element_from_buffer): Improve commentary for when
5486 the iterator is before prev_stop.
5487 (init_iterator): Initialize bidi_p from the default value of
5488 bidi-display-reordering, not from buffer-local value. Use the
5489 buffer-local value only if initializing for buffer iteration.
5490 (handle_invisible_prop): Support invisible properties on strings
5491 that are being bidi-reordered.
5492 (set_iterator_to_next): Support bidi reordering of C strings and
5494 (next_element_from_string): Support bidi reordering of Lisp
5496 (handle_stop_backwards): Support Lisp strings as well.
5497 (display_string): Support display of R2L glyph rows.
5498 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5499 (init_iterator): Don't initialize it->bidi_p for strings
5501 (reseat_to_string): Initialize it->bidi_p for strings here.
5502 (next_element_from_string, next_element_from_c_string)
5503 (next_element_from_buffer): Add xassert's for correspondence
5504 between IT's object being iterated and it->bidi_it.string
5506 (face_before_or_after_it_pos): Support bidi iteration.
5507 (next_element_from_c_string): Handle the case of the first string
5508 character that is not the first one in the visual order.
5509 (get_visually_first_element): New function, refactored from common
5510 parts of next_element_from_buffer, next_element_from_string, and
5511 next_element_from_c_string.
5512 (tool_bar_lines_needed, redisplay_tool_bar)
5513 (display_menu_bar): Force left-to-right direction. Add a FIXME
5514 comment for making that be controlled by a user option.
5515 (push_it, pop_it): Save and restore the state of the
5516 bidi iterator. Save and restore the bidi_p flag.
5517 (pop_it): Iterate out of display property for string iteration as
5519 (iterate_out_of_display_property): Support iteration over strings.
5520 (handle_single_display_spec): Set up it->bidi_it for iteration
5521 over a display string, and call bidi_init_it.
5522 (handle_single_display_spec, next_overlay_string)
5523 (get_overlay_strings_1, push_display_prop): Set up the bidi
5524 iterator for displaying display or overlay strings.
5525 (forward_to_next_line_start): Don't use the shortcut if
5527 (back_to_previous_visible_line_start): If handle_display_prop
5528 pushed the iterator stack, restore the internal state of the bidi
5529 iterator by calling bidi_pop_it same number of times.
5530 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5531 and we are bidi-iterating, don't decrement the iterator position;
5532 instead, set the first_elt flag in the bidi iterator, to produce
5534 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5535 (push_display_prop): xassert that we are iterating a buffer.
5536 (push_it, pop_it): Save and restore paragraph_embedding member.
5537 (handle_single_display_spec, next_overlay_string)
5538 (get_overlay_strings_1, reseat_1, reseat_to_string)
5539 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5540 correctly. Don't assume unibyte strings are not bidi-reordered.
5541 (compute_display_string_pos)
5542 (compute_display_string_end): Fix handling the case of C string.
5543 (push_it, pop_it): Save and restore from_disp_prop_p.
5544 (handle_single_display_spec, push_display_prop): Set the
5545 from_disp_prop_p flag.
5546 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5547 (pop_it): Call iterate_out_of_display_property only if we are
5548 popping after iteration over a string that came from a display
5549 property. Fix a typo in popping stretch info. Add an assertion
5550 for verifying that the iterator position is in sync with the bidi
5552 (handle_single_display_spec, get_overlay_strings_1)
5553 (push_display_prop): Fix initialization of paragraph direction for
5554 string when that of the parent object is not yet determined.
5555 (reseat_1): Call bidi_init_it to resync the bidi
5556 iterator with IT's position. (Bug#7616)
5557 (find_row_edges): If ROW->start.pos gives position
5558 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5559 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5560 Reset the from_disp_prop_p flag.
5561 (SAVE_IT, RESTORE_IT): New macros.
5562 (pos_visible_p, face_before_or_after_it_pos)
5563 (back_to_previous_visible_line_start)
5564 (move_it_in_display_line_to, move_it_in_display_line)
5565 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5566 (try_scrolling, redisplay_window, display_line): Use them when
5567 saving a temporary copy of the iterator and restoring it back.
5568 (back_to_previous_visible_line_start, reseat_1)
5569 (init_iterator): Empty the bidi cache "stack".
5570 (move_it_in_display_line_to): If iterator ended up at
5571 EOL, but we never saw any buffer positions smaller than
5572 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5573 motion in bidi-reordered lines.
5574 (move_it_in_display_line_to): Record prev_method and prev_pos
5575 immediately before the call to set_iterator_to_next. Fixes cursor
5576 motion in bidi-reordered lines with stretch glyphs and strings
5577 displayed in margins. (Bug#8133) (Bug#8867)
5578 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5580 (pos_visible_p): Support positions in bidi-reordered lines.
5581 Save and restore bidi cache.
5583 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5584 (bidi_paragraph_info): Delete unused struct.
5585 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5586 (bidi_cache_start): New variable.
5587 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5589 (bidi_cache_fetch_state, bidi_cache_search)
5590 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5591 (bidi_cache_find, bidi_peek_at_next_level)
5592 (bidi_level_of_next_char, bidi_find_other_level_edge)
5593 (bidi_move_to_visually_next): Compare cache index with
5594 bidi_cache_start rather than with zero.
5595 (bidi_fetch_char): Accept new argument STRING; all callers
5596 changed. Support iteration over a string. Support strings with
5597 display properties. Support unibyte strings. Fix the type of
5598 `len' according to what STRING_CHAR_AND_LENGTH expects.
5599 (bidi_paragraph_init, bidi_resolve_explicit_1)
5600 (bidi_resolve_explicit, bidi_resolve_weak)
5601 (bidi_level_of_next_char, bidi_move_to_visually_next):
5602 Support iteration over a string.
5603 (bidi_set_sor_type, bidi_resolve_explicit_1)
5604 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5605 can now be zero (for strings); special values 0 and -1 were
5606 changed to -1 and -2, respectively.
5607 (bidi_char_at_pos): New function.
5608 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5609 Call it instead of FETCH_MULTIBYTE_CHAR.
5610 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5611 initialized to valid values.
5612 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5614 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5615 the test for valid cached positions. Fix the logic for looking up
5616 the sentinel state in the cache. GCPRO the Lisp string we are
5618 (bidi_push_it, bidi_pop_it): New functions.
5619 (bidi_initialize): Initialize the bidi cache start stack pointer.
5620 (bidi_cache_ensure_space): New function, refactored from part of
5621 bidi_cache_iterator_state. Don't assume the required size is just
5622 one BIDI_CACHE_CHUNK away.
5623 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5624 (bidi_count_bytes, bidi_char_at_pos): New functions.
5625 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5626 always valid if bidi_cache_idx is valid.
5627 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5628 is valid if it's going to be used.
5629 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5630 (bidi_cache_fetch_state, bidi_cache_search)
5631 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5632 (bidi_cache_iterator_state, bidi_cache_find)
5633 (bidi_find_other_level_edge, bidi_cache_start_stack):
5634 All variables related to cache indices are now EMACS_INT.
5636 * dispextern.h (struct bidi_string_data): New structure.
5637 (struct bidi_it): New member `string'. Make flag members be 1-bit
5638 fields, and put them last in the struct.
5639 (compute_display_string_pos, compute_display_string_end):
5641 (bidi_push_it, bidi_pop_it): Add prototypes.
5642 (struct iterator_stack_entry): New members bidi_p,
5643 paragraph_embedding, and from_disp_prop_p.
5644 (struct it): Member bidi_p is now a bit field 1 bit wide.
5645 (bidi_shelve_cache, bidi_unshelve_cache):
5648 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5649 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5650 and vector-like objects.
5652 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5653 cache around display iteration.
5655 * window.c (Fwindow_end, window_scroll_pixel_based)
5656 (displayed_window_lines, Frecenter): Save and restore the bidi
5657 cache around display iteration.
5659 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5661 * editfns.c (Fdelete_region): Clarify the use of the named
5662 parameters (bug#6788).
5664 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5666 * indent.c (Fvertical_motion): Set and restore w->pointm when
5667 saving and restoring the window's buffer (Bug#9006).
5669 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5671 * editfns.c (Fstring_to_char): Clarify just what is returned
5672 (bug#6576). Text by Eli Zaretskii.
5674 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5676 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5678 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5680 * buffer.c (mmap_find): Fix a typo.
5682 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5684 Fix execution of x selection hooks.
5685 * xselect.c (Qx_lost_selection_functions)
5686 (Qx_sent_selection_functions): New vars.
5687 (syms_of_xselect): DEFSYM them.
5688 (x_handle_selection_request): Pass Qx_sent_selection_functions
5689 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5690 (x_handle_selection_clear,x_clear_frame_selections):
5691 Pass Qx_lost_selection_functions rather than
5692 Vx_lost_selection_functions to Frun_hook_with_args.
5694 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5696 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5697 The old code sometimes used this field without initializing it.
5699 * alloc.c (gc_sweep): Don't read past end of array.
5700 In theory, the old code could also have corrupted Emacs internals,
5701 though it'd be very unlikely.
5703 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5705 * character.c (Fcharacterp): Don't advertise optional ignored
5706 argument. (Bug#4026)
5708 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5710 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5713 * window.c (Fset_window_start): Doc fix (bug#4199).
5714 (Fset_window_hscroll): Ditto.
5716 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5718 Fix minor new problems caught by GCC 4.6.1.
5719 * term.c (init_tty): Remove unused local.
5720 * xsettings.c (store_monospaced_changed): Define this function only
5721 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5724 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5726 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5728 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5730 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5731 are the mini-buffer and the echo area (bug#3320).
5733 * term.c (init_tty): Remove support for supdup, c10 and perq
5734 terminals, which are no longer supported (bug#1482).
5736 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5738 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5740 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5742 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5743 for non-popups (Bug#3642).
5745 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5747 * alloc.c (reset_malloc_hooks): Protoize.
5748 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5749 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5750 * cm.c (losecursor): Likewise.
5751 * data.c (fmod): Likewise.
5752 * dispnew.c (swap_glyphs_in_rows): Likewise.
5753 * emacs.c (memory_warning_signal): Likewise.
5754 * floatfns.c (float_error): Likewise.
5755 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5756 (otf_open, font_otf_capability, generate_otf_features)
5757 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5759 * image.c (pbm_read_file): Likewise.
5760 * indent.c (string_display_width): Likewise.
5761 * intervals.c (check_for_interval, search_for_interval)
5762 (inc_interval_count, count_intervals, root_interval)
5763 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5764 * lread.c (defalias): Likewise.
5765 * ralloc.c (r_alloc_check): Likewise.
5766 * regex.c (set_image_of_range_1, set_image_of_range)
5767 (regex_grow_registers): Likewise.
5768 * sysdep.c (strerror): Likewise.
5769 * termcap.c (valid_filename_p, tprint, main): Likewise.
5770 * tparam.c (main): Likewise.
5771 * unexhp9k800.c (run_time_remap, save_data_space)
5772 (update_file_ptrs, read_header, write_header, calculate_checksum)
5773 (copy_file, copy_rest, display_header): Likewise.
5774 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5776 * xdisp.c (check_it): Likewise.
5777 * xfaces.c (register_color, unregister_color, unregister_colors):
5779 * xfns.c (print_fontset_result): Likewise.
5780 * xrdb.c (member, fatal, main): Likewise.
5782 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5784 Fix minor problems found by static checking (Bug#9031).
5785 * chartab.c (char_table_set_range, map_sub_char_table):
5786 Remove unused locals.
5787 (uniprop_table): Now static.
5788 * composite.c (_work_char): Remove unused static var.
5790 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5792 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5794 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5796 * gtkutil.c (qttip_cb): Remove code without function.
5798 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5800 * w32.c (pthread_sigmask): New stub.
5802 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5804 Use pthread_sigmask, not sigprocmask (Bug#9010).
5805 sigprocmask is portable only for single-threaded applications, and
5806 Emacs can be multi-threaded when it uses GTK.
5807 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5809 * callproc.c (Fcall_process):
5810 * process.c (create_process):
5811 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5812 Use pthread_sigmask, not sigprocmask.
5814 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5816 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5817 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5820 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5822 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5823 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5824 (xg_hide_tooltip): Fix comment.
5826 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5827 in registerServicesMenuSendTypes.
5828 (validRequestorForSendType): Don't check ns_return_types.
5830 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5833 2011-07-08 Jason Rumney <jasonr@gnu.org>
5835 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5836 SH_SHOW for hidden windows (Bug#5482).
5838 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5839 frame struct members of non-existent frames (Bug#6284).
5841 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5843 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5844 variable firstTime not needed on OSX >= 10.6.
5845 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5846 >= 10.5. Use setKnobProportion, setDoubleValue.
5848 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5849 (MAC_OS_X_VERSION_10_5): Define if not defined.
5850 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5851 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5852 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5854 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5855 cString and lossyCString on OSX >= 10.4
5857 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5858 sizeToFit on OSX >= 10.2.
5860 * nsimage.m (allocInitFromFile): Don't use deprecated method
5861 bestRepresentationForDevice on OSX >= 10.6.
5863 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5866 * emacs.c: Declare unexec_init_emacs_zone.
5868 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5870 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5872 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5873 on svcsMenu (Bug#8842).
5875 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5877 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5879 * nsterm.m (QUTF8_STRING): Declare.
5880 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5881 (validRequestorForSendType): Return type is (id).
5882 Change indexOfObjectIdenticalTo to indexOfObject.
5883 Check if we have local selection before returning self (Bug#8842).
5884 (writeSelectionToPasteboard): Put local selection into paste board
5885 if we have a local selection (Bug#8842).
5886 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5888 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5889 (ns_get_local_selection): Declare.
5891 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5893 * keymap.c (describe_map_tree): Don't insert a double newline at
5894 the end of the buffer (bug#1169) and return whether we inserted
5897 * callint.c (Fcall_interactively): Change "reading args" to
5898 "providing args" to try to clarify what it does (bug#1010).
5900 2011-07-07 Kenichi Handa <handa@m17n.org>
5902 * composite.c (composition_compute_stop_pos): Ignore a static
5903 composition starting before CHARPOS (Bug#8915).
5905 * xdisp.c (handle_composition_prop): Likewise.
5907 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5909 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5912 2011-07-07 Kenichi Handa <handa@m17n.org>
5914 * character.h (unicode_category_t): New enum type.
5916 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5917 (Qchar_code_property_table): New variable.
5918 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5919 (UNIPROP_COMPRESSED_FORM_P): New macros.
5920 (char_table_ascii): Uncompress the compressed values.
5921 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5922 Uncompress the compressed values.
5923 (sub_char_table_ref_and_range): Likewise.
5924 (char_table_ref_and_range): Uncompress the compressed values.
5925 (sub_char_table_set): New arg is_uniprop. Callers changed.
5926 Uncompress the compressed values.
5927 (sub_char_table_set_range): Args changed. Callers changed.
5928 (char_table_set_range): Adjuted for the above change.
5929 (map_sub_char_table): Delete args default_val and parent. Add arg
5930 top. Give decoded values to a Lisp function.
5931 (map_char_table): Adjust for the above change. Give decoded
5932 values to a Lisp function. Gcpro more variables.
5933 (uniprop_table_uncompress)
5934 (uniprop_decode_value_run_length): New functions.
5935 (uniprop_decoder, uniprop_decoder_count): New variables.
5936 (uniprop_get_decoder, uniprop_encode_value_character)
5937 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5939 (uniprop_encoder, uniprop_encoder_count): New variables.
5940 (uniprop_get_encoder, uniprop_table)
5941 (Funicode_property_table_internal, Fget_unicode_property_internal)
5942 (Fput_unicode_property_internal): New functions.
5943 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5944 Sunicode_property_table_internal, Sget_unicode_property_internal,
5945 and Sput_unicode_property_internal. Defvar_lisp
5946 char-code-property-alist.
5948 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5949 Vunicode_category_table.
5951 * font.c (font_range): Adjust for the change of
5952 Vunicode_category_table.
5954 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5956 * m/iris4d.h: Remove file, move contents ...
5957 * s/irix6-5.h: ... here.
5959 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5961 Remove unportable assumption about struct layout (Bug#8884).
5962 * alloc.c (mark_buffer):
5963 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5964 (clone_per_buffer_values): Don't assume that
5965 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5966 This isn't true in general, and it's particularly not true
5967 if Emacs is configured with --with-wide-int.
5968 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5969 New macros, used in the buffer.c change.
5971 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5973 * xsettings.c: Use both GConf and GSettings if both are available.
5974 (store_config_changed_event): Add comment.
5975 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5976 (store_tool_bar_style_changed): New functions.
5977 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5978 (struct xsettings): Move font inside HAVE_XFT.
5979 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5980 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5981 Move inside HAVE_XFT.
5982 (something_changed_gsettingsCB): Rename from something_changedCB.
5983 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5985 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5986 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5987 (something_changed_gconfCB): Rename from something_changedCB.
5988 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5989 (parse_settings): Move check for font inside HAVE_XFT.
5990 (read_settings, apply_xft_settings): Add comment.
5991 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5992 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5993 call store_font_name_changed.
5994 (xft_settings_event): Add comment.
5995 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5996 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5997 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5998 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5999 (xsettings_initialize): Call init_gsettings last.
6000 (xsettings_get_system_font, xsettings_get_system_normal_font):
6003 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6005 Random fixes. E.g., (random) never returned negative values.
6006 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6007 subseconds part to the entropy, as that's a bit more random.
6008 Prefer signed to unsigned, since the signedness doesn't matter and
6009 in general we prefer signed. When given a limit, use a
6010 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6011 latter isn't right if USE_2_TAGS_FOR_INTS.
6012 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6013 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6015 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6017 * textprop.c (text_property_stickiness):
6018 Obey Vtext_property_default_nonsticky.
6019 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6020 * w32fns.c (syms_of_w32fns):
6021 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6023 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6025 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6026 This is more efficient than Ffile_directory_p and avoids a minor race.
6028 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6030 * buffer.c (Foverlay_put): Say what the return value is
6033 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6034 is a directory before asking whether to use the file name
6036 (barf_or_query_if_file_exists): Make the "File is a directory"
6037 error be more correct.
6039 * fns.c (Frequire): Remove the mention of the .gz files, since
6040 that's installation-specific, but keep the mention of
6041 `get-load-suffixes'.
6043 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6045 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6046 Report string overflow if the output is too long.
6048 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6050 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6051 (syms_of_gnutls): Remove duplicate DEFSYM for
6052 Qgnutls_bootprop_verify_hostname_error, an error for
6053 Qgnutls_bootprop_verify_error (which is no longer used).
6055 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6056 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6057 Also (re)move comments that are misplaced or no longer relevant.
6059 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6061 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6063 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6065 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6066 and background color parameters if they have been changed.
6068 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6070 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6072 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6074 * xsettings.c (SYSTEM_FONT): Define only when used.
6075 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6077 * keymap.c (access_keymap_1): Now static.
6079 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6081 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6082 leave any prefix arg for the up event (Bug#1586).
6084 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6086 * lread.c (syms_of_lread): Mention single symbols defined by
6087 `defvar' or `defconst' (bug#7154).
6089 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6090 (Frequire): Mention get-load-suffixes.
6092 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6094 * window.h (window): Remove clone_number slot.
6095 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6097 (make_parent_window, make_window, saved_window)
6098 (Fset_window_configuration, save_window_save): Don't deal with
6100 * buffer.c (Qclone_number): Remove declaration.
6101 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6103 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6105 Add multiple inheritance to keymaps.
6106 * keymap.c (Fmake_composed_keymap): New function.
6107 (Fset_keymap_parent): Simplify.
6108 (fix_submap_inheritance): Remove.
6109 (access_keymap_1): New function extracted from access_keymap to handle
6110 embedded parents and handle lists of maps.
6111 (access_keymap): Use it.
6112 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6113 (Fcopy_keymap): Handle embedded parents.
6114 (Fcommand_remapping, define_as_prefix): Simplify.
6115 (Fkey_binding): Simplify.
6116 (syms_of_keymap): Move minibuffer-local-completion-map,
6117 minibuffer-local-filename-completion-map,
6118 minibuffer-local-must-match-map, and
6119 minibuffer-local-filename-must-match-map to Elisp.
6120 (syms_of_keymap): Defsubr make-composed-keymap.
6121 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6122 (parse_menu_item): Trivial simplification.
6124 2011-07-01 Glenn Morris <rgm@gnu.org>
6126 * Makefile.in (SETTINGS_LIBS): Fix typo.
6128 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6130 * coding.c (Fencode_coding_string): Record the last coding system
6131 used, as the function doc string says (bug#8738).
6133 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6135 * xsettings.c (store_monospaced_changed): Take new font as arg and
6136 check for change against current_mono_font.
6137 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6138 (emacs_settings_constructor, emacs_settings_get_property)
6139 (emacs_settings_set_property, emacs_settings_class_init)
6140 (emacs_settings_init, gsettings_obj): Remove.
6141 (something_changedCB): New function for HAVE_GSETTINGS.
6142 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6143 with value as argument.
6144 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6145 g_settings_new (Bug#8967). Do not create gsettings_obj.
6146 Remove calls to g_settings_bind. Connect something_changedCB to
6149 * xgselect.c: Add defined (HAVE_GSETTINGS).
6150 (xgselect_initialize): Ditto.
6152 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6153 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6156 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6158 * eval.c (struct backtrace): Simplify and port the data structure.
6159 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6160 signed bit field, as this assumption is not portable and it makes
6161 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6162 "char debug_on_exit : 1" as this is not portable either; instead,
6163 use the portable "unsigned int debug_on_exit : 1". Remove unused
6164 member evalargs. Remove obsolete comments about cc bombing out.
6166 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6168 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6169 Let HAVE_GSETTINGS override HAVE_GCONF.
6170 (store_monospaced_changed): New function.
6171 (EMACS_SETTINGS): A new type derived from GObject to handle
6172 GSettings notifications.
6173 (emacs_settings_constructor, emacs_settings_get_property)
6174 (emacs_settings_set_property, emacs_settings_class_init):
6176 (gsettings_client, gsettings_obj): New variables.
6177 (GSETTINGS_SCHEMA): New define.
6178 (something_changedCB): Call store_monospaced_changed.
6179 (init_gsettings): New function.
6180 (xsettings_initialize): Call init_gsettings.
6181 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6184 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6187 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6189 * window.c (resize_root_window, grow_mini_window)
6190 (shrink_mini_window): Rename Qresize_root_window to
6191 Qwindow_resize_root_window and Qresize_root_window_vertically to
6192 Qwindow_resize_root_window_vertically.
6194 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6196 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6198 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6200 * makefile.w32-in: Redesign dependencies so they reflect more
6201 clearly which files are directly included by each source file,
6202 and not through other includes.
6204 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6206 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6207 (sort_overlays, overlay_strings): When an overlay's clone number
6208 matches the window's clone number process the overlay even if
6209 the overlay's window property doesn't match the current window.
6211 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6212 (Fwindow_hchild): Rename to Fwindow_left_child.
6213 (Fwindow_next): Rename to Fwindow_next_sibling.
6214 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6215 (resize_window_check): Rename to window_resize_check.
6216 (resize_window_apply): Rename to window_resize_apply.
6217 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6218 (Fdelete_other_windows_internal, resize_frame_windows)
6219 (Fsplit_window_internal, Fdelete_window_internal)
6220 (grow_mini_window, shrink_mini_window)
6221 (Fresize_mini_window_internal): Fix callers accordingly.
6223 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6225 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6226 (emacs_fixed_set_min_size): Remove.
6227 (emacs_fixed_new): Take frame as argument.
6229 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6230 (_EmacsFixedPrivate): Remove minwidth/height.
6231 Add struct frame *f.
6232 (emacs_fixed_init): Initialize priv->f.
6233 (get_parent_class, emacs_fixed_set_min_size): Remove.
6234 (emacs_fixed_new): Set priv->f to argument.
6235 (emacs_fixed_get_preferred_width)
6236 (emacs_fixed_get_preferred_height): Use min_width/height from
6237 frames size_hint to set minimum and natural (Bug#8919).
6238 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6239 and use min_width/height from frames size_hint to set
6240 min_width/height (Bug#8919).
6242 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6243 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6246 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6248 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6249 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6252 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6254 * process.c (wait_reading_process_output): Bypass select if
6255 waiting for a cell while ignoring keyboard input, and input is
6256 pending. Suggested by Jan Djärv (Bug#8869).
6258 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6260 Use gnulib's dup2 module instead of rolling our own.
6261 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6263 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6265 * dispnew.c (scrolling_window): Before scrolling, turn off a
6266 mouse-highlight in the window being scrolled.
6268 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6270 Move DEFSYM to lisp.h and use everywhere.
6272 * character.h (DEFSYM): Move declaration...
6273 * lisp.h (DEFSYM): ...here.
6279 * w32select.c: Don't include character.h.
6281 * alloc.c (syms_of_alloc):
6282 * buffer.c (syms_of_buffer):
6283 * bytecode.c (syms_of_bytecode):
6284 * callint.c (syms_of_callint):
6285 * casefiddle.c (syms_of_casefiddle):
6286 * casetab.c (init_casetab_once):
6287 * category.c (init_category_once, syms_of_category):
6288 * ccl.c (syms_of_ccl):
6289 * cmds.c (syms_of_cmds):
6290 * composite.c (syms_of_composite):
6291 * dbusbind.c (syms_of_dbusbind):
6292 * dired.c (syms_of_dired):
6293 * dispnew.c (syms_of_display):
6294 * doc.c (syms_of_doc):
6295 * editfns.c (syms_of_editfns):
6296 * emacs.c (syms_of_emacs):
6297 * eval.c (syms_of_eval):
6298 * fileio.c (syms_of_fileio):
6299 * fns.c (syms_of_fns):
6300 * frame.c (syms_of_frame):
6301 * fringe.c (syms_of_fringe):
6302 * insdel.c (syms_of_insdel):
6303 * keymap.c (syms_of_keymap):
6304 * lread.c (init_obarray, syms_of_lread):
6305 * macros.c (syms_of_macros):
6306 * msdos.c (syms_of_msdos):
6307 * print.c (syms_of_print):
6308 * process.c (syms_of_process):
6309 * search.c (syms_of_search):
6310 * sound.c (syms_of_sound):
6311 * syntax.c (init_syntax_once, syms_of_syntax):
6312 * terminal.c (syms_of_terminal):
6313 * textprop.c (syms_of_textprop):
6314 * undo.c (syms_of_undo):
6315 * w32.c (globals_of_w32):
6316 * window.c (syms_of_window):
6317 * xdisp.c (syms_of_xdisp):
6318 * xfaces.c (syms_of_xfaces):
6319 * xfns.c (syms_of_xfns):
6320 * xmenu.c (syms_of_xmenu):
6321 * xsettings.c (syms_of_xsettings):
6322 * xterm.c (syms_of_xterm): Use DEFSYM.
6324 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6326 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6328 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6330 Integer and buffer overflow fixes (Bug#8873).
6332 * print.c (printchar, strout): Check for string overflow.
6333 (PRINTPREPARE, printchar, strout):
6334 Don't set size unless allocation succeeds.
6336 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6337 for sizes. Check for string overflow more accurately.
6338 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6340 * macros.c: Integer and buffer overflow fixes.
6341 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6342 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6343 Use ptrdiff_t, not int, for sizes.
6344 Don't increment bufsize until after realloc succeeds.
6345 Check for size-calculation overflow.
6346 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6348 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6350 * lread.c: Integer overflow fixes.
6351 (read_integer): Radix is now EMACS_INT, not int,
6352 to improve quality of diagnostics for out-of-range radices.
6353 Calculate buffer size correctly for out-of-range radices.
6354 (read1): Check for integer overflow in radices, and in
6355 read-circle numbers.
6356 (read_escape): Avoid int overflow.
6357 (Fload, openp, read_buffer_size, read1)
6358 (substitute_object_recurse, read_vector, read_list, map_obarray):
6359 Use ptrdiff_t, not int, for sizes.
6360 (read1): Use EMACS_INT, not int, for sizes.
6361 Check for size overflow.
6363 * image.c (cache_image): Check for size arithmetic overflow.
6365 * lread.c: Integer overflow issues.
6366 (saved_doc_string_size, saved_doc_string_length)
6367 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6368 Now ptrdiff_t, not int.
6369 (read1): Don't assume doc string length fits in int. Check for
6370 out-of-range doc string lengths.
6371 (read_list): Don't assume file position fits in int.
6372 (read_escape): Check for hex character overflow.
6374 2011-06-22 Leo Liu <sdl.web@gmail.com>
6376 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6377 Move to minibuffer.el.
6379 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6381 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6382 The following patches are for when GLYPH_DEBUG && !XASSERT.
6383 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6384 * dispnew.c (flush_stdout):
6385 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6386 Mark as externally visible.
6387 * dispnew.c (check_window_matrix_pointers): Now static.
6388 * dispnew.c (window_to_frame_vpos):
6389 * xfns.c (unwind_create_frame):
6390 * xterm.c (x_check_font): Remove unused local.
6391 * scroll.c (CHECK_BOUNDS):
6392 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6393 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6394 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6395 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6396 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6398 (debug_method_add): Use va_list and vsprintf rather than relying
6399 on undefined behavior with wrong number of arguments.
6400 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6401 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6402 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6403 since we're not interested in debugging glyphs with old libraries.
6404 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6405 GCC 4.6.0's static checking.
6407 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6409 Integer overflow and signedness fixes (Bug#8873).
6410 A few related buffer overrun fixes, too.
6412 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6414 * dispextern.h (struct face.stipple):
6415 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6416 (x_bitmap_mask, x_allocate_bitmap_record)
6417 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6418 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6419 (x_create_bitmap_from_xpm_data):
6420 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6421 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6423 * xfaces.c (load_pixmap):
6424 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6425 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6426 (.bitmaps_last, struct x_output.icon_bitmap):
6427 Use ptrdiff_t, not int, for bitmap indexes.
6428 (x_allocate_bitmap_record): Check for size overflow.
6429 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6431 Use ptrdiff_t, not int, for overlay counts.
6432 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6433 * editfns.c (overlays_around, get_pos_property):
6434 * textprop.c (get_char_property_and_overlay):
6435 * xdisp.c (next_overlay_change, note_mouse_highlight):
6436 * xfaces.c (face_at_buffer_position):
6437 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6438 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6439 (Fnext_overlay_change, Fprevious_overlay_change)
6440 (mouse_face_overlay_overlaps, Foverlays_in):
6441 Use ptrdiff_t, not int, for sizes.
6442 (overlays_at, overlays_in): Check for size-calculation overflow.
6444 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6446 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6447 (x_session_initialize): Do not assume string length fits in int.
6449 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6450 This is unlikely, but can occur if DPI is outlandish.
6452 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6453 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6455 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6456 * xrdb.c (magic_file_p, search_magic_path):
6457 Omit last arg SUFFIX; it was always 0. All callers changed.
6458 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6460 * xfont.c (xfont_match): Avoid need for strlen.
6462 * xfns.c: Don't assume strlen fits in int.
6463 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6465 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6466 not unsigned long, as we prefer signed integers. All callers changed.
6467 Detect integer overflow in repeat count.
6468 (message_dolog): Don't assume print length fits in 39 bytes.
6469 (display_mode_element): Don't assume strlen fits in int.
6471 * termcap.c: Don't assume sizes fit in int and never overflow.
6472 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6473 (gobble_line): Check for size-calculation overflow.
6475 * minibuf.c (Fread_buffer):
6476 * lread.c (intern, intern_c_string):
6477 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6478 Don't assume string length fits in int.
6480 * keyboard.c (parse_tool_bar_item):
6481 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6483 * font.c: Don't assume string length fits in int.
6484 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6485 Use ptrdiff_t, not int.
6486 (font_intern_prop): Don't assume string length fits in int.
6487 Don't assume integer property fits in fixnum.
6488 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6490 * filelock.c: Fix some buffer overrun and integer overflow issues.
6491 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6492 Reformulate so as not to need the command string.
6493 Invoke gzip -cd rather than gunzip, as it's more portable.
6494 (lock_info_type, lock_file_1, lock_file):
6495 Don't assume pid_t and time_t fit in unsigned long.
6496 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6497 (current_lock_owner): Prefer signed type for sizes.
6498 Use memcpy, not strncpy, where memcpy is what is really wanted.
6499 Don't assume (via atoi) that time_t and pid_t fit in int.
6500 Check for time_t and/or pid_t out of range, e.g., via a network share.
6501 Don't alloca where an auto var works fine.
6503 * fileio.c: Fix some integer overflow issues.
6504 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6505 Don't assume string length fits in int.
6506 (directory_file_name): Don't assume string length fits in long.
6507 (make_temp_name): Don't assume pid fits in int, or that its print
6508 length is less than 20.
6510 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6512 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6514 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6516 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6517 We prefer signed integers, even for size calculations.
6519 * emacs.c: Don't assume string length fits in 'int'.
6520 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6521 (main): Don't invoke strlen when not needed.
6523 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6524 (XD_DEBUG_MESSAGE): Don't waste a byte.
6526 * callproc.c (getenv_internal_1, getenv_internal)
6528 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6530 * lread.c (invalid_syntax): Omit length argument.
6531 All uses changed. This doesn't fix a bug, but it simplifies the
6532 code away from its former Hollerith-constant appearance, and it's
6533 one less 'int' to worry about when looking at integer-overflow issues.
6534 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6536 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6537 This didn't break anything, but it didn't help either.
6538 It's confusing to put a bogus integer in a place where the actual
6539 value does not matter.
6540 (LIST_END_P): Remove unused macro and its bogus comment.
6541 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6543 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6544 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6546 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6547 We prefer signed types, and the value cannot exceed the EMACS_INT
6548 range anyway (because otherwise the length would not be representable).
6549 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6550 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6551 This avoids a GCC warning when WIDE_EMACS_INT.
6553 * indent.c (sane_tab_width): New function.
6554 (current_column, scan_for_column, Findent_to, position_indentation)
6555 (compute_motion): Use it. This is just for clarity.
6556 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6558 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6560 * lisp.h (lint_assume): New macro.
6561 * composite.c (composition_gstring_put_cache):
6562 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6564 * editfns.c, insdel.c:
6565 Omit unnecessary forward decls, to simplify future changes.
6567 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6569 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6571 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6572 Use much-faster test for byte-length change.
6573 Don't assume string byte-length fits in 'int'.
6574 Check that character arg fits in 'int'.
6575 (mapcar1): Declare byte as byte, for clarity.
6577 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6579 * fns.c (concat): Catch string overflow earlier.
6580 Do not rely on integer wraparound.
6582 * dispextern.h (struct it.overlay_strings_charpos)
6583 (struct it.selective): Now EMACS_INT, not int.
6584 * xdisp.c (forward_to_next_line_start)
6585 (back_to_previous_visible_line_start)
6586 (reseat_at_next_visible_line_start, next_element_from_buffer):
6587 Don't arbitrarily truncate the value of 'selective' to int.
6589 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6591 * composite.c: Don't truncate sizes to 'int'.
6592 (composition_gstring_p, composition_reseat_it)
6593 (composition_adjust_point): Use EMACS_INT, not int.
6594 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6595 not EMACS_UINT, for indexes.
6597 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6599 * buffer.c: Include <verify.h>.
6600 (struct sortvec.priority, struct sortstr.priority):
6601 Now EMACS_INT, not int.
6602 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6603 (struct sortstr.size, record_overlay_string)
6604 (struct sortstrlist.size, struct sortlist.used):
6605 Don't truncate size to int.
6606 (record_overlay_string): Check for size-calculation overflow.
6607 (init_buffer_once): Check at compile-time, not run-time.
6609 2011-06-22 Jim Meyering <meyering@redhat.com>
6611 Don't leak an XBM-image-sized buffer
6612 * image.c (xbm_load): Free the image buffer after using it.
6614 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6617 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6618 that Sun C diagnosed.
6619 * fns.c (secure_hash): Fix pointer signedness issue.
6620 * intervals.c (static_offset_intervals): New function.
6621 (offset_intervals): Use it.
6623 2011-06-21 Leo Liu <sdl.web@gmail.com>
6626 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6629 * fns.c (secure_hash): Rename from crypto_hash_function and change
6630 the first arg to accept symbols.
6631 (Fsecure_hash): New primitive.
6632 (syms_of_fns): New symbols.
6634 2011-06-20 Deniz Dogan <deniz@dogan.se>
6636 * process.c (Fset_process_buffer): Clarify return value in
6639 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6641 * dispnew.c (add_window_display_history): Use BVAR.
6643 * xdisp.c (debug_method_add): Use BVAR.
6644 (check_window_end, dump_glyph_matrix, dump_glyph)
6645 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6647 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6650 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6651 check till after the cache is created in init_frame_faces.
6653 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6655 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6657 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6659 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6660 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6661 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6663 Improve buffer-overflow checking (Bug#8873).
6664 * fileio.c (Finsert_file_contents):
6665 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6666 Remove the old (too-loose) buffer overflow checks.
6667 They weren't needed, since make_gap checks for buffer overflow.
6668 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6669 The old code merely checked for Emacs fixnum overflow, and relied
6670 on undefined (wraparound) behavior. The new code avoids undefined
6671 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6673 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6674 Tune. Don't use wider integers than needed. Don't use alloca.
6675 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6677 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6679 * insdel.c, lisp.h (buffer_overflow): New function.
6680 (insert_from_buffer_1, replace_range, replace_range_2):
6681 * insdel.c (make_gap_larger):
6682 * editfns.c (Finsert_char):
6683 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6685 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6687 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6689 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6691 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6692 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6694 * fileio.c: Don't assume EMACS_INT fits in off_t.
6695 (emacs_lseek): New static function.
6696 (Finsert_file_contents, Fwrite_region): Use it.
6697 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6699 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6701 * fns.c: Don't overflow int when computing a list length.
6702 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6703 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6704 truncation on 64-bit hosts. Check for QUIT every
6705 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6706 faster and is responsive enough.
6707 (Flength): Report an error instead of overflowing an integer.
6708 (Fsafe_length): Return a float if the value is not representable
6709 as a fixnum. This shouldn't happen except in contrived situations.
6710 (Fnthcdr, Fsort): Don't assume list length fits in int.
6711 (Fcopy_sequence): Don't assume vector length fits in int.
6713 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6714 (header_size, word_size): New constants.
6715 (allocate_vectorlike): Don't check size overflow here.
6716 (allocate_vector): Check it here instead, since this is the only
6717 caller of allocate_vectorlike that could cause overflow.
6718 Check that the new vector's length is representable as a fixnum.
6720 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6721 The previous code was bogus. For example, next_almost_prime (32)
6722 returned 39, which is undesirable as it is a multiple of 3; and
6723 next_almost_prime (24) returned 25, which is a multiple of 5 so
6724 why was the code bothering to check for multiples of 7?
6726 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6728 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6730 Variadic C functions now count arguments with ptrdiff_t.
6731 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6732 Back then I didn't know that the Emacs coding style prefers signed int.
6733 Also, in the meantime I found a few more instances where arguments
6734 were being counted with int, which may truncate counts on 64-bit
6735 machines, or EMACS_INT, which may be unnecessarily wide.
6736 * lisp.h (struct Lisp_Subr.function.aMANY)
6737 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6738 Arg counts are now ptrdiff_t, not size_t.
6739 All variadic functions and their callers changed accordingly.
6740 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6741 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6742 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6743 * callint.c (Fcall_interactively): Check arg count for overflow,
6744 to avoid potential buffer overrun. Use signed char, not 'int',
6745 for 'varies' array, so that we needn't bother to check its size
6746 calculation for overflow.
6747 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6748 * eval.c (apply_lambda):
6749 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6750 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6751 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6753 * callint.c (Fcall_interactively): Don't use index var as event count.
6755 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6756 * mem-limits.h (SIZE): Remove; no longer used.
6758 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6760 Remove unnecessary casts.
6761 * xterm.c (x_term_init):
6762 * xfns.c (x_set_border_pixel):
6763 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6764 These aren't needed now that we assume ANSI C.
6766 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6767 It's more likely to cause problems (due to unsigned overflow)
6770 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6772 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6774 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6776 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6778 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6780 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6782 GLYPH_CODE_FACE returns EMACS_INT, not int.
6783 * dispextern.h (merge_faces):
6784 * xfaces.c (merge_faces):
6785 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6786 Don't assume EMACS_INT fits in int.
6788 * character.h (CHAR_VALID_P): Remove unused parameter.
6789 * fontset.c, lisp.h, xdisp.c: All uses changed.
6791 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6793 * fns.c (concat): Minor tuning based on overflow analysis.
6794 This doesn't fix any bugs. Use int to hold character, instead
6795 of constantly refetching from Emacs object. Use XFASTINT, not
6796 XINT, for value known to be a character. Don't bother comparing
6797 a single byte to 0400, as it's always less.
6799 * floatfns.c (Fexpt):
6800 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6802 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6805 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6807 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6808 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6809 incorrectly succeed when S was a string, because 4294967386 was
6810 truncated before it was used.
6812 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6813 Otherwise, an out-of-range integer could cause undefined behavior
6816 * composite.c: Use int, not EMACS_INT, for characters.
6817 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6818 EMACS_INT, for values that are known to be in character range.
6819 This doesn't fix any bugs but is the usual style inside Emacs and
6820 may generate better code on 32-bit machines.
6822 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6823 This is for reasons similar to the recent CHAR_STRING fix.
6824 * charset.c (Fencode_char): Check that character arg is actually
6825 a character. Pass an int to ENCODE_CHAR.
6826 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6827 wider than 'int', as a compile-time check to prevent future regressions
6830 * character.c (char_string): Remove unnecessary casts.
6832 Make sure a 64-bit char is never passed to CHAR_STRING.
6833 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6834 by silently ignoring the top 32 bits, allowing some values
6835 that were far too large to be valid characters.
6836 * character.h: Include <verify.h>.
6837 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6838 arguments are no wider than unsigned, as a compile-time check
6839 to prevent future regressions in this area.
6841 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6842 (Fsubst_char_in_region):
6844 * xdisp.c (decode_mode_spec_coding):
6845 Adjust to CHAR_STRING's new requirement.
6846 * editfns.c (Finsert_char, Fsubst_char_in_region):
6847 * fns.c (concat): Check that character args are actually
6848 characters. Without this test, these functions did the wrong
6849 thing with wildly out-of-range values on 64-bit hosts.
6851 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6852 These casts should not be needed on 32-bit hosts, either.
6853 * keyboard.c (read_char):
6854 * lread.c (Fload): Remove casts to unsigned.
6856 * lisp.h (UNSIGNED_CMP): New macro.
6857 This fixes comparison bugs on 64-bit hosts.
6858 (ASCII_CHAR_P): Use it.
6859 * casefiddle.c (casify_object):
6860 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6861 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6862 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6863 * dispextern.h (FACE_FROM_ID):
6864 * keyboard.c (read_char): Use UNSIGNED_CMP.
6866 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6867 not to EMACS_INT, to avoid GCC warning.
6869 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6871 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6872 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6873 isn't needed on 32-bit machines.
6875 * buffer.c (Fgenerate_new_buffer_name):
6876 Use EMACS_INT for count, not int.
6877 (advance_to_char_boundary): Return EMACS_INT, not int.
6879 * data.c (Qcompiled_function): Now static.
6881 * window.c (window_body_lines): Now static.
6883 * image.c (gif_load): Rename local to avoid shadowing.
6885 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6886 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6887 * alloc.c (make_save_value): Integer argument is now of type
6889 (mark_object): Use ptrdiff_t, not int.
6890 * lisp.h (pD): New macro.
6891 * print.c (print_object): Use it.
6893 * alloc.c: Use EMACS_INT, not int, to count objects.
6894 (total_conses, total_markers, total_symbols, total_vector_size)
6895 (total_free_conses, total_free_markers, total_free_symbols)
6896 (total_free_floats, total_floats, total_free_intervals)
6897 (total_intervals, total_strings, total_free_strings):
6898 Now EMACS_INT, not int. All uses changed.
6899 (Fgarbage_collect): Compute overall total using a double, so that
6900 integer overflow is less likely to be a problem. Check for overflow
6901 when converting back to an integer.
6902 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6903 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6904 These were 'int' variables that could overflow on 64-bit hosts;
6905 they were never used, so remove them instead of repairing them.
6906 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6907 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6908 Previously, this ceilinged at INT_MAX, but that doesn't work on
6910 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6912 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6913 (allocate_vectorlike): Check for ptrdiff_t overflow.
6914 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6915 when a (possibly-narrower) signed value would do just as well.
6916 We prefer using signed arithmetic, to avoid comparison confusion.
6918 * alloc.c: Catch some string size overflows that we were missing.
6919 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6920 for convenience in STRING_BYTES_MAX.
6921 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6922 The definition here is exact; the one in lisp.h was approximate.
6923 (allocate_string_data): Check for string overflow. This catches
6924 some instances we weren't catching before. Also, it catches
6925 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6926 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6927 and ptrdiff_t and EMACS_INT are both 64 bits.
6929 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6930 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6931 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6933 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6935 * alloc.c (Fmake_string): Check for out-of-range init.
6937 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6939 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6941 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6943 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6944 xg_get_default_scrollbar_width.
6946 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6947 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6948 (style_changed_cb): Call update_theme_scrollbar_width and call
6949 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6950 all frames (Bug#8505).
6951 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6952 Call gtk_window_set_resizable if HAVE_GTK3.
6953 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6954 and height if HAVE_GTK3 (Bug#8505).
6955 (scroll_bar_width_for_theme): New variable.
6956 (update_theme_scrollbar_width): New function.
6957 (xg_get_default_scrollbar_width): Move code to
6958 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6959 (xg_initialize): Call update_theme_scrollbar_width.
6961 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6963 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6965 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6967 * frame.c (make_frame): Call other_buffer_safely instead of
6970 * window.c (temp_output_buffer_show): Call display_buffer with
6971 second argument Vtemp_buffer_show_specifiers and reset latter
6972 immediately after the call.
6973 (Vtemp_buffer_show_specifiers): New variable.
6974 (auto_window_vscroll_p, next_screen_context_lines)
6975 (Vscroll_preserve_screen_position): Remove leading asterisks from
6978 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6980 Fix minor problems found by GCC 4.6.0 static checking.
6981 * buffer.c (Qclone_number): Remove for now, as it's unused.
6982 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6983 (record_buffer): Remove unused local.
6984 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6985 (set_frame_buffer_list): Remove; unused.
6986 * frame.h (other_visible_frames): Remove decl.
6987 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6988 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6989 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6991 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6992 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6993 Define only if HAVE_GPM.
6994 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6995 (update_hints_inhibit): Remove; never set. All uses removed.
6996 * widgetprv.h (emacsFrameClassRec): Remove decl.
6997 * window.c (delete_deletable_window): Now returns void, since it
6998 wasn't returning anything.
6999 (compare_window_configurations): Remove unused locals.
7000 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7001 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7002 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7003 the same widths as pointers. This follows up on the 2011-05-06 patch.
7004 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7005 * xterm.h: Likewise.
7006 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7008 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7010 * makefile.w32-in: Update dependencies.
7011 (LISP_H): Add lib/intprops.h.
7013 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7015 * image.c (gif_load): Add animation frame delay to the metadata.
7016 (syms_of_image): Use DEFSYM. New symbol `delay'.
7018 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7020 * window.c (delete_deletable_window): Re-add.
7021 (Fset_window_configuration): Rewrite to handle dead buffers and
7022 consequently deletable windows.
7023 (window_tree, Fwindow_tree): Remove. Supply functionality in
7025 (compare_window_configurations): Simplify code.
7027 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7029 * image.c (imagemagick_load_image): Fix type mismatch.
7030 (Fimagemagick_types): Likewise.
7032 * window.h (replace_buffer_in_windows): Declare.
7034 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7036 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7037 Qclone_number. Remove external declaration of Qdelete_window.
7038 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7040 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7041 Run Qbuffer_list_update_hook if allowed.
7042 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7043 buffer list implementation.
7044 (other_buffer_safely): New function.
7045 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7046 calls to replace_buffer_in_windows and
7047 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7049 (record_buffer): Inhibit quitting and rewrite using quittable
7050 functions. Run Qbuffer_list_update_hook if allowed.
7051 (Frecord_buffer, Funrecord_buffer): New functions.
7052 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7053 Move switch-to-buffer to window.el.
7054 (bury-buffer): Move to window.el.
7055 (Vbuffer_list_update_hook): New variable.
7057 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7060 * window.h (resize_frame_windows): Move up in code.
7061 (Fwindow_frame): Remove EXFUN.
7062 (replace_buffer_in_all_windows): Remove prototype.
7063 (replace_buffer_in_windows_safely): Add prototype.
7065 * window.c: Declare Qdelete_window static again. Move down
7066 declaration of select_count.
7067 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7068 (Fother_window): Move to window.el.
7069 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7070 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7071 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7073 (replace_buffer_in_windows): Implement by calling
7074 Qreplace_buffer_in_windows.
7075 (replace_buffer_in_all_windows): Remove with some functionality
7076 moved into replace_buffer_in_windows_safely.
7077 (replace_buffer_in_windows_safely): New function.
7078 (select_window_norecord, select_frame_norecord): Move in front
7079 of run_window_configuration_change_hook. Remove now obsolete
7081 (Fset_window_buffer): Rewrite doc-string.
7082 Call Qrecord_window_buffer.
7083 (keys_of_window): Move binding for other-window to window.el.
7085 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7087 * dispextern.h (struct image): Replace data member, whose int_val
7088 and ptr_val fields were not used by anything, with a single
7091 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7092 (gif_clear_image, gif_load, imagemagick_load_image)
7093 (gs_clear_image, gs_load): Callers changed.
7095 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7097 * buffer.h: Include <time.h>, for time_t.
7098 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7100 Fix minor problems found by static checking.
7102 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7104 Make identifiers static if they are not used in other modules.
7105 * data.c (Qcompiled_function, Qframe, Qvector):
7106 * image.c (QimageMagick, Qsvg):
7107 * minibuf.c (Qmetadata):
7108 * window.c (resize_window_check, resize_root_window): Now static.
7109 * window.h (resize_window_check, resize_root_window): Remove decls.
7111 * window.c (window_deletion_count, delete_deletable_window):
7113 (window_body_lines): Now static.
7114 (Fdelete_other_windows_internal): Mark vars as initialized.
7115 Make sure 'resize_failed' is initialized.
7116 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7117 (resize_window_apply): Remove unused local.
7118 * window.h (delete_deletable_window): Remove decl.
7120 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7121 (imagemagick_load_image): Fix pointer signedness problem by changing
7122 last arg from unsigned char * to char *. All uses changed.
7123 Also, fix a local for similar reasons.
7124 Remove unused locals. Remove locals to avoid shadowing.
7125 (fn_rsvg_handle_free): Remove; unused.
7126 (svg_load, svg_load_image): Fix pointer signedness problem.
7127 (imagemagick_load_image): Don't use garbage pointer image_wand.
7129 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7131 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7133 * image.c (gif_load): Fix omitted cast error introduced by
7136 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7138 * window.h (resize_proportionally, orig_total_lines)
7139 (orig_top_line): Remove from window structure.
7140 (set_window_height, set_window_width, change_window_heights)
7141 (Fdelete_window): Remove prototypes.
7142 (resize_frame_windows): Remove duplicate declaration.
7144 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7146 * window.h (resize_frame_windows, resize_window_check)
7147 (delete_deletable_window, resize_root_window)
7148 (resize_frame_windows): Declare prototypes.
7150 * window.c (resize_window_apply): Make definition be "static" to
7151 match the prototype.
7153 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7155 * window.c: Remove declarations of Qwindow_size_fixed,
7156 window_min_size_1, window_min_size_2, window_min_size,
7157 size_window, window_fixed_size_p, enlarge_window, delete_window.
7158 Remove static from declaration of Qdelete_window, it's
7159 temporarily needed by Fbury_buffer.
7160 (replace_window): Don't assign orig_top_line and
7162 (Fdelete_window, delete_window): Remove. Window deletion is
7163 handled by window.el.
7164 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7165 Replace Fdelete_window calls with calls to Qdelete_window.
7166 (Fdelete_other_windows): Remove. Deleting other windows is
7167 handled by window.el.
7168 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7169 handled in window.el.
7170 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7171 Window minimum sizes are handled in window.el.
7172 (shrink_windows, size_window, set_window_height)
7173 (set_window_width, change_window_heights, window_height)
7174 (window_width, CURBEG, CURSIZE, enlarge_window)
7175 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7176 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7177 handled in window.el.
7178 (make_dummy_parent): Rename to make_parent_window and give it a
7179 second argument horflag.
7180 (make_window): Don't set resize_proportionally any more.
7181 (Fsplit_window): Remove. Windows are split in window.el.
7182 (save_restore_action, save_restore_orig_size)
7183 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7184 Resize mini windows in window.el.
7185 (grow_mini_window, shrink_mini_window): Implement by calling
7186 Qresize_root_window_vertically, resize_window_check and
7187 resize_window_apply.
7188 (saved_window, Fset_window_configuration, save_window_save):
7189 Do not handle orig_top_line, orig_total_lines, and
7190 resize_proportionally.
7191 (window_min_height, window_min_width): Move to window.el.
7192 (keys_of_window): Move bindings for delete-other-windows,
7193 split-window, delete-window and enlarge-window to window.el.
7195 * buffer.c: Temporarily extern Qdelete_window.
7196 (Fbury_buffer): Temporarily call Qdelete_window instead of
7197 Fdelete_window (Fbury_buffer will move to window.el soon).
7199 * frame.c (set_menu_bar_lines_1): Remove code handling
7200 orig_top_line and orig_total_lines.
7202 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7203 set_window_height but set heights directly.
7204 (change_frame_size_1): Use resize_frame_windows.
7206 * xdisp.c (init_xdisp): Don't use set_window_height but set
7209 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7210 Use resize_frame_windows instead of change_window_heights and run
7211 run_window_configuration_change_hook.
7213 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7214 instead of change_window_heights and run
7215 run_window_configuration_change_hook.
7217 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7219 * window.c (replace_window): Rename second argument REPLACEMENT to
7220 NEW. New third argument SETFLAG. Rewrite.
7221 (delete_window, make_dummy_parent): Call replace_window with
7223 (window_list_1): Move down in code.
7224 (run_window_configuration_change_hook): Move set_buffer part
7225 before select_frame_norecord part in order to unwind correctly.
7226 Rename count1 to count.
7227 (recombine_windows, delete_deletable_window, resize_root_window)
7228 (Fdelete_other_windows_internal)
7229 (Frun_window_configuration_change_hook, make_parent_window)
7230 (resize_window_check, resize_window_apply, Fresize_window_apply)
7231 (resize_frame_windows, Fsplit_window_internal)
7232 (Fdelete_window_internal, Fresize_mini_window_internal):
7234 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7236 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7238 * window.h (window): Add some new members to window structure -
7239 normal_lines, normal_cols, new_total, new_normal, clone_number,
7240 splits, nest, prev_buffers, next_buffers.
7241 (WINDOW_TOTAL_SIZE): Move here from window.c.
7242 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7244 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7246 (make_dummy_parent): Set new members of windows structure.
7247 (make_window): Move down in code. Handle new members of window
7249 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7250 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7251 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7252 (Fset_window_prev_buffers, Fwindow_next_buffers)
7253 (Fset_window_next_buffers, Fset_window_clone_number):
7255 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7256 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7258 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7259 Argument WINDOW can be now internal window too.
7260 (Fwindow_use_time): Move up in code.
7261 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7263 (Fset_window_configuration, saved_window)
7264 (Fcurrent_window_configuration, save_window_save): Handle new
7265 members of window structure.
7266 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7267 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7268 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7269 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7270 Qget_mru_window, Qresize_root_window,
7271 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7272 Qauto_buffer_name; staticpro them.
7274 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7276 * window.c (Fwindow_total_size, Fwindow_left_column)
7277 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7278 (Fwindow_list_1): New functions.
7279 (window_box_text_cols): Replace with window_body_cols.
7280 (Fwindow_width, Fscroll_left, Fscroll_right):
7281 Use window_body_cols instead of window_box_text_cols.
7282 (delete_window, Fset_window_configuration):
7283 Call delete_all_subwindows with window as argument.
7284 (delete_all_subwindows): Take a window as argument and not a
7286 (window_loop): Remove handling of GET_LRU_WINDOW and
7288 (Fget_lru_window, Fget_largest_window): Move to window.el.
7290 * window.h: Extern window_body_cols instead of
7291 window_box_text_cols. delete_all_subwindows now takes a
7292 Lisp_Object as argument.
7294 * indent.c (compute_motion, Fcompute_motion):
7295 Use window_body_cols instead of window_box_text_cols.
7297 * frame.c (delete_frame): Call delete_all_subwindows with root
7300 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7302 * fns.c (Fputhash): Document return value.
7304 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7306 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7308 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7310 Cons<->int and similar integer overflow fixes (Bug#8794).
7312 Check for overflow when converting integer to cons and back.
7313 * charset.c (Fdefine_charset_internal, Fdecode_char):
7314 Use cons_to_unsigned to catch overflow.
7315 (Fencode_char): Use INTEGER_TO_CONS.
7316 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7317 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7318 * data.c (long_to_cons, cons_to_long): Remove.
7319 (cons_to_unsigned, cons_to_signed): New functions.
7320 These signal an error for invalid or out-of-range values.
7321 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7322 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7323 * font.c (Ffont_variation_glyphs):
7324 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7325 * lisp.h: Include <intprops.h>.
7326 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7327 (cons_to_signed, cons_to_unsigned): New decls.
7328 (long_to_cons, cons_to_long): Remove decls.
7329 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7330 (Fprimitive_undo): Use CONS_TO_INTEGER.
7331 * xfns.c (Fx_window_property): Likewise.
7332 * xselect.c: Include <limits.h>.
7333 (x_own_selection, selection_data_to_lisp_data):
7334 Use INTEGER_TO_CONS.
7335 (x_handle_selection_request, x_handle_selection_clear)
7336 (x_get_foreign_selection, Fx_disown_selection_internal)
7337 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7338 (lisp_data_to_selection_data): Use cons_to_unsigned.
7339 (x_fill_property_data): Use cons_to_signed.
7340 Report values out of range.
7342 Check for buffer and string overflow more precisely.
7343 * buffer.h (BUF_BYTES_MAX): New macro.
7344 * lisp.h (STRING_BYTES_MAX): New macro.
7345 * alloc.c (Fmake_string):
7346 * character.c (string_escape_byte8):
7347 * coding.c (coding_alloc_by_realloc):
7348 * doprnt.c (doprnt):
7349 * editfns.c (Fformat):
7351 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7352 since they may not be the same number.
7353 * editfns.c (Finsert_char):
7354 * fileio.c (Finsert_file_contents):
7355 Likewise for BUF_BYTES_MAX.
7357 * image.c: Use ptrdiff_t, not int, for sizes.
7358 (slurp_file): Switch from int to ptrdiff_t.
7360 (slurp_file): Check that file size fits in both size_t (for
7361 malloc) and ptrdiff_t (for sanity and safety).
7363 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7364 if b->modtime has its maximal value.
7366 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7368 Don't assume time_t can fit into int.
7369 * buffer.h (struct buffer.modtime): Now time_t, not int.
7370 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7371 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7373 Minor fixes for signed vs unsigned integers.
7374 * character.h (MAYBE_UNIFY_CHAR):
7375 * charset.c (maybe_unify_char):
7376 * keyboard.c (read_char, reorder_modifiers):
7377 XINT -> XFASTINT, since the integer must be nonnegative.
7378 * ftfont.c (ftfont_spec_pattern):
7379 * keymap.c (access_keymap, silly_event_symbol_error):
7380 XUINT -> XFASTINT, since the integer must be nonnegative.
7381 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7382 since it makes no difference and we prefer signed.
7383 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7384 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7387 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7389 * window.h (Fwindow_frame): Declare.
7391 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7393 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7394 (SPARE_MEMORY): Always define.
7395 (LARGE_REQUEST): Remove.
7396 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7398 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7400 * lisp.h: Move EXFUNS for Fframe_root_window,
7401 Fframe_first_window and Fset_frame_selected_window to window.h.
7403 * window.h: Move EXFUNS for Fframe_root_window,
7404 Fframe_first_window and Fset_frame_selected_window here from
7407 * frame.c (Fwindow_frame, Fframe_first_window)
7408 (Fframe_root_window, Fframe_selected_window)
7409 (Fset_frame_selected_window): Move to window.c.
7410 (Factive_minibuffer_window): Move to minibuf.c.
7411 (Fother_visible_frames_p): New function.
7413 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7415 * window.c (decode_window, decode_any_window): Move up in code.
7416 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7417 (inhibit_frame_unsplittable): Remove unused variable.
7418 (Fwindow_buffer): Move up and rewrite doc-string.
7419 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7420 (Fwindow_prev): New functions.
7421 (Fwindow_frame): Move here from frame.c. Accept any window as
7423 (Fframe_root_window, Fframe_first_window)
7424 (Fframe_selected_window): Move here from frame.c. Accept frame
7425 or arbitrary window as argument. Update doc-strings.
7426 (Fminibuffer_window): Move up in code.
7427 (Fwindow_minibuffer_p): Move up in code and simplify.
7428 (Fset_frame_selected_window): Move here from frame.c.
7430 (Fselected_window, select_window, Fselect_window): Move up in
7431 code. Minor doc-string fixes.
7433 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7435 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7436 Do not assume that spare memory exists; that assumption is valid
7437 only if SYSTEM_MALLOC.
7438 (LARGE_REQUEST): New macro, so that the issue of large requests
7439 is separated from the issue of spare memory.
7441 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7443 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7446 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7448 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7451 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7453 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7455 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7457 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7458 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7460 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7462 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7464 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7466 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7467 (x_clipboard_manager_save): Add return value.
7468 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7470 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7471 Obey Vx_select_enable_clipboard_manager. Catch errors in
7472 x_clipboard_manager_save (Bug#8779).
7473 (Vx_select_enable_clipboard_manager): New variable.
7474 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7476 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7478 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7480 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7482 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7483 in the current matrix if keep_current_p is non-zero.
7485 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7487 * bidi.c (bidi_level_of_next_char): Fix last change.
7489 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7491 Support bidi reordering of text covered by display properties.
7493 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7494 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7495 (bidi_cache_search, bidi_cache_iterator_state)
7496 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7497 (bidi_level_of_next_char, bidi_move_to_visually_next):
7498 Support character positions inside a run of characters covered by a
7500 (bidi_paragraph_init, bidi_resolve_explicit_1)
7501 (bidi_level_of_next_char): Call bidi_fetch_char and
7502 bidi_fetch_char_advance instead of FETCH_CHAR and
7504 (bidi_init_it): Initialize new members.
7505 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7507 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7508 instead of using explicit *_CHAR codes.
7509 (bidi_resolve_explicit, bidi_resolve_weak):
7510 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7511 bidirectional text is supported only in multibyte buffers.
7512 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7513 it to initialize the frame_window_p member of struct bidi_it.
7514 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7515 (bidi_resolve_explicit, bidi_resolve_weak)
7516 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7517 bidi_it->nchars is non-positive.
7518 (bidi_level_of_next_char): Don't try to lookup the cache for the
7519 next/previous character if nothing is cached there yet, or if we
7520 were just reseat()'ed to a new position.
7522 * xdisp.c (set_cursor_from_row): Set start and stop points
7523 according to the row's direction when priming the loop that looks
7524 for the glyph on which to display cursor.
7525 (single_display_spec_intangible_p): Function deleted.
7526 (display_prop_intangible_p): Reimplement to call
7527 handle_display_spec instead of single_display_spec_intangible_p.
7528 Accept 3 additional arguments needed by handle_display_spec.
7529 This fixes incorrect cursor motion across display property with complex
7530 values: lists, `(when COND...)' forms, etc.
7531 (single_display_spec_string_p): Support property values that are
7532 lists with the argument STRING its top-level element.
7533 (display_prop_string_p): Fix the condition for processing a
7534 property that is a list to be consistent with handle_display_spec.
7535 (handle_display_spec): New function, refactored from the
7536 last portion of handle_display_prop.
7537 (compute_display_string_pos): Accept additional argument
7538 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7539 value of a `display' property is a "replacing spec".
7540 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7541 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7542 the display property, but just return a value indicating whether
7543 the display property will replace the characters it covers.
7544 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7545 frame_window_p members of struct bidi_it.
7546 (compute_display_string_pos, compute_display_string_end):
7548 (push_it): Accept second argument POSITION, where pop_it should
7549 jump to continue iteration.
7550 (reseat_1): Initialize bidi_it.disp_pos.
7552 * keyboard.c (adjust_point_for_property): Adjust the call to
7553 display_prop_intangible_p to its new signature.
7555 * dispextern.h (struct bidi_it): New member frame_window_p.
7556 (bidi_init_it): Update prototypes.
7557 (display_prop_intangible_p): Update prototype.
7558 (compute_display_string_pos, compute_display_string_end):
7560 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7563 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7565 Malloc failure behavior now depends on size of allocation.
7566 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7567 * lisp.h: Change signatures accordingly.
7568 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7569 All callers changed. (Bug#8762)
7571 * gnutls.c: Use Emacs's memory allocators.
7572 Without this change, the gnutls library would invoke malloc etc.
7573 directly, which causes problems on non-SYNC_INPUT hosts, and which
7574 runs afoul of improving memory_full behavior. (Bug#8761)
7575 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7576 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7577 xfree instead of the default malloc, realloc, free.
7578 (Fgnutls_boot): No need to check for memory allocation failure,
7579 since xmalloc does that for us.
7581 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7582 * category.c (hash_get_category_set):
7583 * ccl.c (ccl_driver):
7584 * charset.c (Fdefine_charset_internal):
7585 * charset.h (struct charset.hash_index):
7586 * composite.c (get_composition_id, gstring_lookup_cache)
7587 (composition_gstring_put_cache):
7588 * composite.h (struct composition.hash_index):
7589 * dispextern.h (struct image.hash):
7590 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7591 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7592 (hashfn_equal, hashfn_user_defined, make_hash_table)
7593 (maybe_resize_hash_table, hash_lookup, hash_put)
7594 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7595 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7596 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7597 * image.c (make_image, search_image_cache, lookup_image)
7598 (xpm_put_color_table_h):
7599 * lisp.h (struct Lisp_Hash_Table):
7600 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7601 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7602 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7603 * alloc.c (allocate_vectorlike):
7604 Check for overflow in vector size calculations.
7605 * ccl.c (ccl_driver):
7606 Check for overflow when converting EMACS_INT to int.
7607 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7608 need to be updated by these changes.
7609 * fns.c (make_hash_table, maybe_resize_hash_table):
7610 Check for integer overflow with large hash tables.
7611 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7612 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7613 (SXHASH_REDUCE): New macro.
7614 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7615 Use it instead of discarding useful hash info with large hash values.
7616 (sxhash_float): New function.
7617 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7618 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7619 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7620 Rewrite to use FIXNUM_BITS, as this simplifies things.
7621 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7622 Adjust signatures to match updated version of code.
7623 (consing_since_gc): Now EMACS_INT, since a single hash table can
7624 use more than INT_MAX bytes.
7626 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7628 Make it possible to build with GCC-4.6+ -O2 -flto.
7630 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7632 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7634 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7635 Call minibuffer-inactive-mode.
7637 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7639 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7640 Update dependencies.
7642 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7644 * data.c (init_data): Remove code for UTS, this system is not
7647 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7649 Don't force ./temacs to start in terminal mode.
7651 * frame.c (make_initial_frame): Initialize faces in all cases, not
7652 only when CANNOT_DUMP is defined.
7653 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7655 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7657 * dispnew.c (add_window_display_history): Use const for the string
7658 pointer. Remove declaration, not needed.
7660 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7662 Use 'inline', not 'INLINE'.
7663 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7664 * alloc.c, fontset.c (INLINE): Remove.
7665 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7666 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7667 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7668 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7669 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7671 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7673 Make it possible to run ./temacs.
7675 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7676 syms_of_callproc does the same thing. Remove test for
7677 "initialized", do it in the caller.
7678 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7680 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7682 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7683 (read_minibuf): Use get_minibuffer.
7684 (syms_of_minibuf): Use DEFSYM.
7685 (Qmetadata): New var.
7686 * data.c (Qbuffer): Don't make it static.
7687 (syms_of_data): Use DEFSYM.
7689 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7691 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7692 (CCL_CODE_MIN): New macro.
7694 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7696 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7698 * eval.c (Qdebug): Now static.
7699 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7700 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7701 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7703 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7705 * image.c: Various fixes to ImageMagick code comments.
7706 (Fimagemagick_types): Doc fix.
7708 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7710 Minor fixes prompted by GCC 4.6.0 warnings.
7712 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7714 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7715 (x_clipboard_manager_save_all): Move extern decl to ...
7716 * xterm.h: ... here, so that it can be checked for consistency.
7718 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7720 * xselect.c (x_clipboard_manager_save_frame)
7721 (x_clipboard_manager_save_all): New functions.
7722 (Fx_clipboard_manager_save): Lisp function deleted.
7724 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7725 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7727 * xterm.h: Update prototype.
7729 2011-05-28 William Xu <william.xwl@gmail.com>
7731 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7734 2011-05-28 Jim Meyering <meyering@redhat.com>
7736 Avoid a sign-extension bug in crypto_hash_function.
7737 * fns.c (to_uchar): Define.
7738 (crypto_hash_function): Use it to convert some newly-signed
7739 variables to unsigned, to avoid sign-extension bugs. For example,
7740 without this change, (md5 "truc") would evaluate to
7741 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7742 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7743 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7745 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7747 Integer overflow fixes.
7749 * dbusbind.c: Serial number integer overflow fixes.
7750 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7751 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7752 to hold a serial number that is too large for a fixnum.
7753 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7754 Check for serial numbers out of range. Decode any serial number
7755 that was so large that it became a float. (Bug#8722)
7757 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7758 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7759 Use XFASTINT rather than XUINT when numbers are nonnegative.
7760 (xd_append_arg, Fdbus_method_return_internal):
7761 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7762 arguments, check that Lisp number is nonnegative, rather than
7763 silently wrapping negative numbers around. (Bug#8722)
7764 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7767 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7769 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7771 ccl: Add integer overflow checks.
7772 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7773 (IN_INT_RANGE): New macros.
7774 (ccl_driver): Use them to check for integer overflow when
7775 decoding a CCL program. Many of the new checks are whether XINT (x)
7776 fits in int; it doesn't always, on 64-bit hosts. The new version
7777 doesn't catch all possible integer overflows, but it's an
7778 improvement. (Bug#8719)
7780 * alloc.c (make_event_array): Use XINT, not XUINT.
7781 There's no need for unsigned here.
7783 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7784 This follows up to the 2011-05-06 change that substituted uintptr_t
7785 for EMACS_INT. This case wasn't caught back then.
7787 Rework Fformat to avoid integer overflow issues.
7788 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7789 now (part of C89). Include <verify.h>.
7790 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7791 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7792 (Fformat): Avoid the prepass trying to compute sizes; it was only
7793 approximate and thus did not catch overflow reliably. Instead, walk
7794 through the format just once, formatting and computing sizes as we go,
7795 checking for integer overflow at every step, and allocating a larger
7796 buffer as needed. Keep track separately whether the format is
7797 multibyte. Keep only the most-recently calculated precision, rather
7798 than them all. Record whether each argument has been converted to
7799 string. Use EMACS_INT, not int, for byte and char and arg counts.
7800 Support field widths and precisions larger than INT_MAX. Avoid
7801 sprintf's undefined behavior with conversion specifications such as %#d
7802 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7803 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7804 formatting out-of-range floating point numbers with int
7807 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7809 * data.c: Avoid integer truncation in expressions involving floats.
7810 * data.c: Include <intprops.h>.
7811 (arith_driver): When there's an integer overflow in an expression
7812 involving floating point, convert the integers to floating point
7813 so that the resulting value does not suffer from catastrophic
7814 integer truncation. For example, on a 64-bit host (* 4
7815 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7816 Do not rely on undefined behavior after integer overflow.
7818 merge count_size_as_multibyte, parse_str_to_multibyte
7819 * character.c, character.h (count_size_as_multibyte):
7820 Rename from parse_str_to_multibyte; all uses changed.
7821 Check for integer overflow.
7822 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7823 since it's now a duplicate of the other. This is more of
7824 a character than a buffer op, so better that it's in character.c.
7825 * fns.c, print.c: Adjust to above changes.
7827 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7829 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7831 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7833 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7834 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7835 (x_clipboard_manager_save): Now static.
7836 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7838 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7839 (crypto_hash_function): Now static.
7840 Fix pointer signedness problems. Avoid unnecessary initializations.
7842 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7844 * termhooks.h (Vselection_alist): Make it terminal-local.
7846 * terminal.c (create_terminal): Initialize it.
7848 * xselect.c: Support for clipboard managers.
7849 (Vselection_alist): Move to termhooks.h as terminal-local var.
7850 (LOCAL_SELECTION): New macro.
7851 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7852 (symbol_to_x_atom): Remove gratuitous arg.
7853 (x_handle_selection_request, lisp_data_to_selection_data)
7854 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7855 (x_own_selection, x_get_local_selection, x_convert_selection):
7856 New arg, specifying work frame. Use terminal-local Vselection_alist.
7857 (some_frame_on_display): Delete unused function.
7858 (Fx_own_selection_internal, Fx_get_selection_internal)
7859 (Fx_disown_selection_internal, Fx_selection_owner_p)
7860 (Fx_selection_exists_p): New optional frame arg.
7861 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7862 (x_handle_selection_clear): Don't treat other terminals with the
7863 same keyboard specially. Use the terminal-local Vselection_alist.
7864 (x_clear_frame_selections): Use Frun_hook_with_args.
7866 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7868 * xterm.h: Add support for those atoms.
7870 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7872 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7873 (converted_selections, conversion_fail_tag): New global variables.
7874 (x_selection_request_lisp_error): Free the above.
7875 (x_get_local_selection): Remove unnecessary code.
7876 (x_reply_selection_request): Args changed; handle arbitrary array
7877 of converted selections stored in converted_selections.
7878 Separate the XChangeProperty and SelectionNotify steps.
7879 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7880 (x_convert_selection): New function.
7881 (x_handle_selection_event): Simplify.
7882 (x_get_foreign_selection): Don't ignore incoming requests while
7883 waiting for an answer; this will fail when we implement
7884 SAVE_TARGETS, and seems unnecessary anyway.
7885 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7886 (Vx_sent_selection_functions): Doc fix.
7888 2011-05-26 Leo Liu <sdl.web@gmail.com>
7890 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7892 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7894 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7896 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7897 for fringe update if it has periodic bitmap.
7898 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7899 and fringe_bitmap_periodic_p.
7901 * fringe.c (get_fringe_bitmap_data): New function.
7902 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7903 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7904 row. Mark glyph row for fringe update if periodicity changed.
7906 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7907 for fringe update unless it has periodic bitmap.
7909 2011-05-25 Kenichi Handa <handa@m17n.org>
7911 * xdisp.c (get_next_display_element): Set correct it->face_id for
7912 a static composition.
7914 2011-05-24 Leo Liu <sdl.web@gmail.com>
7917 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7919 * fns.c (crypto_hash_function, Fsha1): New function.
7920 (Fmd5): Use crypto_hash_function.
7921 (syms_of_fns): Add Ssha1.
7923 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7925 * gnutls.c: Remove unused macros.
7926 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7927 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7928 Remove macros that are defined and never used.
7929 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7931 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7933 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7934 (Fx_get_selection_internal): Minor cleanup.
7935 (Fx_own_selection_internal): Rename arguments for consistency with
7938 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7940 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7942 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7944 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7946 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7948 * dispnew.c (scrolling_window): Don't exclude the case that the
7949 last enabled row in the desired matrix touches the bottom boundary.
7951 2011-05-21 Glenn Morris <rgm@gnu.org>
7953 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7954 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7955 and add some more files.
7957 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7959 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7960 report_file_error introduced by the change from 2011-05-07.
7962 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7964 * systime.h (Time): Define only if emacs is defined.
7965 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7966 where the include path doesn't have X11/X.h by default. See
7967 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7969 2011-05-20 Kenichi Handa <handa@m17n.org>
7971 * composite.c (find_automatic_composition): Fix previous change.
7973 2011-05-20 Glenn Morris <rgm@gnu.org>
7975 * lisp.mk: New file, split from Makefile.in.
7976 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7977 (shortlisp): Remove.
7978 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7980 2011-05-19 Glenn Morris <rgm@gnu.org>
7982 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7983 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7984 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7985 (lisp): Set the order to that of loadup.el.
7986 (shortlisp): Make it a copy of $lisp.
7987 (SOME_MACHINE_LISP): Remove.
7988 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7989 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7991 2011-05-18 Kenichi Handa <handa@m17n.org>
7993 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7994 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7995 (find_automatic_composition): Mostly rewrite for efficiency.
7997 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7999 * makefile.w32-in: Update dependencies.
8001 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8003 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8004 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8006 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8008 Fix some integer overflow issues, such as string length overflow.
8010 * insdel.c (count_size_as_multibyte): Check for string overflow.
8012 * character.c (lisp_string_width): Check for string overflow.
8013 Use EMACS_INT, not int, for string indexes and lengths; in
8014 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8015 the resulting string length overflows an EMACS_INT; instead,
8016 report a string overflow if no precision given. When checking for
8017 precision exhaustion, use a check that cannot possibly have
8018 integer overflow. (Bug#8675)
8019 * character.h (lisp_string_width): Adjust to new signature.
8021 * alloc.c (string_overflow): New function.
8022 (Fmake_string): Use it. This doesn't change behavior, but saves
8023 a few bytes and will simplify future changes.
8024 * character.c (string_escape_byte8): Likewise.
8025 * lisp.h (string_overflow): New decl.
8027 Fixups, following up to the user-interface timestamp change.
8028 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8029 for UI timestamps, instead of unsigned long.
8030 * msdos.c (mouse_get_pos): Likewise.
8031 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8032 * w32gui.h (Time): Define by including "systime.h" rather than by
8033 declaring it ourselves. (Bug#8664)
8035 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8036 * image.c (clear_image_cache): Likewise.
8038 * term.c (term_mouse_position): Don't assume time_t wraparound.
8040 Be more systematic about user-interface timestamps.
8041 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8042 and sometimes 'EMACS_UINT', to represent these timestamps.
8043 This change causes it to use 'Time' uniformly, as that's what X uses.
8044 This makes the code easier to follow, and makes it easier to catch
8045 integer overflow bugs such as Bug#8664.
8046 * frame.c (Fmouse_position, Fmouse_pixel_position):
8047 Use Time, not unsigned long, for user-interface timestamps.
8048 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8049 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8050 * keyboard.h (last_event_timestamp): Likewise.
8051 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8052 * menu.h (xmenu_show): Likewise.
8053 * term.c (term_mouse_position): Likewise.
8054 * termhooks.h (struct input_event.timestamp): Likewise.
8055 (struct terminal.mouse_position_hook): Likewise.
8056 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8057 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8058 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8059 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8061 * menu.h, termhooks.h: Include "systime.h", for Time.
8063 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8064 Don't assume that the difference between two unsigned long values
8065 can fit into an integer. At this point, we know button_down_time
8066 <= event->timestamp, so the difference must be nonnegative, so
8067 there's no need to cast the result if double-click-time is
8068 nonnegative, as it should be; check that it's nonnegative, just in
8069 case. This bug is triggered when events are more than 2**31 ms
8070 apart (about 25 days). (Bug#8664)
8072 * xselect.c (last_event_timestamp): Remove duplicate decl.
8073 (x_own_selection): Remove needless cast to unsigned long.
8075 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8076 that always fit in int. Use a sentinel instead of a counter, to
8077 avoid a temp and to allay GCC's concerns about possible int overflow.
8078 * frame.h (struct frame): Use int for menu_bar_items_used
8079 instead of EMACS_INT, since it always fits in int.
8081 * menu.c (grow_menu_items): Check for int overflow.
8083 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8085 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8086 Before, the code was not consistent. These values cannot exceed
8087 2**31 - 1 so there's no need to make them unsigned.
8088 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8089 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8090 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8092 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8094 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8095 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8096 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8097 presumably because the widths might not match.
8099 * window.c (size_window): Avoid needless test at loop start.
8101 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8103 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8105 2011-05-12 Drew Adams <drew.adams@oracle.com>
8107 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8109 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8111 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8112 `width' to `bar_area_x' and `bar_area_width', respectively.
8113 (x_scroll_run): Take account of fringe background extension.
8115 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8116 Rename local vars `left' and `width' to `bar_area_x' and
8117 `bar_area_width', respectively.
8118 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8119 background extension.
8121 2011-05-10 Jim Meyering <meyering@redhat.com>
8123 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8125 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8127 * image.c (Finit_image_library): Return t for built-in image types,
8128 like pbm and xbm. (Bug#8640)
8130 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8132 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8134 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8136 * w32console.c (Fset_screen_color): Doc fix.
8137 (Fget_screen_color): New function.
8138 (syms_of_ntterm): Defsubr it.
8140 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8141 unlink the temporary file if Fcall_process didn't create it in the
8143 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8144 child process will be redirected to a file specified with `:file'.
8145 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8146 cue to call_process_cleanup not to close that handle.
8148 2011-05-07 Ben Key <bkey76@gmail.com>
8150 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8151 one of two shell specific rules, either bootstrap-temacs-CMD or
8152 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8153 to the previous implementation of the bootstrap-temacs rule.
8154 The bootstrap-temacs-CMD rule is similar to the previous
8155 implementation of the bootstrap-temacs rule except that it
8156 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8159 These changes, along with some changes to nt/configure.bat,
8160 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8161 earlier fix to add support for --cflags and --ldflags options
8162 that include quotes so that it works whether make uses cmd or
8165 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8167 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8168 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8170 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8171 a string. Handle both cases.
8172 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8173 (Fdbus_register_method): Use Qinvalid_function.
8175 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8177 * makefile.w32-in: Update dependencies.
8178 (LISP_H): Add inttypes.h and stdin.h.
8179 (PROCESS_H): Add unistd.h.
8181 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8183 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8184 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8186 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8188 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8190 * term.c (vfatal): Remove stray call to va_end.
8191 It's not needed and the C Standard doesn't allow it here anyway.
8193 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8194 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8196 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8199 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8201 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8203 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8205 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8207 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8209 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8210 * charset.c (Fdefine_charset_internal): Don't initialize
8211 charset.code_space[15]. The value was garbage, on hosts with
8212 32-bit int (Bug#8600).
8214 * lread.c (read_integer): Be more consistent with string-to-number.
8215 Use string_to_number to do the actual conversion; this avoids
8216 rounding errors and fixes some other screwups. Without this fix,
8217 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8218 (digit_to_number): Move earlier, for benefit of read_integer.
8219 Return -1 if the digit is out of range for the base, -2 if it is
8220 not a digit in any supported base. (Bug#8602)
8222 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8224 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8225 to match comment at start of function. This also removes a
8226 GCC warning about overflow in a 32+64-bit port.
8228 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8230 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8231 Reported by Stefan Monnier in
8232 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8233 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8234 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8236 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8237 (EMACS_UINTPTR): Likewise, with uintptr_t.
8239 * lisp.h: Prefer 64-bit EMACS_INT if available.
8240 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8241 on 32-bit hosts that have 64-bit int, so that they can access
8243 However, temporarily disable this change unless the temporary
8244 symbol WIDE_EMACS_INT is defined.
8246 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8248 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8249 This removes an assumption that EMACS_INT and long are the same
8250 width as pointers. The assumption is true for Emacs porting targets
8251 now, but we want to make other targets possible.
8252 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8253 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8254 In the rest of the code, change types of integers that hold casted
8255 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8256 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8257 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8258 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8259 No need to cast type when ORing.
8260 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8261 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8262 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8263 assume EMACS_INT is the same width as char *.
8264 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8265 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8266 Remove no-longer-needed casts.
8267 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8268 (xg_tool_bar_help_callback, xg_make_tool_item):
8269 Use EMACS_INTPTR to hold an integer
8270 that will be cast to void *; this can avoid a GCC warning
8271 if EMACS_INT is not the same width as void *.
8272 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8273 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8274 (current_message_1, set_message_1):
8275 Use a local to convert to proper width without a cast.
8276 * xmenu.c (dialog_selection_callback): Likewise.
8278 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8279 Also, don't assume VALBITS / RAND_BITS is less than 5,
8280 and don't rely on undefined behavior when shifting a 1 left into
8282 * lisp.h (get_random): Change signature to match.
8284 * lread.c (hash_string): Use size_t, not int, for hash computation.
8285 Normally we prefer signed values; but hashing is special, because
8286 it's better to use unsigned division on hash table sizes so that
8287 the remainder is nonnegative. Also, size_t is the natural width
8288 for hashing into memory. The previous code used 'int', which doesn't
8289 retain enough info to hash well into very large tables.
8290 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8292 * dbusbind.c: Don't possibly lose pointer info when converting.
8293 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8294 Use XPNTR rather than XHASH, so that the high-order bits of
8295 the pointer aren't lost when converting through void *.
8297 * eval.c (Fautoload): Don't double-shift a pointer.
8299 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8301 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8303 * gnutls.c (DEF_GNUTLS_FN):
8304 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8306 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8308 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8311 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8313 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8314 New version that can reserve upto 2GB of heap space.
8316 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8318 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8320 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8322 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8323 `gnutls_certificate_set_x509_key_file'.
8325 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8327 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8328 Update dependencies.
8330 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8332 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8333 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8334 Remove unused parameter `fildes'.
8335 * process.c (read_process_output, send_process): Don't pass it.
8337 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8339 Fix previous change: the library cache is defined in w32.c.
8340 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8341 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8343 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8345 Implement dynamic loading of GnuTLS on Windows.
8347 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8348 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8349 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8352 * gnutls.c (Qgnutls_dll): Define.
8353 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8354 (gnutls_*): Declare function pointers.
8355 (init_gnutls_functions): New function to initialize function pointers.
8356 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8357 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8358 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8359 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8360 (emacs_gnutls_write, emacs_gnutls_read)
8361 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8362 (Fgnutls_available_p): New function.
8363 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8364 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8365 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8367 * image.c: Include w32.h.
8368 (Vimage_type_cache): Delete.
8369 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8370 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8371 (w32_delayed_load): Move to w32.c.
8373 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8375 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8376 (w32_delayed_load): Move from image.c. When loading a library, record
8377 its filename in the :loaded-from property of the library id.
8378 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8379 Initialize and staticpro them.
8380 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8382 * process.c: Include lisp.h before w32.h, not after.
8383 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8384 instead of gnutls_record_check_pending.
8386 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8388 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8390 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8391 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8394 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8396 * xterm.c (x_set_frame_alpha): Do not set property on anything
8397 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8399 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8401 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8403 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8405 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8406 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8407 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8408 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8409 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8410 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8411 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8412 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8413 (Qgnutls_bootprop_callbacks_verify): Make static.
8415 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8417 * callproc.c: Indentation fixup.
8419 * sysdep.c (wait_for_termination_1): Make static.
8420 (wait_for_termination, interruptible_wait_for_termination):
8421 Move after wait_for_termination_1.
8423 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8425 * sysdep.c (interruptible_wait_for_termination): New function
8426 which is like wait_for_termination, but allows keyboard
8429 * callproc.c (Fcall_process): Add (:file "file") as an option for
8431 (Fcall_process_region): Ditto.
8433 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8435 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8436 rather than `XVECTOR (FOO)->size'.
8438 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8439 inttypes.h, as a gnulib replacement is used if it not available in
8442 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8444 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8445 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8446 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8448 * coding.c (coding_alloc_by_realloc): Error out if destination
8449 will grow beyond MOST_POSITIVE_FIXNUM.
8450 (decode_coding_emacs_mule): Abort if there isn't enough place in
8451 charbuf for the composition carryover bytes. Reserve an extra
8452 space for up to 2 characters produced in a loop.
8453 (decode_coding_iso_2022): Abort if there isn't enough place in
8454 charbuf for the composition carryover bytes.
8456 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8458 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8459 aborting when %lld or %lll format is passed.
8460 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8461 %llo or %llx format is passed. (Bug#8545)
8463 * window.c (window_scroll_line_based): Use a marker instead of
8464 simple variables to record original value of point. (Bug#7952)
8466 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8467 produced by %s or %c overflows available buffer space. (Bug#8545)
8469 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8471 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8472 (SIZE_MAX): Move defn after all includes, as they might #define it.
8474 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8476 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8478 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8480 * keyboard.c (Qdelayed_warnings_hook): Define.
8481 (command_loop_1): Run `delayed-warnings-hook'
8482 if Vdelayed_warnings_list is non-nil.
8483 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8484 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8486 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8488 * doprnt.c (doprnt): Don't return value smaller than the buffer
8489 size if the message was truncated. (Bug#8545).
8491 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8493 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8494 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8496 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8498 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8500 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8502 * makefile.w32-in: Update dependencies.
8504 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8506 Improve `doprnt' and its usage. (Bug#8545)
8507 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8508 `format_end'. Remove support for %l as a conversion specifier.
8509 Don't use xrealloc. Improve diagnostics when the %l size modifier
8510 is used. Update the commentary.
8512 * eval.c (verror): Simplify calculation of size_t.
8514 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8517 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8519 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8522 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8524 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8525 This makes this file independent of the recent pseudovector change.
8527 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8529 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8531 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8532 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8533 Remove unused local.
8534 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8536 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8537 GCC 4.6.0 optimizes based on type-based alias analysis.
8538 For example, if b is of type struct buffer * and v of type struct
8539 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8540 != &v->size, and therefore "v->size = 1; b->size = 2; return
8541 v->size;" must therefore return 1. This assumption is incorrect
8542 for Emacs, since it type-puns struct Lisp_Vector * with many other
8543 types. To fix this problem, this patch adds a new type struct
8544 vectorlike_header that documents the constraints on layout of vectors
8545 and pseudovectors, and helps optimizing compilers not get fooled
8546 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8547 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8548 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8550 (XSETPVECTYPE): Rewrite in terms of new macro.
8551 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8552 This is a bit clearer, and further avoids the possibility of
8553 undesirable aliasing.
8554 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8555 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8556 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8557 since Lisp_Subr is a special case (no "next" field).
8558 (ASIZE): Now uses header.size rather than size.
8559 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8560 to avoid the hassle of writing XVECTOR (foo)->header.size.
8561 (struct vectorlike_header): New type.
8562 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8563 object, to help avoid aliasing.
8564 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8565 (SUBRP): Likewise, since Lisp_Subr is a special case.
8566 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8567 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8568 (struct Lisp_Hash_Table): Combine first two members into a single
8569 struct vectorlike_header member. All uses of "size" and "next" members
8570 changed to be "header.size" and "header.next".
8571 * buffer.h (struct buffer): Likewise.
8572 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8573 * frame.h (struct frame): Likewise.
8574 * process.h (struct Lisp_Process): Likewise.
8575 * termhooks.h (struct terminal): Likewise.
8576 * window.c (struct save_window_data, struct saved_window): Likewise.
8577 * window.h (struct window): Likewise.
8578 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8579 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8580 * buffer.c (init_buffer_once): Likewise.
8581 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8583 * process.c (Fformat_network_address): Use local var for size,
8586 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8588 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8589 * data.c (atof): Remove decl; no longer used or needed.
8590 (digit_to_number): Move to lread.c.
8591 (Fstring_to_number): Use new string_to_number function, to be
8592 consistent with how the Lisp reader treats infinities and NaNs.
8593 Do not assume that floating-point numbers represent EMACS_INT
8594 without losing information; this is not true on most 64-bit hosts.
8595 Avoid double-rounding errors, by insisting on integers when
8596 parsing non-base-10 numbers, as the documentation specifies.
8597 * lisp.h (string_to_number): New decl, replacing ...
8598 (isfloat_string): Remove.
8599 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8600 (read1): Do not accept +. and -. as integers; this
8601 appears to have been a coding error. Similarly, do not accept
8602 strings like +-1e0 as floating point numbers. Do not report
8603 overflow for integer overflows unless the base is not 10 which
8604 means we have no simple and reliable way to continue.
8605 Break out the floating-point parsing into a new
8606 function string_to_number, so that Fstring_to_number parses
8607 floating point numbers consistently with the Lisp reader.
8608 (digit_to_number): Move here from data.c. Make it static inline.
8609 (E_CHAR, EXP_INT): Remove, replacing with ...
8610 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8611 (string_to_number): New function, replacing isfloat_string.
8612 This function checks for valid syntax and produces the resulting
8613 Lisp float number too. Rework it so that string-to-number
8614 no longer mishandles examples like "1.0e+". Use strtoumax,
8615 so that overflow for non-base-10 numbers is reported only when
8616 there's no portable and simple way to convert to floating point.
8618 * textprop.c (set_text_properties_1): Rewrite for clarity,
8619 and to avoid GCC warning about integer overflow.
8621 * intervals.h (struct interval): Use EMACS_INT for members
8622 where EMACS_UINT might cause problems. See
8623 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8624 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8625 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8627 (offset_intervals): Tell GCC not to worry about length overflow
8628 when negating a negative length.
8630 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8631 (overrun_check_free): Likewise.
8633 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8634 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8637 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8638 (gnutls_make_error): Rename local to avoid shadowing.
8639 (gnutls_emacs_global_deinit): ifdef out; not used.
8640 (Fgnutls_boot): Use const for pointer to readonly storage.
8641 Comment out unused local. Fix pointer signedness problems.
8643 * lread.c (openp): Don't stuff size_t into an 'int'.
8644 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8645 about possible signed overflow.
8647 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8648 (GDK_KEY_g): Don't define if already defined.
8649 (xg_prepare_tooltip): Avoid pointer signedness problem.
8650 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8652 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8653 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8655 * xfns.c (Fx_window_property): Simplify a bit,
8656 to make a bit faster and to avoid GCC 4.6.0 warning.
8657 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8659 * fns.c (internal_equal): Don't assume size_t fits in int.
8661 * alloc.c (compact_small_strings): Tighten assertion a little.
8663 Replace pEd with more-general pI, and fix some printf arg casts.
8664 * lisp.h (pI): New macro, generalizing old pEd macro to other
8665 conversion specifiers. For example, use "...%"pI"d..." rather
8666 than "...%"pEd"...".
8667 (pEd): Remove. All uses replaced with similar uses of pI.
8668 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8669 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8670 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8671 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8672 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8673 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8674 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8676 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8677 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8678 * print.c (safe_debug_print, print_object): Likewise.
8679 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8681 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8682 avoiding the 0 flag, which is not portable.
8683 * process.c (Fmake_network_process): Use pI to avoid cast.
8684 * region-cache.c (pp_cache): Likewise.
8685 * xdisp.c (decode_mode_spec): Likewise.
8686 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8687 behavior on 64-bit hosts with printf arg.
8688 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8689 (x_stop_queuing_selection_requests): Likewise.
8690 (x_get_window_property): Don't truncate byte count to an 'int'
8693 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8694 here, since it parses constructs like leading '-' and spaces,
8695 which are not wanted; and it overflows with large numbers.
8696 Instead, simply match F[0-9]+, which is what is wanted anyway.
8698 * alloc.c: Remove unportable assumptions about struct layout.
8699 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8700 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8701 (allocate_vectorlike, make_pure_vector): Use the new macros,
8702 plus offsetof, to remove unportable assumptions about struct layout.
8703 These assumptions hold on all porting targets that I know of, but
8704 they are not guaranteed, they're easy to remove, and removing them
8705 makes further changes easier.
8707 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8708 This doesn't fix a bug but makes the code clearer.
8709 (string_overrun_cookie): Now const. Use initializers that
8710 don't formally overflow signed char, to avoid warnings.
8711 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8712 can cause Emacs to crash when string overrun checking is enabled.
8713 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8714 multiple of sizeof (EMACS_INT); it need not be, if
8715 alignof(EMACS_INT) < sizeof (EMACS_INT).
8716 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8718 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8720 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8722 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8724 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8725 supposed to be handshaking. (Bug#8556)
8726 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8728 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8730 * lisp.h (Qdebug): List symbol.
8731 * eval.c (Qdebug): Restore global linkage.
8732 * keyboard.c (debug-on-event): New variable.
8733 (handle_user_signal): Break into debugger when debug-on-event
8734 matches the current signal symbol.
8736 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8738 * alloc.c (check_sblock, check_string_bytes)
8739 (check_string_free_list): Convert to standard C.
8741 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8743 * w32.c (emacs_gnutls_push): Fix typo.
8745 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8747 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8748 "cast to pointer from integer of different size".
8750 Improve doprnt and its use in verror. (Bug#8545)
8751 * doprnt.c (doprnt): Document the set of format control sequences
8752 supported by the function. Use SAFE_ALLOCA instead of always
8755 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8756 is one byte too soon. Don't use xrealloc; instead xfree and
8759 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8761 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8764 * gnutls.c: Renamed global_initialized to
8765 gnutls_global_initialized. Added internals for the
8766 :verify-hostname-error, :verify-error, and :verify-flags
8767 parameters of `gnutls-boot' and documented those parameters in the
8768 docstring. Start callback support.
8769 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8770 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8771 on error. Return error code.
8772 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8773 (emacs_gnutls_read): Likewise.
8774 (Fgnutls_boot): Return handshake error code.
8775 (emacs_gnutls_handle_error): New function.
8776 (wsaerror_to_errno): Likewise.
8778 * w32.h (emacs_gnutls_pull): Add prototype.
8779 (emacs_gnutls_push): Likewise.
8781 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8782 (emacs_gnutls_push): Likewise.
8784 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8786 * process.c (wait_reading_process_output): Check if GnuTLS
8787 buffered some data internally if no FDs are set for TLS
8790 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8791 (LIBS): Link to USER_LIBS.
8792 ($(BLD)/gnutls.$(0)): New target.
8794 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8796 * xdisp.c (handle_single_display_spec): Rename the
8797 display_replaced_before_p argument into display_replaced_p, to
8798 make it consistent with the commentary. Fix typos in the
8801 * textprop.c (syms_of_textprop): Remove dead code.
8802 (copy_text_properties): Delete obsolete commentary about an
8803 interface that was deleted long ago. Fix typos in the description
8806 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8807 to changes in oldXMenu/XMenu.h from 2011-04-16.
8808 <menu_help_message, prev_menu_help_message>: Constify.
8809 (IT_menu_make_room): menu->help_text is now `const char **';
8812 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8813 to changes in oldXMenu/XMenu.h from 2011-04-16.
8814 (struct XMenu): Declare `help_text' `const char **'.
8816 * xfaces.c <Qunspecified>: Make extern again.
8818 * syntax.c: Include sys/types.h before including regex.h, as
8821 * doc.c (get_doc_string): Improve the format passed to `error'.
8823 * doprnt.c (doprnt): Improve commentary.
8825 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8827 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8830 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8831 changes in globals.h immediately force recompilation.
8832 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8833 $(CURDIR)/s/ms-w32.h.
8834 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8836 * character.c (Fchar_direction): Function deleted.
8837 (syms_of_character): Don't defsubr it.
8838 <char-direction-table>: Deleted.
8840 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8842 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8843 * doprnt.c: Include limits.h.
8844 (SIZE_MAX): New macro.
8845 (doprnt): Return a size_t value. 2nd arg is now size_t.
8846 Many local variables are now size_t instead of int or unsigned.
8847 Improve overflow protection. Support `l' modifier for integer
8848 conversions. Support %l conversion. Don't assume an EMACS_INT
8849 argument for integer conversions and for %c.
8851 * lisp.h (doprnt): Restore prototype.
8853 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8856 * Makefile.in (base_obj): Add back doprnt.o.
8858 * deps.mk (doprnt.o): Add back prerequisites.
8859 (callint.o): Depend on character.h.
8861 * eval.c (internal_lisp_condition_case): Include the handler
8862 representation in the error message.
8863 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8864 when breaking from the loop.
8866 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8868 * callint.c (Fcall_interactively): When displaying error message
8869 about invalid control letter, pass the character's codepoint, not
8870 a pointer to its multibyte form. Improve display of the character
8871 in octal and display also its hex code.
8873 * character.c (char_string): Use %x to display the (unsigned)
8874 codepoint of an invalid character, to avoid displaying a bogus
8877 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8878 `error', not SYMBOL_NAME itself.
8880 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8881 character arguments to `error'.
8883 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8884 to `error' in error message about FINAL_CHAR argument. Make sure
8885 FINAL_CHAR is a character, and use %c when it is passed as
8886 argument to `error'.
8888 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8890 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8892 * w32.c: Include <time.h>.
8893 (sys_localtime): New function.
8895 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8897 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8899 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8901 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8903 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8906 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8908 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8909 gl_state.e_property when gl_state.object is Qt.
8911 * insdel.c (make_gap_larger): Remove limitation of buffer size
8914 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8916 * xdisp.c (lookup_glyphless_char_display)
8917 (produce_glyphless_glyph): Handle cons cell entry in
8918 glyphless-char-display.
8919 (Vglyphless_char_display): Document it.
8921 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8922 glyphless-char-display.
8924 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8926 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8928 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8930 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8931 definition for no-X builds.
8933 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8935 Static checks with GCC 4.6.0 and non-default toolkits.
8937 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8939 * process.c (keyboard_bit_set): Define only if SIGIO.
8940 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8941 (send_process): Repair possible setjmp clobbering.
8943 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8945 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8947 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8949 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8950 Define only if needed.
8952 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8953 by pacifying GCC about it. Maybe it's time to retire it?
8954 * xfaces.c (USG, __TIMEVAL__): Likewise.
8956 * dispextern.h (struct redisplay_interface): Rename param
8958 * termhooks.h (struct terminal): Likewise.
8959 * xterm.c (xembed_send_message): Likewise.
8961 * insdel.c (make_gap_smaller): Define only if
8962 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8964 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8967 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8968 so that we aren't warned about unused symbols.
8970 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8972 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8974 * xfns.c (x_real_positions): Mark locals as initialized.
8976 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8978 * xterm.c: Fix problems found by static analysis with other toolkits.
8979 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8980 (x_dispatch_event): Declare static if USE_GTK, and
8981 define if USE_GTK || USE_X_TOOLKIT.
8982 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8983 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8984 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8985 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8987 * xmenu.c (menu_help_callback): Pointer type fixes.
8988 Use const pointers when pointing at readonly data. Avoid pointer
8990 (FALSE): Remove unused macro.
8991 (update_frame_menubar): Remove unused decl.
8993 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8995 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8996 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8997 (single_menu_item): Rename local to avoid shadowing.
8999 * keyboard.c (make_lispy_event): Remove unused local var.
9001 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9002 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9004 * bitmaps: Change bitmaps from unsigned char back to the X11
9005 compatible char. Avoid the old compiler warnings about
9006 out-of-range initializers by using, for example, '\xab' rather
9009 * xgselect.c (xgselect_initialize): Check vs interface
9010 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9012 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9014 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9015 to read-only memory.
9017 * fns.c (vector): Remove; this old hack is no longer needed.
9019 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9021 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9023 * xrdb.c (x_load_resources): Omit unused local.
9025 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9026 (x_window): Rename locals to avoid shadowing.
9027 (USG): Use the kludged USG macro, to pacify gcc.
9029 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9030 (x_term_init): Remove local to avoid shadowing.
9032 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9034 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9035 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9037 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9039 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9041 Fix regex.c, syntax.c and friends for buffers > 2GB.
9042 * syntax.h (struct gl_state_s): Declare character position members
9045 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9047 * textprop.c (verify_interval_modification, interval_of):
9048 Declare arguments EMACS_INT.
9050 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9053 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9055 * indent.c (Fvertical_motion): Local variable it_start is now
9058 * regex.c (re_match, re_match_2, re_match_2_internal)
9059 (bcmp_translate, regcomp, regexec, print_double_string)
9060 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9061 (re_compile_pattern, re_exec): Declare arguments and local
9062 variables `size_t' and `ssize_t' and return values `regoff_t', as
9064 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9065 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9066 <compile_stack_type>: `size' and `avail' are now `size_t'.
9068 * regex.h <regoff_t>: Use ssize_t, not int.
9069 (re_search, re_search_2, re_match, re_match_2): Arguments that
9070 specify buffer/string position and length are now ssize_t and
9071 size_t. Return type is regoff_t.
9073 2011-04-16 Ben Key <bkey76@gmail.com>
9075 * nsfont.m: Fixed bugs in ns_get_family and
9076 ns_descriptor_to_entity that were caused by using free to
9077 deallocate memory blocks that were allocated by xmalloc (via
9078 xstrdup). This caused Emacs to crash when compiled with
9079 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9080 --enable-checking=xmallocoverrun). xfree is now used to
9081 deallocate these memory blocks.
9083 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9085 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9087 emacs_write: Accept and return EMACS_INT for sizes.
9088 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9090 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9091 Accept and return EMACS_INT.
9092 (emacs_gnutls_write): Return the number of bytes written on
9094 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9095 (emacs_read, emacs_write): Remove check for negative size, as the
9096 Emacs source code has been audited now.
9097 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9098 (emacs_read, emacs_write): Use it.
9099 * process.c (send_process): Adjust to the new signatures of
9100 emacs_write and emacs_gnutls_write. Do not attempt to store
9101 a byte offset into an 'int'; it might overflow.
9102 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9104 * sound.c: Don't assume sizes fit in 'int'.
9105 (struct sound_device.period_size, alsa_period_size):
9106 Return EMACS_INT, not int.
9107 (struct sound_device.write, vox_write, alsa_write):
9108 Accept EMACS_INT, not int.
9109 (wav_play, au_play): Use EMACS_INT to store sizes and to
9110 record read return values.
9112 2011-04-15 Ben Key <bkey76@gmail.com>
9114 * keyboard.c (Qundefined): Don't declare static since it is used
9116 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9117 static since they are used in nsfont.m.
9119 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9121 * process.c (Qprocessp): Don't declare static.
9122 * lisp.h (Qprocessp): Declare again.
9124 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9126 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9128 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9130 Improve C-level modularity by making more things 'static'.
9132 Don't publish debugger-only interfaces to other modules.
9133 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9134 (verify_bytepos, count_markers): Move decls to the only modules
9136 * region-cache.h (pp_cache): Likewise.
9137 * window.h (check_all_windows): Likewise.
9138 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9140 * sysdep.c (croak): Now static, if
9141 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9142 * syssignal.h (croak): Declare only if not static.
9144 * alloc.c (refill_memory_reserve): Now static if
9145 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9146 * lisp.h (refill_memory_reserve): Declare only if not static.
9148 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9149 Define only if USE_LUCID.
9151 * xrdb.c (x_customization_string, x_rm_string): Now static.
9153 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9154 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9156 * xdisp.c (draw_row_with_mouse_face): Now static.
9157 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9159 * window.h (check_all_windows): Mark externally visible.
9161 * window.c (window_deletion_count): Now static.
9163 * undo.c: Make symbols static if they're not exported.
9164 (last_undo_buffer, last_boundary_position, pending_boundary):
9167 * textprop.c (interval_insert_behind_hooks): Now static.
9168 (interval_insert_in_front_hooks): Likewise.
9170 * term.c: Make symbols static if they're not exported.
9171 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9172 (max_frame_lines, tty_set_terminal_modes):
9173 (tty_reset_terminal_modes, tty_turn_off_highlight):
9174 (get_tty_terminal): Now static.
9175 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9176 * termhooks.h (term_mouse_moveto): Do not declare if
9178 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9179 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9181 * sysdep.c: Make symbols static if they're not exported.
9182 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9184 (sigprocmask_set, full_mask): Remove; unused.
9185 (wait_debugging): Mark as visible.
9186 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9187 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9189 * syntax.c (syntax_temp): Define only if !__GNUC__.
9191 * sound.c (current_sound_device, current_sound): Now static.
9193 * search.c (searchbufs, searchbuf_head): Now static.
9195 * scroll.c (scroll_cost): Remove; unused.
9196 * dispextern.h (scroll_cost): Remove decl.
9198 * region-cache.h (pp_cache): Mark as externally visible.
9200 * process.c: Make symbols static if they're not exported.
9201 (process_tick, update_tick, create_process, chan_process):
9202 (Vprocess_alist, proc_buffered_char, datagram_access):
9203 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9204 (deactivate_process): Mark defn as static, as well as decl.
9205 * lisp.h (create_process): Remove decl.
9206 * process.h (chan_process, Vprocess_alist): Remove decls.
9208 * print.c: Make symbols static if they're not exported.
9209 (print_depth, new_backquote_output, being_printed, print_buffer):
9210 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9211 (print_interval, print_number_index, initial_stderr_stream):
9213 * lisp.h (Fprinc): Remove decl.
9214 (debug_output_compilation_hack): Mark as externally visible.
9216 * sysdep.c (croak): Move decl from here to syssignal.h.
9217 * syssignal.h (croak): Put it here, so the API can be checked when
9218 'croak' is called from dissociate_if_controlling_tty.
9220 * minibuf.c: Make symbols static if they're not exported.
9221 (minibuf_save_list, choose_minibuf_frame): Now static.
9222 * lisp.h (choose_minibuf_frame): Remove decl.
9224 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9226 * lread.c: Make symbols static if they're not exported.
9227 (read_objects, initial_obarray, oblookup_last_bucket_number):
9229 (make_symbol): Remove; unused.
9230 * lisp.h (initial_obarray, make_symbol): Remove decls.
9232 * keyboard.c: Make symbols static if they're not exported.
9233 (single_kboard, recent_keys_index, total_keys, recent_keys):
9234 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9235 (this_single_command_key_start, echoing, last_auto_save):
9236 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9237 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9238 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9239 (Vlispy_mouse_stem, double_click_count):
9241 (force_auto_save_soon): Define only if SIGDANGER.
9242 (ignore_mouse_drag_p): Now static if
9243 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9244 (print_help): Remove; unused.
9245 (stop_character, last_timer_event): Mark as externally visible.
9246 * keyboard.h (ignore_mouse_drag_p): Declare only if
9247 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9248 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9249 * lisp.h (echoing): Remove decl.
9250 (force_auto_save_soon): Declare only if SIGDANGER.
9251 * xdisp.c (redisplay_window): Simplify code, to make it more
9252 obvious that ignore_mouse_drag_p is not accessed if !defined
9253 USE_GTK && !defined HAVE_NS.
9255 * intervals.c: Make symbols static if they're not exported.
9256 (merge_properties_sticky, merge_interval_right, delete_interval):
9258 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9260 * insdel.c: Make symbols static if they're not exported.
9261 However, leave prepare_to_modify_buffer alone. It's never
9262 called from outside this function, but that appears to be a bug.
9263 (combine_after_change_list, combine_after_change_buffer):
9264 (adjust_after_replace, signal_before_change): Now static.
9265 (adjust_after_replace_noundo): Remove; unused.
9266 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9267 (signal_before_change): Remove decls.
9269 * indent.c (val_compute_motion, val_vmotion): Now static.
9271 * image.c: Make symbols static if they're not exported.
9272 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9274 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9275 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9277 * fringe.c (standard_bitmaps): Now static.
9278 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9280 * frame.c: Make symbols static if they're not exported.
9281 (x_report_frame_params, make_terminal_frame): Now static.
9282 (get_frame_param): Now static, unless HAVE_NS.
9283 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9284 (x_get_resource_string): Remove; not used.
9285 * frame.h (make_terminal_frame, x_report_frame_params):
9286 (x_get_resource_string); Remove decls.
9287 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9288 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9290 * font.c, fontset.c: Make symbols static if they're not exported.
9291 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9292 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9293 * font.c (font_close_object): Now static.
9294 * font.h (font_close_object): Remove.
9295 * fontset.c (FONTSET_OBJLIST): Remove.
9296 (free_realized_fontset) #if-0 the body, which does nothing.
9297 (face_suitable_for_char_p): #if-0, as it's never called.
9298 * fontset.h (face_suitable_for_char_p): Remove decl.
9299 * xfaces.c (face_at_string_position):
9300 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9301 since 0 is always ASCII.
9303 * fns.c (weak_hash_tables): Now static.
9305 * fileio.c: Make symbols static if they're not exported.
9306 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9307 (Vwrite_region_annotation_buffers): Now static.
9309 * eval.c: Make symbols static if they're not exported.
9310 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9311 * lisp.h (backtrace_list): Remove decl.
9313 * emacs.c: Make symbols static if they're not exported.
9314 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9315 (fatal_error_code, fatal_error_signal_hook, standard_args):
9317 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9318 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9319 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9320 * lisp.h (fatal_error_signal_hook): Remove decl.
9321 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9323 * editfns.c: Move a (normally-unused) function to its only use.
9324 * editfns.c, lisp.h (get_operating_system_release): Remove.
9325 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9326 worth the hassle of breaking this out.
9328 * xterm.c: Make symbols static if they're not exported.
9329 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9330 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9331 (x_destroy_window, x_delete_display):
9333 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9334 (x_mouse_leave): Remove; unused.
9335 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9336 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9337 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9339 (x_mouse_leave): Declare only if WINDOWSNT.
9340 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9341 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9344 * ftxfont.c: Make symbols static if they're not exported.
9345 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9347 * font.h (ftxfont_driver): Likewise.
9349 * xfns.c: Make symbols static if they're not exported.
9350 (x_last_font_name, x_display_info_for_name):
9351 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9352 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9353 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9354 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9355 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9356 (last_show_tip_args): Now static.
9357 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9358 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9359 (x_screen_planes): Remove; unused.
9360 * dispextern.h (x_screen_planes): Remove decl.
9362 * dispnew.c: Make symbols static if they're not exported.
9363 * dispextern.h (redraw_garbaged_frames, scrolling):
9364 (increment_row_positions): Remove.
9365 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9366 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9368 (redraw_garbaged_frames): Remove; unused.
9370 * xfaces.c: Make symbols static if they're not exported.
9371 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9373 * xterm.h (defined_color): Remove decls.
9374 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9375 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9376 (menu_face_changed_default, defined_color, free_realized_face):
9377 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9378 (ascii_face_of_lisp_face): Remove; unused.
9380 * xdisp.c: Make symbols static if they're not exported.
9381 * dispextern.h (scratch_glyph_row, window_box_edges):
9382 (glyph_to_pixel_coords, set_cursor_from_row):
9383 (get_next_display_element, set_iterator_to_next):
9384 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9385 (show_mouse_face): Remove decls
9386 * frame.h (message_buf_print): Likewise.
9387 * lisp.h (pop_message, set_message, check_point_in_composition):
9389 * xterm.h (set_vertical_scroll_bar): Likewise.
9390 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9391 (message_buf_print, scratch_glyph_row, displayed_buffer):
9392 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9393 (get_next_display_element, show_mouse_face, window_box_edges):
9394 (frame_to_window_pixel_xy, check_point_in_composition):
9395 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9396 (glyph_to_pixel_coords): Remove; unused.
9398 * dired.c (file_name_completion): Now static.
9400 * dbusbind.c (xd_in_read_queued_messages): Now static.
9402 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9403 * data.c (circular_list_error): Remove.
9405 * commands.h (last_point_position, last_point_position_buffer):
9406 (last_point_position_window): Remove decls.
9407 * keyboard.c: Make these variables static.
9409 * coding.h (coding, code_convert_region, encode_coding_gap):
9411 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9412 (iso_code_class, detect_coding, code_convert_region): Now static.
9413 (encode_coding_gap): Remove; unused.
9415 * chartab.c (chartab_chars, chartab_bits): Now static.
9417 * charset.h (charset_iso_8859_1): Remove decl.
9418 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9421 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9422 * ccl.c (Vccl_program_table): Now static.
9423 (check_ccl_update): Remove; unused.
9425 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9426 * category.h: ... from here.
9427 * category.c (check_category_table, set_category_set): Now static.
9429 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9430 * lisp.h: Remove these decls.
9432 * buffer.c (buffer_count): Remove unused var.
9434 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9435 so that it's not optimized away.
9436 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9437 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9438 exported only to the debugger.
9440 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9441 * atimer.h (run_all_atimers): Remove; not exported.
9443 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9444 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9445 was inaccessible from Lisp.
9446 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9447 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9449 alloc.c: Import and export fewer symbols, and remove unused items.
9450 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9452 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9453 it's not optimized away by whole-program optimization.
9454 (message_enable_multibyte, free_misc): Remove.
9455 (catchlist, handlerlist, mark_backtrace):
9456 Declare only if BYTE_MARK_STACK.
9457 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9458 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9459 (message_enable_multibyte): Remove decl.
9460 (free_misc, interval_free_list, float_block, float_block_index):
9461 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9462 (cons_free_list, last_marked_index):
9464 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9465 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9466 (mark_backtrace): Define only if BYTE_MARK_STACK.
9467 * xdisp.c (message_enable_multibyte): Now static.
9469 Declare Lisp_Object Q* variables to be 'static' if not exported.
9470 This makes it easier for human readers (and static analyzers)
9471 to see whether these variables are used from other modules.
9472 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9473 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9474 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9475 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9476 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9477 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9478 * xmenu.c, xselect.c:
9479 Declare Q* vars static if they are not used in other modules.
9480 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9481 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9482 Remove decls of unexported vars.
9483 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9485 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9487 Make Emacs functions such as Fatom 'static' by default.
9488 This makes it easier for human readers (and static analyzers)
9489 to see whether these functions can be called from other modules.
9490 DEFUN now defines a static function. To make the function external
9491 so that it can be used in other C modules, use the new macro DEFUE.
9492 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9493 (Finit_image_library):
9494 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9495 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9496 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9497 Remove decls, since these functions are now static.
9498 (Funintern, Fget_internal_run_time): New decls, since these functions
9499 were already external.
9501 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9502 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9503 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9504 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9505 * keyboard.c, keymap.c, lread.c:
9506 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9507 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9508 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9509 Mark functions with DEFUE instead of DEFUN,
9510 if they are used in other modules.
9511 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9512 decls for now-static functions.
9513 * buffer.h (Fdelete_overlay): Remove decl.
9514 * callproc.c (Fgetenv_internal): Mark as internal.
9515 * composite.c (Fremove_list_of_text_properties): Remove decl.
9516 (Fcomposition_get_gstring): New forward static decl.
9517 * composite.h (Fcomposite_get_gstring): Remove decl.
9518 * dired.c (Ffile_attributes): New forward static decl.
9519 * doc.c (Fdocumntation_property): New forward static decl.
9520 * eval.c (Ffetch_bytecode): New forward static decl.
9521 (Funintern): Remove extern decl; now in .h file where it belongs.
9522 * fileio.c (Fmake_symbolic_link): New forward static decl.
9523 * image.c (Finit_image_library): New forward static decl.
9524 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9525 * intervals.h (Fprevious_property_change):
9526 (Fremove_list_of_text_properties): Remove decls.
9527 * keyboard.c (Fthis_command_keys): Remove decl.
9528 (Fcommand_execute): New forward static decl.
9529 * keymap.c (Flookup_key): New forward static decl.
9530 (Fcopy_keymap): Now static.
9531 * keymap.h (Flookup_key): Remove decl.
9532 * process.c (Fget_process): New forward static decl.
9533 (Fprocess_datagram_address): Mark as internal.
9534 * syntax.c (Fsyntax_table_p): New forward static decl.
9535 (skip_chars): Remove duplicate decl.
9536 * textprop.c (Fprevious_property_change): New forward static decl.
9537 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9539 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9540 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9542 * editfns.c (Fformat): Remove unreachable code.
9544 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9546 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9549 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9551 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9552 when at ZV. (Bug#8487)
9554 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9556 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9558 * keyboard.c (parse_tool_bar_item): Likewise.
9559 * sound.c (sound_cleanup, alsa_close): Likewise.
9560 * termcap.c (tgetent): Likewise.
9561 * xfns.c (x_default_font_parameter): Likewise.
9562 * xsettings.c (read_and_apply_settings): Likewise.
9564 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9565 (overrun_check_free): Protoize.
9567 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9569 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9570 since callers should never pass a negative size.
9571 Change the signature to match that of plain 'read' and 'write'; see
9572 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9573 * lisp.h: Update prototypes of emacs_write and emacs_read.
9575 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9577 * xdisp.c (redisplay_window): Don't try to determine the character
9578 position of the scroll margin if the window start point w->startp
9579 is outside the buffer's accessible region. (Bug#8468)
9581 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9583 Fix write-region and its subroutines for buffers > 2GB.
9584 * fileio.c (a_write, e_write): Modify declaration of arguments and
9585 local variables to support buffers larger than 2GB.
9586 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9588 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9589 argument, local variables, and return value.
9591 * lisp.h: Update prototypes of emacs_write and emacs_read.
9593 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9595 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9597 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9599 Fix more problems found by GCC 4.6.0's static checks.
9601 * xdisp.c (vmessage): Use a better test for character truncation.
9603 * charset.c (load_charset_map): <, not <=, for optimization,
9604 and to avoid potential problems with integer overflow.
9605 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9606 * casetab.c (set_identity, shuffle): Likewise.
9607 * editfns.c (Fformat): Likewise.
9608 * syntax.c (skip_chars): Likewise.
9610 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9611 This also lets GCC 4.6.0 generate slightly better loop code.
9613 * callint.c (Fcall_interactively): <, not <=, for optimization.
9614 (Fcall_interactively): Count the number of arguments produced,
9615 not the number of arguments given. This is simpler and lets GCC
9616 4.6.0 generate slightly better code.
9618 * ftfont.c: Distingish more carefully between FcChar8 and char.
9619 The previous code passed unsigned char * to a functions like
9620 strlen and xstrcasecmp that expect char *, which does not
9621 conform to the C standard.
9622 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9623 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9624 char * when the C standard requires it.
9626 * keyboard.c (read_char): Remove unused var.
9628 * eval.c: Port to Windows vsnprintf (Bug#8435).
9630 (SIZE_MAX): Define if the headers do not.
9631 (verror): Do not give up if vsnprintf returns a negative count.
9632 Instead, grow the buffer. This ports to Windows vsnprintf, which
9633 does not conform to C99. Problem reported by Eli Zaretskii.
9634 Also, simplify the allocation scheme, by avoiding the need for
9635 calling realloc, and removing the ALLOCATED variable.
9637 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9639 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9640 But keep the doprint source code for now, as we might revamp it
9641 and use it again (Bug#8435).
9642 * lisp.h (doprnt): Remove.
9643 * Makefile.in (base_obj): Remove doprnt.o.
9644 * deps.mk (doprnt.o): Remove.
9646 error: Print 32- and 64-bit integers portably (Bug#8435).
9647 Without this change, on typical 64-bit hosts error ("...%d...", N)
9648 was used to print both 32- and 64-bit integers N, which relied on
9650 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9651 * lisp.h (error, verror): Mark as printf-like functions.
9652 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9653 Report overflow in size calculations when allocating printf buffer.
9654 Do not truncate output string at its first null byte.
9655 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9656 Truncate the output at a character boundary, since vsnprintf does not
9658 * charset.c (check_iso_charset_parameter): Convert internal
9659 character to string before calling 'error', since %c now has the
9661 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9662 overflow when computing char to be passed to 'error'. Do not
9663 pass Lisp_Object to 'error'; pass the integer instead.
9664 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9665 formatted with plain %d.
9667 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9669 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9671 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9673 * xterm.c (x_catch_errors): Remove duplicate declaration.
9675 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9677 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9679 2011-04-10 Jim Meyering <meyering@redhat.com>
9681 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9682 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9683 return ssize_t not "int", and use size_t as the buffer length.
9684 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9685 * gnutls.h: Update declarations.
9686 * process.c (read_process_output): Use ssize_t, to match.
9687 (send_process): Likewise.
9689 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9691 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9693 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9695 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9696 Use unsigned char, to match FcChar8 type definition.
9698 * xterm.c (handle_one_xevent):
9699 * xmenu.c (create_and_show_popup_menu):
9700 * xselect.c (x_decline_selection_request)
9701 (x_reply_selection_request): Avoid type-punned deref of X events.
9703 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9705 Fix some uses of `int' instead of EMACS_INT.
9706 * search.c (string_match_1, fast_string_match)
9707 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9708 (scan_buffer, find_next_newline_no_quit)
9709 (find_before_next_newline, search_command, Freplace_match)
9710 (Fmatch_data): Make some `int' variables be EMACS_INT.
9712 * xdisp.c (display_count_lines): 3rd argument and return value now
9713 EMACS_INT. All callers changed.
9714 (pint2hrstr): Last argument is now EMACS_INT.
9716 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9717 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9718 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9719 (decode_coding_utf_16, decode_coding_emacs_mule)
9720 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9721 (decode_coding_ccl, decode_coding_charset)
9722 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9723 (decode_coding_iso_2022, decode_coding_emacs_mule)
9724 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9725 <char_offset, last_offset>: Declare EMACS_INT.
9726 (encode_coding_utf_8, encode_coding_utf_16)
9727 (encode_coding_emacs_mule, encode_invocation_designation)
9728 (encode_designation_at_bol, encode_coding_iso_2022)
9729 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9730 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9732 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9733 (encode_invocation_designation): Last argument P_NCHARS is now
9735 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9736 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9738 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9741 * ccl.c (Fccl_execute_on_string): Declare some variables
9744 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9746 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9748 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9750 * process.c (Fformat_network_address): Doc fix.
9752 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9754 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9756 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9758 * keyboard.c (read_char): Call Lisp function help-form-show,
9759 instead of using internal_with_output_to_temp_buffer.
9760 (Qhelp_form_show): New var.
9761 (syms_of_keyboard): Use DEFSYM macro.
9763 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9765 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9767 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9769 * process.c (Flist_processes): Remove to Lisp.
9770 (list_processes_1): Delete.
9772 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9774 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9776 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9778 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9780 Fix more problems found by GCC 4.6.0's static checks.
9782 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9784 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9786 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9788 * xdisp.c (vmessage): Mark as a printf-like function.
9790 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9792 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9794 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9795 printf-like functions.
9796 (tiff_load): Add casts to remove these marks before passing them
9797 to system-supplied API.
9799 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9801 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9802 This avoids several warnings with gcc -Wstrict-overflow.
9803 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9804 directly, rather than having caller test rule sign. This avoids
9805 some unnecessary tests.
9806 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9807 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9808 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9810 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9811 (xfont_open): Avoid unnecessary tests.
9813 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9815 * composite.h, composite.c (composition_gstring_put_cache):
9816 Use EMACS_INT, not int, for length.
9818 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9819 breaking out part of COMPOSITION_DECODE_RULE.
9820 (COMPOSITION_DECODE_RULE): Use it.
9821 * composite.c (get_composition_id): Remove unused local vars,
9822 by using the new macro.
9824 * textprop.c (set_text_properties_1): Change while to do-while,
9825 since the condition is always true at first.
9827 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9828 (interval_deletion_adjustment): Return unsigned value.
9831 * process.c (list_processes_1, create_pty, read_process_output):
9832 (exec_sentinel): Remove vars that were set but not used.
9833 (create_pty): Remove unnecessary "volatile"s.
9834 (Fnetwork_interface_info): Avoid possibility of int overflow.
9835 (read_process_output): Do adaptive read buffering even if carryover.
9836 (read_process_output): Simplify nbytes computation if buffered.
9838 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9840 * syntax.c (scan_words): Remove var that was set but not used.
9841 (update_syntax_table): Use unsigned instead of int.
9843 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9844 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9845 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9847 * print.c (print_error_message): Avoid int overflow.
9849 * font.c (font_list_entities): Redo for clarity,
9850 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9852 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9853 (font_score): Avoid potential overflow in diff calculation.
9855 * fns.c (substring_both): Remove var that is set but not used.
9856 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9858 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9860 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9861 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9862 can always succeed if overflow has undefined behavior.
9864 * search.c (boyer_moore, wordify): Remove vars set but not used.
9865 (wordify): Omit three unnecessary tests.
9867 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9868 All callers changed. This avoids the need for an unused var.
9870 * casefiddle.c (casify_region): Remove var that is set but not used.
9872 * dired.c (file_name_completion): Remove var that is set but not used.
9874 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9876 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9877 (Finsert_file_contents): Remove unnecessary code checking fd.
9879 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9880 Check for integer overflow on size calculations.
9882 * buffer.c (Fprevious_overlay_change): Remove var that is set
9885 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9886 Remove vars that are set but not used.
9887 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9888 (timer_check_2): Mark vars as initialized.
9890 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9892 * image.c (lookup_image): Remove var that is set but not used.
9893 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9895 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9896 that are set but not used.
9898 * xfns.c (make_invisible_cursor): Don't return garbage
9899 if XCreateBitmapFromData fails (Bug#8410).
9901 * xselect.c (x_get_local_selection, x_handle_property_notify):
9902 Remove vars that are set but not used.
9904 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9905 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9907 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9908 Remove var that is set but not used.
9909 (scroll_bar_windows_size): Now size_t, not int.
9910 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9913 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9914 (map_tty_color) [!defined MSDOS]: Likewise.
9916 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9918 * coding.c: Remove vars that are set but not used.
9919 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9920 All callers changed.
9921 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9922 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9923 (decode_coding_charset): Remove vars that are set but not used.
9925 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9926 that is set but not used.
9928 * print.c (print_object): Remove var that is set but not used.
9930 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9931 The gnulib version avoids calling malloc in the usual case,
9932 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9933 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9934 * filelock.c (current_lock_owner): Likewise.
9935 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9936 * sysdep.c: Include allocator.h, careadlinkat.h.
9937 (emacs_no_realloc_allocator): New static constant.
9938 (emacs_readlink): New function.
9939 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9940 ../lib/careadlinkat.h.
9942 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9944 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9945 first non-nil return value).
9947 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9949 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9950 if not defined (Bug#8403).
9952 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9954 * xdisp.c (display_count_lines): Remove parameter `start',
9955 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9956 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9957 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9958 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9959 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9960 and thereabouts. All callers changed.
9961 (get_per_char_metric): Remove parameter `f', unused since
9962 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9964 2011-04-02 Jim Meyering <meyering@redhat.com>
9966 do not dereference NULL upon failed strdup
9967 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9968 (ns_get_family): Likewise.
9970 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9972 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9974 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9976 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9979 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9981 Add lexical binding.
9983 * window.c (Ftemp_output_buffer_show): New fun.
9984 (Fsave_window_excursion):
9985 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9987 * lread.c (lisp_file_lexically_bound_p): New function.
9988 (Fload): Bind Qlexical_binding.
9989 (readevalloop): Remove `evalfun' arg.
9990 Bind Qinternal_interpreter_environment.
9991 (Feval_buffer): Bind Qlexical_binding.
9992 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9994 (syms_of_lread): Declare `lexical-binding'.
9996 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9998 * keyboard.c (eval_dyn): New fun.
9999 (menu_item_eval_property): Use it.
10001 * image.c (parse_image_spec): Use Ffunctionp.
10003 * fns.c (concat, mapcar1): Accept byte-code-functions.
10005 * eval.c (Fsetq): Handle lexical vars.
10006 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10007 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10008 (FletX, Flet): Obey lexical binding.
10009 (Fcommandp): Handle closures.
10010 (Feval): New `lexical' arg.
10011 (eval_sub): New function extracted from Feval. Use it almost
10012 everywhere where Feval was used. Look up vars in lexical env.
10014 (Ffunctionp): Move from subr.el.
10015 (Ffuncall): Handle closures.
10016 (apply_lambda): Remove `eval_flags'.
10017 (funcall_lambda): Handle closures and new byte-code-functions.
10018 (Fspecial_variable_p): New function.
10019 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10020 but without exporting it to Lisp.
10022 * doc.c (Fdocumentation, store_function_docstring):
10023 * data.c (Finteractive_form): Handle closures.
10025 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10028 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10030 (exec_byte_code): New function extracted from Fbyte_code to handle new
10031 calling convention for byte-code-functions. Add new byte-codes.
10033 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10035 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10037 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10039 * xdisp.c (redisplay_internal): Fix prototype.
10041 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10043 * xdisp.c (SCROLL_LIMIT): New macro.
10044 (try_scrolling): Use it when setting scroll_limit.
10045 Limit scrolling to 100 screen lines.
10046 (redisplay_window): Even when falling back on "recentering",
10047 position point in the window according to scroll-conservatively,
10048 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10050 (try_scrolling): When point is above the window, allow searching
10051 as far as scroll_max, or one screenful, to compute vertical
10052 distance from PT to the scroll margin position. This prevents
10053 try_scrolling from unnecessarily failing when
10054 scroll-conservatively is set to a value slightly larger than the
10055 window height. Clean up the case of PT below the margin at bottom
10056 of window: scroll_max can no longer be INT_MAX. When aggressive
10057 scrolling is in use, don't let point enter the opposite scroll
10058 margin as result of the scroll.
10059 (syms_of_xdisp) <scroll-conservatively>: Document the
10060 threshold of 100 lines for never-recentering scrolling.
10062 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10064 * dispextern.h (move_it_by_lines):
10065 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10066 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10067 (message_log_check_duplicate): Remove parameters `prev_bol' and
10068 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10069 (redisplay_internal): Remove parameter `preserve_echo_area',
10070 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10072 * indent.c (Fvertical_motion):
10073 * window.c (window_scroll_pixel_based, Frecenter):
10074 Don't pass `need_y_p' to `move_it_by_lines'.
10076 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10078 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10079 steal a few bits to be more compact.
10080 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10081 Remove unneeded casts.
10083 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10085 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10087 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10088 binding" message (bug#7967).
10090 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10092 Fix more problems found by GCC 4.6.0's static checks.
10094 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10095 Remove unused local var.
10097 * editfns.c (Fmessage_box): Remove unused local var.
10099 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10100 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10101 Omit unused local vars.
10102 * window.c (shrink_windows): Omit unused local var.
10103 * menu.c (digest_single_submenu): Omit unused local var.
10104 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10105 Omit unused local var.
10107 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10108 Don't assume string length fits in int.
10109 (keyremap_step, read_key_sequence): Use size_t for sizes.
10110 (read_key_sequence): Don't check last_real_key_start redundantly.
10112 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10113 instead of alloca (Bug#8344).
10115 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10116 (Fbacktrace_frame): Don't assume nframes fits in int.
10118 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10120 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10123 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10125 * cm.c (calccost): Turn while-do into do-while, for clarity.
10127 * keyboard.c (syms_of_keyboard): Use the same style as later
10128 in this function when indexing through an array. This also
10129 works around GCC bug 48267.
10131 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10133 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10135 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10136 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10138 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10139 This avoids undefined behavior on integer overflow, and is a bit
10140 more convenient anyway since it is compared to a size_t variable.
10142 Variadic C functions now count arguments with size_t, not int.
10143 This avoids an unnecessary limitation on 64-bit machines, which
10144 caused (substring ...) to crash on large vectors (Bug#8344).
10145 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10146 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10147 All variadic functions and their callers changed accordingly.
10148 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10149 * data.c (arith_driver, float_arith_driver): Likewise.
10150 * editfns.c (general_insert_function): Likewise.
10151 * eval.c (struct backtrace.nargs, interactive_p)
10152 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10153 (funcall_lambda, mark_backtrace): Likewise.
10154 * fns.c (concat): Likewise.
10155 * frame.c (x_set_frame_parameters): Likewise.
10156 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10157 0 if not found, not -1. All callers changed.
10159 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10160 (stack_copy_size): Now size_t, not int.
10161 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10163 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10165 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10166 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10167 All callers changed.
10169 * lisp.h (multibyte_char_to_unibyte):
10170 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10171 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10172 * character.h (CHAR_TO_BYTE8):
10173 * cmds.c (internal_self_insert):
10174 * editfns.c (general_insert_function):
10175 * keymap.c (push_key_description):
10176 * search.c (Freplace_match):
10177 * xdisp.c (message_dolog, set_message_1): All callers changed.
10179 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10181 * keyboard.c (safe_run_hook_funcall): New function.
10182 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10183 don't set the hook to nil, but remove the offending function instead.
10184 (Qcommand_hook_internal): Remove, unused.
10185 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10186 Vcommand_hook_internal.
10188 * eval.c (enum run_hooks_condition): Remove.
10189 (funcall_nil, funcall_not): New functions.
10190 (run_hook_with_args): Call each function through a `funcall' argument.
10191 Remove `cond' argument, now redundant.
10192 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10193 (Frun_hook_with_args_until_failure): Adjust accordingly.
10194 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10196 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10198 * dispextern.h (string_buffer_position): Remove declaration.
10200 * print.c (strout): Remove parameter `multibyte', unused since
10201 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10203 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10204 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10205 All callers changed.
10207 * w32.c (_wsa_errlist): Use braces for struct initializers.
10209 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10210 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10211 All callers changed.
10212 (string_buffer_position): Likewise. Also, make static (it's never
10213 used outside xdisp.c).
10214 (cursor_row_p): Remove parameter `w', unused since
10215 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10216 (decode_mode_spec): Remove parameter `precision', introduced during
10217 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10218 All callers changed.
10220 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10222 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10224 2011-03-27 Anders Lindgren <andlind@gmail.com>
10226 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10227 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10228 (ns_update_auto_hide_menu_bar): New functions.
10229 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10230 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10231 ns_constrain_all_frames.
10232 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10233 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10235 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10237 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10239 2011-03-27 Glenn Morris <rgm@gnu.org>
10241 * syssignal.h: Replace RETSIGTYPE with void.
10242 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10243 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10244 Replace SIGTYPE with void everywhere.
10245 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10246 * s/template.h (SIGTYPE): Remove commented out definition.
10248 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10250 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10251 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10253 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10255 * w32.c (read_unc_volume): Use parameter `henum', instead of
10256 global variable `wget_enum_handle'.
10258 * keymap.c (describe_vector): Remove parameters `indices' and
10259 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10260 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10262 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10264 * keyboard.c (timer_check): Remove parameter `do_it_now',
10265 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10266 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10267 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10269 * keyboard.c (read_char):
10270 * w32menu.c (w32_menu_display_help):
10271 * xmenu.c (show_help_event, menu_help_callback):
10272 Adjust calls to `show_help_echo'.
10274 * gtkutil.c (xg_maybe_add_timer):
10275 * keyboard.c (readable_events):
10276 * process.c (wait_reading_process_output):
10277 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10279 * insdel.c (adjust_markers_gap_motion):
10280 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10281 (gap_left, gap_right): Don't call it.
10283 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10285 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10286 incurred during fontification.
10288 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10290 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10291 (DEFVAR_PER_BUFFER): Don't pass it.
10293 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10294 (scrolling_window): Don't pass it.
10296 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10298 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10300 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10302 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10303 of variables specific to SELinux and computation of `encoded_absname'.
10305 * image.c (XPutPixel): Remove unused variable `height'.
10307 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10309 * unexw32.c (get_section_info): Remove unused variable `section'.
10311 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10312 (system_process_attributes): Remove unused variable `sess'.
10313 (sys_read): Remove unused variable `err'.
10315 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10316 (w32_wnd_proc): Remove unused variable `isdead'.
10317 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10318 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10319 (x_create_tip_frame): Remove unused variable `tem'.
10321 * w32inevt.c (w32_console_read_socket):
10322 Remove unused variable `no_events'.
10324 * w32term.c (x_draw_composite_glyph_string_foreground):
10325 Remove unused variable `width'.
10327 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10329 * w32term.c (x_set_glyph_string_clipping):
10330 Don't pass uninitialized region to CombineRgn.
10332 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10334 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10335 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10336 (Fx_close_connection): Remove unused variable `i'.
10338 * w32font.c (w32font_draw): Return number of glyphs.
10339 (w32font_open_internal): Remove unused variable `i'.
10340 (w32font_driver): Add missing initializer.
10342 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10343 (fill_in_menu): Remove unused variable `items_added'.
10345 * w32term.c (last_mouse_press_frame): Remove static global variable.
10346 (w32_clip_to_row): Remove unused variable `f'.
10347 (x_delete_terminal): Remove unused variable `i'.
10349 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10350 (NOTHING): Remove unused static global variable.
10351 (uniscribe_check_otf): Remove unused variable `table'.
10352 (uniscribe_font_driver): Add missing initializers.
10354 2011-03-23 Julien Danjou <julien@danjou.info>
10356 * term.c (Fsuspend_tty, Fresume_tty):
10357 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10358 * window.c (temp_output_buffer_show):
10359 * insdel.c (signal_before_change):
10360 * frame.c (Fhandle_switch_frame):
10361 * fileio.c (Fdo_auto_save):
10362 * emacs.c (Fkill_emacs):
10363 * editfns.c (save_excursion_restore):
10364 * cmds.c (internal_self_insert):
10365 * callint.c (Fcall_interactively):
10366 * buffer.c (Fkill_all_local_variables):
10367 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10369 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10370 unconditionally since it does the check itself.
10372 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10374 Fix more problems found by GCC 4.5.2's static checks.
10376 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10377 the first time through the loop, since we know p0 < p1 then.
10378 This also avoids a gcc -Wstrict-overflow warning.
10380 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10381 leading to a memory leak, possible in functions like
10382 load_charset_map_from_file that can allocate an unbounded number
10383 of objects (Bug#8318).
10385 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10386 that could (at least in theory) be that large.
10388 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10389 This is less likely to overflow, and avoids undefined behavior if
10390 overflow does occur. All callers changed. Use strtoul to scan
10391 for the unsigned long integer.
10392 (pint2hrstr): Simplify and tune code slightly.
10393 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10395 * scroll.c (do_scrolling): Work around GCC bug 48228.
10396 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10398 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10399 This also avoids a warning with gcc -Wstrict-overflow.
10400 (validate_x_resource_name): Simplify count usage.
10401 This also avoids a warning with gcc -Wstrict-overflow.
10403 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10406 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10408 * process.c (Fmake_network_process): Use socklen_t, not int,
10409 where POSIX says socklen_t is required in portable programs.
10410 This fixes a porting bug on hosts like 64-bit HP-UX, where
10411 socklen_t is wider than int (Bug#8277).
10412 (Fmake_network_process, server_accept_connection):
10413 (wait_reading_process_output, read_process_output):
10416 * process.c: Rename or move locals to avoid shadowing.
10417 (list_processes_1, Fmake_network_process):
10418 (read_process_output_error_handler, exec_sentinel_error_handler):
10419 Rename or move locals.
10420 (Fmake_network_process): Define label "retry_connect" only if needed.
10421 (Fnetwork_interface_info): Fix pointer signedness.
10422 (process_send_signal): Add cast to avoid pointer signedness problem.
10423 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10424 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10426 Make tparam.h and terminfo.c consistent.
10427 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10428 Include tparam.h instead, since it declares them.
10429 * cm.h (PC): Remove extern decl; tparam.h now does this.
10430 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10431 * terminfo.c: Include tparam.h, to check interfaces.
10432 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10433 (tparam): Adjust signature to match interface in tparam.h;
10434 this removes some undefined behavior. Check that outstring and len
10435 are zero, which they always are with Emacs.
10436 * tparam.h (PC, BC, UP): New extern decls.
10438 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10439 (xftfont_open): Rename locals to avoid shadowing.
10441 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10442 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10443 (OTF_TAG_SYM): Omit macro if not needed.
10444 (ftfont_list): Remove unused local.
10445 (get_adstyle_property, ftfont_pattern_entity):
10446 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10447 Rename locals to avoid shadowing.
10449 * xfont.c (xfont_list_family): Mark var as initialized.
10451 * xml.c (make_dom): Now static.
10453 * composite.c (composition_compute_stop_pos): Rename local to
10455 (composition_reseat_it): Remove unused locals.
10456 (find_automatic_composition, composition_adjust_point): Likewise.
10457 (composition_update_it): Mark var as initialized.
10458 (find_automatic_composition): Mark vars as initialized,
10459 with a FIXME (Bug#8290).
10461 character.h: Rename locals to avoid shadowing.
10462 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10463 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10464 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10465 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10466 to avoid shadowing.
10468 * textprop.c (property_change_between_p): Remove; unused.
10470 * intervals.c (interval_start_pos): Now static.
10472 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10474 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10475 Rename locals to avoid shadowing.
10477 * sound.c (wav_play, au_play, Fplay_sound_internal):
10478 Fix pointer signedness.
10479 (alsa_choose_format): Remove unused local var.
10480 (wav_play): Initialize a variable to 0, to prevent undefined
10481 behavior (Bug#8278).
10483 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10485 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10487 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10488 clobbering (Bug#8298).
10489 * sysdep.c (sys_subshell): Likewise.
10490 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10492 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10493 This should get cleaned up, so that child_setup has the
10494 same signature on all platforms.
10496 * callproc.c (call_process_cleanup): Now static.
10497 (relocate_fd): Rename locals to avoid shadowing.
10499 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10501 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10502 not to be necessary, and produces flickering.
10504 2011-03-20 Glenn Morris <rgm@gnu.org>
10506 * config.in: Remove file.
10508 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10510 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10511 are now in src/globals.h.
10512 (syms_of_minibuf): Remove spurious & from previous change.
10514 2011-03-20 Leo Liu <sdl.web@gmail.com>
10516 * minibuf.c (completing-read-function): New variable.
10517 (completing-read-default): Rename from completing-read.
10518 (completing-read): Call completing-read-function.
10520 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10522 * xfaces.c (Fx_load_color_file):
10523 Read color file from absolute filename (bug#8250).
10525 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10527 * makefile.w32-in: Update dependencies.
10529 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10531 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10533 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10535 Fix more problems found by GCC 4.5.2's static checks.
10537 * process.c (make_serial_process_unwind, send_process_trap):
10538 (sigchld_handler): Now static.
10540 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10541 That way, the code declares only the vars that it needs.
10542 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10543 * s/cygwin.h (PTY_ITERATION): Likewise.
10544 * s/darwin.h (PTY_ITERATION): Likewise.
10545 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10547 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10548 * process.c (allocate_pty): Don't declare stb unless it's needed.
10550 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10551 (CONSTANTLIM): Remove; unused.
10552 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10553 Define only if needed.
10555 * unexelf.c (unexec): Name an expression,
10556 to avoid gcc -Wbad-function-cast warning.
10557 Use a different way to cause a compilation error if anyone uses
10558 n rather than nn, a way that does not involve shadowing.
10559 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10561 * deps.mk (unexalpha.o): Remove; unused.
10563 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10564 * unexec.h: New file.
10565 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10566 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10567 Depend on unexec.h.
10568 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10569 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10570 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10571 Change as necessary to match prototype in unexec.h.
10573 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10575 (back_comment, skip_chars): Mark vars as initialized.
10577 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10578 Rename locals to avoid shadowing.
10580 * lread.c (read1): Rewrite so as not to use empty "else".
10581 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10583 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10585 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10586 warning when compiling print.c.
10588 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10589 instead of using an uninitialized var.
10590 (font_sort_entities): Mark var as initialized.
10592 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10594 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10595 pointers to constants.
10596 (font_parse_fcname): Remove unused vars.
10597 (font_delete_unmatched): Now static.
10598 (font_get_spec): Remove; unused.
10599 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10600 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10601 Rename or move locals to avoid shadowing.
10603 * fns.c (require_nesting_list, require_unwind): Now static.
10604 (Ffillarray): Rename locals to avoid shadowing.
10606 * floatfns.c (domain_error2): Define only if needed.
10607 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10609 * alloc.c (mark_backtrace): Move decl from here ...
10610 * lisp.h: ... to here, so that it can be checked.
10612 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10613 (Fdefvar): Rewrite so as not to use empty "else".
10614 (lisp_indirect_variable): Name an expression,
10615 to avoid gcc -Wbad-function-cast warning.
10616 (Fdefvar): Rename locals to avoid shadowing.
10618 * callint.c (quotify_arg, quotify_args): Now static.
10619 (Fcall_interactively): Rename locals to avoid shadowing.
10620 Use const pointer when appropriate.
10622 * lisp.h (get_system_name, get_operating_system_release):
10623 Move decls here, to check interfaces.
10624 * process.c (get_operating_system_release): Move decl to lisp.h.
10625 * xrdb.c (get_system_name): Likewise.
10626 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10627 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10628 some of which prompt warnings from gcc -Wbad-function-cast.
10629 (Fformat_time_string, Fencode_time, Finsert_char):
10630 (Ftranslate_region_internal, Fformat):
10631 Rename or remove local vars to avoid shadowing.
10632 (Ftranslate_region_internal): Mark var as initialized.
10634 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10637 * lisp.h (eassert): Check that the argument compiles, even if
10638 ENABLE_CHECKING is not defined.
10640 * data.c (Findirect_variable): Name an expression, to avoid
10641 gcc -Wbad-function-cast warning.
10642 (default_value, arithcompare, arith_driver, arith_error): Now static.
10643 (store_symval_forwarding): Rename local to avoid shadowing.
10644 (Fmake_variable_buffer_local, Fmake_local_variable):
10645 Mark variables as initialized.
10646 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10648 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10649 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10650 Rename locals to avoid shadowing.
10651 (mark_stack): Move local variables into the #ifdef region where
10653 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10654 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10656 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10657 (GC_STRING_CHARS): Remove; not used.
10658 (Fmemory_limit): Cast sbrk's returned value to char *.
10660 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10661 avoids undefined behavior in theory.
10663 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10665 Use functions, not macros, for up- and down-casing (Bug#8254).
10666 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10667 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10668 to use the following functions instead of these macros.
10669 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10670 EMACS_INT, since callers assume the returned value fits in int.
10671 (upcase1): Likewise, for UPCASE_TABLE.
10672 (uppercasep, lowercasep, upcase): New static inline functions.
10673 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10674 the race-condition problem in the old DOWNCASE.
10676 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10677 Rename locals to avoid shadowing.
10678 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10679 (regex_compile, re_search_2, re_match_2_internal):
10680 Remove unused local vars.
10681 (FREE_VAR): Rewrite so as not to use empty "else",
10682 which gcc can warn about.
10683 (regex_compile, re_match_2_internal): Mark locals as initialized.
10684 (RETALLOC_IF): Define only if needed.
10685 (WORDCHAR_P): Likewise. This one is never needed, but is used
10686 only in a comment talking about a compiler bug, so put inside
10687 the #if 0 of that comment.
10688 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10689 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10692 * search.c (boyer_moore): Rename locals to avoid shadowing.
10693 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10694 (PREV_CHAR_BOUNDARY): Likewise.
10696 * search.c (simple_search): Remove unused var.
10698 * dired.c (compile_pattern): Move decl from here ...
10699 * lisp.h: ... to here, so that it can be checked.
10700 (struct re_registers): New forward decl.
10702 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10704 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10706 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10707 Rename locals to avoid shadowing.
10708 (Fvertical_motion): Mark locals as initialized.
10710 * casefiddle.c (casify_object, casify_region): Now static.
10711 (casify_region): Mark local as initialized.
10713 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10715 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10716 New macros, so that the caller can use some names other than
10717 gcpro1, gcpro2, etc.
10718 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10720 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10721 argument, for consistency with GCPRO2_VAR, etc: it is now the
10722 prefix of the variable, not the variable itself. All uses
10724 * dired.c (directory_files_internal, file_name_completion):
10725 Rename locals to avoid shadowing.
10727 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10728 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10729 dired.c's scmp function, had undefined behavior.
10730 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10731 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10732 * buffer.h: ... to here, because these macros use current_buffer,
10733 and the new implementation with inline functions needs to have
10734 current_buffer in scope now, rather than later when the macros
10736 (downcase, upcase1): New static inline functions.
10737 (DOWNCASE, UPCASE1): Reimplement using these functions.
10738 This avoids undefined behavior in expressions like
10739 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10740 from race conditions in accessing the global variables
10741 case_temp1 and case_temp2.
10742 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10743 * lisp.h (case_temp1, case_temp2): Remove their decls.
10744 * character.h (ASCII_CHAR_P): Move from here ...
10745 * lisp.h: ... to here, so that the inline functions mentioned
10746 above can use them.
10748 * dired.c (directory_files_internal_unwind): Now static.
10750 * fileio.c (file_name_as_directory, directory_file_name):
10751 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10753 (file_name_as_directory): Use const pointers when appropriate.
10754 (Fexpand_file_name): Likewise. In particular, newdir might
10755 point at constant storage, so make it a const pointer.
10756 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10757 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10759 (Fset_file_times, Finsert_file_contents, auto_save_error):
10760 Rename locals to avoid shadowing.
10762 * minibuf.c (choose_minibuf_frame_1): Now static.
10763 (Ftry_completion, Fall_completions): Rename or remove locals
10764 to avoid shadowing.
10766 * marker.c (bytepos_to_charpos): Remove; unused.
10768 * lisp.h (verify_bytepos, count_markers): New decls,
10769 so that gcc does not warn that these functions aren't declared.
10771 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10772 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10773 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10774 (copy_text): Remove unused local var.
10776 * filelock.c (within_one_second): Now static.
10777 (lock_file_1): Rename local to avoid shadowing.
10779 * buffer.c (fix_overlays_before): Mark locals as initialized.
10780 (fix_start_end_in_overlays): Likewise. This function should be
10781 simplified by using pointers-to-pointers, but that's a different
10783 (switch_to_buffer_1): Now static.
10784 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10785 (report_overlay_modification): Rename locals to avoid shadowing.
10787 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10788 Fix pointer signedness issue.
10789 (sys_subshell): Mark local as volatile if checking for lint,
10790 to suppress a gcc -Wclobbered warning that does not seem to be right.
10791 (MAXPATHLEN): Define only if needed.
10793 * process.c (serial_open, serial_configure): Move decls from here ...
10794 * systty.h: ... to here, so that they can be checked.
10796 * fns.c (get_random, seed_random): Move extern decls from here ...
10797 * lisp.h: ... to here, so that they can be checked.
10799 * sysdep.c (reset_io): Now static.
10800 (wait_for_termination_signal): Remove; unused.
10802 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10803 (copy_keymap_item, append_key, push_text_char_description):
10805 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10806 (DENSE_TABLE_SIZE): Remove; unused.
10807 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10808 (describe_map_tree):
10809 Rename locals to avoid shadowing.
10811 * keyboard.c: Declare functions static if they are not used elsewhere.
10812 (echo_char, echo_dash, cmd_error, top_level_2):
10813 (poll_for_input, handle_async_input): Now static.
10814 (read_char, kbd_buffer_get_event, make_lispy_position):
10815 (make_lispy_event, make_lispy_movement, apply_modifiers):
10816 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10817 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10818 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10819 (read_key_sequence, read_char): Mark locals as initialized.
10820 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10822 * keyboard.h (make_ctrl_char): New decl.
10823 (mark_kboards): Move decl here ...
10824 * alloc.c (mark_kboards): ... from here.
10826 * lisp.h (force_auto_save_soon): New decl.
10828 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10829 (DEFINE_DUMMY_FUNCTION): New macro.
10830 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10832 (main): Add casts to avoid warnings
10833 if GCC considers string literals to be constants.
10835 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10837 * dbusbind.c: Pointer signedness fixes.
10838 (xd_signature, xd_append_arg, xd_initialize):
10839 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10840 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10841 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10842 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10844 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10845 if GCC considers string literals to be constants.
10846 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10848 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10850 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10851 (print_preprocess, print_object): New macro to fix last change.
10853 * print.c (print_preprocess): Don't forget font objects.
10855 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10857 * emacs.c (USAGE3): Doc fixes.
10859 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10861 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10864 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10866 * lisp.h (VWindow_system, Qfile_name_history):
10867 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10868 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10869 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10871 * w32select.c: Don't #include "keyboard.h".
10872 (run_protected): Add extern declaration for waiting_for_input.
10874 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10875 * w32console.c (detect_input_pending, read_input_pending)
10876 (encode_terminal_code):
10877 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10878 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10879 (w32_system_caret_y, Qfile_name_history):
10880 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10881 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10882 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10883 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10884 * w32proc.c (Qlocal, report_file_error):
10885 * w32term.c (Vwindow_system, updating_frame):
10886 * w32uniscribe.c (initialized, uniscribe_font_driver):
10887 Remove unneeded extern declarations.
10889 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10891 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10893 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10895 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10896 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10897 These macros can no longer be used for assignment.
10899 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10900 Assign struct members directly, instead of using BUF_BEGV etc.
10901 (record_buffer_markers, fetch_buffer_markers): New functions for
10902 recording and fetching special buffer markers.
10903 (set_buffer_internal_1, set_buffer_temp): Use them.
10905 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10907 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10909 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10910 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10912 * xdisp.c (hscroll_window_tree):
10913 (reconsider_clip_changes): Use PT instead of BUF_PT.
10915 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10917 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10918 $(EMACS_ROOT)/lib/intprops.h.
10920 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10922 Fix more problems found by GCC 4.5.2's static checks.
10924 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10925 to unsigned char * to avoid compiler diagnostic.
10926 (xg_free_frame_widgets): Make it clear that a local variable is
10927 needed only if USE_GTK_TOOLTIP.
10928 (gdk_window_get_screen): Make it clear that this macro is needed
10929 only if USE_GTK_TOOLTIP.
10930 (int_gtk_range_get_value): New function, which avoids a diagnostic
10931 from gcc -Wbad-function-cast.
10932 (xg_set_toolkit_scroll_bar_thumb): Use it.
10933 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10934 diagnostic from gcc -Wbad-function-cast.
10935 (get_utf8_string, xg_get_file_with_chooser):
10936 Rename locals to avoid shadowing.
10937 (create_dialog): Move locals to avoid shadowing.
10939 * xgselect.c (xg_select): Remove unused var.
10941 * image.c (four_corners_best): Mark locals as initialized.
10942 (gif_load): Initialize transparent_p to zero (Bug#8238).
10943 Mark another local as initialized.
10944 (my_png_error, my_error_exit): Mark with NO_RETURN.
10946 * image.c (clear_image_cache): Now static.
10947 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10948 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10949 (x_edge_detection): Remove unnecessary cast that
10950 gcc -Wbad-function-cast diagnoses.
10951 (gif_load): Fix pointer signedness.
10952 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10953 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10955 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10957 Improve quality of tests for time stamp overflow.
10958 For example, without this patch (encode-time 0 0 0 1 1
10959 1152921504606846976) returns the obviously-bogus value (-948597
10960 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10961 reports time overflow. See
10962 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10963 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10964 * editfns.c: Include limits.h and intprops.h.
10965 (TIME_T_MIN, TIME_T_MAX): New macros.
10966 (time_overflow): Move earlier, to before first use.
10967 (hi_time, lo_time): New functions, for an accurate test for
10968 out-of-range times.
10969 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10970 (Fget_internal_run_time): Don't assume time_t fits in int.
10971 (make_time): Use list2 instead of Fcons twice.
10972 (Fdecode_time): More accurate test for out-of-range times.
10973 (check_tm_member): New function.
10974 (Fencode_time): Use it, to test for out-of-range times.
10975 (lisp_time_argument): Don't rely on undefined left-shift and
10976 right-shift behavior when checking for time stamp overflow.
10978 * editfns.c (time_overflow): New function, refactoring common code.
10979 (Fformat_time_string, Fdecode_time, Fencode_time):
10980 (Fcurrent_time_string): Use it.
10982 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10983 * dired.c (make_time): Move to ...
10984 * editfns.c (make_time): ... here.
10985 * systime.h: Note the move.
10987 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10989 * fringe.c (update_window_fringes): Remove unused variables.
10991 * unexmacosx.c (copy_data_segment): Also copy __got section.
10994 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10996 * termcap.c [MSDOS]: Include "msdos.h".
10997 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10998 Constify `char *' arguments and their references according to
10999 prototypes in tparam.h.
11001 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11003 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11004 Adapt all references accordingly.
11006 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11008 2011-03-11 Tom Tromey <tromey@redhat.com>
11010 * buffer.c (syms_of_buffer): Remove obsolete comment.
11012 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11014 * termhooks.h (encode_terminal_code): Declare prototype.
11016 * msdos.c (encode_terminal_code): Don't declare prototype.
11018 * term.c (encode_terminal_code): Now external again, used by
11019 w32console.c and msdos.c.
11021 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11022 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11024 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11026 Fix some minor problems found by GCC 4.5.2's static checks.
11028 * fringe.c (update_window_fringes): Mark locals as initialized
11030 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11032 * alloc.c (mark_fringe_data): Move decl from here ...
11033 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11034 to check its interface.
11035 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11037 * fontset.c (free_realized_fontset): Now static.
11038 (Fset_fontset_font): Rename local to avoid shadowing.
11039 (fontset_font): Mark local as initialized.
11040 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11042 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11044 * xselect.c (x_disown_buffer_selections): Remove; not used.
11045 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11046 (x_own_selection, Fx_disown_selection_internal): Rename locals
11047 to avoid shadowing.
11048 (x_handle_dnd_message): Remove local to avoid shadowing.
11050 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11051 so that the caller can use some name other than gcpro1.
11052 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11053 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11054 (Fx_backspace_delete_keys_p):
11055 Use them to avoid shadowing, and rename vars to avoid shadowing.
11056 (x_decode_color, x_set_name, x_window): Now static.
11057 (Fx_create_frame): Add braces to silence GCC warning.
11058 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11059 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11060 Remove unused locals.
11061 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11062 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11063 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11066 * xterm.h (x_mouse_leave): New decl.
11068 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11069 Remove unused functions.
11070 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11071 (x_calc_absolute_position): Now static.
11072 (XTread_socket): Don't define label "out" unless it's used.
11073 Don't declare local "event" unless it's used.
11074 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11075 unless they are used.
11076 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11077 (x_fatal_error_signal): Remove; not used.
11078 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11079 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11080 (x_error_catcher, x_connection_closed, x_error_handler):
11081 (x_error_quitter, xembed_send_message, x_iconify_frame):
11082 (my_log_handler): Rename locals to avoid shadowing.
11083 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11084 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11086 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11087 Rename or move locals to avoid shadowing.
11088 (tty_defined_color, merge_face_heights): Now static.
11089 (free_realized_faces_for_fontset): Remove; not used.
11090 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11091 does not deduce is never used uninitialized.
11092 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11093 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11095 * terminal.c (store_terminal_param): Now static.
11097 * xmenu.c (menu_highlight_callback): Now static.
11098 (set_frame_menubar): Remove unused local.
11099 (xmenu_show): Rename parameter to avoid shadowing.
11100 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11101 since they might point to immutable storage.
11102 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11103 since it's unused otherwise.
11105 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11106 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11107 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11108 avoids a gcc -Wuninitialized diagnostic.
11109 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11110 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11111 does not deduce are never used uninitialized.
11113 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11115 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11116 * window.c (window_loop, size_window):
11117 (run_window_configuration_change_hook, enlarge_window): Likewise.
11119 * window.c (display_buffer): Now static.
11120 (size_window): Mark variables that gcc -Wuninitialized
11121 does not deduce are never used uninitialized.
11122 * window.h (check_all_windows): New decl, to forestall
11123 gcc -Wmissing-prototypes diagnostic.
11124 * dispextern.h (bidi_dump_cached_states): Likewise.
11126 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11128 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11129 Include <limits.h>.
11130 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11131 and to avoid gcc -Wuninitialized warning.
11132 (load_charset_map): Mark variables that gcc -Wuninitialized
11133 does not deduce are never used uninitialized.
11134 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11136 * coding.c (coding_set_source, coding_set_destination):
11137 Use "else { /* comment */ }" rather than "else /* comment */;"
11138 for clarity, and to avoid gcc -Wempty-body warning.
11139 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11140 a block, when the outer 'i' will do.
11141 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11142 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11143 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11144 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11145 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11146 Rename locals to avoid shadowing.
11147 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11148 * coding.c (emacs_mule_char, encode_invocation_designation):
11149 Now static, since they're not used elsewhere.
11150 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11151 (decode_coding_object, encode_coding_object, detect_coding_system):
11152 (decode_coding_emacs_mule): Mark variables that gcc
11153 -Wuninitialized does not deduce are never used uninitialized.
11154 (detect_coding_iso_2022): Initialize a local variable that might
11155 be used uninitialized. Leave a FIXME because it's not clear that
11156 this initialization is needed. (Bug#8211)
11157 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11158 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11159 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11160 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11161 Remove unused macros.
11163 * category.c (hash_get_category_set): Remove unused local var.
11164 (copy_category_table): Now static, since it's not used elsewhere.
11165 * character.c (string_count_byte8): Likewise.
11167 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11168 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11170 * chartab.c (copy_sub_char_table): Now static, since it's not used
11172 (sub_char_table_ref_and_range, char_table_ref_and_range):
11173 Rename locals to avoid shadowing.
11174 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11176 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11177 (BIDI_BOB): Remove unused macro.
11179 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11180 deduce are never used uninitialized.
11181 * term.c (encode_terminal_code): Likewise.
11183 * term.c (encode_terminal_code): Now static. Remove unused local.
11185 * tparam.h: New file.
11186 * term.c, tparam.h: Include it.
11187 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11188 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11189 Move these decls to tparam.h, and make them agree with what
11190 is actually in tparam.c. The previous trick of using incompatible
11191 decls in different modules does not conform to the C standard.
11192 All callers of tparam changed to use tparam's actual API.
11193 * tparam.c (tparam1, tparam, tgoto):
11194 Use const pointers where appropriate.
11196 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11197 * cm.h (struct cm): Likewise.
11198 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11199 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11200 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11201 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11202 (turn_on_face, init_tty): Likewise.
11203 * termchar.h (struct tty_display_info): Likewise.
11205 * term.c (term_mouse_position): Rename local to avoid shadowing.
11207 * alloc.c (mark_ttys): Move decl from here ...
11208 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11210 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11212 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11214 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11216 * search.c (compile_pattern_1): Remove argument regp, unused since
11217 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11218 (compile_pattern): Don't pass it.
11220 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11222 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11223 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11225 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11227 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11229 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11230 gdk_window_get_screen, gdk_window_get_geometry,
11231 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11232 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11233 (xg_get_pixbuf_from_pixmap): New function.
11234 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11235 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11236 Call xg_get_pixbuf_from_pixmap instead of
11237 gdk_pixbuf_get_from_drawable.
11238 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11239 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11240 (xg_check_special_colors): Use GtkStyleContext and its functions
11242 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11243 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11244 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11245 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11246 Call gtk_widget_get_preferred_size.
11247 (xg_frame_resized): gdk_window_get_geometry only takes 5
11249 (xg_win_to_widget, xg_event_is_for_menubar):
11250 Call gdk_x11_window_lookup_for_display.
11251 (xg_set_widget_bg): New function.
11252 (delete_cb): New function.
11253 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11254 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11255 (xg_set_background_color): Call xg_set_widget_bg.
11256 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11257 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11258 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11259 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11261 (update_frame_tool_bar): Call gtk_widget_hide.
11262 (xg_initialize): Use GDK_KEY_g.
11264 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11266 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11268 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11269 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11270 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11272 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11274 * w32xfns.c (select_palette): Check success of RealizePalette against
11275 GDI_ERROR, not zero.
11277 See ChangeLog.11 for earlier changes.
11279 ;; Local Variables:
11283 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11285 This file is part of GNU Emacs.
11287 GNU Emacs is free software: you can redistribute it and/or modify
11288 it under the terms of the GNU General Public License as published by
11289 the Free Software Foundation, either version 3 of the License, or
11290 (at your option) any later version.
11292 GNU Emacs is distributed in the hope that it will be useful,
11293 but WITHOUT ANY WARRANTY; without even the implied warranty of
11294 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11295 GNU General Public License for more details.
11297 You should have received a copy of the GNU General Public License
11298 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.