1 2012-05-26 Glenn Morris <rgm@gnu.org>
3 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5 2012-05-26 Eli Zaretskii <eliz@gnu.org>
7 Extend mouse support on W32 text-mode console.
8 * xdisp.c (draw_row_with_mouse_face): Call
9 tty_draw_row_with_mouse_face for WINDOWSNT as well.
11 * w32console.c: Include window.h.
12 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
14 (initialize_w32_display): Initialize mouse-highlight data.
16 * w32inevt.c: Include termchar.h and window.h.
17 (do_mouse_event): Support mouse-autoselect-window. When the mouse
18 moves, call note_mouse_highlight. If help_echo changed, call
19 gen_help_event to produce help-echo message in the echo area.
20 Call clear_mouse_face if mouse_face_hidden is set in the mouse
23 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
25 * lread.c (read1): Simplify slightly to avoid an overflow warning
26 with GCC 4.7.0 on x86-64.
28 2012-05-26 Eli Zaretskii <eliz@gnu.org>
30 * bidi.c (bidi_mirror_char): Revert last change: an int is
31 definitely wide enough here.
33 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
35 Fix integer width and related bugs (Bug#9874).
36 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
37 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
38 (string_bytes, check_sblock, allocate_string_data):
39 (compact_small_strings, Fmake_bool_vector, make_string)
40 (make_unibyte_string, make_multibyte_string)
41 (make_string_from_bytes, make_specified_string)
42 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
43 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
45 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
46 (allocate_pseudovector):
47 Use int, not EMACS_INT, where int is wide enough.
48 (inhibit_garbage_collection, Fgarbage_collect):
49 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
50 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
51 int might not be wide enough.
52 (bidi_cache_search, bidi_cache_find, bidi_init_it)
53 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
54 (bidi_at_paragraph_end, bidi_find_paragraph_start)
55 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
56 (bidi_level_of_next_char, bidi_move_to_visually_next):
57 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
58 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
59 (Fkill_buffer, Fset_buffer_major_mode)
60 (advance_to_char_boundary, Fbuffer_swap_text)
61 (Fset_buffer_multibyte, overlays_at, overlays_in)
62 (overlay_touches_p, struct sortvec, record_overlay_string)
63 (overlay_strings, recenter_overlay_lists)
64 (adjust_overlays_for_insert, adjust_overlays_for_delete)
65 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
66 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
67 (Foverlay_recenter, last_overlay_modification_hooks_used)
68 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
69 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
70 (validate_region): Omit unnecessary test for b <= e,
71 since that's guaranteed by the previous test.
72 (adjust_overlays_for_delete): Avoid pos + length overflow.
73 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
74 (report_overlay_modification):
75 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
76 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
77 Omit pointer cast, which isn't needed anyway, and doesn't work
78 after the EMACS_INT -> ptrdiff_t change.
79 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
80 * buffer.h: Adjust decls to match defn changes elsewhere.
81 (struct buffer_text, struct buffer):
82 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
83 Use EMACS_INT, not int, where int might not be wide enough.
84 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
85 not int, to avoid needless 32-bit limit on 64-bit hosts.
86 (exec_byte_code): Use tighter memory-full test, one that checks
87 for alloca overflow. Don't compute the address of the object just
88 before an array, as that's not portable. Use EMACS_INT, not
89 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
90 * callint.c (Fcall_interactively):
91 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
92 * callproc.c (call_process_kill, Fcall_process):
93 Don't assume pid_t fits into an Emacs fixnum.
94 (call_process_cleanup, Fcall_process, child_setup):
95 Don't assume pid_t fits into int.
96 (call_process_cleanup, Fcall_process, delete_temp_file)
97 (Fcall_process_region):
98 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
99 (Fcall_process): Simplify handling of volatile integers.
100 Use int, not EMACS_INT, where int will do.
101 * casefiddle.c (casify_object, casify_region, operate_on_word)
102 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
104 (casify_object): Avoid integer overflow when overallocating buffer.
105 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
106 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
107 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
108 * category.h (CATEGORYP): Don't assume arg is nonnegative.
109 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
110 integers are now checked earlier. All uses replaced with XINT.
112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
113 For CCL_MapSingle, check that content and value are in int range.
114 (ccl_driver, Fregister_code_conversion_map):
115 Check that Vcode_version_map_vector is a vector.
116 (resolve_symbol_ccl_program): Check that vector header is in range.
117 Always copy the vector, so that we can check its contents reliably
118 now rather than having to recheck each instruction as it's being
119 executed. Check that vector words fit in 'int'.
120 (ccl_get_compiled_code, Fregister_ccl_program)
121 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
122 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
123 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
124 contents are in range.
125 (Fccl_execute_on_string): Check that status is in range.
126 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
127 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
128 Accept and return EMACS_INT, not int, because callers can pass values
130 (c_string_width, strwidth, lisp_string_width, chars_in_text)
131 (multibyte_chars_in_text, parse_str_as_multibyte)
132 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
133 (str_as_unibyte, str_to_unibyte, string_count_byte8)
134 (string_escape_byte8, Fget_byte):
135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
136 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
137 avoid mishandling large integers.
138 * character.h: Adjust decls to match defn changes elsewhere.
139 * charset.c (load_charset_map_from_file, find_charsets_in_text)
140 (Ffind_charset_region):
141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
142 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
143 (load_charset_map_from_vector, Fdefine_charset_internal):
144 Don't assume fixnum fits in int.
145 (load_charset_map_from_vector, Fmap_charset_chars):
146 Remove now-unnecessary CHECK_NATNUMs.
147 (Fdefine_charset_internal): Check ranges here, more carefully.
148 Don't rely on undefined behavior with signed left shift overflow.
149 Don't assume unsigned int fits into fixnum, or that fixnum fits
150 into unsigned int. Don't require max_code to be a valid fixnum;
151 that's not true for gb10830 4-byte on a 32-bit host. Allow
152 invalid_code to be a cons, for the same reason. Require code_offset
153 to be a character. Avoid int overflow if max_char is close
155 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
156 this is intended anyway and avoids some undefined behavior.
157 (load_charset_map): Pass unsigned, not int, as 2nd arg of
158 INDEX_TO_CODE_POINT, as that's what it expects.
159 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
160 * charset.h (DECODE_CHAR): Return int, not unsigned;
161 this is what was intended anyway, and it avoids undefined behavior.
162 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
163 integer-overflow issues.
164 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
165 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
166 where the argument is EMACS_INT, and this behavior is not intended.
167 * chartab.c (Fmake_char_table, Fset_char_table_range)
168 (uniprop_get_decoder, uniprop_get_encoder):
169 Don't assume fixnum fits in int.
170 * cmds.c (move_point): New function, that does the gist of
171 Fforward_char and Fbackward_char, but does so while checking
172 for integer overflow more accurately.
173 (Fforward_char, Fbackward_char): Use it.
174 (Fforward_line, Fend_of_line, internal_self_insert)
175 (internal_self_insert):
176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
177 Fix a FIXME, by checking for integer overflow when calculating
178 target_clm and actual_clm.
179 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
180 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
181 (ASSURE_DESTINATION, coding_alloc_by_realloc)
182 (coding_alloc_by_making_gap, alloc_destination)
183 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
184 (encode_coding_utf_16, detect_coding_emacs_mule)
185 (decode_coding_emacs_mule, encode_coding_emacs_mule)
186 (detect_coding_iso_2022, decode_coding_iso_2022)
187 (encode_invocation_designation, encode_designation_at_bol)
188 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
189 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
190 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
191 (encode_coding_ccl, encode_coding_raw_text)
192 (detect_coding_charset, decode_coding_charset)
193 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
194 (produce_composition, produce_charset, produce_annotation)
195 (decode_coding, handle_composition_annotation)
196 (handle_charset_annotation, consume_chars, decode_coding_gap)
197 (decode_coding_object, encode_coding_object, detect_coding_system)
198 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
199 (code_convert_region, code_convert_string)
200 (Fdefine_coding_system_internal)
201 (coding_set_source, coding_set_destination):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
204 (Fdefine_coding_system_internal):
205 Don't assume fixnums fit in int.
206 (decode_coding_gap, decode_coding_object, encode_coding_object)
207 (Fread_coding_system, Fdetect_coding_region)
208 (Funencodable_char_position, Fcheck_coding_systems_region)
209 (get_translation, handle_composition_annotation, consume_chars):
210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
211 (consume_chars): Rewrite to not calculate an address outside buffer.
212 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
213 Don't access memory outside of the args array.
214 (Fdefine_coding_system_internal): Check for charset-id overflow.
215 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
216 result of ENCODE_CHAR.
217 * coding.h: Adjust decls to match defn changes elsewhere.
218 (struct coding_system):
219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
220 * composite.c (get_composition_id, find_composition)
221 (run_composition_function, update_compositions)
222 (compose_text, composition_gstring_put_cache)
223 (composition_gstring_p, composition_gstring_width)
224 (fill_gstring_header, fill_gstring_body, autocmp_chars)
225 (composition_compute_stop_pos, composition_reseat_it)
226 (composition_update_it, struct position_record)
227 (find_automatic_composition, composition_adjust_point)
228 (Fcomposition_get_gstring, Ffind_composition_internal):
229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
230 (update_compositions):
231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
232 * composite.h: Adjust decls to match defn changes elsewhere.
233 (struct composition):
234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
235 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
236 Do not attempt to compute the address of the object just before a
237 buffer; this is not portable.
239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
240 (Faset): Use int, not EMACS_INT, where int is wide enough.
241 (Fstring_to_number): Don't assume fixnums fit in int.
242 (Frem): Don't assume arg is nonnegative.
243 * dbusbind.c (xd_append_arg): Check for integers out of range.
244 (Fdbus_call_method): Don't overflow the timeout int.
245 (extract_signed, extract_unsigned): New functions.
246 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
247 (xd_get_connection_references): Return ptrdiff_t, not int.
249 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
251 Use int, not unsigned, where the dbus API uses int.
252 (Fdbus_message_internal): Don't overflow mtype.
253 (syms_of_dbusbind): Allocate right-sized buffer for integers.
254 * dired.c (directory_files_internal, file_name_completion, scmp)
255 (file_name_completion_stat):
256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
257 (file_name_completion): Don't overflow matchcount.
258 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
259 * dispextern.h: Adjust decls to match defn changes elsewhere.
260 (struct text_pos, struct glyph, struct bidi_saved_info)
261 (struct bidi_string_data, struct bidi_it, struct composition_it)
263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
264 (struct display_pos, struct composition_it, struct it):
265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
266 * dispnew.c (increment_matrix_positions)
267 (increment_row_positions, mode_line_string)
268 (marginal_area_string):
269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
270 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
272 (duration_to_sec_usec): New function, to check for overflow better.
273 (Fsleep_for, sit_for): Use it.
274 * doc.c (get_doc_string, store_function_docstring):
275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
276 (get_doc_string, Fsnarf_documentation):
277 Use int, not EMACS_INT, where int is wide enough.
279 Use SAFE_ALLOCA, not alloca.
280 Check for overflow when converting EMACS_INT to off_t.
282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
283 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
284 Don't assume uid_t fits into fixnum.
285 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
286 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
287 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
288 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
289 (general_insert_function)
290 (Finsert_char, make_buffer_string, make_buffer_string_both)
291 (update_buffer_properties, Fbuffer_substring)
292 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
293 (Fsubst_char_in_region, check_translation)
294 (Ftranslate_region_internal, save_restriction_restore, Fformat)
295 (transpose_markers, Ftranspose_regions):
296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
297 (clip_to_bounds): Move to lisp.h as an inline function).
298 (Fconstrain_to_field): Don't assume integers are nonnegative.
299 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
300 (Fsubst_char_in_region, Fsave_restriction):
301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
302 (Femacs_pid): Don't assume pid_t fits into fixnum.
303 (lo_time): Use int, not EMACS_INT, when int suffices.
304 (lisp_time_argument): Check for usec out of range.
305 (Fencode_time): Don't assume fixnum fits in int.
306 (Fuser_login_name, Fuser_full_name): Signal an error
307 if a uid argument is out of range, rather than relying on
309 (Fformat_time_string): Remove now-unnecessary check.
310 lisp_time_argument checks for out-of-range usec now.
311 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
312 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
313 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
314 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
315 (init_cmdargs, Fdump_emacs):
316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
317 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
318 the bottom (typically) 32 bits of the fixnum.
319 * eval.c (specpdl_size, call_debugger):
320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
321 (when_entered_debugger, Fbacktrace_debug):
322 Don't assume fixnum can fit in int.
323 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
324 the object just before a buffer; this is not portable.
325 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
326 (grow_specpdl, unbind_to):
327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
328 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
329 (grow_specpdl): Simplify allocation by using xpalloc.
330 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
331 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
332 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
334 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
337 (Fcopy_file, non_regular_nbytes, read_non_regular)
338 (Finsert_file_contents):
339 Use int, not EMACS_INT, where int is wide enough.
340 (READ_BUF_SIZE): Verify that it fits in int.
341 (Finsert_file_contents): Check that counts are in proper range,
342 rather than assuming fixnums fit into ptrdiff_t etc.
343 Don't assume fixnums fit into int.
344 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
345 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
346 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
347 (string_char_to_byte, string_byte_to_char)
348 (string_make_multibyte, string_to_multibyte)
349 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
350 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
351 (substring_both, Fdelete, internal_equal, Ffillarray)
352 (Fclear_string, mapcar1)
353 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
354 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
355 (larger_vector, make_hash_table, maybe_resize_hash_table)
356 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
357 (Fmaphash, secure_hash):
358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
359 (concat): Check for string index and length overflow.
360 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
363 (larger_vector): New API (vec, incr_min, size_max) replaces old
364 one (vec, new_size, init). This catches size overflow.
365 INIT was removed because it was always Qnil.
367 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
368 the upper bound on a hash table index size.
369 (make_hash_table, maybe_resize_hash_table): Use it.
370 (secure_hash): Computer start_byte and end_byte only after
371 they're known to be in ptrdiff_t range.
372 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
373 (Ffont_get_glyphs, Ffont_at):
374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
375 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
376 (Flist_fonts, Fopen_font):
377 Don't assume fixnum can fit in int.
378 (check_gstring): Don't assume index can fit in int.
379 (font_match_p): Check that fixnum is a character, not a nonnegative
380 fixnum, since the later code needs to stuff it into an int.
381 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
382 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
383 conversion overflow issues.
384 (Fopen_font): Check for integer out of range.
385 (Ffont_get_glyphs): Don't assume index can fit in int.
386 * font.h: Adjust decls to match defn changes elsewhere.
387 * fontset.c (reorder_font_vector): Redo score calculation to avoid
389 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
390 printmax_t, where ptrdiff_t is wide enough.
391 (Finternal_char_font):
392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
393 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
394 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
395 (Fset_frame_position, x_set_frame_parameters)
396 (x_set_line_spacing, x_set_border_width)
397 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
398 Check that fixnums are in proper range for system types.
399 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
401 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
402 Use SAFE_ALLOCA_LISP, not alloca.
403 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
404 intptr_t is wide enough.
405 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
406 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
407 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
408 Check for fixnum out of range.
409 * ftfont.c (ftfont_list): Don't assume index fits in int.
410 Check that fixnums are in proper range for system types.
411 (ftfont_shape_by_flt):
412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
413 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
415 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
416 Check that fixnums are in proper range for system types.
417 * gnutls.h: Adjust decls to match defn changes elsewhere.
418 * gtkutil.c (xg_dialog_run):
419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
420 (update_frame_tool_bar):
421 Check that fixnums are in proper range for system types.
422 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
423 (lookup_image): Check that fixnums are in range for system types.
424 * indent.c (last_known_column, last_known_column_point):
425 (current_column_bol_cache):
426 (skip_invisible, current_column, check_display_width):
427 (check_display_width, scan_for_column, current_column_1)
428 (Findent_to, Fcurrent_indentation, position_indentation)
429 (indented_beyond_p, Fmove_to_column, compute_motion):
430 (Fcompute_motion, Fvertical_motion):
431 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
432 (last_known_column_modified): Use EMACS_INT, not int.
433 (check_display_width):
435 Check that fixnums and floats are in proper range for system types.
436 (compute_motion): Don't assume index or fixnum fits in int.
437 (compute_motion, Fcompute_motion):
438 Use int, not EMACS_INT, when it is wide enough.
439 (vmotion): Omit local var start_hpos that is always 0; that way
440 we don't need to worry about overflow in expressions involving it.
441 * indent.h: Adjust decls to match defn changes elsewhere.
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
444 Use int, not EMACS_INT, where int is wide enough.
445 Remove unused members ovstring_chars_done and tab_offset;
447 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
448 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
449 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
450 (make_gap, copy_text, insert, insert_and_inherit)
451 (insert_before_markers, insert_before_markers_and_inherit)
452 (insert_1, count_combining_before, count_combining_after)
453 (insert_1_both, insert_from_string)
454 (insert_from_string_before_markers, insert_from_string_1)
455 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
456 (adjust_after_replace, adjust_after_insert, replace_range)
457 (replace_range_2, del_range, del_range_1, del_range_byte)
458 (del_range_both, del_range_2, modify_region)
459 (prepare_to_modify_buffer, signal_before_change)
460 (signal_after_change, Fcombine_after_change_execute):
461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
462 * intervals.c (traverse_intervals, rotate_right, rotate_left)
463 (balance_an_interval, split_interval_right, split_interval_left)
464 (find_interval, next_interval, update_interval)
465 (adjust_intervals_for_insertion, delete_node, delete_interval)
466 (interval_deletion_adjustment, adjust_intervals_for_deletion)
467 (static_offset_intervals, offset_intervals)
468 (merge_interval_right, merge_interval_left, make_new_interval)
469 (graft_intervals_into_buffer, temp_set_point_both)
470 (temp_set_point, set_point, adjust_for_invis_intang)
471 (set_point_both, move_if_not_intangible, get_property_and_range)
472 (get_local_map, copy_intervals, copy_intervals_to_string)
473 (compare_string_intervals, set_intervals_multibyte_1):
474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
475 * intervals.h: Adjust decls to match defn changes elsewhere.
477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
478 * keyboard.c (this_command_key_count, this_single_command_key_start)
479 (before_command_key_count, before_command_echo_length, echo_now)
480 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
481 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
482 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
483 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
485 (last_non_minibuf_size, last_point_position, echo_truncate)
486 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
487 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
488 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
489 (stuff_buffered_input):
490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
491 (last_auto_save, command_loop_1, read_char):
492 Use EMACS_INT, not int, to avoid integer overflow.
493 (record_char): Avoid overflow in total_keys computation.
494 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
495 * keyboard.h: Adjust decls to match defn changes elsewhere.
496 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
497 (Fkey_description, Fdescribe_vector, Flookup_key):
498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
499 (click_position): New function, to check that positions are in range.
500 (Fcurrent_active_maps):
502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
503 (Faccessible_keymaps, Fkey_description):
504 (preferred_sequence_p):
505 Don't assume fixnum can fit into int.
506 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
507 Check for integer overflow in size calculations.
508 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
509 avoid mishandling large integers.
510 * lisp.h: Adjust decls to match defn changes elsewhere.
511 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
512 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
513 (struct Lisp_Marker):
514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
515 (clip_to_bounds): Now an inline function, moved here from editfns.c.
516 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
517 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
519 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
520 Assume the arg has valid form, since it always does.
521 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
522 unsigned integer system type.
523 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
524 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
526 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
527 (duration_to_sec_usec): New decl.
528 * lread.c (read_from_string_index, read_from_string_index_byte)
529 (read_from_string_limit, readchar, unreadchar, openp)
530 (read_internal_start, read1, oblookup):
531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
532 (Fload, readevalloop, Feval_buffer, Feval_region):
533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
534 (openp): Check for out-of-range argument to 'access'.
535 (read1): Use int, not EMACS_INT, where int is wide enough.
536 Don't assume fixnum fits into int.
537 Fix off-by-one error that can read outside a buffer.
538 (read_filtered_event): Use duration_to_sec_usec
539 to do proper overflow checking on durations.
540 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
542 (Fexecute_kbd_macro):
543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
544 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
545 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
546 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
547 (set_marker_both, set_marker_restricted_both, marker_position)
548 (marker_byte_position, Fbuffer_has_markers_at):
549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
550 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
551 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
552 It now merely ensures that the menu is large enough, without
553 necessarily growing it, as this avoids some integer overflow issues.
555 (keymap_panes, parse_single_submenu, Fx_popup_menu):
556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
557 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
558 Use SAFE_ALLOCA_LISP, not alloca.
559 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
560 to EMACS_INT. Check that fixnums are in proper range for system types.
561 * minibuf.c (minibuf_prompt_width, string_to_object)
562 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
563 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
565 (get_minibuffer, read_minibuf_unwind):
566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
567 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
568 this simplifies overflow checking. All callers changed.
569 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
572 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
573 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
574 Check that fixnums are in proper range for system types.
575 (Fx_create_frame, Fx_show_tip):
576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
577 * nsfont.m (ns_findfonts, nsfont_list_family):
578 Don't assume fixnum fits in long.
579 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
581 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
583 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
585 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
586 (PRINTDECLARE, PRINTPREPARE):
587 (strout, print_string):
588 (print, print_preprocess, print_check_string_charset_prop)
590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
592 (temp_output_buffer_setup, Fprin1_to_string, print_object):
593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
594 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
595 (printchar, strout): Use xpalloc to catch size calculation overflow.
596 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
597 (print_error_message): Use SAFE_ALLOCA, not alloca.
598 (print_object): Use int, not EMACS_INT, where int is wide enough.
599 (print_depth, new_backquote_output, print_number_index):
600 Use ptrdiff_t, not int, where int might not be wide enough.
601 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
602 (Fset_process_window_size, Fformat_network_address)
603 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
605 Check that fixnums are in proper range for system types.
606 (Fsignal_process): Simplify by avoiding a goto.
607 Check for process-ids out of pid_t range rather than relying on
609 (process_tick, update_tick): Use EMACS_INT, not int.
610 (Fformat_network_address, read_process_output, send_process)
611 (Fprocess_send_region, status_notify):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
614 (wait_reading_process_output, read_process_output, exec_sentinel):
615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
616 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
617 (Faccept_process_output): Use duration_to_sec_usec to do proper
618 overflow checking on durations.
619 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
620 Don't assume pid_t fits in int.
621 * process.h (struct Lisp_Process): Members tick and update_tick
622 are now of type EMACS_INT, not int.
623 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
624 configured --with-wide-int.
625 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
626 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
627 * search.c (looking_at_1, string_match_1):
628 (fast_string_match, fast_c_string_match_ignore_case)
629 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
630 (scan_newline, find_before_next_newline, search_command)
631 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
632 (set_search_regs, wordify):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 (string_match_1, search_buffer, set_search_regs):
638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
639 (wordify): Check for overflow in size calculation.
640 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
641 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
642 Check that fixnums are in proper range for system types.
643 * sound.c (struct sound_device)
644 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
646 (Fplay_sound_internal):
647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
648 * syntax.c (struct lisp_parse_state, find_start_modiff)
649 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
650 (Fparse_partial_sexp):
651 Don't assume fixnums can fit in int.
652 (struct lisp_parse_state, find_start_pos, find_start_value)
653 (find_start_value_byte, find_start_begv)
654 (update_syntax_table, char_quoted, dec_bytepos)
655 (find_defun_start, prev_char_comend_first, back_comment):
656 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
657 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
659 (Finternal_describe_syntax_value): Check that match_lisp is a
660 character, not an integer, since the code stuffs it into int.
661 (scan_words, scan_sexps_forward):
662 Check that fixnums are in proper range for system types.
664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
665 (scan_sexps_forward):
666 Use CHARACTERP, not INTEGERP, since the value must fit into int.
667 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
668 * syntax.h: Adjust decls to match defn changes elsewhere.
670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
671 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
672 MOST_POSITIVE_FIXNUM.
673 * sysdep.c (wait_for_termination_1, wait_for_termination)
674 (interruptible_wait_for_termination, mkdir):
675 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
676 (emacs_read, emacs_write):
677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
678 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
679 and double all fit in int.
680 * term.c (set_tty_color_mode):
681 Check that fixnums are in proper range for system types.
682 * termhooks.h (struct input_event):
683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
684 * textprop.c (validate_interval_range, interval_of)
685 (Fadd_text_properties, set_text_properties_1)
686 (Fremove_text_properties, Fremove_list_of_text_properties)
687 (Ftext_property_any, Ftext_property_not_all)
688 (copy_text_properties, text_property_list, extend_property_ranges)
689 (verify_interval_modification):
690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
691 (Fnext_single_char_property_change)
692 (Fprevious_single_char_property_change):
693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
694 (copy_text_properties):
695 Check for integer overflow in index calculation.
696 * undo.c (last_boundary_position, record_point, record_insert)
697 (record_delete, record_marker_adjustment, record_change)
698 (record_property_change):
699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
700 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
702 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
703 (Fx_hide_tip, Fx_file_dialog):
704 * w32menu.c (set_frame_menubar):
705 Use ptrdiff_t, not int, for consistency with rest of code.
706 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
707 (select_window, Fdelete_other_windows_internal)
708 (window_scroll_pixel_based, window_scroll_line_based)
709 (Frecenter, Fset_window_configuration):
710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
711 (Fset_window_hscroll, run_window_configuration_change_hook)
712 (set_window_buffer, temp_output_buffer_show, scroll_command)
713 (Fscroll_other_window, Frecenter):
714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
715 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
716 Don't assume fixnum fits in int.
717 (Fset_window_scroll_bars):
718 Check that fixnums are in proper range for system types.
719 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
720 (string_pos, c_string_pos, number_of_chars, init_iterator)
721 (in_ellipses_for_invisible_text_p, init_from_display_pos)
722 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
723 (compute_display_string_end, handle_face_prop)
724 (face_before_or_after_it_pos, handle_invisible_prop)
725 (handle_display_prop, handle_display_spec, handle_single_display_spec)
726 (display_prop_intangible_p, string_buffer_position_lim)
727 (string_buffer_position, handle_composition_prop, load_overlay_strings)
728 (get_overlay_strings_1, get_overlay_strings)
729 (iterate_out_of_display_property, forward_to_next_line_start)
730 (back_to_previous_visible_line_start, reseat, reseat_to_string)
731 (get_next_display_element, set_iterator_to_next)
732 (get_visually_first_element, compute_stop_pos_backwards)
733 (handle_stop_backwards, next_element_from_buffer)
734 (move_it_in_display_line_to, move_it_in_display_line)
735 (move_it_to, move_it_vertically_backward, move_it_by_lines)
736 (add_to_log, message_dolog, message_log_check_duplicate)
737 (message2, message2_nolog, message3, message3_nolog
738 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
739 (current_message_1, truncate_echo_area, truncate_message_1)
740 (set_message, set_message_1, store_mode_line_noprop)
741 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
742 (text_outside_line_unchanged_p, check_point_in_composition)
743 (reconsider_clip_changes)
744 (redisplay_internal, set_cursor_from_row, try_scrolling)
745 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
746 (redisplay_window, find_last_unchanged_at_beg_row)
747 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
748 (trailing_whitespace_p, find_row_edges, display_line)
749 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
750 (display_mode_element, store_mode_line_string)
751 (pint2str, pint2hrstr, decode_mode_spec)
752 (display_count_lines, display_string, draw_glyphs)
753 (x_produce_glyphs, x_insert_glyphs)
754 (rows_from_pos_range, mouse_face_from_buffer_pos)
755 (fast_find_string_pos, mouse_face_from_string_pos)
756 (note_mode_line_or_margin_highlight, note_mouse_highlight):
757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
758 (safe_call, init_from_display_pos, handle_fontified_prop)
759 (handle_single_display_spec, load_overlay_strings)
760 (with_echo_area_buffer, setup_echo_area_for_printing)
761 (display_echo_area, echo_area_display)
762 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
763 (update_tool_bar, hscroll_window_tree, redisplay_internal)
764 (redisplay_window, dump_glyph_row, display_mode_line)
765 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
766 (handle_display_spec, display_prop_string_p):
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 (handle_single_display_spec, build_desired_tool_bar_string)
769 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
770 (get_specified_cursor_type):
771 Check that fixnums are in proper range for system types.
772 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
774 Don't assume fixnums fit in int.
775 (compare_overlay_entries):
776 Avoid mishandling comparisons due to subtraction overflow.
777 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
778 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
779 (handle_tool_bar_click):
780 Use int, not unsigned, since we prefer signed and the signedness
782 (get_next_display_element, next_element_from_display_vector):
783 Use int, not EMACS_INT, when int is wide enough.
784 (start_hourglass): Use duration_to_sec_usec to do proper
785 overflow checking on durations.
786 * xfaces.c (Fbitmap_spec_p):
787 Check that fixnums are in proper range for system types.
788 (compare_fonts_by_sort_order):
789 Avoid mishandling comparisons due to subtraction overflow.
790 (Fx_family_fonts, realize_basic_faces):
791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
793 Don't assume fixnum fits in int.
794 Use SAFE_ALLOCA_LISP, not alloca.
795 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
796 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
797 (face_at_buffer_position, face_for_overlay_string)
798 (face_at_string_position):
799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
800 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
801 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
803 Check that fixnums are in proper range for system types.
804 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
805 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
807 (Fx_change_window_property): Don't assume fixnums fit in int.
808 * xfont.c (xfont_chars_supported):
809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
810 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
811 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
813 * xml.c (parse_region):
814 * xrdb.c (magic_file_p):
815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
816 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
817 (x_get_local_selection, x_reply_selection_request)
818 (x_handle_selection_request, wait_for_property_change):
819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
820 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
821 short is wide enough.
822 (x_send_client_event): Don't assume fixnum fits in int.
823 * xterm.c (x_x_to_emacs_modifiers):
824 Don't assume EMACS_INT overflows nicely into int.
825 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
827 (handle_one_xevent): NATNUMP can eval its arg twice.
828 (x_connection_closed):
829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
830 * xterm.h: Adjust decls to match defn changes elsewhere.
831 (struct scroll_bar): Use struct vectorlike_header
832 rather than rolling our own approximation.
833 (SCROLL_BAR_VEC_SIZE): Remove; not used.
835 2012-05-25 Glenn Morris <rgm@gnu.org>
837 * lisp.mk (lisp): Update for more files being compiled now.
839 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
841 * lread.c: Remove `read_pure' which makes no difference.
842 (read_pure): Remove var.
843 (unreadpure): Remove function.
844 (readevalloop): Don't call read_list with -1 flag.
845 (read1, read_vector): Don't test read_pure any more.
846 (read_list): Simplify.
848 * fileio.c, character.h: Minor style tweaks.
850 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
852 * window.h (clip_changed): Remove useless declaration.
854 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
856 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
857 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
859 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
862 This directory predates autoconf and is no longer needed nowadays.
863 Move its few remaining bits of functionality to where they're needed.
864 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
865 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
866 * m/template.h: Remove.
867 * Makefile.in (M_FILE): Remove. All uses removed.
868 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
869 * lisp.h (USE_LSB_TAG):
870 * mem-limits.h (EXCEEDS_LISP_PTR):
871 Use VAL_MAX, not VALBITS, in #if.
872 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
873 (EMACS_UINT): Define unconditionally now.
874 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
875 (BITS_PER_EMACS_INT): New constants, replacing
876 what used to be in config.h, but not useful in #if.
877 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
878 define them any more.
879 (VAL_MAX): New macro.
881 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
882 BITS_PER_EMACS_INT, in #if.
883 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
884 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
885 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
886 * s/ms-w32.h (DATA_START):
887 Move here from removed file m/intel386.h.
888 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
889 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
891 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
894 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
895 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
897 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
898 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
899 * textprop.c, tparam.c (NULL): Remove.
900 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
901 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
902 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
903 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
904 * xterm.c (input_signal_count): Assume volatile works.
906 2012-05-21 Ken Brown <kbrown@cornell.edu>
908 * xgselect.c (xg_select): Fix first argument in call to 'select'
911 2012-05-20 Ken Brown <kbrown@cornell.edu>
913 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
914 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
916 2012-05-19 Ken Brown <kbrown@cornell.edu>
918 * xfns.c (x_in_use): Remove `static' qualifier.
919 * xterm.h (x_in_use): Declare.
920 * xgselect.c: Include xterm.h.
921 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
922 and `display_arg' (bug#9754).
924 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
926 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
928 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
929 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
931 2012-05-18 Eli Zaretskii <eliz@gnu.org>
933 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
935 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
936 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
938 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
939 reference to image_cache->refcount.
940 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
942 2012-05-17 Juri Linkov <juri@jurta.org>
944 * search.c (Fword_search_regexp, Fword_search_backward)
945 (Fword_search_forward, Fword_search_backward_lax)
946 (Fword_search_forward_lax): Move functions to isearch.el
947 (bug#10145, bug#11381).
949 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
951 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
953 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
955 * lread.c (init_obarray): Declare Qt and Qnil as special.
957 2012-05-14 Glenn Morris <rgm@gnu.org>
959 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
960 Put "libexec" before "bin", for the sake of init_callproc_1.
962 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
964 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
966 * unexaix.c: Port to more-recent AIX compilers.
967 (report_error, report_error_1, make_hdr, copy_sym)
968 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
969 Make arguments const char *, not char *, to avoid violations of C
970 standard and to fix some AIX warnings reported by Gilles Pion.
972 2012-05-14 Eli Zaretskii <eliz@gnu.org>
974 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
975 already have overlays loaded.
976 (handle_single_display_spec): Before returning without displaying
977 fringe bitmap, synchronize the bidi iterator with the main display
978 iterator, by calling iterate_out_of_display_property.
979 (iterate_out_of_display_property): Detect buffer iteration by
980 testing that it->string is a Lisp string.
981 (get_next_display_element): When the current object is exhausted,
982 and there's something on it->stack, call set_iterator_to_next to
983 proceed with what's on the stack, instead of returning zero.
984 (set_iterator_to_next): If called at the end of a Lisp string,
985 proceed to consider_string_end without incrementing string
986 position. Don't increment display vector index past the end of
987 the display vector. (Bug#11417)
988 (pos_visible_p): Don't report a position visible when move_it_to
989 stopped at the last line of window, which happens to be scanned
990 backwards by the bidi iteration. (Bug#11464)
992 2012-05-14 Eli Zaretskii <eliz@gnu.org>
994 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
995 and right-margin display specs even if the spec is invalid or we
996 are on a TTY, and thus unable to display on the fringes. That's
997 because the text with the property will not be displayed anyway,
998 so we need to signal to the caller that this is a "replacing"
999 display spec. This fixes display when the spec is invalid or we
1002 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1004 * unexaix.c (make_hdr): Fix typo in prototype.
1005 This bug broke the build on AIX. Problem reported by Gilles Pion.
1007 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1009 * keyboard.c (kbd_buffer_get_event): Read special events also in
1010 batch mode. (Bug#11415)
1012 2012-05-12 Glenn Morris <rgm@gnu.org>
1014 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1016 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1018 * lisp.mk (lisp): Add newcomment.elc.
1020 2012-05-12 Glenn Morris <rgm@gnu.org>
1022 * Makefile.in (MKDIR_P): New, set by configure.
1023 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1025 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1027 Remove unused function hourglass_started.
1028 * dispextern.h (hourglass_started):
1029 * w32fns.c (hourglass_started):
1030 * xdisp.c (hourglass_started): Remove.
1032 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1034 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1035 Update dependencies.
1037 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1039 * xgselect.c (xg_select): Put maxfds+1 into a var.
1040 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1042 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1044 2012-05-10 Dave Abrahams <dave@boostpro.com>
1046 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1047 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1049 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1051 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1052 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1053 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1054 Initialize xd_registered_buses.
1056 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1058 Untag more efficiently if USE_LSB_TAG.
1059 This is based on a proposal by YAMAMOTO Mitsuharu in
1060 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1061 For an admittedly artificial (nth 8000 longlist) benchmark on
1062 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1063 Emacs's overall text size by 1%.
1064 * lisp.h (XUNTAG): New macro.
1065 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1066 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1067 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1068 * eval.c (Fautoload):
1069 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1070 * frame.h (XFRAME): Use XUNTAG.
1072 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1073 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1074 Remove unportable assumptions about print widths of types like
1076 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1077 intptr_t when converting between pointer and integer, to avoid GCC
1078 warnings about wrong width.
1080 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1082 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1083 stack for each reader_thread, instead of defaulting to 8MB
1084 determined by the linker. This avoids failures in creating
1085 subprocesses on Windows 7, see the discussion in this thread:
1086 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1088 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1090 Fix up display of the *Minibuf-0* buffer in the mini window.
1091 * keyboard.c (read_char): Don't clear the echo area if there's no
1093 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1094 contents of *Minibuf-0*) if there's no message displayed in its stead.
1096 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1098 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1101 2012-05-06 Chong Yidong <cyd@gnu.org>
1103 * lisp.mk (lisp): Update.
1105 2012-05-05 Jim Meyering <meyering@redhat.com>
1107 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1109 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1111 * data.c (PUT_ERROR): New macro.
1112 (syms_of_data): Use it. Add new error type `user-error'.
1113 * undo.c (user_error): New function.
1114 (Fprimitive_undo): Use it.
1115 * print.c (print_error_message): Adjust print style for `user-error'.
1116 * keyboard.c (user_error): New function.
1117 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1119 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1121 Do not limit current-time-string to years 1000..9999.
1122 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1123 (Fcurrent_time_string): Support any year that is supported by the
1124 underlying localtime representation. Don't use asctime, as it
1125 has undefined behavior for years outside the range -999..9999.
1127 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1129 Fix race conditions involving setenv, gmtime, localtime, asctime.
1130 Without this fix, interrupts could mess up code that uses these
1131 nonreentrant functions, since setting TZ invalidates existing
1132 tm_zone or tzname values, and since most of these functions return
1133 pointers to static storage.
1134 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1135 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1136 Grow the critical sections to include not just invoking
1137 localtime/gmtime, but also accessing these functions' results
1138 including their tm_zone values if any, and any related TZ setting.
1139 (format_time_string): Last arg is now struct tm *, not struct tm **,
1140 so that the struct tm is saved in the critical section.
1141 All callers changed. Simplify allocation of initial buffer, partly
1142 motivated by the fact that memory allocation needs to be outside
1143 the critical section.
1145 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1147 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1148 with RESET_INTERVAL.
1150 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1151 Remove duplicated buffer name initialization.
1153 2012-05-02 Jim Meyering <jim@meyering.net>
1155 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1157 * xfns.c (x_window): Use xstrdup (Bug#11375).
1159 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1161 * xdisp.c (pos_visible_p): If already at a newline from the
1162 display string before the 'while' loop, don't walk back the glyphs
1163 from it3.glyph_row. Solves assertion violation when the display
1164 string begins with a newline (egg.el). (Bug#11367)
1166 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1168 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1171 2012-05-01 Glenn Morris <rgm@gnu.org>
1173 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1174 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1175 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1176 All were removed before 23.1.
1178 * dispnew.c: Remove HAVE_LIBNCURSES test;
1179 it is always true on relevant platforms.
1181 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1182 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1184 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1186 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1188 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1189 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1192 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1194 Do not avoid creating empty evaporating overlays (Bug#9642).
1195 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1196 That is, do not delete an evaporating overlay if it becomes
1197 empty after its bounds are adjusted to fit within its buffer.
1198 This fix caused other problems, and I'm reverting it until we get
1199 to the bottom of them.
1201 2012-04-27 Chong Yidong <cyd@gnu.org>
1203 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1205 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1207 * xdisp.c (pos_visible_p): If the window start position is beyond
1208 ZV, start the display from buffer beginning. Prevents assertion
1209 violation in init_iterator when the minibuffer window is scrolled
1212 * window.c (window_scroll_pixel_based): Likewise.
1214 2012-04-27 Chong Yidong <cyd@gnu.org>
1216 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1218 2012-04-27 Glenn Morris <rgm@gnu.org>
1220 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1221 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1223 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1225 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1226 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1228 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1230 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1231 display element, check also the underlying string or buffer
1232 character. (Bug#11341)
1234 * w32menu.c: Include w32heap.h.
1235 (add_menu_item): If the call to AppendMenuW (via
1236 unicode_append_menu) fails, disable Unicode menus only if we are
1237 running on Windows 9X/Me.
1239 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1241 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1242 (xgetint): Add missing shift for LSB tags.
1244 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1246 * keyboard.c (read_char): Don't wipe echo area for select window
1247 events: These might get delayed via `mouse-autoselect-window'
1250 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1252 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1253 manipulation of :loaded-from data.
1255 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1257 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1258 now a cons (bug#11311).
1260 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1262 Do not create empty overlays with the evaporate property (Bug#9642).
1263 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1264 if it becomes empty after its bounds are adjusted to fit within
1265 its buffer. Without this fix, in a nonempty buffer (let ((o
1266 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1267 yields an empty overlay that has the evaporate property, which is
1268 not supposed to happen.
1270 Fix minor GTK3 problems found by static checking.
1271 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1272 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1273 (struct _EmacsFixedClass, emacs_fixed_get_type):
1274 Move decls here from emacsgtkfixed.h, since they needn't be public.
1275 (emacs_fixed_get_type): Now static.
1276 (emacs_fixed_class_init): Omit unused local.
1277 (emacs_fixed_child_type): Remove; unused.
1278 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1279 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1280 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1281 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1282 (EMACS_FIXED_GET_CLASS): Remove; unused.
1283 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1285 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1286 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1288 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1290 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1291 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1292 (__malloc_size_t, __malloc_ptrdiff_t):
1293 Remove. All uses removed, replaced by the definiens if needed,
1294 since we can assume C89 or better now.
1295 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1296 (protect_malloc_state, align, get_contiguous_space)
1297 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1298 (malloc_atfork_handler_child, malloc_enable_thread)
1299 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1300 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1301 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1302 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1303 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1304 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1305 Define using prototypes, not old style.
1306 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1307 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1308 (align): Don't assume that signed integer overflow wraps around.
1309 Omit unused local var.
1310 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1311 (_free_internal_nolock, memalign, mallochook, reallochook):
1312 Omit no-longer-needed casts.
1313 (valloc): Use getpagesize, not __getpagesize.
1314 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1315 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1317 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1319 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1321 Move functions from C to Lisp. Make non-blocking method calls
1322 the default. Implement further D-Bus standard interfaces.
1324 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1325 (QCdbus_request_name_allow_replacement)
1326 (QCdbus_request_name_replace_existing)
1327 (QCdbus_request_name_do_not_queue)
1328 (QCdbus_request_name_reply_primary_owner)
1329 (QCdbus_request_name_reply_in_queue)
1330 (QCdbus_request_name_reply_exists)
1331 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1332 (QCdbus_registered_serial, QCdbus_registered_method)
1333 (QCdbus_registered_signal): New Lisp objects.
1334 (XD_DEBUG_MESSAGE): Use sizeof.
1335 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1336 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1337 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1338 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1339 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1340 (xd_signature, xd_append_arg): Allow float for integer types.
1341 (xd_get_connection_references): New function.
1342 (xd_get_connection_address): Rename from xd_initialize.
1343 Return cached address.
1344 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1345 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1347 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1348 Return number of refcounts.
1349 (Fdbus_get_unique_name): Make stronger parameter check.
1350 (Fdbus_message_internal): New defun.
1351 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1352 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1353 (Fdbus_send_signal, Fdbus_register_service)
1354 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1355 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1356 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1357 (Vdbus_compiled_version, Vdbus_runtime_version)
1358 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1359 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1360 (Vdbus_message_type_signal): New defvars.
1361 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1364 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1366 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1367 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1368 Do not assume ptrdiff_t is the same width as 'int'.
1370 * alloc.c: Handle unusual debugging option combinations.
1371 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1372 since the two debugging options are incompatible.
1373 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1375 (mem_init, mem_insert, mem_insert_fixup):
1376 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1377 (NEED_MEM_INSERT): Remove; no longer needed.
1379 2012-04-22 Leo Liu <sdl.web@gmail.com>
1381 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1383 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1385 * sysdep.c [__FreeBSD__]: Minor cleanups.
1386 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1387 Use Emacs indenting style more consistently. Avoid some casts.
1388 Use 'double' consistently rather than mixing 'float' and 'double'.
1390 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1392 * sysdep.c (list_system_processes, system_process_attributes):
1393 Add implementation for FreeBSD (Bug#5243).
1395 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1397 * lisp.mk (lisp): Update.
1399 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1401 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1402 It is never used otherwise.
1404 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1406 * print.c (print_preprocess): Only check print_depth if print-circle
1408 (print_object): Check for cycles even when print-circle is nil and
1409 print-gensym is t, but only check print_depth if print-circle is nil.
1411 2012-04-20 Chong Yidong <cyd@gnu.org>
1413 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1414 set the status to "failed" and ensure that sentinel is run.
1416 2012-04-20 Glenn Morris <rgm@gnu.org>
1418 * process.c (Fset_process_inherit_coding_system_flag)
1419 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1420 (Fmake_network_process, Fmake_serial_process): Doc fix.
1422 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1424 * xdisp.c (string_buffer_position_lim): Limit starting position to
1426 (set_cursor_from_row): If called for a mode-line or header-line
1427 row, return zero immediately.
1428 (try_cursor_movement): If inside continuation line, don't back up
1429 farther than the first row after the header line, if any.
1430 Don't consider the header-line row as "partially visible", even if
1431 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1433 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1435 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1438 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1439 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1441 configure: new option --enable-gcc-warnings (Bug#11207)
1442 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1443 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1444 (ALL_CFLAGS): Use new macros rather than old.
1445 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1446 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1447 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1448 -Wunused-result, -Wunused-variable. This should go away once
1449 the Emacs and Gnulib regex code is merged.
1450 (xmalloc, xrealloc): Now static.
1452 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1454 * dired.c (Fsystem_groups): Remove unused local.
1456 2012-04-17 Glenn Morris <rgm@gnu.org>
1458 * dired.c (Fsystem_users): Doc fix.
1460 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1462 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1463 (syms_of_dired): Add them.
1465 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1467 Fix minor alloc.c problems found by static checking.
1468 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1469 New extern decls, to avoid calling undeclared functions.
1470 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1471 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1472 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1473 (NEED_MEM_INSERT): New macro.
1474 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1475 Remove one incorrect comment and fix another.
1477 Fix minor ralloc.c problems found by static checking.
1478 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1479 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1480 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1481 (r_alloc_sbrk): Now static.
1483 Improve ralloc.c interface checking.
1484 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1485 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1486 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1487 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1488 [REL_ALLOC]: ... to here, to check interface.
1489 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1490 Remove decls. This fixes an "It stinks!".
1492 * alloc.c (which_symbols): Fix alignment issue / type clash.
1494 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1496 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1497 (struct Lisp_Misc_Any): Likewise.
1498 (struct Lisp_Free): Likewise.
1499 * alloc.c (union aligned_Lisp_Symbol): Define.
1500 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1501 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1502 (union aligned_Lisp_Misc): Define.
1503 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1504 aligned_Lisp_Misc instead of union Lisp_Misc.
1505 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1507 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1509 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1510 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1511 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1512 * s/netbsd.h, s/sol2-6.h:
1513 Remove definition of GC_MARK_STACK, since the default now works.
1514 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1515 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1516 no longer the default.
1517 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1519 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1521 * lread.c (lisp_file_lexically_bound_p):
1522 Fix hang at ";-*-\n" (bug#11238).
1524 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1526 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1527 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1529 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1531 * nsterm.m (constrainFrameRect): Always constrain when there is only
1532 one screen (Bug#10962).
1534 2012-04-13 Ken Brown <kbrown@cornell.edu>
1536 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1538 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1540 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1542 2012-04-11 Daniel Colascione <dancol@dancol.org>
1544 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1545 against is gone. It's better to use vfork now so that when Cygwin
1546 gains a new, working vfork, we use it automatically (bug#10398).
1548 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1550 * window.c (save_window_save): Obey window-point-insertion-type.
1552 2012-04-11 Glenn Morris <rgm@gnu.org>
1554 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1556 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1558 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1560 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1562 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1563 (force_quit_count): New var.
1564 (handle_interrupt): Use it.
1566 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1568 * w32.c (w32_delayed_load): Record the full path of the library
1569 being loaded (bug#10424).
1571 2012-04-09 Glenn Morris <rgm@gnu.org>
1573 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1574 not just in the obarray, before snarfing them. (Bug#11036)
1576 * Makefile.in ($(leimdir)/leim-list.el):
1577 Pass EMACS rather than BUILT_EMACS.
1579 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1581 * process.c (make_process):
1582 * process.h: Add integer `gnutls_handshakes_tried' member to
1585 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1586 Add convenience `GNUTLS_LOG2i' macro.
1588 * gnutls.c (gnutls_log_function2i): Convenience log function.
1589 (emacs_gnutls_read): Use new log functions,
1590 `gnutls_handshakes_tried' process member, and
1591 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1592 attempts per process (connection).
1594 2012-04-09 Chong Yidong <cyd@gnu.org>
1596 * eval.c (Fuser_variable_p, user_variable_p_eh)
1597 (lisp_indirect_variable): Functions deleted.
1598 (Fdefvar): Caller changed.
1600 * callint.c (Finteractive, Fcall_interactively):
1601 * minibuf.c (Fread_variable): Callers changed.
1603 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1605 * xdisp.c (set_cursor_from_row): If the display string appears in
1606 the buffer at position that is closer to point than the position
1607 after the display string, display the cursor on the first glyph of
1608 the display string. Fixes cursor display when a 'display' text
1609 property immediately follows invisible text. (Bug#11094)
1611 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1613 composite.c: use 'double' consistently
1614 * composite.c (get_composition_id): Use 'double' consistently
1615 instead of converting 'float' to 'double' and vice versa; this is
1616 easier to understand and avoids a GCC warning.
1618 2012-04-09 Glenn Morris <rgm@gnu.org>
1620 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1621 preparation for dumping it with emacs. (Bug#4789)
1622 (leimdir): New variable.
1623 ($(leimdir)/leim-list.el): New rule.
1624 (emacs$(EXEEXT)): Depend on leim-list.el.
1626 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1627 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1628 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1630 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1632 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1635 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1637 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1638 Remove unused local variable.
1640 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1642 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1643 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1644 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1645 objects, as mark_maybe_pointer will catch them otherwise.
1646 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1647 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1649 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1651 Fix typo that broke non-Windows builds.
1652 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1654 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1656 Support building on MS-Windows with libxml2.
1658 * makefile.w32-in (OBJ2): Add xml.$(O).
1659 (GLOBAL_SOURCES): Add xml.c.
1660 ($(BLD)/xml.$(O)): New dependency list.
1662 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1663 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1664 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1665 [!WINDOWSNT]: New macros.
1666 (init_libxml2_functions, libxml2_loaded_p): New functions.
1667 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1668 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1669 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1670 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1672 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1673 Call init_libxml2_functions before calling libxml2 functions.
1674 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1676 * emacs.c: Don't include libxml/parser.h.
1677 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1678 xmlCleanupParser directly.
1680 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1682 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1684 * indent.c (Fvertical_motion): If there is a display string at
1685 point, use it.vpos to compute how many lines to backtrack after
1686 move_it_to point. (Bug#11133)
1688 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1690 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1691 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1692 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1693 macros related to unification of CJK characters. For the details,
1694 see the discussion following the message here:
1695 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1697 2012-04-04 Chong Yidong <cyd@gnu.org>
1699 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1701 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1703 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1704 instead of alloca. (Bug#11138)
1706 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1708 * w32menu.c (is_simple_dialog): Properly check lisp types.
1711 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1713 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1714 position we get to after a call to move_it_to fails the
1715 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1716 only if we wind up in a string from display property. (Bug#11063)
1718 * window.c (Fdelete_other_windows_internal): Invalidate the row
1719 and column information about mouse highlight, so that redisplay
1720 restores it after reallocating the glyph matrices. (Bug#7464)
1722 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1723 string comes from a `display' text property, use the buffer
1724 position of that property as if we actually saw that position in
1726 (move_it_by_lines): Remove the assertion that
1727 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1728 violated when there's a before-string at the beginning of a line.
1731 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1733 * xdisp.c (append_space_for_newline): If the default face was
1734 remapped, use the remapped face for the appended newline.
1735 (extend_face_to_end_of_line): Use the remapped default face for
1736 extending the face to the end of the line.
1737 (display_line): Call extend_face_to_end_of_line when the default
1738 face was remapped. (Bug#11068)
1740 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1742 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1744 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1746 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1748 2012-03-27 Glenn Morris <rgm@gnu.org>
1750 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1753 2012-03-26 Kenichi Handa <handa@m17n.org>
1755 * dispextern.h (struct glyph): Fix previous change. Change the
1756 bit length of glyphless.ch to 25 (Bug#11082).
1758 2012-03-26 Chong Yidong <cyd@gnu.org>
1760 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1761 (command_loop_1): Use it; inhibit selection update for
1762 handle-select-window too (Bug#8996).
1764 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1766 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1768 2012-03-25 Kenichi Handa <handa@m17n.org>
1770 * dispextern.h (struct glyph): Change the bit length of
1771 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1773 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1775 * s/ms-w32.h (tzname): Include time.h before redirecting to
1776 _tzname. Fixes the MSVC build. (Bug#9960)
1778 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1780 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1783 * xterm.c (XTread_socket): Only modify handling_signal if
1784 !SYNC_INPUT. (Bug#11080)
1786 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1788 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1789 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1790 when fetching a multibyte character consumes more bytes than
1791 CHAR_BYTES returns, due to unification of CJK characters in
1792 string_char. (Bug#11073)
1794 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1796 * process.c (wait_reading_process_output): Handle pty disconnect
1797 by refraining from sending oneself a SIGCHLD (bug#10933).
1799 2012-03-22 Chong Yidong <cyd@gnu.org>
1801 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1803 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1804 Mark string as coming from a prefix property.
1805 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1806 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1808 2012-03-21 Chong Yidong <cyd@gnu.org>
1810 * xfaces.c (Vface_remapping_alist): Doc fix.
1812 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1814 * w32proc.c (Fw32_set_console_codepage)
1815 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1818 2012-03-20 Chong Yidong <cyd@gnu.org>
1820 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1821 to reflect default non-nil value of redisplay-dont-pause.
1823 2012-03-19 Kenichi Handa <handa@m17n.org>
1825 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1826 it fit in a valid range (Bug#11003).
1828 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1831 that is not from display property, accept the row as a "cursor
1832 row" if one of the string's character has a non-nil `cursor'
1833 property. Fixes cursor positioning when there are newlines in
1834 overlay strings, e.g. in icomplete.el. (Bug#11035)
1836 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1838 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1840 2012-03-12 Chong Yidong <cyd@gnu.org>
1842 * eval.c (inhibit_lisp_code): Rename from
1843 inhibit_window_configuration_change_hook; move from window.c.
1845 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1846 * window.c (run_window_configuration_change_hook)
1847 (syms_of_window): Callers changed.
1849 2012-03-11 Chong Yidong <cyd@gnu.org>
1851 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1853 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1855 2012-03-10 Chong Yidong <cyd@gnu.org>
1857 * frame.c (other_visible_frames): Don't assume the selected frame
1858 is visible (Bug#10955).
1860 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1862 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1864 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1866 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1867 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1870 2012-03-03 Glenn Morris <rgm@gnu.org>
1872 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1874 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1876 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1877 position past the first glyph_row that ends at ZV. (Bug#10902)
1878 (redisplay_window, next_element_from_string): Fix typos in
1880 (redisplay_window): Pass to move_it_vertically the margin in
1881 pixels, not in screen lines.
1883 2012-03-02 Glenn Morris <rgm@gnu.org>
1885 * buffer.c (buffer-list-update-hook): Doc fix.
1887 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1889 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1890 push_it before setting up the iterator for the first overlay
1891 string, even if we have an empty string loaded.
1892 (next_overlay_string): If there's an empty string on the iterator
1893 stack, pop the stack. (Bug#10903)
1895 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1897 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1898 Suggested by Stefan Monnier in
1899 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1900 * alloc.c (widen_to_Lisp_Object): New static function.
1901 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1902 and widening them to Lisp_Objects. This would work even if
1903 USE_LSB_TAG is defined and wide integers are used, which might
1904 happen in a future version of Emacs.
1906 2012-02-25 Chong Yidong <cyd@gnu.org>
1908 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1911 * xselect.c (Fx_selection_exists_p): Doc fix.
1912 (x_clipboard_manager_save_all): Print an informative message
1913 before saving to clipboard manager.
1915 2012-02-24 Chong Yidong <cyd@gnu.org>
1917 * keyboard.c (process_special_events): Handle all X selection
1918 requests in kbd_buffer, not just the next one (Bug#8869).
1920 2012-02-23 Chong Yidong <cyd@gnu.org>
1922 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1923 call when setting menu-bar-lines and tool-bar-lines parameters.
1924 (unwind_create_frame_1): New helper function.
1926 * window.c (inhibit_window_configuration_change_hook): New var.
1927 (run_window_configuration_change_hook): Obey it.
1928 (syms_of_window): Initialize it.
1930 2012-02-22 Chong Yidong <cyd@gnu.org>
1932 * xterm.c (x_draw_image_relief): Add missing type check for
1933 Vtool_bar_button_margin (Bug#10743).
1935 2012-02-21 Chong Yidong <cyd@gnu.org>
1937 * fileio.c (Vfile_name_handler_alist): Doc fix.
1939 * buffer.c (Fget_file_buffer): Protect against invalid file
1940 handler return value.
1942 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1944 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1945 when computing $valmask.
1947 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1948 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1949 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1950 It's useless in that case, and it can cause problems on hosts
1951 that allocate halves of EMACS_INT values separately.
1952 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1953 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1954 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1955 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1956 it avoids undefined behavior on hosts where shifting right by more
1957 than the word width has undefined behavior.
1959 2012-02-19 Chong Yidong <cyd@gnu.org>
1961 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1962 (Funhandled_file_name_directory, Ffile_name_as_directory)
1963 (Fdirectory_file_name, Fexpand_file_name)
1964 (Fsubstitute_in_file_name): Protect against invalid file handler
1965 return values (Bug#10845).
1967 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1969 * .gdbinit (pitx): Fix incorrect references to fields of the
1972 2012-02-17 Chong Yidong <cyd@gnu.org>
1974 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1976 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1978 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1979 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1981 2012-02-15 Chong Yidong <cyd@gnu.org>
1983 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1984 marked as special. Also, starting docstrings with * is obsolete.
1986 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1988 * gnutls.c (emacs_gnutls_write): Fix last change.
1990 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1992 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1995 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1997 * keymap.c (Fsingle_key_description): Handle char ranges.
1999 2012-02-12 Chong Yidong <cyd@gnu.org>
2001 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2002 as that creates a dangerous corner case.
2004 * window.c (Fdelete_window_internal): Invalidate the mouse
2005 highlight (Bug#9904).
2007 2012-02-12 Glenn Morris <rgm@gnu.org>
2009 * xselect.c (Fx_own_selection_internal)
2010 (Fx_get_selection_internal, Fx_disown_selection_internal)
2011 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2012 * nsselect.m (Fx_own_selection_internal)
2013 (Fx_disown_selection_internal, Fx_selection_exists_p)
2014 (Fx_selection_owner_p, Fx_get_selection_internal):
2015 Sync docs and argument specs with the xselect.c versions.
2017 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2019 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2021 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2023 * w32select.c (Fx_selection_exists_p): Sync doc string and
2024 argument list with xselect.c. (Bug#10783)
2026 * w16select.c (Fx_selection_exists_p): Sync doc string and
2027 argument list with xselect.c. (Bug#10783)
2029 2012-02-10 Glenn Morris <rgm@gnu.org>
2031 * fns.c (Fsecure_hash): Doc fix.
2033 2012-02-09 Kenichi Handa <handa@m17n.org>
2035 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2037 2012-02-07 Chong Yidong <cyd@gnu.org>
2039 * buffer.c (Fbuffer_local_variables)
2040 (buffer_lisp_local_variables): Handle unbound vars correctly;
2041 don't let Qunbound leak into Lisp.
2043 2012-02-07 Glenn Morris <rgm@gnu.org>
2045 * image.c (Fimagemagick_types): Doc fix.
2047 * image.c (imagemagick-render-type): Change it from a lisp object
2048 to an integer. Move the doc here from the lisp manual.
2049 Treat all values not equal to 0 the same.
2051 2012-02-06 Chong Yidong <cyd@gnu.org>
2053 * doc.c (store_function_docstring): Avoid applying docstring of
2054 alias to base function (Bug#2603).
2056 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2058 * .gdbinit (pp1, pv1): Remove redundant defines.
2061 2012-02-04 Chong Yidong <cyd@gnu.org>
2063 * nsterm.m: Declare a global (Bug#10694).
2065 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2067 * w32.c (get_emacs_configuration_options):
2068 Include --enable-checking, if specified, in the return value.
2070 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2072 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2073 after rounding frame sizes. (Bug#9723)
2075 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2077 * keyboard.c (adjust_point_for_property): Don't position point
2078 before BEGV. (Bug#10696)
2080 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2082 Handle overflow when computing char display width (Bug#9496).
2083 * character.c (char_width): Return EMACS_INT, not int.
2084 (char_width, c_string_width): Check for overflow when
2085 computing the width; this is possible now that individual
2086 characters can have unbounded width. Problem introduced
2087 by merge from Emacs 23 on 2012-01-19.
2089 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2091 * dbusbind.c (Fdbus_register_method): Mention the return value
2092 :ignore in the docstring.
2094 2012-02-02 Glenn Morris <rgm@gnu.org>
2096 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2098 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2099 Unconditionally set to t. (Bug#10673)
2100 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2101 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2102 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2104 2012-02-02 Kenichi Handa <handa@m17n.org>
2106 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2107 0, do not call append_composite_glyph.
2109 2012-02-02 Kenichi Handa <handa@m17n.org>
2111 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2113 (x_produce_glyphs): If the component of a composition is a null
2114 string, set it->pixel_width to 1 to avoid zero-width glyph.
2116 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2118 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2119 first 2 arguments are identical. This makes inserting large
2120 output from a subprocess an order of magnitude faster on
2121 MS-Windows, where all sbrk'ed memory is always contiguous.
2123 2012-01-31 Glenn Morris <rgm@gnu.org>
2125 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2126 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2127 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2129 2012-01-29 Glenn Morris <rgm@gnu.org>
2131 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2133 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2135 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2137 2012-01-28 Chong Yidong <cyd@gnu.org>
2139 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2141 2012-01-26 Chong Yidong <cyd@gnu.org>
2143 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2145 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2146 repeat counts (Bug#10507).
2148 2012-01-26 Glenn Morris <rgm@gnu.org>
2150 * lread.c (syms_of_lread): Doc fix.
2152 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2154 * coding.c (encode_designation_at_bol): Change return value to
2157 2012-01-25 Chong Yidong <cyd@gnu.org>
2159 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2161 2012-01-21 Chong Yidong <cyd@gnu.org>
2163 * floatfns.c (Fcopysign): Make the second argument non-optional,
2164 since nil is not allowed anyway.
2166 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2168 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2169 (send_process): Likewise.
2171 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2173 * window.c (save_window_save, Fcurrent_window_configuration)
2174 (Vwindow_persistent_parameters): Do not use Qstate.
2175 Rewrite doc-strings.
2177 2012-01-19 Kenichi Handa <handa@m17n.org>
2179 * character.c (char_width): New function.
2180 (Fchar_width, c_string_width, lisp_string_width):
2181 Use char_width (Bug#9496).
2183 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2185 * window.c (Vwindow_persistent_parameters): New variable.
2186 (Fset_window_configuration, save_window_save): Handle persistent
2189 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2191 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2192 thrashing the stack of the thread. (Bug#9087)
2194 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2196 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2198 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2200 * xdisp.c (rows_from_pos_range): Handle the case where the
2201 highlight ends on a newline. (Bug#10464)
2202 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2203 he end column for display of highlight that ends on a newline
2206 2012-01-11 Glenn Morris <rgm@gnu.org>
2208 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2209 from load-path also when installation-directory is nil. (Bug#10208)
2211 2012-01-10 Glenn Morris <rgm@gnu.org>
2213 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2215 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2216 Update template values to be closer to their typical values these days.
2218 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2220 * xdisp.c (rows_from_pos_range): Accept additional argument
2221 DISP_STRING, and accept any glyph in a row whose object is that
2222 string as eligible for mouse highlight. Fixes mouse highlight of
2223 display strings from overlays. (Bug#10464)
2225 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2227 emacs: fix an auto-save permissions race condition (Bug#10400)
2228 * fileio.c (auto_saving_dir_umask): New static var.
2229 (Fmake_directory_internal): Use it.
2230 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2231 creating the directory. The old code temporarily assigns
2232 too-generous permissions to the directory.
2233 (do_auto_save_eh): Clear it.
2234 (Fdo_auto_save): Catch all errors, not just file errors, so
2235 that the var is always cleared.
2237 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2239 * search.c (scan_buffer): Pass character positions to
2240 know_region_cache, not byte positions. (Bug#6540)
2242 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2244 * w32.c (sys_rename): Report EXDEV when rename of a directory
2245 fails because the target is on another logical disk. (Bug#10284)
2247 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2249 * xterm.c (x_embed_request_focus): New function.
2251 * xterm.h: Add prototype.
2253 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2255 2012-01-05 Glenn Morris <rgm@gnu.org>
2257 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2259 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2261 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2262 Load gnutls_transport_set_lowat only if GnuTLS version is below
2264 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2265 GnuTLS versions below 2.11.1.
2267 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2269 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2270 to the doc string advising against its use for altering the way
2271 windows are scrolled.
2273 2011-12-28 Kenichi Handa <handa@m17n.org>
2275 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2276 coding-system ASCII compatible only when it does not produce BOM
2277 on encoding (Bug#10383).
2279 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2281 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2283 (create_and_show_popup_menu): Always use menu_position_func for
2286 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2288 * callint.c (Fcall_interactively): Don't truncate prompt string.
2290 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2292 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2293 property that ends at ZV, so that the bidi iteration could be
2294 resumed from there (after widening). (Bug#10360)
2296 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2298 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2300 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2302 * nsterm.m (x_free_frame_resources):
2303 Release f->output_data.ns->miniimage.
2304 (ns_index_color): Fix indentation. Do not retain
2305 color_table->colors[i].
2307 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2310 * nsfns.m (x_set_background_color): Assign return value from
2311 ns_index_color to face-background instead of NSColor*.
2312 (ns_implicitly_set_icon_type): Fix indentation.
2313 Change assignment in for loop to comparison.
2315 * emacs.c (ns_pool): New variable.
2316 (main): Assign ns_pool.
2317 (Fkill_emacs): Call ns_release_autorelease_pool.
2319 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2320 autorelease fdesc, release fdAttrs and tdict.
2321 (ns_get_covering_families): Release charset.
2322 (ns_findfonts): Release NSFontDescriptor created with new.
2323 (ns_uni_to_glyphs): Fix indentation.
2324 (setString): Release attrStr before assigning new value.
2326 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2328 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2330 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2331 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2333 2011-12-18 David Reitter <reitter@cmu.edu>
2335 * nsterm.m (ns_term_init): Subscribe for notifications
2336 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2337 to method trackingNotification in EmacsMenu.
2339 * nsmenu.m (trackingMenu): New variable.
2340 (trackingNotification): New method (from Aquamacs).
2341 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2342 from Aquamacs (Bug#7030).
2344 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2346 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2347 (symbol_to_nsstring): Fix indentation.
2348 (ns_symbol_to_pb): New function.
2349 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2350 (Fns_rotate_cut_buffers_internal): Remove.
2351 (Fns_store_selection_internal): Rename from
2352 Fns_store_cut_buffer_internal.
2353 (ns_get_foreign_selection, Fx_own_selection_internal)
2354 (Fx_disown_selection_internal, Fx_selection_exists_p)
2355 (Fns_get_selection_internal, Fns_store_selection_internal):
2356 Use ns_symbol_to_pb and check if return value is nil.
2357 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2358 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2359 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2360 renamed to Sns_store_selection_internal.
2361 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2362 and remove this function.
2363 (ns_handle_selection_clear): Remove, never used.
2364 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2367 2011-12-17 Ken Brown <kbrown@cornell.edu>
2369 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2370 GID is unknown (Bug#10257).
2372 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2374 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2375 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2376 which caused a build failure on GNU/Linux IA-64. This problem was
2377 introduced by my 2011-10-07 patch.
2379 2011-12-15 Juri Linkov <juri@jurta.org>
2381 * image.c (imagemagick_error): New function. (Bug#10112)
2382 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2383 Use `imagemagick_error' where ImageMagick functions return
2385 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2388 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2390 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2391 fill background (Bug#8992).
2393 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2395 * window.c (Vwindow_combination_resize)
2396 (Vwindow_combination_limit): Use t instead of non-nil in
2398 (Vrecenter_redisplay): Add first sentence of doc-string on
2400 (Frecenter): Fix doc-string typo.
2402 2011-12-11 Kenichi Handa <handa@m17n.org>
2404 * coding.c (Funencodable_char_position): Pay attention to the
2405 buffer text relocation (Bug#9389).
2407 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2409 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2410 gtk_init (Bug#10100).
2412 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2414 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2415 IT->string is nil. (Bug#10263)
2417 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2419 * nsterm.h (x_free_frame_resources): Declare.
2421 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2422 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2424 * nsterm.h (ns_get_defaults_value): Declare.
2426 * nsterm.m (ns_default): Call ns_get_defaults_value.
2428 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2430 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2433 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2435 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2436 that where the value of an _OBJC_* symbol points to is in the .bss
2437 section (Bug#10240).
2439 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2441 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2442 after the loop to call ccl_driver at least once (Bug#8619).
2444 2011-12-08 Kenichi Handa <handa@m17n.org>
2446 * ftfont.c (get_adstyle_property): Fix previous change
2449 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2451 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2452 dirs from the default value of EMACSLOADPATH (bug#10208).
2454 2011-12-07 Glenn Morris <rgm@gnu.org>
2456 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2457 installation and source directories as well. (Bug#10208)
2459 2011-12-06 Chong Yidong <cyd@gnu.org>
2461 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2463 2011-12-06 Glenn Morris <rgm@gnu.org>
2465 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2466 as an error, not just -1. (Bug#10217)
2468 2011-12-05 Chong Yidong <cyd@gnu.org>
2470 * keyboard.c (process_special_events): New function.
2471 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2473 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2475 * coding.c (encode_designation_at_bol): Don't use uninitialized
2476 local variable (Bug#9318).
2478 2011-12-05 Kenichi Handa <handa@m17n.org>
2480 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2481 return Qnil (Bug#8046, Bug#10193).
2483 2011-12-05 Kenichi Handa <handa@m17n.org>
2485 * coding.c (encode_designation_at_bol): New args charbuf_end and
2486 dst. Return the number of produced bytes. Callers changed.
2487 (coding_set_source): Return how many bytes coding->source was
2489 (coding_set_destination): Return how many bytes
2490 coding->destination was relocated.
2491 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2492 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2494 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2496 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2497 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2500 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2502 The following changes are to fix Bug#9318.
2504 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2505 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2506 (encode_coding_iso_2022, encode_coding_sjis)
2507 (encode_coding_big5, encode_coding_charset): Use the above macros.
2509 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2511 * lisp.h (process_quit_flag): Fix external declaration.
2513 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2515 Don't macro-inline non-performance-critical code.
2516 * eval.c (process_quit_flag): New function.
2517 * lisp.h (QUIT): Use it.
2519 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2521 * nsfns.m (get_geometry_from_preferences): New function.
2522 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2524 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2526 * emacs.c (Qkill_emacs): Define.
2527 (syms_of_emacs): Initialize it.
2528 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2529 Qquit_flag to `kill-emacs' instead.
2530 (quit_throw_to_read_char): Add parameter `from_signal'.
2531 All callers changed. Call Fkill_emacs if requested and safe.
2532 * lisp.h (QUIT): Call Fkill_emacs if requested.
2534 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2536 * widget.c (update_wm_hints): Return if wmshell is null.
2537 (widget_update_wm_size_hints): New function.
2539 * widget.h (widget_update_wm_size_hints): Declare.
2541 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2542 widget_update_wm_size_hints (Bug#10104).
2544 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2546 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2547 before a newline, prepare the bidi iterator for consuming the
2548 newline, and keep the current paragraph direction. (Bug#10183)
2549 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2551 2011-12-02 Juri Linkov <juri@jurta.org>
2553 * search.c (Fword_search_regexp): New Lisp function created from
2554 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2555 (Fword_search_backward, Fword_search_forward)
2556 (Fword_search_backward_lax, Fword_search_forward_lax):
2557 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2558 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2560 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2562 * fileio.c (Finsert_file_contents): Move after-change-function call
2563 to before the "handled:" label, since all "goto handled" appear in
2564 cases where the *-change-functions have already been properly called
2567 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2569 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2570 waiting for input. (Bug#10169)
2572 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2574 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2575 verifies glyph row's hash code--we have just reallocated the
2576 glyphs, so their contents can be complete garbage. (Bug#10164)
2578 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2580 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2582 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2584 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2585 attributes are tested _before_ calling verify_row_hash, to protect
2586 against GCC re-ordering of the tests. (Bug#10164)
2588 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2590 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2592 * xterm.c (handle_one_xevent): Only set async_visible and friends
2593 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2594 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2595 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2597 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2599 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2600 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2601 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2602 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2603 All uses changed to use GCPRO1 etc.
2604 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2605 Revert to old implementation (i.e., before 2011-03-11).
2607 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2609 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2610 of scroll runs so as to avoid assigning disabled bogus rows and
2611 unnecessary graphics copy operations.
2613 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2615 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2616 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2617 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2618 (malloc, free, realloc, calloc): Redirect to e_* only when
2621 * lisp.h (GCTYPEBITS): Move before first use.
2622 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2623 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2624 this macro definition.
2626 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2629 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2631 * gtkutil.c (xg_create_frame_widgets):
2632 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2633 present with Gtk+ 2.0.
2635 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2637 * fileio.c (Finsert_file_contents): Undo previous change; see
2638 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2640 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2642 Rename locals to avoid shadowing.
2643 * fileio.c (Finsert_file_contents):
2644 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2645 * process.c (wait_reading_process_output):
2646 Rename inner 'proc' to 'p' to avoid shadowing.
2647 Indent for consistency with usual Emacs style.
2649 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2651 * xdisp.c (redisplay_window): If cursor row is not fully visible
2652 after recentering, and scroll-conservatively is set to a large
2653 number, scroll window by a few more lines to make the cursor fully
2654 visible and out of scroll-margin. (Bug#10105)
2655 (start_display): Don't move to the next line if the display should
2656 start at a newline that is part of a display vector or an overlay
2659 2011-11-24 Juri Linkov <juri@jurta.org>
2661 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2662 after the `MagickPingImage' call. (Bug#10112)
2664 2011-11-23 Chong Yidong <cyd@gnu.org>
2666 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2668 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2670 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2671 making another buffer current. (Bug#10114)
2673 2011-11-23 Glenn Morris <rgm@gnu.org>
2675 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2677 2011-11-23 Chong Yidong <cyd@gnu.org>
2679 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2680 using it (Bug#5984).
2682 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2684 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2685 and header-lines, as they don't have one computed for them.
2688 * .gdbinit (prow): Make displayed values more self-explaining.
2689 Add row's hash code.
2691 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2693 * process.c (wait_reading_process_output): Fix asynchrounous
2694 GnuTLS socket handling on some versions of the GnuTLS library.
2695 (wait_reading_process_output): Add comment and URL.
2697 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2699 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2701 2011-11-21 Chong Yidong <cyd@gnu.org>
2703 * window.c (Fnext_window, Fprevious_window): Doc fix.
2705 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2707 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2709 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2711 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2713 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2715 * window.c (Fset_window_combination_limit): Rename argument
2717 (Vwindow_combination_limit): Remove "status" from doc-string.
2719 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2721 * m/ibms390.h: Remove.
2722 * m/ibms390x.h: Don't include "ibms390.h".
2724 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2726 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2727 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2729 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2731 * casetab.c (Fset_case_table):
2732 * charset.c (Fcharset_after): Fix typos.
2734 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2736 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2737 Otherwise, valgrind does not work on some platforms.
2738 Problem reported by Andreas Schwab in
2739 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2740 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2741 is set, removing the need for VIRT_ADDRESS_VARIES.
2742 (PURE_P): Use a more-efficient implementation that needs just one
2743 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2744 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2745 to 4 (xorl, subq, cmpq, setbe).
2746 * alloc.c (pure): Always extern now, since that's the
2747 VIRT_ADDR_VARIES behavior.
2748 (PURE_POINTER_P): Use a single comparison, not two, for
2749 consistency with the new puresize.h.
2750 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2751 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2752 Remove VIRT_ADDR_VARIES no longer needed.
2754 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2756 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2757 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2758 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2759 behave as if the cursor position were at the window margin.
2761 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2762 and the cursor position is out of bounds, behave as if the cursor
2763 position were at the window margin. (Bug#10075)
2765 2011-11-18 Chong Yidong <cyd@gnu.org>
2767 * window.c (Fwindow_combination_limit): Make first argument
2768 non-optional, since it is meaningless for live windows like the
2771 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2773 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2775 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2777 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2778 (graft_intervals_into_buffer): Simplify.
2780 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2782 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2783 hash values of the two rows.
2784 (copy_row_except_pointers): Preserve the used[] arrays and the
2785 hash values of the two rows. (Bug#10035)
2786 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2788 * xdisp.c (row_hash): New function, body extracted from
2789 compute_line_metrics.
2790 (compute_line_metrics): Call row_hash, instead of computing the
2793 * dispnew.c (verify_row_hash): Call row_hash for computing the
2794 hash code of a row, instead of duplicating code from xdisp.c.
2796 * dispextern.h (row_hash): Add prototype.
2798 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2800 * frame.c (delete_frame): Don't delete the terminal when the last
2801 X frame is closed if emacs is built with GTK toolkit.
2803 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2805 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2807 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2809 * window.c (Vwindow_splits): Rename to
2810 Vwindow_combination_resize. Suggested by Juri Linkov.
2811 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2814 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2816 * nsfns.m (Fns_font_name):
2817 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2819 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2821 * window.h (window): Rename slot "nest" to "combination_limit".
2822 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2823 (Fset_window_nest): Rename to Fset_window_combination_limit.
2824 (Vwindow_nest): Rename to Vwindow_combination_limit.
2825 (recombine_windows, make_parent_window, make_window)
2826 (Fsplit_window_internal, saved_window)
2827 (Fset_window_configuration, save_window_save): Rename all
2828 occurrences of window_nest to window_combination_limit.
2830 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2832 * image.c (imagemagick_load_image): Fix typo.
2834 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2836 * xdisp.c (display_line): Move the call to
2837 highlight_trailing_whitespace before the call to
2838 compute_line_metrics, since the latter needs to see the final
2839 faces of all the glyphs to compute ROW's hash value.
2840 Fixes assertion violations in row_equal_p. (Bug#10035)
2842 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2844 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2845 just return (bug#10044).
2847 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2849 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2850 with user-defined heap size. Bump the default size of the temacs
2851 heap to 27MB, to avoid memory warning when running temacs.
2852 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2854 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2855 current_matrix and desired_matrix. (Bug#9990)
2856 (verify_row_hash) [XASSERTS]: New function.
2857 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2858 that the hash value of glyph rows is correct.
2860 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2862 * window.h (window): Remove splits slot.
2863 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2864 (Fdelete_other_windows_internal, make_parent_window)
2865 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2866 (Fset_window_configuration, save_window_save): Don't deal with
2867 split status of windows.
2868 (saved_window): Remove splits slot.
2869 (Vwindow_splits): Rewrite doc-string.
2871 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2873 * xfns.c (unwind_create_frame):
2874 * nsfns.m (unwind_create_frame):
2875 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2876 Vframe_list (Bug#9999).
2878 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2880 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2882 2011-11-11 Kenichi Handa <handa@m17n.org>
2884 * callproc.c (Fcall_process): Set the member dst_multibyte of
2887 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2889 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2890 avoid a crash (bug#9496).
2892 2011-11-09 Chong Yidong <cyd@gnu.org>
2894 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2895 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2897 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2899 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2901 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2903 Avoid some portability problems by eschewing 'extern inline' functions.
2904 The trivial performance wins aren't worth the portability hassles; see
2905 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2907 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2908 (window_box_width, window_box_left, window_box_left_offset)
2909 (window_box_right, window_box_right_offset): Undo previous change,
2910 by removing the "extern"s.
2911 * intervals.c (adjust_intervals_for_insertion)
2912 (adjust_intervals_for_deletion): Undo previous change,
2913 making these static again.
2914 (offset_intervals, temp_set_point_both, temp_set_point)
2915 (copy_intervals_to_string): No longer inline.
2916 * xdisp.c (window_text_bottom_y, window_box_width)
2917 (window_box_height, window_box_left_offset)
2918 (window_box_right_offset, window_box_left, window_box_right)
2919 (window_box): No longer inline.
2921 2011-11-08 Chong Yidong <cyd@gnu.org>
2923 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2924 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2925 Signal an error if not a live window.
2926 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2927 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2929 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2931 * lisp.h (syms_of_abbrev): Remove declaration.
2932 Reported by CHENG Gao <chenggao@royau.me>.
2934 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2936 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2937 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2938 of temacs in GUI mode.
2940 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2942 * window.h: Declare delete_all_child_windows instead of
2943 delete_all_subwindows.
2944 * window.c (Fwindow_nest, Fset_window_nest)
2945 (Fset_window_new_total, Fset_window_new_normal)
2946 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2947 (delete_all_subwindows): Rename to delete_all_child_windows.
2948 (Fdelete_other_windows_internal, Fset_window_configuration):
2949 Call delete_all_child_windows instead of delete_all_subwindows.
2950 * frame.c (delete_frame): Call delete_all_child_windows instead
2951 of delete_all_subwindows.
2953 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2955 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2956 This is also needed for porting to any host where GC_MARK_STACK is
2957 not GC_MAKE_GCPROS_NOOPS.
2958 (which_symbols): Use it.
2960 2011-11-07 Kenichi Handa <handa@m17n.org>
2962 * coding.c (coding_set_destination): Check coding->src_pos only
2963 when coding->src_object is a buffer (bug#9910).
2965 * process.c (send_process): Set the member src_multibyte of coding
2966 to 0 (bug#9911) when sending a unibyte text.
2968 * callproc.c (Fcall_process): Set the member src_multibyte of
2969 process_coding to 0 (bug#9912).
2971 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2973 * xmenu.c (cleanup_widget_value_tree): New function.
2974 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2975 calling free_menubar_widget_value_tree directly (Bug#9830).
2977 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2979 Fix some portability problems with 'inline'.
2980 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2981 (window_box_width, window_box_left, window_box_left_offset)
2982 (window_box_right, window_box_right_offset): Declare extern.
2983 Otherwise, these inline functions do not conform to C99 and
2984 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2985 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2986 * intervals.c (adjust_intervals_for_insertion)
2987 (adjust_intervals_for_deletion): Now extern, because otherwise the
2988 extern inline functions 'offset_intervals' couldn't refer to it.
2989 (static_offset_intervals): Remove.
2990 (offset_intervals): Rewrite using the old contents of
2991 static_offset_intervals. The old version didn't conform to C99
2992 because an extern inline function contained a reference to an
2993 identifier with static linkage.
2995 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2997 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3000 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3002 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3003 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3004 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3005 return Qleft_to_right.
3007 2011-11-06 Chong Yidong <cyd@gnu.org>
3009 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3010 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3011 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3012 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3013 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3014 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3015 (Fwindow_vscroll): Doc fix.
3016 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3017 argument, since it makes no sense to pass a live window and for
3018 consistency with window-child.
3020 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3022 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3025 2011-11-05 Jason Rumney <jasonr@gnu.org>
3027 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3028 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3030 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3031 bitwise arithmetic preventing use of unicode-sip and non-truetype
3034 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3036 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3039 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3040 initialization code to keep similarity to xfns.c after changes
3043 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3045 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3046 (unwind_create_frame): New function (Bug#9943).
3047 (Fx_create_frame): Restructure code to be more similar to the one in
3048 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3049 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3050 Move terminal->reference_count++ just before making the frame official
3053 * nsterm.m (x_free_frame_resources): New function.
3054 (x_destroy_window): Move code to x_free_frame_resources.
3056 * xfns.c (unwind_create_frame): Fix comment.
3057 (Fx_create_frame, x_create_tip_frame):
3058 Move terminal->reference_count++ just before making the frame
3059 official. Move initialization of image_cache_refcount and
3060 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3062 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3064 Support MSVC build with newer versions of Visual Studio.
3065 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3066 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3069 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3070 which are not supported by MSVC.
3071 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3072 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3074 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3076 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3078 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3080 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3082 Support MSVC build with newer versions of Visual Studio.
3083 * w32.c: Don't include w32api.h for MSVC.
3084 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3086 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3087 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3088 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3089 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3091 (alloca) [_MSC_VER]: Define to _alloca.
3093 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3095 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3097 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3099 * xdisp.c (note_mouse_highlight): If either of
3100 previous/next-single-property-change returns nil, treat that as
3101 the beginning or the end of the buffer. (Bug#9955)
3103 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3105 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3106 label is not null (Bug#9951).
3107 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3110 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3112 * window.c (Fwindow_body_size): Mention in the doc string that the
3113 return value is in frame's canonical units. (Bug#9949)
3115 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3117 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3119 * w32fns.c (unwind_create_frame): If needed, free the glyph
3120 matrices of the partially constructed frame. (Bug#9943)
3121 * xfns.c (unwind_create_frame): Likewise.
3123 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3125 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3126 Don't stop backward scan on the continuation glyph, even though
3127 its CHARPOS is positive.
3128 (mouse_face_from_buffer_pos, note_mouse_highlight):
3129 Rename cover_string to disp_string.
3131 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3133 * window.c (temp_output_buffer_show): Don't use
3134 Vtemp_buffer_show_specifiers.
3135 (Vtemp_buffer_show_specifiers): Remove unused variable.
3137 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3139 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3140 past the beginning of the current glyph matrix.
3142 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3144 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3145 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3146 HAVE_GTK3 (Bug#9869).
3148 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3149 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3151 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3153 * xterm.c: Declare x_handle_net_wm_state to return int.
3154 (handle_one_xevent): Check if we are iconified but don't have
3155 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3156 (get_current_wm_state): Return non-zero if not hidden,
3157 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3158 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3159 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3160 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3162 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3164 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3165 so that this new function doesn't get optimized away by a
3166 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3168 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3170 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3172 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3174 Fix the `xbytecode' command.
3175 * .gdbinit (xprintbytestr): New command.
3176 (xwhichsymbols): Rename from `which'; all callers changed.
3177 (xbytecode): Print the byte-code string as well.
3179 2011-10-29 Kim Storm <storm@cua.dk>
3181 * alloc.c (which_symbols): New function.
3183 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3185 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3188 2011-10-29 Glenn Morris <rgm@gnu.org>
3190 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3191 Not clear what it was for, and it causes various bugs. (Bug#9839)
3193 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3195 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3196 possible random value that matches one of those tested as
3197 condition to clear the mouse face.
3199 2011-10-28 Chong Yidong <cyd@gnu.org>
3201 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3203 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3205 * window.c (make_window): Initialize phys_cursor_on_p.
3207 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3209 * lisp.h (struct Lisp_Symbol): Update comments.
3211 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3213 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3215 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3217 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3218 <oslsachem@gmail.com> for helping to debug this.
3220 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3221 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3222 (g_b_init_get_glyph_outline_w): New static variables.
3223 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3224 (GetGlyphOutlineW_Proc): New typedefs.
3225 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3226 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3228 (w32font_open_internal, compute_metrics):
3229 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3230 instead of calling the "wide" APIs directly.
3232 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3234 * w32.h (syms_of_w32font): Add prototype.
3236 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3238 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3239 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3240 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3241 (Fmove_to_window_line): Doc fix.
3243 2011-10-27 Chong Yidong <cyd@gnu.org>
3245 * process.c (make_process): Set gnutls_state to NULL.
3247 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3248 non-NULL, regardless of GNUTLS_INITSTAGE.
3249 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3250 an error. Set process slots as soon as we allocate them.
3252 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3254 2011-10-27 Chong Yidong <cyd@gnu.org>
3256 * gnutls.c (emacs_gnutls_deinit): New function.
3257 Deallocate credentials structures as well as calling gnutls_deinit.
3258 (Fgnutls_deinit, Fgnutls_boot): Use it.
3260 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3261 (deactivate_process): Call emacs_gnutls_deinit.
3263 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3265 * image.c (x_create_x_image_and_pixmap):
3266 * w32.c (sys_rename, w32_delayed_load):
3267 * w32font.c (fill_in_logfont):
3268 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3270 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3272 * w32fns.c (w32_default_color_map): New function,
3273 extracted from Fw32_default_color_map.
3274 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3276 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3278 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3280 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3282 * keyboard.c (test_undefined): New function (bug#9751).
3283 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3285 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3287 * sysdep.c (init_sys_modes): Fix the check for the controlling
3288 terminal (Bug#6649).
3290 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3292 * dispextern.h (struct bidi_it): New member next_en_type.
3294 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3295 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3296 current character, check also for next_en_type being WEAK_EN.
3297 (bidi_resolve_weak): Don't enter the expensive loop if the current
3298 position is before next_en_pos. Record the bidi type of the first
3299 non-ET, non-BN character we find, in addition to its position.
3300 (bidi_level_of_next_char): Invalidate next_en_type when
3301 next_en_pos is over-stepped.
3303 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3305 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3306 * editfns.c: Rewrite current-time-zone so that it invokes
3307 the equivalent of (format-time-string "%Z") to get the time zone name.
3308 This fixes a bug when the time zone name contains characters that
3309 need converting from the system time locale to Emacs internal format.
3310 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3311 that patch fixed format-time-string to do the conversion, but
3312 I forgot to fix current-time-zone.
3313 (format_time_string): New function, containing most of
3314 what Fformat_time_string used to contain.
3315 (Fformat_time_string): Rewrite in terms of format_time_string.
3316 This doesn't change this function's behavior.
3317 (current-time-zone): Rewrite to use format_time_string.
3318 This fixes the bug reported by Michael Schierl in
3319 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3320 Jason Rumney's 2007-06-07 change worked around this bug, but
3322 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3324 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3326 * xdisp.c (start_display): If the character at POS is displayed
3327 via a display vector, reset IT->current.dpvec_index to zero.
3328 (try_window_reusing_current_matrix): If a line ends in a display
3329 vector or the next line starts in a display vector, continue
3330 redrawing the window even though the character position of
3331 start_row was reached.
3334 2011-10-18 Chong Yidong <cyd@gnu.org>
3336 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3337 with nobreak-char-display too.
3339 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3341 Fix part 3 of bug#9771.
3342 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3343 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3344 non-neutral characters if the current character is a paragraph
3345 separator (a.k.a. Newline). This avoids running the same
3346 expensive loop twice, once when we consume the preceding newline
3347 and the other time when the line actually needs to be displayed.
3348 Avoid the loop when we see neutrals on the base embedding level
3349 following a character whose directionality is the same as the
3350 paragraph's. This avoids running the expensive loop when a line
3351 ends in a long sequence of neutrals, like control characters.
3352 Add assertion against STRONG_AL type. Slightly rearrange code
3353 that determines the type of a neutral given the first non-neutral
3355 (bidi_level_of_next_char): Set next_en_pos to zero when
3356 invalidating its info.
3358 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3360 * xdisp.c (push_display_prop): Determine whether to record string
3361 or buffer position by IT->string, not by IT->method. Allow
3362 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3363 (move_it_vertically_backward): Don't look for character position
3364 immediately after the newline when in a continuation line.
3367 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3369 * window.c (coordinates_in_window): Rewrite and delabelize
3370 vertical border check. (Bug#5357) (Bug#9618)
3372 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3374 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3375 errors in XSetWindowBorder (bug#9310).
3377 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3379 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3380 avoid crash when xmalloc overrun checking is enabled.
3382 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3384 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3385 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3386 cursor motion with <left> and <right> arrow keys.
3388 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3389 some callers set that themselves.
3391 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3393 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3394 display string and the previous row comes from the same string and
3395 is empty. (Bug#9739) (Bug#9738)
3397 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3399 * doc.c (get_doc_string): Encode file name (bug#9735).
3401 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3403 * bidi.c (bidi_level_of_next_char):
3404 * xdisp.c (get_visually_first_element): Remove old incorrect
3405 comments regarding the Unicode Line Separator character.
3407 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3409 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3411 * alloc.c (Fgc_status): Do not access beyond zombies array
3412 boundary if nzombies > MAX_ZOMBIES.
3413 * alloc.c (dump_zombies): Add missing format specifier.
3415 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3417 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3418 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3420 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3421 Some packages use them to denote characters with modifiers.
3423 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3425 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3426 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3427 matching a pp-number. Rename parameter var to var1.
3429 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3431 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3433 2011-10-08 Glenn Morris <rgm@gnu.org>
3435 * callint.c (Fcall_interactively): Give a more explicit error for the
3436 'c' case with a non-character input. (Bug#8479)
3438 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3440 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3442 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3443 lines that are hscrolled on the left.
3445 * dispnew.c (buffer_posn_from_coords): Account for a possible
3446 presence of header-line. (Bug#4426)
3448 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3450 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3451 Don't advertise functionality which we discourage or doesn't work.
3453 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3455 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3456 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3457 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3458 this makes Emacs dump core during garbage collection on rare
3459 occasions. sizeof is obviously inferior to offsetof here, so
3460 stick with offsetof.
3461 (GC_POINTER_ALIGNMENT): New macro.
3462 (mark_memory): Omit 3rd (offset) arg; caller changed.
3463 Don't assume EMACS_INT alignment is the same as pointer alignment.
3465 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3467 * keyboard.c (read_key_sequence_remapped): New var.
3468 (read_key_sequence): Compute remapping in the right buffer.
3469 (command_loop_1): Use read_key_sequence's remapping directly.
3471 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3473 * dired.c (file_name_completion): Don't expand file name.
3474 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3475 before checking file name handler.
3477 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3478 they've been requested explicitly (bug#9591).
3480 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3482 * keymap.c (Fsingle_key_description): Use make_specified_string
3483 instead of build_string to build string from push_key_description.
3486 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3488 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3489 This fixes a Y2038 bug on 64-bit hosts.
3490 * buffer.c (reset_buffer):
3491 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3492 (Fclear_buffer_auto_save_failure):
3493 Use 0, not -1, to represent an unset failure time, since time_t
3494 might not be signed.
3496 Remove dependency on glibc malloc internals.
3497 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3498 Move back here from lisp.h, but with their new implementations.
3499 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3500 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3501 * charset.c (charset_table_init): New static var.
3502 (syms_of_charset): Use it instead of xmalloc. This removes a
3503 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3504 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3505 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3506 Move back to alloc.c.
3507 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3508 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3510 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3512 * nsterm.m (windowDidResize): Call x_set_window_size only when
3513 ns_in_resize is true. Otherwise set pixelwidth/height and
3514 call change_frame_size (Bug#9628).
3516 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3518 Port --enable-checking=all to Fedora 14 x86-64.
3519 * charset.c (syms_of_charset): Also account for glibc malloc's
3520 internal overhead when calculating the initial malloc maximum.
3522 Port --enable-checking=all to Fedora 14 x86.
3523 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3525 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3526 (overrun_check_realloc, overrun_check_free):
3527 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3528 That way, xmalloc returns a properly-aligned pointer even if
3529 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3530 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3531 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3532 into account when calculating the initial malloc maximum.
3533 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3534 Move here from alloc.c, so that charset.c can use it too.
3535 Properly align; the old code wasn't right for common 32-bit hosts
3536 when configured with --enable-checking=all.
3537 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3538 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3540 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3542 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3545 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3547 * xdisp.c (compute_display_string_end): If there's no display
3548 string at CHARPOS, return -1.
3550 * bidi.c (bidi_fetch_char): When compute_display_string_end
3551 returns a negative value, treat the character as a normal
3552 character not covered by a display string. (Bug#9624)
3554 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3556 * lread.c (Fread_from_string): Fix typo in docstring.
3558 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3560 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3561 newline, reseat the iterator instead of bidi-iterating there one
3562 character at a time. (Bug#9610)
3563 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3564 TO_CHARPOS if the bidi iterator is at base embedding level.
3566 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3568 * lread.c (readevalloop): Use correct code for NBSP.
3569 (read1): Likewise. (Bug#9608)
3571 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3573 * dbusbind.c (Fdbus_register_signal): When service is not
3574 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3576 2011-09-25 Glenn Morris <rgm@gnu.org>
3578 * buffer.c (truncate-lines): Doc fix.
3580 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3582 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3583 (Fset_window_next_buffers): Doc fix.
3585 2011-09-24 Glenn Morris <rgm@gnu.org>
3587 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3589 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3591 Fix minor problems found by static checking.
3592 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3593 * indent.c (Fvertical_motion): Fix == vs = typo.
3595 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3597 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3598 Default value is now t. Doc fix.
3600 * indent.c (Fvertical_motion): Compute and apply the overshoot
3601 logic when moving up, not only when moving down. Fix the
3602 confusing name and values of the it_overshoot_expected variable;
3603 logic changes accordingly. (Bug#9254) (Bug#9549)
3605 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3606 CHARPOS is covered by a display string which includes newlines.
3607 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3608 is covered by a display string with embedded newlines.
3610 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3612 * dbusbind.c (Fdbus_register_signal): Add match rule to
3613 Vdbus_registered_objects_table. (Bug#9581)
3614 (Fdbus_register_method, Vdbus_registered_objects_table):
3617 2011-09-24 Jim Meyering <meyering@redhat.com>
3619 do not ignore write error for any output size
3620 The previous change was incomplete.
3621 While it makes emacs --batch detect the vast majority of stdout
3622 write failures, errors were still ignored whenever the output size is
3623 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3624 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3625 && echo FAIL: ignored write error
3626 FAIL: ignored write error
3627 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3628 && echo FAIL: ignored write error
3629 FAIL: ignored write error
3630 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3632 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3634 * emacs.c (Fkill_emacs): In noninteractive mode exit
3635 non-successfully if a write error occurred on stdout. (Bug#9574)
3637 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3639 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3642 * dispextern.h (struct it): Update the comment documenting what
3645 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3647 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3648 a display string, extend search for cursor position to end of row.
3649 (find_row_edges): If the row ends in a newline from a display
3650 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3651 Handle the case of a display string with multiple newlines.
3652 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3653 non-empty line. Fixes confusing cursor motion with arrow keys at
3654 the beginning of a line that starts with whitespace.
3656 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3658 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3661 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3663 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3666 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3668 * xdisp.c (display_line): Record maximum and minimum buffer
3669 positions even if no glyphs were produced (e.g., by a zero-width
3670 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3671 buffer positions that will be removed from the glyph row because
3673 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3674 column is beyond frame width: don't subtract 1 "pixel" when
3675 computing width of the stretch.
3676 (reseat_at_next_visible_line_start): Undo the change made on
3677 2011-09-17 that saved paragraph information and restored it after
3678 the call to `reseat'. (Bug#9545)
3680 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3682 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3683 and turn window cursor on if cleared (Bug#9415).
3685 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3687 * search.c (boyer_moore): Take unibyte characters from pattern
3688 literally. (Bug#9458)
3690 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3692 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3694 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3696 Fix minor problem found by static checking.
3697 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3698 initialized, to pacify gcc -Wuninitialized.
3700 * fileio.c: Report proper errno when syscall falls.
3701 (Finsert_file_contents): Save and restore errno,
3702 so that report_file_error outputs the correct diagnostic.
3703 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3705 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3707 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3709 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3711 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3712 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3714 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3716 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3717 about the current paragraph and restore it after the call to reseat.
3719 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3720 (bidi_find_paragraph_start): Search back for paragraph beginning
3721 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3722 (bidi_move_to_visually_next): Only trigger paragraph-related
3723 computations when the last character is a newline or at EOB, not
3724 just any NEUTRAL_B. (Bug#9470)
3726 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3727 truncated lines if point is covered by a display string. (Bug#9524)
3729 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3731 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3732 (cons_to_x_long): New function.
3733 (lisp_data_to_selection_data): Use it. Correct the test for
3734 short-versus-long data; it was negated. Break out of vector
3735 loop, for efficiency, when a long datum is discovered.
3737 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3739 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3741 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3743 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3744 GCC PR/17406) by declaring this function with external scope.
3746 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3748 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3749 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3751 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3753 * editfns.c (Fformat): Correctly handle text properties on "%%".
3755 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3757 * xterm.c (x_draw_composite_glyph_string_foreground):
3758 * w32term.c (x_draw_composite_glyph_string_foreground):
3759 * term.c (encode_terminal_code):
3760 * composite.c (composition_update_it, get_composition_id):
3761 * xdisp.c (get_next_display_element)
3762 (fill_composite_glyph_string): Add comments about special meaning
3763 of TAB characters in a composition.
3765 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3767 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3768 This occurs when processing a multibyte format.
3769 Problem reported by Wolfgang Jenker.
3771 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3773 * xdisp.c (try_cursor_movement): Only check for exact match if
3774 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3776 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3778 Remove unused external symbols.
3779 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3780 * xdisp.c (calc_pixel_width_or_height): Now static.
3781 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3782 * indent.c (check_display_width):
3783 * w32term.c: Fix comment to match code.
3784 * xterm.c, xterm.h (x_catching_errors): Remove.
3786 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3788 * xselect.c: Use signed conversions more consistently (Bug#9498).
3789 (selection_data_to_lisp_data): Assume incoming selection data are
3790 signed integers, not unsigned. This is to be consistent with
3791 outgoing selection data, which was modified to use signed integers
3792 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3793 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3794 expects long, not unsigned long.
3796 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3798 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3799 computation of loop end. Reported by Johan Bockgård
3802 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3804 * frame.c (Fother_visible_frames_p): Function deleted.
3806 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3808 * indent.c (compute_motion): Process display vector front to back
3809 rather than the other way around. (Bug#2496)
3811 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3813 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3815 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3817 * minibuf.c (Fread_from_minibuffer): Doc fix.
3819 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3821 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3822 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3824 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3826 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3827 value for non-existent files.
3829 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3831 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3832 set its "size" to -1. This will set the modtime_size field of
3833 the corresponding buffer to -1, which is what
3834 verify-visited-file-modtime expects for files that do not exist.
3837 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3839 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3841 * lisp.h: ... from here. push_key_description is no longer
3842 defined in keyboard.c, so its declaration should not be in
3843 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3844 logically belongs with push_key_description.
3846 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3848 * buffer.h: Include <sys/types.h> instead of <time.h>.
3849 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3850 Problem reported by Herbert J. Skuhra.
3852 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3854 * xml.c (parse_region): Make the parsing work for
3855 non-comment-starting XML files again (bug#9144).
3857 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3859 * image.c (gif_load): Fix calculation of bottom and right corner.
3862 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3864 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3865 redisplay in small windows.
3867 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3869 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3871 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3873 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3874 Operate on live windows only.
3876 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3878 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3880 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3882 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3883 only under bidi iteration.
3885 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3887 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3889 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3891 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3892 Without this fix, the command to link temacs failed due to an
3893 undefined symbol __builtin_isnan. This is because
3894 /usr/include/iso/math_c99.h #defines isnan(x) to
3895 __builtin_isnan(x), but the bundled gcc, which identifies itself
3896 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3898 * floatfns.c (isnan): #undef, and then #define to a clone of
3900 (Fisnan): Always define, since it's always available now.
3901 (syms_of_floatfns): Always define isnan at the Lisp level.
3903 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3905 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3907 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3909 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3910 The previous code assumed that file offsets (off_t values) fit in
3911 EMACS_INT variables, which is not true on typical 32-bit hosts.
3912 The code messed up by falsely reporting buffer overflow in cases
3913 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3914 when "big" contains more than 2**29 bytes, even though this
3915 inserts just one byte and does not overflow the buffer.
3916 (Finsert_file_contents): Store file offsets as off_t
3917 values, not as EMACS_INT values. Check for overflow when
3918 converting between EMACS_INT and off_t. When checking for
3919 buffer overflow or for overlap, take the offsets into account.
3920 Don't use EMACS_INT for small values where int suffices.
3921 When checking for overlap, fix a typo: ZV was used where
3922 ZV_BYTE was intended.
3923 (Fwrite_region): Don't assume off_t fits into 'long'.
3924 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3926 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3928 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3930 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3932 sprintf-related integer and memory overflow issues (Bug#9412).
3934 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3935 (esprintf, exprintf, evxprintf): New functions.
3936 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3937 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3938 (modify_event_symbol): Do not assume that the length of
3939 name_alist_or_stem is safe to alloca and fits in int.
3940 (Fexecute_extended_command): Likewise for function name and binding.
3941 (Frecursion_depth): Wrap around reliably on integer overflow.
3942 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3943 since some callers pass EMACS_INT values.
3944 (Fsingle_key_description): Don't crash if symbol name contains more
3945 than MAX_ALLOCA bytes.
3946 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3947 (get_minibuffer): Arg is now EMACS_INT, not int.
3948 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3949 (esprintf, exprintf, evxprintf): New decls.
3950 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3952 * dbusbind.c (signature_cat): New function.
3953 (xd_signature, Fdbus_register_signal):
3954 Do not overrun buffer; instead, report string overflow.
3956 * dispnew.c (add_window_display_history): Don't overrun buffer.
3957 Truncate instead; this is OK since it's just a log.
3959 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3960 even if the time zone offset is outlandishly large.
3961 Don't mishandle offset == INT_MIN.
3963 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3964 when creating daemon; the previous buffer-overflow check was incorrect.
3966 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3967 which has the guts of the old verror function.
3969 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3970 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3972 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3973 (font_unparse_xlfd): Don't blindly alloca long strings.
3974 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3975 fits in int, when using sprintf. Use single snprintf to count
3976 length of string rather than counting it via multiple sprintfs;
3977 that's simpler and more reliable.
3978 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3979 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3980 sprintf, in case result does not fit in int.
3982 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3983 (fontset_from_font): Print it.
3985 * frame.c (tty_frame_count): Now printmax_t, not int.
3986 (make_terminal_frame, set_term_frame_name): Print it.
3987 (x_report_frame_params): In X, window IDs are unsigned long,
3988 not signed long, so print them as unsigned.
3989 (validate_x_resource_name): Check for implausibly long names,
3990 and don't assume name length fits in 'int'.
3991 (x_get_resource_string): Don't blindly alloca invocation name;
3992 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3995 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3996 (xg_check_special_colors, xg_set_geometry):
3997 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3999 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4000 Use esprintf, not sprintf, in case result does not fit in int.
4002 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4003 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4004 it as a large positive number.
4005 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4006 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4008 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4009 in case result does not fit in int.
4011 * print.c (float_to_string): Detect width overflow more reliably.
4012 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4013 buffer overrun. Don't assume list length fits in 'int'. Treat
4014 print length of 0 as 0, not as infinity; to be consistent with other
4015 uses of print length in this function. Don't overflow print length
4016 index. Don't assume hash table size fits in 'long', or that
4017 vectorlike size fits in 'unsigned long'.
4019 * process.c (make_process): Use printmax_t, not int, to format
4020 process-name gensyms.
4022 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4024 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4025 to avoid potential buffer overrun.
4027 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4028 if X resource line is longer than 512 bytes.
4030 * xfns.c (x_window): Make sprintf buffer a bit bigger
4031 to avoid potential buffer overrun.
4033 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4035 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4037 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4039 Integer overflow fixes for scrolling, etc.
4040 Without these, Emacs silently mishandles large integers sometimes.
4041 For example, "C-u 4294967297 M-x recenter" was treated as if
4042 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4044 * xdisp.c (try_window_id): Check Emacs fixnum range before
4045 converting to 'int'.
4047 * window.c (window_scroll_line_based, Frecenter):
4048 Check that an Emacs fixnum is in range before assigning it to 'int'.
4049 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4050 values converted from Emacs fixnums.
4051 (Frecenter): Don't wrap around a line count if it is out of 'int'
4052 range; instead, treat it as an extreme value.
4053 (Fset_window_configuration, compare_window_configurations):
4054 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4056 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4057 that can exceed INT_MAX. Check that EMACS_INT value is in range
4058 before assigning it to the (possibly-narrower) index.
4059 (match_limit): Don't assume that a fixnum can fit in 'int'.
4061 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4064 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4065 (Fvertical_motion): Don't wrap around LINES values that don't fit
4066 in 'int'. Instead, treat them as extreme values. This is good
4067 enough for windows, which can't have more than INT_MAX lines anyway.
4069 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4071 * Require libxml/parser.h to avoid compilation warning.
4073 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4075 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4076 since this reportedly can destroy thread storage.
4078 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4080 * syntax.c (find_defun_start): Update all cache variables if
4081 exiting early (Bug#9401).
4083 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4085 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4087 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4088 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4089 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4091 * term.c (tty_append_glyph): New function.
4092 (produce_stretch_glyph): Static function and its prototype deleted.
4094 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4097 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4099 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4100 when checking :margin (Bug#9390).
4101 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4102 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4103 so that the name doesn't mislead. All uses changed.
4105 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4107 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4110 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4112 * xdisp.c (move_it_to): Don't bail out early when reaching
4113 position beyond to_charpos, if we are scanning backwards.
4114 (move_it_vertically_backward): When DY == 0, make sure we get to
4115 the first character in the line after the newline.
4117 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4119 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4120 (ccl_driver): Do not generate an out-of-range pointer.
4121 (Fccl_execute_on_string): Remove unnecessary check for
4122 integer overflow, noted by Stefan Monnier in
4123 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4124 Remove a FIXME that didn't need fixing.
4125 Simplify the newly-introduced buffer reallocation code.
4127 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4129 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4131 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4133 Integer and memory overflow issues (Bug#9196).
4135 * doc.c (get_doc_string): Rework so that
4136 get_doc_string_buffer_size is the actual buffer size, rather than
4137 being 1 less than the actual buffer size; this makes xpalloc more
4140 * image.c (x_allocate_bitmap_record, cache_image):
4141 * xselect.c (Fx_register_dnd_atom):
4142 Simplify previous changes by using xpalloc.
4144 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4145 since either will do and ptrdiff_t is convenient with xpalloc.
4147 * charset.c (charset_table_size)
4148 (struct charset_sort_data.priority): Now ptrdiff_t.
4149 (charset_compare): Don't overflow if priorities differ greatly.
4150 (Fsort_charsets): Don't assume list length fits in int.
4151 Check for size-calculation overflow when allocating sort data.
4152 (syms_of_charset): Allocate an initial charset table that is
4153 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4155 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4157 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4158 The actual value is always <= INT_MAX, and leaving it unsigned made
4159 overflow checking harder.
4161 * dispextern.h (struct glyph_matrix.rows_allocated)
4162 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4163 with xpalloc. The values are still always <= INT_MAX.
4165 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4167 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4168 (SAFE_NALLOCA): New macro.
4170 * region-cache.c (struct boundary.pos, find_cache_boundary)
4171 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4172 (set_cache_region, invalidate_region_cache)
4173 (revalidate_region_cache, know_region_cache, region_cache_forward)
4174 (region_cache_backward, pp_cache):
4175 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4176 so that ptrdiff_t * can be passed to xpalloc.
4177 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4178 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4179 (pp_cache): Don't assume cache_len fits in int.
4180 * region-cache.h: Adjust extern decls to match.
4182 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4183 EMACS_INT, since either will do, for xpalloc.
4185 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4186 (xnmalloc, xnrealloc, xpalloc): New functions.
4188 * bidi.c (bidi_shelve_header_size): New constant.
4189 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4190 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4192 * bidi.c (bidi_cache_shrink):
4193 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4195 Don't update size of array until after memory allocation succeeds,
4196 because xmalloc/xrealloc may not return.
4197 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4198 now that we have proper integer overflow checking.
4199 (record_overlay_string, overlay_strings): Catch overflows when
4200 calculating size of overlay_str_buf.
4202 * callproc.c (Fcall_process): Check for size overflow when
4203 calculating size of args2.
4204 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4205 Normally we prefer signed values, but sticking with ptrdiff_t would
4206 require adding more-complicated checks.
4208 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4209 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4210 Redo buffer-overflow calculations to avoid integer overflow.
4211 Add a FIXME comment where memory seems to be over-allocated.
4213 * character.c (Fstring): Check for size-calculation overflow.
4215 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4216 unnecessary integer overflow. Check for size overflow.
4217 (encode_coding_object): Don't update size until xmalloc succeeds.
4219 * composite.c (get_composition_id): Check for overflow in glyph
4220 length calculations.
4222 Integer and memory overflow fixes for display code.
4223 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4224 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4225 (scrolling_window): Check for overflow in size calculations.
4226 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4227 Don't assume glyph table len fits in int.
4228 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4229 (row_table_size): Now ptrdiff_t, not int.
4230 (scrolling_window): Avoid overflow in size calculations.
4231 Don't update size until allocation succeeds.
4232 * fns.c (concat): Check for overflow in size calculations.
4233 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4234 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4235 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4237 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4238 (get_doc_string): Check for size calculation overflow.
4239 Don't update size until allocation succeeds.
4240 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4241 EMACS_INT, where ptrdiff_t will do.
4242 (Fsubstitute_command_keys): Check for string overflow.
4244 * editfns.c (set_time_zone_rule): Don't assume environment length
4246 (message_length): Now ptrdiff_t, not int.
4247 (Fmessage_box): Don't update size until allocation succeeds.
4248 Don't assume message length fits in int.
4249 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4251 * emacs.c (main): Do not reallocate argv, since there is a null at
4252 the end that can be overwritten, and this way there's no need to
4253 worry about size-calculation overflow.
4254 (sort_args): Check for size-calculation overflow.
4256 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4258 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4260 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4261 (x_set_scroll_bar_width, x_figure_window_size):
4262 Check for integer overflow.
4263 (x_set_alpha): Do not assume XINT fits in int.
4265 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4266 This is for the members text_lines, text_cols, total_lines, total_cols,
4267 where the system imposes an 'int' limit.
4269 * fringe.c (Fdefine_fringe_bitmap):
4270 Don't update size until alloc works.
4272 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4273 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4275 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4276 Check for size-calculation overflow.
4277 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4278 do, as we prefer signed integers.
4279 (id_to_widget.max_size, id_to_widget.used)
4280 (xg_store_widget_in_map, xg_remove_widget_from_map)
4281 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4282 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4283 Use and return ptrdiff_t, not int.
4284 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4285 * gtkutil.h: Change prototypes to match the above.
4287 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4288 are duplicate now that they've been promoted to lisp.h.
4289 (x_allocate_bitmap_record, x_alloc_image_color)
4290 (make_image_cache, cache_image, xpm_load):
4291 Don't update size until alloc is done.
4292 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4294 Check for size calculation overflow.
4295 (ct_colors_allocated_max): New constant.
4296 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4299 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4300 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4301 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4302 Use ptrdiff_t, not int, to count maps.
4303 (read_char_minibuf_menu_prompt): Check for overflow in size
4304 calculations. Don't update size until allocation succeeds.
4305 Redo calculations to avoid overflow.
4306 * keyboard.h: Change prototypes to match the above.
4308 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4310 (current_minor_maps): Check for size calculation overflow.
4311 * keymap.h: Change prototypes to match the above.
4313 * lread.c (read1, init_obarray): Don't update size until alloc done.
4315 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4316 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4318 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4319 Now ptrdiff_t, not int.
4320 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4321 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4323 * process.c (Fnetwork_interface_list): Check for overflow
4324 in size calculation.
4326 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4328 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4329 overflow. Don't bother calling xmalloc when xrealloc will do.
4331 * search.c (Freplace_match): Check for size calculation overflow.
4332 (Fset_match_data): Don't assume list lengths fit in 'int'.
4334 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4335 for command line length. Do not attempt to address one before the
4336 beginning of an array, as that's not portable.
4338 * term.c (max_frame_lines): Remove; unused.
4339 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4341 (encode_terminal_code, calculate_costs): Check for size
4342 calculation overflow.
4343 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4344 table lengths and related sizes. Don't update size until alloc
4345 done. Redo calculations to avoid overflow.
4346 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4348 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4349 subtracting pointers.
4350 (gobble_line): Check for overflow more carefully. Don't update size
4353 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4354 Don't update size until alloc done.
4355 Redo size calculations to avoid overflow.
4356 Check for size calculation overflow.
4357 (main) [DEBUG]: Fix typo in invoking tparam1.
4359 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4360 Use ptrdiff_t, not int, for sizes.
4361 (store_mode_line_noprop_char): Don't update size until alloc done.
4363 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4364 Use ptrdiff_t, not int, for sizes.
4365 (Finternal_make_lisp_face, cache_face):
4366 Check for size calculation overflow.
4367 (cache_face): Treat size calculation overflows as if they were
4368 memory exhaustion (the usual treatment), rather than aborting.
4370 * xfns.c (x_encode_text, x_set_name_internal)
4371 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4372 sizes, since they can exceed INT_MAX in size. Check for size
4373 calculation overflow.
4375 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4376 (xg_select): Check for size calculation overflow.
4377 Don't update size until alloc done.
4379 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4380 as sprintf is limited to int lengths.
4382 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4383 (X_LONG_MIN): New macros.
4384 Use them to make the following changes clearer.
4385 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4386 This change doesn't affect the value now, but it may help remind
4387 future maintainers not to raise the value too much later.
4388 (SELECTION_QUANTUM): Remove, replacing with ...
4389 (selection_quantum): ... new function, which avoids overflow.
4391 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4392 assumption that selection length fits in 'int'.
4393 (x_reply_selection_request, x_handle_selection_request)
4394 (x_get_window_property, receive_incremental_selection)
4395 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4396 (lisp_data_to_selection_data, clean_local_selection_data):
4397 Use ptrdiff_t, not int, to record length of selection.
4398 (x_reply_selection_request, x_get_window_property)
4399 (receive_incremental_selection, x_property_data_to_lisp):
4400 Redo calculations to avoid overflow.
4401 (x_reply_selection_request): When sending hint, ceiling it at
4402 X_LONG_MAX rather than relying on wraparound overflow to send
4404 (x_get_window_property, receive_incremental_selection)
4405 (lisp_data_to_selection_data, x_property_data_to_lisp):
4406 Check for size-calculation overflow.
4407 (x_get_window_property, receive_incremental_selection)
4408 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4409 Don't store size until memory allocation succeeds.
4410 (x_get_window_property): Plug memory leak on memory exhaustion.
4411 Don't double-block input; malloc is safe here. Don't assume 2**34
4412 - 4 fits in unsigned long. Add an xassert to check
4413 XGetWindowProperty overflow. Be more careful about overflow
4414 calculations, and distinguish size from memory overflow better.
4415 (receive_incremental_selection): When tracing, don't assume
4416 unsigned int is less than INT_MAX.
4417 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4418 harmful) conversions of unsigned short to int.
4419 (lisp_data_to_selection_data): Don't assume that integers
4420 in the range -65535 through -1 fit in an X unsigned short.
4421 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4422 result parameters unless successful. Rely on cons_to_unsigned
4423 to report problems with elements; the old code wasn't right anyway.
4424 (x_check_property_data): Check for int overflow; we cannot use
4425 a wider type due to X limits.
4426 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4428 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4430 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4431 (x_term_init): Check for size calculation overflow.
4432 (x_color_cells): Don't store size until memory allocation succeeds.
4433 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4434 Don't assume alloca size is less than MAX_ALLOCA.
4435 (x_term_init): Don't assume length fits in int (sprintf is limited
4438 Use ptrdiff_t for composition IDs.
4439 * character.c (lisp_string_width):
4440 * composite.c (composition_table_size, n_compositions)
4441 (get_composition_id, composition_gstring_from_id):
4442 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4443 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4444 * window.c (Frecenter):
4445 Use ptrdiff_t, not int, for composition IDs.
4446 * composite.c (get_composition_id): Check for integer overflow.
4447 * composite.h: Adjust prototypes to match the above changes.
4449 Use ptrdiff_t for hash table indexes.
4450 * category.c (hash_get_category_set):
4451 * ccl.c (ccl_driver):
4452 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4453 * coding.c (coding_system_charset_list, detect_coding_system):
4454 * coding.h (struct coding_system.id):
4455 * composite.c (get_composition_id, gstring_lookup_cache):
4456 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4457 * image.c (xpm_get_color_table_h):
4458 * lisp.h (hash_lookup, hash_put):
4459 * minibuf.c (Ftest_completion):
4460 Use ptrdiff_t for hash table indexes, not int (which is too
4461 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4462 32-bit --with-wide-int hosts).
4464 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4465 Add a FIXME comment about memory leaks.
4466 (syms_of_charset): Don't assume xmalloc returns.
4468 Don't assume that stated character widths fit in int.
4469 * character.c (Fchar_width, c_string_width, lisp_string_width):
4470 * character.h (CHAR_WIDTH):
4471 * indent.c (MULTIBYTE_BYTES_WIDTH):
4472 Use sanitize_char_width to avoid undefined and/or bad behavior
4473 with outlandish widths.
4474 * character.h (sanitize_tab_width): Rename from sanitize_width,
4475 now that we have two such functions. All uses changed.
4476 (sanitize_char_width): New inline function.
4478 Don't assume that tab-width fits in int.
4479 * character.h (sanitize_width): New inline function.
4480 (SANE_TAB_WIDTH): New macro.
4481 (ASCII_CHAR_WIDTH): Use it.
4482 * indent.c (sane_tab_width): Remove. All uses replaced by
4483 SANE_TAB_WIDTH (current_buffer).
4484 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4486 * fileio.c: Integer overflow issues with file modes.
4487 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4489 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4490 Remove unreachable code.
4491 (read_hex, load_charset_map_from_file): Check for integer overflow.
4493 * xterm.c: Don't go over XClientMessageEvent limit.
4494 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4495 (x_send_scroll_bar_event): Likewise. Check that the size does not
4496 exceed limits imposed by XClientMessageEvent, as well as the usual
4497 ptrdiff_t and size_t limits.
4499 * keyboard.c: Overflow, signedness and related fixes.
4500 (make_lispy_movement): Use same integer type in forward decl
4501 that is used in the definition.
4502 (read_key_sequence, keyremap_step):
4503 Change bufsize argument back to int, undoing my 2011-03-30 change.
4504 We prefer signed types, and int is wide enough here.
4505 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4506 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4507 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4508 length, not size_t. Use ptrdiff_t for index, not int.
4509 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4510 possibility of integer overflow.
4512 Overflow, signedness and related fixes for images.
4514 * dispextern.h (struct it.stack[0].u.image.image_id)
4515 (struct_it.image_id, struct image.id, struct image_cache.size)
4516 (struct image_cache.used, struct image_cache.ref_count):
4517 * gtkutil.c (update_frame_tool_bar):
4518 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4519 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4520 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4521 * nsmenu.m (update_frame_tool_bar):
4522 * xdisp.c (calc_pixel_width_or_height):
4523 * xfns.c (image_cache_refcount):
4524 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4525 on typical 64-bit hosts.
4527 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4528 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4529 Omit unnecessary casts to int.
4530 (parse_image_spec): Check that integers fall into 'int' range
4531 when the callers expect that.
4532 (image_ascent): Redo ascent calculation to avoid int overflow.
4533 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4534 (lookup_image): Remove unnecessary tests.
4535 (xbm_image_p): Locals are now of int, not EMACS_INT,
4536 since parse_image_check makes sure they fit into int.
4537 (png_load, gif_load, svg_load_image):
4538 Prefer int to unsigned where either will do.
4539 (tiff_handler): New function, combining the cores of the
4540 old tiff_error_handler and tiff_warning_handler.
4541 This function is rewritten to use vsnprintf and thereby avoid
4542 stack buffer overflows. It uses only the features of vsnprintf
4543 that are common to both POSIX and native Microsoft.
4544 (tiff_error_handler, tiff_warning_handler): Use it.
4545 (tiff_load, gif_load, imagemagick_load_image):
4546 Don't assume :index value fits in 'int'.
4547 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4548 (imagemagick_load_image): Check that crop parameters fit into
4549 the integer types that MagickCropImage accepts. Don't assume
4550 Vimagemagick_render_type has a nonnegative value. Don't assume
4551 size_t fits in 'long'.
4552 (gs_load): Use printmax_t to print the widest integers possible.
4553 Check for integer overflow when computing image height and width.
4555 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4557 * xdisp.c (redisplay_window): Don't force window start if point
4558 will be invisible in the resulting window. (Bug#9324)
4560 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4562 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4563 the display spec is of the form `(space ...)'.
4564 (handle_display_spec): Return the value returned by
4565 handle_single_display_spec, not just 1 or zero.
4566 (handle_single_display_spec): If the display spec is of the form
4567 `(space ...)', and specifies display in the text area, return 2
4569 (try_cursor_movement): Check for the need to scroll more
4570 accurately, and prefer exact match for point under bidi.
4571 Don't advance `row' beyond the last row of the window.
4573 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4574 into disp_prop; all users changed.
4576 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4577 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4578 for the text covered by the display property.
4580 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4582 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4583 Change return value to nil.
4584 (Frecord_buffer): Delete unused function.
4586 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4588 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4589 buffers, return left-to-right.
4590 (set_cursor_from_row): Consider candidate row a win if its glyph
4591 represents a newline and point is on that newline. Fixes cursor
4592 positioning on the newline at EOL of R2L text within L2R
4593 paragraph, and vice versa.
4594 (try_cursor_movement): Check continued rows, in addition to
4595 continuation rows. Fixes unwarranted scroll when point enters a
4596 continued line of R2L text within an L2R paragraph, or vice versa.
4597 (cursor_row_p): Consider the case of point being equal to
4598 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4599 from the end of a short line to the beginning of a continued line
4600 of R2L text within L2R paragraph.
4601 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4602 composed characters.
4604 * bidi.c (bidi_check_type): Use xassert.
4605 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4608 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4610 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4613 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4615 * nsfont.m (ns_otf_to_script): Fix typo.
4617 2011-08-22 Kenichi Handa <handa@m17n.org>
4619 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4620 extra slot even if the purpose is char-code-property-table.
4622 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4624 * xdisp.c (redisplay_window): When computing centering_position,
4625 account for the height of the header line. (Bug#8874)
4627 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4628 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4629 candidate is selected by the mouse, and that candidate has a
4630 composed character under the mouse.
4632 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4633 coordinates reported by pos-visible-in-window-p for a composed
4634 character in column zero.
4636 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4638 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4640 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4642 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4643 consider it a hit if to_charpos is anywhere in the range of the
4644 composed buffer positions.
4646 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4648 * image.c (gif_load): Don't assume that each subimage has the same
4649 dimensions as the base image. Handle disposal method that is
4650 "undefined" by the gif spec (Bug#9335).
4652 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4654 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4655 (Fcondition_case): Document `debug' symbol in error handler.
4657 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4659 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4660 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4661 from an Org mode buffer to a Speedbar frame.
4663 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4664 a composition, take its buffer position from IT->cmp_it.charpos.
4665 Fixes cursor positioning at the beginning of a line that begins
4666 with a composed character.
4668 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4670 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4671 character bidirectional type, use STRONG_L instead. Fixes crashes
4672 in a buffer produced by `describe-categories'.
4674 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4675 members before the level stack, so they would be saved and
4676 restored when copying iterator state. Fixes incorrect reordering
4677 around TABs covered by display properties.
4679 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4681 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4683 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4685 * eval.c (internal_condition_case, internal_condition_case_1)
4686 (internal_condition_case_2, internal_condition_case_n):
4687 Remove unnecessary aborts (Bug#9081).
4689 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4691 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4692 has no `load' handler, try opening the file locally. (Bug#9311)
4694 2011-08-16 Ken Brown <kbrown@cornell.edu>
4696 * gmalloc.c: Expand comment.
4698 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4700 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4701 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4703 2011-08-16 Ken Brown <kbrown@cornell.edu>
4705 Fix memory allocation problems in Cygwin build (Bug#9273).
4707 * unexcw.c ( __malloc_initialized): Declare external variable.
4708 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4710 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4712 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4714 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4716 [CYGWIN] (special_realloc): New function.
4717 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4718 requests to realloc storage in the static heap.
4720 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4722 * bidi.c (bidi_initialize): Remove unused local.
4724 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4727 * biditype.h: Remove file.
4728 * makefile.w32-in ($(BLD)/bidi.$(O)):
4729 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4731 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4733 * chartab.c: Improve commentary for the uniprop_table API.
4735 * bidi.c (bidi_paragraph_init): Support zero value of
4736 bidi_ignore_explicit_marks_for_paragraph_level.
4737 (bidi_initialize): Use uniprop_table instead of including
4738 biditype.h and bidimirror.h.
4740 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4741 coordinates of the iterator when restoring from ppos_it.
4744 2011-08-14 Kenichi Handa <handa@m17n.org>
4746 * process.c (create_process): Call setup_process_coding_systems
4747 after the pid of the process is set to -1 (Bug#8162).
4749 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4751 * xdisp.c (move_it_in_display_line_to): Don't invoke
4752 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4753 ppos_it. Fixes vertical cursor motion when line beginning is
4754 covered by an image. (Bug#9296)
4756 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4758 * nsterm.h (ns_run_ascript): Declare.
4759 (NSAPP_DATA2_RUNASSCRIPT): Define.
4761 * nsfns.m (as_script, as_result, as_status): New static variables.
4762 (ns_run_ascript): New function.
4763 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4764 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4765 the event loop. Get status from as_status (Bug#7276).
4767 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4768 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4769 the event loop (Bug#7276).
4771 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4773 * gnutls.c (QCgnutls_bootprop_priority)
4774 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4775 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4776 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4777 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4778 (QCgnutls_bootprop_verify_hostname_error)
4779 (QCgnutls_bootprop_callbacks_verify): Rename from
4780 Qgnutls_bootprop_..., all uses changed.
4782 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4785 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4787 * xfaces.c (Qframe_set_background_mode): Now static.
4788 * dispextern.h (Qframe_set_background_mode): Remove decl.
4790 * process.c (Fnetwork_interface_info): Declare local only if needed.
4792 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4794 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4795 (Fnetwork_interface_list): Allocate in increments of bytes instead
4796 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4797 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4799 (struct ifflag_def): notrailers is smart on OSX.
4800 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4801 Get hardware address with getifaddrs if available.
4803 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4805 * xdisp.c (iterate_out_of_display_property): xassert that
4806 IT->position is set to within IT->object's boundaries. Break from
4807 the loop as soon as EOB is reached; avoids infloops in redisplay
4808 when IT->position is set up wrongly due to some bug.
4809 Set IT->current to match the bidi iterator unconditionally.
4810 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4811 entry. Force push_it to save on the stack the current
4812 buffer/string position, to be restored by pop_it. Fix flags in
4813 the iterator structure wrt the object coming from a display
4814 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4815 properties. (Bug#9284)
4817 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4819 * fontset.c (fontset_get_font_group): Add proper type checks.
4822 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4824 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4825 and LC_VERSION_MIN_MACOSX.
4826 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4827 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4829 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4831 * xdisp.c (forward_to_next_line_start): Allow to use the
4832 no-display-properties-and-no-overlays under bidi display.
4833 Set disp_pos in the bidi iterator to avoid searches for display
4834 properties and overlays.
4836 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4838 * editfns.c (Fset_time_zone_rule): Document relationship with the
4841 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4842 the font entity extracted from the cache (Bug#8109).
4844 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4846 * composite.c (autocmp_chars): Don't reset point. That is done by
4847 restore_point_unwind (Bug#5984).
4849 2011-08-07 Juri Linkov <juri@jurta.org>
4851 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4852 to show the arg `TIME' instead of `TIMEVAL'.
4854 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4856 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4857 display property strides EOL and includes a newline, as in
4858 longlines-mode. (Bug#9254)
4859 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4860 word-wrap under bidirectional display. (Bug#9224)
4862 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4863 is non-zero, even if the data buffer is NULL. Fixes a crash in
4864 vertical-motion with longlines-mode. (Bug#9254)
4866 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4868 * bidi.c <bidi_cache_total_alloc>: Now static.
4869 (bidi_initialize): Initialize bidi_cache_total_alloc.
4871 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4874 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4875 amount allocated this far in `bidi_cache_total_alloc'.
4876 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4877 non-zero, only free the data buffer without restoring the cache
4878 contents. All callers changed.
4880 * dispextern.h (bidi_unshelve_cache): Update prototype.
4882 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4883 (move_it_in_display_line, move_it_to)
4884 (move_it_vertically_backward, move_it_by_lines): Replace the call
4885 to xfree to an equivalent call to bidi_unshelve_cache.
4886 (move_it_in_display_line_to): Fix logic of returning
4887 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4889 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4891 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4892 came from a string character with a `cursor' property. (Bug#9229)
4894 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4896 * Makefile.in (LIB_PTHREAD): New variable.
4897 (LIBES): Add LIB_PTHREAD (Bug#9216).
4899 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4900 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4902 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4904 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4906 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4908 * xterm.c (x_find_topmost_parent): New function.
4909 (x_set_frame_alpha): Find topmost parent window with
4910 x_find_topmost_parent and set the property there also (bug#9181).
4911 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4913 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4915 * callproc.c (Fcall_process): Avoid vfork clobbering
4916 the local vars buffer, coding_systems, current_dir.
4918 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4920 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4922 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4924 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4925 so that it is not optimized away.
4927 * xdisp.c (compute_display_string_pos): Remove unused local.
4929 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4931 Fix slow cursor motion and scrolling in large buffers with
4932 selective display, like Org Mode buffers. (Bug#9218)
4934 * dispextern.h (struct bidi_it): New member disp_prop_p.
4936 * xdisp.c: Remove one-slot cache of display string positions.
4937 (compute_display_string_pos): Accept an additional argument
4938 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4939 for a display string or property. If found, set DISP_PROP_P
4942 * bidi.c (bidi_fetch_char): Accept an additional argument
4943 DISP_PROP_P, and pass it to compute_display_string_pos.
4944 Only handle text covered by a display string if DISP_PROP_P is returned
4945 non-zero. All callers of bidi_fetch_char changed.
4947 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4949 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4951 2010-12-03 Don March <don@ohspite.net>
4953 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4954 last character M-[char] is translated to ESC [char] (bug#7541).
4956 2011-08-02 Kenichi Handa <handa@m17n.org>
4958 * lisp.h (uniprop_table): Extern it.
4960 * chartab.c (uniprop_table): Make it non-static.
4962 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4964 * xdisp.c (forward_to_next_line_start): Accept additional argument
4965 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4967 (reseat_at_next_visible_line_start): Use the bidi iterator state
4968 returned by forward_to_next_line_start to restore the state of
4969 it->bidi_it after backing up to previous newline. (Bug#9212)
4971 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4973 * regex.c (re_comp): Protoize.
4974 (re_exec): Fix return type.
4975 (regexec): Fix type of `ret'. (Bug#9203)
4977 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4979 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4980 This is needed if max-image-size is a floating-point number.
4982 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4984 * print.c (print_object): Print empty symbol as ##.
4986 * lread.c (read1): Read ## as empty symbol.
4988 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4990 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4991 setting frame foreground color (Bug#9175).
4992 (x_set_background_color): Likewise.
4994 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4995 contents (Bug#9176).
4996 (EmacsTooltip -init): Remove bezels and add shadows to
4999 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5000 or scroll bar (Bug#8470).
5002 * nsfont.m (nsfont_open): Remove assignment to voffset and
5003 unnecessary vars hshink, expand, hd, full_height, min_height.
5004 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5006 * nsterm.h (nsfont_info): Remove voffset field.
5008 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5010 Implement strike-through and overline on NextStep (Bug#8863).
5012 * nsfont.m (nsfont_open): Use underline position provided by font,
5013 instead of hard-coded value of 2.
5014 (nsfont_draw): Call ns_draw_text_decoration instead.
5016 * nsterm.h: Add declaration for ns_draw_text_decoration.
5018 * nsterm.m (ns_draw_text_decoration): New function for drawing
5019 underline, overline, and strike-through.
5020 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5021 ns_draw_text_decoration. Change treatment of cursor drawing to
5022 accommodate underlining, etc.
5024 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5026 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5029 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5031 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5032 Without this fix, if a signal arrives just after memory fills up,
5033 'malloc' might be invoked reentrantly.
5035 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5036 In other words, assume that every image size is allowed, on non-X
5037 hosts. This assumption is probably wrong, but it lets Emacs compile.
5039 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5041 * regex.c (re_iswctype): Convert return values to boolean.
5043 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5045 * xdisp.c (compute_display_string_pos): Don't use cached display
5046 string position if the buffer had its restriction changed.
5049 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5051 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5053 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5055 Integer signedness and overflow and related fixes. (Bug#9079)
5057 * bidi.c: Integer size and overflow fixes.
5058 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5059 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5060 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5061 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5062 (bidi_find_other_level_edge):
5063 Use ptrdiff_t instead of EMACS_INT where either will do.
5064 This works better on 32-bit hosts configured --with-wide-int.
5065 (bidi_cache_ensure_space): Check for size-calculation overflow.
5066 Use % rather than repeated addition, for better worst-case speed.
5067 Don't set bidi_cache_size until after xrealloc returns, because it
5069 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5070 (bidi_cache_ensure_space): Also check that the bidi cache size
5071 does not exceed that of the largest Lisp string or buffer. See Eli
5072 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5074 * alloc.c (__malloc_size_t): Remove.
5075 All uses replaced by size_t. See Andreas Schwab's note
5076 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5078 * image.c: Improve checking for integer overflow.
5079 (check_image_size): Assume that f is nonnull, since
5080 it is always nonnull in practice. This is one less thing to
5081 worry about when checking for integer overflow later.
5082 (x_check_image_size): New function, which checks for integer
5083 overflow issues inside X.
5084 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5085 This removes the need for a memory_full check.
5086 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5087 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5088 (xbm_read_bitmap_data): Change locals back to 'int', since
5089 their values must fit in 'int'.
5090 (xpm_load_image, png_load, tiff_load):
5091 Invoke x_create_x_image_and_pixmap earlier,
5092 to avoid much needless work if the image is too large.
5093 (tiff_load): Treat overly large images as if
5094 x_create_x_image_and_pixmap failed, not as malloc failures.
5095 (gs_load): Use x_check_image_size.
5097 * gtkutil.c: Omit integer casts.
5098 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5099 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5101 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5103 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5104 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5105 would wrongly return t on a 64-bit host.
5107 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5108 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5109 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5110 and therefore cause GCC to emit a bogus diagnostic in some cases.
5112 * image.c: Integer signedness and overflow and related fixes.
5113 This is not an exhaustive set of fixes, but it's time to
5114 record what I've got.
5115 (lookup_pixel_color, check_image_size): Remove redundant decls.
5116 (check_image_size): Don't assume that arbitrary EMACS_INT values
5117 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5118 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5119 (tiff_load, imagemagick_load_image):
5120 Check for overflow in size calculations.
5121 (x_create_x_image_and_pixmap): Remove unnecessary test for
5122 xmalloc returning NULL; that can't happen.
5123 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5124 (xpm_color_bucket): Use better integer hashing function.
5125 (xpm_cache_color): Don't possibly over-allocate memory.
5126 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5127 (gif_memory_source):
5128 Use ptrdiff_t, not int or size_t, to record sizes.
5129 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5130 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5131 either works, as we prefer signed integers.
5132 (tiff_read_from_memory, tiff_write_from_memory):
5133 Return tsize_t, not size_t, since that's what the TIFF API wants.
5134 (tiff_read_from_memory): Don't fail simply because the read would
5135 go past EOF; instead, return a short read.
5136 (tiff_load): Omit no-longer-needed casts.
5137 (Fimagemagick_types): Don't assume size fits into 'int'.
5139 Improve hashing quality when configured --with-wide-int.
5140 * fns.c (hash_string): New function, taken from sxhash_string.
5141 Do not discard information about ASCII character case; this
5142 discarding is no longer needed.
5143 (sxhash-string): Use it. Change sig to match it. Caller changed.
5144 * lisp.h: Declare it.
5145 * lread.c (hash_string): Remove, since we now use fns.c's version.
5146 The fns.c version returns a wider integer if --with-wide-int is
5147 specified, so this should help the quality of the hashing a bit.
5149 * emacs.c: Integer overflow minor fix.
5150 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5151 Define only if GNU_LINUX.
5152 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5154 * dispnew.c: Integer signedness and overflow fixes.
5155 Remove unnecessary forward decls, that were a maintenance hassle.
5156 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5158 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5159 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5160 (prepare_desired_row, line_draw_cost):
5161 Use int, not unsigned, where either works.
5162 (save_current_matrix, restore_current_matrix):
5163 Use ptrdiff_t, not size_t, where either works.
5164 (init_display): Check for overflow more accurately, and without
5165 relying on undefined behavior.
5167 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5168 Remove, replacing with the new symbols in lisp.h. All uses changed.
5169 * fileio.c (make_temp_name):
5170 * filelock.c (lock_file_1, lock_file):
5171 * xdisp.c (message_dolog):
5172 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5173 Use pMd etc. instead.
5174 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5175 replacing the pWIDE etc. symbols removed from editfns.c.
5177 * keyboard.h (num_input_events): Now uintmax_t.
5178 This is (very slightly) less likely to mess up due to wraparound.
5181 * buffer.c: Integer signedness fixes.
5182 (alloc_buffer_text, enlarge_buffer_text):
5183 Use ptrdiff_t rather than size_t when either will do, as we prefer
5186 * alloc.c: Integer signedness and overflow fixes.
5187 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5188 (__malloc_size_t): Default to size_t, not to int.
5189 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5190 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5191 Prefer ptrdiff_t to size_t when either would do, as we prefer
5193 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5194 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5195 Now const. Initialize with values that are in range even if char
5197 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5198 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5199 These functions do the right thing with sizes > 2**32.
5200 (check_depth): Now ptrdiff_t, not int.
5201 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5202 Adjust to new way of storing sizes. Check for size overflow bugs
5204 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5205 slightly wrong anyway, as it missed one instance of
5206 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5207 (refill_memory_reserve): Omit needless cast to size_t.
5208 (mark_object_loop_halt): Mark as externally visible.
5210 * xselect.c: Integer signedness and overflow fixes.
5211 (Fx_register_dnd_atom, x_handle_dnd_message):
5212 Use ptrdiff_t, not size_t, since we prefer signed.
5213 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5214 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5215 x_dnd_atoms_size and x_dnd_atoms_length.
5217 * doprnt.c: Prefer signed to unsigned when either works.
5219 * doprnt.c (doprnt):
5221 * xdisp.c (vmessage):
5222 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5223 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5224 prefer signed arithmetic to avoid comparison confusion.
5225 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5226 but is a bit tricky.
5228 Assume freestanding C89 headers, string.h, stdlib.h.
5229 * data.c, doprnt.c, floatfns.c, print.c:
5230 Include float.h unconditionally.
5231 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5232 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5233 * regex.c: Likewise for stddef.h, string.h.
5234 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5235 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5236 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5237 (STDC_HEADERS): Remove obsolete defines.
5238 * sysdep.c: Include limits.h unconditionally.
5240 Assume support for memcmp, memcpy, memmove, memset.
5241 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5242 * regex.c (memcmp, memcpy):
5243 Remove; we assume C89 now.
5245 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5246 (__malloc_safe_bcopy): Remove; no longer needed.
5248 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5249 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5250 well either way, and we prefer signed to unsigned.
5252 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5254 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5255 closes the connection while we're reading (bug#9182).
5257 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5259 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5260 are specified (Bug#9168).
5262 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5264 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5265 Found by GCC static checking and --with-wide-int on a 32-bit host.
5267 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5269 * xdisp.c (compute_display_string_pos): Fix logic of caching
5270 previous display string position. Initialize cached_prev_pos to
5271 -1. Fixes slow-down at the beginning of a buffer.
5273 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5275 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5276 for attrs[LFACE_FONTSET_INDEX].
5278 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5280 * xml.c (parse_region): Remove unused local
5281 that was recently introduced.
5283 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5285 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5286 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5288 * xdisp.c (move_it_in_display_line_to): Record the best matching
5289 position for TO_CHARPOS while scanning the line, and restore it on
5290 exit if none of the characters scanned was an exact match.
5291 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5292 when exact match is impossible due to invisible text, and the
5293 lines are truncated.
5295 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5297 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5300 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5302 Fix a significant slow-down of cursor motion with C-n, C-p,
5303 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5304 auto-repeat under bidi redisplay in fontified buffers.
5305 * xdisp.c (compute_stop_pos_backwards): New function.
5306 (next_element_from_buffer): Call compute_stop_pos_backwards to
5307 find a suitable prev_stop when we find ourselves before
5309 (reseat): Don't look for prev_stop, as that could mean a very long
5311 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5312 <cached_disp_overlay_modiff>: Cache for last found display string
5314 (compute_display_string_pos): Return the cached position if asked
5315 about the same buffer in the same area of character positions, and
5316 the buffer wasn't changed since the time the display string
5317 position was cached.
5319 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5321 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5322 is an integer, which is important for empty lines. (Bug#9149)
5324 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5326 * frame.c (Fmodify_frame_parameters): In tty case, update the
5327 default face if necessary (Bug#4238).
5329 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5331 * editfns.c (Fstring_to_char): No need to explain what a character
5332 is in the docstring (Bug#6576).
5334 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5336 * xml.c (parse_region): Make sure we always return a tree.
5338 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5340 * xml.c (parse_region): If a document contains only comments,
5343 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5345 * xml.c (make_dom): Return comments, too.
5347 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5350 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5351 and the surrounding thread.
5352 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5353 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5354 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5356 * s/openbsd.h (BROKEN_SIGIO): Define.
5357 * unexelf.c (unexec) [__OpenBSD__]:
5358 Don't update the .mdebug section of the Alpha COFF symbol table.
5360 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5362 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5365 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5367 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5368 This fixes some race conditions on the permissions of any newly
5371 * alloc.c (valid_pointer_p): Use pipe, not open.
5372 This fixes some permissions issues when debugging.
5374 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5375 If fchown fails to set both uid and gid, try to set just gid,
5376 as that is sometimes allowed. Adjust the file's mode to eliminate
5377 setuid or setgid bits that are inappropriate if fchown fails.
5379 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5381 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5382 to compare Lisp_Objects.
5383 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5384 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5385 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5387 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5389 * lread.c (read_integer): Unread even EOF character.
5390 (read1): Likewise. Properly record start position of symbol.
5392 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5393 symbol character follows.
5395 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5397 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5398 This works around a problem with the previous change to Fcopy_file.
5399 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5400 and without this change, GCC might complain about discarding
5401 fchown's return value.
5403 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5405 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5407 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5409 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5411 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5413 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5414 it's used from the C level.
5416 * process.c: Use the same condition for POLL_FOR_INPUT in both
5417 keyboard.c and process.c (bug#1858).
5419 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5421 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5422 (Fgnutls_boot): Use it.
5424 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5426 * doc.c (Fsubstitute_command_keys): Revert last change.
5428 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5430 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5431 quotes the next character, and doesn't affect other longer
5432 sequences (bug#8935).
5434 * lread.c (syms_of_lread): Clarify that is isn't only
5435 `eval-buffer' and `eval-defun' that's affected by
5436 `lexical-binding' (bug#8460).
5438 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5440 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5441 bidi redisplay when a line includes both an image and is truncated.
5443 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5445 Fix minor problems found by static checking.
5446 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5447 (elsz): Now a signed constant, not a size_t var. We prefer signed
5448 types to unsigned, to avoid integer comparison confusion. Without
5449 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5450 "cannot optimize loop, the loop counter may overflow", a symptom
5452 * indent.c (Fvertical_motion): Mark locals as initialized.
5453 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5455 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5457 * search.c (Fre_search_backward): Mention `case-fold-search' in
5458 all the re_search_* functions (bug#8138).
5460 * keyboard.c (Fopen_dribble_file): Document when the file is
5463 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5465 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5468 Support bidi reordering of display and overlay strings.
5469 * xdisp.c (compute_display_string_pos)
5470 (compute_display_string_end): Accept additional argument STRING.
5471 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5472 (reseat_to_string): Initialize bidi_it->string.s and
5473 bidi_it->string.schars.
5474 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5475 NULL (avoids a crash in bidi_paragraph_init).
5476 Initialize itb.string.lstring.
5477 (init_iterator): Call bidi_init_it only of a valid
5478 buffer position was specified. Initialize paragraph_embedding to
5480 (reseat_to_string): Initialize the bidi iterator.
5481 (display_string): If we need to ignore text properties of
5482 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5483 original value of -1 will not work with bidi.)
5484 (compute_display_string_pos): First arg is now struct
5485 `text_pos *'; all callers changed. Support display properties on
5487 (compute_display_string_end): Support display properties on Lisp
5489 (init_iterator, reseat_1, reseat_to_string): Initialize the
5490 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5491 when iterating on a string not from display properties).
5492 (compute_display_string_pos, compute_display_string_end):
5493 Fix calculation of the object to scan. Fixes an error when using
5495 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5496 base_level_stop; instead, set base_level_stop to BEGV.
5497 Fixes crashes in vertical-motion.
5498 (next_element_from_buffer): Improve commentary for when
5499 the iterator is before prev_stop.
5500 (init_iterator): Initialize bidi_p from the default value of
5501 bidi-display-reordering, not from buffer-local value. Use the
5502 buffer-local value only if initializing for buffer iteration.
5503 (handle_invisible_prop): Support invisible properties on strings
5504 that are being bidi-reordered.
5505 (set_iterator_to_next): Support bidi reordering of C strings and
5507 (next_element_from_string): Support bidi reordering of Lisp
5509 (handle_stop_backwards): Support Lisp strings as well.
5510 (display_string): Support display of R2L glyph rows.
5511 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5512 (init_iterator): Don't initialize it->bidi_p for strings
5514 (reseat_to_string): Initialize it->bidi_p for strings here.
5515 (next_element_from_string, next_element_from_c_string)
5516 (next_element_from_buffer): Add xassert's for correspondence
5517 between IT's object being iterated and it->bidi_it.string
5519 (face_before_or_after_it_pos): Support bidi iteration.
5520 (next_element_from_c_string): Handle the case of the first string
5521 character that is not the first one in the visual order.
5522 (get_visually_first_element): New function, refactored from common
5523 parts of next_element_from_buffer, next_element_from_string, and
5524 next_element_from_c_string.
5525 (tool_bar_lines_needed, redisplay_tool_bar)
5526 (display_menu_bar): Force left-to-right direction. Add a FIXME
5527 comment for making that be controlled by a user option.
5528 (push_it, pop_it): Save and restore the state of the
5529 bidi iterator. Save and restore the bidi_p flag.
5530 (pop_it): Iterate out of display property for string iteration as
5532 (iterate_out_of_display_property): Support iteration over strings.
5533 (handle_single_display_spec): Set up it->bidi_it for iteration
5534 over a display string, and call bidi_init_it.
5535 (handle_single_display_spec, next_overlay_string)
5536 (get_overlay_strings_1, push_display_prop): Set up the bidi
5537 iterator for displaying display or overlay strings.
5538 (forward_to_next_line_start): Don't use the shortcut if
5540 (back_to_previous_visible_line_start): If handle_display_prop
5541 pushed the iterator stack, restore the internal state of the bidi
5542 iterator by calling bidi_pop_it same number of times.
5543 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5544 and we are bidi-iterating, don't decrement the iterator position;
5545 instead, set the first_elt flag in the bidi iterator, to produce
5547 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5548 (push_display_prop): xassert that we are iterating a buffer.
5549 (push_it, pop_it): Save and restore paragraph_embedding member.
5550 (handle_single_display_spec, next_overlay_string)
5551 (get_overlay_strings_1, reseat_1, reseat_to_string)
5552 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5553 correctly. Don't assume unibyte strings are not bidi-reordered.
5554 (compute_display_string_pos)
5555 (compute_display_string_end): Fix handling the case of C string.
5556 (push_it, pop_it): Save and restore from_disp_prop_p.
5557 (handle_single_display_spec, push_display_prop): Set the
5558 from_disp_prop_p flag.
5559 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5560 (pop_it): Call iterate_out_of_display_property only if we are
5561 popping after iteration over a string that came from a display
5562 property. Fix a typo in popping stretch info. Add an assertion
5563 for verifying that the iterator position is in sync with the bidi
5565 (handle_single_display_spec, get_overlay_strings_1)
5566 (push_display_prop): Fix initialization of paragraph direction for
5567 string when that of the parent object is not yet determined.
5568 (reseat_1): Call bidi_init_it to resync the bidi
5569 iterator with IT's position. (Bug#7616)
5570 (find_row_edges): If ROW->start.pos gives position
5571 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5572 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5573 Reset the from_disp_prop_p flag.
5574 (SAVE_IT, RESTORE_IT): New macros.
5575 (pos_visible_p, face_before_or_after_it_pos)
5576 (back_to_previous_visible_line_start)
5577 (move_it_in_display_line_to, move_it_in_display_line)
5578 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5579 (try_scrolling, redisplay_window, display_line): Use them when
5580 saving a temporary copy of the iterator and restoring it back.
5581 (back_to_previous_visible_line_start, reseat_1)
5582 (init_iterator): Empty the bidi cache "stack".
5583 (move_it_in_display_line_to): If iterator ended up at
5584 EOL, but we never saw any buffer positions smaller than
5585 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5586 motion in bidi-reordered lines.
5587 (move_it_in_display_line_to): Record prev_method and prev_pos
5588 immediately before the call to set_iterator_to_next. Fixes cursor
5589 motion in bidi-reordered lines with stretch glyphs and strings
5590 displayed in margins. (Bug#8133) (Bug#8867)
5591 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5593 (pos_visible_p): Support positions in bidi-reordered lines.
5594 Save and restore bidi cache.
5596 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5597 (bidi_paragraph_info): Delete unused struct.
5598 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5599 (bidi_cache_start): New variable.
5600 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5602 (bidi_cache_fetch_state, bidi_cache_search)
5603 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5604 (bidi_cache_find, bidi_peek_at_next_level)
5605 (bidi_level_of_next_char, bidi_find_other_level_edge)
5606 (bidi_move_to_visually_next): Compare cache index with
5607 bidi_cache_start rather than with zero.
5608 (bidi_fetch_char): Accept new argument STRING; all callers
5609 changed. Support iteration over a string. Support strings with
5610 display properties. Support unibyte strings. Fix the type of
5611 `len' according to what STRING_CHAR_AND_LENGTH expects.
5612 (bidi_paragraph_init, bidi_resolve_explicit_1)
5613 (bidi_resolve_explicit, bidi_resolve_weak)
5614 (bidi_level_of_next_char, bidi_move_to_visually_next):
5615 Support iteration over a string.
5616 (bidi_set_sor_type, bidi_resolve_explicit_1)
5617 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5618 can now be zero (for strings); special values 0 and -1 were
5619 changed to -1 and -2, respectively.
5620 (bidi_char_at_pos): New function.
5621 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5622 Call it instead of FETCH_MULTIBYTE_CHAR.
5623 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5624 initialized to valid values.
5625 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5627 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5628 the test for valid cached positions. Fix the logic for looking up
5629 the sentinel state in the cache. GCPRO the Lisp string we are
5631 (bidi_push_it, bidi_pop_it): New functions.
5632 (bidi_initialize): Initialize the bidi cache start stack pointer.
5633 (bidi_cache_ensure_space): New function, refactored from part of
5634 bidi_cache_iterator_state. Don't assume the required size is just
5635 one BIDI_CACHE_CHUNK away.
5636 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5637 (bidi_count_bytes, bidi_char_at_pos): New functions.
5638 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5639 always valid if bidi_cache_idx is valid.
5640 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5641 is valid if it's going to be used.
5642 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5643 (bidi_cache_fetch_state, bidi_cache_search)
5644 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5645 (bidi_cache_iterator_state, bidi_cache_find)
5646 (bidi_find_other_level_edge, bidi_cache_start_stack):
5647 All variables related to cache indices are now EMACS_INT.
5649 * dispextern.h (struct bidi_string_data): New structure.
5650 (struct bidi_it): New member `string'. Make flag members be 1-bit
5651 fields, and put them last in the struct.
5652 (compute_display_string_pos, compute_display_string_end):
5654 (bidi_push_it, bidi_pop_it): Add prototypes.
5655 (struct iterator_stack_entry): New members bidi_p,
5656 paragraph_embedding, and from_disp_prop_p.
5657 (struct it): Member bidi_p is now a bit field 1 bit wide.
5658 (bidi_shelve_cache, bidi_unshelve_cache):
5661 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5662 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5663 and vector-like objects.
5665 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5666 cache around display iteration.
5668 * window.c (Fwindow_end, window_scroll_pixel_based)
5669 (displayed_window_lines, Frecenter): Save and restore the bidi
5670 cache around display iteration.
5672 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5674 * editfns.c (Fdelete_region): Clarify the use of the named
5675 parameters (bug#6788).
5677 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5679 * indent.c (Fvertical_motion): Set and restore w->pointm when
5680 saving and restoring the window's buffer (Bug#9006).
5682 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5684 * editfns.c (Fstring_to_char): Clarify just what is returned
5685 (bug#6576). Text by Eli Zaretskii.
5687 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5689 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5691 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5693 * buffer.c (mmap_find): Fix a typo.
5695 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5697 Fix execution of x selection hooks.
5698 * xselect.c (Qx_lost_selection_functions)
5699 (Qx_sent_selection_functions): New vars.
5700 (syms_of_xselect): DEFSYM them.
5701 (x_handle_selection_request): Pass Qx_sent_selection_functions
5702 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5703 (x_handle_selection_clear,x_clear_frame_selections):
5704 Pass Qx_lost_selection_functions rather than
5705 Vx_lost_selection_functions to Frun_hook_with_args.
5707 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5709 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5710 The old code sometimes used this field without initializing it.
5712 * alloc.c (gc_sweep): Don't read past end of array.
5713 In theory, the old code could also have corrupted Emacs internals,
5714 though it'd be very unlikely.
5716 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5718 * character.c (Fcharacterp): Don't advertise optional ignored
5719 argument. (Bug#4026)
5721 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5723 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5726 * window.c (Fset_window_start): Doc fix (bug#4199).
5727 (Fset_window_hscroll): Ditto.
5729 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5731 Fix minor new problems caught by GCC 4.6.1.
5732 * term.c (init_tty): Remove unused local.
5733 * xsettings.c (store_monospaced_changed): Define this function only
5734 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5737 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5739 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5741 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5743 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5744 are the mini-buffer and the echo area (bug#3320).
5746 * term.c (init_tty): Remove support for supdup, c10 and perq
5747 terminals, which are no longer supported (bug#1482).
5749 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5751 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5753 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5755 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5756 for non-popups (Bug#3642).
5758 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5760 * alloc.c (reset_malloc_hooks): Protoize.
5761 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5762 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5763 * cm.c (losecursor): Likewise.
5764 * data.c (fmod): Likewise.
5765 * dispnew.c (swap_glyphs_in_rows): Likewise.
5766 * emacs.c (memory_warning_signal): Likewise.
5767 * floatfns.c (float_error): Likewise.
5768 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5769 (otf_open, font_otf_capability, generate_otf_features)
5770 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5772 * image.c (pbm_read_file): Likewise.
5773 * indent.c (string_display_width): Likewise.
5774 * intervals.c (check_for_interval, search_for_interval)
5775 (inc_interval_count, count_intervals, root_interval)
5776 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5777 * lread.c (defalias): Likewise.
5778 * ralloc.c (r_alloc_check): Likewise.
5779 * regex.c (set_image_of_range_1, set_image_of_range)
5780 (regex_grow_registers): Likewise.
5781 * sysdep.c (strerror): Likewise.
5782 * termcap.c (valid_filename_p, tprint, main): Likewise.
5783 * tparam.c (main): Likewise.
5784 * unexhp9k800.c (run_time_remap, save_data_space)
5785 (update_file_ptrs, read_header, write_header, calculate_checksum)
5786 (copy_file, copy_rest, display_header): Likewise.
5787 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5789 * xdisp.c (check_it): Likewise.
5790 * xfaces.c (register_color, unregister_color, unregister_colors):
5792 * xfns.c (print_fontset_result): Likewise.
5793 * xrdb.c (member, fatal, main): Likewise.
5795 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5797 Fix minor problems found by static checking (Bug#9031).
5798 * chartab.c (char_table_set_range, map_sub_char_table):
5799 Remove unused locals.
5800 (uniprop_table): Now static.
5801 * composite.c (_work_char): Remove unused static var.
5803 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5805 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5807 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5809 * gtkutil.c (qttip_cb): Remove code without function.
5811 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5813 * w32.c (pthread_sigmask): New stub.
5815 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5817 Use pthread_sigmask, not sigprocmask (Bug#9010).
5818 sigprocmask is portable only for single-threaded applications, and
5819 Emacs can be multi-threaded when it uses GTK.
5820 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5822 * callproc.c (Fcall_process):
5823 * process.c (create_process):
5824 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5825 Use pthread_sigmask, not sigprocmask.
5827 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5829 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5830 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5833 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5835 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5836 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5837 (xg_hide_tooltip): Fix comment.
5839 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5840 in registerServicesMenuSendTypes.
5841 (validRequestorForSendType): Don't check ns_return_types.
5843 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5846 2011-07-08 Jason Rumney <jasonr@gnu.org>
5848 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5849 SH_SHOW for hidden windows (Bug#5482).
5851 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5852 frame struct members of non-existent frames (Bug#6284).
5854 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5856 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5857 variable firstTime not needed on OSX >= 10.6.
5858 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5859 >= 10.5. Use setKnobProportion, setDoubleValue.
5861 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5862 (MAC_OS_X_VERSION_10_5): Define if not defined.
5863 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5864 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5865 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5867 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5868 cString and lossyCString on OSX >= 10.4
5870 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5871 sizeToFit on OSX >= 10.2.
5873 * nsimage.m (allocInitFromFile): Don't use deprecated method
5874 bestRepresentationForDevice on OSX >= 10.6.
5876 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5879 * emacs.c: Declare unexec_init_emacs_zone.
5881 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5883 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5885 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5886 on svcsMenu (Bug#8842).
5888 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5890 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5892 * nsterm.m (QUTF8_STRING): Declare.
5893 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5894 (validRequestorForSendType): Return type is (id).
5895 Change indexOfObjectIdenticalTo to indexOfObject.
5896 Check if we have local selection before returning self (Bug#8842).
5897 (writeSelectionToPasteboard): Put local selection into paste board
5898 if we have a local selection (Bug#8842).
5899 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5901 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5902 (ns_get_local_selection): Declare.
5904 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5906 * keymap.c (describe_map_tree): Don't insert a double newline at
5907 the end of the buffer (bug#1169) and return whether we inserted
5910 * callint.c (Fcall_interactively): Change "reading args" to
5911 "providing args" to try to clarify what it does (bug#1010).
5913 2011-07-07 Kenichi Handa <handa@m17n.org>
5915 * composite.c (composition_compute_stop_pos): Ignore a static
5916 composition starting before CHARPOS (Bug#8915).
5918 * xdisp.c (handle_composition_prop): Likewise.
5920 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5922 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5925 2011-07-07 Kenichi Handa <handa@m17n.org>
5927 * character.h (unicode_category_t): New enum type.
5929 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5930 (Qchar_code_property_table): New variable.
5931 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5932 (UNIPROP_COMPRESSED_FORM_P): New macros.
5933 (char_table_ascii): Uncompress the compressed values.
5934 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5935 Uncompress the compressed values.
5936 (sub_char_table_ref_and_range): Likewise.
5937 (char_table_ref_and_range): Uncompress the compressed values.
5938 (sub_char_table_set): New arg is_uniprop. Callers changed.
5939 Uncompress the compressed values.
5940 (sub_char_table_set_range): Args changed. Callers changed.
5941 (char_table_set_range): Adjuted for the above change.
5942 (map_sub_char_table): Delete args default_val and parent. Add arg
5943 top. Give decoded values to a Lisp function.
5944 (map_char_table): Adjust for the above change. Give decoded
5945 values to a Lisp function. Gcpro more variables.
5946 (uniprop_table_uncompress)
5947 (uniprop_decode_value_run_length): New functions.
5948 (uniprop_decoder, uniprop_decoder_count): New variables.
5949 (uniprop_get_decoder, uniprop_encode_value_character)
5950 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5952 (uniprop_encoder, uniprop_encoder_count): New variables.
5953 (uniprop_get_encoder, uniprop_table)
5954 (Funicode_property_table_internal, Fget_unicode_property_internal)
5955 (Fput_unicode_property_internal): New functions.
5956 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5957 Sunicode_property_table_internal, Sget_unicode_property_internal,
5958 and Sput_unicode_property_internal. Defvar_lisp
5959 char-code-property-alist.
5961 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5962 Vunicode_category_table.
5964 * font.c (font_range): Adjust for the change of
5965 Vunicode_category_table.
5967 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5969 * m/iris4d.h: Remove file, move contents ...
5970 * s/irix6-5.h: ... here.
5972 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5974 Remove unportable assumption about struct layout (Bug#8884).
5975 * alloc.c (mark_buffer):
5976 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5977 (clone_per_buffer_values): Don't assume that
5978 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5979 This isn't true in general, and it's particularly not true
5980 if Emacs is configured with --with-wide-int.
5981 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5982 New macros, used in the buffer.c change.
5984 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5986 * xsettings.c: Use both GConf and GSettings if both are available.
5987 (store_config_changed_event): Add comment.
5988 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5989 (store_tool_bar_style_changed): New functions.
5990 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5991 (struct xsettings): Move font inside HAVE_XFT.
5992 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5993 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5994 Move inside HAVE_XFT.
5995 (something_changed_gsettingsCB): Rename from something_changedCB.
5996 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5998 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5999 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6000 (something_changed_gconfCB): Rename from something_changedCB.
6001 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6002 (parse_settings): Move check for font inside HAVE_XFT.
6003 (read_settings, apply_xft_settings): Add comment.
6004 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6005 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6006 call store_font_name_changed.
6007 (xft_settings_event): Add comment.
6008 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6009 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6010 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6011 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6012 (xsettings_initialize): Call init_gsettings last.
6013 (xsettings_get_system_font, xsettings_get_system_normal_font):
6016 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6018 Random fixes. E.g., (random) never returned negative values.
6019 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6020 subseconds part to the entropy, as that's a bit more random.
6021 Prefer signed to unsigned, since the signedness doesn't matter and
6022 in general we prefer signed. When given a limit, use a
6023 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6024 latter isn't right if USE_2_TAGS_FOR_INTS.
6025 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6026 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6028 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6030 * textprop.c (text_property_stickiness):
6031 Obey Vtext_property_default_nonsticky.
6032 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6033 * w32fns.c (syms_of_w32fns):
6034 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6036 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6038 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6039 This is more efficient than Ffile_directory_p and avoids a minor race.
6041 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6043 * buffer.c (Foverlay_put): Say what the return value is
6046 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6047 is a directory before asking whether to use the file name
6049 (barf_or_query_if_file_exists): Make the "File is a directory"
6050 error be more correct.
6052 * fns.c (Frequire): Remove the mention of the .gz files, since
6053 that's installation-specific, but keep the mention of
6054 `get-load-suffixes'.
6056 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6058 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6059 Report string overflow if the output is too long.
6061 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6063 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6064 (syms_of_gnutls): Remove duplicate DEFSYM for
6065 Qgnutls_bootprop_verify_hostname_error, an error for
6066 Qgnutls_bootprop_verify_error (which is no longer used).
6068 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6069 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6070 Also (re)move comments that are misplaced or no longer relevant.
6072 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6074 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6076 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6078 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6079 and background color parameters if they have been changed.
6081 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6083 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6085 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6087 * xsettings.c (SYSTEM_FONT): Define only when used.
6088 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6090 * keymap.c (access_keymap_1): Now static.
6092 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6094 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6095 leave any prefix arg for the up event (Bug#1586).
6097 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6099 * lread.c (syms_of_lread): Mention single symbols defined by
6100 `defvar' or `defconst' (bug#7154).
6102 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6103 (Frequire): Mention get-load-suffixes.
6105 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6107 * window.h (window): Remove clone_number slot.
6108 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6110 (make_parent_window, make_window, saved_window)
6111 (Fset_window_configuration, save_window_save): Don't deal with
6113 * buffer.c (Qclone_number): Remove declaration.
6114 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6116 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6118 Add multiple inheritance to keymaps.
6119 * keymap.c (Fmake_composed_keymap): New function.
6120 (Fset_keymap_parent): Simplify.
6121 (fix_submap_inheritance): Remove.
6122 (access_keymap_1): New function extracted from access_keymap to handle
6123 embedded parents and handle lists of maps.
6124 (access_keymap): Use it.
6125 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6126 (Fcopy_keymap): Handle embedded parents.
6127 (Fcommand_remapping, define_as_prefix): Simplify.
6128 (Fkey_binding): Simplify.
6129 (syms_of_keymap): Move minibuffer-local-completion-map,
6130 minibuffer-local-filename-completion-map,
6131 minibuffer-local-must-match-map, and
6132 minibuffer-local-filename-must-match-map to Elisp.
6133 (syms_of_keymap): Defsubr make-composed-keymap.
6134 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6135 (parse_menu_item): Trivial simplification.
6137 2011-07-01 Glenn Morris <rgm@gnu.org>
6139 * Makefile.in (SETTINGS_LIBS): Fix typo.
6141 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6143 * coding.c (Fencode_coding_string): Record the last coding system
6144 used, as the function doc string says (bug#8738).
6146 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6148 * xsettings.c (store_monospaced_changed): Take new font as arg and
6149 check for change against current_mono_font.
6150 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6151 (emacs_settings_constructor, emacs_settings_get_property)
6152 (emacs_settings_set_property, emacs_settings_class_init)
6153 (emacs_settings_init, gsettings_obj): Remove.
6154 (something_changedCB): New function for HAVE_GSETTINGS.
6155 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6156 with value as argument.
6157 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6158 g_settings_new (Bug#8967). Do not create gsettings_obj.
6159 Remove calls to g_settings_bind. Connect something_changedCB to
6162 * xgselect.c: Add defined (HAVE_GSETTINGS).
6163 (xgselect_initialize): Ditto.
6165 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6166 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6169 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6171 * eval.c (struct backtrace): Simplify and port the data structure.
6172 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6173 signed bit field, as this assumption is not portable and it makes
6174 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6175 "char debug_on_exit : 1" as this is not portable either; instead,
6176 use the portable "unsigned int debug_on_exit : 1". Remove unused
6177 member evalargs. Remove obsolete comments about cc bombing out.
6179 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6181 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6182 Let HAVE_GSETTINGS override HAVE_GCONF.
6183 (store_monospaced_changed): New function.
6184 (EMACS_SETTINGS): A new type derived from GObject to handle
6185 GSettings notifications.
6186 (emacs_settings_constructor, emacs_settings_get_property)
6187 (emacs_settings_set_property, emacs_settings_class_init):
6189 (gsettings_client, gsettings_obj): New variables.
6190 (GSETTINGS_SCHEMA): New define.
6191 (something_changedCB): Call store_monospaced_changed.
6192 (init_gsettings): New function.
6193 (xsettings_initialize): Call init_gsettings.
6194 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6197 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6200 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6202 * window.c (resize_root_window, grow_mini_window)
6203 (shrink_mini_window): Rename Qresize_root_window to
6204 Qwindow_resize_root_window and Qresize_root_window_vertically to
6205 Qwindow_resize_root_window_vertically.
6207 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6209 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6211 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6213 * makefile.w32-in: Redesign dependencies so they reflect more
6214 clearly which files are directly included by each source file,
6215 and not through other includes.
6217 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6219 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6220 (sort_overlays, overlay_strings): When an overlay's clone number
6221 matches the window's clone number process the overlay even if
6222 the overlay's window property doesn't match the current window.
6224 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6225 (Fwindow_hchild): Rename to Fwindow_left_child.
6226 (Fwindow_next): Rename to Fwindow_next_sibling.
6227 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6228 (resize_window_check): Rename to window_resize_check.
6229 (resize_window_apply): Rename to window_resize_apply.
6230 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6231 (Fdelete_other_windows_internal, resize_frame_windows)
6232 (Fsplit_window_internal, Fdelete_window_internal)
6233 (grow_mini_window, shrink_mini_window)
6234 (Fresize_mini_window_internal): Fix callers accordingly.
6236 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6238 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6239 (emacs_fixed_set_min_size): Remove.
6240 (emacs_fixed_new): Take frame as argument.
6242 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6243 (_EmacsFixedPrivate): Remove minwidth/height.
6244 Add struct frame *f.
6245 (emacs_fixed_init): Initialize priv->f.
6246 (get_parent_class, emacs_fixed_set_min_size): Remove.
6247 (emacs_fixed_new): Set priv->f to argument.
6248 (emacs_fixed_get_preferred_width)
6249 (emacs_fixed_get_preferred_height): Use min_width/height from
6250 frames size_hint to set minimum and natural (Bug#8919).
6251 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6252 and use min_width/height from frames size_hint to set
6253 min_width/height (Bug#8919).
6255 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6256 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6259 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6261 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6262 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6265 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6267 * process.c (wait_reading_process_output): Bypass select if
6268 waiting for a cell while ignoring keyboard input, and input is
6269 pending. Suggested by Jan Djärv (Bug#8869).
6271 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6273 Use gnulib's dup2 module instead of rolling our own.
6274 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6276 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6278 * dispnew.c (scrolling_window): Before scrolling, turn off a
6279 mouse-highlight in the window being scrolled.
6281 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6283 Move DEFSYM to lisp.h and use everywhere.
6285 * character.h (DEFSYM): Move declaration...
6286 * lisp.h (DEFSYM): ...here.
6292 * w32select.c: Don't include character.h.
6294 * alloc.c (syms_of_alloc):
6295 * buffer.c (syms_of_buffer):
6296 * bytecode.c (syms_of_bytecode):
6297 * callint.c (syms_of_callint):
6298 * casefiddle.c (syms_of_casefiddle):
6299 * casetab.c (init_casetab_once):
6300 * category.c (init_category_once, syms_of_category):
6301 * ccl.c (syms_of_ccl):
6302 * cmds.c (syms_of_cmds):
6303 * composite.c (syms_of_composite):
6304 * dbusbind.c (syms_of_dbusbind):
6305 * dired.c (syms_of_dired):
6306 * dispnew.c (syms_of_display):
6307 * doc.c (syms_of_doc):
6308 * editfns.c (syms_of_editfns):
6309 * emacs.c (syms_of_emacs):
6310 * eval.c (syms_of_eval):
6311 * fileio.c (syms_of_fileio):
6312 * fns.c (syms_of_fns):
6313 * frame.c (syms_of_frame):
6314 * fringe.c (syms_of_fringe):
6315 * insdel.c (syms_of_insdel):
6316 * keymap.c (syms_of_keymap):
6317 * lread.c (init_obarray, syms_of_lread):
6318 * macros.c (syms_of_macros):
6319 * msdos.c (syms_of_msdos):
6320 * print.c (syms_of_print):
6321 * process.c (syms_of_process):
6322 * search.c (syms_of_search):
6323 * sound.c (syms_of_sound):
6324 * syntax.c (init_syntax_once, syms_of_syntax):
6325 * terminal.c (syms_of_terminal):
6326 * textprop.c (syms_of_textprop):
6327 * undo.c (syms_of_undo):
6328 * w32.c (globals_of_w32):
6329 * window.c (syms_of_window):
6330 * xdisp.c (syms_of_xdisp):
6331 * xfaces.c (syms_of_xfaces):
6332 * xfns.c (syms_of_xfns):
6333 * xmenu.c (syms_of_xmenu):
6334 * xsettings.c (syms_of_xsettings):
6335 * xterm.c (syms_of_xterm): Use DEFSYM.
6337 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6339 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6341 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6343 Integer and buffer overflow fixes (Bug#8873).
6345 * print.c (printchar, strout): Check for string overflow.
6346 (PRINTPREPARE, printchar, strout):
6347 Don't set size unless allocation succeeds.
6349 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6350 for sizes. Check for string overflow more accurately.
6351 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6353 * macros.c: Integer and buffer overflow fixes.
6354 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6355 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6356 Use ptrdiff_t, not int, for sizes.
6357 Don't increment bufsize until after realloc succeeds.
6358 Check for size-calculation overflow.
6359 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6361 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6363 * lread.c: Integer overflow fixes.
6364 (read_integer): Radix is now EMACS_INT, not int,
6365 to improve quality of diagnostics for out-of-range radices.
6366 Calculate buffer size correctly for out-of-range radices.
6367 (read1): Check for integer overflow in radices, and in
6368 read-circle numbers.
6369 (read_escape): Avoid int overflow.
6370 (Fload, openp, read_buffer_size, read1)
6371 (substitute_object_recurse, read_vector, read_list, map_obarray):
6372 Use ptrdiff_t, not int, for sizes.
6373 (read1): Use EMACS_INT, not int, for sizes.
6374 Check for size overflow.
6376 * image.c (cache_image): Check for size arithmetic overflow.
6378 * lread.c: Integer overflow issues.
6379 (saved_doc_string_size, saved_doc_string_length)
6380 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6381 Now ptrdiff_t, not int.
6382 (read1): Don't assume doc string length fits in int. Check for
6383 out-of-range doc string lengths.
6384 (read_list): Don't assume file position fits in int.
6385 (read_escape): Check for hex character overflow.
6387 2011-06-22 Leo Liu <sdl.web@gmail.com>
6389 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6390 Move to minibuffer.el.
6392 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6394 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6395 The following patches are for when GLYPH_DEBUG && !XASSERT.
6396 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6397 * dispnew.c (flush_stdout):
6398 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6399 Mark as externally visible.
6400 * dispnew.c (check_window_matrix_pointers): Now static.
6401 * dispnew.c (window_to_frame_vpos):
6402 * xfns.c (unwind_create_frame):
6403 * xterm.c (x_check_font): Remove unused local.
6404 * scroll.c (CHECK_BOUNDS):
6405 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6406 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6407 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6408 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6409 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6411 (debug_method_add): Use va_list and vsprintf rather than relying
6412 on undefined behavior with wrong number of arguments.
6413 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6414 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6415 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6416 since we're not interested in debugging glyphs with old libraries.
6417 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6418 GCC 4.6.0's static checking.
6420 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6422 Integer overflow and signedness fixes (Bug#8873).
6423 A few related buffer overrun fixes, too.
6425 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6427 * dispextern.h (struct face.stipple):
6428 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6429 (x_bitmap_mask, x_allocate_bitmap_record)
6430 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6431 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6432 (x_create_bitmap_from_xpm_data):
6433 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6434 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6436 * xfaces.c (load_pixmap):
6437 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6438 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6439 (.bitmaps_last, struct x_output.icon_bitmap):
6440 Use ptrdiff_t, not int, for bitmap indexes.
6441 (x_allocate_bitmap_record): Check for size overflow.
6442 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6444 Use ptrdiff_t, not int, for overlay counts.
6445 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6446 * editfns.c (overlays_around, get_pos_property):
6447 * textprop.c (get_char_property_and_overlay):
6448 * xdisp.c (next_overlay_change, note_mouse_highlight):
6449 * xfaces.c (face_at_buffer_position):
6450 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6451 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6452 (Fnext_overlay_change, Fprevious_overlay_change)
6453 (mouse_face_overlay_overlaps, Foverlays_in):
6454 Use ptrdiff_t, not int, for sizes.
6455 (overlays_at, overlays_in): Check for size-calculation overflow.
6457 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6459 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6460 (x_session_initialize): Do not assume string length fits in int.
6462 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6463 This is unlikely, but can occur if DPI is outlandish.
6465 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6466 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6468 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6469 * xrdb.c (magic_file_p, search_magic_path):
6470 Omit last arg SUFFIX; it was always 0. All callers changed.
6471 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6473 * xfont.c (xfont_match): Avoid need for strlen.
6475 * xfns.c: Don't assume strlen fits in int.
6476 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6478 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6479 not unsigned long, as we prefer signed integers. All callers changed.
6480 Detect integer overflow in repeat count.
6481 (message_dolog): Don't assume print length fits in 39 bytes.
6482 (display_mode_element): Don't assume strlen fits in int.
6484 * termcap.c: Don't assume sizes fit in int and never overflow.
6485 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6486 (gobble_line): Check for size-calculation overflow.
6488 * minibuf.c (Fread_buffer):
6489 * lread.c (intern, intern_c_string):
6490 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6491 Don't assume string length fits in int.
6493 * keyboard.c (parse_tool_bar_item):
6494 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6496 * font.c: Don't assume string length fits in int.
6497 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6498 Use ptrdiff_t, not int.
6499 (font_intern_prop): Don't assume string length fits in int.
6500 Don't assume integer property fits in fixnum.
6501 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6503 * filelock.c: Fix some buffer overrun and integer overflow issues.
6504 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6505 Reformulate so as not to need the command string.
6506 Invoke gzip -cd rather than gunzip, as it's more portable.
6507 (lock_info_type, lock_file_1, lock_file):
6508 Don't assume pid_t and time_t fit in unsigned long.
6509 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6510 (current_lock_owner): Prefer signed type for sizes.
6511 Use memcpy, not strncpy, where memcpy is what is really wanted.
6512 Don't assume (via atoi) that time_t and pid_t fit in int.
6513 Check for time_t and/or pid_t out of range, e.g., via a network share.
6514 Don't alloca where an auto var works fine.
6516 * fileio.c: Fix some integer overflow issues.
6517 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6518 Don't assume string length fits in int.
6519 (directory_file_name): Don't assume string length fits in long.
6520 (make_temp_name): Don't assume pid fits in int, or that its print
6521 length is less than 20.
6523 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6525 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6527 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6529 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6530 We prefer signed integers, even for size calculations.
6532 * emacs.c: Don't assume string length fits in 'int'.
6533 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6534 (main): Don't invoke strlen when not needed.
6536 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6537 (XD_DEBUG_MESSAGE): Don't waste a byte.
6539 * callproc.c (getenv_internal_1, getenv_internal)
6541 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6543 * lread.c (invalid_syntax): Omit length argument.
6544 All uses changed. This doesn't fix a bug, but it simplifies the
6545 code away from its former Hollerith-constant appearance, and it's
6546 one less 'int' to worry about when looking at integer-overflow issues.
6547 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6549 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6550 This didn't break anything, but it didn't help either.
6551 It's confusing to put a bogus integer in a place where the actual
6552 value does not matter.
6553 (LIST_END_P): Remove unused macro and its bogus comment.
6554 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6556 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6557 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6559 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6560 We prefer signed types, and the value cannot exceed the EMACS_INT
6561 range anyway (because otherwise the length would not be representable).
6562 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6563 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6564 This avoids a GCC warning when WIDE_EMACS_INT.
6566 * indent.c (sane_tab_width): New function.
6567 (current_column, scan_for_column, Findent_to, position_indentation)
6568 (compute_motion): Use it. This is just for clarity.
6569 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6571 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6573 * lisp.h (lint_assume): New macro.
6574 * composite.c (composition_gstring_put_cache):
6575 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6577 * editfns.c, insdel.c:
6578 Omit unnecessary forward decls, to simplify future changes.
6580 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6582 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6584 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6585 Use much-faster test for byte-length change.
6586 Don't assume string byte-length fits in 'int'.
6587 Check that character arg fits in 'int'.
6588 (mapcar1): Declare byte as byte, for clarity.
6590 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6592 * fns.c (concat): Catch string overflow earlier.
6593 Do not rely on integer wraparound.
6595 * dispextern.h (struct it.overlay_strings_charpos)
6596 (struct it.selective): Now EMACS_INT, not int.
6597 * xdisp.c (forward_to_next_line_start)
6598 (back_to_previous_visible_line_start)
6599 (reseat_at_next_visible_line_start, next_element_from_buffer):
6600 Don't arbitrarily truncate the value of 'selective' to int.
6602 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6604 * composite.c: Don't truncate sizes to 'int'.
6605 (composition_gstring_p, composition_reseat_it)
6606 (composition_adjust_point): Use EMACS_INT, not int.
6607 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6608 not EMACS_UINT, for indexes.
6610 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6612 * buffer.c: Include <verify.h>.
6613 (struct sortvec.priority, struct sortstr.priority):
6614 Now EMACS_INT, not int.
6615 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6616 (struct sortstr.size, record_overlay_string)
6617 (struct sortstrlist.size, struct sortlist.used):
6618 Don't truncate size to int.
6619 (record_overlay_string): Check for size-calculation overflow.
6620 (init_buffer_once): Check at compile-time, not run-time.
6622 2011-06-22 Jim Meyering <meyering@redhat.com>
6624 Don't leak an XBM-image-sized buffer
6625 * image.c (xbm_load): Free the image buffer after using it.
6627 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6630 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6631 that Sun C diagnosed.
6632 * fns.c (secure_hash): Fix pointer signedness issue.
6633 * intervals.c (static_offset_intervals): New function.
6634 (offset_intervals): Use it.
6636 2011-06-21 Leo Liu <sdl.web@gmail.com>
6639 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6642 * fns.c (secure_hash): Rename from crypto_hash_function and change
6643 the first arg to accept symbols.
6644 (Fsecure_hash): New primitive.
6645 (syms_of_fns): New symbols.
6647 2011-06-20 Deniz Dogan <deniz@dogan.se>
6649 * process.c (Fset_process_buffer): Clarify return value in
6652 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6654 * dispnew.c (add_window_display_history): Use BVAR.
6656 * xdisp.c (debug_method_add): Use BVAR.
6657 (check_window_end, dump_glyph_matrix, dump_glyph)
6658 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6660 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6663 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6664 check till after the cache is created in init_frame_faces.
6666 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6668 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6670 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6672 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6673 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6674 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6676 Improve buffer-overflow checking (Bug#8873).
6677 * fileio.c (Finsert_file_contents):
6678 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6679 Remove the old (too-loose) buffer overflow checks.
6680 They weren't needed, since make_gap checks for buffer overflow.
6681 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6682 The old code merely checked for Emacs fixnum overflow, and relied
6683 on undefined (wraparound) behavior. The new code avoids undefined
6684 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6686 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6687 Tune. Don't use wider integers than needed. Don't use alloca.
6688 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6690 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6692 * insdel.c, lisp.h (buffer_overflow): New function.
6693 (insert_from_buffer_1, replace_range, replace_range_2):
6694 * insdel.c (make_gap_larger):
6695 * editfns.c (Finsert_char):
6696 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6698 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6700 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6702 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6704 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6705 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6707 * fileio.c: Don't assume EMACS_INT fits in off_t.
6708 (emacs_lseek): New static function.
6709 (Finsert_file_contents, Fwrite_region): Use it.
6710 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6712 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6714 * fns.c: Don't overflow int when computing a list length.
6715 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6716 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6717 truncation on 64-bit hosts. Check for QUIT every
6718 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6719 faster and is responsive enough.
6720 (Flength): Report an error instead of overflowing an integer.
6721 (Fsafe_length): Return a float if the value is not representable
6722 as a fixnum. This shouldn't happen except in contrived situations.
6723 (Fnthcdr, Fsort): Don't assume list length fits in int.
6724 (Fcopy_sequence): Don't assume vector length fits in int.
6726 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6727 (header_size, word_size): New constants.
6728 (allocate_vectorlike): Don't check size overflow here.
6729 (allocate_vector): Check it here instead, since this is the only
6730 caller of allocate_vectorlike that could cause overflow.
6731 Check that the new vector's length is representable as a fixnum.
6733 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6734 The previous code was bogus. For example, next_almost_prime (32)
6735 returned 39, which is undesirable as it is a multiple of 3; and
6736 next_almost_prime (24) returned 25, which is a multiple of 5 so
6737 why was the code bothering to check for multiples of 7?
6739 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6741 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6743 Variadic C functions now count arguments with ptrdiff_t.
6744 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6745 Back then I didn't know that the Emacs coding style prefers signed int.
6746 Also, in the meantime I found a few more instances where arguments
6747 were being counted with int, which may truncate counts on 64-bit
6748 machines, or EMACS_INT, which may be unnecessarily wide.
6749 * lisp.h (struct Lisp_Subr.function.aMANY)
6750 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6751 Arg counts are now ptrdiff_t, not size_t.
6752 All variadic functions and their callers changed accordingly.
6753 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6754 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6755 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6756 * callint.c (Fcall_interactively): Check arg count for overflow,
6757 to avoid potential buffer overrun. Use signed char, not 'int',
6758 for 'varies' array, so that we needn't bother to check its size
6759 calculation for overflow.
6760 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6761 * eval.c (apply_lambda):
6762 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6763 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6764 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6766 * callint.c (Fcall_interactively): Don't use index var as event count.
6768 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6769 * mem-limits.h (SIZE): Remove; no longer used.
6771 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6773 Remove unnecessary casts.
6774 * xterm.c (x_term_init):
6775 * xfns.c (x_set_border_pixel):
6776 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6777 These aren't needed now that we assume ANSI C.
6779 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6780 It's more likely to cause problems (due to unsigned overflow)
6783 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6785 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6787 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6789 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6791 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6793 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6795 GLYPH_CODE_FACE returns EMACS_INT, not int.
6796 * dispextern.h (merge_faces):
6797 * xfaces.c (merge_faces):
6798 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6799 Don't assume EMACS_INT fits in int.
6801 * character.h (CHAR_VALID_P): Remove unused parameter.
6802 * fontset.c, lisp.h, xdisp.c: All uses changed.
6804 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6806 * fns.c (concat): Minor tuning based on overflow analysis.
6807 This doesn't fix any bugs. Use int to hold character, instead
6808 of constantly refetching from Emacs object. Use XFASTINT, not
6809 XINT, for value known to be a character. Don't bother comparing
6810 a single byte to 0400, as it's always less.
6812 * floatfns.c (Fexpt):
6813 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6815 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6818 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6820 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6821 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6822 incorrectly succeed when S was a string, because 4294967386 was
6823 truncated before it was used.
6825 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6826 Otherwise, an out-of-range integer could cause undefined behavior
6829 * composite.c: Use int, not EMACS_INT, for characters.
6830 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6831 EMACS_INT, for values that are known to be in character range.
6832 This doesn't fix any bugs but is the usual style inside Emacs and
6833 may generate better code on 32-bit machines.
6835 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6836 This is for reasons similar to the recent CHAR_STRING fix.
6837 * charset.c (Fencode_char): Check that character arg is actually
6838 a character. Pass an int to ENCODE_CHAR.
6839 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6840 wider than 'int', as a compile-time check to prevent future regressions
6843 * character.c (char_string): Remove unnecessary casts.
6845 Make sure a 64-bit char is never passed to CHAR_STRING.
6846 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6847 by silently ignoring the top 32 bits, allowing some values
6848 that were far too large to be valid characters.
6849 * character.h: Include <verify.h>.
6850 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6851 arguments are no wider than unsigned, as a compile-time check
6852 to prevent future regressions in this area.
6854 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6855 (Fsubst_char_in_region):
6857 * xdisp.c (decode_mode_spec_coding):
6858 Adjust to CHAR_STRING's new requirement.
6859 * editfns.c (Finsert_char, Fsubst_char_in_region):
6860 * fns.c (concat): Check that character args are actually
6861 characters. Without this test, these functions did the wrong
6862 thing with wildly out-of-range values on 64-bit hosts.
6864 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6865 These casts should not be needed on 32-bit hosts, either.
6866 * keyboard.c (read_char):
6867 * lread.c (Fload): Remove casts to unsigned.
6869 * lisp.h (UNSIGNED_CMP): New macro.
6870 This fixes comparison bugs on 64-bit hosts.
6871 (ASCII_CHAR_P): Use it.
6872 * casefiddle.c (casify_object):
6873 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6874 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6875 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6876 * dispextern.h (FACE_FROM_ID):
6877 * keyboard.c (read_char): Use UNSIGNED_CMP.
6879 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6880 not to EMACS_INT, to avoid GCC warning.
6882 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6884 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6885 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6886 isn't needed on 32-bit machines.
6888 * buffer.c (Fgenerate_new_buffer_name):
6889 Use EMACS_INT for count, not int.
6890 (advance_to_char_boundary): Return EMACS_INT, not int.
6892 * data.c (Qcompiled_function): Now static.
6894 * window.c (window_body_lines): Now static.
6896 * image.c (gif_load): Rename local to avoid shadowing.
6898 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6899 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6900 * alloc.c (make_save_value): Integer argument is now of type
6902 (mark_object): Use ptrdiff_t, not int.
6903 * lisp.h (pD): New macro.
6904 * print.c (print_object): Use it.
6906 * alloc.c: Use EMACS_INT, not int, to count objects.
6907 (total_conses, total_markers, total_symbols, total_vector_size)
6908 (total_free_conses, total_free_markers, total_free_symbols)
6909 (total_free_floats, total_floats, total_free_intervals)
6910 (total_intervals, total_strings, total_free_strings):
6911 Now EMACS_INT, not int. All uses changed.
6912 (Fgarbage_collect): Compute overall total using a double, so that
6913 integer overflow is less likely to be a problem. Check for overflow
6914 when converting back to an integer.
6915 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6916 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6917 These were 'int' variables that could overflow on 64-bit hosts;
6918 they were never used, so remove them instead of repairing them.
6919 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6920 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6921 Previously, this ceilinged at INT_MAX, but that doesn't work on
6923 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6925 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6926 (allocate_vectorlike): Check for ptrdiff_t overflow.
6927 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6928 when a (possibly-narrower) signed value would do just as well.
6929 We prefer using signed arithmetic, to avoid comparison confusion.
6931 * alloc.c: Catch some string size overflows that we were missing.
6932 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6933 for convenience in STRING_BYTES_MAX.
6934 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6935 The definition here is exact; the one in lisp.h was approximate.
6936 (allocate_string_data): Check for string overflow. This catches
6937 some instances we weren't catching before. Also, it catches
6938 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6939 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6940 and ptrdiff_t and EMACS_INT are both 64 bits.
6942 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6943 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6944 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6946 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6948 * alloc.c (Fmake_string): Check for out-of-range init.
6950 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6952 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6954 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6956 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6957 xg_get_default_scrollbar_width.
6959 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6960 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6961 (style_changed_cb): Call update_theme_scrollbar_width and call
6962 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6963 all frames (Bug#8505).
6964 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6965 Call gtk_window_set_resizable if HAVE_GTK3.
6966 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6967 and height if HAVE_GTK3 (Bug#8505).
6968 (scroll_bar_width_for_theme): New variable.
6969 (update_theme_scrollbar_width): New function.
6970 (xg_get_default_scrollbar_width): Move code to
6971 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6972 (xg_initialize): Call update_theme_scrollbar_width.
6974 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6976 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6978 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6980 * frame.c (make_frame): Call other_buffer_safely instead of
6983 * window.c (temp_output_buffer_show): Call display_buffer with
6984 second argument Vtemp_buffer_show_specifiers and reset latter
6985 immediately after the call.
6986 (Vtemp_buffer_show_specifiers): New variable.
6987 (auto_window_vscroll_p, next_screen_context_lines)
6988 (Vscroll_preserve_screen_position): Remove leading asterisks from
6991 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6993 Fix minor problems found by GCC 4.6.0 static checking.
6994 * buffer.c (Qclone_number): Remove for now, as it's unused.
6995 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6996 (record_buffer): Remove unused local.
6997 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6998 (set_frame_buffer_list): Remove; unused.
6999 * frame.h (other_visible_frames): Remove decl.
7000 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7001 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7002 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7004 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7005 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7006 Define only if HAVE_GPM.
7007 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7008 (update_hints_inhibit): Remove; never set. All uses removed.
7009 * widgetprv.h (emacsFrameClassRec): Remove decl.
7010 * window.c (delete_deletable_window): Now returns void, since it
7011 wasn't returning anything.
7012 (compare_window_configurations): Remove unused locals.
7013 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7014 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7015 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7016 the same widths as pointers. This follows up on the 2011-05-06 patch.
7017 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7018 * xterm.h: Likewise.
7019 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7021 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7023 * makefile.w32-in: Update dependencies.
7024 (LISP_H): Add lib/intprops.h.
7026 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7028 * image.c (gif_load): Add animation frame delay to the metadata.
7029 (syms_of_image): Use DEFSYM. New symbol `delay'.
7031 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7033 * window.c (delete_deletable_window): Re-add.
7034 (Fset_window_configuration): Rewrite to handle dead buffers and
7035 consequently deletable windows.
7036 (window_tree, Fwindow_tree): Remove. Supply functionality in
7038 (compare_window_configurations): Simplify code.
7040 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7042 * image.c (imagemagick_load_image): Fix type mismatch.
7043 (Fimagemagick_types): Likewise.
7045 * window.h (replace_buffer_in_windows): Declare.
7047 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7049 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7050 Qclone_number. Remove external declaration of Qdelete_window.
7051 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7053 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7054 Run Qbuffer_list_update_hook if allowed.
7055 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7056 buffer list implementation.
7057 (other_buffer_safely): New function.
7058 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7059 calls to replace_buffer_in_windows and
7060 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7062 (record_buffer): Inhibit quitting and rewrite using quittable
7063 functions. Run Qbuffer_list_update_hook if allowed.
7064 (Frecord_buffer, Funrecord_buffer): New functions.
7065 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7066 Move switch-to-buffer to window.el.
7067 (bury-buffer): Move to window.el.
7068 (Vbuffer_list_update_hook): New variable.
7070 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7073 * window.h (resize_frame_windows): Move up in code.
7074 (Fwindow_frame): Remove EXFUN.
7075 (replace_buffer_in_all_windows): Remove prototype.
7076 (replace_buffer_in_windows_safely): Add prototype.
7078 * window.c: Declare Qdelete_window static again. Move down
7079 declaration of select_count.
7080 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7081 (Fother_window): Move to window.el.
7082 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7083 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7084 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7086 (replace_buffer_in_windows): Implement by calling
7087 Qreplace_buffer_in_windows.
7088 (replace_buffer_in_all_windows): Remove with some functionality
7089 moved into replace_buffer_in_windows_safely.
7090 (replace_buffer_in_windows_safely): New function.
7091 (select_window_norecord, select_frame_norecord): Move in front
7092 of run_window_configuration_change_hook. Remove now obsolete
7094 (Fset_window_buffer): Rewrite doc-string.
7095 Call Qrecord_window_buffer.
7096 (keys_of_window): Move binding for other-window to window.el.
7098 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7100 * dispextern.h (struct image): Replace data member, whose int_val
7101 and ptr_val fields were not used by anything, with a single
7104 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7105 (gif_clear_image, gif_load, imagemagick_load_image)
7106 (gs_clear_image, gs_load): Callers changed.
7108 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7110 * buffer.h: Include <time.h>, for time_t.
7111 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7113 Fix minor problems found by static checking.
7115 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7117 Make identifiers static if they are not used in other modules.
7118 * data.c (Qcompiled_function, Qframe, Qvector):
7119 * image.c (QimageMagick, Qsvg):
7120 * minibuf.c (Qmetadata):
7121 * window.c (resize_window_check, resize_root_window): Now static.
7122 * window.h (resize_window_check, resize_root_window): Remove decls.
7124 * window.c (window_deletion_count, delete_deletable_window):
7126 (window_body_lines): Now static.
7127 (Fdelete_other_windows_internal): Mark vars as initialized.
7128 Make sure 'resize_failed' is initialized.
7129 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7130 (resize_window_apply): Remove unused local.
7131 * window.h (delete_deletable_window): Remove decl.
7133 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7134 (imagemagick_load_image): Fix pointer signedness problem by changing
7135 last arg from unsigned char * to char *. All uses changed.
7136 Also, fix a local for similar reasons.
7137 Remove unused locals. Remove locals to avoid shadowing.
7138 (fn_rsvg_handle_free): Remove; unused.
7139 (svg_load, svg_load_image): Fix pointer signedness problem.
7140 (imagemagick_load_image): Don't use garbage pointer image_wand.
7142 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7144 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7146 * image.c (gif_load): Fix omitted cast error introduced by
7149 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7151 * window.h (resize_proportionally, orig_total_lines)
7152 (orig_top_line): Remove from window structure.
7153 (set_window_height, set_window_width, change_window_heights)
7154 (Fdelete_window): Remove prototypes.
7155 (resize_frame_windows): Remove duplicate declaration.
7157 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7159 * window.h (resize_frame_windows, resize_window_check)
7160 (delete_deletable_window, resize_root_window)
7161 (resize_frame_windows): Declare prototypes.
7163 * window.c (resize_window_apply): Make definition be "static" to
7164 match the prototype.
7166 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7168 * window.c: Remove declarations of Qwindow_size_fixed,
7169 window_min_size_1, window_min_size_2, window_min_size,
7170 size_window, window_fixed_size_p, enlarge_window, delete_window.
7171 Remove static from declaration of Qdelete_window, it's
7172 temporarily needed by Fbury_buffer.
7173 (replace_window): Don't assign orig_top_line and
7175 (Fdelete_window, delete_window): Remove. Window deletion is
7176 handled by window.el.
7177 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7178 Replace Fdelete_window calls with calls to Qdelete_window.
7179 (Fdelete_other_windows): Remove. Deleting other windows is
7180 handled by window.el.
7181 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7182 handled in window.el.
7183 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7184 Window minimum sizes are handled in window.el.
7185 (shrink_windows, size_window, set_window_height)
7186 (set_window_width, change_window_heights, window_height)
7187 (window_width, CURBEG, CURSIZE, enlarge_window)
7188 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7189 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7190 handled in window.el.
7191 (make_dummy_parent): Rename to make_parent_window and give it a
7192 second argument horflag.
7193 (make_window): Don't set resize_proportionally any more.
7194 (Fsplit_window): Remove. Windows are split in window.el.
7195 (save_restore_action, save_restore_orig_size)
7196 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7197 Resize mini windows in window.el.
7198 (grow_mini_window, shrink_mini_window): Implement by calling
7199 Qresize_root_window_vertically, resize_window_check and
7200 resize_window_apply.
7201 (saved_window, Fset_window_configuration, save_window_save):
7202 Do not handle orig_top_line, orig_total_lines, and
7203 resize_proportionally.
7204 (window_min_height, window_min_width): Move to window.el.
7205 (keys_of_window): Move bindings for delete-other-windows,
7206 split-window, delete-window and enlarge-window to window.el.
7208 * buffer.c: Temporarily extern Qdelete_window.
7209 (Fbury_buffer): Temporarily call Qdelete_window instead of
7210 Fdelete_window (Fbury_buffer will move to window.el soon).
7212 * frame.c (set_menu_bar_lines_1): Remove code handling
7213 orig_top_line and orig_total_lines.
7215 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7216 set_window_height but set heights directly.
7217 (change_frame_size_1): Use resize_frame_windows.
7219 * xdisp.c (init_xdisp): Don't use set_window_height but set
7222 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7223 Use resize_frame_windows instead of change_window_heights and run
7224 run_window_configuration_change_hook.
7226 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7227 instead of change_window_heights and run
7228 run_window_configuration_change_hook.
7230 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7232 * window.c (replace_window): Rename second argument REPLACEMENT to
7233 NEW. New third argument SETFLAG. Rewrite.
7234 (delete_window, make_dummy_parent): Call replace_window with
7236 (window_list_1): Move down in code.
7237 (run_window_configuration_change_hook): Move set_buffer part
7238 before select_frame_norecord part in order to unwind correctly.
7239 Rename count1 to count.
7240 (recombine_windows, delete_deletable_window, resize_root_window)
7241 (Fdelete_other_windows_internal)
7242 (Frun_window_configuration_change_hook, make_parent_window)
7243 (resize_window_check, resize_window_apply, Fresize_window_apply)
7244 (resize_frame_windows, Fsplit_window_internal)
7245 (Fdelete_window_internal, Fresize_mini_window_internal):
7247 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7249 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7251 * window.h (window): Add some new members to window structure -
7252 normal_lines, normal_cols, new_total, new_normal, clone_number,
7253 splits, nest, prev_buffers, next_buffers.
7254 (WINDOW_TOTAL_SIZE): Move here from window.c.
7255 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7257 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7259 (make_dummy_parent): Set new members of windows structure.
7260 (make_window): Move down in code. Handle new members of window
7262 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7263 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7264 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7265 (Fset_window_prev_buffers, Fwindow_next_buffers)
7266 (Fset_window_next_buffers, Fset_window_clone_number):
7268 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7269 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7271 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7272 Argument WINDOW can be now internal window too.
7273 (Fwindow_use_time): Move up in code.
7274 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7276 (Fset_window_configuration, saved_window)
7277 (Fcurrent_window_configuration, save_window_save): Handle new
7278 members of window structure.
7279 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7280 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7281 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7282 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7283 Qget_mru_window, Qresize_root_window,
7284 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7285 Qauto_buffer_name; staticpro them.
7287 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7289 * window.c (Fwindow_total_size, Fwindow_left_column)
7290 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7291 (Fwindow_list_1): New functions.
7292 (window_box_text_cols): Replace with window_body_cols.
7293 (Fwindow_width, Fscroll_left, Fscroll_right):
7294 Use window_body_cols instead of window_box_text_cols.
7295 (delete_window, Fset_window_configuration):
7296 Call delete_all_subwindows with window as argument.
7297 (delete_all_subwindows): Take a window as argument and not a
7299 (window_loop): Remove handling of GET_LRU_WINDOW and
7301 (Fget_lru_window, Fget_largest_window): Move to window.el.
7303 * window.h: Extern window_body_cols instead of
7304 window_box_text_cols. delete_all_subwindows now takes a
7305 Lisp_Object as argument.
7307 * indent.c (compute_motion, Fcompute_motion):
7308 Use window_body_cols instead of window_box_text_cols.
7310 * frame.c (delete_frame): Call delete_all_subwindows with root
7313 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7315 * fns.c (Fputhash): Document return value.
7317 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7319 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7321 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7323 Cons<->int and similar integer overflow fixes (Bug#8794).
7325 Check for overflow when converting integer to cons and back.
7326 * charset.c (Fdefine_charset_internal, Fdecode_char):
7327 Use cons_to_unsigned to catch overflow.
7328 (Fencode_char): Use INTEGER_TO_CONS.
7329 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7330 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7331 * data.c (long_to_cons, cons_to_long): Remove.
7332 (cons_to_unsigned, cons_to_signed): New functions.
7333 These signal an error for invalid or out-of-range values.
7334 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7335 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7336 * font.c (Ffont_variation_glyphs):
7337 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7338 * lisp.h: Include <intprops.h>.
7339 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7340 (cons_to_signed, cons_to_unsigned): New decls.
7341 (long_to_cons, cons_to_long): Remove decls.
7342 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7343 (Fprimitive_undo): Use CONS_TO_INTEGER.
7344 * xfns.c (Fx_window_property): Likewise.
7345 * xselect.c: Include <limits.h>.
7346 (x_own_selection, selection_data_to_lisp_data):
7347 Use INTEGER_TO_CONS.
7348 (x_handle_selection_request, x_handle_selection_clear)
7349 (x_get_foreign_selection, Fx_disown_selection_internal)
7350 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7351 (lisp_data_to_selection_data): Use cons_to_unsigned.
7352 (x_fill_property_data): Use cons_to_signed.
7353 Report values out of range.
7355 Check for buffer and string overflow more precisely.
7356 * buffer.h (BUF_BYTES_MAX): New macro.
7357 * lisp.h (STRING_BYTES_MAX): New macro.
7358 * alloc.c (Fmake_string):
7359 * character.c (string_escape_byte8):
7360 * coding.c (coding_alloc_by_realloc):
7361 * doprnt.c (doprnt):
7362 * editfns.c (Fformat):
7364 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7365 since they may not be the same number.
7366 * editfns.c (Finsert_char):
7367 * fileio.c (Finsert_file_contents):
7368 Likewise for BUF_BYTES_MAX.
7370 * image.c: Use ptrdiff_t, not int, for sizes.
7371 (slurp_file): Switch from int to ptrdiff_t.
7373 (slurp_file): Check that file size fits in both size_t (for
7374 malloc) and ptrdiff_t (for sanity and safety).
7376 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7377 if b->modtime has its maximal value.
7379 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7381 Don't assume time_t can fit into int.
7382 * buffer.h (struct buffer.modtime): Now time_t, not int.
7383 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7384 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7386 Minor fixes for signed vs unsigned integers.
7387 * character.h (MAYBE_UNIFY_CHAR):
7388 * charset.c (maybe_unify_char):
7389 * keyboard.c (read_char, reorder_modifiers):
7390 XINT -> XFASTINT, since the integer must be nonnegative.
7391 * ftfont.c (ftfont_spec_pattern):
7392 * keymap.c (access_keymap, silly_event_symbol_error):
7393 XUINT -> XFASTINT, since the integer must be nonnegative.
7394 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7395 since it makes no difference and we prefer signed.
7396 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7397 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7400 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7402 * window.h (Fwindow_frame): Declare.
7404 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7406 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7407 (SPARE_MEMORY): Always define.
7408 (LARGE_REQUEST): Remove.
7409 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7411 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7413 * lisp.h: Move EXFUNS for Fframe_root_window,
7414 Fframe_first_window and Fset_frame_selected_window to window.h.
7416 * window.h: Move EXFUNS for Fframe_root_window,
7417 Fframe_first_window and Fset_frame_selected_window here from
7420 * frame.c (Fwindow_frame, Fframe_first_window)
7421 (Fframe_root_window, Fframe_selected_window)
7422 (Fset_frame_selected_window): Move to window.c.
7423 (Factive_minibuffer_window): Move to minibuf.c.
7424 (Fother_visible_frames_p): New function.
7426 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7428 * window.c (decode_window, decode_any_window): Move up in code.
7429 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7430 (inhibit_frame_unsplittable): Remove unused variable.
7431 (Fwindow_buffer): Move up and rewrite doc-string.
7432 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7433 (Fwindow_prev): New functions.
7434 (Fwindow_frame): Move here from frame.c. Accept any window as
7436 (Fframe_root_window, Fframe_first_window)
7437 (Fframe_selected_window): Move here from frame.c. Accept frame
7438 or arbitrary window as argument. Update doc-strings.
7439 (Fminibuffer_window): Move up in code.
7440 (Fwindow_minibuffer_p): Move up in code and simplify.
7441 (Fset_frame_selected_window): Move here from frame.c.
7443 (Fselected_window, select_window, Fselect_window): Move up in
7444 code. Minor doc-string fixes.
7446 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7448 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7449 Do not assume that spare memory exists; that assumption is valid
7450 only if SYSTEM_MALLOC.
7451 (LARGE_REQUEST): New macro, so that the issue of large requests
7452 is separated from the issue of spare memory.
7454 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7456 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7459 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7461 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7464 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7466 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7468 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7470 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7471 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7473 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7475 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7477 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7479 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7480 (x_clipboard_manager_save): Add return value.
7481 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7483 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7484 Obey Vx_select_enable_clipboard_manager. Catch errors in
7485 x_clipboard_manager_save (Bug#8779).
7486 (Vx_select_enable_clipboard_manager): New variable.
7487 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7489 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7491 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7493 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7495 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7496 in the current matrix if keep_current_p is non-zero.
7498 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7500 * bidi.c (bidi_level_of_next_char): Fix last change.
7502 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7504 Support bidi reordering of text covered by display properties.
7506 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7507 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7508 (bidi_cache_search, bidi_cache_iterator_state)
7509 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7510 (bidi_level_of_next_char, bidi_move_to_visually_next):
7511 Support character positions inside a run of characters covered by a
7513 (bidi_paragraph_init, bidi_resolve_explicit_1)
7514 (bidi_level_of_next_char): Call bidi_fetch_char and
7515 bidi_fetch_char_advance instead of FETCH_CHAR and
7517 (bidi_init_it): Initialize new members.
7518 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7520 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7521 instead of using explicit *_CHAR codes.
7522 (bidi_resolve_explicit, bidi_resolve_weak):
7523 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7524 bidirectional text is supported only in multibyte buffers.
7525 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7526 it to initialize the frame_window_p member of struct bidi_it.
7527 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7528 (bidi_resolve_explicit, bidi_resolve_weak)
7529 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7530 bidi_it->nchars is non-positive.
7531 (bidi_level_of_next_char): Don't try to lookup the cache for the
7532 next/previous character if nothing is cached there yet, or if we
7533 were just reseat()'ed to a new position.
7535 * xdisp.c (set_cursor_from_row): Set start and stop points
7536 according to the row's direction when priming the loop that looks
7537 for the glyph on which to display cursor.
7538 (single_display_spec_intangible_p): Function deleted.
7539 (display_prop_intangible_p): Reimplement to call
7540 handle_display_spec instead of single_display_spec_intangible_p.
7541 Accept 3 additional arguments needed by handle_display_spec.
7542 This fixes incorrect cursor motion across display property with complex
7543 values: lists, `(when COND...)' forms, etc.
7544 (single_display_spec_string_p): Support property values that are
7545 lists with the argument STRING its top-level element.
7546 (display_prop_string_p): Fix the condition for processing a
7547 property that is a list to be consistent with handle_display_spec.
7548 (handle_display_spec): New function, refactored from the
7549 last portion of handle_display_prop.
7550 (compute_display_string_pos): Accept additional argument
7551 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7552 value of a `display' property is a "replacing spec".
7553 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7554 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7555 the display property, but just return a value indicating whether
7556 the display property will replace the characters it covers.
7557 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7558 frame_window_p members of struct bidi_it.
7559 (compute_display_string_pos, compute_display_string_end):
7561 (push_it): Accept second argument POSITION, where pop_it should
7562 jump to continue iteration.
7563 (reseat_1): Initialize bidi_it.disp_pos.
7565 * keyboard.c (adjust_point_for_property): Adjust the call to
7566 display_prop_intangible_p to its new signature.
7568 * dispextern.h (struct bidi_it): New member frame_window_p.
7569 (bidi_init_it): Update prototypes.
7570 (display_prop_intangible_p): Update prototype.
7571 (compute_display_string_pos, compute_display_string_end):
7573 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7576 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7578 Malloc failure behavior now depends on size of allocation.
7579 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7580 * lisp.h: Change signatures accordingly.
7581 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7582 All callers changed. (Bug#8762)
7584 * gnutls.c: Use Emacs's memory allocators.
7585 Without this change, the gnutls library would invoke malloc etc.
7586 directly, which causes problems on non-SYNC_INPUT hosts, and which
7587 runs afoul of improving memory_full behavior. (Bug#8761)
7588 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7589 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7590 xfree instead of the default malloc, realloc, free.
7591 (Fgnutls_boot): No need to check for memory allocation failure,
7592 since xmalloc does that for us.
7594 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7595 * category.c (hash_get_category_set):
7596 * ccl.c (ccl_driver):
7597 * charset.c (Fdefine_charset_internal):
7598 * charset.h (struct charset.hash_index):
7599 * composite.c (get_composition_id, gstring_lookup_cache)
7600 (composition_gstring_put_cache):
7601 * composite.h (struct composition.hash_index):
7602 * dispextern.h (struct image.hash):
7603 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7604 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7605 (hashfn_equal, hashfn_user_defined, make_hash_table)
7606 (maybe_resize_hash_table, hash_lookup, hash_put)
7607 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7608 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7609 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7610 * image.c (make_image, search_image_cache, lookup_image)
7611 (xpm_put_color_table_h):
7612 * lisp.h (struct Lisp_Hash_Table):
7613 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7614 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7615 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7616 * alloc.c (allocate_vectorlike):
7617 Check for overflow in vector size calculations.
7618 * ccl.c (ccl_driver):
7619 Check for overflow when converting EMACS_INT to int.
7620 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7621 need to be updated by these changes.
7622 * fns.c (make_hash_table, maybe_resize_hash_table):
7623 Check for integer overflow with large hash tables.
7624 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7625 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7626 (SXHASH_REDUCE): New macro.
7627 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7628 Use it instead of discarding useful hash info with large hash values.
7629 (sxhash_float): New function.
7630 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7631 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7632 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7633 Rewrite to use FIXNUM_BITS, as this simplifies things.
7634 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7635 Adjust signatures to match updated version of code.
7636 (consing_since_gc): Now EMACS_INT, since a single hash table can
7637 use more than INT_MAX bytes.
7639 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7641 Make it possible to build with GCC-4.6+ -O2 -flto.
7643 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7645 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7647 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7648 Call minibuffer-inactive-mode.
7650 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7652 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7653 Update dependencies.
7655 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7657 * data.c (init_data): Remove code for UTS, this system is not
7660 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7662 Don't force ./temacs to start in terminal mode.
7664 * frame.c (make_initial_frame): Initialize faces in all cases, not
7665 only when CANNOT_DUMP is defined.
7666 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7668 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7670 * dispnew.c (add_window_display_history): Use const for the string
7671 pointer. Remove declaration, not needed.
7673 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7675 Use 'inline', not 'INLINE'.
7676 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7677 * alloc.c, fontset.c (INLINE): Remove.
7678 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7679 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7680 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7681 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7682 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7684 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7686 Make it possible to run ./temacs.
7688 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7689 syms_of_callproc does the same thing. Remove test for
7690 "initialized", do it in the caller.
7691 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7693 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7695 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7696 (read_minibuf): Use get_minibuffer.
7697 (syms_of_minibuf): Use DEFSYM.
7698 (Qmetadata): New var.
7699 * data.c (Qbuffer): Don't make it static.
7700 (syms_of_data): Use DEFSYM.
7702 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7704 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7705 (CCL_CODE_MIN): New macro.
7707 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7709 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7711 * eval.c (Qdebug): Now static.
7712 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7713 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7714 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7716 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7718 * image.c: Various fixes to ImageMagick code comments.
7719 (Fimagemagick_types): Doc fix.
7721 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7723 Minor fixes prompted by GCC 4.6.0 warnings.
7725 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7727 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7728 (x_clipboard_manager_save_all): Move extern decl to ...
7729 * xterm.h: ... here, so that it can be checked for consistency.
7731 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7733 * xselect.c (x_clipboard_manager_save_frame)
7734 (x_clipboard_manager_save_all): New functions.
7735 (Fx_clipboard_manager_save): Lisp function deleted.
7737 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7738 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7740 * xterm.h: Update prototype.
7742 2011-05-28 William Xu <william.xwl@gmail.com>
7744 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7747 2011-05-28 Jim Meyering <meyering@redhat.com>
7749 Avoid a sign-extension bug in crypto_hash_function.
7750 * fns.c (to_uchar): Define.
7751 (crypto_hash_function): Use it to convert some newly-signed
7752 variables to unsigned, to avoid sign-extension bugs. For example,
7753 without this change, (md5 "truc") would evaluate to
7754 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7755 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7756 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7758 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7760 Integer overflow fixes.
7762 * dbusbind.c: Serial number integer overflow fixes.
7763 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7764 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7765 to hold a serial number that is too large for a fixnum.
7766 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7767 Check for serial numbers out of range. Decode any serial number
7768 that was so large that it became a float. (Bug#8722)
7770 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7771 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7772 Use XFASTINT rather than XUINT when numbers are nonnegative.
7773 (xd_append_arg, Fdbus_method_return_internal):
7774 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7775 arguments, check that Lisp number is nonnegative, rather than
7776 silently wrapping negative numbers around. (Bug#8722)
7777 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7780 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7782 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7784 ccl: Add integer overflow checks.
7785 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7786 (IN_INT_RANGE): New macros.
7787 (ccl_driver): Use them to check for integer overflow when
7788 decoding a CCL program. Many of the new checks are whether XINT (x)
7789 fits in int; it doesn't always, on 64-bit hosts. The new version
7790 doesn't catch all possible integer overflows, but it's an
7791 improvement. (Bug#8719)
7793 * alloc.c (make_event_array): Use XINT, not XUINT.
7794 There's no need for unsigned here.
7796 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7797 This follows up to the 2011-05-06 change that substituted uintptr_t
7798 for EMACS_INT. This case wasn't caught back then.
7800 Rework Fformat to avoid integer overflow issues.
7801 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7802 now (part of C89). Include <verify.h>.
7803 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7804 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7805 (Fformat): Avoid the prepass trying to compute sizes; it was only
7806 approximate and thus did not catch overflow reliably. Instead, walk
7807 through the format just once, formatting and computing sizes as we go,
7808 checking for integer overflow at every step, and allocating a larger
7809 buffer as needed. Keep track separately whether the format is
7810 multibyte. Keep only the most-recently calculated precision, rather
7811 than them all. Record whether each argument has been converted to
7812 string. Use EMACS_INT, not int, for byte and char and arg counts.
7813 Support field widths and precisions larger than INT_MAX. Avoid
7814 sprintf's undefined behavior with conversion specifications such as %#d
7815 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7816 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7817 formatting out-of-range floating point numbers with int
7820 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7822 * data.c: Avoid integer truncation in expressions involving floats.
7823 * data.c: Include <intprops.h>.
7824 (arith_driver): When there's an integer overflow in an expression
7825 involving floating point, convert the integers to floating point
7826 so that the resulting value does not suffer from catastrophic
7827 integer truncation. For example, on a 64-bit host (* 4
7828 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7829 Do not rely on undefined behavior after integer overflow.
7831 merge count_size_as_multibyte, parse_str_to_multibyte
7832 * character.c, character.h (count_size_as_multibyte):
7833 Rename from parse_str_to_multibyte; all uses changed.
7834 Check for integer overflow.
7835 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7836 since it's now a duplicate of the other. This is more of
7837 a character than a buffer op, so better that it's in character.c.
7838 * fns.c, print.c: Adjust to above changes.
7840 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7842 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7844 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7846 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7847 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7848 (x_clipboard_manager_save): Now static.
7849 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7851 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7852 (crypto_hash_function): Now static.
7853 Fix pointer signedness problems. Avoid unnecessary initializations.
7855 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7857 * termhooks.h (Vselection_alist): Make it terminal-local.
7859 * terminal.c (create_terminal): Initialize it.
7861 * xselect.c: Support for clipboard managers.
7862 (Vselection_alist): Move to termhooks.h as terminal-local var.
7863 (LOCAL_SELECTION): New macro.
7864 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7865 (symbol_to_x_atom): Remove gratuitous arg.
7866 (x_handle_selection_request, lisp_data_to_selection_data)
7867 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7868 (x_own_selection, x_get_local_selection, x_convert_selection):
7869 New arg, specifying work frame. Use terminal-local Vselection_alist.
7870 (some_frame_on_display): Delete unused function.
7871 (Fx_own_selection_internal, Fx_get_selection_internal)
7872 (Fx_disown_selection_internal, Fx_selection_owner_p)
7873 (Fx_selection_exists_p): New optional frame arg.
7874 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7875 (x_handle_selection_clear): Don't treat other terminals with the
7876 same keyboard specially. Use the terminal-local Vselection_alist.
7877 (x_clear_frame_selections): Use Frun_hook_with_args.
7879 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7881 * xterm.h: Add support for those atoms.
7883 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7885 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7886 (converted_selections, conversion_fail_tag): New global variables.
7887 (x_selection_request_lisp_error): Free the above.
7888 (x_get_local_selection): Remove unnecessary code.
7889 (x_reply_selection_request): Args changed; handle arbitrary array
7890 of converted selections stored in converted_selections.
7891 Separate the XChangeProperty and SelectionNotify steps.
7892 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7893 (x_convert_selection): New function.
7894 (x_handle_selection_event): Simplify.
7895 (x_get_foreign_selection): Don't ignore incoming requests while
7896 waiting for an answer; this will fail when we implement
7897 SAVE_TARGETS, and seems unnecessary anyway.
7898 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7899 (Vx_sent_selection_functions): Doc fix.
7901 2011-05-26 Leo Liu <sdl.web@gmail.com>
7903 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7905 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7907 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7909 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7910 for fringe update if it has periodic bitmap.
7911 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7912 and fringe_bitmap_periodic_p.
7914 * fringe.c (get_fringe_bitmap_data): New function.
7915 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7916 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7917 row. Mark glyph row for fringe update if periodicity changed.
7919 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7920 for fringe update unless it has periodic bitmap.
7922 2011-05-25 Kenichi Handa <handa@m17n.org>
7924 * xdisp.c (get_next_display_element): Set correct it->face_id for
7925 a static composition.
7927 2011-05-24 Leo Liu <sdl.web@gmail.com>
7930 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7932 * fns.c (crypto_hash_function, Fsha1): New function.
7933 (Fmd5): Use crypto_hash_function.
7934 (syms_of_fns): Add Ssha1.
7936 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7938 * gnutls.c: Remove unused macros.
7939 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7940 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7941 Remove macros that are defined and never used.
7942 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7944 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7946 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7947 (Fx_get_selection_internal): Minor cleanup.
7948 (Fx_own_selection_internal): Rename arguments for consistency with
7951 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7953 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7955 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7957 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7959 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7961 * dispnew.c (scrolling_window): Don't exclude the case that the
7962 last enabled row in the desired matrix touches the bottom boundary.
7964 2011-05-21 Glenn Morris <rgm@gnu.org>
7966 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7967 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7968 and add some more files.
7970 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7972 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7973 report_file_error introduced by the change from 2011-05-07.
7975 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7977 * systime.h (Time): Define only if emacs is defined.
7978 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7979 where the include path doesn't have X11/X.h by default. See
7980 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7982 2011-05-20 Kenichi Handa <handa@m17n.org>
7984 * composite.c (find_automatic_composition): Fix previous change.
7986 2011-05-20 Glenn Morris <rgm@gnu.org>
7988 * lisp.mk: New file, split from Makefile.in.
7989 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7990 (shortlisp): Remove.
7991 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7993 2011-05-19 Glenn Morris <rgm@gnu.org>
7995 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7996 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7997 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7998 (lisp): Set the order to that of loadup.el.
7999 (shortlisp): Make it a copy of $lisp.
8000 (SOME_MACHINE_LISP): Remove.
8001 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8002 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8004 2011-05-18 Kenichi Handa <handa@m17n.org>
8006 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8007 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8008 (find_automatic_composition): Mostly rewrite for efficiency.
8010 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8012 * makefile.w32-in: Update dependencies.
8014 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8016 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8017 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8019 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8021 Fix some integer overflow issues, such as string length overflow.
8023 * insdel.c (count_size_as_multibyte): Check for string overflow.
8025 * character.c (lisp_string_width): Check for string overflow.
8026 Use EMACS_INT, not int, for string indexes and lengths; in
8027 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8028 the resulting string length overflows an EMACS_INT; instead,
8029 report a string overflow if no precision given. When checking for
8030 precision exhaustion, use a check that cannot possibly have
8031 integer overflow. (Bug#8675)
8032 * character.h (lisp_string_width): Adjust to new signature.
8034 * alloc.c (string_overflow): New function.
8035 (Fmake_string): Use it. This doesn't change behavior, but saves
8036 a few bytes and will simplify future changes.
8037 * character.c (string_escape_byte8): Likewise.
8038 * lisp.h (string_overflow): New decl.
8040 Fixups, following up to the user-interface timestamp change.
8041 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8042 for UI timestamps, instead of unsigned long.
8043 * msdos.c (mouse_get_pos): Likewise.
8044 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8045 * w32gui.h (Time): Define by including "systime.h" rather than by
8046 declaring it ourselves. (Bug#8664)
8048 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8049 * image.c (clear_image_cache): Likewise.
8051 * term.c (term_mouse_position): Don't assume time_t wraparound.
8053 Be more systematic about user-interface timestamps.
8054 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8055 and sometimes 'EMACS_UINT', to represent these timestamps.
8056 This change causes it to use 'Time' uniformly, as that's what X uses.
8057 This makes the code easier to follow, and makes it easier to catch
8058 integer overflow bugs such as Bug#8664.
8059 * frame.c (Fmouse_position, Fmouse_pixel_position):
8060 Use Time, not unsigned long, for user-interface timestamps.
8061 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8062 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8063 * keyboard.h (last_event_timestamp): Likewise.
8064 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8065 * menu.h (xmenu_show): Likewise.
8066 * term.c (term_mouse_position): Likewise.
8067 * termhooks.h (struct input_event.timestamp): Likewise.
8068 (struct terminal.mouse_position_hook): Likewise.
8069 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8070 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8071 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8072 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8074 * menu.h, termhooks.h: Include "systime.h", for Time.
8076 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8077 Don't assume that the difference between two unsigned long values
8078 can fit into an integer. At this point, we know button_down_time
8079 <= event->timestamp, so the difference must be nonnegative, so
8080 there's no need to cast the result if double-click-time is
8081 nonnegative, as it should be; check that it's nonnegative, just in
8082 case. This bug is triggered when events are more than 2**31 ms
8083 apart (about 25 days). (Bug#8664)
8085 * xselect.c (last_event_timestamp): Remove duplicate decl.
8086 (x_own_selection): Remove needless cast to unsigned long.
8088 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8089 that always fit in int. Use a sentinel instead of a counter, to
8090 avoid a temp and to allay GCC's concerns about possible int overflow.
8091 * frame.h (struct frame): Use int for menu_bar_items_used
8092 instead of EMACS_INT, since it always fits in int.
8094 * menu.c (grow_menu_items): Check for int overflow.
8096 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8098 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8099 Before, the code was not consistent. These values cannot exceed
8100 2**31 - 1 so there's no need to make them unsigned.
8101 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8102 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8103 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8105 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8107 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8108 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8109 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8110 presumably because the widths might not match.
8112 * window.c (size_window): Avoid needless test at loop start.
8114 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8116 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8118 2011-05-12 Drew Adams <drew.adams@oracle.com>
8120 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8122 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8124 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8125 `width' to `bar_area_x' and `bar_area_width', respectively.
8126 (x_scroll_run): Take account of fringe background extension.
8128 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8129 Rename local vars `left' and `width' to `bar_area_x' and
8130 `bar_area_width', respectively.
8131 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8132 background extension.
8134 2011-05-10 Jim Meyering <meyering@redhat.com>
8136 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8138 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8140 * image.c (Finit_image_library): Return t for built-in image types,
8141 like pbm and xbm. (Bug#8640)
8143 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8145 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8147 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8149 * w32console.c (Fset_screen_color): Doc fix.
8150 (Fget_screen_color): New function.
8151 (syms_of_ntterm): Defsubr it.
8153 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8154 unlink the temporary file if Fcall_process didn't create it in the
8156 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8157 child process will be redirected to a file specified with `:file'.
8158 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8159 cue to call_process_cleanup not to close that handle.
8161 2011-05-07 Ben Key <bkey76@gmail.com>
8163 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8164 one of two shell specific rules, either bootstrap-temacs-CMD or
8165 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8166 to the previous implementation of the bootstrap-temacs rule.
8167 The bootstrap-temacs-CMD rule is similar to the previous
8168 implementation of the bootstrap-temacs rule except that it
8169 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8172 These changes, along with some changes to nt/configure.bat,
8173 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8174 earlier fix to add support for --cflags and --ldflags options
8175 that include quotes so that it works whether make uses cmd or
8178 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8180 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8181 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8183 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8184 a string. Handle both cases.
8185 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8186 (Fdbus_register_method): Use Qinvalid_function.
8188 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8190 * makefile.w32-in: Update dependencies.
8191 (LISP_H): Add inttypes.h and stdin.h.
8192 (PROCESS_H): Add unistd.h.
8194 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8196 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8197 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8199 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8201 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8203 * term.c (vfatal): Remove stray call to va_end.
8204 It's not needed and the C Standard doesn't allow it here anyway.
8206 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8207 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8209 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8212 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8214 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8216 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8218 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8220 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8222 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8223 * charset.c (Fdefine_charset_internal): Don't initialize
8224 charset.code_space[15]. The value was garbage, on hosts with
8225 32-bit int (Bug#8600).
8227 * lread.c (read_integer): Be more consistent with string-to-number.
8228 Use string_to_number to do the actual conversion; this avoids
8229 rounding errors and fixes some other screwups. Without this fix,
8230 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8231 (digit_to_number): Move earlier, for benefit of read_integer.
8232 Return -1 if the digit is out of range for the base, -2 if it is
8233 not a digit in any supported base. (Bug#8602)
8235 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8237 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8238 to match comment at start of function. This also removes a
8239 GCC warning about overflow in a 32+64-bit port.
8241 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8243 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8244 Reported by Stefan Monnier in
8245 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8246 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8247 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8249 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8250 (EMACS_UINTPTR): Likewise, with uintptr_t.
8252 * lisp.h: Prefer 64-bit EMACS_INT if available.
8253 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8254 on 32-bit hosts that have 64-bit int, so that they can access
8256 However, temporarily disable this change unless the temporary
8257 symbol WIDE_EMACS_INT is defined.
8259 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8261 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8262 This removes an assumption that EMACS_INT and long are the same
8263 width as pointers. The assumption is true for Emacs porting targets
8264 now, but we want to make other targets possible.
8265 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8266 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8267 In the rest of the code, change types of integers that hold casted
8268 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8269 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8270 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8271 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8272 No need to cast type when ORing.
8273 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8274 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8275 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8276 assume EMACS_INT is the same width as char *.
8277 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8278 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8279 Remove no-longer-needed casts.
8280 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8281 (xg_tool_bar_help_callback, xg_make_tool_item):
8282 Use EMACS_INTPTR to hold an integer
8283 that will be cast to void *; this can avoid a GCC warning
8284 if EMACS_INT is not the same width as void *.
8285 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8286 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8287 (current_message_1, set_message_1):
8288 Use a local to convert to proper width without a cast.
8289 * xmenu.c (dialog_selection_callback): Likewise.
8291 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8292 Also, don't assume VALBITS / RAND_BITS is less than 5,
8293 and don't rely on undefined behavior when shifting a 1 left into
8295 * lisp.h (get_random): Change signature to match.
8297 * lread.c (hash_string): Use size_t, not int, for hash computation.
8298 Normally we prefer signed values; but hashing is special, because
8299 it's better to use unsigned division on hash table sizes so that
8300 the remainder is nonnegative. Also, size_t is the natural width
8301 for hashing into memory. The previous code used 'int', which doesn't
8302 retain enough info to hash well into very large tables.
8303 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8305 * dbusbind.c: Don't possibly lose pointer info when converting.
8306 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8307 Use XPNTR rather than XHASH, so that the high-order bits of
8308 the pointer aren't lost when converting through void *.
8310 * eval.c (Fautoload): Don't double-shift a pointer.
8312 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8314 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8316 * gnutls.c (DEF_GNUTLS_FN):
8317 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8319 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8321 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8324 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8326 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8327 New version that can reserve upto 2GB of heap space.
8329 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8331 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8333 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8335 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8336 `gnutls_certificate_set_x509_key_file'.
8338 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8340 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8341 Update dependencies.
8343 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8345 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8346 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8347 Remove unused parameter `fildes'.
8348 * process.c (read_process_output, send_process): Don't pass it.
8350 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8352 Fix previous change: the library cache is defined in w32.c.
8353 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8354 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8356 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8358 Implement dynamic loading of GnuTLS on Windows.
8360 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8361 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8362 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8365 * gnutls.c (Qgnutls_dll): Define.
8366 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8367 (gnutls_*): Declare function pointers.
8368 (init_gnutls_functions): New function to initialize function pointers.
8369 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8370 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8371 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8372 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8373 (emacs_gnutls_write, emacs_gnutls_read)
8374 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8375 (Fgnutls_available_p): New function.
8376 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8377 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8378 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8380 * image.c: Include w32.h.
8381 (Vimage_type_cache): Delete.
8382 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8383 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8384 (w32_delayed_load): Move to w32.c.
8386 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8388 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8389 (w32_delayed_load): Move from image.c. When loading a library, record
8390 its filename in the :loaded-from property of the library id.
8391 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8392 Initialize and staticpro them.
8393 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8395 * process.c: Include lisp.h before w32.h, not after.
8396 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8397 instead of gnutls_record_check_pending.
8399 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8401 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8403 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8404 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8407 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8409 * xterm.c (x_set_frame_alpha): Do not set property on anything
8410 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8412 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8414 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8416 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8418 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8419 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8420 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8421 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8422 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8423 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8424 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8425 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8426 (Qgnutls_bootprop_callbacks_verify): Make static.
8428 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8430 * callproc.c: Indentation fixup.
8432 * sysdep.c (wait_for_termination_1): Make static.
8433 (wait_for_termination, interruptible_wait_for_termination):
8434 Move after wait_for_termination_1.
8436 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8438 * sysdep.c (interruptible_wait_for_termination): New function
8439 which is like wait_for_termination, but allows keyboard
8442 * callproc.c (Fcall_process): Add (:file "file") as an option for
8444 (Fcall_process_region): Ditto.
8446 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8448 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8449 rather than `XVECTOR (FOO)->size'.
8451 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8452 inttypes.h, as a gnulib replacement is used if it not available in
8455 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8457 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8458 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8459 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8461 * coding.c (coding_alloc_by_realloc): Error out if destination
8462 will grow beyond MOST_POSITIVE_FIXNUM.
8463 (decode_coding_emacs_mule): Abort if there isn't enough place in
8464 charbuf for the composition carryover bytes. Reserve an extra
8465 space for up to 2 characters produced in a loop.
8466 (decode_coding_iso_2022): Abort if there isn't enough place in
8467 charbuf for the composition carryover bytes.
8469 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8471 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8472 aborting when %lld or %lll format is passed.
8473 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8474 %llo or %llx format is passed. (Bug#8545)
8476 * window.c (window_scroll_line_based): Use a marker instead of
8477 simple variables to record original value of point. (Bug#7952)
8479 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8480 produced by %s or %c overflows available buffer space. (Bug#8545)
8482 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8484 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8485 (SIZE_MAX): Move defn after all includes, as they might #define it.
8487 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8489 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8491 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8493 * keyboard.c (Qdelayed_warnings_hook): Define.
8494 (command_loop_1): Run `delayed-warnings-hook'
8495 if Vdelayed_warnings_list is non-nil.
8496 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8497 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8499 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8501 * doprnt.c (doprnt): Don't return value smaller than the buffer
8502 size if the message was truncated. (Bug#8545).
8504 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8506 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8507 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8509 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8511 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8513 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8515 * makefile.w32-in: Update dependencies.
8517 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8519 Improve `doprnt' and its usage. (Bug#8545)
8520 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8521 `format_end'. Remove support for %l as a conversion specifier.
8522 Don't use xrealloc. Improve diagnostics when the %l size modifier
8523 is used. Update the commentary.
8525 * eval.c (verror): Simplify calculation of size_t.
8527 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8530 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8532 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8535 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8537 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8538 This makes this file independent of the recent pseudovector change.
8540 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8542 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8544 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8545 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8546 Remove unused local.
8547 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8549 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8550 GCC 4.6.0 optimizes based on type-based alias analysis.
8551 For example, if b is of type struct buffer * and v of type struct
8552 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8553 != &v->size, and therefore "v->size = 1; b->size = 2; return
8554 v->size;" must therefore return 1. This assumption is incorrect
8555 for Emacs, since it type-puns struct Lisp_Vector * with many other
8556 types. To fix this problem, this patch adds a new type struct
8557 vectorlike_header that documents the constraints on layout of vectors
8558 and pseudovectors, and helps optimizing compilers not get fooled
8559 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8560 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8561 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8563 (XSETPVECTYPE): Rewrite in terms of new macro.
8564 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8565 This is a bit clearer, and further avoids the possibility of
8566 undesirable aliasing.
8567 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8568 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8569 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8570 since Lisp_Subr is a special case (no "next" field).
8571 (ASIZE): Now uses header.size rather than size.
8572 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8573 to avoid the hassle of writing XVECTOR (foo)->header.size.
8574 (struct vectorlike_header): New type.
8575 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8576 object, to help avoid aliasing.
8577 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8578 (SUBRP): Likewise, since Lisp_Subr is a special case.
8579 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8580 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8581 (struct Lisp_Hash_Table): Combine first two members into a single
8582 struct vectorlike_header member. All uses of "size" and "next" members
8583 changed to be "header.size" and "header.next".
8584 * buffer.h (struct buffer): Likewise.
8585 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8586 * frame.h (struct frame): Likewise.
8587 * process.h (struct Lisp_Process): Likewise.
8588 * termhooks.h (struct terminal): Likewise.
8589 * window.c (struct save_window_data, struct saved_window): Likewise.
8590 * window.h (struct window): Likewise.
8591 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8592 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8593 * buffer.c (init_buffer_once): Likewise.
8594 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8596 * process.c (Fformat_network_address): Use local var for size,
8599 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8601 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8602 * data.c (atof): Remove decl; no longer used or needed.
8603 (digit_to_number): Move to lread.c.
8604 (Fstring_to_number): Use new string_to_number function, to be
8605 consistent with how the Lisp reader treats infinities and NaNs.
8606 Do not assume that floating-point numbers represent EMACS_INT
8607 without losing information; this is not true on most 64-bit hosts.
8608 Avoid double-rounding errors, by insisting on integers when
8609 parsing non-base-10 numbers, as the documentation specifies.
8610 * lisp.h (string_to_number): New decl, replacing ...
8611 (isfloat_string): Remove.
8612 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8613 (read1): Do not accept +. and -. as integers; this
8614 appears to have been a coding error. Similarly, do not accept
8615 strings like +-1e0 as floating point numbers. Do not report
8616 overflow for integer overflows unless the base is not 10 which
8617 means we have no simple and reliable way to continue.
8618 Break out the floating-point parsing into a new
8619 function string_to_number, so that Fstring_to_number parses
8620 floating point numbers consistently with the Lisp reader.
8621 (digit_to_number): Move here from data.c. Make it static inline.
8622 (E_CHAR, EXP_INT): Remove, replacing with ...
8623 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8624 (string_to_number): New function, replacing isfloat_string.
8625 This function checks for valid syntax and produces the resulting
8626 Lisp float number too. Rework it so that string-to-number
8627 no longer mishandles examples like "1.0e+". Use strtoumax,
8628 so that overflow for non-base-10 numbers is reported only when
8629 there's no portable and simple way to convert to floating point.
8631 * textprop.c (set_text_properties_1): Rewrite for clarity,
8632 and to avoid GCC warning about integer overflow.
8634 * intervals.h (struct interval): Use EMACS_INT for members
8635 where EMACS_UINT might cause problems. See
8636 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8637 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8638 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8640 (offset_intervals): Tell GCC not to worry about length overflow
8641 when negating a negative length.
8643 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8644 (overrun_check_free): Likewise.
8646 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8647 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8650 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8651 (gnutls_make_error): Rename local to avoid shadowing.
8652 (gnutls_emacs_global_deinit): ifdef out; not used.
8653 (Fgnutls_boot): Use const for pointer to readonly storage.
8654 Comment out unused local. Fix pointer signedness problems.
8656 * lread.c (openp): Don't stuff size_t into an 'int'.
8657 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8658 about possible signed overflow.
8660 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8661 (GDK_KEY_g): Don't define if already defined.
8662 (xg_prepare_tooltip): Avoid pointer signedness problem.
8663 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8665 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8666 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8668 * xfns.c (Fx_window_property): Simplify a bit,
8669 to make a bit faster and to avoid GCC 4.6.0 warning.
8670 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8672 * fns.c (internal_equal): Don't assume size_t fits in int.
8674 * alloc.c (compact_small_strings): Tighten assertion a little.
8676 Replace pEd with more-general pI, and fix some printf arg casts.
8677 * lisp.h (pI): New macro, generalizing old pEd macro to other
8678 conversion specifiers. For example, use "...%"pI"d..." rather
8679 than "...%"pEd"...".
8680 (pEd): Remove. All uses replaced with similar uses of pI.
8681 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8682 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8683 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8684 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8685 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8686 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8687 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8689 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8690 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8691 * print.c (safe_debug_print, print_object): Likewise.
8692 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8694 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8695 avoiding the 0 flag, which is not portable.
8696 * process.c (Fmake_network_process): Use pI to avoid cast.
8697 * region-cache.c (pp_cache): Likewise.
8698 * xdisp.c (decode_mode_spec): Likewise.
8699 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8700 behavior on 64-bit hosts with printf arg.
8701 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8702 (x_stop_queuing_selection_requests): Likewise.
8703 (x_get_window_property): Don't truncate byte count to an 'int'
8706 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8707 here, since it parses constructs like leading '-' and spaces,
8708 which are not wanted; and it overflows with large numbers.
8709 Instead, simply match F[0-9]+, which is what is wanted anyway.
8711 * alloc.c: Remove unportable assumptions about struct layout.
8712 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8713 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8714 (allocate_vectorlike, make_pure_vector): Use the new macros,
8715 plus offsetof, to remove unportable assumptions about struct layout.
8716 These assumptions hold on all porting targets that I know of, but
8717 they are not guaranteed, they're easy to remove, and removing them
8718 makes further changes easier.
8720 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8721 This doesn't fix a bug but makes the code clearer.
8722 (string_overrun_cookie): Now const. Use initializers that
8723 don't formally overflow signed char, to avoid warnings.
8724 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8725 can cause Emacs to crash when string overrun checking is enabled.
8726 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8727 multiple of sizeof (EMACS_INT); it need not be, if
8728 alignof(EMACS_INT) < sizeof (EMACS_INT).
8729 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8731 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8733 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8735 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8737 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8738 supposed to be handshaking. (Bug#8556)
8739 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8741 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8743 * lisp.h (Qdebug): List symbol.
8744 * eval.c (Qdebug): Restore global linkage.
8745 * keyboard.c (debug-on-event): New variable.
8746 (handle_user_signal): Break into debugger when debug-on-event
8747 matches the current signal symbol.
8749 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8751 * alloc.c (check_sblock, check_string_bytes)
8752 (check_string_free_list): Convert to standard C.
8754 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8756 * w32.c (emacs_gnutls_push): Fix typo.
8758 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8760 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8761 "cast to pointer from integer of different size".
8763 Improve doprnt and its use in verror. (Bug#8545)
8764 * doprnt.c (doprnt): Document the set of format control sequences
8765 supported by the function. Use SAFE_ALLOCA instead of always
8768 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8769 is one byte too soon. Don't use xrealloc; instead xfree and
8772 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8774 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8777 * gnutls.c: Renamed global_initialized to
8778 gnutls_global_initialized. Added internals for the
8779 :verify-hostname-error, :verify-error, and :verify-flags
8780 parameters of `gnutls-boot' and documented those parameters in the
8781 docstring. Start callback support.
8782 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8783 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8784 on error. Return error code.
8785 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8786 (emacs_gnutls_read): Likewise.
8787 (Fgnutls_boot): Return handshake error code.
8788 (emacs_gnutls_handle_error): New function.
8789 (wsaerror_to_errno): Likewise.
8791 * w32.h (emacs_gnutls_pull): Add prototype.
8792 (emacs_gnutls_push): Likewise.
8794 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8795 (emacs_gnutls_push): Likewise.
8797 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8799 * process.c (wait_reading_process_output): Check if GnuTLS
8800 buffered some data internally if no FDs are set for TLS
8803 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8804 (LIBS): Link to USER_LIBS.
8805 ($(BLD)/gnutls.$(0)): New target.
8807 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8809 * xdisp.c (handle_single_display_spec): Rename the
8810 display_replaced_before_p argument into display_replaced_p, to
8811 make it consistent with the commentary. Fix typos in the
8814 * textprop.c (syms_of_textprop): Remove dead code.
8815 (copy_text_properties): Delete obsolete commentary about an
8816 interface that was deleted long ago. Fix typos in the description
8819 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8820 to changes in oldXMenu/XMenu.h from 2011-04-16.
8821 <menu_help_message, prev_menu_help_message>: Constify.
8822 (IT_menu_make_room): menu->help_text is now `const char **';
8825 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8826 to changes in oldXMenu/XMenu.h from 2011-04-16.
8827 (struct XMenu): Declare `help_text' `const char **'.
8829 * xfaces.c <Qunspecified>: Make extern again.
8831 * syntax.c: Include sys/types.h before including regex.h, as
8834 * doc.c (get_doc_string): Improve the format passed to `error'.
8836 * doprnt.c (doprnt): Improve commentary.
8838 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8840 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8843 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8844 changes in globals.h immediately force recompilation.
8845 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8846 $(CURDIR)/s/ms-w32.h.
8847 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8849 * character.c (Fchar_direction): Function deleted.
8850 (syms_of_character): Don't defsubr it.
8851 <char-direction-table>: Deleted.
8853 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8855 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8856 * doprnt.c: Include limits.h.
8857 (SIZE_MAX): New macro.
8858 (doprnt): Return a size_t value. 2nd arg is now size_t.
8859 Many local variables are now size_t instead of int or unsigned.
8860 Improve overflow protection. Support `l' modifier for integer
8861 conversions. Support %l conversion. Don't assume an EMACS_INT
8862 argument for integer conversions and for %c.
8864 * lisp.h (doprnt): Restore prototype.
8866 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8869 * Makefile.in (base_obj): Add back doprnt.o.
8871 * deps.mk (doprnt.o): Add back prerequisites.
8872 (callint.o): Depend on character.h.
8874 * eval.c (internal_lisp_condition_case): Include the handler
8875 representation in the error message.
8876 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8877 when breaking from the loop.
8879 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8881 * callint.c (Fcall_interactively): When displaying error message
8882 about invalid control letter, pass the character's codepoint, not
8883 a pointer to its multibyte form. Improve display of the character
8884 in octal and display also its hex code.
8886 * character.c (char_string): Use %x to display the (unsigned)
8887 codepoint of an invalid character, to avoid displaying a bogus
8890 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8891 `error', not SYMBOL_NAME itself.
8893 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8894 character arguments to `error'.
8896 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8897 to `error' in error message about FINAL_CHAR argument. Make sure
8898 FINAL_CHAR is a character, and use %c when it is passed as
8899 argument to `error'.
8901 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8903 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8905 * w32.c: Include <time.h>.
8906 (sys_localtime): New function.
8908 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8910 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8912 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8914 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8916 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8919 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8921 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8922 gl_state.e_property when gl_state.object is Qt.
8924 * insdel.c (make_gap_larger): Remove limitation of buffer size
8927 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8929 * xdisp.c (lookup_glyphless_char_display)
8930 (produce_glyphless_glyph): Handle cons cell entry in
8931 glyphless-char-display.
8932 (Vglyphless_char_display): Document it.
8934 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8935 glyphless-char-display.
8937 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8939 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8941 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8943 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8944 definition for no-X builds.
8946 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8948 Static checks with GCC 4.6.0 and non-default toolkits.
8950 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8952 * process.c (keyboard_bit_set): Define only if SIGIO.
8953 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8954 (send_process): Repair possible setjmp clobbering.
8956 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8958 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8960 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8962 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8963 Define only if needed.
8965 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8966 by pacifying GCC about it. Maybe it's time to retire it?
8967 * xfaces.c (USG, __TIMEVAL__): Likewise.
8969 * dispextern.h (struct redisplay_interface): Rename param
8971 * termhooks.h (struct terminal): Likewise.
8972 * xterm.c (xembed_send_message): Likewise.
8974 * insdel.c (make_gap_smaller): Define only if
8975 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8977 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8980 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8981 so that we aren't warned about unused symbols.
8983 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8985 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8987 * xfns.c (x_real_positions): Mark locals as initialized.
8989 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8991 * xterm.c: Fix problems found by static analysis with other toolkits.
8992 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8993 (x_dispatch_event): Declare static if USE_GTK, and
8994 define if USE_GTK || USE_X_TOOLKIT.
8995 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8996 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8997 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8998 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9000 * xmenu.c (menu_help_callback): Pointer type fixes.
9001 Use const pointers when pointing at readonly data. Avoid pointer
9003 (FALSE): Remove unused macro.
9004 (update_frame_menubar): Remove unused decl.
9006 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9008 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9009 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9010 (single_menu_item): Rename local to avoid shadowing.
9012 * keyboard.c (make_lispy_event): Remove unused local var.
9014 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9015 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9017 * bitmaps: Change bitmaps from unsigned char back to the X11
9018 compatible char. Avoid the old compiler warnings about
9019 out-of-range initializers by using, for example, '\xab' rather
9022 * xgselect.c (xgselect_initialize): Check vs interface
9023 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9025 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9027 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9028 to read-only memory.
9030 * fns.c (vector): Remove; this old hack is no longer needed.
9032 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9034 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9036 * xrdb.c (x_load_resources): Omit unused local.
9038 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9039 (x_window): Rename locals to avoid shadowing.
9040 (USG): Use the kludged USG macro, to pacify gcc.
9042 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9043 (x_term_init): Remove local to avoid shadowing.
9045 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9047 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9048 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9050 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9052 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9054 Fix regex.c, syntax.c and friends for buffers > 2GB.
9055 * syntax.h (struct gl_state_s): Declare character position members
9058 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9060 * textprop.c (verify_interval_modification, interval_of):
9061 Declare arguments EMACS_INT.
9063 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9066 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9068 * indent.c (Fvertical_motion): Local variable it_start is now
9071 * regex.c (re_match, re_match_2, re_match_2_internal)
9072 (bcmp_translate, regcomp, regexec, print_double_string)
9073 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9074 (re_compile_pattern, re_exec): Declare arguments and local
9075 variables `size_t' and `ssize_t' and return values `regoff_t', as
9077 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9078 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9079 <compile_stack_type>: `size' and `avail' are now `size_t'.
9081 * regex.h <regoff_t>: Use ssize_t, not int.
9082 (re_search, re_search_2, re_match, re_match_2): Arguments that
9083 specify buffer/string position and length are now ssize_t and
9084 size_t. Return type is regoff_t.
9086 2011-04-16 Ben Key <bkey76@gmail.com>
9088 * nsfont.m: Fixed bugs in ns_get_family and
9089 ns_descriptor_to_entity that were caused by using free to
9090 deallocate memory blocks that were allocated by xmalloc (via
9091 xstrdup). This caused Emacs to crash when compiled with
9092 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9093 --enable-checking=xmallocoverrun). xfree is now used to
9094 deallocate these memory blocks.
9096 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9098 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9100 emacs_write: Accept and return EMACS_INT for sizes.
9101 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9103 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9104 Accept and return EMACS_INT.
9105 (emacs_gnutls_write): Return the number of bytes written on
9107 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9108 (emacs_read, emacs_write): Remove check for negative size, as the
9109 Emacs source code has been audited now.
9110 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9111 (emacs_read, emacs_write): Use it.
9112 * process.c (send_process): Adjust to the new signatures of
9113 emacs_write and emacs_gnutls_write. Do not attempt to store
9114 a byte offset into an 'int'; it might overflow.
9115 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9117 * sound.c: Don't assume sizes fit in 'int'.
9118 (struct sound_device.period_size, alsa_period_size):
9119 Return EMACS_INT, not int.
9120 (struct sound_device.write, vox_write, alsa_write):
9121 Accept EMACS_INT, not int.
9122 (wav_play, au_play): Use EMACS_INT to store sizes and to
9123 record read return values.
9125 2011-04-15 Ben Key <bkey76@gmail.com>
9127 * keyboard.c (Qundefined): Don't declare static since it is used
9129 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9130 static since they are used in nsfont.m.
9132 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9134 * process.c (Qprocessp): Don't declare static.
9135 * lisp.h (Qprocessp): Declare again.
9137 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9139 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9141 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9143 Improve C-level modularity by making more things 'static'.
9145 Don't publish debugger-only interfaces to other modules.
9146 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9147 (verify_bytepos, count_markers): Move decls to the only modules
9149 * region-cache.h (pp_cache): Likewise.
9150 * window.h (check_all_windows): Likewise.
9151 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9153 * sysdep.c (croak): Now static, if
9154 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9155 * syssignal.h (croak): Declare only if not static.
9157 * alloc.c (refill_memory_reserve): Now static if
9158 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9159 * lisp.h (refill_memory_reserve): Declare only if not static.
9161 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9162 Define only if USE_LUCID.
9164 * xrdb.c (x_customization_string, x_rm_string): Now static.
9166 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9167 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9169 * xdisp.c (draw_row_with_mouse_face): Now static.
9170 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9172 * window.h (check_all_windows): Mark externally visible.
9174 * window.c (window_deletion_count): Now static.
9176 * undo.c: Make symbols static if they're not exported.
9177 (last_undo_buffer, last_boundary_position, pending_boundary):
9180 * textprop.c (interval_insert_behind_hooks): Now static.
9181 (interval_insert_in_front_hooks): Likewise.
9183 * term.c: Make symbols static if they're not exported.
9184 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9185 (max_frame_lines, tty_set_terminal_modes):
9186 (tty_reset_terminal_modes, tty_turn_off_highlight):
9187 (get_tty_terminal): Now static.
9188 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9189 * termhooks.h (term_mouse_moveto): Do not declare if
9191 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9192 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9194 * sysdep.c: Make symbols static if they're not exported.
9195 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9197 (sigprocmask_set, full_mask): Remove; unused.
9198 (wait_debugging): Mark as visible.
9199 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9200 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9202 * syntax.c (syntax_temp): Define only if !__GNUC__.
9204 * sound.c (current_sound_device, current_sound): Now static.
9206 * search.c (searchbufs, searchbuf_head): Now static.
9208 * scroll.c (scroll_cost): Remove; unused.
9209 * dispextern.h (scroll_cost): Remove decl.
9211 * region-cache.h (pp_cache): Mark as externally visible.
9213 * process.c: Make symbols static if they're not exported.
9214 (process_tick, update_tick, create_process, chan_process):
9215 (Vprocess_alist, proc_buffered_char, datagram_access):
9216 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9217 (deactivate_process): Mark defn as static, as well as decl.
9218 * lisp.h (create_process): Remove decl.
9219 * process.h (chan_process, Vprocess_alist): Remove decls.
9221 * print.c: Make symbols static if they're not exported.
9222 (print_depth, new_backquote_output, being_printed, print_buffer):
9223 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9224 (print_interval, print_number_index, initial_stderr_stream):
9226 * lisp.h (Fprinc): Remove decl.
9227 (debug_output_compilation_hack): Mark as externally visible.
9229 * sysdep.c (croak): Move decl from here to syssignal.h.
9230 * syssignal.h (croak): Put it here, so the API can be checked when
9231 'croak' is called from dissociate_if_controlling_tty.
9233 * minibuf.c: Make symbols static if they're not exported.
9234 (minibuf_save_list, choose_minibuf_frame): Now static.
9235 * lisp.h (choose_minibuf_frame): Remove decl.
9237 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9239 * lread.c: Make symbols static if they're not exported.
9240 (read_objects, initial_obarray, oblookup_last_bucket_number):
9242 (make_symbol): Remove; unused.
9243 * lisp.h (initial_obarray, make_symbol): Remove decls.
9245 * keyboard.c: Make symbols static if they're not exported.
9246 (single_kboard, recent_keys_index, total_keys, recent_keys):
9247 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9248 (this_single_command_key_start, echoing, last_auto_save):
9249 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9250 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9251 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9252 (Vlispy_mouse_stem, double_click_count):
9254 (force_auto_save_soon): Define only if SIGDANGER.
9255 (ignore_mouse_drag_p): Now static if
9256 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9257 (print_help): Remove; unused.
9258 (stop_character, last_timer_event): Mark as externally visible.
9259 * keyboard.h (ignore_mouse_drag_p): Declare only if
9260 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9261 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9262 * lisp.h (echoing): Remove decl.
9263 (force_auto_save_soon): Declare only if SIGDANGER.
9264 * xdisp.c (redisplay_window): Simplify code, to make it more
9265 obvious that ignore_mouse_drag_p is not accessed if !defined
9266 USE_GTK && !defined HAVE_NS.
9268 * intervals.c: Make symbols static if they're not exported.
9269 (merge_properties_sticky, merge_interval_right, delete_interval):
9271 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9273 * insdel.c: Make symbols static if they're not exported.
9274 However, leave prepare_to_modify_buffer alone. It's never
9275 called from outside this function, but that appears to be a bug.
9276 (combine_after_change_list, combine_after_change_buffer):
9277 (adjust_after_replace, signal_before_change): Now static.
9278 (adjust_after_replace_noundo): Remove; unused.
9279 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9280 (signal_before_change): Remove decls.
9282 * indent.c (val_compute_motion, val_vmotion): Now static.
9284 * image.c: Make symbols static if they're not exported.
9285 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9287 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9288 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9290 * fringe.c (standard_bitmaps): Now static.
9291 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9293 * frame.c: Make symbols static if they're not exported.
9294 (x_report_frame_params, make_terminal_frame): Now static.
9295 (get_frame_param): Now static, unless HAVE_NS.
9296 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9297 (x_get_resource_string): Remove; not used.
9298 * frame.h (make_terminal_frame, x_report_frame_params):
9299 (x_get_resource_string); Remove decls.
9300 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9301 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9303 * font.c, fontset.c: Make symbols static if they're not exported.
9304 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9305 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9306 * font.c (font_close_object): Now static.
9307 * font.h (font_close_object): Remove.
9308 * fontset.c (FONTSET_OBJLIST): Remove.
9309 (free_realized_fontset) #if-0 the body, which does nothing.
9310 (face_suitable_for_char_p): #if-0, as it's never called.
9311 * fontset.h (face_suitable_for_char_p): Remove decl.
9312 * xfaces.c (face_at_string_position):
9313 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9314 since 0 is always ASCII.
9316 * fns.c (weak_hash_tables): Now static.
9318 * fileio.c: Make symbols static if they're not exported.
9319 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9320 (Vwrite_region_annotation_buffers): Now static.
9322 * eval.c: Make symbols static if they're not exported.
9323 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9324 * lisp.h (backtrace_list): Remove decl.
9326 * emacs.c: Make symbols static if they're not exported.
9327 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9328 (fatal_error_code, fatal_error_signal_hook, standard_args):
9330 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9331 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9332 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9333 * lisp.h (fatal_error_signal_hook): Remove decl.
9334 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9336 * editfns.c: Move a (normally-unused) function to its only use.
9337 * editfns.c, lisp.h (get_operating_system_release): Remove.
9338 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9339 worth the hassle of breaking this out.
9341 * xterm.c: Make symbols static if they're not exported.
9342 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9343 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9344 (x_destroy_window, x_delete_display):
9346 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9347 (x_mouse_leave): Remove; unused.
9348 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9349 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9350 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9352 (x_mouse_leave): Declare only if WINDOWSNT.
9353 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9354 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9357 * ftxfont.c: Make symbols static if they're not exported.
9358 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9360 * font.h (ftxfont_driver): Likewise.
9362 * xfns.c: Make symbols static if they're not exported.
9363 (x_last_font_name, x_display_info_for_name):
9364 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9365 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9366 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9367 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9368 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9369 (last_show_tip_args): Now static.
9370 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9371 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9372 (x_screen_planes): Remove; unused.
9373 * dispextern.h (x_screen_planes): Remove decl.
9375 * dispnew.c: Make symbols static if they're not exported.
9376 * dispextern.h (redraw_garbaged_frames, scrolling):
9377 (increment_row_positions): Remove.
9378 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9379 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9381 (redraw_garbaged_frames): Remove; unused.
9383 * xfaces.c: Make symbols static if they're not exported.
9384 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9386 * xterm.h (defined_color): Remove decls.
9387 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9388 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9389 (menu_face_changed_default, defined_color, free_realized_face):
9390 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9391 (ascii_face_of_lisp_face): Remove; unused.
9393 * xdisp.c: Make symbols static if they're not exported.
9394 * dispextern.h (scratch_glyph_row, window_box_edges):
9395 (glyph_to_pixel_coords, set_cursor_from_row):
9396 (get_next_display_element, set_iterator_to_next):
9397 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9398 (show_mouse_face): Remove decls
9399 * frame.h (message_buf_print): Likewise.
9400 * lisp.h (pop_message, set_message, check_point_in_composition):
9402 * xterm.h (set_vertical_scroll_bar): Likewise.
9403 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9404 (message_buf_print, scratch_glyph_row, displayed_buffer):
9405 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9406 (get_next_display_element, show_mouse_face, window_box_edges):
9407 (frame_to_window_pixel_xy, check_point_in_composition):
9408 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9409 (glyph_to_pixel_coords): Remove; unused.
9411 * dired.c (file_name_completion): Now static.
9413 * dbusbind.c (xd_in_read_queued_messages): Now static.
9415 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9416 * data.c (circular_list_error): Remove.
9418 * commands.h (last_point_position, last_point_position_buffer):
9419 (last_point_position_window): Remove decls.
9420 * keyboard.c: Make these variables static.
9422 * coding.h (coding, code_convert_region, encode_coding_gap):
9424 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9425 (iso_code_class, detect_coding, code_convert_region): Now static.
9426 (encode_coding_gap): Remove; unused.
9428 * chartab.c (chartab_chars, chartab_bits): Now static.
9430 * charset.h (charset_iso_8859_1): Remove decl.
9431 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9434 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9435 * ccl.c (Vccl_program_table): Now static.
9436 (check_ccl_update): Remove; unused.
9438 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9439 * category.h: ... from here.
9440 * category.c (check_category_table, set_category_set): Now static.
9442 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9443 * lisp.h: Remove these decls.
9445 * buffer.c (buffer_count): Remove unused var.
9447 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9448 so that it's not optimized away.
9449 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9450 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9451 exported only to the debugger.
9453 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9454 * atimer.h (run_all_atimers): Remove; not exported.
9456 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9457 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9458 was inaccessible from Lisp.
9459 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9460 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9462 alloc.c: Import and export fewer symbols, and remove unused items.
9463 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9465 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9466 it's not optimized away by whole-program optimization.
9467 (message_enable_multibyte, free_misc): Remove.
9468 (catchlist, handlerlist, mark_backtrace):
9469 Declare only if BYTE_MARK_STACK.
9470 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9471 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9472 (message_enable_multibyte): Remove decl.
9473 (free_misc, interval_free_list, float_block, float_block_index):
9474 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9475 (cons_free_list, last_marked_index):
9477 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9478 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9479 (mark_backtrace): Define only if BYTE_MARK_STACK.
9480 * xdisp.c (message_enable_multibyte): Now static.
9482 Declare Lisp_Object Q* variables to be 'static' if not exported.
9483 This makes it easier for human readers (and static analyzers)
9484 to see whether these variables are used from other modules.
9485 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9486 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9487 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9488 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9489 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9490 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9491 * xmenu.c, xselect.c:
9492 Declare Q* vars static if they are not used in other modules.
9493 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9494 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9495 Remove decls of unexported vars.
9496 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9498 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9500 Make Emacs functions such as Fatom 'static' by default.
9501 This makes it easier for human readers (and static analyzers)
9502 to see whether these functions can be called from other modules.
9503 DEFUN now defines a static function. To make the function external
9504 so that it can be used in other C modules, use the new macro DEFUE.
9505 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9506 (Finit_image_library):
9507 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9508 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9509 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9510 Remove decls, since these functions are now static.
9511 (Funintern, Fget_internal_run_time): New decls, since these functions
9512 were already external.
9514 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9515 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9516 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9517 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9518 * keyboard.c, keymap.c, lread.c:
9519 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9520 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9521 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9522 Mark functions with DEFUE instead of DEFUN,
9523 if they are used in other modules.
9524 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9525 decls for now-static functions.
9526 * buffer.h (Fdelete_overlay): Remove decl.
9527 * callproc.c (Fgetenv_internal): Mark as internal.
9528 * composite.c (Fremove_list_of_text_properties): Remove decl.
9529 (Fcomposition_get_gstring): New forward static decl.
9530 * composite.h (Fcomposite_get_gstring): Remove decl.
9531 * dired.c (Ffile_attributes): New forward static decl.
9532 * doc.c (Fdocumntation_property): New forward static decl.
9533 * eval.c (Ffetch_bytecode): New forward static decl.
9534 (Funintern): Remove extern decl; now in .h file where it belongs.
9535 * fileio.c (Fmake_symbolic_link): New forward static decl.
9536 * image.c (Finit_image_library): New forward static decl.
9537 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9538 * intervals.h (Fprevious_property_change):
9539 (Fremove_list_of_text_properties): Remove decls.
9540 * keyboard.c (Fthis_command_keys): Remove decl.
9541 (Fcommand_execute): New forward static decl.
9542 * keymap.c (Flookup_key): New forward static decl.
9543 (Fcopy_keymap): Now static.
9544 * keymap.h (Flookup_key): Remove decl.
9545 * process.c (Fget_process): New forward static decl.
9546 (Fprocess_datagram_address): Mark as internal.
9547 * syntax.c (Fsyntax_table_p): New forward static decl.
9548 (skip_chars): Remove duplicate decl.
9549 * textprop.c (Fprevious_property_change): New forward static decl.
9550 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9552 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9553 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9555 * editfns.c (Fformat): Remove unreachable code.
9557 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9559 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9562 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9564 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9565 when at ZV. (Bug#8487)
9567 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9569 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9571 * keyboard.c (parse_tool_bar_item): Likewise.
9572 * sound.c (sound_cleanup, alsa_close): Likewise.
9573 * termcap.c (tgetent): Likewise.
9574 * xfns.c (x_default_font_parameter): Likewise.
9575 * xsettings.c (read_and_apply_settings): Likewise.
9577 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9578 (overrun_check_free): Protoize.
9580 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9582 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9583 since callers should never pass a negative size.
9584 Change the signature to match that of plain 'read' and 'write'; see
9585 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9586 * lisp.h: Update prototypes of emacs_write and emacs_read.
9588 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9590 * xdisp.c (redisplay_window): Don't try to determine the character
9591 position of the scroll margin if the window start point w->startp
9592 is outside the buffer's accessible region. (Bug#8468)
9594 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9596 Fix write-region and its subroutines for buffers > 2GB.
9597 * fileio.c (a_write, e_write): Modify declaration of arguments and
9598 local variables to support buffers larger than 2GB.
9599 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9601 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9602 argument, local variables, and return value.
9604 * lisp.h: Update prototypes of emacs_write and emacs_read.
9606 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9608 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9610 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9612 Fix more problems found by GCC 4.6.0's static checks.
9614 * xdisp.c (vmessage): Use a better test for character truncation.
9616 * charset.c (load_charset_map): <, not <=, for optimization,
9617 and to avoid potential problems with integer overflow.
9618 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9619 * casetab.c (set_identity, shuffle): Likewise.
9620 * editfns.c (Fformat): Likewise.
9621 * syntax.c (skip_chars): Likewise.
9623 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9624 This also lets GCC 4.6.0 generate slightly better loop code.
9626 * callint.c (Fcall_interactively): <, not <=, for optimization.
9627 (Fcall_interactively): Count the number of arguments produced,
9628 not the number of arguments given. This is simpler and lets GCC
9629 4.6.0 generate slightly better code.
9631 * ftfont.c: Distingish more carefully between FcChar8 and char.
9632 The previous code passed unsigned char * to a functions like
9633 strlen and xstrcasecmp that expect char *, which does not
9634 conform to the C standard.
9635 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9636 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9637 char * when the C standard requires it.
9639 * keyboard.c (read_char): Remove unused var.
9641 * eval.c: Port to Windows vsnprintf (Bug#8435).
9643 (SIZE_MAX): Define if the headers do not.
9644 (verror): Do not give up if vsnprintf returns a negative count.
9645 Instead, grow the buffer. This ports to Windows vsnprintf, which
9646 does not conform to C99. Problem reported by Eli Zaretskii.
9647 Also, simplify the allocation scheme, by avoiding the need for
9648 calling realloc, and removing the ALLOCATED variable.
9650 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9652 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9653 But keep the doprint source code for now, as we might revamp it
9654 and use it again (Bug#8435).
9655 * lisp.h (doprnt): Remove.
9656 * Makefile.in (base_obj): Remove doprnt.o.
9657 * deps.mk (doprnt.o): Remove.
9659 error: Print 32- and 64-bit integers portably (Bug#8435).
9660 Without this change, on typical 64-bit hosts error ("...%d...", N)
9661 was used to print both 32- and 64-bit integers N, which relied on
9663 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9664 * lisp.h (error, verror): Mark as printf-like functions.
9665 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9666 Report overflow in size calculations when allocating printf buffer.
9667 Do not truncate output string at its first null byte.
9668 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9669 Truncate the output at a character boundary, since vsnprintf does not
9671 * charset.c (check_iso_charset_parameter): Convert internal
9672 character to string before calling 'error', since %c now has the
9674 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9675 overflow when computing char to be passed to 'error'. Do not
9676 pass Lisp_Object to 'error'; pass the integer instead.
9677 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9678 formatted with plain %d.
9680 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9682 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9684 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9686 * xterm.c (x_catch_errors): Remove duplicate declaration.
9688 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9690 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9692 2011-04-10 Jim Meyering <meyering@redhat.com>
9694 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9695 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9696 return ssize_t not "int", and use size_t as the buffer length.
9697 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9698 * gnutls.h: Update declarations.
9699 * process.c (read_process_output): Use ssize_t, to match.
9700 (send_process): Likewise.
9702 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9704 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9706 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9708 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9709 Use unsigned char, to match FcChar8 type definition.
9711 * xterm.c (handle_one_xevent):
9712 * xmenu.c (create_and_show_popup_menu):
9713 * xselect.c (x_decline_selection_request)
9714 (x_reply_selection_request): Avoid type-punned deref of X events.
9716 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9718 Fix some uses of `int' instead of EMACS_INT.
9719 * search.c (string_match_1, fast_string_match)
9720 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9721 (scan_buffer, find_next_newline_no_quit)
9722 (find_before_next_newline, search_command, Freplace_match)
9723 (Fmatch_data): Make some `int' variables be EMACS_INT.
9725 * xdisp.c (display_count_lines): 3rd argument and return value now
9726 EMACS_INT. All callers changed.
9727 (pint2hrstr): Last argument is now EMACS_INT.
9729 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9730 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9731 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9732 (decode_coding_utf_16, decode_coding_emacs_mule)
9733 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9734 (decode_coding_ccl, decode_coding_charset)
9735 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9736 (decode_coding_iso_2022, decode_coding_emacs_mule)
9737 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9738 <char_offset, last_offset>: Declare EMACS_INT.
9739 (encode_coding_utf_8, encode_coding_utf_16)
9740 (encode_coding_emacs_mule, encode_invocation_designation)
9741 (encode_designation_at_bol, encode_coding_iso_2022)
9742 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9743 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9745 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9746 (encode_invocation_designation): Last argument P_NCHARS is now
9748 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9749 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9751 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9754 * ccl.c (Fccl_execute_on_string): Declare some variables
9757 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9759 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9761 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9763 * process.c (Fformat_network_address): Doc fix.
9765 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9767 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9769 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9771 * keyboard.c (read_char): Call Lisp function help-form-show,
9772 instead of using internal_with_output_to_temp_buffer.
9773 (Qhelp_form_show): New var.
9774 (syms_of_keyboard): Use DEFSYM macro.
9776 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9778 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9780 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9782 * process.c (Flist_processes): Remove to Lisp.
9783 (list_processes_1): Delete.
9785 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9787 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9789 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9791 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9793 Fix more problems found by GCC 4.6.0's static checks.
9795 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9797 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9799 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9801 * xdisp.c (vmessage): Mark as a printf-like function.
9803 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9805 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9807 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9808 printf-like functions.
9809 (tiff_load): Add casts to remove these marks before passing them
9810 to system-supplied API.
9812 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9814 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9815 This avoids several warnings with gcc -Wstrict-overflow.
9816 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9817 directly, rather than having caller test rule sign. This avoids
9818 some unnecessary tests.
9819 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9820 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9821 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9823 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9824 (xfont_open): Avoid unnecessary tests.
9826 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9828 * composite.h, composite.c (composition_gstring_put_cache):
9829 Use EMACS_INT, not int, for length.
9831 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9832 breaking out part of COMPOSITION_DECODE_RULE.
9833 (COMPOSITION_DECODE_RULE): Use it.
9834 * composite.c (get_composition_id): Remove unused local vars,
9835 by using the new macro.
9837 * textprop.c (set_text_properties_1): Change while to do-while,
9838 since the condition is always true at first.
9840 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9841 (interval_deletion_adjustment): Return unsigned value.
9844 * process.c (list_processes_1, create_pty, read_process_output):
9845 (exec_sentinel): Remove vars that were set but not used.
9846 (create_pty): Remove unnecessary "volatile"s.
9847 (Fnetwork_interface_info): Avoid possibility of int overflow.
9848 (read_process_output): Do adaptive read buffering even if carryover.
9849 (read_process_output): Simplify nbytes computation if buffered.
9851 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9853 * syntax.c (scan_words): Remove var that was set but not used.
9854 (update_syntax_table): Use unsigned instead of int.
9856 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9857 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9858 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9860 * print.c (print_error_message): Avoid int overflow.
9862 * font.c (font_list_entities): Redo for clarity,
9863 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9865 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9866 (font_score): Avoid potential overflow in diff calculation.
9868 * fns.c (substring_both): Remove var that is set but not used.
9869 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9871 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9873 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9874 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9875 can always succeed if overflow has undefined behavior.
9877 * search.c (boyer_moore, wordify): Remove vars set but not used.
9878 (wordify): Omit three unnecessary tests.
9880 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9881 All callers changed. This avoids the need for an unused var.
9883 * casefiddle.c (casify_region): Remove var that is set but not used.
9885 * dired.c (file_name_completion): Remove var that is set but not used.
9887 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9889 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9890 (Finsert_file_contents): Remove unnecessary code checking fd.
9892 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9893 Check for integer overflow on size calculations.
9895 * buffer.c (Fprevious_overlay_change): Remove var that is set
9898 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9899 Remove vars that are set but not used.
9900 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9901 (timer_check_2): Mark vars as initialized.
9903 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9905 * image.c (lookup_image): Remove var that is set but not used.
9906 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9908 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9909 that are set but not used.
9911 * xfns.c (make_invisible_cursor): Don't return garbage
9912 if XCreateBitmapFromData fails (Bug#8410).
9914 * xselect.c (x_get_local_selection, x_handle_property_notify):
9915 Remove vars that are set but not used.
9917 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9918 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9920 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9921 Remove var that is set but not used.
9922 (scroll_bar_windows_size): Now size_t, not int.
9923 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9926 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9927 (map_tty_color) [!defined MSDOS]: Likewise.
9929 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9931 * coding.c: Remove vars that are set but not used.
9932 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9933 All callers changed.
9934 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9935 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9936 (decode_coding_charset): Remove vars that are set but not used.
9938 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9939 that is set but not used.
9941 * print.c (print_object): Remove var that is set but not used.
9943 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9944 The gnulib version avoids calling malloc in the usual case,
9945 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9946 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9947 * filelock.c (current_lock_owner): Likewise.
9948 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9949 * sysdep.c: Include allocator.h, careadlinkat.h.
9950 (emacs_no_realloc_allocator): New static constant.
9951 (emacs_readlink): New function.
9952 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9953 ../lib/careadlinkat.h.
9955 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9957 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9958 first non-nil return value).
9960 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9962 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9963 if not defined (Bug#8403).
9965 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9967 * xdisp.c (display_count_lines): Remove parameter `start',
9968 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9969 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9970 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9971 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9972 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9973 and thereabouts. All callers changed.
9974 (get_per_char_metric): Remove parameter `f', unused since
9975 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9977 2011-04-02 Jim Meyering <meyering@redhat.com>
9979 do not dereference NULL upon failed strdup
9980 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9981 (ns_get_family): Likewise.
9983 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9985 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9987 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9989 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9992 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9994 Add lexical binding.
9996 * window.c (Ftemp_output_buffer_show): New fun.
9997 (Fsave_window_excursion):
9998 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10000 * lread.c (lisp_file_lexically_bound_p): New function.
10001 (Fload): Bind Qlexical_binding.
10002 (readevalloop): Remove `evalfun' arg.
10003 Bind Qinternal_interpreter_environment.
10004 (Feval_buffer): Bind Qlexical_binding.
10005 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10007 (syms_of_lread): Declare `lexical-binding'.
10009 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10011 * keyboard.c (eval_dyn): New fun.
10012 (menu_item_eval_property): Use it.
10014 * image.c (parse_image_spec): Use Ffunctionp.
10016 * fns.c (concat, mapcar1): Accept byte-code-functions.
10018 * eval.c (Fsetq): Handle lexical vars.
10019 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10020 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10021 (FletX, Flet): Obey lexical binding.
10022 (Fcommandp): Handle closures.
10023 (Feval): New `lexical' arg.
10024 (eval_sub): New function extracted from Feval. Use it almost
10025 everywhere where Feval was used. Look up vars in lexical env.
10027 (Ffunctionp): Move from subr.el.
10028 (Ffuncall): Handle closures.
10029 (apply_lambda): Remove `eval_flags'.
10030 (funcall_lambda): Handle closures and new byte-code-functions.
10031 (Fspecial_variable_p): New function.
10032 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10033 but without exporting it to Lisp.
10035 * doc.c (Fdocumentation, store_function_docstring):
10036 * data.c (Finteractive_form): Handle closures.
10038 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10041 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10043 (exec_byte_code): New function extracted from Fbyte_code to handle new
10044 calling convention for byte-code-functions. Add new byte-codes.
10046 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10048 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10050 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10052 * xdisp.c (redisplay_internal): Fix prototype.
10054 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10056 * xdisp.c (SCROLL_LIMIT): New macro.
10057 (try_scrolling): Use it when setting scroll_limit.
10058 Limit scrolling to 100 screen lines.
10059 (redisplay_window): Even when falling back on "recentering",
10060 position point in the window according to scroll-conservatively,
10061 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10063 (try_scrolling): When point is above the window, allow searching
10064 as far as scroll_max, or one screenful, to compute vertical
10065 distance from PT to the scroll margin position. This prevents
10066 try_scrolling from unnecessarily failing when
10067 scroll-conservatively is set to a value slightly larger than the
10068 window height. Clean up the case of PT below the margin at bottom
10069 of window: scroll_max can no longer be INT_MAX. When aggressive
10070 scrolling is in use, don't let point enter the opposite scroll
10071 margin as result of the scroll.
10072 (syms_of_xdisp) <scroll-conservatively>: Document the
10073 threshold of 100 lines for never-recentering scrolling.
10075 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10077 * dispextern.h (move_it_by_lines):
10078 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10079 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10080 (message_log_check_duplicate): Remove parameters `prev_bol' and
10081 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10082 (redisplay_internal): Remove parameter `preserve_echo_area',
10083 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10085 * indent.c (Fvertical_motion):
10086 * window.c (window_scroll_pixel_based, Frecenter):
10087 Don't pass `need_y_p' to `move_it_by_lines'.
10089 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10091 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10092 steal a few bits to be more compact.
10093 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10094 Remove unneeded casts.
10096 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10098 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10100 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10101 binding" message (bug#7967).
10103 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10105 Fix more problems found by GCC 4.6.0's static checks.
10107 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10108 Remove unused local var.
10110 * editfns.c (Fmessage_box): Remove unused local var.
10112 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10113 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10114 Omit unused local vars.
10115 * window.c (shrink_windows): Omit unused local var.
10116 * menu.c (digest_single_submenu): Omit unused local var.
10117 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10118 Omit unused local var.
10120 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10121 Don't assume string length fits in int.
10122 (keyremap_step, read_key_sequence): Use size_t for sizes.
10123 (read_key_sequence): Don't check last_real_key_start redundantly.
10125 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10126 instead of alloca (Bug#8344).
10128 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10129 (Fbacktrace_frame): Don't assume nframes fits in int.
10131 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10133 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10136 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10138 * cm.c (calccost): Turn while-do into do-while, for clarity.
10140 * keyboard.c (syms_of_keyboard): Use the same style as later
10141 in this function when indexing through an array. This also
10142 works around GCC bug 48267.
10144 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10146 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10148 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10149 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10151 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10152 This avoids undefined behavior on integer overflow, and is a bit
10153 more convenient anyway since it is compared to a size_t variable.
10155 Variadic C functions now count arguments with size_t, not int.
10156 This avoids an unnecessary limitation on 64-bit machines, which
10157 caused (substring ...) to crash on large vectors (Bug#8344).
10158 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10159 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10160 All variadic functions and their callers changed accordingly.
10161 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10162 * data.c (arith_driver, float_arith_driver): Likewise.
10163 * editfns.c (general_insert_function): Likewise.
10164 * eval.c (struct backtrace.nargs, interactive_p)
10165 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10166 (funcall_lambda, mark_backtrace): Likewise.
10167 * fns.c (concat): Likewise.
10168 * frame.c (x_set_frame_parameters): Likewise.
10169 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10170 0 if not found, not -1. All callers changed.
10172 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10173 (stack_copy_size): Now size_t, not int.
10174 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10176 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10178 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10179 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10180 All callers changed.
10182 * lisp.h (multibyte_char_to_unibyte):
10183 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10184 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10185 * character.h (CHAR_TO_BYTE8):
10186 * cmds.c (internal_self_insert):
10187 * editfns.c (general_insert_function):
10188 * keymap.c (push_key_description):
10189 * search.c (Freplace_match):
10190 * xdisp.c (message_dolog, set_message_1): All callers changed.
10192 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10194 * keyboard.c (safe_run_hook_funcall): New function.
10195 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10196 don't set the hook to nil, but remove the offending function instead.
10197 (Qcommand_hook_internal): Remove, unused.
10198 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10199 Vcommand_hook_internal.
10201 * eval.c (enum run_hooks_condition): Remove.
10202 (funcall_nil, funcall_not): New functions.
10203 (run_hook_with_args): Call each function through a `funcall' argument.
10204 Remove `cond' argument, now redundant.
10205 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10206 (Frun_hook_with_args_until_failure): Adjust accordingly.
10207 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10209 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10211 * dispextern.h (string_buffer_position): Remove declaration.
10213 * print.c (strout): Remove parameter `multibyte', unused since
10214 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10216 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10217 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10218 All callers changed.
10220 * w32.c (_wsa_errlist): Use braces for struct initializers.
10222 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10223 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10224 All callers changed.
10225 (string_buffer_position): Likewise. Also, make static (it's never
10226 used outside xdisp.c).
10227 (cursor_row_p): Remove parameter `w', unused since
10228 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10229 (decode_mode_spec): Remove parameter `precision', introduced during
10230 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10231 All callers changed.
10233 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10235 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10237 2011-03-27 Anders Lindgren <andlind@gmail.com>
10239 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10240 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10241 (ns_update_auto_hide_menu_bar): New functions.
10242 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10243 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10244 ns_constrain_all_frames.
10245 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10246 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10248 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10250 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10252 2011-03-27 Glenn Morris <rgm@gnu.org>
10254 * syssignal.h: Replace RETSIGTYPE with void.
10255 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10256 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10257 Replace SIGTYPE with void everywhere.
10258 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10259 * s/template.h (SIGTYPE): Remove commented out definition.
10261 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10263 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10264 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10266 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10268 * w32.c (read_unc_volume): Use parameter `henum', instead of
10269 global variable `wget_enum_handle'.
10271 * keymap.c (describe_vector): Remove parameters `indices' and
10272 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10273 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10275 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10277 * keyboard.c (timer_check): Remove parameter `do_it_now',
10278 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10279 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10280 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10282 * keyboard.c (read_char):
10283 * w32menu.c (w32_menu_display_help):
10284 * xmenu.c (show_help_event, menu_help_callback):
10285 Adjust calls to `show_help_echo'.
10287 * gtkutil.c (xg_maybe_add_timer):
10288 * keyboard.c (readable_events):
10289 * process.c (wait_reading_process_output):
10290 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10292 * insdel.c (adjust_markers_gap_motion):
10293 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10294 (gap_left, gap_right): Don't call it.
10296 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10298 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10299 incurred during fontification.
10301 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10303 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10304 (DEFVAR_PER_BUFFER): Don't pass it.
10306 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10307 (scrolling_window): Don't pass it.
10309 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10311 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10313 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10315 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10316 of variables specific to SELinux and computation of `encoded_absname'.
10318 * image.c (XPutPixel): Remove unused variable `height'.
10320 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10322 * unexw32.c (get_section_info): Remove unused variable `section'.
10324 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10325 (system_process_attributes): Remove unused variable `sess'.
10326 (sys_read): Remove unused variable `err'.
10328 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10329 (w32_wnd_proc): Remove unused variable `isdead'.
10330 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10331 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10332 (x_create_tip_frame): Remove unused variable `tem'.
10334 * w32inevt.c (w32_console_read_socket):
10335 Remove unused variable `no_events'.
10337 * w32term.c (x_draw_composite_glyph_string_foreground):
10338 Remove unused variable `width'.
10340 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10342 * w32term.c (x_set_glyph_string_clipping):
10343 Don't pass uninitialized region to CombineRgn.
10345 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10347 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10348 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10349 (Fx_close_connection): Remove unused variable `i'.
10351 * w32font.c (w32font_draw): Return number of glyphs.
10352 (w32font_open_internal): Remove unused variable `i'.
10353 (w32font_driver): Add missing initializer.
10355 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10356 (fill_in_menu): Remove unused variable `items_added'.
10358 * w32term.c (last_mouse_press_frame): Remove static global variable.
10359 (w32_clip_to_row): Remove unused variable `f'.
10360 (x_delete_terminal): Remove unused variable `i'.
10362 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10363 (NOTHING): Remove unused static global variable.
10364 (uniscribe_check_otf): Remove unused variable `table'.
10365 (uniscribe_font_driver): Add missing initializers.
10367 2011-03-23 Julien Danjou <julien@danjou.info>
10369 * term.c (Fsuspend_tty, Fresume_tty):
10370 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10371 * window.c (temp_output_buffer_show):
10372 * insdel.c (signal_before_change):
10373 * frame.c (Fhandle_switch_frame):
10374 * fileio.c (Fdo_auto_save):
10375 * emacs.c (Fkill_emacs):
10376 * editfns.c (save_excursion_restore):
10377 * cmds.c (internal_self_insert):
10378 * callint.c (Fcall_interactively):
10379 * buffer.c (Fkill_all_local_variables):
10380 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10382 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10383 unconditionally since it does the check itself.
10385 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10387 Fix more problems found by GCC 4.5.2's static checks.
10389 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10390 the first time through the loop, since we know p0 < p1 then.
10391 This also avoids a gcc -Wstrict-overflow warning.
10393 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10394 leading to a memory leak, possible in functions like
10395 load_charset_map_from_file that can allocate an unbounded number
10396 of objects (Bug#8318).
10398 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10399 that could (at least in theory) be that large.
10401 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10402 This is less likely to overflow, and avoids undefined behavior if
10403 overflow does occur. All callers changed. Use strtoul to scan
10404 for the unsigned long integer.
10405 (pint2hrstr): Simplify and tune code slightly.
10406 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10408 * scroll.c (do_scrolling): Work around GCC bug 48228.
10409 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10411 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10412 This also avoids a warning with gcc -Wstrict-overflow.
10413 (validate_x_resource_name): Simplify count usage.
10414 This also avoids a warning with gcc -Wstrict-overflow.
10416 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10419 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10421 * process.c (Fmake_network_process): Use socklen_t, not int,
10422 where POSIX says socklen_t is required in portable programs.
10423 This fixes a porting bug on hosts like 64-bit HP-UX, where
10424 socklen_t is wider than int (Bug#8277).
10425 (Fmake_network_process, server_accept_connection):
10426 (wait_reading_process_output, read_process_output):
10429 * process.c: Rename or move locals to avoid shadowing.
10430 (list_processes_1, Fmake_network_process):
10431 (read_process_output_error_handler, exec_sentinel_error_handler):
10432 Rename or move locals.
10433 (Fmake_network_process): Define label "retry_connect" only if needed.
10434 (Fnetwork_interface_info): Fix pointer signedness.
10435 (process_send_signal): Add cast to avoid pointer signedness problem.
10436 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10437 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10439 Make tparam.h and terminfo.c consistent.
10440 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10441 Include tparam.h instead, since it declares them.
10442 * cm.h (PC): Remove extern decl; tparam.h now does this.
10443 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10444 * terminfo.c: Include tparam.h, to check interfaces.
10445 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10446 (tparam): Adjust signature to match interface in tparam.h;
10447 this removes some undefined behavior. Check that outstring and len
10448 are zero, which they always are with Emacs.
10449 * tparam.h (PC, BC, UP): New extern decls.
10451 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10452 (xftfont_open): Rename locals to avoid shadowing.
10454 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10455 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10456 (OTF_TAG_SYM): Omit macro if not needed.
10457 (ftfont_list): Remove unused local.
10458 (get_adstyle_property, ftfont_pattern_entity):
10459 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10460 Rename locals to avoid shadowing.
10462 * xfont.c (xfont_list_family): Mark var as initialized.
10464 * xml.c (make_dom): Now static.
10466 * composite.c (composition_compute_stop_pos): Rename local to
10468 (composition_reseat_it): Remove unused locals.
10469 (find_automatic_composition, composition_adjust_point): Likewise.
10470 (composition_update_it): Mark var as initialized.
10471 (find_automatic_composition): Mark vars as initialized,
10472 with a FIXME (Bug#8290).
10474 character.h: Rename locals to avoid shadowing.
10475 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10476 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10477 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10478 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10479 to avoid shadowing.
10481 * textprop.c (property_change_between_p): Remove; unused.
10483 * intervals.c (interval_start_pos): Now static.
10485 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10487 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10488 Rename locals to avoid shadowing.
10490 * sound.c (wav_play, au_play, Fplay_sound_internal):
10491 Fix pointer signedness.
10492 (alsa_choose_format): Remove unused local var.
10493 (wav_play): Initialize a variable to 0, to prevent undefined
10494 behavior (Bug#8278).
10496 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10498 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10501 clobbering (Bug#8298).
10502 * sysdep.c (sys_subshell): Likewise.
10503 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10505 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10506 This should get cleaned up, so that child_setup has the
10507 same signature on all platforms.
10509 * callproc.c (call_process_cleanup): Now static.
10510 (relocate_fd): Rename locals to avoid shadowing.
10512 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10514 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10515 not to be necessary, and produces flickering.
10517 2011-03-20 Glenn Morris <rgm@gnu.org>
10519 * config.in: Remove file.
10521 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10523 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10524 are now in src/globals.h.
10525 (syms_of_minibuf): Remove spurious & from previous change.
10527 2011-03-20 Leo Liu <sdl.web@gmail.com>
10529 * minibuf.c (completing-read-function): New variable.
10530 (completing-read-default): Rename from completing-read.
10531 (completing-read): Call completing-read-function.
10533 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10535 * xfaces.c (Fx_load_color_file):
10536 Read color file from absolute filename (bug#8250).
10538 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10540 * makefile.w32-in: Update dependencies.
10542 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10544 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10546 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10548 Fix more problems found by GCC 4.5.2's static checks.
10550 * process.c (make_serial_process_unwind, send_process_trap):
10551 (sigchld_handler): Now static.
10553 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10554 That way, the code declares only the vars that it needs.
10555 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10556 * s/cygwin.h (PTY_ITERATION): Likewise.
10557 * s/darwin.h (PTY_ITERATION): Likewise.
10558 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10560 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10561 * process.c (allocate_pty): Don't declare stb unless it's needed.
10563 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10564 (CONSTANTLIM): Remove; unused.
10565 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10566 Define only if needed.
10568 * unexelf.c (unexec): Name an expression,
10569 to avoid gcc -Wbad-function-cast warning.
10570 Use a different way to cause a compilation error if anyone uses
10571 n rather than nn, a way that does not involve shadowing.
10572 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10574 * deps.mk (unexalpha.o): Remove; unused.
10576 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10577 * unexec.h: New file.
10578 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10579 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10580 Depend on unexec.h.
10581 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10582 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10583 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10584 Change as necessary to match prototype in unexec.h.
10586 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10588 (back_comment, skip_chars): Mark vars as initialized.
10590 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10591 Rename locals to avoid shadowing.
10593 * lread.c (read1): Rewrite so as not to use empty "else".
10594 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10596 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10598 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10599 warning when compiling print.c.
10601 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10602 instead of using an uninitialized var.
10603 (font_sort_entities): Mark var as initialized.
10605 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10607 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10608 pointers to constants.
10609 (font_parse_fcname): Remove unused vars.
10610 (font_delete_unmatched): Now static.
10611 (font_get_spec): Remove; unused.
10612 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10613 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10614 Rename or move locals to avoid shadowing.
10616 * fns.c (require_nesting_list, require_unwind): Now static.
10617 (Ffillarray): Rename locals to avoid shadowing.
10619 * floatfns.c (domain_error2): Define only if needed.
10620 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10622 * alloc.c (mark_backtrace): Move decl from here ...
10623 * lisp.h: ... to here, so that it can be checked.
10625 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10626 (Fdefvar): Rewrite so as not to use empty "else".
10627 (lisp_indirect_variable): Name an expression,
10628 to avoid gcc -Wbad-function-cast warning.
10629 (Fdefvar): Rename locals to avoid shadowing.
10631 * callint.c (quotify_arg, quotify_args): Now static.
10632 (Fcall_interactively): Rename locals to avoid shadowing.
10633 Use const pointer when appropriate.
10635 * lisp.h (get_system_name, get_operating_system_release):
10636 Move decls here, to check interfaces.
10637 * process.c (get_operating_system_release): Move decl to lisp.h.
10638 * xrdb.c (get_system_name): Likewise.
10639 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10640 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10641 some of which prompt warnings from gcc -Wbad-function-cast.
10642 (Fformat_time_string, Fencode_time, Finsert_char):
10643 (Ftranslate_region_internal, Fformat):
10644 Rename or remove local vars to avoid shadowing.
10645 (Ftranslate_region_internal): Mark var as initialized.
10647 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10650 * lisp.h (eassert): Check that the argument compiles, even if
10651 ENABLE_CHECKING is not defined.
10653 * data.c (Findirect_variable): Name an expression, to avoid
10654 gcc -Wbad-function-cast warning.
10655 (default_value, arithcompare, arith_driver, arith_error): Now static.
10656 (store_symval_forwarding): Rename local to avoid shadowing.
10657 (Fmake_variable_buffer_local, Fmake_local_variable):
10658 Mark variables as initialized.
10659 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10661 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10662 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10663 Rename locals to avoid shadowing.
10664 (mark_stack): Move local variables into the #ifdef region where
10666 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10667 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10669 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10670 (GC_STRING_CHARS): Remove; not used.
10671 (Fmemory_limit): Cast sbrk's returned value to char *.
10673 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10674 avoids undefined behavior in theory.
10676 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10678 Use functions, not macros, for up- and down-casing (Bug#8254).
10679 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10680 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10681 to use the following functions instead of these macros.
10682 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10683 EMACS_INT, since callers assume the returned value fits in int.
10684 (upcase1): Likewise, for UPCASE_TABLE.
10685 (uppercasep, lowercasep, upcase): New static inline functions.
10686 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10687 the race-condition problem in the old DOWNCASE.
10689 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10690 Rename locals to avoid shadowing.
10691 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10692 (regex_compile, re_search_2, re_match_2_internal):
10693 Remove unused local vars.
10694 (FREE_VAR): Rewrite so as not to use empty "else",
10695 which gcc can warn about.
10696 (regex_compile, re_match_2_internal): Mark locals as initialized.
10697 (RETALLOC_IF): Define only if needed.
10698 (WORDCHAR_P): Likewise. This one is never needed, but is used
10699 only in a comment talking about a compiler bug, so put inside
10700 the #if 0 of that comment.
10701 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10702 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10705 * search.c (boyer_moore): Rename locals to avoid shadowing.
10706 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10707 (PREV_CHAR_BOUNDARY): Likewise.
10709 * search.c (simple_search): Remove unused var.
10711 * dired.c (compile_pattern): Move decl from here ...
10712 * lisp.h: ... to here, so that it can be checked.
10713 (struct re_registers): New forward decl.
10715 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10717 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10719 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10720 Rename locals to avoid shadowing.
10721 (Fvertical_motion): Mark locals as initialized.
10723 * casefiddle.c (casify_object, casify_region): Now static.
10724 (casify_region): Mark local as initialized.
10726 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10728 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10729 New macros, so that the caller can use some names other than
10730 gcpro1, gcpro2, etc.
10731 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10733 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10734 argument, for consistency with GCPRO2_VAR, etc: it is now the
10735 prefix of the variable, not the variable itself. All uses
10737 * dired.c (directory_files_internal, file_name_completion):
10738 Rename locals to avoid shadowing.
10740 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10741 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10742 dired.c's scmp function, had undefined behavior.
10743 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10744 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10745 * buffer.h: ... to here, because these macros use current_buffer,
10746 and the new implementation with inline functions needs to have
10747 current_buffer in scope now, rather than later when the macros
10749 (downcase, upcase1): New static inline functions.
10750 (DOWNCASE, UPCASE1): Reimplement using these functions.
10751 This avoids undefined behavior in expressions like
10752 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10753 from race conditions in accessing the global variables
10754 case_temp1 and case_temp2.
10755 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10756 * lisp.h (case_temp1, case_temp2): Remove their decls.
10757 * character.h (ASCII_CHAR_P): Move from here ...
10758 * lisp.h: ... to here, so that the inline functions mentioned
10759 above can use them.
10761 * dired.c (directory_files_internal_unwind): Now static.
10763 * fileio.c (file_name_as_directory, directory_file_name):
10764 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10766 (file_name_as_directory): Use const pointers when appropriate.
10767 (Fexpand_file_name): Likewise. In particular, newdir might
10768 point at constant storage, so make it a const pointer.
10769 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10770 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10772 (Fset_file_times, Finsert_file_contents, auto_save_error):
10773 Rename locals to avoid shadowing.
10775 * minibuf.c (choose_minibuf_frame_1): Now static.
10776 (Ftry_completion, Fall_completions): Rename or remove locals
10777 to avoid shadowing.
10779 * marker.c (bytepos_to_charpos): Remove; unused.
10781 * lisp.h (verify_bytepos, count_markers): New decls,
10782 so that gcc does not warn that these functions aren't declared.
10784 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10785 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10786 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10787 (copy_text): Remove unused local var.
10789 * filelock.c (within_one_second): Now static.
10790 (lock_file_1): Rename local to avoid shadowing.
10792 * buffer.c (fix_overlays_before): Mark locals as initialized.
10793 (fix_start_end_in_overlays): Likewise. This function should be
10794 simplified by using pointers-to-pointers, but that's a different
10796 (switch_to_buffer_1): Now static.
10797 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10798 (report_overlay_modification): Rename locals to avoid shadowing.
10800 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10801 Fix pointer signedness issue.
10802 (sys_subshell): Mark local as volatile if checking for lint,
10803 to suppress a gcc -Wclobbered warning that does not seem to be right.
10804 (MAXPATHLEN): Define only if needed.
10806 * process.c (serial_open, serial_configure): Move decls from here ...
10807 * systty.h: ... to here, so that they can be checked.
10809 * fns.c (get_random, seed_random): Move extern decls from here ...
10810 * lisp.h: ... to here, so that they can be checked.
10812 * sysdep.c (reset_io): Now static.
10813 (wait_for_termination_signal): Remove; unused.
10815 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10816 (copy_keymap_item, append_key, push_text_char_description):
10818 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10819 (DENSE_TABLE_SIZE): Remove; unused.
10820 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10821 (describe_map_tree):
10822 Rename locals to avoid shadowing.
10824 * keyboard.c: Declare functions static if they are not used elsewhere.
10825 (echo_char, echo_dash, cmd_error, top_level_2):
10826 (poll_for_input, handle_async_input): Now static.
10827 (read_char, kbd_buffer_get_event, make_lispy_position):
10828 (make_lispy_event, make_lispy_movement, apply_modifiers):
10829 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10830 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10831 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10832 (read_key_sequence, read_char): Mark locals as initialized.
10833 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10835 * keyboard.h (make_ctrl_char): New decl.
10836 (mark_kboards): Move decl here ...
10837 * alloc.c (mark_kboards): ... from here.
10839 * lisp.h (force_auto_save_soon): New decl.
10841 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10842 (DEFINE_DUMMY_FUNCTION): New macro.
10843 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10845 (main): Add casts to avoid warnings
10846 if GCC considers string literals to be constants.
10848 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10850 * dbusbind.c: Pointer signedness fixes.
10851 (xd_signature, xd_append_arg, xd_initialize):
10852 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10853 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10854 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10855 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10857 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10858 if GCC considers string literals to be constants.
10859 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10861 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10863 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10864 (print_preprocess, print_object): New macro to fix last change.
10866 * print.c (print_preprocess): Don't forget font objects.
10868 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10870 * emacs.c (USAGE3): Doc fixes.
10872 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10874 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10877 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10879 * lisp.h (VWindow_system, Qfile_name_history):
10880 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10881 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10882 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10884 * w32select.c: Don't #include "keyboard.h".
10885 (run_protected): Add extern declaration for waiting_for_input.
10887 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10888 * w32console.c (detect_input_pending, read_input_pending)
10889 (encode_terminal_code):
10890 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10891 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10892 (w32_system_caret_y, Qfile_name_history):
10893 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10894 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10895 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10896 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10897 * w32proc.c (Qlocal, report_file_error):
10898 * w32term.c (Vwindow_system, updating_frame):
10899 * w32uniscribe.c (initialized, uniscribe_font_driver):
10900 Remove unneeded extern declarations.
10902 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10904 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10906 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10908 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10909 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10910 These macros can no longer be used for assignment.
10912 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10913 Assign struct members directly, instead of using BUF_BEGV etc.
10914 (record_buffer_markers, fetch_buffer_markers): New functions for
10915 recording and fetching special buffer markers.
10916 (set_buffer_internal_1, set_buffer_temp): Use them.
10918 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10920 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10922 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10923 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10925 * xdisp.c (hscroll_window_tree):
10926 (reconsider_clip_changes): Use PT instead of BUF_PT.
10928 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10930 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10931 $(EMACS_ROOT)/lib/intprops.h.
10933 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10935 Fix more problems found by GCC 4.5.2's static checks.
10937 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10938 to unsigned char * to avoid compiler diagnostic.
10939 (xg_free_frame_widgets): Make it clear that a local variable is
10940 needed only if USE_GTK_TOOLTIP.
10941 (gdk_window_get_screen): Make it clear that this macro is needed
10942 only if USE_GTK_TOOLTIP.
10943 (int_gtk_range_get_value): New function, which avoids a diagnostic
10944 from gcc -Wbad-function-cast.
10945 (xg_set_toolkit_scroll_bar_thumb): Use it.
10946 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10947 diagnostic from gcc -Wbad-function-cast.
10948 (get_utf8_string, xg_get_file_with_chooser):
10949 Rename locals to avoid shadowing.
10950 (create_dialog): Move locals to avoid shadowing.
10952 * xgselect.c (xg_select): Remove unused var.
10954 * image.c (four_corners_best): Mark locals as initialized.
10955 (gif_load): Initialize transparent_p to zero (Bug#8238).
10956 Mark another local as initialized.
10957 (my_png_error, my_error_exit): Mark with NO_RETURN.
10959 * image.c (clear_image_cache): Now static.
10960 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10961 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10962 (x_edge_detection): Remove unnecessary cast that
10963 gcc -Wbad-function-cast diagnoses.
10964 (gif_load): Fix pointer signedness.
10965 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10966 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10968 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10970 Improve quality of tests for time stamp overflow.
10971 For example, without this patch (encode-time 0 0 0 1 1
10972 1152921504606846976) returns the obviously-bogus value (-948597
10973 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10974 reports time overflow. See
10975 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10976 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10977 * editfns.c: Include limits.h and intprops.h.
10978 (TIME_T_MIN, TIME_T_MAX): New macros.
10979 (time_overflow): Move earlier, to before first use.
10980 (hi_time, lo_time): New functions, for an accurate test for
10981 out-of-range times.
10982 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10983 (Fget_internal_run_time): Don't assume time_t fits in int.
10984 (make_time): Use list2 instead of Fcons twice.
10985 (Fdecode_time): More accurate test for out-of-range times.
10986 (check_tm_member): New function.
10987 (Fencode_time): Use it, to test for out-of-range times.
10988 (lisp_time_argument): Don't rely on undefined left-shift and
10989 right-shift behavior when checking for time stamp overflow.
10991 * editfns.c (time_overflow): New function, refactoring common code.
10992 (Fformat_time_string, Fdecode_time, Fencode_time):
10993 (Fcurrent_time_string): Use it.
10995 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10996 * dired.c (make_time): Move to ...
10997 * editfns.c (make_time): ... here.
10998 * systime.h: Note the move.
11000 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11002 * fringe.c (update_window_fringes): Remove unused variables.
11004 * unexmacosx.c (copy_data_segment): Also copy __got section.
11007 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11009 * termcap.c [MSDOS]: Include "msdos.h".
11010 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11011 Constify `char *' arguments and their references according to
11012 prototypes in tparam.h.
11014 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11016 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11017 Adapt all references accordingly.
11019 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11021 2011-03-11 Tom Tromey <tromey@redhat.com>
11023 * buffer.c (syms_of_buffer): Remove obsolete comment.
11025 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11027 * termhooks.h (encode_terminal_code): Declare prototype.
11029 * msdos.c (encode_terminal_code): Don't declare prototype.
11031 * term.c (encode_terminal_code): Now external again, used by
11032 w32console.c and msdos.c.
11034 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11035 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11037 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11039 Fix some minor problems found by GCC 4.5.2's static checks.
11041 * fringe.c (update_window_fringes): Mark locals as initialized
11043 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11045 * alloc.c (mark_fringe_data): Move decl from here ...
11046 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11047 to check its interface.
11048 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11050 * fontset.c (free_realized_fontset): Now static.
11051 (Fset_fontset_font): Rename local to avoid shadowing.
11052 (fontset_font): Mark local as initialized.
11053 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11055 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11057 * xselect.c (x_disown_buffer_selections): Remove; not used.
11058 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11059 (x_own_selection, Fx_disown_selection_internal): Rename locals
11060 to avoid shadowing.
11061 (x_handle_dnd_message): Remove local to avoid shadowing.
11063 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11064 so that the caller can use some name other than gcpro1.
11065 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11066 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11067 (Fx_backspace_delete_keys_p):
11068 Use them to avoid shadowing, and rename vars to avoid shadowing.
11069 (x_decode_color, x_set_name, x_window): Now static.
11070 (Fx_create_frame): Add braces to silence GCC warning.
11071 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11072 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11073 Remove unused locals.
11074 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11075 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11076 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11079 * xterm.h (x_mouse_leave): New decl.
11081 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11082 Remove unused functions.
11083 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11084 (x_calc_absolute_position): Now static.
11085 (XTread_socket): Don't define label "out" unless it's used.
11086 Don't declare local "event" unless it's used.
11087 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11088 unless they are used.
11089 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11090 (x_fatal_error_signal): Remove; not used.
11091 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11092 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11093 (x_error_catcher, x_connection_closed, x_error_handler):
11094 (x_error_quitter, xembed_send_message, x_iconify_frame):
11095 (my_log_handler): Rename locals to avoid shadowing.
11096 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11097 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11099 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11100 Rename or move locals to avoid shadowing.
11101 (tty_defined_color, merge_face_heights): Now static.
11102 (free_realized_faces_for_fontset): Remove; not used.
11103 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11104 does not deduce is never used uninitialized.
11105 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11106 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11108 * terminal.c (store_terminal_param): Now static.
11110 * xmenu.c (menu_highlight_callback): Now static.
11111 (set_frame_menubar): Remove unused local.
11112 (xmenu_show): Rename parameter to avoid shadowing.
11113 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11114 since they might point to immutable storage.
11115 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11116 since it's unused otherwise.
11118 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11119 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11120 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11121 avoids a gcc -Wuninitialized diagnostic.
11122 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11123 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11124 does not deduce are never used uninitialized.
11126 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11128 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11129 * window.c (window_loop, size_window):
11130 (run_window_configuration_change_hook, enlarge_window): Likewise.
11132 * window.c (display_buffer): Now static.
11133 (size_window): Mark variables that gcc -Wuninitialized
11134 does not deduce are never used uninitialized.
11135 * window.h (check_all_windows): New decl, to forestall
11136 gcc -Wmissing-prototypes diagnostic.
11137 * dispextern.h (bidi_dump_cached_states): Likewise.
11139 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11141 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11142 Include <limits.h>.
11143 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11144 and to avoid gcc -Wuninitialized warning.
11145 (load_charset_map): Mark variables that gcc -Wuninitialized
11146 does not deduce are never used uninitialized.
11147 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11149 * coding.c (coding_set_source, coding_set_destination):
11150 Use "else { /* comment */ }" rather than "else /* comment */;"
11151 for clarity, and to avoid gcc -Wempty-body warning.
11152 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11153 a block, when the outer 'i' will do.
11154 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11155 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11156 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11157 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11158 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11159 Rename locals to avoid shadowing.
11160 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11161 * coding.c (emacs_mule_char, encode_invocation_designation):
11162 Now static, since they're not used elsewhere.
11163 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11164 (decode_coding_object, encode_coding_object, detect_coding_system):
11165 (decode_coding_emacs_mule): Mark variables that gcc
11166 -Wuninitialized does not deduce are never used uninitialized.
11167 (detect_coding_iso_2022): Initialize a local variable that might
11168 be used uninitialized. Leave a FIXME because it's not clear that
11169 this initialization is needed. (Bug#8211)
11170 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11171 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11172 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11173 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11174 Remove unused macros.
11176 * category.c (hash_get_category_set): Remove unused local var.
11177 (copy_category_table): Now static, since it's not used elsewhere.
11178 * character.c (string_count_byte8): Likewise.
11180 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11181 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11183 * chartab.c (copy_sub_char_table): Now static, since it's not used
11185 (sub_char_table_ref_and_range, char_table_ref_and_range):
11186 Rename locals to avoid shadowing.
11187 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11189 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11190 (BIDI_BOB): Remove unused macro.
11192 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11193 deduce are never used uninitialized.
11194 * term.c (encode_terminal_code): Likewise.
11196 * term.c (encode_terminal_code): Now static. Remove unused local.
11198 * tparam.h: New file.
11199 * term.c, tparam.h: Include it.
11200 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11201 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11202 Move these decls to tparam.h, and make them agree with what
11203 is actually in tparam.c. The previous trick of using incompatible
11204 decls in different modules does not conform to the C standard.
11205 All callers of tparam changed to use tparam's actual API.
11206 * tparam.c (tparam1, tparam, tgoto):
11207 Use const pointers where appropriate.
11209 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11210 * cm.h (struct cm): Likewise.
11211 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11212 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11213 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11214 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11215 (turn_on_face, init_tty): Likewise.
11216 * termchar.h (struct tty_display_info): Likewise.
11218 * term.c (term_mouse_position): Rename local to avoid shadowing.
11220 * alloc.c (mark_ttys): Move decl from here ...
11221 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11223 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11225 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11227 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11229 * search.c (compile_pattern_1): Remove argument regp, unused since
11230 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11231 (compile_pattern): Don't pass it.
11233 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11235 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11236 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11238 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11240 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11242 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11243 gdk_window_get_screen, gdk_window_get_geometry,
11244 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11245 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11246 (xg_get_pixbuf_from_pixmap): New function.
11247 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11248 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11249 Call xg_get_pixbuf_from_pixmap instead of
11250 gdk_pixbuf_get_from_drawable.
11251 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11252 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11253 (xg_check_special_colors): Use GtkStyleContext and its functions
11255 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11256 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11257 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11258 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11259 Call gtk_widget_get_preferred_size.
11260 (xg_frame_resized): gdk_window_get_geometry only takes 5
11262 (xg_win_to_widget, xg_event_is_for_menubar):
11263 Call gdk_x11_window_lookup_for_display.
11264 (xg_set_widget_bg): New function.
11265 (delete_cb): New function.
11266 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11267 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11268 (xg_set_background_color): Call xg_set_widget_bg.
11269 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11270 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11271 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11272 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11274 (update_frame_tool_bar): Call gtk_widget_hide.
11275 (xg_initialize): Use GDK_KEY_g.
11277 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11279 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11281 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11282 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11283 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11285 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11287 * w32xfns.c (select_palette): Check success of RealizePalette against
11288 GDI_ERROR, not zero.
11290 See ChangeLog.11 for earlier changes.
11292 ;; Local Variables:
11296 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11298 This file is part of GNU Emacs.
11300 GNU Emacs is free software: you can redistribute it and/or modify
11301 it under the terms of the GNU General Public License as published by
11302 the Free Software Foundation, either version 3 of the License, or
11303 (at your option) any later version.
11305 GNU Emacs is distributed in the hope that it will be useful,
11306 but WITHOUT ANY WARRANTY; without even the implied warranty of
11307 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11308 GNU General Public License for more details.
11310 You should have received a copy of the GNU General Public License
11311 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.